text:
prevent thread report crash for a member when workspace is deleted by owner

Details

Fixed Issues

$ https://github.com/Expensify/App/issues/28336
PROPOSAL: https://github.com/Expensify/App/issues/28336#issuecomment-1737838664
Tests

Create a workspace from user A
Invite user B to this workspace
From user B, send a message in #announce room
From user B, reply in thread for this message
From user A, delete the workspace
Verify that the thread screen is not crashed from user B

[x] Verify that no errors appear in the JS console

Offline tests

Create a workspace from user A
Invite user B to this workspace
From user B, send a message in #announce room
From user B, reply in thread for this message
From user A, delete the workspace
Verify that the thread screen is not crashed from user B

QA Steps

Create a workspace from user A
Invite user B to this workspace
From user B, send a message in #announce room
From user B, reply in thread for this message
From user A, delete the workspace
Verify that the thread screen is not crashed from user B

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web
https://github.com/Expensify/App/assets/102477862/9c01a3b5-22a4-4f04-8e63-d24ed11b11b4

Mobile Web - Chrome
https://github.com/Expensify/App/assets/102477862/f8f58520-a0a1-41d4-956e-2b0c3b3be07b

Mobile Web - Safari
https://github.com/Expensify/App/assets/102477862/b4db931e-5a26-4e15-b2d2-c53e88faeacc

Desktop
https://github.com/Expensify/App/assets/102477862/820333c6-a526-4613-9e8a-c0bf0d1b2176

iOS
https://github.com/Expensify/App/assets/102477862/54fc889a-312f-4c93-ba29-8541acd6cec8

Android
https://github.com/Expensify/App/assets/102477862/c88b5c35-3a80-49fa-ba73-17d346cb2f96

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/mountiny in version: 1.3.77-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

QA mentioned this is still not fixed in desktop. Can you please double check @allroundexperts @c3024 thanks!

🚀 Deployed to production by https://github.com/mountiny in version: 1.3.77-7 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

authors: OSBotify c3024 mountiny


text:
[NO QA] [TS migration] Migrate remaining Test files to TypeScript #38536

Details

Fixed Issues

$ https://github.com/Expensify/App/issues/38536
PROPOSAL:
Tests

[x] Verify that no errors appear in the JS console

Offline tests

QA Steps

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

Reviewer Checklist

[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[x] I verified testing steps are clear and they cover the changes made in this PR

[x] I verified the steps for local testing are in the Tests section
[x] I verified the steps for Staging and/or Production testing are in the QA steps section
[x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I checked that screenshots or videos are included for tests on all platforms
[x] I included screenshots or videos for tests on all platforms
[x] I verified tests pass on all platforms & I tested again on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[x] I verified proper code patterns were followed (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I verified that this PR follows the guidelines as stated in the Review Guidelines
[x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/AndrewGable in version: 1.4.56-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/yuwenmemon in version: 1.4.56-8 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

source: gharchive/pull-request

authors: OSBotify getusha pasyukevich

repo: Expensify/App

license: MIT

license_type: permissive

license_source: github-api


text:
fix: Clicking on a very long parent child category

Details

Fixed Issues

$ https://github.com/Expensify/App/issues/41850
PROPOSAL: https://github.com/Expensify/App/issues/41850#issuecomment-2101972590
Tests

Pre-conditions:

Create a workspace
Create a category name with long parent child relationship (e.g: "A: Very: Long: Category: List: Done: A: Very: Long: Category: List: Done: A: Very: Long: Category: List: Done: A: Very: Long: Category: List: Done: A: Very: Long: Category: List: Done"

Open workspace chat
Click on Plus icon inside compose box > Submit expense > Manual > Enter amount > Click next
Open category list
Click somewhere down the long category list but do not use the mouse scroll wheel
Verify that: Nothing should happen

[x] Verify that no errors appear in the JS console

Offline tests

QA Steps

Pre-conditions:

Create a workspace
Create a category name with long parent child relationship (e.g: "A: Very: Long: Category: List: Done: A: Very: Long: Category: List: Done: A: Very: Long: Category: List: Done: A: Very: Long: Category: List: Done: A: Very: Long: Category: List: Done"

Open workspace chat
Click on Plus icon inside compose box > Submit expense > Manual > Enter amount > Click next
Open category list
Click somewhere down the long category list but do not use the mouse scroll wheel
Verify that: Nothing should happen

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

https://github.com/Expensify/App/assets/161821005/352f7516-a87b-49a0-ada6-c3675d4af93d

Android: mWeb Chrome

https://github.com/Expensify/App/assets/161821005/730633a8-5ab7-43c9-9c52-15cc2ea72ef6

iOS: Native

https://github.com/Expensify/App/assets/161821005/01750527-afca-4ec1-bad8-95310affae26

iOS: mWeb Safari

https://github.com/Expensify/App/assets/161821005/20c4da06-6972-415a-8c9b-ad75bc5538cd

MacOS: Chrome / Safari

https://github.com/Expensify/App/assets/161821005/1be5ffd6-fb7b-48bf-bc0f-fd3694b84049

MacOS: Desktop

https://github.com/Expensify/App/assets/161821005/9322cc65-60a7-497b-afd0-f6c525f780d9

🚀 Deployed to staging by https://github.com/chiragsalian in version: 1.4.76-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/Beamanator in version: 1.4.76-7 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

authors: OSBotify nkdengineer


text:
fix scroll bar on IOS

Details

This pr migrates src/components/Form/FormProvider from withOnyx to useOnyx and thanks to that fixes issue with scroll bar on IOS.
Fixed Issues

$https://github.com/Expensify/App/issues/49456
PROPOSAL:
Tests

Open App

Navigate to search/filters

Open Date filter

Verify that scroll bar placement is correct

Verify that different filters work correctly

[x] Verify that no errors appear in the JS console

Offline tests

QA Steps

Open App

Navigate to search/filters

Open Date filter

Verify that scroll bar placement is correct

Verify that different filters work correctly

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

https://github.com/user-attachments/assets/087fc527-7bab-4e98-8fc2-b5377f82bce9

Android: mWeb Chrome

https://github.com/user-attachments/assets/74823ce9-6657-4db5-aeb3-d09c804c1139

iOS: Native

https://github.com/user-attachments/assets/262825ba-6632-4882-9bb6-dde5069079cb

iOS: mWeb Safari

https://github.com/user-attachments/assets/e0376808-ea17-415a-a285-a4d933d66f0c

MacOS: Chrome / Safari

https://github.com/user-attachments/assets/062d0dd3-0c2c-428a-bf04-b815daa9a726

MacOS: Desktop

https://github.com/user-attachments/assets/ee3b9ae8-b9ef-4482-90b9-ba4e07810dc2

@ishpaul777 Done


text:
🍒 Cherry pick PR #5584 to staging 🍒

🍒 Cherry pick https://github.com/Expensify/App/pull/5584 to staging 🍒

🚀 Cherry-picked to staging by @OSBotify in version: 1.1.3-1 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

🚀 Deployed to production by @timszot in version: 1.1.3-1 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


text:
fix: newline via updating the count first before marking the messages as read

Details

Fixed Issues

$ https://github.com/Expensify/App/issues/6424
Tests | QA Steps

Go to staging.new.expensify.com on two devices (P & Q).
Login with accounts A and B respectively.
Go to any chat other than between A and B (1:1)
Send messages from A to B on device P.
Enter the! 1:1 conversation on device Q  that has unread messages and verify there is a green line indicating the New Messages.

Tested On

[x] Web
[x] Mobile Web
[x] Desktop
[x] iOS
[x] Android

Screenshots

Web

https://user-images.githubusercontent.com/24370807/143273471-78e1d489-8f3d-489e-8b24-ef4a9fab98b8.mp4
Mobile Web

Desktop

iOS

Android

....on the way

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

Ops @johnmlee101 this needs to be CP'ed.

Running!

🚀 Cherry-picked to staging by @johnmlee101 in version: 1.1.16-7 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

🚀 Deployed to production by @roryabraham in version: 1.1.16-10 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to staging by @johnmlee101 in version: 1.1.16-11 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by @roryabraham in version: 1.1.17-7 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

authors: OSBotify johnmlee101 parasharrajat


text:
Make the current password field also submittable via Enter

Details

A very small UI change which makes the Current password field actionable via Enter.
On the form to change password, this change would enable user to submit the form using Enter key also when the Current password field would be focused. This is for scenario, when user enters both, current and new password, but realizes they entered the current password wrong, then they can submit the form while focusing the current password too.
If the New password is not filled in, validation does not pass.
Fixed Issues

$ https://github.com/Expensify/App/issues/6823
Tests

Go to the Change password page
Type in your Current password
Type in your New Password
Focus back to the Current password field and hit enter.
Make sure the form has been submitted

QA Steps

Go to the Change password page
Type in your Current password
Type in your New Password
Focus back to the Current password field and hit enter.
Make sure the form has been submitted

Tested On

[x] Web
[ ] Mobile Web
[ ] Desktop
[ ] iOS
[ ] Android

Screenshots

Web

Mobile Web

Desktop

iOS

Android

Sorry @nickmurray47, this should have been draft PR at this point.

@nickmurray47 This is ready for a review. It is a simple change and it is same as on the other password field in the form: https://github.com/Expensify/App/pull/6904/files#diff-b4474bebdf5744f78c9eded74e6bd3e4d2723040f750e573f4ef4bddfe00481bL189. I have tested it the other day, but unfortunately I did not make screenshots or video, but I believe this is such a simple change it is not required.

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by @nickmurray47 in version: 1.1.24-19 🚀

platform
result

🤖 android 🤖
failure ❌

🖥 desktop 🖥
failure ❌

🍎 iOS 🍎
failure ❌

🕸 web 🕸
failure ❌

🚀 Deployed to production by @francoisl in version: 1.1.24-19 🚀

platform
result

🤖 android 🤖
failure ❌

🖥 desktop 🖥
failure ❌

🍎 iOS 🍎
failure ❌

🕸 web 🕸
failure ❌

authors: OSBotify mountiny


text:
Randomly Logged Out of Desktop App

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:
Was idling. Got logged out.
Expected Result:
Stay logged in.
Actual Result:
Logged out.
Workaround:
Sign back in
Platform:
Desktop App
Version Number: Version 1.0.70-8 (1.0.70-8)
Logs:

Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
View all open jobs on Upwork

Triggered auto assignment to @laurenreidexpensify (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

Looks possibly related to the app trying to update itself.

Triggered auto assignment to @NicMendonca (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

@NicMendonca melvin loves giving me assignments 5min before OOO 😅 reassigning thanks

Triggered auto assignment to @mountiny (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

No update today!

@marcaaron Can this be replicated on dev version? I am using the Desktop app on my Mac and it has never signed off.
Sorry if it is clear and I am missing something here but do you have any hints, how to reproduce it locally? Thank you very much! :)

Nope. I can't reproduce it and it has only happened once.

@mountiny This looks related to https://github.com/electron/electron/issues/7476
Shouldn't happen on prod if our packager is signing the app, but if we don't want this to happen in dev we should sign node_modules/.../Electron.app in our scripts

To clarify, this was experienced in the release build of the app and not while on dev.

Since the issue seems non-reproducible at the moment and happened only once as far as we know, I will degrade its priority label to Monthly and we will see if this error occurs again in next month, potentially closing this issue later if no new occurrences happen.

Just happened to me, was in the middle of typing a message, logs below.  Desktop Version 1.0.73-3 (1.0.73-3) (most recent production version).
size
Object
app-74d3ea1….bundle.js:143 Redirecting to Sign In because we failed to reauthenticate
Object
app-74d3ea1….bundle.js:143 [Pusher] Attempted to unsubscribe or unbind from a channel,
        but Pusher-JS has no knowledge of it 0
Object
app-74d3ea1….bundle.js:143 [Pusher] Unable to reconnect since Pusher instance does not yet exist.
w_5e2c6fdc6944ad66e1…e661.png.1024.jpg:1 Failed to load resource: the server responded with a status of 500 ()
app-74d3ea1….bundle.js:143 Unable to fetch image to calculate size
Object
w_0faa3ead2911202b3f…e78a.png.1024.jpg:1 Failed to load resource: the server responded with a status of 500 ()
app-74d3ea1….bundle.js:143 Unable to fetch image to calculate size
Object
DevTools failed to load SourceMap: Could not parse content for app://-/app-74d3ea1….bundle.js.map: Unexpected end of JSON input
DevTools failed to load SourceMap: Could not parse content for app://-/pdf.worker.entry-b22bab8….bundle.worker.js.map: Unexpected end of JSON input

This might be actually related to Servers being down now.

Yeah. I faced it too. Server is down.

If the servers are down, is there a way that we can have e.cash default to offline mode so that it doesn't log users out?

@marcaaron do you think there should be separate issue for "When site is down, go into offline mode"? If so, I can create one

Kicking user out without any notification is very bad UX for me.

Created a separate internal issue to solely focus on 'site down > user logged out' https://github.com/Expensify/Expensify/issues/168965

@puneetlath Was able to reproduce this https://expensify.slack.com/archives/C01GTK53T8Q/p1625069032270200

just got signed out of Expensify.cash on mac desktop unexpectedly

I'm going to put this in planning while we wait to see if matt's internal issue resolves it

This happened to me again similar logs.
10:40:37.844 › Checking for update
10:40:38.303 › Update for version 1.0.79-1 is not available (latest version: 1.0.79-1, downgrade is disallowed).
11:40:37.722 › Checking for update
11:40:38.337 › Update for version 1.0.79-1 is not available (latest version: 1.0.79-1, downgrade is disallowed).
3app-ee639f401a1c0000b5d7.bundle.js:143 [LOCAL_NOTIFICATION] Creating notification
app-ee639f401a1c0000b5d7.bundle.js:143 [Pusher] Unsubscribing from channel true Object
app-ee639f401a1c0000b5d7.bundle.js:143 [Pusher] Attempting to subscribe to channel true Object
app-ee639f401a1c0000b5d7.bundle.js:143 Skipping request and re-queueing:  Objectcommand: "Report_UpdateLastRead"doNotRetry: falseisQueuePaused: true__proto__: Object
app-ee639f401a1c0000b5d7.bundle.js:143 Skipping request and re-queueing:  Objectcommand: "Report_UpdateLastRead"doNotRetry: falseisQueuePaused: true__proto__: Object
app-ee639f401a1c0000b5d7.bundle.js:143 Skipping request and re-queueing:  Objectcommand: "Report_UpdateLastRead"doNotRetry: falseisQueuePaused: true__proto__: Object
app-ee639f401a1c0000b5d7.bundle.js:143 Skipping request and re-queueing:  Objectcommand: "Report_UpdateLastRead"doNotRetry: falseisQueuePaused: true__proto__: Object
app-ee639f401a1c0000b5d7.bundle.js:143 Skipping request and re-queueing:  Objectcommand: "Report_UpdateLastRead"doNotRetry: falseisQueuePaused: true__proto__: Object
app-ee639f401a1c0000b5d7.bundle.js:143 Redirecting to Sign In because we failed to reauthenticate Object
app-ee639f401a1c0000b5d7.bundle.js:143 [Pusher] Attempted to unsubscribe or unbind from a channel,
        but Pusher-JS has no knowledge of it 0 Object
app-ee639f401a1c0000b5d7.bundle.js:143 [Pusher] Attempting to disconnect from Pusher before initialisation has occurred, ignoring.
app-ee639f401a1c0000b5d7.bundle.js:143 A request was made without an authToken Object
app-ee639f401a1c0000b5d7.bundle.js:143 Skipping request and re-queueing:  Object
app-ee639f401a1c0000b5d7.bundle.js:143 [Pusher] Attempting to disconnect from Pusher before initialisation has occurred, ignoring.
app-ee639f401a1c0000b5d7.bundle.js:143 Redirecting to Sign In because we failed to reauthenticate Objectcommand: "Push_Authenticate"error: "passwordForm.error.unableToResetPassword"__proto__: Object
app-ee639f401a1c0000b5d7.bundle.js:143 [Pusher] Unable to reconnect since Pusher instance does not yet exist.
app-ee639f401a1c0000b5d7.bundle.js:143 [Pusher] Attempting to disconnect from Pusher before initialisation has occurred, ignoring.
app-ee639f401a1c0000b5d7.bundle.js:143 A request was made without an authToken Objectcommand: "Report_GetHistory"parameters: {}__proto__: Object
DevTools failed to load SourceMap: Could not parse content for app://-/app-ee639f401a1c0000b5d7.bundle.js.map: Unexpected end of JSON input
DevTools failed to load SourceMap: Could not parse content for app://-/pdf.worker.entry-b22bab8941f6233eb7c1.bundle.worker.js.map: Unexpected end of JSON input

@marcaaron, this Monthly task hasn't been acted upon in 6 weeks; closing.
If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

Still happening
https://expensify.slack.com/archives/C01GTK53T8Q/p1633027687314200

Maybe we can keep this closed.

source: gharchive/issue

authors: MelvinBot isagoico jboniface laurenreidexpensify mallenexpensify marcaaron mountiny parasharrajat rdjuric


text:
[WIP] Use StackNavigator for ReportScreen to fix browser history

Details
Rough WIP / experiment that attempts to fix the issue of browser history not working correctly on web. we can't push new entries onto the browser history stack because we are navigating with replace and the screen we want to push is a drawer screen.
There has some problems still and ideally there is a better solution.
Fixed Issues
Fixes GH_LINK
Tests

QA Steps

Tested On

[ ] Web
[ ] Mobile Web
[ ] Desktop
[ ] iOS
[ ] Android

Screenshots

Web

Mobile Web

Desktop

iOS

Android

Closing this PR in favor of another idea here -> https://github.com/Expensify/Expensify.cash/pull/2404


text:
Fix: Remove accidental change to package.json browser field

@neil-marcellini
Details

During https://github.com/Expensify/react-native-onyx/pull/437 i accidentally added a change to package.json, which was just for testing the PR locally. This PR reverts the change.
Related Issues

GH_LINK
Automated Tests

Manual Tests

Author Checklist

[x] I linked the correct issue in the ### Related Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

@neil-marcellini i think we can merge this right away?
Sorry for the unintended change :/

bump @neil-marcellini :)

repo: Expensify/react-native-onyx


text:
Update logback-classic to 1.4.0

Updates ch.qos.logback:logback-classic from 1.2.11 to 1.4.0.
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "ch.qos.logback", artifactId = "logback-classic" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "@monthly" },
  dependency = { groupId = "ch.qos.logback", artifactId = "logback-classic" }
}]

labels: library-update, early-semver-minor, semver-spec-minor, commit-count:1

Superseded by #586.

repo: ExposuresProvider/cam-kp-api


text:
Notification sound.

Any chance for other sounds of trade req? Also option for increase sound volume? I rly wanna hear notification sound when i am afk in other room.

will be done in future updates

authors: Exslims Hiffix

repo: Exslims/MercuryTrade

license: mit

license_source: bigquery


text:
Support is needed for requests version < 2.9.1

@zancas
Issues:
Fixes #92
Problem:
We need to support older versions of requests (older than 2.9.1) to be
compliant with some Openstack clients that use older versions of
requests.
Analysis:
Inspecting the requests version and suppressing
requests.packages.urllib3.disable_warnings() call if the current version
of requests is less than 2.9.1.
Tests:
All unit tests and functional tests pass

Merging, as @zancas reviewed this offline.


text:
[DOC] liberty installation instructions

Hi
If I install liberty packages of LBaaS, in short installing the following packages
root@dc8-1f-66-b8-bd-ca:~ # ls -l *.rpm
-rw-r--r-- 1 root root  15528 Aug  3 14:50 f5-icontrol-rest-1.0.9-1.el7.noarch.rpm
-rw-r--r-- 1 root root 172680 Oct 10 14:49 f5-openstack-agent-8.1.0-1.el7.noarch.rpm
-rw-r--r-- 1 root root  47316 Oct 11 10:44 f5-openstack-lbaasv2-driver-8.1.0-1.el7.noarch.rpm
-rw-r--r-- 1 root root 168428 Sep 27 14:16 f5-sdk-1.5.0-1.el7.noarch.rpm

and then I try to install the Heat plugin using the liberty's instructions
pip install f5-openstack-heat-plugins
It does install the latest version rather than the supported version indicated in the web page:
http://f5-openstack-heat-plugins.readthedocs.io/en/liberty/
Indeed it does uninstall the previously f5-sdk package:

root@dc8-1f-66-b8-bd-ca:~ # pip install f5-openstack-heat-plugins
Downloading/unpacking f5-openstack-heat-plugins
  Downloading f5-openstack-heat-plugins-9.0.2.tar.gz
  Running setup.py egg_info for package f5-openstack-heat-plugins

Downloading/unpacking f5-sdk==1.0.0 (from f5-openstack-heat-plugins)
  Downloading f5-sdk-1.0.0.tar.gz (62kB): 62kB downloaded
  Running setup.py egg_info for package f5-sdk

    warning: no files found matching 'README.md'
    warning: no files found matching 'SUPPORT'
Requirement already satisfied (use --upgrade to upgrade): f5-icontrol-rest>=1.0.7 in /usr/lib/python2.7/site-packages (from f5-sdk==1.0.0->f5-openstack-heat-plugins)
Requirement already satisfied (use --upgrade to upgrade): requests>=2.5.0 in /usr/lib/python2.7/site-packages (from f5-icontrol-rest>=1.0.7->f5-sdk==1.0.0->f5-openstack-heat-plugins)
Installing collected packages: f5-openstack-heat-plugins, f5-sdk
  Running setup.py install for f5-openstack-heat-plugins

  Found existing installation: f5-sdk 1.5.0
    Uninstalling f5-sdk:
      Successfully uninstalled f5-sdk
  Running setup.py install for f5-sdk

    warning: no files found matching 'README.md'
    warning: no files found matching 'SUPPORT'
Successfully installed f5-openstack-heat-plugins f5-sdk
Cleaning up...

I think it should be the following command but I get an error
root@dc8-1f-66-b8-bd-ca:~ # pip install git+https://github.com/F5Networks/f5-openstack-heat@liberty
Downloading/unpacking git+https://github.com/F5Networks/f5-openstack-heat@liberty
  Cloning https://github.com/F5Networks/f5-openstack-heat (to liberty) to /tmp/pip-2c4NxQ-build
  Running setup.py egg_info for package from git+https://github.com/F5Networks/f5-openstack-heat@liberty
    Traceback (most recent call last):
      File "<string>", line 16, in <module>
    IOError: [Errno 2] No such file or directory: '/tmp/pip-2c4NxQ-build/setup.py'
    Complete output from command python setup.py egg_info:
    Traceback (most recent call last):

  File "<string>", line 16, in <module>

IOError: [Errno 2] No such file or directory: '/tmp/pip-2c4NxQ-build/setup.py'

----------------------------------------
Cleaning up...
Command python setup.py egg_info failed with error code 1 in /tmp/pip-2c4NxQ-build
Storing complete log in /root/.pip/pip.log

@alonsocamaro: You can do pip install f5-openstack-heat-plugins==8.0.3, which will give you the exact version of the liberty release. I get the same failure doing the pip install from github directly. This is a valid issue.

Yep, it did work but I find that it uninstalls the sdk version necessary for LBaaSv2
root@dc8-1f-66-b8-bd-ca:~ # pip install f5-openstack-heat-plugins==8.0.3
Downloading/unpacking f5-openstack-heat-plugins==8.0.3
  Downloading f5-openstack-heat-plugins-8.0.3.tar.gz
  Running setup.py egg_info for package f5-openstack-heat-plugins

Downloading/unpacking f5-sdk==1.0.0 (from f5-openstack-heat-plugins==8.0.3)
  Downloading f5-sdk-1.0.0.tar.gz (62kB): 62kB downloaded
  Running setup.py egg_info for package f5-sdk

    warning: no files found matching 'README.md'
    warning: no files found matching 'SUPPORT'
Requirement already satisfied (use --upgrade to upgrade): f5-icontrol-rest>=1.0.7 in /usr/lib/python2.7/site-packages (from f5-sdk==1.0.0->f5-openstack-heat-plugins==8.0.3)
Requirement already satisfied (use --upgrade to upgrade): requests>=2.5.0 in /usr/lib/python2.7/site-packages (from f5-icontrol-rest>=1.0.7->f5-sdk==1.0.0->f5-openstack-heat-plugins==8.0.3)
Installing collected packages: f5-openstack-heat-plugins, f5-sdk
  Running setup.py install for f5-openstack-heat-plugins

  Found existing installation: f5-sdk 1.5.0
    Uninstalling f5-sdk:
      Successfully uninstalled f5-sdk
  Running setup.py install for f5-sdk

    warning: no files found matching 'README.md'
    warning: no files found matching 'SUPPORT'
Successfully installed f5-openstack-heat-plugins f5-sdk
Cleaning up...

Yes, we can't guarantee that they aren't mutually exclusive.

This is not good for the customers...
... and is 1.5.0 backwards compatible with 1.0.0? If it is compatible it would be just about adjusting the dependencies in the pip install

Yes 1.5 should be backwards compatible with 1.0.0. We'll talk about supporting this and see where we get.

Would you say that as a workaround the following is acceptable?

install f5-heat
pip uninstall f5-sdk
install lbaasv2 all components (which includes f5-sdk 1.5.0)

That is untested by us, but it looks sound.

Hi again Paul
Additionally... could this issue be also tagged as a documentation bug too?
I think that all pip install commands shown should explicitly indicate the version to install.
Otherwise users might unexpectedly install a different version (the latest). Could this be a policy in our installation instructions for any "pip install" ?
Thanks

authors: alonsocamaro pjbreaux


text:
Display number of filtered out games

Closes #2832

Looks good, but it shows the number of still displayed games instead of the filtered out games. In your screenshot I would expect the text to read "3 of 11 items are filtered out"

I just tested it and it works.
I noticed to issues that are not directly related to the displaying of the game numbers though:

The clear button only works correctly for the live replays. In the custom games tab it only becomes active when filtering game mods and then it also only clears the game mod setting.
Only the filters not affected by the clear button survive a restart of the client.
I guess both things are related and the underlying cause is that the client stores these settings in the preferences.
It would be nice if the client stored the settings but the button still allowed you to clear all settings easily

I guess both things are related and the underlying cause is that the client stores these settings in the preferences.

That is right.

It would be nice if the client stored the settings but the button still allowed you to clear all settings easily

Done

authors: BlackYps Marc-Spector

repo: FAForever/downlords-faf-client


text:
Setup pre commit hook for ruff

[x] Add pre-commit dep
[x] Add hook for ruff
[x] Add readme for pre-commit

Here you go @lukaspie @blueraft

repo: FAIRmat-NFDI/readers-xrd


text:
使用 config-node-expand-example.toml 文件扩容时没有生成node.pem文件

使用两台服务器部署了一个host模式的群组网络，按照官网教程用config-node-expand-example.toml这个文件対该群组进行了节点扩容 ，然后就直接报错了。说我没节点证书。经官方技术人员排查确有BUG存在，望修复。

这个问题预计会在周五之前修复，修复之后会在这里知会一下。

问题已经修复，分支在release-3.2.1，可以使用该分支的代码
https://github.com/FISCO-BCOS/FISCO-BCOS/tree/release-3.2.1

repo: FISCO-BCOS/FISCO-BCOS


text:
Design of a basic tracker of performance in your dedicated mini_core

Design a basic tracker to show the core performance in terms of IPC (Instructions Per Cycle):
The tracker will consist of two parts:
Counters:

Increment the clock cycle counter on each clock cycle.
Increment the valid instruction counter each time a valid instruction is executed.

IPC Calculation and Display:

Upon detecting an EBREAK instruction, divide the valid instruction counter by the clock cycle counter.
Display the resulting IPC value.

done. pushed to mini_core_trackers branch.


text:
pip install misaka setup error in ubuntu 15.10 64-bit

Collecting misaka
  Using cached misaka-2.0.0.tar.gz
    Complete output from command python setup.py egg_info:
    gcc: error: i386: No such file or directory
    gcc: error: x86_64: No such file or directory
    gcc: error: unrecognized command line option ‘-arch’
    gcc: error: unrecognized command line option ‘-arch’
    gcc: error: unrecognized command line option ‘-Qunused-arguments’
    gcc: error: i386: No such file or directory
    gcc: error: x86_64: No such file or directory
    gcc: error: unrecognized command line option ‘-arch’
    gcc: error: unrecognized command line option ‘-arch’
    gcc: error: unrecognized command line option ‘-Qunused-arguments’

        No working compiler found, or bogus compiler options
        passed to the compiler from Python's distutils module.
        See the error messages above.
        (If they are about -mno-fused-madd and you are on OS/X 10.8,
        see http://stackoverflow.com/questions/22313407/ .)
    Traceback (most recent call last):
      File "<string>", line 20, in <module>
      File "/tmp/pip-build-Ttx3lI/misaka/setup.py", line 68, in <module>
        cffi_modules=['build_ffi.py:ffi'],
      File "/usr/lib/python2.7/distutils/core.py", line 111, in setup
        _setup_distribution = dist = klass(attrs)
      File "/home/zeno/mostfun/june/venv/local/lib/python2.7/site-packages/setuptools/dist.py", line 268, in __init__
        self.fetch_build_eggs(attrs['setup_requires'])
      File "/home/zeno/mostfun/june/venv/local/lib/python2.7/site-packages/setuptools/dist.py", line 313, in fetch_build_eggs
        replace_conflicting=True,
      File "/home/zeno/mostfun/june/venv/local/lib/python2.7/site-packages/pkg_resources/__init__.py", line 836, in resolve
        dist = best[req.key] = env.best_match(req, ws, installer)
      File "/home/zeno/mostfun/june/venv/local/lib/python2.7/site-packages/pkg_resources/__init__.py", line 1081, in best_match
        return self.obtain(req, installer)
      File "/home/zeno/mostfun/june/venv/local/lib/python2.7/site-packages/pkg_resources/__init__.py", line 1093, in obtain
        return installer(requirement)
      File "/home/zeno/mostfun/june/venv/local/lib/python2.7/site-packages/setuptools/dist.py", line 380, in fetch_build_egg
        return cmd.easy_install(req)
      File "/home/zeno/mostfun/june/venv/local/lib/python2.7/site-packages/setuptools/command/easy_install.py", line 638, in easy_install
        return self.install_item(spec, dist.location, tmpdir, deps)
      File "/home/zeno/mostfun/june/venv/local/lib/python2.7/site-packages/setuptools/command/easy_install.py", line 668, in install_item
        dists = self.install_eggs(spec, download, tmpdir)
      File "/home/zeno/mostfun/june/venv/local/lib/python2.7/site-packages/setuptools/command/easy_install.py", line 851, in install_eggs
        return self.build_and_install(setup_script, setup_base)
      File "/home/zeno/mostfun/june/venv/local/lib/python2.7/site-packages/setuptools/command/easy_install.py", line 1079, in build_and_install
        self.run_setup(setup_script, setup_base, args)
      File "/home/zeno/mostfun/june/venv/local/lib/python2.7/site-packages/setuptools/command/easy_install.py", line 1067, in run_setup
        raise DistutilsError("Setup script exited with %s" % (v.args[0],))
    distutils.errors.DistutilsError: Setup script exited with 1

    ----------------------------------------
Command "python setup.py egg_info" failed with error code 1 in /tmp/pip-build-Ttx3lI/misaka

i tried to use pip install misaka on debian, it's no problem. git clone source and build it on ubuntu 15.04, also done.

I see No working compiler found, or bogus compiler options. Did you install gcc on Ubuntu?

certainly... i'm confident that.

i have built it from source.

Is the path to the gcc executables also in the $PATH environment variable?
I'll setup an Ubuntu vm later today (I just woke up) and see if I can reproduce this issue.

path has no problem, i can use pip to install uwsgi by gcc.

Any update on this in order to solve it, @ethe ?

@ReneFroger Nope, you can try install misaka by building from source.

I just tested on Ubuntu and Xubuntu and everything works.
I had to install python-dev and libffi-dev.

I'm confident that I have installed python-dev and libffi-dev before, did you installed the latest version(15.10) of ubuntu in test?
A strange thing, I tried to use pip install miska just now in a clean virtualenv, it works no problem. But when I attempted install misaka in global, I got an error like this:
zeno@go:~$ sudo pip install misaka
The directory '/home/zeno/.cache/pip/http' or its parent directory is not owned by the current user and the cache has been disabled. Please check the permissions and owner of that directory. If executing pip with sudo, you may want sudo's -H flag.
The directory '/home/zeno/.cache/pip' or its parent directory is not owned by the current user and caching wheels has been disabled. check the permissions and owner of that directory. If executing pip with sudo, you may want sudo's -H flag.
Collecting misaka
  Downloading misaka-2.0.0.tar.gz (121kB)
    100% |████████████████████████████████| 122kB 211kB/s
Requirement already satisfied (use --upgrade to upgrade): cffi>=1.0.0 in /usr/lib/pypy/lib_pypy (from misaka)
Installing collected packages: misaka
  Running setup.py install for misaka
    Complete output from command /usr/bin/pypy -c "import setuptools, tokenize;__file__='/tmp/pip-build-WOEXNs/misaka/setup.py';exec(compile(getattr(tokenize, 'open', open)(__file__).read().replace('\r\n', '\n'), __file__, 'exec'))" install --record /tmp/pip-VqVy4s-record/install-record.txt --single-version-externally-managed --compile:
    running install
    running build
    running build_py
    creating build
    creating build/lib.linux-x86_64-2.7
    creating build/lib.linux-x86_64-2.7/misaka
    copying misaka/callbacks.py -> build/lib.linux-x86_64-2.7/misaka
    copying misaka/constants.py -> build/lib.linux-x86_64-2.7/misaka
    copying misaka/utils.py -> build/lib.linux-x86_64-2.7/misaka
    copying misaka/__init__.py -> build/lib.linux-x86_64-2.7/misaka
    copying misaka/api.py -> build/lib.linux-x86_64-2.7/misaka
    running build_ext
    generating cffi module 'build/temp.linux-x86_64-2.7/misaka._hoedown.c'
    creating build/temp.linux-x86_64-2.7
    building 'misaka._hoedown' extension
    creating build/temp.linux-x86_64-2.7/build
    creating build/temp.linux-x86_64-2.7/build/temp.linux-x86_64-2.7
    creating build/temp.linux-x86_64-2.7/misaka
    creating build/temp.linux-x86_64-2.7/misaka/hoedown
    cc -O2 -fPIC -Wimplicit -Imisaka -I/usr/lib/pypy/include -c build/temp.linux-x86_64-2.7/misaka._hoedown.c -o build/temp.linux-x86_64-2.7/build/temp.linux-x86_64-2.7/misaka._hoedown.o
    build/temp.linux-x86_64-2.7/misaka._hoedown.c:2:20: fatal error: Python.h: No such file or directory
    compilation terminated.
    error: command 'cc' failed with exit status 1

    ----------------------------------------
Command "/usr/bin/pypy -c "import setuptools, tokenize;__file__='/tmp/pip-build-WOEXNs/misaka/setup.py';exec(compile(getattr(tokenize, 'open', open)(__file__).read().replace('\r\n', '\n'), __file__, 'exec'))" install --record /tmp/pip-VqVy4s-record/install-record.txt --single-version-externally-managed --compile" failed with error code 1 in /tmp/pip-build-WOEXNs/misaka
zeno@go:~$ cc
cc: fatal error: no input files
compilation terminated.

I tested it on the latest Ubuntu in Virtualbox. I can install everything without problems. Same for Xubuntu.
build/temp.linux-x86_64-2.7/misaka._hoedown.c:2:20: fatal error: Python.h: No such file or directory
That's the error you usually get when python-dev is not installed.

I'm sure I have already installed python-dev... If not, why could I bulit it from source?

I found what happend,  sudo -H python /usr/local/bin/pip install misaka can install correctly. Because I installed pypy before and pypy's pip replace the alias pip from cpython. It's a so stupid issue, I'm sorry for wasting your time...

I watched this issue, but and my issue seems solved now.

Do you know what solved it for you?

Yes, I believe. Thanks to your comment, had to install python-dev and libffi-dev.

Hey Guys,
I'm really struggling to get misaka up and running, it keeps on telling me that module 'misaka' has no attribute 'html'.Please help out if you can
Thank You

authors: FSX ReneFroger ethe mshava

repo: FSX/misaka


text:
Ghost admits do not work

See https://github.com/FStarLang/steel/blob/_nik_ghost_admit/share/steel/examples/pulse/bug-reports/GhostAdmit.fst

Fixed

repo: FStarLang/steel


text:
Support wavy underlines (issue #1131)

Basic implementation of wavy underlines as described in #1131.
Adds two properties -- "wave" to control the radius of arc used to draw wavy lines, and "offset" to adjust the distance between text and underline, since it can be necessary to increase this for legibility when a wavy underline is in use.  Probably better names are possible.
These are used in TextFlowExt#getUnderlineShape to modify the shape produced.  If no radius is specified then a line is drawn as previously; otherwise a series of arcs is drawn, which replicates the appearance of the wavy underlines in common programs such as Microsoft Word.
I have only implemented the wavy-line shape in the Java 9+ version of the class because I can see there's an open question whether it's even worth supporting Java 8 any more (and my opinion FWIW is "no").
I haven't added any tests – if they're required then I would appreciate advice on how to test a purely visual change like this.

This is great, thanks a stack for this PR !

Okay, so I've played around with the code you've submitted and propose the following changes:

I noticed that there's a relationship between the wave radius and the offset, in that the offset needs to be increased as the radius gets larger. I think providing a reasonable default will help developers to not have to figure out another underline option if they don't need to. Suggested change to ParagraphText.UnderlineAttributes:

Number waveNumber = text.getUnderlineWave();
waveRadius = waveNumber == null ? 0 : waveNumber.doubleValue();
Number offsetNumber = text.getUnderlineOffset();
offset = offsetNumber == null ? waveRadius*0.5 : offsetNumber.doubleValue();
// The larger the radius the bigger the offset needs to be, so
// a reasonable default is provided if no offset is specified.

The range of useful wave radii is quite limited and with larger radii the underline is rather bumpy and not wavy. If however the X radius of the arcs is stretched out slightly then the range of useful radii increases and the underline is smoothed/stretched out as well. Suggested change to TextFlowExt.getUnderlineShape:

for ( int ele = 2; ele < shape.length; ele += 5 )
{
    LineTo bl = (LineTo) shape[ele+1];
    LineTo br = (LineTo) shape[ele];

    double y = snapSizeY( br.getY() + offset - 2.5 );
    double leftx = snapSizeX( bl.getX() );

    if (waveRadius <= 0) {
        result.add(new MoveTo( leftx, y ));
        result.add(new LineTo( snapSizeX( br.getX() ), y ));
    }
    else {
        // For larger wave radii increase the X radius to stretch out the wave.
        double radiusX = waveRadius > 1 ? waveRadius * 1.25 : waveRadius;
        double rightx = snapSizeX( br.getX() - radiusX ); // Prevent overshooting.
        result.add(new MoveTo( leftx, y ));
        boolean sweep = true;
        while ( leftx < rightx ) {
            leftx += waveRadius * 2;
            // Note, had to remove code here otherwise underline ended in strange tail ?
            result.add(new ArcTo( radiusX, waveRadius, 0.0, leftx, y, false, sweep ));
            sweep = !sweep;
        }
    }
}

I would appreciate it if you could try out the above changes and see how it affects what you want.
If you have any concerns, differences, or recommendations please comment.

Thank you for giving it a try! I agree on both counts -- the shallower waves look much nicer! -- and have pushed an update accordingly.
The only difference is that I have restored a version of the endpoint computation code, fixed to remove the assumption that the arc is defined by a circle.  I think it's necessary to clip the path this way, because otherwise larger radii will always either overflow or underflow.  I appreciate the code is a bit dense, but I wasn't able to find a more idiomatic way to do the clipping (which surprised me a bit -- I was expecting JavaFX to have that kind of feature, did I miss something?)

authors: Jugen shoaniki

repo: FXMisc/RichTextFX


text:
Changed StyledTextAreaBehavior to not catch mnemonic combinations

Fix for https://github.com/TomasMikula/RichTextFX/issues/350
On Unix systems Alt Gr will trigger neither Alt nor Ctrl to be pressed, on Windows it triggers both. As you want to let Alt Gr be a captured by StyledTextArea on Windows I changed the condition for it to let Alt be passed through and Alt Gr be captured. Although I still think that Alt Gr should also not be caught on Windows as it is not used to print characters there.
PS.: this is the private account of @jakob-erdmann

Thanks, looks good! Although I don't see the Windows case (both Ctrl and Alt pressed) being tested by the test cases.
We should be able to test the behavior without instantiating a StyledTextArea. Creating StyledTextAreaBehavior should suffice.

Although I still think that Alt Gr should also not be caught on Windows as it is not used to print characters there.

My thinking is that since it produces a KEY_TYPED event, the corresponding KEY_PRESSED event should be consumed. Am I misunderstanding something?

We should be able to test the behavior without instantiating a StyledTextArea. Creating StyledTextAreaBehavior should suffice.
I think I had problems getting the event handled when only having the behavior. But I can double check and extend for Alt + Ctrl case.

My thinking is that since it produces a KEY_TYPED event, the corresponding KEY_PRESSED event should be consumed. Am I misunderstanding something?
I don't know if the KEY_PRESSED is automatically consumed, but yes a KEY_TYPED event is thrown with those modifiers. On Windows only a bunch of keys are able to create new characters (e.g. @) by this. I guess when matching the typed key with the text property of the event we should be able to identify if this was used for printing a key or not. But anyway there are key combinations like CTRL + ALT + S should be usable by some menu actions in my opinion. I will also check on this tomorrow.

I don't know if the KEY_PRESSED is automatically consumed

It is certainly not consumed automatically. That's why we are writing this code to consume it, and it is hard to determine when we should and when not.

Well basically you only want to consume the event when it is used to print a character. And from the event object you can take the text that would be printed. So if there is no text given it probably should not be consumed. Will check the exact behavior for Windows machines, on Linux I can confirm that the event holds this data.

Well basically you only want to consume the event when it is used to print a character.

Exactly, that's what we are trying to determine: Does this key press produce a character input?

And from the event object you can take the text that would be printed.

There are two methods, getCharacter() and getText(). getCharacter() is defined only for key typed events, getText() is only defined for key pressed and key released events. We are inspecting a KEY_PRESSED event, so we can use only the getText() method. However, the string returned from getText() is a

String describing the key code, such as "HOME", "F1" or "A"

A textual description of the key code has nothing to do with whether character input is produced by the key press. This is why it is so difficult.

Closing due to inactivity and otherwise unresolved questions.

authors: Deroin JordanMartinez TomasMikula ghost


text:
java.lang.RuntimeException: Could not execute entrypoint stage 'main'

Describe the Bug
After updating Create to the latest build the pack failed to launch
Reproduction Steps
See above
Expected Result
no crash on launch
Screenshots and Videos
No response
Crash Report or Log
https://pastebin.com/rbyfJJEF
Operating System
Linux Mint 21.3 Cinnamon
Mod Version
0.5.1f
Minecraft Version
1.20.1
Other Mods
additionalentityattributes-1.7.3+1.20.0
animatica-0.6+1.20
appleskin-fabric-mc1.20.1-2.5.1
architectury-9.2.14-fabric
ArmorPoser-fabric-1.20.1-2.1.3
ArmorStatues-v8.0.6-1.20.1-Fabric
athena-fabric-1.20.1-3.1.2
backpacked-fabric-1.20.1-2.2.7
balm-fabric-1.20.1-7.2.2
better-end-sky-0.2.1+1.20
better-fabric-console-mc1.20.1-1.1.6
BetterCompatibilityChecker-fabric-4.0.1+mc1.20.1
BetterF3-7.0.2-Fabric-1.20.1
BetterThirdPerson-Fabric-1.20-1.9.0
BHMenu-Fabric-1.20.1-2.4.1
bigger_end_cities-1.20.1-1.0.4
bobby-5.0.1
Botania-1.20.1-443-FABRIC
BuildGuide-1.20-0.4.1
bwncr-fabric-1.20.1-3.17.0
carryon-fabric-1.20.1-2.1.2.7
Chipped-fabric-1.20.1-3.0.6
clienttweaks-fabric-1.20-11.1.0
cloth-config-11.1.118-fabric
Clumps-fabric-1.20.1-12.0.0.3
collective-1.20.1-7.40
completeconfig-2.5.0
connectivity-fabric-1.20.1-5.5
continuity-3.0.0-beta.4+1.20.1
Controlling-fabric-1.20.1-12.0.2
Copycats-fabric.1.20.1-1.2.6
craftingtweaks-fabric-1.20.1-18.2.3
create-fabric-0.5.1-f-build.1417+mc1.20.1
CullLessLeaves-1.3.0
cupboard-fabric-1.20.1-2.6
DisableCustomWorldsAdvice-4.1
DistractingTrims-Fabric-1.20.1-2.0.3
drippyloadingscreen_fabric_3.0.2_MC_1.20.1
easiercrafting-1.20-fabric0.83.0-1.7
easiervillagertrading-1.20-fabric0.83.0-1.5.4
EmeraldTools-Fabric-1.20.1-1.6.3
entitycount-2024.0128
entityculling-fabric-1.6.2-mc1.20.1
entityinformation-1.20.1-3.3
environmentalcreepers-fabric-1.20.1-1.6.0
EssentialGUI-1.9.4+1.20.1
extremesoundmuffler-3.41-fabric-1.20
eyespy-1.3.5+1.20.1
fabric-api-0.92.1+1.20.1
fabric-language-kotlin-1.10.19+kotlin.1.9.23
fancymenu_fabric_3.1.4_MC_1.20.1
farmers-delight-fabric-1.4.3
Fastload+1.18.2-1.20-3.4.0
ferritecore-6.0.1-fabric
fireworks-are-for-flying-1.20.1
ForgeConfigAPIPort-v8.0.0-1.20.1-Fabric
FpsReducer2-fabric-1.20-2.5
framework-fabric-1.20.1-0.6.16
fullscreeNO-1.0.0
fusion-1.1.1-fabric-mc1.20.1
geckolib-fabric-1.20.1-4.4.4
IBEEditor-1.20-2.2.8-fabric
ImmediatelyFast-Fabric-1.2.11+1.20.4
immersive_paintings-0.6.7+1.20.1-fabric
improvedsigns-1.3.1
indium-1.0.30+mc1.20.4
individualkeepinv-1.0.3
InventorySorter-1.9.0-1.20
iris-mc1.20.1-1.6.17
kibe-1.10.1-BETA+1.20
konkrete_fabric_1.8.1_MC_1.20.1
kubejs-fabric-2001.6.5-build.7
lambdynamiclights-2.3.2+1.20.1
lazydfu-0.1.3
litematica-fabric-1.20.1-0.15.3
lithium-fabric-mc1.20.1-0.11.2
lootr-1.20-0.7.30.77
malilib-fabric-1.20.1-0.16.3
melody_fabric_1.0.4_MC_1.20.1-1.20.4
memoryleakfix-fabric-1.17+-1.1.5
minihud-fabric-1.20.1-0.27.0
modmenu-7.2.2
MouseTweaks-fabric-mc1.20-2.26
neruina-1.3.0-fabric+1.18.2-1.20.1
NoChatReports-FABRIC-1.20.1-v2.2.2
observable-4.4.1
OpenLoader-Fabric-1.20.1-19.0.3
owo-lib-0.11.2+1.20
paladin-furniture-mod-1.2.1-fabric-mc1.20.1
Patchouli-1.20.1-84-FABRIC
Pehkui-3.8.0+1.14.4-1.20.4
polymorph-fabric-0.49.3+1.20.1
PuzzlesLib-v8.1.18-1.20.1-Fabric
quick-menu-1.2.3-1.20.1
reacharound+1.20-1.1.2
reeses_sodium_options-1.7.2+mc1.20.1-build.101
replaymod-1.20.1-2.6.15
resourcefullib-fabric-1.20.1-2.1.24
rhino-fabric-2001.2.2-build.18
RoughlyEnoughItems-12.1.712-fabric
Searchables-fabric-1.20.1-1.0.2
server-essentials-1.2.0
servertick-mc1.20-1.8
shulkerboxtooltip-fabric-4.0.4+1.20.1
sliceanddice-fabric-3.2.1
sodium-extra-0.5.4+mc1.20.1-build.115
sodium-fabric-0.5.8+mc1.20.1
StackDeobfuscatorFabric-1.4.2+bf1fc22
starlight-1.1.2+fabric.dbc156f
status-fabric-1.20.1-1.0.6
swingthrough-1.0.4+1.19
templates-2.1.1+1.20.1
textile_backup-3.1.2-1.20
toms_storage_fabric-1.20-1.6.6
TravelersTitles-1.20-Fabric-4.0.2
trinkets-3.7.2
tweakeroo-fabric-1.20.1-0.17.1
voicechat-fabric-1.20.1-2.5.12
vt-downloader-2.0.8+1.20.1
waystones-fabric-1.20-14.1.3
WI-Zoom-1.5-MC1.20.1
WorldTools-fabric-1.2.4+1.20.1
Xaeros_Minimap_24.1.1_Fabric_1.20
XaerosWorldMap_1.38.4_Fabric_1.20
yet-another-config-lib-fabric-3.2.2+1.20
yosbr-0.1.2
youre-in-grave-danger-2.0.0-beta.11
YungsApi-1.20-Fabric-4.0.4
YungsBetterDesertTemples-1.20-Fabric-3.0.3
YungsBetterDungeons-1.20-Fabric-4.0.4
YungsBetterJungleTemples-1.20-Fabric-2.0.4
YungsBetterMineshafts-1.20-Fabric-4.0.4
YungsBetterNetherFortresses-1.20-Fabric-2.0.6
YungsBetterOceanMonuments-1.20-Fabric-3.0.4
YungsBetterStrongholds-1.20-Fabric-4.0.3
YungsBetterWitchHuts-1.20-Fabric-3.0.3
YungsBridges-1.20-Fabric-4.0.3
YungsExtras-1.20-Fabric-4.0.3
YungsMenuTweaks-1.20.1-Fabric-1.0.2
Additional Context
No response

sliceanddice is crashing because you are using the old farmers delight port, switch to farmers delight refabricated

the issue is caused by farmer's delight.  farmer's delight fabric says it is deprecated.

lol. typing at teh same time

Thanks, that fixed it

authors: ClaudiusMinimus IThundxr drwoops

repo: Fabricators-of-Create/Create


text:
Additional translations (part 2)

Now with more editing and testing.
Uma profile blurbs could use a proofread as I'm not too familiar with most of them yet.
Also I'm not sure what the basis is for adding categories to the import script as I noticed not all of the csv files are listed there?

Also I'm not sure what the basis is for adding categories to the import script as I noticed not all of the csv files are listed there?

The ones that are listed in the import script should be or is more frequently updated; but you got a point — why not put them all in there? 🤔

authors: FabulousCupcake noccu

repo: FabulousCupcake/umamusume-db-translate


text:
Fast IP Ping

CurseForge link
https://www.curseforge.com/minecraft/mc-mods/fast-ip-ping
CurseForge Mod Distribution
Allowed
Modrinth link
https://modrinth.com/mod/fast-ip-ping
Source/other link
https://github.com/Fallen-Breath/fast-ip-ping
Mod file size
10.3KB
License
(any other license)
What it does

Yeet the laggy reversed DNS lookup for literal IP server addresses
Extracted from the yeetServerIpReversedDnsLookup option in TweakerMore Mod
What & Why & How
For servers whose addresses are represented solely by a literal IP, e.g. 192.168.2.10:25565, disable reverse DNS lookups in the corresponding InetAddress object
Many non-loopback IPs lack associated domain names, which makes reverse lookups time-consuming
// java.net.InetAddress#getHostName(boolean)
String getHostName(boolean check) {
    if (holder().getHostName() == null) {  // It will be null if InetAddress.getByName() received a literal IP
        holder().hostName = InetAddress.getHostFromNameService(this, check);  // <-- takes forever
    }
    return holder().getHostName();
}

This option sets the domain of those servers directly to their IP, bypassing the reverse DNS check
This results in a 1s ~ 5s reduction in time for servers with literal IP address. Affects the following environments:

Pinging the server in the server list screen
Connecting to the server

Environment

Client-side only
Fabric / Forge / NeoForge mod loader. No extra requirement is needed

Why should it be in the modpack
It reduces the time it takes to check the status of LAN servers in the multiplayer menu.
Why shouldn't it be in the modpack
No response
Additional details
No response

I don't personally think it's worth it... Minimal to no change to real word ux

I don't personally think it's worth it... Minimal to no change to real word ux

It's only 10KB and it shaves off several seconds. Considering that the average JPEG weighs about 50KB, there's little to no "cost" to adding this mod.
Even if this only affects LAN servers, for only 10KB I think it's worth adding. There are a lot of people who wait until the server status loads before clicking join.

authors: ItsIgnacioPortal TheBossMagnus


text:
Can't compile GUI

qt/qrcodedialog.cpp:21:22: fatal error: qrencode.h: No such file or directory
#include <qrencode.h>
^
compilation terminated.
make[1]: *** [qt/qt_libbitcoinqt_a-qrcodedialog.o] Error 1
make[1]: *** Waiting for unfinished jobs....
make[1]: Leaving directory `/root/Downloads/fair-coin/src'
make: *** [all-recursive] Error 1

You need to install libqrencode development package.
If you are on ubuntu try:
sudo apt-get install libqrencode-dev
BTW, what exact configure command did you use?

repo: FairCoinTeam/fair-coin


text:
fix #16 open falkordb instance in falkordb browser

fix #16

@coderabbitai review

@AviAvni or @gkorland Can you review and approve, please?

authors: dudizimber gkorland

repo: FalkorDB/saasbuilder


text:
Easycloudbooks Theme - Clients want to update service menu order & hide blog menu By kamlesh gehlot

Describe the bug

Clients want to change service menu order and also wants to hide blog menu from his website

menu sort order depends on Sort Order on website section of service

both of thing possible from design changes on theme

Blog Hide -
<ecbmodule type="visible" data-type="companyrelation" data-filter="{Field:'companyrelationblogany',Operator:'=',Value:'true'}">                                     <ecbtemplate> ---html---- </ecbtemplate> </ecbmodule>

authors: Avinash-ecb mitulpanch

repo: Fammeo/EasyCloudBooks


text:
Rewrite DEX classes avoiding over use of std::shared_ptr

In order to improve performance avoid overuse of std::shared_ptr, keeping it only in very connected components (for example IRGraph and Graphs of basic blocks). In other cases, it is better to keep ownership in just one object (use of std::unique_ptr), there's no need to share ownership of many objects. A raw pointer can be returned in some cases when read access is needed.
Another interesting utility, whenever we use a vector of objects, we can do the next:
  using object_t = std::vector<Object*>;

And from these we could try to return iterators in order to go over them in case a user wants to go over all the data structure.
All these improvements will also be helpful for creating the bindings for other languages, since it does not use many shared_ptr, and there's no need to keep counter for number of references, etc.
A new branch will be created for doing all these changes, so we will avoid having issues.

Current branch https://github.com/Fare9/KUNAI-static-analyzer/tree/refactoring includes many of the changes here proposed, also fix an important issue regarding performance. All these changes have been tested, and currently all these changes are being tested against Androguard with a benchmarking.


text:
Login failed, the terms and conditions might have been updated

After restarting HA today, this integration logs this:
Logger: seatconnect.connection
Bron: custom_components/seatconnect/__init__.py:796
integratie: Seat Connect ([documentatie](https://github.com/farfar/homeassistant-seatconnect/blob/main/README.md), [problemen](https://github.com/farfar/homeassistant-seatconnect/issues))
Eerst voorgekomen: 19:55:31 (11 gebeurtenissen)
Laatst gelogd: 20:05:10

Login failed, the terms and conditions might have been updated and need to be accepted. Login to https://my.seat/portal/ and accept the new terms before trying again

On the proposed website is stated:
Update notification
As of April 22nd 2022, the SEAT CONNECT portal is no longer available online.

Is it possible to make this integration working again?

The same issue happened to me yesterday. I logged into  https://seatid.vwgroup.io with my credentials and accepted all questions. Went back to HA and everything seems to work as expected.

Can confirm this!

Confirmed aswell, thank you for your replies! Closed.

The same issue happened to me yesterday. I logged into https://seatid.vwgroup.io with my credentials and accepted all questions. Went back to HA and everything seems to work as expected.

I logged on to the https://seatid.vwgroup.io/ and did the walk-through. When that didn't change the outcome, I went to https://cupraid.vwgroup.io/ and did the same (with the same account).
Since it’s al marketing / commercial consent, I don’t think it matters whether you give consent or not, but does anyone know their given consent to specific parts?

I gave all, after reading them, but only on seatid.vwgroup.io, while getting data from a Cupra Leon Sportstourer.
I also restarted HA, just to be sure, and after that the integration was happy again.

I think it's a different issue than mine  you solved by doing that.
Just have permissions, bit it still failed.
The main errors (in the other issue ticket):
Invalid credentials or invalid configuration. Make sure you have entered the correct credentials
Login failed with error: User appears unauthorized
Even though the credentials are correct and the plus service is bought.

Did you also fill in your s-pin in the configuration of HA?

I have configured S-pin and restarted HA but same thing. In another test HA, I have done integration again and logically until you log in with User and Psw doesn't let you put the S-pin so I can't configure it either.

Hmmm... Then I'm affraid I can't help you any further...

Did you also fill in your s-pin in the configuration of HA?

No, I do not cause I don’t know how. After I select the integration, I get the following setup screen.

The integration options can be changed after setup by clicking on the "CONFIGURE" text on the integration.
But I can’t get passed the setup.

You are right, it's in the Options for Seat Connect screen, as you wrote. Just curious what brand and model car are you trying to connect?

You are right, it's in the Options for Seat Connect screen, as you wrote. Just curious what brand and model car are you trying to connect?

In my case Cupra León ST

I have created a new user in My Cupra, accepted the terms and tried to add it in HA, but exactly the same thing happens. In the HA Log it says that you have to accept the terms, but I already have them accepted in both my user and the one I just created.

After gerting crazy for days (accessing anywhere you mentioned to accept anything...), have found a solution could help.
I logged in with Tor Browser (any otehr browser with incognito mode may work). I have changed my region to Germany (I am actually in Spain). New terms have appeared so I have accepted them. Then it has worked in HA!!!!

After gerting crazy for days (accessing anywhere you mentioned to accept anything...), have found a solution could help. I logged in with Tor Browser (any otehr browser with incognito mode may work). I have changed my region to Germany (I am actually in Spain). New terms have appeared so I have accepted them. Then it has worked in HA!!!!

Luego volviste a Español? Yo me estoy volviendo loco también. Cuando me contestes lo pruebo. Gracias!!

@trusky7 thats weird, I also connect to a Cupra Leon ST! I'm in the Netherlands, and saw the above suggestion to swap region... Maybe give it a try?

To do the above with other region, I created a new user yesterday (it looks to take a day to be validated), with an invite fron main user. Region is Germany but I keep Spanish language.
When accessing through official app it ramains in Spanish.
Prueba a cambiar la región! No te influirá en nada! No me atrevo a poner España como region de nuevo... Jeje

I have entered Seat Id, I have changed the region to Germany, it has made
me accept conditions, I have exited and entered again, it has made me
accept more conditions and then I have gone to HA but it tells me the same
thing.  I have done this with the user that I created this morning to
test.  Should I wait or something?
El mié, 3 jul 2024, 20:30, dacorde @.***> escribió:

To do the above with other region, I created a new user yesterday (it
looks to take a day to be validated), with an invite fron main user. Region
is Germany but I keep Spanish language.
When accessing through official app it remains in Spanish.
Prueba a cambiar la región! No te influirá en nada! No me atrevo a poner
España como region de nuevo... Jeje
—
Reply to this email directly, view it on GitHub
https://github.com/Farfar/homeassistant-seatconnect/issues/63#issuecomment-2206954908,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BH4USJ6VKE2HS2DTES6CVZ3ZKQ7M7AVCNFSM6AAAAABKGBWVV6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMBWHE2TIOJQHA
.
You are receiving this because you were mentioned.Message ID:
@.***>

Wow now yes!!! In my principal user wotks fine. Thxx

I can confrm the solution... change region in the user to germany, logout, login, agree the terms and conditions and working again. Thanks¡¡

Me pasaba lo mismo. No podía logearme.  He cambiado la región, aceptado todas las condiciones, reiniciado la aplicación y ahora funciona.

repo: Farfar/homeassistant-seatconnect


text:
Calculate travel distance between group members

Idea here is to help users determine which sorting method is going to be the most efficient for their bot:

An embellishment on this idea would be to use the bot's X/Y speed and acceleration settings to calculate travel time, in addition to distance.

Some style suggestions to what's on staging:

Border and background color: #94d7da
Broder-radius: 5px
Increase margin between sort options to 0.5rem

repo: FarmBot/Farmbot-Web-App