text:
immich: init at 1.109.2; nixos/immich: init module

Description of changes
This adds the package, nixos module and nixos test for immich
Closes #244803
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[x] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Does this superseed #244803?

Yes

I occasionally see these messages in my logs:
server[36665]: [Nest] 36665  - 07/05/2024, 12:00:00 AM   ERROR [Microservices:JobService] Unable to run job handler (thumbnailGeneration/generate-preview): Error: Cannot find ffprobe
server[36665]: [Nest] 36665  - 07/05/2024, 12:00:00 AM   ERROR [Microservices:JobService] Error: Cannot find ffprobe

server[8610]: [Nest] 8610  - 07/02/2024, 10:35:52 PM    WARN [Api:ServerInfoRepository~dfqq7ca6] Failed to read build-lock.json

ffprobe is provided by the ffmpeg the build already depends on. Perhaps it needs to be wrapped to have access to the binary at runtime.

Just wanted to say I'm psyched to see this getting added. Thanks for the work!

I have addressed most of the review comments now and rebased onto the current master. This broke albumentations, which I fixed in a seperate commit.
We will still need to wait for the upstream PR to get the geonames without downloading the full docker container

Ok, the albumentation fix got its own PR, I will rebase once that is merged: https://github.com/NixOS/nixpkgs/pull/325019/files

Ok, the albumentation fix got its own PR, I will rebase once that is merged: #325019

Merged :)

Yes, but we are waiting for a PR from upstream. When that is merged and a new release is cut, I will update this here accordingly

We get this error in the Immich logs while indexing photos:
Jul 09 23:26:18 server2 server[1740]: [Nest] 1740  - 07/09/2024, 11:26:18 PM   ERROR [Microservices:JobService] Unable to run job handler (faceDetection/face-detection): Error: Machine learning request to "http://immich-machine-learning:3003" failed with ConnectTimeoutError: Connect Timeout Error

Setting
services.immich.environment.IMMICH_MACHINE_LEARNING_URL = "http://localhost:3003";

fixes the issue. Maybe we should have a default like IMMICH_MACHINE_LEARNING_URL = "${cfg.host}:3003"; or something.
Also would it be possible to rename the environment option to settings?

We get this error in the Immich logs while indexing photos:
Jul 09 23:26:18 server2 server[1740]: [Nest] 1740  - 07/09/2024, 11:26:18 PM   ERROR [Microservices:JobService] Unable to run job handler (faceDetection/face-detection): Error: Machine learning request to "http://immich-machine-learning:3003" failed with ConnectTimeoutError: Connect Timeout Error

Setting
services.immich.environment.IMMICH_MACHINE_LEARNING_URL = "http://localhost:3003";

fixes the issue. Maybe we should have a default like IMMICH_MACHINE_LEARNING_URL = "${cfg.host}:3003"; or something.

I have no idea whether upstream actually supports that, but a Unix socket could be an even nicer option if they do.

There's an issue with HEIC / HEIF images, they can't be viewed and theres no thumbnail generated. Might be related to the implementation of libheif?
Error log of immich-server:
Jul 14 11:24:59 server2 server[174045]: [Nest] 174045  - 07/14/2024, 11:24:59 AM   ERROR [Microservices:JobService] Unable to run job handler (thumbnailGeneration/generate-preview): Error: /var/lib/immich/upload/8046b9e9-b0cf-46d1-9bc7-542fca747436/81/a3/81a3dc3a-db01-45ea-abe5-ed6996ced369.HEIC: bad seek to 1531357
Jul 14 11:24:59 server2 server[174045]: heif: Unsupported feature: Unsupported codec (4.3000)
Jul 14 11:24:59 server2 server[174045]: [Nest] 174045  - 07/14/2024, 11:24:59 AM   ERROR [Microservices:JobService] Error: /var/lib/immich/upload/8046b9e9-b0cf-46d1-9bc7-542fca747436/81/a3/81a3dc3a-db01-45ea-abe5-ed6996ced369.HEIC: bad seek to 1531357
Jul 14 11:24:59 server2 server[174045]: heif: Unsupported feature: Unsupported codec (4.3000)
Jul 14 11:24:59 server2 server[174045]:     at Sharp.toFile (/nix/store/k6sa9kikymqmbnpfbkvnamk1ci793d2p-immich-1.107.1/node_modules/sharp/lib/output.js:89:19)
Jul 14 11:24:59 server2 server[174045]:     at MediaRepository.generateThumbnail (/nix/store/k6sa9kikymqmbnpfbkvnamk1ci793d2p-immich-1.107.1/dist/repositories/media.repository.js:69:14)
Jul 14 11:24:59 server2 server[174045]:     at MediaService.generateThumbnail (/nix/store/k6sa9kikymqmbnpfbkvnamk1ci793d2p-immich-1.107.1/dist/services/media.service.js:158:48)
Jul 14 11:24:59 server2 server[174045]:     at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
Jul 14 11:24:59 server2 server[174045]:     at async MediaService.handleGeneratePreview (/nix/store/k6sa9kikymqmbnpfbkvnamk1ci793d2p-immich-1.107.1/dist/services/media.service.js:135:29)
Jul 14 11:24:59 server2 server[174045]:     at async /nix/store/k6sa9kikymqmbnpfbkvnamk1ci793d2p-immich-1.107.1/dist/services/job.service.js:148:36
Jul 14 11:24:59 server2 server[174045]:     at async Worker.processJob (/nix/store/k6sa9kikymqmbnpfbkvnamk1ci793d2p-immich-1.107.1/node_modules/bullmq/dist/cjs/classes/worker.js:394:28)
Jul 14 11:24:59 server2 server[174045]:     at async Worker.retryIfFailed (/nix/store/k6sa9kikymqmbnpfbkvnamk1ci793d2p-immich-1.107.1/node_modules/bullmq/dist/cjs/classes/worker.js:581:24)
Jul 14 11:24:59 server2 server[174045]: [Nest] 174045  - 07/14/2024, 11:24:59 AM   ERROR [Microservices:JobService] Object:
Jul 14 11:24:59 server2 server[174045]: {
Jul 14 11:24:59 server2 server[174045]:   "id": "dd9353ed-3d2d-4099-b6cc-a5e8d5382519",
Jul 14 11:24:59 server2 server[174045]:   "source": "upload"
Jul 14 11:24:59 server2 server[174045]: }

Isn't that expected? It is not listed as one of the formats on the Sharp website: https://sharp.pixelplumbing.com/#formats

I think the formatting check is broken. I do exactly what the CI says and nothing is changed any more but the check still fails

CI uses precisely the commit mentioned here to pull nixfkt-rfc-style from:
https://github.com/NixOS/nixpkgs/blob/master/ci/pinned-nixpkgs.json#L2
Using that should pass the check

Yes, the missing rebase was the issue.
I think I have now accounted for every bit of feedback, as well as updated to the latest version of immich

I noticed that a few videos were not getting thumbnails, and traced it back to missing ffmpeg encoders. Switching to ffmpeg-full fixes that

I noticed that a few videos were not getting thumbnails

Do you have any specific examples? Container type, encoding, etc? iirc ffmpeg-full was discouraged due to the larger closure.

I know that at least webp is missing from the normal ffmpeg

Let's leave it as ffmpeg for now, I'll go through and see if we can enable some more codecs in the regular ffmpeg package without impacting closure too much.

Related:
https://github.com/lovell/sharp/issues/3844
https://github.com/immich-app/immich/issues/4899
https://github.com/libvips/libvips/issues/3380

Nice share, this motivated me to dig a bit more.
So in the Docker setup they indeed add the -Dtiff=disable flag. I thought it would be a simple matter of overriding vips with that flag, however it doesn't cut it. It seems that the vips in buildInputs doesn't get used at all. The ./node_modules/@img/sharp-libvips-linux-x64/lib/libvips-cpp.so.42 appears in the immich derivation regardless if it's included or not. Its ldd output is very small, which makes me think this is the default library included in the sharp npm package, just patchelf-ed.
I managed to make it work by adding the below instructions to the derivation but surely there must be a better way to make sharp use the provided vips.
rm $out/node_modules/@img/sharp-libvips-linux-x64/lib/libvips-cpp.so.42
ln -s ${vips.out}/lib/libvips-cpp.so.42.17.2 $out/node_modules/@img/sharp-libvips-linux-x64/lib/libvips-cpp.so.42

Given the pace at which upstream development happens, we might want to warn users to stop the immich apps from auto-updating as we cannot ensure that we will be able to keep up in a timely manner.

I thought it would be a simple matter of overriding vips with that flag, however it doesn't cut it. It seems that the vips in buildInputs doesn't get used at all. The ./node_modules/@img/sharp-libvips-linux-x64/lib/libvips-cpp.so.42 appears in the immich derivation regardless if it's included or not. Its ldd output is very small, which makes me think this is the default library included in the sharp npm package, just patchelf-ed.

That should not be the case. There's no patchelfing going on here.
If we're downloading binaries, this should also be tagged with the appropriate sourceProvenance.

That should not be the case. There's no patchelfing going on here.

Ah yes indeed, I misinterpreted the output of ldd. It's the same file regardless of the OS.

If we're downloading binaries, this should also be tagged with the appropriate sourceProvenance.

I hope this won't be necessary as sharp supports building from the system vips. While investigating ad-hoc I noticed that it silently fails to build from source unless node-gyp and node-addon-api are installed before running npm install sharp. I suspect that the latter not being present as buildInput causing the issue, although as I haven't managed to package it I can't really be sure.
But when it is, then there will be a ./node_modules/sharp/src/build/Release/sharp-linux-x64.node file which is linked against the provided vips.  It still embedds the prebuilt ./node_modules/@img/sharp-libvips-linux-x64/lib/libvips-cpp.so.42 for some reason but it has less priority so we should be able to delete it (and maybe the whole of ./node_modules/sharp/src/build/Release/sharp-linux-x64.node as upstream does.

(I was testing the automatic review using nixf-tidy, comments are generated above).

Seems like these issues got flagged by the new CI check:

Editing title won't print them to 'Files changed' overview, to avoid duplicate. Once a push happens it will. Also checking escaping with is disabled now.

Not sure why you're replying to me about that, I edited the title because it was inaccurate. And the nixf-tidy check did fire after I edited.

In case you don't know why it behaved like that, nevermind

Not sure if this is the correct place to ask, but I tried the Immich module from this PR (on commit 7290604) and it's not working on my server (however it does run on my main computer). I also tried running the official docker images and those worked, so I presume the issue is with the nix package.
I set IMMICH_LOG_LEVEL to verbose, but still the log only shows this which is not enough information for me to gain any insight:
  `journalctl -b -u immich-server`
Started Immich backend server (Self-hosted photo and video backup solution).
immich-server.service: Main process exited, code=dumped, status=4/ILL
immich-server.service: Failed with result 'core-dump'.
immich-server.service: Consumed 27.786s CPU time, no IP traffic.
immich-server.service: Scheduled restart job, restart counter is at 1.
Started Immich backend server (Self-hosted photo and video backup solution).
immich-server.service: Main process exited, code=dumped, status=4/ILL
immich-server.service: Failed with result 'core-dump'.
immich-server.service: Consumed 19.285s CPU time, no IP traffic.
immich-server.service: Scheduled restart job, restart counter is at 2.
Started Immich backend server (Self-hosted photo and video backup solution).
immich-server.service: Main process exited, code=dumped, status=4/ILL
immich-server.service: Failed with result 'core-dump'.
immich-server.service: Consumed 18.356s CPU time, no IP traffic.
immich-server.service: Scheduled restart job, restart counter is at 3.
Started Immich backend server (Self-hosted photo and video backup solution).
immich-server.service: Main process exited, code=dumped, status=4/ILL
immich-server.service: Failed with result 'core-dump'.
immich-server.service: Consumed 18.251s CPU time, no IP traffic.

What kind of processor is this? You're running into illegal instructions and that should basically never happen on non-legacy hardware, especially not given that we target a generic x86_64-processor that should even run machines over a decade old.

Yeah it's quite old. It's an Intel Atom CPU D525. Is this not supported by nixpkgs? I haven't run into any issues running NixOS on it so far.

You'll definitely have to disable machine-learning. Unsure if that'd be sufficient though, that cpu only supports SSE3

I've been testing this module today, and discovered that generating thumbnails failed for heic files from my phone.

Log
Jul 29 19:33:34 weilite server[795]: [Nest] 795  - 07/29/2024, 7:33:34 PM   ERROR [Microservices:JobService] Unable to run job handler (thumbnailGeneration/generate-preview): Error: /mnt/XinPhotos/immich/library/admin/2024/2024-05-14/20240514_161132.heic: bad seek to 7948144
Jul 29 19:33:34 weilite server[795]: heif: Unsupported feature: Unsupported codec (4.3000)
Jul 29 19:33:34 weilite server[795]: [Nest] 795  - 07/29/2024, 7:33:34 PM   ERROR [Microservices:JobService] Error: /mnt/XinPhotos/immich/library/admin/2024/2024-05-14/20240514_161132.heic: bad seek to 7948144
Jul 29 19:33:34 weilite server[795]: heif: Unsupported feature: Unsupported codec (4.3000)
Jul 29 19:33:34 weilite server[795]:     at Sharp.toFile (/nix/store/hjw0dx1ap99l7dqi06k1a5f2dmgl0akq-immich-1.109.2/node_modules/sharp/lib/output.js:89:19)
Jul 29 19:33:34 weilite server[795]:     at MediaRepository.generateThumbnail (/nix/store/hjw0dx1ap99l7dqi06k1a5f2dmgl0akq-immich-1.109.2/dist/repositories/media.repository.js:69:14)
Jul 29 19:33:34 weilite server[795]:     at MediaService.generateThumbnail (/nix/store/hjw0dx1ap99l7dqi06k1a5f2dmgl0akq-immich-1.109.2/dist/services/media.service.js:164:48)
Jul 29 19:33:34 weilite server[795]:     at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
Jul 29 19:33:34 weilite server[795]:     at async MediaService.handleGeneratePreview (/nix/store/hjw0dx1ap99l7dqi06k1a5f2dmgl0akq-immich-1.109.2/dist/services/media.service.js:135:29)
Jul 29 19:33:34 weilite server[795]:     at async /nix/store/hjw0dx1ap99l7dqi06k1a5f2dmgl0akq-immich-1.109.2/dist/services/job.service.js:148:36
Jul 29 19:33:34 weilite server[795]:     at async Worker.processJob (/nix/store/hjw0dx1ap99l7dqi06k1a5f2dmgl0akq-immich-1.109.2/node_modules/bullmq/dist/cjs/classes/worker.js:394:28)
Jul 29 19:33:34 weilite server[795]:     at async Worker.retryIfFailed (/nix/store/hjw0dx1ap99l7dqi06k1a5f2dmgl0akq-immich-1.109.2/node_modules/bullmq/dist/cjs/classes/worker.js:581:24)
Jul 29 19:33:34 weilite server[795]: [Nest] 795  - 07/29/2024, 7:33:34 PM   ERROR [Microservices:JobService] Object:
Jul 29 19:33:34 weilite server[795]: {
Jul 29 19:33:34 weilite server[795]:   "id": "db366035-dce6-4d12-8127-67ca60a12fb3"
Jul 29 19:33:34 weilite server[795]: }

This might be related to lovell/sharp#2518, so I agree with @GeoffreyFrogeye that it seems like vips provided in buildInputs is not used in the final result.

What's left here to fix? Looking forward to seeing this merged!

See the unresolved review comments.

I should have time this weekend to address the remaining comments

Great. I think we all appreciate @jvanbruegge continued work, including pioneering the packaging of immich after other continued efforts have failed (e.g. #244803). Considering how this package already provides a lot of value, I think it would be great to merge this after e.g. this weekend, even if not all problems are resolved. We can then open issues for any remaining problems, e.g. with thumbnail creation, and others can step in to fix those problems.

I think it should also generally not be seen as rude to simply take a seemingly stalled PR and continue work on it yourself. In the worst case where the original author does wish to continue working on it, they can simply pull back your changes into their branch. That's the beauty of FOSS and distributed version control.

So, I've addressed all review comments, and updated immich to the latest version. I am now looking into rebuilding sharp.
@Atemu adding the default environment to the environment config option causes the manual to fail, what should be done here?

ok, that took a while, but I finally managed to debug the build failure for pgvecto-rs. Now I can actually test my new changes and investigate the sharp rebuild

@jvanbruegge Maintainer of the pgvecto-rs package here. Thanks for fixing the build failure, I hadn't noticed it was failing! Judging by the date (29th July) it started failing, it seems to be releated to the upgrade to rustc 1.79.
Question for more experienced maintainers: is there a way to get notified when hydra fails to build a package you maintain?

adding the default environment to the environment config option causes the manual to fail, what should be done here?

The usual cause is using options or config in a default value, which necessitates setting defaultText = lib.literalExpression "...", but details will depend on the actual cause if it comes up again.

My only comment is around backups. I dont know immich at all, but do they have a backup solution included or do they just leave that to the user ? If they leave it to the user then it makes sense create a dedicated user and group for immich so that the backup user can just read immich directory as well. If they have a backup solution then maybe dynamic user might be a better fit.
To answer another comment i dont know how to find out with hydra that your builds failed. In my experience you just have to be on unstable and update your system every week with your packages.

Many people were involved in this PR, are we all ok to merge ?

If they leave it to the user then it makes sense create a dedicated user and group for immich
it already does? Immich does not have a dedicated backup feature so far

Many people were involved in this PR, are we all ok to merge ?
No, I am still trying to fix the thumbnails

maybe dynamic user might be a better fit

I think NixOS modules should always use a dynamic user if possible.
I assume in this case it's impossible because multiple services need access to the same data?

Many people were involved in this PR, are we all ok to merge ?

The newest substantial changes were pushed just hours ago, please give people some time to review before calling for further actions.

So, I tested if I really managed to fix the raw/heif issues and yes indeed :tada:

Here are some samples that work on a Docker setup if you want to test for yourself.

Thanks, for having a look at the issue, vips is built with -Dtiff=disable now.

Please pull https://github.com/jvanbruegge/nixpkgs/pull/1

Btw, 1.112 came out eith support for pg-vector 0.3. We are waiting before merging 0.3 to nixpkgs for the update for 1.112 to be done. Take the time you need though .

https://wiki.nixos.org/wiki/Nixpkgs/Reviewing_changes

Thank you for this!
Lookin forward for the merge

Ok, I have updated immich to the latest version and addressed all review comments again

1.115.0 is running nice and smooth for me! Thanks for all the hard work!

Yes, I also upgraded my deployment to the latest version of this PR and everything works

Given the huge popularity of Immich, I'd like to take a bit of time to really thank all the people involved in packaging this.
@jvanbruegge I'd like to thank you for bringing this to the finish line; I know it probably wasn't easy, given this PR was open almost 3 months ago. You started as a user requesting a package and ended up stepping up and sharing your work with the rest of the NixOS community, when it looked like the consensus was having a separate project. I'm sure the community will help you maintain both the package and the module up to date, given the frenetic rate at which Immich is being developed :)
There are a couple of unsung heroes I'd like to mention:

@oddlama, for taking one of the first stabs at this more than a year ago!
@diogotcorreia, for having packaged one of the blockers, pgvecto.rs! You also started by sharing your work in a comment, and ended up making it available to the whole nixpkgs and unblocking @oddlama / @jvanbruegge efforts! Thank you!

And a huge thanks to all the reviewers involved!

Amazing work! How can I properly integrate this into my nix config? Does anyone have a public server config I can take a look at.
Thanks!

https://github.com/jvanbruegge/server-config/blob/86d8f6ff4c9e576cdfd94410dd4e35e58c6e8e5d/caladan/services.nix#L10

Thank you @jvanbruegge, just trying to figure out how to integrate this with the differing directories I have things stored in. Thanks again for all your hard work! Very much appreciated!

back then i wrote this wiki page but not sure if its still up-to date https://wiki.nixos.org/wiki/Immich

Thank you so much for finally bringing immich to nixos!
I have one question: does the default setup support external libraries? Because I tried to add my local picture library on my server to immich as external library, but it cannot access any path I specify. It always gives EACCESS, even though the whole path is readable and executable by everyone.

@ISibboI This is probably because of the service hardening I did in the first version. You will have to add your directory to a ReadWritePaths directive for the relevant systemd units to make it work

@oddlama

This is probably because of the service hardening I did in the first version. You will have to add your directory to a ReadWritePaths directive for the relevant systemd units to make it work

This should be done automatically if it's not the default state directory imo.

I don't think that's the issue, as I also do not use the standard path and have no issues

Congratulations @jvanbruegge! This was one of the most through reviews I've seen, and you made it through! Thanks for all your hard work as well as the hard work of others to get this merged!

I was able to migrate my Docker Compose deployment. An issue I ran into was that file paths in the database were relative to immich's working directory, meaning that everything was prefixed with upload/. I was able to remedy this by replacing upload/ with my mediaLocation (which is also what the UPLOAD_LOCATION variable from my Compose deployment pointed to).

[!NOTE]
This is what worked for my installation that is a few years old. I am not sure if newer installations behave differently. Some facts about my Docker Compose installation:

The database is called immich
The database user is called immich
My UPLOAD_LOCATION (docker mount path) is set to /media/immich-library

Make a backup of your current library and save a copy of the following database dump
Enable NixOS Immich and switch. This will start an empty instance of Immich but will create the database and database user for us.1 In my case it looked like this:

services.immich = {
  enable = true;
  mediaLocation = "/media/immich-library";
};

Stop NixOS Immich

systemctl stop immich-server.service immich-machine-learning.service

Stop Docker Immich. Leave your postgres container running
Dump your database. The following command is going to dump it into Postgres' data directory, so it will be easy to access from your host system.

docker compose exec database pg_dump --user immich -f /var/lib/postgresql/data/dump.sql immich

Fix unset search_path variable.2

sed -i "s#SELECT pg_catalog.set_config('search_path', '', false);#SELECT pg_catalog.set_config('search_path', 'public', false);#" </path/to/immich/compose>/postgres/dump.sql

Replace upload/ path prefix.3 In my case I replace it with /media/immich-library

sed -i "s#upload/#/media/immich-library#g" </path/to/immich/compose>/postgres/dump.sql

Prepare NixOS database

sudo -u postgres psql immich
immich=# <paste following codeblock and exit>

DROP SCHEMA public CASCADE;
DROP SCHEMA vectors CASCADE;

CREATE SCHEMA public;

CREATE EXTENSION IF NOT EXISTS unaccent;
CREATE EXTENSION IF NOT EXISTS "uuid-ossp";
CREATE EXTENSION IF NOT EXISTS vectors;
CREATE EXTENSION IF NOT EXISTS cube;
CREATE EXTENSION IF NOT EXISTS earthdistance;
CREATE EXTENSION IF NOT EXISTS pg_trgm;

ALTER SCHEMA public OWNER TO immich;
ALTER SCHEMA vectors OWNER TO immich;
GRANT SELECT ON TABLE pg_vector_index_stat TO immich;

ALTER EXTENSION vectors UPDATE;

Import your dump. Make sure the file is readable. I moved it to a location that is readable by the postgres user.

sudo -u postgres psql immich -f </path/to/immich/compose>/postgres/dump.sql

Start NixOS Immich

systemctl start immich-server.service immich-machine-learning.service

Make sure you can actually view images on the web app.

If any of these steps fail, you should have your original (unmodified!) database as well as a backup of your media location.
1: As a precaution, you could make your existing Immich library read-only (i.e. chown -R root:root /media/immich-library) to avoid any modifications done by this empty installation of Immich.
2: Restoring a dump that uses Postgres earthdistance seems to fail if search_path isn't set to the target schema. See this StackOverflow comment
3: Perhaps you can inspect your database dump for this first. In my case every file reference started with upload/ (i.e. upload/thumbs/ instead of just thumbs/)

I hope this helps someone out there trying to get this working.

@Scrumplex could you PR that into a migration doc and link it in the patch notes?

Thank you @Scrumplex, I've been working on migration now, luckily I had a backup of my sql because I've broken it hahaha

I have written more in the last hour than I did on average per day for my bachelor's thesis. :sweat_smile:
See https://github.com/NixOS/nixpkgs/pull/344300 for my proposed NixOS manual documentation.
I'll keep "Allow edits and access to secrets by maintainers" in case someone with commit access wants to commit changes into my PR. I will go to bed now! :zzz:

Found an issue with the module, when running immich and changing the group services.immich.group = "test"; the redis service will have the wrong group and fail to start. The issue is this line, so it would make sense to just create the group if the name is immich.
https://github.com/NixOS/nixpkgs/blob/23cbb250f3bf4f516a2d0bf03c51a30900848075/nixos/modules/services/databases/redis.nix#L356
> journalctl -r -u redis-immich.service
Sep 25 04:42:53 HOSTNAME systemd[1]: Failed to start Redis Server - redis-immich.
Sep 25 04:42:53 HOSTNAME systemd[1]: redis-immich.service: Failed with result 'exit-code'.
Sep 25 04:42:53 HOSTNAME systemd[1]: redis-immich.service: Control process exited, code=exited, status=216/GROUP
Sep 25 04:42:53 HOSTNAME (rep-conf)[13315]: redis-immich.service: Failed at step GROUP spawning /nix/store/338pjs37wgmhghid8wbai5qgyssihq2n-redis-immich-prep-conf: No such process
Sep 25 04:42:53 HOSTNAME (rep-conf)[13315]: redis-immich.service: Failed to determine group credentials: No such process
Sep 25 04:42:53 HOSTNAME systemd[1]: Starting Redis Server - redis-immich...

If you use a non-socket postgres connection then services.immich.environment refers to cfg.database.port, but the module doesn't declare this option. Is this a bug, or am I missing something?

@bct i believe that is a bug, I can also reproduce.

Yes, that probably got lost somewhere during all of the rebasing for the reviews

Anyone had success testing this on aarch64?

It tries to build python3Packages.insightface which is broken on aarch64-linux, don't know if it would work removing it (without face recognition obviously). Moreover postgresqlPackages.pgvecto-rstoo is broken onaarch64-linux` and there may be other broken dependencies.

Sorry to interject but please create separate issues rather than commenting on this PR unless it is specifically something that requires the attention of the people who were involved in this PR.
A lot of people are subscribed and this code is in Nixpkgs now, so it should be treated like any other Nixpkgs code.

authors: Aleksanaa Atemu GaetanLepage GeoffreyFrogeye ISibboI Kernald NyCodeGHG PowerUser64 RomeoV Scrumplex Titaniumtown aciceri bct crertel dav-wolff diogotcorreia dotlambda eclairevoyant gitwah h7x4 happysalada inclyc jlbribeiro jpds jvanbruegge oddlama onny qbit rathmerdominik rhoriguchi xinyangli


text:
fedifetcher: 7.1.1 -> 7.1.4

Diff: https://github.com/nanos/FediFetcher/compare/refs/tags/v7.1.1...v7.1.4
Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

@ofborg build fedifetcher

source: gharchive/pull-request

repo: NixOS/nixpkgs

license: MIT

license_type: permissive

license_source: github-api


text:
python312Packages.cyclonedx-python-lib: refactor

Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 330689 run on x86_64-linux 1

10 packages built:

checkov
checkov.dist
cyclonedx-python
cyclonedx-python.dist
pip-audit
pip-audit.dist
python311Packages.cyclonedx-python-lib
python311Packages.cyclonedx-python-lib.dist
python312Packages.cyclonedx-python-lib
python312Packages.cyclonedx-python-lib.dist


text:
parpd: init 2.3.0

Fix https://github.com/NixOS/nixpkgs/issues/345461
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

@Aleksanaa Done.


text:
renode: 1.15.2 -> 1.15.3

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for renode is: Virtual development framework for complex embedded systems
meta.homepage for renode is: https://renode.io
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 1.15.3 in filename of file in /nix/store/dicby0bcpxqa3ws0mpbkz5jnz2w9rz8h-renode-1.15.3

Rebuild report (if merged into master) (click to expand)

2 total rebuild path(s)

2 package rebuild(s)

First fifty rebuilds by attrpath

renode

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/dicby0bcpxqa3ws0mpbkz5jnz2w9rz8h-renode-1.15.3 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A renode https://github.com/r-ryantm/nixpkgs/archive/12bfac6b125be9b6ed323e9f6268566384cb2217.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/12bfac6b125be9b6ed323e9f6268566384cb2217#renode

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/dicby0bcpxqa3ws0mpbkz5jnz2w9rz8h-renode-1.15.3
ls -la /nix/store/dicby0bcpxqa3ws0mpbkz5jnz2w9rz8h-renode-1.15.3/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

renode

Maintainer pings
cc @otavio for testing.

[!TIP]
As a maintainer, if your package is located under pkgs/by-name/*, you can comment @NixOS/nixpkgs-merge-bot merge to automatically merge this update using the nixpkgs-merge-bot.

Add a :+1: reaction to pull requests you find important.

@NixOS/nixpkgs-merge-bot merge

authors: otavio r-ryantm


text:
python312Packages.python-docs-theme: 2024.6 -> 2024.10

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for python312Packages.python-docs-theme is: Sphinx theme for CPython project
meta.homepage for python312Packages.python-docs-theme is: https://github.com/python/python-docs-theme
meta.changelog for python312Packages.python-docs-theme is: https://github.com/python/python-docs-theme/blob/2024.10/CHANGELOG.rst
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 2024.10 with grep in /nix/store/rs2qirl06p9myvkvz5z6m4zlzz83dids-python3.12-python-docs-theme-2024.10
found 2024.10 in filename of file in /nix/store/rs2qirl06p9myvkvz5z6m4zlzz83dids-python3.12-python-docs-theme-2024.10

Rebuild report (if merged into master) (click to expand)

3 total rebuild path(s)

3 package rebuild(s)

First fifty rebuilds by attrpath

python311Packages.python-docs-theme
python312Packages.python-docs-theme

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/rs2qirl06p9myvkvz5z6m4zlzz83dids-python3.12-python-docs-theme-2024.10 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A python312Packages.python-docs-theme https://github.com/r-ryantm/nixpkgs/archive/edece1aa0db54b5c144d7f7cc92a7b970026e91e.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/edece1aa0db54b5c144d7f7cc92a7b970026e91e#python312Packages.python-docs-theme

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/rs2qirl06p9myvkvz5z6m4zlzz83dids-python3.12-python-docs-theme-2024.10
ls -la /nix/store/rs2qirl06p9myvkvz5z6m4zlzz83dids-python3.12-python-docs-theme-2024.10/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review

x86_64-linux

:white_check_mark: 4 packages built:

python311Packages.python-docs-theme
python311Packages.python-docs-theme.dist
python312Packages.python-docs-theme
python312Packages.python-docs-theme.dist

Maintainer pings
cc @KAction for testing.

[!TIP]
As a maintainer, if your package is located under pkgs/by-name/*, you can comment @NixOS/nixpkgs-merge-bot merge to automatically merge this update using the nixpkgs-merge-bot.

Add a :+1: reaction to pull requests you find important.

nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 352284

x86_64-linux

:white_check_mark: 4 packages built:

python311Packages.python-docs-theme
python311Packages.python-docs-theme.dist
python312Packages.python-docs-theme
python312Packages.python-docs-theme.dist

authors: NickCao r-ryantm


text:
qtcreator: pin llvmPackages 18

Build failure with llvm 19
[161/4146] Building CXX object src/libs/3rdparty/cplusplus/CMakeFiles/3rd_cplusplus.dir/Symbol.cpp.o
[162/4146] Building CXX object src/libs/3rdparty/cplusplus/CMakeFiles/3rd_cplusplus.dir/Symbols.cpp.o
[163/4146] Building C object src/libs/sqlite/CMakeFiles/SqliteInternal.dir/__/3rdparty/sqlite/carray.c.o
[164/4146] Automatic MOC for target QmlPuppetCommunication
[165/4146] Running AUTOMOC file extraction for target QmlPuppetCommunication
[166/4146] Building CXX object src/libs/3rdparty/cplusplus/CMakeFiles/3rd_cplusplus.dir/TranslationUnit.cpp.o
[167/4146] Building CXX object src/libs/languageutils/CMakeFiles/LanguageUtils.dir/fakemetaobject.cpp.o
[168/4146] Building CXX object src/libs/3rdparty/cplusplus/CMakeFiles/3rd_cplusplus.dir/Parser.cpp.o
[169/4146] Building CXX object src/libs/sqlite/CMakeFiles/Sqlite.dir/sqliteglobal.cpp.o
[170/4146] Linking CXX shared library nix/store/zx1wd8m2ndx2fdzb4is3vm6xah094242-qtcreator-15.0.0/lib/qtcreator/libLanguageUtils.so.15.0.0
[171/4146] Creating library symlink nix/store/zx1wd8m2ndx2fdzb4is3vm6xah094242-qtcreator-15.0.0/lib/qtcreator/libLanguageUtils.so.15 nix/store/zx1wd8m2ndx2fdzb4is3vm6xah094242-qtcreator-15.0.0/lib/qtcreator/libLanguageUtils.so
[172/4146] Building CXX object src/libs/sqlite/CMakeFiles/Sqlite.dir/sqlitebasestatement.cpp.o
FAILED: src/libs/sqlite/CMakeFiles/Sqlite.dir/sqlitebasestatement.cpp.o
/nix/store/xl0vlc2wdchfbq8536zs19pj2r3xdmma-clang-wrapper-19.1.5/bin/clang++ -DNANOTRACE_ENABLED -DQT_CORE_LIB -DQT_CREATOR -DQT_DISABLE_DEPRECATED_BEFORE=0x050900 -DQT_DISABLE_DEPRECATED_UP_TO=0x050900 -DQT_GUI_LIB -DQT_NO_CAST_TO_ASCII -DQT_NO_DEBUG -DQT_NO_FOREACH -DQT_NO_JAVA_STYLE_ITERATORS -DQT_RESTRICTED_CAST_FROM_ASCII -DQT_USE_QSTRINGBUILDER -DQT_WARN_DEPRECATED_BEFORE=0x060400 -DQT_WARN_DEPRECATED_UP_TO=0x060400 -DRELATIVE_DATA_PATH=\"../share/qtcreator\" -DRELATIVE_DOC_PATH=\"../share/doc/qtcreator\" -DRELATIVE_LIBEXEC_PATH=\"../libexec/qtcreator\" -DRELATIVE_PLUGIN_PATH=\"../lib/qtcreator/plugins\" -DSQLITEINTERNAL_LIBRARY -DSQLITE_CUSTOM_INCLUDE=config.h -DSQLITE_LIBRARY -DSqlite_EXPORTS -I/build/qt-creator-opensource-src-15.0.0/build/src/libs/sqlite -I/build/qt-creator-opensource-src-15.0.0/src/libs/sqlite -I/build/qt-creator-opensource-src-15.0.0/src/libs/sqlite/../3rdparty/sqlite -I/build/qt-creator-opensource-src-15.0.0/src/libs -isystem /nix/store/dh5kclrfrvk7aknvk22n2bnz4x8kj1q6-qtbase-6.8.1/include/QtCore -isystem /nix/store/dh5kclrfrvk7aknvk22n2bnz4x8kj1q6-qtbase-6.8.1/mkspecs/linux-g++ -isystem /nix/store/dh5kclrfrvk7aknvk22n2bnz4x8kj1q6-qtbase-6.8.1/include/QtGui -O3 -DNDEBUG -std=c++20 -fPIC -fvisibility=hidden -fvisibility-inlines-hidden -Wall -Wextra -fPIC -Winvalid-pch -Xclang -include-pch -Xclang /build/qt-creator-opensource-src-15.0.0/build/src/libs/3rdparty/syntax-highlighting/CMakeFiles/QtCreatorPchConsole.dir/cmake_pch.hxx.pch -Xclang -include -Xclang /build/qt-creator-opensource-src-15.0.0/build/src/libs/3rdparty/syntax-highlighting/CMakeFiles/QtCreatorPchConsole.dir/cmake_pch.hxx -MD -MT src/libs/sqlite/CMakeFiles/Sqlite.dir/sqlitebasestatement.cpp.o -MF src/libs/sqlite/CMakeFiles/Sqlite.dir/sqlitebasestatement.cpp.o.d -o src/libs/sqlite/CMakeFiles/Sqlite.dir/sqlitebasestatement.cpp.o -c /build/qt-creator-opensource-src-15.0.0/src/libs/sqlite/sqlitebasestatement.cpp
In file included from /build/qt-creator-opensource-src-15.0.0/src/libs/sqlite/sqlitebasestatement.cpp:4:
In file included from /build/qt-creator-opensource-src-15.0.0/src/libs/sqlite/sqlitebasestatement.h:11:
/build/qt-creator-opensource-src-15.0.0/src/libs/sqlite/sqliteids.h:150:36: error: reference to non-static member function must be called
  150 |         convertToString(string, id.contextId);
      |                                 ~~~^~~~~~~~~
In file included from /build/qt-creator-opensource-src-15.0.0/src/libs/sqlite/sqlitebasestatement.cpp:4:
/build/qt-creator-opensource-src-15.0.0/src/libs/sqlite/sqlitebasestatement.h:416:43: error: no member named 'resetter' in 'BaseSqliteResultRange<ResultType>'
  416 |             : m_statement{std::move(other.resetter)}
      |                                     ~~~~~ ^
2 errors generated.
[173/4146] Building CXX object src/libs/sqlite/CMakeFiles/Sqlite.dir/sqlitedatabase.cpp.o
FAILED: src/libs/sqlite/CMakeFiles/Sqlite.dir/sqlitedatabase.cpp.o
/nix/store/xl0vlc2wdchfbq8536zs19pj2r3xdmma-clang-wrapper-19.1.5/bin/clang++ -DNANOTRACE_ENABLED -DQT_CORE_LIB -DQT_CREATOR -DQT_DISABLE_DEPRECATED_BEFORE=0x050900 -DQT_DISABLE_DEPRECATED_UP_TO=0x050900 -DQT_GUI_LIB -DQT_NO_CAST_TO_ASCII -DQT_NO_DEBUG -DQT_NO_FOREACH -DQT_NO_JAVA_STYLE_ITERATORS -DQT_RESTRICTED_CAST_FROM_ASCII -DQT_USE_QSTRINGBUILDER -DQT_WARN_DEPRECATED_BEFORE=0x060400 -DQT_WARN_DEPRECATED_UP_TO=0x060400 -DRELATIVE_DATA_PATH=\"../share/qtcreator\" -DRELATIVE_DOC_PATH=\"../share/doc/qtcreator\" -DRELATIVE_LIBEXEC_PATH=\"../libexec/qtcreator\" -DRELATIVE_PLUGIN_PATH=\"../lib/qtcreator/plugins\" -DSQLITEINTERNAL_LIBRARY -DSQLITE_CUSTOM_INCLUDE=config.h -DSQLITE_LIBRARY -DSqlite_EXPORTS -I/build/qt-creator-opensource-src-15.0.0/build/src/libs/sqlite -I/build/qt-creator-opensource-src-15.0.0/src/libs/sqlite -I/build/qt-creator-opensource-src-15.0.0/src/libs/sqlite/../3rdparty/sqlite -I/build/qt-creator-opensource-src-15.0.0/src/libs -isystem /nix/store/dh5kclrfrvk7aknvk22n2bnz4x8kj1q6-qtbase-6.8.1/include/QtCore -isystem /nix/store/dh5kclrfrvk7aknvk22n2bnz4x8kj1q6-qtbase-6.8.1/mkspecs/linux-g++ -isystem /nix/store/dh5kclrfrvk7aknvk22n2bnz4x8kj1q6-qtbase-6.8.1/include/QtGui -O3 -DNDEBUG -std=c++20 -fPIC -fvisibility=hidden -fvisibility-inlines-hidden -Wall -Wextra -fPIC -Winvalid-pch -Xclang -include-pch -Xclang /build/qt-creator-opensource-src-15.0.0/build/src/libs/3rdparty/syntax-highlighting/CMakeFiles/QtCreatorPchConsole.dir/cmake_pch.hxx.pch -Xclang -include -Xclang /build/qt-creator-opensource-src-15.0.0/build/src/libs/3rdparty/syntax-highlighting/CMakeFiles/QtCreatorPchConsole.dir/cmake_pch.hxx -MD -MT src/libs/sqlite/CMakeFiles/Sqlite.dir/sqlitedatabase.cpp.o -MF src/libs/sqlite/CMakeFiles/Sqlite.dir/sqlitedatabase.cpp.o.d -o src/libs/sqlite/CMakeFiles/Sqlite.dir/sqlitedatabase.cpp.o -c /build/qt-creator-opensource-src-15.0.0/src/libs/sqlite/sqlitedatabase.cpp
In file included from /build/qt-creator-opensource-src-15.0.0/src/libs/sqlite/sqlitedatabase.cpp:4:
In file included from /build/qt-creator-opensource-src-15.0.0/src/libs/sqlite/sqlitedatabase.h:9:
In file included from /build/qt-creator-opensource-src-15.0.0/src/libs/sqlite/sqlitereadstatement.h:6:
In file included from /build/qt-creator-opensource-src-15.0.0/src/libs/sqlite/sqlitebasestatement.h:11:
/build/qt-creator-opensource-src-15.0.0/src/libs/sqlite/sqliteids.h:150:36: error: reference to non-static member function must be called
  150 |         convertToString(string, id.contextId);
      |                                 ~~~^~~~~~~~~
In file included from /build/qt-creator-opensource-src-15.0.0/src/libs/sqlite/sqlitedatabase.cpp:4:
In file included from /build/qt-creator-opensource-src-15.0.0/src/libs/sqlite/sqlitedatabase.h:9:
In file included from /build/qt-creator-opensource-src-15.0.0/src/libs/sqlite/sqlitereadstatement.h:6:
/build/qt-creator-opensource-src-15.0.0/src/libs/sqlite/sqlitebasestatement.h:416:43: error: no member named 'resetter' in 'BaseSqliteResultRange<ResultType>'
  416 |             : m_statement{std::move(other.resetter)}
      |                                     ~~~~~ ^
2 errors generated.
[174/4146] Building CXX object src/libs/sqlite/CMakeFiles/Sqlite.dir/sqlitedatabasebackend.cpp.o
FAILED: src/libs/sqlite/CMakeFiles/Sqlite.dir/sqlitedatabasebackend.cpp.o
/nix/store/xl0vlc2wdchfbq8536zs19pj2r3xdmma-clang-wrapper-19.1.5/bin/clang++ -DNANOTRACE_ENABLED -DQT_CORE_LIB -DQT_CREATOR -DQT_DISABLE_DEPRECATED_BEFORE=0x050900 -DQT_DISABLE_DEPRECATED_UP_TO=0x050900 -DQT_GUI_LIB -DQT_NO_CAST_TO_ASCII -DQT_NO_DEBUG -DQT_NO_FOREACH -DQT_NO_JAVA_STYLE_ITERATORS -DQT_RESTRICTED_CAST_FROM_ASCII -DQT_USE_QSTRINGBUILDER -DQT_WARN_DEPRECATED_BEFORE=0x060400 -DQT_WARN_DEPRECATED_UP_TO=0x060400 -DRELATIVE_DATA_PATH=\"../share/qtcreator\" -DRELATIVE_DOC_PATH=\"../share/doc/qtcreator\" -DRELATIVE_LIBEXEC_PATH=\"../libexec/qtcreator\" -DRELATIVE_PLUGIN_PATH=\"../lib/qtcreator/plugins\" -DSQLITEINTERNAL_LIBRARY -DSQLITE_CUSTOM_INCLUDE=config.h -DSQLITE_LIBRARY -DSqlite_EXPORTS -I/build/qt-creator-opensource-src-15.0.0/build/src/libs/sqlite -I/build/qt-creator-opensource-src-15.0.0/src/libs/sqlite -I/build/qt-creator-opensource-src-15.0.0/src/libs/sqlite/../3rdparty/sqlite -I/build/qt-creator-opensource-src-15.0.0/src/libs -isystem /nix/store/dh5kclrfrvk7aknvk22n2bnz4x8kj1q6-qtbase-6.8.1/include/QtCore -isystem /nix/store/dh5kclrfrvk7aknvk22n2bnz4x8kj1q6-qtbase-6.8.1/mkspecs/linux-g++ -isystem /nix/store/dh5kclrfrvk7aknvk22n2bnz4x8kj1q6-qtbase-6.8.1/include/QtGui -O3 -DNDEBUG -std=c++20 -fPIC -fvisibility=hidden -fvisibility-inlines-hidden -Wall -Wextra -fPIC -Winvalid-pch -Xclang -include-pch -Xclang /build/qt-creator-opensource-src-15.0.0/build/src/libs/3rdparty/syntax-highlighting/CMakeFiles/QtCreatorPchConsole.dir/cmake_pch.hxx.pch -Xclang -include -Xclang /build/qt-creator-opensource-src-15.0.0/build/src/libs/3rdparty/syntax-highlighting/CMakeFiles/QtCreatorPchConsole.dir/cmake_pch.hxx -MD -MT src/libs/sqlite/CMakeFiles/Sqlite.dir/sqlitedatabasebackend.cpp.o -MF src/libs/sqlite/CMakeFiles/Sqlite.dir/sqlitedatabasebackend.cpp.o.d -o src/libs/sqlite/CMakeFiles/Sqlite.dir/sqlitedatabasebackend.cpp.o -c /build/qt-creator-opensource-src-15.0.0/src/libs/sqlite/sqlitedatabasebackend.cpp
In file included from /build/qt-creator-opensource-src-15.0.0/src/libs/sqlite/sqlitedatabasebackend.cpp:6:
In file included from /build/qt-creator-opensource-src-15.0.0/src/libs/sqlite/sqlitebasestatement.h:11:
/build/qt-creator-opensource-src-15.0.0/src/libs/sqlite/sqliteids.h:150:36: error: reference to non-static member function must be called
  150 |         convertToString(string, id.contextId);
      |                                 ~~~^~~~~~~~~
In file included from /build/qt-creator-opensource-src-15.0.0/src/libs/sqlite/sqlitedatabasebackend.cpp:6:
/build/qt-creator-opensource-src-15.0.0/src/libs/sqlite/sqlitebasestatement.h:416:43: error: no member named 'resetter' in 'BaseSqliteResultRange<ResultType>'
  416 |             : m_statement{std::move(other.resetter)}
      |                                     ~~~~~ ^
2 errors generated.
[175/4146] Building CXX object src/libs/sqlite/CMakeFiles/Sqlite.dir/sqliteexception.cpp.o
[176/4146] Building CXX object src/libs/sqlite/CMakeFiles/Sqlite.dir/sqlitesessionchangeset.cpp.o
FAILED: src/libs/sqlite/CMakeFiles/Sqlite.dir/sqlitesessionchangeset.cpp.o
/nix/store/xl0vlc2wdchfbq8536zs19pj2r3xdmma-clang-wrapper-19.1.5/bin/clang++ -DNANOTRACE_ENABLED -DQT_CORE_LIB -DQT_CREATOR -DQT_DISABLE_DEPRECATED_BEFORE=0x050900 -DQT_DISABLE_DEPRECATED_UP_TO=0x050900 -DQT_GUI_LIB -DQT_NO_CAST_TO_ASCII -DQT_NO_DEBUG -DQT_NO_FOREACH -DQT_NO_JAVA_STYLE_ITERATORS -DQT_RESTRICTED_CAST_FROM_ASCII -DQT_USE_QSTRINGBUILDER -DQT_WARN_DEPRECATED_BEFORE=0x060400 -DQT_WARN_DEPRECATED_UP_TO=0x060400 -DRELATIVE_DATA_PATH=\"../share/qtcreator\" -DRELATIVE_DOC_PATH=\"../share/doc/qtcreator\" -DRELATIVE_LIBEXEC_PATH=\"../libexec/qtcreator\" -DRELATIVE_PLUGIN_PATH=\"../lib/qtcreator/plugins\" -DSQLITEINTERNAL_LIBRARY -DSQLITE_CUSTOM_INCLUDE=config.h -DSQLITE_LIBRARY -DSqlite_EXPORTS -I/build/qt-creator-opensource-src-15.0.0/build/src/libs/sqlite -I/build/qt-creator-opensource-src-15.0.0/src/libs/sqlite -I/build/qt-creator-opensource-src-15.0.0/src/libs/sqlite/../3rdparty/sqlite -I/build/qt-creator-opensource-src-15.0.0/src/libs -isystem /nix/store/dh5kclrfrvk7aknvk22n2bnz4x8kj1q6-qtbase-6.8.1/include/QtCore -isystem /nix/store/dh5kclrfrvk7aknvk22n2bnz4x8kj1q6-qtbase-6.8.1/mkspecs/linux-g++ -isystem /nix/store/dh5kclrfrvk7aknvk22n2bnz4x8kj1q6-qtbase-6.8.1/include/QtGui -O3 -DNDEBUG -std=c++20 -fPIC -fvisibility=hidden -fvisibility-inlines-hidden -Wall -Wextra -fPIC -Winvalid-pch -Xclang -include-pch -Xclang /build/qt-creator-opensource-src-15.0.0/build/src/libs/3rdparty/syntax-highlighting/CMakeFiles/QtCreatorPchConsole.dir/cmake_pch.hxx.pch -Xclang -include -Xclang /build/qt-creator-opensource-src-15.0.0/build/src/libs/3rdparty/syntax-highlighting/CMakeFiles/QtCreatorPchConsole.dir/cmake_pch.hxx -MD -MT src/libs/sqlite/CMakeFiles/Sqlite.dir/sqlitesessionchangeset.cpp.o -MF src/libs/sqlite/CMakeFiles/Sqlite.dir/sqlitesessionchangeset.cpp.o.d -o src/libs/sqlite/CMakeFiles/Sqlite.dir/sqlitesessionchangeset.cpp.o -c /build/qt-creator-opensource-src-15.0.0/src/libs/sqlite/sqlitesessionchangeset.cpp
In file included from /build/qt-creator-opensource-src-15.0.0/src/libs/sqlite/sqlitesessionchangeset.cpp:6:
In file included from /build/qt-creator-opensource-src-15.0.0/src/libs/sqlite/sqlitesessions.h:7:
In file included from /build/qt-creator-opensource-src-15.0.0/src/libs/sqlite/sqlitedatabase.h:9:
In file included from /build/qt-creator-opensource-src-15.0.0/src/libs/sqlite/sqlitereadstatement.h:6:
In file included from /build/qt-creator-opensource-src-15.0.0/src/libs/sqlite/sqlitebasestatement.h:11:
/build/qt-creator-opensource-src-15.0.0/src/libs/sqlite/sqliteids.h:150:36: error: reference to non-static member function must be called
  150 |         convertToString(string, id.contextId);
      |                                 ~~~^~~~~~~~~
In file included from /build/qt-creator-opensource-src-15.0.0/src/libs/sqlite/sqlitesessionchangeset.cpp:6:
In file included from /build/qt-creator-opensource-src-15.0.0/src/libs/sqlite/sqlitesessions.h:7:
In file included from /build/qt-creator-opensource-src-15.0.0/src/libs/sqlite/sqlitedatabase.h:9:
In file included from /build/qt-creator-opensource-src-15.0.0/src/libs/sqlite/sqlitereadstatement.h:6:
/build/qt-creator-opensource-src-15.0.0/src/libs/sqlite/sqlitebasestatement.h:416:43: error: no member named 'resetter' in 'BaseSqliteResultRange<ResultType>'
  416 |             : m_statement{std::move(other.resetter)}
      |                                     ~~~~~ ^
2 errors generated.
[177/4146] Building CXX object src/libs/sqlite/CMakeFiles/Sqlite.dir/sqlitefunctionregistry.cpp.o
FAILED: src/libs/sqlite/CMakeFiles/Sqlite.dir/sqlitefunctionregistry.cpp.o
/nix/store/xl0vlc2wdchfbq8536zs19pj2r3xdmma-clang-wrapper-19.1.5/bin/clang++ -DNANOTRACE_ENABLED -DQT_CORE_LIB -DQT_CREATOR -DQT_DISABLE_DEPRECATED_BEFORE=0x050900 -DQT_DISABLE_DEPRECATED_UP_TO=0x050900 -DQT_GUI_LIB -DQT_NO_CAST_TO_ASCII -DQT_NO_DEBUG -DQT_NO_FOREACH -DQT_NO_JAVA_STYLE_ITERATORS -DQT_RESTRICTED_CAST_FROM_ASCII -DQT_USE_QSTRINGBUILDER -DQT_WARN_DEPRECATED_BEFORE=0x060400 -DQT_WARN_DEPRECATED_UP_TO=0x060400 -DRELATIVE_DATA_PATH=\"../share/qtcreator\" -DRELATIVE_DOC_PATH=\"../share/doc/qtcreator\" -DRELATIVE_LIBEXEC_PATH=\"../libexec/qtcreator\" -DRELATIVE_PLUGIN_PATH=\"../lib/qtcreator/plugins\" -DSQLITEINTERNAL_LIBRARY -DSQLITE_CUSTOM_INCLUDE=config.h -DSQLITE_LIBRARY -DSqlite_EXPORTS -I/build/qt-creator-opensource-src-15.0.0/build/src/libs/sqlite -I/build/qt-creator-opensource-src-15.0.0/src/libs/sqlite -I/build/qt-creator-opensource-src-15.0.0/src/libs/sqlite/../3rdparty/sqlite -I/build/qt-creator-opensource-src-15.0.0/src/libs -isystem /nix/store/dh5kclrfrvk7aknvk22n2bnz4x8kj1q6-qtbase-6.8.1/include/QtCore -isystem /nix/store/dh5kclrfrvk7aknvk22n2bnz4x8kj1q6-qtbase-6.8.1/mkspecs/linux-g++ -isystem /nix/store/dh5kclrfrvk7aknvk22n2bnz4x8kj1q6-qtbase-6.8.1/include/QtGui -O3 -DNDEBUG -std=c++20 -fPIC -fvisibility=hidden -fvisibility-inlines-hidden -Wall -Wextra -fPIC -Winvalid-pch -Xclang -include-pch -Xclang /build/qt-creator-opensource-src-15.0.0/build/src/libs/3rdparty/syntax-highlighting/CMakeFiles/QtCreatorPchConsole.dir/cmake_pch.hxx.pch -Xclang -include -Xclang /build/qt-creator-opensource-src-15.0.0/build/src/libs/3rdparty/syntax-highlighting/CMakeFiles/QtCreatorPchConsole.dir/cmake_pch.hxx -MD -MT src/libs/sqlite/CMakeFiles/Sqlite.dir/sqlitefunctionregistry.cpp.o -MF src/libs/sqlite/CMakeFiles/Sqlite.dir/sqlitefunctionregistry.cpp.o.d -o src/libs/sqlite/CMakeFiles/Sqlite.dir/sqlitefunctionregistry.cpp.o -c /build/qt-creator-opensource-src-15.0.0/src/libs/sqlite/sqlitefunctionregistry.cpp
In file included from /build/qt-creator-opensource-src-15.0.0/src/libs/sqlite/sqlitefunctionregistry.cpp:4:
In file included from /build/qt-creator-opensource-src-15.0.0/src/libs/sqlite/sqlitefunctionregistry.h:6:
In file included from /build/qt-creator-opensource-src-15.0.0/src/libs/sqlite/sqlitedatabase.h:9:
In file included from /build/qt-creator-opensource-src-15.0.0/src/libs/sqlite/sqlitereadstatement.h:6:
In file included from /build/qt-creator-opensource-src-15.0.0/src/libs/sqlite/sqlitebasestatement.h:11:
/build/qt-creator-opensource-src-15.0.0/src/libs/sqlite/sqliteids.h:150:36: error: reference to non-static member function must be called
  150 |         convertToString(string, id.contextId);
      |                                 ~~~^~~~~~~~~
In file included from /build/qt-creator-opensource-src-15.0.0/src/libs/sqlite/sqlitefunctionregistry.cpp:4:
In file included from /build/qt-creator-opensource-src-15.0.0/src/libs/sqlite/sqlitefunctionregistry.h:6:
In file included from /build/qt-creator-opensource-src-15.0.0/src/libs/sqlite/sqlitedatabase.h:9:
In file included from /build/qt-creator-opensource-src-15.0.0/src/libs/sqlite/sqlitereadstatement.h:6:
/build/qt-creator-opensource-src-15.0.0/src/libs/sqlite/sqlitebasestatement.h:416:43: error: no member named 'resetter' in 'BaseSqliteResultRange<ResultType>'
  416 |             : m_statement{std::move(other.resetter)}
      |                                     ~~~~~ ^
2 errors generated.
[178/4146] Automatic MOC and UIC for target Utils
[179/4146] Building C object src/libs/sqlite/CMakeFiles/SqliteInternal.dir/__/3rdparty/sqlite/sqlite3.c.o

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

@ofborg build qtcreator

nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 368736

x86_64-linux

:fast_forward: 10 packages marked as broken and skipped:

rocmPackages.mivisionx
rocmPackages.mivisionx-cpu
rocmPackages.mivisionx-hip
rocmPackages_5.mivisionx
rocmPackages_5.mivisionx-cpu
rocmPackages_5.mivisionx-hip
rocmPackages_5.mivisionx-opencl
rocmPackages_6.mivisionx
rocmPackages_6.mivisionx-cpu
rocmPackages_6.mivisionx-hip

:white_check_mark: 1 package built:

qtcreator

authors: wentasah wineee


text:
whitebox-tools: init at 0.9.0

Motivation for this change
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Fits CONTRIBUTING.md.

@GrahamcOfBorg build whitebox-tools

Failure on aarch64-linux (full log)
Attempted: whitebox-tools
Partial log (click to expand)
cannot build derivation '/nix/store/1hgh2pg0gis0g29dkcc5aj5gh2a03ci8-rust_serde_derive-1.0.18.drv': 6 dependencies couldn't be built
cannot build derivation '/nix/store/132j7mfl04zb7vlhdj9a6kgm6i3668bj-rust_crates-io-0.11.0.drv': 30 dependencies couldn't be built
cannot build derivation '/nix/store/37lmq2kc9fwscasgjvwr5s7wpjgjd636-rust_docopt-0.8.1.drv': 19 dependencies couldn't be built
cannot build derivation '/nix/store/6i9xgpvlp3i943v09n91p4yc97vhhcvc-rust_git2-curl-0.7.0.drv': 20 dependencies couldn't be built
cannot build derivation '/nix/store/hdsnr2qc7ac19rnb9mrl3hj7w3107gzh-rust_ignore-0.2.2.drv': 18 dependencies couldn't be built
cannot build derivation '/nix/store/sbg4sjdjg534ij7g4ki9vj41s5kxiisq-rust_cargo-0.22.0.drv': 78 dependencies couldn't be built
cannot build derivation '/nix/store/vdaccxg8m8yjxk4vhv2m54ygykmhfabs-rust_cargo-vendor-0.1.13.drv': 79 dependencies couldn't be built
cannot build derivation '/nix/store/szv1gqq935xrhsb9bsj76i268qg779fa-whitebox_tools-0.9.0-vendor.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/i03ar26jrqv7snss735w73wlcr3wpm4q-whitebox_tools-0.9.0.drv': 3 dependencies couldn't be built
error: build of '/nix/store/i03ar26jrqv7snss735w73wlcr3wpm4q-whitebox_tools-0.9.0.drv' failed

Failure on x86_64-linux (full log)
Attempted: whitebox-tools
Partial log (click to expand)
cannot build derivation '/nix/store/gk7jma27balgcjhkm4r40zrb64b39hn5-rust_serde_derive-1.0.18.drv': 6 dependencies couldn't be built
cannot build derivation '/nix/store/cb42b4wsk5531gfvw7nagwhk100dlh8z-rust_crates-io-0.11.0.drv': 30 dependencies couldn't be built
cannot build derivation '/nix/store/sly01qb04j3i03qi3m61905v8v5c7lvb-rust_docopt-0.8.1.drv': 19 dependencies couldn't be built
cannot build derivation '/nix/store/w9zzb5fdr7pb1afv7j2lc3ls2nz0yg26-rust_git2-curl-0.7.0.drv': 20 dependencies couldn't be built
cannot build derivation '/nix/store/dz3j5lf77pd0pjv4jy971z8nnmp4qxhw-rust_ignore-0.2.2.drv': 18 dependencies couldn't be built
cannot build derivation '/nix/store/53xkf9vyx0b7ipw0b383jr5dsz82bhjd-rust_cargo-0.22.0.drv': 78 dependencies couldn't be built
cannot build derivation '/nix/store/yjvsqlbilv24ychxkd52qylf7qcqk93n-rust_cargo-vendor-0.1.13.drv': 79 dependencies couldn't be built
cannot build derivation '/nix/store/4c1vdq45pl0cfx73m08pmm35if3cgyag-whitebox_tools-0.9.0-vendor.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/22mqd97n017cjr5p9nyiivr09vkzmp93-whitebox_tools-0.9.0.drv': 3 dependencies couldn't be built
error: build of '/nix/store/22mqd97n017cjr5p9nyiivr09vkzmp93-whitebox_tools-0.9.0.drv' failed

Looks like rustc-1.27.0 is broken.

Success on x86_64-linux (full log)
Attempted: whitebox-tools
Partial log (click to expand)

installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/bqyzzfda84cfamsqm57pcxd0a4yqa8f1-whitebox_tools-0.9.0
shrinking /nix/store/bqyzzfda84cfamsqm57pcxd0a4yqa8f1-whitebox_tools-0.9.0/bin/whitebox_tools
strip is /nix/store/4qvrxzxa535y8304mk195x50b6p9607d-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/bqyzzfda84cfamsqm57pcxd0a4yqa8f1-whitebox_tools-0.9.0/bin
patching script interpreter paths in /nix/store/bqyzzfda84cfamsqm57pcxd0a4yqa8f1-whitebox_tools-0.9.0
checking for references to /build in /nix/store/bqyzzfda84cfamsqm57pcxd0a4yqa8f1-whitebox_tools-0.9.0...
/nix/store/bqyzzfda84cfamsqm57pcxd0a4yqa8f1-whitebox_tools-0.9.0

Failure on x86_64-darwin (full log)
Attempted: whitebox-tools
Partial log (click to expand)
          clang-5.0: error: linker command failed with exit code 1 (use -v to see invocation)

error: aborting due to previous error

error: Could not compile `whitebox_tools`.

To learn more, run the command again with --verbose.
builder for '/nix/store/z75nbfh8m4v0gazbzbja0w1nk3i71rc9-whitebox_tools-0.9.0.drv' failed with exit code 101
error: build of '/nix/store/z75nbfh8m4v0gazbzbja0w1nk3i71rc9-whitebox_tools-0.9.0.drv' failed

Success on aarch64-linux (full log)
Attempted: whitebox-tools
Partial log (click to expand)

installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/1q5xyrymspw126pzhlc8jzrnr5lq8d3i-whitebox_tools-0.9.0
shrinking /nix/store/1q5xyrymspw126pzhlc8jzrnr5lq8d3i-whitebox_tools-0.9.0/bin/whitebox_tools
strip is /nix/store/0pjsgkxz0rp5baycq5sp2s72lrr5q9sg-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/1q5xyrymspw126pzhlc8jzrnr5lq8d3i-whitebox_tools-0.9.0/bin
patching script interpreter paths in /nix/store/1q5xyrymspw126pzhlc8jzrnr5lq8d3i-whitebox_tools-0.9.0
checking for references to /build in /nix/store/1q5xyrymspw126pzhlc8jzrnr5lq8d3i-whitebox_tools-0.9.0...
/nix/store/1q5xyrymspw126pzhlc8jzrnr5lq8d3i-whitebox_tools-0.9.0

I'll fix this on darwin.

@GrahamcOfBorg build whitebox-tools

Success on aarch64-linux (full log)
Attempted: whitebox-tools
Partial log (click to expand)
/nix/store/1q5xyrymspw126pzhlc8jzrnr5lq8d3i-whitebox_tools-0.9.0

Success on x86_64-linux (full log)
Attempted: whitebox-tools
Partial log (click to expand)

installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/bqyzzfda84cfamsqm57pcxd0a4yqa8f1-whitebox_tools-0.9.0
shrinking /nix/store/bqyzzfda84cfamsqm57pcxd0a4yqa8f1-whitebox_tools-0.9.0/bin/whitebox_tools
strip is /nix/store/4qvrxzxa535y8304mk195x50b6p9607d-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/bqyzzfda84cfamsqm57pcxd0a4yqa8f1-whitebox_tools-0.9.0/bin
patching script interpreter paths in /nix/store/bqyzzfda84cfamsqm57pcxd0a4yqa8f1-whitebox_tools-0.9.0
checking for references to /build in /nix/store/bqyzzfda84cfamsqm57pcxd0a4yqa8f1-whitebox_tools-0.9.0...
/nix/store/bqyzzfda84cfamsqm57pcxd0a4yqa8f1-whitebox_tools-0.9.0

to check darwin build:
@GrahamcOfBorg build whitebox-tools

Success on x86_64-linux (full log)
Attempted: whitebox-tools
Partial log (click to expand)

installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/bqyzzfda84cfamsqm57pcxd0a4yqa8f1-whitebox_tools-0.9.0
shrinking /nix/store/bqyzzfda84cfamsqm57pcxd0a4yqa8f1-whitebox_tools-0.9.0/bin/whitebox_tools
strip is /nix/store/4qvrxzxa535y8304mk195x50b6p9607d-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/bqyzzfda84cfamsqm57pcxd0a4yqa8f1-whitebox_tools-0.9.0/bin
patching script interpreter paths in /nix/store/bqyzzfda84cfamsqm57pcxd0a4yqa8f1-whitebox_tools-0.9.0
checking for references to /tmp/nix-build-whitebox_tools-0.9.0.drv-0 in /nix/store/bqyzzfda84cfamsqm57pcxd0a4yqa8f1-whitebox_tools-0.9.0...
/nix/store/bqyzzfda84cfamsqm57pcxd0a4yqa8f1-whitebox_tools-0.9.0

Success on x86_64-darwin (full log)
Attempted: whitebox-tools
Partial log (click to expand)
running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out

installing
post-installation fixup
strip is /nix/store/7ddbq63v97nk8gkbf7gcsfmby37h6gbl-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/yr4b8lpfjixkh97nn8a73qhrj3z5q10n-whitebox_tools-0.9.0/bin
patching script interpreter paths in /nix/store/yr4b8lpfjixkh97nn8a73qhrj3z5q10n-whitebox_tools-0.9.0
/nix/store/yr4b8lpfjixkh97nn8a73qhrj3z5q10n-whitebox_tools-0.9.0

Success on aarch64-linux (full log)
Attempted: whitebox-tools
Partial log (click to expand)

installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/1q5xyrymspw126pzhlc8jzrnr5lq8d3i-whitebox_tools-0.9.0
shrinking /nix/store/1q5xyrymspw126pzhlc8jzrnr5lq8d3i-whitebox_tools-0.9.0/bin/whitebox_tools
strip is /nix/store/0pjsgkxz0rp5baycq5sp2s72lrr5q9sg-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/1q5xyrymspw126pzhlc8jzrnr5lq8d3i-whitebox_tools-0.9.0/bin
patching script interpreter paths in /nix/store/1q5xyrymspw126pzhlc8jzrnr5lq8d3i-whitebox_tools-0.9.0
checking for references to /build in /nix/store/1q5xyrymspw126pzhlc8jzrnr5lq8d3i-whitebox_tools-0.9.0...
/nix/store/1q5xyrymspw126pzhlc8jzrnr5lq8d3i-whitebox_tools-0.9.0

authors: GrahamcOfBorg Infinisil mpickering nlewo xeji


text:
zn_poly: 0.9 -> 0.9.1

Motivation for this change
Sage has taken over maintenance since the original author no longer
maintains the project.
The upgrade integrates various patches from sage. It also enables tuning by default, which now has to be disabled explicitly.
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Fits CONTRIBUTING.md.

Success on aarch64-linux (full log)
Attempted: zn_poly
Partial log (click to expand)
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/ff4ya6fy78g5fzzym185sfk8fg3wr8kp-zn_poly-0.9.1
shrinking /nix/store/ff4ya6fy78g5fzzym185sfk8fg3wr8kp-zn_poly-0.9.1/lib/libzn_poly.so
shrinking /nix/store/ff4ya6fy78g5fzzym185sfk8fg3wr8kp-zn_poly-0.9.1/lib/libzn_poly-0.9.so
shrinking /nix/store/ff4ya6fy78g5fzzym185sfk8fg3wr8kp-zn_poly-0.9.1/lib/libzn_poly-0.9.1.so
strip is /nix/store/428gs2z4b8f9byvghzlpbjwjb3a7jwxx-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/ff4ya6fy78g5fzzym185sfk8fg3wr8kp-zn_poly-0.9.1/lib
patching script interpreter paths in /nix/store/ff4ya6fy78g5fzzym185sfk8fg3wr8kp-zn_poly-0.9.1
checking for references to /build in /nix/store/ff4ya6fy78g5fzzym185sfk8fg3wr8kp-zn_poly-0.9.1...
/nix/store/ff4ya6fy78g5fzzym185sfk8fg3wr8kp-zn_poly-0.9.1

Success on x86_64-darwin (full log)
Attempted: zn_poly
Partial log (click to expand)
zn_array_mul_fft_dft()... ok
zn_array_invert()... ok

All tests passed.
installing
post-installation fixup
strip is /nix/store/9xjkb4xz0b5lmizij9ppxy7lkxdxhx6b-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/5rns1nmh7zkkljdsax34s6714q17wdkk-zn_poly-0.9.1/lib
patching script interpreter paths in /nix/store/5rns1nmh7zkkljdsax34s6714q17wdkk-zn_poly-0.9.1
/nix/store/5rns1nmh7zkkljdsax34s6714q17wdkk-zn_poly-0.9.1

Success on x86_64-linux (full log)
Attempted: zn_poly
Partial log (click to expand)
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/85iam4zzihnkkrjrlanal487ykv03xa5-zn_poly-0.9.1
shrinking /nix/store/85iam4zzihnkkrjrlanal487ykv03xa5-zn_poly-0.9.1/lib/libzn_poly-0.9.1.so
shrinking /nix/store/85iam4zzihnkkrjrlanal487ykv03xa5-zn_poly-0.9.1/lib/libzn_poly-0.9.so
shrinking /nix/store/85iam4zzihnkkrjrlanal487ykv03xa5-zn_poly-0.9.1/lib/libzn_poly.so
strip is /nix/store/dxf1m7dhc4qb655bdljc1fsd74v1nag3-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/85iam4zzihnkkrjrlanal487ykv03xa5-zn_poly-0.9.1/lib
patching script interpreter paths in /nix/store/85iam4zzihnkkrjrlanal487ykv03xa5-zn_poly-0.9.1
checking for references to /build in /nix/store/85iam4zzihnkkrjrlanal487ykv03xa5-zn_poly-0.9.1...
/nix/store/85iam4zzihnkkrjrlanal487ykv03xa5-zn_poly-0.9.1

authors: GrahamcOfBorg timokau


text:
gitea: 1.5.1 -> 1.5.2

Motivation for this change
https://blog.gitea.io/2018/10/gitea-1.5.2-is-released/
“This is a smaller release, with only 12 merged PRs, but it contains several security related fixes and so we recommend upgrading whenever possible.”
Should therefore be safe to backport to 18.09, and required to get the security fixes.
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[X] Fits CONTRIBUTING.md.

Maintainer: @disassembler

Failure on aarch64-linux (full log)
Attempted: gitea
Partial log (click to expand)
code.gitea.io/gitea/models
code.gitea.io/gitea/modules/notification
code.gitea.io/gitea/modules/templates
code.gitea.io/gitea/modules/auth
code.gitea.io/gitea/modules/context
code.gitea.io/gitea/modules/lfs
code.gitea.io/gitea/routers/repo
code.gitea.io/gitea/routers/user
builder for '/nix/store/rz4y8f8pppi5k194gj7k89cskiapy8hf-gitea-1.5.2.drv' failed with exit code 47
error: build of '/nix/store/rz4y8f8pppi5k194gj7k89cskiapy8hf-gitea-1.5.2.drv' failed

Unexpected error: command failed with exit code 1 on x86_64-darwin (full log)
Attempted: gitea
Partial log (click to expand)

trying https://github.com/go-gitea/gitea/archive/v1.5.2.tar.gz
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   122    0   122    0     0    203      0 --:--:-- --:--:-- --:--:--   202
100 17.9M    0 17.9M    0     0  4643k      0 --:--:--  0:00:03 --:--:-- 6856k
unpacking source archive /private/tmp/nix-build-source.drv-0/v1.5.2.tar.gz
fixed-output derivation produced path '/nix/store/4gydlwklm9v77jk8zj3n03f7csmkq18z-source' with sha256 hash '1dr7pxb60y215625nndmisxl6n5zlq1aicaswsg3xfzlk7a93k7k' instead of the expected hash '049f4gs1lw14l0ybz6rx6sibwpqdihqrx1qgvs6ghy6asrc2blif'
cannot build derivation '/nix/store/jsm9n5l3qsr8n7filwzmcbxvkvpgf3xa-gitea-1.5.2.drv': 1 dependencies couldn't be built
error: build of '/nix/store/jsm9n5l3qsr8n7filwzmcbxvkvpgf3xa-gitea-1.5.2.drv' failed

aarch64 failure looks like a builder issue, we can try again later.
Please fix the hash mismatch on darwin.

Success on x86_64-linux (full log)
Attempted: gitea
Partial log (click to expand)
checking for references to /build in /nix/store/fz05imgv890j71v5jp8bc8j54wqvx9is-gitea-1.5.2-bin...
shrinking RPATHs of ELF executables and libraries in /nix/store/hypb926rcw4dw6df3pf9pshrj54mnxvy-gitea-1.5.2
strip is /nix/store/dxf1m7dhc4qb655bdljc1fsd74v1nag3-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/hypb926rcw4dw6df3pf9pshrj54mnxvy-gitea-1.5.2
checking for references to /build in /nix/store/hypb926rcw4dw6df3pf9pshrj54mnxvy-gitea-1.5.2...
shrinking RPATHs of ELF executables and libraries in /nix/store/mj23a6lwgj105m2z58rh6llrn3mjymh8-gitea-1.5.2-data
strip is /nix/store/dxf1m7dhc4qb655bdljc1fsd74v1nag3-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/mj23a6lwgj105m2z58rh6llrn3mjymh8-gitea-1.5.2-data
checking for references to /build in /nix/store/mj23a6lwgj105m2z58rh6llrn3mjymh8-gitea-1.5.2-data...
/nix/store/fz05imgv890j71v5jp8bc8j54wqvx9is-gitea-1.5.2-bin

@GrahamcOfBorg build gitea

Unexpected error: command failed with exit code 1 on x86_64-darwin (full log)
Attempted: gitea
Partial log (click to expand)

trying https://github.com/go-gitea/gitea/archive/v1.5.2.tar.gz
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   122    0   122    0     0    652      0 --:--:-- --:--:-- --:--:--   655
100 17.9M    0 17.9M    0     0  5791k      0 --:--:--  0:00:03 --:--:-- 6654k
unpacking source archive /private/tmp/nix-build-source.drv-0/v1.5.2.tar.gz
fixed-output derivation produced path '/nix/store/4gydlwklm9v77jk8zj3n03f7csmkq18z-source' with sha256 hash '1dr7pxb60y215625nndmisxl6n5zlq1aicaswsg3xfzlk7a93k7k' instead of the expected hash '049f4gs1lw14l0ybz6rx6sibwpqdihqrx1qgvs6ghy6asrc2blif'
cannot build derivation '/nix/store/jsm9n5l3qsr8n7filwzmcbxvkvpgf3xa-gitea-1.5.2.drv': 1 dependencies couldn't be built
error: build of '/nix/store/jsm9n5l3qsr8n7filwzmcbxvkvpgf3xa-gitea-1.5.2.drv' failed

Success on x86_64-linux (full log)
Attempted: gitea
Partial log (click to expand)
/nix/store/fz05imgv890j71v5jp8bc8j54wqvx9is-gitea-1.5.2-bin

Failure on aarch64-linux (full log)
Attempted: gitea
Partial log (click to expand)
code.gitea.io/gitea/routers/api/v1/repo
code.gitea.io/gitea/routers/api/v1/user
code.gitea.io/gitea/routers
code.gitea.io/gitea/routers/api/v1/org
code.gitea.io/gitea/routers/api/v1/admin
code.gitea.io/gitea/routers/admin
code.gitea.io/gitea/routers/api/v1
code.gitea.io/gitea/routers/routes
builder for '/nix/store/rz4y8f8pppi5k194gj7k89cskiapy8hf-gitea-1.5.2.drv' failed with exit code 45
error: build of '/nix/store/rz4y8f8pppi5k194gj7k89cskiapy8hf-gitea-1.5.2.drv' failed

builds fine on aarch64 when issued with --option cores 2. Probably some limitation with the default go routine settings. I vaguely recall some default thread limits.
@NixOS/darwin-maintainers Any idea why fetchFromGitHub expects a different hash on darwin?
@ElvishJerricco posted the following on IRC:
$ nix-prefetch-url --unpack https://github.com/go-gitea/gitea/archive/v1.5.2.tar.gz
unpacking...
path is '/nix/store/n3bg2vhxv8yfc631la9gfykglg3f55b3-v1.5.2.tar.gz'
049f4gs1lw14l0ybz6rx6sibwpqdihqrx1qgvs6ghy6asrc2blif

$ ssh my-mac nix-prefetch-url --unpack https://github.com/go-gitea/gitea/archive/v1.5.2.tar.gz
unpacking...
path is '/nix/store/jq8p6y5zjzhaipsb5wg6bqziw7i45q7g-v1.5.2.tar.gz'
1dr7pxb60y215625nndmisxl6n5zlq1aicaswsg3xfzlk7a93k7k

```

My first guess is that it's due to macOS's case sensitive file system, but I haven't confirmed that the repo actually has any collisions.

Doesn't appear to have obvious case collisions on this macOS, so I'm not sure why it fails.
Furthermore, I'm on macOS, and:
$ nix-prefetch-url --unpack https://github.com/go-gitea/gitea/archive/v1.5.2.tar.gz
unpacking...
path is '/nix/store/n3bg2vhxv8yfc631la9gfykglg3f55b3-v1.5.2.tar.gz'
049f4gs1lw14l0ybz6rx6sibwpqdihqrx1qgvs6ghy6asrc2blif

I'm not running a case-sensitive filesystem so I'm puzzled.

@ElvishJerricco I can't get the other .tar.gz, but perhaps you can unpack and diff the two trees on your linux box?

@copumpkin:
$ linux=/nix/store/n3bg2vhxv8yfc631la9gfykglg3f55b3-v1.5.2.tar.gz
$ mac=/nix/store/jq8p6y5zjzhaipsb5wg6bqziw7i45q7g-v1.5.2.tar.gz
$ diff -r $linux $mac
Only in /nix/store/n3bg2vhxv8yfc631la9gfykglg3f55b3-v1.5.2.tar.gz/integrations/gitea-repositories-meta/user2/utf8.git/refs/heads: ブランチ
Only in /nix/store/jq8p6y5zjzhaipsb5wg6bqziw7i45q7g-v1.5.2.tar.gz/integrations/gitea-repositories-meta/user2/utf8.git/refs/heads: ブランチ
Only in /nix/store/jq8p6y5zjzhaipsb5wg6bqziw7i45q7g-v1.5.2.tar.gz/integrations/gitea-repositories-meta/user2/utf8.git/refs/heads: Grüßen
Only in /nix/store/n3bg2vhxv8yfc631la9gfykglg3f55b3-v1.5.2.tar.gz/integrations/gitea-repositories-meta/user2/utf8.git/refs/heads: Grüßen
Only in /nix/store/n3bg2vhxv8yfc631la9gfykglg3f55b3-v1.5.2.tar.gz/integrations/gitea-repositories-meta/user2/utf8.git/refs/tags: タグ
Only in /nix/store/jq8p6y5zjzhaipsb5wg6bqziw7i45q7g-v1.5.2.tar.gz/integrations/gitea-repositories-meta/user2/utf8.git/refs/tags: タグ
Only in /nix/store/jq8p6y5zjzhaipsb5wg6bqziw7i45q7g-v1.5.2.tar.gz/integrations/gitea-repositories-meta/user2/utf8.git/refs/tags: Ё
Only in /nix/store/n3bg2vhxv8yfc631la9gfykglg3f55b3-v1.5.2.tar.gz/integrations/gitea-repositories-meta/user2/utf8.git/refs/tags: Ё
diff: /nix/store/n3bg2vhxv8yfc631la9gfykglg3f55b3-v1.5.2.tar.gz/vendor/github.com/Unknwon/cae/tz/testdata/testdir.lnk: No such file or directory
diff: /nix/store/jq8p6y5zjzhaipsb5wg6bqziw7i45q7g-v1.5.2.tar.gz/vendor/github.com/Unknwon/cae/tz/testdata/testdir.lnk: No such file or directory
diff: /nix/store/n3bg2vhxv8yfc631la9gfykglg3f55b3-v1.5.2.tar.gz/vendor/github.com/Unknwon/cae/tz/testdata/test.lnk: No such file or directory
diff: /nix/store/jq8p6y5zjzhaipsb5wg6bqziw7i45q7g-v1.5.2.tar.gz/vendor/github.com/Unknwon/cae/tz/testdata/test.lnk: No such file or directory
diff: /nix/store/n3bg2vhxv8yfc631la9gfykglg3f55b3-v1.5.2.tar.gz/vendor/github.com/Unknwon/cae/zip/testdata/testdir.lnk: No such file or directory
diff: /nix/store/jq8p6y5zjzhaipsb5wg6bqziw7i45q7g-v1.5.2.tar.gz/vendor/github.com/Unknwon/cae/zip/testdata/testdir.lnk: No such file or directory
diff: /nix/store/n3bg2vhxv8yfc631la9gfykglg3f55b3-v1.5.2.tar.gz/vendor/github.com/Unknwon/cae/zip/testdata/test.lnk: No such file or directory
diff: /nix/store/jq8p6y5zjzhaipsb5wg6bqziw7i45q7g-v1.5.2.tar.gz/vendor/github.com/Unknwon/cae/zip/testdata/test.lnk: No such file or directory
diff: /nix/store/n3bg2vhxv8yfc631la9gfykglg3f55b3-v1.5.2.tar.gz/vendor/gopkg.in/macaron.v1/fixtures/symlink: No such file or directory
diff: /nix/store/jq8p6y5zjzhaipsb5wg6bqziw7i45q7g-v1.5.2.tar.gz/vendor/gopkg.in/macaron.v1/fixtures/symlink: No such file or directory

Maybe something unicode related? I'm on sierra, if that matters.

Ah yes, some of the unicode normalization of combining pairs (whether to store them as two characters or one) behavior can be weird. Not really sure what to do about that, other than to add a postFetch step to our fetchFromGitHub that strips that junk out

@copumpkin @ElvishJerricco does any of you have the time to implement test it?
I do not have a Mac to test it and never used one. Would probably take me 10x just to figure that out with always going through ofBorg :confused:

Here is a previous occurrence of the same issue.
If subdirs vendor and integrations are not necessary to the build process, then you can do:
  src = fetchFromGitHub {
    owner = "go-gitea";
    repo = "gitea";
    rev = "v${version}";
    sha256 = "049f4gs1lw14l0ybz6rx6sibwpqdihqrx1qgvs6ghy6asrc2blif";
    extraPostFetch = "rm -rf $out/integrations && rm -rf $out/vendor";
  };

@c0bw3b you'll need to update the sha256 there.

Yes indeed that hash needs to be re-computed. I edited the code block.

Thank you all for taking a look at this, I was really lost at how it could possibly be the case that MacOS computes a different checksum than on Linux.
As one could expect from their names, I just verified that integrations contains integration tests and is not required for build, while vendor contains various third-party library dependencies and is indeed required, and needs selective manual / automatic filtering.
For further testing / discussion, I pushed a new version with a extraPostFetch that deletes offending files and still seems to work for me.
Some kind of automatic mechanism in the fetch function would still help though, so that this won't return on the next release, and nix-prefetch-git gives the correct sha256 sum. This would lead to hard-to-detect problems though if some project uses / starts to use affected unicode regions in file names that are relevant for the build process.

Could someone with the appropriate permissions please trigger a @GrahamcOfBorg build gitea?

@GrahamcOfBorg build gitea

Failure on aarch64-linux (full log)
Attempted: gitea
Partial log (click to expand)
code.gitea.io/gitea/vendor/github.com/Unknwon/cae/zip
code.gitea.io/gitea/vendor/github.com/glycerine/go-unsnap-stream
code.gitea.io/gitea/vendor/github.com/couchbase/vellum
code.gitea.io/gitea/vendor/code.gitea.io/git
code.gitea.io/gitea/vendor/github.com/Unknwon/i18n
code.gitea.io/gitea/vendor/gopkg.in/editorconfig/editorconfig-core-go.v1
code.gitea.io/gitea/vendor/github.com/go-xorm/xorm
code.gitea.io/gitea/vendor/gopkg.in/testfixtures.v2
builder for '/nix/store/8jijwi2w49hsyfcyhb0mgana4hxp6sbd-gitea-1.5.2.drv' failed with exit code 43
error: build of '/nix/store/8jijwi2w49hsyfcyhb0mgana4hxp6sbd-gitea-1.5.2.drv' failed

Works fine on my mac.
$ nix build -f https://github.com/NixOS/nixpkgs/archive/0a5c7cf512fcefb4b337186f0aee69ae8dd1df2c.tar.gz gitea.src
[1 built, 55 copied (111.7 MiB), 37.0 MiB DL]
/nix/store/cg1gbwbc68ilw81djc13hp78bhgfsqq1-source

Success on x86_64-linux (full log)
Attempted: gitea
Partial log (click to expand)
checking for references to /build in /nix/store/7jk9mp702a9ry6qnv2rc40vhl8pxrzl8-gitea-1.5.2-bin...
shrinking RPATHs of ELF executables and libraries in /nix/store/w5h82yifgv8ifcpjm73v288k65n49766-gitea-1.5.2
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/w5h82yifgv8ifcpjm73v288k65n49766-gitea-1.5.2
checking for references to /build in /nix/store/w5h82yifgv8ifcpjm73v288k65n49766-gitea-1.5.2...
shrinking RPATHs of ELF executables and libraries in /nix/store/h51jpsy5mwx25h73qx3jj4vbs6gfll6z-gitea-1.5.2-data
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/h51jpsy5mwx25h73qx3jj4vbs6gfll6z-gitea-1.5.2-data
checking for references to /build in /nix/store/h51jpsy5mwx25h73qx3jj4vbs6gfll6z-gitea-1.5.2-data...
/nix/store/7jk9mp702a9ry6qnv2rc40vhl8pxrzl8-gitea-1.5.2-bin

18.03: 8ccf5b63b5786fbf1fdda05132df30e78260139b
18.09: 38f5b076d77ce204a237a5dc9238c3586e607707

Thanks! :smiley:

authors: ElvishJerricco GrahamcOfBorg andir c0bw3b copumpkin florianjacob xeji


text:
linux_testing_bcachefs,bcachefs-tools: 2019-03-29

Motivation for this change
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Assured whether relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

At least bcachefs-tools is broken on 2019-03-29.

Thank you!

authors: dywedir eadwu


text:
updating bitcoin and changing source location

I propose we pull the source from bitcoin.org, since the sha256 sums that are GPG signed match the source packages on bitcoin.org, but not the packages on github.
See:
https://bitcoin.org/bin/bitcoin-core-0.10.0/SHA256SUMS.asc
https://bitcoin.org/bin/bitcoin-core-0.10.0/bitcoin-0.10.0.tar.gz
https://github.com/bitcoin/bitcoin/archive/v0.10.0.tar.gz

Paging @roconnor @AndersonTorres since you are listed as maintainers.


text:
dask: 2.2.0 -> 2.5.2, distributed: 2.4.0 -> 2.5.2, dask-ml: 0.11.0 -> 1.0.0, dask-jobqueue: 0.4.1 -> 0.7.0

Motivation for this change
Dask and relative packages were quite outdated.
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[ ] NixOS
[ ] macOS
[x] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

Notify maintainers
cc @FRidh @costrouc

Thanks for the changes! Would you mind splitting out each update to its own commit? That makes it easier for tooling that uses the commit format, and also to selectively back out if something goes wrong.

@teh No problem, there are now four commits.

apologies, one more commit style change suggestion: distributed: 2.4.0->2.5.2 to distributed: 2.4.0 -> 2.5.2 (check the git commit log of nixpkgs for other examples). LGTM otherwise, thanks!

@GrahamcOfBorg build python3.pkgs.dask python3.pkgs.distributed python3.pkgs.dask-ml python3.pkgs.dask-jobqueue

apologies, one more commit style change suggestion: distributed: 2.4.0->2.5.2 to distributed: 2.4.0 -> 2.5.2 (check the git commit log of nixpkgs for other examples). LGTM otherwise, thanks!

Even better, prefix with the package set so it is an actual attribute path. That way the bot can pick it up.

So what do I have to do to get these packages updated? It's been ten days and I see that dask has already been replaced in master.

@francescocarzaniga I think roughly:

resolve conflict
prefix packages e.g. pythonPackages.dask-ml
ping @FRidh to merge

Nothing happening so closing.

authors: FRidh francescocarzaniga teh


text:
kubecfg: 0.12.5 -> 0.13.1

Motivation for this change
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[ ] NixOS
[x] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Notify maintainers
cc @

@GrahamcOfBorg build kubecfg

authors: groodt jonringer