text:
Added dropdown menu for feedback

Added the dropdown menu for feedback column, with some common feedback options (list generated by analyzing previous feedback). Made it so that the dropdown is required, while the additional feedback is not. If the user selects "other" from the dropdown, then the additional feedback becomes required. Made sure that the new "error" field with the common feedback is being sent as part of the payload.

This change is

Initial pass of comments, not looking at UI/UX

Reviewed 5 of 5 files at r1.
Review status: all files reviewed at latest revision, 17 unresolved discussions.

src/generic_ui/locales/en/messages.json, line 1451 [r1] (raw file):

    "message": "Apply"
  },
  "CUSTOM_ERROR_PLACEHOLDER": {

Can you add descriptions for these messages?  Remember, whoever is translating this has no knowledge of anything except what you put there.  The description could be something like "a prompt to give the user asking them to select their favourite emoji after they send a message that does not contain an emoji"

src/generic_ui/polymer/feedback.html, line 86 [r1] (raw file):

    }
    #errorLink core-icon {
      height: 18px !important;

Will this work without !important perchance?  Using that tends to cause complications later on.

src/generic_ui/polymer/feedback.html, line 89 [r1] (raw file):

      width: 18px !important;
    }
    #errorLink paper-item {

The selector here does not give me a good idea of precisely what this is being applied to.  Might make more sense if the outside selector was for the dropdown.

src/generic_ui/polymer/feedback.html, line 90 [r1] (raw file):

    }
    #errorLink paper-item {
      font-size: 16px;

Just double-checking: are both font-sizes necessary?

src/generic_ui/polymer/feedback.html, line 95 [r1] (raw file):

      padding: 0;
    }
    #label:not(.selectedItem) {

I'm having trouble figuring out what element this is being applied to, can you clarify that?

src/generic_ui/polymer/feedback.html, line 100 [r1] (raw file):

    }

Remove blank line please

src/generic_ui/polymer/feedback.html, line 118 [r1] (raw file):

      left: -64px !important;
    }
    paper-input-decorator[id=errorDecorator] /deep/ .unfocused-underline,

For anything affecting a specific element, it's easier to just use #XXX instead of [id=XXX]

src/generic_ui/polymer/feedback.html, line 212 [r1] (raw file):

          </paper-input-decorator>

{{"CUSTOM_ERROR_TITLE" | $$ }}

Can you switch to using double-quotes for HTML attributes?  Thanks.

src/generic_ui/polymer/feedback.html, line 213 [r1] (raw file):

{{"CUSTOM_ERROR_TITLE" | $$ }}

errorLink does not really give me much information about this element just reading it, any chance of making the id more descriptive?

src/generic_ui/polymer/feedback.html, line 214 [r1] (raw file):

{{"CUSTOM_ERROR_TITLE" | $$ }}

          <paper-dropdown-menu label='{{ "CUSTOM_ERROR_PLACEHOLDER" | $$ }}' error='{{"NO_CUSTOM_ERROR_PLACEHOLDER" | $$ }}'>

I think you are missing a level of indentation here

src/generic_ui/polymer/feedback.html, line 214 [r1] (raw file):

{{"CUSTOM_ERROR_TITLE" | $$ }}

          <paper-dropdown-menu label='{{ "CUSTOM_ERROR_PLACEHOLDER" | $$ }}' error='{{"NO_CUSTOM_ERROR_PLACEHOLDER" | $$ }}'>

What is the error attribute for?

src/generic_ui/polymer/feedback.html, line 216 [r1] (raw file):

          <paper-dropdown-menu label='{{ "CUSTOM_ERROR_PLACEHOLDER" | $$ }}' error='{{"NO_CUSTOM_ERROR_PLACEHOLDER" | $$ }}'>
            <paper-dropdown class="dropdown" valign="bottom">
                <core-menu class="menu" on-core-select='{{ updateError }}' selected=null id='errorInput'>

What is the selected=null for?

src/generic_ui/polymer/feedback.html, line 216 [r1] (raw file):

          <paper-dropdown-menu label='{{ "CUSTOM_ERROR_PLACEHOLDER" | $$ }}' error='{{"NO_CUSTOM_ERROR_PLACEHOLDER" | $$ }}'>
            <paper-dropdown class="dropdown" valign="bottom">
                <core-menu class="menu" on-core-select='{{ updateError }}' selected=null id='errorInput'>

It seems to me that it might be easier to bind selected to a variable instead of using the core-select event, any reason why we're using the event?

src/generic_ui/polymer/feedback.html, line 217 [r1] (raw file):

            <paper-dropdown class="dropdown" valign="bottom">
                <core-menu class="menu" on-core-select='{{ updateError }}' selected=null id='errorInput'>
                      <paper-item errorCode = 'Cloud gets disconnected'> My cloud connections get disconnected.</paper-item>

For style consistency, there should not be spaces around the = signs here.

src/generic_ui/polymer/feedback.html, line 217 [r1] (raw file):

            <paper-dropdown class="dropdown" valign="bottom">
                <core-menu class="menu" on-core-select='{{ updateError }}' selected=null id='errorInput'>
                      <paper-item errorCode = 'Cloud gets disconnected'> My cloud connections get disconnected.</paper-item>

In general, try to avoid creating your own html attributes.  The normal way to handle this is to use data attributes.

src/generic_ui/polymer/feedback.html, line 217 [r1] (raw file):

            <paper-dropdown class="dropdown" valign="bottom">
                <core-menu class="menu" on-core-select='{{ updateError }}' selected=null id='errorInput'>
                      <paper-item errorCode = 'Cloud gets disconnected'> My cloud connections get disconnected.</paper-item>

Please add these strings as messages

src/generic_ui/polymer/feedback.ts, line 87 [r1] (raw file):

    if (detail.isSelected) {
      this.error = detail.item.getAttribute('errorCode');

Blank line

Comments from Reviewable

Review status: 2 of 5 files reviewed at latest revision, 17 unresolved discussions.

src/generic_ui/locales/en/messages.json, line 1451 [r1] (raw file):
Previously, jpevarnek (Jonathan Pevarnek) wrote…
> Can you add descriptions for these messages?  Remember, whoever is translating this has no knowledge of anything except what you put there.  The description could be something like "a prompt to give the user asking them to select their favourite emoji after they send a message that does not contain an emoji"

Done.

src/generic_ui/polymer/feedback.html, line 86 [r1] (raw file):
Previously, jpevarnek (Jonathan Pevarnek) wrote…
> Will this work without `!important` perchance?  Using that tends to cause complications later on.

I copied code from the splash.html file, which also had a dropdown, because my original code for a dropdown wasn't working. Because of this, I am not really sure if !important is what makes it work, but it didn't seem to break after I removed it!

src/generic_ui/polymer/feedback.html, line 89 [r1] (raw file):
Previously, jpevarnek (Jonathan Pevarnek) wrote…
> The selector here does not give me a good idea of precisely what this is being applied to.  Might make more sense if the outside selector was for the dropdown.

Done.

src/generic_ui/polymer/feedback.html, line 90 [r1] (raw file):
Previously, jpevarnek (Jonathan Pevarnek) wrote…
> Just double-checking: are both font-sizes necessary?

Turns out they weren't both necessary! Like I said above, I copied this code from code for a dropdown that was working, so I didn't remove anything from that.

src/generic_ui/polymer/feedback.html, line 95 [r1] (raw file):
Previously, jpevarnek (Jonathan Pevarnek) wrote…
> I'm having trouble figuring out what element this is being applied to, can you clarify that?

Done. (I put in a comment, but this makes the default selected item for the dropdown, before the user selects something, grey and a little transparent)

src/generic_ui/polymer/feedback.html, line 100 [r1] (raw file):
Previously, jpevarnek (Jonathan Pevarnek) wrote…
> Remove blank line please

Done.

src/generic_ui/polymer/feedback.html, line 118 [r1] (raw file):
Previously, jpevarnek (Jonathan Pevarnek) wrote…
> For anything affecting a specific element, it's easier to just use `#XXX` instead of `[id=XXX]`

Done.

src/generic_ui/polymer/feedback.html, line 212 [r1] (raw file):
Previously, jpevarnek (Jonathan Pevarnek) wrote…
> Can you switch to using double-quotes for HTML attributes?  Thanks.

Done.

src/generic_ui/polymer/feedback.html, line 213 [r1] (raw file):
Previously, jpevarnek (Jonathan Pevarnek) wrote…
> `errorLink` does not really give me much information about this element just reading it, any chance of making the id more descriptive?

Done.

src/generic_ui/polymer/feedback.html, line 214 [r1] (raw file):
Previously, jpevarnek (Jonathan Pevarnek) wrote…
> I think you are missing a level of indentation here

Done.

src/generic_ui/polymer/feedback.html, line 214 [r1] (raw file):
Previously, jpevarnek (Jonathan Pevarnek) wrote…
> What is the `error` attribute for?

Whoops, forgot to get rid of that

src/generic_ui/polymer/feedback.html, line 216 [r1] (raw file):
Previously, jpevarnek (Jonathan Pevarnek) wrote…
> What is the `selected=null` for?

It makes sure that the default selected item in the dropdown isn't any of the options

src/generic_ui/polymer/feedback.html, line 216 [r1] (raw file):
Previously, jpevarnek (Jonathan Pevarnek) wrote…
> It seems to me that it might be easier to bind `selected` to a variable instead of using the `core-select` event, any reason why we're using the event?

I modeled this after the code that had the dropdown for selecting a language on the splash page. My understanding is that without the core-select, the dropdown changes but the changes aren't recorded and the error isn't ultimately passed as part of the feedback variable/payload. At least that's what Lucy sort of said.. basically it wasn't working before I put the core-select in there, so I'm not sure if it can/should be changed.

src/generic_ui/polymer/feedback.html, line 217 [r1] (raw file):
Previously, jpevarnek (Jonathan Pevarnek) wrote…
> For style consistency, there should not be spaces around the `=` signs here.

Done.

src/generic_ui/polymer/feedback.html, line 217 [r1] (raw file):
Previously, jpevarnek (Jonathan Pevarnek) wrote…
> In general, try to avoid creating your own html attributes.  The normal way to handle this is to use [data attributes](https://developer.mozilla.org/en-US/docs/Web/Guide/HTML/Using_data_attributes).

It didn't work when I changed it! The error stopped being passed as part of feedback, so I kept it the same.

src/generic_ui/polymer/feedback.html, line 217 [r1] (raw file):
Previously, jpevarnek (Jonathan Pevarnek) wrote…
> Please add these strings as messages

Done.

src/generic_ui/polymer/feedback.ts, line 87 [r1] (raw file):
Previously, jpevarnek (Jonathan Pevarnek) wrote…
> Blank line

Done.

Comments from Reviewable

Great to see this getting some love. I didn't peek at the code but two observations:

That's a lot of writing on the "submit feedback" screen. I'm no UX-er but that's usually a smell and there's a bunch of clauses, e.g. "optional, unless feedback is 'Other'", likely to further frustrate an already-exasperated user. It's worth having a quick chat with @ohnocassio.

You've a bunch of canned responses - cool, I reckon these will be useful, but rather than sending the raw string (which will differ in each language), have you considered extending the feedbackType instead? This will allow us easily aggregate the responses by type. Right now it's only got one possible value but I think your dropdown values are all perfectly reasonable to add.

Reviewed 1 of 4 files at r3.
Review status: 1 of 4 files reviewed at latest revision, 11 unresolved discussions.

src/generic_ui/locales/en/messages.json, line 1463 [r4] (raw file):

  },"NO_CUSTOM_ERROR_PLACEHOLDER": {
    "description": "Error that apears if you do not select any feedback in the dropdown menu .",
    "message": "Please choose feedback most similar to yours"

We are going to want to work with @ohnocassio on the wording for these by the way, just as a heads up.

src/generic_ui/polymer/feedback.html, line 86 [r1] (raw file):
Previously, shilpa10kumar9 wrote…
> I copied code from the splash.html file, which also had a dropdown, because my original code for a dropdown wasn't working. Because of this, I am not really sure if !important is what makes it work, but it didn't seem to break after I removed it!

Yup, probably  just unnecessary copying from somewhere else.  When you do need to copy code, first try to see if you can move it to a common location.  If you absolutely need to copy (in this case, let's actually talk about that), make sure you're considering whatn code is actually needed

src/generic_ui/polymer/feedback.html, line 95 [r1] (raw file):
Previously, shilpa10kumar9 wrote…
> Done. (I put in a comment, but this makes the default selected item for the dropdown, before the user selects something, grey and a little transparent)

TODO(jpevarnek)

src/generic_ui/polymer/feedback.html, line 213 [r1] (raw file):
Previously, shilpa10kumar9 wrote…
> Done.

So `feedbackDropdown` doesn't really seem right for this since the element itself is not a dropdown.  Any chance of making this a bit more applicable?

src/generic_ui/polymer/feedback.html, line 216 [r1] (raw file):
Previously, shilpa10kumar9 wrote…
> It makes sure that the default selected item in the dropdown isn't any of the options

Why is that necessary?

src/generic_ui/polymer/feedback.html, line 216 [r1] (raw file):
Previously, shilpa10kumar9 wrote…
> I modeled this after the code that had the dropdown for selecting a language on the splash page. My understanding is that without the core-select, the dropdown changes but the changes aren't recorded and the error isn't ultimately passed as part of the feedback variable/payload. At least that's what Lucy sort of said.. basically it wasn't working before I put the core-select in there, so I'm not sure if it can/should be changed.

Yup, that's totally correct.  What I'm saying is that it will probably be much easier and save you a bunch of code if, instead of attaching a function to the event, you just look for changes in the value itself.  Since all you're doing in the handler is setting the value, there should be no need to actually have a function run.

src/generic_ui/polymer/feedback.html, line 217 [r1] (raw file):
Previously, shilpa10kumar9 wrote…
> It didn't work when I changed it! The error stopped being passed as part of feedback, so I kept it the same.

(ignoring this after in-person discussion)

src/generic_ui/polymer/feedback.ts, line 28 [r1] (raw file):

      this.$.logCheckbox.checked = true;
    }
    this.feedbackType = (data && data.feedbackType) ? data.feedbackType :

We should probably still keep this so we default to the feedback type being PROXYING_FAILURE when that's the reason.

src/generic_ui/polymer/feedback.ts, line 82 [r4] (raw file):

  updateError: function(event: Event, detail: any, sender: HTMLElement) {
    if (detail.isSelected) {
      this.feedbackType = detail.item.getAttribute('data-errorCode');

errorCode does not seem to apply as much now that it's a feedback type instead of an error code.

Comments from Reviewable

Review status: 1 of 4 files reviewed at latest revision, 10 unresolved discussions.

src/generic_ui/polymer/feedback.html, line 95 [r1] (raw file):
Previously, jpevarnek (Jonathan Pevarnek) wrote…
> TODO(jpevarnek)

Ah, sorry, meant to come back to this before hitting publish.
I'm not seeing anywhere where we have an element with the id label or with the class selectedItem, can you clarify this a bit?

Comments from Reviewable

Review status: 1 of 4 files reviewed at latest revision, 10 unresolved discussions.

src/generic_ui/polymer/feedback.html, line 86 [r1] (raw file):
Previously, jpevarnek (Jonathan Pevarnek) wrote…
> Yup, probably  just unnecessary copying from somewhere else.  When you do need to copy code, first try to see if you can move it to a common location.  If you absolutely need to copy (in this case, let's actually talk about that), make sure you're considering whatn code is actually needed

Sounds good, I'll keep that in mind next time!

src/generic_ui/polymer/feedback.html, line 95 [r1] (raw file):
Previously, jpevarnek (Jonathan Pevarnek) wrote…
> Ah, sorry, meant to come back to this before hitting publish.
>
> I'm not seeing anywhere where we have an element with the id `label` or with the class `selectedItem`, can you clarify this a bit?

So turns out I was completely wrong and this isn't the code that makes the dropdown grey. Got rid of it! I don't think it did anything haha.

src/generic_ui/polymer/feedback.html, line 213 [r1] (raw file):
Previously, jpevarnek (Jonathan Pevarnek) wrote…
> So `feedbackDropdown` doesn't really seem right for this since the element itself is not a dropdown.  Any chance of making this a bit more applicable?

Done.

src/generic_ui/polymer/feedback.html, line 216 [r1] (raw file):
Previously, jpevarnek (Jonathan Pevarnek) wrote…
> Why is that necessary?

This is necessary cause when the user clicks "submit feedback", one of the checks is whether the selected item in the dropdown is null (in which case it'll throw an error, because I made the dropdown compulsory).. if I remove this, the user is able to submit feedback without choosing something from the dropdown

src/generic_ui/polymer/feedback.html, line 216 [r1] (raw file):
Previously, jpevarnek (Jonathan Pevarnek) wrote…
> Yup, that's totally correct.  What I'm saying is that it will probably be much easier and save you a bunch of code if, instead of attaching a function to the event, you just look for changes in the value itself.  Since all you're doing in the handler is setting the value, there should be no need to actually have a function run.

I'm still not entirely sure what you mean, could you help me when you have time? Or is this fix not essential?

src/generic_ui/polymer/feedback.html, line 217 [r1] (raw file):
Previously, jpevarnek (Jonathan Pevarnek) wrote…
> (ignoring this after in-person discussion)

Done.

src/generic_ui/polymer/feedback.ts, line 82 [r4] (raw file):
Previously, jpevarnek (Jonathan Pevarnek) wrote…
> `errorCode` does not seem to apply as much now that it's a feedback type instead of an error code.

Done.

Comments from Reviewable

Reviewed 1 of 4 files at r3, 1 of 2 files at r6, 1 of 3 files at r7.
Review status: 2 of 4 files reviewed at latest revision, 9 unresolved discussions.

src/generic_ui/polymer/feedback.html, line 205 [r5] (raw file):

{{"CUSTOM_ERROR_TITLE" | $$ }}

            <paper-dropdown-menu label='{{ "CUSTOM_ERROR_PLACEHOLDER" | $$ }}'>

Can you swap the ' and " here?  Thanks.

src/generic_ui/polymer/feedback.html, line 216 [r7] (raw file):

          <paper-input-decorator id="errorDecorator" label = '{{ "CUSTOM_ERROR_PLACEHOLDER" | $$ }}' error='{{ "NO_CUSTOM_ERROR_PLACEHOLDER" | $$ }}'></paper-input-decorator>

What is the error here for?

src/generic_ui/polymer/feedback.ts, line 60 [r7] (raw file):

      this.$.errorDecorator.isInvalid = false;
      this.$.feedbackDecorator.isInvalid = false;
      this.$.dropdownContainer.textContent = ui.i18n_t('CUSTOM_ERROR_PLACEHOLDER');

Hopefully we can get rid of a couple of these lines with other changes, see below.

src/generic_ui/polymer/feedback.ts, line 85 [r7] (raw file):

    });
  },
  updateError: function(event: Event, detail: any, sender: HTMLElement) {

I believe this function is no longer referenced anywhere, can you confirm?

src/generic_ui/polymer/feedback.ts, line 92 [r7] (raw file):

  toggleDropdown: function() {
    this.$.collapse.toggle();
    if (this.$.collapse.opened) {

It's a lot easier to just have two elements on the page and have one be hidden if $.collapsed.opened is true/false.  Otherwise, probably better to have an explicit call to a function that takes $.collapsed.opened as an argument in the Polymer element so someone glancing at the HTML can see that it is changing.

src/generic_ui/polymer/feedback.ts, line 98 [r7] (raw file):

    }
  },
  changePlaceholder: function() {

It would be nice if we could collapse the menu when the user makes a selection

src/generic_ui/polymer/feedback.ts, line 99 [r7] (raw file):

  },
  changePlaceholder: function() {
    this.$.dropdownContainer.textContent=this.$.errorInput.children.array()[this.$.errorInput.selected - 2].textContent; //Because errorInput.selected returns values starting from 2 instead of 0 (not sure why)

In response to your comment: because selected returns the attribute you specified (the enum).
I think what you're looking for here is:
if (detail.isSelected) {
  selectedText = detail.item.textContent;
}

Alternatively, what you could do is just have the text for the placeholder be: {{ someArrayOfText[feedbackType] }}
In fact, you could almost have the whole element be something like (this is not real code)
{{someArrayOfText[feedbackType]}}
<core-menu selected="{{ feedbackType }}" ...>
  <template repeat="{{ type, text in someArrayOfText}}">
    <paper-item data-thing="{{type}}">{{text></paper-item>
  </template>
</core-menu>

I think that might be a good way to simplify things, and it might even be useful to try to break this type of selector into its own Polymer element if it's going to be in the UI in multiple places.

Comments from Reviewable

Review status: 2 of 4 files reviewed at latest revision, 9 unresolved discussions.

src/generic_ui/polymer/feedback.html, line 205 [r5] (raw file):
Previously, jpevarnek (Jonathan Pevarnek) wrote…
> Can you swap the `'` and `"` here?  Thanks.

Done.

src/generic_ui/polymer/feedback.html, line 216 [r7] (raw file):
Previously, jpevarnek (Jonathan Pevarnek) wrote…
> What is the `error` here for?

The error is called when the user tries to submit feedback without choosing one of the options. Because the expansion menu/dropdown thing did not have an error attribute, I had to make an invisible paper-input-decorator, which does have an error field

src/generic_ui/polymer/feedback.ts, line 28 [r1] (raw file):
Previously, jpevarnek (Jonathan Pevarnek) wrote…
> We should probably still keep this so we default to the feedback type being `PROXYING_FAILURE` when that's the reason.

Done.

src/generic_ui/polymer/feedback.ts, line 85 [r7] (raw file):
Previously, jpevarnek (Jonathan Pevarnek) wrote…
> I believe this function is no longer referenced anywhere, can you confirm?

Yup, forgot to get rid of it

src/generic_ui/polymer/feedback.ts, line 92 [r7] (raw file):
Previously, jpevarnek (Jonathan Pevarnek) wrote…
> It's a lot easier to just have two elements on the page and have one be hidden if `$.collapsed.opened` is true/false.  Otherwise, probably better to have an explicit call to a function that takes `$.collapsed.opened` as an argument in the Polymer element so someone glancing at the HTML can see that it is changing.

I'm not entirely sure what you mean by this, so I somewhat fixed it, but I'd love to talk to you about it more

src/generic_ui/polymer/feedback.ts, line 98 [r7] (raw file):
Previously, jpevarnek (Jonathan Pevarnek) wrote…
> It would be nice if we could collapse the menu when the user makes a selection

Done.

src/generic_ui/polymer/feedback.ts, line 99 [r7] (raw file):
Previously, jpevarnek (Jonathan Pevarnek) wrote…
> In response to your comment: because selected returns the attribute you specified (the enum).
>
> I think what you're looking for here is:
> ```
> if (detail.isSelected) {
>   selectedText = detail.item.textContent;
> }
> ```
>
> Alternatively, what you could do is just have the text for the placeholder be: `{{ someArrayOfText[feedbackType] }}`
>
> In fact, you could almost have the whole element be something like (this is not real code)
>
> ```
> {{someArrayOfText[feedbackType]}}
>
>
>
> ```
>
> I think that might be a good way to simplify things, and it might even be useful to try to break this type of selector into its own Polymer element if it's going to be in the UI in multiple places.

Done. (did it like your first suggestion)

Comments from Reviewable

Reviewed 2 of 2 files at r8.
Review status: all files reviewed at latest revision, 8 unresolved discussions.

src/generic_ui/polymer/feedback.html, line 212 [r1] (raw file):
Previously, shilpa10kumar9 wrote…
> Done.

I'm still seeing a lot of inconsistencies, did you push?

src/generic_ui/polymer/feedback.html, line 216 [r7] (raw file):
Previously, shilpa10kumar9 wrote…
> The error is called when the user tries to submit feedback without choosing one of the options. Because the expansion menu/dropdown thing did not have an error attribute, I had to make an invisible paper-input-decorator, which does have an error field

By the way, you have a bunch of unnecessary spaces around the equal signs.  For HTML tags, you should use `foo="bar"`

src/generic_ui/polymer/feedback.ts, line 28 [r1] (raw file):
Previously, shilpa10kumar9 wrote…
> Done.

I'm not seeing this change, did you push it?

src/generic_ui/polymer/feedback.ts, line 92 [r7] (raw file):
Previously, shilpa10kumar9 wrote…
> I'm not entirely sure what you mean by this, so I somewhat fixed it, but I'd love to talk to you about it more

Let's talk about this more in person :)

src/generic_ui/polymer/feedback.ts, line 91 [r8] (raw file):

  changePlaceholder: function(event: Event, detail: any, sender: HTMLElement) {
    if (detail.isSelected) {
      this.$.dropdownContainer.textContent= detail.item.textContent;

Space before the equal sign here

Comments from Reviewable

Review status: 2 of 4 files reviewed at latest revision, 8 unresolved discussions, some commit checks failed.

src/generic_ui/polymer/feedback.html, line 212 [r1] (raw file):
Previously, jpevarnek (Jonathan Pevarnek) wrote…
> I'm still seeing a lot of inconsistencies, did you push?

Idk why it didn't update! Done.

src/generic_ui/polymer/feedback.html, line 216 [r7] (raw file):
Previously, jpevarnek (Jonathan Pevarnek) wrote…
> By the way, you have a bunch of unnecessary spaces around the equal signs.  For HTML tags, you should use `foo="bar"`

Done.

src/generic_ui/polymer/feedback.ts, line 28 [r1] (raw file):
Previously, jpevarnek (Jonathan Pevarnek) wrote…
> I'm not seeing this change, did you push it?

when I put back the lines you wanted, the default feedback type was the first one, instead of the placeholder that used to appear. I am pretty sure the placeholder is a better option; plus, if the user selects something and clicks the back arrow, and then clicks on submit feedback again, the selection is still there. Is that what you were talking about? If not, is there a different way to fix the issue you pointed out?

src/generic_ui/polymer/feedback.ts, line 60 [r7] (raw file):
Previously, jpevarnek (Jonathan Pevarnek) wrote…
> Hopefully we can get rid of a couple of these lines with other changes, see below.

Done.

src/generic_ui/polymer/feedback.ts, line 92 [r7] (raw file):
Previously, jpevarnek (Jonathan Pevarnek) wrote…
> Let's talk about this more in person :)

Done.

src/generic_ui/polymer/feedback.ts, line 91 [r8] (raw file):
Previously, jpevarnek (Jonathan Pevarnek) wrote…
> Space before the equal sign here

Done.

Comments from Reviewable

Couple tiny issues, I'll glance over everything again once those get resolved.  Thanks for working through all of this!

Reviewed 4 of 4 files at r9.
Review status: all files reviewed at latest revision, 3 unresolved discussions.

src/generic_ui/locales/en/messages.json, line 1311 [r9] (raw file):

  },
  "NO_CUSTOM_ERROR_PLACEHOLDER": {
    "description": "Error that apears if you do not select any feedback in the dropdown menu .",

I think you have an accidental space here

src/generic_ui/polymer/feedback.ts, line 28 [r1] (raw file):
Previously, shilpa10kumar9 wrote…
> when I put back the lines you wanted, the default feedback type was the first one, instead of the placeholder that used to appear. I am pretty sure the placeholder is a better option; plus, if the user selects something and clicks the back arrow, and then clicks on submit feedback again, the selection is still there. Is that what you were talking about? If not, is there a different way to fix the issue you pointed out?

Feel free to have it default to `null` if there is nothing, but if `data.feedbackType` is set, let's make sure we select it for them.

Comments from Reviewable

Review status: 2 of 4 files reviewed at latest revision, 2 unresolved discussions.

src/generic_ui/locales/en/messages.json, line 1311 [r9] (raw file):
Previously, jpevarnek (Jonathan Pevarnek) wrote…
> I think you have an accidental space here

Done.

src/generic_ui/polymer/feedback.ts, line 28 [r1] (raw file):
Previously, jpevarnek (Jonathan Pevarnek) wrote…
> Feel free to have it default to `null` if there is nothing, but if `data.feedbackType` is set, let's make sure we select it for them.

Done.

Comments from Reviewable

Reviewed 2 of 2 files at r10.
Review status: all files reviewed at latest revision, 1 unresolved discussion.

src/generic_ui/polymer/feedback.ts, line 28 [r1] (raw file):
Previously, shilpa10kumar9 wrote…
> Done.

I think you'd be better off here conditionally setting it to `data.feedbackType` instead of having the ternary statement.  No reason to set the value to what it already is.
e.g.:
if (data && data.feedbackType) {
  this.feedbackType = data.feedbackType;
}

Comments from Reviewable

Review status: 3 of 4 files reviewed at latest revision, 1 unresolved discussion.

src/generic_ui/polymer/feedback.ts, line 28 [r1] (raw file):
Previously, jpevarnek (Jonathan Pevarnek) wrote…
> I think you'd be better off here conditionally setting it to `data.feedbackType` instead of having the ternary statement.  No reason to set the value to what it already is.
>
> e.g.:
> ```
> if (data && data.feedbackType) {
>   this.feedbackType = data.feedbackType;
> }
> ```

Done.

Comments from Reviewable

:thumbsup:

Reviewed 1 of 1 files at r11.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

Ah, sorry, noticed a couple more things.  :thumbsup: after addressed.

Review status: all files reviewed at latest revision, 4 unresolved discussions, all commit checks successful.

src/generic_ui/polymer/feedback.html, line 121 [r11] (raw file):

    #errorDecorator /deep/ .unfocused-underline,
    #errorDecorator /deep/ .focused-underline {
      /* Remove the underline from the errorDecorator textbox, which is there to throw the error for not selecting

For multi-line comments, have the opening and closing tags on their own lines

src/generic_ui/polymer/feedback.html, line 167 [r11] (raw file):

      height: 15px;
      width: 15px;
    }

Trailing whitespace

src/generic_ui/polymer/feedback.html, line 210 [r11] (raw file):

                <paper-item data-feedbackOption="{{ UserFeedbackType.TROUBLE_STARTING_CONNECTION }}"> {{ "TROUBLE_STARTING_CONNECTION" | $$ }}</paper-item>
                <paper-item data-feedbackOption="{{ UserFeedbackType.DISCONNECTED_FROM_FRIEND }}"> {{ "DISCONNECTED_FROM_FRIEND" | $$ }}</paper-item>
                 <paper-item data-feedbackOption="{{ UserFeedbackType.OTHER_FEEDBACK }}"> {{ "OTHER_FEEDBACK" | $$ }} </paper-item>

No space between the tags and curly braces

src/interfaces/uproxy_core_api.ts, line 22 [r11] (raw file):

export enum UserFeedbackType {
  USER_INITIATED = 0,
  PROXYING_FAILURE = 1,

Do we have an error message that corresponds to PROXYING_FAILURE?

Comments from Reviewable

Review status: 3 of 4 files reviewed at latest revision, 4 unresolved discussions.

src/generic_ui/polymer/feedback.html, line 121 [r11] (raw file):
Previously, jpevarnek (Jonathan Pevarnek) wrote…
> For multi-line comments, have the opening and closing tags on their own lines

Done.

src/generic_ui/polymer/feedback.html, line 167 [r11] (raw file):
Previously, jpevarnek (Jonathan Pevarnek) wrote…
> Trailing whitespace

Done.

src/generic_ui/polymer/feedback.html, line 210 [r11] (raw file):
Previously, jpevarnek (Jonathan Pevarnek) wrote…
> No space between the tags and curly braces

Done.

src/interfaces/uproxy_core_api.ts, line 22 [r11] (raw file):
Previously, jpevarnek (Jonathan Pevarnek) wrote…
> Do we have an error message that corresponds to `PROXYING_FAILURE`?

I don't think so, Proxying_failure was part of user feedback type before I messed with it (I think feedback automatically gets sent with this feedback type if something in particular happens). I chose not to change anything related to this because I was afraid of messing something else up

Comments from Reviewable

authors: jpevarnek shilpa10kumar9 trevj

repo: uProxy/uproxy


text:
Where is download link?

Hello where is the download link? there is no download link to any information!!

Look at the configuration of the function "def UP104D7060F113(path)" which is responsible for uploading files.

source: gharchive/issue

authors: AncientPunishers uanc

repo: uanc/NiceRAT

license: MIT

license_type: permissive

license_source: github-api


text:
你好，为什么用uni-app 创建了一个App 项目，然后使用了 sentry-uniapp ，然后手机上运行会报错

代码如下：

`import * as Sentry from "sentry-uniapp"
Sentry.init({
  dsn: "后台获取的dsn地址"
})`

本地引用是可以的，就是npm 包是不行的

本地引用是可以的，就是npm 包是不行的

1、检查下你npm install 的位置，打包后，可以去 unpackage/dist 下面搜索下 sentry-uniapp，如果没搜到就是打包进去。
2、之前有朋友反馈的，就是装了 sentry h5 等其他的版本，需要都移除掉 sentry 相关的包，只保留  sentry-uniapp 这一个就可以。

请问npm install 的位置应该是哪里呢，我这边就是在项目的根目录下去安装的

请问npm install 的位置应该是哪里呢，我这边就是在项目的根目录下去安装的

是的，正常是项目根目录。不过hbx创建项目，和uniapp-cli的目录结构不同。要看下是哪种创建方式。另外也可以通过安装其他npm包对比下是不是安装的姿势不对
如果没有和 sentry-uniapp 相关问题，本ISSUE将关闭。

repo: uappkit/sentry-uniapp


text:
Feature/semester transition backup

I am still taking a look to see that I am not missing anything vital here. It looks like all of the requirements have been gathered in this issue: https://github.com/ubccpsctech/classy/issues/79, but we have not performed this procedure yet, so this pull-request may have to be modified after we perform our first semester transition.

This has been squashed and moved to this pull-request: https://github.com/ubccpsc/classy/pull/308.

source: gharchive/pull-request

repo: ubccpsc/classy


text:
test: use T.TempDir to create temporary test directory

What changed?
This pull request replaces ioutil.TempDir with t.TempDir in tests.

Why?
A testing cleanup.
We can use the T.TempDir function from the testing package to create temporary directory. The directory created by T.TempDir is automatically removed when the test and all its subtests complete.
Reference: https://pkg.go.dev/testing#T.TempDir
func (s *Suite) TestFoo(t *testing.T) {
	// before
	tmpDir, err := ioutil.TempDir("", "")
	s.NoError(err)
	defer os.RemoveAll(tmpDir)

	// now
	tmpDir := t.TempDir()
}

How did you test it?
Tested locally

Potential risks

Release notes

Documentation Changes

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Rebased onto master

Pull Request Test Coverage Report for Build 018461a6-0632-4384-ba46-1109c4c81a7c

0 of 0   changed or added relevant lines in 0 files are covered.
80 unchanged lines in 15 files lost coverage.
Overall coverage increased (+0.02%) to 57.304%

Files with Coverage Reduction
New Missed Lines
%

common/persistence/sql/sqlExecutionStore.go
1
63.86%

common/persistence/executionManager.go
2
78.83%

common/persistence/statsComputer.go
2
94.64%

common/task/fifoTaskScheduler.go
2
85.57%

service/frontend/workflowHandler.go
2
60.09%

service/history/execution/mutable_state_builder.go
2
68.75%

service/history/queue/timer_gate.go
3
95.83%

service/history/task/fetcher.go
3
91.75%

common/persistence/serialization/parser.go
4
63.91%

common/persistence/serialization/thrift_decoder.go
4
57.14%

Totals

Change from base Build 0184617e-3240-4baa-a45f-cbe1d8cfda38:
0.02%

Covered Lines:
85117

Relevant Lines:
148537

💛  - Coveralls

authors: CLAassistant Juneezee coveralls

repo: uber/cadence


text:
Change permission of DescribeCluster to Read

What changed?

Add DescribeCluster permission setting in gowrap template file of frontend server access control decorator.
Run make go-generate to modify admin_generated.go

Why?

To enable users with read level access to use cadence web.  As addressed in this issue.
DescribeCluster is a read operation semantically.

How did you test it?
Add unit test.

Potential risks

Release notes

Documentation Changes

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.jiaxuyang.i__dcar seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

missing a make fmt apparently:
--- a/service/frontend/wrappers/accesscontrolled/access_controlled_test.go
+++ b/service/frontend/wrappers/accesscontrolled/access_controlled_test.go
@@ -25,8 +25,6 @@ package accesscontrolled
 import (
 	"context"
 	"errors"
-	"github.com/uber/cadence/common/types"
-	"github.com/uber/cadence/service/frontend/admin"
 	"testing"
 	"github.com/golang/mock/gomock"
@@ -35,6 +33,8 @@ import (
 	"github.com/uber/cadence/common/authorization"
 	"github.com/uber/cadence/common/metrics"
 	"github.com/uber/cadence/common/metrics/mocks"
+	"github.com/uber/cadence/common/types"
+	"github.com/uber/cadence/service/frontend/admin"
 )
 func TestIsAuthorized(t *testing.T) {

or for a (much slower) more complete process, try make pr.  that should definitely match what CI produces.

@Groxx @taylanisikdemir Modifications have been committed, please review it again.

Pull Request Test Coverage Report for Build 018feb7f-b68d-44ce-952b-543c65230059
Details

0 of 0   changed or added relevant lines in 0 files are covered.
32 unchanged lines in 10 files lost coverage.
Overall coverage increased (+0.02%) to 69.68%

Files with Coverage Reduction
New Missed Lines
%

common/task/weighted_round_robin_task_scheduler.go
2
89.05%

common/task/fifo_task_scheduler.go
2
85.57%

service/history/execution/mutable_state_util.go
2
78.52%

service/matching/tasklist/matcher.go
2
88.66%

service/history/task/transfer_standby_task_executor.go
3
87.14%

service/history/task/task.go
3
84.81%

service/history/queue/timer_queue_processor_base.go
3
77.87%

common/types/history.go
4
45.35%

service/history/engine/engineimpl/record_activity_task_started.go
5
68.87%

service/history/execution/cache.go
6
74.61%

Totals

Change from base Build 018fdb42-97b4-456b-8043-44705c1f0950:
0.02%

Covered Lines:
103078

Relevant Lines:
147930

💛  - Coveralls

authors: CLAassistant Groxx coveralls jiaxuyang


text:
HeatmapLyaer: set point size to address ANGLE bug

possible fix for #3554
More details: https://bugs.chromium.org/p/angleproject/issues/detail?id=3941

Background

Change List

Coverage remained the same at 82.612% when pulling 3e7b3bbbfb03851e6109c4a973d45d739726ab07 on HeatmapLayerPointSize into 39524c39aa9d3f23bc7fb7223c77921fb4f29a0e on master.


text:
unhelpful error message when meta.json fails to parse

This isn't a user-friendly error and leads to a lot of confusion:
$ idl fetch ...
ERR: SyntaxError: Unexpected string

Related: why are we seeing so many corrupt meta.json files? Seems to common to be due to bad merges, I'm starting to suspect we're writing incomplete files to disk.

@blampe no idea why. would be impossible to tell without being able to reproduce one of the situations that causes a corrupt meta.json.

authors: blampe malandrew

repo: uber/idl

license: mit

license_source: bigquery


text:
ValueError: Cannot convert an unknown Dimension to a Tensor

When training the model, I get the following output.
/home/mark/.local/lib/python3.7/site-packages/h5py/_hl/dataset.py:313: H5pyDeprecationWarning: dataset.value has been deprecated. Use dataset[()] instead.
  "Use dataset[()] instead.", H5pyDeprecationWarning)
Traceback (most recent call last):
  File "train.py", line 14, in <module>
    train_stats = model.train(data_csv="./dataset.csv")
  File "/home/mark/.local/lib/python3.7/site-packages/ludwig/api.py", line 441, in train
    debug=debug,
  File "/home/mark/.local/lib/python3.7/site-packages/ludwig/train.py", line 301, in full_train
    debug=debug
  File "/home/mark/.local/lib/python3.7/site-packages/ludwig/train.py", line 442, in train
    debug=debug
  File "/home/mark/.local/lib/python3.7/site-packages/ludwig/models/model.py", line 108, in __init__
    **kwargs
  File "/home/mark/.local/lib/python3.7/site-packages/ludwig/models/model.py", line 182, in __build
    is_training=self.is_training
  File "/home/mark/.local/lib/python3.7/site-packages/ludwig/models/outputs.py", line 43, in build_outputs
    **kwargs
  File "/home/mark/.local/lib/python3.7/site-packages/ludwig/models/outputs.py", line 93, in build_single_output
    **kwargs
  File "/home/mark/.local/lib/python3.7/site-packages/ludwig/features/base_feature.py", line 314, in concat_dependencies_and_build_output
    **kwargs
  File "/home/mark/.local/lib/python3.7/site-packages/ludwig/features/text_feature.py", line 266, in build_output
    kwarg=kwargs
  File "/home/mark/.local/lib/python3.7/site-packages/ludwig/features/sequence_feature.py", line 320, in build_sequence_output
    eval_loss
  File "/home/mark/.local/lib/python3.7/site-packages/ludwig/features/sequence_feature.py", line 445, in sequence_measures
    self.name
  File "/home/mark/.local/lib/python3.7/site-packages/ludwig/models/modules/measure_modules.py", line 73, in masked_accuracy
    maxlen=correct_predictions.shape[1], dtype=tf.int32)
  File "/home/mark/.local/lib/python3.7/site-packages/tensorflow/python/ops/array_ops.py", line 3088, in sequence_mask
    maxlen = ops.convert_to_tensor(maxlen)
  File "/home/mark/.local/lib/python3.7/site-packages/tensorflow/python/framework/ops.py", line 1087, in convert_to_tensor
    return convert_to_tensor_v2(value, dtype, preferred_dtype, name)
  File "/home/mark/.local/lib/python3.7/site-packages/tensorflow/python/framework/ops.py", line 1145, in convert_to_tensor_v2
    as_ref=False)
  File "/home/mark/.local/lib/python3.7/site-packages/tensorflow/python/framework/ops.py", line 1224, in internal_convert_to_tensor
    ret = conversion_func(value, dtype=dtype, name=name, as_ref=as_ref)
  File "/home/mark/.local/lib/python3.7/site-packages/tensorflow/python/framework/constant_op.py", line 358, in _dimension_tensor_conversion_function
    raise ValueError("Cannot convert an unknown Dimension to a Tensor: %s" % d)
ValueError: Cannot convert an unknown Dimension to a Tensor: ?

Python Training Script
from ludwig.api import LudwigModel

model_definition = {
    "input_features":[
        {"name":"image_path", "type":"image", "preprocessing":{"height": "128", "width": "128", "resize_method": "interpolate"}}
    ],
    "output_features":[
        {"name":"plate","type":"text"}
    ]
}

model = LudwigModel(model_definition)
train_stats = model.train(data_csv="./dataset.csv")

CSV Format
image_path,plate
./crop_m1/I00000.png,9B52145
./crop_h1/I00000.png,9B52145
./crop_m1/I00001.png,6B94558
./crop_h1/I00001.png,6B94558
./crop_m1/I00002.png,8B90164
./crop_h1/I00002.png,8B90164

I'm using version 0.1.2, the newest release in pip. I also receive the same error when building from master branch.
Looking at previous issues with the same error. And following the corrective action did not resolve this case.

Please use the code in master and let me know if the problem is still there. Plus, your output should be tokenized at the character level, check the documentation for that.

I'm a little confused of how to use it after reading the documentation. I currently have it written the output features like this.
"output_features":[
        {"name":"plate","type":"text", "char_tokenizer":"characters"}
]

And if I am utilizing it properly, I'm still getting the same error.

That's incorrect. It should be:
"output_features":[
        {"name":"plate","type":"text", "level": "char"}
]

Text features at the moment save both word and char tokens, with level you are specifying that you want to generate char by char.
But that's probably not your issue. One possibility could be that you have the hdf5 and json cache files from previous attempt to train a model, make sure you delete them.
If neither of those things work and you are using the code from master, then please provide a fully reproducible, because I tried to reproduce it myself and everything works fine.

Thank you, that resolved the issue.

Great!

repo: uber/ludwig


text:
jupyter

Migrate the Jupyter Bindings

Closed this PR due to mistakenly pushing some data files into it. Made a new PR for clean commit.

repo: uber/manifold


text:
Using phabricator-jenkins-plugin in Jenkinsfile

Hey folks,
Is anyone using this plugin with a Jenkinsfile?
I'd love to use the plugin to apply diffs prior to building, but it seems that 'Build Environment' isn't available for Pipeline projects.
How can I use this plugin from a Jenkinsfile?
I'm not overly familiar with Jenkins so doing this from scratch is a little beyond my current knowledge.
Thanks,
-- Rob.

I haven't used a Jenkinsfile before. We use the Groovy DSL plugin at Uber
(which has support for applying diffs). Are there any docs on getting 3rd
party plugins supported with Jenkinsfile?
On Tue, May 17, 2016 at 9:36 PM, Rob Sharp notifications@github.com wrote:

Hey folks,
Is anyone using this plugin with a Jenkinsfile
https://jenkins.io/doc/pipeline/jenkinsfile/?
I'd love to use the plugin to apply diffs prior to building, but it seems
that 'Build Environment' isn't available for Pipeline projects.
How can I use this plugin from a Jenkinsfile?
I'm not overly familiar with Jenkins so doing this from scratch is a
little beyond my current knowledge.
Thanks,
-- Rob.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
https://github.com/uber/phabricator-jenkins-plugin/issues/156

@sectioneight It looks like the Groovy DSL is used in the Jenkinsfile.
https://github.com/jenkinsci/pipeline-plugin/blob/master/TUTORIAL.md#understanding-pipeline-scripts
Would you be willing to share an example so I can try and integrate it?
In return I'll contribute some docs back if/when I get it working!

Sure, I'm not super familiar with how they look, perhaps @Ignas has a succinct example?

It looks like the API is documented on this Job DSL API Explorer.
I'll experiment with it tonight and let you know how I get on.

The Job DSL is quite different to the Pipeline workflow that the Jenkinsfile offers - my mistake.
I've found some resources on implementing the Pipeline interface:
The current list of Pipeline compatible plugins
The PR for Pipeline support for Hipchat
The PR from Saucelabs updating their plugin for Pipeline
I may have a crack at creating a Pipeline interface for this plugin, but I'm not a Java programmer, for better or worse!

Great, thanks for the info! I don't have a ton of time to do new feature development, but I'll leave this one open until I or somebody else can get to it.

hey everyone!  i'm guessing this hasn't seen much movement over the summer?  i'm not really a java programmer either, but i could potentially find some time to do this if no one else is.  @qnm what route did you end up taking?

@davidquarles I ended up setting up a 'staging' repo for my project in Diffusion - so I no longer have to apply diffs, they're pushed to a named branch instead.
It's a simpler workflow for me.

Closing due to inactivity. Please re-open if there's work you're interested in happening on our side.

authors: davidquarles qnm sectioneight

repo: uber/phabricator-jenkins-plugin


text:
React 18 support

When trying to update to React 18 I get this kind of errors of all react-vis components:
error TS2786: 'FlexibleWidthXYPlot' cannot be used as a JSX component.
  Its type 'typeof FlexibleWidthXYPlot' is not a valid JSX element type.

React-vis with React 17 works with fine with newest ("17.0.80") "@types/react", if you don't get different versions of React by some other dependency.
We needed to add this manual (yarn) resolve:
  "resolutions": {
    "@types/react": "17.0.80"
  }

I'm not even able to install react-vis in a fresh React 18 project.

Are you encountering an error indicating a peer dependency version conflict? The package react-vis requires a React version from 15.0.0 to 16.x, which is incompatible with the React version 18.0.0 installed in your project.

To work around this, try running the command npm install react-vis@1.11.12 --legacy-peer-deps. The --legacy-peer-deps flag allows you to bypass peer dependency conflicts.

I suggest using react-vis@1.11.12 since the latest version has some issues with component rendering (#1482). I'll investigate this further. Meanwhile, this should help!

I have the same issue with RadialChart 'RadialChart' cannot be used as a JSX component. even with version 1.11.12 installed with yarn. Then sad but practically I have to find another alternative that at least works

First step would be merging this PR:
https://github.com/uber/react-vis/pull/1473

authors: collink dancespiele jkytomak thisis-Shitanshu

repo: uber/react-vis


text:
Protobuf changes

Adding some changes to add compatibility with protobuf

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

authors: CLAassistant bukue


text:
feat: ensure firefox (flatpak) has hardware decoding turned on by default

Got this straight from Bazzite, just renamed a few thingies to make it Bluefin-themed :p - Fixes #1730

I'm not sure about all these settings... I don't think they are required to enable hardware accelerated video decoding.
I don't have any of them and hw accel decode works well for me. (I happen to have been testing this topic lately).

authors: bsherman tulilirockz

repo: ublue-os/bluefin


text:
cosmic-silverblue: GNOME Wayland not launching

from cosmic greeter I can not launch GNOME on Wayland. Last time I checked only GNOME on Xorg worked.
I will try from tty with gnome-session --session gnome-wayland

Are these images intended to have more than one desktop environment? I think we would only have Cosmic in the final version.

Are these images intended to have more than one desktop environment? I think we would only have Cosmic in the final version.

I agree. The upstream project is Fedora Cosmic Atomic so this one should be Ublue Cosmic.

From what I understand, those desktops are temporary and will go away from these images, long-term

This would be the only ublue image featuring 2 desktops. I suppose the drop will be when COSMIC is stable, not alpha and not beta anymore.

authors: boredsquirrel dylanmtaylor etrigan63

repo: ublue-os/cosmic


text:
'dashboard-proxy' is not a valid MicroK8s subcommand !

Following the infos at https://microk8s.io/ I tried to do  microk8s dashboard-proxy but I get only this:
'dashboard-proxy' is not a valid MicroK8s subcommand.
Available subcommands are:
	add-node
	cilium
	config
	ctr
	disable
...

inspection-report-20200621_001621.tar.gz

Same here.

dashboard-proxy is a recent addition. It is available on the latest track and will be available in the 1.19 track and forward. Please install MicroK8s with the --channel argument:
sudo snap install microk8s --classic --channel=latest/stable

In this case please update the documentation at https://microk8s.io/ because is there where I find that
 1) Install MicroK8s on Linux
sudo snap install microk8s --classic

@evilnick @joedborg, @j75 is right. With  sudo snap install microk8s --classic you get the 1.18/latest track that does not have the dashboard-proxy command. The  dashboard-proxy command is on the latest stable and will be available with the tracks from 1.19 and on. Should we update the docs to have the old dashboard access command or should we have the snap install to use the "latest/stable" channel?

https://github.com/ubuntu/microk8s/pull/1341

authors: fidesachates j75 joedborg ktsakalozos


text:
Prepare for 1.22 build

Start building 1.22!

OpenEBS and Kubeflow addons are failing. I am merging this so we can proceed with the addon fixes.


text:
add links to explain how to use git and github

This change is

Thanks Daniel, I added some inline notes.

Review status: 0 of 1 files reviewed at latest revision, 3 unresolved discussions.

CONTRIBUTING.md, line 4 [r1] (raw file):
Previously, tsimonq2 (Simon Quigley) wrote…
> on the projects that are added to it.

Done.

CONTRIBUTING.md, line 26 [r1] (raw file):
Previously, tsimonq2 (Simon Quigley) wrote…
> GitHub

Done.

CONTRIBUTING.md, line 28 [r1] (raw file):
Previously, tsimonq2 (Simon Quigley) wrote…
> GitHub

Done.

Comments from Reviewable

Dropping this in favour of https://github.com/ubuntu/snappy-playpen/pull/157

Simon reviewed this, we'll merge it and land #157 in the next days once it's ready. :-)

repo: ubuntu/snappy-playpen


text:
FIRRTL Internal Error

i got FIRRTL  ERROR when i try "make CONFIG=PWMConfig"
java -Xmx8G -Xss8M -cp "/mnt/e/Project/project-template/rocket-chip/target/scala-2.12/classes:/mnt/e/Project/project-template/rocket-chip/chisel3/target/scala-2.12/*":"/mnt/e/Project/project-template/testchipip/target/scala-2.12/classes":/mnt/e/Project/project-template/barstools/tapeout/target/scala-2.12/tapeout-assembly-1.0.jar barstools.tapeout.transforms.GenerateTop -o /mnt/e/Project/project-template/verisim/generated-src/example.TestHarness.PWMConfig.top.v -i /mnt/e/Project/project-template/verisim/generated-src/example.TestHarness.PWMConfig.fir --syn-top ExampleTop --harness-top TestHarness -faf /mnt/e/Project/project-template/verisim/generated-src/example.TestHarness.PWMConfig.anno.json --repl-seq-mem -c:TestHarness:-o:/mnt/e/Project/project-template/verisim/generated-src/example.TestHarness.PWMConfig.mems.conf -td /mnt/e/Project/project-template/verisim/generated-src
Exception in thread "main" firrtl.FIRRTLException: Internal Error! Please file an issue at https://github.com/ucb-bar/firrtl/issues
at firrtl.Utils$.error(Utils.scala:440)
at firrtl.Utils$.throwInternalError(Utils.scala:181)
at firrtl.Driver$.$anonfun$execute$1(Driver.scala:252)
at logger.Logger$.$anonfun$makeScope$2(Logger.scala:138)
at scala.util.DynamicVariable.withValue(DynamicVariable.scala:58)
at logger.Logger$.makeScope(Logger.scala:136)
at firrtl.Driver$.execute(Driver.scala:224)
at barstools.tapeout.transforms.GenerateTopAndHarnessApp.executeTop(Generate.scala:102)
at barstools.tapeout.transforms.GenerateTopAndHarnessApp.executeTop$(Generate.scala:96)
at barstools.tapeout.transforms.GenerateTop$.executeTop(Generate.scala:116)
at barstools.tapeout.transforms.GenerateTop$.delayedEndpoint$barstools$tapeout$transforms$GenerateTop$1(Generate.scala:118)
at barstools.tapeout.transforms.GenerateTop$delayedInit$body.apply(Generate.scala:116)
at scala.Function0.apply$mcV$sp(Function0.scala:34)
at scala.Function0.apply$mcV$sp$(Function0.scala:34)
at scala.runtime.AbstractFunction0.apply$mcV$sp(AbstractFunction0.scala:12)
at scala.App.$anonfun$main$1$adapted(App.scala:76)
at scala.collection.immutable.List.foreach(List.scala:389)
at scala.App.main(App.scala:76)
at scala.App.main$(App.scala:74)
at barstools.tapeout.transforms.GenerateTop$.main(Generate.scala:116)
at barstools.tapeout.transforms.GenerateTop.main(Generate.scala)
Caused by: java.util.NoSuchElementException: key not found: ExampleTop
at scala.collection.MapLike.default(MapLike.scala:232)
at scala.collection.MapLike.default$(MapLike.scala:231)
at scala.collection.AbstractMap.default(Map.scala:59)
at scala.collection.MapLike.apply(MapLike.scala:141)
at scala.collection.MapLike.apply$(MapLike.scala:140)
at scala.collection.AbstractMap.apply(Map.scala:59)
at barstools.tapeout.transforms.RemoveUnusedModules.execute(RemoveUnusedModules.scala:46)
at firrtl.Transform.$anonfun$runTransform$2(Compiler.scala:199)
at firrtl.Utils$.time(Utils.scala:186)
at firrtl.Transform.runTransform(Compiler.scala:199)
at firrtl.Compiler.$anonfun$compile$2(Compiler.scala:443)
at scala.collection.LinearSeqOptimized.foldLeft(LinearSeqOptimized.scala:122)
at scala.collection.LinearSeqOptimized.foldLeft$(LinearSeqOptimized.scala:118)
at scala.collection.immutable.List.foldLeft(List.scala:86)
at firrtl.Compiler.$anonfun$compile$1(Compiler.scala:443)
at firrtl.Utils$.time(Utils.scala:186)
at firrtl.Compiler.compile(Compiler.scala:443)
at firrtl.Compiler.compile$(Compiler.scala:439)
at firrtl.VerilogCompiler.compile(LoweringCompilers.scala:162)
at firrtl.Driver$.$anonfun$execute$1(Driver.scala:242)
... 18 more
/mnt/e/Project/project-template/Makefrag:65: recipe for target '/mnt/e/Project/project-template/verisim/generated-src/example.TestHarness.PWMConfig.top.v' failed
make: *** [/mnt/e/Project/project-template/verisim/generated-src/example.TestHarness.PWMConfig.top.v] Error 1

but I can use run "make CONFIG=RoccExampleConfig debug", get simulator-RoccExampleConfig.

You need to set the TOP to the top-level module/dut's class name.
https://github.com/ucb-bar/project-template/blob/master/verisim/Makefile#L9

Thanks a lot, I will try it. ヽ(✿ﾟ▽ﾟ)ノ

repo: ucb-bar/project-template


text:
Private YouTube video

This issue is user submitted and needs to be validated:
15.4.1. TCP
Video link goes to https://www.youtube.com/watch?v=WwyJGzZmBe8 which is private and requires a signin

Duplicate of #408

repo: uccser/cs-field-guide


text:
Styling the Forum Vote Buttons

Purpose
Fix the rather clunky looking visuals of the forum like and dislike buttons. The intended result is to have buttons that fit the theme of the machina forum.

Closing comment
We added styles to the barebones like buttons, and ensured they behaved properly when toggling and switching between button clicks.
Detailed notes
We faced some issues with the voting icons not appearing for Firefox, but that was solved by using FA5 class names for those icons, i.e. fas instead of fa-solid. (credits: @majorsylvie)
We made sure the user's vote was clear by choosing to fill an icon instead of solely changing the icon's color. This helped with accessibility. (credits: @giomhern )
We added a bit of extra space around the vote counter so the button placement would shift so much with every vote. (credits: @majorsylvie)
Thank you to @joshuamonroe and @majorsylvie for reviewing, and @giomhern for spear-heading this!

Issue Score: Excellent

authors: bburgess19 giomhern majorsylvie

repo: uchicago-cs/chigame


text:
Use @Contract instead of @NullUnmarked

Is your feature request related to a problem? Please describe.
Sometimes it is quiet easy to figure out when @Contract("null -> null") should be added at the method declaration itself.  Currently, autoannotator adds @Nullunmarked on the invocations.
Describe the solution you'd like
Add @Contract
cc: @lazaroclapp

Hi @ketkarameya Thank you for reporting the requested feature. I will work on it and get back to you.

Thanks for the report @ketkarameya!  We discussed this today and let me summarize the findings.  We'd like to only infer @Contract in cases where we can give a guarantee that the inferred annotation is valid.  Right now, @Contract verification is not enabled at Uber, and we also discovered the verification is not powerful enough to validate some common cases.  Basically, we'd need to enhance the NullAway dataflow analysis to reason about dead code.  Consider the following case (adapted from an example by @lazaroclapp):
  @Nullable
  @Contract("_, !null -> !null")
  static Bar bar(final String a, @Nullable final String b) {
    if (b == null) {
      return null;
    }
    return new Bar(a, b);
  }

Currently, NullAway fails to verify this @Contract annotation and reports it may be invalid (when contract checking is enabled).  To verify the contract, the analysis has to reason that when b != null the return null statement is unreachable.  Currently, NullAway does not do any kind of reasoning about (conditional) code reachability.
So, we are tabling support for @Contract inference until we can enhance NullAway's ability to verify @Contract annotations for these kinds of cases.

Thanks for investigating into this :)

authors: ketkarameya msridhar nimakarimipour

repo: ucr-riple/NullAwayAnnotator


text:
Update Circle CI Ruby version to latest possible

Following up on #13:
Please update Ruby to the latest version possible. There was a noted issue with 2.4.0, but hopefully we can either get past that, or at least upgrade to the latest 2.3.x

@mcritchlow I've tested to upgrade to ruby 2.4.0 on billing-ill first and it got failed, which is the same errors as the horton upgrades:
An error occurred while installing json (1.8.3), and Bundler
cannot continue.
Make sure that `gem install json -v '1.8.3'` succeeds before bundling.
➜  billing-ill git:(feature/upgrade_ruby2.4.0) gem install json -v '1.8.3'
Building native extensions.  This could take a while...
ERROR:  Error installing json:
	ERROR: Failed to build gem native extension.

Look at https://github.com/rails/rails/issues/27450, "Component 'json' of Ruby on Rails not working with Ruby 2.4.0". it seems the common issue for Ruby 2.4.0
I will try the workaround approaches to see if it can fix the issues.

@hweng yeah, this is what @VivianChu ran into as well.
Maybe we update to the latest 2.3.x for now and then try again for 2.4 later?

@mcritchlow Someone suggested gem json -v 1.8.5 is support it, and It has been published last month.
Let me try it to see how it is going on.

@mcritchlow Yeah I've tried it on billing-ill, then it comes up different errors one by one which requires to upgrade a bunch of gems but mainly are rails 5 , rspec-rails and rubocop dependency gems.
Now the bundle install in circleci looks fine to me that all gem install errors are gone. It passed DEPENDENCIES, DATABASE step and moved to TEST step:
https://circleci.com/gh/ucsdlib/billing-ill/57?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link
The Rspec is fine. It is failed because the RuboCop offenses that after upgrade the RuboCop gem, it detected new 106 offenses.  I'll look into those new offenses and fix them late.
But for horton project it hasn't installed RuboCop so I think it will be fine.

authors: hweng mcritchlow

repo: ucsdlib/horton


text:
Playground-Demo-Fix: Subscript and Supscript toolbar buttons were mixed up

Dear maintainers,
I noticed following bug in the playground demo and provide a small and straight forward fix to it.
The labels were simply mixed up and the clearing behaviour could not handle changing a subscript to a supscript or vice versa.
With best regards,
Leon Müller

Thank you for the PR! We are maintaining the templates in plate repo: https://github.com/udecode/plate/tree/main/templates
Could you open the PR there?

authors: LeonMueller-OneAndOnly zbeyens

repo: udecode/plate-playground-template


text:
Finalización de implantación de funcionalidad crud componente colocación de horarios con flujo actual de plan trabajo docente y análisis de flujo  de relación docente en colocación de espacios académicos

Se requiere realizar la Finalización de implantación de funcionalidad crud componente colocación de horarios con flujo actual de plan trabajo docente y análisis de flujo  de relación docente en colocación de espacios académicos, la issue debe cumplir con los siguientes requerimientos
Sub Tareas

[ ] Realizar la finalización de funcionalidad CRUD (get, put, uptate y delete) en el componente de colocación de espacios academicos, teniendo en cuenta el flujo definido en el modulo de plan docente trabajo

[ ] Analizar y establecer el flujo actual de almacenamiento de colocación de espacios academicos al plan trabajo docente desde el modulo propio y establecer el flujo mas indicado para el modulo de horario, recordar que no siempre se asgina docentes en el modulo de horarios

Criterios de aceptación

[ ] Finalización de funciones CRUD
[ ] Análisis y establecer el flujo de relación colocación de espacios con plan docente trabajo

Requerimientos
No aplica
Definition of Ready - DoR

[x] Está refinada y estimada en puntos de historia por el equipo.
[x] Incluye la descripción y criterios de aceptación, con el detalle funcional y especificaciones técnicas, de forma entendible por cualquier miembro del equipo.
[x] No tiene bloqueos que impidan su ejecución.
[x] Las dependencias están identificadas y resueltas.
[x] Puede ser probada dentro del Sprint.

Definition of Done - DoD - Desarrollo

[ ] Desarrollo en local.
[ ] Push en Feature.
[ ] Pruebas locales (funcionales).
[ ] PR a Develop.
[ ] Criterios de aceptación cumplidos.
[ ] Documentación de issue realizada.
[ ] Aprobada por SM/Líder técnico.

Finalización de implantación de funcionalidad crud componente colocación de horarios con flujo actual de plan trabajo docente y análisis de flujo de relación docente en colocación de espacios académicos

[!NOTE]
Edicion de espacios en frontend

https://github.com/udistrital/sga_documentacion/assets/69730859/acab5da4-fc5e-434e-83b2-992b132848a0

[!NOTE]
Formulario para la asignación de docente

https://github.com/udistrital/sga_documentacion/assets/69730859/bc8c3795-d82e-4dff-acab-859c47aa7cfe

[!NOTE]

Se creo controlador en horarios mid
Se implemento en el front

https://github.com/user-attachments/assets/62a55c95-cb3d-45fd-a230-e96fd8efa75b

Issue finalizada


text:
List all accounts in the service

As a [role]
I need [function]
So that [benefit]
Details and Assumptions
* [document what you know]

Acceptance Criteria
gherkin
Given [some context]
When [certain action is taken]
Then [the outcome of action is observed]

Add label

repo: ugolabo/devops-capstone-project


text:
ROS_DOMAIN_IDをセット

同一ネットワーク内で衝突するのを回避するため

#7


text:
Not getting unlocked status event

Hi.
Well done for creating this, I realise some features are a bit rough, but I have been able to configure it for our building which has 3 floors with a controller on each floor.
With all of the doors, I am able to unlock them using uhppoted.door.{door}.unlock and the uhppoted.door.{door}.lock status shows unlocked until the next poll. However the uhppoted.door.{door}.unlocked.event appears to never fire for any door and the status is always shown as Unknown. Any ideas?
All of my controllers are V6.62.51215 which I realise is pretty old...
One other thing that would be good to know, is there anyway to import the existing swipe records from a controller?
Good work so far though.
Phil

To update this, after a bit more research, it appears that 'some' doors are working and generating the unlocked events. Of our 9 doors, 3 seem to work. There seems to be no pattern though (different numbers doors on different controllers?)

Oh dear .. I guess this means I'm going to have to remove the bit in the README which says "... probably not suitable for office buildings" :-).
Hmm, v6.62.51215 firmware should be ok - it's the earliest version that is known to work, although it does have some oddities that were fixed in later versions. But I've just checked and the code is in place to handle those.
Oh .. oops! Best guess is that the controllers are probably not configured to send events to the Home Assistant machine and uhppoted-app-home-assistant doesn't configure them automatically either. I need to think about how best to do that - but if you want to configure them manually in the interim, the easiest is probably the CLI set-listener command:
set-listener <controller> <address:port>

e.g. uhppote-cli set-listener 405419896 192.168.1.100:60001

The reason you're seeing occasional events is that there is a background process that retrieves "missing" events from the controller, but the interaction with the Home Assistant poll cycle and event handling makes it more than a bit unintuitive.
re. existing swipe records. It's possible except that I have no idea where to store them Home Assistant (am open to suggestions though). I did experiment a bit but hass timestamps events when it receives them so the built-in event logs make no sense whatever doing it that way.

Perfect, set-listener has sorted it! I assume the controllers only send an unlock event as the doors show as unlocked until the next poll (30 seconds) is this correct?
I was a bit concerned about using 'early Alpha' software but since the Windows software stopped working, I have been managing them manually using the internal web interface on each controller, which is a bit painful, so I thought even if it is only 1/2 working, it must be better than that!
I assume the set-listener setting is persistent on the controllers (or do I need to set it again after a controller reboot?)
I will have a think about the existing swipe records, but I am a bit new to HA so still learning.
Thanks again
Phil

Oh great!! Very glad it was that and not something completely weird, and yes, you're completely correct - the controller only generates an unlocked event, the locked event is a synthetic event that is generated from the poll data.
The controller event listener setting is persistent across power cycles, etc, so it only needs to be set once - although I may add a controller-unconfigured event/entity/somesuch so that at least there is some kind of notification if it isn't set. Still  thinking about how best to do it though...
re. early Alpha. <smile> I shall try not to break anything.
re. I am a bit new to HA so still learning. Likewise - it's been quite a learning curve :-)
I'm going to leave this issue open until I have something in place to set/monitor the controller event listener setting - will post an update here when it's available.

Hi,
The wording of the log message is a bit misleading - it is updating the Home Assistant controller date/time entity with the controller date/time every 30 seconds (or whatever poll interval you choose to configure). The actual controller date/time is only set when you change it via the uhppoted.controller.{controller}.datetime entity. I'll fix the log message to read something like "fetching controller date/time" to avoid confusion.
re. who/what/when. The controller doesn't natively support access queries because it's only a small microcontroller with limited capability. It's also reasonably unlikely that the Home Assistant custom component ever will - hass just doesn't include the UI elements to implement something like that (at least not at the moment anyway).
A tool to query and analyse the event logs is on the TODO list but it's not going to happen anytime soon barring a 3AM stroke of genius - it is surprisingly complicated and difficult to do well! In the interim however, there are a couple of other other options:

use the CLI get-event command to retrieve events from the controllers and store them in a database that you can query on an ad hoc basis. There is a cookbook example of how to do that using a bash script and sqlite3 here.

uhppoted-app-db has a get-events command which does the same thing but with a whole lot less fuss. You just need to schedule the command to run every 30 minutes or so to fetch events to the DB of your choice.

uhppoted-httpd can display a user friendly view of the event log - although going by the version of your controllers you're going to have a lot of events which translates to a lot of scrolling. You're also not going to be able to run httpd and the Home Assistant custom component concurrently (well, you can but it's complicated and not recommended)

Hi,
I'm going to close this out - the latest alpha release includes the ability to configure the destination address for controller events and will set it automatically if it is incorrect.
Thanks for braving the early alpha release :-)

repo: uhppoted/uhppoted-app-home-assistant


text:
Files with TS only assets still get transpiled

Problem: Suppose a TS app has a interfaces directory. After transpilation to JS, those files are too transpiled but left empty. UI5 tooling then bundles them but that's another thing.
The predefined setup does not handle this case out-of-the box. I've searched for babel plugins / settings but the results were not very good.
Babel does have ignore property, but when --copy-files is enabled, then the interfaces are properly not processed but still copied in the dist, which is bad. There's also this issue but the additional flag also does not function perfectly.
To handle the issue therefore an additional build step can be added (e.g filtering or deleting unneeded files).
Before doing this however, I wanted to know whether there's possibility to add this behavior in this plugin. Otherwise additional customization steps for the building of TS UI5 apps need to be taken.
Thanks for any info in advance & BR

Hi @dfenerski ,
why does it need to be a .ts file at all? Can't it just be a .d.ts file? The ui5-tooling-transpile doesn't copy the .d.ts files when the generateDts option is disabled.
In general, if you have files only including type definitions, AFAICS, the recommendation is to use .d.ts files (https://stackoverflow.com/questions/37263357/how-to-declare-and-import-typescript-interfaces-in-a-separate-file). I found a small bug in the ui5-tooling-transpile in case of generateDts the relative names need to be made absolute. But this one I tackle independently.
WDYT?
Cheers, Peter

BTW: for the issue in ui5-tooling-transpile, I created an issue: https://github.com/ui5-community/ui5-ecosystem-showcase/issues/743

Thanks for reaching out @petermuessig,
the described solution does indeed solve the problem, so I think this issue can be closed.
In my case however we also have TS for the backend so implementing this would require changing some naming conventions for all **/interfaces/**/*.ts & **/types/**/*.ts files across the codebase to have .d.ts extension instead of the current .ts one. Filtering those files in the builder section of ui5.yaml files has in the same time worked out fine.
Maybe in the future the .d.ts solution is to be implemented, however I would like to research it some more beforehand (read more about ambient modules).
Thanks & BR,
Dimitar

authors: dfenerski petermuessig


text:
New lines in multi-line literal strings trimmed incorrectly

The library is incorrectly parsing/generating code from multi-line literal strings by condensing multiple new lines in the string into a single one.
Example:
EXPECTED:
import toml
toml.loads("a = '''\nhello\nworld\n\n\nbye'''")
{u'a': u'hello\nworld\n\nbye'}

ACTUAL:
import toml
toml.loads("a = '''\nhello\nworld\n\n\nbye'''")
{u'a': u'hello\nworld\nbye'}

We expect two new lines between world and bye, but we get one. According to the specification (emphasis mine):

Multi-line literal strings are surrounded by three single quotes on each side and allow newlines. Like literal strings, there is no escaping whatsoever. A newline immediately following the opening delimiter will be trimmed. All other content between the delimiters is interpreted as-is without modification.

I'll take a look at the code and propose a fix.

It looks like there's a test that contradicts the specification in @BurntSushi's tests. In particular, this test with this expected result. @avakar doesn't have a test case for this. I've fixed this issue in the Python script and will submit a PR. I believe @BurntSushi's test case is incorrect.

From the spec:

For writing long strings without introducing extraneous whitespace, use a "line ending backslash". When the last non-whitespace character on a line is a \, it will be trimmed along with all whitespace (including newlines) up to the next non-whitespace character or closing delimiter.

Closing as WONTFIX due to compliance with the spec.

@uiri That line of the spec is entirely irrelevant to this issue.

@uiri I totally aggree with @SergioBenitez

I'm sorry. You're right; it is relevant to the associated PR(s) but not to this issue.

authors: SergioBenitez noqqe uiri

repo: uiri/toml


text:
Logo for the documentation site?

I chose a simple logo almost at random just to have something at the top left of the docs site:

But it's boring and not really representative of the library, so if anyone has any ideas for a better logo - let's hear them!

Ah OK cool. Well maybe we don't need to change it then!

boring logo is good.  it won't attract the wrong attention.

repo: uk-fci/nhs-number


text:
Delete ES docs on django delete

Issue number: N/A
Description of change
This:

adds a context manager that collects and deletes the objects from ES when they are deleted from the db
creates a search app that can be used to test generic logic

Checklist

[ ] Have any relevant search models been updated?
[ ] Have any relevant fixtures (fixtures/test_data.yaml) been updated?
[ ] Have any relevant select-/prefetch-related field lists in the views and search apps been updated?
[ ] Has the admin site been updated (for new models, fields etc.)?
[ ] Has the README been updated (if needed)?

Codecov Report

Merging #1011 into develop will increase coverage by 0.02%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           develop    #1011      +/-   ##
===========================================
+ Coverage    96.41%   96.44%   +0.02%
===========================================
  Files          206      207       +1
  Lines         5753     5799      +46
  Branches       544      551       +7
===========================================
+ Hits          5547     5593      +46
  Misses         142      142
  Partials        64       64

Impacted Files
Coverage Δ

...ahub/cleanup/management/commands/delete_orphans.py
100% <100%> (ø)
:arrow_up:

datahub/search/deletion.py
100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2a7e01...45a3061. Read the comment docs.

Something else to consider is that the interaction search app does have a post_delete signal receiver, so we might need to disconnect some existing signal receiver while a Collector is active as well...

Something else to consider is that the interaction search app does have a post_delete signal receiver, so we might need to disconnect some existing signal receiver while a Collector is active as well...

True :/

authors: codecov-io marcofucci reupen

repo: uktrade/data-hub-leeloo


text:
Not able to decrypt using jasypt maven plugin with 3.0.0

My application-local.properties file is located under ./src/main/resources.
Encryptor password is correct. The application starts fine and I can confirm the encrypted password is decrypted into its correct string.
I have not been able to get this utility to work.
mvn jasypt:decrypt -Djasypt.encryptor.password="MXyXswPQkxRanB3VXNMgYY2JJRYngE?aun(bHkVJK6PN4aYjT}/^ueLtex(R78W4" -Dspring.profiles.active=local -Djasypt.encryptor.algorithm=PBEWithMD5AndTripleDES
[INFO] Scanning for projects...
[INFO]
[INFO] ------------------< com.protractinator:protractinator-web-api >-------------------
[INFO] Building Protractinator Web API (Spring Boot) 11.0.27-SNAPSHOT
[INFO] --------------------------------[ jar ]---------------------------------
[INFO]
[INFO] --- jasypt-maven-plugin:3.0.0:decrypt (default-cli) @ protractinator-web-api ---
[INFO] Starting MavenCli v3.6.3 on crash.local with PID 1618 (/usr/local/Cellar/maven/3.6.3/libexec/lib/maven-embedder-3.6.3.jar started by crash in /Users/crash/git/protractinator/protractinator-web-api)
[INFO] The following profiles are active: local
[INFO] Post-processing PropertySource instances
[INFO] Converting PropertySource configurationProperties [org.springframework.boot.context.properties.source.ConfigurationPropertySourcesPropertySource] to AOP Proxy
[INFO] Converting PropertySource systemProperties [org.springframework.core.env.PropertiesPropertySource] to EncryptableMapPropertySourceWrapper
[INFO] Converting PropertySource systemEnvironment [org.springframework.boot.env.SystemEnvironmentPropertySourceEnvironmentPostProcessor$OriginAwareSystemEnvironmentPropertySource] to EncryptableSystemEnvironmentPropertySourceWrapper
[INFO] Converting PropertySource random [org.springframework.boot.env.RandomValuePropertySource] to EncryptablePropertySourceWrapper
[INFO] Property Filter custom Bean not found with name 'encryptablePropertyFilter'. Initializing Default Property Filter
[INFO] Started MavenCli in 0.69 seconds (JVM running for 3.901)
[INFO] Decrypting file src/main/resources/application-local.properties
[INFO] String Encryptor custom Bean not found with name 'jasyptStringEncryptor'. Initializing Default String Encryptor
[INFO] Property Resolver custom Bean not found with name 'encryptablePropertyResolver'. Initializing Default Property Resolver
[INFO] Property Detector custom Bean not found with name 'encryptablePropertyDetector'. Initializing Default Property Detector
[INFO] Encryptor config not found for property jasypt.encryptor.key-obtention-iterations, using default value: 1000
[INFO] Encryptor config not found for property jasypt.encryptor.pool-size, using default value: 1
[INFO] Encryptor config not found for property jasypt.encryptor.provider-name, using default value: null
[INFO] Encryptor config not found for property jasypt.encryptor.provider-class-name, using default value: null
[INFO] Encryptor config not found for property jasypt.encryptor.salt-generator-classname, using default value: org.jasypt.salt.RandomSaltGenerator
[INFO] Encryptor config not found for property jasypt.encryptor.iv-generator-classname, using default value: org.jasypt.iv.RandomIvGenerator
[INFO] Encryptor config not found for property jasypt.encryptor.string-output-type, using default value: base64
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  2.936 s
[INFO] Finished at: 2019-12-09T08:47:08+07:00
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal com.github.ulisesbocchio:jasypt-maven-plugin:3.0.0:decrypt (default-cli) on project protractinator-web-api: Execution default-cli of goal com.github.ulisesbocchio:jasypt-maven-plugin:3.0.0:decrypt failed.: EncryptionOperationNotPossibleException -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/PluginExecutionException

See https://github.com/ulisesbocchio/jasypt-spring-boot/blob/master/README.md#update-11242019-version-300-release-includes, you need
jasypt:
  encryptor:
    algorithm: PBEWithMD5AndDES
    iv-generator-classname: org.jasypt.iv.NoIvGenerator

to use your existing code

are you passing the password to the mvn command?

Hi @ulisesbocchio . Yes, passing the password as shown above.
Hi @lz1asl . Thank you. That did the trick.
This works:
mvn jasypt:decrypt -Djasypt.encryptor.password="MXyXswPQkxRanB3VXNMgYY2JJRYngE?aun(bHkVJK6PN4aYjT}/^ueLtex(R78W4" -Dspring.profiles.active=local -Djasypt.encryptor.algorithm=PBEWithMD5AndTripleDES -Djasypt.encryptor.iv-generator-classname=org.jasypt.iv.NoIvGenerator

authors: bjornharvold lz1asl ulisesbocchio

repo: ulisesbocchio/jasypt-spring-boot


text:
How to tell the Matrix server to create a new profile?

Hi,
As the title says, I read through the documentation and issues here, but unless I'm missing something, I couldn't find how to do so.
Thanks!

Creating accounts through iamb is not currently supported. It is tracked under issue #258.

Gotcha

repo: ulyssa/iamb


text:
ERR! ERESOLVE unable to resolve dependency tree

I just tried to update, so pulled the latest codebase, and ran:
$ sudo -u umami npm install
npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR!
npm ERR! While resolving: umami@1.40.0
npm ERR! Found: react@17.0.2
npm ERR! node_modules/react
npm ERR!   react@"^17.0.0" from the root project
npm ERR!   peer react@"^17.0.2 || ^18.0.0-0" from next@12.3.4
npm ERR!   node_modules/next
npm ERR!     next@"^12.3.1" from the root project
npm ERR!     peer next@"^12.2.5" from next-basics@0.18.0
npm ERR!     node_modules/next-basics
npm ERR!       next-basics@"^0.18.0" from the root project
npm ERR!   1 more (react-dom)
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer react@"^18.2.0" from next-basics@0.18.0
npm ERR! node_modules/next-basics
npm ERR!   next-basics@"^0.18.0" from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR!
npm ERR! See /home/umami/.npm/eresolve-report.txt for a full report.

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/umami/.npm/_logs/2023-02-15T05_28_58_684Z-debug-0.log

If only npm could manage to write lucid error reports in moderately natural language. I cannot decipher this without some upskilling, but clearly something to do with react and next-basics.
Any tips for someone keen to understand/learn and or how a dependency tree can be broken?

Have you tried using yarn instead?

No. No experience with that. How do I do that?

Worked it out. That updated fine, built fin and starts fine. Alas Now when I try to log in:
Feb 16 12:13:30 shelob yarn[259269]: The column `account.account_uuid` does not exist in the current database.
Feb 16 12:13:30 shelob yarn[259269]:     at RequestHandler.handleRequestError (/home/umami/umami/node_modules/@prisma/client/runtime/index.js:3194>
Feb 16 12:13:30 shelob yarn[259269]:     at RequestHandler.handleAndLogRequestError (/home/umami/umami/node_modules/@prisma/client/runtime/index.j>
Feb 16 12:13:30 shelob yarn[259269]:     at RequestHandler.request (/home/umami/umami/node_modules/@prisma/client/runtime/index.js:31908:12)
Feb 16 12:13:30 shelob yarn[259269]:     at async PrismaClient._request (/home/umami/umami/node_modules/@prisma/client/runtime/index.js:32994:16)
Feb 16 12:13:30 shelob yarn[259269]:     at async __WEBPACK_DEFAULT_EXPORT__ (/home/umami/umami/.next/server/pages/api/auth/login.js:107:21)
Feb 16 12:13:30 shelob yarn[259269]:     at async Object.apiResolver (/home/umami/umami/node_modules/next/dist/server/api-utils/node.js:366:9)
Feb 16 12:13:30 shelob yarn[259269]:     at async NextNodeServer.runApi (/home/umami/umami/node_modules/next/dist/server/next-server.js:481:9)
Feb 16 12:13:30 shelob yarn[259269]:     at async Object.fn (/home/umami/umami/node_modules/next/dist/server/next-server.js:735:37)
Feb 16 12:13:30 shelob yarn[259269]:     at async Router.execute (/home/umami/umami/node_modules/next/dist/server/router.js:247:36)
Feb 16 12:13:30 shelob yarn[259269]:     at async NextNodeServer.run (/home/umami/umami/node_modules/next/dist/server/base-server.js:347:29) {
Feb 16 12:13:30 shelob yarn[259269]:   code: 'P2022',
Feb 16 12:13:30 shelob yarn[259269]:   clientVersion: '4.9.0',
Feb 16 12:13:30 shelob yarn[259269]:   meta: { column: 'account.account_uuid' },
Feb 16 12:13:30 shelob yarn[259269]:   batchRequestIdx: undefined
Feb 16 12:13:30 shelob yarn[259269]: }

Oh the joys. I shall drill down I guess.  Silly me should have backed that database up ;-)

Looking into the database with psql, I see everything looks good. All my data seems intact ;-) but:
umami=# \d account
                                         Table "public.account"
   Column   |           Type           | Collation | Nullable |                 Default
------------+--------------------------+-----------+----------+------------------------------------------
 user_id    | integer                  |           | not null | nextval('account_user_id_seq'::regclass)
 username   | character varying(255)   |           | not null |
 password   | character varying(60)    |           | not null |
 is_admin   | boolean                  |           | not null | false
 created_at | timestamp with time zone |           |          | CURRENT_TIMESTAMP
 updated_at | timestamp with time zone |           |          | CURRENT_TIMESTAMP
Indexes:
    "account_pkey" PRIMARY KEY, btree (user_id)
    "account_username_key" UNIQUE CONSTRAINT, btree (username)
Referenced by:
    TABLE "website" CONSTRAINT "website_user_id_fkey" FOREIGN KEY (user_id) REFERENCES account(user_id) ON UPDATE CASCADE ON DELETE RESTRICT

reveals account_uuid is missing. Indeed. It seems in the yard build a migration was missed. Is this indicative of a deeper problem? I could create a single column, and even populate it (only have two accounts on the system). But it is worrying that I saw yarn apply migrations but it seems to have missed one?

And before I fiddles with schema by hand I'd want to know what else may have changed on it.

But guess what:
https://github.com/umami-software/umami/blob/master/sql/schema.postgresql.sql
It's not even in the schema! Dear me.

It looks like this migration:
https://github.com/umami-software/umami/blob/aceb904398b527658676879b11ff22135b7cbaf8/db/postgresql/migrations/04_add_uuid/migration.sql
was not applied!

So now, I need to work out which migrations have been applied and how to check and apply migrations.

Done. Inspected migrations 1 to 3 and confirmed they are all in my schema already, then ran migration 4 with psql and now I can log in again and it looks like I'm updated.

authors: bernd-wechner mikecao

repo: umami-software/umami


text:
Panel keeps on collapsing on touch of the views inside it (button)

Hi,
First of all, thanks for this one. =)
I just wanna ask, I tried running the Demo app included in the project and then added some buttons inside the sliding panel but I can't click on the buttons, but instead the panel keeps on hiding.
Am I missing something here?
Thanks and regards!

Hello,
mPanelLayout.setDragView(this.findViewById(R.id.ivPullUp));
This method is not working for me. I have tried to set my whole view as dragview still it's not working. Please update for same.

repo: umano/AndroidSlidingUpPanel


text:
Bring implementations up-to-date

With the new spec, we have to update all implementations

[ ] #47
[ ] #48
[ ] #49
[ ] #50
[ ] #51
[ ] #52
[ ] #53
[ ] #54
[ ] #58
[ ] #62
[x] #55

Can we at first fix the client so we can actually test, whether the implementations are working?

We have to implement the new functionality in the client anyway. Let me once again refer you to #57

With new additions to the spec, more updates are needed #69

authors: tectrixer umgefahren

repo: umgefahren/server-language-benchmark


text:
u-form-item在小程序无法进行验证

版本
1.8.5
转载链接
xn--bug-x28doa2596aqocv12e.com
重现步骤
新建一个表单，直接设置自定义规则，在h5可以正常校验，在小程序不行，校验结果是false
期望的结果是什么？
你猜
实际的结果是什么？
你猜我为什么提bug

表单页面

真服了这个提bug的页面了，怎么你们公司都不需要本地测试就敢上线嘛
还有那个加群的，一个空白的问题，官方文档都找不到的加群答案

uview不是一个公司

repo: umicro/uView


text:
你的功能建议是否和某个问题相关？
我想在BubbleMenu里面配置自定义的拓展，无法配置
你希望看到什么解决方案？

你考虑过哪些替代方案？
No response
你有其他上下文或截图吗？
No response
其他说明
No response
意向参与贡献

[X] 我有意向参与具体功能的开发实现并将代码贡献回到上游社区

@qtch 已收到您的建议

咱们没提供自定义配置哎 只能禁用和启用气泡菜单

authors: qtch umodoc

repo: umodoc/editor


text:
Composer usage

How is this package meant to be used?
Possibly add some examples?
I tried to use bin/build, but got error.
php vendor/umpirsky/language-list/bin/build
Warning: include(/var/www/vendor/umpirsky/language-list/bin/../vendor/autoload.php): failed to open stream: No such file or directory in /var/www/vendor/umpirsky/language-list/bin/build on line 4

Warning: include(): Failed opening '/var/www/vendor/umpirsky/language-list/bin/../vendor/autoload.php' for inclusion (include_path='.:/usr/local/lib/php') in /var/www/vendor/umpirsky/language-list/bin/build on line 4

Fatal error: Uncaught Error: Class 'Umpirsky\ListGenerator\Importer\Importer' not found in /var/www/vendor/umpirsky/language-list/bin/build:6
Stack trace:
#0 {main}
  thrown in /var/www/vendor/umpirsky/language-list/bin/build on line 6

Just run php composer.phar install.
For more information, see https://getcomposer.org/doc/01-basic-usage.md#installing-dependencies

Sorry, let me explain some more.
I have installed this package with composer composer require umpirsky/language-list. It is installed in vendor.
My question is how the package is meant to be consumed after it has been installed.

Describe your use case please. You can use it in many ways, one of them is $languages = include 'language-list/data/en/language.php'.

authors: jsgv umpirsky

repo: umpirsky/language-list


text:
Revisão Geral da Documentação e Registro de Pendências

Descrição
A documentação do projeto precisa de uma revisão geral para garantir que todas as informações estejam atualizadas e que não existam seções obsoletas ou incorretas. O responsável por esta tarefa deve revisar toda a documentação, identificar o que precisa ser alterado ou removido, e trazer para a equipe uma lista de melhorias recomendadas.
Tarefas

[x] Revisar a documentação atual: Analisar toda a documentação do projeto para identificar informações desatualizadas, incorretas ou que precisem de ajustes.
[x] Anotar pendências: Registrar todas as pendências encontradas durante a revisão, incluindo o que precisa ser alterado, atualizado ou removido.
[x] Identificar conteúdo obsoleto: Listar seções ou tópicos que estão obsoletos e precisam ser removidos ou reformulados.
[x] Sugerir melhorias: Preparar uma lista de melhorias para a documentação, incluindo novas seções que possam ser úteis, ajustes de linguagem, formatação e estrutura.
[x] Compartilhar com a equipe: Apresentar as pendências e sugestões de melhoria para a equipe em uma reunião ou documento compartilhado, para discussão e priorização das ações necessárias.
[x] Atualizar a documentação: Após a aprovação das mudanças pela equipe, realizar as atualizações e ajustes necessários na documentação.

A revisãso da documentação foi concluida e resolvemos os problemas levantados na ultima realise.

authors: Gxaite manuvaladares


text:
feat/59

Desenvolvimento do código para o design do front-end.
issue #59

O código está funcionando corretamente.

authors: BrzGab JuliaGabP


text:
Cut is broken

Can no longer cut (1.4.3). Text disappears but is not in the clipboard (Windows). Perhaps related to plain text paste fix?

@elsylambert can you confirm?

@birchamp Verified, as stated in the issue description Text is removed on CTRL + X but is not on the clipboard , so the Paste does not work. Both in MAC and windows.

@mandolyte

authors: BincyJ birchamp deferredreward elsylambert

repo: unfoldingWord/tc-create-app


text:
🛑 Unforest is down

In 485b8fa, Unforest (https://www.unforest.net) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Unforest is back up in d55ddaf after 11 minutes.

repo: unforest/uptime


text:
🛑 Libreddit is down

In b29ab1e, Libreddit (https://libreddit.unforest.net) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Libreddit is back up in a7781ed after 58 minutes.


text:
🛑 Libreddit is down

In dcbfc8b, Libreddit (https://libreddit.unforest.net) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Libreddit is back up in dd4fc61 after 12 minutes.


text:
🛑 SearXNG is down

In ccf977d, SearXNG (https://searxng.unforest.net) was down:

HTTP code: 0
Response time: 0 ms

Resolved: SearXNG is back up in 8aff4ab after 52 minutes.


text:
🛑 Rimgo is down

In 8c000a2, Rimgo (https://rimgo.unforest.net) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Rimgo is back up in c58c537 after 14 minutes.


text:
🛑 Libreddit is down

In 3656596, Libreddit (https://libreddit.unforest.net) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Libreddit is back up in c330181 after 11 minutes.


text:
Added nominee: Community Health Toolkit

Added nominee: Community Health Toolkit

This is a duplicate of Medic Mobile, which already exists on our dataset, kindly update or replace the existing entry.

Resolved in commit 4e89da2

repo: unicef/publicgoods-candidates

license: Unlicense


text:
Finalize TLD Explorations

Discuss with TLD team during the week of Sept 6
Finalize which explorations/prototypes we need to add to our product roadmap OR elaborate upon

First pass completed. Working on the details which will be included in the 2-pager.

repo: unicef/publicgoods-roadmap


text:
Use PinoJS for logging, refactor tests, increase test coverage

This PR refactors the way we perform tests and resolves #40 and #45
This PR switches to using Jest as our test runner since it provides a easy to use mocking functionality for imported modules which are extremely useful to perform unit tests.

Add Pino JS dependency (pino-http and pino-http-print)
Add Jest, remove Ava
Switch all tests from Ava testing syntax to Jest
Increases the test coverage for authentication, review and application services/controllers
CI now runs all tests on current and LTS versions of Node simultaneously

This PR doesn't affect the admin or mail services. These have huge tech debt and need be refactored.

Codecov Report

Merging #46 into master will increase coverage by 4.60%.
The diff coverage is 90.00%.

@@            Coverage Diff             @@
##           master      #46      +/-   ##
==========================================
+ Coverage   66.79%   71.40%   +4.60%
==========================================
  Files          52       52
  Lines        1045     1119      +74
  Branches      107      122      +15
==========================================
+ Hits          698      799     +101
+ Misses        336      319      -17
+ Partials       11        1      -10

Impacted Files
Coverage Δ

src/util/auth/hs_auth.ts
92.98% <90.00%> (+48.33%)
:arrow_up:

src/util/fs/writer.ts
23.07% <0.00%> (-1.93%)
:arrow_down:

src/util/errorHandling/apiError.ts
37.50% <0.00%> (-1.39%)
:arrow_down:

src/controllers/applicationController.ts
89.74% <0.00%> (-0.93%)
:arrow_down:

src/routes/index.ts
100.00% <0.00%> (ø)

src/models/sections.ts
100.00% <0.00%> (ø)

src/models/settings.ts
100.00% <0.00%> (ø)

src/util/cache/cache.ts
100.00% <0.00%> (ø)

src/util/cache/index.ts
100.00% <0.00%> (ø)

src/routes/adminRouter.ts
100.00% <0.00%> (ø)

... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea3c8fb...abebe51. Read the comment docs.

Don't merge yet, going to try and improve the auth tests :)

authors: codecov-commenter seanjparker