text:
[ISSUE #4602] when wechat send message api response errcode is not zero, the wechat sink connector does not throw IllegalAccessException

Fixes #4602
Motivation
fix  bug when wecaht api response fail
Modifications
rename org.apache.eventmesh.connector.wechat.sink.connector.TemplateMessageResponse#errocode
to org.apache.eventmesh.connector.wechat.sink.connector.TemplateMessageResponse#errcode
add abnormal test case

You can add this Sink Connector to the list in this document. https://github.com/apache/eventmesh/tree/master/eventmesh-connectors#connector-status

already done, please review

Finally, are you willing to write a document for your connector (#4601 (comment)) to facilitate user understanding and use. If you are willing, you can do it in this PR or in a new PR in the future.
最后，请问是否愿意给您的这个Connector写一下文档 （#4601 (comment) ），方便用户理解和使用。如果您愿意，可以在该PR中做，也可以以后在新的PR中做。

i prefer in a new PR to do this

@pandaapo  hello, i found  some commit in this PR used wrong email, so i want to close this PR, an create a new one

repo: apache/eventmesh


text:
[FLINK-35623] Bump mongo-driver version from 4.7.2 to 5.1.1 to support MongoDB 7.0

Bump mongo-driver version from 4.7.2 to 5.1.1 to support MongoDB 7.0
https://www.mongodb.com/docs/drivers/java/sync/current/compatibility/

Hi @GOODBOY008, could you help review this?

Hi @yux, could you help review this?

source: gharchive/pull-request

repo: apache/flink-connector-mongodb

license_type: permissive

license_source: github-api


text:
[FLINK-14924][table sql / api] CsvTableSource can not config empty column as null

CsvTableSource can not config empty column as null.

What is the purpose of the change
This pull request add option of treating empty column as null for CsvTableSource.
Brief change log

update file org.apache.flink.table.sources.CsvTableSource.java

Verifying this change
Add ITCase to to test CsvTableSource:

org.apache.flink.table.runtime.batch.sql.TableSourceITCase.scala
org.apache.flink.table.runtime.utils.CommonTestData.scala

Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
The serializers: (no)
The runtime per-record code paths (performance sensitive): ( no)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
The S3 file system connector: (no)

Documentation

Does this pull request introduce a new feature? (no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

I look up csv descriptor, we have two csv descriptor named CSV and OldCsv.
Only OldCsv will call CsvTableSource and OldCsv is deprecated,  CSV  has an another mechanism RuntimeConverter and supports  null literal property which interpret literal string(i.e. "null" or "N/A") as null value.
So I think we do not need to add this feature now.

@KurtYoung
I update the PR, Could you have a more look ?

repo: apache/flink


text:
[FLINK-17572][runtime] Remove checkpoint alignment buffered metric from webui

What is the purpose of the change
After avoid caching buffers for blocked input channels before barrier alignment, runtime never cache buffers while checkpoint barrier alignment, therefore checkpoint alignment buffered metric would always be 0, which should remove it directly in CheckpointStatistics , CheckpointingStatistics, TaskCheckpointStatistics, TaskCheckpointStatisticsWithSubtaskDetails and SubtaskCheckpointStatistics.
Brief change log

Remove alignmentBuffered attribute in CheckpointStatistics , CheckpointingStatistics, TaskCheckpointStatistics, TaskCheckpointStatisticsWithSubtaskDetails and SubtaskCheckpointStatistics
Remove alignment_buffered in Checkpoint Detail from job-checkpoints.component.html.
Remove alignment_buffered column in document of /jobs/:jobid/checkpoints rest interface.

Verifying this change

Modify test object create by CheckpointStatistics , CheckpointingStatistics, TaskCheckpointStatistics, TaskCheckpointStatisticsWithSubtaskDetails and SubtaskCheckpointStatistics in CheckpointingStatisticsTest, TaskCheckpointStatisticsTest and TaskCheckpointStatisticsWithSubtaskDetailsTest.

Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (yes / no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
The serializers: (yes / no / don't know)
The runtime per-record code paths (performance sensitive): (yes / no / don't know)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / no / don't know)
The S3 file system connector: (yes / no / don't know)

Documentation

Does this pull request introduce a new feature? (yes / no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

This breaks the REST API contracts; see the JIRA for details.

authors: SteNicholas zentol


text:
[FLINK-18063][checkpointing] Fix the race condition for aborting current checkpoint in CheckpointBarrierUnaligner

What is the purpose of the change
There are three aborting scenarios which might encounter race condition:
1. CheckpointBarrierUnaligner#processCancellationBarrier
2. CheckpointBarrierUnaligner#processEndOfPartition
3. AlternatingCheckpointBarrierHandler#processBarrier

They only consider the pending checkpoint triggered by #processBarrier from task thread to abort it. Actually the checkpoint might also be triggered by #notifyBarrierReceived from netty thread in race condition, so we should also handle properly to abort it.
Brief change log

Fix the process of AlternatingCheckpointBarrierHandler#processBarrier
Fix the process of CheckpointBarrierUnaligner#processEndOfPartition to abort checkpoint properly
Fix the process of CheckpointBarrierUnaligner#processCancellationBarrier to abort checkpoint properly

Verifying this change

Added new unit test CheckpointBarrierUnalignerTest#testProcessCancellationBarrierAfterNotifyBarrierReceived
Added new unit test CheckpointBarrierUnalignerTest#testProcessCancellationBarrierAfterProcessBarrier
Added new unit test CheckpointBarrierUnalignerTest#testProcessCancellationBarrierBeforeProcessAndReceiveBarrier

Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (yes / no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
The serializers: (yes / no / don't know)
The runtime per-record code paths (performance sensitive): (yes / no / don't know)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / no / don't know)
The S3 file system connector: (yes / no / don't know)

Documentation

Does this pull request introduce a new feature? (yes / no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

Cherry-pick it to master from #12406 which was reviewed and approved before.
The failure e2e is known StreamingKafkaITCase, so ignore it to merge.


text:
[FLINK-20518][rest] Add decoding characters for MessageQueryParameter

What is the purpose of the change
Add decoding characters for rest service
Brief change log

Add decoding characters for rest service

Verifying this change
no
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
The serializers: (no)
The runtime per-record code paths (performance sensitive): (no)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (no)
The S3 file system connector: (no)

Documentation

Does this pull request introduce a new feature? (no)
If yes, how is the feature documented? (not documented)

@zentol  please take a look, if you have time, thanks

As I said in the ticket, the server side decodes characters just fine. The UI isn't encoding special characters; that's the isssue.

As I said in the ticket, the server side decodes characters just fine. The UI isn't encoding special characters; that's the isssue.
Maybe I didn't understand what you mean correctly?
Do you think that special characters should be encoded on the UI side?
Instead of decoding it on the server again?

Do you think that special characters should be encoded on the UI side? Instead of decoding it on the server again?

yes and yes. I did a manual check when reviewing https://github.com/apache/flink/pull/13514 and confirmed that our REST API handles escaped special characters fine. So this is purely a UI issue.

Do you think that special characters should be encoded on the UI side? Instead of decoding it on the server again?

yes and yes. I did a manual check when reviewing #13514 and confirmed that our REST API handles escaped special characters fine. So this is purely a UI issue.

@zentol
I add some log on UI and REST server, then I found,
UI send 0.GroupWindowAggregate(window=[TumblingGroupWindow(%27w$__rowtime__60000)]__properti.watermarkLatency
but REST server received is 0.GroupWindowAggregate(window=%5BTumblingGroupWindow(%252527w$__rowtime__60000)%5D__properti.watermarkLatency by RouterHandler, this has been encoded 3 times,
QueryStringDecoder decode only once, so this happened.
Do you want anything else to discover?

All I know is that if you send a request, with encoding applied once, things work fine.

All I know is that if you send a request, with encoding applied once, things work fine.

@zentol  I found the root cause! We are using flink on yarn, RM will escape the special characters again!!
So what is your suggestion to solve this problem?

We are using flink on yarn, RM will escape the special characters again!!

YARN making things complicate again... 😢
Earlier you said that the requests are encoded 3 times; The UI does it once (does it?), and the RM does it (I assume) once. Any idea where the third one comes from?

So what is your suggestion to solve this problem?

hmm...it seems a bit arbitrary to stack a fixed number of decode calls; what if yet another middle-layer gets added between the UI and rest API, things could break at any time. Are there any downsides to decoding too often? As in, we loop the decoding until nothing changes anymore (although that also feels just wrong...).

Earlier you said that the requests are encoded 3 times; The UI does it once (does it?), and the RM does it (I assume) once. Any idea where the third one comes from?

I don’t know how many encodes will be done in RM.
The 3 times mentioned before are based on the need to decode 3 times.

hmm...it seems a bit arbitrary to stack a fixed number of decode calls; what if yet another middle-layer gets added between the UI and rest API, things could break at any time. Are there any downsides to decoding too often? As in, we loop the decoding until nothing changes anymore (although that also feels just wrong...).

We are like #13514?
Handle special characters single quotes.

Earlier you said that the requests are encoded 3 times; The UI does it once (does it?), and the RM does it (I assume) once. Any idea where the third one comes from?

I don’t know how many encodes will be done in RM.
The 3 times mentioned before are based on the need to decode 3 times.

hmm...it seems a bit arbitrary to stack a fixed number of decode calls; what if yet another middle-layer gets added between the UI and rest API, things could break at any time. Are there any downsides to decoding too often? As in, we loop the decoding until nothing changes anymore (although that also feels just wrong...).

We are like #13514?
Handle special characters single quotes.

@zentol   What do you think of this?

We are like #13514?
Handle special characters single quotes.

I don't understand what you are asking/suggesting, please elaborate.

We are like #13514?
Handle special characters single quotes.

I don't understand what you are asking/suggesting, please elaborate.

@zentol  We add the handling of single quotes in MetricQueryService#replaceInvalidChars to avoid single quotes;
Decode multiple times, not the best solution.

Decode multiple times, not the best solution.

I agree, but I have outlined in #13514 why replacing more characters is not a good option as well.


text:
[FLINK-25782] [docs] Translate datastream filesystem.md page into Chinese.

What is the purpose of the change
(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them on each deployment (during recovery).)
Brief change log
(for example:)

The TaskInfo is stored in the blob store on job creation time as a persistent artifact
Deployments RPC transmits only the blob storage reference
TaskManagers retrieve the TaskInfo from the blob cache

Verifying this change
Please make sure both new and modified tests in this PR follows the conventions defined in our code quality guide: https://flink.apache.org/contributing/code-style-and-quality-common.html#testing
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)

Added integration tests for end-to-end deployment with large payloads (100MB)
Extended integration test for recovery after master (JobManager) failure
Added test that validates that TaskInfo is transferred only once across recoveries
Manually verified the change by running a 4 node cluser with 2 JobManagers and 4 TaskManagers, a stateful streaming program, and killing one JobManager and two TaskManagers during the execution, verifying that recovery happens correctly.

Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (yes / no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
The serializers: (yes / no / don't know)
The runtime per-record code paths (performance sensitive): (yes / no / don't know)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know)
The S3 file system connector: (yes / no / don't know)

Documentation

Does this pull request introduce a new feature? (yes / no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

Hi, @Thesharing @RocMarshal , May I get your help to review it? Thanks.

@flinkbot  run Azure


text:
[FLINK-28837][chinese-translation] Translate "Hybrid Source" page of …

What is the purpose of the change
Translate "Hybrid Source" page of "DataStream Connectors" into Chinese
Brief change log
Translate "Hybrid Source" page of "DataStream Connectors" into Chinese
Verifying this change
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
The serializers: (no)
The runtime per-record code paths (performance sensitive): (no)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
The S3 file system connector: (no)

Documentation

Does this pull request introduce a new feature? (no)
If yes, how is the feature documented? (not documented)

@flinkbot run azure

@flinkbot run azure

@wuchong please help review when you are free, thanks.


text:
[FLINK-30538][SQL gateway/client] Improve error handling of stop job operation

What is the purpose of the change
Currently, the stop-job operation produces some verbose error msg and doesn't handle exceptions in stop-without-savepoint gracefully.
This PR fixes the problem.
Brief change log

Wrap simple cancel with try-catch.
Wait for simple cancel Acknowledge before returning 'OK'.
Simplify exception message for stop job operations.

Verifying this change
Please make sure both new and modified tests in this PR follows the conventions defined in our code quality guide: https://flink.apache.org/contributing/code-style-and-quality-common.html#testing
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): no
The public API, i.e., is any changed class annotated with @Public(Evolving): no
The serializers: no
The runtime per-record code paths (performance sensitive): no
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
The S3 file system connector: no

Documentation

Does this pull request introduce a new feature?  no
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@flinkbot run azure

@flinkbot run azure

Please kindly take a look @fsk119

CI ran into https://issues.apache.org/jira/browse/FLINK-30328. Re-run CI.

@flinkbot run azure

@fsk119 CI turned green. Please kindly take a look at your convenience.

ping @fsk119 . It should be a quick one :)

ping @fsk119


text:
[FLINK-35166][runtime] Make the SortBufferAccumulator use more buffers when the parallelism is small

What is the purpose of the change
Improve the performance of hybrid shuffle when enable memory decoupling and meantime the parallelism is small.
Brief change log

Make the SortBufferAccumulator use more buffers when the parallelism is small

Verifying this change
Please make sure both new and modified tests in this PR follow the conventions for tests defined in our code quality guide.
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
The serializers: (no)
The runtime per-record code paths (performance sensitive): (no)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
The S3 file system connector: (no)

Documentation

Does this pull request introduce a new feature? (no)
If yes, how is the feature documented? (not applicable)

Is TPC-DS performance no longer regression after the fix?

@reswqa  The regression still exists because we replace the HashBufferAccumulator with the SortBufferAccumulator when the decoupling is enabled and the parallelism is less than 512, but this PR reduces the regression. According to the previous discussion, the regression is acceptable if the feature is enabled.


text:
Upgrade com.squareup.okio:okio

What is the purpose of the change
(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them on each deployment (during recovery).)
Brief change log
(for example:)

The TaskInfo is stored in the blob store on job creation time as a persistent artifact
Deployments RPC transmits only the blob storage reference
TaskManagers retrieve the TaskInfo from the blob cache

Verifying this change
Please make sure both new and modified tests in this PR follow the conventions for tests defined in our code quality guide.
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)

Added integration tests for end-to-end deployment with large payloads (100MB)
Extended integration test for recovery after master (JobManager) failure
Added test that validates that TaskInfo is transferred only once across recoveries
Manually verified the change by running a 4 node cluster with 2 JobManagers and 4 TaskManagers, a stateful streaming program, and killing one JobManager and two TaskManagers during the execution, verifying that recovery happens correctly.

Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (yes / no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
The serializers: (yes / no / don't know)
The runtime per-record code paths (performance sensitive): (yes / no / don't know)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know)
The S3 file system connector: (yes / no / don't know)

Documentation

Does this pull request introduce a new feature? (yes / no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

Reviewed by Chi on 21/11/24. Asked submitter questions
Please could you raise a Jira detailing the reason you want to upgrade this component (e.g. is there a particular bug that this would fix)

authors: davidradl g-s-eire


text:
[FLINK-4631] Avoided NPE in OneInputStreamTask.

Added additional condition to check possible NPE. This PR solve FLINK-4631.

+1 to merge

merging

authors: chermenin zentol


text:
[FLINK-6483] [table] Support time materialization

This PR adds support for time materialization. It also fixes several bugs related to time handling in the Table API & SQL.

Thanks for the update @twalthr!
Looks very good. Will merge this.

authors: fhueske twalthr


text:
[FLINK-6522] Add ZooKeeper cleanup logic to ZooKeeperHaServices

Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration.
If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the How To Contribute guide.
In addition to going through the list, please provide a meaningful description of your changes.

[ ] General

The pull request references the related JIRA issue ("[FLINK-XXX] Jira title text")
The pull request addresses only one issue
Each commit in the PR has a meaningful commit message (including the JIRA id)

[ ] Documentation

Documentation has been added for new functionality
Old documentation affected by the pull request has been updated
JavaDoc for public methods has been added

[ ] Tests & Build

Functionality added by the pull request is covered by tests
mvn clean verify has been executed successfully locally or a Travis build has passed

Hi @tillrohrmann , I have created this PR for issue FLINK-6522. Could you please have a look when you're free, thanks

@tillrohrmann Thank you for your review. I use prefix as the name of sub directory, and add test case to FileSystemStateStorageHelper#closeAndCleanupAllData. Also I have fixed the problem you metioned, thanks

Solved by FLINK-11336.

authors: tillrohrmann zjureel


text:
[FLINK-7797] [table] Add support for windowed outer joins for streaming tables

What is the purpose of the change
This PR adds support for windowed outer joins for streaming tables.
Brief change log

Adjusts the plan translation logic to accept stream window outer join.
Adheres an ever emitted flag to each row. When a row is removed from the cache (or detected as not cached), a null padding join result will be emitted if necessary.
Adds a custom JoinAwareCollector to track whether there's a successfully joined result for both sides in each join loop.
Adds table/SQL translation tests, and also join integration tests. Since the runtime logic is built on the existing window inner join, no new harness tests are added.
Updates the SQL/Table API docs.

Verifying this change
This PR can be verified by the cases added in JoinTest and JoinITCase.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
The serializers: (no)
The runtime per-record code paths (performance sensitive): (yes)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
The S3 file system connector: (no)

Documentation

Does this pull request introduce a new feature? (yes)
If yes, how is the feature documented? (remove the restriction notes)

Thanks for the PR @xccui.
I'll try to have a look at it sometime this week.
Best, Fabian

authors: fhueske xccui


text:
[FLINK-10431] Extraction of scheduling-related code from SlotPool into preliminary Scheduler

What is the purpose of the change
This PR extracts the scheduling related code (e.g. slot sharing logic) from to slot pool into a preliminary version of a future scheduler component. Our primary goal is fixing the scheduling logic for local recovery. Changes in this PR open up potential for more code cleanups (e.g. removing all scheduling concerns from the slot pool, removing ProviderAndOwner, moving away from some CompletableFuture return types, etc). This cleanup and some test rewrites will happen in a followup PR.
Brief change log

SlotPool is no longer a RpcEndpoint, we need to take care that all state modification happens in the component's main thread now.
Introduced SlotInfo and moving the slot sharing code into a scheduler component. Slot pool code can now deal with single slot requests. The pattern of interaction is more explicit, we have 3 main new methods: getAvailableSlotsInformation to list available slots, allocateAvailableSlot to allocated a listed / available slot, requestNewAllocatedSlot to request a new slot from the resoure manager. The old codepaths currently still co-exist in the slot pool and will be removed in followup work.
Introduce creating a collection of all previous allocations through ExecutionGraph::computeAllPriorAllocationIds. This serves as basis to compute a "blacklist" of allocation ids that we use to fix the scheduling of local recovery.
Provide an improved version of the scheduling for local recovery, that uses a blacklist.

Verifying this change
This change is already covered by existing tests, but we still need to rewrite tests for the slot pool and add more additional tests in followup work.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
The serializers: (no)
The runtime per-record code paths (performance sensitive): (no)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes)
The S3 file system connector: (no)

Documentation

Does this pull request introduce a new feature? (no)
If yes, how is the feature documented? (not applicable)

Hi @StefanRRichter , I am just wondering why make SlotPool no longer to be an RpcEndpoint?

@Clarkkkkk background is that it will make things easier and otherwise you have concurrency between two components that want to interact in transactional ways: if the scheduler runs in a different thread than the slot pool there can be concurent modifications to the slot pool (e.g. slots added/removed) between the scheduler asking for the available slots and the scheduler requesting the available slot. All of this has to be resolved and it becomes harder to understand and reason about the code. This can be avoided if scheduler and slot pool run in the same thread, and we are also aiming at having all modifications to the execution graph in the same thread as well. The threading model would then be that blocking or expensive operations run in their own thread so that the main thread is never blocked, but the results are always synced back to a main thread to runs all the modifications in scheduler, slot pool, execution graph, etc.

Closed because there is an updated version of this PR in #7662.

authors: Clarkkkkk StefanRRichter


text:
Remove hostHeader = hostname property from Host interceptor example

We are overriding the host header name from host to hostname in the example usage section. Due to this example users are overriding the header name too but still use the %{host} substitution as shown in the HDFS Sink section. This won't work for them.
This change removes this config line.

+1, LGTM
I'll leave some time for others to review this, then commit it if nobody disagrees.

I'm about to commit this.

@peterableda : thank you for the patch!

authors: bessbd peterableda

repo: apache/flume


text:
GEODE-6927 make getThreadOwnedConnection code thread safe

Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:

[x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

[x] Has your PR been rebased against the latest commit within the target branch (typically develop)?

[x] Is your initial contribution a single, squashed commit?

[x] Does gradlew build run cleanly?

[ ] Have you written or updated unit tests to verify your changes?

[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?

Note:
Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.

Instead of adding synchronizations and null checks everywhere let's just make that field final and change the close() method to clear it.

Even butt but I think there is still a race in what to do with calls to this method concurrently with close. The map would be cleared by close but then updated by this method. Having little background in what this is tracking I can’t say if this is good or bad, it is simply just a case the original code seemed to try to avoid.

I don't think we should be using the state of a collection as an indication of whether the service is open or closed.  There should be other state that we use to avoid creating a new connection and putting it in the connection map if ConnectionTable is closed.

I don't think we should be using the state of a collection as an indication of whether the service is open or closed. There should be other state that we use to avoid creating a new connection and putting it in the connection map if ConnectionTable is closed.

Couldn't agree more! If you think its safe for connection references that race into the map on close to sit there then this is an easy fix. A simple check if the collection is closed after the put completes could accomplish this. The close itself would empty the map and any race on that operation would get cleared up on the back end after the put by checking for closed state and removing the entry just put.

@bschuchardt @pivotal-jbarrett  Are there still concerns with this PR?

@bschuchardt @pivotal-jbarrett Are there still concerns with this PR?

My concern over the threadConnectionMap null checks hasn't been addressed.  I've been fighting against the nulling-out of instance variables like this forever.  It's always causing NPEs for unsuspecting programmers who don't recognize that this anti-pattern is being used.  The instance variable ought to be "final" and some other state should be added and consulted to see if the connection table has been closed.

@bschuchardt @pivotal-jbarrett Are there still concerns with this PR?

My concern over the threadConnectionMap null checks hasn't been addressed. I've been fighting against the nulling-out of instance variables like this forever. It's always causing NPEs for unsuspecting programmers who don't recognize that this anti-pattern is being used. The instance variable ought to be "final" and some other state should be added and consulted to see if the connection table has been closed.

Hi @bschuchardt ,
I think that the best way is to make this threadConnectionMap final and change this close() to iterate over the map, close all connections and clear map. In this way, we don't need these null checks.
Writing it to local map and then execute command on it isn't good as computeIfAbsent() can throw NPE as we didn't know if someone deleted it as we are checking our local copy.

Tnx @bschuchardt! :)

authors: bschuchardt mhansonp mkevo pivotal-jbarrett

repo: apache/geode


text:
GROOVY-8983: STC: support "Type[] array = collectionOfTypeOrSubtype"

https://issues.apache.org/jira/browse/GROOVY-8983
NOTE: GenericsUtils.parameterizeType("List<? super Type>","Collection") returns Collection<Type> and not Collection<? super Type>.  I attempted to address this, but was not successful.  This should probably be fixed at some point because it breaks the semantics of "? super Type".

Merged. Thanks!

repo: apache/groovy


text:
[SUBMARINE-248]. Add websocket interface to submarine workbench server.

What is this PR for?
Add WebSocket interface to the submarine workbench server. So that the frontend and backend can have bidirectional communications.
What type of PR is it?
Feature
What is the Jira issue?
https://issues.apache.org/jira/browse/SUBMARINE-248
How should this be tested?
https://travis-ci.org/yuanzac/hadoop-submarine/builds/599666968
Questions:

Does the licenses files need update? No
Is there breaking changes for older versions? No
Does this needs documentation? No

Thanks @liuxunorg and @jiwq for the review~

Will merge if no more comments

authors: liuxunorg yuanzac

repo: apache/hadoop-submarine


text:
HADOOP-16409. Allow authoritative mode on non-qualified paths.

This addresses whitespace nits from Gabor's review of https://github.com/apache/hadoop/pull/1043, and allows non-qualified paths to be specified in the config.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
31
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1
mvninstall
1085
trunk passed

+1
compile
30
trunk passed

+1
checkstyle
23
trunk passed

+1
mvnsite
41
trunk passed

+1
shadedclient
684
branch has no errors when building and testing our client artifacts.

+1
javadoc
28
trunk passed

0
spotbugs
58
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
55
trunk passed

_ Patch Compile Tests _

+1
mvninstall
31
the patch passed

+1
compile
27
the patch passed

+1
javac
27
the patch passed

-0
checkstyle
16
hadoop-tools/hadoop-aws: The patch generated 1 new + 40 unchanged - 0 fixed = 41 total (was 40)

+1
mvnsite
32
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
707
patch has no errors when building and testing our client artifacts.

+1
javadoc
20
the patch passed

+1
findbugs
56
the patch passed

_ Other Tests _

+1
unit
285
hadoop-aws in the patch passed.

+1
asflicense
27
The patch does not generate ASF License warnings.

3267

Subsystem
Report/Notes

Docker
Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1054/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1054

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux fff5b7977c40 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 8965ddc

Default Java
1.8.0_212

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-1054/1/artifact/out/diff-checkstyle-hadoop-tools_hadoop-aws.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1054/1/testReport/

Max. process+thread count
414 (vs. ulimit of 5500)

modules
C: hadoop-tools/hadoop-aws U: hadoop-tools/hadoop-aws

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1054/1/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Test result against ireland: 4 known testMRJob failures, no others.
+1 on this.

authors: bgaborg hadoop-yetus mackrorysd

repo: apache/hadoop


text:
Hadoop-18169. getDelegationTokens in ViewFs should also fetch the token from fallback FS

Description of PR
cherry-pick of 15a5ea2c955a7d1b89aea0cb127727a57db76c76 from trunk to branch-2.10 and created TestViewFsLinkFallback.java file with one test case included.
All other test cases in TestViewFsLinkFallback.java from trunk are removed, as the implementation of InternalDirOfViewFs (createInternal function) is out of date and these test cases won't pass. Leave the fix and the inclusion of these other unit tests as a future pull request.
How was this patch tested?
mvn test -Dtest="TestViewFsLinkFallback"

@omalley,
Here is the backport for DelegationToken for 2.10. Could you take a look? Thanks,

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 35s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ branch-2.10 Compile Tests _

+0 :ok:
mvndep
2m 21s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
12m 12s

branch-2.10 passed

+1 :green_heart:
compile
13m  8s

branch-2.10 passed with JDK Azul Systems, Inc.-1.7.0_262-b10

+1 :green_heart:
compile
10m 45s

branch-2.10 passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~18.04-b07

+1 :green_heart:
checkstyle
1m 50s

branch-2.10 passed

+1 :green_heart:
mvnsite
2m 30s

branch-2.10 passed

+1 :green_heart:
javadoc
2m 43s

branch-2.10 passed with JDK Azul Systems, Inc.-1.7.0_262-b10

+1 :green_heart:
javadoc
2m  2s

branch-2.10 passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~18.04-b07

-1 :x:
spotbugs
2m  2s
/branch-spotbugs-hadoop-common-project_hadoop-common-warnings.html
hadoop-common-project/hadoop-common in branch-2.10 has 2 extant spotbugs warnings.

-1 :x:
spotbugs
2m 31s
/branch-spotbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html
hadoop-hdfs-project/hadoop-hdfs in branch-2.10 has 1 extant spotbugs warnings.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 20s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
1m 37s

the patch passed

+1 :green_heart:
compile
12m 21s

the patch passed with JDK Azul Systems, Inc.-1.7.0_262-b10

+1 :green_heart:
javac
12m 21s

the patch passed

+1 :green_heart:
compile
10m 46s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~18.04-b07

+1 :green_heart:
javac
10m 46s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
1m 50s

the patch passed

+1 :green_heart:
mvnsite
2m 28s

the patch passed

+1 :green_heart:
javadoc
2m 40s

the patch passed with JDK Azul Systems, Inc.-1.7.0_262-b10

+1 :green_heart:
javadoc
2m  4s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~18.04-b07

+1 :green_heart:
spotbugs
4m 51s

the patch passed

_ Other Tests _

-1 :x:
unit
8m 24s
/patch-unit-hadoop-common-project_hadoop-common.txt
hadoop-common in the patch passed.

-1 :x:
unit
62m 56s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 56s

The patch does not generate ASF License warnings.

169m 34s

Reason
Tests

Failed junit tests
hadoop.io.compress.snappy.TestSnappyCompressorDecompressor

hadoop.io.compress.TestCompressorDecompressor

hadoop.fs.sftp.TestSFTPFileSystem

hadoop.hdfs.qjournal.server.TestJournalNodeRespectsBindHostKeys

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4128/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/4128

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux 2d6802dd4aa1 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
branch-2.10 / 88a556b79fdc6952d10a6c771f7b436349830a5c

Default Java
Private Build-1.8.0_312-8u312-b07-0ubuntu1~18.04-b07

Multi-JDK versions
/usr/lib/jvm/zulu-7-amd64:Azul Systems, Inc.-1.7.0_262-b10 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~18.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4128/1/testReport/

Max. process+thread count
2709 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4128/1/console

versions
git=2.17.1 maven=3.6.0 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

This change alone seems fine. It would be good and helpful for others reviewing to identify the differences in viewfs to explain why the rest of the tests couldn't be backported, but thats more of a nice to have, not required to ship it

@mccormickt12 thanks for taking a quick review.
create() method in InternalDirOfViewFs diverged between trunk and branch-2.10. In trunk, when fallbackFS is configured, we can create a file but in branch-2.10, it does not do the check whether fallbackFS exists and simply throws "read-only fs" exception, thus failing these unit tests.

InternalDirOfViewFs class in trunk has two more members than in branch-2.10. Without access to fsState, we can not check whether a fallbackFS is set or not. Does not seem trivial to bring InternalDirOfViewFs in branch-2.10 to be in sync with trunk. Leave it as a separate patch for later.
    private final boolean showMountLinksAsSymlinks;
    private InodeTree<FileSystem> fsState;

Thanks for backporting this @xinglin and explaining what's not present in 2.10. As the rest of the functionality doesn't exist, I am good with having the required test backported. Can you please rebase your branch and push it again so Yetus gives a positive run? I am +1 on merging this PR after that.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
8m 12s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ branch-2.10 Compile Tests _

+0 :ok:
mvndep
4m  3s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
13m 58s

branch-2.10 passed

+1 :green_heart:
compile
13m 12s

branch-2.10 passed with JDK Azul Systems, Inc.-1.7.0_262-b10

+1 :green_heart:
compile
10m 50s

branch-2.10 passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~18.04-b07

+1 :green_heart:
checkstyle
2m  6s

branch-2.10 passed

+1 :green_heart:
mvnsite
2m 36s

branch-2.10 passed

+1 :green_heart:
javadoc
2m 47s

branch-2.10 passed with JDK Azul Systems, Inc.-1.7.0_262-b10

+1 :green_heart:
javadoc
2m  9s

branch-2.10 passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~18.04-b07

-1 :x:
spotbugs
2m 28s
/branch-spotbugs-hadoop-common-project_hadoop-common-warnings.html
hadoop-common-project/hadoop-common in branch-2.10 has 2 extant spotbugs warnings.

-1 :x:
spotbugs
2m 33s
/branch-spotbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html
hadoop-hdfs-project/hadoop-hdfs in branch-2.10 has 1 extant spotbugs warnings.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 24s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
1m 38s

the patch passed

+1 :green_heart:
compile
12m 23s

the patch passed with JDK Azul Systems, Inc.-1.7.0_262-b10

+1 :green_heart:
javac
12m 23s

the patch passed

+1 :green_heart:
compile
10m 46s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~18.04-b07

+1 :green_heart:
javac
10m 46s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
2m  2s

the patch passed

+1 :green_heart:
mvnsite
2m 30s

the patch passed

+1 :green_heart:
javadoc
2m 39s

the patch passed with JDK Azul Systems, Inc.-1.7.0_262-b10

+1 :green_heart:
javadoc
2m 10s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~18.04-b07

+1 :green_heart:
spotbugs
4m 56s

the patch passed

_ Other Tests _

-1 :x:
unit
8m 30s
/patch-unit-hadoop-common-project_hadoop-common.txt
hadoop-common in the patch passed.

-1 :x:
unit
63m 37s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
1m  0s

The patch does not generate ASF License warnings.

183m 18s

Reason
Tests

Failed junit tests
hadoop.io.compress.snappy.TestSnappyCompressorDecompressor

hadoop.io.compress.TestCompressorDecompressor

hadoop.fs.sftp.TestSFTPFileSystem

hadoop.hdfs.server.namenode.ha.TestEditLogTailer

hadoop.hdfs.qjournal.server.TestJournalNodeRespectsBindHostKeys

hadoop.hdfs.TestDataTransferKeepalive

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4128/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/4128

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux c9dcbe54b6da 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
branch-2.10 / 17b677c42e1dcd5b4236389e1e6735133f698c7e

Default Java
Private Build-1.8.0_312-8u312-b07-0ubuntu1~18.04-b07

Multi-JDK versions
/usr/lib/jvm/zulu-7-amd64:Azul Systems, Inc.-1.7.0_262-b10 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~18.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4128/2/testReport/

Max. process+thread count
2364 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4128/2/console

versions
git=2.17.1 maven=3.6.0 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

@virajith rebased last night but I guess we are seeing the same set of unit test failures. these tests have been failing before and don't seem to be related with our patch. Please see another example, where we see the same set of unit test failures for another backport to branch-2.10. I think we can commit this PR.
https://github.com/apache/hadoop/pull/4124

The failures in Yetus in the last run are unrelated to the changes in this PR. I will be merging this. Thanks for the backport @xinglin !

authors: hadoop-yetus virajith xinglin


text:
HDFS-17094. EC: Fix bug in block recovery when there are stale datanodes.

Description of PR
When a block recovery occurs, RecoveryTaskStriped in datanode expects rBlock.getLocations() and rBlock. getBlockIndices() to be in one-to-one correspondence. However, if there are locations in stale state when NameNode handles heartbeat, this correspondence will be disrupted. In detail, there is no stale location in recoveryLocations, but the block indices array is still complete (i.e. contains the indices of all the locations).
https://github.com/apache/hadoop/blob/c44823dadb73a3033f515329f70b2e3126fcb7be/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/DatanodeManager.java#L1720-L1724
https://github.com/apache/hadoop/blob/c44823dadb73a3033f515329f70b2e3126fcb7be/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/DatanodeManager.java#L1754-L1757
This will cause BlockRecoveryWorker.RecoveryTaskStriped#recover() to generate a wrong internal block ID, and the corresponding datanode cannot find the replica, thus making the recovery process fail.
https://github.com/apache/hadoop/blob/c44823dadb73a3033f515329f70b2e3126fcb7be/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BlockRecoveryWorker.java#L407-L416
This bug needs to be fixed.
How was this patch tested?
Add a new unit test.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 43s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
45m 26s

trunk passed

+1 :green_heart:
compile
1m 24s

trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
compile
1m 19s

trunk passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
checkstyle
1m 16s

trunk passed

+1 :green_heart:
mvnsite
1m 31s

trunk passed

+1 :green_heart:
javadoc
1m 12s

trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
1m 39s

trunk passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
spotbugs
3m 20s

trunk passed

+1 :green_heart:
shadedclient
35m 43s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 13s

the patch passed

+1 :green_heart:
compile
1m 16s

the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javac
1m 16s

the patch passed

+1 :green_heart:
compile
1m 11s

the patch passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
javac
1m 11s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
1m  2s

the patch passed

+1 :green_heart:
mvnsite
1m 19s

the patch passed

+1 :green_heart:
javadoc
0m 56s

the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
1m 30s

the patch passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
spotbugs
3m 13s

the patch passed

+1 :green_heart:
shadedclient
35m 58s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
214m 54s

hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 55s

The patch does not generate ASF License warnings.

357m 49s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5854/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5854

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux f7f9bf4d0ae1 4.15.0-212-generic #223-Ubuntu SMP Tue May 23 13:09:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 5b72c1d7c5ef527c328245874ab5f5d7ab86e9ab

Default Java
Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5854/1/testReport/

Max. process+thread count
3374 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5854/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@Hexiaoqiao @tomscut Thanks for your review. I've update this PR according to the suggestions. Please take a look, thanks again.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 42s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
52m 58s

trunk passed

+1 :green_heart:
compile
1m 42s

trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
compile
1m 29s

trunk passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
checkstyle
1m 23s

trunk passed

+1 :green_heart:
mvnsite
1m 40s

trunk passed

+1 :green_heart:
javadoc
1m 21s

trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
2m  0s

trunk passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
spotbugs
4m  5s

trunk passed

-1 :x:
shadedclient
42m 13s

branch has errors when building and testing our client artifacts.

_ Patch Compile Tests _

-1 :x:
mvninstall
0m 23s
/patch-mvninstall-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch failed.

+1 :green_heart:
compile
1m 32s

the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javac
1m 32s

the patch passed

+1 :green_heart:
compile
1m 26s

the patch passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
javac
1m 26s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
1m 13s

the patch passed

+1 :green_heart:
mvnsite
1m 30s

the patch passed

+1 :green_heart:
javadoc
1m  6s

the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
1m 36s

the patch passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
spotbugs
3m 48s

the patch passed

+1 :green_heart:
shadedclient
36m 38s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
223m 42s

hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 58s

The patch does not generate ASF License warnings.

382m 58s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5854/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5854

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 79c529060291 4.15.0-212-generic #223-Ubuntu SMP Tue May 23 13:09:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 446ddffc53cb891e0a410bd76a6864666f22ff11

Default Java
Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5854/2/testReport/

Max. process+thread count
3594 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5854/2/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 42s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
49m 27s

trunk passed

+1 :green_heart:
compile
1m 27s

trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
compile
1m 21s

trunk passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
checkstyle
1m 14s

trunk passed

+1 :green_heart:
mvnsite
1m 29s

trunk passed

+1 :green_heart:
javadoc
1m 12s

trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
1m 38s

trunk passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
spotbugs
3m 20s

trunk passed

+1 :green_heart:
shadedclient
35m 43s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 16s

the patch passed

+1 :green_heart:
compile
1m 12s

the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javac
1m 12s

the patch passed

+1 :green_heart:
compile
1m 11s

the patch passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
javac
1m 11s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
1m  1s

the patch passed

+1 :green_heart:
mvnsite
1m 16s

the patch passed

+1 :green_heart:
javadoc
0m 57s

the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
1m 31s

the patch passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
spotbugs
3m 14s

the patch passed

+1 :green_heart:
shadedclient
36m  2s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
215m 51s

hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 58s

The patch does not generate ASF License warnings.

362m 17s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5854/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5854

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 3913e9b84c85 4.15.0-212-generic #223-Ubuntu SMP Tue May 23 13:09:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 446ddffc53cb891e0a410bd76a6864666f22ff11

Default Java
Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5854/3/testReport/

Max. process+thread count
3028 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5854/3/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@zhangshuyan0 Could you please backport this to branch-3.3? Thanks!

@zhangshuyan0 Could you please backport this to branch-3.3? Thanks!

Ok, I'll do this later.

@tomscut This PR can cherry pick to branch-3.3 smoothly, Please cherry-pick directly if you evaluate it also need to fix for branch-3.3 rather than submit another PR. Thanks.

@tomscut This PR can cherry pick to branch-3.3 smoothly, Please cherry-pick directly if you evaluate it also need to fix for branch-3.3 rather than submit another PR. Thanks.

OKK, I have backport to branch-3.3. I thought it would be safer to trigger jenkins. But for this PR, it's really not necessary. Thank you for your advice.

authors: Hexiaoqiao hadoop-yetus tomscut zhangshuyan0


text:
YARN-11592. Add timeout to GPGUtils#invokeRMWebService.

Description of PR
JIRA: YARN-11592. Add timeout to GPGUtils#invokeRMWebService.
How was this patch tested?
For code changes:

[ ] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
[ ] Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
11m 33s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+0 :ok:
xmllint
0m  0s

xmllint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
15m 19s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
20m 22s

trunk passed

+1 :green_heart:
compile
4m 30s

trunk passed with JDK Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
4m  3s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
checkstyle
1m 13s

trunk passed

+1 :green_heart:
mvnsite
2m 11s

trunk passed

+1 :green_heart:
javadoc
2m 13s

trunk passed with JDK Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
2m  7s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
spotbugs
3m 34s

trunk passed

+1 :green_heart:
shadedclient
20m 48s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 25s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
1m  9s

the patch passed

+1 :green_heart:
compile
4m  0s

the patch passed with JDK Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javac
4m  0s

the patch passed

+1 :green_heart:
compile
3m 50s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
javac
3m 50s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
1m  6s

the patch passed

+1 :green_heart:
mvnsite
1m 54s

the patch passed

+1 :green_heart:
javadoc
1m 56s

the patch passed with JDK Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
1m 53s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
spotbugs
3m 43s

the patch passed

+1 :green_heart:
shadedclient
21m  7s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
0m 55s

hadoop-yarn-api in the patch passed.

+1 :green_heart:
unit
4m 49s

hadoop-yarn-common in the patch passed.

+1 :green_heart:
unit
0m 55s

hadoop-yarn-server-globalpolicygenerator in the patch passed.

+1 :green_heart:
asflicense
0m 47s

The patch does not generate ASF License warnings.

141m 23s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6189/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6189

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets xmllint

uname
Linux 4b7c9e4364ed 4.15.0-213-generic #224-Ubuntu SMP Mon Jun 19 13:30:12 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 3f3f91ce98cd23e9a14a7af041e635179617c5a8

Default Java
Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6189/1/testReport/

Max. process+thread count
553 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-globalpolicygenerator U: hadoop-yarn-project/hadoop-yarn

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6189/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 26s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+0 :ok:
xmllint
0m  1s

xmllint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
15m 59s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
19m 51s

trunk passed

+1 :green_heart:
compile
4m 29s

trunk passed with JDK Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
4m  1s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
checkstyle
1m 13s

trunk passed

+1 :green_heart:
mvnsite
2m 51s

trunk passed

+1 :green_heart:
javadoc
2m 54s

trunk passed with JDK Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
2m 45s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
spotbugs
4m 24s

trunk passed

+1 :green_heart:
shadedclient
20m 48s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 26s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
1m 27s

the patch passed

+1 :green_heart:
compile
3m 54s

the patch passed with JDK Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javac
3m 54s

the patch passed

+1 :green_heart:
compile
3m 53s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
javac
3m 53s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
1m  8s
/results-checkstyle-hadoop-yarn-project_hadoop-yarn.txt
hadoop-yarn-project/hadoop-yarn: The patch generated 1 new + 164 unchanged - 0 fixed = 165 total (was 164)

+1 :green_heart:
mvnsite
2m 32s

the patch passed

+1 :green_heart:
javadoc
2m 31s

the patch passed with JDK Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
2m 27s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
spotbugs
4m 40s

the patch passed

+1 :green_heart:
shadedclient
21m 22s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
0m 57s

hadoop-yarn-api in the patch passed.

+1 :green_heart:
unit
4m 50s

hadoop-yarn-common in the patch passed.

-1 :x:
unit
0m 36s
/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client.txt
hadoop-yarn-client in the patch failed.

+1 :green_heart:
unit
0m 55s

hadoop-yarn-server-globalpolicygenerator in the patch passed.

+1 :green_heart:
asflicense
0m 47s

The patch does not generate ASF License warnings.

137m  2s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6189/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6189

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets xmllint

uname
Linux 4db31f3a3fa2 4.15.0-212-generic #223-Ubuntu SMP Tue May 23 13:09:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 2bac4178db80535ab2b252690b6bbf535f52d067

Default Java
Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6189/2/testReport/

Max. process+thread count
617 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-globalpolicygenerator U: hadoop-yarn-project/hadoop-yarn

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6189/2/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 26s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+0 :ok:
xmllint
0m  0s

xmllint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
16m  5s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
20m 15s

trunk passed

+1 :green_heart:
compile
4m 32s

trunk passed with JDK Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
4m  1s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
checkstyle
1m 13s

trunk passed

+1 :green_heart:
mvnsite
2m 51s

trunk passed

+1 :green_heart:
javadoc
2m 52s

trunk passed with JDK Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
2m 44s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
spotbugs
4m 25s

trunk passed

+1 :green_heart:
shadedclient
21m  9s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 25s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
1m 29s

the patch passed

+1 :green_heart:
compile
3m 53s

the patch passed with JDK Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javac
3m 53s

the patch passed

+1 :green_heart:
compile
3m 56s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
javac
3m 56s

the patch passed

+1 :green_heart:
blanks
0m  1s

The patch has no blanks issues.

-0 :warning:
checkstyle
1m  8s
/results-checkstyle-hadoop-yarn-project_hadoop-yarn.txt
hadoop-yarn-project/hadoop-yarn: The patch generated 1 new + 164 unchanged - 0 fixed = 165 total (was 164)

+1 :green_heart:
mvnsite
2m 28s

the patch passed

+1 :green_heart:
javadoc
2m 26s

the patch passed with JDK Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
2m 21s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
spotbugs
4m 41s

the patch passed

+1 :green_heart:
shadedclient
21m 12s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
0m 56s

hadoop-yarn-api in the patch passed.

+1 :green_heart:
unit
4m 49s

hadoop-yarn-common in the patch passed.

-1 :x:
unit
0m 36s
/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client.txt
hadoop-yarn-client in the patch failed.

+1 :green_heart:
unit
0m 55s

hadoop-yarn-server-globalpolicygenerator in the patch passed.

+1 :green_heart:
asflicense
0m 47s

The patch does not generate ASF License warnings.

137m 56s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6189/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6189

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets xmllint

uname
Linux af5599409b7d 4.15.0-213-generic #224-Ubuntu SMP Mon Jun 19 13:30:12 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 16d99187211c620092dc2aaa593e196bb94b3359

Default Java
Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6189/3/testReport/

Max. process+thread count
755 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-globalpolicygenerator U: hadoop-yarn-project/hadoop-yarn

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6189/3/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 27s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+0 :ok:
xmllint
0m  0s

xmllint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
15m  4s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
19m 59s

trunk passed

+1 :green_heart:
compile
4m 30s

trunk passed with JDK Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
4m  5s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
checkstyle
1m 16s

trunk passed

+1 :green_heart:
mvnsite
2m 51s

trunk passed

+1 :green_heart:
javadoc
2m 52s

trunk passed with JDK Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
2m 44s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
spotbugs
4m 25s

trunk passed

+1 :green_heart:
shadedclient
21m  6s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 25s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
1m 28s

the patch passed

+1 :green_heart:
compile
3m 52s

the patch passed with JDK Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javac
3m 52s

the patch passed

+1 :green_heart:
compile
3m 53s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
javac
3m 53s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
1m  4s

the patch passed

+1 :green_heart:
mvnsite
2m 30s

the patch passed

+1 :green_heart:
javadoc
2m 30s

the patch passed with JDK Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
2m 26s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
spotbugs
4m 33s

the patch passed

+1 :green_heart:
shadedclient
21m  9s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
0m 56s

hadoop-yarn-api in the patch passed.

+1 :green_heart:
unit
4m 48s

hadoop-yarn-common in the patch passed.

-1 :x:
unit
0m 36s
/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client.txt
hadoop-yarn-client in the patch failed.

+1 :green_heart:
unit
0m 56s

hadoop-yarn-server-globalpolicygenerator in the patch passed.

+1 :green_heart:
asflicense
0m 47s

The patch does not generate ASF License warnings.

136m 30s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6189/4/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6189

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets xmllint

uname
Linux 36fc2cc59e18 4.15.0-213-generic #224-Ubuntu SMP Mon Jun 19 13:30:12 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / c38f58c72e9d4bc15ba8236c956169669a5d0bbd

Default Java
Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6189/4/testReport/

Max. process+thread count
613 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-globalpolicygenerator U: hadoop-yarn-project/hadoop-yarn

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6189/4/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 26s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+0 :ok:
xmllint
0m  0s

xmllint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
15m 53s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
22m  9s

trunk passed

+1 :green_heart:
compile
5m 11s

trunk passed with JDK Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
4m 24s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
checkstyle
1m 13s

trunk passed

+1 :green_heart:
mvnsite
2m 40s

trunk passed

+1 :green_heart:
javadoc
2m 45s

trunk passed with JDK Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
2m 35s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
spotbugs
4m  9s

trunk passed

+1 :green_heart:
shadedclient
25m 50s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 25s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
1m 17s

the patch passed

+1 :green_heart:
compile
3m 54s

the patch passed with JDK Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javac
3m 54s

the patch passed

+1 :green_heart:
compile
4m 30s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
javac
4m 30s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
1m 15s

the patch passed

+1 :green_heart:
mvnsite
2m 17s

the patch passed

+1 :green_heart:
javadoc
2m 32s

the patch passed with JDK Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
2m 23s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
spotbugs
4m 44s

the patch passed

+1 :green_heart:
shadedclient
23m 40s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
0m 52s

hadoop-yarn-api in the patch passed.

+1 :green_heart:
unit
4m 48s

hadoop-yarn-common in the patch passed.

-1 :x:
unit
0m 34s
/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client.txt
hadoop-yarn-client in the patch failed.

+1 :green_heart:
unit
0m 57s

hadoop-yarn-server-globalpolicygenerator in the patch passed.

+1 :green_heart:
asflicense
0m 48s

The patch does not generate ASF License warnings.

147m 23s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch-windows-10/job/PR-6189/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6189

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets xmllint

uname
Linux 602f21487dad 4.15.0-212-generic #223-Ubuntu SMP Tue May 23 13:09:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / c38f58c72e9d4bc15ba8236c956169669a5d0bbd

Default Java
Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch-windows-10/job/PR-6189/1/testReport/

Max. process+thread count
554 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-globalpolicygenerator U: hadoop-yarn-project/hadoop-yarn

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch-windows-10/job/PR-6189/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 24s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+0 :ok:
xmllint
0m  0s

xmllint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
15m 39s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
20m 10s

trunk passed

+1 :green_heart:
compile
4m 29s

trunk passed with JDK Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
4m  1s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
checkstyle
1m 13s

trunk passed

+1 :green_heart:
mvnsite
2m 50s

trunk passed

+1 :green_heart:
javadoc
2m 52s

trunk passed with JDK Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
2m 45s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
spotbugs
4m 26s

trunk passed

+1 :green_heart:
shadedclient
21m  5s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 26s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
1m 28s

the patch passed

+1 :green_heart:
compile
3m 53s

the patch passed with JDK Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javac
3m 53s

the patch passed

+1 :green_heart:
compile
3m 58s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
javac
3m 58s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
1m  5s

the patch passed

+1 :green_heart:
mvnsite
2m 30s

the patch passed

+1 :green_heart:
javadoc
2m 30s

the patch passed with JDK Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
2m 26s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
spotbugs
4m 35s

the patch passed

+1 :green_heart:
shadedclient
20m 57s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
0m 56s

hadoop-yarn-api in the patch passed.

+1 :green_heart:
unit
4m 48s

hadoop-yarn-common in the patch passed.

+1 :green_heart:
unit
26m  6s

hadoop-yarn-client in the patch passed.

+1 :green_heart:
unit
0m 58s

hadoop-yarn-server-globalpolicygenerator in the patch passed.

+1 :green_heart:
asflicense
0m 50s

The patch does not generate ASF License warnings.

162m 39s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6189/5/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6189

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets xmllint

uname
Linux 740c2c885900 4.15.0-213-generic #224-Ubuntu SMP Mon Jun 19 13:30:12 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 0836b2b76db98ef0b298bc2580e71b278aa46cc2

Default Java
Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6189/5/testReport/

Max. process+thread count
577 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-globalpolicygenerator U: hadoop-yarn-project/hadoop-yarn

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6189/5/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@goiri Can you help review this PR? Thank you very much!

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 25s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+0 :ok:
xmllint
0m  1s

xmllint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
16m 13s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
20m 16s

trunk passed

+1 :green_heart:
compile
4m 39s

trunk passed with JDK Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
4m  0s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
checkstyle
1m 12s

trunk passed

+1 :green_heart:
mvnsite
2m 51s

trunk passed

+1 :green_heart:
javadoc
2m 51s

trunk passed with JDK Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
2m 44s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
spotbugs
4m 23s

trunk passed

+1 :green_heart:
shadedclient
21m 13s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 25s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
1m 28s

the patch passed

+1 :green_heart:
compile
3m 53s

the patch passed with JDK Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javac
3m 53s

the patch passed

+1 :green_heart:
compile
3m 57s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
javac
3m 57s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
1m  6s

the patch passed

+1 :green_heart:
mvnsite
2m 32s

the patch passed

+1 :green_heart:
javadoc
2m 30s

the patch passed with JDK Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
2m 27s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
spotbugs
4m 33s

the patch passed

+1 :green_heart:
shadedclient
20m 56s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
0m 56s

hadoop-yarn-api in the patch passed.

+1 :green_heart:
unit
4m 49s

hadoop-yarn-common in the patch passed.

+1 :green_heart:
unit
26m 10s

hadoop-yarn-client in the patch passed.

+1 :green_heart:
unit
0m 59s

hadoop-yarn-server-globalpolicygenerator in the patch passed.

+1 :green_heart:
asflicense
0m 51s

The patch does not generate ASF License warnings.

163m 39s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6189/6/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6189

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets xmllint

uname
Linux a7bba7fed213 4.15.0-213-generic #224-Ubuntu SMP Mon Jun 19 13:30:12 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 6256a3c5e19afd9e1afc1f8b7e4d236db5aaca86

Default Java
Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6189/6/testReport/

Max. process+thread count
726 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-globalpolicygenerator U: hadoop-yarn-project/hadoop-yarn

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6189/6/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@goiri Thank you very much for your help in reviewing the code!