text:
Crash app with platform-mac

Thread 4 Crashed:: io.flutter.ui

0 libsystem_kernel.dylib 0x00007fff6c6e22c6 __pthread_kill + 10

1 libsystem_pthread.dylib 0x00007fff6c79dbf1 pthread_kill + 284

2 libsystem_c.dylib 0x00007fff6c64c6a6 abort + 127

3 io.flutter.flutter-macos 0x000000010edad829 std::__1::__throw_system_error(int, char const*) + 9

4 io.flutter.flutter-macos 0x000000010edaa6d3 std::__1::mutex::lock() + 67

5 io.flutter.flutter-macos 0x000000010edb935f fml::MessageLoopTaskQueues::GetNextTaskToRun(fml::TaskQueueId, fml::TimePoint) + 639

6 io.flutter.flutter-macos 0x000000010edb8519 fml::MessageLoopImpl::FlushTasks(fml::FlushType) + 121

7 io.flutter.flutter-macos 0x000000010edbf94c fml::MessageLoopDarwin::OnTimerFire(__CFRunLoopTimer*, fml::MessageLoopDarwin*) + 44

8 com.apple.CoreFoundation 0x00007fff406717c0 __CFRUNLOOP_IS_CALLING_OUT_TO_A_TIMER_CALLBACK_FUNCTION__ + 20

9 com.apple.CoreFoundation 0x00007fff4067136c __CFRunLoopDoTimer + 851

10 com.apple.CoreFoundation 0x00007fff40670eb2 __CFRunLoopDoTimers + 330

11 com.apple.CoreFoundation 0x00007fff406520c2 __CFRunLoopRun + 2130

12 com.apple.CoreFoundation 0x00007fff4065161e CFRunLoopRunSpecific + 455

13 io.flutter.flutter-macos 0x000000010edbfbae fml::MessageLoopDarwin::Run() + 142

14 io.flutter.flutter-macos 0x000000010edb83c4 fml::MessageLoopImpl::DoRun() + 36

15 io.flutter.flutter-macos 0x000000010edbeb8a void* std::__1::__thread_proxy >, fml::Thread::Thread(std::__1::basic_string, std::__1::allocator > const&)::$_0> >(void*) + 266

16 libsystem_pthread.dylib 0x00007fff6c79b2eb _pthread_body + 126

17 libsystem_pthread.dylib 0x00007fff6c79e249 _pthread_start + 66

18 libsystem_pthread.dylib 0x00007fff6c79a40d thread_start + 13

@darshankawar after i upgraded to 2.6. when i close app. this crash log:
Thread 0 Crashed:: Dispatch queue: com.apple.main-thread 0   io.flutter.flutter-macos      	0x0000000116698f76 sk_abort_no_print() + 22 1   io.flutter.flutter-macos      	0x0000000116e37b02 GrManagedResource::Trace::~Trace()::'lambda'()::operator()() const + 50 2   io.flutter.flutter-macos      	0x0000000116e379b4 GrManagedResource::Trace::~Trace() + 100 3   io.flutter.flutter-macos      	0x0000000116e37493 GrManagedResource::Trace::~Trace() + 35 4   libsystem_c.dylib             	0x00007fff2024aca7 __cxa_finalize_ranges + 316 5   libsystem_c.dylib             	0x00007fff2024af92 exit + 53 6   com.apple.AppKit              	0x00007fff22ed9746 -[NSApplication terminate:] + 1725 7   com.apple.AppKit              	0x00007fff22e51c4e -[NSApplication(NSResponder) sendAction:to:from:] + 283 8   com.apple.AppKit              	0x00007fff22f54a61 -[NSMenuItem _corePerformAction] + 413 9   com.apple.AppKit              	0x00007fff22f54780 -[NSCarbonMenuImpl performActionWithHighlightingForItemAtIndex:] + 95 10  com.apple.AppKit              	0x00007fff22f537e5 -[NSMenu performKeyEquivalent:] + 412 11  com.apple.AppKit              	0x00007fff233a6910 routeKeyEquivalent + 521 12  com.apple.AppKit              	0x00007fff22db8af7 -[NSApplication(NSEvent) sendEvent:] + 1155 13  com.apple.AppKit              	0x00007fff2309136e -[NSApplication _handleEvent:] + 65 14  com.apple.AppKit              	0x00007fff22c21b2f -[NSApplication run] + 623 15  com.apple.AppKit              	0x00007fff22bf5df2 NSApplicationMain + 816 16  vn.pancake.chat               	0x000000010d4e1f1d main + 13 17  libdyld.dylib                 	0x00007fff20338621 start + 1

@letungcntt
I tried a sample macOS app on latest master and ran it in release mode and then pressed cmd +q to quit which closed it without throwing any issues.  If it doesn't represent your use case, please provide detailed steps to replicate the issue, so that we can properly address it.
Thanks.

source: gharchive/issue

authors: darshankawar letungcntt

repo: flutter/flutter

license_type: permissive

license_source: github-api


text:
[Proposal] Document availabilty of icons in a Flutter release

With Google Fonts constantly adding and removing fonts, it is hard to know which fonts are supported or not in Flutter.
Yesterday I wanted 'terminal' icon, it shows on the website but it is nowhere in Flutter (and I'm on Flutter Beta). Probably the next time icons are refreshed it will be there.
Meanwhile, icons such as Facebook, Adobe and WeChat were removed from the website but are still present on Flutter. Many things are unclear.

Hi @bernaferrari, Thanks for reporting, I agree there should be some clarity about the availability of material icons in a flutter version.

I know this may not be as interactive as Google Fonts, but the Icons' API Doc does document the available material icons. For the master branch, this can be referred to.

Oh, sure. But it is too time-consuming to see if it is in Flutter, what Flutter version contains it and why my version doesn't. Wish Google Fonts just showed 'not available in Flutter yet'.

Adding @guidezpl . Is the goal to know version-by-version or just to make sure that Flutter is as up-to-date as possible? Because we can hopefully work with Fonts on the workflow there but it would always go into Master. Otherwise it's a front end of fonts.google.com change that's needed to give more info?

My goal is to be able to see if the font I want is coming soon or will still take a while. Maybe having master + release comparison could be good enough, just saying (you need channel master for this font instead of stable) could help.

Would a minimum Flutter version availability number be useful? like "🍄 2.1.3"

Yeah. But for me what matters most is the channel. If you put '2.1.3-pre-beta' it would be useful.

Thanks. Can't make any promises but we'll investigate. Thanks for using the icons!

Hi, the Google Fonts web team is responsible for the integration, so feedback can be filed via the website. For the Flutter side of things:

https://master-api.flutter.dev/flutter/material/Icons-class.html lists icons available on the master channel
https://api.flutter.dev/flutter/material/Icons-class.html lists the icons available on the stable channel
the source file for any version can be searched

Additionally, the merge commit for PRs adding icons lists all versions those icons are a part of (see https://github.com/flutter/flutter/wiki/Where's-my-Commit%3F), e.g.:

Regarding terminal_outlined, it was added by the latest update https://master-api.flutter.dev/flutter/material/Icons/terminal_outlined-constant.html
All in all, I think it's sufficiently documented.

Google Fonts web team is responsible for the integration, so feedback can be filed via the website.

Yeah, but it is not public, so I'll never know what happened nor be able to discuss it, like here where we were talking about which branch is relevant.

the merge commit for PRs adding icons lists all versions those icons are a part of
It is, but shall I manually search through the commit list and master list and stable list to see where the icon belongs? I think it would be easier for Google Fonts to just have a link "check if Flutter has this icon" or "check which branches this is", because right now you spend 5 minutes finding where the icon is.

There is an opportunity here to add https://beta-api.flutter.dev/ but I don't know how much additional work that would involve.

It is, but shall I manually search through the commit list and master list and stable list to see where the icon belongs? I think it would be easier for Google Fonts to just have a link "check if Flutter has this icon" or "check which branches this is", because right now you spend 5 minutes finding where the icon is.

You can enter the icon name in th API docs search box to find out instantly whether an icon is available.

The icon page froze my browser (in PC) and the GitHub thing doesn't even show without 'raw'. It is too heavy and all I want is to know where is a single icon.

The APi docs definitely shouldn't freeze and I've never run into this, so it would be helpful to file a bug report with more details on flutter/website! I'm not sure why searching https://raw.githubusercontent.com/flutter/flutter/master/packages/flutter/lib/src/material/icons.dart is a problem

This is probably going to be deprecated with Material Symbols https://github.com/flutter/flutter/issues/102560.

authors: bernaferrari guidezpl maheshmnj werainkhatri willlarche


text:
add discussion page

Use case

Proposal

Duplicate of https://github.com/flutter/flutter/issues/60696


text:
Framework crashes on startup, complains about Z key??

Steps to Reproduce

everything was working fine then all of the sudden I started getting this error/crash right when I try to compile/run the app.
PS I'm unlikely to report framework bugs in the future since it's a hassle (I had to figure out my github login since I don't use github anymore, then run several commands and copy/paste output into this bug) — why not just have the Flutter AS plugin add a "report bug" option that collects these logs automatically and creates a bug?

Code sample

Logs

======== Exception caught by services library ======================================================
The following assertion was thrown during a platform message callback:
A KeyUpEvent is dispatched, but the state shows that the physical key is not pressed. If this occurs in real application, please report this bug to Flutter. If this occurs in unit tests, please ensure that simulated events follow Flutter's event model as documented in `HardwareKeyboard`. This was the event: KeyUpEvent#2676d(physicalKey: PhysicalKeyboardKey#7001d(usbHidUsage: "0x0007001d", debugName: "Key Z"), logicalKey: LogicalKeyboardKey#0007a(keyId: "0x0000007a", keyLabel: "Z", debugName: "Key Z"), character: null, timeStamp: 456:12:43.208645)
'package:flutter/src/services/hardware_keyboard.dart':
Failed assertion: line 441 pos 16: '_pressedKeys.containsKey(event.physicalKey)'

Either the assertion indicates an error in the framework itself, or we should provide substantially more information in this error message to help you determine and fix the underlying cause.
In either case, please report this assertion by filing a bug on GitHub:
  https://github.com/flutter/flutter/issues/new?template=2_bug.md

When the exception was thrown, this was the stack:
#2      HardwareKeyboard._assertEventIsRegular.<anonymous closure> (package:flutter/src/services/hardware_keyboard.dart:441:16)
#3      HardwareKeyboard._assertEventIsRegular (package:flutter/src/services/hardware_keyboard.dart:452:6)
#4      HardwareKeyboard.handleKeyEvent (package:flutter/src/services/hardware_keyboard.dart:544:5)
#5      KeyEventManager.handleRawKeyMessage (package:flutter/src/services/hardware_keyboard.dart:821:35)
#6      BasicMessageChannel.setMessageHandler.<anonymous closure> (package:flutter/src/services/platform_channel.dart:77:49)
#7      BasicMessageChannel.setMessageHandler.<anonymous closure> (package:flutter/src/services/platform_channel.dart:76:47)
#8      _DefaultBinaryMessenger.setMessageHandler.<anonymous closure> (package:flutter/src/services/binding.dart:377:35)
#9      _DefaultBinaryMessenger.setMessageHandler.<anonymous closure> (package:flutter/src/services/binding.dart:374:46)
#10     _invoke2.<anonymous closure> (dart:ui/hooks.dart:190:15)
#14     _invoke2 (dart:ui/hooks.dart:189:10)
#15     _ChannelCallbackRecord.invoke (dart:ui/channel_buffers.dart:42:5)
#16     _Channel.push (dart:ui/channel_buffers.dart:132:31)
#17     ChannelBuffers.push (dart:ui/channel_buffers.dart:329:17)
#18     PlatformDispatcher._dispatchPlatformMessage (dart:ui/platform_dispatcher.dart:583:22)
#19     _dispatchPlatformMessage (dart:ui/hooks.dart:89:31)
(elided 5 frames from class _AssertionError and dart:async)
====================================================================================================

Analyzing raw...
No issues found! (ran in 0.8s)

[✓] Flutter (Channel beta, 2.10.0-0.3.pre, on macOS 12.0.1 21A559 darwin-arm, locale en-US)
    • Flutter version 2.10.0-0.3.pre at /Users/mihai/dev/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision fdd0af78bb (3 weeks ago), 2022-01-25 22:01:33 -0600
    • Engine revision 5ac30ef0c7
    • Dart version 2.16.0 (build 2.16.0-134.5.beta)
    • DevTools version 2.9.2

[✓] Android toolchain - develop for Android devices (Android SDK version 32.1.0-rc1)
    • Android SDK at /Users/mihai/Library/Android/sdk
    • Platform android-31, build-tools 32.1.0-rc1
    • ANDROID_HOME = /Users/mihai/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jre/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.11+0-b60-7772763)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 13.2.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • CocoaPods version 1.11.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2021.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.11+0-b60-7772763)

[✓] VS Code (version 1.63.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension can be installed from:
      🔨 https://marketplace.visualstudio.com/items?itemName=Dart-Code.flutter

[✓] Connected device (3 available)
    • Pixel 4 XL (mobile) • 96071FFBA00055                       • android-arm64  • Android 11 (API 30)
    • iPhone 13 (mobile)  • 900F5EC7-231D-4E15-9C75-E6B3C458E245 • ios            •
      com.apple.CoreSimulator.SimRuntime.iOS-15-2 (simulator)
    • Chrome (web)        • chrome                               • web-javascript • Google Chrome 98.0.4758.80

[✓] HTTP Host Availability
    • All required HTTP hosts are available

• No issues found!

@mihaibulic
Looking at the error log you shared, it seems to be similar to below reported issues:
https://github.com/flutter/flutter/issues/98071.  -> this is reported on Windows
https://github.com/flutter/flutter/issues/95888. -> this was fixed in December.
Since you are on older version of beta, can you upgrade it to the latest or also try to switch to latest master and try again the scenario to see if you still get the same error or not.

authors: darshankawar mihaibulic


text:
Roll Flutter Engine from d1afda52d254 to e47f8766c171 (3 revisions)

https://github.com/flutter/engine/compare/d1afda52d254...e47f8766c171
2024-01-19 leroux_bruno@yahoo.fr [Android] Fix KeyEmbedderResponder throws a NullPointerException (flutter/engine#49860)
2024-01-19 skia-flutter-autoroll@skia.org Roll Skia from dd24bd11d79e to e073a4fad57a (1 revision) (flutter/engine#49881)
2024-01-19 skia-flutter-autoroll@skia.org Manual roll Dart SDK from d6c08fa9bb54 to 8d697eaa395c (23 revisions) (flutter/engine#49880)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Commit queue failed; closing this roll.

source: gharchive/pull-request


text:
[CupertinoActionSheet] Match colors to native

This PR matches the various colors of CupertinoActionSheet more closely with the native one.
The following colors are changed.

Sheet background color
Pressed button color
Cancel button color
Pressed cancel button color
Divider color
Content text color

The resulting colors match with native one with deviation of at most 1 (in terms of 0~255 RGB).
The following are comparison (left to right: Native, Flutter after PR, Flutter current)

Note: The divider thickness is adjusted to 1/dpr instead of 0.3 in both Flutter version to make them look more native, as will be proposed in https://github.com/flutter/flutter/pull/149636.
Derivation
All the colors are derived through color picker and calculation. The algorithm is as followed:

Assume all colors are translucent grey colors, i.e. having the same value x for R, G, and B, with an alpha a.
Given the barrier color is x_B1=0 when the background is black, and x_B2=204 when the background is white.
Pick the target color x_t1 when the background is black, and x_t2 when the background is white
Solve the following equations for x and a

a * x + (1-a) * x_B1 = x_t1
a * x + (1-a) * x_B2 = x_t2

a = 1 - (x_t1 - x_t2) / (x_B1 - x_B2)
x = (x_t1 - (1-a) * x_B1) / a

These equations use a linear model for color composition, which might not be exact, but is close enough for an accuracy of (1/255).
The full table is as follows:

The first two columns are colors picked from XCode.
The 3~4 columns are the colors picked from the current Flutter. Notice the deviation, which is sometimes drastic.
The 5~6 columns are the colors picked from Flutter after this PR. The deviation is at most 1.
The last few columns are calculation.

There are two rows whose calculation is based on adjusted numbers, since the original results are not accurate enough, possibly due to the linear composition.

During the calculation, I assumed these colors vary between light and dark modes, but it turns out that both modes use the same set of colors.
Screenshots
Pre-launch Checklist

[ ] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[ ] I read the Tree Hygiene wiki page, which explains my responsibilities.
[ ] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[ ] I signed the CLA.
[ ] I listed at least one issue that this PR fixes in the description above.
[ ] I updated/added relevant documentation (doc comments with ///).
[ ] I added new tests to check the change I am making, or this PR is test-exempt.
[ ] I followed the breaking change policy and added Data Driven Fixes where supported.
[ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Reason for revert: Appears to be failing tests in tree
01:48 +2991 ~18: /Volumes/Work/s/w/ir/x/w/flutter/packages/flutter/test/cupertino/action_sheet_test.dart: Taps on a button can be slided to other buttons
 ══╡ EXCEPTION CAUGHT BY FLUTTER TEST FRAMEWORK ╞════════════════════════════════════════════════════
 The following SkiaException was thrown while running async test code:
 Skia Gold received an unapproved image in post-submit
 testing. Golden file images in flutter/flutter are triaged
 in pre-submit during code review for the given PR.
 Visit https://flutter-gold.skia.org/ to view and approve
 the image(s), or revert the associated change. For more
 information, visit the wiki:
 https://github.com/flutter/flutter/wiki/Writing-a-golden-file-test-for-package:flutter
 Debug information for Gold --------------------------------
 stdout: Given image with hash 601f421e3bb643f437cc12395de96152 for test
 cupertino.cupertinoActionSheet.press-drag
 Expectation for test: ce8ef79c146857d162663b1161fd6d5c (positive)
 Expectation for test: 3bb57a8782f67836c6ad3ece7f00729a (positive)
 Expectation for test: 3f8c592774caf3c760fbbd318a7dc5af (positive)
 Expectation for test: 61863f38217aa3349c239eeb49b84930 (positive)
 Expectation for test: 98af16e9b7eb3fb810b44c74bb18ffb9 (positive)
 Untriaged or negative image:
 https://flutter-gold.skia.org//detail?grouping=name%3Dcupertino.cupertinoActionSheet.press-drag%26source_type%3Dflutter&digest=601f421e3bb643f437cc12395de96152
 stderr: Test: cupertino.cupertinoActionSheet.press-drag FAIL
 result-state.json: No result file found.

PR to manual revert: https://github.com/flutter/flutter/pull/149998

@dkwingsmt I have problems with the colors in dark mode, I suspect this PR has broken something.

@dkwingsmt I have problems with the colors in dark mode, I suspect this PR has broken something.
I see some colors are not resolved by CupertinoDynamicColor.resolve, maybe thats the issue.

Can you provide me with screenshots and code to reproduce? I might have used the wrong method to test.

Hi @dkwingsmt,
I´m using this code to reproduce:
void main() {
 runApp(TestScaffoldApp(
   theme: const CupertinoThemeData(brightness: Brightness.dark),
   actionSheet: CupertinoActionSheet(
     actions: [
       CupertinoActionSheetAction(
         onPressed: () {},
         child: Text('Button'),
       ),
       CupertinoActionSheetAction(
         onPressed: () {},
         child: Text('Button'),
       ),
     ],
     cancelButton: CupertinoActionSheetAction(
       isDefaultAction: true,
       child: Text("Cancel"),
       onPressed: () {},
     ),
   ),
 ));
}

// Shows an app that has a button with text "Go", and clicking this button
// displays the `actionSheet` and hides the button.
//
// The `theme` will be applied to the app and determines the background.
class TestScaffoldApp extends StatefulWidget {
 const TestScaffoldApp(
     {super.key, required this.theme, required this.actionSheet});
 final CupertinoThemeData theme;
 final Widget actionSheet;

 @override
 TestScaffoldAppState createState() => TestScaffoldAppState();
}

class TestScaffoldAppState extends State<TestScaffoldApp> {
 bool _pressedButton = false;

 @override
 Widget build(BuildContext context) {
   return CupertinoApp(
     theme: widget.theme,
     home: Builder(
       builder: (BuildContext context) => CupertinoPageScaffold(
         child: Center(
           child: _pressedButton
               ? Container()
               : CupertinoButton(
                   onPressed: () {
                     setState(() {
                       _pressedButton = true;
                     });
                     showCupertinoModalPopup<void>(
                       context: context,
                       builder: (BuildContext context) {
                         return widget.actionSheet;
                       },
                     );
                   },
                   child: const Text('Go'),
                 ),
         ),
       ),
     ),
   );
 }
}

This is where I use your PR using Dark Mode:

This is running the latest master (still not correct, so maybe some other PR has broken this behavior):

The first screenshot is exactly what I observed on an Xcode native app when the dark mode toggle on the status bar is on. Did I do it wrong? Can you show me what color it should be?

Maybe this is a bug in Xcode itself, I can't reproduce it myself in Xcode right now, but this is what a native action sheet looks like in dark mode in the Contacts app.

If I use CupertinoDynamicColors.resolve for all colors in _ActionSheetButtonBackground (currently _kPressed, _kActionSheetCancelPressedColor and secondarySystemGroupedBackground Color are not resolved),
then I get these colors (matching native)

Thanks you very much! Yeah I couldn't believe it either when I saw that the colors were the same in dark mode. I'll do more research (probably by running the native app on my phone).

authors: b3nni97 dkwingsmt vashworth


text:
Traverse dependencies and dev dependencies separately

Note: not quite ready, still verifying correctness
Fixes #15080
Currently, flutter update-packages --force-upgrade will combine the dependencies and dev_dependencies sections of a pubspec before retrieving the set of transitive dependencies.  All of the resulting deps are then added to the dev dependency section.
This behavior is not quite correct, as documented in #14992.  The transitive dependencies of the package direct dependencies must be included in the dependencies section.  For example, the main flutter package (currently) has a dep on http.  We should expect the pubspec to look something like this:
dependencies:
  http: 0.11.3+16
  ...
  async: 2.0.6 # TRANSITIVE DEPENDENCY
  charcode: 1.1.1 # TRANSITIVE DEPENDENCY
  http_parser: 3.1.1 # TRANSITIVE DEPENDENCY
  path: 1.5.1 # TRANSITIVE DEPENDENCY
  source_span: 1.4.0 # TRANSITIVE DEPENDENCY
  string_scanner: 1.0.2 # TRANSITIVE DEPENDENCY

Instead  It looks something like the following, with the transitive deps of package:http added in dev_dependencies:
dependencies:
  http: 0.11.3+16
  ...

dev_dependencies:
  async: 2.0.6 # TRANSITIVE DEPENDENCY
  charcode: 1.1.1 # TRANSITIVE DEPENDENCY
  http_parser: 3.1.1 # TRANSITIVE DEPENDENCY
  path: 1.5.1 # TRANSITIVE DEPENDENCY
  source_span: 1.4.0 # TRANSITIVE DEPENDENCY
  string_scanner: 1.0.2 # TRANSITIVE DEPENDENCY

To correct this process, I've updated the flutter update-packages command to separate the dependencies and dev_dependenices, then to do two traversals of the resulting transitive deps.  The same seen set is used between both traversals to prevent repeats, since any package in the dependencies section is implicitly a dev dependency too.  Furthermore, when determining the dependencies of a PubspecYaml, we need to distinguish between regular and dev deps too
I also ran the updated command on the flutter repos

The use of package:intl_translation seems to be adding a lot of unfortunate dependencies

While you're here, can you do me a favour and change the text "TRANSITIVE DEPENDENCY" to something like THIS LINE IS AUTOGENERATED - TO UPDATE USE "flutter update-packages --force-upgrade ? It might reduce the number of times that people try to manually update these lines.

For super duper bonus points (not at all required for this PR unless you feel motivated to do it), what you could do to REALLY stop people from hand-editing these is include a value at the bottom of each list which is some sort of hash of the values above, along with a comment saying to run the script to update it, and then add a test that opens each pubspec.yaml and verifies that the hashes match the currently listed dependencies.

This is fantastic, thanks.
I didn't check the comments that aren't mentioned in the diff, but I recommend doing one last scan through the file to make sure all the comments still make sense.

@Hixie I added an initial implementation of a simple checksum over the package names + versions, and updated the magic string.  Also addressed comment comments.

authors: Hixie jonahwilliams


text:
Mark flutter_gallery_instrumentation_test as flaky

See #18879.
Please merge for me if you're happy with this; it's getting late here so I'll be off v. soon.

Windows Cirrus failure is "Agent is not responding!", so I've restarted it.

This test doesn't seem flaky. I think we can unmark it.

You jinxed it :( Yellow 3 times in the last 6 runs.

https://flutter-dashboard.appspot.com/api/get-log?ownerKey=ahNzfmZsdXR0ZXItZGFzaGJvYXJkclgLEglDaGVja2xpc3QiOGZsdXR0ZXIvZmx1dHRlci9lZTM5NjI3MmQzMjYzZWVjNDZjOTRiYjFmYTAwY2QyY2E3MmRkMWU3DAsSBFRhc2sYgICAgICA1AgM
https://flutter-dashboard.appspot.com/api/get-log?ownerKey=ahNzfmZsdXR0ZXItZGFzaGJvYXJkclgLEglDaGVja2xpc3QiOGZsdXR0ZXIvZmx1dHRlci9hY2Y0YjZjMWFhNjMxZTVmYTYyOTliYTdlZjZkZmRmZTFmYTdkNmFiDAsSBFRhc2sYgICAgICAiAoM
https://flutter-dashboard.appspot.com/api/get-log?ownerKey=ahNzfmZsdXR0ZXItZGFzaGJvYXJkclgLEglDaGVja2xpc3QiOGZsdXR0ZXIvZmx1dHRlci81YjMwYjM5M2E4Y2Y3ZjAwOTJmMTcyNmM1YThmNzk4MzJiMGFkMGY4DAsSBFRhc2sYgICAgICAuAkM

authors: DanTup Hixie yjbanov


text:
Use mixin syntax for Flutter's super-mixins

Convert all super-mixins to the new mixin syntax. This brings new versions of the analyzer, linter, and dartdoc that support the new syntax.
@stereotype441 @JekCharlsonYu @leafpetersen

In general it is not easy to spot a class that may or may not be used as a super-mixin

@yjbanov You know that if you remove enableSuperMixins: true from analysis_options.yaml you'll get errors on anything that mixes in an old-style super-mixin right?  Assuming so, presumably the issue is things that client code might mix in but nothing in the framework mixes in?  You could check with @keertip about possibly doing a presubmit on google code with enableSuperMixins disabled which might give you better coverage.

authors: gspencergoog leafpetersen yjbanov


text:
Roll engine 6d7eb52185b1..293b3de986d4 (12 commits)

https://github.com/flutter/engine/compare/6d7eb52185b1...293b3de986d4
git log 6d7eb52185b117a3972cac4e23625f97198114d9..293b3de986d42fd67b4e69475f6dbefb7ad55bda --no-merges --oneline
293b3de98 Roll src/third_party/skia 20ebd0cb3882..348227b89430 (4 commits) (flutter/engine#7900)
6e6020d29 Eliminate .member = foo struct initialization (flutter/engine#7899)
6d8bd99af Revert "Reland PerformanceOverlayLayer golden test (#7863)" (flutter/engine#7895)
39f7066b6 Test profile and release build and unit tests (flutter/engine#7880)
abe9826a9 Add accessibility semantics support to embedder (flutter/engine#7891)
ce7016e1f Roll src/third_party/skia e471c05f92e8..20ebd0cb3882 (4 commits) (flutter/engine#7894)
684c9394c Respect the custom GL proc table when creating the resource context on the IO thread. (flutter/engine#7893)
e11d0e96f Android embedding refactor pr5 add flutterengine impl (flutter/engine#7878)
2f4a38dbd Android embedding refactor pr3 add remaining systemchannels (flutter/engine#7892)
8427d73c8 Reland PerformanceOverlayLayer golden test (flutter/engine#7863)
61fc1786f Roll src/third_party/dart c92d5ca288..5ddd157809 (153 commits)
b0671145a Roll src/third_party/skia 7738736f9622..e471c05f92e8 (23 commits) (flutter/engine#7889)
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (amirha@google.com), and stop
the roller if necessary.

Trybots failed. These were the failed builds: https://cirrus-ci.com/task/4835952255041536

Commit queue failed; closing this roll.


text:
Roll engine 75387dbc147d..089c740841e8 (29 commits)

https://github.com/flutter/engine/compare/75387dbc147d...089c740841e8
git log 75387dbc147d1cee8164f5d61582eab8ba1e5058..089c740841e8f9f43cfbe9cd119a228da5fbe4d1 --no-merges --oneline
089c74084 Roll fuchsia/sdk/core/mac-amd64 from lCQWEeR_Ert7t_qAbMRycwrRyZC-dIprYPyPJzwPmg4C to EYnRdXFT9l-d8Qkz4zeTRXnqfV3KQzpQhoPs1r0-740C (flutter/engine#9759)
b22410ef6 Include SkParagraph headers only when the enable-skshaper flag is on (flutter/engine#9758)
2cd650d26 Minimal integration with the Skia text shaper module (flutter/engine#9556)
f775f5e4d Re-enable the Wuffs GIF decoder (flutter/engine#9466)
aca048236 Make all shell unit tests use the OpenGL rasterizer. (flutter/engine#9746)
bc57291ff Make FLEViewController's view an internal detail (flutter/engine#9741)
9776043ea Synchronize main thread and gpu thread for first render frame (flutter/engine#9506)
f600ae830 Use libc++ variant of string view and remove the FML variant. (flutter/engine#9737)
564f53f0a Revert "Improve caching limits for Skia (#9503)" (flutter/engine#9740)
b453d3c3d libtxt: fix reference counting of SkFontStyleSets held by font asset providers (flutter/engine#9561)
fa7627d17 Fix backspace crash on Chinese devices (flutter/engine#9734)
56885f79b Let pushColorFilter accept all types of ColorFilters (flutter/engine#9641)
6dccb21e6 Roll src/third_party/skia 96fdfe0fe88e..af4e7b6cf616 (1 commits) (flutter/engine#9735)
8511d9b47 Roll fuchsia/sdk/core/mac-amd64 from byM-kyxL4bemlTYNqhKUfJfZoIUrCSzS6XzsFr4n9-MC to lCQWEeR_Ert7t_qAbMRycwrRyZC-dIprYPyPJzwPmg4C (flutter/engine#9742)
b3bf0a182 Roll fuchsia/sdk/core/linux-amd64 from I2Qe1zxgckzIzMBTztvzeWYsDgcb9Fw-idSI16oIlx8C to KGmm_RIJoXS19zTm2crjM3RYpmp5Y03-fLUeVdylbTYC (flutter/engine#9743)
7e568232a Fix windows test by not attempting to open a directory as a file. (flutter/engine#9745)
6cf0d1350 Roll src/third_party/skia a3ffaabcc4f2..96fdfe0fe88e (5 commits) (flutter/engine#9731)
49a00aed8 Fix Fuchsia build. (flutter/engine#9730)
b3bb39b0b Roll src/third_party/dart 06c3d7ad3a...09fc76bc51 (flutter/engine#9728)
2284210f4 Make the license script compatible with recently changed Dart I/O stream APIs (flutter/engine#9725)
ad582b508 Rework image & texture management to use concurrent message queues. (flutter/engine#9486)
1dcd5f52b Roll src/third_party/skia 6b82cf638682..a3ffaabcc4f2 (24 commits) (flutter/engine#9726)
129979cab Revert "Roll src/third_party/dart 06c3d7ad3a..7acecda2cc (12 commits)" (flutter/engine#9724)
8020d7e43 Roll src/third_party/skia 56065d9b875f..6b82cf638682 (3 commits) (flutter/engine#9718)
e24bd7846 Roll src/third_party/dart 06c3d7ad3a..7acecda2cc (12 commits)
3d2668c35 Reland isolate group changes
802bd1518 iOS platform view opacity (flutter/engine#9667)
3b6265b74 Roll src/third_party/dart b5aeaa6796..06c3d7ad3a (44 commits)
887e05233 Refactor ColorFilter to have a native wrapper (flutter/engine#9668)
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (garyq@google.com), and stop
the roller if necessary.

Trybots failed. These were the failed builds: https://cirrus-ci.com/task/6324628232863744

Commit queue failed; closing this roll.


text:
Fid app bundle in Gradle 3.5

Description
The Android Gradle plugin 3.5.0 generates the following app bundle: app(-<flavor>)?-<build-type>.aab.
Related Issues
Fixes https://github.com/flutter/flutter/issues/38934
Tests
I added the following tests:
Unit tests in gradle_test.dart
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I signed the CLA.
[x] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[x] I updated/added relevant documentation (doc comments with ///).
[x] All existing and new tests are passing.
[x] The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
[x] I am willing to follow-up on review comments in a timely manner.

Breaking Change
Does your PR require Flutter developers to manually update their apps to accommodate your change?

[ ] Yes, this is a breaking change (Please read Handling breaking changes). Replace this with a link to the e-mail where you asked for input on this proposed change.
[x] No, this is not a breaking change.

https://codecov.io/gh/flutter/flutter/pull/39126/diff?src=pr&el=tree#diff-cGFja2FnZXMvZmx1dHRlcl90b29scy9saWIvc3JjL2FuZHJvaWQvZ3JhZGxlLmRhcnQ= doesn't seem right

So does this mean that we just need the master to be pushed to Stable to start using 3.5.0?

When can we get this update?

So if using Cloud based CI/CD tools, if we can't change to the master branch of Flutter we have to wait?

So if using Cloud based CI/CD tools, if we can't change to the master branch of Flutter we have to wait?

Not really, if youjust put the option you want to use in the Gradle, you should be ok.
However, this should be supported soon.

Hi @elmariocarlos ,
I'm not exactly an expert in Gradle but is there a quick switch param on flutter build command to set this up?

Not really, if youjust put the option you want to use in the Gradle, you should be ok.

Hi @elmariocarlos ,
I'm not exactly an expert in Gradle but is there a quick switch param on flutter build command to set this up?

Not really, if youjust put the option you want to use in the Gradle, you should be ok.

Go to your android/build.gradle file, and change the version there, for example:
dependencies {
    classpath 'com.android.tools.build:gradle:3.4.1'

authors: bangonkali blasten elmariocarlos workerbee22


text:
Roll Plugins from d7125cdb91c0 to 7b9ac6b0c20d (11 revisions)

https://github.com/flutter/plugins/compare/d7125cdb91c0...7b9ac6b0c20d
2021-03-20 32639467+danielroek@users.noreply.github.com [quick_actions] 2/3 Quick actions federated platform interface (flutter/plugins#3735)
2021-03-19 ditman@gmail.com [ci] Run more web tests (flutter/plugins#3739)
2021-03-19 stuartmorgan@google.com Enable web integration tests in CI (flutter/plugins#3738)
2021-03-19 stuartmorgan@google.com Standardize copyright year (flutter/plugins#3737)
2021-03-19 32639467+danielroek@users.noreply.github.com Moved quickactions to a subfolder (flutter/plugins#3734)
2021-03-19 stuartmorgan@google.com [integration_test] Deprecate, and stop using in this repository (flutter/plugins#3723)
2021-03-18 stuartmorgan@google.com Standardize Copyrights: Chromium->Flutter (flutter/plugins#2996)
2021-03-18 stuartmorgan@google.com Fix cosmetic variations in copyrights and license files (flutter/plugins#3730)
2021-03-18 stuartmorgan@google.com Add an AUTHORS file to each plugin (flutter/plugins#3725)
2021-03-18 guiga741@gmail.com [google_sign_in] Adds support to send clientId as a parameter (flutter/plugins#3640)
2021-03-17 stuartmorgan@google.com Prep for alignment with Flutter analysis options (flutter/plugins#3703)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-plugins-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Commit queue failed; closing this roll.


text:
TextField should update IME when controller changes

Fixes #9246

@Hixie

authors: Hixie abarth


text:
[firebase_crashlytics] Update README code example

Seems like the API has changed but not the code example.
reportInDevMode -> enableInDevMode
Description
README change. Code example
Related Issues
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

[ ] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[ ] My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
[ ] All existing and new tests are passing.
[ ] I updated/added relevant documentation (doc comments with ///).
[ ] The analyzer (flutter analyze) does not report any problems on my PR.
[ ] I read and followed the Flutter Style Guide.
[ ] The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
[ ] I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
[ ] I updated CHANGELOG.md to add a description of the change.
[ ] I signed the CLA.
[ ] I am willing to follow-up on review comments in a timely manner.

Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?

[ ] Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
[x ] No, this is not a breaking change.

I signed it!

repo: flutter/plugins


text:
[video_player] Adding a fix for video player alignment issues on iPhone 12Pro

Description
Video player was experiencing alignment issues on iPhone12 Pro device
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[ ] My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
[ ] All existing and new tests are passing.
[ ] I updated/added relevant documentation (doc comments with ///).
[ ] The analyzer (flutter analyze) does not report any problems on my PR.
[ ] I read and followed the Flutter Style Guide.
[ ] The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
[ ] I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
[ ] I updated CHANGELOG.md to add a description of the change.
[x] I signed the CLA.
[x] I am willing to follow-up on review comments in a timely manner.

Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?

[ ] Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
[x] No, this is not a breaking change.

@googlebot I signed it!

I'm going to close the PR because the CLA is not signed. Feel free to ping me when the CLA is signed and I'll re-open the PR. Or you can open a new PR after signing the CLA.

I'm going to close the PR because the CLA is not signed. Feel free to ping me when the CLA is signed and I'll re-open the PR. Or you can open a new PR after signing the CLA.

authors: cyanglaz veljkomih


text:
Remove dependencies on 'meta'

Flutter re-exports everything from meta that we actually use, and all plugins by definition require Flutter, so there's no need to use meta instead of Flutter to access common annotations (e.g., immutable, visibleForTesting).
This removes all use of meta, as well as dependencies on the package, from all plugins.
Fixes https://github.com/flutter/flutter/issues/95658
Pre-launch Checklist

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I read the Tree Hygiene wiki page, which explains my responsibilities.
[x] I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
[x] I signed the CLA.
[x] The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
[x] I listed at least one issue that this PR fixes in the description above.
[x] I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
[x] I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
[x] I updated/added relevant documentation (doc comments with ///).
[x] I added new tests to check the change I am making, or this PR is test-exempt.
[x] All existing and new tests are passing.

We actually do have a test for this in the flutter/flutter repo, FWIW. It just reads every Dart file and checks for the banned imports.
test-exempt: code refactor with no semantic change

We actually do have a test for this in the flutter/flutter repo, FWIW. It just reads every Dart file and checks for the banned imports.

I had considered this, but presumably there could be cases where we'd want to use something from meta that Flutter doesn't happen to re-export, so an outright ban didn't seem like the right behavior. (I guess in theory we could make it a complicated check that only allowed import 'meta/meta.dart' show <things not in a list of banned items>...)

We could also just require that anything we want to use has to be re-exported from foundation. But I don't feel strongly about this either way.

I wish this could be done with:
meta:
  sdk: flutter

That way we don't have to remember the random place from which the framework reexports the meta pkg :/

That way we don't have to remember the random place from which the framework reexports the meta pkg :/

It's not really that random, it's the foundation package of the core framework. :-)

authors: Hixie ditman stuartmorgan


text:
[BUG] Error with something

Describe the bug
, if I click on the image picker home page, after a while it goes wrong
How to reproduce
I downloaded your example,
Steps to reproduce the behavior:
I downloaded your example, if I click on the image picker home page, after a while it goes wrong, see screnncast
https://www.screencast.com/t/R9DZdLBgJNg9
Expected behavior
as if it fails to load images, but it should go ahead and not go into error because if , I continue debugging then it loads everything>
Version information

Device: Samsung s22+
OS:Android 13
Package Version: wechat_assets_picker
Flutter Version:3.7.12

AlexV525
extended image package is now updated as per 3.10.0

Track with #445.


text:
connectivity_plus is incompatible with flutter_local_notifications.

System info
Platform the Issue occurs on: Both
Plugin name: connectivity_plus
Plugin version: 2.2.1
Steps to Reproduce

Add connectivity_plus 2.2.1 and flutter_local_notifications 9.0.2 to any project and try pub get

Because connectivity_plus >=2.2.1 depends on connectivity_plus_linux ^1.3.0 which depends on nm ^0.5.0, connectivity_plus >=2.2.1 requires nm ^0.5.0.
(1) So, because nm >=0.5.0 depends on dbus ^0.7.0, connectivity_plus >=2.2.1 requires dbus ^0.7.0.
Because flutter_local_notifications >=9.2.0 <10.0.0-dev.1 depends on flutter_local_notifications_linux ^0.4.1 and flutter_local_notifications >=9.1.5 <9.2.0 depends on flutter_local_notifications_linux ^0.4.0, flutter_local_notifications >=9.1.5 <10.0.0-dev.1 requires flutter_local_notifications_linux ^0.4.0.
And because flutter_local_notifications >=9.0.0 <9.1.5 depends on flutter_local_notifications_linux ^0.3.0, flutter_local_notifications >=9.0.0 <10.0.0-dev.1 requires flutter_local_notifications_linux ^0.3.0 or ^0.4.0.
And because flutter_local_notifications_linux <0.4.0 depends on dbus ^0.5.0 and flutter_local_notifications_linux >=0.4.0 depends on dbus ^0.6.0, flutter_local_notifications >=9.0.0 <10.0.0-dev.1 requires dbus ^0.5.0 or ^0.6.0.
And because connectivity_plus >=2.2.1 requires dbus ^0.7.0 (1), connectivity_plus >=2.2.1 is incompatible with flutter_local_notifications >=9.0.0 <10.0.0-dev.1.
So, because 'myappname' depends on both flutter_local_notifications ^9.0.2 and connectivity_plus ^2.2.1, version solving failed.

pub get failed (1;     So, because 'myappname' depends on both flutter_local_notifications ^9.0.2 and connectivity_plus ^2.2.1, version solving failed.)

Flutter doctor output

flutter doctor -v
[√] Flutter (Channel master, 2.11.0-0.0.pre.604, on Microsoft Windows [versÃ£o 10.0.19043.1466], locale pt-BR)
    • Flutter version 2.11.0-0.0.pre.604 at D:\DEV\flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 28e1dea69c (2 hours ago), 2022-02-17 16:24:16 -0500
    • Engine revision 01ac6cf661
    • Dart version 2.17.0 (build 2.17.0-117.0.dev)
    • DevTools version 2.10.0

[√] Android toolchain - develop for Android devices (Android SDK version 31.0.0-rc4)
    • Android SDK at C:\Users\myuser\AppData\Local\Android\sdk
    • Platform android-31, build-tools 31.0.0-rc4
    • Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java
    • Java version OpenJDK Runtime Environment (build 11.0.8+10-b944.6842174)
    • All Android licenses accepted.

[√] Chrome - develop for the web
    • Chrome at C:\Program Files (x86)\Google\Chrome\Application\chrome.exe

[X] Visual Studio - develop for Windows
    X Visual Studio not installed; this is necessary for Windows development.
      Download at https://visualstudio.microsoft.com/downloads/.
      Please install the "Desktop development with C++" workload, including all of its default components

[√] Android Studio (version 4.2)
    • Android Studio at C:\Program Files\Android\Android Studio
    • Flutter plugin can be installed from:
       https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
       https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.8+10-b944.6842174)

[√] Connected device (3 available)
    • Windows (desktop) • windows • windows-x64    • Microsoft Windows [versÃ£o 10.0.19043.1466]
    • Chrome (web)      • chrome  • web-javascript • Google Chrome 98.0.4758.102
    • Edge (web)        • edge    • web-javascript • Microsoft Edge 94.0.992.47

[√] HTTP Host Availability
    • All required HTTP hosts are available

! Doctor found issues in 1 category.

Connectivity plus 2.2.1 was updated to use latest nm dependency to be compatible with other plugins #728
Currently, looking at your logs it is flutter_local_notification isn't compatible with Connectivity plus, since uses older version of nm.

authors: dpedrinha vbuberen

license_source: bigquery


text:
Support riverpod >0.10.0, state_notifier >0.6.0

Riverpod and state_notifier got several updates (https://pub.dev/packages/riverpod/changelog, https://pub.dev/packages/state_notifier/changelog), which were mostly bug fixes. Could you please update them to the latest versions?

Sure, I will get to that as soon as I can.

@ac130kz done

license: MIT


text:
unable to merge value from key 'sharedSecret' in Secret 'pomerium/pomerium-config-secrets' into target path 'config.sharedSecret': unable to parse key: assignment to entry in nil map

I have this HelmRelease:
apiVersion: helm.toolkit.fluxcd.io/v2beta1
kind: HelmRelease
metadata:
  name: pomerium
  namespace: pomerium
  selfLink: /apis/helm.toolkit.fluxcd.io/v2beta1/namespaces/pomerium/helmreleases/pomerium
spec:
  chart:
    spec:
      chart: pomerium
      sourceRef:
        kind: HelmRepository
        name: pomerium
        namespace: gotk-system
      version: 13.0.0
  interval: 10m0s
  values:
    config:
      policy:
      - allowed_users:
        - github/stuartpb
        - s@stuartpb.com
        from: https://alertmanager.horn.horse
        to: http://kps-alertmanager.prometheus.svc.cluster.local:9093
      - allowed_users:
        - github/stuartpb
        - s@stuartpb.com
        from: https://prometheus.horn.horse
        to: http://kps-prometheus.prometheus.svc.cluster.local:9090
      - allowed_users:
        - github/stuartpb
        - s@stuartpb.com
        from: https://grafana.horn.horse
        pass_identity_headers: true
        to: http://kube-prometheus-stack-grafana.prometheus.svc.cluster.local
      - allowed_users:
        - github/stuartpb
        - s@stuartpb.com
        from: https://rook-ceph.horn.horse
        to: http://rook-ceph-mgr-dashboard.rook-ceph.svc.cluster.local:7000
      - allowed_users:
        - github/stuartpb
        - s@stuartpb.com
        from: https://kubernetes-dashboard.horn.horse
        tls_skip_verify: true
        to: https://kubernetes-dashboard.kubernetes-dashboard.svc.cluster.local
      rootDomain: horn.horse
    extraEnvFrom:
    - secretRef:
        name: hornhorse-github
    forwardAuth:
      enabled: true
      internal: true
    ingress:
      annotations:
        cert-manager.io/cluster-issuer: stuartpb-letsencrypt-staging
        ingress.kubernetes.io/force-ssl-redirect: "true"
        kubernetes.io/ingress.class: internal
        kubernetes.io/tls-acme: "true"
        nginx.ingress.kubernetes.io/backend-protocol: HTTPS
      secret:
        name: pomerium-hornhorse-cert
    nodeSelector:
      kubernetes.io/arch: amd64
    redis:
      enabled: true
      image:
        repository: library/redis
      master:
        persistence:
          storageClass: throwaway
      slave:
        persistence:
          storageClass: throwaway
  valuesFrom:
  - kind: Secret
    name: pomerium-config-secrets
    targetPath: config.sharedSecret
    valuesKey: sharedSecret
  - kind: Secret
    name: pomerium-config-secrets
    targetPath: config.cookieSecret
    valuesKey: cookieSecret
status:
  conditions:
  - lastTransitionTime: "2020-10-21T11:33:39Z"
    message: 'unable to merge value from key ''sharedSecret'' in Secret ''pomerium/pomerium-config-secrets''
      into target path ''config.sharedSecret'': unable to parse key: assignment to
      entry in nil map'
    reason: InitFailed
    status: "False"
    type: Ready
  failures: 1
  helmChart: gotk-system/pomerium-pomerium
  lastAttemptedRevision: 13.0.2
  lastAttemptedValuesChecksum: 5b8d69560c6da71246c86fa2402a934632dd96e1
  lastHandledReconcileAt: "2020-10-21T04:33:31.530090319-07:00"
  lastReleaseRevision: 3
  observedGeneration: 12

And this Secret (:shushing_face:)
apiVersion: v1
data:
  cookieSecret: YW83K2tmdTBvR0RPNWFQWjQvWUQ2Y2NrR2dDbi9Sb1gyWkRwTTUyVQ==
  sharedSecret: YmJlK1BXNlBWTnd1STNYaUp1RStEUXh3eEgvVVB6ZU5QYi9WSGpTYQ==
kind: Secret
metadata:
  annotations:
    secret-generator.v1.mittwald.de/autogenerate: sharedSecret,cookieSecret
    secret-generator.v1.mittwald.de/autogenerate-generated-at: "2020-10-21T11:21:26Z"
    secret-generator.v1.mittwald.de/secure: "yes"
    secret-generator.v1.mittwald.de/type: string
  name: pomerium-config-secrets
  namespace: pomerium
  selfLink: /api/v1/namespaces/pomerium/secrets/pomerium-config-secrets
type: Opaque

As you can see, the Helm chart isn't reconciling, as every attempt to do so fails with unable to merge value from key ''sharedSecret'' in Secret ''pomerium/pomerium-config-secrets'' into target path ''config.sharedSecret'': unable to parse key: assignment to entry in nil map.
This Secret was originally created with the data fields missing (they were created by the secret-generator operator), so I thought it might be possible that it's trying to pull its values from the empty version, but I tried restarting the Helm Controller pod and it's still happening, so I've ruled that out.

This is a likely a duplicate of #113, and should have been fixed in the latest v0.1.3 release.

authors: hiddeco stuartpb

repo: fluxcd/helm-controller


text:
Make concurrent reconciliation configurable

Default for both, the ImageRepository and the ImagePolicy controllers
is 4 workers.
closes #148
Signed-off-by: Max Jonas Werner mail@makk.es

Looking good, @makkes!
One suggestion I have, for consistency's sake, I think it would make sense to define some types named ImagePolicyReconcilerOptions and respectively ImageRepositoryReconcilerOptions to hold the reconciliation specific options separately, similar to how it's done in other controllers.
Also see an example of the SetupWithManager implementation.

Looking good, @makkes!
One suggestion I have, for consistency's sake, I think it would make sense to define some types named ImagePolicyReconcilerOptions and respectively ImageRepositoryReconcilerOptions to hold the reconciliation specific options separately

Yeah, I saw these in the other controllers and was wondering why these were different. If you don't mind, I'll introduce these types in a subsequent PR to keep this focussed on the reconciliation configurability. What do you think?

@makkes it's ok to introduce the Options types in this PR.

@makkes it's ok to introduce the Options types in this PR.

Alright, I'll add a commit shortly.

@relu @stefanprodan added option types for both controllers.

PS. Can you please do the same in image-automation-controller?
sure thing

@stefanprodan https://github.com/fluxcd/image-automation-controller/pull/192

authors: makkes relu stefanprodan

repo: fluxcd/image-reflector-controller


text:
Provider removing kustomize-controller patch

Thanks for the prior help.
Implementing SOPS/AAD pod identity, I'm not sure the best way to patch the kustomize-controller so have put it in clusters/staging/flux-system/kustomization.yaml.  This did match the approach in the docs https://fluxcd.io/flux/installation/#customize-flux-manifests
Having done that I've found that rerunning the terraform provider 1.0.0-rc3 is reverting kustomization.yaml and wiping out my patch
Note: the lines matching ^*** are removals:
  # flux_bootstrap_git.this will be updated in-place
  ~ resource "flux_bootstrap_git" "this" {
        id                   = "flux-system"
      ~ repository_files     = {
          ~ "clusters/staging/flux-system/kustomization.yaml"   = <<-EOT
                apiVersion: kustomize.config.k8s.io/v1beta1
                kind: Kustomization
                resources:
                - gotk-components.yaml
                - gotk-sync.yaml
***                - patches:
***                - - path: kustomize-controller-patch.yaml
            EOT
            # (2 unchanged elements hidden)
        }
        # (11 unchanged attributes hidden)
    }

fyi...
 $ find clusters/staging/

clusters/staging/flux-system
clusters/staging/flux-system/kustomization.yaml
clusters/staging/flux-system/kustomize-controller-patch.yaml
clusters/staging/flux-system/gotk-sync.yaml
clusters/staging/flux-system/gotk-components.yaml
clusters/staging/infrastructure.yaml
clusters/staging/apps.yaml

kustomization.yaml:
apiVersion: kustomize.config.k8s.io/v1beta1
kind: Kustomization
resources:
- gotk-components.yaml
- gotk-sync.yaml
patches:
- path: kustomize-controller-patch.yaml

kustomize-controller-patch.yaml:
apiVersion: apps/v1
kind: Deployment
metadata:
  name: kustomize-controller
  namespace: flux-system
spec:
  selector:
    matchLabels:
      app: kustomize-controller
  template:
    metadata:
      labels:
        ## For aad-pod-identity
        # aadpodidbinding: ${IDENTITY_NAME} match the AzureIdentity name
        aadpodidbinding: sops-decryptor
    spec:
      containers:
      - name: manager
        ## For aad-pod-identity
        env:
        - name: AZURE_AUTH_METHOD
          value: msi

Please see how to customise Flux from Terraform https://registry.terraform.io/providers/fluxcd/flux/latest/docs/resources/bootstrap_git#customizing-flux

If your using Terraform this is the only way

For future reference...
resource "flux_bootstrap_git" "this" {
depends_on = [github_repository_deploy_key.this]
path = var.flux_cluster_dir
kustomization_override = local.kustomization_override
}
locals {
kustomization_override = <<KUST_EOF
apiVersion: kustomize.config.k8s.io/v1beta1
kind: Kustomization
resources:

gotk-components.yaml
gotk-sync.yaml
patches:
path: kustomize-controller-patch.yaml

KUST_EOF
}

authors: adeturner stefanprodan

repo: fluxcd/terraform-provider-flux


text:
🛑 Cartilla is down

In 88e686d, Cartilla (https://extranet.osam.org.ar/Consulta/cartilla) was down:

HTTP code: 502
Response time: 2130 ms

Resolved: Cartilla is back up in dad75f3 after 13 minutes.

repo: flvanney/OSAMuptime


text:
Supportting node version

Currently fly supports "node": ">= 0.11.16", but co fly are using supports"node": ">= 0.12.0". What do you think about to update supporting version to same version with co?

btw, it doesnt work on windows even with node@0.12.7

@iamstarkov Did you get it to work? #50

yep

@iamstarkov That's very impressive. Does it handle arrow functions too?

not sure

--harmony_arrow_functions should do the trick.

btw, everything in a fly can be polyfilled, why fly is not shipping already transpiled?

@iamstarkov Fly ships transpiled, as you can see by browsing dist/. The use of these flags is to allow users to write Flyfiles using both generators and arrow functions.

if fly ship itsled already transpiled, then fly should not require any specific node versions.
ability to use arrow functions and generators is in userland and should be fixed by using babel hook with file like flyfile.babel.js. If you want es6 just use babel-version of flyfile =)

you even dont need co

if fly ship itsled already transpiled, then fly should not require any specific node versions.

Fly the CLI and task runner is transpiled and does not require any version. But in order to let you write a Flyfile that uses generators we can't support < 0.11
unless...
We transpile every Flyfile we get our hands on. In that case we could support any node version. The drawback is that it will be slower even for users that are only writing ES5.

you even dont need co

We still need to use co for the co-routine functionality that it provides letting us run tasks concurrently and manipulate generators like state machines out of the box.
Just in case there could be any missunderstanding, co has nothing to do with generator support, co is a totally different library, please see some examples here.

IMHO
I think compiling build scripts on the fly is a bit out of this project's scope. Right now, fly's "selling point" over its competitors is that it fully leverages ES6. This makes fly a nice and lightweight tool for a specific purpose and a specific audience. If fly is going to try to be as universal as other build systems, such as gulp, then it will loose what makes it special.

@derhuerst So you are proposing dropping support for ES6/7 and other JavaScript variants?

@watilde See tj/co/issues/236

@derhuerst right now, fly does transpiling already.  I think this is a great feature that allows me to write flyfiles in Earl Grey (my preferred variant) or ES6/7.  This allows fly to do exactly what you want which is to "fully leverage ES6".  It doesn't do it internally, it uses js-interpret to import register functions that do the compiling for fly.
As far as ES5, the node version and flags, I think we should not compile ES5 flyfiles because it's a nice tradeoff: features -> ES6/variants, performance -> ES5.  As a new innovative tool, I think it's important that we push the envelope in terms of pushing node support forward to newer versions rather than eagerly transpiling everything just for supporting all node versions (and also losing performance for ES5 flyfiles).

@bucaran Thanks, that changed my mind!
Closing as resolved.

@derhuerst This is key

It (Fly) doesn't do it internally, it uses js-interpret to import register functions (so-called require hooks) that do the (actual) compiling...

The source is here.
Now, if you have any suggestions on how to improve this part (I know we can do better) I'd love to know. I would like to simplify this bit.

IMHO
I think compiling build scripts on the fly is a bit out of this project's scope. Right now, fly's "selling point" over its competitors is that it fully leverages ES6. This makes fly a nice and lightweight tool for a specific purpose and a specific audience. If fly is going to try to be as universal as other build systems, such as gulp, then it will loose what makes it special.

Now, let me get this straight, are you proposing to completely drop support for ES6/7 and other JavaScript variants?

No, I'm not. In fact, I'm urging you to not do this. (;
@MadcapJake put it in words I agree with:

As far as ES5, the node version and flags, I think we should not compile ES5 flyfiles because it's a nice tradeoff: features -> ES6/variants, performance -> ES5.

I agree with this too.

As far as ES5, the node version and flags, I think we should not compile ES5 flyfiles because it's a nice tradeoff: features -> ES6/variants, performance -> ES5.

0.4.0 will land support for more node versions by registering the require hook! Bonanza!!

authors: MadcapJake bucaran derhuerst iamstarkov watilde

repo: flyjs/fly

license: mit


text:
[WIP] Full Rework (v2.0.0)

This area is reserved for notes, thoughts, and a (wip) changelog.
Please feel free to comment below 🙇
Notes

with 1.4: 117 tests in ~980ms
with 2.0: 180 tests in ~350ms

Todo

[ ] add fly.target (lol) & tests
[ ] add fly.watch & tests
[ ] finalize fly.plugin API definition
[ ] define plugins using fly.plugin
[ ] bind plugins to this instance
[ ] incorporate existing fmt object into logging
[ ] consolidate / provide better fmt key names
[ ] use clean-stack for tracing?
[ ] create _github directory
[ ] move examples, contributing, etc
[ ] finalize changelog
[ ] benchmark

Changelog

Upgraded minimum Node requirement from 0.12 to 4.6 (LTS)
Rewrite with (most) ES2015 syntax
Dropped --harmony flag
Replaced tj/co with bluebird.coroutine generators

every prototype method must be yielded, for performance & consistency
every util method (fly.$) must be yielded, for performance & consistency

Replaced custom EventEmitter with built-in EventEmitter
Globs are only expanded once per task lifecycle
Rewrote all tests

added 65+ new tests!
more fine-tuning and control
far less prone to core bugs

API

Fly can be initialized anywhere programmatically
removed fly.concat and fly._.cat
removed fly.flatten
removed fly.unwrap (use fly.$.expand)
removed fly.filter (use fly.plugin)
removed fly.exec (use fly.start)
changed fly.start

acts as the base executor
resets the stored internal values (fly._)
initializes the fly instance, if not already
accepts an opts object in addition to a task name

opts may contain a src and val
removed opts.parallel (see below)

added fly.init

adds additional instance validations
alerts instance of ready status

added fly.serial

sequentially runs an array of task names
allows for opts to be shared & mutated by each chain member
interrupts & aborts chain when a member throws

added fly.parallel

run a group of tasks in parallel, completely indifferent to member order
shares opts across all members; does not cascade
is correctly yielded

prevents next sequence from running until all members have finished

changed fly.source

eagerly expands globs once per lifecycle
populates fly._.globs and fly._.files

replaced fly._.host with fly._.tasks

Utilities

every must be yielded, for performance & consistency
exposed publicly as fly.$
added expand
changed 'write'

will now handle/create its own ancestor tree (mkdir)

removed bind
removed defer
removed apply
removed diff
removed shallow-copy
removed arrayToMap
removed custom UnknownOption and UnknownInput error classes (see CLI)

CLI

added -m and --mode flag

defaults to serial
toggles the execution type for tasks

added additional cli.help content
improved cli.list output
changed -f and --file to -p and --pwd

always expected a directory anyway
still defaults to process.cwd()

wrapped cli.spawn with bluebird

must be yielded

merged UnknownOption and UnknownInput into generic CLI error handler
moved all cli-related ramp up to cli.js

stopped using child_process.spawn
dropped --harmony flag

Extras

Includes #212 , #177, #170
Closes #203

@lukeed
Please, ping me when API will be stable for 2.* release.
I work on a tool for migrating from one major version to other one for Fly.
Basically, it will have web UI where owner of project, that uses Fly, can add his repo, and then receive PRs from bot that will scan flyfile detect old api parts, etc and rewrite or suggest changes, that should be done.

@hzlmn Sounds awesome! Will do

@lukeed Hey, I'm writting backend for tool, and wondering, if you have any preferences for tech stack?
I was thinking about Python3.5 + Aiohttp and some sort of key-value storage (I pretty familiar with this stack, as used actively at work). For node.js I thought about Koa (I don't like callback nature of Express).

@hzlmn I always write backends in Elixir...or PHP if the current team/project sets that limitation. I don't actually write much Node (Fly pretty much covers it, or other small CLI utilities), but the last time I wrote a web-related Node project, it was with Feathers.js. Although, it's based on express.
Koa would be interesting, I haven't tried it. But if you wanted to keep the Koa / generator system, you could always just require tj/co or bluebird directly & wrap your callbacks.

@hzlmn API is largely complete. Only minor (internal) things may change.
Still working on examples, new docs & readme

@hzlmn Currently published with the beta flag if you want to start fiddling with it. I haven't had time to write up an "Upgrade Guide" yet, but I surely will.
npm i -D fly@beta

@lukeed thx, will start playing with it.

I just want to say thank you for

Fly can be initialized anywhere programmatically
I've been doing this programmatically for awhile now, but it is basically a copy of how the CLI instantiated a task, so the code looks pretty awful compared to what a public api will look like.

const reporter = require('fly/lib/reporter');
const spawn = require('fly/lib/cli/spawn');
const creed = require('creed');
const path = require('path');

module.exports = function() {
   creed.coroutine(spawn)(path.resolve(__dirname, '../../'))
    .then(function onSpawn(fly) {
      return reporter.call(fly)
        .emit('fly_run', { path: fly.file })
        .start(['build:dynamic'], { value: opts });
    })
};

@akkuma you're welcome, great suggestion! All of the Fly tests use this method in case you need any examples while using the beta flag.

authors: Akkuma hzlmn lukeed


text:
SchedulerSuite.TestOmniJobs: unexpected status 500

FAIL: test_scheduler.go:310: SchedulerSuite.TestOmniJobs

++ 23:50:52.930 created app cats-smash-hudson (7232ef2849d84d74b5c113796946fb2f)
++ 23:50:52.982 scaling formation to map[printer:2]
++ 23:50:53.012 waiting for job events: map[printer:map[up:2]]
++ 23:50:53.064 got job event: printer 93d2b834-52bb782faba6425a9d610f8f1daa0137 starting
++ 23:50:53.082 got job event: printer 4f7ece1a-9e5e0e44500540f78137f6966c12637f starting
++ 23:50:54.072 got job event: printer 93d2b834-52bb782faba6425a9d610f8f1daa0137 up
++ 23:50:54.342 got job event: printer 4f7ece1a-9e5e0e44500540f78137f6966c12637f up
++ 23:50:54.342 scaling formation to map[printer:3 omni:2]
++ 23:50:54.351 waiting for job events: map[printer:map[up:1] omni:map[up:6]]
++ 23:50:54.432 got job event: omni 8544f5d4-9e59f62e1fa7406883a37f7fca44fad3 starting
++ 23:50:54.462 got job event: omni 4f7ece1a-545c285b14384c1683a01defbca07433 starting
++ 23:50:54.522 got job event: omni 93d2b834-bbea4364f16a4835bcbf40953f3eefcb starting
++ 23:50:55.575 got job event: omni 8544f5d4-0c388915c5bb47248a892bb09879e619 starting
++ 23:50:55.622 got job event: omni 8544f5d4-9e59f62e1fa7406883a37f7fca44fad3 up
++ 23:50:55.642 got job event: omni 4f7ece1a-8756a65dd2d24d25b24d915d2c137494 starting
++ 23:50:55.662 got job event: omni 4f7ece1a-545c285b14384c1683a01defbca07433 up
++ 23:50:55.712 got job event: omni 93d2b834-db00735b3b214cbfa42e9da5495e1cec starting
++ 23:50:55.732 got job event: omni 93d2b834-bbea4364f16a4835bcbf40953f3eefcb up
++ 23:50:56.782 got job event: printer 8544f5d4-4e43929fb59e465283e7532080699057 starting
++ 23:50:56.812 got job event: omni 8544f5d4-0c388915c5bb47248a892bb09879e619 up
++ 23:50:56.995 got job event: omni 93d2b834-db00735b3b214cbfa42e9da5495e1cec up
++ 23:50:57.022 got job event: omni 4f7ece1a-8756a65dd2d24d25b24d915d2c137494 up
++ 23:50:57.972 got job event: printer 8544f5d4-4e43929fb59e465283e7532080699057 up
++ 23:50:57.972 scaling formation to map[printer:1 omni:1]
++ 23:50:57.988 waiting for job events: map[printer:map[down:2] omni:map[down:3]]
++ 23:50:58.022 got job event: printer 8544f5d4-4e43929fb59e465283e7532080699057 down
++ 23:50:58.102 got job event: printer 4f7ece1a-9e5e0e44500540f78137f6966c12637f down
++ 23:50:58.162 got job event: omni 8544f5d4-0c388915c5bb47248a892bb09879e619 down
++ 23:50:58.202 got job event: omni 93d2b834-db00735b3b214cbfa42e9da5495e1cec down
++ 23:50:58.264 got job event: omni 4f7ece1a-8756a65dd2d24d25b24d915d2c137494 down
++ 23:50:58.264 adding 2 hosts
++ 23:51:04.928 host added: a78dc4ac
++ 23:51:11.709 host added: 096ba1ab
++ 23:51:11.709 waiting for job events: map[omni:map[up:2]]
++ 23:51:11.709 got job event: omni a78dc4ac-447170122d0c4b22b74c914040fba747 starting
++ 23:51:11.710 got job event: omni a78dc4ac-447170122d0c4b22b74c914040fba747 up
++ 23:51:12.222 got job event: omni 096ba1ab-7f3a8d94457441fea89fd2968c2f0a52 starting
++ 23:51:13.122 got job event: omni 096ba1ab-7f3a8d94457441fea89fd2968c2f0a52 up
++ 23:51:13.122 removing 2 hosts
test_scheduler.go:370:
    ...
helper.go:206:
    t.Assert(testCluster.RemoveHost(host), c.IsNil)
... value *url.Error = &url.Error{Op:"DELETE", URL:"https://10.69.3.1:443/cluster/8ab7bf27/a78dc4ac", Err:(*errors.errorString)(0xc2086e2c80)} ("DELETE https://10.69.3.1:443/cluster/8ab7bf27/a78dc4ac: httpclient: unexpected status 500")

https://ci.flynn.io/builds/20150313234344-23cc0d7f

https://ci.flynn.io/builds/20150314000026-ebedf6ee

The error in the runner logs is:
runner.go:681: clusterAPI err in DELETE /cluster/622c146d/52f46fd6: timed out waiting for host removal

Looking in https://ci.flynn.io/builds/20150313234344-23cc0d7f, the host being removed is a78dc4ac, and from the ps faux output, flynn-host has stopped but the containers are still up. The last output from flynn-host is:
now=2015-03-13T23:51:13+0000 app=host fn=main at=sampi_disconnected err=0x42f800

So this looks related to #1177, we should consider manually killing the containers with killall .containerinit if the timeout is hit.

https://ci.flynn.io/builds/20150314014931-8761e211

authors: jvatic lmars

repo: flynn/flynn


text:
test: Use Basic Auth with cluster API

Putting the auth key in the URL gets leaked in the test logs because the run script is executed with trace on.

LGTM

authors: lmars titanous


text:
discoverd: Allow setting service leader during SetServiceMeta

This allows us to transactionally set the leader and the service meta at the same time, which is in turn used by Sirenia to prevent the metadata from getting out of sync with the leader entry.
Closes #3219

LGTM

authors: josephglanville titanous


text:
Inline input data for execution events

Signed-off-by: Katrina Rogan katrina@Katrinas-MBP.UNION.AI
TL;DR
Adds parity to the existing flow for inline event output data passing and storage.
Type

[ ] Bug Fix
[x] Feature
[ ] Plugin

Are all requirements met?

[x] Code completed
[x] Smoke tested
[x] Unit tests added
[x] Code documentation added
[x] Any pending items have an associated Issue

Complete description
Tested for

Python tasks
Dynamic nodes
Recovered nodes
Branch nodes
Map tasks

Tracking Issue
https://github.com/flyteorg/flyte/issues/3232
Follow-up issue
NA

@EngHabu updated to only send task event input for undefined plugin phases, re-tested on the same set of task and node types. Mind taking another look?

friendly ping @EngHabu @hamersaw

@EngHabu sorry one more time if you don't mind?

repo: flyteorg/flytepropeller


text:
Non-transactional migration blocks by SELECT COUNT(*) FROM pg_namespace WHERE nspname=$1

Which version and edition of Flyway are you using?
Tested on 9.3.1 and 9.3.0 but got the same results.
Which client are you using? (Command-line, Java API, Maven plugin, Gradle plugin)

gradle: 7.5.1
org.postgresql:postgresql:42.5.0
com.zaxxer:HikariCP:4.0.3

Which database are you using? (Type & version)
PostgreSQL 11.6
Which operating system are you using?

Mac os but failing also on Linux.

What did you do? (Please include the content causing the issue, any relevant configuration settings, the SQL statement(s) that failed (if any), and the command you ran)
Running migration only with non-transacional statement (mixed mode isn't set and it's not needed)
create index concurrently if not exists ...
    on ... (...)
    where (...);

What did you see instead?
Flyway uses an auto-detect non transactional migration with regular expression: - https://github.com/flyway/flyway/blob/d5ccaf3c5506ae3c910b9aace5b88869c30641cd/flyway-core/src/main/java/org/flywaydb/core/internal/database/postgresql/PostgreSQLParser.java#L102
And it seems that there is no extra configuration to execute non-transactional queries. The migration was detected correctly as non-transactional, but it freezes on finishing the migration because it waits on the client to close the migration. The migrations execution freezes and is never finished because of the blocking query described above.
SELECT
     activity.pid,
     activity.usename,
     activity.query,
     blocking.pid AS blocking_id,
     blocking.query AS blocking_query
FROM pg_stat_activity AS activity
JOIN pg_stat_activity AS blocking ON blocking.pid = ANY(pg_blocking_pids(activity.pid));

 pid | usename  |                        query                        | blocking_id |                   blocking_query
-----+----------+-----------------------------------------------------+-------------+----------------------------------------------------
  72 | sentinel | create index concurrently if not exists ...        +|          71 | SELECT COUNT(*) FROM pg_namespace WHERE nspname=$1
     |          |     on ... (...)                                   +|             |
     |          |     where (...)                                     |             |
(1 row)

Is there any option on how to successfully run a non-transactional migration with a flyway?

See this comment
In particular, you will need to set flyway.postgresql.transactional.lock=false
Closing as duplicate

authors: DoodleBobBuffPants radeklos

repo: flyway/flyway


text:
🛑 Site nxtc is down

In 618d797, Site nxtc ($SECRET_SITE_2) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Site nxtc is back up in df5f70b after 1 hour, 44 minutes.

repo: fmmaia/fmAtAllUptime


text:
Clean your mind

One cannot know a lot about a lot.

Choose wisely. Forget the unchoosen.
Clean up this repository from learning things you don't want to focus.

Keep coded stuff as history and move forward.

repo: fmoliveira/learning-book


text:
Upgrade strategy does not work if ruby-build is already installed

The nof_if clause on execute "Install ruby-build" most likely is not needed.

Guess it did work.


text:
Algo Kruskal's Algorithm Java

Here is the description of the algorithm of the Kruskal algorithm .
https://www.geeksforgeeks.org/kruskals-algorithm-simple-implementation-for-adjacency-matrix/

Want to work on this issue
yes

i wan't to do using c++

Then plss open another issue for C++

repo: fnplus/interview-techdev-guide


text:
🛑 Whatsapp is down

In a6586a9, Whatsapp (https://web.whatsapp.com) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Whatsapp is back up in 83a07c7.

repo: fnzv/status


text:
🛑 Contaboo is down

In d66c14c, Contaboo (https://contabo.com) was down:

HTTP code: 403
Response time: 17659 ms

Resolved: Contaboo is back up in 57b746c after 27 minutes.


text:
🛑 Contaboo is down

In a666635, Contaboo (https://contabo.com) was down:

HTTP code: 403
Response time: 637 ms

Resolved: Contaboo is back up in 7b442a6.


text:
Path include error on ubuntu/debian R installation + fix

I was getting a R.h not found error when installing according to the docs, and did some digging about where it was looking for R.h. interface_r/pogs/src/config.mk defines R_INC:=$(R_HOME)/include, but the debian install of R stores these files in /usr/share/R/include. Commenting out Line 7 in config.mk and installing from the package directory using devtools::install worked.

Thanks Apoorval. Thanks for raising this. I would have hoped that RHOME takes care of this, but I guess not. I'll add both of the includes to cover both cases.

authors: apoorvalal foges

repo: foges/pogs


text:
bug: init.lua in plugins directory ignored

Did you check docs and existing issues?

[X] I have read all the lazy docs
[X] I have searched the existing issues of lazy
[X] I have searched the exsiting issues of the plugin I have a problem with

Neovim version (nvim -v)
v0.9.0-dev
Operating system/version
Ubuntu 18.04
Describe the bug
Hi, i have following structure for my nvim config:
├── init.lua
├── lazy-lock.json
├── lua
│   ├── keymaps.lua
│   ├── options.lua
│   └── plugins
│       ├── cmp.lua
│       ├── hlargs.lua
│       ├── init.lua
│       ├── lsp.lua
│       ├── mason.lua
│       └── neo-tree.lua

Today i cleaned out the data/state directory (~/.local/{share,state}/nvim/lazy and lazy-lock.json and started nvim so that lazy can resetup.
It seems the init.lua in the plugins directory is ignored now, and only after i renamed the file lazy also took the configuration from this file into considerations.
Steps To Reproduce

clean out data/state directory and remove lock file
have an init.lua in lua/plugins with some plugins configs
start nvim so that lazy can resetup

the init.lua in the plugins dir is ignored and only after renaming to eg general.lua lazy takes this file again in considerations
Expected Behavior
init.lua in plugins dir should not be ignored
Repro
-- DO NOT change the paths and don't remove the colorscheme
local root = vim.fn.fnamemodify("./.repro", ":p")

-- set stdpaths to use .repro
for _, name in ipairs({ "config", "data", "state", "cache" }) do
  vim.env[("XDG_%s_HOME"):format(name:upper())] = root .. "/" .. name
end

-- bootstrap lazy
local lazypath = root .. "/plugins/lazy.nvim"
if not vim.loop.fs_stat(lazypath) then
  vim.fn.system({
    "git",
    "clone",
    "--filter=blob:none",
    "--single-branch",
    "https://github.com/folke/lazy.nvim.git",
    lazypath,
  })
end
vim.opt.runtimepath:prepend(lazypath)

-- install plugins
local plugins = {
  "folke/tokyonight.nvim",
  -- add any other plugins here
}
require("lazy").setup(plugins, {
  root = root .. "/plugins",
})

vim.cmd.colorscheme("tokyonight")
-- add anything else here

I just pushed a bunch of changes. Can you check if the problem persists?

Make sure to update lazy or delete the lock file, since otherwise an older version would be installed

yeah i remove lazy-lock.json in ~/.config/nvim
problem is still there, only renaming the file init.lua -> to .lua lets lazy consider the content of the file

I can't reproduce this unfortunately.
What does the code below show?
vim.pretty_print({require("lazy.core.cache").find_dir("plugins")})

Yeah, I think today's changes broke something: telescope no longer has a preview. (Useless bug report, I know; I'll try to narrow it down.)

Yep, reverting https://github.com/folke/lazy.nvim/commit/0bc73db503e550076c0a8effb976a778c7cf5a6a restores the old (correct) behavior.

I can reproduce it now. Will fix

02:45:15 PM msg_show  vim.pretty_print({require("lazy.core.cache").find_dir("plugins")}) core.cache").find_dir("plugins")})↴
    6 02:45:15 PM msg_show  vim.pretty_print({require("lazy.core.cache").find_dir("plugins")}) "core.cache").find_dir("plugins")})" [New]↴
    7 02:45:15 PM msg_show  vim.pretty_print({require("lazy.core.cache").find_dir("plugins")}) Cannot open file "core.cache").find_dir("plugins")})"↴
    8    Error  02:45:15 PM msg_show.emsg  vim.pretty_print({require("lazy.core.cache").find_dir("plugins")}) E480: No match: pretty_print({require("lazy↴

Not for me, unfortunately.

and now? Autoloading was broken

Yep, now it's back :)

good :)
@shinzu is your problem fixed as well? I think that's another issue than @clason

(oops, sorry, didn't mean to hijack!)

no worries, it did look like the same issue :)

@folke still broken for me

What does that command show? You need to add :lua  before it, so
:lua vim.pretty_print({require("lazy.core.cache").find_dir("plugins")}).
CAn you give a full listing of your nvim directory?

{ "/home/mwyrsch/.config/nvim/lua/plugins" }

  ~/.config/nvim   main !6 ?8                                                                                 21s  14:57:12
❯ tree
.
├── init.lua
├── lazy-lock.json
├── lua
│   ├── keymaps.lua
│   ├── options.lua
│   └── plugins
│       ├── cmp.lua
│       ├── general.lua
│       ├── hlargs.lua
│       ├── lsp.lua
│       ├── mason.lua
│       └── neo-tree.lua
├── minimal.lua
├── README.md
├── repro.lua
├── snippets
│   └── vscode_snippets
│       ├── CHANGELOG.md
│       ├── CODE_OF_CONDUCT.md
│       ├── images
│       │   ├── cfn-snippets-extension-example.gif
│       │   └── cfn-snippets-extension-icon.png
│       ├── LICENSE
│       ├── package.json
│       ├── README.md
│       ├── snippets
│       │   ├── condition-functions.json
│       │   ├── custom.json
│       │   ├── intrinsic-functions.json
│       │   ├── parameter-types.json
│       │   └── resource-types.json
│       └── src
│           ├── current-json-spec-hash
│           ├── feed.py
│           ├── requirements.txt
│           └── update-cfn-resource-snippets.py
├── test.cf.yaml
├── test.go
└── test.py

7 directories, 32 files

Can you check again?

I pushed something wrong. Just fixed that. sorry!

works again, thank you

for completeness, that i get now back from the lua command:
{ "/home/user/.config/nvim/lua/plugins", "/home/user/.config/nvim/lua/plugins/init.lua" }

authors: Shinzu clason folke


text:
bug: potential state pollution(?) over time could cause a difficult to tackle crashes

Did you check docs and existing issues?

[X] I have read all the lazy.nvim docs
[X] I have searched the existing issues of lazy.nvim
[X] I have searched the exsiting issues of plugins related to this issue

Neovim version (nvim -v)
0.8.2
Operating system/version
MacOS 13.1
Describe the bug
It's hard to prove but I had a strange case of Neovim crashing when I press tab to cycle nvim-cmp.
My configuration here have been working fine until today.
Today all of sudden, when I tab to cycle the suggestions from nvim-cmp, Neovim crashed with messages like the one from this one.
nvim(15010,0x1064395c0) malloc: *** error for object 0x500007f8cfdd81e8: pointer being freed was not allocated
nvim(15010,0x1064395c0) malloc: *** set a breakpoint in malloc_error_break to debug

I did checkout Neovim's issues as well as related plugins issue and I couldn't connect the dots as there was no report that guide me to the issue. I also tried multiple things to pinpoint including running Neovim in different terminals and etc. and nothing was successful (spend some hours here).
I also tried to restore and upgrade and downgrade plugins and it was not successful either.
It was very difficult to reason about what might have gone wrong. And finally I had an idea of trying "from scratch". So I deleted the path that lazy.nvim uses, ~/.local/share/nvim/lazy. And lazy.nvim picked up this manual clean up automatically when I opened Neovim again and installed all the plugins back. Voilà! No more crashses. (btw clean from lazy.nvim didn't help, hence the manual clean up)
This experience made me believe that using lazy.nvim with various usages of restore and update over time might make some sort of state gets "tangled". Of course I don't know enough on internals, so I can't say for sure and it's just a hunch at this point.

A Side Note
I almost always get this kind of error when I do update or restore (and I just retrying until it eventually succeed (usually after around 3-5 times) and wonder if this have anything to do with this issue. (my git version is 2.39.0)

(plugins that fails are different everytime)
Also wonder why this happens too.

I also understand this issue might be really tricky to tackle, so main purpose of reporting this is not much about appealing to get a fix but just wanted to share this here so anyone experience a similar issue can be aware of the workaround and try what I did if they would like. So feel free to close this issue if there is no clear clue on what might be wrong and what can be done to it.
Steps To Reproduce
Do these things multiple times over time

Restore
Update

And

wait for mysterious crash to happen (at one point)
with same exact dotfiles, do the clean install of plugins
see if the crash happens again

I am aware it's not the one of the best reproducible steps but that's all I got for now.
Expected Behavior
restore and update doesn't influence how plugins work.
Repro
(I don't think I can provide this as this is not about the config itself but let me know if you would still like one)

Those failing git process are probably caused because you don't have enough memory. Check :h uv.spawn()
Try setting config.concurrency and config.checker.concurrency to a low number (like 10)
If your system is low on memory then that can obviously also make Neovim unstable and cause all sorts of weird errors.
Next time, you should try getting a full stacktrace, since those two lines you posted are not enough to see what's going wrong. Also check on how to get an ASAN report from the Neovim Wiki.
Either way, segfaults etc are almost always caused by bugs in Neovim (or probably not enough memory in this case).
Closing this for now, but feel free to post a new issue if the issue would persist and you can get a full stacktract

@folke Thanks for all the information! These will be helpful for me to report better next time for similar thing if I ever face them again!
Also just set those values for concurrency and it seems to work fine!
Settled with following for now
{
  concurrency = 32,
  checker = {
    enabled = true,
    concurrency = 8,
    frequency = 3600 * 24 * 7,
  }
}

authors: folke ryuheechul


text:
No errors shown in list

I installed lsp-trouble.nvim with Vim-Plug
nvim version: 0.5 nightly
I use your tokyonight colorscheme
I created a file to test the LspTrouble.
Then I used :LspTroubleOpen

The list is just empty even though, there are errors

Are these errors diagnostics from the builtin lsp client? Or is that something like ALE?

I have ALE
Should I deactivate it?

That;s not it, but I wonder if those errors you are seeing are coming from ALE and are not lsp diagnostics.

so should I try deactivating it?

To make sure they are from lsp, do;
:lua vim.lsp.diagnostic.set_loclist()

That should show those errors in your quicklist

Now it looks different but still no errors shown

That means that those errors are not coming from LSP.
Closing this as it's an issue with your lsp setup. Nothing to do with trouble.
Please follow the guide at https://github.com/neovim/nvim-lspconfig to get it working

https://www.reddit.com/r/neovim/comments/n3rary/trouble_just_pushed_a_big_update_with_support_for/
is this still a problem?

With ALE you can push your errors to the quickfix and/or loclist, so try one of the commands below:

LspTrouble quickfix
LspTrouble loclist

That should work, although I haven't tested it specifically with ALE :)


text:
feature: use lua-language-server's builtin luv meta library

Did you check the docs?

[X] I have read all the neodev.nvim docs

Is your feature request related to a problem? Please describe.
Hey!
So I've noticed that luv has been added to lua-language-server's builtin meta libraries since 3 months ago..
And so it would be nice to simply replace the luv metadata from neodev with lua-language-server's and have much more complete luv information :)
Describe the solution you'd like

Add "${3rd}/luv/library" to workspace.library
Annotate vim.loop with @type uv

Describe alternatives you've considered
Stay as is.
Additional context
According to this test:
https://github.com/neovim/neovim/tree/master/test/functional/lua/loop_spec.lua#L154
vim.loop isn't modified from luv so there shouldn't be any clashes.
Potential caveat
If a user updates their lua-language-server version but not Neovim, there could be a slight desync in information.

Awesome, didn't know that!
Just updated the code. Types will be re-generated in a bit