text:
Support for Tiled Resources in D3D12

Description
I understand this might be a big ask, but I was wondering if there were any plans to support tiled resources in D3D12? We've never really had renderdoc support in this engine and I was trying to get it to work, tiled resources is a core feature so nothing we can really disable. It fails to report support for TILED_RESOURCES and even if I let it run, it fails in the call to CreateReservedResource.
Thanks!
Environment

RenderDoc version: 1.12
Operating System: Windows 10
Graphics API: D3D12

That commit adds support for capturing and replaying sparse resources on D3D12. It's only lightly tested since I couldn't really get a hold of many non-trivial sparse resource samples (on any API), possibly because I think IHVs recommend against using them so it's a rarely used feature. Especially on D3D12 this may be an issue since the D3D12 API for sparse resources is... awful.
One thing to note: the memory overhead for capturing such resources is proportional to their total virtual size not how much physical memory is currently mapped. This isn't a problem if you're using sparse resources to defrag/remap and they're mostly always bound anyway, but it may be if you are reserving a lot more memory than is available on the GPU or system.

@baldurk you are a total machine. I was not expecting this at all, I was eager to try it out, booted up our game and hey presto it loaded and ran! I could also take a capture but during replay renderdoc crashes, accessing a null list in d3d12_initstate.cpp
// transition to copy dest
if(!barriers.empty())
  list->ResourceBarrier((UINT)barriers.size(), &barriers[0]);

This is the callstack
renderdoc.dll!D3D12ResourceManager::Apply_InitialState(ID3D12DeviceChild * live, const D3D12InitialContents & data) Line 1181	C++
renderdoc.dll!ResourceManager::ApplyInitialContents() Line 1351	C++
renderdoc.dll!WrappedID3D12Device::ApplyInitialContents() Line 1291	C++
renderdoc.dll!WrappedID3D12Device::ReadLogInitialisation(RDCFile * rdc, bool storeStructuredBuffers) Line 3837	C++
renderdoc.dll!ReplayController::PostCreateInit(IReplayDriver * device, RDCFile * rdc) Line 2042	C++
renderdoc.dll!ReplayController::CreateDevice(RDCFile * rdc, const ReplayOptions & opts) Line 2009	C++
renderdoc.dll!CaptureFile::OpenCapture(const ReplayOptions & opts, std::function<void __cdecl(float)> progress) Line 364	C++
qrenderdoc.exe!ReplayManager::run(int proxyRenderer, const QString & capturefile, const ReplayOptions & opts, std::function<void __cdecl(float)> progress) Line 450	C++
If that's not enough, I can try to move the necessary strings to get a capture to you when I'm back at work on Monday. Seriously thank you so much for the effort, it's quite game-changing.

You're lucky that I had already implemented sparse resources for vulkan and was already planning on rolling in D3D12 too at the same time :smile: .
I'm not surprised that there are bugs but please open it as a new issue, I don't want this to become a mega-issue for every tiled resource bug.
For that one it sounds like you hit a device removed earlier which is why the list is NULL, you could double check in the diagnostic log. Yes I'll definitely need either a repro case or a lot more information so that I can tell what's wrong/repro it locally in isolation - e.g. you could run with debug layers enabled to see if it points out any problems.

Of course, I will do. I'll get more details tomorrow and open a new issue. Thanks!

authors: baldurk redorav

repo: baldurk/renderdoc


text:
Send value from UI to Server

First, I have to say I'm a real noob in Rust
I want to send additional value to my Linux board when clicking the submit button.
So, I added input form in index.html easily but I wonder how to send it to the board
Actually, my board will do something with the delivered value after connecting with WiFi
Could you please help me about that?
Plus, how can I build the source?
Fortunately, I know how to use Docker
My Linux board's architecture is ARM 64, and the OS is Debian 9

We have an example of doing that through Python: https://github.com/balena-io-playground/wifi-connect-api/

Going to add some documentation now at the README of that repo.

I added additional information to the README. Please let me know if you have any questions.

@majorz
Thank you so much! I'll try

@majorz
I've tried several times but it doesn't work
It seems working fine but my phones and laptop could not find the AP(WiFi-connect)

Serving Flask app "web-app" (lazy loading)
Environment: production
WARNING: Do not use the development server in a production environment.
Use a production WSGI server instead.
Debug mode: off
Running on http://0.0.0.0:80/ (Press CTRL+C to quit)

I did docker build/run as below
docker build --tag wifi-connect .
docker run -p 80:80 -p 45454:45454 wifi-connect
And, I had to change some words in Dockerfile.template as below
Because, these variables cannot found
%%RESIN_MACHINE_NAME%%
%%RESIN_ARCH%%
FROM balenalib/generic-aarch64-python:3.7.2-20190327
RUN curl -Ls https://github.com/resin-io/resin-wifi-connect/releases/download/$WW
IFI_CONNECT_VERSION/wifi-connect-$WIFI_CONNECT_VERSION-linux-aarch64.tar.gz | taa
r -xvz -C /tmp/download

@theruin0000 Docker will need --cap-add=NET_ADMIN (or --privileged) and --network=host, as those are required by dnsmasq.
Additionally you will need to mount the DBus socket in Docker. I need to look up how that is done on non-balenaOS environment.
Do you actually need Docker? Probably the best way is to download wifi-connect and put it in /usr/local/sbin on the OS directly. And follow the other steps from the Dockerfile.template but apply them on the OS. What do you think?

Do you mean following Dockerfile.template step by step manually?
Okay, I'll try :)

Yes, it is only a few steps like download and copy wifi-connect, clone the repo, install Python requirements, and run the application.

@majorz
I just found it works well :)
So thanks for your help!

source: gharchive/issue

repo: balena-io/wifi-connect

license_type: permissive

license_source: github-api


text:
Update layers/meta-balena digest to c6a25b2

This PR contains the following updates:

Package
Update
Change

layers/meta-balena
digest
80ca81f -> c6a25b2

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

Can one of the admins verify this patch?

@resin-jenkins add to whitelist

@resin-jenkins ok to test

@resin-jenkins test this please

lgtm

@balena-ci I self-certify!

source: gharchive/pull-request

authors: alexgg balena-ci floion resin-jenkins

repo: balena-os/balena-fsl-arm


text:
Add negative test cases for ballerina checkpointing

Description:
Ballerina test cases only cover the positive part of ballerina checkpointing. We need to add the following.
Ballerina services without interruptible annotation so persistence should not be activated.

Checkpoint support is removed.

authors: hasithaa warunalakshitha

repo: ballerina-platform/ballerina-lang


text:
Enable the disabled test with lang-lib change

Description:
There are several test-modules have been commented out from the testng.xml. There should be more than ~5200 unit tests running but currently only ~4500 are running as of now.

There are no tests excluding due to "brokenOnLangLibChange" So we can close this issue, after removing "brokenOnLangLibChange" label

authors: SupunS hasithaa


text:
Function Documentation code action not working

Description:
Consider the following source snippet
function myFunction(record {int x; string b;} hello) {

}

After executing the add documentation code action, the following source is generated causing syntax errors.
function myFunction(# Description
                    #
                    # + x - x Parameter Description
                    # + b - b Parameter Description
                    record {int x; string b;} hello) {

}

Affected Versions:
v1.2.0-SNAPSHOT at least

This is fixed in the latest master

authors: nadeeshaan rasika


text:
Emit error for empty fork stmt

Purpose
Fixes https://github.com/ballerina-platform/ballerina-lang/issues/18025
Approach

Describe how you are implementing the solutions along with the design details.

Samples

Provide high-level details about the samples related to this feature.

Remarks

List any other known issues, related PRs, TODO items, or any other notes related to the PR.

Check List

[ ] Read the Contributing Guide
[ ] Required Balo version update
[ ] Updated Change Log
[ ] Checked Tooling Support (#)
[ ] Added necessary tests

[ ] Unit Tests
[ ] Spec Conformance Tests
[ ] Integration Tests
[ ] Ballerina By Example Tests

[ ] Increased Test Coverage
[ ] Added necessary documentation

[ ] API documentation
[ ] Module documentation in Module.md files
[ ] Ballerina By Examples

Can't we enforce this in the grammar instead?

Can't we enforce this in the grammar instead?

This is to avoid the conflict form Hasitha's PR

authors: MaryamZi rdhananjaya


text:
Fix multiple sync sends to a errored worker

Purpose

Fixes #19115
Approach

Describe how you are implementing the solutions along with the design details.

Samples

Provide high-level details about the samples related to this feature.

Remarks

List any other known issues, related PRs, TODO items, or any other notes related to the PR.

Check List

[ ] Read the Contributing Guide
[ ] Required Balo version update
[ ] Updated Change Log
[ ] Checked Tooling Support (#)
[ ] Added necessary tests

[ ] Unit Tests
[ ] Spec Conformance Tests
[ ] Integration Tests
[ ] Ballerina By Example Tests

[ ] Increased Test Coverage
[ ] Added necessary documentation

[ ] API documentation
[ ] Module documentation in Module.md files
[ ] Ballerina By Examples

Codecov Report

Merging #19321 into ballerina-1.0.x will not change coverage.
The diff coverage is n/a.

@@               Coverage Diff                @@
##           ballerina-1.0.x   #19321   +/-   ##
================================================
  Coverage            15.73%   15.73%
================================================
  Files                   47       47
  Lines                 1265     1265
  Branches               197      197
================================================
  Hits                   199      199
  Misses                1053     1053
  Partials                13       13

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b93018...bb9fa55. Read the comment docs.


text:
Update performance test results for Ballerina v1.0.x

Purpose
This PR updates the performance test results for Ballerina v1.0.1x
Check List

[x] Read the Contributing Guide
[ ] Required Balo version update
[ ] Updated Change Log
[ ] Checked Tooling Support (#)
[ ] Added necessary tests

[ ] Unit Tests
[ ] Spec Conformance Tests
[ ] Integration Tests
[ ] Ballerina By Example Tests

[ ] Increased Test Coverage
[ ] Added necessary documentation

[ ] API documentation
[ ] Module documentation in Module.md files
[ ] Ballerina By Examples

Codecov Report

Merging #19464 into ballerina-1.0.x will not change coverage.
The diff coverage is n/a.

@@               Coverage Diff                @@
##           ballerina-1.0.x   #19464   +/-   ##
================================================
  Coverage            15.73%   15.73%
================================================
  Files                   47       47
  Lines                 1265     1265
  Branches               197      197
================================================
  Hits                   199      199
  Misses                1053     1053
  Partials                13       13

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69bc949...4a2c7d3. Read the comment docs.

Latest results: https://github.com/ballerina-platform/ballerina-lang/pull/19515

authors: codecov-io ldclakmal


text:
Introduce BBE for OAuth2 inbound authentication

Purpose
This PR introduces a BBE for OAuth2 inbound authentication.
Additionally, this updates the description of the BBE related to JWT inbound auth.
Fixes #19765
Check List

[x] Read the Contributing Guide
[ ] Updated Change Log
[ ] Checked Tooling Support (#)
[ ] Added necessary tests

[ ] Unit Tests
[ ] Spec Conformance Tests
[ ] Integration Tests
[ ] Ballerina By Example Tests

[ ] Increased Test Coverage
[ ] Added necessary documentation

[ ] API documentation
[ ] Module documentation in Module.md files
[ ] Ballerina By Examples

Closing this with the duplicate https://github.com/ballerina-platform/ballerina-lang/pull/20447 created because of Travis failure here.


text:
Fix type cast code action for numeric optional types

Purpose
$subject to suggest type cast code action as a quick fix  when the expected type is a optional numeric type.
Fixes #37465
Samples

Remarks

List any other known issues, related PRs, TODO items, or any other notes related to the PR.

Check List

[x] Read the Contributing Guide
[ ] Updated Change Log
[ ] Checked Tooling Support (#)
[x] Added necessary tests

[x] Unit Tests
[ ] Spec Conformance Tests
[ ] Integration Tests
[ ] Ballerina By Example Tests

[x] Increased Test Coverage
[ ] Added necessary documentation

[ ] API documentation
[ ] Module documentation in Module.md files
[ ] Ballerina By Examples

Changes look good. BTW, do we need to handle cases like,
function test(int|1.0 num) { // or test(int|decimal num)
    float? num2 = num;
}

Yes we should cover this. +1

Created https://github.com/ballerina-platform/ballerina-lang/pull/38285 for master. Closing as not mandatory for 2.x


text:
Tooling check for Random module

Description:
$Subject

Tested the tooling support in VS code against SL Beta4 RC3. Everything is rendered properly.


text:
Improve dependency graph generator

$subject since it is recommended to only use platform level URL to identify packages repositories. Because of this, we cannot identify dependencies based on the repository URL.
The script is improved to parse the gradle.properties file to identify the version key of each modules' dependencies.
Default version_key is stdlib + Capitalised artifact Name + Version
This can be overridden in the modules.json.
Improvement because of https://github.com/ballerina-platform/ballerina-release/issues/547

We should ask the repo owners to clean up the gradle.properties file after this. I think there are places where gradle.properties file has versions that aren't used in the build, and some of the gradle.properties files may not follow the naming convention too. (Especially we have to check the cases like OAuth2).

We should ask the repo owners to clean up the gradle.properties file after this. I think there are places where gradle.properties file has versions that aren't used in the build, and some of the gradle.properties files may not follow the naming convention too. (Especially we have to check the cases like OAuth2).

@ThisaruGuruge Tracked it here, https://github.com/ballerina-platform/ballerina-release/issues/547#issuecomment-860365346

authors: ThisaruGuruge niveathika


text:
Update Google Vision connector category

Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
This is to move the Google Cloud Vision connector to the category AI/Google as part of an effort to move all AI connectors to a new category.
One line release note:

This will move the Google Cloud Vision connector to the category AI/Google.

Type of change
Please delete options that are not relevant.

[x] This change requires a documentation update

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

authors: AathmanT CLAassistant

repo: ballerina-platform/openapi-connectors


text:
Z-wave battery sensor (from thermostat)

Home Assistant release (hass --version):
0.14
Python release (python3 --version):
3.4
Component/platform:
z-wave
Description of problem:
no sensors for my batteries of my radiator thermostats
Expected:
see the battery level of my stellaz radiator thermostats
Additional info:
6-02-29 20:10:21 ERROR (Thread-8) [homeassistant.components.light] Error while setting up platform zwave
Traceback (most recent call last):
  File "/usr/local/lib/python3.4/dist-packages/homeassistant/helpers/entity_component.py", line 97, in _setup_platform
    discovery_info)
  File "/usr/local/lib/python3.4/dist-packages/homeassistant/components/light/zwave.py", line 36, in setup_platform
    add_devices([ZwaveDimmer(value)])
  File "/usr/local/lib/python3.4/dist-packages/homeassistant/helpers/entity_component.py", line 146, in add_entities
    if self.component.add_entity(entity):
  File "/usr/local/lib/python3.4/dist-packages/homeassistant/helpers/entity_component.py", line 118, in add_entity
    entity.update_ha_state()
  File "/usr/local/lib/python3.4/dist-packages/homeassistant/helpers/entity.py", line 161, in update_ha_state
    device_attr = self.device_state_attributes
  File "/usr/local/lib/python3.4/dist-packages/homeassistant/components/zwave.py", line 323, in device_state_attributes
    battery_level = self._value.node.get_battery_level()
  File "/usr/local/lib/python3.4/dist-packages/openzwave-0.3.0b8-py3.4.egg/openzwave/command.py", line 284, in get_battery_level
    for val in self.get_battery_levels():
  File "/usr/local/lib/python3.4/dist-packages/openzwave-0.3.0b8-py3.4.egg/openzwave/command.py", line 306, in get_battery_levels
    type='Byte', readonly=True, writeonly=False)
  File "/usr/local/lib/python3.4/dist-packages/openzwave-0.3.0b8-py3.4.egg/openzwave/node.py", line 403, in get_values
    for value in self.values:
RuntimeError: dictionary changed size during iteration

This seems to be an issue with Python Open Z-Wave iterating over a dictionary that is being changed mid-iteration. Best to report it there.

authors: balloob luxus

repo: balloob/home-assistant

license_source: bigquery


text:
Support keep-alive in REST API

Home Assistant release (hass --version):
0.17.0.dev0
Python release (python3 --version):
3.4.2
Component/platform:
http
Description of problem:
I have a bunch of energy sensors of the same kind as described in this blog post: https://batilanblog.wordpress.com/2015/02/17/using-ec3k-with-raspberry-pi/
The ec3k package uses gnu-radio which unfortunately is not Python 3-compatibile so it was not possible to integrate this package into its own HA-component.
Instead I use the REST API to feed HA with events (current power, on/off state, total amount of energy used) received from the sensors by a small radio listener script.
I noticed that HA seems to drop the connecton after each POST (I'm posting using the requests library which should support keep-alive if supported by the server).
Minor suggestion: support HTTP keep-alive to let clients re-use connections (or make it a configurable option). Currently the my sensors feed HA with updates about 1/s and there really is no need to re-open a new connection for each update.
Expected:
Allow the client to re-use the connection.
Problem-relevant configuration.yaml entries and steps to reproduce:

Traceback (if applicable):

Additional info:

We're using the built in python http server. I don't think that it supports
it
On Sat, Mar 26, 2016, 10:19 Erik notifications@github.com wrote:

Home Assistant release (hass --version):
0.17.0.dev0
Python release (python3 --version):
3.4.2
Component/platform:
http
Description of problem:
I have a bunch of energy sensors of the same kind as described in this
blog post:
https://batilanblog.wordpress.com/2015/02/17/using-ec3k-with-raspberry-pi/
The ec3k package uses gnu-radio which unfortunately is not Python
3-compatibile so it was not possible to integrate this package into its own
HA-component.
Instead I use the REST API to feed HA with events (current power, on/off
state, total amount of energy used) received from the sensors by a small
radio listener script.
I noticed that HA seems to drop the connecton after each POST (I'm posting
using the requests library which should support keep-alive if supported by
the server).
Minor suggestion: support HTTP keep-alive to let clients re-use
connections (or make it a configurable option).
Expected:
Allow the client to re-use the connection.
Problem-relevant configuration.yaml entries and steps to reproduce:
Traceback (if applicable):
Additional info:
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
https://github.com/balloob/home-assistant/issues/1619

it seems to be supported: https://docs.python.org/3/library/http.server.html#http.server.BaseHTTPRequestHandler.protocol_version

protocol_version
This specifies the HTTP protocol version used in responses. If set to 'HTTP/1.1', the server will permit HTTP persistent connections; however, your server must then include an accurate Content-Length header (using send_header()) in all of its responses to clients. For backwards compatibility, the setting defaults to 'HTTP/1.0'.

I can confirm that keep-alive/connection re-use seems to work fine with the REST-API by setting protocol_version='HTTP/1.1' as in https://github.com/balloob/home-assistant/pull/1624

Closed by https://github.com/balloob/home-assistant/pull/1624 thanks!

strange, after updating to latest dev today, the REST API seems to drop HTTP connections again. I will investigate some more.

The command
curl -4Iv http://localhost:8123/ http://localhost:8123 2>&1 | grep connection

should not return Closing connection 0, instead it should reuse the connection (Re-using existing connection).

In fact it seems to reply with HTTP 1.0:
* Connected to localhost (127.0.0.1) port 8123 (#1)
> HEAD / HTTP/1.1
> User-Agent: curl/7.38.0
> Host: localhost:8123
> Accept: */*
>
* HTTP 1.0, assume close after body
< HTTP/1.0 405 Method Not Allowed
HTTP/1.0 405 Method Not Allowed
< Server: HomeAssistant/1.0 Python/3.4.2

Is this only for me or can anybody reproduce this?

Ah,
self.protocol_version = 'HTTP/1.1'

should be moved to the _handle_request method.

I guess this was what I had in my local branch when confirming https://github.com/balloob/home-assistant/pull/1624 in my comment https://github.com/balloob/home-assistant/issues/1619#issuecomment-202109737 ... sorry for that. I'll see if I can add a test case for this.

Alrighty, that's too bad. If you can open a PR to fix this, bueno

Sorry for the delay, had some vacation and got some tan.
Added PR for upgrade to HTTP/1.1.
Created two separate PR:s so the test cases can be merged first to verify that they indeed do fail, before the fix is applied.

However, HA still seems to drop the connection anyway, i.e. no keepalive
> curl -4Iv http://localhost:8123/ http://localhost:8123/ 2>&1 | grep -i connection
* Connection #0 to host localhost left intact
* Connection 0 seems to be dead!
* Closing connection 0
* Connection #1 to host localhost left intact

I can confirm this is no longer an issue with the new HTTP impementation (i.e. keepalive works as expected). Thank you!

authors: balloob molobrakos


text:
Slider Component

Slider component background width calculation is off

When giving the Slider component a max value of 20000, the calculation of the background-styles are getting calculated depending on the step-size, e.g. when the step is 5000, the percentage of the bg is 5000%.

Also, the ticks on the slider are not available. The flag hasTicks is used, but does nothing.

Working in chrome on macOs

Steps to reproduce the issue

Add a BalSlider component
Add a max value of 20.000
Add a step value of 5.000
Run page and select a value.

Additional information

Screenshots or code
Notes

https://github.com/baloise/design-system/pull/603

repo: baloise/design-system


text:
Datepicker - Months not updated when navigating backwards

Month in datepicker does not get updated
Detailed description
Currently, we are using the datepicker component for the SOB of SoBa (banking.baloise.ch). In the second page, the component can be accessed and whenever the user tries to navigate backwards, it the month will not get updated automatically. It will still display e.g. May for example instead of April.
However, the forward navigations do not have this issue and the month will get updated from May --> June for example.
This issue can be observed on the SoBa site: www.banking.baloise.ch
Steps to reproduce the issue

Go to second page
Navigate to datepicker field and open it via mouse click
Navigate backwards by clicking on "<"
It can be observed that description of the month in the header of this component does not get updated
Screenshot will display that the month is changed to April (30 days) but the month title is still May

moved issue


text:
Add the client certificates to download at https://mtls.run/pt/sidecar

At this page there are the server certificates and there is a curl example, but the curl uses a client key/cert that is not available to download.
These files can be downloaded at https://mtls.run/pt/ambassador

Hi @tiagostutz! I would like to claim this issue.

Hi @cristiangutie 👋
Awsome.! Thanks for your help.
I just assigned this to you. If you need any assistance, please let me know.

@tiagostutz I made a pull request (#12). Please review it.

authors: cristiangutie tiagostutz

repo: bancodobrasil/mtls-best-friend

license: MIT


text:
Reaplce styled-components by pure HTML tags

Currently we have some components using styled-components. Replace those by "vanilla" html tags.
Don't need to bring the style, we will tackle the style thing on another issue.

Hi there, @stokesy94 !! 👋🏻
Sure, just assigned that to you.! Nice to have you on board. 😃

Hi Tiago,
I am still working on this thanks!
Matt
Sent from Yahoo Mail for iPhone
On Wednesday, August 12, 2020, 13:43, Tiago de Oliveira Stutz notifications@github.com wrote:
Hi @stokesy94 ! I hope you are doing well..!
I'd like to know whether you are working on this issue or if we could assign it to another contributor. If you are working on this, just let me know. If not, we could assign it to another contributor and create another one for you as soon as you want to.
What do you say?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.

Hi there @stokesy94 !
This issue is reaching 30 days kinda stale and I checked that you still haven't forked the repo. I'm sorry but I have to unassign it from you because there are people looking for simple issues to contribute here and we have to keep the project pace.
If you want, I will gladly create another issue for you. ☕
Thanks!

@tiagostutz, can I take this up?

Hey @Bob160 ! How are you doing?
Sure, go ahead. Just assigned to you.! Nice!
🚀

Hey @Bob160 ! How are you doing?
Sure, go ahead. Just assigned to you.! Nice!
🚀

Hi @tiagostutz . I'm doing very well, thank you! How are you doing? Waited for you to create the new issue for me as you said but decided to choose one on my own.
Let's get to work, shall we?

I'm doing great, thanks!
Nice move.! I've been on a rush on last weeks, thats why I couldn't create the issue... but now your are good to go!
Please let me know whether you need any assistance.

Hi @tiagostutz, can you please throw more light on what this project entails?
Thanks

Hi @tiagostutz hope all is well with you?
Still waiting for your response so we can get this issue sorted.
Hope to hear back from you soon.
Cheers

Hi there @Bob160 ! I hope you are doing well.!
Sorry for the delay... so, this project is about creating a tool that offers a less "frictional" choosing experience for scenarios in which the user may have lots of options. As you know, choosing between lots of options requires a heavy cognitive load and can be frustrating, sometimes. This tool will offer for websites - such as e-commerces - and alternative for that.
The background brief of this project can be found here: https://github.com/bancodobrasil/stop-analyzing/issues/2
If you have any further doubts, please let me know.!

hey @tiagostutz, I am doing well. How are you? Yes I can take this issue, can you please explain it to me. Also, is there some place I can contact you email or something. Thanks!!

I'm doing great, thanks!
Just assigned this issue you to you.
You can reach me at Telegram or Twitter. My user is @tiagostutz.

I would like to contribute to #51. How do I get started

Hi @OluyemisiA !
You can put the project to run. Have you already followed the README instructions to try to put it to run?

@tiagostutz Yes, I followed the instructions and the project is running already

Ok. Now, you can perform the required adjustments and submit the PR. Need any assistance on that or you are good to go?

I want to know if the replacement is a specific file or all the files?

Hi all,
Please can I be removed from this email chain?
Kind Regards,
Matt
Sent from Yahoo Mail for iPhone
On Saturday, October 3, 2020, 16:24, OluyemisiA notifications@github.com wrote:
I want to know if the replacement is a specific file or all the files?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.

Hi @stokesy94 I think I'm not able to do so as it is a preference configured by you. In the e-mail you receive there's a text at the end with a link to unsubscribe. The text is: "Reply to this email directly, view it on GitHub, or unsubscribe."

@OluyemisiA all files, please. And also remove the imports and the package.json dependency.

i can take this if you want! @tiagostutz

Hi there @poleselfg !! Welcome to stop-analyzing.! Thanks for offering help.
I have just assigned it to you. If you still can tackle this issue, please go ahead.

repo: bancodobrasil/stop-analyzing-embed


text:
请问生成结束之后，如何禁用弹出资源管理器呢

生成器版本: 3.5.1

@angryLid 开启GlobalConfig的disableOpenDir配置

@angryLid 开启GlobalConfig的disableOpenDir配置

非常抱歉，文档看的有点草率了。

authors: angryLid lanjerry

repo: baomidou/generator


text:
启动的时候出现2次

当前使用版本(必填,否则不予处理)
3.4.1
该问题是如何引起的？(确定最新版也有问题再提!!!)
配置了自定义的sqlSessionFactory
public class MybatisPlusConfig {
@Autowired
private Environment env;
@Autowired
private DataSource dataSource;

@Autowired
private MybatisPlusProperties properties;

@Autowired(required = false)
private Interceptor[] interceptors;

@Autowired(required = false)
private DatabaseIdProvider databaseIdProvider;

@Autowired
private ResourceLoader resourceLoader = new DefaultResourceLoader();

/**
 * 分页插件 旧版
 */
// @Bean
// public PaginationInterceptor paginationInterceptor()
// {
// return new PaginationInterceptor();
// }

/**
 * 乐观锁插件
 *
 * @return
 */
// @Bean
// public OptimisticLockerInterceptor optimisticLockerInterceptor() {
// return new OptimisticLockerInterceptor();
// }

/**
 * 新的分页插件,一缓和二缓遵循mybatis的规则,需要设置 MybatisConfiguration#useDeprecatedExecutor = false 避免缓存出现问题
 */
@Bean
public MybatisPlusInterceptor mybatisPlusInterceptor() {
    MybatisPlusInterceptor interceptor = new MybatisPlusInterceptor();
    // 乐观锁插件
    interceptor.addInnerInterceptor(new OptimisticLockerInnerInterceptor());
    // 分页插件
    interceptor.addInnerInterceptor(new PaginationInnerInterceptor(DbType.MYSQL));
    return interceptor;
}

@Bean
public ConfigurationCustomizer configurationCustomizer() {
    return configuration -> configuration.setUseDeprecatedExecutor(false);
}

/**
 * 这里全部使用mybatis-autoconfigure 已经自动加载的资源。不手动指定 配置文件和mybatis-boot的配置文件同步
 *
 * @return
 */
@Bean(name = "sqlSessionFactory")
public MybatisSqlSessionFactoryBean mybatisSqlSessionFactoryBean() {
    log.info("初始化SqlSessionFactory");
    log.info("dynamicDataSource:{}", dataSource);
    log.info("mybatisPlus Properties:{}", this.properties);
    MybatisSqlSessionFactoryBean mybatisPlus = new MybatisSqlSessionFactoryBean();
    mybatisPlus.setDataSource(dataSource);
    mybatisPlus.setVfs(SpringBootVFS.class);
    if (StringUtils.hasText(this.properties.getConfigLocation())) {
        mybatisPlus.setConfigLocation(this.resourceLoader.getResource(this.properties.getConfigLocation()));
    }
    mybatisPlus.setConfiguration((MybatisConfiguration)properties.getConfiguration());
    if (!ObjectUtils.isEmpty(this.interceptors)) {
        mybatisPlus.setPlugins(this.interceptors);
    }
    mybatisPlus.setPlugins(new Interceptor[] { // PerformanceInterceptor(),OptimisticLockerInterceptor()
        mybatisPlusInterceptor() // 添加分页功能
    });
    MybatisConfiguration mc = new MybatisConfiguration();
    mc.setDefaultScriptingLanguage(MybatisXMLLanguageDriver.class);
    mybatisPlus.setConfiguration(mc);
    if (this.databaseIdProvider != null) {
        mybatisPlus.setDatabaseIdProvider(this.databaseIdProvider);
    }
    if (StringUtils.hasLength(this.properties.getTypeAliasesPackage())) {
        mybatisPlus.setTypeAliasesPackage(this.properties.getTypeAliasesPackage());
    }
    if (StringUtils.hasLength(this.properties.getTypeHandlersPackage())) {
        mybatisPlus.setTypeHandlersPackage(this.properties.getTypeHandlersPackage());
    }
    if (!ObjectUtils.isEmpty(this.properties.resolveMapperLocations())) {
        mybatisPlus.setMapperLocations(this.properties.resolveMapperLocations());
    }
    return mybatisPlus;
}

}
重现步骤(如果有就写完整)
报错信息
启动时出现
_ _   |_  _ |. ___ _ |    _
| | |/|)(| | |\  |)|||\
/               |
3.4.1
_ _   |_  _ |. ___ _ |    _
| | |/|)(| | |\  |)|||\
/               |
3.4.1
这个信息出现2次，同一个项目，另一个模块启动正常，分页正常，出现2次的这个模块分页出现2次 limit ，分页插件只注册了一次

自行排查

authors: jenven miemieYaho

repo: baomidou/mybatis-plus


text:
saveBatch 插入太慢   https://mp.baomidou.com/guide/crud-interface.html#insertbatchsomecolumn 访问不了!

mysql 选装一下一下这个插件 https://mp.baomidou.com/guide/crud-interface.html#insertbatchsomecolumn
其他数据库 自己拼sql
mybatis-plus 为了多数据源兼容性 是for loop  insert
Originally posted by @lltx in https://github.com/baomidou/mybatis-plus/issues/3360#issuecomment-789371126

https://baomidou.com/pages/49cc81/#insertbatchsomecolumn


text:
Don't hash the crate name in the cache key

I'd like to see the cached crate when looking at the caches for the repo, right now for example I see like 10 entries with cargo-install-{hash}

Hello! Thanks for the suggestion, I just released a new update that changes the cache key format. Since it is a major update, you'll need to manually update your workflows to use the v2 tag (changelog).

license: ISC


text:
Refactor: Implement  chainable AST / functional AST handlers

The current implementation generates the AST on every needed point instead of using the existing one if no modifications are made.
All code regarding this can be found in
lib/ast-helpers.js
lib/jsx-helpers.js
The needed change is to have a chainable contructor that allows doing the same manipulations as already in the functions but instead using a single ast as needed.
The other approach is to be functional and pass the ast around in the functions as a parameter, though that increases the amount of memory transferred around so the chain approach is preferrable.
Post the modification,
Test the application by visiting the web url : http://localhost:3000 or whatever port you have it on and then check if both the default code and the example code run (Click the View Example button ) properly without any issues.

https://github.com/barelyhuman/hen/commit/407c2479a04a3134c21af6bc00b281db68b675d4
Initial changes done,
can be optimized even more to reduce the transform time from the API for larger code snippets.

repo: barelyhuman/hen


text:
Updated instagram icon

Updated instagram svg and styles to make it scale properly as an svg background image. Closes #411.
See this update on my blog

After this update:

Thanks.

authors: domfarolino firsttopman

repo: barryclark/jekyll-now

license: mit


text:
add Tipping Point to base web directory

What changed? Why?
Notes to reviewers
How has it been tested?

🟡 Heimdall Review Status

Requirement
Status
More Info

Reviews

🟡
0/2

Denominator calculation

Show calculation

1 if user is bot
0

1 if user is external
0

From .codeflow.yml

1

Additional review requirements

Show calculation

Max
0

0

From CODEOWNERS

0

Global minimum
0

Max

1

1

1 if commit is unverified
1

Sum
2

@Ncastro878
Heya! Thanks for building on Base!
We require that defi apps linked to from base.org include a terms of service / terms and conditions page for users. It doesn't appear that this is present on the linked page. In order to continue the review, could you all please update and resubmit?

authors: Ncastro878 cb-heimdall wbnns

repo: base-org/web


text:
When your auditor table uses UUIDs as Primary Key

I'm just recording this in case it helps someone else or, after reviewing, the team tell me a better way! 😄
We use GUIDs as primary key for all tables so my Auditor record primary key starts with:
035d675a-0aa8-...

When audit records are created, the auditor_id is set as:

id
status
session_id
auditor_id

1
1
4
35

1
1
3
35

1
1
2
35

1
1
1
35

I rolled back the migration and changed the script to
t.references :auditor, null: false, type: :uuid

After re-migrating, the system successfully records my Auditor account with no, so far, further errors!

Bump. Thank you. That one had me stumped for awhile. Might be worth an add to the README.

authors: bpurinton colinbruce


text:
#170 - Calculate toast

Created toast on calculation start. But not understand delete calculation logic, if it removes automatically🤔

@Valexr we need a bot who will be checking an uncommented console.log calls at each PR :laughing:

authors: Valexr blokhin

repo: basf/bscience-gui


text:
🛑 wpsitedoctors is down

In 5e8d433, wpsitedoctors (https://wpsitedoctors.com/) was down:

HTTP code: 503
Response time: 582 ms

Resolved: wpsitedoctors is back up in 61dc09a after 31 minutes.

repo: basharatreyaz/uptimebot


text:
Update rebar.config

A things I added for my own use, you can have them if you want.

Do not want, if this is a problem put something like this inf your .gitconfig:
[url "http://github.com"]
insteadOf = ssh://git@github.com/

authors: MisaKondo Vagabond

repo: basho/lager


text:
Add HyperLogLog Data Type

Adds HLL data type.
Test with a devrel of this Riak branch: https://github.com/basho/riak_ee/tree/develop-2.2, configured with the included tools change.

The HllPrecision bucket type property needs to have support added to FetchBucketPropsCommand and StoreBucketPropsCommand

Docs can be found at: https://github.com/basho/private_basho_docs/commit/c07fb253252398b0d007952ba910bc6bf315292d

Ok, everything should be addressed now.

:+1:

authors: alexmoore lukebakken

repo: basho/riak-go-client


text:
ENH: Add out-of-sample prediction to IV

Add out-of-sample prediction to IV models

This pull request introduces 6 alerts - view on lgtm.com
new alerts:

6 for Potentially uninitialized local variable

Comment posted by lgtm.com

repo: bashtage/linearmodels

license: NCSA


text:
Add opsgenie

Add opsgenie class for know who is on call, stats of alert (UNACK, ACK,...)

For now we can't add it because, our schedule is not implement

Close for now, no information in SDK


text:
Feature/add docker image

#59
WIP

Add initial Dockerfile + .dockerignore
Add documentation for docker compose
Updated docker-compose to V2 variant docker compose
CI through docker compose (untested)
CI push docker image to dockerhub on release (untested)

Hi ! Thank you for this beautiful PR! I leave @jmsche  the review, he will know better than me.
However, I think it will merge after my #62  which should change the way adapters are handled. Small changes will certainly be expected, at the level of the documentation that you have updated for example, since we will no longer need to use the environment variables of S3, for the reasons described below.
Thank you very much for the contribution! :)

Hey @bastien70,
Thanks for the heads-up. I'll adapt the current documentation in the meantime. I currently have the PR mark as draft as I was still testing if the docker image works correctly in existing projects and with local development.

Hi ! Small question, have you or are you going to write tests to check that the docker container you are setting up works and is correctly configured?
And if I understood correctly, you modified the CI so that the tests are launched thanks to Docker, right? In which case, your PR may be merged before mine.

Hello!
To be more specific on what I was asking:
Basically we have our tests (PHPUnit) which will test the entirety of dbsaver (verify that each feature works). Similarly, how are you going to ensure that the dbsaver docker image you created deploys correctly and without issues?
The goal is that when the CI will launch the PhpUnit tests, it can also check each time that your dbsaver docker image is still compliant, that it deploys correctly, that we have not forgotten anything.
How do you handle this? Maybe you have already answered it, but I must admit that Docker is not our specialty at jmsche and myself, so we will not know if what you have coded is good (but I have the feel like you know what you're doing), or if you've written any tests to make sure the dbsaver docker image works perfectly

Hello @ToshY !
Indeed, now that the tests will be launched based on the docker image, you are right, if from the start it does not work, there is a direct problem with the docker image.
Regarding the docker-release, can you tell me more?
dbsaver docker image is created/updated on every merge? I'm not sure I understand this part correctly.
 I could of course add the phpunit, phpcs and phpstan checks as well in there?
=> It would be safer yes, even if a priori we are already well thanks to the phpunit tests launched from docker
Also, I would like to point out that I'm also not an "expert" on docker,......
=> Although you're not an expert on it, it's still great PR! Good game :)

Hey @bastien70

dbsaver docker image is created/updated on every merge? I'm not sure I understand this part correctly.

Maybe I was unclear about that, but I meant on a new release an image will be build and pushed. Currently in the docker-release.yml the following can be found:
on:
  release:
    types: [published]
...

So it would make sense that upon a new release the workflow gets triggered.

I also have a question/request regarding the Taskfile. Using the docker compose commands in the CI makes it visually kind of crowded, so is it acceptable to install Taskfile in the CI? It would reduce the run for each step to just a single task command then.
p.s. I normally use Makefiles so I don't have this dilemma :wink:

I also have a question/request regarding the Taskfile. Using the docker compose commands in the CI makes it visually kind of crowded, so is it acceptable to install Taskfile in the CI? It would reduce the run for each step to just a single task command then. p.s. I normally use Makefiles so I don't have this dilemma wink

Yeah no problem! :)

Hey @bastien70
Hope you don't mind that this is taking some time, but I'll give you an update in the meantime:

Simplified the commands in the CI by using Taskfile with the help of arduino/setup-task@v1 action.
Simplified Dockerfile.
Added a docker-compose.dev.yaml for local development. While it should be relatively easy to use, I will write documentation for it so future contributors (or you 😉) can also use it.

Todo:

Further testing of dev image, and testing of production image.

One of the things that I think is important is that we should start building building a dev image, tag it as bastien70/dbsaver:dev and push it to Dockerhub. This way we can speed up the tests in the CI, because then it only needs to pull the image. If we don't create a dev image it needs to build the image for every run, which is significantly slower compared to just downloading the image.
To do that I actually need to know if you already have a Dockerhub account? And if not, could you make one? As you stated that Docker is not your specialty, I'm not sure if you're familiar with building, tagging and pushing images? If not, the commands are relatively simply but I can guide you through it if needed (already added a command in the Taskfile for building the image).
If I'm confident enough in the current images, I'll let you know, so that we can start making the dev image before actually merging the PR.

Hey @bastien70

I have a question, what is the caddy-server for?

Well I realized that if I want to keep contributing to this application, it would be easier for me to add a relatively simple webserver, like caddy, to the docker-compose.dev.yaml. So I could just use task docker:up:dev to up the services, and after having add dbsaver.local / mail.dbsaver.local to my systems hosts file, I can easily access the application and mail client through those URLs.
So to answer your question: "For easier setup/access of the application using docker".
Even though you may not be very comfortable to docker yet, I hope you/jmsche will try it out before we actually merge the PR. I will of course update the documentation before that to try to make clear on how to use it 😉

"Will you still be there to manage docker files?"

Yeah I am still interested in contributing, that includes managing the Dockerfile. However, there shouldn't be a need to change the Dockerfile very often unless there's some (security) issues or need for additional (php) extensions or packages. I will probably still need to update the contribution guidelines to make sure that for new features that require certain extensions/packages that the Dockerfile is updated as well.

Hey @bastien70
To give an update, the last couple of days I've been busy on fixing new CI workflows, making/publishing of the images, and testing the images. To ease the CI testing, I've done this in a temporary private repository, so I can test both the workflows as the images without making a mess here. I'm at the point that everything is green in the CI, so I'm almost ready to commit the last changes back here. I will also include Minio in it then (as you mentioned it in #62 )
I hope to commit my last changes by the end of the week so it can get reviewed 👌

Hello @ToshY
Greate news! :)
Waiting for your last commit :)

Hey @bastien70,
I think it's as good as done. I will review it myself once more this weekend before I'll mark it for review for @jmsche.
I'm missing French documentation regarding the docker compose contribution part, which I just cannot write. From my perspective, it also seems double the work to document in two languages, but maybe we should save that discussion for another time.
Currently the image repository is set to bastien70/dbsaver, which means that you should create a repository called dbsaver on Dockerhub. This is under the assumption that you've made an account with the username bastien70. If you've created your account under another username, please let me know so I can update this.
After you created a Dockerhub account, could you update the repo's (action) secrets by adding DOCKER_USERNAME and DOCKER_PASSWORD? This is needed so the CI can push the new images to your dockerhub repository.
I also took the liberty to incorporate security-check and dependabot workflows. I could create a separate PR for this if you'd like, but I thought it would be just as easy to include it here as I was overhauling the CI anyway.

Hello @ToshY ! Thanks for this PR :)
I will check for docker account on Monday.
I have not yet looked in detail at the files you have modified, but suddenly you confirm that even with this PR it will be possible to launch the project locally and contribute without using docker for those who would like to do it "normally" ?
And so you confirm once again that after this PR merged, it should be very rare that we have to edit it in the future?

Hey @bastien70,

I have not yet looked in detail at the files you have modified, but suddenly you confirm that even with this PR it will be possible to launch the project locally and contribute without using docker for those who would like to do it "normally" ?

I have tried to keep the original way of working unaffected, and with that I mean, in case  you and others still want to develop locally without docker, you should still be able to so (although I haven't tested this myself).
There are however some changes to existing files which could affect local development:

The .env files are updated to use mysql:3306 instead of 127.0.0.1:3306 in the DATABASE_URL. You would need to create a .env.local and override the DATABASE_URL back to 127.0.0.1:3306 (in case you have a local MySQL instance).
The contribution task has slightly changed, but because it already required docker compose before this change, it should not affect your current local development.
The task commands for the current way of working are kept mostly the same, except for replacing symfony console by bin/console. This also should not effect your current local development.

And so you confirm once again that after this PR merged, it should be very rare that we have to edit it in the future?

Normally the Dockerfile itself shouldn't have the need for much update unless you decide to add some features that require additional php extensions, packages or patches for high/severe security updates. As an example, let's say you want to add the php redis extension for a new feature, this means the Dockerfile should simply be appended with the redis entry at  RUN install-php-extensions redis. If you need additional packages, let's say for example FFmpeg, you can add that by just appending it to apk add ffmpeg part.
Regarding security, I made the workflow docker-base.yml, which will update both base and dev images weekly, so that you'll get patches and security updates (from PHP 8.1.X alpine) for those images. When you eventually publish a new release in Github, it will run the docker-release.yml workflow, which will build and push base, dev and prod images of the application to Dockerhub.
If you have any more questions let me know 😄

Hello @ToshY !
I just created my docker account and added the secrets keys, you should be able to continue now :)
https://hub.docker.com/repository/docker/bastien70/dbsaver
Tell me if you need anything else :D

Hey @bastien70
Keen eye, I totally forgot that 🤦♂ I will start on that README.

Hey @bastien70
Something like this?

Hello @ToshY yes it seems good :)

I haven't had much time to rework the last few weeks, so I'll try to this next week. Also realized that there still may be some small issues with the Dockerfile user permissions, so still have to investigate that further. Sorry for the delay in communication.

Due to circumstances, I shall no longer continue my work on this. Sorry for any inconvenience this may have caused.


text:
BatLit community: shall we use the coviho as the BatLit community?

shall we continue to use the coviho community and rename as batlit?
here we added already the first stack of Aja's test corpus for interaction.
https://zenodo.org/communities/coviho/records?q=&l=list&p=1&s=10&sort=newest
We also added ca 140 publications with bat virus interactions @jhpoelen used for Globis
In this sense, it would make to rename the repository to BatLit.
We also need to make sure that the publcations here are not added a second time  - see deduplication issue: https://github.com/bat-literature/bat-literature.github.io/issues/6#issuecomment-2213580719

@myrmoteras we already have a batlit community registered in Zenodo (both production and sandbox). I'd favor leaving the decision up to the curator of the BatLit corpus to incorporate works like those from CoViHo. This follows curation step https://batlit.org/#feedback-workflow .

the Batlit in Zenodo has nothing in it, so we can delete it an use instead the covhio, which is also run through this bat community.
To start yet another one doesn't make sense, especially they cover the same.

I agree that the batlit community is currently empty.
However, the origin of the CoViHo is different than the batlit corpus. This difference is reflected in the different metadata (linkage to origin) as well as the associated curators.
The current curatorial workflows are documented on https://batlit.org . Which workflow would you imagine this merging of CoViHo into BatLit fall into?

Coviho had exactly the same purpose of BatLit, to create a repo for bat literature which I proposed to this bat community, and we started now to build.
We should allow others to contribute, be it adding single publications, or using other batch upload tools.  we  cannot talk openness and democratization of resources is we control building resources beyond a very basic policy what can and what can't be uploaded in the scope of building a global bat scientific publication resource.

I much agree to CoViHo and BatLit have much in common. Also, I think that allowing others to contribute is important. @ajacsherman has been working hard to make this happen with the pdfs shared with her.
And, I'd favor to keep the workflow and provenance of the items in the BatLit corpus consistent. Currently, the procedure to include/update stuff into BatLit is recorded on https://batlit.org  . What procedure would you like to use to add the CoViHo corpus to the BatLit corpus?
Perhaps this is something to best discuss as a group.

let's discuss.
I understand your point, but this is extremely restrictive to a method and has a dependency, Aja to prepare data and getting paid for it. There are other tools to make deposit, eg the Zenodo tool Lycophron as an example, that has a different concept of uploading.
From my perspective the crux is that these publications need be accessible with the respective metadata that mininmally provides the provenance, eg a DOI of the original publication or enough metadata needed to discover origin of who published where the article.
Everybody uploading the the community has to get the right to do so, which is still restrictive but at the same time get's a credit and we do not get spammed, which is unfortunately a very common phenomon in Zenodo.

Perhaps good to distinguish two concerns:

open access to publications
curating thematic collections of accessible publications

In my mind 2. involves the work of curators and involves effort (time/money) to make decisions on which works to include / exclude from the corpus.
Are you concerned about 1. (providing access to some pdf and metadata) or 2.?

I am concerened to build corpora of publications,  such as all the bats. that is 1 and 2, with an emphasis of access.

I understand you are concerned about building corpora of publications.
With BatLit, as outlined in https://batlit.org, we have citable, transferrable, and versioned corpus of publications that can be published across various platforms and storage media.
With CoViHo, we have a Zenodo community that includes records containing some metadata and pdfs. However, as far as I know, there's no way to easily transfer and cite a versioned copy of CoViHo.
In order to add CoViHo to an existing corpus, or to build CoViHo as an independent corpus, the associated (meta) data needs to be compiled, versioned, packaged and published so that it can live (and be cited) independent of Zenodo in specific and the internet in general.

closing stale issue. Please free to re-open if needed.

authors: jhpoelen myrmoteras


text:
PHP warning

PHP 8.3 Warning: foreach() argument must be of type array|object, null given in [.../site/modules/RockLoaders/RockLoaders.module.php:29]
probably if the module setup is not done yet

thx, should be fixed with the latest commit. can you check and reopen in case it needs more work?

authors: BernhardBaumrock tbba

repo: baumrock/RockLoaders


text:
Feature Idea : Keep track of books lended to friends

I usually lend books to friends and being able to keep the record of to whom I lent which book in JELU would be great !

Yes why not.
I think we need at least a boolean to flag a book as lended.
The personal notes field could be used to track to whom the book was lended and a return date or something.

This should be available in 0.32.0

authors: Ombrelin bayang

repo: bayang/jelu


text:
Best way to enable and see logs when Tomcat serves HTTP 400 error

This may just be a request for some additional detail in the documentation (which I'm happy to PR once I figure this out) on how to get logs out of jelu.
I've deployed jelu using the docker container behind Authelia and SWAG (an Nginx reverse proxy).
When I browse to jelu through SWAG I get a HTTP 400 error back from Tomcat. The jelu.log file mentioned in the docs doesn't create a new log line when the 400 is served.
Here is what the request that is arriving at jelu looks like (I used docker-http-https-echo to see what a request being passed through SWAG after Authelia authentication looks like)
{
  "path": "/",
  "headers": {
    "remote-user": "jdoe",
    "remote-groups": "admins,jelu",
    "remote-name": "John Doe",
    "remote-email": "jdoe@example.com",
    "connection": "close",
    "host": "jelu.example.com",
    "x-forwarded-for": "192.168.0.105",
    "x-forwarded-host": "jelu.example.com:443, jelu.example.com",
    "x-forwarded-method": "GET",
    "x-forwarded-proto": "https",
    "x-forwarded-server": "jelu.example.com",
    "x-forwarded-ssl": "on",
    "x-forwarded-uri": "/",
    "x-original-url": "https://jelu.example.com/",
    "x-real-ip": "192.168.1.105",
    "user-agent": "Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:109.0) Gecko/20100101 Firefox/111.0",
    "accept": "text/html,application/xhtml+xml,application/xml;q=0.9,image/avif,image/webp,*/*;q=0.8",
    "accept-language": "en-US,en;q=0.5",
    "accept-encoding": "gzip, deflate, br",
    "upgrade-insecure-requests": "1",
    "sec-fetch-dest": "document",
    "sec-fetch-mode": "navigate",
    "sec-fetch-site": "same-site",
    "sec-fetch-user": "?1",
    "cookie": "authelia_session=BWy-REDACTED-onb"
  },
  "method": "GET",
  "body": "",
  "fresh": false,
  "hostname": "jelu.example.com",
  "ip": "192.168.1.105",
  "ips": [
    "192.168.1.105"
  ],
  "protocol": "https",
  "query": {},
  "subdomains": [
    "jelu"
  ],
  "xhr": false,
  "os": {
    "hostname": "f27ee356b422"
  },
  "connection": {}
}

And my application.yml contains
jelu:
  auth:
    proxy:
      enabled: true
      adminName: "jdoe"
      header: Remote-User  # https://github.com/linuxserver/docker-swag/blob/ce32306873ded414980e60d9c46eb87464ce2f3b/root/defaults/nginx/authelia-location.conf.sample#L20
    ldap:
      enabled: false
server:
  port: 8400

I've confirmed that if I bypass SWAG and Authelia and just do a curl -i http://jelu:8400 from the SWAG container, I get a HTTP 200 and HTML from jelu, so there's something about the request after it goes through SWAG that is causing jelu to choke.
So my main question is, how do I enable additional logging to see why it is that Tomcat is returning an HTTP 400 when I browse to jelu through SWAG?

Okay, I'll try to have a look when I have some time.
Just know that your exact setup does work, since someone else already opened an issue for it : #64
A 400 http code is weird, because it has nothing to do with authentication, it is just a bad request.
In the meantime, if you want the tomcat access logs you can have a look at this  :
https://www.baeldung.com/spring-boot-embedded-tomcat-logs
Which basically is :
add server.tomcat.accesslog.enabled=true somewhere (as an env variable or in your yaml config file)
and if you really need to delve into tomcat internals, you want to add :
logging.level.org.apache.tomcat=DEBUG
logging.level.org.apache.catalina=DEBUG

again, as env vars or in your yaml.
But I think access logs should already be useful.
Also you can start by making sure you application.yml file is really picked by the jelu app in your container (ie check your volumes)

Thanks for that guidance.

Also you can start by making sure you application.yml file is really picked by the jelu app in your container (ie check your volumes)

I feel confident it is as I set the server port in application.yml and I then see in the container output from the app
2023-04-06 04:25:52.721  INFO 1 --- [main] o.s.b.w.embedded.tomcat.TomcatWebServer  : Tomcat started on port(s): 8400 (http) with context path ''

Implying that the file is being read.
I first enabled just access logs which write out to /tmp/tomcat.8400.17324305235024466065/log/access_log.*.log
Those access logs show the 400 but don't give much more information
172.21.0.4 - - [06/Apr/2023:04:36:23 +0000] "GET / HTTP/1.1" 400 435

So I then set the tomcat and catalina logging level to DEBUG. This produced additional log lines in the docker container output.
Log lines from application startup
Of the various log lines that show up on application start, these two seem potentially noteworthy, though, given that they're of log level DEBUG they may also be innocuous.
org.apache.tomcat.jni.LibraryNotFoundError: Can't load library: /app/bin/libtcnative-2.so

Full log lines
2023-04-06 04:32:03.022 DEBUG 1 --- [main] o.a.catalina.core.AprLifecycleListener   : The Apache Tomcat Native library could not be found using names [tcnative-2, libtcnative-2, tcnative-1, libtcnative-1] on the java.library.path [/usr/java/packages/lib:/usr/lib64:/lib64:/lib:/usr/lib]. The errors reported were [Can't load library: /app/bin/libtcnative-2.so, Can't load library: /app/bin/liblibtcnative-2.so, Can't load library: /app/bin/libtcnative-1.so, Can't load library: /app/bin/liblibtcnative-1.so, no tcnative-2 in java.library.path: [/usr/java/packages/lib, /usr/lib64, /lib64, /lib, /usr/lib], no libtcnative-2 in java.library.path: [/usr/java/packages/lib, /usr/lib64, /lib64, /lib, /usr/lib], no tcnative-1 in java.library.path: [/usr/java/packages/lib, /usr/lib64, /lib64, /lib, /usr/lib], no libtcnative-1 in java.library.path: [/usr/java/packages/lib, /usr/lib64, /lib64, /lib, /usr/lib]]

org.apache.tomcat.jni.LibraryNotFoundError: Can't load library: /app/bin/libtcnative-2.so, Can't load library: /app/bin/liblibtcnative-2.so, Can't load library: /app/bin/libtcnative-1.so, Can't load library: /app/bin/liblibtcnative-1.so, no tcnative-2 in java.library.path: [/usr/java/packages/lib, /usr/lib64, /lib64, /lib, /usr/lib], no libtcnative-2 in java.library.path: [/usr/java/packages/lib, /usr/lib64, /lib64, /lib, /usr/lib], no tcnative-1 in java.library.path: [/usr/java/packages/lib, /usr/lib64, /lib64, /lib, /usr/lib], no libtcnative-1 in java.library.path: [/usr/java/packages/lib, /usr/lib64, /lib64, /lib, /usr/lib]
    at org.apache.tomcat.jni.Library.<init>(Library.java:93) ~[tomcat-embed-core-9.0.69.jar:9.0.69]
    at org.apache.tomcat.jni.Library.initialize(Library.java:234) ~[tomcat-embed-core-9.0.69.jar:9.0.69]
    at org.apache.catalina.core.AprLifecycleListener.init(AprLifecycleListener.java:201) ~[tomcat-embed-core-9.0.69.jar:9.0.69]
    at org.apache.catalina.core.AprLifecycleListener.isAprAvailable(AprLifecycleListener.java:112) ~[tomcat-embed-core-9.0.69.jar:9.0.69]
    at org.springframework.boot.web.embedded.tomcat.TomcatServletWebServerFactory.getDefaultServerLifecycleListeners(TomcatServletWebServerFactory.java:182) ~[spring-boot-2.7.6.jar:2.7.6]
    at org.springframework.boot.web.embedded.tomcat.TomcatServletWebServerFactory.<init>(TomcatServletWebServerFactory.java:129) ~[spring-boot-2.7.6.jar:2.7.6]
    at org.springframework.boot.autoconfigure.web.servlet.ServletWebServerFactoryConfiguration$EmbeddedTomcat.tomcatServletWebServerFactory(ServletWebServerFactoryConfiguration.java:76) ~[spring-boot-autoconfigure-2.7.6.jar:2.7.6]
    at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[na:na]
    at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(Unknown Source) ~[na:na]
    at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source) ~[na:na]
    at java.base/java.lang.reflect.Method.invoke(Unknown Source) ~[na:na]
    at org.springframework.beans.factory.support.SimpleInstantiationStrategy.instantiate(SimpleInstantiationStrategy.java:154) ~[spring-beans-5.3.24.jar:5.3.24]
    at org.springframework.beans.factory.support.ConstructorResolver.instantiate(ConstructorResolver.java:653) ~[spring-beans-5.3.24.jar:5.3.24]
    at org.springframework.beans.factory.support.ConstructorResolver.instantiateUsingFactoryMethod(ConstructorResolver.java:638) ~[spring-beans-5.3.24.jar:5.3.24]
    at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.instantiateUsingFactoryMethod(AbstractAutowireCapableBeanFactory.java:1352) ~[spring-beans-5.3.24.jar:5.3.24]
    at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.createBeanInstance(AbstractAutowireCapableBeanFactory.java:1195) ~[spring-beans-5.3.24.jar:5.3.24]
    at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.doCreateBean(AbstractAutowireCapableBeanFactory.java:582) ~[spring-beans-5.3.24.jar:5.3.24]
    at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.createBean(AbstractAutowireCapableBeanFactory.java:542) ~[spring-beans-5.3.24.jar:5.3.24]
    at org.springframework.beans.factory.support.AbstractBeanFactory.lambda$doGetBean$0(AbstractBeanFactory.java:335) ~[spring-beans-5.3.24.jar:5.3.24]
    at org.springframework.beans.factory.support.DefaultSingletonBeanRegistry.getSingleton(DefaultSingletonBeanRegistry.java:234) ~[spring-beans-5.3.24.jar:5.3.24]
    at org.springframework.beans.factory.support.AbstractBeanFactory.doGetBean(AbstractBeanFactory.java:333) ~[spring-beans-5.3.24.jar:5.3.24]
    at org.springframework.beans.factory.support.AbstractBeanFactory.getBean(AbstractBeanFactory.java:213) ~[spring-beans-5.3.24.jar:5.3.24]
    at org.springframework.boot.web.servlet.context.ServletWebServerApplicationContext.getWebServerFactory(ServletWebServerApplicationContext.java:219) ~[spring-boot-2.7.6.jar:2.7.6]
    at org.springframework.boot.web.servlet.context.ServletWebServerApplicationContext.createWebServer(ServletWebServerApplicationContext.java:182) ~[spring-boot-2.7.6.jar:2.7.6]
    at org.springframework.boot.web.servlet.context.ServletWebServerApplicationContext.onRefresh(ServletWebServerApplicationContext.java:162) ~[spring-boot-2.7.6.jar:2.7.6]
    at org.springframework.context.support.AbstractApplicationContext.refresh(AbstractApplicationContext.java:577) ~[spring-context-5.3.24.jar:5.3.24]
    at org.springframework.boot.web.servlet.context.ServletWebServerApplicationContext.refresh(ServletWebServerApplicationContext.java:147) ~[spring-boot-2.7.6.jar:2.7.6]
    at org.springframework.boot.SpringApplication.refresh(SpringApplication.java:731) ~[spring-boot-2.7.6.jar:2.7.6]
    at org.springframework.boot.SpringApplication.refreshContext(SpringApplication.java:408) ~[spring-boot-2.7.6.jar:2.7.6]
    at org.springframework.boot.SpringApplication.run(SpringApplication.java:307) ~[spring-boot-2.7.6.jar:2.7.6]
    at org.springframework.boot.SpringApplication.run(SpringApplication.java:1303) ~[spring-boot-2.7.6.jar:2.7.6]
    at org.springframework.boot.SpringApplication.run(SpringApplication.java:1292) ~[spring-boot-2.7.6.jar:2.7.6]
    at io.github.bayang.jelu.JeluApplicationKt.main(JeluApplication.kt:20) ~[classes/:0.38.0]
    at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[na:na]
    at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(Unknown Source) ~[na:na]
    at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source) ~[na:na]
    at java.base/java.lang.reflect.Method.invoke(Unknown Source) ~[na:na]
    at org.springframework.boot.loader.MainMethodRunner.run(MainMethodRunner.java:49) ~[app/:na]
    at org.springframework.boot.loader.Launcher.launch(Launcher.java:108) ~[app/:na]
    at org.springframework.boot.loader.Launcher.launch(Launcher.java:58) ~[app/:na]
    at org.springframework.boot.loader.JarLauncher.main(JarLauncher.java:65) ~[app/:na]

2023-04-06 04:32:03.393 DEBUG 1 --- [main] o.apache.tomcat.util.compat.Jre19Compat  : Class not found so assuming code is running on a pre-Java 19 JVM

Full log lines
2023-04-06 04:32:03.393 DEBUG 1 --- [main] o.apache.tomcat.util.compat.Jre19Compat  : Class not found so assuming code is running on a pre-Java 19 JVM

java.lang.ClassNotFoundException: java.lang.WrongThreadException
  at java.base/java.net.URLClassLoader.findClass(Unknown Source) ~[na:na]
  at java.base/java.lang.ClassLoader.loadClass(Unknown Source) ~[na:na]
  at org.springframework.boot.loader.LaunchedURLClassLoader.loadClass(LaunchedURLClassLoader.java:135) ~[app/:na]
  at java.base/java.lang.ClassLoader.loadClass(Unknown Source) ~[na:na]
  at java.base/java.lang.Class.forName0(Native Method) ~[na:na]
  at java.base/java.lang.Class.forName(Unknown Source) ~[na:na]
  at org.apache.tomcat.util.compat.Jre19Compat.<clinit>(Jre19Compat.java:37) ~[tomcat-embed-core-9.0.69.jar:9.0.69]
  at org.apache.tomcat.util.compat.JreCompat.<clinit>(JreCompat.java:72) ~[tomcat-embed-core-9.0.69.jar:9.0.69]
  at org.apache.catalina.startup.Tomcat.<clinit>(Tomcat.java:1299) ~[tomcat-embed-core-9.0.69.jar:9.0.69]
  at org.springframework.boot.web.embedded.tomcat.TomcatServletWebServerFactory.getWebServer(TomcatServletWebServerFactory.java:194) ~[spring-boot-2.7.6.jar:2.7.6]
  at org.springframework.boot.web.servlet.context.ServletWebServerApplicationContext.createWebServer(ServletWebServerApplicationContext.java:184) ~[spring-boot-2.7.6.jar:2.7.6]
  at org.springframework.boot.web.servlet.context.ServletWebServerApplicationContext.onRefresh(ServletWebServerApplicationContext.java:162) ~[spring-boot-2.7.6.jar:2.7.6]
  at org.springframework.context.support.AbstractApplicationContext.refresh(AbstractApplicationContext.java:577) ~[spring-context-5.3.24.jar:5.3.24]
  at org.springframework.boot.web.servlet.context.ServletWebServerApplicationContext.refresh(ServletWebServerApplicationContext.java:147) ~[spring-boot-2.7.6.jar:2.7.6]
  at org.springframework.boot.SpringApplication.refresh(SpringApplication.java:731) ~[spring-boot-2.7.6.jar:2.7.6]
  at org.springframework.boot.SpringApplication.refreshContext(SpringApplication.java:408) ~[spring-boot-2.7.6.jar:2.7.6]
  at org.springframework.boot.SpringApplication.run(SpringApplication.java:307) ~[spring-boot-2.7.6.jar:2.7.6]
  at org.springframework.boot.SpringApplication.run(SpringApplication.java:1303) ~[spring-boot-2.7.6.jar:2.7.6]
  at org.springframework.boot.SpringApplication.run(SpringApplication.java:1292) ~[spring-boot-2.7.6.jar:2.7.6]
  at io.github.bayang.jelu.JeluApplicationKt.main(JeluApplication.kt:20) ~[classes/:0.38.0]
  at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[na:na]
  at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(Unknown Source) ~[na:na]
  at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source) ~[na:na]
  at java.base/java.lang.reflect.Method.invoke(Unknown Source) ~[na:na]
  at org.springframework.boot.loader.MainMethodRunner.run(MainMethodRunner.java:49) ~[app/:na]
  at org.springframework.boot.loader.Launcher.launch(Launcher.java:108) ~[app/:na]
  at org.springframework.boot.loader.Launcher.launch(Launcher.java:58) ~[app/:na]
  at org.springframework.boot.loader.JarLauncher.main(JarLauncher.java:65) ~[app/:na]

Log lines when the HTTP 400 is triggered
2023-04-06 04:51:27.907 DEBUG 1 --- [http-nio-8400-Acceptor] o.apache.tomcat.util.threads.LimitLatch  : Counting up[http-nio-8400-Acceptor] latch=1
2023-04-06 04:51:27.909 DEBUG 1 --- [http-nio-8400-exec-4] o.a.tomcat.util.net.SocketWrapperBase    : Socket: [org.apache.tomcat.util.net.NioEndpoint$NioSocketWrapper@4672a6ee:org.apache.tomcat.util.net.NioChannel@1ff243e5:java.nio.channels.SocketChannel[connected local=/172.21.0.5:8400 remote=/172.21.0.4:55770]], Read from buffer: [0]
2023-04-06 04:51:27.910 DEBUG 1 --- [http-nio-8400-exec-4] org.apache.tomcat.util.net.NioEndpoint   : Socket: [org.apache.tomcat.util.net.NioEndpoint$NioSocketWrapper@4672a6ee:org.apache.tomcat.util.net.NioChannel@1ff243e5:java.nio.channels.SocketChannel[connected local=/172.21.0.5:8400 remote=/172.21.0.4:55770]], Read direct from socket: [935]
2023-04-06 04:51:27.915 DEBUG 1 --- [http-nio-8400-exec-4] o.apache.tomcat.util.threads.LimitLatch  : Counting down[http-nio-8400-exec-4] latch=1
2023-04-06 04:51:27.915 DEBUG 1 --- [http-nio-8400-exec-4] org.apache.tomcat.util.net.NioEndpoint   : Calling [org.apache.tomcat.util.net.NioEndpoint@17c001a3].closeSocket([org.apache.tomcat.util.net.NioEndpoint$NioSocketWrapper@4672a6ee:org.apache.tomcat.util.net.NioChannel@1ff243e5:java.nio.channels.SocketChannel[connected local=/172.21.0.5:8400 remote=/172.21.0.4:55770]])

Which doesn't give me a sense of what the issue is.
I also disabled Authelia in SWAG and tested. Comparing what the request is that arrives in the docker container the only differences when Authelia is disabled is that these headers are now not present (which makes sense)

"remote-user": "jdoe",
"remote-groups": "admins,jelu",
"remote-name": "John Doe",
"remote-email": "jdoe@example.com",
"pragma": "no-cache",
"cache-control": "no-cache",

And this new header is present
    "if-none-match": "W/\"5c2-sOYCy+nQ9kwC/VoHDW9ESPxN6AA\"",
But, disabling Authelia doesn't solve the problem. With the request passing through SWAG without any authentication still triggers the 400 in Tomcat.
I'll try bypassing SWAG and comparing how the requests appear (direct vs proxied) to see if I can identify what it is about the request coming through SWAG that causes Tomcat to reject it.

Ok,
the tomcat debug logs are not relevant.
Can you make sure that your proxy tries to reach jelu through http and not https ?

Yes I've confirmed that the proxy (swag) is using http
        set $upstream_proto http;

I wasn't ever able to get this working and wasn't able to get any greater logging information than what I mentioned above.

that is weird, but my first guess is still one of the best options to explain why you are receiving a 400 and not another error.
Your first block of test in your first message, which is therequest received by jelu after the proxy if I understand correctly has this line :
 "protocol": "https",

can you double check please ?


text:
[Feature] Add inferAll method

What does this PR do?
Create inferAll method that infers all node's states from the network according the given and options.
Where should the reviewer start?
src/utils/inferAll.ts
What testing has been done on this PR?
yarn test
How should this be manually tested?
yarn test
Any background context you want to provide?
I've updated the Junction Tree algorithm to use only WeakMap instead of a mix of WeakMap and Map to improve the performance.
I've tested to only use Map and create a key to store cliques and potentials to avoid wrong inferring when the user mutates the network or the given (#32 ) but the performance was not so good so I create an option called force to prevent this error to happening.
I also create a script to benchmark the inferAll using WeakMap and Map approaches:
Benchmark: https://gist.github.com/nolleto/523da8f5d229cbe0e49cd279ae9091db
Results:
// With WeakMap (this PR) - https://github.com/nolleto/bayesjs/tree/infer-all-with-weak-map
// The mutation error will happen
// inferAll executed 100 times: 972.847ms
// inferAll executed 500 times: 3563.248ms
// inferAll executed 1000 times: 6863.624ms
// inferAll executed 2000 times: 13624.510ms
// inferAll executed 5000 times: 33492.657ms
// Total time: 58608.248ms

// With WeakMap and Map (current - until v0.5.0) - https://github.com/nolleto/bayesjs/tree/infer-all-with-current-algorithm
// The mutation error will happen
// inferAll executed 100 times: 987.221ms
// inferAll executed 500 times: 5654.897ms
// inferAll executed 1000 times: 11278.152ms
// inferAll executed 2000 times: 22390.635ms
// inferAll executed 5000 times: 55837.960ms
// Total time: 96266.677ms

// With WeakMap (potentials) and Map (cliques (id, cpt)) - https://github.com/nolleto/bayesjs/tree/infer-all-mapping-network-nodes
// The mutation error will NOT happen
// inferAll executed 100 times: 57444.127ms
// inferAll executed 500 times: 276823.310ms
// Too long...

What are the relevant issues?
#18 #32
Screenshots (if appropriate)
NA

:tada: This PR is included in version 0.6.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

repo: bayesjs/bayesjs


text:
Remove GCP Credentials check

What this PR does and why we need it:
This PR removes the sanity check for GOOGLE_APPLICATION_CREDENTIALS in the environment since our BazelCI Ubuntu VMs doesn't have that value set.
Does this require a change in the script's interface or the BigQuery's table structure?
No.

google.auth.exceptions.DefaultCredentialsError: Could not automatically determine credentials. Please set GOOGLE_APPLICATION_CREDENTIALS or explicitly create credentials and re-run the application. For more information, please see https://cloud.google.com/docs/authentication/getting-started

LGTM

repo: bazelbuild/bazel-bench


text:
Add protoc-gen-validate 1.0.4.bcr.1

This fixes compatibility with more recent versions of rules_python.

Hello @bazelbuild/bcr-maintainers, modules without existing maintainers (protoc-gen-validate) have been updated in this PR. Please review the changes.

@bazel-io skip_check unstable_url

@keith patching the old version until #3414 is figured out. The current version 1.0.4 on BCR is not compatible with recent rules_python version (still uses name instead of hub_name for pip dependencies).

yea, note that as of bazel 7.4.x you can use a single_module_override to patch MODULE.bazel files to avoid this kinda issue. still good to fix for everyone tho :+1:

yea, note that as of bazel 7.4.x you can use a single_module_override to patch MODULE.bazel files to avoid this kinda issue. still good to fix for everyone tho 👍

Thanks for the hint. As we are providing an SDK to our users, we are not the root module and therefore cannot use overrides.

authors: bazel-io keith mering

repo: bazelbuild/bazel-central-registry


text:
Support bash autocomplete

Since bazelisk downloads entire binaries, autocomplete scripts are not accessible. bazelisk could potentially also download the autocomplete scripts to a predetermined location to make it easier invoke.

+1, this will be excellent to have.

I suppose you can do this manually with instructions from https://docs.bazel.build/versions/master/completion.html#bash
$ bazel build //scripts:bazel-complete.bash
$ cp bazel-bin/scripts/bazel-complete.bash /etc/bash_completion.d/bazelisk

# new shell
$ bazelisk <TAB>
analyze                                                 --nodeep_execroot
analyze-profile                                         --noexoblaze
aquery                                                  --noexpand_configs_in_place
--batch                                                 --noexperimental_oom_more_eagerly
--batch_cpu_scheduling                                  --noidle_server_tasks
--blazerc=                                              --noignore_all_rc_files
..

yeah that's what i ended up doing... I was hoping something like a bundled bash completion script that bazelisk could provide, but it's not super blocking

I would love to have this myself, but currently don't have time to implement this - if someone wants to contribute a PR, I would be very happy to review it.

I'll take a stab at this when I have time over the next few days.

@sudoforge Thanks! If you could find a solution that also works with zsh completions, I'd be extra grateful 😊 (I was a long-time bash user, but since macOS Catalina switched to zsh by default, I gave it a try and stuck with it.)

I'll be looking to add completion for all shells that Bazel supports -- off the top of my head, I think that's just Bash and ZSH.

+1 would be super useful to have

FWIW this is done now for zsh on Homebrew installs of bazelisk: https://github.com/bazelbuild/homebrew-tap/pull/89

I've got it working on my mac using zsh but it's painfully slow. Are others experiencing the same?

Having done some comparisons between bazel and bazelisk using zsh completion on my mac, bazelisk is orders of magnitude slower.

Having done some comparisons between bazel and bazelisk using zsh completion on my mac, bazelisk is orders of magnitude slower.

I wonder if https://github.com/bazelbuild/bazelisk/pull/248 would improve this

I've given some thought to this and will be sending a PR out in the next few days with a proposed solution.

Any update here? I'd be glad to help if I can.

@sudoforge Is this still something you're planning to open?

I was looking at this briefly, and my assumption as to what needs to be done:

Update DownloadRelease to also fetch the auto-complete scripts
To get the auto-complete scripts, the source needs to be downloaded (e.g. https://releases.bazel.build/6.0.0/release/bazel_6.0.0.tar.gz), and for simplicity probably just extract the entire "scripts/" directory (which includes bazel-complete-header.bash and such, and other auto-completes).
Make that scripts/ sub-directory available in a deterministic place, so switching bazel versions also switches the underlying scripts

Seem reasonable to others?

authors: UebelAndre andrewring evie404 finn-ball gibfahn jin kylepl philwo rickypai rpwoodbu sudoforge

repo: bazelbuild/bazelisk


text:
Update CHANGELOG for v2024.03.26

Please let me know of any important changes that you want to make visible by adding to the Change log.

https://github.com/bazelbuild/intellij/pull/6262
https://github.com/bazelbuild/intellij/pull/6310
https://github.com/bazelbuild/intellij/pull/6030
https://github.com/bazelbuild/intellij/pull/6257

repo: bazelbuild/intellij


text:
Issue 45: add version to footer

Add version number to the footer.
Add the version number to the app context so it's automatically available in all templates.

Coverage decreased (-0.1%) to 59.595% when pulling 7e0e53303c04a86b3dbc17a18a2ecd600f4e282a on janetriley:develop into e3203599f097d0db6eb7f936eb6b8d079d4414a6 on bbengfort:develop.

@janetriley nice job! Thanks for the contribution!

authors: bbengfort coveralls janetriley

repo: bbengfort/baleen


text:
Safeguard subject property (and others) against SMTP CRLF injection attacks

It is possible to set a subject which contains newlines and custom SMTP protocol directives which directly sets the body of the email. This can be an issue when the subject comes from an external resource.
As a matter of precaution, Simple Java Mail should simply remove newline characters from all values (except for the body).
Also see:

http://www.cakesolutions.net/teamblogs/2008/05/08/email-header-injection-security
https://security.stackexchange.com/a/54100/110048
https://www.owasp.org/index.php/Testing_for_IMAP/SMTP_Injection_(OTG-INPVAL-011)
http://cwe.mitre.org/data/definitions/93.html

Released in 4.3.0.

repo: bbottema/simple-java-mail


text:
chore: correct links in issue template

Previous links was invalid

Thanks for the PR 👍

authors: bcakmakoglu tchiotludo

repo: bcakmakoglu/vue-flow


text:
[Arknights Fan TRPG] アップデート

・成功、失敗とクリティカル、エラーの優先度をルール準拠に変更。
・ヘルプメッセージの誤りを修正。
・ココフォリアのルーム変数に対応するため、役職名の後ろに0がつくと動作せず、1がつくと動作するように整備。

対応遅れてしまい申し訳ありません。
コミット整理承知いたしました。
Pull request の前にフォーク元(BcDice本体)の変更をマージして取り込んでおく処理は止めておいたほうが良いでしょうか？

こちらですが、前回の Arknights Fan TRPG の取り込みが、squash merge となっており、コミットがまとめられてます。#666 f1db21f2e26739e2e8ae8c442434f92d9b65234b
なので、手元とBCDice 本体のツリー情報に差分があり、過去のコミットがこのPRに混じっているという状況になっています。
したがって、BCDice の master から新しくブランチを切り直して、そこに今回の差分を乗せるという形が良いと思います。
こちらの方針については、Arknights Fan TRPG のコードの共同開発者の @NOBUTOKA さんにもDiscord で伝えてあります。
よろしくお願いします。

ありがとうございます。discordの方確認致しました。２度お手間をおかけする形となってしまい申し訳ありませんでした。
対応したく思いますので、少々お時間頂けますと幸いです。

repo: bcdice/BCDice


text:
Improve release notes formatting

Would it be possible to adjust the formatting of https://www.bouncycastle.org/releasenotes.html?
In my opinion it has the following two issues which make it extremely difficult to skim and navigate:

Every header is numbered
This makes it pretty difficult to tell apart the release version from the header number, e.g.:

Here you might initially think the version is "2.2.1"
All headers have the same size
Even though some headers are logically sub-headers of others, they all have the same size and you have to pay close attention to the header numbers to understand which section belongs to which version, e.g.:

This screenshot even highlights a different issue, that the header numbers are apparently manually applied and now two headers have the number "2.2.2" making it even more difficult to read.

Personally I think a formatting similar to the following one (that is, no header numbering and hierarchical headers) would be easier to understand and read:

1.72.3
Date: 2022, November 20th
Defects fixed

PGP patch release - fix for pom file in 1.72.2 jar file for JDK15to18 version..

...
1.72
Date: 2022, September 25th
Defects Fixed

There were parameter errors in XMSS^MT OIDs for XMSSMT_SHA2_40/4_256 and XMSSMT_SHA2_60/3_256. These have been fixed.
...

Additional Features and Functionality

BCJSSE: TLS 1.3 is now enabled by default where no explicit protocols ...

Seems to be obsolete with the new redesigned website now. The release notes are now under https://www.bouncycastle.org/download/bouncy-castle-java/#release-notes

repo: bcgit/bc-java


text:
Update Wally Database for Gold

Describe the task
Update the existing database storing procedures to be able to handle the new Keycloak token structure
Acceptance Criteria

[ ] Database can properly save user info from Keycloak

Additional context
How WALLY is saving things to the database is relatively unknown to me at the time of writing this other than the logic happens on the backend.  I do know the important tables relating to Keycloak having looked at it in openshift.  There is a user table and a user_map_layer table in the database.
The user_map_layer table only uses idir's for saving/looking up info; that will still exist in gold but the field in the token could be a different name so that will possibly need to be updated.
The user layer is going to require a migration as the user_uuid is no longer going to exist in the gold realm; that is what will become the GUID.  I have uploaded the files that pair the UUID to the correct user's GUID from Zorin to the Dev Chat files section, and I believe Norris has experience writing a translation table for this kind of work so he will probably be able to give more info on how to go about doing this.

This work is being done in WALLY ticket #697

authors: LolandaE jakemorr

repo: bcgov-c/wally


text:
Lock down pg_tileserv layers by role

Right now the pg_tileserv  doesn't have any authentication/authorization, it's only limited by showing/hiding the layer definitions within the arches implementation. The WMS is accessed via a proxy which could be used to limit the access of each layer by role/user.

Taking the MVP label off as this isn't relevant until we include the next user group.

repo: bcgov/BCHeritage


text:
Create payment-noplugins.yaml

Test API Gateway config generated from OpenAPI spec using gwa tool

@eyjwarren

authors: eyjwarren vyasworks

repo: bcgov/PaymentCommonComponent


text:
Content for begin/resume application page

Should support UX of application process:

who should be filling out this form
how long will it take to apply to the program
what information will be needed to complete
what happens if they lose username/password
that they can start/come back to form
dates/deadlines for completion of application
timeline on gov response to applicants
how information will be used
any legal stuff

Rachel to send FOIPPA language to Elliott/Bryan for form internal landing page
Instructions have been drafted. Need to review against this card to ensure completion.
BCeID piece needs to be send to Tim McGuire, Geomark piece needs to be sent to Brian.

Dupe of #31

authors: BryanGK rgreensp

repo: bcgov/connectivity-intake


text:
Bug - geographic names maximum query length

Describe the Bug
if the spreadsheet contains too many geographic locations the api request fails
Steps To Reproduce
Steps to reproduce the behaviour:
User/Role: uploader

upload the suvi dataset from teams
See error
the backend shows this error: Client Error: Request-URI Too Long for url

this indicates we need to change the way the request is sent, eg batches

PR up for this does address the maximum query length, but I found when testing on a huge file it takes FOREVER to load. Maybe we should discuss this api call further.

authors: JulianForeman emi-hi

repo: bcgov/cthub


text:
Filter refresh and postal code editing

HCAP-527 and 520 are back with a vengeance.

MoH can now update participants postal codes. This also updates their FSA
Fixed issue where the filter would reset after being idle for 5 minutes
I had to lint ignore a warning to get this to work. I really think we should rework the SiteTable to use less useEffect hooks

We intend to do a release containing only email blast changes to prod. This is on hold until we've done so. See discussion.

authors: ashtonmeuser dbayly-freshworks

repo: bcgov/hcap


text:
LCFS - Error saving edits to Allocation agreement data

Describe the Bug:
Edits made to rows in the Allocation Agreement input form are not saving. Attempting to save changes results in an error, and the data remains unchanged.
Expected Behaviour:
Edits to rows in the Allocation Agreement input form should be saved successfully without any errors.
Actual Behaviour:

When attempting to save changes to a row, an error occurs.
The edits are not saved, and the original data remains unchanged.

Implications:

Users are unable to update Allocation Agreement data, potentially leading to incomplete or inaccurate compliance reports.

Steps To Reproduce:

User/Role: BCeID user
Navigate to the Allocation Agreement input form.
Make edits to any row.
Observe the error and verify that the changes are not saved.

Additional Context:

It is normal to get 422s while the row is invalid or incomplete, but it should be showing an error message for what is required. Was the label stuck saying Updating Row?

Yes the row was complete/valid but it hung on Updating row

authors: airinggov dhaselhan

repo: bcgov/lcfs


text:
Search results need formatting rethink

[x] No results found fixed
[x] Search results should collapse pathways and steps into one list
[x] Add descriptions to each type (cat, path, act)

Skipping the descriptions as I think the UI ended up working better without them.

repo: bcgov/learningcurator


text:
Update spacing for responsiveness in events widget

Issue #1184 :
https://github.com/bcgov/met-public/issues/1184
-Make the event widget more responsiveness at different sizes

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the met-public license (Apache 2.0).

Codecov Report

Merging #1298 (d10eba4) into main (44fd9c0) will increase coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1298      +/-   ##
==========================================
+ Coverage   72.68%   72.71%   +0.02%
==========================================
  Files         303      303
  Lines        8505     8505
  Branches      599      599
==========================================
+ Hits         6182     6184       +2
+ Misses       2230     2228       -2
  Partials       93       93

Flag
Coverage Δ

metweb
66.65% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...s/engagement/view/widgets/Events/InPersonEvent.tsx
75.00% <ø> (ø)

.../engagement/view/widgets/Events/VirtualSession.tsx
75.00% <ø> (ø)

...-web/src/components/engagement/view/EmailPanel.tsx
15.15% <0.00%> (ø)

met-api/src/met_api/schemas/engagement.py
92.45% <0.00%> (+3.77%)
:arrow_up:

authors: codecov-commenter djnunez-aot

repo: bcgov/met-public


text:
feat: #1630 Pagination access control privilege endpoint

Adjust endpoint "/access_control_privileges" to "/access-control-privileges"
Add pagination schema objects for pagination related classes used by endpoint.
Add "page_params" query parameter for "/access-control-privileges?application_id" for pagination capability.
Use "create_date" as default sorting.
Add simple paginate abstract repository to provide pagination functionality for server/admin_management.
Implement paginate repository in access_control_privilege_repository for getting delegated admins.
access_control_privilege_service uses and return paged delegated admins from repository paged method.
Client-Code gen for frontend admin_management api.
Adjust frontend due to endpoint change.
Fix affected tests.

I'm having trouble running this in docker since pytest is not installed for runtime Docker containers.
Looks like we have a from pytest import Session in server/admin_management/api/app/repositories/simple_paginate_repository.py
Perhaps it should be from sqlalchemy.orm import Session
Log
2024-11-13 18:30:03 INFO:     Will watch for changes in these directories: ['/usr/src']
2024-11-13 18:30:03 INFO:     Uvicorn running on http://0.0.0.0:8001 (Press CTRL+C to quit)
2024-11-13 18:30:03 INFO:     Started reloader process [7] using WatchFiles
2024-11-13 18:30:04 Process SpawnProcess-1:
2024-11-13 18:30:04 Traceback (most recent call last):
2024-11-13 18:30:04   File "/usr/local/lib/python3.12/multiprocessing/process.py", line 314, in _bootstrap
2024-11-13 18:30:04     self.run()
2024-11-13 18:30:04   File "/usr/local/lib/python3.12/multiprocessing/process.py", line 108, in run
2024-11-13 18:30:04     self._target(*self._args, **self._kwargs)
2024-11-13 18:30:04   File "/usr/local/lib/python3.12/site-packages/uvicorn/_subprocess.py", line 78, in subprocess_started
2024-11-13 18:30:04     target(sockets=sockets)
2024-11-13 18:30:04   File "/usr/local/lib/python3.12/site-packages/uvicorn/server.py", line 65, in run
2024-11-13 18:30:04     return asyncio.run(self.serve(sockets=sockets))
2024-11-13 18:30:04            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
2024-11-13 18:30:04   File "/usr/local/lib/python3.12/asyncio/runners.py", line 194, in run
2024-11-13 18:30:04     return runner.run(main)
2024-11-13 18:30:04            ^^^^^^^^^^^^^^^^
2024-11-13 18:30:04   File "/usr/local/lib/python3.12/asyncio/runners.py", line 118, in run
2024-11-13 18:30:04     return self._loop.run_until_complete(task)
2024-11-13 18:30:04            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
2024-11-13 18:30:04   File "uvloop/loop.pyx", line 1518, in uvloop.loop.Loop.run_until_complete
2024-11-13 18:30:04   File "/usr/local/lib/python3.12/site-packages/uvicorn/server.py", line 69, in serve
2024-11-13 18:30:04     await self._serve(sockets)
2024-11-13 18:30:04   File "/usr/local/lib/python3.12/site-packages/uvicorn/server.py", line 76, in _serve
2024-11-13 18:30:04     config.load()
2024-11-13 18:30:04   File "/usr/local/lib/python3.12/site-packages/uvicorn/config.py", line 433, in load
2024-11-13 18:30:04     self.loaded_app = import_from_string(self.app)
2024-11-13 18:30:04                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
2024-11-13 18:30:04   File "/usr/local/lib/python3.12/site-packages/uvicorn/importer.py", line 22, in import_from_string
2024-11-13 18:30:04     raise exc from None
2024-11-13 18:30:04   File "/usr/local/lib/python3.12/site-packages/uvicorn/importer.py", line 19, in import_from_string
2024-11-13 18:30:04     module = importlib.import_module(module_str)
2024-11-13 18:30:04              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
2024-11-13 18:30:04   File "/usr/local/lib/python3.12/importlib/__init__.py", line 90, in import_module
2024-11-13 18:30:04     return _bootstrap._gcd_import(name[level:], package, level)
2024-11-13 18:30:04            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
2024-11-13 18:30:04   File "<frozen importlib._bootstrap>", line 1387, in _gcd_import
2024-11-13 18:30:04   File "<frozen importlib._bootstrap>", line 1360, in _find_and_load
2024-11-13 18:30:04   File "<frozen importlib._bootstrap>", line 1331, in _find_and_load_unlocked
2024-11-13 18:30:04   File "<frozen importlib._bootstrap>", line 935, in _load_unlocked
2024-11-13 18:30:04   File "<frozen importlib._bootstrap_external>", line 995, in exec_module
2024-11-13 18:30:04   File "<frozen importlib._bootstrap>", line 488, in _call_with_frames_removed
2024-11-13 18:30:04   File "/usr/src/api/app/main.py", line 7, in <module>
2024-11-13 18:30:04     from api.app.routers import (router_access_control_privilege,
2024-11-13 18:30:04   File "/usr/src/api/app/routers/router_access_control_privilege.py", line 6, in <module>
2024-11-13 18:30:04     from api.app.routers.router_guards import (
2024-11-13 18:30:04   File "/usr/src/api/app/routers/router_guards.py", line 12, in <module>
2024-11-13 18:30:04     from api.app.routers.router_utils import (
2024-11-13 18:30:04   File "/usr/src/api/app/routers/router_utils.py", line 5, in <module>
2024-11-13 18:30:04     from api.app.services.access_control_privilege_service import \
2024-11-13 18:30:04   File "/usr/src/api/app/services/access_control_privilege_service.py", line 9, in <module>
2024-11-13 18:30:04     from api.app.repositories.access_control_privilege_repository import \
2024-11-13 18:30:04   File "/usr/src/api/app/repositories/access_control_privilege_repository.py", line 9, in <module>
2024-11-13 18:30:04     from api.app.repositories.simple_paginate_repository import \
2024-11-13 18:30:04   File "/usr/src/api/app/repositories/simple_paginate_repository.py", line 10, in <module>
2024-11-13 18:30:04     from pytest import Session
2024-11-13 18:30:04 ModuleNotFoundError: No module named 'pytest'

It certainly shouldn't be from pytest should be sqlalchemy. But this is interesting, I ran many times in my local with just now again and was fine, don't know why my local does not catch this. Sometimes I don't understand Python, quite flexible and seems it is smart enough to correct this things.

It certainly shouldn't be from pytest should be sqlalchemy. But this is interesting, I ran many times in my local with just now again and was fine, don't know why my local does not catch this. Sometimes I don't understand Python, quite flexible and seems it is smart enough to correct this things.

@ianliuwk1019 i think it's because when you run locally in your terminal the pytest package is installed, but when you run it in docker or in a test or prod environment it doesn't get installed since it's only a dev dependency

Do you think we should re-generate client-code-gen after the sortOrder change? I'm not sure if it's affected

Yes, it does not re-generate/update new objects, but I update the json (has one single difference only).

repo: bcgov/nr-forests-access-management