text:
use pycurl as default

It seem WMAgent is not using pycurl as default (httplib2 is used). Change to pycurl call.
However, pycurl doesn't seems to be working smothly all the call fails.
Please don't merge yet
Traceback (most recent call last):
File "/Users/sryu/WorkArea2/WMCore/test/python/WMCore_t/Services_t/ReqMgr_t/ReqMgr_t.py", line 62, in setUp
RESTBaseUnitTestWithDBBackend.setUp(self)
File "/Users/sryu/WorkArea2/WMCore/src/python/WMQuality/REST/RESTBaseUnitTestWithDBBackend.py", line 53, in setUp
self.testInit.setupCouch(dbName, couchApp)
File "/Users/sryu/WorkArea2/WMCore/src/python/WMQuality/TestInitCouchApp.py", line 98, in setupCouch
self.couch.create(dropExistingDb=self.dropExistingDb)
File "/Users/sryu/WorkArea2/WMCore/src/python/WMQuality/TestInitCouchApp.py", line 49, in create
self.couchServer.createDatabase(self.dbName)
File "/Users/sryu/WorkArea2/WMCore/src/python/WMCore/Database/CMSCouch.py", line 876, in createDatabase
self.put("/%s" % urllib.quote_plus(dbname))
File "/Users/sryu/WorkArea2/WMCore/src/python/WMCore/Services/Requests.py", line 130, in put
encode, decode, contentType)
File "/Users/sryu/WorkArea2/WMCore/src/python/WMCore/Database/CMSCouch.py", line 113, in makeRequest
encode, decode,contentType)
File "/Users/sryu/WorkArea2/WMCore/src/python/WMCore/Services/Requests.py", line 147, in makeRequest
encoder, decoder, contentType)
File "/Users/sryu/WorkArea2/WMCore/src/python/WMCore/Services/Requests.py", line 172, in makeRequest_pycurl
verb=verb, ckey=ckey, cert=cert, capath=capath, decode=decoder)
File "/Users/sryu/WorkArea2/WMCore/src/python/WMCore/Services/pycurl_manager.py", line 149, in request
ckey, cert, capath, verbose, verb, doseq, cainfo)
File "/Users/sryu/WorkArea2/WMCore/src/python/WMCore/Services/pycurl_manager.py", line 91, in set_opts
curl.setopt(pycurl.POSTFIELDS, params)
TypeError: invalid arguments to setopt

@vkuznet, Valentin, actually the problem was it is passing python dict as the setopt argument.
I changed to encode to json string. I am still running the test but please review.

I am still having problem, that particular error is gone but now it is trying to convert pickled object to json.
2015-05-07 21:45:48,506:INFO:WorkQueue:fixing conflict...
2015-05-07 21:45:48,588:ERROR:WorkQueueManagerWorkPoller:Error in new work split loop: cannot parse JSON description: ccopy_reg
reconstructor
p1
(cWMCore.WMSpec.WMWorkload
WMWorkload
p2
c__builtin_
object
p3
NtRp4
(dp5
S'persistency'
p6
g1
(cWMCore.Configuration
ConfigSection
p7

Seangchan, I'm not sure I understand how your code fix relates to shown error in a ticket. The error says about invalid arguments to setopt method of curl, while your code fix initializes data member of the class

please post environment you're using or node where I can set this environment and I can test it.

Here is the traceback
Traceback (most recent call last):
File "/data/srv/wmagent/v1.0.6.pre7/sw.pre.sryu/slc6_amd64_gcc481/cms/wmagent/1.0.6.pre7/lib/python2.6/site-packages/WMComponent/WorkQueueManager/WorkQueueManagerWorkPoller.py", line 50, in algorithm
self.processWork()
File "/data/srv/wmagent/v1.0.6.pre7/sw.pre.sryu/slc6_amd64_gcc481/cms/wmagent/1.0.6.pre7/lib/python2.6/site-packages/WMComponent/WorkQueueManager/WorkQueueManagerWorkPoller.py", line 85, in processWork
self.queue.processInboundWork()
File "/data/srv/wmagent/v1.0.6.pre7/sw.pre.sryu/slc6_amd64_gcc481/cms/wmagent/1.0.6.pre7/lib/python2.6/site-packages/WMCore/WorkQueue/WorkQueue.py", line 975, in processInboundWork
inbound_work = self.backend.getElementsForSplitting()
File "/data/srv/wmagent/v1.0.6.pre7/sw.pre.sryu/slc6_amd64_gcc481/cms/wmagent/1.0.6.pre7/lib/python2.6/site-packages/WMCore/WorkQueue/WorkQueueBackend.py", line 104, in getElementsForSplitting
wmspec.load(self.parentCouchUrlWithAuth + "/%s/spec" % ele['RequestName'])
File "/data/srv/wmagent/v1.0.6.pre7/sw.pre.sryu/slc6_amd64_gcc481/cms/wmagent/1.0.6.pre7/lib/python2.6/site-packages/WMCore/WMSpec/Persistency.py", line 75, in load
data = request.makeRequest('', incoming_headers = {"Accept" : "/"})
File "/data/srv/wmagent/v1.0.6.pre7/sw.pre.sryu/slc6_amd64_gcc481/cms/wmagent/1.0.6.pre7/lib/python2.6/site-packages/WMCore/Services/Requests.py", line 147, in makeRequest
encoder, decoder, contentType)
File "/data/srv/wmagent/v1.0.6.pre7/sw.pre.sryu/slc6_amd64_gcc481/cms/wmagent/1.0.6.pre7/lib/python2.6/site-packages/WMCore/Services/Requests.py", line 172, in makeRequest_pycurl
verb=verb, ckey=ckey, cert=cert, capath=capath, decode=decoder)
File "/data/srv/wmagent/v1.0.6.pre7/sw.pre.sryu/slc6_amd64_gcc481/cms/wmagent/1.0.6.pre7/lib/python2.6/site-packages/WMCore/Services/pycurl_manager.py", line 156, in request
data = self.parse_body(bbuf.getvalue(), decode)
File "/data/srv/wmagent/v1.0.6.pre7/sw.pre.sryu/slc6_amd64_gcc481/cms/wmagent/1.0.6.pre7/lib/python2.6/site-packages/WMCore/Services/pycurl_manager.py", line 132, in parse_body
res = json.loads(data)
File "/data/srv/wmagent/v1.0.6.pre7/sw.pre.sryu/slc6_amd64_gcc481/cms/wmagent/1.0.6.pre7/lib/python2.6/site-packages/WMCore/Wrappers/JsonWrapper/init.py", line 40, in loads
raise ex
DecodeError: cannot parse JSON description: ccopy_reg
_reconstructor
p1

Seangchan, it seems to me that we had a mixture of two different issues here. First, if someone pass a python dictionary to pycurl and it needs to me json'ized. The second is default json decoding. In later case, it seems to me it is enabled by upper caller, while it retrieves the data which is not json stream. The issue happened with this call
https://reqmgr2-dev.cern.ch/couchdb/workqueue/sryu_MonteCarloFromGEN_Agent105_CDB16_forceComplete_150507_201640_2266/spec
if you'll query it you'll get python pickled object rather then json stream. This explains why pycurl fails. The pycurl includes parser which enables json decoding. As I said the caller of pycurl enabled it. So, I think it is not an issue with pycurl and rather a caller who must explicitly tell pycurl what todo. Anyway, I fixed both issue in this PR: https://github.com/dmwm/WMCore/pull/5868. The former just dumps json out of python dict, while later I print an error and return untoched data. Please have a look. But I rather to know who made a call to retrieve a spec and why spec is python pickled object, instead of a json. May be it is a wrong spec in DB.

Thanks Valentin for the prompt fix, We are getting pickled object from workqueue and turn that to python object.
Anyway, I made a couple of comments on your PR.

In that case the fix I made should work it will try to decode and if fails it will return untouched object.

test this please

Beginning pylint and unit tests.
See https://cmssdt.cern.ch/jenkins/job/DMWM-PR-test/115/ for details

retest this please

Eric it is in my todo list, please be patient.
On  0, Eric Vaandering notifications@github.com wrote:

retest this please

Reply to this email directly or view it on GitHub:
https://github.com/dmwm/WMCore/pull/5845#issuecomment-131974995

This is an instruction to Jenkins, not to you. :-)
Sent from a mobile device. Please excuse my brevity or transcription errors.
On Aug 17, 2015, at 17:10, Valentin Kuznetsov <notifications@github.commailto:notifications@github.com> wrote:
Eric it is in my todo list, please be patient.
On 0, Eric Vaandering <notifications@github.commailto:notifications@github.com> wrote:

retest this please

Reply to this email directly or view it on GitHub:
https://github.com/dmwm/WMCore/pull/5845#issuecomment-131974995

—
Reply to this email directly or view it on GitHubhttps://github.com/dmwm/WMCore/pull/5845#issuecomment-131979246.

Beginning pylint and unit tests.
See https://cmssdt.cern.ch/jenkins/job/DMWM-PR-test/284/ for details

retest this please

Beginning pylint and unit tests.
See https://cmssdt.cern.ch/jenkins/job/DMWM-PR-test/286/ for details

Please take this PR: https://github.com/dmwm/WMCore/pull/6142
which fix POSTFIELDS issue in unittests.
On  0, Eric Vaandering notifications@github.com wrote:

This is an instruction to Jenkins, not to you. :-)
Sent from a mobile device. Please excuse my brevity or transcription errors.
On Aug 17, 2015, at 17:10, Valentin Kuznetsov <notifications@github.commailto:notifications@github.com> wrote:
Eric it is in my todo list, please be patient.
On 0, Eric Vaandering <notifications@github.commailto:notifications@github.com> wrote:

retest this please

Reply to this email directly or view it on GitHub:
https://github.com/dmwm/WMCore/pull/5845#issuecomment-131974995

—
Reply to this email directly or view it on GitHubhttps://github.com/dmwm/WMCore/pull/5845#issuecomment-131979246.

Reply to this email directly or view it on GitHub:
https://github.com/dmwm/WMCore/pull/5845#issuecomment-131985106

retest this please

Beginning pylint and unit tests.
See https://cmssdt.cern.ch/jenkins/job/DMWM-PR-test/289/ for details

retest this please

Beginning pylint and unit tests.
See https://cmssdt.cern.ch/jenkins/job/DMWM-PR-test/299/ for details

It seems that my PR (#6142) didn't applied to these tests, all of them complains again
about invalid arguments to setopt.
On  0, DMWM Autobot notifications@github.com wrote:

Beginning pylint and unit tests.
See https://cmssdt.cern.ch/jenkins/job/DMWM-PR-test/299/ for details

Reply to this email directly or view it on GitHub:
https://github.com/dmwm/WMCore/pull/5845#issuecomment-132633732

Let me check…
Sent from a mobile device. Please excuse my brevity or transcription errors.
On Aug 19, 2015, at 13:02, Valentin Kuznetsov <notifications@github.commailto:notifications@github.com> wrote:
It seems that my PR (#6142) didn't applied to these tests, all of them complains again
about invalid arguments to setopt.
On 0, DMWM Autobot <notifications@github.commailto:notifications@github.com> wrote:

Beginning pylint and unit tests.
See https://cmssdt.cern.ch/jenkins/job/DMWM-PR-test/299/ for details

Reply to this email directly or view it on GitHub:
https://github.com/dmwm/WMCore/pull/5845#issuecomment-132633732

—
Reply to this email directly or view it on GitHubhttps://github.com/dmwm/WMCore/pull/5845#issuecomment-132722918.

The unit tests are still running for this, but they will fail. Two slices are stuck in places that things often get stuck. CherryPy and something to do with a database.
I haven't seen any evidence this patch is failing new tests, but it sure seems to get stuck more often.

Actually, no, your thing had a bunch of slices fail. But I did find a problem. I was setting python path incorrectly in the tests and it was not picking up code in src/python, only test/python. That's bad...

retest this please

Beginning pylint and unit tests.
See https://cmssdt.cern.ch/jenkins/job/DMWM-PR-test/302/ for details

Eric,
it failed again and some of the tests still shows that my patch didn't applied,
e.g.
https://cmssdt.cern.ch/jenkins/job/DMWM-PR-unittests/235/SLICE=2,label=slc6_amd64-cloud/testReport/junit/WMCore_t.WorkQueue_t.DataStructs_t.CouchWorkQueueElement_t/CouchWorkQueueElementTest/testIdFromDbImmutable/
this test still uses pycurl setopt in old way which I fixed.
So, I'm not sure how jenkins picks stuff. I think what happens that I submit
new PR https://github.com/dmwm/WMCore/pull/6142 and it is not part of this
issue (it is different PR). So the unit test continue to use this PR file
changes. My understanding that we need to close this PR and open new one
which should include changes on top of #6142 PR.
Valentin.
On  0, DMWM Autobot notifications@github.com wrote:

Beginning pylint and unit tests.
See https://cmssdt.cern.ch/jenkins/job/DMWM-PR-test/302/ for details

Reply to this email directly or view it on GitHub:
https://github.com/dmwm/WMCore/pull/5845#issuecomment-132770667

Jenkins has been all fubar for the last day or so. So give it another try. I will retrigger the tests on this PR when I think Jenkins is working correctly.
What it is supposed to be doing is
a) check out the current master
b) merge your patch onto master if possible (which is possible with this PR)
c) test that aggregation
d) compare with the last successful test of the master (run once per day)

retest this please

Beginning pylint and unit tests.
See https://cmssdt.cern.ch/jenkins/job/DMWM-PR-test/317/ for details

Beginning pylint and unit tests.
See https://cmssdt.cern.ch/jenkins/job/DMWM-PR-test/321/ for details

Beginning pylint and unit tests.
See https://cmssdt.cern.ch/jenkins/job/DMWM-PR-test/323/ for details

Summary of pylint changes for pull request 5845:

Score for src/python/WMCore/Services/Requests.py decreased from 9.75 to 9.72
Warnings for src/python/WMCore/Services/Requests.py increased from 5 to 6

src/python/WMCore/Services/Requests.py got worse in pylint. Report follows:

Line 27 W0702 No exception type(s) specified
Line 64 in Requests.init W0612 Unused variable 'pycurl'
Line 154 in Requests.makeRequest_pycurl W0613 Unused argument 'encoder'
Line 260 in Requests.makeRequest_httplib W0106 Expression "[conn.close() for conn in self['conn'].connections.values()]" is assigned to nothing
Line 175 in Requests.makeRequest_httplib R0912 Too many branches (14/12)
Line 289 in Requests.encode R0201 Method could be a function
Line 295 in Requests.decode R0201 Method could be a function
Line 371 in Requests._getURLOpener W0703 Catching too general exception Exception
Line 521 in Requests.downloadFile W0621 Redefining name 'ResponseHeader' from outer scope (line 36)
Line 50 in Requests R0904 Too many public methods (31/20)
Line 550 in JSONRequests R0904 Too many public methods (31/20)
Line 583 in TempDirectory R0903 Too few public methods (0/2)
plus 41 comments on code style

Pre-python 2.6 idioms found in changed files. Please consider updating the code. Suggested patch follows:
--- src/python/WMCore/Services/Requests.py (original)
+++ src/python/WMCore/Services/Requests.py (refactored)
@@ -220,7 +220,7 @@
             pass

         if verb != 'GET' and data:
-            if type(encoder) == type(self.get) or type(encoder) == type(f):
+            if isinstance(encoder, type(self.get)) or isinstance(encoder, type(f)):
                 encoded_data = encoder(data)
             elif encoder == False:
                 # Don't encode the data more than we have to
@@ -240,7 +240,7 @@

         headers["Content-length"] = str(len(encoded_data))

-        assert type(encoded_data) == type('string'), \
+        assert isinstance(encoded_data, type('string')), \
             "Data in makeRequest is %s and not encoded to a string" \
                 % type(encoded_data)

@@ -279,7 +279,7 @@
             setattr(e, 'headers', response)
             raise e

-        if type(decoder) == type(self.makeRequest) or type(decoder) == type(f):
+        if isinstance(decoder, type(self.makeRequest)) or isinstance(decoder, type(f)):
             result = decoder(result)
         elif decoder != False:
             result = self.decode(result)

Unit test changes for pull request 5845:

WMCore_t.Services_t.Registration_t.Registration_t.RegistrationTest:testPush changed from success to error
WMComponent_t.JobTracker_t.JobTracker_t.JobTrackerTest:testAlerts changed from success to error
WMCore_t.WorkQueue_t.WMBSHelper_t.WMBSHelperTest:testKillWorkflow changed from success to error
WMComponent_t.JobAccountant_t.JobAccountant_t.JobAccountantTest:testBadFWJR changed from success to error
WMCore_t.WMBS_t.JobSplitting_t.EventBased_t.EventBasedTest:testExactEvents changed from success to error
WMCore_t.FwkJobReport_t.Report_t.ReportTest:testExitCode changed from success to error
WMCore_t.Services_t.RequestDB_t.T0RequestDB_t.T0RequestDBTest:testRequestDBWriter changed from success to error
WMCore_t.WMBS_t.JobSplitting_t.LumiBased_t.LumiBasedTest:testE_getParents changed from success to error
WMCore_t.DataStructs_t.MathStructs_t.DiscreteSummaryHistogram_t.DiscreteSummaryHistogramTest:testA_BasicTest changed from success to error
WMCore_t.WMBS_t.JobSplitting_t.EventBased_t.EventBasedTest:testMoreEvents changed from success to error
WMCore_t.FwkJobReport_t.Report_t.ReportTest:testCheckLumiInformation changed from success to error
WMCore_t.JobStateMachine_t.Couchapp_t.CouchappTest:testHighestJobID changed from success to error
WMCore_t.WMBSFeeder_t.FakeFeeder_t.BaseFakeFeederTestCase:testCall was deleted. Prior status was success
WMCore_t.WMSpec_t.StdSpecs_t.TaskChain_t.TaskChainTests:testMultithreadedTasksTaskChain changed from success to error
WMCore_t.BossAir_t.VanillaCondorPlugin_t.VanillaCondorPluginTest:testG_monitoringDAO changed from success to error
WMComponent_t.AlertGenerator_t.Pollers_t.Couch_t.CouchTest:testAlertGeneratorCouchMemoryPollerSoftThreshold changed from success to failure
WMComponent_t.JobSubmitter_t.JobSubmitter_t.JobSubmitterTest:testE_SiteModesTest changed from success to error
WMCore_t.FwkJobReport_t.Report_t.ReportTest:testFallbackFilesJSON changed from success to error
WMCore_t.Services_t.DBS_t.DBSReader_t.DBSReaderTest:testListBlockParents changed from success to error
WMCore_t.FwkJobReport_t.Report_t.ReportTest:testProperties changed from success to error
WMComponent_t.JobAccountant_t.JobAccountant_t.JobAccountantTest:testMergeSuccessNoLumi changed from success to error
WMComponent_t.TaskArchiver_t.TaskArchiver_t.TaskArchiverTest:testD_Timing changed from success to error
WMComponent_t.JobArchiver_t.JobArchiver_t.JobArchiverTest:testJobArchiverPollerAlertsSending_constructor changed from success to error
WMCore_t.DataStructs_t.MathStructs_t.ContinuousSummaryHistogram_t.ContinuousSummaryHistogramTest:testA_BasicTest changed from success to error
WMCore_t.WMSpec_t.StdSpecs_t.MonteCarlo_t.MonteCarloTest:testMonteCarloExtension changed from success to error
WMCore_t.WMLogging_t.WMLoggingTest:testLog changed from success to error
WMCore_t.FwkJobReport_t.Report_t.ReportTest:testTaskJobID changed from success to error
WMCore_t.Database_t.CMSCouch_t.CMSCouchTest:testCommitOneWithQueue changed from success to error
WMCore_t.WMSpec_t.StdSpecs_t.ReReco_t.ReRecoTest:testReRecoDroppingRECO changed from success to error
WMCore_t.WMBS_t.JobSplitting_t.EventBased_t.EventBasedTest:test50EventMultipleFileSplit changed from success to error
WMComponent_t.TaskArchiver_t.TaskArchiver_t.TaskArchiverTest:testTaskArchiverPollerAlertsSending_notifyWorkQueue changed from success to error
WMCore_t.Cache_t.WMConfigCache_t.testWMConfigCache:testA_basicConfig changed from success to error
WMCore_t.FwkJobReport_t.Report_t.ReportTest:test_PerformanceReport changed from success to error
WMComponent_t.JobCreator_t.JobCreator_t.JobCreatorTest:testC_ProfileWorker changed from success to error
WMCore_t.WMBS_t.JobSplitting_t.EventBased_t.EventBasedTest:test50EventSplit changed from success to error
WMCore_t.WebTools_t.NestedModel_t.NestedModelTest:testOuterFooError changed from error to success
WMCore_t.WorkQueue_t.Policy_t.Start_t.Dataset_t.DatasetTestCase:testParentProcessing changed from failure to error
WMCore_t.FwkJobReport_t.Report_t.ReportTest:testPileupFiles changed from success to error
WMCore_t.FwkJobReport_t.Report_t.ReportTest:testDeleteOutputModule changed from success to error
WMCore_t.WMBS_t.JobSplitting_t.EventBased_t.EventBasedTest:testMCEventSplitOver32bit changed from success to error
WMCore_t.FwkJobReport_t.Report_t.ReportTest:testPerformanceJSON changed from success to error
WMComponent_t.AlertGenerator_t.Pollers_t.Couch_t.CouchTest:testAlertGeneratorCouchCPUPollerNoAlert changed from success to failure
WMCore_t.WorkQueue_t.WorkQueueBackend_t.WorkQueueBackendTest:testPriority changed from success to error
WMCore_t.JobStateMachine_t.ChangeState_t.TestChangeState:testRetryCount changed from success to error
WMCore_t.BossAir_t.CondorPlugin_t.CondorPluginTest:testG_monitoringDAO changed from success to error
WMCore_t.ACDC_t.CouchFileset_t.CouchFileset_t:testDropCount changed from success to error
WMCore_t.WMBSFeeder_t.PhEDExNotifier_t.PhEDExNotifierTest:testCall was deleted. Prior status was skipped
WMCore_t.WorkQueue_t.Policy_t.Start_t.Block_t.BlockTestCase:testGetMaskedBlocks changed from success to error
WMCore_t.Cache_t.WMConfigCache_t.testWMConfigCache:testD_LoadConfigCache changed from success to error
WMCore_t.WMBS_t.JobSplitting_t.LumiBased_t.LumiBasedTest:testD_NonContinuousLumis changed from success to error
WMCore_t.WorkQueue_t.Policy_t.Start_t.Dataset_t.DatasetTestCase:testRunWhitelist changed from success to error
WMCore_t.Services_t.DBS_t.DBSReader_t.DBSReaderTest:testGetFileBlockWithParents changed from success to error
WMComponent_t.JobArchiver_t.JobArchiver_t.JobArchiverTest:testJobArchiverPollerAlertsSending_cleanJobCache changed from success to error
WMComponent_t.AlertGenerator_t.Pollers_t.Couch_t.CouchTest:testAlertGeneratorCouchCPUPollerSoftThreshold changed from success to failure
WMComponent_t.RetryManager_t.RetryManager_t.RetryManagerTest:testE_ExponentialAlgo changed from success to error
WMCore_t.Database_t.CMSCouch_t.CMSCouchTest:testCommitOne changed from success to error
WMComponent_t.JobCreator_t.JobCreator_t.JobCreatorTest:testE_TestNonProxySplitting changed from success to error
WMCore_t.WebTools_t.REST_t.RESTTest:testBadMethodEcho changed from error to success
WMCore_t.WMRuntime_t.DashboardInterface_t.DashboardInterfaceTest:testAFailedJobMonitoring changed from success to error
WMCore_t.WebTools_t.REST_t.RESTTest:testBadEchoWithPosArg changed from error to success
WMComponent_t.RetryManager_t.RetryManager_t.RetryManagerTest:testA_Create changed from success to error
WMCore_t.FwkJobReport_t.ReportEmu_t.ReportEmuTest:testMerge changed from success to error
WMCore_t.FwkJobReport_t.Report_t.ReportTest:testErrorReporting changed from success to error
WMCore_t.Database_t.CMSCouch_t.CMSCouchTest:testSlashInDBName changed from success to error
WMCore_t.Agent_t.HarnessCouchBackend_t.HarnessCouchBackend_t:testAddComponent changed from success to error
WMCore_t.WMBSFeeder_t.FakeFeeder_t.BaseUpdatingFakeFeederTestCase:testCall was deleted. Prior status was success
WMComponent_t.RetryManager_t.RetryManager_t.RetryManagerTest:testH_PauseAlgo changed from success to error
WMComponent_t.AlertGenerator_t.Pollers_t.Couch_t.CouchTest:testAlertGeneratorCouchErrorsPollerBasic changed from success to failure
WMComponent_t.JobCreator_t.JobCreator_t.JobCreatorTest:testA_VerySimpleTest changed from success to error
WMCore_t.BossAir_t.gLitePlugin_t.gLitePluginTest:testG_monitoringDAO changed from success to error
WMCore_t.WMRuntime_t.DashboardInterface_t.DashboardInterfaceTest:testAKilledJobMonitoring changed from success to error
WMComponent_t.WorkQueueManager_t.WorkQueueManager_t.WorkQueueManagerTest:testComponentBasic changed from success to error
WMCore_t.BossAir_t.ARCPlugin_t.BossAirTest:testG_monitoringDAO changed from success to error
WMCore_t.FwkJobReport_t.Report_t.ReportTest:testOutputCheck changed from success to error
WMComponent_t.JobAccountant_t.JobAccountant_t.JobAccountantTest:testParentlessMergeSuccess changed from success to error
WMComponent_t.TaskArchiver_t.TaskArchiver_t.TaskArchiverTest:testTaskArchiverPollerAlertsSending_killSubscriptions changed from success to error
WMCore_t.WebTools_t.REST_t.RESTTest:testSanitiseFailHTTP changed from error to success
WMCore_t.ACDC_t.CouchFileset_t.CouchFileset_t:testListFiles changed from success to error
WMCore_t.Cache_t.WMConfigCache_t.testWMConfigCache:testC_testViews changed from success to error
WMCore_t.WMBS_t.JobSplitting_t.EventBased_t.EventBasedTest:test150EventMultipleFileSplit changed from success to error
WMCore_t.Alerts_t.ZMQ_t.Processor_t.ProcessorTest:testProcessorWithReceiverAndCouchSink changed from success to error
WMCore_t.DataStructs_t.MathStructs_t.ContinuousSummaryHistogram_t.ContinuousSummaryHistogramTest:testC_compactHistogram changed from success to error
WMComponent_t.AlertGenerator_t.Pollers_t.Couch_t.CouchTest:testAlertGeneratorCouchPollerBasic changed from success to failure
WMCore_t.WMBS_t.JobSplitting_t.LumiBased_t.LumiBasedTest:testF_RunWhitelist changed from success to error
WMComponent_t.RetryManager_t.RetryManager_t.RetryManagerTest:testF_LinearAlgo changed from success to error
WMCore_t.JobStateMachine_t.ChangeState_t.TestChangeState:testJobKilling changed from success to error
WMCore_t.BossAir_t.PyCondorPlugin_t.BossAirTest:testG_monitoringDAO changed from success to error
WMComponent_t.JobSubmitter_t.JobSubmitter_t.JobSubmitterTest:testB_thresholdTest changed from success to error
WMCore_t.WMBS_t.JobSplitting_t.EventBased_t.EventBasedTest:test100EventMultipleSite changed from success to error
WMComponent_t.JobSubmitter_t.JobSubmitterCaching_t.JobSubmitterCachingTest:testCaching changed from success to error
WMComponent_t.RetryManager_t.RetryManager_t.RetryManagerTest:testB_Submit changed from success to error
WMCore_t.Database_t.CMSCouch_t.CMSCouchTest:testAllDocs changed from success to error
WMCore_t.WorkQueue_t.Policy_t.Start_t.Block_t.BlockTestCase:testTier1ReRecoWorkload changed from success to error
WMCore_t.Cache_t.WMConfigCache_t.testWMConfigCache:testB_addingConfigsAndTweaks changed from success to error
WMComponent_t.AlertGenerator_t.Pollers_t.Couch_t.CouchTest:testAlertGeneratorCouchErrorsPollerNoAlert changed from success to failure
WMComponent_t.ErrorHandler_t.ErrorHandler_t.ErrorHandlerTest:testB_Submit changed from success to error
WMCore_t.BossAir_t.PyCondorPlugin_t.PyCondorPluginTest:testG_monitoringDAO changed from success to error
WMCore_t.WorkQueue_t.DataStructs_t.CouchWorkQueueElement_t.CouchWorkQueueElementTest:testIdFromDbImmutable changed from success to error
WMCore_t.JobStateMachine_t.ChangeState_t.TestChangeState:testPersist changed from success to error
WMCore_t.WMSpec_t.StdSpecs_t.ReDigi_t.ReDigiTest:testDependentReDigi changed from success to error
WMCore_t.WMBS_t.JobSplitting_t.LumiBased_t.LumiBasedTest:testB_NoRunNoFileSplitting changed from success to error
WMCore_t.FwkJobReport_t.Report_t.ReportTest:testPerformanceSummary changed from success to error
WMCore_t.WMRuntime_t.DashboardInterface_t.DashboardInterfaceTest:testMultithreadedApplication changed from success to error
WMCore_t.GroupUser_t.Interface_t.Interface_t:testA changed from success to error
WMComponent_t.AlertGenerator_t.Pollers_t.Couch_t.CouchTest:testAlertGeneratorCouchErrorsPollerSoftThreshold changed from success to failure
WMCore_t.WorkQueue_t.WMBSHelper_t.WMBSHelperTest:testCreateSubscription changed from success to error
WMComponent_t.AlertGenerator_t.Pollers_t.Couch_t.CouchTest:testAlertGeneratorCouchMemoryPollerCriticalThreshold changed from success to failure
WMComponent_t.JobAccountant_t.JobAccountant_t.JobAccountantTest:testMergedSkim changed from success to error
WMCore_t.ACDC_t.CouchService_t.CouchService_t:testOwners changed from failure to error
WMCore_t.DataStructs_t.MathStructs_t.ContinuousSummaryHistogram_t.ContinuousSummaryHistogramTest:testB_extremeData changed from success to error
WMCore_t.WMBS_t.JobSplitting_t.EventBased_t.EventBasedTest:test100EventMultipleFileSplit changed from success to error
WMCore_t.WorkQueue_t.Policy_t.Start_t.Block_t.BlockTestCase:testWhiteBlackLists changed from failure to error
WMCore_t.Services_t.Requests_t.TestRequests:testSecureNoAuth changed from success to error
WMCore_t.WMSpec_t.StdSpecs_t.ReDigi_t.ReDigiTest:testChainedReDigi changed from success to error
WMCore_t.WorkQueue_t.Policy_t.Start_t.Block_t.BlockTestCase:testContinuousSplittingSupport changed from success to error
WMCore_t.WMSpec_t.StdSpecs_t.ReDigi_t.ReDigiTest:testThreeStepChainedReDigi changed from success to error
WMCore_t.WorkQueue_t.Policy_t.Start_t.Block_t.BlockTestCase:testDataDirectiveFromQueue changed from success to error
WMCore_t.GroupUser_t.CouchObject_t.CouchObject_t:testB changed from success to error
WMCore_t.GroupUser_t.CouchObject_t.CouchObject_t:testA changed from success to error
WMCore_t.ACDC_t.CouchService_t.CouchService_t:testListCollectionsFilesets changed from success to error
WMCore_t.Database_t.CMSCouch_t.CMSCouchTest:testDeleteDoc changed from success to error
WMCore_t.WMSpec_t.StdSpecs_t.StepChain_t.StepChainTests:testStepChainMC changed from success to error
WMCore_t.ACDC_t.CouchCollection_t.CouchCollection_t:testCreatePopulateDrop changed from success to error
WMCore_t.JobStateMachine_t.ChangeState_t.TestChangeState:testUpdateFailedDoc changed from success to error
WMCore_t.WorkQueue_t.Policy_t.Start_t.Block_t.BlockTestCase:testPileupData changed from success to error
WMComponent_t.ErrorHandler_t.ErrorHandler_t.ErrorHandlerTest:testC_Jobs changed from success to error
WMComponent_t.JobAccountant_t.JobAccountant_t.JobAccountantTest:testZ1_BigHeritage changed from success to error
WMCore_t.WorkQueue_t.Policy_t.Start_t.ResubmitBlock_t.ResubmitBlockTest:testUnsupportedACDC changed from success to error
WMCore_t.WMSpec_t.Steps_t.Fetchers_t.PileupFetcher_t.PileupFetcherTest:testPileupFetcherOnMC changed from success to error
WMCore_t.WMSpec_t.StdSpecs_t.MonteCarlo_t.MonteCarloTest:testMonteCarlo changed from success to error
WMCore_t.WMSpec_t.StdSpecs_t.ReReco_t.ReRecoTest:testReReco changed from success to error
WMCore_t.FwkJobReport_t.Report_t.ReportTest:testXMLParsing changed from success to error
WMCore_t.WMSpec_t.StdSpecs_t.StepChain_t.StepChainTests:testStepChainSingleStep changed from success to error
WMCore_t.WorkQueue_t.Policy_t.Start_t.Block_t.BlockTestCase:testDatasetLocation changed from success to error
WMComponent_t.RetryManager_t.RetryManager_t.RetryManagerTest:testD_SquaredAlgo changed from success to error
WMCore_t.Database_t.CMSCouch_t.CMSCouchTest:testTimeStamping changed from success to error
WMCore_t.Database_t.CouchUtils_t.CouchUtils_t:testB changed from success to error
WMCore_t.ResourceControl_t.ResourceControl_t.ResourceControlTest:testChangeSiteState changed from error to success
WMCore_t.WorkQueue_t.Policy_t.Start_t.Block_t.BlockTestCase:testInvalidSpecs changed from success to error
WMCore_t.ACDC_t.CouchService_t.CouchService_t:testTimestampAccounting changed from success to error
WMCore_t.WMSpec_t.StdSpecs_t.DQMHarvest_t.DQMHarvestTests:testDQMHarvest changed from success to error
WMCore_t.Database_t.CMSCouch_t.CMSCouchTest:testInvalidName changed from success to error
WMCore_t.JobStateMachine_t.ChangeState_t.TestChangeState:testRecordInCouch changed from success to error
WMCore_t.FwkJobReport_t.Report_t.ReportTest:testOutputFiles changed from success to error
WMCore_t.Cache_t.WMConfigCache_t.testWMConfigCache:testE_SaveConfigFileToDisk changed from success to error
WMCore_t.WMSpec_t.StdSpecs_t.PrivateMC_t.PrivateMCTest:testPrivateMC changed from success to error
WMCore_t.WorkQueue_t.Policy_t.Start_t.ResubmitBlock_t.ResubmitBlockTest:testEmptyACDC changed from success to error
WMComponent_t.RetryManager_t.RetryManager_t.RetryManagerTest:testG_ProcessingAlgo changed from success to error
WMCore_t.WorkQueue_t.WorkQueueBackend_t.WorkQueueBackendTest:testDuplicateInsertion changed from success to error
WMCore_t.FwkJobReport_t.Report_t.ReportTest:testStripReport changed from success to error
WMCore_t.WorkQueue_t.Policy_t.Start_t.Block_t.BlockTestCase:testLumiSplitTier1ReRecoWorkload changed from success to error
WMCore_t.Database_t.RotatingDatabase_t.RotatingDatabaseTest:testArchive changed from failure to error
WMCore_t.ResourceControl_t.ResourceControl_t.ResourceControlTest:testAbortedState changed from error to success
WMCore_t.WMBS_t.JobSplitting_t.LumiBased_t.LumiBasedTest:testA_FileSplitting changed from failure to error
WMCore_t.WorkQueue_t.Policy_t.Start_t.Dataset_t.DatasetTestCase:testInvalidSpecs changed from success to error
WMCore_t.FwkJobReport_t.Report_t.ReportTest:testSkippedFilesJSON changed from success to error
WMComponent_t.JobSubmitter_t.JobSubmitter_t.JobSubmitterTest:testC_prioritization changed from success to error
WMCore_t.Database_t.RotatingDatabase_t.RotatingDatabaseTest:testExpire changed from success to error
WMCore_t.JobStateMachine_t.ChangeState_t.TestChangeState:testCheck changed from success to error
WMCore_t.WebTools_t.RESTFormat_t.RESTFormatTest:testReturnFormat was deleted. Prior status was error
WMCore_t.WMSpec_t.StdSpecs_t.Analysis_t.AnalysisTest:testAnalysis changed from success to error
WMComponent_t.JobCreator_t.JobCreator_t.JobCreatorTest:testD_HugeTest changed from success to error
WMCore_t.BossAir_t.CondorPlugin_t.BossAirTest:testG_monitoringDAO changed from success to error
WMCore_t.Database_t.RotatingDatabase_t.RotatingDatabaseTest:testRotate changed from success to error
WMCore_t.Services_t.DBS_t.DBSReader_t.DBSReaderTest:testGetFileBlock changed from success to error
WMCore_t.Alerts_t.ZMQ_t.Sinks_t.RESTSink_t.RESTSinkTest:testRESTSinkBasic changed from success to error
WMCore_t.WMSpec_t.StdSpecs_t.TaskChain_t.TaskChainTests:testMultithreadedTaskChain changed from success to error
WMCore_t.JobStateMachine_t.ChangeState_t.TestChangeState:testFWJRInputFileTruncation changed from success to error
WMCore_t.WMSpec_t.Steps_t.Fetchers_t.CMSSWFetcher_t.URLFetcherTest:testA_BasicFunction changed from success to error
WMCore_t.WMBS_t.JobSplitting_t.LumiBased_t.LumiBasedTest:testC_ACDCTest changed from success to error
WMCore_t.RequestManager_t.Assign_t.AssignTest:testA_SiteWhitelist changed from success to error
WMCore_t.Services_t.DBS_t.DBSReader_t.DBSReaderTest:testGetFiles changed from success to error
WMComponent_t.ErrorHandler_t.ErrorHandler_t.ErrorHandlerTest:testE_FailJobs changed from success to error
WMComponent_t.AlertGenerator_t.Pollers_t.Couch_t.CouchTest:testAlertGeneratorCouchDbSizePollerNoAlert changed from success to failure
WMCore_t.WMBS_t.JobSplitting_t.EventBased_t.EventBasedTest:test_addParents changed from success to error
WMCore_t.WorkQueue_t.Policy_t.Start_t.Block_t.BlockTestCase:testWithMaskedBlocks changed from success to error
WMCore_t.FwkJobReport_t.Report_t.ReportTest:testDuplicatStep changed from success to error
WMComponent_t.JobAccountant_t.JobAccountant_t.JobAccountantTest:testSplitJobs changed from success to error
WMCore_t.WorkQueue_t.WorkQueueSchema_t.WorkQueueSchemnaTest:testSchemaGeneration changed from success to error
WMCore_t.WMSpec_t.StdSpecs_t.ReDigi_t.ReDigiTest:testCombinedReDigiRecoConfig changed from success to error
WMCore_t.JobSplitting_t.Generators_t.ReproducibleSeeding_t.ReproducibleSeedingTests:testA changed from success to error
WMComponent_t.JobAccountant_t.JobAccountant_t.JobAccountantTest:testMergeSuccessSkippedFiles changed from success to error
WMCore_t.WMSpec_t.StdSpecs_t.ReDigi_t.ReDigiTest:testSingleStepReDigi changed from success to error
WMCore_t.WMSpec_t.StdSpecs_t.MonteCarlo_t.MonteCarloTest:testMCWithLHE changed from success to error
WMCore_t.BossAir_t.BossAir_t.BossAirTest:testG_monitoringDAO changed from success to error
WMComponent_t.JobSubmitter_t.JobSubmitter_t.JobSubmitterTest:testA_BasicTest changed from success to error
WMComponent_t.AlertGenerator_t.AlertGenerator_t.AlertGeneratorTest:testAllFinalClassPollerImplementations changed from success to error
WMCore_t.WMSpec_t.StdSpecs_t.MonteCarlo_t.MonteCarloTest:testMCWithPileup changed from success to error
WMCore_t.JobStateMachine_t.ChangeState_t.TestChangeState:testUpdateLocation changed from success to error
WMComponent_t.AnalyticsDataCollector_t.Plugins_t.Tier0Plugin_t.Tier0PluginTest:testB_ExpressStates changed from success to error
WMCore_t.WorkQueue_t.DataStructs_t.CouchWorkQueueElement_t.CouchWorkQueueElementTest:testFixElementConflicts changed from success to error
WMCore_t.FwkJobReport_t.Report_t.ReportTest:testTimeSetting changed from success to error
WMComponent_t.AlertGenerator_t.Pollers_t.Couch_t.CouchTest:testAlertGeneratorCouchDbSizePollerBasic changed from success to failure
WMCore_t.Database_t.CMSCouch_t.CMSCouchTest:testWriteReadDocNoID changed from success to error
WMComponent_t.JobArchiver_t.JobArchiver_t.JobArchiverTest:testA_BasicFunctionTest changed from success to error
WMCore_t.Database_t.CMSCouch_t.CMSCouchTest:testAttachments changed from success to error
WMCore_t.JobStateMachine_t.ChangeState_t.TestChangeState:testJobSummary changed from success to error
WMComponent_t.JobAccountant_t.JobAccountant_t.JobAccountantTest:testReportReturn changed from success to error
WMCore_t.Services_t.WMStats_t.WMStats_t.WMStatsTest:testWMStatsWriter changed from success to error
WMComponent_t.AlertGenerator_t.Pollers_t.Couch_t.CouchTest:testAlertGeneratorCouchDbSizePollerSoftThreshold changed from success to failure
WMCore_t.BossAir_t.ARCTest_t.ARCTest:testG_monitoringDAO changed from success to error
WMComponent_t.FeederManager_t.FeederManager_t.FeederManagerTest:testA was deleted. Prior status was success
WMCore_t.BossAir_t.VanillaCondorPlugin_t.BossAirTest:testG_monitoringDAO changed from success to error
WMCore_t.WorkQueue_t.Policy_t.Start_t.Dataset_t.DatasetTestCase:testLumiSplitTier1ReRecoWorkload changed from success to error
WMComponent_t.JobAccountant_t.JobAccountant_t.JobAccountantTest:testNoFileReport changed from success to error
WMCore_t.FwkJobReport_t.Report_t.ReportTest:testMultipleInputs changed from success to error
WMCore_t.WorkQueue_t.WMBSHelper_t.WMBSHelperTest:testTruncatedWFInsertion changed from success to error
WMCore_t.FwkJobReport_t.ReportEmu_t.ReportEmuTest:testProcessing changed from success to error
WMCore_t.Agent_t.HarnessCouchBackend_t.HarnessCouchBackend_t:testAddWorker changed from success to error
WMComponent_t.ErrorHandler_t.ErrorHandler_t.ErrorHandlerTest:testZ_Profile changed from success to error
WMComponent_t.DBSUpload_t.DBSUploadPoller_t.DBSUploadTest:testG_closeSettingsPerWorkflow changed from failure to error
WMCore_t.Database_t.CouchUtils_t.CouchUtils_t:testA changed from success to error
WMCore_t.JobStateMachine_t.ChangeState_t.TestChangeState:testIndexConflict changed from success to error
WMCore_t.FwkJobReport_t.Report_t.ReportTest:testSkippedFiles changed from success to error
WMCore_t.FwkJobReport_t.Report_t.ReportTest:testFallbackFiles changed from success to error
WMComponent_t.RetryManager_t.RetryManager_t.RetryManagerTest:testZ_Profile changed from success to error
WMComponent_t.RetryManager_t.RetryManager_t.RetryManagerTest:testY_MultipleIterations changed from success to error
WMCore_t.WMSpec_t.Steps_t.Fetchers_t.URLFetcher_t.URLFetcherTest:testA_BasicFunction changed from success to error
WMCore_t.Database_t.CMSCouch_t.CMSCouchTest:testDeleteQueuedDocs changed from success to error
WMComponent_t.TaskArchiver_t.TaskArchiver_t.TaskArchiverTest:testC_Profile changed from success to error
WMCore_t.JobStateMachine_t.ChangeState_t.TestChangeState:testDuplicateJobReports changed from success to error
WMComponent_t.JobAccountant_t.JobAccountant_t.JobAccountantTest:testFailedJob changed from success to error
WMCore_t.FwkJobReport_t.Report_t.ReportTest:testJSONEncoding changed from success to error
WMCore_t.BossAir_t.ARCPlugin_t.ARCPluginTest:testG_monitoringDAO changed from success to error
WMCore_t.Database_t.CMSCouch_t.CMSCouchTest:testUpdateHandler changed from success to error
WMCore_t.Database_t.CMSCouch_t.CMSCouchTest:testList changed from success to error
WMComponent_t.TaskArchiver_t.TaskArchiver_t.TaskArchiverTest:testDQMRecoPerformanceToDashBoard changed from success to error
WMCore_t.Cache_t.WMConfigCache_t.testWMConfigCache:testListAllConfigs changed from success to error
WMCore_t.Services_t.Requests_t.TestRequests:testSecureWithProxy changed from success to error
WMCore_t.WMSpec_t.StdSpecs_t.TaskChain_t.TaskChainTests:testMultipleGlobalTags changed from success to error
WMComponent_t.AlertGenerator_t.Pollers_t.Couch_t.CouchTest:testAlertGeneratorCouchDbSizePollerCriticalThreshold changed from success to failure
WMCore_t.WorkQueue_t.Policy_t.Start_t.Block_t.BlockTestCase:testIgnore0SizeBlocks changed from success to error
WMCore_t.JobStateMachine_t.ChangeState_t.TestChangeState:testJobSerialization changed from success to error
WMComponent_t.ErrorHandler_t.ErrorHandler_t.ErrorHandlerTest:testA_Create changed from failure to error
WMComponent_t.JobAccountant_t.JobAccountant_t.JobAccountantTest:testDBRollback changed from success to error
WMComponent_t.ErrorHandler_t.ErrorHandler_t.ErrorHandlerTest:testD_Exhausted changed from success to error
WMCore_t.Database_t.CMSCouch_t.CMSCouchTest:testDocumentSerialisation changed from success to error
WMCore_t.WMBS_t.JobSplitting_t.EventBased_t.EventBasedTest:test99EventSplit changed from success to error
WMCore_t.WMRuntime_t.DashboardInterface_t.DashboardInterfaceTest:testASuccessfulJobMonitoring changed from success to error
WMCore_t.WorkQueue_t.DataStructs_t.CouchWorkQueueElement_t.CouchWorkQueueElementTest:testIdSaved changed from success to error
WMCore_t.FwkJobReport_t.Report_t.ReportTest:testBadXMLParsing changed from success to error
WMCore_t.WorkQueue_t.Policy_t.Start_t.Block_t.BlockTestCase:testMultiTaskProcessingWorkload changed from success to error
WMComponent_t.JobSubmitter_t.JobSubmitter_t.JobSubmitterTest:testD_WhiteListBlackList changed from failure to error
WMCore_t.FwkJobReport_t.Report_t.ReportTest:testTaskSuccessful changed from success to error
WMCore_t.BossAir_t.gLitePlugin_t.BossAirTest:testG_monitoringDAO changed from success to error
WMCore_t.Services_t.RequestDB_t.RequestDB_t.RequestDBTest:testRequestDBWriter changed from success to error
WMCore_t.GroupUser_t.Group_t.Group_t:testA changed from success to error
WMCore_t.BossAir_t.ARCTest_t.BossAirTest:testG_monitoringDAO changed from success to error
WMComponent_t.RetryManager_t.RetryManager_t.RetryManagerTest:testC_Job changed from success to error
WMCore_t.Services_t.Requests_t.TestRequests:testSecureOddPort changed from success to error
WMCore_t.ACDC_t.CouchFileset_t.CouchFileset_t:testFileset changed from success to error
WMCore_t.WMSpec_t.StdSpecs_t.TaskChain_t.TaskChainTests:testGeneratorWorkflow changed from success to error
WMComponent_t.RetryManager_t.RetryManager_t.RetryManagerTest:testI_MultipleJobTypes changed from success to error
WMComponent_t.AlertGenerator_t.Pollers_t.Couch_t.CouchTest:testAlertGeneratorCouchErrorsPollerCriticalThreshold changed from success to failure
WMComponent_t.JobAccountant_t.JobAccountant_t.JobAccountantTest:testEmptyFWJR changed from success to error
WMCore_t.WMSpec_t.StdSpecs_t.StoreResults_t.StoreResultsTest:testStoreResults changed from success to error
WMComponent_t.AlertGenerator_t.Pollers_t.Couch_t.CouchTest:testAlertGeneratorCouchCPUPollerCriticalThreshold changed from success to failure
WMCore_t.ACDC_t.DataCollectionService_t.DataCollectionService_t:testChunking changed from success to error
WMComponent_t.JobAccountant_t.JobAccountant_t.JobAccountantTest:testMergeSuccess changed from success to error
WMCore_t.Alerts_t.ZMQ_t.Sinks_t.CouchSink_t.CouchSinkTest:testCouchSinkBasic changed from success to error
WMComponent_t.AlertGenerator_t.Pollers_t.Couch_t.CouchTest:testAlertGeneratorCouchMemoryPollerNoAlert changed from success to failure
WMCore_t.GroupUser_t.User_t.User_t:testB changed from success to error
WMCore_t.ACDC_t.DataCollectionService_t.DataCollectionService_t:testGetLumiWhitelist changed from success to error
WMCore_t.WMSpec_t.StdSpecs_t.MonteCarloFromGEN_t.MonteCarloFromGENTest:testMonteCarloFromGEN changed from success to error
WMCore_t.FwkJobReport_t.Report_t.ReportTest:testGetAdlerChecksum changed from success to error
WMCore_t.GroupUser_t.User_t.User_t:testA changed from success to error
WMComponent_t.AnalyticsDataCollector_t.Plugins_t.Tier0Plugin_t.Tier0PluginTest:testA_RepackStates changed from success to error
WMCore_t.WMSpec_t.StdSpecs_t.DQMHarvest_t.DQMHarvestTests:testDQMHarvestFailed changed from success to error

retest this please

Beginning pylint and unit tests.
See https://cmssdt.cern.ch/jenkins/job/DMWM-PR-test/353/ for details

Beginning pylint and unit tests.
See https://cmssdt.cern.ch/jenkins/job/DMWM-PR-test/354/ for details

Beginning pylint and unit tests.
See https://cmssdt.cern.ch/jenkins/job/DMWM-PR-test/355/ for details

Beginning pylint and unit tests.
See https://cmssdt.cern.ch/jenkins/job/DMWM-PR-test/356/ for details

Something in this patch make the cherry py hangs we have much more frequent. Do not merge it.

retest this please

Beginning pylint and unit tests.
See https://cmssdt.cern.ch/jenkins/job/DMWM-PR-test/357/ for details

retest this please

Beginning pylint and unit tests.
See https://cmssdt.cern.ch/jenkins/job/DMWM-PR-test/441/ for details

Summary of pylint changes for pull request 5845:

Score for src/python/WMCore/Services/Requests.py decreased from 9.75 to 9.72
Warnings for src/python/WMCore/Services/Requests.py increased from 5 to 6

src/python/WMCore/Services/Requests.py got worse in pylint. Report follows:

Line 27 W0702 No exception type(s) specified
Line 64 in Requests.init W0612 Unused variable 'pycurl'
Line 154 in Requests.makeRequest_pycurl W0613 Unused argument 'encoder'
Line 260 in Requests.makeRequest_httplib W0106 Expression "[conn.close() for conn in self['conn'].connections.values()]" is assigned to nothing
Line 175 in Requests.makeRequest_httplib R0912 Too many branches (14/12)
Line 289 in Requests.encode R0201 Method could be a function
Line 295 in Requests.decode R0201 Method could be a function
Line 371 in Requests._getURLOpener W0703 Catching too general exception Exception
Line 521 in Requests.downloadFile W0621 Redefining name 'ResponseHeader' from outer scope (line 36)
Line 50 in Requests R0904 Too many public methods (31/20)
Line 550 in JSONRequests R0904 Too many public methods (31/20)
Line 583 in TempDirectory R0903 Too few public methods (0/2)
plus 41 comments on code style

Pre-python 2.6 idioms found in changed files. Please consider updating the code. Suggested patch follows:
--- src/python/WMCore/Services/Requests.py (original)
+++ src/python/WMCore/Services/Requests.py (refactored)
@@ -220,7 +220,7 @@
             pass

         if verb != 'GET' and data:
-            if type(encoder) == type(self.get) or type(encoder) == type(f):
+            if isinstance(encoder, type(self.get)) or isinstance(encoder, type(f)):
                 encoded_data = encoder(data)
             elif encoder == False:
                 # Don't encode the data more than we have to
@@ -240,7 +240,7 @@

         headers["Content-length"] = str(len(encoded_data))

-        assert type(encoded_data) == type('string'), \
+        assert isinstance(encoded_data, type('string')), \
             "Data in makeRequest is %s and not encoded to a string" \
                 % type(encoded_data)

@@ -279,7 +279,7 @@
             setattr(e, 'headers', response)
             raise e

-        if type(decoder) == type(self.makeRequest) or type(decoder) == type(f):
+        if isinstance(decoder, type(self.makeRequest)) or isinstance(decoder, type(f)):
             result = decoder(result)
         elif decoder != False:
             result = self.decode(result)

Unit test changes for pull request 5845:

WMComponent_t.AlertGenerator_t.AlertGenerator_t.AlertGeneratorTest:testAllFinalClassPollerImplementations changed from success to error
WMComponent_t.AlertGenerator_t.Pollers_t.Couch_t.CouchTest:testAlertGeneratorCouchCPUPollerCriticalThreshold changed from success to failure
WMComponent_t.AlertGenerator_t.Pollers_t.Couch_t.CouchTest:testAlertGeneratorCouchCPUPollerNoAlert changed from success to failure
WMComponent_t.AlertGenerator_t.Pollers_t.Couch_t.CouchTest:testAlertGeneratorCouchCPUPollerSoftThreshold changed from success to failure
WMComponent_t.AlertGenerator_t.Pollers_t.Couch_t.CouchTest:testAlertGeneratorCouchDbSizePollerBasic changed from success to failure
WMComponent_t.AlertGenerator_t.Pollers_t.Couch_t.CouchTest:testAlertGeneratorCouchDbSizePollerCriticalThreshold changed from success to failure
WMComponent_t.AlertGenerator_t.Pollers_t.Couch_t.CouchTest:testAlertGeneratorCouchDbSizePollerNoAlert changed from success to failure
WMComponent_t.AlertGenerator_t.Pollers_t.Couch_t.CouchTest:testAlertGeneratorCouchDbSizePollerSoftThreshold changed from success to failure
WMComponent_t.AlertGenerator_t.Pollers_t.Couch_t.CouchTest:testAlertGeneratorCouchErrorsPollerBasic changed from success to failure
WMComponent_t.AlertGenerator_t.Pollers_t.Couch_t.CouchTest:testAlertGeneratorCouchErrorsPollerCriticalThreshold changed from success to failure
WMComponent_t.AlertGenerator_t.Pollers_t.Couch_t.CouchTest:testAlertGeneratorCouchErrorsPollerNoAlert changed from success to failure
WMComponent_t.AlertGenerator_t.Pollers_t.Couch_t.CouchTest:testAlertGeneratorCouchErrorsPollerSoftThreshold changed from success to failure
WMComponent_t.AlertGenerator_t.Pollers_t.Couch_t.CouchTest:testAlertGeneratorCouchMemoryPollerCriticalThreshold changed from success to failure
WMComponent_t.AlertGenerator_t.Pollers_t.Couch_t.CouchTest:testAlertGeneratorCouchMemoryPollerNoAlert changed from success to failure
WMComponent_t.AlertGenerator_t.Pollers_t.Couch_t.CouchTest:testAlertGeneratorCouchMemoryPollerSoftThreshold changed from success to failure
WMComponent_t.AlertGenerator_t.Pollers_t.Couch_t.CouchTest:testAlertGeneratorCouchPollerBasic changed from success to failure
WMComponent_t.AnalyticsDataCollector_t.Plugins_t.Tier0Plugin_t.Tier0PluginTest:testA_RepackStates changed from success to error
WMComponent_t.AnalyticsDataCollector_t.Plugins_t.Tier0Plugin_t.Tier0PluginTest:testB_ExpressStates changed from success to error
WMComponent_t.DBSUpload_t.DBSUploadPoller_t.DBSUploadTest:testG_closeSettingsPerWorkflow changed from failure to error
WMComponent_t.ErrorHandler_t.ErrorHandler_t.ErrorHandlerTest:testA_Create changed from failure to error
WMComponent_t.ErrorHandler_t.ErrorHandler_t.ErrorHandlerTest:testD_Exhausted changed from success to error
WMComponent_t.ErrorHandler_t.ErrorHandler_t.ErrorHandlerTest:testE_FailJobs changed from success to error
WMComponent_t.JobAccountant_t.JobAccountant_t.JobAccountantTest:testBadFWJR changed from success to error
WMComponent_t.JobAccountant_t.JobAccountant_t.JobAccountantTest:testDBRollback changed from success to error
WMComponent_t.JobAccountant_t.JobAccountant_t.JobAccountantTest:testEmptyFWJR changed from success to error
WMComponent_t.JobAccountant_t.JobAccountant_t.JobAccountantTest:testFailedJob changed from success to error
WMComponent_t.JobAccountant_t.JobAccountant_t.JobAccountantTest:testMergeSuccess changed from success to error
WMComponent_t.JobAccountant_t.JobAccountant_t.JobAccountantTest:testMergeSuccessNoLumi changed from success to error
WMComponent_t.JobAccountant_t.JobAccountant_t.JobAccountantTest:testMergeSuccessSkippedFiles changed from success to error
WMComponent_t.JobAccountant_t.JobAccountant_t.JobAccountantTest:testMergedSkim changed from success to error
WMComponent_t.JobAccountant_t.JobAccountant_t.JobAccountantTest:testNoFileReport changed from success to error
WMComponent_t.JobAccountant_t.JobAccountant_t.JobAccountantTest:testParentlessMergeSuccess changed from success to error
WMComponent_t.JobAccountant_t.JobAccountant_t.JobAccountantTest:testReportReturn changed from success to error
WMComponent_t.JobAccountant_t.JobAccountant_t.JobAccountantTest:testSplitJobs changed from success to error
WMComponent_t.JobAccountant_t.JobAccountant_t.JobAccountantTest:testZ1_BigHeritage changed from success to error
WMComponent_t.JobSubmitter_t.JobSubmitter_t.JobSubmitterTest:testB_thresholdTest changed from success to error
WMComponent_t.TaskArchiver_t.TaskArchiver_t.TaskArchiverTest:testC_Profile changed from success to error
WMComponent_t.TaskArchiver_t.TaskArchiver_t.TaskArchiverTest:testDQMRecoPerformanceToDashBoard changed from success to error
WMComponent_t.TaskArchiver_t.TaskArchiver_t.TaskArchiverTest:testD_Timing changed from success to error
WMComponent_t.TaskArchiver_t.TaskArchiver_t.TaskArchiverTest:testTaskArchiverPollerAlertsSending_killSubscriptions changed from success to error
WMComponent_t.TaskArchiver_t.TaskArchiver_t.TaskArchiverTest:testTaskArchiverPollerAlertsSending_notifyWorkQueue changed from success to error
WMCore_t.ACDC_t.CouchCollection_t.CouchCollection_t:testCreatePopulateDrop changed from success to error
WMCore_t.ACDC_t.CouchFileset_t.CouchFileset_t:testDropCount changed from success to error
WMCore_t.ACDC_t.CouchFileset_t.CouchFileset_t:testFileset changed from success to error
WMCore_t.ACDC_t.CouchFileset_t.CouchFileset_t:testListFiles changed from success to error
WMCore_t.ACDC_t.CouchService_t.CouchService_t:testListCollectionsFilesets changed from success to error
WMCore_t.ACDC_t.CouchService_t.CouchService_t:testOwners changed from failure to error
WMCore_t.ACDC_t.CouchService_t.CouchService_t:testTimestampAccounting changed from success to error
WMCore_t.ACDC_t.DataCollectionService_t.DataCollectionService_t:testChunking changed from success to error
WMCore_t.ACDC_t.DataCollectionService_t.DataCollectionService_t:testGetLumiWhitelist changed from success to error
WMCore_t.Agent_t.HarnessCouchBackend_t.HarnessCouchBackend_t:testAddComponent changed from success to error
WMCore_t.Agent_t.HarnessCouchBackend_t.HarnessCouchBackend_t:testAddWorker changed from success to error
WMCore_t.Alerts_t.ZMQ_t.Sinks_t.CouchSink_t.CouchSinkTest:testCouchSinkBasic changed from success to error
WMCore_t.Alerts_t.ZMQ_t.Sinks_t.RESTSink_t.RESTSinkTest:testRESTSinkBasic changed from success to error
WMCore_t.Cache_t.WMConfigCache_t.testWMConfigCache:testA_basicConfig changed from success to error
WMCore_t.Cache_t.WMConfigCache_t.testWMConfigCache:testB_addingConfigsAndTweaks changed from success to error
WMCore_t.Cache_t.WMConfigCache_t.testWMConfigCache:testC_testViews changed from success to error
WMCore_t.Cache_t.WMConfigCache_t.testWMConfigCache:testD_LoadConfigCache changed from success to error
WMCore_t.Cache_t.WMConfigCache_t.testWMConfigCache:testE_SaveConfigFileToDisk changed from success to error
WMCore_t.Cache_t.WMConfigCache_t.testWMConfigCache:testListAllConfigs changed from success to error
WMCore_t.DataStructs_t.MathStructs_t.ContinuousSummaryHistogram_t.ContinuousSummaryHistogramTest:testA_BasicTest changed from success to error
WMCore_t.DataStructs_t.MathStructs_t.DiscreteSummaryHistogram_t.DiscreteSummaryHistogramTest:testA_BasicTest changed from success to error
WMCore_t.Database_t.CMSCouch_t.CMSCouchTest:testAllDocs changed from success to error
WMCore_t.Database_t.CMSCouch_t.CMSCouchTest:testAttachments changed from success to error
WMCore_t.Database_t.CMSCouch_t.CMSCouchTest:testCommit changed from error to failure
WMCore_t.Database_t.CMSCouch_t.CMSCouchTest:testCommitOne changed from success to error
WMCore_t.Database_t.CMSCouch_t.CMSCouchTest:testCommitOneWithQueue changed from success to error
WMCore_t.Database_t.CMSCouch_t.CMSCouchTest:testDeleteDoc changed from success to error
WMCore_t.Database_t.CMSCouch_t.CMSCouchTest:testDeleteQueuedDocs changed from success to error
WMCore_t.Database_t.CMSCouch_t.CMSCouchTest:testDocumentSerialisation changed from success to error
WMCore_t.Database_t.CMSCouch_t.CMSCouchTest:testSlashInDBName changed from success to error
WMCore_t.Database_t.CMSCouch_t.CMSCouchTest:testTimeStamping changed from success to error
WMCore_t.Database_t.CMSCouch_t.CMSCouchTest:testUpdateHandler changed from success to error
WMCore_t.Database_t.RotatingDatabase_t.RotatingDatabaseTest:testArchive changed from success to error
WMCore_t.Database_t.RotatingDatabase_t.RotatingDatabaseTest:testExpire changed from success to error
WMCore_t.Database_t.RotatingDatabase_t.RotatingDatabaseTest:testRotate changed from success to failure
WMCore_t.FwkJobReport_t.ReportEmu_t.ReportEmuTest:testMerge changed from success to error
WMCore_t.FwkJobReport_t.ReportEmu_t.ReportEmuTest:testProcessing changed from success to error
WMCore_t.GroupUser_t.CouchObject_t.CouchObject_t:testB changed from success to error
WMCore_t.GroupUser_t.Group_t.Group_t:testA changed from success to error
WMCore_t.GroupUser_t.Interface_t.Interface_t:testA changed from success to error
WMCore_t.GroupUser_t.User_t.User_t:testA changed from success to error
WMCore_t.GroupUser_t.User_t.User_t:testB changed from success to error
WMCore_t.JobSplitting_t.Generators_t.ReproducibleSeeding_t.ReproducibleSeedingTests:testA changed from success to error
WMCore_t.JobStateMachine_t.ChangeState_t.TestChangeState:testDuplicateJobReports changed from success to error
WMCore_t.JobStateMachine_t.ChangeState_t.TestChangeState:testFWJRInputFileTruncation changed from success to error
WMCore_t.JobStateMachine_t.ChangeState_t.TestChangeState:testIndexConflict changed from success to error
WMCore_t.JobStateMachine_t.ChangeState_t.TestChangeState:testJobSerialization changed from success to error
WMCore_t.JobStateMachine_t.ChangeState_t.TestChangeState:testJobSummary changed from success to error
WMCore_t.JobStateMachine_t.ChangeState_t.TestChangeState:testRecordInCouch changed from success to error
WMCore_t.JobStateMachine_t.ChangeState_t.TestChangeState:testUpdateFailedDoc changed from success to error
WMCore_t.JobStateMachine_t.ChangeState_t.TestChangeState:testUpdateLocation changed from success to error
WMCore_t.JobStateMachine_t.Couchapp_t.CouchappTest:testHighestJobID changed from success to error
WMCore_t.Services_t.DBS_t.DBSReader_t.DBSReaderTest:testGetFileBlock changed from success to error
WMCore_t.Services_t.DBS_t.DBSReader_t.DBSReaderTest:testGetFileBlockWithParents changed from success to error
WMCore_t.Services_t.DBS_t.DBSReader_t.DBSReaderTest:testGetFiles changed from success to error
WMCore_t.Services_t.DBS_t.DBSReader_t.DBSReaderTest:testListBlockParents changed from success to error
WMCore_t.Services_t.Registration_t.Registration_t.RegistrationTest:testPush changed from success to error
WMCore_t.Services_t.RequestDB_t.RequestDB_t.RequestDBTest:testRequestDBWriter changed from success to failure
WMCore_t.Services_t.RequestDB_t.T0RequestDB_t.T0RequestDBTest:testRequestDBWriter changed from success to failure
WMCore_t.Services_t.Requests_t.TestRequests:testSecureNoAuth changed from success to error
WMCore_t.Services_t.Requests_t.TestRequests:testSecureOddPort changed from success to error
WMCore_t.Services_t.Requests_t.TestRequests:testSecureWithProxy changed from success to error
WMCore_t.Services_t.WMStats_t.WMStats_t.WMStatsTest:testWMStatsWriter changed from success to error
WMCore_t.WMBS_t.JobSplitting_t.LumiBased_t.LumiBasedTest:testC_ACDCTest changed from success to error
WMCore_t.WMLogging_t.WMLoggingTest:testLog changed from success to error
WMCore_t.WMRuntime_t.DashboardInterface_t.DashboardInterfaceTest:testAFailedJobMonitoring changed from success to error
WMCore_t.WMRuntime_t.DashboardInterface_t.DashboardInterfaceTest:testAKilledJobMonitoring changed from success to error
WMCore_t.WMRuntime_t.DashboardInterface_t.DashboardInterfaceTest:testASuccessfulJobMonitoring changed from success to error
WMCore_t.WMRuntime_t.DashboardInterface_t.DashboardInterfaceTest:testMultithreadedApplication changed from success to error
WMCore_t.WMSpec_t.StdSpecs_t.Analysis_t.AnalysisTest:testAnalysis changed from success to error
WMCore_t.WMSpec_t.StdSpecs_t.DQMHarvest_t.DQMHarvestTests:testDQMHarvest changed from success to error
WMCore_t.WMSpec_t.StdSpecs_t.DQMHarvest_t.DQMHarvestTests:testDQMHarvestFailed changed from success to error
WMCore_t.WMSpec_t.StdSpecs_t.MonteCarloFromGEN_t.MonteCarloFromGENTest:testMonteCarloFromGEN changed from success to error
WMCore_t.WMSpec_t.StdSpecs_t.MonteCarlo_t.MonteCarloTest:testMCWithLHE changed from success to error
WMCore_t.WMSpec_t.StdSpecs_t.MonteCarlo_t.MonteCarloTest:testMCWithPileup changed from success to error
WMCore_t.WMSpec_t.StdSpecs_t.MonteCarlo_t.MonteCarloTest:testMonteCarlo changed from success to error
WMCore_t.WMSpec_t.StdSpecs_t.MonteCarlo_t.MonteCarloTest:testMonteCarloExtension changed from success to error
WMCore_t.WMSpec_t.StdSpecs_t.PrivateMC_t.PrivateMCTest:testPrivateMC changed from success to error
WMCore_t.WMSpec_t.StdSpecs_t.ReDigi_t.ReDigiTest:testChainedReDigi changed from success to error
WMCore_t.WMSpec_t.StdSpecs_t.ReDigi_t.ReDigiTest:testCombinedReDigiRecoConfig changed from success to error
WMCore_t.WMSpec_t.StdSpecs_t.ReDigi_t.ReDigiTest:testDependentReDigi changed from success to error
WMCore_t.WMSpec_t.StdSpecs_t.ReDigi_t.ReDigiTest:testSingleStepReDigi changed from success to error
WMCore_t.WMSpec_t.StdSpecs_t.ReDigi_t.ReDigiTest:testThreeStepChainedReDigi changed from success to error
WMCore_t.WMSpec_t.StdSpecs_t.ReReco_t.ReRecoTest:testReReco changed from success to error
WMCore_t.WMSpec_t.StdSpecs_t.ReReco_t.ReRecoTest:testReRecoDroppingRECO changed from success to error
WMCore_t.WMSpec_t.StdSpecs_t.StepChain_t.StepChainTests:testStepChainMC changed from success to error
WMCore_t.WMSpec_t.StdSpecs_t.StepChain_t.StepChainTests:testStepChainSingleStep changed from success to error
WMCore_t.WMSpec_t.StdSpecs_t.StoreResults_t.StoreResultsTest:testStoreResults changed from success to error
WMCore_t.WMSpec_t.StdSpecs_t.TaskChain_t.TaskChainTests:testGeneratorWorkflow changed from success to error
WMCore_t.WMSpec_t.StdSpecs_t.TaskChain_t.TaskChainTests:testMultipleGlobalTags changed from success to error
WMCore_t.WMSpec_t.StdSpecs_t.TaskChain_t.TaskChainTests:testMultithreadedTaskChain changed from success to error
WMCore_t.WMSpec_t.StdSpecs_t.TaskChain_t.TaskChainTests:testMultithreadedTasksTaskChain changed from success to error
WMCore_t.WMSpec_t.Steps_t.Fetchers_t.CMSSWFetcher_t.URLFetcherTest:testA_BasicFunction changed from success to error
WMCore_t.WMSpec_t.Steps_t.Fetchers_t.PileupFetcher_t.PileupFetcherTest:testPileupFetcherOnMC changed from success to error
WMCore_t.WMSpec_t.Steps_t.Fetchers_t.URLFetcher_t.URLFetcherTest:testA_BasicFunction changed from success to error
WMCore_t.WorkQueue_t.DataStructs_t.CouchWorkQueueElement_t.CouchWorkQueueElementTest:testIdFromDbImmutable changed from success to error
WMCore_t.WorkQueue_t.DataStructs_t.CouchWorkQueueElement_t.CouchWorkQueueElementTest:testIdSaved changed from success to error
WMCore_t.WorkQueue_t.Policy_t.Start_t.Block_t.BlockTestCase:testContinuousSplittingSupport changed from success to error
WMCore_t.WorkQueue_t.Policy_t.Start_t.Block_t.BlockTestCase:testDataDirectiveFromQueue changed from success to error
WMCore_t.WorkQueue_t.Policy_t.Start_t.Block_t.BlockTestCase:testDatasetLocation changed from success to error
WMCore_t.WorkQueue_t.Policy_t.Start_t.Block_t.BlockTestCase:testGetMaskedBlocks changed from success to error
WMCore_t.WorkQueue_t.Policy_t.Start_t.Block_t.BlockTestCase:testIgnore0SizeBlocks changed from success to error
WMCore_t.WorkQueue_t.Policy_t.Start_t.Block_t.BlockTestCase:testInvalidSpecs changed from success to error
WMCore_t.WorkQueue_t.Policy_t.Start_t.Block_t.BlockTestCase:testLumiSplitTier1ReRecoWorkload changed from success to error
WMCore_t.WorkQueue_t.Policy_t.Start_t.Block_t.BlockTestCase:testMultiTaskProcessingWorkload changed from success to error
WMCore_t.WorkQueue_t.Policy_t.Start_t.Block_t.BlockTestCase:testPileupData changed from success to error
WMCore_t.WorkQueue_t.Policy_t.Start_t.Block_t.BlockTestCase:testRunWhitelist changed from success to error
WMCore_t.WorkQueue_t.Policy_t.Start_t.Block_t.BlockTestCase:testTier1ReRecoWorkload changed from success to error
WMCore_t.WorkQueue_t.Policy_t.Start_t.Block_t.BlockTestCase:testWhiteBlackLists changed from failure to error
WMCore_t.WorkQueue_t.Policy_t.Start_t.Block_t.BlockTestCase:testWithMaskedBlocks changed from success to error
WMCore_t.WorkQueue_t.Policy_t.Start_t.Dataset_t.DatasetTestCase:testLumiSplitTier1ReRecoWorkload changed from success to error
WMCore_t.WorkQueue_t.Policy_t.Start_t.Dataset_t.DatasetTestCase:testParentProcessing changed from failure to error
WMCore_t.WorkQueue_t.Policy_t.Start_t.Dataset_t.DatasetTestCase:testRunWhitelist changed from success to error
WMCore_t.WorkQueue_t.Policy_t.Start_t.MonteCarlo_t.MonteCarloTestCase:testLHEProductionWorkload changed from failure to success
WMCore_t.WorkQueue_t.Policy_t.Start_t.MonteCarlo_t.MonteCarloTestCase:testShiftedStartSplitting changed from failure to success
WMCore_t.WorkQueue_t.Policy_t.Start_t.ResubmitBlock_t.ResubmitBlockTest:testEmptyACDC changed from success to error
WMCore_t.WorkQueue_t.Policy_t.Start_t.ResubmitBlock_t.ResubmitBlockTest:testUnsupportedACDC changed from success to error
WMCore_t.WorkQueue_t.WMBSHelper_t.WMBSHelperTest:testCreateSubscription changed from success to error
WMCore_t.WorkQueue_t.WMBSHelper_t.WMBSHelperTest:testKillWorkflow changed from success to error
WMCore_t.WorkQueue_t.WMBSHelper_t.WMBSHelperTest:testTruncatedWFInsertion changed from success to error
WMCore_t.WorkQueue_t.WorkQueueBackend_t.WorkQueueBackendTest:testDuplicateInsertion changed from success to error
WMCore_t.WorkQueue_t.WorkQueueBackend_t.WorkQueueBackendTest:testPriority changed from success to error

retest this please

Beginning pylint and unit tests.
See https://cmssdt.cern.ch/jenkins/job/DMWM-PR-test/465/ for details

Summary of pylint changes for pull request 5845:

Score for src/python/WMCore/Services/Requests.py decreased from 9.75 to 9.72
Warnings for src/python/WMCore/Services/Requests.py increased from 5 to 6

src/python/WMCore/Services/Requests.py got worse in pylint. Report follows:

Line 27 W0702 No exception type(s) specified
Line 64 in Requests.init W0612 Unused variable 'pycurl'
Line 154 in Requests.makeRequest_pycurl W0613 Unused argument 'encoder'
Line 260 in Requests.makeRequest_httplib W0106 Expression "[conn.close() for conn in self['conn'].connections.values()]" is assigned to nothing
Line 175 in Requests.makeRequest_httplib R0912 Too many branches (14/12)
Line 289 in Requests.encode R0201 Method could be a function
Line 295 in Requests.decode R0201 Method could be a function
Line 371 in Requests._getURLOpener W0703 Catching too general exception Exception
Line 521 in Requests.downloadFile W0621 Redefining name 'ResponseHeader' from outer scope (line 36)
Line 50 in Requests R0904 Too many public methods (31/20)
Line 550 in JSONRequests R0904 Too many public methods (31/20)
Line 583 in TempDirectory R0903 Too few public methods (0/2)
plus 41 comments on code style

Pre-python 2.6 idioms found in changed files. Please consider updating the code. Suggested patch follows:
--- src/python/WMCore/Services/Requests.py (original)
+++ src/python/WMCore/Services/Requests.py (refactored)
@@ -220,7 +220,7 @@
             pass

         if verb != 'GET' and data:
-            if type(encoder) == type(self.get) or type(encoder) == type(f):
+            if isinstance(encoder, type(self.get)) or isinstance(encoder, type(f)):
                 encoded_data = encoder(data)
             elif encoder == False:
                 # Don't encode the data more than we have to
@@ -240,7 +240,7 @@

         headers["Content-length"] = str(len(encoded_data))

-        assert type(encoded_data) == type('string'), \
+        assert isinstance(encoded_data, type('string')), \
             "Data in makeRequest is %s and not encoded to a string" \
                 % type(encoded_data)

@@ -279,7 +279,7 @@
             setattr(e, 'headers', response)
             raise e

-        if type(decoder) == type(self.makeRequest) or type(decoder) == type(f):
+        if isinstance(decoder, type(self.makeRequest)) or isinstance(decoder, type(f)):
             result = decoder(result)
         elif decoder != False:
             result = self.decode(result)

Unit test changes for pull request 5845:

WMComponent_t.AlertGenerator_t.AlertGenerator_t.AlertGeneratorTest:testAllFinalClassPollerImplementations changed from success to error
WMComponent_t.AlertGenerator_t.Pollers_t.Couch_t.CouchTest:testAlertGeneratorCouchCPUPollerCriticalThreshold changed from success to failure
WMComponent_t.AlertGenerator_t.Pollers_t.Couch_t.CouchTest:testAlertGeneratorCouchCPUPollerNoAlert changed from success to failure
WMComponent_t.AlertGenerator_t.Pollers_t.Couch_t.CouchTest:testAlertGeneratorCouchCPUPollerSoftThreshold changed from success to failure
WMComponent_t.AlertGenerator_t.Pollers_t.Couch_t.CouchTest:testAlertGeneratorCouchDbSizePollerBasic changed from success to failure
WMComponent_t.AlertGenerator_t.Pollers_t.Couch_t.CouchTest:testAlertGeneratorCouchDbSizePollerCriticalThreshold changed from success to failure
WMComponent_t.AlertGenerator_t.Pollers_t.Couch_t.CouchTest:testAlertGeneratorCouchDbSizePollerNoAlert changed from success to failure
WMComponent_t.AlertGenerator_t.Pollers_t.Couch_t.CouchTest:testAlertGeneratorCouchDbSizePollerSoftThreshold changed from success to failure
WMComponent_t.AlertGenerator_t.Pollers_t.Couch_t.CouchTest:testAlertGeneratorCouchErrorsPollerBasic changed from success to failure
WMComponent_t.AlertGenerator_t.Pollers_t.Couch_t.CouchTest:testAlertGeneratorCouchErrorsPollerCriticalThreshold changed from success to failure
WMComponent_t.AlertGenerator_t.Pollers_t.Couch_t.CouchTest:testAlertGeneratorCouchErrorsPollerNoAlert changed from success to failure
WMComponent_t.AlertGenerator_t.Pollers_t.Couch_t.CouchTest:testAlertGeneratorCouchErrorsPollerSoftThreshold changed from success to failure
WMComponent_t.AlertGenerator_t.Pollers_t.Couch_t.CouchTest:testAlertGeneratorCouchMemoryPollerCriticalThreshold changed from success to failure
WMComponent_t.AlertGenerator_t.Pollers_t.Couch_t.CouchTest:testAlertGeneratorCouchMemoryPollerNoAlert changed from success to failure
WMComponent_t.AlertGenerator_t.Pollers_t.Couch_t.CouchTest:testAlertGeneratorCouchMemoryPollerSoftThreshold changed from success to failure
WMComponent_t.AlertGenerator_t.Pollers_t.Couch_t.CouchTest:testAlertGeneratorCouchPollerBasic changed from success to failure
WMComponent_t.DBSUpload_t.DBSUploadPoller_t.DBSUploadTest:testG_closeSettingsPerWorkflow changed from failure to error
WMComponent_t.ErrorHandler_t.ErrorHandler_t.ErrorHandlerTest:testA_Create changed from failure to error
WMComponent_t.ErrorHandler_t.ErrorHandler_t.ErrorHandlerTest:testD_Exhausted changed from success to error
WMComponent_t.ErrorHandler_t.ErrorHandler_t.ErrorHandlerTest:testE_FailJobs changed from success to error
WMComponent_t.JobAccountant_t.JobAccountant_t.JobAccountantTest:testBadFWJR changed from success to error
WMComponent_t.JobAccountant_t.JobAccountant_t.JobAccountantTest:testDBRollback changed from success to error
WMComponent_t.JobAccountant_t.JobAccountant_t.JobAccountantTest:testEmptyFWJR changed from success to error
WMComponent_t.JobAccountant_t.JobAccountant_t.JobAccountantTest:testFailedJob changed from success to error
WMComponent_t.JobAccountant_t.JobAccountant_t.JobAccountantTest:testMergeSuccess changed from success to error
WMComponent_t.JobAccountant_t.JobAccountant_t.JobAccountantTest:testMergeSuccessNoLumi changed from success to error
WMComponent_t.JobAccountant_t.JobAccountant_t.JobAccountantTest:testMergeSuccessSkippedFiles changed from success to error
WMComponent_t.JobAccountant_t.JobAccountant_t.JobAccountantTest:testMergedSkim changed from success to error
WMComponent_t.JobAccountant_t.JobAccountant_t.JobAccountantTest:testNoFileReport changed from success to error
WMComponent_t.JobAccountant_t.JobAccountant_t.JobAccountantTest:testParentlessMergeSuccess changed from success to error
WMComponent_t.JobAccountant_t.JobAccountant_t.JobAccountantTest:testReportReturn changed from success to error
WMComponent_t.JobAccountant_t.JobAccountant_t.JobAccountantTest:testSplitJobs changed from success to error
WMCore_t.ACDC_t.CouchCollection_t.CouchCollection_t:testCreatePopulateDrop changed from success to error
WMCore_t.ACDC_t.CouchFileset_t.CouchFileset_t:testDropCount changed from success to error
WMCore_t.ACDC_t.CouchFileset_t.CouchFileset_t:testFileset changed from success to error
WMCore_t.ACDC_t.CouchFileset_t.CouchFileset_t:testListFiles changed from success to error
WMCore_t.ACDC_t.CouchService_t.CouchService_t:testListCollectionsFilesets changed from success to error
WMCore_t.ACDC_t.CouchService_t.CouchService_t:testOwners changed from failure to error
WMCore_t.ACDC_t.CouchService_t.CouchService_t:testTimestampAccounting changed from success to error
WMCore_t.ACDC_t.DataCollectionService_t.DataCollectionService_t:testChunking changed from success to error
WMCore_t.ACDC_t.DataCollectionService_t.DataCollectionService_t:testGetLumiWhitelist changed from success to error
WMCore_t.Alerts_t.ZMQ_t.Sinks_t.CouchSink_t.CouchSinkTest:testCouchSinkBasic changed from success to error
WMCore_t.Alerts_t.ZMQ_t.Sinks_t.RESTSink_t.RESTSinkTest:testRESTSinkBasic changed from success to error
WMCore_t.Cache_t.WMConfigCache_t.testWMConfigCache:testA_basicConfig changed from success to error
WMCore_t.Cache_t.WMConfigCache_t.testWMConfigCache:testB_addingConfigsAndTweaks changed from success to error
WMCore_t.Cache_t.WMConfigCache_t.testWMConfigCache:testC_testViews changed from success to error
WMCore_t.Cache_t.WMConfigCache_t.testWMConfigCache:testD_LoadConfigCache changed from success to error
WMCore_t.Cache_t.WMConfigCache_t.testWMConfigCache:testE_SaveConfigFileToDisk changed from success to error
WMCore_t.Cache_t.WMConfigCache_t.testWMConfigCache:testListAllConfigs changed from success to error
WMCore_t.Database_t.CMSCouch_t.CMSCouchTest:testAttachments changed from success to error
WMCore_t.Database_t.RotatingDatabase_t.RotatingDatabaseTest:testArchive changed from success to failure
WMCore_t.FwkJobReport_t.ReportEmu_t.ReportEmuTest:testMerge changed from success to error
WMCore_t.FwkJobReport_t.ReportEmu_t.ReportEmuTest:testProcessing changed from success to error
WMCore_t.GroupUser_t.CouchObject_t.CouchObject_t:testB changed from success to error
WMCore_t.GroupUser_t.Group_t.Group_t:testA changed from success to error
WMCore_t.GroupUser_t.Interface_t.Interface_t:testA changed from success to error
WMCore_t.GroupUser_t.User_t.User_t:testA changed from success to error
WMCore_t.GroupUser_t.User_t.User_t:testB changed from success to error
WMCore_t.JobStateMachine_t.ChangeState_t.TestChangeState:testDuplicateJobReports changed from success to failure
WMCore_t.JobStateMachine_t.ChangeState_t.TestChangeState:testFWJRInputFileTruncation changed from success to failure
WMCore_t.JobStateMachine_t.ChangeState_t.TestChangeState:testIndexConflict changed from success to failure
WMCore_t.JobStateMachine_t.ChangeState_t.TestChangeState:testJobSerialization changed from success to failure
WMCore_t.JobStateMachine_t.ChangeState_t.TestChangeState:testJobSummary changed from success to failure
WMCore_t.JobStateMachine_t.ChangeState_t.TestChangeState:testUpdateFailedDoc changed from success to error
WMCore_t.JobStateMachine_t.ChangeState_t.TestChangeState:testUpdateLocation changed from success to failure
WMCore_t.Services_t.DBS_t.DBSReader_t.DBSReaderTest:testGetFileBlock changed from success to error
WMCore_t.Services_t.DBS_t.DBSReader_t.DBSReaderTest:testGetFileBlockWithParents changed from success to error
WMCore_t.Services_t.DBS_t.DBSReader_t.DBSReaderTest:testGetFiles changed from success to error
WMCore_t.Services_t.DBS_t.DBSReader_t.DBSReaderTest:testListBlockParents changed from success to error
WMCore_t.Services_t.Registration_t.Registration_t.RegistrationTest:testPush changed from success to error
WMCore_t.Services_t.Requests_t.TestRequests:testSecureNoAuth changed from success to error
WMCore_t.Services_t.Requests_t.TestRequests:testSecureOddPort changed from success to error
WMCore_t.Services_t.Requests_t.TestRequests:testSecureWithProxy changed from success to error
WMCore_t.Services_t.Requests_t.TestRequests:testSecureWithProxy_with_pycurl changed from error to success
WMCore_t.WMBS_t.JobSplitting_t.LumiBased_t.LumiBasedTest:testC_ACDCTest changed from success to error
WMCore_t.WMRuntime_t.DashboardInterface_t.DashboardInterfaceTest:testAFailedJobMonitoring changed from success to error
WMCore_t.WMRuntime_t.DashboardInterface_t.DashboardInterfaceTest:testAKilledJobMonitoring changed from success to error
WMCore_t.WMRuntime_t.DashboardInterface_t.DashboardInterfaceTest:testASuccessfulJobMonitoring changed from success to error
WMCore_t.WMRuntime_t.DashboardInterface_t.DashboardInterfaceTest:testMultithreadedApplication changed from success to error
WMCore_t.WMSpec_t.StdSpecs_t.Analysis_t.AnalysisTest:testAnalysis changed from success to error
WMCore_t.WMSpec_t.StdSpecs_t.DQMHarvest_t.DQMHarvestTests:testDQMHarvest changed from success to error
WMCore_t.WMSpec_t.StdSpecs_t.MonteCarloFromGEN_t.MonteCarloFromGENTest:testMonteCarloFromGEN changed from success to error
WMCore_t.WMSpec_t.StdSpecs_t.PrivateMC_t.PrivateMCTest:testPrivateMC changed from success to error
WMCore_t.WMSpec_t.StdSpecs_t.ReDigi_t.ReDigiTest:testChainedReDigi changed from success to error
WMCore_t.WMSpec_t.StdSpecs_t.ReDigi_t.ReDigiTest:testCombinedReDigiRecoConfig changed from success to error
WMCore_t.WMSpec_t.StdSpecs_t.ReDigi_t.ReDigiTest:testDependentReDigi changed from success to error
WMCore_t.WMSpec_t.StdSpecs_t.ReDigi_t.ReDigiTest:testSingleStepReDigi changed from success to error
WMCore_t.WMSpec_t.StdSpecs_t.ReDigi_t.ReDigiTest:testThreeStepChainedReDigi changed from success to error
WMCore_t.WMSpec_t.StdSpecs_t.ReReco_t.ReRecoTest:testReReco changed from success to error
WMCore_t.WMSpec_t.StdSpecs_t.ReReco_t.ReRecoTest:testReRecoDroppingRECO changed from success to error
WMCore_t.WMSpec_t.StdSpecs_t.StoreResults_t.StoreResultsTest:testStoreResults changed from success to error
WMCore_t.WMSpec_t.Steps_t.Fetchers_t.CMSSWFetcher_t.URLFetcherTest:testA_BasicFunction changed from success to error
WMCore_t.WMSpec_t.Steps_t.Fetchers_t.URLFetcher_t.URLFetcherTest:testA_BasicFunction changed from success to error
WMCore_t.WorkQueue_t.DataStructs_t.CouchWorkQueueElement_t.CouchWorkQueueElementTest:testIdSaved changed from success to error
WMCore_t.WorkQueue_t.Policy_t.Start_t.Block_t.BlockTestCase:testContinuousSplittingSupport changed from success to error
WMCore_t.WorkQueue_t.Policy_t.Start_t.Block_t.BlockTestCase:testDataDirectiveFromQueue changed from success to error
WMCore_t.WorkQueue_t.Policy_t.Start_t.Block_t.BlockTestCase:testDatasetLocation changed from success to error
WMCore_t.WorkQueue_t.Policy_t.Start_t.Block_t.BlockTestCase:testGetMaskedBlocks changed from success to error
WMCore_t.WorkQueue_t.Policy_t.Start_t.Block_t.BlockTestCase:testIgnore0SizeBlocks changed from success to error
WMCore_t.WorkQueue_t.Policy_t.Start_t.Block_t.BlockTestCase:testInvalidSpecs changed from success to error
WMCore_t.WorkQueue_t.Policy_t.Start_t.Block_t.BlockTestCase:testLumiSplitTier1ReRecoWorkload changed from success to error
WMCore_t.WorkQueue_t.Policy_t.Start_t.Block_t.BlockTestCase:testMultiTaskProcessingWorkload changed from success to error
WMCore_t.WorkQueue_t.Policy_t.Start_t.Block_t.BlockTestCase:testPileupData changed from success to error
WMCore_t.WorkQueue_t.Policy_t.Start_t.Block_t.BlockTestCase:testRunWhitelist changed from success to error
WMCore_t.WorkQueue_t.Policy_t.Start_t.Block_t.BlockTestCase:testTier1ReRecoWorkload changed from success to error
WMCore_t.WorkQueue_t.Policy_t.Start_t.Block_t.BlockTestCase:testWhiteBlackLists changed from failure to error
WMCore_t.WorkQueue_t.Policy_t.Start_t.Block_t.BlockTestCase:testWithMaskedBlocks changed from success to error
WMCore_t.WorkQueue_t.Policy_t.Start_t.Dataset_t.DatasetTestCase:testLumiSplitTier1ReRecoWorkload changed from success to error
WMCore_t.WorkQueue_t.Policy_t.Start_t.Dataset_t.DatasetTestCase:testParentProcessing changed from failure to error
WMCore_t.WorkQueue_t.Policy_t.Start_t.Dataset_t.DatasetTestCase:testRunWhitelist changed from success to error
WMCore_t.WorkQueue_t.Policy_t.Start_t.ResubmitBlock_t.ResubmitBlockTest:testEmptyACDC changed from success to error
WMCore_t.WorkQueue_t.Policy_t.Start_t.ResubmitBlock_t.ResubmitBlockTest:testUnsupportedACDC changed from success to error
WMCore_t.WorkQueue_t.WMBSHelper_t.WMBSHelperTest:testCreateSubscription changed from success to error
WMCore_t.WorkQueue_t.WMBSHelper_t.WMBSHelperTest:testKillWorkflow changed from success to error
WMCore_t.WorkQueue_t.WMBSHelper_t.WMBSHelperTest:testTruncatedWFInsertion changed from success to error
WMCore_t.WorkQueue_t.WorkQueueBackend_t.WorkQueueBackendTest:testDuplicateInsertion changed from success to error
WMCore_t.WorkQueue_t.WorkQueueBackend_t.WorkQueueBackendTest:testPriority changed from success to error

Seangchan, could you please apply final set of changes from https://github.com/dmwm/WMCore/pull/6205 and re-test this PR with them.

retest this please

Beginning pylint and unit tests.
See https://cmssdt.cern.ch/jenkins/job/DMWM-PR-test/500/ for details

Summary of pylint changes for pull request 5845:

Score for src/python/WMCore/Services/Requests.py decreased from 9.75 to 9.72
Warnings for src/python/WMCore/Services/Requests.py increased from 5 to 6

src/python/WMCore/Services/Requests.py got worse in pylint. Report follows:

Line 27 W0702 No exception type(s) specified
Line 64 in Requests.init W0612 Unused variable 'pycurl'
Line 154 in Requests.makeRequest_pycurl W0613 Unused argument 'encoder'
Line 260 in Requests.makeRequest_httplib W0106 Expression "[conn.close() for conn in self['conn'].connections.values()]" is assigned to nothing
Line 175 in Requests.makeRequest_httplib R0912 Too many branches (14/12)
Line 289 in Requests.encode R0201 Method could be a function
Line 295 in Requests.decode R0201 Method could be a function
Line 371 in Requests._getURLOpener W0703 Catching too general exception Exception
Line 521 in Requests.downloadFile W0621 Redefining name 'ResponseHeader' from outer scope (line 36)
Line 50 in Requests R0904 Too many public methods (31/20)
Line 550 in JSONRequests R0904 Too many public methods (31/20)
Line 583 in TempDirectory R0903 Too few public methods (0/2)
plus 41 comments on code style

Pre-python 2.6 idioms found in changed files. Please consider updating the code. Suggested patch follows:
--- src/python/WMCore/Services/Requests.py (original)
+++ src/python/WMCore/Services/Requests.py (refactored)
@@ -220,7 +220,7 @@
             pass

         if verb != 'GET' and data:
-            if type(encoder) == type(self.get) or type(encoder) == type(f):
+            if isinstance(encoder, type(self.get)) or isinstance(encoder, type(f)):
                 encoded_data = encoder(data)
             elif encoder == False:
                 # Don't encode the data more than we have to
@@ -240,7 +240,7 @@

         headers["Content-length"] = str(len(encoded_data))

-        assert type(encoded_data) == type('string'), \
+        assert isinstance(encoded_data, type('string')), \
             "Data in makeRequest is %s and not encoded to a string" \
                 % type(encoded_data)

@@ -279,7 +279,7 @@
             setattr(e, 'headers', response)
             raise e

-        if type(decoder) == type(self.makeRequest) or type(decoder) == type(f):
+        if isinstance(decoder, type(self.makeRequest)) or isinstance(decoder, type(f)):
             result = decoder(result)
         elif decoder != False:
             result = self.decode(result)

Unit test changes for pull request 5845:

WMComponent_t.AlertGenerator_t.AlertGenerator_t.AlertGeneratorTest:testAllFinalClassPollerImplementations changed from success to error
WMComponent_t.AlertGenerator_t.Pollers_t.Couch_t.CouchTest:testAlertGeneratorCouchCPUPollerCriticalThreshold changed from success to failure
WMComponent_t.AlertGenerator_t.Pollers_t.Couch_t.CouchTest:testAlertGeneratorCouchCPUPollerNoAlert changed from success to failure
WMComponent_t.AlertGenerator_t.Pollers_t.Couch_t.CouchTest:testAlertGeneratorCouchCPUPollerSoftThreshold changed from success to failure
WMComponent_t.AlertGenerator_t.Pollers_t.Couch_t.CouchTest:testAlertGeneratorCouchDbSizePollerBasic changed from success to failure
WMComponent_t.AlertGenerator_t.Pollers_t.Couch_t.CouchTest:testAlertGeneratorCouchDbSizePollerCriticalThreshold changed from success to failure
WMComponent_t.AlertGenerator_t.Pollers_t.Couch_t.CouchTest:testAlertGeneratorCouchDbSizePollerNoAlert changed from success to failure
WMComponent_t.AlertGenerator_t.Pollers_t.Couch_t.CouchTest:testAlertGeneratorCouchDbSizePollerSoftThreshold changed from success to failure
WMComponent_t.AlertGenerator_t.Pollers_t.Couch_t.CouchTest:testAlertGeneratorCouchErrorsPollerBasic changed from success to failure
WMComponent_t.AlertGenerator_t.Pollers_t.Couch_t.CouchTest:testAlertGeneratorCouchErrorsPollerCriticalThreshold changed from success to failure
WMComponent_t.AlertGenerator_t.Pollers_t.Couch_t.CouchTest:testAlertGeneratorCouchErrorsPollerNoAlert changed from success to failure
WMComponent_t.AlertGenerator_t.Pollers_t.Couch_t.CouchTest:testAlertGeneratorCouchErrorsPollerSoftThreshold changed from success to failure
WMComponent_t.AlertGenerator_t.Pollers_t.Couch_t.CouchTest:testAlertGeneratorCouchMemoryPollerCriticalThreshold changed from success to failure
WMComponent_t.AlertGenerator_t.Pollers_t.Couch_t.CouchTest:testAlertGeneratorCouchMemoryPollerNoAlert changed from success to failure
WMComponent_t.AlertGenerator_t.Pollers_t.Couch_t.CouchTest:testAlertGeneratorCouchMemoryPollerSoftThreshold changed from success to failure
WMComponent_t.AlertGenerator_t.Pollers_t.Couch_t.CouchTest:testAlertGeneratorCouchPollerBasic changed from success to failure
WMComponent_t.DBSUpload_t.DBSUploadPoller_t.DBSUploadTest:testG_closeSettingsPerWorkflow changed from failure to error
WMComponent_t.JobAccountant_t.JobAccountant_t.JobAccountantTest:testBadFWJR changed from success to error
WMComponent_t.JobAccountant_t.JobAccountant_t.JobAccountantTest:testDBRollback changed from success to error
WMComponent_t.JobAccountant_t.JobAccountant_t.JobAccountantTest:testEmptyFWJR changed from success to error
WMComponent_t.JobAccountant_t.JobAccountant_t.JobAccountantTest:testFailedJob changed from success to error
WMComponent_t.JobAccountant_t.JobAccountant_t.JobAccountantTest:testMergeSuccess changed from success to error
WMComponent_t.JobAccountant_t.JobAccountant_t.JobAccountantTest:testMergeSuccessNoLumi changed from success to error
WMComponent_t.JobAccountant_t.JobAccountant_t.JobAccountantTest:testMergeSuccessSkippedFiles changed from success to error
WMComponent_t.JobAccountant_t.JobAccountant_t.JobAccountantTest:testMergedSkim changed from success to error
WMComponent_t.JobAccountant_t.JobAccountant_t.JobAccountantTest:testNoFileReport changed from success to error
WMComponent_t.JobAccountant_t.JobAccountant_t.JobAccountantTest:testParentlessMergeSuccess changed from success to error
WMComponent_t.JobAccountant_t.JobAccountant_t.JobAccountantTest:testReportReturn changed from success to error
WMComponent_t.JobAccountant_t.JobAccountant_t.JobAccountantTest:testSplitJobs changed from success to error
WMCore_t.Alerts_t.ZMQ_t.Sinks_t.CouchSink_t.CouchSinkTest:testCouchSinkBasic changed from success to error
WMCore_t.Alerts_t.ZMQ_t.Sinks_t.RESTSink_t.RESTSinkTest:testRESTSinkBasic changed from success to error
WMCore_t.Cache_t.WMConfigCache_t.testWMConfigCache:testB_addingConfigsAndTweaks changed from success to error
WMCore_t.Cache_t.WMConfigCache_t.testWMConfigCache:testC_testViews changed from success to error
WMCore_t.Database_t.CMSCouch_t.CMSCouchTest:testAttachments changed from success to error
WMCore_t.Database_t.RotatingDatabase_t.RotatingDatabaseTest:testArchive changed from success to failure
WMCore_t.FwkJobReport_t.ReportEmu_t.ReportEmuTest:testMerge changed from success to error
WMCore_t.FwkJobReport_t.ReportEmu_t.ReportEmuTest:testProcessing changed from success to error
WMCore_t.GroupUser_t.Interface_t.Interface_t:testA changed from success to error
WMCore_t.JobStateMachine_t.ChangeState_t.TestChangeState:testDuplicateJobReports changed from success to failure
WMCore_t.JobStateMachine_t.ChangeState_t.TestChangeState:testFWJRInputFileTruncation changed from success to failure
WMCore_t.JobStateMachine_t.ChangeState_t.TestChangeState:testJobSerialization changed from success to failure
WMCore_t.JobStateMachine_t.ChangeState_t.TestChangeState:testJobSummary changed from success to failure
WMCore_t.JobStateMachine_t.ChangeState_t.TestChangeState:testUpdateFailedDoc changed from success to error
WMCore_t.JobStateMachine_t.ChangeState_t.TestChangeState:testUpdateLocation changed from success to failure
WMCore_t.Services_t.DBS_t.DBSReader_t.DBSReaderTest:testGetFileBlock changed from success to error
WMCore_t.Services_t.DBS_t.DBSReader_t.DBSReaderTest:testGetFileBlockWithParents changed from success to error
WMCore_t.Services_t.DBS_t.DBSReader_t.DBSReaderTest:testGetFiles changed from success to error
WMCore_t.Services_t.DBS_t.DBSReader_t.DBSReaderTest:testListBlockParents changed from success to error
WMCore_t.Services_t.Requests_t.TestRequests:testSecureNoAuth changed from success to error
WMCore_t.Services_t.Requests_t.TestRequests:testSecureOddPort changed from success to error
WMCore_t.Services_t.Requests_t.TestRequests:testSecureWithProxy changed from success to error
WMCore_t.Services_t.Requests_t.TestRequests:testSecureWithProxy_with_pycurl changed from error to success
WMCore_t.WMRuntime_t.DashboardInterface_t.DashboardInterfaceTest:testAFailedJobMonitoring changed from success to error
WMCore_t.WMRuntime_t.DashboardInterface_t.DashboardInterfaceTest:testAKilledJobMonitoring changed from success to error
WMCore_t.WMRuntime_t.DashboardInterface_t.DashboardInterfaceTest:testASuccessfulJobMonitoring changed from success to error
WMCore_t.WMRuntime_t.DashboardInterface_t.DashboardInterfaceTest:testMultithreadedApplication changed from success to error
WMCore_t.WMSpec_t.StdSpecs_t.Analysis_t.AnalysisTest:testAnalysis changed from success to error
WMCore_t.WMSpec_t.StdSpecs_t.DQMHarvest_t.DQMHarvestTests:testDQMHarvest changed from success to error
WMCore_t.WMSpec_t.StdSpecs_t.MonteCarloFromGEN_t.MonteCarloFromGENTest:testMonteCarloFromGEN changed from success to error
WMCore_t.WMSpec_t.StdSpecs_t.PrivateMC_t.PrivateMCTest:testPrivateMC changed from success to error
WMCore_t.WMSpec_t.StdSpecs_t.ReDigi_t.ReDigiTest:testChainedReDigi changed from success to error
WMCore_t.WMSpec_t.StdSpecs_t.ReDigi_t.ReDigiTest:testCombinedReDigiRecoConfig changed from success to error
WMCore_t.WMSpec_t.StdSpecs_t.ReDigi_t.ReDigiTest:testDependentReDigi changed from success to error
WMCore_t.WMSpec_t.StdSpecs_t.ReDigi_t.ReDigiTest:testSingleStepReDigi changed from success to error
WMCore_t.WMSpec_t.StdSpecs_t.ReDigi_t.ReDigiTest:testThreeStepChainedReDigi changed from success to error
WMCore_t.WMSpec_t.StdSpecs_t.ReReco_t.ReRecoTest:testReReco changed from success to error
WMCore_t.WMSpec_t.StdSpecs_t.ReReco_t.ReRecoTest:testReRecoDroppingRECO changed from success to error
WMCore_t.WMSpec_t.StdSpecs_t.StoreResults_t.StoreResultsTest:testStoreResults changed from success to error
WMCore_t.WMSpec_t.Steps_t.Fetchers_t.CMSSWFetcher_t.URLFetcherTest:testA_BasicFunction changed from success to error
WMCore_t.WMSpec_t.Steps_t.Fetchers_t.URLFetcher_t.URLFetcherTest:testA_BasicFunction changed from success to error
WMCore_t.WorkQueue_t.Policy_t.Start_t.Block_t.BlockTestCase:testContinuousSplittingSupport changed from success to error
WMCore_t.WorkQueue_t.Policy_t.Start_t.Block_t.BlockTestCase:testDataDirectiveFromQueue changed from success to error
WMCore_t.WorkQueue_t.Policy_t.Start_t.Block_t.BlockTestCase:testDatasetLocation changed from success to error
WMCore_t.WorkQueue_t.Policy_t.Start_t.Block_t.BlockTestCase:testGetMaskedBlocks changed from success to error
WMCore_t.WorkQueue_t.Policy_t.Start_t.Block_t.BlockTestCase:testIgnore0SizeBlocks changed from success to error
WMCore_t.WorkQueue_t.Policy_t.Start_t.Block_t.BlockTestCase:testInvalidSpecs changed from success to error
WMCore_t.WorkQueue_t.Policy_t.Start_t.Block_t.BlockTestCase:testLumiSplitTier1ReRecoWorkload changed from success to error
WMCore_t.WorkQueue_t.Policy_t.Start_t.Block_t.BlockTestCase:testMultiTaskProcessingWorkload changed from success to error
WMCore_t.WorkQueue_t.Policy_t.Start_t.Block_t.BlockTestCase:testPileupData changed from success to error
WMCore_t.WorkQueue_t.Policy_t.Start_t.Block_t.BlockTestCase:testRunWhitelist changed from success to error
WMCore_t.WorkQueue_t.Policy_t.Start_t.Block_t.BlockTestCase:testTier1ReRecoWorkload changed from success to error
WMCore_t.WorkQueue_t.Policy_t.Start_t.Block_t.BlockTestCase:testWhiteBlackLists changed from failure to error
WMCore_t.WorkQueue_t.Policy_t.Start_t.Block_t.BlockTestCase:testWithMaskedBlocks changed from success to error
WMCore_t.WorkQueue_t.Policy_t.Start_t.Dataset_t.DatasetTestCase:testLumiSplitTier1ReRecoWorkload changed from success to error
WMCore_t.WorkQueue_t.Policy_t.Start_t.Dataset_t.DatasetTestCase:testParentProcessing changed from failure to error
WMCore_t.WorkQueue_t.Policy_t.Start_t.Dataset_t.DatasetTestCase:testRunWhitelist changed from success to error
WMCore_t.WorkQueue_t.Policy_t.Start_t.ResubmitBlock_t.ResubmitBlockTest:testEmptyACDC changed from success to error
WMCore_t.WorkQueue_t.Policy_t.Start_t.ResubmitBlock_t.ResubmitBlockTest:testUnsupportedACDC changed from success to error
WMCore_t.WorkQueue_t.WMBSHelper_t.WMBSHelperTest:testCreateSubscription changed from success to error
WMCore_t.WorkQueue_t.WMBSHelper_t.WMBSHelperTest:testDuplicateFileInsert changed from success to error
WMCore_t.WorkQueue_t.WMBSHelper_t.WMBSHelperTest:testKillWorkflow changed from success to error
WMCore_t.WorkQueue_t.WMBSHelper_t.WMBSHelperTest:testLumiMaskRestrictionsKO changed from success to error
WMCore_t.WorkQueue_t.WMBSHelper_t.WMBSHelperTest:testLumiMaskRestrictionsOK changed from success to error
WMCore_t.WorkQueue_t.WMBSHelper_t.WMBSHelperTest:testParentage changed from success to error
WMCore_t.WorkQueue_t.WMBSHelper_t.WMBSHelperTest:testReReco changed from success to error
WMCore_t.WorkQueue_t.WMBSHelper_t.WMBSHelperTest:testReRecoBlackRunRestriction changed from failure to error
WMCore_t.WorkQueue_t.WMBSHelper_t.WMBSHelperTest:testReRecoWhiteRunRestriction changed from success to error
WMCore_t.WorkQueue_t.WMBSHelper_t.WMBSHelperTest:testTruncatedWFInsertion changed from success to error
WMCore_t.WorkQueue_t.WorkQueueBackend_t.WorkQueueBackendTest:testDuplicateInsertion changed from success to error
WMCore_t.WorkQueue_t.WorkQueueBackend_t.WorkQueueBackendTest:testPriority changed from success to error

Seangchan, please test this PR with https://github.com/dmwm/WMCore/pull/6210, which fixed params=None issue in some tests.

Valentin, Jenkins doesn't test combinations of patches. If that goes with this, just add a commit to this branch, please

I can merge #6210 separately. That patch #6210 is independent (sort of) won't break anything (since we are not testing pycurl L :smile: )
Current code doesn't use the pycurl so unittest is not running under pycurl but httplib2.
If the #6210 doesn't fix everything about using pycurl. What we can do is just close this request and Valentin can create new patch with this one included it would be simpler to trigger the test.

retest this please

Summary of pylint changes for pull request 5845:

Score for src/python/WMCore/Services/Requests.py decreased from 9.75 to 9.72
Warnings for src/python/WMCore/Services/Requests.py increased from 5 to 6

src/python/WMCore/Services/Requests.py got worse in pylint. Report follows:

Line 27 W0702 No exception type(s) specified
Line 64 in Requests.init W0612 Unused variable 'pycurl'
Line 154 in Requests.makeRequest_pycurl W0613 Unused argument 'encoder'
Line 260 in Requests.makeRequest_httplib W0106 Expression "[conn.close() for conn in self['conn'].connections.values()]" is assigned to nothing
Line 175 in Requests.makeRequest_httplib R0912 Too many branches (14/12)
Line 289 in Requests.encode R0201 Method could be a function
Line 295 in Requests.decode R0201 Method could be a function
Line 371 in Requests._getURLOpener W0703 Catching too general exception Exception
Line 521 in Requests.downloadFile W0621 Redefining name 'ResponseHeader' from outer scope (line 36)
Line 50 in Requests R0904 Too many public methods (31/20)
Line 550 in JSONRequests R0904 Too many public methods (31/20)
Line 583 in TempDirectory R0903 Too few public methods (0/2)
plus 41 comments on code style

Pre-python 2.6 idioms found in changed files. Please consider updating the code. Suggested patch follows:
--- src/python/WMCore/Services/Requests.py (original)
+++ src/python/WMCore/Services/Requests.py (refactored)
@@ -220,7 +220,7 @@
             pass

         if verb != 'GET' and data:
-            if type(encoder) == type(self.get) or type(encoder) == type(f):
+            if isinstance(encoder, type(self.get)) or isinstance(encoder, type(f)):
                 encoded_data = encoder(data)
             elif encoder == False:
                 # Don't encode the data more than we have to
@@ -240,7 +240,7 @@

         headers["Content-length"] = str(len(encoded_data))

-        assert type(encoded_data) == type('string'), \
+        assert isinstance(encoded_data, type('string')), \
             "Data in makeRequest is %s and not encoded to a string" \
                 % type(encoded_data)

@@ -279,7 +279,7 @@
             setattr(e, 'headers', response)
             raise e

-        if type(decoder) == type(self.makeRequest) or type(decoder) == type(f):
+        if isinstance(decoder, type(self.makeRequest)) or isinstance(decoder, type(f)):
             result = decoder(result)
         elif decoder != False:
             result = self.decode(result)

Unit test changes for pull request 5845:

WMComponent_t.DBSUpload_t.DBSUploadPoller_t.DBSUploadTest:testG_closeSettingsPerWorkflow changed from failure to error
WMComponent_t.JobAccountant_t.JobAccountant_t.JobAccountantTest:testBadFWJR changed from success to error
WMComponent_t.JobAccountant_t.JobAccountant_t.JobAccountantTest:testDBRollback changed from success to error
WMComponent_t.JobAccountant_t.JobAccountant_t.JobAccountantTest:testEmptyFWJR changed from success to error
WMComponent_t.JobAccountant_t.JobAccountant_t.JobAccountantTest:testFailedJob changed from success to error
WMComponent_t.JobAccountant_t.JobAccountant_t.JobAccountantTest:testMergeSuccess changed from success to error
WMComponent_t.JobAccountant_t.JobAccountant_t.JobAccountantTest:testMergeSuccessNoLumi changed from success to error
WMComponent_t.JobAccountant_t.JobAccountant_t.JobAccountantTest:testMergeSuccessSkippedFiles changed from success to error
WMComponent_t.JobAccountant_t.JobAccountant_t.JobAccountantTest:testMergedSkim changed from success to error
WMComponent_t.JobAccountant_t.JobAccountant_t.JobAccountantTest:testNoFileReport changed from success to error
WMComponent_t.JobAccountant_t.JobAccountant_t.JobAccountantTest:testParentlessMergeSuccess changed from success to error
WMComponent_t.JobAccountant_t.JobAccountant_t.JobAccountantTest:testReportReturn changed from success to error
WMComponent_t.JobAccountant_t.JobAccountant_t.JobAccountantTest:testSplitJobs changed from success to error
WMCore_t.Alerts_t.ZMQ_t.Sinks_t.CouchSink_t.CouchSinkTest:testCouchSinkBasic changed from success to error
WMCore_t.Alerts_t.ZMQ_t.Sinks_t.RESTSink_t.RESTSinkTest:testRESTSinkBasic changed from success to error
WMCore_t.Cache_t.WMConfigCache_t.testWMConfigCache:testB_addingConfigsAndTweaks changed from success to error
WMCore_t.Cache_t.WMConfigCache_t.testWMConfigCache:testC_testViews changed from success to error
WMCore_t.Database_t.CMSCouch_t.CMSCouchTest:testAttachments changed from success to error
WMCore_t.Database_t.RotatingDatabase_t.RotatingDatabaseTest:testArchive changed from success to failure
WMCore_t.FwkJobReport_t.ReportEmu_t.ReportEmuTest:testMerge changed from success to error
WMCore_t.FwkJobReport_t.ReportEmu_t.ReportEmuTest:testProcessing changed from success to error
WMCore_t.Services_t.DBS_t.DBSReader_t.DBSReaderTest:testGetFileBlock changed from success to error
WMCore_t.Services_t.DBS_t.DBSReader_t.DBSReaderTest:testGetFileBlockWithParents changed from success to error
WMCore_t.Services_t.DBS_t.DBSReader_t.DBSReaderTest:testGetFiles changed from success to error
WMCore_t.Services_t.DBS_t.DBSReader_t.DBSReaderTest:testListBlockParents changed from success to error
WMCore_t.Services_t.Requests_t.TestRequests:testSecureNoAuth changed from success to error
WMCore_t.Services_t.Requests_t.TestRequests:testSecureOddPort changed from success to error
WMCore_t.Services_t.Requests_t.TestRequests:testSecureWithProxy changed from success to error
WMCore_t.Services_t.Requests_t.TestRequests:testSecureWithProxy_with_pycurl changed from error to success
WMCore_t.WMRuntime_t.DashboardInterface_t.DashboardInterfaceTest:testAFailedJobMonitoring changed from success to error
WMCore_t.WMRuntime_t.DashboardInterface_t.DashboardInterfaceTest:testAKilledJobMonitoring changed from success to error
WMCore_t.WMRuntime_t.DashboardInterface_t.DashboardInterfaceTest:testASuccessfulJobMonitoring changed from success to error
WMCore_t.WMRuntime_t.DashboardInterface_t.DashboardInterfaceTest:testMultithreadedApplication changed from success to error
WMCore_t.WMSpec_t.StdSpecs_t.Analysis_t.AnalysisTest:testAnalysis changed from success to error
WMCore_t.WMSpec_t.StdSpecs_t.DQMHarvest_t.DQMHarvestTests:testDQMHarvest changed from success to error
WMCore_t.WMSpec_t.StdSpecs_t.MonteCarloFromGEN_t.MonteCarloFromGENTest:testMonteCarloFromGEN changed from success to error
WMCore_t.WMSpec_t.StdSpecs_t.PrivateMC_t.PrivateMCTest:testPrivateMC changed from success to error
WMCore_t.WMSpec_t.StdSpecs_t.ReDigi_t.ReDigiTest:testChainedReDigi changed from success to error
WMCore_t.WMSpec_t.StdSpecs_t.ReDigi_t.ReDigiTest:testCombinedReDigiRecoConfig changed from success to error
WMCore_t.WMSpec_t.StdSpecs_t.ReDigi_t.ReDigiTest:testDependentReDigi changed from success to error
WMCore_t.WMSpec_t.StdSpecs_t.ReDigi_t.ReDigiTest:testSingleStepReDigi changed from success to error
WMCore_t.WMSpec_t.StdSpecs_t.ReDigi_t.ReDigiTest:testThreeStepChainedReDigi changed from success to error
WMCore_t.WMSpec_t.StdSpecs_t.ReReco_t.ReRecoTest:testReReco changed from success to error
WMCore_t.WMSpec_t.StdSpecs_t.ReReco_t.ReRecoTest:testReRecoDroppingRECO changed from success to error
WMCore_t.WMSpec_t.StdSpecs_t.StoreResults_t.StoreResultsTest:testStoreResults changed from success to error
WMCore_t.WMSpec_t.Steps_t.Fetchers_t.CMSSWFetcher_t.URLFetcherTest:testA_BasicFunction changed from success to error
WMCore_t.WMSpec_t.Steps_t.Fetchers_t.URLFetcher_t.URLFetcherTest:testA_BasicFunction changed from success to error
WMCore_t.WorkQueue_t.Policy_t.Start_t.Block_t.BlockTestCase:testContinuousSplittingSupport changed from success to error
WMCore_t.WorkQueue_t.Policy_t.Start_t.Block_t.BlockTestCase:testDataDirectiveFromQueue changed from success to error
WMCore_t.WorkQueue_t.Policy_t.Start_t.Block_t.BlockTestCase:testDatasetLocation changed from success to error
WMCore_t.WorkQueue_t.Policy_t.Start_t.Block_t.BlockTestCase:testGetMaskedBlocks changed from success to error
WMCore_t.WorkQueue_t.Policy_t.Start_t.Block_t.BlockTestCase:testIgnore0SizeBlocks changed from success to error
WMCore_t.WorkQueue_t.Policy_t.Start_t.Block_t.BlockTestCase:testInvalidSpecs changed from success to error
WMCore_t.WorkQueue_t.Policy_t.Start_t.Block_t.BlockTestCase:testLumiSplitTier1ReRecoWorkload changed from success to error
WMCore_t.WorkQueue_t.Policy_t.Start_t.Block_t.BlockTestCase:testMultiTaskProcessingWorkload changed from success to error
WMCore_t.WorkQueue_t.Policy_t.Start_t.Block_t.BlockTestCase:testPileupData changed from success to error
WMCore_t.WorkQueue_t.Policy_t.Start_t.Block_t.BlockTestCase:testRunWhitelist changed from success to error
WMCore_t.WorkQueue_t.Policy_t.Start_t.Block_t.BlockTestCase:testTier1ReRecoWorkload changed from success to error
WMCore_t.WorkQueue_t.Policy_t.Start_t.Block_t.BlockTestCase:testWhiteBlackLists changed from failure to error
WMCore_t.WorkQueue_t.Policy_t.Start_t.Block_t.BlockTestCase:testWithMaskedBlocks changed from success to error
WMCore_t.WorkQueue_t.Policy_t.Start_t.Dataset_t.DatasetTestCase:testLumiSplitTier1ReRecoWorkload changed from success to error
WMCore_t.WorkQueue_t.Policy_t.Start_t.Dataset_t.DatasetTestCase:testParentProcessing changed from failure to error
WMCore_t.WorkQueue_t.Policy_t.Start_t.Dataset_t.DatasetTestCase:testRunWhitelist changed from success to error
WMCore_t.WorkQueue_t.Policy_t.Start_t.ResubmitBlock_t.ResubmitBlockTest:testEmptyACDC changed from success to error
WMCore_t.WorkQueue_t.Policy_t.Start_t.ResubmitBlock_t.ResubmitBlockTest:testUnsupportedACDC changed from success to error
WMCore_t.WorkQueue_t.WMBSHelper_t.WMBSHelperTest:testCreateSubscription changed from success to error
WMCore_t.WorkQueue_t.WMBSHelper_t.WMBSHelperTest:testDuplicateFileInsert changed from success to error
WMCore_t.WorkQueue_t.WMBSHelper_t.WMBSHelperTest:testKillWorkflow changed from success to error
WMCore_t.WorkQueue_t.WMBSHelper_t.WMBSHelperTest:testLumiMaskRestrictionsKO changed from success to error
WMCore_t.WorkQueue_t.WMBSHelper_t.WMBSHelperTest:testLumiMaskRestrictionsOK changed from success to error
WMCore_t.WorkQueue_t.WMBSHelper_t.WMBSHelperTest:testParentage changed from success to error
WMCore_t.WorkQueue_t.WMBSHelper_t.WMBSHelperTest:testReReco changed from success to error
WMCore_t.WorkQueue_t.WMBSHelper_t.WMBSHelperTest:testReRecoBlackRunRestriction changed from failure to error
WMCore_t.WorkQueue_t.WMBSHelper_t.WMBSHelperTest:testReRecoWhiteRunRestriction changed from success to error
WMCore_t.WorkQueue_t.WMBSHelper_t.WMBSHelperTest:testTruncatedWFInsertion changed from success to error
WMCore_t.WorkQueue_t.WorkQueueBackend_t.WorkQueueBackendTest:testDuplicateInsertion changed from success to error
WMCore_t.WorkQueue_t.WorkQueueBackend_t.WorkQueueBackendTest:testPriority changed from success to error

Seangchan, feel free to go ahead and merge #6210. As you said it stays independent. And, probably it would be good idea to close this one that I can apply these changes when pycurl saga will be finished.

retest this please

Beginning pylint and unit tests.
See https://cmssdt.cern.ch/jenkins/job/DMWM-PR-test/770/ for details

Beginning pylint and unit tests.
See https://cmssdt.cern.ch/jenkins/job/DMWM-PR-test/772/ for details

Summary of pylint changes for pull request 5845:

Score for src/python/WMCore/Services/Requests.py changed from 9.75 to 9.72 with 0 (6) total errors (warnings)

src/python/WMCore/Services/Requests.py got worse in pylint. Report follows:

Line 27 W0702 No exception type(s) specified
Line 64 in Requests.init W0612 Unused variable 'pycurl'
Line 154 in Requests.makeRequest_pycurl W0613 Unused argument 'encoder'
Line 260 in Requests.makeRequest_httplib W0106 Expression "[conn.close() for conn in self['conn'].connections.values()]" is assigned to nothing
Line 175 in Requests.makeRequest_httplib R0912 Too many branches (14/12)
Line 289 in Requests.encode R0201 Method could be a function
Line 295 in Requests.decode R0201 Method could be a function
Line 371 in Requests._getURLOpener W0703 Catching too general exception Exception
Line 521 in Requests.downloadFile W0621 Redefining name 'ResponseHeader' from outer scope (line 36)
Line 50 in Requests R0904 Too many public methods (31/20)
Line 550 in JSONRequests R0904 Too many public methods (31/20)
Line 583 in TempDirectory R0903 Too few public methods (0/2)
plus 41 comments on code style

Pre-python 2.6 idioms found in changed files. Please consider updating the code. Suggested patch follows:
--- src/python/WMCore/Services/Requests.py (original)
+++ src/python/WMCore/Services/Requests.py (refactored)
@@ -220,7 +220,7 @@
             pass

         if verb != 'GET' and data:
-            if type(encoder) == type(self.get) or type(encoder) == type(f):
+            if isinstance(encoder, type(self.get)) or isinstance(encoder, type(f)):
                 encoded_data = encoder(data)
             elif encoder == False:
                 # Don't encode the data more than we have to
@@ -240,7 +240,7 @@

         headers["Content-length"] = str(len(encoded_data))

-        assert type(encoded_data) == type('string'), \
+        assert isinstance(encoded_data, type('string')), \
             "Data in makeRequest is %s and not encoded to a string" \
                 % type(encoded_data)

@@ -279,7 +279,7 @@
             setattr(e, 'headers', response)
             raise e

-        if type(decoder) == type(self.makeRequest) or type(decoder) == type(f):
+        if isinstance(decoder, type(self.makeRequest)) or isinstance(decoder, type(f)):
             result = decoder(result)
         elif decoder != False:
             result = self.decode(result)

Unit test changes for pull request 5845:

WMComponent_t.AnalyticsDataCollector_t.Plugins_t.Tier0Plugin_t.Tier0PluginTest:testC_PromptRecoStates changed from success to error
WMComponent_t.DBSUpload_t.DBSUploadPoller_t.DBSUploadTest:testG_closeSettingsPerWorkflow changed from failure to error
WMComponent_t.JobAccountant_t.JobAccountant_t.JobAccountantTest:testBadFWJR changed from success to error
WMComponent_t.JobAccountant_t.JobAccountant_t.JobAccountantTest:testDBRollback changed from success to error
WMComponent_t.JobAccountant_t.JobAccountant_t.JobAccountantTest:testEmptyFWJR changed from success to error
WMComponent_t.JobAccountant_t.JobAccountant_t.JobAccountantTest:testFailedJob changed from success to error
WMComponent_t.JobAccountant_t.JobAccountant_t.JobAccountantTest:testMergeSuccess changed from success to error
WMComponent_t.JobAccountant_t.JobAccountant_t.JobAccountantTest:testMergeSuccessNoLumi changed from success to error
WMComponent_t.JobAccountant_t.JobAccountant_t.JobAccountantTest:testMergeSuccessSkippedFiles changed from success to error
WMComponent_t.JobAccountant_t.JobAccountant_t.JobAccountantTest:testMergedSkim changed from success to error
WMComponent_t.JobAccountant_t.JobAccountant_t.JobAccountantTest:testNoFileReport changed from success to error
WMComponent_t.JobAccountant_t.JobAccountant_t.JobAccountantTest:testParentlessMergeSuccess changed from success to error
WMComponent_t.JobAccountant_t.JobAccountant_t.JobAccountantTest:testReportReturn changed from success to error
WMComponent_t.JobAccountant_t.JobAccountant_t.JobAccountantTest:testSplitJobs changed from success to error
WMCore_t.Cache_t.WMConfigCache_t.testWMConfigCache:testB_addingConfigsAndTweaks changed from success to error
WMCore_t.Cache_t.WMConfigCache_t.testWMConfigCache:testC_testViews changed from success to error
WMCore_t.Database_t.CMSCouch_t.CMSCouchTest:testAttachments changed from success to error
WMCore_t.FwkJobReport_t.ReportEmu_t.ReportEmuTest:testMerge changed from success to error
WMCore_t.FwkJobReport_t.ReportEmu_t.ReportEmuTest:testProcessing changed from success to error
WMCore_t.FwkJobReport_t.ReportIntegration_t.ReportIntegrationTest:testReportHandling changed from failure to error
WMCore_t.ReqMgr_t.Service_t.Auxiliary_t.AuxiliaryTest:test_A_HelloWorld_get changed from success to error
WMCore_t.Services_t.DBS_t.DBSReader_t.DBSReaderTest:testGetFileBlock changed from success to error
WMCore_t.Services_t.DBS_t.DBSReader_t.DBSReaderTest:testGetFileBlockWithParents changed from success to error
WMCore_t.Services_t.DBS_t.DBSReader_t.DBSReaderTest:testGetFiles changed from success to error
WMCore_t.Services_t.DBS_t.DBSReader_t.DBSReaderTest:testListBlockParents changed from success to error
WMCore_t.Services_t.EmulatorSwitch_t.EmulatorSwitch_t:testGetEmulators changed from success to failure
WMCore_t.Services_t.Requests_t.TestRequests:testSecureNoAuth changed from success to error
WMCore_t.Services_t.Requests_t.TestRequests:testSecureOddPort changed from success to error
WMCore_t.Services_t.Requests_t.TestRequests:testSecureWithProxy changed from success to error
WMCore_t.Services_t.Requests_t.TestRequests:testSecureWithProxy_with_pycurl changed from error to success
WMCore_t.Services_t.Service_t.ServiceTest:testClear changed from success to error
WMCore_t.Services_t.Service_t.ServiceTest:testClearAndRepopulate changed from success to error
WMCore_t.Services_t.Service_t.ServiceTest:testNoCache changed from success to error
WMCore_t.Services_t.Service_t.ServiceTest:testSocketTimeout changed from success to error
WMCore_t.WMRuntime_t.DashboardInterface_t.DashboardInterfaceTest:testAFailedJobMonitoring changed from success to error
WMCore_t.WMRuntime_t.DashboardInterface_t.DashboardInterfaceTest:testAKilledJobMonitoring changed from success to error
WMCore_t.WMRuntime_t.DashboardInterface_t.DashboardInterfaceTest:testASuccessfulJobMonitoring changed from success to error
WMCore_t.WMRuntime_t.DashboardInterface_t.DashboardInterfaceTest:testMultithreadedApplication changed from success to error
WMCore_t.WMSpec_t.StdSpecs_t.Analysis_t.AnalysisTest:testAnalysis changed from success to error
WMCore_t.WMSpec_t.StdSpecs_t.DQMHarvest_t.DQMHarvestTests:testDQMHarvest changed from success to error
WMCore_t.WMSpec_t.StdSpecs_t.MonteCarloFromGEN_t.MonteCarloFromGENTest:testMonteCarloFromGEN changed from success to error
WMCore_t.WMSpec_t.StdSpecs_t.PrivateMC_t.PrivateMCTest:testPrivateMC changed from success to error
WMCore_t.WMSpec_t.StdSpecs_t.PromptReco_t.PromptRecoTest:testPromptReco changed from success to error
WMCore_t.WMSpec_t.StdSpecs_t.ReDigi_t.ReDigiTest:testChainedReDigi changed from success to error
WMCore_t.WMSpec_t.StdSpecs_t.ReDigi_t.ReDigiTest:testCombinedReDigiRecoConfig changed from success to error
WMCore_t.WMSpec_t.StdSpecs_t.ReDigi_t.ReDigiTest:testDependentReDigi changed from success to error
WMCore_t.WMSpec_t.StdSpecs_t.ReDigi_t.ReDigiTest:testSingleStepReDigi changed from success to error
WMCore_t.WMSpec_t.StdSpecs_t.ReDigi_t.ReDigiTest:testThreeStepChainedReDigi changed from success to error
WMCore_t.WMSpec_t.StdSpecs_t.ReReco_t.ReRecoTest:testReReco changed from success to error
WMCore_t.WMSpec_t.StdSpecs_t.ReReco_t.ReRecoTest:testReRecoDroppingRECO changed from success to error
WMCore_t.WMSpec_t.StdSpecs_t.StoreResults_t.StoreResultsTest:testStoreResults changed from success to error
WMCore_t.WMSpec_t.Steps_t.Fetchers_t.CMSSWFetcher_t.URLFetcherTest:testA_BasicFunction changed from success to error
WMCore_t.WMSpec_t.Steps_t.Fetchers_t.URLFetcher_t.URLFetcherTest:testA_BasicFunction changed from success to error
WMCore_t.WorkQueue_t.Policy_t.Start_t.Block_t.BlockTestCase:testContinuousSplittingSupport changed from success to error
WMCore_t.WorkQueue_t.Policy_t.Start_t.Block_t.BlockTestCase:testDataDirectiveFromQueue changed from success to error
WMCore_t.WorkQueue_t.Policy_t.Start_t.Block_t.BlockTestCase:testDatasetLocation changed from success to error
WMCore_t.WorkQueue_t.Policy_t.Start_t.Block_t.BlockTestCase:testGetMaskedBlocks changed from success to error
WMCore_t.WorkQueue_t.Policy_t.Start_t.Block_t.BlockTestCase:testIgnore0SizeBlocks changed from success to error
WMCore_t.WorkQueue_t.Policy_t.Start_t.Block_t.BlockTestCase:testInvalidSpecs changed from success to error
WMCore_t.WorkQueue_t.Policy_t.Start_t.Block_t.BlockTestCase:testLumiSplitTier1ReRecoWorkload changed from success to error
WMCore_t.WorkQueue_t.Policy_t.Start_t.Block_t.BlockTestCase:testMultiTaskProcessingWorkload changed from success to error
WMCore_t.WorkQueue_t.Policy_t.Start_t.Block_t.BlockTestCase:testPileupData changed from success to error
WMCore_t.WorkQueue_t.Policy_t.Start_t.Block_t.BlockTestCase:testRunWhitelist changed from success to error
WMCore_t.WorkQueue_t.Policy_t.Start_t.Block_t.BlockTestCase:testTier1ReRecoWorkload changed from success to error
WMCore_t.WorkQueue_t.Policy_t.Start_t.Block_t.BlockTestCase:testWhiteBlackLists changed from success to error
WMCore_t.WorkQueue_t.Policy_t.Start_t.Block_t.BlockTestCase:testWithMaskedBlocks changed from success to error
WMCore_t.WorkQueue_t.Policy_t.Start_t.Dataset_t.DatasetTestCase:testDataDirectiveFromQueue changed from success to error
WMCore_t.WorkQueue_t.Policy_t.Start_t.Dataset_t.DatasetTestCase:testInvalidSpecs changed from success to error
WMCore_t.WorkQueue_t.Policy_t.Start_t.Dataset_t.DatasetTestCase:testLumiSplitTier1ReRecoWorkload changed from success to error
WMCore_t.WorkQueue_t.Policy_t.Start_t.Dataset_t.DatasetTestCase:testMultiTaskProcessingWorkload changed from failure to error
WMCore_t.WorkQueue_t.Policy_t.Start_t.Dataset_t.DatasetTestCase:testParentProcessing changed from failure to error
WMCore_t.WorkQueue_t.Policy_t.Start_t.Dataset_t.DatasetTestCase:testRunWhitelist changed from success to error
WMCore_t.WorkQueue_t.Policy_t.Start_t.Dataset_t.DatasetTestCase:testTier1ReRecoWorkload changed from failure to error
WMCore_t.WorkQueue_t.Policy_t.Start_t.Dataset_t.DatasetTestCase:testWhiteBlackLists changed from failure to error
WMCore_t.WorkQueue_t.Policy_t.Start_t.ResubmitBlock_t.ResubmitBlockTest:testEmptyACDC changed from success to error
WMCore_t.WorkQueue_t.Policy_t.Start_t.ResubmitBlock_t.ResubmitBlockTest:testUnsupportedACDC changed from success to error
WMCore_t.WorkQueue_t.WMBSHelper_t.WMBSHelperTest:testCreateSubscription changed from success to error
WMCore_t.WorkQueue_t.WMBSHelper_t.WMBSHelperTest:testDuplicateFileInsert changed from success to error
WMCore_t.WorkQueue_t.WMBSHelper_t.WMBSHelperTest:testKillWorkflow changed from success to error
WMCore_t.WorkQueue_t.WMBSHelper_t.WMBSHelperTest:testLumiMaskRestrictionsKO changed from success to error
WMCore_t.WorkQueue_t.WMBSHelper_t.WMBSHelperTest:testLumiMaskRestrictionsOK changed from success to error
WMCore_t.WorkQueue_t.WMBSHelper_t.WMBSHelperTest:testParentage changed from success to error
WMCore_t.WorkQueue_t.WMBSHelper_t.WMBSHelperTest:testReReco changed from success to error
WMCore_t.WorkQueue_t.WMBSHelper_t.WMBSHelperTest:testReRecoBlackRunRestriction changed from success to error
WMCore_t.WorkQueue_t.WMBSHelper_t.WMBSHelperTest:testReRecoWhiteRunRestriction changed from success to error
WMCore_t.WorkQueue_t.WMBSHelper_t.WMBSHelperTest:testTruncatedWFInsertion changed from success to error
WMCore_t.WorkQueue_t.WorkQueueBackend_t.WorkQueueBackendTest:testDuplicateInsertion changed from success to error
WMCore_t.WorkQueue_t.WorkQueueBackend_t.WorkQueueBackendTest:testPriority changed from success to error
WMCore_t.WorkQueue_t.WorkQueue_t.WorkQueueTest:test0eventBlock changed from failure to error
WMCore_t.WorkQueue_t.WorkQueue_t.WorkQueueTest:testBlackList changed from failure to error
WMCore_t.WorkQueue_t.WorkQueue_t.WorkQueueTest:testCancelWork changed from failure to error
WMCore_t.WorkQueue_t.WorkQueue_t.WorkQueueTest:testCancelWorkGlobal changed from failure to error
WMCore_t.WorkQueue_t.WorkQueue_t.WorkQueueTest:testCloseWorkOpenBlocks changed from failure to error
WMCore_t.WorkQueue_t.WorkQueue_t.WorkQueueTest:testCloseWorkTimeout changed from success to error
WMCore_t.WorkQueue_t.WorkQueue_t.WorkQueueTest:testConflicts changed from failure to error
WMCore_t.WorkQueue_t.WorkQueue_t.WorkQueueTest:testDeleteWork changed from failure to error
WMCore_t.WorkQueue_t.WorkQueue_t.WorkQueueTest:testDrainMode changed from success to error
WMCore_t.WorkQueue_t.WorkQueue_t.WorkQueueTest:testEndPolicyNegotiating changed from failure to error
WMCore_t.WorkQueue_t.WorkQueue_t.WorkQueueTest:testFailRequestAfterTimeout changed from success to error
WMCore_t.WorkQueue_t.WorkQueue_t.WorkQueueTest:testGlobalBlockSplitting changed from failure to error
WMCore_t.WorkQueue_t.WorkQueue_t.WorkQueueTest:testGlobalDatasetSplitting changed from failure to error
WMCore_t.WorkQueue_t.WorkQueue_t.WorkQueueTest:testIgnoreDuplicates changed from success to error
WMCore_t.WorkQueue_t.WorkQueue_t.WorkQueueTest:testInvalidSpecs changed from success to error
WMCore_t.WorkQueue_t.WorkQueue_t.WorkQueueTest:testMultiTaskProduction changed from success to error
WMCore_t.WorkQueue_t.WorkQueue_t.WorkQueueTest:testMultipleTeams changed from failure to error
WMCore_t.WorkQueue_t.WorkQueue_t.WorkQueueTest:testOpenBlocks changed from failure to error
WMCore_t.WorkQueue_t.WorkQueue_t.WorkQueueTest:testParentProcessing changed from failure to error
WMCore_t.WorkQueue_t.WorkQueue_t.WorkQueueTest:testPileupOnProduction changed from success to error
WMCore_t.WorkQueue_t.WorkQueue_t.WorkQueueTest:testPrioritiesWorkPolling changed from failure to error
WMCore_t.WorkQueue_t.WorkQueue_t.WorkQueueTest:testPriority changed from success to error
WMCore_t.WorkQueue_t.WorkQueue_t.WorkQueueTest:testProcessing changed from failure to error
WMCore_t.WorkQueue_t.WorkQueue_t.WorkQueueTest:testProcessingWithContinuousSplitting changed from failure to error
WMCore_t.WorkQueue_t.WorkQueue_t.WorkQueueTest:testProcessingWithPileup changed from failure to error
WMCore_t.WorkQueue_t.WorkQueue_t.WorkQueueTest:testProduction changed from success to error
WMCore_t.WorkQueue_t.WorkQueue_t.WorkQueueTest:testProductionMultiQueue changed from failure to error
WMCore_t.WorkQueue_t.WorkQueue_t.WorkQueueTest:testQueueChaining changed from failure to error
WMCore_t.WorkQueue_t.WorkQueue_t.WorkQueueTest:testQueueChainingStatusUpdates changed from failure to error
WMCore_t.WorkQueue_t.WorkQueue_t.WorkQueueTest:testResetWork changed from failure to error
WMCore_t.WorkQueue_t.WorkQueue_t.WorkQueueTest:testResubmissionWithParentsWorkflow changed from success to error
WMCore_t.WorkQueue_t.WorkQueue_t.WorkQueueTest:testResubmissionWorkflow changed from failure to error
WMCore_t.WorkQueue_t.WorkQueue_t.WorkQueueTest:testResubmissionWorkflowSiteWhitelistLocations changed from failure to error
WMCore_t.WorkQueue_t.WorkQueue_t.WorkQueueTest:testSiteStatus changed from failure to error
WMCore_t.WorkQueue_t.WorkQueue_t.WorkQueueTest:testSitesFromResourceControl changed from failure to error
WMCore_t.WorkQueue_t.WorkQueue_t.WorkQueueTest:testSplittingLargeInputs changed from failure to error
WMCore_t.WorkQueue_t.WorkQueue_t.WorkQueueTest:testTeams changed from failure to error
WMCore_t.WorkQueue_t.WorkQueue_t.WorkQueueTest:testThrottling changed from failure to error
WMCore_t.WorkQueue_t.WorkQueue_t.WorkQueueTest:testWMBSInjectionStatus changed from failure to error

Previously working unit tests have failed!

Summary of pylint changes for pull request 5845:

Score for src/python/WMCore/Services/Requests.py changed from 9.75 to 9.72 with 0 (6) total errors (warnings)

src/python/WMCore/Services/Requests.py got worse in pylint. Report follows:

Line 27 W0702 No exception type(s) specified
Line 64 in Requests.init W0612 Unused variable 'pycurl'
Line 154 in Requests.makeRequest_pycurl W0613 Unused argument 'encoder'
Line 260 in Requests.makeRequest_httplib W0106 Expression "[conn.close() for conn in self['conn'].connections.values()]" is assigned to nothing
Line 175 in Requests.makeRequest_httplib R0912 Too many branches (14/12)
Line 289 in Requests.encode R0201 Method could be a function
Line 295 in Requests.decode R0201 Method could be a function
Line 371 in Requests._getURLOpener W0703 Catching too general exception Exception
Line 521 in Requests.downloadFile W0621 Redefining name 'ResponseHeader' from outer scope (line 36)
Line 50 in Requests R0904 Too many public methods (31/20)
Line 550 in JSONRequests R0904 Too many public methods (31/20)
Line 583 in TempDirectory R0903 Too few public methods (0/2)
plus 41 comments on code style

Pre-python 2.6 idioms found in changed files. Please consider updating the code. Suggested patch follows:
--- src/python/WMCore/Services/Requests.py (original)
+++ src/python/WMCore/Services/Requests.py (refactored)
@@ -220,7 +220,7 @@
             pass

         if verb != 'GET' and data:
-            if type(encoder) == type(self.get) or type(encoder) == type(f):
+            if isinstance(encoder, type(self.get)) or isinstance(encoder, type(f)):
                 encoded_data = encoder(data)
             elif encoder == False:
                 # Don't encode the data more than we have to
@@ -240,7 +240,7 @@

         headers["Content-length"] = str(len(encoded_data))

-        assert type(encoded_data) == type('string'), \
+        assert isinstance(encoded_data, type('string')), \
             "Data in makeRequest is %s and not encoded to a string" \
                 % type(encoded_data)

@@ -279,7 +279,7 @@
             setattr(e, 'headers', response)
             raise e

-        if type(decoder) == type(self.makeRequest) or type(decoder) == type(f):
+        if isinstance(decoder, type(self.makeRequest)) or isinstance(decoder, type(f)):
             result = decoder(result)
         elif decoder != False:
             result = self.decode(result)

Unit test changes for pull request 5845:

WMComponent_t.AnalyticsDataCollector_t.Plugins_t.Tier0Plugin_t.Tier0PluginTest:testC_PromptRecoStates changed from success to error
WMComponent_t.DBSUpload_t.DBSUploadPoller_t.DBSUploadTest:testG_closeSettingsPerWorkflow changed from failure to error
WMComponent_t.JobAccountant_t.JobAccountant_t.JobAccountantTest:testBadFWJR changed from success to error
WMComponent_t.JobAccountant_t.JobAccountant_t.JobAccountantTest:testDBRollback changed from success to error
WMComponent_t.JobAccountant_t.JobAccountant_t.JobAccountantTest:testEmptyFWJR changed from success to error
WMComponent_t.JobAccountant_t.JobAccountant_t.JobAccountantTest:testFailedJob changed from success to error
WMComponent_t.JobAccountant_t.JobAccountant_t.JobAccountantTest:testMergeSuccess changed from success to error
WMComponent_t.JobAccountant_t.JobAccountant_t.JobAccountantTest:testMergeSuccessNoLumi changed from success to error
WMComponent_t.JobAccountant_t.JobAccountant_t.JobAccountantTest:testMergeSuccessSkippedFiles changed from success to error
WMComponent_t.JobAccountant_t.JobAccountant_t.JobAccountantTest:testMergedSkim changed from success to error
WMComponent_t.JobAccountant_t.JobAccountant_t.JobAccountantTest:testNoFileReport changed from success to error
WMComponent_t.JobAccountant_t.JobAccountant_t.JobAccountantTest:testParentlessMergeSuccess changed from success to error
WMComponent_t.JobAccountant_t.JobAccountant_t.JobAccountantTest:testReportReturn changed from success to error
WMComponent_t.JobAccountant_t.JobAccountant_t.JobAccountantTest:testSplitJobs changed from success to error
WMCore_t.ACDC_t.CouchService_t.CouchService_t:testTimestampAccounting changed from success to failure
WMCore_t.Cache_t.WMConfigCache_t.testWMConfigCache:testB_addingConfigsAndTweaks changed from success to error
WMCore_t.Cache_t.WMConfigCache_t.testWMConfigCache:testC_testViews changed from success to error
WMCore_t.Database_t.CMSCouch_t.CMSCouchTest:testAttachments changed from success to error
WMCore_t.FwkJobReport_t.ReportEmu_t.ReportEmuTest:testMerge changed from success to error
WMCore_t.FwkJobReport_t.ReportEmu_t.ReportEmuTest:testProcessing changed from success to error
WMCore_t.FwkJobReport_t.ReportIntegration_t.ReportIntegrationTest:testReportHandling changed from failure to error
WMCore_t.ReqMgr_t.Service_t.Auxiliary_t.AuxiliaryTest:test_A_HelloWorld_get changed from success to error
WMCore_t.Services_t.DBS_t.DBSReader_t.DBSReaderTest:testGetFileBlock changed from success to error
WMCore_t.Services_t.DBS_t.DBSReader_t.DBSReaderTest:testGetFileBlockWithParents changed from success to error
WMCore_t.Services_t.DBS_t.DBSReader_t.DBSReaderTest:testGetFiles changed from success to error
WMCore_t.Services_t.DBS_t.DBSReader_t.DBSReaderTest:testListBlockParents changed from success to error
WMCore_t.Services_t.EmulatorSwitch_t.EmulatorSwitch_t:testGetEmulators changed from success to failure
WMCore_t.Services_t.Requests_t.TestRequests:testSecureNoAuth changed from success to error
WMCore_t.Services_t.Requests_t.TestRequests:testSecureOddPort changed from success to error
WMCore_t.Services_t.Requests_t.TestRequests:testSecureWithProxy changed from success to error
WMCore_t.Services_t.Requests_t.TestRequests:testSecureWithProxy_with_pycurl changed from error to success
WMCore_t.Services_t.Service_t.ServiceTest:testClear changed from success to error
WMCore_t.Services_t.Service_t.ServiceTest:testClearAndRepopulate changed from success to error
WMCore_t.Services_t.Service_t.ServiceTest:testNoCache changed from success to error
WMCore_t.Services_t.Service_t.ServiceTest:testSocketTimeout changed from success to error
WMCore_t.WMRuntime_t.DashboardInterface_t.DashboardInterfaceTest:testAFailedJobMonitoring changed from success to error
WMCore_t.WMRuntime_t.DashboardInterface_t.DashboardInterfaceTest:testAKilledJobMonitoring changed from success to error
WMCore_t.WMRuntime_t.DashboardInterface_t.DashboardInterfaceTest:testASuccessfulJobMonitoring changed from success to error
WMCore_t.WMRuntime_t.DashboardInterface_t.DashboardInterfaceTest:testMultithreadedApplication changed from success to error
WMCore_t.WMSpec_t.StdSpecs_t.Analysis_t.AnalysisTest:testAnalysis changed from success to error
WMCore_t.WMSpec_t.StdSpecs_t.DQMHarvest_t.DQMHarvestTests:testDQMHarvest changed from success to error
WMCore_t.WMSpec_t.StdSpecs_t.MonteCarloFromGEN_t.MonteCarloFromGENTest:testMonteCarloFromGEN changed from success to error
WMCore_t.WMSpec_t.StdSpecs_t.PrivateMC_t.PrivateMCTest:testPrivateMC changed from success to error
WMCore_t.WMSpec_t.StdSpecs_t.PromptReco_t.PromptRecoTest:testPromptReco changed from success to error
WMCore_t.WMSpec_t.StdSpecs_t.ReDigi_t.ReDigiTest:testChainedReDigi changed from success to error
WMCore_t.WMSpec_t.StdSpecs_t.ReDigi_t.ReDigiTest:testCombinedReDigiRecoConfig changed from success to error
WMCore_t.WMSpec_t.StdSpecs_t.ReDigi_t.ReDigiTest:testDependentReDigi changed from success to error
WMCore_t.WMSpec_t.StdSpecs_t.ReDigi_t.ReDigiTest:testSingleStepReDigi changed from success to error
WMCore_t.WMSpec_t.StdSpecs_t.ReDigi_t.ReDigiTest:testThreeStepChainedReDigi changed from success to error
WMCore_t.WMSpec_t.StdSpecs_t.ReReco_t.ReRecoTest:testReReco changed from success to error
WMCore_t.WMSpec_t.StdSpecs_t.ReReco_t.ReRecoTest:testReRecoDroppingRECO changed from success to error
WMCore_t.WMSpec_t.StdSpecs_t.StoreResults_t.StoreResultsTest:testStoreResults changed from success to error
WMCore_t.WMSpec_t.Steps_t.Fetchers_t.CMSSWFetcher_t.URLFetcherTest:testA_BasicFunction changed from success to error
WMCore_t.WMSpec_t.Steps_t.Fetchers_t.URLFetcher_t.URLFetcherTest:testA_BasicFunction changed from success to error
WMCore_t.WorkQueue_t.Policy_t.Start_t.Block_t.BlockTestCase:testContinuousSplittingSupport changed from success to error
WMCore_t.WorkQueue_t.Policy_t.Start_t.Block_t.BlockTestCase:testDataDirectiveFromQueue changed from success to error
WMCore_t.WorkQueue_t.Policy_t.Start_t.Block_t.BlockTestCase:testDatasetLocation changed from success to error
WMCore_t.WorkQueue_t.Policy_t.Start_t.Block_t.BlockTestCase:testGetMaskedBlocks changed from success to error
WMCore_t.WorkQueue_t.Policy_t.Start_t.Block_t.BlockTestCase:testIgnore0SizeBlocks changed from success to error
WMCore_t.WorkQueue_t.Policy_t.Start_t.Block_t.BlockTestCase:testInvalidSpecs changed from success to error
WMCore_t.WorkQueue_t.Policy_t.Start_t.Block_t.BlockTestCase:testLumiSplitTier1ReRecoWorkload changed from success to error
WMCore_t.WorkQueue_t.Policy_t.Start_t.Block_t.BlockTestCase:testMultiTaskProcessingWorkload changed from success to error
WMCore_t.WorkQueue_t.Policy_t.Start_t.Block_t.BlockTestCase:testPileupData changed from success to error
WMCore_t.WorkQueue_t.Policy_t.Start_t.Block_t.BlockTestCase:testRunWhitelist changed from success to error
WMCore_t.WorkQueue_t.Policy_t.Start_t.Block_t.BlockTestCase:testTier1ReRecoWorkload changed from success to error
WMCore_t.WorkQueue_t.Policy_t.Start_t.Block_t.BlockTestCase:testWhiteBlackLists changed from success to error
WMCore_t.WorkQueue_t.Policy_t.Start_t.Block_t.BlockTestCase:testWithMaskedBlocks changed from success to error
WMCore_t.WorkQueue_t.Policy_t.Start_t.Dataset_t.DatasetTestCase:testDataDirectiveFromQueue changed from success to error
WMCore_t.WorkQueue_t.Policy_t.Start_t.Dataset_t.DatasetTestCase:testInvalidSpecs changed from success to error
WMCore_t.WorkQueue_t.Policy_t.Start_t.Dataset_t.DatasetTestCase:testLumiSplitTier1ReRecoWorkload changed from success to error
WMCore_t.WorkQueue_t.Policy_t.Start_t.Dataset_t.DatasetTestCase:testMultiTaskProcessingWorkload changed from failure to error
WMCore_t.WorkQueue_t.Policy_t.Start_t.Dataset_t.DatasetTestCase:testParentProcessing changed from failure to error
WMCore_t.WorkQueue_t.Policy_t.Start_t.Dataset_t.DatasetTestCase:testRunWhitelist changed from success to error
WMCore_t.WorkQueue_t.Policy_t.Start_t.Dataset_t.DatasetTestCase:testTier1ReRecoWorkload changed from failure to error
WMCore_t.WorkQueue_t.Policy_t.Start_t.Dataset_t.DatasetTestCase:testWhiteBlackLists changed from failure to error
WMCore_t.WorkQueue_t.Policy_t.Start_t.ResubmitBlock_t.ResubmitBlockTest:testEmptyACDC changed from success to error
WMCore_t.WorkQueue_t.Policy_t.Start_t.ResubmitBlock_t.ResubmitBlockTest:testUnsupportedACDC changed from success to error
WMCore_t.WorkQueue_t.WMBSHelper_t.WMBSHelperTest:testCreateSubscription changed from success to error
WMCore_t.WorkQueue_t.WMBSHelper_t.WMBSHelperTest:testDuplicateFileInsert changed from success to error
WMCore_t.WorkQueue_t.WMBSHelper_t.WMBSHelperTest:testKillWorkflow changed from success to error
WMCore_t.WorkQueue_t.WMBSHelper_t.WMBSHelperTest:testLumiMaskRestrictionsKO changed from success to error
WMCore_t.WorkQueue_t.WMBSHelper_t.WMBSHelperTest:testLumiMaskRestrictionsOK changed from success to error
WMCore_t.WorkQueue_t.WMBSHelper_t.WMBSHelperTest:testParentage changed from success to error
WMCore_t.WorkQueue_t.WMBSHelper_t.WMBSHelperTest:testReReco changed from success to error
WMCore_t.WorkQueue_t.WMBSHelper_t.WMBSHelperTest:testReRecoBlackRunRestriction changed from success to error
WMCore_t.WorkQueue_t.WMBSHelper_t.WMBSHelperTest:testReRecoWhiteRunRestriction changed from success to error
WMCore_t.WorkQueue_t.WMBSHelper_t.WMBSHelperTest:testTruncatedWFInsertion changed from success to error
WMCore_t.WorkQueue_t.WorkQueueBackend_t.WorkQueueBackendTest:testDuplicateInsertion changed from success to error
WMCore_t.WorkQueue_t.WorkQueueBackend_t.WorkQueueBackendTest:testPriority changed from success to error
WMCore_t.WorkQueue_t.WorkQueue_t.WorkQueueTest:test0eventBlock changed from failure to error
WMCore_t.WorkQueue_t.WorkQueue_t.WorkQueueTest:testBlackList changed from failure to error
WMCore_t.WorkQueue_t.WorkQueue_t.WorkQueueTest:testCancelWork changed from failure to error
WMCore_t.WorkQueue_t.WorkQueue_t.WorkQueueTest:testCancelWorkGlobal changed from failure to error
WMCore_t.WorkQueue_t.WorkQueue_t.WorkQueueTest:testCloseWorkOpenBlocks changed from failure to error
WMCore_t.WorkQueue_t.WorkQueue_t.WorkQueueTest:testCloseWorkTimeout changed from success to error
WMCore_t.WorkQueue_t.WorkQueue_t.WorkQueueTest:testConflicts changed from failure to error
WMCore_t.WorkQueue_t.WorkQueue_t.WorkQueueTest:testDeleteWork changed from failure to error
WMCore_t.WorkQueue_t.WorkQueue_t.WorkQueueTest:testDrainMode changed from success to error
WMCore_t.WorkQueue_t.WorkQueue_t.WorkQueueTest:testEndPolicyNegotiating changed from failure to error
WMCore_t.WorkQueue_t.WorkQueue_t.WorkQueueTest:testFailRequestAfterTimeout changed from success to error
WMCore_t.WorkQueue_t.WorkQueue_t.WorkQueueTest:testGlobalBlockSplitting changed from failure to error
WMCore_t.WorkQueue_t.WorkQueue_t.WorkQueueTest:testGlobalDatasetSplitting changed from failure to error
WMCore_t.WorkQueue_t.WorkQueue_t.WorkQueueTest:testIgnoreDuplicates changed from success to error
WMCore_t.WorkQueue_t.WorkQueue_t.WorkQueueTest:testInvalidSpecs changed from success to error
WMCore_t.WorkQueue_t.WorkQueue_t.WorkQueueTest:testMultiTaskProduction changed from success to error
WMCore_t.WorkQueue_t.WorkQueue_t.WorkQueueTest:testMultipleTeams changed from failure to error
WMCore_t.WorkQueue_t.WorkQueue_t.WorkQueueTest:testOpenBlocks changed from failure to error
WMCore_t.WorkQueue_t.WorkQueue_t.WorkQueueTest:testParentProcessing changed from failure to error
WMCore_t.WorkQueue_t.WorkQueue_t.WorkQueueTest:testPileupOnProduction changed from success to error
WMCore_t.WorkQueue_t.WorkQueue_t.WorkQueueTest:testPrioritiesWorkPolling changed from failure to error
WMCore_t.WorkQueue_t.WorkQueue_t.WorkQueueTest:testPriority changed from success to error
WMCore_t.WorkQueue_t.WorkQueue_t.WorkQueueTest:testProcessing changed from failure to error
WMCore_t.WorkQueue_t.WorkQueue_t.WorkQueueTest:testProcessingWithContinuousSplitting changed from failure to error
WMCore_t.WorkQueue_t.WorkQueue_t.WorkQueueTest:testProcessingWithPileup changed from failure to error
WMCore_t.WorkQueue_t.WorkQueue_t.WorkQueueTest:testProduction changed from success to error
WMCore_t.WorkQueue_t.WorkQueue_t.WorkQueueTest:testProductionMultiQueue changed from failure to error
WMCore_t.WorkQueue_t.WorkQueue_t.WorkQueueTest:testQueueChaining changed from failure to error
WMCore_t.WorkQueue_t.WorkQueue_t.WorkQueueTest:testQueueChainingStatusUpdates changed from failure to error
WMCore_t.WorkQueue_t.WorkQueue_t.WorkQueueTest:testResetWork changed from failure to error
WMCore_t.WorkQueue_t.WorkQueue_t.WorkQueueTest:testResubmissionWithParentsWorkflow changed from success to error
WMCore_t.WorkQueue_t.WorkQueue_t.WorkQueueTest:testResubmissionWorkflow changed from failure to error
WMCore_t.WorkQueue_t.WorkQueue_t.WorkQueueTest:testResubmissionWorkflowSiteWhitelistLocations changed from failure to error
WMCore_t.WorkQueue_t.WorkQueue_t.WorkQueueTest:testSiteStatus changed from failure to error
WMCore_t.WorkQueue_t.WorkQueue_t.WorkQueueTest:testSitesFromResourceControl changed from failure to error
WMCore_t.WorkQueue_t.WorkQueue_t.WorkQueueTest:testSplittingLargeInputs changed from failure to error
WMCore_t.WorkQueue_t.WorkQueue_t.WorkQueueTest:testTeams changed from failure to error
WMCore_t.WorkQueue_t.WorkQueue_t.WorkQueueTest:testThrottling changed from failure to error
WMCore_t.WorkQueue_t.WorkQueue_t.WorkQueueTest:testWMBSInjectionStatus changed from failure to error

Previously working unit tests have failed!

test this please

It seems to me that majority of unit tests failed due to simple oversight on my sight in pycurl manager. In particular there are plenty of POST calls which uses empty params dict. In that case I fixed the problem in this PR: https://github.com/dmwm/WMCore/pull/6347 Please accept 6347 and then re-test this PR with this fix.

test this please

test this please

Thanks Valentin. I put a copy/paste error in Jenkins. :-1:

I fixed another bug in pycurl_manager, see https://github.com/dmwm/WMCore/pull/6355. So we need to merge #6355 and retest this PR again.

Ok, let me do that.  Have not got the automated stuff yet. Maybe tomorrow.

Ok, I have started a new baseline. When it completes you should see a message in https://github.com/dmwm/ContinuousIntegration/issues/6#issuecomment-150592973 after that you should be able to request that Jenkins starts a new round here and it should be against that new baseline.

Is there a reason you are not just adding the commits to pycurl_manager to this branch? Seems easier.

Is there a reason you are not just adding the commits to pycurl_manager to this branch? Seems easier.

Sorry I haven't thought about that. Why didn't you say it earlier? It is all your fault. :smile:
@vkuznet, Valentin, feel free to add this one on your patch if you find any bugs next time. I can just close this one.

Hmm, I don't think it a good idea. This PR is simple and transparent, as well
as other PRs I make for pycurl_manager. They stay independent. But if you want
everything in one go then of course we can combine both.
On  0, ticoann notifications@github.com wrote:

Is there a reason you are not just adding the commits to pycurl_manager to this branch? Seems easier.

Sorry I haven't thought about that. Why didn't you say it earlier? It is all your fault. :smile:
@vkuznet, Valentin, feel free to add this one on your patch if you find any bugs next time. I can just close this one.

Reply to this email directly or view it on GitHub:
https://github.com/dmwm/WMCore/pull/5845#issuecomment-150607630

Just asking. Do whatever makes the most sense to you.

Sure Valentin, thanks.

test this please

replaced by #6360

authors: DMWMBot ericvaandering ticoann vkuznet