text:
PHOENIX-6343 : Phoenix allows duplicate column names when one of them is a primary key

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
4m 43s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ 4.x Compile Tests _

+1 :green_heart:
mvninstall
14m 17s
4.x passed

+1 :green_heart:
compile
1m  1s
4.x passed

+1 :green_heart:
checkstyle
1m 37s
4.x passed

+1 :green_heart:
javadoc
0m 45s
4.x passed

+0 :ok:
spotbugs
3m  0s
phoenix-core in 4.x has 945 extant spotbugs warnings.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
5m 51s
the patch passed

+1 :green_heart:
compile
1m  0s
the patch passed

+1 :green_heart:
javac
1m  0s
the patch passed

-1 :x:
checkstyle
1m 39s
phoenix-core: The patch generated 2 new + 2856 unchanged - 1 fixed = 2858 total (was 2857)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
javadoc
0m 45s
the patch passed

+1 :green_heart:
spotbugs
3m  9s
the patch passed

_ Other Tests _

-1 :x:
unit
1m 23s
phoenix-core in the patch failed.

+1 :green_heart:
asflicense
0m 10s
The patch does not generate ASF License warnings.

40m 46s

Reason
Tests

Failed junit tests
phoenix.query.QueryPlanTest

phoenix.util.json.JsonUpsertExecutorTest

phoenix.index.IndexScrutinyMapperTest

phoenix.compile.QueryOptimizerTest

phoenix.query.ExplainPlanTextTest

phoenix.schema.RowKeyValueAccessorTest

phoenix.compile.QueryMetaDataTest

phoenix.schema.MutationTest

phoenix.mapreduce.index.IndexScrutinyTableOutputTest

phoenix.query.PropertyPolicyProviderTest

phoenix.schema.MetaDataClientTest

phoenix.schema.RowKeySchemaTest

phoenix.jdbc.PhoenixResultSetMetadataTest

phoenix.index.VerifySingleIndexRowTest

phoenix.util.PhoenixRuntimeTest

phoenix.compile.LimitCompilerTest

phoenix.query.OrderByTest

phoenix.compile.CreateTableCompilerTest

phoenix.util.ScanUtilTest

phoenix.util.csv.StringToArrayConverterTest

phoenix.index.IndexMaintainerTest

phoenix.query.KeyRangeClipTest

phoenix.jdbc.PhoenixPreparedStatementTest

phoenix.compile.StatementHintsCompilationTest

phoenix.query.ParallelIteratorsSplitTest

phoenix.expression.RoundFloorCeilExpressionsTest

phoenix.jdbc.PhoenixDriverTest

phoenix.index.PrepareIndexMutationsForRebuildTest

phoenix.util.csv.CsvUpsertExecutorTest

phoenix.util.PhoenixEncodeDecodeTest

phoenix.query.ScannerLeaseRenewalTest

phoenix.compile.HavingCompilerTest

phoenix.compile.TenantSpecificViewIndexCompileTest

phoenix.compile.WhereOptimizerTest

phoenix.iterate.RowKeyOrderedAggregateResultIteratorTest

phoenix.compile.QueryCompilerTest

phoenix.mapreduce.util.PhoenixConfigurationUtilTest

phoenix.compile.SelectStatementRewriterTest

phoenix.compile.CursorCompilerTest

phoenix.compile.PostIndexDDLCompilerTest

phoenix.iterate.AggregateResultScannerTest

phoenix.compile.WhereCompilerTest

phoenix.hbase.index.covered.NonTxIndexBuilderTest

phoenix.compile.ViewCompilerTest

phoenix.expression.NullValueTest

phoenix.compile.JoinQueryCompilerTest

phoenix.mapreduce.util.IndexColumnNamesTest

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1118/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/phoenix/pull/1118

Optional Tests
dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile

uname
Linux c38352c577bc 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev/phoenix-personality.sh

git revision
4.x / 44d4402

Default Java
Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08

checkstyle
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1118/1/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt

unit
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1118/1/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt

Test Results
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1118/1/testReport/

Max. process+thread count
463 (vs. ulimit of 30000)

modules
C: phoenix-core U: phoenix-core

Console output
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1118/1/console

versions
git=2.7.4 maven=3.3.9 spotbugs=4.1.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
4m 43s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ 4.x Compile Tests _

+1 :green_heart:
mvninstall
14m 17s
4.x passed

+1 :green_heart:
compile
1m  1s
4.x passed

+1 :green_heart:
checkstyle
1m 37s
4.x passed

+1 :green_heart:
javadoc
0m 45s
4.x passed

+0 :ok:
spotbugs
3m  0s
phoenix-core in 4.x has 945 extant spotbugs warnings.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
5m 51s
the patch passed

+1 :green_heart:
compile
1m  0s
the patch passed

+1 :green_heart:
javac
1m  0s
the patch passed

-1 :x:
checkstyle
1m 39s
phoenix-core: The patch generated 2 new + 2856 unchanged - 1 fixed = 2858 total (was 2857)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
javadoc
0m 45s
the patch passed

+1 :green_heart:
spotbugs
3m  9s
the patch passed

_ Other Tests _

-1 :x:
unit
1m 23s
phoenix-core in the patch failed.

+1 :green_heart:
asflicense
0m 10s
The patch does not generate ASF License warnings.

40m 46s

Reason
Tests

Failed junit tests
phoenix.query.QueryPlanTest

phoenix.util.json.JsonUpsertExecutorTest

phoenix.index.IndexScrutinyMapperTest

phoenix.compile.QueryOptimizerTest

phoenix.query.ExplainPlanTextTest

phoenix.schema.RowKeyValueAccessorTest

phoenix.compile.QueryMetaDataTest

phoenix.schema.MutationTest

phoenix.mapreduce.index.IndexScrutinyTableOutputTest

phoenix.query.PropertyPolicyProviderTest

phoenix.schema.MetaDataClientTest

phoenix.schema.RowKeySchemaTest

phoenix.jdbc.PhoenixResultSetMetadataTest

phoenix.index.VerifySingleIndexRowTest

phoenix.util.PhoenixRuntimeTest

phoenix.compile.LimitCompilerTest

phoenix.query.OrderByTest

phoenix.compile.CreateTableCompilerTest

phoenix.util.ScanUtilTest

phoenix.util.csv.StringToArrayConverterTest

phoenix.index.IndexMaintainerTest

phoenix.query.KeyRangeClipTest

phoenix.jdbc.PhoenixPreparedStatementTest

phoenix.compile.StatementHintsCompilationTest

phoenix.query.ParallelIteratorsSplitTest

phoenix.expression.RoundFloorCeilExpressionsTest

phoenix.jdbc.PhoenixDriverTest

phoenix.index.PrepareIndexMutationsForRebuildTest

phoenix.util.csv.CsvUpsertExecutorTest

phoenix.util.PhoenixEncodeDecodeTest

phoenix.query.ScannerLeaseRenewalTest

phoenix.compile.HavingCompilerTest

phoenix.compile.TenantSpecificViewIndexCompileTest

phoenix.compile.WhereOptimizerTest

phoenix.iterate.RowKeyOrderedAggregateResultIteratorTest

phoenix.compile.QueryCompilerTest

phoenix.mapreduce.util.PhoenixConfigurationUtilTest

phoenix.compile.SelectStatementRewriterTest

phoenix.compile.CursorCompilerTest

phoenix.compile.PostIndexDDLCompilerTest

phoenix.iterate.AggregateResultScannerTest

phoenix.compile.WhereCompilerTest

phoenix.hbase.index.covered.NonTxIndexBuilderTest

phoenix.compile.ViewCompilerTest

phoenix.expression.NullValueTest

phoenix.compile.JoinQueryCompilerTest

phoenix.mapreduce.util.IndexColumnNamesTest

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1118/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/phoenix/pull/1118

Optional Tests
dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile

uname
Linux c38352c577bc 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev/phoenix-personality.sh

git revision
4.x / 44d4402

Default Java
Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08

checkstyle
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1118/1/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt

unit
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1118/1/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt

Test Results
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1118/1/testReport/

Max. process+thread count
463 (vs. ulimit of 30000)

modules
C: phoenix-core U: phoenix-core

Console output
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1118/1/console

versions
git=2.7.4 maven=3.3.9 spotbugs=4.1.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 37s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ 4.x Compile Tests _

+1 :green_heart:
mvninstall
14m 39s
4.x passed

+1 :green_heart:
compile
1m  1s
4.x passed

+1 :green_heart:
checkstyle
1m 42s
4.x passed

+1 :green_heart:
javadoc
0m 46s
4.x passed

+0 :ok:
spotbugs
3m  2s
phoenix-core in 4.x has 945 extant spotbugs warnings.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
5m 54s
the patch passed

+1 :green_heart:
compile
1m  1s
the patch passed

+1 :green_heart:
javac
1m  1s
the patch passed

-1 :x:
checkstyle
1m 41s
phoenix-core: The patch generated 4 new + 3014 unchanged - 0 fixed = 3018 total (was 3014)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
javadoc
0m 44s
the patch passed

+1 :green_heart:
spotbugs
3m 11s
the patch passed

_ Other Tests _

-1 :x:
unit
1m 32s
phoenix-core in the patch failed.

+1 :green_heart:
asflicense
0m 11s
The patch does not generate ASF License warnings.

37m 25s

Reason
Tests

Failed junit tests
phoenix.compile.QueryOptimizerTest

phoenix.schema.MutationTest

phoenix.compile.QueryCompilerTest

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1118/2/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/phoenix/pull/1118

Optional Tests
dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile

uname
Linux baef993b88fe 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev/phoenix-personality.sh

git revision
4.x / 44d4402

Default Java
Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08

checkstyle
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1118/2/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt

unit
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1118/2/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt

Test Results
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1118/2/testReport/

Max. process+thread count
464 (vs. ulimit of 30000)

modules
C: phoenix-core U: phoenix-core

Console output
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1118/2/console

versions
git=2.7.4 maven=3.3.9 spotbugs=4.1.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 37s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ 4.x Compile Tests _

+1 :green_heart:
mvninstall
14m 39s
4.x passed

+1 :green_heart:
compile
1m  1s
4.x passed

+1 :green_heart:
checkstyle
1m 42s
4.x passed

+1 :green_heart:
javadoc
0m 46s
4.x passed

+0 :ok:
spotbugs
3m  2s
phoenix-core in 4.x has 945 extant spotbugs warnings.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
5m 54s
the patch passed

+1 :green_heart:
compile
1m  1s
the patch passed

+1 :green_heart:
javac
1m  1s
the patch passed

-1 :x:
checkstyle
1m 41s
phoenix-core: The patch generated 4 new + 3014 unchanged - 0 fixed = 3018 total (was 3014)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
javadoc
0m 44s
the patch passed

+1 :green_heart:
spotbugs
3m 11s
the patch passed

_ Other Tests _

-1 :x:
unit
1m 32s
phoenix-core in the patch failed.

+1 :green_heart:
asflicense
0m 11s
The patch does not generate ASF License warnings.

37m 25s

Reason
Tests

Failed junit tests
phoenix.compile.QueryOptimizerTest

phoenix.schema.MutationTest

phoenix.compile.QueryCompilerTest

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1118/2/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/phoenix/pull/1118

Optional Tests
dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile

uname
Linux baef993b88fe 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev/phoenix-personality.sh

git revision
4.x / 44d4402

Default Java
Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08

checkstyle
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1118/2/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt

unit
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1118/2/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt

Test Results
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1118/2/testReport/

Max. process+thread count
464 (vs. ulimit of 30000)

modules
C: phoenix-core U: phoenix-core

Console output
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1118/2/console

versions
git=2.7.4 maven=3.3.9 spotbugs=4.1.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Shall we disable allowing same column name as primary key under any columnFamily or should we just disable it under default columnFamily only?

Shall we disable allowing same column name as primary key under any columnFamily or should we just disable it under default columnFamily only?

Good question.
I don't know enough about how we handle the PKs to answer it.

Do we store the PK field(s) in actual cell, or are they only present in the rowkey ?
What happens when you specify a CF for a PK field ? is it even valid ?

This should be easy enough to check with hbase shell.
I'll try to check later today if you can't answer these of the top of your head.

Good question.
I don't know enough about how we handle the PKs to answer it.

Do we store the PK field(s) in actual cell, or are they only present in the rowkey ?
What happens when you specify a CF for a PK field ? is it even valid ?

This should be easy enough to check with hbase shell.
I'll try to check later today if you can't answer these of the top of your head.

Nice points.

Do we store the PK field(s) in actual cell, or are they only present in the rowkey ?

For user created tables, their pk (and non-pk) columns are actually rowkeys in SYSTEM.CATALOG. The cells represent specific properties like DATA_TYPE, NULLABLE etc.

What happens when you specify a CF for a PK field ? is it even valid ?

I think we can't specify CF for PK. We have this special Exception for it: PRIMARY_KEY_WITH_FAMILY_NAME
Based on some unit tests written very initially, it seems we do allow creating same column name (with user defined columnFamily) as Pk column name, but that is the very reason why the same would apply to default columnFamily and hence, any user created table can have Pk and non-Pk column names same.

Nice points.

Do we store the PK field(s) in actual cell, or are they only present in the rowkey ?

For user created tables, their pk (and non-pk) columns are actually rowkeys in SYSTEM.CATALOG. The cells represent specific properties like DATA_TYPE, NULLABLE etc.

What happens when you specify a CF for a PK field ? is it even valid ?

I think we can't specify CF for PK. We have this special Exception for it: PRIMARY_KEY_WITH_FAMILY_NAME
Based on some unit tests written very initially, it seems we do allow creating same column name (with user defined columnFamily) as Pk column name, but that is the very reason why the same would apply to default columnFamily and hence, any user created table can have Pk and non-Pk column names same.

Thanks for checking.
In this case, IMO we should handle this like the standard columns.
If we allow the same name in different column families, then we should only forbid matching names in the default CF.
If we don't allow the same name in differenct CFs, then we should forbid matching names in all CFs.

Thanks for checking.
In this case, IMO we should handle this like the standard columns.
If we allow the same name in different column families, then we should only forbid matching names in the default CF.
If we don't allow the same name in differenct CFs, then we should forbid matching names in all CFs.

It seems from visibility viewpoint, the problem remains same. Even with user defined CF, we see same column name as pk column.
> create table tab3 (col1 INTEGER NOT NULL PRIMARY KEY, col2 INTEGER, a.col1 INTEGER);
No rows affected (1.254 seconds)

> select * from tab3;
+-------+-------+-------+
| COL1  | COL2  | COL1  |
+-------+-------+-------+
+-------+-------+-------+

> create table table4 (col1 INTEGER NOT NULL PRIMARY KEY, col2 INTEGER, a.col1 INTEGER, b.col1 INTEGER);
No rows affected (1.254 seconds)
0: jdbc:phoenix:> select * from table4;
+-------+-------+-------+-------+
| COL1  | COL2  | COL1  | COL1  |
+-------+-------+-------+-------+
+-------+-------+-------+-------+
No rows selected (0.01 seconds)

It seems from visibility viewpoint, the problem remains same. Even with user defined CF, we see same column name as pk column.
> create table tab3 (col1 INTEGER NOT NULL PRIMARY KEY, col2 INTEGER, a.col1 INTEGER);
No rows affected (1.254 seconds)

> select * from tab3;
+-------+-------+-------+
| COL1  | COL2  | COL1  |
+-------+-------+-------+
+-------+-------+-------+

> create table table4 (col1 INTEGER NOT NULL PRIMARY KEY, col2 INTEGER, a.col1 INTEGER, b.col1 INTEGER);
No rows affected (1.254 seconds)
0: jdbc:phoenix:> select * from table4;
+-------+-------+-------+-------+
| COL1  | COL2  | COL1  | COL1  |
+-------+-------+-------+-------+
+-------+-------+-------+-------+
No rows selected (0.01 seconds)

That is more of an sqlline/presentation problem.
You can address the different columns via the JDBC API unambigously ( I hope, though I didn't test this), while it's not possible in the PK vs default CF case.
Based on this, we should only disallow the PK names in the default CF.

That is more of an sqlline/presentation problem.
You can address the different columns via the JDBC API unambigously ( I hope, though I didn't test this), while it's not possible in the PK vs default CF case.
Based on this, we should only disallow the PK names in the default CF.

i.e you can get rs.getString("cfa.a"), and rs.getString("cfb.a"), but if you cannot get do the same for PK.a vs default cf.a .

i.e you can get rs.getString("cfa.a"), and rs.getString("cfb.a"), but if you cannot get do the same for PK.a vs default cf.a .

Right, mostly it is representation problem. You are right, we should stick to default CF.

Right, mostly it is representation problem. You are right, we should stick to default CF.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 31s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ 4.x Compile Tests _

+1 :green_heart:
mvninstall
14m 31s
4.x passed

+1 :green_heart:
compile
1m  1s
4.x passed

+1 :green_heart:
checkstyle
1m 33s
4.x passed

+1 :green_heart:
javadoc
0m 45s
4.x passed

+0 :ok:
spotbugs
3m  0s
phoenix-core in 4.x has 945 extant spotbugs warnings.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
5m 49s
the patch passed

+1 :green_heart:
compile
1m  2s
the patch passed

+1 :green_heart:
javac
1m  2s
the patch passed

-1 :x:
checkstyle
1m 43s
phoenix-core: The patch generated 12 new + 3013 unchanged - 1 fixed = 3025 total (was 3014)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
javadoc
0m 44s
the patch passed

+1 :green_heart:
spotbugs
3m 12s
the patch passed

_ Other Tests _

-1 :x:
unit
1m 31s
phoenix-core in the patch failed.

+1 :green_heart:
asflicense
0m 10s
The patch does not generate ASF License warnings.

36m 57s

Reason
Tests

Failed junit tests
phoenix.compile.QueryOptimizerTest

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1118/3/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/phoenix/pull/1118

Optional Tests
dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile

uname
Linux fa0bb6a2a1d1 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev/phoenix-personality.sh

git revision
4.x / 44d4402

Default Java
Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08

checkstyle
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1118/3/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt

unit
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1118/3/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt

Test Results
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1118/3/testReport/

Max. process+thread count
463 (vs. ulimit of 30000)

modules
C: phoenix-core U: phoenix-core

Console output
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1118/3/console

versions
git=2.7.4 maven=3.3.9 spotbugs=4.1.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 31s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ 4.x Compile Tests _

+1 :green_heart:
mvninstall
14m 31s
4.x passed

+1 :green_heart:
compile
1m  1s
4.x passed

+1 :green_heart:
checkstyle
1m 33s
4.x passed

+1 :green_heart:
javadoc
0m 45s
4.x passed

+0 :ok:
spotbugs
3m  0s
phoenix-core in 4.x has 945 extant spotbugs warnings.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
5m 49s
the patch passed

+1 :green_heart:
compile
1m  2s
the patch passed

+1 :green_heart:
javac
1m  2s
the patch passed

-1 :x:
checkstyle
1m 43s
phoenix-core: The patch generated 12 new + 3013 unchanged - 1 fixed = 3025 total (was 3014)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
javadoc
0m 44s
the patch passed

+1 :green_heart:
spotbugs
3m 12s
the patch passed

_ Other Tests _

-1 :x:
unit
1m 31s
phoenix-core in the patch failed.

+1 :green_heart:
asflicense
0m 10s
The patch does not generate ASF License warnings.

36m 57s

Reason
Tests

Failed junit tests
phoenix.compile.QueryOptimizerTest

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1118/3/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/phoenix/pull/1118

Optional Tests
dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile

uname
Linux fa0bb6a2a1d1 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev/phoenix-personality.sh

git revision
4.x / 44d4402

Default Java
Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08

checkstyle
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1118/3/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt

unit
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1118/3/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt

Test Results
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1118/3/testReport/

Max. process+thread count
463 (vs. ulimit of 30000)

modules
C: phoenix-core U: phoenix-core

Console output
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1118/3/console

versions
git=2.7.4 maven=3.3.9 spotbugs=4.1.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 32s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ 4.x Compile Tests _

+1 :green_heart:
mvninstall
14m 40s
4.x passed

+1 :green_heart:
compile
1m  1s
4.x passed

+1 :green_heart:
checkstyle
1m 40s
4.x passed

+1 :green_heart:
javadoc
0m 44s
4.x passed

+0 :ok:
spotbugs
2m 59s
phoenix-core in 4.x has 945 extant spotbugs warnings.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
5m 52s
the patch passed

+1 :green_heart:
compile
1m  1s
the patch passed

+1 :green_heart:
javac
1m  1s
the patch passed

-1 :x:
checkstyle
1m 43s
phoenix-core: The patch generated 12 new + 3013 unchanged - 1 fixed = 3025 total (was 3014)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
javadoc
0m 45s
the patch passed

+1 :green_heart:
spotbugs
3m  9s
the patch passed

_ Other Tests _

-1 :x:
unit
1m 31s
phoenix-core in the patch failed.

+1 :green_heart:
asflicense
0m 10s
The patch does not generate ASF License warnings.

37m 13s

Reason
Tests

Failed junit tests
phoenix.compile.QueryOptimizerTest

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1118/4/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/phoenix/pull/1118

Optional Tests
dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile

uname
Linux 1c873547c43e 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev/phoenix-personality.sh

git revision
4.x / 44d4402

Default Java
Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08

checkstyle
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1118/4/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt

unit
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1118/4/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt

Test Results
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1118/4/testReport/

Max. process+thread count
491 (vs. ulimit of 30000)

modules
C: phoenix-core U: phoenix-core

Console output
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1118/4/console

versions
git=2.7.4 maven=3.3.9 spotbugs=4.1.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 32s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ 4.x Compile Tests _

+1 :green_heart:
mvninstall
14m 40s
4.x passed

+1 :green_heart:
compile
1m  1s
4.x passed

+1 :green_heart:
checkstyle
1m 40s
4.x passed

+1 :green_heart:
javadoc
0m 44s
4.x passed

+0 :ok:
spotbugs
2m 59s
phoenix-core in 4.x has 945 extant spotbugs warnings.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
5m 52s
the patch passed

+1 :green_heart:
compile
1m  1s
the patch passed

+1 :green_heart:
javac
1m  1s
the patch passed

-1 :x:
checkstyle
1m 43s
phoenix-core: The patch generated 12 new + 3013 unchanged - 1 fixed = 3025 total (was 3014)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
javadoc
0m 45s
the patch passed

+1 :green_heart:
spotbugs
3m  9s
the patch passed

_ Other Tests _

-1 :x:
unit
1m 31s
phoenix-core in the patch failed.

+1 :green_heart:
asflicense
0m 10s
The patch does not generate ASF License warnings.

37m 13s

Reason
Tests

Failed junit tests
phoenix.compile.QueryOptimizerTest

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1118/4/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/phoenix/pull/1118

Optional Tests
dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile

uname
Linux 1c873547c43e 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev/phoenix-personality.sh

git revision
4.x / 44d4402

Default Java
Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08

checkstyle
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1118/4/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt

unit
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1118/4/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt

Test Results
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1118/4/testReport/

Max. process+thread count
491 (vs. ulimit of 30000)

modules
C: phoenix-core U: phoenix-core

Console output
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1118/4/console

versions
git=2.7.4 maven=3.3.9 spotbugs=4.1.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Latest changes include some minor changes in PhoenixLoggingMetricsIT and QueryOptimizerTest. Let's see how QA goes (build#6 onwards).

Latest changes include some minor changes in PhoenixLoggingMetricsIT and QueryOptimizerTest. Let's see how QA goes (build#6 onwards).

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 32s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 1 new or modified test files.

_ 4.x Compile Tests _

+1 :green_heart:
mvninstall
14m 26s
4.x passed

+1 :green_heart:
compile
1m  2s
4.x passed

+1 :green_heart:
checkstyle
1m 41s
4.x passed

+1 :green_heart:
javadoc
0m 46s
4.x passed

+0 :ok:
spotbugs
2m 58s
phoenix-core in 4.x has 945 extant spotbugs warnings.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
6m  3s
the patch passed

+1 :green_heart:
compile
1m  1s
the patch passed

+1 :green_heart:
javac
1m  1s
the patch passed

-1 :x:
checkstyle
1m 38s
phoenix-core: The patch generated 12 new + 3013 unchanged - 1 fixed = 3025 total (was 3014)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
javadoc
0m 45s
the patch passed

+1 :green_heart:
spotbugs
3m 10s
the patch passed

_ Other Tests _

-1 :x:
unit
138m 16s
phoenix-core in the patch failed.

+1 :green_heart:
asflicense
0m 48s
The patch does not generate ASF License warnings.

175m 51s

Reason
Tests

Failed junit tests
phoenix.monitoring.PhoenixLoggingMetricsIT

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1118/5/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/phoenix/pull/1118

Optional Tests
dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile

uname
Linux b3ffd620027c 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev/phoenix-personality.sh

git revision
4.x / 44d4402

Default Java
Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08

checkstyle
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1118/5/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt

unit
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1118/5/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt

Test Results
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1118/5/testReport/

Max. process+thread count
5684 (vs. ulimit of 30000)

modules
C: phoenix-core U: phoenix-core

Console output
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1118/5/console

versions
git=2.7.4 maven=3.3.9 spotbugs=4.1.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 32s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 1 new or modified test files.

_ 4.x Compile Tests _

+1 :green_heart:
mvninstall
14m 26s
4.x passed

+1 :green_heart:
compile
1m  2s
4.x passed

+1 :green_heart:
checkstyle
1m 41s
4.x passed

+1 :green_heart:
javadoc
0m 46s
4.x passed

+0 :ok:
spotbugs
2m 58s
phoenix-core in 4.x has 945 extant spotbugs warnings.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
6m  3s
the patch passed

+1 :green_heart:
compile
1m  1s
the patch passed

+1 :green_heart:
javac
1m  1s
the patch passed

-1 :x:
checkstyle
1m 38s
phoenix-core: The patch generated 12 new + 3013 unchanged - 1 fixed = 3025 total (was 3014)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
javadoc
0m 45s
the patch passed

+1 :green_heart:
spotbugs
3m 10s
the patch passed

_ Other Tests _

-1 :x:
unit
138m 16s
phoenix-core in the patch failed.

+1 :green_heart:
asflicense
0m 48s
The patch does not generate ASF License warnings.

175m 51s

Reason
Tests

Failed junit tests
phoenix.monitoring.PhoenixLoggingMetricsIT

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1118/5/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/phoenix/pull/1118

Optional Tests
dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile

uname
Linux b3ffd620027c 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev/phoenix-personality.sh

git revision
4.x / 44d4402

Default Java
Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08

checkstyle
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1118/5/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt

unit
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1118/5/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt

Test Results
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1118/5/testReport/

Max. process+thread count
5684 (vs. ulimit of 30000)

modules
C: phoenix-core U: phoenix-core

Console output
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1118/5/console

versions
git=2.7.4 maven=3.3.9 spotbugs=4.1.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 32s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 1 new or modified test files.

_ 4.x Compile Tests _

+1 :green_heart:
mvninstall
14m 38s
4.x passed

+1 :green_heart:
compile
1m  5s
4.x passed

+1 :green_heart:
checkstyle
1m 28s
4.x passed

+1 :green_heart:
javadoc
0m 49s
4.x passed

+0 :ok:
spotbugs
3m 10s
phoenix-core in 4.x has 945 extant spotbugs warnings.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
7m 50s
the patch passed

+1 :green_heart:
compile
1m 19s
the patch passed

+1 :green_heart:
javac
1m 19s
the patch passed

-1 :x:
checkstyle
1m 36s
phoenix-core: The patch generated 13 new + 3013 unchanged - 2 fixed = 3026 total (was 3015)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
javadoc
1m  0s
the patch passed

+1 :green_heart:
spotbugs
4m 42s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
143m 39s
phoenix-core in the patch passed.

+1 :green_heart:
asflicense
0m 12s
The patch does not generate ASF License warnings.

182m 57s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1118/6/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/phoenix/pull/1118

Optional Tests
dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile

uname
Linux b54fec3632d7 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev/phoenix-personality.sh

git revision
4.x / 44d4402

Default Java
Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08

checkstyle
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1118/6/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt

Test Results
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1118/6/testReport/

Max. process+thread count
5801 (vs. ulimit of 30000)

modules
C: phoenix-core U: phoenix-core

Console output
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1118/6/console

versions
git=2.7.4 maven=3.3.9 spotbugs=4.1.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 32s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 1 new or modified test files.

_ 4.x Compile Tests _

+1 :green_heart:
mvninstall
14m 38s
4.x passed

+1 :green_heart:
compile
1m  5s
4.x passed

+1 :green_heart:
checkstyle
1m 28s
4.x passed

+1 :green_heart:
javadoc
0m 49s
4.x passed

+0 :ok:
spotbugs
3m 10s
phoenix-core in 4.x has 945 extant spotbugs warnings.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
7m 50s
the patch passed

+1 :green_heart:
compile
1m 19s
the patch passed

+1 :green_heart:
javac
1m 19s
the patch passed

-1 :x:
checkstyle
1m 36s
phoenix-core: The patch generated 13 new + 3013 unchanged - 2 fixed = 3026 total (was 3015)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
javadoc
1m  0s
the patch passed

+1 :green_heart:
spotbugs
4m 42s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
143m 39s
phoenix-core in the patch passed.

+1 :green_heart:
asflicense
0m 12s
The patch does not generate ASF License warnings.

182m 57s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1118/6/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/phoenix/pull/1118

Optional Tests
dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile

uname
Linux b54fec3632d7 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev/phoenix-personality.sh

git revision
4.x / 44d4402

Default Java
Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08

checkstyle
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1118/6/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt

Test Results
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1118/6/testReport/

Max. process+thread count
5801 (vs. ulimit of 30000)

modules
C: phoenix-core U: phoenix-core

Console output
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1118/6/console

versions
git=2.7.4 maven=3.3.9 spotbugs=4.1.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
4m 24s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 1 new or modified test files.

_ 4.x Compile Tests _

+1 :green_heart:
mvninstall
14m 43s
4.x passed

+1 :green_heart:
compile
1m  1s
4.x passed

+1 :green_heart:
checkstyle
1m 41s
4.x passed

+1 :green_heart:
javadoc
0m 45s
4.x passed

+0 :ok:
spotbugs
3m  1s
phoenix-core in 4.x has 945 extant spotbugs warnings.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
5m 43s
the patch passed

+1 :green_heart:
compile
0m 59s
the patch passed

+1 :green_heart:
javac
0m 59s
the patch passed

-1 :x:
checkstyle
1m 45s
phoenix-core: The patch generated 12 new + 3013 unchanged - 1 fixed = 3025 total (was 3014)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
javadoc
0m 44s
the patch passed

+1 :green_heart:
spotbugs
3m 13s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
195m 53s
phoenix-core in the patch passed.

+1 :green_heart:
asflicense
0m 12s
The patch does not generate ASF License warnings.

234m 57s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1118/7/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/phoenix/pull/1118

Optional Tests
dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile

uname
Linux e208e60b5d7f 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev/phoenix-personality.sh

git revision
4.x / 883170e

Default Java
Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08

checkstyle
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1118/7/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt

Test Results
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1118/7/testReport/

Max. process+thread count
5635 (vs. ulimit of 30000)

modules
C: phoenix-core U: phoenix-core

Console output
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1118/7/console

versions
git=2.7.4 maven=3.3.9 spotbugs=4.1.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

authors: stoty virajjasani

repo: apache/phoenix


text:
[SPARK-12337][SPARKR] Implement dropDuplicates() method of DataFrame in SparkR.

NAVER - http://www.naver.com/
3ourroom@naver.com 님께 보내신 메일 <[spark] [SPARK-12337][SPARKR] Implement dropDuplicates() method of DataFrame in SparkR. (#10309)> 이 다음과 같은 이유로 전송 실패했습니다.

받는 사람이 회원님의 메일을 수신차단 하였습니다.

Test build #47732 has started for PR 10309 at commit 45b76bc.

NAVER - http://www.naver.com/
3ourroom@naver.com 님께 보내신 메일 <Re: [spark] [SPARK-12337][SPARKR] Implement dropDuplicates() method of DataFrame in SparkR. (#10309)> 이 다음과 같은 이유로 전송 실패했습니다.

받는 사람이 회원님의 메일을 수신차단 하였습니다.

Test build #47732 has finished for PR 10309 at commit 45b76bc.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/47732/
Test PASSed.

ok, looks good

LGTM. Thanks @sun-rui - Merging this to master.

source: gharchive/pull-request

authors: 3ourroom AmplabJenkins SparkQA felixcheung shivaram sun-rui

repo: apache/spark

license_type: permissive

license_source: github-api


text:
STORM-2080: storm-submit-tools license check failure

Duplicated #1648 (STORM-2054)
Actually there's also a bug which doesn't handle relative path vs absolute path.

Oh, I missed that. I will comment there and, FYI, some license headers are not in the right form

authors: HeartSaVioR manuzhang

repo: apache/storm


text:
[WIP] chore: setup eslint and prettier

Appreciate it

@apclary Could you please setup a travis or circle ci build?

I threw together a quick travis-ci build, it fails though with a simple error I'm sure you can work out.
I put my non-working travis ci build in the travis branch. If I don't hear back from you by tonight I'll try to get a linux or mac OS going and work it out.

repo: apclary/dungeon-revealer

license: ISC


text:
spec: annotations from image manifest and CRM are merged

Couple of style nits but lgtm after that; also please adjust the commit message to the "spec: ..." format

LGTM, thank you!

authors: eyakubovich jonboulle

repo: appc/spec

license_source: bigquery


text:
Update TSC

@swift-ci please test

repo: apple/swift-driver


text:
 Adding support to compile with code coverage flags

@swift-ci smoke test

repo: apple/swift-package-manager


text:
need file after importing

No description provided.

source: gharchive/issue

repo: archko/AMupdf


text:
fix: extract truncate staging table in transaction

lgtm

authors: VifleY kuznetsovin

repo: arenadata/kafka-tarantool-loader


text:
Sort deployments in project by latest

Pushed the fix from this!!!

repo: argoapp-live/argo-react

license: MIT


text:
Meepo splits, if one clone dies, while other stays at the fountain

Not confirmed, but found related but, that meepo's clones not dies on fountain.

license: mit


text:
@orta => [AsyncImageLoading] Use actual -[NSError code] type.

Works for me :+1:

authors: alloy orta

repo: artsy/eigen


text:
Adds code coverage.

Adding something, do not merge yet

:+1:  Thanks for adding coverage to the redmine tests

Edna deserves all the credit, but was scared of this git merge, so I get all the credit...and the blame!!

@lukecampbell @FBRTMaka please review and merge if okay with you

reviewing!

damn. good. stuff. :+1:

authors: Bobfrat FBRTMaka oceanzus

repo: asascience-open/ooi-ui-services


text:
fix typo in sphinx auto api github url

Hi @hugufc, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, DNFBOT;

authors: dnfclas hugufc

repo: aspnet/ApiDocs


text:
Update Roslyn to 2.3.1

:shipit:

authors: mikeharder pranavkm

repo: aspnet/Mvc


text:
Support multiple meanings of the word

Is closed in #6

repo: augustjune/thesaurus-api


text:
capital H

My man

Coverage remained the same at 100.0% when pulling d1b090c3f6aa5539d84f1d8099b4734b44ed2fd9 on retlehs:patch-1 into 9954588eea24f58e26dd5644775a5f246b1d2279 on austinpray:master.

ty @coveralls

authors: austinpray coveralls retlehs

repo: austinpray/asset-builder


text:
Improve documentation

Could be useful: https://github.com/SwiftDocOrg/swift-doc#github-action

Since Apple made DocC available (and I was already familiar with it due to past work experience), I made a stub PR that would start to flesh out the docs using that setup and the code documentation already in place: https://github.com/automerge/automerge-swift/pull/43
DocC currently doesn't enable an easy "plop into GitHub pages" kind of flat HTML hosting scenario, but that's actively being worked on - and when available, I'd be happy to help set that up (including to the GitHub pages associated with this repo if you like). That said, the current DocC pieces do integrate nicely into Xcode for anyone wanting to work on or use automerge-swift as a dependency in their project.

repo: automerge/automerge-swift


text:
Adição do grupo de discussão sobre react

esta com erro no json @ronal2do

não vi que o type era pré definido.


text:
Updated Bootstrap Select to version 1.12.4

Coverage remained the same at 100.0% when pulling a3e9abc22844abf5ca1540986c2994c28381df65 on bselect-update into 0773596aa36a1e60116adb46980a09138fac0014 on master.

authors: coveralls gcotelli

repo: ba-st/Willow-Bootstrap


text:
Draw inspector dropdown to toggle logger methods

8051a90c86cc1b2fed25a7ad37672979b2131335

repo: bartlomiejwolk/logger


text:
Add Perfomance/Detect cop

One thing to consider - some people prefer find over detect, so there should be some configuration that would affect the message and the autocorrect.

:+1: Looks good. Great work!

Coverage increased (+0.0%) to 99.65% when pulling ec23fb10fceb3e4ea8a1a5cf6a2fa9e91475e2e0 on palkan:array_detect into c80ab2be9fc3b8c50427568484098a4998297c3f on bbatsov:master.

Coverage increased (+0.0%) to 99.65% when pulling ec23fb10fceb3e4ea8a1a5cf6a2fa9e91475e2e0 on palkan:array_detect into c80ab2be9fc3b8c50427568484098a4998297c3f on bbatsov:master.

Coverage increased (+0.0%) to 99.65% when pulling 0d8b2e27913c45a2e236cea38575bb9d4b8ee176 on palkan:array_detect into c80ab2be9fc3b8c50427568484098a4998297c3f on bbatsov:master.

Coverage increased (+0.0%) to 99.65% when pulling 0d8b2e27913c45a2e236cea38575bb9d4b8ee176 on palkan:array_detect into c80ab2be9fc3b8c50427568484098a4998297c3f on bbatsov:master.

Coverage decreased (-0.01%) to 99.64% when pulling 521c38e18d1c2f6e15c846b89898107a1b1d3a89 on palkan:array_detect into c80ab2be9fc3b8c50427568484098a4998297c3f on bbatsov:master.

Coverage decreased (-0.01%) to 99.64% when pulling 521c38e18d1c2f6e15c846b89898107a1b1d3a89 on palkan:array_detect into c80ab2be9fc3b8c50427568484098a4998297c3f on bbatsov:master.

Coverage decreased (-0.01%) to 99.64% when pulling 610609c0efbaee0743620e78d8a26db6402add6d on palkan:array_detect into c80ab2be9fc3b8c50427568484098a4998297c3f on bbatsov:master.

Coverage decreased (-0.01%) to 99.64% when pulling 610609c0efbaee0743620e78d8a26db6402add6d on palkan:array_detect into c80ab2be9fc3b8c50427568484098a4998297c3f on bbatsov:master.

Coverage decreased (-0.01%) to 99.64% when pulling 610609c0efbaee0743620e78d8a26db6402add6d on palkan:array_detect into c80ab2be9fc3b8c50427568484098a4998297c3f on bbatsov:master.

@palkan Some late comments for you. Can you take a look?

@jonas054
Opened new PR with fixes - #1715.

I had a problem with this cop with auto-correction of Datamapper select, from adapter.select() to adapter.find(), that doesn't exist in DM.
Can we only do the auto-correct if the word "adapter" doesn't exist before the select?

Please, provide full code snippet.

This was the diff:

DataMapper.repository(:default).adapter.select('select id from ....')

DataMapper.repository(:default).adapter.find('select id from ....')

Ok, got it.
Please open a new issue, I'm working on it.

Thanks a lot. Issue opened #1766

This can also be a problem with ActiveRecord (as it also has a select method). Probably the best approach would be to simply exclude the cop for such files. I don't think this can be handled in the code in any reasonable way (I certainly don't want to support a ton of special cases).

@bbatsov
I think we can)
Enumerable#select requires block (either normal block or ampersand-style block), so we can use this to distinguish from AR/DataMapper and others select. See PR.

authors: basex bbatsov coveralls jonas054 palkan

repo: bbatsov/rubocop


text:
Evaluate Cognito pricing model

count # of users in dev, test and prod keycloak instances.
look for the AWS Cognito pricing model.

Cognito charges based on the monthly active users (MAUs) only. A user is counted as an MAU if, within a calendar month, there is an identity operation related to that user, such as sign-up, sign-in, token refresh or password change.

Cognito charges differently based on the authentication type:

For users who sign in directly with their credentials from a User Pool or with social identity providers:

$0.0055

For users who sign in through SAML or OIDC federation:

$0.015

Based on the # of users through 07 realms in the prod Keycloak instance below:

min: 0
max 223,723 = $3,355.845
mean 4,535
sum 485,277 = $7,279.155

in the worst-case scenario when considering all users are active,
it will cost $3,355.845 by scaling in app-client level while $7,279.155 by scaling in user-pool level.

repo: bcgov/ocp-sso


text:
Add a "publish" branch of the GitHub repo, to be used instead of "master" for generating presentation data

This has been elaborated in a newer issue #330. So, I am closing this.

authors: maherou rinkug


text:
Login Cookie not working.

Fixed.

repo: bfwg/mypage


text:
Migrate to travis containers

Addresses part of #906

Do you think it makes sense to put the requirements files in a top-level ci directory? Otherwise users might think that these files are necessary to install scikit-bio.

authors: anderspitman jairideout

repo: biocore/scikit-bio


text:
Prepare 1.0

No exciting changes. Just bump this crate to 1.0 before it proliferates. It's an integration crate (enum Either used for crate interoperation) so we need to reach 1.0 as soon as possible.

cc @m4rw3r it's a pointless version bump in the short perspective (sorry), but being 1.0 has its own utility

repo: bluss/either


text:
If a file has its .boiler alternative, then ignore that file by default, it doesn't have to be ignored in .boilerplatoignore file

Fixed!

repo: boilerplato/boilerplato


text:
Add gulp-gzip

gulp-gzip/gulp-gzip.d.ts
check list

[ ] is collect naming convention?

https://www.npmjs.com/package/gulp-gzip
http://bower.io/search/?q=gulp-gzip
others?

[X] has a test file? (gulp-gzip/gulp-gzip-tests.ts or others)
[ ] pass the Travis-CI test?

@tkqubo thanks mate!

authors: tkqubo vvakame

repo: borisyankov/DefinitelyTyped


text:
Fixed issues with URIjs typing definitions for certain overloads of the segment method.

urijs/URIjs.d.ts
to authors(@RodneyJT @xt0rted). could you review this PR?
:+1: or :-1:?
check list

[ ] pass the Travic-CI test?

Looks good to me.

@xt0rted thanks!
@bdoss thanks mate!

authors: bdoss vvakame xt0rted


text:
Added a stack.yaml file with stack init

If a smaller file is desired, just resolver: lts-6.12 will also suffice

I've never used stack at all, so I'm afraid you'll have to explain to me (preferably in the commit description) what this is even for. Also, all the bloaty auto-generated commentary is not useful.

authors: NorfairKing bos mgsloan

repo: bos/text


text:
comments

This is the trial comment

actually becomes a note for nonlinear programming


text:
Fix #21: Prevent the tests from being installed with the wheel file

Thanks!

authors: brutasse timgraham

repo: brutasse/django-ratelimit-backend


text:
database of datasets must not be full loaded

@pierreandrieu Is it a "Priority task" ?

authors: bryan-brancotte pierreandrieu


text:
Resolve merge conflicts introduced by RuboCop and fix failing specs

Looks like this is just failing on the path specs that are currently failing in 2-0-dev, so this should be good to merge.

@smlance this is a history mess. Please rebase before merging

@segiddins All branches I've opened for 2-0-dev have this history mess.

@smlance yes, since I rebased 2-0-dev. You'll need to rebase / cherry pick your branches against 2-0-dev in turn

Should I open a new PR, or should I merge directly into 2-0-dev?

authors: segiddins smlance

repo: bundler/bundler


text:
Create a program to add file info to the new database schema.

working on maven and connections with dosocs


text:
add maven central badge

Hi @jangalinski,
thank you for this pull request.
Directly visible after merging...

Hi @jangalinski,
thank you for this pull request.
Directly visible after merging...

authors: ingorichtsmeier jangalinski


text:
Remove duplicate line in model.py

Thanks


text:
Add carufenon

test

repo: carufenon/patchwork


text:
Fix links to (opened/merged) pull requests

Thanks! :+1:

authors: caseyscarborough raboof

repo: caseyscarborough/github-activity


text:
updated dupin (2.10.2)

Merged as 9ddd8ff15a2730295922420f68172061b10b25bd.

repo: caskroom/homebrew-cask


text:
Add SoapUI 5.0.0

This is so old, the cask format is not even this one, anymore. If anyone is still interested in adding, please resubmit in a working condition.

authors: aaronwalker vitorgalvao


text:
All done

omg so many commits

authors: cengique scassagnol

license: Unlicense


text:
Deps are now locked

@20uf merged ;)

repo: certificationy/certificationy-cli


text:
Rename refactoring should handle doc links

Done!

repo: ceylon/ceylon-ide-intellij


text:
Fix for #6584

Can one of the admins verify this patch? (see README)

Yup, thanks!

authors: CeylonBuildBot FroMage bjansen

repo: ceylon/ceylon


text:
REQUESTS TABLE > MODAL WINDOW: enlarge the modal window

completed


text:
[wip] upgrade Chef

needs a rebase after #1323.

Closed by #1506

authors: markan srenatus

repo: chef/chef-server


text:
Handle the /usr/local/bin symlinks correctly on Mac 10.11.

We are also going to need to apply a similar fix to ChefDK's verify command:
https://github.com/chef/chef-dk/blob/443061eef820c01aad355a000b4200a9a0b4570d/lib/chef-dk/command/verify.rb#L239-L273

This fixes the issue for chef and derivative projects.
For Chef DK we are only launching chef verify so the fix will be in chef-dk.

:+1:

:+1:

:+1:

authors: schisamo scotthain sersut yzl

repo: chef/omnibus-chef


text:
[WIP] Window Methods

Neat. Ping me when it's ready!

Included already now. Sorry for the late notice.

authors: chenglou vramana

repo: chenglou/reason-js


text:
Fixing broken links with some parenthesis fixes

Hey, sorry for the delay on this, I don't seem to get notifications on these. But thanks! Much appreciated.

Closing this, as got another similar pull request that did a little more. Thanks again!

authors: cholmes rossbernet


text:
add support to afreecatv.com.tw

Thanks!

repo: chrippa/livestreamer


text:
fix typo: DBVC -> DBCV

Thanks!

authors: christopherjenness galeone

repo: christopherjenness/DBCV


text:
Add parsing and decoding for byte arrays

Codecov Report

Merging #1385 into master will decrease coverage by 0.02%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1385      +/-   ##
==========================================
- Coverage   86.09%   86.07%   -0.03%
==========================================
  Files          74       74
  Lines        2532     2535       +3
  Branches      105      105
==========================================
+ Hits         2180     2182       +2
- Misses        352      353       +1

Impacted Files
Coverage Δ

...jawn/src/main/scala/io/circe/jawn/JawnParser.scala
100% <100%> (ø)
:arrow_up:

...rc/main/scala/io/circe/numbers/BiggerDecimal.scala
85.38% <0%> (-0.59%)
:arrow_down:

.../core/shared/src/main/scala/io/circe/Decoder.scala
85.25% <0%> (-0.27%)
:arrow_down:

...re/shared/src/main/scala/io/circe/JsonNumber.scala
96.38% <0%> (ø)
:arrow_up:

...les/core/shared/src/main/scala/io/circe/Json.scala
80% <0%> (+0.6%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76f972c...6affc56. Read the comment docs.

authors: codecov-io travisbrown

repo: circe/circe


text:
Added ability to set options for curl in constructor.

@nqxcode Thank you for the pull request.
I agree with all the style changes. I agree with allowing the ability to set options.
Looking back on this, I have some additional changes that I'll suggest. If you happen to want to modify the PR for these I'd be grateful but if not I can always do it.

[ ]  __construct() $config should always be required
[ ] Add setOptions()
[ ] Remove __construct() get doing setter logic
[ ] Allow $options to override the hard coded options I have CURLOPT_HEADER, CURLOPT_RETURNTRANSFER, CURLOPT_SSL_VERIFYPEER

authors: ckdarby nqxcode

repo: ckdarby/PHP-UptimeRobot


text:
Retry with host bcdboot when generating Win7 images

yes it works


text:
fix(connector): nullable types

Thanks!

authors: fdhadzh vavrusa

repo: cloudflare/sqlalchemy-clickhouse


text:
CFY-7186: print root cause when YAML parsing error occurs

@mcouthon added tests and merged.

repo: cloudify-cosmo/cloudify-cli


text:
Fix a typo and a link, and added a few links

Thanks for spotting and taking the time to file this PR! :shipit:

authors: clue marclaporte

repo: clue/graph


text:
优化目录结构

优化了目录结构和部分命名

repo: coajs/coa-mysql


text:
SHOW ROLES was out of order in the sidebar

This change is

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/23adc9639d9c0e3d237708e27f0a3882f52e1b98/

authors: cockroach-teamcity lhirata

repo: cockroachdb/docs


text:
[WIP] add offline Docker container serving docs

This change is

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/2eb671463478ed4346270bc47f3e8c5bbb816777/

authors: cockroach-teamcity otan


text:
move documentation into docsify website

Coverage remained the same at 76.98% when pulling 388c2855485e966827b0e99fa883f91852886882 on website-v3 into 0bf555a8873618c3ba1f547a87021bc720797cdd on master.

authors: coveralls thijstriemstra

repo: collab-project/videojs-wavesurfer


text:
rerender with smithy 2.0.1 and try to reenable all builds

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

pandas is not yet available for numpy-1.12

pandas for np112 has been merged yesterday.
pytables not yet available for np112
Appveyor on py27 failed in tng for not finding stdint.h

Hi! This is the friendly automated conda-forge-linting service.
I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.
Here's what I've got...
For recipe:

Selectors are suggested to take a <two spaces>#<one space>[<expression>] form.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

ping @mpharrigan: the builds for np112 of pytables and pandas are there. Can you please re-run CI?

Thanks for investigating this. I've restarted the ci jobs

@mpharrigan The roundf error also occurs here. Since Python 2.7 is still contained in conda-forge's build matrix, I'll encourage to fix this. Unfortunately I have no clue, why this particular error pops up.

I'll open up a PR with this fix for mdtraj.

Thanks so much @marscher . Just to be safe, I'm going to wait for travis-ci to run. I'll check back periodically, but if you notice it's finished, please ping me :)

press the button, please

thanks!

Will need a new re-rendering to add NumPy 1.12 to Windows builds.

authors: conda-forge-linter jakirkham marscher mpharrigan

repo: conda-forge/mdtraj-feedstock


text:
Update nginx base to use split configuration

Changes have been added to further customise the config and a readme added, ready for review

repo: continuouspipe/dockerfiles


text:
Fix resync for SFC

Coverage decreased (-0.4%) to 71.272% when pulling 5109e66e6db55ce53568352c9d3055ca1be94d7d on rastislavszabo:sfc into 9d856e11e124a6af1da224109950103fe17e7c6b on contiv:master.

authors: coveralls rastislavszabo

repo: contiv/vpp


text:
Image with ldpreload

Changes Unknown when pulling a3b2f25a1dd3c2408443de4d8efb4de538ba3423 on mklotton:image_with_ldpreload into ** on contiv:master**.

authors: coveralls mklotton


text:
etcdserver: use fifo scheduler for applier

Much cleaner! LGTM!

repo: coreos/etcd


text:
mvcc, v3rpc: minor coverage improvements

lgtm


text:
I used your test.py and files from hhb072/WaveletSRNet,It shows list index out of range

data[0] -> data.iter() good luck!

authors: TWLemontree yangyingni

repo: corganhejijun/frontal-trans


text:
Use new coursier-version library

(Will add back removed classes to preserve binary compatibility)

Way to out-of-date.

repo: coursier/coursier


text:
added sequences to permissions for super

Looks good to me.  :+1:

authors: cjestel dansajner


text:
Landing Page Changes

I also get Status: 503 Service Unavailable when trying to login with username and password. I'm not sure if it's because this is a review app though.

authors: andrewmarklloyd fukuru

repo: crablar/podsheets


text:
[t175] support generated columns on insert from sub-querys

otherwise ack

authors: mfussenegger seut

repo: crate/crate


text:
Reverted wrong changes to license content

+1 Changes compatible with http://www.apache.org/licenses/LICENSE-2.0.txt

authors: aplanas tboerger

repo: crowbar/crowbar


text:
Don't make a mongodb connection required

Shouldn't we instead not instantiate the storage service in general if you dont have the vars and just check if it's null? This checks if you specifically dont have env vars, but doesnt check if you have a valid mongo connection

If you don't have the env vars set you can't have a valid connection. MongoDB was never required until my changes to plugin state.

repo: cs-discord-at-ucf/lion


text:
Chapter1/homework/9

 Here is an overview of what got changed by this pull request:

Issues
======
- Added 4

Complexity increasing per file
==============================
- Src/BootCamp.Chapter/Conversions.cs  5

See the complete overview on Codacy

 Here is an overview of what got changed by this pull request:

Issues
======
- Added 8

Complexity increasing per file
==============================
- Src/BootCamp.Chapter/LetterConverter.cs  5
- Src/BootCamp.Chapter/Conversions.cs  5

See the complete overview on Codacy

 Here is an overview of what got changed by this pull request:

Issues
======
- Added 1

Complexity increasing per file
==============================
- Src/BootCamp.Chapter/LetterConverter.cs  5
- Src/BootCamp.Chapter/Conversions.cs  5

See the complete overview on Codacy

 Here is an overview of what got changed by this pull request:

Issues
======
- Added 2

Complexity increasing per file
==============================
- Src/BootCamp.Chapter/LetterConverter.cs  5
- Src/BootCamp.Chapter/Conversions.cs  5

See the complete overview on Codacy

 Here is an overview of what got changed by this pull request:

Issues
======
- Added 2

Complexity increasing per file
==============================
- Src/BootCamp.Chapter/LetterConverter.cs  5
- Src/BootCamp.Chapter/Conversions.cs  5

See the complete overview on Codacy

 Here is an overview of what got changed by this pull request:

Complexity increasing per file
==============================
- Src/BootCamp.Chapter/LetterConverter.cs  5
- Src/BootCamp.Chapter/Conversions.cs  3

See the complete overview on Codacy

 Here is an overview of what got changed by this pull request:

Issues
======
- Added 1

Complexity increasing per file
==============================
- Src/BootCamp.Chapter/ArrowMovement.cs  4
- Src/BootCamp.Chapter/BinaryConverter.cs  3

See the complete overview on Codacy

 Here is an overview of what got changed by this pull request:

Issues
======
- Added 1

Complexity increasing per file
==============================
- Src/BootCamp.Chapter/ArrowMovement.cs  4
- Src/BootCamp.Chapter/BinaryConverter.cs  3

See the complete overview on Codacy

repo: csinn/CSharp-From-Zero-To-Hero


text:
Add to doc about advanced indexing support

Thanks. I fixed the link.

Thank you

repo: cupy/cupy


text:
add System requirement doc for secret provider in official doc

This is a duplicate of cyberark/conjur-docs#1357, closing now.

This is a duplicate of cyberark/conjur-docs#1357, closing now.

authors: InbalZilberman izgeri


text:
A line is added

This pr has conflicts. conflict happens when you are trying edit to same part of the same file differently in two different branches. in this case if you have an old copy of this repo which you've cloned during the CSE : A Survival guide workshop(Glad you've attended that as well). so if you open a pull request with that repo which we've worked on after the workshop to make it ready for this workshop with out fetching the changes we've made. you will get a conflict. you can dm on teams  [CB.EN.U4CSE19063] to resolve this or delete your fork and make a new fork and then open a pull request again.
Regards
Sridhar


text:
add support for scrollbars of RecyclerView

Thank you very much for optimizing the Ultimate Recyclerview!
I hope you may help us to improve the library or the framework in the future.
Best Regards

authors: SevanJoe cymcsg

repo: cymcsg/UltimateRecyclerView


text:
Add table of contents to README

"Contents" might be a be more accurate header, since not all of them are examples. If that were to be changed, the bottom sections at the bottom would need to be added. It also might be useful to add this to the news file too.

Done.

Thank you!

authors: adityamenon d-unseductable elifoster

repo: d-unseductable/ruru


text:
Improve file type parsing + minor improvements

Fails

:no_entry_sign:

Sources/Danger/File.swift#L21 - Enum element name should be between 3 and 40 characters long: 'h' (identifier_name)

:no_entry_sign:

Sources/Danger/File.swift#L21 - Enum element name should be between 3 and 40 characters long: 'm' (identifier_name)

Warnings

:warning:

Any changes to library code should be reflected in the Changelog.
Please consider adding a note there and adhere to the Changelog Guidelines.

:warning:

Sources/Danger/File.swift#L21 - Enum element name should be between 3 and 40 characters long: 'mm' (identifier_name)

  Generated by :no_entry_sign: Danger Swift against 1f076e697797a7a750bd9378dd39e46647da5355

authors: DangerCI f-meloni

repo: danger/swift


text:
Decidir cuantas páginas serán necesarias para el estudio inicial

El tiempo medio para una página de unos 50 artículos es de 5 minutos. 10 páginas de artículos deberían llevar algo de una hora y daría como resultado la información de aproximadamente 500 artículos.

repo: daniarnaizg/TFG-Amazon-Scraper


text:
fix production order

Coverage decreased (-0.005%) to 59.442% when pulling d331a298aca8da5e0fe8bc634afb0ee8190cf9db on achensetyawati:dev into b70025d7373d62993ff95824062873a8762fcb78 on danliris:dev.

Coverage increased (+0.01%) to 59.458% when pulling b03451b5d79ef7400abd71d6c2cb54510b49f657 on achensetyawati:dev into b70025d7373d62993ff95824062873a8762fcb78 on danliris:dev.

authors: achensetyawati coveralls

repo: danliris/dl-module


text:
service watch apis

merged via command line

authors: danwinship rajatchopra

repo: danwinship/origin


text:
Add badges to README

Fix #6


text:
Updated with linkup info to R ported package

Thanks, looks great!

authors: davidmerfield ronammar

repo: davidmerfield/randomColor


text:
Installation instructions cleanup + added conda

Coverage remained the same at 100.0% when pulling 35833ee259f4425e7176aa6ac41ad0d576e7e4ec on SijmenHuizenga:conda-installation into a55c562a73d91b2ea39f31056416fb745f96bfb8 on dbader:master.

Coverage remained the same at 100.0% when pulling 35833ee259f4425e7176aa6ac41ad0d576e7e4ec on SijmenHuizenga:conda-installation into a55c562a73d91b2ea39f31056416fb745f96bfb8 on dbader:master.

authors: SijmenHuizenga coveralls

repo: dbader/schedule


text:
Echart图表第1次打开可以显示，第2次再打开。整个应用卡死。官方例子Muihello中也是这样。

请提供手机型号和版本信息以及HBuilder版本信息

HBuilder 版本号：8.9.1.201712121728
手机型号：红米HM2LTE-CMCC
Android 5.1.1 LMY47V

authors: Epans nearwmy

repo: dcloudio/mui


text:
Added profiles.

:japanese_goblin:

repo: decause/bizlegfoss


text:
Update CakePHP framework support statement for 2.x

Codecov Report

Merging #25 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #25   +/-   ##
=========================================
  Coverage     50.55%   50.55%
  Complexity      527      527
=========================================
  Files            24       24
  Lines          1634     1634
=========================================
  Hits            826      826
  Misses          808      808

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e46003...c6e707a. Read the comment docs.

repo: dereuromark/cakephp-setup


text:
Revert some changes

Ещё нужно вернуть "ScanAppType": "Configuration, Fingerprint, PmTaint, DependencyCheck, $COND",

authors: alexkhudyshkin dvragulin

repo: devopshq/dohq-ai-best-practices


text:
리뷰해주세요 - 테스트

Closing test PR

authors: ianychoi ianychoi-dev

repo: devrel-kr/Web-Dev-For-Beginners


text:
please update to support Swift 5.0

Resolved by #145

authors: devxoul zhengyanfeng

repo: devxoul/Toaster

license: WTFPL


text: Support for Sileo depictions

repo: dimitarnestorov/RepoOnVercel


text:
Format code using 'cargo fmt'

Sorry, but this is not a meaningful enough pull request for me to merge on the develop branch.

repo: divvun/divvunspell


text:
Added libreborme to "projects using this package"

Coverage remained the same at 83.04% when pulling 431d1ea3e86f0040d78781fbc8756826f21fd379 on PabloCastellano:master into 61427e474cb2f4be8fdfce225d78a5330bc77eb0 on djangonauts:master.

authors: PabloCastellano coveralls

repo: djangonauts/django-hstore


text:
Removed several global imports from std.parallelism

autotester dun like it

Should be good now. It was an issue with the windows specific module constructor.

authors: JackStouffer andralex

repo: dlang/phobos


text:
Update Serbian

Thanks a lot. I've just merged it locally. The updates will be present in the next release. I've just reverted the app name to OpenTasks. We don't localize the name of the app itself.

Thanks, but could you please consider leaving localized name at least for Serbian? Since we are using Cyrillic script, translation is considered unfinished if name isn't localized. General consensus among Serbian translation community is that we either translate or transcribe app name.

Really? How about "Android", "Google" or "Facebook"? Do you use transcribed versions of these names?
"OpenTasks" is not the title underneath the launcher icon (for that we use the localized version of "tasks"), so you won't see "OpenTasks" in your app drawer.

How about "Android", "Google" or "Facebook"? Do you use transcribed versions of these names?

We can't influence on companies and proprietary projects, but in common communication (including TV, newspapers, etc.) if the text is in Cyrillic script those names are usually transcribed („Андроид“, „Гугл“, „Фејсбук“). „Usually“ means „if authors strictly follow language rules“. (As for „Android“: in AOSP it left in Latin script, I'm not sure why, but AFAIK every other FLOSS project uses transcribed name.)

"OpenTasks" is not the title underneath the launcher icon (for that we use the localized version of "tasks"), so you won't see "OpenTasks" in your app drawer.

Okay, that's fine with me, thanks.

authors: dmfs pejakm

repo: dmfs/opentasks


text:
Fill PNN in origin_site_name

if this issue means :
write T2_CH_CERN in place of srm-eos.cern.ch as site_origin_name in DBS
this is not done yet in current WMA released used in production
https://hypernews.cern.ch/HyperNews/CMS/get/tier0-Ops/943/1/1/1/1.html

@ticoann this can be closed now right?

authors: alexanderrichards belforte ticoann

repo: dmwm/WMCore


text:
Strip trailing whitespace

Oh my! :smile:

Hasn't been done in a while.

Are you also fixing these warning and errors
803 warnings and errors that must be fixed
?
:-)

Yup, every single one of them. And the 7K comments.

@ericvaandering, Sorry Eric I cause the conflict on this patch by merging another patch. I still have to merge a couple of patches first. Could you create new patch in the beginning of next week?

test this please

authors: amaltaro ericvaandering ticoann


text:
DNN-4608: use new virtual roles

This issue is already closed based on Will's comment here https://dnntracker.atlassian.net/browse/DNN-4608?focusedCommentId=116531&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-116531

authors: galatrash-at-dnn sleupold


text:
Replaced with strict assertions

Merged, thanks for your contribution!

authors: domnikl samnela

repo: domnikl/DesignPatternsPHP


text:
java.lang.NoSuchMethodError: com.bumptech.glide.RequestManager.clear

Am also having the same issue. Using glide 4.7.1 version

repo: donglua/PhotoPicker


text:
Remove duplicated paragraph and minor improvements

I also think it's better to re-write this article. Many information aren't so clear.

Thanks, @Youssef1313, for making the additional changes. I'll merge your PR now.

repo: dotnet/docs


text:
[ArPow] Onboard templating to arcade-powered source-build

While onboarding templating I discovered a 6.0 change that introduced some analyzer prebuilts.  I logged https://github.com/dotnet/templating/issues/2900 to track this issue.

The clicommandlineparser intermediate dependency is not available yet but there is still value in forging ahead so I created a PR to get the ArPow infra in place.  Once the intermediate NuGet package is available for clicommandlineparser we can create another PR to reference it.

Verified Microsoft.SourceBuild.Intermediate.templating is being produced correctly by builds.  Closing.

repo: dotnet/source-build


text:
A few updates

L and R are not available because they are ignored by lolicon for some reason

Removing features is a no-no

the whole pr?
anyway commits are reversible, but ok :\

Sorry, I'm not trying to be a downer but but they do not fall in line with the project.
The exit game is a very important feature as reloading a game as normally you'd have to: press home, swipe, find the icon again, click it twice. But this was removed as the shell_pid check was removed in order to remedy the controls issue I think?
Customization will never be in LOLIcon.
I will rewrite the LOLIcon at a later date as I did with rePatch.  I do admit its not well written and was rushed out to be released while I still had time. The whole oClock profile system will be removed.
However, I do enjoy your interest in the project, will support your branch, and users may use your build as an alternative.
Hope you understand. Thanks.

np
your plugins are amazing, and LOLIcon is the only way i have to play some games at a decent framerate (eg Helldivers, default is 15pfs when too many mobs are on screen....)
i think a way to customize buttons is needed becuase select and up is not good for all the games (also on phat, the select button is uncomfortable due to its size)
i will revert that commit and add builds on my repo then.
just a few notes:
somehow is still possible to open LOLIcon in pspemu|adrenaline but it is not drawn in pspemu fb (i was able to see it only once, dunno how) and you can't close it so you are stuck because controls are not working (any of them).
your only option is to hard reset the device.
i tried to fix this in my last commit and it seems i can't reproduce the problem now (but not sure).
Thanks, looking forward the next LOLIcon version

authors: dots-tb kylon

repo: dots-tb/LOLIcon


text:
Add S3 documentation to README.md

:+1:

authors: AudreyAltman markbreedlove

repo: dpla/primary-source-sets


text:
Remove small words "in" and "on" in abbreviations

Fixed in 52aa4999

repo: drjbarker/blib


text:
Improves the ResultSet Testing (Issue #86)

Issue #86

repo: drvinceknight/Axelrod


text:
Create LICENSE

GREAT

repo: dsi-icl/eae-utils


text:
Add Z option for SELinux and add Podman option

I would also suggest adding a newline to the files locales/fr-informal.json and locales/fr.json before the merge to remove the annoying git warning.

Thanks for your contribution!

authors: eddiesigner inknos

repo: eddiesigner/liebling


text:
Some template fixes

Changes Unknown when pulling 86c7ddd147698c1042fda3cea9e30d474a99b85d on declaration_request_printout_form_fix into ** on master**.

Changes Unknown when pulling 8b77fc5145bb8d9195b8d58161726b9939e4216d on declaration_request_printout_form_fix into ** on master**.

Changes Unknown when pulling 4c17bfbdb629a4048bc16ff571e059fe80fa0d06 on declaration_request_printout_form_fix into ** on master**.

Changes Unknown when pulling f57fc15a50a41f22dc75bcc103db0c0ac59f6bf8 on declaration_request_printout_form_fix into ** on master**.

authors: MBatrak coveralls


text:
feat: add additional avatar sizes

Coverage increased (+0.1%) to 87.404% when pulling ff9bd761feb1fccb6bb6f878957176a1e6c187d2 on abutterworth/PAR-365 into 6abb7892dae627733749f493e3dfef430a42b10f on master.

:tada: This PR is included in version 13.6.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

repo: edx/paragon


text:
typo at mock adapter documentation

:+1: Thanks!

authors: egeloen elernonelma

repo: egeloen/ivory-http-adapter


text:
add test for update_all behavior

this won't build correctly till https://github.com/elixir-sqlite/exqlite/pull/146 is merged and a release is cut and we bump the mix lock file here
but was able to confirm is works locally when pointing at the latest version of exqlite locally with the needed fix

@kevinlang I'm releasing v0.5.11 now, you can bump the deps for this

authors: kevinlang warmwaffles


text:
fixed a usage of cleanup

Right. Thank you

authors: frsyuki ykubota

repo: embulk/embulk


text:
SonarQube

see wiki/Sonar

continuous issue so there is no need to have this open.

repo: empt-ak/meditor


text:
Test userprofile views

Coverage increased (+2.4%) to 84.506% when pulling cdfe4a914082aacce94e0cb20addca1aa7fc1900 on tests/userprofile-views-new into af3d31beb635643b8ae9e073e941a524250d8720 on main.

authors: coveralls gritfessel

repo: ephios-dev/ephios


text:
Conf nginx

Pas moyen de passer par cette méthode ? https://dokku.com/docs/configuration/nginx/#customizing-via-configuration-files-included-by-the-default-tem
Pour la maintanabilité du fichier de conf par défaut, qui peut changer entre versions de Dokku.

Ce qui serait vraiment cool c'est d'en faire un plugin, un peu comme https://github.com/Aluxian/dokku-nginx-cache

@abulte j'ai mis ca dans un conf file, mais je suis pas sur de moi. Notamment la doc dit que le conf fil est inclu dans le "main server {}" est ce que ca va fonctionner si limit_req_zone $binary_remote_addr zone=mylimit:10m rate=10r/s; est dans le main server ?

authors: XavierJp abulte


text:
Résoudre le système avec fonction par itération dans Matlab

Le squelette du code est réalisé, par contre le cancer pogne dedans, reste a reverifier si une erreur c'est glissé dans les matrices ou si la technique utiliser en ce moment est mauvaise.![SCREENSHOT_MATLAB.png]

Le squelette du code est réalisé, par contre le cancer pogne dedans, reste a reverifier si une erreur c'est glissé dans les matrices ou si la technique utiliser en ce moment est mauvaise.![SCREENSHOT_MATLAB.png]

Le code converge vers une réponse, mais celle-ci est mauvaise. Passé beaucoup de temps avec Nicolas Quaegebeur pour essayer de debugger, mais aucun résultat n'a fonctionné encore.
Je vais essayer de faire de la recherche ailleurs voir si je peux pas trouver une solution.

Le code converge vers une réponse, mais celle-ci est mauvaise. Passé beaucoup de temps avec Nicolas Quaegebeur pour essayer de debugger, mais aucun résultat n'a fonctionné encore.
Je vais essayer de faire de la recherche ailleurs voir si je peux pas trouver une solution.


text:
Add onKeyDown support to grid.

Merging this, thanks.  I am going to simplify the comment a bit post-merge -- think its a bit too much detail on this issue, when all we really need is a pointer.

authors: cnrudd lbwexler

repo: exhi/hoist-react


text:
Replaces PushResponseError with PushTicketError in README

Got me today. Thanks for keeping documentation up to spec.
Can this get merged?

Never saw this. Merging now.

authors: jeffreybrowning julianpacker oalsing

repo: expo-community/expo-server-sdk-python


text:
feat: add app.request for set get, post

Hello @bluelovers ! Thank you for the pull request. Can you explain what it does and what it would achieve other the existing APIs and the use-case for this new method? This will help us better understand the purpose to evaluate it.

Hi @bluelovers!
As far I know you can use .all to fix this requirement using a filter, let me show you a simple example 🤔
app.all('/', (req, res) => {
    const validMethods = ["GET", "POST"];
    const { method }  = req
    if (validMethods.contains(method)) {
        return res.send(`Current method: ${method}`)
    }
    res.status(405).send() //405 Method Not Allowed
})

I don't think app.request will add an extra value to the Express Core, but maybe it is a great opportunity for you to create an independent module in NPM for that as external middleware 👍.

I'm going to close this since we asked for more information and never got any, and the PR remains in a failing state.

authors: UlisesGascon bluelovers dougwilson

repo: expressjs/express


text:
Fix #323: Reverse shape animation doesn't work

👍

repo: exyte/Macaw


text:
fix issue #50

Thanks @pcgreat!

authors: patapizza pcgreat

repo: facebookincubator/duckling


text:
Add workaround for latest regex version failing on version access

Breakage was more sever than just __version__, but mainly related to there being another level of indirection to access private attributes, which we must have access to properly intercept replace templates.

repo: facelessuser/backrefs


text:
Added TypeScript definitions

@digitalcortex thanks for the PR!  Sorry that I didn't notice it until now.

authors: digitalcortex marshallswain

repo: feathers-plus/validate-joi


text:
Update API with new mock API

Shouldn't be merged until https://github.com/sedouard/connected-car-api/pull/13 is merged.

repo: felixrieseberg/OxideFleet


text:
插入图片拖拽改变图片大小后  编辑器内无法获得鼠标焦点

多谢反馈，后续会解决。

请问什么时候能解决呀？

年后吧~

authors: Phinome Terry-cjgu qzzsunly

repo: fex-team/ueditor


text:
add filters to makers for products + capabilities

Awesome work! Great choice on the two base filter items.
Can the filter options be in alphabetical order?
Categories: 3D printing, A B C, Other
Products: ABC, Other ?

Awesome work! Great choice on the two base filter items.
Can the filter options be in alphabetical order?
Categories: 3D printing, A B C, Other
Product Type: ABC, Other ?

Unfortunately we can't without a substantial amount of work since it'll need to work across all languages. I agree that's better behavior but we should do it in a separate issue since this isn't what we do for find the masks either.

You have some mega fan love from Claire C on #makers-ftm from Nation of Makers She also asked for "Other" to be dropped to the bottom --- maybe this is a more appropriate ask; I'll midnight issue that ABC stuff --- thanks, Nate! This is great!

An actual use of reduce()!!!! <3.
Very nicely done :)

authors: awong-dev linderr nburt

repo: findthemasks/findthemasks


text:
failing test: test-decode-from-heap::Windows::32bit

need to hook memcpy, fixed by #143

repo: fireeye/flare-floss


text:
ok

Coverage remained the same at 92.233% when pulling 0b6ae808059d06571e927ad5bd21b050d35bf967 on removeTagHandler into 6caa0d7883cfb463b63605ba7827316c6dd20c0f on master.

authors: coveralls orthagonal

repo: firstandthird/hapi-log-response


text:
Workflows install fails if fission is not installed in the "fission" namespace

Proposed solution: change helm chart to assume by default that fission is located in the same as where fission workflows will be installed. To have workflows live in a seperated ns,  the user will need to update the helm value to point to the ns with fission deployment it wants to use.

Yeah, ok, let's do that. It's not ideal, but I can't think of anything better.

Fixed in #90 (which depends on https://github.com/fission/fission/pull/413 in Fission)

authors: erwinvaneyk soamvasani

repo: fission/fission-workflows


text:
allow using node 4

closed by #12 I think.

authors: fivetanley ryankshaw


text:
Deploy s3-upload-cleaner as a cronjob

Fixed in #349

authors: moshloop teodor-pripoae

repo: flanksource/karina


text:
Miscellaneous dartdoc markdown fixes

LGTM

cc @qchong

authors: Hixie abarth

repo: flutter/flutter


text:
Update README.md

/rebase

/rebase


text:
Added link to Apex Dev Guide

👍 Thanks @bleyle!

authors: alouie-sfdc bleyle

repo: forcedotcom/ConnectApiHelper


text:
DEV-1356 don't init session automatically in beacon mode

Merging!

authors: FrancescElies juergen-vogel

repo: fredknowsit/jquery-expert


text:
Upgrades Troy to latest stable version

Codecov Report

Merging #123 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #123   +/-   ##
=======================================
  Coverage   94.45%   94.45%
=======================================
  Files          23       23
  Lines         469      469
=======================================
  Hits          443      443
  Misses         26       26

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 01ecfea...62fd513. Read the comment docs.

authors: FPerezP codecov-io

repo: frees-io/freestyle-cassandra


text:
Chapter 3

What is this PR for? master has everything the branches have; they're separated for convenience. Nothing should have to be merged.

authors: koubaaa yupferris

repo: fusetools/hikr


text:
No audio after install

I have this same hardware and issue. I tried setting with pacmd command, but nothing changed. I eventually unlocked the filesystem and installed pavucontrol, which allowed me to set HDMI as output and not the default of optical audio. I then had audio and it persisted on reboots(until a future update I assume). I am willing to test things to help make this smoother for devices like this.

authors: eyecreate xpdos

repo: gamer-os/gamer-os


text:
\setsansfont设置的也是serif字体？

就是喜欢 serif 字体。。。

repo: gaocegege/Deedy-Resume-for-Chinese


text:
Add a travis test for Ubuntu 14.04

Hmm this is the second time it stalls at https://travis-ci.org/geerlingguy/drupal-vm/jobs/187804211#L1968
No clue as to why

Ah... no TTY: https://github.com/geerlingguy/ansible-role-mysql/blob/master/.travis.yml#L38
Means no colored output in Travis, but it's some wacky bug with the MySQL init script, Ansible 2.x, Docker 1.12, and Travis.

Wow, that's probably the wackiest bug I've ever heard of.

Wow, that's probably the wackiest bug I've ever heard of.

Yep, spent like 8 hours on it before giving up. See: https://github.com/ansible/ansible-modules-core/issues/2459#issuecomment-246880847

And of course the 14.04 test takes two minutes longer than the rest :)

authors: geerlingguy oxyc

repo: geerlingguy/drupal-vm


text:
fix inconsistent indents

Thank you!

authors: chrishhx gfairchild

repo: gfairchild/pyHarmonySearch


text:
Add testing CI

@KerstenBreuer Sollen wir offen lassen, bis die Backend-Dep gefixt ist? Ich glaube der Rest läuft.

Sehr cool :)

authors: KerstenBreuer lkuchenb

repo: ghga-de/datameta-client


text:
Additional workspace views

Ready for review.

repo: gina-alaska/nasa-ace-web