text:
Error when trying to filter a dataframe

Running this results in the following panic:
    {client_id, event_type_id, key, offset} = {"bs1", 5, <<1>>, 32}
    Explorer.DataFrame.filter(df, [
      client_id == ^client_id,
      event_type_id == ^event_type_id,
      key == ^key,
      offset == ^offset
    ])

thread '<unnamed>' panicked at 'cannot coerce datatypes: ComputeError(Owned("Failed to determine supertype of Binary and Utf8"))', /Users/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/polars-core-0.26.1/src/series/comparison.rs:170:17
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

The dataframe:
#Explorer.DataFrame<
  Polars[96 x 8]
  client_id string ["bs1", "bs1", "bs1", "bs1", "bs1", ...]
  event_type_id integer [5, 5, 5, 5, 5, ...]
  key binary [<<1>>, <<1>>, <<1>>, <<1>>, <<1>>, ...]
  offset integer [1, 2, 3, 4, 5, ...]
  timestamp integer [1593563400, 1593564300, 1593565200, 1593566100, 1593567000,
   ...]
  event_data binary [<<144, 228, 222, 239, 11, 136, 214, 222, 239, 11, 2, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 205, 204, 204, 61, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 208, 140, 1, ...>>,
   <<152, 242, 222, 239, 11, 144, 228, 222, 239, 11, 2, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 205, 204, 204, 61, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 208, 140, 1, ...>>,
   <<160, 128, 223, 239, 11, 152, 242, 222, 239, 11, 2, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 205, 204, 204, 61, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 208, 140, 1, ...>>,
   <<168, 142, 223, 239, 11, 160, 128, 223, 239, 11, 2, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 205, 204, 204, 61, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 208, 140, 1, ...>>,
   <<176, 156, 223, 239, 11, 168, 142, 223, 239, 11, 2, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 205, 204, 204, 61, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 208, 140, 1, ...>>,
   ...]
  schema_version integer [2, 2, 2, 2, 2, ...]
  inserted_at datetime [2023-03-03 14:51:07.608247, 2023-03-03 14:51:07.610753,
   2023-03-03 14:51:07.611021, 2023-03-03 14:51:07.611253,
   2023-03-03 14:51:07.611446, ...]
>

@LostKobrakai polars differentiate between strings and binaries at the type level and we don't. @philss we would need to cast a string literal to a binary at some point, but I am not sure when is the best moment to do that. If at the Elixir level or the Rust level. Does Series.equal(binary_series, <<0, 1, 2>>) generally work? Inside or outside queries?

@josevalim the Series.equal(binary_series, <<0, 1, 2>>) works fine. The problem is inside queries.
I guess this is a problem with all the operations that accepts binaries and strings.
I'm going to investigate a way to fix, but I think it is probably easier to fix at the Elixir side, in the the moment we convert our lazy series to polars expressions (the expression.ex file).
cc @LostKobrakai

authors: LostKobrakai josevalim philss

repo: elixir-nx/explorer


text:
Fixed a bug where gedcomdiff would panic

The changes in v31.0.0 left a bug where the similarity may be nil and so gedcomdiff would panic when generating the HTML.

This change is

Codecov Report

Merging #189 into master will increase coverage by 2.83%.
The diff coverage is 91.66%.

@@            Coverage Diff             @@
##           master     #189      +/-   ##
==========================================
+ Coverage   52.27%   55.11%   +2.83%
==========================================
  Files         170      170
  Lines        5071     5075       +4
==========================================
+ Hits         2651     2797     +146
+ Misses       2357     2204     -153
- Partials       63       74      +11

Impacted Files
Coverage Δ

gedcomdiff/main.go
0% <0%> (ø)
:arrow_up:

gedcomdiff/diff_page.go
82.75% <100%> (+82.75%)
:arrow_up:

gedcomdiff/individual_compare.go
51.57% <0%> (+51.57%)
:arrow_up:

gedcomdiff/diff_row.go
73.52% <0%> (+73.52%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46654c0...a13c34b. Read the comment docs.

source: gharchive/pull-request

authors: codecov-io elliotchance

repo: elliotchance/gedcom

license: MIT

license_type: permissive

license_source: github-api


text:
Adds the "watch a post" feature

[x] Watch post button reflects post.watching status.
[x] Tap button to watch/unwatch a post.
[x] Commenting auto-watches a post.

Looks like some snapshot spec failures. Do the specs pass locally?

Getting those spec fixes in - the corners were not rounding, so the new snapshot had square corners on the avatar.  To fix it required calling setNeedsLayout on avatarView in the cell's layoutSubviews() method shakes fist at iOS 10.
override public func layoutSubviews() {
    avatarView.setNeedsLayout()
    super.layoutSubviews()
    avatarView.layer.cornerRadius = avatarView.frame.width / CGFloat(2)

    // if this doesn't fix the "stretched create comment" bug, please remove
    createCommentBackground.setNeedsDisplay()
}

authors: colinta steam

repo: ello/ello-ios

license: mit

license_source: bigquery


text:
Where is the online compiler/REPL

I couldn't find it in the website?

For people still finding this on Google, the editor is now found at http://elm-lang.org/try and has been greatly improved.

Online repl is at http://elmrepl.cuberoot.in/

source: gharchive/issue

authors: arashbi johnyradio jupp0r

repo: elm-lang/elm-compiler


text:
Ingest fails at setting localStorage when a non-ASCII character is present

The ingest fails after creation when either a form field or a file name has a non-ASCII character.
Example use case from Sam: I tried uploading my file FARAÓ_CORUJA_MIX.wav twice and it crashed the app both times after submitting, the third time I substituted in an O and it worked.
Console errors:

RangeError: Maximum call stack size exceeded.
Failed to execute 'btoa' on 'Window': The string to be encoded contains characters outside of the Latin1 range.

https://eluvio.slack.com/archives/CF7AQGUH0/p1679850828704099?thread_ts=1679698463.014159&cid=CF7AQGUH0

This changes encoding/decoding of localStorage data in three areas:

Decoding when app is first loaded
Encoding during event fired when clicking Clear Inactive Jobs
Encoding during a new ingest
Deployed to demo.

This change looks good. I test the following scenarios

filename and descriptions have a non-ascii character
only filename has a non-ascii character
only descriptions have a non ascii-character

I tested the above with aws and file based ingests

@elv-gerald From the code review, I changed the encoding/decoding to use utilities built into client-js. Sorry, could you run through those scenarios again?

I re-rean the same set of test and the everything passed with no failures. Change are good.

authors: elv-gerald elv-zenia

repo: eluv-io/elv-studio


text:
test: use snapshot and split into multiple files

Part of #141

Unit tests updates

Split tests between files
Unit tests have been divided into multiple files and now use snapshots.
This should improve readability and, hopefully, maintenance efforts.
All common utilities and variables are now exported by test/utils/index file
insertStyle.test.ts – replace jsdom with happy-dom
Since the test are quite simple I opted out to switch jsdom to happy-dom (less dependencies and faster)
Additional changes

All unit test dependencies have been updated:

ava
@ava/typescript
nyc
sinon

Added missing @types for

sinon
icss-utils

Started looking over the changes - Will review them fully over the weekend.

@marcalexiei Hey, the changes are pretty lenghty to go through - Could you summarize which tests have been updated to use snapshots, and which tests actually changed (I see a couple are using snapshots, but not all of them)?

test/watchList.test.ts
Can't use snapshot since is comparing rollup properties with file system files.
However I was able to simplify the logic (I created a separate commit).
test/options.output.test.ts
Using snapshot here is not feasible due to rollup:
It looks like that, randomly, plugin transform is called first on actual_b and then on actual_a instead of calling transform on  actual_a and then on actual_b.
So instead of having:
body{color:red}body{color:green}

you end up having
body{color:green}body{color:red}

But only some times.
This looks like a rollup bug:

https://github.com/rollup/rollup/issues/3888

Right now on main branch should support output as function sometimes fails for the exact same reason.
Also on other tests involving output, assertions are written using indexOf !== -1 logic.
I assume it's because of this bug.
E.g.:
https://github.com/elycruz/rollup-plugin-sass/blob/0425739612e38ded0fda00e5060b25a735d620c3/test/index.test.ts#L265-L268
Right now there isn't much we can do.
I'm going to add a code comment on options.output.test.ts referencing this PR

I'm glad you noticed that bug (I had noticed it too) - Lets connect on the interwebs to discuss this PR - I'm on discord  (as edlcmoose)

For  transparency and because I do not have a Discord account 😅 I will reply here:

I'm only asking because this is a large change that we should probably do in smaller pull requests

I divided the monolithic  file into different files but the tests are the same.
I haven't changed test description, so it can be compared with the previous implementation.
I had to move the variables that were on the top of index.test.ts inside a separate file (test/utils/index.ts) to avoid duplication between the new test files.
The variables have been renamed with a TEST_ prefix to avoid clash with src folder export.

I do not have any rush to get this merged so feel free to review when you have time 😀.

[!NOTE]
If you stil find hard to review the changes I can close this PR and re-create smaller ones.

the value of changing all tests to use snapshots isn't very clear

IMHO The main benefit is that though the snapshots you have a quick and fast way to compare the string output instead of having to search around for "expect" files that are read through node:fs and compared to plugin output after various trim / clean operations.

if there are any analysis that you have performed on the approach

I used snapshot approach for the first time when implementing a custom webpack loader tests.
I find it more quick and easy than manipulating the strings directly via JS (which I was doing previously).
An additional benefit is that they can easily updated via cli command instead of performing the operation manually.
You can find the code here: https://github.com/marcalexiei/ractive-html-loader
The snapshot are used in this file: test/loader.test.js

Ok, thank you for indulging me  -  I understand the changes better now -
will set time to review and validate them over the next couple of days.

thank you for indulging me

No problem 😉

will set time to review and validate them over the next couple of days.

Thank you! As I said there is no rush 😃.

Have a good weekend!

@marcalexiei Also, the dependency updates can go together with the changing the tests PR.

Ok...

authors: elycruz marcalexiei

repo: elycruz/rollup-plugin-sass


text:
Benchmarking failing the official claims

Your results are not matching with the posted here: https://web-frameworks-benchmark.netlify.app/result?asc=0&f=elysia&metric=totalRequestsPerS&order_by=level64
Please check it and fix at: https://github.com/the-benchmarker/website/issues/44.
javascript (ES2019)
elysia (0.7)
138 735
141 956
142 657

Don't you consider that benchmarks are running on different machines..?

To make this kind of assumption @codeyash, you may refer indeed to how results are produced.
The first question I will as is :
Are the machines reliable/ close to what is used / could be used in production?
Like @fecony check it first
What makes sure differences ? What makes the official runs reliable?...
Not sure we can have a single source of trust for benchmarks, it depends on contexts ...
However, feel free to challenge anything here

This is the result of the official round 22 of TechEmpower Framework Benchmark:

https://www.techempower.com/benchmarks/#section=test&runid=66d86090-b6d0-46b3-9752-5aa4913b2e33&test=plaintext&l=zieepr-33z
Elysia claims that it is 18x faster than Express, and that's true at least for a simple plain text test.

Could you please point me to the source code ?
Seems that Elysia run thrown spawning, not sure is the way recommended to run in production
cc @aquapi @SaltyAom

Elysia : https://github.com/TechEmpower/FrameworkBenchmarks/blob/master/frameworks/TypeScript/elysia/spawn.ts

Seems that Elysia run thrown spawning, not sure is the way recommended to run in production

Spawning Workers with reusePort enabled is just a way to take advantage of multi-core systems. https://github.com/TechEmpower/FrameworkBenchmarks/pull/8416#issuecomment-1739072644

Hono seems to use reusePort https://github.com/the-benchmarker/web-frameworks/blob/master/javascript/hono/app.ts
But not Elysia
Feel free to PR

authors: codeyash fecony masfahru waghanza

repo: elysiajs/elysia


text:
The error message is being returned as "[object Object]." in resolve

What version of Elysia is running?
1.1.24
What platform is your computer?
Mac
What steps can reproduce the bug?
from 1.1.17 and Later errors that returns from resolve or derive are not parse and body is
[object Object]
export const accountAuther = ({
  IN,
  NOTIN,
  Ignore = false,
}: {
  IN?: AccountType[];
  NOTIN?: AccountType[];
  Ignore?: boolean;
}) =>
  new Elysia().use(bearer()).resolve(
    {
      as: "scoped",
    },
    async ({ error, bearer, set }) => {
      if (Ignore) {
        return error(404, {
          error: "Account not authorized",
        });
      }
      set.headers["content-type"] = "application/json";

      if (!bearer) {
        return error(404, {
          error: "Bearer token not found",
        });
      }

      const dataFromAuth = verifyJWT(bearer);

      if (!dataFromAuth) {
        return error(404, {
          error: "Authorization key not valid",
        });
      }

      const account = await validateAccount({
        id: dataFromAuth.id,
        updatedAt: dataFromAuth.updatedAt,
      });

      if (!account)
        return error(404, {
          error: "Account not found",
        });

      if (IN && IN.length > 0 && !IN.includes(account.type)) {
        return error(401, {
          error: "Account not authorized",
        });
      }

      if (NOTIN && NOTIN.length > 0 && NOTIN.includes(account.type)) {
        return error(401, {
          error: "Account not authorized",
        });
      }

      // Check if account is banned
      if (account.accountState === AccountState.BLOCKED) {
        return error(403, {
          error: "Account is blocked",
        });
      }

      return {
        account: account!,
      };
    }
  );

What is the expected behavior?
No response
What do you see instead?
No response
Additional information
No response
Have you try removing the node_modules and bun.lockb and try again yet?
No response

yes, up

authors: DIEGOHORVATTI yadsbah


text:
embassy_stm32: How to send a large amount of the same data using SPI?

I am using an SPI LCD screen, one of the operations is to full the screen, which is actually writing the same color data as the number of pixels on the screen.
Using the SPL library, the SPI DMA channel can be set up like this:
DMA_InitTypeDef DMA_InitStructure;
DMA_InitStructure.DMA_DIR = DMA_DIR_PeripheralDST;
DMA_InitStructure.DMA_MemoryInc = DMA_MemoryInc_Disable;
DMA_InitStructure.DMA_M2M = DMA_M2M_Disable;
// ...
DMA_Init(DMA_CHx, &DMA_InitStructure);

Because the memory address does not increase, the specified amount of the same data will be written to MOSI.
But I can't find a similar method in embassy_stm32::spi::Spi. It can be done using write, but if the screen pixels are large, the stack will explode, and using the heap is not advisable.
I hope there will be something like:
async fn write_n(&mut self, data: Word, n: usize) -> Result<(), Self::Error>;

You can open a relatively small array (such as 32bytes), and send it repeatedly.

You can open a relatively small array (such as 32bytes), and send it repeatedly.

This is a good solution for the current situation.

authors: jmjoy showier-drastic

repo: embassy-rs/embassy


text:
README: Add "Unmaintained" banner

Resolves #29
/cc @stefanpenner

👍

should we release a maintenance release to include this in the readme on NPM?

I tend to ignore the readmes on NPM, but feel free to do that.

I tend to ignore the readmes on NPM, but feel free to do that.

kk

complete, i figure we can catch those who use the npm readme as a source of truth.
➜  broccoli-es6modules git:(master) git tag v1.2.3
➜  broccoli-es6modules git:(master) git push origin v1.2.3
Total 0 (delta 0), reused 0 (delta 0)
To git@github.com:ember-cli/broccoli-es6modules.git
 * [new tag]         v1.2.3 -> v1.2.3
➜  broccoli-es6modules git:(master) npm publish
+ broccoli-es6modules@1.2.3


text:
Add dvdcli parameter

This parameter sets the location of the dvdcli binary. Defaults to
/usr/bin/dvdcli.

Hi @branden
I am interesting in hearing about the use case for making the DVDCLI location configurable. The DVDCLI installer defines where the binary is placed and I am curious as to what the motivation is for moving the binary?
Also, I would be a little nervous about making this fully qualified path configurable as one might be able to bootstrap another malicious binary in its place to potentially do a Man In The Middle data attack to snoop data. One could easily use a FUSE overlay to make that attack happen.

I think this makes a ton of sense as a configurable option when configuring
the Mesos agent with the isolator. A user configurable option of course
makes no sense.
David,
Maybe I am misinterpreting the PR here.
On Friday, March 4, 2016, David vonThenen notifications@github.com wrote:

Hi @branden https://github.com/branden
I am interesting in hearing about the use case for making the DVDCLI
location configurable. The DVDCLI installer defines where the binary is
placed and I am curious as to what the motivation is for moving the binary?
Also, I would be a little nervous about making this fully qualified path
configurable as one might be able to bootstrap another malicious binary in
its place to potentially do a Man In The Middle data attack to snoop data.
One could easily use a FUSE overlay to make that attack happen.
—
Reply to this email directly or view it on GitHub
https://github.com/emccode/mesos-module-dvdi/pull/79#issuecomment-192341382
.

Yeah, this is intended to be configured by an admin, in the same way as the existing work_dir config parameter.

I am interesting in hearing about the use case for making the DVDCLI location configurable. The DVDCLI installer defines where the binary is placed and I am curious as to what the motivation is for moving the binary?

I'm installing DVDCLI under /opt/ as part of another software package.

Also, I would be a little nervous about making this fully qualified path configurable as one might be able to bootstrap another malicious binary in its place to potentially do a Man In The Middle data attack to snoop data. One could easily use a FUSE overlay to make that attack happen.

Setting this config value requires that you have admin privileges on the Mesos agent, so I'm not sure what vulnerability this adds. Can you explain the potential attack a bit more?

very interested in this feature. not sure how this is any less secure than the current implementation.

Apologize for letting this sit here as we have been busy with some internal commitments. We plan on having this in the next release. There currently is a conflict with this merge and I will hopefully get to this shortly.

@branden We took what was implemented in this PR and tried this out in a private build. It looks like that when you give the mesos agent a parameter that it isnt expecting, the agent fails to start up with an unknown parameter. I have seen this before when I fat finger running the agent on the command line versus as a service, when it receives a parameter it doesnt know about, the agent craps out. A quick test of this, just add a parameter called junk and set the value to myjunk. and you should see the same behavior.
I think rather than doing this as a parameter which may break in 0.30.0 because of a feature/functionality that is being deprecated in 0.30.0 (http://mail-archives.apache.org/mod_mbox/mesos-dev/201603.mbox/<CAK7AWaGB24ALh8eb+vKMFgc4+jmhxZ6ry79HBcKN+Bt04Sx43A@mail.gmail.com>), I think a solution that will work regardless of version and gives you even finer grain control would be to make this an environment variable that can be set per job and would support multiple dvdcli versions.
Since we are gearing up for a release soon, this reimplementation of this idea might not make it into the upcoming release. We will take it upon ourselves to implement in the next release however.

@dvonthenen Setting it as a DVDI_ environment variable does represent a very valid security risk. I would say implementing via something that agent respects like a local environment variable would be the best route.

@clintonskitson I agree there isnt anymore a security risk, then there is today with any of the other environment variables.
As for the local environment variable, I think I said that in my last comment and had agreed to implement it.

@dvonthenen the comment around "set per task" threw me off. This would I believe mean it was a choice from the task issuer.

@clintonskitson it can be done per task as described but since this is an environment variable, if the environment variable is set at the agent node level, you wouldn't need to specify it per task and it would automatically be inherit to every task. I was just trying to describe how granular you could potentially get.

Will be closing this PR out as there is a new PR https://github.com/emccode/mesos-module-dvdi/pull/100 open that will resolve this issue along with other outstanding issues.

The PR mentioned above has been merged. If this doesn't meet you requirements, we can revisit the issue.

authors: branden clintonskitson dvonthenen jdef

repo: emccode/mesos-module-dvdi


text:
doc: Re-introduce EBS driver

DO NOT MERGE until https://github.com/emccode/libstorage/pull/273 has been merged.
Formerly known as ec2, add the ebs driver back into the mix. Add links
to EBS and EFS drivers from libstorage. Also, fixup the README to have a
working example of setting env vars on the CLI and running rexray.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

Current coverage is 44.55% (diff: 100%)

Merging #566 into master will not change coverage

@@             master       #566   diff @@
==========================================
  Files             2          2
  Lines           193        193
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
  Hits             86         86
  Misses          107        107
  Partials          0          0

Powered by Codecov. Last update 8964279...e51a6e5

Hi @codenrhoden,
I'm approving this and will be closing it with #578 and the commit that replaces this one, 13421b4598949378503f1279854ca6f890713bc7. Thank you again!

FWIW @codenrhoden, the new commit uses your old commit's message and authorship, so you don't lose any attribution. That's important to me.

authors: CLAassistant akutz codecov-io codenrhoden

repo: emccode/rexray


text:
Change position of Checkbox label

Currently it seems like there's no way to make a checkbox (or radiobox) whose text precedes its button. This would be a useful layout option, as having labels before controls and text after checkboxes clashes a lot.

Are we sure this is the right solution?

having labels before controls and text after checkboxes clashes a lot

The other solution is to move others labels to be after the control.
The problem with moving them to the right is that it aligns badly:
Accept EULA: [ ]
Sign up to newsletter: [ ]

vs
[ ] Accept EULA
[ ] Sign up to newsletter

The nicer way to have checkboxes to the right is to align them using a Grid (which is already possible):
Accept EULA:           [ ]
Sign up to newsletter: [ ]

I wasn't aware about Grids. That does seems like a better solution to the problem I had.

authors: OfficialURL emilk

repo: emilk/egui


text:
Runtime options

Closes https://github.com/emilk/loguru/issues/117
Helps https://github.com/emilk/loguru/issues/94 and https://github.com/emilk/loguru/issues/103
This is a breaking change for a minority of people, but it will be a compile-time failure with helpful errors messages.

Thanks @emilk, this is great!

authors: Qix- emilk

repo: emilk/loguru

license: Unlicense


text:
feature:  add example with vaul

Given that the two libraries both include swiping gestures, I would love to see an example where a toast is fired from within a vaul drawer and can still function. The provider would be defined outside of the drawer.

Won't be adding it, I'd say it's up to the user. You can either decide to close on intearcting outside of Vaul (defaul), or keep it open when interacting with sonner.

authors: Kinbaum emilkowalski

repo: emilkowalski/sonner


text:
Replace requests and add sanity tests

This PR includes:

Replace requests library with urllib/urllib2
Add sanity testing, including Travis
Fix all pylint and PEP8 issues
Add pip requirements.txt
Add a Makefile for creating a working ZIP package

This fixes #64 and relates to #63

It would be nice if Travis integration could be enabled for the sanity testing.

I am sorry for mixing 2 things up in a single PR, but I started with removing Requests with urlib/urllib2 for performance reasons (removing 800ms hit for loading urllib3 on RPi).
And only when I had that done, I looked at testing this code easily which required some changes. An so I added PEP8 and pylint to this as well.

I checked your changes and saw you broke _install_inputstream function. Because xbmc.executebuiltin doesn't return if it succeeded or failed we have to check afterwards if the inputstream addon exists. I added this fix to this pull request already.
I will do a couple of more tests today and report back.

Please split the changes into separate commits before merging as well.

@emilsvennesson How do you want them to be split?

@emilsvennesson I don't mind separating the Requests-change from the sanity checks/fixes. (As it should have been), but separating the different commits make no sense as these are gradual fixes during development. Each change does not represent a new entity, so using the reflog to turn them in commits is a waste of everyone's time.
The amend-commits during development (in most cases) are there for testing, to ensure a new commit hash is used in the ZIP file so I can actually test individual changes, without having a new commit for every small change or typo.

@dagwieers Yeah, it was the requests change I'd like to see as a separate commit. I'm with you on the rest.

I think I managed to split both. It was dirty :-(
And now it needs to be retested, twice.

Added a couple of fixes. Looks good to me now.

I am going to merge this as it is holding everything back at the moment.
PS We could set rules on this repository that e.g. requires PRs to be reviewed or CI turns green before they can be merged etc.

Seems reasonable

I'm okay with setting rules, but I guess that's something the repo owner has to do.

@mediaminister Yes, same for Travis. Only the owner can do this :-/

authors: basrieter dagwieers emilsvennesson mediaminister


text:
EMI crashes when hovering item with minecraft:hide_tooltip component (1.20.6, Fabric)

EMI crashes when ItemStack with hide_tooltip component is hovered in inventory, if option for appending mod name enabled.
You can create this item with /give @p minecraft:sculk[minecraft:hide_tooltip={}]
It happens due to https://github.com/emilyploszaj/emi/blob/1.20.5/xplat/src/main/java/dev/emi/emi/mixin/ItemStackMixin.java#L25 being injected at both returns, one that uses List.of() for disabled tooltips and the old/regular one that uses ArrayList.

Should be fixed in 1.1.7

authors: Patbox emilyploszaj

repo: emilyploszaj/emi


text:
Wärmepumpenmanager Version

Hi, mit welcher Wärmepumpenmanager Version, wurde denn das ganze bei der System M getestet, mit Version M1.2 oder M1.4?

Okay super, ich habe eine System M mit der Version M1.4 und der Software Version 5.0.6.
Wie hast du den Zugriff auf die HTTP API erhalten? Bei Version M1.2 hatte ich darauf zugriff, nach dem Update auf M1.4 nicht mehr.

You're right. Firewall was locked down in the last update.
Can't give you detailed instructions here but if you have SSH access you could login and change these firewall rules. Such rules could be defined in a file probably named 'lib/firewall/index.js' or something like that. The software running is called 'uhi' I think, so maybe look for a folder under /usr/local/uhi.
Linux iptables rules have either a 'drop' or 'accept' policy. So changing something from '-P INPUT DROP' to '-P INPUT ACCEPT' will allow that traffic.
Of course you do this all on your own responsibility. 😉
Hoffe du hast verstanden was ich meine. Viel Glück 😄

Oh and if you can't remember your password needed for the SSH access...
What once helped me, in a totally unrelated case, to get access to my raspberry again was to turn down the raspberry, take the sd card and put it in another computer, mount the partition and copy your SSH key over under the user you want to login (e.g. /home/user/.ssh/authorized_keys).
Put that card in the raspberry again and boot.
No idea if that is helpful to you 😉

authors: emischorr xeboo


text:
v0.3.0

Description
As discussed in a previous dev meeting, this PR implements specific readers for input datas.
Changes

Created the amd.loaders module to house data readers
Created the Granules loader for handling EMIT granules

Added a Jupyter notebook to demonstrate how to use

I have reviewed and executed the code in this pull request. Everything works great and as expected for me. I will tag Phil for final approval, but my review of the code raises no issues.

authors: jammont mikebramble

repo: emit-sds/mined-lands


text:
Protyp modelu ML do transferu stylu

Podstawowe pytanie: jakie podejście chcemy zastosować?

CycleGAN – podejście unsupervised starające się znaleźć mapowanie między dwiema domenami, bez wykorzystania podanych na tacy mapowań 1:1. Jeżeli klasyfikator działałby nawet w przypadku kilku stylów, to pewnie można by wykorzystać go jako discriminator obrazów tworzonych przez generator.
CycleGAN lub jego poprzednia wersja wykorzystująca maski segmentacji – treningowe dane w postaci obrazów i ich posegmentowanych odpowiedników, czyli bardziej supervised. Obraz na wejściu wpadałby w segmentator, ten wyrzucałby maski, następnie takie maski wchodziłyby do generatora z dodatkową informacją mówiącą w jakim stylu pomieszczenie ma być wykończone → na wyjściu powinniśmy otrzymać obraz o takich samych elementach, ale odmiennym charakterze
Można pewnie jakoś podpiąć EditGANa i na sztywno określić jakie modyfikacje ma wykonywać

Wszystko zostanie wyłonione podczas realizacji #39 i #38

authors: MatOgr emkarcinos

repo: emkarcinos/AITech-flats


text:
Enhancement Requirment - Date Picker Field

Adding more field like Date Picker would be great.
I have also thought of adding select, but things go comprehensive this way.

Thanks @emkay .
Please check the pull request: pull request #8

repo: emkay/material-ui-table-edit


text:
Improved handling of .AOK_VARS fixed issues in aok_groups

fixed importing of .AOK_VARS to avoid fork bombs removed inline include stuff, now one can copy AOK_VARS to .AOK_VARS and modify it.

fixed aok_groups only to read _APKS variables, and now one can override existing and add _APKS groups in .AOK_VARS If a group is set to "" it will not be displayed by aok_groups

Awesome.  Thank you!


text:
ENYO-5365: Fixed overscroll effects on improper timing

Issue Resolved / Feature Added

Fixed not to show an overscroll effect when a focus moves between paging control buttons right after a list reached to the edge.
Fixed to show an overscroll effect by the first wheeling on native lists.

Resolution
The internal status variable is shared for effects on both edges (beginning and ending), so updating the variable by reaching one edge affected an effect for the other edge. In this PR, effects for both edges have their own status variable.
Links
ENYO-5365
Comments
Enact-DCO-1.0-Signed-off-by: Seungcheon Baek (sc.baek@lge.com)

Hmm. it's a just clearing code and is not required. I will change the name of the first function.

I found there was one issue with dragging.
If dragging vertically to show overscroll effect on the top or on the bottom while showing overscroll effect on the left or on the right, the vertical and horizontal overscroll effects are hidden at the same time even though the horizontal overscroll effect was shown first.
I think it is the reason to call clearAllOverscrollEffects() in https://github.com/enactjs/enact/blob/8104e49a5352f574126d472734b4fad4a9872031/packages/ui/Scrollable/Scrollable.js#L560, then all overscroll effect are hidden at the same time.

Thanks for reporting. I have already one ticket to handle drag cases and I will check this also.

@ybsung

I found there was one issue with dragging.
If dragging vertically to show overscroll effect on the top or on the bottom while showing overscroll effect on the left or on the right, the vertical and horizontal overscroll effects are hidden at the same time even though the horizontal overscroll effect was shown first.

I thought you pointed out some flicking, but it looks a dragging case. All effects by dragging should be gone at the same time. It is not a problem. If I misunderstood, please let me know.

To make relations between internal functions clearer and to remove redundant check codes, I updated to check conditions (to show effects) within a requesting methods (input handlers, scrolling logics, etc) instead of effect handling methods. It is a simple change of a concept but most code for overscroll effect is affected.

LGTM

repo: enactjs/enact


text:
faucet claim didn't work for reputable

NYT bootstrapper EPrZ1Lu6fHW7Fk7mYHxpoiXCLCJKqXR8w2EnyqMJLczrm4R failed to claim
there was an extrinsic error "insufficientBalance"

@clangenb  it possible that the faucet claim implementation in the app doesn't recognize NYT to use as fee payment when sending the faucet claim extrinsic (or it uses the wrong token leading to insufficient balance)?
current balances of the mentioned account:
u0qj944rhWE: 8.9592480648918493148 LEU
kygch5kVGq7: 11.90345849166083718775 NYT
19336095210 (19mKSM)

Hmm, I can't explain this:
https://github.com/encointer/encointer-wallet-flutter/blob/28e09d603e4db9253f4ce2be99559a0c47bed922/app/lib/store/encointer/encointer.dart#L187-L204
The function is a bit flawed if preferredCid is not equal chosenCid, but we always call it with chosenCid.
So, the observed behaviour is obviously that we try to pay with the native balance (or maybe with an inexistent cid, not sure if this would throw another error). So I think we try to pay in the native currency, can only happen if:

account! throws a null exception
.firstWhere((e) => applyDemurrage(e.value)! > 0.13) throws an exception, which can be due to:

applyDemurrage is null, but it is initialized upon ap startup and hence non-zero.
there is no cid with amount < 0.13 after demurrage, but based on your balance reports, I would be surprised.

Hmm. I have to try to reproduce it.

Yes the account may actually have been initialized on gesell

I have found the culprit: insufficient funds is an error we infer from the RPC error. The actual error is bad signature:
[log] [DEBUG]  ==> : [TxPaymentAsset]: Enough funds in preferred cid {"principal":"22.933469182418623","lastUpdate":3523116} to pay tx fee.
[log] [PRINT]  ==> : Header: {parentHash: 0x76f3a9e72ef612cdf9cb36809ed70d564af2dc0c7ced81233a6009322da99576, number: 0x35c241, stateRoot: 0x6830e926b9ef9ce724dfd5c4921ec62b4ba481a2d1c1a360ee9a0f93b1eea97b, extrinsicsRoot: 0x663a432f50d3550aff46ed67a0941dd53523c160d4d6b73833b3be5bfb3c124b, digest: {logs: [0x066175726120051c7a0800000000, 0x0452505352901022c2625cdf284f807599a6fc4eb30ced1457e21a125fd4b4a580dc29be075ba6d82302, 0x05617572610101549f339edea95271d4e21238bb1a00efffcffcfcbbe19418284c6d023433e731d8be0708cdc0a131d4c7afb9849e20e272062767dc8af1fc3c7d59fbcd34e781]}}
[log] [PRINT]  ==> : [subscribeNewHeads] Got header: {number: 3523137}
[log] [PRINT]  ==> : [getBlockHash] params: [3523137]
[log] [PRINT]  ==> : [getBlockHash] hash: 0x3742f72e93adfb297cb8db5918915dc212db4677042fdaebae29a5c07a54cfa9
[log] [DEBUG] EncointerApi ==> : api: Getting pendingIssuance for 5Dkgw1dQHWUuaYPjh8tPoayxkQSS67PM3FXh6QGf48zXChBd
[log] [DEBUG] Api ==> : Dart Rpc Api is connected: true
[log] [DEBUG] Api ==> : Provider is connected: true
[log] [ERROR]  ==> : Caught RPC error while sending extrinsics: Exception: {code: 1010, message: Invalid Transaction, data: Transaction has a bad signature}

I will close the issue as this was before the major revamp where we got rid of JS.

authors: brenzi clangenb

repo: encointer/encointer-wallet-flutter


text:
Generate icons with no border where appropriate

For channels with thumbnails matching a particular set of constraints,
we will generate icons where the thumbnail fills all available space.
https://phabricator.endlessm.com/T32101

If you're curious, here's a Jupyter notebook and a big JSON file with a whole bunch of thumbnails, so you can poke at this across all the icons in one place:
https://drive.google.com/file/d/1S9kMll8GY5uYbXbcYAQpSBlsvU4qMdOd/view?usp=sharing

repo: endlessm/kolibri-app-desktop-xdg-plugin


text:
[tarantool] Mark 2.8 series as EOL

See the release lifetime information on the website:
https://www.tarantool.io/en/doc/latest/release/calendar/

Thank you for your contribution 🎉 🥇 👍 💯

authors: Totktonada usta


text:
Make openapi json more stable

sort by name or preserve order defined in code where possible

Hello, thank you for your contribution! Would you mind elaborating on the reasons why minimizing the diffs of the OpenAPI document is important?

well i just store it in git to check if it evolves compatibly

Thank you again @OlegYch, I’ve just released version 1.12.0 of endpoints4s with your changes.

cheers

Actually I made a mistake, but I will release 1.12.1 with your changes…

authors: OlegYch julienrf


text:
custom timeout refresh plz

we need a custom timeout refresh please :)
it's a pain, the refreshment is too fast in some cases.

What do you mean by too fast? What is the problem you are trying to solve?

the issue happen on big project.
the update are too fast i think.
for small projet it fine, but on big example , i get many freeze when i write a simple letter.
The update take ~1,2 seconde for each letters.

Oh i see what you're saying the refresh is painful for a large playground, and because it happens so often you are having a poor editing experience.
I think I would want to have a "manual update" checkbox for that when checked gives you a button to click when you want it to update.
Also profiling the update to see if there is something we can do to make it faster would be good.

yes a check box for disable the live update it a good idea.

Fixed by 4ef92956793fe67810b3821a6829b1a2aef41ce6.
There is now a manual Refresh button and a checkbox in the settings to disable auto update.

authors: djmisterjon englercj

repo: englercj/playground


text:
Change the settings panel to Show in CP Nav

The Hide in CP Nav switch feels backwards. I know it says hide with the switch off and while this seems like a little thing but if you're going to use a switch it should be Show in CP Nav with the switch on by default.

@stubear Alright, you win :smile: This has been updated in the latest version (1.3.3). Thanks!

authors: engram-design stubear

repo: engram-design/FieldManager


text:
incompatibility with bobby?

https://pastebin.com/2fddh525

(Edited to put the crashlog in a pastebin)
At a glance it looks like Bobby doesn't like that the mod creates a dummy world to render the player character in UIs. I'm not sure how easy this will be to fix, but I'll look into it.

Fixed in 1.1.1.

repo: enjarai/show-me-your-skin


text:
🛑 Airtopup is down

In 2ebb0ce, Airtopup (https://airtopup.com) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Airtopup is back up in 3c01303 after 14 minutes.

repo: enlivenonedrive/upptime


text:
Rewrite accounts app

[x] #56 Rewrite accounts app from scratch as:

Added a dot env package to secure the secret keys in a safe place.

Updated middelwares.py by adding code to initially create a field in auth toggle as active = False, So initially URLs will not be transferred to /portal, wait here what about other URLs? we can restrict them well later.

Updated models.py by adding code to initially create a user ( if not present or created yet ) based on the given credentials.
added a new model called passphrase to store and change different passphrases.

Registered the passphrase model in admin.py

Updated urls.py by adding two more URLs entry as portal and logout.

Updated views.py by adding code for the index function and added the functionality to automatically check for all passphrases values in the DB and check if the entered passphrase is validated or not? ( if satisfied then, as well as toggling the active model in Auth Toggle to True ). For the portal URL, a Django decorator called @login_required will be preventing users to keep away without logging in to the system using the correct passphrase. A logout function, added to again toggling the active model in Auth Toggle to False and deleting the created user.

That's all, I had done, thank you @enoren5
Best Regards,
Umar Ahmed

Hi @UmarGit!
I tested your changes. Everything runs very well so far. Great work!
To answer your first question, all the other urls should be protected, not just portal. So if a web visitor navigates to an essay or tarot_key, then Django should serve them the gateway until they enter a correct passphrase.
You asked a second question which I don't completely understand. You said:

Updated views.py by adding code for the index function and added the functionality to automatically check for all passphrases values in the DB and check if the entered passphrase is validated or not? ( if satisfied then, as well as toggling the active model in Auth Toggle to True )

Could you please clarify what you mean?
Here are some of my remaining questions:

For the accounts app, in the AdminDashboard, can you show a list of passphrases submitted by the admin user? Also: the admin user should be able to delete one of the passphrases listed.
Could you also add a timer so that after 1 hour goes by, Django will re-route them to gateway.html requiring the web visitor to re-enter a valid passphrase?

Hey @enoren5

I didn't ask any question above, I was trying to explain the workflow to you only.

To answer your questions:

You can visit admin view on to add passphrases, delete or modify them.

Okay I will it like a session time out thing and explain it to you after implementing.

thank you @enoren5
Best Regards,
Umar Ahmed

Thanks Umar! Issue #58 has been resolved. I am curious to learn more about your thoughts on the session time-out feature that you said you could explain.

Yes @enoren5 sure !


text:
Move transfer_2022 (BALTRAD SFTP -> S3) script as function to vptstools

@stijnvanhoey, you probably have already started with this? The idea is to remove the script at https://github.com/enram/data-repository/tree/master/transfer_2022 and make it part of the vptstools.

Is already part of https://github.com/enram/vptstools/pull/19, closing this

authors: peterdesmet stijnvanhoey

repo: enram/vptstools


text:
Update @ensdomains/ens to 0.4.5

Fixes #71:

There is a newer version 0.4.5 that removes a dependency on ganache-cli, which is not needed. Would really appreciate this change to reduce dependency bloat.

Sorry to insist. Would love if a new version could be published to npm.

repo: ensdomains/ensjs


text:
MacOS binary is not signed/notarised

There is an issue with signing the macOS package. This happened after upgrading the GraalVM to version 21.
Relevant PR enso-org/ide#1640 addressing the GraalVM version change.

What did you do?

Open the Enso IDE.
What did you expect to see?

An Enso IDE opens without an error message.
What did you see instead?

An error message.
Enso Version

Enso 2.0.0-alpha.6
Last working build (with GraalVM 20) https://github.com/enso-org/ide/actions/runs/967308683
Additional notes

How can I workaround this to run the app? Is it possible?

@kneczaj-p44 I think you can. Try opening your Applications folder in Finder, right-click Enso and choose Open. It should override MacOS' security restrictions.

repo: enso-org/enso


text:
Backend crash on startup

In current develop (b700679d35), on Linux, I am unable to start the application (./run ide start --skip-wasm-opt):
[...]
 INFO ide_ci::program::command: enso⚠ [info] [2023-04-17T18:21:44.549Z] [org.enso.projectmanager.boot.ProjectManager$] Starting Project Manager...
 INFO ide_ci::program::command: enso⚠ [info] [2023-04-17T18:21:44.567Z] [org.enso.projectmanager.boot.ProjectManager$] Started server at 127.0.0.1:30535, press enter to kill server
 INFO ide_ci::program::command: enso⚠ [info] [2023-04-17T18:21:46.018Z] [org.enso.projectmanager.protocol.ClientController] Client connected to Project Manager [c5402c02-8675-4383-a3f2-4a11a0ad5af2]
 INFO ide_ci::program::command: enso⚠ java.lang.StackOverflowErrorjava.lang.StackOverflowErrorjava.lang.StackOverflowErrorjava.lang.StackOverflowErrorjava.lang.StackOverflowError
 INFO ide_ci::program::command: enso⚠   at org.graalvm.nativeimage.builder/com.oracle.svm.core.graal.snippets.StackOverflowCheckImpl.newStackOverflowError0(StackOverflowCheckImpl.java:333)
 INFO ide_ci::program::command: enso⚠   at org.graalvm.nativeimage.builder/com.oracle.svm.core.graal.snippets.StackOverflowCheckImpl.newStackOverflowError(StackOverflowCheckImpl.java:329)
 INFO ide_ci::program::command: enso⚠   at org.graalvm.nativeimage.builder/com.oracle.svm.core.graal.snippets.StackOverflowCheckImpl.throwNewStackOverflowError(StackOverflowCheckImpl.java:309)
 INFO ide_ci::program::command: enso⚠   at org.graalvm.nativeimage.builder/com.oracle.svm.core.jni.functions.JNIFunctions.FindClass(JNIFunctions.java:340)
 INFO ide_ci::program::command: enso⚠   at java.base@11.0.18/java.io.FileOutputStream.writeBytes(FileOutputStream.java)
 INFO ide_ci::program::command: enso⚠   at java.base@11.0.18/java.io.FileOutputStream.write(FileOutputStream.java:354)
 INFO ide_ci::program::command: enso⚠   at java.base@11.0.18/java.io.BufferedOutputStream.flushBuffer(BufferedOutputStream.java:81)
 INFO ide_ci::program::command: enso⚠   at java.base@11.0.18/java.io.BufferedOutputStream.write(BufferedOutputStream.java:127)
 INFO ide_ci::program::command: enso⚠   at java.base@11.0.18/java.io.PrintStream.write(PrintStream.java:559)
 INFO ide_ci::program::command: enso⚠   at java.base@11.0.18/sun.nio.cs.StreamEncoder.writeBytes(StreamEncoder.java:233)
 INFO ide_ci::program::command: enso⚠   at java.base@11.0.18/sun.nio.cs.StreamEncoder.implFlushBuffer(StreamEncoder.java:312)
 INFO ide_ci::program::command: enso⚠   at java.base@11.0.18/sun.nio.cs.StreamEncoder.flushBuffer(StreamEncoder.java:104)
 INFO ide_ci::program::command: enso⚠   at java.base@11.0.18/java.io.OutputStreamWriter.flushBuffer(OutputStreamWriter.java:181)
 INFO ide_ci::program::command: enso⚠   at java.base@11.0.18/java.io.PrintStream.write(PrintStream.java:606)
 INFO ide_ci::program::command: enso⚠   at java.base@11.0.18/java.io.PrintStream.print(PrintStream.java:745)
 INFO ide_ci::program::command: enso⚠   at java.base@11.0.18/java.io.PrintStream.println(PrintStream.java:899)
 INFO ide_ci::program::command: enso⚠   at java.base@11.0.18/java.lang.Throwable$WrappedPrintStream.println(Throwable.java:752)
 INFO ide_ci::program::command: enso⚠   at java.base@11.0.18/java.lang.Throwable.printStackTrace(Throwable.java:659)
 INFO ide_ci::program::command: enso⚠   at java.base@11.0.18/java.lang.Throwable.printStackTrace(Throwable.java:648)
 INFO ide_ci::program::command: enso⚠   at java.base@11.0.18/java.lang.Throwable.printStackTrace(Throwable.java:639)
 INFO ide_ci::program::command: enso⚠   at zio.RuntimePlatformSpecific.$anonfun$defaultReportFatal$1(RuntimePlatformSpecific.scala:38)
 INFO ide_ci::program::command: enso⚠   at zio.internal.FiberRuntime.handleFatalError(FiberRuntime.scala:674)
 INFO ide_ci::program::command: enso⚠   at zio.internal.FiberRuntime.runLoop(FiberRuntime.scala:1274)
 INFO ide_ci::program::command: enso⚠   at zio.internal.FiberRuntime.runLoop(FiberRuntime.scala:944)
[...previous line repeated many times...]
 INFO ide_ci::program::command: enso⚠   at zio.internal.FiberRuntime.evaluateEffect(FiberRuntime.scala:391)
 INFO ide_ci::program::command: enso⚠   at zio.internal.FiberRuntime.evaluateMessageWhileSuspended(FiberRuntime.scala:514)
 INFO ide_ci::program::command: enso⚠   at zio.internal.FiberRuntime.drainQueueOnCurrentThread(FiberRuntime.scala:230)
 INFO ide_ci::program::command: enso⚠   at zio.internal.FiberRuntime.run(FiberRuntime.scala:139)
 INFO ide_ci::program::command: enso⚠   at java.base@11.0.18/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515)
 INFO ide_ci::program::command: enso⚠   at java.base@11.0.18/java.util.concurrent.FutureTask.run(FutureTask.java:264)
 INFO ide_ci::program::command: enso⚠   at java.base@11.0.18/java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:304)
 INFO ide_ci::program::command: enso⚠   at java.base@11.0.18/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
 INFO ide_ci::program::command: enso⚠   at java.base@11.0.18/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
 INFO ide_ci::program::command: enso⚠   at java.base@11.0.18/java.lang.Thread.run(Thread.java:829)
 INFO ide_ci::program::command: enso⚠   at org.graalvm.nativeimage.builder/com.oracle.svm.core.thread.PlatformThreads.threadStartRoutine(PlatformThreads.java:775)
 INFO ide_ci::program::command: enso⚠   at org.graalvm.nativeimage.builder/com.oracle.svm.core.posix.thread.PosixPlatformThreads.pthreadStartRoutine(PosixPlatformThreads.java:203)
 INFO ide_ci::program::command: ensoℹ **** WARNING ****
 INFO ide_ci::program::command: ensoℹ Catastrophic error encountered. Application not safely interrupted. Resources may be leaked. Check the logs for more details and consider overriding `Runtime.reportFatal` to capture context.
 INFO ide_ci::program::command: ensoℹ Backend exited with code 255.

Having trouble reproducing it.

I just made sure I had a clean working directory; it's still happening after rm -rf *; git reset --HARD origin/develop.

Nightly 2023.1.1-nightly.2023.4.18 built from e5a96b97828f865ec9f9a3325a1e407adcf04451 (after the commit in question) works for me. I'll try a clean build tomorrow.

I've bisected it to #6072. Let me know if there's any way I can help debug it.

@4e6 maybe https://github.com/zio/zio/issues/7323?

Looks like it. I'll try to increase the stack size as suggested

@kazcw can you please check if #6355 fixes the issue for you?

authors: 4e6 hubertp kazcw


text:
Source Map Loading Timeout Warnings in Console When Creating a New Project

Open IDE, and create a new project. The following warning appears in the DevTools console:
DevTools failed to load source map: Could not load content for http://localhost:8080/preload.cjs.map: Load canceled due to load timeout
DevTools failed to load source map: Could not load content for http://localhost:8080/pkg.js.map: Load canceled due to load timeout

There should be no warning.

@somebody1234 we are not shipping source maps with the app. We probably should. Could you take a look how to do it, please?

asar l /tmp/.mount_enso-random-string-here/resources/app.asar indicates that these files exist:
/assets/* # elided because they are not relevant
/tasks/computeHashes.cjs
/ensogl-app/index.js
/ensogl-app/index.js.map
/assets/dynamic-assets.js
/assets/dynamic-assets.js.map
/assets/fonts.js
/assets/fonts.js.map
/assets/index.js
/assets/index.js.map
/assets/pkg.js
/assets/run.js
/assets/run.js.map
/index.cjs
/index.cjs.map
/preload.cjs
/preload.cjs.map

initial observations:

pkg.js doesn't have a source map?! i might have forgotten to copy it across? will look into it later, just posting this as a status update
not sure how it's even loading preload.cjs. afaict, the builtin server only serves from assets, which preload.cjs doesn't seem to appear in... but i guess Electron loads that itself.

not sure why electron is trying to load preload.cjs.map then, so i'll just switch sourcemaps to inline

as for pkg.js, i specialcased it. it doesn't seem like it's possible to get sourcemap generation to work, and keep pkg.js as CJS...

actually we do generate it because we pass --sourcemap. so maybe the issue is that it's excluded from ENSO_BUILD_GUI_WASM_ARTIFACTS

and indeed we see that index.js.map is explicitly added but not pkg.js.map.

ok so this comment is mostly outdated but i'd figure i'd keep it here for posterity

authors: mwu-tow somebody1234 wdanilo


text:
Added compare_to to True/False

Pull Request Description
Implements https://www.pivotaltracker.com/story/show/181030200
Checklist
Please include the following checklist in your PR:

[ ] The documentation has been updated if necessary.
[ ] All code conforms to the Scala, Java, and Rust style guides.
All code has been tested:

[x] Unit tests have been written where possible.
[ ] If GUI codebase was changed: Enso GUI was tested when built using BOTH ./run dist and ./run watch.

LGTM

Should probably have a changelog entry added

@4e6 Looks like this one requires :+1: from you as well?

authors: hubertp jdunkerley


text:
entc/gen: allow multiline database comments

I've made a fix to allow multiline database comments.
Previously, this was causing a failure when generating migrate/schema.go.

Thanks for the review! I've added tests in https://github.com/ent/ent/pull/3670/commits/bd2f19425499df741c922d91d3150492c81d84bc

repo: ent/ent


text:
Switch to using the pipeline task name instead of the taskRef name

The taskRef name can be excluded if a task is defined inline, but the pipeline task name is always required.
This change only affects the message on a failed rule.
https://issues.redhat.com/browse/RHTAPBUGS-1076

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (348a610) 100.00% compared to head (a763cdd) 100.00%.
Report is 18 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff            @@
##              main      #841   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           91        91
  Lines         4041      4111   +70
=========================================
+ Hits          4041      4111   +70

Files
Coverage Δ

policy/lib/rule_data.rego
100.00% <ø> (ø)

policy/lib/tekton/task.rego
100.00% <100.00%> (ø)

policy/lib/tekton/task_test.rego
100.00% <100.00%> (ø)

policy/release/attestation_task_bundle.rego
100.00% <100.00%> (ø)

policy/release/attestation_task_bundle_test.rego
100.00% <100.00%> (ø)

policy/release/buildah_build_task.rego
100.00% <100.00%> (ø)

policy/release/buildah_build_task_test.rego
100.00% <100.00%> (ø)

policy/release/lib/attestations_test.rego
100.00% <100.00%> (ø)

policy/release/olm.rego
100.00% <100.00%> (ø)

policy/release/olm_test.rego
100.00% <100.00%> (ø)

... and 3 more

... and 2 files with indirect coverage changes

authors: codecov-commenter joejstuart

repo: enterprise-contract/ec-policies


text:
Dev gate applicator

Description

Changed the way Gate Objects are structured. Each non-core openqaoa module will need a GateApplicator object which contains library specific functions on how the gates are applied to the circuit. The Gate Object now acts as an interface.
Each Backend now creates a GateApplicator Object that, together with the Gate Object apply the right library gate to the Backend's internal circuit
The implementation of GateApplicator for Qiskit, Braket and Pyquil backends.
Dynamic generation of constants: DEVICE_NAME_TO_OBJECT_MAPPER , DEVICE_ACCESS_OBJECT_MAPPER. Based on the presence of the particular module.
get_qaoa_backend and create_device updated to dynamically find a module if it has been installed.
plugin_finder.py is added which helps facilitate the function needed to dynamically find modules within the environment.
Updated test_gates.py unittests

Checklist

[ ] I have performed a self-review of my code.
[ ] I have commented my code and used numpy-style docstrings
[ ] I have made corresponding updates to the documentation.
[ ] My changes generate no new warnings
[ ] I have added/updated tests to make sure bugfix/feature works.
[ ] New and existing unit tests pass locally with my changes.

Type of change
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?
Name the new unit-tests that you have added along with this change.

Since, I proposed the design in this PR, it makes sense that either @raulconchello, @Q-lds, be the primary reviewer of this PR. I am adding you both for now. I will be reviewing it too

NOTE: If not done yet, run black formatter before merging

repo: entropicalabs/openqaoa


text:
CI: codecov runs fail with 429 during upload

There seems to be an issue with the codecov upload action in this repo. Possibly the GH Action is outdated or the CODECOV_TOKEN secret is wrong?
See this for an example failure.

Possibly caused by an outdated codecov action version, I bumped it in #45, and the codecov action passed. Closing for now, reopen if it happens again.

authors: dvdplm fjarri

repo: entropyxyz/crypto-primes


text:
envoyproxy/envoy:latest is missing in: https://hub.docker.com/r/envoyproxy/envoy/tags

WARNING: If you want to report crashes, leaking of sensitive information,
and/or other security issues, please consider
reporting them using appropriate channels.
Issue Template
Title: One line description
Description:

Describe the issue. Please be detailed. If a feature request, please
describe the desired behaviour, what scenario it enables and how it
would be used.

[optional Relevant Links:]

Any extra documentation required to understand the issue.

Bug Template
Title: One line description
Description:

What issue is being seen? Describe what should be happening instead of
the bug, for example: Envoy should not crash, the expected value isn't
returned, etc.

Repro steps:

Include sample requests, environment, etc. All data and inputs
required to reproduce the bug.

Note: The Envoy_collect tool
gathers a tarball with debug logs, config and the following admin
endpoints: /stats, /clusters and /server_info. Please note if there are
privacy concerns, sanitize the data prior to sharing the tarball/pasting.

Admin and Stats Output:

Include the admin output for the following endpoints: /stats,
/clusters, /routes, /server_info. For more information, refer to the
admin endpoint documentation.

Note: If there are privacy concerns, sanitize the data prior to
sharing.

Config:

Include the config used to configure Envoy.

Logs:

Include the access logs and the Envoy logs.

Note: If there are privacy concerns, sanitize the data prior to
sharing.

Call Stack:

If the Envoy binary is crashing, a call stack is required.
Please refer to the Bazel Stack trace documentation.

With us now releasing security/stable releases, "latest" no longer has any meaning so it has been removed. Please pin to a specific version.

Thanks for the quick reply! Maybe the doc needs to be updated to reflect this https://www.envoyproxy.io/docs/envoy/latest/install/building?

Thanks for the quick reply! Maybe the doc needs to be updated to reflect this

Yes thanks I will fix this. cc @lizan

As of 3/3/3023 the getting started with docker page here: https://www.envoyproxy.io/docs/envoy/v1.6.0/start/start
Still references FROM envoyproxy/envoy:latest

This version is no longer supported and the docs may/not work

This version is no longer supported and the docs may/not work

I deleted my post before realizing someone had responded.  I was referencing an outdated document link, my apologies.

authors: fuqianggao mattklein123 phlax totalknowledge

repo: envoyproxy/envoy


text:
proposal: securing admin endpoint

A proposal to secure the admin endpoint
I was chatting with @mattklein123 a couple weeks ago about securing the admin endpoint, under the assumption that we'd want some way to allow users to specify arbitrary filters (e.g. RBAC).
I would like to propose that we allow specifying a Listener config in the Admin message, and deprecate the Admin fields that can be taken directly from the Listener (e.g. address details).
The AdminFilter would be made a first class filter (registered with just like the other http filters), but we would validate that the AdminFilter is only used within the Admin config, and that the filter is specified last in the filter chain.
I would appreciate feedback from both Envoy users and developers; would this approach work for you?

This dupes https://github.com/envoyproxy/envoy/issues/2763, can you continue the discussion there? Suggest copy+paste ^^. Thanks.

authors: cstrahan htuch


text:
Traffic Control based upstream CPU and Memory etc measurement

Looking at currently traffic policy (weighted) round robin, hash etc load balance, they all does not count on upstream CPU utilization. in  those kind of load balance, if upstream endpoint CPU is high, envoy can still forward traffic to that upstream w/o difference with others upstream endpoints. then it is really not load balanced. So can envoy support traffic control policy based on upstream CPU utilization?
Thanks,
Ryan

Not currently, see https://github.com/envoyproxy/envoy/issues/6614 which would be a good way of accomplishing this.

@mattklein123 that is great. what is the plan to deliver this feature?
Thanks,
Ryan

Hello, any comments?
Thanks,
Ryan


text:
[RFC] Add a glossary to docs

description
The Envoy docs (and community discussions) use a lot of terminology that is not always clear/precise to new users
Some phrases are Envoy-specific, others are common in related communities (eg serverless, service mesh, etc). Many use acronyms
It would be good to have a glossary so key terms used in the Envoy docs can be set out clearly
Terms that immediately spring to mind

typed_config
[a-Z]DS
middle/edge proxy
data plane
control plane
circuit breaker
(Envoy) filter
(Envoy) extension
(Envoy) Bootstrap
sidecar

im happy to collate/write the glossary, but suggestions of terms and/or definitions would be greatly appreciated

+1 this would be great.

Upstream and downstream!

A request is a salmon - https://twitter.com/benplotnick/status/1299178415996702726
https://twitter.com/benplotnick/status/1230308689703100416
https://twitter.com/mattklein123/status/1299139849279082496

front proxy
double proxy

Upstream and downstream!

funnily i had been thinking about definitions for these, but the potentially counter-intuitive request salmon hadnt ever occurred to me.
~definitions i had been thinking of were:

upstream: machine or network that an envoy proxy initiates connections to (in response to downstream requests)
downstream: machine or network initiating requests to an envoy proxy

but now im thinking about request salmons im wondering about egress proxying too

Note that we have https://www.envoyproxy.io/docs/envoy/latest/intro/arch_overview/intro/terminology. We should merge this into whatever we come up with here.

i havent gone through all the service discovery types completely, and some of the terms may not be 100% correct, but ive created a wiki page here to get started
https://github.com/phlax/envoy/wiki/Glossary

thanks @moderation added, and ive opened a wip PR to progress this #13829

authors: mattklein123 moderation phlax


text:
Simple envoy configuration does not work with "netperf"

Title: Netperf fails to connect to netserver when proxied through envoy process
Description:
I have a scenario where I'm using three machines:

Machine with netperf process
Machine with Envoy proxy
Machine with netserver process

When running the client, the connection fails with the error: "Connection Refused".
Few observations:

Traffic arrived at the Envoy process but does not get to the netserver process
If I am bypassing the Envoy process and sending the request directly to the netserver, then the flow works

Repro steps:

Run envoy process with the attached configuration
Start a netserver in the proxied machine: netserver -p 5558 -DfdN4
Start a netperf client in the client machine: netperf -H <envoy_proxy_ip> -p 5557 -l 10 -v2
Receive error: netperf: send_omni: connect_data_socket failed: Connection refused

Config:
admin:
  address:
    socket_address:
      protocol: TCP
      address: 127.0.0.1
      port_value: 9903

static_resources:
  listeners:
  - name: postgres_listener
    address:
      socket_address:
        address: 0.0.0.0
        port_value: 5557
    filter_chains:
    - filters:
      - name: envoy.filters.network.tcp_proxy
        typed_config:
          "@type": type.googleapis.com/envoy.extensions.filters.network.tcp_proxy.v3.TcpProxy
          stat_prefix: postgres_tcp
          cluster: postgres_cluster

  clusters:
  - name: postgres_cluster
    type: STRICT_DNS
    load_assignment:
      cluster_name: postgres_cluster
      endpoints:
      - lb_endpoints:
        - endpoint:
            address:
              socket_address:
                address: netserver_machine
                port_value: 5558

Logs:
Logs abbreviated to the part of the client connection
[2022-07-11 15:51:40.732][72][trace][upstream] [source/common/upstream/cluster_discovery_manager.cc:35] cm cdm: starting processing cluster name postgres_cluster (status 2) from cluster lifecycle callback in
 worker_30
[2022-07-11 15:51:40.732][72][trace][upstream] [source/common/upstream/cluster_discovery_manager.cc:45] cm cdm: no callbacks for the cluster name postgres_cluster in worker_30
[2022-07-11 15:51:40.732][66][trace][upstream] [source/common/upstream/cluster_discovery_manager.cc:45] cm cdm: no callbacks for the cluster name postgres_cluster in worker_26
[2022-07-11 15:51:40.732][1][warning][main] [source/server/server.cc:761] there is no configured limit to the number of allowed active connections. Set a limit via the runtime key overload.global_downstream_
max_connections
[2022-07-11 15:51:44.738][39][debug][filter] [source/common/tcp_proxy/tcp_proxy.cc:197] [C0] new tcp proxy session
[2022-07-11 15:51:44.738][39][trace][connection] [source/common/network/connection_impl.cc:357] [C0] readDisable: disable=true disable_count=0 state=0 buffer_length=0
[2022-07-11 15:51:44.738][39][debug][filter] [source/common/tcp_proxy/tcp_proxy.cc:369] [C0] Creating connection to cluster postgres_cluster
[2022-07-11 15:51:44.738][39][debug][misc] [source/common/upstream/cluster_manager_impl.cc:1895] Allocating TCP conn pool
[2022-07-11 15:51:44.738][39][debug][pool] [source/common/conn_pool/conn_pool_base.cc:268] trying to create new connection
[2022-07-11 15:51:44.738][39][trace][pool] [source/common/conn_pool/conn_pool_base.cc:269] ConnPoolImplBase 0x571a3ebec220, ready_clients_.size(): 0, busy_clients_.size(): 0, connecting_clients_.size(): 0, c
onnecting_stream_capacity_: 0, num_active_streams_: 0, pending_streams_.size(): 1 per upstream preconnect ratio: 1
[2022-07-11 15:51:44.738][39][debug][pool] [source/common/conn_pool/conn_pool_base.cc:145] creating a new connection
[2022-07-11 15:51:44.738][39][debug][connection] [source/common/network/connection_impl.cc:912] [C1] connecting to <netserver_machine>:5558
[2022-07-11 15:51:44.739][39][debug][connection] [source/common/network/connection_impl.cc:931] [C1] connection in progress
[2022-07-11 15:51:44.739][39][trace][pool] [source/common/conn_pool/conn_pool_base.cc:131] not creating a new connection, shouldCreateNewConnection returned false.
[2022-07-11 15:51:44.739][39][debug][conn_handler] [source/server/active_tcp_listener.cc:142] [C0] new connection from <netperf_machine>:52270
[2022-07-11 15:51:44.739][39][trace][connection] [source/common/network/connection_impl.cc:563] [C0] socket event: 2
[2022-07-11 15:51:44.739][39][trace][connection] [source/common/network/connection_impl.cc:674] [C0] write ready
[2022-07-11 15:51:44.739][39][trace][connection] [source/common/network/connection_impl.cc:563] [C1] socket event: 2
[2022-07-11 15:51:44.739][39][trace][connection] [source/common/network/connection_impl.cc:674] [C1] write ready
[2022-07-11 15:51:44.739][39][debug][connection] [source/common/network/connection_impl.cc:683] [C1] connected
[2022-07-11 15:51:44.739][39][trace][connection] [source/common/network/connection_impl.cc:418] [C1] raising connection event 2
[2022-07-11 15:51:44.739][39][trace][connection] [source/common/network/connection_impl.cc:357] [C1] readDisable: disable=true disable_count=0 state=0 buffer_length=0
[2022-07-11 15:51:44.739][39][debug][pool] [source/common/conn_pool/conn_pool_base.cc:305] [C1] attaching to next stream
[2022-07-11 15:51:44.739][39][debug][pool] [source/common/conn_pool/conn_pool_base.cc:177] [C1] creating stream
[2022-07-11 15:51:44.739][39][trace][connection] [source/common/network/connection_impl.cc:357] [C1] readDisable: disable=false disable_count=1 state=0 buffer_length=0
[2022-07-11 15:51:44.739][39][trace][connection] [source/common/network/connection_impl.cc:357] [C0] readDisable: disable=false disable_count=1 state=0 buffer_length=0
[2022-07-11 15:51:44.739][39][debug][filter] [source/common/tcp_proxy/tcp_proxy.cc:665] [C0] TCP:onUpstreamEvent(), requestedServerName:
[2022-07-11 15:51:44.740][39][trace][connection] [source/common/network/connection_impl.cc:563] [C1] socket event: 2
[2022-07-11 15:51:44.740][39][trace][connection] [source/common/network/connection_impl.cc:674] [C1] write ready
[2022-07-11 15:51:44.740][39][trace][connection] [source/common/network/connection_impl.cc:563] [C0] socket event: 3
[2022-07-11 15:51:44.740][39][trace][connection] [source/common/network/connection_impl.cc:674] [C0] write ready
[2022-07-11 15:51:44.740][39][trace][connection] [source/common/network/connection_impl.cc:603] [C0] read ready. dispatch_buffered_data=0
[2022-07-11 15:51:44.740][39][trace][connection] [source/common/network/raw_buffer_socket.cc:24] [C0] read returns: 517
[2022-07-11 15:51:44.740][39][trace][connection] [source/common/network/raw_buffer_socket.cc:38] [C0] read error: Resource temporarily unavailable
[2022-07-11 15:51:44.740][39][trace][filter] [source/common/tcp_proxy/tcp_proxy.cc:552] [C0] downstream connection received 517 bytes, end_stream=false
[2022-07-11 15:51:44.740][39][trace][connection] [source/common/network/connection_impl.cc:478] [C1] writing 517 bytes, end_stream false
[2022-07-11 15:51:44.740][39][trace][connection] [source/common/network/connection_impl.cc:563] [C1] socket event: 2
[2022-07-11 15:51:44.740][39][trace][connection] [source/common/network/connection_impl.cc:674] [C1] write ready
[2022-07-11 15:51:44.740][39][trace][connection] [source/common/network/raw_buffer_socket.cc:67] [C1] write returns: 517
[2022-07-11 15:51:45.723][1][debug][main] [source/server/server.cc:251] flushing stats

cc @alyssawilk hi, could you take a look for this when you have free time? Thanks.

Updating with few more observations:

If I update the envoy's upstream cluster IP to the proxy machine (and not the third machine in the list) then it works.
If I make direct netperf connection from the proxy machine to the server machine, without envoy, then netperf works - this is to rule out problems of firewall configurations

In other words - Envoy successfully creates the netperf connection only if the netserver is created on the same machine. If the upstream IP is of a different machine, then the flow doesn't work

After debugging, I can confirm that the problem is not with Envoy.
netperf is by design listening on a random port for the data connection on each test, so Envoy blocked the data connection traffic, as the destination port was not defined in the yaml

authors: ohadvano wbpcode


text:
FAILED: Build did NOT complete successfully

uname -a
Linux tv3--c9d4bf90 5.15.0-52-generic #58-Ubuntu SMP Thu Oct 13 08:03:55 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
gcc --version
gcc (Ubuntu 11.3.0-1ubuntu1~22.04) 11.3.0
Copyright (C) 2021 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
bazel version
Starting local Bazel server and connecting to it...
Build label: 6.0.0-pre.20220421.3
Build target: bazel-out/k8-opt/bin/src/main/java/com/google/devtools/build/lib/bazel/BazelServer_deploy.jar
Build time: Tue May 3 16:41:11 2022 (1651596071)
Build timestamp: 1651596071
Build timestamp as int: 1651596071
envoy tag:v1.24.1
external/com_google_absl/absl/base/policy_checks.h:79:2: error: #error "C++ versions less than C++14 are not supported."
79 | #error "C++ versions less than C++14 are not supported."
|  ^~~~~
In file included from external/com_google_absl/absl/hash/internal/hash.h:53,
from external/com_google_absl/absl/hash/hash.h:85,
from external/com_google_absl/absl/container/internal/hash_function_defaults.h:55,
from external/com_google_absl/absl/container/flat_hash_map.h:41,
from external/upb/upbc/protoc-gen-upb.cc:28:
external/com_google_absl/absl/strings/string_view.h: In member function 'constexpr void absl::string_view::remove_prefix(absl::string_view::size_type) const':
external/com_google_absl/absl/strings/string_view.h:340:10: error: assignment of member 'absl::string_view::ptr_' in read-only object
340 |     ptr_ += n;
|     ~^~
external/com_google_absl/absl/strings/string_view.h:341:13: error: assignment of member 'absl::string_view::length_' in read-only object
341 |     length_ -= n;
|     ^~
external/com_google_absl/absl/strings/string_view.h:338:18: error: invalid return type 'void' of 'constexpr' function 'constexpr void absl::string_view::remove_prefix(absl::string_view::size_type) const'
338 |   constexpr void remove_prefix(size_type n) {
|                  ^~~~~
external/com_google_absl/absl/strings/string_view.h: In member function 'constexpr void absl::string_view::remove_suffix(absl::string_view::size_type) const':
external/com_google_absl/absl/strings/string_view.h:350:13: error: assignment of member 'absl::string_view::length_' in read-only object
350 |     length_ -= n;
|     ^~
external/com_google_absl/absl/strings/string_view.h:348:18: error: invalid return type 'void' of 'constexpr' function 'constexpr void absl::string_view::remove_suffix(absl::string_view::size_type) const'
348 |   constexpr void remove_suffix(size_type n) {
|                  ^~~~~~~
external/com_google_absl/absl/strings/string_view.h: In member function 'constexpr void absl::string_view::swap(absl::string_view&) const':
external/com_google_absl/absl/strings/string_view.h:358:13: error: passing 'const absl::string_view' as 'this' argument discards qualifiers [-fpermissive]
358 |     *this = s;
|             ^
external/com_google_absl/absl/strings/string_view.h:161:7: note:   in call to 'absl::string_view& absl::string_view::operator=(const absl::string_view&)'
161 | class string_view {
|       ^~~~~~~~~~~
external/com_google_absl/absl/strings/string_view.h:356:18: error: invalid return type 'void' of 'constexpr' function 'constexpr void absl::string_view::swap(absl::string_view&) const'
356 |   constexpr void swap(string_view& s) noexcept {
|                  ^~~~
In file included from external/com_google_absl/absl/types/span.h:69,
from external/com_google_absl/absl/container/internal/inlined_vector.h:33,
from external/com_google_absl/absl/container/inlined_vector.h:53,
from external/com_google_absl/absl/strings/cord.h:78,
from external/com_google_absl/absl/container/internal/hash_function_defaults.h:56,
from external/com_google_absl/absl/container/flat_hash_map.h:41,
from external/upb/upbc/protoc-gen-upb.cc:28:
external/com_google_absl/absl/types/internal/span.h: At global scope:
external/com_google_absl/absl/types/internal/span.h:141:26: error: 'remove_const_t' in namespace 'std' does not name a template type; did you mean 'remove_const'?
141 |   using Container = std::remove_const_t;
|                          ^~~~~~~~~~~~~~
|                          remove_const
external/com_google_absl/absl/types/internal/span.h:143:58: error: ISO C++ forbids declaration of 'type name' with no type [-fpermissive]
143 |       decltype(span_internal::GetData(std::declval<const Container&>()));
|                                                          ^~~~~~~~~
external/com_google_absl/absl/types/internal/span.h:143:44: error: parse error in template argument list
143 |       decltype(span_internal::GetData(std::declval<const Container&>()));
|                                            ^~~~~~~~~~~~~~~~~~~~~~~~~
external/com_google_absl/absl/types/internal/span.h:144:64: error: 'Container' was not declared in this scope
144 |   using MutData = decltype(span_internal::GetData(std::declval<Container&>()));
|                                                                ^~~~~~~~~
external/com_google_absl/absl/types/internal/span.h:144:56: error: parse error in template argument list
144 |   using MutData = decltype(span_internal::GetData(std::declval<Container&>()));
|                                                        ^~~~~~~~~~~~~~~~~~~
external/com_google_absl/absl/types/internal/span.h:152:29: error: 'enable_if_t' in namespace 'std' does not name a template type
152 | using EnableIfIsView = std::enable_if_t<IsView::value, int>;
|                             ^~~~~~~~~~~
external/com_google_absl/absl/types/internal/span.h:152:24: note: 'std::enable_if_t' is only available from C++14 onwards
152 | using EnableIfIsView = std::enable_if_t<IsView::value, int>;
|                        ^~~
external/com_google_absl/absl/types/internal/span.h:155:32: error: 'enable_if_t' in namespace 'std' does not name a template type
155 | using EnableIfNotIsView = std::enable_if_t<!IsView::value, int>;
|                                ^~~~~~~~~~~
external/com_google_absl/absl/types/internal/span.h:155:27: note: 'std::enable_if_t' is only available from C++14 onwards
155 | using EnableIfNotIsView = std::enable_if_t<!IsView::value, int>;
|                           ^~~
In file included from external/com_google_absl/absl/container/internal/inlined_vector.h:33,
from external/com_google_absl/absl/container/inlined_vector.h:53,
from external/com_google_absl/absl/strings/cord.h:78,
from external/com_google_absl/absl/container/internal/hash_function_defaults.h:56,
from external/com_google_absl/absl/container/flat_hash_map.h:41,
from external/upb/upbc/protoc-gen-upb.cc:28:
external/com_google_absl/absl/types/span.h:201:39: error: 'EnableIfNotIsView' in namespace 'absl::span_internal' does not name a template type
201 |             typename = span_internal::EnableIfNotIsView>
|                                       ^~~~~~~~~~~~~~~~~
external/com_google_absl/absl/types/span.h:201:56: error: expected '>' before '<' token
201 |             typename = span_internal::EnableIfNotIsView>
|                                                        ^
external/com_google_absl/absl/types/span.h:210:39: error: 'EnableIfNotIsView' in namespace 'absl::span_internal' does not name a template type
210 |             typename = span_internal::EnableIfNotIsView>
|                                       ^~~~~~~~~~~~~~~~~
external/com_google_absl/absl/types/span.h:210:56: error: expected '>' before '<' token
210 |             typename = span_internal::EnableIfNotIsView>
|                                                        ^
external/com_google_absl/absl/types/span.h:222:28: error: 'absl::span_internal::EnableIfIsView' has not been declared
222 |             span_internal::EnableIfIsView = 0>
|                            ^~~~~~~~~~~~~~
external/com_google_absl/absl/types/span.h:222:42: error: expected '>' before '<' token
222 |             span_internal::EnableIfIsView = 0>
|                                          ^
external/com_google_absl/absl/types/span.h:223:12: error: 'template template<class V, class, class,  > absl::Span::Span(V&)' cannot be overloaded with 'template template<class V, class, class, class> absl::Span::Span(V&)'
223 |   explicit Span(V& v) noexcept  // NOLINT(runtime/references)
|            ^~~~
external/com_google_absl/absl/types/span.h:202:12: note: previous declaration 'template template<class V, class, class, class> absl::Span::Span(V&)'
202 |   explicit Span(
|            ^~~~
external/com_google_absl/absl/types/span.h:227:28: error: 'absl::span_internal::EnableIfIsView' has not been declared
227 |             span_internal::EnableIfIsView = 0>
|                            ^~~~~~~~~~~~~~
external/com_google_absl/absl/types/span.h:227:42: error: expected '>' before '<' token
227 |             span_internal::EnableIfIsView = 0>
|                                          ^
external/com_google_absl/absl/types/span.h:228:13: error: 'template template<class V, class, class,  > constexpr absl::Span::Span(const V&)' cannot be overloaded with 'template template<class V, class, class, class> constexpr absl::Span::Span(const V&)'
228 |   constexpr Span(const V& v) noexcept  // NOLINT(runtime/explicit)
|             ^~~~
external/com_google_absl/absl/types/span.h:211:13: note: previous declaration 'template template<class V, class, class, class> constexpr absl::Span::Span(const V&)'
211 |   constexpr Span(
|             ^~~~
In file included from external/com_google_absl/absl/container/internal/layout.h:176,
from external/com_google_absl/absl/strings/internal/cord_rep_ring.h:25,
from external/com_google_absl/absl/strings/cord.h:88,
from external/com_google_absl/absl/container/internal/hash_function_defaults.h:56,
from external/com_google_absl/absl/container/flat_hash_map.h:41,
from external/upb/upbc/protoc-gen-upb.cc:28:
external/com_google_absl/absl/strings/str_cat.h:242:33: error: 'enable_if_t' is not a member of 'std'
242 | struct HasAbslStringify<T, std::enable_if_t<std::is_void<decltype(AbslStringify(
|                                 ^~~~~~~~~~~
external/com_google_absl/absl/strings/str_cat.h:242:33: note: 'std::enable_if_t' is only available from C++14 onwards
external/com_google_absl/absl/strings/str_cat.h:242:33: error: 'enable_if_t' is not a member of 'std'
external/com_google_absl/absl/strings/str_cat.h:242:33: note: 'std::enable_if_t' is only available from C++14 onwards
external/com_google_absl/absl/strings/str_cat.h:244:61: error: type/value mismatch at argument 2 in template parameter list for 'template<class T, class> struct absl::HasAbslStringify'
244 |                                std::declval<const T&>()))>::value>>
|                                                             ^~~~~
external/com_google_absl/absl/strings/str_cat.h:244:61: note:   expected a type, got '( < std::is_void<decltype (AbslStringify(declvalabsl::strings_internal::StringifySink&(), declval<const T&>()))>::value)'
external/com_google_absl/absl/strings/str_cat.h:244:66: error: expected unqualified-id before '>' token
244 |                                std::declval<const T&>()))>::value>>
|                                                                  ^~
1671113398.136278451: src/main/tools/linux-sandbox-pid1.cc:498: wait returned pid=2, status=0x100
1671113398.136320894: src/main/tools/linux-sandbox-pid1.cc:516: child exited normally with code 1
1671113398.137759878: src/main/tools/linux-sandbox.cc:233: child exited normally with code 1
Target //source/exe:envoy-static failed to build
INFO: Elapsed time: 1970.614s, Critical Path: 136.28s
INFO: 2726 processes: 1047 internal, 1679 linux-sandbox.
FAILED: Build did NOT complete successfully
@Keith Smiley

https://github.com/envoyproxy/envoy/issues/24464#issuecomment-1355469686

authors: Webster-Yang keith


text:
Golang filter example fails to build

Description:
I'm trying to build the golang filter example by running the verify.sh script, it fails in the building step with this error
[+] Running 1/0
 ⠿ Container golang-go_plugin_compile-1  Created                                                                                0.1s
Attaching to golang-go_plugin_compile-1
golang-go_plugin_compile-1  | 2023/03/13 17:07:34 Downloading https://releases.bazel.build/6.0.0/release/bazel-6.0.0-linux-x86_64...
golang-go_plugin_compile-1  | $TEST_TMPDIR defined: output root default is '/tmp' and max_idle_secs default is '15'.
golang-go_plugin_compile-1  | Starting local Bazel server and connecting to it...
golang-go_plugin_compile-1  | Loading:
golang-go_plugin_compile-1  | Loading: 1 packages loaded
golang-go_plugin_compile-1  | Analyzing: target //examples/golang/simple:simple.so (2 packages loaded, 0 targets configured)
golang-go_plugin_compile-1  | Analyzing: target //examples/golang/simple:simple.so (76 packages loaded, 6 targets configured)
golang-go_plugin_compile-1  | Analyzing: target //examples/golang/simple:simple.so (117 packages loaded, 527 targets configured)
golang-go_plugin_compile-1  | Analyzing: target //examples/golang/simple:simple.so (117 packages loaded, 527 targets configured)
golang-go_plugin_compile-1  | Analyzing: target //examples/golang/simple:simple.so (179 packages loaded, 10896 targets configured)
golang-go_plugin_compile-1  | INFO: Analyzed target //examples/golang/simple:simple.so (191 packages loaded, 12411 targets configured).
golang-go_plugin_compile-1  | INFO: Found 1 target...
golang-go_plugin_compile-1  | [0 / 11] [Prepa] BazelWorkspaceStatusAction stable-status.txt
golang-go_plugin_compile-1  | [1 / 19] [Prepa] BazelWorkspaceStatusAction stable-status.txt
golang-go_plugin_compile-1  | [2 / 19] checking cached actions
golang-go_plugin_compile-1  | [45 / 124] [Prepa] GoStdlib external/io_bazel_rules_go/stdlib_/pkg
golang-go_plugin_compile-1  | [70 / 124] GoStdlib external/io_bazel_rules_go/stdlib_/pkg; 0s processwrapper-sandbox
golang-go_plugin_compile-1  | [70 / 124] GoStdlib external/io_bazel_rules_go/stdlib_/pkg; 11s processwrapper-sandbox
golang-go_plugin_compile-1  | [70 / 124] GoStdlib external/io_bazel_rules_go/stdlib_/pkg; 41s processwrapper-sandbox
golang-go_plugin_compile-1  | [70 / 124] GoStdlib external/io_bazel_rules_go/stdlib_/pkg; 101s processwrapper-sandbox
golang-go_plugin_compile-1  | [70 / 124] GoStdlib external/io_bazel_rules_go/stdlib_/pkg; 161s processwrapper-sandbox
golang-go_plugin_compile-1  | [70 / 124] GoStdlib external/io_bazel_rules_go/stdlib_/pkg; 221s processwrapper-sandbox
golang-go_plugin_compile-1  | ERROR: /tmp/_bazel_envoybuild/b570b5ccd0454dc9af9f65ab1833764d/external/io_bazel_rules_go/BUILD.bazel:42:7: TreeArtifact external/io_bazel_rules_go/stdlib_/pkg was not created
golang-go_plugin_compile-1  | ERROR: /tmp/_bazel_envoybuild/b570b5ccd0454dc9af9f65ab1833764d/external/io_bazel_rules_go/BUILD.bazel:42:7: GoStdlib external/io_bazel_rules_go/stdlib_/pkg failed: not all outputs were created or valid
golang-go_plugin_compile-1  | Target //examples/golang/simple:simple.so failed to build
golang-go_plugin_compile-1  | Use --verbose_failures to see the command lines of failed build steps.
golang-go_plugin_compile-1  | INFO: Elapsed time: 287.570s, Critical Path: 259.52s
golang-go_plugin_compile-1  | INFO: 2 processes: 1 internal, 1 processwrapper-sandbox.
golang-go_plugin_compile-1  | FAILED: Build did NOT complete successfully
golang-go_plugin_compile-1 exited with code 1

I tried --verbose_failures flag, but it doesn't provide any more useful info about the error.
Repro steps:

Clone the repo
Setting up the sandbox environment as described in documentation
cd /examples/golang
./verify.sh

hi @subzerobo this is working in CI and works for me locally so wondering why it would fail
did you try following the steps in the docs rather than trying to run the verify.sh script which is more intended for CI/dev?

I tried --verbose_failures flag, but it doesn't provide any more useful info about the error.

might be worth trying --sandbox_debug

cc @wangfakang

hello @subzerobo  with --sandbox_debug have any update? I have some guesses, we can try it below.
When compile the go library, the default value of  TEST_ TMPDIR  is /tmp/envoy-docker-build, which is used as the root output directory of bazel. During compilation, many external dependencies need to be downloaded. I'am not sure that the /tmp/ directory of your host is Is there any disk space left. You can try to use ENVOY_ DOCKER_ BUILD_ DIR=~/build  ./verify.sh setting the bazel outputRoot directory.

did you try with the latest Envoy code?
we have just switched over to using buildx for the examples so there is quite a lot of change

authors: phlax subzerobo wangfakang