text:
Facebook - Activity Exceptions: Value cannot be null. Parameter name: invalid activity-missing Conversation.Id

Version
4.2.2
Describe the bug
It seems a conversation arrived via the Facebook channel that was potentially missing key data.  I can't tell if the BotFramework got things wrong or something went wrong on the Facebook side
The first exception was dealing with a missing From details (which is understandable as I believe it started in the Web Chat Plugin that doesn't start new conversation with a user opt-in thus allowing access to the users profile data).
Value cannot be null. Parameter name: invalid activity-missing From.Id
Occured on this line:
var userState = await _accessors.AAUserStateAccessor.GetAsync(turnContext, () => new AAUserState(), cancellationToken);
The code I have written to handle exceptions contains this:
await _accessors.ConversationState.LoadAsync(turnContext, false, cancellationToken);
await _accessors.ConversationState.ClearStateAsync(turnContext, cancellationToken);
await _accessors.ConversationState.SaveChangesAsync(turnContext, true, cancellationToken);

So then the next exception in the stack was
Value cannot be null. Parameter name: invalid activity-missing Conversation.Id
This occured on this line:
await _accessors.ConversationState.LoadAsync(turnContext, false, cancellationToken);
Then once all of this had happened the final exception happened in my OnTurnError global handler:
Object reference not set to an instance of an object.
On this line:
await context.SendActivityAsync(Constants.ErrorMessage);
options.OnTurnError = async (context, exception) =>
{
    var ai = new TelemetryClient();
    ai.TrackException(exception);

    logger.LogError($"Exception caught : {exception}");
    await context.SendActivityAsync(Constants.ErrorMessage);

    await _conversationState.LoadAsync(context);
    await _conversationState.ClearStateAsync(context);
    await _conversationState.SaveChangesAsync(context);

    // https://github.com/Microsoft/BotBuilder/issues/5175
    //wait _conversationState.DeleteAsync(context);
};

Which is suggesting that context was in fact null!!
To Reproduce
Steps to reproduce the behavior:

Start a new conversaion via Web Chat Plugin

I can understand the From property being null due to the optin issues on Facebook when using the Web Chat Plugin but I'm not sure that it makes sense that the ConversationId is null.
I have now also updated this particular bot to v4.3.1 of the SDK.
[bug]

I've been unable to reproduce this issue.  Please share the following, so we can investigate further:

Bot Handle
Microsoft App Id for the bot
UTC Time for when the Exception occurred

Not entirely sure what you mean by Bot Handle (did you mean the name of the bot registration? If so that is autoagentbot).
The MS app Id is "9bb3eb37-cea6-490e-8639-5e6248e6f246"
The POST to the bot the caused the error was at 2019-03-11T17:36:41.0249261Z
The first error in that POST was invalid activity-missing From.Id at 2019-03-11T17:36:41.6730105Z

Not entirely sure what you mean by Bot Handle (did you mean the name of the bot registration? If so that is autoagentbot).
The MS app Id is "9bb3eb37-cea6-490e-8639-5e6248e6f246"
The POST to the bot the caused the error was at 2019-03-11T17:36:41.0249261Z
The first error in that POST was invalid activity-missing From.Id at 2019-03-11T17:36:41.6730105Z

Our logs only indicate there was an exception in the bot.
There is nothing in the Bot Framework Facebook Connector Service removing From.Id or Conversation.Id from a message before sending it to the bot.  Either 1) there is an issue with the Facebook Chat Plugin or 2) something is modifying the message in the bot or 3) the message coming in is not a 'normal' or expected message from a user and directed towards a conversation.
More information is required in order to determine what is happening.  Can you log the entire activity that is received when this exception occurs?  Along with a complete stack trace.
Do you have Application Insights configured for the bot, and the web application hosting the bot?  This should provide more information.
Bot: https://docs.microsoft.com/en-us/azure/bot-service/bot-service-manage-analytics?view=azure-bot-service-4.0#enable-analytics
Web Application: https://docs.microsoft.com/en-us/azure/application-insights/app-insights-asp-net

Hi Eric, sorry for no reply so far I've been utterly snowed under. I should have an opportunity to dig all this out for you tomorrow. We do have AI all setup and working so we're all good.
Thanks for your time so far.

Does this help?
name: invalid activity-missing From.Id
ai.snapshot.stampid | uksouth-ohgm3yzm66bru
ai.snapshot.id | 1b148b70664143bd858ab32b4906bc74
System.ArgumentNullException: at Microsoft.Bot.Builder.UserState.GetStorageKey (Microsoft.Bot.Builder, Version=4.2.2.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35) at Microsoft.Bot.Builder.BotState+d__4.MoveNext (Microsoft.Bot.Builder, Version=4.2.2.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35) at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw (System.Private.CoreLib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e) at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess (System.Private.CoreLib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e) at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification (System.Private.CoreLib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e) at Microsoft.Bot.Builder.BotState+BotStatePropertyAccessor`1+d__7.MoveNext (Microsoft.Bot.Builder, Version=4.2.2.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35) at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw (System.Private.CoreLib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e) at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess (System.Private.CoreLib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e) at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification (System.Private.CoreLib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e) at AutoAgent.Bots.AutoAgentBot+d__10.MoveNext (AutoAgent, Version=1.0.0.0, Culture=neutral, PublicKeyToken=nullAutoAgent, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null: D:\a\1\s\AutoAgent\AutoAgent\Bots\AutoAgentBot.csAutoAgent, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null: 202)
Value cannot be null. Parameter name: invalid activity-missing Conversation.Id
ai.snapshot.id | 7532f238aeec4dc98695260f11e04150
ai.snapshot.stampid | uksouth-ohgm3yzm66bru
System.ArgumentNullException: at Microsoft.Bot.Builder.ConversationState.GetStorageKey (Microsoft.Bot.Builder, Version=4.2.2.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35) at Microsoft.Bot.Builder.BotState+d__4.MoveNext (Microsoft.Bot.Builder, Version=4.2.2.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35) at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw (System.Private.CoreLib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e) at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess (System.Private.CoreLib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e) at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification (System.Private.CoreLib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e) at AutoAgent.Bots.AutoAgentBot+d__10.MoveNext (AutoAgent, Version=1.0.0.0, Culture=neutral, PublicKeyToken=nullAutoAgent, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null: D:\a\1\s\AutoAgent\AutoAgent\Bots\AutoAgentBot.csAutoAgent, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null: 381) at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw (System.Private.CoreLib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e) at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess (System.Private.CoreLib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e) at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification (System.Private.CoreLib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e) at Microsoft.Bot.Builder.AutoSaveStateMiddleware+d__7.MoveNext (Microsoft.Bot.Builder, Version=4.2.2.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35) at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw (System.Private.CoreLib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e) at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess (System.Private.CoreLib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e) at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification (System.Private.CoreLib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e) at Microsoft.Bot.Builder.MiddlewareSet+d__3.MoveNext (Microsoft.Bot.Builder, Version=4.2.2.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35) at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw (System.Private.CoreLib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e) at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess (System.Private.CoreLib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e) at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification (System.Private.CoreLib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e) at Microsoft.Bot.Builder.BotAdapter+d__13.MoveNext (Microsoft.Bot.Builder, Version=4.2.2.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35)
I've actually not seen this particular error reoccur again yet. So not sure what conclusion to draw from that at the moment.

@EricDahlvang I've just had the error again ... when I switched a facebook messenger thread to Done in a handover scenario ... here is the stack trace:
Application Insights Telemetry: {"name":"Microsoft.ApplicationInsights.Dev.abe08c1a6b4142cba7502af181bf5667.Exception","time":"2019-03-20T15:57:35.4001970Z","iKey":"abe08c1a-6b41-42cb-a750-2af181bf5667","tags":{"ai.application.ver":"1.0.0.0","ai.cloud.roleInstance":"LapJam","ai.operation.id":"e75d420a7ea5a44eb53db8e28e851207","ai.operation.parentId":"|e75d420a7ea5a44eb53db8e28e851207.8a8ab86_8a8ab87_5.7f6ec90b_","ai.operation.name":"POST ","ai.location.ip":"40.121.92.251","ai.internal.sdkVersion":"dotnet:2.9.1-26108","ai.internal.nodeName":"LAPJAM"},"data":{"baseType":"ExceptionData","baseData":{"ver":2,"exceptions":[{"id":29939153,"outerId":0,"typeName":"System.ArgumentNullException","message":"Value cannot be null.\r\nParameter name: invalid activity-missing Conversation.Id","hasFullStack":true,"parsedStack":[{"level":0,"method":"Microsoft.Bot.Builder.ConversationState.GetStorageKey","assembly":"Microsoft.Bot.Builder, Version=4.3.2.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35","fileName":"D:\a\1\s\libraries\Microsoft.Bot.Builder\ConversationState.cs","line":30},{"level":1,"method":"Microsoft.Bot.Builder.BotState+d__4.MoveNext","assembly":"Microsoft.Bot.Builder, Version=4.3.2.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35","fileName":"D:\a\1\s\libraries\Microsoft.Bot.Builder\BotState.cs","line":64},{"level":2,"method":"System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw","assembly":"System.Private.CoreLib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e","line":0},{"level":3,"method":"System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification","assembly":"System.Private.CoreLib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e","line":0},{"level":4,"method":"Microsoft.Bot.Builder.BotState+BotStatePropertyAccessor1+<GetAsync>d__7.MoveNext","assembly":"Microsoft.Bot.Builder, Version=4.3.2.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35","fileName":"D:\\a\\1\\s\\libraries\\Microsoft.Bot.Builder\\BotState.cs","line":305},{"level":5,"method":"System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw","assembly":"System.Private.CoreLib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e","line":0},{"level":6,"method":"System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification","assembly":"System.Private.CoreLib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e","line":0},{"level":7,"method":"Microsoft.Bot.Builder.Dialogs.DialogSet+<CreateContextAsync>d__9.MoveNext","assembly":"Microsoft.Bot.Builder.Dialogs, Version=4.3.2.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35","fileName":"D:\\a\\1\\s\\libraries\\Microsoft.Bot.Builder.Dialogs\\DialogSet.cs","line":92},{"level":8,"method":"System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw","assembly":"System.Private.CoreLib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e","line":0},{"level":9,"method":"System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification","assembly":"System.Private.CoreLib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e","line":0},{"level":10,"method":"System.Runtime.CompilerServices.TaskAwaiter1.GetResult","assembly":"System.Private.CoreLib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e","line":0},{"level":11,"method":"AutoAgent.Bots.AutoAgentBot+d__9.MoveNext","assembly":"AutoAgent, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null","fileName":"C:\Code\autoagent\bot-core\AutoAgent\AutoAgent\Bots\AutoAgentBot.cs","line":175},{"level":12,"method":"System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw","assembly":"System.Private.CoreLib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e","line":0},{"level":13,"method":"System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification","assembly":"System.Private.CoreLib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e","line":0},{"level":14,"method":"Microsoft.Bot.Builder.AutoSaveStateMiddleware+d__7.MoveNext","assembly":"Microsoft.Bot.Builder, Version=4.3.2.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35","fileName":"D:\a\1\s\libraries\Microsoft.Bot.Builder\AutoSaveStateMiddleware.cs","line":60},{"level":15,"method":"System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw","assembly":"System.Private.CoreLib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e","line":0},{"level":16,"method":"System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification","assembly":"System.Private.CoreLib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e","line":0},{"level":17,"method":"Microsoft.Bot.Builder.MiddlewareSet+d__3.MoveNext","assembly":"Microsoft.Bot.Builder, Version=4.3.2.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35","fileName":"D:\a\1\s\libraries\Microsoft.Bot.Builder\MiddlewareSet.cs","line":55},{"level":18,"method":"System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw","assembly":"System.Private.CoreLib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e","line":0},{"level":19,"method":"System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification","assembly":"System.Private.CoreLib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e","line":0},{"level":20,"method":"Microsoft.Bot.Builder.BotAdapter+d__13.MoveNext","assembly":"Microsoft.Bot.Builder, Version=4.3.2.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35","fileName":"D:\a\1\s\libraries\Microsoft.Bot.Builder\BotAdapter.cs","line":167}]}],"properties":{"AspNetCoreEnvironment":"Local-Development","DeveloperMode":"true"}}}}
AutoAgent.Bots.AutoAgentBot:Error: Exception caught : System.ArgumentNullException: Value cannot be null.
Parameter name: invalid activity-missing Conversation.Id
at Microsoft.Bot.Builder.ConversationState.GetStorageKey(ITurnContext turnContext) in D:\a\1\s\libraries\Microsoft.Bot.Builder\ConversationState.cs:line 30
at Microsoft.Bot.Builder.BotState.LoadAsync(ITurnContext turnContext, Boolean force, CancellationToken cancellationToken) in D:\a\1\s\libraries\Microsoft.Bot.Builder\BotState.cs:line 64
at Microsoft.Bot.Builder.BotState.BotStatePropertyAccessor1.GetAsync(ITurnContext turnContext, Func1 defaultValueFactory, CancellationToken cancellationToken) in D:\a\1\s\libraries\Microsoft.Bot.Builder\BotState.cs:line 305
at Microsoft.Bot.Builder.Dialogs.DialogSet.CreateContextAsync(ITurnContext turnContext, CancellationToken cancellationToken) in D:\a\1\s\libraries\Microsoft.Bot.Builder.Dialogs\DialogSet.cs:line 92
at AutoAgent.Bots.AutoAgentBot.OnTurnAsync(ITurnContext turnContext, CancellationToken cancellationToken) in C:\Code\autoagent\bot-core\AutoAgent\AutoAgent\Bots\AutoAgentBot.cs:line 175
at Microsoft.Bot.Builder.AutoSaveStateMiddleware.OnTurnAsync(ITurnContext turnContext, NextDelegate next, CancellationToken cancellationToken) in D:\a\1\s\libraries\Microsoft.Bot.Builder\AutoSaveStateMiddleware.cs:line 60
at Microsoft.Bot.Builder.MiddlewareSet.ReceiveActivityWithStatusAsync(ITurnContext turnContext, BotCallbackHandler callback, CancellationToken cancellationToken) in D:\a\1\s\libraries\Microsoft.Bot.Builder\MiddlewareSet.cs:line 55
at Microsoft.Bot.Builder.BotAdapter.RunPipelineAsync(ITurnContext turnContext, BotCallbackHandler callback, CancellationToken cancellationToken) in D:\a\1\s\libraries\Microsoft.Bot.Builder\BotAdapter.cs:line 167
Microsoft.Bot.Builder.Integration.IAdapterIntegration:Information: Sending activity.  ReplyToId: IBNkZ7wWg2d
Exception thrown: 'System.NullReferenceException' in Microsoft.Bot.Connector.dll
Exception thrown: 'System.NullReferenceException' in System.Private.CoreLib.dll
Exception thrown: 'System.NullReferenceException' in System.Private.CoreLib.dll
Exception thrown: 'System.NullReferenceException' in System.Private.CoreLib.dll
Exception thrown: 'System.NullReferenceException' in System.Private.CoreLib.dll
Exception thrown: 'System.NullReferenceException' in System.Private.CoreLib.dll
Exception thrown: 'System.NullReferenceException' in System.Private.CoreLib.dll
Exception thrown: 'System.NullReferenceException' in System.Private.CoreLib.dll
Exception thrown: 'System.NullReferenceException' in System.Private.CoreLib.dll
Exception thrown: 'System.NullReferenceException' in System.Private.CoreLib.dll
Exception thrown: 'System.NullReferenceException' in System.Private.CoreLib.dll
Exception thrown: 'System.NullReferenceException' in System.Private.CoreLib.dll
Exception thrown: 'System.NullReferenceException' in System.Private.CoreLib.dll
Exception thrown: 'System.NullReferenceException' in System.Private.CoreLib.dll
Microsoft.AspNetCore.Server.Kestrel:Error: Connection id "0HLLD9H2FQ2PN", Request id "0HLLD9H2FQ2PN:00000001": An unhandled exception was thrown by the application.
System.NullReferenceException: Object reference not set to an instance of an object.
at Microsoft.Bot.Connector.ConversationsExtensions.ReplyToActivityAsync(IConversations operations, Activity activity, CancellationToken cancellationToken) in D:\a\1\s\libraries\Microsoft.Bot.Connector\ConversationsEx.cs:line 138
at Microsoft.Bot.Builder.BotFrameworkAdapter.SendActivitiesAsync(ITurnContext turnContext, Activity[] activities, CancellationToken cancellationToken) in D:\a\1\s\libraries\Microsoft.Bot.Builder\BotFrameworkAdapter.cs:line 315
at Microsoft.Bot.Builder.TurnContext.<>c__DisplayClass22_0.<g__SendActivitiesThroughAdapter|1>d.MoveNext() in D:\a\1\s\libraries\Microsoft.Bot.Builder\TurnContext.cs:line 267
--- End of stack trace from previous location where exception was thrown ---
at Microsoft.Bot.Builder.TurnContext.SendActivityAsync(IActivity activity, CancellationToken cancellationToken) in D:\a\1\s\libraries\Microsoft.Bot.Builder\TurnContext.cs:line 196
at Microsoft.Bot.Builder.TurnContext.SendActivityAsync(String textReplyToSend, String speak, String inputHint, CancellationToken cancellationToken) in D:\a\1\s\libraries\Microsoft.Bot.Builder\TurnContext.cs:line 179
at AutoAgent.Startup.<>c__DisplayClass11_1.<b__5>d.MoveNext() in C:\Code\autoagent\bot-core\AutoAgent\AutoAgent\Startup.cs:line 112
--- End of stack trace from previous location where exception was thrown ---
at Microsoft.Bot.Builder.BotAdapter.RunPipelineAsync(ITurnContext turnContext, BotCallbackHandler callback, CancellationToken cancellationToken) in D:\a\1\s\libraries\Microsoft.Bot.Builder\BotAdapter.cs:line 177
at Microsoft.Bot.Builder.BotFrameworkAdapter.ProcessActivityAsync(ClaimsIdentity identity, Activity activity, BotCallbackHandler callback, CancellationToken cancellationToken) in D:\a\1\s\libraries\Microsoft.Bot.Builder\BotFrameworkAdapter.cs:line 233
at Microsoft.Bot.Builder.BotFrameworkAdapter.ProcessActivityAsync(String authHeader, Activity activity, BotCallbackHandler callback, CancellationToken cancellationToken) in D:\a\1\s\libraries\Microsoft.Bot.Builder\BotFrameworkAdapter.cs:line 204
at Microsoft.Bot.Builder.Integration.AspNet.Core.Handlers.BotMessageHandler.ProcessMessageRequestAsync(HttpRequest request, IAdapterIntegration adapter, BotCallbackHandler botCallbackHandler, CancellationToken cancellationToken) in D:\a\1\s\libraries\integration\Microsoft.Bot.Builder.Integration.AspNet.Core\BotMessageHandler.cs:line 39
at Microsoft.Bot.Builder.Integration.AspNet.Core.Handlers.BotMessageHandlerBase.HandleAsync(HttpContext httpContext) in D:\a\1\s\libraries\integration\Microsoft.Bot.Builder.Integration.AspNet.Core\BotMessageHandlerBase.cs:line 60
at Microsoft.AspNetCore.Builder.Extensions.MapMiddleware.Invoke(HttpContext context)
at Microsoft.AspNetCore.StaticFiles.StaticFileMiddleware.Invoke(HttpContext context)
at Microsoft.AspNetCore.Server.IISIntegration.IISMiddleware.Invoke(HttpContext httpContext)
at Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Http.HttpProtocol.ProcessRequests[TContext](IHttpApplication`1 application)

I apologize for the delayed response.  I'm investigating this more thoroughly.   Can you log the ChannelData of the incoming message when this occurs?

@jamsoft I think the issue here is that the handover protocol 'event' activities do not contain a conversation.id or from.id, since they are notification events from the service to the bots.
One possible way to work around this is to eliminate the BotMessageHandler, and go with a Controller approach similar to: https://github.com/Microsoft/BotBuilder-Samples/blob/samples-work-in-progress/samples/csharp_dotnetcore/13.core-bot/Controllers/BotController.cs  This is the standard we are moving our sample towards.
If you are available to work more directly with me on these Messenger Handover protocol issues, please email me at the address on my profile.

We've determined two issues exist within the Bot Framework Facebook Connector service:

standby events were not being sent to bots tied to secondary apps

during the handover process, when control is passed, the connector service is sending conversationUpdate event that contains no conversation.id

These issues have been addressed, and the fix is in the pipeline for release.
Thank you for reporting this issue.

authors: EricDahlvang jamsoft

repo: Microsoft/botbuilder-dotnet


text:
ConfirmPrompt not uses Culture parameter

I am using ConfirmPrompt in my development, and I was passing to it the value of Culture.Spanish in the constructor, but it was not working. I am looking at the source code and I noticed this:
// private IModel _model;
private Regex yes = new Regex(@"(\byes\b|\byep\b|\bok\b|\byessir\b|\bconfirm\b|^y$)", RegexOptions.IgnoreCase);
private Regex no = new Regex(@"(\bno\b|\bnope\b|\bnosir\b|\bcancel\b|^n$)", RegexOptions.IgnoreCase);

public ConfirmPrompt(string culture, PromptValidator<ConfirmResult> validator = null)
   : base(validator)
{

}

As you can see, the culture parameter is not being used at all, so it is the cause it does not work.
Do you know if this is fixed in another branch or release?
If not, I have done a PR (#560) with this fixed, as I think using ChoiceRecognizer (similar to what is used in NumberPrompt) will be simpler and clearer.
Thanks in advance.

i have similar problem , to be precise it´s with the localization of the Prompt Confirm.

If you want to get it working until this is fixed in the repo and in the Nuget, you can copy the classes I modified in the PR, add these classes into your project, and use the modified ConfirmPrompt class instead of the class in the dll.

@johnataylor, who wrote these C# prompts, is out until next week. Can this wait until then? Ideally he would review/incorporate, just because I'm not sure I have enough context.
Note: This change will need to be done in the Javascript SDK as well to keep them in sync, and then the docs have to be updated as well. :)

Yes, It can wait, because I fixed it for my project (a workaround).
If I have to apply these changes to the Javascript SDK as well, I would to look at these more thoroughly, because I am not so familiar with it.
Regarding the documentation, I think it is not necessary to change anything, because the change is only internal, and external behaviour is not changed, but maybe I am wrong.

we have merged in the PR here

source: gharchive/issue

authors: Arincon cleemullins gopal300 johnataylor

license: MIT

license_type: permissive

license_source: github-api


text:
deltaDecorations loss when editor executeEdits

Monaco:0.8.3
Browser:chrome
OS: mac
Hi
there are some deltaDecorations among those modified lines,here is my code:
 editor.executeEdits('danding', [
     { identifier: 'modify' , range: new monaco.Range(
                         component2.loc.start.line, component2.loc.start.column+1,
                         component2.loc.end.line, component2.loc.end.column+1),
                         text:line1, forceMoveMarkers: false }
      ]);

However,deltaDecorations get into a mess,how can i fix this.
Thanks for your time.

I'm not sure what you mean that deltaDecorations gets into a mess.
Any decorations that you create will be "live tracked". i.e. they will flow with the text. So, for example if you create a decoration on line 10, and then the user (or you, programatically, via executeEdits) modify the buffer, to e.g. insert a new line on line 2, then the decorations will move to line 11.

@akosyakov does not work.
steps to reproduce:

goto https://microsoft.github.io/monaco-editor/playground.html#interacting-with-the-editor-rendering-glyphs-in-the-margin
replace decorations with your example
click run
delete "if (age) {" (do not just overwrite it)
type something new
press return

expected result: breakpoint does not move
actual result: breakpoint moves :(
visual studio code does not show this behavior.
any ideas?

The good news is that vscode is open source and the sources can be used as reference. Here are the options used by breakpoints in VS Code: https://github.com/Microsoft/vscode/blob/93028e44ea7752bd53e2471051acbe6362e157e9/src/vs/workbench/parts/debug/browser/debugEditorModelManager.ts#L280

authors: alexandrudima dandingol03 neoncom

repo: Microsoft/monaco-editor


text:
Using $(SolutionDir) causes problems with msbuild

My project attempts to import a .targets file from a directory higher than the solution directory.  The import looks like so: <Import Project="$(SolutionDir)..\foo\bar.targets" />
This results in a build-time error when using msbuild to restore nuget packages via command line:
C:\SolutionDirRepro\SolutionDirRepro.csproj(139,3): error MSB4019: The imported project "C:\SolutionDirRepro*Undefined*..\foo\test.targets" was not found. Confirm that the path in the  declaration is correct, and that the file exists on disk.
If I move the .targets file to the directory the solution resides in, this problem goes away.

Closed as duplicate of https://github.com/Microsoft/msbuild/issues/2743

authors: cdmihai datalurkur

repo: Microsoft/msbuild

license: mit

license_source: bigquery


text:
Make SQLServerException constructors public

re-create PR #247

Codecov Report

Merging #334 into dev will increase coverage by 0.05%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                dev     #334      +/-   ##
============================================
+ Coverage     37.22%   37.27%   +0.05%
- Complexity     1662     1670       +8
============================================
  Files           103      103
  Lines         23673    23673
  Branches       3882     3882
============================================
+ Hits           8812     8825      +13
+ Misses        13267    13258       -9
+ Partials       1594     1590       -4

Flag
Coverage Δ
Complexity Δ

#JDBC41
37.06% <ø> (+0.05%)
1660 <ø> (+8)
:arrow_up:

#JDBC42
37.17% <ø> (+0.01%)
1664 <ø> (+4)
:arrow_up:

Impacted Files
Coverage Δ
Complexity Δ

...m/microsoft/sqlserver/jdbc/SQLServerException.java
77.23% <ø> (+1.62%)
29 <0> (+1)
:arrow_up:

...om/microsoft/sqlserver/jdbc/SimpleInputStream.java
47.79% <0%> (-1.48%)
9% <0%> (-1%)

...c/main/java/com/microsoft/sqlserver/jdbc/Util.java
45.15% <0%> (-0.71%)
60% <0%> (-1%)

...in/java/com/microsoft/sqlserver/jdbc/IOBuffer.java
46.04% <0%> (-0.24%)
0% <0%> (ø)

...om/microsoft/sqlserver/jdbc/SQLServerBulkCopy.java
48.97% <0%> (-0.15%)
210% <0%> (-1%)

...oft/sqlserver/jdbc/SQLServerPreparedStatement.java
33.62% <0%> (+0.17%)
90% <0%> (+1%)
:arrow_up:

...rc/main/java/com/microsoft/sqlserver/jdbc/dtv.java
37.03% <0%> (+0.27%)
0% <0%> (ø)
:arrow_down:

...m/microsoft/sqlserver/jdbc/SQLServerResultSet.java
27.61% <0%> (+0.37%)
189% <0%> (+2%)
:arrow_up:

...rc/main/java/com/microsoft/sqlserver/jdbc/DDC.java
30.13% <0%> (+1.11%)
57% <0%> (+3%)
:arrow_up:

... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92a9dfa...1ca5a0b. Read the comment docs.

source: gharchive/pull-request

authors: codecov-io v-xiangs

repo: Microsoft/mssql-jdbc


text:
Increase CI testing stages timeouts

Recently, I noticed few jobs getting aborted by Jenkins due to the
timeout getting exceeded.
I have bumped the values for the timeouts just to be safe for the
workload nowadays.
These are some Jenkins jobs runs that failed on the first run
(due to the small timeout), but succeed on the second run:

OpenEnclave-sandbox#777
Bors-staging#642
Bors-trying#732
Bors-trying#736
Bors-trying#738
Bors-trying#739

Hm, I am curious why they got so slow. 15 minutes was well more than enough when we set it.

@andschwa We talked about this in the morning sync together, documented with our plan in the meeting notes in the Wiki! As for the check-ci failure, we have no idea why it is slow sometimes! There's not enough output from it to know from these logs.  But there's a problem with the ecall_ocall test that sometimes causes it to deadlock. There's going to be a separate issue created for that problem. However, overall, sometimes our CI systems can really slow down, and we're not sure why, although they will eventually finish, so we're going to extend the timeout for these reasons.

bors r+

Thanks for the explanation @johnkord!

authors: andschwa ionutbalutoiu johnkord

repo: Microsoft/openenclave


text:
The button is selected by two rectangles on IE

Repro Steps:
• Navigate to https://makecode.microbit.org/beta
• Click "More" -> "High Contrast On" and then click "Projects" on the top-left
• Switch form "My Stuff" to "Projects" and "Examples" and Observe
Expected result:(Chrome, Edge & Firefox )
The button should be selected by one green rectangle

Actual result:(IE)
The button is selected by two rectangles on IE

Won't fix.

repo: Microsoft/pxt


text:
Proposal: Add configurations for schema loading

Totally out of self-interest from my experience, but might make it easier to adopt thrifty's schema: some configuration for controlling how strict the parser is.
Some ideas:

duplicate field IDs
using keywords as names

yeah I'd love to take a look. That was the part I actually wasn't sure about, the duplicate field IDs would be reasonably easy to flag
and totally understandable :)

I've pushed the branch to my personal fork: https://github.com/benjamin-bader/thrifty/tree/syntax/escaped-literals
It implements an "escaped identifier" syntax for enum members where surrounding an identifier with square brackets circumvents checking for reserved keywords, e.g.
enum Foo {
  [struct] = 1,
  BAR = 2
}

The main point is that the antlr definition gets a new ESCAPED_IDENTIFIER token, because (due to the lexing algorithm) literals that appear in parse rules (e.g. struct) are so-called "implicit" tokens, and aren't matched by catch-alls like IDENTIFIER which are defined later on in the file.  Using an escaping syntax like this sidesteps the issue, because [struct] never appears in the grammar.
If you wanted to allow non-escaped keywords, we'd need to pull literals into explicit tokens, like STRUCT : 'struct';, use those everywhere in the grammar, and then make identifier into a parse rule ident : STRUCT | ENUM | ... | IDENTIFIER.  It would be a lot of work, but doable.
Not sure how much of that makes sense; if it doesn't, let me know!

@hzsweers Do you still have use-cases for any of these?  I'll close this if not.

I think it's safe to close for now, being strict is probably a better thing to do

authors: benjamin-bader hzsweers

repo: Microsoft/thrifty


text:
Update not working.

Both GSL and folly have changed there structures , folly now has detail directory and thus changes in namespaces. Whereas GSL has changed many files including gsl folder. But still there is no updates for both when I try vcpkg update , I am very sorry but it is very bad for me if nothing is done here.
Please help me.

@jack17529 I was confused at first but now I understand what you are alluding to. vcpkg does not update when code in some repository changes. Someone has to manually update the portfile to the latest versions. In this case no one has volunteered just yet. If you want the latest version you could change the version in your portfile and see if it works. If it works you might consider a PR. I am sure @ras0219-msft would be glad to review it.

We need in upstream monitoring. Something like:

Anitya: https://github.com/release-monitoring/anitya
Repology: https://repology.org
Debian watch: https://wiki.debian.org/debian/watch

Hi @jack17529, thank you for posting this issue! GSL and folly have been upgraded to latest version, you can update vcpkg and rebuild them.

repo: Microsoft/vcpkg


text:
mongoc-driver 's lib and dll name not uniform

one is mongoc-1.0.lib and another one is libmongoc-1.0.dll

Thanks for posting this issue!
This behavior is by design for the upstream library (mongoc). If this causes specific issues for you, please let us know and we can reopen this issue!


text:
Valid pattern match fails to compile

The following pattern matching expression fails. I am not sure if this is a valid error.
Repro steps
type Token =
  | T_Exclamation
  | T_Question
  | T_String of string
  | T_Lparen
  | T_Rparen
  | T_Eof
  | T_Empty

let compare (x:Token) (y:Token) =
  match x, y with
  | N_Session, N_Session -> 0
  | _,_ -> 1

Error
error FS0038: 'N_Session' is bound twice in this pattern
Related information

Windows 10
.NET Runtime,
Visual Studio Version 2017, 15.3.2

You don't have the case N_session so it's treated as variable and you can't use the same car name in one pattern more then one

@AviAvni .. Indeed. you are correct. I will close this issue.

authors: AviAvni bikalgurung

repo: Microsoft/visualfsharp


text:
[WIP] Add "Do not show this message again" to type provider security dialog

fix #378
added the checkbox to type provider dialog

The preference is stored using a file %APPLOCALDATA%\Local\Microsoft\VisualStudio\12.0\always-trust-type-providers.lock (like the type providers list type-providers.txt, same directory)
Cannot reenable it after (like T4), but this behaviour can be documented, delete a file is easy. Should i add this check to Tools menu?
i splitted the 233514b to make the diff easier
TODO

[ ] localization with resorce (today or tomorrow)
[ ] integration tests (??)
[x] add to Tools menu?
[ ] add tests below to developer wiki, something like "Checklist for UI changes"

Tests

[X] manual tests :smile:
[ ] localization
[ ] 200% high DPI
[ ] Check box can be selected/toggled via keyboard
[ ] Windows narrator can read the label text

i need review :eyes: :eyes: :eyes: :eyes:

Nice work. But I feel this should probably be a regular setting here:

That way, you get

serialization/deserialization for free
a way to back out of the decision to trust TPs
VS settings roaming

The checkbox would still be there, but it would modify that setting instead.

Thx @rojepp i'll add a checkbox there too.
About serialization, i have implemented it like the enabled/disabled type provider list.
Maybe there is a reason about that, i'll wait @KevinRansom or @latkin feedback.
But the vs settings roaming is nice to have, i'll do it if possibile

Thx @rojepp i'll add a checkbox there too.
About serialization, i have implemented it like the enabled/disabled type provider list.
Maybe there is a reason about that, i'll wait @KevinRansom or @latkin feedback.
But the vs settings roaming is nice to have, i'll do it if possibile for sure

added checkbox in tools menu

As long as @latkin and @KevinRansom we can speculate:
You're probably right in following the way that its done for the accepted TP list, because it can be used outside of VS. Is it being used outside of VS? IDK. I haven't ever seen a TP warning when building from Fake/msbuild, so I'm guessing its not used outside of VS.
For reference, Xamarin Studio doesn't care. There was an issue to add support for allowed TPs but this is OSS and no-one really wants the feature, so it doesn't get built. :)

Awesome with the checkbox in Tools / Options! Could you get some margin in there, just to make it look nicer? IMHO, it is too close to the list

localized texts. I dont like "Always trust ..", a better description?
a bit of margin:

Margin is much better, thank you.
To me that phrase is fine, but natives should be the judge of that. :)

tested narrator and 200% dpi

closing, the security check will be removed, ref #378

authors: enricosada rojepp


text:
Hosts we have keychain tokens for are always GitHub hosts

For this is the only law that makes sense.
Fixes #576

The sense, it makes! :rocket:

authors: queerviolet shana

repo: Microsoft/vscode-pull-request-github


text:
Error: Path must be a string. Received undefined

VSCode Version: Code 1.6.0 (e52fb0bc87e6f5c8f144e172639891d8d8c9aa55, 2016-10-10T18:28:55.412Z)
OS Version: Darwin x64 15.6.0
Extensions: chenxsan.vscode-standard-format-0.0.12, naumovs.color-highlight-1.2.1, shardulm94.trailing-spaces-0.2.11, shinnn.standard-0.1.5, xabikos.JavaScriptSnippets-1.2.0

Steps to Reproduce:

Update to newestes VSCode Version
Just code in a simple js-file. With every character I type the error message "Error Path must be a string. Received undefined" is displayed again.

@michaelchiche  I can not reproduce this. Do you also see this if you run with --disable-extensions?

@isidorn wrong mention i think ;)

Oops
@michikuehne I meant :)

@isidorn You supposed the right. If I run vsc without --disable-extensions the error message doesn't occur.
So one of the extension I use must be responsible for this error. Thanks for the hint

@michikuehne what I suggest is to uninstall extensions one by one and try to figure out which one it is. Once you got that just file this issue to the github repository of that extension.
Closing this as there is nothing to be done on the vscode side

Hi! I had the same problem, i have tried each one of my extensions and found out that in my case its vscode-standard 0.1.5 thats causing the problems. It actually says on their extensions page that their dev dependencies are out of date. i think https://github.com/shinnn is the authour.

@rasmuslundberg You're right! The same plugin caused the error message on my vscode.

What the easiest way to contact shinnn? is there a formal way to ask for a update on  a vscode extension or should we just post an issue on the repos? Sorry for my newb questions.

@rasmuslundberg Right, just open I github issue on his repo.

@michikuehne its already there https://github.com/shinnn/vscode-standard/issues/7

FWIW, The ESLint extension causes this error for me.

FYI I received this error because my global install of eslint was out of date

authors: isidorn jhaddow mehas michaelchiche michikuehne rasmuslundberg

repo: Microsoft/vscode


text:
Zen Coding Command Outputting Extra Closing Tag

VSCode Version: 1.8.1
OS Version: Windows Home Premium 64GB

Steps to Reproduce:

create a new .html file
enter the following valid zen code command: div>p

actual output:

expected output:

The problem is caused by one of the installed extensions. IMO, maybe, it's Auto Close Tag or other.

The problem is caused by one of the installed extensions. IMO, maybe, it's Auto Close Tag or other.

Thanks, this makes sense. Disabling Auto Close Tag resolves this.

Thanks, this makes sense. Disabling Auto Close Tag resolves this.

authors: ImranAhmed mrmlnc


text:
Node related configuration snippets showing up in non Node environment

Testing #19039

I have the Go extension installed and Go workspace opened with no launch.json file.
There is a Go file opened in the active editor.
I click on the "Add Configuration" option in the debug drop down and there is a pop up asking me to choose the environment.
I choose Go
The default launch.json is created by the Go extension.
The snippets for adding new configuration have nothing to do with Go. Why are they even showing up?

In case you don't have Go and the Go extension installed, follow the below steps:

Install Go
Setup GOPATH
1. Choose a folder where you will be having the Go projects
2. Add env variable GOPATH with value as the above folder path
3. Create 3 folders "src", "bin" and "pkg"
Run go get github.com/golang/example/hello
Install the Go extension by lukehoban and open the folder $GOPATH/src/GitHub.com/golang/example/hello in VS Code
Open the hello.go file. You will see "Analysis Tools Missing" in the status bar. Click on it to install the Go tools that the extension needs.

@ramya-rao-a a launch.json is not connected to a specific debugger. It can contain launch configurations for any type of debugger, e.g. one of type go for a backend, and another of type chrome for client code running in a browser. To help with building heterogenous launch.json files VS Code shows all launch config snippets.
/cc @isidorn

Created https://github.com/Microsoft/vscode-go/issues/744

authors: isidorn ramya-rao-a weinand


text:
TypeError: Cannot read property 'element' of undefined

open ts file
trigger IntelliSense
select an item with the mouse
type space, trigger IntelliSense again
select an item with the mouse
💥 the list widget explodes

index.js:31 [uncaught exception]: TypeError: Cannot read property 'element' of undefinedonError @ index.js:31(anonymous function) @ index.js:100emitOne @ events.js:96emit @ events.js:188window.onerror @ init.js:120
index.js:34 TypeError: Cannot read property 'element' of undefined
    at ListView.element (file:////Users/jrieken/Code/vscode/out/vs/base/browser/ui/list/listView.js:96:37)
    at file:////Users/jrieken/Code/vscode/out/vs/base/browser/ui/list/listWidget.js:366:91
    at Array.forEach (native)
    at file:////Users/jrieken/Code/vscode/out/vs/base/browser/ui/list/listWidget.js:366:25
    at EventBufferer.bufferEvents (file:////Users/jrieken/Code/vscode/out/vs/base/common/event.js:338:13)
    at List.setFocus (file:////Users/jrieken/Code/vscode/out/vs/base/browser/ui/list/listWidget.js:364:32)
    at MouseController.onPointer (file:////Users/jrieken/Code/vscode/out/vs/base/browser/ui/list/listWidget.js:198:23)
    at file:////Users/jrieken/Code/vscode/out/vs/base/browser/ui/list/listWidget.js:187:89
    at ListView.fireScopedEvent (file:////Users/jrieken/Code/vscode/out/vs/base/browser/ui/list/listView.js:187:13)
    at HTMLDivElement.handler (file:////Users/jrieken/Code/vscode/out/vs/base/browser/ui/list/listView.js:174:55)

Let me know if this is suggest using the list widget wrong.

Oh, and after that the suggest widget is totally broken. Keep throwing the same error until reload

Needs these settings:
	"files.autoSave": "onFocusChange",
	"files.trimTrailingWhitespace": true

Reverted.

@bpasero The root cause for this is that "files.autoSave": "onFocusChange" saves to early, namely when the cursor loses focus, not when the editor loses focus. That also repos with other things like Cmd+F. In this particular issue the cursor loses focus when an element is clicked, triggers trim tailing whitespace, cancelling suggest. Now the exploding list widget just covers the real mess which is that you cannot insert a suggestion via click in the presence of certain settings. So unless I miss something instead of onDidBlurEditorText the onDidBlurEditor-event should be used.

An event emitted when the text inside this editor or an editor widget lost focus.

Reading the API doc actually not sure anymore. @alexandrudima does above mean there is no editor blur event which is basically 'this editor orand an editor widget lost'

@jrieken @alexandrudima I once had used onDidBlurEditorText and onDidBlurEditor for auto save and got bugs that under some situations auto save was not triggered (including yourself). So I reverted that back to my solution because I did not want and do not plan to break auto save like that. I am not sure why the event seems to sometimes not fire...

@bpasero This is the first I hear about the blur event not firing. That would mean the cursor would still be blinking... even though focus is somewhere else. If you have a repro please let me know.

Unsure how #17729 is related to that but I think if there is an issue blur not being fire that should be fixed. Today, the behaviour is pretty bad because all those save participants (format, trim whitespace, apply quick fix) kick in as soon as the cursor blurs, e.g when searching inside the editor

Yeah I agree. I can either bring back to use the editor events (which I like provided the work reliably) or add a timeout to my blur listener to avoid running save during the event bubbling phase.

The timeout won't work for things like Search, F8 error navigation or any other peek view. We should go back to the before event and understand why it doesn't work at times

Fixed via https://github.com/Microsoft/vscode/issues/21273

authors: alexandrudima bpasero joaomoreno jrieken


text:
FeatureRequest: Using the immediate window without building

VSCode Version: 14.0.24720.00 Update 1
OS Version: Windows 10

I want to run simple commands in the immediate window without building the solution.  For example I might want to type something like "Double.Parse("0.1")"; but currently I will get the error "Build Failed. For a list of build errors see the Error List. For detailed information about a build error select an item and press F1.".

@StratThinker pls provide information that allows us to reproduce your problem. What extensions do you have installed? What file is open? etc. Thanks!

I have EditorConfig, "End of the Line", various F# packages installed.  Every thing else looks like the default packages.  Although these are probably not the problem.
To reproduce the problem:

create a new console application.
Inside the Main method write some text that will not compile, for example "asdf"
Open up the immediate window
Type something simple like ""+0.1
Press enter
Instead of doing this calculation, it will try to build my solution, which will fail, and it will give the error "Build Failed. For a list of build errors see the Error List. For detailed information about a build error select an item and press F1."

Note I fairly certain that this is the expected behaviour.  My feature request is to be able use the Immediate window like a command line application without building the solution, to test some simple calculations (for anything more complex I use a test solution).  Note that I am requesting something similar to Matlab's command line.

Sorry I see that I confused "visual studio" with "visual studio code".

authors: StratThinker kieferrm


text:
Add offset-len version of range in TextDocumentContentChangeEvent

Working with Position objects is not ideal when trying to incrementally sync documents. Additionally it is impossible to compare them with each other without an unnecessary performance hit. If you want to delay and merge events to keep the number of edits down in large documents, this becomes a basic requirement.
Consider the following TextDocumentContentChangeEvent objects:
let first = {
  text: '\r\n',
  rangeLength: 0,
  range: {
    start: { line: 1, character: 0 }
    end: { line: 1, character: 0 }
  }
}
let second = {
  text: 'a',
  rangeLength: 0,
  range: {
    start: { line: 2, character: 0 }
    end: { line: 2, character: 0 }
  }
}

In this text document:
b
cd

Individually, they are both accurate, but since the start/end ranges have changed, the language server cannot determine the precise location of the second event without either applying the first event or parsing it to count the number of line breaks and the new character offset. Things only get worse if the changes overlap, since you would need to keep track of every newline.
All of this can be avoided if instead of the relative range location, an absolute location such as the offset into the document is provided.

To clarify - it is possible to maintain synchronized text from these events. See https://github.com/Microsoft/vscode/blob/master/src/vs/editor/common/model/mirrorModel2.ts#L39 for an example
Your desire is for us to send the range also in an offset-len format besides the start-end pos format?

That's right. It just makes some tasks a bit easier.

Moved to discussion at Microsoft/language-server-protocol#96.

authors: alexandrudima mattacosta


text:
Shortcut for Format Document(Ctrl+Shift+I) not Functioning

VSCode Version: 1.13.1
OS Version: LMDE2 - Linux Mint Debian Edition (Debian 8 based)

Steps to Reproduce:

Open one document and execute the shortcut: Ctrl+Shift+I.
The result is open search box and not format document.

@Hygens Did you set the Ctrl+Shift+I keybinding yourself?

No. I do not have executed any customizations here for keybinding. I have followed the default documentations for linux shortcut here.

That should have worked...
https://github.com/Microsoft/vscode/blob/b34f17350f2d20dbbbfdb26df91dd50bb9160900/src/vs/editor/contrib/format/browser/formatActions.ts#L304
cc @jrieken for formatting

I'm sorry but here not working. I have downloaded today the version 1.13.1 and my linux is clean installed today and I do not have executed any customizations for keystrokes here and not working.
If I select the code on document and use Ctrl+K+F ok functioning, but, if possible not need select the document and get document formatted it's better.
More some informations are:

I'm using Cinnamon desktop;
My kernel is: 3.16.0-4-amd64 #1 SMP Debian 3.16.43-2 (2017-04-30) x86_64 GNU/Linux

Exists more some information needed for that or workaround for solve that?!

Did this shortcut work before you updated to 1.3.1?

Yes. With VSCode 1.3 was ok. But I have installed one clean environment with LMDE2(Debian Jessie based) and after that installed tha last version of VSCode 1.13.1. After that not working. I'm new with VSCode because I'm commonly use Vim or Spacemacs. I'm testing that editor because it's better with for example Atom for me and more easy for configurations and use. About that problem I will be analysing here what is the problem because need two keystrokes for format source(Ctrl+A/Ctrl+K+F) not productive that. I have attempted beautify plugins but most of them give problems in vscode and for that I'm using default configuratios because is enough for me.

@Hygens
What does VS Code detect when you press the desired key combination? Please hover over the input box and take a screenshot:

Here is screenshot for keystroke preference:

@Hygens

Please hover over the input box and take a screenshot:

If you tools doesn't support screen shooting a hover use a gif recorder. The hover contains the necessary information

Ok, follow below screenshot with hover input box:

Ok, thanks at lot for that. So it does seem that the physical buttons on your keyboard map to what we have registered for. There two possibilities why this isn't working.

You have no formatter for that language? Check by right-clicking in the file and check the context menu as a Format-entry
Some extension has stolen your keybinding. The screenshot above looks fishing because ctrl+shift+i seems to unconditionally bound to some extension command. Try to disable that.

Ok. The questions really is the other keystrokes present for possible extensions using the same keystroke and I have erased all others keystroke for extensions and solved question.
Thank you very much.
You can mark that issue solved or close the same.

authors: Hygens jrieken ramya-rao-a


text:
editor.mouseWheelScrollSensitivity has no effect

VSCode Version: Code 1.13.1 (379d2efb5539b09112c793d3d9a413017d736f89, 2017-06-14T18:18:03.540Z)
OS Version: Linux x64 4.11.0+
Extensions:

Extension
Author
Version

Bookmarks
alefragnani
0.15.2

vscode-rust
kalitaalexey
0.3.14

Steps to Reproduce:

Change editor.mouseWheelScrollSensitivity to something extreme, like 20
Restart vscode (just to make sure the setting is applied)
Turn the scroll wheel

Expected behavior:
It should scroll by much more than it used to.
Actual behavior:
Scrolling didn't change compared to the default settings.

Can confirm it also does the same in Windows 10 Pro x64, VSCode release 1.13.1

Duplicate of #28412

authors: RalfJung alexandrudima cyrilmesvayn


text:
Eclipse style file syntax check status highlighting in the file menu bar

For angular2 projects which contain numerous typescript files, a module/class/function name mismatch in one file causes problems in the dependent files (often during code refactoring).
As of now, VScode highlights the error in the dependent file with a red underline on the imported variable name. Instead of manually going through all the dependent files, it would be nice if VSC can highlight the files which have problems ( like broken file icon in file list menu in eclipse ).
VScode version : 1.13.1

Asks from this feature request is present in VScode Version 1.20.1. Hence closing this issue.


text:
Test Tour: ReactNative getting started (JavaScript)

You have heard about ReactNative and you want to learn about it using Code.

find and follow a ReactNative tutorial https://facebook.github.io/react-native/docs/getting-started.html
install the ReactNative extension
setup validation using ESLint
use Emmet

To get Intellisense when using the ES6 import as is done in index.ios.js:
import React, { AppRegistry } from 'react-native';

with the react-native and react-global typings, then you must add the following setting to the jsconfig.json:
 {
    "compilerOptions": {
        "allowSyntheticDefaultImports": true
    }
}

I've added this to the release notes and we also need to doc it.

@egamma Even after adding a jsconfig.json file with those contents, I still don't get Intellisense. Any other tips?

@joaomoreno and you have the d.ts files (tsd react-global react-native) installed?

I was missing the tsd

authors: egamma joaomoreno


text:
Ruby templating syntax highlighting problem

VSCode Version: 1.17.2
OS Version: MacOS 10.10.5

Steps to Reproduce:

Open ruby code with templating. For example, https://gist.github.com/hanxue/46cb83e532792b3ec7b83a43372d6c7f
Ruby code will not be highlighted correctly

Reproduces without extensions: Yes

We only bundle basic ruby language support. For advanced Ruby language support you can try: https://marketplace.visualstudio.com/items?itemName=rebornix.Ruby and fill issues for them.

authors: hanxue octref