text:
libvlc-3.0.16: fails to build on nixpkgs-unstable, affects KDE Plasma 5

Describe the bug
libvlc package fails to build. Breaks building elisa and subsequently Plasma 5 if services.xserver.desktopManager.plasma5 is enabled.
Steps To Reproduce
Steps to reproduce the behavior:

Checkout nixpkgs-unstable of nixpkgs
Run nix build .#libvlc
Encounter an error

Expected behavior
libvlc builds normally.
Additional context
Full build log:
https://gist.github.com/azahi/fcc77da55dae5384b2360ba49fbe93a1
Notify maintainers
@NixOS/qt-kde (Affects elisa and Plasma 5)
@AndersonTorres (Could be a libcaca issue)
Metadata
 - system: `"x86_64-linux"`
 - host os: `Linux 5.15.12, NixOS, 22.05 (Quokka)`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.5.1`
 - channels(azahi): `""`
 - nixpkgs: `/nix/store/rfv5vc72q69qb9qzp8qif35pq3a8nfbi-source`

This bisects to https://github.com/NixOS/nixpkgs/pull/153140

Upstream issue: https://code.videolan.org/videolan/vlc/-/issues/26389

Apply the not-yet-merged patch from upstream?  I have no clue about the libcaca changes, but at least the patch looks like trivial renames:
https://code.videolan.org/videolan/vlc/-/merge_requests/889/diffs?commit_id=d35391caa03c046149e7fe2497f51bf59ed8551d
To me that sounds better than reverting the update (though my information is very limited):

(side note, the beta20 libcaca update fixes several security issues).

Yes. I will do this.

authors: AndersonTorres K900 azahi r-burns vcunat


text:
mesa fails to build on aarch64-darwin

Steps To Reproduce
Steps to reproduce the behavior:

build mesa

Build log
[1077/1078] Linking static target src/glx/libglx.a
[1078/1078] Linking target src/glx/libGL.1.dylib
buildPhase completed in 33 seconds
installing
install flags: install
[1/9] Generating src/git_sha1.h with a custom command
[1/2] Installing files.
Installing src/mapi/shared-glapi/libglapi.0.dylib to /nix/store/xf9hi5h9ynjjpnrmdbijnhg153zr3fnh-mesa-22.2.2/lib
Installing src/mapi/es1api/libGLESv1_CM.1.dylib to /nix/store/xf9hi5h9ynjjpnrmdbijnhg153zr3fnh-mesa-22.2.2/lib
Installing src/mapi/es2api/libGLESv2.2.dylib to /nix/store/xf9hi5h9ynjjpnrmdbijnhg153zr3fnh-mesa-22.2.2/lib
Installing src/gallium/targets/dri/libgallium_dri.so to /nix/store/7pmab9bri6pc4y5phkmfdqlwavmc01jx-mesa-22.2.2-drivers/lib/dri
Installing src/glx/libGL.1.dylib to /nix/store/xf9hi5h9ynjjpnrmdbijnhg153zr3fnh-mesa-22.2.2/lib
Installing /private/tmp/nix-build-mesa-22.2.2.drv-0/mesa-22.2.2/include/KHR/khrplatform.h to /nix/store/1ds2sh20vns2zq2zljcgv6kycib4i0nh-mesa-22.2.2-dev/include/KHR/
Installing /private/tmp/nix-build-mesa-22.2.2.drv-0/mesa-22.2.2/include/GLES/egl.h to /nix/store/1ds2sh20vns2zq2zljcgv6kycib4i0nh-mesa-22.2.2-dev/include/GLES/
Installing /private/tmp/nix-build-mesa-22.2.2.drv-0/mesa-22.2.2/include/GLES/gl.h to /nix/store/1ds2sh20vns2zq2zljcgv6kycib4i0nh-mesa-22.2.2-dev/include/GLES/
Installing /private/tmp/nix-build-mesa-22.2.2.drv-0/mesa-22.2.2/include/GLES/glext.h to /nix/store/1ds2sh20vns2zq2zljcgv6kycib4i0nh-mesa-22.2.2-dev/include/GLES/
Installing /private/tmp/nix-build-mesa-22.2.2.drv-0/mesa-22.2.2/include/GLES/glplatform.h to /nix/store/1ds2sh20vns2zq2zljcgv6kycib4i0nh-mesa-22.2.2-dev/include/GLES/
Installing /private/tmp/nix-build-mesa-22.2.2.drv-0/mesa-22.2.2/include/GLES2/gl2.h to /nix/store/1ds2sh20vns2zq2zljcgv6kycib4i0nh-mesa-22.2.2-dev/include/GLES2/
Installing /private/tmp/nix-build-mesa-22.2.2.drv-0/mesa-22.2.2/include/GLES2/gl2ext.h to /nix/store/1ds2sh20vns2zq2zljcgv6kycib4i0nh-mesa-22.2.2-dev/include/GLES2/
Installing /private/tmp/nix-build-mesa-22.2.2.drv-0/mesa-22.2.2/include/GLES2/gl2platform.h to /nix/store/1ds2sh20vns2zq2zljcgv6kycib4i0nh-mesa-22.2.2-dev/include/GLES2/
Installing /private/tmp/nix-build-mesa-22.2.2.drv-0/mesa-22.2.2/include/GLES3/gl3.h to /nix/store/1ds2sh20vns2zq2zljcgv6kycib4i0nh-mesa-22.2.2-dev/include/GLES3/
Installing /private/tmp/nix-build-mesa-22.2.2.drv-0/mesa-22.2.2/include/GLES3/gl31.h to /nix/store/1ds2sh20vns2zq2zljcgv6kycib4i0nh-mesa-22.2.2-dev/include/GLES3/
Installing /private/tmp/nix-build-mesa-22.2.2.drv-0/mesa-22.2.2/include/GLES3/gl32.h to /nix/store/1ds2sh20vns2zq2zljcgv6kycib4i0nh-mesa-22.2.2-dev/include/GLES3/
Installing /private/tmp/nix-build-mesa-22.2.2.drv-0/mesa-22.2.2/include/GLES3/gl3ext.h to /nix/store/1ds2sh20vns2zq2zljcgv6kycib4i0nh-mesa-22.2.2-dev/include/GLES3/
Installing /private/tmp/nix-build-mesa-22.2.2.drv-0/mesa-22.2.2/include/GLES3/gl3platform.h to /nix/store/1ds2sh20vns2zq2zljcgv6kycib4i0nh-mesa-22.2.2-dev/include/GLES3/
Installing /private/tmp/nix-build-mesa-22.2.2.drv-0/mesa-22.2.2/include/GL/gl.h to /nix/store/1ds2sh20vns2zq2zljcgv6kycib4i0nh-mesa-22.2.2-dev/include/GL/
Installing /private/tmp/nix-build-mesa-22.2.2.drv-0/mesa-22.2.2/include/GL/glcorearb.h to /nix/store/1ds2sh20vns2zq2zljcgv6kycib4i0nh-mesa-22.2.2-dev/include/GL/
Installing /private/tmp/nix-build-mesa-22.2.2.drv-0/mesa-22.2.2/include/GL/glext.h to /nix/store/1ds2sh20vns2zq2zljcgv6kycib4i0nh-mesa-22.2.2-dev/include/GL/
Installing /private/tmp/nix-build-mesa-22.2.2.drv-0/mesa-22.2.2/include/GL/glx.h to /nix/store/1ds2sh20vns2zq2zljcgv6kycib4i0nh-mesa-22.2.2-dev/include/GL/
Installing /private/tmp/nix-build-mesa-22.2.2.drv-0/mesa-22.2.2/include/GL/glxext.h to /nix/store/1ds2sh20vns2zq2zljcgv6kycib4i0nh-mesa-22.2.2-dev/include/GL/
Installing /private/tmp/nix-build-mesa-22.2.2.drv-0/mesa-22.2.2/include/GL/internal/dri_interface.h to /nix/store/1ds2sh20vns2zq2zljcgv6kycib4i0nh-mesa-22.2.2-dev/include/GL/internal/
Installing /private/tmp/nix-build-mesa-22.2.2.drv-0/mesa-22.2.2/src/util/00-mesa-defaults.conf to /nix/store/xf9hi5h9ynjjpnrmdbijnhg153zr3fnh-mesa-22.2.2/share/drirc.d
Installing /private/tmp/nix-build-mesa-22.2.2.drv-0/mesa-22.2.2/build/meson-private/glesv1_cm.pc to /nix/store/xf9hi5h9ynjjpnrmdbijnhg153zr3fnh-mesa-22.2.2/lib/pkgconfig
Installing /private/tmp/nix-build-mesa-22.2.2.drv-0/mesa-22.2.2/build/meson-private/glesv2.pc to /nix/store/xf9hi5h9ynjjpnrmdbijnhg153zr3fnh-mesa-22.2.2/lib/pkgconfig
Installing /private/tmp/nix-build-mesa-22.2.2.drv-0/mesa-22.2.2/build/meson-private/dri.pc to /nix/store/xf9hi5h9ynjjpnrmdbijnhg153zr3fnh-mesa-22.2.2/lib/pkgconfig
Installing /private/tmp/nix-build-mesa-22.2.2.drv-0/mesa-22.2.2/build/meson-private/gl.pc to /nix/store/xf9hi5h9ynjjpnrmdbijnhg153zr3fnh-mesa-22.2.2/lib/pkgconfig
Installing symlink pointing to libglapi.0.dylib to /nix/store/xf9hi5h9ynjjpnrmdbijnhg153zr3fnh-mesa-22.2.2/lib/libglapi.dylib
Installing symlink pointing to libGLESv1_CM.1.dylib to /nix/store/xf9hi5h9ynjjpnrmdbijnhg153zr3fnh-mesa-22.2.2/lib/libGLESv1_CM.dylib
Installing symlink pointing to libGLESv2.2.dylib to /nix/store/xf9hi5h9ynjjpnrmdbijnhg153zr3fnh-mesa-22.2.2/lib/libGLESv2.dylib
Installing symlink pointing to libGL.1.dylib to /nix/store/xf9hi5h9ynjjpnrmdbijnhg153zr3fnh-mesa-22.2.2/lib/libGL.dylib
Running custom install script '/nix/store/14sv2h3nag638062j87lg3ic4z8ipgis-python3-3.10.8/bin/python3.10 /private/tmp/nix-build-mesa-22.2.2.drv-0/mesa-22.2.2/bin/install_megadrivers.py /private/tmp/nix-build-mesa-22.2.2.drv-0/mesa-22.2.2/build/src/gallium/targets/dri/libgallium_dri.so /nix/store/7pmab9bri6pc4y5phkmfdqlwavmc01jx-mesa-22.2.2-drivers/lib/dri swrast_dri.so'
mv: missing file operand
Try 'mv --help' for more information.

Additional context
#196310
Notify maintainers
@primeos @vcunat
Metadata
Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.
[user@system:~]$ nix-shell -p nix-info --run "nix-info -m"
 - system: `"aarch64-darwin"`
 - host os: `Darwin 22.1.0, macOS 13.0`
 - multi-user?: `yes`
 - sandbox: `no`
 - version: `nix-env (Nix) 2.11.0`
 - channels(user): `"darwin, home-manager, nixpkgs, nur-packages"`
 - channels(root): `"nixpkgs"`
 - nixpkgs: `/Users/user/.nix-defexpr/channels/nixpkgs`

Sorry about that :(
Is there a way I can test changes for aarch64-darwin without a darwin device to avoid this in future?
It looks like pkgsCross.aarch64-darwin is broken.
$ nix-build '<nixpkgs>' -A pkgsCross.aarch64-darwin.mesa
error: infinite recursion encountered

       at /nix/store/rn8y2gw3n33mawaxqw8j0zlfcd63wyv8-source/pkgs/os-specific/darwin/apple-sdk-11.0/libSystem.nix:32:12:

           31|     for dir in $includeDirs; do
           32|       from=${MacOSX-SDK}/usr/include/$dir
             |            ^
           33|       if [ -e "$from" ];

source: gharchive/issue

authors: LunNova wegank

repo: NixOS/nixpkgs

license: MIT

license_type: permissive

license_source: github-api


text:
platformio depends on <= starlette 0.21.0, but attempts to build with Nixpkgs's 0.23.0

Steps To Reproduce
Steps to reproduce the behavior:

build platformio

Build log
Executing pipInstallPhase
/build/source/dist /build/source
Processing ./platformio-6.1.5-py3-none-any.whl
Requirement already satisfied: ajsonrpc==1.* in /nix/store/9p9ws2gx11wqc5z0zvifswnx17na52mc-python3.10-ajsonrpc-1.2.0/lib/python3.10/site-packages (from platformio==6.1.5) (1.2.0)
Requirement already satisfied: marshmallow==3.* in /nix/store/61snn19046kbh7ammdjxlhsbajjr316k-python3.10-marshmallow-3.16.0/lib/python3.10/site-packages (from platformio==6.1.5) (3.16.0)
Requirement already satisfied: bottle==0.12.* in /nix/store/n6rz9z3z2ky6pzxj6s043l55yymkvzd4-python3.10-bottle-0.12.23/lib/python3.10/site-packages (from platformio==6.1.5) (0.12.23)
Requirement already satisfied: pyserial==3.5.* in /nix/store/jxzz20a7i2byxh0zqfk0vhh3cx8yafcz-python3.10-pyserial-3.5/lib/python3.10/site-packages (from platformio==6.1.5) (3.5)
Requirement already satisfied: click<9,>=8.0.4 in /nix/store/whih1qwwfq8a4zyzx2kdnpjvwdr9b83k-python3.10-click-8.1.3/lib/python3.10/site-packages (from platformio==6.1.5) (8.1.3)
Requirement already satisfied: semantic-version==2.10.* in /nix/store/c0rzd0dim0i5j4g6jpa5hjhajacy5g2m-python3.10-semantic-version-2.10.0/lib/python3.10/site-packages (from platformio==6.1.5) (2.10.0)
ERROR: Could not find a version that satisfies the requirement starlette<=0.21,>=0.19.1 (from platformio) (from versions: none)
ERROR: No matching distribution found for starlette<=0.21,>=0.19.1

error: builder for '/nix/store/gfbrpq67jyw8gfz5288rs3f12w7v0dx3-platformio-6.1.5.drv' failed with exit code 1
error: 1 dependencies of derivation '/nix/store/dqzgjy56m0kbda2zf7rqbb6v537gdxyx-platformio-usr-target.drv' failed to build
error: 1 dependencies of derivation '/nix/store/jzmwgkna6daw1czdzxfkb0hk3dp4kjg0-platformio-fhs.drv' failed to build
error: 1 dependencies of derivation '/nix/store/3n8l3q1p3bhryfbqw0651dw4rpj7n6i6-platformio-init.drv' failed to build
error: 1 dependencies of derivation '/nix/store/cjfsdl2ywkhzsg82clr6p95rim6rcd51-platformio.drv' failed to build

Additional context
The platformio develop branch supports Starlette 0.23.0.
Not much changed between 0.21.0 and 0.23.0 either. The latest version may just work with 0.23.0 if setup.py is patched.
On another note:
This issue could be worked around immediately by overriding Starlette with an older version, but it's not possible to override the platformio derivation used in the FHS  from core.nix. It'd be great if there was a way to modify the derivation used in the FHS.
Notify maintainers
@mogorman
Metadata
[user@system:~]$ nix-shell -p nix-info --run "nix-info -m"
 - system: `"x86_64-linux"`
 - host os: `Linux 5.15.86, NixOS, 23.05 (Stoat), 23.05pre443927.6dccdc45851`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.12.0`
 - channels(root): `"home-manager, nixos"`
 - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`

Here's my workaround to get it to build again:
diff --git a/pkgs/development/embedded/platformio/core.nix b/pkgs/development/embedded/platformio/core.nix
index a9b6e156b87..1d5cd60022f 100644
--- a/pkgs/development/embedded/platformio/core.nix
+++ b/pkgs/development/embedded/platformio/core.nix
@@ -42,7 +42,18 @@ with python3.pkgs; buildPythonApplication rec {
     requests
     semantic-version
     spdx-license-list-data.json
-    starlette
+    (starlette.overrideAttrs
+      (old: rec {
+        version = "0.21.0";
+        src = fetchPypi {
+          pname = "starlette";
+          inherit version;
+          hash = "sha256-sbUjBe6PfPxIzeODSW98EauJfNcRKzPZmLExfcjvkCc=";
+        };
+        postPatch = "";
+        doCheck = false;
+        doInstallCheck = false;
+      }))
     tabulate
     uvicorn
     wsproto

Here's my workaround to get it to build again:
diff --git a/pkgs/development/embedded/platformio/core.nix b/pkgs/development/embedded/platformio/core.nix
index a9b6e156b87..1d5cd60022f 100644
--- a/pkgs/development/embedded/platformio/core.nix
+++ b/pkgs/development/embedded/platformio/core.nix
@@ -42,7 +42,18 @@ with python3.pkgs; buildPythonApplication rec {
     requests
     semantic-version
     spdx-license-list-data.json
-    starlette
+    (starlette.overrideAttrs
+      (old: rec {
+        version = "0.21.0";
+        src = fetchPypi {
+          pname = "starlette";
+          inherit version;
+          hash = "sha256-sbUjBe6PfPxIzeODSW98EauJfNcRKzPZmLExfcjvkCc=";
+        };
+        postPatch = "";
+        doCheck = false;
+        doInstallCheck = false;
+      }))
     tabulate
     uvicorn
     wsproto

The original derivation actually fetches sources from GitHub instead of PyPI.
I built it like this, and didn't need to disable any tests - not sure if that's related?
starlette.overrideAttrs ({ pname, ... }: rec {
  version = "0.21.0";
  src = fetchFromGitHub {
    owner = "encode";
    repo = pname;
    rev = version;
    hash = "sha256-wZtlKCD7eE4sCKfhFgWXywACAes8uo4HXkicJAMcgqk=";
  };
})

The original derivation actually fetches sources from GitHub instead of PyPI.
I built it like this, and didn’t need to disable any tests - not sure if that’s related?

Often the tests are not available in the distribution bundle from pypi, so that makes sense. Yours is better!

Do you want to prep a PR?

solved by 62b9dc3abb57084d9c50806c34bbee8f098fad17

authors: gador hacker1024 peterhoeg


text:
nix shell nixpkgs#cabal-install doesn't provide autocompletion for cabal

Describe the bug
Autocomplete doesn't work when in a nix shell.
nix shell nixpkgs#cabal-install doesn't provide auto completion for cabal
Steps To Reproduce
nix shell nixpkgs#cabal-install
cabal in<TAB>
cabal index.html

index.html is a random file whose name matches that of the cabal's command prefix.
Expected behavior
cabal in<TAB>
info     init     install

cabal-install does ship completions:
$ nix-build -A cabal-install
$ cat result/share/bash-completion/completions/cabal
...

@cdepillabout. You're right, it's not a cabal-specific issue. Please, consider removing the 6.topic-haskell label.

@deemp Label removed, thanks for the reminder.
Also, I'm not super familiar with the interaction between completions and nix shell or nix-shell, but it is possible that it makes more sense to post about this on the Nix issue tracker.  Maybe at least you should take a look there to see if anyone has posted something similar.

Thanks for a suggestion! Seems like https://github.com/NixOS/nix/issues/4453 addresses this issue.

authors: cdepillabout deemp


text:
Trying to make use of lib.systems.architectures.features

I have looked into lib/systems/architectures.nix and found that the predicates at the bottom of the file are used here.
I have a Ryzen 7 4750u and desire to enable all the available features that GCC can use and/or compile with.
When import nixpkgs, I tried setting localSystem to:
{
  system = "x86_64-linux";
  gcc.arch = "znver2";
}

This results in the following error:
error: a 'x86_64-linux' with features {gccarch-znver2} is required to build '/nix/store/zy4h2yj3ssv8q582lzl613w64zgi5z3m-bootstrap-stage0-glibc-bootstrapFiles.drv', but I am a 'x86_64-linux' with features {benchmark, big-parallel, kvm, nixos-test}

What is the intended usage of these platform feature flags? I could set them individually, but when there's already machinery in place to handle this, well...

You need to set system feature for the nix daemon. So it does not know that it is able to build znver2 things in your case.
That can be archived by setting something like
  nix.settings.system-features = ["gccarch-znver2" "benchmark" "big-parallel" "kvm" "nixos-test"];

Not sure if you need to set everything after gccarch-znver2, possibly that is already set by the system.
After that change is enabled you should be able to bootstrap the system.

You have to set system-features for Nix for localSystem to work correctly, the error message says exactly that. E.g. in configuration.nix:
nix.extraOptions = ''
  system-features = system-features = nixos-test benchmark big-parallel kvm gccarch-znver2
'';

However, it's not guaranteed that an actual -march=znver2 will be used, stdenv.hostSystem.* functions have to be explicitly used in a derivation. An alternative might be to wrap stdenv with wrapCFlags and specify desired ones. See also wiki.
But next time please use https://discourse.nixos.org for support questions.


text:
NixOS: networking/firewall.nix: pingLimit does not validate syntax

https://github.com/NixOS/nixpkgs/blob/610a958b03fb660c282148b2a6e15d2f5e20b47a/nixos/modules/services/networking/firewall.nix#L148
Attempting to use pingLimit with nftables syntax but without nftables.enable results in an error on startup.
Suggest adding a validation check that captures the information here

Pinging @duament and @azahi, who have both done some work on the module "recently" (read: in the last two years).


text:
Update to exiv2 broke gexiv2

Issue description
In c2e9f45df2387c4b809793c77639ec209b53efb9 @fpletz updated the exiv2 library without updating the gexiv2 library, which leads to build failures
Steps to reproduce
Try to build gexiv2 and you'll get failures like:
GExiv2 will be built with prefix /nix/store/sjgyvjs5kfy6kbkya9sklcqwklfygq0h-gexiv2-0.10.4 for x86_64-pc-linux-gnu (cross-compiling: no).

Options:
    Introspection:      no
    Python2 binding:    no (introspection disabled)
    Python3 binding:    no (introspection disabled)
    Tests and utils:    no

building
make flags: SHELL=/nix/store/1vcp949ka9qnyp6dfv4s9pgjda57vk4x-bash-4.4-p12/bin/bash
  CXX      gexiv2/libgexiv2_la-gexiv2-metadata.lo
In file included from gexiv2/gexiv2-metadata.cpp:13:0:
gexiv2/gexiv2-stream-io.h:42:15: error: conflicting return type specified for 'virtual long int StreamIo::size() const'
  virtual long size () const;
               ^
In file included from /nix/store/znbg3069yfwr48n9yr8ak0s5dbml4gvg-exiv2-0.26-dev/include/exiv2/image.hpp:31:0,
                 from gexiv2/gexiv2-metadata-private.h:14,
                 from gexiv2/gexiv2-metadata.cpp:12:
/nix/store/znbg3069yfwr48n9yr8ak0s5dbml4gvg-exiv2-0.26-dev/include/exiv2/basicio.hpp:225:24: error:   overriding 'virtual size_t Exiv2::BasicIo::size() const'
         virtual size_t size() const = 0;
                        ^
make: *** [Makefile:703: gexiv2/libgexiv2_la-gexiv2-metadata.lo] Error 1

Fixed in 46ead28a58

authors: globin mdorman


text:
programs.steam: Maintainers wanted

I'm currently the single maintainer for the steam module and as such usually the only person pinged.
I'd like to ask the community to step up and help, since my time and experience in this area of nixpkgs is quite limited
Comment here if you wanted to be added. A steam team will be created later.

Sure, I can help.

cc @samueldr @k900 @zhaofengli from Jovian

I can probably help.

I use Steam frequently, have touched the Steam module before and somewhat maintain buildFHSEnv, I can help out.

@hrdinka @abbradar @tadfisher @jagajaga @jonringer you are currently listed as a maintainer for steam/steam-runtime/steamcmd. would it be ok to add you to the steam team and then set maintainers for all steam packages to teams.steam?

(And do you actually still maintain Steam?)

I haven't really touched it in a while, I might just remove myself ig.

I'll help out, still use it regularly

I've merged the PR now, the package maintainers were left untouched, only the module was updated. Feel free to use the team in packages aswell.

done in https://github.com/NixOS/nixpkgs/pull/292817

authors: Atemu K900 appsforartists eclairevoyant jonringer mkg20001 pbsds


text:
syncthing for multiple users

config.services.syncthing allows configuring only one syncthing service. However, multiple users should be configured as separate processes according to syncthing documentation: https://docs.syncthing.net/users/faq.html#how-do-i-configure-multiple-users-on-a-single-machine
It would be nice if config.services.syncthing would be converted to a list of syncthing definitions, or whatever is the best way to support multiple syncthing instances.

I can try to contribute the required changes, but I'd like to hear opinions on what to actually do.

cc @peterhoeg @rnhmjoj

services.syncthing configures a system-wide service, with a dedicated user and all the related options iff config.services.systemService is true. You can still run any number of syncthing services on any users by setting services.syncthing = true and then running systemctl --user start synthing.

@rnhmjoj Oh, wow! :+1: That seems to work, although based on the nix file I don't understand how. So, I guess this can be closed.

although based on the nix file I don't understand how

You are correct, the syncthing module doesn't create the user service anymore. Thanks to @peterhoeg NixOS is directly using the unit file provided upstream as other distros do.

@jluttine, you can do this to activate the user service for all users:
systemd.user.services.syncthing.wantedBy = [ "default.target" ];

Shouldn't this follow the emacs multi-user service example in the manual?
In other words:
{
  services.syncthing.enable = false; # Do not start the service system-wide...
  services.emacs.install = true; # ...but never-the-less, make it available to individual users
}

The way services are handled (at least so far) is very much up to the individual maintainers which is far from ideal and we absolutely should standardize both the names for the various options as well as how we handle them. This is something I have wanted to do for a long time but never got around to. I really don't know if the emacs way is the best way forward or something else entirely but it would be worth at least starting the conversation. That should however, belong in a separate issue.

If there isn't one, an RFC certainly seems to be warranted.
(Though, given that there's not much difference technically, IMO the least surprising behavior for new services would be to follow whats in the manual as a de facto standard in the mean time. If nothing else it makes it easier to refactor everything uniformly to follow a new standard.)

If there isn't one, an RFC certainly seems to be warranted.

Absolutely.

IMO the least surprising behavior for new services would be to follow whats in the manual as a de facto standard in the mean time

Fully agree. Ping me in a PR? ;-)

I looked into this, but after some quick hacking I was surprised to notice that the emacs doesn't actually do exactly what I was expecting:
  config = mkIf (cfg.enable || cfg.install) {.
    systemd.user.services.emacs = {
      ....
    } // optionalAttrs cfg.enable { wantedBy = [ "default.target" ]; };

Specifically it uses systemd.user.services for both scenarios. This doesn't sound right for syncthing: I want to be able to deploy it to the cloud for "non-interactive" use. I may need to retract my initial reaction.

services.syncthing configures a system-wide service, with a dedicated user and all the related options iff config.services.systemService is true. You can still run any number of syncthing services on any users by setting services.syncthing = true and then running systemctl --user start synthing.

How can I accomplish that declaratively via configuration.nix?
I want to run a syncthing service for a handful of particular users, but not for all of them. Furthermore, I'd like those services to start at boot-time, i.e. not just when the users log in.
Is that possible with the current code?

There is no option to control user services declaratively afaik. You can enable a service for a certain user by symlinking the syncthing unit file like this:
ln -s /run/current-system/etc/systemd/user/syncthing.service $XDG_CONFIG_HOME/systemd/user/default.target.wants

this should make the default.target depend on syncthing so it will be started on login.  I'm not sure about starting at boot, maybe with loginctl enable-linger.

I ended up duplicating the code from the main syncthing module in a function
  mkJob = user: {
    "syncthing-${user}" = {
      description = "Syncthing service for user ${user}";
      after = [ "network.target" ];
      environment = { STNOUPGRADE = "yes"; };
      wantedBy = [ "multi-user.target" ];
      serviceConfig = {
        Restart = "on-failure";
        SuccessExitStatus = "2 3 4";
        RestartForceExitStatus="3 4";
        User = user;
        Group = "users";
        PermissionsStartOnly = true;
        ExecStart = "${config.services.syncthing.package}/bin/syncthing -no-restart -no-browser -home=/var/lib/syncthing/${user}";
      };
    };
  };

than can define services per user, like so:
systemd.services = mkJob "foo" // mkJob "bar";

It's not pretty, but it works fine. Now, what's missing is a way to configure the listen addresses for the actual sync service declaratively. I ended up editing lots of config.xml files ...

Furthermore, I'd like those services to start at boot-time, i.e. not just when the users log in.

This is possible by enabling "lingering", e.g. loginctl enable-linger $USER.

authors: hlovdal jluttine joachifm peterhoeg peti rehno-lindeque rnhmjoj


text:
Update request: pstoedit 3.78 -> 4.01

Package name: pstoedit
Latest released version: 4.01

Current version on the unstable channel: 3.78
Current version on the stable/release channel: 3.78

[x] Checked the nixpkgs pull requests

Notify maintainers
@MarcWeber

Note for maintainers: Please tag this issue in your PR.

Add a :+1: reaction to issues you find important.

ping @Artturin, due to last to commit
maintainer does not seem to be active


text:
Package request: hyprpanel

Project description
ags-based bar for hyprland
Metadata

homepage URL: https://github.com/Jas-SinghFSU/HyprPanel
source URL: https://github.com/Jas-SinghFSU/HyprPanel.git
license: mit
platforms: linux

Add a :+1: reaction to issues you find important.

Hey!
HyprPanel provide a flake and a package themselves: https://hyprpanel.com/getting_started/installation.html#nixos-home-manager.
I've opened an issue to see if they want to eventually upstream this into Nixpkgs, if they do, then there's not much point doing it now. Otherwise, it'd make sense, but we can probably collaborate with them!

Hey I have some error installing hyprpanel via flake. This is so annoying for me. I am extremely  love the hyprpanel. But nix flake gave me headache installing hyprpanel. So plz add hyprpanel to official nixpkgs. I am new to nixos and I really love nixos so plz

after the package has been added, it would be really nice to have a module to configure hyprpanel the nix way.

@mairs8 I mean, the flake already has that. The flake has a home manager module that allows you to configure it.


text:
ZapZap shows incorrect system time in messages

Describe the bug
Zapzap from the unstable repo will show incorrect system time in messages. This most often occurs if the application has been left running for long periods of time without quitting. Generally, for at least a day or two.
Steps To Reproduce
Steps to reproduce the behavior:

Launch zapzap unstable
Engage in a conversation
Leave the application open for a few days and when you return it should show wrong times on the next message you send.

Expected behavior
The time should always be synced with the system time.
Additional context
I use zapzap from unstable repo.
Notify maintainers
@hatch01

Could you please try this workaround to see if it fix the issue : https://github.com/NixOS/nixpkgs/issues/238025#issuecomment-1601270140


text:
Minor documentation nitpick: Python development mode

Issue description
The documentation for Python development mode says:

If we create a shell.nix file which calls buildPythonPackage, and if src is a local source, and if the local source has a setup.py, then development mode is activated.

This sounds like you need a shell.nix file and you need to use buildPythonPackage. But is that really true? I have a project that only has a default.nix and uses buildPythonApplication and it still seems to call setup.py develop.

Right, the name of the Nix file is not important – you can use any name and then run nix-shell yourfile.nix. I would guess the important thing is that you ran the shell (that is $IN_NIX_SHELL environment variable is set) but I do not see any relevant mentions of develop in nixpkgs.
buildPythonApplication does basically the same thing as buildPythonPackage so it makes sense that they work similarly:
https://github.com/NixOS/nixpkgs/blob/f86e309a9415049d6b0e4ad67fcf16f80e8b087d/pkgs/top-level/python-packages.nix#L54-L67

Correct, any .nix file works, it's just that by convention we call it shell.nix and nix-shell also chooses shell.nix over default.nix.

Okay, thanks for the clarification guys!

authors: FRidh jtojnar pmiddend


text:
failing test in coreutils

The test for dd/sparse.sh fails when building coreutils in 77f160e

building tests/dd/sparse.log
FAIL: tests/dd/sparse.sh

https://gist.github.com/vandenoever/816b177b0c4ba99c5477
I've tried finding the offending commit with git bisect, but this did not lead me to the offending commit.
I'm running NixOS 14.12 on btrfs with kernel 3.18.0.

aea1254f96b068d370cb0dbc16638e7cef8ba84c seems to be the first problematic commit. The preceding commit, c45372f038bc89c69390bdbc6a4b0bfdb63b1423 can install coreutils, but it might have been retrieved from a binary cache.

I'm certain I've seen this already, but I can't find what I did about it (probably just disabled checks temporarily). I guess it's a bug in the tests when running on some filesystems, as it was in other cases https://lists.fedoraproject.org/pipermail/scm-commits/Week-of-Mon-20140407/1223907.html.

It's failing on btrfs too. Disabling checks do the job.

A fix is in staging, only disabling the dd/sparse test instead of all.

authors: dwe11er vandenoever vcunat


text:
Example in nixos-container docs is broken

In https://nixos.org/releases/nixos/14.12/nixos-14.12.374.61adf9e/manual/ch-containers.html, this example doesn't work (curl hangs).
$ nixos-container update foo --config 'services.httpd.enable = true; \
  services.httpd.adminAddr = "foo@example.org";'

$ curl http://$(nixos-container show-ip foo)/
<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 3.2 Final//EN">…

It can be fixed by adding networking.firewall.enable = false; inside the container config.

It's probably better to add networking.firewall.allowedTCPPorts = [ 80 ];

Please submit a PR if this is still a problem

authors: anderspapitto copumpkin joachifm


text:
RFP: Brother J890DW Printer Drivers

Project description
Printer drivers for the Brother J890DW Printer
Metadata

homepage URL: https://support.brother.com/g/b/downloadlist.aspx?c=eu_ot&lang=en&prod=mfcj890dw_eu_as&os=128
source URL: proprietary
license: unfree
platforms: linux

While IPP Everywhere works, having a generic script for all those different brother drivers (most aren't that different so a few simple checks could make it work I suppose) would really help with printer things in the nixOS world


text:
Package pantheon's mail client

Project description
The elementary mail client shares a history with geary, but is a different app, which fits the pantheon desktop.
Metadata

homepage URL: https://elementary.io/
source URL: https://github.com/elementary/mail
license: GPLv3
platforms: Linux

@worldofpeace I think you're coordinating pantheon efforts? I'd be happy to take a look at this.

See the last bullet of https://github.com/NixOS/nixpkgs/issues/58161

Not stale, still waiting for them to ship-it :shipit:

@worldofpeace it seems like your wait might be over, judging by dependency list in README.md?

@kisik21 I see this https://github.com/elementary/seeds/pull/41, so I will ask them in slack if they're shipping it. If so, I think I'll add it myself when they release odin, or anyone else is free to package it.


text:
Manual, 20.1. Synapse Homeserver: example is wrong

The example configuration suggests the setting
 services.postgresql.initialScript = ''
    CREATE ROLE "matrix-synapse" WITH LOGIN PASSWORD 'synapse';
    CREATE DATABASE "matrix-synapse" WITH OWNER "matrix-synapse"
      TEMPLATE template0
      LC_COLLATE = "C"
      LC_CTYPE = "C";
  '';

This fails because services.postgresql.initialScript has to be of type null or path.

@ma27 (I think)

Thanks for pointing this out! Fixed on master and release-20.03 :)

authors: Ma27 loewenheim worldofpeace


text:
Vulnerability roundup 84: systemd-243.7: 1 advisory

search, files

[ ] CVE-2020-1712 CVSSv3=7.8 (nixos-19.09, nixos-20.03)

Scanned versions: nixos-19.09: 31dcaa5eb67; nixos-20.03: 82b5f87fcc7. May contain false positives.

Discussion happens in https://github.com/NixOS/nixpkgs/issues/90982, let's close here.

authors: ckauhaus flokli


text:
Setting CAP_SYS_NICE=eip on vrcompositor-launcher crashes SteamVR

Describe the bug
A clear and concise description of what the bug is.
SteamVR crashes when you set CAP_SYS_NICE=eip on vrcompositor-launcher.
To Reproduce
Steps to reproduce the behavior:

sudo setcap CAP_SYS_NICE=eip ~/.local/share/Steam/steamapps/common/SteamVR/bin/linux64/vrcompositor-launcher
steam-run strace ~/.local/share/Steam/steamapps/common/SteamVR/bin/linux64/vrcompositor-launcher

Expected behavior
A clear and concise description of what you expected to happen.
On an FHS distro it looks for libs in /lib32 /lib64 and the like. It should either do that or look under /steamrt/.
Screenshots
If applicable, add screenshots to help explain your problem.
Additional context
Add any other context about the problem here.
See #71554
I booted up a Pop!_OS live env, installed SteamVR, set the CAP and straced vrcompositor-launcher.
It first started looking for libcap.so.2 in the SteamVR bin and then regular FHS paths like /usr/lib etc. where it found libcap under /lib/x86_64-linux-gnu/libcap.so.2.
On NixOS it only tries to look in a few FHS paths under ${pkgs.glibc} which is obviously nonsensical and fails.
Seems like this happends due to Nix-specific patches to dynamic linking because we're also doing something that makes vrcompositor-launcher try to preload from /etc/ld-nix.so.preload which, countrary to LD_PRELOAD, also actually works. I made use of this and modified buildFHSUserEnv to create a file in that location inside the chroot to preload libcap.so.2 and libstdc++.so.6 from the steamrt.
With these patches, SteamVR can be launched with CAP_SYS_NICE=eip set on vrcompositor-launcher.
https://github.com/Atemu/nixpkgs/tree/steamvr-lib-loading-fixes
This is obviously not a solution, only for troubleshooting. Could someone more knowledgeable about dynamic linking in Nix to have a look at this now that we know what our issue is?
While doing this I have also discovered that the chronic stuttering issue (1-3 purple spikes ever second or so) is greatly reduced or even completely eliminated (depending on the mood of SteamVR) when a preloaded ${pkgs.steamPackages.steam-runtime}/usr/lib/x86_64-linux-gnu/libSDL2-2.0.so.0 replaces the libSDL from the SteamVR bin it'd normally try to load. This can also be achieved by replacing the lib with a symlink to the one in the steamrt.
I'd love to hear more reports on this so that we can take this information to Valve as I had the same issue on Pop!_OS.
Notify maintainers

@jagajaga @abbradar
Metadata
Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.

system: "x86_64-linux"
host os: Linux 5.6.19, NixOS, 20.09pre233323.dc80d7bc4a2 (Nightingale)
multi-user?: yes
sandbox: yes
version: nix-env (Nix) 2.3.6
channels(root): "nixos-20.09pre233323.dc80d7bc4a2, nixpkgs-mozilla, nixos-stable-20.03.2310.fb6c3a6831c, nixos-unstable-20.09pre231796.22a81aa5fc1"
nixpkgs: /nix/var/nix/profiles/per-user/root/channels/nixos

Maintainer information:
# a list of nixpkgs attributes affected by the problem
attribute:
# a list of nixos modules affected by the problem
module:

FIxed by https://github.com/NixOS/nixpkgs/pull/55973

This was working for me in the past, but seems broken again currently.
Fri Jan 13 14:01:11 GMT 2023 - Error: setcap of vrcompositor-launcher failed.

nixos-unstable @ a518c77148585023ff56022f09c4b2c418a51ef5

Oh, there was a hidden background dialog with 'OK, proceed anyway' which did work, so maybe the error can be ignored.

authors: Atemu pwaller


text:
bear: 3.0.1 -> 3.0.2

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/rizsotto/bear/releases.
meta.description for bear is: "Tool that generates a compilation database for clang tooling"
meta.homepage for bear is: "https://github.com/rizsotto/Bear"
meta.changelog for bear is: ""
Updates performed

Version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS

The tests defined in passthru.tests, if any, passed

0 of 0 passed binary check by having a zero exit code.

0 of 0 passed binary check by having the new version present in output.

found 3.0.2 with grep in /nix/store/2qdwp8hbi8fmfnk1pa4pa832zp0afnl9-bear-3.0.2

directory tree listing: https://gist.github.com/e48800dc0525fbd20a24e3e28a235f87

du listing: https://gist.github.com/dd46083dd4a1af95d6f7acf258d3e0f2

Rebuild report (if merged into master) (click to expand)

4 total rebuild path(s)

1 package rebuild(s)

1 x86_64-linux rebuild(s)
1 i686-linux rebuild(s)
1 x86_64-darwin rebuild(s)
1 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
bear

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/2qdwp8hbi8fmfnk1pa4pa832zp0afnl9-bear-3.0.2 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A bear https://github.com/r-ryantm/nixpkgs/archive/376405314fd15eee5c9235549096cee3518ff364.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/2qdwp8hbi8fmfnk1pa4pa832zp0afnl9-bear-3.0.2
ls -la /nix/store/2qdwp8hbi8fmfnk1pa4pa832zp0afnl9-bear-3.0.2/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review 1

1 package built:

bear

Maintainer pings
cc @babariviere for testing.

@GrahamcOfBorg eval

source: gharchive/pull-request

authors: marsam r-ryantm


text:
crow-translate: init at 2.6.2

Motivation for this change

Crow Translate is a simple and lightweight translator programmed in C++ / Qt that allows to translate and speak text using Google, Yandex and Bing translate API.

Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 105402 run on x86_64-linux 1

1 package built:

crow-translate

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/425

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/425

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.
Result of nixpkgs-review pr 105402 run on x86_64-linux 1

1 package built:

crow-translate

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.
Result of nixpkgs-review pr 105402 run on x86_64-linux 1

1 package built:

crow-translate

authors: SuperSandro2000 nixos-discourse sikmir


text:
parse: init at 3.0.1

Parse's installation instructions point to a shell script which simply downloads the release from github, so this ends up being a very straightforward package.

/home/travis/build/NixOS/nixpkgs/pkgs/applications/editors/emacs-24/macport-24.5.nix:1:1 called without required argument ‘cf-private’, at

Is that failure related to this PR? I don't see how it could be.

Renamed parse to parse-cli-bin.
Also changed the version from 3.0.0 to 3.0.1.

authors: chris-martin domenkozar


text:
pinta: 1.4 -> 1.6

There three distinct changes:

Updated pinta to version 1.6. Note, that package now uses buildDotnetPackage instead of plain mkDerivation.
CC maintainer: @viric

In order to do 1., I needed:
2. Add dotnet package Mono.Addins (init at 1.2)
3. Add makeWrapperArgs argument to buildDotnetPackage (we have the same thing in buildPythonPackage and I think it should be often useful)
CC maintainer: @obadz
I stripped  Version, Culture and PublicKeyToken attributes from <Reference Include="..." />  in Pinta's .csproj files, so that xbuild could find those libraries. I don't know if that was a correct way to resolve that issue but something very similar happens in this monodevelop patch: https://github.com/NixOS/nixpkgs/blob/master/pkgs/development/dotnet-modules/patches/monodevelop-fsharpbinding.references.patch
I tested it locally just in case for both system="i686-linux" and system="x86_64-linux".

@demin-dmitriy, the dotnet change looks fine to me.

authors: demin-dmitriy obadz


text:
soldat-unstable: init at unstable-2020-11-26;  gamenetworkingsockets: init at 1.2.0

Motivation for this change
Adds the open sourced development version of soldat, a 2d side
scrolling shooter. The soldat-unstable attribute name was chosen since
this is a development version of the unfinished soldat 1.8 version which
most notably has incompatible netcode to the windows-only soldat 1.7
version which you can download on steam for example, so naming this
soldat-unstable hopefully avoids confusion as to why it is not possible
to connect to soldat 1.7 servers.
We wrap the soldat and soldatserver executables to have fixed paths set
for fs_basepath (the game archive) and fs_userpath (configuration, state
files). The latter is set to $XDG_CONFIG_HOME/soldat/soldat{,server} by
default to stop the executables from polluting the working directory.
Both settings can be overriden however by giving the respective options
on the command line of the wrapper.
GameNetworkingSockets is a dependency of soldat.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.
Result of nixpkgs-review pr 108436 run on x86_64-linux 1

2 packages built:

gamenetworkingsockets
soldat-unstable

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.
Result of nixpkgs-review pr 108436 run on x86_64-linux 1

2 packages built:

gamenetworkingsockets
soldat-unstable

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.
Result of nixpkgs-review pr 108436 run on x86_64-darwin 1

1 package failed to build and are new build failure:

gamenetworkingsockets: log https://hastebin.com/raw/feqelinexe

gamenetworkingsockets: log https://hastebin.com/raw/feqelinexe

log not found

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.
Result of nixpkgs-review pr 108436 run on x86_64-linux 1

2 packages built:

gamenetworkingsockets
soldat-unstable

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.
Result of nixpkgs-review pr 108436 run on x86_64-linux 1

2 packages built:

gamenetworkingsockets
soldat-unstable

Shall we merge?

Shall we merge?

Fixing GameNetworkingSockets and soldat for darwin would be nice, but I can' really gauge what the problem is without a build log.

Fixing GameNetworkingSockets and soldat for darwin would be nice, but I can' really gauge what the problem is without a build log.

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.
Result of nixpkgs-review pr 108436 run on x86_64-darwin 1

1 package failed to build and are new build failure:

gamenetworkingsockets: log https://termbin.com/o8jc

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.
Result of nixpkgs-review pr 108436 run on x86_64-darwin 1

1 package failed to build and are new build failure:

gamenetworkingsockets: log https://termbin.com/o8jc

Okay, this is a genuine issue with GameNetworkingSockets, SOCK_NONBLOCK doesn't exist on darwin. I've marked it as broken for now and will try to get a patch into upstream and the come back to fix the package.

Okay, this is a genuine issue with GameNetworkingSockets, SOCK_NONBLOCK doesn't exist on darwin. I've marked it as broken for now and will try to get a patch into upstream and the come back to fix the package.

The build failure is already resolved on GameNetworkingSockets master, so it's just a matter of time to have it for darwin as well.

The build failure is already resolved on GameNetworkingSockets master, so it's just a matter of time to have it for darwin as well.

Result of nixpkgs-review pr 108436 run on x86_64-darwin 1

1 package marked as broken and skipped:

gamenetworkingsockets

Result of nixpkgs-review pr 108436 run on x86_64-darwin 1

1 package marked as broken and skipped:

gamenetworkingsockets

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.
Result of nixpkgs-review pr 108436 run on x86_64-linux 1

2 packages built:

gamenetworkingsockets
soldat-unstable

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.
Result of nixpkgs-review pr 108436 run on x86_64-linux 1

2 packages built:

gamenetworkingsockets
soldat-unstable

@SuperSandro2000 Automating review is nice and all, but please scroll through the backlog and tell me it’s not starting to get spammy.
e.g. your bot (‽) added the same comment as earlier, even though @sternenseemann already said that the nit is irrelevant.
We shouldn’t force stylistic nitpicks onto maintainers that know what they are doing.

@SuperSandro2000 Automating review is nice and all, but please scroll through the backlog and tell me it’s not starting to get spammy.
e.g. your bot (‽) added the same comment as earlier, even though @sternenseemann already said that the nit is irrelevant.
We shouldn’t force stylistic nitpicks onto maintainers that know what they are doing.

e.g. your bot (‽) added the same comment as earlier, even though @sternenseemann already said that the nit is irrelevant.

I am not a bot. I have several humans that can prove that I made out of flesh. Jokes aside.
I read through the diff and thought the second time that this is still not quite right.
Generally variables which contain commands use '' because they can easily be multiline even if they only contain one command. Additionally some extra escaping is required here because of that. I think that adds the false intention that $TMP maybe shouldn't be evaluated at that point and only at runtime. I try to not nit about older packages to much when they just change one line or do a simple version update but for new packages or packages with bigger changes we should focus on making them clean and use hooks and variables when available. Especially for new packages we should really think how to make them clean, short and simple to easily maintain them in the future, make updates easy and don't hinder treewide changes with unusual syntaxes or escapes.

We shouldn’t force stylistic nitpicks onto maintainers that know what they are doing.

We already enforce a pretty great list of stylistics and probably some of them are nitpicks but so far I don't think I have seen one that is literally useless.

e.g. your bot (‽) added the same comment as earlier, even though @sternenseemann already said that the nit is irrelevant.

I am not a bot. I have several humans that can prove that I made out of flesh. Jokes aside.
I read through the diff and thought the second time that this is still not quite right.
Generally variables which contain commands use '' because they can easily be multiline even if they only contain one command. Additionally some extra escaping is required here because of that. I think that adds the false intention that $TMP maybe shouldn't be evaluated at that point and only at runtime. I try to not nit about older packages to much when they just change one line or do a simple version update but for new packages or packages with bigger changes we should focus on making them clean and use hooks and variables when available. Especially for new packages we should really think how to make them clean, short and simple to easily maintain them in the future, make updates easy and don't hinder treewide changes with unusual syntaxes or escapes.

We shouldn’t force stylistic nitpicks onto maintainers that know what they are doing.

We already enforce a pretty great list of stylistics and probably some of them are nitpicks but so far I don't think I have seen one that is literally useless.

Cool, merging.

Cool, merging.

It makes a difference of one `\n in the string and I'd argue in this case it reduces noise and readability since a relatively unimportant compatibility fix is not occupying to much space.
Also I think I'll be fine maintaining this whereas endless rebasing is just plain annoying.

It makes a difference of one `\n in the string and I'd argue in this case it reduces noise and readability since a relatively unimportant compatibility fix is not occupying to much space.
Also I think I'll be fine maintaining this whereas endless rebasing is just plain annoying.

@Profpatsch If you wouldn't be the first person labeling my manual work as a bot I would be pretty offended by that.

@Profpatsch If you wouldn't be the first person labeling my manual work as a bot I would be pretty offended by that.


text:
@electron-forge/cli: init at 6.0.0-beta.54

Motivation for this change
Adding @electron-forge/cli which is used to build electron applications into various distribution formats.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Depends on this PR: https://github.com/NixOS/nixpkgs/pull/115174

»» ~/Projects/nixpkgs
 ♖ ./result/bin/electron-forge -h     (electron-forge) pts/9 18:27:51
✔ Checking your system
Usage: electron-forge [options] [command]

Options:
  -V, --version  output the version number
  --verbose      Enables verbose mode
  -h, --help     output usage information

Commands:
  init           Initialize a new Electron application
  import         Attempts to navigate you through the process of
                 importing an existing project to "electron-forge"
  lint           Lints the current Electron application
  package        Package the current Electron application
  make           Generate distributables for the current Electron
                 application
  start          Start the current Electron application
  publish        Publish the current Electron application to GitHub
  install        Install an Electron application from GitHub
  help [cmd]     display help for [cmd]

Strange problem but the nixpkgs packaged ones seems to be creating files with read permission only. This is different from the npm installed one:
> nix-env -f ./default.nix -iA 'nodePackages.@electron-forge/cli'
> mkdir test/a
> cd test/a
> electron-forge init --template=typescript-webpack
✔ Checking your system
✔ Initializing Project Directory
✔ Initializing Git Repository
✔ Locating custom template: "typescript-webpack"
✔ Copying Starter Files
✔ Initializing NPM Module
✔ Setting up Forge configuration
✖ Setting up TypeScript configuration

An unhandled error has occurred inside Forge:
EACCES: permission denied, open '/test/a/src/index.html'
Error: EACCES: permission denied, open '/test/b/src/index.html'

The reason is that the files here are generated with only the read permission:
> ls -l /test/a/src
total 14K
-r--r--r-- 1 cmcdragonkai operators  162 Mar  6 18:30 index.css
-r--r--r-- 1 cmcdragonkai operators  253 Mar  6 18:30 index.html
-r--r--r-- 1 cmcdragonkai operators 1.5K Mar  6 18:30 index.js

When using the electron-forge from NPM, this doesn't occur.

The other usages of electron-forge does work, and I'm able to build and package electron apps with it.
The above error is strange, why would electron-forge end up creating files that are read-only? Is this due to being put inside the /nix/store?

Tested to be functional. Didn't test any other package changed by this commit. Currently there's also https://github.com/NixOS/nixpkgs/pull/114574 which changes files in node-packages.nix and it has merge conflicts already. @CMCDragonkai would you like to get past the read only permissions issue before merging?

No idea what is causing that read issue. But the other stuff is all working. Can build windows and Linux packages.

The above error is strange, why would electron-forge end up creating files that are read-only? Is this due to being put inside the /nix/store?

Does it copy files from the nix store?

@SuperSandro2000 oh maybe that is the reason... in that case, how can we fix this? Will it need a source code patch? Maybe an upstream fix that ensures that the generated files are read write.

Posted an upstream issue here: https://github.com/electron-userland/electron-forge/issues/2190
I think an upstream fix will eventually fix the whole problem and then there will be no problems using electron-forge in Nixpkgs.
Also in the future, I think electron-packager and electron-rebuild should also be packaged in Nixpkgs as well but so far it is not needed.
Furthermore the @electron-forge/maker-* dependencies don't need to be packaged in Nix yet, electron-forge here will make use of it by checking package.json in the devDependencies... but in the future these might be packaged in Nix as well, but we will need a more sophisticated electron ecosystem in nixpkgs to do this...

in that case, how can we fix this? Will it need a source code patch? Maybe an upstream fix that ensures that the generated files are read write.

A patch would probably be the easiest.

we will need a more sophisticated electron ecosystem in nixpkgs to do this...

yeah, someone needs to do that.

authors: CMCDragonkai SuperSandro2000 doronbehar


text:
detect-secrets: 0.14.3 -> 1.1.0

Motivation for this change
Update to latest upstream release 1.1.0
Change log: https://github.com/Yelp/detect-secrets/releases/tag/v1.1.0
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Relase notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 129160 run on x86_64-linux 1

3 packages built:

detect-secrets
gibberish-detector (python38Packages.gibberish-detector)
python39Packages.gibberish-detector

Result of nixpkgs-review pr 129160 at 4a30247b run on x86_64-linux 1

3 packages built successfully:

detect-secrets
gibberish-detector (python38Packages.gibberish-detector)
python39Packages.gibberish-detector

2 suggestions:

warning: unused-argument
Unused argument: configparser.
Near pkgs/development/tools/detect-secrets/default.nix:3:3:
  |
3 | , configparser
  |   ^

warning: unused-argument
Unused argument: future.
Near pkgs/development/tools/detect-secrets/default.nix:5:3:
  |
5 | , future
  |   ^

@fabaff please remove the unused arguments.

@fabaff please remove the unused arguments.

Thanks, done.

authors: SuperSandro2000 fabaff r-rmcgibbo


text:
git-remote-hg: fix the derivation name

-v0.2 isn't parsed as a version by Nix, and makes it inconvenient to
install git-remote-hg through nix-env.

@nathan7  also rev could be used in version
but then maybe we should remove git-remote-hg in favor of git-cinnabar, which i'm about to package (if nobody does it before me)

I'm hoping we can keep it around, given that

Git-cinnabar is still in early infancy`

@joachifm Done.


text:
python39Packages.influxdb-client: 1.21.0 -> 1.23.0

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for python39Packages.influxdb-client is: "InfluxDB 2.0 Python client library"
meta.homepage for python39Packages.influxdb-client is: "https://github.com/influxdata/influxdb-client-python"
meta.changelog for python39Packages.influxdb-client is: ""
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS

Warning: a test defined in passthru.tests did not pass

0 of 0 passed binary check by having a zero exit code.

0 of 0 passed binary check by having the new version present in output.

found 1.23.0 with grep in /nix/store/wkxjgf315j4z0cywlh48libh5jp391i6-python3.9-influxdb-client-1.23.0

found 1.23.0 in filename of file in /nix/store/wkxjgf315j4z0cywlh48libh5jp391i6-python3.9-influxdb-client-1.23.0

Rebuild report (if merged into master) (click to expand)

11 total rebuild path(s)

3 package rebuild(s)

3 x86_64-linux rebuild(s)
3 i686-linux rebuild(s)
2 x86_64-darwin rebuild(s)
3 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
home-assistant
python38Packages.influxdb-client
python39Packages.influxdb-client

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/wkxjgf315j4z0cywlh48libh5jp391i6-python3.9-influxdb-client-1.23.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A python39Packages.influxdb-client https://github.com/r-ryantm/nixpkgs/archive/2dac86f1405bc7f1b5bdf7dd7126d394132bb654.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/wkxjgf315j4z0cywlh48libh5jp391i6-python3.9-influxdb-client-1.23.0
ls -la /nix/store/wkxjgf315j4z0cywlh48libh5jp391i6-python3.9-influxdb-client-1.23.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package failed to build:

home-assistant

2 packages built:

python38Packages.influxdb-client
python39Packages.influxdb-client

Maintainer pings
cc @mic92 for testing.

This update seems to break all home-assistant tests for influxdb. cc @mweinelt

Judging the message this could be a regression in the client itself:
/nix/store/wkxjgf315j4z0cywlh48libh5jp391i6-python3.9-influxdb-client-1.23.0/lib/python3.9/site-packages/influxdb_client/rest.py:360: in __init__
    super().__init__(response=http_resp)
        __class__  = <class 'influxdb_client.rest.ApiException'>
        http_resp  = None
        reason     = None
        self       = ApiException()
        status     = None
/nix/store/wkxjgf315j4z0cywlh48libh5jp391i6-python3.9-influxdb-client-1.23.0/lib/python3.9/site-packages/influxdb_client/client/exceptions.py:16: in __init__
    self.message = self._get_message(response)
        __class__  = <class 'influxdb_client.client.exceptions.InfluxDBError'>
        response   = None
        self       = ApiException()
/nix/store/wkxjgf315j4z0cywlh48libh5jp391i6-python3.9-influxdb-client-1.23.0/lib/python3.9/site-packages/influxdb_client/client/exceptions.py:22: in _get_message
    if response.data:
E   AttributeError: 'NoneType' object has no attribute 'data'
        response   = None
        self       = ApiException()

Home Assistant pins 1.14.0. Guess we just need a pin on home-assistant.

authors: Mic92 mweinelt r-ryantm


text:
haskellPackages: update stackage and hackage

This Merge
This PR is the regular merge of the haskell-updates branch into master.
This branch is being continually built and tested by hydra at https://hydra.nixos.org/jobset/nixpkgs/haskell-updates. You may be able to find an up-to-date Hydra build report at cdepillabout/nix-haskell-updates-status.
We roughly aim to merge these haskell-updates PRs at least once every two weeks. See the @NixOS/haskell team calendar for who is currently in charge of this branch.
haskellPackages Workflow Summary
Our workflow is currently described in pkgs/development/haskell-modules/HACKING.md.
The short version is this:

We regularly update the Stackage and Hackage pins on haskell-updates (normally at the beginning of a merge window).
The community fixes builds of Haskell packages on that branch.
We aim at at least one merge of haskell-updates into master every two weeks.
We only do the merge if the mergeable job is succeeding on hydra.
If a maintained package is still broken at the time of merge, we will only merge if the maintainer has been pinged 7 days in advance. (If you care about a Haskell package, become a maintainer!)

This is the follow-up to #148359. Come to #haskell:nixos.org if you have any questions.

haskell-updates build report from hydra
evaluation 1729068 of nixpkgs commit cf33a63 as of 2021-12-08 14:39 UTC
:yellow_circle: Potential issues

maintained jobset is not finished.

Build summary

Platform
Failed :x:
DependencyFailed :heavy_exclamation_mark:
TimedOut :hourglass::no_entry_sign:
Unfinished :hourglass_flowing_sand:
Success :heavy_check_mark:

aarch64-linux :iphone:
23
16
1
5
7112

x86_64-darwin :apple:
54
26
2
5
7010

x86_64-linux :penguin:
3

4
7185

Maintained packages with failed dependency

[ ] cabal-install @peti

[:iphone::heavy_check_mark:] [:apple::heavy_check_mark:] [:penguin::heavy_check_mark:] toplevel
[:iphone::heavy_check_mark:] [:apple::heavy_check_mark:] [:penguin::heavy_check_mark:] haskell.packages.ghc8107
[:iphone::heavy_check_mark:] [:apple::heavy_check_mark:] [:penguin::heavy_check_mark:] haskell.packages.ghc884
[:iphone::heavy_check_mark:] [:apple::heavy_check_mark:] [:penguin::heavy_check_mark:] haskell.packages.ghc901
[:iphone::heavy_exclamation_mark:] [:apple::heavy_check_mark:] [:penguin::heavy_check_mark:] haskell.packages.ghc921
[:iphone::heavy_check_mark:] [:apple::heavy_check_mark:] [:penguin::heavy_check_mark:] haskellPackages

[ ] cabal2nix @peti

[:iphone::heavy_check_mark:] [:apple::heavy_check_mark:] [:penguin::heavy_check_mark:] toplevel
[:iphone::heavy_check_mark:] [:apple::heavy_check_mark:] [:penguin::heavy_check_mark:] haskell.packages.ghc8107
[:iphone::heavy_check_mark:] [:apple::heavy_check_mark:] [:penguin::heavy_check_mark:] haskell.packages.ghc884
[:iphone::heavy_check_mark:] [:apple::heavy_check_mark:] [:penguin::heavy_check_mark:] haskell.packages.ghc901
[:iphone::heavy_exclamation_mark:] [:apple::heavy_check_mark:] [:penguin::heavy_check_mark:] haskell.packages.ghc921
[:iphone::heavy_check_mark:] [:apple::heavy_check_mark:] [:penguin::heavy_check_mark:] haskellPackages

[ ] hsdns @peti

[:iphone::heavy_check_mark:] [:apple::heavy_check_mark:] [:penguin::heavy_check_mark:] haskell.packages.ghc8107
[:iphone::heavy_check_mark:] [:apple::heavy_check_mark:] [:penguin::heavy_check_mark:] haskell.packages.ghc884
[:iphone::heavy_check_mark:] [:apple::heavy_check_mark:] [:penguin::heavy_check_mark:] haskell.packages.ghc901
[:iphone::heavy_exclamation_mark:] [:apple::heavy_check_mark:] [:penguin::heavy_check_mark:] haskell.packages.ghc921
[:iphone::heavy_check_mark:] [:apple::heavy_check_mark:] [:penguin::heavy_check_mark:] haskellPackages

[ ] language-nix @peti

[:iphone::heavy_check_mark:] [:apple::heavy_check_mark:] [:penguin::heavy_check_mark:] haskell.packages.ghc8107
[:iphone::heavy_check_mark:] [:apple::heavy_check_mark:] [:penguin::heavy_check_mark:] haskell.packages.ghc884
[:iphone::heavy_check_mark:] [:apple::heavy_check_mark:] [:penguin::heavy_check_mark:] haskell.packages.ghc901
[:iphone::heavy_exclamation_mark:] [:apple::heavy_check_mark:] [:penguin::heavy_check_mark:] haskell.packages.ghc921
[:iphone::heavy_check_mark:] [:apple::heavy_check_mark:] [:penguin::heavy_check_mark:] haskellPackages

[ ] titlecase @peti

[:iphone::heavy_check_mark:] [:apple::heavy_check_mark:] [:penguin::heavy_check_mark:] haskell.packages.ghc8107
[:iphone::heavy_check_mark:] [:apple::heavy_check_mark:] [:penguin::heavy_check_mark:] haskell.packages.ghc884
[:iphone::heavy_check_mark:] [:apple::heavy_check_mark:] [:penguin::heavy_check_mark:] haskell.packages.ghc901
[:iphone::heavy_exclamation_mark:] [:apple::heavy_check_mark:] [:penguin::heavy_check_mark:] haskell.packages.ghc921
[:iphone::heavy_check_mark:] [:apple::heavy_check_mark:] [:penguin::heavy_check_mark:] haskellPackages

Unmaintained packages with build failure
73 job(s)

[ ] [:iphone::heavy_check_mark:] [:apple::x:] [:penguin::heavy_check_mark:] haskellPackages.sdp  :arrow_heading_up: 9 | 9
[ ] [:iphone::heavy_check_mark:] [:apple::x:] [:penguin::heavy_check_mark:] haskellPackages.thyme  :arrow_heading_up: 6 | 15
[ ] [:iphone::x:] [:apple::heavy_check_mark:] [:penguin::heavy_check_mark:] haskellPackages.libBF  :arrow_heading_up: 4 | 20
[ ] [:iphone::heavy_check_mark:] [:apple::x:] [:penguin::heavy_check_mark:] haskellPackages.exinst  :arrow_heading_up: 4 | 6
[ ] [:iphone::heavy_check_mark:] [:apple::x:] [:penguin::heavy_check_mark:] haskellPackages.nri-observability  :arrow_heading_up: 3 | 5
[ ] [:iphone::x:] [:apple::heavy_check_mark:] [:penguin::heavy_check_mark:] haskellPackages.ptr-poker  :arrow_heading_up: 3 | 4
[ ] [:iphone::x:] [:apple::heavy_check_mark:] [:penguin::heavy_check_mark:] haskellPackages.long-double  :arrow_heading_up: 2 | 2
[ ] [:iphone::x:] [:apple::heavy_check_mark:] [:penguin::heavy_check_mark:] haskellPackages.OrderedBits  :arrow_heading_up: 1 | 36
[ ] [:iphone::x:] [:apple::heavy_check_mark:] [:penguin::heavy_check_mark:] haskellPackages.type-natural  :arrow_heading_up: 1 | 4
[ ] [:iphone::x:] [:apple::x:] [:penguin::heavy_check_mark:] haskellPackages.easytensor  :arrow_heading_up: 1 | 1
[ ] [:iphone::heavy_check_mark:] [:apple::x:] [:penguin::heavy_check_mark:] haskellPackages.gi-gdkx11  :arrow_heading_up: 1 | 1
[ ] [:iphone::heavy_check_mark:] [:apple::x:] [:penguin::heavy_check_mark:] haskellPackages.keep-alive  :arrow_heading_up: 1 | 1
[ ] [:iphone::heavy_check_mark:] [:apple::x:] [:penguin::heavy_check_mark:] haskellPackages.loc  :arrow_heading_up: 1 | 1
[ ] [:iphone::x:] [:apple::heavy_check_mark:] [:penguin::heavy_check_mark:] haskellPackages.nlopt-haskell  :arrow_heading_up: 1 | 1
[ ] [:iphone::heavy_check_mark:] [:apple::x:] [:penguin::heavy_check_mark:] haskellPackages.opencv  :arrow_heading_up: 1 | 1
[ ] [:iphone::x:] [:apple::heavy_check_mark:] [:penguin::heavy_check_mark:] haskellPackages.unicode-properties  :arrow_heading_up: 1 | 1
[ ] [:iphone::x:] [:apple::heavy_check_mark:] [:penguin::heavy_check_mark:] haskellPackages.accelerate-llvm  :arrow_heading_up: 0 | 8
[ ] [:iphone::x:] [:apple::heavy_check_mark:] [:penguin::heavy_check_mark:] haskellPackages.freetype2  :arrow_heading_up: 0 | 7
[ ] [:iphone::heavy_check_mark:] [:apple::x:] [:penguin::heavy_check_mark:] haskellPackages.pipes-zlib  :arrow_heading_up: 0 | 6
[ ] [:iphone::heavy_check_mark:] [:apple::x:] [:penguin::heavy_check_mark:] haskellPackages.hmidi  :arrow_heading_up: 0 | 4
[ ] [:iphone::heavy_check_mark:] [:apple::x:] [:penguin::heavy_check_mark:] haskellPackages.zip  :arrow_heading_up: 0 | 4
[ ] [:iphone::x:] [:apple::heavy_check_mark:] [:penguin::heavy_check_mark:] haskellPackages.cdar-mBound  :arrow_heading_up: 0 | 2
[ ] [:iphone::x:] [:apple::x:] [:penguin::x:] haskellPackages.headed-megaparsec  :arrow_heading_up: 0 | 2
[ ] [:iphone::heavy_check_mark:] [:apple::x:] [:penguin::heavy_check_mark:] haskellPackages.posix-socket  :arrow_heading_up: 0 | 2
[ ] [:iphone::x:] [:apple::heavy_check_mark:] [:penguin::heavy_check_mark:] haskellPackages.quic  :arrow_heading_up: 0 | 2
[ ] [:iphone::heavy_check_mark:] [:apple::x:] [:penguin::heavy_check_mark:] haskellPackages.hamid  :arrow_heading_up: 0 | 1
[ ] [:iphone::heavy_check_mark:] [:apple::x:] [:penguin::heavy_check_mark:] haskellPackages.hmatrix-morpheus  :arrow_heading_up: 0 | 1
[ ] [:iphone::heavy_check_mark:] [:apple::x:] [:penguin::heavy_check_mark:] haskellPackages.huckleberry  :arrow_heading_up: 0 | 1
[ ] [:iphone::x:] [:apple::heavy_check_mark:] [:penguin::heavy_check_mark:] haskellPackages.picosat  :arrow_heading_up: 0 | 1
[ ] [:iphone::heavy_check_mark:] [:apple::x:] [:penguin::heavy_check_mark:] haskellPackages.select  :arrow_heading_up: 0 | 1
[ ] [:iphone::heavy_check_mark:] [:apple::x:] [:penguin::heavy_check_mark:] haskellPackages.sysinfo  :arrow_heading_up: 0 | 1
[ ] [:iphone::heavy_check_mark:] [:apple::x:] [:penguin::heavy_check_mark:] haskellPackages.FractalArt
[ ] [:iphone::x:] [:apple::heavy_check_mark:] [:penguin::heavy_check_mark:] haskellPackages.HsASA
[ ] [:iphone::heavy_check_mark:] [:apple::x:] [:penguin::heavy_check_mark:] haskellPackages.chiphunk
[ ] [:iphone::heavy_check_mark:] [:apple::x:] [:penguin::heavy_check_mark:] haskellPackages.discount
[ ] [:iphone::heavy_check_mark:] [:apple::x:] [:penguin::heavy_check_mark:] haskellPackages.diskhash
[ ] [:iphone::heavy_check_mark:] [:apple::x:] [:penguin::heavy_check_mark:] haskellPackages.epub-tools
[ ] [:iphone::heavy_check_mark:] [:apple::x:] [:penguin::heavy_check_mark:] haskellPackages.float128
[ ] [:iphone::heavy_check_mark:] [:apple::x:] [:penguin::heavy_check_mark:] haskellPackages.gerrit
[ ] [:iphone::x:] [:penguin::heavy_check_mark:] haskellPackages.gnome-keyring
[ ] [:iphone::heavy_check_mark:] [:apple::x:] [:penguin::heavy_check_mark:] haskellPackages.gtk-traymanager
[ ] [:iphone::x:] [:apple::x:] [:penguin::x:] haskellPackages.has-transformers
[ ] [:iphone::heavy_check_mark:] [:apple::x:] [:penguin::heavy_check_mark:] haskellPackages.hid
[ ] [:iphone::heavy_check_mark:] [:apple::x:] [:penguin::heavy_check_mark:] haskellPackages.highlight
[ ] [:iphone::heavy_check_mark:] [:apple::x:] [:penguin::heavy_check_mark:] haskellPackages.hinotify-conduit
[ ] [:iphone::heavy_check_mark:] [:apple::x:] [:penguin::heavy_check_mark:] haskellPackages.hls-rename-plugin
[ ] [:iphone::x:] [:apple::heavy_check_mark:] [:penguin::heavy_check_mark:] haskellPackages.hq
[ ] [:iphone::heavy_check_mark:] [:apple::x:] [:penguin::heavy_check_mark:] haskellPackages.hs
[ ] [:iphone::heavy_check_mark:] [:apple::x:] [:penguin::heavy_check_mark:] haskellPackages.hsshellscript
[ ] [:iphone::heavy_check_mark:] [:apple::x:] [:penguin::heavy_check_mark:] haskellPackages.hssourceinfo
[ ] [:iphone::heavy_check_mark:] [:apple::x:] [:penguin::heavy_check_mark:] haskellPackages.ipcvar
[ ] [:iphone::x:] [:apple::x:] [:penguin::x:] haskellPackages.koji-install
[ ] [:iphone::heavy_check_mark:] [:apple::x:] [:penguin::heavy_check_mark:] haskellPackages.linux-framebuffer
[ ] [:iphone::heavy_check_mark:] [:apple::x:] [:penguin::heavy_check_mark:] haskellPackages.mediawiki2latex
[ ] [:iphone::heavy_check_mark:] [:apple::x:] [:penguin::heavy_check_mark:] haskellPackages.mercury-api
[ ] [:iphone::heavy_check_mark:] [:apple::x:] [:penguin::heavy_check_mark:] haskellPackages.nano-cryptr
[ ] [:iphone::heavy_check_mark:] [:apple::x:] [:penguin::heavy_check_mark:] haskellPackages.persistent-pagination
[ ] [:iphone::heavy_check_mark:] [:apple::x:] [:penguin::heavy_check_mark:] haskellPackages.ping-wrapper
[ ] [:iphone::x:] [:apple::heavy_check_mark:] [:penguin::heavy_check_mark:] haskellPackages.poker
[ ] [:iphone::heavy_check_mark:] [:apple::x:] [:penguin::heavy_check_mark:] haskellPackages.posix-timer
[ ] [:iphone::heavy_check_mark:] [:apple::x:] [:penguin::heavy_check_mark:] haskellPackages.procex
[ ] [:iphone::heavy_check_mark:] [:apple::x:] [:penguin::heavy_check_mark:] haskellPackages.pthread
[ ] [:iphone::x:] [:apple::heavy_check_mark:] [:penguin::heavy_check_mark:] haskellPackages.risc386
[ ] [:iphone::heavy_check_mark:] [:apple::x:] [:penguin::heavy_check_mark:] haskellPackages.sandwich-webdriver
[ ] [:iphone::heavy_check_mark:] [:apple::x:] [:penguin::heavy_check_mark:] haskellPackages.sfml-audio
[ ] [:iphone::heavy_check_mark:] [:apple::x:] [:penguin::heavy_check_mark:] haskellPackages.shared-memory
[ ] [:iphone::heavy_check_mark:] [:apple::x:] [:penguin::heavy_check_mark:] haskellPackages.tailfile-hinotify
[ ] [:iphone::x:] [:apple::heavy_check_mark:] [:penguin::heavy_check_mark:] haskellPackages.wiringPi
[ ] [:iphone::x:] [:apple::heavy_check_mark:] [:penguin::heavy_check_mark:] haskellPackages.x86-64bit
[ ] [:iphone::heavy_check_mark:] [:apple::x:] [:penguin::heavy_check_mark:] haskellPackages.xmonad-utils
[ ] [:iphone::heavy_check_mark:] [:apple::x:] [:penguin::heavy_check_mark:] haskellPackages.yoga
[ ] [:iphone::heavy_check_mark:] [:apple::x:] [:penguin::heavy_check_mark:] haskellPackages.zot
[ ] [:iphone::heavy_check_mark:] [:apple::x:] [:penguin::heavy_check_mark:] haskellPackages.zxcvbn-c

Unmaintained packages with failed dependency
41 job(s)

[ ] [:iphone::heavy_exclamation_mark:] [:apple::heavy_check_mark:] [:penguin::heavy_check_mark:] haskellPackages.jsonifier  :arrow_heading_up: 2 | 2
[ ] [:iphone::heavy_check_mark:] [:apple::heavy_exclamation_mark:] [:penguin::heavy_check_mark:] haskellPackages.sdp-io  :arrow_heading_up: 2 | 2
[ ] [:iphone::heavy_check_mark:] [:apple::heavy_exclamation_mark:] [:penguin::heavy_check_mark:] haskellPackages.nri-redis  :arrow_heading_up: 1 | 1
[ ] [:iphone::heavy_exclamation_mark:] [:apple::heavy_check_mark:] [:penguin::heavy_check_mark:] haskellPackages.opentelemetry-extra  :arrow_heading_up: 1 | 1
[ ] [:iphone::heavy_check_mark:] [:apple::heavy_exclamation_mark:] [:penguin::heavy_check_mark:] haskellPackages.orgmode-parse  :arrow_heading_up: 1 | 1
[ ] [:iphone::heavy_check_mark:] [:apple::heavy_exclamation_mark:] [:penguin::heavy_check_mark:] haskellPackages.sdp-hashable  :arrow_heading_up: 1 | 1
[ ] [:iphone::heavy_exclamation_mark:] [:apple::heavy_check_mark:] [:penguin::heavy_check_mark:] haskellPackages.PrimitiveArray  :arrow_heading_up: 0 | 35
[ ] [:iphone::heavy_exclamation_mark:] [:apple::heavy_check_mark:] [:penguin::heavy_check_mark:] haskellPackages.sized  :arrow_heading_up: 0 | 2
[ ] [:iphone::heavy_check_mark:] [:apple::heavy_exclamation_mark:] [:penguin::heavy_check_mark:] haskellPackages.keenser  :arrow_heading_up: 0 | 1
[ ] [:iphone::heavy_check_mark:] [:apple::heavy_exclamation_mark:] [:penguin::heavy_check_mark:] haskellPackages.antiope-es
[ ] cabal2nix-unstable

[:iphone::heavy_check_mark:] [:apple::heavy_check_mark:] [:penguin::heavy_check_mark:] haskell.packages.ghc8107
[:iphone::heavy_check_mark:] [:apple::heavy_check_mark:] [:penguin::heavy_check_mark:] haskell.packages.ghc884
[:iphone::heavy_check_mark:] [:apple::heavy_check_mark:] [:penguin::heavy_check_mark:] haskell.packages.ghc901
[:iphone::heavy_exclamation_mark:] [:apple::heavy_check_mark:] [:penguin::heavy_check_mark:] haskell.packages.ghc921
[:iphone::heavy_check_mark:] [:apple::heavy_check_mark:] [:penguin::heavy_check_mark:] haskellPackages

[ ] [:iphone::heavy_exclamation_mark:] [:apple::heavy_exclamation_mark:] [:penguin::heavy_check_mark:] haskellPackages.easytensor-vulkan
[ ] [:iphone::heavy_check_mark:] [:apple::heavy_exclamation_mark:] [:penguin::heavy_check_mark:] haskellPackages.exinst-aeson
[ ] [:iphone::heavy_check_mark:] [:apple::heavy_exclamation_mark:] [:penguin::heavy_check_mark:] haskellPackages.exinst-bytes
[ ] [:iphone::heavy_check_mark:] [:apple::heavy_exclamation_mark:] [:penguin::heavy_check_mark:] haskellPackages.exinst-cereal
[ ] [:iphone::heavy_check_mark:] [:apple::heavy_exclamation_mark:] [:penguin::heavy_check_mark:] haskellPackages.exinst-serialise
[ ] [:iphone::heavy_check_mark:] [:apple::heavy_exclamation_mark:] [:penguin::heavy_check_mark:] haskellPackages.fastparser
[ ] [:iphone::heavy_exclamation_mark:] [:apple::heavy_check_mark:] [:penguin::heavy_check_mark:] haskellPackages.hmatrix-nlopt
[ ] [:iphone::heavy_check_mark:] [:apple::heavy_exclamation_mark:] [:penguin::heavy_check_mark:] haskellPackages.nri-http
[ ] [:iphone::heavy_check_mark:] [:apple::heavy_exclamation_mark:] [:penguin::heavy_check_mark:] haskellPackages.nri-test-encoding
[ ] [:iphone::heavy_check_mark:] [:apple::heavy_exclamation_mark:] [:penguin::heavy_check_mark:] haskellPackages.opencv-extra
[ ] [:iphone::heavy_exclamation_mark:] [:apple::heavy_check_mark:] [:penguin::heavy_check_mark:] haskellPackages.opentelemetry-lightstep
[ ] [:iphone::heavy_check_mark:] [:apple::heavy_exclamation_mark:] [:penguin::heavy_check_mark:] haskellPackages.orgstat
[ ] [:iphone::heavy_check_mark:] [:apple::heavy_exclamation_mark:] [:penguin::heavy_check_mark:] haskellPackages.postgresql-replicant
[ ] [:iphone::heavy_exclamation_mark:] [:apple::heavy_check_mark:] [:penguin::heavy_check_mark:] haskellPackages.rounded
[ ] [:iphone::heavy_exclamation_mark:] [:apple::heavy_check_mark:] [:penguin::heavy_check_mark:] haskellPackages.rounded-hw
[ ] [:iphone::heavy_check_mark:] [:apple::heavy_exclamation_mark:] [:penguin::heavy_check_mark:] haskellPackages.scan-metadata
[ ] [:iphone::heavy_check_mark:] [:apple::heavy_exclamation_mark:] [:penguin::heavy_check_mark:] haskellPackages.sdp-binary
[ ] [:iphone::heavy_check_mark:] [:apple::heavy_exclamation_mark:] [:penguin::heavy_check_mark:] haskellPackages.sdp-deepseq
[ ] [:iphone::heavy_check_mark:] [:apple::heavy_exclamation_mark:] [:penguin::heavy_check_mark:] haskellPackages.sdp-quickcheck
[ ] [:iphone::heavy_check_mark:] [:apple::heavy_exclamation_mark:] [:penguin::heavy_check_mark:] haskellPackages.sdp4bytestring
[ ] [:iphone::heavy_check_mark:] [:apple::heavy_exclamation_mark:] [:penguin::heavy_check_mark:] haskellPackages.sdp4text
[ ] [:iphone::heavy_check_mark:] [:apple::heavy_exclamation_mark:] [:penguin::heavy_check_mark:] haskellPackages.sdp4unordered
[ ] [:iphone::heavy_check_mark:] [:apple::heavy_exclamation_mark:] [:penguin::heavy_check_mark:] haskellPackages.sdp4vector
[ ] [:iphone::heavy_exclamation_mark:] [:apple::heavy_check_mark:] [:penguin::heavy_check_mark:] haskellPackages.unicode-names
[ ] [:iphone::heavy_check_mark:] [:apple::heavy_exclamation_mark:] [:penguin::heavy_check_mark:] haskellPackages.xbattbar

Top 50 broken packages, sorted by number of reverse dependencies
50 job(s)
haskell98 :arrow_heading_up: 153
enumerator :arrow_heading_up: 56
derive :arrow_heading_up: 48
contiguous :arrow_heading_up: 46
MonadCatchIO-transformers :arrow_heading_up: 41
parseargs :arrow_heading_up: 41
bytesmith :arrow_heading_up: 36
data-lens :arrow_heading_up: 33
distributed-process :arrow_heading_up: 30
iteratee :arrow_heading_up: 29
jmacro :arrow_heading_up: 29
ip :arrow_heading_up: 26
either-unwrap :arrow_heading_up: 25
HList :arrow_heading_up: 23
SciBaseTypes :arrow_heading_up: 22
haskelldb :arrow_heading_up: 22
hsc3 :arrow_heading_up: 22
wxdirect :arrow_heading_up: 22
BiobaseTypes :arrow_heading_up: 21
wxc :arrow_heading_up: 21
biocore :arrow_heading_up: 20
polysemy-plugin :arrow_heading_up: 20
secp256k1-haskell :arrow_heading_up: 20
wxcore :arrow_heading_up: 20
attoparsec-enumerator :arrow_heading_up: 19
bytestring-show :arrow_heading_up: 19
numhask :arrow_heading_up: 19
wx :arrow_heading_up: 19
BiobaseENA :arrow_heading_up: 18
asn1-data :arrow_heading_up: 18
dbus-core :arrow_heading_up: 18
gtksourceview2 :arrow_heading_up: 18
BiobaseXNA :arrow_heading_up: 17
HGamer3D-Data :arrow_heading_up: 17
certificate :arrow_heading_up: 17
dbus-client :arrow_heading_up: 17
gconf :arrow_heading_up: 17
gtk-serialized-event :arrow_heading_up: 17
uuid-orphans :arrow_heading_up: 17
cuda :arrow_heading_up: 16
happstack-jmacro :arrow_heading_up: 16
manatee-core :arrow_heading_up: 16
monads-fd :arrow_heading_up: 16
murmur3 :arrow_heading_up: 16
tls-extra :arrow_heading_up: 16
ADPfusion :arrow_heading_up: 15
MaybeT :arrow_heading_up: 15
blaze-builder-enumerator :arrow_heading_up: 15
clash-prelude :arrow_heading_up: 15
hetero-dict :arrow_heading_up: 15

:arrow_heading_up:: The number of packages that depend (directly or indirectly) on this package (if any). If two numbers are shown the first (lower) number considers only packages which currently have enabled hydra jobs, i.e. are not marked broken. The second (higher) number considers all packages.
Report generated with maintainers/scripts/haskell/hydra-report.hs

authors: maralorn sternenseemann


text:
modemmanager: 1.18.2 -> 1.18.4

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/modemmanager/versions.
meta.description for modemmanager is: "WWAN modem manager, part of NetworkManager"
meta.homepage for modemmanager is: "https://www.freedesktop.org/wiki/Software/ModemManager/"
meta.changelog for modemmanager is: ""
Updates performed

Version update

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
/nix/store/46fi3jv4i1qnbmdn2xgxrpb7nl2halhl-modemmanager-1.18.4/bin/mmcli passed the binary check.
/nix/store/46fi3jv4i1qnbmdn2xgxrpb7nl2halhl-modemmanager-1.18.4/bin/ModemManager passed the binary check.
2 of 2 passed binary check by having a zero exit code.
2 of 2 passed binary check by having the new version present in output.
found 1.18.4 with grep in /nix/store/46fi3jv4i1qnbmdn2xgxrpb7nl2halhl-modemmanager-1.18.4
found 1.18.4 in filename of file in /nix/store/46fi3jv4i1qnbmdn2xgxrpb7nl2halhl-modemmanager-1.18.4

Rebuild report (if merged into master) (click to expand)

633 total rebuild path(s)

620 package rebuild(s)

620 x86_64-linux rebuild(s)
13 x86_64-darwin rebuild(s)

First fifty rebuilds by attrpath
ChowKick
CuboCore.coretoppings
adapta-gtk-theme
alfis
almanah
apostrophe
appgate-sdp
arc-theme
arx-libertatis
asciidoc-full
asciidoc-full-with-plugins
astroid
autosuspend
aws-workspaces
ayu-theme-gtk
balsa
bespokesynth
birdfont
blueman
bolt
bookworm
btrbk
bubblemail
calligra
calls
capitaine-cursors
cawbird
chatty
chrome-gnome-shell
cinnamon.cinnamon-common
cinnamon.cinnamon-control-center
cinnamon.cinnamon-gsettings-overrides
cinnamon.cinnamon-screensaver
cinnamon.iso-flags-png-320x420
cinnamon.iso-flags-svg
cinnamon.pix
cinnamon.xreader
citrix_workspace
citrix_workspace_20_04_0
citrix_workspace_20_06_0
citrix_workspace_20_09_0
citrix_workspace_20_10_0
citrix_workspace_20_12_0
citrix_workspace_21_01_0
citrix_workspace_21_03_0
citrix_workspace_21_06_0
citrix_workspace_21_08_0
citrix_workspace_21_09_0
claws-mail
clevis

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/46fi3jv4i1qnbmdn2xgxrpb7nl2halhl-modemmanager-1.18.4 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A modemmanager https://github.com/r-ryantm/nixpkgs/archive/0922e25d58e0e2bbc7dbc6de11181b5c8a629fb4.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/46fi3jv4i1qnbmdn2xgxrpb7nl2halhl-modemmanager-1.18.4
ls -la /nix/store/46fi3jv4i1qnbmdn2xgxrpb7nl2halhl-modemmanager-1.18.4/bin

Pre-merge build results
NixPkgs review skipped

Maintainer pings
cc @jtojnar for testing.

https://github.com/NixOS/nixpkgs/pull/155414

authors: jwygoda r-ryantm


text:
ati-drivers: use makeLibraryPath instead of concatStringsSep

Things done

[x] Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] OS X
[ ] Linux

[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

cc @vcunat

That's not a nice way to use makeLibraryPath. I'd suggest something like below, though it would still be better if someone checked running with the result before we merge it.
let # to fix highlighting
LD_LIBRARY_PATH = with xorg; stdenv.lib.makeLibraryPath
  [ libXrandr libXrender libXext libX11 libXinerama libSM libICE stdenv.cc.cc ];

Well the patch itself is fine, I'm running it now. I can cherry pick the better version after I've tried it out if you like.

Probably best fix this properly. Note that extraDRIlibs is also broken, but it's possible it's not needed (anymore).

It seems we still need extraDRIlibs, I at least got most applications going by this small change. It still isn't good since GLX doesn't seem supported on my card anymore, I'll try to do some more digging.

Upgrading the driver didn't help my case so there is likely some problem with the builder as the card should be supported.

Fixed in 046ee5ac3ffbc7e5daa706bd3ad405bd30c7aad5

authors: edwtjo vcunat