text:
关于table列宽可拖动问题

版本号：
2.1.4
问题描述：
由于table中会存在很多字段内容过长的问题，能否在全局集成table的列宽拖动功能
截图&代码：
友情提示： 未按格式要求发帖，会直接删掉。

新版会提供两套方案
一套样式 默认左右拖动不允许换行
一套样式 允许换行需要设置列宽度

authors: zhangdaiscott zzbsh

repo: zhangdaiscott/jeecg-boot


text:
系统用户逻辑删除代码

版本号：2.4.2
问题描述：
系统管理模块，用户删除会做逻辑删除，这一块的代码没有找到在哪里发生的变更，方便的话，可以告知一下吗
截图&代码：

友情提示： 未按格式要求发帖，会直接删掉。

source: gharchive/issue

license_type: permissive

license_source: bigquery


text:
🛑 ZY is down

In 20793b4, ZY (https://ziyuan.baidu.com) was down:

HTTP code: 0
Response time: 0 ms

Resolved: ZY is back up in 7ed3689.

repo: zhaodylan/uptime-ziyuan

license: MIT

license_source: github-api


text:
How to achieve the two-stage training strategy?

In your paper, you train the RFDA using the two-stage training strategy, but we can not find the two stage training files in the release code. So we are very confused that how to achieve the two-stage training strategy. Could you provide the training strategy files in detail?
Thank you very much!

You may implement it by your own :)

Modify L232 at https://github.com/zhaominyiz/RFDA-PyTorch/blob/main/train_rfda_ft.py

repo: zhaominyiz/RFDA-PyTorch


text:
希望增加多key流转使用功能

⚠ 搜索是否存在类似issue

[X] 我已经搜索过issues和disscussions，没有发现相似issue

总结
当使用企业微信接入自建应用后，免费key的次数限制导致无法使用，能不能增加多个key轮流，这样可以规避频率次数问题
举例
比如企业有300人使用，我设置50个key轮流使用，这样就可以保证每个人都可以收到内容
动机
No response

先使用付费key吧，频率是足够的

authors: lanvent xiaolietu

repo: zhayujie/chatgpt-on-wechat


text:
🛑 腾讯云 COS 节点 is down

In dc9a977, 腾讯云 COS 节点 (https://lisz.ink) was down:

HTTP code: 0
Response time: 0 ms

Resolved: 腾讯云 COS 节点 is back up in 135667d.

repo: zhonger/upptime


text:
🛑 腾讯云 COS 节点 is down

In eb65d67, 腾讯云 COS 节点 (https://lisz.ink) was down:

HTTP code: 0
Response time: 0 ms

Resolved: 腾讯云 COS 节点 is back up in 8d634c9.


text:
Cannot open any worlds

Monday, July 13, 2015
Boardwalk Version 1.1
Samsung Galaxy Tab 4 7.0 (SM-T230NU)
Android 4.4.2
No screenshot available, as it doesn't have anything.
When I try to open or create a world, Minecraft seems to "crash", even though it doesn't have a crash report. The saves aren't corrupt (at least I don't think they are) because I just tried to create a world and it crashed. Also, the saves worked the last time I opened them up! What could this be? Is anything corrupted? Do I need to delete anything? I don't want to restart with my saves because I worked so hard to start them! Help! (ASAP?)

NVM, the game works now! :D

I can't play it because I don't have a PC can I make a account from
boardwalk?
On Jul 14, 2015 9:58 AM, "Kristomayo (aka DotComCrash)" <
notifications@github.com> wrote:

Closed #205.
—
Reply to this email directly or view it on GitHub.

authors: kristomayo theblueslimegameing

repo: zhuowei/Boardwalk


text:
pls help me.. howto fix this

The creator hasn't updated it for 0.13. Please be patient so he can update it.
Besides, this isn't a BL issue, so please close it.

repo: zhuowei/MCPELauncher


text:
[Device Support Request] TS0601 Cover. Zemismart (Tuya) TZE204_1fuxihti curtain motor

Problem description
Tuya released new version of curtain motor with a name (manufacturer) TZE204_1fuxihti, device is same as described in #1245 and #1602 and #1953 but none of those solutions worked.
with a blank configuration it show no entities, once i create a quirk with following code there appear 3 buttons (open, close, stop). If I click any button then error message occur "Failed to call service cover/close_cover. Failed to close cover: <Status.UNSUP_MANUF_CLUSTER_COMMAND: 131>"
What is important - integration show if curtain is open or close, it could read state of curtain, just cannot send anything.
Solution description
Best solution would be upgrade of code which I send to allow remote communication
Screenshots/Video
Screenshot

Device signature
Device signature
{
  "home_assistant": {
    "installation_type": "Home Assistant OS",
    "version": "2023.11.2",
    "dev": false,
    "hassio": true,
    "virtualenv": false,
    "python_version": "3.11.6",
    "docker": true,
    "arch": "x86_64",
    "timezone": "Europe/Warsaw",
    "os_name": "Linux",
    "os_version": "6.1.59",
    "supervisor": "2023.11.3",
    "host_os": "Home Assistant OS 11.1",
    "docker_version": "24.0.6",
    "chassis": "embedded",
    "run_as_root": true
  },
  "custom_components": {
    "alarmo": {
      "version": "v1.9.10",
      "requirements": []
    },
    "hacs": {
      "version": "1.33.0",
      "requirements": [
        "aiogithubapi>=22.10.1"
      ]
    },
    "xiaomi_miot": {
      "version": "0.7.13",
      "requirements": [
        "construct>=2.10.56",
        "python-miio>=0.5.6",
        "micloud>=0.3"
      ]
    }
  },
  "integration_manifest": {
    "domain": "zha",
    "name": "Zigbee Home Automation",
    "after_dependencies": [
      "onboarding",
      "usb"
    ],
    "codeowners": [
      "@dmulcahey",
      "@adminiuga",
      "@puddly"
    ],
    "config_flow": true,
    "dependencies": [
      "file_upload"
    ],
    "documentation": "https://www.home-assistant.io/integrations/zha",
    "iot_class": "local_polling",
    "loggers": [
      "aiosqlite",
      "bellows",
      "crccheck",
      "pure_pcapy3",
      "zhaquirks",
      "zigpy",
      "zigpy_deconz",
      "zigpy_xbee",
      "zigpy_zigate",
      "zigpy_znp",
      "universal_silabs_flasher"
    ],
    "requirements": [
      "bellows==0.36.8",
      "pyserial==3.5",
      "pyserial-asyncio==0.6",
      "zha-quirks==0.0.106",
      "zigpy-deconz==0.21.1",
      "zigpy==0.59.0",
      "zigpy-xbee==0.19.0",
      "zigpy-zigate==0.11.0",
      "zigpy-znp==0.11.6",
      "universal-silabs-flasher==0.0.14",
      "pyserial-asyncio-fast==0.11"
    ],
    "usb": [
      {
        "vid": "10C4",
        "pid": "EA60",
        "description": "*2652*",
        "known_devices": [
          "slae.sh cc2652rb stick"
        ]
      },
      {
        "vid": "1A86",
        "pid": "55D4",
        "description": "*sonoff*plus*",
        "known_devices": [
          "sonoff zigbee dongle plus v2"
        ]
      },
      {
        "vid": "10C4",
        "pid": "EA60",
        "description": "*sonoff*plus*",
        "known_devices": [
          "sonoff zigbee dongle plus"
        ]
      },
      {
        "vid": "10C4",
        "pid": "EA60",
        "description": "*tubeszb*",
        "known_devices": [
          "TubesZB Coordinator"
        ]
      },
      {
        "vid": "1A86",
        "pid": "7523",
        "description": "*tubeszb*",
        "known_devices": [
          "TubesZB Coordinator"
        ]
      },
      {
        "vid": "1A86",
        "pid": "7523",
        "description": "*zigstar*",
        "known_devices": [
          "ZigStar Coordinators"
        ]
      },
      {
        "vid": "1CF1",
        "pid": "0030",
        "description": "*conbee*",
        "known_devices": [
          "Conbee II"
        ]
      },
      {
        "vid": "10C4",
        "pid": "8A2A",
        "description": "*zigbee*",
        "known_devices": [
          "Nortek HUSBZB-1"
        ]
      },
      {
        "vid": "0403",
        "pid": "6015",
        "description": "*zigate*",
        "known_devices": [
          "ZiGate+"
        ]
      },
      {
        "vid": "10C4",
        "pid": "EA60",
        "description": "*zigate*",
        "known_devices": [
          "ZiGate"
        ]
      },
      {
        "vid": "10C4",
        "pid": "8B34",
        "description": "*bv 2010/10*",
        "known_devices": [
          "Bitron Video AV2010/10"
        ]
      }
    ],
    "zeroconf": [
      {
        "type": "_esphomelib._tcp.local.",
        "name": "tube*"
      },
      {
        "type": "_zigate-zigbee-gateway._tcp.local.",
        "name": "*zigate*"
      },
      {
        "type": "_zigstar_gw._tcp.local.",
        "name": "*zigstar*"
      },
      {
        "type": "_uzg-01._tcp.local.",
        "name": "uzg-01*"
      },
      {
        "type": "_slzb-06._tcp.local.",
        "name": "slzb-06*"
      }
    ],
    "is_built_in": true
  },
  "data": {
    "ieee": "**REDACTED**",
    "nwk": 57680,
    "manufacturer": "_TZE204_1fuxihti",
    "model": "TS0601",
    "name": "_TZE204_1fuxihti TS0601",
    "quirk_applied": true,
    "quirk_class": "curt_v5.TuyaCover0601_GP",
    "quirk_id": null,
    "manufacturer_code": 4417,
    "power_source": "Mains",
    "lqi": 136,
    "rssi": -66,
    "last_seen": "2023-11-15T20:24:53",
    "available": true,
    "device_type": "Router",
    "signature": {
      "node_descriptor": "NodeDescriptor(logical_type=<LogicalType.Router: 1>, complex_descriptor_available=0, user_descriptor_available=0, reserved=0, aps_flags=0, frequency_band=<FrequencyBand.Freq2400MHz: 8>, mac_capability_flags=<MACCapabilityFlags.FullFunctionDevice|MainsPowered|RxOnWhenIdle|AllocateAddress: 142>, manufacturer_code=4417, maximum_buffer_size=66, maximum_incoming_transfer_size=66, server_mask=10752, maximum_outgoing_transfer_size=66, descriptor_capability_field=<DescriptorCapability.NONE: 0>, *allocate_address=True, *is_alternate_pan_coordinator=False, *is_coordinator=False, *is_end_device=False, *is_full_function_device=True, *is_mains_powered=True, *is_receiver_on_when_idle=True, *is_router=True, *is_security_capable=False)",
      "endpoints": {
        "1": {
          "profile_id": "0x0104",
          "device_type": "0x0202",
          "input_clusters": [
            "0x0000",
            "0x0004",
            "0x0005",
            "0x0102",
            "0xef00"
          ],
          "output_clusters": [
            "0x000a",
            "0x0019"
          ]
        },
        "242": {
          "profile_id": "0xa1e0",
          "device_type": "0x0061",
          "input_clusters": [],
          "output_clusters": [
            "0x0021"
          ]
        }
      },
      "manufacturer": "_TZE204_1fuxihti",
      "model": "TS0601"
    },
    "active_coordinator": false,
    "entities": [
      {
        "entity_id": "cover.kar1_cover",
        "name": "_TZE204_1fuxihti TS0601"
      }
    ],
    "neighbors": [],
    "routes": [],
    "endpoint_names": [
      {
        "name": "WINDOW_COVERING_DEVICE"
      },
      {
        "name": "PROXY_BASIC"
      }
    ],
    "user_given_name": "KAR1",
    "device_reg_id": "eb8c73609b96a2d9b9a2fc2acdffb2bb",
    "area_id": "sypialnia",
    "cluster_details": {
      "1": {
        "device_type": {
          "name": "WINDOW_COVERING_DEVICE",
          "id": 514
        },
        "profile_id": 260,
        "in_clusters": {
          "0x0000": {
            "endpoint_attribute": "basic",
            "attributes": {
              "0x0001": {
                "attribute_name": "app_version",
                "value": 74
              },
              "0x0004": {
                "attribute_name": "manufacturer",
                "value": "_TZE204_1fuxihti"
              },
              "0x0005": {
                "attribute_name": "model",
                "value": "TS0601"
              }
            },
            "unsupported_attributes": {}
          },
          "0x0004": {
            "endpoint_attribute": "groups",
            "attributes": {},
            "unsupported_attributes": {}
          },
          "0x0005": {
            "endpoint_attribute": "scenes",
            "attributes": {},
            "unsupported_attributes": {}
          },
          "0xef00": {
            "endpoint_attribute": "tuya_manufacturer",
            "attributes": {},
            "unsupported_attributes": {}
          },
          "0x0102": {
            "endpoint_attribute": "window_covering",
            "attributes": {
              "0x0008": {
                "attribute_name": "current_position_lift_percentage",
                "value": 0
              }
            },
            "unsupported_attributes": {
              "0x0008": {
                "attribute_name": "current_position_lift_percentage"
              },
              "0x0009": {
                "attribute_name": "current_position_tilt_percentage"
              }
            }
          }
        },
        "out_clusters": {
          "0x000a": {
            "endpoint_attribute": "time",
            "attributes": {},
            "unsupported_attributes": {}
          },
          "0x0019": {
            "endpoint_attribute": "ota",
            "attributes": {},
            "unsupported_attributes": {}
          }
        }
      },
      "242": {
        "device_type": {
          "name": "PROXY_BASIC",
          "id": 97
        },
        "profile_id": 41440,
        "in_clusters": {},
        "out_clusters": {
          "0x0021": {
            "endpoint_attribute": "green_power",
            "attributes": {},
            "unsupported_attributes": {}
          }
        }
      }
    }
  }
}

Diagnostic information
Diagnostic information
[Paste the diagnostic information here]

Logs
Logs
Logger: homeassistant.components.websocket_api.http.connection
Source: components/websocket_api/commands.py:230
Integration: Home Assistant WebSocket API (documentation, issues)
First occurred: 19:46:46 (12 occurrences)
Last logged: 20:23:52

[139681897782592] Failed to close cover: <Status.UNSUP_MANUF_CLUSTER_COMMAND: 131>
[139682099123136] Failed to close cover: <Status.UNSUP_MANUF_CLUSTER_COMMAND: 131>
[139681737586624] Failed to close cover: <Status.UNSUP_MANUF_CLUSTER_COMMAND: 131>
[139681734085440] Failed to close cover: <Status.UNSUP_MANUF_CLUSTER_COMMAND: 131>
[139681735934912] Failed to close cover: <Status.UNSUP_MANUF_CLUSTER_COMMAND: 131>
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/components/websocket_api/commands.py", line 230, in handle_call_service
    await hass.services.async_call(
  File "/usr/src/homeassistant/homeassistant/core.py", line 2035, in async_call
    response_data = await coro
                    ^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/core.py", line 2072, in _execute_service
    return await target(service_call)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/helpers/entity_component.py", line 235, in handle_service
    return await service.entity_service_call(
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/helpers/service.py", line 876, in entity_service_call
    response_data = await _handle_entity_call(
                    ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/helpers/service.py", line 948, in _handle_entity_call
    result = await task
             ^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/components/zha/cover.py", line 174, in async_close_cover
    raise HomeAssistantError(f"Failed to close cover: {res[1]}")
homeassistant.exceptions.HomeAssistantError: Failed to close cover: <Status.UNSUP_MANUF_CLUSTER_COMMAND: 131>

Custom quirk
Custom quirk
"""Tuya based cover and blinds."""
from zigpy.profiles import zha
from zigpy.zcl.clusters.general import Basic, Groups, Identify, OnOff, Ota, Scenes, Time, GreenPowerProxy
from zhaquirks.const import (
    DEVICE_TYPE,
    ENDPOINTS,
    INPUT_CLUSTERS,
    MODELS_INFO,
    OUTPUT_CLUSTERS,
    PROFILE_ID,
)
from zhaquirks.tuya import (
    TuyaManufacturerWindowCover,
    TuyaManufCluster,
    TuyaWindowCover,
    TuyaWindowCoverControl,
)

class TuyaCover0601_GP(TuyaWindowCover):
    """Tuya blind controller device."""

    signature = {
        # "node_descriptor": "NodeDescriptor(byte1=2, byte2=64, mac_capability_flags=128, manufacturer_code=4098,
        #                    maximum_buffer_size=82, maximum_incoming_transfer_size=82, server_mask=11264,
        #                    maximum_outgoing_transfer_size=82, descriptor_capability_field=0)",
        # "endpoints": {
        # "1": { "profile_id": 260, "device_type": "0x0051", "in_clusters": [ "0x0000", "0x0004","0x0005","0xef00"], "out_clusters": ["0x000a","0x0019"] }
        # },
        # "manufacturer": "_TZE200_zah67ekd",
        # "model": "TS0601",
        # "class": "zigpy.device.Device"
        # }
        MODELS_INFO: [
            ("_TZE204_1fuxihti", "TS0601"),
        ],
        ENDPOINTS: {
            1: {
                PROFILE_ID: zha.PROFILE_ID,
                DEVICE_TYPE: zha.DeviceType.SMART_PLUG,
                INPUT_CLUSTERS: [
                    Basic.cluster_id,
                    Groups.cluster_id,
                    Scenes.cluster_id,
                    TuyaManufCluster.cluster_id,
                ],
                OUTPUT_CLUSTERS: [Time.cluster_id, Ota.cluster_id],
            },
            # <SimpleDescriptor endpoint=242 profile=41440 device_type=97
            # input_clusters=[]
            # output_clusters=[33]
            242: {
                PROFILE_ID: 41440,
                DEVICE_TYPE: 97,
                INPUT_CLUSTERS: [],
                OUTPUT_CLUSTERS: [GreenPowerProxy.cluster_id],
            },
        },
    }

    replacement = {
        ENDPOINTS: {
            1: {
                DEVICE_TYPE: zha.DeviceType.WINDOW_COVERING_DEVICE,
                INPUT_CLUSTERS: [
                    Basic.cluster_id,
                    Groups.cluster_id,
                    Scenes.cluster_id,
                    TuyaManufacturerWindowCover,
                    TuyaWindowCoverControl,
                ],
                OUTPUT_CLUSTERS: [Time.cluster_id, Ota.cluster_id],
            },
            242: {
                PROFILE_ID: 41440,
                DEVICE_TYPE: 97,
                INPUT_CLUSTERS: [],
                OUTPUT_CLUSTERS: [GreenPowerProxy.cluster_id],
            },
        }
    }

Additional information
No response

My model is TZE200_xu4a5rhj and my situation is the same as you are.
It showed no entities at first, so I asked for support and add the custom quirk porvided by @javicalle.
Then the 3 buttons appeared, but cannot be controlled at all.
https://github.com/zigpy/zha-device-handlers/issues/2483#issue-1813225750
I replyed my debug log and waited for a few months until now.
No further tips or instructions.
Seems like the tuya cover motor do have a problem with ZHA.
https://github.com/zigpy/zha-device-handlers/issues/2766#issue-2004521949
I found the same issue here.
I tried with zigbee2mqtt, it works perfectly.
But I change back to ZHA because my ohter devices works more stable with ZHA.
Hope someone can help this out.

Also have _TZE204_1fuxihti, but i can't understand how make it works in ZHA.

repo: zigpy/zha-device-handlers


text:
undefined method `scoped'

Hi,
I'm developing a Rails 3.1.1 application. An ActiveRecord model belongs to an ActiveHash model. When I try to follow the relation in this way (AR -> AH), I get the following error:
undefined method 'scoped'
I hope this could help you,
Camille

Yeah - that's a known issue that will likely not be fixed.  Please make sure you are on the latest version and see the "Referencing ActiveHash objects from ActiveRecord Associations" in the README - you can use the belongs_to_active_hash method.

authors: camilleroux zilkey

license: mit


text:
Add Support for Visualizing Dynamic Schema Fields in Attu

Describe the feature:
The proposed feature would involve enhancing the Attu interface to support the visualization of dynamic schema fields in Milvus collections. Currently, collections in Milvus can evolve with dynamic schemas, but these changes are not reflected in the Attu UI. The feature would allow Attu to display all fields of a collection, including those that are dynamically added or altered after the initial schema is set up.
Describe a specific use case for the feature:
In the current scenario, when dynamic fields are added to a Milvus collection, the only way to view and interact with these fields is through the Milvus SDK. Developers and data scientists must write and execute custom code to retrieve and view this information, which can be cumbersome and time-consuming. For example, when a new set of features is added to a collection as part of a data update process, users have to rely on the SDK to access the updated schema and the new data points.
This process lacks the convenience and immediacy of a visual tool. With the addition of this feature to Attu, users would be able to immediately see the updated schema and corresponding data directly within the Attu interface, without the need for additional coding. This would streamline workflows for users who need to manage and explore evolving datasets, making it easier to verify and understand the structure of their data in real-time.

which version of attu are you using?

I apologize for still using version 2.3.1, I didn't notice the update.

authors: HantaoCai shanghaikid

repo: zilliztech/attu


text:
[API]There is no state_code field in data for get_restore API when restore is ongoing

When the restore is completed, the state code is 2, but when the restore is ongoing,  there is no state code field.
{
    "requestId": "c41a39b2-6fbd-11ed-824c-acde48001122",
    "msg": "success",
    "data": {
        "id": "ed89a252-6fbc-11ed-824c-acde48001122",
        "start_time": 1669709274
    }
}

The API get_backup will return state_code as 1 when creating  backup is ongoing

nice catch. fixed in #28

authors: wayblink zhuwenxing

repo: zilliztech/milvus-backup


text:
milvus_cli show collection does not support json schema

as picture show. when i run 'show collection -c $collection_name'.i got different response. question collection schema not have json filed. openai_amc_question have json field like 'FieldSchema(name='question_meta', dtype=DataType.JSON),'
please tell me what happened?

Milvus cli version: 0.4.0
Pymilvus version: 2.3.0

@younger027  sure, will update soon

@younger027 please try 0.4.1


text:
Exception: OperationException(linkException: ResponseFormatException(originalException: FormatException: Unexpected character (at character 1)

Postman.

example code of subs
void _onErrorSubscription(Object error, StackTrace stackTrace) {
  print('Listen Subscription Error: $error & $stackTrace');
}

void _onDoneSubscription() {
  print('Listen Subscription Done');
}

void _subs() {
      const checkOutSubscription = r'''
subscription MySubscription {
  onUpdateCheckout(userId: $userId) {
    createdAt
    checkoutId
    maxAllowedAmount
    maxAvailableAmount
    message
    state
    trancheId
  }
}
''';

      final options = SubscriptionOptions(
        document: gql(checkOutSubscription),
        variables: {
          "userId": userId,
        },
      );

      final baseUrl = Config.baseUrl + endPoint;
      final HttpLink link = HttpLink(baseUrl);

      Map<String, String> authHeader = {};
      authHeader['Authorization'] = 'cognitoIdToken';
      authHeader['host'] = 'apiHost';
      final encodedHeader = toBase64(authHeader);
      final WebSocketLink wsLink = WebSocketLink(
        ApiEndpoint.webSocket(encodedHeader), // the format is same like in the postman: {{websocketUrl}}?header=$encodedHeader&payload=e30=
        config: const SocketClientConfig(
          autoReconnect: true,
          inactivityTimeout: Duration(seconds: 60),
        ),
        subProtocol: GraphQLProtocol.graphqlWs,
      );

      final Link linkSplitted = link.split(
        (request) => request.isSubscription,
        wsLink,
        link,
      );

      final client = GraphQLClient(
        link: linkSplitted,
        cache: GraphQLCache(),
        alwaysRebroadcast: true,
      );

      final prettyStringRequest =
          const JsonEncoder.withIndent('  ').convert(options.variables);
      print('Request : $prettyStringRequest\n');

      final result = client.subscribe(options);
      Map<String, dynamic> data = {};
      result.listen(
        (event) {
          print('Listen Subscription: Active');
          if (event.hasException) {
            print(
              'Listen Subscription Exception: ${event.exception.toString()}',
            );
          }
          data = event.data ?? {};
          print('Listen Subscription Data: $data');
        },
        onDone: _onDoneSubscription,
        onError: _onErrorSubscription,
        cancelOnError: true,
      );
}

logs
flutter: Request : {
  "userId": "244648"
}

flutter: Listen Subscription: Active

flutter: Listen Subscription Exception: OperationException(linkException: ResponseFormatException(originalException: FormatException: Unexpected character (at character 1)
Bad Request
^
, originalStackTrace: #0      _ChunkedJsonParser.fail (dart:convert-patch/convert_patch.dart:1383:5)
#1      _ChunkedJsonParser.parseNumber (dart:convert-patch/convert_patch.dart:1250:9)
#2      _ChunkedJsonParser.parse (dart:convert-patch/convert_patch.dart:915:22)
#3      _parseJson (dart:convert-patch/convert_patch.dart:35:10)
#4      JsonDecoder.convert (dart:convert/json.dart:610:36)
#5      JsonCodec.decode (dart:convert/json.dart:216:41)
#6      HttpLink._defaultHttpResponseDecoder (package:gql_http_link/src/link.dart:48:12)
#7      HttpLink._parseHttpResponse (package:gql_http_link/src/link.dart:117:53)
#8      HttpLink.request (package:gql_http_link/src/link.dart:78:28)
<asynchronous suspension>
), graphqlErrors: [])

flutter: Listen Subscription Data: {}

flutter: Listen Subscription Done

You server is returning Bad Request and the library can not parse it.
Not a library problem if you are not constructing a proper request.

Hi @robertoestivill @vincenzopalazzo do u have any example of subs implementation? seems ur documentation not proper yet. Open an issue for that one as well here: https://github.com/zino-hofmann/graphql-flutter/issues/1349

Update.
Now i saw this on the log.
flutter: Initialising connection
flutter: Disconnected from websocket.
flutter: Initialising connection
flutter: Disconnected from websocket.
flutter: Initialising connection

Mean successfully connecting to subscription/websocket?

you may are setting the wrong ws protocol?

so this one (https://github.com/zino-hofmann/graphql-flutter/issues/1350#issuecomment-1640470400) still not connected to subscription/websocket?

the ws has different protocols

the ws has different protocols

hmm what u mean diff protocols? or do u have any idea what code should i check?
Coz basically, i just added this code.
final AuthLink authLink =
          AuthLink(getToken: () => 'Bearer $currentToken');

      final Link linkSplitted = authLink.split(
        (request) => request.isSubscription,
        webSocketLink,
        httpLink,
      );

and the result is this: https://github.com/zino-hofmann/graphql-flutter/issues/1350#issuecomment-1640470400
If I remove that like this one.
final Link linkSplitted = httpLink.split(
        (request) => request.isSubscription,
        webSocketLink,
        httpLink,
      );

I will got an error like this one: https://github.com/zino-hofmann/graphql-flutter/issues/1350#issue-1770000167

this https://github.com/zino-hofmann/graphql-flutter/pull/1206 should have a basic configuration of the ws, also please check the documentation and also research about grahql ws protocols

let me check ur example: https://github.com/zino-hofmann/graphql-flutter/tree/main/examples/starwars
idk why prev i dont see it.

Hi, @vincenzopalazzo @robertoestivill have a question.
In Postman, if I don't send a Message by clicked the Send button after successfully connected to the wss. I also can't get the data. The result is the same as this one (https://github.com/zino-hofmann/graphql-flutter/issues/1350#issuecomment-1640470400), only successfully connected or disconnected.

So my question is, how can I send a Message from the app side using this package?

repo: zino-hofmann/graphql-flutter


text:
checkDocument is not a function

Trying to write my first tests with this tool (seems really neat), but I'm running into some issues recreating the example projects I've seen (mainly this one: https://github.com/zinserjan/webdriverio-example/blob/master/test/diff-test.js).
relevant package.json items:
"wdio-visual-regression-service": "^0.9.0",
"webdriverio": "^5.11.6"

Posting the configuration below, let me know if anything else helps.
var path = require('path');
var VisualRegressionCompare = require('wdio-visual-regression-service/compare');

function getScreenshotName(basePath) {
    return function(context) {
        var testName = context.test.title;
        var resolution = context.meta.width || context.meta.orientation || 'unknown';
        var browserVersion = parseInt(/\d+/.exec(context.browser.version)[0]);
        var browserName = context.browser.name;

        return path.join(basePath, `${testName}_${resolution}_${browserName}_v${browserVersion}.png`);
      };
}

exports.config = {
    runner: 'local',
    path: '/',
    specs: [
       // 'test/specs/basic.js',
        'test/specs/visualRegression.js'
    ],
    exclude: [
    ],
    //
    maxInstances: 10,
    //
    capabilities: [{
        maxInstances: 5,
        browserName: 'chrome',
    }],
    logLevel: 'info',
    bail: 0,
    screenshotPath: './errorShots/',
    baseUrl: 'http://locally.hostedurl.com',
    waitforTimeout: 10000,
    connectionRetryTimeout: 90000,
    connectionRetryCount: 3,
    services: ['chromedriver', 'visual-regression'],
    visualRegression: {
        compare: new VisualRegressionCompare.LocalCompare({
            referenceName: getScreenshotName(path.join(process.cwd(), 'screenshots/reference')),
            screenshotName: getScreenshotName(path.join(process.cwd(), 'screenshots/screen')),
            diffName: getScreenshotName(path.join(process.cwd(), 'screenshots/diff')),
            misMatchTolerance: 0.11
          }),
          viewportChangePause: 1000,
          viewports: [{ width: 320, height: 480 }, { width: 480, height: 320 }, { width: 1024, height: 768 }],
          orientations: ['landscape', 'portrait'],
    },
    plugins: {
        'wdio-screenshot': {},
    },
    framework: 'mocha',
    reporters: ['spec'],
    mochaOpts: {
        ui: 'bdd',
        timeout: 60000
    }

}

Same issue

authors: Wexx myfailemtions


text:
Use the companion objects for Clock and Console

Looks like there was some carry over from the transition. With Clock and Console being used as parameters instead of directly using their companion objects. I also tried to convert the Console.printLine usage to ZIO.log but it makes one of the tests time out so 🤷 .

Thanks! Will take a look at using ZIO.log instead.

source: gharchive/pull-request

authors: paulpdaniels zalbia

repo: zio/zio-webhooks


text:
No module named 'deepke'

Describe the question

A clear and concise description of what the question is.
我按照步骤执行re/documen/run.py时，报异常：
Traceback (most recent call last):
File "run.py", line 13, in
from deepke.relation_extraction.document import *
ModuleNotFoundError: No module named 'deepke'

Environment (please complete the following information):

OS: [e.g. mac / window]
Python Version [e.g. 3.6]
OS: UBUNTU
Python：3.8.13（anaconda）

Screenshots

If applicable, add screenshots to help explain your problem.

Additional context

Add any other context about the problem here.

请安装deepke环境

麻烦您参考Quick Start按照下环境和相关包

authors: dptong xxupiano zxlzr

repo: zjunlp/DeepKE


text:
Add slippage protection for uniswap

[x] Add slippage protection
[x] Add a new template for Uniswap extension

Currently I have defined the slippage basis point as a constant. We can make it a user-defined variable in the future.

Thank you for adding the slippage protection!
You used {sqrtPriceLimitX96} in the new template of the uniswap extension, but our contract supports only {tokenAmount}, {amount}, {string}, {uint}, {int}, {address}, {recipient}.
If sqrtPriceLimitX96 is the unsigned integer, could you use {uint} instead and decode the subjectParams[1] into (uint256)?
Also, please define the template in such a way that it is natural for users to write the template values in the subject, e.g., "Swap 0.01 ETH to DAI under 23 sqrt price limit."

Thank you for adding the slippage protection! You used {sqrtPriceLimitX96} in the new template of the uniswap extension, but our contract supports only {tokenAmount}, {amount}, {string}, {uint}, {int}, {address}, {recipient}. If sqrtPriceLimitX96 is the unsigned integer, could you use {uint} instead and decode the subjectParams[1] into (uint256)? Also, please define the template in such a way that it is natural for users to write the template values in the subject, e.g., "Swap 0.01 ETH to DAI under 23 sqrt price limit."

Sure. Let me update the implementation. Thank you for reviewing.

authors: SoraSuegami wshino

repo: zkemail/email-wallet


text:
Metal building pipeline enhancement

Metal shaders for macOS compile with build.rs
metallib stored within std out dir rather than in the git repo under hardcoded path.
Prebuilt library and script deleted.
build.rs handles conditional debug symbols injection into metal lib by setting [profile.release]\n debug = true in Cargo.toml

PR is converted to draft due to iOS pipeline haven't been implemented yet.

@moven0831 I haven't removed all.metal file yet, to avoid unnecessary conflicts with your pending PR #13 But it's the matter of changing a single function in the build current pipeline, so it won't take any long to do it afterwards.
PR is ready for review

repo: zkmopro/gpu-acceleration


text:
二月份有29天的时候，选中会有bug

已修复，请更新到版本1.2.9

authors: YpchenLove zkytech

repo: zkytech/taro-calendar-customizable


text:
Game Crash on new Planet/World load w/ Mod'd Biome

Version of Advanced Rocketry
1.12.2-1.5.0-131
Have you verified this is an issue in the latest unstable build
yes
Version of LibVulpes
1.12.2-0.4.0-52
Version of Minecraft
1.12.2
Crash report or log (if applicable)
https://paste.dimdev.org/meruhugemo.mccrash
Description of the problem
Game crash when loading new Planet/World with mod'd biome. Tested w/ Traverse Mod & Project: Vibrant Journeys Mod.
Deleting both Dim file and planetDefs from saves->[world-name]->advRocketry and replacing Mod'd biome with Vanilla biome  nets a loaded world without crash.
Edit: With Vanilla biome is include inside tag w/ Mod'd biome, no crash happens, but mod's biome does not gen either,
Specific code used to generate Planet:
<planet name="Dunes" DIMID="20">         <isKnown>false</isKnown>         <fogColor>1.0,1.0,1.0</fogColor> 	<skyColor>0.8,0.7409648,0.33749646</skyColor> 	<gravitationalMultiplier>100</gravitationalMultiplier> 	<orbitalDistance>134</orbitalDistance> 	<orbitalPhi>-1</orbitalPhi> 	<rotationalPeriod>25499</rotationalPeriod> 	<atmosphereDensity>166</atmosphereDensity> 	<biomeIds>traverse:mountainous_desert</biomeIds> 	<oceanBlock>minecraft:lava</oceanBlock>     </planet>

Issue was related to a improper biome id. However, without another valid biome id included in the biomeIds tag, this issue would persist.

So after revisiting this with more time, I have had mixed results getting certain Mod Biomes to load and NOT crash the Game. Using the TellMe Mod to get Biome ID's, I used a defalt planet type and single biomes for testing. I tested both the biome id number, as well as the biome id name. Both resulted in a game crash. Using the biome id number, the planetDef.xml in the saves folder, returns the proper biome id name confirming proper naming. I deleted both the world file, and the planetDefs.xml from the saves folder each time.
I am getting game crashes from both Traverse Mod Biomes, and Project: Vibrant Journeys Biomes. Multiple biomes were tested.
I was able to get both Stygian Mod biomes to load properly, as well as all BOP biomes,
Crash Report: https://pastebin.com/grAtAt36

Some info that MAY help"Noobanidus: "int weight = nextInt(totalWeight / 10) * 10;" I think it has to do with that"


text:
ZNC 1.6.1 release archive doesn't contain submodules

make is not happening on release archive (https://github.com/znc/znc/releases/tag/znc-1.6.1):
root@services163:~/znc-znc-1.6.1/znc# make
Packing man page znc.1.gz...
Packing man page znc-buildmod.1.gz...
It looks like git submodules are not initialized. Run: git submodule update --init --recursive
make: *** [third_party/Csocket/Csocket.h] Error 1

The issue is: release archive does not contain '.git' folder, so there is no way to do git submodule update --init --recursive.
Solved by using not release archive, but git cloning particular release commit (in this case: aa6e7e7).
Could be reference to #806

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/27025526-znc-1-6-1-release-archive-doesn-t-contain-submodules?utm_campaign=plugin&utm_content=tracker%2F1759&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F1759&utm_medium=issues&utm_source=github).

This issue is invalid and caused by ZNC using submodules which GitHub doesn't support with those zip/tarballs, but they cannot be disabled.
Please download ZNC from http://znc.in/releases/ instead.

I see. Thanks =]
Probably there is no reason to keep releases on GitHub then.

Probably there is no reason to keep releases on GitHub then.

I was unclear at first sorry, the tar/zip files are automatically generated by GitHub and they cannot be disabled. I have requested disabling them at least once from GitHub support.
This issue doesn't affect only ZNC, but also Atheme, https://github.com/atheme/atheme/issues/382.

@Mikaela
Thanks for explanation. Sorry for taking your time then :sweat_smile:

You're welcome, no problem. Could you close this next to the comment box?

authors: Mikaela michaelforge

repo: znc/znc


text:
Firebase analytics

Description
Firebase Analytics: As a move away from Amplitude, this PR integrates the app with firebase analytics for staging.

[x] Add Google-services.plist file to ios native folder
[x] Add google-services.json file to android native folder
[x] Install firbase base and analytics libraries
[x] Integrate analytics to react native navigation

We keep both Amplitude and Firebase for the moment to see that the data / metrics we see on both are the same to confirm the integration works correctly. After confirmation, we should go ahead and remove/archive Amplitude altogether (it would be nice to keep their historical data but I am not aware if this is possible - I would be surprised if its not).
On what platform have you tested the change?

[ ] Android - Emulator
[ ] Android - Physical device
[x] iOS - Emulator
[x] iOS - Physical device

Out of scope and potential follow-up
In a future PR: transition event tracking to Firebase Analytics on top of just page tracking.
Screenshots

Checklist (for submission)

[x] Analytics/tracking events have been added (if relevant)
[x] Screenshot of analytics capture on stage

Checklist (for reviewers)

[x] For Developers: Run branch on local, login with your user, and swipe through screens. Go to the console and confirm your screen views were tracked.
[x] On viewing a screen there are no crashes (i.e atleast view each page once)

updated the version numbers to 2.7.2 now

repo: zoe/covid-tracker-react-native


text:
role variables got removed?

https://github.com/zoitech/terraform-aws-saml/commit/c5ad8acbddd63cc1a254d6f702eff37a47c54104
logic/documentation no longer match.
Looks like something in PR10 didn't get merged properly.

Thank you for reporting. We will have a look.

Hi @rismoney ,
could you be more specific? Where is the mismatch?
Thanks

I've submitted https://github.com/zoitech/terraform-aws-saml/pull/16 to fix this

authors: Geartrixy derBroBro rismoney shmick

repo: zoitech/terraform-aws-saml


text:
add requires to get tests passing with recent library versions

ruby 3.2
bundler 2.4
power_assert (2.0.3)
rack (3.0.8)
rack-test (2.1.0)
  rack (>= 1.3)
rake (13.0.6)
test-unit (3.6.1)
  power_assert

resolved in https://github.com/zombocom/rack-timeout/commit/0315a6a6a5c480309e70f0438ffff7a37c9b1d18

@wuputah note that this PR also adds a couple requires https://github.com/zombocom/rack-timeout/pull/205/files#diff-ba37813ca277c227a74a372479b7b05b7f3ff085d890ab708f80d62573efdb7a

authors: jjb wuputah

repo: zombocom/rack-timeout


text:
Can't enter same data for county and city

A user reports that he tried to enter "San Francisco" for both city and county (since San Fran is both the city and the county), but got rejected.
Can we fix this? Sometimes the city name is indeed the same as the county.
http://talk.notesfromnature.org/#/boards/BNN0000002/discussions/DNN00003o3?page=1&comment_id=54e3b2286975267adc0000f0

@DarrenMcRoy  -- Assuming I understand correctly, San Fransisco would go into the County drop down and then into the (free text) Locality field. There is no City field.
I don't see what the bug is. Am I missing something?

Hm. I'm going to check and try to get more detail from the user.

Closing pending clarification.

authors: DarrenMcRoy chrissnyder denslowm

repo: zooniverse/notesFromNature


text:
Indiya

My account 😭😭

Pelish my account

My account 😭😭

My account 😔😔

My account help

My


text:
install/update display strange message.

Problem Summary
zplug install and zplug update will display Unknown error message.
But the installation/update is success actually.
System Information

uname -a

Linux  4.8.13-1-ARCH #1 SMP PREEMPT Fri Dec 9 07:24:34 CET 2016 x86_64 GNU/Linux

zsh version

zsh 5.3.1 (x86_64-unknown-linux-gnu)

zplug version/commit

2e06c65

(current head)
Minimal zshrc
Create a minimal reproducing set of configurations for this issue. Please
remove all unnecessary parts!
source ~/.zplug/init.zsh
zplug "zsh-users/zsh-syntax-highlighting"
zplug check || zplug install
zplug load --verbose

Steps to Reproduce

remove ~/.zplug.
use the minimal .zshrc above.
curl -sL zplug.sh/installer | zsh to install the zplug.
open a new zsh and confirm to install plugins.
get the Unknown error message

Actual message is like following:
[zplug] Start to install 1 plugins in parallel

 ✘  Unknown error         zsh-users/zsh-syntax-highlighting

[zplug] Elapsed time: 2.8343 sec.
 ==> Installation finished successfully!
 Load "~/.zplug/repos/zsh-users/zsh-syntax-highlighting/zsh-syntax-highlighting.plugin.zsh" (zsh-users/zsh-syntax-highlighting)
[zplug] Run compinit
[8]  + done       { tags[as]="$(__zplug::core::core::run_interfaces 'as' "$repo")" ; case  in (

Thank you for report, that is my bad. It is environment dependent bug. We will respond immediately. (related to #326)

repo: zplug/zplug


text:
文档树图标使用svg时不能正常居中

问题描述:
文档树图标使用svg时不能正常居中
截图:
使用svg时

使用emoji时

请问文档树图标使用svg的方法是什么？我没有用过这一功能，不好意思

authors: kuusei zqhjl

repo: zqhjl/Rem-Craft


text:
use jGit instead of git on shell

To better support different build environments it would be nice to use e.g.
https://github.com/ajoberstar/grgit

Thanks for bringing this to my attention, cool project!
What do you mean by better supporting different build environments and how can grgit help in that?
Also, as I saw, it's lacking support for git describe parameters, which paperwork needs.

@friedger if there's no further input, I will be closing this.

I think what friedger means it that by using jgit paperwork no longer relies on there being a working installation of the git cmdln tools on the machine (and available on the PATH). Some GUI-loving users may for example only use something like TortoiseGit and not have the cmdln git tools at all.

authors: friedger mstevens83 zsoltk

repo: zsoltk/paperwork


text:
[#86] Modify junit5 test classes and methods's access modifier to defalut

I have a mistake when i rebase branch.. 😭
So i reupload this pull request
I remove all public keywords in all test codes
please review if I forgot public keywords and another something wrong

Coverage remained the same at 83.072% when pulling ad5c7bb70edaf5c2eb27003ecdd4c055ac161dac on ParkSale:feature/86_Modify_junit5_test_classes_and_methods's_access_modifier_to_default into f79c1b5c76ea92fdf384cc7ef07f9d670f43cc45 on ztkmkoo:develop.

ParkSale:feature/86_Modify_junit5_test_classes_and_methods's_access_modifier_to_default so long branch name ^^ (it does not matter at all)

authors: ParkSale coveralls ztkmkoo

repo: ztkmkoo/dss


text:
希望更新功能能支持db-ip数据库

我观察了一下，db-ip数据库的下载链接格式为
https://download.db-ip.com/free/dbip-city-lite-{YYYY}-{MM}.mmdb.gz

如 https://download.db-ip.com/free/dbip-city-lite-2022-08.mmdb.gz
并且该地址没有任何鉴权，隐身模式访问可以直接下载，所以这个应该是可以做到自动更新的，希望作者大大能加入支持~

nali 目前可以通过在配置文件中增加配置项并指定下载链接下载。目前配置文件中的下载链接不支持字符串格式化，所以你还需要自己搭建一个跳转接口，从固定 url 跳转到 DB-IP 的可变下载地址。
DB-IP 主要提供付费数据库，目前付费数据库需要用户手动下载，nali 不提供自动下载。


text:
Allow to specify alternate server name for postfixadmin

https://github.com/zuazo/postfix-dovecot-cookbook/blob/master/recipes/postfixadmin.rb#L22 explicitly sets the node['postfixadmin']['server_name'].
On some configurations I do want to be able to override it looks like it is not possible at the moment.

If you are having problems with that, you can always overwrite it using node.override:
node.override['postfixadmin']['server_name'] = 'postfixadmin.example.com'

https://docs.chef.io/attributes.html#attribute-types

Nope, it does not work. What I'm trying to achieve is to set it to nil. node.override['postfixadmin']['server_name'] = nil does not work for me. But when I remove the line mentioned above it starts working just fine.

Why do you want to set it to nil instead of other value? What error gives you?

I'm getting 403 Forbidden for postfixadmin URL due to hostname mismatch. I can work around it, though.

authors: RomanKisilenko zuazo

repo: zuazo/postfix-dovecot-cookbook


text:
登陆后，重新访问域名不会自动跳转到dashboard

无法重现，请强制刷新页面后再试

authors: superlbr yanghuayi

repo: zuiidea/antd-admin


text:
api: Implement GET /messages/matches_narrow endpoint

This implements GET /messages/matches_narrow api endpoint.

I think that the format for request here is different from get_messages, apart from the narrow key. Did I misunderstand you ?

@timabbott I've updated this PR.

@timabbott Can you have a look ?

Yeah, this is great, merged!

authors: akashaviator timabbott

repo: zulip/python-zulip-api


text:
Reading a message should dismiss the notification for that message

If I read a message that I received a notification about, the notification should be dismissed.

I would like to work on this issue. @niftynei

Go for it @AmoliShah!

@timabbott Changes are to be made in RecyclerMessageAdapter.java activity. Right?

@AmoliShah No. it is for gsm. Check it out here

ok thanks. @saketkumar95

@AmoliShah Are you working on this?

authors: AmoliShah niftynei saketkumar95 timabbott

repo: zulip/zulip-android


text:
Pin a precise version of Flutter

So far, in the prototype phase, we've been able to just always use the latest Flutter version in a given channel (either beta or main). At some point we will want more control, specifying a particular version and being sure everyone gets that version even if it's not the very newest. That way everyone's seeing the same behavior, and a change happening outside our own repo can't break our tests.
In particular, if we use versions from the Flutter main branch, then that will be a constantly moving target. Using the moving target will still be OK as long as we don't frequently see anything change that breaks us, but at some point we'll want to pin the exact version to be sure of that.
Implementation notes
The pubspec.yaml file lets us specify a lower bound for the Flutter version, but not an upper bound. (The syntax permits an upper bound, but it's ignored.) In particular it doesn't permit specifying an exact version. Upstream discussions:

https://github.com/flutter/flutter/issues/95472#issuecomment-1119312969
https://github.com/flutter/flutter/pull/26577#issuecomment-454698844
https://github.com/flutter/flutter/issues/40428
https://github.com/flutter/flutter/issues/95807#issuecomment-1006724141

Relatedly, while the flutter tool provides flutter upgrade as a handy way to get the latest Flutter version within any given channel (stable, beta, or main), there's no such way to get a specific version. So if Flutter did respect the pubspec.yaml file as far as complaining when the version was newer than specified, it still wouldn't provide a convenient way to actually get the specified version.
From those upstream threads, it seems like the usual solution in the Flutter community is to use one of several tools people have built to manage Flutter versions. I haven't looked into these in detail yet at all, but listing the ones I've seen mentioned:

https://fvm.app/
https://github.com/passsy/flutter_wrapper

So when pursuing this, we'll want to look at those and also look to see if there are other implementations to consider.

This caused a bit of confusion in a recent PR:

https://github.com/zulip/zulip-flutter/pull/223#discussion_r1267409152

We also had an outright build-break a couple of months ago:

https://github.com/zulip/zulip-flutter/commit/2f0f4692f2d55748d055ac7c140ab7414307a36d (that fix was from #103)

And there's the recurring small nuisance of:

#85

So while our README says that our lack of pinning so far hasn't been a problem, that seems to no longer be true. It's not an overwhelming problem, but it is an actual problem.

Also, though this next part hasn't yet concretely bitten us, I'm concerned that it will get increasingly hard to run old versions of the app — say, to test whether some behavior is a regression or bisect when it changed — because there's no automated way to get a corresponding Flutter version, and no way at all to determine the exact Flutter versions that we were running at the time we were developing a given version of the app.
And unlike many kinds of problems, that isn't one where it necessarily makes sense to wait until we hit the problem before acting to solve it. That's because when you hit this problem, what you want isn't to have a solution now, but to have had a solution back when the old versions in question were developed, perhaps months earlier.

So I'm bumping this up in the timeline. I don't expect to have time to pick it up immediately, though.

Here's a couple more thoughts about our needs here which I think aren't yet explicit above. (These are copied from a comment I just made at https://github.com/zulip/zulip-flutter/pull/577#issuecomment-2014307364 , on a draft PR toward an implementation of this.)

I'd really like the pinned version to apply when building or running the app — so flutter build, flutter run, and when hitting the "run" button or equivalent in an IDE — and not only when running tests.
Similarly, it's common to use flutter test directly (or a "run this test" button in an IDE) rather than tools/check, because that gives control over which specific tests to run. If that uses a different version of Flutter than tools/check does, that's likely to be super confusing when one way doesn't reproduce the same failures as the other way.
Accomplishing that may require some sort of setup step, which is OK (though I'll be interested in keeping that setup as clean as possible). The key is just that when someone clones the zulip-flutter repo and follows our setup instructions in the most straightforward way, they consistently get our pinned Flutter version across all the above ways of building or running our code.

It's pretty common for us to develop changes to contribute to Flutter upstream, and that's been quite valuable for us. That's currently an extremely low-friction thing to do: the flutter tool is already using your local Git clone of the Flutter repo, so you just start editing that — and committing, and using git reset to move to various branches, etc. — and the changes show up just as seamlessly as if you were making them in your zulip-flutter tree itself.
So I'd quite like to preserve that property, or close to it. Given the nature of pinning, we'll probably need to introduce a nonzero amount of friction — you're not really using a pinned version once you start making edits — but I'd like to keep that friction to the absolute minimum possible. For example, having to do something simple to disable pinning (so that you can make changes) would be fine.

Further design discussion from #577:

I'm not thrilled with fvm, having now looked closer at it.
I sketched a possible approach for managing the pinned Flutter tree with a small script of our own.

@chrisirhc also wrote:

Thinking on this PR more, I think there's some value with testing the commit with the latest commit on flutter. Something like check-flutter-nightly job. This helps with continuously verifying that zulip is compatible with newer versions of flutter and would allow you to skip testing it and just upgrade to a new (tested) version.
However, I saw that this behaviour is not supported on GitHub actions: actions/runner#2347 .
So I'm going to leave that check-flutter-nightly idea out for now.

I agree, a job like that would be valuable (and that's something we currently get from our unpinned setup). It's a shame that GitHub Actions lacks the feature to support that well (by having a job where failure doesn't turn the whole commit's build status to red). It looks like this is the main thread now for that feature request:
https://github.com/orgs/community/discussions/15452
but it's not particularly more promising. (A PM showed up in the thread a bit over a year ago, had some offline conversations, but never followed up in the thread.)
One possible workaround would be to have the job but only run it on main, not on PRs. That way when things started failing because of an upstream change, it wouldn't interfere with seeing the status of PRs — but we would still get the signal that something's wrong, as a prompt for us to investigate and fix.

repo: zulip/zulip-flutter


text:
content: Handle bold-text setting in code blocks and error-unimplementeds

Screenshots show the app with the system bold text setting on.
Fixes: #690

Before
After

Thanks! Looks good; merging, with one nit:
    -    text [nfc]: Remove some params that equal defaults
    +    text [nfc]: Remove some arguments that equal defaults

because I'd read "remove some parameters" to mean changing the signature of a function, rather than some of its call sites. See:
https://developer.mozilla.org/en-US/docs/Glossary/Parameter#parameters_versus_arguments
(It's common to use the terms interchangeably and context usually makes the meaning clear, but here in the terseness of a summary line there's not much context.)

authors: chrisbobbe gnprice


text:
Reset backoff duration after successful connection.

This fixes #554, and supersedes #564.

After having a discussion with Greg, we will drop the testing part of this because this change is easy to verify, but testing is complicated.

Thanks @PIG208, and thanks @chrisbobbe for the previous review!
Merging, with an additional commit adding a long comment:
cca6f244a store [nfc]: Explain why we reset backoff, and the trade-offs


text:
ESLint 6.8.0 upgrade

Closes: #4120
This was started with the RN v60 upgrade (#3548) in mind, since the upgrade helper had us going to ESLint 6 from 5.
But running
rm -rf node_modules && yarn && tools/test lint prettier --full
(yes, newly ensuring to use --full! see discussion for more on that)
with these commits positioned before or after the RN 60 upgrade gives no warnings or errors whatsoever. So it seems like we're in good shape to get this done at any time, and no mention is made of the RN v60 upgrade in this revision.

@gnprice If you'd like the reorganization of those Airbnb overrides to look different, please feel free to change as you see fit, if you prefer that to a round-trip review. (Of course I'll make changes, as requested, if you prefer that, too.) I do always examine any changes you make before merging, when you mention them, to increase my chances of doing things better next time. 🙂

Oops! As also noted at https://github.com/zulip/zulip-mobile/pull/4133#issuecomment-637219322, I'll fix this to say Fixes: #... instead of Closes: #....

Oops! As also noted at #4133 (comment), I'll fix this to say Fixes: #... instead of Closes: #....

Done. I also rebased and fixed some conflicts.

Thanks @chrisbobbe ! Just read this, and it looks good. The main thing it needs is a rebase.
I might make some adjustments to how the eslintrc is organized. I agree that's better to just do rather than round-trip through a review.
Small comments:
cea62b754 tools/test lint: Make globs passed to prettier-eslint absolute.
There was a chat discussion about this, right? May be worth linking to in the commit message, to help explain the syntax for any reader unfamiliar with this sort of Bash arcana.
859fee6e7 deps: Remove direct eslint-config-airbnb-base dependency.
Also, run `yarn yarn-deduplicate && yarn`, as prompted by
`tools/test deps`.

There's no change to yarn.lock here, so it seems like this change wound up in a different commit.
... Hmm, in fact -- in an earlier commit in the series:
9c6aebb2f deps: Upgrade babel-eslint to ^10.0.3.
the yarn.lock changes look like they introduce duplicates which I expect yarn yarn-deduplicate would remove.

Thanks for the review, @gnprice!

There was a chat discussion about this, right?

Ah, yes—thanks for the reminder! Added a link.
About yarn yarn-deduplicate && yarn:
Yup. Looks like I'd marked that I'd run that command on...both commits. Sure enough, running it at the babel-eslint ^10.0.3 commit resulted in some changes, so, I committed those, and tools/test deps didn't complain at the eslint-config-airbnb-base commit, so I removed that bit of the commit message.

OK, just pushed my latest changes, for another review. 🙂

Looks great, thanks -- merged!

repo: zulip/zulip-mobile


text:
Add support for italics to bugdown

It would be nice to be able to italicize things in Zulip messages. I recognize that coming up with Markdown-like programmer-friendly syntax for italics will be tricky, but hopefully we can start(/continue) the conversation here.
(Bonus points if we also come up with formatting for strikethrough, which I think will get us to simple formatting parity with Github.)

Strikethrough, with GitHub's syntax, seems easy to add.
For italics, we should just make sure to minimize the risk of accidentally triggering the italics syntax (e.g. by only matching *foo* and *foo bar*, not things like const char *x = (char *)y or sloppily done bulleted lists.
http://zulip.readthedocs.io/en/latest/markdown.html is probably helpful.

@timabbott Do you know if anybody's actively working on this ticket?  It would influence whether I try to tackle #1379 sooner than later.  If somebody is working on this, I can probably help push it over the finish line.

I don't believe anyone is.

Strikethrough is being worked on in #2023; italics is still open.

I did some testing, and with the narrow syntax described above, it appears accidental italics would be extremely rare (on the scale of 1/20K messages), which seems low enough to be fine.  Italics support has been added.  Thanks @TigorC for working on this!

authors: jdherg showell timabbott

repo: zulip/zulip


text:
Clean up logic around web public streams settings

I think there's a couple things that don't quite work correctly around the settings for web-public streams:

As noted in https://github.com/zulip/zulip/pull/20277#discussion_r751678127, we shouldn't display the option to enable web-public streams unless settings.WEB_PUBLIC_STREAMS_ENABLED is true on the server (default is false except in Zulip Cloud and the development environment).  Probably to do this we need a server_web_public_streams_enabled key to be added to the page_params response via the realm section of zerver/lib/events.py.
As discussed in https://github.com/zulip/zulip/pull/20277#discussion_r751712460, we should not offer the option in "Stream settings" to create a web-public stream, or have the server accept API requests to do so, unless both WEB_PUBLIC_STREAMS_ENABLED and enable_spectator_access are enabled.
In addition to checking the above, user_profile.create_web_public_stream_policy should control whether you have permission to actually create a web public stream (and thus presumably whether the relevant radio button is disabled in settings UI); this is related to but somewhat independent of https://github.com/zulip/zulip/issues/20287.

Working on this also along with #20287.

I am almost done with this issue and #20287.
We currently show the private streams option in stream creation form even if a user is only allowed to create public streams.
As we want to hide the web-public stream choice from stream creation form if user is not allowed to create web-public streams, I am also adding the same for other types of streams as well - both for private and public.
I wanted to confirm one thing that we also do not want to show these options in Change privacy modal as well. Like if an admin is not allowed to create web-public stream and it should also not be able to change the setting from public to web-public right?
(This case is only for web-public streams for now as only admins are allowed to change privacy of a stream and they are always allowed to create public and private streams. But we may add Owners only option as well in future)

I don't think the "can only create public streams" logic is one we've particularly polished -- it was a thing we meant to come back to after migrating the page structure, but didn't.
I think if the organization has enabled web-public streams but you don't personally have permission to create them, that feels to me like a setting for a radio option that's disabled (maybe with a tooltip explaining why).  If the organization doesn't allow them, it's more ambiguous -- there's an advertising argument for showing it, but also a confusion argument for not.
@alya thoughts on that UX question?  Might be best to move to #design.  Ability to create a stream of type X should match the ability to change a stream to type X.

In the case where the org allows web public streams but the user can't create them, this sounds like the right plan to me:

radio option that's disabled (maybe with a tooltip explaining why)

We should also implement this approach for public streams. Right now we give an error after a user without the necessary permissions has tried to create a public stream, which is not a good experience:

If the organization doesn't allow them, it's more ambiguous -- there's an advertising argument for showing it, but also a confusion argument for not.

I definitely don't think we should show the option in this case. If we want to advertise it, we could show an "Enable web public streams." link to admins only.

authors: alya sahil839 timabbott


text:
Bug in resolving topics

While exploring the Zulip codebase and tinkering around, I noticed a bug when marking a topic as unresolved.
If there are no messages in a resolved topic( possibly because they were deleted after the topic was marked as resolved), and the user tries to compose a message, a banner appears:

However, on clicking the Unresolve topic button, the following error pops up:

As per the error message, the problem lies in message_edit.js, line 1378:

It is assumed that data.messages will never be empty.

CZO thread

I can solve the issue, but I cannot claim it because last my pull request is almost ready to merge, so therefore the bot will not let me claim it.

I appreciate that you showed interest, but there are a couple other things to do here, apart from what you suggest. I am familiar with the problem and have made some progress, and wish to continue with the issue.


text:
user_name: Prevent users from setting forbidden format.

https://github.com/zulip/zulip/issues/13923.
Preventing users from setting their usernames in the format "Alice|999".
EDIT: The regex finally decided upon and used is r"\|\d+$".

Perhaps the regex should be relaxed from ^\w+\|+\d to \|+\d$? With the current regex you won't be able to set a name with any spaces or special characters.

@pemontto Thanks! Fixed it.

As you're not matching the whole string now you'll probably want to use re.search instead.

@timabbott A review please

LGTM.  Tim, you may want to tweak the error message here to be something like "Invalid format!  Please do not end your name with a pipe and digits.".  I don't think the message needs to be super clear; as long as it hints toward the problem, we should be ok.

@timabbott A review please. It's a small one.

Merged as 43e39718c429900f92de54193894aa289c5b9543, after fixing several things:

The commit message didn't close the issue
The commit message was a bit unclear about the issue
Added a comment documenting this more unusual element.
Fixed the import re placement.

@Abhishek-Balaji I'd encourage you to spend more time on these details.  If you don't, even a "small PR" like this one is actually quite time-consuming to review and merge.

authors: Abhishek-Balaji pemontto showell timabbott


text:
missedmessage_hook: Fix inaccurate docstring.

If the client is no longer on the Internet (Hard Disconnect Problem) then receiver_is_off_zulip returns False, not True, for DEFAULT_EVENT_QUEUE_TIMEOUT_SECS, until the queue is garbage-collected.
https://chat.zulip.org/#narrow/stream/2-general/topic/missedmessage_hook.20docstring

Testing plan:
GIFs or screenshots:

I think it'd be clearer to just explain in the commit message, simply that receiver_is_off_zulip actually returns False in the circumstances described in that sentence - so True was just a kind of typo that we correct?

Great, thanks for catching this!

Merged, thanks @shanukun!  This sort of documentation fix is really valuable, since it'll save confusion for the next person who reads that code :)

authors: mateuszmandera shanukun timabbott


text:
Infrastructure for unsubscribe links in marketing emails

Tested in a development environment.  This changes manage.py send_custom_email emails to have an unsubscribe link, adds a notification setting (only visible in Zulip Cloud configurations) to control whether a user wants "occasional marketing emails", and fixes adjacent issues.
The last commit needs testing on a production server to verify we are generating the mailing list headers such that they work correctly in Gmail.

I merged everything but the list-unsubscribe commit (which still needs testing, and would benefit from an automated test check too) as the series ending with a0e18cb06ae1d5bd2f5bc1254bbcb4a6fc9f04b7.

@hackerkid do you have a bit of time to add assertions that the List-Unsubscribe headers are present in tests for the relevant outgoing email code paths?  (Probably we just want to change existing tests with outbox rather than adding new ones).


text:
UI redesign : change font & color of timestamp in a message

made the required changes in  static/styles/zulip.css
and static/styles/dark_theme.css in issue #21752
https://github.com/zulip/zulip/issues/21752
Testing plan: By running  locally after changes
GIFs or screenshots:
https://zulip.re

adthedocs.io/en/latest/tutorials/screenshot-and-gif-software.html

Thanks @supriya-045 ! In addition to addressing the feedback above and posting an updated screenshot, please also edit your commit message according to https://zulip.readthedocs.io/en/latest/contributing/version-control.html.
You can post and to request a review when ready. :)

Thanks @supriya-045 ! In addition to addressing the feedback above and posting an updated screenshot, please also edit your commit message according to https://zulip.readthedocs.io/en/latest/contributing/version-control.html.
You can post and to request a review when ready and all the tests are passing. :)

All checks are passed now,please review the PR.

@terpimost would you like to take a look?
In the screenshot, the font looks a bit funny to me next to the date font in the message header, but I don't know if we think that's OK for now?

If that would be easy to update the date in the header of the topic lets do that.
Light theme:  color is hsla(0, 0%, 37%, 1) and
font-size: 15px;
line-height: 18px;
text-align: right;
font-variant: small-caps;
font-weight: 400;

and lets also do font-variant: all-small-caps; as @sayamsamal suggested.
For the dark theme the color is background: hsla(0, 0%, 70%, 1);

If that would be easy to update the date in the header of the topic lets do that. Light theme: color is hsla(0, 0%, 37%, 1) and
font-size: 15px;
line-height: 18px;
text-align: right;
font-variant: small-caps;
font-weight: 400;

and lets also do font-variant: all-small-caps; as @sayamsamal suggested.
For the dark theme the color is background: hsla(0, 0%, 70%, 1);

Sir

If that would be easy to update the date in the header of the topic lets do that. Light theme: color is hsla(0, 0%, 37%, 1) and
font-size: 15px;
line-height: 18px;
text-align: right;
font-variant: small-caps;
font-weight: 400;

and lets also do font-variant: all-small-caps; as @sayamsamal suggested.
For the dark theme the color is background: hsla(0, 0%, 70%, 1);

As per the issue of changing the font and color of timestamp also do i need to update the date font in the header?

@supriya-045  Right, @terpimost 's and my feedback above is that we would like to make the header changes at the same time. Please add those to your PR (in a separate commit), or let us know if you aren't able to do so. Thanks!

@supriya-045 please post a comment if/when this is ready for another review. Thanks!

@supriya-045 please post a comment if/when this is ready for another review. Thanks!

@alya and @terpimost I have made the  changes in the style of date in message header ,please review it. Thanks!

@supriya-045 could you please attach light and dark theme screen shots?

Made the required changes in static/styles/zulip.css and static/styles/dark_theme.css in issue #21752
https://github.com/[/issues/21752](https://github.com/zulip/zulip/issues/21752)
Testing plan: By running locally after changes
GIFs or screenshots: https://zulip.re

@supriya-045 could you please attach light and dark theme screen shots?

@terpimost I have added the screenshot of dark mode too,please review it.Thanks!

@supriya-045 could you please attach light and dark theme screen shots?

@terpimost I have added the screenshot of dark mode too, please review it. Thanks!

@supriya-045 could you please attach light and dark theme screen shots?

@alya @terpimost I have added the screenshot of dark mode too, please review it. Thanks!

@supriya-045 thank you for the screenshots. It looks like that in the current design the date is too dark in the dark mode.

@supriya-045 thank you for the screenshots. It looks like that in the current design the date is too dark in the dark mode.

I have applied the same as suggested by you , should I use same as before?

Let me check on my side and get back to you
On Fri, Apr 15, 2022 at 3:43 PM Supriya Patidar @.***>
wrote:

@supriya-045 https://github.com/supriya-045 thank you for the
screenshots. It looks like that in the current design the date is too dark
in the dark mode.
I have applied the same as suggested by you , should I use same as before?
—
Reply to this email directly, view it on GitHub
https://github.com/zulip/zulip/pull/21754#issuecomment-1100321668, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAOQVTNTXT5RAJBAEQ4R7XTVFHBE5ANCNFSM5TAPUY2A
.
You are receiving this because you were mentioned.Message ID:
@.***>

Let me check on my side and get back to you
…
On Fri, Apr 15, 2022 at 3:43 PM Supriya Patidar @.> wrote: @supriya-045 https://github.com/supriya-045 thank you for the screenshots. It looks like that in the current design the date is too dark in the dark mode. I have applied the same as suggested by you , should I use same as before? — Reply to this email directly, view it on GitHub <#21754 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAOQVTNTXT5RAJBAEQ4R7XTVFHBE5ANCNFSM5TAPUY2A . You are receiving this because you were mentioned.Message ID: @.>

@terpimost @alya As I have made the PR for this issue ,can I unassign myself because due to this I am unable to claim another issues. And please let me know if it require some changes . Thanks!

@supriya-045 sorry, for confusing instructions.
Lets try that again. For the dark theme the timestamp color is hsla(0, 0%, 50%, 1);
and for the date color is hsla(0, 0%, 70%, 1);
Please check opacity (transparency) of parenting containers. Since the date is lighter of a color it should be visible better.
Here is the part from the design:

@supriya-045 sorry, for confusing instructions. Lets try that again. For the dark theme the timestamp color is hsla(0, 0%, 50%, 1); and for the date color is hsla(0, 0%, 70%, 1); Please check opacity (transparency) of parenting containers. Since the date is lighter of a color it should be visible better. Here is the part from the design:

@terpimost I have done the changes suggested by you and added the screenshot , please review it.Thanks!

Great. I would love to test deploy it and see if anything should be tined further. @alya how should we move further with these improvements by @supriya-045 ?

Great. I would love to test deploy it and see if anything should be tined further. @alya how should we move further with these improvements by @supriya-045 ?

@terpimost @alya As I have made the PR for this issue ,can I unassign myself because of  this I am unable to claim another issues. And please let me know if it require some changes . Thanks!

Hm, testing this on dev, the alignment looks off to me -- the date is a bit lower than the other text in the topic bar.

The alignment of the timestamp seems too high compared to the other icons; I'm not sure about the sender.

Hm, testing this on dev, the alignment looks off to me. The date is a bit lower than the other text in the topic bar, and I think it would look better if that were not the case.

Alignment is now same.

The alignment of the timestamp seems too high compared to the other icons; I'm not sure about the sender.

Alignment of timestamp is now same as other icons ,please review it. Thanks

@supriya-045 and @alya thank you so much for noticing and working on such details.

@supriya-045 please update your commit messages according to https://zulip.readthedocs.io/en/latest/contributing/version-control.html#commit-messages
Thanks!

@terpimost is this otherwise ready for testing on CZO from your perspective?

@supriya-045 please update your commit messages according to https://zulip.readthedocs.io/en/latest/contributing/version-control.html#commit-messages
Thanks!
Hey, I have updated the commit message.

@supriya-045 please update your commit messages according to https://zulip.readthedocs.io/en/latest/contributing/version-control.html#commit-messages
Thanks!

Hey! I have changed the commit message.

@terpimost is this otherwise ready for testing on CZO from your perspective?

Yes

@timabbott could you please evaluate this for test-deployment on CZO? @terpimost and I have reviewed it.

I've squashed the commits and cleaned up some stale comments in this PR. I think we can potentially test-deploy it, but I noted a few issues:

Hovering over the timestamp results in a slow 1.5s transition/fade towards blue link styling. This is likely just stale transition CSS from some previous design that needs to be excised (along with the likely misplaced comments explaining them).
I'm suspicious that the vertical alignment was not fixed correctly; it seems possible that, for example, the timestamp was actually aligned with the sender name (on the left) but that . So we should check that.
I note that the issue description has hsla(0, 0%, 60%, 1); vs. the 50% that this implements; based on https://github.com/zulip/zulip/pull/21754#issuecomment-1100689525 I think the issue description is wrong, but just flagging this.
Ideally, we'd use 110% for the font size variations (rather than 15px), since that's the way to make it work when we support different font sizes. We should try to use that pattern wherever we're doing something that's intended to be a different size from the rest of the app's content.
I'm not sure about the maintainability of using a custom text color for this. Previously, this component had the same font color as the rest of the app, with the idea that we'd just have a common default text font color, and components that just want a lighter/darker variant can use opacity for it. (The 50% used before this was crazy, though -- one usually wants 70% or 80%). So @terpimost I wanted to ask if the colors you selected here are equivalent to something like 70% opacity on what would be the future default font color for the app; if so, we can define $redesign_font_color_light and $redesign_font_color_dark variables and use those. The other advantage of opacity for the job is that often a single value will look OK in both light and dark themes.

To be clear, I'm fine with testing and merging this one with the current approach, but I figure this PR is a good opportunity to decide those two "how we write CSS for the redesign" questions, since they're most of the code of this PR, and it'll smooth future ones if we make a policy decision on how we want to write this stuff.
In any case, @amanagr perhaps you can make a new PR for this issue, debug the blue link styling thing (perhaps have just a new prep commit removing it -- I checked it's there in main but just really subtle), and perhaps action whatever we conclude with @terpimost on the percentage/opacity questions. It might be easier for you to understand the plan to just read the issue thread and this comment and then try to do the issue yourself, and then compare with this PR's code, since the comment thread here is so long.

@timabbott yes, we can make text for date as regular text with 75% opacity:

Closing in favor of https://github.com/zulip/zulip/pull/22661.

authors: alya medhatiwari supriya-045 terpimost timabbott


text:
help: Document edit or delete a message mobile feature.

Documents "Edit message" mobile feature.
Adds instructions block to "Delete a message" on Desktop/Web.
Documents "Delete message" mobile feature.

Question:
For clarity, should we also add a Desktop/Web tab to the instructions block for deleting a message completely?
Screenshots and screen captures:

https://zulip.com/help/edit-or-delete-a-message#edit-a-message

https://zulip.com/help/edit-or-delete-a-message#delete-a-message

Self-review checklist

[x] Self-reviewed the changes for clarity and maintainability

Communicate decisions, questions, and potential concerns.

[x] Calls out remaining decisions and concerns.
[x] Automated tests.

Individual commits are ready for review (see commit discipline).

[x] Each commit is a coherent idea.
[x] Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

[x] Visual appearance of the changes.
[x] Links.

@alya This PR is ready for you.

Thanks! This is a good start. Closing in favor of a more extensive rewrite in #25281.

authors: alya drrosa


text:
Prep commits to removing discount percentage.

This PR just adds required plan tier field to clould support page and make the field required for setting discount.
Disabled until a required plan tier is set.

Looks good, merged, thanks @amanagr! I didn't hand-test under the theory we'll be testing the next versions soon anyway with the next PRs, and it's an internal page, so impact of bugs I'd potentially have caught seems minimal.

authors: amanagr timabbott


text:
settings: Allow tabs to be wider.

First commit is to fix the tabs in bots panel.
Second commit is to fix the tabs in stream and group settings.

Fixes: #30672

Screenshots and screen captures:

Self-review checklist

[ ] Self-reviewed the changes for clarity and maintainability
(variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

[ ] Explains differences from previous plans (e.g., issue description).
[ ] Highlights technical choices and bugs encountered.
[ ] Calls out remaining decisions and concerns.
[ ] Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

[ ] Each commit is a coherent idea.
[ ] Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

[ ] Visual appearance of the changes.
[ ] Responsiveness and internationalization.
[ ] Strings and tooltips.
[ ] End-to-end functionality of buttons, interactions and flows.
[ ] Corner cases, error conditions, and easily imagined bugs.

One point here is that the tabs are not of same size now since their width is set by the content inside them. Other way can be to just set the width constant but large enough for all languages.

I have checked other places as well where tabs are used -

In user profile modal, invite modal, and help modal, the text is wrapped and for small screens, the width of modal is not enough to show the text as wrapping is not done at random places so it looks like below.

And for all other places the tabs move to other line for narrow screen -

I don't see the advantage of using min-width to keep the tabs larger than their text contents would be. Why not just bump up the spacing from, say, padding: 3px 4px to padding: 3px 8px? That'll keep the buttons generously sized while allowing the tab group to collapse further and avoid the weird appearance of a third button on a line by itself.

And for all other places the tabs move to other line for narrow screen -

I feel like that would look better if we properly rounded all the corners, and left some vertical space between the two lines of tabs.

I'm OK with potentially leaving some mobile-width issues for follow-ups if it's hard to get everything working properly in one go.

In user profile modal, invite modal, and help modal, the text is wrapped and for small screens, the width of modal is not enough to show the text as wrapping is not done at random places so it looks like below.

I guess we could let it go to three lines?
Russian in particular has pretty specific rules about where you are allowed to break a word -- it's supposed to be done at syllable boundaries. Not something I'd worry about if we aren't using a library that handles this sort of thing, but figured I'd mention it.

I don't see the advantage of using min-width to keep the tabs larger than their text contents would be. Why not just bump up the spacing from, say, padding: 3px 4px to padding: 3px 8px? That'll keep the buttons generously sized while allowing the tab group to collapse further and avoid the weird appearance of a third button on a line by itself.

If we use padding then also the buttons would move on a third line at a certain screen width.
Keeping min-width also helps in having the tabs of same width for normal screens, if we think that looks better than having tabs with different sizes. We can decrease the min-width based on screen size to have the tabs move to third line at a more narrower screen than current.

And for all other places the tabs move to other line for narrow screen -

I feel like that would look better if we properly rounded all the corners, and left some vertical space between the two lines of tabs.

Yes, that would look better with I guess some vertical space between the tabs as well. Maybe we can leave this as a follow-up, and for now just try to make it look good for the cases till all the tabs are on one line.

Merged, thanks @sahil839!

authors: alya karlstolley sahil839 timabbott


text:
typeahead: Alter style for user emails.

Altered the style for emails in the @-mention typeahead to match the style used for stream description in #**stream**. This also affects typeaheads for PM recipients and adding new users in stream settings. relavant topic on Zulip.
Here's an image depicting the changes:

Automated message from Dropbox CLA bot
@akhilmd, it looks like you've already signed the Dropbox CLA. Thanks!

@akhilmd this looks great, though maybe we should adjust the CSS to make the secondary element have a bit higher contrast?  The emails feel pretty hard to read.

I altered the CSS. I felt that secondary element in the active item was even harder to read, so I changed that as well.

@akhilmd thanks for working on this!  The new CSS looks great, and the code looks correct.  However, I think I'd like you to split this into more commits, since that would make the code changes easier to understand for people reading it in the future, and it's an important habit to learn for this sort of change where you're refactoring existing code.  A good split might look like this:

The first commit should move the interface of render_person to include highlight_with_escaping; there would be no functional changes here but it'd have most of the code in this commit.
A second commit could extract render_secondary so that it's a reusable function, with no function changes.
A third commit should make the functional change to use render_secondar in render_person.
The last commit would update the CSS, which is a functional change to the existing stream descriptions feature as well.

Then, someone reading these changes (either now or potentially months or years later, when debugging whether a bug might have been caused by it) will have a super easy time reading the code, since it's completely obvious what exactly you changed on a quick inspection.
I could imagine the 2nd and 3rd commits being squashed together, since it's a really simple change in that case.  Does that make sense?  Ask on the "#git help" stream if you need advice on how to do this split.  Once the split is done, I'll merge this.
Thanks @akhilmd!

@akhilmd what do you think about removing the highlighting of the matching characters?  I feel like those make this look less good, and isn't functionally important.  If you agree, you can add another commit doing that.

I split the commits.
Should removal of highlighting affect all similar typeaheads? The other typeaheads are:

Stream and topic suggestion while composing.
Default streams in organization settings.

This looks great, I merged the commit so far @akhilmd!  Closing, we can open a new PR for the highlighting issue.
Can you post screenshots of the others?  I think maybe it looks particularly bad for emails, because the highlighted text often appears in both the name and email...

authors: akhilmd smarx timabbott


text:
build-release-tarball: misc small cleanups

Most of these were in a branch I had lying around locally from July, part of me figuring out at that time what this script was really doing.
Rebasing and cleaning up their commit messages, I spotted a few more easy cleanups.

This looks good, assuming you've done a test where you build a release tarball before and after and diff the tar -tf output of the two (to make sure the result is the same).
(It's possible we should document that testing procedure somewhere).

Yeah, that's a reasonable compromise test between "not a pain to do" and "accurate". I'll quick do that now.

Done, and it passes. Also included one more commit which was inspired by doing that. :-)
There are a couple of wrinkles in the test process:

you want something like perl -lpe 's,.*?/,,' | sort applied to the tar tf output
there are a handful of filenames that do still differ: two apparently of minified JS, and a JS sourcemap. Spot-checking the sourcemap first, the actual files do differ. Not sure why, but this sort of small nondeterminism in builds is typical when not carefully avoided.

Great, merged, thanks @gnprice!
For update-authors-json, I've been thinking of emailing GitHub about that.  It seems like a clear bug.

authors: gnprice timabbott


text:
Add architectural overview documentation.

(Work by me with a tremendous amount of assistance & investigation by @leonardr -- thanks for the help!)
Fixes: #453.
Also addresses part of #790.

Automated message from Dropbox CLA bot
@brainwane, thanks for the pull request! It looks like you haven't yet signed the Dropbox CLA. Please sign it here.

@christi3k Heads-up -- might be useful to you in your work.

@brainwane thanks for writing this, I definitely appreciate all the detail!
There are a couple components that are missing from this overview but should probably be mentioned:

camo, a caching image proxy that we use to avoid mixed-content warnings (and prevent certain MITM attacks on Zulip users) for showing user content that is displayed over S3.  It's implemented in node.js.
We should probably mention that uploaded files and avatars are either hosted by nginx (if LOCAL_UPLOADS_DIR is enabled) or can be hosted by Amazon S3.

Also, would probably be good to at least mention and link to some of the non-service components, probably most relevant for now is this:

Markdown processor for rendering messages: http://zulip.readthedocs.io/en/latest/markdown.html
closure-compiler is our minifier
We use Jinja2 and Handlebars for templating (covered in http://zulip.readthedocs.io/en/latest/translating.html)

etc.
But we may have more we want to highlight in the future, so it'd be good to have a clear place to add links to such things.
Finally, I think it'd be great to have some sort of diagram for this, ideally setup in a way where it's easy to modify the diagram.  Probably something best left as an open issue for future work.
Overall this looks really good and super useful!  Let me know when you have a revised version ready.

@timabbott I think Friday or Saturday this week is the soonest I'll be able to revise this - I know that's around when you'll start your vacation but I suppose it'll be ready for you when you return! :) Glad it's looking mostly good and useful; thanks for the review.

No worries, that just means I'll be a bit slow to review again :)

Tim, FYI, I can't get to this before PyCon (it took longer than I thought it would to rebase the other work), so I'll finish this up side-by-side with you at the PyCon sprints. :)

Sounds good, see you in a couple days!

Automated message from Dropbox CLA bot
@brainwane, thanks for signing the CLA!

@timabbott I've addressed all of your inline comments, I believe, but I haven't yet addressed the longer comment regarding the missing components and the non-service components. I honestly think it might be good to go ahead and merge this now, anyway, for use for tomorrow morning's sprinters, and then I can add the other items in a separate pull request tomorrow improving the doc.

That's reasonable as a plan; I'll take a look tonight and hopefully merge.

OK posted a few more hopefully quick comments, otherwise this looks good!

Merged, thanks @brainwane!  Do you want to open an issue to keep track of the additional things we wanted to add (e.g. camo)?

Thanks, @acrefoot -- fixing in my new pull request #899.

Tim's comments (re camo and other components to add to the overview) are now issue #900.

Awesome, thanks @brainwane!

authors: brainwane smarx timabbott


text:
Swift 5 support

Hello,
will you add support for Swift 5 as well?
kind regards

Actually, I'm planning to completely rewrite this library. It will have a different, more modern API, a new repository and written in Swift 5.

@Vario
If you're still interested here it is: https://github.com/zummenix/KeyboardNotificationsObserver

authors: Vario zummenix

repo: zummenix/KeyboardWrapper


text:
Outlook/Yahoo problem with multiple columns inside row

How can we reproduce this bug?
I created one row with multiple 4-columns divs (more than 3) because i want to produce dynamically the content of the email. Sometimes there will be 4 divs to show, sometimes more than 12.
Write out the HTML (or Inky code) that causes the issue.
`

Test24

            <spacer size="40"></spacer>

        </callout>
    </columns>
    <columns small="12" large="4">
        <callout>

Test 2. 12

            <spacer size="35"></spacer>

            <spacer size="40"></spacer>

        </callout>
    </columns>
    <columns small="12" large="4">
        <callout>

Test 3. 34

            <spacer size="25"></spacer>

            <spacer size="40"></spacer>

        </callout>
    </columns>
    <columns small="12" large="4">
        <callout>

Test 4. 8

            <spacer size="35"></spacer>

            <spacer size="40"></spacer>

        </callout>
    </columns>
    <columns small="12" large="4">
        <callout>

Test 5. 0

            <spacer size="35"></spacer>

            <spacer size="40"></spacer>
        </callout>
    </columns>
    <columns small="12" large="4">
        <callout>

Test6. 34

            <spacer size="35"></spacer>

            <spacer size="40"></spacer>
        </callout>
    </columns>
</row>

`
What did you expect to happen?
I was expected to see all boxes inside the width of the table
What happened instead?
All boxes are aligned one after the other and exceed the width of the table
What email clients does this happen in?
Outlook client and Yahoo (web)
This image is from Outlook client and Litmus too.

Foundation For Emails isn't like a front-end web framework such as Foundation or Bootstrap in that you can't just open a Row and expect Columns adding up to a total of more than 12 to stack. My guess would be that this is a limitation of nesting tables?
Essentially then, Columns within a row need to total any permutation of 12, be that two 6s, three 4s etc. etc.
I'm not sure that Foundation For Emails will be able to do what you need it to, as even if you're able to programatically close the Row tag after each n Columns, that will only work for either the desktop or mobile version and not both.

You are right. I reworked with back end and came back to full rows.
Thank you!

@antonydjames, nicely said! @GBratsos looks like this was resolved! Please reopen if there are any other issues.

authors: GBratsos antonydjames tdhartwick

repo: zurb/foundation-emails


text:
Updated tips-tricks.md with a workaround for dates/times/phone numbers on iOS devices

@tdhartwick Added section on targeting dates/times/phone numbers on iOS devices to tips-tricks.

Thanks! This page is a work in progress and we'd love to make it a community thing that people can contribute to. We'll have a version of it published by Friday and go from there!
Thanks for the PR!

Thanks!

authors: rafibomb stephenrust tdhartwick


text:
Foundation 5.2.2 : TypeError: Cannot read property 'css' of undefined

Hello,
I'm posting an error for old version so, first of allow me please.
My foundation version is 5.2.2.
I have implement reveal in my project and find a very weird issue. Some time I got the TypeError: Cannot read property 'css' of undefined. Refer the attached screenshot
. Because of this error reveval modal is not opening.
It would be helpful if someone help me.
I'm not in a stage to update foundation framework. so, please don't suggest that.
Regards,
Sanjay

You need to provide more than screenshot if you want people to help you.
Can you reproduce the error in a CodePen?

@Deckluhm Thanks for your suggestion but its a intermediate error. It's not reproduce every time thats why I attached screen. Please allow me. I'll try to make codepan as you suggest but not sure it reproduce over there.

@sanjay-russmediatech if you isolate the code and can't reproduce the error, that might be a sign that the error is in your code (not a bug in Foundation).
That's why lot of open-source projects ask for reproduction steps (or even better, CodePen / JSFiddle).

@sanjay-russmediatech Sanjay bhai, Just fork these from below codepen's and reproduce

CodePen with Foundation 6.3.1 and MotionUI
CodePen with Foundation 6.3.1, Flexbox grid and MotionUI
We unfortunately can't help you with screenshots!

Also if its not a bug related with foundation itself,
The Foundation Forum would be a better place to seek help!

@IamManchanda the issue is about Foundation 5.2.2, not 6.3.1.

Yeah @Deckluhm i have updated my comment .... didn't notice at first !

@Deckluhm @IamManchanda Thanks. I'll try to reproduce in codepan and let you update. I also check in my codebase that if something wrong with my code.

@sanjay-russmediatech any updates ??

@IamManchanda I tried in codpan and there is no issue with foundation. It may be due to a older version of jquery used in my project but, thanks for your help. I'm closing this issue.

repo: zurb/foundation-sites


text:
The accordion does not work with "any" element as the documentation states. Here is a fix.

The accordion does not work with "any" element as the documentation states it requires the use of ul and li. This is a quick fix to that issue.
This “li” selector assumes the use of ul and li to create an accordion however the documentation indicates any elements “should” work.
Switching to “.accordion-item” allows for the use of any element.

Quite right you are. Simple enough fix, however, we either need to use a state class i.e. .is-accordion-item or set this as an option i.e. this.options.tabClass. In it makes more sense to use the state class, since it won't interfere with styling, but targeting the elements to apply the class too becomes an issue, since the js doesn't necessarily know what to look for.

Wouldn't a state class be reserved to indicate a states such as .is-active, .is-open or .is-closed?
.accordion-item os more of a "what" am I kind of class.
Would the reasoning be because .accordion-item might have styles attached to it? As far as I can tell it does not?

Sorry for the delay in getting back to you. After talking this over with the Foundation team, it's been decided to move more to the [data-attributes] for JS and classes for styles. Which means, to keep this non-breaking, we need to leave in the check for li's but add in the option to use data-accordion-item to the markup and use that as a target. We'll be doing this for a couple other plugins as well, in the near-ish future. If you update your code to reflect that selector with a conditional statement for maintaining li support, I would love to pull it in before a patch tomorrow.

authors: evanlask zurbchris


text:
Add JSPM config

Replaces #8229, as requested.

Thanks, appreciate it!


text:
🛑 Groups API Endpoint is down

In 24ba08a, Groups API Endpoint (https://groups.roblox.com/v1/groups/5680533) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Groups API Endpoint is back up in abdf2b9 after 9 minutes.


text:
Works as global, but not as filter

I'm having some trouble getting this to work.
I've added via Hacs. Testing in dev tools, the functions work as globals, but not as filters.
Works: {{ get_type('foo bar baz') }}
Fails: {{ 'foo bar baz' | get_type }}, error: TemplateAssertionError: No filter named 'get_type'.
Any ideas?
This is with Home Assistant installed on a raspberry pi.

Same here. Installed via HACS on dockerized version of HA.

authors: edwardhorsford mcree