text:
yield on wait, no wait before command, SYNC timing, add setGain()

ESP32 has 2 cores and can use multiple tasks, waiting in a nop loop is not ideal
waitDRDY blocks at second command if first command does not lead to a DRDY
Longer delay after SYNC command: 24 cycles according to datasheet, not 4

Wrote a small test program for setGain()
#include <Arduino.h>

#include <ADS1256.h>
#include <SPI.h>

// Initialize ADS1256 object
ADS1256 adc(7.68, 2.5, false);  // clockSpeed in Mhz,  VREF in volt, if use RESET PIN

const uint8_t chan = 2;         // channel to use
uint8_t gain = 0;               // first gain value

volatile bool ready = false;    // set to true on DRDY

// Interrupt service routine triggered by DRDY
void IRAM_ATTR readyIsr() {
    ready = true;
}

// Wait for DRDY (or return immediately if not fromNowOn and ready is already true)
// Return true if DRDY and false if timeout without DRDY
bool readyWait( uint32_t timeout_ms = 2000, bool fromNowOn = true ) {
    if( fromNowOn ) ready = false;
    uint32_t start = millis();
    while( !ready ) {
        if( millis() - start > timeout_ms ) return false;  // wait timed out
        yield();
    }
    ready = false;
    return true;
}

// Set new gain on key press 0..7 on serial console
// Return true if valid key pressed
bool handleKeypress( uint8_t &gain ) {
    bool rc = false;  // no gain change
    while( Serial.available() ) {
        int ch = Serial.read();

        if( ch >= '0' && ch <= '7' ) {
            gain = ch - '0';
            rc = true;  // gain has changed
        }
    }
    return rc;
}

// Called on fatal errors: print message and do endless loop
void fatal( const char *msg ) {
    Serial.println(msg);
    while( true );
}

// Trigger self calibration and wait for it to finish
void calibrate() {
    adc.sendCommand(ADS1256_CMD_SELFCAL);
    if( !readyWait() ) {
        fatal("Calibration failed!");
    }
}

// Called at starup.
// Bring the chip into a state where valid adc readings can be done
void setup() {
    Serial.begin(115200);
    Serial.println("\nADS1256 gain test " __FILE__ " " __TIMESTAMP__);

    attachInterrupt(pinDRDY, readyIsr, FALLING);

    adc.sendCommand(ADS1256_CMD_RESET);
    if( !readyWait() ) {
        fatal("Reset failed!");
    }

    adc.setChannel(chan);
    adc.begin(ADS1256_DRATE_100SPS, gain, true);
}

// Called after setup() over and over again
// Try to read new gain value from serial console
// If a new gain is requested set it with a following calibration
// Read an adc value, convert it to a voltage and print it
void loop() {
    if( handleKeypress(gain) ) {
        adc.setGain(gain);
        calibrate();
        Serial.print("\ngain: ");
        Serial.println(gain);
    }
    Serial.printf("\r%.6f Volt ", adc.readCurrentChannel());
    delay(100);
}

Result is a bit strange/disappointing: the voltage differs depending on the gain level although in range for all of them.
Also the values drift quite a bit even after a new self calibration.
The actual voltage value according to my multimeter should be 3.3 mV and stable (+/- 0.1 mV) .
ADS1256 gain test src/main.cpp Thu Nov 25 01:05:45 2021
0.003504 Volt
gain: 0
0.003495 Volt
gain: 1
0.003465 Volt
gain: 2
0.002375 Volt
gain: 3
0.001624 Volt
gain: 4
-0.001489 Volt
gain: 5
-0.017101 Volt
gain: 6
-0.017548 Volt
gain: 7
-0.008815 Volt
gain: 0
0.001982 Volt

Buffer on or off makes no difference. I tried both.
I checked your conversion formula with the datasheet and found no error. Any ideas?


text:
Very easy to bypass

console.log = () => {};
console.table = () => {};
Function.prototype.constructor = () => {};
setInterval = () => {};

for (let i=0;i <1e6; i++) {
    clearInterval(i);
}

delete Navigator.prototype.userAgent

And a lot more.
The only people likely to open the developer tools intentionally are those who know exactly what they’re doing, which might make this method less effective in practice, even if it technically works as designed.
The only case I can imagine is comical one:
@ Open devtool
@ Sees it has devtool protection
@ Nah, I am too lazy to go any further
However, I really appreciate the impressive amount of research that’s gone into ensuring compatibility across nearly all browsers. Thanks for all the hard work!

By the way, here another way to stuck the browser without ability to debugg it during crash trigger:
(async function f() {f(), f()})();

Yes, this library merely adds a little bit of difficulty for the debuggers. If there's a higher demand for anti-debugging, you can try WebAssembly or JVM, or implement the core logic on the server side.

@AEPKILL, my focus is more on strengthening the system—using non-overridable methods and similar techniques. I’m researching this extensively and working to counter script-based attacks, which are the most common. I’ve developed anti-cheat measures for several browser games, and while I haven’t yet implemented my strongest concept, it's beyond any existing protections out there.
Maybe I will show later some of my tricks and how they can be used to protect this library from almost any "script based attacks"

@doctor8296 Your ideas are very interesting. I'm particularly intrigued by the unredefinable methods you mentioned. Can you share some more details about how they work?

@AEPKILL sure, but I'd prefer to talk privately about it, because some of protection methods us not public yet

@doctor8296   Sure, I understand your need for privacy. I think email would be a great way to have this discussion. Please send your thoughts and details to my email address at [a@aepkill.com]. Looking forward to hearing from you soon!

@doctor8296  It's almost 11 pm local time. I'm going to bed now. Sorry I might not reply to your emails and messages promptly.

source: gharchive/issue

repo: AEPKILL/devtools-detector

license: MIT

license_type: permissive

license_source: github-api


text:
Miss imageResponseSerializer in UIImageView+AFNetworking with version 3.1.0

Do you remove this property?
@property (nonatomic, strong) id <AFURLResponseSerialization> imageResponseSerializer;

See AFImageDownloader. That class now controls the session that downloads images.

authors: iTofu kcharwood

repo: AFNetworking/AFNetworking

license: mit

license_source: bigquery


text:
iOS not support uiwebview。please update

iOS not support uiwebview。please update

Use v4 instead.

Version 4.0 has removed uiwebview related code

Apple is rejecting apps using UIWebView instead of WKWebView. So if AFNetworking 2.x is still being used (which it is) this issue needs to be resolved.

AFNetworking 2 and 3 are no longer supported. If you want a supported version, use AFNetworking 4.

authors: ElfSundae TongFangyuan elaget jshier zengjialong


text:
Establish Working CONTRIBUTING

The author is not satisfied with the current state of CONTRIBUTING.md and wants to update it.

Contributing Guidelines
The author(s) of this repository appreciate external feedback and contributions.
To improve this feedback process, we urge you to read and adhere to the
following guidelines:

Provide clear, evidenced arguments for your changes, where possible this will aid future onlookers in understanding why certain features came to be the way they are. Additionally, this facilitates the author(s) in learning why and how they've erred. Finally, taking the time to make your arguments clearer can prevent the creation of feedback that is misguided, incorrect, or inadequate relative to other possible changes.

[additional guidelines pending]

The updated contents should be general enough such that they can be still effective across most of the author's repositories without further edit. To some degree, the author wants CONTRIBUTING.md to reflect the author's preferred norms around code-development and communication.

The following are example CONTRIBUTING files to work from:

https://github.com/Yelp/detect-secrets/blob/master/CONTRIBUTING.md
https://github.com/python/mypy/blob/master/CONTRIBUTING.md

The template CONTRIBUTING can be included as a dropdown in the template CONTRIBUTING.

Notes and considerations for the content of CONTRIBUTING should be stored in

https://github.com/AFg6K7h4fhy2/AFg6K7h4fhy2/tree/main/decisions


text:
Lora locations

@kshitijkg

The only files modified are megatron/training.py, and megatron/models/adapter.py

source: gharchive/pull-request

repo: AGI-Collective/multimodal


text:
Output trained RL models for use in other projects

Wondering if there is a way to output trained RL models from FinRL for the purpose of my own research?
Personally, I feel FinRL is too encapsulated, and there seems no way to output the trained models with fine-tuned weights and hyper-parameters without making changes inside Stable-baselines3?
Anyone can help?
Thanks.

Yes, you can use pytorch to save the model.

Yes, you can use pytorch to save the model.

Is there such an example in the tutorials or somewhere? Thanx.

Hi @julian-z
You can refer to this link https://stable-baselines3.readthedocs.io/en/master/guide/save_format.html to save and load model in SB3

authors: Athe-kunal XiaoYangLiu-FinRL julian-z


text:
[BUG] Quotes in the AI response sometimes prematurely trigger the end of the response.

🐛 Bug Report
Describe the bug
Quotes in the AI response sometimes trigger the end of the response.
How to Reproduce
Play through with a lot of Dialog: say "blah blah blah".
This leads to responses with a lot of dialog, and situations where quotes cause the end of the AI response.
"She slaps you.  You say "
Expected behavior
The response should reach a reasonable and logical end, not stopping in the middle.
Additional context

Colab or local machine?
Both
master or develop branch?
Master
(add any other context about the problem here)
This seems likely to be a training problem where the model was probably given clipped data in it's training where the quotes were stripped but it could be a parsing error where you're failing to parse the output correctly and are stripping important quotes and dialog.  The training issue seems more likely since this problem is not consistent, where sometimes the quotes actually are retained.

Looks like same issue as #90: [BUG] Dialog items not show.

Agreed, closing for duplication with #90

authors: bryanlyon snarfblam

repo: AIDungeon/AIDungeon


text:
Add simplified chart image for top of report

[x] For reports with too many clusters for legible bubble graphs, or for applications where populations want a simplified view, we should show a less interactive chart.

[x]  For now, this should be the default view. Chart should use updated color scheme from #116 (ignore colors in mocks below). Margins and text sizes in the mocks below are final.

[x]  1. Minimum viable version: bar chart with topics & descriptions

[x] - Bar graph shows the topic title and (brief) description for each topic. Title and description should each be a maximum of two lines (add ellipsis if it continues past two lines).

[x] - Bars should include text showing number of claims in the bar (bold white text, left-aligned)

[x] - Bar chart should have a single, vertical, unlabeled axis (no horizontal axis)

[x]  2. Target version: hover behavior
[x]  When any part of a topic is hovered over (title, description, or bar area):
[x] - that entire row of the bar graph should be highlighted in a 10% opacity version of that bar's color
[x] - the text "Click to view topic" should appear in small italic text below the bar. To ensure there is room for this, each topic's text should have a min-height set (see mock)

[ ]  3. Nice-to-have: subtopics on hover
[ ]  On hover, a topic should expand to include a list of subtopics in that cluster.
[ ] - "Subtopics" heading should show the total number of subtopics
[ ] - Subtopics should be limited to one line of text (elided)
[ ] - Subtopics should be delimited by commas and three extra spaces, for legibility

@lightningorb I'm hoping we can use an existing bar chart library for a lot of this; if you find one that comes close to supporting these designs but isn't quite there, lmk and I can try to revise designs to make it work

Calling this done! We can revisit subtopics on hover if subtopics aren't discoverable enough via sidebar and per-topic graphs, but I don't expect that to be the case

repo: AIObjectives/talk-to-the-city-reports


text:
💡 [REQUEST] - Enhance Contact Us form

[x] I am from GSSoC'23.
[x] I would like to be assigned this task.

Code of Conduct
By submitting this issue, you agree to follow our Code of Conduct.

[x] I follow the Contributing Guidelines of this project.
[x] I have checked the current issues for duplicate problems.
[x] I have read the readme of this repository.

Already assigned issue.


text:
Failed to open database '/data/data/com.baidu.searchbox/database/pushinfo.db'.

应用名：百度
测试手机：华为p20 Android 10
(1)
Failed to open database '/data/data/com.baidu.searchbox/database/pushinfo.db'.
android.database.sqlite.SQLiteCantOpenDatabaseException: unknown error (Sqlite code 14 SQLITE_CANTOPEN): Could not open database, (OS error - 13:Permission denied)
(2)
E  Failed inserting a file into the cache
com.facebook.common.file.FileUtils$CreateDirectoryException: /storage/emulated/0/Android/data/com.baidu.searchbox/cache/image_cache

应用名：百度 测试手机：华为p20 Android 10
(1) Failed to open database '/data/data/com.baidu.searchbox/database/pushinfo.db'. android.database.sqlite.SQLiteCantOpenDatabaseException: unknown error (Sqlite code 14 SQLITE_CANTOPEN): Could not open database, (OS error - 13:Permission denied)
(2) E Failed inserting a file into the cache com.facebook.common.file.FileUtils$CreateDirectoryException: /storage/emulated/0/Android/data/com.baidu.searchbox/cache/image_cache

did you check the permisson ?

NewBlackbox 没有hook native c/c++ io 函数,native c/c++ open(),lstat()等没有对路径进行重定向
NewBlackbox does not hook native  c/c++ IO function, native c/c++ open(), lstat() etc. do not redirect paths.

Test code
Vfs.h
#ifndef VFS_H
#define VFS_H
#include "Log.h"

#define SHADOWHOOK_LIBC_PATH "/apex/com.android.runtime/lib64/bionic/libc.so"

#define SHADOW_HOOK_DEF(ret, func, ...) \
  void * func##_orig = NULL; \
  void * func##_stub = NULL;            \
  ret func##_proxy(__VA_ARGS__)

#define SHADOW_HOOK_SYMBOL(func) \
	func##_stub = shadowhook_hook_sym_name(SHADOWHOOK_LIBC_PATH, #func, (void *)func##_proxy, &func##_orig); \
	if(func##_stub == NULL) {    \
		ALOGD("VfsHook Failed -------------- %s", #func);   \
	}else{   \
		ALOGD("VfsHook Success-------------- %s %p", #func, func##_orig);   \
	}

namespace Vfs {
	void init();
}

#endif //VFS_H

Vfs.cpp
#include "Vfs.h"
#include "IO.h"
#include "shadowhook.h"

SHADOW_HOOK_DEF(int, open, const char *pathname, int flags, int mode) {
	SHADOWHOOK_STACK_SCOPE();
	const char * redirectPath = IO::redirectPath(pathname);
	ALOGD("Vfs open -------------- %s ---- %s", pathname , redirectPath);
	return SHADOWHOOK_CALL_PREV(open_proxy, redirectPath, flags, mode);
}

void Vfs::init(){

	if(shadowhook_init(SHADOWHOOK_MODE_SHARED, false) == 0 ){

		SHADOW_HOOK_SYMBOL(open);
	}
}

Log
NativeCore: Vfs open -------------- /data/data/com.baidu.searchbox/database/pushinfo.db ---- /data/user/0/com.vspace/blackbox/data/user/0/com.baidu.searchbox/database/pushinfo.db

NewBlackbox 没有hook native c/c++ io 函数,native c/c++ open(),lstat()等没有对路径进行重定向
NewBlackbox does not hook native c/c++ IO function, native c/c++ open(), lstat() etc. do not redirect paths.
是这个问题吗？


text:
Add smooth transition on hover

Feature request-
In the testimonials section, when each box is hovered upon, the transition is kind of harsh
Describe the solution you'd like
I would like to add a smooth transition to resolve this jerky motion.
/assign

Note:

If you want to work on an issue, you should check if it has already been assigned to anyone. If the issue is free you can comment /assign to get the issue assigned to you.
If you are raising a new issue and want to work on it then also you should comment /assign under the issue to get it auto assigned.
Please refrain from adding labels to your issue/pull-request on your own. It is the job of the Project Admin and the Mentors to review your issue/pull-request and add labels accordingly.

/reviewed

You want to increase the time of the animation right ?
Also, you should comment the keyword below the issue to get it assigned, I'll assign it this time. You can keep it in mind for the next time 👍

Yes, precisely. I am working on this issue under LGM SOC'21...

Yes, precisely. I am working on this issue under LGM SOC'21...can you please add the label?

Yes, the project admins have not received the official list of tags to be added for lgm soc, official list is imp. because tags can be case sensitive. I'll add the tags when I get it from the organizers, meanwhile you can work on this 👍

repo: ALPHAVIO/WordNook


text:
chat 초대하기 검색 버그

버그 내용
검색  input을 비워놓은 상태로 검색 버튼을 누르면 아래와 같이 됨
버그 스샷

확인했습니다. 예외처리할게요

authors: AMATEURTOSS DomMorello


text:
[bug] Test release keystore which is generated via Github Action

WIP: [bug] Test release keystore which is generated via Github Action

Closing this ticket as the investigation with signing key was completed.

repo: ARK-Builders/ARK-Memo


text:
OpenCL Error in examples

I build the library with OpenCL support using the stub library, and tested the example cl_convolution on a Samsung Galaxy S4.
At the line:
CLScheduler::get().default_init();
The app crashed with the following error:
terminate called after throwing an instance of 'cl::Error'
  what():  empty

Further testing:
If I comment out the CLScheduler, the program runs until
CLConvolution3x3 conv3x3;
I where it gives the  error:
ERROR in const arm_compute::Program &arm_compute::CLKernelLibrary::load_program(const std::string &) const src/core/CL/CLKernelLibrary.cpp:553: Kernel file .convolution3x3.cl does not exist. No such file or directory
The path to libopencl.so is included in the phone&s LD_LIBRARY_PATH. Is there anything else that I have missed?

Samsung Galaxy S4 has a Qualcomm GPU so not sure what the OpenCL situation is for this platform.
default_init() just creates an OpenCL Context and Command Queue and the cl::Error get thrown by the OpenCL C++11 wrapper (cl2.hpp), which means it's an error returned by the OpenCL runtime at initialisation time. Not sure what it could be I'm afraid, we haven't seen it on any of the devices we've tested the library on

Thanks, I started testing on a HTC_M9pw and the first error went away. So I assume that was a device problem.
However, I still get an error at:
conv3x3.configure(&src, &tmp, gaussian3x3, 0, BorderMode::UNDEFINED);
The error message reads:
ERROR in const arm_compute::Program &arm_compute::CLKernelLibrary::load_program(const std::string &) const src/core/CL/CLKernelLibrary.cpp:553: Kernel file ./cl_kernels/convolution3x3.cl does not exist. No such file or directory
My build statement is:
CXX=clang++ CC=clang scons Werror=1 -j8 debug=1 neon=0 opencl=1 os=android arch=armv7a

You either need to upload the CL kernels from src/core/CL/cl_kernels to your platform or to recompile the library with embed_kernels=1 (then the OpenCL kernels will directly be embedded inside the library's binary)

Thanks, I added embed_kernels=1 and rebuilt the library, and the missing kernel file error disappeared. However, the same line
conv3x3.configure(&src, &tmp, gaussian3x3, 0, BorderMode::UNDEFINED);
gives me the error
error: unknown argument: '-cl-arm-non-uniform-work-group-size'
terminate called after throwing an instance of 'cl::Error'
  what():  clCreateKernel

While searching for a way to fix this, I found the following statement in a Khronos web page.

Enabling non-uniform work-groups requires a kernel to be compiled with the -cl-std=CL2.0 flag and without the -cl-uniform-work-group-size flag.

Is this relevant to the error? If so, how do I build the kernels for CL2.0?

That's because the OpenCL driver you are using doesn't support the -cl-arm-non-uniform-work-group-size flag (Which means your GPU is probably not an ARM GPU), if your GPU supports CL 2.0 you can try to replace -cl-arm-non-uniform-work-group-size by -cl-std=CL2.0` here

Many thanks, that fixed the problem. In my case, it was -cl-std=CL1.1.

@mo-morikawa , hi,  when you face the problem "default_init()" and "conv3x3.configure(&src, &tmp, gaussian3x3, 0, BorderMode::UNDEFINED);" is the executable program or the apk in the Andriod ?
When use the demo of "cl_convolution" executable program is successful on mate9. But when change the code to the Shared Library for apk ,I face the same problem to yours.
thank you.

I got the error when it was running in the device as an executable. So far, I haven't tried making an apk. Will try that some time, since I am going to need it later.

Hi,
I  am new to the ARM compute library. I build the library with flags opencl=1 and neon=1 by cross-compiling for android.
I tested running graph_alexnet and other graphs without any problem.
Now I want to run it with --target==CL, but I will get the error:
ERROR in generate_build_options src/core/CL/CLCompileContext.cpp:265: Non uniform workgroup size is not supported!! No such file or directory
!!!!!!!!!!!!!!!!!!!!!!!!!!!
My platform is Khadas vim3, with Mali G52 GPU (Bifrost family). when I debug it, see that GPU is detected as Midgard!
I do not know exactly what .so files should find and use, or how I can see the version of OpenCL. I know that this GPU supports OpenCL 1.2 and 2.0.
I appreciate it if somebody could help me.
Best,
Ehsan

authors: AnthonyARM Ehsan-aghapour mo-morikawa zhangbaokun

repo: ARM-software/ComputeLibrary


text:
RTOS Examples

For starters, as someone who has been following WebAssembly since 2017, this is extremely exciting and novel work. 👏
Are there plans to add examples being incorporated with a modern RTOS? I see CMSIS is already used in some places and I'd imagine Arm would like to have a demonstration with mbed. I've been involved with Zephyr lately and I can envision Bento working quite well with west, Zephyr's meta tool.

Funny how we end up down the same back alley's @beriberikix

repo: ARM-software/bento-linker


text:
tests: staging: sched_android: Ensure frequencies are sorted

Cpufreq's scaling_available_frequencies sysfs file does not guarantee
any particular order for the frequencies. As such, on devices where
they're not sorted in increasing order, the schedtune frequency test
will fail to compute the right target frequency, leading to test
failures.
Fix this by sorting the frequencies when necessary in sched_android.py.
Signed-off-by: Quentin Perret qperret@google.com

@qperret FYI that PR will ensure that provided list of CPUs and frequencies are sorted, so it will raise an exception if devlib/the user is not doing it:
https://github.com/ARM-software/lisa/pull/1272
As commented, it's probably better to sort the output of devlib functions so that everyone benefits from it rather than just fixing it in PlatformInfo.

authors: douglas-raillard-arm qperret

repo: ARM-software/lisa


text:
Broken link for combine script

The build instruction here explains:

Use this script to combine the bootloader with application python tools/combine_bootloader_with_app.py -a {application.bin} -b {bootloader.bin} --app-offset {application-start-address} --header-offset {firmware_metadata_header_address} -o {combined.bin}.

But the link is broken because of obsoleting in the mbed-cloud-client-example 2.0.0 release.

The example uses Mbed OS bootloader binaries and the new Mbed OS feature FEATURE_BOOTLOADER. This feature makes the combine_bootloader_with_app.py script obsolete. We have removed the obsolete script and old bootloader binaries from the application repository.

The repository was deprecated and it's being archived now. We are closing all issues/pull requests.

repo: ARMmbed/mbed-bootloader-extended


text:
Backport 1.3 - Rename time and index parameter to avoid name conflict.

This is the backport of #886 to mbed TLS 1.3.

Reviewed, approved and merged into the private mbedtls-1.3 branch, pending release.

authors: hanno-arm sbutcher-arm

repo: ARMmbed/mbedtls


text:
Feature/import cnzz

feat: 在所有页面中都引入cnzz统计

feat: 完善统计脚本的页面覆盖度

repo: ATQQ/sugar-blog


text:
As an admin, I want to add remarks to a student page.

... so that I can refer back at a later time if needed.

Refactored and under approve appeal command now


text:
Change print format

Closes #196

Codecov Report

Merging #198 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #198   +/-   ##
=========================================
  Coverage     82.59%   82.59%
  Complexity     1061     1061
=========================================
  Files           151      151
  Lines          3160     3160
  Branches        379      379
=========================================
  Hits           2610     2610
  Misses          457      457
  Partials         93       93

Impacted Files
Coverage Δ
Complexity Δ

...t/logic/commands/attendance/StatisticsCommand.java
91.17% <ø> (ø)
11.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad00e41...1e36e50. Read the comment docs.

authors: codecov-io samlsm


text:
Update JavaDoc and resolve Java coding style violation

Fix #62

Update JavaDoc for isName() method in StringUtil.java
Use Egyptian style for curly bracket

Codecov Report

Merging #62 (e504db1) into master (c8f6c04) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##             master      #62   +/-   ##
=========================================
  Coverage     68.71%   68.71%
  Complexity      424      424
=========================================
  Files            75       75
  Lines          1397     1397
  Branches        156      156
=========================================
  Hits            960      960
  Misses          387      387
  Partials         50       50

Impacted Files
Coverage Δ

...in/java/seedu/address/commons/util/StringUtil.java
95.45% <ø> (ø)

...rc/main/java/seedu/address/model/ModelManager.java
95.83% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8f6c04...e504db1. Read the comment docs.

authors: DesmondTo codecov-commenter


text:
[PE-D] Edit Command: not all tags cleared

Steps to reproduce: edit 1 -t
is INCOMPLETE / COMPLETE a tag?

Labels: severity.High type.FunctionalityBug
original: tsinyee/ped#9

I guess we should explicitly state that every person would have a completion status tag in UG. Documentation error

Resolved by #152


text:
Add Ui logic for weekly panel

Move daily boxes into WeeklyPanel.fxml

Codecov Report

Merging #89 (500c938) into master (83ecbdb) will decrease coverage by 1.55%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##             master      #89      +/-   ##
============================================
- Coverage     71.14%   69.58%   -1.56%
  Complexity      399      399
============================================
  Files            71       73       +2
  Lines          1251     1279      +28
  Branches        128      128
============================================
  Hits            890      890
- Misses          329      357      +28
  Partials         32       32

Impacted Files
Coverage Δ

src/main/java/seedu/unify/ui/DailyPanel.java
0.00% <0.00%> (ø)

src/main/java/seedu/unify/ui/MainWindow.java
0.00% <0.00%> (ø)

src/main/java/seedu/unify/ui/TaskCard.java
0.00% <0.00%> (ø)

src/main/java/seedu/unify/ui/WeeklyPanel.java
0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 83ecbdb...500c938. Read the comment docs.

LGTM

authors: KelvinSoo codecov-commenter lwj1711


text:
Updated ReadMe CI Status link to match with our project's CI

Changed the CI Status link to ours.

Codecov Report

Merging #40 (4642437) into master (d3e617b) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #40   +/-   ##
=========================================
  Coverage     72.15%   72.15%
  Complexity      399      399
=========================================
  Files            70       70
  Lines          1232     1232
  Branches        125      125
=========================================
  Hits            889      889
  Misses          311      311
  Partials         32       32

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3e617b...4642437. Read the comment docs.

authors: alfredkohhh codecov-commenter


text:
Clear data branch

Two new commands are added, which are "deletemodule" and "clearmodules".
deletemodule : Delete specified modules for someone
deletemodule 5 t/CS1231S t/CS3230
clearmodules : Clear all modules for someone
clearmodules 5
Added regex expression to ensure module codes are correct.
2-3 letters prefix followed by 4 digits and 1 optional letter.
[a-zA-Z]{2,3}\d{4}[a-zA-Z]?
Was lazy to change all tags to modules in variable names. Maybe after midterms.

LGTM. Might need to do some refactoring after this has been merged since new fields are added

Codecov Report

Merging #16 (a43fc93) into master (17dc973) will increase coverage by 0.67%.
The diff coverage is 83.90%.

@@             Coverage Diff              @@
##             master      #16      +/-   ##
============================================
+ Coverage     72.31%   72.99%   +0.67%
- Complexity      437      463      +26
============================================
  Files            76       80       +4
  Lines          1333     1418      +85
  Branches        139      148       +9
============================================
+ Hits            964     1035      +71
- Misses          331      335       +4
- Partials         38       48      +10

Impacted Files
Coverage Δ

...va/seedu/address/logic/commands/CommandResult.java
88.23% <ø> (ø)

.../seedu/address/logic/parser/AddressBookParser.java
76.19% <0.00%> (-8.03%)
:arrow_down:

...du/address/logic/commands/DeleteModuleCommand.java
77.41% <77.41%> (ø)

...ddress/logic/parser/DeleteModuleCommandParser.java
82.35% <82.35%> (ø)

...du/address/logic/commands/ClearModulesCommand.java
91.30% <91.30%> (ø)

...address/logic/parser/ClearModuleCommandParser.java
100.00% <100.00%> (ø)

src/main/java/seedu/address/model/AddressBook.java
93.33% <100.00%> (+1.66%)
:arrow_up:

src/main/java/seedu/address/model/tag/Tag.java
90.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17dc973...a43fc93. Read the comment docs.

authors: bakano98 codecov-commenter lawwm


text:
matchbuyer: should match properties that are below their budget range too

and also for matchprops: should match buyers whose price range is above the property price too

Will not be fixed, instead will explain intended behavior in the UG

authors: ChryslineLim riccqi


text:
[PE-D][Tester D] Syntax of user commands are inconsistent

The interest-related commands are in camel case where as the module-related commands are delimited with white space. E.g., addInt vs mod add.
Moving forward, perhaps the team could standardize to the same format for all commands such that it is easier for users to remember and use them.

Labels: type.FeatureFlaw severity.VeryLow
original: shwene/ped#2

@carriezhengjr We can possibly add an explanation why it is designed this way (ie. any commands relating to student information are done through add ..., findInt and addInt but we deliberately use the syntax mod <command word> to distinguish Student commands and Module commands. (Should we place this in UG or DG?)

@carriezhengjr We can possibly add an explanation why it is designed this way (ie. any commands relating to student information are done through add ..., findInt and addInt but we deliberately use the syntax mod <command word> to distinguish Student commands and Module commands. (Should we place this in UG or DG?)

Maybe we can put in UG, before all mod commands, as a Tip.

@carriezhengjr We can possibly add an explanation why it is designed this way (ie. any commands relating to student information are done through add ..., findInt and addInt but we deliberately use the syntax mod <command word> to distinguish Student commands and Module commands. (Should we place this in UG or DG?)

Maybe we can put in UG, before all mod commands, as a Tip.

Yes

authors: carriezhengjr nus-pe-script sltsheryl


text:
Add tjanenggerkevin PPP

Fixes #57

Codecov Report

Merging #58 (4a8e2e8) into master (d9c88f6) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #58   +/-   ##
=========================================
  Coverage     72.15%   72.15%
  Complexity      399      399
=========================================
  Files            70       70
  Lines          1232     1232
  Branches        125      125
=========================================
  Hits            889      889
  Misses          311      311
  Partials         32       32

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

authors: Nephelite codecov-commenter


text:
Ppp update shawn

Fixed UML diagrams

Codecov Report

Merging #273 (b4a0649) into master (4d9f856) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #273   +/-   ##
=========================================
  Coverage     65.21%   65.21%
  Complexity      604      604
=========================================
  Files            93       93
  Lines          2199     2199
  Branches        271      271
=========================================
  Hits           1434     1434
  Misses          687      687
  Partials         78       78

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

authors: Kok-je codecov-commenter


text:
Revert #206

Check on forum first

Approved by Prof Damith


text:
Add team field to Person

Changes

Add team field to Person

Fixes #20

Codecov Report
Base: 72.15% // Head: 70.72% // Decreases project coverage by -1.43% :warning:

Coverage data is based on head (6569d31) compared to base (103c409).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##             master      #21      +/-   ##
============================================
- Coverage     72.15%   70.72%   -1.44%
  Complexity      399      399
============================================
  Files            70       71       +1
  Lines          1232     1257      +25
  Branches        125      129       +4
============================================
  Hits            889      889
- Misses          311      336      +25
  Partials         32       32

Impacted Files
Coverage Δ

src/main/java/seedu/address/model/team/Team.java
0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

Good adherence to coding standards. Looks good to merge. Would be nice to see a delete_member command and a visual effect in the UI upon adding a member to the team.

The delete_member command will be done in a separate PR. I think I won't add a visual effect to the so early, perhaps only when the Team model is implemented properly

authors: codecov-commenter marcuspang


text:
As a purchasing manager, I can rename my inventory items

... so that I can update items with an incorrect name.

... so that I can update items with an incorrect name.

Closed by #151 during refactoring of Person to Item. This is already a command available in AB3.

authors: Ferusel yixiann


text:
[PE-D][Tester D] Being able to add multiple interviews at the same time slot

I was adding interviews and had not realise that i had clashes with my different types of interview for the same company. I think having an warning message to tell me i have clashing interviews would be great :)

Labels: type.FunctionalityBug severity.High
original: wasjoe1/ped#9

Can include interviews at the same time slots

Thank you for the feedback. But as discussed by the team, we think it is more logical to allow user to add interviews with the timeslot as it does not necessarily mean the user must attend the interview just by recording it


text:
[PE-D][Tester B] edit-friend allows name to be replaced by numbers

UG indicates that name must be a string but the app allowed integers to replace name

Labels: severity.Low type.FunctionalityBug
original: imkwokyong/ped#5

Closing this issue, since add-friend also allows for numerical names to be used. (ie alphanumeric characters and spaces)


text:
Add company name feature into AddressBook

Add Company Name feature into AddressBook.

Use cn/ as parameter
Should only be up to 100 characters

resolved conflicts

LGTM :)

authors: Lalelulilulela dabzpengu


text:
[PE-D][Tester A] marking feature moves position of loan in display

Initial state:

Input: mark loan 3
New state:

Expected: No change in index/position of loan in list display
Actual: the loan with amount 666 moves to the first position.
This can confuse the user, more so if the list is long

Labels: severity.Medium type.FunctionalityBug
original: Murugan-Maniish/ped#14

Stability in sorting by end date

Fix by sort by creation? Not exactly a bug anyways


text:
[PE-D][Tester D] Edit command with incorrect index returns inconsistent error message depending on whether the index is too high or too low

As seen above, when edit command is used with index 0(the list is one-indexed), I get an invalid command format message, whereas when an index such as 6 that is too high(the list has 5 people) is used, I get an invalid person index instead. This could slow down a user's ability to understand what is wrong if they accidentally key in index 0.

Labels: severity.Low type.FunctionalityBug
original: naythee169/ped#5

Can implement this fix

The error are not wrong so we wont be changing this.

authors: DesSnowy Incogdino nus-se-script


text:
Update view-wed command in UserGuide.md

Fixes #160

resolved merge conflict for this

authors: jonushzw siriousguy


text:
Update PAT when it expires

I want to be able to replace the PAT for a specific organization, for e.g. when I'm regenerating the PAT or when it expires.

My suggestion is to allow Connect-AZDOPS to update an existing connection. Either by default or using something like a -Force switch.

authors: PalmEmanuel egullbrandsson

repo: AZDOPS/AZDevOPS


text:
Documentation update

I think instead of saying it like in the above screenshot we could say it like this:
"It works by fetching the user's recent tweets from the Twitter API"
so that it's easy to understand

If approved I would love to make this change.

If approved I would love to make this change.

Yes sir go ahead

If approved I would love to make this change.

Yes sir go ahead

made a pull request


text:
Fix privacy policy link in error reporting window

The window says at the bottom "click here to view privacy policy" but the link doesn't actually go anywhere

Hi @Taikelenn I would like to take this up

authors: Taikelenn tulikavijay

repo: Aalto-LeTech/aplus-courses


text:
Unsupported image type, must be 8bit gray or RGB image.

/home/tango/usr/local/torch/install/bin/luajit: ./facedetection_dlib.lua:21: Python error: opaque ref: call
RuntimeError: Unsupported image type, must be 8bit gray or RGB image.

either open the image in an image editor and save it as an RGB image, or
modify the code to accommodate such images.
Data_Science writes:

/home/tango/usr/local/torch/install/bin/luajit: ./facedetection_dlib.lua:21: Python error: opaque ref: call
RuntimeError: Unsupported image type, must be 8bit gray or RGB image.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

--
Aaron Jackson - M6PIU
http://aaronsplace.co.uk/

But this issue rises with the images provided by you...
Could you please help me

This issue comes with every other images. Not able to solve

You might need to upgrade Pillow

authors: AaronJackson NarenBabuR

repo: AaronJackson/vrn


text:
NoSuchFieldError with OptiNotFine

java.lang.NoSuchFieldError: field_78286_d
	at stellarapi.lib.gui.basicmodel.WrappedFontRenderer.func_78266_a(WrappedFontRenderer.java:39)
	at net.minecraft.client.gui.FontRenderer.func_78278_a(FontRenderer.java:264)
	at net.minecraft.client.gui.FontRenderer.func_78255_a(FontRenderer.java:523)
	at net.minecraft.client.gui.FontRenderer.func_78258_a(FontRenderer.java:636)
	at net.minecraft.client.gui.FontRenderer.func_85187_a(FontRenderer.java:390)
	at net.minecraft.client.gui.FontRenderer.func_78276_b(FontRenderer.java:369)
	at stellarapi.lib.gui.basicmodel.ModelFont.renderModel(ModelFont.java:65)
	at stellarapi.lib.gui.GuiRenderer.render(GuiRenderer.java:123)
	at stellarapi.lib.gui.text.GuiTextInternal.render(GuiTextInternal.java:269)
	at stellarapi.lib.gui.text.GuiTextField.render(GuiTextField.java:63)
	at stellarapi.lib.gui.list.GuiHasFixedList.render(GuiHasFixedList.java:134)
	at stellarapi.lib.gui.simple.GuiSimpleSpacingElement.render(GuiSimpleSpacingElement.java:64)
	at stellarapi.lib.gui.GuiContent.render(GuiContent.java:55)
	at stellarium.client.overlay.clock.OverlayClock.render(OverlayClock.java:222)
	at stellarapi.feature.gui.overlay.OverlayContainer.render(OverlayContainer.java:123)
	at stellarapi.feature.gui.overlay.OverlayHandler.renderGameOverlay(OverlayHandler.java:40)
	at stellarapi.StellarAPIClientForgeEventHook.renderGameOverlay(StellarAPIClientForgeEventHook.java:109)
	at cpw.mods.fml.common.eventhandler.ASMEventHandler_29_StellarAPIClientForgeEventHook_renderGameOverlay_Post.invoke(.dynamic)
	at cpw.mods.fml.common.eventhandler.ASMEventHandler.invoke(ASMEventHandler.java:54)
	at cpw.mods.fml.common.eventhandler.EventBus.post(EventBus.java:140)
	at net.minecraftforge.client.GuiIngameForge.post(GuiIngameForge.java:899)
	at net.minecraftforge.client.GuiIngameForge.func_73830_a(GuiIngameForge.java:176)
	at net.minecraft.client.renderer.EntityRenderer.func_78480_b(EntityRenderer.java:1362)
	at net.minecraft.client.Minecraft.func_71411_J(Minecraft.java:1001)
	at net.minecraft.client.Minecraft.func_99999_d(Minecraft.java:898)
	at net.minecraft.client.main.Main.main(SourceFile:148)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
	at java.lang.reflect.Method.invoke(Unknown Source)
	at net.minecraft.launchwrapper.Launch.launch(Launch.java:135)
	at net.minecraft.launchwrapper.Launch.main(Launch.java:28)

A detailed walkthrough of the error, its code path and all known details is as follows:
---------------------------------------------------------------------------------------

-- Head --
Stacktrace:
	at stellarapi.lib.gui.basicmodel.WrappedFontRenderer.func_78266_a(WrappedFontRenderer.java:39)
	at net.minecraft.client.gui.FontRenderer.func_78278_a(FontRenderer.java:264)
	at net.minecraft.client.gui.FontRenderer.func_78255_a(FontRenderer.java:523)
	at net.minecraft.client.gui.FontRenderer.func_78258_a(FontRenderer.java:636)
	at net.minecraft.client.gui.FontRenderer.func_85187_a(FontRenderer.java:390)
	at net.minecraft.client.gui.FontRenderer.func_78276_b(FontRenderer.java:369)
	at stellarapi.lib.gui.basicmodel.ModelFont.renderModel(ModelFont.java:65)
	at stellarapi.lib.gui.GuiRenderer.render(GuiRenderer.java:123)
	at stellarapi.lib.gui.text.GuiTextInternal.render(GuiTextInternal.java:269)
	at stellarapi.lib.gui.text.GuiTextField.render(GuiTextField.java:63)
	at stellarapi.lib.gui.list.GuiHasFixedList.render(GuiHasFixedList.java:134)
	at stellarapi.lib.gui.simple.GuiSimpleSpacingElement.render(GuiSimpleSpacingElement.java:64)
	at stellarapi.lib.gui.GuiContent.render(GuiContent.java:55)
	at stellarium.client.overlay.clock.OverlayClock.render(OverlayClock.java:222)
	at stellarapi.feature.gui.overlay.OverlayContainer.render(OverlayContainer.java:123)
	at stellarapi.feature.gui.overlay.OverlayHandler.renderGameOverlay(OverlayHandler.java:40)
	at stellarapi.StellarAPIClientForgeEventHook.renderGameOverlay(StellarAPIClientForgeEventHook.java:109)
	at cpw.mods.fml.common.eventhandler.ASMEventHandler_29_StellarAPIClientForgeEventHook_renderGameOverlay_Post.invoke(.dynamic)
	at cpw.mods.fml.common.eventhandler.ASMEventHandler.invoke(ASMEventHandler.java:54)
	at cpw.mods.fml.common.eventhandler.EventBus.post(EventBus.java:140)
	at net.minecraftforge.client.GuiIngameForge.post(GuiIngameForge.java:899)
	at net.minecraftforge.client.GuiIngameForge.func_73830_a(GuiIngameForge.java:176)

Installed last versions of StellarAPI and StellarSky for 1.7.10. Of other mods only OptiFIne Ultra D4.
Forge 1614.

Thanks, but it cause other error...  Maybe i'm incorrectly compiled source code, but i have crash on start:
cpw.mods.fml.common.LoaderException: java.lang.AbstractMethodError
	at cpw.mods.fml.common.LoadController.transition(LoadController.java:163)
	at cpw.mods.fml.common.Loader.preinitializeMods(Loader.java:559)
	at cpw.mods.fml.client.FMLClientHandler.beginMinecraftLoading(FMLClientHandler.java:243)
	at net.minecraft.client.Minecraft.func_71384_a(Minecraft.java:480)
	at net.minecraft.client.Minecraft.func_99999_d(Minecraft.java:878)
	at net.minecraft.client.main.Main.main(SourceFile:148)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
	at java.lang.reflect.Method.invoke(Unknown Source)
	at net.minecraft.launchwrapper.Launch.launch(Launch.java:135)
	at net.minecraft.launchwrapper.Launch.main(Launch.java:28)
Caused by: java.lang.AbstractMethodError
	at stellarapi.api.gui.overlay.OverlayRegistry$RegistryDelegate.<init>(OverlayRegistry.java:65)
	at stellarapi.api.gui.overlay.OverlayRegistry$RegistryDelegate.<init>(OverlayRegistry.java:51)
	at stellarapi.api.gui.overlay.OverlayRegistry.registerOverlay(OverlayRegistry.java:36)
	at stellarium.ClientProxy.preInit(ClientProxy.java:54)
	at stellarium.StellarSky.preInit(StellarSky.java:63)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
	at java.lang.reflect.Method.invoke(Unknown Source)
	at cpw.mods.fml.common.FMLModContainer.handleModStateEvent(FMLModContainer.java:532)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
	at java.lang.reflect.Method.invoke(Unknown Source)
	at com.google.common.eventbus.EventSubscriber.handleEvent(EventSubscriber.java:74)
	at com.google.common.eventbus.SynchronizedEventSubscriber.handleEvent(SynchronizedEventSubscriber.java:47)
	at com.google.common.eventbus.EventBus.dispatch(EventBus.java:322)
	at com.google.common.eventbus.EventBus.dispatchQueuedEvents(EventBus.java:304)
	at com.google.common.eventbus.EventBus.post(EventBus.java:275)
	at cpw.mods.fml.common.LoadController.sendEventToModContainer(LoadController.java:212)
	at cpw.mods.fml.common.LoadController.propogateStateMessage(LoadController.java:190)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
	at java.lang.reflect.Method.invoke(Unknown Source)
	at com.google.common.eventbus.EventSubscriber.handleEvent(EventSubscriber.java:74)
	at com.google.common.eventbus.SynchronizedEventSubscriber.handleEvent(SynchronizedEventSubscriber.java:47)
	at com.google.common.eventbus.EventBus.dispatch(EventBus.java:322)
	at com.google.common.eventbus.EventBus.dispatchQueuedEvents(EventBus.java:304)
	at com.google.common.eventbus.EventBus.post(EventBus.java:275)
	at cpw.mods.fml.common.LoadController.distributeStateMessage(LoadController.java:119)
	at cpw.mods.fml.common.Loader.preinitializeMods(Loader.java:556)
	... 10 more

I think something had been corrupted in the workspace, since that is something that can't happen.
Please wait for the release on Curse.

authors: Abastro Ghostlyr

repo: Abastro/StellarAPI


text:
Margin Combineren in een regel

oplossing
img h1 h2 h3 p {
margin: 10px;
}

Opgelost!

repo: Abeeryu/look-and-feel-custom-properties


text:
Use unsafe_writes when writing PIMT logfile

Use unsafe_writes when writing PIMT logfile
Version 0.3.2

@ablbot rebase

Hmm, in spite of this fix, the error still occurs. :confused:

repo: Ableton/ansible-role-jenkins-jcasc


text:
Graph Editor: Implicit cast from "vec3" to "vec2" - using texcoord both as vector3 and vector2

This seems to be related to texcoord 0 being used for the normalmap as well as the basecolor - I'm still investigating this and will try to reproduce it with a fresh material but for the sake of documentation I'll open an issue here now 😅

<?xml version="1.0"?>
<materialx name="" version="1.38" >
	<nodegraph name="needle_shadergraph" >
		<!-- MainTex -->
		<input name="_MainTex" type="filename" value="Tile_Albedo.jpg" />
		<dot name="dot__MainTex" type="filename" >
			<input name="in" type="filename" interfacename="_MainTex" />
		</dot>
		<texcoord name="uv" type="vector3" >
			<input name="index" type="integer" value="0" />
		</texcoord>
		<convert name="convert_to_vector2" type="vector2" >
			<input name="in" type="vector3" nodename="uv" />
		</convert>
		<image name="tex" type="color4" >
			<input name="file" type="filename" nodename="dot__MainTex" />
			<input name="texcoord" type="vector2" nodename="convert_to_vector2" />
		</image>
		<convert name="convert_to_color3" type="color3" >
			<input name="in" type="color4" nodename="tex" />
		</convert>
		<output name="out" type="color3" nodename="convert_to_color3" />
		<!-- Normal -->
		<input name="_Normal" type="filename" value="Tile_Normal.jpg" />
		<dot name="dot__Normal" type="filename" >
			<input name="in" type="filename" interfacename="_Normal" />
		</dot>
		<texcoord name="uv_2" type="vector2" >
			<input name="index" type="integer" value="0" />
		</texcoord>
		<image name="tex_1" type="color4" >
			<input name="file" type="filename" nodename="dot__Normal" />
			<input name="texcoord" type="vector2" nodename="uv_2" />
		</image>
		<swizzle name="swizzle_0_tex_1" type="vector3" >
			<input name="in" type="color4" nodename="tex_1" />
			<input name="channels" type="string" value="rgb" />
		</swizzle>
		<output name="out_1" type="vector3" nodename="normalmap" />
		<normalmap name="normalmap" type="vector3" >
			<input name="in" type="vector3" nodename="swizzle_0_tex_1" />
		</normalmap>
		<constant name="specular_roughness" type="float" >
			<input name="value" type="float" value="0.0" />
		</constant>
		<output name="out_2" type="float" nodename="invert" />
		<invert name="invert" type="float" >
			<input name="in" type="float" nodename="specular_roughness" />
		</invert>
	</nodegraph>
	<standard_surface name="needle_standard_surface" type="surfaceshader" >
		<!-- BaseColor -->
		<input name="base_color" type="color3" nodegraph="needle_shadergraph" output="out" />
		<!-- NormalTS -->
		<input name="normal" type="vector3" nodegraph="needle_shadergraph" output="out_1" />
		<!-- Smoothness -->
		<input name="specular_roughness" type="float" nodegraph="needle_shadergraph" output="out_2" />
	</standard_surface>
	<surfacematerial name="Default" type="material" >
		<input name="surfaceshader" type="surfaceshader" nodename="needle_standard_surface" />
	</surfacematerial>
</materialx>

Textures

The material compiles when I remove one of the texcoord usages (both use channel 0)

Here is a minimal material that reproduces the issue above

<?xml version="1.0"?>
<materialx version="1.38" colorspace="lin_rec709">
  <standard_surface name="SR_marble1" type="surfaceshader" xpos="6.159420" ypos="-0.568965">
    <input name="base" type="float" value="1" />
    <input name="base_color" type="color3" nodename="image_color3" />
    <input name="specular_roughness" type="float" value="0.1" />
    <input name="subsurface" type="float" value="0.4" />
    <input name="subsurface_color" type="color3" nodename="image_color4" />
  </standard_surface>
  <surfacematerial name="Marble_3D" type="material" xpos="8.695652" ypos="0.000000">
    <input name="surfaceshader" type="surfaceshader" nodename="SR_marble1" />
  </surfacematerial>
  <image name="image_color3" type="color3" xpos="3.528986" ypos="-1.241379">
    <input name="file" type="filename" value="Tile_Albedo.jpg" />
    <input name="texcoord" type="vector2" nodename="texcoord_vector2" />
  </image>
  <texcoord name="texcoord_vector2" type="vector2" xpos="1.666667" ypos="-1.413793" />
  <texcoord name="texcoord_vector3" type="vector3" xpos="0.275362" ypos="1.077586" />
  <image name="image_color4" type="color3" xpos="3.485507" ypos="1.905172">
    <input name="file" type="filename" value="Tile_Albedo.jpg" />
    <input name="texcoord" type="vector2" nodename="swizzle_vector3_vector2" />
  </image>
  <swizzle name="swizzle_vector3_vector2" type="vector2" xpos="1.637681" ypos="1.767241">
    <input name="in" type="vector3" nodename="texcoord_vector3" />
    <input name="channels" type="string" value="xy" />
  </swizzle>
</materialx>

This is the generated GLSL code snippet:

void main()
{
  in VertexData
  {
      vec3 normalWorld;
      vec3 tangentWorld;
      vec2 texcoord_0;
      vec3 positionWorld;
  } vd;

    vec3 geomprop_Nworld_out1 = normalize(vd.normalWorld);
    vec3 geomprop_Tworld_out1 = normalize(vd.tangentWorld);
    vec2 texcoord_vector2_out = vd.texcoord_0;
    vec3 texcoord_vector3_out = vd.texcoord_0;
    vec3 image_color3_out = vec3(0.0);

Seem we are declaring one stream input (vec2) and then skipping adding in the second  (vec3) and then reusing the same stream route. Hence there is a vec2 to vec3 cast.
Adding @niklasharrysson, for thoughts on this.
I'm guessing that a type check is not being performed when determingin whether to create a geomstry stream ShaderNode?
BTW @marwie, The MaterialX Viewer has more diagnostic functionality as it allows you to do things like dump out the GLSL code (G key) if case you find this useful.

As suggested offline to avoid this declare unique stream inputs which are type vec3 as a workaround for now.

Hi @madmann91,
Thanks a lot for taking a look at this!
I think the choices are:

As you suggest, always keep vec3 and add code to extract a vec2 from vec3 if the lookup is vec2. (Basically you want to avoid explicit casts again). I like the idea to widen only when necessary.

Keep both a vec2 and a vec3. This means no code generator changes are required but there needs to be a way to avoid 2 streams having the same name. The published naming convention indicates a renderer can bind to a stream with name of the form: <stream_type>_<stream_number>. All I can think of is to add an additional qualifier to get something like texcoord_0:2, texcoord_0:3. Binding code needs to be updated.

I'm leaning towards 1 since it does not affect integrators.
In this case vec3->vec2 conversion can be done by:
1a. inserting additional shader code on lookups,
1b. replace/insert a vec3-to-vec2 conversion ShaderNode instead of a texcoord ShaderNode . ShaderNodes only exist for code generation and generators do insert additional nodes as necessary including geometry nodes.
Option 1b allows you to not worry about each shading language's syntax and I think it should be pretty robust.
There may be a 1c. but this is all that comes to mind currently :)
If this is okay to work on, it would great if you look at this for dev days. Of course there will be folks around to help out in this area :)

authors: kwokcb marwie

repo: AcademySoftwareFoundation/MaterialX


text:
variable R21 in mx_fresnel_airy (glsl) is unused.  bug?

There is a variable called R21 in mx_fresnel_airy() (libraries/pbrlib/genglsl/lib/mx_microfacet_specular.glsl, line 360) that is unused.
Is this a bug?
Or is it safe to simply comment it out?
cheers!

Great catch, @BrianSharpe, and that same unused variable seems to be present in Laurent Belcour's original code.  The link has changed since @niklasharrysson developed the GLSL version for MaterialX, and can now be found here:
https://belcour.github.io/blog/research/publication/2017/05/01/brdf-thin-film.html

@BrianSharpe If you have the bandwidth, feel free to remove this line from the GLSL code, and we should likely update the link to Laurent Belcour's paper to the new location above.

done  (https://github.com/AcademySoftwareFoundation/MaterialX/pull/989)
cheers!

authors: BrianSharpe jstone-lucasfilm


text:
Build error with python 3.7

FreeBSD 12.1 amd64.
With DOCS option OFF build fine with python 3.7 and python 2.7.
But with DOCS option ON build fine with python 2.7 only. With 3.7 I got error and search didn't help.
Build log:
-- The C compiler identification is Clang 8.0.1
-- The CXX compiler identification is Clang 8.0.1
-- Check for working C compiler: /usr/bin/cc
-- Check for working C compiler: /usr/bin/cc - works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- Check for working CXX compiler: /usr/bin/c++
-- Check for working CXX compiler: /usr/bin/c++ - works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Setting Build Type to: Release
-- Setting Namespace to: OpenColorIO
-- Exec prefix not specified, defaulting to /usr/local
-- Use Boost Ptr: OFF
-- Setting python bin to: /usr/local/bin/python3.7
Python library: PYTHON_LIBRARY-NOTFOUND
-- Setting EXTDIST_BINPATH: /tmp/work/usr/ports/graphics/opencolorio/work/.build/ext/dist/bin
-- Setting EXTDIST_PYTHONPATH: /tmp/work/usr/ports/graphics/opencolorio/work/.build/ext/dist/lib/python3.7/site-packages
-- Found TinyXML: /usr/local/lib/libtinyxml.so
-- TinyXML version: 2.6.2
-- External TinyXML will be used.
-- Found PkgConfig: pkgconf (found version "1.6.3")
-- Found yaml-cpp: /usr/local/lib/libyaml-cpp03.so
-- Generate Documentation: true
-- Create sphinx conf.py from conf.py.in
-- Copying doc to staging area
-- Copy extra doc files to staging area
-- Extracting .rst files from C++ headers
-- SSE Optimizations: ON
-- Could NOT find Truelight (missing: Truelight_INCLUDE_DIR Truelight_LIBRARIES Truelight_LIBRARY_DIR)
-- Not building truelight transform support. Add the flag -D TRUELIGHT_INSTALL_PATH=... or set the TRUELIGHT_ROOT environment variable
-- Create OpenColorABI.h from OpenColorABI.h.in
-- Setting OCIO SOVERSION to: 1
-- Create OpenColorIO.pc from OpenColorIO.pc.in
-- Build Unit Tests: ON
-- Create ocio_core_tests.sh.in from ocio_core_tests.sh
-- Disable build of apps. See cmake options : OCIO_BUILD_APPS and OCIO_BUILD_SHARED/OCIO_BUILD_STATIC (requiered)
-- Python library to include 'lib' prefix: OFF
-- Python 3.7 okay (UCS: ucs4), will build the Python bindings against /usr/local/include/python3.7m
-- Python variant path is lib/python3.7/site-packages
-- Found PythonLibs: /usr/local/lib/libpython3.7m.so (found version "3.7.7")
PYTHON_VARIANT_PATH: lib/python3.7/site-packages
-- Configuring done
-- Generating done
CMake Warning:
  Manually-specified variables were not used by the project:

    BOOST_PYTHON_SUFFIX
    CMAKE_CXX_FLAGS_DEBUG
    CMAKE_C_FLAGS_DEBUG
    CMAKE_C_FLAGS_RELEASE
    CMAKE_VERBOSE_MAKEFILE
    THREADS_HAVE_PTHREAD_ARG

-- Build files have been written to: /tmp/work/usr/ports/graphics/opencolorio/work/.build
===>  Building for opencolorio-1.1.1_1
[1/200] cd /tmp/work/usr/ports/graphics/opencolorio/work/.build/docs && /usr/local/bin/cmake -E make_directory /tmp/work/usr/ports/graphics/opencolorio/work/.build/docs/setuptools-prefix/src/setuptools && /usr/local/bin/cmake -E make_directory /tmp/work/usr/ports/graphics/opencolorio/work/.build/docs/setuptools-prefix/src/setuptools && /usr/local/bin/cmake -E make_directory /tmp/work/usr/ports/graphics/opencolorio/work/.build/docs/setuptools-prefix && /usr/local/bin/cmake -E make_directory /tmp/work/usr/ports/graphics/opencolorio/work/.build/docs/setuptools-prefix/tmp && /usr/local/bin/cmake -E make_directory /tmp/work/usr/ports/graphics/opencolorio/work/.build/docs/setuptools-prefix/src/setuptools-stamp && /usr/local/bin/cmake -E make_directory /tmp/work/usr/ports/graphics/opencolorio/work/.build/docs/setuptools-prefix/src && /usr/local/bin/cmake -E make_directory /tmp/work/usr/ports/graphics/opencolorio/work/.build/docs/setuptools-prefix/src/setuptools-stamp && /usr/local/bin/cmake -E touch /tmp/work/usr/ports/graphics/opencolorio/work/.build/docs/setuptools-prefix/src/setuptools-stamp/setuptools-mkdir
[2/200] cd /tmp/work/usr/ports/graphics/opencolorio/work/.build/docs/setuptools-prefix/src && /usr/local/bin/cmake -P /tmp/work/usr/ports/graphics/opencolorio/work/.build/docs/setuptools-prefix/src/setuptools-stamp/verify-setuptools.cmake && /usr/local/bin/cmake -P /tmp/work/usr/ports/graphics/opencolorio/work/.build/docs/setuptools-prefix/src/setuptools-stamp/extract-setuptools.cmake && /usr/local/bin/cmake -E touch /tmp/work/usr/ports/graphics/opencolorio/work/.build/docs/setuptools-prefix/src/setuptools-stamp/setuptools-download
CMake Warning at setuptools-stamp/verify-setuptools.cmake:15 (message):
  File will not be verified since no URL_HASH specified

-- extracting...
     src='/tmp/work/usr/ports/graphics/opencolorio/work/OpenColorIO-1.1.1/ext/setuptools-1.1.6.tar.gz'
     dst='/tmp/work/usr/ports/graphics/opencolorio/work/.build/docs/setuptools-prefix/src/setuptools'
-- extracting... [tar xfz]
-- extracting... [analysis]
-- extracting... [rename]
-- extracting... [clean up]
-- extracting... done
[3/200] cd /tmp/work/usr/ports/graphics/opencolorio/work/.build/docs && /usr/local/bin/cmake -E echo_append && /usr/local/bin/cmake -E touch /tmp/work/usr/ports/graphics/opencolorio/work/.build/docs/setuptools-prefix/src/setuptools-stamp/setuptools-update
[4/200] cd /tmp/work/usr/ports/graphics/opencolorio/work/.build/docs && /usr/local/bin/cmake -E echo_append && /usr/local/bin/cmake -E touch /tmp/work/usr/ports/graphics/opencolorio/work/.build/docs/setuptools-prefix/src/setuptools-stamp/setuptools-patch
[5/200] cd /tmp/work/usr/ports/graphics/opencolorio/work/.build/docs/setuptools-prefix/src/setuptools && /usr/local/bin/cmake -E make_directory /tmp/work/usr/ports/graphics/opencolorio/work/.build/ext/dist/lib/python3.7/site-packages && /usr/local/bin/cmake -E touch /tmp/work/usr/ports/graphics/opencolorio/work/.build/docs/setuptools-prefix/src/setuptools-stamp/setuptools-configure
[6/200] cd /tmp/work/usr/ports/graphics/opencolorio/work/.build/docs/setuptools-prefix/src/setuptools && PYTHONPATH=/tmp/work/usr/ports/graphics/opencolorio/work/.build/ext/dist/lib/python3.7/site-packages: /usr/local/bin/python3.7 setup.py build && /usr/local/bin/cmake -E touch /tmp/work/usr/ports/graphics/opencolorio/work/.build/docs/setuptools-prefix/src/setuptools-stamp/setuptools-build
FAILED: docs/setuptools-prefix/src/setuptools-stamp/setuptools-build
cd /tmp/work/usr/ports/graphics/opencolorio/work/.build/docs/setuptools-prefix/src/setuptools && PYTHONPATH=/tmp/work/usr/ports/graphics/opencolorio/work/.build/ext/dist/lib/python3.7/site-packages: /usr/local/bin/python3.7 setup.py build && /usr/local/bin/cmake -E touch /tmp/work/usr/ports/graphics/opencolorio/work/.build/docs/setuptools-prefix/src/setuptools-stamp/setuptools-build
Traceback (most recent call last):
  File "setup.py", line 17, in <module>
    exec(init_file.read(), command_ns)
  File "<string>", line 8, in <module>
  File "/tmp/work/usr/ports/graphics/opencolorio/work/.build/docs/setuptools-prefix/src/setuptools/setuptools/__init__.py", line 11, in <module>
    from setuptools.extension import Extension
  File "/tmp/work/usr/ports/graphics/opencolorio/work/.build/docs/setuptools-prefix/src/setuptools/setuptools/extension.py", line 5, in <module>
    from setuptools.dist import _get_unpatched
  File "/tmp/work/usr/ports/graphics/opencolorio/work/.build/docs/setuptools-prefix/src/setuptools/setuptools/dist.py", line 16, in <module>
    import pkg_resources
  File "/tmp/work/usr/ports/graphics/opencolorio/work/.build/docs/setuptools-prefix/src/setuptools/pkg_resources.py", line 1435, in <module>
    register_loader_type(importlib_bootstrap.SourceFileLoader, DefaultProvider)
AttributeError: module 'importlib._bootstrap' has no attribute 'SourceFileLoader'
[7/200] /usr/bin/c++  -DOpenColorIO_EXPORTS -DUSE_SSE -I/tmp/work/usr/ports/graphics/opencolorio/work/OpenColorIO-1.1.1/export -Iexport -I/tmp/work/usr/ports/graphics/opencolorio/work/OpenColorIO-1.1.1/ext/oiio/src/include -Iext/dist/include -O2 -pipe -march=core2 -fstack-protector-strong -isystem /usr/local/include -fno-strict-aliasing  -Wno-deprecated-register -isystem /usr/local/include -msse2 -O2 -pipe -march=core2 -fstack-protector-strong -isystem /usr/local/include -fno-strict-aliasing  -Wno-deprecated-register -isystem /usr/local/include -fPIC   -DOLDYAML  -fPIC -fvisibility=hidden -Werror -std=c++11 -MD -MT src/core/CMakeFiles/OpenColorIO.dir/AllocationOp.cpp.o -MF src/core/CMakeFiles/OpenColorIO.dir/AllocationOp.cpp.o.d -o src/core/CMakeFiles/OpenColorIO.dir/AllocationOp.cpp.o -c /tmp/work/usr/ports/graphics/opencolorio/work/OpenColorIO-1.1.1/src/core/AllocationOp.cpp
ninja: build stopped: subcommand failed.

Hi @VVD
OCIO 1.x does not support Python 3. But the coming OCIO v2 supports both Python versions.

That's a known limitation of OCIO v1 so I close the defect.
Please feel free to reopen it if needed.

But it build and work with python 3.7 without DOCS…
When v2 will be released?

OCIOv2 feature complete is planned for this summer.
Note: As any open source project we are open to contributions from the community. So, you can definitively submit a pull request to fix the Python 3 support in OCIOv1 if that's a blocker for you. Refer to CONTRIBUTING.md for details.

Thanks. I'm not python developer and I'll wait v2.

Is master support python 3 already?

All FreeBSD ports with mandatory dependency from python 2 will be removed on 2020-12-31 if not fixed:
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=249695

There are issue already: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=249534

authors: VVD hodoulp

repo: AcademySoftwareFoundation/OpenColorIO


text:
build: llvm 18 compat issue - include libclangAPINotes

Fixes #1809

@etsach are you able to try this change on your slide and let us know if it works?
It seems safe, and doesn't break anything. But then again, I could never get it to fail. Maybe because you were using llvm 18.0 and I was using 18.1 and maybe they fixed something on their end in between?

Hi,
This fixes the link error, but then I have another serie of link errors:
undefined reference to clang::SourceMgrAdapter::~SourceMgrAdapter()' undefined reference to clang::SourceMgrAdapter::handleDiag(llvm::SMDiagnostic const&, void*)'
etc...
And I can't find a library that fix them.
Definitely something else causing an issue.
Le dim. 5 mai 2024 à 05:48, Larry Gritz @.***> a écrit :

@etsach https://github.com/etsach are you able to try this change on
your slide and let us know if it works?
It seems safe, and doesn't break anything. But then again, I could never
get it to fail. Maybe because you were using llvm 18.0 and I was using 18.1
and maybe they fixed something on their end in between?
—
Reply to this email directly, view it on GitHub
https://github.com/AcademySoftwareFoundation/OpenShadingLanguage/pull/1812#issuecomment-2094570297,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACXIPYMDXBVO4JHQY2VSWZTZAWTZHAVCNFSM6AAAAABHHLUVYOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOJUGU3TAMRZG4
.
You are receiving this because you were mentioned.Message ID:
<AcademySoftwareFoundation/OpenShadingLanguage/pull/1812/c2094570297@
github.com>

I forgot, this is with LLVM 18.1.3
Le lun. 6 mai 2024 à 22:24, Etienne Sandré-Chardonnal <
@.***> a écrit :

Hi,
This fixes the link error, but then I have another serie of link errors:
undefined reference to clang::SourceMgrAdapter::~SourceMgrAdapter()' undefined reference to clang::SourceMgrAdapter::handleDiag(llvm::SMDiagnostic const&, void*)'
etc...
And I can't find a library that fix them.
Definitely something else causing an issue.
Le dim. 5 mai 2024 à 05:48, Larry Gritz @.***> a
écrit :

@etsach https://github.com/etsach are you able to try this change on
your slide and let us know if it works?
It seems safe, and doesn't break anything. But then again, I could never
get it to fail. Maybe because you were using llvm 18.0 and I was using 18.1
and maybe they fixed something on their end in between?
—
Reply to this email directly, view it on GitHub
https://github.com/AcademySoftwareFoundation/OpenShadingLanguage/pull/1812#issuecomment-2094570297,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACXIPYMDXBVO4JHQY2VSWZTZAWTZHAVCNFSM6AAAAABHHLUVYOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOJUGU3TAMRZG4
.
You are receiving this because you were mentioned.Message ID:
<AcademySoftwareFoundation/OpenShadingLanguage/pull/1812/c2094570297@
github.com>

@etasch, any comments? Should I merge what I have here and then we can try to find any remaining issues? Or are you worried that these changes are not correct?

This has languished for a while without a reply, but I think it's safe. Merging.

authors: etsach lgritz


text:
Clean up library VERSION and SOVERSION

Reduce confusion between "VERSION", "REVISION", and "SOVERSION":

Label the internal variable IMATH_LIBTOOL_* to indicate their purpose.
Use terminology closer to the libtool description
Add comment documenting the library update process

Signed-off-by: Cary Phillips cary@ilm.com

I'm bringing this up for the exact reason you cite, I strongly suspect we're not updating these numbers properly, because it's so confusing. I'm certainly open to other ideas or solutions.

I think you want the patch to be reflected in the age, not current, because it's ok to substitute a new patch release, right?

I believe that's true, I'm just wondering if that's a real use case? If someone is releasing a new ubuntu, it's unlikely they're going to cleverly avoid building openexr. If it's you or I building for our own not /usr/local directory, why are we doing that? If it's to rev an app like Blender, recompiling exr is 1% of 1% of the build time. So what I'm questioning is whether age is a pedantic correctness thing as opposed to a practical correctness. If it's merely pedantic, I'm all for all sails to the wind, let's do the thing that requires the least brain power, and only bump one number, because right now I'm feeling like maybe it's only an issue for PedanticKitty :) ... I am looking to be educated here, I feel like we've been coddling this problem along for almost plural decades now and still confused about it.

I don't disagree, as far as my personal workflow and priorities. I don't know if anybody else really cares.
I will note that if we wrap the whole thing up in current, we can never make a substitution that breaks (that's the single most important constraint), and although it doesn't allow for some possibly correct substitutions, it's no worse than the situation people would be in if they were linking statically.

Raising this again, as we need to resolve it before the 3.1 release.
In spite of how much I'd like to (a) not think about this again, and (b) not make mistakes, I'm not sure the automatic formula conforms to the libtool instructions:  https://www.gnu.org/software/libtool/manual/html_node/Updating-version-info.html, which also say:  "Never try to set the interface numbers so that they correspond to the release number of your package. This is an abuse that only fosters misunderstanding of the purpose of library versions."  Since the project has traditionally followed this library versioning policy, I'd prefer to stick with it, and just be deliberate.
The 3.0.5 release has library version 29.0.0. The 3.1 release make a few minor internal fixes (most have been patched into 3.0.5) and adds the OpenEXRCore library. So:

Start with version information of ‘0:0:0’ for each libtool library.
Update the version information only immediately before a public release of your software.
If the library source code has changed at all since the last update, then increment revision (‘c:r:a’ becomes ‘c:r+1:a’).
yes -> 29.1.0
If any interfaces have been added, removed, or changed since the last update, increment current, and set revision to 0.
yes -> 30.0.0
If any interfaces have been added since the last public release, then increment age.
yes -> 30.0.1
If any interfaces have been removed or changed since the last public release, then set age to 0.
no -> 30.0.1

Sound right?

Since we have an entirely different library name for every minor release (libOpenEXR-3.1.so vs libOpenEXR-3.2.so), do we start at 0:0:0 again for every one of those? Or does 3.2 pick up at where 3.1 left off?

I'm not sure your examples are correct. I don't think you can ever have a x.0.1 because age says how far BACK in revision is considered compatible, and there is no revision prior to 0.
This is so hard to get right.

We also install libOpenEXR.so in the chain of symlinks to libOpenEXR-3_0.29.0.0, and I think that's where the "drop-in" policy figures in, so I don't think the -3_1 suffix resets things.

And as pointed out in the new issue, drop-in of arbitrary OpenEXR libs into a cascade of symlinks such that one can simply link libOpenEXR.so doesn't work anyway because the version is burned into the ABI.

I'd like propose that we go with this PR as is for now. It doesn't change behavior or policy, it simply names variables in a slightly less confusing way. We approved similar changes for Imath, which went into 3.1.  I don't think we should hold up the 3.1 release of OpenEXR in hopes of resolving this any more effectively, although I'm open to ideas.
Can someone approve the review so I can merge it?

authors: cary-ilm lgritz meshula

repo: AcademySoftwareFoundation/openexr


text:
Media queries

I've been trying to port Xess to gcss as an exercise to see what I think about it and I've run into an issue, I can't properly express media queries like this:
@media only screen and (max-device-width: 736px) {
  main {
    padding: 0;
  }
}

What's the gcss way to do this?

Hi @Xe
Ive added a basic example of how you could do it. The end goal with any of it is you just need to wrap styles with something like the media string to the writer.  In short there isn't a way and im keen not to impose it as that will keep the repo free of problems.
But here is an example:
package main

import (
	"github.com/AccentDesign/gcss"
	"github.com/AccentDesign/gcss/props"
	"io"
	"os"
)

type (
	Styles []gcss.Style
	Media  struct {
		Query  string
		Styles Styles
	}
	Stylesheet struct {
		Styles Styles
		Medias []Media
	}
)

// WriteCSS writes the CSS for the media query to the writer
func (m Media) WriteCSS(w io.Writer) error {
	if _, err := io.WriteString(w, m.Query); err != nil {
		return err
	}
	if _, err := io.WriteString(w, "{"); err != nil {
		return err
	}
	for _, style := range m.Styles {
		if err := style.CSS(w); err != nil {
			return err
		}
	}
	if _, err := io.WriteString(w, "}"); err != nil {
		return err
	}
	return nil
}

// WriteCSS writes the CSS for the stylesheet to the writer
func (ss Stylesheet) WriteCSS(w io.Writer) error {
	// Write the base styles first
	for _, style := range ss.Styles {
		if err := style.CSS(w); err != nil {
			return err
		}
	}
	// Write the media queries next
	for _, media := range ss.Medias {
		if err := media.WriteCSS(w); err != nil {
			return err
		}
	}
	return nil
}

var (
	base = Styles{
		{
			Selector: "body",
			Props: gcss.Props{
				Margin: props.UnitRaw(0),
			},
		},
	}
	screen736 = Media{
		Query: "@media only screen and (max-device-width: 736px)",
		Styles: Styles{
			{
				Selector: "main",
				Props: gcss.Props{
					Padding: props.UnitRaw(0),
				},
			},
		},
	}
	stylesheet = Stylesheet{
		Styles: base,
		Medias: []Media{screen736},
	}
)

// This is just a basic idea of how you could structure your CSS
// the goal hear is just to wrap the css how you wish with what ever you wish
// construct your stylesheet to suit your needs.
// The end goal is just to call CSS on each style with the object to write to.
func main() {
	file, err := os.Create("media.css")
	if err != nil {
		panic(err)
	}
	defer file.Close()

	if err := stylesheet.WriteCSS(file); err != nil {
		panic(err)
	}
}

hope this helps in some way

PS. when you get commit ur happy with feel free to pr it to the examples would love to see it :)

Sorry to wade in here but I've been evaluating gcss - couldn't this also be solved (and also enable nested styles) by just including a []Styles child field in Style?

hi @jamiec7919,
yeh there are a multitude of ways really, what ever suits the needs best. I did have a play around with a sort of starting point after this issue at https://github.com/AccentDesign/gcss-starter as a "could it actually generate a more complete basic stylesheet to cover the basics" and "does it actually need anything adding that can serve this kind of use more specifically".
I did toy with the nested idea, but thought I would wait and chew it over. The only thought off the cuff would be validity of the selectors and whether it is actually a media query or standard selectors.
i'm not sure where the lib is going at present. Still trying to work that out. it feels like we should either do it properly (aka more complete). The bare basics. Or nothing :)
Stu

authors: Xe jamiec7919 stuartaccent

repo: AccentDesign/gcss


text:
Carousel syncing does not work when using 'responsive' setting

I have carousels that are synced using the following example
Using this example https://codepen.io/A360/pen/BaKwaGa
But I'm trying to get the thumbnail nav to become horizontal for smaller screens, I'm doing this via the 'responsive' setting, but it seems that once the breakpoint happens the syncing is broken (even if i drag the window back to a larger size).
e.g.
on  https://codepen.io/A360/pen/BaKwaGa
If you add the responsive setting to the '.thumbnail-slider' e.g.
 responsive: [       {         breakpoint: 1000,         settings: {           vertical: false,         }       }     ],
This will switch the slider to horizontal as expected but clicking on the  thumbnail slider buttons do not change the main slider, syncing between the two is broken.

note* that example will look weird as the CSS in that example doesn't accommodate for that behavior, but the clicking behavior should still work I believe

I just realize that example is doing carousel syncing manually not using the settings, so its probably an issue with that


text:
AT2-464 - Standalone service without vasco - [do not merge]

Following the pattern used in assess-api, this allows the static service to run securely as a standalone service.  The vasco repo is still referenced, but only as a library.
It can't be merge to master yet since all services must be upgraded simulataneously.  (They require AWS Load Balancer changes)

Following the pattern used in assess-api, this allows the static service to run securely as a standalone service. The vasco repo is still referenced, but only as a library.
It can't be merge to master yet since all services must be upgraded simulataneously. (They require AWS Load Balancer changes)

Is there a way to avoid this big bang approach so that each service can be done one at a time?

Following the pattern used in assess-api, this allows the static service to run securely as a standalone service. The vasco repo is still referenced, but only as a library.
It can't be merged to master yet since all services must be upgraded simultaneously. (They require AWS Load Balancer changes)

Is there a way to avoid this big bang approach so that each service can be done one at a time? If so, what is the cost?

Since this change decouples each service from vasco, the AT2 application itself fails until the AWS load balancer's listeners are reconfigured to not route to vasco, but rather route directly to the services.  This is all due to vasco doing both routing and service discovery.  I suppose it might possible, but I'd have to do some investigation.  The biggest risk is that QT development is interrupted since QT calls the AT2 learnosity-mirror service to retrieve Learnosity data.  I'll give it some thought.  Thanks!

authors: StevenPyle glewis-ANet

repo: AchievementNetwork/static


text:
-repack 之后微信提示清理缓存，repack没用

repack之后，微信打开小程序直接就告诉我清理缓存，应该是检测到修改了直接不让运行，有什么方法可以处理这个问题吗

repack之后，微信打开小程序直接就告诉我清理缓存，应该是检测到修改了直接不让运行，有什么方法可以处理这个问题吗

可以提供截图吗

repo: Ackites/KillWxapkg


text:
update Activiti/activiti-build to master

UpdateBot pushed version changes from the source code in repository: Activiti/activiti-build ref: master

UpdateBot commands:
updatebot push --ref master https://github.com/Activiti/activiti-build.git

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.jenkins-x-bot seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

authors: CLAassistant jx-activiti-cloud

repo: Activiti/activiti-api


text:
fix(versions): update Activiti/activiti-cloud-modeling versions

UpdateBot pushed maven dependency: org.activiti.cloud.modeling:activiti-cloud-modeling-dependencies to: 7.1.425

UpdateBot commands:
updatebot push-version --kind maven org.activiti.cloud.modeling:activiti-cloud-modeling-dependencies 7.1.425 org.activiti.cloud.audit:activiti-cloud-audit-dependencies 7.1.425 org.activiti.cloud.api:activiti-cloud-api-dependencies 7.1.425 org.activiti.cloud.build:activiti-cloud-parent 7.1.425 org.activiti.cloud.build:activiti-cloud-dependencies-parent 7.1.425 org.activiti.cloud.connector:activiti-cloud-connectors-dependencies 7.1.425 org.activiti.cloud.messages:activiti-cloud-messages-dependencies 7.1.425 org.activiti.cloud.modeling:activiti-cloud-modeling-dependencies 7.1.425 org.activiti.cloud.notifications.graphql:activiti-cloud-notifications-graphql-dependencies 7.1.425 org.activiti.cloud.query:activiti-cloud-query-dependencies 7.1.425 org.activiti.cloud.rb:activiti-cloud-runtime-bundle-dependencies 7.1.425 org.activiti.cloud.acc:activiti-cloud-acceptance-tests-dependencies 7.1.425 org.activiti.cloud.common:activiti-cloud-service-common-dependencies 7.1.425

repo: Activiti/activiti-cloud-modeling


text:
update org.activiti.cloud.build:activiti-cloud-parent to 7.0.30

UpdateBot pushed maven dependency: org.activiti.cloud.build:activiti-cloud-parent to: 7.0.30

UpdateBot commands:
updatebot push-version --kind maven org.activiti.cloud.build:activiti-cloud-parent 7.0.30 org.activiti.cloud.build:activiti-cloud-dependencies-parent 7.0.30

UpdateBot commands:
updatebot push-version --kind maven org.activiti.cloud.build:activiti-cloud-parent 7.0.31 org.activiti.cloud.build:activiti-cloud-dependencies-parent 7.0.31

repo: Activiti/activiti-cloud-service-common


text:
update org.activiti.cloud.dependencies:activiti-cloud-dependencies to 7.1.138

UpdateBot pushed maven dependency: org.activiti.cloud.dependencies:activiti-cloud-dependencies to: 7.1.138

UpdateBot commands:
updatebot push-version --kind maven org.activiti.cloud.dependencies:activiti-cloud-dependencies 7.1.138 --merge false

repo: Activiti/example-runtime-bundle


text:
update org.activiti.cloud.dependencies:activiti-cloud-dependencies to 7.1.169

UpdateBot pushed maven dependency: org.activiti.cloud.dependencies:activiti-cloud-dependencies to: 7.1.169

UpdateBot commands:
updatebot push-version --kind maven org.activiti.cloud.dependencies:activiti-cloud-dependencies 7.1.169 --merge false

repo: Activiti/ttc-connectors-dummytwitter


text:
validates_uniqueness_of_without_deleted undefined in Rails 4.2

More of an FYI I suppose since 4.2 is not official yet, but the above method is undefined both on master and on 0.5.0.beta1 when used as instructed in the README

Any update on this @zzak ?

@allaire there is a patch, maybe you can point your Gemfile to @mvz's fix-build branch?
https://github.com/mvz/acts_as_paranoid/tree/fix-build
If you try it please report any issues to #26, thank you!

+1

This should be fixed in the last release, please check it. <3

Please try 0.5.0, this should be fixed now

authors: allaire suan vaughanj10 zzak


text:
[Breath of the Wild] FPS++ - High Refresh Rate Causes Excessive Bokoblin/Moblin Ragdolling

Describe the issue
I'm playing the game at 144hz using the FPS++ mod. I have noticed that the ragdolling of enemies increases greatly. For example, when I get a headshot on a bokoblin, they go absolutely flying, several times further than expected. I would assume this issue has to do with the speed of the engine being accelerated due to the higher FPS.
To Reproduce
Steps to reproduce the behavior:

Enable a higher refresh rate in FPS++ (it is extremely noticeable past 100FPS)
Cause a bokoblin to go flying due to a critical hit of some sort (I recommend a headshot with an arrow)
The bokoblin will be yeeted across the environment instead of flying backwards a few feet.

Expected behavior
I would expect the knockback/ragdolling to behave similarly to how it does in 30fps.
Desktop (please complete the following information):

OS: Windows
GPU: Nvidia
Renderer: Vulkan
Version: 1.2.170

This is now fixed with the new major graphic pack update, thanks to the work of @Exzap!

authors: Crementif dimanaum


text:
“models/: Contains the neural networks used. Also contains the trained models for each task.”

I did not see the trained model in this folder, could you elaborate more on how to play with different examples shown in paper?

Hi @Capri2014, so sorry about that! We had .gitignore'ed the trained models by accident. It has now been added to the models/folder. The instructions have also been updated with examples on how to run the scripts.

repo: AdaCompNUS/magic


text:
Issues flagged by Cloud Manager - Clientlib versioning

Required Information

[ ] AEM Version, including Service Packs, Cumulative Fix Packs, etc: 6.5.5
[ ] ACS AEM Commons Version: 4.11.2
[ ] Reproducible on Latest? yes/no Yes

Expected Behavior
As per versioned clientlib doc https://adobe-consulting-services.github.io/acs-aem-commons/features/versioned-clientlibs/index.html, we created config at Level 4... /apps/myapp/config/rewriter/versioned-clientlibs. With that we are seeing  a major bug in Scan reports from Cloudmanager
ConfigAndInstallShouldOnlyContainOsgiNodes  -- Node /apps/myapp/config is an OSGi config or install path which contains non-OSGi-related children that will not be visible to non-administrative users.
Actual Behavior
There shouldnt be Cloud Manager issue with versioned clientlib config
Steps to Reproduce

Install ACS commons package
Configure versioned clienlibs at /apps/myapp/config/rewriter/versioned-clientlibs and run CM pipeline

Links
N.A.

@viveksachdeva  The newer AEM Archetype splits configs into another package (ui.confg) from the code (ui.apps) ... These might be part of the "cloud ready" recent changes ?
https://experienceleague.adobe.com/docs/experience-manager-core-components/using/developing/archetype/using.html?lang=en

@viveksachdeva mm - interesting. Just a quick question - any reason you arent using OOTB client lib versioning? Highly recommend you do so over ACS Commons, unless you have a good reason.
@justinedelson any insights on this? The rewriter config is a sling:Folder under the /apps/.../config node ... CM is unhappy that the node is not an OSGi config (ie. sling:OsgiConfig/.cfg.json).

Pretty sure this is a false positive in the CM build. Configuration pipelines must be configured in that path: https://sling.apache.org/documentation/bundles/output-rewriting-pipelines-org-apache-sling-rewriter.html#configuring-a-processor-1

@kwin  that was my expectation as well. JE might be busy - ill log an issue with CM team internally and ask them to review the rule.

@davidjgonzalez @kwin I'd never say never, but this was actually an issue 2 years ago that I don't think has regressed.
FWIW, the content structured used in testing this specific case is:
/apps
         /testco
                    /config
                               /com.day.cq.rewriter.linkchecker.impl.LinkCheckerImpl.xml (sling:OsgiConfig)
                               /rewriter (sling:Folder)
                                             /pdf (nt:unstructured)

i.e. /apps/testco/config/rewriter/.content.xml declares the node as sling:Folder and /apps/testco/config/rewriter/pdf/.content.xml declares that node as nt:unstructured.
I see that the ACS AEM Commons docs say to use a sling:Folder node for the configuration. This, however, does not have an impact (just validated this as well).
@viveksachdeva If you can provide the execution ID, I can probably look up some more detail. We could also move this to an AEM support issue if you would be more comfortable with that.
This test project does not generate any issues.

I have connected with out PS to relay this information as this could have some client info. thanks!

Hi,
We too are facing same issue. Could you please let me know how it was resolved?
Thanks,
Shilpa

authors: ShilpaAmbi by-4x1 davidjgonzalez justinedelson kwin viveksachdeva


text:
Update buildJDK id

Fix the run java version step
https://github.com/AdoptOpenJDK/build-jdk/runs/801659565?check_suite_focus=true
Signed-off-by: Sophia Guo sophiag@ca.ibm.com

Hotspot builds now ok, but java -version step still failing for OpenJ9 @sophia-guo

authors: smlambert sophia-guo

repo: AdoptOpenJDK/build-jdk


text:
how should i install this in my custom docker environment?

Hello,
trying installing jdk 8 on my docker machine. Running this:
git clone https://github.com/AdoptOpenJDK/openjdk-build
cd openjdk-build
./makejdk-any-platform.sh --docker jdk8u

i am getting the following error:
Starting ./makejdk-any-platform.sh to configure, build (Adopt)OpenJDK binary
Parsing opt: --docker
Possible opt arg: jdk8u
Working dir is ./build/
[debug] COPY_MACOSX_FREE_FONT_LIB_FOR_JDK_FLAG=true
[debug] COPY_MACOSX_FREE_FONT_LIB_FOR_JRE_FLAG=true
JDK Image folder name: j2sdk-image
JRE Image folder name: j2re-image
Searching for JDK_BOOT_DIR
readlink: missing operand
Try 'readlink --help' for more information.
dirname: missing operand
Try 'dirname --help' for more information.
dirname: missing operand
Try 'dirname --help' for more information.

any suggestion?
thanks

Searching the repo for readlink gives only this as result:
https://github.com/AdoptOpenJDK/openjdk-build/blob/95dc19f9b5a9ecc02addae45312d047ad154cfe8/sbin/common/common.sh#L129
Install a JDK on your system, so which javac suceeeds and building works again (Just tried that, had the same problem).

What O/S are you running? what happens when you run:
which javac and subsequently readlink -f $(which javac)?

Hi @fede-green . Have you tried Martijn's comment above?

This was resolved some time ago (we enhanced the detection)

authors: M-Davies MeFisto94 fede-green karianna

repo: AdoptOpenJDK/openjdk-build


text:
remove zulu-7 from the jdk8 build

zulu-7 no longer appears to be needed or used during the build.
(Perhaps it was used previously as part of a bootstrap?)
The PR also installs ca-certificates, which is still needed and was
being pulled in by software-properties-common.
I realize that this doesn't change much.  This saves one apt-get update during the build process and avoids unnecessary traffic to Azul's repo, so perhaps speeds up the build just a tad.  But I was curious about "why we can't have nice things..."

@tmancill - how does the docker build bootstrap itself without the Java 7?

@tmancill - how does the docker build bootstrap itself without the Java 7?

@karianna I was puzzling over this as well when I started looking into it.  Ostensibly the assumption is that we're already successfully bootstrapped and can retrieve jdk8 from api.adoptopenjdk.net in that Dockerfile here; these lines changed in https://github.com/AdoptOpenJDK/openjdk-build/pull/1278.
To test, I cleaned my environment with docker system prune -a to ensure that a container with a JDK wasn't being reused from cache, and then built with ./makejdk-any-platform.sh --docker jdk8u:
...
Step 4/24 : RUN mkdir -p /openjdk/target
 ---> Running in 4b5869d461f2
Removing intermediate container 4b5869d461f2
 ---> a06a1507ac08
Step 5/24 : RUN wget 'https://api.adoptopenjdk.net/v2/binary/releases/openjdk8?openjdk_impl=hotspot&os=linux&arch=x64&release=latest&type=jdk' -O jdk8.tar.gz
 ---> Running in 44d266989564
--2020-04-20 18:36:59--  https://api.adoptopenjdk.net/v2/binary/releases/openjdk8?openjdk_impl=hotspot&os=linux&arch=x64&release=latest&type=jdk
Resolving api.adoptopenjdk.net (api.adoptopenjdk.net)... 104.17.158.60, 104.17.159.60
Connecting to api.adoptopenjdk.net (api.adoptopenjdk.net)|104.17.158.60|:443... connected.
HTTP request sent, awaiting response... 302 Found
Location: https://github.com/AdoptOpenJDK/openjdk8-binaries/releases/download/jdk8u252-b09/OpenJDK8U-jdk_x64_linux_hotspot_8u252b09.tar.gz [following]
...

And then later on in openjdk_container:latest:
...
Searching for JDK_BOOT_DIR
Guessing JDK_BOOT_DIR: /usr/lib/jvm/jdk8
If this is incorrect explicitly configure JDK_BOOT_DIR
Boot dir set to /usr/lib/jvm/jdk8
Running gradle with /usr/lib/jvm/jdk8
...

So we're currently building jdk8 with itself.  Should we break the recursion?

While building with JDK8 works, we generally use the previous version, but if we've already got it pulling the adoptopenjdk8 then this seems like a reasonable change ... thoughts @karianna ?

I'm actually going to be a pian here and state that we should stay with the Zulu 7 as the bootstrap JDK.  We should ideally always build with version -1 (as recommended by the upstream guides).

Makes sense to me.  Closing this PR.  I'll have another look to see what it will take to build with 7 have Java 8 to run Gradle.

authors: karianna sxa tmancill


text:
System unavailable:  test-osuosl-aix71-ppc64-1 insufficient disk space

System tests are failing on test-osuosl-aix71-ppc64-1 because there is <3Gb available at the start of the tests (which is checked at the start of each test): https://ci.adoptopenjdk.net/job/Test_openjdk11_hs_sanity.system_ppc64_aix/48/consoleFull
17:13:31  ===============================================
17:13:31  Running test CLLoadTest_0 ...
17:13:31  ===============================================
17:13:31  CLLoadTest_0 Start Time: Tue Nov 10 17:13:31 2020 Epoch Time (ms): 1605028411166
17:13:31  Nothing to be done for setup.
17:13:31  variation: NoOptions
17:13:31  JVM_OPTIONS:
17:13:31  { itercnt=1; \
17:13:31  mkdir -p "/home/jenkins/workspace/Test_openjdk11_hs_sanity.system_ppc64_aix/openjdk-tests/TKG/../TKG/test_output_16050238357263/CLLoadTest_0"; \
17:13:31  cd "/home/jenkins/workspace/Test_openjdk11_hs_sanity.system_ppc64_aix/openjdk-tests/TKG/../TKG/test_output_16050238357263/CLLoadTest_0"; \
17:13:31  perl /home/jenkins/workspace/Test_openjdk11_hs_sanity.system_ppc64_aix/openjdk-tests/TKG/../../jvmtest/system/modularity/..//stf/stf.core/scripts/stf.pl -test-root="/home/jenkins/workspace/Test_openjdk11_hs_sanity.system_ppc64_aix/openjdk-tests/TKG/../../jvmtest/system/modularity/..//stf;/home/jenkins/workspace/Test_openjdk11_hs_sanity.system_ppc64_aix/openjdk-tests/TKG/../../jvmtest/system/modularity/..//openjdk-systemtest""" -systemtest-prereqs="/home/jenkins/workspace/Test_openjdk11_hs_sanity.system_ppc64_aix/openjdk-tests/TKG/../../jvmtest/system/modularity/..//systemtest_prereqs" -java-args=" " -results-root="/home/jenkins/workspace/Test_openjdk11_hs_sanity.system_ppc64_aix/openjdk-tests/TKG/../TKG/test_output_16050238357263/CLLoadTest_0" -test=CLLoadTest; \
17:13:31  if [ $? -eq 0 ] ; then echo ""; echo "CLLoadTest_0""_PASSED"; echo ""; cd /home/jenkins/workspace/Test_openjdk11_hs_sanity.system_ppc64_aix/openjdk-tests/TKG/..;  else echo ""; echo "CLLoadTest_0""_FAILED"; echo ""; fi; } 2>&1 | tee -a "/home/jenkins/workspace/Test_openjdk11_hs_sanity.system_ppc64_aix/openjdk-tests/TKG/../TKG/test_output_16050238357263/TestTargetResult";
17:13:31  STF 17:13:31.421 - =========================   S T F   =========================
17:13:31  systemtest-prereqs has been processed, and set to: /home/jenkins/workspace/Test_openjdk11_hs_sanity.system_ppc64_aix/jvmtest/system/systemtest_prereqsRetrieving amount of free space on drive containing /home/jenkins/workspace/Test_openjdk11_hs_sanity.system_ppc64_aix/openjdk-tests/TKG/../TKG/test_output_16050238357263/CLLoadTest_0
17:13:31  There is 3025 Mb free
17:13:31
17:13:31  Test machine has only 3025 Mb free on drive containing /home/jenkins/workspace/Test_openjdk11_hs_sanity.system_ppc64_aix/openjdk-tests/TKG/../TKG/test_output_16050238357263/CLLoadTest_0.
17:13:31
17:13:31  There must be at least 3Gb (3072Mb) free to be sure of capturing diagnostics
17:13:31  files in the event of a test failure.
17:13:31
17:13:31  Exiting.
17:13:31
17:13:31  CLLoadTest_0_FAILED

Seems to have about 15Gb free just now, so closing. Feel free to reopen if it recurs

authors: lumpfish sxa

repo: AdoptOpenJDK/openjdk-infrastructure