text:
Treat pointer types like desc

Is this pull request associated with an issue(s)?
Fixes #96
Description
This PR adds support for pointer types in signatures and type assertions by treating them like they are desc.
TODOs

[x] Add tests for cpp_is_type() for pointer types
[ ] Restrict cpp_is_type pointer type detection, right now it's a simple regex
[x] Update documentation

I think this is ready for review, I haven't restricted the is_type check but let me know if that would be desirable

To be clear, when you say restricting the is_type check, are you referring to making sure that the the say a bool* actually points to a bool rather than pointing to say a list?

Yeah that's what I mean

Yeah, I'm fine punting on that for now.

Sounds good. I did see a couple diagrams in the documentation, I didn't modify any of them but should we? I think the only relevant one is the type relations diagram

How would a pointer to a pointer be handled in this implementation (for example, list**)?

I did think of that and it should work, but I'll definitely add tests and documentation for it

Sounds good. I did see a couple diagrams in the documentation, I didn't modify any of them but should we? I think the only relevant one is the type relations diagram

It's be good to keep the documentation in synch or at least open an issue about it.

@zachcran is there a source file somewhere for the type_relations.png diagram?

Hmmm, tried opening it in drawio.com and it said it wasn't a diagram file... I checked the true file type and it is indeed a png file. Checked metadata with ImageMagick and I don't see anything that could be interpreted as the diagram source

It's possible I forgot to click the "embed diagram" (or whatever they call the option) upon saving. I guess that means the image will probably need to be remade. Don't worry about doing that unless you really want to (and if you do I recommend using Excalidraw, since we've been using that instead of draw.io for some time now).

Sounds good, for now, I just added a small blurb to the RST file where the diagram is shown explaining the relationships for pointers

authors: AutonomicPerfectionist ryanmrichard

repo: CMakePP/CMakePPLang


text:
[WIP] Refactoring + Adding comprehensive tests

This is not fully complete yet, but can start to get reviewed.
The goal of this PR was to refactor the vol.py tool such that previously single class is separated into two classes each corresponding to two different steps in the geometry creation process.
The two new classes are:

IsoVolDatabase: this is the first step that uses only VisIt to generate a database of isovolumes.
IsoSurfGeom: this is the second step that creates the DAGMC geometry from the database created in the first step.
There are two pieces of information that connect these two steps:
data: the name of the data on the original cartesian mesh file
dbname: the path to the folder containing the database of isovolume files generated in the visit step
levels: the values that were used for the isosurfaces
This information for each step can be assigned in many different ways in each class. These member variables can be assigned when the object is instantiated or when the over-arching method is called. In the case of the IsoSurfGeom class, a IsoVolDatabase object can also be passed in that contains all this information. In this refactor, I have implemented some new logic for handling these various methods for providing input.

Additional changes in this PR:

Introduce the package meshio which allows me to remove some complicated logic for checking if the min/max values for the levels are within the bounds of the provided data.
removal of unused methods and variables
adds a method for writing out a levelfile in the first step and reading it in the second step
Add tests for everything (NOTE: some tests are still needed, this is still incomplete)
code coverage analysis in CI
warnings and errors are real warnings and errors and not just print statements now

Things that still need updating in this PR (WIP):

[ ] complete tests
[ ] update the CLI/argparse options in generate_isogeom.py to be consistent with the refactor
[ ] update readme
[ ] make sure docstrings are all up to date (or existent)
[ ] confirm that all the necessary checks for information are present
[ ] confirm that methods are complete

If you are reviewing the files, there is a lot added because of the tests. The most important file is IsogeomGenerator/vol.py. The changes here are significant enough I would recommend viewing it as a split diff or just look at the file entirely separate on my branch. The other most important file is test/test_vol.py. Both of these files need the diff loaded to view.

@bam241 - can you take a look at the new structure of the files I made here? I separated my huge vol.py file that contained both classes for the two steps into two separate files (IsoVolDatabase.py and IsoSurfGeom.py). I made a new file called tools.py that is meant to be the driver file. There are three available "tools" in this file, the first is a tool to generate levels(0 (optional in the full workflow), generate_volumes() which is the overarching workflow for the information int he IsoVolDatabase class (the Visit step), and generate_geometry() which is the workflow for the second step (moab step). Can you briefly take a look at the function signatures in tools.py and the inits of the two new classes just to see if this is what you were suggesting?
Also, any suggestion of a file name that's better than tools.py or driver.py?
(note, the file generate_isogeom.py is the CLI and has yet to be updated, and the tests aren't updated with the new addition of the driver file).

In both of the classes, there is the common member variables for data, levels, db, and the method read_levels(). So I think I might make a parent class to hold these and then these two classes will inherit from that parent class.

@bam241 - can you take a look at the new structure of the files I made here (specifically in the IsogeomGenerator folder)? I separated my huge vol.py file that contained both classes for the two steps into two separate files (IsoVolDatabase.py and IsoSurfGeom.py). I made a new file called tools.py that is meant to be the driver file. There are three available "tools" in this file: the first is a tool to generate levels() (optional in the full workflow), generate_volumes() which is the overarching workflow for the information int he IsoVolDatabase class (the Visit step), and generate_geometry() which is the workflow for the second step (moab step). Can you briefly take a look at the function signatures in tools.py and the inits of the two new classes just to see if this is what you were suggesting?

yes it is !

Also, any suggestion of a file name that's better than tools.py or driver.py?

I think I prefer driver.py, as it does not a set of useful methods to be used elsewhere, but it is the main course :)

(note, the file generate_isogeom.py is the CLI and has yet to be updated, and the tests aren't updated with the new addition of the driver file).
👍

Thanks so much for taking a look @bam241!

Merging this to provide a clean slate for incremental improvements

source: gharchive/pull-request

authors: bam241 gonuke kkiesling

repo: CNERG/IsogeomGenerator

license: MIT

license_type: permissive

license_source: github-api


text:
How to output maximal unitigs?

Hi, Jamshed @jamshed
Thanks for cuttlefish giving me a new way to build cDBG in a very fast speed. I have one question after reading your paper. I noticed that you find the maximal unitigs by traversaling vertex mentioned in paper (called "two walks"). Every walk would stop until finding a "Fuzzy-Side" and concat two path if possible.  So I check the code in github repo and  try to find how to implement the corresponding logic. But there maybe some different with paper detailed in the repo.
I read output_maximal_unitigs_plain in src/CdBG_Plain_Writer.cpp:, I find there is not vertex traversaling, but visited every kmer in seq[left_end:right_end]. Firstly, find start_kmer and then try to find end_kmer. If paired end kmers were found, the unitig will be ouputed if not ouputed.
This is my understanding of how to output unitg. Please point it out for me if I'm wrong.

template <uint16_t k>
size_t CdBG<k>::output_maximal_unitigs_plain(const uint16_t thread_id, const char* const seq, const size_t seq_len, const size_t right_end, const size_t start_idx)
{
    size_t kmer_idx = start_idx;

    // assert(kmer_idx <= seq_len - k);

    Annotated_Kmer<k> curr_kmer(Kmer<k>(seq, kmer_idx), kmer_idx, *hash_table);

    // The subsequence contains only an isolated k-mer, i.e. there's no valid left or right
    // neighboring k-mer to this k-mer. So it's a maximal unitig by itself.
    if((kmer_idx == 0 || Kmer<k>::is_placeholder(seq[kmer_idx - 1])) &&
        (kmer_idx + k == seq_len || Kmer<k>::is_placeholder(seq[kmer_idx + k])))
        output_plain_unitig(thread_id, seq, curr_kmer, curr_kmer);
    else    // At least one valid neighbor exists, either to the left or to the right, or on both sides.
    {
        // No valid right neighbor exists for the k-mer.
        if(kmer_idx + k == seq_len || Kmer<k>::is_placeholder(seq[kmer_idx + k]))
        {
            // A valid left neighbor exists as it's not an isolated k-mer.
            Annotated_Kmer<k> prev_kmer(Kmer<k>(seq, kmer_idx - 1), kmer_idx, *hash_table);

            if(is_unipath_start(curr_kmer.state_class(), curr_kmer.dir(), prev_kmer.state_class(), prev_kmer.dir()))
                // A maximal unitig ends at the ending of a maximal valid subsequence.
                output_plain_unitig(thread_id, seq, curr_kmer, curr_kmer);

            // The contiguous sequence ends at this k-mer.
            return kmer_idx + k;
        }

        // A valid right neighbor exists for the k-mer.
        Annotated_Kmer<k> next_kmer = curr_kmer;
        next_kmer.roll_to_next_kmer(seq[kmer_idx + k], *hash_table);

        bool on_unipath = false;
        Annotated_Kmer<k> unipath_start_kmer;
        Annotated_Kmer<k> prev_kmer;

        // No valid left neighbor exists for the k-mer.
        if(kmer_idx == 0 || Kmer<k>::is_placeholder(seq[kmer_idx - 1]))
        {
            // A maximal unitig starts at the beginning of a maximal valid subsequence.
            on_unipath = true;
            unipath_start_kmer = curr_kmer;
        }
        // Both left and right valid neighbors exist for this k-mer.
        else
        {
            prev_kmer = Annotated_Kmer<k>(Kmer<k>(seq, kmer_idx - 1), kmer_idx, *hash_table);
            if(is_unipath_start(curr_kmer.state_class(), curr_kmer.dir(), prev_kmer.state_class(), prev_kmer.dir()))
            {
                on_unipath = true;
                unipath_start_kmer = curr_kmer;
            }
        }

        if(on_unipath && is_unipath_end(curr_kmer.state_class(), curr_kmer.dir(), next_kmer.state_class(), next_kmer.dir()))
        {
            output_plain_unitig(thread_id, seq, unipath_start_kmer, curr_kmer);
            on_unipath = false;
        }

        // Process the rest of the k-mers of this contiguous subsequence.
        for(kmer_idx++; on_unipath || kmer_idx <= right_end; ++kmer_idx)
        {
            prev_kmer = curr_kmer;
            curr_kmer = next_kmer;

            if(is_unipath_start(curr_kmer.state_class(), curr_kmer.dir(), prev_kmer.state_class(), prev_kmer.dir()))
            {
                on_unipath = true;
                unipath_start_kmer = curr_kmer;
            }

            // No valid right neighbor exists for the k-mer.
            if(kmer_idx + k == seq_len || Kmer<k>::is_placeholder(seq[kmer_idx + k]))
            {
                // A maximal unitig ends at the ending of a maximal valid subsequence.
                if(on_unipath)
                {
                    output_plain_unitig(thread_id, seq, unipath_start_kmer, curr_kmer);
                    on_unipath = false;
                }

                // The contiguous sequence ends at this k-mer.
                return kmer_idx + k;
            }
            else    // A valid right neighbor exists.
            {
                next_kmer.roll_to_next_kmer(seq[kmer_idx + k], *hash_table);

                if(on_unipath && is_unipath_end(curr_kmer.state_class(), curr_kmer.dir(), next_kmer.state_class(), next_kmer.dir()))
                {
                    output_plain_unitig(thread_id, seq, unipath_start_kmer, curr_kmer);
                    on_unipath = false;
                }
            }
        }
    }

    // Return the non-inclusive ending index of the processed contiguous subsequence.
    return kmer_idx + k;
}

dwpeng

Hi @dwpeng: good to know your interest in the algorithm!
Based on your description, you read the Cuttlefish 2 paper; but the implementation you're looking at is for the original Cuttlefish paper. You'll find the relevant implementation of the specific methods you're looking for at these files (and their .cpp counterparts): Read_CdBG.hpp, Read_CdBG_Constructor.hpp, and Read_CdBG_Extractor.hpp.
Regards.

I am so happy to receive your reply. Thank you. I will reread your code.
Regards.

source: gharchive/issue

authors: dwpeng jamshed

repo: COMBINE-lab/cuttlefish


text:
FIrst draft of login page

The php can work. Users can check whether the username and password is correct.

Need to change the code of creating a session.


text:
Chore/occupi tech

Description
This PR adds Framer Motion animations to the VisualFeatures component, enhancing the user experience with smooth transitions and engaging animations. The changes include:

Adding container animations for each major section
Implementing text animations for content to fade in and slide up
Adding image animations to fade in and scale up slightly
Using Framer Motion variants for easy animation management and reuse

These changes improve the visual appeal of the VisualFeatures component and create a more dynamic and engaging user interface.
Fixes #123 (assuming there was an issue to enhance the VisualFeatures component)
Type of change

[x] New feature (non-breaking change which adds functionality)

How Has This Been Tested?
The changes have been tested in the following ways:

[x] Manual testing in development environment
[x] Verified animations work correctly on different screen sizes
[x] Checked performance impact of animations

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules

Additional Notes

The animations are designed to be subtle and not overwhelming
Performance impact should be minimal, but should be monitored in production
Consider adding a toggle for users who prefer reduced motion

@waveyboym please check if the occupi.tech is suitable, also there are a few fixes needed to be added such as the FAQ page, the About Us page, the Privacy policy, Terms and services etc


text:
Missing gossip on screen

Good afternoon, firstly, thank you very much for such a wonderful modification, which I use with the acquisition of the game.
But there is a problem - gossip on the screen about AI does not appear at all, just notifications about my studied technologies of culture and science.
How can I solve this problem? Or tell me, which file or string I should cut to get rid of the gossip removal function.
I'm playing the Russian version of the game.
Thank you very much!

This may be an issue with the heuristic used for intercepting gossips. I did my best to render it language neutral, but there's only so much I can achieve as an English-only speaker.
Hey @e1ectron, does this issue affect you as well?

Sorry, I can't check it now and in the near future (don't have access to actual game version).

Hey, @chaorace. Test it on a 1.0.4 (1.0.0.129) Mac version on Russian and English.
For a hour, I haven't seen any gossips. So problem is not the language.
May be platform? @legdrop, you play on Win or Mac?

Windows 10, 64 bit.

I think @legdrop wants to read popup gossips that appears on vanilla on center of the screen. If so you need to remove line 35 in UI/Panels/StatusMessagePanel.lua that was added on this commit f04d0b5e0ff387a80420ccb0009865df134fc524

@bolbass
Yes, you understood everything correctly, thank you all very much!
I do not have the option now to run the game, but please check, I selected the correct code to delete?

Don't delete it :)
The commit I mentioned above was already fixed in CQUI so my last comment is wrong.
The last commit that affects gossips is c8963130252a8cb90546423564eb6c22911e64ea
The result of this commit is that you can choose gossips you want to see or disable on CQUI settings that are above the minimap. Have you tried changing it?

Thanks a lot, it works!

Okay... so did we ever figure out if this issue was caused by CQUI not correctly showing gossips?

Yes, there is at least one type of gossips that is missing on gossips settings screen (a gossip when other civs enter new era for example).

This type of gossips is under "City>>X has counquered Y" settings. We should fix it and can close this issue as soon as it's enough to unchek "Trim gossip messages" to see all the gossips.

authors: bolbass chaorace e1ectron legdrop

repo: CQUI-Org/cqui

license: mit

license_source: bigquery


text:
🛑 Superset is down

In 692919f, Superset (https://superset.p3.csgroup.space) was down:

HTTP code: 503
Response time: 655 ms

Resolved: Superset is back up in dac4654.

repo: CS-METIS/metis-dev-status-page


text:
Typo in "Terminate (WILL revoke)"

There is a typo on the termination confirmation dialog:
"This will terminate the Yubikey, wiping the PIN, PUK, Management Key and Certificates. This will also revoke the certificiate. Proceed?"
Note "certificiate" and not "certificate".

Thx :)

authors: bluikko mike-csis

repo: CSIS/EnrollmentStation


text:
feature-robo-control

Moved around some items in the main file and created the control_manager.hpp/cpp. We are now good to start working on different control methods, though we do also need to think about how to integrate the yaml into the control manager file.

Marking this as closed. The main robot control code was merged with feature-controllers. This is now obsolete.

repo: CU-Robotics/firmware


text:
🛑 JGA Counsel is down

In eed260a, JGA Counsel (https://www.jgacounsel.com) was down:

HTTP code: 0
Response time: 0 ms

Resolved: JGA Counsel is back up in 1944d94 after 9 minutes.

repo: CVRDigital/Upptime


text:
Fix mask at boundaries

Closes #163.

The failing tests are not introduced by this PR. I opened a separate issue #166.

repo: CWorthy-ocean/roms-tools


text:
help pages - increase window size slightly

(German menu is wrapped)

done with #1115

repo: CactuseSecurity/firewall-orchestrator


text:
Updated fbresnet to accept different sized images

The update allows fbresnet to process images larger or smaller than prescribed image size (224x224). Will be useful while finetuning or testing on different resolution images.

Thanks @ekagra-ranjan
Sorry for the late merged. I had to manually evaluate the model on imagenet.

authors: Cadene ekagra-ranjan


text:
Initial Implement of Super Mario Bros. 3

I have managed to create an implementation for Super Mario Bros. 3 (SMB3).
Quests include:

Score - Collect 100,000 points
Levels - Complete 3 levels
Worlds - Collect a hint token for each world completed
Streak - Get a bonus hint token if you complete 10 levels in a row without dying

There are still cooldown timers on Levels and Streak at the moment as a precaution since there was an issue of values staying in memory too long on death in certain cases resulting in multiple points for those quests. I developed a method of avoiding that issue in code, but have left the timers for the time being as it is beta testing. If we see no reports of messages regarding the cooldown, it should be safe to remove it eventually.
I also included a good many safeguards into the code to avoid means of cheesing the system (entering and exiting pipes on the map) and addressing specific scenarios (warp whistles do not count towards world completion for instance).

Don't forget to add a README entry.
Also a nitpick, and I don't know how @Dinopony feels about this, but I think we've tended to avoid abbreviations in game connector names so far. I personally think there should be no ambiguity when looking at a connector name. SuperMarioBros3Connector is crystal clear. SMB3Connector you have a good sense it's Super Mario Bros 3 but it could be something else when you open it.

Good point, especially in regard to Super Mega Baseball. I've expanded those out to the full names.
Also, didn't realize we needed to add our own entries to the README table, so good to know going forward.

Yup indeed, having full names is encouraged because it could get obscure really quickly if we all used abbreviations 😉
I'll try to find time to test it in the next few days, thanks for the contrib 👍

Tested the connector. Everything working as expected on my end. Good work.

authors: Dinopony RadzPrower nbrochu

repo: CalDrac/hintMachine


text:
Child Care resources

Background on the problem the feature will solve/improved user experience
Marginalized communities often bear the heaviest burden when trying to exercise their right to vote especially when it comes to childcare. Parents either have to rely on family members to take care of their children during this period or take the child with them. This can be tiring for a parent especially if there are limited toilets, lack of shade, or long wait times.
Describe the solution you'd like
The YMCA offers numerous childcare throughout their centers. As a national organization there is greater opportunity for parents to reach out for child care during voting periods. The YMCA is a proponent of civic engagement as well as community wellness so we can point users in need of childcare to their resources. They have a 'Find your Y' mapping tool that we can either pull into 5/5 or point users to the external link.
Tasks

Investigate how to incorporate the 'Find your Y' location tool as a resource for parents/guardians
Decide if this map can be pulled into the 5/5 solution or should be pointed to via a link on 5/5

Acceptance Criteria

A user can locate the 'childcare' resource in the resources tab
A user can view the 'Find your Y' tool and select the location they need to find childcare in
A user can connect with/ contact the selected Y and follow the process for getting childcare support

From our scrum 09.15 meeting, the task is to replace the
https://ymcaofcoastalga.org/news/2018/10/17/ymca-news/ymca-works-to-help-make-it-easier-for-parents-to-vote/
with
https://www.ymca.org/find-your-y?distance=175&lat=26.0517448&lng=-80.13727569999999&geolocation_geocoder_address=33004&type=branch

That string is in the ui/src/views/SupportPage/SupportPage.vue file.
Probably it's a straight search/replace.

authors: Sabine-Justilien davidnixon upkarlidder


text:
Merge master into Production

Summary
Merges master branch into production

We are not ready for 1.1 yet.
soon tho

authors: Miqhtiedev SkillBeatsAll

repo: CalmGuild/CalmBot


text:
Updates to the model serialization example

First of all, thanks for this awesome package - it's really helpful for newbies as me to quickly get started in the field of survival analysis. I've trained a CoxPHFitter model and would like to save it to the disk for future inference. I was able to find the following codes from this file but looks like there's a typo below: (see my comments next to those lines)
from dill import loads, dumps
from pickle import loads, dumps

s_cph = dumps(cph)
cph_new = loads(s_cph)
cph.summary # shouldn't it be cph_new.summary?

s_kmf = dumps(kmf)
kmf_new = loads(s_kmf)
kmf.survival_function_ # shouldn't it be kmf_new.summary?

The codes above only serialize binary objects in memory. It would be helpful if the following example codes could be added, too, to help others save their trained models to local path:
import pickle

with open('/path/my.pickle', 'bw') as f:
    pickle.dump(cph, f) # saving my trained cph model

with open('/path/my.pickle', 'rb') as f:
    cph_new = pickle.load(f)

cph_new.summary # should produce the same output as cph.summary

I can submit a merge request for this, if anybody finds it interested.

I love this suggestion (and agree that it's a typo) - feel free to send a PR and I'll merge it

I love this suggestion (and agree that it's a typo) - feel free to send a PR and I'll merge it

authors: CamDavidsonPilon mekomlusa

repo: CamDavidsonPilon/lifelines


text:
Add opt options rebase

This is an updated version of #78 rebased onto main after the GPU changes by @jwallwork23
@ElliottKasoar's comment on the original PR:
Resolves #73
Adds flags in all(?) functions that operate on tensors (tensor creation, model loading, forward) to optionally disable autograd, which should improve performance for inference.
Also adds a similar flag to set evaluation mode for the loaded model.

Evaluation mode

Contrary to my initial comments in #73, from testing evaluation mode does appear to be preserved, both between saving and loading TorchScript, and when applied to the loaded model.
In most cases evaluation mode is therefore likely to already be set, but I think it's useful to have the option to change it, particularly if FTorch may be extended to facilitate training (#22).

NoGradMode

Enabling or disabling gradients is more complicated, as it defined via a context manager, which only appears to define the behaviour within its own scope, and so it seems necessary to enable/disable gradients before every code block that operates on tensors (similar to the Python equivalent with torch.no_grad():).

InferenceMode

No changes are currently included, but it would be good to support InferenceMode too eventually, as it should provide further performance benefits over NoGradMode.
However, it has stricter requirements, and the mode was only added (as a beta) in PyTorch 1.9, so we would need to be careful if we want to support older versions.

Model freezing

No changes are currently included, and less directly applicable to the main FTorch library, although there are still interactions e.g. freezing the model can allow InferenceMode to be enabled when loading the model.
Freezing is currently the "default" when tracing in pt2ts.py, but not for scripting, despite potentially improving performance.
Freezing appears to (sometimes) introduce numerical errors when saving the reloading (differences ~10^-6), and can seem to lead to issues loading with Forpy too.

(For more general explanation of autograd/evaluation mode, see autograd mechanics).
Note: I've also removed the old, commented out torch_from_blob function.

Hi @ElliottKasoar after the work @jwallwork23 did there were some conflicts with your PR in #78.
I have done my best to rebase your work, but please could you take a look and see if everything seems in order to you?
@TomMelt You originally reviewed this PR and approved, but if you could take a quick glance and re-review it would be appreciated - since @jwallwork23 restructured the order of functions in the files and added additional arguments in the same place as @ElliottKasoar some of the merge conflicts got a little hairy so I may have missed the odd thing!

Before we merge we need to:

[ ] Add some docs for these new options
[ ] Add an example showing the use of these new options?
Or perhaps not given we are not training yet and just use the defaults...?

Added a note to the FAQ about eval and no_grad settings.
A detailed example will perhaps wait until these are used as part of #111 since for now they are the sensible defaults for running inference.
Squashing and merging shortly.

repo: Cambridge-ICCS/FTorch


text:
WIKI error Page 'Role Based Authorization'

In your wiki you purpose to do this:
rails generate migration add_role_to_users role:string
But the column type needs to be an integer for work not string then:
rails generate migration add_role_to_users role:integer

Howdy @malstrom thanks for bringing this up. It's a large wiki, could you copy in the link to the specific page you're referring to?

Why does it have to be an integer?

I wrote it in first my post, role must be integer

As per my comment above: why cannot it be a string? Thanks for clarifying.

I close for stale. Feel free to reopen.

authors: Malstrom Schwad coorasse

repo: CanCanCommunity/cancancan


text:
WIP: Integrate Workflow management app

Core features

[x] Add viewflow new dependency
[x] Configure viewflow
[x] Add django-debug-toolbar dependency for development
[x] Create a submission process
[x] Add tests for the submission process
[x] Add tests for the download task

Fixes

[x] Add support for help text in form fields
[x] Fix content layout (sticky footer & width)

Coverage remained the same at 100.0% when pulling ad995455c214ff36768ddf70d737bb4c0838626e on add-viewflow-and-upload into 0dbb55365ecaa00016b2c45e54e26a02c4dadc02 on master.

authors: coveralls jmaupetit

repo: Candihub/pixel


text:
404 response to /regulator/{id}/ when not all ids could be mapped.

I am curious about the logic for using 404 as the response if not all ids were able to be attached.
404 is defined as "The server has not found anything matching the Request-URI".
If I am reading the docs correctly in the case that not all ids could be mapped the request URI /regulator/{id}/ is valid and a matching resource was found, the issue exists within the array of ids to map.
Since the /regulator/{id}/ transaction doesn't seem to follow ACID I think the request should return a 200 response code since it is possible that some ids were mapped successfully.
Then it is on the caller to check if the failures array has data / exists at all.
Thoughts on this?

This is a really great point. I am happy to change to a 200 with a failure array.

Nice. I think a 200 would result in the least amount of confusion.
That way 404 can be reserved for when the requested resource is not found.

#13

Closing issue as this will be handled with issue #13

authors: alecKent danaspiegel elibosley


text:
foeture, gauchest

This pull request was generated by the 'mq' tool

/trunk merge

repo: Canva/mergequeue-trunk


text:
accomplis

This pull request was generated by the 'mq' tool

/trunk merge


text:
fibrillary, counterscalloped

This pull request was generated by the 'mq' tool

/trunk merge


text:
Add support for ubernetes-lite

Requires a 1.2 upgrade. See https://github.com/kubernetes/kubernetes/blob/release-1.2/docs/proposals/federation-lite.md

Should be available in aws after https://github.com/Capgemini/kubeform/pull/64 https://github.com/Capgemini/kubeform/pull/77

repo: Capgemini/kubeform


text:
🛑 Funky Ducks - Client is down

In 81a0416, Funky Ducks - Client (https://client.funkyducks.ml/) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Funky Ducks - Client is back up in f5cf585.

repo: CaptainQWasTaken/funkyducks-status


text:
全屏视频切换浮窗视频为什么要重新创建一个播放器

问题描述：
大神你好，我在看源码ListVideo2Activity的过程中，发现在处理视频进行浮窗切换的时候都是重新创建了一个GSYBaseVideoPlayer实例，复制播放器的参数重新播放，我理解使用同一个播放器，改变view的大小即可。反复切换悬浮窗感觉会消耗较大。请问这样设计有什么原因呢？

因为这样状态好管理，同时最主要是不同状态的窗口可能ui不一样。
这里切换的是ui显示层，对于播放内核并没有切换。

大神你好，在video_player_standard这个布局文件中，是同时放了small_close这样的view来操作小屏视频的，在GSYBaseVideoPlayer中也是负责小屏操作的，设计思路是StandardVideoPlayer既可以操作大屏，也可以操作小屏。我想如果使用一个播放器，通过small_id来区分视频状态，是否可以一个播放器来控制大小屏的ui变化

大神你好，在video_player_standard这个布局文件中，是同时放了small_close这样的view来操作小屏视频的，在GSYBaseVideoPlayer中也是负责小屏操作的，设计思路是StandardVideoPlayer既可以操作大屏，也可以操作小屏。我想如果使用一个播放器，通过small_id来区分视频状态，是否可以一个播放器来控制大小屏的ui变化

应该可以，我就是三种尺寸不同ui的屏幕用的同一个FloatVideo。

authors: CarGuo hseury oveeeee

repo: CarGuo/GSYVideoPlayer


text:
HealthKit background delivery entitlement is missing

iOS 15 requires a new HealthKit background delivery entitlement.
2021-12-28 23:48:26.816569-0500 CardinalKit Example[63076:2217316] [VError(::category:)] (
(
"Missing com.apple.developer.healthkit.background-delivery entitlement."
),
"setUpBackgroundDeliveryForDataTypes(types:frequency:_:)"
)

Addressed in dbefc38.

repo: CardinalKit/CardinalKit


text:
Release 0.1.1 on Hex

Hey @benwilson512, it seems like you bumped the version to 0.1.1 but that version isn't on Hex. Would you mind releasing it there as well, please? Thank you!

Done, thanks! :)

authors: PJUllrich mcrumm


text:
Update deps version {hackney, poison}

Hi. I'm using dialyzer it depends on ex_aws.
I found error when getting error building a plt of certifi,
And It caused by an old version of hackney depends on an  old version of certifi.
Summery

Updated hackney latest version.
Updated poison latest version.

Backgrounds

current version of hackney has dialyzer warnings. (https://github.com/benoitc/hackney/issues/409)
now latest version of hackney, solved dialyzer bugs.

Hey! I appreciate the PR, but I'm not really sure I see the need to force people to ugprade. I already support the latest versions of hackney and poison, all this PR does is remove support for earlier versions.

I really do appreciate your desire to help, but I think it will be easier for me to just update dialyze, and leave the other dependencies as is.

Thank you reviewing for this PR.
Now I know these backgrounds of Poison and apologize for my fault.
So, you may close this pull request 🙇

Thanks!!


text:
"redirected more than 3 times" during download link verification

This tool seems to have stopped working for me recently. Links can still be parsed, but when verifying download links, it says that it redirected more than 3 times. The links are not saved in links.txt. Additionally, the 'Last download' date on Zippyshare is not updated.
Here is my terminal output when running a single link:
Enter URLs (leave blank to stop): https://www25.zippyshare.com/v/dCDCcbJk/file.html
Enter URLs (leave blank to stop):
[*] pattern_1 has failed for link: https://www25.zippyshare.com/v/dCDCcbJk/file.html
[*] Trying next pattern
[*] pattern_2 has failed for link: https://www25.zippyshare.com/v/dCDCcbJk/file.html
[*] Trying next pattern
[*] pattern_3 has failed for link: https://www25.zippyshare.com/v/dCDCcbJk/file.html
[*] Trying next pattern
[*] pattern_4 has failed for link: https://www25.zippyshare.com/v/dCDCcbJk/file.html
[*] Trying next pattern
[*] 1/1 links parsed https://www25.zippyshare.com/d/dCDCcbJk/5/VPN-White-Paper.pdf
[*] Verifying download links...
[*] https://www25.zippyshare.com/d/dCDCcbJk/4/VPN-White-Paper.pdf redirected more than 3 times
[*] All download links saved at links.txt

Turns out I'm just dumb and running an older version of the tool. Git cloned the latest version and it works fine.

repo: Cartmanishere/zippyshare-scraper


text:
Some software extends dbf standard with extra encoding files, fixing #449

@Kartones, @rafatower CR this, please. I didn't know about those extra encoding files and it's pretty common (and useful for us). For example, QGIS save it. It's a workaround for DBase encoding support (I realised looking at the supported encodings table of dbf gem.

Frontend tests were OK :+1: (details)

Frontend tests were OK :+1: (details)

:+1: good research!

+1 nice!

Frontend tests were OK :+1: (details)

Frontend tests were OK :+1: (details)

Frontend tests were OK :+1: (details)

@Kartones could you CR this again? QGIS allows many exotic encodings not supported by PG, so I had to filter them and code has changed.

+1

authors: Cartofante Kartones juanignaciosl rafatower

repo: CartoDB/cartodb


text:
Use correct base address for 32-bit ASLR images

Fixes #266.
Adds a method image_base(&self) -> Va to the Pe trait:

For a PeFile, returns the preferred virtual address, i.e. self.optional_header().ImageBase.
For a PeView, it returns the true virtual address of the image. By default, this is the same as the above, except when constructing via PeView::module (uses base directly) or via from_bytes_and_base (where it is provided by the user).

The return value of this method is used for VA/RVA conversions in the Pe trait, replacing self.optional_header().ImageBase.

Unfortunately PeView was meant to be also usable if you just copied the memory of a running image (eg. from another process) where the base of the image ptr is not actually the real virtual address of the image. I've always had a nagging feeling that ignoring it and relying on ImageBase being 'corrected' was not reliable and now it's coming back to bite me :)
This will probably require an extra field in PeView containing the actual image base and trying not to break APIs.

I see. In this case, adding the extra field as you said and only setting it to self.image.as_ptr() as Va when the PeView is constructed using PeView::module should not break any existing APIs, correct?
Also, I guess a new (unsafe?) PeView constructor taking a AsRef<[u8]> and the base address would be useful in case one encounters issue #266 after copying the memory of a running image from another process.

PeView should work when copying the memory of a running image now. However, I'm not familiar with the Serde library, so I'm not sure how to serialize the PeView's image_base field without potentially breaking backwards compatibility for some formats (e.g. sequential ones). Is it fine to assume that some formats may not be compatible no matter what and just add a new serialize_field call at the end of serialize_pe that writes the image base?

Thanks for the update! I'm a bit distracted with other projects right now, I'll try to take a look at it tomorrow or during next week.

I've changed the API to set the base address after construction (I'm not a fan of a bunch of _with constructors, Rust could really use default parameter values...)

authors: CasualX tremwil

repo: CasualX/pelite


text:
F8 Community Governance Oversight Meeting 3 - Thursday 8th September 2022 - 1400 UTC

Agenda - F8 Community Governance Oversight Meeting 3
Scheduled date/time of meeting : 1400 UTC, Thursday 8th September 2022
Present:

[x] Allison Fromm
[ ] George Lovegrove
[x] Kenric Nelson
[ ] Matthias Sieber
[x] Phil Khoo
[ ] Stephen Whitenstall
[x] Tevo Saks
[x] Thorsten Pottebaum
[x] Vanessa Cardui
[x] Treasury
[x] Andre Diamond
[ ] Miroslav Rajh

Proposed Agenda
Matters arising/action points
Pay Allison $75 for TH Slides - ?
Pay Stephen $500 for PM - Aug 2022 yes
Pay Kenric remainder of the research budget - Aug 2022 yes
Last meeting we were looking to add something  to F9 IOG survey (Phil) - did we? - in theory yes but depends on form, scope, data protection
We missed adding something to Danny’s newsletters - tut
We agreed to discuss async the process to build public register of parameters - didn’t happen yet
CGO Treasury
Andre & Miroslav - after what has been paid, what is left?.
https://docs.google.com/spreadsheets/d/1v8EySgaWqoYlOVxHAjKKufj24x8CPn-no33EUPZP8sw/edit?usp=sharing
will rec 6860 $ on Mon
Can pay for all TH slides and project management
Partially pay Treasury management
Items left to pay for CGO8 - Reports, Retros, Surveys, Prep of F9 proposal - there’s not one… Should this be F10 proposal?? Town Hall Slides, Treasury Management. Project Management
All meeting attendance is already paid
should we develop a process for paying deliverables? Splitting equally is easier (Allison)
Tevo - we estimate delivery time of how much tasks cost. Everyone who contributes shares how much time they spent, if no information, the estimated cost will be shared equally between participants of specific task.
Vanessa - Should we split distributions between high level epics/projects/themes or we take reward each deliverable differently.
Phil - community distribution model - equal split and can choose to redistribute your share to others
Kenric - baseline = split evenly, then specific tasks - bonus pool? for those who put in extra effort. Decide thisusing Phil’s method.
Phil - easier to just pay everyone equal and then reallocate
Phil - this doesn’t change what’s already allocated
Andre - pay treasury in full this time, and then divide the rest between all of us Rename it “deliverables”
Leave it with Treasury until such time as deliverables are done? AGREED
Need to set aside money for closing report too
F7 proposal final payment - deliverables payments is what is outstanding
Pay Stephen for close out report and project management
$840 in wallet now
$6,366 to come on Monday
Town Hall Slides
Allison - Updates on Town Hall Slides
https://github.com/Catalyst-Auditing/Community-Governance-Oversight-Coordination/issues/87
Continuing
Will stay with every other week cadence
Will continue on recap of history, what’s happening in governance, and then parameter changes
CGO Project Board Review
Board:
https://github.com/orgs/Catalyst-Auditing/projects/3/views/1
F8 CGO Scope & Deliverables
5.1 Challenge Setting
What is the scope of F8 Challenge Setting oversight ?
Issue :
https://github.com/Catalyst-Auditing/Community-Governance-Oversight-Coordination/issues/88
We’ve agreed George and Phil are working on this, but what exactly are its deliverable(s) likely to be?
Do we need to consider how to maintain (and be seen to maintain) independence of oversight, given George is so strongly involved with working to change the Challenge-Setting process? George - conflict of interest is sthg he’s aware of. Meeting w Kriss on Fri - there will be changes soon. Whatever approach they want to take, will communicate it w CGO. Survey to gain community feedback on what IOG want to do? Tevo: this is best oversight we could have - let’s not add barriers. George : I do the work, oversight comes from everyone else.
What is the deliverable?? A survey? The proposals George has in? Analysis of discussion e.g in Telegram? To be discussed next meeting after George’s meeting with Kriss. Communicate that this discussion has been had, and the oversight will be to engage with or survey the community - sentiment analysis.
Thorsten - who is enacting changes to the challenge setting process? Also what is the intent, and how do we measure if it is achieved? A survey probably won’t cover that.
Kenric - not every community change HAS to be done by vote.Conversations, surveys etc are already happening - that’s also a decentralised process.
Allison - agree, it’s not always about a vote. How much surveying, conversation etc is enough to create legitimacy?? to protect the implementer from accusations of a decision that is not representative
Thorsten - agree, it’s not clearly defined how decision making is done if not via a vote. It becomes hard to determine if what is happening is within the parameter of controlling decision making process. Who decides if a vote is needed or not.
Phil - Dripdropz ATH last night - building a petition module to their voting structure, which fills some of the role we are talking about. An interesting possibility.
F10 looks likely to be another odd one: developer-heavy, and excluding much of the other work people do. Should we be additionally looking to maintain oversight of what sort of effect this is having on the community, the work that is done and the proposals that are getting funded?
5.2 Catalyst Circle Oversight
What is the scope of F8 Catalyst Circle Oversight ?
Issue :
https://github.com/Catalyst-Auditing/Community-Governance-Oversight-Coordination/issues/89
We agreed that those working on this are Tevo (general), Kenric (compensation), Vanessa (CC Oversight) - but what exactly will its deliverable(s) be?
We’ve discussed the ATHs at the end of June regarding planning for CCv4 - things have moved on a lot since then, but do we want to write up anything specific about those? Including Kenric’s points about remuneration?
CCv4 Election will be on DripDropz - what oversight can we / should we have? Do we want to have any oversight of the election design? e.g. what is the effect of doing it via DripDropz, of 1-wallet-1-vote, plutocratic voting power, etc)? And/or do we want to interrogate the resultsof the vote (in terms of what kinds of people voted, who felt “invited”, or anything else)?
Should we oversee the process that got us to this election format (e.g. was there enough community consultation?) It’s already being done by Oversight of Catalyst Circle - is it enough?
Is there scope for us to have oversight of whether the process is working and is fair, or is excluding anyone?  (e.g. is there enough time for people to write platform statements; is it OK that no support is being offered to help people stand, no education sessions, etc)
The above is a LOT of oversight. Remuneration for Circle is emerging as quite a big issue, so should we make that our focus? A survey on this could canvass community opinion on how the remuneration affects whether people stand for election, etc.
Kenric - concerns about the structure of the election. CCv3.2 decided to redesign Circle, not just prepare for the election.
Tevo: what are the roles and functions in catalyst - is Circle an official role? - There are functional groups, and they are not represented? (we don’t know that before voting)
Kenric - do we need to put together a report on what we think the problems are? The point of good processes = good outcomes. Kenric thinks we now have a poor outcome - gone from well defined roles (which were not perfect) to no design (? This is not necessarily accurate - the approach of “self-defined” IS a design)
Phil: as an oversight group we shouldn’t have a group opinion? Identify the parameters that have been changed or adjusted for this to happen? could look at this sort of via parameter changes process - it’s a sub-parameter that needs looked at separately
Vanessa - can we assess the outcome when it hasn’t happened yet in the sense that we haven’t had the election?
Phil - yes we could add it to TH slides
George: Observe what is changing and look at the process they took. Pros and cons?
Phil: is Circle becoming a decision making body? V- not yet
Phil- we could use TH slides and newsletter to help inform people about what has been decided
Our oversight ends at after Circle voting results are shared
What about making our focus the remuneration
Kenric - no
Time sensitive tho - decision on pay will not come immediately
Tevo - I think statements from oversight will not have impact
5.3 d-Reps
The White Paper is progressing well - Kenric to give a quick update?
dReps “Review Paper” is nearing completion.  Plan to submit to public by the end of Sept.  Three sections: literature review, voting power, community agreements
Tevo’s “participating dRep” perspective - what will be the deliverable?
5.4 Governance parameters
What is the scope of F8 Governance parameters ?
Issue : https://github.com/Catalyst-Auditing/Community-Governance-Oversight-Coordination/issues/90
We have agreed that Allison, Vanessa, Thorsten and Matthias are working on this- and Andre? (to maintain the register of changes)? And Phil?
We agreed that one deliverable  will be creating, publicising and maintaining a publicly- accessible register of parameter changes (including identifying who is actually making decisions, and info on the conditions on which community can take over each parameter)? So what do we need to do to launch that? And how will it be maintained? (Andre?)
We also suggested defining broad categories of parameters - should that come later, when we see what parameters there are?
Could the deliverables also include suggesting a process that IOG or anyone else should follow to launch a parameter change - particularly., an idea of how to determine what is sufficient community consultation?
We have discussed a decision-making tree  (is decision urgent, etc) using info from Jeremy’s Miro https://miro.com/app/board/uXjVOsELu0U=/ -  to categorize parameters - Tevo / Phil. Are we proceding with ths? and is it part of the above proposed process?
Tevo: Location of parameter changes - what it affects - who takes the decision and who is affected by it
Phil: do we focus on parameters that have “caused waves”, and ones that are announced during this proposal?
Allison: yes, narrow it down to the ones which are changing now. Possible test case - SSI proposal. Conflict of interest?
Phil: If you’re creating a proof of concept it’s not really a parameter change till it affects everyone. If it’s optional, an experiment, it’s not a parameter change
Tevo: We will send out the google form - but which parameters we report on, we will discuss.
V will share google form in Discord - will put it in next slides
Phil: community participation doesn’t yield that many results so let’s be realistic
Tevo -suggest an  emphasis on propsal assessor/VPA parameters. The way we have scaled is ineffective. To be discussed.
We also said that we would follow up on the F7 meeting with Harris - particularly, he was going to share info on IOG’s current process re parameter changes. How will we progress this?
Allocating pay for deliverables
In the light of the above discussion - how do we want to do this? Equal share for all involved, as with F7 project, or something else?
CGO Proposal Reporting
F7 CGO Proposal Reporting
https://github.com/Catalyst-Auditing/Community-Governance-Oversight-Coordination/issues/91
F8 CGO Proposal Reporting
https://github.com/Catalyst-Auditing/Community-Governance-Oversight-Coordination/issues/92
Summary of CGO meeting for Catalyst Weekly Newsletter
Executive, Legislative, and Judicial functions (Kenric)
This topic can be removed - there isn’t time in these meetings - Kenric
2 meetings ago, we said we’d find a time to discuss (async or informally) the below, that Kenric raised. Don’t think it happened, and don’t want to lose it - so can we quickly decide where and how this discussion could happen?
I’m (Kenric) not sure where to put this, but I suggest having a discussion about the Executive, Legislative, and Judicial functions of governance.  The voting processes of Catalyst map clearly to a Legislative function. What are the Executive and Judicial functions?  Perhaps the approved projects are an executive function. Perhaps the Circle’s identification and discussion of problems is a judicial function.  Clarity about this mapping might help define these different roles, and thereby the form and expectations of these roles.
AOB?


text:
Buddybuild crash report on build #520

Buddybuild detected a crash from bigbigchai@gmail.com
View Full Crash Details

Crash report from Unknown user

repo: CatchChat/Yep


text:
Port Adapters module to Java

https://github.com/CategoricalData/hydra/blob/main/hydra-haskell/src/main/haskell/Hydra/Adapters/Coders.hs

Now: https://github.com/CategoricalData/hydra/blob/main/hydra-haskell/src/main/haskell/Hydra/Adapters.hs

authors: aman-dureja joshsh

repo: CategoricalData/hydra


text:
🛑 Main Website is down

In c8b1477, Main Website (https://aqurusmc.xyz) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Main Website is back up in 2f4184d after 21 minutes.

repo: CcNicebruh/aqurusstatuspage


text:
🛑 欧陆风云四百科（eu4cn） is down

In 1141e02, 欧陆风云四百科（eu4cn） (https://www.eu4cn.com) was down:

HTTP code: 500
Response time: 2815 ms

Resolved: 欧陆风云四百科（eu4cn） is back up in 1788a80 after 9 minutes.

repo: Cccc-owo/upptime


text:
🛑 欧陆风云四百科（eu4cn） is down

In e10ac1e, 欧陆风云四百科（eu4cn） (https://www.eu4cn.com) was down:

HTTP code: 0
Response time: 0 ms

Resolved: 欧陆风云四百科（eu4cn） is back up in 8792bf2 after 1 hour, 17 minutes.


text:
fix: end tag for main element

Changes proposed in this pull request:

Fix missing end tag for the main element

Thanks a lot @magentix 👍

@all-contributors please add @magentix for bug and code.

authors: ArnaudLigny magentix

repo: Cecilapp/Cecil


text:
🛑 Nextcloud is down

In b72644d, Nextcloud (https://nextcloud.hiripple.com) was down:

HTTP code: 500
Response time: 114 ms

Resolved: Nextcloud is back up in 1863d06 after 10 minutes.

repo: CelestialRipple/ripplelog


text:
A User is technically optional on an audit event

Closes #223

Coverage remained the same at 84.235% when pulling ba7125d59df83853147cad4af2a5dec482ad7b92 on bug/224 into 14711e05549bf8908656f938f7578068766d0b2a on master.

authors: ChrisMacNaughton coveralls

repo: CentauriSolutions/EyeDP


text:
scale-up mizar support

What type of PR is this?

/kind feature

What this PR does / why we need it:

Start arktos-network-controller
create default network object (flat or mizar) of for system tenant
kubeup support mizar

Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:
Tested on scenarios blow:

Kubeup (scale up) with mizar: successfully except known pods issue (metrics-server, cordons... pods failure)

$ kubectl get pods -AT | grep mizar
system   default       mizar-daemon-pzmzn                                   2841290244949531555   1/1     Running             0          43m
system   default       mizar-daemon-s777f                                   7391625322091307921   1/1     Running             0          43m
system   default       mizar-daemon-xnxfb                                   5425713208105442661   1/1     Running             0          43m
system   default       mizar-operator-5c97f7478d-dcbv8                      3157000951661054885   1/1     Running             0          43m

Kubeup (scale up with default network): successfully
Kubeup (scale up with default network) + kubemark ( scale up with default network): successfully

Does this PR introduce a user-facing change?:

https://github.com/CentaurusInfra/arktos/wiki/Mizar-Arktos-Integration-Release-2022-0130-Test-Plan

https://github.com/CentaurusInfra/arktos/wiki/Mizar-Arktos-Integration-Release-2022-0130-Test-Plan -- The tests for pods were all passed on 2022-02-24.

/lgtm

/approve

repo: CentaurusInfra/arktos


text:
Rating Form UI changes [LEI-213]

Refs: https://openscience.atlassian.net/browse/LEI-213
Changes

Increase spacing of radio buttons in questions 2, 4, & 6
Fix scales in questions 2, 6 & 9

Done responding to your comments/questions @abought! Let me know if I should change the rating labels to map to option values instead of indices 🍂

Done responding to your comments/questions @abought! Let me know if I should change the rating labels to map to option values instead of indices 🍂

I'll leave this slightly to your discretion- but maintaining two distinct sets of numbers associated with each item is slightly confusing, and seems like it could make the code harder to maintain. Somewhere at the back of my mind, this seems to hint that the code is duplicating more than necessary.
Let me know what you decide.

@abought, done responding! I changed the option labels to map to the option values to make that clearer. ☔

authors: abought samanehsan

repo: CenterForOpenScience/exp-addons


text:
Fix card text overflowing card

Refs: https://trello.com/c/e5LbqRT8/4-text-on-cards-in-sub-categories-runs-off-card
Purpose
On small screen widths, card text runs off of cards.
Summary of changes

Make buckets wider
Make cards wider
Make card text break in between long words

Looks like purely cosmetic changes here; no review needed.
This will look weird on small screens, but ultimately there's not much we can do if the column is narrower than the text.


text:
[feature] Multiple emails

Status: ready for review

@lyndsysimon Let's focus this PR on the limited multiple emails requirement i.e. ability to add emails to a user account that are non-existent, or unregistered/unconfirmed -- and then knock this out -- OK

1st pass finished. :point_up:

Ready for second pass.

2nd pass finished. :v:

Bah. For some reason, Travis isn't building this every push.
I've got my repo to build as well, and this passes: https://travis-ci.org/lyndsysimon/osf.io/builds/56771321

Response to 2nd pass complete. Your move, @sloria...
:game_die:

Pass finished. :tanabata_tree:

Third pass review complete.
:pager:ing @sloria.

Is there any way to resend a confirmation email?

Minor "bug": When adding an unconfirmed that is already in the list of unconfirmed emails, the growl message says "Email added" when it should probably say "Email already added" or something similar.

Bug: Whenever I input an unconfirmed email with an uppercase character, I get an error message "Email validation failed", but the email still gets added.

Doesn't have to be added before this is merged, but we might want to add a little helper text (e.g. with a question-mark button) to explain what it means to make an email "primary".

Pass finished. :deciduous_tree:

Some input from Trello re: the "Email added" message: https://trello.com/c/X8aJ9lC7/73-more-information-when-email-is-added

Also: https://trello.com/c/Udvre4jB/75-adding-an-email-for-a-confirmed-account-with-no-email-set

ed20e52 address https://trello.com/c/X8aJ9lC7/73-more-information-when-email-is-added

@sloria rdy for review

:+1:

authors: chennan47 lbanner lyndsysimon sloria


text:
Account for folders without relying on querying BaseFileNode for path [#PLAT-1053]

Purpose
Yet another addendum to #8643
Changes

Use OsfStorageFileNode (cuz BaseFileNode overrides path)
If path turns out to be a folder and a version is still there, don't error just don't do anything with the folder

QA Notes

Documentation

Side Effects

Ticket
https://openscience.atlassian.net/browse/PLAT-1053

Failing build is due to missing merge migration, which has been fixed on feature/storage-i18n.

authors: erinspace sloria


text:
[ENG-691] Enables gitlab addon to access all gitlab projects with user membership

Purpose

Enable the GitLab addon to access all GitLab projects that the user is a member of. Previously, the addon was limited to GitLab projects that the user is the owner of.
Changes

Modifies the function that retrieves projects to use the general purpose project endpoint with a membership requirement as opposed to using the user/projects endpoint.
QA Notes

Testing the GitLab add on and ensuring that users are able to access GitLab projects they own as well as GitLab projects that they do not own but are members of would be beneficial.
I tested this locally using two separate GitLab accounts.
Documentation

N/A
Side Effects

N/A
Ticket

https://openscience.atlassian.net/browse/ENG-691

LGTM 🚢

authors: UdayVarkhedkar pattisdr


text:
[SVCS-332][SVCS-292] Make Googledrive give folder children’s metadata on moves and copies

Purpose
On inter/intra moves/copies googledrive doesn't return the folder's children, this fixes that.
Changes
Changes item serializer to recursively call the google drive api include children to metadata.
Side Effects
None that I know of.
Ticket
https://openscience.atlassian.net/browse/SVCS-332
Old PR
https://github.com/CenterForOpenScience/waterbutler/pull/221

Coverage remained the same at 76.68% when pulling ea5986c48aa6f86a6ffe7661db40964f05c8a2a3 on Johnetordoff:Google-drive-return-children into b787a92c180697cb8fb2f5b6c402cf7b931b339d on CenterForOpenScience:develop.

Coverage remained the same at 78.562% when pulling 5f5b5b0a90105c9c6918b1922ca6259943cb76a5 on Johnetordoff:Google-drive-return-children into 761c430396730b72e600f8def98c06e4a5d0316b on CenterForOpenScience:develop.

Coverage decreased (-0.03%) to 78.536% when pulling 547db2b48a29e6455b93ccc9f386a776127eb91b on Johnetordoff:Google-drive-return-children into 761c430396730b72e600f8def98c06e4a5d0316b on CenterForOpenScience:develop.

authors: Johnetordoff coveralls

repo: CenterForOpenScience/waterbutler


text:
Always On Mode

Rather than running from cron, we should have a way of running all the time. This would provide for alternate light configurations that don't rely on music to update lights. For example, it would be useful to only play songs at the top of the hour, but leave the lights on at the conclusion of the playlist (or configured subset of the playlist) and the only way to do that is to leave the process running and ensure the GPIO pins stay high

Somewhat wrong here: if you don't explicitly set the GPIO pins to low, they will stay in whatever state the song left them in. In other words, we don't need to run anything. A quick hack to get this up and running is to start a new show in cron, and ensure there are pre and post-cleanup scripts to set all the pins high so the lights stay on the rest of the time.


text:
Optimize local WAL size

Describe This Problem
In my local env, I find WAL(rocksdb based) is very large compared with SST, even after manually flush.
1.5G    data/wal
76M     data/manifest
371M    data/store
1.9G    data

Proposal
Do a compaction after delete_range to try remove dead entry from SST.
https://github.com/CeresDB/ceresdb/blob/9ab659a99417b41f3a4007e59bbe9b8f3ff65b8b/wal/src/rocks_impl/manager.rs#L120
Additional Context
https://github.com/facebook/rocksdb/wiki/RocksDB-Tuning-Guide#trigger-compaction-on-deletes

@ShiKaiWi I don't think this issue get fixed, wal encode is a general way to reduce wal size, but the issue here is to optimize for rocksdb-based, they have no direct relation.

repo: CeresDB/ceresdb


text:
[Feature Request] TilesetCombiner fails for older tilesets with content adressed by url property instead of uri

When using the combine method on tilesets produced by ContextCapture, then an error Content does not have a URI is raised. This is probably because the tile contents in the tileset root json file (plus subsequent tiles) are referred to via the url property rather than the uri property - which references either b3dm or json tile contents.
I know I can use the 3d-tiles-tools upgrade utility on local tilesets I do manage - although it will take a lot of time to upgrade loads of tilesets.
But for tilesets I do not manage, which are stored online on different servers and that I'd like to combine, then the easiest way would be for the combine utility to allow for tilesets which use either the url or the uri property to reference tile content.

We have been pondering this question internally.
The pragmatic view is: All inputs have to be valid. And for the case of the uri vs. url, the recommendation would be: Run upgrade on the input, and then use the upgraded tilesets for any further operations.
But... I can see that this is... invonvenient, particularly when the reason for something not working properly is literally that of a single letter (or "a pixel", as in "the difference between i and l...).
One reason of why we are (currently) not just ignoring this point is that the generalization of this question could be: Which forms of "invalid" inputs should be "ignored"? Or: Which parts of the upgrade should be done autmatically in other operations? At some point, we'd have to spread workarounds for legacy data, handling for special cases, and pseudo-upgrade functionality throughout the code. And it would really be better to summarize this in the upgrade command.
(One example: When you combine two tilesets that use url - should the combined tileset use uri or url then? It should probably use uri, but maybe you want to retain the original url...?)
That being said: The case of the content url was a special one for me as well: The original (pre-refactoring) state of the 3d-tiles-tools had been using the (somewhat unspecified) Tileset sample data extensively for tests. This one uses url. I created a utility function to handle this more transparently. But at some point, I just created a TilesetWithUris from that, to not have to cope with this issue for some tests 😕
So I agree that we should consider to make the tools more resilient for the particular, very special case of uri-vs-url...

Hi again, and again thanks for all this context, very useful.
Understood for the fact that the upgrade utility would be the corner piece before any other workflow operation, which would therefore only have to deal with valid tilesets, simplifying the code a lot. Then indeed, the question of whether to perform such pseudo-upgrade within workflow operations could be important - and even generalized as a cli option for every workflow.
Good question regarding whether the output combined tileset should have a url or uri property. If the tile versioning is a property of each tile json, then since viewers can handle tilesets of different versions, I would say they can be mixed, but I don't know the intricacies of such a decision.
And it's true this uri-vs-url seem like a special corner-case. Being able to combine tilesets without the requirement for upgrading them would make it easier to source external tilesets (if served from a CORS enabled server) without the need to download/serve them and mix multiple sources for content.

Edit final questions related to tiling:

are utilities defined in Cesium3DTilesWriter meant to build a tool to tile arbitrary input meshes to 3D-tiles? Probably something that is used internally by the Cesium Ion pipeline but not meant to be open-sourced as a complete tool yet? All commercial photogrammetry suites have been offering 3D-tiles exporting capabilities for the past few years (RealityCapture, ContextCapture, Agisoft Metashape, etc), but no open-source suite does so at the moment (Colmap/Meshroom etc), probably because of that fact that there is no oss tiler for meshes existing yet, only for pointclouds.
final question: when tiling a pointcloud into a Potree dataset, I can specify the bounding box of the input pointcloud data which will be used as the box of the root tile. Therefore if I reuse the same bbox for tiling multiple pointclouds (where coords are expressed in the same Coordinate Reference System), and PotreeConvert them sequentially with the overwrite option, then it is equivalent to appending pointclouds to the same tiled Potree container. Is there any standard representation as to how to do this for 3d-tiles? This way, we could probably combine tilesets to a master, earth-covering tileset, where tilesets would be appended at a given level in the hierarchy without affecting any other portions of the tileset, and this would be really useful - a way for us to combine a few hundreds indepdent tilesets to a single, earth-wide tileset ala google3dtiles.

Understood for the fact that the upgrade utility would be the corner piece before any other workflow operation,

Ideally, doing an upgrade should never be necessary. It should only be a last-resort option for the case that somebody has a legacy tileset, and wants to try and salvage it. One difficulty is that it is tremendously hard to say which "legacy" elements can be updated (and how), and what exactly the result will be. One example is that of tilesets that contain glTF 1.0 data. It is sometimes simply not possible to update this to glTF 2.0, and whether it is possible depends on many low-level technical factors, and it would be hard or impossible to establish a reliable contract for the behavior of the upgrade in this case.
The url-vs-uri, however, is relatively simple. It only twiddles in the JSON, and can be upgraded with a few lines of code. (So it doesn't really need the broader infrastructure that is offerd by the general upgrade command). We'll still have to see where/how to integrate that step in the most most sensible way. The two "extremes" would be:

Hand this in the most fine-grained manner, on the fly. Instead of writing const uri = content.uri, we'd have to say const uri = Contents.getUri(content), where the latter is the utility function that returns the url from legacy content if necessary
Handle it as a coarse-grained, blanket step. Whenever a tileset.json is read, there could be one pass to PseudoUpgrade.doThatUrlToUriUpgradeIfNecessary(tilesetJson), to have one place where this upgrade happens if necessary, and all the remaining code can use the content.uri directly, without having to worry about the case that it might be a url

Both have pros and cons. We'll have to sort that out..

Regarding the last questions...:

are utilities defined in Cesium3DTilesWriter meant to build a tool to tile arbitrary input meshes to 3D-tiles? Probably something that is used internally by the Cesium Ion pipeline but not meant to be open-sourced as a complete tool yet?

The Cesium3DTilesWriter in particular is just intended to have a mechanism for reading/writing the tileset JSON data. This code is auto-generated from the schema. Users could use this, for example, when they implement a tool that converts meshes to 3D Tiles. Considering the complexity of such a tool, the part that is responsible for writing the JSON would only be a minor, minor part, but ... at least, users wouldn't have to write that part from scratch.

final question: when tiling a pointcloud into a Potree dataset, ...

Sorry, I'm lacking a lot of context here. It sounds like this might be related to external tilesets in general, and maybe something that involves additive refinement. But I don't know Potree well enough to say more here. You might consider bringing this up in the forum at https://community.cesium.com/c/3d-tiles/16 , maybe someone with knowledge about Potree and a better understanding of your goals could chime in there.

Again thanks for all these details, very useful to understand the state of this toolset. And indeed probably not the right place to share these thoughts - the way I did it here is because from my point of view this could be what merge/combine are meant to do - combining tilesets, merging two or more hierarchical structures keeping only the lowest error/highest detail data.
You're right I'll iterate over these thoughts and ask along the way to the community forum instead if I need some feedback. Thanks again for all your help!

As I mentioned, there are some thoughts about possible extensions of the tools in the future. These thoughts differ in how likely it is for them to become actual points on a roadmap.
One example is that we have 'combine' (which creates one large tileset from one that had external tilesets), but we don't have an opposite of that - i.e. there is no "split" function. This could, in some way, be a low-hanging fruit: Just traverse the tileset, and whenever you reach depth x, start writing out a new one.
Now we could go and implement that. But...

nobody needed it until now (i.e. there was no feature request for that)
there is some overlap to concepts of implicit tilesets (the x would be the subtreeLevels, so to speak)
maybe most importantly: This could be generalized ... abritrarily

And before starting something like that, one should at least have a rough idea about how it could be generalized. For example: People might not want to split their tileset into "slices" with x levels each, but maybe based on some geometricError-threshold`, or maybe based on the file/data size of the results...
But if you have ideas (or even specific demand) for a certain functionality, just let us know... (or... open a PR, of course...)

authors: javagl jo-chemla


text:
UE5 + Vehicle = exaggerated motion blur

If you create a vehicle template in UE5 and drive the car and notice the wheel motion blur looks fine in the template map
If you then add the Cesium plugin (CesiumForUnreal-500-v1.12.1-ue5 - windows) and create a blank scene, add Cesium World Terrain + Cesium SunSky and then place the car on a city street in Denver area (default area) the motion blur on the tires go crazy. Everything still has default project settings from the vehicle template project.
If this is some setting I'm missing somewhere, please let me know.
I went back and the wheel motion blur is terrible regardless of Cesium being involved in UE4.27
I don't recall this in older versions of Cesium.
I tried various settings of anti-aliasing to no effect in the Cesium map.

same behavior with first person template. its fine until walking on cesium generated terrain. Maybe this is the physics bodies that are being created?

@nzanepro Is there a drop in frame rate when adding the Cesium tilesets? I am not sure how motion blur is computed, but I wonder if it varies based on the delta time between frames.

The CitySample has a better example of car tire motion blur trickery, which works well with Cesium tileset.
The first person template still exhibits this difference between walking on a Geometric "Plane" or "Cube" object and the ground provided by the Cesium World Terrain.

Is the Cesium Physics geometry able to be presented as a StaticMesh to the Physics system?

Cesium tiles are simply static meshes, though they're created and destroyed in a view-dependent manner. I think Nithin's question about frame rate might be highly relevant. Were you able to confirm a frame rate drop?

ok, I figured out something that is reproduceable for you.

install cesium samples project into ue5.01
navigate to 03_CesiumDenver Level
delete Aerometrex Denver photogrammetry from outliner
play
you will start on the "StartPlatform"
use the "a" button to run to the left
notice the motion blur while on the "StartPlatform" vs the motion blur when you drop to the cesium tiles and continue running to the left.
my fps doesn't seem to drop in the same scene, same settings, but different geometry?
video capture attached including fps displayed.

machine stats:
Intel(R) Core(TM) i9-9900KF CPU @ 3.60GHz 32GB memory
NVIDIA GeForce RTX 2080ti 11GB gpu memory
https://user-images.githubusercontent.com/5840082/167763438-ab1f6a9c-845f-42e1-b439-b01773c64b99.mp4

same steps repeated in ue4.27 for reference. motion blur seems to be fine.
https://user-images.githubusercontent.com/5840082/167765248-58f3e64b-5a8c-476f-8c41-490d01ecb6bc.mp4

authors: kring nithinp7 nzanepro

repo: CesiumGS/cesium-unreal


text:
Add check to disable LOD transitions in material layer

Follow up to #1414. Fixes #1104.
This PR does the following:

Renames UseLodTransitions to EnableLodTransitions, to keep consistent with the rest of the naming in Cesium3DTileset.
Adds a EnableLodTransitions parameter to the ML_DitherFade material layer, to control whether or not the dithering is applied.
Clarifies that EnableLodTransitions is only compatible with temporal AA modes in the comments.

This material parameter corresponds exactly with the Cesium3DTileset's parameter. When false, dithering won't be applied at all. This helps for projects that use non-temporal AA modes. As long as they don't enable LOD transitions (which would be user error), they don't need to worry about these dithering artifacts on their tilesets.
Before

After

Hm, the artifacts don't appear when Forward Rendering is disabled, even for non-temporal AA modes. So I'll adjust the documentation

@j9liu I see pretty significant artifacts in this branch when "Enable LOD Transitions" is enabled. It kind of looks like the old tile is being removed completely before the new one comes in, so I see big holes in the surface. This is with Google Photorealistic 3D Tiles:

I see the same thing with CWT+Bing, though.