text:
Default value within the HiveField annotation

Hi!
Have an idea how the default values can be set in easy way for TypeAdapter.
All we need - add new field to HiveField annotation and then use it during class generation.
class HiveField {
  final int index;
  final dynamic defaultValue;
  const HiveField(this.index, {this.defaultValue});
}

Then in our class we can do like this:
@HiveType()
class CityHive {
  @HiveField(0, defaultValue: -1)
  int id;
  @HiveField(1, defaultValue: "Some name")
  String name;
  @HiveField(2)
  double lat;
  @HiveField(3)
  double lng;
}

Generated class will looks like this:
class CityHiveAdapter extends TypeAdapter<CityHive> {
  @override
  CityHive read(BinaryReader reader) {
    var numOfFields = reader.readByte();
    var fields = <int, dynamic>{
      for (var i = 0; i < numOfFields; i++) reader.readByte(): reader.read(),
    };
    return CityHive()
      ..id = fields[0] as int ?? -1
      ..name = fields[1] as String ?? "Some name"
      ..lat = fields[2] as double
      ..lng = fields[3] as double
  }
  ...
}

Hmm, what about if a field is purposely set to null?
var cities = Hive.openBox('cities');
var newYork = cities.get('ny');
newYork.name = null;
cities.put('ny', newYork);
cities.close();
cities = Hive.openBox('cities');
print(cities.get('ny')); // City has a name again

Also, when would CityHives be implicitly created? If a city doesn't exist, box.get(...) returns null anyways, so if you have code like the following, you still explicitly create a city on the caller side:
var newYork = cities.get('ny') ?? CityHive(id: ..., name: ..., ...);

Come to think of it, I could see this feature being used if you switch app versions and a new field got added.

I like this idea. It will be mandatory when non-nullable types are released and you want to add a non-nullable field to an existing object.

I like this idea. It will be mandatory when non-nullable types are released and you want to add a non-nullable field to an existing object.

Exactly. I got this idea when I was thinking about migration (adding new fields)
For example bool isFavourite, which should be false, but not null.

Hmm, what about if a field is purposely set to null?
@marcelgarus nice catch, I didn't think about it.
But i guess that field, which you mark with this annotation should not be nullable. Then it will make sense.

Hmm, what about if a field is purposely set to null?

Hive can tell the difference between a non existing field and a field set to null...

Hive can tell the difference between a non existing field and a field set to null...
how? didn't find it on documentation 😞

Oh well, you're right of course. The TypeAdapter code could, of course, be like the following or something similar:
return CityHive()
      ..id = fields.containsKey(0) ? fields[0] as int : -1
      ..name = fields.containsKey(1) ? fields[1] as String : "Some name"
      ..lat = fields[2] as double
      ..lng = fields[3] as double;

Bump!
I could really use this, specifically for the case where the backend schema changes and I am adding new fields to my model.
Also. If someone has a good work-around in the meantime... I struggle to find a way to handle this that I like.
I also have an alternate path to a solution I would like to open for discussion. Dart already offers default values for object properties. You could write the example at the start of this thread as:
@HiveType()
class CityHive {
  @HiveField(0)
  int id;
  @HiveField(1)
  String name = "Some name";
  @HiveField(2)
  double lat;
  @HiveField(3)
  double lng;
}

There is also defaults in the constructor you could use. The thing Hive would have to change to support this path is just to not step all over them when assigning values to the object constructor. Probably specifically when a key doesn't exist as in an earlier post in this thread. That seems like a very gentle and backwards compatible way to address this. Any property that I do not give a dart-native default value to will still return null when read.

Also. If someone has a good work-around in the meantime... I struggle to find a way to handle this that I like.

You can write custom type adapters or generate one then modify generated code.

Good call on custom type adapters.. or effectively not using generators for this.
I also just realized I can use the actual constructor in my models... not just the "shortcut assignment":
@HiveType()
class CityHive {
  @HiveField(0)
  int id;
  @HiveField(1)
  String name;
  @HiveField(2)
  double lat;
  @HiveField(3)
  double lng;

  CityHive({
    this.id,
    name,
    ... more ...
  }) {
    this.name = name ?? "Some name";
  }
}

Got into this one this week, sharing my solution in case it helps anybody:
@HiveType()
class Question {
  @HiveField(1)
  String id
  @HiveField(2)
  bool allowSomething;

  Question({
      @required this.id,
      this.allowSomething,
    }) {
      allowSomething  = allowSomething ?? false;
    }
}

Nice thing about this approach is that it uses short-hand constructor parameters & generated adapters

Got into this one this week, sharing my solution in case it helps anybody:
@HiveType()
class Question {
  @HiveField(1)
  String id
  @HiveField(2)
  bool allowSomething;

  Question({
      @required this.id,
      this.allowSomething,
    }) {
      allowSomething  = allowSomething ?? false;
    }
}

Nice thing about this approach is that it uses short-hand constructor parameters & generated adapters

Got into this one this week, sharing my solution in case it helps anybody:

Thanks - I was really expecting just having fields with default values declared the normal way to work, but the principle of least astonishment was not followed here. This definitely helps, even though I don't particularly enjoy the additional boilerplate for every field I add.
I specifically wanted to add a new field and give it a default value, and this solves the problem.

I want this too.
Because now I'm always changing generated type adapter for new field. But I don't want to do it. Executing build_runner only is best.

Hey, @dala00 , @lietu and others. Default value support for @HiveField annotations added in latest version of hive_generator.
hive: ^2.0.4
hive_generator: ^1.1.0

(you have to upgrade both packages).
Check this file for the example: example/types.dart

Ohhhhhh, God!!!!! Thanks!

Makes more sense for the generated code to always be if fields[index] != null set the value
else leave the default as set by the normal way of defining default values.
This way you dont need the defaultValue annotation
Ex.
@HiveField(1)
bool isBool = true;
generated code
if (fields[1] != null)  isBool = fields[1] as bool;

authors: TheMisir dala00 eimermusic juandiago kamimark leisim lietu marcelgarus pro100svitlo

repo: isar/hive


text:
我使用打包安装方式跟直接启动方式，前端都报错Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'join')

我使用打包安装方式跟直接启动方式，前端都报错Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'join')
而且打包也会报错：The CJS build of Vite's Node API is deprecated. See https://vitejs.dev/guide/troubleshooting.html#vite-cjs-node-api-deprecated for more details.
vite v5.0.12 building for production...
✓ 1236 modules transformed.
Could not resolve "../userinfo/images/#U5b66#U751f#U5361#U901a_1.png?url" from "src/views/chatgpt/index.vue?vue&type=script&setup=true&lang.ts"
file: /home/www/node_project/upimg/client/src/views/chatgpt/index.vue?vue&type=script&setup=true&lang.ts
error during build:
RollupError: Could not resolve "../userinfo/images/#U5b66#U751f#U5361#U901a_1.png?url" from "src/views/chatgpt/index.vue?vue&type=script&setup=true&lang.ts"
at error (file:///home/www/node_project/upimg/client/node_modules/rollup/dist/es/shared/parseAst.js:337:30)
at ModuleLoader.handleInvalidResolvedId (file:///home/www/node_project/upimg/client/node_modules/rollup/dist/es/shared/node-entry.js:18022:24)
at file:///home/www/node_project/upimg/client/node_modules/rollup/dist/es/shared/node-entry.js:17982:26

这是不打包直接运行访问提示
main.ts:29 [Vue Router warn]: No match found for location with path "/"
App.vue:32 command + shift + p
config.ts:45 Uncaught (in promise)
TypeError: Cannot read properties of undefined (reading 'join')
at config.ts:45:29

source: gharchive/issue

repo: ischenliang/quickly-picture-bed

license: MIT

license_type: permissive

license_source: github-api


text:
Sort bugs via status

It would be great if we can sort the reports to display fixed bugs first and then confirmed etc. Also if you can upload the excel processing script I can help refactor that to implement this feature. (Or you can just simply extract reports whose title contains ✅ and put them first).
cc: @Co1lin

Fixed by #43dc756 .

repo: ise-uiuc/neuri-artifact


text:
Improvement

Hey,
thanks for you very nice repo!
I just found out, that the ids in you data are ongoning numbers and not the Kreisgemeinde IDs. So I found the Dataset:
https://gdz.bkg.bund.de/index.php/default/digitale-geodaten/verwaltungsgebiete.html
what I think: this data could be extended to contain the Kreisgemeinde ID, so if you have Data from a Kreisgemeine you are able to plot them with plotly.
Hope that helps you!?
Regards

Hi @exandi, thanks for opening the issue. This project will be archived, because I won’t be able to maintain it anymore. Feel free to fork it and make it your own. Thanks a lot.

authors: exandi isellsoap

repo: isellsoap/deutschlandGeoJSON

license: Unlicense


text:
Features

Hello !
In this capstone project, I developed a budget app named Smart Pocket Budget keeps track of all your expenses associated with categories.
Here are the following features done in this project.
Splash screen
To enhance the user onboarding process, I have incorporated a visually appealing splash screen that prominently displays the app's name. For added convenience, the splash screen provides direct links to the sign-up and log-in pages, streamlining the user's journey into the app.
Signup and Login pages
The app now offers a user registration feature, requiring users to provide their full name, email address, and password. Existing users can seamlessly access their accounts by logging in with their registered email and password. To ensure a secure authentication process, appropriate validations and security measures have been implemented. Unauthorized access to pages requiring authentication has been effectively restricted.
Homepage and Categories page
Upon successful login, users are directed to a dynamic home page showcasing various categories. Each category is presented with a clear and concise name, an accompanying icon, and the total amount of transactions associated with it. For enhanced user experience, clicking or tapping on a category item seamlessly navigates the user to the corresponding transactions page. Additionally, a prominent "Add a new category" button has been incorporated at the bottom of the page to facilitate category creation.
Transactions page
Users can now effortlessly view a comprehensive list of transactions for the selected category. The transactions are displayed in a clear and organized manner, sorted in descending order based on their recency, ensuring that users can easily track their latest expenses. The total amount for each category is prominently displayed at the top of the page, providing users with a quick overview of their financial standing. To further streamline transaction creation, a conveniently placed "Add a new transaction" button has been added at the bottom of the page. For added convenience, users can easily navigate back to the home page by simply clicking on the intuitive "Back" button (<).
Add a New Category page
A user-friendly form has been implemented to facilitate the creation of new categories. To successfully create a new category, users are required to provide a descriptive category name and an accompanying icon. Upon saving the newly created category, users are seamlessly redirected to the home page. Alternatively, users can conveniently navigate back to the home page by clicking on the intuitive "Back" button (<).
Add a New Transaction page
Users can effortlessly create new transactions by completing a straightforward form that includes the transaction name (mandatory), amount (mandatory), and at least one associated category (mandatory). Upon successfully saving the transaction, users are seamlessly directed to the corresponding transactions page for that specific category. To facilitate easy navigation, a convenient "Back" button (<) is provided, allowing users to swiftly return to the transactions page for the selected category.

Thanks a lot !

source: gharchive/pull-request

repo: ishimwepati/Smart-Pocket-Budget-App


text:
how to remove FLICKER effect in the depth

is there a way to reduce the flickering effect in the depth map

The same problem with flickering when processing image sequence.
It caused by producing inconsistent (in some cases) depth map.
Such" collateral effect " makes calculated depth maps unusable in case of processing image sequence from video.
What could be done to reduce (ideally completely illuminate) such effect? May be "TecoGan"?

I agree with you. will have to see if they can fix it
On Mon, 14 Jun 2021 at 20:15, semel1 @.***> wrote:

The same problem with flickering when processing image sequence.
It caused by producing inconsistent (in some cases) depth map.
Such" collateral effect " makes calculated depth maps unusable in case of
processing image sequence from video.
What could be done to reduce (ideally completely illuminate) such effect?
May be "TecoGan"?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/intel-isl/MiDaS/issues/87#issuecomment-860928695, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AFIOA3KWSJYUBSASOUHDZDLTSZIMPANCNFSM4W4VEXRA
.

It looks like solution here https://robust-cvd.github.io/. Waiting for code.

Thanks, I'll check it out.
On Thu, 24 Jun 2021 at 15:41, semel1 @.***> wrote:

It looks like solution here https://robust-cvd.github.io/. Waiting for
code.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/intel-isl/MiDaS/issues/87#issuecomment-867692001, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AFIOA3KUCHP4RIA37UHQHY3TUM7YLANCNFSM4W4VEXRA
.

@semel1
looks like the code is up now  :)

so try the code on colab it was about 20 minutes to do on a video of 150
frames  very slow
On Sat, 26 Jun 2021 at 20:33, 3dsf @.***> wrote:

@semel1 https://github.com/semel1
looks like the code is up now :)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/intel-isl/MiDaS/issues/87#issuecomment-869051491, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AFIOA3OR42OWZO3GD3PX34DTUYTSNANCNFSM4W4VEXRA
.

Midas has a flickering effect because original training has no color augmentations. To remove that authors should retain the model with it or you need to reproduce training by yourself with color augmentation.

thanks for the reply are you going to do a model with   color augmentations
training and why was the model not done with   color augmentations did you
not see that with out   color augmentations that your model would have a
lot of flickering in the frames l am using dpt which has not a lot of
flickering thanks
On Fri, 3 Dec 2021 at 13:11, Andrii Litvynchuk @.***>
wrote:

Midas has a flickering effect because original training has no color
augmentations. To remove that authors should retain the model with it or
you need to reproduce training by yourself with color augmentation.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/isl-org/MiDaS/issues/87#issuecomment-985507453, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AFIOA3OHBWPVFOFIWZ75SW3UPC6ZFANCNFSM4W4VEXRA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

I am not the creator of Midas so I cannot answer your questions. Probably, authors will include color augmentations in future version of Midas

Hi @andy500 , did you find a good solution or alternative for this?
I want to infer depth for some random videos. Thanks.

Thanks for the message no still have flickering am using DPT-main
code model_type dpt_large does reduce the flickering effect l am hoping
there will be a update to model that do not create the flickering effects
thank you
On Thu, 9 Dec 2021 at 07:50, Jiaqi Xu @.***> wrote:

Hi @andy500 https://github.com/andy500 , did you find a good solution
or alternative for this?
I want to infer depth for some random videos. Thanks.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/isl-org/MiDaS/issues/87#issuecomment-989597315, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AFIOA3LGQUSWIOQDJYJFXR3UQBNUPANCNFSM4W4VEXRA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

hhh Thank you.
I tried with DPT-large but still some flickering and harms the downstream task somehow.
It seems this is a hard problem for the general-purpose consistent video depth estimation.

Let hope there will update with a new model we can only hope
On Sat, 11 Dec 2021 at 09:17, Jiaqi Xu @.***> wrote:

hhh Thank you.
I tried with DPT-large but still some flickering and harms the downstream
task somehow.
It seems this is a hard problem for the general-purpose consistent video
depth estimation.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/isl-org/MiDaS/issues/87#issuecomment-991566972, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AFIOA3MZQK2DIL2YNLFHFM3UQMJJNANCNFSM4W4VEXRA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

@andy500 this one is really good and efficient https://github.com/yu-li/TCMonoDepth

Got the same error.

repo: isl-org/MiDaS


text:
🛑 Prebel.isolucion.co is down

In 7f5390d, Prebel.isolucion.co (https://Prebel.isolucion.co) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Prebel.isolucion.co is back up in cefc6f2.

repo: isolucionco/EstadoIsolucionHosting


text:
readme information correction

readme content
Basic configuration file: ./src/config.yaml
can only find
consts.ts

fixed it

authors: DerickIT isooosi

repo: isooosi/VisVrs


text:
Everytime getting the below error

I am getting stuck at this point every time I restart or upgrade from BigSur.. currently am in BigSur and trying to upgrade or freshly trying to install Ventura using your EFI... am also having same Dell G3 3579 Laptop but Samsung 860 EVO SSD.
please help me to fix this

https://github.com/isoulgh/isoul-Hackintosh-EFI-Dell-G3-3579-OpenCore/assets/35803467/c1583ed4-3906-4f5a-9ec4-89e2c912deaf
this happens too


text:
Allow running load synchronously

Motivation:
You can't really do much of anything else before agda finishes loading a file, so I'd rather my interface freeze to indicate that the buffer is not in a workable state.
Another big motivation is that if we can rely on load being synchronous, we can then write scripts that run load and rely on the load having completed in order to then run other commands afterwards. Concretely, I wanted to have a bind for :CornelisLoad<CR>:CornelisQuestionToMeta<CR>, but that doesn't currently work out of the box.
Making this PR in a somewhat WIP state since I want to get feedback:

if you'd accept this
if this is the way to make a command synchronous

Notably, I'm still not sure this actually makes the command run synchronously, because my example of :CornelisLoad<CR>:CornelisQuestionToMeta<CR> still doesn't work, but I'm not sure what's going wrong exactly.

Is it possible to make a new command that provides the synchronous behavior? That would be preferable in my book. If so, I'd be willing to merge such a change.

As for why your test doesn't work, my suspicion is that even though you're running the vim command synchronously, the connection with Agda is still async. You'll probably need to block until you've got a response from Agda.
What that response is? I don't know. But I've found that running agda with --interaction-json has been helpful for watching the communication flow to Agda. If you've got an emacs setup, you can snoop on the channel by opening the buffer to Agda.

Is it possible to make a new command that provides the synchronous behavior?

Yep, that sounds better to me as well, thanks!

You'll probably need to block until you've got a response from Agda.

Right, thanks for the tip!
Side question:
Is there some reason why cornelis doesn't automatically expand question marks into metas? This is the behaviour I remember having with emacs, and it's hard to think of a situation where I wouldn't want to expand a question mark into a metas.
At least with the synchronous version that blocks the buffer until agda responds to the load command, it seems like there are no downsides to always converting question marks to metas.

From looking at the agda mode for emacs, it seems that you simply can't issue any other commands while agda is loading.
They do this by

marking certain commands (e.g. load) as "busy"
any commands that are marked "busy" set a variable called agda2-in-progress
you can't issue commands while agda2-in-progress, except for some special commands (e.g. "restart agda", "exit agda")

Does cornelis perhaps want to replicate this behaviour? From looking through the code base, it seems to me that we only indicate an "agda is busy" when we try to issue a load specifically, and not other commands.
But I'm not sure what exactly happens if you try to issue other commands while e.g. agda is currently reloading a file. I would personally wager that there's not much sense in issuing further commands, because by the time agda is done loading, the buffer would potentially be out of date, and you theoretically can't reliable issue any other actions.
What's your experience with using cornelis? Do you always wait for load to finish before doing anything else?

The reason we don't automatically is that it's really hard to implement! The communication between Agda and the editor is rife with race conditions. Emacs gets away with it by embracing the race condition and hacking up a solution that exploits the syntax highlighting of meta variables (when it eventually arrives.) Vim doesn't have nearly as good support for tracking objects in the buffer, and usually gets it wrong.
Pulling out the command gives us a chance to receive the relevant hole information from Agda before needing to process it, which minimizes the chances of this race occurring.
On February 18, 2024 11:21:31 p.m. PST, Georgi Lyubenov @.***> wrote:

Is it possible to make a new command that provides the synchronous behavior?

Yep, that sounds better to me as well, thanks!

You'll probably need to block until you've got a response from Agda.

Right, thanks for the tip!
Side question:
Is there some reason why cornelis doesn't automatically expand question marks into metas? This is the behaviour I remember having with emacs, and it's hard to think of a situation where I wouldn't want to expand a question mark into a metas.
At least with the synchronous version that blocks the buffer until agda responds to the load command, it seems like there are no downsides to always converting question marks to metas.
--
Reply to this email directly or view it on GitHub:
https://github.com/isovector/cornelis/pull/137#issuecomment-1951842124
You are receiving this because you commented.
Message ID: @.***>

FWIW @googleson78 one thing that occured to me thinking about this work here was that maybe a different way to approach it could be via a callback; so after the results of the load command, say, some back, then you would do your second thing.
I'm not sure if that's significantly easier to implement, but it might be?

The difficult part is

after the results of the load command

I believe, although I'm not 100% sure.
Right now after trying out cornelis for a bit, I'm somewhat convinced the best approach would be to implement the same sort of synchronisation that the emacs agda-mode offers (what I've outlined here), where the whole agda process can be put into a state of "busy" on the nvim plugin side, and then you cannot issue commands while in that state. After that it should also be trivial to block the buffer while the plugin is in the "busy" state.
This however obviously will require some bigger amount of work, so I haven't sat down to do it.

The difficult part is ...

I guess so.
Glancing around the code, I suppose what one might need to do is have a kind of Map like
Map Response SomeAction

and when the Agda response comes in ( https://github.com/isovector/cornelis/blob/master/src/Cornelis/Agda.hs#L74 ? ) read that map, and if there is an action in there for the present response, pop it off, and run it.

authors: googleson78 isovector silky

repo: isovector/cornelis


text:
nvcc: not found

在按照教程进行安装的过程中，出现了nvcc: not found的错误。ubuntu20.04之前没有安装过cuda，但是这里却出现了这种错误
(lidar4d) supercoconut@supercoconut:~/Myfile/LiDAR4D/tiny-cuda-nn/bindings/torch$ python setup.py install
/home/supercoconut/Myfile/LiDAR4D/tiny-cuda-nn/bindings/torch/setup.py:5: DeprecationWarning: pkg_resources is deprecated as an API. See https://setuptools.pypa.io/en/latest/pkg_resources.html
from pkg_resources import parse_version
Building PyTorch extension for tiny-cuda-nn version 1.7
Obtained compute capability 89 from PyTorch
sh: 1: nvcc: not found
Targeting C++ standard 14
running install
/home/supercoconut/anaconda3/envs/lidar4d/lib/python3.9/site-packages/setuptools/_distutils/cmd.py:66: SetuptoolsDeprecationWarning: setup.py install is deprecated.
!!
    ********************************************************************************
    Please avoid running ``setup.py`` directly.
    Instead, use pypa/build, pypa/installer or other
    standards-based tools.

    See https://blog.ganssle.io/articles/2021/10/setup-py-deprecated.html for details.
    ********************************************************************************

!!
self.initialize_options()
/home/supercoconut/anaconda3/envs/lidar4d/lib/python3.9/site-packages/setuptools/_distutils/cmd.py:66: EasyInstallDeprecationWarning: easy_install command is deprecated.
!!
    ********************************************************************************
    Please avoid running ``setup.py`` and ``easy_install``.
    Instead, use pypa/build, pypa/installer or other
    standards-based tools.

    See https://github.com/pypa/setuptools/issues/917 for details.
    ********************************************************************************

!!
self.initialize_options()
running bdist_egg
running egg_info
creating tinycudann.egg-info
writing tinycudann.egg-info/PKG-INFO
writing dependency_links to tinycudann.egg-info/dependency_links.txt
writing top-level names to tinycudann.egg-info/top_level.txt
writing manifest file 'tinycudann.egg-info/SOURCES.txt'
/home/supercoconut/anaconda3/envs/lidar4d/lib/python3.9/site-packages/torch/utils/cpp_extension.py:502: UserWarning: Attempted to use ninja as the BuildExtension backend but we could not find ninja.. Falling back to using the slow distutils backend.
warnings.warn(msg.format('we could not find ninja.'))
reading manifest file 'tinycudann.egg-info/SOURCES.txt'
writing manifest file 'tinycudann.egg-info/SOURCES.txt'
installing library code to build/bdist.linux-x86_64/egg
running install_lib
running build_py
creating build
creating build/lib.linux-x86_64-cpython-39
creating build/lib.linux-x86_64-cpython-39/tinycudann
copying tinycudann/modules.py -> build/lib.linux-x86_64-cpython-39/tinycudann
copying tinycudann/init.py -> build/lib.linux-x86_64-cpython-39/tinycudann
copying tinycudann/bindings.cpp -> build/lib.linux-x86_64-cpython-39/tinycudann
running build_ext
error: [Errno 2] No such file or directory: '/usr/local/cuda/bin/nvcc'

Tiny-cuda-nn requires GPU and CUDA. So you need to install CUDA first and then add the CUDA installation to your PATH. For more detailed instruction, you can refer to https://github.com/NVlabs/tiny-cuda-nn.

感谢回复！我之前以为这个命令(pip install torch==2.1.0 torchvision==0.16.0 torchaudio==2.1.0 --index-url https://download.pytorch.org/whl/cu118)是安装cuda，原来是安装pytorch的。我已经成功运行了您开源的代码，并且将自己的安装过程整理到了一个CSDN博客中,但是我现在还有一些疑问：

请问这个算法输出结果只有一些图片么？能否类似于论文中Fig.1，可以展示整个数据集中自身车辆的周围重建结果。
github中的时间线是不是有些问题，是2023而不是2024么。

感谢回复！我之前以为这个命令(pip install torch==2.1.0 torchvision==0.16.0 torchaudio==2.1.0 --index-url https://download.pytorch.org/whl/cu118) 是安装cuda，原来是安装pytorch的。
我已经成功运行了您开源的代码，并且将自己的安装过程整理到了一个CSDN博客 中, 但是我现在还有一些疑问：

请问这个算法输出结果只有一些图片么？能否类似于论文中Fig.1，可以展示整个数据集中自身车辆的周围重建结果。
github中的时间线是不是有些问题，是2023而不是2024么。

Thank you for your blog! 👍

The Fig.1 in the paper is just the original point cloud, in order to show the dynamic scene. And the model will automatically save novel-view reconstructed results of depth/intensity/raydrop images (*.png) and corresponding point clouds (*.npy) in the results filefolder. Btw, we may update some codes of the LiDAR simulator later for easier rendering, so stay tuned.
Thanks. We will revise it in the next update.

authors: dyfcalid supersupercoconut


text:
Text widget border highlight/active not respecting the theme colours

Desktop (please complete the following information):
ttkbootstrap 1.10.1
OS ubuntu 23.10
Describe the bug
The Text widget does not seem to take into account the border highlight/active properties (colour, width) of the theme, among other limitations.
@israel-dryer I suspect this to be a bug, but not sure if this is actually by design. Is this something where you think you can extend ttkbootstrap functionality?
Thanks in advance
To Reproduce
No response
Expected behavior
No response
Screenshots
No response
Additional context
No response

I actually wonder if the problem is actually different.
It appears the first time you apply a rule, it is not being used. If you apply it a second time, the values from the first attempt are being used.
Here is a good example:

To reach this, i have actually swapped between 2 custom themes in ttk creator and ended up with the Text widget having the styling from the previous theme still applied.

repo: israel-dryer/ttkbootstrap


text:
Add baseline switch to nyc instrument command

This implements  #1202
Adds the switch --baseline that creates a baseline coverage file when running nyc instrument ....
The baseline coverage files is saved to <temp-dir>/baseline/coverage.json.
The baseline coverage file saves the zero coverage state for all files specified by your configuration.
Include this file when reporting to highlight source files with no coverage.
Note that  <temp-dir>/baseline/coverage.json isn't automatically included when running nyc report.
However this might not be such an issue when running nyc for instrumentation and reporting only.

bump.  Still relevant, from memory this needs work to finish.

bump.  Still relevant, from memory this needs work to finish.

bump, Still relevant, I'll take another look when there's some maintainer interest

repo: istanbuljs/nyc

license: isc

license_source: bigquery


text:
Move IstioCNI.spec.values.cni to IstioCNI.spec.values?

Is this the right place to submit this?

[X] This is not a question about how to use the sail-operator

Bug Description
The CNI values are currently specified in IstioCNI.spec.values.cni, which looks odd, since we already know we're configuring CNI values. The same applies to ZTunnel (ZTunnel.spec.values.ztunnel).
Should we move the values one level up (to IstioCNI.spec.values and ZTunnel.spec.values), since it's clear that those values are for CNI/ZTunnel?
For Istio, things are a bit different, since we don't have Istio.spec.values.istio, but Istio.spec.values.pilot (and others), but it might make sense to move these values up also. In all three cases, the charts already do use this structure.
Operator Version
0.1.0
Link to Gist with Logs
No response
Additional Information
No response

Yes, I think this is a good idea

authors: dgn luksa

repo: istio-ecosystem/sail-operator


text:
Issue 230: adding bookinfo deploy to e2e framework

Fixes #230
Adding bookinfo deploy to validate proxy injection and proxy Istio version are successful.
Tested on both kind and ocp

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@fjglira: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

lint_sail-operator_main
3594735332c99c5aeda4b8d52cc23b1c22a405f7
link
true
/test lint

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

/test integ-tests-arm64

@fjglira: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

lint_sail-operator_main
5a79cb9dae35ee09e2d4888d8172dd13b4d91579
link
true
/test lint

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

In response to a cherrypick label: new pull request created: #302

authors: fjglira istio-testing


text:
Return intermediate certs when CA signs a CSR

Release note:

NONE

/assign @wattli

@lookuptable: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/auth-presubmit.sh
906183a907798e4dc0235776781b18882024b379
link
/test auth-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@lookuptable: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/auth-presubmit.sh
55c91608d2a397b1f441f2f45c467d0ca9bdaaf5
link
/test auth-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@wattli can you sign off this?

/lgtm, thanks
On Wed, Aug 23, 2017 at 3:08 PM, Yang Guan notifications@github.com wrote:

@wattli https://github.com/wattli can you sign off this?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/istio/auth/pull/237#issuecomment-324476696, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AXQIZhSBdz9jiqUeVIjGpEjlY3S4tJgrks5sbKLWgaJpZM4O_Qk3
.

/approve

authors: istio-testing lookuptable wattli

repo: istio/auth


text:
Calculate % for each retcode and allow initial errors

Also handle 100% error case in graph title
(Stacked diff on top of #56)

with http://localhost:8080/echo?status=503:10,504:20
Code 200 : 2060 (68.7 %)
Code 503 : 318 (10.6 %)
Code 504 : 622 (20.7 %)

repo: istio/fortio


text:
Unable to configure multiple Istio Ingress Gateways

Bug description
Unable to setup Multiple Istio Ingress Gateways via Istio Operator install method
[X ] Configuration Infrastructure
[X] Docs
[X ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
Expected behavior
With the below configuration. Istio should have been able to configure multiple istio ingress gateways.
Steps to reproduce the bug
With the following config
apiVersion: install.istio.io/v1alpha1
kind: IstioOperator
metadata:
  namespace: istio-system
  name: example-istiocontrolplane
spec:
  profile: default
  addonComponents:
    grafana:
      enabled: true
      k8s:
        replicaCount: 1
    istiocoredns:
      enabled: false
    kiali:
      enabled: true
      k8s:
        replicaCount: 1
    prometheus:
      enabled: true
      k8s:
        replicaCount: 1
    tracing:
      enabled: true
  components:
    sds:
      enabled: true
    policy:
      enabled: false
    telemetry:
      enabled: false
    egressGateways:
    - enabled: true
      k8s:
        resources:
          requests:
            cpu: 10m
            memory: 40Mi
      name: istio-egressgateway
    ingressGateways:
    - enabled: true
      k8s:
        resources:
          requests:
            cpu: 10m
            memory: 40Mi
      name: istio-ingressgateway
    - enabled: true
      k8s:
        resources:
          requests:
            cpu: 10m
            memory: 40Mi
      name: istio-ingressgateway-new
  global:
    proxy:
       accessLogEncoding: TEXT
       accessLogFile: /dev/stdout
       autoInject: enabled
    sds:
       enabled: true
  values:
    gateways:
      istio-ingressgateway:
        autoscaleEnabled: true
        debug:
        serviceAnnotations:
          cert.gardener.cloud/secretname: "wildcard-ssl-secret"
          dns.gardener.cloud/class: garden
          dns.gardener.cloud/dnsnames: "*.istio.example.ondemand.com"
          dns.gardener.cloud/ttl: "300"
        labels:
          app: istio-ingressgateway
          istio: istio-ingressgateway
        sds:
          enabled: false
        externalTrafficPolicy: Local
      istio-ingressgateway-new:
        autoscaleEnabled: true
        debug:
        serviceAnnotations:
          cert.gardener.cloud/secretname: "wildcard-ssl-secret-new"
          dns.gardener.cloud/class: garden
          dns.gardener.cloud/dnsnames: "*.new.example.ondemand.com"
          dns.gardener.cloud/ttl: "300"
        labels:
          app: istio-ingressgateway
          istio: istio-ingressgateway
        sds:
          enabled: false
        externalTrafficPolicy: Local

Also the below config does not work
apiVersion: install.istio.io/v1alpha1
kind: IstioOperator
metadata:
  namespace: istio-system
  name: example-istiocontrolplane
spec:
  profile: default
  addonComponents:
    grafana:
      enabled: true
      k8s:
        replicaCount: 1
    istiocoredns:
      enabled: false
    kiali:
      enabled: true
      k8s:
        replicaCount: 1
    prometheus:
      enabled: true
      k8s:
        replicaCount: 1
    tracing:
      enabled: true
  components:
    sds:
      enabled: true
    policy:
      enabled: false
    telemetry:
      enabled: false
    egressGateways:
    - enabled: true
      k8s:
        resources:
          requests:
            cpu: 10m
            memory: 40Mi
      name: istio-egressgateway
    ingressGateways:
    - name: istio-ingressgateway
      namespace: istio-system
      enabled: true
      k8s:
        resources:
          requests:
            cpu: 10m
            memory: 40Mi
        serviceAnnotations:
          cert.gardener.cloud/secretname: "wildcard-ssl-secret"
          dns.gardener.cloud/class: garden
          dns.gardener.cloud/dnsnames: "*.istio.example.ondemand.com"
          dns.gardener.cloud/ttl: "300"
      label:
        app: istio-ingressgateway
        istio: istio-ingressgateway
    - name: istio-ingressgateway-new
      namespace: istio-system
      enabled: true
      k8s:
        resources:
          requests:
            cpu: 10m
            memory: 40Mi
        serviceAnnotations:
          cert.gardener.cloud/secretname: "wildcard-ssl-secret-new"
          dns.gardener.cloud/class: garden
          dns.gardener.cloud/dnsnames: "*.new.example.ondemand.com"
          dns.gardener.cloud/ttl: "300"
      label:
        app: istio-ingressgateway-new
        istio: istio-ingressgateway-new
  global:
    proxy:
       accessLogEncoding: TEXT
       accessLogFile: /dev/stdout
       autoInject: enabled
    sds:
       enabled: true

In this case the istio ingress pod does not come up and gives the following error
[Envoy (Epoch 0)] [2020-03-09 10:15:05.915][27][warning][config] [bazel-out/k8-opt/bin/external/envoy/source/common/config/_virtual_includes/grpc_stream_lib/common/config/grpc_stream.h:91] gRPC config stream closed: 14, no healthy upstream
[Envoy (Epoch 0)] [2020-03-09 10:15:05.915][27][warning][config] [bazel-out/k8-opt/bin/external/envoy/source/common/config/_virtual_includes/grpc_stream_lib/common/config/grpc_stream.h:54] Unable to establish new stream
2020-03-09T10:15:06.171189Z     info    Envoy proxy is NOT ready: config not received from Pilot (is Pilot running?): cds updates: 0 successful, 0 rejected; lds updates: 0 successful, 0 rejected
2020-03-09T10:15:08.172077Z     info    Envoy proxy is NOT ready: config not received from Pilot (is Pilot running?): cds updates: 0 successful, 0 rejected; lds updates: 0 successful, 0 rejected
2020-03-09T10:15:10.171229Z     info    Envoy proxy is NOT ready: config not received from Pilot (is Pilot running?): cds updates: 0 successful, 0 rejected; lds updates: 0 successful, 0 rejected
2020-03-09T10:15:12.171071Z     info    Envoy proxy is NOT ready: config not received from Pilot (is Pilot running?): cds updates: 0 successful, 0 rejected; lds updates: 0 successful, 0 rejected
2020-03-09T10:15:14.171058Z     info    Envoy proxy is NOT ready: config not received from Pilot (is Pilot running?): cds updates: 0 successful, 0 rejected; lds updates: 0 successful, 0 rejected

Version (include the output of istioctl version --remote and kubectl version and helm version if you used Helm)
istioctl version --remote
client version: 1.5.0
egressgateway version: 1.5-alpha.0e6be865d62c9b36d634896850ddcb3005e04352
istio-ingressgateway version:
pilot version: 1.5-alpha.0e6be865d62c9b36d634896850ddcb3005e04352
data plane version: 1.5-alpha.0e6be865d62c9b36d634896850ddcb3005e04352 (4 proxies)

Client Version: version.Info{Major:"1", Minor:"17", GitVersion:"v1.17.3", GitCommit:"06ad960bfd03b39c8310aaf92d1e7c12ce618213", GitTreeState:"clean", BuildDate:"2020-02-12T13:43:46Z", GoVersion:"go1.13.7", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"17", GitVersion:"v1.17.3", GitCommit:"06ad960bfd03b39c8310aaf92d1e7c12ce618213", GitTreeState:"clean", BuildDate:"2020-02-11T18:07:13Z", GoVersion:"go1.13.6", Compiler:"gc", Platform:"linux/amd64"}

How was Istio installed?
Standalone operator install method
Environment where bug was observed (cloud vendor, OS, etc)
AWS with Gardener K8s Cluster

Related https://github.com/istio/istio/issues/20033.

See https://github.com/istio/istio/issues/22253 for top level tracker on all gateway issues and fixes.

For me the operator just errors:
error	failed to generate IstioOperator spec, unknown field "istio-clientgateway" in v1alpha1.GatewaysConfig

authors: jurgenweber linuxbsdfreak ostromart

repo: istio/istio


text:
Make tests runnable in parallel

To debug and fix flaky tests, it useful to run them many times in parallel (using stress usually). However, some tests break down when doing this.
This issue tracks updating all of our unit tests to support this

Known broken:

TestADSC_Run
TestADSC_Save
TestStartEnvoyShouldSucceed
TestStartTwiceShouldDoNothing
TestHotRestart
TestCommandLineArgs
TestShutdown
TestKillEnvoy
TestCancelContext
TestConfigDump
TestXdsProxyHealthCheck
TestWorkloadHealthChecker_PerformApplicationHealthCheck

Known broken:

TestADSC_Run
TestADSC_Save
TestStartEnvoyShouldSucceed
TestStartTwiceShouldDoNothing
TestHotRestart
TestCommandLineArgs
TestShutdown
TestKillEnvoy
TestCancelContext
TestConfigDump
TestXdsProxyHealthCheck
TestWorkloadHealthChecker_PerformApplicationHealthCheck

/assign

/assign

not stale

not stale, but also not high priority


text:
Cannot install Istio 1.16 on OpenShift 1.12-rc0 (based on K8s 1.25) due to required PodSecurity changes

Bug Description
Using OCP 4.12rc0 I get the following when running:
$ istioctl install --set profile=openshift

This will install the Istio 1.16.0 openshift profile with ["Istio core" "Istiod" "CNI" "Ingress gateways"] components into the cluster. Proceed? (y/N) y
✔ Istio core installed
✔ Istiod installed
✔ Ingress gateways installed
- Processing resources for CNI. Waiting for DaemonSet/kube-system/istio-cni-node                                                                                - Processing resources for CNI. Waiting for DaemonSet/kube-system/istio-cni-node                                                                                ✘ CNI encountered an error: failed to wait for resource: resources not ready after 5m0s: timed out waiting for the condition

- Pruning removed resources                                                                                Error: failed to install manifests: errors occurred during operation

Looking into the events in the kube-system namespace I get the following:

2m21s       Warning   FailedCreate   daemonset/istio-cni-node   (combined from similar events): Error creating: pods "istio-cni-node-knflf" is forbidden: violates PodSecurity "restricted:latest": privileged (container "install-cni" must not set securityContext.privileged=true), allowPrivilegeEscalation != false (container "install-cni" must set securityContext.allowPrivilegeEscalation=false), unrestricted capabilities (container "install-cni" must set securityContext.capabilities.drop=["ALL"]), restricted volume types (volumes "cni-bin-dir", "cni-net-dir", "cni-log-dir" use restricted volume type "hostPath"), runAsNonRoot != true (container "install-cni" must not set securityContext.runAsNonRoot=false), runAsUser=0 (container "install-cni" must not set runAsUser=0), seccompProfile (pod or container "install-cni" must set securityContext.seccompProfile.type to "RuntimeDefault" or "Localhost")

Version
istioctl
client version: 1.16.0
control plane version: 1.16.0
data plane version: 1.16.0 (1 proxies)

kubectl
Client Version: v1.24.1
Kustomize Version: v4.5.4
Server Version: v1.25.2+f33d98e

Additional Information
No response

Privileged pods need to run in namespaces with special labels:
pod-security.kubernetes.io/enforce: privileged
pod-security.kubernetes.io/audit: privileged
pod-security.kubernetes.io/warn: privileged

We could move the CNI installation from kube-system namespace to openshift-operators: https://github.com/istio/istio/blob/master/manifests/profiles/openshift.yaml#L7
This namespace already contains these labels.

Run this:
oc adm policy add-scc-to-user privileged  -n openshift-operators -z istio-cni

I was able to deploy cni in the openshift-operators namespace after running only the command above

@jwendell Thank you for your suggestion.  Running this command and installing the istio-cni into the openshift-operators namespace does work.
% kubectl get all -n openshift-operators
NAME                       READY   STATUS    RESTARTS   AGE
pod/istio-cni-node-2zqb9   1/1     Running   0          12m
pod/istio-cni-node-4hsp9   1/1     Running   0          12m
pod/istio-cni-node-5zbjx   1/1     Running   0          12m
pod/istio-cni-node-6wcgb   1/1     Running   0          12m
pod/istio-cni-node-cklmj   1/1     Running   0          12m
pod/istio-cni-node-qkttz   1/1     Running   0          12m
pod/istio-cni-node-rpd6g   1/1     Running   0          12m
pod/istio-cni-node-zwsjb   1/1     Running   0          12m

NAME                            DESIRED   CURRENT   READY   UP-TO-DATE   AVAILABLE   NODE SELECTOR            AGE
daemonset.apps/istio-cni-node   8         8         8       8            8           kubernetes.io/os=linux   12m

I have a hard time understanding how kube-ssytem can deny high priv. Most things in kube-system require high priv (kube-proxy, etc)? Are they not in kube-system in openshift?

See more info at https://docs.openshift.com/container-platform/4.11/release_notes/ocp-4-11-release-notes.html#ocp-4-11-auth-pod-security-admission
They don't allow the adding of these labels to kube-system in our testing. In the base OCP 4.12 install there isn't anything installed to the kube-system namespace anyway. They move a lot of it into other namespaces.

For this release, namespaces that are prefixed with openshift- do not
have restricted enforcement. Restricted enforcement for such namespaces is
planned for inclusion in a future release.

suggests this may not work long term
Maybe istio-system should be used and explicitly allowed?
On Mon, Nov 21, 2022 at 9:36 AM jacob-delgado @.***>
wrote:

See more info at
https://docs.openshift.com/container-platform/4.11/release_notes/ocp-4-11-release-notes.html#ocp-4-11-auth-pod-security-admission
They don't allow the adding of these labels to kube-system in our
testing. In the base OCP 4.12 install there isn't anything installed to the
kube-system namespace anyway. They move a lot of it into other namespaces.
—
Reply to this email directly, view it on GitHub
https://github.com/istio/istio/issues/42055#issuecomment-1322422745, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAEYGXODQYRN3QVAOZL2T3DWJOXKDANCNFSM6AAAAAASDWK7UI
.
You are receiving this because you commented.Message ID:
@.***>

They don't allow the adding of these labels to kube-system in our testing. In the base OCP 4.12 install there isn't anything installed to the kube-system namespace anyway. They move everything it into other namespaces.

It's not that they don't allow adding the labels to kube-system namespace, it's that it's possible but we're not sure it's recommended due to the nature of the kube-system namespace.

After adding the labels to kube-system (either with oc or via edit) and seeing the namespace have them, but they not be applied this doesn't work.
For more info see https://github.com/istio/istio/pull/42093#discussion_r1028535936

@howardjohn and @jwendell Checking for an update, do we know how we're going to handle this issue?

On recent testing, it appears this issue has been resolved: https://github.com/openshift/cluster-kube-apiserver-operator/pull/1405
Closing this issue.

Just leave this here.
If you install Miastra 2.1, uninstall it and try to install Istio - you'll get the same error. Solution is - check openshift-operators namespace, and delete DaemonSet left after Maistra removal.

authors: alishchytovych howardjohn jacob-delgado jwendell rrobb-aspen


text:
Special headers were removed

Bug Description
When we enable istio on eks we have a lot of HTTP 400 errors to some services. Reviewing all the request we are receiving errors with messages like: XXX_HEADER was not provided.
No.	Time	Source	Destination	Protocol	Length	Info
1763	78.858481	172.30.129.227	172.30.129.42	HTTP/JSON	1860	HTTP/1.1 400 Bad Request , JavaScript Object Notation (application/json)

All is working normally when we disable sidecar injection.
Version
client version: 1.16.2
control plane version: 1.16.2
data plane version: 1.16.2 (16 proxies)

Client Version: v1.25.4
Kustomize Version: v4.5.7
Server Version: v1.23.14-eks-ffeb93d

Additional Information

bug-report.tar.gz

maybe because Envoy will normalize the header keys to be all lowercase.

Envoy sanitizes some headers (https://www.envoyproxy.io/docs/envoy/latest/configuration/http/http_conn_man/header_sanitizing). Do you have URI that is sent by the client?

Right now we don't have enough to proceed on this, please feel free to re-open if there is some more information. Thanks!

authors: ggmr2212 howardjohn hzxuzhonghu kyessenov


text:
not able to write to hostpath /etc/ambient-config/config.json.tmp in Bottlerocket os in EKS

Is this the right place to submit this?

[X] This is not a security vulnerability or a crashing bug
[X] This is not a question about how to use Istio

Bug Description
this issue is related to bug #45304 the Bottlerocket OS that we are using in AWS EKS  is quite secure and doesn't allow access to write in /etc dir but allows access for /var and /opt according to OS-Doc ,  but in istio-cni helm chart  the hostpath is hard-coded (line 185 in   CNI-daemonset.yaml  ) .
please could we add hostpath variable in CNI chart values to replace this hostpath value.
Version
$ istioctl version
1.18.0-rc.0
$ kubectl version --short
Client Version: v1.27.1
Kustomize Version: v5.0.1
Server Version: v1.25.9-eks-0a21954

Additional Information
No response
Affected product area

[X] Ambient
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Extensions and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
[ ] Upgrade
[ ] Multi Cluster
[ ] Virtual Machine
[ ] Control Plane Revisions

I see that #45404 was merged; can we close this issue?

Sure, #45405 should solve the file access issue , still facing the GitRepository failure may be istio was not able to configure iptables on host with Bottlerocket os in EKS. Will test and try to identify the exact issue.


text:
Precommit hook sets GOPATH to empty string

The pre-commit hook in "bin/pre-commit" does not work properly because it sets GOPATH to an empty string. It is overall a messy script and in need of updating.
This line is the troublemaker.

export GOPATH=$(cd $ROOT/../..)

Perhaps a typo? I think this should read:
export GOPATH=$(cd $ROOT/../.. && pwd)

cc @ZackButcher for confirmation

Yup probably, though TBH I'm not sure if anyone today actually uses the pre-commit in practice. Either way https://github.com/istio/istio/pull/4874 addresses this just fine IMO.

Ah, I skipped over the part in https://github.com/istio/istio/blob/master/DEV-GUIDE.md#enable-pre-commit-hook which says it's not functional. In any case, I was able to get it working with the changes in #4874. I hope this can also close #2262.

/retest

@Tahler what is the status? Can we merge #4874?

Well, I think the better move is to remove the pre-submit hooks. No one is using it and even in a fixed state, it will take some time to run the unit tests and linters on each commit. I'll close #4874 and make a different PR to delete the pre-submits from the docs and repo.

authors: Tahler ZackButcher ayj hklai


text:
Fix demo

Please take over this work. I'm not good at bash and have strong aversion to it.

This change is

This PR overlaps with https://github.com/istio/istio/pull/107 but is missing many of the fixes in it, and therefore isn't close to actually working. I like the new format of istio.VERSION, but not sure how to get all the other fixes from #107 into here. How about we close this one, and I'll take the improvements and merge them into #107?

Sure, feel free to take the changes here and incorporate them in #107.
I also recommend removing istioctl binary and just fetching it before the test.

The test is failing because bookinfo.yaml cannot be found in dir. Something wrong with generate_bookinfo_yaml

These changes moved into #107

@wlu2016

authors: frankbu kyessenov sebastienvas wattli


text:
Use syncmap to protect fileBasedMetadataConfigAnyMap from race conditions

Fixes #12432

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: JimmyCYJ
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: greghanson
If they are not already assigned, you can assign the PR to them by writing /assign @greghanson in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

pilot/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: JimmyCYJ, quanjielin
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: greghanson
If they are not already assigned, you can assign the PR to them by writing /assign @greghanson in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

pilot/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@JimmyCYJ: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-k8s-tests.sh
9d3bf9f969dca07736fc45b89ec6f88909a0e16b
link
/test istio-integ-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@JimmyCYJ: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-k8s-tests.sh
9d3bf9f969dca07736fc45b89ec6f88909a0e16b
link
/test istio-integ-k8s-tests

prow/istio-pilot-multicluster-e2e.sh
9d3bf9f969dca07736fc45b89ec6f88909a0e16b
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mandarjog @costinm @rshriram @hzxuzhonghu this PR just barely missed the 1.1rc4 cutoff and we thought that 1.1rc4 was likely the final release.  I'm OK creating another release candidate for this, but I'm worried about the risk of accepting additional serialization this late in the game.
Thoughts?

/hold while we discuss

I vote for merging this into 1.1. This is a trivial fix for an important bug.

+1
the helm change should be handled in a separate PR

@quanjielin
Quanjie, could you file a separate issue to track the helm change? I don't think that is related to https://github.com/istio/istio/issues/12442, but for better usability on SDS config. And I guess that fix can wait till 1.1.1 unless it is very trivial fix.

Quanjie, could you file a separate issue to track the helm change? I don't think that is related to #12442, but for better usability on SDS config. And I guess that fix can wait till 1.1.1 unless it is very trivial fix.

I filed https://github.com/istio/istio/issues/12443 to keep tracking of the SDS config improvements.

Thanks @JimmyCYJ , filed https://github.com/istio/istio/issues/12444(to track work in 1.2 when we support per-pod SDS rollout(migration) and SDS in control plane, which may introduce more customer facing settings).

This will go int 1.1rc5

authors: JimmyCYJ duderino istio-testing quanjielin wenchenglu


text:
WIP 12/fix build

Please provide a description for what this PR is for.
And to help us figure out who should review this PR, please
put an X in all the areas that this PR affects.
[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure

@fpesce codecov will never pass because it depends on the previous commit passing tests which doesn't happen because certs expired


text:
pilot/xds: replace mutex with atomic.Bool when accessing cache sync

It seems to me that the synchronization for serverReady could be atomic.Bool instead of two mutexs, unless the IsServerReady() should be blocked during the EndpointShardsByService is being updated.
Please correct me if I misunderstood anything here.
[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ ] Networking
[x] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
Pull Request Attributes
Please check any characteristics that apply to this pull request.
[ ] Does not have any changes that may affect Istio users.

Hi @panjf2000. Thanks for your PR.
I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

/ok-to-test

@panjf2000: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
932593e8907c37071a7f53321a1a3e6d6dfae846
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@panjf2000: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
932593e8907c37071a7f53321a1a3e6d6dfae846
link
/test unit-tests_istio

release-test_istio
932593e8907c37071a7f53321a1a3e6d6dfae846
link
/test release-test_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@panjf2000: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
932593e8907c37071a7f53321a1a3e6d6dfae846
link
/test unit-tests_istio

release-test_istio
932593e8907c37071a7f53321a1a3e6d6dfae846
link
/test release-test_istio

integ-telemetry-k8s-tests_istio
932593e8907c37071a7f53321a1a3e6d6dfae846
link
/test integ-telemetry-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@panjf2000: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
932593e8907c37071a7f53321a1a3e6d6dfae846
link
/test unit-tests_istio

release-test_istio
932593e8907c37071a7f53321a1a3e6d6dfae846
link
/test release-test_istio

integ-telemetry-k8s-tests_istio
932593e8907c37071a7f53321a1a3e6d6dfae846
link
/test integ-telemetry-k8s-tests_istio

release-notes_istio
932593e8907c37071a7f53321a1a3e6d6dfae846
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@panjf2000: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
932593e8907c37071a7f53321a1a3e6d6dfae846
link
/test unit-tests_istio

release-test_istio
932593e8907c37071a7f53321a1a3e6d6dfae846
link
/test release-test_istio

integ-telemetry-k8s-tests_istio
932593e8907c37071a7f53321a1a3e6d6dfae846
link
/test integ-telemetry-k8s-tests_istio

release-notes_istio
932593e8907c37071a7f53321a1a3e6d6dfae846
link
/test release-notes_istio

integ-distroless-k8s-tests_istio
932593e8907c37071a7f53321a1a3e6d6dfae846
link
/test integ-distroless-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@panjf2000: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
932593e8907c37071a7f53321a1a3e6d6dfae846
link
/test unit-tests_istio

release-test_istio
932593e8907c37071a7f53321a1a3e6d6dfae846
link
/test release-test_istio

integ-telemetry-k8s-tests_istio
932593e8907c37071a7f53321a1a3e6d6dfae846
link
/test integ-telemetry-k8s-tests_istio

release-notes_istio
932593e8907c37071a7f53321a1a3e6d6dfae846
link
/test release-notes_istio

integ-distroless-k8s-tests_istio
932593e8907c37071a7f53321a1a3e6d6dfae846
link
/test integ-distroless-k8s-tests_istio

integ-security-k8s-tests_istio
932593e8907c37071a7f53321a1a3e6d6dfae846
link
/test integ-security-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Makefile.core.mk:290: recipe for target 'build' failed
make: *** [build] Error 2
++ docker ps -q

docker kill
"docker kill" requires at least 1 argument.
See 'docker kill --help'.

This seems not a source code issue?

@panjf2000: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
932593e8907c37071a7f53321a1a3e6d6dfae846
link
/test unit-tests_istio

release-test_istio
932593e8907c37071a7f53321a1a3e6d6dfae846
link
/test release-test_istio

integ-telemetry-k8s-tests_istio
932593e8907c37071a7f53321a1a3e6d6dfae846
link
/test integ-telemetry-k8s-tests_istio

release-notes_istio
932593e8907c37071a7f53321a1a3e6d6dfae846
link
/test release-notes_istio

integ-distroless-k8s-tests_istio
932593e8907c37071a7f53321a1a3e6d6dfae846
link
/test integ-distroless-k8s-tests_istio

integ-security-k8s-tests_istio
932593e8907c37071a7f53321a1a3e6d6dfae846
link
/test integ-security-k8s-tests_istio

lint_istio
932593e8907c37071a7f53321a1a3e6d6dfae846
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@panjf2000: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
932593e8907c37071a7f53321a1a3e6d6dfae846
link
/test unit-tests_istio

release-test_istio
932593e8907c37071a7f53321a1a3e6d6dfae846
link
/test release-test_istio

integ-telemetry-k8s-tests_istio
932593e8907c37071a7f53321a1a3e6d6dfae846
link
/test integ-telemetry-k8s-tests_istio

release-notes_istio
932593e8907c37071a7f53321a1a3e6d6dfae846
link
/test release-notes_istio

integ-distroless-k8s-tests_istio
932593e8907c37071a7f53321a1a3e6d6dfae846
link
/test integ-distroless-k8s-tests_istio

integ-security-k8s-tests_istio
932593e8907c37071a7f53321a1a3e6d6dfae846
link
/test integ-security-k8s-tests_istio

lint_istio
932593e8907c37071a7f53321a1a3e6d6dfae846
link
/test lint_istio

integ-operator-controller-tests_istio
932593e8907c37071a7f53321a1a3e6d6dfae846
link
/test integ-operator-controller-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@panjf2000: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
932593e8907c37071a7f53321a1a3e6d6dfae846
link
/test unit-tests_istio

release-test_istio
932593e8907c37071a7f53321a1a3e6d6dfae846
link
/test release-test_istio

integ-telemetry-k8s-tests_istio
932593e8907c37071a7f53321a1a3e6d6dfae846
link
/test integ-telemetry-k8s-tests_istio

release-notes_istio
932593e8907c37071a7f53321a1a3e6d6dfae846
link
/test release-notes_istio

integ-distroless-k8s-tests_istio
932593e8907c37071a7f53321a1a3e6d6dfae846
link
/test integ-distroless-k8s-tests_istio

integ-security-k8s-tests_istio
932593e8907c37071a7f53321a1a3e6d6dfae846
link
/test integ-security-k8s-tests_istio

lint_istio
932593e8907c37071a7f53321a1a3e6d6dfae846
link
/test lint_istio

integ-operator-controller-tests_istio
932593e8907c37071a7f53321a1a3e6d6dfae846
link
/test integ-operator-controller-tests_istio

gencheck_istio
932593e8907c37071a7f53321a1a3e6d6dfae846
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@panjf2000: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
932593e8907c37071a7f53321a1a3e6d6dfae846
link
/test unit-tests_istio

release-test_istio
932593e8907c37071a7f53321a1a3e6d6dfae846
link
/test release-test_istio

integ-telemetry-k8s-tests_istio
932593e8907c37071a7f53321a1a3e6d6dfae846
link
/test integ-telemetry-k8s-tests_istio

release-notes_istio
932593e8907c37071a7f53321a1a3e6d6dfae846
link
/test release-notes_istio

integ-distroless-k8s-tests_istio
932593e8907c37071a7f53321a1a3e6d6dfae846
link
/test integ-distroless-k8s-tests_istio

integ-security-k8s-tests_istio
932593e8907c37071a7f53321a1a3e6d6dfae846
link
/test integ-security-k8s-tests_istio

lint_istio
932593e8907c37071a7f53321a1a3e6d6dfae846
link
/test lint_istio

integ-operator-controller-tests_istio
932593e8907c37071a7f53321a1a3e6d6dfae846
link
/test integ-operator-controller-tests_istio

gencheck_istio
932593e8907c37071a7f53321a1a3e6d6dfae846
link
/test gencheck_istio

analyze-tests_istio
932593e8907c37071a7f53321a1a3e6d6dfae846
link
/test analyze-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@panjf2000: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
932593e8907c37071a7f53321a1a3e6d6dfae846
link
/test unit-tests_istio

release-test_istio
932593e8907c37071a7f53321a1a3e6d6dfae846
link
/test release-test_istio

integ-telemetry-k8s-tests_istio
932593e8907c37071a7f53321a1a3e6d6dfae846
link
/test integ-telemetry-k8s-tests_istio

release-notes_istio
932593e8907c37071a7f53321a1a3e6d6dfae846
link
/test release-notes_istio

integ-distroless-k8s-tests_istio
932593e8907c37071a7f53321a1a3e6d6dfae846
link
/test integ-distroless-k8s-tests_istio

integ-security-k8s-tests_istio
932593e8907c37071a7f53321a1a3e6d6dfae846
link
/test integ-security-k8s-tests_istio

lint_istio
932593e8907c37071a7f53321a1a3e6d6dfae846
link
/test lint_istio

integ-operator-controller-tests_istio
932593e8907c37071a7f53321a1a3e6d6dfae846
link
/test integ-operator-controller-tests_istio

gencheck_istio
932593e8907c37071a7f53321a1a3e6d6dfae846
link
/test gencheck_istio

analyze-tests_istio
932593e8907c37071a7f53321a1a3e6d6dfae846
link
/test analyze-tests_istio

integ-pilot-k8s-tests_istio
932593e8907c37071a7f53321a1a3e6d6dfae846
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@panjf2000: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
932593e8907c37071a7f53321a1a3e6d6dfae846
link
/test unit-tests_istio

release-test_istio
932593e8907c37071a7f53321a1a3e6d6dfae846
link
/test release-test_istio

integ-telemetry-k8s-tests_istio
932593e8907c37071a7f53321a1a3e6d6dfae846
link
/test integ-telemetry-k8s-tests_istio

release-notes_istio
932593e8907c37071a7f53321a1a3e6d6dfae846
link
/test release-notes_istio

integ-distroless-k8s-tests_istio
932593e8907c37071a7f53321a1a3e6d6dfae846
link
/test integ-distroless-k8s-tests_istio

integ-security-k8s-tests_istio
932593e8907c37071a7f53321a1a3e6d6dfae846
link
/test integ-security-k8s-tests_istio

lint_istio
932593e8907c37071a7f53321a1a3e6d6dfae846
link
/test lint_istio

integ-operator-controller-tests_istio
932593e8907c37071a7f53321a1a3e6d6dfae846
link
/test integ-operator-controller-tests_istio

gencheck_istio
932593e8907c37071a7f53321a1a3e6d6dfae846
link
/test gencheck_istio

analyze-tests_istio
932593e8907c37071a7f53321a1a3e6d6dfae846
link
/test analyze-tests_istio

integ-pilot-k8s-tests_istio
932593e8907c37071a7f53321a1a3e6d6dfae846
link
/test integ-pilot-k8s-tests_istio

integ-telemetry-mc-k8s-tests_istio
932593e8907c37071a7f53321a1a3e6d6dfae846
link
/test integ-telemetry-mc-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@panjf2000: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
932593e8907c37071a7f53321a1a3e6d6dfae846
link
/test unit-tests_istio

release-test_istio
932593e8907c37071a7f53321a1a3e6d6dfae846
link
/test release-test_istio

integ-telemetry-k8s-tests_istio
932593e8907c37071a7f53321a1a3e6d6dfae846
link
/test integ-telemetry-k8s-tests_istio

release-notes_istio
932593e8907c37071a7f53321a1a3e6d6dfae846
link
/test release-notes_istio

integ-distroless-k8s-tests_istio
932593e8907c37071a7f53321a1a3e6d6dfae846
link
/test integ-distroless-k8s-tests_istio

integ-security-k8s-tests_istio
932593e8907c37071a7f53321a1a3e6d6dfae846
link
/test integ-security-k8s-tests_istio

lint_istio
932593e8907c37071a7f53321a1a3e6d6dfae846
link
/test lint_istio

integ-operator-controller-tests_istio
932593e8907c37071a7f53321a1a3e6d6dfae846
link
/test integ-operator-controller-tests_istio

gencheck_istio
932593e8907c37071a7f53321a1a3e6d6dfae846
link
/test gencheck_istio

analyze-tests_istio
932593e8907c37071a7f53321a1a3e6d6dfae846
link
/test analyze-tests_istio

integ-pilot-k8s-tests_istio
932593e8907c37071a7f53321a1a3e6d6dfae846
link
/test integ-pilot-k8s-tests_istio

integ-telemetry-mc-k8s-tests_istio
932593e8907c37071a7f53321a1a3e6d6dfae846
link
/test integ-telemetry-mc-k8s-tests_istio

integ-helm-tests_istio
932593e8907c37071a7f53321a1a3e6d6dfae846
link
/test integ-helm-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@panjf2000: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
932593e8907c37071a7f53321a1a3e6d6dfae846
link
/test unit-tests_istio

release-test_istio
932593e8907c37071a7f53321a1a3e6d6dfae846
link
/test release-test_istio

integ-telemetry-k8s-tests_istio
932593e8907c37071a7f53321a1a3e6d6dfae846
link
/test integ-telemetry-k8s-tests_istio

release-notes_istio
932593e8907c37071a7f53321a1a3e6d6dfae846
link
/test release-notes_istio

integ-distroless-k8s-tests_istio
932593e8907c37071a7f53321a1a3e6d6dfae846
link
/test integ-distroless-k8s-tests_istio

integ-security-k8s-tests_istio
932593e8907c37071a7f53321a1a3e6d6dfae846
link
/test integ-security-k8s-tests_istio

lint_istio
932593e8907c37071a7f53321a1a3e6d6dfae846
link
/test lint_istio

integ-operator-controller-tests_istio
932593e8907c37071a7f53321a1a3e6d6dfae846
link
/test integ-operator-controller-tests_istio

gencheck_istio
932593e8907c37071a7f53321a1a3e6d6dfae846
link
/test gencheck_istio

analyze-tests_istio
932593e8907c37071a7f53321a1a3e6d6dfae846
link
/test analyze-tests_istio

integ-pilot-k8s-tests_istio
932593e8907c37071a7f53321a1a3e6d6dfae846
link
/test integ-pilot-k8s-tests_istio

integ-telemetry-mc-k8s-tests_istio
932593e8907c37071a7f53321a1a3e6d6dfae846
link
/test integ-telemetry-mc-k8s-tests_istio

integ-helm-tests_istio
932593e8907c37071a7f53321a1a3e6d6dfae846
link
/test integ-helm-tests_istio

integ-security-multicluster-tests_istio
932593e8907c37071a7f53321a1a3e6d6dfae846
link
/test integ-security-multicluster-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@panjf2000: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
932593e8907c37071a7f53321a1a3e6d6dfae846
link
/test unit-tests_istio

release-test_istio
932593e8907c37071a7f53321a1a3e6d6dfae846
link
/test release-test_istio

integ-telemetry-k8s-tests_istio
932593e8907c37071a7f53321a1a3e6d6dfae846
link
/test integ-telemetry-k8s-tests_istio

integ-distroless-k8s-tests_istio
932593e8907c37071a7f53321a1a3e6d6dfae846
link
/test integ-distroless-k8s-tests_istio

integ-security-k8s-tests_istio
932593e8907c37071a7f53321a1a3e6d6dfae846
link
/test integ-security-k8s-tests_istio

lint_istio
932593e8907c37071a7f53321a1a3e6d6dfae846
link
/test lint_istio

integ-operator-controller-tests_istio
932593e8907c37071a7f53321a1a3e6d6dfae846
link
/test integ-operator-controller-tests_istio

gencheck_istio
932593e8907c37071a7f53321a1a3e6d6dfae846
link
/test gencheck_istio

analyze-tests_istio
932593e8907c37071a7f53321a1a3e6d6dfae846
link
/test analyze-tests_istio

integ-pilot-k8s-tests_istio
932593e8907c37071a7f53321a1a3e6d6dfae846
link
/test integ-pilot-k8s-tests_istio

integ-telemetry-mc-k8s-tests_istio
932593e8907c37071a7f53321a1a3e6d6dfae846
link
/test integ-telemetry-mc-k8s-tests_istio

integ-helm-tests_istio
932593e8907c37071a7f53321a1a3e6d6dfae846
link
/test integ-helm-tests_istio

integ-security-multicluster-tests_istio
932593e8907c37071a7f53321a1a3e6d6dfae846
link
/test integ-security-multicluster-tests_istio

release-notes_istio
d87aed8a0fa97fb8cb93fb30268e92e68f617faf
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@panjf2000: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
932593e8907c37071a7f53321a1a3e6d6dfae846
link
/test unit-tests_istio

release-test_istio
932593e8907c37071a7f53321a1a3e6d6dfae846
link
/test release-test_istio

integ-telemetry-k8s-tests_istio
932593e8907c37071a7f53321a1a3e6d6dfae846
link
/test integ-telemetry-k8s-tests_istio

integ-distroless-k8s-tests_istio
932593e8907c37071a7f53321a1a3e6d6dfae846
link
/test integ-distroless-k8s-tests_istio

integ-security-k8s-tests_istio
932593e8907c37071a7f53321a1a3e6d6dfae846
link
/test integ-security-k8s-tests_istio

lint_istio
932593e8907c37071a7f53321a1a3e6d6dfae846
link
/test lint_istio

integ-operator-controller-tests_istio
932593e8907c37071a7f53321a1a3e6d6dfae846
link
/test integ-operator-controller-tests_istio

gencheck_istio
932593e8907c37071a7f53321a1a3e6d6dfae846
link
/test gencheck_istio

analyze-tests_istio
932593e8907c37071a7f53321a1a3e6d6dfae846
link
/test analyze-tests_istio

integ-pilot-k8s-tests_istio
932593e8907c37071a7f53321a1a3e6d6dfae846
link
/test integ-pilot-k8s-tests_istio

integ-telemetry-mc-k8s-tests_istio
932593e8907c37071a7f53321a1a3e6d6dfae846
link
/test integ-telemetry-mc-k8s-tests_istio

integ-helm-tests_istio
932593e8907c37071a7f53321a1a3e6d6dfae846
link
/test integ-helm-tests_istio

integ-security-multicluster-tests_istio
932593e8907c37071a7f53321a1a3e6d6dfae846
link
/test integ-security-multicluster-tests_istio

release-notes_istio
d87aed8a0fa97fb8cb93fb30268e92e68f617faf
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@panjf2000: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-test_istio
932593e8907c37071a7f53321a1a3e6d6dfae846
link
/test release-test_istio

integ-telemetry-k8s-tests_istio
932593e8907c37071a7f53321a1a3e6d6dfae846
link
/test integ-telemetry-k8s-tests_istio

integ-distroless-k8s-tests_istio
932593e8907c37071a7f53321a1a3e6d6dfae846
link
/test integ-distroless-k8s-tests_istio

integ-security-k8s-tests_istio
932593e8907c37071a7f53321a1a3e6d6dfae846
link
/test integ-security-k8s-tests_istio

lint_istio
932593e8907c37071a7f53321a1a3e6d6dfae846
link
/test lint_istio

integ-operator-controller-tests_istio
932593e8907c37071a7f53321a1a3e6d6dfae846
link
/test integ-operator-controller-tests_istio

analyze-tests_istio
932593e8907c37071a7f53321a1a3e6d6dfae846
link
/test analyze-tests_istio

integ-pilot-k8s-tests_istio
932593e8907c37071a7f53321a1a3e6d6dfae846
link
/test integ-pilot-k8s-tests_istio

integ-telemetry-mc-k8s-tests_istio
932593e8907c37071a7f53321a1a3e6d6dfae846
link
/test integ-telemetry-mc-k8s-tests_istio

integ-helm-tests_istio
932593e8907c37071a7f53321a1a3e6d6dfae846
link
/test integ-helm-tests_istio

integ-security-multicluster-tests_istio
932593e8907c37071a7f53321a1a3e6d6dfae846
link
/test integ-security-multicluster-tests_istio

release-notes_istio
d87aed8a0fa97fb8cb93fb30268e92e68f617faf
link
/test release-notes_istio

unit-tests_istio
d87aed8a0fa97fb8cb93fb30268e92e68f617faf
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

It seems like a temporary failure? or it is caused by my code changes?

/test unit-tests_istio

maybe a flake

@panjf2000: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
d87aed8a0fa97fb8cb93fb30268e92e68f617faf
link
/test unit-tests_istio

release-notes_istio
d87aed8a0fa97fb8cb93fb30268e92e68f617faf
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@panjf2000: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
d87aed8a0fa97fb8cb93fb30268e92e68f617faf
link
/test release-notes_istio

unit-tests_istio
d87aed8a0fa97fb8cb93fb30268e92e68f617faf
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Well, the unit-tests_istio failed again, maybe it is caused by my code changes, but I don't get the causes, and this failure is  different from the last one:

Any clue about it?

The last failed test now pass:

/retest

@hzxuzhonghu @panjf2000 what is the benefit of this change?  If it improves performance by reducing lock contention, I'd expect there to be a comparison of performance results before and after the change

@panjf2000 could you do the performance comparison and attach the results here?
My concern is that if you introduced a race condition with this change, the tests that ran against your PR might not catch it, and I'd at least like to understand the benefits of this change.
If there are no detectable benefits, then I think we should revert it.  There's no reason to risk introducing a race condition if we can't demonstrate a performance improvement.

Although the performance improvement is pretty intuitive (the atomic operation is faster than lock and the DiscoveryServer.IsServerReady() will be blocked if it happens to be in the middle of DiscoveryServer.EndpointShardsByService being updated cuz they share the same mutex, which makes it even slower), I can still submit a benchmark for this latter if you insist.

@panjf2000 Amdahl's Law applies here.  Your change may have improved performance in an area that the program spends little time in.   In such a case, we would end up taking the risk of introducing a race condition for an insignificant benefit.

Yeah, i understand your concern. Since this is a minor improvement, so i approved

authors: carolynhu duderino hzxuzhonghu istio-testing panjf2000


text:
Disable vm test in cluster wide

Cluster provisioning is enabled on cluster wide test, and vm test has not been updated to use the pre-provisioned VM and is creating instead a VM in the main testing project. The VM test is using local network IP, and the cluster and the VM are not in the same project which makes communication between those 2 impossible.
Disabling the vm test for now until we can take advantage of the provisioned VM

@sebastienvas: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
4579805ca92e16aa971b09921fed2d1bf4e8476a
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test istio-pilot-e2e

@sebastienvas: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
4579805ca92e16aa971b09921fed2d1bf4e8476a
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/lgtm

@sebastienvas: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
4579805ca92e16aa971b09921fed2d1bf4e8476a
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

authors: chxchx istio-testing sebastienvas


text:
Reduce test duration for google mock CA

Reduce the sleep delay for the mock CA server. The reason for the flakiness is the time it takes until the first listener accept call which should not take over 1 second.
Tested on 1000 retries on my local machine.

[ ] Configuration Infrastructure

[ ] Docs

[ ] Installation

[ ] Networking

[ ] Performance and Scalability

[ ] Policies and Telemetry

[ ] Security

[x] Test and Release

[ ] User Experience

[ ] Developer Infrastructure

[x] Does not have any user-facing changes. This may include CLI changes, API changes, behavior changes, performance improvements, etc.

Hi @ichbinfrog. Thanks for your PR.
I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

/ok-to-test

authors: howardjohn ichbinfrog istio-testing


text:
Automator: update common-files@master in istio/istio@master

Generated by Automator - 2022-05-03T15:29:55+00:00

@istio-testing: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-distroless_istio
e5d8290e140ff4ebe834c5e51d62fc2903c5c38f
link
unknown
/test integ-distroless_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test integ-distroless_istio

authors: ericvn istio-testing


text:
improve check-inject example output

Please provide a description of this PR:
Previous output：

Output after adjustment：

To help us figure out who should review this PR, please put an X in all the areas that this PR affects.

[ ] Ambient
[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[x] User Experience
[ ] Developer Infrastructure

Please check any characteristics that apply to this pull request.

[x] Does not have any user-facing changes. This may include CLI changes, API changes, behavior changes, performance improvements, etc.

@my-git9: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
a095d74d78101bba34076ddfb40e6c575d19695d
link
true
/test release-notes

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test release-notes

@my-git9: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests_istio
a095d74d78101bba34076ddfb40e6c575d19695d
link
true
/test unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

authors: hanxiaop istio-testing my-git9


text:
DONOTSUBMIT - PLEASE IGNORE

Enable Dependabot for Docker and GoMod if not already so.
Keeping K8s dependencies up-to-date.
This PR is created by bot.
Signed-off-by: zhuxiaow@google.com

Hi @zhuxiaow0. Thanks for your PR.
I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.


text:
WIP: improve iptables locking

Our current iptables locking strategy is "retry a few times if we fail to get the lock". This is broken in a number of different ways, depending on the environment.
For background, iptables execution is network namespace scoped, but the lock is in the filesystem. We want exclusive access in the network namespace when we do any writes.
iptables 1.6.2 adds locking to iptables-restore. Before then, there is no locking in this command since its atomic -- but the lock ensures that others using raw iptables commands do not cause issues.
In CNI, we are in the host filesystem. So the lock we acquire is the host lock -- the same one kube-proxy and others acquire. This can cause extreme contention - in some cases we have seen users effectively unable to schedule any pods for hours due to this. The lock is useless, because we are running the commands in the pod network namespace, not the host!
In init-container mode, we should never have lock contention so its not a big deal.
The new logic is based on the iptables version and whether we are in CNI:

If we are using an old version without locking, just run the command. No need to do anything tricky or retry
if we are in istio-init mode, let iptables wait for us with --wait=30 (30s wait)
if we are in CNI mode, we will disable locking. This is done differently based on the version. See code for details

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

The lock is useless, because we are running the commands in the pod network namespace, not the host!

Ah good catch.

Ah good catch. This is specific to iptables-legacy, correct? As it's the only one that uses xtables.lock? AFAIK iptables-nft doesn't require/support/allow file-based locking.

I haven't personally verified this myself, but another expert said the same so I believe y'all :slightly_smiling_face:

/cc @jaellio @MorrisLaw This would be a cool PR to review

PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Ah good catch. This is specific to iptables-legacy, correct? As it's the only one that uses xtables.lock? AFAIK iptables-nft doesn't require/support/allow file-based locking.

correct

the changes for iptables logic lgtm, I don't have enough understanding of the codebase to judge of the other changes on the logic are correct though

@howardjohn: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
fd92fbb0e2345ccf23eac8a448c8c4936d606bef
link
true
/test release-notes

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
fd92fbb0e2345ccf23eac8a448c8c4936d606bef
link
true
/test release-notes

lint_istio
fd92fbb0e2345ccf23eac8a448c8c4936d606bef
link
true
/test lint

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
fd92fbb0e2345ccf23eac8a448c8c4936d606bef
link
true
/test release-notes

lint_istio
fd92fbb0e2345ccf23eac8a448c8c4936d606bef
link
true
/test lint

integ-cni_istio
fd92fbb0e2345ccf23eac8a448c8c4936d606bef
link
true
/test integ-cni

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

authors: aojea bleggett howardjohn istio-testing keithmattix


text:
Assert kind.Service is disallowed in ConfigKey

Please provide a description of this PR:
To prevent the use of Service by mistake, we all use ServiceEntry now
To help us figure out who should review this PR, please put an X in all the areas that this PR affects.

[ ] Ambient
[ ] Configuration Infrastructure
[ ] Docs
[ ] Dual Stack
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure

Please check any characteristics that apply to this pull request.

[x] Does not have any user-facing changes. This may include CLI changes, API changes, behavior changes, performance improvements, etc.

@hzxuzhonghu: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
e515cf12c87e025dc768ab6837d6a8b6ba2259e8
link
true
/test release-notes

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test release-notes

cc @ramaraochavali

authors: hzxuzhonghu istio-testing


text:
improved enroll-namespace message

Please provide a description of this PR:
fixes #50569
new message will look like:
namespace default labeled with "istio.io/use-waypoint: waypoint"

@ilrudie: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
355e0a601bc2fc167620ea6b45f189434b1c516f
link
true
/test release-notes

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

authors: howardjohn ilrudie istio-testing