text:
0.21.0 iOS build failed when Google Maps are not included

Is this a bug report?
Yes
Have you read the Installation Instructions?
Yes
Environment
react: 16.3.0
react-native: 0.54.4
react-native-maps: 0.21.0
iOS only, without Google Maps
Steps to Reproduce
Expected Behavior
The build succeeds.
Actual Behavior
The iOS build crashes with AIRGoogleMapCircle.h:7:9: fatal error: 'GoogleMaps/GoogleMaps.h' file not found even if I do not use Google Maps.
The cause is commit https://github.com/react-community/react-native-maps/commit/d22f96f9115f10b50085206463143c421f8d948d where some Google-depending sources have been added to AirMaps.xcodeproj/project.pbxproj.
For now I got things moving again with a npm postinstall script that deletes the references:
"postinstall": "sed -i '' '/Google.*\\.[h|m]/d' node_modules/react-native-maps/lib/ios/AirMaps.xcodeproj/project.pbxproj"
Reproducible Demo
I expect that any iOS project that does not use Google Maps will have the same problem.

@radubatori did you remove from podfile all the Google references as per installation instructions?
You might also need to clean your xcode project and run pod install again if you had the google refs on before.

I did not use Google Maps from the star, so the podfile does not reference 'react-native-google-maps' or 'GoogleMaps'.
The same result is obtained if I do not use pods and add AirMaps as a library directly.

@rafaellincoln could you please have a look? 🤗

I just upgraded from 0.20.1 to 0.21.0 and I appear to be having this issue as well.

Can you reopen this ticket?  I'm also having this problem.  The sed line that @radubatori suggests does fix this problem for me. (@radubatori you should remove one of the backslashes in your sed line)

I've reopened the issue, but I cannot provide a clean environment to reproduce it.
@arichnad The extra backslash is there to escape the backslash in package.json. If the command is ran directly, then yes, one backslash has to be removed.

@TheWrongAlice are you using react-native-maps: 0.21.0 ?

@meylor Yes that's right.

@TheWrongAlice here are the versions from my package.json
{
  "name": "MobileApp",
  "version": "0.0.1",
  "private": true,
  "scripts": {
    "postinstall": "scripts/postinstall.sh",
    "start": "node node_modules/react-native/local-cli/cli.js start",
    "test": "jest"
  },
  "dependencies": {
    "react": "16.3.0",
    "react-native": "0.54.2",
    "react-native-maps": "0.21.0"
    ...
  },
  "devDependencies": {
    ...
  },
  "jest": {
    "preset": "react-native"
  }
}

postinstall.sh is is just doing patch -p1 < $patchfile ; perhaps you're not having the same issue?

@meylor I got your solution to work now (I guess I was doing something wrong the first time).
My build is succeeding! :balloon:
I hope that this can be fixed in the master branch soon.

@radubatori @rafaellincoln @meylor could you guys collaborate and make a PR to solve this issue 🤗 ❤

@TheWrongAlice  what are you doing wrong? i have the same problem like you.  im getting
Helmers-Mac:react-native-maps helmer$ patch -p1 < react-native-maps-remove-google-support.patch patching file ./lib/ios/AirMaps.xcodeproj/project.pbxproj patch unexpectedly ends in middle of line Hunk #4 succeeded at 240 with fuzz 1.

Same issue here, using the patch mentioned by @meylor fixed it for me.

@rborn @rafaellincoln I can try to take a look at making a PR this weekend. I don't think that removing the AirGoogleMaps dependencies from project.pbxproj is the right approach since someone may actually want to use GoogleMaps. I'm guessing that most people are having an issue because they're not using CocoaPods, which is a requirement in the installation instructions.
Simple solution should be to add instructions for manually adding the GoogleMaps header files. I haven't yet looked at the source, but it seems odd that the default for not using GoogleMaps is to not have the Pod dependencies, which are require a requirement in the project.pbxproj file.
  pod 'react-native-maps', path: rn_maps_path
  pod 'react-native-google-maps', path: rn_maps_path  # Remove this line if you don't want to support GoogleMaps on iOS
  pod 'GoogleMaps'  # Remove this line if you don't want to support GoogleMaps on iOS
  pod 'Google-Maps-iOS-Utils' # Remove this line if you don't want to support GoogleMaps on iOS

One way to not use GoogleMaps is to use ${inherited} on the header / framework search paths.
If that was included it would be possible to simple add the framework directly and set their path on the settings of the app.

Estou usando sem cocoapods, após a atualização para 0.21.0 este problema aparece.
É possível consertar sem cocoapods?

Is there any  installation instructions for people who do not use cocoapods?
Cann't get the new version work in ios because of the GoogleMap.h not fount error.

remove all google maps reference in build phases -> compile source in Librairies/AirMap/Build Phases

@hamsddxn this solution means it needs to be done every time yarn install re-installs libraries and it will not work for CI-s.
I use cocoa-pods in my projects but I prefer to keep react-native out of it so far, as there are other libraries that depend on react and don't support cocoa-pods.

I would love to see some installation instructions that do not require CocoaPods. No matter how complicated they may be.

I tried install without cocoapod and manually install GoogleMap SDK(because I want to use google map), but it's  really not good, it wasted me a lot of time.
the point is that you have to install google-maps-ios-utils to use react-native-map(otherwise you will get errors) but that utils doesnot have  manual installation instructions except cocoapod.
so finally I have to use cocoapod to use this library.

We managed to get it installed without CocoaPods!
cc: @theonetheycallneo maybe we could share what we did with this thread to help others looking to do a pure manual install.

@duro would love to see manual install instructions sans cocoa pods

@duro yes please share your experience !

@theonetheycallneo, Does this tutorial work with Apple Maps, or just with Google Maps?

@theonetheycallneo Hi!
I tried your instruction, but maybe something missed.
What I am doing.

Install react-native-map via yarn (it help to install for react-native@0.55.x
Download ios sdk zip 2.0.1 from https://developers.google.com/maps/documentation/ios-sdk/start and extract it in my temporarly folder.

question: what means the line $(SRCROOT)/Frameworks/Google-Maps-iOS-Utils in this step?

Open xcode, I have had already folder Frameworks and it contains libReact.a, so I added GoogleMaps.framework, GoogleMapsCore.framework and GoogleMapsBase.framework from unzipped ios sdk folder.

Drag this three frameworks to Embedded Binaries
question: What it means? I dont have a  folder Google-Maps-iOS-Utilsin xcodeFrameworks`.

Search Xcode Build Settings for "Header Paths" and add your new framwork folder from above:

$(SRCROOT)/Frameworks/Google-Maps-iOS-Utils

notice: I noticed, that after that, there were no changes in Build Phases/Compile Sources, it contains only main.m and AppDelegate.m.

Add AirMaps folder from node_modules/react-native-maps/lib/ios. I drag from finder to Frameworks folder in xcode. You could see it in left sidebar in above screenshot.

$(GITROOT)/node_modules/react-native-maps/lib/ios/AirGoogleMaps
$(GITROOT)/node_modules/react-native-maps/lib/ios/AirMaps

notice: In Build Phases/Compile Sources` there are a lot of files after step 4.

After that I was trying to build an ios app.

But I got an error:

I research a problem and found that this is a dependency from https://github.com/googlemaps/google-maps-ios-utils but I don`t have it. How I could install it?

This issue looks like a duplicate of https://github.com/react-community/react-native-maps/issues/2270.
I opened a PR at https://github.com/react-community/react-native-maps/pull/2310 which coincidentally appears to implement the same patch that @meylor came up with, please test it to see if it fixes this issue for y'all!
@radubatori The gradle 4 issue you mentioned sounds like it could be https://github.com/facebook/react-native/issues/16906

Hi, so is there a work around?  I saw a few mentions of removing AirGoogleMaps from AirMaps.xcodeproj.  What is the correct way to do this?  I assume I have to do it in xcode?  Thanks!

@billtlee
@radubatori suggested a workaround himself.
I automated it (for CI etc.) by having this in the package.json:
  "scripts": {
    "start": "node node_modules/react-native/local-cli/cli.js start",
    "test": "jest",
    "postinstall": "cross-os fix-maps"
  },
  "cross-os": {
    "fix-maps": {
      "darwin": "sed -i '' '/Google.*\\.[h|m]/d' node_modules/react-native-maps/lib/ios/AirMaps.xcodeproj/project.pbxproj"
    }
  },

and of course npm install -S cross-os
It basically removes all references to Google Maps in the faulty AirMaps.xcodeproj/project.pbxproj

@dj-hedgehog Thx!

@meylor the gist worked for me.
The project succeeded to build.
But It gives me error while archiving. Any suggestion?

#2396  was merged, please test with the latest git version.
Please keep in mind that you might have to setup the module again as now it works with react-native link
Read the install manual carefully

@dj-hedgehog worked ! thx !

Add pod 'GoogleMaps', '~> 2.7.0' and then pod install solves the problem

@nolan12345 it doesn't work

nothing has worked for me so far :(

authors: Freddy03h JCMais JulienCorb TheWrongAlice arichnad atkit billtlee dinukasal dj-hedgehog douglasjunior duro hamsddxn hlbp kidmysoul meylor mikemorris nolan12345 pushpendra65 radubatori rborn shide1989 tavriaforever zzimbler


text:
swipeable area

Hello.
Is it possible to specify the height of the swipeable area to close modals?

At the moment is it not, but PRs are welcome to support this feature :)

up

source: gharchive/issue

authors: Aleksandern rabanos-rvc rewieer

license: mit

license_type: permissive

license_source: bigquery


text:
Update dependencies

Overview
Update all dependencies except for the React Native related ones. We can't upgrade these because Detox only supports up to RN 0.58.
These upgrades should give us:

A bug fix to Detox so failing tests are reported as failures on CircleCI.
Updated semantic release support.
Everything else nice and up-to-date with the latest patches.

Test Plan
CircleCI should pass.

Man, you are on fire! :)

source: gharchive/pull-request

authors: bartolkaruza matt-oakes

license: MIT

license_source: github-api


text:
Naming collisions while building DependencyGraph

Hey,
I'm getting some naming collisions, seemingly because of the react-native dependencies fighting each other. Any ideas on how to solve this? React Native v. 0.17.0-rc.
Error building DependencyGraph:
 Error: Naming collision detected: /Users/[...]/Documents/[...]/[...]/node_modules/react-native-navbar/node_modules/react-native/node_modules/react-haste/test/reactComponentExpect.js collides with /Users/[...]/Documents/[...]/[...]/node_modules/react-native/node_modules/react-haste/test/reactComponentExpect.js
    at HasteMap._updateHasteMap (HasteMap.js:123:13)
    at HasteMap.js:94:28
    at tryCallOne (/Users/[...]/Documents/[...]/[...]/node_modules/react-native/node_modules/promise/lib/core.js:37:12)
    at /Users/[...]/Documents/[...]/[...]/node_modules/react-native/node_modules/promise/lib/core.js:103:15
    at flush (/Users/[...]/Documents/[...]/[...]/node_modules/react-native/node_modules/promise/node_modules/asap/raw.js:50:29)
    at doNTCallback0 (node.js:407:9)
    at process._tickCallback (node.js:336:13)

Duplicate of #116. @Kureev

And I thought I had been using npm3 for a long time... Nope! Thanks for the reminder as well :+1:

I'm using npm3 to install my node modules. But I'm still getting this unfamiliar error.
Failed to build DependencyGraph: @providesModule naming collision:
  Duplicate module name: UniversalWorkerNodeHandle
  Paths: /Users/[...]/Workspace/[...]/[...]/node_modules/react-native/Libraries/vendor/react/platformImplementations/universal/worker/UniversalWorkerNodeHandle.js collides with /Users/[...]/Workspace/[...]/[...]/node_modules/react-native-sliding-up-panel/node_modules/react-native/Libraries/vendor/react/platformImplementations/universal/worker/UniversalWorkerNodeHandle.js

This error is caused by a @providesModule declaration with the same name accross two different files.
Error: @providesModule naming collision:
  Duplicate module name: UniversalWorkerNodeHandle
  Paths: /Users/[...]/Workspace/[...]/[...]/node_modules/react-native/Libraries/vendor/react/platformImplementations/universal/worker/UniversalWorkerNodeHandle.js collides with /Users/[...]/Workspace/[...]/[...]/node_modules/react-native-sliding-up-panel/node_modules/react-native/Libraries/vendor/react/platformImplementations/universal/worker/UniversalWorkerNodeHandle.js

authors: andreasbhansen grabbou holyxiaoxin


text:
Unable To Play Local Files

hi I am trying Sample Example  In Android
With this  PlayList.json Its Working Good:
[
{
"id": "4444",
"url": "https://drive.google.com/uc?export=download&id=1V-c_WmanMA9i5BwfkmTs-605BQDsfyzC",
"title": "Rhythm City (Demo)",
"artist": "David Chavez",
"artwork": "https://picsum.photos/200"
}
]
When I try To Add Some Local File Path in the json And try To play Its Not Working...
[
{
"id": "2222",
"url": "file:///storage/emulated/0/Download/Selena_Gomez_-_Naturally.mp3",
"title": "Soul Searching (Demo)",
"artist": "David Chavez",
"artwork": "https://picsum.photos/200"
},
{
"id": "4444",
"url": "https://drive.google.com/uc?export=download&id=1V-c_WmanMA9i5BwfkmTs-605BQDsfyzC",
"title": "Rhythm City (Demo)",
"artist": "David Chavez",
"artwork": "https://picsum.photos/200"
}
]
I Enabled  Permissions.
Thanks In Advance...

Please, try the latest dev branch.

"react-native-track-player": "git+https://github.com/react-native-kit/react-native-track-player.git#dev"
Tried With this one no luck.... @Guichaguri

"react-native-track-player": "git://github.com/react-native-kit/react-native-track-player.git#dev"

And want from app's files folder.
file:///storage/emulated/0/Android/data/com.myproject/files/audios/myaudio.mp3
How??
I am doing by
url:"file:///storage/emulated/0/Android/data/com.myproject/files/audios/myaudio.mp3".

@imran1992  dev branch is  working try remove, node modules and android build folders from project and do npm i and build
and i guess  RNFB.fs.dirs.DocumentDir Will have '/' in its path give it a shot with
url:"file://" + RNFB.fs.dirs.DocumentDir + "/myaudio.mp3"

for me is not working, im using dev branch, and put file:// before my song name
results into this. file:///storage/emulated/0/DCIM/mysong.mp3
in Android Studio results on this
11-22 19:13:15.234 30016-30150/com.fancyplayer E/ExoPlayerImplInternal: Source error.
    com.google.android.exoplayer2.upstream.FileDataSource$FileDataSourceException: java.io.FileNotFoundException: : open failed: ENOENT (No such file or directory)
        at com.google.android.exoplayer2.upstream.FileDataSource.open(FileDataSource.java:73)
        at com.google.android.exoplayer2.upstream.DefaultDataSource.open(DefaultDataSource.java:249)
        at com.google.android.exoplayer2.upstream.StatsDataSource.open(StatsDataSource.java:83)
        at com.google.android.exoplayer2.source.ExtractorMediaPeriod$ExtractingLoadable.load(ExtractorMediaPeriod.java:885)
        at com.google.android.exoplayer2.upstream.Loader$LoadTask.run(Loader.java:379)
        at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1162)
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:636)
        at java.lang.Thread.run(Thread.java:784)

it says that my file doesn't exist, but that URL its comming from a native module

Damn, I couldn't get it to work on the iPhone simulator today. I added the file:// prefix. But nothing to do. I downloaded the file with react-native-fs, don't know if it's related.
The file is downloaded, so it's not coming from the fs library...
If any one has an idea, do not hesitate.
Thanks

There was a really old issue about local files that the fix was to change from file:// to file:/// (three slashes instead of two), I don't know if that would work, but you should try that.

Hey ! Thanks for answering. I found out where it came from, what I did was
launch the app from xcode with the simulator so I could track the issue.
And I found it came from the MediaURL in Swift.
Basically what I had to do was use encodeURI on my localUrl. I had already
done that for the distantUrl before.
Didn't think about it...
But now it's working.
Le lun. 26 nov. 2018 01:37, Guilherme Chaguri notifications@github.com a
écrit :

There was a really old issue about local files that the fix was to change
from file:// to file:/// (three slashes instead of two), I don't know if
that would work, but you should try that.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/react-native-kit/react-native-track-player/issues/344#issuecomment-441488717,
or mute the thread
https://github.com/notifications/unsubscribe-auth/Ae9ClDM76EkZ565eZXsWAEiKABLhW7Ogks5uyzexgaJpZM4YaTan
.

I also tried on Emulator but it doesn't work, it seems to work on a real device only

I also tried on Emulator but it doesn't work, it seems to work on a real device only

where to find the dev repo and how to put it in my project
thanks

FWIW, I spent a long time debugging the same issue, and for me, it came down to the player requiring a file extension. If your local file doesn't have a file extension, the player won't play the audio (and will silently fail without Event.PlaybackError).


text:
onPress events for subviews of Custom Marker

Question
Is there any option for handling onPress event for child control of Custom Markers ?
I'm building accordion widget on map so I need to detect on which row of opened custom widget was clicked.
<Marker onPress={() => { alert('I dont want this onPress. I want inner event') }} ...>
  <TouchableOpacity onPress={() => { alert ('Not triggering this event') }}
    <View style={{backgroundColor: "red", padding: 10}}>
      <Text>SF</Text>
    </View>
  </TouchableOpacity>
</Marker>

Please use this issue tracker for bug reports and features. Questions are better suited for Stack Overflow.
Thanks!

authors: christopherdro kmkrtich

repo: react-native-maps/react-native-maps


text:
Fix to allow installation on >=RN0.60.0

fix: allow project to be used with RN 0.60.0
Also providing updated install instructions
BREAKING CHANGE: You need to update React Native to work with this version

I think we are almost there, can you run npm install && npm run format and combine both commits?

@DanielMSchmidt @kirkryan currently we are experiencing these issues for RN > 0.60, and we can not build the android app. We think this PR could help with the issue. Could this PR be re-opened?

authors: DanielMSchmidt JesseKoper kirkryan


text:
Android blank screen

Video plays in Android but showing blank screen, i am able to hear audio.
In both media player and exo player , I am getting the same issue.

Can you test on master ? And give reproduction steps and / or a sample

can you please provide more informations:

Provide a sample stream or a sample application to reproduce the issue ?
clarify if this is a real revice or an emulator issue ?
Thank you

This one can reproduce in real device and emulators also

Sorry, I can't provide sample stream or an application and logcat output now.
I tested application at real device (HYBROAD tv box with AndroidTV 7.1.2 on board)

stale issue, let's close, no sample and no clue to understand the issue

authors: Brittognanaraj freeboub gizomo

repo: react-native-video/react-native-video


text:
Support for window.open with multiple windows, like a real browser

Hello, for a number of applications, we'd like to use window.open and properly have window.postMessage communication capabilities between the windows.
This ticket is related to https://github.com/react-native-webview/react-native-webview/issues/1111 and I am reopening.
[edit: previously I had offered a bounty for this ticket to be solved, however I've managed to find a work-around and this is no longer urgent, so the bounty has expired]

@pkieltyka are you trying to open popup window?

@krunaldarji yes, open a popup window which would also be a react-native-webview and then have window.postMessage work between windows -- https://developer.mozilla.org/en-US/docs/Web/API/Window/postMessage

btw, just to clarify my comment above -- the popup window (aka child window) does not have to be a "react-native-webview" window, it should just be of the same native-webview class on the respective platform, on iOS its WKWebview, and on Android its android.webkit.WebView.
I'm not super familiar with this repo's codebase or project -- but one idea / thought could be to polyfill / inject into both windows a new window.open() method on the parent side, and window.postMessage() on the child side. And then do messaging between those in the RN context.
On the apple-side of RNCWebview, there is https://github.com/react-native-webview/react-native-webview/blob/dd315bcf87d7bdbbcf7e63f9afa17c8f59b368bc/apple/RNCWebView.m#L196-L205 -- I imagine something similar on Android side.
Another idea could be to use https://github.com/react-native-webview/react-native-webview/blob/dd315bcf87d7bdbbcf7e63f9afa17c8f59b368bc/docs/Reference.md#onshouldstartloadwithrequest and return false to prevent the loading of this request, then instead open a new RNWebView window, and setup the window.postMessage() messaging. The window.open() method which is injected in the parent window would have to flag to the onshouldstartloadwithrequest method that the url being opened is called from window.open(..), as I believe this handler will also be triggered when someone clicks an anchor link.
.. anyways just some thoughts anyways if others are thinking about it. Feel free to ignore my implementation suggestions above as Im not a mobile dev expert or have enough time to get into the weeds but wanted to share some high level thoughts.
thank you :)

also.. to do bidirectional messaging you’ll have to support event listeners and postMessage on parent. But I do think can all be written to spec / standard of browsers and everything will interoperate and even can implement the usual security and domain checking. But transport would be just a class on RN side..

@pkieltyka were you able to resolve it ?

authors: krunaldarji nrajput05 pkieltyka


text:
further plugin refactoring

[x] move functionality of @react-page/create-plugin-materialui into core

the @react-page/create-plugin-materialui package allows you to create new plugins easily. in our project, most plugins are created with that package. it allows to create customizable content and layout plugins with very little configuration.
but it could be made obsoletewith some addtional refactorings:

[x] plugins always require Renderer instead of Component and optionaly Controls
[x] plugins can define a jsonSchema (like in @react-page/create-plugin-materialui)
[x] in edit mode (in ui) we should render always the Bottom toolbar when a cell is focused and render Controls inside of that. This would also streamline plugins to always use the BottomToolbar with aditional functionality
[x] when no Controls is defined, it uses the uniforms component which automatically generate the form
[x] custom controls might use schema and validator, similarly to the uniforms component
[x] custom controls have a streamlied api (data/onChange)
[x] refactor all plugins we provide to use this new api

:tada: This issue has been resolved in version 1.0.0-beta.15 :tada:
The release is available on:

v1.0.0-beta.15
GitHub release

Your semantic-release bot :package::rocket:

:tada: This issue has been resolved in version 1.0.0 :tada:
The release is available on:

v1.0.0
GitHub release

Your semantic-release bot :package::rocket:

repo: react-page/react-page


text:
Is it possible to add custom operators with custom evaluation functions?

Discussed in https://github.com/react-querybuilder/react-querybuilder/discussions/829

Originally posted by Lemour-sudo December 10, 2024
Is it possible to add custom operators with custom evaluation functions:
<QueryBuilder
    operators={[
        {
            name: 'strlen',
            label: 'strlen',
            value: 'strlen',
            evaluate: (value: string) => value.length,
        },
        {
            name: 'isOdd',
            label: 'isEven',
            value: 'strlen',
            evaluate: (value: number) => value % 2 === 0,
        },
    ]}
    fields={fields}
    query={query}
    onQueryChange={setQuery}
/>
```</div>

https://github.com/react-querybuilder/react-querybuilder/discussions/829

repo: react-querybuilder/react-querybuilder


text:
Unique not working with autocomplete

When I enabled autocomplete I was able to add the same tag multiple times by pressing the delimiter. Picking from the list still seems to work. I'm on version 6.6.1.

@Blackpinned it works fine in example, can you share a stackblitz example?

Autocomplete wasn't enabled in the example. I enabled it and pressing "," allowed me to put Thailand in twice.
https://stackblitz.com/edit/react-tag-input-r58jud?file=index.js

Added an image since I never used stackblitz before.

@Blackpinned yeah, I can reproduce it now.

:tada: This issue has been resolved in version 6.7.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

repo: react-tags/react-tags


text:
Slider rendered incorrectly

Hi, Slider looks completely wrong when there are floating elements nearby. This happens only for non-editable sliders. To reproduce:
import Slider from 'react-toolbox/lib/slider';

 class SliderTest extends React.Component {
  state = {
  	slider1: 12,
    slider2: 5,
    slider3: 1
  };

  handleChange = (slider, value) => {
    const newState = {};
    newState[slider] = value;
    this.setState(newState);
  };

  render () {
    return (

Normal slider

        <Slider value={this.state.slider1} onChange={this.handleChange.bind(this, 'slider1')} />

With steps, initial value and editable

        <Slider min={0} max={10} editable value={this.state.slider2} onChange={this.handleChange.bind(this, 'slider2')} />

Pinned and with snaps

        <Slider pinned snaps min={0} max={10} step={1} editable value={this.state.slider3} onChange={this.handleChange.bind(this, 'slider3')} />

    );
  }
}

return <SliderTest />;

Thanks for reporting. Actually I don't see this as a problem but as an expected behavior... If you want to put a label next to the slider then you just have to make the slider float to the right and clear the space. It will work that way. If you guys think this should be considered a bug, please reopen.
Thanks!

I don't think it's as simple as that. This issue will happen if Slider is deep inside a floating container next to another floating container. If this behaviour is expected, that means Slider can't be used in complex floating layouts.

Following the screenshot you just sent, I think there should be no problem if you enclose your form in a div and make it float to the right, clearing the space in a parent container.

    .....

Try this:
class SliderTest extends React.Component {
  state = {
    slider1: 12,
    slider2: 5,
    slider3: 1
  };

  handleChange = (slider, value) => {
    const newState = {};
    newState[slider] = value;
    this.setState(newState);
  };

  render () {
    return (

Float

Normal slider

	        <Slider value={this.state.slider1} onChange={this.handleChange.bind(this, 'slider1')} />

With steps, initial value and editable

	        <Slider min={0} max={10} editable value={this.state.slider2} onChange={this.handleChange.bind(this, 'slider2')} />

Pinned and with snaps

	        <Slider pinned snaps min={0} max={10} step={1} editable value={this.state.slider3} onChange={this.handleChange.bind(this, 'slider3')} />

    );
  }
}

return <SliderTest />;

I think this could be fixed by giving .innerprogress the attribute left: 0

#524

authors: Valentin-Seehausen javivelasco nocon

repo: react-toolbox/react-toolbox


text:
"support paypal" link on react-toolbox.com doesn't work

I get redirected to my account home.

hahaha.. funny.. for that reason maybe our account is 0 ;)

In Bratislava is not enabled and I couldn't verify :(
Now it's fixed, many thanks for reporting it!!

Hopefully your account balance is fixed now, too. :)

Hahaha hopefully :dancer:
Thanks @alltom :)

authors: alltom javivelasco soyjavi


text:
Hide columns header row

I have table without header of columns. How to hide empty header div in my table?

This looks to be a question of implemention. Please repost this question on our support community:

repo: react-tools/react-table


text:
fix: update packages to fix issues with build

Resolves https://github.com/reactioncommerce/reaction/issues/5460 (maybe?)
Impact: critical
Type: bugfix
Component

Update various babel packages
Update husky and commitlint because I couldn't commit. (the hook failed and prevented committing)

Breaking changes

Updated babel versions should mean that other projects that use this library should update their various babel packages to the latest versions. For example below

devDependencies
    "@babel/cli": "~7.5.5",
    "@babel/core": "~7.5.5",
    "@babel/node": "~7.5.5",
    "@babel/plugin-proposal-class-properties": "~7.5.5",
    "@babel/plugin-proposal-decorators": "~7.4.4",
    "@babel/plugin-proposal-export-namespace-from": "~7.2.0",
    "@babel/plugin-proposal-function-sent": "~7.2.0",
    "@babel/plugin-proposal-json-strings": "~7.2.0",
    "@babel/plugin-proposal-numeric-separator": "~7.2.0",
    "@babel/plugin-proposal-throw-expressions": "~7.2.0",
    "@babel/plugin-syntax-dynamic-import": "~7.2.0",
    "@babel/plugin-syntax-import-meta": "~7.2.0",
    "@babel/plugin-transform-runtime": "~7.5.5",
    "@babel/preset-env": "~7.5.5",
    "@babel/preset-react": "~7.0.0",

Testing

Build should pass
Docs should render and all components should work. Most specifically the Select component and that's the single component causing all the issues...
npm link or otherwise link the built package to a project and verify that the app still runs and places where the Select component is used, are functioning correctly.

Checkout address form on example-storefront
Tags admin in the Reaction admin

🚀 Preview deployed
Built with commit 5cfa05cbe4abf8fdb4ac44832f254aca3847709b
https://deploy-preview-435--stoic-hodgkin-c0179e.netlify.com

:tada: This PR is included in version 0.67.2 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

authors: mikemurray rc-publisher


text:
Add hidden/unused parameters as document objects/properties

Allowing unused parameters in the formatted message to be added as objects in the document submitted to Elasticsearch. For example:
Logger.Error("Error message {0}", p1, new [] {"object key", "object value"})
In the above example the third parameter is unused for formatting, but it is in a form that can be converted to a document entry for ElasticSearch. With this change it will be added as an object to the root document submitted to the ElasticSearch target. The accepted object types are: string[], KeyValuePair<string, object>, and Dictionary<string, object>. In the case of string[] the first two items are used to make the object.
This feature is very valuable in my use cases. The processing and inclusion of additional data is light weight and simple while keeping the message sent to other NLog targets clean.

@lrickard You could also just add your own extension method for NLog-Logger, that can inject custom properties into the NLog LogEventInfo.Properties-Dictionary ?

void Info(Dictionary<string,object> extraProperties, string messageTemplate, params object[])

@snakefoot, thanks. I tried a couple approaches in an extension method but they had unintended side effects on other targets or were disappointing in some other way. I think I could create an asynchronous log event and log to the elastic target differently than my other targets (with the additional properties), but this would make logging to a file more burdensome and wouldn't be as elegant in my eyes. I doubt my implementation is perfect, but I think this logic belongs in the target itself.

@lrickard Maybe just change the PR into making it easy for you to inherit from this target, and override a method to inject your custom magic logic for adding extra properties?
No offense but your code might work for your case, but will probably create a lot of side-effects for everyone else.

@snakefoot That's an interesting idea, but I can't think of any way that maintaining a child class would be any easier than just maintaining my fork. (I could be wrong).
No offense taken regarding a concern for side effects, they are important. While this change isn't perfect, neither is this target's current functionality. One could argue that if others are using hidden parameters to create functionality in their target that this would have effects on them. This is true, but the same could be said about using the structured logging for creating the ElasticSearch document in the first place, right? I'm very interested in the side-effects you are concerned with, if you would care to elaborate.
My main goal with this change is this: Allow additional data to be added to the ElasticSearch document, and not the message to other targets, while still allowing users to use structured logging in the same function call. I've experimented with oodles of different extension methods and C# functionalities, but they've all fallen short in this goal. (I still have hope and will continue to waste time trying)
This change isn't the most elegant ever (it would be sweet if it just worked with ValueTuples), but it does meet this goal and it seems to have amicable performance implications.

@lrickard Well if you don't mind maintaining your own custom fork. Then I guess this PR can be closed:)
You could also inject your custom data into the Exception-Data-Dictionary, if looking for random places to inject your random data  :)
Anyway not my decision, since I don't maintain this target. Just find your requirement strange, and abusing a quirk to fix it is a bad road.

@snakefoot I think it would be best if my change could be improved and this functionality could be included for those who might need it. One improvement I just thought of is to simply make it an option that is configurable and off by default. That said, I see where you are coming from. I can't sure how popular such a feature would be. I hope I haven't bothered you too much with this PR, but I don't see my code as abuse.
Reading this makes me think the ability to use of these extra parameter is a deliberate inclusion.
You might be right that there is another way of getting metadata into my logs, but I don't think I can get it dynamically from log lines with what you have outlined. Also, I do care about performance and I have thought of a way of optimizing the code in this PR. I think it would improve the O(n) efficiency of my code to check keys in the document when inserting instead of whether the value exists in the properties.

@lrickard I hope I haven't bothered you too much with this PR

Usually a good library ensures the basic stuff works really well. But is extensible enough so it is possible for users to add their own exciting stuff.
Have seen a lot of libraries becoming swiss-army-knifes over time that become very hard to maintain, and everything suddenly becomes breaking changes. NLog is a good example of this.

authors: lrickard snakefoot


text:
Tag a release

We have many changes in master since 2.3.1

While I'm not arguing against a release, we only have a small handful of changed in master currently.
https://github.com/reactiveops/pentagon/blob/master/CHANGELOG.md
I'd like to cut a release in the next couple weeks once:
https://github.com/reactiveops/pentagon/pull/131
https://github.com/reactiveops/pentagon/pull/120
Land.
#120 is going to take some more discussion before that is ready to see more work.

authors: ejether geojaz

repo: reactiveops/pentagon


text:
Server-side i18n

Any suggestions on how to do this? Is there a suggested framework for integrating i18n? If I was using Razor it would be something like R.SomeResource.
Currently I'm passing the required resources to @Html.React as props, but this is not ideal as it looks messy.

Sorry, I'm not too sure, I don't have much experience with i18n in JavaScript. This seems like a broader question though, rather than something specific to ReactJS.NET. Perhaps ask on StackOverflow? :)

@deevus Consider checking these out:
https://github.com/yahoo/react-intl
https://github.com/mashpie/i18n-node
https://github.com/jeresig/i18n-node-2

I'm using https://github.com/jquery/globalize.
Preparation
2 gulp tasks is required to generate the files for React.NET to consume

Pass the runtime modules through browserify
For each locale, pass the formatters, parsers etc through globalize-compiler

The generated files from the gulp tasks are included in both React config and layout.cshtml.
Usage
Within the jsx files, use the Globalize.formatMessage to localize strings
Setting language
In layout.cshtml, set the language by adding a script tag and calling Globalize.locale("the locale")
Create a custom HtmlHelperExtension that runs Globalize.locale("the locale") on the current ReactEnvironment before calling Html.React

Closing issues older than a year, please re-open if you think this is still relevant.


text:
Referencing values with refs

This PR might be broken into other parts if the page is too long!

So, I have decided to make some buttons in Bangla. Maybe there could be more changes, but I only limited the translation to what the page needed for the time being. As far as I have seen, making the whole page Bangla could look really nice. So, that is going to be a thing to decide. Like 'download', 'fork'...everything. Again the PR has gone a bit large. So, take your time and make change requests as much as you can.
@moshfiqrony  @nomandhoni-cs

Thanks @nafistiham bhai. Reviews will be done by tomorrow early evening.

@moshfiqrony vai. Thanks. Fixed the PR with your help!

authors: moshfiqrony nafistiham


text:
Consider to make the new role dialog optional

The new role dialog merged in #223 is a nice addiction but worth noting it's not just about semantics. A role="dialog" directly impacts the way screen readers behave, making them enter in a sort-of application mode.
It's a TL;DR and bit difficult to explain :) but basically, with the exception of VoiceOver that uses a different interaction model, screen readers will enter in a mode where they read out just the focusable content. Will post some references below to try to better explain.
The specification states:
https://www.w3.org/TR/wai-aria-practices-1.1/#dialog_modal

A dialog is a small application window that sits above the application and is designed to interrupt the current processing of an application in order to prompt the user to enter information or require a response

That's to say it assumes to have some interactive content, like a form or some buttons, exactly like in the desktop system dialogs. In this case the role dialog is perfectly appropriate. But that's not the reality and, often, modal dialogs on the web are used for long blocks of text and no interactive content. In this case, the role dialog can be a problem since screen readers in application mode don't allow to navigate content using the arrow keys.
So it's all about the type (or prevalent type) of content. This should probably be an authors decision or maybe they should be able to indicate if the content is mostly interactive or not.
Some of the main experts in a11y suggest to don't use role dialog at all. Considering react-modal already hides the background content using aria-hidden that could be an option.
This thread on webaim.org on this topic is very interesting, I'd recommend to focus on what Mr. Bryan Garaventa and Mr. Steve Faulkner posted there:
http://webaim.org/discussion/mail_thread?thread=5664

ARIA modal dialogs only read out focusable items

There are other options, like setting back the modal dialog content to role="document" but this seems to cause other issues. All in all I guess the simpler solution would be making role dialog optional, for use by well educated authors (hopefully).
Other references:
http://www.deque.com/blog/aria-modal-alert-dialogs-a11y-support-series-part-2/
In a normal role=”dialog” or “alertdialog” NVDA will go into Forms Mode when focus is sent into the dialog.

Forms Mode means NVDA users an only tab around the dialog. They can’t press the up/down arrow keys to read through the dialog with linear navigation...

https://labs.ssbbartgroup.com/index.php/ARIA_Dialog

Regarding web app behavior on Windows, specific to the use of role=dialog, it causes screen readers like JAWS and NVDA to activate Applications Mode...

@afercia Thanks so much for the very insightful issue.  I'm going to send a commit in now that will just allow you to pass in the dialog prop and let that be used.  So it won't do it by default, but will instead allow you to specify it if you want.
It's been a while since this library was created, but I do recall the issues with dialog back then.  We purposefully didn't use it.  Curse my human memory.  So this new commit should make it so that people can use it if they want, but won't be forced to do so.

authors: afercia claydiffrient

repo: reactjs/react-modal


text:
Cannot run tests in PhantomJS

Summary:
When running tests using PhantomJS, I'm getting a SyntaxError. Please see the attached screenshots.
This started to happen after upgrading to version 1.7.0
Additional notes:

@nancruz hi, this seems related to #336.

@diasbruno you are right. I'm going to close this issue

authors: diasbruno nancruz


text:
withRouter--- whthin routerWillLeave function can not access this

import React, {Component} from 'react';
import {withRouter} from 'react-router';

class ReactRouter02 extends Component {
    state = {
        isSaved: false
    }
    componentDidMount() {
        this.props.router.setRouteLeaveHook(
            this.props.route,
            this.routerWillLeave
        )
    }

    routerWillLeave(nextLocation) {
        // return false to prevent a transition w/o prompting the user,
        // or return a string to allow the user to decide:
        if (!this.state.isSaved) {
            return 'Your work is not saved! Are you sure you want to leave?'
        }
    }

    render() {
        return (

离开路径时，弹出提示

        );
    }
}

export default withRouter(ReactRouter02);

within routerWillLeave function, give me this:
Uncaught TypeError: Cannot read property 'isSaved' of undefined

and I debugger this, here is the debugger

My react-router version is 2.4.1

You need to bind the function yourself.

Thanks for reply!
I did like this:
componentDidMount() {
        const scope = this;
        this.props.router.setRouteLeaveHook(
            this.props.route,
            scope.routerWillLeave
        )
    }

save this to scope, but still not work.
And, I bind this, it work~
constructor(props) {
        super(props);
        this.routerWillLeave = this.routerWillLeave.bind(this);
    }

why saved this to scope not work?

authors: mrdulin taion

repo: reactjs/react-router


text:
Update startTransition.md

In the context of a function invocation, I believe it'd be more relevant to say that a function or a callback was called with no or some arguments instead of parameters

@gaearon @Huxpro @sophiebits Could you kindly review my changes?

LGTM ;)

authors: Huxpro prajwalkulkarni


text:
Update react-devtools URL

@jamesbaskerville thank you!


text:
translate file structure page

Thanks for the translation. Merging it...

authors: alioguzhan umutcanbolat


text:
🛑 Bellshade Website is down

In 0b800c4, Bellshade Website (https://bellshade.org) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Bellshade Website is back up in 6c3e06c after 12 minutes.


text:
Support legacy PHP 5.3 through PHP 7.1 and HHVM

Refs https://github.com/reactphp/dns/pull/56

Why support non-supported versions of PHP?

@mdrost While I understand your concerns, this discussion is not relevant to this ticket, as this merely documents the supported versions and does not change any existing code :+1:

authors: clue mdrost

repo: reactphp/stream


text:
Cannot bundle 'reactstrap' by 'browserify' because of 'reactstrap-tether'

Thanks for providing this awesome package which made my development much easier.
I got an issue related to 'reactstrap-tether'. I've also added a comment in https://github.com/HubSpot/tether/pull/175
It is caused by the tether.js forked in 'reactstrap-tether'.
Basically this tether.js will block browserify from bundling 'reactstrap', there will be an error:
Error: Cannot find module './utils' from .....

The workaround is ignore 'reactstrap-tether' from the bundling.
bundle.ignore('reactstrap-tether');
//or command line
browserify -i reactstrap-tether ....

But the result will not have ToolTip or other components which used 'tether'.
It seems the webpack or 'create-react-app' could work with current 'reactstrap' setup without any issue.
I think it would be nice to let 'browserify' finish its job properly.
BTW, directly include './node_modules/reactstrap-tether/src/js/tether' won't work.
The 'import' and 'export' keyword will cause trouble. User must provide preset such as es2015.
Is it better to avoid using 'import/export' and keep the minimal dependency?
#438

yeah can't use reactstrap because of this. Any update would be appreciated.

+1

+1

Given that Bootstrap has dropped tether in favor of popper.js, I wonder if we could make a release that makes this change to drop reactstrap-tether as a dependency

reactstrap is working on making the change from tether to popper.js as well. See: https://github.com/reactstrap/reactstrap/issues/487#issuecomment-324473298

authors: MarkRich TheSharpieOne fantasydr und0ck3d zekedroid

repo: reactstrap/reactstrap


text:
fix: migrating magic block tables with breaks

Ref CX-1112

🧰 Changes
Fixes breaks in magic block tables.
🧬 QA & Testing

Broken on production.
Working in this PR app.

This PR was released!
🚀 Changes included in v7.6.2

authors: kellyjosephprice rafegoldberg

repo: readmeio/markdown

license: ISC


text:
fix: Replace IE11 incompatible DOM features

Closes #360
This PR replaces Element.prototype.closest and Element.prototype.remove by their ponyfilled versions. These methods aren't automatically polyfilled by Babel on apps. So, with this, Reakit should work with IE11 by simply using Babel (production build).
Does this PR introduce a breaking change?
No

Codecov Report

Merging #443 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master    #443      +/-   ##
=========================================
+ Coverage   95.29%   95.3%   +<.01%
=========================================
  Files          94      94
  Lines        1424    1427       +3
  Branches      445     446       +1
=========================================
+ Hits         1357    1360       +3
  Misses         67      67

Impacted Files
Coverage Δ

packages/reakit/src/Menu/__utils/useShortcuts.ts
96.96% <100%> (ø)
:arrow_up:

packages/reakit/src/Dialog/__utils/usePortalRef.ts
100% <100%> (ø)
:arrow_up:

packages/reakit/src/Dialog/__utils/useFocusTrap.ts
97.01% <100%> (+0.13%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e9bc21...c1f4b95. Read the comment docs.

authors: codecov-io diegohaz

repo: reakit/reakit


text:
Support write advise / read advised nukleus:flush

Blocked-By: https://github.com/k3po/k3po/issues/472
Supports sending and receiving FLUSH frame with optional extension metadata.

Fixed by https://github.com/reaktivity/reaktor.java/commit/4e574ee43a2859159a9f003e9830c857d14aba4c.


text:
Explain item crafting in README

We should explain how to craft the item in How to use section of README.

Let's do this in readme branch, and then we can review and merge to master.

Air horn crafting is currently not implemented.

repo: real-coco-labs/pz-airhorn


text:
apply doesn't consider cluster defaults when settings are changed

Example case:
Cluster default retention is 100ms
Create topic with retention of 50ms (ex. via esque apply)
Specify no retention for this topic in a config
Change the topic based on the config with esque apply

Expected: esque apply shows the change as "50ms -> 100ms" and applies this correctly when confirming
Actual: esque apply doesn't show the change. Not sure if it's applied correctly.
Notes:
This relates to the fact that we ignore None values for the new changes in AttributeDiffs. Instead, we should treat None values as ClusterDefault for this setting.
If we simply show the None, we'd get a diff for EVERYTHING that we haven't specified.
To solve, we need to do the following in the case that the new value is None: IF old_val IS NOT cluster_default THEN show change as old_val -> cluster_default and IF old_val IS cluster_default THEN show no change.
Open questions:
How do we get the cluster defaults?
What happens if we submit a None setting to the client when we change a topic? Will it revert to the cluster default? I'd assume yes, but this should also be tested (ideally as part of the test suite, I don't trust any of the clients to not have regressions on this at some point).

Additional note: If it turns out that submitting a value of None for a configuration property causes the property to be automatically set to cluster default, we don't necessarily need to know the cluster defaults. Instead, we could store all changes in a topic as mentioned in #22 and use that info to decide whether we need to change something.

repo: real-digital/esque


text:
🛑 Hacker News is down

In 211b232, Hacker News (https://news.ycombinator.com) was down:

HTTP code: 502
Response time: 88 ms

Resolved: Hacker News is back up in f819470 after 8 minutes.

repo: realewie/uptime


text:
Realm Object With Primary Key or without primary key, better performance.

I have two classes Folders and MathSolutions. One to Many relationship. Please suggest me which method is good to develop whether having the id defined as a primary key, keep the refence in the another class. OR apply object mapping ?

Your question is quite vague. Is this the type of schema you're looking for?
class Folder: Object {
  let solutions = List<MathSolution>()
}
class MathSolution: Object {
  dynamic var content = "<insert content of solution here>"
}

This will allow Folders to contain many MathSolutions.

Hoping that my last comment helped you @Piraban. Feel free to reopen this issue if you have any further comments or questions you'd like us to address.

authors: Piraban jpsim

repo: realm/realm-cocoa


text:
Improve docs on usage on background thread

We still see a lot of people running into problems with users pinning Realms when using them on background threads, with a bloating of the file size as result.
Wo mention in the documentation that they should call refresh() regularly to avoid pinning, but that still leaves a risk of having Realm objects hanging around not being refreshed while the thread is blocked doing work or just inactive.
We should improve the docs to show examples of more robust ways to deal with realms on background threads, whether that is by recommending the use of explicit runloops or patterns for closing the realm when not in active use.
@andkon

@jpsim, it'd be really nice to have a pattern/anti-pattern. Our devs are debating what this paragraph actually means:

Realm read transaction lifetimes are tied to the memory lifetime of Realm instances. Avoid “pinning” old Realm transactions by using auto-refreshing Realms and wrapping all use of Realm APIs from background threads in explicit autorelease pools.

Reference: https://realm.io/docs/swift/latest/#file-size-and-tracking-of-intermediate-versions

Anti-pattern:
DispatchQueue(label: "bg").async {
  _ = try! Realm()
  // ^ no autoreleasepool, ARC won't release right away (or ever), Realm won't know how long it needs to keep the data at this version around for you to access
}
let realm = try! Realm()
try! realm.write { /**/ }
try! realm.write { /**/ }
// lots of writes, Realm is advancing, maybe deleting data...
try! realm.write { /**/ }

Better pattern:
DispatchQueue(label: "bg").async {
  autoreleasepool {
    _ = try! Realm()
  }
  // ^ explicit autoreleasepool, ARC guarantees that the `Realm` instance will be released by the end of its scope, meaning that Realm knows you don't need the data at that version anymore, so it can mark it as "free space" in the file
}
let realm = try! Realm()
try! realm.write { /**/ }
try! realm.write { /**/ }
// lots of writes, Realm is advancing, maybe deleting data...
try! realm.write { /**/ }

authors: astigsen jpsim semireg


text:
error: 'Realm/RLMRealm_Private.h' file not found

How frequently does the bug occur?
Always
Description
Having updated to 10.37 can no longer build our app, see log below.
Issue does not occur with 10.36 or earlier.
Stacktrace & log output
<module-includes>:45:9: note: in file included from <module-includes>:45:
#import "RLMAsyncTask_Private.h"
        ^
../Pods/Headers/Private/Realm/RLMAsyncTask_Private.h:21:9: error: 'Realm/RLMRealm_Private.h' file not found
#import <Realm/RLMRealm_Private.h>
        ^
../Pods/RealmSwift/RealmSwift/Aliases.swift:20:8: error: could not build Objective-C module 'Realm'
import Realm.Swift
       ^

Can you reproduce the bug?
Always
Reproduction Steps
This may be specific to our app, so at this time can't provide you with reproduction steps.
Version
10.37
What Atlas Services are you using?
Local Database only
Are you using encryption?
Yes
Platform OS and version(s)
Build issue
Build environment
Xcode version: Xcode 14.2 (14C18).
Dependency manager and version: CocoaPods 1.11.3

Hi @mark-urbanthings can you please do a clean cocoapods install, use pod deintegrate, remove your Podfile.lock and try again to pod install again. Clean your project derived data folder as well and try again.
If you are still having issues, can you please attach your Podfile and check also check if this files are within the private header phase for the Realm target in the pods project, if not clearly something is going wrong with the cocoapods installation.

Hi @dianaafanador3,
I've tried the above steps with no success. Our project has complex dependencies where we are publishing our own libraries to private pod repo and integrating these alongside public pods.
I've however managed to reproduce the issue with a much cut down test project. Issue seems to be tied to having an abstract project into which we include both Realm and our own library of Realm functionality (UTRealm). The development pod in attached zip of the project is again cut down representation of our UTRealm pod but is enough to reproduce the issue.
Regards
Mark
BuildIssue.zip

Same problem to me at version 10.37

@MunokKim are you using abstract_target as well?

@mark-urbanthings Sorry I don't understand about abstract_target

@MunokKim in your Podfile (see here). If you can post your Podfile here it may help diagnosing issue.

Added a PR https://github.com/realm/realm-swift/pull/8168 which may help solve this issue.

@dianaafanador3 integrating from your PR branch fixes issue for our app as well as the test project.

Running into the same build error and #8168 indeed resolves it for me!

try   needDynamicFramework = Array['RealmSwift', 'Realm']
pre_install do |installer|
installer.pod_targets.each do |pod|
if needDynamicFramework.include?(pod.name)
def pod.build_type;
Pod::BuildType.dynamic_framework
end
end
end
end

I have also encountered this problem, how to solve it

Fixed on version v10.41.0

authors: MunokKim dianaafanador3 maopenglin mark-urbanthings rpander93 wangxue-holla

repo: realm/realm-swift


text:
关于分区最新回复的时间问题

多次看到这个最新回复时间是负数的情况了。。。

之前都下意识再刷新就没了，这次可我算是逮到录下来的机会了（

今天用app聊了一下午的天，这种情况看到好几次了
ps：用起来是真的爽，比官方app强太多了

这个是老问题，服务器那边时钟有误差，随着运行时间越长误差也会越大，去年年末服务器曾重启过一次，重启之前的误差是八分钟，现在也有一些误差了。
后面只能掩耳盗铃，把负数时间显示成0秒前，没办法彻底解决。

这个是老问题，服务器那边时钟有误差，随着运行时间越长误差也会越大，去年年末服务器曾重启过一次，重启之前的误差是八分钟，现在也有一些误差了。
后面只能掩耳盗铃，把负数时间显示成0秒前，没办法彻底解决。

那只能掩耳盗铃了。。。。。确实这种问题app没法彻底修好。。


text:
[module.mdx] Remove open syntax sugar exemple

Open's syntax sugar is valid in reason, but not in rescript. Related to #26.

Thanks.

I am curious to know why this syntax was dismissed from rescript.

authors: chenglou henriklundgren marcagba


text:
compile ignores the -j flag

Running DEBUG=1 rebar3 compile -j 1 outputs ===> Starting 3 compile worker(s) while building. Which might point out that rebar is actually ignoring the -j flag
Rebar3 wtf report
 version 3.0.0-alpha
 generated at 2015-03-12T14:12:40+00:00
=================
Please submit this along with your issue at https://github.com/rebar/rebar3/issues (and feel free to edit out private information, if any)
-----------------
Task:
Entered as:

-----------------
Operating System: x86_64-apple-darwin14.1.0
ERTS: Erlang/OTP 17 [erts-6.3.1] [source] [64-bit] [smp:4:4] [async-threads:0] [hipe] [kernel-poll:false] [dtrace]
Root Directory: /usr/local/Cellar/erlang/17.4.1/lib/erlang
Library directory: /usr/local/Cellar/erlang/17.4.1/lib/erlang/lib
-----------------
Loaded Applications:
[{inets,"INETS  CXC 138 49","5.10.5"},
 {ssl,"Erlang/OTP SSL application","5.3.8"},
 {public_key,"Public key infrastructure","0.22.1"},
 {asn1,"The Erlang ASN1 compiler version 3.0.3","3.0.3"},
 {crypto,"CRYPTO","3.4.2"},
 {stdlib,"ERTS  CXC 138 10","2.3"},
 {kernel,"ERTS  CXC 138 10","3.1"}]
-----------------
Escript path: XXXXXXXXXXXXXXXXXXXXXXXXXXXX
Providers:
  app_discovery as clean compile compile cover ct deps dialyzer do edoc escriptize eunit help install_deps lock new pkgs release shell tar update upgrade version wtf xref

Should be fixed in #262

authors: asabil ferd


text:
Upgrade relx and add relup provider

Fix #518 and #538

+1, merge when tests clear

authors: ferd tsloughter


text:
Reduce dependency by using Java instead of kotlin

RT.

Progress:

[ ] common
[ ] rec-accessor
[x] rec-app
[ ] rec-core
[ ] rec-initializer
[x] rec-scripting
[x] rec-sepval

For test, see #8

repo: rec-jvm/rec-core


text:
Beta 1 flagged by Antivirus.

Description
Beta 1 was flagged by antivirus AVIRA and put on quarantine.
says it is infected with ...
"Drop.Win64.LocalAppSelfRun.21014"
kindly submit the build to them so they stop flagging it.
thanks
Reproduction steps
No response
Image file
No response
Version
1.3.4
OS
Windows
Tool
A1111's webUI

just recalling Github system wide infections in recent months, could this be related to github injecting something in builds rather than devs doing something wrong?

I will update the library that causes false positives to the latest version in beta2, hoping this can solve the problem.

beta2 is here! Hope AVIRA likes it.
https://github.com/receyuki/stable-diffusion-prompt-reader/releases/tag/v1.3.5-beta.2

authors: danrazor receyuki

repo: receyuki/stable-diffusion-prompt-reader


text:
Refactor serializers into separate classes, and add JSON and BSON serializers

Continued from #265. Closes #244, #274, #276, and updates #283.

Refactor serializers into separate classes
Add a BaseSerializer class that uses cattrs to do most of the common (de)serialization steps
Add a JSON serializer
Add a BSON serializer
Allow selecting a serializer by name, class, or instance (with same behavior as selecting backends)
Allow using a custom serializer by subclassing BaseSerializer (with roughly the same pattern as making custom backends by subclassing BaseCache)
Add relevant package extras to install optional dependencies
Fix some python 3.8 compatibility issues

Coverage decreased (-1.02%) to 98.013% when pulling ce3cce7e59c9c8d82953e8c399f1d20aaeb04794 on JWCook:json-serializer into 766b1f792f1d9917940eb38febfab750dee6a0f1 on reclosedev:master.

Hey! I started writing out my thoughts on #283, but realized it made more sense here.
One more idea worth circulating before we go to implement #244 / #275. What if we got rid of serializers altogether? That is, I think I'm starting to smell some Yak Shaving.
Put another way, there's a whole bunch of classes that have methods to go forwards or backwards, in some sense. E.g.:

class
forward
backward

pickle
dumps
loads

gzip / zlib / bz2 / lzma
compress
decompress

codecs.[anything]
encode
decode

itsdangerous.Signer
sign
unsign

itsdangerous.serializer.Serializer
dumps
loads

cryptography.fernet.Fernet
encrypt
decrypt

cattrs.preconf.[ujson|bson|json]
unstructure
structure

Any sequence of these (or other similar classes) that starts from a python class representation, and ends in a format supported by a backend, is a perfectly valid way of doing serialization. The serialization classes seem to, at root, just be aliasing the appropriate method for these classes, and collecting all the initialization parameters in a single class. And our proposed mixin system bakes that into a difficult-to-understand class hierarchy.
So rather than write new classes to encapsulate that functionality, why don't we just use them in the raw? For example, what if this worked?
import gzip, codecs
from itsdangerous.serializer import Serializer as IDSerializer
from itsdangerous import Signer
from cattrs import preconf
import requests_cache

json_serializer = catters.preconf.ujson.make_converter()
code_signer = IDSerializer('secret-key')

session = requests_cache.Session(serializer=[json_serializer, code_signer, codecs.utf_8, gzip])

This would work if the BaseCache class took as serializer a list of classes that would serve as the serialization pipeline. To serialize, it would work through the list in order, calling the dumps / encode / compress / sign / encrypt / unstructure methods of the classes (essentially looking for the first method that was valid for the class), and then passing it on to the next stage in the pipeline. To avoid a performance hit, you could memoize the list of valid methods the first time through, and then just run the memoized pipeline.
Alternatively, the dumps / loads terminology is nice and clear in terms of what is going on. So alternatively, the BaseCache could just call those methods and be done. If there was a class that didn't support it, you could write a wrapper class that aliased the appropriate methods to dumps / loads. E.g.:
from itsdangerous import Signer

class IDSerializer(Signer):
    def dumps(self, obj):
        return self.sign(obj)

    def loads(self, obj):
        return self.unsign(obj)

In the end, I think this would allow for a lot of customizability / extensibility with little testing or code overhead. Instead, that would all be replaced with some common-sense docs for how to build a serializer pipeline.
Thoughts?

@parkerhancock
Yeah, I see where you're going with that. Good thinking! From a user's perspective, I do like having the option to pass a list of steps instead of making subclasses or mixins. Seems more pythonic.
I would prefer to be a bit more explicit than assuming each step has one and only one of the methods in that list. That could be problematic when passing a module, which could have members with multiple names from that list. What would you think of a make_serializer() function that generates a serializer object from a list of:

Anything with dumps and loads methods
A dict that maps the equivalent functions to use, for example:{'loads': gzip.compress, 'dumps': gzip.decompress}

Or maybe tuples instead of dicts? I'm open to other ideas there.

Internally, I still like having the built-in serializers as classes for a couple reasons:

Being able to modify the cattrs converter, which is what does the majority of the work. In the example of JSON, it's not immediately obvious that you need an additional step of encoding the response body, which is what cattr.preconf.(u)json.make_converter does. That's partly why I wanted to make that a built-in feature, so users wouldn't have to figure out how cattrs works, and make it usable with CachedSession(serializer='json').
Backend classes need to know if serialized objects are expected to be bytes or strings, since some of them have specific datatypes to handle bytes (like sqlite3.Binary). Being able to check self.serializer.is_binary seems a little cleaner than adding another keyword argument.

As for test coverage, well, that yak has already been shaved. :grin:

Here's a rough sketch of what that could look like (and I'm not attached to any of the details here):
class SerializerPipeline:
    def __init__(self, *steps, is_binary=True):
        self.dumps_steps = [_get_item_or_attr(step, 'dumps') for step in steps]
        self.loads_steps = [_get_item_or_attr(step, 'loads') for step in reversed(steps)]
        self.is_binary = is_binary

    def dumps(self, value):
        for step in self.dumps_steps:
            value = step.dumps(value)
        return value

    def loads(self, value):
      for step in self.loads_steps:
          value = step.loads(value)
      return value

def _get_item_or_attr(step, attr):
    if isinstance(step, dict):
        return step[attr]
    return getattr(step, attr)

And then that would get called by init_serializer(), if the argument is a list? Or would it be better to accept a SerializerPipeline object directly instead of taking a list?
Your example would become something like:
import gzip, codecs
from itsdangerous.serializer import Serializer as IDSerializer

from requests_cache import CachedSession, JSONSerializer, SerializerPipeline

code_signer = IDSerializer('secret-key')

session = CachedSession(
  serializer=[
    JSONSerializer(),
    {'dumps': code_signer.sign, 'loads': code_signer.unsign},
    {'dumps': codecs.utf_8.encode, 'loads': codecs.utf8.decode},
    {'dumps': gzip.compress, 'loads': gzip.decompress},
  ]
)

That's more verbose than your original example, but still pretty readable I think.

Also, this PR is ready to go now, but I'll hold off until we decide on what to do next.
And thanks again for the input, it's great to have another pair of eyes on this.

I like it! I think I would suggest one further change - using a utility class for a stage, rather than a dict, tuple, or even a wrapper class. Keeps the SerializerPipeline clean. So more like this:

class Stage:
    def __init__(self, dumps, loads):
        self.dumps = dumps
        self.loads = loads

class SerializerPipeline:
    def __init__(self, *steps):
        self.dump_steps = [getattr(step, "dumps") for step in steps]
        self.load_steps = [getattr(step, "loads") for step in reversed(steps)]

    def dumps(self, value):
        for step in self.dump_steps:
            value = step.dumps(value)
        return value

    def loads(self, value):
      for step in self.load_steps:
          value = step.loads(value)
      return value

So then the example looks like:
import gzip, codecs
from itsdangerous.serializer import Serializer as IDSerializer

from requests_cache import CachedSession, JSONSerializer

code_signer = IDSerializer('secret-key')

serializer = SerializerPipeline([
    JSONSerializer(),
    Stage(dumps=code_signer.sign, loads=code_signer.unsign),
    Stage(dumps=codecs.utf_8.encode, loads=codecs.utf_8.decode),
    Stage(dumps=gzip.compress, loads=gzip.decompress),
])

session = CachedSession(serializer=serializer)

Rounding out, I think you should go ahead and merge - particularly if you have the tests passing. Serializer pipelines probably makes more sense as a discrete PR. But let me know if you have any more thoughts on this!

Yeah, that's looking good. Would you like to put that and some examples into a PR for #283?

authors: JWCook coveralls parkerhancock

repo: reclosedev/requests-cache


text:
Please invite me to the Recode-Hive GitHub Community Organization

Name
Michael Hinrichs
Discord Username (if applicable)
NintenHero
Additional Context
No response

Invitation sent to join the GitHub Organisation. Welcome to the community 🎉
Don't forget after accepting to make it public so it appears on your GitHub profile for everyone else to see. You can do this by finding your name in the GitHub organisation list and change the dropdown to public https://github.com/orgs/recodehive/people

authors: MichaelHinrichs sanjay-kv

repo: recodehive/Support


text:
Remove Habana from manifests and repository docs

Related to: https://issues.redhat.com/browse/RHOAIENG-13278

/lgtm
When it comes to the digest updater for these old releases - where do we plan to take it from? Also rhoai-2.8 branch? In such case, should the digest updater also deserve a change as part of this? :thinking:

Good thought @jstourac,  I believe we can retrieve the date of the latest commit from the rhoai-2.8 branch, then search on Quay for 2023a tag using that date. Afterward, we can update the manifests accordingly.
The current flow of the digest updater does not allow this flexibility. as it is made to update the main manifests, and after the sync process updates the current version for RHOAI.

Good thought @jstourac, I believe we can retrieve the date of the latest commit from the rhoai-2.8 branch, then search on Quay for 2023a tag using that date or close date. Afterward, we can update the manifests accordingly.

I'm not sure if I follow on this one. We can't use the latest builds of the 2023a and 2023b for this release?

The current flow of the digest updater does not allow this flexibility, as it is made to update the main manifests, and then the sync process updates the current version for RHOAI branch.

That is why I asked whether we plan to use the GHA from the rhoai-2.8 branch where is point to the versions we expected at that time of the release, I think.

We can't use the latest builds of the 2023a and 2023b for this release?
What I mentioned above could be a baseline for every case.
In this particular Habana notebook since we didn't add any extra feature in following releases, yes we can grab also a latest build.

What I mentioned above could be a baseline for every case. In this particular Habana notebook since we didn't add any extra feature on the following releases, yes we can grab also a latest build.

Hm, in general it should be that way with every release version we maintain, no? :thinking: We do big changes to images only with the version bump. Otherwise we do just minor package updates. Also, this discussion isn't about Habana image solely, it's about the update of images in case of a z.stream release.

Follwed the same removal way as we did on https://github.com/red-hat-data-services/notebooks/pull/404

btw for the failing kubectl, this will fix it #404

/unapprove
sorry, wanted just lgtm

/lgtm

authors: atheo89 jiridanek jstourac

repo: red-hat-data-services/notebooks


text:
changing the pg_num to power of 2

Signed-off-by: harishmunjulur hmunjulu@redhat.com

rhel 8.1: http://pulpito.ceph.redhat.com/hmunjulu-2020-04-13_18:28:22-rbd:singleton-bluestore-nautilus-distro-basic-multi/
rhel 7.7: http://pulpito.ceph.redhat.com/hmunjulu-2020-04-13_21:11:15-rbd:singleton-bluestore-nautilus-distro-basic-multi/

repo: red-hat-storage/ceph


text:
Custom hook: useAccessReview

Adapted original console implementation in order to avoid dev. dep. 'dynamic-plugin-sdk-internal-kubevirt'
that is deprecated in 4.11 release.
Signed-off-by: Alfonso Martínez almartin@redhat.com

@SanjalKatiyar Can you please review and allow running workflows?
First-time contributors need a maintainer to approve running workflows.

/ok-to-test

/approve
/lgtm

/lgtm cancel
let's build test pass

/lgtm

authors: SanjalKatiyar alfonsomthd

repo: red-hat-storage/mcg-ms-console


text:
Remove active mds solution from alert

Running more than one active MDS is not tested as of now.

/hold

authors: agarwal-mudit manishym

repo: red-hat-storage/ocs-operator


text:
Propagate verification results to the pipeline

This makes the easily viewable on the test report

/test jvm-build-service-in-repo-apicurio-e2e

/test jvm-build-service-in-repo-apicurio-e2e

@dwalluck FYI

repo: redhat-appstudio/jvm-build-service


text:
refactor(STONEO11Y-90): Consolidate CI scripts into a single makefile

A couple of scripts were originally created for installing and running some of the tools required for CI tests.
This change consolidates those into a single makefile. The use of makefile also reduces the need for checking if the prerequisites exist as make does that on its own.

/test

pint:
	echo 'Installing pint...'
	curl -OJL 'https://github.com/cloudflare/pint/releases/download/v${PINT_VERSION}/pint-${PINT_VERSION}-linux-amd64.tar.gz'
	tar xvzf 'pint-${PINT_VERSION}-linux-amd64.tar.gz' pint-linux-amd64
	mv pint-linux-amd64 pint
	rm 'pint-${PINT_VERSION}-linux-amd64.tar.gz'

promtool:
	echo "Installing promtool..."
	curl -OJL "https://github.com/prometheus/prometheus/releases/download/v${PROMTOOL_VERSION}/prometheus-${PROMTOOL_VERSION}.linux-amd64.tar.gz"
	tar xvzf "prometheus-${PROMTOOL_VERSION}.linux-amd64.tar.gz" "prometheus-${PROMTOOL_VERSION}.linux-amd64"/promtool --strip-components=1
	rm -f prometheus-${PROMTOOL_VERSION}.linux-amd64.tar.gz

yq:
	echo "Installing yq..."
	curl -OJL "https://github.com/mikefarah/yq/releases/download/v${YQ_VERSION}/yq_linux_amd64.tar.gz"
	tar xvzf yq_linux_amd64.tar.gz ./yq_linux_amd64
	rm -f yq_linux_amd64.tar.gz
	mv yq_linux_amd64 yq

LGTM, but as long as all of the installation code is in one file, we might be able to unify it into one function.

pint:
	echo 'Installing pint...'
	curl -OJL 'https://github.com/cloudflare/pint/releases/download/v${PINT_VERSION}/pint-${PINT_VERSION}-linux-amd64.tar.gz'
	tar xvzf 'pint-${PINT_VERSION}-linux-amd64.tar.gz' pint-linux-amd64
	mv pint-linux-amd64 pint
	rm 'pint-${PINT_VERSION}-linux-amd64.tar.gz'

promtool:
	echo "Installing promtool..."
	curl -OJL "https://github.com/prometheus/prometheus/releases/download/v${PROMTOOL_VERSION}/prometheus-${PROMTOOL_VERSION}.linux-amd64.tar.gz"
	tar xvzf "prometheus-${PROMTOOL_VERSION}.linux-amd64.tar.gz" "prometheus-${PROMTOOL_VERSION}.linux-amd64"/promtool --strip-components=1
	rm -f prometheus-${PROMTOOL_VERSION}.linux-amd64.tar.gz

yq:
	echo "Installing yq..."
	curl -OJL "https://github.com/mikefarah/yq/releases/download/v${YQ_VERSION}/yq_linux_amd64.tar.gz"
	tar xvzf yq_linux_amd64.tar.gz ./yq_linux_amd64
	rm -f yq_linux_amd64.tar.gz
	mv yq_linux_amd64 yq

LGTM, but as long as all of the installation code is in one file, we might be able to unify it into one function.

I don't think this should be generalized. At least not at the moment. Those installations behave somewhat similarly, but they are not similar enough for such generalization to be elegant and increase maintainability.

Wen I asked why are we working shell scripts in this day and age, Gal told me it was because we could use linting tools like shellcheck for them, do we have the same for makefiles? Do we have checking for the shell commands within the makefiles?

pint:
	echo 'Installing pint...'
	curl -OJL 'https://github.com/cloudflare/pint/releases/download/v${PINT_VERSION}/pint-${PINT_VERSION}-linux-amd64.tar.gz'
	tar xvzf 'pint-${PINT_VERSION}-linux-amd64.tar.gz' pint-linux-amd64
	mv pint-linux-amd64 pint
	rm 'pint-${PINT_VERSION}-linux-amd64.tar.gz'

promtool:
	echo "Installing promtool..."
	curl -OJL "https://github.com/prometheus/prometheus/releases/download/v${PROMTOOL_VERSION}/prometheus-${PROMTOOL_VERSION}.linux-amd64.tar.gz"
	tar xvzf "prometheus-${PROMTOOL_VERSION}.linux-amd64.tar.gz" "prometheus-${PROMTOOL_VERSION}.linux-amd64"/promtool --strip-components=1
	rm -f prometheus-${PROMTOOL_VERSION}.linux-amd64.tar.gz

yq:
	echo "Installing yq..."
	curl -OJL "https://github.com/mikefarah/yq/releases/download/v${YQ_VERSION}/yq_linux_amd64.tar.gz"
	tar xvzf yq_linux_amd64.tar.gz ./yq_linux_amd64
	rm -f yq_linux_amd64.tar.gz
	mv yq_linux_amd64 yq

LGTM, but as long as all of the installation code is in one file, we might be able to unify it into one function.

I don't think this should be generalized. At least not at the moment. Those installations behave somewhat similarly, but they are not similar enough for such generalization to be elegant and increase maintainability.

I will go with at least not at the moment as I do think there is a similarity that is close enough to generalize the installation part of different tools. :)

When I asked why are we working shell scripts in this day and age

I'm on the same page with you...
Look at other Stonesoup repos as well... shell scripts... shell scripts everywhere....  :)

Wen I asked why are we working shell scripts in this day and age, Gal told me it was because we could use linting tools like shellcheck for them, do we have the same for makefiles? Do we have checking for the shell commands within the makefiles?

I had that conversation in mind when we talked about using makefiles. I think the answer is no. At least I don't have it. We opted for makefile, mainly to reduce the need for checking if things are installed already and to utilize targets as an alternative to switch/case statements.
At this given moment, I think makefile is cleaner and easier to use in the same way across CI and local environments.
We could have as well had the makefile call scripts, but I don't think that's necessary at the moment, but if it gets more complicated then we can do that as well.

@ifireball

When I asked why are we working shell scripts in this day and age

I'm on the same page as you... Look at other Stonesoup repos as well... shell scripts... shell scripts everywhere.... :)

What's the alternative? Having it defined in the YAMLs? Going this way, we need to maintain separate solutions for the CI and for the developers.

@yftacherzog :

What's the alternative? Having it defined in the YAMLs? Going this way, we need to maintain separate solutions for the CI and for the developers.

Python? Go? Java? Language that actually has a good testing framework.

@ifireball

When I asked why are we working shell scripts in this day and age

I'm on the same page as you... Look at other Stonesoup repos as well... shell scripts... shell scripts everywhere.... :)

What's the alternative? Having it defined in the YAMLs? Going this way, we need to maintain separate solutions for the CI and for the developers.

We seem to be re-solving the same problem set that pipenv solves for python repos. We could use that, or equivalent tools for other languages, there are also a couple of very generic ones.
One interesting option may be pre-commit, which is python based but chooses to not make that a concern for the repo that uses it.
Another option is to gook everything into go test like we did for pytest in our previous repo - the go ecosystem seems to be quite good at allowing things to be easily rebuilt across platforms

If we plan to keep using makefiles lets at least make sure to run this:
https://github.com/mrtazz/checkmake

@eisraeli @ifireball I'm going to open a ticket for investigating potential test frameworks.
I honestly think that, for now, bash/makefile is the best approach in terms of flexibility and maintainability. Once we get a better picture of the nature of what we're going to work on, I think we will be in a better position to decide on the best approach.
Until then, I think the best approach is to go with something easy to implement which has as fewer prerequisites as possible for the developers.

authors: eisraeli ifireball yftacherzog


text:
flake8

admin.py , models.py , tests.py files has been modified

Well done!

@RawanAbuleil does this PR needs to be rebased on all those other PRs? Might be that we can merge yours earlier, so that some of that python code is introduced already according to flake8 standards, rather than having you fix it here.

@RawanAbuleil try making the PR name more descriptive.

@RawanAbuleil you're again in some sort of merge-commit. Not sure how come. Please consult with the team regarding how to avoid this (the rest of the PRs look ok in that sense at the moment). I'll merge this tomorrow morning only if this is sorted.

LGTM!

@RawanAbuleil The merge commit issue was not addressed. See the Files changed tab and you see it contains stuff which are not part of your PR. The knowledge for avoiding that already exists within the team, so please ask around.

Looks good,but i think README and CONTRIBUTING files should not be there because they are on their own PRS,great work!

lgtm. Need to verify that the workflow is working as expected after the PR is merged.

authors: RawanAbuleil pazMenachem thetaxas2468 yftacherzog


text:
[chaos-recommender] Consider node level resource usage for app with no limits

For identifying CPU/Memory intensive applications, we might want to compare % usage with respect to availability on nodes in cases where there are no limits set.

cc: @mudverma @sandeephans

The feature has been added, thanks to @mudverma!

repo: redhat-chaos/krkn


text:
Make 'ignore_unknown_parameters' configurable to support old OCP versions

Older versions of OCP doesn't support the ignore_unknown_parameters flag, so this issue is to make it configurable to not set it at all.

Done by #48 - closing

repo: redhat-cop/openshift-applier