text:
Create a list of package requirements

Using the latest version https://github.com/opendatahub-io/caikit-tgis-serving/blob/main/demo/kserve/scripts/generate-wildcard-certs.sh the script is failing with the following error:
+ openssl req -x509 -newkey rsa:2048 -sha256 -days 3560 -nodes -subj '/CN=<value>' -extensions san -config <configpath> -CA <cert_path> -CAkey <key_path> -keyout <keyout_path> -out <out_path>
req: Unrecognized flag CA
req: Use -help for summary.

The cause was due an outdated pkg installed on the system. It could happen to anyone using the script, hence it would be good to explicitly say the minimum reqs

@heyselbi @bdattoma  - Did you intend for this bug to be included as a known issue in the 1.33 release notes, or did you include the documentation solely to document the minimum package requirements for running the script?

Hi @chtyler , added the doc label because the issue is related to the quickstart we have in this repo. The quickstart instructs the user to execute a script that has a bug Berto mentioned.

Thanks Selbi, I can confirm that I will not include this bug in the 1.33 release notes.

This step is no longer necessary, it is handled by the operator now. The manual install steps are officially legacy with 2.5

authors: Xaenalt bdattoma chtyler heyselbi

repo: opendatahub-io/caikit-tgis-serving


text:
Rename package_upload.sh to package_download.sh

Description of your changes:
It is a rename of files to match exactly what they are doing
Testing instructions
NA
Checklist

[X] The commits are squashed in a cohesive manner and have meaningful messages.
[X] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
[X] The developer has manually tested the changes and verified that the changes work

/lgtm

/retest

source: gharchive/pull-request

authors: VaniHaripriya diegolovison

license_type: permissive

license_source: github-api


text:
Automated test for LLM Finetune Deepspeed demo

Description

RHOAIENG-9185

Automated test for Ray-LLM-deepspeed-finetune demo
Updated tests to use default local queue created in given namespace to skip local-queue usage in raycluster configuration function.
Updated mnist_hpo.py to run TestMnistRayTuneHpoCpu/Gpu tests in disconnected environment.

Depends on :
https://github.com/project-codeflare/codeflare-common/pull/59
How Has This Been Tested?

export CODEFLARE_TEST_OUTPUT_DIR=/home/abdhumal/abhidev/RedHatDev/distributed-workloads \
NOTEBOOK_USER_NAME=regular-user \
NOTEBOOK_USER_TOKEN=<auth-token> \
ODH_NAMESPACE=redhat-ods-applications \
NOTEBOOK_IMAGE=quay.io/modh/odh-generic-data-science-notebook@sha256:465e81c69c891565b979668b84adcf0c645b1ed99e1bf107474ef6bb56090027 \
AWS_ACCESS_KEY_ID=<s3-access-key> \
AWS_SECRET_ACCESS_KEY=<s3-secret-key> \
AWS_STORAGE_BUCKET=<storage-bucket-name> \
AWS_DEFAULT_REGION=<aws-default-region>

go test -timeout 15m -v ./tests/odh -run TestRayFinetuneDemo

Merge criteria:

[ ] The commits are squashed in a cohesive manner and have meaningful messages.
[ ] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
[ ] The developer has manually tested the changes and verified that the changes work

What was the reasoning behind copying all of the necessary training files to this tests/odh/ray_finetune_demo? The files should exist already under examples/ray-finetune-llm-deepspeed.
This would cause any updates for the example to also be updated here

Hey Mark, I have updated some of the files a bit to make it compatible with paths specified during test execution and also some tweaks can be made in future for upcoming tests..
So keeping example files and test files separate seems feasible to me in this case.. please correct me if I'm wrong
Thank you for reviewing @Bobbins228 !!

A general question, do you have a strategy how to make sure that the example which is tested is aligned with the test?
How to make sure that any change in example is propagated into the test?

A general question, do you have a strategy how to make sure that the example which is tested is aligned with the test? How to make sure that any change in example is propagated into the test?

@sutaakar I guess reusing all existing demo finetune files from examples directory might help in keeping sync between example & related test. As we are using string.replace()  to make changes in existing notebook for the test, if example file is updated then the requiredChangesInNotebook map also needs to be updated manually  to reflect those chnages in test accordingly.

The test seems to fail to me:
ksuta@ksuta-thinkpadp1gen4i:~/src/github.com/opendatahub-io/distributed-workloads$ go test -run TestMnistRayCpu -v -timeout 60m ./tests/odh/
=== RUN   TestMnistRayCpu
    mnist_ray_test.go:50: Created Kueue ResourceFlavor rf-tnxqd successfully
    mnist_ray_test.go:79: Created Kueue ClusterQueue cq-kn6th successfully
    mnist_ray_test.go:81: Created Kueue LocalQueue test-ns-4fk75/lq-485wq successfully
    mnist_ray_test.go:91: Created ConfigMap test-ns-4fk75/config-pqkfw successfully
    mnist_ray_test.go:103: Created User RoleBinding  in namespace test-ns-4fk75 successfully
    notebook.go:58: Created PersistentVolumeClaim test-ns-4fk75/pvc-hmhm5 successfully
Storage bucket doesn't exists!
    notebook.go:74: Ingress domain: apps.ods-qe-psi-18.osp.rh-ods.com
    notebook.go:75: OpenShift API URL: https://api.ods-qe-psi-18.osp.rh-ods.com:6443
    notebook.go:100:
        Unexpected error:
            <yaml.YAMLSyntaxError>:
            error converting YAML to JSON: yaml: line 53: did not find expected ',' or ']'
            {
                err: <*fmt.wrapError | 0xc0005e0700>{
                    msg: "error converting YAML to JSON: yaml: line 53: did not find expected ',' or ']'",
                    err: <*errors.errorString | 0xc000893cc0>{
                        s: "yaml: line 53: did not find expected ',' or ']'",
                    },
                },
            }
        occurred
    test.go:141: Creating ephemeral output directory as CODEFLARE_TEST_OUTPUT_DIR env variable is unset
    test.go:144: Output directory has been created at: /tmp/TestMnistRayCpu1613457119/001
--- FAIL: TestMnistRayCpu (3.27s)
FAIL
FAIL	github.com/opendatahub-io/distributed-workloads/tests/odh	3.287s
FAIL

Looks like it is related to:
	if !s3BucketNameExists {
		println("Storage bucket doesn't exists!")
		s3BucketName = "\"\""
		s3AccessKeyId = "\"\""
		s3SecretAccessKey = "\"\""
		s3DefaultRegion = "\"\""
	}

The test seems to fail to me:
ksuta@ksuta-thinkpadp1gen4i:~/src/github.com/opendatahub-io/distributed-workloads$ go test -run TestMnistRayCpu -v -timeout 60m ./tests/odh/
=== RUN   TestMnistRayCpu
    mnist_ray_test.go:50: Created Kueue ResourceFlavor rf-tnxqd successfully
    mnist_ray_test.go:79: Created Kueue ClusterQueue cq-kn6th successfully
    mnist_ray_test.go:81: Created Kueue LocalQueue test-ns-4fk75/lq-485wq successfully
    mnist_ray_test.go:91: Created ConfigMap test-ns-4fk75/config-pqkfw successfully
    mnist_ray_test.go:103: Created User RoleBinding  in namespace test-ns-4fk75 successfully
    notebook.go:58: Created PersistentVolumeClaim test-ns-4fk75/pvc-hmhm5 successfully
Storage bucket doesn't exists!
    notebook.go:74: Ingress domain: apps.ods-qe-psi-18.osp.rh-ods.com
    notebook.go:75: OpenShift API URL: https://api.ods-qe-psi-18.osp.rh-ods.com:6443
    notebook.go:100:
        Unexpected error:
            <yaml.YAMLSyntaxError>:
            error converting YAML to JSON: yaml: line 53: did not find expected ',' or ']'
            {
                err: <*fmt.wrapError | 0xc0005e0700>{
                    msg: "error converting YAML to JSON: yaml: line 53: did not find expected ',' or ']'",
                    err: <*errors.errorString | 0xc000893cc0>{
                        s: "yaml: line 53: did not find expected ',' or ']'",
                    },
                },
            }
        occurred
    test.go:141: Creating ephemeral output directory as CODEFLARE_TEST_OUTPUT_DIR env variable is unset
    test.go:144: Output directory has been created at: /tmp/TestMnistRayCpu1613457119/001
--- FAIL: TestMnistRayCpu (3.27s)
FAIL
FAIL	github.com/opendatahub-io/distributed-workloads/tests/odh	3.287s
FAIL

Looks like it is related to:
	if !s3BucketNameExists {
		println("Storage bucket doesn't exists!")
		s3BucketName = "\"\""
		s3AccessKeyId = "\"\""
		s3SecretAccessKey = "\"\""
		s3DefaultRegion = "\"\""
	}

@sutaakar Apologies I should have tested it correctly, Thanks for pointing this out. I have replaced "\"\"" with "''" so it should be working now.. Could you please test it again?

authors: abhijeet-dhumal sutaakar

repo: opendatahub-io/distributed-workloads


text:
Request external storage runtime permission on startup

Depends on https://github.com/opendatakit/androidlibrary/pull/28

runtests

repo: opendatakit/services


text:
cy(doc): add d4rl(mujoco) English file

done the translation

rename file (file name should be consistent with other files in the directory )

add banner in the index of the peer directory

check whether the title exists in the idnex of the same level directory

repo: opendilab/DI-engine-docs


text:
403 response from opendns.com

The build worked fine, I tried this:
./miner.py --domain test.com
And got this as a result:
Exception: investigate: 403 Client Error: Forbidden for url: https://investigate.api.opendns.com/dnsdb/name/A/test.com.json
I web browser access to https://investigate.api.opendns.com yields a response that it doesn't exist, but nslookup has this to say:
investigate.api.opendns.com
Server:		192.168.88.1
Address:	192.168.88.1#53
Non-authoritative answer:
investigate.api.opendns.com	canonical name = investigate-prod-1684235967.us-west-1.elb.amazonaws.com.
Name:	investigate-prod-1684235967.us-west-1.elb.amazonaws.com
Address: 52.52.202.183
Name:	investigate-prod-1684235967.us-west-1.elb.amazonaws.com
Address: 52.52.239.3
Am I doing something wrong, or did this prove insanely popular and get overrun, resulting in the service being disabled?

nealrauhauser, you need to provide a token in order to use the APIs. I do believe this is what is happening to you

source: gharchive/issue

authors: MadMiniHunter nealrauhauser

repo: opendns/og-miner

license: MIT


text:
feat(moac): decouple moac from mayastor

It is a preparation step for moving moac to a separate repository.
Major update to the documentation.
This commit solves two major problems:

Sharing proto files between mayastor and moac
Removing dependency on nix and using docker to build moac image

add 1. We use curl to download proto files from the mayastor repo.
It does not make sense now but will in the future. Everytime a change
to proto files in mayastor repo is made, the commit hash in a script
needs to be changed to pull these new changes. It is a conscious
decision resulting into a deterministic build of moac.
add 2. We still provide nix-shell for setting up dev environment for
moac, however that's all what we use the nix for. The script
csi/moac/scripts/release.sh is a simplified version of its
mayastor counterpart.
Resolves: CAS-958

bors try

bors merge

repo: openebs/Mayastor


text:
chore(actions): update github actions to remove deprecated methods

Signed-off-by: Akhil Mohan akhil.mohan@mayadata.io
Why is this PR required? What issue does it fix?:
Github actions deprecated the set-env command. Instead of that environment files are the recommended option now.
What this PR does?:

use environment files in github actions instead of deprecated set-env command
tag generation in release workflow is now fixed with the correct release tag

Does this PR require any upgrade changes?:
No
If the changes in this PR are manually verified, list down the scenarios covered::
Any additional information for your reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs
Checklist:

[ ] Fixes #
[x] PR Title follows the convention of  <type>(<scope>): <subject>
[ ] Has the change log section been updated?
[ ] Commit has unit tests
[ ] Commit has integration tests
[ ] (Optional) Are upgrade changes included in this PR? If not, mention the issue/PR to track:
[ ] (Optional) If documentation changes are required, which issue on https://github.com/openebs/openebs-docs is used to track them:

Codecov Report

Merging #6 (faeb6f5) into develop (72b79ff) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           develop      #6   +/-   ##
=======================================
  Coverage     0.68%   0.68%
=======================================
  Files           10      10
  Lines          585     585
=======================================
  Hits             4       4
  Misses         581     581

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72b79ff...faeb6f5. Read the comment docs.

authors: akhilerm codecov-io

repo: openebs/dynamic-localpv-provisioner


text:
chore: update nixpkgs and rustc

Rustc is now set to 2023-02-06 both for nightly and stable.
Signed-off-by: Tiago Castro tiagolobocastro@gmail.com

bors try

bors merge

bors merge

repo: openebs/mayastor-control-plane


text:
Documentation incorrect for creating Jiva backups

Description
The Jiva User Guide states the following command can be used to create a backup manually:
velero backup create <backup_name> --selector '!openebs.io/controller,!openebs.io/replica'

However, the labels used by the --selector are not present on the Jiva replica or controller pods. These pods actually use the label openebs.io/component with a value of either jiva-controller or jiva-replica.
Possible Solution
I suggest the documentation be updated as follows:
velero backup create <backup_name> --selector 'openebs.io/component notin (jiva-controller, jiva-replica)'

Screenshots

In the latest version of documentation, not even the "bad" documentation exists.

authors: adamcharnock aidapsibr

repo: openebs/openebs


text:
Travis CI must bring up a Kubernetes Environment and verify all Maya commits within that environment.

Is this a BUG REPORT or FEATURE REQUEST?
FEATURE REQUEST

What happened:
Most of the Maya changes require its Kubernetes integration to be verified, the current Travis CI build does not verify this integration. So in order to verify this integration Travis should be able to spawn up a Kubernetes Environment and Run Maya operator related integration related tests on the commits made.
What you expected to happen:
Travis should bring up a Kubernetes Environment for the changes in Maya to be verified in that environment.
How to reproduce it (as minimally and precisely as possible):
Anything else we need to know?:
A good reference to get started of with: https://kinvolk.io/blog/2017/10/running-kubernetes-on-travis-ci-with-minikube/

https://github.com/openebs/maya/pull/142 Can Please you review this ?

https://github.com/openebs/maya/pull/142 PR installs minkube to the openebs/maya build environment in travis. Need to extend it with test scripts that will launch the maya deployments.

authors: ggarg2906sumo kmova yudaykiran


text:
docs: update link to production configuration

This PR fix a broken link to the production configuration in the technical documentation in the Aspects documentation.

Thanks for the pull request, @Apgomeznext! Please note that it may take us up to several weeks or months to complete a review and merge your PR.
Feel free to add as much of the following information to the ticket as you can:

supporting documentation
Open edX discussion forum threads
timeline information ("this must be merged by XX date", and why that is)
partner information ("this is a course on edx.org")
any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.
Please let us know once your PR is ready for our review and all tests are green.

@Apgomeznext 🎉 Your pull request was merged!  Please take a moment  to answer a two question survey so we can improve your experience in the future.

authors: Apgomeznext openedx-webhooks

repo: openedx/openedx-aspects


text:
Update local frontend-platform documentation

### Tasks
- [ ] https://github.com/openedx/paragon/issues/3067
- [ ] https://github.com/openedx/paragon/issues/3068

I reviewed the documentation here https://github.com/openedx/frontend-platform/pull/689/files#diff-0e764ad3abf238c70590cbada2902ec481874e525cd7cd80da1a5875afda7d9a and made some improvements. Also, I checked the JSDoc to reflect the hook behavior, and with that, the gh-pages stay updated once the PR is merged. Finally, I made a small recommendation for the migrating document https://openedx.atlassian.net/wiki/spaces/BPL/pages/3770744958/Migrating+MFEs+to+Paragon+design+tokens+and+CSS+variables

repo: openedx/paragon


text:
Sync alpha with master

Description
Sync alpha with latest from master.
Deploy Preview
N/A
Merge Checklist

[ ] If your update includes visual changes, have they been reviewed by a designer? Send them a link to the Netlify deploy preview, if applicable.
[ ] Does your change adhere to the documented style conventions?
[ ] Do any prop types have missing descriptions in the Props API tables in the documentation site (check deploy preview)?
[ ] Were your changes tested using all available themes (see theme switcher in the header of the deploy preview, under the "Settings" icon)?
[ ] Were your changes tested in the example app?
[ ] Is there adequate test coverage for your changes?
[ ] Consider whether this change needs to reviewed/QA'ed for accessibility (a11y). If so, please add wittjeff and adamstankiewicz as reviewers on this PR.

Post-merge Checklist

[ ] Verify your changes were released to NPM at the expected version.
[ ] If you'd like, share your contribution in #show-and-tell.
[ ] 🎉 🙌 Celebrate! Thanks for your contribution.

:tada: This PR is included in version 21.0.0-alpha.14 :tada:
The release is available on:

npm package (@alpha dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 20.28.5 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 22.0.0-alpha.1 :tada:
The release is available on:

npm package (@alpha dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

authors: adamstankiewicz edx-semantic-release


text:
fix: delay loading of unfocused dashboards

Description
This PR delays the loading of unfocused dashboards.
https://github.com/user-attachments/assets/0080ab4b-abba-4565-b99f-7bd353f3f034
Merge checklist:
Check off if complete or not applicable:

[ ] Version bumped
[ ] Changelog record added
[ ] Documentation updated (not only docstrings)
[ ] Fixup commits are squashed away
[ ] Unit tests added/updated
[ ] Manual testing instructions provided
[ ] Noted any: Concerns, dependencies, migration issues, deadlines, tickets

Thanks for the pull request, @Ian2012!
What's next?
Please work through the following steps to get your changes ready for engineering review:
:radio_button: Get product approval
If you haven't already, check this list to see if your contribution needs to go through the product review process.

If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.

This process (including the steps you'll need to take) is documented here.

If it doesn't, simply proceed with the next step.

:radio_button: Provide context
To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

Dependencies

This PR must be merged before / after / at the same time as ...

Blockers

This PR is waiting for OEP-1234 to be accepted.

Timeline information

This PR must be merged by XX date because ...

Partner information

This is for a course on edx.org.

Supporting documentation
Relevant Open edX discussion forum threads

:radio_button: Get a green build
If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.
:radio_button: Let us know that your PR is ready for review:
Who will review my changes?
This repository is currently maintained by @bmtcril.  Tag them in a comment and let them know that your changes are ready for review.
Where can I find more information?
If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

Overview of Review Process for Community Contributions
Pull Request Status Guide
Making changes to your pull request

When can I expect my changes to be merged?
Our goal is to get community contributions seen and reviewed as efficiently as possible.
However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

The size and impact of the changes that it introduces
The need for product review
Maintenance status of the parent repository

:bulb: As a result it may take up to several weeks or months to complete a review and merge your PR.

repo: openedx/platform-plugin-aspects


text:
split ubuntu build into multi stage

Signed-off-by: brmclaren brmclare@microsoft.com

/test all

/test all

repo: openenclave/test-infra


text:
Template Github Actions for release build

https://github.com/techknowlogick/classic-watchdog/runs/1889042735?check_suite_focus=true
Fixes #3

Thank you @techknowlogick
Could you also copy over the issue and PR templates from here?

authors: alexellis techknowlogick

repo: openfaas/classic-watchdog


text:
test: add test for storage.ReadPage

I am adding one test that is meant to simulate the case where ReadPage is supposed to skip over tuples that don't match the filter.
In the future we need to consider revisiting our entire storage interface tests, see what code paths aren't well covered, and write tests for those.

It seems we're doing 2 things in the scope of this PR

Changing the tuple validation logic in the graph package to make sure we filter out invalid tuples correctly and
Adding tests for storage#ReadPage

#2 can presumably be in its own PR. I don't see why its relevant to lump it in with #1. What was the reasoning behind combining these two code changes together?

authors: jon-whit miparnisari

repo: openfga/openfga


text:
refactor: use slices and maps packages from go1.21

Description

This PR applies slices and maps builtin packages from go1.21.

References

Review Checklist

[x] I have clicked on "allow edits by maintainers".
[ ] I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
[ ] The correct base branch is being used, if not main
[ ] I have added tests to validate that the change in functionality is working as expected

@tranngoclam  thank you for your contribution!

authors: adriantam tranngoclam


text:
Migrate CircleCI to GitActions

The current deployed is not automated using GitHub actions.  Please migrate deployment and validation of all OpenFIDO resources to GitHub actions.

Addressed by pull-requests #120 , #121 and #122

authors: Thistleman catzzz

repo: openfido/openfido-client


text:
Allow unresizable HTML5 apps

If the user sets the window config "resizable" to false in an html5 app, then it forces the window to always be a certain fixed size.
I just add some macro logic to the template. If resizable is true, width/height are "100%" (the current behavior). If resizable is false, width/height are the exact values specified by the user in project.xml

Significance: this will be extremely helpful in maturing HaxeFlixel for proper HTML5 support.

repo: openfl/openfl

license: mit

license_source: bigquery


text:
fixed a UI bug in LoginActivity

Fixed a bug in issue #1199 by changing a method in CustomEditTextView.java

Before and after:

Looking good to me. @Karljoones Have a look.

Merged, thanks!

authors: Karljoones shivanshsoni tjwhm

repo: openfoodfacts/openfoodfacts-androidapp


text:
Add Unit Tests for some of the models

Description
Just some Unit tests for Product, Additive, AdditiveName and AddtiveResponse. I only tested methods that include actual logic. I didn't touch any of the Production code, so this doesn't fix any problems.
Related issues and discussion
None. Doesn't touch production code.
Checklist
I'm pretty sure I got all the items here, but as this is my first time contributing here, I may have done something wrong.
I enjoy writing these tests, and I feel it's a good way to get to know the codebase, so I'll probably end up writing more in the next couple of days. If I do I imagine you'd want me to put them all into one pull request, which I'm willing to do.

Hey @gspitz01,
Your changes look good to me!

Merged, thanks @gspitz01

authors: Karljoones TravisBuddy gspitz01