text:
Apparently inaccurate alignment end positions in the "ont" mode

I am attaching a sequence at the end. For this sequence, both bwa-mem and graphmap find a hit between [75,19805) against GRCh38. In the "pacbio" mode, ngm-lr finds [75,19622). In the "ont" mode, it finds [0,19622), which is surprising in that other aligners can align the last ~183bp but not the first 75bp. I extracted the first 75bp and the extra reference sequence in ngm-lr-ont alignment. The alignment looks like
CTCCTAGGT---AACTGGCCAGC-----AA--ATGAA-GTGACACTGTTAGATCTTGTACACTTTGCCATGTTTGTTTCACTCACCTG
AAGCGCGGCGAAAACGCGAAAGCGTTTTACCGATAAATGCGAAACAGCAATA-C--GTA-ACTGAACGAAGT-------AC--ACCAG

They don't align well. My gut feeling is there might be something wrong – for example, ngm-lr could be extending towards the wrong direction. Sorry if my guess is wrong here.
>test
CTGGTGTACTTCGTTCAGTTACGTATTGCTGTTTCGCATTTATCGGTAAAACGCTTTCGCGTTTTCGCCGCGCTTCATAGGAATATCGACTCCCCACCCATGCAGTACTCTCAAATTTCAGCAACTGAACATCAGAGTTCTTTCTCTTTCAAGTTTCTGCTCTCAATAACTGGGAGAAACAAGAAAAGAAAAGAAAAAGA
GGAAAGAAAGAGATAGTAGTGGGGACAAATACTCACTAGAACTTACTGGGTACTACTGGGATGATTACTATAAAATCAAAGGGTCTCTACTGGCGGTACGTGCTCCACGCCTATGTCCAGCAGCGCACAGAATGCCGAGGCGGTGGATCATGAGGTCAGGAGATGGAATATCCACAGCGCAACAAGGTGAAACCGTCTAA
AAATACAAAAATTGGCGGGCGTGGTGAGCCTGGTCAACTACTACAGGCTGGGAGCAGGAGAATGCGTGAACCAGAGCCGAACTTGCAGTGCGCCGAGATGCGCCACTGCAGTCCGCAGTCGGCCTAGGCGACAAGCGGGGAACTCGATCTCAAAAGTCTACTAAACAGTGGTTCTCAGTGTTCTCCAATGGCGAATGTAG
GTCAAGCATCAGTATTTTTGCCGGGATTCTCTAAGGGATTCTAAAGTCTTTTAGGTTGAGTACTGTCACTGAAGAAGAACCCTTCTCGCCGTGGCGGACGCCTTCAGTATCCTGAATTAAATAGCTGGGTAGTTTGGGAAAAATATAATGAACAGGTAATAGGTAAGTAAAAGCCGTCAGAGCAAAATTTAAGCAAGTTT
GCTGAGGTGGGAAATAAGGCACTGGTGTATAAACCAATAATCTTGACATATAAGTAATAGCACTACTAAGATAGGCTCACCTTTGGTATAGATAAATGAAACACTCTTATTGTTCTATATGCTGAGGCACTGTGCATTAGGTTATATATCTGCTTATGGCGCGGCTAAAAATTCTATTACCACCAATATGGAGGTCAAGT
AAGATCAAACATGCCTTCTCTGAAGGTTCTTATTCTACCGGTCCACGGTCTATTTTAGAGTCATACTTAAATGGGGATGACAGTTACTTCGGTAAGTCAACAAAAGCTTTTCTGTATAGCTGAATATTTAGCTACAGATGAAAACATCAAATAAGCAGGATAGCACTATCTTAATATAAGAGATAATCGGGTTGATAAAC
CCTGTTTCTATTTCAGTATCTAGTTCTAGCACAACTGTAGTGAGTACATAAATGGAATTTCAACACGCCTTAGTTAAAATCTCAGCATTCCACAGCGTAAACTCACCCTCAGATAGGATGCTTGTTGTTAACTTTATCACTATTCCTTTTATTGCTAATAGTGGCAGAGGGTAAAATGGAAAATAAATCTGAATAGTGTA
AGTTCCTGGCAGGGCTGGGCGAAACCACCCAGCACGAATTTGAAAAGCACACAAATGTTGAATGAATAATTCTGCAAACCAAATTCAAAGCGAATAGTTTCAAATTGTTTGAAGATCCTCACTGATATTTAGGTTATATAGAACTCAGAATTTATCTAAATGTACCTTTGGAGCAGAATAAGAAAAGCGAAAGTTGTTAT
TATGCAACGTGAAGGTAGACATAGACAGAATGGCTCACTAAAAACCATTCTGCTGCAAATCCTGAATGTTGGCTCGTCTGAAGGTTGAAAATCTCATAACGATTTAAGATTATTGGATAAGTCGTATTTTCCTCCCTCAATGAAGCATTCACTTTTAGCAGCCAGGCATCTCCATGTTGAAGTAAAATTCGGTCATGCCA
GGTTCTGCAGGAGCAAATTGCCTTCAAATATGGAAACCAATTCTTAATTATCAGGTTTTAAATGTGTACCAACTCATTGCTTTTCTGGGTTTCATGCAATAGCTTCAACTTATCATCTGGTTCCCATGAGCCCATAGCCTGCTGTTGATCCCAGACCGACTTCTTTCTGTACTTCCCGGTTCCCTCACGGGGCCTCCTCT
TTACCTCAAGCTGTTCCTCAACACCCATTAATCATAGAACGATTTTCACTGTTCCATCTGCCAAACCATCAACATAACTGAAGGCCCTTCCTCCGGTGTTCCCCAATAACCTGCCATTCACCAACTCGACAGACCGTCTAAAATCTCTGTGGTAAGACGTTTTGAATAAATGTCTTGTATTACTTTTATCACTAATGTTA
TCTTCCTCACCCATCAAACGCAATAAGTACTGCGTCTTGTATGTAGTCAATGCTCACTAGTCACACTGTTTTCACAGACGTTTCCATCACTCCCTAAGTAGTGCCTCCATAACAACAATCTCATCCCGCTCTGAAGTTCTATAAAATGAAACTTTACTTGCAGTCAATTCAAGTCTCTGAAGGTCACTGTGTAATAAGAC
TTTTCCTCGGCATCAGGCATACAAGTCTATGATGCAATCTCCAACCGTGACAGCCTAAGGATCAAAAATATGGGTGATAGCGGTGTAAAGCAAGAAGGATGGAGAAAATGGGTGTGATAAGGGGCTCACTCACCACTATCTCTAAAGGGTTTGGTTGTAACTAATCCTTTGAGGGCAACTACCTCAACACCTGAGAGACA
ATGGTTACAAATAGGTGAGAAGAGGACTCTGTACATGAAATGAAACTGGAAATATTAAGCAGGTTGAAAACCAAGGAGTTAATGGACTGAAGCATGCAGTTTATTTGCTGGACCAAGCTTCAAAATTTTGCCTGGCTGCTGGCAGGTCACAGGAAAGAAGAATCTGAACGTTTTCTGCACTCTCAAGGTCTGAAGTCCTG
CAGGTTCTCCACTGAAGTCTGCATGGTCTGGTGACATCTCCGGCCAGGACCACCACTAGAAAAGTAGGTCAGGGCTCTCTGGTGAAGCCTGAGATTGGTCTACCATTGCCGCCCAAGTTGCAGGCCGGGAAGGGCGGCATTCCATGGGATCCTCAGCTCAATAACGCAGCATGGGCCTTAGATGTGCTGAGAGCCCACAG
GGAACAATACGAATTAACATCAAATGAACTCTCTGTTGAGTGAGCTCAAGTTCCCAATGGTCATTCCTGACAATCTCAATACTGGTATGGAATCCTGGGAAAATAAATTTTGGAATTTCTTGGCAACTTCATGACCATACATTTGGAAGGCCTTCACTTTACCCATAGCAAAATAGAGATTATACATGATCTAGTATTGA
GACATTATGGAAAGGCGTTTGATATCCTACTCTTCTCCTCTTTTCCCAATGACTTACCTACCTATTAATTTTAAATTTTATTTTATTATTATAAGTTTTGGGTACATGGCGCAATGTGGGATTGGGTTACGCGTAGCCATGTACCCGTATGGTGTGCTGCCATTAACTGCGATAAACAGCATTAGGTATATATACAAAGC
TATCCTCCCTTCCCCCGTTTAACGGTCCCAGAGTGTGATGTTCCTACTGTGTCATGTATTTCTCTGTTGTTCAATTCCACCTGGTGGGGTAACAGTGCATTTTTATTTCTTTAAGTAGTTTACTGAATGATGATTTCAATTTCATCCATCTCTACAAGGACATGACTCATCATTTTATGGCTGCATAGTATTCATGGTGT
ATATGTGCCACATTTTCTTAATCAGTCTATCATTCATTGGACATTTGGCTTGGTTCAGAAGTCTTTGCTATTGTGAATAGTGCCGCGATAAACATATGCATTGTGCATATGTCTTTATAGCAACATGATTTATAGTCCTTTGGTATATACCCAGTAATGGGATAAGCAGGTCAAATAAGTATTTCTAGTTCTAGATCCTG
AGAATAATACGCAACTTCACAAGGAGTTGGAGCAGTTACAATCCTAACAGGTAAGTGTTCCTATTTCTCCACATCCTCTCAGCACCTGTTGTCTCTGACTTTTAATGGTGCCATTCTAACACTGAGCAGATGGTATCTCATTATGTTTGTTCGCGTTCTCTGATATGCCGTGATGGTGACATTTTCATATGTTTTGGCTG
CATAAATGTCTTCTTTAGAAGTGTATCTGTTCTTCATCCTTTGCCACTTTTGATGGGGTTGTTTTCTTATAGAATTTGTTGTGATTCATTGCTGGATTCTGGATATTAGCCCTTTGTCAGATATGGTGGGATTTACGCGAAAATTTCTTACATTTGGCAGGTTGCCTGTTCACTCTGATAGTAGTTTCTGCTGGTAAAAC
TCTTGTTGAATTAGATCCCTTTGTCAGTTTGGCTTTTTATTGTGCTTTTTGAATTCTGTTTAGACAGCAGTCCTTGCCACATGCCTATATAGATAGTAATGCCTGGTTTCTTCTGAGGTTTCTGGTTTAAGGTATATTGGGCTGCTTTCGCAAAACTAATCATTTCCACCACCATCTACTCACTCCAACACATCTCTGCT
TCTATGCTTGTATCCCATTCTTCACTGACCTCTCTCTACTGCCCCTATTTTATCAGCACAGCCATTAAAGAATAATGTAGATCTATATATACTGGCAGAGAATAAATAAATAGAATAATACAGTCTTGCCACCAGTACTATGTATTGTGTTTGCTGTATGAATAGACAAAGGCTAGAATAATTGCTATTTAATAGAATTA
CTAATACACCTCACAATATAATTTAGTTTTCAAGTAGCTGCATTTTAAAGAAAAACAGTAGTATCAGCGATTTCATTTATATTATGTCAAATTATTTCAACATATGGATATTTTAGAAATCTGAATATATAGTACCTTCTTCTAAGTCTTTAGGAAATCAATATATAACTTATGCATACAACATACTCTTAATTTGAACC
AGTCACTCAAGGTACTAACAGCCATATATGGCTACTGGTTATCATATTGGACAGGCTGAATCAAAGGCTACACAACACTGTTAGAATGGTTTCCTTTGGAGAGGACTGGCTGATGAGAAATAAAATGAAATTTAACTACAATTTCTTTGTTATTGCAATGAATATTTCTATTTTAACTCATAAAACAATAAAAACGGCTC
CAACTACAGACCCTCCAGCATTATTCTAGGTACTTACTAATAGAACTATCTTTTCTGATATCAGATACAATTTCTCTGCCTCAATGATTCTATTGTACTCAAAACCCTCTGCTTTGTATTGTCCTCACTGGTAATCTTTCACTCTTCACACAGCTCACAAATCATTTAATCTCTACACTTCGCCAAACTCCTGTAGCCAC
TACTCTCAAGGCTACAGGTGAGTGCTTTCACTACTCATGTTTCATGATACCAACTGCGGAGGTCTGATTTGGGACTACAAGAAAATAATTCTACTTCAAATGTCCTTATAATCTTGGTTCTTCTCTGGGGGTCCTCGTGTGCAGCAGATGGGGTAAATGACAAAGGTGAACGACAGCGAAATACCGTCTAAGCTGCCACC
TTTGTTTCCTGTTAGCAGAGTAATTATTCAATTGGTACACAGAACAGCGCTGAATACGAACATGAATAATCAGCTCATTTCAGAAATACCATTTTCCCTTGATTCCGATTTCAGCAACTTTCTGTAGCAATATCACAGTGTATTCGTACTGATCCTTTCTGTGATATAAGAAGCATCATCCCAACAAGGCACCAAGTTGT
GAACCTGTAGTTCGAGGTTACAAGTTAATGTTAATACCAATCTTTTGCCGCATTTCTAATGTCCCGACCCAATTTTCCATCAAGATGTTATACTAATTACCCAAATCACGACTTCATATAATTTCTCATTGGACCCGTCAGTAAAACTAATGTTATCTCTGGGAGGCTCCTGTCTGGCACTGAAGCCAACCAAGAGTTAA
AAGCTGGGAGGGACAATGGTGCTGGCTCTAGATCTATTCTTTTAATCACTTCTTAGCCTACCAGATAAGCGGCATTAAAGTTCAAATAATAAAACCACTAACAGCTTGTTCTTCCTTTCCTTCTAGTTTCTGATGTCTGTTTTCTAAGTGAAATCAACAAACAGCAATCTTTTACTTATTTTAACTTGGCAATTACAGCT
AAATATGTCATGAGATATACAGTATCAGGACCTATATGGGAGGAATAACATCCCCGGGTTTATTACCTACTAAATGATGAAGATGTGAAAATTACTCCATTACTTCTTTTGAAACCTTAATTATGATGACCCTGTAATTAACTCTTCTGGTGGCTAAATGCCTTTACATACCTTCTAAGACAAACAAATTGGCCAGCTCT
TGCTAAAGTCAACTCTCCTCAACTTAAAACCAAGTTGGAACTCGTTCAAATTCCACACTATTCTTGCTCTGATTGCAACACATACCCATCATACGTTTCATATTGCTTTTCTGTAAAGCGATTCTAAACCATGTCATTGAGTAATCTAATCTTATATGTAATTTAATTTCAACTAAGTGACAGTAAGCATAATAAATTTT
CCCTAAAAGCTATCTAAACGTATGAAAATATAGTATCAAGCAGTTTTTAAGATAGGATGAATGATCAATCTGCTATCCCAGTATTACACCTGAAAATTAATTAAACTATTCTTTTGGACAAGTTGTAGATAATGGAATAACTCCCGATTGACCCTATTTAGTCATACAGCAAAGATAATTGTCATTTTTCTATGCTTGGC
TTTAGATACAACCTCTCTCACAACCATAGACCATGCTTGTTCCATACAGTTCTAAGAGCAGAAACTGCAATGCTCAAGTCAGTTCTTGGAATCTATGGAAAGGATATGAATCTATACATATCCCATAATTATCTCTGGCTACCCACATCCCACCTGTTGAAACATTATAGATGAAAAGTATAGGAGAGATAAATTTATAG
AACCTCTGTTTCACCAGGTTATCAGTAAGAACAAGTGGCTTTCTTTTCAAAGGAATTCCCAAGTACATTCTGGCTATGCAAAAATAAATCAAAATACCTCCCACAGGATAACAGCAGAGCTTTGCTCTTATATCAGGAACTGTCACTGTTGGACATTCTAGAATATGGTTCTATGCAAGTGTATAGGTCTACGGGTTTCA
AGAAATTAGATGCTTCCTTACACCATTTGGGTATCTGTGCATTTCTGTTCTCACAAATTTGACCATAAGTGCTTTCAAGTGTATAGTCTACAGTAGGTTTTACCAACAGTGCTTTTAAAGGCAAAACATCATAATAAATGAACACAAACATATAATAAAAATGAAGTGTTGCTTTGCAATGCCAGTAGATATATCAAATT
GGGATACAGTTCAGCAAGTTCTAACCCGCTAACTCTGGAACTGGCCATTCACATTTAAAGTTCCAACAAAATCTAATACATAATGAAAGATAATTTGAAAATAAAGATCAAGTATAGCCAACAGTTCTTTCTTTTAGCTGCTTACAAGGTATGTTCACAATATGCTAACATAATTCCTCAAAATGTTTTGCCACATATGT
AAGAAGATCTGCATCCCGACACAAAGGCAGTGGAGCTTATTTTCTCTAAATTTTACATTAAGTAAAACTTCAAGAAACCAAGTCTTTTATTTTAAAAATACAGGTAGTGCTACCTTTCCTTTCAATTACAGCTCCATCAAACTCATACTTGATGGGAGAGCTTATGGATGGAAGAATATCTTCATGCGTAAGCTGATAAA
TATGGATAAATGTTCTATAAAATTTATAGTTGACTCAGGAACTCACTACCTGAAGGATTAAGGACATCATGAAATTCTGATGAGCAGACATAGTATTGGGGAAAGCAGAAGGGAAAACTATGACTGTATGTACAACTGTTTACAAATATAAGCAATTAGAGTGTGAGGTGCAAGTTTTAGCATAGGGATATAATTGCTGT
TGAATTAGAATAGTGGTATGACAGGATATAGCAGATGGGACTGAATCTTGGACTGAAGGTCATTCTGCTCATGAATAACAAGAAATGTGGTGTTGCTTCATGCATTAGCGATACATATACATGGTACATGCAAACATACACACAGTCCAAAAATGAAATAAAATAATACAGATAAAAGGCAAGATGAACTCCCAATCAAG
AGGACTGATTGGCTTTTGCTATTACCAAAGTAAGTAAGTTAGAGCTACAAGTGGTAGTGGACTTTAATTTTCTAATGTGGCTGAAAAACTTAACAGGCCAGATATATAAACCGCTTGCTTATGGTGGAATGCTGAGGAAAATTCTGGTACAGCAGCGACCTTGATTTGGTTCTCTCTAGGACTCAGTGAACGTGAAGCCA
GACATGGCATTATTGGTTAGAAAATCAAGGAAGGCCAACCGGTGGCTCAGCCTGTCTAACACTTTGTGAGGCAAAGTGAGGTGGATTGCCTGAGCTCAATTTGAGACCAACCTGGGCAGCCTGGGTGAAACCAGTCTCTATAAAAACACAAATATTAGCAGATGGTGGTGTGCACCTGCCTTGGTTCCACCTACGCAGGG
CTGGTAGGAGGATTGCTGACTGGGGAGGTTGCAGAGGCCTGATAAGCTGCCGTCTCTATCACTCTCCAGCCTGGTGGCAAAGAGACCCTGGCCACACAAAAAGAAAATCAAGGAAACTGTAGCATCTGCATTATTTCTGACCGCCCTGTTATTGGCAACATACAGACGGGCTTGAAACAGGCAACCATTCCTTTTATCAT
ATTTGGTTATGGCGTGGCTAATGTCTTAAGCATATCAACGGAGCCACTGCTCTGGTATATACTAACTTTAGACTCGAAACAAAAATTTTAACACAGAAATTGAATATTACGACGCCTTTCTCTGGCTTTGCCAGGATATGTTTGATAGAAGACCCTCCACGCTGCCGTTGGGTATTTATTTCAGAAGGCTTCCGCATGGT
GTTGTTACCCAGATGGGCTGCTCCTTATTTAGAAGCTTCTTTCCGTGGAAGCCTTCTAGCAAAATAGTAAGAGATTCAAAATGAAATTGTTTAACTATAATTCTCCTACAAGGCAAATATGTTTCACATGGGACTTACATTTATTCACTGAAAGGGTGGAGGTGGGGTTCCGATGAATCAGTAGGCTGATTTTGTGAATT
TATTTTCTTGTCAAATTCATAGAAAAGTATGCTTCAAATCAAAACCTGAAAGACACAGACCACAAAGTCAGCGGGAAAAATCTAACATCAACATATCAGGGTAACAGAACTTTGATTTGATCACAATTTGATCAGGTGGTATTACTGACAGAAAACTATAAGGTGAAATTACTTGGATTGGGTTGAAGAAGCCTGCTGCC
TATCCCTGAAGCACTGATATACTACTTCAGAACTTATTAAGTATAAGAACTTGGAACAGACTGGTAATAGCTAACATTTATTGGCAGACTGAGCACAAATGCCTGGTTGAGAGTGAGTTTATATCATGATCTCTTAGCATCATCAAAACTCCAAGAAGTAAGTACTGATGAAATCGCCCATAGCTGCAGAAAGGAAAGGG
AAGTTCAGGTTGTTGGAAGTAACTTGATGAAGGTTGTGCAACTAGTAAGTTCGACTTGGGATTCAAATCCAGGCTGTACGGCTCACCGAGCGGCACTTTCTACCACCCTGCTAAGCTGGCTCTGAACGCTGGCATGCTGCAGGAAGAGGATAAGGAGTGAACACTGGTCAGTGGACCTGGGCTTGATAAACTACTCTGCA
GGAGGGCTGACATCAGCTTTAATCTACATCTGTTGACAACCAAATCTACTGTCTGCAGCTGTGCCTTAGCAGGAAAGCAGGAACTTTTGGTACAGAAAAACGAAGTTTGTGCTTAGTGTCCCAATTTAATTTTCCGCTGAATGCGATCCTTTTATGCCGGAACGAAGCTGGCGAGCTGAGCTAGAGATAGGTTCATGGTG
AAACTGAAGTCACTTTCACTGAGTACAGGGCTACTATAATACAAAAGCCTGTTCTTTCAACATTCCTTATATGCAGGCCAGCACCATTTTGAATGCAGTGGAAGAAACCTTCAAAATGGGGCAGCTCTGGGGATGCATCTAGGGGCAGAAGGAGAATTATAGTCTATGGTGGCTGACGCGCCATGACCTGAATATTCTGG
CTTTCGTCCTTAAAGCTGGGCAGTTTTCCTAACCTATCCCTGTGTTCCTCTGAAAAATCAGCTATCGGGGCTTAAGGGTGGGTATTTTGCCAATGGCCACTTTCCTCTGTATCAATGTCAATTCCTCGTTGAAATGAAGAAGAAAATGGCTGAGTCTTTAGTTACCTTTCACCAGGCGCAAGGACGGGAACTTCAAACAG
TGTTCTCATCAGGGATTTCAGCGGCATTCTCTGATCAGTCCCCAGACGGGTGCAGCCACTAAGGTGCAATCCGCGCCTTACTGCTATGGATAAATGTTTTACTGGGATCATATTCTCCTTATCAGGTTAACAGAAGAAGGTCAGATCACAAATATTCCAGATCTCTAACAGGAAGCACACATACAGATCGAGGGGTCGTA
TGGCGGTGGAGGTGATGCAGAGGGGAACTAAGTGAGAACTCTAAGGCTGATGAACCGTGTCATGAGCCTTGATCTGGGATATGGCCGTGCGATTATACTGCGTTCAGTCTATCTCTCAGACGGCAGGACCTTCAAATTCAGCAAAGGTAGATTCCTCAATCCTCCTCCTTTCACTTGGCTGGAAATTCTACCATTTTCAA
GTCCAGATCCGCATTGTCCAGGCTCTGAAGCATGAGGAATAAAATAAGTAGGATGGTTTGTCCGTAAGCACAGATTAAATCACAAAATAATAACTTAAAAATAGTGATACTGGTATTCTGAAAAGCATCTACAACTCAGTATCAGTTTAAAATGTATGTCTTGAATAAACTGCAAAACAATACCATGACTAATATAAAAG
TGGTTTGGTTCCAAGTACAGCCAATTGAAATAGGAGAGTGAAGCAAGTTAGCTGGGGCTTTAATTTATTATGTGTATAACATATTCTCCCTTTTTGATGCCTATAGTTATGTCTATAATAACTGTTTGGATGTGGTGATCCAGAGCTACAATACTTGTTTCTATTCTTGGCGTGTAACTGATTTAATACATAAATTTTGT
TTTCTCAAAGCCTTGCCTCTGAACTACAAGCTCATGGGGCAAGAGGCGGTCATGCAGGGTTTTATACAGCCAGACCCAGCACTTTCAGGTCTGGTGACCAACAATCAGCACTGTACAATTTGCTCAGAGGCTTCCCTAGGACTCAGGACTTCCAATGCTAAAGACTACTGGAAGATCCCAGGCAAATGAGCTTGCTGGTC
ACTCTGGTGTGGTAACGTAGACTTCACAGGCAAGAGGTATTTAATGACACGTGGAACTGGACTCTTTACCCACTAACTGAAATATATTACTTGAAAATGAAGCCGAAAATCTAGTTTTGCTGGTGGAAATCCACTTCTGAACCTTTAGCTTTGTCCTCTGCATTTCTTCTTCTTTCTGTCTTTGGCAAATAGGTTACAAA
AGGAAAATAAAATAGTGATGAAAGAAAATAGATATAAAATGGAAAAATGTGAAAGCGCAACAAATAGACTCTGGATAAGAAAATTAATGGTACTGTAGAGAAAAAGAGAGGAAAAATTATCAACTGCGATTATAGCAGCCATGAAGATGTAGGAAAACTCCTTGATTGCTAAGTCAACACAATATAGATTATTTATACTA
AATATTGGTTTAAAGTAGTTTCAGCATAAATTTAGAACAAAAGTATATTGCTCTCTCACACAAACACAATTCTTGAAGACGCCTTTTGTAAATGCTATAGCGAAGCCTATTTGTGGGTAGAAGATTTAGAAATTGCTCACCAAAGGCGCTTTTCGGATGCTCCTCACCGCCAAACTGGCAGAAAACAAATTACCTCAAGA
CATCCTTCTCTCCTTGTCATCCTGGAAACCTTCTGGACCTCTGTGATGCAAACACTCCATCCTCAACTTCTCTGGAATGATATATAAATACTCTCAGTAGTTCTCTTGTGCATTGCAAGTACAGAGGCACTTTGTTTTGTTTTACTTTTGCAGAGGCGGTGTACTGCTCTGTATTGCCAGGCTGGAACACAGTGCCGCGG
TGATCTCGTCCTGCAACCTGATCCTGGGTTTAAGCAATTCTCGCCATCAACCTCCTGGTAGCTGGGATTTGGGTGCCGCCACCATGTCCGACTACTTTGTATCTAGTAGAGATGGTTTCTGTATTTGGTCAGTGCCGAACTCCTGACCTCATGATCTGCCACTGGCCTCGGTGCTGGGATTACAGGCGCGAACCGCTGTG
CCAGCCACCAGAGAACGCTAAAAACAATATTGAACCCAGGCCCACTCAGGACAATTAGAAACAGAATACAGGTGAAGCCAAACTCGTGGTTTCGGTGATCTGACATAATGCACATTTATTAAAATTAAGTCAACTGCAAAACTGGCTGGTCCTAGAACGCTATAACCCTCTGTTTTATTTATTTATTTATTTATTTATTT
ATTTGTTATTTTGTTGTTATTTTTGAGGTCTCTACTGCAGGCTGGAATGCGAAAGTACGCGATCTAAATACCAGCCTCACCTAAAGTTGGTGATTCTCTACTCAACCTGAGTAACTGGGATTGTACGCCGACCACCCAGCAATTTTGTATTTTAGTAGGCGGTTTCACCATGTTGGCTGAGCTGGTCTCTAAAACTACGG
CCTCGTGATCCACCTTAATATATAAACCTCCCAAAGTGCTGGGATTACAGTAAGCCGCGTTCCTAGCCTAACCCTCTTAATGAGTCATATTCTCTCACCTGATAATTTTGGGTTGGTGTCTGTATTTTCTAATAACACCGCAGACCTCTTTCTCCTTCTCCTCAGACAAATGCTTTCTCCTTTGAGCTCCGGCATTGGGA
TCACCATTTCCTCTTTCTCTACCAAGATCGCGTACTGTCCTCCGAAACTTCCAGAATCCAGATAATACCTGGCTCGCAGACTTTCTCTCCCTCGGTCTCCTGCATTAATTTTGGGTCCCTTTAAAGTGCTTTGAAACAGTCATACCTTCAGCTTCCTCATCCAATGACATTTCCCCTCCTCAGCCACCACTTCCTCAGAT
TTTGCTACAGGACCTCTAATTTATACCTGGATTTTGTCCTTCTTAGAAACACCACCACTTCATAAACCTCTACTAAACTCCCATACCCGACGCCTTATTCCTTCCAACACTTTCATTATCCCATTGTAACTGTTTTAATCTGATGGAACCTCCAGCCCGTGATTTCTCTGTTTCTTACTATCCGTCAGCCCCTTCCTGCT
CTCACTTCCTTTTATCAACCGTGCCGCTGCACGAAACCAGAACGCCTCTGTTCTTCCGTGGCACCTACCTGGCATGCAACCTCAAGTCCAACTGGGTACGCTGCAGCGCCTACCTGAGCAAGCGGGGGTAAGCCTTGCACTACAACCAGATATGGCTACCATTGCTATGCATTACAGTGCCAATCTCAGCCAGGTCTCCT
ATCACTGGAAGCAACTGGGTCACCTACAGTCGTGATCTCCTACTACTATACCAGAAACAACTGTTCCTACTCATTTATCTCAAAATTTGGATCCCCATCTTCTTGGCCTCTTATTACAAGCAGAATGCTTCAGCTCATACTTCAGAAAAATAAAGCTATCGCCGACTTGTCTGCCTTTGTACTCATCTCCTTTCTACTAC
GATACCAAAGAAGATCACTCTATCAAACCTCCTTCTTTTAGATTACAACCTCTGATTCTCTCAGTAATCGCACAGCTAATCCTAGTACACCCCATATCATAACGCTTTCCTTTCACTGCTCCTCCATTGTACTAATGCGTATTCAAGTCCTTCTCTATACAGAAAACCAAAATCTTCAGATATCTAAATTTACTCAATTC
CAGTCATCTCCTTCTTCCTCCAGTCCGTTCTTTAAAAGACACGGTCACCAGACTTCCCATTTCTCGCGAATCCATTCAACACTTGACTTTACCACTACTTATGCAGTGCTTTAGTTCACCAGCAACCTCATCCCATGGATTATTCTTCAGTCATCTTGTGACCTGACAGCGAAATCAACAGTTAATCAGGAGAGCATTAT
AATCCCTTCAAAAGCTATGATTACCATATAATCTGGTTTCTCTCTAAATACATAATTTTGGTGCCTTTGGTAATATCTTCCTCTATCTAACATTTAAAACTGGGTTCCTCAAGTTCAAACATAAATCTTTTTCTCATTACCAGTGACCTCCAGTAGGACTTTCTGGCGACTATGGGCGTATACAAACGCGATTGCTGTCA
ATATGGTAGCTAACAATTTGATATGTGACTACTGCAACTGGGGACTGAATTTCATTTTATTTCTAGTGCACTAAATAGGCTTTCTTAATGACAGTGGCTGCTGTATTGAATGCTGATCACACACAATCACATCATCTCTTATGATTTTGAATATCATCGTGCTGGTATTAGTGACTTTCTTCGGTCAGGTCGCATTCTAC
TTGCCAATTTATCATCTACACTCAGGTGTCTCAAAATCTCAGCCTTGGTGGGTGGCTCATGCCTGTTAATCCCAGCACTTTGGAGGCGGGTGGGCAGATCACCTGGCAAGTCCGCGGGAGTTCCAGACCCACAGCCACAATATTAGTAAACATCTGCAAAGTACAAAAATCAACTGGTGGTGCCTGAAATCCCAGCTACT
CAGGAGAGCCAGGCAGAATATAGCTTCAGCCGGAGGCGGGGTTGCAGTGAGCTGAGATATACCTCCAGCCTGAGCGATAAGACAGGCTCTATAAAACAAAAATATAAAACTAAACGCGGCTAAAACAAATTAATGACCCTTCCCCTTGAGGAAAACTCATTCTTTGTGCGTGTTCTTATTTCTGCAAATGGTGCCATCAT
CCACAGTCATGTCAGAGCAGATTCATCCTTCCTCTCACCCCTTACACCCAAACAATTTCTATGGTTTACCTCCAGCATCTATCAAGTCATTAGCTTCTCTTCATTACTAAATACCTGCACTCTCAAACACACTATGAGCAACCTCTATTGGTCTCTCTGGCACAAACGCAATGATGACACTTAACATAAAATCCTTCTCG
GTCTCCTTTGAAATCCTCAAAGATTCAGATTTAAGACAAAACACAGATCCTGCCAGATCACTAGCCTGTTTTCTTGCAACCAGTGCCCAGACCTGTTTTGGCCTGATTATTATCACTAAAGAAAAGTGTCAAGCTACTTCCCAGCCTGGAGCCTTGTGATTCCCTTTACCTGGTAAGTGCTCTCTCCCATCTTATGCCAC
CTCTTGCCGCCCTCTGGTCTCAATTTAAATGTCAATTCTTGGTCTTCTGACCACCTCAATATACTTACTCTTCTCATAAACTCTTAGTACTTTTCTCAAGAGCATTTATTAAACTACAATTATCTGGGTGTTGGCTCACGCCTGTAATCAGCACTGGAGAGCCAAGGCGGGCAGATCACGGTCAAAGATTGAGACCATCC
TGGCCTATGGTGAAATCCTGTCTTCACTAAAAACACAAAATTAAGCCAGGCATGTGGTGGCGGGTGCCTGGTCAGCTACTGGGCTGAGACGGAGAATGGTGAACCTGCTGGGCAGACTGCAGTGAGCCAAAGATAGCGCAGCTGCACTCAGCCTGGATATTGAAACAGACTCCGCATCTCAAAAAGACAAATAAAATAGT
ATCTATATCTTATCAGTTTAAAGTCTAACCTATCTTCAAATCTTAAAGTATCATGACTGTACTGCTTTCTGCTATCCCTAGAGCCTAGTGCAGTTCTGGCATAAAAATAGTCATATTTTATGGATAGATGATTAGATATAGGTATCTGTGAGCACTAGTACTGAATTACACAGAAGCAAGAACTAAGTAGGGTAACAACT
TTATCTTGGTTCTGTACTGATTCTGCCACAAAGATGCCTGAAATAGAAGGCACTCAACAAATATTTGTTGGACAATGGATAAACAAGTTGTAGTTTAATTTTAGGAAATTAGTACAATACAGTGTACCAATTGGTCAAATAAGGAAGAATATAAAATCATCTCCATAAATACAAAAAGACATTTGCTAAAATTCAGTATA
CATTCATAATTTAAAAATAAACTTGAAATATAATGCAGTTTCTTATTAAAAACACATAATCAAATCAGTAACAAGTAATAATGTCATTAGGTGAAATACCGCTTGAGGCATTCTCACTGAAATCAGAATGAAACAAGAACATCATCATTTACCACTGAATCTAAGGAAGATTCTCACTGGTGTAATTACAGCGATAGTAT
TCTACTGAAAGAGACAAAAATTATTATTTATAGATATGGGTTAGCTACCGGAAATGAAAAACAAAATGAAAATAAGGTGTAAAATAAATTTCCAGTAAACAGCTGGATTAAAGATAAATATCACAACTCAGCTTAGCTATTTTCTTTATACTAGTAATAAACAATTTAGGACATGAAAAACCTCCTGTAATGGCAACAAA
TAAAATCCTGCGAAATACTTAACCTAAAACTATATATATTAAGAAACTATAAAATTTTAATGAAAGATATAAAGCCTGAAAAACAGATATATCATGTTCCTTGACAATGACTTAATTTTATAAAGAAGTTAATTTAATACAAATTTGGCACAATTCACTAAGGTATGAAATATTTGGTTTTTAAAAGCATATTATAAAGT
AATTGTAAATGACATGAAAATAGGACAATATAATGTTAAGTAGAGCAGGATAAAACTGCATATGAAGTTCAATTATGTAAAAATATAAAGACTGGAGGAAATACATAAAAATGTGAAAACCACAGTGGTGATCTCTAGATTGCAGGAAAATAATCTTAATTTGATACTTTGGCTTTTCTGAATTAGTAAATTGTATATAT
TAATAGAGATTATGAAAAATTATTTAAAGCATTTAACACAATATCAGACAATGGGAAAATGCATATTTACATTAAAATCAGGCCACCTAACAACTTAAAGATCCTTCCTGCAACCACCGTCTTCATAAAGGTTTATGCTTAATGAAGCCCAAGGATCAAGATAAATGTGGACAGTGCAAATACTATAAATGGGTAGAAAC
AAAGTTTTATTCAAGTGGTCACCACCTATTTTCCCCTATAGCGGTAATGCTGAACTCTGGACATAGCAGCTTGTAAGCTAATGTAAAGCGGCCACAACAAACTAATGCAGTGGTTTCTTATAAGAGAAAAGGCACAGCTCAGTTTAACTTTCAGCTTGAATCAAATGCCTCACATCAAATACAGGACCTTTCCATCTTCT
TCAGCAGCAACAGTGTCAGTTGTTATGGGTGCTTTTAATTTCTGTTTGCTTTTTAAATGTTGTTTGCCTTCTCTTCTAAACTGTTAAGAAATAGACATTAAGTTACTTCTCTCTTGGATTACTTGCAGCTAGGTTTACCTGACCTTTCAGACACAATACTTTAGACTTCTAAATTCCGCGACCAAGGGAAAAACTCAAAT
ATAGAAAAAGCCTATAAGAATACAAATTAATAATTGTTAAGGAGCAGGACTATCTAAACAAAAGTTATGTAAACCCTAGTCCCAAGCTCAGTGCCAGTTCCTCATCAAGGATCGAAAAGCAAGAGATAAAGCCAACCCATTTGATTTAGATTCATGTGGTCAGACTCTTTCCTTGTAACCTCACAGTAGCATGAGGTGCC
ATTTCACTCCATAAAATAAGTACAATAGATGATAAACAAGAACAGTTTGCAGAAAGTCAAGATGATTTAGCTTCAACAGATAAAAATGAGAGAATGGAAACATTGAAAGAAGATCGTAACCCTCTAATAAAGGATGAGGATGGGGCTTAAATAAAGACCATTTTTAAAGAATGCCTGGACAAACATTAGGGACTCTTCAG
CCTTCAAAAATACAACAAATAAAGAAAATATTATGACTTAACACACAAATTTAAAAAGAAGGGTGGGAAAAACTTAAATGTAATAGCAGTTAAGTAATAAAACTCCACCAATAAACCTTATGCTTTCAAACATCAGCCCTTCTACAATTATCAGTTCAGCAATGATTCGCTGGTAGCAACATATTACTGGTGGCTCACGG
AAGTTCAGCGATAGAAGGTGGATCGTATTTTATTTTATAAAAGATTCTTACAACCACCTGCTTTTCTTAAACCTTCCATGTTTTGGAAGTGAGGTGCTAATTTGACATGGCTGCTGGAACTACCAGGAAAGATGGAAATAAAATGTACTTCAAAGATTATGTAAATGCGGTGAGTGTTCAGTAAATATTTGTTGATAAAA
TCAAGCACATTCAGAAGATACTCACTGTTGACTATGTCAATCAAAGTTTCTTCATACCGAGGAAAAAGAGTGGATTAGGAGAAAACCATACTACAACAAAAGATACATACTAACTAAATAACTGCTTCTCTCAGTCACTACTCTAGGTCTTAGAACATATTTTCATCCTTTACTAGTTTAATATTTTTGAGAGTTTTTAT
AGCGCGGGTTACTACAAGACGCGAGCAATCAGCTAAATAAAAATGAACTGAAGAAGTAACCAAATGGAACTCCTCAGCAATCAGCAGAATGAAATTAATGGTACAGGAACATAACAGCATGTTAGGTCGGCGAAAGCAGTTTAATTCCTTGCTTTGTAACGTAGTTTAACTCTGGGTCCGCTGAATACTTTAGACCAACA
GAAGGCAAAGAAGTGACTGAAAGCCAGGGTGGAGTGCTTTCTTAACTCAGATCTATTCTCTCTCTGAAGAATTTCCCAGTGATCTCATCACCTCTACCCATGGGGCAGAGTATACCAGTTACAACTTTACCTGTGGGCCCAAGGCCACCGTACTTAAACAGGGTGCAAAACGGTCTGCAGTTTGAATTTCTCTTATCTCT
CAATGGTTCCTGGACTTCTTCCTTTGCAACAAGTGTCTGGGCCAACATCTCTTCCTCTGATTTCTCTGGATTTGACCAAGTACCTGCAGACCCTCCTGGCTAATTGAACTCTGTTTGCTGACTCTTTAGGATTAACCTGGATCTACCGCGGTCAAATGGGTAGTCTCTGCCTACCTCCTCCAAAGACTGAATTGTTTATT
TGGCTCCGTATAAAATTTTCTTAAAACGCTGGCAGGAACCGCTCCTTTAACACTAAAAGTGGTCTCGATATTATTATTGGGATGATTAAACCGCAAGGGGAATTGGGGCATCAAGACATGAATGTGTATGCCGCCTACTGTTCTTGTTAACTTTTAGTTGTAAAACCTGGTGTTTACAGATGGTTTCTTTCTTTTTGAAG
GCAGGTCTGCTCTGTCACCAGGCTGGAGTGCAACAGCGCGATCTACGACTCTACAACTCAACACTCCCAGGTTCCTGCATTCTCACCTCAGCCTCCAGTGATTTGGGATTCAGGCACCGCCACCATGCCCGGCTAATTTTGTATTTTTAGTAGAGCGGGGTTTCAGCCATTATTGTGGATGGTCTCAATCTCTGACCTTG
ATCTGCCGGCCTCCCAAGGGTATACAGGATTACGGTAAACCACCAGCCTTGATTTCTTTCTTGAAGTAGCCTCACTCTACACCCAGGTTGCGTGGTGCTTTGATACGGCTCACTGCAGCACCGAACTGCGGGCTCAGCAACCTGCTGCTTCAACTCAAAGTGGCTGGGATTTGCATGCCATCTGCCTGCATCTGGCAATG
TTGTTTAATTTTATTTTTGTACGGGTAAGTTATAGTATTTGGCTGAATGGCAGACCCTGAACAACAATCTCTACTAAGCTTCAAAATGTTGGGATTGCAGAATTTAAACCGCCATACCAATACAGTTTACAAAATGATACGGTCAGGAAATAGGGGTAATCAAGTAAGTCTTCCTTTAGTCATGGGAACTCGTTGCATGT
ACGCA

Hi Heng,
thanks for pointing this out. We will look into it.  It certainly has something todo with the score functions.
Can you say where the sequence is from and what source of error you simulated? Just curious since you used bwa (pacbio mode ?) and ngmlr pacbio + ont although bwa has ont as well.
Thanks
Fritz

This is real ont data. I don't know the true mapping position. Both pacbio and ont2d modes of bwa-mem give the same alignment.

Hi,
I just tried to reproduce this. I am using the source version from github and I am getting these alignments ending with 75S. I think that is what you pointed out?
I recognized that we changed the score function a bit from 2.5 to 2.6 version.
ONT: .....2I3M1D9M1I3M1D2M1D2M1D4M1D9M1I16M3I11M2D3M2D13M1D16M1D3M1D14M11D5M5D15M4D3M1D2M2D11M1D32M2D3M1D2M1D11M2D18M1D28M75S
Pac:
....2M3I11M2D3M2D13M1D16M1D3M1D14M11D5M5D15M4D3M1D2M2D11M1D8M1D1M1I22M2D3M1D2M1D11M2D18M1D28M75S
Thanks
Fritz

Philipp noted that in the release:
"Match score reduced and low quality split + short inv detection enabeld for -x ont"
which is probably the reason the ont alignment breaks now earlier.
Please let me know if you find other things. I really appreciate the feedback!
Thanks
Fritz

I was using 0.2.5 and have upgraded. 0.2.6 does give the expected results. Sorry for the hassle. I am closing this as this has already been resolved.

Thanks Heng!
Mike
On Tue, Aug 1, 2017 at 11:19 PM, Heng Li notifications@github.com wrote:

Closed #31 https://github.com/philres/ngmlr/issues/31.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/philres/ngmlr/issues/31#event-1188800220, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAL983zS13hN8cY_zG1hlLUIoFVEBdMjks5sT-rZgaJpZM4Oqf9R
.

authors: fritzsedlazeck lh3 mschatz

repo: philres/ngmlr


text:
warning generated using Catch in g++-4.7: suggest parentheses around comparison in operand of '=='

Hi,
The following warning is generated in my project using Catch in GNU g++-4.7:
/build/fuzzylite/test/BenchmarkTest.cpp: In function 'void fl::____C_A_T_C_H____T_E_S_T____32()':
/build/fuzzylite/test/BenchmarkTest.cpp:85:13: error: suggest parentheses around comparison in operand of '==' [-Werror=parentheses]

It would be great to be able to compile the tests without generating such a warning.
Project: https://github.com/fuzzylite/fuzzylite/tree/master
Commit: https://github.com/fuzzylite/fuzzylite/tree/d095efce076549b435ea5f9e21addf8a7346965c
Travis failing job: https://travis-ci.org/fuzzylite/fuzzylite/jobs/137058960
Thanks for such a great testing framework!

https://github.com/fuzzylite/fuzzylite/blob/d095efce076549b435ea5f9e21addf8a7346965c/fuzzylite/test/BenchmarkTest.cpp#L85
That == true should be deleted, it is invalid if I give you any truthy value instead of true.

Thank you very much for your feedback. Unfortunately, there are other cases where I am being required to enclose in parentheses different kinds of statements. For example,
https://github.com/fuzzylite/fuzzylite/blob/d095efce076549b435ea5f9e21addf8a7346965c/fuzzylite/test/activation/ThresholdTest.cpp#L31
https://github.com/fuzzylite/fuzzylite/blob/d095efce076549b435ea5f9e21addf8a7346965c/fuzzylite/test/activation/ThresholdTest.cpp#L36
and so on, thereby requiring checks in the form CHECK(( a == b )) to use double parentheses in order to avoid triggering a warning. It seems a bit silly to have to use double parenthesis in such cases to avoid a warning.
Would it not be possible to do such an enclosing in Catch instead? Hence, addressing this issue in g++-4.7 and possibly earlier versions of the compiler?
Thanks again!

I'll try rolling back g++ on my arch box and looking at that.  I'm in no means a Catch developer, I'm just trying to help if I can.

Thanks for your help!
You could use my .travis.yml and Dockerfile file scripts to configure Docker to run with g++-4.7, without needing to roll back in your box.
Just clone my repository in master branch (https://github.com/fuzzylite/fuzzylite/tree/master), and issue the following commands:
export CXX_COMPILER=g++-4.7
docker build -t fuzzylite -f Dockerfile --build-arg CXX_COMPILER=${CXX_COMPILER} .
docker run -e CXX=${CXX_COMPILER} -e FL_CPP11=${FL_CPP11} -e FL_USE_FLOAT=${FL_USE_FLOAT} -e FL_BUILD_TESTS=ON --entrypoint /bin/bash -it fuzzylite

The docker run will open bash for you on my projects root, where you can issue build.sh release to build the release of the software.
Thanks!
Let me know if I can be of any help.

We can't put it in parentheses within the macro as this defeats the expression decomposition (so you won't get LHS and RHS values separately).
I use this to suppress the same warning with clang:
#define CATCH_INTERNAL_SUPPRESS_PARENTHESES_WARNINGS _Pragma( "clang diagnostic ignored \"-Wparentheses\"" )
Is there a "gcc diagnostic ignored" version? And if so from what version is it available? I'm happy to put that in but I don't have easy access to gcc at the moment to test it.

https://gcc.gnu.org/onlinedocs/gcc/Diagnostic-Pragmas.html
Same thing but replace clang with GCC

Ha -> Arch Linux Archives don't go back to g++ 4.7!

_Pragma() will not work for g++ (only gcc) in complex macros - see this

Can we just wrap the entire header in a #pragma push pop for this?

@czipperz if you pop the silenced warning at the bottom of the header - it will not affect code generated from a macro in a source file - so it either has to use _Pragma() or it has to be left enabled even after the header

Many thanks for your help!
Since the warning is raised only in g++-4.7, I decided to ignore the warning from the CMakeLists.txt by adding the following:
 if ("${CMAKE_CXX_COMPILER_ID}"  STREQUAL "GNU")
    if (CMAKE_CXX_COMPILER_VERSION VERSION_LESS 4.8)
        set_target_properties(fl-test PROPERTIES COMPILE_FLAGS "-Wno-parentheses")
    endif()
    endif()

I am happy to have this issue closed.
Thanks.

-Wno-error=parenthesis is another way

FWIW this is still a problem with v1.7.1. To be precise, it's a problem with the g++ versions from 4.4 to 4.7, inclusive. There are no warnings with 4.2 (I couldn't find 4.3 to test) nor with 4.8, 4.9 and 5 (I couldn't test 6 because it segfaulted with an ICE on my simple test, I'll look into this separately).
So I think it would be reasonable to add
#if __GNUC__ == 4 && __GNUC_MINOR__ >= 4 && __GNUC_MINOR__ <= 7
#    pragma GCC diagnostic ignored "-Wparentheses"
#endif

to include/internal/catch_suppress_warnings.h. This would make CATCH usable for people forced to use these versions of the compiler (because currently it just isn't, until you add -Wno-parentheses to the compiler flags yourself).

Interestingly, this is already suppressed but for C++11 only (can't tell you why).
The problem with pragma-based suppression though is that it also forcefully turns-off that warning for the entire TU.

I understand the problem with suppressing the warnings in the entire TU, but IME this will end up being done anyhow when using one of the affected compiler versions because there are just too many useless warnings otherwise.
And doing it for C++11 doesn't seem to make that much sense because gcc < 4.8 didn't have full C++11 support anyhow, so the vast majority of people using C++11 with gcc wouldn't be affected by this warning even without this _Pragma.

@horenmar did some more experimenting and found that _Pragma is supported back to at least GCC 4.6. He wasn't able to try 4.5, but 4.4 didn't work (if anyone else is able to confirm one way or another with 4.5 then please let us know).
So we're going to extend the use of _Pragma back to 4.6 (or possible 4.5), leaving only a couple of older versions in the not-covered range. If anyone else complains about these ones we'll consider the whole-TU-affecting option.

@vadz The reason for using _Pragma is that in theory it lets us apply the pragma to single line, where Catch causes the warning, while letting the warnings be in rest of the TU. The reason why it is gated behind C++11 is that it was added to the language at that point and there was no testing done to see if earlier versions of GCC support it as well. Standard pragma is of no use, since we would have to let the suppression be enabled.
The good news is that I did some testing and gcc versions 4.6 and up support _Pragma.
The bad news is that there are some bugs in gcc's handling of _Pragma pre gcc-4.8, so it is useless anyway.
At this point we will probably end up just force disabling these for pre 4.8 gcc, and use the _Pragma option for post 4.8 gcc.

_Pragma was new in gcc 4.6 according to the docs.
Right now the compiler which troubles us is 4.5 (yes, don't laugh please) under some ancient CentOS that we need to support, so it won't really help here. So I still think we should use _Pragma if we can and disable the warning globally otherwise.

Seems fixed when using GCC 4.4. Thanks.

https://github.com/philsquared/Catch/issues/674#issuecomment-225896777

-Wno-error=parenthesis is another way

Typo: parentheses

source: gharchive/issue

authors: czipperz horenmar jcrada mloskot obfuscated onqtam philsquared vadz

repo: philsquared/Catch

license_type: permissive

license_source: github-api


text:
help: basic example for the web browser

I try to make a simple web page that : loads sql.js-httpvfs, open the database, have an input text where to enter the SQL query, a button to run the query and an a js function to perform the query and display the result.
All the material I can find here is using node to build the logic but I just want plain JS in an HTML page.
Is there a way to have it in the browser ?

Is there a way to have it in the browser ?

You can compile your Node.js code with weback 5 and run it in the browser.

Hi @setop,
Have a look at the example from the README. Does that work? If not, what would you like to see that's not already there?

Ok I see. I think you're essentially asking for a beefier demo than the one supplied in /example.

authors: jaylinski luciferous setop


text:
Extract a "renderable" module

All the logic around rendering and passing buffers should be extracted into a module that can be included in non-SGML classes. This will allow people to craft special Phlex-renderables that don’t have all the HTML tags on them.

Closing as a dup of #618

repo: phlex-ruby/phlex

license: MIT


text:
mp2 audio decode error

when there are 2 channels(L+R) in the auido, and if the L channel or the R channel is silent,  then the decoded audio is silent using mp2 decoder. but if both the L and R channels are not silent, then OK.
how to resolve this? thanks very much.

Do you have a sample file that show this problem?

yes, of course.  please check the "sample_file.zip" file.
waiting for your help, thank you very much.
sample_file.zip

Thanks for the bug report. That was quite something!

great！ thank you very much!

authors: phoboslab xyhweinin

repo: phoboslab/jsmpeg

license: mit

license_source: bigquery


text:
Add support for custom source

I added custom source support. The following code is example.
// Constructor
function CustomSource(url, options) {
  this.progress = 0;
  this.established = false; // set true when established
  this.streaming = false; // or true
  this.completed = false; // set true when completed
}

// Interfaces
CustomSource.prototype.connect = function(demuxer) { /* snip */ };
CustomSource.prototype.start = function() { /* snip */};
CustomSource.prototype.resume = function(secondsHeadroom) { /* snip */};
CustomSource.prototype.abort = function() { /* snip */ };

// Create a player with custom source
var player = new JSMpeg.Player(url, { source: MyContomSource });

Nice, thank you!
In the long run, it would probably be a good idea to do this for all components (muxer, decoders,...). Though maybe an easier way to subclass the JSMpeg.Player would then be cleaner, instead of feeding the stock Player all components through the options. Not sure how to go about that. Maybe it's not needed for the other components anyway!?

source: gharchive/pull-request

authors: nulltask phoboslab


text:
Can I use TypeScript on Phaser 3?

I found there was no TS definition file for Phaser 3 now.
So it means Phaser 3 have no support for TypeScript?

TypeScript is supported but just wasn't ready by the launch.

The relevant issue is #3047. Unfortunately it was closed before actually being resolved.

I haven't tested everything yet but using my modified version of Antriel's official (WIP) Phaser 3 typescript definitions build, I was able to get scene properties (plugins) to work using a hacky generator by stepping through Phaser code with the browser debugger, converting any useful runtime data to JSON, writing it to disk, then converting it with a simple script, and injecting it into Antriel's build.
End result: Everything appears to be compiling in the typescript compiler so far, with code hinting, autocompletion/intellisense, ect. in VS Code (and I imagine similar editors).
Note: This is a temporary, hacky, potentially unstable solution for those who want to start building their Phaser 3 typescript projects right now while we wait on offical typescript support to be complete by Antriel and the Phaser team.
Modified build here:
https://github.com/troyedwardsjr/phaser3-tsd/blob/master/build/official/phaser.d.ts
Also created a starter project, with definitions included:
https://github.com/troyedwardsjr/phaser3-typescript-webpack

@troyedwardsjr
?

Yes, it's still missing some things. But your screen shows v2 code. The current version is v3.

@Antriel I was using v3, but I was having issues loading it without NodeJS so I recently moved down to 2.10 (Not in that screenshot)

Any idea when this will be officially added?

Would love to know as well, or at least know if it's within the next week or month.

Note that in the last issue of Phaser World it was mentioned that the JS Doc work being done is a step toward TS definitions. See https://madmimi.com/p/a022cb (not on the main site yet) and search for 'typescript.'

Any ETA ?
waiting for typescript definition to get in Phaser ;)

Last newsletter devblog suggests he willing on it but docs are a mess. I'm working on the assumption it'll be April.

Docs are the current priority. Defs will be done after the docs are sorted out. Progress so far this week has been great. Nothing about v3 stops you using TS, you just wont have any code insight for the moment. It’s really not the end of the world.

@photonstorm as a new user of Phaser i'm a bit lost, so Defs will be there to greatly add to my productivity.
And normaly Defs contain some examples and links to other object, so it will be easier to learn ;)

Hello, i work on types definition, my work is end at ~70% (i have jsut compile all current description and function in declaration. An first realase of my definition probably out in next days.

@photonstorm How about adding the unfinished type-definitions to the repo for pull-requests? Or a separate definitions-repo for separate version tracking and npm-publishing (ie @types/phaser)
Having an "official" but unfinished definitions-file is better than nothing, and I'd just suggest using the "any"-type for any unfinished interface/class definitions while it's being worked on.

The first pass at them (they're automated, not hand done) were posted to the Phaser forum a few weeks back. They're not being worked on at all until the docs are complete. Docs are the priority. Until all of the data types, config objects, events, etc are correct in the docs, the defs will never generate properly.

Oh, so the defs are generated from jsdoc? That makes sense then

Yes, completely from the docs (using hinting where needed to ensure they are correct). We fell into the trap of manually making docs for v2 and even today, years later, they're still being fixed now and again. It was something we couldn't bear to go through again for v3.

Is there any way to contribute to the docs?

The most helpful right now would be to literally do a 'find' on the source code for the string [type] - and, if you know or can work out what the data-type should be by looking at the function, replace it.

As it currently stands there are 1069 unspecified types left to replace.
Once that is done, there are 7400 [description] blocks to write.
It's really, really, not a small task. However, for the purpose of the defs it's just the [type]s that need replacing for now.

Thanks to a huge PR from @orblazer and a bunch of work I did over the weekend we're down from 1069 unknown types to just 579 remaining. Should easily be able to complete all of those this week.

Another huge batch done. Just 343 left now.

@photonstorm nice, continue, your great jobs guys ;)

@photonstorm Just published a Phaser 3 project template using Typescript and just happened upon this thread, only to find out that typing support is fast approaching. Excited to integrate once it's complete. Thanks for your hard work.
https://github.com/stephenpoole/phaser3-typescript-template

Alright, that's every single data type done. Now the tedious task of checking them all to look for typos, etc. And then working out objects to TypeDefs to Interfaces.

I'm curious about what you are planning on using to convert JSDoc types to TypeScript types. Maybe something like Clutz?

Is there any way to contribute to this? I'd love to use Phaser 3 with TypeScript, so if there's any way I can help bring this about faster, please let me know.

The TypeScript Defs are now available here: https://github.com/photonstorm/phaser3-docs/tree/master/typescript
You can find more details in the Phaser 3 Docs readme. The full source to the parser and conversion tool we built is also in that repo. If you wish to help improve the quality of the defs, or help refine the parser, then please see the details in the readme.
I'm going to close this issue. Any problems with the defs should now be reported in the docs repo.

I wonder why you don't package them in the "phaser" npm package or "@types/phaser" as is standard practice? I need to copy paste this 2.3MB and maintain it myself?
Also would be nice to explain more explicitly that you need to manually copy paste, I wasted time to figure out that you don't provide it properly and need to be done this hacky way.
Maybe explain how to use them https://github.com/photonstorm/phaser3-docs#typescript-definitions

When it's finished, we will include it. It's not ready yet. In the meantime, you can spend all of the earth-shattering 10 seconds it must have taken to copy a single file over to your project folder.

Right? It’s not that difficult to just wget the TypeScript definitions for the current version anyways.

I had the same issue as hackhat :) it does not take 10 seconds to figure out and solve when you are new to TypeScript and Webpack. Even now that I read this thread, I am not certain what I need to do ^^

Webpack has nothing to do with this really. Which-ever folder your project is being saved to in VS Code, you drop the Phaser defs file in there so VS Code can see it. That's literally all there is to it (there are other ways, like referencing the defs globally, but this by far is the quickest)

ok, so I just made a folder def and copy-paste the file phaser.d.ts in it (from https://github.com/photonstorm/phaser3-docs/blob/master/typescript/phaser.d.ts)
When using VS code with tsc, the definition file in found automatically.
PS: @photonstorm, you posted just as I finished to write this :)

If it isn't ready yet, it shouldn't be in public releases. Plus, by that
logic, the entire framework should be in the docs repo. Either it isn't
ready and it's not released publicly, or it is and it should exist in this
repo. You can't have both.
On Thu, Aug 9, 2018 at 8:57 AM Geoffrey Mégardon notifications@github.com
wrote:

ok, so I just made a folder def and copy-paste the file phaser.d.ts in it
(from
https://github.com/photonstorm/phaser3-docs/blob/master/typescript/phaser.d.ts
)
When using VS code with tsc, the definition file in found automatically.
PS: @photonstorm https://github.com/photonstorm, you posted just as I
finished to write this :)
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/photonstorm/phaser/issues/3224#issuecomment-411747794,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADMHHygEoGFzqjEHzqIzaWND6i-JKr9Iks5uPDGjgaJpZM4SErN3
.

I agree that this is a bit odd that the Type Definitions are in the docs repo :D maybe it should be in the phaser repo (easier to find?)?
There could be a note telling the user that this is a beta/alpha version that is improved in parallel to phaser.

I'm not sure if you've heard, but git has a concept known as branching that
allows features to be developed without polluting the master branch. No
need to be a genius to use them.
On Thu, Aug 9, 2018 at 6:24 PM Richard Davey notifications@github.com
wrote:

And yet by existing publicly there have been hundreds of updates and fixes
contributed to them. So yeah, let’s hide them away where no one can help
with them, because of course that would really speed up their growth.
Genius idea, can’t wait for your next insight.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/photonstorm/phaser/issues/3224#issuecomment-411917180,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADMHHwCkFyRh0fQC2tErc5ObqAQcttDOks5uPLaEgaJpZM4SErN3
.

If you are using open-source software and don’t expect to see incomplete features... Idk what else you’re expecting, especially in a docs repo, when docs tend to be a continuous body of work.
Hiding away the defs could also mean that people who could contribute to them, wouldn’t even know they were there.
Not to be harsh, but IMO it’s really not a big deal to have a single .d.ts file you have to download when you want TypeScript definitions. It’s already simpler than using a package manager to solely download a metadata file.

yep I totally agree, but maybe we could add a little sentence in the doc to explain we can just copy-paste the file in the project :)
Anyway, I am a big fan of Phaser; I am very happy to have met this amazingly-fun-to-use library; take all the time you need to polish Phaser 3 :) Thank you to all the contributors, and to the creator @photonstorm!

@photonstorm  is not about taking time. I can copy paste quickly, is about wasting time figuring out that's the "best practice". I couldn't believe I still need to copy paste a library in 2018, so that's why it took me a while to "accept" it.

It literally tells you what to do, and why, in the readme, under the TypeScript heading:
“As soon as we're happy with the accuracy of the TS defs we'll merge them into the main repo, for now, please download them from the docs repo, linked above, and add them to your project. When we release new versions of Phaser we publish new TS defs too.”

@hackhat yes and no. I agree that it took me time to figure it out, but I disagree with the "we are in 2018" comment :) it is totally acceptable to have to copy-paste a "beta" version of the TS defs file.
@photonstorm ... Whaahou I just discovered Phaser 3's documentation :D is there a link to it on the official website?
For people who wonder, the piece of text can be found here: https://photonstorm.github.io/phaser3-docs/index.html#toc4__anchor
Maybe the text can be slightly modified to say something like:
Copy-paste the TS defs file (available here) anywhere in your project, if using VS code it will be detected automatically (does it work automatically with other editors?).

I'm sorry but if you're in too much of a rush to do proper research into new technologies when you use them for the first time then that is on you, this is true of any field of work.
For example, I googled phaser 3 typescript, found this thread, read through it, (was astonished by how much the developers of this free and open source platform have to deal with,) and mid way through found the information I needed and was ready to start using it with typscript in all of a few minutes of reading, and will not have this issue again when starting a new project with it.
I would also like to point out it has been on the main github readme since march 30th according to commit history.
I apologize for the mini rant that is somewhat off topic, but after reading through this I couldn't really help it. I've never used this before but I have to say, I'm not sure I would have had the same patience as these devs.

Honestly, this thread makes me want to become a Phaser contributor... Guess I'll get started on some open issues.

With Phaser > 3.17.0
"files": ["node_modules/phaser/types/phaser.d.ts"],

@jdnichollsc Where should I include that line?
"files": ["node_modules/phaser/types/phaser.d.ts"],

It finally worked for me with that config :
tsconfig.json
{   "compilerOptions": {     "outDir": "./dist/",     "sourceMap": true,     "noImplicitAny": true,     "module": "es6",     "target": "es5",     "jsx": "react",     "allowJs": true,     "typeRoots": [       "./node_modules/@types",       "./node_modules/phaser/types"     ],     "types": [       "Phaser"     ]   } }
It just needed to add the "types" config.
Thanks to @vickylance

Thanks @sh4bang
What must be done so phaser types can be installed like other packages with @types/phaser?

@aounleonardo  The type definitions installed in the @types folder is possible when a type definition is published to the Microsoft's definitely-typed repo (https://definitelytyped.org/). Currently the type definition files for Phaser is not published to the definitely-typed repo. You can search for packages that support in this website -> https://microsoft.github.io/TypeSearch/
However with the latest improvements in typescript ecosystem its not necessarily needed for all libraries to push to definitely-typed. It can stay within the library installation itself. In fact libraries are moving away from the definitely-typed. Especially when you use modern bundlers it just works out of the box.
If you want a quick typescript-phaser setup. Check out my boiler-plate repo -> https://github.com/vickylance/phaser3-parcel-ts-starter

@vickylance thanks for the explanation!!!

authors: Antriel JamesSkemp Korigoth Majirefy Nodragem Sja91 Tatsujinichi ampled aounleonardo camdenorrb goowikns hackhat jdnichollsc mmermerkaya nkholski orblazer photonstorm sh4bang stephenpoole thosakwe troyedwardsjr vickylance

repo: photonstorm/phaser


text:
Tween problem with v3.17

With v3.17 this exemple ( http://labs.phaser.io/edit.html?src=src/tweens/paused tween.js&v=3.17.0 ) doesn't work. When I click on the box there is no tween.

Based on discussion on Discord it seems to be because of a change in tween.play(), possibly causing it to be stuck in a pending_add state.

Thank you for submitting this issue. We have fixed this and the fix has been pushed to the master branch. It will be part of the next release. If you get time to build and test it for yourself we would appreciate that.

authors: 16patsle TonioParis photonstorm


text:
🛑 phpMyFAQ Demo is down

In c1e5dee, phpMyFAQ Demo (https://demo.phpmyfaq.de) was down:

HTTP code: 0
Response time: 0 ms

Resolved: phpMyFAQ Demo is back up in a924613.


text:
🛑 phpMyFAQ API is down

In b54496b, phpMyFAQ API (https://api.phpmyfaq.de/versions) was down:

HTTP code: 0
Response time: 0 ms

Resolved: phpMyFAQ API is back up in 98012ea.


text:
🛑 phpMyFAQ Homepage is down

In ac33845, phpMyFAQ Homepage (https://www.phpmyfaq.de) was down:

HTTP code: 0
Response time: 0 ms

Resolved: phpMyFAQ Homepage is back up in c733b92.


text:
🛑 phpMyFAQ Homepage is down

In 46afc6b, phpMyFAQ Homepage (https://www.phpmyfaq.de) was down:

HTTP code: 0
Response time: 0 ms

Resolved: phpMyFAQ Homepage is back up in 8d63fd5 after 5 minutes.


text:
🛑 Forum de démonstration is down

In aa237b1, Forum de démonstration (https://demo.phpbb-fr.com) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Forum de démonstration is back up in f6ece24 after 8 minutes.

repo: phpbb-fr-com/status-site


text:
adds a note to readme to remind / ensure required 4lw whitelisting is done

might save someone a bit of time if they don't whitelist these 4l words as standard in their config...

Great idea, thanks @david-bush-oxb !

Also created #25 - perhaps we can be even more obvious given this is likely to be a common failure scenario. thx again.

authors: david-bush-oxb phunt

repo: phunt/zktop


text:
iOS: UI API called on a background thread: removeFromSuperview

[x] I have read the README
[x] I have already searched for the same problem
[x] I have read and done the setup for Android: IMPORTANT Note for Android and iOS and IMPORTANT Note for Android
[x] I have read and done the setup for iOS: IMPORTANT Note for Android and iOS and IMPORTANT Note for iOS
[x] I have ran the sample app and it does not work there

Environment

Technology
Version

Flutter version
1.22.2

Plugin version
^4.0.0+4

Android version

iOS version
14.1

Xcode version
12.1

Device information:
Experienced on iPhone 7, iphone 8 plus, iphone Xs, iPhone 12
Description
When pushing a route with a webview, the app freezes for around 5 seconds. Sometimes need to push and dismiss a few times before the bug appears.
According to Flutter #68490 this may be related to Flutter 1.22.2.
I did not experience this issue prior 1.22.2 (1.22.0 was fine).
Expected behavior:
Pushing a route with a webview should not trigger a bug.
Current behavior:
Pushing a route with a webview causes the app to freeze
Minumum reproducible code
Click the open webview button and navigate back. Do it until it crashes. (sometimes takes a good 30 back and forth, sometimes crashes at the second attempt)
import 'package:flutter/cupertino.dart';
import 'package:flutter/material.dart';
import 'package:flutter_inappwebview/flutter_inappwebview.dart';

void main() {
  runApp(MyApp());
}

class MyApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return CupertinoApp(
      debugShowCheckedModeBanner: false,
      title: 'MyApp',
      theme: CupertinoThemeData(
        primaryColor: CupertinoColors.white,
        barBackgroundColor: CupertinoColors.white,
        primaryContrastingColor: CupertinoColors.white,
      ),
      home: Home(),
    );
  }
}

class Home extends StatefulWidget {
  Home({Key key}) : super(key: key);

  @override
  HomeState createState() => HomeState();
}

class HomeState extends State<Home> {
  void _openWebview() {
    Navigator.of(context).push(
      CupertinoPageRoute(
        builder: (ctx) => WebviewPage(
          url: 'https://flutter.dev',
        ),
      ),
    );
  }

  @override
  Widget build(BuildContext context) {
    return Container(
      color: CupertinoColors.systemGreen,
      child: Column(
        mainAxisAlignment: MainAxisAlignment.center,
        children: [
          CupertinoButton(
            color: CupertinoColors.destructiveRed,
            child: Text(
              'Push and pop until crash',
            ),
            onPressed: () => _openWebview(),
          )
        ],
      ),
    );
  }
}

class WebviewPage extends StatefulWidget {
  final String url;

  WebviewPage({Key key, @required this.url})
      : assert(url != null),
        super(key: key);

  @override
  WebviewPageState createState() => WebviewPageState();
}

class WebviewPageState extends State<WebviewPage> {
  @override
  Widget build(BuildContext context) {
    return Material(
      child: CupertinoPageScaffold(
        backgroundColor: CupertinoColors.white,
        navigationBar: CupertinoNavigationBar(
          leading: SizedBox(
            height: 19.0,
            width: 19.0,
            child: CupertinoButton(
              padding: EdgeInsets.zero,
              color: CupertinoColors.black,
              child: Icon(CupertinoIcons.back),
              onPressed: () => Navigator.maybePop(context),
            ),
          ),
        ),
        child: Container(
          child: InAppWebView(initialUrl: widget.url),
        ),
      ),
    );
  }
}

Stacktrace/Logcat
Expand for stacktrace
=================================================================

Main Thread Checker: UI API called on a background thread: -[UIView removeFromSuperview]
PID: 23894, TID: 1054877, Thread name: io.flutter.1.raster, Queue name: com.apple.root.default-qos.overcommit, QoS: 0
Backtrace:
4   Flutter                             0x0000000104ce5c70 _ZN7flutter30FlutterPlatformViewsController11SubmitFrameEP15GrDirectContextNSt3__110shared_ptrINS_10IOSContextEEENS3_10unique_ptrINS_12SurfaceFrameENS3_14default_deleteIS8_EEEE + 4932
5   Flutter                             0x0000000104cff100 _ZN7flutter10IOSSurface11SubmitFrameEP15GrDirectContextNSt3__110unique_ptrINS_12SurfaceFrameENS3_14default_deleteIS5_EEEE + 160
6   Flutter                             0x0000000104fd5764 _ZN7flutter10Rasterizer13DrawToSurfaceERNS_9LayerTreeE + 604
7   Flutter                             0x0000000104fd62a0 _ZNSt3__110__function6__funcIZN7flutter10Rasterizer4DrawEN3fml6RefPtrINS2_8PipelineINS2_9LayerTreeEEEEEE3$_1NS_9allocatorISA_EEFvNS_10unique_ptrIS7_NS_14default_deleteIS7_EEEEEEclEOSG_ + 116
8   Flutter                             0x0000000104fd5a64 _ZN7flutter10Rasterizer4DrawEN3fml6RefPtrINS_8PipelineINS_9LayerTreeEEEEE + 408
9   Flutter                             0x0000000104fdc2b0 _ZNSt3__110__function6__funcIZN7flutter5Shell14OnAnimatorDrawEN3fml6RefPtrINS2_8PipelineINS2_9LayerTreeEEEEENS4_9TimePointEE4$_30NS_9allocatorISB_EEFvvEEclEv + 100
10  Flutter                             0x0000000104d09fe8 _ZN3fml15MessageLoopImpl10FlushTasksENS_9FlushTypeE + 1472
11  Flutter                             0x0000000104d0c714 _ZN3fml17MessageLoopDarwin11OnTimerFireEP16__CFRunLoopTimerPS0_ + 32
12  CoreFoundation                      0x0000000188dcda30 58021D2F-E0D8-3FD1-805D-ECF92B4E0CB0 + 633392
13  CoreFoundation                      0x0000000188dcd634 58021D2F-E0D8-3FD1-805D-ECF92B4E0CB0 + 632372
14  CoreFoundation                      0x0000000188dccb14 58021D2F-E0D8-3FD1-805D-ECF92B4E0CB0 + 629524
15  CoreFoundation                      0x0000000188dc6eb0 58021D2F-E0D8-3FD1-805D-ECF92B4E0CB0 + 605872
16  CoreFoundation                      0x0000000188dc6200 CFRunLoopRunSpecific + 572
17  Flutter                             0x0000000104d0c5f0 _ZN3fml17MessageLoopDarwin3RunEv + 88
18  Flutter                             0x0000000104d0b7cc _ZNSt3__114__thread_proxyINS_5tupleIJNS_10unique_ptrINS_15__thread_structENS_14default_deleteIS3_EEEEZN3fml6ThreadC1ERKNS_12basic_stringIcNS_11char_traitsIcEENS_9allocatorIcEEEEE3$_0EEEEEPvSJ_ + 196
19  libsystem_pthread.dylib             0x00000001cebb9b70 _pthread_start + 288
20  libsystem_pthread.dylib             0x00000001cebbe880 thread_start + 8
2020-10-27 11:10:33.601247-0700 Runner[23894:1054877] [reports] Main Thread Checker: UI API called on a background thread: -[UIView removeFromSuperview]
PID: 23894, TID: 1054877, Thread name: io.flutter.1.raster, Queue name: com.apple.root.default-qos.overcommit, QoS: 0
Backtrace:
4   Flutter                             0x0000000104ce5c70 _ZN7flutter30FlutterPlatformViewsController11SubmitFrameEP15GrDirectContextNSt3__110shared_ptrINS_10IOSContextEEENS3_10unique_ptrINS_12SurfaceFrameENS3_14default_deleteIS8_EEEE + 4932
5   Flutter                             0x0000000104cff100 _ZN7flutter10IOSSurface11SubmitFrameEP15GrDirectContextNSt3__110unique_ptrINS_12SurfaceFrameENS3_14default_deleteIS5_EEEE + 160
6   Flutter                             0x0000000104fd5764 _ZN7flutter10Rasterizer13DrawToSurfaceERNS_9LayerTreeE + 604
7   Flutter                             0x0000000104fd62a0 _ZNSt3__110__function6__funcIZN7flutter10Rasterizer4DrawEN3fml6RefPtrINS2_8PipelineINS2_9LayerTreeEEEEEE3$_1NS_9allocatorISA_EEFvNS_10unique_ptrIS7_NS_14default_deleteIS7_EEEEEEclEOSG_ + 116
8   Flutter                             0x0000000104fd5a64 _ZN7flutter10Rasterizer4DrawEN3fml6RefPtrINS_8PipelineINS_9LayerTreeEEEEE + 408
9   Flutter                             0x0000000104fdc2b0 _ZNSt3__110__function6__funcIZN7flutter5Shell14OnAnimatorDrawEN3fml6RefPtrINS2_8PipelineINS2_9LayerTreeEEEEENS4_9TimePointEE4$_30NS_9allocatorISB_EEFvvEEclEv + 100
10  Flutter                             0x0000000104d09fe8 _ZN3fml15MessageLoopImpl10FlushTasksENS_9FlushTypeE + 1472
11  Flutter                             0x0000000104d0c714 _ZN3fml17MessageLoopDarwin11OnTimerFireEP16__CFRunLoopTimerPS0_ + 32
12  CoreFoundation                      0x0000000188dcda30 58021D2F-E0D8-3FD1-805D-ECF92B4E0CB0 + 633392
13  CoreFoundation                      0x0000000188dcd634 58021D2F-E0D8-3FD1-805D-ECF92B4E0CB0 + 632372
14  CoreFoundation                      0x0000000188dccb14 58021D2F-E0D8-3FD1-805D-ECF92B4E0CB0 + 629524
15  CoreFoundation                      0x0000000188dc6eb0 58021D2F-E0D8-3FD1-805D-ECF92B4E0CB0 + 605872
16  CoreFoundation                      0x0000000188dc6200 CFRunLoopRunSpecific + 572
17  Flutter                             0x0000000104d0c5f0 _ZN3fml17MessageLoopDarwin3RunEv + 88
18  Flutter                             0x0000000104d0b7cc _ZNSt3__114__thread_proxyINS_5tupleIJNS_10unique_ptrINS_15__thread_structENS_14default_deleteIS3_EEEEZN3fml6ThreadC1ERKNS_12basic_stringIcNS_11char_traitsIcEENS_9allocatorIcEEEEE3$_0EEEEEPvSJ_ + 196
19  libsystem_pthread.dylib             0x00000001cebb9b70 _pthread_start + 288
20  libsystem_pthread.dylib             0x00000001cebbe880 thread_start + 8

flutter/engine#22372 addresses this bug in 1.24.0-6.0.pre.


text:
nginx default page

This is likely user error, but I am trying to follow your documentation as closely as possible, however I can never get to the page that allows me to create an admin account, instead I simple see the "you have installed nginx page" I am using vagrant with virtualbox on Ubuntu 16.04. Would be happy to provide any logs/system data you want/need.
Thanks so much.

Our 2019 release is based on Ubuntu 18.04, there may be packages that will not install correctly on a xenial VM. This should be done automatically by vagrant though, are you using the 2018 release?

Ok, that solves it, I am using the wrong release (I just cloned the main repo) I will try again with the 2018 release, or update to Ubuntu 18.04. Thanks for the clarification

Closing assuming issue is resolved with proper vagrant box image

authors: TGC-TECH hiliang-cmu

repo: picoCTF/picoCTF


text:
rename .data to .props

Because hyperapp did it. So any vdom decorator that aims to be compatible with both hyperapp and picodom can still be.

Codecov Report

Merging #31 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master    #31   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files           2      2
  Lines         114    114
  Branches       32     32
=====================================
  Hits          114    114

Impacted Files
Coverage Δ

src/h.js
100% <ø> (ø)
:arrow_up:

src/patch.js
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72c607c...36156a7. Read the comment docs.

Codecov Report

Merging #31 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master    #31   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files           2      2
  Lines         114    114
  Branches       32     32
=====================================
  Hits          114    114

Impacted Files
Coverage Δ

src/h.js
100% <ø> (ø)
:arrow_up:

src/patch.js
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72c607c...36156a7. Read the comment docs.

I added the enhancement tag, but then removed it because this is not really an enhancement. But if not, then what is it?
Maybe API?

tag -> type -- do it in this PR or separate one?

@JorgeBucaran Yeah, API I'd say

@zaceno Let's do it on a separate one and merge this right away.

@JorgeBucaran roger wilco. But I can't merge it (I don't think I have permissions) so you'll have to.

@Zaceno Thanks! 🎉
I fixed the permissions, now all members can push / merge.

🎉

authors: JorgeBucaran codecov-io zaceno

repo: picodom/picodom


text:
Fix typo in PICO_PORT_DIGITAL_CHANNEL enum

A missing comma in the list caused the strings
PICO_PORT_DIGITAL_CHANNEL4 and PICO_PORT_DIGITAL_CHANNEL5 to be merged. Resulting in the enum not working properly.
Fixes #.
Changes proposed in this pull request:

Add a missing comma and thus fix an enum.

@neil-hamilton PTAL

@davidfokkema PTAL

LGTM, but not sure why you tagged me. I'm not a PicoTech employee and don't have permission to merge pull requests, sorry!

Sorry to bother you. Do you know anyone who has permission to merge PRs?

No problem, I was just a bit surprised. It seems that @neil-hamilton has been the only one working on this code the last few years. He's probably also required to work on other projects, and at some point (some years back) company policy changed and they stopped accepting issues and PRs from the community. This is only fixing a typo so it may be merged, but it's taking quite some time...

authors: davidfokkema wsxrdv

repo: picotech/picosdk-python-wrappers

license: ISC


text:
Add Icons for torrent status

A nice to have feature would be a column with an Icon indicating the current status for torrents.

I agree, and this has been discussed in #188 as well. It would make some statuses more easily understood 😄

Fixed in #324.

authors: vktr warhuhn

repo: picotorrent/picotorrent


text:
How can I capture slow motion video

I just found your library, am able to do a video capture but I would like to know how I
can use it to make a slow motion video.
Thanks

@pkadetiloye thanks for your interest in the project and support. i've been wanting to add in examples for slow motion capture adjustment but there is also a bug with this feature.
dup
:paperclip: https://github.com/piemonte/PBJVision/issues/25
:paperclip: https://github.com/piemonte/PBJVision/issues/127

authors: piemonte pkadetiloye

repo: piemonte/PBJVision


text:
TLS  shake hands error

!!!!want help!!!!
branch master and 0.4.4
server config
server 10.140.0.0 255.255.255.0
topology subnet
verb 3

# Filled by Secrets object. Use generic names
key /etc/openvpn/pki/private.key
ca /etc/openvpn/pki/ca.crt
cert /etc/openvpn/pki/certificate.crt

dh none
ecdh-curve secp256k1

key-direction 0
keepalive 10 60
persist-key
persist-tun
push "block-outside-dns"

proto tcp
cipher AES-256-CBC
tls-cipher TLS-ECDHE-RSA-WITH-AES-128-GCM-SHA256:TLS-ECDHE-ECDSA-WITH-AES-128-GCM-SHA256:TLS-ECDHE-RSA-WITH-AES-256-GCM-SHA384

# Rely on scheduler to do port mapping, internally always 1194
port 1194
dev tun0

user nobody
group nogroup

push "dhcp-option DOMAIN svc.cluster.local"
push "dhcp-option DNS 10.96.0.10"

client config
client
nobind
dev tun
key-direction 1
remote-cert-tls server

remote xxxx 1194 tcp

<key>...</key>
<cert>...</cert>
<ca>...</ca>
<tls-auth>...</tls-auth>
key-direction 1

tls-cipher TLS-ECDHE-RSA-WITH-AES-128-GCM-SHA256:TLS-ECDHE-ECDSA-WITH-AES-128-GCM-SHA256:TLS-ECDHE-RSA-WITH-AES-256-GCM-SHA384:TLS-DHE-RSA-WITH-AES-256-CBC-SHA256
cipher AES-256-CBC

server log
 MULTI: multi_create_instance called
Re-using SSL/TLS context
Control Channel MTU parms [ L:1623 D:1182 EF:68 EB:0 ET:0 EL:3 ]
Data Channel MTU parms [ L:1623 D:1450 EF:123 EB:406 ET:0 EL:3 ]
Local Options String (VER=V4): 'V4,dev-type tun,link-mtu 1559,tun-mtu 1500,proto TCPv4_SERVER,keydir 0,cipher AES-256-CBC,auth SHA1,keysize 256,tls-auth,key-method 2,tls-server'
Expected Remote Options String (VER=V4): 'V4,dev-type tun,link-mtu 1559,tun-mtu 1500,proto TCPv4_CLIENT,keydir 1,cipher AES-256-CBC,auth SHA1,keysize 256,tls-auth,key-method 2,tls-client'
TCP connection established with [AF_INET]10.244.0.0:2530
TCPv4_SERVER link local: (not bound)
TCPv4_SERVER link remote: [AF_INET]10.244.0.0:2530
R 10.244.0.0:2530 TLS: Initial packet from [AF_INET]10.244.0.0:2530, sid=b13fc9ef 56a51211
WRR 10.244.0.0:2530 OpenSSL: error:141F7065:SSL routines:final_key_share:no suitable key share
10.244.0.0:2530 TLS_ERROR: BIO read tls_read_plaintext error
10.244.0.0:2530 TLS Error: TLS object -> incoming plaintext read error
10.244.0.0:2530 TLS Error: TLS handshake failed
10.244.0.0:2530 Fatal TLS error (check_tls_errors_co), restarting
10.244.0.0:2530 SIGUSR1[soft,tls-error] received, client-instance restarting
TCP/UDP: Closing socket

client log
 Outgoing Control Channel Authentication: Using 160 bit message hash 'SHA1' for HMAC authentication
 Incoming Control Channel Authentication: Using 160 bit message hash 'SHA1' for HMAC authentication
 TCP/UDP: Preserving recently used remote address: [AF_INET]xxxxx:1194
 Socket Buffers: R=[131072->131072] S=[131072->131072]
 Attempting to establish TCP connection with [AF_INET]xxxxx:1194 [nonblock]
 MANAGEMENT: >STATE:1604551160,TCP_CONNECT,,,,,,
 TCP connection established with [AF_INET]xxxxx:1194
 TCP_CLIENT link local: (not bound)
 TCP_CLIENT link remote: [AF_INET]xxxxx:1194
 MANAGEMENT: >STATE:1604551162,WAIT,,,,,,
 MANAGEMENT: >STATE:1604551162,AUTH,,,,,,
 TLS: Initial packet from [AF_INET]xxxxx:1194, sid=5e5bd90d 77e70dff
 Connection reset, restarting [0]
 SIGUSR1[soft,connection-reset] received, process restarting
 MANAGEMENT: >STATE:1604551162,RECONNECTING,connection-reset,,,,,
 MANAGEMENT: CMD 'hold release'

I managed to resolve this by replacing the EDCH curve secp256k1 with secp521r1.

@mtsgrd did you change the openvpn.tmpl and recreated the docker image? Or how did you fixed it?

@mtsgrd did you change the openvpn.tmpl and recreated the docker image? Or how did you fixed it?

@Edelf I came across this issue and my approach was to create a configmap using the openvpn.tmpl from this repository after editing it:
kubectl -n openvpn create cm openvpn-tmpl --from-file ./openvpn.tmpl

Then change ./kube/deployment.yaml with these lines:
under spec.containers[openvpn].volumeMounts
        - mountPath: /etc/openvpn/templates/openvpn.tmpl
          name: openvpn-tmpl
          subPath: openvpn.tmpl

under spec.volumes
        - name: openvpn-tmpl
          configMap:
            name: openvpn-tmpl
            defaultMode: 0400

I didn't bother editing the whole YAML so had to edit the final line in ./kube/deploy.sh from create to apply, and then update the deployment, but it works :) hopefully this helps!

@Edelf I came across this issue and my approach was to create a configmap using the openvpn.tmpl from this repository after editing it:
kubectl -n openvpn create cm openvpn-tmpl --from-file ./openvpn.tmpl

Then change ./kube/deployment.yaml with these lines:
under spec.containers[openvpn].volumeMounts
        - mountPath: /etc/openvpn/templates/openvpn.tmpl
          name: openvpn-tmpl
          subPath: openvpn.tmpl

under spec.volumes
        - name: openvpn-tmpl
          configMap:
            name: openvpn-tmpl
            defaultMode: 0400

I didn't bother editing the whole YAML so had to edit the final line in ./kube/deploy.sh from create to apply, and then update the deployment, but it works :) hopefully this helps!

authors: Edelf alfieyfc mtsgrd zqWu

repo: pieterlange/kube-openvpn


text:
Behavior when nested loop for with (while|repeat) loop with continue add extra unnecessary scope in generated lua code?

Combine for loop with while or repeat loop that use only 1 continue will add more extra local continue? that unnecessary
EX:
for i = 1, 10
  while true
    if not true
      continue
    break

MoonPLus generated Lua:
for i = 1, 10 do -- 2
  local _continue_0 = false -- 2
  repeat -- 2
    while true do -- 3
      local _continue_1 = false -- 3
      repeat -- 3
        if not true then -- 4
          _continue_1 = true -- 5
          break -- 5
        end -- 4
        break -- 6
        _continue_1 = true -- 3
      until true -- 6
      if not _continue_1 then -- 6
        break -- 6
      end -- 6
    end -- 6
    _continue_0 = true -- 2
  until true -- 6
  if not _continue_0 then -- 6
    break -- 6
  end -- 6
end -- 6

While MoonScript compile to:
for i = 1, 10 do
  while true do
    local _continue_0 = false
    repeat
      do
        if not true then
          _continue_0 = true
          break
        end
        break
      end
      _continue_0 = true
    until true
    if not _continue_0 then
      break
    end
  end
end

Note: I only see it happen with for loop nested a "while or repeat" loop that have use continue, other case that I don't see that happen.
It not really breaking bug or anything but just report to make sure you aware of it.
Thanks and regards!

Thank you for noticing the bug! It is a missed case in the codes that may lead to potential bugs in the future.

confirm fixed!
Thanks and regards!

authors: ngocgodwar pigpigyyy

repo: pigpigyyy/MoonPlus


text:
[Feature]: Allow templates on the color of chips

Is your feature request related to a problem?
It would be nice to have the ability to have chip icon colored in various colors based on the value of the chip.
For instance if the temperature on a sensor drops below 4 degrees Celsius, then the icon will be blue - otherwise, red.
icon_color: >-
{% if states('sensor.house_corner_motion_sensor_temperature') | int >= 4
%} red {% elif states('sensor.house_corner_motion_sensor_temperature') |
int < 4 %} red {% endif %}
Describe the solution you'd like
Accept templates as input
Describe alternatives you've considered
No response
Additional context
No response

You can use a chip of Kind template. I used it several times.
E. G. Having the Updates icon Green when everything is up to date

It's possible with the template chip.

authors: Mask3007 lapo-gh piitaya

repo: piitaya/lovelace-mushroom


text:
🛑 Stripe Test Endpoint URL is down

In 79992f4, Stripe Test Endpoint URL ($STRIPETESTAPI) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Stripe Test Endpoint URL is back up in 32e06eb after 46 minutes.

repo: pikfarm/PikfarmStatus


text:
🛑 www.pik.farm is down

In 0b2369d, www.pik.farm (https://pik.farm) was down:

HTTP code: 0
Response time: 0 ms

Resolved: www.pik.farm is back up in 1dad1cd after 1 hour, 54 minutes.


text:
Add trends in the scoreboards

A green/red arrow with the change in the ranking in the last 24h.
How? Compare 2 data points at 5.55am Paris Time for example and display the "+2" or "-1" or "=" signs next to each line.
Bonus: we can make a graph out of it.

Basic front is ready with #117


text:
tween() without start parameter non-linear fade

start is an optional parameter to tween(), with the documented default of "the current state".
The problem is the implementation literally assigns a reference to the _values list, without taking a copy. As such, when _values changes during the loop, so does start as they refer to the same list.
Link to code at time of writing.
Steps to reproduce:
from piglow import tween

for _ in range(3):
    tween(2.0, [255] * 18)
    tween(2.0, [0] * 18)

for _ in range(3):
    tween(2.0, start=[0]*18, end=[255]*18)
    tween(2.0, start=[255]*18, end=[0]*18)

What happened:
In the first loop, LEDs fade in/out much faster than the second loop.
What's expected:
Both loops give the same result.

I wish every issue was this detailed and descriptive. Thank you for reporting and subsequently fixing this.

Published in release v1.2.5 - https://github.com/pimoroni/piglow/releases/tag/v1.2.5

authors: Gadgetoid rowlap

repo: pimoroni/piglow


text:
Subcommand to get current configuration parameters

I'm trying to work on some fish completions for todoman, and in order to get the list displaynames you need to basically do something like cat ~/.local/share/calendars/*/displayname; however, there's no guarantee the user stores their calendars there.
I noticed the ZSH completions inspect the default-config-file location for the path setting, but figure it might be useful to be able to do something like todo config get {setting} to be able to load this at runtime. You can do something similar with pip, which comes in handy.
Later, if #129 ever got implemented you could do other subcommands like todo config set.

Following up on this: it looks like the click library that todoman depends on actually lets you generate completions, so I will probably end up using that.
_TODO_COMPLETE=fish_source todo > ~/.config/fish/completions/todo.fish

https://click.palletsprojects.com/en/8.1.x/shell-completion/

repo: pimutils/todoman

license: isc


text:
Define gateway services

Questions

[ ] which URL to be used for documentation?
[ ] how do we define the JSON schema for Gateways?
[ ] are gateways linking other services (ex: Subgraphs/Firehose/Substreams)?
[ ] are gateways chain specific? (does there need to be any reference of chain IDs?)

Reach out to:

[ ] GraphOps on gateway requirements

Not adding gateways details to this repo

repo: pinax-network/supported-networks


text:
Make this repository private?

I'm a Professor at Stanford, and I'm teaching an Operating Systems course that uses Pintos for its class projects. I'm writing because an automated search of GitHub identified this repository as possibly containing solutions for the Pintos programming projects. This is a problem for us, because it makes it very easy for students to cheat. Even if they just look at your solution, and don't copy it, that will still reduce the educational experience for them. If this repo does indeed contain Pintos solutions, would you be willing to take it down or at least make it private? If so, that would be a great help to us.

I can't make it private since github doesn't support private repos (for free).
I'll take it down later today.
btw, thank you for such project. It was by far the best project I've done in my programming career.

authors: johnousterhout pindexis

repo: pindexis/pintos-tn


text:
Add code for querying existing index w/Llama

Problem
Users often don't know the best way to query an existing Pinecone index via LlamaIndex. This code snippet does that + shows how to do it with a Pinecone index that contains namespaces.
Solution
Describe the approach you took. Link to any relevant bugs, issues, docs, or other resources.
Type of Change

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update
[ ] Infrastructure change (CI configs, etc)
[ ] Non-code change (docs, etc)
[ ] None of the above: (explain here)

Test Plan
Will run by LlamaIndex devs in our shared channel to confirm its validity :)

naming conventions for repo are to use all lowercase and "-" rather than "_" — former is so we don't need to think about title case or anything other standard (other than all lower), latter is a Google recommended thing for URLs
your file is weird:

@aulorbe you have merge changes in the file, causing the error

Sry about that @jamescalam all fixed now :)

Oof, rebased & now have your commits @jamescalam don't think it's make or break, but sry about the complicated commit history

@aulorbe you did make this complicated 😅 — all looks good to me!

authors: aulorbe jamescalam

repo: pinecone-io/examples


text:
Readme: Better documentation of the configuration options

I feel it would help, if the various environment variables which can be set to configure the tool, were better documented in the readme.

I acutually found the config.go just now. Maybe just link to that from the README

repo: pinepain/ldap-auth-proxy


text:
UCP: Output the TAG name when playground bootstrapping

Description
Currently, we will specify a TAG name for each running instance, but users must use tiup status to display the name. It's better to display the TAG name when playground bootstrapping.
We can use an environment variable to synchronize the TAG to the instance (e.g: TIUP_INSTANCE_TAG).
Score

50

Mentor(s)

@lonng

Contact the mentors: #tidb-challenge-program channel in TiDB Community  Slack Workspace
Recommended Skills

Go

Learning Materials

Closed via #86

repo: pingcap-incubator/tiup


text:
Wrap & Optimize rest bin collator

What problem does this PR solve?
Issue Number: close #5294
Problem Summary:
What is changed and how it works?
Check List
Tests

[x] Unit test
[ ] Integration test
[ ] Manual test (add detailed scripts or steps below)
[ ] No code

Side effects

[ ] Performance regression: Consumes more CPU
[ ] Performance regression: Consumes more Memory
[ ] Breaking backward compatibility

Documentation

[ ] Affects user behaviors
[ ] Contains syntax changes
[ ] Contains variable changes
[ ] Contains experimental features
[ ] Changes MySQL compatibility

Release note

None

/run-all-tests

/merge

repo: pingcap/tiflash


text:
Use memory bounded buffer in executors

What problem does this PR solve?
Issue Number: close #7531
Problem Summary:
What is changed and how it works?

Use memory bounded buffer in ExchangeReceiver/MPPTunnel/UnionBlockInputStream/SharedQueryBlockInputStream/SharedQueue

Check List
Tests

[ ] Unit test
[ ] Integration test
[x] Manual test (add detailed scripts or steps below)
In a 3 nodes TiFlash cluster, run explain analyze select * from lineitem on TPCH-100

max_buffered_bytes_in_executor
Peak memory usages in one TiFlash node

0(unlimited)
2.37 GiB

200 MB(default value)
1.55 GiB

1 byte
1.39 GiB

The query time is almost the same as it is a really simple query

[ ] No code

Side effects

[ ] Performance regression: Consumes more CPU
[ ] Performance regression: Consumes more Memory
[ ] Breaking backward compatibility

Documentation

[ ] Affects user behaviors
[ ] Contains syntax changes
[ ] Contains variable changes
[ ] Contains experimental features
[ ] Changes MySQL compatibility

Release note

None

/rebuild

/lgtm

/run-unit-test

authors: SeaRise windtalker


text:
syncer: support start from empty gtid config

What problem does this PR solve?

Issue Number: close #3731
What is changed and how it works?
mariadb could use 0-0-0 as empty gtid config

support user to use uuid:0 as mysql empty gtid config

Check List
Tests

Integration test
Manual test (mariadb)

Code changes

Has exported function/method change
Has exported variable/fields change
Has interface methods change
Has persistent data change

Side effects

Possible performance regression
Increased code complexity
Breaking backward compatibility

Related changes

Need to cherry-pick to the release branch
Need to update the documentation
Need to update key monitor metrics in both TiCDC document and official document

Release note
Support start an incremental task with nil MySQL GTID set.

/run-dm-integration-test

Codecov Report

Merging #5340 (044a3e3) into master (687e248) will decrease coverage by 0.0104%.
The diff coverage is 54.3836%.

Flag
Coverage Δ

cdc
60.9708% <54.3836%> (+0.3721%)
:arrow_up:

dm
52.2691% <ø> (-0.2005%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.
@@               Coverage Diff                @@
##             master      #5340        +/-   ##
================================================
- Coverage   56.1240%   56.1135%   -0.0105%
================================================
  Files           522        526         +4
  Lines         65325      69199      +3874
================================================
+ Hits          36663      38830      +2167
- Misses        25094      26657      +1563
- Partials       3568       3712       +144

/run-all-tests

/merge

authors: GMHDBJD codecov-commenter

repo: pingcap/tiflow


text:
servermaster(engine): cancel/delete job avoid return error when job is failed

What problem does this PR solve?

Issue Number: close https://github.com/pingcap/tiflow/issues/7315
What is changed and how it works?
Check List
Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No code

Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note
None

Codecov Report

Merging #7320 (16e2eec) into master (2843d67) will increase coverage by 0.1980%.
The diff coverage is 58.9434%.

Additional details and impacted files

Flag
Coverage Δ

dm
51.9765% <36.6666%> (+0.0714%)
:arrow_up:

engine
60.8415% <54.2857%> (-0.2160%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.
@@               Coverage Diff                @@
##             master      #7320        +/-   ##
================================================
+ Coverage   59.6477%   59.8458%   +0.1980%
================================================
  Files           790        798         +8
  Lines         91016      91450       +434
================================================
+ Hits          54289      54729       +440
+ Misses        31982      31949        -33
- Partials       4745       4772        +27

/merge

/run-all-tests

authors: amyangfei codecov-commenter gozssky


text:
Support Auto Random

Signed-off-by: qidi1 1083369179@qq.com
What problem does this PR solve?
This pr is a backport feature from TiBigData about https://github.com/tidb-incubator/TiBigData/issues/235.
TiBigData support auto random feature list.
Design
Code
Differences from TiBigData implementation
Unlike the TiBigData design, we do not use the configuration (tikv.sink.ignore-autorandom-column-value) to explicitly indicate whether to ignore the user-specified value of the auto random column, but follow the auto increment design, where only in update mode the auto random column can only be specified.
Check List
Tests
Integration test

/run-all-tests

/run-all-tests

/run-all-tests

/run-all-tests

/run-all-tests

/run-all-tests

/run-all-tests

/run-all-tests

/run-all-tests

/run-all-tests

/run-all-tests

/run-all-tests

/run-all-tests

/run-all-tests

/run-all-tests

/run-all-tests

/merge

repo: pingcap/tispark


text:
Don't show user-supplied content in error pages

First: Thanks for this awesome Apache module! :) 🚀
Via our Bug Bounty program we got some reports of Text Injections in the error pages such as https://logs.nextcloud.com/redirect_uri?THE......SERVER.....WAS.....NOT......FOUND......PLEASE......GO......TO.....MALICIOUSLINK.COM which would render as:
Error:

Invalid Request

Description:

The OpenID Connect callback URL received an invalid request: THE......SERVER.....WAS.....NOT......FOUND......PLEASE......GO......TO.....MALICIOUSLINK.COM

While I don't really see this as security relevant issue since spaces etc. are properly converted it would be awesome if the error messages would not show the user-supplied content as I'm sure I'll have otherwise to cope with some more of these reports :)

I don't think I follow:
Are you worried about a user manipulating a URL in his browser and then being phished in to copy/pasting to the address bar the URL that is suggested by himself...?
Or are you worried about a user visiting a malicious site that redirects the user to your site and displays non-clickable text that the user would then copy/paste in to the address bar?
Both seem far-fetched to me, unless there's something that I'm missing.
OTOH: it could be a good idea to minimize the text in the error message on a false request to the redirect URI, I don't dis-agree with that.

The actual vector here is https://www.owasp.org/index.php/Content_Spoofing, basically an adversary sending an URL to somebody and hoping that they give it more trust based on domain in scope. I do agree though on the questionability with regard to successful exploitation :)
Thanks for fixing nevertheless! Already got 2 reports about this by some reporters, so that will keep the noise down once we've redeployed via Ansible :)

it is in release 2.1.4 now

This has been assigned CVE-2017-6059

authors: LukasReschke carnil zandbelt


text:
The item couldn’t be saved because the file name

https://upload.wikimedia.org/wikipedia/commons/thumb/0/0b/名鉄2201Fギラティナ・シェイミ号20080720.jpg/700px-名鉄2201Fギラティナ・シェイミ号20080720.jpg
PINDiskCache.m (756) ERROR: The item couldn’t be saved because the file name “https%3A%2F%2Fupload%2Ewikimedia%2Eorg%2Fwikipedia%2Fcommons%2Fthumb%2F0%2F0b%2F%25E5%2590%258D%25E9%2589%25842201F%25E3%2582%25AE%25E3%2583%25A9%25E3%2583%2586%25E3%2582%25A3%25E3%2583%258A%25E3%2583%25BB%25E3%2582%25B7%25E3%2582%25A7%25E3%2582%25A4%25E3%2583%259F%25E5%258F%25B720080720%2Ejpg%2F700px-%25E5%2590%258D%25E9%2589%25842201F%25E3%2582%25AE%25E3%2583%25A9%25E3%2583%2586%25E3%2582%25A3%25E3%2583%258A%25E3%2583%25BB%25E3%2582%25B7%25E3%2582%25A7%25E3%2582%25A4%25E3%2583%259F%25E5%258F%25B720080720%2Ejpg” is invalid.

@k06a this is a known limitation of PINDiskCache currently (because files are stored as with their key and the OS limits the filename length). What we should probably do is assert when the filename is too long.
As a workaround, you can do something like PINRemoteImage does:
NSString *cacheKey = [url absoluteString];
    if (processorKey.length > 0) {
        cacheKey = [cacheKey stringByAppendingString:[NSString stringWithFormat:@"-<%@>", processorKey]];
    }

    //PINDiskCache uses this key as the filename of the file written to disk
    //Due to the current filesystem used in Darwin, this name must be limited to 255 chars.
    //In case the generated key exceeds PINRemoteImageManagerCacheKeyMaxLength characters,
    //we return the hash of it instead.
    if (cacheKey.length > PINRemoteImageManagerCacheKeyMaxLength) {
        __block CC_MD5_CTX ctx;
        CC_MD5_Init(&ctx);
        NSData *data = [cacheKey dataUsingEncoding:NSUTF8StringEncoding];
        [data enumerateByteRangesUsingBlock:^(const void * _Nonnull bytes, NSRange byteRange, BOOL * _Nonnull stop) {
            CC_MD5_Update(&ctx, bytes, (CC_LONG)byteRange.length);
        }];

        unsigned char digest[CC_MD5_DIGEST_LENGTH];
        CC_MD5_Final(digest, &ctx);

        NSMutableString *hexString  = [NSMutableString stringWithCapacity:(CC_MD5_DIGEST_LENGTH * 2)];
        for (int i = 0; i < CC_MD5_DIGEST_LENGTH; i++) {
            [hexString appendFormat:@"%02lx", (unsigned long)digest[i]];
        }
        cacheKey = [hexString copy];
    }

    return cacheKey;

Why not to make this default behavior of PINRemoteImage?

@k06a it is! https://github.com/pinterest/PINRemoteImage/pull/189
If you're on the latest version and still seeing that error, there's probably a bug there and an issue should be opened in PINRemoteImage.

I got this debug log with latest stable version – PINRemoteImage 2.1.4

@k06a yup, that fix is in the latest beta, but not the latest stable version, sorry :(

repo: pinterest/PINCache


text:
Docs: Add missing parameter for Toast

Docs: The parameter color exists in the code but not in the docs. Add the parameter and a corresponding example for it in Toast.

See https://github.com/pinterest/gestalt/pull/760  for more information on why it's no longer documented. I'm ok adding it back in since it's confusing for developers.

Thanks for the advise! Updated:

See #760 for more information on why it's no longer documented. I'm ok adding it back in since it's confusing for developers.

Didn't know it. I'll also check with our designer about this. Thank you!

@Neet-Nestor merged - thanks for the fix!

authors: Neet-Nestor christianvuerings

repo: pinterest/gestalt


text:
two pop up displays on progress bar

Hovering over the progress bar on current deploy page display two pop ups with same information.

Let me know, if I can help to fix the issue :)

Thanks for the question! This will be fixed by #154.

authors: skapil yujunglo

repo: pinterest/teletraan


text:
Secondary IP problem

i have 2 IPs for a server imagine my IPs are 1.1.1.1 and 2.2.2.2
i want the client to connect to 2.2.2.2:2815 and the server gives the data to client with 1.1.1.1:2815 but the tunnel gives me error because the sender and reviser's IP is not the same. how do you think i should solve this problem. i know it is not the right way to use it but our internet in on censorship and the only way i can use it permanently is this what do you suggest i should do for your DTLS tunnel to accept this connection.
Thank you.

Hi @evangelme
Is it possible to open the UDP Socket yourself?
You can send/recv UDP packets outside of Pion DTLS. That way it doesn't care where the packets are coming from or going.

@Sean-Der
thank you for your response. yes it is possible but not in my country. in my country we are under censorship so i have to use these protocols and if i use DTLS as well they block it. the only way to use these is to send the data with 1 IP and receive  with another IP so this way the DPI dose not detect it.

Tell me if I can do anything else! Happy to make examples or code changes if you need
thanks for using Pion!

authors: Sean-Der evangelme

repo: pion/dtls


text:
I wonder how can sfu-minimal work

I download webrtc-2.1.18， and follow the Instructions of README.md like this:
I  open jsfiddle.net in one of my windows pc, ip is 10.0.1.128, call it A pc
Run main.go in sfu-minimal;
In A pc chrome browser, Click Publish a Broadcast, a video view screen appears, wait about 3 minuts, Browser base64 Session Description appears: eyJ0eXBlIjoib2Zm................cclxuIn0=
cmd.exe localhost:8080/sdp -d "eyJ0eXBlIjoib2Zm................cclxuIn0="
sfu-minimal.exe response: eyJ0eXBlIjoiYW5...................0ZXNcclxuIn0
copy eyJ0eXBlIjoiYW5...................0ZXNcclxuIn0 to Golang base64 Session Description, int A pc, Then press Start Session.
Then, Logs appears:
checking
connected
In B pc( whose ip is 10.0.1.88) chrome browser, Click Join a Broadcast,  a video view screen appears, wait about 1 minuts,Browser base64 Session Description appears: eyJ0eXBlIjo...............kZGU2ZVxyXG4ifQ==
cmd.exe localhost:8080/sdp -d "eyJ0eXBlIjo...............kZGU2ZVxyXG4ifQ=="
sfu-minimal.exe response: eyJ0eXBlIjoiYW5zd2Vy........................pZGF0ZXNcclxuIn0=
copy eyJ0eXBlIjoiYW5zd2Vy........................pZGF0ZXNcclxuIn0= to Golang base64 Session Description in pc B .Then press Start Session.
Then, Logs appears:
checking
disconnected
I try about 3 times, the same result. I wonder how can it work?

Hey @mabaohong
Sorry I missed this! If you are trying to use Pion and still have issues I am available to help in Slack
thanks

authors: Sean-Der mabaohong

repo: pion/webrtc


text:
SampleBuilder: Remove PopWithTimestamp

Sample returned by Pop() contains PacketTimestamp field now, so PopWithTimestamp() is redundant.
As we're now preparing v4, it's good time to remove it.

Use Sample.PacketTimestamp field instead.
Migration example:
- sample, timestamp := s.PopWithTimestamp()
+ sample := s.Pop()
+ timestamp := sample.PacketTimestamp

Error status is caused by API compatibility check and test is passed


text:
Add getChunkFile

Get always the chunk file back.
We use this plugin for uploading from a frontend to an api server. The api server merge the chunks to one file.

thanks 👍

Hi @tomswinkels, I'm sorry but after more thinking, the implementation is not abstract (if upload is not chunked, the library will use SingleSave and there is no method with getChunkFile.
I've added getUploadedFile to all save objects. This will return only the uploaded file. Please update your code to 1.0.3. I've also added dependency injection for FileReceiver for automatic selection of file and the handler.
Best regards

authors: pionl tomswinkels

repo: pionl/laravel-chunk-upload


text:
Example with import from google/protobuf types

E.g. if you want to use timestamps, it makes sense to
import "google/protobuf/timestamp.proto";

When as-proto processes this definition it produces AssemblyScript like this:
import { google } from "./google/protobuf/timestamp";

but there is no such source file to import from, at least that I have been able to find. The fact that the import is processed to something that looks sensible makes me think it is intentional, so I need an example to see how it is supposed to be used.

UPDATE: you have to include the Google proto sources on the command line when you run protoc, e.g:
protoc --plugin=protoc-gen-as=./node_modules/.bin/as-proto-gen --as_out=./protoc simple.proto google/protobuf/timestamp.proto

then you get a "google" directory generated with AssemblyScript in it. An example would still be useful.

To be honest, I didn't know about that. Thanks for all reported issues - this is really helpful! This library is still pretty new and it doesn't cover all cases.
Would you like to create a PR to add this to the README.md?

authors: dsyer piotr-oles

repo: piotr-oles/as-proto


text:
Add log unary interceptor for WebAPI

What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?:

NONE

/approve

repo: pipe-cd/pipe


text:
Pipeless 1.0

Description of the change
This PR contains a major re-write of Pipeless from Python to Rust. We took advantage of these changes to support many features that were not possible with the previous architecture by re-designing the whole architecture.
There have also been a significant performance increase and an important decrease in resource consumption.

Benefits

Highly parallelized processing. Version 0.x was conditioned to deploy several workers for parallel processing. Version 1.x contains a single type of Pipeless node, running processing in parallel by default.
Removed the need of configuring streams in a YAML file before running Pipeless.
The App class was replaced by the concept of stage. Stages can be easily plugged and re-used as boxes.
Multi-stream processing. Version 0.x supported a single stream at a time. Version 1.x supports any number of streams without significant overhead.
Significant reduction in resources consumption. Version 0.x required a minimum of 3 processes to work, adding an extra process per level of parallelization. Version 1.x works on a single process, and dynamically distributes loads between processes when required.
Multi-language support. The new architecture allows to support several languages for writing hooks. We are starting with Python and Rust.
Significant performance increase. Some tests indicated 5x speed up with 25% of the resources, which computes a 20x performance increase.

Possible drawbacks

Applicable issues

fixes #

Additional information

Merging PR in order to test workflows, for some reason I can't run them from the branch using the GitHub CLI.
Pending before release:

Setup release workflows.
Update container images.

repo: pipeless-ai/pipeless


text:
Export all/multiple sprites at once

A suggestion I have is being able to export all/some of your sprites at the same time, so you don't have to go into the editing page for every sprite to export them.

I presume you mean exporting the individual sprite frames?
I just use imagemagick to work around: "convert -crop frameSizexframeSize img.png %d.png"

No, the sprites. As in, exporting them from the gallery.

authors: realicraft scarejar

repo: piskelapp/piskel


text:
Bs seq

[x] Workflow のテストを書く
[x] #18 から、cpがなくなったので、あらたに、InitialWorkDirRequirement をつかった rename にする

@inutano Thanks!!
なかで使用している、ツールについては、テストを書いてすでに取り込まれました。

mkdir #16
trim_galore (single end) #17
bismark and bismark_genome_preparation #20
cp to directory #21

いいと思います！
ここまで来ると、workflow/epigenome-BS-seq/bismark_genome_preparation_workflow.cwl 中の mkdir+copy_to_directory も InitialWorkDirRequirement で書きたくなりますが、どうしましょう？

Thanks!
mkdir+copy_to_directory を書き直すとしたら、Step に書いたほうが良いですかね？それとも、ツールにしますかね。
ツールにしておくと、同じことする人に使ってもらえるのでよいのではないかとおもいました。

mkdir+copy_to_directory を書き直すとしたら、Step に書いたほうが良いですかね？それとも、ツールにしますかね。

どちらかというと step に書きたいです。
mkdir+copy_to_directory で得られる「特定のファイルが配置されたディレクトリ」自体は、処理というよりそうしないと動かないツール側の都合なので、それを使うツールの近くで処理させたいです(原理主義的にはツール側を修正したい…)。
ただ、ここは好みの問題な気がするので、単体のツールとして切り出しても問題はないと思います。

authors: manabuishii tom-tan


text:
install-pcf pipeline references rjain material

Looks like the pipe is downloading something from Rahul Jain's GIT:
Status: Downloaded newer image for rjain/buildbox@sha256:
This should probably only reference materials from C[0] or R&D.

We already have a chore for that: https://www.pivotaltracker.com/story/show/144251095

authors: forddonald krishicks

repo: pivotal-cf/pcf-pipelines