text:
hipGetLastError(); -Wunused-result

rocThrust is triggering a warning in a call to hipGetLastError
/rocthrust/thrust/system/hip/detail/malloc_and_free.h:71:9: warning: ignoring return value of function declared with 'nodiscard' attribute [-Wunused-result]
        hipGetLastError(); // Clear global hip error state.
        ^~~~~~~~~~~~~~~

This is with:
% clang --version
clang version 12.0.0 (/llvm/llvm-project/clang 009181e63cd6a46681319335b18180d91d05f241)

Same with calls at thrust/system/hip/detail/util.h:189 and thrust/system/hip/detail/util.h:221

repo: ROCmSoftwarePlatform/rocThrust


text:
List of enums

Hi RSuter,
We recently ran into an issue where someone had written a JSON schema which contained an array of enums.
Here is an example of what can appear: (imagine this is required)
"ListEnum": {
    "type": "array",
    "items": {
        "type": "string",
        "enum": [
            "Element One",
            "Element Two",
            "Element Three"
        ]
    }
},

This gives rise to the following C# code:
There will be an object which contains
private ObservableCollection<ListEnum> _listEnum = new ObservableCollection<ListEnum>();
as well as
[JsonProperty("ListEnum", Required = Required.Always)]
[Required]
public ObservableCollection<ListEnum> ListEnum
{
    get { return _listEnum; }
    set
    {
        if (_listEnum!= value)
        {
            _listEnum= value;
            RaisePropertyChanged();
        }
    }
}

And that all looks great, except if you then try to use Newtonsoft's JSON.NET with this, it requires the following addition to the JSON Properties:
ItemConverterType=typeof(StringEnumConverter)
So the expected result should be:
[JsonProperty("ListEnum", Required = Required.Always, ItemConverterType=typeof(StringEnumConverter))]
[Required]
public ObservableCollection<ListEnum> ListEnum
{
    get { return _listEnum; }
    set
    {
        if (_listEnum!= value)
        {
            _listEnum= value;
            RaisePropertyChanged();
        }
    }
}

Otherwise, an exception will be raised by JSON.NET and it will refuse to deserialize correctly.
We've so far managed to fix it by inserting the element manually when needed, but I hope you'll be willing to look into this.

Strange, this should already be handled:
https://github.com/RSuter/NJsonSchema/blob/master/src/NJsonSchema.CodeGeneration.CSharp/Templates/ClassTemplate.tt#L24
and:
https://github.com/RSuter/NJsonSchema/blob/master/src/NJsonSchema.CodeGeneration/Models/PropertyModelBase.cs#L54
Are you using the latest version of NJS?

Hi RSuter,
I definitely thought I was, but it turns out NPM had done some shenaniganry where an old version was being falsely reported as a new one and linked up nicely. Once I went into packages.config and cleaned it up, the newest version was downloaded correctly.
I apologize for the false report.
You may close this.
I've still got some bugs here though. They are somewhat related to this, but I perfectly understand if you want me to make new bug reports instead - and I will do so if you request. Nevertheless, I will descirbe them here.
Concrete example from our actual code:
              "sekundaerForretningshaendelse": {
                "type": "array",
                "description": "EAID_A2B9B2EF_86F2_4f1d_87C0_1804A7071486.EAID_A0A706C1_027A_46ec_AC79_9138DA725DF5",
                "items": {
                  "title": "sekundaerForretningshaendelse",
                  "description": "EAID_A0A706C1_027A_46ec_AC79_9138DA725DF5",
                  "type": "string",
                  "enum": [
                    "Afledt ændring",
                    "Anden ændring",
                    "Arealændring på Ejerlejlighed",
                    "Ejerlejlighed bortfaldet",
                    "Ejerlejlighed tilkommet",
                    "Arealændring på Jordstykke",
                    "BPFG med oprindelse 'Matriklen - stedfæstet' bortfaldet",
                    "BPFG med oprindelse 'Matriklen - ikke stedfæstet' bortfaldet",
                    "BPFG med oprindelse 'Matriklen - ikke stedfæstet' tilkommet",
                    "Oprindelse for BPFG ændret til 'Matriklen - stedfæstet'",
                    "Registrering af relation fra SFE til BPFG bortfaldet",
                    "Registrering af relation fra SFE til BPFG tilkommet",
                    "Registrering af SFE som Hovedejendom for ejerlejlighedsfællesskab bortfaldet",
                    "Registrering af SFE som Hovedejendom for ejerlejlighedsfællesskab tilkommet",
                    "Noteringsændring på Jordstykke",
                    "Jordstykke(r) bortfaldet",
                    "Noteringsændring på ejendom",
                    "Jordstykke(r) tilkommet"
                  ]
                }
              }

Becomes:
        /// EAID_A2B9B2EF_86F2_4f1d_87C0_1804A7071486.EAID_A0A706C1_027A_46ec_AC79_9138DA725DF5
        [Newtonsoft.Json.JsonProperty("sekundaerForretningshaendelse", Required = Newtonsoft.Json.Required.Always, ItemConverterType = typeof(Newtonsoft.Json.Converters.StringEnumConverter))]
        [System.ComponentModel.DataAnnotations.Required]
        public System.Collections.ObjectModel.ObservableCollection<Anonymous2> SekundaerForretningshaendelse
        {
            get { return _sekundaerForretningshaendelse; }
            set
            {
                if (_sekundaerForretningshaendelse != value)
                {
                    _sekundaerForretningshaendelse = value;
                    RaisePropertyChanged();
                }
            }
        }

where Anonymous2 is
    /// EAID_A0A706C1_027A_46ec_AC79_9138DA725DF5
    [System.CodeDom.Compiler.GeneratedCode("NJsonSchema", "9.6.0.0")]
    public enum Anonymous2
    {
        [System.Runtime.Serialization.EnumMember(Value = "Afledt ændring")]
        Afledt_ændring = 0,

        [System.Runtime.Serialization.EnumMember(Value = "Anden ændring")]
        Anden_ændring = 1,

        [System.Runtime.Serialization.EnumMember(Value = "Arealændring på Ejerlejlighed")]
        Arealændring_på_Ejerlejlighed = 2,

        [System.Runtime.Serialization.EnumMember(Value = "Ejerlejlighed bortfaldet")]
        Ejerlejlighed_bortfaldet = 3,

        [System.Runtime.Serialization.EnumMember(Value = "Ejerlejlighed tilkommet")]
        Ejerlejlighed_tilkommet = 4,

        [System.Runtime.Serialization.EnumMember(Value = "Arealændring på Jordstykke")]
        Arealændring_på_Jordstykke = 5,

        [System.Runtime.Serialization.EnumMember(Value = "BPFG med oprindelse 'Matriklen - stedfæstet' bortfaldet")]
        BPFG_med_oprindelse_'Matriklen__stedfæstet'_bortfaldet = 6,

        [System.Runtime.Serialization.EnumMember(Value = "BPFG med oprindelse 'Matriklen - ikke stedfæstet' bortfaldet")]
        BPFG_med_oprindelse_'Matriklen__ikke_stedfæstet'_bortfaldet = 7,

        [System.Runtime.Serialization.EnumMember(Value = "BPFG med oprindelse 'Matriklen - ikke stedfæstet' tilkommet")]
        BPFG_med_oprindelse_'Matriklen__ikke_stedfæstet'_tilkommet = 8,

        [System.Runtime.Serialization.EnumMember(Value = "Oprindelse for BPFG ændret til 'Matriklen - stedfæstet'")]
        Oprindelse_for_BPFG_ændret_til_'Matriklen__stedfæstet' = 9,

        [System.Runtime.Serialization.EnumMember(Value = "Registrering af relation fra SFE til BPFG bortfaldet")]
        Registrering_af_relation_fra_SFE_til_BPFG_bortfaldet = 10,

        [System.Runtime.Serialization.EnumMember(Value = "Registrering af relation fra SFE til BPFG tilkommet")]
        Registrering_af_relation_fra_SFE_til_BPFG_tilkommet = 11,

        [System.Runtime.Serialization.EnumMember(Value = "Registrering af SFE som Hovedejendom for ejerlejlighedsfællesskab bortfaldet")]
        Registrering_af_SFE_som_Hovedejendom_for_ejerlejlighedsfællesskab_bortfaldet = 12,

        [System.Runtime.Serialization.EnumMember(Value = "Registrering af SFE som Hovedejendom for ejerlejlighedsfællesskab tilkommet")]
        Registrering_af_SFE_som_Hovedejendom_for_ejerlejlighedsfællesskab_tilkommet = 13,

        [System.Runtime.Serialization.EnumMember(Value = "Noteringsændring på Jordstykke")]
        Noteringsændring_på_Jordstykke = 14,

        [System.Runtime.Serialization.EnumMember(Value = "Jordstykke(r) bortfaldet")]
        Jordstykke(r)_bortfaldet = 15,

        [System.Runtime.Serialization.EnumMember(Value = "Noteringsændring på ejendom")]
        Noteringsændring_på_ejendom = 16,

        [System.Runtime.Serialization.EnumMember(Value = "Jordstykke(r) tilkommet")]
        Jordstykke(r)_tilkommet = 17,

    }

Two problems here:

The name of the property is clearly given in he title field, yet the code generator makes no attempt to guess a type name based on that.
The generated enums are not sanitized correctly, leading to quotes and paranthesis in them, which is invalid C# code.

Furthermore, https://github.com/RSuter/NJsonSchema/issues/397 has returned in this version.
Specifically, when generating code for
              "paataenktHandling": {
                "title": "paataenktHandling",
                "description": "EAID_D38C4D27_B57C_4356_89E1_05E8DA0250B6",
                "type": [
                  "string",
                  "null"
                ],
                "enum": [
                  "Ændring",
                  "Nyoprettelse",
                  "Udgår",
                  null
                ]
              }

You will run into this exception:
System.NullReferenceException was unhandled
  HResult=-2147467261
  Message=Object reference not set to an instance of an object.
  Source=NJsonSchema.CodeGeneration.CSharp
  StackTrace:
       at NJsonSchema.CodeGeneration.CSharp.Models.EnumTemplateModel.get_Enums()
       at NJsonSchema.CodeGeneration.CSharp.Templates.EnumTemplate.TransformText()
       at NJsonSchema.CodeGeneration.CSharp.Templates.EnumTemplate.Render()
       at NJsonSchema.CodeGeneration.CSharp.CSharpGenerator.GenerateEnum(String typeName)
       at NJsonSchema.CodeGeneration.CSharp.CSharpGenerator.GenerateType(String typeNameHint)
       at NJsonSchema.CodeGeneration.TypeResolverBase`1.GenerateTypes(ExtensionCode extensionCode)
       at NJsonSchema.CodeGeneration.CSharp.CSharpTypeResolver.GenerateClasses()
       at NJsonSchema.CodeGeneration.CSharp.CSharpGenerator.GenerateFile(String rootTypeNameHint)
       at ConsoleApplication2.Program.Main() in C:\Code\Tools\DAFCodeJSONGenerator\DAFCodeJSONGenerator\Program.cs:line 45
       at System.AppDomain._nExecuteAssembly(RuntimeAssembly assembly, String[] args)
       at System.AppDomain.ExecuteAssembly(String assemblyFile, Evidence assemblySecurity, String[] args)
       at Microsoft.VisualStudio.HostingProcess.HostProc.RunUsersAssembly()
       at System.Threading.ThreadHelper.ThreadStart_Context(Object state)
       at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx)
       at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx)
       at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state)
       at System.Threading.ThreadHelper.ThreadStart()
  InnerException:

source: gharchive/issue

authors: Ishayu RSuter

repo: RSuter/NJsonSchema

license: mit

license_type: permissive

license_source: bigquery


text:
🛑 Olympiad is down

In 777d287, Olympiad (https://olympiad.rtuitlab.dev) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Olympiad is back up in 577c48b.

repo: RTUITLab/upptime

license: MIT

license_source: github-api


text:
the metadata dataset can not  be found

when i deal with the dataset preprocessin, i find that this link can't be find [http://deepyeti.ucsd.edu/jianmo/amazon/index.html]

Thanks for catching the bug! I've updated the README and please refer to metadata links in the "Complete review data" table from https://nijianmo.github.io/amazon/index.html.

repo: RUCAIBox/UniSRec


text:
API如何修改参数？

请问一下如果需要修改API的top_p, top_k这样的参数在哪里哈？没有在config里找到，api.py里只有一个top_k

可以手动添加参数

repo: RVC-Boss/GPT-SoVITS


text:
Failed to load audio

was trying to train, got this error. Got any idea ?
start preprocess
['trainset_preprocess_pipeline_print.py', 'C:\Users\mypc\IACHANT\RVC\training', '48000', '11', 'C:\Users\mypc\iachant\rvc/logs/poil', 'False']
C:\Users\mypc\IACHANT\RVC\training/faischier.wav->Traceback (most recent call last):
File "C:\Users\mypc\iachant\rvc\lib\audio.py", line 14, in load_audio
ffmpeg.input(file, threads=0)
File "C:\Users\mypc\AppData\Local\Programs\Python\Python38\lib\site-packages\ffmpeg_run.py", line 313, in run
process = run_async(
File "C:\Users\mypc\AppData\Local\Programs\Python\Python38\lib\site-packages\ffmpeg_run.py", line 284, in run_async
return subprocess.Popen(
File "C:\Users\mypc\AppData\Local\Programs\Python\Python38\lib\subprocess.py", line 858, in init
self._execute_child(args, executable, preexec_fn, close_fds,
File "C:\Users\mypc\AppData\Local\Programs\Python\Python38\lib\subprocess.py", line 1311, in _execute_child
hp, ht, pid, tid = _winapi.CreateProcess(executable, args,
FileNotFoundError: [WinError 2] Le fichier spécifié est introuvable
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "C:\Users\mypc\iachant\rvc\trainset_preprocess_pipeline_print.py", line 79, in pipeline
audio = load_audio(path, self.sr)
File "C:\Users\mypc\iachant\rvc\lib\audio.py", line 19, in load_audio
raise RuntimeError(f"Failed to load audio: {e}")
RuntimeError: Failed to load audio: [WinError 2] Le fichier spécifié est introuvable
end preprocess

Ran into this once with a Windows installation. Make sure ffmpeg is installed.
you can put the ffmpeg.exe within your installation folder from here, download the windows x64 and look in the bin folder
https://github.com/BtbN/FFmpeg-Builds/releases

Ran into this once with a Windows installation. Make sure ffmpeg is installed.
you can put the ffmpeg.exe within your installation folder from here, download the windows x64 and look in the bin folder https://github.com/BtbN/FFmpeg-Builds/releases

Can you please explain where exactly should I put this executable file? Which folder?

还有可能存在的一个问题是 fffmpeg & ffprobe 应该放在根目录而不是tools 下


text:
Add Resource Packs to TBP Launcher

Add resource packs as an optional download from TBP launcher.

Resource packs are now working in latest build.

repo: RWELabs/Minecraft


text:
CoreOS max payload

creating max payload file for CoreOS.  My next story is to refine some options such as network devices by testing on real hardware.
@srinia6 @uppalk1 @tannoa2 @geoff-reid @dalebremner @keedya

BUILD RackHD #955 : UNSTABLE

** BUILD build-config-setup  #158816: SUCCESS

test this please

source: gharchive/pull-request

authors: BillyAbildgaard JenkinsRHD

repo: RackHD/RackHD


text:
RAC-1984 (somewhat) Removal of PUT node/id/workflows CIT test

This relates to #707. I did not consider that the PUT test would have the same issue as POST. They both use and fail when posting a workflow when the GET API fix is present.
This CIT test fails when run against the fix for GET node/:id/workflows (RackHD/on-http#613)
The PUT for node/id/workflows works with master and the above GET fix. However, the CIT test breaks and blocks the GET fix from getting merged. I propose that this test be temporarily removed so the GET API fix can be moved in. Meanwhile a new ticket will be added for correcting the CIT test for PUT.
What I have in the pipes at the moment is this test removal, the API fix, and a new GET CIT test.

👍

BUILD RackHD #93 : FAILURE

BUILD RackHD #93  Error Logs  ▼Test Name: test13_load_ucs_manager_config
Error Details: HTTP Error 503: Service Unavailable
-------------------- >> begin captured stdout << ---------------------
 16384  [15.80%]?????????????????????
 24576  [23.70%]?????????????????????
 32768  [31.60%]?????????????????????
 49152  [47.39%]?????????????????????
 57344  [55.29%]?????????????????????
 65536  [63.19%]?????????????????????
 73728  [71.09%]?????????????????????
 90112  [86.89%]?????????????????????
 98304  [94.79%]?????????????????????
106496  [102.69%]??????????????????????
114688  [110.59%]??????????????????????

--------------------- >> end captured stdout << ----------------------
-------------------- >> begin captured logging << --------------------
root: INFO: +1.25 - STARTING TEST: [test13_load_ucs_manager_config (test.deploy.rackhd_stack_init.rackhd_stack_init)]
ucs: DEBUG: ./tests/ucs/ucsm_config.xml
ucs: DEBUG: Date: Thu, 13 Apr 2017 03:54:04 GMT
Server: Apache/2.4.16 (Unix) CiscoSSL/1.0.1l.4.8-fips
Content-Length: 299
Connection: close
Content-Type: text/html; charset=iso-8859-1
--------------------- >> end captured logging << ---------------------
Stack Trace:   File "/usr/lib/python2.7/unittest/case.py", line 331, in run
testMethod()
File "/home/jenkins/workspace/RackHD/RackHD/test/deploy/rackhd_stack_init.py", line 307, in test13_load_ucs_manager_config
import_ucs_backup(handle, file_dir=path, file_name=file)
File "/home/jenkins/workspace/RackHD/RackHD/test/.venv/on-build-config/local/lib/python2.7/site-packages/ucsmsdk/utils/ucsbackup.py", line 192, in import_ucs_backup
file_name=file_name)
File "/home/jenkins/workspace/RackHD/RackHD/test/.venv/on-build-config/local/lib/python2.7/site-packages/ucsmsdk/ucssession.py", line 367, in file_upload
progress=progress)
File "/home/jenkins/workspace/RackHD/RackHD/test/.venv/on-build-config/local/lib/python2.7/site-packages/ucsmsdk/ucsgenutils.py", line 222, in upload_file
response = driver.post(uri, data=stream)
File "/home/jenkins/workspace/RackHD/RackHD/test/.venv/on-build-config/local/lib/python2.7/site-packages/ucsmsdk/ucsdriver.py", line 207, in post
response = opener.open(request)
File "/usr/lib/python2.7/urllib2.py", line 410, in open
response = meth(req, response)
File "/usr/lib/python2.7/urllib2.py", line 523, in http_response
'http', request, response, code, msg, hdrs)
File "/usr/lib/python2.7/urllib2.py", line 448, in error
return self._call_chain(*args)
File "/usr/lib/python2.7/urllib2.py", line 382, in _call_chain
result = func(*args)
File "/usr/lib/python2.7/urllib2.py", line 531, in http_error_default
raise HTTPError(req.get_full_url(), code, msg, hdrs, fp)
'HTTP Error 503: Service Unavailable\n-------------------- >> begin captured stdout << ---------------------\n\r     16384  [15.80%]\x08\x08\x08\x08\x08\x08\x08\x08\x08\x08\x08\x08\x08\x08\x08\x08\x08\x08\x08\x08\x08\r     24576  [23.70%]\x08\x08\x08\x08\x08\x08\x08\x08\x08\x08\x08\x08\x08\x08\x08\x08\x08\x08\x08\x08\x08\r     32768  [31.60%]\x08\x08\x08\x08\x08\x08\x08\x08\x08\x08\x08\x08\x08\x08\x08\x08\x08\x08\x08\x08\x08\r     49152  [47.39%]\x08\x08\x08\x08\x08\x08\x08\x08\x08\x08\x08\x08\x08\x08\x08\x08\x08\x08\x08\x08\x08\r     57344  [55.29%]\x08\x08\x08\x08\x08\x08\x08\x08\x08\x08\x08\x08\x08\x08\x08\x08\x08\x08\x08\x08\x08\r     65536  [63.19%]\x08\x08\x08\x08\x08\x08\x08\x08\x08\x08\x08\x08\x08\x08\x08\x08\x08\x08\x08\x08\x08\r     73728  [71.09%]\x08\x08\x08\x08\x08\x08\x08\x08\x08\x08\x08\x08\x08\x08\x08\x08\x08\x08\x08\x08\x08\r     90112  [86.89%]\x08\x08\x08\x08\x08\x08\x08\x08\x08\x08\x08\x08\x08\x08\x08\x08\x08\x08\x08\x08\x08\r     98304  [94.79%]\x08\x08\x08\x08\x08\x08\x08\x08\x08\x08\x08\x08\x08\x08\x08\x08\x08\x08\x08\x08\x08\r    106496  [102.69%]\x08\x08\x08\x08\x08\x08\x08\x08\x08\x08\x08\x08\x08\x08\x08\x08\x08\x08\x08\x08\x08\x08\r    114688  [110.59%]\x08\x08\x08\x08\x08\x08\x08\x08\x08\x08\x08\x08\x08\x08\x08\x08\x08\x08\x08\x08\x08\x08\n--------------------- >> end captured stdout << ----------------------\n-------------------- >> begin captured logging << --------------------\nroot: INFO: +1.25 - STARTING TEST: [test13_load_ucs_manager_config (test.deploy.rackhd_stack_init.rackhd_stack_init)]\nucs: DEBUG: ./tests/ucs/ucsm_config.xml\nucs: DEBUG: Date: Thu, 13 Apr 2017 03:54:04 GMT\r\nServer: Apache/2.4.16 (Unix) CiscoSSL/1.0.1l.4.8-fips\r\nContent-Length: 299\r\nConnection: close\r\nContent-Type: text/html; charset=iso-8859-1\r\n\n--------------------- >> end captured logging << ---------------------'

test this please

authors: DavidjohnBlodgett JenkinsRHD lacarb


text:
gpuOwl Fails with Memory Access Fault Error

"Issue: gpuOwL is an OpenCL-based program for testing Mersenne numbers for primality. Currently, running gpuOwl for higher probable prime (PRP) values results in a Memory Access Fault error.
Note, the issue is noticed only when using higher PRP values.
Resolution: As a workaround, you may use lower PRP values."
This Resolution is not valid as PRP values are growing.

Hi,
have you tried to track down the problem with rocr_debug_agent? (https://github.com/ROCm-Developer-Tools/rocr_debug_agent)
I had a memory access fault in my application that I tried to find for months without luck. rocr_debug_agent pointed me to the right location in the code.
You need a Vega GPU, older ASICS are not supported.

Hi,
have you tried to track down the problem with rocr_debug_agent? (https://github.com/ROCm-Developer-Tools/rocr_debug_agent)
I had a memory access fault in my application that I tried to find for months without luck. rocr_debug_agent pointed me to the right location in the code.
You need a Vega GPU, older ASICS are not supported.

and Radeon VII is supported?

Yes

At this point I have no indication that there is a memory access error in GpuOwl. Secondly, I am not able to run OpenCL with ROCm 3.0 as discussed here https://github.com/RadeonOpenCompute/ROCm/issues/977 , and as such I can't investigate GpuOwl's behavior on 3.0.

At this point I have no indication that there is a memory access error in GpuOwl. Secondly, I am not able to run OpenCL with ROCm 3.0 as discussed here #977 , and as such I can't investigate GpuOwl's behavior on 3.0.

I would be useful if they indicated which PRP values they used for the test.

As mentioned in #977 recently I was able to run with ROCm 3.1. There was no "memory access fault" reported but the computation does not proceed correctly. Basically there is a bug, either in gpuowl or in the OpenCL codegen or somewhere.

As mentioned in #977 recently I was able to run with ROCm 3.1. There was no "memory access fault" reported but the computation does not proceed correctly. Basically there is a bug, either in gpuowl or in the OpenCL codegen or somewhere.

it looks like it may be from application side on ROCm3.1.
We  can give a try below info and see if it helps.
gpuowl : https://github.com/preda/gpuowl
Commit ID à  305d2b4949b7827af6e394eaf6c7a0d41c1b17c3  --> Pass
Commit ID à  6d275b7130dbcc05d9ca1771fd8ba2522f3b6a75 -->Fail [ first commit that started seeign failure ]

it looks like it may be from application side on ROCm3.1.
We can give a try below info and see if it helps.
gpuowl : https://github.com/preda/gpuowl
Commit ID à 305d2b4949b7827af6e394eaf6c7a0d41c1b17c3 --> Pass
Commit ID à 6d275b7130dbcc05d9ca1771fd8ba2522f3b6a75 -->Fail [ first commit that started seeign failure ]

@pramenku Thank you I'll have a look.

If that's fine I'm going to close this issue, because it seems there is no Memory Acccess Error with ROCm 3.1 anymore, so this issue relative to 3.0 seems to have been already fixed in 3.1.

No Memory Access Fault issue is observed in ROCm 3.1.
Verified with the latest gpuowl commit + ROCm 3.1.
Observations
kumar@desktop-radeon7:~/Desktop/gpuowl$ ./gpuowl -prp 84682337
2020-03-02 12:57:06 gpuowl v6.11-160-g74b7196-dirty
2020-03-02 12:57:06 Note: not found 'config.txt'
2020-03-02 12:57:06 config: -prp 84682337
2020-03-02 12:57:06 device 0, unique id 'a5de692172dc768b'
2020-03-02 12:57:06 a5de692172dc768b 84682337 FFT 4608K: Width 256x4, Height 64x4, Middle 9; 17.95 bits/word
2020-03-02 12:57:07 a5de692172dc768b OpenCL args "-DEXP=84682337u -DWIDTH=1024u -DSMALL_HEIGHT=256u -DMIDDLE=9u -DWEIGHT_STEP=0x1.09aaaa1a94ac2p+0 -DIWEIGHT_STEP=0x1.ed5ec2690d837p-1 -DWEIGHT_BIGSTEP=0x1.ae89f995ad3adp+0 -DIWEIGHT_BIGSTEP=0x1.306fe0a31b715p-1 -DPM1=0 -DAMDGPU=1 -cl-fast-relaxed-math -cl-std=CL2.0"
2020-03-02 12:57:10 a5de692172dc768b OpenCL compilation in 3.40 s
2020-03-02 12:57:11 a5de692172dc768b 84682337 OK 0 loaded: blockSize 400, 0000000000000003
2020-03-02 12:57:12 a5de692172dc768b 84682337 OK 800 0.00%; 595 us/it; ETA 0d 14:00; d0b20c358eaddcea (check 0.33s)
2020-03-02 12:59:12 a5de692172dc768b 84682337 OK 200000 0.24%; 601 us/it; ETA 0d 14:07; 3ad53bdf0f0dcb10 (check 0.33s)
2020-03-02 13:01:13 a5de692172dc768b 84682337 OK 400000 0.47%; 603 us/it; ETA 0d 14:07; 2fa7256aa0425861 (check 0.33s)

I was courious what actually fixed the memory access fault in ROCm 3.1. Didn't find any message from the maintainers on this topic. It appears that the fix is in the firmware blob since I had to update the firmware to the latest one found on linux-firmware.git.
Really a pity that there is no proper changelog for the firmware. One finding from this is that there are certain kind of bugs which cannot be fixed by the open source community despite all the host software being open source. But to be honest, currently there seems to be practically no community outside of AMD for maintaining ROCm.

I still see a strange crash manifested in dmesg such:
[  501.631399] amdgpu 0000:67:00.0: [gfxhub0] retry page fault (src_id:0 ring:0 vmid:8 pasid:32771, for process gpuowl pid 4376 thread gpuowl pid 4376)
[  501.631406] amdgpu 0000:67:00.0:   in page starting at address 0x00006f20054e4000 from client 27
[  501.631410] amdgpu 0000:67:00.0: VM_L2_PROTECTION_FAULT_STATUS:0xFFFFFFFF
[  501.631412] amdgpu 0000:67:00.0: 	 MORE_FAULTS: 0x1
[  501.631415] amdgpu 0000:67:00.0: 	 WALKER_ERROR: 0x7
[  501.631417] amdgpu 0000:67:00.0: 	 PERMISSION_FAULTS: 0xf
[  501.631419] amdgpu 0000:67:00.0: 	 MAPPING_ERROR: 0x1
[  501.631421] amdgpu 0000:67:00.0: 	 RW: 0x1
[  501.631430] amdgpu 0000:67:00.0: [gfxhub0] retry page fault (src_id:0 ring:0 vmid:8 pasid:32771, for process gpuowl pid 4376 thread gpuowl pid 4376)
[  501.631434] Evicting PASID 0x8003 queues
[  501.631435] amdgpu 0000:67:00.0:   in page starting at address 0x00005f610dc33000 from client 27
[  501.631439] amdgpu 0000:67:00.0: VM_L2_PROTECTION_FAULT_STATUS:0xFFFFFFFF
[  501.631441] amdgpu 0000:67:00.0: 	 MORE_FAULTS: 0x1
[  501.631444] amdgpu 0000:67:00.0: 	 WALKER_ERROR: 0x7
[  501.631445] amdgpu 0000:67:00.0: 	 PERMISSION_FAULTS: 0xf
[  501.631447] amdgpu 0000:67:00.0: 	 MAPPING_ERROR: 0x1
[  501.631449] amdgpu 0000:67:00.0: 	 RW: 0x1
[  501.631454] amdgpu 0000:67:00.0: [gfxhub0] retry page fault (src_id:0 ring:0 vmid:8 pasid:32771, for process gpuowl pid 4376 thread gpuowl pid 4376)
[  501.631457] amdgpu 0000:67:00.0:   in page starting at address 0x00005d6107692000 from client 27
[  501.631460] amdgpu 0000:67:00.0: VM_L2_PROTECTION_FAULT_STATUS:0xFFFFFFFF
[  501.631462] amdgpu 0000:67:00.0: 	 MORE_FAULTS: 0x1
[  501.631464] amdgpu 0000:67:00.0: 	 WALKER_ERROR: 0x7
[  501.631466] amdgpu 0000:67:00.0: 	 PERMISSION_FAULTS: 0xf
[  501.631468] amdgpu 0000:67:00.0: 	 MAPPING_ERROR: 0x1
[  501.631470] amdgpu 0000:67:00.0: 	 RW: 0x1
[  501.631475] amdgpu 0000:67:00.0: [gfxhub0] retry page fault (src_id:0 ring:0 vmid:8 pasid:32771, for process gpuowl pid 4376 thread gpuowl pid 4376)
[  501.631478] amdgpu 0000:67:00.0:   in page starting at address 0x00007f20054e4000 from client 27
[  501.631480] amdgpu 0000:67:00.0: VM_L2_PROTECTION_FAULT_STATUS:0xFFFFFFFF
[  501.631482] amdgpu 0000:67:00.0: 	 MORE_FAULTS: 0x1
[  501.631484] amdgpu 0000:67:00.0: 	 WALKER_ERROR: 0x7
[  501.631486] amdgpu 0000:67:00.0: 	 PERMISSION_FAULTS: 0xf
[  501.631489] amdgpu 0000:67:00.0: 	 MAPPING_ERROR: 0x1
[  501.631491] amdgpu 0000:67:00.0: 	 RW: 0x1
[  501.631496] amdgpu 0000:67:00.0: [gfxhub0] retry page fault (src_id:0 ring:0 vmid:8 pasid:32771, for process gpuowl pid 4376 thread gpuowl pid 4376)
[  501.631498] amdgpu 0000:67:00.0:   in page starting at address 0x00007f2107552000 from client 27
[  501.631501] amdgpu 0000:67:00.0: VM_L2_PROTECTION_FAULT_STATUS:0xFFFFFFFF
[  501.631503] amdgpu 0000:67:00.0: 	 MORE_FAULTS: 0x1
[  501.631505] amdgpu 0000:67:00.0: 	 WALKER_ERROR: 0x7
[  501.631507] amdgpu 0000:67:00.0: 	 PERMISSION_FAULTS: 0xf
[  501.631509] amdgpu 0000:67:00.0: 	 MAPPING_ERROR: 0x1
[  501.631511] amdgpu 0000:67:00.0: 	 RW: 0x1
[  501.631516] amdgpu 0000:67:00.0: [gfxhub0] retry page fault (src_id:0 ring:0 vmid:8 pasid:32771, for process gpuowl pid 4376 thread gpuowl pid 4376)
[  501.631519] amdgpu 0000:67:00.0:   in page starting at address 0x00005d6005426000 from client 27
[  501.631521] amdgpu 0000:67:00.0: VM_L2_PROTECTION_FAULT_STATUS:0xFFFFFFFF
[  501.631523] amdgpu 0000:67:00.0: 	 MORE_FAULTS: 0x1
[  501.631525] amdgpu 0000:67:00.0: 	 WALKER_ERROR: 0x7
[  501.631527] amdgpu 0000:67:00.0: 	 PERMISSION_FAULTS: 0xf
[  501.631529] amdgpu 0000:67:00.0: 	 MAPPING_ERROR: 0x1
[  501.631531] amdgpu 0000:67:00.0: 	 RW: 0x1
[  501.631536] amdgpu 0000:67:00.0: [gfxhub0] retry page fault (src_id:0 ring:0 vmid:8 pasid:32771, for process gpuowl pid 4376 thread gpuowl pid 4376)
[  501.631539] amdgpu 0000:67:00.0:   in page starting at address 0x00005f6105426000 from client 27
[  501.631541] amdgpu 0000:67:00.0: VM_L2_PROTECTION_FAULT_STATUS:0xFFFFFFFF
[  501.631543] amdgpu 0000:67:00.0: 	 MORE_FAULTS: 0x1
[  501.631545] amdgpu 0000:67:00.0: 	 WALKER_ERROR: 0x7
[  501.631547] amdgpu 0000:67:00.0: 	 PERMISSION_FAULTS: 0xf
[  501.631550] amdgpu 0000:67:00.0: 	 MAPPING_ERROR: 0x1
[  501.631552] amdgpu 0000:67:00.0: 	 RW: 0x1
[  501.631557] amdgpu 0000:67:00.0: [gfxhub0] retry page fault (src_id:0 ring:0 vmid:8 pasid:32771, for process gpuowl pid 4376 thread gpuowl pid 4376)
[  501.631559] amdgpu 0000:67:00.0:   in page starting at address 0x00007d6107692000 from client 27
[  501.631562] amdgpu 0000:67:00.0: VM_L2_PROTECTION_FAULT_STATUS:0xFFFFFFFF
[  501.631564] amdgpu 0000:67:00.0: 	 MORE_FAULTS: 0x1
[  501.631566] amdgpu 0000:67:00.0: 	 WALKER_ERROR: 0x7
[  501.631568] amdgpu 0000:67:00.0: 	 PERMISSION_FAULTS: 0xf
[  501.631570] amdgpu 0000:67:00.0: 	 MAPPING_ERROR: 0x1
[  501.631572] amdgpu 0000:67:00.0: 	 RW: 0x1
[  501.631577] amdgpu 0000:67:00.0: [gfxhub0] retry page fault (src_id:0 ring:0 vmid:8 pasid:32771, for process gpuowl pid 4376 thread gpuowl pid 4376)
[  501.631580] amdgpu 0000:67:00.0:   in page starting at address 0x00007f21075f2000 from client 27
[  501.631582] amdgpu 0000:67:00.0: VM_L2_PROTECTION_FAULT_STATUS:0xFFFFFFFF
[  501.631584] amdgpu 0000:67:00.0: 	 MORE_FAULTS: 0x1
[  501.631586] amdgpu 0000:67:00.0: 	 WALKER_ERROR: 0x7
[  501.631588] amdgpu 0000:67:00.0: 	 PERMISSION_FAULTS: 0xf
[  501.631590] amdgpu 0000:67:00.0: 	 MAPPING_ERROR: 0x1
[  501.631592] amdgpu 0000:67:00.0: 	 RW: 0x1
[  501.631597] amdgpu 0000:67:00.0: [gfxhub0] retry page fault (src_id:0 ring:0 vmid:8 pasid:32771, for process gpuowl pid 4376 thread gpuowl pid 4376)
[  501.631600] amdgpu 0000:67:00.0:   in page starting at address 0x00007c2109991000 from client 27
[  501.631602] amdgpu 0000:67:00.0: VM_L2_PROTECTION_FAULT_STATUS:0xFFFFFFFF
[  501.631604] amdgpu 0000:67:00.0: 	 MORE_FAULTS: 0x1
[  501.631606] amdgpu 0000:67:00.0: 	 WALKER_ERROR: 0x7
[  501.631608] amdgpu 0000:67:00.0: 	 PERMISSION_FAULTS: 0xf
[  501.631610] amdgpu 0000:67:00.0: 	 MAPPING_ERROR: 0x1
[  501.631612] amdgpu 0000:67:00.0: 	 RW: 0x1
[  510.633583] qcm fence wait loop timeout expired
[  510.633586] The cp might be in an unrecoverable state due to an unsuccessful queues preemption
[  510.633592] amdgpu 0000:67:00.0: GPU reset begin!
[  510.633595] Evicting PASID 0x8003 queues
[  510.633596] Evicting PASID 0x8003 queues
[  511.030771] amdgpu: [powerplay] Failed to send message 0x7, response 0xffffffff
[  511.030774] amdgpu: [powerplay] [DisableAllSMUFeatures] Failed to disable all smu features!
[  511.030774] amdgpu: [powerplay] [DisableDpmTasks] Failed to disable all smu features!
[  511.030775] amdgpu: [powerplay] [PowerOffAsic] Failed to disable DPM!
[  511.030836] [drm:amdgpu_device_ip_suspend_phase2 [amdgpu]] *ERROR* suspend of IP block <powerplay> failed -5
[  511.271180] [drm] Timeout wait for RLC serdes 0,0
[  511.292052] amdgpu 0000:67:00.0: GPU BACO reset
[  511.292055] amdgpu: [powerplay] Failed to send message 0x58, response 0xffffffff
[  511.292058] amdgpu 0000:67:00.0: GPU reset succeeded, trying to resume
[  511.292145] [drm] PCIE GART of 512M enabled (table at 0x0000008000000000).
[  511.292157] [drm] VRAM is lost due to GPU reset!
[  511.292273] [drm] PSP is resuming...
[  511.292277] amdgpu 0000:67:00.0: sos fw version = 0xffffffff.
[  511.431761] [drm:psp_hw_start [amdgpu]] *ERROR* PSP create ring failed!
[  511.431814] [drm:psp_resume [amdgpu]] *ERROR* PSP resume failed
[  511.431846] [drm:amdgpu_device_fw_loading [amdgpu]] *ERROR* resume of IP block <psp> failed -62
[  511.431878] [drm] Skip scheduling IBs!
[  511.431882] [drm] Skip scheduling IBs!
[  511.431885] [drm] Skip scheduling IBs!
[  511.431888] [drm] Skip scheduling IBs!
[  511.431891] [drm] Skip scheduling IBs!
[  511.431893] amdgpu 0000:67:00.0: GPU reset(1) failed
[  511.431894] [drm] Skip scheduling IBs!
[  511.431896] [drm] Skip scheduling IBs!
[  511.431899] [drm] Skip scheduling IBs!
[  511.431902] [drm] Skip scheduling IBs!
[  511.431904] [drm] Skip scheduling IBs!
[  511.431907] [drm] Skip scheduling IBs!
[  511.431909] [drm] Skip scheduling IBs!
[  511.431912] [drm] Skip scheduling IBs!
[  511.431915] [drm] Skip scheduling IBs!

The app reports
Memory access fault by GPU node-2 (Agent handle: 0x5561bed44740) on address 0x7d6107692000. Reason: Unknown.

This is with ROCm 3.1 on linux kernel 5.6.0-rc1. This system worked fine for a few days, I'm still investigating what changed that might have activated this issue. Anyway, if ROCm devs have any insight into what may cause this, or workarounds, I'd like to hear. It seems the problem does not originate application-side (i.e. it's not caused by a genuine invalid memory access).

If that's fine I'm going to close this issue, because it seems there is no Memory Acccess Error with ROCm 3.1 anymore, so this issue relative to 3.0 seems to have been already fixed in 3.1.
(can't close, I think original author should close)

Thanks for the confirmation.

As per preda, 3.1 doesn't exhibit this issue. so closing this issue.

authors: Moading pramenku preda pskumar152 seesturm streamhsa valeriob01

repo: RadeonOpenCompute/ROCm


text:
Fix incorrect slicing during application of wavelet filter

Due to some slicing errors, the wavelet filter resulted in a 90deg rotation and a mirroring along one axis. This resulted in that the labelmaps did not align with the ROI anymore, causing the wavelet features to be incorrectly calculated.
This PR addresses this error by recoding the slicing during wavelet decomposition. Results have been checked visually. I'll add some examples later.

Original

LLL: Image is flipped and rotated --> This is due to incorrect slicing

LLH: Bottom slice is somehow 'copied' / filtered and inserted over the top slice --> This is due to the wavelet transform by the pywavelet package, will look into this further...

Tests of the pywavelet functions (using Haar wavelet):
Test1, length = 8
In: [5 4 3 0 0 0 0 0]
Out-H: [ 6.364   4.9497  2.1213  0.      0.      0.      0.      3.5355]
Out-L: [ 0.7071  0.7071  2.1213  0.      0.      0.      0.     -3.5355]
Test2, length = 6
In: [5 4 3 0 0 0]
Out-H: [ 6.364   4.9497  2.1213  0.      0.      3.5355]
Out-L: [ 0.7071  0.7071  2.1213  0.      0.     -3.5355]
Test3, reverse
In: [0 0 0 0 0 3 4 5]
Out-H: [ 0.      0.      0.      0.      2.1213  4.9497  6.364   3.5355]
Out-L: [ 0.      0.      0.      0.     -2.1213 -0.7071 -0.7071  3.5355]
Test4, reverse with extra padding
In: [0 0 0 0 0 3 4 5 0 0]
Out-H: [ 0.      0.      0.      0.      2.1213  4.9497  6.364   3.5355  0.      0.    ]
Out-L: [ 0.      0.      0.      0.     -2.1213 -0.7071 -0.7071  3.5355  0.      0.    ]
Test5, discreet instead of stationary wavelet transform
In: [5 4 3 0 0 0 0 0]
Out-H: [ 6.364   2.1213  0.      0.    ]
Out-L: [ 0.7071  2.1213  0.      0.    ]
The value of 3.5355 is equal to 1/sqrt(2) * (5 + 0), i.e. looks like it wraps around for the last index:
1/sqrt(2) * (index[-1] + index[0]) for L, 1/sqrt(2) * (index[-1] + index[0]) for H

Got a response from pywavelets: This duplication 'error' is intentional, as it is their way of handling edges: swt is forced to periodization, which appends copies of the array.
Furthermore, in swt, the wavelets overlap (i.e. first index in Haar is calculated using inidces 0 and 1, 2nd using 1 and 2, etc.), but with dwt there is no overlap. If I understand correctly, this is different from just upsampling the filter coefficients, correct?
I will look at the matlab code to see if I can find how the wavelets were calculated before...

repo: Radiomics/pyradiomics


text:
Security: Mallory can delete all the rooms

Anyone can fetch all the room IDs and delete all of the rooms

Yeah, I need to set some proper DB write rules ;P

authors: HaseebLUMS RafaeNoor

repo: RafaeNoor/GDrive-Party


text:
[Bug]: Sorting calendar_time field does not work as expected when the date format is modified

Contact Details
No response
What happened?
Sorting calendar_time fields sorts based on the output of the date format instead of the value of the date. Here's a video with using the date format EEE MMM dd yyyy hh:mm :
https://user-images.githubusercontent.com/80559262/196015377-e78722c3-9e2f-4650-a8b4-983bee49e91f.mp4
What platform were you using?
Desktop
Version of the plugin
2.7.2
Relevant log output
No response
Are you using the latest version of the plugin in your Obsidian vault?

[X] I have verified that I am on the latest version

Are you check if there is a similar issue?

[X] I have verified that there are not similar issues

the format affects the order. internally it's transformed to text and then its sorted
With the last version we adapt the sort function with its own parser function so I think it could be good idea to parse the datetime to   timestamp ans then apply the sorting

authors: RafaelGB icytree

repo: RafaelGB/obsidian-db-folder


text:
use of undeclared crate or module ufmt

Hi!
Throughout the examples
ufmt::writeln!(&mut serial, ...);

is used. If I do that I'm not able to compile and I get the following error:
48 |     ufmt::uwriteln!(&mut serial, "Hello from Arduino!\r").void_unwrap();
   |     ^^^^ use of undeclared crate or module `ufmt`

I tried to add ufmt under [dependencies] in the Cargo.toml as ufmt = "0.1.0". Doing so gives me access to the ufmt crate with use ufmt;. The code then compiles (although rust-analyzer in VSCode complains that it could not resolve macro `ufmt::uwriteln` ).
Is this how it is intended to work? Would be great if someone could help me with that! :)

Hey!
Yes, you need to add ufmt as a dependency to make this work.  I guess the documentation should be more clear on that ...
Why rust-analyzier is failing, I have no idea.  I'm also using it and did not see any such problems so far.  Can you get a more verbose output of what it is complaining about?

I have the same issue regarding rust-analyzer. Here's my repo: https://github.com/nbigaouette/robot-car/tree/343b89bc397dc99761de583d744ebe8d47dfd135/rust
I can cargo build and flash to my arduino uno (thanks for avr-hal!!) but rust-analyzer cannot find ufmt:

My guess is that rust-analyzer is confused with the target?

I've reported the rust-analyzer issue upstream: https://github.com/rust-analyzer/rust-analyzer/issues/7674

Turns out that ufmt uses proc-macro-hack which rust-analyzer does not supports... 🤷

Okay, as this is not really something related to avr-hal and there is an upstream report now, I'll close this issue here.

authors: MLackner Rahix nbigaouette

repo: Rahix/avr-hal


text:
Pacify clippy

cargo clippy had some complaints.  I think I pacified them.  There are other complaints, but my instincts tell me that "solving" those would break APIs.

I see in the commits for the PR that you originally had a new example included here: 53f594d  This example doesn't show up in the final diff, however?  If your intention was to also submit that example, maybe send a new PR with just that?

Ah, right, that example is already upstream as of #267 so ignore my previous comment.  I just got confused by seeing the commit here.

Rebased ontop of latest main.

authors: Rahix mutantbob


text:
Login to Rainloop from dedicated landing page - InvalidToken[101]'

I have a dedicated landing page to log in to the Rainloop (ex. https://webmail.somedomain.com) as a folder /login but I'm not able to login from that location - getting InvalidToken[101] error
Rainloop itself is installed on somedomain.com in /webmail/ folder and it works fine when I move my code from location above to the root of the web.
Any clue what is wrong with that setup?
Stack trace looks like
Stack trace:

#0 [internal function]: RainLoop\ServiceActions->ServiceAjax()
#1 /var/www/html/webmail/rainloop/v/1.9.1.333/app/libraries/RainLoop/Service.php(143): call_user_func(Array)
#2 /var/www/html/webmail/rainloop/v/1.9.1.333/app/libraries/RainLoop/Service.php(56): RainLoop\Service->localHandle()
#3 /var/www/html/webmail/rainloop/v/1.9.1.333/app/libraries/RainLoop/Service.php(79): RainLoop\Service->__construct()
#4 /var/www/html/webmail/rainloop/v/1.9.1.333/app/handle.php(83): RainLoop\Service::Handle()
#5 /var/www/html/webmail/rainloop/v/1.9.1.333/include.php(229): include('/var/www/html/m...')
#6 /var/www/html/webmail/index.php(13): include('/var/www/html/m...')
#7 {main}

It looks like
csrf_protection = Off
do the trick but IMO it shouldn't be a case in my example when I login from /var/www/html as www.somedomain.com vs /var/www/html/login served as webmail.somedomain.com
Any clue on that?

repo: RainLoop/rainloop-webmail


text:
🛑 HK区服 is down

In e16218c, HK区服 (https://$HK_SERVER) was down:

HTTP code: 0
Response time: 0 ms

Resolved: HK区服 is back up in d2e0682.

repo: RainThings/uptime


text:
🛑 HK区服 is down

In ea04067, HK区服 (https://$HK_SERVER) was down:

HTTP code: 0
Response time: 0 ms

Resolved: HK区服 is back up in d48ed32.


text:
Working on Synology DSM7

Hello,
Is this solution with USB stick possible on HA installed on a NAS Synology with DSM 7? As this version of DSM is not USB friendly.
What is the driver used for this stick.
Thank you

Hello,
I am running Home Assistant with becker on DSM 7.1 as VM in Virtual Machine Manager (ova image). Works perfect.
FYI: My synology has 6 GB RAM to run the VM and other apps.
Best Regards

Thank you very much for your Feedback.


text:
[Style] Home Page

What's the style idea?
We need to improve the overall look and feel of the Landing page of the website. I want to improve the hover effects of the cards made, the navbar, etc.
Checklist

[X] I have checked the existing issues.
[X] I follow Contributing Guidelines of this project.
[ ] I am a IWOC'24 contributor.
[ ] I am a JWOC'24 contributor.
[X] I am a SWOC'24 contributor.

Code of Conduct

[X] I agree to follow this project's "Code of Conduct".

Waht do you mean by overall look, as I need some screenshots or reference of your changes @Yuvraj960

Ok Rakesh.
Style 1:

Please refer to below right corner, the positioning of your chatbot button with the back-to-top button seems weird. Either we have to shift the chatbot button or the back to top button on the below left corner of the website.
Style 2:

We can add the Better UI for the Navbar, And Kinda add separation between the top page and rest scrolled website to add differentiation. Please see below the page reference:
https://github.com/Rakesh9100/Beautiify/assets/146326636/5c43445b-286c-46a1-a451-771eaa691bef
Style 3:
We can change the cards of the website.
Please refer to below attached video, I have 3 different designs to apply, the one you like I will apply it.
https://github.com/Rakesh9100/Beautiify/assets/146326636/dde3aeaa-8a3a-4852-ab31-40d99fe6cf96
Style 4: (Optional Change)
We can introduce the feedback system from users just like:
https://github.com/Rakesh9100/Beautiify/assets/146326636/ffdc9e5f-025b-4b65-9dcb-0b1fbe17e908
We can add this anywhere in the website, if want to.
Style 5:
We can change the social icon hover effects:
https://github.com/Rakesh9100/Beautiify/assets/146326636/6aaae420-2424-4b63-8fe9-87b0088f8824
This is all I think should be changed to enhance user experience.
You can also suggest me some of the changes that you want in your website, I will try find the best alternative style to that.

I want to add the above enhancements to the website.
@Rakesh9100, If you think something is wrong in my suggestion, please correct me.

Pls hold for now, will update you soon as one issue is already open before for enhancing the cards @Yuvraj960

Do you want to be assigned @Yuvraj960

Yes @Rakesh9100, I want to be get assigned, But can you please specify me the changes you want in the redesign of the website.

The website is already redesigned and looks good, so I don't have any specific idea for now. If you have, you can tell me @Yuvraj960

@Rakesh9100, I did like to change the design of the navbar of the Website as it doesn't look aesthetic on the website. It doesn't differentiate it's presence on the website. Same goes through the footer. I did like to redesign Navbar and footer section of the website.

Okay proceed and give your best, will merge if it will look good @Yuvraj960

Status of your PR pls @Yuvraj960

@Rakesh9100 , my new page development is in very early stages  as my exams are there and I have fever also, but I assure you, that my pr will be there next week in the pr section😇. Sorry for being late for this particular issue🙏

No issues, take care of your health first @Yuvraj960

@Rakesh9100, due to fever I was not very active on this issue.
Just updated my fork and seen that there are many design changes done for which I was developing code before fever, very sad to see this.
But still, I have something to add in the website code:

I can add the smooth transition when dark-light mode toggles
I can alter the appearance of footer, as at present it seems like a normal part of website, but after the changes I will make it a highlighted part of the website by completely revamping its look.
I want to change the location of the chat bot button as it comes in way of the back-to-top button.
Add some missing hover effects in website (navbar items, get compo... button, etc.)
This is all, I can change on the website as of now, rest if you can suggest any major change, you think is to be done on the website, please tell.
And also, if you think that the above changes need not to be done necessarily, please close the issue.

I have updated the cards design 2 days back to which it was before the new design due to some issue. So you can update and revamp the cards design, its hover effects on the home page to give a good look.
Navbar slight update has been done, so make sure to update your forked repo.
Alignment of chatbot button is already open, so leave this for now.
And also go for the enhancements you mentioned!! @Yuvraj960


text:
Declarator token is part of declarator rule

The problem
Rule appears as part of declarator token
Suggestions
Check how it's indexed and fix it.

Hmm, where? It does not seem to me, can you please clarify?

Is this because the heading is "Declarator rule rule"?

See discussion linked ticket.

authors: Altai-man JJ coke

repo: Raku/doc


text:
title html escaped too much?

Problem or new feature
https://docs.raku.org/routine/<==
Shows the title as:
infix <==
instead of
infix <==

Already fixed as http://164.90.207.89:10010/routine/<== <-

My recommendation is that we keep any issues that will be resolved by the new site open until at least we agree to deploy the new site; There are many tickets that fall into this category. Can you find that ticket and link to it?
We'll come out of the monthly call in May with a plan to address this kind of ticket, and hopefully a roadmap/timeline on the new site. Thanks

As a side note, tickets that are "fixed" in the new website are in general assigned to me (there are 30+ of those right now, and almost all can be considered resolved given the migration takes place). I can also "mark" this one.

I cannot duplicate this issue on the new site in progress at doc-website; (However I did find a different issue that I opened a ticket for).
Closing this ticket.

authors: Altai-man coke


text:
Adding wrong GSSoC labels!

You are adding a wrong label for the GSSoC-ext.
The level labels should not contain any spaces in between!
@RamakrushnaBiswal

@smog-root but my PRs are counted in the leaderboard
@sanjay-kv @MastanSayyad please review

@smog-root the labels are correct as said dashes are not allowed but spaces are.

@MastanSayyad ok I will change it :)

@MastanSayyad is this correct one ?

@RamakrushnaBiswal Level labels are correct, just change gssoc ext label
gssoc-ext

@MastanSayyad now

@RamakrushnaBiswal perfect

@RamakrushnaBiswal @MastanSayyad He provided me access to the repo., so i fixed it

You're repo is short listed for PA with wrong labeling.
https://docs.google.com/spreadsheets/u/0/d/1HogIA94g8XQnY1J2nfjFneUyuedxxO5TYAcYcbTBLhE/htmlview?pli=1

Okay got it! 👍

authors: MastanSayyad RamakrushnaBiswal sanjay-kv smog-root

repo: RamakrushnaBiswal/PlayCafe


text:
Created help page with FAQs

A new Help Page to the project, providing a centralized resource for users to find answers and support. The Help Page includes a wide range of frequently asked questions (FAQs) covering various topics related to the company and webpage.
Added contact info for contacting support team.
Issue: #344
Link added to the footer as instructed earlier.
Styled according to webpage aesthetics and colour pallet.
@RamakrushnaBiswal If any changes are needed, Lemme know. Happy to contribute.

Summary by CodeRabbit

New Features

Introduced a Help and Support page featuring a FAQ section for user inquiries.
Added a new navigation link for "Help and Support" in the footer.
Implemented a new route for the Help and Support component, accessible at /help.

Bug Fixes

Minor formatting adjustments made to enhance the layout and readability of the footer component.

@Sumanbhadra also match the colors with the UI and remove the footer part of the page like emails and phone

@Sumanbhadra also match the colors with the UI and remove the footer part of the page like emails and phone

Could you please be specific about the color of which part ?

@Sumanbhadra like the questions bg

this

@RamakrushnaBiswal Changed the UI color of FAQ to homepage bgcolor and removed the footer (email and phone no) from the page.
Could you please merge it now.

@Sumanbhadra make it responsive and
change the size

Is it okay ? @RamakrushnaBiswal

@Sumanbhadra its good make it responsive

@RamakrushnaBiswal Done 👍

authors: RamakrushnaBiswal Sumanbhadra


text:
Improving README.md steps in Development Internals

Rasa Open Source version
3.3.3
Rasa SDK version
No response
Python version
3.8
What operating system are you using?
Linux
What happened?
When I was intalling the environment to contribute with Rasa, first I got some instruction at this link, on the Rasa website.
On the site says we should install one of these Python supported versions: 3.7, 3.8, 3.9 or 3.10
And if we need to create a new virtual environment manually using those Python3 version, we can use the 2 command below:
python3 -m venv ./venv
source ./venv/bin/activate

But if we follow the steps at the official README.md, there says we should run the following command: python -m venv ./venv
Running this, we should get a "command not found" as this is not about the phython version 3.x we have (that is supported by Rasa)
This section at README.md should get updated to the Python3 command, as it happens on the official site rasa.com
Command / Request
No response
Relevant log output
No response

Hi @antoniotoineto
Thank you for reporting the issue!
We will look into it as soon as possible.

Hi @radovanZRasa
I've opened the PR #11908 to get this done!

authors: antoniotoineto radovanZRasa

repo: RasaHQ/rasa


text:
NLU correctly extracts intent, does not pass to slot via story

Rasa version:
Core: 0.13.7
Core-sdk: 0.13.0
NLU: 0.14.6
Python version:  3.6
Operating system:  Ubuntu 16.04
Issue: NLU correctly identifying intent, not passing to slot via story
Content of configuration file (config.yml):
language: "en"
pipeline:
- name: "nlp_spacy"
- name: "tokenizer_spacy"
- name: "intent_entity_featurizer_regex"
- name: "intent_featurizer_spacy"
- name: "ner_crf"
- name: "intent_featurizer_count_vectors"
- name: "intent_classifier_tensorflow_embedding"
- name: "ner_duckling_http"
  url:  "http://0.0.0.0:8000"
  dimensions: ["time"]

Content of domain file (domain.yml) (if used & relevant):
intents:
  - greet
  - goodbye
  - get_quote_withinfo
  - get_quote
  - modify_booking
  - thanks
  - inform_city
  - inform_date
  - check_status

actions:
- utter_greet
- utter_goodbye
- utter_welcome
- utter_get_quote
- utter_slot_values
- utter_submit
- utter_ask_source # should this not be included by default, will i be overriding shit?
- utter_changebook
- utter_check_status

entities:
  - source
  - destination
  - day
  - month
  - year
  - time_day
  - new_day
  - new_month
  - date
  - city
  - time

slots:
  source:
    type: unfeaturized
    auto_fill: false
  destination:
    type: unfeaturized
    auto_fill: false
  date:
    type: unfeaturized
    auto_fill: false
  day:
    type: unfeaturized
    auto_fill: false
  month:
    type: unfeaturized
    auto_fill: false
  year:
    type: unfeaturized
    auto_fill: false
  time_day:
    type: unfeaturized
    auto_fill: false

templates:
  utter_greet:
  - text: "Hello! How can I help?"
  - text: "Hiya!"
  utter_goodbye:
  - text: "Goodbye!"
  utter_ask_source:
    - text: "Where are you shipping from?"
  utter_ask_destination:
    - text: "Where are you shipping to?"
  utter_ask_date:
  - text: "When do you want your items to ship from {source}?"
  utter_welcome:
    - text: "You're welcome!"
    - text: "No worries :)"
  utter_get_quote:
    - text: "Okay, lets get a quote going"
  utter_changebook:
    - text: "Okay, let me grab that booking for you"
  utter_slot_values:
    - text: "I am going to run a quote search using the following parameters:\n
            - source: {source}\n
            - destination: {destination}\n
            - date: {day} of {month}\n
            - time: {time_day}"
  utter_submit:
    - text: "All done!"
  utter_default:
    - text: "Totes soz, I don't understand what you mean there, can you rephrase please?"
  utter_ask_month:
    - text: "What day of {year}"
  utter_ask_day:
    - text: "What day of {month}"
  utter_ask_time_day:
    - text: "What time on {day}"

forms:
  - booking_form

**Content of stories.md
## new_quote2
* greet
  - utter_greet
* get_quote{"source":"perth"}
  - utter_get_quote
  - booking_form
  - form{"name": "booking_form"}
  - form{"name": null}
  - utter_slot_values
* goodbye
  - utter_goodbye

I am trying to make a fairly standard variation of the form bot which will make bookings. If the user writes 'make booking' and starts the form then everything works fine. However, I would like to be able to extract information from the very first sentence before an intent has been classified (i.e. before a form is used). It seems this is done via slot filling directly in the stories but i cannot get it to work. In the attached image it shows that NLU is correctly pulling the source city (though admittedly low confidence but that's fine) but the form is still asking for it.
I have tried several variations (i.e. putting the slot filling part in the story after the form is activated) but nothing seems to work, what am i missing?
Thanks!

Thanks for raising this issue, @Ghostvv  will get back to you about it soon.

what version of rasa_core_sdk are you using? it didn't validate already filled slots. We updated forms to add this functionality: https://github.com/RasaHQ/rasa_core_sdk/pull/67
Could you please try a new version

Hello,
The versions I used for that example are listed at the top of the post. I did a pip install --upgrade and am now running
rasa-core                     0.13.8
rasa-core-sdk                 0.13.1
rasa-nlu                      0.14.6
but the issue persists. NLU correctly pulls the entity but the slot remains unfilled. Is there a particular version i should specifically request through pip? I have attached another image showing the same thing happening.
Thanks!

Update: okay I think I have a better idea of my confusion, and I have made a more compact example to illustrate this.
Let's say I have two slots to fill, pickup_city and pickup_street. I have two entities of the same name, so I can extract them directly, but I also want to be able to extract them from a more general intent 'inform_address' which may be used for pickup but also for dropoff. So, for this intent i have two other entities just 'street' and 'city.
What I thought would happen is if i have the following form definition:
` @staticmethod
def required_slots(tracker: Tracker) -> List[Text]:
return ["pickup_city", "pickup_street"]
 def slot_mappings(self):
			return {
				"pickup_city": [ self.from_entity(entity="pickup_city", intent = ["make_booking"]),self.from_entity(entity="city",intent=["inform"])],
				"pickup_street": [self.from_entity(entity="pickup_street", intent = ["make_booking"]),self.from_entity(entity="street", intent = ["inform"])]
			}`

that if the form asked for 'pickup_city' but I gave 'city' and 'street' (as correctly extracted by NLU), then the slot mapping would not only give me pickup_city but also see that it extracted 'street' and map that to 'pickup_street'. However, this does not happen: it does not see that it can fill a slot it knows about by using an entity it has just seen.
For example, if I change it so the required slot it 'street' then this works: I give it a city and a street at the same time and it sees 'street' as the extra slot to fill and does so (though here it would not work because i have not defined 'street' as a slot but i can see it is trying to do the right thing anyway)
So, while I understand i could get around this by having a custom 'validate' function, am I wrong in thinking this sort of thing should happen by default?
Thanks again!

Do you have another action or utterance between a user input and a form? By default, validation is triggered only if the form is called after action_listen

I did have that, though if I remove it i still get the same thing. I have changed the setup quite a bit since the last round, sorry, so here is the new setup.
## intent:get_quote
- get quote
- make quote
- hello, i want to get a quote
- hi i need a quote
- hey i want to find out how much it will cost
- how much will it cost to send stuff from [bayswater](pickup_suburb) to [castlemaine](dropoff_suburb)?
- i want to send some items
- i want to ship some freight
- i want to ship items to [moonah](dropoff_suburb)
- i want to send items to [mildura](dropoff_suburb)
- i need to ship to [petersham](dropoff_suburb)
- i want to send some items from [brisbane](pickup_suburb)
- i want to ship some freight [rye](pickup_suburb)
- i want to send items from [petersham](pickup_suburb) to [brisbane](dropoff_suburb), how much will it cost?
- i need a quote on sending from [new town](pickup_suburb) to [ultimo](dropoff_suburb)
- i want to send items to [petersham](dropoff_suburb) from [brisbane](pickup_suburb), how much will it cost?
- i need a quote on sending to [new town](dropoff_suburb) from [ultimo](pickup_suburb)
- how much will it cost to send stuff to [bayswater](dropoff_suburb) from [castlemaine](pickup_suburb)?

## new_quote1
- utter_intro
* get_quote
  - pickup_address_form
  - form{"name": "pickup_address_form"}
  - form{"name": null}
  - dropoff_address_form
  - form{"name": "dropoff_address_form"}
  - form{"name": null}
  - items_form
  - form{"name": "items_form"}
  - form{"name": null}
  - utter_return_quote

 @staticmethod
 def required_slots(tracker: Tracker) -> List[Text]:
 	return ["pickup_suburb", "pickup_postcode", "pickup_residential"]

 def slot_mappings(self):
	return {
		"pickup_suburb": [ self.from_entity(entity="pickup_suburb", intent = ["make_booking"]),self.from_entity(entity="suburb",intent=["inform_address"])],
		"pickup_postcode": [self.from_entity(entity="pickup_postcode", intent = ["make_booking"]), self.from_entity(entity="postcode", intent = ["inform_address"]), self.from_entity(entity="number", intent = ["inform_address"])],
		"pickup_residential": [ self.from_intent(intent='affirm', value=True), self.from_intent(intent='deny', value=False)]
	}

 # NOTE: this is infact called for each slot at time of filling, not at the end
 def validate(self, dispatcher: CollectingDispatcher, tracker: Tracker, domain: Dict[Text, Any]) -> List[Dict]:

	slot_values = self.extract_other_slots(dispatcher, tracker, domain)
	slot_to_fill = tracker.get_slot(REQUESTED_SLOT)
	if slot_to_fill:
		slot_values.update(self.extract_requested_slot(dispatcher, tracker, domain))
		if not slot_values:
			raise ActionExecutionRejection(self.name(), "Failed to validate slot {0} "
														"with action {1}"
															"".format(slot_to_fill,self.name())
															)

	latest_message = tracker.latest_message['entities']
	updated_slots = {}

	for el in latest_message:
		value = el['value']
		if el['entity'] == 'postcode':
			updated_slots['pickup_postcode'] = value
		elif el['entity'] == 'suburb':
			updated_slots['pickup_suburb'] = value

	for slot, value in updated_slots.items():
		slot_values[slot] = value

	return [SlotSet(slot, value) for slot, value in slot_values.items()]

I have attached an image of the output. Is it possible because i have overwritten the validate() function it is no longer looking for other prefilled stuff? The Core output shows NLU extracting the pickup_suburb correctly but it still does not apply it to the appropriate slot

Thanks!

A thousand apologies, I had changed one of my intents and failed to update my actions.py
For now this seems to work swimmingly so I am happy to close the issue, however it would still be good to know how to utter a message at the start of a form without losing the slot filling aspect.

there is _activate_if_required method, which you can copy and add utterance upon activation there.
there is slot mapping from_trigger_intent that should fill the slot upon form activation depending on user intent that triggered the form

however it would still be good to know how to utter a message at the start of a form without losing the slot filling aspect. - we thinking about the most general way to implement it

Ah okay great, will play with that. For now I just have a custom action
class FillAll(Action):
	def name(self):
		return "action_fillall"

	def run(self, dispatcher, tracker, domain):
		latest_message = tracker.latest_message
		entities = latest_message['entities']
		slots = tracker.slots.keys()

		result = []
		for el in entities:
			if el['entity'] in slots:
				result.append(SlotSet(el['entity'], el['value']))
		return result

which has zero error handling and is lazy but seems to work.
Regarding 'best way' ideally, at least from myself as a user point of view, something akin to the submit() method, basically an init(), would be great.

Hello,
I'm afraid i need to re-open this issue. I went back to a previous version of forms/stories and have come up against this issue again, though it may be me expecting something that isn't meant to happen. Note I have re-read the above stuff to make sure i'm not re-hashing old solutions.
Problem is simple: given the following FormAction (leaving validate() un-overloaded)
class QuoteForm(FormAction):

    def name(self):
        return "quote_form"

    @staticmethod
    def required_slots(tracker: Tracker) -> List[Text]:
        return ["pickup_suburb", "pickup_postcode"  ]

    def slot_mappings(self):
        return {
            "pickup_suburb": [
                self.from_entity(entity="pickup_suburb", intent = ["quote"]),
                self.from_entity(entity="suburb",intent=["inform_address"])],
            "pickup_postcode": [
                self.from_entity(entity="postcode", intent = ["inform_address"]),
                self.from_entity(entity="pickup_postcode", intent = ["quote"]),
                self.from_entity(entity="number", intent = ["inform_number"])]

and story
## quote
* greet
  - utter_greet
* quote
  - quote_form
  - form{"name":"quote_form"}
  - form{"name": null}

I want to be able to respond to suburb and postcode at the same time when suburb is asked for. Specifically, when it asks for suburb  it actually asks for suburb and postcode, so the user has the option to enter both at the same time. I had assumed that the mappings defined above would mean that it would get the postcode even though only suburb was asked for, is that not the case?
An example response i am trying to parse when asked for suburb is " perth 2000" with intent inform_address
I can put a whole bunch of things in validate to deal with this, but it would involve lots of intent checking which should be handled already by the slot mappings (I will have pickup/dropoff and so on)
Thanks!
Z.

Update: Okay I think i have answered my own question, apologies for the threadnaught.
I managed to hack my way to what i wanted but turns out what i wanted isn't what i needed, as i end up overriding slots ahead of time. I think i saw mention of 'groups' being maybe implemented in the future which may solve this problem.
For now I think I  will just define sets of slots that may be set together and others which can only be set when asked for.
Thanks!

so can we close this issue again?

Yes, my apologies, thanks!

authors: Ghostvv Zylatis akelad


text:
outdated screenshot/info for share your bot

the rasa x docs currently have share your bot in the wrong place.

closed as PR was closed


text:
webchat is not working

Webchat is not working anymore with the 1.3 release

Thanks for raising this issue, @erohmensing will get back to you about it soon✨
Please also check out the docs and the forum in case your issue was raised there too 🤗

@ice2tricky you'll have to be a little more descriptive if you want help -- what is going wrong? What is different between 1.2.7 and 1.3.0?

As described in the issue template

THIS INFORMATION IS MANDATORY - YOUR ISSUE WILL BE CLOSED IF IT IS MISSING.

please fill out the issue template so we can help you.

authors: erohmensing ice2tricky sara-tagger


text:
RuntimeError: This event loop is already running

Thanks for the question, our Github issue board is for bugs and feature requests only, though 😕
Please ask this question in the forum✨
If you were describing a bug, please create a report and fill out the template.

Thanks for raising this issue, @closed will get back to you about it soon✨
Please also check out the docs and the forum in case your issue was raised there too 🤗

authors: dmw-cola sara-tagger


text:
DucklingHTTPExtractor with defined request timeout

Proposed changes:

Fixed the bug being discussed under #1695
Added a timeout of a default of 3 seconds to t.he Duckling HTTP Request Invocation and made it a configurable component parameter.
Updated the docs to reflect the new timeout parameter.
Updated the changelog to reflect the fix.
Reformatted the code using black.
Ran a few tests to ascertain the fix.Attached a screenshot (below) of the test that fulfills the fix.

Status (please check what you already did):

[x] made PR ready for code review
[ ] added some tests for the functionality
[x] updated the documentation
[x] updated the changelog
[x] reformat files using black (please check Readme for instructions)

Thanks @imLew for all your patience and support that you extended for this PR .Glad that I could finish my first contribution to Rasa.Hoping for many more contributions to come.


text:
Clean Duplicate Line

Proposed changes:

minor code clean up

Status (please check what you already did):

[ ] ~added some tests for the functionality~
[ ] ~updated the documentation~
[ ] ~updated the changelog~
[ ] ~reformat files using black~

Thanks for submitting a pull request 🚀 @tttthomasssss will take a look at it as soon as possible ✨

authors: Mazyod sara-tagger


text:
Fix featurizers

Proposed changes:

add binary_intent_prob flag to TrackerFeaturizer. If it is set to True (default behavior), binarize intent probabilities on the states level
merge Binary- and ProbabilisticSingleStateFeaturizer together

Status (please check what you already did):

[x] made PR ready for code review
[x] added some tests for the functionality
[ ] updated the documentation
[ ] updated the changelog

good job 💯

authors: Ghostvv tmbo


text:
Remove broken format script

This script is broken, because no .prettierrc file is included in the repo.
We're relying on the prettier plugin for eslint to do code formatting & checking, e.g. in .github/workflows/ci-cd.yml where we invoke yarn lint to check the formatting.
Similarly, the lint:fix script can be used to apply formatting. So the format script is redundant and potentially confusing to new developers.

LGTM

Thanks, @danhalson. I seem to have lost your review approval by rebasing the branch and fixing the conflicts. Any chance you could re-add it?

repo: RaspberryPiFoundation/editor-ui


text:
minecraft:chest is unsupported

There is an unsuported block in this world and it was skipped
x:12 Y:1 Z:6, Block:minecraft:chest, Variant: default

Not sure what the problem is. I do see references in the project, but I'm not familiar with python, so I can't actually debug this.
This happens with any mcstructure file created with the latest minecraft version (1.20.50). Not sure if this was a issue before in older versions or on what version this problem started.

Fixed

authors: NickdeK RavinMaddHatter

repo: RavinMaddHatter/Structura


text:
Support stdout output

Resvg supports reading input file from stdin but there's no support to write output to stdout which might be useful to avoid intermediate file storage.
I tried to use /dev/stdout as output file argument, it seems to work but produces broken output.

Why would you want PNG in stdout? What is the use case?

Why would you want PNG in stdout? What is the use case?

My use-case is web service which generates SVG in memory and returns PNG as a response to the caller. Right now I'm using random file name on tmpfs filesystem which is supplied as output filename to resvg, then I read that file in memory, delete it from tmpfs and return response to the client. Using stdout would allow to simplify that workflow. I could imagine that I'm not the only one using resvg in that manner.

Ok, makes sense.

That's exactly my workflow as well.

authors: PlkMarudny RazrFalcon vbezhenar

repo: RazrFalcon/resvg


text:
Introducing new  prop - allowModifiedKeys

In some cases I want to allow the special keys (e.g. alt, ctrl, meta, shift) to be pressed while clicking on a Link component.
This new prop (default false) will allow just that.

We need to ignore these keys, as they map to new windows and tabs in most browsers. If we don't, the browser behavior will change.

authors: timdorr uditalias

repo: ReactTraining/react-router


text:
Older version of symbol-observable still getting installed with beta.9

RxJS version: 5.0.0-beta.9
Code to reproduce:
npm i rxjs-es
Also have example repo where I identified the issue and have a workaround.
Expected behavior:
Installs and uses 1.0.1 ES6ified version of symbol-observable
Actual behavior:
Look in node_modules/rxjs-es, there's a child node_modules folder that has v0.2.4
(side questions: shouldn't it be a sibling in top-level node-modules?)
Additional information:
Using rollup with RxJS which works great except that CJS require gets stuck in from older symbol-observable

It is expected. PR https://github.com/ReactiveX/rxjs/pull/1772 has been checked in after publishing beta.9,  so latest package still points at old version of symbol-observable. Next package will point latest package dependencies. Let me close this issue for now, please feel freely reopen / file other issues if there's other issues unresolved.

authors: kwonoj martypdx

repo: ReactiveX/rxjs


text:
Add a note to lettable-operators.md that static methods do not need a lettable variant.

A few times already i've had questions on gitter about lettable operators ( https://github.com/ReactiveX/rxjs/blob/master/doc/lettable-operators.md ) and why static operators like fromEvent have no lettable variant.
Obvious, (at least to me,) is that lettable operators are made to replace instance methods (that modify Observable.prototype) with static methods, so that you can tree shake, remove dead code etc.
Operators that are already static (all creating operators like of, fromEvent and the static variant of combineLatest) have no need for a lettable variant. Thus upgrading to lettable operators, there is no need to modify code that uses already static operators, or to import them differently.
This note should probably be added to the docs somewhere.

why static operators like fromEvent have no lettable variant.

AFAICS, they do:
import { fromEvent } from 'rxjs/observable/fromEvent';
import { of } from 'rxjs/observable/of';
import { defer } from 'rxjs/observable/defer';

Do I misunderstand?
Alternatively, users may continue to import patches, such as
import 'rxjs/add/observable/of';

Is this correct?

Actually, going by the definition of "lettable operators", these imports are not technically "lettable operators":
import { fromEvent } from 'rxjs/observable/fromEvent';

any function that returns a function with the signature: <T, R>(source: Observable) => Observable.

https://github.com/ReactiveX/rxjs/blob/339092628201a1f9a784dcde1905f700dacffe0a/doc/lettable-operators.md#what

authors: Dorus OliverJAsh


text:
[fromEvent] consistency of single / multiple argument event emissions

Taken here from #3362
The current fromEvent implementation emits single argument events unchanged and wraps multiple arguments in an array. There's an edge case I find worth discussing when a single argument is an array:
fromEvent(myEmitter, 'myEvent').subscribe(console.log);

myEmitter.emit('myEvent', 1);
// 1

myEmitter.emit('myEvent', 1, 2);
// [1, 2]

myEmitter.emit('myEvent', [1, 2]);
// [1, 2]

There's no way for the observable consumer to tell cases 2 and 3 apart.
@benlesh mentioned the possibility of undeprecating the fromEvent result selector.
Another (breaking) solution that comes to mind would be wrapping single arguments as well:
myEmitter.emit('myEvent', 1);
// [1]

myEmitter.emit('myEvent', 1, 2);
// [1, 2]

myEmitter.emit('myEvent', [1, 2]);
// [[1, 2]]

@kwonoj is there a way to proceed with this or close it?

Closing this in favour of #4736 because this comment describes the favoured solution:

Maybe with all of the functions that do this (bindCallback and friends also do this), we could return the result selector, and just the result collector gets args[] but the default, without the result selector will always just be the first argument.
So, let's say your fromEvent source has 3 args: number, string, boolean:   fromEvent(thing, 'whatever') would return Observable<number> always. BUT, fromEvent(thing, 'whatever', (a: number, b: string, c: boolean) => of([a, b, c])) would give you Observable<[number, string, boolean]>.
It's an idea. Of course, we'd need to wait a long time to introduce this, because it's a breaking change.

authors: BioPhoton cartant j2L4e


text:
Filter operator predicate overwrites the observable's type

Bug Report
Current Behavior
The type of the first argument of the predicate passed to the filter operator will overwrite the observable's type. The linked stackblitz shows the issue very clearly, hover the variable name to see its type.
Reproduction
// type of filteredNumber$ is Observable<any>
const filteredNumber$ = of(5).pipe(filter((num: any) => true));

Reproduction with possible solution: https://stackblitz.com/edit/rxjs-filter-typing?file=index.ts&view=editor
Expected behavior
The filter operator does not affect the type of the observable it is used on.
// type of filteredNumber$ is Observable<number>
const filteredNumber$ = of(5).pipe(filter((num: any) => true));

Environment

Runtime: any
RxJS version: 6.4.0

Possible Solution
Use a second type parameter for the predicate argument, so it doesn't affect the return type:
type newFilterType = <T, R extends T = T>(predicate: (value: R, index: number) => boolean, thisArg?: any) => MonoTypeOperatorFunction<T>

Context
Came across this issue when trying to use filter(Boolean). Noticed the type of the observable was lost after the filter operator. I'm willing to submit a PR with a solution if that's useful 😄

distinctUntilChanged has the same issue, added it to the stackblitz. There are probably some more operators I'm not thinking of 😛

By explicitly declaring the type as any you have widened it. So this is the expected behaviour.

I understand, in my example it's pretty explicit but in practice it can be less intuitive:
// type of filteredNumber$ is Observable<any>
const filteredNumber$ = of(5).pipe(filter(Boolean));

or
import { filterPredicate } from 'dependency-without-typedef';

// type of filteredNumber$ is Observable<any>
const filteredNumber$ = of(5).pipe(filter(filterPredicate));

Personally I didn't expect filter to have any effect on the type of the Observable.

filter (and distinctUntilChanged) emissions will always be a subset of their inputs, so they "real" types must also be a subset of the input types. Given that, it seems like ideally the typings for these should never be able to widen types, whatever predicates are passed? And if that can be achieved in a way that doesn't break anything else then that's the way it should be?
If there's something wrong with that logic, or if there's some strong consistency-based reason for inferring filter's output type from the arg type then ok, but otherwise it seems like a simple question of whether @eliasmeire 's possible solution breaks any other type behavior (e.g. can it be added in a way that doesn't stop you from being able to narrow the type, which you definitely should be able to)?

The problem is that the inference of the type parameter for filter will first come from the callback passed. If the type can be inferred from that callback, then that's what will be used. This all happens before pipe is even considered.
Essentially it is:
const op = filter((num: any) => true); // OperatorFunction<any, any>
const filteredNumber$ = of(5).pipe(op); // Observable<any>

It's the first step that is the problem. You have introduced an OperatorFunction that is specifically typed as any. And that is compatible with the number from the source observable, so TypeScript is happy.
Because it's an OperatorFunction<any, any>, the type of the Observable that's returned by pipe will be any. pipe has no idea about the semantics of filter, it just uses the second type parameter from OperatorFunction as the type for the Observable that is returned or input into the next operator.
AFAICT, there is nothing that can be done about this and the behavior is expected.

@eliasmeire I'm not sure that your proposed solution solves the problem. It doesn't appear to solve it for me. filter already has a signature similar to yours:
export declare function filter<T, S extends T>(predicate: (value: T, index: number) => value is S, thisArg?: any): OperatorFunction<T, S>;

And adding S extends T = T does not appear to solve the problem, AFAICT.

Yeah, sorry, good explanation @cartant - here's a stackblitz showing the problem https://stackblitz.com/edit/rxjs-pxbhzr

The filter(Boolean) bit is fixed now, and the rest is working as expected.

authors: benlesh cartant eliasmeire elsmr jgbpercy


text:
switchMap operator keeps the values from previous observable sequence.

Bug Report
Current Behavior
When I use the switchMap operator twice, it keeps the values from the first one.
Reproduction
import { of, from } from 'rxjs'
import { switchMap, tap } from 'rxjs/operators'

of({})
  .pipe(switchMap(() => from([1, 2, 3])))
  .pipe(switchMap(() => from([4, 5, 6])))
  .pipe(tap(number => console.log(number)))
  .subscribe()

/*
As a result, we get the following console output:
4
5
6
4
5
6
4
5
6
*/

Expected behavior
/*
The console output should be:
4
5
6
*/

Environment

Runtime: Node v10.15.3
RxJS version: 6.5.2

Additional context/Screenshots

This is the expected behaviour.

Sorry, my bad. To get the expected described, expected behaviour, this is the right code:
import { of, from } from 'rxjs'
import { switchMap, tap, toArray } from 'rxjs/operators'

of({})
  .pipe(switchMap(() => from([1, 2, 3])))
  .pipe(toArray())
  .pipe(switchMap(() => from([4, 5, 6])))
  .pipe(tap(number => console.log(number)))
  .subscribe()

Thx you.

authors: RaduBuciuceanu cartant


text:
docs(content): add testing guide

I have migrated the marble testing docs from the "old" docs.
I have also added the internal testing document but not linked it obviously. So we could use it for pointing in prs or similar

Pull Request Test Coverage Report for Build 7404

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 96.806%

Totals

Change from base Build 7399:
0.0%

Covered Lines:
5244

Relevant Lines:
5417

💛  - Coveralls


text:
feat(Subject): add isObserved() api

Description:
This PR adds an api subject.isObserved() to handle the common use case of the deprecated subject.observers member

https://stackoverflow.com/questions/44555615/rxjs-detect-when-observable-has-been-subscribed-to
https://stackoverflow.com/questions/33441393/is-there-a-way-to-check-for-output-wire-up-from-within-a-component-in-angular-2

Relates to: #5967

I'm generally in favor of this addition. However, it requires core team agreement.

Notes from core team meeting: Approved, but it should be a readonly property observed, not a method.

@bbarry thanks for this important contribution! It's now out in version 7.1.0

authors: bbarry benlesh


text:
Fix the styling of Github Sign in button

Need to make text and logo in a line .

assign @gunjal-prajakt26

repo: Real-Dev-Squad/website-www


text:
[Ember-Migration] Create a 404 Page

Issue

We don't have a found page present and if someone visits any unavailable route they get error of Unrecognized URL

Solution

Create a 404 page using ember generate route 404 command. For reference : https://guides.emberjs.com/release/routing/defining-your-routes/
Code Reference : Refer to this issue and the linked PR with it https://github.com/Real-Dev-Squad/website-my/issues/324
Live Reference: https://my.realdevsquad.com/404

Write Tests for it (Mandatory) - Refer to other files

Note

PR should be raised to develop-ember not develop
Please follow the CSS patterns like BEM in class names and use CSS Modules. Refer to the existing code
Also, use the information above to write the code.

Hi I want to take this task


text:
Rewrite with posthtml

Judging from your other projects, this is probably on-track with your goals. I've built something similar already this week, using some of your tools and others not. Instead of creating my own project, it might be beneficial to us both to keep the work here. Let me know your thoughts.
The biggest thing preventing that from happening, I think, would be if your opinions on #18 have not changed.

Actually, now that I know about GMail supporting <style>, my project idea is mostly useless.

repo: Rebelmail/html-preflight


text:
MAJ des textes descriptif sur le github

MAJ des textes descriptif sur le github
choix edition des pages WIKI ?
ou Github pages ?

done :)

repo: Recovid/Documentation


text:
Run sonarqube scan during PR check and merge to main

Add steps to execute sonarqube scan

Codecov Report

Merging #338 (6dc1331) into main (6589d24) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #338   +/-   ##
=======================================
  Coverage   24.92%   24.92%
=======================================
  Files          29       29
  Lines        2704     2704
=======================================
  Hits          674      674
  Misses       1955     1955
  Partials       75       75

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6589d24...6dc1331. Read the comment docs.

authors: chambridge codecov-commenter

repo: RedHatInsights/edge-api


text:
webui.go:620:19:1 other occurrence(s) of "link" found in: webui.go:626:14

webui.go:620:19:1 other occurrence(s) of "link" found in: webui.go:626:14

Fixed in https://github.com/RedHatInsights/insights-operator-web-ui/pull/125

repo: RedHatInsights/insights-operator-web-ui


text:
[tracking] Problem detected in BASH script: In ./checks/check_localhost.sh line 29

https://github.com/RedHatInsights/insights-results-aggregator-mock/issues/113

Fixed in https://github.com/RedHatInsights/insights-results-aggregator-mock/pull/118


text:
[tracking]  Incorporate Go error checker into CI configuration

https://github.com/RedHatInsights/insights-results-aggregator-mock/issues/127

Fixed in https://github.com/RedHatInsights/insights-results-aggregator-mock/pull/128


text:
[RHCLOUD-13364] refactor: make the spec match the back end's endpoints

The things that have been done:

Fix license URL to use the "https" scheme.
Add the ability to authorize using headers.
Include all the environments: local, staging and production.
Improve some of the descriptions for the endpoints.
"400" returns for many endpoints that lacked them.
Update the models for the payloads and responses, which weren't 100%
accurate.
Add a missing "/application_authentications/{id}/authentications" endpoint.

Links
[RHCLOUD-9245]
[RHCLOUD-18477]
[RHCLOUD-13364]

The SonarQube failure is related to this PR: https://github.com/RedHatInsights/sources-api-go/pull/335 .

/retest

authors: MikelAlejoBR lpichler

repo: RedHatInsights/sources-api-go


text:
Option to specify Jira epic (or task) for further task (or subtask) creation

Currently, if an user wants NEWA to use already existing epic and let it add tasks there, the only option is to define identier in config:
issues:
  - ...
    newa_id: "XYZ#{{ ERRATUM.id }}"

and add the identifier (::: NEWA XYZ#123) to epic description.
It would be simpler to have an option in CLI to choose which epic should be used rather then have specific identifier and need to edit epic description.

Given it won't be NEWA finding the issue but a user telling issue ID, we need to make sure NEWA would find it in subsequent invocations and except updating newa ID (which should be already in the code) we need to also add NEWA label.

WIP in https://github.com/RedHatQE/newa/pull/117

Merged.
Another related MR https://github.com/RedHatQE/newa/pull/118

authors: kkaarreell mildas

repo: RedHatQE/newa


text:
add /mars endpoint

Merge from dev master

Approved


text:
Support fetching from RedisJSON datasource

Is your enhancement related to a problem? Please describe.
Ability to display data stored in RedisJSON in Grafana. Most notably for the table plugin.
Describe the solution you'd like
Ability to connect to a ReidsJSON datastore, query, search, filter and display data Grafana.
Describe alternatives you've considered
JSON API Grafana datasource which connects to http JSON PATH compliant APIs.
Additional context

@xkilian Thank you for the feature request. Do you have any particular command from the RedisJSON module you want to use?
We started to introduce support for Redis modules and I will target to add support for some RedisJSON command in 1.3.1.

The principal use-case would be GETting data from RedisJSON et being able to display it Grafana. Perhaps MGET as well. Second order would be meta-data about what is being displayed (TYPE).
I think KEYS would also be important but more from a searching perspective which should be built-in to the datasource. But could also be a method of list the keys explicitely.  I am not sure I see much value in writing to RedisJSON for most users at this ime from Grafana.
So: KEYS, GET, MGET, TYPE.

@xkilian Thank you, I will let you know when ready.

I still look forward to this feature and will provide testing. Thank you for this great plugin.

@xkilian I am sorry for the delay. I am working on it.

Hi,
Still looking forward to hearing something new about supporting rejson.
Thank you

@trungswat I am sorry for the delay, I am working on it right now.

authors: mikhailredis trungswat xkilian

repo: RedisGrafana/grafana-redis-datasource


text:
validation of sample : readOnly / writeOnly  and required statement interaction

Describe the bug
given an API specification mixing required keyword and readOnly , writeOnly redocly generate a warning wheras it should not
To Reproduce
given the minimal files attached  small.json
redocly lint generate 2 warnings
Expected behavior
it should not,
the object contains Id , name , password ,  both are required ... in differents scenario

id is set to ReadOnly
password as WriteOnly

i would expect to do a single representation of my object, for input / output  and exemple matching
this is a quite common use case (especially for id that is generated by server so mandatory in return only ... so readOnly)
i extended the use case to writeOnly and password just for the record.
The Json Schema specification is not 100 % clear if there is a precedence between required statement and the readOnly and writeOnly context  .
=> discussing with JsonSchema team , it is up to the upper layer aka OAS / and so redocly to "customize" the validation as it is the only pieces that has the information
Logs
Example value must conform to the schema: must have required property 'id'.

80 | "inputExample" : {
81 |     "description" : "sampleOfInput",
82 |     "value" : {
83 |         "name" : "Doe",
84 |         "password" : "securityFirst"
85 |     }
86 | },
87 | "outputExample" : {

referenced from small.json:23:45 at #/paths/~1test/post/requestBody/content/application~1json

Warning was generated by the no-invalid-media-type-examples rule.

[2] small.json:89:27 at #/components/examples/outputExample/value

Example value must conform to the schema: must have required property 'password'.

87 |     "outputExample" : {
88 |         "description" : "sampleOfOutPut",
89 |         "value" : {
90 |             "id" : "goodId",
91 |             "name" : "Doe"
92 |         }
93 |     }
94 | }

referenced from small.json:39:49 at #/paths/~1test/post/responses/200/content/application~1json

Warning was generated by the no-invalid-media-type-examples rule.

Redocly Version(s)
redocly 1.8.1
Additional context
thx for your attention , do not hesitate to close it if you consider it as too corner case

Oh, this is indeed a corner case. Nevertheless, it is still worth fixing. Thank you for bringing this up!

Hi, I ran into this exact issue. We make use of the readOnly attribute a lot in our definitions, and I think it would be great if you could fix this issue. It is interesting that another OpenAPI linter ran into the same issue and fixed it.

authors: LasneF r-reload tatomyr

repo: Redocly/redocly-cli


text:
How does it work?

Hello, thanks for the project!
I couldn't find any documentation or tutorial. How does the tool work?

https://github.com/Refloow/Steam-Games-Idle#setup-guide-step-by-step
Make sure to read readme.md

authors: Refloow fcakyon

repo: Refloow/Steam-Games-Idle


text:
浏览器的渲染过程

首先解析收到的文档，根据文档定义构建一棵 DOM 树，DOM 树是由 DOM 元素及属性节点组成的。
然后对 CSS 进行解析，生成 CSSOM 规则树。
根据 DOM 树和 CSSOM 规则树构建渲染树。渲染树的节点被称为渲染对象，渲染对象是一个包含有颜色和大小等属性的矩形，渲染对象和 DOM 元素相对应，但这种对应关系不是一对一的，不可见的 DOM 元素不会被插入渲染树。还有一些 DOM元素对应几个可见对象，它们一般是一些具有复杂结构的元素，无法用一个矩形来描述。
当渲染对象被创建并添加到树中，它们并没有位置和大小，所以当浏览器生成渲染树以后，就会根据渲染树来进行布局（也可以叫做回流）。这一阶段浏览器要做的事情是要弄清楚各个节点在页面中的确切位置和大小。通常这一行为也被称为“自动重排”。
布局阶段结束后是绘制阶段，遍历渲染树并调用渲染对象的 paint 方法将它们的内容显示在屏幕上，绘制使用 UI 基础组件。

注意

这个过程是逐步完成的，为了更好的用户体验，渲染引擎将会尽可能早的将内容呈现到屏幕上，并不会等到所有的html 都解析完成之后再去构建和布局 render 树。它是解析完一部分内容就显示一部分内容，同时，可能还在通过网络下载其余内容

repo: ReinerLau/Blog


text:
Save and restore state

angular-resizable is great! How would you go about saving and restoring the width/height of each resized section?

Hm... I assume you mean on a refresh right? If so, I think the best way to go about it would be to create a service that stores the width and height of the element on release. For this I can set up a broadcast event once the dimensions are set.
As far as loading the then stored dimensions back in, we could add a couple of attributes to the directive (r-width and r-height) for setting predefined values. I'll work on putting something together in the next few days.
Let me know if you have any other ideas :)

Hey Reklino, yes - I was thinking about maintaining the sizes after a page refresh.
And yea, I agree broadcasting events is the way to go about and then being able to initiate the directive with a predefined with and height would enable me to restore the size.

Come to think about it, at least two events would be nice:
angular-resizable.startResizing
angular-resizable.resizing
angular-resizable.endResizing
That way I can choose whether I want my UI to resize on every pixel the size changes, or if I want to wait till the resizing is finished. For instance I am using ui-grid.info, and resizing the grid is a little processor intensive. With the startResizing event, I could for instance fade out the grid a bit and then resize it and fade it back in when endResizing is broadcasted.

Hey @nitech!
Check this out  and let me know what you think.
I held off on emitting a 'resizing' event for now because I couldn't think of a use case that couldn't be solved by making use of a start event, end event, and the '.no-transition' class that is available when dragging. However, if you've got a use case in mind, let me know and we'll figure it out.
As far as getting the specific instance of the directive after refresh, the simplest solution I could think of was to emit the 'id' of the resizable element (if there is one) along with the width and height so that they can be stored together. So if you have any resizable elements that need to be remembered on refresh, you can store them on the 'angular-resizable.endResizing' event and then reference them by id once the page has been refreshed. Think that will work?
This seemed to be the most logical and simple solution to me, but I'm open to other methods :)

Thanks! This seems to solve the need to store and restore the size. I am not quite eloquent in AngularJs (yet) and therefore I was a bit puzzled as to how to know which specific directive I am listening to. Passing the ID as suggested would make me able to restore a specific instance.
Without 'px'
I cheated  a bit and implemented somewhat the similar solution yesterday - and then I didn't pass the r-width and r-height as string but rather number - without 'px'. You might consider adding 'px' inside the directive - or defaulting to px.
Options object
Also, it seems other directives implement an options-object rather than having multiple attributes (like r-width, r-height, etc) Ie: resizable="{ width: 200 }"
setSize
I guess we should also have a setSize(width?, height?) method in the directive. Say for instance I am storing the size on the server, I need to call an async request to the server to get the size, and before I have the size at hand, the directive has already processed.

Thanks for the feedback. Yeah, there is no built in method for finding a specific instance of a directive that I know of. But using the ID works. If you find a better method, let me know or play around and submit a PR.
As far as nixing the 'px' and passing an integer goes, I guess that'd be fine. My thoughts behind passing a string were to allow for the possibility of someone using some other unit and having it converted to 'px' in some future version, but that's probably not really gonna be needed.
I have seen some directives that use an object passed to a single attribute for config, and there's nothing really wrong with that (in fact sometimes I prefer it). However, I personally feel that keeping these view-altering options visible in the HTML is part of the beauty of AngularJs. When you can look at the html and understand an element's behavior, you're doing good :)
I was assuming the server request was being done before the rendering of the directive, which is my bad. In lieu of a 'setSize' method though, perhaps we could just watch for changes on the 'r-width' and 'r-height' attributes if they are set.
I kinda forgot to fork that last codepen and instead saved over it with this new version. But you can play around with updating the width and height attributes now. The input boxes in the bottom left are bound to the directives.
Check it out and let me know what ya think!

I was going to submit another bug that highlighted that mouseup event was not getting unregistered.  However, I see that it's fixed in this version!

@nitech I went ahead and pushed these changes. If you had any issues with the changes or have any feedback, feel free to still post it here or open a new issue.

So I've test hooking up to the events, and it works fine for me.  Only change I would recommend is add scope.$apply(); after the emits, because the events are raised outside of the angular world and therefore the changes aren't digested automatically.

@jinder Cool. Let me look at this later. Feel free to fork the codepen, or submit a pull request in the meantime :)

I changed 1.1.0 to this:
                    updateInfo();
                    scope.$emit("angular-resizable.resizeEnd", info);
                    scope.$apply();

and:
                    updateInfo();
                    scope.$emit("angular-resizable.resizeStart", info);
                    scope.$apply();

I see in the codepen that you do the apply() inside your controller.  I guess it's a matter of style more than anything - although usually angular directive do the applying() for you.

That makes sense to me :). I'll push up those changes.

authors: Reklino jinder nitech

repo: Reklino/angular-resizable


text:
为什么现在复制svg会自动添加fill属性呢？

网站使用css来更改颜色，复制粘贴svg很方便，结果现在svg自动包含了fill，还得手动删除，之前明明都没有的qaq

是指增加了一个 fill=CurrentColor 属性吗？这个会影响从父级的 css 属性控制颜色吗？

是指增加了一个 fill=CurrentColor 属性吗？这个会影响从父级的 css 属性控制颜色吗？

是的，现在颜色会默认为CurrentColor，影响css属性控制颜色

svg 添加 currentColor 时可以继承元素的文本颜色或父类的颜色，能更方便的动态修改图标去适配不同主题。
但网站上的 copy 把 currentColor 加到了 path 上，改到 svg 上会更好些。
目前网站已经修改。

好多了，很感谢！

authors: ScarletDor wendygaoyuan xiaochunjimmy

repo: Remix-Design/RemixIcon


text:
Table formatting missing from posts

Table formatting is missing.
Example post:
https://researchhub-web-researchhub.vercel.app/post/264/revamping-researchcoin-reward-distribution
To reproduce:

Visit notebook and create a post that includes table
Publish post and noticed that published post does not include table formatting but the notebook version does

Moved to https://github.com/ResearchHub/issues/issues/4

repo: ResearchHub/researchhub-web


text:
Move Requirements & Glossary wiki pages into repo

https://github.com/RespiraWorks/Ventilator/wiki/Requirements
https://github.com/RespiraWorks/Ventilator/wiki/UI-Requirements
https://github.com/RespiraWorks/Ventilator/wiki/Using-Valispace
https://github.com/RespiraWorks/Ventilator/wiki/Ventilator-Glossary

Done

authors: gracecanfield martukas

repo: RespiraWorks/Ventilator