text:
Webpack build breaks ability to use npm installed custom components

OS?
Mac OSX El Capitan
Versions.

angular-cli: local (v1.0.0-beta.11-webpack, branch: ??)
node: 6.3.1
os: darwin x64

Repro steps.

$ ng  bug-demo
$ cd bug-demo
$ npm install NorthernLogic/angular-cli-imported-component-bug#typescript

# In app.component.ts

# Add this
import { CustomComponent } from 'ng2-custom-component';

# Add the `CustomComponent` directive to the directives list
@Component({
  #...
  selector: 'app-root',
  directives: [CustomComponent]
...

$ ng serve

# Observe errors in

The log given by the failure. Normally this include a stack trace and some
more information.

zone.js:101GET http://127.0.0.1:4200/component.html 404 (Not Found)scheduleTask @ zone.js:101ZoneDelegate.scheduleTask @ zone.js:336Zone.scheduleMacroTask @ zone.js:273(anonymous function) @ zone.js:122send @ VM43932:3XHRImpl.get @ xhr_impl.js:47DirectiveNormalizer._fetch @ directive_normalizer.js:49DirectiveNormalizer.normalizeTemplateAsync @ directive_normalizer.js:92DirectiveNormalizer.normalizeDirective @ directive_normalizer.js:67RuntimeCompiler._getCompiledTemplate @ runtime_compiler.js:109RuntimeCompiler._getTransitiveCompiledTemplates @ runtime_compiler.js:117(anonymous function) @ runtime_compiler.js:120RuntimeCompiler._getTransitiveCompiledTemplates @ runtime_compiler.js:120(anonymous function) @ runtime_compiler.js:120RuntimeCompiler._getTransitiveCompiledTemplates @ runtime_compiler.js:120RuntimeCompiler.compileComponentAsync @ runtime_compiler.js:43RuntimeCompiler.resolveComponent @ runtime_compiler.js:39(anonymous function) @ application_ref.js:165(anonymous function) @ application_ref.js:364ZoneDelegate.invoke @ zone.js:323onInvoke @ ng_zone_impl.js:53ZoneDelegate.invoke @ zone.js:322Zone.run @ zone.js:216NgZoneImpl.runInner @ ng_zone_impl.js:84NgZone.run @ ng_zone.js:235ApplicationRef_.run @ application_ref.js:362coreLoadAndBootstrap @ application_ref.js:162bootstrap @ index.js:115(anonymous function) @ main.ts:9__webpack_require__ @ bootstrap f5caf8d…:52(anonymous function) @ environment.dev.ts:4__webpack_require__ @ bootstrap f5caf8d…:52webpackJsonpCallback @ bootstrap f5caf8d…:23(anonymous function) @ main.bundle.js:1
browser_adapter.js:93EXCEPTION: Failed to load /component.html
browser_adapter.js:84EXCEPTION: Failed to load /component.htmlBrowserDomAdapter.logError @ browser_adapter.js:84BrowserDomAdapter.logGroup @ browser_adapter.js:94ExceptionHandler.call @ exception_handler.js:65(anonymous function) @ application_ref.js:368ZoneDelegate.invoke @ zone.js:323onInvoke @ ng_zone_impl.js:53ZoneDelegate.invoke @ zone.js:322Zone.run @ zone.js:216(anonymous function) @ zone.js:571ZoneDelegate.invokeTask @ zone.js:356onInvokeTask @ ng_zone_impl.js:44ZoneDelegate.invokeTask @ zone.js:355Zone.runTask @ zone.js:256drainMicroTaskQueue @ zone.js:474ZoneTask.invoke @ zone.js:426XMLHttpRequest.send (async)scheduleTask @ zone.js:101ZoneDelegate.scheduleTask @ zone.js:336Zone.scheduleMacroTask @ zone.js:273(anonymous function) @ zone.js:122send @ VM43932:3XHRImpl.get @ xhr_impl.js:47DirectiveNormalizer._fetch @ directive_normalizer.js:49DirectiveNormalizer.normalizeTemplateAsync @ directive_normalizer.js:92DirectiveNormalizer.normalizeDirective @ directive_normalizer.js:67RuntimeCompiler._getCompiledTemplate @ runtime_compiler.js:109RuntimeCompiler._getTransitiveCompiledTemplates @ runtime_compiler.js:117(anonymous function) @ runtime_compiler.js:120RuntimeCompiler._getTransitiveCompiledTemplates @ runtime_compiler.js:120(anonymous function) @ runtime_compiler.js:120RuntimeCompiler._getTransitiveCompiledTemplates @ runtime_compiler.js:120RuntimeCompiler.compileComponentAsync @ runtime_compiler.js:43RuntimeCompiler.resolveComponent @ runtime_compiler.js:39(anonymous function) @ application_ref.js:165(anonymous function) @ application_ref.js:364ZoneDelegate.invoke @ zone.js:323onInvoke @ ng_zone_impl.js:53ZoneDelegate.invoke @ zone.js:322Zone.run @ zone.js:216NgZoneImpl.runInner @ ng_zone_impl.js:84NgZone.run @ ng_zone.js:235ApplicationRef_.run @ application_ref.js:362coreLoadAndBootstrap @ application_ref.js:162bootstrap @ index.js:115(anonymous function) @ main.ts:9__webpack_require__ @ bootstrap f5caf8d…:52(anonymous function) @ environment.dev.ts:4__webpack_require__ @ bootstrap f5caf8d…:52webpackJsonpCallback @ bootstrap f5caf8d…:23(anonymous function) @ main.bundle.js:1
browser_adapter.js:93EXCEPTION: Error: Uncaught (in promise): Failed to load /component.html
browser_adapter.js:84EXCEPTION: Error: Uncaught (in promise): Failed to load /component.htmlBrowserDomAdapter.logError @ browser_adapter.js:84BrowserDomAdapter.logGroup @ browser_adapter.js:94ExceptionHandler.call @ exception_handler.js:65(anonymous function) @ application_ref.js:337schedulerFn @ async.js:139SafeSubscriber.__tryOrUnsub @ Subscriber.js:225SafeSubscriber.next @ Subscriber.js:174Subscriber._next @ Subscriber.js:124Subscriber.next @ Subscriber.js:88Subject._finalNext @ Subject.js:128Subject._next @ Subject.js:120Subject.next @ Subject.js:77EventEmitter.emit @ async.js:127onError @ ng_zone.js:124onHandleError @ ng_zone_impl.js:74ZoneDelegate.handleError @ zone.js:327Zone.runGuarded @ zone.js:233_loop_1 @ zone.js:487drainMicroTaskQueue @ zone.js:494ZoneTask.invoke @ zone.js:426XMLHttpRequest.send (async)scheduleTask @ zone.js:101ZoneDelegate.scheduleTask @ zone.js:336Zone.scheduleMacroTask @ zone.js:273(anonymous function) @ zone.js:122send @ VM43932:3XHRImpl.get @ xhr_impl.js:47DirectiveNormalizer._fetch @ directive_normalizer.js:49DirectiveNormalizer.normalizeTemplateAsync @ directive_normalizer.js:92DirectiveNormalizer.normalizeDirective @ directive_normalizer.js:67RuntimeCompiler._getCompiledTemplate @ runtime_compiler.js:109RuntimeCompiler._getTransitiveCompiledTemplates @ runtime_compiler.js:117(anonymous function) @ runtime_compiler.js:120RuntimeCompiler._getTransitiveCompiledTemplates @ runtime_compiler.js:120(anonymous function) @ runtime_compiler.js:120RuntimeCompiler._getTransitiveCompiledTemplates @ runtime_compiler.js:120RuntimeCompiler.compileComponentAsync @ runtime_compiler.js:43RuntimeCompiler.resolveComponent @ runtime_compiler.js:39(anonymous function) @ application_ref.js:165(anonymous function) @ application_ref.js:364ZoneDelegate.invoke @ zone.js:323onInvoke @ ng_zone_impl.js:53ZoneDelegate.invoke @ zone.js:322Zone.run @ zone.js:216NgZoneImpl.runInner @ ng_zone_impl.js:84NgZone.run @ ng_zone.js:235ApplicationRef_.run @ application_ref.js:362coreLoadAndBootstrap @ application_ref.js:162bootstrap @ index.js:115(anonymous function) @ main.ts:9__webpack_require__ @ bootstrap f5caf8d…:52(anonymous function) @ environment.dev.ts:4__webpack_require__ @ bootstrap f5caf8d…:52webpackJsonpCallback @ bootstrap f5caf8d…:23(anonymous function) @ main.bundle.js:1
browser_adapter.js:84STACKTRACE:BrowserDomAdapter.logError @ browser_adapter.js:84ExceptionHandler.call @ exception_handler.js:67(anonymous function) @ application_ref.js:337schedulerFn @ async.js:139SafeSubscriber.__tryOrUnsub @ Subscriber.js:225SafeSubscriber.next @ Subscriber.js:174Subscriber._next @ Subscriber.js:124Subscriber.next @ Subscriber.js:88Subject._finalNext @ Subject.js:128Subject._next @ Subject.js:120Subject.next @ Subject.js:77EventEmitter.emit @ async.js:127onError @ ng_zone.js:124onHandleError @ ng_zone_impl.js:74ZoneDelegate.handleError @ zone.js:327Zone.runGuarded @ zone.js:233_loop_1 @ zone.js:487drainMicroTaskQueue @ zone.js:494ZoneTask.invoke @ zone.js:426XMLHttpRequest.send (async)scheduleTask @ zone.js:101ZoneDelegate.scheduleTask @ zone.js:336Zone.scheduleMacroTask @ zone.js:273(anonymous function) @ zone.js:122send @ VM43932:3XHRImpl.get @ xhr_impl.js:47DirectiveNormalizer._fetch @ directive_normalizer.js:49DirectiveNormalizer.normalizeTemplateAsync @ directive_normalizer.js:92DirectiveNormalizer.normalizeDirective @ directive_normalizer.js:67RuntimeCompiler._getCompiledTemplate @ runtime_compiler.js:109RuntimeCompiler._getTransitiveCompiledTemplates @ runtime_compiler.js:117(anonymous function) @ runtime_compiler.js:120RuntimeCompiler._getTransitiveCompiledTemplates @ runtime_compiler.js:120(anonymous function) @ runtime_compiler.js:120RuntimeCompiler._getTransitiveCompiledTemplates @ runtime_compiler.js:120RuntimeCompiler.compileComponentAsync @ runtime_compiler.js:43RuntimeCompiler.resolveComponent @ runtime_compiler.js:39(anonymous function) @ application_ref.js:165(anonymous function) @ application_ref.js:364ZoneDelegate.invoke @ zone.js:323onInvoke @ ng_zone_impl.js:53ZoneDelegate.invoke @ zone.js:322Zone.run @ zone.js:216NgZoneImpl.runInner @ ng_zone_impl.js:84NgZone.run @ ng_zone.js:235ApplicationRef_.run @ application_ref.js:362coreLoadAndBootstrap @ application_ref.js:162bootstrap @ index.js:115(anonymous function) @ main.ts:9__webpack_require__ @ bootstrap f5caf8d…:52(anonymous function) @ environment.dev.ts:4__webpack_require__ @ bootstrap f5caf8d…:52webpackJsonpCallback @ bootstrap f5caf8d…:23(anonymous function) @ main.bundle.js:1
browser_adapter.js:84Error: Uncaught (in promise): Failed to load /component.html
    at resolvePromise (zone.js:538)
    at PromiseCompleter.reject (zone.js:515)
    at application_ref.js:367
    at ZoneDelegate.invoke (zone.js:323)
    at Object.onInvoke (ng_zone_impl.js:53)
    at ZoneDelegate.invoke (zone.js:322)
    at Zone.run (zone.js:216)
    at zone.js:571
    at ZoneDelegate.invokeTask (zone.js:356)
    at Object.onInvokeTask (ng_zone_impl.js:44)BrowserDomAdapter.logError @ browser_adapter.js:84ExceptionHandler.call @ exception_handler.js:68(anonymous function) @ application_ref.js:337schedulerFn @ async.js:139SafeSubscriber.__tryOrUnsub @ Subscriber.js:225SafeSubscriber.next @ Subscriber.js:174Subscriber._next @ Subscriber.js:124Subscriber.next @ Subscriber.js:88Subject._finalNext @ Subject.js:128Subject._next @ Subject.js:120Subject.next @ Subject.js:77EventEmitter.emit @ async.js:127onError @ ng_zone.js:124onHandleError @ ng_zone_impl.js:74ZoneDelegate.handleError @ zone.js:327Zone.runGuarded @ zone.js:233_loop_1 @ zone.js:487drainMicroTaskQueue @ zone.js:494ZoneTask.invoke @ zone.js:426XMLHttpRequest.send (async)scheduleTask @ zone.js:101ZoneDelegate.scheduleTask @ zone.js:336Zone.scheduleMacroTask @ zone.js:273(anonymous function) @ zone.js:122send @ VM43932:3XHRImpl.get @ xhr_impl.js:47DirectiveNormalizer._fetch @ directive_normalizer.js:49DirectiveNormalizer.normalizeTemplateAsync @ directive_normalizer.js:92DirectiveNormalizer.normalizeDirective @ directive_normalizer.js:67RuntimeCompiler._getCompiledTemplate @ runtime_compiler.js:109RuntimeCompiler._getTransitiveCompiledTemplates @ runtime_compiler.js:117(anonymous function) @ runtime_compiler.js:120RuntimeCompiler._getTransitiveCompiledTemplates @ runtime_compiler.js:120(anonymous function) @ runtime_compiler.js:120RuntimeCompiler._getTransitiveCompiledTemplates @ runtime_compiler.js:120RuntimeCompiler.compileComponentAsync @ runtime_compiler.js:43RuntimeCompiler.resolveComponent @ runtime_compiler.js:39(anonymous function) @ application_ref.js:165(anonymous function) @ application_ref.js:364ZoneDelegate.invoke @ zone.js:323onInvoke @ ng_zone_impl.js:53ZoneDelegate.invoke @ zone.js:322Zone.run @ zone.js:216NgZoneImpl.runInner @ ng_zone_impl.js:84NgZone.run @ ng_zone.js:235ApplicationRef_.run @ application_ref.js:362coreLoadAndBootstrap @ application_ref.js:162bootstrap @ index.js:115(anonymous function) @ main.ts:9__webpack_require__ @ bootstrap f5caf8d…:52(anonymous function) @ environment.dev.ts:4__webpack_require__ @ bootstrap f5caf8d…:52webpackJsonpCallback @ bootstrap f5caf8d…:23(anonymous function) @ main.bundle.js:1
zone.js:461Unhandled Promise rejection: Failed to load /component.html ; Zone: angular ; Task: Promise.then ; Value: Failed to load /component.htmlconsoleError @ zone.js:461_loop_1 @ zone.js:490drainMicroTaskQueue @ zone.js:494ZoneTask.invoke @ zone.js:426XMLHttpRequest.send (async)scheduleTask @ zone.js:101ZoneDelegate.scheduleTask @ zone.js:336Zone.scheduleMacroTask @ zone.js:273(anonymous function) @ zone.js:122send @ VM43932:3XHRImpl.get @ xhr_impl.js:47DirectiveNormalizer._fetch @ directive_normalizer.js:49DirectiveNormalizer.normalizeTemplateAsync @ directive_normalizer.js:92DirectiveNormalizer.normalizeDirective @ directive_normalizer.js:67RuntimeCompiler._getCompiledTemplate @ runtime_compiler.js:109RuntimeCompiler._getTransitiveCompiledTemplates @ runtime_compiler.js:117(anonymous function) @ runtime_compiler.js:120RuntimeCompiler._getTransitiveCompiledTemplates @ runtime_compiler.js:120(anonymous function) @ runtime_compiler.js:120RuntimeCompiler._getTransitiveCompiledTemplates @ runtime_compiler.js:120RuntimeCompiler.compileComponentAsync @ runtime_compiler.js:43RuntimeCompiler.resolveComponent @ runtime_compiler.js:39(anonymous function) @ application_ref.js:165(anonymous function) @ application_ref.js:364ZoneDelegate.invoke @ zone.js:323onInvoke @ ng_zone_impl.js:53ZoneDelegate.invoke @ zone.js:322Zone.run @ zone.js:216NgZoneImpl.runInner @ ng_zone_impl.js:84NgZone.run @ ng_zone.js:235ApplicationRef_.run @ application_ref.js:362coreLoadAndBootstrap @ application_ref.js:162bootstrap @ index.js:115(anonymous function) @ main.ts:9__webpack_require__ @ bootstrap f5caf8d…:52(anonymous function) @ environment.dev.ts:4__webpack_require__ @ bootstrap f5caf8d…:52webpackJsonpCallback @ bootstrap f5caf8d…:23(anonymous function) @ main.bundle.js:1
zone.js:463Error: Uncaught (in promise): Failed to load /component.html(…)

Anything else that might be helpful

This worked pre the switch to using webpack instead of broccoli.

@TheLarkInn this seems bad, probably related to the template loader. Can you add some insight?

Is there a link or repo to this component we can test?

I believe I know what's going on here but it will help to have this component as an example.

@TheLarkInn @filipesilva The npm install command in the original message references this repo. https://github.com/NorthernLogic/angular-cli-imported-component-bug

May need to apply the angular2-template-loader to both ts and js.

I've been looking into this, and there isn't a easy solution to it right now.
Basically, there's no decent way to bundle 3rd party libs that do not inline their html/css. At the moment we use some regex to figure it out for ts files, but it's somewhat risky... it might replace stuff it shouldn't.
However risky it is for TS, it's much more so to apply it to all JS files. I tried and it immediately broke some other unrelated files. There isn't any foolproof way to regex both TS and JS files and only find templateUrl/styleUrls that are Angular 2 components, because that can't be determined just via regex. Using TS AST tools also doesn't help on the JS front, since JS isn't TS.
I talked with the team and the immediate solution is that libs should be distributed with inlined html/css. The solution in the near future is is for libs to be build with ngc which include metadata that Angular 2 needs to know this sort of stuff. We'll be making this information available as soon as possible.
I'm closing the issue then since this isn't a CLI bug per se, but rather a bigger topic that needs to be discussed in the docs or angular/angular issues.
/cc @hansl @TheLarkInn @robwormald

How about things such as images that I library may include? Will it be covered by ngc as well? Also do you have any links to the discussions you mentioned? Thank you.

Actually, this is as good as any a place to discuss all this, reopening. I don't have any links to the discussions, it's ongoing.

I have similar problem I've described in https://github.com/angular/angular-cli/issues/3274#issuecomment-272185646

A couple of months have passed since this issue was opened and even though there isn't much more to say, I want to give an update before closing it.
As far as libraries go, they should always inline html and css and be AoT ready. There isn't yet a published chapter about this on angular.io, but there's one in the works that needs a bit more work: https://github.com/angular/angular.io/pull/2758
Images and other resources have to either be inlined, or somehow provided for the application to use. TSC doesn't do anything with these, as far as I know.
When the CLI has a library move (tracked in https://github.com/angular/angular-cli/issues/1692) it should do all of this for you. Until then third party libraries have to do it themselves without the CLI.

Why don't you add a custom loader in webpack that does the replace  example:
templateUrl: './test.component.html' ->   template: require('./test.component.html')
or you allow to add custom loader to the webpack in the cli?

Because that regex replacement might look fine for Angular components, but will also break any other third party library that happens to use those strings. We tried regex replacements for a while, and it's really not worth it. There's also no decent way to figure out which JS or TS files are Angular components.

The modules that would require something like that could be configured somewhere, also I suppose are not a lot the modules that would require something like that.
example package.json :
{
fiximport: [
../node_modules/my_external_component
]
}

authors: TheLarkInn adamduren filipesilva magemello serhiisol


text:
Is there any plans for @ngtools/webpack to support Webpack 5?

🚀 Feature request
Command (mark with an x)

[ ] new
[x] build
[ ] serve
[ ] test
[ ] e2e
[ ] generate
[ ] add
[ ] update
[ ] lint
[ ] extract-i18n
[ ] run
[ ] config
[ ] help
[ ] version
[ ] doc

Description
I tried to use @ng-tools/webpack with Webpack 5 but it doesn't seem to work.
According to Webpack-team the fault might be loader. I can't explain in detail whats wrong since I don't have a deep understanding of the loader nor Webpack. But there seem to be some issue with how caching is implemented.

Please see this issue for more info: https://github.com/webpack/webpack-cli/issues/1985
I tried to create create a minimal reproduction but it only happens with our full monorepo setup. When using the repro I don't end up in the ResolverCachePlugin with the Angular files at all, and I don't know how to force it either.
Maybe someone in the team can share some light on what's happening?
Describe the solution you'd like
Sorry. I'm no help here.
Describe alternatives you've considered
The alternative is to stay with Webpack 4.x.x

Which version of the plugin are you using?

@alan-agius4: Sorry for not mentioning that. Last time I tried it I used 11.0.0-rc.1. It was a week ago.

Can you try to use version 11 final please? If the problem persists kindly provide a minimal reproduction. Thanks.

I'll do my best to recreate it. However I would really appreciate if someone could help me explain in short what ResolverCachePlugin is and why files end up there is some cases, and in some not. I've added a  and imported stuff from @angular/material/dialog and it still won't recreate what's happening in our real repo.

ResolverCachePlugin is part of Webpack (code) and is used when the new Webpack 5 caching is enabled.  As to why Webpack is crashing in that plugin, this is currently under investigation.  However, it is currently recommended to disable the new caching via the cache: false option in the Webpack configuration.

ResolverCachePlugin is part of Webpack (code) and is used when the new Webpack 5 caching is enabled. As to why Webpack is crashing in that plugin, this is currently under investigation. However, it is currently recommended to disable the new caching via the cache: false option in the Webpack configuration.

Thanks for the reply. I'm currently trying to reproduce the issue but I'm unable to. I've stripped down our repo to bare minimum and adding generic test components so that I don't have to upload company property. I've been importing @angular/material/dialog in components, in services, in route guards and every single place where I can think of, but I still can't reproduce the error in our main repo.
When logging out all resolved files in the ResolveCachePlugin I can see that app.module.ts is trying to resolve ./__ivy_ngcc__/fesm2015/dialog.js multiple times even though I don't have any direct import in app.module.ts to that file. I don't know why app.module.ts would be the issuer for that file. According to a member of the Webpack-team this is a bug in AngularCompilerPlugin and as here, without a repro they don't wanna investigate. I've been trying for a long time creating a simple repro. But I'm unable to.
I've pasted my findings in this ticket:
https://github.com/webpack/webpack-cli/issues/1985

Thank you for looking deeper into this issue. Our investigation has been focused on attempting to ascertain how the ResolverCachePlugin has entered an invalid state as well as whether this is indeed an invalid state.  However, the new caching code is quite complex and the call stacks are non-trivial so the investigation may take some time.

@clydin: Let me know if you need any assistance. Do you guys have a repo where you can reproduce the issue? In that case I won't try to create a minimal repo.

@clydin: The problem is a race condition. The same issuer, app.module.ts, is trying to resolve ./__ivy_ngcc__/fesm2015/dialog.js twice in a very short time and since the resolver is async the second one is triggered before the first one in done, but after the first one is triggered, so the cache is not ready, hence a "cache miss".
I've stepped through the code with a delay for each file and the problem goes away,
The issuer, app.module.ts, has no direct import of the file that fails, so it might be because how Angular imports other modules? Although that's not the whole truth, because in my repro, I import a module that export both components and other modules using material, and I still don't get that issue.
I have been trying to find any information about the source of the import, but the only information I can find is app.module.ts, and like I said it doesn't even import @angular/material/dialog.

I'm looking at the TypeScript output for app.module.ts in both our projects (real monorepo and repro monorepo).
Can someone explain to me why and how the i0, i1 and i2 are added?

In the real monorepo where this fails I have a lot more of them, including our internal lib.

I know for a fact the for example @angular/material/dialog and our internal lib @oas/web-lib-angular is used in our component's in both repos. So why are they just imported by app.module.ts in one of the cases?
The follow up is obviously then why ./__ivy_ngcc__/fesm2015/dialog.js is being resolved twice from app.module.ts.

Finally figured out the Angular side of the issue. The issue occur for me when "remote scoping" used.
Read about it here: https://github.com/angular/angular/blob/master/packages/core/test/bundling/cyclic_import/README.md
We have this "render component" that renders other components dynamically with an ngSwitch. And our group components (tables, sections, lists, etc) can render child components. So in this case the "render component" has a reference to the table in it's template, and the table has a reference to the "render component" so it can render child components in the table dynamically.
I still don't know why this causes cache issues, but at least I know how to reproduce it in a small repo. Will be done with the repro really soon.

@alan-agius4:
Repro here: https://github.com/JonWallsten/monorepo-new/tree/webpack-5-issue
It's private since I don't want to expose company stuff, but anyone that wan't to look into this let me know and I'll provide access.

After spending some time in the debugger, this does appear to be a Webpack defect.  The code in question in the ResolverCachePlugin is used to merge requests for identical identifiers.  However, in certain cases it appears to not properly merge the requests and results in an internal state mismatch that leads to the aforementioned crash.
By making the following changes to the ResolverCachePlugin, the crash no longer occurs.  Manual inspection via the debugger also indicates that identical requests are being merged with the changes.  All webpack tests also continue to pass with the changes.
@@ -202,23 +202,23 @@ class ResolverCachePlugin {
 									request,
 									!cacheWithContext
 								)}`;
-								const activeRequest = activeRequests.get(identifier);
-								if (activeRequest) {
-									activeRequest.push(callback);
+								let callbacks = activeRequests.get(identifier);
+								if (callbacks) {
+									callbacks.push(callback);
 									return;
+								} else {
+									callbacks = [callback];
+									activeRequests.set(identifier, callbacks);
 								}
 								const itemCache = cache.getItemCache(identifier, null);
-								let callbacks;
 								const done = (err, result) => {
-									if (callbacks === undefined) {
+									activeRequests.delete(identifier);
+									if (callbacks.length === 1) {
 										callback(err, result);
-										callbacks = false;
 									} else {
 										for (const callback of callbacks) {
 											callback(err, result);
 										}
-										activeRequests.delete(identifier);
-										callbacks = false;
 									}
 								};
 								/**
@@ -277,10 +277,6 @@ class ResolverCachePlugin {
 									}
 								};
 								itemCache.get(processCacheResult);
-								if (callbacks === undefined) {
-									callbacks = [callback];
-									activeRequests.set(identifier, callbacks);
-								}
 							}
 						);
 					}

I'll quote @sokra from my Webpack issue:

The diff is interesting. The code was written in previous way to avoid allocating an array when resolve result can be provided synchronous from cache. Maybe something tries to resolve within the resolver so it's kind of nested. Maybe delaying the real resolve call with process.nextTick can also fix it without the additional allocation in the cached case.

@clydin: Great news! Bug is fixed in https://github.com/webpack/enhanced-resolve/releases/tag/v5.3.2

Closing as issue appears to have been solved upstream.

source: gharchive/issue

authors: JonWallsten alan-agius4 clydin

repo: angular/angular-cli

license: MIT

license_type: permissive

license_source: github-api


text:
(feat) 3rd party libs

I got this working, but like the whole project this is a prototype and a lot of things needed to be done.
This is how it looks like
[tp]$ ng libs install ng2-cli-test-lib
version: 1.13.13
Installing 3rd party packages: ng2-cli-test-lib...
1 Packages successfully installed
[?] Would you like to inject the installed packages into your app automatically? Y
[?] What is the path to the file which bootstraps your app? /Users/jan/Desktop/tp/src/app.ts

[?] What would you like to inject from ng2-cli-test-lib?
1 Directive
2 Pipe
3 Provider
4 styleUrl
Enter value: 1
[?] Which Directive would you like to inject?
1 TestDirective
Enter value: 1
[?] Where would you like to inject it?
1 /Users/jan/Desktop/tp/src/app.ts
2 /Users/jan/Desktop/tp/src/app/tp.spec.ts
3 /Users/jan/Desktop/tp/src/app/tp.ts
Enter value: 3
Injecting Directive (TestDirective) to /Users/jan/Desktop/tp/src/app/tp.ts
Done.

[tp]$

I tested on a https://github.com/NathanWalker/ng2-cli-test-lib test library, which regarding to comments on https://github.com/angular/angular-cli/issues/96 should be it.

@jkuri you are amazing!
Really nice work thank you!
We may tweak the flow a little bit but this is definitely what we are after. Bravo :+1:

@NathanWalker no problem. Would you write some guide how the packages needs to be created?

@jkuri You nailed it for most part.
I will write a guide once we have consensus. I'll cc' others below that may want to offer other ideas.
Main thing I object to is:

What would you like to inject from ng2-cli-test-lib?

In general, I believe it should ask something like this before that:

Would you like to customize the injection of ng2-cli-test-lib? (N/y)

If n (default):

Please provide the path to the file which bootstraps your root component:

/path/to/bootstrap.ts

cli appends all lib providers to bootstrap.

Please provide the path to the component where you want the (directives, pipes, styles, styleUrls, etc.)?

/path/to/root/component.ts

cli injects and annotates everything else that the lib makes available.
If 'y':
Then it would go through the flow you have at the moment, which is more pick/choose (manual install) from the library.
I believe the default should be the easiest most painless path, which would be:
Add the lib, inject and annotate with everything the lib provides and don't allow the user to pick/choose
Path of least resistance I believe is adding providers to the apps bootstrap method ensuring it's available app-wide. This will help devs out of the gate I believe. More advanced users can answer y to Would you like to customize the injection of ng2-cli-test-lib? (N/y) to go the pick/choose (more power) route.
/cc @jvandemo, @gdi2290, @valorkin, @ocombe, @robwormald

My last commit allows auto import (this is default option) of everything that lib provide in bootstrap script. It also injects providers in bootstrap function.

@jkuri this is exciting! I can't thank you enough, I can't wait for this to land....
@IgorMinar please, pretty please? :)
lgtm. It can be improved over time if need be and the flow can continue to be tweaked, but having this now will allow lib authors to start advocating angular cli as a way to install their lib :+1:

@IgorMinar yes, that would be cool :-). This command/task does not require any new dependencies, thanks to inquirer is built in ember-cli.

Hey @jkuri, could you rebase this on master?

need to check my modules to work with this

Hi @filipesilva, I rebased this.

@valorkin use this script with systemjs-builder and run it in prepublish script. Also, here is example how to export things.

@jkuri: Hey Jan, good job!

any reason why ng libs install foo was picked over ng install foo? I personally prefer smaller command lines. Seems like install could be purposed for this.
please squash your history before merging. We want to keep a clean commit history (same code practice as other angular projects). If you need help, you can check here and/or ask me!

The code looks good but I'm going to read it more thoroughly later on today.

Hi @hansl. Thank you!
Yes, I do need some help with squashing commits into one.. here's what I am trying to do
git rebase -i HEAD~9
then I mark all but first one with s and the first one I left with pick option. Then it rebases my commits, but when trying to push to a 3rd-party-libs branch it says my current branch is behind. Any suggestions?
I also like shorter commands but in that case I choose ng libs for two reasons. First is that when you type libs you know that you will install 3rd party library, and the second is that correlated install and uninstall commands can be merged into one ember-cli task.

@jkuri Whenever you squash commits, you are rewriting history ;)
So you have to force push:
git push -f

Unfortunately, you need to force push at this point.

Thanks. Commits squashed.

This is pretty cool! Thanks @jkuri.
I'd do 2 things before merging this in:

[ ] Change the command to ng lib install (as we are installing one lib per time, I think that keeping it in singular make more sense) or ng install as suggested by @hansl
[ ] Add unit tests for the feature

@cironunes thanks, no problem.
You can install/uninstall multiple libs per time, separating them by space.
ng install and ng uninstall as @hansl suggested will be good, but then I need to break up the task into two separated tasks. Also ng i and ng u will then be possible as aliases to this commands, even shorter. Should I implement in it that way?

@jkuri: I personally don't see it as a blocker for this PR. It can easily be done in a separate PR. I checked and the ember install currently fails so people won't be using it.
You're :+1: to commit.

@hansl ok, I agree. I can override the core install command, but if I remember correctly it logs some warning that the command has been overridden. Will check if I can take care of that.

@jkuri not a huge deal, but you might reword your commit msg from:
(feat) 3rd party libs

to:
feat(libs): 3rd party lib helper

And please squash your history. I can take time right off now to help you merge if you need to.

Thanks, I managed to squash it yesterday, I will make another commit when separating commands later today. I was having problem with squashing merged stuff from master. It will not harm if you write commands in order, it can save me some time.

I would suggest doing a separate PR just so we can get this in. Also, I feel this second commit came from a git merge; you should rather do git rebase master instead (assuming your master is up to date). It doesn't commit anything (although you have to git push --force)

git checkout master
git fetch upstream
git rebase upstream/master
git checkout 3rd-party-libs
git rebase master  // if you have merge conflicts, you may need to fix and add, then `git rebase --continue`
git rebase -i HEAD~4  // reword, squash and do what you need to do
git push -f

@hansl and @NathanWalker thanks for your help with that. I squashed commits without any problems now.
I reword commands to ng install <name-of-lib> and ng uninstall <name-of-lib> and put them in separate tasks. Here is one variant of how install process looks like, and here is screenshot of uninstall process. All the things gets properly injected and also cleaned after uninstalling, but I still need to write unit tests.
After this will be merged, we should write documentation about how the lib needs to be created to be compatible with our commands, so developers can start building/reconfigures their libs the right way.

Agreed, I will help write a lib guide over next 2 weeks (prob become its
own repo with wiki and all) that we can collab on to make good docs for how
to author libs that will work with this feature. Again, really nice work
here.
On Sun, Jan 24, 2016 at 5:43 PM Jan Kuri notifications@github.com wrote:

@hansl https://github.com/hansl and @NathanWalker
https://github.com/NathanWalker thanks for your help with that. I
squashed commits without any problems now.
I reword commands to ng install  and ng uninstall
 and put them in separate tasks. Here
https://cloud.githubusercontent.com/assets/1796022/12540605/bfb40d96-c30b-11e5-8397-5f0ca544c417.png
is one variant of how install process looks like, and here
https://cloud.githubusercontent.com/assets/1796022/12540653/8133b142-c30c-11e5-8e53-d009620bd027.png
is screenshot of uninstall process. All the things gets properly injected
and also cleaned after uninstalling, but I still need to write unit tests.
After this will be merged, we should write documentation about how the lib
needs to be created to be compatible with our commands, so developers can
start building/reconfigures their libs the right way.
—
Reply to this email directly or view it on GitHub
https://github.com/angular/angular-cli/pull/135#issuecomment-174369153.

If we do documentation I suggest keeping it under a single roof. I don't mind either creating a doc/ folder with markdown files or using this github's wiki.

Starting with the wiki here sounds like a good idea.
On Sun, Jan 24, 2016 at 5:53 PM Hans notifications@github.com wrote:

If we do documentation I suggest keeping it under a single roof. I don't
mind either creating a doc/ folder with markdown files or using this
github's wiki.
—
Reply to this email directly or view it on GitHub
https://github.com/angular/angular-cli/pull/135#issuecomment-174369977.

Added tests to both commands.

There you go. Awesome job @jkuri. LGTM

Awesomesauce. Merging it then!

Thanks for helping guys.

Thank you to everyone here. @jkuri incredible effort. If you are on Twitter, you might DM me, we can chat about further details of documentation coordination, etc (@wwwalkerrun)

\o/
Right on time for my talk at NG-NL on "How to write libraries for Angular 2" :)

Sweet. Tells us how it goes on gitter! https://gitter.im/angular/angular-cli

can't wait for the next release :)

source: gharchive/pull-request

authors: NathanWalker cironunes filipesilva hansl jkuri ocombe valorkin


text:
feat(@angular-devkit/build-angular): support custom headers in dev-server

Make it possible to configure dev-server to send custom HTTP headers on
every client request. These headers can be specified as a key-value map
under the new "headers" property of the dev-server builder in
angular.json. These headers are then passed on to the webpack devserver.
An example use case for this is to enable various security features,
such as CSP and Trusted Types, both in local application development and
in integration tests, by setting appropriate HTTP headers.
This is part of an effort to add support for Trusted Types in Angular.
The ability to enforce Trusted Types during development and integration
tests is essential, as this can help detect Trusted Types violations
that might otherwise break applications when they're pushed to
production where such security features may be enforced.
This change is completely backwards compatible, and does not change
any behavior before the "headers" property is set.

CC @engelsdamien @koto


text:
Bower Install Fails on the system

(wye) nayan@ubuntu:~/Desktop/wye/angular-seed(master)$ npm install
npm WARN deprecated minimatch@0.3.0: Please update to minimatch 3.0.2 or higher to avoid a RegExp DoS issue
npm WARN deprecated tough-cookie@2.2.2: ReDoS vulnerability parsing Set-Cookie https://nodesecurity.io/advisories/130

angular-seed@0.0.0 postinstall /home/nayan/Desktop/wye/angular-seed
bower install

/usr/bin/env: ‘node’: No such file or directory
npm WARN optional Skipping failed optional dependency /chokidar/fsevents:
npm WARN notsup Not compatible with your operating system or architecture: fsevents@1.0.14
npm ERR! Linux 4.4.0-34-generic
npm ERR! argv "/usr/bin/nodejs" "/usr/bin/npm" "install"
npm ERR! node v4.2.6
npm ERR! npm  v3.5.2
npm ERR! file sh
npm ERR! code ELIFECYCLE
npm ERR! errno ENOENT
npm ERR! syscall spawn
npm ERR! angular-seed@0.0.0 postinstall: bower install
npm ERR! spawn ENOENT
npm ERR!
npm ERR! Failed at the angular-seed@0.0.0 postinstall script 'bower install'.
npm ERR! Make sure you have the latest version of node.js and npm installed.
npm ERR! If you do, this is most likely a problem with the angular-seed package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     bower install
npm ERR! You can get information on how to open an issue for this project with:
npm ERR!     npm bugs angular-seed
npm ERR! Or if that isn't available, you can get their info via:
npm ERR!     npm owner ls angular-seed
npm ERR! There is likely additional logging output above.
npm ERR! Please include the following file with any support request:
npm ERR!     /home/nayan/Desktop/wye/angular-seed/npm-debug.log
npm-debug.log.zip

npm install seems to be failing (based on the attached npm-debug.log). Could it be a permissions issue? What is the output if you run npm install directly?

I am having the same issue..does it have anything to do with Windows10..?

It works fine on Windows 10 for me :confused:

Same issue, here are the details:
[faddat@arch-anywhere]: ~/gocryptotrader/web>$ npm start

> angular-seed@0.0.0 prestart /home/faddat/gocryptotrader/web
> npm install

> angular-seed@0.0.0 postinstall /home/faddat/gocryptotrader/web
> bower install

npm WARN optional Skipping failed optional dependency /chokidar/fsevents:
npm WARN notsup Not compatible with your operating system or architecture: fsevents@1.0.14

> angular-seed@0.0.0 start /home/faddat/gocryptotrader/web
> node server.js

events.js:160
      throw er; // Unhandled 'error' event
      ^

Error: listen EACCES 0.0.0.0:80
    at Object.exports._errnoException (util.js:1026:11)
    at exports._exceptionWithHostPort (util.js:1049:20)
    at Server._listen2 (net.js:1240:19)
    at listen (net.js:1289:10)
    at Server.listen (net.js:1385:5)
    at EventEmitter.listen (/home/faddat/gocryptotrader/web/node_modules/express/lib/application.js:617:24)
    at Object.<anonymous> (/home/faddat/gocryptotrader/web/server.js:32:5)
    at Module._compile (module.js:556:32)
    at Object.Module._extensions..js (module.js:565:10)
    at Module.load (module.js:473:32)

npm ERR! Linux 4.7.2-1-ARCH
npm ERR! argv "/home/faddat/.nvm/versions/node/v6.4.0/bin/node" "/home/faddat/.nvm/versions/node/v6.4.0/bin/npm" "start"
npm ERR! node v6.4.0
npm ERR! npm  v3.10.3
npm ERR! code ELIFECYCLE
npm ERR! angular-seed@0.0.0 start: `node server.js`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the angular-seed@0.0.0 start script 'node server.js'.
npm ERR! Make sure you have the latest version of node.js and npm installed.
npm ERR! If you do, this is most likely a problem with the angular-seed package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     node server.js
npm ERR! You can get information on how to open an issue for this project with:
npm ERR!     npm bugs angular-seed
npm ERR! Or if that isn't available, you can get their info via:
npm ERR!     npm owner ls angular-seed
npm ERR! There is likely additional logging output above.

npm ERR! Please include the following file with any support request:
npm ERR!     /home/faddat/gocryptotrader/web/npm-debug.log
[faddat@arch-anywhere]: ~/gocryptotrader/web>$ node server.js
events.js:160
      throw er; // Unhandled 'error' event
      ^

Error: listen EACCES 0.0.0.0:80
    at Object.exports._errnoException (util.js:1026:11)
    at exports._exceptionWithHostPort (util.js:1049:20)
    at Server._listen2 (net.js:1240:19)
    at listen (net.js:1289:10)
    at Server.listen (net.js:1385:5)
    at EventEmitter.listen (/home/faddat/gocryptotrader/web/node_modules/express/lib/application.js:617:24)
    at Object.<anonymous> (/home/faddat/gocryptotrader/web/server.js:32:5)
    at Module._compile (module.js:556:32)
    at Object.Module._extensions..js (module.js:565:10)
    at Module.load (module.js:473:32)

I think it may be my version of node?  I'm going to dial it back one in nvm and will let you know.

@faddat, yurs is a different error. It means that the address/port combination is in use, so the werver that is trying to bind to that port fails.
I also see in your logs that node is trying to execute server.js, which does not exist in this repo. Your problem is not related to angular-seed actually.

oh, well then!  Thank you very much @gkalpak 🎯
I should have spotted that, but will remember that's what it "looks like" in the future.

Getting this error. Please help me if anyone have any idea.
bower html5-boilerplate#^5.3.0  ENOGIT git is not installed or not in the PATH
npm ERR! Windows_NT 10.0.14393
npm ERR! argv "C:\Program Files\nodejs\node.exe" "C:\Program Files\nodejs\node_modules\npm\bin\npm-cli.js" "install"
npm ERR! node v4.5.0
npm ERR! npm  v2.15.9
npm ERR! code ELIFECYCLE
npm ERR! angular-seed@0.0.0 postinstall: bower install
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the angular-seed@0.0.0 postinstall script 'bower install'.
npm ERR! This is most likely a problem with the angular-seed package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     bower install
npm ERR! You can get information on how to open an issue for this project with:
npm ERR!     npm bugs angular-seed
npm ERR! Or if that isn't available, you can get their info via:
npm ERR!
npm ERR!     npm owner ls angular-seed
npm ERR! There is likely additional logging output above.
npm ERR! Please include the following file with any support request:

Closing since we didn't get any feedback from the OP.

repo: angular/angular-seed

license: mit

license_source: bigquery


text:
angular-mocks package.json file does not depend on angular

This is kind of an issue with JSPM workflow. I seem to be forced to use the bower version of the installation rather than the npm version. Meaning:
jspm install npm:angular-mocks
This will install a package that has no idea that angular should be loaded before loading angular-mocks into the page. Installing from the bower.json works because it has the dependency listed correctly.
I prefer installing via npm rather than via bower because we have set up a local NPM cache.

I think that this can be solved using jspm peerDependencies: http://jspm.io/0.17-beta-guide/peer-dependencies.html or possibly a jspm shim dependency.
@onlywei can you take a look and suggest a solution that doesn't involve changing npm dependencies??

@petebacondarwin JSPM's peerDependencies feature seems like a way to resolve version conflicts when multiple packages depend on different versions of another package. It doesn't seem to apply here because the npm version of angular-mocks has no idea that there's a dependency on Angular at all.

@guybedford maybe you have some insight on this?

A JSPM  shim dependency then?

See https://github.com/jspm/registry/commit/94ebcfda771f8cbd1d0d2cb435152dab160829a1 for an example of an Angular override in the registry to shim the package dependency and module dependency (two separate things, the first for install, the second for module loading).

@guybedford - thanks for that. Are you saying that if a similar commit is made for each of the core angular modules then that would solve the problem for @onlywei ?

All that would be needed is the ability for jspm to know that it should load angular first. This can be as simple as the following in the package.json of angular mocks:
{
  "shim": {
    "angular-mocks": {
      "deps": ["angular"]
    }
  }
}

Alternatively this can be added with an override into the registry, but putting it in the original repo is preferred.
Note that the above shim config only works for global files - modules that aren't CommonJS or AMD or use a global UMD pattern.

We can add that. @onlywei fancy creating a PR for each of the bower-angular... repositories?

There are already some overrides for these repos in https://github.com/jspm/registry/tree/master/package-overrides/github/angular. Checking in those proven configurations into the original repos is definitely worthwhile. It is worth first testing the overrides locally and carefully considering any breaking changes where jspm users are already using these repos.
Just let me know if I can help further at all here.

Thanks @guybedford. @petebacondarwin I will try my hand at this soon, hopefully sometime next week.

@guybedford the package.json property is just called "shim"? It's not called "jspm-shim" or anything namespaced like that?

Yes exactly, more info here - https://github.com/jspm/registry/wiki/Configuring-Packages-for-jspm#shim-configuration.

@petebacondarwin @guybedford yep, test with that command works. I see the string: "deps angular"; on line 3 of angular-mocks.js with the override.

Closed via https://github.com/angular/bower-angular-mocks/commit/3f3116c4c74f7397bce13c14e4436ae8ecacc783.

authors: gkalpak guybedford onlywei petebacondarwin


text:
feat(orderBy): speed optimization

Closes #4177.

Closing this in favor of #12072

authors: agentcooper lgalfaso


text:
Firebase relationship

Consider this firebase structure:
products : {
1: {
deadline : 3,
minimum : 4,
name : "Product Name",
productCategory : { 1: true }
productUnitType : { 2: true },
supllier : { 1: true, 2: true }
}
}
productCategory : {
1: {name: "Category Test 1"},
2: {name: "Category Test 2"},
3: {name: "Category Test 3"},
}
productUnitType : {
1: {name: "Category Type 1"},
2: {name: "Category Type 2"},
3: {name: "Category Type 3"},
}
supplier: {
1: {name: "Supplier 1"},
2: {name: "Supplier 2"},
3: {name: "Supplier 3"},
}
When I try to read /products/, I recive the product list normaly,

{{product.name}}
{{product.productCategory.name}}
{{product.productUnitType.name}}
{{product.minimum}}
{{product.deadline}}
                ...
But I want to read product.productUnitType.name or evan suppliers. It's possible? How can I link two structures?
What its the bast way to do that?

Hi,
This is mostly a Stackoverflow type question regarding NoSQL databases not specifically firebase related. But as a quick reply I recommend checking the following firebase documentation
For these type of relations you may need to duplicate the relational data in both nodes. Here's a quick example for products <-> productCategory relation. You can generate the others using the same idea.
 products : {
1: {
deadline : 3,
minimum : 4,
name : "Product Name",
productCategory : {
       1: {
              name: "Category Test 1"
           }},
productUnitType : { 2: true },
supllier : { 1: true, 2: true }
}
}

productCategory : {
1: {
      name: "Category Test 1",
      products: {
                         1:  true
                     }},
2: {name: "Category Test 2"},
3: {name: "Category Test 3"},
}


text:
[MdSelectionList/MatListOption] Add readonly support for items

Feature Description
Right now only disabled is supported for items, which excludes the option if they were previously selected from the final result.
With readonly, the items wouldn't be able to be interacted with but if they were previously checked, then they make it to the final result.
Use Case
To have selection list with items visually stylized as readonly that cannot be checked/unchecked due some business conditions.
Reference:
https://material.angular.io/components/list/api#MatListOption

You mentioned this in your description:

Right now only disabled is supported for items, which excludes the option if they were previously selected from the final result.

The intention with the disabled binding is that it only blocks user interactions, but if the option is selected any other way (e.g. programmatically), it'll still be shown as selected and will propagate to the model. From my testing it seems like it works as expected. Can you post example where it doesn't work like that?

@crisbeto Thanks, I still am figuring this out, changing constantly the code to corner what it is happening, maybe it is a miss-configuration from my side, if I'm able to determine was it was I will post it here.
Thanks again.

@crisbeto You are right, I'm sorry, all points out that the related logic to that specific field was the culprit.
I cleaned up everything (a 2 level formGroup, a valuesChanges on a main field responsible to updating the select-list, and added a missing compareWith) and worked like a charm.

authors: crisbeto diosney

repo: angular/components


text:
MatDatepicker: MatDatepickerParse shows blank error if the field is empty

Reproduction
Use StackBlitz to reproduce your issue: https://stackblitz.com/fork/components-issue
https://stackblitz.com/edit/components-issue-nkebqj?file=src%2Fapp%2Fexample-component.ts
Steps to reproduce:

Hit submit with a blank datepicker

I can't reproduce in the Stackblitz.
Expected Behavior
What behavior were you expecting to see?
The MatDatepicker should allow for an empty field.
Actual Behavior
What behavior did you actually see?
The MatDatepicker adds an error to the FormControl's errors array, with MatDatepickerParse. The error text is "".
From the form:
date: FormControl
  asyncValidator: null
  errors:
    matDatepickerParse:
      text: ""
  __proto__: Object
  __proto__: Object
  pristine: true
  status: "INVALID"

Environment

Angular: 9.0.4
CDK/Material: 9.1.0
Browser(s): Chrome
Operating System (e.g. Windows, macOS, Ubuntu): macOS

Can you post a Stackblitz that shows the issue?

Like I said I can't reproduce the issue in Stackblitz but it's implemented the same. Only difference is my project's version of Material is more recent.

It would still be useful to see what your code looks like.

You could look at the Stackblitz I put in the issue?

authors: crisbeto laneschmidt


text:
docs(form-field): update custom form field control docs

Documentation Feedback
The guide to create a custom form field control is beyond confusing. Some suggestions:

The stackblitz is very very hard to read. There is one .ts file with 2 components and 3 classes, and one of the components in the file references a separate template file with a completely different name. Why not just use another file altogether for the .ts and use the same name as the template?
The accessibility section briefly mentions things like setDescribedByIds(), but the actual implementation doesn't even use many things mentioned (and when I tried to use the exact example, was met with many errors I couldn't get past).
accommodate strict typescript settings, which many people use/are forced to use at work. I ran into many problems with this. Many @Inputs needed to be initialized, and I wasn't sure if I should just use the safe navigation or non-null assertion operators. I think the official documentation should be using the strictest forms of typechecking/null checking instead of the many "any" types that are so often used (not in this guide, but elsewhere in angular docs). It would make things much easier, and also stop teaching so people bad habits.

Affected documentation page
https://material.angular.io/guide/creating-a-custom-form-field-control

For the first bullet point, I disagree. Having two components defined in a single ts file pointing to two separate html files doesn't increase the complexity. Preference on how code in the examples is structured is not something we would take action on, sonless others also find that this has a significant impact on their ability to understand the example we most likely won't adopt this change
For the a11y and strict ts issues, the original purpose of this docs example is not to be perfect battle-tested and ready to use implementation of a phone input. Its only goal was to demonstrate some of the capabilities of the custom form field control
That being said, I'll keep this issue open so our team can discuss potentially enforcing strict ts, no a11y warnings, etc. on our docs examples


text:
build: remove unused dependencies

Removes all unused dependencies. Also reduces dependencies
needed for the legacy gulp setup that is only used for testing
these days (e.g. minifying is not needed for tests; and we also
don't have it in Bazel)

FYI: I looked for a ticket that described the HTMLElement.innerText difference.. but didn't find anything in the MS EdgeHTML tracker. It seems like this has been like that for a long time in IE11/Edge and it's not clear whether it's expected or not. Eventually will be fixed by the Chromium based Edge browser though.


text:
Weird Expansion panel animation

Bug, feature request, or proposal:
Bug
What is the expected behavior?
Better animation
What is the current behavior?
Items show up sooner than animation ends.
What are the steps to reproduce?

What is the use-case or motivation for changing an existing behavior?
Its a bug
Which versions of Angular, Material, OS, TypeScript, browsers are affected?
Angular: 5.2.5
Material: 5.2.1
OS: Mac 10.13.3
Typescript 2.6.2
Chrome 64

Why "Sidenav" in title? This seems to be an expansion or something like that. Could you provide a stackblitz minimum reproduction?

True, i use the expansion panel as a sidenav so that i made the title mistake.

Closing as duplicate of #8754


text:
test(checkbox): add e2e test for checkbox

For issue #550
R: @jelbourn

@tinayuangao looks like you've got merge conflicts now; you should be able to rebase and push after resolving conflicts

Merged conflicts.

LGTM

authors: jelbourn tinayuangao


text:
What version of node and npm? getting build errors

What verison of node and npm should this be installable with?
I am using node 4.1 and npm 3.3.3 and getting build errors, along with when running tests it doesn't open a window and shows them all passing in one second.
Here are the errors on npm install:
(chore/e2e-login-tests)*$ npm install

bufferutil@1.1.0 install /Users/leeblazek/sites/gloo/polymer/node_modules/bufferutil
node-gyp rebuild

CXX(target) Release/obj.target/bufferutil/src/bufferutil.o
In file included from ../src/bufferutil.cc:16:
../node_modules/nan/nan.h:261:25: error: redefinition of '_NanEnsureLocal'
NAN_INLINE v8::Local _NanEnsureLocal(v8::Local val) {
^
../node_modules/nan/nan.h:256:25: note: previous definition is here
NAN_INLINE v8::Local _NanEnsureLocal(v8::Handle val) {
^
../node_modules/nan/nan.h:661:13: error: no member named 'smalloc' in namespace 'node'
, node::smalloc::FreeCallback callback
^
../node_modules/nan/nan.h:672:12: error: no matching function for call to 'New'
return node::Buffer::New(v8::Isolate::GetCurrent(), data, size);
^~~~~~~~~~~
/Users/leeblazek/.node-gyp/4.1.0/include/node/node_buffer.h:31:40: note: candidate function not viable: no known conversion from 'uint32_t' (aka 'unsigned int') to 'enum encoding' for 3rd argument
NODE_EXTERN v8::MaybeLocalv8::Object New(v8::Isolate* isolate,
^
/Users/leeblazek/.node-gyp/4.1.0/include/node/node_buffer.h:43:40: note: candidate function not viable: 2nd argument ('const char ') would lose const qualifier
NODE_EXTERN v8::MaybeLocalv8::Object New(v8::Isolate isolate,
^
/Users/leeblazek/.node-gyp/4.1.0/include/node/node_buffer.h:28:40: note: candidate function not viable: requires 2 arguments, but 3 were provided
NODE_EXTERN v8::MaybeLocalv8::Object New(v8::Isolate* isolate, size_t length);
^
/Users/leeblazek/.node-gyp/4.1.0/include/node/node_buffer.h:36:40: note: candidate function not viable: requires 5 arguments, but 3 were provided
NODE_EXTERN v8::MaybeLocalv8::Object New(v8::Isolate* isolate,
^
In file included from ../src/bufferutil.cc:16:
../node_modules/nan/nan.h:676:12: error: no viable conversion from 'v8::MaybeLocalv8::Object' to 'v8::Localv8::Object'
return node::Buffer::New(v8::Isolate::GetCurrent(), size);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/Users/leeblazek/.node-gyp/4.1.0/include/node/v8.h:210:7: note: candidate constructor (the implicit copy constructor) not viable: no known conversion from 'v8::MaybeLocalv8::Object' to
'const v8::Localv8::Object &' for 1st argument
class Local {
^
/Users/leeblazek/.node-gyp/4.1.0/include/node/v8.h:210:7: note: candidate constructor (the implicit move constructor) not viable: no known conversion from 'v8::MaybeLocalv8::Object' to
'v8::Localv8::Object &&' for 1st argument
class Local {
^
/Users/leeblazek/.node-gyp/4.1.0/include/node/v8.h:214:13: note: candidate template ignored: could not match 'Local' against 'MaybeLocal'
V8_INLINE Local(Local that)
^
/Users/leeblazek/.node-gyp/4.1.0/include/node/v8.h:326:13: note: candidate template ignored: could not match 'S ' against 'v8::MaybeLocalv8::Object'
V8_INLINE Local(S that)
^
In file included from ../src/bufferutil.cc:16:
../node_modules/nan/nan.h:683:26: error: no member named 'Use' in namespace 'node::Buffer'
return node::Buffer::Use(v8::Isolate::GetCurrent(), data, size);
^
In file included from ../src/bufferutil.cc:7:
/Users/leeblazek/.node-gyp/4.1.0/include/node/v8.h:221:5: error: assigning to 'v8::Primitive *volatile' from incompatible type 'v8::Value *'
TYPE_CHECK(T, S);
^~
/Users/leeblazek/.node-gyp/4.1.0/include/node/v8.h:180:37: note: expanded from macro 'TYPE_CHECK'
(static_cast<T volatile*>(0)) = static_cast<S*>(0);
^ ~~~~~~~~~~~~~~~~~~
../node_modules/nan/nan.h:414:12: note: in instantiation of function template specialization 'v8::Localv8::Primitive::Localv8::Value' requested here
return NanEscapeScope(NanNew(v8::Undefined(v8::Isolate::GetCurrent())));
^
../node_modules/nan/nan.h:398:30: note: expanded from macro 'NanEscapeScope'
define NanEscapeScope(val) scope.Escape(_NanEnsureLocal(val))
                         ^

In file included from ../src/bufferutil.cc:7:
/Users/leeblazek/.node-gyp/4.1.0/include/node/v8.h:221:5: error: assigning to 'v8::Boolean volatile' from incompatible type 'v8::Value '
TYPE_CHECK(T, S);
^~~~~~~~~~~~~~~~
/Users/leeblazek/.node-gyp/4.1.0/include/node/v8.h:180:37: note: expanded from macro 'TYPE_CHECK'
(static_cast<T volatile>(0)) = static_cast<S>(0);
^ ~~~~~~~~~~~~~~~~~~
../node_modules/nan/nan.h:424:12: note: in instantiation of function template specialization 'v8::Localv8::Boolean::Localv8::Value' requested here
return NanEscapeScope(NanNew(v8::True(v8::Isolate::GetCurrent())));
^
../node_modules/nan/nan.h:398:30: note: expanded from macro 'NanEscapeScope'
define NanEscapeScope(val) scope.Escape(_NanEnsureLocal(val))
                         ^

In file included from ../src/bufferutil.cc:7:
/Users/leeblazek/.node-gyp/4.1.0/include/node/v8.h:221:5: error: assigning to 'v8::Function volatile' from incompatible type 'v8::Value '
TYPE_CHECK(T, S);
^~~~~~~~~~~~~~~~
/Users/leeblazek/.node-gyp/4.1.0/include/node/v8.h:180:37: note: expanded from macro 'TYPE_CHECK'
(static_cast<T volatile>(0)) = static_cast<S>(0);
^ ~~~~~~~~~~~~~~~~~~
../node_modules/nan/nan.h:1514:12: note: in instantiation of function template specialization 'v8::Localv8::Function::Localv8::Value' requested here
return NanEscapeScope(NanNew(handle)->Get(kCallbackIndex)
^
../node_modules/nan/nan.h:398:30: note: expanded from macro 'NanEscapeScope'
define NanEscapeScope(val) scope.Escape(_NanEnsureLocal(val))
                         ^

In file included from ../src/bufferutil.cc:7:
/Users/leeblazek/.node-gyp/4.1.0/include/node/v8.h:221:5: error: assigning to 'v8::Object volatile' from incompatible type 'v8::Value '
TYPE_CHECK(T, S);
^~~~~~~~~~~~~~~~
/Users/leeblazek/.node-gyp/4.1.0/include/node/v8.h:180:37: note: expanded from macro 'TYPE_CHECK'
(static_cast<T volatile>(0)) = static_cast<S>(0);
^ ~~~~~~~~~~~~~~~~~~
../node_modules/nan/nan.h:1632:12: note: in instantiation of function template specialization 'v8::Localv8::Object::Localv8::Value' requested here
return NanEscapeScope(handle->Get(NanNew(key)).Asv8::Object());
^
../node_modules/nan/nan.h:398:30: note: expanded from macro 'NanEscapeScope'
define NanEscapeScope(val) scope.Escape(_NanEnsureLocal(val))
                         ^

9 errors generated.
make: *** [Release/obj.target/bufferutil/src/bufferutil.o] Error 1
gyp ERR! build error
gyp ERR! stack Error: make failed with exit code: 2
gyp ERR! stack     at ChildProcess.onExit (/Users/leeblazek/.nvm/versions/node/v4.1.0/lib/node_modules/npm/node_modules/node-gyp/lib/build.js:270:23)
gyp ERR! stack     at emitTwo (events.js:87:13)
gyp ERR! stack     at ChildProcess.emit (events.js:172:7)
gyp ERR! stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:200:12)
gyp ERR! System Darwin 14.4.0
gyp ERR! command "/Users/leeblazek/.nvm/versions/node/v4.1.0/bin/node" "/Users/leeblazek/.nvm/versions/node/v4.1.0/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "rebuild"
gyp ERR! cwd /Users/leeblazek/sites/gloo/polymer/node_modules/bufferutil
gyp ERR! node -v v4.1.0
gyp ERR! node-gyp -v v3.0.1
gyp ERR! not ok
npm WARN install:bufferutil bufferutil@1.1.0 install: node-gyp rebuild
npm WARN install:bufferutil Exit status 1

fsevents@0.2.1 install /Users/leeblazek/sites/gloo/polymer/node_modules/fsevents
node-gyp rebuild

CXX(target) Release/obj.target/fse/fsevents.o
In file included from ../fsevents.cc:6:
../../nan/nan.h:339:13: error: no member named 'New' in 'v8::String'
return  _NAN_ERROR(v8::Exception::Error, errmsg);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../../nan/nan.h:319:50: note: expanded from macro '_NAN_ERROR'
define _NAN_ERROR(fun, errmsg) fun(v8::String::New(errmsg))
                                 ~~~~~~~~~~~~^

../../nan/nan.h:343:5: error: no member named 'ThrowException' in namespace 'v8'
_NAN_THROW_ERROR(v8::Exception::Error, errmsg);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../../nan/nan.h:324:11: note: expanded from macro '_NAN_THROW_ERROR'
v8::ThrowException(_NAN_ERROR(fun, errmsg));
^
../../nan/nan.h:343:5: error: no member named 'New' in 'v8::String'
_NAN_THROW_ERROR(v8::Exception::Error, errmsg);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../../nan/nan.h:324:26: note: expanded from macro '_NAN_THROW_ERROR'
v8::ThrowException(_NAN_ERROR(fun, errmsg));
^~~~~~~~~~~~~~~~~~~~~~~
../../nan/nan.h:319:50: note: expanded from macro '_NAN_ERROR'
define _NAN_ERROR(fun, errmsg) fun(v8::String::New(errmsg))
                                 ~~~~~~~~~~~~^

../../nan/nan.h:348:9: error: no type named 'ThrowException' in namespace 'v8'
v8::ThrowException(error);
^
../../nan/nan.h:355:53: error: no member named 'New' in 'v8::String'; did you mean 'v8::TypeSwitch::New'?
v8::Localv8::Value err = v8::Exception::Error(v8::String::New(msg));
^~~~~~~~~~~
v8::TypeSwitch::New
/Users/leeblazek/.node-gyp/4.1.0/include/node/v8.h:4705:28: note: 'v8::TypeSwitch::New' declared here
static Local New(Local type);
^
In file included from ../fsevents.cc:6:
../../nan/nan.h:355:69: error: calling a private constructor of class 'v8::Localv8::FunctionTemplate'
v8::Localv8::Value err = v8::Exception::Error(v8::String::New(msg));
^
/Users/leeblazek/.node-gyp/4.1.0/include/node/v8.h:326:13: note: declared private here
V8_INLINE Local(S* that)
^
In file included from ../fsevents.cc:6:
../../nan/nan.h:357:65: error: too few arguments to function call, expected 2, have 1
obj->Set(v8::String::New("code"), v8::Int32::New(errorNumber));
~~~~~~~~~~~~~~            ^
/Users/leeblazek/.node-gyp/4.1.0/include/node/v8.h:2499:3: note: 'New' declared here
static Local New(Isolate* isolate, int32_t value);
^
In file included from ../fsevents.cc:6:
../../nan/nan.h:357:26: error: no member named 'New' in 'v8::String'
obj->Set(v8::String::New("code"), v8::Int32::New(errorNumber));
^
../../nan/nan.h:369:12: error: no member named 'New' in 'v8::String'
return _NAN_ERROR(v8::Exception::TypeError, errmsg);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../../nan/nan.h:319:50: note: expanded from macro '_NAN_ERROR'
define _NAN_ERROR(fun, errmsg) fun(v8::String::New(errmsg))
                                 ~~~~~~~~~~~~^

../../nan/nan.h:373:5: error: no member named 'ThrowException' in namespace 'v8'
_NAN_THROW_ERROR(v8::Exception::TypeError, errmsg);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../../nan/nan.h:324:11: note: expanded from macro '_NAN_THROW_ERROR'
v8::ThrowException(_NAN_ERROR(fun, errmsg));
^
../../nan/nan.h:373:5: error: no member named 'New' in 'v8::String'
_NAN_THROW_ERROR(v8::Exception::TypeError, errmsg);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../../nan/nan.h:324:26: note: expanded from macro '_NAN_THROW_ERROR'
v8::ThrowException(_NAN_ERROR(fun, errmsg));
^~~~~~~~~~~~~~~~~~~~~~~
../../nan/nan.h:319:50: note: expanded from macro '_NAN_ERROR'
define _NAN_ERROR(fun, errmsg) fun(v8::String::New(errmsg))
                                 ~~~~~~~~~~~~^

../../nan/nan.h:377:12: error: no member named 'New' in 'v8::String'
return _NAN_ERROR(v8::Exception::RangeError, errmsg);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../../nan/nan.h:319:50: note: expanded from macro '_NAN_ERROR'
define _NAN_ERROR(fun, errmsg) fun(v8::String::New(errmsg))
                                 ~~~~~~~~~~~~^

../../nan/nan.h:381:5: error: no member named 'ThrowException' in namespace 'v8'
_NAN_THROW_ERROR(v8::Exception::RangeError, errmsg);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../../nan/nan.h:324:11: note: expanded from macro '_NAN_THROW_ERROR'
v8::ThrowException(_NAN_ERROR(fun, errmsg));
^
../../nan/nan.h:381:5: error: no member named 'New' in 'v8::String'
_NAN_THROW_ERROR(v8::Exception::RangeError, errmsg);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../../nan/nan.h:324:26: note: expanded from macro '_NAN_THROW_ERROR'
v8::ThrowException(_NAN_ERROR(fun, errmsg));
^~~~~~~~~~~~~~~~~~~~~~~
../../nan/nan.h:319:50: note: expanded from macro '_NAN_ERROR'
define _NAN_ERROR(fun, errmsg) fun(v8::String::New(errmsg))
                                 ~~~~~~~~~~~~^

../../nan/nan.h:406:13: error: no member named 'smalloc' in namespace 'node'
, node::smalloc::FreeCallback callback
~~~~~~^
../../nan/nan.h:141:71: note: expanded from macro 'NAN_INLINE'
define NAN_INLINE(declarator) inline attribute((always_inline)) declarator
                                                                  ^

../../nan/nan.h:416:12: error: no matching function for call to 'New'
return node::Buffer::New(data, size);
^~~~~~~~~~~~~~~~~
/Users/leeblazek/.node-gyp/4.1.0/include/node/node_buffer.h:28:40: note: candidate function not viable: no known conversion from 'char ' to 'v8::Isolate ' for 1st argument
NODE_EXTERN v8::MaybeLocalv8::Object New(v8::Isolate isolate, size_t length);
^
/Users/leeblazek/.node-gyp/4.1.0/include/node/node_buffer.h:31:40: note: candidate function not viable: no known conversion from 'char ' to 'v8::Isolate ' for 1st argument
NODE_EXTERN v8::MaybeLocalv8::Object New(v8::Isolate isolate,
^
/Users/leeblazek/.node-gyp/4.1.0/include/node/node_buffer.h:43:40: note: candidate function not viable: requires 3 arguments, but 2 were provided
NODE_EXTERN v8::MaybeLocalv8::Object New(v8::Isolate isolate,
^
/Users/leeblazek/.node-gyp/4.1.0/include/node/node_buffer.h:36:40: note: candidate function not viable: requires 5 arguments, but 2 were provided
NODE_EXTERN v8::MaybeLocalv8::Object New(v8::Isolate isolate,
^
In file included from ../fsevents.cc:6:
../../nan/nan.h:420:12: error: no matching function for call to 'New'
return node::Buffer::New(size);
^~~~~~~~~~~~~~~~~
/Users/leeblazek/.node-gyp/4.1.0/include/node/node_buffer.h:28:40: note: candidate function not viable: requires 2 arguments, but 1 was provided
NODE_EXTERN v8::MaybeLocalv8::Object New(v8::Isolate* isolate, size_t length);
^
/Users/leeblazek/.node-gyp/4.1.0/include/node/node_buffer.h:31:40: note: candidate function not viable: requires at least 2 arguments, but 1 was provided
NODE_EXTERN v8::MaybeLocalv8::Object New(v8::Isolate* isolate,
^
/Users/leeblazek/.node-gyp/4.1.0/include/node/node_buffer.h:43:40: note: candidate function not viable: requires 3 arguments, but 1 was provided
NODE_EXTERN v8::MaybeLocalv8::Object New(v8::Isolate* isolate,
^
/Users/leeblazek/.node-gyp/4.1.0/include/node/node_buffer.h:36:40: note: candidate function not viable: requires 5 arguments, but 1 was provided
NODE_EXTERN v8::MaybeLocalv8::Object New(v8::Isolate* isolate,
^
In file included from ../fsevents.cc:6:
../../nan/nan.h:427:26: error: no member named 'Use' in namespace 'node::Buffer'
return node::Buffer::Use(data, size);
~~~~~~~~~~~~~~^
../../nan/nan.h:727:49: error: too few arguments to function call, single argument 'isolate' was not specified
v8::Localv8::Object obj = v8::Object::New();
~~~~~~~~~~~~~~~ ^
/Users/leeblazek/.node-gyp/4.1.0/include/node/v8.h:2933:3: note: 'New' declared here
static Local New(Isolate* isolate);
^
fatal error: too many errors emitted, stopping now [-ferror-limit=]
20 errors generated.
make: *** [Release/obj.target/fse/fsevents.o] Error 1
gyp ERR! build error
gyp ERR! stack Error: make failed with exit code: 2
gyp ERR! stack     at ChildProcess.onExit (/Users/leeblazek/.nvm/versions/node/v4.1.0/lib/node_modules/npm/node_modules/node-gyp/lib/build.js:270:23)
gyp ERR! stack     at emitTwo (events.js:87:13)
gyp ERR! stack     at ChildProcess.emit (events.js:172:7)
gyp ERR! stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:200:12)
gyp ERR! System Darwin 14.4.0
gyp ERR! command "/Users/leeblazek/.nvm/versions/node/v4.1.0/bin/node" "/Users/leeblazek/.nvm/versions/node/v4.1.0/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "rebuild"
gyp ERR! cwd /Users/leeblazek/sites/gloo/polymer/node_modules/fsevents
gyp ERR! node -v v4.1.0
gyp ERR! node-gyp -v v3.0.1
gyp ERR! not ok
npm WARN install:fsevents fsevents@0.2.1 install: node-gyp rebuild
npm WARN install:fsevents Exit status 1

utf-8-validate@1.1.0 install /Users/leeblazek/sites/gloo/polymer/node_modules/utf-8-validate
node-gyp rebuild

CXX(target) Release/obj.target/validation/src/validation.o
In file included from ../src/validation.cc:15:
../node_modules/nan/nan.h:261:25: error: redefinition of '_NanEnsureLocal'
NAN_INLINE v8::Local _NanEnsureLocal(v8::Local val) {
^
../node_modules/nan/nan.h:256:25: note: previous definition is here
NAN_INLINE v8::Local _NanEnsureLocal(v8::Handle val) {
^
../node_modules/nan/nan.h:661:13: error: no member named 'smalloc' in namespace 'node'
, node::smalloc::FreeCallback callback
^
../node_modules/nan/nan.h:672:12: error: no matching function for call to 'New'
return node::Buffer::New(v8::Isolate::GetCurrent(), data, size);
^~~~~~~~~~~
/Users/leeblazek/.node-gyp/4.1.0/include/node/node_buffer.h:31:40: note: candidate function not viable: no known conversion from 'uint32_t' (aka 'unsigned int') to 'enum encoding' for 3rd argument
NODE_EXTERN v8::MaybeLocalv8::Object New(v8::Isolate* isolate,
^
/Users/leeblazek/.node-gyp/4.1.0/include/node/node_buffer.h:43:40: note: candidate function not viable: 2nd argument ('const char ') would lose const qualifier
NODE_EXTERN v8::MaybeLocalv8::Object New(v8::Isolate isolate,
^
/Users/leeblazek/.node-gyp/4.1.0/include/node/node_buffer.h:28:40: note: candidate function not viable: requires 2 arguments, but 3 were provided
NODE_EXTERN v8::MaybeLocalv8::Object New(v8::Isolate* isolate, size_t length);
^
/Users/leeblazek/.node-gyp/4.1.0/include/node/node_buffer.h:36:40: note: candidate function not viable: requires 5 arguments, but 3 were provided
NODE_EXTERN v8::MaybeLocalv8::Object New(v8::Isolate* isolate,
^
In file included from ../src/validation.cc:15:
../node_modules/nan/nan.h:676:12: error: no viable conversion from 'v8::MaybeLocalv8::Object' to 'v8::Localv8::Object'
return node::Buffer::New(v8::Isolate::GetCurrent(), size);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/Users/leeblazek/.node-gyp/4.1.0/include/node/v8.h:210:7: note: candidate constructor (the implicit copy constructor) not viable: no known conversion from 'v8::MaybeLocalv8::Object' to
'const v8::Localv8::Object &' for 1st argument
class Local {
^
/Users/leeblazek/.node-gyp/4.1.0/include/node/v8.h:210:7: note: candidate constructor (the implicit move constructor) not viable: no known conversion from 'v8::MaybeLocalv8::Object' to
'v8::Localv8::Object &&' for 1st argument
class Local {
^
/Users/leeblazek/.node-gyp/4.1.0/include/node/v8.h:214:13: note: candidate template ignored: could not match 'Local' against 'MaybeLocal'
V8_INLINE Local(Local that)
^
/Users/leeblazek/.node-gyp/4.1.0/include/node/v8.h:326:13: note: candidate template ignored: could not match 'S ' against 'v8::MaybeLocalv8::Object'
V8_INLINE Local(S that)
^
In file included from ../src/validation.cc:15:
../node_modules/nan/nan.h:683:26: error: no member named 'Use' in namespace 'node::Buffer'
return node::Buffer::Use(v8::Isolate::GetCurrent(), data, size);
^
In file included from ../src/validation.cc:7:
/Users/leeblazek/.node-gyp/4.1.0/include/node/v8.h:221:5: error: assigning to 'v8::Primitive *volatile' from incompatible type 'v8::Value *'
TYPE_CHECK(T, S);
^~
/Users/leeblazek/.node-gyp/4.1.0/include/node/v8.h:180:37: note: expanded from macro 'TYPE_CHECK'
(static_cast<T volatile*>(0)) = static_cast<S*>(0);
^ ~~~~~~~~~~~~~~~~~~
../node_modules/nan/nan.h:414:12: note: in instantiation of function template specialization 'v8::Localv8::Primitive::Localv8::Value' requested here
return NanEscapeScope(NanNew(v8::Undefined(v8::Isolate::GetCurrent())));
^
../node_modules/nan/nan.h:398:30: note: expanded from macro 'NanEscapeScope'
define NanEscapeScope(val) scope.Escape(_NanEnsureLocal(val))
                         ^

In file included from ../src/validation.cc:7:
/Users/leeblazek/.node-gyp/4.1.0/include/node/v8.h:221:5: error: assigning to 'v8::Boolean volatile' from incompatible type 'v8::Value '
TYPE_CHECK(T, S);
^~~~~~~~~~~~~~~~
/Users/leeblazek/.node-gyp/4.1.0/include/node/v8.h:180:37: note: expanded from macro 'TYPE_CHECK'
(static_cast<T volatile>(0)) = static_cast<S>(0);
^ ~~~~~~~~~~~~~~~~~~
../node_modules/nan/nan.h:424:12: note: in instantiation of function template specialization 'v8::Localv8::Boolean::Localv8::Value' requested here
return NanEscapeScope(NanNew(v8::True(v8::Isolate::GetCurrent())));
^
../node_modules/nan/nan.h:398:30: note: expanded from macro 'NanEscapeScope'
define NanEscapeScope(val) scope.Escape(_NanEnsureLocal(val))
                         ^

In file included from ../src/validation.cc:7:
/Users/leeblazek/.node-gyp/4.1.0/include/node/v8.h:221:5: error: assigning to 'v8::Function volatile' from incompatible type 'v8::Value '
TYPE_CHECK(T, S);
^~~~~~~~~~~~~~~~
/Users/leeblazek/.node-gyp/4.1.0/include/node/v8.h:180:37: note: expanded from macro 'TYPE_CHECK'
(static_cast<T volatile>(0)) = static_cast<S>(0);
^ ~~~~~~~~~~~~~~~~~~
../node_modules/nan/nan.h:1514:12: note: in instantiation of function template specialization 'v8::Localv8::Function::Localv8::Value' requested here
return NanEscapeScope(NanNew(handle)->Get(kCallbackIndex)
^
../node_modules/nan/nan.h:398:30: note: expanded from macro 'NanEscapeScope'
define NanEscapeScope(val) scope.Escape(_NanEnsureLocal(val))
                         ^

In file included from ../src/validation.cc:7:
/Users/leeblazek/.node-gyp/4.1.0/include/node/v8.h:221:5: error: assigning to 'v8::Object volatile' from incompatible type 'v8::Value '
TYPE_CHECK(T, S);
^~~~~~~~~~~~~~~~
/Users/leeblazek/.node-gyp/4.1.0/include/node/v8.h:180:37: note: expanded from macro 'TYPE_CHECK'
(static_cast<T volatile>(0)) = static_cast<S>(0);
^ ~~~~~~~~~~~~~~~~~~
../node_modules/nan/nan.h:1632:12: note: in instantiation of function template specialization 'v8::Localv8::Object::Localv8::Value' requested here
return NanEscapeScope(handle->Get(NanNew(key)).Asv8::Object());
^
../node_modules/nan/nan.h:398:30: note: expanded from macro 'NanEscapeScope'
define NanEscapeScope(val) scope.Escape(_NanEnsureLocal(val))
                         ^

9 errors generated.
make: *** [Release/obj.target/validation/src/validation.o] Error 1
gyp ERR! build error
gyp ERR! stack Error: make failed with exit code: 2
gyp ERR! stack     at ChildProcess.onExit (/Users/leeblazek/.nvm/versions/node/v4.1.0/lib/node_modules/npm/node_modules/node-gyp/lib/build.js:270:23)
gyp ERR! stack     at emitTwo (events.js:87:13)
gyp ERR! stack     at ChildProcess.emit (events.js:172:7)
gyp ERR! stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:200:12)
gyp ERR! System Darwin 14.4.0
gyp ERR! command "/Users/leeblazek/.nvm/versions/node/v4.1.0/bin/node" "/Users/leeblazek/.nvm/versions/node/v4.1.0/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "rebuild"
gyp ERR! cwd /Users/leeblazek/sites/gloo/polymer/node_modules/utf-8-validate
gyp ERR! node -v v4.1.0
gyp ERR! node-gyp -v v3.0.1
gyp ERR! not ok
npm WARN install:utf-8-validate utf-8-validate@1.1.0 install: node-gyp rebuild
npm WARN install:utf-8-validate Exit status 1
npm WARN prefer global bower@1.4.1 should be installed with -g
polymer@1.0.0 /Users/leeblazek/sites/gloo/polymer
├─┬ grunt@0.4.5
│ ├─┬ findup-sync@0.1.3
│ │ ├─┬ glob@3.2.11
│ │ │ └── minimatch@0.3.0
│ │ └── lodash@2.4.2
│ └─┬ grunt-legacy-log@0.1.2
│   ├─┬ grunt-legacy-log-utils@0.1.1
│   │ └── lodash@2.4.2
│   └── lodash@2.4.2
├─┬ grunt-jscs@0.8.1
│ └── lodash@2.4.2
├─┬ grunt-protractor-runner@1.2.1
│ └─┬ protractor@1.8.0
│   ├─┬ glob@3.2.11
│   │ └── minimatch@0.3.0
│   ├─┬ jasmine@2.1.1
│   │ └─┬ glob@3.2.11
│   │   └── minimatch@0.3.0
│   └── lodash@2.4.2
├─┬ gulp-kss@0.0.2
│ ├─┬ gulp@3.5.6
│ │ └─┬ liftoff@0.9.8
│ │   └─┬ findup-sync@0.1.3
│ │     ├─┬ glob@3.2.11
│ │     │ └── minimatch@0.3.0
│ │     └── lodash@2.4.2
│ ├─┬ gulp-less@1.2.4
│ │ └─┬ less@1.7.5
│ │   └─┬ request@2.40.0
│ │     └─┬ form-data@0.1.4
│ │       └─┬ combined-stream@0.0.7
│ │         └── delayed-stream@0.0.5
│ └─┬ kss@0.3.7
│   └─┬ less@1.7.5
│     └─┬ request@2.40.0
│       └─┬ form-data@0.1.4
│         └─┬ combined-stream@0.0.7
│           └── delayed-stream@0.0.5
├─┬ gulp-livereload@3.8.0
│ └─┬ tiny-lr@0.1.6
│   └─┬ body-parser@1.8.4
│     └─┬ type-is@1.5.7
│       └── mime-types@2.0.14
├─┬ phantomjs@1.9.18
│ └─┬ request@2.42.0
│   └─┬ form-data@0.1.4
│     └─┬ combined-stream@0.0.7
│       └── delayed-stream@0.0.5
└─┬ protractor@2.3.0
├─┬ glob@3.2.11
│ └── minimatch@0.3.0
├─┬ jasmine@2.3.2
│ └── jasmine-core@2.3.4
├── jasminewd2@0.0.5
├── lodash@2.4.2
├─┬ request@2.57.0
│ ├── caseless@0.10.0
│ ├─┬ combined-stream@1.0.5
│ │ └── delayed-stream@1.0.0
│ ├── forever-agent@0.6.1
│ ├─┬ form-data@0.2.0
│ │ └─┬ combined-stream@0.0.7
│ │   └── delayed-stream@0.0.5
│ ├─┬ hawk@2.3.1
│ │ ├── boom@2.9.0
│ │ ├── cryptiles@2.0.5
│ │ ├── hoek@2.16.3
│ │ └── sntp@1.0.9
│ ├── http-signature@0.11.0
│ ├── mime-types@2.0.14
│ ├── oauth-sign@0.8.0
│ └── qs@3.1.0
├── saucelabs@1.0.1
└── selenium-webdriver@2.45.1
npm WARN EPACKAGEJSON polymer@1.0.0 No repository field.
npm WARN EPACKAGEJSON polymer@1.0.0 No license field.

duplicate of https://github.com/angular/protractor/issues/2489
NOTE: These errors are in optional deps. Everything will actually work, even though npm is shouting at you.

authors: juliemr surfjedi

repo: angular/protractor


text:
Protractor still hanging on "[launcher] Running 1 instances of WebDriver"

The issue #2419 still persists. I suggest reopening that issue to make it easy to review the comments.

Just to be clear - @PaddyMann is this still when using xvfb?

Yes - apologies for the missing detail @juliemr

OK, reopening the old issue since it's still descriptive.

authors: PaddyMann juliemr


text:
Protractor and element.all

Protractor used with angular 2 does not find elements when using element.all

Please follow the issue template.

authors: cnishina pearljamik


text:
Missing support for httpProxy?

The reference conf file doesn't list httpProxy capabilities https://github.com/angular/protractor/blob/master/lib/config.ts. Trying the below doesn't work. Also, passing any value to the httpProxy key passes the test which means that the httpProxy is probably ignored.
Is httpProxy still supported?
capabilities: {
    proxy: {
        proxyType: 'manual',
        httpProxy: 'host:port'
    }
}

Protractor Version 4.0.10

Proxy is still supported. We just pass these capabilities to the server / driver provider. The config.ts is an interface that could have additional capabilities that are not listed, based on https://github.com/angular/protractor/blob/master/lib/config.ts#L239. When launching a browser, you could verify the capabilities are appearing.
get capabilities:
browser.getCapabilities().then(caps => {console.log(caps);});

console log:
Capabilities {
  'applicationCacheEnabled' => false,
  'rotatable' => false,
  'mobileEmulationEnabled' => false,
  'networkConnectionEnabled' => false,
  'chrome' => { chromedriverVersion: '2.25.426935 (820a95b0b81d33e42712f9198c215f703412e1a1)',
  userDataDir: '/var/folders/gx/4cw5vsyj4lx332w66xwdxwpm00b14w/T/.org.chromium.Chromium.eRNQJ1' },
  'takesHeapSnapshot' => true,
  'pageLoadStrategy' => 'normal',
  'databaseEnabled' => false,
  'handlesAlerts' => true,
  'hasTouchScreen' => false,
  'version' => '54.0.2840.98',
  'platform' => 'MAC',
  'browserConnectionEnabled' => false,
  'nativeEvents' => true,
  'acceptSslCerts' => true,
  'webdriver.remote.sessionid' => 'c2b95382-92d1-4d5b-8396-ebe336a0b2b0',
  'locationContextEnabled' => true,
  'webStorageEnabled' => true,
  'browserName' => 'chrome',
  'takesScreenshot' => true,
  'javascriptEnabled' => true,
  'cssSelectorsEnabled' => true }

I still can't get it to work. It seems to me like httpProxy capability is not passed onto webdriver. If I do this, the test still passes although it should fail on non-existent proxy. Am I missing something here?
 capabilities: {
    'proxy': {
        'proxyType': 'manual',
        'httpProxy': 'invalidUrl'
    }
}

Nevermind, it's the sslProxy that I had to use. Problem solved!
 capabilities: {
    'proxy': {
        'proxyType': 'manual',
        'sslProxy': 'hostname.com:port'
    }
}

authors: cnishina finspin


text:
Execution order of Suites and Specs in Conf file Protractor

Hi All,
I want to know the execution order of Suites and Specs in conf file for Protractor.I have read at few places that it is in alphabetical order a->z but while running specs on my file I find they are executed in the order they are defined in conf.Can someone please confirm the behavior for this ?

Regards,
Kunal

The ordering of suites will be respected since we iterate over the keys of suites. Alphabetical order typically comes into play with "globs" like *-spec.js, those will be sorted in alaphabetical order.
I'm going to go ahead and close this; please ask any additional questions on StackOverflow.

Thanks Nick things are clear now .

authors: NickTomlin kunalshokeen


text:
similar issue as #203

I am facing similar problem as reported in #203. I get error when i do npm start. On close debugging i found that "tsc -w" is failing. You can close this if you thing that #203 and this one is related..
I am on mac, with tsc version 1.8.10, typings 1.3.3 and node 6.5.0.
simply doing "tsc -w" gives me the following error:
quickstart $ tsc -w
fs.js:1431
throw error;
^
Error: watch /users/u/projects/experiements/rc6/quickstart ENOENT
at exports._errnoException (util.js:1026:11)
at FSWatcher.start (fs.js:1429:19)
at Object.fs.watch (fs.js:1456:11)
at addDirWatcher (/usr/local/lib/node_modules/typescript/lib/tsc.js:1036:39)
at Object.addFile (/usr/local/lib/node_modules/typescript/lib/tsc.js:1051:21)
at Object.watchFile (/usr/local/lib/node_modules/typescript/lib/tsc.js:1172:48)
at Object.executeCommandLine (/usr/local/lib/node_modules/typescript/lib/tsc.js:34546:44)
at Object. (/usr/local/lib/node_modules/typescript/lib/tsc.js:34877:4)
at Module._compile (module.js:556:32)
at Object.Module._extensions..js (module.js:565:10)
I have tried almost everything mentioned in this issue chain, but it's not working.

Following these instructions fix that for me:
http://stackoverflow.com/questions/34335340/angular2-quickstart-npm-start-is-not-working-correctly
They essentially installed some of the dependencies globally with:
sudo npm install -g concurrently lite-server typescript

Shane, The instructions do not help!

quickstart $ sudo npm install -g concurrently lite-server typescript
Password:
npm WARN deprecated tough-cookie@2.2.2: ReDoS vulnerability parsing Set-Cookie https://nodesecurity.io/advisories/130
/usr/local/bin/concurrently -> /usr/local/lib/node_modules/concurrently/src/main.js
/usr/local/bin/concurrent -> /usr/local/lib/node_modules/concurrently/src/main.js
/usr/local/bin/lite-server -> /usr/local/lib/node_modules/lite-server/bin/lite-server
/usr/local/bin/tsc -> /usr/local/lib/node_modules/typescript/bin/tsc
/usr/local/bin/tsserver -> /usr/local/lib/node_modules/typescript/bin/tsserver
/usr/local/lib
├── concurrently@2.2.0
├─┬ lite-server@2.2.2
│ └─┬ browser-sync@2.15.0
│   ├─┬ chokidar@1.6.0
│   │ ├── inherits@2.0.3
│   │ └─┬ is-binary-path@1.0.1
│   │   └── binary-extensions@1.6.0
│   ├─┬ fs-extra@0.30.0
│   │ └─┬ rimraf@2.5.4
│   │   └─┬ glob@7.0.6
│   │     └── once@1.4.0
│   └─┬ serve-index@1.8.0
│     └─┬ http-errors@1.5.0
│       └── inherits@2.0.1
└── typescript@1.8.10
quickstart $ tsc -w
fs.js:1431
throw error;
^
Error: watch /users/kalra/projects/experiements/rc6/quickstart ENOENT
at exports._errnoException (util.js:1026:11)
at FSWatcher.start (fs.js:1429:19)
at Object.fs.watch (fs.js:1456:11)
at addDirWatcher (/usr/local/lib/node_modules/typescript/lib/tsc.js:1036:39)
at Object.addFile (/usr/local/lib/node_modules/typescript/lib/tsc.js:1051:21)
at Object.watchFile (/usr/local/lib/node_modules/typescript/lib/tsc.js:1172:48)
at Object.executeCommandLine (/usr/local/lib/node_modules/typescript/lib/tsc.js:34546:44)
at Object. (/usr/local/lib/node_modules/typescript/lib/tsc.js:34877:4)
at Module._compile (module.js:556:32)
at Object.Module._extensions..js (module.js:565:10)

Old. Not about QuickStart. Closing

authors: DeepshikhaKalra ShaneRich5 wardbell

repo: angular/quickstart


text:
no component's controller instance in scope at directive's link function

Hi,
I have encountered following issue when trying to use the router:
When accessing component's controller instance from scope, being inside of a directive's link function, I get undefined but when I wrap it in evalAsync everything works as expected. Directive of course is used inside of the component's template.
Here's the plunkr:
http://plnkr.co/edit/zEdNVHZzJC4DcPIU5BbZ?p=preview

I am experiencing the exact same issue. Is there any news on this?

authors: lennehendrickx trefnis

repo: angular/router


text:
fix(patch): fix #708, modify the canPatchDescriptor logic when browser has no onreadystatechange

Fix #708,
in jsdom, XMLHttpRequest has no onreadystatechange,
in zone.js canPatchDescriptor logic, zone.js use a fake onreadystatechange descriptor which only have a getter, and XMLHttpRequest will use this one, and prevent set onreadystatechange property.
so we need to use a workable onreadystatechange descriptor in this case.

could you rebase so that we can merge it in?

@mhevery , I have rebased the PR, please review.

great! @JiaLiPassion   I need this for tests with jest+jsdom.
For now i'm using a patch with your changes

authors: JiaLiPassion abner mhevery


text:
Last release doesnt reflect last changes

Hello,
Could you create a version with the latest changes ? The 0.1.1 version is quite old.
Thanks

@lunks can you bump this on npm?

repo: angulartics/angulartics-localytics


text:
Add webpack files to webpack folder

closes: #133

@anikethsaha Please review the changes, Inform me if there is need for any changes

What is the benefit of that?

No benifits in particular, but it states that it contains configurations for the project.
like .github folder

Changes have been made

netlify deployement is failing. Can you check that locally if there is any issue with running the scripts.

No, I have verified the changes before pushing. 👍

No, I have verified the changes before pushing. 👍

umm, I will check this soon 👍

Hey,
Did you check?

I will check this soon. A bit busy for few coming days

Bro, it's been 8 days. Can you please review now?

@anikethsaha Can you check now?

I will check this weekend.
Thank you for your patience

Bro, I think, contributed to a dead project.

apologies for delay.
Did you test locally is there any issue in that ? I didn't check locally, have some issue with my current OS config.

I had checked when I fixed this. It was working fine.

authors: Ckbhatia anikethsaha

repo: anikethsaha/mern


text:
Missing ship-data

When trying to run ship-data example, the following data is not available :
FileNotFoundError: [Errno 2] No such file or directory: 'E:/Geodata/MarineCadastre/AIS_2021_03_28.zip'

Thank you for the report. This cell should be removed from the notebook since it is wrong. The correct data loading code is shown in the following cell
read_file('../data/ais.gpkg')

authors: AlexNewn anitagraser

repo: anitagraser/movingpandas-examples


text:
Crash on rotating screen twice

Steps to reproduce

Open aniyomi
Rotate screen twice
Crash.

Expected behavior
The app should not crash.
Actual behavior
The app crashes.
Crash logs
No response
Aniyomi version
r7513
Android version
LineageOS 20 (Android 13)
Device
Samsung S9
Other details
https://github.com/aniyomiorg/aniyomi/assets/129636286/016bfabd-8617-4d1c-b1d0-50bd8f66536d
Acknowledgements

[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
[X] I have written a short but informative title.
[X] If this is an issue with an official extension, I should be opening an issue in the extensions repository.
[X] If this is an issue with an official manga extension and this issue can be replicated in the Tachiyomi app, that I should be opening an issue in Tachiyomi's extensions repository.
[X] I have gone through the FAQ and troubleshooting guide.
[X] I have updated the app to version 0.15.2.4.
[X] I have updated all installed extensions.
[X] I will fill out all of the requested information in this form.

relevant to #1484 and #1446

I have the same issue. App also crashes when I press back while in video player. Its also connected to rotation issue.

App still crashes on my device even with auto rotate turned off.
https://github.com/aniyomiorg/aniyomi/assets/129636286/1e8bf091-2956-4757-98c7-9243726256fa

I am guessing this was because of a bug caused by the main activity creating an mpv instance twice. This was fixed on 71e0d44a0b82a708342a8b22e108dd051e2c1615

authors: abdallahmehiz fakebhai shubham926 suhaien

repo: aniyomiorg/aniyomi


text:
Cannot checkout review mode

Issue Type: Bug
Cannot checkout review mode
git config
$> git remote  get-url origin --all
git@ssh.dev.azure.com:v3/figg/Decisions/Decisions.Web

config
        "azdoPullRequests.defaultMergeMethod": "Rebase",
        "azdoPullRequests.orgUrl": "https://dev.azure.com/figg",
        "azdoPullRequests.projectName": "Decisions",
        "azdoPullRequests.pullRequestDescription": "ask",
        "azdoPullRequests.remotes": [
            "origin"
        ]

logs

[Info] PAT token is not provided
[Info] Looking for git repository
[Info] Git repository found, initializing review manager and pr tree view.
[Info] Review> Validate state in progress
[Info] Review> Validating state...
[Info] Found GitHub remote
[Info] Review> no matching pull request metadata found for current branch tasks/4887-upgrade-froala
[Info] Review> no matching pull request metadata found on GitHub for current branch tasks/4887-upgrade-froala
[Info] PAT token is not provided
[Info] Review> Queuing additional validate state
[Info] Review> Validating state...
[Info] Found GitHub remote
[Info] Review> Queuing additional validate state
[Info] Review> no matching pull request metadata found for current branch tasks/4887-upgrade-froala
[Info] Warning: no result data for _git/Decisions.Web for search: {"sourceRefName":"tasks/4887-upgrade-froala"}
[Info] Review> no matching pull request metadata found on GitHub for current branch tasks/4887-upgrade-froala
[Info] Review> Validating state...
[Info] Found GitHub remote
[Info] Review> no matching pull request metadata found for current branch tasks/4887-upgrade-froala
[Info] Warning: no result data for _git/Decisions.Web for search: {"sourceRefName":"tasks/4887-upgrade-froala"}
[Info] Review> no matching pull request metadata found on GitHub for current branch tasks/4887-upgrade-froala
[Info] Review> switch to Pull Request #3427 - start
[Info] PullRequestGitHelper> Branch pr/kasturi.sharma@meetingdecisions.com/3427 is from a fork. Create a remote first.
[Info] PullRequestGitHelper> create remote for https://figg.visualstudio.com/_git/decisions.web.
[Info] Review> checkout failed #{"message":"Failed to execute git","stdout":"","stderr":"ssh: connect to host figg.visualstudio.com port 22: Network is unreachable\r\nfatal: Could not read from remote repository.\n\nPlease make sure you have the correct access rights\nand the repository exists.\n","exitCode":128,"gitErrorCode":"RemoteConnectionError","gitCommand":"fetch","gitArgs":["fetch","_git","bugs/5808-412-pre-conditioned-failed:pr/kasturi.sharma@meetingdecisions.com/3427","--depth=1"]}
[Info] Review> Queuing additional validate state
[Info] Review> Validating state...
[Info] Found GitHub remote
[Info] Review> no matching pull request metadata found for current branch tasks/4887-upgrade-froala
[Info] Warning: no result data for _git/Decisions.Web for search: {"sourceRefName":"tasks/4887-upgrade-froala"}
[Info] Review> no matching pull request metadata found on GitHub for current branch tasks/4887-upgrade-froala

Extension version: 0.0.5
VS Code version: Code - Insiders 1.53.0-insider (1a6eef3170be2a11751ee50d450328d458f7bfac, 2021-01-15T05:15:40.826Z)
OS version: Windows_NT x64 10.0.19042

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-8565U CPU @ 1.80GHz (8 x 1992)

GPU Status
2d_canvas: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onoop_rasterization: enabledopengl: enabled_onprotected_video_decode: enabledrasterization: enabledskia_renderer: enabled_onvideo_decode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabled

Load (avg)
undefined

Memory (System)
15.75GB (8.27GB free)

Process Argv
D:\repo\Decisions.Web\web.code-workspace --crash-reporter-id 690ad1b7-c84f-4e12-b9a4-ec7eef81099e

Screen Reader
no

VM
0%

Fixed. Released version 0.0.6. However you will need to update your vscode to 1.53.0-insider which got released earlier today.

Fixed. Released version 0.0.6. However you will need to update your vscode to 1.53.0-insider which got released earlier today.

Thanks again
works like a charm

Thanks again
works like a charm

authors: abdulkareemnalband ankitbko

repo: ankitbko/vscode-pull-request-azdo