text:
Remove legacy Popover code

Feature request type
Other
Component name
No response
Is your feature request related to a problem?
Obsolete code exists in various popover services
Describe the solution you'd like
https://github.com/search?q=repo%3AMudBlazor%2FMudBlazor popover obsolete&type=code
Have you seen this feature anywhere else?
No response
Describe alternatives you've considered
No response
Pull Request

[ ] I would like to do a Pull Request

Code of Conduct

[X] I agree to follow this project's Code of Conduct

cc @ScarletKuro

We probably will keep it for now, still not sure if IPopoverService is totally free from all the problems, so I would want to have that backup.

authors: ScarletKuro danielchalmers


text:
TemplateColumn not rendering when EditMode is Cell

Bug type
Component
Component name
TemplateColumn
What happened?
I've had trouble finding out why a TemplateColumn doesn't render when using EditMode=DataGridEditMode.Cell.
Here is an example
    <MudDataGrid @ref="@_dataGrid"
                 T="EffectParameter"
                 Items="@Effect.EffectParameters"
                 EditMode="@DataGridEditMode.Cell"
                 CanceledEditingItem="@OnCanceledEditingItemAsync"
                 CommittedItemChanges="@OnCommittedItemChangesAsync"
                 Bordered="true"
                 ReadOnly="false"
                 Dense="true"
                 EditTrigger="@DataGridEditTrigger.OnRowClick">
        <Columns>
            <TemplateColumn CellClass="d-flex justify-end">
                <CellTemplate>
                    <MudStack Row="true">
                        <MudIconButton Class="pa-2" Size="@Size.Small" Icon="@Icons.Material.Outlined.Cancel" />
                        <MudIconButton Class="pa-2" Size="@Size.Small" Icon="@Icons.Material.Outlined.Edit" />
                        <MudIconButton Class="pa-2" Size="@Size.Small" Icon="@Icons.Material.Outlined.Remove" />
                    </MudStack>
                </CellTemplate>
            </TemplateColumn>
        </Columns>
    </MudDataGrid>

But it does not render the HTML output as follows.
image
Why does the TemplateColoumn disappear when using the EditMode is Cell?
How could I mitigate this, is there a workaround?
Issue from: https://github.com/MudBlazor/MudBlazor/discussions/6568
Expected behavior
Render template column
Reproduction link
https://try.mudblazor.com/snippet/wEmHaAECnUKNlthp
Reproduction steps
Add TemplateColumn when EditMode is Cell.
Relevant log output
No response
Version (bug)
6.19.1
Version (working)
No response
What browsers are you seeing the problem on?
Firefox, Chrome, Edge
On which operating systems are you experiencing the issue?
Windows
Pull Request

[ ] I would like to do a Pull Request

Code of Conduct

[x] I agree to follow this project's Code of Conduct

Hi.
I'm not datagrid expert, but as far as I know this is by design since Cell mode is an edit mode as the CellTemplate is not used in this mode. @tjscience
But if want to show something in this mode, then instead of the CellTemplate you need to use EditTemplate.
https://try.mudblazor.com/snippet/wOceEoQUKjCSNIrW

Closing since an solution was provided.

source: gharchive/issue

repo: MudBlazor/MudBlazor

license: MIT

license_type: permissive

license_source: github-api


text:
Snackbar Aligment

Description
There is an aligment text issue if the text is too long.
Motivation and Context
Fix the text alignment issue.
How Has This Been Tested?
Below is the result. Before and After.

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Improvement/refactoring (non-breaking change that doesn't add any features but makes things better)

Checklist:

[x] The PR title is no longer than 64 characters.
[x] The PR is submitted to the correct branch (dev).
[x] My code follows the code style of this project.
[ ] I've added relevant changes to the documentation (applies to new features and breaking changes in library)

@henon Hello. Could it be reviewed please? Could it be part of the next version? This is a minor change. But it improves the display of information for the snackbar.

@Garderoben Thank you

source: gharchive/pull-request


text:
[Bug]: Non-op players cannot use /mv tp despite having enforceaccess: 'false'

/mv version -p output
https://j.mp/3ekjRqf
Server logs
https://paste.gg/p/anonymous/5d40eb0ead9b44d184111eb624393bc2
Server Version
This server is running Paper version git-Paper-101 (MC: 1.18.1) (Implementing API version 1.18.1-R0.1-SNAPSHOT) (Git: 464b171)
You are running the latest version
Previous version: git-Paper-99 (MC: 1.18.1)

Bug Description
Non-op players cannot use /mv tp despite having enforceaccess: 'false'. Not sure what to add there. I've tried using it on true, with luckperms to allow default access, yet it still refused to acknowledge the permissions. I don't think it's because I'm using it on an aternos server because all the other plugins work fine.
All the issues I've found about this are either not working or closed for being idle.
Steps to reproduce
1.Start a 1.18 aternos server with multiverse-core and multiverse-inventory
2.Create a world BuildWorld alias BW, creative only with separate inventory
3.Try to tp to BW without op
4.Add Luckperms and setup default perms to have access to any world
5.Switch enforceaccess to true
6.Retry step 3
Agreements

[X] I have searched for and ensured there isn't already an open or resolved issue(s) regarding this.
[ ] I was able to reproduce my issue on a freshly setup and up-to-date server with the latest version of Multiverse plugins with no other plugins and with no kinds of other server or client mods.

I forgot to add: the only few other plugins I have are to skip the night with only one player sleeping, itemedit, skinrestorer, villagertradelimiter, silkyspawners and nottooexpensive.

enforceaccess does affect player ability to use mvtp command. The permissions needed is explained here: https://github.com/Multiverse/Multiverse-Core/wiki/Command-Reference#teleport-command

repo: Multiverse/Multiverse-Core


text:
Fix :string limits

Delivers Pivotal #147238161

Increase Name :string field limits

Bump up Name#author limit to accommodate Imperator Authors
Increase other limits to accommodate largest possible Scientific Name and Author
Validate Name :string fields based on character size (instead of bytesize)

Validate and truncate :string fields in other tables based on character size (instead of bytesize); update tests accordingly.

Remove now-uncalled bytesize StringExtension methods

[Delivers #147238161]

Thanks for taking care of this, Joe!
On Fri, Jun 16, 2017 at 2:29 PM, Joseph D. Cohen notifications@github.com
wrote:

Delivers Pivotal #147238161
https://www.pivotaltracker.com/story/show/147238161

Increase Name :string field limits

Bump up Name#author limit to accommodate Imperator Authors

Increase other limits to accommodate largest possible Scientific
Name and Author
Validate Name :string fields based on character size (instead of
bytesize)

Validate and truncate :string fields in other tables based on
character size (instead of bytesize); update tests accordingly.
Remove now-uncalled bytesize StringExtension methods
[Delivers #147238161]
You can view, comment on, or merge this pull request online at:
https://github.com/MushroomObserver/mushroom-observer/pull/323
Commit Summary

Raise limit on Name author size
Fix bug in Name field validators
Validate and truncate :string's based on characters
Remove StringExtensions#truncate_bytesize
Improve Name validation error messages
Fix issues re changing validation from bytes to chars

File Changes

M app/controllers/account_controller.rb
https://github.com/MushroomObserver/mushroom-observer/pull/323/files#diff-0
(2)
M app/extensions/string_extensions.rb
https://github.com/MushroomObserver/mushroom-observer/pull/323/files#diff-1
(26)
M app/models/comment.rb
https://github.com/MushroomObserver/mushroom-observer/pull/323/files#diff-2
(4)
M app/models/image.rb
https://github.com/MushroomObserver/mushroom-observer/pull/323/files#diff-3
(10)
M app/models/interest.rb
https://github.com/MushroomObserver/mushroom-observer/pull/323/files#diff-4
(2)
M app/models/location.rb
https://github.com/MushroomObserver/mushroom-observer/pull/323/files#diff-5
(2)
M app/models/name.rb
https://github.com/MushroomObserver/mushroom-observer/pull/323/files#diff-6
(76)
M app/models/observation.rb
https://github.com/MushroomObserver/mushroom-observer/pull/323/files#diff-7
(2)
M app/models/project.rb
https://github.com/MushroomObserver/mushroom-observer/pull/323/files#diff-8
(2)
M app/models/species_list.rb
https://github.com/MushroomObserver/mushroom-observer/pull/323/files#diff-9
(4)
M app/models/user.rb
https://github.com/MushroomObserver/mushroom-observer/pull/323/files#diff-10
(8)
M config/locales/en.txt
https://github.com/MushroomObserver/mushroom-observer/pull/323/files#diff-11
(13)
A db/migrate/20170615205453_increase_name_author_limit.rb
https://github.com/MushroomObserver/mushroom-observer/pull/323/files#diff-12
(27)
M db/schema.rb
https://github.com/MushroomObserver/mushroom-observer/pull/323/files#diff-13
(18)
M test/controllers/name_controller_test.rb
https://github.com/MushroomObserver/mushroom-observer/pull/323/files#diff-14
(18)
M test/models/image_test.rb
https://github.com/MushroomObserver/mushroom-observer/pull/323/files#diff-15
(4)
M test/models/string_extensions_test.rb
https://github.com/MushroomObserver/mushroom-observer/pull/323/files#diff-16
(32)
M test/models/user_test.rb
https://github.com/MushroomObserver/mushroom-observer/pull/323/files#diff-17
(21)

Patch Links:

https://github.com/MushroomObserver/mushroom-observer/pull/323.patch
https://github.com/MushroomObserver/mushroom-observer/pull/323.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/MushroomObserver/mushroom-observer/pull/323, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ADE2tWyyI5QJCbrSMJSBBsz1c6VKoEMHks5sEsmZgaJpZM4N8yXv
.

Coverage decreased (-0.0004%) to 93.323% when pulling cd4ea5928645b754603e2f1397bda05206df7f3d on JoeCohen:string-limits into 4417ba7a81800771391bea0494174bb3408d41c9 on MushroomObserver:master.

Coverage decreased (-0.0004%) to 93.323% when pulling 825a41d4c01ef1112f6ef5f65a1cd5bb22d861da on JoeCohen:string-limits into 4417ba7a81800771391bea0494174bb3408d41c9 on MushroomObserver:master.

codeclimate report
Please ignore it.  This PR page says "1 new issue (5 fixed)", but details say: w"Passed No new issues were found." https://codeclimate.com/repos/58cfc16d1035280287001d93/pull/323  (I think the difference is one issue I marked WONTFIX because it was preexisting, time-consuming, and not the concert of this PR.)

coverage/coveralls report
Please ignore it. There are no newly uncovered lines. The decrease in the Coveralls percentage grade is minute. (I think it's due to the removal of tests which covered methods removed in this PR.)

I removed all but one use of bytesize.  The remaining one is at line 10 in https://github.com/MushroomObserver/mushroom-observer/blob/master/app/classes/api/parse_string.rb. I left it there because I wasn't sure if it could be removed.

Coverage decreased (-0.2%) to 93.105% when pulling 2f16aee9f8303bfb100c9195aba85a77e60fef3f on JoeCohen:string-limits into 4417ba7a81800771391bea0494174bb3408d41c9 on MushroomObserver:master.

Yes, you can remove that, change that to a normal char length.  Its purpose
there is to give the api clients appropriate error message if they are
trying to set a string in the db too long.  Ideally all the set_xxx
parameters should be declared with appropriate limits based on the db
limits.  I don't think any of the set_xxx parameters are tested outside of
what's needed to post an observation, and there are no limited strings
there (I think).
On Fri, Jun 16, 2017 at 4:45 PM, Joseph D. Cohen notifications@github.com
wrote:

I removed all but one use of bytesize. The remaining one is at line 10 in
https://github.com/MushroomObserver/mushroom-observer/blob/master/app/
classes/api/parse_string.rb. I left it there because I wasn't sure if it
could be removed.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/MushroomObserver/mushroom-observer/pull/323#issuecomment-309130046,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADE2tflvetyM97gpHZTrVeETXl6vmBVuks5sEul-gaJpZM4N8yXv
.

Oops! Forgot to Rake.  Will re-open when ready.

Thanks.  Will do.
On Fri, Jun 16, 2017 at 2:10 PM Jason Hollinger notifications@github.com
wrote:

Yes, you can remove that, change that to a normal char length. Its purpose
there is to give the api clients appropriate error message if they are
trying to set a string in the db too long. Ideally all the set_xxx
parameters should be declared with appropriate limits based on the db
limits. I don't think any of the set_xxx parameters are tested outside of
what's needed to post an observation, and there are no limited strings
there (I think).
On Fri, Jun 16, 2017 at 4:45 PM, Joseph D. Cohen <notifications@github.com

wrote:

I removed all but one use of bytesize. The remaining one is at line 10 in
https://github.com/MushroomObserver/mushroom-observer/blob/master/app/
classes/api/parse_string.rb. I left it there because I wasn't sure if it
could be removed.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<
https://github.com/MushroomObserver/mushroom-observer/pull/323#issuecomment-309130046
,
or mute the thread
<
https://github.com/notifications/unsubscribe-auth/ADE2tflvetyM97gpHZTrVeETXl6vmBVuks5sEul-gaJpZM4N8yXv
.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/MushroomObserver/mushroom-observer/pull/323#issuecomment-309132680,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AACxlLQt6fyhMQGNXhtDvF0GGUiBmakMks5sEuyIgaJpZM4N8yXv
.

I think it's fixed. (But there seems to be >= 5 minutes delay between (a) when I push commits to my personal GitHub repo and (b) when those commits show up in the MO repo.)

Coverage increased (+0.002%) to 93.326% when pulling a6c219bae28e442d6261994b526de7cd4a33f28f on JoeCohen:string-limits into 4417ba7a81800771391bea0494174bb3408d41c9 on MushroomObserver:master.

Coverage increased (+0.002%) to 93.326% when pulling a6c219bae28e442d6261994b526de7cd4a33f28f on JoeCohen:string-limits into 4417ba7a81800771391bea0494174bb3408d41c9 on MushroomObserver:master.

No, it is plain text here.  It gets hashed automagically by rails in a
before_save hook, I think.
On Fri, Jun 16, 2017 at 6:35 PM, Joseph D. Cohen notifications@github.com
wrote:

@JoeCohen commented on this pull request.
In app/controllers/account_controller.rb
https://github.com/MushroomObserver/mushroom-observer/pull/323#discussion_r122545933
:

@@ -160,7 +160,7 @@ def verify # :nologin:
elsif password != confirmation
@user.errors.add(:password_confirmation,
:validate_user_password_no_match.t)

     elsif password.length < 5 || password.bytesize > 40

     elsif password.length < 5 || password.size > 40

At this point is password the real password or the hash?
If it's the hash then can we validate its size here? Also see same issue
in User.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/MushroomObserver/mushroom-observer/pull/323#pullrequestreview-44677342,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADE2tdss3ZHtfy_7jd1-Sp0oAleDt6yQks5sEwMcgaJpZM4N8yXv
.

Yup. I should have figured that out.  (it's before_create :crypt_password.)
I'm done with this branch unless someone has suggestions.

Great, thanks again, Joe.  I'll take a look later tonight maybe.
On Fri, Jun 16, 2017 at 8:37 PM, Joseph D. Cohen notifications@github.com
wrote:

Yup. I should have figured that out. (it's before_create :crypt_password.)
I'm done with this branch unless someone has suggestions.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/MushroomObserver/mushroom-observer/pull/323#issuecomment-309174258,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADE2tZi23vXABnPAWoODvAS5h_rLulYaks5sEx-1gaJpZM4N8yXv
.

Thank you Jason. I'll try to get started on creating more work for you; no good deed goes unpunished.

Please give me a few minutes to  fix display_name_limit and the migration.

Will probably take more than a few minutes -- I have to do some branch switching, cleaning, migrating, fixing, etc.
So I will close this, and re-open when it's fixed.

Corrected display_name_limit.

Coverage increased (+0.02%) to 93.326% when pulling 5d8da3423c8d94a495f1815916c6e6341510f45a on JoeCohen:string-limits into 15f751d3b42bad03b4e915179abcb402b7d641c6 on MushroomObserver:master.

Coverage increased (+0.02%) to 93.326% when pulling 5d8da3423c8d94a495f1815916c6e6341510f45a on JoeCohen:string-limits into 15f751d3b42bad03b4e915179abcb402b7d641c6 on MushroomObserver:master.

Thanks, Joe.  Yeah, I thought that might be the reason.  My thought, in
that case, was "what are the odds we will have to do this again when an
even longer author comes around?"  Of course, bumping up the size again
with another very short PR will be trivial, so maybe "who cares?"
On Sat, Jun 24, 2017 at 4:16 PM, Coveralls notifications@github.com wrote:

[image: Coverage Status] https://:/builds/12118589
Coverage increased (+0.02%) to 93.326% when pulling 5d8da34
https://github.com/MushroomObserver/mushroom-observer/commit/5d8da3423c8d94a495f1815916c6e6341510f45a
on JoeCohen:string-limits into 15f751d
https://github.com/MushroomObserver/mushroom-observer/commit/15f751d3b42bad03b4e915179abcb402b7d641c6
on MushroomObserver:master.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/MushroomObserver/mushroom-observer/pull/323#issuecomment-310863274,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADE2tZKHJcVBaWfDqhAh-wk3I7zXiOdAks5sHW6kgaJpZM4N8yXv
.

My guess is it's not likely to happen again soon. (But P it will happen sometime => 100%.)
Should we just forget about this PR?
What effect will it have on disk storage? (I don't understand whether MySQL automatically consumes the :limit for each column for each record, or whether it uses only the space it needs for the actual field data.) We have close to 60,000 Names.
What about search speed?

I think you misunderstand.  I was wondering if we shouldn't just bump it up
way bigger, and have done with it.  I am definitely in favor of this PR!
As for performance, space, etc... Who knows?  I suppose you could do some
benchmarks before and after to at least quantify any hit to either.  But
I'm having a hard time being very concerned about it.  Don't do it on my
account.
On Sat, Jun 24, 2017 at 11:32 PM, Joseph D. Cohen notifications@github.com
wrote:

My guess is it's not likely to happen again soon. (But P it will happen
sometime => 100%.)
Should we just forget about this PR?
What effect will it have on disk storage? (I don't understand whether
MySQL automatically consumes the :limit for each column for each record, or
whether it uses only the space it needs for the actual field data.) We have
close to 60,000 Names.
What about search speed?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/MushroomObserver/mushroom-observer/pull/323#issuecomment-310880002,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADE2tUda6v8l0fnMKOsnh93cvTpzAgnoks5sHdThgaJpZM4N8yXv
.

I'll think about it overnight.

I am now inclined to:

leave the Authorlimit as it was (100);
give a flash error suggesting use of "et al." when a user inputs an author longer than the limit (or when search_name, display_name, and sort_name would be too long);
keep other improvements of this branch (e.g., size instead of bytesize).

This goes back to something @pellaea said (in an email?) about using "& al." and ICN Recommendation 46C.2 (which I somehow overlooked until now):

46C.2. After a name published jointly by more than two authors, the citation should be restricted to the first author followed by “et al.” or “& al.”, except in the original publication.

46C.Ex.2. Lapeirousia erythrantha var. welwitschii (Baker) Geerinck, Lisowski, Malaisse & Symoens (in Bull. Soc. Roy. Bot. Belgique 105: 336. 1972) should be cited as L. erythrantha var. welwitschii (Baker) Geerinck & al.

Yes!  I didn't know about the ICN recommendation, but I'm totally behind
using "et al." for these ridiculous molecular-defined genera!
Good idea, Joe.
On Sun, Jun 25, 2017 at 9:09 AM, Joseph D. Cohen notifications@github.com
wrote:

I am now inclined to:

leave the Authorlimit as it was (100);
give a flash error suggesting use of "et al." when a user inputs an
author longer than the limit (or when search_name, display_name, and
sort_name would be too long);
keep other improvements of this branch (e.g., size instead of
bytesize).

This goes back to something @pellaea https://github.com/pellaea said
(in an email?) about using "& al." and ICN Recommendation 46C.2
http://www.iapt-taxon.org/nomen/main.php?page=art46 (which I somehow
overlooked until now):
46C.2. After a name published jointly by more than two authors, the
citation should be restricted to the first author followed by “et al.” or
“& al.”, except in the original publication.
46C.Ex.2. Lapeirousia erythrantha var. welwitschii (Baker) Geerinck,
Lisowski, Malaisse & Symoens (in Bull. Soc. Roy. Bot. Belgique 105: 336.
1972) should be cited as L. erythrantha var. welwitschii (Baker)
Geerinck & al.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/MushroomObserver/mushroom-observer/pull/323#issuecomment-310901766,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADE2tV4Qs78D3_tksPOw4TK7UcNngMTtks5sHlwBgaJpZM4N8yXv
.

Okay!  I will close this PR, modify the branch, and then make a new PR.

Leave author limit at 100, adjust other limits

Leave author as it was before this PR
Adjust search_name, sort_name, and display_limits to their theoretical maxima, given author and text_name limits.

Revise Name validation

Revise flash message for author too long -- suggest using first author plus "et al."
Remove validation of search_name, sort_name, and display_limits. These fields are always calculated by the app based on :text_name and :author; they are never supplied by the user or API. The :limits have been increased to the theoretical max, so length should never be exceeded. The old message no longer makes sense. If there's an error, it now gets treated like any other glitch which occurs when trying to save a Name.

Lots of RuboCopping
If this is too much to review, it's easy to revert.

Coverage increased (+0.02%) to 93.326% when pulling df0cab0fcc3af5064fe48f6ffb10bf2c7dc1b863 on JoeCohen:string-limits into 15f751d3b42bad03b4e915179abcb402b7d641c6 on MushroomObserver:master.

Connection to CodeClimate broken. I will seek help fixing this.
Once connection is restored, my RuboCopping will likely provoke new CodeClimate complaints. I will fix them, and post a GitHub Comment when this is ready to review.

Coverage increased (+0.02%) to 93.326% when pulling 5bd2ec609689adcfbf957eede24932d0d4270405 on JoeCohen:string-limits into 15f751d3b42bad03b4e915179abcb402b7d641c6 on MushroomObserver:master.

Coverage increased (+0.02%) to 93.326% when pulling 2b20343a3d89ccf5939b14c13f394e20be35f22c on JoeCohen:string-limits into 15f751d3b42bad03b4e915179abcb402b7d641c6 on MushroomObserver:master.

Coverage increased (+0.03%) to 93.331% when pulling 19eec9a2467664525fac35f4ff8c5184e8f66b7f on JoeCohen:string-limits into 15f751d3b42bad03b4e915179abcb402b7d641c6 on MushroomObserver:master.

Coverage increased (+0.03%) to 93.331% when pulling eb8aa9abaa34d942543c649bb75d3ccf9efb408b on JoeCohen:string-limits into 15f751d3b42bad03b4e915179abcb402b7d641c6 on MushroomObserver:master.

authors: JoeCohen coveralls pellaea

repo: MushroomObserver/mushroom-observer


text:
[BUG]- Footer section

Under career building section there is an unecessary line which on clicking give 404 error page,
removal of it makes it good
Please assign me this issue under GSSOC
@Muskansahuincredible

just dont remove it all.. if u make some changes on it then i will assign

Hello @Muskansahuincredible

I want to add more styling in footer . There is a unnecessary line in career building section , if you want to remove or some changes in it ,  i will do.  And I want to add vertical line for every section of footer in left side for better UI.
Please assign me this issue under GSSOC.

@suma30 assigned work on it

@suma30 how will u do that just explain or i will assign someone else..

Hey @Muskansahuincredible I will remove a div which contains unnecessary line in career building section. And there is also problem with responsiveness.

There is no symmetry in footer sections on mobile screen. i will make sure only one section display  on mobile screen and in middle , for that i will use grid/flex properties .

@Muskansahuincredible Hey, I will remove the extra unnecessary line under career building section and also check the responsiveness of the footer section, please assign me the issue

hi @SyedImtiyaz-1
please assign this issue to me under GSSOC24


text:
需要少女粉主题

哈哈哈

这个黑色模式,颜色不够深啊,应该更黑才好,现在有点白灰

这个黑色模式,颜色不够深啊,应该更黑才好,现在有点白灰

是的。微信下面是白晃晃的QQ界面，有一瞬间我还以为微信这个 dark mode 是有点透明的。。。

authors: houyukun joescon

repo: MustangYM/WeChatExtension-ForMac


text:
Feature: Provide options to override some default Foundry token behaviour on an Actor type basis

So people can set reasonable defaults for Players and NPCs separately.

Not sure we want to do this anymore.

repo: Muttley/foundryvtt-shadowdark


text:
Disable Digital Bitbox

Digital Bitbox's firmware has a check agains https://myetherwallet.com hard-coded into it. I was not able to work out a solution with them in time, and so it doesn't work on MyCrypto right now. In the mean time, we should let users know this.

FWIW I have reached out to the Digital Bitbox team to try to resolve this. Should hopefully hear back from them soon.


text:
writing $med med arrow med med$ make the server crash

Describe the bug
I made a function in which I used $med med arrow med med$ that is the part of code why the server crashes, you can put anywhere not only in a function to trigger this crash. If you replace arrow with eta for example, the crash is not triggered.
Package/Software version:
VSCode version(Help -> About):
Version: 1.95.3
Commit: f1a4fb101478ce6ec82fe9627c43efbf9e98c813
Date: 2024-11-13T14:45:08.000Z
Electron: 31.7.5
ElectronBuildId: Electron for openSUSE
Chromium: 126.0.6478.234
Node.js: 20.18.0
V8: 12.6.228.30-electron.0
OS: Linux x64 6.11.8-1-default```

tinymist extension version: `v0.12.2`. Get it by `tinymist --version` in terminal.
I installed the vscode extension and I don't have the command tinymist available.
```plain
tinymist
Build Timestamp:
Build Git Describe:
Commit SHA:
Commit Date:
Commit Branch:
Cargo Target Triple:
Typst Version:       typst 0.11.0 (e0d80968)

Logs:
tinymist server log(Output Panel -> tinymist):
[2024-11-21T08:50:52Z INFO  tinymist::actor::editor] received status request(primary) Compiling
thread '<unnamed>' panicked at /home/runner/.cargo/git/checkouts/typst-15b90983aa0184a9/58426a9/crates/typst/src/layout/inline/shaping.rs:605:45:
byte index 14 is not a char boundary; it is inside '\u{2069}' (bytes 12..15) of `· Q￼  Litri/secondo
 · ￼￼  mmHg
`
stack backtrace:
[2024-11-21T08:50:52Z INFO  sync_lsp] handling textDocument/documentColor - (4) at Instant { tv_sec: 264, tv_nsec: 389969582 }
[2024-11-21T08:50:52Z INFO  tinymist_query::analysis::global] analysis revision 9 is created
[2024-11-21T08:50:52Z INFO  sync_lsp] handled  textDocument/documentColor - (4) in 438.13µs
   0: rust_begin_unwind
   1: core::panicking::panic_fmt
   2: core::str::slice_error_fail_rt
   3: core::str::slice_error_fail
   4: typst::layout::inline::prepare::prepare
   5: typst::layout::inline::layout_inline
   6: typst::layout::flow::layout_flow
   7: typst::layout::pages::run::layout_page_run_impl
   8: typst::layout::pages::run::layout_page_run
   9: rayon::iter::plumbing::bridge_producer_consumer::helper
  10: rayon_core::join::join_context::{{closure}}
  11: rayon::iter::plumbing::bridge_producer_consumer::helper
  12: <rayon_core::job::StackJob<L,F,R> as rayon_core::job::Job>::execute
  13: rayon_core::registry::WorkerThread::wait_until_cold
  14: rayon_core::registry::ThreadBuilder::run
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.
[Error - 09:50:52] Server process exited with signal SIGABRT.
[Info  - 09:50:52] Connection to server got closed. Server will restart.
true

Additional context

hi, could you please put the whold document here if possible? from the log, it looks like the panic  is not directly related to the math equation you mentioned here.

#import "style.typ": apply_style
#import "custom_functions.typ": def

#let title = align(center)[
  #text(
    "Formulario di Dispositivi itps",
    30pt)

]

#let def(formula, unit) = {
  //set text(rgb("#000000"), 1em, weight: "bold")
  text(strong("· "), 1.4em, weight: "bold") + formula + $med med arrow med med$

  show text: set text(blue)
  show math.equation: set text(blue)
  unit + "\n"
}

#title
#apply_style[
#outline(indent: true)
#pagebreak()

= Valvole cardiache
== Effective Orifice Area (EOA)
  $
  "EOA" = 10^4/516 (Q) / (sqrt(Delta p))  arrow "cm"^2
  $
  #def[Q][Litri/secondo]
  #def[$Delta p$][mmHg]

== Discharge Coefficient (DC)
  $
  "DC" = "EOA"/A_"int" arrow ["adim."]
  $
  #param[EOA][$"cm"^2$]
  #param[$A_"interna"$][$"cm"^2$]

== Performance Index (PI)

  $
  "PI" = "EOA" / A_"est" arrow ["adim."]
  $

  #param[EOA][$"cm"^2$]
  #param[$A_"esterna"$][$"cm"^2$]

#pagebreak()
== Reverse Flow (RF%)
  $
  "RF%" = V_"rigurgitato" / V_"eiettato" dot 100
  $
  \
  - $V_"rigurgitato" -- #block[È l'area negativa del grafico Portata-Tempo nel ventricolo sinistro.(Left-Ventricle)]$ \ \
  - $V_"eiettato" -- #block[È l'area positiva del grafico Portata-Tempo nel ventricolo sinistro (Left-Ventricle).]$

  == Numero di Reynolds (Re)

  $
  "Re" = (rho dot v dot d) / mu
  $

  - $rho$ : densità sangue 1 $g/"cm"^3$

  - v: velocità del sangue $"cm"/s$

  - d: diametro del condotto $"cm"$

  - $mu$ : viscosità dinamica del sangue 0.03Poise = 0.03 $(g dot "cm") / s$
  \
  #strong("Nota:") Interpretazione del numero di Reynold

  - Re < 2000 #h(2cm) $arrow$  flusso laminare
  - 2000 < Re < 4000 #h(.45cm)$arrow$  Regime di transizione
  - Re > 4000 #h(2cm) $arrow$ Regime turbolento
]

oh actually it is not everywhere but only if it is in the style function

❯ typst compile test.typ
thread '<unnamed>' panicked at crates/typst/src/layout/inline/shaping.rs:605:45:
byte index 14 is not a char boundary; it is inside '\u{2069}' (bytes 12..15) of `· Q￼  Litri/secondo
 · ￼￼  mmHg
`
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

It is an upstream bug, unfortunately. Compiling your document with typst-cli also triggers crash.

#let def(formula, unit) = {
  formula + $med med arrow med med$
  unit + "\n"
}
#def[$a$][]

Minimal example

authors: AliothCancer Enter-tainer

repo: Myriad-Dreamin/tinymist


text:
Add dark theme

I'd love if there was a dark theme. Could you add one at default-dark.css? I'm configuring my page to load a stylesheet from that URL. I really would like having a dark theme, so please implement it.

@MystPi Could you please?

You can implement it yourself; it's not very hard. First. go to https://dreamcss.cf and scroll to the themes section. In the Make your own theme! subsection, click the link with the text download and customize the CSS variables to your liking. Done!
After that you can make a PR to add your theme to the theme library.

You can implement it yourself; it's not very hard. First go to https://dreamcss.cf and scroll to the themes section. In the Make your own theme! subsection, click the link with the text download and customize the CSS variables to your liking. Done!
After that you can make a PR to add your theme to the theme library.

I'll try using the Chrome OS system stylesheet.

repo: MystPi/dreamcss


text:
Tool for fetching objects directly from validators

Adds the sui-tool binary, which is intended for sui debugging stuff.
The main use case right now is making all AuthorityAPI methods accessible on the command line. For now, only handle_object_info_request is supported.

@oxade lmk if you want to merge this with the db tool. It may make sense to keep them separate though.

repo: MystenLabs/sui


text:
Use type system to indicate signatures have been verified

The goal of this PR is to safely support optimizations that reduce unnecessary signature verifications. For instance, before this PR, we would verify signatures after loading a cert from the DB, even though that cert was almost certainly verified before it was written to the db. This change makes it much easier to trust that nothing unverified gets in to the db.
The overall design is:

VerifiedTransactionEnvelope is added as a wrapper around TransactionEnvelope.

normally VerifiedTransactionEnvelope is only created by fn verify(self) methods.
there are a few exceptions which require a new_unchecked method - these can be carefully audited.

The network APIs are unchanged, to indicate that everything arriving via the network must be verified.
AuthorityState accepts only VerifiedCertificate, VerifiedTransaction, etc.
Databases store VerifiedTransactionEnvelope, meaning that you cannot write unverified data to the db, and you don't need to verify signatures after reading from the db.

This is a huge PR, obviously. I recommend focusing the review in sui-core, especially:

messages.rs
authority.rs
safe_client.rs
authority_aggregator.rs

Cool! Now I really wish we had merged https://github.com/MystenLabs/sui/pull/4142 and https://github.com/MystenLabs/sui/pull/4155

authors: lxfind mystenmark


text:
🛑 POST to DRM is down

In 5491898, POST to DRM (https://mysteryexe.xyz/drm.php?) was down:

HTTP code: 403
Response time: 409 ms

Resolved: POST to DRM is back up in a1f03e4 after 9 minutes.

repo: Mysteryexe/uptime-checker


text:
Fix: Scroll on homepage

Hey guys 👋
I saw your invitation on the hacktoberfest discord channel and I think the project looks awesome!
Looking through the code base, and understanding the human interaction on the front end I thought I could create my first issue. It appears that there is a scrollbar present on the homepage which creates an overflow of the username and logout icon.
https://github.com/N-45div/Resilient-Response/assets/28037374/6589d487-a23c-4688-85a6-1cec4a09c827

Great work @MorkWood2...keep on the work and share this repo to more devs

I wanna work on this issue please assign it to me. It has been idle for a while.


text:
Rename distance_matrix to (travel_)duration_matrix

Hadn't really given this much thought, but everything's of course in time units, so we shouldn't talk about a "distance matrix" so much. We need to update a few places in the code to reflect this.

I haven’t seen this before in any of the existing VRPLIB instances though.

That makes sense to me. The typical VRPLIB instances are quite stylised, so I'd expect this kind of stuff not to be present. On our end, there's nothing stopping us from writing a ProblemData class that can accept two matrices (cost + time), and another 'shortcut' constructor that simply copies one into the other, when only one has been provided.

I don't think there is a VRPLIB instance having both distance and time, and if it supports two matrices I don't think its unambiguous. Also note there is distance, time and (in theory) costs, which may be a combination of distance and time or even completely something else (general support of objectives is another topic anyway). You can replace distance by cost except if you want to support constraints like maximum route distance. Anyway, I don't think we should let our support depend on the VRPLIB format.
For now we can either choose to just support duration, or do both, indeed by default being equal. However we should make sure having two matrices does not affect performance?

authors: N-Wouda wouterkool

repo: N-Wouda/pyvrp


text:
Firefox cannot set src attribute

Example sceneraio:
/ working code
img data-src="holder.js/60x60"

/ not working/buggy code
= holder_tag '60x60'

In not working code part, Firefox produce below code (in here src is empty),

What version of Firefox are you using? Works for me in FF33 Mac.
Anyway that seems an issue with holder.js
Please open the issue at https://github.com/imsky/holder

I have the same problem in Firefox 44.0.2 on OS X 10.11.2. It works in Google Chrome.
It seems it occurs because the src attribute on the image i set.
Example
This doesn't work:

This works:

You can argue that this is a holder.js issue - though it's easy fixed, by not setting the src attribute.
Any change you could remove this in the holderjs_tag function?

Any reason this issue has never been resolved? Seems odd to leave an empty src field within the tag, especially knowing it's causing issues. I was testing first with Firefox since I use Firebug a lot, and thought I wasn't getting the gem to work correctly, and then came across this, tried in Safari, and it works fine, just not in Firefox.

Hello!
solution
  $('.holdertag').removeAttr('src');
  Holder.run();

https://github.com/imsky/holder/issues/91

authors: NARKOZ altun blimey85 mibamur mortenjakobsen

license_source: bigquery


text:
Partial resolution for NASA-PDS/roundup-action#47

📜 Summary
Merge this if you dare to resolve the Python part of NASA-PDS/roundup-action#47, which adds GitHub Actions caching for downloaded Maven dependencies (jar files and other artifacts).
🩺 Test Data and/or Report
Gonna sound like a broken record here: There's really no way to test this without a massive test harness (which would include—amongst many other things—the GitHub Actions ecosystem, actions runners, virtual machines, public key infrastructure, image registries, OSSRH stub, PyPI stub, robots.txt to prevent dev sites crawling, warning banners, etc.).
🧩 Related Issues

NASA-PDS/roundup-action#47

Merging the heck out of this, thanks @MJJoyce 🙏

repo: NASA-PDS/pds-template-repo-python


text:
Single wrapper use cases for EnsembleStat, TCPairs, SeriesByInit, SeriesByLead

Subtask of issue #231
Single wrapper use cases for EnsembleStat, TCPairs, SeriesByInit, SeriesByLead

The Use Cases have been completed and tested.
THE ONLY REMAINING Task is to update the RST documentation for these
single wrapper use case files:
TCPairs.py EnsembleStat.py, SeriesByInit.py and SeriesByLead.py

repo: NCAR/METplus


text:
Post-processing fails for runs with sub-hourly output

Describe the Problem
The GeoJson converter fails to convert all GRIB output to GeoJson because the UPP class generates the wrong GRIB file name for runs with sub-hourly output.
Expected Behavior
For example, with 30 minute output, the converter will look for /data/test_run/upp/fhr_001/WRFPRS.GrbF01 instead of /data/test_run/upp/fhr_001/WRFPRS.GrbF00.30
Environment
ParallelCluster (wrfcloud-cluster)
To Reproduce
Submit a run with 30m or 15m output frequency.

Fix was merged into Auto Install branch (PR #114)

authors: fossell hahnd

repo: NCAR/wrfcloud


text:
Optimize RoboCORD

There are two main things that need to be done here:

In my current quick-and-dirty setup, RoboCORD loads all JSON files that it needs to use into memory. This should be replaced by a lazy system so that the file isn't actually read and parsed until it is needed.
We use a pretty simple Scala parallel collection system to process documents in parallel. This seems to work well enough for now, with jobs usually taking <15m to process 105 articles each, but eventually we might want to replace this with something fancier.

In my current quick-and-dirty setup, RoboCORD loads all JSON files that it needs to use into memory. This should be replaced by a lazy system so that the file isn't actually read and parsed until it is needed.

Streams!

authors: balhoff gaurav

repo: NCATS-Gamma/omnicorp


text:
Sameer

Changing the directory structure by putting data in the data directory

Not merging it

authors: kanekalla sameerd

repo: NCBI-Hackathons/RetroCancer


text:
🛑 test (NDLA) is down

In d0f42d9, test (NDLA) ($SECRET_TESTNDLANO) was down:

HTTP code: 503
Response time: 274 ms

Resolved: test (NDLA) is back up in 21eee19 after 6 minutes.

repo: NDLANO/oppetid


text:
How can I alter classrooms structure?

Hi,
I would like to implement this algorithm for school-level timetable generator. I couldn't alter the classrooms from input data.  When I alter the input data and execute, then it got "Index out of bound" error. It would be nice if you could explain what should I do. Also, what are those keys meant in the classroom section in input data like "a", "k", "n", "r", "s"? Any help would be appreciated.

Hi,
For altering the classroom's input data (or any other input) you would need to modify the load_data method (https://github.com/NDresevic/timetable-generator/blob/master/utils.py#L8). From line number 59 is where the parsing for classrooms starts, so you should change that part to fit your model. For my model each classroom is identified by name and type, so you might also need to change that model (https://github.com/NDresevic/timetable-generator/blob/master/model.py#L19), not sure how your data looks like. Here is also where those keys appear the first time ("a", "k", "n", "r", "s"). This is adapted to finding a schedule for my university and each key represents a type of classroom. For example, some classrooms have computers, some are auditoriums, etc. Each classroom has its own type and each class can be held in only one type of classroom (it can be in any of the classrooms but from the defined type).
How does your input data for classrooms look like? I could change a bit the loading to make it more robust or something like that, although for reading the input requirements there will always need to be some hardcoding to fit different input models.
Let me know if you have more questions.

authors: NDresevic blockchain-expert

repo: NDresevic/timetable-generator


text:
[DESAFIO] Fizz Buzz

Título: FizzBuzz
Enunciado: Dado um número inteiro x (onde 1 <= x <= 10000), crie um método que retorne uma matriz n com x elementos onde:
O primeiro elemento é 1, e vai incrementando até o valor x. Porém, existem algumas regras.

Se o valor for múltiplo de 3, ao invés disso você deverá incluir "Fizz"
Se o valor for múltiplo de 5, ao invés disso deverá incluir "Buzz"
Se o valor for múltiplo de 3 e 5, ao invés disso deverá incluir "FizzBuzz""

Casos de teste:
x = 3, n = [ "1", "2", "Fizz" ]
x = 5, n = [ "1", "2", "Fizz", "4", "Buzz" ]
x = 15, n = [ "1", "2", "Fizz", "4", "Buzz", "Fizz", "7", "8", "Fizz", "Buzz", "11", "Fizz", "13", "14", "FizzBuzz" ]

Desafio integrado à branch main.

repo: NET-Devs-BR/desafios-string


text:
Generate DOIs for Datasets

[x] DataCite schema requirements
[ ] Assign DOIs for public datasets
[ ] DOI Versioning
[ ] Explore ways to link Datasets with projects/studies/samples

@okoepler @hujo91 @febach
Could you please provide us with details on how we can generate these from our end?? API?? Sandbox to test?

Currently, it is possible to assign DOIs for projects and studies:

Closing in favour of #511 and #512


text:
Acking a by-category stream, doesn' seem to work

Hey again, I will try to contribute by finding the error myself, but I can post it here in the mean time.
It seems that acking on a persistent subscription on a by-category stream is not working.
:ok = Spear.ack(JaaApiLive.EventStoreDbClient, sub, msg)
evaluates fine, but the event is sent over and over.
My guess is that it is somehow related to the event being a link as it is a projection stream.

ah another nice find! Thanks for trying out spear and finding all my embarrassing bugs :grin:
I suspect that this is just like the other problem: the link data that we would need to acknowledge events is probably currently discarded. In this case instead of the .metadata.stream_revision field on a link, I think we need the .id. The event_store.client.persistent_subscriptions.ReadReq.Ack message looks like this: it's pretty thin, just a list of event IDs to acknowledge as a batch. I suspect it needs these event IDs to line up with the ID of the link instead of the resolved event when acknowledging persistent subscriptions.
I'm sure that there's a way that isn't too messy to fix this in the current code-base but I think it's probably wiser for me to bite the bullet of the refactor in #36 (and some real testing in #35) before/during tackling this problem. Right now links are a bit of an after-thought and I'd like to change that.
The day is just getting started here in the CDT timezone, I'll have this fixed in a jiffy!

Ok so it looks like the .id hypothesis was correct. #38 added a new :link field to t:Spear.Event.t/0 which Spear.ack/3 and Spear.nack/4 now respect and use to source each event's ID. I didn't add any test cases yet for projected streams but I set up a persistent subscription locally in my IEx and ack-ed my way through a category stream and it appears to be working like expected :+1:
v0.9.0 is a bit of a breaking change if you're depending on Spear.Event.metadata.link explicitly. Upgrading should be as easy as matching on the :link top-level field instead of that metadata field
# before
def revision(%Spear.Event{metadata: %{link: %{stream_revision: revision}}}), do: revision
def revision(%Spear.Event{metadata: %{stream_revision: revision}}), do: revision

# after
def revision(%Spear.Event{link: %Spear.Event{} = link}), do: revision(link)
def revision(%Spear.Event{metadata: %{stream_revision: revision}}), do: revision

Also if you're looking into using persistent subscriptions, be sure to check out Broadway. It's has a really nice Acknowledger behaviour that fits well with the persistent subscription ack/nack/park system. We recently built a producer for regular and persistent subscriptions. It's a bit experimental and surely has some bugs to iron out but it makes writing event-handling topologies really slick (here's an example handler).
Thanks again for reporting, glad to have you trying out the library! :slightly_smiling_face:

It is my pleasure! And thanks for being so responsive and fixing it.
I really liked the thorough explanation. I figured it had to be something regarding resolved id's but I became lost trying to figure out how to fix it :see_no_evil:

authors: askasp the-mikedavis

repo: NFIBrokerage/spear


text:
Update normal-login.ts

PR Checklist
Please check if your PR fulfills the following requirements:

[ ] The commit message follows our guidelines: https://github.com/NG-ZORRO/ng-zorro-antd/blob/master/CONTRIBUTING.md#commit
[ ] Tests for the changes have been added (for bug fixes / features)
[x] Docs have been added / updated (for bug fixes / features)

PR Type
What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Duplicate attribute class
What is the new behavior?
Removed duplicate attribute
Does this PR introduce a breaking change?
[ ] Yes
[x] No

Other information

Please update your commit message to meet the commit guideline.

repo: NG-ZORRO/ng-zorro-antd


text:
feat(module:date-picker): support standalone component

PR Checklist
Please check if your PR fulfills the following requirements:

[✔] The commit message follows our guidelines: https://github.com/NG-ZORRO/ng-zorro-antd/blob/master/CONTRIBUTING.md#commit
[ ] Tests for the changes have been added (for bug fixes / features)
[✔] Docs have been added / updated (for bug fixes / features)

PR Type
What kind of change does this PR introduce?

[ ] Bugfix
[✔] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?
What is the new behavior?
Updated Date picker component to work as a standalone component.
Does this PR introduce a breaking change?
[ ] Yes
[✔] No

Other information

Let's delete the BidiModule again :)
https://github.com/NG-ZORRO/ng-zorro-antd/issues/8229#issuecomment-1839810931

Let's delete the BidiModule again :)
#8229 (comment)

Sure, I will get back to you as soon as I can :)

Let's delete the BidiModule again :)
#8229 (comment)

Changes have been made


text:
feat(module:notification): popup order adjustment

PR Checklist
Please check if your PR fulfills the following requirements:

[✅] The commit message follows our guidelines: https://github.com/NG-ZORRO/ng-zorro-antd/blob/master/CONTRIBUTING.md#commit
[✅] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

PR Type
What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
[ ] Yes
[ ] No

Other information

@OriginRing LGTM too, 关注下 codecov 覆盖率的变化

authors: Laffery OriginRing


text:
Tuntap integration

Not sure how complicated it would be to add but it could be useful to add tuntap support (ssh -w) similar to ligolo as an alternative to using a socks proxy, different tool or manually configuring a tunnel back to the bastion.
Edit: I'm not sure how you give issues a label, github wouldn't let me assign one

Hi Joe,
Thanks for this feature! I definitely think its worth having a look at. However there are some caveats, I'm going to try and avoid requiring the client binary to have administrative/root privileges, which will most likely mean I wont be setting up a full tun/tap interface on the client side.
This has the knock on effect that things like raw ICMP will not work.
Having a look at ligolo, I can see they effectively act as a proxy much the same to how the dynamic and local forwards (-D and -L) work in ssh already. They dont let you proxy arbitrary network traffic as their client is also unprivileged.

Hi Joe,
Thanks for this feature request! I definitely think its worth having a look at. However there are some caveats, I'm going to try and avoid requiring the client binary to have administrative/root privileges, which will most likely mean I wont be setting up a full tun/tap interface on the client side.
This has the knock on effect that things like raw ICMP will not work.
Having a look at ligolo, I can see they effectively act as a proxy much the same to how the dynamic and local forwards (-D and -L) work in ssh already. They dont let you proxy arbitrary network traffic as their client is also unprivileged.

Yeah, I think it's key to retain the current requirements of the project rather than requiring the client to be ran in a privileged context.

In reference to our emails you mentioned that the default forwarding + nmap was quiet slow. To speed this up, I could set a timeout on the client side for the TCP connection its trying to create.
Currently it will wait forever, which means on hosts that have a default DROP policy (rather than reject) it will hang until nmap gives up.

In reference to our emails you mentioned that the default forwarding + nmap was quiet slow. To speed this up, I could set a timeout on the client side for the TCP connection its trying to create.
Currently it will wait forever, which means on hosts that have a default DROP policy (rather than reject) it will hang until nmap gives up.

That sounds like a good solution yes!

Sweet, I'll set the timeout to the same as ligolo (5 seconds)

On the unstable branch it now has a 5 second timeout for local forward dialing, e.g when its trying to start the connection it will have a 5 second timeout but not have a timeout during the actual connection.

+1 for this
Having an integrated sshuttle/ligolo would make this an incredibly powerful tool for pivoting around networks

Well, to delve into my reading and thinking today.
The tun extension is defined here: https://cvsweb.openbsd.org/src/usr.bin/ssh/PROTOCOL?annotate=HEAD section 2.3
SSH supports both layer 3 and layer 2 tun/tap devices with the -w any:any and -w any:any -o Tunnel=ethernet options respectively.
In general tuntap presents a problem for the RSSH client. To do proper tuntap you need administrative privileges and tuntap isnt native to windows.
Other projects, such as sshuttle and ligolo have solved this by writing compatibility layers between input packets and the output network. This has its limitations, namely restricted to L3 and lacking true ICMP support (tcp/udp only).
So to roughly sum it up:

True tuntap

+ Fast
+ Able to support L3 and L2
+ Easier to implement
- Adds an additional interface (i.e very noisy)
- Requires administrative privs
- No windows unless I write a method with a specific tuntap driver which... is out of the question

Compat tuntap

+ Works on windows
+ Doesnt add an additional interface
- Most probably has a reduced throughput
- L3 Only
- - Current local or remote forwards are basically the same as this

There is also a question of client bloat, as I would like to try and keep the client somewhat small.
So those points aside, the question comes back to you lot.
Are you looking to have a true site to site vpn using rssh (i.e using true tuntap)?
What does the current feature set lack?

Well, to delve into my reading and thinking today.
The tun extension is defined here: https://cvsweb.openbsd.org/src/usr.bin/ssh/PROTOCOL?annotate=HEAD section 2.3
SSH supports both layer 3 and layer 2 tun/tap devices with the -w any:any and -w any:any -o Tunnel=ethernet options respectively.
In general tuntap presents a problem for the RSSH client. To do proper tuntap you need administrative privileges and tuntap isnt native to windows.
Other projects, such as sshuttle and ligolo have solved this by writing compatibility layers between input packets and the output network. This has its limitations, namely restricted to L3 and lacking true ICMP support (tcp/udp only).
So to roughly sum it up:

True tuntap

+ Fast
+ Able to support L3 and L2
+ Easier to implement
- Adds an additional interface (i.e very noisy)
- Requires administrative privs
- No windows unless I write a method with a specific tuntap driver which... is out of the question

Compat tuntap

+ Works on windows
+ Doesnt add an additional interface
- Most probably has a reduced throughput
- L3 Only
- - Current local or remote forwards are basically the same as this

There is also a question of client bloat, as I would like to try and keep the client somewhat small.
So those points aside, the question comes back to you lot.
Are you looking to have a true site to site vpn using rssh (i.e using true tuntap)?
What does the current feature set lack that this feature adds?

I think in terms of keeping the project as you initially intended, true tuntap might stray a little too far and be too much work compared to the compat alternative which would suffice for the use case I have currently

Getting close to having this working, unfortunately getting some very odd errors from ssh.
debug2: channel 0: rcvd adjust 132
debug2: channel 0: rcvd adjust 84
channel_input_data: channel 0: get data: incomplete message

And UDP appears to lock up at this stage.

I've now implemented this on the unstable branch, please test it out @TechSupportJosh or @joe-butler2, seems to work for me :)

I've now implemented this on the unstable branch, please test it out @TechSupportJosh or @joe-butler2, seems to work for me :)

From what I can tell, it seems to be working perfectly, nice job!

Sweet, after I get confirmation from Josh, I'll probably do a release!

Looks great, thank you! :)

authors: NHAS TechSupportJosh joe-butler2


text:
Integrating and versioning Mauro and Terminology Server models

David added as some alignment between mauro content and TS content versions is desirable.

SoW 901 - MS02 & MS04, MS13
Logic model needs clarification. JW/SH to progress with MC.

Linked to #200

First workshop on 29 April to determine approach;
Follow-up on 13 May

24/5 - building for 3++ not amending 3+

JW has demod to dd team.

30/6 - still needs testing

Maxine reviewed Mauro generated code system. Versioning mechanism shared and agreed. Awaiting value sets.

No status change at this point

James and Maxine need to discuss this.

Decision made to simplify this requirement to data stamps for versioning for both fhir history and mauro. Unable to close this ticket until some preliminary tests by Dedalus confirm TS behaviours if item is invalid in Mauro to TS feed. Likely to need business process to address special handling for rare event of 2 publications being published/committed to TS on the same day.

Thank youfor the pragmatic approach Maxine.
@maxChappell  / @jamesrwelch  - I assume this changes the Dev(M) to either a small or actually removes Oxford development effort.  Would you please confirm and replace or remove the label as appropriate if required.  Thanks

@maxChappell / @jamesrwelch - this issue is still in "For Discussion" but it appears a decision was made. Does it need moving to a different column?

18/8/22 - Maxine said this can go in the backlog.

authors: AngelaFaulding GSChandel PaulChapmanPM luxi-liu97 maxChappell oughnic rajabr57

repo: NHSDigital/DataDictionaryPublication


text:
FizzBuzz-Ternary in Javascript

FizzBuzz using Ternary operator in Javascript.

Nice! Thank you :)

license: Unlicense


text:
hey there

hi nnni. this is overlord cheese, a kid you used to talk to on discoird. I got sent to a wilderness therapy and am now at a tbs. im still into electronics and am currently reading a book on circuit analysis (well, more like pushing my way through it, its suuuper boring)
miss ya. everything else was blocked and i dont have much time so yeah this was the on;ly place i could contact you

Hi, glad to know you're doing okay! I've been wondering for a long time as well.
I don't really like to read books about circuits because it's all so much maths. The Art of Electronics is the only thing I would consider a good read, and there's a PDF version available online.
I hope everything works out fine and you will be active on Discord again.

I'll take what I can get with circuits right now, plus I don't mind math (all I lack in terms of know how is calculus, and I'll be learning that soon).
As for AOE, I've already asked my parents for it, and a PDF wouldn't work, cause, well... I don't really get to use screens. On that note, someday I will be on discord again but not anytime soon. Well, at least not consistently. it may be over a year before I can do that with the restrictions here.
...But I look forward to talking to you then
:)

No problem, see you then!
P.S. AoE 3 is like 50USD, you can probably get the second edition cheaper but wouldn't recommend it.

authors: NNNIIndia overloadchez overloadchez2


text:
[1pt] PR: nws_lid creation (Dev-nws-lid-creation)

This PR addresses #368
Creates the nws_lid layer with attributes that denote whether a site is a headwater and whether it is co-located (on the same nwm_feature_id) with another site.
This is created by retrieving all NWS_LID sites:

all sites attributed with rfc_forecast_point = True
all evaluated sites not included in (1)
all sites in HI/PR/VI

It then sorts through the WRDS metadata for all these sites and compiles the feature_id associated with the site as well as the most downstream feature_id immediately upstream of the ocean. This information is compiled into a dictionary.
Reads in the nwm_flows.gpkg layer used in FIM run to obtain the NWM river network. It then loops through all the sites based on the downstream feature_id to group sites that would flow into each other. For example, all sites associated with the Mississippi River would be selected at once. The network is then traversed and headwater sites are identified.
It then does a check to see if sites are co-located, based on having the same feature_id assignment.
It then creates a spatial GeoDataFrame of all nws_lid points and then the headwater/co-located attributes are joined.  The spatial data is then written out to file.
Additions

Creation of nws_lid geopackage layer with attributes denoting whether a site is a headwater site or is co-located with another site (at least referencing same nwm feature_id).

Testing
1.Example run is:
python3 foss_fim/tools/generate_nws_lid.py -w /path/to/workspace
Screenshots
nws_lid points are attributed with a "is_headwater" column that indicates whether it is a headwater lid location or not.
Headwater points are in black

Headwater points also denoted as co-located (assigned same nwm feature_id from WRDS)

Another example of Headwater points also co-located

@TrevorGrout-NOAA I can merge this in once it's approved. It looks like it has conflicts with the base branch, though.

authors: BradfordBates-NOAA TrevorGrout-NOAA

repo: NOAA-OWP/cahaba


text:
Port notification upon job completion functionality from private repo

Expand ngen-cal utilities, consider some simple event notifications which allow user/caller scripts to do what they see fit.
Do not leave user property in Evaluatable or EvaluationOptions!

Related to https://github.com/NOAA-OWP/ngen-cal/pull/126

I looked into how we might do this yesterday using this pure python example and how we might do this for gmail. The more that I look into it and think about it, I think we can just provide an example of how to do this using a plugin, but I don't think this is something that we will want to maintain as a feature longterm. I think we can support simple the SMTP case, but that is less and less applicable these days (e.g. MFA / BioAuth requirements).

Implementing as an ngen_cal_finish plugin hook in a top level example_plugins or even plugins directory under python/ngen_cal.  Things to consider: how to provide name/path to plugins in config.yaml, installed modules vs local file modules, ect.

Yeah, im not sold that we need to worry / consider those things. At the end of the day, it all comes down to how python imports modules. So, the three main options are:

Run ngen.cal from the same directory that contains your plugin. Then you can just ngen_cal_plugin (note, drop .py) for a function based plugin or ngen_cal_plugin.MyPlugin if it's a class based plugin.
Using PYTHONPATH to add a directory for python to search (i.e. PYTHONPATH=~/plugins python -m ngen.cal config.yaml)
Creating an installable plugin (i.e. define pyproject.toml). Then you can just provide the module path in the config.

Closing this b.c. the ngen_cal_finish plugin satisfies what is required implement this feature. Its of our opinion that a notification is workflow specific and should be implemented as a custom or installable plugin.

authors: aaraney hellkite500 robertbartel

repo: NOAA-OWP/ngen-cal


text:
GeoJSON Reader Exception

Updated the example catchment_data.geojson property from 'area_sqkm' to 'areasqkm' to match the new hydro-fabric. Added exception to GeoJSON reader whenever a property is not found.
This should fix part of the automated tests that are failing on GitHub.
Checklist

[ ] PR has an informative and human-readable title
[ ] Changes are limited to a single goal (no scope creep)
[ ] Code can be automatically merged (no conflicts)
[ ] Code follows project standards (link if applicable)
[ ] Passes all existing automated tests
[ ] Any change in functionality is tested
[ ] New functions are documented (with a description, list of inputs, and expected output)
[ ] Placeholder code is flagged / future todos are captured in comments
[ ] Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
[ ] Reviewers requested with the Reviewers tool :arrow_right:

Testing checklist (automated report can be put here)

Target Environment support

[ ] Linux

The python environment variable issue needs to be resolved, but I'll approve it once it's in there (you might need to ping me in order to remind me). I like the change.

authors: christophertubbs jdmattern-noaa

repo: NOAA-OWP/ngen


text:
shade/lev=# var fails if all values are the same

Reported by Jonathan S Callahan on 16 Jul 2001 19:11 UTC
Try the following:
yes? use coads_climatology
yes? let bop = if sst gt 30 then 150
yes? shade/lev=30 bop['shade bop[l=5](l=5]
Though)' works fine
This fix is needed for LAS.
Migrated-From: http://dunkel.pmel.noaa.gov/trac/ferret/ticket/290

Comment by ansley on 4 Sep 2008 21:18 UTC
This has been fixed, probably long since.

repo: NOAA-PMEL/Ferret


text:
blank shade plot when using immediate-mode expression

Reported by Ansley B Manke on 10 May 2004 19:27 UTC
(Andrew Wittenberg, 8-May-04 )
yes? can dat/all; use climatological_axes; use monthly_navy_winds
yes? let tseries = uwnd[shade/set tseriesz[gz=1:5:1](y=0,x=140w]
yes?
yes?)
yes? say tseries[ppl shade                      !GIVES A BLANK PLOT yes? yes? shade/set tseries*z[gz=1:5:1](GT=month_irreg],r=tunit
yes?)
yes? ppl shade                      !but this works
yes?
yes? shade/set tseriesz[say tseries,r=tunit
yes? ppl shade                      !and this works
yes?
yes? let a = tseries*z[gz=1:5:1](gz=1:5:1]
yes?)
yes? shade/set a
yes? say `tseries[ppl shade                      !and this works
Why doesn't the first case reproduce the other three?
Note: this is because there are two dynamic grids used;
one for tseries*z[gz=1:5:1](GT=month_irreg],r=tunit`
yes?) and another for the immediate-mode expr.
When we save the bb_grid, bb_yaxis, and bb_xaxis in disp_set_up,
need to increment the use count for the grid (and un-do this after?)
If the two dynamic grids are used in the same expression, then
Ferret keeps track correctly.  This plot is OK
yes? shade/title="tseries[tseries*z[gz=1:5:1](GT=month_irreg],r=tunit")
Migrated-From: http://dunkel.pmel.noaa.gov/trac/ferret/ticket/883

Comment by Ansley.B.Manke@noaa.gov on 5 Jan 2005 18:37 UTC
*** Bug 1140 has been marked as a duplicate of this bug. ***

Modified by ansley.b.manke on 5 Jan 2011 19:39 UTC

Modified by ansley.b.manke on 9 Mar 2011 00:27 UTC

Comment by andrew.wittenberg on 5 Feb 2014 19:22 UTC
Backquotes were lost in the examples -- here they are again:
yes? can dat/all; use climatological_axes; use monthly_navy_winds
yes? let tseries = uwnd[shade/set tseries*z[gz=1:5:1](y=0,x=140w]
yes?
yes?)
yes? say `tseries[ppl shade !GIVES A BLANK PLOT
yes?
yes? shade/set tseries*z[gz=1:5:1](GT=month_irreg],r=tunit`
yes?)
yes? ppl shade !but this works
yes?
yes? shade/set tseries*z[say `tseries,r=tunit`
yes? ppl shade !and this works
yes?
yes? let a = tseries*z[gz=1:5:1](gz=1:5:1]
yes?)
yes? shade/set a
yes? say `tseries[ppl shade !and this works

yes? shade/title="`tseries[GT=month_irreg](GT=month_irreg],r=tunit`
yes?),r=tunit`" tseries*z[gz=1:5:1]

Comment by ansley.b.manke on 5 Feb 2014 20:36 UTC
Indeed, as the note in the original report suggests, if I increment the use count for the grid in disp_set_up, the plots all show up.
How to later decrement that count? See if there's all the right information available at the end of xeq_pplus.F

Comment by ansley.b.manke on 11 Feb 2014 23:20 UTC
This is fixed. I bump the grid use count when /SET is given. The grid and its axes are saved in the common block  common/xbox_bounds.cmn so that the box bounds can be accessed in pplus. I can store info about whether the grid was incremented, in that same common block and decrement the grid count at the end of xeq_pplus (when the PPL SHADE has been done).

Comment by andrew.wittenberg on 14 Mar 2014 19:10 UTC
I'm still getting a blank plot for the following:
 	NOAA/PMEL TMAP
 	FERRET v6.86
 	Linux 2.6.32-431.3.1.el6.x86_64 64-bit - 02/25/14
 	14-Mar-14 15:09

yes? can dat/all; use climatological_axes; use monthly_navy_winds
yes? let tseries = uwnd[shade/set tseries*z[gz=1:5:1](y=0,x=140w]
yes?
yes?)
yes? say `tseries[GT=month_irreg],r=tunit`
 !-> MESSAGE/CONTINUE DAYS
DAYS
yes? ppl shade !GIVES A BLANK PLOT


text:
No update of quest list for 2.2 scenario being updated

Anton reported on Discord :
Latest update of scenario on 2.2 release is not made available in download list.

Script is failing to update due to mismanaged end of line in some description.
They should be encoded to \n

Fixed

repo: NPBruce/valkyrie


text:
[Scenario] Curse of Set (Nicola Zee)

Mansions of Madness Scenario
Expansions the scenario requires

Streets of Arkham (SoA)
Path of the Serpent (PotS)

Expansions the scenario can optionally use

Curse of Set

GitHub Url
https://github.com/NicolaZee/PublishedScenarios/tree/master/CurseOfSet

Ohh shiney! I'll add this now

I've added this to the manifest, @antontimmermans could you add this to the stats sheet, im not sure how to add to yours :)

Thanks for the quick response.

added to statistics

authors: NicolaZee antontimmermans scrubbless


text:
Guide - For Proof read, and use if you wish

Hi Guys,
I have written a guide to using the editor (MoM specific), it has some more up to date screenshots and goes into more detail. I hope it helps.
Please feel free to download it, link it on your Wiki or pinch bits you like for your guides.
Also if you have any comments or would like to correct anything, let me know via BGG IM or email (scrubbless@gmail.com)
https://docs.google.com/document/d/1Gi5gTwKkw84Px0Lvk-bJ3Aml_vF3ZoljjB6a8FjWGt8/

Are you interested in wiki permissions to add these to the main wiki?
Some quick comments:
You can also update scenarios from the download page.
Quest component (see https://github.com/NPBruce/valkyrie/wiki/QuestIniQuest for most of this)
Thumbnails can also be in jpg format, which is probably more appropriate if there is no text or transparency.
For required expansions should state that RN and SM should not be used.
Max player number is 10 if you want to clarify that.
Yes difficulty is 0-1, not a bug.
Editor:
Click the + icon for an event will give you the option to create a {new} one.This doesn’t work for Add Components sadly. - Added as #616
Tokens:
Tokens work even if there is no text, all the event stuff happens you just don't see a dialog (this is why the camera moves).
Events:
Many events could trigger from EventStart, but Valkyrie doesn't make any promises on the execution order.  This may be fine if you have several different set up events (like setting up mythos variables).
Puzzles:
jpg images might be more appropriate in many cases.
"I have found that sometimes the default Cancel button does not appear for Item inspects. If you find that your puzzle box has two cancel buttons, just remove this second button."
Do you have any more info on this?  Can you please report as an issue?
UI:
This should mention that the layout and scaling will be different at 16x9 and 16x10 aspect ratios, Valkyrie supports both.  More on this here:
https://github.com/NPBruce/valkyrie/wiki/QuestIniUI
Custom Images:
"jpg’s work for some parts of the editor, but PNG’s are universal, so use them"
Can you please report any known issues with jpg?  It should work everywhere.
"it will only need to be a maximum of 1920 x 1080px"
This is a bit arbitrary, no reason you couldn't run this at 8K.  A high res jpg is generally better for quality/size than png
Audio:
Yes only ogg is supported (mostly because mp3 licensing). See also:
https://github.com/NPBruce/valkyrie/wiki/QuestIniEvent
"Tip - You can hit the Log button during your Save & Test to see what variables are set to. This is extremely useful when testing if events are working. We explained this when Testing the Mythos Events."
FYI you can do this in a normal game with ALT+d
Custom Monters:
"If you want the creature to do a variety of attack activations (like a ranged activation, horror activation and a melee activation) make this first event very simple and descriptive. "
Better to have no text at all - just use this to chain a random next event and add as many activation events as you like.
"Create a trigger event - there is a little bug here when creating an event from the activation. So create it first, then add it"
What is the bug?

Custom Images:
"jpg’s work for some parts of the editor, but PNG’s are universal, so use them"
Can you please report any known issues with jpg? It should work everywhere.

Yeh I will do, I had a couple of instances where I couldn't select a JPEG, but could a PNG. This was before I knew about the GitHub issue tracking. If I can reproduce i'll log an issue.

"it will only need to be a maximum of 1920 x 1080px"
This is a bit arbitrary, no reason you couldn't run this at 8K. A high res jpg is generally better for quality/size than png

It was completely arbitrary, I was mainly trying to advise people against putting in massive 150mb images. Generally speaking people are going to be playing on a laptop or windows tablet so bigger than 1080p. I'll make it a tip and less "you must"

"Tip - You can hit the Log button during your Save & Test to see what variables are set to. This is extremely useful when testing if events are working. We explained this when Testing the Mythos Events."
FYI you can do this in a normal game with ALT+d

Ohh handy, thanks!

Custom Monters:
"If you want the creature to do a variety of attack activations (like a ranged activation, horror activation and a melee activation) make this first event very simple and descriptive. "
Better to have no text at all - just use this to chain a random next event and add as many activation events as you like.

Ahh yeh, that makes sense, thanks!
I'll reproduce and submit it. But if you click -> on a Custom Monster event and click {New event} and rename it, when you go back to the Custom Monster it still links to the Event0 that was automatically created.

Sure i am happy to work on the wiki. Better to have it all in one place.

I have added you.  LordPyrex said he would work on adding this in #287 please collaborate.

I think that the best way to implement this in the Wiki section is going to be to put your information into GitHubs text formatting. From there we can create a separate table of contents. Just let me know your thoughts on how you'd like to handle the incorporation of the information.

I don't mind, whatever is easiest.

@scrubbless after looking into the transfer into GitHub, I think that it would be better to retain the Table of Contents by keeping this in your original document. I'd like to link to your Doc file, but I noticed that it is in Suggestion mode. I figured I'd ask you if you would want to switch it to Viewing Mode only, or did you want to leave it in suggestion mode so that others could send thoughts your way.

I'll pop it back into viewing mode, i've had a couple of proof readers already run through it, so should be fine.
If anyone wants to comment i'll give them individual permissions.

I'm going to close this as I don't think this is an ongoing issue.

authors: LordPyrex NPBruce scrubbless


text:
Sylvia Marsh Token is not correct

The person in the sight token should be Sylvia Marsh. I'm pretty sure it was correct before as one of the scenarios (Lair of Rlim Shaikorth) used her token.

There were all redone for MoM 1.5 (Valkyrie 1.6), so the bug will be new.

Othera Gilman is also wrong (has the Sylvia Marsh image)

authors: Hobbeslionheart NPBruce


text:
Update CHP defaults, and update Julia dependencies

PRs:

https://github.com/NREL/REopt.jl/pull/290
https://github.com/NREL/REopt.jl/pull/289

@zolanaj I'm seeing an issue with Oscar's strategy with the GhpGhx package which is only conditionally loaded with the Requires package. I vaguely remember something about this when adding GHP. I'm going to use my strategy for now, since it's working, and I will work toward removing the Manifest.toml with the [compat] section of the test/Project.toml in the near future.


text:
Figure out what we want on the source_type page

I feel like this (and possibly the source page) could get at what Amir was getting at with qualitative data feeds or at least content. the current spec is pretty bare bones. See:
http://resourceprojects.org/source_type/56e873691d1d2a3824141431
I could see adding admin generated content here on what is included, reliabilty/timliness, etc.

Admin generated basic content on timeliness/reliability/etc + a few auto filled content:
number of project,  total reported lines, total value  would be awesome content.
happy to do a list of suggestion.
But one question: this could be for the  source page and only for selected sources (not all sources will have that)..
Also note that this is more geared at source page then at source_type page.

authors: byndcivilization davidmihalyi


text:
Issues with dif_beam camera and scan at CSX

dif_beam stats are plotted with vairous motor scans.  If the scan is paused, the camera does not move back to continuous mode (mode prior to scan).  It is stuck in multiple.
PV parameters:
XF:23ID1-ES{Dif-Cam:Beam}cam1:ImageMode
    Native data type: DBF_ENUM
    Request type:     DBR_GR_ENUM
    Element count:    1
    Value:            Continuous
    Status:           NO_ALARM
    Severity:         NO_ALARM
    Enums:            ( 3)
                      [ 0] Single
                      [ 1] Multiple
                      [ 2] Continuous

This is expected, it should only roll back to the previous state when it is unstaged (which is not done when paused).

Sorry @tacaswell .  I wasn't clear enough.  It was paused and stopped/aborted.  I will work out the details (now that I don't remember them) when the current users leave the beamline - ETA next Monday.

Oh, that is much worse.  Put something on my calendar (~1 hr) to look at this.

@tacaswell The order of the unstaged signals may be key here - stop acquisition, then set continuous mode, etc.

I take it that it may be more sensitive to that order maybe more sensitive it it has not finished the acquisition?

IIRC unstage does run correctly in reverse order -- I think that's tested.

It should be tested and working - my comment was merely that stage_sigs should be one of the first things to check when you sit at the beamline.

authors: ambarb danielballan klauer tacaswell

repo: NSLS-II/Bug-Reports


text:
Stages are not needed for OutputSlotMeta and thus misleading

Currently the stages is defined as a field of BaseSlotMeta and therefore presents in both InputSlotMeta and OutputSlotMeta:
https://github.com/NTAILab/bosk/blob/fba330481a2de56c1bd4efe453acf4ca75901575/bosk/block/slot.py#L18
For the InputSlotMeta the stages field is very important.
But for the OutputSlotMeta the stages field is not used at all.
Besides, probably it doesn't have much sense, because outputs are only available when transform method is executed.
Possible solutions:

Move stages from BaseSlotMeta to InputSlotMeta.
(1) and devise some analogous field for OutputSlotMeta.
Implement stages handling for output slots too.

For the (3) solution stages meaning would be:

fit=True or transform_on_fit=True – the output will be calculated at the FIT stage;
transform=True – the output definitely will be calculated at TRANSFORM stage.

Thus transform_on_fit is redundant for output slots.
Besides, fit=True and transform=False is a correct state, whereas fit=False and transform=True seems not to be a correct state (because a block does not know at which stage it is executed).

Fixed in #51

repo: NTAILab/bosk


text:
[BUG] LambdaOp doesnt work with multi-GPU cluster, multiple output workers

Describe the bug
I run a multi=GPU NVTabular workflow with LambdaOps. It executes the fit functionality, but when the pipeline does tramsform and to parquet, I get following error. I I run on single GPU, it does work.
Failed to transform operator <nvtabular.ops.lambdaop.LambdaOp object at 0x7fbb4a93f2e0>
Traceback (most recent call last):
  File "/usr/local/lib/python3.8/dist-packages/nvtabular/workflow/workflow.py", line 539, in _transform_partition
    f"Dtype discrepancy detected for column {col_name}: "
  File "/usr/local/lib/python3.8/dist-packages/nvtabular/ops/lambdaop.py", line 103, in label
    source = getsourcelines(self.f)[0][0]
  File "/usr/lib/python3.8/inspect.py", line 979, in getsourcelines
    lines, lnum = findsource(object)
  File "/usr/lib/python3.8/inspect.py", line 798, in findsource
    raise OSError('could not get source code')
OSError: could not get source code
2022-07-20 10:17:49,872 - distributed.worker - WARNING - Compute Failed
Key:       ('write-processed-2c66d3a6a6f1b9c54db536c61f1e311e-partition2c66d3a6a6f1b9c54db536c61f1e311e', "('part_50.parquet', 'part_51.parquet', 'part_52.parquet', 'part_53.parquet', 'part_54.parquet', 'part_55.parquet', 'part_56.parquet', 'part_57.parquet', 'part_58.parquet', 'part_59.parquet')")
Function:  _write_subgraph
args:      (<merlin.io.dask.DaskSubgraph object at 0x7fbb4ab4d550>, ('part_50.parquet', 'part_51.parquet', 'part_52.parquet', 'part_53.parquet', 'part_54.parquet', 'part_55.parquet', 'part_56.parquet', 'part_57.parquet', 'part_58.parquet', 'part_59.parquet'), '/raid/moj_feed_data_v1_sample1_parquet_test/', None, <fsspec.implementations.local.LocalFileSystem object at 0x7fbb4aaee2b0>, [], [], [], 'parquet', 0, False, '')
kwargs:    {}
Exception: "OSError('could not get source code')"

Steps/Code to reproduce bug
I use the criteo dask cluster initalization
# Dask dashboard
dashboard_port = "8787"
dask_workdir = '/raid/dask/'

# Deploy a Single-Machine Multi-GPU Cluster
protocol = "tcp"  # "tcp" or "ucx"
if numba.cuda.is_available():
    NUM_GPUS = list(range(len(numba.cuda.gpus)))
else:
    NUM_GPUS = []
visible_devices = ",".join([str(n) for n in NUM_GPUS])  # Delect devices to place workers
device_limit_frac = 0.7  # Spill GPU-Worker memory to host at this limit.
device_pool_frac = 0.8
part_mem_frac = 0.15

# Use total device size to calculate args.device_limit_frac
device_size = device_mem_size(kind="total")
device_limit = int(device_limit_frac * device_size)
device_pool_size = int(device_pool_frac * device_size)
part_size = int(part_mem_frac * device_size)

# Check if any device memory is already occupied
for dev in visible_devices.split(","):
    fmem = pynvml_mem_size(kind="free", index=int(dev))
    used = (device_size - fmem) / 1e9
    if used > 1.0:
        warnings.warn(f"BEWARE - {used} GB is already occupied on device {int(dev)}!")

cluster = None  # (Optional) Specify existing scheduler port
if cluster is None:
    cluster = LocalCUDACluster(
        protocol=protocol,
        n_workers=len(visible_devices.split(",")),
        CUDA_VISIBLE_DEVICES=visible_devices,
        device_memory_limit=device_limit,
        local_directory=dask_workdir,
        dashboard_address=":" + dashboard_port,
        rmm_pool_size=(device_pool_size // 256) * 256
    )

# Create the distributed client
client = Client(cluster)
client

E.g.
col_cat_int8 = col_cat_int8 >> nvt.ops.Categorify() >> nvt.ops.LambdaOp(lambda x: x.astype('int8'))
workflow.transform(dataset).to_parquet(output_path, out_files_per_proc=10)

The only thing I know that serialized Python lambdas is cloudpickle, so I guess we could serialize the Workflow to cloudpickle and then deserialize it on the workers? Not too sure how to do that, but it's the only approach I can think of.

@bschifferer, as a short-term workaround - can you try this instead to explicitly set the dtype in the LambdaOp?
col_cat_int8 = col_cat_int8 >> nvt.ops.Categorify() >> nvt.ops.LambdaOp(lambda x: x.astype('int8'), dtype="int8")
workflow.transform(dataset).to_parquet(output_path, out_files_per_proc=10)

This should at least cause your workflow to execute on multiple workers.
I think the root cause of the issue here is that the 'capture_dtypes' functionality doesn't work on a distributed cluster environment - since the dtypes are only captured here https://github.com/NVIDIA-Merlin/NVTabular/blob/bc71785aab96368fb51f60d876fdfecba709e494/nvtabular/workflow/workflow.py#L534-L535 on the worker process, and the dtypes for each node in the graph aren't communicated back to the actual workflow.
The LambdaOp issue is a red-herring - we're already using cloudpickle under the hood (either to save the workflow itself, or distribute work with dask https://distributed.dask.org/en/stable/serialization.html#defaults . The issue was in raising the exception, called the LambdaOp.label functionality which failed =(. I've fixed the LambdaOp.label call here  https://github.com/NVIDIA-Merlin/NVTabular/pull/1634- and added a basic test using LambdaOp's with dask there too

Yes that worked around works for me - thanks

authors: benfred bschifferer karlhigley

repo: NVIDIA-Merlin/NVTabular


text:
GptManager vs Executorl: Why using an Executor instead of a GptManager the release version?

Why using an Executor instead of a GptManager the release version?

This may not be sufficient to answer your question, the GptManager is deprecated, and the Executor API is the official API now, it is available both in C++ API and Python API.

This may not be sufficient to answer your question, the GptManager is deprecated, and the Executor API is the official API now, it is available both in C++ API and Python API.

SO, what reasons was deprecated for GptManager?

Executor API is a refined and generalized version of GptManager. It adds another layer of abstraction. To avoid duplicating APIs, the GptManager API is not going to be supported beyond 0.14.

authors: Guangjun-A MartinMarciniszyn Superjomn

repo: NVIDIA/TensorRT-LLM


text:
gptManagerBenchmark launch failed

I'm using the code commit f7eca56161d496cbd28e8e7689dbd90003594bd2.
The gptSessionBenchmark runs ok.
But when I try gptManagerBenchmark to test inflight batching. It crashed.
mpirun -n 2 --allow-run-as-root benchmarks/gptManagerBenchmark --model llama --engine_dir ../../examples/llama/./tmp/llama/13B/trt_engines/fp16/2-gpu/ --dataset /data/TensorRT-LLM/benchmarks/cpp/preprocessed_dataset_256.json
[bms-airtrunk-c-g1v2-app-10-214-144-75:317357:0:318107] Caught signal 11 (Segmentation fault: address not mapped to object at address (nil))
==== backtrace (tid: 318107) ====
 0 0x0000000000042520 __sigaction()  ???:0
 1 0x000000000007c262 tensorrt_llm::batch_manager::NamedTensor::serialize()  ???:0
 2 0x000000000007b79d tensorrt_llm::batch_manager::InferenceRequest::serialize()  ???:0
 3 0x0000000000048f4e GptServer::getInferenceRequests()  ???:0
 4 0x0000000000049837 std::_Function_handler<std::list<std::shared_ptr<tensorrt_llm::batch_manager::InferenceRequest>, std::allocator<std::shared_ptr<tensorrt_llm::batch_manager::InferenceRequest> > > (int), GptServer::GptServer(std::filesystem::path const&, tensorrt_llm::batch_manager::TrtGptModelType, int, tensorrt_llm::batch_manager::batch_scheduler::SchedulerPolicy, tensorrt_llm::batch_manager::TrtGptModelOptionalParams const&, std::shared_ptr<Recorder>, std::optional<unsigned long>)::{lambda(int)#1}>::_M_invoke()  ???:0
 5 0x0000000000071ce4 tensorrt_llm::batch_manager::GptManager::fetchNewRequests()  ???:0
 6 0x00000000000733c6 tensorrt_llm::batch_manager::GptManager::decoupled_execution_loop()  ???:0
 7 0x00000000000dc253 std::error_code::default_error_condition()  ???:0
 8 0x0000000000094b43 pthread_condattr_setpshared()  ???:0
 9 0x0000000000125bb4 clone()  ???:0
=================================
[bms-airtrunk-c-g1v2-app-10-214-144-75:317357] *** Process received signal ***
[bms-airtrunk-c-g1v2-app-10-214-144-75:317357] Signal: Segmentation fault (11)
[bms-airtrunk-c-g1v2-app-10-214-144-75:317357] Signal code:  (-6)
[bms-airtrunk-c-g1v2-app-10-214-144-75:317357] Failing at address: 0x4d7ad
[bms-airtrunk-c-g1v2-app-10-214-144-75:317357] [ 0] /lib/x86_64-linux-gnu/libc.so.6(+0x42520)[0x7f5b0bd76520]
[bms-airtrunk-c-g1v2-app-10-214-144-75:317357] [ 1] benchmarks/gptManagerBenchmark(+0x7c262)[0x55f2d3804262]
[bms-airtrunk-c-g1v2-app-10-214-144-75:317357] [ 2] benchmarks/gptManagerBenchmark(+0x7b79d)[0x55f2d380379d]
[bms-airtrunk-c-g1v2-app-10-214-144-75:317357] [ 3] benchmarks/gptManagerBenchmark(+0x48f4e)[0x55f2d37d0f4e]
[bms-airtrunk-c-g1v2-app-10-214-144-75:317357] [ 4] benchmarks/gptManagerBenchmark(+0x49837)[0x55f2d37d1837]
[bms-airtrunk-c-g1v2-app-10-214-144-75:317357] [ 5] benchmarks/gptManagerBenchmark(+0x71ce4)[0x55f2d37f9ce4]
[bms-airtrunk-c-g1v2-app-10-214-144-75:317357] [ 6] benchmarks/gptManagerBenchmark(+0x733c6)[0x55f2d37fb3c6]
[bms-airtrunk-c-g1v2-app-10-214-144-75:317357] [ 7] /lib/x86_64-linux-gnu/libstdc++.so.6(+0xdc253)[0x7f5b0c058253]
[bms-airtrunk-c-g1v2-app-10-214-144-75:317357] [ 8] /lib/x86_64-linux-gnu/libc.so.6(+0x94b43)[0x7f5b0bdc8b43]
[bms-airtrunk-c-g1v2-app-10-214-144-75:317357] [ 9] /lib/x86_64-linux-gnu/libc.so.6(clone+0x44)[0x7f5b0be59bb4]
[bms-airtrunk-c-g1v2-app-10-214-144-75:317357] *** End of error message ***
--------------------------------------------------------------------------
Primary job  terminated normally, but 1 process returned
a non-zero exit code. Per user-direction, the job has been aborted.
--------------------------------------------------------------------------
--------------------------------------------------------------------------
mpirun noticed that process rank 0 with PID 0 on node bms-airtrunk-c-g1v2-app-10-214-144-75 exited on signal 11 (Segmentation fault).

Here is my script to convert model, I'm running on 2*V100 GPU.
python build.py --model_dir /data/models/vicuna-13b-v1.5/vicuna-13b-v1.5/ \
                --dtype float16 \
                --use_gpt_attention_plugin float16 \
                --use_gemm_plugin float16 \
                --output_dir ./tmp/llama/13B/trt_engines/fp16/2-gpu/ \
                --max_batch_size 24 \
                --tp_size 2 \
                --world_size 2 \
                --use_inflight_batching \
                --remove_input_padding \
                --paged_kv_cache \
                --parallel_build \

Having same issue here. Happens only with MPIRun

Hi,
Thanks for reporting the issue, we have fixed the issue in the internal codebase, before the fix is pushed, could you please try the following changes to unblock you?
diff --git a/benchmarks/cpp/gptManagerBenchmark.cpp b/benchmarks/cpp/gptManagerBenchmark.cpp
index 9f6681547..c1be42d98 100644
--- a/benchmarks/cpp/gptManagerBenchmark.cpp
+++ b/benchmarks/cpp/gptManagerBenchmark.cpp
@@ -465,8 +465,14 @@ std::shared_ptr<InferenceRequest> makeRequest(std::uint64_t reqId,
     request->setMaxNewTokens(
         bufferManager.copyFrom(&request_output_len, ITensor::makeShape({1, 1}), MemoryType::kPINNED));
     request->setBeamWidth(beamWidthTensor);
-    request->setEndId(eosId);
-    request->setPadId(padId);
+    if (eosId != nullptr)
+    {
+        request->setEndId(eosId);
+    }
+    if (padId != nullptr)
+    {
+        request->setPadId(padId);
+    }
     return request;
 }

Please let me know if you are still seeing the issue after apply the changes, thanks!

Hi,
This issue should already been fixed on the latest main branch, please kindly check and let us know if you're still seeing the issue.
Closing, thanks very much for the support.

authors: kaiyux omer-dayan sleepwalker2017


text:
What does two optimization profiles mean?

in runntime/gptSession.cpp
...
void GptSession::createContexts()
{
    TLLM_LOG_DEBUG("%s start", __PRETTY_FUNCTION__);
    mRuntime->clearContexts();

    auto const numProfiles = mRuntime->getNbProfiles();
    TLLM_CHECK_WITH_INFO(
        numProfiles == 1 || numProfiles == 2, "GPT only expects one optimization profile or two optimization profiles");

    // Instantiate 1 execution context for each profile
    for (auto contextId = 0; contextId < numProfiles; ++contextId)
    {
        mRuntime->addContext(contextId);
    }

    TLLM_LOG_DEBUG("%s stop", __PRETTY_FUNCTION__);
}

and in tensorrt_llm/models/generation_mixin.py
  enable_two_optimization_profiles = GenerationMixin.has_two_optimization_profiles(
            use_gpt_attention_plugin, use_gemm_plugin, remove_input_padding,
            paged_kv_cache)

How does building mRuntime.addContext with setting =1 or 2 make sense in terms of performance?
Is the context phase or generate phase FLOPs percentage controlled?

TensorRT-LLM depends on TensorRT to get the best performance. While TensorRT needs to know shape to find the optimal kernels.
In some cases, using two different optimal shapes for finding good kernels are needed. This is all done automatically, and should not be a concern to users.
Thanks

authors: litaotju xesdiny