text:
[WIP] Remove duplicate interpolation SILGen code

This is a refactoring that doesn't work yet. The first eight commits are all from #27292; the last commit is new, and attempts to switch from manually creating a temporary allocation to using ManagedValue::materialize(). The problem is that doing this breaks the OSLogInterpolation tests, and I'm not sure how to fix them.
This change appears to break OSLog in two ways:

error: 'OSLogMessage' struct is unoptimizable: 'init' is not constant evaluable. This is because beginOfInterpolation() in the OSLog optimization pass starts interpreting instructions at the alloc_stack instruction, but the change I made to SILGen causes it to emit the allocating init call before the alloc_stack instead of after. I have some code stashed locally which fixes this by finding the store instruction that initialized the alloc_stack and then tracing all of its operands recursively to find the earliest instruction involved in initializing the OSLogMessage instance; this seems to work, but it's very complex and I think I may be taking the wrong approach.

error: globalStringTablePointer builtin must used only on string literals. When I see this, the argument is a reference to the formatString property, which suggests that this change also breaks something more subtle in the OSLog pass.

I'm posting this PR so I can share it with people who may know how to fix this problem. But first, I'll run tests so we can see what we're dealing with.

@swift-ci please smoke test

Example of the failures: https://ci.swift.org/job/swift-PR-osx-smoke-test/17542/consoleFull#16525587803122a513-f36a-4c87-8ed7-cbc36a1ec144
@ravikandhadai Any thoughts about this?

@brentdax I can help you fix this. Unfortunately, the logic in the beginOfInterpolation function of the OSLogOptimization pass is a bit fragile and it has been a pain point.  The function tries to find the first SIL instruction that is generated for the string interpolation passed to the os log APIs. (Btw,  the second error relating to globalStringTablePointer is just because of the first.)

I have some code stashed locally which fixes this by finding the store instruction that initialized the alloc_stack and then tracing all of its operands recursively to find the earliest instruction involved in initializing the OSLogMessage instance; this seems to work, but it's very complex and I think I may be taking the wrong approach.

I think this kind of backward dependency analysis is possible, and could benefit other applications of constant evaluation. But my concern is, as you say, it could be complex and will also have to be conservative (if there are intervening function calls) meaning that it could result in more code being analyzed.  There is also a  requirement specific to OSLog that we shouldn't follow some parts of the backward dependency chain that corresponds to the "dynamic" argument being logged.
An alternative is to "mark" the start and end of the SIL instructions generated for a string interpolation during SILgen. I am not sure how feasible this is? We either need dummy instruction or a way to associate some metadata with the SIL instruction. Not sure, how easy it is to do.
Anyway, I will take a look at the new SIL to see if there is a better way to change that code.

@ravikandhadai The dependency analysis wasn't actually too horrible; the only problem was that it didn't seem to resolve the situation completely—I still got globalStringTablePointer errors even with it in place.

@brentdax  I have created a PR here: https://github.com/apple/swift/pull/27419 that fixes this issues. I tested it on this PR also. The change does the backward dependency traversal that we discussed here.

Now that #27419 has fixed the issue blocking this change, I'm folding it back into #27292. Thank you, @ravikandhadai!

authors: brentdax ravikandhadai


text:
[Sema] fix ParenPattern resolution when subexpression is a NilLiteralExpr

What's in this pull request?
A minor fix to the ResolvePattern ASTVisitor used in TypeCheckPattern.cpp.
Previously, if a ParenExpr's subexpression returned nullptr when passed to visit() (which happens for nil literals, since visitNilLiteralExpr() isn't defined), then visitParenExpr() itself would return nullptr, so the ParenExpr was just wrapped in an ExprPattern. This broke the ability of coercePatternToType() to peek at the ExprPattern's expression and convert NilLiteralExpr to an EnumElementPattern, because instead of finding a NilLiteralExpr, it'd just find the ParenExpr.
With this fix, visitParenExpr() reuses existing logic from getSubExprPattern(), which wraps the subexpression in an ExprPattern, even when there's no special visitor for it, rather than wrapping the whole ParenExpr in an ExprPattern.
Resolved bug number: SR-2066
"Parenthesized nil in a case statement breaks exhaustivity checking" filed by @gregomni

Before merging this pull request to apple/swift repository:

[x] Test pull request on Swift continuous integration.

Triggering Swift CI
The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:
Smoke Testing
    Platform     | Comment
    ------------ | -------------
    All supported platforms     | @swift-ci Please smoke test
    All supported platforms     | @swift-ci Please smoke test and merge
    OS X platform               | @swift-ci Please smoke test OS X platform
    Linux platform              | @swift-ci Please smoke test Linux platform

Validation Testing
    Platform     | Comment
    ------------ | -------------
    All supported platforms     | @swift-ci Please test
    All supported platforms     | @swift-ci Please test and merge
    OS X platform               | @swift-ci Please test OS X platform
    OS X platform               | @swift-ci Please benchmark
    Linux platform              | @swift-ci Please test Linux platform

Lint Testing
    Language     | Comment
    ------------ | -------------
    Python       | @swift-ci Please Python lint

Note: Only members of the Apple organization can trigger swift-ci.

Thanks, LGTM.
@swift-ci please test and merge.

Cheers!

source: gharchive/pull-request

authors: CodaFi jtbandes

repo: apple/swift

license_type: permissive

license_source: github-api


text:
Implementation of the SE-130 proposal.

What's in this pull request?

Resolved bug number: (SR-1964)

rdar://problem/17028332

Before merging this pull request to apple/swift repository:

[x] Test pull request on Swift continuous integration.

Triggering Swift CI
The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:
Smoke Testing
    Platform     | Comment
    ------------ | -------------
    All supported platforms     | @swift-ci Please smoke test
    All supported platforms     | @swift-ci Please smoke test and merge
    OS X platform               | @swift-ci Please smoke test OS X platform
    Linux platform              | @swift-ci Please smoke test Linux platform

A smoke test on macOS does the following:

Builds the compiler incrementally.
Builds the standard library only for macOS. Simulator standard libraries and
device standard libraries are not built.
lldb is not built.
The test and validation-test targets are run only for macOS. The optimized
version of these tests are not run.

A smoke test on Linux does the following:

Builds the compiler incrementally.
Builds the standard library incrementally.
lldb is built incrementally.
The swift test and validation-test targets are run. The optimized version of these
tests are not run.
lldb is tested.

Validation Testing
    Platform     | Comment
    ------------ | -------------
    All supported platforms     | @swift-ci Please test
    All supported platforms     | @swift-ci Please test and merge
    OS X platform               | @swift-ci Please test OS X platform
    OS X platform               | @swift-ci Please benchmark
    Linux platform              | @swift-ci Please test Linux platform

Lint Testing
    Language     | Comment
    ------------ | -------------
    Python       | @swift-ci Please Python lint

Note: Only members of the Apple organization can trigger swift-ci.

It replaces String initializers taking Character or UnicodeScalar as a repeating value by a more general initializer that takes a String as a repeating value. This is done to avoid the ambiguities in the current String API, which can be only resolved by explicit casting.
String.append(_:UnicodeScalar) APIs is also removed to match these changes.

@gribozavr Please review this implementation of the SE-130 proposal.

@swift-ci Please test

@parkera This PR implements SE-130. Among other things, it removed String(repeating:Character, count:) in favor of String(repeating: String, count:). Foundation uses the old API at two different places according to these compilation errors.

Those look fine to me.

@swift-ci Please some test Linux

@swift-ci Please smoke test Linux

@gribozavr Do you mind having a look at it? The biggest change is the fix for "appendToSubstringBug" test failure.

It is impossible to test this PR and the related apple/swift-package-manager#561 and apple/swift-corelibs-foundation#477 using our CI. But I'm testing on a Linux box.

OK. All tests on the Linux box seem to pass.
I'm going to merge now.

authors: parkera swiftix


text:
[5.5][Async Refactoring] Add return keyword if wrapping ReturnStmt is implicit

Explanation: Previously, in the following case we were failing to add a return keyword inside withImplicitReturn.

func withImplicitReturn(completionHandler: (String) -> Void) {
  simple {
    completionHandler($0)
  }
}

// becomes

func withImplicitReturn() async -> String {
  let val0 = await simple()
  val0 // <-- missing return here
}

This is because the call of completionHandler($0) is wrapped by an implicit ReturnStmt and thus we assumed that there was already a return keyword present.
Fix this issue by checking if the wrapping ReturnStmt is implicit and if it is, add the return keyword.

Scope: Async refactoring containing implicit returns statements
Risk: Very low
Testing: Added regression test
Issue: rdar://80009760
Reviewer: @bnbarham (Ben Barham) on original PR #38191

@swift-ci Please test

Build failed
Swift Test Linux Platform
Git Sha - 3134a9a027ae50201f46cdc223e1a22c705871e8

@swift-ci please test Linux platform

authors: ahoppen bnbarham swift-ci


text:
[IRGen] Use condbrs for big int switches.

Previously, switches over extremely large integers (e.g. i832) were emitted when emitting switches with many spare bits.  Such switches result in unfortunate downstream codegen.
Here, for large enums (currently, more than two words) the preexisting EnumPayload::emitCompare function is used to compare each of the enum cases in turn with the payload's value.  The result is a series of cond_br where the conditional is made by anding together word-size chunks of the payload value with word-size chunks of each enum case's tag, subject to masking.
rdar://83158525

@swift-ci please test

@swift-ci please benchmark

@swift-ci please test compiler performance

@swift-ci please test macOS platform

Same source compatibility UPASSes in compiler performance run as in baseline.  Merging.


text:
[DRAFT][stdlib] Publish some useful prespecializations

The help reduce code size costs of specialization by allowing clients whose minimum deployment target is high enough to call into ready-made prespecializations in the stdlib instead of emitting them into their own executable.
(The entry points introduced here have actually been shipping on Apple’s OSes since Swift 5.5, but previously we lacked the ability to describe their availability, limiting their use to OS components.)
rdar://74529458
[This is a draft because of the TBD validation problems it currently induces in modules that call these.]

@swift-ci test

I'll also need to figure out if it is possible to fix these warnings without affecting the symbol names:
.../swift/stdlib/public/core/Prespecialize.swift:621:19: warning: redundant same-type constraint 'Element' == 'String'
    where Element == String, S == Set<String>)
                  ^
.../swift/stdlib/public/core/Prespecialize.swift:616:19: warning: redundant same-type constraint 'Element' == 'Any'
    where Element == Any, S == [Any])
                  ^
.../swift/stdlib/public/core/Prespecialize.swift:611:19: warning: redundant same-type constraint 'Element' == 'String'
    where Element == String, S == [String])
                  ^
.../swift/stdlib/public/core/Prespecialize.swift:885:19: warning: redundant same-type constraint 'Element' == 'String'
    where Element == String, S == Set<String>)
                  ^
.../swift/stdlib/public/core/Prespecialize.swift:880:19: warning: redundant same-type constraint 'Element' == 'String'
    where Element == String, S == [String])
                  ^
.../swift/stdlib/public/core/Prespecialize.swift:875:19: warning: redundant same-type constraint 'Element' == 'Any'
    where Element == Any, S == [Any])
                  ^

@swift-ci test


text:
Delete _InternalSwiftSyntaxParser And Its Build Infrastructure

This is the start of the removal of the C++ implementation of libSyntax in favor of the new Swift Parser and Swift Syntax libraries. Now that the swift-syntax project has switched the SwiftSyntaxParser library over to being a thin wrapper around the Swift Parser, there is no longer any reason we need to retain any libSyntax infrastructure in the swift compiler.
As a first step, delete the infrastructure that builds lib_InternalSwiftSyntaxParser and convert any scripts that mention it to instead mention the static mirror libraries. The --swiftsyntax build-script flag has been retained and will now just execute the SwiftSyntax and Swift Parser builds with the just-built tools.

@swift-ci test

@swift-ci test

@swift-ci test Linux

@swift-ci smoke test Linux

@swift-ci smoke test Linux

@swift-ci smoke test

@swift-ci smoke test

apple/swift-integration-tests#103
@swift-ci test Linux


text:
[Refactoring] Merge identical cases of switch

This diff doesn't look quite right. I think the changes to delete the ResumeThrowingContinuationReturning case didn't come through.

fixed

ping

Can you do a rebase instead?

Can you do a rebase instead?

done

@swift-ci please smoke test

authors: AnthonyLatsis valeriyvan


text:
[SourceKit] Return the original location for decls within generated code

Pass back the original location (ie. where the macro was expanded, not the location that the generated code would be inserted) for cursor info and indexing. Also mark any declarations/references within generated source as implicit.
Resolves rdar://107209132.

@swift-ci please test Linux platform


text:
[cxx-interop] Add test for mutable std.optional.pointee

See https://github.com/apple/swift/pull/67648

@swift-ci please smoke test

@swift-ci please smoke test macOS

@swift-ci please smoke test Linux

@swift-ci please smoke test macOS

@swift-ci please smoke test macOS

@swift-ci please smoke test macOS

@swift-ci please smoke test macOS


text:
Improve support for Swift-only initializers in @_objcImplementation checker

The typical rules for member implementations don't work very well for initializers:

Initializers cannot be made final, so we need to support @nonobjc as an opt-out keyword for them.
Designated and required initializers don't function correctly without dynamic dispatch, dynamic dispatch of Swift-only members requires a vtable, and @_objcImplementation classes don't have a vtable, so it shouldn't be possible to define Swift-only designated and required initializers on an @_objcImplementation class. (Swift-only convenience inits and @objc inits of any kind are okay.)

Enforce these new rules, and additionally make several related improvements to @_objcImplementation diagnostics:

Make the fix-it suggesting private on an @objc member replace an existing access control keyword if one is present.
Add a separate ObjCReason for members that are implicitly @objc because they belong to an @_objcImplementation extension; this improves the wording of some diagnostics and allows us to avoid emitting redundant diagnostics about members that aren't valid as @objc.
Add a fallback diagnostic about @_objcImplementation extension members that require a vtable entry. This would have caught the designated/required init issue even without knowing the specific cause of the problem.

This PR will probably be easier to review commit-by-commit.

@swift-ci please test

@swift-ci please smoke test and merge


text:
🍒[cxx-interop] Only run tests for reference types against a recent Swift runtime

Having a Swift array of C++ reference types without crashing at runtime only became possible recently (https://github.com/apple/swift/pull/73615). When building against an older runtime, one would still see runtime crashes. This is expected because part of the fix is in the Swift runtime.
This makes sure we don't try to run tests for C++ reference types with an older Swift runtime.
rdar://128681137
(cherry picked from commit 0f420fe8a4756309ff8804b4dab0816bbd5ddb3a)

@swift-ci please test


text:
String contact with flexible type doesn't behave intuitively

Strange results when combining flexible types. Discovered this while fixing #669
flexible_type right = "right";
log_and_throw(std::string("left ") + std::string(right)); // left right

log_and_throw(std::string("left ") + right); // right left

This template definition assumes that the + operator is commutative
https://github.com/apple/turicreate/blob/8675c1c684d17e4f7e6267af7e290b95dc8a4f26/src/flexible_type/flexible_type.hpp#L2535

source: gharchive/issue

authors: nickjong srikris

repo: apple/turicreate


text:
Style Transfer Does Not Work

The code included: https://apple.github.io/turicreate/docs/userguide/style_transfer/ does not at all. It throws the following exception.
failed assertion `MTLTextureDescriptor has height (65536) greater than the maximum allowed size of 16384.'
Even though the image size for test, content and style images are 256 X 256.

@azamsharp - what operating system are you using?

macOS Catalina

@azamsharp - I just ran the style transfer code from the user guide on macOS Catalina. It works fine  for me. Could you please provide the full output/stack-trace? Also it would be helpful to know some details about your dataset.

authors: TobyRoseman azamsharp


text:
verifyCallback not called

On many occasions, the verifyCallback is not called. I don't think it's a deterministic process, but it always happens after the recaptcha asks the user to filter some images among many others.

It was behaving slightly differently in my case (Gatsby website), in that the callback was only getting called if landing on the form from another page, not if accessing the form page directly :confused:
Possibly some bug hiding somewhere in the isReady() polling? Btw, I noticed state being mutated directly here: https://github.com/appleboy/react-recaptcha/blob/master/src/index.js#L103 -> which usually causes things to break, although I doubt that's what's causing this issue...
Anyways, after copy-pasting the code down and starting to dissect it to pinpoint the issue, I ended up using this stripped-down version, which works a charm for me:
import React, {Component} from 'react';
import PropTypes from 'prop-types';

// Wait for the recaptcha object to become available
// The promise will resolve as soon as needed, keep resolving with the
// cached object.
const waitForRecaptcha = new Promise(resolve=> {
    let interval = setInterval(()=> {
        if (typeof window !== 'undefined' && typeof window.grecaptcha !== 'undefined') {
            clearInterval(interval);
            resolve(window.grecaptcha);
        }
    }, 1000);
});

export default class Recaptcha extends Component {

    constructor(props) {
        super(props);
        this.state = {widget: null};
        this._containerRef = null;
    }

    componentDidMount() {
        this._renderGrecaptcha();
    }

    _renderGrecaptcha() {
        const {sitekey, theme, type, size, tabindex, hl, badge,
               verifyCallback, expiredCallback, onloadCallback} = this.props;

        waitForRecaptcha.then(grecaptcha=> {
            const widget = grecaptcha.render(this._containerRef, {
                sitekey, theme, type, size, tabindex, hl, badge,
                callback: verifyCallback,
                'expired-callback': expiredCallback,
            });
            this.setState({widget});
        });

        if (onloadCallback) {
            onloadCallback();
        }
    }

    render() {
        return <div ref={el=> this._containerRef = el} />;
    }
}

Recaptcha.propTypes = {
    onloadCallback: PropTypes.func,
    verifyCallback: PropTypes.func,
    expiredCallback: PropTypes.func,
    sitekey: PropTypes.string.isRequired,
    theme: PropTypes.string,
    type: PropTypes.string,
    size: PropTypes.string,
    tabindex: PropTypes.string,
    hl: PropTypes.string,
    badge: PropTypes.string,
};

Recaptcha.defaultProps = {
    onloadCallback: undefined,
    verifyCallback: undefined,
    expiredCallback: undefined,
    theme: 'light',
    type: 'image',
    size: 'normal',
    tabindex: '0',
    hl: 'en',
    badge: 'bottomright',
};

+1

+1

@rshk Thanks for sharing your version, seems to be working for me!

+1

+1

+1

+1

The problem is that this library is not following the newest Recaptcha API.
For example: react-recaptcha is basing on data-onloadcallbackname and data-verifycallbackname tag attributes for explicit rendering, but these attributes don't exist anymore. I don't know if this library was based on Recaptcha V1, but there are few properties that are doing completely nothing and these might be the reasons why it doesn't work at all.
I have some spare time tomorrow and I'll try to make this library compatible with the current Recaptcha API so it would work in all the cases described in the docs.

Btw, can I ask pretty please people finding this issue in the future to just click the "thumbs up" on the issue description, instead of commenting with just a +1?

Hey guys! It took me a little bit more time to make it happen, but it's here! My approach has some improvements comparing to this lib and most important - it works! 😄 🚀 What's awesome - you can have everything in your React component (not outside in some global variables). Verify callback also works like a charm!
Library: https://github.com/sarneeh/reaptcha
Example: https://sarneeh.github.io/reaptcha/
Hope it helps! 😄 🎉
If you'll encounter any problems, just file an issue - I'm available right now and will fix anything pretty fast. 💃

Same mistake for me

authors: AlinaPoluykova GlennSouthern Jiert Metrakit PaulRBerg SysOpsNet cemkiy pongpisit33009 rshk sarneeh

repo: appleboy/react-recaptcha

license_source: bigquery


text:
[Docs]: Performance best practices

Is there an existing issue for this?

[X] I have searched the existing issues

Engineering Ticket Link
N/A
Release Date
N/A
Release Number
N/A
First Draft
No response
Loom video
No response
Discord/slack/intercom Link if needed
No response
PRD
No response
Test plan/cases
No response
Use cases or user requests
Each framework or product has best practices in order to eke performance from that framework. Like our security docs, we should publish a document around best practices to improve the performance of Appsmith apps.
This includes:

Paginating queries
Performing aggregation on the server instead of pulling a lot of data to the browser.
Design multiple pages instead of loading a single page with many widgets.
Following best practices of JS code to avoid infinite loop or intensive computations.

Should be part of core concepts cc: @jnikhila @Pranay105

authors: danciaclara mohanarpit

repo: appsmithorg/appsmith-docs


text:
[Bug]: Internal server error is displayed when the user selects "Sheets" as datasource from Quick Page Wizard

Is there an existing issue for this?

[X] I have searched the existing issues

Description
When the user selects google sheets as datasources from the 'Quick Page Wizard' page internal server error is displayed.
Steps To Reproduce

Go to this url:- https://release.app.appsmith.com/applications
Click on New button and create your workspace
Click on Generate page from data table
Now on Quick Page Wizard select Sheets as your datasource from the dropdown
Observe the error

Actual Result
Internal server error is observed when "Sheets" as datasource is selected.
Expected Result
User should be able to select "Sheets" as datasource without any error.
Note
Please refer to the attached video:- https://jiju8jbmwa.vmaker.com/record/uQ4egV0MQPmIK7Jp
Public Sample App
No response
Version
Release

happens only some times, some observations:

each time this happened, it was for a new app
out of 10 tries, I saw the error 4 times

Removing release blocker tag since I am able to reproduce the same issue on prod as well with a older datasource. Primary investigation reveals that refresh token flow is failing on cloud services with the following error:
		Nov 4 13:50:25 cloudservice-7b9c6d7d4c-pvrc6 cloudservice requestId=0f30169dbb64e28319d03cca680d24d4 - Retrieving authentication response
		 - Unable to retrieve access token for integration 609126dbdb29e66d63d69c94 with error 400 BAD_REQUEST
		 -
		com.appsmith.internal.exceptions.AppsmithException: Internal server error while processing request
			at com.appsmith.cloudservices.services.IntegrationServiceImpl.lambda$refreshAccessToken$13(IntegrationServiceImpl.java:153)
			Suppressed: reactor.core.publisher.FluxOnAssembly$OnAssemblyException:
		Nov 4 13:50:25 cloudservice-7b9c6d7d4c-pvrc6 cloudservice Error Error has been observed at the following site(s):
			|_ checkpoint ⇢ Handler com.appsmith.cloudservices.controllers.IntegrationController#getAuthenticationResponse(Integration) [DispatcherHandler]
		Nov 4 13:50:25 cloudservice-7b9c6d7d4c-pvrc6 cloudservice trace Stack trace:
				at com.appsmith.cloudservices.services.IntegrationServiceImpl.lambda$refreshAccessToken$13(IntegrationServiceImpl.java:153)
				at reactor.core.publisher.MonoFlatMap$FlatMapMain.onNext(MonoFlatMap.java:118)
				at reactor.core.publisher.FluxHide$SuppressFuseableSubscriber.onNext(FluxHide.java:127)
				at reactor.core.publisher.FluxSwitchIfEmpty$SwitchIfEmptySubscriber.onNext(FluxSwitchIfEmpty.java:67)
....
....

More observations - I am unable to see the internal server error, however, though I am able to select the Spreadsheet, and the sheet, I get an error as per this image. And I see the same behavior on Prod too!!! This I am able to reproduce consistently.

Raised a separate bug for this issue

After the using the generate page functionality. The crud operations created when we leave tableHeaderIndex empty result in error. Here's a loom video :
Loom Video Link

authors: AmanAgarwal041 Richarex btsgh rohan-arthur sumitsum

repo: appsmithorg/appsmith


text:
[Bug]: Select widget value field shows error by default

Is there an existing issue for this?

[X] I have searched the existing issues

Description
When i connect a select field to label and value and refresh the page, i see the widget showing an error and value property showing an error
https://www.loom.com/share/5ed9b122fd13450b84324fcf0fefa1ac
Steps To Reproduce

Add a new select widget
Configure static data in any format, select the label and value key
Refresh the page
Observe the error in the select widget

Public Sample App
No response
Environment
Production
Issue video log
https://www.loom.com/share/5ed9b122fd13450b84324fcf0fefa1ac
Version
Cloud

Medium issue because UX is confusing, but has a really high reach. All apps where select and Multi select are used will now show errors.


text:
[Task]: Replace static wait in cypress/e2e/Regression/ClientSide/Autocomplete/BracketNotation_AC_spec.ts

SubTasks

This task will belong to all SDETS
Since @sharanya-appsmith @sarojsarab are also not able to fix the spec flakiness, creating this task for tracking.

Duplicate Task: https://github.com/appsmithorg/appsmith/issues/35134

authors: Aishwarya-U-R NilanshBansal


text:
fix: Allow "spaces" in theme names while saving and display a more relevant error message

Description
This PR intends to allow users to include "space(s)" in their theme name while creating/saving a new theme. Moreover, a new and more relevant error message is displayed which lets the user know what all is accepted in the theme name input.

No spaces allowed previously and now

Old and new error messages

Previously, while saving a new theme, we got an error if the name had any "space". However, Appsmith already has an in-house theme with a space in its name. 😄

"Water Lily" Theme

Fixes #14840
Type of change

Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Manually Tested

Few test cases

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes

/ok-to-test sha=9a8e982

/ok-to-test sha=cadbf38

Tested this PR and working as expected

/ok-to-test sha=f0610fe

/ok-to-test sha=f7510b2

/ok-to-test sha=f7510b2

/ok-to-test sha=68dd876

/ok-to-test sha=a77f9b1

/ok-to-test sha=a77f9b1

authors: Aishwarya-U-R chandannkumar dhruvikn somangshu


text:
fix: add expected structure example

Description
Added example structure to Post body data
Fixes #6364
Type of change

Bugfix (non-breaking change which fixes an issue)

Checklist:

[x] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes

Test coverage results :test_tube:
:white_circle: Total coverage has not changed
No changes to code coverage between the base branch and the head branch

@Tooluloope Verified that for API JSON body we have expected example structure

But for raw input we are still seeing only evaluated value

authors: Tooluloope YogeshJayaseelan


text:
Allow multiple sudoer groups

Fixes #62
Adds a list sudoGroups and deprecates the parameter sudoGroupName.
Checklist

[x] PR contains a single logical change (to build a better changelog).
[x] Update the documentation.
[x] Categorize the PR by setting a good title and adding one of the labels:
bug, enhancement, documentation, change, breaking, dependency
as they show up in the changelog.
[x] Link this PR to related issues or PRs.

If I wanted to be veery nitpicky: To preserve the exact same behavior as before we would need to remove sudoers from the list if sudoGroupName is set, but I think that's a bit of a pain to implement and might lead to some other edge case weirdness, so I think this solution is good enough.

I though of it but seems to be too much magic 😅


text:
Added a new tool (Snow)

Added a new Forensics Tool

Thanks. This has landed into master.

repo: apsdehal/awesome-ctf


text:
added a new feature to display age in year, months and days

Title :  added a new feature to display age in year, months and days
Issue No. : #121
ref: #121
Code Stack :

WELCOME TO METAVERSE !!!!! Thank you for your valid contribution.
Keep up the good work.

license: MIT


text:
[Bug]: Testimonial Third Card Image is not loading.

Is there an existing issue for this?

[X] I have searched the existing issues

Describe the bug
The Website is having an issue while loading the Image for testimonial third card. I have checked and I have investigated and found the root cause behind this. And was able to fix the issue for my system. @apu52 please assign me this task. ( #1496 )

Expected behavior
The Third Image for the testimonial should load as per the other two.
Add ScreenShots

On which device are you experiencing this bug?
Chrome, Windows
Record

[X] I have read the Contributing Guidelines
[X] I'm a GSSOC'24 contributor
[ ] I'm a VSOC'24 contributor
[X] I have starred the repository

@apu52 please assign this issue (#1496) to me.

@sneha056  this issue has already been solved . sorry to close this issue . but u can still make new issues on which u want to work on


text:
feat: add golang.org/x/tools/cmd/stringer

golang.org/x/tools/cmd/stringer: Stringer is a tool to automate the creation of methods that satisfy the fmt.Stringer interface
$ aqua g -i golang.org/x/tools/cmd/stringer

Thank you for your contribution!

$ aqua g golang/tools/stringer
- name: golang/tools/stringer@gopls/v0.9.4

version is invalid.
We have to use version_filter and version_source.

Moved the package directory according to the package name. 5ba3817e1af6aa480caf2b67e0b7b4698930e0cc

https://github.com/aquaproj/aqua-registry/pull/5972#issuecomment-1236103374
Fixed. 5ba3817e1af6aa480caf2b67e0b7b4698930e0cc
$ aqua g
- name: golang/tools/stringer@v0.1.12

To update this package by Renovate, we have to update aqua-renovate-config, because this requires github-tags datasource.
https://github.com/aquaproj/aqua-renovate-config

Sorry but this style guide is wrong.
I'll update.

Package name of go_install should be equivalent to Go's Module path
https://aquaproj.github.io/docs/reference/registry-style-guide#package-name-of-go_install-should-be-equivalent-to-gos-module-path

https://github.com/aquaproj/aquaproj.github.io/pull/175

Thanks for following along! I will check the documentation.

https://github.com/aquaproj/aqua-registry/pull/5972#issuecomment-1236104681
Oh, I found this isn't needed.
golang/tools is already updated by github-tags datasource.
https://github.com/aquaproj/aqua-renovate-config/blob/a625beb57a201d64bb3a9118b28b7ab1343f1852/default.json#L4-L35

Released. https://github.com/aquaproj/aqua-registry/releases/tag/v3.46.0

authors: suzuki-shunsuke takumin

repo: aquaproj/aqua-registry


text:
Add support for custom resource names

feat: Add support for custom resource names

Implement custom naming for firewall network
Update the aqua_gcp_projects_attachment module with new variables
Add validation for variables
Update examples and README with instructions for custom resource names
Implement tflint for code quality checks

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 2 committers have signed the CLA.:white_check_mark: Noamstrauss:x: github-actions[bot]You have signed the CLA already but the status is still pending? Let us recheck it.

authors: CLAassistant Noamstrauss

repo: aquasecurity/terraform-gcp-onboarding


text:
docs: restructuring docs like in Trivy

Description
I changed the docs similar to how we changed the Trivy docs.
One thing I am not happy with is the installation section, maybe we can move some of those docs somewhere else or maybe within getting-started I could add some files within a reference folder e.g. reference/troubleshooting.md
Thoughts?

Description
I changed the docs similar to how we changed the Trivy docs.
One thing I am not happy with is the installation section, maybe we can move some of those docs somewhere else or maybe within getting-started I could add some files within a reference folder e.g. reference/troubleshooting.md

@AnaisUrlichs sure,  shift docs as you think it should be I'm open minded for having  new look and feel

Maybe @itaysk can take a look, too -- I did not change that much.
Also, would wait until we merge the changes to the Trivy docs and then merge the ones here, too

@AnaisUrlichs LGTM 🚀  Please rebase the branch with upstream.

lgtm 🚀

authors: AnaisUrlichs chen-keinan

repo: aquasecurity/trivy-operator


text:
Update Plugin Artifacts Links for v0.141.10

Automated changes by create-pull-request GitHub action

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

repo: aquasecurity/trivy-plugin-aqua


text:
Deprecate/remove the Fabfile / bash install scripts

We have made great strides in Cabot distribution:

Cabot is now packaged in Pypi ;
we have an Ansible role
we have a Docker-compose setup

I don’t see any reason to use the Bash scripts now, and would suggest removing them.
Thoughts?

when trying to contribute on this project, I was quite confuse with (should I / how to) use the fabfile. If they don't help anymore, better removing them.

They should definitely be removed

What is the supported method of performing the equivalent of a 'fab backup'? I have been crafting an ansible playbook to deploy cabot via docker-compose, which is great, except that I have no way of (in a documented fashion that I can find) pulling data I create out of the containers - and the docs still reference doing backups by this old method, in the implicit sense of suggesting using fab here: http://cabotapp.com/use/configuration.html

See also http://cabotapp.com/use/operations.html , which explicitly mentions using 'fab backup'.

Try docker-compose exec db pg_dump cabot > cabot.sql

Using the framework in https://github.com/cabotapp/docker-cabot , the correct command is this (and thanks for the hints to get me started):
docker-compose exec postgres pg_dump -U postgres postgres > cabot.sql

@skylerbunny Thanks! I added this command verbatim to the Operations chapter :)

authors: JeanFred frankh skylerbunny thomasleveil

repo: arachnys/cabot

license: mit


text:
new entities in ogit/Automation needed

we need following things:

new entity ogit/Automation/DynamicEngineData
new connection of "ogit/contains" from: ogit/Automation/DynamicEngineData, to: ogit/Automation/DynamicEngineData
new connection from ogit/Automation/MARSNode to ogit/Automation/DynamicEngineData, Verb should be like the old "hasMARSData", now it can be "ogit/availableIn", "ogit/relates"???
new connection from ogit/Automation/AutomationIssue to ogit/Automation/DynamicEngineData, Verb could be "ogit/describes", "ogit/availableIn", "ogit/relates"? Pls take notice of the direction of the verbs

Please review and merge https://github.com/arago/OGIT/pull/185

done

authors: mglusiuk plarem

repo: arago/OGIT


text:
Geo functions does not contains any distance calculating function between two co-ordinates.

Hi,
I have seen ArangoDb docs but not find any function that calculates the distance between two coordinates in AQL queries. Might be there is but I have not seen yet.
I have a users and posts collection that contains the latitude and longitude. So when I fetch the posts, I want to calculate the distance between the current user and the posts with their respective coordinates.
arango 2.8.7 + NodeJs

We will add this during the 3.0.x release cycle. The current workaround is to install a user defined function as noted on stackoverflow.

Thanks for your reply @dothebart
Actually, I have started from few days on ArangoDb. I have not enough knowledge on it.
Can you please let me How I can add my own functions for AQL queries? Or Where I need to add these functions?
I have not seen any options on ArangoDB Web UI for same.

Hi @lalitlogical,
you can read more about user defined functions at https://docs.arangodb.com/AqlExtending/index.html
There is no GUI interface for defining these functions.

Hi @baslr
Where I need to put these functions?

You need to register it in the database as explained in the documentation. It won't be part of your NodeJS project.

Hi @CoDEmanX , @dothebart, @jsteemann
I have seen the doc but I have not cleared my queries as Where I will find these files where I need to put these functions? I have installed the ArangoDB with the brew on Mac Yosemite.
Actually, I have completed the Backend APIs for a project with OrientDB. But we found that it goes slow with more data. So we decide to move to another database as ArangoDB. So till now I have completed all feature with OrientDB. Which actually based on locations, distance etc. So I must need distance calculating function at any effort.
So anyone can help me to define this functions. Only let me know with the example that where I need to put these functions and rest work I will do myself.
Please help me.
Thanks

When you register an AQL function, the name, code and determinism flag are stored in the database system itself (_aqlfunctions system collection), by default in the _system database. You don't need any file with the function code.
https://youtu.be/xlFlawPHYkM
It's of advisable to write the code in a code editor and save it as file. You can require the code in arangosh in order to register the function, so that you don't have to type the entire code in arangosh or copy & paste respectively:
https://youtu.be/zxnNIqZlyJQ
You could theoretically delete the source file after registering, but you are better off to keep it in case you need to re-register the function or want to adjust the code (you will have to register the function again in order to update it).
Note that it's discouraged to edit the function code in the _aqlfunctions collection directly. As you can see in the video, there is a cache which results in the old code being used at first. After I restart the server, the new code is used. If you use the proper interface (.register(...)), that problem shouldn't occur.

Thanks for your reply @Simran-B
I have followed your steps and resolved my issue by creating my own AQL Functions.
/* distance.js */
'use strict';

function gdistance(latitude1, longitude1, latitude2, longitude2, radius) {
    if (Number.prototype.toRadians === undefined) {
	    Number.prototype.toRadians = function() { return this * Math.PI / 180; };
	}

    var lat1 = Number(latitude1), lon1 = Number(longitude1);
    var lat2 = Number(latitude2), lon2 = Number(longitude2);

    radius = (radius === undefined) ? 6371e3 : Number(radius);

    var R = radius;
    var φ1 = lat1.toRadians(), λ1 = lon1.toRadians();
    var φ2 = lat2.toRadians(), λ2 = lon2.toRadians();
    var Δφ = φ2 - φ1;
    var Δλ = λ2 - λ1;

    var a = Math.sin(Δφ/2) * Math.sin(Δφ/2)
          + Math.cos(φ1) * Math.cos(φ2)
          * Math.sin(Δλ/2) * Math.sin(Δλ/2);
    var c = 2 * Math.atan2(Math.sqrt(a), Math.sqrt(1-a));
    var d = R * c;

    return d / 1000;
}

module.exports = gdistance;

I have added the above functions as AQL function as below.
db._useDatabase("myDatabase");
var aqlfunctions = require("org/arangodb/aql/functions");
var f = require("/path/to/file/distance.js");
aqlfunctions.register("geo::gdistance", f, true)

In my queries I have used above function as below.
LET distance = geo::gdistance(user.latitude, user.longitude, @latitude, @longitude)
Again thanks @Simran-B for the reply. Actually, in ArangoDB docs, there are not mention about arangosh uses. So I have never found the way to add my own functions.
Thanks

@lalitlogical  afaik km -> to meter is multiply by 1000. 1km is 1000m.

@baslr I have wrongly written Vise-Versa :P

I have updated the above code for blank(undefined) values as below.
'use strict';

function gdistance(latitude1, longitude1, latitude2, longitude2, radius) {
    if (!latitude1 || !longitude1 || !latitude2 || !longitude2) {
        return null;
    };

    var lat1 = Number(latitude1), lon1 = Number(longitude1);
    var lat2 = Number(latitude2), lon2 = Number(longitude2);

    radius = (radius === undefined) ? 6371e3 : Number(radius);

    var R = radius;
    var φ1 = (lat1 * Math.PI / 180), λ1 = (lon1 * Math.PI / 180);
    var φ2 = (lat2 * Math.PI / 180), λ2 = (lon2 * Math.PI / 180);
    var Δφ = φ2 - φ1;
    var Δλ = λ2 - λ1;

    var a = Math.sin(Δφ/2) * Math.sin(Δφ/2)
          + Math.cos(φ1) * Math.cos(φ2)
          * Math.sin(Δλ/2) * Math.sin(Δλ/2);
    var c = 2 * Math.atan2(Math.sqrt(a), Math.sqrt(1-a));
    var d = R * c;     // Meters
    var d2 = d / 1000; // Meters to KM
    return d2;
}

module.exports = gdistance;

How can I do above for arangodb cluster service which contains the 2 coordinators, 2 dbservers etc on DC/OS under AWS Cloudformation?

@lalitlogical: What problem do you see when running DC/OS under AWS Cloudformation?

Hi @Simran-B, I am able to add my custom function below.

I had done sshuttle to access clusters to my local machine

sshuttle --python /opt/mesosphere/bin/python3.4 -r core@my-ip-address 10.0.0.0/8
Then I am able to access the arangodb service web ui on my browser with local ip address i.e. http://10.0.1.221:14170

Access the remote arangosh as below

arangosh --server.endpoint tcp://10.0.1.221:14170 --server.username root
Then I had registered the distance function as below.
db._useDatabase("GeoConnect");
var aqlfunctions = require("@arangodb/aql/functions");
var f = require("distance.js");
aqlfunctions.register("geo::gdistance", f, true)

Thanks, I'll add a note to the documentation that AQL UDFs need to be registered on the coordinator. How to get access to the server (sshuttle) seems a bit too specific to include it in the general documentation, but I'll check with the team.

Hi @dothebart,
Hope you remeber the issue of UDFs on Arangodb Cluster services. So I just want to know, is there any plan/roadmap to add this function under AQL in arangodb releases? Because our app totally depends on distance. So we can not modify our some aql queries that consume our resources and leads to issue.
https://github.com/arangodb/arangodb/issues/1947

authors: CoDEmanX Simran-B baslr dothebart lalitlogical

repo: arangodb/arangodb


text:
ArangoDB issue with server cores

my environment running ArangoDB
I'm using the latest ArangoDB of the respective release series:

[ ] 2.8
[ ] 3.0
[ x ] 3.1.27
[ ] 3.2
[ ] 3.3
[ ] self-compiled devel branch

Mode:

[ ] Cluster
[ x ] Single-Server

Storage-Engine:

[ ] mmfiles
[ x ] rocksdb

On this operating system:

[ ] DCOS on

[ ] AWS
[ ] Azure
[ ] own infrastructure

[ ] Linux

[ x ] Debian .deb
[ ] Ubuntu .deb
[ ] SUSE   .rpm
[ ] RedHat .rpm
[ ] Fedora .rpm
[ ] Gentoo
[ ] docker - official docker library
[ ] other:

[ ] Windows, version:
[ ] MacOS, version:

this is an AQL-related issue:
[ x ] I'm using graph features
I'm issuing AQL via:

[ ] web interface with this browser:     running on this OS:
[ ] arangosh
[ x ] this Driver: arangodb-php

Hi all,
We are experiencing a kind of weird problem. Our application runs on a cuad-core server for arangodb and sometimes is really slow (we have a pageTree graph with about 4.000 edges). We tried updating to octa-core in the virtual server, but it resulted to even slower and sometimes crashing the application. Does anyone have any idea regarding that? Are there any parameters in the configuration file that need changing when adding cores? I attach two images from my server htop before and after the change in cores.
Thank you all in advance

The above info indicates you are running 3.1.27 with the RocksDB engine, which is unlikely (RocksDB engine was introduced with version 3.2.0 first).
So I am assuming you are on 3.1.27 with the MMFiles engine (the only available storage engine there).
Is there any chance you can upgrade to a more recent version, e.g. 3.2.12 or 3.3.3?

Thank you again, the way I figured out that we use the RocksDB engine is that the LOCK file was created in the path /var/lib/arangodb3/rocksdb (sorry, I have started working with arangodb about 2 months ago). If the problem persists I will try the upgrade part, but the thing is that there are about 200 hotel sites on the DB and I am worried if something goes wrong on the upgrade, but if you think that is the only solution, we will try it.

Ah got it. I think 3.1 fires up a RocksDB instance at startup, but it is only used for a particular type of index ("persistent"). But the storage engine is MMFiles there. Since 3.2 the storage engine is switchable, and there are currently two engines available: MMFiles (the ever existing one) and RocksDB.
Regarding workload: what actually is going on on the server? Is it CPU-bound or I/O bound, or are there any other indications of high load or activity, slow queries etc.?

Regarding workload I am not really sure about the bound of the server, but if I had to guess I would say I/O bound. It is a web application that is based only on PHP and yii2 framework. Slow queries do exist and we are in the process of trying to fix them, but they are quite complicated and also include aql functions. However, the queries are always the same but when the system is changed from 4 to 8 cores the performance is deteriorated dramatically. Below you can see the configuration file for arangoDB
# ArangoDB configuration file
#
# Documentation:
# https://docs.arangodb.com/Manual/Administration/Configuration/
#

[database]
directory = /var/lib/arangodb3

maximal-journal-size = 33554432
###maximal-journal-size =   8388608

[http]
keep-alive-timeout=60

[server]
# Specify the endpoint for HTTP requests by clients.
#  tcp://ipv4-address:port
#  tcp://[ipv6-address]:port
#  ssl://ipv4-address:port
#  ssl://[ipv6-address]:port
#  unix:///path/to/socket
#
# Examples:
#   endpoint = tcp://0.0.0.0:8529
#   endpoint = tcp://127.0.0.1:8529
#   endpoint = tcp://localhost:8529
#   endpoint = tcp://myserver.arangodb.com:8529
#   endpoint = tcp://[::]:8529
#   endpoint = tcp://[fe80::21a:5df1:aede:98cf]:8529
#
endpoint = tcp://0.0.0.0:8529

# resuse a port on restart or wait until it is freed by the operating system
# reuse-address = false

authentication = true

# number of server threads. use 0 to make arangod determine the
# number of threads automatically, based on available CPUs
threads = 0

# gather server statistics
###statistics = true
statistics = false

# the user and group are normally set in the start script
# uid = arangodb
# gid = arangodb

uid = arangodb

[scheduler]
# number of threads used for I/O, use 0 to make arangod determine
# the number of threads automatically
# threads = 0

[javascript]
startup-directory = usr/share/arangodb3/js
app-path = /var/lib/arangodb3-apps
# app-path = @HOMEDRIVE@/@HOMEPATH@/arangodb3/apps

# number of V8 contexts available for JavaScript execution. use 0 to
# make arangod determine the number of contexts automatically.
# v8-contexts = 0

[foxx]
# enable Foxx queues in the server
# queues = true

# interval (seconds) to use for polling jobs in Foxx queues
# queues-poll-interval = 1

[log]
###level = info
level = error
file = /var/log/arangodb3/arangod.log

[wal]
logfile-size = 8388608
allow-oversize-entries = true
reserve-logfiles = 10
sync-interval=10000

@eafiontzi
How many databases have been on the server now ?

@georgekaf : that's indeed a good question...
@eafiontzi : can you let us know if the dataset fits into the server's available RAM (how big is the dataset on disk, how big is the server's physical RAM)? Can you also let us know what the main workload is (mainly reads/writes, complex queries/transactions vs. single document operations)? Without further information it is kind of hard to say what is going on. Thanks!

Thank you for your interest, the are about 110 databases on the server, the RAM is 8GB. Regarding the  workload besides arangodb we also have mysql and redis on the specific virtual machine. However the main workload as far as I can see from the processes is arango. There we mostly (about 80% of the time) we have complex queries and read/ writes in the database. For example, I paste below some of the slowest queries (some take up to 50sec, but that depents on the server workload. Most slow queries though have to do with the pageTree graph which consists of about 4000 edges.

LET params = { data: { pagePreview: @previewMode, pageStatus: @pageStatus, inSiteMap: @inSiteMap, rootPageId: @rootPageId, rootPageType: @rootPageType, returnRoot: @returnRoot, inSiteMapMismatch: @inSiteMapMismatch, statusMismatch: @statusMismatch, activeLanguageMismatch: @activeLanguageMismatch } } FOR v, e, p IN @minDepth..@maxDepth INBOUND @id pageTree LET filtered = CALL("cms3::getPageParentFilter", v, p, params) FILTER filtered == null LET d = CALL("cms3::getPageParentVisitor",v, e, p, params) RETURN d

LET params = { data: { pagePreview: @previewMode, langCode: @langCode, fallbackLangCode: @fallbackLangCode, searchLocalized: @searchLocalized, pageStatus: @pageStatus, inSiteMap: @inSiteMap, activeLanguageMismatch: @activeLanguageMismatch, pageAttrFilters: @pageAttrFilters, pageAttrSort: @pageAttrSort, pageFieldFilters: @pageFieldFilters, pageFieldSort: @pageFieldSort } }FOR v, dOr, p IN @minDepth..@maxDepth OUTBOUND @id pageTree LET d = CALL("cms3::getPageChildrenVisitor", v, dOr, p, params)FILTER d != null && (d.pageStd_typeKey==@filter0 ) SORT d.pageStd_depth ASC, d.pageStd_vOrder ASC LIMIT 0, 20 RETURN d

Any thoughts?

@eafiontzi can you execute vm_stat 1 as root and leet it run for a while and paste the output here?

Sorry for not replying earlier, I finally added two indexes in two collections and the workload was reduced significantly. It still does not explain why the 8 core system was causing more bottlenecks but seems to be stable for now.
Can I ask something about skiplist indexes here or should I close that issue and open a new one with different title?

Hi @eafiontzi
I am going to close this issue since you said that is stable now.
Regarding skiplist indexes, you can open another issue.
Best

authors: OmarAyo baslr eafiontzi georgekaf jsteemann


text:
Docs: Make scripts compatible with Python 3

https://python-future.org/compatible_idioms.html

[x] Transform with 2to3 script
[x] Review automatic transforms
[x] Optimize code
[x] Test scripts with Python 2
[ ] Test scripts with Python 3

https://jenkins01.arangodb.biz/view/Documentation/job/arangodb-ANY-examples/418/console
Python seems to be 2.7, not sure how to test 3.x on the same machine... change invocations to python3 or via shebang?

Looks like there is an encoding related error in python3:
https://jenkins01.arangodb.biz/view/Documentation/job/arangodb-ANY-examples/427/console
13:32:28 Generating swagger
13:32:28 while parsing '/work/ArangoDB/Documentation/DocuBlocks/Rest/Views/post_api_view_arangosearch.md'
13:32:28 trying to use handler 'skip_code'
13:32:28
13:32:28 while parsing file: '/work/ArangoDB/Documentation/DocuBlocks/Rest/Views/post_api_view_arangosearch.md' error: 'ascii' codec can't decode byte 0xe2 in position 1237: ordinal not in range(128)
13:32:28 Traceback (most recent call last):
13:32:28   File "/work/ArangoDB/utils/generateSwagger.py", line 1464, in <module>
13:32:28     getOneApi(infile, name + " - " + ', '.join(filenames), fn)
13:32:28   File "/work/ArangoDB/utils/generateSwagger.py", line 1311, in getOneApi
13:32:28     automat.run((infile, ''))
13:32:28   File "/work/ArangoDB/utils/generateSwagger.py", line 402, in run
13:32:28     raise x
13:32:28   File "/work/ArangoDB/utils/generateSwagger.py", line 390, in run
13:32:28     (newState, cargo) = handler(cargo)
13:32:28   File "/work/ArangoDB/utils/generateSwagger.py", line 1274, in skip_code
13:32:28     return comment((fp, last), r)
13:32:28   File "/work/ArangoDB/utils/generateSwagger.py", line 1252, in comment
13:32:28     line = fp.readline()
13:32:28   File "/usr/lib/python3.6/encodings/ascii.py", line 26, in decode
13:32:28     return codecs.ascii_decode(input, self.errors)[0]
13:32:28 UnicodeDecodeError: 'ascii' codec can't decode byte 0xe2 in position 1237: ordinal not in range(128)
13:32:28
13:32:28 During handling of the above exception, another exception occurred:
13:32:28
13:32:28 Traceback (most recent call last):
13:32:28   File "/work/ArangoDB/utils/generateSwagger.py", line 1467, in <module>
13:32:28     raise Exception("while parsing file '%s' error: %s" %(thisfn, x))
13:32:28 Exception: while parsing file '/work/ArangoDB/Documentation/DocuBlocks/Rest/Views/post_api_view_arangosearch.md' error: 'ascii' codec can't decode byte 0xe2 in position 1237: ordinal not in range(128)
13:32:28 FAILED!

18:39:12 Automatic merge failed; fix conflicts and then commit the result. ?!
https://jenkins01.arangodb.biz/view/Documentation/job/arangodb-ANY-examples/431/console

No errors in my test run using https://github.com/arangodb/oskar/tree/python3-compat and https://github.com/arangodb/arangodb/pull/10320/commits/426bca5acece8b6cda63d6258096f7f9ecfc6382
https://jenkins01.arangodb.biz/view/Documentation/job/arangodb-ANY-examples/449/console
https://github.com/arangodb/docs/pull/246

It looks like generateLicense.py was already broken in both Python 2 and 3?!
Fails with py2 because of str(response.read(), "utf-8", "ignore") - looks like the 3 argument variant is py3 only?
Fails with py3 because strings are passed to html.startswith(…) but html is a bytes object.

Failing in Jenkins:
[
17:41:39   "utils/generateExamples.py",
17:41:39   "--outputDir",
17:41:39   "/work/ArangoDB/Documentation/Examples",
17:41:39   "--outputFile",
17:41:39   "/work/ArangoDB/arangosh.examples.js",
17:41:39   "--arangoshSetup",
17:41:39   "/work/ArangoDB/Documentation/Scripts/setup-arangosh.js",
17:41:39   "/work/ArangoDB/Documentation/DocuBlocks",
17:41:39   "/work/ArangoDB/Documentation/Books/Manual",
17:41:39   "/work/ArangoDB/Documentation/Books/AQL",
17:41:39   "/work/ArangoDB/Documentation/Books/HTTP",
17:41:39   "--storageEngine",
17:41:39   "mmfiles",
17:41:39   "--storageEngineAgnostic",
17:41:39   false,
17:41:39   "--cluster",
17:41:39   false
17:41:39 ]
17:41:39 Traceback (most recent call last):
17:41:39   File "utils/generateExamples.py", line 738, in <module>
17:41:39     loopDirectories()
17:41:39   File "utils/generateExamples.py", line 697, in loopDirectories
17:41:39     analyzeFile(f, filename)
17:41:39   File "utils/generateExamples.py", line 281, in analyzeFile
17:41:39     for line in f:
17:41:39   File "/usr/lib/python3.6/encodings/ascii.py", line 26, in decode
17:41:39     return codecs.ascii_decode(input, self.errors)[0]
17:41:39 UnicodeDecodeError: 'ascii' codec can't decode byte 0xe2 in position 1237: ordinal not in range(128)
17:41:39 parsing the examples failed - aborting!
17:41:39 {
17:41:39   "pid" : 83,
17:41:39   "status" : "TERMINATED",
17:41:39   "exit" : 1
17:41:39 }

Might have to specify utf-8 encoding on open (io.open for compatibility). Does the newline option matter in generateExamples.py?

https://jenkins01.arangodb.biz/view/Documentation/job/arangodb-ANY-examples/579/

@jsteemann Jenkins run succeeded. Good enough to merge IMO. Should we get into trouble again then we can fix that later.


text:
Removing debuggerInfo dereference

Scope & Purpose
This causes some tests to fail.

[x] :hankey: Bugfix
[ ] :pizza: New feature
[ ] :fire: Performance improvement
[ ] :hammer: Refactoring/simplification

Red Jenkins is unrelated to this fix. Ready to go

authors: apetenchea mchacki


text:
documentCollection.documentExists checks the whole database instead of the given collection

When checking if a document exists in a collection, I use the function documentCollection.documentExists. For example:
const cities = db.collection("City")
const city_exists = await cities.documentExists("Country/1234")
console.log("city_exists = ", city_exists)

But instead of looking only in the specific "City" collection, it finds documents from other collections (like "Country") too.
ArangoJS version: 6.10.0

This was originally intentional but I agree that it's confusing. This also affects other methods that accept IDs instead of keys. I think the most straightforward way would be to remove this special handling so these methods only take keys and provide db.document and db.documentExists as variants that only take IDs. This would be a breaking change.

This will be addressed in the upcoming major release.

authors: neumann-d pluma

repo: arangodb/arangojs


text:
🛑 Test loibra.moo.com is down

In 43b849d, Test loibra.moo.com (http://loibra.mooo.com/) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Test loibra.moo.com is back up in 8af6b2f.

repo: aratan/Monitorizaci-n


text:
UI/UX Updates

I've made some updates to the Wireframes

[ ] 1. A section with sources with updated design.

From left to right the source labels depict different state: 1. Selected 2. Hovered 3. Inactive

[ ] 2. Clickable suggested follow-up questions

On click a message from the user will be automatically sent and visible in that chat as if the user sent it. After clicking any suggested question, the suggested questions will dissapear and a new set of them will generate under the last response by DocsGPT
if the question is to long, the label wraps and the corners get clightly less rounded:

[x] 3. Rounded up the corners for consistency (highlighted in yellow)

Same for all of the buttons

[ ] 4. Updated Empty state chat screen

Mobile

Hit me up on Discord with @Nick for review and questions.

Hey, I'd like to work on task 3 and 4. Could this be assigned to me?

Yep, absolutely, Thank you, if you have any questions please dont hesitate to contact me

Hey,
Since 3rd and 4th task is already completed can I take up 1st and 2nd point given in description. Can it be assigned to me

Absolutely, that would be great!

Hey! I've created a PR for the first task that isn't complete yet.
Could someone please review it, thanks.

Hey, can I pick up 4th task if it's not completed and no one's working on it?

authors: DenyTwice dartpain lakshmi930 siiddhantt tenokami vikaschouhan97


text:
🛑 ARCaptcha is down

In f4f41d7, ARCaptcha (https://arcaptcha.co/fa) was down:

HTTP code: 502
Response time: 1759 ms

Resolved: ARCaptcha is back up in 98aa32c.

repo: arcaptcha/ARCaptcha-monitoring


text:
🛑 ARCaptcha API is down

In 0ac6b8c, ARCaptcha API (https://api.arcaptcha.ir/arcaptcha/api/heartbeat) was down:

HTTP code: 502
Response time: 872 ms

Resolved: ARCaptcha API is back up in efff42d.


text:
🛑 ARCaptcha S3 is down

In c3145bb, ARCaptcha S3 (https://api.arcaptcha.ir/arcaptcha/api/s3) was down:

HTTP code: 0
Response time: 0 ms

Resolved: ARCaptcha S3 is back up in 0e3d257 after 17 minutes.


text:
希望Cascader和Select可以像TreeSelect一样通过传入field-names指定数据中的字段名

[ ] I'm sure this does not appear in the issue list of the repository

Basic Info
What are the similar cases of this feature
What problem does this feature solve?
我觉得TreeSelect中可以传入field-names指定数据中的字段名是一个非常好用的功能，希望Cascader和Select也能加上

@wehuss 好的，这个后面会支持下

authors: Flsion wehuss

repo: arco-design/arco-design-vue


text:
Sql Database scripting

First version of the Sql update script, let me know what you think!
This is according to task #93

Thanks for these additions!
Would you be able to add some tests as well?

What is the .psd1 file ?  It's a binary file so does it belong in the repo ?

Not sure why GH is behaving in such a way, but it's in fact a readable file.
It's the manifest module in a PowerShell data file, which indicates all details, release info, dependencies,... used during release to the PS gallery.

What is the .psd1 file ?  It's a binary file so does it belong in the repo ?

Not sure why GH is behaving in such a way, but it's in fact a readable file.
It's the manifest module in a PowerShell data file, which indicates all details, release info, dependencies,... used during release to the PS gallery.

Yes, what he said.
@fgheysels , maybe this helps: https://github.com/arcus-azure/arcus.scripting/blob/feature/databaseupdatescript/src/Arcus.Scripting.SQL/Arcus.Scripting.SQL.psd1

authors: gverstraete mbraekman stijnmoreels


text:
Duplicate Azure DevOps Build as GitHub Action

Take the work being done in Azure DevOps currently and migrate it to do the same thing in GitHub actions.

Done!

repo: ardalis/Specification


text:
Model filenames get truncated when they contain multiple '.' characters in the filename when using the Toolkit tab.

Similar issue to https://github.com/arenasys/stable-diffusion-webui-model-toolkit/issues/27, but was not fixed for the Toolkit tab.
There exists this line in scripts/toolkit_gui.py's get_name(tm, arch) function on line 367:
name = os.path.basename(tm.filename).split(".")[0]
it should read something like this:
name = os.path.basename(tm.filename).rsplit(".", 1)[0]

I created a pull request with the change in it. The actual change is 1 line, but my editor decided to eliminate trailing whitespace so that's why there are so many lines touched.


text:
Error when try to read https feed in podcast module

Banshee/podcast show "network error"  when try to check https feed for new episodes

Could you attach a log made with the --debug switch?
Alternatively a test feed URL so I can reproduce would be great?

switch --debug show nothing special.
Try add for example this
https://latenightlinux.com/feed/mp3

That feed loads okay for me - what mono version are you running with?

Mono JIT compiler version 4.6.2
bellow list of installed pkg:
libmono-addins-gui0.2-cil/bionic,bionic,now 1.0+git20130406.adcd75b-4 all [zainstalowany]
libmono-addins-msbuild0.2-cil/bionic,bionic,now 1.0+git20130406.adcd75b-4 all [zainstalowany]
libmono-addins0.2-cil/bionic,bionic,now 1.0+git20130406.adcd75b-4 all [zainstalowany,automatycznie]
libmono-cairo4.0-cil/bionic,bionic,now 4.6.2.7+dfsg-1ubuntu1 all [zainstalowany,automatycznie]
libmono-corlib4.5-cil/bionic,bionic,now 4.6.2.7+dfsg-1ubuntu1 all [zainstalowany,automatycznie]
libmono-csharp4.0c-cil/bionic,bionic,now 4.6.2.7+dfsg-1ubuntu1 all [zainstalowany,automatycznie]
libmono-data-tds4.0-cil/bionic,bionic,now 4.6.2.7+dfsg-1ubuntu1 all [zainstalowany,automatycznie]
libmono-i18n-west4.0-cil/bionic,bionic,now 4.6.2.7+dfsg-1ubuntu1 all [zainstalowany,automatycznie]
libmono-i18n4.0-cil/bionic,bionic,now 4.6.2.7+dfsg-1ubuntu1 all [zainstalowany,automatycznie]
libmono-ldap4.0-cil/bionic,bionic,now 4.6.2.7+dfsg-1ubuntu1 all [zainstalowany,automatycznie]
libmono-microsoft-build-framework4.0-cil/bionic,bionic,now 4.6.2.7+dfsg-1ubuntu1 all [zainstalowany,automatycznie]
libmono-microsoft-build-utilities-v4.0-4.0-cil/bionic,bionic,now 4.6.2.7+dfsg-1ubuntu1 all [zainstalowany,automatycznie]
libmono-posix4.0-cil/bionic,bionic,now 4.6.2.7+dfsg-1ubuntu1 all [zainstalowany,automatycznie]
libmono-profiler-gui-thread-check/bionic,now 2.99.3-2 amd64 [zainstalowany,automatycznie]
libmono-security4.0-cil/bionic,bionic,now 4.6.2.7+dfsg-1ubuntu1 all [zainstalowany,automatycznie]
libmono-sharpzip4.84-cil/bionic,bionic,now 4.6.2.7+dfsg-1ubuntu1 all [zainstalowany,automatycznie]
libmono-sqlite4.0-cil/bionic,bionic,now 4.6.2.7+dfsg-1ubuntu1 all [zainstalowany]
libmono-system-configuration4.0-cil/bionic,bionic,now 4.6.2.7+dfsg-1ubuntu1 all [zainstalowany,automatycznie]
libmono-system-core4.0-cil/bionic,bionic,now 4.6.2.7+dfsg-1ubuntu1 all [zainstalowany,automatycznie]
libmono-system-data4.0-cil/bionic,bionic,now 4.6.2.7+dfsg-1ubuntu1 all [zainstalowany,automatycznie]
libmono-system-drawing4.0-cil/bionic,bionic,now 4.6.2.7+dfsg-1ubuntu1 all [zainstalowany,automatycznie]
libmono-system-enterpriseservices4.0-cil/bionic,bionic,now 4.6.2.7+dfsg-1ubuntu1 all [zainstalowany,automatycznie]
libmono-system-numerics4.0-cil/bionic,bionic,now 4.6.2.7+dfsg-1ubuntu1 all [zainstalowany,automatycznie]
libmono-system-runtime-serialization4.0-cil/bionic,bionic,now 4.6.2.7+dfsg-1ubuntu1 all [zainstalowany,automatycznie]
libmono-system-security4.0-cil/bionic,bionic,now 4.6.2.7+dfsg-1ubuntu1 all [zainstalowany,automatycznie]
libmono-system-servicemodel-internals0.0-cil/bionic,bionic,now 4.6.2.7+dfsg-1ubuntu1 all [zainstalowany,automatycznie]
libmono-system-transactions4.0-cil/bionic,bionic,now 4.6.2.7+dfsg-1ubuntu1 all [zainstalowany,automatycznie]
libmono-system-xml-linq4.0-cil/bionic,bionic,now 4.6.2.7+dfsg-1ubuntu1 all [zainstalowany,automatycznie]
libmono-system-xml4.0-cil/bionic,bionic,now 4.6.2.7+dfsg-1ubuntu1 all [zainstalowany,automatycznie]
libmono-system4.0-cil/bionic,bionic,now 4.6.2.7+dfsg-1ubuntu1 all [zainstalowany,automatycznie]
libmono-upnp-cil/bionic,bionic,now 0.1.2-2build1 all [zainstalowany]
libmono-zeroconf1.0-cil/bionic,bionic,now 0.9.0-6 all [zainstalowany,automatycznie]
libmonoboehm-2.0-1/bionic,now 4.6.2.7+dfsg-1ubuntu1 amd64 [zainstalowany,automatycznie]
mono-4.0-gac/bionic,bionic,now 4.6.2.7+dfsg-1ubuntu1 all [zainstalowany,automatycznie]
mono-addins-utils/bionic,bionic,now 1.0+git20130406.adcd75b-4 all [zainstalowany]
mono-gac/bionic,bionic,now 4.6.2.7+dfsg-1ubuntu1 all [zainstalowany,automatycznie]
mono-runtime/bionic,now 4.6.2.7+dfsg-1ubuntu1 amd64 [zainstalowany,automatycznie]
mono-runtime-common/bionic,now 4.6.2.7+dfsg-1ubuntu1 amd64 [zainstalowany,automatycznie]
mono-runtime-sgen/bionic,now 4.6.2.7+dfsg-1ubuntu1 amd64 [zainstalowany,automatycznie]

repo: arfbtwn/banshee


text:
Dataset cards and metadata generation for Hub

Resources

The HF dataset card creator app: https://huggingface.co/datasets/card-creator/
The HF dataset card template: https://raw.githubusercontent.com/huggingface/datasets/master/templates/README.md

Description
The HF dataset card contains a set of fields we will easily expose when publishing an RB dataset into the HF hub.

As a starting point, we can provide tools for:

manual configuring some dataset tags (task, task category, language,...)
automatic configuring tag like size
manual a dataset summary/description
automatically generate a basic dataset structure - all RB datasets should keep the same general schema.

please @dvsrepo @dcfidalgo confirm the issue spec.

I´ve created an example here.
https://huggingface.co/datasets/argilla/uber-reviews/blob/main/README.md

Also, train-test splits are not taken into account based on metadata. our release twitter-coronavirus vs argilla/twitter-coronavirus on the hub.

This is already covered in the new FeedbackDatasets. Is this something we want to expand to other datasets or are we ok closing this issue @dvsrepo ?

Well spotted, we can close this 🎆

authors: davidberenstein1957 dvsrepo nataliaElv

repo: argilla-io/argilla


text:
ApplicationSet CRD size reduction, by removing validation (CRD defn) of nested merge/matrix generator

Problem
The large increase in the size of the ApplicationSet CRD has caused a couple significant issues:

Controller/operator bundling tools, such as OLM, are unable to package CRDs that are this large. Even though the CRD is less than the size supported by kubectl apply and/or the underlying etcd db, the overall size still exceeds this threshold when packaged together with other CRDs plus additional controller installation metadata, as is the case with OLM.
See EDIT below. Original text: When kubectl applying changes to the new ApplicationSet CRD, @jannfis observed that kubectl was stuck for 10+ minutes in trying to apply that CRD (and using a lot of CPU while doing so). This implies that the operation of diffing the structures of the old and new CRD is complex enough to make supporting a CRD this large potentially unworkable.

EDIT: Got an update from @jannfis that he might have had an older kubectl binary that had this issue, which is our guess on what caused the excess CPU usage and long wait time issues. (I had seen this same issue previously, so it is unrelated to the CRD size.). So probably not related to the recent changes.

Proposed solution
Our proposed solution is to remove validation (e.g. OpenAPI type information) from the nested Matrix/Merge generator (NestedMergeGenerator/NestedMatrixGenerator in the code) objects in the CRD. We would convert them to apiextensionsv1.JSON in the corresponding Go structs, which controller-gen will convert into type: object in the OpenAPI schema.

The nested fields will still be validated, but rather than failing on resource creation (e.g. kubectl apply), instead the ApplicationSet controller will report an error (in the console log, and in status condition)  when the format of these fields cannot be unmarshalled to the expected structure.
This does not affect non-nested Merge/Matrix generator scenarios, which work as before.

Since nesting a merge/matrix generator within another merge/matrix generator is IMHO an advanced feature, my expectation is that users using the functionality are likely to have the wherewithal to fix validation problems in the fields if they arise, e.g. without requiring explicit CR validation on resource creation.
This reduces the size of the ApplicationSet CRD from 836KB to 341KB. This is smaller than the size of the CRD in v0.2.0 (but, this is not an apples-to-apples comparison, because the v0.2.0 CRD included the description fields, whereas v0.3.0 still does not).

Should we look at restoring the description fields, since those shouldn't affect CPU load?

@crenshaw-dev We're now much less convinced it's a CPU issue, now that we found a kubectl that seems related. I've edited the problem description text with the details. So it's mainly just an issue with the overall size (in KB of text), and the description fields would probably add to that.

authors: crenshaw-dev jgwest

repo: argoproj/applicationset


text:
Pods do not get deleted on success/failure

Checklist:

[x] I've included the version.
[x] I've included reproduction steps.
[x] I've included the workflow YAML.
[ ] I've included the logs.

What happened:
I am trying to implement GC strategy to delete pods automatically after workflow is done. However, podsdon't get deleted. I've tried with all strategy options (see), but result is the same.
What you expected to happen:
Workflows should be deleted after Success or failure.
How to reproduce it (as minimally and precisely as possible):
Submit following workflow with argo CLI.
Anything else we need to know?:
Workflow.yaml
apiVersion: argoproj.io/v1alpha1
kind: Workflow                  # new type of k8s spec
metadata:
  generateName: nirav-test-    # name of the workflow spec
spec:
  podGC:
    strategy: OnPodCompletion
  entrypoint: pod-gc-strategy          # invoke the whalesay template
  templates:
  - name: pod-gc-strategy
    steps:
    - - name: fail
        template: fail
      - name: succeed
        template: succeed

  - name: fail
    container:
      image: alpine:3.7
      command: [sh, -c]
      args: ["exit 1"]

  - name: succeed
    container:
      image: alpine:3.7
      command: [sh, -c]
      args: ["exit 0"]

Environment:

Argo version:

argo: v2.4.2
  BuildDate: 2019-10-21T18:39:52Z
  GitCommit: 675c66267f0c916de0f233d8101aa0646acb46d4
  GitTreeState: clean
  GitTag: v2.4.2
  GoVersion: go1.11.5
  Compiler: gc
  Platform: darwin/amd64

Kubernetes version :

clientVersion:
  buildDate: "2019-10-15T12:11:03Z"
  compiler: gc
  gitCommit: 211047e9a1922595eaa3a1127ed365e9299a6c23
  gitTreeState: clean
  gitVersion: v1.14.8
  goVersion: go1.12.10
  major: "1"
  minor: "14"
  platform: darwin/amd64
serverVersion:
  buildDate: "2019-11-07T19:12:22Z"
  compiler: gc
  gitCommit: 56d89863d1033f9668ddd6e1c1aea81cd846ef88
  gitTreeState: clean
  gitVersion: v1.13.11-gke.14
  goVersion: go1.12.11b4
  major: "1"
  minor: 13+
  platform: linux/amd64

I feel like I have also seen this unexpected behaviour.

Introduced in #1234

Unable to repro on master (v2.5)
@nirav24 this is a new feature. Can I ask you to upgrade to v2.4.3 and see if the issue still occurs?
@jackywu do you want to chime in on this feature as you authored it originally?
I wonder if it is possible for a workflow to complete before a pod is ready to be GCd? I'd noted you can delete a workflows, but PodGC does not happen.

I've linked a PoC fix for my hypothetical issue with this.

Thanks @alexec for the quick reply. I will update argo and try it again. Also, I will update the logs as well.

I am including output requested below
$ kubectl get wf nirav-test-wfrdn -n test-nirav
NAME               AGE
nirav-test-wfrdn   2m

kubectl get pod -l workflows.argoproj.io/workflow=nirav-test-wfrdn -n test-nirav
NAME                          READY   STATUS      RESTARTS   AGE
nirav-test-wfrdn-1910956530   0/2     Error       0          2m46s
nirav-test-wfrdn-2175938526   0/2     Completed   0          2m46s

I will upgrade argo to v2.4.3 and update the result.

Thank you @nirav24 - great! @jackywu and @jessesuen what do you think to my comments above please?

@nirav24 I've come back to this and I need to clarify something really important.
PodGC only applies to pods, not to workflows - there is no GC for workflows. It is actually not clear from the title of this issue whether or not you are referring to pods, to workflows, or to both.

@alexec I am referring to both. I can see pods with kubectl get pods and workflows with argo list

@nirav24 @alexec yes, there is no GC for workflow.

Sorry for the wrong title. I've changed it.

Ok. You're running an older version. Have you tried in v2.4.3 or v2.5.0-rc9 (if you're on a test environment - but this is a big change!)

I've tried with v2.4.3. I can try with v2.5.0-rc9 as well.

@alexec sorry for super delay on this. I've tried with v2.5.0-rc9. Argo deletes pod based on given strategy.
I am not sure to keep this issue open since it did not work with v2.4.3 or it was not suppose to work.

@jackywu it does sound like there is a bug with this feature - is this something you'd want to own investigating or fixing?

@jackywu it does sound like there is a bug with this feature - is this something you'd want to own investigating or fixing?

Sure. I'll try investigating it.

I'm so sorry, I don't have enough time to  investigate it right now.  @jessesuen , do you have time to check it.

authors: alexec jackywu nirav24

repo: argoproj/argo


text:
Support resource references

This PR adds support for resource references, where one resource is also known under another name - and references to those other names will be fixed to the correct updated name.
This is useful for generated resources which are referenced by a generic name, but are later generated by a hashed name - and references need to switch to using the hashed name.
Closes #15

Duplicates:

arikkfir/kude#20
arikkfir/kude#22
arikkfir/kude#23
arikkfir/kude#24
arikkfir/kude#25
arikkfir/kude#27

repo: arikkfir/kude


text:
[Bug] Adapter throws exception

[ ] iOS
[x] Android
[ ] UWP
[ ] .NET Standard

Version of Library
6.2.6
Version of OS(s) listed above with issue
Android 8.0 (API Level 26 - Oreo)
Steps to Reproduce

Accessing CrossBleAdapter.Current or CrossBleAdapter.AdapterScanner.IsSupported

Expected Behavior
Returns Current Adapter / bool value if the Adapter scan is supported
Actual Behavior
Throws exception
For CrossBleAdapter.Current
{System.Reflection.TargetInvocationException: Exception has been thrown by the target of an invocation. ---> System.ArgumentException: [Plugin.BluetoothLE] No platform plugin found.  Did you install the nuget package in your app project as well?
at Plugin.BluetoothLE.CrossBleAdapter.get_AdapterScanner () [0x00007] in C:\dev\acr\bluetoothle\Plugin.BluetoothLE\CrossBleAdapter.cs:14
CrossBleAdapter.AdapterScanner.IsSupported
{System.Reflection.TargetInvocationException: Exception has been thrown by the target of an invocation. ---> System.ArgumentException: [Plugin.BluetoothLE] No platform plugin found.  Did you install the nuget package in your app project as well?
at Plugin.BluetoothLE.CrossBleAdapter.get_Current () [0x00007] in C:\dev\acr\bluetoothle\Plugin.BluetoothLE\CrossBleAdapter.cs:28

You need to ensure your android target meets the use nuget package target of 8.1

Then I guess it would be appropriate to fix the support in the readme.md where is stated version 4.3

4.3 is supported.  Set the target to 8.1+

repo: aritchie/bluetoothle


text:
A lot of requests to web pages -> phantom crashes

I'm writing a tool to automate a sitemap creation for webpages.
If the webpage has many subpages (> ~100) phantomjs crashes every time. Is there a problem with the memory and request amount?
Is it possible to limit the request amount, or to queue the requests?
Phantom.JS is AWESOME!

Please upgrade to PhantomJS 2. 1.9.x is no longer supported, and known to have many crasher bugs that are fixed in 2 version.

authors: Vitallium frankred

repo: ariya/phantomjs


text:
Renderbase64 doesn't always honor viewport height

I am unsure how to test this directly but here are the steps to reproduce the problem through webdriver for both phantomjs 1.9.8 and phantomjs2.0@05d7e3e :
SESSIONID=`curl -s -X POST -d '{"requiredCapabilities":{},"desiredCapabilities":{}}' localhost:8000/session | jq -r '.sessionId'`
curl -s -X POST -d '{"url":"https://openoox.com"}' localhost:8000/session/$SESSIONID/url | jq '.'
curl -s -X POST -d '{"width":1280,"height":768}' localhost:8000/session/$SESSIONID/window/current/size | jq '.'
curl -s -X GET localhost:8000/session/$SESSIONID/window/current/size | jq '.'
#{
#  "sessionId": "50cee280-9b42-11e4-9a9d-d75c0f3f8c5a",
#  "status": 0,
#  "value": {
#    "height": 768,
#    "width": 1280
#  }
#}
curl -s -X GET localhost:8000/session/$SESSIONID/screenshot | jq -r '.value' | base64 -D >/tmp/screenshot.png

file /tmp/screenshot.png
# /tmp/screenshot.png: PNG image data, 1280 x 1333, 8-bit/color RGBA, non-interlaced

As you can see the window size is set ( https://github.com/ariya/phantomjs/blob/48fabe06463460d2fb7026d6df9783216e26265c/src/ghostdriver/request_handlers/session_request_handler.js#L285 ) and reported  by viewportSize ( https://github.com/ariya/phantomjs/blob/48fabe06463460d2fb7026d6df9783216e26265c/src/ghostdriver/request_handlers/session_request_handler.js#L294 )  to be
 {
   "height": 768,
    "width": 1280
 }

yet the screenshot rendered by  base64 ( https://github.com/ariya/phantomjs/blob/48fabe06463460d2fb7026d6df9783216e26265c/src/ghostdriver/request_handlers/session_request_handler.js#L468 ) ends up being 1280 x 1333.
failing websites :

https://openoox.com
http://lemonde.fr
https://facebook.com
https://plus.google.com
https://github.com
https://yahoo.com
https://flickr.com

working websites :

https://google.com
https://pinterest.com
https://twitter.com

This is linked to #10217 which is considered fixed by d844d540.  This will cause render to only consider the size of the content of the window (which will be influenced by viewport width but not by its height).
Digging some more, it seems there is a clipRect method available in the phantomJs API which would enforce the viewport size when  rendering the screenshot.
This is not used by the embedded webdriver implementation when getting a screenshot. Unfortunately,  the webdriver JsonWireProtocol doesn't offer an option which could be used to distinguish wether to clip or not when taking a screenshot.
I have opened https://code.google.com/p/selenium/issues/detail?id=8384 to request an enhancement to the wire protocol to help decide whether to clip or not to clip.

it seems the situation is evolving on this, the json  wire protocol is now a w3c project and they are currently changing the takeScreenshot specification to capture viewport instead of full page (see
https://github.com/w3c/webdriver/pull/98 and https://github.com/SeleniumHQ/selenium/issues/646#issuecomment-111043913)


text:
config.json "proxy-type" : "socks5" doesn't change proxy type

PhantomJS 2.0, Windows 7 x64
I'm testing a script that loads a page over TOR and console.logs its content.
Here's my config.json:
{"proxy": "localhost:9050", "proxy-type": "socks5"}
If I run phantomjs --config=config.json test.js, I'm getting Tor is not an HTTP Proxy,
but if I run phantomjs --proxy=localhost:9050 --proxy-type=socks5 test.js I'm getting page source as expected, so I guess that the relevant option in config.json doesn't affect the proxy type.
I've been told that it should indeed be "proxy-type" and not "proxyType" as I first assumed (see issue #13839)

Thanks for the bug report.  I agree this is a bug, and we don't need anything more from you before we can investigate, but, FYI, we are very short on developer manpower right now and can't promise a fix soon.  If you feel up to digging into it and sending us a pull request, that may well get things done faster.

Ok, thank you! I will consider that.

authors: mitsukuri zackw


text:
Cont3xt with OIDC crashes while redirecting

Describe the bug
Cont3xt crashes when using OIDC auth after successful login with the OIDC provider. Cont3xt attempts to redirect to original URL put tries to access an undefined field on the request object.
/opt/arkime/common/auth.js:780
          if (req.body.ogurl) {
                       ^

TypeError: Cannot read properties of undefined (reading 'ogurl')
    at /opt/arkime/common/auth.js:780:24
    at complete (/opt/arkime/node_modules/passport/lib/middleware/authenticate.js:271:13)
    at /opt/arkime/node_modules/passport/lib/middleware/authenticate.js:278:15
    at pass (/opt/arkime/node_modules/passport/lib/authenticator.js:428:14)
    at Authenticator.transformAuthInfo (/opt/arkime/node_modules/passport/lib/authenticator.js:450:5)
    at /opt/arkime/node_modules/passport/lib/middleware/authenticate.js:275:22
    at /opt/arkime/node_modules/passport/lib/http/request.js:41:7
    at /opt/arkime/node_modules/passport/lib/sessionmanager.js:51:9
    at /opt/arkime/common/auth.js:1143:7
    at onBody (/opt/arkime/node_modules/@elastic/elasticsearch/lib/Transport.js:320:9)

Elasticsearch version: 8.8.2
Arkime/Moloch version: 5.1.0
OS name and version: Ubuntu 20.04
How was Arkime/Moloch built/installed: (rpm, deb, easybutton, ...) easybutton
Provide logs, stack traces and steps to reproduce:

Enable OIDC auth
Try to login
Cont3xt returns a 500 and crashes with the following log

/opt/arkime/common/auth.js:780
          if (req.body.ogurl) {
                       ^

TypeError: Cannot read properties of undefined (reading 'ogurl')
    at /opt/arkime/common/auth.js:780:24
    at complete (/opt/arkime/node_modules/passport/lib/middleware/authenticate.js:271:13)
    at /opt/arkime/node_modules/passport/lib/middleware/authenticate.js:278:15
    at pass (/opt/arkime/node_modules/passport/lib/authenticator.js:428:14)
    at Authenticator.transformAuthInfo (/opt/arkime/node_modules/passport/lib/authenticator.js:450:5)
    at /opt/arkime/node_modules/passport/lib/middleware/authenticate.js:275:22
    at /opt/arkime/node_modules/passport/lib/http/request.js:41:7
    at /opt/arkime/node_modules/passport/lib/sessionmanager.js:51:9
    at /opt/arkime/common/auth.js:1143:7
    at onBody (/opt/arkime/node_modules/@elastic/elasticsearch/lib/Transport.js:320:9)

The line numbers don't seem to match up, has auth.js been modified?
Unfortunately this is a works for me, so any other info you can share? Which OIDC provider are you using? It looks like the req.body is missing.

Sorry, just noticed that the log output was from v5.0.1, I tried again this time with v5.1.0 and the line numbers match up now
Wed, 01 May 2024 13:04:11 GMT - GET / 302 0 bytes 9.663 ms
/opt/arkime/common/auth.js:783
          if (req.body.ogurl) {
                       ^

TypeError: Cannot read properties of undefined (reading 'ogurl')
    at /opt/arkime/common/auth.js:783:24
    at complete (/opt/arkime/node_modules/passport/lib/middleware/authenticate.js:280:13)
    at /opt/arkime/node_modules/passport/lib/middleware/authenticate.js:287:15
    at pass (/opt/arkime/node_modules/passport/lib/authenticator.js:446:14)
    at Authenticator.transformAuthInfo (/opt/arkime/node_modules/passport/lib/authenticator.js:468:5)
    at /opt/arkime/node_modules/passport/lib/middleware/authenticate.js:284:22
    at /opt/arkime/node_modules/passport/lib/http/request.js:41:7
    at /opt/arkime/node_modules/passport/lib/sessionmanager.js:51:9
    at /opt/arkime/common/auth.js:1146:7
    at onBody (/opt/arkime/node_modules/@elastic/elasticsearch/lib/Transport.js:320:9)

Node.js v18.20.1

I'm using Keycloak and the authRedirectURIs is set to https://context.mcgillowen.local/auth/login/callback

Ok, I'll try and reproduce, for now you could change it to if (req.body?.ogurl) {

authors: awick mcgillowen

repo: arkime/arkime


text:
Add inline SVG dynamically

Hi,
Inline SVG is a great library to be used and thank you very much for all the contributors.
I would like to know whether the library can be used to add SVGs dynamically to the component.
For example, I am loading an external web page with the help of an iFrame.
This HTML page is having references to SVG images with IMG(s).
I would like to replace these IMG elements with the help of inline-svg dynamically.
A dynamic directive example is explained by Jagadesh in the following link for an example:
How to add directive dynamically in angular 2/4/6?
Regards.
Shan

There's no built-in support for something like this, no.

Hi, Thank you very much for the comment.
Any idea of adding this kind of feature in future releases?
Regards

Hi, Thank you very much for the comment.
Any idea of adding this kind of feature in future releases?
Regards

Thank you very much

Thank you very much

authors: arkon ishanuda

repo: arkon/ng-inline-svg


text:
Removed unnecessary tomli dependency

Closes https://github.com/arkq/flake8-requirements/issues/85

https://github.com/arkq/flake8-requirements/blob/v2.0.2/src/flake8_requirements/checker.py#L14-L17 uses tomllib, so it's actually required


text:
merge package from arlac77/npm-package-template

package.json

chore(devDependencies): update travis-deploy-once@^5.0.0 from template

Codecov Report

Merging #96 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master    #96   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files           2      2
  Lines          29     29
=====================================
  Hits           29     29

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8aa19c5...f3800a2. Read the comment docs.

:tada: This PR is included in version 1.0.6 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


text:
Add missing fields in Helm charts to values file

Helm values file are missing some fields which are used in the templates.

For some reason I cannot assign this to myself. This is merged.

repo: armadaproject/armada


text:
🛑 NWTFV is down

In 0dac15b, NWTFV (https://nwtfv.com) was down:

HTTP code: 0
Response time: 0 ms

Resolved: NWTFV is back up in fb9fb41.

repo: arnef/status


text:
Crashlytics found an invalid API key: null.

Hello!
I needed to change 'com.google.gms: google-services: 4.1.0' for 'com.google.gms: google-services: 4.2.0' in file bulid.gradle to work, was giving the error:
Crashlytics found an invalid API key: null. Check the Crashlytics plugin to make sure that the application has been added successfully!

@EdisonWerle  use 4.3.2 for now, because firebase only works with those, most likely. You can check my fork too  (https://github.com/freefiona85/cordova-plugin-firebase) - i focused on making the plugin works on Phonegap Build, also, I suggest to apply the Crashlytics plugin on the bottom of build.gradle. I hope this helps.

repo: arnesson/cordova-plugin-firebase


text:
IOS notification on status bar not working

Hi,
I'm using ionic with cordova 7. I have installed APN certificates, adjusted the GoogleServices-Info.plist in the xcode project and enabled capabilities (Push notification and Remote notifications in Background capabilities). I have published my app in the testflight and when i send the notification to ios devices the firebase says that is successfully sent, however the notification in the IOS status bar is not created or showed even if my app is in background ou not opened.
However, if my app is in foreground and running, when i send the notification, it can be received in the OnNotification method. What i'm doing wrong? Can anyone help-me?

You sound like you are having the opposite issue of everyone else.  The Docs say its only supposed to register a notification is the app is closed or in the background - which is how mine is working on Android.  however I can't get notifications to work with my app on iOS...in fact I can't even figure out how to enable the permissions for my iOS app.  when I see iPhone -> Settings -> MyApp, "NOTIFICATIONS" is not listed in the entitlements/access permissions.
I have done the same as you, APN Certs, added the GoogleServices-Info.plist to the root of my project and in Xcode enabled Push Notifications....and Background Modes -> Remote Notifications.  But when I look in my iPhone App permissions settings NOTIFICATIONS is not listed.

@rolinger, i have the same problem than you. My app have no notification permission in the settings. I tried but i cant make It Works. However, when the app os in the foreground the firebase notification data, comes into onNotification function. I think maybe you can receive It in the foreground mode too.
Im thinking if anyone here have successfully made notification in the status bar works in IOS using this plugin...

I'm trying to get notification to work in IOS also. So far I've had no luck, not even if the app is in the foreground. I have everything set up. Brunosoaresds when you created your app id on developer.apple.com did you enable push notification? When my app installs it shows up on my device settings and it has notifcations enabled.
I'm using cordova-ios 4.3.1, cordova-cli 6.3.1, xcode 8.3.3, build for ios 10.3,
I have an issue i can't figure out. if i build for 9.3 and install on an ipad the app will freeze on startup, but i done see any errors.
I had to edit the AppDelegate.m file and add firebase.h, and [FIRApp configure];
Does anyone have notifications completely working in IOS?

@jaybowman i have enabled this options. But im thinking that the problem is because im using 9.3 SDK. Searching this repository, i found pull requests to fix this bugs. However, i don't want to upgrade my Macbook to Sierra, so for now, i can't test it with 10++ SDK.

Are you executing   Grant Permissions?, without it you wont see Notifications in the permission's list. @rolinger @brunosoaresds

yes @zgluis , but its doesn't works in my app compiled with 9.3 SDK. The popup don't appear.

I got my iOS notifications to work.  It was a grant permissions issue.  I am working on cleaning it up though because when it the grant permissions is executed at app install/launch, the app doesn't wait for user response, it fully loads the app while the permission request is still on the screen.  That poses a problem for me because parts of my app need to determine if the permission is set before the app loads.  Maybe you all can assist on how to pause the app while waiting for user action on the permission.
Here is my code:
  function iosPush() {
    var q = $q.defer() ;
    if (/(iPad|iPhone|iPod)/i.test(navigator.userAgent)) {
      window.FirebasePlugin.grantPermission(function(status) {
        q.resolve(status) ;
      }) ;
    } else {
      q.resolve("Android") ;
    }
    return q.promise ;
  }
    // calling iosPush() should pause the app install waiting for user action on the permission, but
   // but it doesn't pause, the app continues and other permissions do pop up waiting for user action.
   // I think this is because the window.FirebasePlugin.grantPermission isn't a true "success/error" callback function.
    iosPush().then(function(status) {
      return getLocationAuth()
    }).then(function(status) {
      errMgmt("ctrl/init",30.2,'GPS Auth was '+status) ;
      if (/(android)/i.test(navigator.userAgent) ) {
        return getReadPhoneAuth() ;  // process Android Permission
      } else {
        return "GRANTED" ;  // if iOS, pass 'granted' which is used to bypass certain sections in next promise chain.
      }
    }).then(function(status){ ...... }) ;

authors: brunosoaresds jaybowman rolinger zgluis


text:
[FIRTrace updateTraceWithSessionId]_block_invoke

Describe the bug
This is a bug from the Firebase SDK, that we are seeing through this plugin: https://github.com/firebase/firebase-ios-sdk/issues/2019
Essentially a large number of our users are experiencing crashing due to Crashlytics.
To Reproduce
Steps to reproduce the behavior:

App Starts with Cordova-plugin-firebase
Certain performance triggers cause Firebase SDK to crash

Expected behavior
No App should Crash due to the presence of an Analytics / Crash monitoring solution
Plugin Version
cordova-plugin-firebase 2.0.5 "Google Firebase Plugin"
Desktop (please complete the following information):
Smartphone (please complete the following information):

Device: iPhone(s)
OS: iOS 11.4.1 and 12.0.2

Additional context
Following the bug report directly on Firebase SDK, the solution appears to be to update the Firebase plugin to 5.11 making sure the performance SDK within Firebase is 2.2.
Additionally there are some notes around back end fixes, but these I believe are with Google and are outside of this plugins scope.

@soumak77  Hey Brian, I hope all is well?
I was trying to upgrade the Firebase Frameworks for iOS but I couldn't see how you obtained some of the Frameworks like: FirebaseAuth.framework from CocoaPods it only gives me src, do you build from src, or obtain the frameworks another way?

Found the link: Integrate without CocoaPods.  I will do a PR with the latest, hopefully that will resolve.

I have added a PR #937, I have also been using this in my production project and have seen the crash no longer reported for the version with this upgrade, everything appears to be working.  I am however struggling with the CI on the PR, so any help gratefully received.


text:
Specify MathLive and Vue version in README

Specifying MathLive version helps to prevent clients from having breaking changes in the future. For example, when Vue 2 is updated to Vue 3, the API of the component is changed, etc.
Move the wrapper source location up in the documentation and specify the compatible Vue version so that the developers need to read less documentation and code to understand this project.

Feel free to make any changes/suggestion to this PR.

repo: arnog/vue-mathlive


text:
Upgrade to use JDK11

probably available from CXF 3.3 (https://stackoverflow.com/questions/52857820/cxf-codegen-maven-plugin-doesnt-work-openjdk-11)

fixed and verified by build #18

repo: arnosthavelka/ws-training


text:
Stop using base formatter in golines

We're already using golangci-lint with gofumpt, we don't need golines to do additional work beyond splitting long lines.
Fixes #899.

Confirming this fixes #899 for me. Thanks @sevein!

authors: djjuhasz sevein

repo: artefactual-sdps/enduro