text:
Optimize handling of globs from extension searches

Issue Type: Performance Issue
Opening project folders with vscode slows down
VS Code version: Code 1.35.0 (553cfb2c2205db5f15f3ee8395bbd5cf066d357d, 2019-06-04T01:17:12.481Z)
OS version: Windows_NT x64 10.0.17763

System Info

Item
Value

CPUs
Intel(R) Core(TM) i5-7500 CPU @ 3.40GHz (4 x 3408)

GPU Status
2d_canvas: enabledchecker_imaging: disabled_offflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onnative_gpu_memory_buffers: disabled_softwarerasterization: enabledsurface_synchronization: enabled_onvideo_decode: enabledwebgl: enabledwebgl2: enabled

Load (avg)
undefined

Memory (System)
15.89GB (6.99GB free)

Process Argv
C:\Users\jedi\code\Jedi\OBG_clint

Screen Reader
no

VM
0%

Process Info
CPU %	Mem MB	   PID	Process
    4	    96	 13912	code main
    1	    68	    76	   window (问题报告程序)
    0	    58	  1076	   shared-process
    0	   177	  1564	   window (Login.vue - OBG_clint - Visual Studio Code)
    0	    10	  6628	     electron-crash-reporter
    0	    11	  6976	     watcherService
    0	     5	 16980	       console-window-host (Windows internal process)
    0	    38	 13172	     extensionHost
    0	   105	  2960	       electron_node vueServerMain.js
    0	    24	  6472	       electron_node tsserver.js
    0	    17	 12056	         electron_node typingsInstaller.js typesMap.js
    0	   174	  7732	   window (main.js - demo - Visual Studio Code)
    0	    11	  2444	     watcherService
    0	    11	  7552	       console-window-host (Windows internal process)
    0	    62	 14956	     extensionHost
    0	   117	 15816	       electron_node tsserver.js
    0	    56	  5284	         electron_node typingsInstaller.js typesMap.js
    0	   161	 10872	   gpu-process

Workspace Info
|  Window (Login.vue - OBG_clint - Visual Studio Code)
|  Window (main.js - demo - Visual Studio Code)
|    Folder (demo): 14 files
|      File types: js(4) json(2) vue(2) browserslistrc(1) gitignore(1) md(1)
|                  html(1) ico(1) png(1)
|      Conf files: package.json(1)
|    Folder (OBG_clint): 349 files
|      File types: js(149) vue(83) css(49) less(16) html(10) svg(9) jpg(9)
|                  png(5) json(3) ico(2)
|      Conf files: package.json(1);

Extensions (8)

Extension
Author (truncated)
Version

laravel-blade-spacer
aus
1.0.3

vscode-intelephense-client
bme
1.0.14

dotenv
mik
1.0.1

vscode-language-pack-zh-hans
MS-
1.35.1

mssql
ms-
1.6.0

vetur
oct
0.21.0

laravel-blade
one
1.20.0

open-html-in-browser
pea
1.2.0

Seems to me like node_modules are again subject to the ripgrep treatment. To work around this issue, you can put node_modules into the files.exclude setting.

If node_modules are not in files.exclude or .gitignore, they will be searched. Please give more details.

@roblourens If that is how it's supposed to work (and I think it is) then there is a regression. .gitignore has no effect, only files.exclude.
The node_modules folder is in the .gitignore of every single project in the workspace. An example for a generated command line for one of the projects in the workspace is:
"c:\Users\oliver\AppData\Local\Programs\Microsoft VS Code\resources\app\node_modules.asar.unpacked\vscode-ripgrep\bin\rg.exe" --files --hidden --case-sensitive -g /test/**/*.js -g !**/.git -g !**/.svn -g !**/.hg -g !**/CVS -g !**/.DS_Store -g !/.nyc_output -g !/mochawesome-report --no-ignore --follow --no-config --no-ignore-global
When I open the workspace, the multiple rg.exe processes fully saturate the CPU on my workstation for considerable amount of time and the system becomes unusable.
When I include node_modules in the files.exclude setting of the workspace, the rg.exe processes are extremely short-lived and there is no problem at all. The generated command line is:
"c:\Users\oliver\AppData\Local\Programs\Microsoft VS Code\resources\app\node_modules.asar.unpacked\vscode-ripgrep\bin\rg.exe" --files --hidden --case-sensitive -g /test/**/*.js -g !**/.git -g !**/.svn -g !**/.hg -g !**/CVS -g !**/.DS_Store -g !/.nyc_output -g !/mochawesome-report -g !/node_modules --no-ignore --follow --no-config --no-ignore-global

It looks like you have the setting search.useIgnoreFiles disabled, can you check that? That causes the --no-ignore to be used which disables gitignore

search.useIgnoreFiles is not configured in my user or workspace settings. The toggle in the sidebar is enabled:

Can you find the full search log?
Please do the following

Run the command "Set log level" and change it to "Trace"
Run the search again
Show the search-related messages in the "Log (Window)" output panel

That panel is empty even after changing the log level. I'm not running any searches. I'm just opening VS Code.

There are extensions triggering searches or being activated on a glob pattern which also triggers a search, if you change the log level and reload the window, you should see them. I want to see if there are any other hints about why --no-ignore is being used.

@roblourens I took the liberty of sending the log to your gmail.

Thanks, I see what's going on, I forgot that .gitignore and search.exclude are not considered for extension-triggered searches. It has always been this way, changing it now would just be a breaking change, and some extensions rely on this. https://github.com/microsoft/vscode/issues/68056
So unfortunately all I can say is that you can add these folders to files.exclude to exclude them from the extension's search. I'm guessing this is an extension related to tests based on the fact that it is looking for files matching /test/**/*.js.

Yeah, I figure it's https://github.com/hbenl/vscode-mocha-test-adapter I've been using this for some time now. I'm surprised this behavior is so noticeable now but has been unchanged from the last update :/
Including node_modules in files.exclude is undesirable as having the folder available in VS Code makes debugging a lot easier in many of our projects. So this is disappointing.
But I'll look into possible ways to work around the problematic behavior via the configuration options of the extension, as there shouldn't really be any reason to look into ./node_modules when the test directory is ./test anyway.
Thanks for the support.

Looking at the code, it looks like the extension makes several other checks before triggering a search. You might check whether one of those can help you to avoid the search entirely. https://github.com/hbenl/vscode-mocha-test-adapter/blob/40a8b1beb4f1f9790efb20f87aeb52b766a84408/src/configReader.ts#L180
Or if this is a workspace where you are not using this extension, extensions can be disabled per-workspace. Alternately it could be a bug with the extension.

We handle the ripgrep issue that you identified in some cases - for text searches that use the ./foo/bar syntax in "files to include" to search with a particular pattern from the root, we map this to -g '!*' -g 'foo' -g 'foo/bar' -g 'foo/bar/**'.
For a search like the one in this case, I can in theory apply the same optimization. It's often really tricky to get this right without breaking something but I'm all for anything that decreases the impact of extension searches.

IMHO the entire issues is a result from trying to abstract away too much of the complexity of search.
Sometimes you want the convenience of not including files matched by .gitignore (and the likes), sometimes you do not. Sometimes you want to follow all symlinks, sometimes you don't. Sometimes you want to find files ignoring case, sometimes not. Sometimes you care about the users settings, sometimes not so much.
As I understand it, the API in VS Code currently allows only 2 relevant arguments to target a search: One inclusive pattern and one exclusive pattern. The remaining ways to further specify the search are set outside of the scope of the search request, which should already be undesirable in itself. The result of the search must then be filtered down further as desired.
This is not ideal. First a tool, that prides itself on performance (rg), is used to collect a large list only to then filter it down far less sufficiently, wasting a lot of resources and time. Even though rg could have been used in a more targeted fashion right from the beginning.
Another aspect is, rg uses parallelization already. Yet, one process is started for every project in the workspace. Whenever there is a new issue resulting from how rg is employed in VS Code, it slows down the machine to a grinding halt. These searches should be queued and run in series.
In any case, thanks again for your help, which ultimately resulted in a solution implemented by the extension author, resolving the problem in this specific case. And I also learned a bit more about ripgrep :)

The remaining ways to further specify the search are set outside of the scope of the search request, which should already be undesirable in itself. The result of the search must then be filtered down further as desired.

I do have an open issue to expose more options to the findFiles extension API but that extension wouldn't want to exclude gitignore and search.excude files all the time, that was a problem in this issue: https://github.com/microsoft/vscode/issues/68056. But yeah extensions should be able to use that in their searches.

Yet, one process is started for every project in the workspace. Whenever there is a new issue resulting from how rg is employed in VS Code, it slows down the machine to a grinding halt. These searches should be queued and run in series.

Not sure, I think rg will use all the resources available, whether there is one process at a time or 5. That is not a bad thing, you paid for a fast CPU, let's use it :)
Thanks for following up with the extension author, I think just excluding node_modules is a good workaround too.

Not sure, I think rg will use all the resources available, whether there is one process at a time or 5. That is not a bad thing, you paid for a fast CPU, let's use it :)

I'd rather trust a single instance of rg to balance resource usage, then running N instances without any control over resource usage. The CPU is not the only resource being used here and the worst-case has the potential to completely freeze the system.
I have been involved or followed many tickets revolving around performance/freeze issues in VS Code and rg (or the way it is utilized) was very often the source of it. I also know you have been involved in those tickets as well. You should be aware of the problems that result from the current approach.
When I run a single rg --files --follow --no-ignore in a problematic directory, my CPU load for rg peaks at 60% and uses over 2 GB of memory.

I manually exited rg at the point I took the screenshot. It would have probably run for a while longer. The graph was plotted over several minutes of run time.
This is only a single process. If 10 of those would be running for my entire workspace (and this is what was happening when I initially posted in this ticket), the system becomes unusable. I don't even want to think about what would happen if my system would have started to page out memory to disk.
In the best-case scenario, people (or the extensions they are using) aren't searching for millions or billions of files and this use case should be perfectly served by single instances of rg running in series. Especially since, as you've also pointed out, rg already parallelizes excellently.
In the worst-case scenario, people should at least be able to still control their system and not be locked out by processes running wild due to an error.
Maybe running in series isn't even a good solution, I just experienced this so often now, that I felt maybe a better solution can be found and implemented.

Hey @roblourens, hoping to get your help on this issue again in light of your recent fix in https://github.com/microsoft/vscode/issues/138337#issuecomment-985726566.

It has always been this way, changing it now would just be a breaking change, and some extensions rely on this. https://github.com/microsoft/vscode/issues/68056

I agree with the complexities of a fix here being a breaking change, and it was the main reason I hadn't commented before now. Noticing your other fix, would adding a default timeout here too be reasonable? I personally don't see many good reasons for extensions to search for files in the background for more than a few minutes, but it's possible I'm missing hidden complexity here. What are your thoughts?
The problem was exacerbated after we switched to pnpm, which sets up a symlinked strict node_modules structure that makes it look larger than it is to a lot of tooling. Setting "search.followSymlinks": false helps, but still leads to 100% CPU rg processes running for 5+ minutes.
It looks like the change to respect 7s timeouts in the November 2021 release only applies to filesService.ts. I was a bit excited when I saw that commit, but after tracing down vscode.workspace.findFiles's call stack, it looks like that's calling into a separate searchService.ts file.
https://github.com/microsoft/vscode/blob/80fd8b36eae911fe31216eb9b095ab7da5378086/src/vs/workbench/services/search/common/searchService.ts#L114

For context, many members of my team have been running into this problem from extensions that fire off vscode.workspace.findFiles(...) requests.
We first saw this in rebornix/vscode-project-snippet, but considered it a one-off misbehaving extension since it's deprecated.

https://github.com/rebornix/vscode-project-snippet/blob/fd98e479c0a6d2dd3176857cc538da0092f60cbc/src/extension.ts#L88

But since then we've isolated at least 2 other extensions causing this problem:

https://github.com/vscode-kubernetes-tools/vscode-kubernetes-tools/blob/92582a57ce722e166d25482b443c37a58d16305a/src/helm.exec.ts#L576
https://github.com/microsoft/vscode-java-debug/blob/6a56a5a9daf9978491f4895e1644ab05c1601092/src/debugCodeLensProvider.ts#L184

Adding node_modules to files.excludes does resolve this problem, but we're hesitant to set this as the default in our repo's .vscode/settings.json for the same reasons @oliversalzburg mentioned above.

Setting "search.followSymlinks": false helps, but still leads to 100% CPU rg processes running for 5+ minutes.

And this is because it's still spending time in node_modules?
To be clear, this particular "optimize globs" issue wouldn't help with extensions searching for **/something because that query has to check every single file in your folder regardless, and they should just carefully consider whether they really have to do that...
Thanks for sending a PR upstream to that extension.

And this is because it's still spending time in node_modules?

We believe so. In the rebornix/vscode-project-snippet case my coworker ran dtruss and saw a bunch of read calls into node_modules/.... Adding node_modules to files.exclude stopped the high CPU usage, which supports the theory.

To be clear, this particular "optimize globs" issue wouldn't help with extensions searching for **/something because that query has to check every single file in your folder regardless, and they should just carefully consider whether they really have to do that...

You're right, but I think it's also the case that the existing API makes it easy to accidentally search everything when **/something is the query?
I'm reading a bit more closely at the comments above and noticed that an update to the API was already considered:

I do have an open issue to expose more options to the findFiles extension API

Is the result of that this comment? https://github.com/microsoft/vscode/issues/48674#issuecomment-924144472 I see the new API allows useSearchExcludes and useIgnoreFiles, which would definitely be more reasonable to send PRs against extensions. 🙂
It seems like migrating to whatever new function accepts FindInFilesOptions is the best way to close this issue. It requires a change in all extensions exhibiting this problem, but I think that's very reasonable.

Thanks for sending a PR upstream to that extension.

Thanks for the suggestion that was a reasonable way to fix this. I would have felt unsure creating such a PR before reading your comment above.

Yeah, new API will help here, I hope to get to it soon.

closing as stale since there have been many API changes that have impacted performance. If you are still having problems with performance please file a new issue so we can address it in its current state. Thanks!

authors: eleanorjboyd gluxon lubo3395 oliversalzburg roblourens


text:
A11y_HDInsight Tools for VSCode_HDInteractive:Hive interactive_Screen Reader:NVDA/JAWS/VO is not reading the role of the button correctly,it's reading button as link

Environment Details:
https://marketplace.visualstudio.com/items?itemName=mshdinsight.azure-hdinsight
**Visual studio code version:**1.34.0
OS Version: Mac OS
Repro Steps:
1)Download and install HDInsights for VS code from the URL: https://marketplace.visualstudio.com/items?itemName=mshdinsight.azure-hdinsight
2)Open any hql query and link with the cluster using proper credentials.
3)Switch on the Screen Reader
3)Use the short cut key ctrl+Alt+H to run the code of HDInteractive: Hive Batch
4)Navigate to (Maximize, save as csv, save as json, save as Excel) and check whether screen reader is reading the role correctly or not

Actual Result:
NVDA is not reading the role of the button correctly, it's reading button as link

Expected Result:
Nvda should read the role of the control correctly.
i.e Maximize button ,save as csv  button, save as json  button, save as Excel button

User Impact:
Screen Reader users will get confused while navigating to the Result window as screen reader is not reading the role of the control correctly

Mas Reference:
https://microsoft.sharepoint.com/:w:/r/teams/msenable/_layouts/15/WopiFrame.aspx?sourcedoc={54f28d1f-a2d1-4dcd-84e1-5c9b87e8aba4}
Attachments:
Bug 81040_Buttons are reading as link.pptx

Please file against extension. Extension authors can destill the issue and figure out if this is on the vscode side and if it is they can file this back to the vscode repository using nice bug description and nice readable steps using VSCode terminology. Thanks

source: gharchive/issue

authors: isidorn v-supupp

repo: microsoft/vscode

license: MIT

license_type: permissive

license_source: github-api


text:
Annoying GitHub commit behaviour

VSCode Version: 1.36.1
OS Version: Linux (Ubuntu 19.04)

Steps to Reproduce:

Make your default code editor (commit editor) of git to "code".
Turn ON autosave on vscode.

Try to commit, it will autosave that file and blank commit get passed.

In my opinion, it should ignore the "COMMIT_EDITMSG" file.
I faced it first time, on windows no issues are there but on Ubuntu 19.04 there's issue.
Does this issue occur when all extensions are disabled?: Yes

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

Annoying GitHub commit (#77927)

no

@yogesh-aggarwal you can ignore files in your workspace user and global settings to archive your goals.

@yogesh-aggarwal you can ignore files in your workspace user and global settings to archive your goals.

How?

https://stackoverflow.com/questions/30140112/how-do-i-hide-certain-files-from-the-sidebar-in-visual-studio-code
and you can also ignore that file inside git via .gitignore

No, I am talking about that it autosaves the commit file too & an empty commit gets passed on. How can I prevent the autosave for the commit file?

Okay I have figured it out. Just I have to set the vscode editor for commit with --wait flag
git config --global core.editor "code --wait"

This solves the issue.

authors: frank-dspeed yogesh-aggarwal


text:
Active inline breakpoint isn't highlighted

re #81175

set breakpoints as show in this file https://github.com/microsoft/vscode-references-view/blob/a48315c11bfeec50fc0d018f555097f61c888ce4/src/extension.ts#L26
hide the references viewlet
the 'editorHighlight.hide()' inline breakpoint is active
:bug: the inline breakpoint doesn't get the highlight (yellow arrow enclosing dot), instead the gutter breakpoints is highlighted, step in, step out and the yellow arrow does appear inline.

Good catch. We currently do not support this.
And yes it makes perfect sense. So assigning first to September though I might move it out to next week.

We now support this as shown by this gif:
Verifier: make sure that when the inline breakpoint is at the same location as the top stack frame indicator that you get one decoration and not two. The one decroation should be the yellow arrow with a red dot inside (as shown in the .gif)

I found an issue with this change and opened a PR for it: https://github.com/microsoft/vscode/pull/83851

authors: connor4312 isidorn jrieken


text:
[RFI] tasks inside workspace file

Hi, could you please add support for defining tasks inside the *.code-workspace file?
This would allow to create specific tasks without polluting the workspace directory, in cases like /etc/systemd/ and the like...
It would also enable to have per-developer tasks for a project they are working on by simply editing their personal *.code-workspace files.
Yes people use this editor for other purposes (like system administration) instead of just code development :smile:

Tasks are already supported in *.code-workspace files.

@alexr00 Could you please direct me to some documentation where this is explained/demonstrated?
Thanks

Looks like I missed adding it to the release notes last month. Try running the Tasks: Open Workspace Tasks command.

Tanks a lot using it now :+1:


text:
VSCode crashes when pasting this very long line C# code

Version: 1.42.1
OS: Windows 10
Steps to Reproduce:

Open VSCode using code --disable-extensions
Open a C# file
Paste this line of code

            if (other.m_navigationMode == this.m_navigationMode && other.m_eliminateEnemies == this.m_eliminateEnemies && (other.m_searchForItems == this.m_searchForItems && other.m_searchItems == this.m_searchItems) && ((int)other.m_chokePointPlayerCountThreshold == (int)this.m_chokePointPlayerCountThreshold && (double)other.m_chokePointValue == (double)this.m_chokePointValue && ((double)other.m_defensiveAvoidProjectilesLevel == (double)this.m_defensiveAvoidProjectilesLevel && (double)other.m_defensiveBlockLevel == (double)this.m_defensiveBlockLevel)) && ((double)other.m_counterOutOfRangeMeleeAttacksLevel == (double)this.m_counterOutOfRangeMeleeAttacksLevel && (double)other.m_defensiveRollFireLevel == (double)this.m_defensiveRollFireLevel && (other.m_meleeUsage == this.m_meleeUsage && other.m_meleeWeaponUsage == this.m_meleeWeaponUsage) && (other.m_meleeWeaponUseFullRange == this.m_meleeWeaponUseFullRange && other.m_rangedWeaponUsage == this.m_rangedWeaponUsage && ((double)other.m_seekCoverWhileShooting == (double)this.m_seekCoverWhileShooting && other.m_rangedWeaponMode == this.m_rangedWeaponMode))) && (other.m_rangedWeaponLOSIgnoreTeammates == this.m_rangedWeaponLOSIgnoreTeammates && other.m_powerupUsage == this.m_powerupUsage && ((double)other.m_navigationRandomPausesLevel == (double)this.m_navigationRandomPausesLevel && (double)other.m_aggroRange == (double)this.m_aggroRange) && ((double)other.m_searchItemRange == (double)this.m_searchItemRange && (double)other.m_guardRange == (double)this.m_guardRange && ((double)other.m_chaseRange == (double)this.m_chaseRange && (double)other.m_offensiveClimbingLevel == (double)this.m_offensiveClimbingLevel)) && ((double)other.m_offensiveDiveLevel == (double)this.m_offensiveDiveLevel && (double)other.m_offensiveEnrageLevel == (double)this.m_offensiveEnrageLevel && ((double)other.m_offensiveSprintLevel == (double)this.m_offensiveSprintLevel && (double)other.m_rangedWeaponAccuracy == (double)this.m_rangedWeaponAccuracy) && ((double)other.m_rangedWeaponAimShootDelayMax == (double)this.m_rangedWeaponAimShootDelayMax && (double)other.m_rangedWeaponAimShootDelayMin == (double)this.m_rangedWeaponAimShootDelayMin && ((double)other.m_rangedWeaponHipFireAimShootDelayMax == (double)this.m_rangedWeaponHipFireAimShootDelayMax && (double)other.m_rangedWeaponHipFireAimShootDelayMin == (double)this.m_rangedWeaponHipFireAimShootDelayMin)))) && ((double)other.m_rangedWeaponBurstPauseMax == (double)this.m_rangedWeaponBurstPauseMax && (double)other.m_rangedWeaponBurstPauseMin == (double)this.m_rangedWeaponBurstPauseMin && ((double)other.m_rangedWeaponBurstTimeMax == (double)this.m_rangedWeaponBurstTimeMax && (double)other.m_rangedWeaponBurstTimeMin == (double)this.m_rangedWeaponBurstTimeMin) && ((double)other.m_rangedWeaponPrecisionInterpolateTime == (double)this.m_rangedWeaponPrecisionInterpolateTime && (double)other.m_rangedWeaponPrecisionAccuracy == (double)this.m_rangedWeaponPrecisionAccuracy && ((double)other.m_rangedWeaponPrecisionAimShootDelayMax == (double)this.m_rangedWeaponPrecisionAimShootDelayMax && (double)other.m_rangedWeaponPrecisionAimShootDelayMin == (double)this.m_rangedWeaponPrecisionAimShootDelayMin)) && ((double)other.m_rangedWeaponPrecisionBurstPauseMax == (double)this.m_rangedWeaponPrecisionBurstPauseMax && (double)other.m_rangedWeaponPrecisionBurstPauseMin == (double)this.m_rangedWeaponPrecisionBurstPauseMin && ((double)other.m_rangedWeaponPrecisionBurstTimeMax == (double)this.m_rangedWeaponPrecisionBurstTimeMax && (double)other.m_rangedWeaponPrecisionBurstTimeMin == (double)this.m_rangedWeaponPrecisionBurstTimeMin) && ((double)other.m_meleeWaitTimeLimitMin == (double)this.m_meleeWaitTimeLimitMin && (double)other.m_meleeWaitTimeLimitMax == (double)this.m_meleeWaitTimeLimitMax && (other.MeleeActions == this.MeleeActions && other.MeleeActionsWhenHit == this.MeleeActionsWhenHit))) && (other.MeleeActionsWhenEnraged == this.MeleeActionsWhenEnraged && other.MeleeActionsWhenEnragedAndHit == this.MeleeActionsWhenEnragedAndHit)))

Does this issue occur when all extensions are disabled?: Yes

Moved to owning repo: https://github.com/dotnet/csharp-tmLanguage/issues/176


text:
Translation export fails

Exporting translation fails with the following error message:
[05:10:46] Finished optimize-vscode after 106597 ms

[05:10:46] Starting vscode-translations-export ...

[05:10:47] 'vscode-translations-export' errored after 17 min

[05:10:47] Error: No item ID or value specified: {"id":"add","message":""}

    at XLF.addStringItem (c:\_shift\vscode\vscode\build\lib\i18n.js:159:23)

    at XLF.toString (c:\_shift\vscode\vscode\build\lib\i18n.js:117:26)

    at Stream.<anonymous> (c:\_shift\vscode\vscode\build\lib\i18n.js:548:51)

    at Stream.stream.write (c:\_shift\vscode\vscode\node_modules\through\index.j

s:26:11)

    at DestroyableTransform.ondata (c:\_shift\vscode\vscode\node_modules\readabl

e-stream\lib\_stream_readable.js:612:20)

    at DestroyableTransform.emit (events.js:198:13)

    at DestroyableTransform.EventEmitter.emit (domain.js:466:23)

    at addChunk (c:\_shift\vscode\vscode\node_modules\readable-stream\lib\_strea

m_readable.js:284:12)

    at readableAddChunk (c:\_shift\vscode\vscode\node_modules\readable-stream\li

b\_stream_readable.js:271:11)

    at DestroyableTransform.Readable.push (c:\_shift\vscode\vscode\node_modules\

readable-stream\lib\_stream_readable.js:238:10)

    at DestroyableTransform.Transform.push (c:\_shift\vscode\vscode\node_modules

\readable-stream\lib\_stream_transform.js:146:32)

    at Pumpify.onReadable (c:\_shift\vscode\vscode\node_modules\to-through\index

.js:25:14)

    at Pumpify.emit (events.js:198:13)

    at Pumpify.EventEmitter.emit (domain.js:466:23)

    at emitReadable_ (c:\_shift\vscode\vscode\node_modules\readable-stream\lib\_

stream_readable.js:497:10)

    at emitReadable (c:\_shift\vscode\vscode\node_modules\readable-stream\lib\_s

tream_readable.js:491:65)

I couldn't reproduce this on tag 1.43.0.
The exception is generated since the actual message is the empty string. There is not reason why we shouldn't allow this.

c:_shift\vscode\vscode>gulp --max-old-space-size=8192 vscode-translations-export
[06:13:20] Node flags detected: --max-old-space-size=8192
[06:13:20] Respawned to PID: 6408
[06:13:42] Using gulpfile c:_shift\vscode\vscode\gulpfile.js
[06:13:42] Starting 'vscode-translations-export'...
[06:13:42] Starting clean-out-build ...
[06:13:45] Finished clean-out-build after 3333 ms
[06:13:45] Starting compile-build ...
[06:13:54] Starting compilation...
[06:21:05] Finished compilation with 0 errors after 430528 ms
[06:21:05] Finished compile-build after 439923 ms
[06:21:05] Starting clean-extensions-build ...
[06:21:06] Finished clean-extensions-build after 876 ms
[06:21:06] Starting bundle-extensions-build ...
[06:25:13] Bundled extension: python\extension.webpack.config.js...
[06:26:35] Bundled extension: git-ui\extension.webpack.config.js...
[06:27:13] Bundled extension: search-result\extension.webpack.config.js...
[06:27:22] Bundled extension: debug-auto-launch\extension.webpack.config.js...
[06:27:23] Bundled extension: debug-server-ready\extension.webpack.config.js...
[06:27:27] Bundled extension: jake\extension.webpack.config.js...
[06:27:27] Bundled extension: gulp\extension.webpack.config.js...
[06:27:28] Bundled extension: image-preview\extension.webpack.config.js...
[06:27:28] Bundled extension: grunt\extension.webpack.config.js...
[06:27:29] Bundled extension: vscode-account\extension.webpack.config.js...
[06:27:37] Bundled extension: configuration-editing\extension.webpack.config.js.
..
[06:27:37] Bundled extension: github-authentication\extension.webpack.config.js.
..
[06:27:38] Bundled extension: merge-conflict\extension.webpack.config.js...
[06:27:53] Bundled extension: php-language-features\extension.webpack.config.js.
..
[06:28:02] Bundled extension: npm\extension.webpack.config.js...
[06:28:03] Bundled extension: css-language-features\extension.webpack.config.js.
..
[06:28:05] Bundled extension: extension-editing\extension.webpack.config.js...
[06:28:06] Bundled extension: json-language-features\server\extension.webpack.co
nfig.js...
[06:28:09] Bundled extension: emmet\extension.webpack.config.js...
[06:28:11] Bundled extension: html-language-features\extension.webpack.config.js
...
[06:28:13] Bundled extension: json-language-features\extension.webpack.config.js
...
[06:28:18] Bundled extension: typescript-language-features\extension.webpack.con
fig.js...
[06:28:23] Bundled extension: git\extension.webpack.config.js...
[06:28:30] Bundled extension: css-language-features\server\extension.webpack.con
fig.js...
[06:28:30] Bundled extension: markdown-language-features\extension.webpack.confi
g.js...
[06:28:36] Bundled extension: html-language-features\server\extension.webpack.co
nfig.js...
[06:28:41] Finished bundle-extensions-build after 454570 ms
[06:28:41] Starting bundle-marketplace-extensions-build ...
[06:28:41] Downloading extension: ms-vscode.node-debug@1.44.2 ...
[06:28:41] Downloading extension: ms-vscode.node-debug2@1.42.1 ...
[06:28:41] Downloading extension: ms-vscode.references-view@0.0.49 ...
[06:28:41] Downloading extension: ms-vscode.js-debug-nightly@2020.3.317 ...
[06:28:41] Downloading extension: ms-vscode.js-debug-companion@0.0.4 ...
[06:28:47] Finished bundle-marketplace-extensions-build after 6150 ms
[06:28:47] Starting compile-extensions-build ...
[06:28:47] Finished compile-extensions-build after 0 ms
[06:28:47] Starting clean-out-vscode ...
[06:28:47] Finished clean-out-vscode after 133 ms
[06:28:47] Starting optimize-vscode ...
CSS INLINING IMAGE AT out-build\vs\editor\contrib\colorPicker\images\opacity-bac
kground.png MORE THAN ONCE. CONSIDER CONSOLIDATING CSS RULES
CSS INLINING IMAGE AT out-build\vs\workbench\contrib\comments\browser\media\reac
tion-light.svg MORE THAN ONCE. CONSIDER CONSOLIDATING CSS RULES
CSS INLINING IMAGE AT out-build\vs\workbench\contrib\comments\browser\media\reac
tion-dark.svg MORE THAN ONCE. CONSIDER CONSOLIDATING CSS RULES
CSS INLINING IMAGE AT out-build\vs\workbench\contrib\comments\browser\media\reac
tion-hc.svg MORE THAN ONCE. CONSIDER CONSOLIDATING CSS RULES
CSS INLINING IMAGE AT out-build\vs\workbench\contrib\extensions\browser\media\lo
ading.svg MORE THAN ONCE. CONSIDER CONSOLIDATING CSS RULES
CSS INLINING IMAGE AT out-build\vs\workbench\contrib\feedback\browser\media\info
.svg MORE THAN ONCE. CONSIDER CONSOLIDATING CSS RULES
CSS INLINING IMAGE AT out-build\vs\workbench\contrib\welcome\code-icon.svg MORE
THAN ONCE. CONSIDER CONSOLIDATING CSS RULES
[06:30:40] Finished optimize-vscode after 112705 ms
[06:30:40] Starting vscode-translations-export ...
[06:30:41] 'vscode-translations-export' errored after 17 min
[06:30:41] Error: No item ID or value specified: {"id":"add","message":""}
at XLF.addStringItem (c:_shift\vscode\vscode\build\lib\i18n.js:159:23)
at XLF.toString (c:_shift\vscode\vscode\build\lib\i18n.js:117:26)
at Stream. (c:_shift\vscode\vscode\build\lib\i18n.js:548:51)
at Stream.stream.write (c:_shift\vscode\vscode\node_modules\through\index.j
s:26:11)
at DestroyableTransform.ondata (c:_shift\vscode\vscode\node_modules\readabl
e-stream\lib_stream_readable.js:612:20)
at DestroyableTransform.emit (events.js:198:13)
at DestroyableTransform.EventEmitter.emit (domain.js:466:23)
at addChunk (c:_shift\vscode\vscode\node_modules\readable-stream\lib_strea
m_readable.js:284:12)
at readableAddChunk (c:_shift\vscode\vscode\node_modules\readable-stream\li
b_stream_readable.js:271:11)
at DestroyableTransform.Readable.push (c:_shift\vscode\vscode\node_modules
readable-stream\lib_stream_readable.js:238:10)
at DestroyableTransform.Transform.push (c:_shift\vscode\vscode\node_modules
\readable-stream\lib_stream_transform.js:146:32)
at Pumpify.onReadable (c:_shift\vscode\vscode\node_modules\to-through\index
.js:25:14)
at Pumpify.emit (events.js:198:13)
at Pumpify.EventEmitter.emit (domain.js:466:23)
at emitReadable_ (c:_shift\vscode\vscode\node_modules\readable-stream\lib_
stream_readable.js:497:10)
at emitReadable (c:_shift\vscode\vscode\node_modules\readable-stream\lib_s
tream_readable.js:491:65)

@janbaltus is this on master ?

Could reproduce on master. For 1.43.0 (the stable build from yesterday) please export the translation on that version

The problematic code is here:
https://github.com/Microsoft/vscode/blob/master/src/vs/platform/theme/common/iconRegistry.ts#L144
@aeschli can you comment on why you need to externalize empty strings?

@janbaltus can you comment on whether your translation platfrom can handle items with an empty message (e.g. "").

The localization platform can handle empty string.

authors: dbaeumer janbaltus


text:
JavaScript: try-catch in self-invoked functions makes the code afterwards unreachable

VSCode Version: 1.43.2
OS Version: Windows 10

Steps to Reproduce:

Paste this code into the editor:

let b = ((x) => {
try {
return x
}
catch (e) {
return e		//	now this, actually, will never be called
}
})('c');				//	all this does is assign b = 'c'
d = "everything is marked unreachable from this point on";
console.log('except it definitely is reachable! ...b = '+b);
2...

Does this issue occur when all extensions are disabled?: Yes

I can reproduce with the TypeScript language server at 3.8.2, but not with 3.9-nightly so this is likely fixed in the next version of TypeScript. You can try that out by installing the TypeScript and JavaScript Nightly extension which only affects the language server features of the editor.

Confirmed: TS 3.9... seems to fix it (after restart). Thanks for this suggestion!

authors: IiroUllin spahnke


text:
Search incorrectly interprets CRLF line endings in opened files

Issue Type: Bug
Summary: CRLF line endings in opened files are treated as LF line endings
Reproduction steps:

create folder "testsearch"
inside the folder create two files "foo1.txt" and "foo2.txt"
modify both files to have identical content "foo\r\n" (first line contains text "foo" with CRLF line break and second line is empty)
open "testsearch" folder in VS Code
press Ctrl + Shift + F to enable search panel
press Alt + R to enable regex search
search for "foo\r\n"
it should display two results, one in each file
click one of results to open the file
while file is open switch back to search and click refresh
opened file disappears from the result list

Additional note: searching for "foo\n" displays both results even though it should be 0 matches.
VS Code version: Code 1.43.2 (0ba0ca52957102ca3527cf479571617f0de6ed50, 2020-03-24T07:38:38.248Z)
OS version: Windows_NT x64 10.0.18363

System Info

Item
Value

CPUs
Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz (16 x 2304)

GPU Status
2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onoop_rasterization: disabled_offprotected_video_decode: enabledrasterization: enabledskia_renderer: disabled_off_okvideo_decode: enabledviz_display_compositor: enabled_onviz_hit_test_surface_layer: disabled_off_okwebgl: enabledwebgl2: enabled

Load (avg)
undefined

Memory (System)
31.81GB (20.06GB free)

Process Argv

Screen Reader
no

VM
0%

Extensions (5)

Extension
Author (truncated)
Version

xml
Dot
2.5.0

gitlens
eam
10.2.1

vscode-yarn
gam
1.7.0

csharp
ms-
1.21.16

mssql
ms-
1.9.0

Yeah, so the editor normalizes newlines to \n, but that only applies when a file is open. That means that you can't actually search for \r in an open editor, but we find that most people actually expect \n to match any sort of newline. When we search the disk, we try to make \n match \r\n but don't normalize away \r. That leads to this unfortunate inconsistency but I don't feel that it can be improved right now.

authors: eggpa roblourens


text:
try to ignore history on editor open for quicksearch

Related to https://github.com/microsoft/vscode/issues/204853
Fixes https://github.com/microsoft/vscode/issues/205135
cc @bpasero

@andreamah sorry for the late response, I should have been the reviewer here, can you add me for future PRs in this area? I will post a follow up PR with some cleanup and thoughts.

source: gharchive/pull-request

authors: andreamah bpasero


text:
Adding an Open in DevZero button

DevZero is a dev environment platform. Using this link, all contributors to this project will be able to use a DevZero environment as their dev workspace.
DevZero supports a free plan that individual contributors to OSS projects can utilize to make their contributions and/or to just test out the project.

Thanks for the PR, but we won't be taking this change!


text:
Allow specifying the degree of parallelism

Description
I have several test projects written with xUnit that I want to run in CI. These unit tests are IO bound and run much more quickly when parallelized with dotnet vstest --parallel. However, machines in my CI system (GitHub Actions) only have two CPU cores, which limits test execution to two concurrent assemblies. I would like to speed up my tests when run in CI by increasing the degree of parallelism further.
I added the following xunit.runner.json file to my project, but it only affected parallelization within each assembly.
{
  "parallelizeAssembly": true,
  "maxParallelThreads": -1
}

I was very surprised that parallelizeAssembly seemingly has no effect when run with the dotnet CLI. I assume MSBuild and VSTest create separate xUnit test runners for each assembly, which is why this setting has no effect?
I was able to work around that issue by using dotnet test --no-build -maxCpuCount:8, but the maxCpuCount parameter does not work with dotnet vstest, which tends to give me cleaner test output. Would it make sense to add support for maxCpuCount (or a similar parameter) in VSTest?
Steps to reproduce
Run dotnet vstest --parallel on a machine with more test projects than CPU cores.
Expected behavior
The dotnet CLI should respect properties in my xunit.runner.json file. However, barring that, it would be nice if there was a parameter that would increase the degree of parallelism when running dotnet vstest --parallel.
Actual behavior
A higher degree of parallelism can only be achieved when running tests through MSBuild (dotnet test).
Diagnostic logs
N/A
Environment
Linux and macOS
$ dotnet --version
6.0.401

@MatisseHack I think all the options you set are propagated correctly but our code assumes that tests will run in parallel (doing CPU bound work at the same time), and hence it chooses the minimal number between logical processor count, the specified maxCpuCount and assembly count to avoid overwhelming the CPU with too much parallel work. In your case the maxParallelLevel will be 2, because you have 2 logical processors.
In your case this assumption is not correct, because your tests are IO bound, and hence they run concurrently on the processors (they don't always do CPU work, so more than 2 concurrent tests can easily be handled by the CPU).
We don't have an option for that, and I don't think we can easily add it as there is an existing behavior, and we don't want to add yet another very similar option.

Do you mean that -maxCpuCount should work as a parameter to dotnet vstest? I got an error when I tried that:
The argument -maxCpuCount:1 is invalid. Please use the /help option to check the list of valid arguments.

Allowing this parameter and making it consistent with the behavior of dotnet test -maxCpuCount:8 would make the most sense to me, but I realize there is legacy behavior to consider when calling vstest.console.exe directly.
Is there any way to use the same test adapter for all assemblies then? I'm not familiar with the internals of VSTest, but am I correct in thinking that it's creating a separate xUnit test adapter for each assembly, which overrides xUnit's ability to run assemblies in parallel? Would it be possible to add an option to adjust this behavior instead?

I don't understand that having test frameworks, like xUnit, that are able to handle (and interested in doing that) parallelism, vstest opts for the no-no, "I don't support it, nor I let others do it". Woudn't be the easiest for vstest to hand over that responsibility to the test framework or, at least, allowing that option?

This is a new feature and won't be implemented, we are focusing on adding new features to Testing.Platform instead. https://aka.ms/testingplatform

authors: MatisseHack elpht nohwnd

repo: microsoft/vstest


text:
Multivalue control selected value get deleted after loading the Azure DevOps worktiem.

Multivalue control selected value get deleted after loading the Azure DevOps worktiem. I am facing this issue in chrome browser.
However, I was able to see the value for multivalue control in Firefox browser.
Is anyone aware of this issue with extension?
Any help, suggestions.. welcome

Unfortunately, we are seeing this issue as well using both Edge and Chrome. I have not tried using Firefox. I'm hoping to see some news from the developers on this, as someone from the team replied on a previous issue.

@JGPease we'll start going through the old issues. In what environment are you seeing this? Cloud or Server?

We are using a Cloud environment.

authors: JGPease MOlausson deeepakmhaskar


text:
Detailed logs without system path (RESULT_DIAGNOSTICS_LEVEL)

The default value of RESULT_DIAGNOSTICS_LEVEL is 3, which means that system paths are compiled into the binary. I'd like to avoid that, since I don't want for the build to depend on the project path, and because of size bloat.
https://github.com/microsoft/wil/blob/master/include/wil/result_macros.h#L265
Other possible values:
(RESULT_DIAGNOSTICS_LEVEL >= 2) // line number
(RESULT_DIAGNOSTICS_LEVEL >= 3) // line number + file name
(RESULT_DIAGNOSTICS_LEVEL >= 4) // line number + file name + function name
(RESULT_DIAGNOSTICS_LEVEL >= 5) // line number + file name + function name + macro code

So currently, to avoid the system file path ending up in the binary, I must select 2, which is very terse.
I'd like one of the two options:

Have the relative path, not the full path, of the source file. The library relies on __PATH__, and it sounds more like a task for the compiler. See also the topic on StackOverflow: __FILE__ macro shows full path.
Have an option for line number + function name. Usually it gives much more context than only the line number, obviously.

You can use /d1trimfile to remove paths from the __FILE__ macro, turning it relative. Example use here:
https://github.com/TranslucentTB/TranslucentTB/blob/4b4b41466f2950e9c8fa686e18ffa43ebb1208eb/Common/CppProject.props#L90-L92

Wow, it's barely documented. Thank you!

@sylveon Is that working for vcpkg packages? IIRC vcpkg compiles packages to dll/lib, didn't that file location hardcoded in dll/lib?

wil is header-only, so when using wil from vcpkg it isn't an issue (although you might have to add the path to vcpkg's installed folder as another /d1trimfile command). If a package from vcpkg is using wil, you'll have to make a custom build triplet that passes /d1trimfile.

seems like you reached a conclusion, so I'm closing. thank you @sylveon.

authors: ChrisGuzak justanotheranonymoususer sylveon ysc3839

repo: microsoft/wil

license: mit

license_source: bigquery


text:
Feature request: support for the SIO_GET_EXTENSION_FUNCTION_POINTER WSAIoctl ?

Motivation
Hi,
I am trying to port a Winsock2 application which use Overlapped I/O and need to get a function pointer to ConnectEX or AcceptEx (among other functions) on a socket.
I don't seem to find any of the WSAID_* I need defined in the windows and sys crates, although I do find type definitions for the LPFN_*.
Is the support for these features coming later or should I do it differently?
Drawbacks
No response
Rationale and alternatives
No response
Additional context
No response

Yes, these GUID constants are missing.

I'll transfer to the Win32 metadata repo for resolution.

authors: kennykerr zarkdav

repo: microsoft/windows-rs


text:
[Package Request]: Fujitsu ScanSnap Home

How can we help?
I would like someone else to build the manifest.
Please read and ensure the following

[X] The installer meets the above requirements

Please provide the following information
Download Page Url: https://www.pfu.fujitsu.com/imaging/ssacc/en/start_download_21_GA.html
Publisher: Fujitsu
Package Name: ScanSnap Home
Description: ScanSnap Home is a desktop application that edits, manages, and utilizes scanned data from documents, business cards, photos, and receipts to increase your productivity.
Package Version: 2.10.0
Installer URL: https://origin.pfultd.com/downloads/ss/sshinst/w-2100/WinSSHDownloadInstaller_2_10_0.exe

Unable to add tag because what do you want the tag to be? So that, it can be easily find.

Here are some possible tags.  Not sure which ones make the most sense.

scanner
documents
receipts
digitize
ocr

Ok.

During the creation of manifest, wingetcreate asks me the silent switches for installer?

I'm not sure if this installer has silent switches.  Are they required?

Yes, they might required.

Detected Version changed

Unsuccessful! Because silent switch is needed. This installer don't support silent switch either.

According to the strings table inside the InstallShield setup, /S /V/qn should be the silent install string. However, this doesn't seem to work. This will likely have to wait until either a silent install switch is found or winget supports non-unattended installers.

authors: BrandonWanHuanSheng Trenly jeffwlawson

repo: microsoft/winget-pkgs


text:
Please confirm these before moving forward

[X] I have searched for my issue and not found a work-in-progress/duplicate/resolved issue.
[X] I have not been informed if the issue is resolved in a preview version of the winget client.

Category of the issue
Installer hash mismatch.
Brief description of your issue
hash of file when downloaded from website:
6718ABBD4F4FAEFE375C579DE775151525A9A1CCA821041796588A6EC05A5C99
hash of file in package manifest:
48998B09194BF2D56AAE3D36810BB3AE536E7C60FBA76A30DE78107742E5EA7A
Steps to reproduce
try to download lt spice through winget
throws error Hash value of installer does not coincide
Actual behavior
winget throws error
Expected behavior
winget doesnt throw error
Environment
Windows-Paket-Manager v1.6.2771
Copyright (c) Microsoft Corporation. Alle Rechte vorbehalten.

Windows: Windows.Desktop v10.0.19045.3570
Systemarchitektur: X64
Paket: Microsoft.DesktopAppInstaller v1.21.2771.0

WinGet-Verzeichnisse
-----------------------------------------------------------------------------------------------------------------------
Protokolle                                   %LOCALAPPDATA%\Packages\Microsoft.DesktopAppInstaller_8wekyb3d8bbwe\Local…
Benutzereinstellungen                        %LOCALAPPDATA%\Packages\Microsoft.DesktopAppInstaller_8wekyb3d8bbwe\Local…
Verzeichnis für portierbare Links (Benutzer) %LOCALAPPDATA%\Microsoft\WinGet\Links
Portables Linkverzeichnis (Computer)         C:\Program Files\WinGet\Links
Portierbarer Paketstamm (Benutzer)           %LOCALAPPDATA%\Microsoft\WinGet\Packages
Portierbarer Paketstamm                      C:\Program Files\WinGet\Packages
Portierbares Paketstamm (x86)                C:\Program Files (x86)\WinGet\Packages
Installationsprogrammdownloads               %USERPROFILE%\Downloads

Links
-----------------------------------------------------------------------------------------
Datenschutzerklärung              https://aka.ms/winget-privacy
Lizenzvereinbarung                https://aka.ms/winget-license
Hinweise von Drittanbietern       https://aka.ms/winget-3rdPartyNotice
Startseite                        https://aka.ms/winget
Windows Store-Nutzungsbedingungen https://www.microsoft.com/en-us/storedocs/terms-of-sale

Administratoreinstellung                  Status
-----------------------------------------------------
LocalManifestFiles                        Deaktiviert
BypassCertificatePinningForMicrosoftStore Deaktiviert
InstallerHashOverride                     Deaktiviert
LocalArchiveMalwareScanOverride           Deaktiviert

Screenshots and Logs
No response

@wingetbot is currently working on this issue.

https://github.com/microsoft/winget-pkgs/pull/125589

Close with reason: Resolved in #126192;

authors: Dragon1573 benjibst mdanish-kh


text:
Error: Unable to write to C:/... IT policies may be restricting access to this folder

Create issues related to the winget.exe client here

Brief description of your issue

Each time I make winget upgrade --all, when the download ends, I get a window error saying: Installation has failed: Unable to write to C:\ProgramData\julie IT policies may be restricting access to this folder

The worse there is that winget is telling me that the upgrade succeed but in facts, it doesn't:

Winget is writting that the software has been "correctly installed" (Installé Correctement in the screenshot) but they still show up when doing winget upgrade:

Steps to reproduce

Open a command prompt as Administrator (the default one from Windows 10)
Type winget upgrade --all
See the errors window everywhere
Make winget upgrade and see that nothing has been updated

Expected behavior

A working command or a way to disabled IT policies?
Actual behavior

Already explained in the description
Environment
Windows Package Manager v1.0.11451
Windows: Windows.Desktop v10.0.19042.985
Package: Microsoft.DesktopAppInstaller v1.11.11451.0

Any other software?

Can I ask what do you expect by any other software? ? Like anything related to winget? Then no.

Can you open this issue in microsoft/winget-cli? This repo is for the packages in the repo, not the client itself.

oops my bad, you can close this issue

authors: Juknum jedieaston


text:
Andrelouis.NokiaInternalTuneEdit version 1.0

[ ] Have you signed the Contributor License Agreement?
[ ] Have you checked that there aren't other open pull requests for the same manifest update/change?
[ ] This PR only modifies one (1) manifest
[ ] Have you validated your manifest locally with winget validate --manifest <path>?
[ ] Have you tested your manifest locally with winget install --manifest <path>?
[ ] Does your manifest conform to the 1.4 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

portable app

This package installed normally, but errored when launched:

Faulting application name: Nite.exe, version: 0.0.0.0, time stamp: 0x39854106
Faulting module name: Nite.exe, version: 0.0.0.0, time stamp: 0x39854106
Exception code: 0xc000041d
Fault offset: 0x00011b90
Faulting process id: 0x0x266C
Faulting application start time: 0x0x1D97EE55D17F494
Faulting application path: C:\Users\User\AppData\Local\Microsoft\WinGet\Packages\Andrelouis.NokiaInternalTuneEdit__DefaultSource\Nite.exe
Faulting module path: C:\Users\User\AppData\Local\Microsoft\WinGet\Packages\Andrelouis.NokiaInternalTuneEdit__DefaultSource\Nite.exe
Report Id: ab9bd053-e06b-47a1-8d42-2447abd4cd21
Faulting package full name:
Faulting package-relative application ID:

This package installed normally, but errored when launched:

Faulting application name: Nite.exe, version: 0.0.0.0, time stamp: 0x39854106
Faulting module name: Nite.exe, version: 0.0.0.0, time stamp: 0x39854106
Exception code: 0xc000041d
Fault offset: 0x00011b90
Faulting process id: 0x0x266C
Faulting application start time: 0x0x1D97EE55D17F494
Faulting application path: C:\Users\User\AppData\Local\Microsoft\WinGet\Packages\Andrelouis.NokiaInternalTuneEdit__DefaultSource\Nite.exe
Faulting module path: C:\Users\User\AppData\Local\Microsoft\WinGet\Packages\Andrelouis.NokiaInternalTuneEdit__DefaultSource\Nite.exe
Report Id: ab9bd053-e06b-47a1-8d42-2447abd4cd21
Faulting package full name:
Faulting package-relative application ID:

Is this Windows Sandbox

Is this Windows Sandbox

In a Windows 11 VM.

Try on a normal PC

Try on a normal PC

This also fails to launch for me on Win10 and Win11. I believe this is because it relies on several files in the same directory, which cannot be called through symlink

Try on windows 10 to see if it works

@upintheairsheep - Support for zipped binaries has now been added and is available in the pipelines. This will require you to update your submission to ManifestVersion: 1.9.0 and set ArchiveBinariesDependOnPath: true in the installer node. To keep things clean, this PR is being closed. Please submit a new PR for the latest version of this package. Thank you for your contributions!

authors: Trenly stephengillie upintheairsheep


text:
New package: AuraMarker.Lattics version 1.9.4

[X] Have you signed the Contributor License Agreement?
[X] Have you checked that there aren't other open pull requests for the same manifest update/change?
[X] This PR only modifies one (1) manifest
[X] Have you validated your manifest locally with winget validate --manifest <path>?
[X] Have you tested your manifest locally with winget install --manifest <path>?
[X] Does your manifest conform to the 1.4 schema?

Microsoft Reviewers: codeflow:open?pullrequest=https://github.com/microsoft/winget-pkgs/pull/110627&drop=dogfoodAlpha

@wingetbot waivers Add Validation-Domain

authors: SpecterShell stephengillie


text:
Update massCode to 3.7.0

[x] Have you signed the Contributor License Agreement?
[x] Have you checked that there aren't other open pull requests for the same manifest update/change?
[x] This PR only modifies one (1) manifest
[x] Have you validated your manifest locally with winget validate --manifest <path>?
[x] Have you tested your manifest locally with winget install --manifest <path>?
[x] Does your manifest conform to the 1.5 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

Automatic Validation ended with:

authors: stephengillie tiksn


text:
New version: Wasmer.Wasmer version 4.2.2

[X] Have you signed the Contributor License Agreement?
[X] Have you checked that there aren't other open pull requests for the same manifest update/change?
[X] This PR only modifies one (1) manifest
[X] Have you validated your manifest locally with winget validate --manifest <path>?
[ ] Have you tested your manifest locally with winget install --manifest <path>?
[X] Does your manifest conform to the 1.5 schema?

Microsoft Reviewers: Open in CodeFlow

@wingetbot waivers Add Validation-Executable-Error


text:
New version: JetBrains.IntelliJIDEA.Ultimate.EAP version 241.8102.112

This pull request is automatically generated by 🥟 Dumplings in #3157
Microsoft Reviewers: Open in CodeFlow

@wingetbot run

authors: SpecterShell mdanish-kh


text:
New version: eza-community.eza version 0.17.3

Pull request has been created with WinGet Releaser v2 :rocket:
Microsoft Reviewers: Open in CodeFlow

/AzurePipelines run

authors: cafkbot-winget stephengillie


text:
Remove version: OpenJS.NodeJS.LTS version 12.22.1

Replaced by another Pull Request
Microsoft Reviewers: Open in CodeFlow

https://www.github.com/microsoft/winget-pkgs/pull/143386#issuecomment-1986949152 [Policy] Needs-Author-Feedback

Close with reason: See discussion in above linked issue;

authors: CoolPlayLin mdanish-kh


text:
Remove Apifox.Apifox 2.5.6 to Ruihu.Apifox 2.5.6

[x] Have you signed the Contributor License Agreement?
[x] Have you checked that there aren't other open pull requests for the same manifest update/change?
[x] This PR only modifies one (1) manifest
[ ] Have you validated your manifest locally with winget validate --manifest <path>?
[ ] Have you tested your manifest locally with winget install --manifest <path>?
[ ] Does your manifest conform to the 1.6 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

URL: http://cdn.apifox.com/download/2.5.6/Apifox-2.5.6.exe
Status Code: 200
(Automated message - build 869)


text:
Remove Apifox.Apifox 2.2.38 to Ruihu.Apifox 2.2.38

Microsoft Reviewers: Open in CodeFlow

URL: http://cdn.apifox.cn/download/2.2.38/Apifox-2.2.38.exe
Status Code: 200
(Automated message - build 869)


text:
Remove LogMeIn.GoToMeeting 10.17.0.19796 to GoTo.GoToMeeting 10.17.0.19796

Microsoft Reviewers: Open in CodeFlow

URL: https://builds.cdn.getgo.com/builds/g2m/19796/G2MSetup10.17.19796_IT.msi
OK
(Automated message - build 887)


text:
Aserto.Topaz.v0.32.14

Checklist for Pull Requests

[x] Have you signed the Contributor License Agreement?
[ ] Is there a linked Issue?

Manifests

[x] Have you checked that there aren't other open pull requests for the same manifest update/change?
[x] This PR only modifies one (1) manifest
[x] Have you validated your manifest locally with winget validate --manifest <path>?
[x] Have you tested your manifest locally with winget install --manifest <path>?
[x] Does your manifest conform to the 1.6 schema?

Note: <path> is the directory's name containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

/azp run

authors: gertd hackean-msft


text:
Remove version: Google.Chrome.Canary version 131.0.6764.0

All InstallerUrls returned 404 Not Found

https://dl.google.com/release2/chrome/acq6c4qcnvq7gslehxiuweqr36jq_131.0.6764.0/131.0.6764.0_chrome_installer.exe
https://dl.google.com/release2/chrome/adjdh4bt72ufcap5rxzflj5hhyxa_131.0.6764.0/131.0.6764.0_chrome_installer.exe
https://dl.google.com/release2/chrome/ed6k66rxl5qqhhdaypnnvmtgfu_131.0.6764.0/131.0.6764.0_chrome_installer.exe

Microsoft Reviewers: Open in CodeFlow

/azp run


text:
Remove version: RoyQu.RedPanda-C++ version 2.4

[Automated] It returns code over 400 in all urls
Microsoft Reviewers: Open in CodeFlow

Close with reason: URL works;


text:
Remove version: IvoSoft.ClassicShell version 4.3.1

[Automated] It returns code over 400 in all urls
Microsoft Reviewers: Open in CodeFlow

Close with reason: URL works;


text:
New package: ScooterSoftware.BeyondCompare4 version 4.4.7

Pull request has been created with komac v2.6.0 :rocket:
Microsoft Reviewers: Open in CodeFlow

@microsoft-github-policy-service agree

@microsoft-github-policy-service agree


text:
GitVersion: added version 5.11.1

[ x ] Have you signed the Contributor License Agreement?
[ x ] Have you checked that there aren't other open pull requests for the same manifest update/change?
[ x ] Have you validated your manifest locally with winget validate --manifest <path>?
[ x ] Have you tested your manifest locally with winget install --manifest <path>?
[ ] Does your manifest conform to the 1.2 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

@microsoft-github-policy-service agree [company="GitTools"]

@microsoft-github-policy-service agree company="GitTools"

The warning is only because this is a zip manifest, and zip files are to be supported in WinGet 1.4. At that point, the pipelines will have support for 1.4 manifests and all PRs marked with .zip will be re-ran.

authors: arturcic russellbanks


text:
5 second delay when opening Xt dialogs

Environment
Windows build number: 10.0.21390.2025
Your Distribution version: Ubuntu 20.04 LTS
Your WSLg version: 1.0.22 (Windows Subsystem for Linux WSLg Preview)

Steps to reproduce

Install "nedit" with:

sudo apt install nedit

Run "nedit"
Press CTRL+s to save file

This should imediately display a file save dialog, but there is a 5 second delay before it appears.  This does not occur on Ubuntu 20.04 running Wayland in a standard VM or bare metal.  The Xt call that is blocking is "XtManageChild":
#0  0x00007ffff7527ac7 in __GI___poll (fds=0x7fffffff7b40, nfds=1, timeout=4289)
at ../sysdeps/unix/sysv/linux/poll.c:29
#1  0x00007ffff78bce7a in _XtWaitForSomething () from /lib/x86_64-linux-gnu/libXt.so.6
#2  0x00007ffff78ca8a8 in ?? () from /lib/x86_64-linux-gnu/libXt.so.6
#3  0x00007ffff7c6c5ad in ?? () from /lib/x86_64-linux-gnu/libXm.so.4
#4  0x00007ffff78b4d56 in _XtMakeGeometryRequest () from /lib/x86_64-linux-gnu/libXt.so.6
#5  0x00007ffff78b4f80 in XtMakeGeometryRequest () from /lib/x86_64-linux-gnu/libXt.so.6
#6  0x00007ffff7b854c8 in ?? () from /lib/x86_64-linux-gnu/libXm.so.4
#7  0x00007ffff78bbdb9 in ?? () from /lib/x86_64-linux-gnu/libXt.so.6
#8  0x00007ffff78bc26e in XtManageChildren () from /lib/x86_64-linux-gnu/libXt.so.6
#9  0x00007ffff78bc378 in XtManageChild () from /lib/x86_64-linux-gnu/libXt.so.6
#10 0x0000555555620177 in ?? ()
#11 0x000055555561cb2d in ?? ()
#12 0x000055555558e281 in ?? ()
#13 0x000055555558f0f6 in ?? ()
#14 0x00007ffff78d047b in XtCallActionProc () from /lib/x86_64-linux-gnu/libXt.so.6
#15 0x00007ffff7bd1ec2 in ?? () from /lib/x86_64-linux-gnu/libXm.so.4
#16 0x00007ffff7c79731 in ?? () from /lib/x86_64-linux-gnu/libXm.so.4
#17 0x00007ffff7c7990d in ?? () from /lib/x86_64-linux-gnu/libXm.so.4
#18 0x00007ffff7c799dc in _XmRC_KeyboardInputHandler () from /lib/x86_64-linux-gnu/libXm.so.4
#19 0x00007ffff78b22be in XtDispatchEventToWidget () from /lib/x86_64-linux-gnu/libXt.so.6
#20 0x00007ffff78b283d in ?? () from /lib/x86_64-linux-gnu/libXt.so.6
#21 0x00007ffff78b2919 in XtDispatchEvent () from /lib/x86_64-linux-gnu/libXt.so.6
#22 0x00007ffff78be5cf in XtAppProcessEvent () from /lib/x86_64-linux-gnu/libXt.so.6
#23 0x00007ffff78b2d2d in XtAppMainLoop () from /lib/x86_64-linux-gnu/libXt.so.6
WSL logs:
pulseaudio.log
weston.log
versions.txt
Expected behavior
Dialog should appear immediately
Actual behavior
Dialog appears after a 5 second delay.

I confirm this bug also in other X11 applications on WSLG. The delay to pop-up dialog windows can be even longer than 5 seconds.

@badjames, thanks for reporting the issue, I confirmed this does repro with the latest WSLg. Using nedit, it doesn't occur to every dialog, like CTRL+O and ALT+I come up immediately, but it does have delay like CTRL+S, SHIFT+CTRL+F and SHIFT+CTRL+R,
@dpeterc, thanks for info, would you please share what-else X11 applications do you observe this issue? thanks!

I'm not sure what the difference between the nedit file "open" and "save" actions are that cause the delay in one but not the other.
I did run nedit under xtruss and it appears the hang is at the point that the WM_SIZE_HINTS property is set:
ChangeProperty(window=w#0040025F, property=a"WM_NORMAL_HINTS", type=a"WM_SIZE_HINTS", format=32, mode=Replace, data=0000022C:000004FF:000002CF:000001F4:000001B0:00000000:00000000:00000EE7:00000497:00000000:00000000:00000000:00000000:00000000:00000000:...)
In the code, it is the XtManageChild call that hangs.
Hope this helps!

The other X11 applications where I observe this issue are
ddd (data display debugger)
grace (xmgrace scientific visualization software)
These are all Motif applications, so menus do not work (already reported in a different bug report), so menu entries need to be called from the shortcut while the menu is open by mouse (for example Ctrl+o).
Popup windows open after considerable delay (several seconds). But if you call them the next time, it is fast.
Usually these programs create the whole user interface widget tree at the startup, so opening of dialog windows should be instant, once the main application window is up and running.

authors: badjames dpeterc hideyukn88

repo: microsoft/wslg


text:
use YAML.unsafe_load to support Ruby 3.1/Psych 4

Since YAML.load has been changed to an alias of Psych.safe_load from Ruby 3.1/Psych 4.0, using Date, Time, etc. cause raise owing to prohibiting of class loading at frontmatter.
https://github.com/ruby/psych/pull/487
To avoid this problem, use YAML.unsafe_load if it is definded (YAML.load is renamed to YAML.unsafe_load).
I think this is better implementation because

This frontmatter comes from developer's input, so it may be treated as safe input.
This modification will not break previous behavior of Middleman.

but you can choose passing permitted_classes option to YAML.load to fix vulnerability.

Hi @gyugyu 👋🏼 That seems fine! But in order to get a green ✅ build, could you please rebase middleman:4.x?

authors: gyugyu markets

repo: middleman/middleman


text:
Conflicting type "time"

This is conflicting with the Doctrine Core "time" type, need to rename it.

This is fixed in code now but still needs to be updated in the README.


text:
Remove HMAC-MD5 support from TSIG

The Wikipedia article for TSIG claims that HMAC-MD5 is "still in common usage", but doesn't provide any source for this. If there's no one who desperately needs this, I'd like to remove it entirely.
MD5 is a severely broken algorithm so it would be great to get it out of this library, even removing legacy support.
Considering that the TSIG algorithm is set by the TSIG record and not by the secret key (!! see the JWT token mess), an exploitable weakness in HMAC-MD5 could allow easy forging of TSIG records even on systems that do not otherwise use MD5.

@miekg It would be good to have it formally deprecated. This is an easy revert at least if people need HMAC-MD5 and can’t easily update.

Hey @miekg, I am part of the DNS team in NS1 and just saw that the support for hmac-md5 algorithm is removed. Unfortunately, our customers still make heavy use of this algorithm in our systems thus we have to support it. Further, RFC  https://tools.ietf.org/html/rfc6151 also states that it is not urgent to stop using HMAC-MD5 (Section 2, Security Considerations).
We have a plan of migrating customers eventually away from hmac-md5, but this will take time. In the meantime, is it possible to re-add support for it in the library since it prohibits us from updating to newer versions?

@apantelopoulosNS1 That is quite unfortunate, ridding this library of ancient algorithms is definitely a goal of mine. I would encourage you to migrate as promptly as you can, because it really isn’t a good algorithm or something that should be kept around anywhere at all.
Just for the record RFC 6151 is now a full decade old, so I wouldn’t rush to it for security advice. I can’t seem to find much recent discussion on how secure HMAC-MD5 is or isn’t though.
I can open a revert PR, but now we have a TsigProvider you could potentially quite trivially implement it yourself by copying the built in HMAC provider code and adding it. Would that satisfy your use case or shall I open a revert PR?

Hello @tmthrgd, thanks for responding so quickly! We decided to use TsigProvider as you pointed out to implement this functionality, thus there is no need for a revert PR. 👍

@tmthrgd hey! I have a question regarding the TsigProvider interface. It seems that the provider functions are not exposed and we can't use them?
(original comment/question)
https://github.com/miekg/dns/issues/1254#issuecomment-912983457

@tmthrgd I think TsigProvider is not in a state that can be used right now. It's only supported when you are client and there is no use of it in xfr or server.
Also, the TsigProvider does not support using the current secret for the processed packet so when acting as a server you should know all the secrets beforehand which is not always possible.
https://github.com/miekg/dns/blob/master/client.go#L349
co.TsigSecret[t.Hdr.Name] vs just co.TsigProvider
This makes support of MD5 nearly impossible unless we change the whole TsigProvider implementation to also use the t.Hdr.Name which breaks backwards compatibility.
Please tell me if I am wrong with the above mentioned.

authors: apantelopoulosNS1 dmavrommatis tmthrgd

repo: miekg/dns


text:
Provide a LayoutComplete event for View

It is very common for apps and Views to need to know when they have been resized or their layout otherwise changed.
People are currently using Application.Loaded to get initial sizing or Application.Resized to get notified when the terminal size changes.
But neither of these are useful for when a parent view's size changes independently of the terminal sizing. In preparation for being able to resize windows (e.g. consider the left & right panes of UI Catalog being resizable) we need a way for Views to know their layout has changed. It's possible to do this in a sub-class by overriding LayoutSubviews but this doesn't help app writers.
I'm proposing a new API for View to address this:
		/// <summary>
		/// Event arguments for the <see cref="LayoutComplete"/> event.
		/// </summary>
		public class LayoutEventArgs : EventArgs {
			/// <summary>
			/// The view-relative bounds of the <see cref="View"/> before it was laid out.
			/// </summary>
			public Rect OldBounds { get; set; }
		}

		/// <summary>
		/// Fired after the <see cref="LayoutSubviews"/> method has completed.
		/// </summary>
		/// <remarks>
		/// Subscribe to this event to perform tasks when the <see cref="View"/> has been resized or the layout has otherwise changed.
		/// </remarks>
		public event EventHandler<LayoutEventArgs> LayoutComplete;

		/// <summary>
		/// Raises the <see cref="LayoutComplete"/> event. Called from  <see cref="LayoutSubviews"/> after all sub-views have been laid out.
		/// </summary>
		internal virtual void OnLayoutComplete (LayoutEventArgs args)
		{
			LayoutComplete?.Invoke (this, args);
		}

Existing classes that override LayoutSubViews, like Dialog can use this isntead:
		public Dialog (ustring title, int width, int height, params Button [] buttons) : base (title, padding: padding)
		{
			X = Pos.Center ();
			Y = Pos.Center ();
			Width = width;
			Height = height;
			ColorScheme = Colors.Dialog;
			Modal = true;

			if (buttons != null) {
				foreach (var b in buttons) {
					this.buttons.Add (b);
					Add (b);
				}
			}

			LayoutComplete += (sender, a) => AdjustButtonLayout ();
		}

		void AdjustButtonLayout ()
		{
			int buttonSpace = 0;
			int maxHeight = 0;

			foreach (var b in buttons) {
				buttonSpace += b.Frame.Width + 1;
				maxHeight = Math.Max (maxHeight, b.Frame.Height);
			}
			const int borderWidth = 2;
			var start = (Frame.Width - borderWidth - buttonSpace) / 2;

			var y = Frame.Height - borderWidth - maxHeight - 1 - padding;
			foreach (var b in buttons) {
				var bf = b.Frame;

				b.Frame = new Rect (start, y, bf.Width, bf.Height);

				start += bf.Width + 1;
			}
		}

in demo.cs:
		var bottom = new Label ("This should go on the bottom of the same top-level!");
		win.Add (bottom);
		var bottom2 = new Label ("This should go on the bottom of another top-level!");
		top.Add (bottom2);

		top.LayoutComplete += (sender, e) => {
			bottom.X = win.X;
			bottom.Y = Pos.Bottom (win) - Pos.Top (win) - margin;
			bottom2.X = Pos.Left (win);
			bottom2.Y = Pos.Bottom (win);
		};

Etc...
I've got a PR basically ready but want input before I submit it. Thoughts?

Questions I have:

What properties do subscribers really care about? I assumed OldBounds, but maybe OldFrame is better? I note that Dialog uses Frame (I think incorrectly) to re-layout buttons. I say incorrectly, because the buttons should be located using view-relative coords.
Is there a need for a 'pre' Layout event as well? I can't think of any use case, and I've not found any code that overrides LayoutSubViews that does pre-processing, so I'm guess no.

It depends on the value being passed, whether it be from Frame or Bounds. Frame is relative to the position of the View on the screen and the Bound is relative to 0.0, Frame.Width, Frame.Heigth. By the way, the Frame has to be redesigned so that it can have negative X and Y axes so that they are not drawn while the values are negative and also cannot be drawn if the values are greater than their container

The new DrawWindowFrame code is defensive to negative values.

authors: BDisp tig


text:
Feature #94 Toast 컴포넌트 작성 및 기능 추가

Closes #94
변경사항:

Toast 컴포넌트를 작성했습니다.
ToastProvider를 작성하여 전역에서 toast를 사용할 수 있도록 구현했습니다.
Icon 컴포넌트를 작성했습니다. 추후 기존 사용하는 components/Icons 파일과 통합하면 좋을 것 같습니다.

확인할 목록:

toastMessage는 아래와 같이 사용하면 됩니다.

const { openToast } = useToastMessage();
openToast({ message: 'successDeleteMemory' }); // 삭제가 완료되었습니다. 새로운 추억을 만들어보세요.

toast message의 목록을 constants로 저장했으며, lib/constant/toastMessage.ts 파일에서 확인할 수 있습니다.

빌드 실패하네요..! 확인 한 번만 부탁드려욥

repo: miind-palace/mind-palace-FE


text:
Feature: add opt-in "unitlessPrecision" flag for line heights

feat(tokens): add unitlessPrecision config for lineHeights

opt-in config flag allowing to set the decimals precision (defaults to 2: current hardcoded value)
improve parseCliArgs function (preserve arguments sorting order)
add unit-test cases for new config flag
mention how to override in README.md

fix(types): refactor parseCliArgs with typed setConfigValue
refactor: attempt to reduce SonarCloud warnings

try to reduce duplicate implementations in parseCliArgs
immediate return of lineHeightTokens reduce result

I missed that one so far but I have a need to customize that precision in some cases (to more than 2 decimals)

Reduced CS from 15 to 3, others are on other parts I did not really touch ;)

Thanks! Merging

Great :)
Can you keep me in touch when you release a new patch?

authors: flo-sch mikaelvesavuori

repo: mikaelvesavuori/figmagic


text:
Place inside anonymous function

See link for benefits: https://stackoverflow.com/questions/2421911/what-is-the-purpose-of-wrapping-whole-javascript-files-in-anonymous-functions-li

New release done from this: https://github.com/mikaturunen/ng-onload/releases/tag/v0.7.0

authors: Piccirello mikaturunen

repo: mikaturunen/ng-onload


text:
VS2015 options missing

I cant find the colour options, eg, LogCustom1 in tools options in VS2015?
the default colour for warnings makes it almost unreadable.

I have the same problem, even after uninstalling/reinstalling the extension. If I get a chance I'll try to help track it down

Moved colors in beta 1 to VSColorOutput options window.

authors: kenwarner mgwalm mike-ward

repo: mike-ward/VSColorOutput


text:
add .toJSON method to all objects

Because we add a ton of circular references we need:

request.Request.prototype.toJSON()
add .toJSON method to http.ClientRequest and http.ClientResponse

If we don't add this soon I'm going to lose my sanity.

i'm not releasing 3.0 without this.

repo: mikeal/request


text:
Tests seem to be failing?

davida@suki ~/s/node-github> mocha api/v3.0.0/authorizationTest.js

  ․․․․․

  3 passing (8s)
  2 failing

  1) [authorization] should successfully execute GET /authorizations (getAll):
     Uncaught AssertionError: 41 == 2
      at /Users/davida/src/node-github/api/v3.0.0/authorizationTest.js:48:32
      at /Users/davida/src/node-github/api/v3.0.0/authorization.js:59:17
      at IncomingMessage.<anonymous> (/Users/davida/src/node-github/index.js:752:21)
      at IncomingMessage.EventEmitter.emit (events.js:117:20)
      at _stream_readable.js:910:16
      at process._tickCallback (node.js:415:13)

  2) [authorization] should successfully execute PATCH /authorizations/:id (update):
     Error: timeout of 2000ms exceeded
      at null.<anonymous> (/usr/local/lib/node_modules/mocha/lib/runnable.js:175:14)
      at Timer.listOnTimeout [as ontimeout] (timers.js:110:15)

This issue is very outdated so I’m going to close it :) We are working on bringing back tests as part of the transition to the @octokit org: https://github.com/octokit/discussions/issues/7

repo: mikedeboer/node-github


text:
How can I disable PanMode some specific area?

I have to a view controller and I need to enable pan mode in it. I did it like this
-(void)viewDidAppear:(BOOL)animated
{
[super viewDidAppear:animated];
self.menuContainerViewController.panMode=MFSideMenuPanModeDefault;//enable pan mode only rootview controller
}
But I need to add UISlider on that view controller. So I want to disable pan mode on only that area. Otherwise UISlider not work on smoothly. How can I do that?

I solved the issue with UISliders this way:

In MFSideMenuContainerViewController.m find the method with the signature.

(BOOL)gestureRecognizer:(UIGestureRecognizer *)gestureRecognizer shouldReceiveTouch:(UITouch *)touch

Add the following at the beginning.
if ([touch.view isKindOfClass:[UISlider class]]) {
return NO;
}

authors: HemalAsanka bendigi

repo: mikefrederick/MFSideMenu


text:
[Question]: How to properly extract text from BODY?

Hello, could you please help me to understand how to do it right?
There is this body in my pr
## Release Notes

### Dropdown

some text

### What/why Changed

some text

some text

And I would like to take only part that is between  ## Release Notes and  ### What/why Changed
In the documentation I've found information about custom_placeholders
This is part of my configuration
{
    "pr_template": "#{{DESC}}\n\n#{{TITLE}} (#{{URL}})\n\n",
    "custom_placeholders": [
      {
        "name": "DESC",
        "source": "BODY",
        "transformer": {
            "pattern": "(?:## Release Notes)(.*)(?:### What\/why Changed)",
            "flags": "s",
            "target": "$1"
        }
      }
    ]
}

I don’t understand what I’m doing wrong
## Components

  ### Dropdown

  - some text
  - some text
  - some text

some text

    📦 Published PR as canary version: Canary Versions

    :sparkles: Test out this PR locally via:

  feat: add Dropdown (url)

I expect to see this result
## Uncategorized
### Dropdown

some text

pr_title (#222)

I would be grateful for your help!

The custom_placeholders use javascripts replace method.
As far as I can observe, I suppose you would expect it to use match instead?
(debugger preview with match in use, which would do what you expect)

you would expect it to use match instead

Yep =)
I expected that 1$ is the result of a regular expression and that it will replace its BODY.

Unfortunately the replace function of JavaScript works differently
You can best test its behavior here for example: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/replace
const paragraph = "## Release Notes\n\n### Dropdown\n\nsome text\n\n### What/why Changed\n\nsome text\n\nsome text";

const regex = /(?:## Release Notes)(.*)(?:### What\/why Changed)/s;

// this is the behaviour within the action
console.log("FIRST EXAMPLE");
console.log(paragraph.replace(regex, '$1'));

// this would be the result of match (which returns an array, and has no target)
console.log("SECOND EXAMPLE");
console.log(paragraph.match(regex));

// the index 1 result of the match array
console.log("THRID EXAMPLE");
console.log(paragraph.match(regex)[1]);

I would love to find a better solution with javascript which would work like match, and has the support for the "target" - as that would most of the times be the most convenient way of doing things.

authors: Yakutoc mikepenz


text:
add days it takes to close a pr to repos.pulls

Signed-off-by: Mike Ng ming@redhat.com
@chenz4027 @harryli256
an example of how to update the db entries with new field

which allows you to do queries like
db.repos.pulls.aggregate([{$match: {"repo_name": "_put_repo_name_here_"}}, { $group: { _id:null, averageDaysToClose: { $avg: "$days_to_close" } } } ])

which can be market it as "prediction" of how long a new PR will be close.

or even better just do this which gives you a repo per repo_name
db.repos.pulls.aggregate([{"$group":{"_id":"$repo_name","averageDaysToClose":{"$avg":"$days_to_close"}}}])

repo: mikeshng/github-data-mining


text:
Typo in JsonParseException- has 'falied' instead of 'failed'.

        internal JsonParseException(JsonParser parser, string message)              : base($"Parsing falied: {message} (at position {parser.CurrentPosition})")         {             this.Position = parser.CurrentPosition;         }

fixed, thanks for reporting it!


text:
Add extension to default CLI config filename

Describe the bug
Currently, without configure anything on package.json, the CLI by default search by a config filename cli-config without extension.
Expected behavior
I think it should search by a config filename cli-config.js with extension.
Additional context
I too would suggest use, by default, a more typical filename as mikro-orm.config.js or mikro-cli.config.js (as others: Webpack: webpack.config.js, Babel: babel.config.js)
Versions

Dependency
Version

node
10.16.3

typescript
3.6.2

mikro-orm
3.0.0-alpha.16

your-driver
mariadb

Yeah I am also thinking about using different default filename (cli-config comes from doctrine), mikro-orm.config.js/ts sounds good I guess.
About the extension, the idea was that cli-config will resolve to both cli-config.js and cli-config.ts (that is how node's require work). I totally forgot to try this out, as I immediately used paths from package.json. Will fix that so it will search for both js/ts extensions.

I'm using src/db/mikro-config.ts cause I use the same config file for both the cli and the app.
  "mikro-orm": {
    "useTsNode": true,
    "configPaths": [
      "./src/db/mikro-config.ts"
    ]
  }

That is a name of my first nodejs package :P
The name here is MikroORM so I would prefer mikro-orm.config. But that is the reason why I allowed to specify the path including file name, so one can pick whatever filename suites them best.

Implemented in 3.0.0-alpha.18, the file is now called mikro-orm.config.js, if you enable ts-node, then also mikro-orm.config.ts is searched for (and has priority).

authors: B4nan localnet lookfirst

repo: mikro-orm/mikro-orm


text:
json columnType data are automatically casted to jsonb in Postgres

Describe the bug
When I use json value for columnType property of @Property decorator option in entity definition class, mikro-orm automatically typecasts inserted data via ::jsonb. Is this intentional? I use json postgres type specifically to avoid json properties reordering of jsonb type, but thanks to automatic jsonb typecast the properties are still being reordered.
The workaround for this is not using columnType option at all, and instead use just type: JsonType.
Versions

Dependency
Version

mikro-orm
5.7.10

Sure. If I have entity definition like this
@Entity()
export class Book {
  @Property({ type: 'json', nullable: true })
  meta?: { foo: string; bar: number };
}

Mikro autocasts inserted data via ::jsonb
But if I keep it like this, it won't typecast to ::jsonb
@Entity()
export class Book {
  @Property({ type: JsonType, nullable: true })
  meta?: { foo: string; bar: number };
}

Or am I doing something wrong?

Well, it does not behave like that, we have tests for those cases, type: 'json' and type: JsonType is exactly the same thing, those are alternative ways to do the same, unlike the columnType option which serves as a way to override the default mappings. Are you on latest already?
If you pass a known mapping from those to the type option as a string, it will be used. And both of those will default to jsonb column in schema generator. You are mentioning ::jsonb which is casting, so you are probably not talking about schema generation. That's why I am asking for reproduction, not entity definition, show me what you are doing.

I think I understand what you are talking about. There is this line which is probably causing it. I've already refactored this away in v6.
I will close this, as the problem is no longer present in v6, just verified in this test case.
I won't be backporting things at this stage, if this is a problem for you, I'd suggest giving v6 a try. Upgrading guide is here.

I think I understand what you are talking about. There is this line which is probably causing it. I've already refactored this away in v6.
I will close this, as the problem is no longer present in v6, just verified in this test case.
I won't be backporting things at this stage, if this is a problem for you, I'd suggest giving v6 a try. Upgrading guide is here.

Yes this seems like the issue I was referring to. Thanks

Yeah closing again, this was removed as part of this commit, there were some bad rebases which caused some confusing history.
https://github.com/mikro-orm/mikro-orm/commit/9d2ccea2873babd4b438cfe1486ec6a263eeb109


text:
feat(core): automatically detect src/dist/build folders and adjust configuration

If there is a src folder, the ORM will now automatically detect it and adjust the seeder and migrations configs to have both path and pathTs set based on that. This happens only if there are no values provided by user and the default folders don't exist.
For a fresh project, this means that if you omit the configuration, but your project has a src and dist folders existing, the ORM will automatically set the following:

migrations.path to ./dist/migrations
migrations.pathTs to ./src/migrations
seeder.path to ./dist/seeders
seeder.pathTs to ./src/seeders

In addition to this, the CLI no longer requires explicit configuration of configPaths in package.json, as long as your config is called mikro-orm.config.js/ts and is located in src or dist/build folder. useTsNode flag is still required.

Codecov Report
Base: 99.90% // Head: 99.82% // Decreases project coverage by -0.08% :warning:

Coverage data is based on head (4f0d6aa) compared to base (d9cdf98).
Patch coverage: 50.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3497      +/-   ##
==========================================
- Coverage   99.90%   99.82%   -0.09%
==========================================
  Files         205      205
  Lines       12831    12852      +21
  Branches     2976     2981       +5
==========================================
+ Hits        12819    12829      +10
- Misses         12       23      +11

Impacted Files
Coverage Δ

packages/sqlite/src/index.ts
100.00% <ø> (ø)

packages/core/src/utils/Configuration.ts
91.17% <31.25%> (-8.00%)
:arrow_down:

packages/core/src/utils/ConfigurationLoader.ts
99.40% <100.00%> (+0.01%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


text:
Setup sbt-ci-release

@milessabin I think all that is left should be to setup GPG:
https://github.com/olafurpg/sbt-ci-release#gpg

Will need to follow up with a downgrade to openjdk8.

It looks like this is only publishing for 2.11 ...

repo: milessabin/shapeless


text:
Update README.md

Added some links to contributors.

Wow, this is the kindest pull request I've ever received, thanks for the typo corrections also! :)

authors: lvictorino milgra

repo: milgra/highsierramediakeyenabler

license: unlicense


text:
Support custom commands for milvus components

Signed-off-by: shaoyue.chen shaoyue.chen@zilliz.com
/cc @zwd1208

/lgtm

repo: milvus-io/milvus-operator


text:
feat(TLS): Support skipCertCheck option to bypass certificate check

This new skipCertCheck option allows for connecting to Milvus instances with self-signed certificates, without the need to pass the certificate directly.
Signed-off-by: Zander Bobronnikov Zander.Bobronnikov@ibm.com

This will be released util milvus 2.5. I guess in 1 or two weeks.

authors: shanghaikid zander-bobronnikov

repo: milvus-io/milvus-sdk-node


text:
Decouple Trusty engine from Trusty SDK structs.

Summary
This change aims to limit the impact of changes deriving from Trusty SDK to fewer lines of code. Specifically, business logic implemented in Trusty evaluation engine looks into the response as returned by the SDK itself, making it harder to move to Trusty API v2.
Note: this change is meant to be bug-compatible with the current Trusty evaluation engine.
Change Type

[ ] Bug fix (resolves an issue without affecting existing features)
[ ] Feature (adds new functionality without breaking changes)
[ ] Breaking change (may impact existing functionalities or require documentation updates)
[ ] Documentation (updates or additions to documentation)
[X] Refactoring or test improvements (no bug fixes or new functionality)

Testing
Manual testing and unit testing.
Review Checklist:

[X] Reviewed my own code for quality and clarity.
[X] Added comments to complex or tricky code sections.
[ ] Updated any affected documentation.
[ ] Included tests that validate the fix or feature.
[X] Checked that related changes are merged.

Tested locally and it works as it did before. Note that the existing bugs #4944 and #4945 are still present, but unrelated to this PR.

❤ Thank you so much for looking into this thoroughly! 🙏

repo: mindersec/minder