text:
Bump dependencies

A fix in Go 1.18 breaks jsoniter because of its dependencies. They have patched this: https://github.com/json-iterator/go/commit/024077e996b048517130b21ea6bf12aa23055d3d
If there are no complications and it's easy, we should bump our dependencies in 0.3.0. If that does present challenges we should release 0.3.0 and bump deps in 0.3.1.
Then, we should update tests as per https://github.com/snowplow/snowplow-golang-analytics-sdk/issues/30

Indeed bumping deps seems to fix it: https://github.com/snowplow/snowplow-golang-analytics-sdk/runs/6488532955?check_suite_focus=true
We should be able to bump this and also add matrix testing in release 0.3.0.

repo: snowplow/snowplow-golang-analytics-sdk


text:
Scala Common Enrich: add Adapter to pre-process Olark events

Here is a test event:
{"line":"2014-09-30\t18:23:06\t-\t-\t166.78.182.125\tPOST\t166.78.182.125\t/com.olark/v1\t200\t-\tTwisted+PageGetter\t&cv=clj-0.8.0-tom-0.1.0&nuid=dfd9febf-8620-4e3e-ba49-26d60bf12ee7\t-\t-\t-\tapplication%2Fx-www-form-urlencoded\tZGF0YT0lN0IlMjJpdGVtcyUyMiUzQSslNUIlN0IlMjJib2R5JTIyJTNBKyUyMkhpK3RoZXJlK2Zyb20rT2xhcmslMjErJTNBJTI5JTIyJTJDKyUyMnRpbWVzdGFtcCUyMiUzQSslMjIwJTIyJTJDKyUyMmtpbmQlMjIlM0ErJTIyVGVzdE1lc3NhZ2UlMjIlN0QlNUQlMkMrJTIya2luZCUyMiUzQSslMjJUZXN0JTIyJTJDKyUyMm9wZXJhdG9ycyUyMiUzQSslN0IlMjIyJTIyJTNBKyU3QiUyMmVtYWlsQWRkcmVzcyUyMiUzQSslMjJvcCU0MG9sYXJrLmNvbSUyMiUyQyslMjJraW5kJTIyJTNBKyUyMk9wZXJhdG9yJTIyJTJDKyUyMm5pY2tuYW1lJTIyJTNBKyUyMlRlc3RPcGVyYXRvciUyMiUyQyslMjJpZCUyMiUzQSslMjIyJTIyJTdEJTdEJTJDKyUyMmlkJTIyJTNBKyUyMjElMjIlMkMrJTIydmlzaXRvciUyMiUzQSslN0IlMjJjaXR5JTIyJTNBKyUyMlBhbG8rQWx0byUyMiUyQyslMjJraW5kJTIyJTNBKyUyMlRlc3RWaXNpdG9yJTIyJTJDKyUyMmNvdW50cnlDb2RlJTIyJTNBKyUyMlVTJTIyJTJDKyUyMmNvdW50cnklMjIlM0ErJTIyVW5pdGVkK1N0YXRlcyUyMiUyQyslMjJyZWdpb24lMjIlM0ErJTIyQ0ElMjIlMkMrJTIyb3BlcmF0aW5nU3lzdGVtJTIyJTNBKyUyMldpbmRvd3MlMjIlMkMrJTIyZW1haWxBZGRyZXNzJTIyJTNBKyUyMnN1cHBvcnQlNDBvbGFyay5jb20lMjIlMkMrJTIyaXAlMjIlM0ErJTIyMC4wLjAuMCUyMiUyQyslMjJvcmdhbml6YXRpb24lMjIlM0ErJTIyT2xhcmslMjIlMkMrJTIyZnVsbE5hbWUlMjIlM0ErJTIyb2xhcmtUZXN0ZXIlMjIlMkMrJTIyaWQlMjIlM0ErJTIyMSUyMiUyQyslMjJicm93c2VyJTIyJTNBKyUyMk5ldHNjYXBlKzEuMCUyMiU3RCU3RA","errors":["Payload with vendor com.olark and version v1 not supported by this version of Scala Common Enrich"]}

https://www.olark.com/help/webhooks

Bringing forwards - we are going to go for 5 webhooks in this release...

Update: 4 webhooks

Please do this one before Marketo

source: gharchive/issue

repo: snowplow/snowplow

license_type: permissive

license_source: bigquery


text:
Ordering of checks in flipOrientation causes failure on 23andme data with "I" genotypes

from https://github.com/snpeek/snpeek.github.io/blob/main/src/index.ts#L303-L310
function flipOrientation (genotype: string): string {
  if (genotype.length !== 2) {
    throw new Error('Invalid genotype')
  }
  if (!IsNucleotide(genotype)) {
    console.log(`found odd genotype=${genotype}`)
    return genotype // we don't need to flip II genotypes
  }

Having the isNucleotide check after the length check causes total failure (no results reported, "Invalid genotype" error in the JS console), I believe due to lines that look like this in 23andme data:
rs[redacted]	X	[redacted number]	G
rs[redacted]	X	[redacted number]	I

It's possible that reordering the checks still causes issues since it would still cause an error with the single-letter genotypes, of which there are some, at least in my V5 23andme file.
I was able to get past this by removing the if (genotype.length !== 2) check in the minified JS.
For reference, the header of the 23andme file looks like:
# This data file generated by 23andMe at: Fri May 05 15:27:52 2023
#
# This file contains raw genotype data, including data that is not used in 23andMe reports.
# This data has undergone a general quality review however only a subset of markers have been
# individually validated for accuracy. As such, this data is suitable only for research,
# educational, and informational use and not for medical or other use.
#
# Below is a text version of your data.  Fields are TAB-separated
# Each line corresponds to a single SNP.  For each SNP, we provide its identifier
# (an rsid or an internal id), its location on the reference human genome, and the
# genotype call oriented with respect to the plus strand on the human reference sequence.
# We are using reference human assembly build 37 (also known as Annotation Release 104).
# Note that it is possible that data downloaded at different times may be different due to ongoing
# improvements in our ability to call genotypes. More information about these changes can be found at:
# https://you.23andme.com/p/0abf9c75b2a78406/tools/data/download/
#
# More information on reference human assembly builds:
# https://www.ncbi.nlm.nih.gov/assembly/GCF_000001405.13/
#
# rsid	chromosome	position	genotype

and the file name is genome_[redacted]_[redacted]_v5_Full_20230505152752.txt

Oh interesting, the 23andme data I have doesn't have any single letter genotypes. I put the check there just as a sanity check. Does skipping if a single letter genotype is found sound good?

I believe this is solved now.

license: MIT

license_source: github-api


text:
[Snyk] Security upgrade com.thoughtworks.xstream:xstream from 1.4.18 to 1.4.21

Snyk has created this PR to fix 1 vulnerabilities in the maven dependencies of this project.
Snyk changed the following file(s):

gradebookng/impl/pom.xml

Vulnerabilities that will be fixed with an upgrade:

Issue
Score
Upgrade

Deserialization of Untrusted Data SNYK-JAVA-COMTHOUGHTWORKSXSTREAM-8352924
  227
com.thoughtworks.xstream:xstream:  1.4.18 -> 1.4.21  Proof of Concept

[!IMPORTANT]

Check the changes in this PR to ensure they won't cause issues with your project.
Max score is 1000. Note that the real score may have changed since the PR was raised.
This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic

Learn how to fix vulnerabilities with free interactive lessons:
🦉 Deserialization of Untrusted Data

:tada: Snyk checks have passed. No issues have been found so far.
:white_check_mark: code/snyk check is complete. No issues have been found. (View Details)

source: gharchive/pull-request

authors: amacsnyk dylansnyk

repo: snyk-cs-goof-org/java-monorepo-goof


text:
Use second most recent tag in changelog script

Description
Since the tag is already created when releasing, we need to compare commits based on the second most recent tag, not the default branch. For now we just get an empty changelog so goreleaser fallback to its default changelog generator.

Codecov Report

Merging #1302 (aaa3c4f) into main (cfec9bd) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1302   +/-   ##
=======================================
  Coverage   81.94%   81.94%
=======================================
  Files         398      398
  Lines       14414    14414
=======================================
  Hits        11812    11812
  Misses       2309     2309
  Partials      293      293

authors: codecov-commenter sundowndev

repo: snyk/driftctl


text:
Allow scope to be changed

At the moment the controllers reference current_user and authenticate_user! but our application uses a model called Member instead of User.
The Devise registration controller has a small helper that handles this nicely

+1

authors: BRMatt barbolo

license: mit


text:
What are we intending with the use of the readonly attribute?

According to http://www.w3.org/TR/html-markup/input.radio.html the readonly attribute is not valid on input type=radio.  Even if it was valid, readonly represents a control whose value is not meant to be edited.  (http://www.w3.org/TR/html-markup/input.text.html#input.text.attrs.readonly)

The above link to w3.org states "attribute boolean readOnly;" note the capital 'O'.  It is a valid property.

authors: SpikedKira notmessenger

repo: softlayer/sl-ember-components


text:
prepare_deploy_contract cheatcode

Proposal:
func ():
%{
  dep = Contract("./contract.cairo",  [1,2,3])
  start_prank(123, target=dep.contract_address)
  dep.deploy()
%}
end

Would work also for mock_call and any targeted cheatcode.
We could in the future deprecate deploy_contract, and instead use:
%{
  dep = Contract("./contract.cairo",  [1,2,3]).deploy()
%}

Interface
class Contract:
__init__(path, calldata): ...

def deploy(self) -> Contract: ...

%{
  c = Contract('./contract.cairo')
  start_prank(123, target=c)
  c.deploy([1,2,3])
}

Looks better 😄

We can create a mapping tmp_address -> actual_address, which could be updated by Contract::deploy just before deploying a contract.

If we provide the constructor data at the very beginning we need to detect if the contracts are deployed in the expected order. I still believe we should use the tmp_address -> actual_address mapping.
%{
  c1 = Contract("./contract.cairo",  [1,2,3])
  c2 = Contract("./contract.cairo",  [1,2,3])
  start_prank(123, target=c1.contract_address)
  c2.deploy()
  c1.deploy()
%}

@kasperski95 Why?

NVM, I thought generation of contract address depends on the Starknet's state.

#379

repo: software-mansion/protostar


text:
Bump crypto-cpp-py

Feature Request
.

Can't be solved until starknet-devnet updates crypto-cpp-py

Lets open a PR in devnet alongside with resolving this issue.

https://github.com/Shard-Labs/starknet-devnet/pull/403

authors: cptartur war-in


text:
uri"".scheme().port() renders wrong uri

val uri = uri"192.168.1.1".scheme("http").port(8888)
println(uri)

http://:8888192.168.1.1

In contrast,
val uri = uri"http://192.168.1.1".port(8888)
println(uri)

http://192.168.1.1:8888

Hm :) Is 192.168.1.1 a valid URI? (according to the spec?)
But why it ends up as a port is puzzling :)

Fair point. https://datatracker.ietf.org/doc/html/rfc3986#section-1.1.1
Shall I close the issue?

As for now, parsing relative URIs  works fine. 192.168.1.1 is parsed as a relative URI and ends up as a path segment. Adding schema by scheme("http") is effectively changing relative URI to absolute URI - what is not currently supported in sttp. Yet after the change remains 192.168.1.1 a path segment not part of the port in the URI object .

authors: Pask423 adamw kamilkloch

repo: softwaremill/sttp


text:
Explore possibility to use VILLASctrl for container management

VILLASctrl can already manage kubernetes resources: https://git.rwth-aachen.de/acs/public/villas/controller
We should try to understand what parts of VILLASctrl can be reused.

We decided to manage dpsim-workers using kubernetes features.

repo: sogno-platform/dpsim-api


text:
这行代码是否有并发问题

https://github.com/sogou/workflow/blob/d694479b15fa33b3d6d14ed3a0a6234d300f6b5a/src/kernel/thrdpool.c#L74
这行代码是pthread_mutex_unlock(&pool->mutex)之后执行，此时没有获取到互斥锁，那这个if (pool->nthreads == 0)读操作，是存在并发问题的吧？

你好。这个判断在锁外，但是并不会存在并发的问题。这里有两种情况：
1、72行task_routine里调用了thrdpool_destroy，那么，destroy函数里会等待所有其它线程退出。此时，除了本线程，已经没有任何线程可能访问pool对像，且nthreads==0判断成立，释放pool并返回。
2、task_routine里没有调用thrdpool_destroy，那么，可能有线程池正在退出那么其它线程可能正在操作pool->nthreads。但就算有线程在写nthreads（nthreads可能正在自减），对nthread==0的判断都不会成立，无论在任何硬件体系结构下都不会成立。本线程正常进入下一次循环。
所以，这里并没有并发相关的风险。感谢看得这么仔细。

好的，感谢答疑

authors: Barenboim WangShuaiNWPU

repo: sogou/workflow


text:
Inspect Element

I keep going back and forth between the chrome debugger and start debugging to inspect elements in chrome. Opening the chrome debugger kicks me out of webinspector, but I can't inspect an element in the web inspector.
It would really be awesome if I could just control inspecting an element from the webinspector.

Working on it.

I'm now on other projects, but this is worth doing and I'd accept PR's. I'm pretty sure some of the work may be already done in the dom_explorer branch.

authors: danmosemsft jackphel

repo: sokolovstas/SublimeWebInspector


text:
Multi-account withdraw added the stake-pool CLI

Now if there is not enough funds on the single stake account CLI will withdraw from several and then join them into one single account.

This looks great -- thanks so much!  Once it passes CI I'll merge it in :-)

authors: joncinque ysavchenko

repo: solana-labs/solana-program-library


text:
Update png #12221

I'm submitting a ...
[ ] bug report
[x] feature request
[ ] question about the decisions made in the repository
[ ] question about how to use this project

Summary

Other information (e.g. detailed explanation, stack traces, related issues, suggestions how to fix, links for us to have context, eg. StackOverflow, personal fork, etc.)

#12221

@keone :)

merged. please don't tag maintainers

authors: keone neutralskew

repo: solana-labs/token-list


text:
Token-List PLAGUE Token Not Auto-Merging Any Help?

I'm submitting a an issue with auto-merging to token-list
[ ] bug report
[ ] feature request
[ ] question about the decisions made in the repository
[X] question about how to use this project

Hey everyone, I'm slowly learning on this side of things... but long story short I created my SPL token and followed the steps to get here with auto-merging in order to put the name and logo on mainnet. When I open the solana.tokenlist.json to edit it everything works accordingly... I do not delete unwanted code, or changed already existing code... I am adding my changes as new and that is it. I then save the solana.tokenlist.json and this creates a solana.tokenlist.json.bak. This is the file that is somehow causing me issues but its the specific issue that I cannot figure out. Here is my pull request below. Thank you for any insight in advance, its greatly appreciated.

Other information

mismatching { and }, see https://github.com/solana-labs/token-list/pull/18314/files


text:
Request for Manual merge

I'm submitting a ...
[ .] request for the deletion of my token #20524

I want to delete my token and recreate it due to some issues with the token.

https://github.com/solana-labs/token-list/pull/20524

this doesn't delete TERP: see https://github.com/solana-labs/token-list/pull/20524/files to observe the impact
why?  because your PR includes both the 'add' and the 'delete' commit: https://github.com/solana-labs/token-list/pull/20524/commits
it needs to only contain the 'delete'

My fork is behind and when I try to find the old token its not there, is there a way to fork it again with all the new PR and stuff?
Im trying to modify and delete the old token but its not in my forked repository

as i mentioned in your other ticket, look at https://github.com/solana-labs/token-list#duplicate-token.  it contains instructions on how to rebase your fork back onto the latest version of main, which is exactly the problem you are describing

forget it, i fixed it for you in #20546


text:
Are spec dependencies assumed to be pinned?

Version 0.9.0 of https://solidproject.org/TR/protocol was last modified on 17 December, but if you follow the link from there to the Solid OIDC spec, that is an unversioned link to https://solid.github.io/solid-oidc/
That document claims to have been created on 28 April which is odd in itself because on 13 December https://github.com/solid/solid-oidc/tree/a5a966c7342da01a57bfb316e5533ea7d82fd245 already pointed to it. In any case, it seems likely that at the time of publishing, version 0.9.0 of the spec pointed to this version of Solid OIDC, which in turn points to version 4 of the DPoP id.
Readers who read version 0.9.0 of the Solid spec nowadays, and follow their nose, end up at https://solid.github.io/solid-oidc/#normative which points to DPoP without choosing any particular version.
In software development it's common practice to pin dependencies when publishing. This prevents things from breaking at random unexpected times, and allows the publisher to update dependencies in a controlled way. Should we do the same in spec development?

I believe the dates of the Solid-OIDC ED: https://solid.github.io/solid-oidc/ , should be as suggested as in https://github.com/solid/solid-oidc/issues/105#issuecomment-1103283231, in particular:

ED/oidc

Created: 2021-07-16 (whenever it came to existence)
Published: 2021-07-16 (usually same as created...)
Modified: 2022-04-30 (update as you go)

Note that above I used the date from gh-page's first commit - assuming everything else was configured for https://solid.github.io/solid-oidc/

Since FPWD was released to https://solidproject.org/TR/oidc no releases should point anymore to the ED.
@michielbdejong any version release of Solid-OIDC will be now processed with this github workflow https://github.com/solid/solid-oidc/blob/main/.github/workflows/tr-draft-config.yml
There result will go as PR to https://github.com/solid/specification

Since FPWD was released to https://solidproject.org/TR/oidc no releases should point anymore to the ED.

That is at the discretion of the authors making the citation.
TR/protocol as of this writing refers to Solid-OIDC ED, and ED/protocol (will eventually make it into the next update of TR/protocol) refers to TR/oidc. The Solid-OIDC ED dates should be corrected irrespective to any of that.

Just as in software development, when referencing a "snapshot dependency" (in this case, that would be an editor's draft), you need to be aware that this dependency may change at any time.
It is true that Solid Protocol 0.9 points to the editor's draft of Solid OIDC, which means that the dependency is not fixed.
You will also note that the published Solid-OIDC 0.1 document depends on the draft DPoP specification (which also continues to change)
Obviously, it is better for a published specification to always depend on other non-draft published specifications, but that is not always possible. (WebID has been in draft since 2005). In this case, if the dependency is a draft, there is an implicit acknowledgement that the dependency is not fixed

In software development it's common practice to pin dependencies when publishing. This prevents things from breaking at random unexpected times, and allows the publisher to update dependencies in a controlled way. Should we do the same in spec development?

@michielbdejong described workflow, starting from Solid-OIDC 0.1, satisfy your suggestion?

The Solid-OIDC ED dates should be corrected irrespective of any of that.

@csarven could you please submit a PR that corrects the dates?
Otherwise at least please explain here which exact dates you would like to be changed, including expected values.

Update created and add published. See the suggested values as mentioned in https://github.com/solid/solid-oidc/issues/197#issuecomment-1263461771.

if the dependency is a draft, there is an implicit acknowledgement that the dependency is not fixed

That answers my question, thanks!

authors: acoburn csarven elf-pavlik michielbdejong

repo: solid/solid-oidc


text:
Move Solid Apps

[ ]  Agree that the target location is the Forum (tentatively discussed need official confirmation) – Action item done by: by May 7, 2021

[ ]  What notice needs to be given – Decided no later than the end of Solid Team Meeting May 12, 2021

[ ]  Notice to the community

[ ] Get approval from the Solid Team

[ ] Actually write and post a note to the community – Determined during the Solid Team Meeting

[ ] Do the transfer of the applications

If this refers to applications that were once in the github.com/solid organization, then this task is complete. Closing for now.

authors: MarrelleBailey jaxoncreed

repo: solid/team


text:
Set field with default value in ADO without source field

Hello! I have a field "Enviroment" for my bug work items in my ADO. I do not have a corresponding field for my Jira work items. I wonder if it is possible to set a default value for that field when importing items, without having a source field from Jira?

Should be doable by creating a Work Item Rule in Azure DevOps. Otherwise simply bulk edit the work items in ADO WIT Queries and set the value of the items there.
Here is how I have mapped the Environments field previously:
      {
        "source": "environment",
        "source-type": "name",
        "target": "Microsoft.VSTS.TCM.SystemInfo",
        "for": "Bug,Epic"
      }

Hi, thanks for the reply! That sounds like a good idea. But I will also post the work-around I did, in case it can help anyone in the future: I used the jira api to find a common field which was static for all work items I wanted to target.  In my case I used "issueType" as source.
My field-map entry then looked like this:
{
	"source": "issueType",
	"source-type": "name",
        "target": "Custom.Environment",
	"for": "Bug",
	"mapping": {
         "values": [
           {
           "source": "Bug",
           "target": "Production"
           }
           ]
        }
},

This worked in my case without any issues.

repo: solidify/jira-azuredevops-migrator


text:
fix entry-client url on Windows

Since on windows the URL was starting with C:\ the browser was treating it as a local file request.
This PR simply adds /@fs/ in front of the absolute file path.
This will create URLs like the following:
Windows
/@fs/C:\...\examples\bare\src\entry-client.tsx
Linux
/@fs//home/.../examples/bare/src/entry-client.tsx
The vite dev server seems to handle the extra slash in the Linux URL just fine and the browser seems to take care of converting the backslashes to slashes.
I tested this on Windows and WSL Ubuntu, with an entry-client and without.

Ahh thanks for this! I wonder why the cloudflare workers are failing.. they have this required login error from wrangler.. but cloudflare pages is fine.. maybe do a push to rerun the tests?

There seems to be something specific about this change causing this.. can you for a commit revert the change and push to trigger tests with the old stuff.. just to confirm this

Looks like its still failing.. I wonder if it has to do with permissions and you not getting access to the cloudflare tokens.. hmm.. let me check

authors: ghalle nksaraf

repo: solidjs/solid-start


text:
Importing solid-js/web (as ESM, from Node.js) throws a SyntaxError

Describe the bug
When I import solid-js/html as an ES module from Node.js, I get the following error:
SyntaxError: The requested module 'solid-js/web' does not provide an export named 'Aliases'

Your Example Website or App
n/a
Steps to Reproduce the Bug or Issue
For example, in the Node.js REPL:
>> node
Welcome to Node.js v21.1.0.
Type ".help" for more information.
> await import('solid-js/html')
file:///home/vinsonchuong/projects/test-tube/node_modules/solid-js/html/dist/html.js:15
  Aliases,
  ^^^^^^^
Uncaught:
SyntaxError: The requested module 'solid-js/web' does not provide an export named 'Aliases'

Expected behavior
I expect the import to succeed and not throw an error.
Screenshots or Videos
No response
Platform

OS: Linux
Browser: Running in Node.js v21.1.0
Version: 1.8.7

Additional context
I'm looking to write some custom tooling for writing automated tests from Node.js and was surprised to see this error.
After some searching, I found this issue: https://github.com/solidjs/solid/issues/1483, which clued me into the fact that there are separate builds for the browser and for Node.js.
It looks like because the html tag function returns a DOM Node, solid-js/html is a browser-only package. I am, however, able to proceed if I configure Node.js to prefer browser packages:
>> node --conditions browser
Welcome to Node.js v21.4.0.
Type ".help" for more information.
> await import('solid-js/html')
[Module: null prototype] { default: [Function: html] }

Because solid-js/html imports solid-js/web, there's no way to specify that the browser packages should be used without passing in arguments to Node.js. To make this easier, could solid-js/html directly import the browser build of solid-js/web instead? There are probably trade-offs to doing that, but I'm hoping to have easy ways to run Solid from a Node.js + JSDOM environment.

So far we've pushed people to use "browser" export conditions for this. Like in solid-jest when doing testing we use the browser condition. We could make it use the browser version. Although there are 2 versions of Solid as well, and it is less clear what version you want. Like testing I want the browser reactive version, but for doing some sort of SSR you probably want the inert server version. To be fair right now because they all connect to the same condition it isn't that configurable.
Not sure. What I'm getting at it is this probably won't work correctly for everyone unless we treat it as browser across the board which can only be done through conditions as web internally doesn't wire to browser version of solid etc... It is interesting problem.

Makes sense. It's pretty tough to hit every usecase gracefully.
When reading this section in solid-jest, I noticed that a user can choose the right preset to get what I assume to be the build of Solid that they want.
One of the reasons I'm using solid-js/html is, for simple projects, I tend towards not having a compiler.
So, I'm wondering if a similar concept can be applied here. Perhaps by importing something like solid-js/html/browser or solid-js/web/browser, we can get the hardcoded browser builds. I see that solid-js/web ends up importing solid-js. So, if solid-js/web/browser ended up importing solid-js/browser, that might be a graceful way to hit this usecase.
What do you think?

I am hitting this issue in Vite/Vitest and am still looking for a workaround. Setting resolve.conditions is too intrusive in my use case and causes other side effects.
So a direct kind of import would also be very helpful to me!

I am hitting this issue in Vite/Vitest and am still looking for a workaround. Setting resolve.conditions is too intrusive in my use case and causes other side effects. So a direct kind of import would also be very helpful to me!

I think you are going have to depend aliasing then because this is a multi-package concern. While any package could just import from the right source (we expose dist) our core libraries which reference each other would not. Export conditions make sense here or bundler aliasing makes sense here but hard-coding the libraries doesn't particularly.
It doesn't really extend out well into the ecosystem either. We tend to ship as source to give maximum compilation flexibility to the end user so like intermediate libraries aren't going to do the combinatorics as well.
I think we should look at export conditions here a bit more and see if we can be more helpful in some way. Like we have a "server" export condition when people need that build regardless of node etc.. Maybe there is a way to get client that doesn't have other implications. That being said this hasn't been a problem for a lot of projects because the solid parts could be built with that setting and then the setting could be absent from the runtime when running.

I can't import Solid's html in a Solid Start app if SSR is enabled:
import html from `solid-js/html`

Causes:
7:15:10 PM [vite] Error when evaluating SSR module /src/elements/Scroller.ts: failed to import "solid-js/html"
|- file:///Users/trusktr/src/showcase/node_modules/solid-js/html/dist/html.js:1
import { effect, style, insert, untrack, spread, createComponent, delegateEvents, classList, mergeProps, dynamicProperty, setAttribute, setAttributeNS, addEventListener, Aliases, getPropAlias, Properties, ChildProperties, DelegatedEvents, SVGElements, SVGNamespace } from 'solid-js/web';
                                                                                ^^^^^^^
SyntaxError: The requested module 'solid-js/web' does not provide an export named 'Aliases'
    at ModuleJob._instantiate (node:internal/modules/esm/module_job:131:21)
    at async ModuleJob.run (node:internal/modules/esm/module_job:213:5)
    at async ModuleLoader.import (node:internal/modules/esm/loader:308:24)
    at async nodeImport (file:///Users/trusktr/src/showcase/node_modules/vite/dist/node/chunks/dep-BzOvws4Y.js:52954:15)
    at async ssrImport (file:///Users/trusktr/src/showcase/node_modules/vite/dist/node/chunks/dep-BzOvws4Y.js:52812:16)
    at async eval (/Users/trusktr/src/showcase/src/elements/Scroller.ts:4:31)
    at async instantiateModule (file:///Users/trusktr/src/showcase/node_modules/vite/dist/node/chunks/dep-BzOvws4Y.js:52870:5)

Solid's html code causes the problem here:
https://github.com/solidjs/solid/blob/main/packages/solid/html/src/index.ts#L17
The solution is Solid should export Aliases regardless. And if it should not be used on the server side, then a runtime error can be thrown instead (people can easily guard that with a conditional like if (globalThis.window) useAliases().

Code in dom-expressions can be made to workaround Aliases missing at runtime, if needed. For example this code here,
https://github.com/ryansolid/dom-expressions/blob/b0016751ad0149e61c93337ce10c135f3f8efe90/packages/lit-dom-expressions/src/index.ts#L203
already does this
r.Aliases[name] || name

and let's say that Aliases were to at least be exported as undefined (I'm not suggesting that's the best solution, but for example)) then that code can be updated to
r.Aliases?.[name] || name

and this creepy crawly can be squashed. 🐛🥾
Similarly any other code that might be relying on Aliases can be updated.

Working towards fixing this here:

https://github.com/ryansolid/dom-expressions/pull/345

Not only does https://github.com/ryansolid/dom-expressions/pull/345 fix this error for Solid Start, but it fixes the error for all SSR frameworks.
For example, I've had this error turning up for me and other people where were trying to use Lume in Svelte Kit, Next, etc.

Aha! Well I've verified in tested that this is fixed in the PR ^, as far as import solid-js/html goes. But now that that's out of the way, I've discovered more similar issues in separate packages that I'll also fix:
SyntaxError: The requested module 'solid-js/store' does not provide an export named 'modifyMutable'

I'm getting this error when SSR is enabled, but not when SSR is disabled. The odd thing is I do not see where the client code is including modifyMutable, it is nowhere in the store/src/store.ts file.

I've updated https://github.com/solidjs/solid/pull/2269 and can confirm that the updated build of solid-js prevents any SSR errors due to imports (my app code then runs logic on the client conditionally if needed), and confirm that SSR is working (HTML payload comes from server). 🎉
I am still having a hydration error of some kind, but imports are working great.

Yeah merged into next. Will be in 1.9.

authors: dan-lee ryansolid trusktr vinsonchuong

repo: solidjs/solid


text:
🛑 admissions is down

In 1d0d42b, admissions (https://admissions.umich.edu) was down:

HTTP code: 0
Response time: 0 ms

Closing manually on account of not tracking admissions anymore.

repo: solve-it-once/upptime


text:
Navigation treeview is above the page content in the mobile view

Currently the treeview appears above the actual page content in a smaller screen. Is this an intended change ? @ststimac
It could be an issue in the rule pages since the expanded panel can stretch pretty long before a user can see the page content:

Ah, yes. I made an update after reviewing one of David Storey's accessibility concerns. This was appearing after the content which would make it hard for a user to navigate around.
For now I will switch it back to the way it was and open a new issue to explore a better solution on mobile.


text:
Add functional test and fix container usage

Subject
I was trying to add a functional test and in the way some issues came up.

I am targeting this branch, because this is BC.

Closes #471.
Changelog

### Deprecated
- Constructing `TokenStorageUsernameCallable` with an instance of `Container`, use an instance of `TokenStorageInterface` instead
### Fixed
- Fixed service id of `ViewEntityAction`
### Removed
- Support for `doctrine/orm` < 1.12.8

Thanks @franmomu

repo: sonata-project/EntityAuditBundle


text:
为每个模型预设前置role角色

如这样[
{
"role": "system",
"content": "\nYou are ChatGPT, a large language model trained by OpenAI.\nKnowledge cutoff: 2021-09\nCurrent model: gpt-3.5-turbo\nCurrent time: 2023/8/30 18:15:26\n"
},
{
"role": "user",
"content": "1"
}
]
可以自定义system角色的内容

这应该是客户端做的事情

authors: codesdevs songquanpeng

repo: songquanpeng/one-api


text:
Not able to use the .login() endpoint

When using the login endpoint code in the docs, I get 401 Unauthorized errors. I'm also noticing that the LoginDTO() object needs to be updated in the docs, it shows an empty LoginDTO object which causes validation errors. Here's the code I'm running:
import songtradr_api_client_python
from songtradr_api_client_python.models.jwt_token_dto import JwtTokenDTO
from songtradr_api_client_python.models.login_dto import LoginDTO
from songtradr_api_client_python.rest import ApiException
from pprint import pprint
from dotenv import load_dotenv
import os

load_dotenv()

# Defining the host is optional and defaults to https://api.songtradr.com
# See configuration.py for a list of all supported configuration parameters.
configuration = songtradr_api_client_python.Configuration(
    host = "https://api.songtradr.com"
)

# The client must configure the authentication and authorization parameters
# in accordance with the API server security policy.
# Examples for each auth method are provided below, use the example that
# satisfies your auth use case.

# Configure Bearer authorization (JWT): bearer-jwt

# QUESTION: How would I already have a bearer token if I'm using the login to get it?
configuration = songtradr_api_client_python.Configuration(
    access_token = os.environ["BEARER_TOKEN"]
)

# Enter a context with an instance of the API client
with songtradr_api_client_python.ApiClient(configuration) as api_client:
    # Create an instance of the API class
    api_instance = songtradr_api_client_python.UserApi(api_client)
    login_dto = songtradr_api_client_python.LoginDTO(
        # version='3.0.0',
        password=os.environ.get('SONGTRADR_PASSWORD'),
        email=os.environ.get('SONGTRADR_EMAIL')
    ) # LoginDTO |

    try:
        # Login to generate a bearer token.
        api_response = api_instance.login(login_dto)
        print("The response of UserApi->login:\n")
        pprint(api_response)
    except Exception as e:
        print("Exception when calling UserApi->login: %s\n" % e)

And the error message I receive:
Exception when calling UserApi->login: (401)
Reason:
HTTP response headers: HTTPHeaderDict({'Date': 'Sat, 31 Aug 2024 20:39:18 GMT', 'Content-Type': 'application/json', 'Transfer-Encoding': 'chunked', 'Connection': 'keep-alive', 'Vary': 'Origin, Access-Control-Request-Method, Access-Control-Request-Headers', 'X-Content-Type-Options': 'nosniff', 'X-XSS-Protection': '0', 'Cache-Control': 'no-cache, no-store, max-age=0, must-revalidate', 'Pragma': 'no-cache', 'Expires': '0', 'Strict-Transport-Security': 'max-age=31536000; includeSubDomains', 'X-Frame-Options': 'DENY'})
HTTP response body: timestamp=datetime.datetime(2024, 8, 31, 20, 39, 18, 979000, tzinfo=TzInfo(UTC)) status=401 error='Unauthorized' message='Unauthorized' path='/api/v1/user/login'

I've confirmed my email and password are correct. What's the issue here?

Oo I am running Python 3.12, so let me run this in 3.7 and see.


text:
tvOS support

Are you able to add tvOS support for reddift? I'm trying to implement Oauth in my reddit-based tvOS application to allow Login with Reddit, and then access the user's subreddits. I can't find any authentication options on tvOS for Reddit users.

I want to support tvOS.
But, tvOS does not support typical OAuth authentication scheme.
Anyone, do you have some ideas to overcome this issue?

probably a little late, but you could delegate to an iOS device
see: http://stephenradford.me/oauth-login-on-tvos/

authors: bpenda dnadri sonsongithub

repo: sonsongithub/reddift


text:
COM-2192 - update fonts

Mise en place de la nouvelle charte graphique
Il y avait un souci avec les polices sur dev sur l'ordinateur de Romain - sans doute sous windows du coup ...

j'ai importé la police qu'on veut utiliser du coup
j'ai modifié tous les h4 pour homogénéiser les titres

j'ai également corrigé des coquilles qui trainaient :

la couleurs des indicateurs eLearning
la couleur de fond des progressions de étapes
l'affichage du bouton arreter sur la fiche bénéficiaire
le nom de la classe pink-icon -> primary-icon

Ce commit partira dans la MEP de la semaine prochaine

Sur la page ToBill, le bouton Facturer` recouvre le numéro de page

Idem pour le bouton Créer les prélèvements sur la page ClientsBalances

normalement tu peux scroller non ?

repo: sophiemoustard/alenvi-webapp


text:
Add UI for Survival Mode in Singleplayer Mode

https://github.com/sopra-fs23-group-32/SoPra23_Client/commit/81552efb1f5d2240c97692590e877205ee5e6a09

https://github.com/sopra-fs23-group-32/SoPra23_Client/commit/c656a1cc4dd0726dc01e6e715ce487ce39ddcaa6


text:
Android - Buy fiat with crypto

As a SORA Card user I want to buy fiat currency with my crypto within the wallet so that I can trade in the Traditional Finance economy seamlessly.
Exchanges integration:

X1
Gatehub

Aha! Link: https://soramitsucoltd.aha.io/features/SORANEO-668

Gatehub to provide documentation by EoW (17/03)

repo: sora-xor/sora-card-android


text:
move third_party/parser underneath parser

third_party/parser is in a bit of a weird state: it's imported from the upstream project typedruby/typedruby.  But the upstream project is not under active development, and we've added enough stuff to third_party/parser that it's probably time to admit that we've a) permanently forked it and b) (eventually) take action based on that (e.g. eliminating some of the abstraction that the more general typedruby project needed, but isn't relevant to Sorbet's purposes).
This PR just moves the code around and does the minimum fixing up to build (including formatting).  typedruby_fork is maybe not the best name, but it is at least accurate (parser/parser seemed like asking for trouble).  I did not try to deal with moving all the relevant code into parser/ directly and untangling the resulting build issues; I think doing that is best left to a separate PR.
Motivation

Laying the foundation for better code in the future.
Test plan

See included automated tests.

seems good, maybe putting the files in parser/ or parser/parser/ is better than typedruby_fork?

I had some FUD about putting things in parser/parser because there was a //parser:parser Bazel target, but everything seems to have worked out OK.
I'll follow up with a PR or two to collapse everything into parser/.

repo: sorbet/sorbet


text:
Upgrade Bazel to 5.0.0

This is part of the work for compiling Sorbet on M1 macs
Upgrade Bazel to 5.0.0.
Motivation
The earlier version don't have some darwin_arm64 rules related to toolchains which prevents us from compiling to ARM64.
Test plan
Existing tests should cover it.

We have a policy of testing changes to Sorbet against Stripe's codebase before
merging them. I've kicked off a test run for the current PR.  When the build
finishes, I'll share with you whether or how it failed. Thanks!
Stripe employees can see the build results here:
→ https://go/builds/bui_L7cxyizeG57Vlq
→ https://go/builds/bui_L7cx66nSPWnhe9

This failed in Stripe's CI due to inherited bazelrc options. We'll need to fix that before we can land this.

Stripe build fix PR: https://go/ps/pull/418401

authors: elliottt vinistock


text:
[Chess] Speed up _legal_action_mask by caching piece positions

#704

3.801090955734253

repo: sotetsuk/pgx


text:
Attempt to call field 'hasFastHalfInstructions' (a nil value)

Using the newest version of cutorch & cudnn I keep getting following error when using cudnn:
th> require 'cudnn'
Found Environment variable CUDNN_PATH = /Users/d-32/Downloads/cuda/lib/libcudnn.6.dylib
/Users/d-32/torch-cl/install/share/lua/5.1/trepl/init.lua:384: /Users/d-32/torch-cl/install/share/lua/5.1/cudnn/init.lua:98: attempt to call field 'hasFastHalfInstructions' (a nil value)
stack traceback:
	[C]: in function 'error'
	/Users/d-32/torch-cl/install/share/lua/5.1/trepl/init.lua:384: in function 'require'
	[string "_RESULT={require 'cudnn'}"]:1: in main chunk
	[C]: in function 'xpcall'
	/Users/d-32/torch-cl/install/share/lua/5.1/trepl/init.lua:651: in function 'repl'
	...2/torch-cl/install/lib/luarocks/rocks/trepl/scm-1/bin/th:199: in main chunk
	[C]: at 0x010c2aea00

Any idea why this is happening? None of the solutions in related tickets helped me.

@D-32 looks like you should install the R6 version.
git clone https://github.com/soumith/cudnn.torch -b R6
cd cudnn.torch
luarocks make

@rjuge I did exactly that, gives me the same error though. I uninstalled the previous version, so I'm sure I installed the correct R6 version.

This error has to do with the cutorch version,not the cudnn.torch version.

@ngimel What cutorch version should I be using? The newest version not good?

The newest is good, but I'm not sure you have the newest one. Make sure when you require cutorch, cutorch.hasFastHalfInstructions is not nil. I'm closing it here, as it is not related to cudnn.torch,
th> require 'cutorch'
{
  createCudaUVATensor : function: 0x40846758
  getPeerToPeerAccess : function: 0x41f374f8
  getStream : function: 0x40df5f48
  isCachingAllocatorEnabled : function: 0x40df5e58
  getDeviceCount : function: 0x41f374a0
  isManaged : function: 0x408467b8
  setHeapTracking : function: 0x40611068
  manualSeedAll : function: 0x40610f78
  streamWaitFor : function: 0x40df5ff0
  toCudaUVATensor : function: 0x40846798
  toFloatUVATensor : function: 0x40846778
  setKernelPeerToPeerAccess : function: 0x40df5d98
  reserveBlasHandles : function: 0x40087ca0
  manualSeed : function: 0x40610f28
  hasHalfInstructions : function: 0x40610e08
  getBlasHandle : function: 0x41936190
  hasFastHalfInstructions : function: 0x40610e60
  setDefaultStream : function: 0x40df5fa0
  getMemoryUsage : function: 0x40610db0
  createCudaHostIntTensor : function: 0x40846568
  streamBarrier : function: 0x40df60a0
  createCudaHostLongTensor : function: 0x408465e8
  seedAll : function: 0x40610ed8
  createCudaHostHalfTensor : function: 0x408466b0
  driverVersion : 8000
  CudaUVAAllocator : torch.Allocator
  synchronize : function: 0x41936168
  createCudaHostByteTensor : function: 0x40846668
  reserveStreams : function: 0x40829440
  createCudaHostDoubleTensor : function: 0x408464f0
  getDevice : function: 0x41936088
  createCudaHostFloatTensor : function: 0x40846488
  withDevice : function: 0x408463b8
  seed : function: 0x40610eb0
  test : function: 0x40846350
  _stategc : userdata: 0x41408798
  getNumStreams : function: 0x40df5d20
  getRuntimeVersion : function: 0x40610d08
  deviceReset : function: 0x41f37450
  Event : {...}
  CudaHostAllocator : torch.Allocator
  isManagedPtr : function: 0x40611090
  getState : function: 0x40611040
  setRNGState : function: 0x40610ff0
  synchronizeAll : function: 0x40087c48
  initialSeed : function: 0x40610f00
  getDeviceProperties : function: 0x40df5eb0
  getRNGState : function: 0x40610fc8
  getNumBlasHandles : function: 0x408294b0
  _sleep : function: 0x40610fa0
  setStream : function: 0x40df5d70
  getKernelPeerToPeerAccess : function: 0x40df5df8
  createFloatUVATensor : function: 0x40846718
  createCudaHostTensor : function: 0x40846488
  getDriverVersion : function: 0x40610d60
  streamSynchronize : function: 0x41936060
  streamWaitForMultiDevice : function: 0x40df6050
  setDevice : function: 0x40610e88
  setPeerToPeerAccess : function: 0x41f37550
  hasHalf : true
  streamBarrierMultiDevice : function: 0x41936008
  setBlasHandle : function: 0x40087cc8
  _state : userdata: 0x013fdae0
}
                                                                      [0.4648s]
th> cutorch.hasFastHalfInstructions
function: 0x40610e60

Okay, will look further into that. Thanks!

authors: D-32 ngimel rjuge


text:
[JOSS-Review][Reproducibility] How to reproduce the results?

How to verify the claims made in the paper? Could you please provide more details? For example: this QuantumSE.jl artifact describes how to reproduce results in detail. It includes information regarding the docker image and the commmands to run inside the docker container and expected output(s).
Additional Context
As part of https://github.com/openjournals/joss-reviews/issues/7489

Hi @Manvi-Agrawal, please find the details to reproduce the results under the 'Experiments and Results' section in the full_paper.md(link). To briefly describe the approach, we collected actual README files from open-source GitHub repositories and compared them against the README files auto-generated using the readme_ready tool. We generated the README by using the same headings as the actual README and calculated the BLEU and BERT scores between them after some minor post-processing to fix the output formatting. The scoring functions can be found under the Scoring section in the scripts/data.ipnb (link). The scoring is done for both non-finetuned and fine-tuned LLAMA models. The finetuned mode can be generated using scripts/fine-tuning-with-llama-2-qlora.ipynb notebook.


text:
Remove rank from contest voting

Remove the concept of rank from contest voting. The scoring for voting is now 1(worst) to 10 (best).
Should be tested with the frontend PR.

Coverage decreased (-0.001%) to 97.671% when pulling ca763c9d76efb5f34a3e81367e281a187c749e13 on elizabeth/contest-remove-rank into c7478b52d4474840ec5330d6407e342cd4ca6a2a on master.

percentage dropped due to removed parts, no new uncovered lines.

authors: YaleChen299 coveralls lizchow

repo: source-academy/backend


text:
Guided programming paths support

Guided programming paths support
Summary: Add experimental support for guided programming paths - question blocking and hidden testcases. Addresses #682 in full.
Related PRs
Please review this PR in conjunction with this PR on cadet: https://github.com/source-academy/cadet/pull/466. Both PRs should be approved together. This PR is complete, apart from additional tests that may be introduced in a later PR.
Rationale
The following is a summary of a discussion on the state of Paths with @martin-henz, @blackening and @geshuming.
Presently, most Paths contain primarily MCQ questions (that can be easily brute-forced) and few programming questions. As a result, Paths lack instructive and reinforcement value as there is no feedback loop for student learning.
To retain the non-manual graded nature of Paths yet improve student learning, it was decided that Paths will be redesigned with primarily programming questions. The Autograder will be employed here to guide students in the Path, by

allowing Path authors to throw custom error messages for each testcase as hints (i.e. using error(<message>) to hint a student to check the base case), by invoking a sentinel function in the question's postpend to perform custom assertions
allowing students to check the correctness of their solution using a set of public and hidden testcases
discouraging hard-coding of answers by hiding some of the testcase data

Changelog

Amend Autograder run-all to prematurely terminate if one of the testcases results in an error
Add attribute type to ITestcase interface to enable Autograder to apply different rendering for testcases of type public, hidden and private
Shard a new "privileged" interpreter context elevated to use Source §4 for execution of prepend, postpend and testcase chunks, but not for programs in the editor

Ensures grader programs in prepend and postpend run without raising interpreter errors, but prevents students from using the elevated chapter to run illegal code from the editor or REPL
Additionally, prevents students from accessing contents of postpend

Hidden testcases: private testcases of a Path in its assessment XML are treated as hidden testcases by the Autograder

A placeholder cell will be rendered in place of the three cells 'Testcase', 'Expected result' and 'Actual result'
Students may still run the testcase; its status may be determined by observing the background colour of the card - green if correct, red if incorrect, dark blue if no answer was returned
To prevent hard-coding of the expected output, the interpreter output will be suppressed for hidden testcases - this includes any calls made to display(...)

This is achieved by adding a new action CLEAR_REPL_OUTPUT_LAST that removes the last entry from the REPL, which is invoked only for hidden testcases
The alternative is to extend EVAL_INTERPRETER_SUCCESS and EVAL_INTERPRETER_FAILURE with an optional parameter to discard the pending output to REPL - this is required due to how display(...) calls are handled through HANDLE_CONSOLE_LOG

Question blocking: modify the behaviour of the <NextButton> in assessmentWorkspace to use onClickProgress in place of onClickNext when the current assessment is a Path

onClickProgress computes the number of questions attempted by the student thus far in the Path as blockedQuestionId
If the current questionId equals blockedQuestionId, onClickNext will only let the student proceed to the next question iff the answer to the current question is correct

For MCQ questions, this is when the student's MCQ choice is equal to the solution
For programming questions, this is when the student has passed all of its testcases (public and hidden)

Bugfixes

Fix excessive margins in MCQ hint notifications in assessments
Fix excessive margins of header HTML elements in assessment briefing overlay

Mocks and Tests

Add a new mock programming Path 'Basic logic gates' to demonstrate the behaviour introduced from this PR
Update existing snapshots and add new rendering and logic tests for hidden testcases, premature run-all termination and hidden testcase output suppression

Screenshots
As most of the changes relate to UX, I recommend trying out the mock programming path instead.
Before/After (MCQ hint notifications fix)

Before/After (assessment briefing overlay fix)

Feature demonstration (guided programming path - hidden testcases and question blocking)

Last updated 16 Aug 2019, 10:00AM

Pull Request Test Coverage Report for Build 2868

31 of 45 (68.89%)  changed or added relevant lines in 10 files are covered.
4 unchanged lines in 1 file lost coverage.
Overall coverage increased (+0.1%) to 36.902%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/components/workspace/MCQChooser.tsx
0
1
0.0%

src/components/assessment/AssessmentWorkspace.tsx
3
16
18.75%

Files with Coverage Reduction
New Missed Lines
%

src/sagas/workspaces.ts
4
96.15%

Totals

Change from base Build 2867:
0.1%

Covered Lines:
2603

Relevant Lines:
6322

💛  - Coveralls

This PR requires the following fix to the interpreter: https://github.com/source-academy/js-slang/pull/332. Merging this in for production without the fix applied may lead to failures during client-side autograding for Paths!

authors: Aulud coveralls

repo: source-academy/cadet-frontend


text:
Add env vars for overriding GitHub / GitLab hostnames in the .netrc file.

Adds override env vars GITLAB_HOSTNAME and GITHUB_HOSTNAME to support authenticating against self-hosted GitLab / GitHub instances.
Fixes #20

@brendan-kellam Thank you for fix, however why do you use the env vars to build the .netrc file, instead of the settings from the config file? I'm asking because i'm trying to index repos from multiple self-hosted gitlab servers (so I have more than gitlab one hostname and token). It seems limited to just 1 if we rely on env var, while the config file is more flexible since you can have any number of entries in the Configs array, right?

Hey @loris - yea that's correct. Using env vars was a quick fix for the single self-hosted server scenario.
We are working on overhauling the config format atm and plan to support multiple host authentication (via the config). We expect to have that in sometime next week. See: #27

authors: brendan-kellam loris

repo: sourcebot-dev/sourcebot


text:
Add --test-tool=nextest

Fixes #85

[x] Update manual
[x] Exercise from cargo-mutants' own CI
[x] Integration test
[ ] Build with cargo test --no-run and nextest run --no-run
[ ] Look at nextest exit codes and report if the test one is not "tests failed"

Performance on cargo-mutants
I tested this on cargo-mutants itself locally and in CI, and it works well. However, interestingly, it does currently seem to be significantly slower in sharded full-tree tests than is cargo test (about 8m vs >13m). (Example CI run.)
It's also somewhat slower, although not as much, locally:
; c r --release mutants --shard 1/10 --test-tool=nextest
   Compiling cargo-mutants v23.12.2 (/home/mbp/src/mutants)
    Finished release [optimized] target(s) in 4.49s
     Running `target/release/cargo-mutants mutants --shard 1/10 --test-tool=nextest`
Found 56 mutants to test
ok       Unmutated baseline in 13.9s build + 22.3s test
Auto-set test timeout to 1m 51s
56 mutants tested in 4m 22s: 40 caught, 16 unviable

; c r --release mutants --shard 1/10
    Finished release [optimized] target(s) in 0.08s
     Running `target/release/cargo-mutants mutants --shard 1/10`
Found 56 mutants to test
ok       Unmutated baseline in 13.8s build + 21.7s test
Auto-set test timeout to 1m 48s
56 mutants tested in 3m 46s: 40 caught, 16 unviable

Although it's probably better at stopping early, it may be paying a higher per-test overhead or maybe making less use of parallelism?
Performance on stackslib
I also tested this on a 1% sample of stackslib with
; c r --release mutants --shard 1/100 -d ~/src/stacks-core/ --test-tool nextest
    Finished release [optimized] target(s) in 0.18s
     Running `target/release/cargo-mutants mutants --shard 1/100 -d /home/mbp/src/stacks-core/ --test-tool nextest`
Found 112 mutants to test
ok       Unmutated baseline in 116.1s build + 244.5s test
Auto-set test timeout to 20m 22s
MISSED   src/burnchains/bitcoin/spv.rs:1150:55: replace > with == in SpvClient::get_target in 34.1s build + 256.1s test
MISSED   src/chainstate/burn/db/sortdb.rs:2893:25: replace == with != in SortitionDB::is_db_version_supported_in_epoch in 25.8s build + 283.8s test
3358.435171577s  INFO timeout after 1222.4s, terminating child process...
TIMEOUT  src/net/connection.rs:1334:9: replace NetworkConnection<P>::send_data -> Result<usize, net_error> with Ok(1) in 34.8s build + 1222.4s test
MISSED   src/chainstate/coordinator/comm.rs:105:9: replace SignalBools::receive_signal -> u8 with 0 in 38.0s build + 278.8s test
MISSED   src/main.rs:957:16: replace == with != in main in 24.3s build + 258.5s test
MISSED   src/net/p2p.rs:4235:9: replace PeerNetwork::need_block_or_microblock_stream -> Result<bool, net_error> with Ok(true) in 28.7s build + 267.8s test
MISSED   src/net/p2p.rs:1280:9: replace PeerNetwork::num_peers -> usize with 1 in 26.8s build + 311.8s test
test     src/clarity_vm/database/mod.rs:174:9: replace <impl HeadersDB for ChainstateTx<'a>>::get_burnchain_tokens_spent_for_block -> Option<u128> with Some(1) ... 233.0s
MISSED   src/net/http.rs:1730:9: replace HttpRequestType::get_proof_query -> bool with true in 33.5s build + 291.0s test
MISSED   src/util_lib/db.rs:656:20: replace > with == in tx_busy_handler in 35.5s build + 290.3s test
test     src/chainstate/stacks/db/unconfirmed.rs:443:9: replace UnconfirmedState::num_mined_txs -> usize with 0 s
└                PASS [  28.317s]                     blockstack-core clarity_vm::tests::costs::epoch_21_test_alt
47/112 mutants tested, 8 MISSED, 1 timeout, 24 caught, 14 unviable, 1h 49m 40s elapsed, about 2h 32m remaining

It looks like some of those tests are still pretty slow, but it is making progress.

Performance on stackslib
I also tested this on a 1% sample of stackslib with
; c r --release mutants --shard 1/100 -d ~/src/stacks-core/ --test-tool nextest

Hey @sourcefrog , thanks for updating cargo mutants with nextest!
In the above example, the mutants that you specified are run from the whole stacks-core workspace, not specifically from stackslib.
I've tested it on stackslib with mutants that are caught and the difference is truly significant ( excepting unmutated build and test, from 1 hour and 10 minutes to 6 minutes).
cargo test
; command containing the regex of the 4 mutants tested
; test-threads=1 and bitcoind_test=1 are required for stackslib in order to work properly with bitcoin
; BITCOIND_TEST=1 RUST_BACKTRACE=full cargo mutants -F "(stackslib/src/chainstate/nakamoto/mod.rs:2595:9: replace NakamotoChainState::set_aggregate_public_key with \(\))|(stackslib/src/chainstate/nakamoto/mod.rs:3059:9: replace NakamotoChainState::aggregate_public_key_bootcode with \(\))|(stackslib/src/net/relay.rs:661:9: replace Relayer::process_new_nakamoto_block -> Result<bool, chainstate_error> with Ok\(true\))|(stackslib/src/net/relay.rs:661:9: replace Relayer::process_new_nakamoto_block -> Result<bool, chainstate_error> with Ok\(false\))" -- --all-targets -- --test-threads 1

Found 4 mutants to test
ok       Unmutated baseline in 131.2s build + 1052.1s test
Auto-set test timeout to 1h 27m 40s
4 mutants tested in 1h 31m 41s: 4 caught

cargo nextest
; BITCOIND_TEST=1 RUST_BACKTRACE=full cargo mutants -F "(stackslib/src/chainstate/nakamoto/mod.rs:2595:9: replace NakamotoChainState::set_aggregate_public_key with \(\))|(stackslib/src/chainstate/nakamoto/mod.rs:3059:9: replace NakamotoChainState::aggregate_public_key_bootcode with \(\))|(stackslib/src/net/relay.rs:661:9: replace Relayer::process_new_nakamoto_block -> Result<bool, chainstate_error> with Ok\(true\))|(stackslib/src/net/relay.rs:661:9: replace Relayer::process_new_nakamoto_block -> Result<bool, chainstate_error> with Ok\(false\))" --test-tool=nextest -- --fail-fast --test-threads 1

Found 4 mutants to test
ok       Unmutated baseline in 130.8s build + 1054.7s test
Auto-set test timeout to 1h 27m 53s
4 mutants tested in 25m 22s: 4 caught

The baseline tests ran in ~20 minutes, meaning it took less than 6 minutes to run the mutants with nextest's fail-fast flag enabled, compared to cargo test's 1h 10m.
Documentation related as well, the -- --test-threads arg from cargo test does not apply to cargo nextest, which doesn't require the additional --, leaving it just as --test-threads.

Wow that's incredible @ASuciuX!

That's outstanding, thanks for letting us know!
I will do the couple of small items in the head of the PR including checking the docs about passing options to cargo test/nextest, and then push a release.
I don't think you need to set --fail-fast explicitly for nextest as that's the default.
Regarding test-threads, from previous conversations I think you are setting this because you have some non-hermetic tests that cannot be run in parallel. nextest actually has some nice specific features for this which once set up properly might give you more precise control.

You are right @sourcefrog , I've tried without --fail-fast and I had the same results.
Interesting features, thank you for sharing, I will take a look into those.

authors: ASuciuX sourcefrog sunshowers

repo: sourcefrog/cargo-mutants


text:
70-upgrade-upstream-module-versions

Description
Upgrade upstream module versions and supported configuration.\
Related Issue

#70

Checklist
Please ensure that the following steps are completed before submitting the pull request:

[x] Code follows the Terraform best practices and style guidelines.
[x] Changes are appropriately documented, including any necessary updates to README or other documentation files.

Type of change
Please delete options that are not relevant.

[x] New feature (non-breaking change which adds functionality)
[x] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Versioning
#minor

@mayank0202 , can you please make sure I commented on the PR correctly to increment the minor version?

@mayank0202 , can you please make sure I commented on the PR correctly to increment the minor version?

You have to write minor while doing a git commit and it works first time only🥲

repo: sourcefuse/terraform-aws-arc-db


text:
Wrap "Already upgraded..." text in the subscription tab

We have no issue for this one but the text exceeding the line width is not visible - these changes fix that.
Test plan

play with Cody tool window width
verify that the text is wrapped

Before
After

repo: sourcegraph/jetbrains


text:
Add an npm and docker release workflow

Test plan
Merge this PR, push a git tag and manually check if the release succeeds. I haven't found a better way to test changes like this than by doing an actual release.

Partly resolves https://github.com/sourcegraph/lsif-typescript/issues/3

authors: olafurpg varungandhi-src

repo: sourcegraph/lsif-typescript


text:
Update README.md

Fix typo: is => if

Thanks!

authors: parisk yurovant


text:
build file misses dependency from plugin to agent module

When I want to build the plugin straight away, the build fails, because it has a dependency on the agent module, which is not declared in the build script (but should, as Gradle supports that).
So ./gradlew buildPlugin fails with

java.io.FileNotFoundException: /Users/gregor/Develop/Assistant/agent/jvm-agent/build/libs/source-agent-0.2.2.jar (No such file or directory)

but builds fine after

./gradlew buildAgent

I'd expect the first build to succeed and build the dependency automatically, which would work in the build file expressed that explicitly.

@grexe, closing this issue since it should only be present on the  java-11-upgrade branch. Still working on that upgrade. I removed it because the JetBrains Runtime doesn't have the "jmods" folder so I was having issues with ProGaurd. Installing Java JDK 11 locally and switching to that works though.

authors: BFergerson grexe

repo: sourceplusplus/Assistant


text:
Plugins install on wrong PATH when VAGRANT_HOME is set to another location than homedir

Hi,
I've set a different VAGRANT_HOME to "D:\WORK\.vagrant.d" (for example), but, when I am using the vagrant_plugin resource, everything is still installed on C:\Users#{username}\.vagrant.d
Please modify the following code to not overwrite the PATH if VAGRANT_HOME is already set and is different than homedir/.vagrant.d
    def vagrant_home
      user_home_dir = home_dir
      ::File.join(user_home_dir, '.vagrant.d') unless user_home_dir.nil?
    end

    def home_dir
      return Dir.home unless username

      # Dir.home(user) raises ArgumentError: user `user` doesn't exist
      # on Windows so we must workaround for now.
      if windows?
        "C:/Users/#{username}" if Dir.exist?("C:/Users/#{username}")
      else
        begin
          Dir.home(username)
        rescue ArgumentError
          raise UserNotFoundError
        end
      end
    end

I just got bit by this today. I've tested that adjusting the method to the below works but ends up pulling the variable from the user executing Chef which may not be the same as the user defined at node['vagrant']['user']. In my particular use case this is ok because I'll be running sudo -E chef-solo on a workstation.
def vagrant_home
  user_home_dir = home_dir
  ENV['VAGRANT_HOME'] || ::File.join(user_home_dir, '.vagrant.d') unless user_home_dir.nil?
end

@jtimberman @cheeseplus any objections to this fix?
I've also noticed that the plugins always have root for group ownership. Will need another issue opened for that...

authors: bkonick nicutor

repo: sous-chefs/vagrant-cookbook


text:
[#6825] Update and fix WebexTeams issues

Addresses # 6825
#minor
Description
This PR updates the Thrzn41.WebexTeams package from 1.6.2 to 1.8.1, and fixes the error [CS0104](https://learn.microsoft.com/en-us/dotnet/csharp/misc/cs0104): 'Attachment' is an ambiguous reference between 'Microsoft.Bot.Schema.Attachment' and 'Thrzn41.WebexTeams.Version1.Attachment'.
Specific Changes

Updated Thrzn41.WebexTeams package from 1.6.2 to 1.8.1.
Updated Attachment references to be Schema.Attachment due to ambiguous reference between BotBuilder and WebexTeams packages.

Testing
The following image shows the unit tests and CI pipeline passing successfully.

/promoted 6833

repo: southworks/botbuilder-dotnet


text:
[Botskills] Sanitize AppSettings file

Purpose
Depends on PR#XXXX
What is the context of this pull request? Why is it being done?
Botskills is running into retrocompatibility issues as the earlier versions was using the property BotFrameworkSkills with it properties inside, in uppercase. Now Botskills uses botFrameworkSkills in lowercase.
Changes
Are there any changes that need to be called out as significant or particularly difficult to grasp? (Include illustrative screenshots for context if applicable.)
We are using the method sanitizeAppSettingsProperties for every time the AppSettings file is read. This method takes the BotFrameworkSkills property with it properties inside and change them to lowercase.
Tests
Is this covered by existing tests or new ones? If no, why not?
We tested it manually and worked as expected. We added a unit test to check the sanitizeAppSettingsProperties method.
BotFrameworkSkills in uppert case along with its properties

botFrameworkSkills after update using the sanitizeAppSettingsProperties method

Feature Plan
Are there any remaining steps or dependencies before this issue can be fully resolved? If so, describe and link to any relevant pull requests or issues.
-
Checklist
General

[ ] I have commented my code, particularly in hard-to-understand areas
[x] I have added or updated the appropriate tests
[ ] I have updated related documentation

I double checked the changes and are okay, however, we can add the same behavior in the migrate command.

Done!

repo: southworks/botframework-solutions


text:
Panel 상태에서 창 닫고, 프로그램 재시작 했을 때 panel 버튼 누르면 창 닫힘.

panel 상태에서 panel 버튼 누르면 localstorage를 popup으로 바꾸고, window.close() 실행하도록 되어있는데 그냥 창닫기 버튼을 누르면 localstorage는 그대로라서 발생하는 버그로 보입니다.

window.close 이벤트 발생 시 localstorage를 바꿔주는 코드를 추가했습니다.

repo: soyoungjeong/EmojiByEternal


text:
Add support for --no-comments to spago init

Description of the change
Here's the initial attempt to implement support for --no-comments switch (https://github.com/spacchetti/spago/issues/417)
The most future-proof approach seems to be to parse the dhall template file, remove comments from AST and pretty-print it before writing the file. This however is currently not possible due to dhall stripping most comments while parsing (see https://github.com/dhall-lang/dhall-haskell/issues/145).
This PR could be considered a hack taking advantage of this Dhall behavior and simply does parse + pretty print of dhall templates, which "accidentally" strips comments. This impl. will potentially break in the future when Dhall parser preserves comments, but I added tests to catch this.
I thought of couple of alternative approaches, but I find them even more hacky/brittle than the current PR:

Do something like Text.dropWhile (/="-}") on the dhall template files (would break once more than 1 comment is present in the template or comment is somewhere else than in the beginning)
Have another "no comment" templates and copy those instead (would require maintenance of duplicate templates)

Checklist:

[x] Added the change to the "Unreleased" section of the changelog
[ ] Added some example of the new feature to the README
[x] Added a test for the contribution (if applicable)

P.S.: the above checks are not compulsory to get a change merged, so you may skip them. However, taking care of them will result in less work for the maintainers and will be much appreciated 😊

Thanks for the feedback! spago works great and is really useful. Also the source code is nicely readable. I'd like to contribute some more to practice my Haskell :-) Let me know if there are some issues that you'd consider helpful to fix, otherwise I'll pick something with "good first issue" label

@jhrcek thanks for the kind words, I'm happy to hear this 😊
I just went through all the issues marked with "good first issue", and they should all be fine to pick up! I also tried to provide context and/or an idea for implementation in there, but if there are any details missing or confusing I'd be happy to detail more in the relevant threads 🙂

authors: f-f jhrcek

repo: spacchetti/spago


text:
Изменен MapPool для Атара, Мейн и Элизиум

Описание PR

Медиа

Проверки

[ ] PR полностью завершён и мне не нужна помощь чтобы его закончить.
[ ] Я внимательно просмотрел все свои изменения и багов в них не нашёл.
[ ] Я запускал локальный сервер со своими изменениями и всё протестировал.
[ ] Я добавил скриншот/видео демонстрации PR в игре, или этот PR этого не требует.

Изменения
У Атара, Мейн и Элизиум расширен мап пул, он стал как у Солярис, Нова и Эхо.
В связи с тем, с тем что на Атаре был убран бункер, время для прочтения правил был увеличен до 180 секунд.

:cl: Krosus777

tweak: Увеличен список станций из голосования для серверов: Атара, Мейн и Элизиум

Название пра должно по крайней мере описывать изменения
В чейнжлоге не фикс, а tweak

Исправил, ты кстати не знаешь почему мап пул такой обрезанный был у этих серверов?

Лрп сервера походу)


text:
Very slippery things should still slip on lower speed thresholds

Description
It would be nice to have certain very slippery things such as space lube or omega soap to still be able to slip players who are slowed down by the following movement speed reducers: damage, hardsuits, hunger, dragging, etc.
Currently if your movement speed is lowered by any means you wont slip even if you are not using the walk key. This makes sense with things such as banana peels since your character is moving slower after all. Some things however (space lube, omega soap) should still slip you if your character is not being extra careful, i.e using the walk key.
Additional context
Not sure how it is currently coded but when you walk do you not slip because of your lowered move speed or because of the fact you are using the walk action?

you can just change the movement threshold on SlipperyComponent


text:
Vending/other machine ghost role spam

Description

Ghost role list gets filled up with vending machine roles in needless categories. These roles can all be summarized as "worse pAI" and don't need a separate category for each vending machine type. It leads to trouble finding actually desirable roles that can interact with the round in a way that's not just screaming from an immobile prison.
Reproduction

Play a longer round, check ghost roles.
Screenshots

Additional context

Having an option to never see certain ghost roles would be a welcome addition. Does anyone actually enjoy this ghost role?

No i hate it

putting all of them under the one category would remove almost all of the wasted space

authors: AJimmyU Vaaankas deltanedas


text:
Replays always say "Waiting on Server" in context menu

It's never coming let it go.

server went out for milk and cigarettes

This is probably fixed with electro's pr that removed this message.

authors: metalgearsloth mirrorcult


text:
The Space adder cannot be butchered

Description
The space adder cannot be butchered, but there is raw snake meat in the game
Screenshots

And when the snake is butchered, it gives raw meat and not raw snake meat.

so is droping 5 meat okay?

authors: Janiano KonstantinAngelov


text:
Fix the spaghet that is collision layers

https://discord.com/channels/310555209753690112/770682801607278632/819085060862902334

IMO:

Layers should be impassable rather than passable so stuff doesn't implicitly collide.
Layers should generally be for collision only unless a particular raycast has an expensive predicate.
Anything else should probably go with EntityManager's stuff (or whatever Acruid replaces PVS with) given items don't have collision unless moving and won't show up in physics lookups.

As such here's a draft of what layers we need I think:

Opaque. This isn't used for collision but it saves doing a lot of TryGets when raycasting.
LowImpassable
MidImpassable (from Impassable)
HighImpassable
GhostImpassable
MapGrid
AudioOcclusion, maybe

The limit is effectively infinite given it's backed by an int but adding more just bloats it so it'd be better to keep these as tight as possible.
Currently I have collision disabled for anything underplating (now the broadphase prunes anything that's not collidable) but if we really need it we can add it back in.
We might also need a MobImpassable as I can't see an easy way to have combat-mode enable / disable collisions when toggled; all I can see is using an ICollideSpecial but adding the layer would be significantly faster (and given these are mob collisions are very frequent).

So, basically the list I have in my mind is

Humans

Vaulting

Crabs/Cats/Dogs/etc
Mice
Birds

So I was thinking something like
Small, Low, Mid, High
where
Small is for mice going under doors
Low is for pets going under tables
Mid is for tables and low walls blocking humans
High is for vaulting and fliers. Though I'm wondering if vaulting should be this and fly should be a separate layer.
We also probably want something for bullets going through grills/girders.

We talked about it on disc and Small / Mid / High it is.

Fixed by shadow

authors: DogZeroX ShadowCommander metalgearsloth


text:
Flying mobs can go through doors

ezfix.

Just a change to the FlyingMobMask. Wasn't sure whether to make them go through doors or not, so went with going through doors.

Can I have this assigned to me?

This should be solved once my PR is accepted. See #8236

Needs to be closed @metalgearsloth

authors: Rinzii ShadowCommander ike709 metalgearsloth


text:
Resolves PowerDeviceVisualizer is Obsolete

About the PR

Splits the PowerDeviceVisualizer into a component/system pair.
TODO:

[ ] Testing

Media

[ ] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Reopen when you come back to this.

@DrSmugleaf Commits tested and pushed. Mostly a generic visualizer now.

authors: DrSmugleaf TemporalOroboros


text:
Add a container display to dispenser UI

About the PR

Added a sprite viewer to the reagent dispenser UI window that shows the current appearance of the container inserted into the machine.
Why / Balance

It's fun and more intuitive to see the container fill up than just reading the numbers going up on the UI. This is especially fun for mixing drinks in metamorphic glasses, since you get visual feedback when making the right mix.
Technical details

Adds a SpriteView control to ReagentDispenserWindow. ReagentDispenserSystem is modified to pass the NetEntity ID of the container from the server to the client UI.
This is the first time I've messed with UI stuff, so let me know what's wrong so I can fix it.
Media

Chem dispenser:
https://github.com/space-wizards/space-station-14/assets/85356/6e13bdd2-1522-4529-b341-6f79d84ceb95
Booze/Soda dispenser (in combination with #25319):
https://github.com/space-wizards/space-station-14/assets/85356/b601cf0d-a604-40c6-93ba-3bd402480237

[X] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog

:cl:

add: Added a live preview display to reagent dispensers.

wow this is really cool

aluminium sulfuric acid and welding fuel lived in harmony
until the space lube nation attacked

authors: Tayrtahn UbaserB deltanedas


text:
Make the sentient plant mutation non-copyable to other plantholders

About the PR
This PR changes seed packets to lose the sentient mutation gene if created by clipping, the seed extractor or reverting a plant with cryoxadone. Crossing plants will no longer transfer the gene either.
Why / Balance
Fixes #20825
The ghost role menu is often spammed by lots of sentient hydroponics trays from the sentient plant mutation. The large number of these is caused by it being possible to transfer sentience by producing seeds from the mutated plant and putting them into other trays.
By removing this propagation we can make this ghost role more rare. If a botanist wants multiple sentient trays he will have to mutate each one of them separately.
The mutation has also been made rarer. While the exact probability depends on the amount of mutagen given at once and whether Left4Zed is used, my calculation says that using 90u of mutagen should give you a 50-60% chance of getting a sentient tray.
Technical details
Each time we spawn a seed packet we first clone the seed data if necessary and set the Sentient gene to false.
The Unique bool is adjusted accordingly.
The number of bits for Sentient has been reduced.
The total number of bits has been corrected.
Media

[x] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes
none
Changelog.
:cl:

tweak: The sentient plant mutation can no longer be propagated to other trays via seeds or swabs. It has also been made more rare.

Could it have been on purpose that the bit sum didn't match for the longest time?
I always assumed it was for a reason, like having mutations that don't do anything.

Could it have been on purpose that the bit sum didn't match for the longest time?
I always assumed it was for a reason, like having mutations that don't do anything.

I had a look at the git history and it seems the fun column had always been summed up wrong (70 instead of 60). People just kept adding or subtracting instead of checking the correct value.
See 7fc357afd28c68bb844e11277de1d2f6ee680df5

authors: Sirionaut slarticodefast


text:
Adding intellicard functionality.

About the PR

Intellicards can now be used to remove/insert the current AI from the core.
Why / Balance

Killing AI makes sense... I think
Technical details

The brain slot on intellicards and ai core is unlocked but cannot eject, making intellicards swap the brain between itself and the core.
Media

https://github.com/user-attachments/assets/b26716e3-1b4d-42b5-a62d-f225da3e43fc
Requirements

[X] I have read and am following the Pull Request and Changelog Guidelines.
[X] I have added media to this PR or it does not require an ingame showcase.

TODO

[ ] Make swapping the brain a doAfter.
[X] Fix a bug where actions duplicate on removing and inserting the brain.
[ ] Update laws on inserting into the core, in case the upload console is used while AI brain is taken out. (Maybe)

Breaking changes

Changelog

:cl:

add: Using an intellicard on the AI core now swaps the AI between the core and intellicard. (You can evac with the AI!)

If someone knows how to do anything in the TODO please tell me because I don't 😭

Make swapping the brain a doAfter.

i think ItemSlot has a field for this that rmc added

i think ItemSlot has a field for this that rmc added

From what ive seen ItemSlotsComponent doesnt have a field for doAfter, unless im missing something

God bless fildrance

Just need to make ai cores buildable and anchorable and then AI’s can successfully be revived after being disconnected from the station.

Maybe it shouldn't spawn in RD locker for now, as AI still doesn't have ways to protect itself against an antag breaking in and carding them

Well shit its all on fire

Tested in-game and works as intended.

Can we perhaps remove mapped intellicards and instead put one in RD's locker?

Make the intelicard require a lenghty do-after like disarming the nuke does. That way someone can't just suicide rush into AI chamber and intelicard them away, and also provides a MALF AI or just regular AI in general the chance to warn crew or fight back before they are completely neutralized. Perhaps even make it tell the AI "hey someone is uploading you into an Intelicard!"

Thats the plan!
I will be trying to do something similiar when I continue working on intellicards after this, for now this serves as a basic way to be able to kill the AI

Can we perhaps remove mapped intellicards and instead put one in RD's locker?

There is one in RD's locker but I know nothing of mapping to remove the mapped ones


text:
Welded secret doors no longer say they are welded shut.

About the PR

When examining a welded secret door it no longer says "It is welded shut".
Why / Balance

Secret doors are basically a joke with how easy they are to figure out, even if they are welded it doesnt stop someone from examining walls in a location cause they saw an odd room on the station map.
This gives a bit of a higher chance of not being found as easily.
Technical details

Set the weldedExamineMessage to nothing.
Media

See? Even you can't tell whether its a secret door or a wall now.

Requirements

[X] I have read and am following the Pull Request and Changelog Guidelines.
[X] I have added media to this PR or it does not require an ingame showcase.

Breaking changes

Changelog

:cl:

tweak: Secret doors no longer tell you if they're welded shut on examine.

While it doesnt make sense for why you can't see marks of welding on a well, it also doesnt make sense why any random person just happens to know how to open a wall.

Based. Secret doors already suffer from being given away by station maps, which are accessible to everybody, so making them harder to crack is a good thing in my mind. Should make playing a thief without externals access much more viable.


text:
Make chemistry machines and IdCardConsole use item slots

This PR makes the chemistry machines and Id card console use the ItemSlotsSystem.
Why?

It gets rid of all the duplicate insert/eject logic. See #4770
It moves the interactions to shared
I want predicted alt-click interactions.

It also adds some functionality to ItemSlotsSystem:

item slots can now be set to eject when the entity is deconstructed or destroyed
the item swapping functionality is now optional (caused problems for IdCardConsole)
item slots can optionally generate a popup message if a user attempts to insert an item that does not match the whitelist.

Issues
I think at some point @Ygg01 was working on ECSing the chemistry machines. so this might cause conflicts?
Given that there is currently an explicit popup about the chemistry machines already having a beaker inside when you attempt to insert another one, maybe the swapping behaviour is not desired? I prefer it with swapping, but it can be easily disabled.
:cl:

tweak: You can now directly swap beakers in chemistry machines. No more swap-hands > eject > swap-hands> insert.

I'm not working on any chem machine refactor. There is some puddle baggage I need to solve.


text:
Gun refactor

How guns work:

GunComponent exists
Client attempts to shoot gun n times in a specific tick, raising a predicted event, and raises an event on itself to get ammo
AmmoProviders provide ammo via subscription and handle their own logic
Bullets shot. If no bullets shot play empty sound.

AmmoCounter is also ECS driven and on its own component so any gun can have a basic ammo counting by just adding or removing the component; having specific controls is just handled by an event.
I'm putting as much code into shared as I can though because of batteries / actions / do_afters not being predicted some has to be moved (do_afters for reloads etc is tbc).
Ammo is a bit weird as supporting both hitscan and entity shooting required the interface which means launchers will add a dummy AmmoComponent to stuff being launched which immediately gets removed. This also applies to the client spawning its entities then immediately deleting them (at least for now).
ChamberMagazine + Magazine ammo providers just pass most of their events onwards to the magazines so having whatever as a magazine should be fairly simple. The yml for the itemslots is a bit cbt atm so this may change.
Other notes:

Projectile spawning isn't predicted but the muzzle flash and sound are which I think is the best we can hope for anyway.
Guns just use whitelists instead of calibers which means you can load many things into guns easily, same with ItemSlots so guns benefit from any bugfixes to those.
Significantly cut down the number of rsis and sprites, to the point it will probably have a noticeable impact on game startup
The diff is huge because I cut down rsi bloat significantly and had to update all of the map prototypes. I also deleted centcomm, dart, and moonrise because they are unmaintained and fixing their yml was much more CBT than the others (their gun containers already had magazines spawned, but some had duplicate magazines). Someone remind me to dump them in the archive repo. They need some sort of script run over them to clean them up.
Guns all have a default spread for now until I make a debug overlay and we balance it. This really isn't worse than master atm.
There's probably going to be container oddities. Detachable cells were removed from battery guns (per pjb in disc) so I deleted all of the containers but didn't get all of the children of those entities. These should easily show up in game and be deletable. I have already spent a lot of time fixing maps and I'm not spending more.

Review:
I'd recommend reviewing the following:

GunSystem and the related components
Check out a gun or two, e.g. SMGs + batteries
Trust the yml linter to do its job on the rest

Huge credit to electro for getting predicted shooting working for me & stalker for doing the gun removals beforehand.
:cl: ElectroSr, metalgearsloth, & TStalkerZero

add: Guns are now predicted. This should also lead to significantly fewer "Got late MsgEntity!" messages.
add: Selector mode for guns has been added.
remove: Many different guns have been removed to cull excess.
remove: Revolver ammo counter has been removed making spinning much more exciting.
remove: Battery weapons have had their ammo count and damage nerfed.
remove: Gun bolts have been removed.
tweak: Hitscan effects for guns are now fancy, using CEV-eris latest sprites.
tweak: Gun accuracies have all been reset to a default and will be re-balanced in the future.
tweak: Tasers are single shot until some sort of diminishing return on stuns is implemented, but should recharge faster.

Probably ready for review; ignore the Diff RSI action failure.
It's MVP so mappers can start working again and I'll do the rest.

If I have harm on, and pick up a gun, I sometimes accidentally fire the weapon

If I have harm on, and pick up a gun, I sometimes accidentally fire the weapon

Feature :HECK:

authors: metalgearsloth wrexbe


text:
Proof of Space-Time (PoST)

The Motivation
Enable proofs of fair and distributed resource expenditure.
The Requirement
Implement Rational Proofs of Space-Time.

@barakshani what's the purpose of having this issue? Why re-open it?

repo: spacemeshos/go-spacemesh


text:
Missing init file upon setup.py test

After following instructions for installation here (installing all dependent libraries etc.) the test setup failed due to missing files:

Thanks for the guidance!
P.S. I have tried on ubuntu and windows 10.

@burke86 Do you have astropy installed? If so does this work:
from astropy.modeling import projections

re-installing astropy via pip did the trick.
Many thanks.

repo: spacetelescope/asdf


text:
Saving arrays from np.broadcast_arrays fails

This:
def test_broadcasting(tmpdir):
   attrs = np.broadcast_arrays(np.array([10,20]), np.array(10), np.array(10))
   tree = {'one': attrs[0],
           'two': attrs[1],
           'three': attrs[2]}
   assert_roundtrip_tree(tree, tmpdir)

Fails with a
E           jsonschema.exceptions.ValidationError: {'shape': [2], 'source': 1, 'datatype': 'int64', 'byteorder': 'little', 'strides': [0]} is not valid under any of the given schemas

(full traceback: https://gist.github.com/Cadair/9ff970a06c4f90bf409a86b4022505f8)
I am assuming it's a problem with 'strides'

I seems that the schema for ndarray is not flexible enough with it's strides
>>> attrs = np.broadcast_arrays(np.array([[10,20],[30,40]]), np.array(10), np.array(10))
>>> attrs
[array([[10, 20],
       [30, 40]]), array([[10, 10],
       [10, 10]]), array([[10, 10],
       [10, 10]])]
>>> attrs[1].strides
(0, 0)

https://github.com/spacetelescope/asdf-standard/blob/master/schemas/stsci.edu/asdf/core/ndarray-1.0.0.yaml#L354

This section of the numpy documentation seems relevant: https://docs.scipy.org/doc/numpy-1.13.0/reference/arrays.ndarray.html#internal-memory-layout-of-an-ndarray
I think the easiest solution to this is to change the ndarray schema to also allow lists of length N (where N is the dimensionality of the array). I don't know if this would have knock-on effects in other language / array type implementations of asdf?

I'm beginning to wonder whether stride should be encoded at all as part of the schema, since it seems like an implementation detail of numpy.ndarray that may have no bearing on other implementations. The right thing to do in this case might be simply to copy the broadcasted array to the file. Although this takes up more memory on disk, it is implementation-agnostic.

authors: Cadair drdavella


text:
Replace array class code with ndarray class plus copy

While my previous fix for the memory leak problem fixed that issue, other code in generic_io.py and its tests expects that the returned object be an ndarray. Since using the frombuffer call followed by a copy to break the reference achieves the same result as using array, I've replaced my previous change to MemoryIO with this new change.

@bernie-simon Could you please add an entry to the Changelog.
Other than that and the small inline comment, is this ready to be merged? It'd be good to put a new release out (1.1.1 ? )because the latest release does not work with astropy 1.2.

Coverage increased (+0.002%) to 93.858% when pulling d6799e13b1e2b098cf1782799e230350d166bf9d on bernie-simon:memory_leak into b8a7ad64d5c98d65744f25c4e6b39af354a99891 on spacetelescope:master.

authors: bernie-simon coveralls nden


text:
Add support for ecmascript 6 generator functions

Hi, I added support for generator function from ecmascript 6. Here is a test regular expression against which I was testing.

When I write comment like this, I got this:

This works for me. Here's the output
class TeamInviteLink extends Controller {
  /**
   * [test description]
   * @return {[type]}
   */
  test() {

  }
}

authors: spadgos szarouski wanming

repo: spadgos/sublime-jsdocs


text:
use full width images in posts

https://infrastructure.sparcopen.org/landscape-analysis/elsevier

Do you want people to be able to click on the images, or for the images to appear, inline, in full-size? It will bleed & overlap with the right-side content, unless we make the right-side content not sticky.

erm, I want them the full width of the text (so, the RHS column would be clear)

Ah okay, then it’s not a CSS issue. Do you just need to crop the images then?

Oh… is there just a bunch of whitespace in the images 🙃?
Joseph McArthur
Assistant Director: Right to Research Coalition ( http://righttoresearch.org )
Director / Founder: Open Access Button ( http://openaccessbutton.org )
Twitter: @Mcarthur_Joe ( https://twitter.com/Mcarthur_Joe )
Skype: joseph_mcarthur
On Mon, Jun 22, 2020 at 5:49 PM, Sophy < notifications@github.com > wrote:

Ah okay, then it’s not a CSS issue. Do you just need to crop the images
then?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub (
https://github.com/sparcopen/infrastructure/issues/80#issuecomment-647642291
) , or unsubscribe (
https://github.com/notifications/unsubscribe-auth/ABFZMZ23LPTL4H7PI7NW2RTRX6DRHANCNFSM4ODIHECQ
).

Yep!

Ah, if it's fast for you to crop them then that would be great... but if it isn't let me know and I deal with it.

Sure, but shouldn’t you have the source material instead of the PNGs? Probably easier to export from there -- if not, no problem, I can do that too...

Should do, let me hunt down.
Joseph McArthur
Assistant Director: Right to Research Coalition ( http://righttoresearch.org )
Director / Founder: Open Access Button ( http://openaccessbutton.org )
Twitter: @Mcarthur_Joe ( https://twitter.com/Mcarthur_Joe )
Skype: joseph_mcarthur
On Mon, Jun 22, 2020 at 6:31 PM, Sophy < notifications@github.com > wrote:

Sure, but shouldn’t you have the source material instead of the PNGs?
Probably easier to export from there -- if not, no problem, I can do that
too...
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub (
https://github.com/sparcopen/infrastructure/issues/80#issuecomment-647671295
) , or unsubscribe (
https://github.com/notifications/unsubscribe-auth/ABFZMZZBFOCAYNXNWRX3NRDRX6IOPANCNFSM4ODIHECQ
).

I've cropped them

authors: JosephMcArthur sssoz

repo: sparcopen/infrastructure


text:
check access token before API call

KENMBP:test kennethlimcp$ pwc patch.json
Error loading command /usr/local/lib/node_modules/particle-cli/commands/SerialCommand.js Error: Module version mismatch. Expected 48, got 47.
Using settings from the file  patch.json
Sending webhook request  { uri: '/v1/webhooks',
  method: 'POST',
  json:
   { },
  headers: { Authorization: 'Bearer' } }

! Please login - it appears your access token may have expired

Error Invalid token
KENMBP:test kennethlimcp$ p --version
1.19.0-libraries.20

This is a catch-22: there's no way to know that a token is expired before doing an API call, so the CLI has to go ahead and make the API call and reports the error if the token has expired.

I agree it's a catch 22 situation, although we may be able to offer a smoother experience.
How about this:  in interactive mode, the CLI could catch the authentication error when running a command, prompt the user to login and then rerun the command entered. This provides a smoother experience.
In non-interactive mode, it would fail as it does now.
Another alternative is that we save the login credentials (securely) and automatically obtain a new access token when we detect it has expired.  I see pros and cons with this (smoother, but hiding the fact the token has expired), just throwing it out there for discussion.

authors: kennethlimcp m-mcgowan monkbroc

repo: spark/particle-cli


text:
'typedef' ignored in declaration SparkFunMLX90614.h

Hello Sparkfun,
I am just starting with Arduino and I have problems verifying the MLX_Get_ID code. It refers to SparkFun_MLX90614_Arduino_Library/src/SparkFunMLX90614.h and gives the following warning:
In file included from ...\Arduino\libraries\SparkFun_MLX90614_Arduino_Library-master\examples\MLX90614_Get_ID\MLX90614_Get_ID.ino:25:0:
...\Arduino\libraries\SparkFun_MLX90614_Arduino_Library-master\src/SparkFunMLX90614.h:54:1: warning: 'typedef' was ignored in this declaration [enabled by default]
};
^
So, this example didn't work out for me, as well as the other three examples.
What is it that I am doing wrong?
Luc

I'm having the same problem, from what I was able to narrow down: The: typedef ernum wasn't done correctly. At least based on C++ it wasn't. It looks like the name of the enumerator need to go between the } and the ; so it would look like:
typedef enum{
banana1
banana2
banana3
}banana_num;
That's what I could find, I might be looking at the wrong thing though.

Same same.

Hi folks - I am attempting to replicate using an Uno under Arduino 1.8.7 but cannot. Perhaps the compiler has changed slightly since first issue report but the GetID example compiles fine for me. Regardless, I've moved the declarator after the enum brackets (better practice). Should be fixed in v1.0.2. Please re-open if you continue to have issues.

authors: BurgerDan Resonanz lvZandbrink nseidle


text:
Make "beginEnvironment" automatic

We try to avoid "setup" functions as it is very easy for a user to put them in. Instead, call "beginEnvironment" automatically on the first call that requires it.

@pelikhan The reason for the initialization block in these libraries is to teach our target audience that some of these sensors require a few bytes to be sent to them before they can start working. In my opinion, it's valuable to know that these lines of code should be placed in the "on start" loop

You could keep a variable to track the “setup” has been called once. What happens when you forget this?

I could just set up a boolean and do that, yes. If we omit this block, the sensor will respond with 0xFF or not at all if I remember correctly. There are two sensors on board that require initialization and we would prefer to keep this step in there, as initialization is common in many devices

So if the kid forget that blocs, it will look like your sensor is broken.

That's the idea!

All sensors on the micro:bit perform lazy initialization on first use; this is a common pattern used all across the system (radio, acc, magnetometer, ...). Why would your sensor be different?

repo: sparkfun/pxt-gator-environment


text:
Preview mode by default

I don't want to see the HTML markup in my editor view. I just want to see the rendered output. Is this possible?

@GigaMick There is a function togglePreview() on your SimpleMDE Object, you could call that after assigning the editor to textarea

@GigaMick There is a function togglePreview() on your SimpleMDE Object, you could call that after assigning the editor to textarea

authors: ChristianGroeber GigaMick

repo: sparksuite/simplemde-markdown-editor