text:
ListView.builder and SingleChildScrollView do not scroll in Firefox on Android

To see the problem just create the standard example app and modify the build method this way:
Widget build(BuildContext context) {
   return Scaffold(
     appBar: AppBar(
       title: Text(widget.title),
     ),
     body: ListView.builder(
         itemCount: 1000, itemBuilder: (context, index) => Text("a$index")),
   );
 }

It will display the numbers from 0 to 999.
Build it using
flutter build web --target=lib/main.dart
and then view it in Firefox and Google Chrome on Android (latest versions on Android 11). It works fine in Google Chrome but in Firefox it cannot be scrolled. Each swipe/drag gesture results only in the content being scrolled up/down by about half a line of text.
Tested with the latest stable, beta and dev version:
Flutter 2.5.0-5.1.pre • channel beta • https://github.com/flutter/flutter.git
Flutter 2.5.0-6.0.pre • channel dev • https://github.com/flutter/flutter.git
Tested with
Firefox 91.1.0 (Build #2015826187) on Android 11
Firefox 91.2.0 (Build #2015828467) on Android 11
When using Flutter 2.0.0-2.0.3 it cannot be scrolled at all in Firefox. Starting with Flutter 2.0.4 it scrolls as slow as in the latest version 2.5.0-6.0.pre.

Hi @dg76, I can replicate the issue Listview is not scrollable in the firefox browser, Heres the sample app deployed on the web built on the latest master channel.

code sample
import 'package:flutter/material.dart';

 void main() {
  runApp(MyApp());
}

class MyApp extends StatefulWidget {
  const MyApp({Key? key}) : super(key: key);

  @override
  _MyAppState createState() => _MyAppState();
}

class _MyAppState extends State<MyApp> {
  bool toggleOff = true;

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
        debugShowCheckedModeBanner: false,
        title: 'Flutter Demo',
        home: InfiniteListView());
  }
}
class InfiniteListView extends StatefulWidget {
  const InfiniteListView({Key? key}) : super(key: key);

  @override
  _InfiniteListViewState createState() => _InfiniteListViewState();
}

class _InfiniteListViewState extends State<InfiniteListView> {
  @override
  Widget build(BuildContext context) {
    final int length = Colors.primaries.length;
    return Scaffold(
      floatingActionButton: FloatingActionButton(
        onPressed: () {
          isDark = !isDark;
          darkNotifier.value = isDark;
        },
        tooltip: 'Increment',
        child: Icon(isDark ? Icons.wb_sunny_outlined : Icons.bubble_chart),
      ),
      appBar: AppBar(
        title: Text('ListView example'),
      ),
      body: ListView.builder(
          itemCount: 100,
          itemBuilder: (context, index) {
            return Container(
              color: Colors.primaries[index % length],
              height: 80,
              alignment: Alignment.center,
              child: Text(
                '${Colors.primaries[index % length]}',
                style: TextStyle(color: Colors.white),
              ),
            );
          }),
    );
  }
}

Output
Chrome
https://user-images.githubusercontent.com/31410839/129856571-880e1f7d-1f85-4f7e-90f1-ddf7d19cca8e.mov
Firefox
https://user-images.githubusercontent.com/31410839/129856548-4175ec12-3cc5-4f84-ba55-554c738040b3.mov

flutter doctor -v
[✓] Flutter (Channel stable, 2.2.3, on macOS 11.5.2 20G95 darwin-arm, locale en-GB)
    • Flutter version 2.2.3 at /Users/mahesh/Documents/flutter
    • Framework revision f4abaa0735 (6 weeks ago), 2021-07-01 12:46:11 -0700
    • Engine revision 241c87ad80
    • Dart version 2.13.4

[✓] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
    • Android SDK at /Users/mahesh/Library/Android/sdk
    • Platform android-31, build-tools 31.0.0
    • ANDROID_HOME = /Users/mahesh/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.8+10-b944.6916264)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 12.5.1, Build version 12E507
    • CocoaPods version 1.10.1

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.8+10-b944.6916264)

[✓] VS Code (version 1.58.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.25.0

[✓] Connected device (4 available)
    • iPhone 12 Pro Max (mobile) • 5430F628-A903-402C-A635-D55D7E6EEFCA • ios            •
      com.apple.CoreSimulator.SimRuntime.iOS-14-5 (simulator)
    • macOS (desktop)            • macos                                • darwin-arm64   • macOS 11.5.2
      20G95 darwin-arm
    • Chrome (web)               • chrome                               • web-javascript • Google Chrome
      92.0.4515.131

• No issues found!

[✓] Flutter (Channel master, 2.5.0-7.0.pre.8, on macOS 11.5.2 20G95 darwin-arm, locale en-GB)
    • Flutter version 2.5.0-7.0.pre.8 at /Users/mahesh/Documents/flutter_master
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 40e8620a27 (7 days ago), 2021-08-06 09:14:50 +0430
    • Engine revision 431ac604da
    • Dart version 2.14.0 (build 2.14.0-383.0.dev)

[✓] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
    • Android SDK at /Users/mahesh/Library/Android/sdk
    • Platform android-31, build-tools 31.0.0
    • ANDROID_HOME = /Users/mahesh/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.8+10-b944.6916264)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 12.5.1, Build version 12E507
    • CocoaPods version 1.10.1

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.8+10-b944.6916264)

[✓] VS Code (version 1.58.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.25.0

[✓] Connected device (4 available)
    • iPhone 12 Pro Max (mobile) • 5430F628-A903-402C-A635-D55D7E6EEFCA • ios            •
      com.apple.CoreSimulator.SimRuntime.iOS-14-5 (simulator)
    • macOS (desktop)            • macos                                • darwin-arm64   • macOS 11.5.2
      20G95 darwin-arm
    • Chrome (web)               • chrome                               • web-javascript • Google Chrome
      92.0.4515.131

• No issues found!

Interestingly both examples (mine and the deployed example) seem to work fine now on
Firefox 93.1.0 (Build #2015836707) on Android 11
So it seems to have been fixed, maybe with version 93 of Firefox. That's great, thank you very much! 🎉😊
Can anyone confirm that?

Thanks, on our side I've confirmed that this was caused by a regression in Firefox 91, which has been fixed in Firefox 92 and later.

authors: dg76 maheshmnj theres-waldo


text:
No separation of hintText and suffixText with end-aligned TextField

Steps to Reproduce
Focus the TextField.
Expected results:
The hint text and suffix text are separated by a space, the way the entered text is separated from the suffix text.
Actual results:
The hint text and suffix text are not separated.

Code sample
import 'package:flutter/material.dart';

void main() {
  runApp(MyApp());
}

class MyApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      home: Scaffold(
        body: Center(
          child: TextField(
            textAlign: TextAlign.end,
            decoration: InputDecoration(
              hintText: 'hintText',
              suffixText: 'suffixText',
            ),
          ),
        ),
      ),
    );
  }
}

Logs
Reproduced on DartPad - Based on Flutter 2.5.3 Dart SDK 2.14.4

No text entered:

Text "hintText" entered:

Hi @JetA2, I tested this issue on the latest stable and master channel and it is reproducible.

flutter doctor -v
[✓] Flutter (Channel stable, 2.5.3, on macOS 11.6.1 20G224 darwin-x64, locale en-US)
    • Flutter version 2.5.3 at /Users/flo/development/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 18116933e7 (4 weeks ago), 2021-10-15 10:46:35 -0700
    • Engine revision d3ea636dc5
    • Dart version 2.14.4

[!] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
    • Android SDK at /Users/flo/Library/Android/sdk
    • Platform android-31, build-tools 31.0.0
    • Java binary at: /Applications/Android Studio.app/Contents/jre/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.10+0-b96-7281165)
    ! Some Android licenses not accepted.  To resolve this, run: flutter doctor --android-licenses

[✓] Xcode - develop for iOS and macOS
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 13.0, Build version 13A5212g
    • CocoaPods version 1.11.0

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2020.3)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.10+0-b96-7281165)

[✓] VS Code (version 1.60.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.27.0

[✓] Connected device (4 available)
    • sdk gphone x86 (mobile)    • emulator-5554                        • android-x86    • Android 11 (API 30) (emulator)
    • iPhone 12 Pro Max (mobile) • 98CBBFB1-4069-4A28-B7F7-138911ACBE72 • ios            •
      com.apple.CoreSimulator.SimRuntime.iOS-15-0 (simulator)
    • macOS (desktop)            • macos                                • darwin-x64     • macOS 11.6.1 20G224 darwin-x64
    • Chrome (web)               • chrome                               • web-javascript • Google Chrome 93.0.4577.63

! Doctor found issues in 1 category.

[✓] Flutter (Channel master, 2.6.0-12.0.pre.701, on macOS 11.6.1 20G224 darwin-x64, locale en-US)
    • Flutter version 2.6.0-12.0.pre.701 at /Users/flo/fvm/versions/master
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 24b9346c9b (7 hours ago), 2021-11-11 16:45:40 -0800
    • Engine revision aaacb670af
    • Dart version 2.15.0 (build 2.15.0-285.0.dev)
    • DevTools version 2.8.0

[!] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
    • Android SDK at /Users/flo/Library/Android/sdk
    • Platform android-31, build-tools 31.0.0
    • Java binary at: /Applications/Android Studio.app/Contents/jre/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.10+0-b96-7281165)
    ! Some Android licenses not accepted.  To resolve this, run: flutter doctor --android-licenses

[✓] Xcode - develop for iOS and macOS (Xcode 13.0)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • CocoaPods version 1.11.0

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2020.3)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.10+0-b96-7281165)

[✓] VS Code (version 1.60.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.27.0

[✓] Connected device (4 available)
    • sdk gphone x86 (mobile)    • emulator-5554                        • android-x86    • Android 11 (API 30) (emulator)
    • iPhone 12 Pro Max (mobile) • 98CBBFB1-4069-4A28-B7F7-138911ACBE72 • ios            • com.apple.CoreSimulator.SimRuntime.iOS-15-0 (simulator)
    • macOS (desktop)            • macos                                • darwin-x64     • macOS 11.6.1 20G224 darwin-x64
    • Chrome (web)               • chrome                               • web-javascript • Google Chrome 93.0.4577.63

! Doctor found issues in 1 category.

Thank you

What is the correct behavior ? no spaces for both? or one space for both?

I found that the real cause for this is the cursor width so it is not a character space as it seemed , the documentation says that negative values can be used to reverse this effect ,,you can use cursorWidth = -2 for example , unfortunately this will work in release mode as there an assert preventing it to accept negative values , I will make PR to correct this behavior .

Thanks for looking into this.
Since the correct behaviour is no space between hint text and suffix text, is there a way to actually achieve a space?
I tried adding a space at the end of the suffix text but trailing spaces do not seem to have an effect or they get trimmed off somewhere. Or is there a unicode "hard space" that can be used at the end of the suffix text to force a space?

I tried adding a space at the end of the suffix text but trailing spaces do not seem to have an effect or they get trimmed off somewhere. Or is there a unicode "hard space" that can be used at the end of the suffix text to force a space?

'\u202f' seems to do the trick.

@Reekoooo started work on this in https://github.com/flutter/flutter/pull/93634. If anyone would like to take that work across the finishing line please don't hesitate to take the code from that PR and apply the review comments @justinmc left there, and then create a new PR with the result!

source: gharchive/issue

authors: Hixie JetA2 Reekoooo mamuseferha

repo: flutter/flutter

license_type: permissive

license_source: github-api


text:
Marker does not rotate on the web

I wrote an app using the google_maps_flutter_platform_interface library. A custom marker properly rotates according to the rotation setting on Android, but not on the web, where the rotation is always 0 (north).

@Henk-Keijzer
Can you provide flutter doctor -v, plugin version and a complete minimal reproducible code sample that shows the behavior you are seeing ?

This is the code I use to create the marker:
Future buildShips(ships) async {
shipList = [];
following = [];
shipMarkerList = {};
for (var k = 0; k < ships.length; k++) {
shipList.add(ships[k]['name']);           // add the name to the shipList for the menu
following.add(false);                     // set following to false
shipMarkerList.addAll({MarkerId(ships[k]['name']) : Marker(
markerId: MarkerId(ships[k]['name']),
anchor: Offset(0.5, 0.5),
icon: await shipMarkerIcon (shipMarkerColorTable[int.parse(ships[k]['colorcode'])], markerBackGroundColor),
position: LatLng(ships[k]['lat'][0].toDouble(), ships[k]['lon'][0].toDouble()),
rotation: ships[k]['course'][0].toDouble(),
flat: true,
)});
}
}
On web all icons are pointing to "north", on Android the are pointing in the direction indicated with "rotation"

@Henk-Keijzer
We would need a complete minimal reproducible code sample that we can directly copy paste and run to verify the issue. The code you provided seem to have lot of custom variables that we can't directly use, so please provide a runnable code sample, along with flutter doctor -v and plugin version.
Thanks.

Hi Darshankawar, I added the following simple routine to my code and this has the same result on the website (flutter build web). I did not test it on the connected Chrome or Edge device, because it would otherwise use cross-domain connections (which is not allowed).
Future buildShip(ship) async {
shipMarkerList.addAll({MarkerId(ship) : Marker(
markerId: MarkerId(ship),
anchor: Offset(0.5, 0.5),
position: LatLng(52.2, 4.5),
rotation: 90.0,
flat: true,
)});
}
My guess is that it has to do with the fact that rotation in flutter is a double and in the Android Google SDK an integer.
This is the result of flutter doctor -v:
[√] Flutter (Channel stable, 2.8.1, on Microsoft Windows [Version 10.0.22000.376], locale nl-NL)
• Flutter version 2.8.1 at K:\AndroidStudioProjects\flutter
• Upstream repository https://github.com/flutter/flutter.git
• Framework revision 77d935af4d (3 weeks ago), 2021-12-16 08:37:33 -0800
• Engine revision 890a5fca2e
• Dart version 2.15.1
[!] Android toolchain - develop for Android devices (Android SDK version 32.0.0)
• Android SDK at C:\Users\hwkei\AppData\Local\Android\sdk
X cmdline-tools component is missing
Run path/to/sdkmanager --install "cmdline-tools;latest"
See https://developer.android.com/studio/command-line for more details.
X Android license status unknown.
Run flutter doctor --android-licenses to accept the SDK licenses.
See https://flutter.dev/docs/get-started/install/windows#android-setup for more details.
[√] Chrome - develop for the web
• Chrome at C:\Program Files\Google\Chrome\Application\chrome.exe
[√] Android Studio (version 2020.3)
• Android Studio at C:\Program Files\Android\Android Studio
• Flutter plugin can be installed from:
https://plugins.jetbrains.com/plugin/9212-flutter
• Dart plugin can be installed from:
https://plugins.jetbrains.com/plugin/6351-dart
• Java version OpenJDK Runtime Environment (build 11.0.10+0-b96-7249189)
[√] Connected device (3 available)
• Nokia X20 (mobile) • AQKSLVH030M42600828 • android-arm64  • Android 12 (API 31)
• Chrome (web)       • chrome              • web-javascript • Google Chrome 96.0.4664.110
• Edge (web)         • edge                • web-javascript • Microsoft Edge 96.0.1054.62
! Doctor found issues in 1 category.
As far as I know I have the latest plugin version...
Flutter is already up to date on channel stable
Flutter 2.8.1 • channel stable • https://github.com/flutter/flutter.git
Framework • revision 77d935af4d (3 weeks ago) • 2021-12-16 08:37:33 -0800
Engine • revision 890a5fca2e
Tools • Dart 2.15.1
Process finished with exit code 0

O, and BTW, I installed the command line tools and accepted the android licenses, but that did not make any difference,,,,
Thanks

There are more problems. I use the following to move the marker(s) to another position:
  shipMarkerList.addAll({MarkerId(track['name']) : Marker(
  markerId: MarkerId(track['name']),
  anchor: Offset(0.5, 0.5),
  icon: await shipMarkerIcon (shipMarkerColorTable[int.parse(track['colorcode'])], markerBackGroundColor),
  position: LatLng(calculatedLat, calculatedLon),
  rotation: calculatedRotation,
  flat: true,
  )});

The addALL replaces the marker with MarkerId in the list, or adds a new one of the marker is does not exist yet.
This works perfectly on Android, but on web, the markers do not move....

@Henk-Keijzer
I think you are hitting same issue as reported here: https://github.com/flutter/flutter/issues/80578
Please follow-up in it for further updates.
Closing this as a duplicate. If you disagree, write in comments and I'll reopen it.

Ok! Thanks so far.

Similar code for Polylines works ok!!

authors: Henk-Keijzer darshankawar


text:
Roll Engine from 3c6d4da86862 to 98ba539627de (7 revisions)

https://github.com/flutter/engine/compare/3c6d4da86862...98ba539627de
2022-04-18 skia-flutter-autoroll@skia.org Roll Dart SDK from 5896bc42f9dc to 020d55c3ddd3 (1 revision) (flutter/engine#32731)
2022-04-17 skia-flutter-autoroll@skia.org Roll Dart SDK from c41c8589857a to 5896bc42f9dc (2 revisions) (flutter/engine#32730)
2022-04-17 skia-flutter-autoroll@skia.org Roll Skia from dc07bc65622c to 4f1107c8b4b7 (4 revisions) (flutter/engine#32728)
2022-04-17 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 9MKoWhaYn... to BUsSUZga0... (flutter/engine#32727)
2022-04-17 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from 2Vv6DrgEK... to dCChXvyRA... (flutter/engine#32726)
2022-04-17 skia-flutter-autoroll@skia.org Roll Dart SDK from 0a3c40c7860e to c41c8589857a (2 revisions) (flutter/engine#32724)
2022-04-17 skia-flutter-autoroll@skia.org Roll Skia from 9cf1448788b9 to dc07bc65622c (4 revisions) (flutter/engine#32723)
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from 9MKoWhaYnvu0 to BUsSUZga0yT-
fuchsia/sdk/core/mac-amd64 from 2Vv6DrgEKSuX to dCChXvyRALqG
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC kaushikiska@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Commit queue failed; closing this roll.

source: gharchive/pull-request


text:
Fix NavigationDestination API doc

Fixes https://github.com/flutter/flutter/issues/103032
Pre-launch Checklist

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I read the Tree Hygiene wiki page, which explains my responsibilities.
[x] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[x] I signed the CLA.
[x] I listed at least one issue that this PR fixes in the description above.
[x] I updated/added relevant documentation (doc comments with ///).
[x] I added new tests to check the change I am making, or this PR is test-exempt.
[x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Thanks!


text:
Add AppLifecycleListener, with support for application exit handling

Description
This adds AppLifecycleListener, a class for listening to changes in the application lifecycle, and responding to requests to exit the application.
It depends on changes in the Engine that add new lifecycle states: https://github.com/flutter/engine/pull/42418
Related Issues

https://github.com/flutter/flutter/issues/30735

Tests

Added tests for new lifecycle value, as well as for the AppLifecycleListener itself.

Okay, I think this is ready for another look, @goderbauer.


text:
Dragging a field while unfocused should do nothing

Fixes https://github.com/flutter/flutter/issues/93143

I'm struggling to reproduce the test failures locally.  Pushed a merge commit.

(triage) @justinmc Is this one still on your radar?

Now it is, thanks for the reminder!  I think I'm going to be able to fix the tests and get this into review.

I'm struggling to test this, but I also should verify that this is behavior that we want for Flutter by default.  I should try something similar to the example in the issue but in plain HTML/JS and see what happens (and maybe on native Android and iOS too).
Also @Renzo-Olivares may come up with a way to disable dragging in the future, since it interferes with Scrollables sometimes.

Closing since https://github.com/flutter/flutter/issues/93143 is closed.

authors: goderbauer justinmc


text:
Roll Flutter Engine from a0925f158198 to 935dc94ecfaa (5 revisions)

https://github.com/flutter/engine/compare/a0925f158198...935dc94ecfaa
2023-05-11 skia-flutter-autoroll@skia.org Roll Skia from 9cbc2c578e10 to a12a999cbd09 (2 revisions) (flutter/engine#41933)
2023-05-11 skia-flutter-autoroll@skia.org Roll Skia from 1a29bd9a0147 to 9cbc2c578e10 (10 revisions) (flutter/engine#41932)
2023-05-11 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from a3rrULFaXlwS8mfjW... to 2tQjI0g3aDmjHAtMw... (flutter/engine#41931)
2023-05-11 jacksongardner@google.com Return fonts in a deterministic order. (flutter/engine#41907)
2023-05-11 58529443+srujzs@users.noreply.github.com Turn @staticInterop tear-off into closure (flutter/engine#41885)
Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from a3rrULFaXlwS to 2tQjI0g3aDmj
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Commit queue failed; closing this roll.


text:
Roll Flutter Engine from faf1121d010c to e297eab21d78 (7 revisions)

https://github.com/flutter/engine/compare/faf1121d010c...e297eab21d78
2023-07-26 skia-flutter-autoroll@skia.org Roll Dart SDK from b5710782b91c to 8961d36eaa0c (1 revision) (flutter/engine#44048)
2023-07-26 skia-flutter-autoroll@skia.org Roll Skia from 990aa6016ff6 to fdf224be4f98 (3 revisions) (flutter/engine#44046)
2023-07-26 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from d6O9t74z-k2svOmvz... to pgJmG2-qZVMzlMuq8... (flutter/engine#44045)
2023-07-26 skia-flutter-autoroll@skia.org Roll ANGLE from 58cb5c8396a3 to 451b3c31a1fa (1 revision) (flutter/engine#44044)
2023-07-26 skia-flutter-autoroll@skia.org Roll Skia from d76a9c3bb3fd to 990aa6016ff6 (4 revisions) (flutter/engine#44043)
2023-07-26 skia-flutter-autoroll@skia.org Roll Skia from ca48e45a0262 to d76a9c3bb3fd (1 revision) (flutter/engine#44042)
2023-07-26 skia-flutter-autoroll@skia.org Roll Dart SDK from b1e82e2e55b2 to b5710782b91c (4 revisions) (flutter/engine#44040)
Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from d6O9t74z-k2s to pgJmG2-qZVMz
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Commit queue failed; closing this roll.


text:
Roll Flutter Engine from 55314d08d792 to 8a2e15824025 (5 revisions)

https://github.com/flutter/engine/compare/55314d08d792...8a2e15824025
2023-09-20 skia-flutter-autoroll@skia.org Roll Dart SDK from ed05ca364d5e to d5d05146868a (1 revision) (flutter/engine#46104)
2023-09-20 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from aHtib4LBcLwx7JwK-... to QcxgV9KlY7j3o3b4j... (flutter/engine#46102)
2023-09-20 skia-flutter-autoroll@skia.org Roll Skia from 9bc5eeb93a1e to 565d95f72f2e (1 revision) (flutter/engine#46100)
2023-09-20 ychris@google.com [ios] Reland "[ios] use python script to generate extension safe frameworks and code sign them" #46004" (flutter/engine#46014)
2023-09-20 skia-flutter-autoroll@skia.org Roll Skia from f54c214a739b to 9bc5eeb93a1e (2 revisions) (flutter/engine#46099)
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from aHtib4LBcLwx to QcxgV9KlY7j3
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Commit queue failed; closing this roll.


text:
Roll Flutter Engine from 8b490a9f1650 to 83db8663e6b0 (8 revisions)

https://github.com/flutter/engine/compare/8b490a9f1650...83db8663e6b0
2023-11-09 skia-flutter-autoroll@skia.org Roll Skia from b6ce84dc3e53 to b055626ce8c2 (1 revision) (flutter/engine#47850)
2023-11-09 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from sD8HRA4JmXczujkqO... to 0pD5ceqf-e9y9NTNn... (flutter/engine#47847)
2023-11-09 goderbauer@google.com Remove physical geometry (flutter/engine#47825)
2023-11-09 skia-flutter-autoroll@skia.org Roll Skia from f3e4fd80eeeb to b6ce84dc3e53 (1 revision) (flutter/engine#47843)
2023-11-09 skia-flutter-autoroll@skia.org Roll Skia from d9ec01cf15ff to f3e4fd80eeeb (3 revisions) (flutter/engine#47838)
2023-11-09 737941+loic-sharma@users.noreply.github.com [Windows] Remove global state in keyboard tests (flutter/engine#47829)
2023-11-08 mdebbar@google.com [web] Non-singleton implementation of ui.FlutterView (flutter/engine#47806)
2023-11-08 gspencergoog@users.noreply.github.com Move window state update to window realize callback (flutter/engine#47713)
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from sD8HRA4JmXcz to 0pD5ceqf-e9y
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Commit queue failed; closing this roll.


text:
[flutter_fuchsia] Adds flutter_fuchsia.

Includes very basic functionality to connect to a VM instance and
determine the active Flutter Views running on the machine.

@awdavies / @Hixie could you provide a bit more clarity on what this is?

Long term this is intended to replace lots of code that should be shared between flutter_driver and flutter_tools in such a way as to allow connecting to an arbitrary number of Dart VM's, and then on top of that allow for driving stories/mods on Fuchsia devices similar to flutter_driver.
I am unsure where the highest priorities lie regarding those requirements.  I am simply implementing things with guidance from @yjbanov.  I am also unsure of how much information has been sync'd between @yjbanov and @Hixie.  It appears they are both on the same page now?  I need to sync up with Yegor, though, to make sure I understand (as far as I understand there is no up-to-date PRD or design doc to reference).
At the time of writing this I am under the impression this is initially going to be more Fuchsia-centric code, but now I'm not sure given the existing feedback.

I'm just hoping to avoid stepping over existing namespaces (e.g. FlutterView, Isolate, VMService etc).

Since this is in its own package I wouldn't worry too much about that.

I can understand this, but is there a workaround so that we can support logging?  I think it is at least important to know if, say, the user doesn't have permission to bind to a port or the like.

Sure, just use print or provide a callback that you invoke. Logging doesn't have to be particularly complicated. :-)

Ah.  This was something I blatantly stole from flutter_tools.

Oh dear, we still have code there that does this? I thought we'd excised all of it. Sigh. I'll file a bug or something to deal with that. In the meantime, yeah, let's avoid reproducing this mistake here.
Happy to give a more detailed review, let me know when it's ready. :-)

@Hixie @yjbanov PTAL
Supports IPv6 and has tests and such. Logging is self-contained, etc.  I've addressed all concerns AFAICT, though I'm unsure how well the code is tested regarding actual SSH.

If @Hixie is ok with the high-level structure of this package, I can do a detailed code review.

General approach SGTM.

@yjbanov Comments addressed.  PTAL

-[x] the unit tests run as part of our Travis script
-[x] the package is captured by the analyzer
-[x]  all types that are returned by public API are also exported through libraries under lib/ (so that a user does not have to import from lib/src)

@yjbanov @Hixie there are some minor analyzer issues (but these are due to the flutter package.  slider_theme.dart is also missing documented public members).

@Hixie, did you want to do a code style pass on this PR, or is it good to merge?

Just some style nits and one race condition that we should fix before landing (we've had huge troubles with race conditions like this causing flakes, and I really don't want to go down that road again...).

@Hixie @yjbanov
Everything should be ready to go!

Oh wait... had to fix a constructor.  Should be good.

Great!

authors: Hixie awdavies shrike69 yjbanov


text:
Allow search page widget search field hint text and keyboard text input action to be customizable

Description
Currently, the search page widget's hint text and keyboard text input action are hardcoded to the material localization of 'Search' and the search text input action, respectively. This prevents further customization where search functionality is desired, but the nuance of the action isn't exactly "searching" (e.g. adding a location via Google Maps Places API autocomplete).
Added a getHintText function (that takes in a BuildContext) and a textInputAction field to SearchDelegate. These default to the previous hardcoded attributes that were present in SearchPage.
These changes are purely aesthetic changes; no additional functionality is provided.
All tests still pass.
Related Issues
N/A
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] My PR includes tests for all changed/updated/fixed behaviors (See Test Coverage).
[x] All existing and new tests are passing.
[x] I updated/added relevant documentation (doc comments with ///).
[x] The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
[x] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[x] I signed the CLA.
[x] I am willing to follow-up on review comments in a timely manner.

Breaking Change
Does your PR require Flutter developers to manually update their apps to accommodate your change?

[ ] Yes, this is a breaking change (Please read Handling breaking changes).
[x] No, this is not a breaking change.

While you're at it, please do keyboardType: https://github.com/flutter/flutter/issues/29983
You don't always search with text.

I agree with the idea to add keyboardType to this as well.
Looks like all tests are passing now.  @somarkoe are you still available to get this PR in?

Yes! Sorry, been swamped by work and haven't touched the project that deals with this in a while. I'll add the keyboard type request to it as well.

Awesome, thank you @somarkoe.  Update the PR when you get a chance and I'll be happy to help you get this in.

@justinmc Perhaps will you be able to get https://github.com/flutter/flutter/pull/28165 in too? There's so much about the search page that is hard coded and it shouldn't be.

Yeah that one looks straightforward to me.  The original reviewer @HansMuller isn't around today but I'll talk it through with him when he's back.

Abandoned? :(

Oops, been a while since I've used git.
Reopened and made the relevant changes. Sorry it took so long!

😍 merge this ish!

Only thing that could be added on is https://github.com/flutter/flutter/pull/30388 / https://github.com/flutter/flutter/pull/28165 (seems like they are the same 1 line of code)

@somarkoe Thanks for following up and no worries about the delay!
Sorry to drag this out longer, but I realized that this should update the tests as well.  This test should probably say "keyboard shows search button by default" now.
Then, could you add a separate test that tests a different textInputAction?  Just duplicate that other test and add textInputAction to the TestHomePage parameters.
After that this is good to go and we can merge.

@MichaelPriebe I'll try to see if we can get things moving on those 2 other PRs you referenced.

@justinmc how's this going?

Waiting on @somarkoe for the changes mentioned above.

@somarkoe come thru

Oops, didn't notice the warning not to override, but also unsure how to alleviate this problem in the test. Thoughts?

@justinmc What do you think?

I made the fields non-final since apparently overriding fields when a class is extended is no bueno, and this abstract class is one meant to be extended and not implemented (since it has functions with default behaviors).

Excited for this, can finally ditch my very hacky extension of the search delegate.

@justinmc Is it ready now?

Lets get this pull a'mergin'!

@somarkoe What do you think about the suggestions?

@somarkoe Would love to hear what you think about the suggested changes.

So sorry! Was on vacation and now I'm moving 😅
Ill take a look ASAP!

I'm going to close this since https://github.com/flutter/flutter/pull/36409 has been merged. Thank you @somarkoe for your initial work with this!

authors: MichaelPriebe justinmc shihaohong somarkoe


text:
Revert "Fix TextField height issues"

Reverts flutter/flutter#27205

/cc @justinmc fyi - this broke some internal tests

Yep - specifically, see this

authors: dnfield tvolkert


text:
Roll engine a32df2c92800..153416e554ef (2 commits)

https://github.com/flutter/engine/compare/a32df2c92800...153416e554ef
git log a32df2c9280033c93a7ed089c294566dabfbf693..153416e554ef3cad38f5d569373b995fc9240d92 --no-merges --oneline
153416e55 Eliminate deprecated super_goes_last lint (flutter/engine#9156)
473f17ff8 Roll src/third_party/skia c4fec06e5a3b..3cd435eecf5e (13 commits) (flutter/engine#9155)
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (cbracken@google.com), and stop
the roller if necessary.

Auto-roller completed checks. About to merge.


text:
Added demo projects for splash screen support on Android.

Added demo projects for splash screen support on Android.
These projects intended both as a demo for app devs to see what is possible, as well as ready built debugging projects for Flutter team devs that need to work on splash support on Android.
Note: Do not merge until the associated engine work has merged:
https://github.com/flutter/engine/pull/9525

Looks like the analyzer is unhappy: https://cirrus-ci.com/task/6536306685902848

@xster @dnfield would one or both of you mind reviewing this PR? This PR adds 2 manual projects for future verification, as well as a "kitchen sink" project that is hooked up to the device lab. I ran the device lab test locally and it passes.
The PR that contains the code being exercised in these projects is here:
https://github.com/flutter/engine/pull/9525
That other PR already has an LGTM - it's just waiting for tests to be approved.

@xster I ran optipng on the pngs but git isn't showing any diff to commit. Do you know what I need to do to update those in git?

Chatted offline. We're not sure why optipng doesn't show changes in git, but we'll leave the PNGs as-is for now.

Everything is green. I'm gonna merge these in.

Looks like the new devicelab test is failing.

authors: Hixie goderbauer matthew-carroll


text:
Roll engine ff49ca1c6e5b..99355b086229 (23 commits)

git@github.com:flutter/engine.git/compare/ff49ca1c6e5b...99355b086229
git log ff49ca1c6e5b..99355b086229 --no-merges --oneline
2019-08-10 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from bvUCO... to xqsy5... (flutter/engine#10826)
2019-08-10 skia-flutter-autoroll@skia.org Roll src/third_party/skia 89e43889afd9..3e7fa79f2c79 (1 commits) (flutter/engine#10825)
2019-08-10 skia-flutter-autoroll@skia.org Roll src/third_party/skia fe19203eb7d7..89e43889afd9 (1 commits) (flutter/engine#10824)
2019-08-10 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from HsuAH... to bvUCO... (flutter/engine#10822)
2019-08-10 bkonyi@google.com Roll src/third_party/dart ffefa124a7..e29d6d0ecb (4 commits)
2019-08-10 skia-flutter-autoroll@skia.org Roll src/third_party/skia af89d3972e0b..fe19203eb7d7 (5 commits) (flutter/engine#10819)
2019-08-10 bkonyi@google.com Roll src/third_party/dart 15a3bf82cb..ffefa124a7 (11 commits)
2019-08-09 chris@bracken.jp Roll Dart SDK 78ce916d82..15a3bf82cb (flutter/engine#10810)
2019-08-09 skia-flutter-autoroll@skia.org Roll src/third_party/skia b7b0b3ad538c..af89d3972e0b (7 commits) (flutter/engine#10812)
2019-08-09 jonahwilliams@google.com Revert "Remove flutter_kernel_sdk dart script (#10808)" (flutter/engine#10811)
2019-08-09 iska.kaushik@gmail.com [dart:zircon] Porting Cache re-usable handle wait objects (flutter/engine#10809)
2019-08-09 jonahwilliams@google.com Remove flutter_kernel_sdk dart script (flutter/engine#10808)
2019-08-09 cfontas@google.com change add part to add child (flutter/engine#10787)
2019-08-09 yjbanov@google.com rename stub_ui to web_ui (flutter/engine#10776)
2019-08-09 kpozin@google.com [fuchsia] Migrate from custom FuchsiaFontManager to SkFontMgr_fuchsia (flutter/engine#10700)
2019-08-09 skia-flutter-autoroll@skia.org Roll src/third_party/skia 26cedb4c603b..b7b0b3ad538c (11 commits) (flutter/engine#10807)
2019-08-09 egarciad@google.com Rename flutter_java.jar and flutter_engine.jar so they match the Maven comvention (flutter/engine#10797)
2019-08-09 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from 9xVXx... to HsuAH... (flutter/engine#10806)
2019-08-09 bkonyi@google.com Roll src/third_party/dart 3d9a356f6e..78ce916d82 (7 commits)
2019-08-09 skia-flutter-autoroll@skia.org Roll src/third_party/skia b2151310068b..26cedb4c603b (1 commits) (flutter/engine#10804)
2019-08-09 skia-flutter-autoroll@skia.org Roll src/third_party/skia 059bf776c184..b2151310068b (3 commits) (flutter/engine#10803)
2019-08-09 bkonyi@google.com Roll src/third_party/dart f29f41f1a5..3d9a356f6e (65 commits)
2019-08-09 skia-flutter-autoroll@skia.org Roll src/third_party/skia 4d557e3df433..059bf776c184 (1 commits) (flutter/engine#10801)
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (jimgraham@google.com), and stop
the roller if necessary.

Trybots failed. These were the failed builds: https://cirrus-ci.com/task/5206984322711552 , https://cirrus-ci.com/task/4644034369290240

Commit queue failed; closing this roll.


text:
Fixed Render Overflow error on text selection

Description
Added horizontal scrolling ability to the text selection toolbar.
Related Issues
Fixes  #35826
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I signed the CLA.
[ ] I updated/added relevant documentation (doc comments with ///).
[x] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[x] All existing and new tests are passing.
[x] The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
[x] I am willing to follow-up on review comments in a timely manner.

Breaking Change
Does your PR require Flutter developers to manually update their apps to accommodate your change?

[ ] Yes, this is a breaking change (Please read Handling breaking changes). Replace this with a link to the e-mail where you asked for input on this proposed change.
[x] No, this is not a breaking change.

Yeh, sure. I'll check this out. Thanks for your reply. And where should I make the tests for my code?

I think I would put your tests in this file: https://github.com/flutter/flutter/blob/master/packages/flutter/test/material/text_selection_test.dart
You might want to look around here for some similar tests that you can copy from.  That one isn't exactly what you're looking for, but it should show you how to render a text field, show the selection menu, and expect the size of something.

Thanks @justinmc

Added new pull request #39624.


text:
[AppBarTheme] adds centerTitle property

Description
Adds centerTitle property in AppBarTheme.
Related Issues
Fixes #45639
Tests
I added the following tests:

Added test to check that AppBar uses AppBarTheme.centerTitle when centerTitle is null.
Added test to check that AppBar.centerTitle  takes priority over AppBarTheme.centerTitle.
Added test to check that AppBar.centerTitle adapts to TargetPlaform when AppBarTheme.centerTitle is null.

Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I signed the CLA.
[x] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[x] I read the Tree Hygiene wiki page, which explains my responsibilities.
[x] I updated/added relevant documentation (doc comments with ///).
[x] All existing and new tests are passing.
[x] The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
[x] I am willing to follow-up on review comments in a timely manner.

Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.

[x] No, no existing tests failed, so this is not a breaking change.
[ ] Yes, this is a breaking change. If not, delete the remainder of this section.

[ ] I wrote a design doc: https://flutter.dev/go/template Replace this with a link to your design doc's short link
[ ] I got input from the developer relations team, specifically from: Replace with the names of who gave advice
[ ] I wrote a migration guide: Replace with a link to your migration guide

@shihaohong Awseome, thank you 😄


text:
Roll Engine from 39a31934c68a to b5ebf221d083 (1 revision)

https://github.com/flutter/engine/compare/39a31934c68a...b5ebf221d083
2020-08-05 skia-flutter-autoroll@skia.org Roll Dart SDK from 363c72111d12 to 8cb0afa882c4 (5 revisions) (flutter/engine#20258)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC liyuqian@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Commit queue failed; closing this roll.


text:
Update tool string

Fixes #6417
'pub get' should be 'flutter packages get'
'pub run tests' should be 'flutter test'
'pub upgrade' should be 'flutter packages upgrade'

I'm seeing now something fragile happens with the --pub command in create.dart because the order should occur at an overridden place rather than the default. Sorry about that, fixing....

You should feel free to update this CL, or you can close it and start a new.  Completely up to you!  There were definitely some useful parts here, just not all of it was correct.
Thanks again for your help!  We really appreciate it!

authors: eseidelGoogle warent


text:
Abort a hot reload if we detect an error in flutter.yaml

[x] Better handling of Flutter.yaml errors.
[x] Do not allow a reload to happen with an error in flutter.yaml

Fixes https://github.com/flutter/flutter/issues/6726

authors: Hixie johnmccutchan


text:
Roll Engine from dd17c0883ec0 to 4749578a5d63 (4 revisions)

https://github.com/flutter/engine/compare/dd17c0883ec0...4749578a5d63
2021-07-07 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from YKiGmmdKT... to 57vjq86y7... (flutter/engine#27207)
2021-07-07 skia-flutter-autoroll@skia.org Roll Dart SDK from 586ecc5a0697 to 6f9810c8f7da (1 revision) (flutter/engine#27202)
2021-07-07 skia-flutter-autoroll@skia.org Roll Skia from 40242241c3bf to 40586cf1f885 (2 revisions) (flutter/engine#27201)
2021-07-07 matej.knopp@gmail.com MacOS (metal): Block raster thread instead of platform thread. (flutter/engine#27191)
Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from YKiGmmdKTUQT to 57vjq86y7ZzN
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Commit queue failed; closing this roll.


text:
Roll Engine from f0325b6a3d6d to 19f853d5a733 (14 revisions)

https://github.com/flutter/engine/compare/f0325b6a3d6d...19f853d5a733
2021-07-20 skia-flutter-autoroll@skia.org Roll Dart SDK from b410651bd18e to f82b36d0b4f0 (5 revisions) (flutter/engine#27582)
2021-07-20 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 665qcW5C1... to q6H_ZE5Bs... (flutter/engine#27581)
2021-07-20 jason-simmons@users.noreply.github.com Extract the prebuilt Dart SDK to a temp directory and then move it after the extraction completes (flutter/engine#27569)
2021-07-20 skia-flutter-autoroll@skia.org Roll Skia from b5cd95b58fba to d37bb6ae7248 (1 revision) (flutter/engine#27578)
2021-07-20 matej.knopp@gmail.com MacOS: Release backbuffer surface when idle (flutter/engine#27189)
2021-07-20 skia-flutter-autoroll@skia.org Roll Skia from 3f6e8d8864bb to b5cd95b58fba (2 revisions) (flutter/engine#27576)
2021-07-20 skia-flutter-autoroll@skia.org Roll Skia from 2373b9ed9617 to 3f6e8d8864bb (2 revisions) (flutter/engine#27575)
2021-07-20 skia-flutter-autoroll@skia.org Roll Skia from 38a6e5aa1a49 to 2373b9ed9617 (1 revision) (flutter/engine#27574)
2021-07-20 skia-flutter-autoroll@skia.org Roll Skia from 946a4cb8acb7 to 38a6e5aa1a49 (8 revisions) (flutter/engine#27573)
2021-07-20 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from 897eI2xwc... to rQOi2N8BM... (flutter/engine#27572)
2021-07-20 30870216+gaaclarke@users.noreply.github.com Added a test filter for objc tests (flutter/engine#27566)
2021-07-20 skia-flutter-autoroll@skia.org Roll Skia from fe49b2c6f41b to 946a4cb8acb7 (9 revisions) (flutter/engine#27564)
2021-07-20 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from FGuPZEZLt... to 665qcW5C1... (flutter/engine#27561)
2021-07-20 flar@google.com add test for scaled playback of DL and SkPicture (flutter/engine#27503)
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from FGuPZEZLt_5Z to q6H_ZE5BsiK1
fuchsia/sdk/core/mac-amd64 from 897eI2xwc8f5 to rQOi2N8BMbLj
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC garyq@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Gold has detected about 2 new digest(s) on patchset 14.
View them at https://flutter-gold.skia.org/cl/github/86725

Landing manually as the golden diffs are due to an earlier problem


text:
Sindhi app

Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.
List which issues are fixed by this PR. You must list at least one issue.
If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
Pre-launch Checklist

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I read the Tree Hygiene wiki page, which explains my responsibilities.
[x] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[x] I signed the CLA.
[x] I listed at least one issue that this PR fixes in the description above.
[x] I updated/added relevant documentation (doc comments with ///).
[ ] I added new tests to check the change I am making, or this PR is test-exempt.
[ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Gold has detected about 2 new digest(s) on patchset 7.
View them at https://flutter-gold.skia.org/cl/github/96031

This PR looks like it was branched off of a different branch from master, resulting in a large diff and meaning it will not be mergeable. Please see tree hygiene for more details about how to open pull requests to Flutter repositories.
Feel free to create a new pull request with these same changes branched off of master, and thanks for contributing!

authors: CaseyHillers skia-gold vrajshah24


text:
[share] Use NSURL when sharing non-image files to make correct actions appear in share sheet

Description
When sharing a non-image file with the iOS share sheet (via the share plugin), the correct actions based on the file type are not appearing in the share sheet.
For example, when sharing a PDF file, the share sheet currently looks like the screenshot on the left. Notice that compared with the screenshot on the right, the current share sheet does not include the Markup or Print actions.

Current Behavior
Fixed - Using NSURL

The fix consists of using a NSURL based on the supplied file path when initializing the UIActivityViewController.
I've tested the fix with several file types including pdf, mp4, and docx; additional relevant share sheet actions are now being shown for each file type.
I'm sure there's some cleanup required if my fix is accepted, but as my Objective-C chops leave a lot to be desired, I'll be looking to the package maintainer(s) for guidance here.
Checklist

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
[x] All existing and new tests are passing.
[x] I updated/added relevant documentation (doc comments with ///).
[x] The analyzer (flutter analyze) does not report any problems on my PR.
[x] I read and followed the Flutter Style Guide.
[x] The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
[x] I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
[x] I updated CHANGELOG.md to add a description of the change.
[x] I signed the CLA.
[x] I am willing to follow-up on review comments in a timely manner.

Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?

[ ] Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
[x] No, this is not a breaking change.

when i used video player plugin to load videos from assets for story play like instagram so the video couldn't load properly in ios simulator and some times app crashes when starting playing video and navigate to next video i used code from this url
https://github.com/MarcusNg/flutter_instagram_stories
please look at this issue

when i used video player plugin to load videos from assets for story play like instagram so the video couldn't load properly in ios simulator and some times app crashes when starting playing video and navigate to next video i used code from this url
https://github.com/MarcusNg/flutter_instagram_stories
please look at this issue

Not sure how the issue you're describing is related to the share plugin or my PR.

Thanks for the submission! However, we’re currently not accepting non-critical PRs for this plugin, as we hope in time to be able to transition users to the corresponding plugin in the Flutter Community Plus Plugins repository. We encourage you to submit your PR there.
We apologize for the long delay in triaging this PR. We’re in the process of overhauling our PR triage system to respond much more quickly, as well as working through the backlog.

authors: jaymahaab philiplindberg stuartmorgan

repo: flutter/plugins


text:
[webview_flutter] Update webview packages for Android and iOS to implement runJavascript and runJavascriptReturningResult.

This PR implements the newly added runJavaScript and runJavaScriptForResult methods added to the platform interface in #4401.
This is meant as a solution to the issue mentioned in flutter/flutter#66318, and was discussed offline with @mvanbeusekom and @stuartmorgan.
As this PR also depends on and includes the changes from #4401, this PR will remain in draft state until that PR is merged and published.
Relevant issue:

flutter/flutter#66318

Pre-launch Checklist

[x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
[x] I read the [Tree Hygiene] wiki page, which explains my responsibilities.
[x] I read and followed the [relevant style guides] and ran [the auto-formatter]. (Note that unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
[x] I signed the [CLA].
[x] The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
[x] I listed at least one issue that this PR fixes in the description above.
[x] I updated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy].
[x] I updated CHANGELOG.md to add a description of the change.
[x] I updated/added relevant documentation (doc comments with ///).
[x] I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
[x] All existing and new tests are passing.

I think I've fixed every case now where "JavaScript" could be used, while still using "Javascript" where it was needed to either stay consistent or prevent a breaking change.
If you still find any cases I missed, let me know!


text:
Roll Flutter from a20cd33d6734 to 4aa843a606b5 (3 revisions)

https://github.com/flutter/flutter/compare/a20cd33d6734...4aa843a606b5
2022-04-13 engine-flutter-autoroll@skia.org Roll Plugins from 700fba5b1bc7 to ace57091e0c7 (20 revisions) (flutter/flutter#101839)
2022-04-13 jonahwilliams@google.com Revert "[framework] use ImageFilter for zoom page transition" (flutter/flutter#101838)
2022-04-13 christopherfujino@gmail.com [flutter_conductor] fix conductor codesign --upstream flag (flutter/flutter#101782)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-plugins
Please CC dit@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Plugins: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Commit queue failed; closing this roll.


text:
Support sign-in with Github and linking Github accounts to existing users

Fulfills feature request: https://github.com/flutter/flutter/issues/21331

@filleduchaos Hello, how is this intended to be used? Where do we get the Token from?

@lukepighetti Hey sorry - saw this late! Much like with any OAuth thing you'd get the token back from the provider (in this case, likely through a Sign In With Github web flow)

authors: filleduchaos lukepighetti


text:
Add rtl

Automatic rtl detection and field rtl in chewieController for the display buildBottomBar

Could you explain why this is needed?
Does the video player bottom bar need to be inverted for rtl countries?
Your solution is well thought out but misses a few things.
In my opinion we should not include localization libraries just to find out if rlt and then reverse the controls.
Is there any benefit or real need to reverse the controls?
@Ahmadre What's your opinion?

Could you explain why this is needed?
Does the video player bottom bar need to be inverted for rtl countries?
Your solution is well thought out but misses a few things.
In my opinion we should not include localization libraries just to find out if rlt and then reverse the controls.
Is there any benefit or real need to reverse the controls?
@Ahmadre What's your opinion?

Rtl is not only related to localizations, but also to accessibility. It would be nice if left-handed people enjoy apps made with chewie.
So, thumbs up from me for this 👍🏼

@mreslami please re-sync your changes with the latest master changes, then I'll be able to finish reviewing. Thanks in advance.

authors: Ahmadre diegotori mreslami nstrelow

repo: fluttercommunity/chewie

license: MIT


text:
[battery_plus]: Couldn't get battery info on iOS simulator

What is your question?

Clone the sample app from here
https://github.com/fluttercommunity/plus_plugins/tree/main/packages/battery_plus/battery_plus
Run the app on a iPhone 15 Pro(iOS 17.5) simulator
I got the following error

[ERROR:flutter/runtime/dart_vm_initializer.cc(41)] Unhandled Exception: PlatformException(UNAVAILABLE, Battery info unavailable, null, null)

How can I fix this problem?
flutter doctor

[✓] Flutter (Channel stable, 3.22.1, on macOS 14.5 23F79 darwin-arm64, locale
    en-US)
[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
[✓] Xcode - develop for iOS and macOS (Xcode 15.4)
[✓] Chrome - develop for the web
[✓] Android Studio (version 2023.3)
[✓] VS Code (version 1.89.1)
[✓] Connected device (6 available)
[✓] Network resources

• No issues found!

Checklist before submitting a question

[X] I searched issues in this repository and couldn't find such bug/problem
[X] I Google'd a solution and I couldn't find it
[X] I searched on StackOverflow for a solution and I couldn't find it
[X] I read the README.md file of the plugin
[X] I am using the latest version of the plugin
[X] All dependencies are up to date with flutter pub upgrade
[X] I did a flutter clean
[X] I tried running the example project

The plugin returns an error because the battery state cannot be determined. iOS returned as battery state: https://developer.apple.com/documentation/uikit/uidevicebatterystate/uidevicebatterystateunknown
Doing a quick search online seems that this is a common issue: https://stackoverflow.com/questions/74224835/uidevice-batterylevel-always-returns-1-in-simulator

authors: miquelbeltran tomgly

license_source: bigquery


text:
[Compile]: Swift Compiler Error (Xcode): Instance member 'connectivityProvider' cannot be used on type 'ConnectivityPlusPlugin'

Operating System
macOS Sonoma version 14.6.1
Plugin
connectivity_plus
Version
6.1.0
Flutter SDK
3.24.3
Compilation command
fvm flutter run
Dart Dependencies
No response
Native dependencies
No response
Compilation Error
Swift Compiler Error (Xcode): Instance member 'connectivityProvider' cannot be used on type 'ConnectivityPlusPlugin'
/Users/vishwa/.pub-cache/hosted/pub.dev/connectivity_plus-6.1.0/darwin/connectivity_plus/Sources/connectivity_plus/ConnectivityPlusPlugin.swift:41:64

Could not build the application for the simulator.
Error launching application on iPhone 16.

Flutter Doctor
[✓] Flutter (Channel stable, 3.24.3, on macOS 14.6.1 23G93 darwin-arm64, locale en-IN)
    • Flutter version 3.24.3 on channel stable at /Users/vishwa/fvm/versions/3.24.3
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 2663184aa7 (9 weeks ago), 2024-09-11 16:27:48 -0500
    • Engine revision 36335019a8
    • Dart version 3.5.3
    • DevTools version 2.37.3

[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
    • Android SDK at /Users/vishwa/Library/Android/sdk
    • Platform android-34, build-tools 34.0.0
    • Java binary at: /Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 17.0.10+0-17.0.10b1087.21-11572160)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 16.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 16B40
    • CocoaPods version 1.16.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2023.3)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 17.0.10+0-17.0.10b1087.21-11572160)

[✓] VS Code (version 1.94.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.100.0

[✓] Connected device (3 available)
    • macOS (desktop)                 • macos                 • darwin-arm64   • macOS 14.6.1 23G93 darwin-arm64
    • Mac Designed for iPad (desktop) • mac-designed-for-ipad • darwin         • macOS 14.6.1 23G93 darwin-arm64
    • Chrome (web)                    • chrome                • web-javascript • Google Chrome 130.0.6723.119

[✓] Network resources
    • All expected network resources are available.

• No issues found!

Checklist before submitting a bug

[X] I searched issues in this repository and couldn't find such bug/problem
[X] I Google'd a solution and I couldn't find it
[X] I searched on StackOverflow for a solution and I couldn't find it
[X] I read the README.md file of the plugin
[X] I'm using the latest version of the plugin
[X] All dependencies are up to date with flutter pub upgrade
[X] I did a flutter clean
[X] I tried running the example project

FYI, When tried building with connectivity_plus-6.0.5 its building properly with no issues.

Mmmhh I cannot reproduce it either with an ios objc project, I did the following:
flutter create -i objc --empty test_ios
flutter pub add connectivity_plus
open ios/Runner.xcworkspace (to fix provisioning profile)
flutter build ios

Compilation worked:
Building com.example.testIos.xyz for device (ios-release)...
Automatically signing iOS for device deployment using specified development team in Xcode project: _______
Running pod install...                                             805ms
Running Xcode build...
 └─Compiling, linking and signing...                         3.6s
Xcode build done.                                           34.1s
✓ Built build/ios/iphoneos/Runner.app (25.1MB)

Can you do the same and see if it builds for you?

I got similar issue with connectivity_plus-6.1.0
Error (Xcode): 'ConnectivityPlusPlugin' has different definitions in different modules; first difference is definition in module 'connectivity_plus.Swift'
found 2 referenced protocols
/Users/Documents/test-project/app/build/ios/Production-Release-iphoneos/connectivity_plus/connectivity_plus.framework/Headers
/connectivity_plus-Swift.h:310:11

Modules Issue (Xcode): Definition of 'ConnectivityPlusPlugin' must be imported from module 'connectivity_plus.Swift' before it is required
/Users/Documents/test-project/ios/Runner/GeneratedPluginRegistrant.m:167:3

Encountered error while building for device.

However, this problem does not occur in connectivity_plus-6.0.5.
This is AppDelegate.swift
import UIKit
import Flutter
import GoogleMaps
import flutter_local_notifications

@main
@objc class AppDelegate: FlutterAppDelegate {
  override func application(
    _ application: UIApplication,
    didFinishLaunchingWithOptions launchOptions: [UIApplication.LaunchOptionsKey: Any]?
  ) -> Bool {
    // This is required to make any communication available in the action isolate.
    FlutterLocalNotificationsPlugin.setPluginRegistrantCallback { (registry) in
      GeneratedPluginRegistrant.register(with: registry)
    }
    if #available(iOS 10.0, *) {
      UNUserNotificationCenter.current().delegate = self as? UNUserNotificationCenterDelegate
    }
    //Google Maps API Key
    GMSServices.provideAPIKey("")
    GeneratedPluginRegistrant.register(with: self)
    return super.application(application, didFinishLaunchingWithOptions: launchOptions)
  }
  // for the OneSignal package
  override func userNotificationCenter(_ center: UNUserNotificationCenter, willPresent notification: UNNotification, withCompletionHandler completionHandler: @escaping (UNNotificationPresentationOptions) -> Void) {
      super.userNotificationCenter(center, willPresent: notification, withCompletionHandler: completionHandler)
  }
  override func userNotificationCenter(_ center: UNUserNotificationCenter, didReceive response: UNNotificationResponse, withCompletionHandler completionHandler: @escaping () -> Void) {
      super.userNotificationCenter(center, didReceive: response, withCompletionHandler: completionHandler)
  }
}

And the project also has a swift code section like this: NotificationService.swift
import UserNotifications

import OneSignalExtension

class NotificationService: UNNotificationServiceExtension {

    var contentHandler: ((UNNotificationContent) -> Void)?
    var receivedRequest: UNNotificationRequest!
    var bestAttemptContent: UNMutableNotificationContent?

    override func didReceive(_ request: UNNotificationRequest, withContentHandler contentHandler: @escaping (UNNotificationContent) -> Void) {
        self.receivedRequest = request
        self.contentHandler = contentHandler
        self.bestAttemptContent = (request.content.mutableCopy() as? UNMutableNotificationContent)

        if let bestAttemptContent = bestAttemptContent {
            /* DEBUGGING: Uncomment the 2 lines below to check this extension is executing
                          Note, this extension only runs when mutable-content is set
                          Setting an attachment or action buttons automatically adds this */
            // print("Running NotificationServiceExtension")
            // bestAttemptContent.body = "[Modified] " + bestAttemptContent.body

            OneSignalExtension.didReceiveNotificationExtensionRequest(self.receivedRequest, with: bestAttemptContent, withContentHandler: self.contentHandler)
        }
    }

    override func serviceExtensionTimeWillExpire() {
        // Called just before the extension will be terminated by the system.
        // Use this as an opportunity to deliver your "best attempt" at modified content, otherwise the original push payload will be used.
        if let contentHandler = contentHandler, let bestAttemptContent =  bestAttemptContent {
            OneSignalExtension.serviceExtensionTimeWillExpireRequest(self.receivedRequest, with: self.bestAttemptContent)
            contentHandler(bestAttemptContent)
        }
    }
}

Do you see this error in debug builds or only release builds?
The only change in 6.1.0 is that it deleted the objc plugin definition, which is not clear for me if it was still necessary: https://github.com/fluttercommunity/plus_plugins/pull/3173/files
Is your project somehow an old codebase?

@miquelbeltran Thank you for your quick reply.
Sure, this is a project I've been managing for 3 years, but I'm using the latest stable flutter version, and all 28 other packages except connectivity_plus are the latest versions.
Could it be that removing the objc plugin definition is causing conflicts with other packages? Or is it that I have objc in my code base?

Could it be that removing the objc plugin definition is causing conflicts with other packages? Or is it that I have objc in my code base?

I think the issue is a combination of old(ish) Flutter native codebase and removing the objc definition, indeed.
A newly created Flutter project with objc doesn't have this issue.
A possible solution can be to revert part of the changes in #3173 but keeping the Swift package support. The problem is that I cannot reproduce the issue on my side, so I'd love if someone who has the problem can try this somehow and submit a PR.

Thank you for your reply.
Let me try again with new codebase

@miquelbeltran We were on flutter 3.0 and while upgrading to 3.24.3. Whats the solution for upgradation use cases.


text:
Create a flux cheatsheet

It'd be great to have a flux cmd cheatsheet that covers the most interesting use-cases.
For Flux Legacy there's this: https://gist.github.com/j33ty/58c9761f5f261e3218bb8787cb26a5d9

The Flux legacy cheatsheet is not relevant to Flux v2. Given that the v2 CLI has hundreds of cmd/args combination we could use kubectl as an example https://kubernetes.io/docs/reference/kubectl/cheatsheet/

I know - I was just mentioning it to illustrate how a cheatsheet could be done, or what kind of actions might be useful to consider. The one for kubectl looks very nice and might indeed be a better example of how to implement it.

I was just mentioning it to illustrate how a cheatsheet could be done, or what kind of actions might be useful to consider.

None of the actions from the Flux Legacy cheatsheet are possible in v2. Flux v2 API is very different, the whole operation model is different too. You can't release things from the CLI, not you can query workloads nor images...

I guess this can be closed now that we have https://fluxcd.io/flux/cheatsheets/?

authors: dholbach stefanprodan

repo: fluxcd/website


text:
bug: update scratch org pool prereq error url

Checklist
All items have to be completed before a PR is merged

[x] Adhere to Contribution Guidelines
[ ] Updates to Decision Records considered?
[ ] Updates to documentation at flxbl-sfp Guide considered?
[ ] Tested changes?
[ ] Unit Tests new and existing passing locally?

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

authors: CLAassistant nbatterham

repo: flxbl-io/sfp


text:
Allow overriding of _linkify() widget to give more flexibility with markdown

Necessary for https://github.com/flyerhq/flutter_chat_ui/pull/206
This allows us to pass the Markdown component to be rendered. The links can be caught and opened through that too.

Thanks for the PR!

authors: demchenkoalex felixgabler


text:
Can't bootstrap flynn in development environment

Recently I have started to get the following error:
03:28:21.940907 wait router-wait error: bootstrap: timed out waiting for http://router-api.discoverd, last response "Get http://router-api.discoverd: dial tcp: lookup router-api.discoverd: no such host"
Steps to re-produce:

vagrant destroy
vagrant up
vagrant ssh
vagrant build
script/bootstrap-flynn

$ script/bootstrap-flynn
===> 03:26:02.571 killing running libvirt-lxc flynn-host, if any
error: command 'destroy' requires <domain> option
===> 03:26:06.382 done!
===> 03:26:06.384 starting single node cluster
opening volume state db...
DBUG[11-05|03:26:06] zfs get all -Hp flynn-default            package=zfs
DBUG[11-05|03:26:06] zfs get all -Hp flynn-default/152f3476-4a12-4713-9708-e8619601fbdc package=zfs
DBUG[11-05|03:26:06] zfs get all -Hp flynn-default/6d90d807-4291-49ed-8cb5-8f55e14072a9 package=zfs
DBUG[11-05|03:26:06] zfs get all -Hp flynn-default/c98e4744-2899-4111-be9a-63f7d24c1f5f package=zfs
volume state db opened.
removing volume id="c98e4744-2899-4111-be9a-63f7d24c1f5f"... DBUG[11-05|03:26:06] zfs destroy -f flynn-default/c98e4744-2899-4111-be9a-63f7d24c1f5f package=zfs
success
removing volume id="152f3476-4a12-4713-9708-e8619601fbdc"... DBUG[11-05|03:26:06] zfs destroy -f flynn-default/152f3476-4a12-4713-9708-e8619601fbdc package=zfs
success
removing volume id="6d90d807-4291-49ed-8cb5-8f55e14072a9"... DBUG[11-05|03:26:06] zfs destroy -f flynn-default/6d90d807-4291-49ed-8cb5-8f55e14072a9 package=zfs
success
state db file "/var/lib/flynn/volumes/volumes.bolt" removed.
===> 03:26:06.801 bootstrapping Flynn
03:26:06.887065 check online-hosts
03:26:07.918948 require-env require-env
03:26:07.920627 resource-check resource-check
03:26:07.923418 run-app discoverd
03:26:08.720173 run-app flannel
03:26:09.434233 wait-hosts wait-hosts
03:26:11.445158 gen-random pg-password
03:26:11.445400 gen-random pg-password 159ad88994a024cc8293ab0272928764
03:26:11.445473 run-app postgres
03:26:14.164411 gen-random controller-key
03:26:14.164547 gen-random controller-key c2af74c835578a2cab916ed0aab77727
03:26:14.164554 gen-random dashboard-session-secret
03:26:14.164616 gen-random dashboard-session-secret 355e08f0979715d4305575a5c53e3dad
03:26:14.164625 gen-random dashboard-login-token
03:26:14.165355 gen-random dashboard-login-token d8526a5ed0f499819a4d116046ea7610
03:26:14.165632 gen-random name-seed
03:26:14.165947 gen-random name-seed 71bff21e0641a39ecf60
03:26:14.166434 gen-random router-sticky-key
03:26:14.167022 gen-random router-sticky-key MCsseZb5zCBrZci5xcJO8/BqwAnfZYCLbwNtLHYXs9Y=
03:26:14.167118 wait postgres-wait
03:26:14.695944 gen-tls-cert controller-cert
03:26:17.964597 gen-tls-cert controller-cert pin: v1QwXeQRXP863t4M3THOns7PIh/hav2/s5K7sMibmrc=
03:26:17.964648 run-app controller
03:26:19.110120 wait controller-wait
03:26:19.793107 add-app controller-inception
03:26:19.864550 add-app postgres-app
03:26:19.889076 add-app flannel-app
03:26:19.910369 add-app discoverd-app
03:26:19.929919 scale-app scheduler-scale
03:26:19.935912 run-app scheduler
03:26:20.518697 deploy-app blobstore
03:26:21.016965 deploy-app router
03:26:21.426683 deploy-app gitreceive
03:26:21.455515 wait router-wait
03:28:21.940907 wait router-wait error: bootstrap: timed out waiting for http://router-api.discoverd, last response "Get http://router-api.discoverd: dial tcp: lookup router-api.discoverd: no such host"

Check flynn-host ps -a, is the router job running or stopped/crashed? Is there anything in the log? (flynn-host log $JOB_ID)

Also, make sure you ran make clean after destroying/recreating the VM.

I run make clean very often. Will get back about the rest.

both router and discoverd are running. will collect logs into a gist.

https://gist.github.com/anonymous/505c5c2583c5fd33a5cc
also saw this while creating the debug gist:
EROR[11-05|03:42:16] error capturing output of "iptables -L -v -n --line-numbers" err="exit status 3"

This looks like the relevant error:

error binding to port (check if another service is listening on :3128): address already in use

19:47 < rikurr> ha-ha-ha, squid3 process binds to the same port as discoverd
19:47 < rikurr> Maybe something you guys might want to reconsider in the future.
19:47 < rikurr> and I might have to continue work on my caching PR.. :)

@rikur the problem is not discoverd but rather that the default TCP range for the router is 3000-3500 and it will bind to all ports in that range.

authors: josephglanville rikur titanous

repo: flynn/flynn


text:
9.12 - Unable to determine the original schema for the connection

Which version and edition of Flyway are you using?
9.12
Which client are you using? (Command-line, Java API, Maven plugin, Gradle plugin)
Docker Image - flyway/flyway
Which database are you using?
Snowflake 7.2
Which operating system are you using?
Docker Image - flyway/flyway
What did you do?
flyway migrate
What did you expect to see?
Successful migrations
If I revert to Flyway 9.11, I can still successfully perform a migration againts Snowflake 7.2.  It is also successfully when using 9.12 with "jdbc_query_result_format=json" added to the connection string.
What did you see instead?
error	20-Jan-2023 12:32:24	SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder".
error	20-Jan-2023 12:32:24	SLF4J: Defaulting to no-operation (NOP) logger implementation
error	20-Jan-2023 12:32:24	SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further details.
error	20-Jan-2023 12:32:24	Jan 20, 2023 6:32:24 PM net.snowflake.client.jdbc.internal.apache.arrow.memory.BaseAllocator <clinit>
error	20-Jan-2023 12:32:24	INFO: Debug mode disabled.
error	20-Jan-2023 12:32:24	Jan 20, 2023 6:32:24 PM net.snowflake.client.jdbc.internal.apache.arrow.memory.DefaultAllocationManagerOption getDefaultAllocationManagerFactory
error	20-Jan-2023 12:32:24	INFO: allocation manager type not specified, using netty as the default type
error	20-Jan-2023 12:32:24	Jan 20, 2023 6:32:24 PM net.snowflake.client.jdbc.internal.apache.arrow.memory.CheckAllocator reportResult
error	20-Jan-2023 12:32:24	INFO: Using DefaultAllocationManager at memory/DefaultAllocationManagerFactory.class
error	20-Jan-2023 12:32:24	Jan 20, 2023 6:32:24 PM net.snowflake.client.core.SFStatement executeQueryInternal
error	20-Jan-2023 12:32:24	SEVERE: Exception creating result
error	20-Jan-2023 12:32:24	java.lang.ExceptionInInitializerError
error	20-Jan-2023 12:32:24		at net.snowflake.client.jdbc.internal.apache.arrow.memory.UnsafeAllocationManager.<clinit>(UnsafeAllocationManager.java:27)
error	20-Jan-2023 12:32:24		at net.snowflake.client.jdbc.internal.apache.arrow.memory.DefaultAllocationManagerFactory.<clinit>(DefaultAllocationManagerFactory.java:26)
error	20-Jan-2023 12:32:24		at java.base/java.lang.Class.forName0(Native Method)
error	20-Jan-2023 12:32:24		at java.base/java.lang.Class.forName(Unknown Source)
error	20-Jan-2023 12:32:24		at net.snowflake.client.jdbc.internal.apache.arrow.memory.DefaultAllocationManagerOption.getFactory(DefaultAllocationManagerOption.java:111)
error	20-Jan-2023 12:32:24		at net.snowflake.client.jdbc.internal.apache.arrow.memory.DefaultAllocationManagerOption.getDefaultAllocationManagerFactory(DefaultAllocationManagerOption.java:101)
error	20-Jan-2023 12:32:24		at net.snowflake.client.jdbc.internal.apache.arrow.memory.BaseAllocator$Config.getAllocationManagerFactory(BaseAllocator.java:735)
error	20-Jan-2023 12:32:24		at net.snowflake.client.jdbc.internal.apache.arrow.memory.ImmutableConfig.access$801(ImmutableConfig.java:24)
error	20-Jan-2023 12:32:24		at net.snowflake.client.jdbc.internal.apache.arrow.memory.ImmutableConfig$InitShim.getAllocationManagerFactory(ImmutableConfig.java:83)
error	20-Jan-2023 12:32:24		at net.snowflake.client.jdbc.internal.apache.arrow.memory.ImmutableConfig.<init>(ImmutableConfig.java:47)
error	20-Jan-2023 12:32:24		at net.snowflake.client.jdbc.internal.apache.arrow.memory.ImmutableConfig.<init>(ImmutableConfig.java:24)
error	20-Jan-2023 12:32:24		at net.snowflake.client.jdbc.internal.apache.arrow.memory.ImmutableConfig$Builder.build(ImmutableConfig.java:485)
error	20-Jan-2023 12:32:24		at net.snowflake.client.jdbc.internal.apache.arrow.memory.BaseAllocator.<clinit>(BaseAllocator.java:63)
error	20-Jan-2023 12:32:24		at net.snowflake.client.jdbc.SnowflakeResultSetSerializableV1.create(SnowflakeResultSetSerializableV1.java:577)
error	20-Jan-2023 12:32:24		at net.snowflake.client.jdbc.SnowflakeResultSetSerializableV1.create(SnowflakeResultSetSerializableV1.java:489)
error	20-Jan-2023 12:32:24		at net.snowflake.client.core.SFResultSetFactory.getResultSet(SFResultSetFactory.java:29)
error	20-Jan-2023 12:32:24		at net.snowflake.client.core.SFStatement.executeQueryInternal(SFStatement.java:218)
error	20-Jan-2023 12:32:24		at net.snowflake.client.core.SFStatement.executeQuery(SFStatement.java:133)
error	20-Jan-2023 12:32:24		at net.snowflake.client.core.SFStatement.execute(SFStatement.java:746)
error	20-Jan-2023 12:32:24		at net.snowflake.client.core.SFStatement.execute(SFStatement.java:656)
error	20-Jan-2023 12:32:24		at net.snowflake.client.jdbc.SnowflakeStatementV1.executeQueryInternal(SnowflakeStatementV1.java:236)
error	20-Jan-2023 12:32:24		at net.snowflake.client.jdbc.SnowflakePreparedStatementV1.executeQuery(SnowflakePreparedStatementV1.java:118)
error	20-Jan-2023 12:32:24		at org.flywaydb.core.internal.jdbc.JdbcTemplate.queryForString(JdbcTemplate.java:158)
error	20-Jan-2023 12:32:24		at org.flywaydb.core.internal.database.snowflake.SnowflakeConnection.getCurrentSchemaNameOrSearchPath(SnowflakeConnection.java:51)
error	20-Jan-2023 12:32:24		at org.flywaydb.core.internal.database.base.Connection.<init>(Connection.java:49)
error	20-Jan-2023 12:32:24		at org.flywaydb.core.internal.database.snowflake.SnowflakeConnection.<init>(SnowflakeConnection.java:35)
error	20-Jan-2023 12:32:24		at org.flywaydb.core.internal.database.snowflake.SnowflakeDatabase.doGetConnection(SnowflakeDatabase.java:63)
error	20-Jan-2023 12:32:24		at org.flywaydb.core.internal.database.snowflake.SnowflakeDatabase.doGetConnection(SnowflakeDatabase.java:32)
error	20-Jan-2023 12:32:24		at org.flywaydb.core.internal.database.base.Database.getConnection(Database.java:88)
error	20-Jan-2023 12:32:24		at org.flywaydb.core.internal.database.base.Database.getMainConnection(Database.java:280)
error	20-Jan-2023 12:32:24		at org.flywaydb.core.internal.schemahistory.SchemaHistoryFactory.prepareSchemas(SchemaHistoryFactory.java:62)
error	20-Jan-2023 12:32:24		at org.flywaydb.core.FlywayExecutor.execute(FlywayExecutor.java:178)
error	20-Jan-2023 12:32:24		at org.flywaydb.core.Flyway.repair(Flyway.java:320)
error	20-Jan-2023 12:32:24		at org.flywaydb.commandline.Main.executeOperation(Main.java:392)
error	20-Jan-2023 12:32:24		at org.flywaydb.commandline.Main.main(Main.java:146)
error	20-Jan-2023 12:32:24	Caused by: java.lang.RuntimeException: Failed to initialize MemoryUtil.
error	20-Jan-2023 12:32:24		at net.snowflake.client.jdbc.internal.apache.arrow.memory.util.MemoryUtil.<clinit>(MemoryUtil.java:139)
error	20-Jan-2023 12:32:24		... 35 more
error	20-Jan-2023 12:32:24	Caused by: java.lang.reflect.InaccessibleObjectException: Unable to make field long java.nio.Buffer.address accessible: module java.base does not "opens java.nio" to unnamed module @22c6d958
error	20-Jan-2023 12:32:24		at java.base/java.lang.reflect.AccessibleObject.checkCanSetAccessible(Unknown Source)
error	20-Jan-2023 12:32:24		at java.base/java.lang.reflect.AccessibleObject.checkCanSetAccessible(Unknown Source)
error	20-Jan-2023 12:32:24		at java.base/java.lang.reflect.Field.checkCanSetAccessible(Unknown Source)
error	20-Jan-2023 12:32:24		at java.base/java.lang.reflect.Field.setAccessible(Unknown Source)
error	20-Jan-2023 12:32:24		at net.snowflake.client.jdbc.internal.apache.arrow.memory.util.MemoryUtil.<clinit>(MemoryUtil.java:87)
error	20-Jan-2023 12:32:24		... 35 more
error	20-Jan-2023 12:32:24
error	20-Jan-2023 12:32:24	ERROR: Unable to determine the original schema for the connection
error	20-Jan-2023 12:32:24	----------------------------------------------------------
error	20-Jan-2023 12:32:24	SQL State  : XX000
error	20-Jan-2023 12:32:24	Error Code : 200001
error	20-Jan-2023 12:32:24	Message    : JDBC driver internal error: exception creating result java.lang.ExceptionInInitializerError at net.snowflake.client.jdbc.internal.apache.arrow.memory.UnsafeAllocationManager.<clinit>(UnsafeAllocationManager.java:27).
error	20-Jan-2023 12:32:24
error	20-Jan-2023 12:32:24	Caused by: net.snowflake.client.jdbc.SnowflakeSQLException: JDBC driver internal error: exception creating result java.lang.ExceptionInInitializerError at net.snowflake.client.jdbc.internal.apache.arrow.memory.UnsafeAllocationManager.<clinit>(UnsafeAllocationManager.java:27).
error	20-Jan-2023 12:32:25	Exit code: 1, output: STDERR: 	at org.flywaydb.commandline.Main.executeOperation(Main.java:392)STDERR: 	at org.flywaydb.commandline.Main.main(Main.java:146)STDERR: Caused by: java.lang.RuntimeException: Failed to initialize MemoryUtil.STDERR: 	at net.snowflake.client.jdbc.internal.apache.arrow.memory.util.MemoryUtil.<clinit>(MemoryUtil.java:139)STDERR: 	... 35 moreSTDERR: Caused by: java.lang.reflect.InaccessibleObjectException: Unable to make field long java.nio.Buffer.address accessible: module java.base does not "opens java.nio" to unnamed module @22c6d958STDERR: 	at java.base/java.lang.reflect.AccessibleObject.checkCanSetAccessible(Unknown Source)STDERR: 	at java.base/java.lang.reflect.AccessibleObject.checkCanSetAccessible(Unknown Source)STDERR: 	at java.base/java.lang.reflect.Field.checkCanSetAccessible(Unknown Source)STDERR: 	at java.base/java.lang.reflect.Field.setAccessible(Unknown Source)STDERR: 	at net.snowflake.client.jdbc.internal.apache.arrow.memory.util.MemoryUtil.<clinit>(MemoryUtil.java:87)STDERR: 	... 35 moreSTDERR: STDERR: ERROR: Unable to determine the original schema for the connectionSTDERR: ----------------------------------------------------------STDERR: SQL State  : XX000STDERR: Error Code : 200001STDERR: Message    : JDBC driver internal error: exception creating result java.lang.ExceptionInInitializerError at net.snowflake.client.jdbc.internal.apache.arrow.memory.UnsafeAllocationManager.<clinit>(UnsafeAllocationManager.java:27).STDERR: STDERR: Caused by: net.snowflake.client.jdbc.SnowflakeSQLException: JDBC driver internal error: exception creating result java.lang.ExceptionInInitializerError at net.snowflake.client.jdbc.internal.apache.arrow.memory.UnsafeAllocationManager.<clinit>(UnsafeAllocationManager.java:27).

This is a known issue with the Snowflake JDBC driver to do with compatibility with Java 17, and we have recently updated to support both Java 8 and 17 as we move to 17 only
We can update the driver once a fix is available but your workaround is completely valid, so closing for now

authors: DoodleBobBuffPants EMCINS

repo: flyway/flyway


text:
🛑 Contaboo is down

In e569744, Contaboo (https://contabo.com) was down:

HTTP code: 403
Response time: 432 ms

Resolved: Contaboo is back up in d229437 after 1 hour.

repo: fnzv/status


text:
🛑 Contaboo is down

In e69fc84, Contaboo (https://contabo.com) was down:

HTTP code: 403
Response time: 442 ms

Resolved: Contaboo is back up in a9fda64 after 7 hours, 23 minutes.


text:
🛑 Contaboo is down

In aae5ac1, Contaboo (https://contabo.com) was down:

HTTP code: 403
Response time: 2949 ms

Resolved: Contaboo is back up in 6a34357 after 2 hours, 21 minutes.


text:
Session Expiry

Added isExpired method to Session model. Added checking of expiry to SessionServerBox
Fixes: https://github.com/nanoPayinc/NANOPAY/issues/2064

The cron job runs every minute to remove expired sessions, so this isn't necessary.

authors: eatonk kgrgreer


text:
DO NOT MERGE: ExpressionSlot fallback to context

Allow ExpressionSlot to fallback onto the context it was created in and make the Section's createIsAvailableFor's ExpressionSlot use the context that's passed in. With this, the isAvailable for SectionAxioms can use things like controllerMode in their expression.

Chatted about this and we both agree it's not a good avenue to go down.