text:
Passwords holding "!" will trigger history expansion

cmd://bash -c 'FILE=$(mktemp) && chmod 600 $FILE && echo {PASSWORD} > $FILE ; xterm -e sshpass -f $FILE ssh -o StrictHostKeyChecking=no {USERNAME}@{BASE:RMVSCM}; rm -f $FILE'

Wont work if Password contains "!" as "!" will trigger history expansion.

You have to single quote the string: echo \'{PASSWORD}\' > $FILE
But I would recommend to use the sshpass environment method instead:
cmd://bash -c 'xterm -e SSHPASS=\'{PASSWORD}\' sshpass -e ssh -o ...'

On Thu, Feb 20, 2020 at 7:44 PM Zadkiel notifications@github.com wrote:

You have to single quote the string: echo '{PASSWORD}' > $FILE
But I would recommend to use the sshpass environment method instead:
cmd://bash -c 'xterm -e SSHPASS='{PASSWORD}' sshpass -e ssh -o ...'

This should work:
cmd://bash -c 'SSHPASS='{PASSWORD}' cssh --user={USERNAME} {BASE:RMVSCM}'
leads to "File not found", because bash tries to find
"SSHPASS='abc!abc!$abc!xyz' cssh --user=user host" which, for sure, isn't
a commands name within PATH. Indeed using " (double quote) instead of '
(single quote) will work, but lead to interpreting $abc within {PASSWORD}
as an expandable variable:
URL-Overwrite:
cmd://bash -c "SSHPASS='{PASSWORD}' cssh --user={USERNAME} {BASE:RMVSCM}"
is handled to system as:
bash -c "SSHPASS='abc!abc!$abc!xyz' cssh --user=user host"
Since bash is used to handle the given command (it is the users default
shell), expansion leads to ($abc is not defined):
bash -c "SSHPASS='abc!abc!!xyz' cssh --user=user host"
Next step:
SSHPASS='abc!abc!!xyz' cssh --user=user host
The shell defines variable SSHPASS, then calls cssh:
SSHPASS=abc!abc!!xyz
cssh --user=user host
cssh is a simple script opening an xterm, defining colors at users will,
then looking if $SSHPASS is defined and if calling ssh:
sshpass -e ssh -l user host
This will fail, since "abc!abc!!xyz" is not the needed password
"abc!abc!$abc!xyz".
I've tried both: single quotes, within url-overwrite: these lead to "file
not found" and double quotes they lead to expansions if passwords hold
"$"-signs.
I've tried to escape this would not help either, because I would have to
escape the "$"-signs within the password. Which I can't do, because I am to
late -- bash is already running at this point and has expanded variables as
possible.
What we need is something that puts the password without any changes into
an environment variable SSHPASS leaving bash or others no chance to change
anything. Ideally this could be done by keepass2 itself.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/kvaps/keepass-url-overrides/issues/3?email_source=notifications&email_token=AAFLNTEARPUWMJB5TUIUL7DRD3FPTA5CNFSM4KYLVGAKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEMPTBOI#issuecomment-589246649,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAFLNTG6AODSL7ORYXLHWNTRD3FPTANCNFSM4KYLVGAA
.

--
Thomas

for bash or sh as your primary shell you can use:
cmd://bash -c "SSHPASS='{PASSWORD}' cssh --user={USERNAME} {BASE:RMVSCM}"
But with zsh this wont work again ...!
With this again: it would be nice to have keepass set an environment
variable filled with the password, independent of any shell interpretation
(same for user and hostname) Maybe something like {PASSWORD=SSHPASS}
({USERNAME=USER}, {BASE:RMVSCM=HOST}) or fields assigned to environment
variables, filled with whatever the user thinks has to go there (may be
quite simple named var1, var2, var3, ..., varN)?
On Mon, Feb 24, 2020 at 1:00 PM Thomas Schweikle tschweikle@gmail.com
wrote:

On Thu, Feb 20, 2020 at 7:44 PM Zadkiel notifications@github.com wrote:

You have to single quote the string: echo '{PASSWORD}' > $FILE
But I would recommend to use the sshpass environment method instead:
cmd://bash -c 'xterm -e SSHPASS='{PASSWORD}' sshpass -e ssh -o ...'

This should work:
cmd://bash -c 'SSHPASS='{PASSWORD}' cssh --user={USERNAME} {BASE:RMVSCM}'
leads to "File not found", because bash tries to find
"SSHPASS='abc!abc!$abc!xyz' cssh --user=user host" which, for sure, isn't
a commands name within PATH. Indeed using " (double quote) instead of '
(single quote) will work, but lead to interpreting $abc within {PASSWORD}
as an expandable variable:
URL-Overwrite:
cmd://bash -c "SSHPASS='{PASSWORD}' cssh --user={USERNAME} {BASE:RMVSCM}"
is handled to system as:
bash -c "SSHPASS='abc!abc!$abc!xyz' cssh --user=user host"
Since bash is used to handle the given command (it is the users default
shell), expansion leads to ($abc is not defined):
bash -c "SSHPASS='abc!abc!!xyz' cssh --user=user host"
Next step:
SSHPASS='abc!abc!!xyz' cssh --user=user host
The shell defines variable SSHPASS, then calls cssh:
SSHPASS=abc!abc!!xyz
cssh --user=user host
cssh is a simple script opening an xterm, defining colors at users will,
then looking if $SSHPASS is defined and if calling ssh:
sshpass -e ssh -l user host
This will fail, since "abc!abc!!xyz" is not the needed password
"abc!abc!$abc!xyz".
I've tried both: single quotes, within url-overwrite: these lead to "file
not found" and double quotes they lead to expansions if passwords hold
"$"-signs.
I've tried to escape this would not help either, because I would have to
escape the "$"-signs within the password. Which I can't do, because I am to
late -- bash is already running at this point and has expanded variables as
possible.
What we need is something that puts the password without any changes into
an environment variable SSHPASS leaving bash or others no chance to change
anything. Ideally this could be done by keepass2 itself.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/kvaps/keepass-url-overrides/issues/3?email_source=notifications&email_token=AAFLNTEARPUWMJB5TUIUL7DRD3FPTA5CNFSM4KYLVGAKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEMPTBOI#issuecomment-589246649,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAFLNTG6AODSL7ORYXLHWNTRD3FPTANCNFSM4KYLVGAA
.

--
Thomas

--
Thomas

repo: kvaps/keepass-url-overrides


text:
Cannot run DeepSeek V2 Chat in server mode on 2 GPUs

I have 2x RTX 3090. I've built ktransformers from source (needed to install some missing packages, but it worked in the end).
When I run local_chat with
python -m ktransformers.local_chat --model_path deepseek-ai/DeepSeek-V2-Chat-0628 --gguf_path ~/.cache/lm-studio/models/bartowski/DeepSeek-V2-Chat-0628-GGUF --optimize_rule_path ./build/lib.linux-x86_64-cpython-312/ktransformers/optimize/optimize_rules/DeepSeek-V2-Chat-multi-gpu.yaml

in-console chat works, I get 9 tps, more than llama.cpp out-of-the-box 7.5 tps.
I didn't find a way to pass multi-gpu optimization rule to ktransformers server, as --optimize_config_path OPTIMIZE_CONFIG_PATH option seems to be not about that. So I just replaced default file with multi-gpu version. The I run
ktransformers --model_path deepseek-ai/DeepSeek-V2-Chat-0628 --gguf_path ~/.cache/lm-studio/models/bartowski/DeepSeek-V2-Chat-0628-GGUF --port 1234

I get this error (in the end it says Expected all tensors to be on the same device, but found at least two devices, cuda:0 and cuda:1!).
Should I also change ktransformers/configs/config.yaml ? How? Is the problem that only cuda:0 is mentioned in config? But right when the server starts it seems to read optimize rule right - it split 0-29, 30-59 layers bettween GPUs:
...
loading blk.29.attn_norm.weight to cuda:0
loading blk.29.ffn_norm.weight to cuda:0
loading blk.30.attn_q_a.weight to cuda:1
loading blk.30.attn_q_a_norm.weight to cuda:1
...

The error:
INFO:     192.168.27.159:46148 - "OPTIONS /v1/chat/completions HTTP/1.1" 200 OK
2024-08-20 19:03:00,415 WARNING /home/ai/miniconda3/envs/ktransformers/lib/python3.11/site-packages/ktransformers/server/backend/interfaces/transformers.py[161]: change system to user
2024-08-20 19:03:00,415 WARNING /home/ai/miniconda3/envs/ktransformers/lib/python3.11/site-packages/ktransformers/server/backend/interfaces/transformers.py[167]: merge two adjacent user messages
2024-08-20 19:03:00,461 DEBUG /home/ai/miniconda3/envs/ktransformers/lib/python3.11/site-packages/ktransformers/server/backend/interfaces/transformers.py[185]: get input ids of shape torch.Size([1, 18])
2024-08-20 19:03:00,461 DEBUG /home/ai/miniconda3/envs/ktransformers/lib/python3.11/site-packages/ktransformers/server/backend/interfaces/transformers.py[240]: input_ids: torch.Size([1, 18])
2024-08-20 19:03:00,462 DEBUG /home/ai/miniconda3/envs/ktransformers/lib/python3.11/site-packages/ktransformers/server/backend/interfaces/transformers.py[262]: cache position: 0 to 18
INFO:     192.168.27.159:46148 - "POST /v1/chat/completions HTTP/1.1" 500 Internal Server Error
ERROR:    Exception in ASGI application
Traceback (most recent call last):
  File "/home/ai/miniconda3/envs/ktransformers/lib/python3.11/site-packages/uvicorn/protocols/http/h11_impl.py", line 406, in run_asgi
    result = await app(  # type: ignore[func-returns-value]
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/ai/miniconda3/envs/ktransformers/lib/python3.11/site-packages/uvicorn/middleware/proxy_headers.py", line 70, in __call__
    return await self.app(scope, receive, send)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/ai/miniconda3/envs/ktransformers/lib/python3.11/site-packages/fastapi/applications.py", line 1054, in __call__
    await super().__call__(scope, receive, send)
  File "/home/ai/miniconda3/envs/ktransformers/lib/python3.11/site-packages/starlette/applications.py", line 123, in __call__
    await self.middleware_stack(scope, receive, send)
  File "/home/ai/miniconda3/envs/ktransformers/lib/python3.11/site-packages/starlette/middleware/errors.py", line 186, in __call__
    raise exc
  File "/home/ai/miniconda3/envs/ktransformers/lib/python3.11/site-packages/starlette/middleware/errors.py", line 164, in __call__
    await self.app(scope, receive, _send)
  File "/home/ai/miniconda3/envs/ktransformers/lib/python3.11/site-packages/starlette/middleware/cors.py", line 93, in __call__
    await self.simple_response(scope, receive, send, request_headers=headers)
  File "/home/ai/miniconda3/envs/ktransformers/lib/python3.11/site-packages/starlette/middleware/cors.py", line 148, in simple_response
    await self.app(scope, receive, send)
  File "/home/ai/miniconda3/envs/ktransformers/lib/python3.11/site-packages/starlette/middleware/exceptions.py", line 65, in __call__
    await wrap_app_handling_exceptions(self.app, conn)(scope, receive, send)
  File "/home/ai/miniconda3/envs/ktransformers/lib/python3.11/site-packages/starlette/_exception_handler.py", line 64, in wrapped_app
    raise exc
  File "/home/ai/miniconda3/envs/ktransformers/lib/python3.11/site-packages/starlette/_exception_handler.py", line 53, in wrapped_app
    await app(scope, receive, sender)
  File "/home/ai/miniconda3/envs/ktransformers/lib/python3.11/site-packages/starlette/routing.py", line 756, in __call__
    await self.middleware_stack(scope, receive, send)
  File "/home/ai/miniconda3/envs/ktransformers/lib/python3.11/site-packages/starlette/routing.py", line 776, in app
    await route.handle(scope, receive, send)
  File "/home/ai/miniconda3/envs/ktransformers/lib/python3.11/site-packages/starlette/routing.py", line 297, in handle
    await self.app(scope, receive, send)
  File "/home/ai/miniconda3/envs/ktransformers/lib/python3.11/site-packages/starlette/routing.py", line 77, in app
    await wrap_app_handling_exceptions(app, request)(scope, receive, send)
  File "/home/ai/miniconda3/envs/ktransformers/lib/python3.11/site-packages/starlette/_exception_handler.py", line 64, in wrapped_app
    raise exc
  File "/home/ai/miniconda3/envs/ktransformers/lib/python3.11/site-packages/starlette/_exception_handler.py", line 53, in wrapped_app
    await app(scope, receive, sender)
  File "/home/ai/miniconda3/envs/ktransformers/lib/python3.11/site-packages/starlette/routing.py", line 72, in app
    response = await func(request)
               ^^^^^^^^^^^^^^^^^^^
  File "/home/ai/miniconda3/envs/ktransformers/lib/python3.11/site-packages/fastapi/routing.py", line 278, in app
    raw_response = await run_endpoint_function(
                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/ai/miniconda3/envs/ktransformers/lib/python3.11/site-packages/fastapi/routing.py", line 191, in run_endpoint_function
    return await dependant.call(**values)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/ai/miniconda3/envs/ktransformers/lib/python3.11/site-packages/ktransformers/server/api/openai/endpoints/chat.py", line 32, in chat_completion
    async for token in interface.inference(input_message,id):
  File "/home/ai/miniconda3/envs/ktransformers/lib/python3.11/site-packages/ktransformers/server/backend/interfaces/transformers.py", line 323, in inference
    for t in self.prefill(input_ids,self.check_is_new(thread_id)):
  File "/home/ai/miniconda3/envs/ktransformers/lib/python3.11/site-packages/torch/utils/_contextlib.py", line 36, in generator_context
    response = gen.send(None)
               ^^^^^^^^^^^^^^
  File "/home/ai/miniconda3/envs/ktransformers/lib/python3.11/site-packages/ktransformers/server/backend/interfaces/transformers.py", line 272, in prefill
    logits = self.model(
             ^^^^^^^^^^^
  File "/home/ai/miniconda3/envs/ktransformers/lib/python3.11/site-packages/torch/nn/modules/module.py", line 1553, in _wrapped_call_impl
    return self._call_impl(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/ai/miniconda3/envs/ktransformers/lib/python3.11/site-packages/torch/nn/modules/module.py", line 1562, in _call_impl
    return forward_call(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/ai/miniconda3/envs/ktransformers/lib/python3.11/site-packages/ktransformers/models/modeling_deepseek.py", line 1731, in forward
    outputs = self.model(
              ^^^^^^^^^^^
  File "/home/ai/miniconda3/envs/ktransformers/lib/python3.11/site-packages/torch/nn/modules/module.py", line 1553, in _wrapped_call_impl
    return self._call_impl(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/ai/miniconda3/envs/ktransformers/lib/python3.11/site-packages/torch/nn/modules/module.py", line 1562, in _call_impl
    return forward_call(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/ai/miniconda3/envs/ktransformers/lib/python3.11/site-packages/ktransformers/operators/models.py", line 613, in forward
    layer_outputs = decoder_layer(
                    ^^^^^^^^^^^^^^
  File "/home/ai/miniconda3/envs/ktransformers/lib/python3.11/site-packages/torch/nn/modules/module.py", line 1553, in _wrapped_call_impl
    return self._call_impl(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/ai/miniconda3/envs/ktransformers/lib/python3.11/site-packages/torch/nn/modules/module.py", line 1562, in _call_impl
    return forward_call(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/ai/miniconda3/envs/ktransformers/lib/python3.11/site-packages/ktransformers/models/modeling_deepseek.py", line 1238, in forward
    hidden_states, self_attn_weights, present_key_value = self.self_attn(
                                                          ^^^^^^^^^^^^^^^
  File "/home/ai/miniconda3/envs/ktransformers/lib/python3.11/site-packages/torch/nn/modules/module.py", line 1553, in _wrapped_call_impl
    return self._call_impl(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/ai/miniconda3/envs/ktransformers/lib/python3.11/site-packages/torch/nn/modules/module.py", line 1562, in _call_impl
    return forward_call(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/ai/miniconda3/envs/ktransformers/lib/python3.11/site-packages/ktransformers/operators/attention.py", line 163, in forward
    return self.forward_chunck(
           ^^^^^^^^^^^^^^^^^^^^
  File "/home/ai/miniconda3/envs/ktransformers/lib/python3.11/site-packages/ktransformers/operators/attention.py", line 92, in forward_chunck
    k_pe, compressed_kv = past_key_value.update(k_pe, compressed_kv, self.layer_idx, cache_kwargs)
                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/ai/miniconda3/envs/ktransformers/lib/python3.11/site-packages/ktransformers/models/custom_cache.py", line 105, in update
    k_out[:, :, cache_position] = key_states
    ~~~~~^^^^^^^^^^^^^^^^^^^^^^
RuntimeError: Expected all tensors to be on the same device, but found at least two devices, cuda:0 and cuda:1!

You can appoint optimise yaml rule by --optimize_config_path now. I have fixed by #48 .

Expected all tensors to be on the same device
Ok this is a bug that server creating static cache on one device. Also fixed by #48 .

source: gharchive/issue

authors: Azure-Tang ELigoP

repo: kvcache-ai/ktransformers

license_type: permissive

license_source: github-api


text:
Enhanced scroll back button with timeline on it for smoother functioning.

Enhanced scroll back button with timeline on it for smoother functioning.

Yep...this seems nice...but choose the color gradient that is suitable for the website

@kvcops Okay

Ok...be waiting for your pr..

@kvcops Done.
https://github.com/kvcops/KV-Nexus/pull/72

Thank you @shriyadindi  :)

authors: kvcops shriyadindi

repo: kvcops/KV-Nexus

license: MIT


text:
Timezone Support - Mismatch from UTC and Local Timezone in frontend?

An example shown above.
This was a query that was just logged. Looks like the date/time in the database/backend is in UTC, but the front-end seems to be doing the 'difference' calculation using the browsers local time. (In this case, I'm in Australia, so a timezone of +10)
Wouldn't hurt to show the actual time, rather than just the 'hours ago', and in this case, I don't think any issue in just showing " UTC" after the time/date, without having to go to the trouble of implementing the whole "timezone support"
Very minor one, not a show stopper by any means :)

I've opened a Pull Request with this change timeSince() calculates in UTC, and added the timestamp (in UTC) as a title tag/hover for the offset display in the frontend.

repo: kviklet/kviklet


text:
http_auth_ldap: Message with unknown ID received, ignoring.

Getting timeout after hanging for couple of minutes.
2016/08/03 06:25:45 [debug] 31129#0: http_auth_ldap: ldap_result() -> rc=97, msgid=8, msgtype=97
2016/08/03 06:25:45 [debug] 31129#0: http_auth_ldap: Message with unknown ID received, ignoring.
error-github.txt

NGINX.CONF ...
worker_processes  1;
error_log  logs/error.log debug;
events {
worker_connections  1024;
}
http {
ldap_server nod {
url ldaps://HQDC1.xxxx.com:636/dc=xxxx,dc=com?sAMAccountName?sub?(objectClass=user);
basedn "cn=users,dc=xxxx,dc=com";
binddn "dala@xxxx.com";
binddn_passwd "Cxxxxxxxxxxxxxx";
require valid_user;
satisfy any;
connections 50;
}
auth_ldap_cache_enabled on;
auth_ldap_cache_expiration_time 10000;
auth_ldap_cache_size 10000;
include       mime.types;
default_type  application/octet-stream;
error_log  logs/error.log debug;
sendfile        on;

keepalive_timeout  65;

server {
    listen       80;
    server_name  localhost;
    auth_ldap "Forbidden";
    auth_ldap_servers nod;

    location / {
       root   html;
       index  index.html index.htm;
    }

    error_page   500 502 503 504  /50x.html;
    location = /50x.html {
        root   html;
    }

}

}

Never Mind, it is fixed.
It was a setting in ldap.conf did the magic.
REFERRALS off

repo: kvspb/nginx-auth-ldap


text:
Interactive Layers depending on another Interactive Layers observable throw error at start up

When using <lflt-interactive-layers [observable]="main">, the following error occured:
core.js:6241 ERROR TypeError: Cannot read property 'interactiveLayerDirectivesQueryList' of undefined
    at LeafletInteractiveObserverLayersDirective.get interactiveLayerDirectives [as interactiveLayerDirectives] (lflt-core.js:486)
    at LeafletInteractiveObserverLayersDirective.get areLayersReady [as areLayersReady] (lflt-core.js:316)
    at LeafletInteractiveObserverLayersDirective.ngAfterViewChecked (lflt-core.js:489)
    at callHook (core.js:4730)
    at callHooks (core.js:4690)
    at executeInitAndCheckHooks (core.js:4630)
    at refreshView (core.js:12088)
    at refreshEmbeddedViews (core.js:13404)
    at refreshView (core.js:12035)
    at refreshComponent (core.js:13458)

Most likely caused by observable haven't been any value:
https://github.com/kygoh/lflt-core/blob/23f1e6f9a0edd8f8e5e8698ebb39b266ac953caa/projects/lflt-core/src/lib/directives/leaflet-interactive-layers.directive.ts#L272-L276

Most likely caused by observable hasn't been assigned any value because the parent directive has not been instantiated:

This is caused by <lflt-map *ngIf="isViewReady"> which was used to prevent map container having width and height 0 on start up.
To avoid this problem, directive that can be assigned to a variable must not be conditionally rendered.

Going back to the drawing boards to figure out how to "wait" for map container to have the correct size before starting.

From Handle Template Reference Variables with Directives blog:

(Note that if you use an  or a structural directive like *ngIf or *ngFor it creates a new template scope and template reference variables declared inside will not be available for use outside.)

Going back to the drawing boards to figure out how to "wait" for map container to have the correct size before starting.

Raised as #3

repo: kygoh/lflt-core


text:
Specify path width

Ex. the width of a river
This could be shown on the radar compass to convey how wide the path is.
I'm not sure if I will implement this, more research is needed.

Makes me think that (for trails) other properties might be useful; such as difficulty / quality metrics. Width being merely one of them.
I'm imagining hiking trails visited infrequently, and a user forgetting the differences. In the mind of the user, what they ultimately want is a reminder of which path they prefer.

The path tool already displays the difficulty and quality metrics - could you provide a specific example of what you would like added?
That sort of sounds like they should be able to provide a comment (like the beacon tool allows), here's a new issue to track that: https://github.com/kylecorry31/Trail-Sense/issues/1191

The path tool already displays the difficulty and quality metrics — could you provide a specific example of what you would like added?

Ah, my mistake for not checking / testing. More tinkering (on my part) needed.
Sounds like my imagined use-case is already covered.

That sort of sounds like they should be able to provide a comment (like the beacon tool allows), here's a new issue to track that: #1191

Interesting; far more generic & adaptable. 👍


text:
Swift 4 api change.

Minor swift 4 api change with conditional runtime check.

Can we have this merged?

Merged this in via bbe7413 and fixing the indentation. Thanks for PR @m4rkk. This is released in 2.0.2.

source: gharchive/pull-request

authors: kylef m4rkk nyekimov

license: mit

license_source: bigquery


text:
ovpn_run "Exited (1)" (Fedora 22, Docker 1.8)

Hello,
WIth a digital ocean vps, i got the following issue:
a01efde49a1b        kylemanna/openvpn   "ovpn_run"          3 minutes ago       Exited (1) 3 minutes ago                       determined_banach

I just followed the steps (as the last time I installed this docker).
configuration: Fedora 22, Docker version 1.8.2-fc22, build f1db8f2/1.8.2
logs:
root@whatweare /h/# docker logs 64db0e83fb1a
iptables: No chain/target/match by that name.
iptables: No chain/target/match by that name.
Enabling IPv6 Forwarding
sysctl: setting key "net.ipv6.conf.default.forwarding": Read-only file system
Failed to enable IPv6 Forwarding default
sysctl: setting key "net.ipv6.conf.all.forwarding": Read-only file system
Failed to enable IPv6 Forwarding
Sun Sep 27 00:24:50 2015 OpenVPN 2.3.4 x86_64-pc-linux-gnu [SSL (OpenSSL)] [LZO] [EPOLL] [PKCS11] [MH] [IPv6] built on Dec  1 2014
Sun Sep 27 00:24:50 2015 library versions: OpenSSL 1.0.1k 8 Jan 2015, LZO 2.08
Sun Sep 27 00:24:50 2015 Diffie-Hellman initialized with 2048 bit key
Sun Sep 27 00:24:50 2015 Control Channel Authentication: using '/etc/openvpn/pki/ta.key' as a OpenVPN static key file
Sun Sep 27 00:24:50 2015 Outgoing Control Channel Authentication: Using 160 bit message hash 'SHA1' for HMAC authentication
Sun Sep 27 00:24:50 2015 Incoming Control Channel Authentication: Using 160 bit message hash 'SHA1' for HMAC authentication
Sun Sep 27 00:24:50 2015 Socket Buffers: R=[212992->131072] S=[212992->131072]
Sun Sep 27 00:24:50 2015 ROUTE_GATEWAY XXXX/255.255.0.0 IFACE=eth0 HWADDR=02:42:ac:11:00:16
Sun Sep 27 00:24:50 2015 ERROR: Cannot open TUN/TAP dev /dev/net/tun: No such device (errno=19)
Sun Sep 27 00:24:50 2015 Exiting due to fatal error

After installing openvpn out of the docker, restarting and restart the docker, it worked.

repo: kylemanna/docker-openvpn


text:
Release candidate tag set to latest release

Description
Changes proposed in this pull request:

In security configuration file we set release candidate tag to latest released version, to let scanner scan this before it is promoted

Related issue(s)

/test pull-btp-manager-module-build

/unhold

authors: MarekMichali jaroslaw-pieszka

repo: kyma-project/btp-manager


text:
Add tooltip for service account download kubeconfig button

Description
Changes proposed in this pull request:

Add tooltip for service account download kubeconfig button

Related issue(s)

/retest

repo: kyma-project/busola


text:
Sort-List-Dialog closes now after sorting

Description
Changes proposed in this pull request:

Sort-List-Dialog closes now after sorting

Related issue(s)

/retest

/retest


text:
KEB AvS Maintenance Mode config

Description
Changes proposed in this pull request:

extend AvS config with fields and logic for maintenance mode,
enhance KEB steps where AvS evaluations are set to maintenance,
add unit tests,
add AvS maintenance mode config to KEB's chart.

Related issue(s)

See #3008

/hold

/unhold

/hold

/unhold

repo: kyma-project/control-plane


text:
Renaming

Description
Related issue(s)
https://github.com/kyma-project/keda-manager/issues/7

/retest

/retest

/test pull-keda-module-build

/test all

/test pre-main-keda-manager-verify

/retest

authors: Cortey jakobmoellersap m00g3n

repo: kyma-project/keda-manager


text:
SAKORA モジュールを追加

git submodule で追加しましたので，以下の事項に注意する必要があります:

clone する際は，--recursive オプションをつける

$ git clone https://github.com/kyoto-u/openpanda --recursive

新しいサブモジュールが追加された

$ git submodule update --inint

サブモジュールが使用しているバージョンの確認

$ git submodule status

サブモジュールの最新情報を取得

$ git submodule foreach git fetch

サブモジュールのリビジョンを変える

$ cd sub-module; .....; cd ..; git commit -a

See also https://www.m3tech.blog/entry/git-submodule

すべて push しました．git pull する際，以下の要領で submodule で追加したリポジトリをとってきて下さい

git submodule update --init --recursive

repo: kyoto-u/openpanda


text:
🛑 senoshaidodelasmanos.bogach.es is down

In 1b02140, senoshaidodelasmanos.bogach.es (https://senoshaidodelasmanos.bogach.es/) was down:

HTTP code: 0
Response time: 0 ms

Resolved: senoshaidodelasmanos.bogach.es is back up in 52c299d after 19 minutes.

repo: kyryl-bogach/upptime


text:
🛑 senoshaidodelasmanos.love is down

In 79c044c, senoshaidodelasmanos.love (https://senoshaidodelasmanos.love) was down:

HTTP code: 0
Response time: 0 ms

Resolved: senoshaidodelasmanos.love is back up in 0862cd0 after 572 days, 2 hours, 4 minutes.


text:
🛑 senoshaidodelasmanos.love is down

In 7759f6f, senoshaidodelasmanos.love (https://senoshaidodelasmanos.love) was down:

HTTP code: 0
Response time: 0 ms

Resolved: senoshaidodelasmanos.love is back up in 76e5a23 after 17 minutes.


text:
Make mssql testable using apple silicon.

Hey 👋
The current docker setup doesn't seem to work on Apple silicon (e.g. M3 chips).

I think you need to enable Rosetta emulation in Docker for this to work.

Thanks!
They moved it to:

@igalklebanov did you get a Mac? 😋

Been using macs at work for a few years now. But only Intel chips. Now they gave me an M3. 🤓

Welcome to the world of not-useless-battery-life!

authors: MarkusWendorf igalklebanov koskimas

repo: kysely-org/kysely


text:
INT telemetry NApp v1 implementation placeholder

INT NApp v1 implementation placeholder.
This placeholder will be replaced when more specific tasks of blueprint EP31 gets mapped as issues and implemented.
@jab1982 I'll go ahead and assign this to you, feel free to start breaking down implementation tasks as you think it's suitable to be delivered and reviewed.

Once we have a new repo for the telemetry NApp feel free to map the issues there, I initially created here this placeholder to show up on 2023.1 filters.

The tasks have been broken down into this epic epic_telemetry_int_v1, so I'll go ahead and close this old issue that was just a placeholer.

repo: kytos-ng/kytos


text:
🛑 Korone is down

In a84cc69, Korone (korone.kyun.host) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Korone is back up in fb21678 after 88 days, 2 hours, 21 minutes.

repo: kyundothost/status


text:
my first PR assignment

hope I am doing this right

You did great! Thanks for the pull request. Don't forget to mark your assignment as "done" at https://pullrequest.club/my-assignment.

@kyzn is there a way we can request a new assignment, I'm super excited about getting started. Also, has anyone else signed up?

@estrabd currently that's not possible on site. I give out assignments by hand 1st day of each month.
Also you can get one assignment per month (not set in stone, but never gave out 2 per month, not sure what would go wrong if I did).
However: Since you seem excited, I can send you your July assignment early, if that sounds good to you :slightly_smiling_face:

authors: estrabd kyzn

repo: kyzn/welcome-to-prc


text:
readme additions: setup, branch_coverage, gitignore

Addresses issue #83 by adding instructions to the readme about using enable_coverage :branch

Generally adds configuration section to setup section

Updates github actions to v3 and adds required path: setting for upload/download.

Adds an implementation strategy:
Stop .gitignore-ing the .resultset.json file so it persists on the base branch. Then use this file instead of having to build a container and re-run the test suite on the base branch.

No interest, no activity.

repo: kzkn/simplecov-resultset-diff-action


text:
Add code coverage to CI/CD with reporting

Let's aim to do this first in the many-rs repo.

Rust 1.60 added support for Source-based Code Coverage.
See

https://blog.rust-lang.org/2022/04/07/Rust-1.60.0.html#source-based-code-coverage
https://doc.rust-lang.org/rustc/instrument-coverage.html

and more especially

https://doc.rust-lang.org/rustc/instrument-coverage.html#test-coverage

Fixed by #46

authors: fmorency hansl


text:
Add ability to track data fields

This patch introduces a new function called trackWithDataFields.
In order to be backwards compatible with existing SDK users, I added a new function.
This gives sdk users the ability to add extra data to tracked events.

I know there is another PR open for this but it seems dead. This is required by my project, so I figured I would add it in. Looking forward to feedback/integration. Thanks

Standby for changes

@danielgomezrico @cdmunoz I have made the changes discussed above

🚀 Awesome, thanks for the effort
@chillbrodev can you check the unit tests that are failing?

Oh sure thing, sorry its the week before the holiday break so been trying to cram in work. Missed the tests. Standby for a change

repo: la-haus/iterable-flutter


text:
[Bug] Ingress controller app was pending because worker nodes have been tainted.

Description
Hi @MonolithProjects.
When I added key:value in node_taints["key1:value1","key2:value2"] variable and set rke2_server_taint: true, the Ingress controller app was pending because worker nodes have been tainted.
As I see it that task is always true with "when: rke2_type == 'agent' or not rke2_server_taint" condition if we add one or more values in node_taints[] variable. So, in my opinion, we should choose a suitable condition or remove that task. Because most worker nodes will not set taints

Type of change

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update
[ ] Small minor change not affecting the Ansible Role code (Github Actions Workflow, Documentation etc.)

How Has This Been Tested?
Tested. I have tested been with this bug on High Availability ( 03 masters and 02 workers)

Hi @DungT9x, you don't need to remove these tasks. Set node_taints variable only in group vars (or host vars) for your rke2 servers if you don't want to taint the agents.

Hi @DungT9x, you don't need to remove these tasks. Set node_taints variable only in group vars (or host vars) for your rke2 servers if you don't want to taint the agents.

Thank bro.


text:
bugfix: fix sudo -E bash -c '$cmd' with cmd that contains single quotations

this is a bug fix for https://github.com/labring/sealos/issues/4424 ,
the cmd of metrics-server in cluster's yaml has a signle quotation ' in --set args='{--kubelet-insecure-tls=true,--kubelet-preferred-address-types=InternalIP}', which will cause a problem with the single quotation in sudo -E /bin/bash -c '$cmd'
- cmd:
    - helm upgrade -i metrics-server charts/metrics-server -n kube-system --set args='{--kubelet-insecure-tls=true,--kubelet-preferred-address-types=InternalIP}'
    imageName: registry.cn-shanghai.aliyuncs.com/labring/metrics-server:v0.6.4
    labels:
      io.buildah.version: 1.30.0
    mountPoint: /var/lib/containers/storage/overlay/e080cdaa0e7b16bd43e9635a8079538ee1b891aa2838c5ccf31b0ce191fe2cc0/merged
    name: default-ggcfdsaf
    type: application

if we find a cmd to wrap that contains single quotations, we can replace it with double quotations to avoid problems.

@bxy4543 I'm working on the failed e2e tests. currently I found docker_122 and docker_123 was failed, containerd_122 and containerd_123 was ok. The failure seems related with some old version of k8s with docker runtime.
I will appreciate it if you have some tips for debugging this problem.
E2E_sealos_runtime_version_docker_123_test failed
E2E_sealos_runtime_version_docker_124_test was successfully executed.
E2E_sealos_runtime_version_123_test was successfully executed.
log for E2E_sealos_runtime_version_docker_123_test
https://github.com/labring/sealos/actions/runs/7237990534/job/19736079820?pr=4427
2023-12-18T08:48:46 debug apply apiserver_host_applier on host 10.1.0.12:22
2023-12-18T08:48:46 info domain apiserver.cluster.local:10.1.0.12 append success
2023-12-18T08:48:46 debug apply initializer on host 10.1.0.12:22
current system is ubuntu

gzip: stdin: not in gzip format
tar: Child returned status 1
tar: Error is not recoverable: exiting now
tar: This does not look like a tar archive

gzip: stdin: not in gzip format
tar: Child returned status 1
tar: Error is not recoverable: exiting now
chmod: missing operand after ‘a+x’
Try 'chmod --help' for more information.
Created symlink /etc/systemd/system/multi-user.target.wants/docker.service → /etc/systemd/system/docker.service.
Job for docker.service failed because the control process exited with error code.
See "systemctl status docker.service" and "journalctl -xe" for details.
Job for docker.service failed because the control process exited with error code.
See "systemctl status docker.service" and "journalctl -xe" for details.
 INFO [2023-12-18 08:48:46] >> Health check docker!
 ERROR [2023-12-18 08:48:46] >> docker status is error
 ERROR [2023-12-18 08:48:46] >> ====init docker failed!====
2023-12-18T08:48:46 error Applied to cluster error: exit status 1

log for E2E_sealos_runtime_version_docker_124_test
https://github.com/labring/sealos/actions/runs/7237990534/job/19736080031?pr=4427
2023-12-18T08:47:39 debug apply apiserver_host_applier on host 10.1.0.24:22
2023-12-18T08:47:39 info domain apiserver.cluster.local:10.1.0.24 append success
2023-12-18T08:47:39 debug apply initializer on host 10.1.0.24:22
current system is ubuntu
docker/docker
docker/docker-init
docker/dockerd
docker/runc
docker/ctr
docker/containerd-shim-runc-v2
docker/containerd
docker/docker-proxy
Created symlink /etc/systemd/system/multi-user.target.wants/docker.service → /etc/systemd/system/docker.service.
 INFO [2023-12-18 08:47:46] >> Health check docker!
 INFO [2023-12-18 08:47:46] >> docker is running
 INFO [2023-12-18 08:47:46] >> init docker success

log for E2E_sealos_runtime_version_123_test
https://github.com/labring/sealos/actions/runs/7237990534/job/19736078510?pr=4427
2023-12-18T08:48:22 debug apply apiserver_host_applier on host 10.1.0.9:22
2023-12-18T08:48:22 info domain apiserver.cluster.local:10.1.0.9 append success
2023-12-18T08:48:22 debug apply initializer on host 10.1.0.9:22
Created symlink /etc/systemd/system/multi-user.target.wants/containerd.service → /etc/systemd/system/containerd.service.
 INFO [2023-12-18 08:48:24] >> Health check containerd!
 INFO [2023-12-18 08:48:24] >> containerd is running
 INFO [2023-12-18 08:48:24] >> init containerd success

This has nothing to do with the pr, it is a problem in the image, which has now been fixed.

repo: labring/sealos


text:
路由策略中，是否可以考虑增加全部允许

目前路由策略分为：随机、轮训、权重、最少任务。
是否可以考虑增加，主机组内所有主机都运行任务。

这个可以的，会在下一班版本加入，谢谢反馈


text:
Change text programmatically

Hi:)
Great work!
It is possible to add some public methods to change all labels?
Current:
Rings r = (Rings) findViewById(R.id.rings);
r.setRingInnerThirdProgress(123);
In the future?
r.setRingInnerThirdText("my new label");

Yep, that's a feature in my TODO list.
Maybe next week I'll work on that.
Otherwise, PR are welcome.

Some quick code snippet:)
public void updateLabels(String newOverAllText, String newInnerFirstText, String newInnerSecondText, String newInnerThirdText) {         overAllText = newOverAllText;         innerFirstText = newInnerFirstText;         innerSecondText = newInnerSecondText;         innerThirdText = newInnerThirdText;     }

authors: OlliZi lalongooo

repo: lalongooo/rings


text:
Add minimum lines for ::std::error::Error implementation

To compile below with current (1.47) rustc:
fn f<E: ::std::error::Error>(e: E) {}
fn main() {
    f(errnor::Errno(0));
}

Sorry, for typo in commit message too. Fixed by rebase: https://github.com/chamaken/rust-errno/commit/fbff9e4652bf2d95968fab71cf1f385b1856a457

Thanks!

authors: chamaken lambda-fairy

repo: lambda-fairy/rust-errno


text:
DiAbstractServiceFactory Recursion

[x] I was not able to find an open or closed issue matching what I'm seeing.
[x] This is not a question. (Questions should be asked on chat (Signup here) or our forums.)

The Zend\ServiceManager\Di\DiAbstractServiceFactory when used as an abstract factory is causing recursion.
The issue is caused by Zend\ServiceManager\ServiceManager::has() function implementation and Zend\ServiceManager\Di\DiAbstractServiceFactoryFactory: :__invoke() function which is using DiAbstractServiceFactory::USE_SL_BEFORE_DI and Zend\ServiceManager\Di\DiServiceFactory: :get() method which is sending the object initialization request back to the Zend\ServiceManager\ServiceManager and as a result creating the recursion.
During object initialization by ServiceManager via DiAbstractServiceFactory the DiServiceFactory::get() method checks whether it should call ServiceManager (Service Locator) first by the following code (line 126) and therefore sends the object initialization request back to the ServiceManager because both conditions for the if statement are correct in this situation.
// Allow this di service to get dependencies from the service locator BEFORE trying DI.
if ($this->useContainer === self::USE_SL_BEFORE_DI && $this->container->has($name)) {
     return $this->container->get($name);
 }

As the object initialization request is sent or pushed back to the ServiceManager and the ServiceManager will forward the request again to DiAbstractServiceFactory therefore creating the recursion (sending the request back and forth) and the end result is system memory exhausted.
Code to reproduce the issue
Please just use Zend\ServiceManager\Di\DiAbstractServiceFactory as an abstract factory
and then use ServiceManager to get/initialize an object. This object should not have any other factory class defined in the config. The only factory which should initialize this object should be Zend\ServiceManager\Di\DiAbstractServiceFactory.
Expected results

No Recursion.
Actual results

Recursion

Originally posted by @mirza572 at https://github.com/zendframework/zend-servicemanager-di/issues/19

I created the following to test this:
// in src/Example.php:
namespace Test;

class Example
{
}

// in test.php:
use Test\Example;
use Zend\ServiceManager\Di\ConfigProvider;
use Zend\ServiceManager\Di\DiAbstractServiceFactory;
use Zend\ServiceManager\ServiceManager;

require './vendor/autoload.php';

$container = new ServiceManager((new ConfigProvider())->getDependencyConfig());
$container->addAbstractFactory($container->get('DiAbstractServiceFactory'));

$instance = $container->get(Example::class);
var_export($instance);

This mimics how zend-servicemanager-di would register its services, and demonstrates how to add its abstract factory to the container after initialization.
This definitely reproduces the issue.
I'm not certain how quickly we will try to address it, particularly as zend-di provides comprehensive support for zend-servicemanager as of version 3. We typically recommend using that support if you are able to to, as it provides a better path from development to production, and more flexibility in how users interact with their container.
Interestingly, I checked to see if this worked in that paradigm as well:
use Test\Example;
use Zend\Di\ConfigProvider;
use Zend\Di\Container\ServiceManager\AutowireFactory;
use Zend\ServiceManager\ServiceManager;

require './vendor/autoload.php';

$container = new ServiceManager(array_merge_recursive(
    (new ConfigProvider())->getDependencyConfig(),
    [
        'abstract_factories' => [
            new AutowireFactory(),
        ],
    ]
));

$instance = $container->get(Example::class);
var_export($instance);

Surprisingly, the behavior is exhibited there as well. (Anecdotally, I'm surprised, as I've used the autowire factory before when prototyping functionality, and it worked fine.)
I'm curious if the issue is due to having an empty constructor. Can you provide some information about the class you're trying to retrieve from the container?

Originally posted by @weierophinney at https://github.com/zendframework/zend-servicemanager-di/issues/19#issuecomment-558818981

The issue exists in both cases whether the class has an empty constructor or not. Following is the class constructor
    /**
     * Constructor
     *
     *  \Vendor\Framework\App\ResourceConnection $resourceConnection
     */
    public function __construct(
        \Vendor\Framework\App\ResourceConnection $resourceConnection
    ) {
       $this->connection = $resourceConnection->getConnection();
    }

A quick solution to this issue is changing Zend\ServiceManager\Di\DiAbstractServiceFactoryFactory: :__invoke() method as following i.e. replace DiAbstractServiceFactory::USE_SL_BEFORE_DI by DiAbstractServiceFactory::USE_SL_NONE or DiAbstractServiceFactory::USE_SL_AFTER_DI
    /**
     * Class responsible for instantiating a DiAbstractServiceFactory
     *
     * @param ContainerInterface $container
     * @param string $name
     * @param null|array $options
     * @return DiAbstractServiceFactory
     */
    public function __invoke(ContainerInterface $container, $name, array $options = null)
    {
        $factory = new DiAbstractServiceFactory($container->get('Di'), DiAbstractServiceFactory::USE_SL_NONE);

        if ($container instanceof ServiceManager) {
            $container->addAbstractFactory($factory, false);
        }

        return $factory;
    }

Originally posted by @mirza572 at https://github.com/zendframework/zend-servicemanager-di/issues/19#issuecomment-559056476

This package is considered feature-complete, and is now in security-only maintenance mode, following a decision by the Technical Steering Committee.
If you have a security issue, please follow our security reporting guidelines.
If you wish to take on the role of maintainer, please nominate yourself
You can now use laminas/laminas-di directly with laminas/laminas-servicemanager.

repo: laminas/laminas-servicemanager-di


text:
🛑 rexingsports.cn is down

In 08d0c7b, rexingsports.cn (https://www.rexingsports.cn) was down:

HTTP code: 567
Response time: 858 ms

Resolved: rexingsports.cn is back up in 6e73ce0 after 19 minutes.

repo: lanen/bs-site


text:
🛑 rexingsports.cn is down

In 07cb8c9, rexingsports.cn (https://www.rexingsports.cn) was down:

HTTP code: 567
Response time: 788 ms

Resolved: rexingsports.cn is back up in 71598dd.


text:
🛑 vipgifts.net is down

In 524547f, vipgifts.net (https://vipgifts.net) was down:

HTTP code: 567
Response time: 822 ms

Resolved: vipgifts.net is back up in 83ee9ca.


text:
🛑 trixmall.com is down

In de0756c, trixmall.com (https://www.trixmall.com/) was down:

HTTP code: 567
Response time: 544 ms

Resolved: trixmall.com is back up in 53b706c after 617 days, 4 hours, 29 minutes.


text:
🛑 vipgifts.net is down

In 56a16f4, vipgifts.net (https://vipgifts.net) was down:

HTTP code: 567
Response time: 323 ms

Resolved: vipgifts.net is back up in bdc968b after 20 minutes.


text:
Issue: Unable to Serialize AgentExecutor Object for Centralized Storage

Issue you'd like to raise.
To develop a scalable solution, I hoped to store the AgentExecutor object in centralized memory, such as Redis. However, due to its non-serializable nature, this has not been possible. Is there a workaround to achieve this?
Suggestion:
No response

Unfortunately, this does not work, I am getting the following error
in serialize_agent_executor
serialized_agent_executor = pickle.dumps(agent_executor_dict)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
TypeError: cannot serialize 'GreenThread' object

Yes, I wasn't able to resolve it earlier, and it seems to be generating in the current langchain version

Issue has not been resolved

issue yet pending to resolution, facing the same problem here

authors: REsteche ns-qasim

repo: langchain-ai/langchain


text:
DOC: Is there a way to conditionally create/update a Pandas DataFrame agent?

Issue with current documentation:
Is there a way to conditionally create a Pandas agent using create_pandas_dataframe_agent or update the DataFrame the agent has access to?
Say I have an agent that has access to tools like so:
@tool()
def f(query: str) -> pd.DataFrame:
    ...

agent = initialize_agent(
    tools=[f, PythonREPLTool()],
    llm,
    agent=AgentType.ZERO_SHOT_REACT_DESCRIPTION,
    verbose=True,
    handle_parsing_errors=True,
)

Since create_pandas_dataframe_agent takes the df argument, I can't create this agent unless/until the tool f is called, producing the DataFrame. But without the specialized Pandas agent, the regular agent seems to be producing bad/bogus Python, trying to filter the DataFrame (either with syntax errors or just doing the wrong thing). Is there a way to either 1) callcreate_pandas_dataframe_agent ahead of time and then later update the contents of the df after the function call or 2) create a Pandas agent on-the-fly inside f to answer the question (I haven't found a way to pass the current Thought content to the nested agent in this case)?
Idea or request for content:
It would be helpful to see how to work with Pandas data when reading dynamically created DataFrames coming from functions that agents may or may not call.

Hi, thanks for the attempt but this is not quite applicable. In the scenario that I described, the agent will be calling the function (get_dataframe(...)) with input based on the conversation, so it is not possible to preemptively call create_pandas_dataframe_agent.


text:
Bug: FireCrawlLoader - Got exception due to failed crawl job but it was indeed a success

Checked other resources

[X] I added a very descriptive title to this issue.
[X] I searched the LangChain documentation with the integrated search.
[X] I used the GitHub search to find a similar question and didn't find it.
[X] I am sure that this is a bug in LangChain rather than my code.
[X] The bug is not resolved by updating to the latest stable version of LangChain (or the specific integration package).

Example Code
from langchain_community.document_loaders import FireCrawlLoader
loader = FireCrawlLoader(
  url="https://firecrawl.dev",
  mode="crawl",
)
docs = loader.load()
docs[0]

I have set environment variable for FIRECRAWL_API_KEY
Error Message and Stack Trace (if applicable)
Traceback (most recent call last):
File "/home/thoa/Documents/dev/demos/firecrawl/chat-with-website.py", line 23, in
for doc in docs_lazy:
File "/home/thoa/.local/lib/python3.10/site-packages/langchain_community/document_loaders/firecrawl.py", line 112, in lazy_load
firecrawl_docs = self.firecrawl.crawl_url(self.url, params=self.params)
File "/home/thoa/.local/lib/python3.10/site-packages/firecrawl/firecrawl.py", line 133, in crawl_url
return self._monitor_job_status(id, headers, poll_interval)
File "/home/thoa/.local/lib/python3.10/site-packages/firecrawl/firecrawl.py", line 360, in _monitor_job_status
raise Exception(f'Crawl job failed or was stopped. Status: {status_data["status"]}')
Exception: Crawl job failed or was stopped. Status: failed
Description
I'm trying to use FireCrawlLoader to crawl a website. I should get a printed out put like:

Document(metadata={'ogUrl': 'https://www.firecrawl.dev/', 'title': 'Home - Firecrawl', 'robots': 'follow, index', 'ogImage': 'https://www.firecrawl.dev/og.png?123', 'ogTitle': 'Firecrawl', 'sitemap': {'lastmod': '2024-08-12T00:28:16.681Z', 'changefreq': 'weekly'}, 'keywords': 'Firecrawl,Markdown,Data,Mendable,Langchain', 'sourceURL': 'https://www.firecrawl.dev/', 'ogSiteName': 'Firecrawl', 'description': 'Firecrawl crawls and converts any website into clean markdown.' ...)

Instead, I got an error that the crawl job failed or was stopped but I checked the Activity Logs in FireCrawl and the craw was a success.
The error can be traced to the function monitor_job_status in FireCrawl's Python SDK. I'm not sure if there is bug in FireCrawl integration in Langchain, or FireCrawl's Python SDK.
System Info
System Information

OS:  Linux
OS Version:  #62-Ubuntu SMP Tue Nov 22 19:54:14 UTC 2022
Python Version:  3.10.12 (main, Nov 20 2023, 15:14:05) [GCC 11.4.0]

Package Information

langchain_core: 0.3.6
langchain: 0.3.1
langchain_community: 0.3.1
langsmith: 0.1.129
langchain_text_splitters: 0.3.0

Optional packages not installed

langgraph
langserve

Other Dependencies

aiohttp: 3.10.6
async-timeout: 4.0.3
dataclasses-json: 0.6.7
httpx: 0.27.2
jsonpatch: 1.33
numpy: 1.26.4
orjson: 3.10.7
packaging: 24.1
pydantic: 2.9.2
pydantic-settings: 2.5.2
PyYAML: 5.4.1
requests: 2.25.1
SQLAlchemy: 2.0.35
tenacity: 8.5.0
typing-extensions: 4.12.2

@bytrangle I believe this issue is due to https://github.com/mendableai/firecrawl/issues/720. You should be able to resolve it by using the workaround provided in the discussion or updating to include the associated PR fix. The former works in my case.

Closed by https://github.com/langchain-ai/langchain/pull/26548


text:
docs: Embellish article on splitting by tokens with more examples and missing details

Description
This PR adds some missing details from the "Split by tokens" page in the documentation. Specifically:

The .from_tiktoken_encoder() class methods for both the CharacterTextSplitter and RecursiveCharacterTextSplitter default to the old gpt-2 encoding. I've added a comment to suggest specifying model_name or encoding
The docs didn't mention that the from_tiktoken_encoder() class method passes additional kwargs down to the constructor of the splitter. I only discovered this by reading the source code
Added an example of using the .from_tiktoken_encoder() class method with RecursiveCharacterTextSplitter which is the recommended approach for most scenarios above CharacterTextSplitter
Added a warning that TokenTextSplitter can split characters which have multiple tokens (e.g. 猫 has 3 cl100k_base tokens) between multiple chunks which creates malformed Unicode strings and should not be used in these situations.

Side note: I think the default argument of gpt2 for .from_tiktoken_encoder() should be updated?
Twitter handle anthonypjshaw

Cc @baskaryan who worked on this article most recently

@baskaryan sorry there was a linting error, have fixed please can you reapprove the CI and auto-merge. I ran all the checks locally.


text:
community[patch]: change default Neo4j username/password

Description:
Change the default Neo4j username/password (when not supplied as environment variable or in code) from None to "".
Neo4j has an option to disable auth which is helpful when developing. When auth is disabled, the username / password through the neo4j module should be "" (ie an empty string).
Empty strings get marked as false in langchain_core.utils.env.get_from_dict_or_env -- changing this code / behaviour would have a wide impact and is undesirable.
In order to both allow access to Neo4j with auth disabled and not impact langchain_core this patch is presented. The downside would be that if a user forgets to set NEO4J_USERNAME or NEO4J_PASSWORD they would see an invalid credentials error rather than missing credentials error. This could be mitigated but would result in a less elegant patch!
Issue:
Fix issue where langchain cannot communicate with Neo4j if Neo4j auth is disabled.
Twitter handle: @danodonovan

Hmm when auth is disabled, wouldn't it rather leave off the auth parameter in the driver?
Missing credentials is actually more helpful than "wrong credentials" here ... I can imagine searching for the bug e.g. a wrong path or a misspelled env variable for ages when it says wrong credentials instead of missing.

@jexp @eyurtsev thank you for the feedback, I agree. 6a60dad follows jexp suggestion to remove auth from the driver if "" is intentionally provided

@eyurtsev @jexp Sorry for pushing this PR past you again, the changes would be helpful for me if accepted.

cc @tomasonjo

LGTM
V čet., 29. avg. 2024, 11:27 je oseba Bagatur @.***>
napisala:

cc @tomasonjo https://github.com/tomasonjo
—
Reply to this email directly, view it on GitHub
https://github.com/langchain-ai/langchain/pull/25226#issuecomment-2316593432,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AEYGGTMUEQRW7WQG4EYEOY3ZT2BJ7AVCNFSM6AAAAABMIHDA36VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMJWGU4TGNBTGI
.
You are receiving this because you were mentioned.Message ID:
@.***>

needs to be formatted, otherwise lgtm

needs to be formatted, otherwise lgtm

Thanks @hwchase17 -- sorry to have missed the linting issue, it should be green-lit now

authors: baskaryan danodonovan hwchase17 jexp tomasonjo


text:
Error : Cannot get final name for export 'getRuntime' of ./node_modules/openai/_shims/auto/runtime-node.mjs

Checked other resources

[X] I added a very descriptive title to this issue.
[X] I searched the LangChain.js documentation with the integrated search.
[X] I used the GitHub search to find a similar question and didn't find it.
[X] I am sure that this is a bug in LangChain.js rather than my code.
[X] The bug is not resolved by updating to the latest stable version of LangChain (or the specific integration package).

Example Code
const chain = ConversationalRetrievalQAChain.fromLLM(
      model,
      vectorStore.asRetriever()
    );
    // Format the messages
    const formattedChatPrompt = await chatPrompt.formatMessages({
      text: question,
    });

    const res = await chain.invoke({
      question,
      chat_history: formattedChatPrompt,
    });

Error Message and Stack Trace (if applicable)
Failed to compile.

./node_modules/@langchain/openai/index.js + 66 modules
Cannot get final name for export 'getRuntime' of ./node_modules/openai/_shims/auto/runtime-node.mjs```

### Description

I am trying to use Langchain + NextJs for hosting my chatbot , and it works fine in the development server ,
But when I try to compile my code to host on the vercel server, I am getting the error

### System Info

Langchain info ->
```elixir
langchain@0.1.34 | MIT | deps: 17 | versions: 265
Typescript bindings for langchain
https://github.com/langchain-ai/langchainjs/tree/main/langchain/

keywords: llm, ai, gpt3, chain, prompt, prompt engineering, chatgpt, machine learning, ml, openai, embeddings, vectorstores

dist
.tarball: https://registry.npmjs.org/langchain/-/langchain-0.1.34.tgz
.shasum: 3c28a6bde69c5f4ac3931376d34187de0e44e43a
.integrity: sha512-4TVH2mzhITrLPOeyfGucfqo1+360DJMl4+ItG56ApxVY1krO4hV0EkqcRLAxW06W6sIue8mIU70WbyhBYH68Ug==
.unpackedSize: 4.1 MB

dependencies:
@anthropic-ai/sdk: ^0.9.1     binary-extensions: ^2.2.0     langchainhub: ~0.0.8          p-retry: 4                    zod: ^3.22.4
@langchain/community: ~0.0.47 js-tiktoken: ^1.0.7           langsmith: ~0.1.7             uuid: ^9.0.0
@langchain/core: ~0.1.56      js-yaml: ^4.1.0               ml-distance: ^4.0.0           yaml: ^2.2.1
@langchain/openai: ~0.0.28    jsonpointer: ^5.0.1           openapi-types: ^12.1.3        zod-to-json-schema: ^3.22.3

maintainers:
- nfcampos <nuno@boringbits.io>
- jacoblee93 <jacoblee93@gmail.com>
- andrewnguonly <andrewnguonly@gmail.com>
- davidduong <david@duong.cz>
- hwchase17 <hw.chase.17@gmail.com>
- basproul <braceasproul@gmail.com>

dist-tags:
latest: 0.1.34     next: 0.1.29-rc.0

published 2 days ago by jacoblee93 <jacoblee93@gmail.com>```

Platform -> windows 10
Node -> v20.9.0

@dosu
I tried doing this
/** @type {import('next').NextConfig} */
const nextConfig = {
  transpilePackages: ['html-to-text'],
  webpack: (config ) => {
    config.externals = [...config.externals, "hnswlib-node","closevector-hnswlib-node","langchain","openai","@langchain", "@langchain/community","@langchain/groq"];

    return config;
  },
};

export default nextConfig;

and now my openai error is gone somehow
but now new error comes of @langchain/core
<!--StartFragment-->
./node_modules/@langchain/openai/index.js + 15 modules
--
14:07:23.264 | Cannot get final name for export 'Tool' of ./node_modules/@langchain/core/tools.js
14:07:23.264 |
14:07:23.269 |
14:07:23.270 | > Build failed because of webpack errors

<!--EndFragment--> ```
and this doesnt seem to go away even if i add @langchain or something in my externals

hello @dosu,
I tried to run npm run build and this error popped up.

here are my next.config.js configurations:

authors: jiveshkalra momensalama

repo: langchain-ai/langchainjs


text:
Browser (and other non-node environment) Support

I'm using LangGraph in a browser extension, but it appears the released version requires node via this method:
https://github.com/langchain-ai/langgraphjs/blob/6657998095cece2f7d48323454474a294fee6b65/libs/langgraph/src/setup/async_local_storage.ts#L1-L8
I've simply commented out calling this function, and otherwise LangGraph seems to be fully functional.
Can we use  a dynamic import or something to allow released LangGraph to work in a browser-like environment?

Hey @gingerhendrix, please see instructions here:
https://langchain-ai.github.io/langgraphjs/how-tos/use-in-web-environments/
A few things to watch out for around nesting and config passing but should work fine!

https://langchain-ai.github.io/langgraphjs/how-tos/use-in-web-environments/?h=browser
^ does this resolve your issue?

haha jinx

authors: gingerhendrix hinthornw jacoblee93

repo: langchain-ai/langgraphjs


text:
Custom Run IDs & tags with proxy

Hi there,
Thanks for all the innovative stuff the team is putting out.
I'm using the langsmith proxy because I need langsmith to support streaming, and, to my understanding of the docs, using the proxy is the only way to do this currently (?).
However, when using the proxy, there's no documentation on how to specify custom Run IDs, Trace IDs, tags, metadata, etc. The pattern shown in the docs is basically just raw OpenAI API syntax with the proxy URL specified as a param in openai.Client().
Are tags, IDs currently supported by the proxy?
Tyia

Hi @sfuller14 could you elaborate on langsmith not supporting streaming? What are you trying to do?
LangSmith supports streaming natively:
from langsmith import traceable

@traceable
def foo():
    for i in range(10):
        yield i

list(foo)

Okay thanks for confirming. I couldn't find that pattern anywhere in the docs except in the proxy section - could be worth making explicit somewhere like the QuickStart (though I may have just missed it). Thanks!

repo: langchain-ai/langsmith-docs


text:
langgraph

Hello, do you have any plans to build components like Langgraph in the near future?

Please check https://github.com/czelabueno/langchain4j-workflow and https://github.com/bsorrentino/langgraph4j and


text:
[FEATURE] Whisper API support; including files (.wav, .png..etc) with your prompt

Is your feature request related to a problem? Please describe.
I want to be able to use the whisper-1 model provided by OpenAI to transcribe text from audio. LLMs are also getting more multi-modal and so this same feature would likely also be needed for sending images as part of prompts as well, for future feature coverage.
Describe the solution you'd like
Primarily I want to be able to transcribe audio using whisper-1 model offered by OpenAI. The solution should probably not be specific to audio files though since multi-modal LLMs can make use of images too these days.
Describe alternatives you've considered
Not using langchain4j for this :(

I'll add audio/sound soon together with @LizeRaes, please feel free to assign this request to me

@SandraAhlgrimm thank you, looking forward to it!

@langchain4j we would start by either implementing the Azure version or the OpenAI version (incl. extension to openai4j)
Wondering about the output format, should we make something like Response as is currently the case with image models? Asking because I'm not sure if this wrapper will be deprecated soon, and what we would want instead.

@LizeRaes please don't use Response<T> as it will be deprecated eventually.
Do you plan to implement text-to-speech or speech-to-text?

Assuming we are talking about speech to text, I can imagine interface like this:
interface AudioTranscriptionModel {

    AudioTranscriptionResult transcribe(AudioTranscriptionRequest request);
}

Is this what you had in mind?

sounds good, thank you!

Hi @SandraAhlgrimm, do you still work on this feature? Any estimates/timelines? Thanks! 🙏

Yes, PR should come by the end of this week

authors: Emperorlou LizeRaes SandraAhlgrimm langchain4j


text:
[FEATURE] llm work with tool using function-calling

I figure out that langchain4j uses function-calling api work with tools,
but most llm except chatgpt does not support function-calling,
this way may not work for my request, do you have some advice?

Hi @vcjj which LLM are you using? LocalAI supports function calling and you can run many opensource LLMs with it.


text:
Opening wallet triggers resync for ALL wallets

I finally managed to get MultiDoge to sync one wallet..
And then I opened the 2nd wallet, to transfer from it to the one that just synced.
Unfortunately, the sync process began once again all the way back from 2013 .........
Does it make sense that the blockchain data can be 'shared' between wallets, such that opening a new wallet doesn't retrigger a sync for all wallets? This seems to be very unoptimal behavior.
Is there a technical reason for it to be so?
Thanks.

The thing is, how SPV works, it requests the nodes you're syncing from to send you block hashes and then also send you transactions actually relevant to your wallet. It does so by using bloom filters.
Now, since each of your wallets is differet, it can't use the same blockchain data, as it doesn't hold the same amount of data needed in relation to all your wallets.
Now what it shouldn't do is doing a full resync of the wallets. This might be something in relation to the old codebase here. I'm currently waiting for MultiBit HD to come out, so I could actually work on porting that to Doge ;)

So that's why it currently does a full resync of my main wallet. I just imported the keys from my old android wallet to see whether I still had some doge there (I did not) and now I need to wait at least 1-2 days of resync of my main wallet until I can send doge again? At least the sync status could be held separately for each wallet.
I left it for 8 hours and it synced like 200,000 blocks and still has 1,700,000 to go. With this ridiculous long sync times, maybe it would be better to add functionality to sync via a bootstrap copy of the blockchain so only a few weeks/months must be synced online. I know, that defeats the purpose of a light wallet a bit, but I mainly wanted one for avoiding it continuously eating away at my the free space on my hard disk.

authors: ChristophHaag bsdhsr langerhans

repo: langerhans/multidoge


text:
Wrong docker hub version tag

Bug Description
The latest deployment uses version tag 0.0.93 instead of 1.0.15
https://hub.docker.com/r/langflowai/langflow-backend/tags
https://hub.docker.com/r/langflowai/langflow-frontend/tags
Reproduction
Visit
https://hub.docker.com/r/langflowai/langflow-backend/tags
https://hub.docker.com/r/langflowai/langflow-frontend/tags
Expected behavior
tag is 1.0.15
Who can help?
@ogabrielluiz
Operating System
Not relevant
Langflow Version
1.0.15
Python Version
None
Screenshot
No response
Flow File
No response

I confirm that the images have the wrong tags. An easy fix will be to rename the Docker image tags to avoid confusion.
In the meantime, you can use the Docker images by changing the tag name on your Docker Compose or Helm Chart:
For 1.0.15 => base-1.0.15 or latest
For base-0.0.93 => 0.0.93 or base-latest
Using the latest/base-latest is a better option if the team rename the Docker image tags.

@timoa what is the difference between those two images? I can see a significant change in storage used

PR #3455 resolves this issue

authors: hakan-77 italojohnny konradbjk timoa

repo: langflow-ai/langflow


text:
谷歌双列问题

双列的话，谷歌精选推荐不能自动换行

与这个类似， 计算器的显示也不完整。建议把这一类内容就单列显示。或者加滚动条 。万分感谢。


text:
alignment of examples in relative-clause.tex

The examples in relative-clause.tex are not aligned. This can be done with \ex[]{ ... } and \ex[*]{ ... } respectively.
Example:
\eal
\ex[*]{\label{x:rc-29}
I wonder [some pictures of whom] they were admiring.
}
\ex[]{\label{x:rc-30}
the children [some pictures of whom] they were admiring
}
\zl

fixed #12

Please only do this for examples having ungrammatical examples in the listing. I fixed this.

repo: langsci/hpsg-handbook


text:
Make spiner a spack variant rather than a required dependency

Make a variant for spiner rather than having it be a required dependency

Resolved

authors: Yurlungur jhp-lanl

repo: lanl/singularity-eos


text:
最新版报错：Our systems have detected unusual activity coming from your system. Please try again later.

佬，更新到最新版后似乎会报错，是不是被官方盯上了，报错如下：
2024-06-18 08:04:45,329 | INFO | Retry 1 status code 500, Failed to perform, curl: (7) Failed to connect to 172.17.0.15 port 1081 after 0 ms: Couldn't connect to server. See https://curl.se/libcurl/c/libcurl-errors.html first for more details.. Retrying... 2024-06-18 08:04:45,967 | INFO | diff: 00415a, time: 8.319ms, solved: True 2024-06-18 08:04:49,899 | INFO | Model mapping: gpt-4o -> gpt-4o 2024-06-18 08:04:51,033 | INFO | 172.17.0.1:35068: POST /zjw/v1/chat/completions HTTP/1.1 200 OK 2024-06-18 08:04:51,034 | ERROR | -------------------------------------------------- | Error: data: {"message": null, "conversation_id": "4f184ab4-5b76-44ba-9228-75a0cdc89ad6", "error": "Our systems have detected unusual activity coming from your system. Please try again later."}, details: 'NoneType' object has no attribute 'get' └--------------------------------------------------------------------------------

试了一下似乎还是因为ip的问题

确实是ip问题

现在好像还是总出现这个问题，你还出现么？

现在好像还是总出现这个问题，你还出现么？

ip的问题，尝试搞个新IP或者弄个好点的代理

这个是openai在灰度turnstile

这个是openai在灰度turnstile

😮  close ai又在搞事情


text:
代码注释有一些bug

注释颜色异常

```js ```格式的注释, 有时被转为纯文字
使用// 单行注释会导致代码块失效

已经修复 https://github.com/alecthomas/chroma/issues/106

authors: congzhaoyang laozhu

repo: laozhu/hugo-nuo


text:
Can't install elasticsearch plugin

Info:

Docker version ($ docker --version):
Laradock commit ($ git rev-parse HEAD):
System info (Mac, PC, Linux):
System info disto/version:

Issue:

Tried to install a elasticsearch plugin based on document, but that didn't work. It seems no correct directory for plugins.
Expected behavior:

Reproduce:

Relevant Code:
// place a code sample here
```OCI runtime exec failed: exec failed: container_linux.go:348: starting container process caused "exec: \"/usr/share/elasticsearch/bin/plugin\": stat /usr/share/elasticsearch/bin/plugin: no such file or directory": unknown

Chang
docker-compose exec elasticsearch /usr/share/elasticsearch/bin/plugin install {plugin-name}
To
docker-compose exec elasticsearch /usr/share/elasticsearch/bin/elasticsearch-plugin install {plugin-name}

repo: laradock/laradock


text:
No config file or laraspace artisan command

Hi,
According to the documentation one should be able to remove the demo files by running the command php artisan laraspace:clean or by configuring the laraspace config file. The config file is nowhere to be seen and running the artisan command returns this error:   There are no commands defined in the "laraspace" namespace.
Should I remove everything by hand?

Here's the config file which mentions the files and folders that will be deleted if you run php artisan laraspace:clean command:
https://github.com/laraspace/laraspace/blob/master/config/laraspace.php
It looks like this:

authors: JanCusters mohitpanjwani

repo: laraspace/laraspace


text:
KendoUI SASS deprecation warning

Laravel Mix Version: 6.0.49
Node Version (node -v): v16.17.0
NPM Version (npm -v): 8.15.0
OS: Ubuntu WSL

Description:
Dart sass warning:
I'm migrating to laravel mix from 5 to 6 with also sass from 1.32.13 to 1.55.0 . I'm using kendoui component and I've many deprecation warning that confuse me in development.
In kendoui community is proposed to hide the warning with the options
 sassOptions: {
          quietDeps: true
}

I've tried many combination to hide this but without success. How can update this options?
Using something like that looks promising but look like I brake the compilation of the template.
mix.webpackConfig({
  rules: [
    {
       test: /\.vue$/,
       use: [
          loader: 'vue-loader', options: { sassOptions: { quietDeps: true } }
       ]
    }
  ]
})

The problem
WARNING in ./resources/js/components/navbar/xxxx.vue?vue&type=style&index=0&id=373334aa&lang=scss&scoped=true (./node_modules/css-loader/dist/cjs.js??clonedRuleSet-12.use[1]!./node_modules/vue-loader/dist/stylePostLoader.js!./node_modules/postcss-loader/dist/cjs.js??clonedRuleSet-12.use[2]!./node_modules/sass-loader/dist/cjs.js??clonedRuleSet-12.use[3]!./node_modules/vue-loader/dist/index.js??ruleSet[0].use[0]!./resources/js/components/navbar/xxxx.vue?vue&type=style&index=0&id=373334aa&lang=scss&scoped=true)
Module Warning (from ./node_modules/sass-loader/dist/cjs.js):
Deprecation Using / for division outside of calc() is deprecated and will be removed in Dart Sass 2.0.0.

Steps To Reproduce:
Add kendoui element in laravel9 projects

@paraflu why not just fix the Sass division?

Is from kendoui package...

I think the y need to fix that because current sass doesn’t support slash for division anymore.

authors: florianbouvot paraflu

repo: laravel-mix/laravel-mix


text:
Unexpected behavior from Request::fulUrlWithQuery: Trailing separator

Hello,
Having the following full URL present:
http://myapp.dev/search?q=something+here
adding a query parameter vie the fullUrlWithQuery eg. ['page' => 5] should result in the following:
http://myapp.dev/search?q=something+here&page=5
results in:
http://myapp.dev/search/?q=something+here&page=5
Notice the trailing path separator after search and before the query string starts.
The expected behavior can be achieved by changing the Request::fulUrlWithQuery from:
<?php

    public function fullUrlWithQuery(array $query)
    {
        return count($this->query()) > 0
                        ? $this->url().'/?'.http_build_query(array_merge($this->query(), $query))
                        : $this->fullUrl().'?'.http_build_query($query);
    }

to:
<?php

    public function fullUrlWithQuery(array $query)
    {
        return count($this->query()) > 0
                        ? $this->url().'?'.http_build_query(array_merge($this->query(), $query))
                        : $this->fullUrl().'?'.http_build_query($query);
    }

Is there a specific reason of why the trailing separator is placed there or can this just be changed to get to the expected behavior?

Thanks, but this is not actually a bug. We have a test to ensure we don't change this behaviour.

authors: GrahamCampbell belisarh

repo: laravel/framework


text:
[5.4] "Npm run" commands don't work on windows.

Laravel Version: 5.4.1
PHP Version: 7.0.4
node v6.9.4
npm  v3.10.5

Description:
npm commands are completely broken on windows (windows 7 in this case), whenever I run npm run dev I get the following error:
'node_modules' is not recognized as an internal or external command,
operable program or batch file.

node-debug.log
I tried
  "scripts": {
    "dev": "node node_modules/cross-env/bin/cross-env.js NODE_ENV=development node_modules/webpack/bin/webpack.js --progress --hide-modules --config=node_modules/laravel-mix/setup/webpack.config.js",
    "watch": "node node_modules/cross-env/bin/cross-env.js NODE_ENV=development node_modules/webpack/bin/webpack.js --watch --progress --hide-modules --config=node_modules/laravel-mix/setup/webpack.config.js",
    "hot": "node node_modules/cross-env/bin/cross-env.js NODE_ENV=development node_modules/webpack-dev-server/bin/webpack-dev-server.js --inline --hot --config=node_modules/laravel-mix/setup/webpack.config.js",
    "production": "node node_modules/cross-env/bin/cross-env.js NODE_ENV=production node_modules/webpack/bin/webpack.js --progress --hide-modules --config=node_modules/laravel-mix/setup/webpack.config.js"
  },

It ran but without success:
> @ dev c:\wamp\www\web
> node node_modules/cross-env/bin/cross-env.js NODE_ENV=development node_modules/webpack/bin/webpack.js --progress --hide-modules --config=node_modules/laravel-mix/setup/webpack.co
nfig.js

path.js:7
    throw new TypeError('Path must be a string. Received ' + inspect(path));
    ^

TypeError: Path must be a string. Received undefined
    at assertPath (path.js:7:11)
    at Object.parse (path.js:950:5)
    at new File (c:\wamp\www\web\node_modules\laravel-mix\src\File.js:14:30)
    at Object.module.exports.preprocess (c:\wamp\www\web\node_modules\laravel-mix\src\index.js:108:14)
    at Object.module.exports.sass (c:\wamp\www\web\node_modules\laravel-mix\src\index.js:84:27)
    at Object.<anonymous> (c:\wamp\www\web\webpack.mix.js:17:5)
    at Module._compile (module.js:570:32)
    at Object.Module._extensions..js (module.js:579:10)
    at Module.load (module.js:487:32)
    at tryModuleLoad (module.js:446:12)
    at Function.Module._load (module.js:438:3)
    at Module.require (module.js:497:17)
    at require (internal/module.js:20:19)
    at Mix.initialize (c:\wamp\www\flores\node_modules\laravel-mix\src\Mix.js:38:9)
    at Object.<anonymous> (c:\wamp\www\flores\node_modules\laravel-mix\setup\webpack.config.js:18:5)
    at Module._compile (module.js:570:32)

Steps To Reproduce:
Run npm run dev command on windows.

These are the scripts as they are meant to be:
  "scripts": {
    "dev": "cross-env NODE_ENV=development webpack --progress --hide-modules",
    "watch": "cross-env NODE_ENV=development webpack --watch --progress --hide-modules",
    "hmr": "cross-env NODE_ENV=development webpack-dev-server --inline --hot",
    "production": "cross-env NODE_ENV=production webpack --progress --hide-modules"
  }

@PascaleBeier No.
Just installed the latest version. I'm pretty sure that's the package.json installed for Mac users.
Also, this is the master branch: https://github.com/laravel/laravel/blob/master/package.json

@Frondor Did you try these? Taken from laravel-mix.

I have tried @PascaleBeier 's suggestion, but same issue.
Fresh installed Laravel 5.4.2 with npm 4.12, then npm install.
npm run production
npm-debug.txt

Looks like I may have to get my PC out of the closet :) ... can anyone confirm a working resolution that works on both mac and Windows?

@Frondor Please paste in your webpack.mix.js file.

change from this:
"dev": "node_modules/cross-env/bin/cross-env.js NODE_ENV=development node_modules/webpack/bin/webpack.js --progress --hide-modules --config=node_modules/laravel-mix/setup/webpack.config.js",
to this:
"dev": "cross-env NODE_ENV=development webpack --progress --hide-modules --config=node_modules/laravel-mix/setup/webpack.config.js",
for other commands same

I dont know is this work for Mac but for me on Windows work

@bajro17 - But then it doesn't work if you're using Yarn. :/

I don't know  than we need to find universal solution 😢

Just installed Laravel 5.4.3 on my windows machine and then ran
npm install
and then tried
npm run dev, npm run watch and it works perfectly fine for me.

Changes like cross-env NODE_ENV=development webpack --progress --hide-modules --config=node_modules/laravel-mix/setup/webpack.config.js don't work because it assumes you have cross-env added you your PATH environment variable.
Appending the node command to the string should do the trick, but the error I shared before is still there. Debug logs are pointing to c:\wamp\www\web\node_modules\laravel-mix\src\File.js:14:30.
I didn't try any other version than L5.4.1, I'll check the 5.4.3 once I get back in home.

That's why we need to see what your webpack.mix.js file looks like. I'm wondering if there's an method argument there that isn't correct.

@JeffreyWay everything is default, I didn't touch a single.
const { mix } = require('laravel-mix');

/*
 |--------------------------------------------------------------------------
 | Mix Asset Management
 |--------------------------------------------------------------------------
 |
 | Mix provides a clean, fluent API for defining some Webpack build steps
 | for your Laravel application. By default, we are compiling the Sass
 | file for the application as well as bundling up all the JS files.
 |
 */

mix.js('resources/assets/js/app.js', 'public/js')
   .sass('resources/assets/sass/app.scss', 'public/css');

Win 8, node 7.4.0, npm 4.0.5 Laravel 5.4.3 everything works perfectly. Thanks for all the work put into this.

I updated Node from 5.x.x to 7.4.0 and then it works on Windows (same error before).
sudo npm cache clean -f
sudo npm install -g n
sudo n stable

@Frondor - At this point, your question is specifically related to Laravel Mix. It doesn't have anything to do with the framework code. I'm going to port this question over there.
https://github.com/JeffreyWay/laravel-mix/issues/185

Same problem
win 10 64bits
wampserver php7
Solution:
Update windows npm with installer
https://nodejs.org/en/download/

Same problem
MacOs Sierra
Laravel Framework 5.4.10
Valet - PHP 7.1.1
NPM 4.0.5
//Terminal
$ npm run dev

@ dev /Users/gabrielap/Sites/projectX
node node_modules/cross-env/bin/cross-env.js NODE_ENV=development node_modules/webpack/bin/webpack.js --progress --hide-modules --config=node_modules/laravel-mix/setup/webpack.config.js

module.js:472
throw err;
^
Error: Cannot find module '/Users/gabrielap/Sites/projectX/node_modules/cross-env/bin/cross-env.js'
at Function.Module._resolveFilename (module.js:470:15)
at Function.Module._load (module.js:418:25)
at Module.runMain (module.js:605:10)
at run (bootstrap_node.js:420:7)
at startup (bootstrap_node.js:139:9)
at bootstrap_node.js:535:3
npm ERR! Darwin 16.4.0
npm ERR! argv "/usr/local/bin/node" "/usr/local/bin/npm" "run" "dev"
npm ERR! node v7.4.0
npm ERR! npm  v4.0.5
npm ERR! code ELIFECYCLE
npm ERR! @ dev: node node_modules/cross-env/bin/cross-env.js NODE_ENV=development node_modules/webpack/bin/webpack.js --progress --hide-modules --config=node_modules/laravel-mix/setup/webpack.config.js
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the @ dev script 'node node_modules/cross-env/bin/cross-env.js NODE_ENV=development node_modules/webpack/bin/webpack.js --progress --hide-modules --config=node_modules/laravel-mix/setup/webpack.config.js'.
npm ERR! Make sure you have the latest version of node.js and npm installed.
npm ERR! If you do, this is most likely a problem with the  package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     node node_modules/cross-env/bin/cross-env.js NODE_ENV=development node_modules/webpack/bin/webpack.js --progress --hide-modules --config=node_modules/laravel-mix/setup/webpack.config.js
npm ERR! You can get information on how to open an issue for this project with:
npm ERR!     npm bugs
npm ERR! Or if that isn't available, you can get their info via:
npm ERR!     npm owner ls
npm ERR! There is likely additional logging output above.
npm WARN Local package.json exists, but node_modules missing, did you mean to install?
npm ERR! Please include the following file with any support request:
npm ERR!     /Users/gabrielap/Sites/changingmybooking/npm-debug.log

I have same problem
I only upgrade my node
its fixed

You can solve this problem 100%
https://github.com/AttaUrRehman24/laravel-mix

Same problem when I run below
$ npm run dev

node_modules/cross-env/bin/cross-env.js NODE_ENV=development node_modules/webpack/bin/webpack.js --progress --hide-modules --config=node_modules/laravel-mix/setup/webpack.config.js

'node_modules' is not recognized as an internal or external command,
operable program or batch file.
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! @ dev: node_modules/cross-env/bin/cross-env.js NODE_ENV=development node_modules/webpack/bin/webpack.js --progress --hide-modules --config=node_modules/laravel-mix/setup/webpack.config.js
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the @ dev script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
Tried cross-env and  node but nothing is working for me.
I use integrated terminal MINGW64
My versions:
NPM - 5.6.0
Node - v8.11.2
Laravel - 5.4.36
Windows 8.1, 64-bit
My package.json:
{
"private": true,
"scripts": {
"dev": "node_modules/cross-env/bin/cross-env.js NODE_ENV=development node_modules/webpack/bin/webpack.js --progress --hide-modules --config=node_modules/laravel-mix/setup/webpack.config.js",
"watch": "node_modules/cross-env/bin/cross-env.js NODE_ENV=development node_modules/webpack/bin/webpack.js --watch --progress --hide-modules --config=node_modules/laravel-mix/setup/webpack.config.js",
"hot": "node_modules/cross-env/bin/cross-env.js NODE_ENV=development webpack-dev-server --inline --hot --config=node_modules/laravel-mix/setup/webpack.config.js",
"production": "node_modules/cross-env/bin/cross-env.js NODE_ENV=production node_modules/webpack/bin/webpack.js --progress --hide-modules --config=node_modules/laravel-mix/setup/webpack.config.js"
},
"devDependencies": {
"axios": "^0.15.2",
"bootstrap-sass": "^3.3.7",
"jquery": "^3.1.0",
"laravel-mix": "^0.5.0",
"lodash": "^4.16.2",
"vue": "^2.0.1"
}
}
Please somebody help me with this. Thanks

Any updates here?
Scripts that work in mac and windows???

Maybe best to ask on the mix repo. I have a dev environment on Mac, Ubuntu and Windows and all work as expected.

Here is what worked for me on Win 10.
  "scripts": {
    "dev": "npm run env NODE_ENV=development&&webpack --progress --hide-modules --config=node_modules/laravel-mix/setup/webpack.config.js",
    "watch": "npm run env NODE_ENV=developmen&&webpack --watch --progress --hide-modules --config=node_modules/laravel-mix/setup/webpack.config.js",
    "hot": "npm run env NODE_ENV=development&&webpack-dev-server --inline --hot --config=node_modules/laravel-mix/setup/webpack.config.js",
    "production": "npm run env NODE_ENV=production&&webpack --progress --hide-modules --config=node_modules/laravel-mix/setup/webpack.config.js"
  },

authors: AttaUrRehman24 Frondor GabrielApG JeffreyWay MiladAheshmeh PascaleBeier a-wenzel ac1982 alipajand bajro17 devcircus eduardoarandah jagadeshanh jasonbaciulis ssnatu taylorotwell


text:
can make eloquent Observer lazy load?

Laravel Version: 5.5.*
PHP Version: 7.0.12
Database Driver & Version: Mysql 5.6

Description:
I want to use the events in Model, I chose to use observers.
I follow the documentation to register Observer in AppServiceProvider\boot.
When registering I found that the model will be instantiated, If I have multiple observers, this request does not need to use it.
This waste of resources I should ignore it or how to solve?
Can give me a direction?
Thanks!
Steps To Reproduce:

observer

namespace App\Observers;
use App\Models\Link;

class LinkObserver {

    public function deleted(Link $link){

        if(!empty($link->logo))
            @unlink($link->logo);
    }
}

model

namespace App\Models;
use Illuminate\Database\Eloquent\Model;

class Link extends Model
{
}

controller

namespace App\Http\Controllers;
use Laravel\Lumen\Routing\Controller;
use App\Models\Link;

class LinkController extends Controller {

    protected $model;

    public funtion __construct(Link $model)
    {
        $this->model = $model;
    }

    public function destroy($ids)
    {
        $this->model->destroy(explode(',', $ids));
        return response('', 204);
    }
}

AppServiceProvider

namespace App\Providers;
use App\Models\Link;
use App\Observers\LinkObserver;
use Illuminate\Support\ServiceProvider;

class AppServiceProvider extends ServiceProvider
{
    public function boot(){
        Link::observe(LinkObserver::class);
        // If I have multiple observers ...
      // But for some requests I do not use it
    }
}

Hi there,
Welcome to Laravel and we are glad to have you as part of the community.
Unfortunately this github area is not a support area for general application issues. This is only for issues/bugs with the framework code itself.
Can I please suggestion closing your issue ticket here. Instead trying asking your question on one of the many great community support areas that will likely give you a better answer more quickly:

Laravel Slack (https://larachat.co/)
Laravel.io Forum (https://laravel.io/forum)
Laracasts Forum (https://laracasts.com/discuss)
StackOverflow (http://stackoverflow.com/questions/tagged/laravel)

Thanks in advance.

authors: junliuxian laurencei


text:
5.6 Feature Test lack of CSRF leaking Symfony HTTP Exception

Laravel Version: 5.6
PHP Version: 7.2
Database Driver & Version: sqlite

Description:
Testing a HTTP endpoint is leading to the following error when 405 is expected. If I switch to 400 expected the bug goes away. What I wanted to do was have providers hit 400 and 201 use cases for a create endpoint.
1) Tests\Feature\InvoiceTest::invoice_create_endpoint_correct_data with data set #1 (array(), 405)
Symfony\Component\HttpKernel\Exception\MethodNotAllowedHttpException:

C:\Users\lewis\Desktop\invoice-app\vendor\laravel\framework\src\Illuminate\Routing\RouteCollection.php:255
C:\Users\lewis\Desktop\invoice-app\vendor\laravel\framework\src\Illuminate\Routing\RouteCollection.php:242
C:\Users\lewis\Desktop\invoice-app\vendor\laravel\framework\src\Illuminate\Routing\RouteCollection.php:176
C:\Users\lewis\Desktop\invoice-app\vendor\laravel\framework\src\Illuminate\Routing\Router.php:619
C:\Users\lewis\Desktop\invoice-app\vendor\laravel\framework\src\Illuminate\Routing\Router.php:608
C:\Users\lewis\Desktop\invoice-app\vendor\laravel\framework\src\Illuminate\Routing\Router.php:597
C:\Users\lewis\Desktop\invoice-app\vendor\laravel\framework\src\Illuminate\Foundation\Http\Kernel.php:176
C:\Users\lewis\Desktop\invoice-app\vendor\laravel\framework\src\Illuminate\Routing\Pipeline.php:30
C:\Users\lewis\Desktop\invoice-app\vendor\barryvdh\laravel-debugbar\src\Middleware\InjectDebugbar.php:58
C:\Users\lewis\Desktop\invoice-app\vendor\laravel\framework\src\Illuminate\Pipeline\Pipeline.php:151
C:\Users\lewis\Desktop\invoice-app\vendor\laravel\framework\src\Illuminate\Routing\Pipeline.php:53
C:\Users\lewis\Desktop\invoice-app\vendor\fideloper\proxy\src\TrustProxies.php:57
C:\Users\lewis\Desktop\invoice-app\vendor\laravel\framework\src\Illuminate\Pipeline\Pipeline.php:151
C:\Users\lewis\Desktop\invoice-app\vendor\laravel\framework\src\Illuminate\Routing\Pipeline.php:53
C:\Users\lewis\Desktop\invoice-app\vendor\laravel\framework\src\Illuminate\Foundation\Http\Middleware\TransformsRequest.php:31
C:\Users\lewis\Desktop\invoice-app\vendor\laravel\framework\src\Illuminate\Pipeline\Pipeline.php:151
C:\Users\lewis\Desktop\invoice-app\vendor\laravel\framework\src\Illuminate\Routing\Pipeline.php:53
C:\Users\lewis\Desktop\invoice-app\vendor\laravel\framework\src\Illuminate\Foundation\Http\Middleware\TransformsRequest.php:31
C:\Users\lewis\Desktop\invoice-app\vendor\laravel\framework\src\Illuminate\Pipeline\Pipeline.php:151
C:\Users\lewis\Desktop\invoice-app\vendor\laravel\framework\src\Illuminate\Routing\Pipeline.php:53
C:\Users\lewis\Desktop\invoice-app\vendor\laravel\framework\src\Illuminate\Foundation\Http\Middleware\ValidatePostSize.php:27
C:\Users\lewis\Desktop\invoice-app\vendor\laravel\framework\src\Illuminate\Pipeline\Pipeline.php:151
C:\Users\lewis\Desktop\invoice-app\vendor\laravel\framework\src\Illuminate\Routing\Pipeline.php:53
C:\Users\lewis\Desktop\invoice-app\vendor\laravel\framework\src\Illuminate\Foundation\Http\Middleware\CheckForMaintenanceMode.php:62
C:\Users\lewis\Desktop\invoice-app\vendor\laravel\framework\src\Illuminate\Pipeline\Pipeline.php:151
C:\Users\lewis\Desktop\invoice-app\vendor\laravel\framework\src\Illuminate\Routing\Pipeline.php:53
C:\Users\lewis\Desktop\invoice-app\vendor\laravel\framework\src\Illuminate\Pipeline\Pipeline.php:104
C:\Users\lewis\Desktop\invoice-app\vendor\laravel\framework\src\Illuminate\Foundation\Http\Kernel.php:151
C:\Users\lewis\Desktop\invoice-app\vendor\laravel\framework\src\Illuminate\Foundation\Http\Kernel.php:116
C:\Users\lewis\Desktop\invoice-app\vendor\laravel\framework\src\Illuminate\Foundation\Testing\Concerns\MakesHttpRequests.php:345
C:\Users\lewis\Desktop\invoice-app\vendor\laravel\framework\src\Illuminate\Foundation\Testing\Concerns\MakesHttpRequests.php:195
C:\Users\lewis\Desktop\invoice-app\tests\Feature\InvoiceTest.php:78

Steps To Reproduce:
    /**
     * @test
     * Invoice create endpoint behaves as expected
     *
     * @dataProvider invoices_create_api_provider
     *
     * @param array $payload
     * @param int $code
     *
     * @return void
     */
    public function invoice_create_endpoint_correct_data($payload, $code)
    {
        $response = $this->post(
            route('invoice.create'), // uri
            $this->add_payload_token($payload) // data (array compatible)
        );
        $response->assertStatus($code);
        $response->assertJsonCount(0, 'line_items');
        $response->assertJson($payload);
    }

    /**
     * workaround static method provider unable to use `csrf_token()`
     *
     * @param array $payload
     *
     * @return array
     */
    private function add_payload_token(array $payload)
    {
        if(isset($payload['_token']) && $payload['_token']) {
            $payload['_token'] = csrf_token();
        }
        return $payload;
    }

    public static function invoices_create_api_provider()
    {
        return [
            [['_token' => true], 400], // blank request with token
            [[], 405], // blank request without token
        ];
    }

I know I can hack the CSRF out or disable it or wrap in a try catch finally. I may even just be able to take this from web routes to api routes. I may eventually do that.
Right now I just want to see if I can model what I'm expecting. I've omitted models and 201 cases because my model should be largely irrelevant as should the controller. There is no non-framework code generating 405.
Dusk seems fine with using my create route and form filling. I'm not sure testing should ever bubble up HTTP exceptions

... invoice.store not invoice.create


text:
^ symbol shown with dd method

Laravel Version: 9.1.0
PHP Version: 8.1.3
Database Driver & Version:

Description:

Not sure what you're getting at. If you have any concerns with this please open an issue with symfony's vardumper component.

authors: EslamNemr driesvints


text:
[9.x] Attributes on Auth::user() instance have relationships inside them - they're marked as dirty

Laravel Version: v9.11.0
PHP Version: 8.1.5
Database Driver & Version: 10.5.13-MariaDB - Homebrew

Description:
I've opened a PR attempting to patch this problem #42292
I've detailed everything I could there. I'm happy to get on a call and provide more context, I've tried to explain the problem as best as I could in the PR.

Hey there,
Can you first please try one of the support channels below? If you can actually identify this as a bug, feel free to open up a new issue with a link to the original one and we'll gladly help you out.

Laracasts Forums
Laravel.io Forums
StackOverflow
Discord
Larachat
IRC

Thanks!

authors: driesvints tntsoft


text:
Event faking regression introduced in #49730

Laravel Version
From 11.x-dev#abfd659 on
PHP Version
8.3.3
Database Driver & Version
No response
Description
I'll start by saying that I'm not 100% sure if this is a bug introduced on Laravel's end, or if we should simply somehow update our code to support Laravel 11, but I discovered this while updating dependencies in a PR adding Laravel 11 support to our tenancy package.
1) Stancl\Tenancy\Tests\QueueTest::tenant_id_is_passed_to_tenant_queues
TypeError: Illuminate\Log\Context\Repository::__construct(): Argument #1 ($events) must be of type Illuminate\Events\Dispatcher, Illuminate\Support\Testing\Fakes\EventFake given

/var/www/html/vendor/laravel/framework/src/Illuminate/Log/Context/Repository.php:50
/var/www/html/vendor/laravel/framework/src/Illuminate/Container/Container.php:944
/var/www/html/vendor/laravel/framework/src/Illuminate/Container/Container.php:293
/var/www/html/vendor/laravel/framework/src/Illuminate/Container/Container.php:900
/var/www/html/vendor/laravel/framework/src/Illuminate/Container/Container.php:787
/var/www/html/vendor/laravel/framework/src/Illuminate/Foundation/Application.php:1026
/var/www/html/vendor/laravel/framework/src/Illuminate/Container/Container.php:723
/var/www/html/vendor/laravel/framework/src/Illuminate/Foundation/Application.php:1011
/var/www/html/vendor/laravel/framework/src/Illuminate/Container/Container.php:1446
/var/www/html/vendor/laravel/framework/src/Illuminate/Support/Facades/Facade.php:237
/var/www/html/vendor/laravel/framework/src/Illuminate/Support/Facades/Facade.php:208
/var/www/html/vendor/laravel/framework/src/Illuminate/Support/Facades/Facade.php:351
/var/www/html/vendor/laravel/framework/src/Illuminate/Log/Context/ContextServiceProvider.php:30
/var/www/html/vendor/laravel/framework/src/Illuminate/Queue/Queue.php:308
/var/www/html/vendor/laravel/framework/src/Illuminate/Queue/Queue.php:142
/var/www/html/vendor/laravel/framework/src/Illuminate/Queue/Queue.php:129
/var/www/html/vendor/laravel/framework/src/Illuminate/Queue/Queue.php:107
/var/www/html/vendor/laravel/framework/src/Illuminate/Queue/SyncQueue.php:60
/var/www/html/vendor/laravel/framework/src/Illuminate/Queue/SyncQueue.php:45
/var/www/html/vendor/laravel/framework/src/Illuminate/Bus/Dispatcher.php:254
/var/www/html/vendor/laravel/framework/src/Illuminate/Bus/Dispatcher.php:230
/var/www/html/vendor/laravel/framework/src/Illuminate/Bus/Dispatcher.php:77
/var/www/html/vendor/laravel/framework/src/Illuminate/Foundation/Bus/PendingDispatch.php:193
/var/www/html/vendor/laravel/framework/src/Illuminate/Foundation/helpers.php:388
/var/www/html/tests/QueueTest.php:124

Notice the ContextServiceProvider in the stack trace. The test is just:
/** @test */
public function tenant_id_is_passed_to_tenant_queues()
{
    config(['queue.default' => 'sync']);

    $tenant = Tenant::create();

    tenancy()->initialize($tenant);

    Event::fake([JobProcessing::class, JobProcessed::class]);

    dispatch(new TestJob($this->valuestore)); // line 124

    Event::assertDispatched(JobProcessing::class, function ($event) {
        return $event->job->payload()['tenant_id'] === tenant('id');
    });
}

This test passes on 5e87357 (the commit immediately preceding the PR) but fails from abfd659 on.
Steps To Reproduce
I believe the combination of Event::fake([JobProcessing::class, JobProcessed::class]); and dispatching a job is the cause of this.
Event::fake() (without any events specified) and dispatching a job also seems to cause this. This test fails with the same stack trace:
/** @test */
public function tenant_id_is_not_passed_to_central_queues()
{
    $tenant = Tenant::create();

    tenancy()->initialize($tenant);

    Event::fake();

    config(['queue.connections.central' => [
        'driver' => 'sync',
        'central' => true,
    ]]);

    dispatch(new TestJob($this->valuestore))->onConnection('central');

    Event::assertDispatched(JobProcessing::class, function ($event) {
        return ! isset($event->job->payload()['tenant_id']);
    });
}

Fixed.

Thanks! Can confirm https://github.com/laravel/framework/commit/dde4bfecca6a224dc582eff0f7401ba5ca2de0ad fixed this for us.

authors: stancl taylorotwell