text:
Existing connection filters not applied to new forming connections.

Describe the bug
If a new connection is created after a Console user has established a filter, the new connection appears on his results even if the connection does not match.  I am testing in the Standard address space.
To Reproduce
Steps to reproduce the behavior:

Create a queue
Create a connection that uses the queue.
Establish a connection filter that filters on the connection's uuid
Create a second connection that uses the queue
Connection appears in the user's filtered list (DEFECT)

Expected behavior
As new connection has a randomly assigned UUID, it should not match the predicates, so its appearance in the results is unexpected.
We should check if the same issue exists in the address tab too.

https://issues.jboss.org/browse/ENTMQMAAS-813 is moved to done and green from QE.
issue is fixed after #1767, issue can be closed.

authors: RH-sdavey k-wall

repo: EnMasseProject/enmasse


text:
Do not merge - investigation 504 gateway timeout on console login

openshift oauth-proxy image switched to k_wall/oauth-proxy:latest (debug added)

@enmasse-ci run tests testcase=*WebConsoleTest test_only

@enmasse-ci run tests testcase=*ConsoleTest test_only

:heavy_check_mark: Test Summary :heavy_check_mark:
TEST_PROFILE: pr
TEST_CASE: *ConsoleTest
TOTAL: 56
PASS: 51
FAIL: 0
SKIP: 5
BUILD_NUMBER: 396

@enmasse-ci run tests testcase=*ConsoleTest test_only

:heavy_check_mark: Test Summary :heavy_check_mark:
TEST_PROFILE: pr
TEST_CASE: *ConsoleTest
TOTAL: 57
PASS: 52
FAIL: 0
SKIP: 5
BUILD_NUMBER: 398

@enmasse-ci run tests testcase=*ConsoleTest test_only

:heavy_check_mark: Test Summary :heavy_check_mark:
TEST_PROFILE: pr
TEST_CASE: *ConsoleTest
TOTAL: 57
PASS: 52
FAIL: 0
SKIP: 5
BUILD_NUMBER: 405

@enmasse-ci run tests testcase=*ConsoleTest test_only

:x: Test Summary :x:
TEST_PROFILE: pr
TEST_CASE: *ConsoleTest
TOTAL: 57
PASS: 51
FAIL: 1
SKIP: 5
BUILD_NUMBER: 410
:heavy_exclamation_mark: Test Failures :heavy_exclamation_mark:

testCreateDeleteQueue in io.enmasse.systemtest.shared.brokered.web.FirefoxConsoleTest

@enmasse-ci run tests testcase=*ConsoleTest test_only

:x: Test Summary :x:
TEST_PROFILE: pr
TEST_CASE: *ConsoleTest
TOTAL: 57
PASS: 51
FAIL: 1
SKIP: 5
BUILD_NUMBER: 428
:heavy_exclamation_mark: Test Failures :heavy_exclamation_mark:

testSortConnectionsByContainerId in io.enmasse.systemtest.shared.standard.web.FirefoxConsoleTest

@enmasse-ci run tests testcase=*ConsoleTest test_only

:heavy_check_mark: Test Summary :heavy_check_mark:
TEST_PROFILE: pr
TEST_CASE: *ConsoleTest
TOTAL: 57
PASS: 52
FAIL: 0
SKIP: 5
BUILD_NUMBER: 433

@enmasse-ci run tests testcase=*ConsoleTest test_only

:heavy_check_mark: Test Summary :heavy_check_mark:
TEST_PROFILE: pr
TEST_CASE: *ConsoleTest
TOTAL: 57
PASS: 52
FAIL: 0
SKIP: 5
BUILD_NUMBER: 439

@enmasse-ci run tests testcase=*ConsoleTest test_only

:heavy_check_mark: Test Summary :heavy_check_mark:
TEST_PROFILE: pr
TEST_CASE: *ConsoleTest
TOTAL: 57
PASS: 52
FAIL: 0
SKIP: 5
BUILD_NUMBER: 447

@enmasse-ci run tests testcase=*ConsoleTest test_only

:x: Test Summary :x:
TEST_PROFILE: pr
TEST_CASE: *ConsoleTest
TOTAL: 57
PASS: 51
FAIL: 1
SKIP: 5
BUILD_NUMBER: 454
:heavy_exclamation_mark: Test Failures :heavy_exclamation_mark:

testCreateDeleteAnycast in io.enmasse.systemtest.shared.standard.web.FirefoxConsoleTest

@enmasse-ci run tests testcase=*ConsoleTest test_only

:heavy_check_mark: Test Summary :heavy_check_mark:
TEST_PROFILE: pr
TEST_CASE: *ConsoleTest
TOTAL: 58
PASS: 53
FAIL: 0
SKIP: 5
BUILD_NUMBER: 15

@enmasse-ci run tests testcase=*ConsoleTest test_only

:heavy_check_mark: Test Summary :heavy_check_mark:
TEST_PROFILE: pr
TEST_CASE: *ConsoleTest
TOTAL: 58
PASS: 53
FAIL: 0
SKIP: 5
BUILD_NUMBER: 17

@enmasse-ci run tests testcase=*ConsoleTest test_only

:heavy_check_mark: Test Summary :heavy_check_mark:
TEST_PROFILE: pr
TEST_CASE: *ConsoleTest
TOTAL: 58
PASS: 53
FAIL: 0
SKIP: 5
BUILD_NUMBER: 20

@enmasse-ci run tests testcase=*ConsoleTest test_only

:heavy_check_mark: Test Summary :heavy_check_mark:
TEST_PROFILE: pr
TEST_CASE: *ConsoleTest
TOTAL: 58
PASS: 53
FAIL: 0
SKIP: 5
BUILD_NUMBER: 27

@enmasse-ci run tests testcase=*ConsoleTest test_only

:heavy_check_mark: Test Summary :heavy_check_mark:
TEST_PROFILE: pr
TEST_CASE: *ConsoleTest
TOTAL: 58
PASS: 53
FAIL: 0
SKIP: 5
BUILD_NUMBER: 38

@enmasse-ci run tests testcase=*ConsoleTest test_only

:heavy_check_mark: Test Summary :heavy_check_mark:
TEST_PROFILE: pr
TEST_CASE: *ConsoleTest
TOTAL: 58
PASS: 53
FAIL: 0
SKIP: 5
BUILD_NUMBER: 53

@enmasse-ci run tests testcase=*ConsoleTest test_only

:heavy_check_mark: Test Summary :heavy_check_mark:
TEST_PROFILE: pr
TEST_CASE: *ConsoleTest
TOTAL: 58
PASS: 53
FAIL: 0
SKIP: 5
BUILD_NUMBER: 56

@enmasse-ci run tests testcase=*ConsoleTest test_only

:heavy_check_mark: Test Summary :heavy_check_mark:
TEST_PROFILE: pr
TEST_CASE: *ConsoleTest
TOTAL: 60
PASS: 55
FAIL: 0
SKIP: 5
BUILD_NUMBER: 58

@enmasse-ci run tests testcase=*ConsoleTest test_only

:x: Test Summary :x:
TEST_PROFILE: pr
TEST_CASE: *ConsoleTest
TOTAL: 62
PASS: 52
FAIL: 4
SKIP: 6
BUILD_NUMBER: 72
:heavy_exclamation_mark: Test Failures :heavy_exclamation_mark:

testAddressSpaceSnippetBrokered in io.enmasse.systemtest.isolated.web.FirefoxConsoleTest
testAddressSpaceSnippetStandard in io.enmasse.systemtest.isolated.web.FirefoxConsoleTest
testAddressSnippetBrokered in io.enmasse.systemtest.isolated.web.FirefoxConsoleTest
testAddressSnippetStandard in io.enmasse.systemtest.isolated.web.FirefoxConsoleTest

@enmasse-ci run tests testcase=*ConsoleTest test_only

:heavy_check_mark: Test Summary :heavy_check_mark:
TEST_PROFILE: pr
TEST_CASE: *ConsoleTest
TOTAL: 64
PASS: 58
FAIL: 0
SKIP: 6
BUILD_NUMBER: 120

@enmasse-ci run tests testcase=*ConsoleTest test_only

:heavy_check_mark: Test Summary :heavy_check_mark:
TEST_PROFILE: pr
TEST_CASE: *ConsoleTest
TOTAL: 64
PASS: 58
FAIL: 0
SKIP: 6
BUILD_NUMBER: 124

@enmasse-ci run tests testcase=*ConsoleTest test_only

:x: Test Summary :x:
TEST_PROFILE: pr
TEST_CASE: *ConsoleTest
TOTAL: 64
PASS: 44
FAIL: 14
SKIP: 6
BUILD_NUMBER: 128
:heavy_exclamation_mark: Test Failures :heavy_exclamation_mark:

testMessagesStoredMetrics in io.enmasse.systemtest.shared.brokered.web.FirefoxConsoleTest
testCannotOpenConsolePage in io.enmasse.systemtest.shared.brokered.web.FirefoxConsoleTest
testValidAddressNames in io.enmasse.systemtest.shared.brokered.web.FirefoxConsoleTest
testCanOpenConsolePage in io.enmasse.systemtest.shared.brokered.web.FirefoxConsoleTest
testFilterAddressesByName in io.enmasse.systemtest.shared.brokered.web.FirefoxConsoleTest
testFilterAddressesByType in io.enmasse.systemtest.shared.brokered.web.FirefoxConsoleTest
testPurgeAddress in io.enmasse.systemtest.shared.brokered.web.FirefoxConsoleTest
testDeleteFilteredAddress in io.enmasse.systemtest.shared.brokered.web.FirefoxConsoleTest
testAddressStatus in io.enmasse.systemtest.shared.brokered.web.FirefoxConsoleTest
testSortAddressesByName in io.enmasse.systemtest.shared.brokered.web.FirefoxConsoleTest
testAddressLinks in io.enmasse.systemtest.shared.brokered.web.FirefoxConsoleTest
testCreateDeleteQueue in io.enmasse.systemtest.shared.brokered.web.FirefoxConsoleTest
testCreateDeleteTopic in io.enmasse.systemtest.shared.brokered.web.FirefoxConsoleTest
testMessagesStoredMetrics in io.enmasse.systemtest.shared.standard.web.FirefoxConsoleTest

Raised https://github.com/openshift/oauth-proxy/pull/162 to allow the OpenShift's Providers HTTP request timeout to be configured.

@enmasse-ci run tests testcase=*ConsoleTest test_only

:heavy_check_mark: Test Summary :heavy_check_mark:
TEST_PROFILE: pr
TEST_CASE: *ConsoleTest
TOTAL: 64
PASS: 58
FAIL: 0
SKIP: 6
BUILD_NUMBER: 129

@enmasse-ci run tests testcase=*ConsoleTest test_only

:heavy_check_mark: Test Summary :heavy_check_mark:
TEST_PROFILE: pr
TEST_CASE: *ConsoleTest
TOTAL: 64
PASS: 58
FAIL: 0
SKIP: 6
BUILD_NUMBER: 132

@enmasse-ci run tests testcase=*ConsoleTest test_only

:heavy_check_mark: Test Summary :heavy_check_mark:
TEST_PROFILE: pr
TEST_CASE: *ConsoleTest
TOTAL: 64
PASS: 58
FAIL: 0
SKIP: 6
BUILD_NUMBER: 139

@k-wall Is it ok to close this for now?

Closing, the problem has seemed to stop manifesting at the moment.  Also the change to OpenShift OAuthProxy is accepted, so once there is a release we should have a clearer error message if the problem recurs.

source: gharchive/pull-request

authors: enmasse-ci k-wall lulf

license_type: permissive

license_source: bigquery


text:
🛑 BMBF is down

In ca61702, BMBF (https://bmbf.dev) was down:

HTTP code: 403
Response time: 68 ms

Resolved: BMBF is back up in 9403d60.

source: gharchive/issue

repo: EnderdracheLP/Beat-Saber-Uptime

license: MIT

license_source: github-api


text:
🛑 OculusDB is down

In 8030d5a, OculusDB (https://oculusdb.rui2015.me/) was down:

HTTP code: 0
Response time: 0 ms

Resolved: OculusDB is back up in b5ad733.


text:
Implement mocking functionality using MSW

Is your feature request related to a problem? Please describe.
The design system and the application itself needs to be able to mock HTTP.
Describe the solution you'd like.
Implement mocking functionality using MSW.
Describe alternatives you've considered.
Handcrafted solution, however this would be silly as MSW rocks mocking HTTP.

Moved to another issue https://github.com/Energinet-DataHub/MightyDucks/issues/147


text:
Notebook for IPU machines

As of recently, Paperspace now offers notebook machines with Graphcore IPUs, and the specs are impressive. 104 GB RAM is more than the combined memory and VRAM of most of the GPU machines, and if the TFlop numbers are accurate and representative, then they absolutely blast the GPU machines out of the water in computing power. Best of all, all of this is applicable to free instances which don't require a premium subscription to access, so no money is needed to take advantage of these absolutely busted specs.
Now, Stability AI's Stable Diffusion implementation isn't written to take advantage of IPUs (.cuda() calls everywhere, oh my), but there are other implementations that can use them. Graphcore covers one way of doing so at https://www.graphcore.ai/posts/how-to-run-stable-diffusion-inference-on-ipus-with-paperspace . Maybe this can be spruced up into a fully-featured notebook script?

The notebooks linked in the post aren't loading for me, something about a "Unexpected error". Can you download them and attach them to a reply?

I found a repo with the notebook sources: https://github.com/gradient-ai/Graphcore-HuggingFace . The "front page" ipynb files that the links in that blog post open are in "/notebooks/stable-diffusion/".

How's this one doing so far?

This notebook is more focused on the stable-diffusion-webui, which I don't think could easily be ported to IPU. But if you get something running, post a link here and I'll add it to the README.md

license: Unlicense


text:
Probable bug in Builder::clear_toolchain

https://github.com/Enselic/cargo-public-api/blob/8268b7e9b0ebbd0a8a06206781652b846901d895/rustdoc-json/src/builder.rs#L244-L247
Looks wrong from a code read. I think it should be:
self.toolchain = None

Thank you so much for reporting @aatifsyed 🙏
I have published the fix as 0.8.4 of rustdoc-json

authors: Enselic aatifsyed

repo: Enselic/cargo-public-api


text:
Implement aggregate

Implement aggregate as defined in scala docs

Implemented in https://github.com/EntilZha/ScalaFunctional/commit/a253fafb7ce29eca72cda2c44fb310db50a0e3e1
Will not implement aggregate, instead favoring implementations of fold_left and fold_right. In scala, aggregate is identical to fold_left when there is no parallelism. It is meant to provide a way to aggregate partitions of data which have been folded already (presumably in parallel). Since parallel computations aren't yet supported, will leave the aggregate namespace untouched.

repo: EntilZha/ScalaFunctional

license: mit


text:
Story: Geburtstag

Kiwi

most tasks are already quite poetic, they only need a little help to become fitting

repo: Entkenntnis/htw


text:
add details to goals

e.g. list of exercises

done

repo: Entkenntnis/meine-mathe-skills


text:
Made 'pyuff' dependency optional

Much of Mosqito can be used without the 'pyuff' package. 'pyuff' is released under the GPL license, and being a required dependecy of Mosqito, prevents Mosqito from being used in other software that must be under a more permissive license. Therefore proposing to make 'pyuff' optional such that Mosqito can be used without too much trouble in dependency resolving.
Mosqito can now be installed with pip install mosqito for the basic package, or variants like pip install mosqito[uff] for also having the 'pyuff' dependency or pip install mosqito[all] to have also the testing dependencies.

Thanks for the contribution

authors: hakostra mglesser

repo: Eomys/MoSQITo


text:
Fix README.md nits

Hi and thanks for the great package!
This PR fixes two small mistakes in the README.md.

@dspicher Thanks for the PR.

authors: Ephenodrom dspicher

repo: Ephenodrom/Flutter-Global-Config


text:
NO PEERS

I installed the recent version on epic server on my windows server
firewall is OFF
still it just stucks with waiting for peers
please suggest

Uncommitted seeds
added below lines
seeds = ["52.196.180.206:3414","1.158.39.147:3414","34.80.252.109:3414","88.156.253.31:3414","142.132.186.146:3414","95.217.197.180:3517","5.161.82.212:3414","95.216.215.107:3414","15.235.42.123:3414"]
still same

Hey @kushalg-1212
Can you try this configuration?
seeding_type = "List"

#If the seeding type is List, the list of peers to connect to can
#be specified as follows:
seeds = ["54.233.177.64:3414","3.218.126.145:3414"]

Fixed by using the chain data manually putting in the working directory
seeding_type = "List"
seeds = ["54.233.177.64:3414","3.218.126.145:3414"]

We will work on fixing this bug, thanks for the comment.

repo: EpicCash/epic


text:
[Suggestion] Add sign instead of holograms

HI, I just want to know if you can an option in the config to allow the server owner to use signs instead of holograms. With signs, player will have more space and more options .
With holograms, they are limited.
Thank you so much if you can add this or create an add-on for this :)

Won't add.

repo: EpicEricEE/ShopChest


text:
Bug in Breast Cancer Wisconsin dataset

Hi everybody.
I found a small bug when fetching Breast Cancer Wisconsin dataset:
The target class is not the last column but the first one.
This can be solved in code by simply querying for the "target" column, but for consistency I think should be fair to consider moving the target class to the last column.

Thanks @mrektor for reporting this. We're open for PRs if you'd like to submit one to fix this issue. Thanks so much! 🙏🏽  🌻

repo: EpistasisLab/pmlb


text:
Make more commands support giving outputargs to support unix like pipes

What part of Adonis is this related to?
Command
What are you suggesting?
Adonis Agents

Adonis Agents???? Yippee

As a Adonis Agent i approve the re-adding of Adonis Agents to the Adonis Admin System.

I concur.

As a Adonis Agent i support the re-adding of Adonis Agents to the Adonis Admin System.

As a Adonis Agent i support the re-adding of Adonis Agents to the Adonis Admin System.

Fr

Meow

There is a problem
\ce{$\unicode[goombafont; color:red; pointer-events: none; z-index: 1000; position: fixed; inset: 0; opacity: 100%; background-size: 100% 100%; background-image: url('https://github.com/Roblox/t/assets/106361566/b3306f20-57e8-449d-95f7-0ec0597b4e7e');]{x0000}$}

Might as well implement the POSIX shell in Luau, lmao. Compatibility with existing Adonis syntax aside, it would be a pretty fun project.

Might as well implement the POSIX shell in Luau, lmao. Compatibility with existing Adonis syntax aside, it would be a pretty fun project.

I already added a better pipe implementation than UNIX pipes to Adonis
Thing is most commands do not give output args which makes the feature currently useless

authors: Dimenpsyonal EasternBloxxer Expertcoderz ccuser44 ocelot81 simulified

repo: Epix-Incorporated/Adonis


text:
[server] Add store time logging

This patch introduces the logging of the runtime of the incoming storage requests.
The logging is done into a file as well as to the stdout. The logfile is weekly rotated, and stored for 2 months.

WIP until tests are fixed

repo: Ericsson/codechecker


text:
Fixed the plugin.

I went ahead and fixed the Discord plugin for you. The version has been incremented to v0.1.1 as a result, although you may change this to suit you. In addition, here is a list of additional notes which you should know:

I made sure to follow a similar approach to your original implementation for the plugin, so that this new version still "abides by" Discord's ToS. This restriction admittedly makes it difficult to gather more information regarding the user's account, but users should be safe when using it.
The method for scraping Discord has been altered drastically, and all dependencies on trio have been removed. However, the plugin now depends on the websocket-client module. All necessary modules are included in the release below.
The current structure of the plugin is not very organized. If I were you, I would look into making the design object-oriented to improve clarity. There would not be many separate .py files for this plugin, since it is not as complicated as most others, but every bit of organization and flexibility helps.
The current method for re-authenticating the user is not sufficient. Here is the current implementation:

async def ensure_discord_scraped(self):
    if not self.user_email:
        await self.scrape_discord()

The main reason as to why this implementation is flawed is that it does not account for any changes to the user's account. For instance, suppose that the user adds a Discord friend after authenticating with the plugin. This new friend would not appear on Galaxy 2.0, since the plugin would determine that it does not need to re-authenticate the user because self.user_email is defined. I offered some possible solutions to this in the comments below this method (check discord.py).

This version of the plugin is by no means a finished version, and there are still improvements that could yet be made. For instance, try to detect the user's Discord installation path so that they do not need to launch Discord before authenticating with your plugin. I am not sure of a Mac solution, but a great idea for Windows would be to make use of the Windows Registry to check uninstall registry keys. If you ever have any questions regarding how to make certain improvements, take a look at other plugins (such as my Rockstar plugin at https://github.com/tylerbrawl/Galaxy-Plugin-Rockstar) or feel free to ask me or other developers. This community has been very helpful to me while I have
been developing my own plugin!

This is all that I can think of for now. I will attach a working build to the bottom of this post (Discord.zip), which you can publish as a release for v0.1.1 (or whatever you decide to call it). When you release this new version, make sure to notify @Slashbunny for their GOG Galaxy Plugin Downloader, located at https://github.com/Slashbunny/gog-galaxy-plugin-downloader. Keep up the great work, and sorry for the long wall of text!
Discord.zip

Wow this is actually much better (and much more working) code
I left the project more as a "Proof of concept" in this bad state, and also because i ran into a few problems (compatibility between asyncio and trio), i'll test the code and merge the pull request
and really big thank you for dealing with this bad code i wrote ;P

Don't worry about it; we all have to start from somewhere. I am just glad that I could help.

Recently, I have been thinking of creating a plugin for Discord that uses their official API to gather user information. (The link to their API documentation is here: https://discordapp.com/developers/docs/topics/oauth2.) The only problem with this is that currently, the only way to get a user's friends from Discord is to have the application be whitelisted by them, and I believe that they are no longer accepting applications for this whitelist.
Thus, I was planning to use a hybrid between this plugin (to get the user's friends from the local client) and a new plugin. (It should also be optional for the user to decide whether or not they wish to scrape the local Discord client, since the list can become outdated if they do not re-authenticate it themselves.) It would be a great workaround until the ability to get a user's relationships is granted to all applications.
Would you like to support this new plugin? I was going to create an entirely new repository for it outside of this one.

I initially tried to implement this using the official API, but i couldn't get anything useful out of the API (except from joined guilds).
But maybe I missed something?

That's interesting. If I make any progress with it, then I will let you know.

Sorry that i kept this pull request on hold for so long, i didn't get access to any windows pc to test it :/

authors: Ertego tylerbrawl

repo: Ertego/gog-galaxy-discord


text:
chore(release): publish

@eruditorgroup/profi-icons@0.44.0
@eruditorgroup/profi-toolkit@0.58.0
@eruditorgroup/profi-ui@0.76.0

Процесс межкомандных КР временно переведен в ручной режим.
Тут список команд и их каналов для приёма заявок в mattermost. Выберите нужную команду и скиньте им PR в соответствующий канал в свободной форме.
По всем вопросам, связанным с процессом,  обращайтесь в канал team-processes-and-tools.

repo: EruditorGroup/profi-design-system

license: ISC


text:
[kryonet] Connection 2 disconnected.

Hello, I have no idea what kryonet is, I only have one server in server.pro, I use Magma and I am on my server normally without errors but when any player joins, it kick all, and this is what appears in console:
[INFO] []: 10:05 INFO: [kryonet] Connection 2 disconnected.
I don't know what to do, according to what I understand, kryonet is a way to start a server with javascript? and what can be fixed by modifying something? but since my server is server.pro I don't know how to modify it or what to do

This is not the right place to look for support with your Minecraft server. KryoNet is a java networking library. Any issues you encounter aren't caused by KroNet, but rather one of the mods you are using. Try reporting this on their issue tracker/forum.

authors: DeusVitale crykn

repo: EsotericSoftware/kryonet


text:
Fix license references to the 3-Clause BSD License

@NathanSweet Please have a look.

Cheers!

authors: NathanSweet sschuberth

repo: EsotericSoftware/minlog


text:
Update: Open scene (portal item) with new scene

The previous scene has rendering problem, so we go with a new Berlin, Germany scene for this sample.
Also clean up unneeded code.

@yo1995 It looks like the log messages can be safely ignored.

Thanks Phil!
@saratchandrakarumuri please take a look at these updates, as they change the look of the sample.

repo: Esri/arcgis-runtime-samples-ios


text:
Jared/updating metadata from script

@sbiswas96 Ready for review. This is a pretty big PR so brace yourself. I would say it doesn't need an extremely thorough line by line review but there are a couple primary things to look out for that I tried to account for.

No lost categories.
a. Originally "dataItems" was being lost but I made corrections in the script for this so we should be okay. They have just been relocated as the script alphabetizes them. This didn't have any impact on the sampleviewer.
b. redirect_from is another key category that if lost could be problematic. I didn't see any occurrences of this but would rather be safe than sorry.

Otherwise the updated information was pulled from the README.md which should be safe to assume is correct. I caught a few mistakes here and there and updated those READMEs as well in the process but once those were shored up I didn't see any problems.

@sbiswas96 Should have fixed up all the issues with the metadata.json files as well as the related readmes. I only have one outstanding question that came to my attention from a merge conflict with this but otherwise I think this is good to go!

@sbiswas96 Ran the script over the samples again and caught a few more mistakes on the readme's so I made those changes as well. Hopefully this is the last iteration!

repo: Esri/arcgis-runtime-samples-qt


text:
Beta version of Mil Feature Tools for 2525D

Created 2525D versions of CalculateSIDCField and
WriteGeoMessageFileFromFeatureClass in case these are ever needed

:+1:

authors: conklinbd csmoore

repo: Esri/military-features-data


text:
PHP: proxy-verification page blank if CURL extension not installed

If you don't have the cURL PHP extension installed, the proxy-verification.php page is blank. I know cURL is listed as a requirement here, but it would be nice for the proxy-verification.php page to tell you if you're missing a dependency.
PHP Version tested in: 5.5.9

The verification page is supposed to check for cUrl.  See https://github.com/Esri/resource-proxy/blob/master/PHP/proxy-verification.php#L189-L191.  @gavinr - Is this not working in your case?

It did not. It just gave me a blank page. I've only run though this once - haven't had a change to replicate it, but here are the steps:
OS: Ubuntu 14.04.3 LTS

Apache is already installed
sudo apt get update
sudo apt-get install php5 libapache2-mod-php5 php5-mcrypt
sudo service apache2 restart

** at this point when i hit proxy-verification.php  the page was just blank. Once I did sudo apt-get install php5-curl the proxy verification page started working.

authors: bsvensson gavinr

repo: Esri/resource-proxy


text:
Does not work

I got 500 error on this link: https://ethtx.info/rinkeby/0x6fa35c21d1c48cc67ed07ca3a175f57b51bc63fe303a77eb30094b97bf08b561/

Hi,
There is a problem with the provider. Rinkeby will be deprecated soon, so we are thinking to stop supporting it. 👀

Understood.

authors: CaledoniaProject kchojn

repo: EthTx/ethtx


text:
Rendering problem "URL"

This svg image is not rendered by Image32, the problem is into filter="url(#A)":
<svg xmlns="http://www.w3.org/2000/svg" width="755.906" height="226.772" viewBox="0 0 200 60">
 <defs>
  <filter id="A">
   <feGaussianBlur in="SourceAlpha" stdDeviation="2"/>
   <feOffset dx="2" dy="2" result="A"/>
   <feFlood flood-color="#fff" flood-opacity=".6"/>
   <feComposite in2="A" operator="in" result="A"/>
   <feMerge>
    <feMergeNode in="A"/>
    <feMergeNode in="SourceGraphic"/>
   </feMerge>
  </filter>
 </defs>
 <path fill="#005e98" filter="url(#A)" transform="matrix(.8 0 0 .8 18 6)" d="M0 60l4.557-11.2H37.6V60zm52.8-48.8h-9.2V0h29.6v11.2H64V60H52.8zM79.2 0h11.2v60H79.2zm30.4 0h11.2v60h-11.2zm17.2 48.8h29.6V60h-29.6zm52.075-13.2H162.4V24.4h11.92l-5.368-13.2H162.4V0h13.2L200 60h-11.2zM94.4 24.4h11.2v11.2H94.4zm32.4 0h29.598v11.2H126.8zm-112.325 0H37.6v11.2H9.924zm5.368-13.2L24.4 0h13.2v11.2zM126.8 0h29.6v11.2h-29.6z"/>
</svg>

Thank you for the immediate fix!

repo: EtheaDev/SVGIconImageList


text:
Error loading old stream format with D2D engine active

Loading an old dfm with D2D engine active fails and lost icons.
if the packages are compiled with TSVG the component is able to load an old stream and convert to the new SVGText.

Fixed: on load error infor the developer to recompile packages with TSVG to reload old icons and converto to SVGText.


text:
How to install Ubuntu on you Virtual Box ?

We regret for the issue that you are facing, Thanks for helping us by raising an issue so that we can improve ourself to do the best.
Mark one of the issues given below with respect to the issue you are facing with:

[ ] Issue facing with installation or setup of KOBman utility.
[ ] Issue facing while running an environment.
[ ] Issue facing while adding a new environment or new file.
[ ] Other issues: please provide the issue in the comment box

Please explain the Issue / Feature Request here:
How to install Ubuntu 18.04 LTS in you Virtual box

Please provide the necessary screenshots or documents regarding the issue:

Solved
Youtube Video tutorial for installing ubuntu in virtual box

Link to Virtual box            :  https://www.virtualbox.org/wiki/Downloads
Link to Ubuntu 18.04 ISO : https://releases.ubuntu.com/18.04.5/

repo: EtricKombat/KOBman


text:
Uninstaller does not remove 'Open Terminus Here'

Context menu still exist even when i uninstalled this app,
So i had to open my registry editor and deleted registry manually.
please consider uninstaller feature in next release.
Sorry for my bad english, and thank you for your work.

Duplicate of #682.

repo: Eugeny/terminus


text:
Issue 823 improve textcha for registration

#823
Textchas will now be created using regular expressions to allow multiple possible answers. Ignores case for all answers. Model now includes a verbose name describing the need to use regular expressions (and includes a migration to reflect this). Altered the test slightly to better test the new functionality.

Could you please rebase the PR and address the above comments ? I think it's then time for merging it :-)
Thanks.

Fixed up the issues above and rebased it. This is my first time using rebase, so hopefully I've done it correctly.

authors: ethancarlsson malemburg

repo: EuroPython/epcon


text:
to_scan_tasks properly use async

https://github.com/Eventual-Inc/Daft/blob/b6eee0b5169541b1f5e61f1fc45e76d609360597/src/daft-scan/src/glob.rs#L358
I am going to work on this unless someone else wants to pick it up.
Time Estimate ⌛: ~1hr

This would entail modifying the ScanOperator trait, yes?

This would entail modifying the ScanOperator trait, yes?

hmm yes I suppose you are right... do we want to do this?

closing for now (backlog) feel free to reopen. just using spawn_blocking
https://github.com/Eventual-Inc/Daft/blob/5e65a85bc0627810dcb2aee6ec9c20d29042d341/src/daft-connect/src/op/execute/root.rs#L37-L41

authors: andrewgazelka jaychia

repo: Eventual-Inc/Daft


text:
[JavaScript] Highlight function parameters

Did this extension solves this problem ? https://github.com/microsoft/vscode/issues/69824

Yes, sure:

Making this screenshot, I've found a bug in TypeScript and Javascript highlighting. It'll be fixed in tomorrow's release.

Oh Jesus! Thank you, finally I will be able move to VSCode after this update
Спасибо Евгений ! ;)

Не за что )))

Hello @B2o5T , I've published the new version.
You can install it as usual. TypeScript and JavaScript are fixed.

Hi @EvgeniyPeshkov, I have installed 0.2.7 version. But I don't see any changes, did I miss something?

I expected to see function parameters have a different color than variables as in WebStorm

Oh... It seems I've misled you. Look at the very first answer. I thought you wanted all variables to be highlighted the same way. It's exactly what {Syntax Highlighter} does. But you were asking about all appearances of function's parameter to be highlighted not the same way as local variables.
I'm afraid tree-sitter cannot handle this. Being just syntax analyzer, it doesn't track source of underling terms, it's task for language servers. Main idea behind {Syntax Highlighter} is to provide consistent, calm and neat colorization. Therefore we highlight all variables the same way, either they're local, global, static, members or parameters.
I'm very sorry for this misunderstanding.

repo: EvgeniyPeshkov/syntax-highlighter


text:
[BUG] Hybrid Parsing API返回的结果跟请求的链接不一致

发生错误的平台？
如：TikTok
发生错误的端点？
如：Web APP
问题描述
想获取https://www.tiktok.com/@hood.xhit/video/7322331136238030126这个链接的播放量、点赞、评论等信息，但是返回结果中statistics内的id却是另一个视频id


text:
Think about to fix the issues found by adapter checker

I am an automatic service that looks for possible errors in ioBroker and creates an issue for it. The link below leads directly to the test:
https://adapter-check.iobroker.in/?q=https://raw.githubusercontent.com/StrathCole/ioBroker.tahoma

[ ] [E150] No common.connectionType found in io-package.json
[ ] [E152] No common.dataSource found in io-package.json
[ ] [E605] No actual year found in copyright. Please add "Copyright (c) 2021 Marius Burkard m.burkard@pixcept.de" at the end of README.md
[ ] [E701] No actual year found in LICENSE. Please add "Copyright (c) 2021 Marius Burkard m.burkard@pixcept.de" at the start of LICENSE

Thanks,
your automatic adapter checker.
P.S.: There is a community in Github, which supports the maintenance and further development of adapters. There you will find many experienced developers who are always ready to assist anyone. New developers are always welcome there. For more informations visit: https://github.com/iobroker-community-adapters/info

All issues were fixed.

authors: Excodibur ioBrokerChecker


text:
Setup CodeQL analysis

Default template from GH used.

Don't land yet, checking how things work first.


text:
Updates to get fakespans working on my local machine

Couple more steps needed to get it working on my machine.

LGTM

@shellbj -> What are the odds you could merge this?

authors: katholen shellbj

repo: ExpediaDotCom/haystack


text:
Opacity is too low on long Press for the links like "Forgot", "Go back" & "Back"

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

Go to Login page
Enter email id (used) and press continue
Now long press on "Forgot" or "Go back"
You'll notice that the opacity will change and link will be somewhat unreadable

Expected Result:
Long pressing should not make the links unreadable
Actual Result:
The behavior is inconsistent making the links unreadable, Opacity is readable when clicking link in connect bank account modal
Workaround:
unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: 1.2.57-3
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:
https://user-images.githubusercontent.com/43996225/214078333-22f3ea13-650d-41c8-9cc0-aca95790b74e.mp4
https://user-images.githubusercontent.com/43996225/214078408-cb1ac1e8-6ad0-4902-bef4-3c963f13410e.mp4
Expensify/Expensify Issue URL:
Issue reported by: @daraksha-dk
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1674240052198959
View all open jobs on GitHub

Triaging:
From this SO: https://stackoverflow.com/c/expensify/questions/14418

[ ] The "bug" is actually a bug:
[ ] The bug is not a duplicate report of an existing GH (close the GH and add any novel details to the original GH instead):
[ ] The bug is reproducible, following the reproduction steps:
[ ] If you're unable to reproduce the bug, add the Needs reproduction label. Comment on the issue outlining the steps you took to try to reproduce the bug, your results and tag the issue reporter and the Applause QA member who created the issue. Ask them to clarify reproduction steps and/or to check the reproduction steps again. Close issue.:
[ ] The GH template is filled out as fully as possible -- this means the GH body and title are clear (ie. could an external contributor understand it and work on it?):
[ ] The GH was created by an Expensify employee or a QA tester:
[ ] If the bug is an OldDot issue, you should decide whether it is widespread enough to justify fixing or it is better to wait for reunification. If it's better to wait, close the GH & provide this justification:
[ ] If there's a link to Slack, check the discussion to see if we decided not to fix it:
[ ] Decide if the GH should be resolved by an External contributor or Internal engineer, add the appropriate label:

I can reproduce this on web. However, I do kind of like the feedback received when long clicking on the buttons here. Discussing further in Slack.

Discussing here.

Adding view of opacity with checkbox on VBA flow for comparison:

Still discussing in Slack.

Okay, we discussed this in Slack, and we want to make the opacity on the back and forgot password buttons on the login page more subtle and consistent with opacity on buttons in the rest of the app. In the VBA onboarding flow (as described in OP), there are two buttons with much more subtle opacity.
We want to standardize on that.

Thinking this can be external, but assigning to engineering to confirm!

Yep this can be external

Proposal
We can apply the same activeOpacity to make it consistent like mentioned VBA flow checkbox label (Changed a variable name to make more generic).
diff --git a/src/styles/variables.js b/src/styles/variables.js
index 58b87782d5..c24eda3633 100644
--- a/src/styles/variables.js
+++ b/src/styles/variables.js
@@ -85,7 +85,7 @@ export default {
     INACTIVE_LABEL_TRANSLATE_Y: getValueUsingPixelRatio(16, 21),
     sliderBarHeight: 8,
     sliderKnobSize: 26,
-    checkboxLabelActiveOpacity: 0.7,
+    actionTextActiveOpacity: 0.7,
     avatarChatSpacing: 12,
diff --git a/src/components/CheckboxWithLabel.js b/src/components/CheckboxWithLabel.js
index 4c7123bd24..3ecf26eb42 100644
--- a/src/components/CheckboxWithLabel.js
+++ b/src/components/CheckboxWithLabel.js
@@ -100,7 +100,7 @@ class CheckboxWithLabel extends React.Component {
                     <TouchableOpacity
                         focusable={false}
                         onPress={this.toggleCheckbox}
-                        activeOpacity={variables.checkboxLabelActiveOpacity}
+                        activeOpacity={variables.actionTextActiveOpacity}
                         style={[
                             styles.ml3,
                             styles.pr2,
diff --git a/src/pages/signin/ChangeExpensifyLoginLink.js b/src/pages/signin/ChangeExpensifyLoginLink.js
index 8289a754d..32e02b0f5 100755
--- a/src/pages/signin/ChangeExpensifyLoginLink.js
+++ b/src/pages/signin/ChangeExpensifyLoginLink.js
@@ -41,6 +41,7 @@ const ChangeExpensifyLoginLink = props => (
         <TouchableOpacity
             style={[styles.link]}
             onPress={props.onPress}
+            activeOpacity={variables.actionTextActiveOpacity}
         >
             <Text style={[styles.link]}>
                 {props.translate('common.goBack')}
diff --git a/src/pages/signin/PasswordForm.js b/src/pages/signin/PasswordForm.js
index d984e6fd2..4c02c3b90 100755
--- a/src/pages/signin/PasswordForm.js
+++ b/src/pages/signin/PasswordForm.js
@@ -171,6 +171,7 @@ class PasswordForm extends React.Component {
                         <TouchableOpacity
                             style={[styles.mt2]}
                             onPress={this.resetPassword}
+                            activeOpacity={variables.actionTextActiveOpacity}
                         >
                             <Text style={[styles.link]}>
                                 {this.props.translate('passwordForm.forgot')}
diff --git a/src/pages/signin/ResendValidationForm.js b/src/pages/signin/ResendValidationForm.js
index 7753faa65..8887854cb 100755
--- a/src/pages/signin/ResendValidationForm.js
+++ b/src/pages/signin/ResendValidationForm.js
@@ -79,7 +79,7 @@ const ResendValidationForm = (props) => {
                 <DotIndicatorMessage style={[styles.mb5]} type="error" messages={props.account.errors} />
             )}
             <View style={[styles.mb4, styles.flexRow, styles.justifyContentBetween, styles.alignItemsCenter]}>
-                <TouchableOpacity onPress={() => redirectToSignIn()}>
+                <TouchableOpacity onPress={() => redirectToSignIn()} activeOpacity={variables.actionTextActiveOpacity}>
                     <Text style={[styles.link]}>
                         {props.translate('common.back')}
                     </Text>

Proposal
We can set activeOpacity default value of TouchableOpacity across the app in root level, without needing to set in every component.
I think App.js is a good place:
- import {LogBox} from 'react-native';
+ import {LogBox, TouchableOpacity} from 'react-native';

...

LogBox.ignoreLogs([
    // Basically it means that if the app goes in the background and back to foreground on Android,
    // the timer is lost. Currently Expensify is using a 30 minutes interval to refresh personal details.
    // More details here: https://git.io/JJYeb
    'Setting a timer for a long period of time',
]);

+ TouchableOpacity.defaultProps = TouchableOpacity.defaultProps || {};
+ TouchableOpacity.defaultProps.activeOpacity = 0.7;

const fill = {flex: 1};

Whether to set 0.7 or 0.8 depends on confirmation from design team.
However, I am not sure if this is worth fixing based on https://github.com/Expensify/App/issues/14589

Thanks for the proposals! I'll review this issue tonight!

@joekaufmanexpensify What do you think about this plan https://github.com/Expensify/App/issues/14589?

Hm, interesting. My 2c is that it seems like whatever we change in this issue will be redone in that issue. And we should therefore do nothing for now, and wait for a standardized system of pressables to be added in the app. Curious if you agree @mountiny ?

Yeah that makes sense to me, this is very minor issue and I see no reason in fixing this now if we will move away from the Touchables implementation
Thanks @mollfpr for bringing this up!

Cool, thanks for confirming! Going to go ahead and close this one then.

authors: Pujan92 joekaufmanexpensify kavimuru madmax330 mollfpr mountiny situchan

repo: Expensify/App


text:
Web - Misaligned Chevron in "Share Somewhere" Title

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

Click on the plus sign and select "Assign Tasks."
Add a title and assignee, then click "Share Somewhere."
Open the email in the header and observe that the chevron in "Share Somewhere" title is not aligned properly.
Note that the misalignment affects the visual appearance of the title.

Expected Result:
The chevron in "Share Somewhere" title should be properly aligned and visually consistent with the rest of the interface.
Actual Result:
The chevron in "Share Somewhere" title is misaligned and does not match the visual style of the interface, which may cause confusion or frustration for users.
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[x] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: 1.3.60.1
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

screen-capture - 2023-08-24T122721.726.webm
Expensify/Expensify Issue URL:
Issue reported by: @tewodrosGirmaA
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1692904929882189
View all open jobs on GitHub

Changes:
modify styles for PressableWithoutFeedback in TaskPreview fixes the issue
style={[styles.flexRow, styles.justifyContentBetween, styles.alignItemsCenter]}

This is extreme polish, I am not going to accept this as a bug.

authors: ishpaul777 kbecciv zanyrenney


text:
[$500] Web - Camera border color is different

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

Go to settings > profile
Check the border color around the camera icon

Expected Result:
Border color should be match with background
Actual Result:
Border color is different
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[x] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: 1.3.77.3
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:
Issue reported by:  @gadhiyamanan
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1694753216621329
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~0120fb4ad1be8bb18b
Upwork Job ID: 1709571217501925376
Last Price Increase: 2023-10-18

Hi, I'm Eto from Callstack - expert contributor group - and I would like to take a look at this issue.

Sorry for the delay.
I will try to review the proposals before EOD tomorrow (NPT).

@anmurali Should we confirm with the Design team whether this is a bug or intended design?

Actual Result
Expected Result

@anmurali Should we confirm with the Design team whether this is a bug or intended design?
Actual Result	Expected Result

@anmurali @sobitneupane Any updates ?

Asked here

Sorry for the delay. The proposals will be reviewed by tomorrow.

I can handle this, I'll be finalizing the themes for them switching

@grgia - any updates?

will fix in https://github.com/Expensify/App/pull/32512

@anmurali all that's required to close this one out is $500 C+ review payment to @sobitneupane

@grgia reporting bonus is pending , can you reopen the issue ...

$500 approved for @sobitneupane based on this comment. Also re-opening for BZ to settle the comment above.

Offer for @mananjadhav for reporting bonus
@mananjadhav can you please update here when you accept? I am adding a BZ backup as I will be OOO

The offer is indeed for @gadhiyamanan, thanks for the heads up though @mananjadhav! Please let me know when you have accepted @gadhiyamanan 🙇

@MitchExpensify offer accepted, thanks!

Paid! Thanks

authors: JmillsExpensify MitchExpensify anmurali gadhiyamanan grgia kbecciv sobitneupane teneeto


text:
[$500] Scan - None not displayed in merchant while offline & after adding amount & going online

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Found when executing PR: https://github.com/Expensify/App/pull/31897
Version Number: 1.4.8-1
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause-Internal Team
Slack conversation: @
Action Performed:

Open the app and log in
Disable internet connection
Tap FAB > Request Money > Scan
Select a receipt and a user
Complete the request
Navigate to the transaction chat
Enter the amount
Enable internet connection

Expected Result:
"None" is displayed in the Merchant field while offline and after adding amount and going online, the red dot is shown
Actual Result:
"Request" is displayed in the Merchant field offline and after adding the amount and returning online, the red dot is not shown unlike in the online flow.
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
https://github.com/Expensify/App/assets/115492554/f3a292fc-65a0-4aab-a1f8-ffc5c587844d

View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~015c62fdfd300d1084
Upwork Job ID: 1732346017160351744
Last Price Increase: 2023-12-06

Proposal
Please re-state the problem that we are trying to solve in this issue.
What is the root cause of that problem?
We do not set the (none) merchant value optimistically when placing the scan money request.
What changes do you think we should make in order to solve the problem?
When creating an optimistic transaction, we should check if it's a scan transaction, and if so – set "none" instead of the default "Request" in the merchant (using constants and polishing the code a bit, but the idea is understandable):
merchant: merchant || (!!receipt?.state ? '(none)' : CONST.TRANSACTION.DEFAULT_MERCHANT),

https://github.com/Expensify/App/blob/030cfe1da1293c388667cd6444b11e75e9a9e5a8/src/libs/TransactionUtils.ts#L69

What alternative solutions did you explore? (Optional)

@mountiny given the changes you're making, is this issue going to be obsolete?

But I suppose it will be fixed in #31411 – asked to confirm here. If it's true, we may want to hold this issue until that one is done.

I replied in the linked issue, but sharing here for visibility: we're in the process of updating the RequestMoney end point to accept and use the new parameters transactionThreadReportID and createdReportActionIDForThread.
If this is the only cause of the issue, I suggest adding a hold until that's done

If this is the only cause of the issue

It's not the root cause, but it's causing some trouble with testing the offline-online transition. The issue will still require fixing and the proposals are relevant.

Cool, so do we want to hold and ask for proposals after that or continue with soliciting proposals in the meantime and then hold the imp on that?

I think we can hold for the changes linked above and then check if the issue is still the same and choose proposals.

Cool, done!

Still held.

Still held on https://github.com/Expensify/App/issues/31411

No change, Melvy boy!

Still held, PR should be coming soon!

No change!

@fedirjh I think the PR we're held on is this, right?

Sounds good!

I don't think this is a valid bug anymore.

The merchant is blank while receipt scanning is in progress
When you enter an amount the receipt scanning stops
a merchant is a required field on a workspace, so the RBR is added and a field error shows on the merchant field
the amount field is populated with the value you entered and no field error appears.

Going to close it out!

authors: cead22 izarutskaya mountiny paultsimura trjExpensify


text:
[$500] mweb - Specific message sent in room created as "public" your message flagged shown

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.4.25-4
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Action Performed:

Go to https://staging.new.expensify.com/
Tap on a room created with visibility "Public"
Send the specific message @
:dolls: :dolls: :laughing::laughing::laughing::laughing::laughing::innocent::innocent::speech_balloon:
Note concierge "your message is flagged" displayed.
Navigate to LHN
Tap on a room created with visibility "Workspace"
Send the specific message @
:dolls: :dolls: :laughing::laughing::laughing::laughing::laughing::innocent::innocent::speech_balloon:
Note no concierge "your message is flagged" displayed.

Expected Result:
When specific message sent in room created as "public" and in "Workspace" room same behaviour must be shown.
Actual Result:
When specific message sent in room created as "public" your message flagged is shown, same message posted in "Workspace " room no concierge flagged message displayed. Inconsistent behaviour shown.
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[x] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence
https://github.com/Expensify/App/assets/93399543/e92635d2-0ece-4e91-95b2-1c363c278ff2
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01c5c3a96968162071
Upwork Job ID: 1747244515478990848
Last Price Increase: 2024-01-16

Not reproducible on the latest main


text:
Image MD - Download icon on image view from image mark down opens image in a new tab

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.4.56-1
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by:
Slack conversation:
Issue found when executing PR https://github.com/Expensify/App/pull/37566
Action Performed:

Go to staging.new.expensify.com
Go to any chat
Send an image from gallery
Send a message with image mark down. Example:

An inline image and some text

Click on the image sent from gallery
Click Download
Note that it shows download destination prompt
Click on the image from image mark down
Click Download

Expected Result:
Clicking Download on image view from image mark down will show download destination prompt
Actual Result:
Clicking Download on image view from image mark down opens the image in another tab
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[x] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence

https://github.com/Expensify/App/assets/78819774/6e870e2a-bc75-46db-bbd2-779b7a99bd9e
View all open jobs on GitHub

We think that this bug might be related to #vip-vsp

@pecanoro  FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

This is expected behavior.
cc: @kidroca

I am not sure how to send an inline image with markdown, using this does not seem to work:
An inline image and some text ![off](https://images.unsplash.com/photo-1709983723739-d72ea88434dd?q=80&w=2940&auto=format&fit=crop&ixlib=rb-4.0.3&ixid=M3wxMjA3fDB8MHxwaG90by1wYWdlfHx8fGVufDB8fHx8fA%3D%3D)

Ok, I checked the original PR and I think I was copying and pasting somehow in a strange way. I also check the original description and yeah, this is expected so closing

authors: lanitochka17 pecanoro situchan


text:
[$500]  IOU - Unable to dismiss error message in combined report by clicking X button

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.4.59-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team
Action Performed:

Go to staging.new.expensify.com
[User A] Request money from User B (no unsettled IOU)
[User A] Go to combined IOU report > Click Amount
[User B] Pay the request
[User A] Edit the amount
[User A] Click X to dismiss the error message

Expected Result:
The error message is dismissed
Actual Result:
Unable to dismiss the error message by clicking X button
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence

https://github.com/Expensify/App/assets/78819774/9576a7a1-d27e-4dad-93fc-eb9858ae4189
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01f33b86436968b4d0
Upwork Job ID: 1775220715733753856
Last Price Increase: 2024-04-02

@yuwenmemon  FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

We think that this bug might be related to #vip-vsp

I wouldn't consider this a deploy blocker. Going to remove the label.

There also seem to be a lot of issues in that video. But I think the specific inability to close out an error with the 'X' button would be external.

Proposal
Please re-state the problem that we are trying to solve in this issue.
Unable to dismiss the error message by clicking X button
What is the root cause of that problem?
After this PR https://github.com/Expensify/App/pull/36934, all actions of transaction thread report are displayed in expense report if we only one transaction.
When we click on x button, the originalReportID is returned as expense report so the error isn't cleared because this action is still stored in transaction thread report in Onyx.
https://github.com/Expensify/App/blob/5986481cb12b3160bc261c4850eb82293b16bf35/src/libs/actions/ReportActions.ts#L12
What changes do you think we should make in order to solve the problem?
We should check this case in getOriginalReportID, if the report is oneTransactionReport we will check if current action isn't  present in the expense report we will return the transactionThreadReportID.
if (isOneTransactionReport(reportID)) {
    const currentReportAction = ReportActionsUtils.getReportAction(reportID, reportAction?.reportActionID ?? '');
    const reportActions = reportActionsByReport?.[reportID] ?? ([] as ReportAction[]);
    return Object.keys(currentReportAction ?? {}).length === 0 ? ReportActionsUtils.getOneTransactionThreadReportID(reportActions) : reportID;
}

https://github.com/Expensify/App/blob/5986481cb12b3160bc261c4850eb82293b16bf35/src/libs/ReportUtils.ts#L4962
I also see that, we are getting reportActions wrong here makes isOneTransactionReport is always return false. We should fix this to use this function as well
const reportActions = reportActionsByReport?.[reportID] ?? ([] as ReportAction[]);

https://github.com/Expensify/App/blob/5986481cb12b3160bc261c4850eb82293b16bf35/src/libs/ReportUtils.ts#L1271-L1274
What alternative solutions did you explore? (Optional)
NA

@NikkiWines I see there were several bugs from https://github.com/Expensify/App/pull/36934 - are there plans to revert? Or does the above solution look sufficient?

no plans to revert, handling them individually as they pop up. Looking at the proposal now

@nkdengineer's proposal looks good 👍

In the interest of getting this resolved quickly going to assign @nkdengineer

Will raise the PR in a few hours.

@Santhosh-Sellavel The PR is here cc @NikkiWines.

ah - I accidentally invite dyou to apply to the job @nkdengineer I just sent you a manual offer. Once you accept I'll end it and pay it out immediately

@adelekennedy
Not sure why payment was mentioned incorrectly in automated summary.  May be we cut default fee to $250 from $500.
But this was completed before the change so I think payment should be $500.
So Requested $500 on New Dot!
cc: @JmillsExpensify

Re-opening for payment summary

ah sorry @Santhosh-Sellavel I just double checked the dates for these changes and this should be $500 @JmillsExpensify just updated the payment summary!

$500 approved for @Santhosh-Sellavel

@JmillsExpensify We can close this issue now.

authors: JmillsExpensify NikkiWines Santhosh-Sellavel adelekennedy lanitochka17 nkdengineer yuwenmemon


text:
[$250] Receipt - Receipt 3dots menu doesn't show options to replace and delete receipt

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: v9.0.50-0
Reproducible in staging?: Y
Reproducible in production?: N
Issue reported by: Applause Internal Team
Action Performed:

Go to https://staging.new.expensify.com/home
Open 1:1 with an user (or workspace chat)
Submit an expense
Open the expense
Tap plus placeholder and using camera upload an image
Tap on receipt -- 3 dots
Note the receipt options

Expected Result:
Receipt 3dots menu must show options to replace and delete receipt.
Actual Result:
Receipt 3dots menu doesn't show options to replace and delete receipt.
Workaround:
Unknown
Platforms:

[ ] Android: Standalone
[ ] Android: HybridApp
[x] Android: mWeb Chrome
[ ] iOS: Standalone
[ ] iOS: HybridApp
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
https://github.com/user-attachments/assets/75a0f39e-fe5c-4012-a092-e7bd47b2aab4

View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~021846827472906199686
Upwork Job ID: 1846827472906199686
Last Price Increase: 2024-10-17

Issue OwnerCurrent Issue Owner: @Pujan92

Proposal
Please re-state the problem that we are trying to solve in this issue.
Receipt 3dots menu doesn't show options to replace and delete receipt.
What is the root cause of that problem?
The readonly route param here is parsed as string:
https://github.com/Expensify/App/blob/9f8e8c5abcb7c3d842398de18a516eb8b79d36ce/src/pages/TransactionReceiptPage.tsx#L30
so when it is "false" (string), the canEditReceipt here is false (because !"false" is boolean false)
https://github.com/Expensify/App/blob/9f8e8c5abcb7c3d842398de18a516eb8b79d36ce/src/pages/TransactionReceiptPage.tsx#L75
And eventually we cannot edit the receipt (neither replace nor delete)
What changes do you think we should make in order to solve the problem?

Explicitly check if route.params.readonly === 'true'

Ooh your change does look like it fixes the problem 👍 👍 🎉  though I'm still curious to try to find any regressed PR(s) if possible!

@mkzie2's RCA and proposal looks correct, let me also find the offended PR

Proposal
Please re-state the problem that we are trying to solve in this issue.
Receipt 3dots menu doesn't show options to replace and delete receipt
What is the root cause of that problem?
This issue happend by this pull request.
receipt${readonly ? '?readonly=true' : ''}$ to  changed readonly=${readonly}
So the condition here returns the string 'false', which causes this issue during the check
https://github.com/Expensify/App/blob/cd2c7ddc3f6e063c3b0648d3326495ddede3f7b1/src/pages/TransactionReceiptPage.tsx#L30
What changes do you think we should make in order to solve the problem?
We need to update condition
//.src/pages/TransactionReceiptPage.tsx#L74
canEditReceipt={canEditReceipt && route.params.readonly === 'false'}

What alternative solutions did you explore? (Optional)

Offending PR https://github.com/Expensify/App/pull/50546. Explicitly this change. Before that we never have readonly=false, only readonly=true.

Wow good find both of y'all 😅
So it sounds like that PR only really uncovered a bug in the App/src/pages/TransactionReceiptPage.tsx file, right? If so, I think let's hire @mkzie2 to fix real quick

@Pujan92 I added an alternative solution, which one should we proceed?

Yes @Beamanator, I think so.

@Pujan92 I added an alternative solution, which one should we proceed?

As route param will always be a string then I believe it is better to proceed with your main solution which is to check value 'true'

Also @mkzie2 please make this a priority today since this is a deploy blocker 🙏

Successfully CP'd! @mkzie2 @Pujan92 can y'all please test on staging to make sure this is fixed? 🙏

@Beamanator Just verified in staging and it gets fixed. 👍

Amazing! Thanks!

HI there, just checking to see if this might be a regression https://github.com/Expensify/App/issues/51142

Hmm @Christinadobrzyn that seems unlikely b/c the fix for this issue is now in production 🤔

@Pujan92 can you please complete the checklist so that I can issue payment?

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[X] [@Pujan92] The PR that introduced the bug has been identified. Link to the PR: https://github.com/Expensify/App/pull/47536
[X] [@Pujan92] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/47536/files#r1816465370
[X] [@Pujan92] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: NA
[X] [@Pujan92] Determine if we should create a regression test for this bug. Yes
[X] [@Pujan92] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Steps

Submit an expense and add a receipt to it
Goto that expense and open an image modal
Click on 3 dots menu
Verify Replace and Delete receipt options are shown

Will pay this tomorrow!

Payment Summary:
Contributor: @mkzie2 paid $250 via Upwork
Contributor+: @Pujan92 to be paid $250 via Newdot manual request
Upwork job here

Contributor has been paid, the contract has been completed, and the Upwork post has been closed.

$250 approved for @Pujan92

authors: Beamanator Christinadobrzyn IuliiaHerets Pujan92 RachCHopkins garrettmknight huult mkzie2


text:
mWeb - Back button on workspace chat returns to workspace list instead of workspace settings

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0.77-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): applausetester+kh1311020@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: iPhone 15 Pro Max / iOS 18.2
App Component: Workspace Settings
Action Performed:

Go to staging.new.expensify.com
Go to workspace settings.
Tap on the workspace chat under "Submit expenses using your workspace chat below".
Tap app back button.

Expected Result:
App will return to the workspace settings (production behavior).
Actual Result:
App returns to workspace list.
Workaround:
Unknown
Platforms:

[ ] Android: Standalone
[ ] Android: HybridApp
[x] Android: mWeb Chrome
[ ] iOS: Standalone
[ ] iOS: HybridApp
[x] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
https://github.com/user-attachments/assets/05c0c254-15c5-4f69-bc55-57b6a8c03853
View all open jobs on GitHub

I'm going to demote this from being a blocker because it doesn't interfere with any workflows.

Regression from https://github.com/Expensify/App/pull/53985

@twilight2294 Is this something you will be looking into and fixing?

Thank you!


text:
Update the reanimated and gesture handler versions

Details

Bumping two packages to resolve issues when running native apps locally. There is nothing specific to test, full regression tests should discover if anything will be broken
Fixed Issues

A lot of issues internally running the native apps https://expensify.slack.com/archives/C03TQ48KC/p1675812945076659
Tests

No specific tests, a full regression suite in case something odd is happening.

[x] Verify that no errors appear in the JS console

Offline tests

N/A
QA Steps

No specific tests, a full regression suite in case something odd is happening.

[ ] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos
Nothing specific to add to the screenshots here, the app was running and mainly it builds fine on native.

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

@youssef-lr Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@0xmiroslav do you have time to test this today? :D it's causing issues testing iOS in other PRs

Please run npm start -- --reset-cache to clear Metro cache due to changes in Reanimated Babel plugin.

Thanks for help!

@0xmiroslav Thanks! Do you plan to submit any screenshots there before approval?

thank you!

@moutiny Sure, I will take a look at it tomorrow. I will keep you updated. Thanks for testing!

Thank you!

@0xmiroslav I'm trying to investigate the issue. Can you please describe what's the expected behavior of the drawer when you open a chat? Even when running the app in Chrome on my Mac, the drawer seems to behave non-deterministically even on the main branch.
In particular, when I open the chat with Concierge, sometimes the animation starts but sometimes it doesn't. Also, the animation is more likely to be skipped when I open two chats in turn, see the video recording:
https://user-images.githubusercontent.com/20516055/218061907-3ce81297-a747-4bca-9a47-208ba976635a.mov

@0xmiroslav but you specifically noticed the issues on Android mWeb Chrome right? For the other platforms, was it fine from your testing?

@0xmiroslav @mountiny Thanks for providing more details. I'm aware of the fact that originally the bug has been found when testing this PR on Android mWeb Chrome. The thing is, I can reproduce this exact problem also on the main branch, also on other platforms. I can easily reproduce the bug when opening two chats in turn (A, B, then A again, then B again etc.). Here are the configurations that I've tested:

new.expensify.com (production) / Chrome on Mac: ✅ (animations is always started)
main (14ebe26b6af9c19b7debedb25bcbdf976cb57c5e) / Chrome on Mac: ❌ (sometimes animation does not start)
vit-updateReanimatedAndGestureHandler (a4f8faa9bc94afee1b124b49271a427af62d5477) / Chrome on Mac: ❌ (sometimes animation does not start)

The conclusion is that most likely this bug was actually introduced some time earlier and not in this PR.
@0xmiroslav Could you please check if you can reproduce this bug on commit 14ebe26b6af9c19b7debedb25bcbdf976cb57c5e (from main branch)?

I know this is not ideal, if the animation does not work at all on Android chrome it is not great, but if it works on all other platforms the benefits of this upgrade might outweigh this issue and we could just follow up with investigation how to fix the original issue.

Just for the record, as promised, here's the video recording of the bug on the production. I believe this may be related to the keyboard appearing as a result of focusing the text input.
https://user-images.githubusercontent.com/20516055/218124504-e0941cf4-d759-412e-902a-741bbaff45e7.mp4

@0xmiroslav can you sum this up please. is the animation working fine on other platforms and mWeb Android you never got the animation to work?
If this is the case I think we could merge this and then have a follow up issue for why the Android mWeb animation does not work well. What do you think?

@0xmiroslav I would say we can investigate that but we can merge this first too, basically now anyone trying to run from main is running to issues when running pods so it might be better to improve the developer experience here and investigate this bug as a follow up
Can you approve the PR?

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/madmax330 in version: 1.2.70-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

🚀 Deployed to staging by https://github.com/madmax330 in version: 1.2.70-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

🚀 Deployed to staging by https://github.com/madmax330 in version: 1.2.70-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/francoisl in version: 1.2.70-1 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

authors: Beamanator MelvinBot OSBotify mountiny tomekzaw


text:
Display IOU and expense reports in the LHN

Details

Fixed Issues

$ https://github.com/Expensify/App/issues/18475
Tests

[ ] Verify that no errors appear in the JS console

Offline tests

QA Steps

[ ] Verify that no errors appear in the JS console

PR Author Checklist

[ ] I linked the correct issue in the ### Fixed Issues section above
[ ] I wrote clear testing steps that cover the changes made in this PR

[ ] I added steps for local testing in the Tests section
[ ] I added steps for the expected offline behavior in the Offline steps section
[ ] I added steps for Staging and/or Production testing in the QA steps section
[ ] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[ ] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[ ] I included screenshots or videos for tests on all platforms
[ ] I ran the tests on all platforms & verified they passed on:

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[ ] MacOS / Chrome / Safari
[ ] MacOS / Desktop

[ ] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[ ] I followed proper code patterns (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[ ] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[ ] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[ ] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[ ] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I followed the guidelines as stated in the Review Guidelines
[ ] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] I verified that if a function's arguments changed that all usages have also been updated correctly
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If any new file was added I verified that:

[ ] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[ ] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[ ] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[ ] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

@mountiny I'll open a new PR to clear up the unsigned commit.


text:
Combine Split Bill details page PRs

Details

Fixed Issues

$ GH_LINK
PROPOSAL: GH_LINK_ISSUE(COMMENT)
Tests

[ ] Verify that no errors appear in the JS console

Offline tests

QA Steps

[ ] Verify that no errors appear in the JS console

PR Author Checklist

[ ] I linked the correct issue in the ### Fixed Issues section above
[ ] I wrote clear testing steps that cover the changes made in this PR

[ ] I added steps for local testing in the Tests section
[ ] I added steps for the expected offline behavior in the Offline steps section
[ ] I added steps for Staging and/or Production testing in the QA steps section
[ ] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[ ] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[ ] I included screenshots or videos for tests on all platforms
[ ] I ran the tests on all platforms & verified they passed on:

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[ ] MacOS / Chrome / Safari
[ ] MacOS / Desktop

[ ] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[ ] I followed proper code patterns (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[ ] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[ ] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[ ] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[ ] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I followed the guidelines as stated in the Review Guidelines
[ ] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] I verified that if a function's arguments changed that all usages have also been updated correctly
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If any new file was added I verified that:

[ ] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[ ] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[ ] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[ ] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

Ignoring the remaining checks, THIS IS NOT GOING TO MAIN. Will be fully reviewed here.

🚀 Deployed to staging by https://github.com/Julesssss in version: 1.3.20-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

authors: Julesssss OSBotify