text:
Function override does not work in Solang

The function overriding is not working for the following contract:
/**
 *Submitted for verification at polygonscan.com on 2021-10-11
*/

// SPDX-License-Identifier: MIT

// Amended by HashLips
/**
    !Disclaimer!
    These contracts have been used to create tutorials,
    and was created for the purpose to teach people
    how to create smart contracts on the blockchain.
    please review this code on your own before using any of
    the following code for production.
    HashLips will not be liable in any way if for the use
    of the code. That being said, the code has been tested
    to the best of the developers' knowledge to work as intended.
*/

// File: @openzeppelin/contracts/utils/introspection/IERC165.sol
pragma solidity^0.8.0;
/**
 * @dev Interface of the ERC165 standard, as defined in the
 * https://eips.ethereum.org/EIPS/eip-165[EIP].
 *
 * Implementers can declare support of contract interfaces, which can then be
 * queried by others ({ERC165Checker}).
 *
 * For an implementation, see {ERC165}.
 */
interface IERC165 {
    /**
     * @dev Returns true if this contract implements the interface defined by
     * `interfaceId`. See the corresponding
     * https://eips.ethereum.org/EIPS/eip-165#how-interfaces-are-identified[EIP section]
     * to learn more about how these ids are created.
     *
     * This function call must use less than 30 000 gas.
     */
    function supportsInterface(bytes4 interfaceId) external view returns(bool);
}

// File: @openzeppelin/contracts/token/ERC721/IERC721.sol
pragma solidity^0.8.0;
/**
 * @dev Required interface of an ERC721 compliant contract.
 */
interface IERC721 is IERC165 {
    /**
     * @dev Emitted when `tokenId` token is transferred from `from` to `to`.
     */
    event Transfer(address indexed from, address indexed to, uint256 indexed tokenId);

    /**
     * @dev Emitted when `owner` enables `approved` to manage the `tokenId` token.
     */
    event Approval(address indexed owner, address indexed approved, uint256 indexed tokenId);

    /**
     * @dev Emitted when `owner` enables or disables (`approved`) `operator` to manage all of its assets.
     */
    event ApprovalForAll(address indexed owner, address indexed operator, bool approved);

	/**
	 * @dev Returns the number of tokens in ``owner``'s account.
	 */
	function balanceOf(address owner) external view returns(uint256 balance);

	/**
	 * @dev Returns the owner of the `tokenId` token.
	 *
	 * Requirements:
	 *
	 * - `tokenId` must exist.
	 */
	function ownerOf(uint256 tokenId) external view returns(address owner);

	/**
	 * @dev Safely transfers `tokenId` token from `from` to `to`, checking first that contract recipients
	 * are aware of the ERC721 protocol to prevent tokens from being forever locked.
	 *
	 * Requirements:
	 *
	 * - `from` cannot be the zero address.
	 * - `to` cannot be the zero address.
	 * - `tokenId` token must exist and be owned by `from`.
	 * - If the caller is not `from`, it must be have been allowed to move this token by either {approve} or {setApprovalForAll}.
	 * - If `to` refers to a smart contract, it must implement {IERC721Receiver-onERC721Received}, which is called upon a safe transfer.
	 *
	 * Emits a {Transfer} event.
	 */
	function safeTransferFrom(
		address from,
		address to,
		uint256 tokenId
	) external;

	/**
	 * @dev Transfers `tokenId` token from `from` to `to`.
	 *
	 * WARNING: Usage of this method is discouraged, use {safeTransferFrom} whenever possible.
	 *
	 * Requirements:
	 *
	 * - `from` cannot be the zero address.
	 * - `to` cannot be the zero address.
	 * - `tokenId` token must be owned by `from`.
	 * - If the caller is not `from`, it must be approved to move this token by either {approve} or {setApprovalForAll}.
	 *
	 * Emits a {Transfer} event.
	 */
	function transferFrom(
		address from,
		address to,
		uint256 tokenId
	) external;

	/**
	 * @dev Gives permission to `to` to transfer `tokenId` token to another account.
	 * The approval is cleared when the token is transferred.
	 *
	 * Only a single account can be approved at a time, so approving the zero address clears previous approvals.
	 *
	 * Requirements:
	 *
	 * - The caller must own the token or be an approved operator.
	 * - `tokenId` must exist.
	 *
	 * Emits an {Approval} event.
	 */
	function approve(address to, uint256 tokenId) external;

	/**
	 * @dev Returns the account approved for `tokenId` token.
	 *
	 * Requirements:
	 *
	 * - `tokenId` must exist.
	 */
	function getApproved(uint256 tokenId) external view returns(address operator);

	/**
	 * @dev Approve or remove `operator` as an operator for the caller.
	 * Operators can call {transferFrom} or {safeTransferFrom} for any token owned by the caller.
	 *
	 * Requirements:
	 *
	 * - The `operator` cannot be the caller.
	 *
	 * Emits an {ApprovalForAll} event.
	 */
	function setApprovalForAll(address operator, bool _approved) external;

	/**
	 * @dev Returns if the `operator` is allowed to manage all of the assets of `owner`.
	 *
	 * See {setApprovalForAll}
	 */
	function isApprovedForAll(address owner, address operator) external view returns(bool);

	/**
	 * @dev Safely transfers `tokenId` token from `from` to `to`.
	 *
	 * Requirements:
	 *
	 * - `from` cannot be the zero address.
	 * - `to` cannot be the zero address.
	 * - `tokenId` token must exist and be owned by `from`.
	 * - If the caller is not `from`, it must be approved to move this token by either {approve} or {setApprovalForAll}.
	 * - If `to` refers to a smart contract, it must implement {IERC721Receiver-onERC721Received}, which is called upon a safe transfer.
	 *
	 * Emits a {Transfer} event.
	 */
	function safeTransferFrom(
		address from,
		address to,
		uint256 tokenId,
		bytes calldata data
	) external;
}

// File: @openzeppelin/contracts/token/ERC721/extensions/IERC721Enumerable.sol
pragma solidity^0.8.0;
/**
 * @title ERC-721 Non-Fungible Token Standard, optional enumeration extension
 * @dev See https://eips.ethereum.org/EIPS/eip-721
 */
interface IERC721Enumerable is IERC721 {
	/**
	 * @dev Returns the total amount of tokens stored by the contract.
	 */
	function totalSupply() external view returns(uint256);

	/**
	 * @dev Returns a token ID owned by `owner` at a given `index` of its token list.
	 * Use along with {balanceOf} to enumerate all of ``owner``'s tokens.
	 */
	function tokenOfOwnerByIndex(address owner, uint256 index) external view returns(uint256 tokenId);

	/**
	 * @dev Returns a token ID at a given `index` of all the tokens stored by the contract.
	 * Use along with {totalSupply} to enumerate all tokens.
	 */
	function tokenByIndex(uint256 index) external view returns(uint256);
}

// File: @openzeppelin/contracts/utils/introspection/ERC165.sol
pragma solidity^0.8.0;
/**
 * @dev Implementation of the {IERC165} interface.
 *
 * Contracts that want to implement ERC165 should inherit from this contract and override {supportsInterface} to check
 * for the additional interface id that will be supported. For example:
 *
 * ```solidity
 * function supportsInterface(bytes4 interfaceId) public view virtual override returns (bool) {
 *     return interfaceId == type(MyInterface).interfaceId || super.supportsInterface(interfaceId);
 * }
 * ```
 *
 * Alternatively, {ERC165Storage} provides an easier to use but more expensive implementation.
 */
abstract contract ERC165 is IERC165 {
	/**
	 * @dev See {IERC165-supportsInterface}.
	 */
	function supportsInterface(bytes4 interfaceId) public view virtual override returns(bool) {
		return interfaceId==type(IERC165).interfaceId;
	}
}

// File: @openzeppelin/contracts/utils/Strings.sol

pragma solidity^0.8.0;

/**
 * @dev String operations.
 */
library Strings {
    bytes16 private constant _HEX_SYMBOLS="0123456789abcdef";

	/**
	 * @dev Converts a `uint256` to its ASCII `string` decimal representation.
	 */
	function toString(uint256 value) internal pure returns(string memory) {
		// Inspired by OraclizeAPI's implementation - MIT licence
		// https://github.com/oraclize/ethereum-api/blob/b42146b063c7d6ee1358846c198246239e9360e8/oraclizeAPI_0.4.25.sol

		if (value==0) {
			return "0";
		}
        uint256 temp=value;
        uint256 digits;
		while (temp!=0) {
			digits++;
			temp/=10;
		}
        bytes memory buffer=new bytes(digits);
		while (value!=0) {
			digits-=1;
			buffer[digits]=bytes1(uint8(48+uint256(value%10)));
			value/=10;
		}
		return string(buffer);
	}

	/**
	 * @dev Converts a `uint256` to its ASCII `string` hexadecimal representation.
	 */
	function toHexString(uint256 value) internal pure returns(string memory) {
		if (value==0) {
			return "0x00";
		}
        uint256 temp=value;
        uint256 length=0;
		while (temp!=0) {
			length++;
			temp>>=8;
		}
		return toHexString(value, length);
	}

	/**
	 * @dev Converts a `uint256` to its ASCII `string` hexadecimal representation with fixed length.
	 */
	function toHexString(uint256 value, uint256 length) internal pure returns(string memory) {
        bytes memory buffer=new bytes(2*length+2);
		buffer[0]="0";
		buffer[1]="x";
		for (uint256 i=2*length+1; i>1; --i) {
			buffer[i]=_HEX_SYMBOLS[value&0xf];
			value>>=4;
		}
		require(value==0, "Strings: hex length insufficient");
		return string(buffer);
	}
}

// File: @openzeppelin/contracts/utils/Address.sol

pragma solidity^0.8.0;

/**
 * @dev Collection of functions related to the address type
 */
library Address {
	/**
	 * @dev Returns true if `account` is a contract.
	 *
	 * [IMPORTANT]
	 * ====
	 * It is unsafe to assume that an address for which this function returns
	 * false is an externally-owned account (EOA) and not a contract.
	 *
	 * Among others, `isContract` will return false for the following
	 * types of addresses:
	 *
	 *  - an externally-owned account
	 *  - a contract in construction
	 *  - an address where a contract will be created
	 *  - an address where a contract lived, but was destroyed
	 * ====
	 */
	function isContract(address account) internal view returns(bool) {
        // This method relies on extcodesize, which returns 0 for contracts in
        // construction, since the code is only stored at the end of the
        // constructor execution.

        uint256 size;
        assembly {
			size:=extcodesize(account)
		}
		return size>0;
	}

	/**
	 * @dev Replacement for Solidity's `transfer`: sends `amount` wei to
	 * `recipient`, forwarding all available gas and reverting on errors.
	 *
	 * https://eips.ethereum.org/EIPS/eip-1884[EIP1884] increases the gas cost
	 * of certain opcodes, possibly making contracts go over the 2300 gas limit
	 * imposed by `transfer`, making them unable to receive funds via
	 * `transfer`. {sendValue} removes this limitation.
	 *
	 * https://diligence.consensys.net/posts/2019/09/stop-using-soliditys-transfer-now/[Learn more].
	 *
	 * IMPORTANT: because control is transferred to `recipient`, care must be
	 * taken to not create reentrancy vulnerabilities. Consider using
	 * {ReentrancyGuard} or the
	 * https://solidity.readthedocs.io/en/v0.5.11/security-considerations.html#use-the-checks-effects-interactions-pattern[checks-effects-interactions pattern].
	 */
	function sendValue(address payable recipient, uint256 amount) internal {
		require(address(this).balance>=amount, "Address: insufficient balance");

		(bool success, ) = recipient.call{ value: amount } ("");
		require(success, "Address: unable to send value, recipient may have reverted");
	}

	/**
	 * @dev Performs a Solidity function call using a low level `call`. A
	 * plain `call` is an unsafe replacement for a function call: use this
	 * function instead.
	 *
	 * If `target` reverts with a revert reason, it is bubbled up by this
	 * function (like regular Solidity function calls).
	 *
	 * Returns the raw returned data. To convert to the expected return value,
	 * use https://solidity.readthedocs.io/en/latest/units-and-global-variables.html?highlight=abi.decode#abi-encoding-and-decoding-functions[`abi.decode`].
	 *
	 * Requirements:
	 *
	 * - `target` must be a contract.
	 * - calling `target` with `data` must not revert.
	 *
	 * _Available since v3.1._
	 */
	function functionCall(address target, bytes memory data) internal returns(bytes memory) {
		return functionCall(target, data, "Address: low-level call failed");
	}

	/**
	 * @dev Same as {xref-Address-functionCall-address-bytes-}[`functionCall`], but with
	 * `errorMessage` as a fallback revert reason when `target` reverts.
	 *
	 * _Available since v3.1._
	 */
	function functionCall(
		address target,
		bytes memory data,
		string memory errorMessage
	) internal returns(bytes memory) {
		return functionCallWithValue(target, data, 0, errorMessage);
	}

	/**
	 * @dev Same as {xref-Address-functionCall-address-bytes-}[`functionCall`],
	 * but also transferring `value` wei to `target`.
	 *
	 * Requirements:
	 *
	 * - the calling contract must have an ETH balance of at least `value`.
	 * - the called Solidity function must be `payable`.
	 *
	 * _Available since v3.1._
	 */
	function functionCallWithValue(
		address target,
		bytes memory data,
		uint256 value
	) internal returns(bytes memory) {
		return functionCallWithValue(target, data, value, "Address: low-level call with value failed");
	}

	/**
	 * @dev Same as {xref-Address-functionCallWithValue-address-bytes-uint256-}[`functionCallWithValue`], but
	 * with `errorMessage` as a fallback revert reason when `target` reverts.
	 *
	 * _Available since v3.1._
	 */
	function functionCallWithValue(
		address target,
		bytes memory data,
		uint256 value,
		string memory errorMessage
	) internal returns(bytes memory) {
		require(address(this).balance>=value, "Address: insufficient balance for call");
		require(isContract(target), "Address: call to non-contract");

		(bool success, bytes memory returndata) = target.call{ value: value } (data);
		return verifyCallResult(success, returndata, errorMessage);
	}

	/**
	 * @dev Same as {xref-Address-functionCall-address-bytes-}[`functionCall`],
	 * but performing a static call.
	 *
	 * _Available since v3.3._
	 */
	function functionStaticCall(address target, bytes memory data) internal view returns(bytes memory) {
		return functionStaticCall(target, data, "Address: low-level static call failed");
	}

	/**
	 * @dev Same as {xref-Address-functionCall-address-bytes-string-}[`functionCall`],
	 * but performing a static call.
	 *
	 * _Available since v3.3._
	 */
	function functionStaticCall(
		address target,
		bytes memory data,
		string memory errorMessage
	) internal view returns(bytes memory) {
		require(isContract(target), "Address: static call to non-contract");

		(bool success, bytes memory returndata) = target.staticcall(data);
		return verifyCallResult(success, returndata, errorMessage);
	}

	/**
	 * @dev Same as {xref-Address-functionCall-address-bytes-}[`functionCall`],
	 * but performing a delegate call.
	 *
	 * _Available since v3.4._
	 */
	function functionDelegateCall(address target, bytes memory data) internal returns(bytes memory) {
		return functionDelegateCall(target, data, "Address: low-level delegate call failed");
	}

	/**
	 * @dev Same as {xref-Address-functionCall-address-bytes-string-}[`functionCall`],
	 * but performing a delegate call.
	 *
	 * _Available since v3.4._
	 */
	function functionDelegateCall(
		address target,
		bytes memory data,
		string memory errorMessage
	) internal returns(bytes memory) {
		require(isContract(target), "Address: delegate call to non-contract");

		(bool success, bytes memory returndata) = target.delegatecall(data);
		return verifyCallResult(success, returndata, errorMessage);
	}

	/**
	 * @dev Tool to verifies that a low level call was successful, and revert if it wasn't, either by bubbling the
	 * revert reason using the provided one.
	 *
	 * _Available since v4.3._
	 */
	function verifyCallResult(
		bool success,
		bytes memory returndata,
		string memory errorMessage
	) internal pure returns(bytes memory) {
		if (success) {
			return returndata;
		} else {
			// Look for revert reason and bubble it up if present
			if (returndata.length>0) {
                // The easiest way to bubble the revert reason is using memory via assembly

                assembly {
					let returndata_size:=mload(returndata)
					revert(add(32, returndata), returndata_size)
				}
			} else {
				revert(errorMessage);
			}
		}
	}
}

// File: @openzeppelin/contracts/token/ERC721/extensions/IERC721Metadata.sol

pragma solidity^0.8.0;

/**
 * @title ERC-721 Non-Fungible Token Standard, optional metadata extension
 * @dev See https://eips.ethereum.org/EIPS/eip-721
 */
interface IERC721Metadata is IERC721 {
	/**
	 * @dev Returns the token collection name.
	 */
	function name() external view returns(string memory);

	/**
	 * @dev Returns the token collection symbol.
	 */
	function symbol() external view returns(string memory);

	/**
	 * @dev Returns the Uniform Resource Identifier (URI) for `tokenId` token.
	 */
	function tokenURI(uint256 tokenId) external view returns(string memory);
}

// File: @openzeppelin/contracts/token/ERC721/IERC721Receiver.sol

pragma solidity^0.8.0;

/**
 * @title ERC721 token receiver interface
 * @dev Interface for any contract that wants to support safeTransfers
 * from ERC721 asset contracts.
 */
interface IERC721Receiver {
    /**
     * @dev Whenever an {IERC721} `tokenId` token is transferred to this contract via {IERC721-safeTransferFrom}
     * by `operator` from `from`, this function is called.
     *
     * It must return its Solidity selector to confirm the token transfer.
     * If any other value is returned or the interface is not implemented by the recipient, the transfer will be reverted.
     *
     * The selector can be obtained in Solidity with `IERC721.onERC721Received.selector`.
     */
    function onERC721Received(
	address operator,
	address from,
	uint256 tokenId,
	bytes calldata data
) external returns(bytes4);
}

// File: @openzeppelin/contracts/utils/Context.sol
pragma solidity^0.8.0;
/**
 * @dev Provides information about the current execution context, including the
 * sender of the transaction and its data. While these are generally available
 * via msg.sender and msg.data, they should not be accessed in such a direct
 * manner, since when dealing with meta-transactions the account sending and
 * paying for execution may not be the actual sender (as far as an application
 * is concerned).
 *
 * This contract is only required for intermediate, library-like contracts.
 */
abstract contract Context {
	function _msgSender() internal view virtual returns(address) {
		return msg.sender;
	}

	function _msgData() internal view virtual returns(bytes calldata) {
		return msg.data;
	}
}

// File: @openzeppelin/contracts/token/ERC721/ERC721.sol
pragma solidity^0.8.0;
/**
 * @dev Implementation of https://eips.ethereum.org/EIPS/eip-721[ERC721] Non-Fungible Token Standard, including
 * the Metadata extension, but not including the Enumerable extension, which is available separately as
 * {ERC721Enumerable}.
 */
contract ERC721 is Context, ERC165, IERC721, IERC721Metadata {
    using Address for address;
		using Strings for uint256;

			// Token name
			string private _name;

    // Token symbol
    string private _symbol;

	// Mapping from token ID to owner address
	mapping(uint256 => address) private _owners;

	// Mapping owner address to token count
	mapping(address => uint256) private _balances;

	// Mapping from token ID to approved address
	mapping(uint256 => address) private _tokenApprovals;

	// Mapping from owner to operator approvals
	mapping(address => mapping(address => bool)) private _operatorApprovals;

	/**
	 * @dev Initializes the contract by setting a `name` and a `symbol` to the token collection.
	 */
	constructor(string memory name_, string memory symbol_) {
		_name=name_;
		_symbol=symbol_;
	}

	/**
	 * @dev See {IERC165-supportsInterface}.
	 */
	function supportsInterface(bytes4 interfaceId) public view virtual override(ERC165, IERC165) returns(bool) {
		return
		interfaceId==type(IERC721).interfaceId||
			interfaceId==type(IERC721Metadata).interfaceId||
			super.supportsInterface(interfaceId);
	}

	/**
	 * @dev See {IERC721-balanceOf}.
	 */
	function balanceOf(address owner) public view virtual override returns(uint256) {
		require(owner!=address(0), "ERC721: balance query for the zero address");
		return _balances[owner];
	}

	/**
	 * @dev See {IERC721-ownerOf}.
	 */
	function ownerOf(uint256 tokenId) public view virtual override returns(address) {
        address owner=_owners[tokenId];
		require(owner!=address(0), "ERC721: owner query for nonexistent token");
		return owner;
	}

	/**
	 * @dev See {IERC721Metadata-name}.
	 */
	function name() public view virtual override returns(string memory) {
		return _name;
	}

	/**
	 * @dev See {IERC721Metadata-symbol}.
	 */
	function symbol() public view virtual override returns(string memory) {
		return _symbol;
	}

	/**
	 * @dev See {IERC721Metadata-tokenURI}.
	 */
	function tokenURI(uint256 tokenId) public view virtual override returns(string memory) {
		require(_exists(tokenId), "ERC721Metadata: URI query for nonexistent token");

        string memory baseURI=_baseURI();
		return bytes(baseURI).length>0? string(abi.encodePacked(baseURI, tokenId.toString())):"";
	}

	/**
	 * @dev Base URI for computing {tokenURI}. If set, the resulting URI for each
	 * token will be the concatenation of the `baseURI` and the `tokenId`. Empty
	 * by default, can be overriden in child contracts.
	 */
	function _baseURI() internal view virtual returns(string memory) {
		return "";
	}

	/**
	 * @dev See {IERC721-approve}.
	 */
	function approve(address to, uint256 tokenId) public virtual override {
        address owner=ERC721.ownerOf(tokenId);
		require(to!=owner, "ERC721: approval to current owner");

		require(
			_msgSender()==owner||isApprovedForAll(owner, _msgSender()),
			"ERC721: approve caller is not owner nor approved for all"
		);

		_approve(to, tokenId);
	}

	/**
	 * @dev See {IERC721-getApproved}.
	 */
	function getApproved(uint256 tokenId) public view virtual override returns(address) {
		require(_exists(tokenId), "ERC721: approved query for nonexistent token");

		return _tokenApprovals[tokenId];
	}

	/**
	 * @dev See {IERC721-setApprovalForAll}.
	 */
	function setApprovalForAll(address operator, bool approved) public virtual override {
		require(operator!=_msgSender(), "ERC721: approve to caller");

		_operatorApprovals[_msgSender()][operator]=approved;
        emit ApprovalForAll(_msgSender(), operator, approved);
	}

	/**
	 * @dev See {IERC721-isApprovedForAll}.
	 */
	function isApprovedForAll(address owner, address operator) public view virtual override returns(bool) {
		return _operatorApprovals[owner][operator];
	}

	/**
	 * @dev See {IERC721-transferFrom}.
	 */
	function transferFrom(
		address from,
		address to,
		uint256 tokenId
	) public virtual override {
		//solhint-disable-next-line max-line-length
		require(_isApprovedOrOwner(_msgSender(), tokenId), "ERC721: transfer caller is not owner nor approved");

		_transfer(from, to, tokenId);
	}

	/**
	 * @dev See {IERC721-safeTransferFrom}.
	 */
	function safeTransferFrom(
		address from,
		address to,
		uint256 tokenId
	) public virtual override {
		safeTransferFrom(from, to, tokenId, "");
	}

	/**
	 * @dev See {IERC721-safeTransferFrom}.
	 */
	function safeTransferFrom(
		address from,
		address to,
		uint256 tokenId,
		bytes memory _data
	) public virtual override {
		require(_isApprovedOrOwner(_msgSender(), tokenId), "ERC721: transfer caller is not owner nor approved");
		_safeTransfer(from, to, tokenId, _data);
	}

	/**
	 * @dev Safely transfers `tokenId` token from `from` to `to`, checking first that contract recipients
	 * are aware of the ERC721 protocol to prevent tokens from being forever locked.
	 *
	 * `_data` is additional data, it has no specified format and it is sent in call to `to`.
	 *
	 * This internal function is equivalent to {safeTransferFrom}, and can be used to e.g.
	 * implement alternative mechanisms to perform token transfer, such as signature-based.
	 *
	 * Requirements:
	 *
	 * - `from` cannot be the zero address.
	 * - `to` cannot be the zero address.
	 * - `tokenId` token must exist and be owned by `from`.
	 * - If `to` refers to a smart contract, it must implement {IERC721Receiver-onERC721Received}, which is called upon a safe transfer.
	 *
	 * Emits a {Transfer} event.
	 */
	function _safeTransfer(
		address from,
		address to,
		uint256 tokenId,
		bytes memory _data
	) internal virtual {
		_transfer(from, to, tokenId);
		require(_checkOnERC721Received(from, to, tokenId, _data), "ERC721: transfer to non ERC721Receiver implementer");
	}

	/**
	 * @dev Returns whether `tokenId` exists.
	 *
	 * Tokens can be managed by their owner or approved accounts via {approve} or {setApprovalForAll}.
	 *
	 * Tokens start existing when they are minted (`_mint`),
	 * and stop existing when they are burned (`_burn`).
	 */
	function _exists(uint256 tokenId) internal view virtual returns(bool) {
		return _owners[tokenId]!=address(0);
	}

	/**
	 * @dev Returns whether `spender` is allowed to manage `tokenId`.
	 *
	 * Requirements:
	 *
	 * - `tokenId` must exist.
	 */
	function _isApprovedOrOwner(address spender, uint256 tokenId) internal view virtual returns(bool) {
		require(_exists(tokenId), "ERC721: operator query for nonexistent token");
        address owner=ERC721.ownerOf(tokenId);
		return (spender==owner||getApproved(tokenId)==spender||isApprovedForAll(owner, spender));
	}

	/**
	 * @dev Safely mints `tokenId` and transfers it to `to`.
	 *
	 * Requirements:
	 *
	 * - `tokenId` must not exist.
	 * - If `to` refers to a smart contract, it must implement {IERC721Receiver-onERC721Received}, which is called upon a safe transfer.
	 *
	 * Emits a {Transfer} event.
	 */
	function _safeMint(address to, uint256 tokenId) internal virtual {
		_safeMint(to, tokenId, "");
	}

	/**
	 * @dev Same as {xref-ERC721-_safeMint-address-uint256-}[`_safeMint`], with an additional `data` parameter which is
	 * forwarded in {IERC721Receiver-onERC721Received} to contract recipients.
	 */
	function _safeMint(
		address to,
		uint256 tokenId,
		bytes memory _data
	) internal virtual {
		_mint(to, tokenId);
		require(
			_checkOnERC721Received(address(0), to, tokenId, _data),
			"ERC721: transfer to non ERC721Receiver implementer"
		);
	}

	/**
	 * @dev Mints `tokenId` and transfers it to `to`.
	 *
	 * WARNING: Usage of this method is discouraged, use {_safeMint} whenever possible
	 *
	 * Requirements:
	 *
	 * - `tokenId` must not exist.
	 * - `to` cannot be the zero address.
	 *
	 * Emits a {Transfer} event.
	 */
	function _mint(address to, uint256 tokenId) internal virtual {
		require(to!=address(0), "ERC721: mint to the zero address");
		require(!_exists(tokenId), "ERC721: token already minted");

		_beforeTokenTransfer(address(0), to, tokenId);

		_balances[to]+=1;
		_owners[tokenId]=to;

        emit Transfer(address(0), to, tokenId);
	}

	/**
	 * @dev Destroys `tokenId`.
	 * The approval is cleared when the token is burned.
	 *
	 * Requirements:
	 *
	 * - `tokenId` must exist.
	 *
	 * Emits a {Transfer} event.
	 */
	function _burn(uint256 tokenId) internal virtual {
        address owner=ERC721.ownerOf(tokenId);

		_beforeTokenTransfer(owner, address(0), tokenId);

		// Clear approvals
		_approve(address(0), tokenId);

		_balances[owner]-=1;
		delete _owners[tokenId];

        emit Transfer(owner, address(0), tokenId);
	}

	/**
	 * @dev Transfers `tokenId` from `from` to `to`.
	 *  As opposed to {transferFrom}, this imposes no restrictions on msg.sender.
	 *
	 * Requirements:
	 *
	 * - `to` cannot be the zero address.
	 * - `tokenId` token must be owned by `from`.
	 *
	 * Emits a {Transfer} event.
	 */
	function _transfer(
		address from,
		address to,
		uint256 tokenId
	) internal virtual {
		require(ERC721.ownerOf(tokenId)==from, "ERC721: transfer of token that is not own");
		require(to!=address(0), "ERC721: transfer to the zero address");

		_beforeTokenTransfer(from, to, tokenId);

		// Clear approvals from the previous owner
		_approve(address(0), tokenId);

		_balances[from]-=1;
		_balances[to]+=1;
		_owners[tokenId]=to;

        emit Transfer(from, to, tokenId);
	}

	/**
	 * @dev Approve `to` to operate on `tokenId`
	 *
	 * Emits a {Approval} event.
	 */
	function _approve(address to, uint256 tokenId) internal virtual {
		_tokenApprovals[tokenId]=to;
        emit Approval(ERC721.ownerOf(tokenId), to, tokenId);
	}

	/**
	 * @dev Internal function to invoke {IERC721Receiver-onERC721Received} on a target address.
	 * The call is not executed if the target address is not a contract.
	 *
	 * @param from address representing the previous owner of the given token ID
	 * @param to target address that will receive the tokens
	 * @param tokenId uint256 ID of the token to be transferred
	 * @param _data bytes optional data to send along with the call
	 * @return bool whether the call correctly returned the expected magic value
	 */
	function _checkOnERC721Received(
		address from,
		address to,
		uint256 tokenId,
		bytes memory _data
	) private returns(bool) {
		if (to.isContract()) {
			try IERC721Receiver(to).onERC721Received(_msgSender(), from, tokenId, _data) returns(bytes4 retval) {
				return retval==IERC721Receiver.onERC721Received.selector;
			} catch (bytes memory reason) {
				if (reason.length==0) {
					revert("ERC721: transfer to non ERC721Receiver implementer");
				} else {
                    assembly {
						revert(add(32, reason), mload(reason))
					}
				}
			}
		} else {
			return true;
		}
	}

	/**
	 * @dev Hook that is called before any token transfer. This includes minting
	 * and burning.
	 *
	 * Calling conditions:
	 *
	 * - When `from` and `to` are both non-zero, ``from``'s `tokenId` will be
	 * transferred to `to`.
	 * - When `from` is zero, `tokenId` will be minted for `to`.
	 * - When `to` is zero, ``from``'s `tokenId` will be burned.
	 * - `from` and `to` are never both zero.
	 *
	 * To learn more about hooks, head to xref:ROOT:extending-contracts.adoc#using-hooks[Using Hooks].
	 */
	function _beforeTokenTransfer(
		address from,
		address to,
		uint256 tokenId
	) internal virtual { }
}

// File: @openzeppelin/contracts/token/ERC721/extensions/ERC721Enumerable.sol

pragma solidity^0.8.0;

/**
 * @dev This implements an optional extension of {ERC721} defined in the EIP that adds
 * enumerability of all the token ids in the contract as well as all token ids owned by each
 * account.
 */
abstract contract ERC721Enumerable is ERC721, IERC721Enumerable {
	// Mapping from owner to list of owned token IDs
	mapping(address => mapping(uint256 => uint256)) private _ownedTokens;

	// Mapping from token ID to index of the owner tokens list
	mapping(uint256 => uint256) private _ownedTokensIndex;

	// Array with all token ids, used for enumeration
	uint256[] private _allTokens;

	// Mapping from token id to position in the allTokens array
	mapping(uint256 => uint256) private _allTokensIndex;

	/**
	 * @dev See {IERC165-supportsInterface}.
	 */
	function supportsInterface(bytes4 interfaceId) public view virtual override(IERC165, ERC721) returns(bool) {
		return interfaceId==type(IERC721Enumerable).interfaceId||super.supportsInterface(interfaceId);
	}

	/**
	 * @dev See {IERC721Enumerable-tokenOfOwnerByIndex}.
	 */
	function tokenOfOwnerByIndex(address owner, uint256 index) public view virtual override returns(uint256) {
		require(index<ERC721.balanceOf(owner), "ERC721Enumerable: owner index out of bounds");
		return _ownedTokens[owner][index];
	}

	/**
	 * @dev See {IERC721Enumerable-totalSupply}.
	 */
	function totalSupply() public view virtual override returns(uint256) {
		return _allTokens.length;
	}

	/**
	 * @dev See {IERC721Enumerable-tokenByIndex}.
	 */
	function tokenByIndex(uint256 index) public view virtual override returns(uint256) {
		require(index<ERC721Enumerable.totalSupply(), "ERC721Enumerable: global index out of bounds");
		return _allTokens[index];
	}

	/**
	 * @dev Hook that is called before any token transfer. This includes minting
	 * and burning.
	 *
	 * Calling conditions:
	 *
	 * - When `from` and `to` are both non-zero, ``from``'s `tokenId` will be
	 * transferred to `to`.
	 * - When `from` is zero, `tokenId` will be minted for `to`.
	 * - When `to` is zero, ``from``'s `tokenId` will be burned.
	 * - `from` cannot be the zero address.
	 * - `to` cannot be the zero address.
	 *
	 * To learn more about hooks, head to xref:ROOT:extending-contracts.adoc#using-hooks[Using Hooks].
	 */
	function _beforeTokenTransfer(
		address from,
		address to,
		uint256 tokenId
	) internal virtual override {
		super._beforeTokenTransfer(from, to, tokenId);

		if (from==address(0)) {
			_addTokenToAllTokensEnumeration(tokenId);
		} else if (from!=to) {
			_removeTokenFromOwnerEnumeration(from, tokenId);
		}
		if (to==address(0)) {
			_removeTokenFromAllTokensEnumeration(tokenId);
		} else if (to!=from) {
			_addTokenToOwnerEnumeration(to, tokenId);
		}
	}

	/**
	 * @dev Private function to add a token to this extension's ownership-tracking data structures.
	 * @param to address representing the new owner of the given token ID
	 * @param tokenId uint256 ID of the token to be added to the tokens list of the given address
	 */
	function _addTokenToOwnerEnumeration(address to, uint256 tokenId) private {
        uint256 length=ERC721.balanceOf(to);
		_ownedTokens[to][length]=tokenId;
		_ownedTokensIndex[tokenId]=length;
	}

	/**
	 * @dev Private function to add a token to this extension's token tracking data structures.
	 * @param tokenId uint256 ID of the token to be added to the tokens list
	 */
	function _addTokenToAllTokensEnumeration(uint256 tokenId) private {
		_allTokensIndex[tokenId]=_allTokens.length;
		_allTokens.push(tokenId);
	}

	/**
	 * @dev Private function to remove a token from this extension's ownership-tracking data structures. Note that
	 * while the token is not assigned a new owner, the `_ownedTokensIndex` mapping is _not_ updated: this allows for
	 * gas optimizations e.g. when performing a transfer operation (avoiding double writes).
	 * This has O(1) time complexity, but alters the order of the _ownedTokens array.
	 * @param from address representing the previous owner of the given token ID
	 * @param tokenId uint256 ID of the token to be removed from the tokens list of the given address
	 */
	function _removeTokenFromOwnerEnumeration(address from, uint256 tokenId) private {
        // To prevent a gap in from's tokens array, we store the last token in the index of the token to delete, and
        // then delete the last slot (swap and pop).

        uint256 lastTokenIndex=ERC721.balanceOf(from)-1;
        uint256 tokenIndex=_ownedTokensIndex[tokenId];

		// When the token to delete is the last token, the swap operation is unnecessary
		if (tokenIndex!=lastTokenIndex) {
            uint256 lastTokenId=_ownedTokens[from][lastTokenIndex];

			_ownedTokens[from][tokenIndex]=lastTokenId; // Move the last token to the slot of the to-delete token
			_ownedTokensIndex[lastTokenId]=tokenIndex; // Update the moved token's index
		}

		// This also deletes the contents at the last position of the array
		delete _ownedTokensIndex[tokenId];
		delete _ownedTokens[from][lastTokenIndex];
	}

	/**
	 * @dev Private function to remove a token from this extension's token tracking data structures.
	 * This has O(1) time complexity, but alters the order of the _allTokens array.
	 * @param tokenId uint256 ID of the token to be removed from the tokens list
	 */
	function _removeTokenFromAllTokensEnumeration(uint256 tokenId) private {
        // To prevent a gap in the tokens array, we store the last token in the index of the token to delete, and
        // then delete the last slot (swap and pop).

        uint256 lastTokenIndex=_allTokens.length-1;
        uint256 tokenIndex=_allTokensIndex[tokenId];

        // When the token to delete is the last token, the swap operation is unnecessary. However, since this occurs so
        // rarely (when the last minted token is burnt) that we still do the swap here to avoid the gas cost of adding
        // an 'if' statement (like in _removeTokenFromOwnerEnumeration)
        uint256 lastTokenId=_allTokens[lastTokenIndex];

		_allTokens[tokenIndex]=lastTokenId; // Move the last token to the slot of the to-delete token
		_allTokensIndex[lastTokenId]=tokenIndex; // Update the moved token's index

		// This also deletes the contents at the last position of the array
		delete _allTokensIndex[tokenId];
		_allTokens.pop();
	}
}

// File: @openzeppelin/contracts/access/Ownable.sol
pragma solidity^0.8.0;
/**
 * @dev Contract module which provides a basic access control mechanism, where
 * there is an account (an owner) that can be granted exclusive access to
 * specific functions.
 *
 * By default, the owner account will be the one that deploys the contract. This
 * can later be changed with {transferOwnership}.
 *
 * This module is used through inheritance. It will make available the modifier
 * `onlyOwner`, which can be applied to your functions to restrict their use to
 * the owner.
 */
abstract contract Ownable is Context {
    address private _owner;

    event OwnershipTransferred(address indexed previousOwner, address indexed newOwner);

	/**
	 * @dev Initializes the contract setting the deployer as the initial owner.
	 */
	constructor() {
		_setOwner(_msgSender());
	}

	/**
	 * @dev Returns the address of the current owner.
	 */
	function owner() public view virtual returns(address) {
		return _owner;
	}

    /**
     * @dev Throws if called by any account other than the owner.
     */
    modifier onlyOwner() {
		require(owner()==_msgSender(), "Ownable: caller is not the owner");
		_;
	}

	/**
	 * @dev Leaves the contract without owner. It will not be possible to call
	 * `onlyOwner` functions anymore. Can only be called by the current owner.
	 *
	 * NOTE: Renouncing ownership will leave the contract without an owner,
	 * thereby removing any functionality that is only available to the owner.
	 */
	function renounceOwnership() public virtual onlyOwner {
		_setOwner(address(0));
	}

	/**
	 * @dev Transfers ownership of the contract to a new account (`newOwner`).
	 * Can only be called by the current owner.
	 */
	function transferOwnership(address newOwner) public virtual onlyOwner {
		require(newOwner!=address(0), "Ownable: new owner is the zero address");
		_setOwner(newOwner);
	}

	function _setOwner(address newOwner) private {
        address oldOwner=_owner;
		_owner=newOwner;
        emit OwnershipTransferred(oldOwner, newOwner);
	}
}

pragma solidity>=0.7.0<0.9.0;

contract ZombieRobotsClubNFT is ERC721Enumerable, Ownable {
  using Strings for uint256;

		string baseURI;
  string public baseExtension=".json";
  uint256 public cost=5 ether;
  uint256 public maxSupply=10000;
  uint256 public maxMintAmount=20;
  bool public paused=false;
  bool public revealed=false;
  string public notRevealedUri;

	constructor(
		string memory _name,
		string memory _symbol,
		string memory _initBaseURI,
		string memory _initNotRevealedUri
	) ERC721(_name, _symbol) {
		setBaseURI(_initBaseURI);
		setNotRevealedURI(_initNotRevealedUri);
	}

	// internal
	function _baseURI() internal view virtual override returns(string memory) {
		return baseURI;
	}

	// public
	function mint(uint256 _mintAmount) public payable {
    uint256 supply=totalSupply();
		require(!paused);
		require(_mintAmount>0);
		require(_mintAmount<=maxMintAmount);
		require(supply+_mintAmount<=maxSupply);

		if (msg.sender!=owner()) {
			require(msg.value>=cost*_mintAmount);
		}

		for (uint256 i=1; i<=_mintAmount; i++) {
			_safeMint(msg.sender, supply+i);
		}
	}

	function walletOfOwner(address _owner)
	public
	view
	returns(uint256[] memory)
	{
    uint256 ownerTokenCount=balanceOf(_owner);
		uint256[] memory tokenIds=new uint256[](ownerTokenCount);
		for (uint256 i; i<ownerTokenCount; i++) {
			tokenIds[i]=tokenOfOwnerByIndex(_owner, i);
		}
		return tokenIds;
	}

	function tokenURI(uint256 tokenId)
	public
	view
	virtual
	override
	returns(string memory)
	{
		require(
			_exists(tokenId),
			"ERC721Metadata: URI query for nonexistent token"
		);

		if (revealed==false) {
			return notRevealedUri;
		}

    string memory currentBaseURI=_baseURI();
		return bytes(currentBaseURI).length>0
			? string(abi.encodePacked(currentBaseURI, tokenId.toString(), baseExtension))
			:"";
	}

	//only owner
	function reveal() public onlyOwner() {
		revealed=true;
	}

	function setCost(uint256 _newCost) public onlyOwner() {
		cost=_newCost;
	}

	function setmaxMintAmount(uint256 _newmaxMintAmount) public onlyOwner() {
		maxMintAmount=_newmaxMintAmount;
	}

	function setNotRevealedURI(string memory _notRevealedURI) public onlyOwner {
		notRevealedUri=_notRevealedURI;
	}

	function setBaseURI(string memory _newBaseURI) public onlyOwner {
		baseURI=_newBaseURI;
	}

	function setBaseExtension(string memory _newBaseExtension) public onlyOwner {
		baseExtension=_newBaseExtension;
	}

	function pause(bool _state) public onlyOwner {
		paused=_state;
	}

	function withdraw() public payable onlyOwner {
		(bool success, ) = payable(msg.sender).call{ value: address(this).balance } ("");
		require(success);
	}
}

The error is the following:
     ┌─ /home/lucas/Documents/solang/examples/test.sol:1033:69
     │
 229 │     function supportsInterface(bytes4 interfaceId) public view virtual override returns(bool) {
     │     ----------------------------------------------------------------------------------------- previous definition of function 'supportsInterface'
     ·
1033 │     function supportsInterface(bytes4 interfaceId) public view virtual override(IERC165, ERC721) returns(bool) {
     │                                                                        ^^^^^^^^^^^^^^^^^^^^^^^^^

error: function 'supportsInterface' override list does not contain 'ERC165'
     ┌─ /home/lucas/Documents/solang/examples/test.sol:1033:69
     │
 229 │     function supportsInterface(bytes4 interfaceId) public view virtual override returns(bool) {
     │     ----------------------------------------------------------------------------------------- previous definition of function 'supportsInterface'
     ·
1033 │     function supportsInterface(bytes4 interfaceId) public view virtual override(IERC165, ERC721) returns(bool) {
     │                                                                        ^^^^^^^^^^^^^^^^^^^^^^^^^

Maybe you will meet error soon  "error: conversion to bytes1 from uint256 not allowed".
Error code:
function _toString(uint i) internal pure returns (string memory c) {
    if (i == 0) return "0";
    uint j = i;
    uint length;
    while (j != 0) {
        length++;
        j /= 10;
    }
    bytes memory str = new bytes(length);
    uint k = length - 1;
    while (i != 0) {
        str[k--] = byte(48 + i % 10);
        i /= 10;
    }
    c = string(str);
}

Maybe you will meet error soon "error: conversion to bytes1 from uint256 not allowed". Error code:
function _toString(uint i) internal pure returns (string memory c) {
    if (i == 0) return "0";
    uint j = i;
    uint length;
    while (j != 0) {
        length++;
        j /= 10;
    }
    bytes memory str = new bytes(length);
    uint k = length - 1;
    while (i != 0) {
        str[k--] = byte(48 + i % 10);
        i /= 10;
    }
    c = string(str);
}

Error line

str[k--] = byte(48 + i % 10);

You have declared i as uint, which means it is a 256-bit integer. When you do 48 + i % 10, the compiler will cast all numbers to the widest integer available to avoid truncating the response, so the result will be a 256-bit integer too.
256 bits are 32 bytes, so there is no way to convert 32 bytes into 1 bytes without losing information. This is what the error means. If you are sure there is no problem truncating your result to one byte, just do str[k--] = uint8(48 + i % 10).
In addition, you function will still not compile because the variable length is undefined. You have not assigned a value to it before using it.

也许您很快就会遇到错误“错误：不允许从 uint256 转换为 bytes1”。错误代码：
function _toString(uint i) internal pure returns (string memory c) {
    if (i == 0) return "0";
    uint j = i;
    uint length;
    while (j != 0) {
        length++;
        j /= 10;
    }
    bytes memory str = new bytes(length);
    uint k = length - 1;
    while (i != 0) {
        str[k--] = byte(48 + i % 10);
        i /= 10;
    }
    c = string(str);
}

错误线

str[k--] = 字节（48 + i % 10）；

您已声明i为uint，这意味着它是一个 256 位整数。当您这样做48 + i % 10时，编译器会将所有数字转换为可用的最宽整数以避免截断响应，因此结果也将是 256 位整数。
256位就是32个字节，没有办法将32个字节转换成1个字节而不丢失信息。这就是错误的意思。如果您确定将结果截断为一个字节没有问题，只需执行str[k--] = uint8(48 + i % 10).
此外，您的函数仍然无法编译，因为变量length未定义。在使用它之前，您还没有为其赋值。

Maybe you will meet error soon "error: conversion to bytes1 from uint256 not allowed". Error code:
function _toString(uint i) internal pure returns (string memory c) {
    if (i == 0) return "0";
    uint j = i;
    uint length;
    while (j != 0) {
        length++;
        j /= 10;
    }
    bytes memory str = new bytes(length);
    uint k = length - 1;
    while (i != 0) {
        str[k--] = byte(48 + i % 10);
        i /= 10;
    }
    c = string(str);
}

Error line

str[k--] = byte(48 + i % 10);

You have declared i as uint, which means it is a 256-bit integer. When you do 48 + i % 10, the compiler will cast all numbers to the widest integer available to avoid truncating the response, so the result will be a 256-bit integer too.
256 bits are 32 bytes, and there is no way to convert 32 bytes into 1 bytes without losing information. This is what the error means. If you are sure there is no problem truncating your result to one byte, just do str[k--] = uint8(48 + i % 10).
In addition, you function will still not compile because the variable length is undefined. You have not assigned a value to it before using it.

It passed when i convert byte to uint8 and set length equal 100.But new problem coming in remix.ethereum.org.
Code:
// SPDX-License-Identifier: GPL-3.0

pragma solidity >=0.7.0 <0.9.0;

contract Test{
    function _toString(uint i) public pure returns (string memory c) {
        if (i == 0) return "0";
        uint j = i;
        uint length = 100;
        while (j != 0) {
            j /= 10;
        }
        bytes memory str = new bytes(length);
        uint k = length - 1;
        while (i != 0) {
            str[k--] = uint8(48 + i % 10);
            i /= 10;
        }
        c = string(str);
    }
}

Error:
  TypeError: Type uint8 is not implicitly convertible to expected type bytes1.
  --> contracts/Test.sol:17:24:

  17 | str[k--] = uint8(48 + i % 10);
    ^^^^^^^^^^^^^^^^^^

The contract you pasted works fine with Solang. I've tested that. remix.ethereum.org utilizes the Solc Ethereum compiler, which works quite differently from Solang. This is the reason for the error!
If your goal is to make the contract work with solc, then just exchange that line for str[k--] = bytes1(uint8(48 + i % 10)).

It worked when i add bytes1 convert to  uint8.
Thanks~

repo: hyperledger-labs/solang


text:
Fix interface inheritance bug

This PR fixes a bug, in which we couldn't not call a function from an interfaced that was inherited from another one.
This is one of the bugs found in issue #744.

So the code should check if the function is declared public or external and if not, give an error. Non-public functions are not callable so this would result in a broken transaction.

Looks like this routine does not check if the function is declared public or external.
Also the same problem exists for external function calls with named arguments, e.g. foo.bar({a: 1, b: 2}); (see method_call_named_args)

Can you provide an example of the foo.bar({a: 1, b: 2}) case?

Looks like this routine does not check if the function is declared public or external.
Also the same problem exists for external function calls with named arguments, e.g. foo.bar({a: 1, b: 2}); (see method_call_named_args)

Can you provide an example of the foo.bar({a: 1, b: 2}) case?

In the babylink example replace the call to createPair with:
        uniswapV2Pair = IUniswapV2Factory(_uniswapV2Router.factory())
            .createPair({tokenA: address(this), tokenB:_uniswapV2Router.WETH()});

does that work?

Looks like this routine does not check if the function is declared public or external.
Also the same problem exists for external function calls with named arguments, e.g. foo.bar({a: 1, b: 2}); (see method_call_named_args)

Can you provide an example of the foo.bar({a: 1, b: 2}) case?

In the babylink example replace the call to createPair with:
        uniswapV2Pair = IUniswapV2Factory(_uniswapV2Router.factory())
            .createPair({tokenA: address(this), tokenB:_uniswapV2Router.WETH()});

does that work?

I added the lines you suggested, but surprisingly the compilation does not fail.

I added the lines you suggested, but surprisingly the compilation does not fail.

Sorry that was not an inherited function. I wrote this.
interface A {
	function foo(int a, int b) external;
}

interface B is A {
	function bar(int a, int b) external;
}

contract C {
	function test(B b) public {
		b.foo({a: 1, b: 2});
	}
}

You should be able to do this yourself without asking me.

You should be able to do this yourself without asking me.

I deleted my comment, but you were faster to answer that 😅

source: gharchive/pull-request

authors: LucasSte seanyoung

license_type: permissive

license_source: github-api


text:
Devcontainer ruff pytest

Bring in changes from commit 48e24043f0a5ad89b5e6e808c26b9552a8856abd.
Updates devcontainer to run pytests in Testing view and integrate ruff and black into the IDE better.
One change is in devcontainer.json, setting the black formatted to "useBundled"... no idea why that extension just decided there was an issue with the typing_extensions lib in the environment but it did. The change also needed in the main branch now 🤷
Well, looks like it got updated overnight... sigh.
Published 2022-04-14, 14:24:13
Last released 2023-11-08, 02:11:58
Last updated 2023-11-08, 10:56:39
Identifier ms-python.black-formatter

too many files pulled in, too risky. can make the necessary changes manually

repo: hyperledger/aries-cloudagent-python


text:
feat(credentials): find didcomm message methods

Adds findProposalMessage, findOfferMessage, findRequestMessage, findCredentialMessage methods to the credentials module to be able to access the did comm message associated with a credential exchange.

Codecov Report

Merging #887 (e39f245) into main (8d67e63) will decrease coverage by 0.97%.
The diff coverage is 90.47%.

@@            Coverage Diff             @@
##             main     #887      +/-   ##
==========================================
- Coverage   87.57%   86.60%   -0.98%
==========================================
  Files         463      463
  Lines       11083    11099      +16
  Branches     1745     1745
==========================================
- Hits         9706     9612      -94
- Misses       1377     1487     +110

Impacted Files
Coverage Δ

...les/credentials/protocol/v1/V1CredentialService.ts
68.01% <33.33%> (-27.38%)
:arrow_down:

.../core/src/modules/credentials/CredentialsModule.ts
93.15% <100.00%> (+0.62%)
:arrow_up:

...protocol/v1/messages/V1ProposeCredentialMessage.ts
83.33% <100.00%> (-2.78%)
:arrow_down:

...protocol/v1/handlers/V1ProposeCredentialHandler.ts
36.84% <0.00%> (-52.64%)
:arrow_down:

...s/protocol/v1/messages/V1OfferCredentialMessage.ts
86.20% <0.00%> (-13.80%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d67e63...e39f245. Read the comment docs.

authors: TimoGlastra codecov-commenter

repo: hyperledger/aries-framework-javascript


text:
Added command line option --static-nodes-file (#1414)

Now able to inject static nodes by explicitly specifying
a static nodes JSON file (.json) on the command line
Signed-off-by: Terrence Cooke terrence.s.cooke@gmail.com

PR description
Fixed Issue(s)

Changelog

[x] I thought about the changelog and included a changelog update if required.

Thanks for the contribution! We need to add a test in BesuCommandTest that makes sure StaticNodesParser.fromPath(staticNodesPath, getEnodeDnsConfiguration()); gets called with the correct values when the option is absent and present with a value. You should be able to copy and edit a test from that class that does something similar.

Sure, I'll get on it.

Also, before I forget, this is going to need a line in the changelog as well.

I added three test methods to class BesuCommandTest. One tests a valid file is used, a second test when an ill-formed JSON file is specified, and a third tests when the option is used but no parameter is specified.
I attempted to test when an file that does not exist is given as a parameter:
--static-nodes-file=some-file-that-does-not-exist
But no message was returned at all during the test build.  This is contrary to running besu manually, you'll get the message:
| main | INFO  | StaticNodesParser | StaticNodes file /home/tcooke/code/gitprojs/besu/build/install/besu/staticdir/some-file-that-does-not-exist does not exist, no static connections will be created.
Any suggestions on how I should proceed?
I was considering omitting this particularly test. What do you think?

As far as adding a line to the changelog, what should be added: the tests and the added cli option, or just the tests?

I've decided that the best test for when a file does not exist is to make sure no error message was returned. The commantOutput will be ignored for now.
As for the changelog, I'll simply add the line from the commit message:
Added command line option --static-nodes-file (#1414)

Added tests to BesuCommand and a line to CHANGELOG.md

Running besu as a background service fails with "unable to parse static nodes file.  Using a config.toml to start.  Loads fine from TCL and does not require a static nodes jason.  I don't have a jason to parse.  Why is besu failing?
brad@tiny:~/besu-21.1.3$ sudo journalctl -fu besu.service
-- Logs begin at Mon 2021-03-29 13:07:26 EDT. --
Mar 30 09:45:03 tiny besu[67434]: ANTLR Tool version 4.7.1 used for code generation does not match the current runtime version 4.8ANTLR Runtime version 4.7.1 used for parser compilation does not match the current runtime version 4.8ANTLR Tool version 4.7.1 used for code generation does not match the current runtime version 4.8ANTLR Runtime version 4.7.1 used for parser compilation does not match the current runtime version 4.82021-03-30 09:45:03.522-04:00 | main | INFO  | AbstractAltBnPrecompiledContract | Using LibEthPairings native alt bn128
Mar 30 09:45:04 tiny besu[67434]: 2021-03-30 09:45:04.173-04:00 | main | INFO  | SECP256K1 | Using native secp256k1
Mar 30 09:45:04 tiny besu[67434]: 2021-03-30 09:45:04.178-04:00 | main | INFO  | Besu | Starting Besu version: besu/v21.1.3/linux-x86_64/openjdk-java-11
Mar 30 09:45:04 tiny besu[67434]: 2021-03-30 09:45:04.342-04:00 | main | INFO  | Besu | Static Nodes file = /media/brad/Ether/mainnet/static-nodes.json
Mar 30 09:45:04 tiny besu[67434]: 2021-03-30 09:45:04.343-04:00 | main | INFO  | StaticNodesParser | Unable to parse static nodes file (/media/brad/Ether/mainnet/static-nodes.json)
Mar 30 09:45:04 tiny besu[67434]: /media/brad/Ether/mainnet/static-nodes.json
Mar 30 09:45:04 tiny besu[67434]: To display full help:
Mar 30 09:45:04 tiny besu[67434]: besu [COMMAND] --help
Mar 30 09:45:04 tiny systemd[1]: besu.service: Main process exited, code=exited, status=1/FAILURE
Mar 30 09:45:04 tiny systemd[1]: besu.service: Failed with result 'exit-code'.
Mar 30 09:45:09 tiny systemd[1]: besu.service: Scheduled restart job, restart counter is at 214.

Does the file /media/brad/Ether/mainnet/static-nodes.json exist? If so, what are its contents?

I don't have one.  I can start besu using a config.toml from command line with no problem.  but when I start besu as a background service, using the same config.toml file,  it fails wanting a static file.  what am I doing wrong?

here is config.toml
miner-enabled=false
graphql-http-enabled=false
sync-mode="FAST"
rpc-http-host="127.0.0.1"
pruning-enabled=false
rpc-ws-enabled=false
data-path="/media/brad/Ether/goerli"
rpc-http-enabled=true
rpc-http-apis=["ETH", "NET", "WEB3"]
network="goerli"
rpc-http-port="8545"

running service with a new user and group named: besu

and the besu.service file as well please :)

sure!
[Unit]
Description=Ethereum besu client
After=network.target
Wants=network.target
[Service]
User=besu
Group=besu
Type=simple
Restart=always
RestartSec=5
ExecStart=/home/brad/besu-21.1.3/bin/besu --config-file=/home/brad/besu-21.1.3/>
[Install]
WantedBy=default.target

It's odd because clearly your service is using /media/brad/Ether/mainnet as its data path but your config.toml specifies data-path="/media/brad/Ether/goerli". What's going on at the end of this line ExecStart=/home/brad/besu-21.1.3/bin/besu --config-file=/home/brad/besu-21.1.3/> ? That > is suspicious

authors: RatanRSur how2applyIT terrencecooke

repo: hyperledger/besu


text:
Downgrade rocksdbjni to 8.3.2 following FOREST bug

Bug introduced by upgrading to 8.9.1 in  9b7efb9 (#6377)
This is a revert of that specific dependency, will need further work to fix FOREST + 8.9.1+
Tested on the canary that found the bug: prd-elc-besu-prysm-mainnet-nightly-forest-snap
and synced a fresh FOREST and BONSAI node on holesky.

db upgrade and downgrade tests performed: downgrade was from this PR to https://github.com/hyperledger/besu/commit/f721c1c2c26bf695edbbba6ba612c5fb312aa57c on a bonsai node


text:
docs(readme): consider using merge-chance badge

Description
Some more statistics and a badge that comes with it that you can put into your readme:
https://merge-chance.info/target?repo=hyperledger/cactus
cc: @sfuji822 @takeutak @hartm @jonathan-m-hamilton

The merge-chance product no longer exists (domain redirects to a registrar parking page or similar spam site)

source: gharchive/issue

repo: hyperledger/cacti


text:
I successfully ran node main.js on composer, but the result of the test is this

My cpu share has exceeded 100%!! Why?
What is the difference between dev-peer0.org1.example.co...0.1.0 and peer0.org1.example.com? What do they mean? What does Traffic In and Traffic Out and Disc Read mean? What do the names in docker mean? Why is there a difference between CPU(max) and CPU(avg)? Please explain

@zcyzhu For general questions please use the Rocket.Chat #caliper channel or the Caliper mailing list. GitHub issues should only be raised for confirmed bugs or enhancement suggestions.

authors: aklenik zcyzhu

repo: hyperledger/caliper


text:
behave test scenarios issue_#680 and issue_#1000 fail with latest commit tag

commit 8b6eb2ff1f253d3a3546d99d1ff9f6a79442192c
Merge: 509b2d6 4e19fa4
Author: Sheehan Anderson <sranderson@gmail.com>
Date:   Thu May 12 15:13:12 2016 -0400

    Merge pull request #1463 from novusopt/issue-1462

    Use new peer command in the docker-compose files

Issue_#1000 passes when I increase wait time from 60 seconds to 240 seconds.
Issue_#680 is a bit more interesting. When I increase wait time from 60 seconds to 240 seconds, @1.1  passes but @1.2 and @1.3 fail. When I increase wait time to 480 seconds, @1.1 and @1.2 pass but @1.3 still fails. Maybe if I increase the wait time further and @1.3 will eventually pass. But I tend to think that the slowness isn't due to the machine but rather some inherent problem with the protocol that warrants a closer look. I'm attaching the test run log, as well as logs of the containers, for both 240 second and 480 second runs.
behave_issue_680_240sec.zip
behave_issue_680_480sec.zip

After moving to a machine with 32GB memory, even with the default 60 seconds wait time, I no longer get timeouts for issue_680. Instead I'm getting indexError. All logs attached (note in this particular run @1.1 still had a timeout).
behave_issue_680_60sec.zip

Per Tuan's request, log files for issue_1000 behave test with @doNotDecompose uncommented.
behave_issue_1000_60sec.zip

PR #1476 fixes the indexErrors problem

I can confirm that with the patch I no longer get an IndexError for issue_1000 @1.1 behave test. Instead, I'm getting a timeout, which is still being investigated.

running on @gongsu832 's machine,  I'm consistently seeing a timeout in the @issue_1000 test case during the batch run and not the classic run.
1466.zip

02:21:09.224 [consensus/obcpbft] assignSequenceNumbers -> WARN 0e0 Replica 1 could not assign value to contents of seqNo 31, found only 0 missing P entries
02:21:09.224 [consensus/obcpbft] sendNewView -> INFO 0e1 Replica 1 could not assign sequence numbers for new view

I think this is where it's at.  Currently trying to understand why this can happen.

02:20:56.436 [consensus/obcpbft] restoreState -> INFO 038 Replica 1 restored state: view: 0, seqNo: 31, pset: 1, qset: 0, reqs: 31, chkpts: 1
Seems the restored qset is empty.

From looking at the code, it may be that the qset is never persisted properly, because .prePrepared() returns false if there is no corresponding request in the reqStore.  How does this pass behave tests usually?

@gongsu832 @tuand27613 what commit was used for the latest log?

commit listed in first post.

One odd thing is this (vp0):
02:19:14.369 [devops] Deploy -> DEBU 79d Creating secure transaction 1edd7021ab71b766f4928a9ef91182c018dffb86fef7a4b5a5516ac590a87957e21a62d939df817f5105f524abddcddfc7b1a60d780f02d8235bd7af9db81b66
02:19:14.738 [devops] Deploy -> DEBU 79e Sending deploy transaction (1edd7021ab71b766f4928a9ef91182c018dffb86fef7a4b5a5516ac590a87957e21a62d939df817f5105f524abddcddfc7b1a60d780f02d8235bd7af9db81b66) to validator
02:19:14.738 [peer] sendTransactionsToLocalEngine -> DEBU 79f Marshalling transaction CHAINCODE_DEPLOY to send to local engine
02:19:14.759 [peer] sendTransactionsToLocalEngine -> DEBU 7a0 Sending message CHAIN_TRANSACTION with timestamp seconds:1463278754 nanos:759499000  to local engine
02:19:14.759 [crypto] CloseClient -> INFO 7a1 Closing client [binhn]...
02:19:14.795 [rest] Deploy -> INFO 7a2 Successfuly deployed chainCode: 1edd7021ab71b766f4928a9ef91182c018dffb86fef7a4b5a5516ac590a87957e21a62d939df817f5105f524abddcddfc7b1a60d780f02d8235bd7af9db81b66.
02:19:15.103 [consensus/obcpbft] processMessage -> INFO 7a3 New consensus request received: +/FhSCokroTZH0/InSFGvRHxR+PD23tOAj2Hj+ySnIAZYwpyJCkHKvG0Xwg5Fjl+iPKS7UUdhoF+NxC70ACLTQ==
02:19:15.449 [consensus/obcpbft] leaderProcReq -> DEBU 7a4 Batch primary 0 queueing new request +/FhSCokroTZH0/InSFGvRHxR+PD23tOAj2Hj+ySnIAZYwpyJCkHKvG0Xwg5Fjl+iPKS7UUdhoF+NxC70ACLTQ==
02:19:15.449 [consensus/obcpbft] startBatchTimer -> DEBU 7a5 Replica 0 started the batch timer
02:19:15.449 [consensus/obcpbft] stopBatchTimer -> DEBU 7a6 Replica 0 stopped the batch timer
02:19:15.470 [consensus/obcpbft] sendBatch -> INFO 7a7 Creating batch with 1 requests
02:19:15.470 [consensus/obcpbft] main -> DEBU 7a8 Replica 0 received incoming message from 0

later:
02:19:16.657 [consensus/obcpbft] recvCommit -> DEBU 7ec Replica 0 received commit from replica 2 for view=0/seqNo=1
02:19:16.657 [consensus/obcpbft] prepared -> DEBU 7ed Replica 0 prepare count for view=0/seqNo=1: 2
02:19:16.657 [consensus/obcpbft] committed -> DEBU 7ee Replica 0 commit count for view=0/seqNo=1: 3
02:19:16.657 [consensus/obcpbft] stopTimer -> DEBU 7ef Replica 0 stopping a running new view timer
02:19:16.657 [consensus/obcpbft] prepared -> DEBU 7f0 Replica 0 prepare count for view=0/seqNo=1: 2
02:19:16.657 [consensus/obcpbft] committed -> DEBU 7f1 Replica 0 commit count for view=0/seqNo=1: 3
02:19:16.657 [consensus/obcpbft] executeOne -> INFO 7f2 Replica 0 executing/committing request for view=0/seqNo=1 and digest WDT59lht+THe1c0ipRBawHU0SfXRFjzHaqy9BhQ/fkW/pfRlq3c78tSCeCVDxlaYqandlFSMc5gzYw5nT+l7VQ==
02:19:16.657 [consensus/obcpbft] executeOutstanding -> DEBU 7f3 replica 0 certstore map[{v:0 n:1}:0xc8203f82a0]
02:19:16.657 [consensus/obcpbft] main -> DEBU 7f4 Replica 0 service thread looping
02:19:16.694 [consensus/obcpbft] main -> DEBU 7f5 Replica 0 received incoming message from 3
02:19:16.694 [consensus/obcpbft] recvPrepare -> DEBU 7f6 Replica 0 received prepare from replica 3 for view=0/seqNo=1
02:19:16.694 [consensus/obcpbft] prepared -> DEBU 7f7 Replica 0 prepare count for view=0/seqNo=1: 3
02:19:16.694 [consensus/obcpbft] prepared -> DEBU 7f8 Replica 0 prepare count for view=0/seqNo=1: 3
02:19:16.694 [consensus/obcpbft] main -> DEBU 7f9 Replica 0 service thread looping
02:19:16.695 [consensus/obcpbft] main -> DEBU 7fa Replica 0 received incoming message from 3
02:19:16.695 [consensus/obcpbft] recvCommit -> DEBU 7fb Replica 0 received commit from replica 3 for view=0/seqNo=1
02:19:16.695 [consensus/obcpbft] prepared -> DEBU 7fc Replica 0 prepare count for view=0/seqNo=1: 3
02:19:16.695 [consensus/obcpbft] committed -> DEBU 7fd Replica 0 commit count for view=0/seqNo=1: 4
02:19:16.695 [consensus/obcpbft] stopTimer -> DEBU 7fe Replica 0 stopping a running new view timer
02:19:16.695 [consensus/obcpbft] main -> DEBU 7ff Replica 0 service thread looping
02:19:17.037 [chaincode] getArgsAndEnv -> DEBU 800 Executable is /opt/gopath/bin/1edd7021ab71b766f4928a9ef91182c018dffb86fef7a4b5a5516ac590a87957e21a62d939df817f5105f524abddcddfc7b1a60d780f02d8235bd7af9db81b66
02:19:17.037 [chaincode] Deploy -> DEBU 801 deploying chaincode 1edd7021ab71b766f4928a9ef91182c018dffb86fef7a4b5a5516ac590a87957e21a62d939df817f5105f524abddcddfc7b1a60d780f02d8235bd7af9db81b66(networkid:dev,peerid:vp0)
02:19:17.037 [container] lockContainer -> DEBU 802 waiting for container(dev-vp0-1edd7021ab71b766f4928a9ef91182c018dffb86fef7a4b5a5516ac590a87957e21a62d939df817f5105f524abddcddfc7b1a60d780f02d8235bd7af9db81b66) lock
02:19:17.037 [container] lockContainer -> DEBU 803 got container (dev-vp0-1edd7021ab71b766f4928a9ef91182c018dffb86fef7a4b5a5516ac590a87957e21a62d939df817f5105f524abddcddfc7b1a60d780f02d8235bd7af9db81b66) lock

Finally:
02:19:25.104 [consensus/obcpbft] main -> WARN 81f Batch replica 0 custody expired, complaining: +/FhSCokroTZH0/InSFGvRHxR+PD23tOAj2Hj+ySnIAZYwpyJCkHKvG0Xwg5Fjl+iPKS7UUdhoF+NxC70ACLTQ==

(repeats)
Questions

Why is the batch timer started and immediately stopped?
Why is the executed request not removed from custody?

failing consistently in Vagrant. using commit 28b893c
1466_classic.zip
1466_batch.zip

I think this is a whitelist issue?

@corecode is this still an issue? Seems to me that if different timeouts yield different results that the behave tests should be augmented to attempt various timeouts so that we aren't sunning such tests manually. @jeffgarratt

repo: hyperledger/fabric

license_source: bigquery


text:
Prepare for go 1.14

Before we can move to go 1.14, we need to make sure things work with go 1.14...

bump golang.org/x/crypto/sha3 to pick up checkptr fix
soften assertion in error string to handle quotes present in go 1.14
error that is not present in go 1.13

Thanks Matt, LGTM

I guess 1.14 doesn't fix pre-existing flakes ;)

I guess 1.14 doesn't fix pre-existing flakes

Nope. And I just hit another one (FAB-17376).

bump golang.org/x/crypto/sha3 to pick up checkptr fix

Just wondering why is this necessary? We don't use sha3 in Fabric.

bump golang.org/x/crypto/sha3 to pick up checkptr fix

Just wondering why is this necessary? We don't use sha3 in Fabric.

fatal error: checkptr: unsafe pointer conversion

goroutine 232 [running]:
runtime.throw(0x15e5045, 0x23)
	/usr/local/Cellar/go/1.14/libexec/src/runtime/panic.go:1112 +0x72 fp=0xc00073b920 sp=0xc00073b8f0 pc=0x1073402
runtime.checkptrAlignment(0xc0007642a9, 0x1554780, 0x1)
	/usr/local/Cellar/go/1.14/libexec/src/runtime/checkptr.go:13 +0xd0 fp=0xc00073b950 sp=0xc00073b920 pc=0x1045790
github.com/hyperledger/fabric/vendor/golang.org/x/crypto/sha3.xorInUnaligned(0xc0007641c0, 0xc0007642a9, 0x88, 0xa8)
	/Users/sykesm/workspace/fabric/src/github.com/hyperledger/fabric/vendor/golang.org/x/crypto/sha3/xor_unaligned.go:13 +0x60 fp=0xc00073b988 sp=0xc00073b950 pc=0x12650c0
github.com/hyperledger/fabric/vendor/golang.org/x/crypto/sha3.(*state).permute(0xc0007641c0)
	/Users/sykesm/workspace/fabric/src/github.com/hyperledger/fabric/vendor/golang.org/x/crypto/sha3/sha3.go:84 +0x1d3 fp=0xc00073b9d8 sp=0xc00073b988 pc=0x1263cc3
github.com/hyperledger/fabric/vendor/golang.org/x/crypto/sha3.(*state).padAndPermute(0xc0007641c0, 0xc000054806)
	/Users/sykesm/workspace/fabric/src/github.com/hyperledger/fabric/vendor/golang.org/x/crypto/sha3/sha3.go:117 +0x347 fp=0xc00073ba80 sp=0xc00073b9d8 pc=0x1264087
github.com/hyperledger/fabric/vendor/golang.org/x/crypto/sha3.(*state).Read(0xc0007641c0, 0xc000734340, 0x20, 0x20, 0xb, 0xb, 0x1)
	/Users/sykesm/workspace/fabric/src/github.com/hyperledger/fabric/vendor/golang.org/x/crypto/sha3/sha3.go:163 +0x2e0 fp=0xc00073bb10 sp=0xc00073ba80 pc=0x1264b50
github.com/hyperledger/fabric/vendor/golang.org/x/crypto/sha3.(*state).Sum(0xc000764000, 0x0, 0x0, 0x0, 0xb, 0x0, 0x0)
	/Users/sykesm/workspace/fabric/src/github.com/hyperledger/fabric/vendor/golang.org/x/crypto/sha3/sha3.go:190 +0x233 fp=0xc00073bba8 sp=0xc00073bb10 pc=0x1264db3
github.com/hyperledger/fabric/bccsp/sw.(*hasher).Hash(0xc0000100e8, 0xc000200410, 0xb, 0xb, 0x16798e0, 0x1999f68, 0xc000200410, 0x10, 0x100000000000000, 0x0, ...)
	/Users/sykesm/workspace/fabric/src/github.com/hyperledger/fabric/bccsp/sw/hash.go:32 +0xca fp=0xc00073bc18 sp=0xc00073bba8 pc=0x14e2cca
github.com/hyperledger/fabric/bccsp/sw.(*CSP).Hash(0xc0000201e0, 0xc000200410, 0xb, 0xb, 0x16798e0, 0x1999f68, 0x0, 0xc00022e0c0, 0xc0004c61c0, 0xc000703568, ...)
	/Users/sykesm/workspace/fabric/src/github.com/hyperledger/fabric/bccsp/sw/impl.go:188 +0x1f9 fp=0xc00073bd10 sp=0xc00073bc18 pc=0x14e4f99
github.com/hyperledger/fabric/bccsp/sw.TestECDSALowS(0xc000465320)
	/Users/sykesm/workspace/fabric/src/github.com/hyperledger/fabric/bccsp/sw/impl_test.go:982 +0x275 fp=0xc00073bed0 sp=0xc00073bd10 pc=0x150b2b5
testing.tRunner(0xc000465320, 0x15f6518)
	/usr/local/Cellar/go/1.14/libexec/src/testing/testing.go:992 +0x1ec fp=0xc00073bfd0 sp=0xc00073bed0 pc=0x118f72c
runtime.goexit()
	/usr/local/Cellar/go/1.14/libexec/src/runtime/asm_amd64.s:1373 +0x1 fp=0xc00073bfd8 sp=0xc00073bfd0 pc=0x10a6cf1
created by testing.(*T).Run
	/usr/local/Cellar/go/1.14/libexec/src/testing/testing.go:1043 +0x661

authors: btl5037 sykesm yacovm


text:
E2E Test failure ocassional - pulling docker images

https://github.com/hyperledger/firefly/runs/3866130616?check_suite_focus=true
Pulling dataexchange_0 (ghcr.io/hyperledger/firefly-dataexchange-https:latest)...
latest: Pulling from hyperledger/firefly-dataexchange-https
Digest: sha256:9ea73a56d353bd040f0b6fbd5e0b7db3427d673b598101bf53e803ce87d34fa4
Status: Downloaded newer image for ghcr.io/hyperledger/firefly-dataexchange-https:latest
Pulling ethconnect_1 (ghcr.io/hyperledger/firefly-ethconnect:latest)...
latest: Pulling from hyperledger/firefly-ethconnect
error pulling image configuration: Get "https://ghcr.io/v2/hyperledger/firefly-ethconnect/blobs/sha256:76f0130a3f9df30b3f34796a2288f33e2c7dd712d2e61cfed1612cb9d715c364": dial tcp 140.82.114.33:443: i/o timeout
Error: docker-compose up -d
Failed [1]
Usage:
  ff start <stack_name> [flags]

Flags:
  -h, --help          help for start
  -n, --no-pull       Do not pull latest images when starting
  -b, --no-rollback   Do not automatically rollback changes if first time setup fails

Global Flags:
      --ansi string   control when to print ANSI control characters ("never"|"always"|"auto") (default "auto") (default "auto")
  -v, --verbose       verbose log output

Error: docker-compose up -d

I think we've fixed this one with several CLI enhancements. Closing it for now, and if we still see the problem, we can open it back up again.

authors: nguyer peterbroadhurst

repo: hyperledger/firefly


text:
Add token URI

Depends on https://github.com/hyperledger/firefly-tokens-erc1155/pull/44

Codecov Report

Merging #335 (4359a14) into main (6761542) will not change coverage.
The diff coverage is 100.00%.

:exclamation: Current head 4359a14 differs from pull request most recent head 3aac00c. Consider uploading reports for the commit 3aac00c to get more accurate results

@@            Coverage Diff            @@
##              main      #335   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files          232       232
  Lines        12721     12729    +8
=========================================
+ Hits         12721     12729    +8

Impacted Files
Coverage Δ

internal/apiserver/route_post_token_burn.go
100.00% <ø> (ø)

...nternal/apiserver/route_post_token_burn_by_type.go
100.00% <ø> (ø)

internal/apiserver/route_post_token_mint.go
100.00% <ø> (ø)

...nternal/apiserver/route_post_token_mint_by_type.go
100.00% <ø> (ø)

internal/apiserver/route_post_token_transfer.go
100.00% <ø> (ø)

...nal/apiserver/route_post_token_transfer_by_type.go
100.00% <ø> (ø)

pkg/fftypes/tokenbalance.go
100.00% <ø> (ø)

internal/database/sqlcommon/tokenbalance_sql.go
100.00% <100.00%> (ø)

internal/database/sqlcommon/tokentransfer_sql.go
100.00% <100.00%> (ø)

internal/tokens/fftokens/fftokens.go
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6761542...3aac00c. Read the comment docs.

authors: awrichar codecov-commenter


text:
Fix mac installer formula failures

Homebrew install can throw an error if some formulas already are installed. This fixes that issue: installs formulas that are not present and upgrades those that are out of date without throwing errors.
Signed-off-by: Theo Turner theo_turner@outlook.com

Related issue:
https://jira.hyperledger.org/browse/IS-1340

authors: esplinr theoturner

repo: hyperledger/indy-sdk


text:
cascade or restrict on delete entities?

Currently, domains, accounts, and assets are cascaded on unregister due to nested structure, but for shallow objects #3921 we might choose either of the following unregister policies:

autoremove orphans (ON DELETE CASCADE)

entity should have a set of references (IDs) of other entities

do not unregister as long as referenced (ON DELETE RESTRICT)

entity should have a reference counter that indicates how many other entities are referencing it

domains, accounts, and assets would keep cascading if that is implied in CanUnregisterDomain
should an account be dominant for the triggers it has registered?

related to #4670

To consider entity relationships, I drew what if the storages under the world were tables of relational database:
erDiagram
    %% parent tables
    DOMAINS {
        _ id PK
        _ logo
        _ metadata
        _ admin FK
    }
    ACCOUNTS {
        _ id PK
        _ metadata
    }
    ASSETS {
        _ id PK
        _ total_quantity
        _ is_mintable
        _ logo
        _ metadata
        _ admin FK
    }
    %% child tables
    DOMAIN_ACCOUNTS {
        _ domain_id PK, FK
        _ account_id PK, FK
    }
    DOMAIN_ASSETS {
        _ domain_id PK, FK
        _ asset_id PK, FK
    }
    ASSET_ACCOUNTS_NUMERIC {
        _ asset_id PK, FK
        _ account_id PK, FK
        Numeric balance
    }
    ASSET_ACCOUNTS_STORE {
        _ asset_id PK, FK
        _ account_id PK, FK
        Metadata datastore
    }
    %% relationships
    DOMAINS ||--o{ DOMAIN_ACCOUNTS : has
    DOMAINS ||--o{ DOMAIN_ASSETS : has
    ACCOUNTS ||--o{ DOMAINS : administrates
    ACCOUNTS ||--o{ ASSETS : administrates
    ACCOUNTS ||--o{ DOMAIN_ACCOUNTS : has
    ACCOUNTS ||--o{ ASSET_ACCOUNTS_NUMERIC : has
    ACCOUNTS ||--o{ ASSET_ACCOUNTS_STORE : has
    ASSETS ||--o{ DOMAIN_ASSETS : serves
    ASSETS ||--o{ ASSET_ACCOUNTS_NUMERIC : serves
    ASSETS ||--o{ ASSET_ACCOUNTS_STORE : serves

erDiagram
    %% parent tables
    ACCOUNTS {
        _ id PK
        _ metadata
    }
    PERMISSIONS {
        _ id PK
    }
    ROLES {
        _ id PK
    }
    %% child tables
    ACCOUNT_PERMISSIONS {
        _ account_id PK, FK
        _ permission_id PK, FK
    }
    ACCOUNT_ROLES {
        _ account_id PK, FK
        _ role_id PK, FK
    }
    ROLE_PERMISSIONS {
        _ role_id PK, FK
        _ permission_id PK, FK
    }
    %% relationships
    ACCOUNTS ||--o{ ACCOUNT_PERMISSIONS : has
    ACCOUNTS ||--o{ ACCOUNT_ROLES : has
    PERMISSIONS ||--o{ ACCOUNT_PERMISSIONS : serves
    PERMISSIONS ||--o{ ROLE_PERMISSIONS : serves
    ROLES ||--o{ ROLE_PERMISSIONS : has
    ROLES ||--o{ ACCOUNT_ROLES : serves

where:

if table P has table C, entity c in C that references p is also deleted when entity p in P is deleted (CASCADE)
if table P serves table C, entity p in P cannot be deleted as long as any entity c in C references p (RESTRICT)
P serves C when P administrates C

Interesting, when you visualized it this way i noticed that either removal of account or domain can have cascade a lot.
Like:

removal of domain owner would delete it's domain
which in turn delete every account in this domain
if any account in this domain was domain owner it trigger domain removal
...
Until domain is empty or every account in the domain is not owner of some other domain

In response to https://github.com/hyperledger/iroha/issues/4087#issuecomment-2210348956, assuming that NUMERIC/STORE assets correspond to FT/NFT respectively, I have updated them as totally different entities:
erDiagram
    %% parent tables
    DOMAINS {
        _ id PK
        _ logo
        _ metadata
        _ admin FK
    }
    ACCOUNTS {
        _ id PK
        _ metadata
    }
    FASSETS {
        %% fungible assets
        _ id PK
        _ total_quantity
        _ is_mintable
        _ logo
        _ metadata
        _ admin FK
    }
    NFASSETS {
        %% non-fungible assets
        _ id PK
        Metadata datastore
        _ owner FK
    }
    %% child tables
    DOMAIN_ACCOUNTS {
        _ domain_id PK, FK
        _ account_id PK, FK
    }
    DOMAIN_FASSETS {
        _ domain_id PK, FK
        _ asset_id PK, FK
    }
    FASSET_ACCOUNTS {
        _ asset_id PK, FK
        _ account_id PK, FK
        Numeric balance
    }
    %% relationships
    DOMAINS ||--o{ DOMAIN_ACCOUNTS : has
    DOMAINS ||--o{ DOMAIN_FASSETS : has
    ACCOUNTS ||--o{ DOMAINS : administrates
    ACCOUNTS ||--o{ FASSETS : administrates
    ACCOUNTS ||--o{ DOMAIN_ACCOUNTS : has
    ACCOUNTS ||--o{ FASSET_ACCOUNTS : has
    ACCOUNTS ||--o{ NFASSETS : has
    FASSETS ||--o{ DOMAIN_FASSETS : serves
    FASSETS ||--o{ FASSET_ACCOUNTS : serves

where:

FASSET is an abbreviation for FUNGIBLE ASSET
NFASSET is an abbreviation for NON FUNGIBLE ASSET
assumes FASSET is associated with a domain, whereas NFASSET makes sense on its own across domains

Do we need a fungible Store asset type? It would also allow creating multiple instances based on the prototype, with the prototype dictating which keys are allowed and which are required.

authors: Erigara nxsaken s8sato

repo: hyperledger/iroha


text:
Adding missing dependencies for building iroha on Linux

Description of the Change
I've noticed that when building according to instruction: https://iroha.readthedocs.io/en/main/build/index.html#linux dependencies are not working for minimalist debian-based distribution (to be more specific - when I'm building on docker image of ubuntu:21.04). So I've just added the missing dependencies.
They are helping to build on ubuntu:21.04 docker instance, because vcpkg needs them. But they are not destroying building on not minimalist building on normal Ubuntu 21.04 system.

Benefits
More automatic building on minimalist debian based linux distribution.

Possible Drawbacks
I've checked on normal Debian-based linux distribution and it is still installing dependencies, so rather no drawback.

Usage Examples or Tests [optional]

Alternate Designs [optional]

PS: I've also corrected formatting of python code - sphinx is ignoring tabs, so I've changed them into spaces.

Looks good to me - it seems that only indentation was changed in the python code, right?
Need an approve from the core team for the dependencies though

Looks good to me - it seems that only indentation was changed in the python code, right?

In the python code only indentation. Because there were tabs, so I've changed them into spaces (so now copy-paste the code is easier - changing indentation after copy-paste is required)

Ufff, destination branch changed from main into support/1.2.x

@baziorek is it still actual?
please try build in Docker $ docker pull ghcr.io/hyperledger/iroha-builder:support/1.2.x
All dependancies are listed in ./docker/iroha-builder/Dockerfile.  If this problem still reproducible please rebase and prepare to review. If not let's close this PR

@baziorek is it still actual?
please try build in Docker $ docker pull ghcr.io/hyperledger/iroha-builder:support/1.2.x
All dependancies are listed in ./docker/iroha-builder/Dockerfile. If this problem still reproducible please rebase and prepare to review. If not let's close this PR

Sorry for not replying for few days - I didn't see Your message.
I've tried command as You suggested and few more, they are invalid:
# command as You told me is not working:
➜  ~ docker pull ghcr.io/hyperledger/iroha-builder:support/1.2.x
invalid reference format
# so I've tried:
➜  ~ docker pull hyperledger/iroha-builder:support/1.2.x
invalid reference format
# I've also tried command from DockerHub: https://hub.docker.com/r/hyperledger/iroha-builder
➜  ~ docker pull hyperledger/iroha-builder
Using default tag: latest
Error response from daemon: manifest for hyperledger/iroha-builder:latest not found: manifest unknown: manifest unknown
__________
The problem, which I'm trying to solve is when I don't use default docker image with iroha, but when I'm pulling `ubuntu:21.04` from docker then building Iroha by my own.

I see conflicts are killing the PR again and again. Fortunately @petermetz repaired the same thing in different PR: https://github.com/hyperledger/iroha/pull/1393
So I'm closing my PR.

I see conflicts are killing the PR again and again. Fortunately @petermetz repaired the same thing in different PR: #1393
So I'm closing my PR.

@baziorek Oops, sorry for the duplicate! I'm happy to withdraw my PR in favor of yours, just let me know!

@baziorek Oops, sorry for the duplicate! I'm happy to withdraw my PR in favor of yours, just let me know!

@petermetz No problem. It is good as it is now when my PR is closed (it has 558 conflicted files:D).

authors: LiraLemur baziorek kuvaldini petermetz


text:
Blockchain entity was removed to clean up codebase.

Description of the Change

Benefits

Possible Drawbacks

Usage Examples or Tests [optional]

Alternate Designs [optional]

Wait for #458

I think the name of the pull request should be more descriptive, not a number of issue. Maybe mention issue in the description of the PR.

@eadventurous thanks, didn't checked - looks like GH makes another name, not a commit name


text:
Improve bindings interface

What is this pull request?
It solves problem when bindings users can forget to set one ore more mandatory fields for queries and transactions (like tx_counter) and still pass validation.
Details/Features

Add validator for query and tx counters
Set mandatory fields for query and tx to invalid values
Fix bug in load_query

Codecov Report

:exclamation: No coverage uploaded for pull request base (trunk/bindings-test@0d2c833). Click here to learn what that means.
The diff coverage is 45.45%.

@@                  Coverage Diff                  @@
##             trunk/bindings-test    #819   +/-   ##
=====================================================
  Coverage                       ?   31.6%
=====================================================
  Files                          ?     458
  Lines                          ?   13510
  Branches                       ?    8605
=====================================================
  Hits                           ?    4270
  Misses                         ?    1459
  Partials                       ?    7781

Impacted Files
Coverage Δ

shared_model/bindings/model_query_builder.hpp
100% <ø> (ø)

...ule/shared_model/validators/validators_fixture.hpp
43.39% <ø> (ø)

...e/shared_model/validators/query_validator_test.cpp
42.5% <0%> (ø)

shared_model/validators/transaction_validator.hpp
48.36% <0%> (ø)

shared_model/validators/query_validator.hpp
58.46% <0%> (ø)

shared_model/bindings/model_query_builder.cpp
20% <25%> (ø)

shared_model/validators/field_validator.hpp
62.96% <50%> (ø)

...red_model/backend/protobuf/queries/proto_query.hpp
58.13% <66.66%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d2c833...cd2633f. Read the comment docs.

authors: codecov-io luckychess


text:
Remove the metadata fields in rethink objects

User Story
Remove metadata fields in rethink objects

T-shirt size:
S

User Story
"As a developer I do not want excess fields created by us to be maintained.

Description  Right now we keep a metadata field on all objects.  With the metadata table we do not need this extra field.  It should be removed.  This process occurs in ledger_sync/inbound/listener  in the metadata creation step.  For an example of hat currently happens look at the groups and users table in rethinkdb and find the metadata field is empty.
Acceptance Criteria/Tests Remove the metadata field and have tests to back up the fact that it is not created.

some investigation needed...  Sawtooth is designed to be extensible via this metadata field.  Lets be sure we are not killing the meta data that we need.  Code comments say "meta data not stored on chain" -- let's make sure we are in sync with schema descriptions in "ledger object definitions" on the sharepoint.

Per conversation with Ned...  the orginal design calls for actually having this metadata field but it is currently not used correctly.  We will close this one and open a new ticket once we understand it better...

authors: PatrickLammers nadiabahrami

repo: hyperledger/sawtooth-next-directory


text:
blurry client in some cases

Hyprland Version
Hyprland, built from branch main at commit f242f9447b02e304e214ef36443bd795719c3330 dirty (keybinds: suppress up event if down was consumed). Tag: v0.29.0-17-gf242f944
Bug or Regression?
Regression
Description
in master layout, when I have 4 client (not <4 or >4) the font looks blurry. Happens on all the terminals I tried (foot, alacritty)

You can see here that the master term is fine, while the 3 other are blurry
How to reproduce
Open 4 terms
Crash reports, logs, images, videos
No response

it actually happens for any app

patch.txt
try

yep that fixes it

authors: primalmotion vaxerski

repo: hyprwm/Hyprland


text:
Held keys not passed to wayland clients on keyboard::enter

Hyprland Version
For some reason: [ ERROR ] Unknown option 'systeminfo'!

Using the latest hyprland from main (3c964a9fdc220250a85b1c498e5b6fad9390272f).
Bug or Regression?
Bug
Description
Held keys are not passed to a window when it's activated.
How to reproduce

Run blender 4.0 from a terminal with the command:
blender --log "ghost.wl.handle.keyboard.*" --log-level 2

Hover the cursor over the blender window and press the Super key.

Move the cursor to another window and back to change focus, re-focusing on the Blender window.

The following warning is printed:
INFO (ghost.wl.handle.keyboard): intern/ghost/intern/GHOST_SystemWayland.cc:4732 keyboard_handle_leave: leave
INFO (ghost.wl.handle.keyboard): intern/ghost/intern/GHOST_SystemWayland.cc:4690 keyboard_handle_enter: enter
INFO (ghost.wl.handle.keyboard): intern/ghost/intern/GHOST_SystemWayland.cc:5044 keyboard_handle_modifiers: modifiers (depressed=64, latched=0, locked=16, group=0)
WARN (ghost.wl.keyboard.depressed): intern/ghost/intern/GHOST_SystemWayland.cc:7081 getModifierKeys: modifier (OS) state is inconsistent (GHOST held keys do not match XKB)
INFO (ghost.wl.handle.keyboard): intern/ghost/intern/GHOST_SystemWayland.cc:4898 keyboard_handle_key: key (code=133, state=0)

By comparison SWAY 1.8.1 does not have this behavior, with the same steps the following output is printed:
INFO (ghost.wl.handle.keyboard): intern/ghost/intern/GHOST_SystemWayland.cc:4732 keyboard_handle_leave: leave
INFO (ghost.wl.handle.keyboard): intern/ghost/intern/GHOST_SystemWayland.cc:4690 keyboard_handle_enter: enter
INFO (ghost.wl.handle.keyboard): intern/ghost/intern/GHOST_SystemWayland.cc:4707 keyboard_handle_enter: enter (key_held=133)
INFO (ghost.wl.handle.keyboard): intern/ghost/intern/GHOST_SystemWayland.cc:5044 keyboard_handle_modifiers: modifiers (depressed=64, latched=0, locked=16, group=0)

Notice the key_held=133 is set as part of keyboard::enter.

Note that the same issue existed with mutter which has since been resolved: https://gitlab.gnome.org/GNOME/mutter/-/issues/2457
Crash reports, logs, images, videos
No response

For some reason: [ ERROR ] Unknown option 'systeminfo'!

4 days ago is not latest

woops my bad wrong ref

Did you find a solution?

authors: ideasman42 shasherazi vaxerski


text:
Configure compose key

Hello,
I'm having a hard time at configuring the compose key, as I'm using a US keyboard but I need to write in Italian too, so I need to have the special letters (like è, which I'm currently copy pasting from the web).
The idea is to have a certain key (in my case right alt) so that Compose + ` + e will result in that letter.
Searching online it should be possible with XKB options (which I'm trying to set in the input section) but it is not working.
Part of my config file:
input {
    kb_file=
    kb_layout=
    kb_variant=
    kb_model=
    kb_options="compose:ralt,level3:ralt_switch"
    kb_rules=

    follow_mouse=2

    touchpad {
        natural_scroll=yes
	tap-to-click=yes
	middle_button_emulation=yes
    }

    sensitivity=0 # -1.0 - 1.0, 0 means no modification.
}

I've looked into:

https://superuser.com/questions/1160777/make-special-characters-available-on-us-keyboard-an-wayland
https://wiki.archlinux.org/title/Xorg/Keyboard_configuration#Configuring_compose_key

and tried various combinations on options, without success
Is it a problem with the WM reload? Is it a bug or simply a lack of documentation?
Thanks in advice

kb_options="compose:ralt,level3:ralt_switch"

this is not vaid, and no part of the config has ever told you to do this.
Quotes are not to be put there.

My bad, removing the quotes fixes the issue. Thank you and sorry for the dummy question

authors: VersusF vaxerski