text:
🛑 Mailcow (web) is down

In 269739f, Mailcow (web) (https://mail.artemislena.eu) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Mailcow (web) is back up in 28eeb02 after 1 minute.

repo: artemislena/upptime


text:
🛑 Main site is down

In 3e04111, Main site (https://artemislena.eu) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Main site is back up in 5a1aec9.

source: gharchive/issue

license: MIT

license_type: permissive

license_source: github-api


text:
useCache method name is confusing since 'use' is a reserved prefix for React hooks

React and my linter think that it's a react hook, so I get a linting error and displayed below. I can resolve by aliasing the import name, but it would be preferable for React devs to use a different name for the primary method.
Thank you for building this great package!

Hi!
Before, there was a createCache function and a useCache. A while ago I removed the createCache function and left only useCache, but for an outsider's perspective it makes a lot more sense for the function name to be changed. It makes total sense, thanks!

I published v0.7.7 to fix this issue for you. You can close this issue if it does not need anything more. 🚀

awesome, thanks so much @arthurfiorette!!

repo: arthurfiorette/axios-cache-interceptor


text:
December release notes

We need to publish December release notes article to give overview of changes made in Artipie during the month

@olenagerasimova here is list of pull requests for last 30 days:
 - #150 - Fix bug in meta skeleton @genryxy: https://github.com/artipie/npm-adapter/pull/151
 - #119 - Fix backward compatibility @genryxy: https://github.com/artipie/npm-adapter/pull/149
 - #296 - Copy all keys @olegmoz: https://github.com/artipie/asto/pull/297
 - #829 - docker-adapter upgraded to 0.10 @olegmoz: https://github.com/artipie/artipie/pull/830
 - #826 - Verbose output for IT cases @genryxy: https://github.com/artipie/artipie/pull/827
 - #797 - Update management-api version, use ConfigFileApi @genryxy: https://github.com/artipie/artipie/pull/824
 - #822 - Fix HelmIT @genryxy: https://github.com/artipie/artipie/pull/823
 - #820 - docker-adapter upgraded to 0.9.3 @olegmoz: https://github.com/artipie/artipie/pull/821
 - #804 - update readme @olenagerasimova: https://github.com/artipie/artipie/pull/817
 - #797 - Support both extensions for ArtipieApi and DashboardSlice @genryxy: https://github.com/artipie/artipie/pull/816
 - #804 - Add setting for repo configs location @olenagerasimova: https://github.com/artipie/artipie/pull/815
 - #797 - Use ConfigFile where RxStorage is used for config files @genryxy: https://github.com/artipie/artipie/pull/814
 - #804 - handle exception on repo config parsing @olenagerasimova: https://github.com/artipie/artipie/pull/811
 - #797 - Get value for different extensions  @genryxy: https://github.com/artipie/artipie/pull/810
 - #803 - specify layout on start @olenagerasimova: https://github.com/artipie/artipie/pull/809
 - artipie/management-api#15 - update management API and use GetStorageSlice from there @olenagerasimova: https://github.com/artipie/artipie/pull/808
 - #797 - Check existing, trim filename for different extensions @genryxy: https://github.com/artipie/artipie/pull/807
 - #738 - Fix path handling for NpmProxySlice @genryxy: https://github.com/artipie/artipie/pull/805
 - #775 - test for ArtipieApi @olenagerasimova: https://github.com/artipie/artipie/pull/801
 - #798 - update management-api @olenagerasimova: https://github.com/artipie/artipie/pull/799
 - #793 - prepare to transfer dashboard @olenagerasimova: https://github.com/artipie/artipie/pull/796
 - #778 - Add tests for YamlProxyConfig, extract class StorageYamlConfig @genryxy: https://github.com/artipie/artipie/pull/794
 - #597 - Add negative tests to RepositoriesFromStorage @genryxy: https://github.com/artipie/artipie/pull/792
 - #586 - Layout extracted @olegmoz: https://github.com/artipie/artipie/pull/785
 - #597 - Test RepositoriesFromStorage @genryxy: https://github.com/artipie/artipie/pull/783
 - #768 - Support Basic auth for Gem @genryxy: https://github.com/artipie/artipie/pull/782
 - Simplify YamlSettings.java @portlek: https://github.com/artipie/artipie/pull/780
 - #778 - Extend tests for RepoConfig @genryxy: https://github.com/artipie/artipie/pull/779
 - #422 - Handling empty UUID @olegmoz: https://github.com/artipie/docker-adapter/pull/425
 - #372 - Tags implemented in MultiReadManifests @olegmoz: https://github.com/artipie/docker-adapter/pull/423
 - #366 - Tags implemented in CacheManifests @olegmoz: https://github.com/artipie/docker-adapter/pull/421
 - #417 - Parsing scope from string @olegmoz: https://github.com/artipie/docker-adapter/pull/420
 - #366 - Added JoinedTagsSource @olegmoz: https://github.com/artipie/docker-adapter/pull/419
 - #417 - Added authentication Scope @olegmoz: https://github.com/artipie/docker-adapter/pull/418
 - #369 - Tags implemented in ReadWriteManifests @olegmoz: https://github.com/artipie/docker-adapter/pull/416
 - #366 - Added TagsPage @olegmoz: https://github.com/artipie/docker-adapter/pull/415
 - #366 - Added ParsedTags @olegmoz: https://github.com/artipie/docker-adapter/pull/414
 - #393 - Mount implemented in ReadWriteLayers @olegmoz: https://github.com/artipie/docker-adapter/pull/413
 - #375 - Tags implemented in ProxyManifests @olegmoz: https://github.com/artipie/docker-adapter/pull/412
 - #375 - Added TagsListUri @olegmoz: https://github.com/artipie/docker-adapter/pull/411
 - #368 - Catalog in CacheDocker @olegmoz: https://github.com/artipie/docker-adapter/pull/410
 - #368 - Catalog in TrimmedDocker @olegmoz: https://github.com/artipie/docker-adapter/pull/409
 - #367 - JoinedCatalogSource extracted from MultiReadDocker @olegmoz: https://github.com/artipie/docker-adapter/pull/408
 - #371 - Catalog implemented in MultiReadDocker @olegmoz: https://github.com/artipie/docker-adapter/pull/407
 - #405 - Support for manifest conversion to wildcard @olegmoz: https://github.com/artipie/docker-adapter/pull/406
 - #371 - CatalogPage extracted from AstoCatalog @olegmoz: https://github.com/artipie/docker-adapter/pull/404
 - #371 - ParsedCatalog added @olegmoz: https://github.com/artipie/docker-adapter/pull/403
 - #370 - Catalog implemented in ReadWriteDocker @olegmoz: https://github.com/artipie/docker-adapter/pull/402
 - #376 - Catalog proxy @olegmoz: https://github.com/artipie/docker-adapter/pull/401
 - #376 - Extracted ResponseSink from ProxyLayers and ProxyManifests @olegmoz: https://github.com/artipie/docker-adapter/pull/400
 - #376 - Added CatalogUri @olegmoz: https://github.com/artipie/docker-adapter/pull/399
 - #297 - Invalid digest error on blob creation @olegmoz: https://github.com/artipie/docker-adapter/pull/398
 - #297 - InvalidDigestException added @olegmoz: https://github.com/artipie/docker-adapter/pull/397
 - #390 - Blob mount endpoint implementation @olegmoz: https://github.com/artipie/docker-adapter/pull/396
 - #394 - Mount implemented in AstoLayers @olegmoz: https://github.com/artipie/docker-adapter/pull/395
 - #390 - Added Layers.mount method without implementation @olegmoz: https://github.com/artipie/docker-adapter/pull/392
 - #390 - Mount blob request parameters parsing @olegmoz: https://github.com/artipie/docker-adapter/pull/391
 - #374 - Pagination support in AstoCatalog @olegmoz: https://github.com/artipie/docker-adapter/pull/389
 - #275 - Content constructors in RsWithBody and RsFull @olegmoz: https://github.com/artipie/http/pull/282
 - #278 - AuthScheme.Fake added @olenagerasimova: https://github.com/artipie/http/pull/279
 - #276 - RqParams class added @olegmoz: https://github.com/artipie/http/pull/277
 - #273 - JoinedPermissions added @olegmoz: https://github.com/artipie/http/pull/274
 - #83 - Remove deprecated auth classes @genryxy: https://github.com/artipie/gem-adapter/pull/84
 - #81 - Support Basic authentication @genryxy: https://github.com/artipie/gem-adapter/pull/82
 - #81 - Fix ITCase @genryxy: https://github.com/artipie/helm-adapter/pull/82
 - #57 - Add IT with authentication @genryxy: https://github.com/artipie/helm-adapter/pull/80
 - #14 - November blog post @olenagerasimova: https://github.com/artipie/blog.artipie.com/pull/15
 - #27 - Revert using ContentAs in ApiRepoGetSlice @genryxy: https://github.com/artipie/management-api/pull/33
 - #27 - Use ConfigFiles in page implementations @genryxy: https://github.com/artipie/management-api/pull/32
 - #27 - Use ConfigFile in RepoUpdateSlice, remove ApiRepoCreateSlice @genryxy: https://github.com/artipie/management-api/pull/30
 - #27 - ConfigFile for RepoGet and RepoList slices @genryxy: https://github.com/artipie/management-api/pull/29
 - #27 - ConfigFile for permissions slices @genryxy: https://github.com/artipie/management-api/pull/28
 - #15 - GetStorageSlice migrated @olenagerasimova: https://github.com/artipie/management-api/pull/26
 - #24 - artifactory API endpoints to ApiPermission @olenagerasimova: https://github.com/artipie/management-api/pull/25
 - #16 - dashboard classes should be public @olenagerasimova: https://github.com/artipie/management-api/pull/23
 - #14 - extracted interface from Cookies @olenagerasimova: https://github.com/artipie/management-api/pull/19
 - #16 - transfer dashboard @olenagerasimova: https://github.com/artipie/management-api/pull/18
 - #11 - support xz compression @olenagerasimova: https://github.com/artipie/debian-adapter/pull/16
 - #11 - read control file @olenagerasimova: https://github.com/artipie/debian-adapter/pull/15
 - #13 - expand readme @olenagerasimova: https://github.com/artipie/debian-adapter/pull/14
 - #2 - added test for install @olenagerasimova: https://github.com/artipie/debian-adapter/pull/10
 - #2 - test for search @olenagerasimova: https://github.com/artipie/debian-adapter/pull/9
 - #6 - github actions @olenagerasimova: https://github.com/artipie/debian-adapter/pull/7
 - #1 - project setup @olenagerasimova: https://github.com/artipie/debian-adapter/pull/5

closed by #17

closed by #17

authors: olegmoz olenagerasimova


text:
Publish submissions f

This PR includes:

Publish submissions to the blockchain
Publish Artifacts
Buy open editions (Rough UI Buy Open Edition Widget)
Add EK code to get Gnosis data to hook: UseGnosis but it needs to be reviewed by EK

@EricWVGG thanks for reviewing

source: gharchive/pull-request

repo: artizen-fund/artizen-frontend


text:
Create video animation directive.

Implement a video directive with the animation interface.

Closing for now, not really needed.

repo: artoale/ng-cat

license: mit

license_source: bigquery


text:
HeaderModule: Onboarding Update

Can we change ‘search artist name’ to e.g. ‘search artist’ ?

Sure
Sent with thumbs,
Katarina Batina
Product Designer
Artsy.net

On Mar 22, 2016, at 7:20 AM, Eloy Durán notifications@github.com wrote:
Can we change ‘search artist name’ to e.g. ‘search artist’ ?
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub

authors: alloy katarinabatina

repo: artsy/eigen


text:
Feedback 'From: Katie Higgins'

Message from 537963418b3b8122330012f3 sent on 2017-02-01 13:16:26 UTC###

From: Katie Higgins

Link to HockeyApp

https://rink.hockeyapp.net/manage/apps/37029/feedback/717869

I think this might have been a mistake

authors: artsyit katarinabatina


text:
feat(AREnableCollectorProfilePrompts): clean up

Description
Clean up feature flag, sibling of https://github.com/artsy/echo/pull/713
PR Checklist

[ ] I have tested my changes on iOS and Android.
[ ] I hid my changes behind a feature flag, or they don't need one.
[ ] I have included screenshots or videos, or I have not changed the UI.
[ ] I have added tests, or my changes don't require any.
[ ] I added an app state migration, or my changes do not require one.
[ ] I have documented any follow-up work that this PR will require, or it does not require any.
[ ] I have added a changelog entry below, or my changes do not require one.

To the reviewers 👀

[ ] I would like at least one of the reviewers to run this PR on the simulator or device.

Changelog updates
Changelog updates

Cross-platform user-facing changes

feat: clean up AREnableCollectorProfilePrompts

iOS user-facing changes

Android user-facing changes

Dev changes

Need help with something? Have a look at our docs, or get in touch with us.

This PR contains the following changes:

Cross-platform user-facing changes (feat: clean up AREnableCollectorProfilePrompts - araujobarret)

  Generated by :no_entry_sign: dangerJS against 1bf25184bb1611db4e34d58f82677ba41e06d01b

authors: ArtsyOpenSource araujobarret


text:
fix: don't rerender home when logged out

The type of this PR is: fix
This PR resolves CX-1311
Description
All of our tabs are rerendered any time we switch tabs, on logging out we reset the tab state to home causing a rerender of the home tab which fails because at this point the users access token is gone leading to the unable to load screen. This checks for presence of access token and doesn't render the home screen if it is absent.
PR Checklist (tick all before merging)

[x] I have included screenshots or videos to illustrate my changes, or I have not changed anything that impacts the UI.
[x] I have tested my changes on iOS and Android.
[x] I have added tests for my changes, or my changes don't require testing, or I have included a link to a separate Jira ticket covering the tests.
[x] I have added a feature flag, or my changes don't require a feature flag. (How do I add one?)
[x] I have documented any follow-up work that this PR will require, or it does not require any.
[x] I have added an app state migration, or my changes do not require one. (What are migrations?)
[x] I have added a CHANGELOG.yml entry or my changes do not require one.

Finally we fixed this 🎉

authors: MounirDhahri brainbicycle


text:
View in Room not being selectable in iPad

Haven't confirmed, but seen it on a device.

#26

authors: orta sarahscott

repo: artsy/energy


text:
[Artist Signup CTA] Fails for artists with no data

Reported by @tayapage6
https://www.artsy.net/artist/chansong-kim?show_artist_cta_code=show-me

I think this is release critical, at least the signup should pop the regular sign up modal if the fix is complicated.

repo: artsy/force


text:
fix: Updated ConfirmArtworkModal deps to system instead of artsy

Updated deps for ConfirmArtworkModal to use System instead of Artsy as per this comment.

🙏

authors: dzucconi jo-rs


text:
🛑 Art UK Shop is down

In 4007050, Art UK Shop (https://shop.artuk.org) was down:

HTTP code: 500
Response time: 3477 ms

Resolved: Art UK Shop is back up in 29ede74 after 9 minutes.

repo: artukdotorg/uptime


text:
Cannot enter password after locking session

If I lock the session, I can't log back in. The login button doesn't work, and neither does pressing Enter.

This happens to me every time, not just on login.


text:
🛑 Plex Server is down

In e30cae8, Plex Server (plex.vanillyneko.com) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Plex Server is back up in 412937e.


text:
Connect using Robomongo

Hello,
I've managed to deploy succesfully using mupx, using abernix/meteord:base.
I can access the mongodb using: docker exec -it mongodb mongo Project-A-database,
But I can't seem to connect using robomongo.
Any pointers would be greatly appreciated
Thanks!!!

I think this was asked somewhere else (possibly by me) but basically you won't be able to do it. Maybe in a future version you will

Hey, I've figured it out, I got myself the latest version of robomongo.

Use the SSH function
key in localhost for the connection(first tab)
fill in the auth

You cannot access a mongodb from robomongo if the db is in a docker container...
But you can use a free or paid db from mlab.com.
#MUP.JSON (part of it at least)
"setupMongo": false,   "appName": "YOURAPP",   "app": "/YOUR/APP/PATH",   "env": {     "ROOT_URL": "https://YOURAPPDOMA.IN/",     "MONGO_URL": "//mongodb://username:password@xxxx.mlab.com:xxxx/YOURAPP"   }
After this you can setup robomongo to point to the mlab db.

Let me clear my statement. With some versions of MUP you can't, with other versions you can. What @luisreyes says is correct. If you want more detailed instructions you can check out my blog post which walks you through it using 3T MongoChef. Similar instructions would work for Robo http://blog.codehatcher.com/mongodb-ssh-access-on-remote-meteor-deployment

I was able to connect to my remote mongodb deployed by mup.
I use windows and I followed this steps.
https://www.digitalocean.com/community/tutorials/how-to-set-up-ssh-tunneling-on-a-vps
Windows and PuTTY
-- I created a SSH tunnel to a local port like 3030 then I connected to the database in robomongo using LOCALHOST:3030

authors: codeHatcher darrenyxj ericmagalhaes luisreyes

repo: arunoda/meteor-up


text:
Can't edit NPC biography - div is too small

In GitLab by @jwinget on Aug 19, 2021, 20:28
When I try to edit an NPC biography, the edit button seems to be hidden or placed in a very small div, and clicking on it does nothing.
PC biography fields work as expected.

Foundry version 0.8.8
PBtA version beta11-0.2.0

NPC configuration TOML:
# NPC configuration
[npc]
  [npc.attributesTop]
    [npc.attributesTop.harm]
      type = "Clock"
      max = 6
      default = 0
  [npc.attributesLeft]
    [npc.attributesLeft.confidence]
      type = "LongText"
      label = "Confidence"
  [npc.moveTypes]
    hard = "Hard Moves"
    soft = "Soft Moves"

In GitLab by @mclemente on Nov 28, 2023, 16:56
This was already at some point, but the CSS was changed on !48.

In GitLab by @jwinget on Aug 20, 2021, 12:31
I whacked up a temporary fix by adding the following lines to pbta.css:
.cell.cell--bio .editor {
         height: 90%;
         min-height: 200px; }
        }

My guess is the class is supposed to be .cell .cell--bio and a space is missing somewhere.

repo: asacolips-projects/pbta


text:
Absolute vs. relative paths

The webui is broken when used behind a reverse proxy under a directory because of some absolute paths. For example, with this handy nginx configuration, it's not working:
location /peerflix/ {
        proxy_pass        http://127.0.0.1:9000/;
}

The webui looks for socket.io in https://domain.name/socket.io/socket.io.js instead of https://domain.name/peerflix/socket.io/socket.io.js. In index.html <script src="/socket.io/socket.io.js"></script> should be replaced by <script src="socket.io/socket.io.js"></script>
Same thing happens with paths to fonts in stylesheets and at least with /upload and /torrents

If you can get it to work for both relative and absolute urls, PR is welcome.

Honestly I never pulled anything because I'm not a real developer. However that looks doable and could be a good start. I'll try, but please be indulgent!

authors: asapach homlett

repo: asapach/peerflix-server


text:
feat: Supports monorepo

PoC change for https://github.com/asbiin/semantic-release-github-pullrequest/issues/86

@raytung thank you for this contribution! The tests are failing, would you have a look?

@asbiin Apologies for the late reply, I've updated the tests now :+1:

@raytung I've regenerated the package-lock.json using node 16.

authors: asbiin raytung


text:
resolves #59 use correct property to get label (aka id) of ref

The converter for the inline ref was extracting the label (aka id) from the text. However, the label is already available as a property. In Asciidoctor < 1.5.6, the label was stored on the target property. Although still supported, the preferred property is id. I have set up to converter look at the id property first and fallback to the target.
This fixes a NilClass exception when using Asciidoctor LaTeX with Asciidoctor >= 1.5.6.

I'm confident this is the right fix.

repo: asciidoctor/asciidoctor-latex


text:
Document title theming

As a follow up on issues #105 and #135 we should be able to theme the document title section in a consistent way while also supporting the requirements of the different document types (i.e. separate title page vs. title section followed by content).
The first question is what should include the title section?

In case of a book it is composed of the logo (image), title, subtitle, authors, and revision.
In case of an article (according to #975) it includes only the title.

As I stated in https://github.com/asciidoctor/asciidoctor-pdf/issues/66#issuecomment-1128562591, we've decided to focus on a programmatic solution to this need. Refer to that comment for the reasoning.
If someone would like to come forward with a proposal to change the built-in ink_title_page method to look for additional keys, I won't rule it out. However, I think you'll quickly find that no matter how many keys we add, it's always going to feel constrained trying to design through configuration (short of recreating CSS). That's why I think a more powerful approach is to make the converter easier to extend, which is what we've done.
If you think it would be easier if we made an "ink" method for the article title, I'm open to considering that. However, I think you'll find that you can already capture that hook by checking the opts[:role] == :doctitle in the ink_general_heading method.
def ink_general_heading doc, title, opts
  return super unless opts[:role] == :doctitle
  theme_font :doctitle do
    ink_prose title, align: :center
  end
  margin_bottom theme.heading_doctitle_margin_bottom
end

Since I don't see any clear action right now, I'm going to close this issue as covered by existing enhancements in Asciidoctor PDF 2.0. If you still see room for improvement, please open a new issue that builds on current functionality.

authors: mojavelinux ogmios-voice

repo: asciidoctor/asciidoctor-pdf


text:
Auto reshim

Is your feature request related to a problem? Please describe.
no
Describe the solution you'd like
we must reshim manually by self
Describe alternatives you've considered
reshim should occur automatically whenever possible.
Additional context
there are two implements can be referenced

https://github.com/asdf-community/asdf-python/blob/master/shims/pip
https://github.com/asdf-vm/asdf-nodejs/blob/master/shims/npm

Can this be assigned to me? I would love to have a go at it!

@shettytejas Recently, I was really stressed about this reshim.
It's annoying to reshim after go install
I have some time right now, so if it's okay with you, would it be okay if I did this right away? (I've already done some of the work!)

@HwangTaehyun Go for it! 😄

authors: HwangTaehyun jiz4oh shettytejas

repo: asdf-community/asdf-golang


text:
Fix animations with an odd column count

The "last column changed" sequence is not supposed to increase row id, as it exists to support animations with odd column counts (the chunk type is encoded using 16-bit words). The commit fixes loading of animations that are like this.

I agree that my contributions are licensed under the Flic license, and agree to future changes to the licensing.

Hi @mecirt, do you have a .flc file as an example to test your patch?

authors: dacap mecirt

repo: aseprite/flic


text:
Define ctermbg parameter if cleared

Hi!
I have an issue with a plain Vim configuration where only the Vundle and Filestyle plugins are installed. No other modification whatsoever.
When I start Vim (not gVim) I get the following error:
FileStyle: ctermbg parameter should be defined explicitly
Press ENTER or type command to continue

I don’t really understand why the ctermbg parameter is not set, but it seems expected with the default colorscheme:
:hi Normal
Normal           xxx cleared

This is on a FreeBSD virtual machine. I’ve tried with the plain CSH shell:
:echo &term
xterm

Same error within a tmux session:
:echo &term
screen

Anyway, the attached patch resolves the issue for me, but I would not be surprised if it broke another functionality, as this is quite over my head.
Hope it helps!

I forgot to add that before the patch, when entering Insert mode in Vim, I get the following errors:
Error detected while processing function FileStyleInsertModeEnter[8]..FileStyleIgnoreTrailingSpacesInCurrentLine:
line    2:
E28: No such highlight group name: FileStyleIgnoredPattern

…as well as similar errors when going back to Normal mode.

@Juanitou thank you for proposed solution, but I decided to do something bit more generic. See the
5190b8b.

authors: Juanitou aserebryakov

repo: aserebryakov/filestyle


text:
add GenerateWith common func

GnenrateWith allows passing of tools (eg. from deps.GoBinPath) when running go generate

Pull Request Test Coverage Report for Build 1852187563

0 of 13 (0.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.08%) to 13.084%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

common/generate.go
0
13
0.0%

Totals

Change from base Build 1837576085:
-0.08%

Covered Lines:
227

Relevant Lines:
1735

💛  - Coveralls

authors: coveralls mihaibuzgau

repo: aserto-dev/mage-loot


text:
Why is epsilon=12/255 on CIFAR-10 linf?

Hi, thanks for the interesting work and code!
While trying to run your code, I found that the epsilon bound is set to 12/255 instead of 8/255 on CIFAR-10 linf threat models (for example, on blackbox-adv-examples-signhunter/src/config-jsons/cifar10_shc_linf_config.json). But isn't 8/255 bound much more common, even on black-box attacks?  The main paper says that the bound setting is from (Ilyas et al., 2019), while that work also uses epsilon=8/255 on CIFAR-10 linf threat models.
Thank you.

Hi @dssrgu, thank you for your question and interest.
If you look at Table 4 (page 20) from Ilyas et al. (https://openreview.net/pdf?id=BkMiWhR5K7), the allowed perturbation for CIFAR10-linf is set to 0.05 for images in [0,1]. This is 0.05 * 255 = 12.
Hope this answers your question.
Best,

authors: ash-aldujaili dssrgu


text:
improvement: resolve project app names set using a module attribute

This PR also fixes two bugs in Common.expand_literal/1. Previously, the following would be returned:
iex(1)> ":foo" |> Sourceror.parse_string!() |> Sourceror.Zipper.zip() |> Igniter.Code.Common.expand_literal()
{:ok, {:__block__, [trailing_comments: [], leading_comments: [], line: 1, column: 1], [:foo]}}
iex(2)> "@foo" |> Sourceror.parse_string!() |> Sourceror.Zipper.zip() |> Igniter.Code.Common.expand_literal()
{:ok,
 {:@, [trailing_comments: [], leading_comments: [], line: 1, column: 1],
  [{:foo, [trailing_comments: [], leading_comments: [], line: 1, column: 2], nil}]}}

With this PR:
iex(1)> ":foo" |> Sourceror.parse_string!() |> Sourceror.Zipper.zip() |> Igniter.Code.Common.expand_literal()
{:ok, :foo}
iex(2)> "@foo" |> Sourceror.parse_string!() |> Sourceror.Zipper.zip() |> Igniter.Code.Common.expand_literal()
:error

Contributor checklist

[x] Bug fixes include regression tests
[x] Features include unit/acceptance tests

Looking great. One small question added. Also curious if you'd rather get the other one in before this.

We can ignore the CI issue, that is a misconfiguration in our CI that I need to address.

Marked as a draft for now because this PR now relies on #113, which hasn't been merged yet, so tests are now failing. Once it's merged, I'll rebase and mark as ready for review.

I believe this is ready to go pending a final review, @zachdaniel :)

🚀 Thank you for your contribution! 🚀

authors: zachallaun zachdaniel

repo: ash-project/igniter


text:
Unable to load create_swapchain_khr on MacOS

Version of Rust: 1.62.1
Version of ash: 0.37.0
Version of VulkanSDK: 1.3.216.0
OS: MacOS 12.2.1
GPU: Intel Iris Plus Graphics 655 1536 MB

Can't figure out where I did wrong, running this on my machine will result in error: thread 'main' panicked at 'Unable to load create_swapchain_khr'
main.rs
fn main() -> Result<(), Box<dyn std::error::Error>>{
    let event_loop = EventLoop::new();
    let window = WindowBuilder::new()
        .with_title("AshApp")
        .with_inner_size(winit::dpi::LogicalSize::new(600, 400))
        .build(&event_loop)?;

    let entry = unsafe { ash::Entry::load()? };

    let app_info = ApplicationInfo{
        api_version: make_api_version(0, 1, 0, 0),
        ..Default::default()
    };
    let mut extension_names = ash_window::enumerate_required_extensions(&window).unwrap().to_vec();
    extension_names.push(KhrPortabilityEnumerationFn::name().as_ptr());

    let create_info = InstanceCreateInfo::builder()
        .application_info(&app_info)
        .enabled_extension_names(&extension_names)
        .flags(InstanceCreateFlags::ENUMERATE_PORTABILITY_KHR)
        .build();
    let instance = unsafe { entry.create_instance( &create_info, None)? };

    let surface = unsafe { ash_window::create_surface(&entry, &instance, &window, None).unwrap() };
    let surface_loader = Surface::new(&entry, &instance);

    let physical_device = unsafe { instance.enumerate_physical_devices()?
        .into_iter()
        .min_by_key(|p|{
        match instance.get_physical_device_properties(*p).device_type{
            PhysicalDeviceType::DISCRETE_GPU => 0,
            PhysicalDeviceType::INTEGRATED_GPU => 1,
            PhysicalDeviceType::VIRTUAL_GPU => 2,
            PhysicalDeviceType::CPU => 3,
            _ => 4,
        }
    }).unwrap() };

    let qf_indices = [0];

    let priorities = [1.0];
    let queue_infos = qf_indices.iter().map(|&i|{
        DeviceQueueCreateInfo::builder()
            .queue_family_index(i)
            .queue_priorities(&priorities)
            .build()
    }).collect::<Vec<_>>();

    let device_create_info = DeviceCreateInfo::builder()
        .queue_create_infos(&queue_infos)
        .build();

    let device = unsafe { instance.create_device(physical_device, &device_create_info, None)? };
    let queues = unsafe{ qf_indices.iter().map(|&i| device.get_device_queue(i, 0)).collect::<Vec<_>>() };

    let surface_caps = unsafe { surface_loader.get_physical_device_surface_capabilities(physical_device, surface)? };
    // let surface_present_modes = unsafe{ surface_loader.get_physical_device_surface_present_modes(physical_device, surface)? };
    let surface_formats = unsafe { surface_loader.get_physical_device_surface_formats(physical_device, surface)?};

    let surface_format = surface_formats.first().unwrap();

    let swapchain_create_info = SwapchainCreateInfoKHR::builder()
        .surface(surface)
        .min_image_count(2)
        .image_format(surface_format.format)
        .image_color_space(surface_format.color_space)
        .image_extent(surface_caps.current_extent)
        .image_array_layers(1)
        .image_usage(ImageUsageFlags::COLOR_ATTACHMENT)
        .image_sharing_mode(SharingMode::EXCLUSIVE)
        .queue_family_indices(&qf_indices)
        .pre_transform(surface_caps.current_transform)
        .composite_alpha(CompositeAlphaFlagsKHR::OPAQUE)
        .present_mode(PresentModeKHR::FIFO)
        .clipped(true)
        .build();

    let swapchain_loader = Swapchain::new(&instance, &device);

    let swapchain = unsafe {swapchain_loader.create_swapchain(&swapchain_create_info, None)?};

    unsafe {
        device.destroy_device(None);
        instance.destroy_instance(None);
    }
    Ok(())
}

VK_KHR_swapchain is a device extension and must be added to DeviceCreateInfo::enabled_extension_names.

I wonder if ash-window should make a enumerate_required_extensions version for device and instance extensions separately, if we didn't do/discuss that already.

VK_KHR_swapchain is a device extension and must be added to DeviceCreateInfo::enabled_extension_names.

I tried
extension_names.push(KhrSwapchainFn::name().as_ptr());
It says: Error: ERROR_EXTENSION_NOT_PRESENT
If I do
dbg!(instance.enumerate_device_extension_properties(physical_device)?);
I can see VK_KHR_swapchain is actually there

I tried extension_names.push(KhrSwapchainFn::name().as_ptr()); It says: Error: ERROR_EXTENSION_NOT_PRESENT

Your example is using that variable for InstanceCreateInfo, but Swapchain::name() (use the wrapper extension to get to the name) must go in DeviceCreateInfo.

I tried extension_names.push(KhrSwapchainFn::name().as_ptr()); It says: Error: ERROR_EXTENSION_NOT_PRESENT

Your example is using that variable for InstanceCreateInfo, but Swapchain::name() (use the wrapper extension to get to the name) must go in DeviceCreateInfo.

THX!! It works, I was a bit confused there

repo: ash-rs/ash


text:
No options in menu for adding file in GoLand

GoLand 2021.2.3
Build #GO-212.5284.40, built on September 14, 2021
EnvFile 3.2.2

That's weird, I couldn't reproduce this.

authors: ashald martin-sucha

repo: ashald/EnvFile


text:
Write tests for requests endpoints

Wrote tests for the requests endpoints

Pull Request Test Coverage Report for Build 73

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+15.6%) to 84.158%

Totals

Change from base Build 71:
15.6%

Covered Lines:
425

Relevant Lines:
505

💛  - Coveralls

Pull Request Test Coverage Report for Build 73

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+15.6%) to 84.158%

Totals

Change from base Build 71:
15.6%

Covered Lines:
425

Relevant Lines:
505

💛  - Coveralls

Pull Request Test Coverage Report for Build 73

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+15.6%) to 84.158%

Totals

Change from base Build 71:
15.6%

Covered Lines:
425

Relevant Lines:
505

💛  - Coveralls

authors: asheuh coveralls

repo: asheuh/flaskie


text:
🛑 Home Assistant is down

In 6a1d0af, Home Assistant (https://ha.ashhhleyyy.dev/) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Home Assistant is back up in f393ea0.

repo: ashhhleyyy/status-page


text:
Celery worker status

Hi,
I run 3 workers (each using its own queue) with different number of worker processes. When I try to "ping" them by doing:
./manage.py celeryctl inspect ping
I get pong only from those workers that have one or more idling worker processes. Workers with all busy  processes do not replay at all. Same thing then i try to get status information via python using "inspect" from "celery.task.control".
Not sure if it's a bug or a feature, but how do I reliably get the worker status ?
(Broker: RabbitMQ 2.7.1, Celery: 2.4.6)
Thanks,
lauris

On Feb 22, 2012, at 5:39 PM, PonasNiekas reply@reply.github.com wrote:

Hi,
I run 3 workers (each using its own queue) with different number of worker processes. When I try to "ping" them by doing:
./manage.py celeryctl inspect ping
I get pong only from those workers that have one or more idling worker processes. Workers with all busy  processes do not replay at all. Same thing then i try to get status information via python using "inspect" from "celery.task.control".
Not sure if it's a bug or a feature, but how do I reliably get the worker status ?
(Broker: RabbitMQ 2.7.1, Celery: 2.4.6)
Thanks,
lauris

Reply to this email directly or view it on GitHub:
https://github.com/ask/celery/issues/619

Have you disabled rate limits? Issues related to this have been fixed in the development version (2.5 will be released this Friday)

I had CELERY_DISABLE_RATE_LIMITS set to True yesterday. Today I set it to False, also set CELERYD_PREFETCH_MULTIPLIER to 4 (from 1) and it works just fine at the moment.
Looking forward to 2.5 .

authors: PonasNiekas ask

repo: ask/celery


text:
start documenting the GitHub tables

Starts to document the GitHub tables in the README, will wait to merge as more GitHub functionality is added

Codecov Report

Merging #146 (b6b6805) into main (a1aa14f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #146   +/-   ##
=======================================
  Coverage   67.91%   67.91%
=======================================
  Files          26       26
  Lines        1119     1119
=======================================
  Hits          760      760
  Misses        221      221
  Partials      138      138

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1aa14f...b6b6805. Read the comment docs.

authors: codecov-commenter patrickdevivo

repo: askgitdev/askgit


text:
🛑 Quiver Site is down

In 6ccaf51, Quiver Site (https://www.quivertheapp.com/) was down:

HTTP code: 403
Response time: 6 ms

Resolved: Quiver Site is back up in 383bd79.

repo: asmur/quiver


text:
Correctly resetting the terminal when quitting the application

When quitting the application, reset the terminal settings.  This is necessary for bash and ksh93, but not for sh, csh, tcsh, and fish.
Fixes #28

@stesser can you test please?

repo: asomers/gstat-rs


text:
Fix npmproj incrementalism

Makes it so dotnet build actually rebuilds npmproj's

Nice catch!

authors: NTaylorMullen ryanbrandenburg

repo: aspnet/AspNetCore-Tooling


text:
Multiple  tag helpers in same element interfere with each other

It seems that when you use multiple <component /> tag helpers side-by-side, e.g.,:
    <app style="display:block">
        <component type="typeof(Something)" render-mode="Server" />
        <component type="typeof(AnotherThing)" render-mode="Server" />
    </app>

... then they can disrupt each others' rendering and lead to corrupted UI updates. See the repro at https://github.com/aspnet/AspNetCore/issues/17570
My guess is that our JS-side code that converts the <!--Blazor:...--> comments into a LogicalElement isn't setting it up correctly, and perhaps has the logical elements both hooked up to the physical DOM parent as if they were its only child.

@SteveSandersonMS is this something we should look into patching?

@rynowak I think we should be prepared to do so. We know this has to be fixed, so there's no reason to delay doing so. Once we know what the fix looks like, we can make a call about whether it's small and safe enough to release as a patch, or whether that would take additional investment and we would rather wait for customer demand before doing so.
The workaround is pretty simply (surround each <component> with its own <div>) so it's more about the risk of people unknowingly deploying buggy sites than about there not being a workaround.

Fixed in https://github.com/aspnet/AspNetCore/pull/17910

authors: SteveSandersonMS rynowak

repo: aspnet/AspNetCore


text:
Add Tests and Docs: Razor Components Server Routes

I'm working on porting a project over to Razor Components. However, I have noticed something that could easily be fixed if we had the option to pick the route the Components boot on, on the server.  Would look something like this in a idea world.
app.UseRazorComponents<App.Startup>(o => o.route "/app1");
What my end goal is to be able to boot app1 and app2, ext on the same server. Without having to have two completely separate servers to do so.

This would be amazing. Then we can have scenario such as
Support.App will go to /support
Main.App will go to /
Admin.App will go to /Admin

@javiercn - is this covered in the work you've done so far or requires additional features to do? If this is already possible can we add a functional test and add to docs?

@rynowak Yeah, this should be able with the new design.
app.UseRouting(routes => routes.MapComponentsHub<App>(selector: "app", path: "/app1") i believe was the overload.

Overload produces a Connection ID required in Preview 3. Is this not functioning yet?

@rynowak @javiercn The issue is the components.server.js is hardcoded with the _blazor for the hub.
https://github.com/aspnet/AspNetCore/blob/master/src/Components/Browser.JS/src/Boot.Server.ts#L46
Also thhis Url and the one for the boot.json should be Root-Relative URLs

Was a user error but I did have to follow @LorenDorez  advise and copy and edit the js file for the hub name ... https://github.com/jbomhold3/workingsplitproject

Fair enough. We need to allow configuring that

@SteveSandersonMS How do you feel about creating a component/taghelper to render the script tag into the page and provide options? Either that or a component/taghelper that puts the components options in a place where we can find them. Something like
<ComponentScript HubAddress"/path"></ComponentScript>

or
<ComponentOptions HubAddress="/path"></ComponentOptions>

You would replace the script tag with the component/taghelper on the first one and it would produce a script tag with some data-* attributes assigned to it".
You would put the second one inside the head tag in your app and would produce one or more meta tags with the configuration options. Then you would put the script tag wherever you choose as normal.
When the components.server.js tag boots up, it will query the dom for the options and use them during the boot process (or use default values if not found).

I don't quite yet understand the requirement.
You can already connect to different Websocket endpoints by changing the <base href> in the page. The only thing about that which is fixed is that the path has to end with /_blazor [1], but you can have other custom stuff in the path before that. What are the scenarios where this is insufficient?
[1] The default name for that will change at some point.

Also thhis Url and the one for the boot.json should be Root-Relative URLs

They are base-relative URLs. They shouldn't be root-relative. The base href already controls the mapping from base-relative to root-relative.

BTW if the idea is to open multiple concurrent connections to different Razor Components endpoints from within the same page, this isn't something we've ever supported, and may require quite a lot more changes besides controlling the target endpoint. Lots of things, such as the client-side router, rely on the idea that there is exactly one base href and they get to control the URL space. This is common to most SPA frameworks.

@SteveSandersonMS Fair enough, I didn't think about the base path as a factor. You are totally right, this is just a matter of aligning your base path with whatever you set up in MapComponentsHub

OK, I'm going to close this as there's nothing further to be done. If the docs are insufficient, please file an issue or PR on https://github.com/aspnet/docs/

@SteveSandersonMS  The Idea isn't to open multi end points to the same page. It's to have different apps,on different routes using the same server. IG what I have here https://github.com/jbomhold3/workingsplitproject and it does work.  While I have no issue with doing                routes.MapComponentHub<App2.App2>("app", "/app2/_blazor"); to make the script work as is.  If your going to give a overload that allows you to name the end point hub. Then we should have something in the java that allows us to set the endpoint name as well. @LorenDorez and my use case on this does not align.

@SteveSandersonMS The issue is that base path is not used for the Hub Connection on the JS file. So either this needs to be allowed to customize or the overload on the server side MapComponentsHub needs to be removed. I just tested with  fresh project and when i set my MapComponentHub("app","app1") i get a SingalRHub at "/app1" however the JS cant connect because its trying to connect to "'_blazor".
I ask for it to be atleast considered to allow us to customize the JS side.

You already can do that by having different base href values on different pages.

Yes but when it created the HUB it doesnt append '_blazor' if we overload the MapCompoenentHub it simply overwrites. so if i do MapComponentHub("app","app1") it will do routes.MapHub<ComponentHub>("app1").AddComponent(componentType, selector);' This should be **app1/_blazor**. it would then need to append the value from ComponentHub.DefaultPath`

Here is a sample app where i set the base path, updated iis express to launch on base path and all work expect it dies trying to connect to a signalr hub at "app1/_blazor"
https://github.com/LorenDorez/EatSleepBlazorRepeat/tree/master/RCApp

@LorenDorez  do you manage to get this working ? I can't get this working
   routes.MapComponentHub<App2.Components.App>("app", "/application2");

<!DOCTYPE html>
<html>
<head>
    <meta charset="utf-8" />
    <meta name="viewport" content="width=device-width, initial-scale=1.0" />
    <title>Multiple Apps</title>
    <base href="/application2/" />
</head>
<body>
    <app></app>
    <script src="_framework/components.server.js"></script>
</body>
</html>

@SteveSandersonMS Fair enough, I didn't think about the base path as a factor. You are totally right, this is just a matter of aligning your base path with whatever you set up in MapComponentsHub

@javiercn This doesn't seem to be the case. I can't get the simplest sample to work.

@SteveSandersonMS Do we have an E2E test for this? Feels like we should and we can just point people there for a sample.

@javiercn Yes, our E2E test app is hosted on a non-root URL for this exact reason.

@dodyg Yes i got this to work on the base path. Make sure you also update your LaunchSettings.json to launch your app with the new endpoint

@LorenDorez I can't make it work with Kestrel at  http://localhost:51997/application2.
I got JS error Uncaught SyntaxError: Unexpected token <  at http://localhost:51997/application2/_framework/components.server.js
        public void Configure(IApplicationBuilder app, IHostEnvironment env)
        {
            if (env.IsDevelopment())
            {
                app.UseDeveloperExceptionPage();
            }
            else
            {
                // The default HSTS value is 30 days. You may want to change this for production scenarios, see https://aka.ms/aspnetcore-hsts.
                app.UseHsts();
            }

            app.UseHttpsRedirection();
            app.UseStaticFiles();

            app.UsePathBase("/application2");
            app.UseRouting(routes =>
            {
                routes.MapComponentHub<App2.Components.App>("app", "application2");
                routes.MapRazorPages();
            });
        }

@page "{*clientPath}"
<!DOCTYPE html>
<html>
<head>
    <meta charset="utf-8" />
    <meta name="viewport" content="width=device-width, initial-scale=1.0" />
    <title>Multiple Apps</title>
    <base href="/application2/" />
</head>
<body>
    <app></app>

    <script src="_framework/components.server.js"></script>
</body>
</html>

@Dodyg did you update your launch settings for Kestrel? so that it knows you want to put on the directory?

Kestrel does not allow using path base in launchSetting.json. It must be set via code     app.UsePathBase("/application2");

authors: LorenDorez SteveSandersonMS dodyg javiercn jbomhold3 rynowak


text:
React to changes in Microsoft.NETCore.App

Part of aspnet/AspNetCore#9720, similar to https://github.com/aspnet/Extensions/pull/1828.

bump


text:
Convert to plugin architecture?

I very much appreciate this page, and the idea of pushing views into reusable components.  But I'm wondering if this can be pushed to the next step, and have these components loaded as plugins?  This way the website wouldn't require a direct dependency to the component?
I suspect this is possible based on the following successful experiment:

I built the above project/library combo with the dependency, and it created a .deps.json file.  This is able to find the library views ok.
I built the above project/library combo, but this time w/out the dependency.  It created a different .deps.json file.  This time, it was NOT able to find the library views.  (Expected)
However, if I overwrite the .deps.json file with the original .deps.json file, when I run the project, it finds the library views.

This shows me it is possible to build the project w/out a direct dependency on the library, and still be able to make use of it at runtime, by manipulating the .deps.json file.  (Hmmmm, I wonder if this is a security risk?)
Anyway, it's a hack, and would prefer to load the library views as a plugin.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 9fd019c7-ceb7-6ef3-26ba-6b44341b6fc5
Version Independent ID: fd116d00-0dc7-efaf-c714-34d77b345a05
Content: Reusable Razor UI in class libraries with ASP.NET Core
Content Source: aspnetcore/razor-pages/ui-class.md
Product: aspnet-core
GitHub Login: @Rick-Anderson
Microsoft Alias: riande

@pranavkm please comment.

Instead of dropping code into the running app we would recommend using a module system, like the one Orchard Core provides. Orchard Core modules allow you to build modules as NuGet packages that can be added to your application on the fly. And you can use them as a low level framework without adopting the entire Orchard CMS infrastructure. Check out https://github.com/OrchardCMS/OrchardCore.Samples to see what this looks like.
https://github.com/aspnet/Mvc/issues/7825#issuecomment-392129629 has some relevant comments about why dynamically loading assemblies might not be a very good idea.

Some clarification: I'm not trying to bring in multiple plugins, only one plugin that would override a small set of views.
My particular situation is trying to port to .NET Core a legacy system applied to many different clients.   Though each client shares a common history, each client system has unfortunately diverged as it became more customized to that particular client.
I'm researching an idea around (a small set of) client customized views, each client all sharing the same controller and model.  Theory being compiling the client views separately, and using the appropriate client view library at run-time.  (Additional issues such as CSS, JS, images, etc. to be dealt with later)
This article comes so close by offering a means of putting the views into a library.  It's just that to work a project reference to the library must exist.  It's purpose isn't to help the project compile, but rather the library is copied to the /bin/ folder, and the .deps.json file updated to load the library at run-time.

I downloaded OrchardCore, got it to build and run the OrchardCore.Mvc.Web sample project.  However, this demo is showing that a project reference to the modules it loads is still required.  I'm trying to break this coupling.  At the moment, it looks like Orchard is not going to help.

@eric-914 What you are trying to do is to load an assembly without a direct reference to that assembly, right? And then have that assembly override internal components?
If so... that yeah, we took that support out of Orchard Core for a number of reasons.
What you could do is to... when the application is loaded, look inside a predetermined folder for any order assemblies, load those up in to your DI. Make sure you load them last so they over ride any internal components.

Thanks for contacting us.
We don’t have the resources to invest in this area, so we are closing the issue. Should your request generate enough  👍 responses, we’ll reconsider.

repo: aspnet/Docs


text:
What is the purpose of SendGridUser

The SendGridUser is never used in the code. What is the purpose?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: fe1bea60-d173-f6d2-3559-b147699e295a
Version Independent ID: 98e7aacb-2a01-d581-9b03-bfef2893163e
Content: Account confirmation and password recovery in ASP.NET Core
Content Source: aspnetcore/security/authentication/accconfirm.md
Product: aspnet-core
GitHub Login: @Rick-Anderson
Microsoft Alias: riande

@MSIH  you're right, it's not used in the sample. It could be used in From = new EmailAddress("Joe@contoso.com", "Joe Smith"),
I think it was used in an earlier version when it was required by the SendGrid API.

authors: MSIH Rick-Anderson


text:
Add license

Addresses #1046

Hmm, this looks like a bit of a hack. The license isn't part of the copyright.

I think the "right" way to do this is to specify a custom jinja template for the footer that overrides the footer block from the basic sphinx theme: https://github.com/sphinx-doc/sphinx/blob/master/sphinx/themes/basic/layout.html#L185

Or we could just do the hack :smile:. :shipit:

I'm updated the PR to do it the "right" way

Cool :shipit:


text:
Remove links to Glyphicons library. Closes #7382

As discussed in #7382 the Bootstrap 4 CDN section should not contain reference to Glyphicons library as:

this is no longer part of Bootstrap itself, it ships without icon/web font dependency now

Thanks!

Thank you again for pointing this out, @peterblazejewicz

authors: peterblazejewicz scottaddie


text:
How to disable migrations for existing databases

How do you disable migrations for existing databases in code?
Previously I used this in the DbContext constructor:
Database.SetInitializer<ApplicationDbContext>(null);

EF7 will never automatically create or alter your database schema. Users will need to explicitly call one of the following to do that.
context.Database.EnsureCreated();
context.Database.Migrate();

@bricelam what's the difference between Migrate and EnsureCreated?

EnsureCreated bypasses Migrations. It will simple create the database schema for the current model. It is primarily used for prototyping and testing.

@bricelam I am running into the same issue. I have tried calling EnsureCreated() and Migrate() as suggested but still get a nondescript error that "There are pending model changes for AppDbContext". Is there another way to disable migrations so I might get a more useful error?

@sheinema did you try scaffolding the next migration to see what changes it things are pending?

@rowanmiller yes, I was able to figure out the mismatch; however my team is interested in completely disabling migrations since we are doing database first. It would be nice to get a more useful/specific error and not have to scaffold a new migration each time.

@sheinema so the database error page will only ever show if there is an exception trying to access the database (and details of the exception will be shown on the page too). It won't ever show just because you have pending model changes - it's trying to add some helpful information about your model in a situation where you would be getting an error page anyway.

You can always remove it, there is an AddDatabaseErrorPage call in Startup.cs, then you will just see the standard error page in these situations.

@rowanmiller Thank you, removing AddDatabaseErrorPage() indeed reverted to the standard error page.
The migrations error message did include the generic exception but not the stack-trace, which is what we were looking for.

@sheinema do you have any migrations in your project? I would only expect to see the pending changes message if you have a model snapshot for the context in question.

@rowanmiller No, there are no migrations in this project; no model snapshot

Opened https://github.com/aspnet/Diagnostics/issues/182 to review this scenario as we shouldn't talk about migrations on the page when you have an existing schema and no migrations. We should also include info about how to turn off the error page.

authors: Vasimovic bricelam davezych rowanmiller sheinema

repo: aspnet/EntityFramework


text:
MySQL provider shown as "coming soon", but not on roadmap

MySQL is shown as a provider on the docs and is listed as "Coming Soon" here: https://docs.efproject.net/en/latest/providers/mysql/index.html. However, it's nowhere to be seen on the roadmap, here: https://github.com/aspnet/EntityFramework/wiki/Roadmap.
Filing this ticket in hopes of finding clarification as to when EF Core will have MySQL support.

dupe of #5659

@amattie There is an open sourced and free mysql provider for ef core now: https://github.com/PomeloFoundation/Pomelo.EntityFrameworkCore.MySql

Hi all,
We have published our first version of the .net core driver and the ef core provider. Have a look if you like at nuget.
More information here:
http://insidemysql.com/mysql-connectornet-7-0-4-m3-has-been-released/

authors: Kagamine amattie gmartinezsan smitpatel


text:
Enable SDL validation in rel/3.1

Part of aspnet/AspNetCore-Internal#3293
@riarenas @JohnTortugo PTAL
CC @aspnet/build

This is equivalent to aspnet/Extensions#2579 which was validated & approved


text:
Visual Studio and dotnet scaffolded view generation does not follow new DbSet convention

I feel as if this issue is certainly already filed, but I cannot locate anything that would be relevant.
With the improvements to naming deductions/generations in EF.NET Core 2, the existing tooling (both in Visual Studio 2017 Preview as of 15.6 Preview 4.0 and with the CLI dotnet apsnet-codegenerator utility) does not generate code compatible with the new DbContext table names.
In particular, while EF.NET Core 2 uses the existence of DbSet<Entity> SetName as a hint that the table for Entity is SetName, the code generated by the tooling is wholly ignorant of any such concept and instead relies on the presence of a table/DbSet in the DbContext that uses the name of the entity as the name of the DbSet<Entity> property and/or table.
Since the code for analyzing DbSet<Entity> members to automagically determine property names is already written, it should be reused by the tooling to generate compatible views that do not need to be hand-edited afterwards. Both tooling approaches for scaffolding generation already require the project to be compiled for analysis in all cases.
(Note that even overriding OnModelCreate and adding builder.Entity<Model>().ToTable("ActualName") is presently ignored by the tooling.)

@mqudsi ASP.NET scaffolding is managing in the https://github.com/aspnet/Scaffolding repo. It looks like this issue was already reported there: https://github.com/aspnet/Scaffolding/issues/633

Awesome, thank you very much!

authors: ajcvickers mqudsi

repo: aspnet/EntityFrameworkCore


text:
Increase ANCMV1 minor version to 8.2

https://github.com/aspnet/IISIntegration/blob/release/2.2/version.props currently has 8.1 as the version number, which isn't higher than the current ANCM installation. This causes the dll not to be replaced.

Current public ANCM version:
ANCMV1
Dll version: 8.2.1991.0
Msi version: 2.1.1991
Proposed versions:
ANCMV1 and ANCM V2
release/2.1
Dll version: 12.1.xxxx
Msi Version: 2.1.xxxx
release/2.2
Dll version: 12.2.xxxx
Msi Version: 2.2.xxxx
release/3.0
Dll version: 13.0.xxxx
Msi Version: 3.0.xxxx
This keeps versions between the dll and msi consistent.

What about WHB?

@joeloff Can we make build versions of the windows hosting bundle match what we do for the rest of aspnetcore?
https://github.com/aspnet/WindowsHostingBundle/blob/master/tools/Version.props#L50-L63 vs last two digits of the current year + number of days since Jan 1st?

Normally we'd grab the build number from the props file that's passed through during official builds. That section is only used when you build locally to generate a build number

authors: jkotalik joeloff pakrym

repo: aspnet/IISIntegration


text:
Disable requestTimeout when the debugger is attached

Similar to how startupTimeLimit is ignored while the debugger is attached to enable debugging startup, requestTimeout should also be ignored to help debug requests.

this is a per request issue. If we check whether debugger is attached for each request, there will be significant performance cost. There is a simple workaround that user can change the request time out value at the web.config.

What's the % overhead per request for checking if the debugger is attached?

We don't have concrete % overhead since we haven't protoyped it. However, we are confident there will be a perf impact looking at the code path.
Since there are multiple config changes required (see also #171), we think it's best to document it in a debugging document.

authors: Tratcher pan-wang shirhatti


text:
Two factor authentication by Email

Is it possible to configure 2FA via email in a .net core 2.0 or 2.1 application?
I can't find any information anywhere about it apart from SMS or QR code examples which are not usable in a PCI compliant environment.
Are there any email 2FA examples anywhere?
Thank you

Yes, it's still in there (and presumably supported). My suggest is to create an ASP.NET Core 1.x project and see how the starter code does it.

That's great, thank you! I can confirm I followed the process from core 1.x and it worked without any issues.

authors: brockallen flatproject

repo: aspnet/Identity


text:
Add some space in the LogLevel enumeration and flip the values

Proposal: Critical = 0, Error = 10000, Warning = 20000, and so on.
This has a few advantages over the current stack. First, default(LogLevel) signifies "record only critical failures", which seems an appropriate default if the developer didn't specify an explicit level. Second, adding extra space gives us room to add new levels in the future. Third, it allows you to think of the log level as a measure of verbosity, so the condition if (level >= LogLevel.Warning) naturally correlates to "only log this if the current verbosity level is at least 'Warning'".
/cc @BrennanConroy @lukewaters

Not sure why we'd ever inject more log levels - I'm not sure what the semantic would be if we ever added a new one. Similarly for the order, the world seems to be split between high->low and low->high. It's easy to argue the ordering should be "most severe is biggest because it's the most important" but it's just as easy to argue as "most verbose is biggest because it's the most messages".

Yea, these level types are pretty standard across the most popular logging technologies on .NET today.

Shall we close then?

Yeah I'm not sure there's any clear benefit to these suggestions over what we currently have.

authors: Eilon GrabYourPitchforks davidfowl

repo: aspnet/Logging


text:
[2.1] Allow SqliteParameter.Size to be -1

Fixes #511

(Blocked waiting for branch to open)

@bricelam was this approved by shiproom already? Otherwise the branch was opened yesterday.

Not yet approved

@bricelam Now it is :+1:

authors: bricelam divega


text:
DataAnnotationsLocalization does not cover [Display] attribute

I updated LocalizationWebSite's User.cs model with [Display(Name="UserName")].
Also, I added key-value UserName->UserNameTranslated into the resx file for given model.
I expected that /Home/GetInvalidUser?culture=fr will have UserNameTranslated as label for first textbox.
Actual result is 'UserName'.

@yossarianeq I suspect you're asking for a #3518 fix. Correct?

@dougbu Yes. Sorry for the duplicate, I was not able to find it.

authors: dougbu yossarianeq

repo: aspnet/Mvc


text:
Null passed as arguments to controller method parameters when no InputFormatter matches

if the request's content-type is missing or not matching any InputFormatter then controller methods are passed null as arguments where data need to be deserialized. In the example below 'employee' is then null when the method is called. Instead the code 415 should be returned and the controller method should NOT be called.
public IActionResult UpdateEmployee(uint employeerId, [FromBody] Employee employee)
P.S:
A workaround is to create a middleware the code below to force the error it is not very pretty and breaks if other content types than json is added because I am not aware how to check properly any of the registered InputFormatter's match rather then hardcoding it.
       async Task Invoke(HttpContext context)
        {
          string method = context.Request.Method;
          if (method == "PUT" || method == "POST" || method == "PATCH")
          {
                RequestHeaders typedHeaders = context.Request.GetTypedHeaders();
                MediaTypeHeaderValue contentType = typedHeaders.ContentType;
                if (contentType==null || contentType.SubType!=@"json")
                {
                    context.Response.StatusCode = Status415UnsupportedMediaType;
                    return;
                }
          }

          await next.Invoke(context);
        }

If you want this behavior add [Consumes("application/json", "text/json")]. You can add this to the list of  global filters if you want to configure it application-wide.
services.AddMvc(options => options.Filters.Add(new ConsumesAttribute(...)));

@rynowak I can not confirm this. I tried adding the consumes attribute to the base controller for all my controllers and it does not change the behavior. I still get null passed to the employee argument if content-type is missing for my PUT request to the update method UpdateEmployee.

@bluemmc - this is definitely at odds with how the feature was intended to work - https://github.com/aspnet/Mvc/issues/1782
It looks like this code has remained mostly unchanged since it was added aspnet/Mvc@60fa4a6f
I'll dig in and see what I can figure out.

This case, and the surrounding comment just don't really fit the intent of the feature. I think we've had this bug for a while because no one was paying attention to what happens when you don't have a content type!
https://github.com/aspnet/Mvc/commit/60fa4a6f#diff-69de547dc02178bc5eb004e33185ce7cR78
I'd suggest the following changes to the handling when there's no ContentType specified in the body:

If another action exists without consumes, call it
If no other action exists (your case) - this should be a 415
If multiple other actions exist (overloaded on [Consumes(...)] - this should be a 415

Thanks for looking at this. I think behavior should depend on missing/wrong content-type AND if there are arguments that needs serialization or not. If there is no content content-type is not  required. if There is content-type should be required.

Based on ghost's comment:

Thanks for looking at this. I think behavior should depend on missing/wrong content-type AND if there are arguments that needs serialization or not. If there is no content content-type is not required. if There is content-type should be required.

This behaviour is not currently honoured in Mvc v2.0.2.
calling a POST method with a null body and null Content-Type is also returning 415 status code. It sounds like the intended behaviour is to allow null input with no content-type specified. The parameter in the controller action should then be null.

The behavior is to return 415 when you have an argument that would need to be deserialized, Independent of whether you sent content type or not, and to let requests without content type go through when they aren’t deserializing arguments from the body.

So in my example of:
Controller action has a [FromBody] argument of type object, and [HttpPost]
annotation
POSTing to that action's route with an empty body, and no Content-Type
header.
Status code 415 is or is not expected in this case? I would argue that we
should expect the action to be hit with an argument of default(T). What we
actually observe is 415 returned at model binding time (i.e. the action is
not hit).
On Wed, Feb 21, 2018 at 7:29 AM, Javier Calvarro Nelson <
notifications@github.com> wrote:

The behavior is to return 415 when you have an argument that would need to
be deserialized, Independent of whether you sent content type or not, and
to let requests without content type go through when they aren’t
deserializing arguments from the body.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/aspnet/Mvc/issues/3874#issuecomment-367363713, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ACfI6KMaMRJyJtqtGTB8aXJ8N1FXgHhMks5tXDZsgaJpZM4G_h0I
.

as per HTTP/1.1 spec: https://www.w3.org/Protocols/rfc2616/rfc2616-sec7.html#sec7.2.1

Any HTTP/1.1 message containing an entity-body SHOULD include a Content-Type header field defining the media type of that body. If and only if the media type is not given by a Content-Type field, the recipient MAY attempt to guess the media type via inspection of its content and/or the name extension(s) of the URI used to identify the resource. If the media type remains unknown, the recipient SHOULD treat it as type "application/octet-stream".

[emphasis mine]
Based on this deinition, ASP.NET Core is not going against a "must"/"must not" portion of the spec. However the bolded section indicates that there should be a default value.
So in the request received pipeline - empty content-type should be coerced into "application/octet-stream" and then model binding should be performed on the null data, with the null object passed into the controller action method. The action should handle null data input.

If the media type remains unknown, the recipient SHOULD treat it as type "application/octet-stream"
Old Web API used to have that behavior and it was a frequent source of issues for customers. The current behavior, while not "fully compliant" is less surprising to our customers and results in a better experience.

The result in the general case would be the same as we don't have any formatter that handles application/octect-stream and there is no useful way the framework can provide a mapping between application/octect-stream and a given type.
If you want to have this behavior you can just write your own input formatter and plug it in.

If you want to have this behavior you can just write your own input formatter and plug it in.

This is what I'd already ended up doing via a ResourceFilter: https://gist.github.com/fiksen99/61cef3d1e9af8830e12933e70a2437af
However it still feels like this behaviour is broken. Why should the existence of Content-Type matter when the body of a request is null? Regardless of Content-Type, we should be able to map this to a null/Default(T), and have my controller handle the request, instead of failing at model biding time.

authors: bluemmc fiksen99 ghost javiercn rynowak


text:
TagHelper: How to use a form model that is not the same as the view model

I use a view model to transport my data from the controller to the view. Inside the view I have a html form which posts data to a controller action. The post action model is different to my view model. How can I achieve that the TagHelper react to another model?
For HtmlHelper I can create a separate instance of type HtmlHelper and use this with razor syntax. But TagHelpers work with a ModelExpression that automatically binds to the view model.

@audacity76 one approach would be to make your form model a property of the view model. Then post back only that important part of the view model.
Another approach would be to create a variable named model that references your form model. Then use model in the tag helpers e.g. <input asp-for="@model.Name" /> would bind a ModelExpression with the Name "Name".

@dougbu thanks, both approaches are working great. It's worth mentioning that these strategies are leaving a prefix (the view model property name or the variable name) in the html name (and id) fields. Therefore the parameter in the post action needs to be the same as the prefix otherwise the model binder doesn't work.


text:
Integration tests always use development environment

Is this a Bug or Feature request?:
Bug
Steps to reproduce (preferably a link to a GitHub repo with a repro project):
https://github.com/henrik-olsson-valtech/EnvironmentRepro
Description of the problem:
ASP.NET Core 2.1 web API reads environment from environment variable ASPNETCORE_ENVIRONMENT with "normal" Kestrel hosting but not when hosted in a test. Was this changed with https://github.com/aspnet/Mvc/commit/ced377d89b2208cddce3a3157925a1d4fb0c0113? It doesn't work for us, becuase we're running integration tests as part of our build in an integration test environment.
Version of Microsoft.AspNetCore.Mvc or Microsoft.AspNetCore.App or Microsoft.AspNetCore.All:
2.1.0

I doubt anyone thought people would use environment variables in their test setup 😄
You could work around it pretty easily though:
diff --git a/EnvironmentRepro.IntegrationTests/WebApplicationFactory.cs b/EnvironmentRepro.IntegrationTests/WebApplicationFactory.cs
new file mode 100644
index 0000000..21790db
+++ b/EnvironmentRepro.IntegrationTests/WebApplicationFactory.cs
@@ -0,0 +1,20 @@
+using System;
+using Microsoft.AspNetCore.Hosting;
+
+namespace EnvironmentRepro.IntegrationTests
+{
+    public class WebApplicationFactory<TEntryPoint> : Microsoft.AspNetCore.Mvc.Testing.WebApplicationFactory<TEntryPoint>
+        where TEntryPoint : class
+    {
+        protected override void ConfigureWebHost(IWebHostBuilder builder)
+        {
+            base.ConfigureWebHost(builder);
+
+            var environment = Environment.GetEnvironmentVariable("ASPNETCORE_ENVIRONMENT");
+
+            if (!string.IsNullOrEmpty(environment))
+            {
+                builder.UseEnvironment(environment);
+            }
+        }
+    }
+}

Yes, I already had a workaround similar to that one (although yours is better). But I spent several hours to understand the problem and implement a workaround.

I doubt anyone thought people would use environment variables in their test setup

What do you mean? We have the following:

We want to run integration tests in multiple environments (development and test/staging).
We have different configurations in different environments, so the web API must load appsettings.Development.json or appsettings.Staging.json etc.
I thought that the ASPNETCORE_ENVIRONMENT environment variable is the way to tell ASP.NET Core which environment it is running in. Do you have an alternative solution?

What do you mean?

I'm just guessing that this is a scenario that didn't come up when the bug fix/feature was put in place. TBH, it's the first time I've heard of this.

Do you have an alternative solution?

My alternative solution would be to make your tests environment-agnostic (unless you have environment-specific code in your app). I.e. start out with a clean environment each time you run the tests. It's hard to say whether this would work for you without knowing more details about the environment.

We don't have environment specific code, but the environments contain databases that have different connection strings.

@javiercn, would like to get your opinion about this? I've requested your review on the associated PR also.

@henrik-olsson-valtech This is by design, so that apps in functional tests work so long as they work when you F5 or dotnet run the app. We expect people to write tests this way first and then productionize their tests to run on the CI, etc. Ideally with an environment specifically designed for running integration tests.

I might not have been super clear.
What @khellang is proposing is the expected way to do this.
If you need to run the tests against multiple environments with multiple setups the recommendation is that you override ConfigureWebHostBuilder and add the appropiate setups in there.
I'm closing the issue as this is by design and there's no further action to take in here.

authors: henrik-olsson-valtech javiercn khellang mkArtakMSFT


text:
Remove T4 custom tool

use same generator as most other projects in aspnet repos
were not using named arguments to resource methods anyhow

FYI mostly

@natemcmaster @pranavkm @ryanbrandenburg a quick confirmation: We don't plan to remove the resx target (and use regular generator) i.e. I'm not migrating toward something that's about to go.

Actually, we do plan to remove the resx target. I can't promise a timeline on it, but removing our custom resx targets is part of the plan to converge with Arcade. See The MicroBuild team won't let us use MicroBuild.Plugins.Signing in TeamCity agents, so this basically copies the API

Oops, copy paste fail. See https://github.com/aspnet/BuildTools/issues/728

@natemcmaster is aspnet/BuildTools#728 likely to make it in 2.2?

No.

Attempting to trigger VSTS validations.

authors: dougbu natemcmaster


text:
Scaffolding Controller with EF broken for projects targeting net4x

On a project targeting net4x run
dotnet aspnet-codegenerator -p . controller -name CarController -m WebApplication1.Models.Car -dc WebApplication1.Data.ApplicationDbContext
It fails with error
'Could not load file or assembly 'WebApplication1.exe' or one of its dependencies. The system cannot find the file specified.
   at Microsoft.VisualStudio.Web.CodeGeneration.ActionInvoker.<BuildCommandLine>b__6_0()
   at Microsoft.Extensions.CommandLineUtils.CommandLineApplication.Execute(String[] args)
   at Microsoft.VisualStudio.Web.CodeGeneration.ActionInvoker.Execute(String[] args)
   at Microsoft.VisualStudio.Web.CodeGeneration.CodeGenCommand.Execute(String[] args)'

cc @vkichline

Fixed in e28f8308da1d96faf6a089f820242eb0820ef4db

repo: aspnet/Scaffolding


text:
Twitter Authentication doesn't work as described in docs

I'm following this tutorial.
I have created new ASP.NET Core MVC app (VS2017 15.5.6, targeting .NET Core 2.0, based on Microsoft.AspNetCore.All v2.0.5) then added Microsoft.AspNetCore.Authentication.Twitter (v 2.0.1).
I added
services.AddAuthentication().AddTwitter(options =>
{
options.ConsumerKey = "8QTUn... CONSUMER KEY";
options.ConsumerSecret = "mhJvQ5liYQ... CONSUMER SECRET";
});

to Startup.cs just after
services.AddIdentity<ApplicationUser, IdentityRole>()
.AddEntityFrameworkStores<ApplicationDbContext>()
.AddDefaultTokenProviders();

lines.
When I run and try login with Twitter I'm getting
An unhandled exception occurred while processing the request.
HttpRequestException: Response status code does not indicate success: 401 (Authorization Required).
System.Net.Http.HttpResponseMessage.EnsureSuccessStatusCode()

trying to debug the issue I get this value for Authorization header: {OAuth oauth_callback="http%3A%2F%2Flocalhost%3A35857%2Fsignin-twitter", oauth_consumer_key="8QTUn...NAF", oauth_nonce="bd89dae721674133b4a58d047be5c22c", oauth_signature="zqesuPmJqUzQ49wpgyvhn8nyN6A%3D", oauth_signature_method="HMAC-SHA1", oauth_timestamp="1519210280", oauth_version="1.0"}

@blowdart
step-0 = Ok
step-1 with my ConsumerKey & ConsumerSecret =
fail: Microsoft.AspNetCore.Server.Kestrel[13]
      Connection id "0HLBRQ5ERRSD5", Request id "0HLBRQ5ERRSD5:00000001": An unhandled exception was thrown by the application.
System.Net.Http.HttpRequestException: Response status code does not indicate success: 401 (Authorization Required).
   at System.Net.Http.HttpResponseMessage.EnsureSuccessStatusCode()
   at Microsoft.AspNetCore.Authentication.Twitter.TwitterHandler.<ObtainRequestTokenAsync>d__14.MoveNext()

Oh, the issue was because of typo in Callback URL!
Thanks!

repo: aspnet/Security


text:
Add consent policies to CookiePolicy

Here is the baseline feature for discussion. CookiePurpose needs attention, we need to decide what the categories are, if there's a default policy allowing some categories, etc..
I updated CookieAuth to work, but not any of the remote auth providers.
Depends on https://github.com/aspnet/HttpAbstractions/commit/0bd9bd8f76665f64c3e412de94f10fe3703aca50

for http://github.com/aspnet/Security/issues/1561

Updated to drop cookie purposes and use IsEssential instead.
@blowdart said offline this is adequate for preview1, but is still mulling over the naming of a few properties.
The non-empty templates will add
            services.Configure<CookiePolicyOptions>(options =>
             {
                 options.CheckConsentPolicyNeeded = context => true;
             });

and
app.UseCookiePolicy();

Tested and ready for review.

authors: Tratcher glennc


text:
[Design] Use RemoteWebDriver for selenium tests

Addresses #277
In this PR:

Use RemoteWebDriver
Use Chrome by default
Option to use Firefox or Edge using environment variables
Turn off parallel test run for Edge - web driver does not support parallel selenium tests https://developer.microsoft.com/en-us/microsoft-edge/platform/issues/5980485/
Use AssemblyFixture to set up and tear down the selenium-standalone server and keep test run parallel (sample used https://github.com/xunit/samples.xunit/tree/f4d955a52d3298150ad2bd211c65a3477e184413/AssemblyFixtureExample)

Note:
Travis needs installation and Appveyor needs installation and starting the selenium server in yaml files despite the fixture for the tests.
I have tried running the tests on a clean machine and the fixture takes care of spinning up the server. We plan to move to dotnet-ci bot soon which would not require any configuration.
Next steps:

Logging for tests: Once the test run starts, there is no logging related to where in the process it is
Graceful handling of failures: In case of a failure or interruption in the test run, there needs to be clean up code that stops all the dotnet processes that had begun and close down web drivers and the selenium java process
Capture selenium server logs only for failures: May be useful to capture the selenium server logs to debug

Waiting for Appveyor and Travis to run successfully. I will request review once I make necessary changes

@SteveSandersonMS @javiercn Please take a look whenever you can!

Once https://github.com/aspnet/Coherence-Signed/issues/856 is done, run https://github.com/aspnet/templating/pull/519 on the CI. Then this can be merged.
I was unable to find a cross-platform and reliable way to programmatically shutdown the selenium-standalone server without killing all java processes. @SteveSandersonMS may have other ideas on how to handle that.
Thanks!

@javiercn, can you please handle merging this PR in?

I used most of this PR in my giant templating test fix PR, thanks @jbagga!

authors: jbagga mkArtakMSFT ryanbrandenburg

repo: aspnet/templating


text:
ChangeAbpTablePrefix should add “AbpUserClaims”

SetTableName<AbpUserClaims>(modelBuilder, prefix + "UserClaims", schemaName);

Thank you for finding this bug. Until it's released, you can do this in your OnModelCreating method:
modelBuilder.Entity<UserClaim>().ToTable("...");

authors: ChiakiYu hikalkan

repo: aspnetboilerplate/module-zero


text:
Announcement on discourse

I guess now that we have a working 0.1.0 we should announce the package on Discourse :).
Here are things that I think should be mentioned but of course you should be the one presenting  it  😄

copy-paste the example from the readme
explain that it can be used combined with Documenter to have live-rendering docs when editing the docs
mention that it's inspired from "browser-sync"
that it's meant for developping sites, not for interactive apps (for that people should consider Mux and all of that stuff)
that we welcome comments and suggestions for improvements

Cheers!
PS: I wouldn't mention JuDoc, I want to fix a few more things before announcing that package soon. (btw, pre-rendering is working now as you suggested for KaTeX and highlight.js!!)

Agreed, came up with roughly the same points. Probably can find some time this evening. JuDoc: great! Sadly, I still haven't had the time to try out all that great new stuff (the different layouts/styles etc.)... but really want to start my GH pages ASAP, have some things to share...

Look!

authors: asprionj tlienart


text:
[feature] Add changelog during github release creation

⭐ Suggestion
I monitor the project using the release emails sent by github upon publishing a release (Watch -> Custom -> Releases). Unfortunately, the sent email does not contain the changelog, as at the time the release is created/published it does not contain a changelog entry, but this is added later (manually?)
It would be nice if either:

the changelog could be generated before the creation of the release and the output added to the create release github action call OR
The release could be created in draft mode so that the publish happens when the changelog was added.

(I tried to figure out when the changelog is added: to my eyes it gets added manually or by some undocumented magic in the last step in the release workflow (heinrichreimer/action-github-changelog-generator only documents that it sets the changelog as an output which could be consumed by the create release action)
I can send a PR for both versions, if any of the solutions would be acceptable to you.

Thank you, worked like a charm!

Strangely, I would have expected that https://github.com/ast-grep/ast-grep/blob/d81cf31a1092334a82101f727a1c44f80f47a412/.github/workflows/release.yml#L116-L122 would be moved above the release creation action. Right now it seems to do nothing?

I don't quite understand the heinrichreimer/action-github-changelog-generator@v2.3 action since the README from that project said it will change release note upon release is created.
Maybe my configuration is wrong but it seems that we don't need the action at the moment.

I think the main result of that action is the changelog in an output (more or less a "variable" which contains the changelog so it can get passed from one action as an input to another) which can be used in the next step to create the release.
So you wouldn't need to maintain the changelog anymore, but let the action create it on the fly and use that output to create the release.

authors: HerringtonDarkholme jankatins

repo: ast-grep/ast-grep


text:
timeout at starting a call

Hi,
there is a bug (with the latest version), which sometimes occurs in our log at heavy traffic (more than 5-10 calls start at the same millisec).
When a new channel is added, a timeout happens:
08:05:20,709 ERROR [stderr] (AJ DaemonPool-1.2) Exception in thread "AJ DaemonPool-1.2" org.asteriskjava.live.ManagerCommunicationException: Unable to send GetVarAction
08:05:20,709 ERROR [stderr] (AJ DaemonPool-1.2) 	at org.asteriskjava.live.internal.ManagerCommunicationExceptionMapper.mapSendActionException(ManagerCommunicationExceptionMapper.java:60)
08:05:20,709 ERROR [stderr] (AJ DaemonPool-1.2) 	at org.asteriskjava.live.internal.AsteriskServerImpl.sendAction(AsteriskServerImpl.java:985)
08:05:20,709 ERROR [stderr] (AJ DaemonPool-1.2) 	at org.asteriskjava.live.internal.AsteriskChannelImpl.getVariable(AsteriskChannelImpl.java:763)
08:05:20,709 ERROR [stderr] (AJ DaemonPool-1.2) 	at org.asteriskjava.live.internal.ChannelManager.addNewChannel(ChannelManager.java:223)
08:05:20,709 ERROR [stderr] (AJ DaemonPool-1.2) 	at org.asteriskjava.live.internal.ChannelManager.handleNewChannelEvent(ChannelManager.java:496)
08:05:20,709 ERROR [stderr] (AJ DaemonPool-1.2) 	at org.asteriskjava.live.internal.AsteriskServerImpl.onManagerEvent(AsteriskServerImpl.java:1045)
08:05:20,709 ERROR [stderr] (AJ DaemonPool-1.2) 	at org.asteriskjava.manager.ManagerEventListenerProxy$1.run(ManagerEventListenerProxy.java:59)
08:05:20,709 ERROR [stderr] (AJ DaemonPool-1.2) 	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
08:05:20,709 ERROR [stderr] (AJ DaemonPool-1.2) 	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
08:05:20,709 ERROR [stderr] (AJ DaemonPool-1.2) 	at java.lang.Thread.run(Thread.java:745)
08:05:20,725 ERROR [stderr] (AJ DaemonPool-1.2) Caused by: org.asteriskjava.manager.TimeoutException: Timeout waiting for response to GetVar
08:05:22,033 ERROR [stderr] (AJ DaemonPool-1.2) 	at org.asteriskjava.manager.internal.ManagerConnectionImpl.sendAction(ManagerConnectionImpl.java:936)
08:05:22,033 ERROR [stderr] (AJ DaemonPool-1.2) 	at org.asteriskjava.manager.internal.ManagerConnectionImpl.sendAction(ManagerConnectionImpl.java:896)
08:05:22,033 ERROR [stderr] (AJ DaemonPool-1.2) 	at org.asteriskjava.manager.DefaultManagerConnection.sendAction(DefaultManagerConnection.java:326)
08:05:22,033 ERROR [stderr] (AJ DaemonPool-1.2) 	at org.asteriskjava.live.internal.AsteriskServerImpl.sendAction(AsteriskServerImpl.java:981)
08:05:22,033 ERROR [stderr] (AJ DaemonPool-1.2) 	... 8 more

It has timeout in ChannelManager.addNewChannel(), because getVariable() function needs more time than 2s (which is the default value of ManagerConnectionImpl.defaultResponseTimeout).
Timeout happens in ChannelManager.java at line 223:
channel.getVariable(Constants.VARIABLE_TRACE_ID);
Suggested solution (after debuging 2 days), ChannelManager.java at line 225
before:
                catch (NoSuchChannelException e)
after:
                catch (NoSuchChannelException | ManagerCommunicationException e)
This way, if a simple GetVarAction has timeout, it will try it again, and don't skip the rest of the addNewChannel(), because of an exception. (Or if it has no more time (SLEEP_TIME_BEFORE_GET_VAR interval was not enough to complete GetVar), it will skip it simple.)
I would happily upgrade to the latest version (instead of 2.0.0), but this bug blocks it.
Thank you very much! :)

Can I suggest that you fork the project and push a pr.
We can then review the code.
Superficiality you suggested change sounds fine.
On Wed., 17 Jul. 2019, 5:50 pm István Endrédy, notifications@github.com
wrote:

Hi,
there is a bug (with the latest version), which sometimes occurs in our
log at heavy traffic (more than 5-10 calls start at the same millisec).
When a new channel is added, a timeout happens:
08:05:20,709 ERROR [stderr] (AJ DaemonPool-1.2) Exception in thread "AJ DaemonPool-1.2" org.asteriskjava.live.ManagerCommunicationException: Unable to send GetVarAction
08:05:20,709 ERROR [stderr] (AJ DaemonPool-1.2) 	at org.asteriskjava.live.internal.ManagerCommunicationExceptionMapper.mapSendActionException(ManagerCommunicationExceptionMapper.java:60)
08:05:20,709 ERROR [stderr] (AJ DaemonPool-1.2) 	at org.asteriskjava.live.internal.AsteriskServerImpl.sendAction(AsteriskServerImpl.java:985)
08:05:20,709 ERROR [stderr] (AJ DaemonPool-1.2) 	at org.asteriskjava.live.internal.AsteriskChannelImpl.getVariable(AsteriskChannelImpl.java:763)
08:05:20,709 ERROR [stderr] (AJ DaemonPool-1.2) 	at org.asteriskjava.live.internal.ChannelManager.addNewChannel(ChannelManager.java:223)
08:05:20,709 ERROR [stderr] (AJ DaemonPool-1.2) 	at org.asteriskjava.live.internal.ChannelManager.handleNewChannelEvent(ChannelManager.java:496)
08:05:20,709 ERROR [stderr] (AJ DaemonPool-1.2) 	at org.asteriskjava.live.internal.AsteriskServerImpl.onManagerEvent(AsteriskServerImpl.java:1045)
08:05:20,709 ERROR [stderr] (AJ DaemonPool-1.2) 	at org.asteriskjava.manager.ManagerEventListenerProxy$1.run(ManagerEventListenerProxy.java:59)
08:05:20,709 ERROR [stderr] (AJ DaemonPool-1.2) 	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
08:05:20,709 ERROR [stderr] (AJ DaemonPool-1.2) 	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
08:05:20,709 ERROR [stderr] (AJ DaemonPool-1.2) 	at java.lang.Thread.run(Thread.java:745)
08:05:20,725 ERROR [stderr] (AJ DaemonPool-1.2) Caused by: org.asteriskjava.manager.TimeoutException: Timeout waiting for response to GetVar
08:05:22,033 ERROR [stderr] (AJ DaemonPool-1.2) 	at org.asteriskjava.manager.internal.ManagerConnectionImpl.sendAction(ManagerConnectionImpl.java:936)
08:05:22,033 ERROR [stderr] (AJ DaemonPool-1.2) 	at org.asteriskjava.manager.internal.ManagerConnectionImpl.sendAction(ManagerConnectionImpl.java:896)
08:05:22,033 ERROR [stderr] (AJ DaemonPool-1.2) 	at org.asteriskjava.manager.DefaultManagerConnection.sendAction(DefaultManagerConnection.java:326)
08:05:22,033 ERROR [stderr] (AJ DaemonPool-1.2) 	at org.asteriskjava.live.internal.AsteriskServerImpl.sendAction(AsteriskServerImpl.java:981)
08:05:22,033 ERROR [stderr] (AJ DaemonPool-1.2) 	... 8 more
It has timeout in ChannelManager.addNewChannel(), because getVariable()
function needs more time than 2s (which is the default value of
ManagerConnectionImpl.defaultResponseTimeout).
Timeout happens in ChannelManager.java at line 223:
channel.getVariable(Constants.VARIABLE_TRACE_ID);
Suggested solution (after debuging 2 days), ChannelManager.java at line
225
before:
catch (NoSuchChannelException e)
after:
catch (NoSuchChannelException | ManagerCommunicationException e)
This way, if a simple GetVarAction has timeout, it will try it again, and
don't skip the rest of the addNewChannel(), because of an exception. (Or if
it has no more time (SLEEP_TIME_BEFORE_GET_VAR interval was not enough to
complete GetVar), it will skip it simple.)
I would happily upgrade to the latest version (instead of 2.0.0), but this
bug blocks it.
Thank you very much! :)
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/asterisk-java/asterisk-java/issues/302?email_source=notifications&email_token=AAG32OAZJY5UOR3EUGAZSZLP73FNRA5CNFSM4IENQLNKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4G7U72BA,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAG32OATJCMYTV5IRHSTV7DP73FNRANCNFSM4IENQLNA
.

Hi,
the pull request was created, i hope it will help the code. :)
thanks!

Closed by #303

authors: bsutton endredy seanbright

repo: asterisk-java/asterisk-java