text:
Can not access Ionic app in Ionic Dev App

I am trying to access an Ionic app built on Windows 10 machine, in Ionic Dev App on mobile device over Wifi. I am not able to access it. In Ionic Dev App, connection times out.
I am not able to access such Ionic app in mobile browser also on mobile device.
I have opened ports: 8100, 8200 in Inbound Rules in Windows Firewall: Port Number: 8100, 8200; Action: Allow the connection; Profile: Private, Public, Domain.
Here is Ionic info on my box:
Ionic:
   ionic (Ionic CLI)  : 4.0.6 (C:\Users\<myuser>\AppData\Roaming\npm\node_modules\ionic)
   Ionic Framework    : ionic-angular 3.9.2
   @ionic/app-scripts : 3.1.11

Cordova:
   cordova (Cordova CLI) : 7.1.0
   Cordova Platforms     : none

System:
   Android SDK Tools : 26.1.1
   NodeJS            : v9.5.0 (D:\Program Files\nodejs\node.exe)
   npm               : 6.2.0
   OS                : Windows 10

Environment:
   ANDROID_HOME : D:\Users\<myuser>\AppData\Local\Android\sdk

Is there something I am missing. Any helpful info is highly appreciated.

Hi,
Hopefully you managed yp get past any issues but if not...
Can you see the app listed in DevApp or is it just spinning looking for apps?
If not you can try:

Restarting your device (worked for me, after a restart, my app was showing up in DevApp)
Connecting directly by opening the menu, selecting 'Enter address manually' and entering the info from your terminal when running 'ionic serve --devapp' (e.g. External: http://192.168.1.2:8100)

If you can see it, what do you see when you open the app?  You mentioned it times out but do you mean the connection, the app itself?
Cheers

Old post, but the following worked for me on Windows 10 Pro:

Go to Network & Internet settings->Status.
Change connection properties.
Select "Private" as the network profile.
Restart DevApp.
Enter address manually. (External address from console running the dev server.)

Allowing port 8100 in my PC's firewall was needed. Then it works.

Thanks @MattBH this worked for me. I think it would be nice to add this to the official getting started documentation 🤔

authors: Animion MattBH Mesaman daddywoodland singhniranjan

repo: ionic-team/ionic-app-scripts


text:
Error: Unable to load app.

Bug Report
Ionic version:

[x] 4.x
Current behavior:

After putting the app into the background and re-opening it, a blank white page appears with the text:
Error
Unable to load app.

Expected behavior:

Re-opening the app displays the last shown page.
Steps to reproduce:

ionic cordova build ios --prod --release.
Deploy to an actual device
Start the app without any debugger
Put the app in the background and interact with other apps
re-open the app

I only got this problem on the prod build without debugging enabled and I can't reliably tell what leads to this issue.
Other information:

Ionic info:

Ionic:

   ionic (Ionic CLI)             : 4.6.0 (/usr/local/lib/node_modules/ionic)
   Ionic Framework               : @ionic/angular 4.0.0-rc.0
   @angular-devkit/build-angular : 0.11.3
   @angular-devkit/schematics    : 7.1.3
   @angular/cli                  : 7.1.3
   @ionic/angular-toolkit        : 1.2.1

Capacitor:

   capacitor (Capacitor CLI) : 1.0.0-beta.11
   @capacitor/core           : 1.0.0-beta.11

Cordova:

   cordova (Cordova CLI) : 8.1.2 (cordova-lib@8.1.1)
   Cordova Platforms     : android 7.1.4, ios 4.5.5
   Cordova Plugins       : cordova-plugin-ionic 5.2.7, cordova-plugin-ionic-keyboard 2.1.3, cordova-plugin-ionic-webview 2.3.1, (and 8 other plugins)

System:

   ios-deploy : 1.9.4
   ios-sim    : 7.0.0
   NodeJS     : v10.12.0 (/usr/local/Cellar/node/10.12.0/bin/node)
   npm        : 6.4.1
   OS         : macOS Mojave
   Xcode      : Xcode 10.1 Build version 10B61

Thanks for your issue! From my point of view it's looking more like an issue with capacitor because I could not verify it (creating apps with cordova). So create an issue over there, I think they will have more information.
https://github.com/ionic-team/capacitor/issues

source: gharchive/issue

authors: Mobiletainment paulstelzer

repo: ionic-team/ionic

license: MIT

license_type: permissive

license_source: github-api


text:
InteliSense completion hints are not type aware

Describe the bug
InteliSense completion hints are not "type aware". When invoking the code-completion popup it doesn't take parameter types into account. It results in the "there you go - here's a list of all variables ever defined" hint, which isn't too helpful.
To Reproduce
Put a cursor at the end of the last line of this snippet and press ctrl+space:
let myFunc (x: string): string =
    x

let myInt1: int = 123
let myFloat1: float = 123.0
let myString1: string = "hello"

myFunc my

If you remove my from after myFunc and press ctrl+space, completion hint shows all variables in scope, most of which don't make sense type-wise:

Expected behaviour
I'd expect the hint to show only entries which make sense in terms of types.
Environment

Ionide version: v4.14.0
dotnet SDK version: v3.1.300
output of VSCode -> Help -> About:

Version: 1.46.1 (system setup)
Commit: cd9ea6488829f560dc949a8b2fb789f3cdc05f5d
Date: 2020-06-17T21:13:20.174Z
Electron: 7.3.1
Chrome: 78.0.3904.130
Node.js: 12.8.1
V8: 7.8.279.23-electron.0
OS: Windows_NT x64 10.0.19041

This is ultimately a limitation of the F# compiler service, where parameters to function calls are not fed as input into the machinery that determines a context for completion. Such a context would then allow for filtering based on relevant situations, like you describe. As it stands, Ionide would need to either work around this limitation with its own ad-hoc implementation of completion context, or do nothing since it's an upstream concern.

Would that make sense to raise it in the upstream repository then?

Duplicate of #164

authors: Krzysztof-Cieslak cartermp mjarosie

repo: ionide/ionide-vscode-fsharp


text:
"NDBC" commit introduced an eventTime string bug?

I'm guessing the recent, latest release of sensorml2iso is now being used to generate iso metadata records for NOS-COOPS, based on tests starting yesterday (8/20). It looks like my "NDBC" PR actually introduced a bug in the GetObservation eventTime string for non-NDBC service endpoints!
This is what a current NOS-COOPS GetObservation link looks like, taken from the IOOS Catalog:
http://opendap.co-ops.nos.noaa.gov/ioos-dif-sos/SOS?eventTime=2018-08-19T16:12:49None/2018-08-19T18:12:49None&request=GetObservation&version=1.0.0&responseFormat=text/csv&offering=urn:ioos:station:NOAA.NOS.CO-OPS:9087096&service=SOS&observedProperty=http://mmisw.org/ont/cf/parameter/sea_water_temperature

The eventTime arguments have an aberrant "None" string at the end of each datetime:  2018-08-19T16:12:49None/2018-08-19T18:12:49None. Previously there was no timezone suffix after the datetime, and this argument would've looked like this: 2018-08-19T16:12:49/2018-08-19T18:12:49.
I think the fix is simple, and involves changing this line:
utc_code = 'Z' if self.sos_type.lower() == 'ndbc' else None

to
utc_code = 'Z' if self.sos_type.lower() == 'ndbc' else ''

But I haven't tested it, and won't have time at least till mid Wednesday.

Resolved by #29.

authors: emiliom mwengren

license: mit

license_source: bigquery


text:
[Bug report]: Fiat rates from the API are wrong

Platform
Desktop
Version
1.6.5
Description
The calculation of each fiat value is correctly implemented in Firefly. However there is a big difference for some fiat values compared to exchanges.
I have checked the IOTA market API and there seems to be a big difference in the fiat rates. In the example below all rates received from the IOTA market API are listed. The fiat rate EUR for example is at 0.8528784648 to the base USD but it should be more like 0.97 at the time of the request.
"rates":{"CAD":1.2607249467,"HKD":7.7742430704,"ISK":126.3113006397,"PHP":48.5296375267,"DKK":6.3431130064,"HUF":309.8251599147,"CZK":22.2968017058,"GBP":0.7267292111,"RON":4.1981236674,"SEK":8.7320255864,"IDR":14524.9978678038,"INR":73.1880597015,"BRL":5.7491684435,"RUB":75.3240938166,"HRK":6.4567164179,"JPY":110.7974413646,"THB":31.2648187633,"CHF":0.9441364606,"EUR":0.8528784648,"MYR":4.1465245203,"BGN":1.6680597015,"TRY":8.2942430704,"CNY":6.551130064,"NOK":8.5249466951,"NZD":1.4301918977,"ZAR":14.7960767591,"USD":1,"MXN":20.512238806,"SGD":1.3448187633,"AUD":1.31445629,"ILS":3.3414072495,"KRW":1129.3731343284,"PLN":3.9665671642}}
Expected behaviour
Fiat rates should be correctly fetched.
Actual behaviour
For some fiat rates there is a big difference.
Can the issue reliably be reproduced?
No
Steps to reproduce the issue
No response
Operating System
Windows
Diagnostics
No response
Developer Profile
No
Profile Type
Software (Stronghold)
Staking
No response
Crash Status
None of the above
Error Messages
No response
Error Logs
No response
Duplicate declaration

[X] I have searched the issues tracker this issue and there is none

Code of Conduct

[X] I agree to follow this project's Code of Conduct

new version will be released soon with improved fiat

repo: iotaledger/firefly


text:
Don't set with_minimum_amount for accounts when they have a staking feature

Description of change
Don't set with_minimum_amount for accounts when they have a staking feature, as this would result in an invalid transition
Type of change

Bug fix (a non-breaking change which fixes an issue)

How the change has been tested
Sending txs with the cli wallet

We can't reduce the amount when we have the staking feature, without it, we can do the minimum

source: gharchive/pull-request

repo: iotaledger/iota-sdk


text:
Feat/integrate comms

Description of change
Refactor communication actor and integrate it into the stronghold interface.
Type of change
Choose a type of change, and delete any options that are not relevant.

[ ] Bug fix (a non-breaking change which fixes an issue)
[x] Enhancement (a non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation Fix

How the change has been tested
Added interface tests to read/ write a remote stronghold store.
Change checklist
Add an x to the boxes that are relevant to your changes, and delete any items that are not.

[x] I have followed the contribution guidelines for this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes

@lucasfernog and @tensor-programming - would love to have you both do an in depth review of this PR, from the perspective of your respective sides of this actor stack.

@lucasfernog and @tensor-programming - would love to have you both do an in depth review of this PR, from the perspective of your respective sides of this actor stack.

R,

I am right now doing some refactoring, but I will soon be done with that and then also mark the PR's as ready for review.

R,

I am right now doing some refactoring, but I will soon be done with that and then also mark the PR's as ready for review.

Please tag me when this is ready :)

Please tag me when this is ready :)

@lucasfernog @tensor-programming the PR is ready for review, but the following aspects are not implemented yet / need to be discussed afterwards:

what methods should exists in the stronghold interface (currently I only added write_remote_vault, read_remote_store and write_remote_store)
the firewall actor is at the moment just a dummy actor that accepts all requests, eventually it should be provided by the user
my changes depends on this PR to riker, right now I set my fork of riker as dependency, where the PR is included for development purposes

The tests currently fail until this PR is merged.

authors: elenaf9 lucasfernog nothingismagick


text:
Transitioning from "node-red-contrib-azure-iot-hub" palette

Thank you for developing the Azure-IoT-Device palette. The "direct" node works great for my publishing and direct method needs. I have tested my application offline and am trying to incrementally incorporate the new "direct" node into a production system that includes 25 flows, each flow communicating with various subsystems on various communication protocols (Modbus, SNMP, OPC, etc.). My existing production system uses the "node-red-contrib-azure-iot-hub" palette for just publishing telemetry in each of the 25 flows.
When I edited the first flow to include the "direct" node I noticed all IoT nodes from the legacy palette stopped publishing telemetry to the IoTHub. I was hoping to replace one flow at a time in the production system but this result creates a problem. Is this a know problem? Is there any work around? Thank you.

Related to the above I've tried everything I could think of:  export/reimport, edit node one at a time and redeploy, restart the controller, etc. All "direct" nodes are publishing duplicate payloads to IoT Hub but everything is very stable and reliable. I just don't want to be publishing double the payloads than what is necessary. Thank you.

same issue here, all the payloads (twins) are being published even to nodes without those 'properties'

@mgKeeKrog @BC-josgreeve thanks for reporting. I haven't tested using my node nect to the "node-red-contrib-azure-iot-hub" palette. I will check it out. Will also check the duplicate messages and twins. Each Azure IoT Device created with "node-red-contrib-azure-iot-device" should be individually addressable as twin.

Closing issue. Couldn't reproduce.

authors: BC-josgreeve iotblackbelt mgKeeKrog


text:
rounding balance of decimal xrc20

we may use more signaficant digitals to display
you can refer getTokenAmountBN

@hunglmtb The balanceString is already calculated by getTokenAmountBN
https://github.com/iotexproject/iotex-explorer/blob/master/src/erc20/token.ts#L132

authors: blesstosam hunglmtb

repo: iotexproject/iotex-explorer


text:
🛑 备用KMS激活服务器 01 is down

In 4c36e1a, 备用KMS激活服务器 01 (s11.ikms.eu.org) was down:

HTTP code: 0
Response time: 0 ms

Resolved: 备用KMS激活服务器 01 is back up in 89b7a8c after 9 minutes.

repo: iougemini/ikms-uptime


text:
🛑 备用KMS激活服务器 01 is down

In de28b39, 备用KMS激活服务器 01 (s11.ikms.eu.org) was down:

HTTP code: 0
Response time: 0 ms

Resolved: 备用KMS激活服务器 01 is back up in 6fe2bcf after 9 minutes.


text:
🛑 备用KMS激活服务器 01 is down

In 53ea507, 备用KMS激活服务器 01 (s11.ikms.eu.org) was down:

HTTP code: 0
Response time: 0 ms

Resolved: 备用KMS激活服务器 01 is back up in 7a2936d after 25 minutes.


text:
🛑 备用KMS激活服务器 01 is down

In 6f326a2, 备用KMS激活服务器 01 (s11.ikms.eu.org) was down:

HTTP code: 0
Response time: 0 ms

Resolved: 备用KMS激活服务器 01 is back up in 6944c21 after 10 minutes.


text:
🛑 备用KMS激活服务器 11 is down

In 0a93f11, 备用KMS激活服务器 11 (s01.ikms.eu.org) was down:

HTTP code: 0
Response time: 0 ms

Resolved: 备用KMS激活服务器 11 is back up in 69da98f after 39 minutes.


text:
🛑 备用KMS激活服务器 01 is down

In e257a78, 备用KMS激活服务器 01 (s11.ikms.eu.org) was down:

HTTP code: 0
Response time: 0 ms

Resolved: 备用KMS激活服务器 01 is back up in 0060952 after 15 minutes.


text:
Add support for assigning one tuple element value

Is your feature request related to a problem? Please describe.
I'm using a tuple to store some data after looking at the syntax here.
This allows me to access the data in the tuple using a convenient @tuple.1 syntax. However, I get an error message when I try to assign to it using @tuple.1 = 1;.
I'm running bpftrace v0.11.1 on Gentoo. Here's a one-liner that reproduces this:
root# bpftrace -e 'interval:s:1 { @x = (3, 3); @x.1 = 1; printf("%d\n", @x.1); }'
stdin:1:34-35: ERROR: syntax error, unexpected =, expecting }
interval:s:1 { @x = (3, 3); @x.1 = 1; printf("%d\n", @x.1); }
                                 ~

Describe the solution you'd like
It would be convenient if assigning to a tuple element just worked:
root# bpftrace -e 'interval:s:1 { @x = (3, 3); @x.1 = 1; printf("%d\n", @x.1); }'
Attaching 1 probe...
1
1
^C

Describe alternative solutions or features you've considered

The current solution of updating a tuple by assigning all the tuple values to it does work fine:

root# bpftrace -e 'interval:s:1 { @x = (3, 3); @x = (@x.0, 1); printf("%d\n", @x.1); }'
Attaching 1 probe...
1
1
^C

but allowing direct assignment would be a little more convenient.

If this is not possible due to syntax limitations, it would be good to document this in the reference guide.

Right, tuples are currently immutable once created. Just like python. Seems like python can get away with doing that so I'd like to see how long we can get away from it as well.

Agree on keeping immutable (atleast until we have a valid real world usecase)
But we should improve error message, so reopening this.
stdin:1:34-35: ERROR: syntax error, unexpected =, expecting }
interval:s:1 { @x = (3, 3); @x.1 = 1; printf("%d\n", @x.1); }

authors: danobi fbs rdmello

repo: iovisor/bpftrace


text:
Add support for new demo

Please remove the custom font for the one button

authors: fbjorn lietu

repo: ioxiocom/ioxio-tags


text:
fix: use floodsub events to simplify discovery

Fixes https://github.com/ipfs-shipyard/peer-star-app/issues/153
Note: This PR is ready for review, but will not pass tests until release v0.15.2 is included into libp2p2, and we include that version of libp2p2 in peer-star-app

pedroteixeira@MacBook-Pro-4:~/projects/ipfs/peer-star/peer-star-app (master)
→ npm ls | ag floodsub
│ │ ├── libp2p-floodsub@0.15.2 deduped
│ ├─┬ libp2p-floodsub@0.15.2

@dirkmc if you rebase from master you should get that dependency included..

It looks like there are a couple of pinner related tests failing that I don't think are related to the work I've been doing (but I will look into it in the morning). I think the discovery related code is ready for testing, maybe with the minimalist peer-pad @jimpick?
I wrote a simple chat app to try it out, and it looks like the peers are connecting and setting up membership gossip within a couple of seconds (this is using the default rendezvous server at ws-star1.par.dwebops.pub). Watch for the Connected message at the bottom right:
https://youtu.be/Au239dGo2TA

FYI to see the log messages for web-socket-star, floodsub, and peer-star-app discovery paste this into the browser console and refresh:
localStorage.debug = 'libp2p:floodsub,libp2p:floodsub:*,peer-star:discovery,peer-star:discovery:*,libp2p:websocket-star,libp2p:websocket-star:*'

@pgte there are quite a lot of changes here, let me know if you would like to code review in real time and I can talk you through it :)

@dirkmc thanks, I may take you up on that some time later!
I pulled your branch locally and rebased from latest master and did a fresh install.
When running the tests, sometimes I'm getting an error on test/replication.spec.js:
$ npx aegir test -t node -f test/replication.spec.js
[...]
 1) replication
       can stop pinner:
     Error: Timeout of 30000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (/Users/pedroteixeira/projects/ipfs/peer-star/peer-star-app/test/replication.spec.js)

  2) replication
       peers dont list pinner any longer after pinner stopped:

      AssertionError: expected 1 to equal 0
      + expected - actual

      -1
      +0

      at collaborations.forEach (test/replication.spec.js:112:103)
      at Array.forEach (<anonymous>)
      at Context.it (test/replication.spec.js:112:20)

I did a bit of digging around and I found out that, when the tests fail, sometimes the connection from the nodes to the pinner is not closed after pinner.stop(). Do you have any clues on why this might be happening?

@pgte it seems like at some stage in the past libp2p must have called AppTransport.close() but it no longer seems to do that (it calls close on the listeners, not the transport itself)
I can listen for when libp2p calls discovery.close(), but it seems like at that point libp2p has already stopped, so it's not possible to disconnect.
I'm digging around in the libp2p code trying to work out how we can make it wait till we've closed out connections before shutting down.

@dirkmc @pgte how much have you spoken with the (js)libp2p folks about this? I know service discovery is something they're interested in and it feels like we're basically using pubsub to implement our own discovery service because it's not done there yet. Maybe there's some way for us to help them out and ensure the libp2p discovery covers the peer-star-app use cases.

@dirkmc thank you!
@aschmahmann there's a spec for a rendezvous protocol being designed here: https://github.com/libp2p/specs/pull/56 . Is this what you were referring to?

I looked into this more over the weekend. If I add a random delay before dialing, the replication test passes.
My theory is that when libp2p-switch gets an incoming connection for a peer at the same time as it is dialing that same peer, it gets confused and loses track of some connections. When it shuts down, it closes all connections for a peer, but I believe it misses some of the connections, which is why the protocol pull stream never detects the connection ending. Tomorrow I'll try to write a test case against libp2p-switch that consistently fails.

@pgte Yes, thanks.

I created a test case to demonstrate the issue at https://github.com/ipfs-shipyard/peer-star-app/pull/199

@dirkmc I dug into this a bit and I think you're right, apparently there's some problem with libp2p connection management. This is evident through your new test9:
Doing app.stop() triggers ipfs.stop() , which should stop the discovery and transports, which should then disconnect all.
While I did some digging I think I found a problem in this package and the way that it handles connections: when you do collaboration.stop(), the existing outbound connections were not being terminated, which then results in libp2p maintaining connections to other nodes indefinitely.
If we fix this, our tests run consistently, simply because stopping an app will stop all the collaborations, which will then terminate all the collaboration-specific connections.
Because I'd like to review these fixes with you, I suggest we continue this in another PR that joins these contributions to the connection management issues: https://github.com/ipfs-shipyard/peer-star-app/pull/200

authors: aschmahmann dirkmc pgte

repo: ipfs-shipyard/peer-star-app


text:
TypeScript support

I'd love to use this library in my Typescript-based project. But the project has no type definition files and there don't seem to be any in the Definitely Typed repository either.
It looks like https://github.com/ipinfo/node has type definitions. How about adding them here too?

Yeah the Nodejs SDK has it because it's in Typescript already, but this one is in plain JS. We'll add something, though it'll take some time, or if you can contribute we'll accept a PR.

Latest version has TS support.

authors: UmanShahzad jjeff

repo: ipinfo/node-express


text:
🛑 NowBoarding (tokyo) is down

In d91e60e, NowBoarding (tokyo) (https://tokyo.nowboarding.club/) was down:

HTTP code: 502
Response time: 584 ms

Resolved: NowBoarding (tokyo) is back up in 41e6072 after 8 minutes.

repo: iplanwebsites/up


text:
🛑 NowBoarding (tokyo) is down

In 36a2267, NowBoarding (tokyo) (https://tokyo.nowboarding.club/) was down:

HTTP code: 0
Response time: 0 ms

Resolved: NowBoarding (tokyo) is back up in 8d2cc99 after 11 minutes.


text:
🛑 NowBoarding (tokyo) is down

In f33180a, NowBoarding (tokyo) (https://tokyo.nowboarding.club/) was down:

HTTP code: 0
Response time: 0 ms

Resolved: NowBoarding (tokyo) is back up in 636800f after 1 hour, 10 minutes.


text:
🛑 NowBoarding (tokyo) is down

In e469418, NowBoarding (tokyo) (https://tokyo.nowboarding.club/) was down:

HTTP code: 0
Response time: 0 ms

Resolved: NowBoarding (tokyo) is back up in 7c7ba96 after 9 minutes.


text:
NGmerge or fastqc shoud be used in quality control before alignment

Hi,
It's really interesting tool to identify circle DNA from DNAseq data. But, recently, we are considered with the variety of circle DNA length and length of insenrtion of reads, which would influence the usage of quanlity control tools. These library sizes of circle DNA were like ATACseq results, the inseration length of DNA fragments could be less than 50bp or more than 150bp.  And in ATACseq quality control, we were suggested to use NGmerge, which could keep the short reads reminding, to cut adapters and filter reads,  instead of fastqc (or other trim tools in standard pipeline) which will remove shorted reads directly.
So, we also want to know whether trim tools we need to use to finish quality control before alignment.
Thanks!

Another question;
should we implemented picard tools to remove duplicates reads caused by PCR after bwa alignment?

Dear Pangxueyu233,
I am out of the office this days. I will get back to you at the end of  the week
Sorry for the inconvinience.
Best,
Iñigo

Dear @pangxueyu233,
I am back.
Regarding:

So, we also want to know whether trim tools we need to use to finish quality control before alignment.

You can use any standard trimming software to remove adapters on the reads. Regarding more aggresive trimming such as removing low quality sequences or too short sequences, I think that this is not strickly necessary. Circle-Map incorporates sequencing errors and sequence length (implicitly) into the probabilistic model. Long story short, I think you are fine with removing the adapters.
You should not use any software that merges paired-reads. This is not supported.
Regarding:

should we implemented picard tools to remove duplicates reads caused by PCR after bwa alignment?

This depends on the biological question you want to answer. If you are interested in a qualitative analysis where you only detect the circle keeping PCR duplicates is fine. If you want to do any quantitative analysis you should remove duplicates.
Best,
Inigo

Thanks, I will follow your suggestion.
And one more quenstion, whether this tool could identify ecDNA (Extrachromosomal DNA) not only eccDNA？
And are there any tools to visualise Circle-Map results? As you known, if we constructed a circle sequence, we need to show our results like a plasmid map to visualise stucture information including gene body overlapped in circle sequence and genes position in circles structure.

Hi,
Regarding:

And one more quenstion, whether this tool could identify ecDNA (Extrachromosomal DNA) not only eccDNA？

Circle-Map is designed to detect any type of circular DNA. If you want to reconstruct the amplicon structure take a look at https://github.com/virajbdeshpande/AmpliconArchitect
Regarding:

And are there any tools to visualise Circle-Map results? As you known, if we constructed a circle sequence, we need to show our results like a plasmid map to visualise stucture information including gene body overlapped in circle sequence and genes position in circles structure.

@RAHenriksen from our lab has generated beautiful Circos plots of circles. Take a look at it.
Best,
Inigo

Thanks for immediately replying. And one more thing I want to make sure about the results, each rows of files meant they could fomed an eccDNA individually, or combination of them could formed an eccDNA ?

Each row should be an individual eccDNA. If some of eccDNA formed a complex amplicon they will be reported as indendent lines. That is limitation of Circle-Map. You can use AmpliconArchitect to solve those.

repo: iprada/Circle-Map


text:
Add: Sundom TV

Channel Name
Sundom TV
Native Name (optional)
No response
Network (optional)
No response
Country
FI
Subdivision (optional)
FI-12
City (optional)
Sundom
Broadcast Area
s/FI-12
Languages
swe
Categories (optional)
No response
NSFW
FALSE
Launched (optional)
No response
Closed (optional)
No response
Replaced By (optional)
No response
Website (optional)
https://951.fi/
Logo
https://951.fi/wp-content/uploads/2022/05/cropped-stv_3D_951_3D.png
Notes
Stream URL
https://www.youtube.com/user/Sundomtv/live

Added in https://github.com/iptv-org/database/commit/72b602bf90fed5152836b866a78652ae950c1fc4

authors: freearhey las-pen

repo: iptv-org/database

license: Unlicense


text:
Edit: Lolo TV [LV]

Channel ID (required)
LoloTV.lv
Channel Name
No response
Alternative Names
No response
Network
No response
Owners
No response
Country
No response
Subdivision
No response
City
No response
Broadcast Area
No response
Languages
No response
Categories
No response
NSFW
None
Launched
No response
Closed
No response
Replaced By
No response
Website
No response
Logo
https://imgur.com/hfXoJIY
Notes
No response

Duplicate of Pingviins.lv. Thanks for reminding me

Closing, creating another PR for channel removal.


text:
Eignung von Server-Side Events prüfen

A.F. schlägt Server-Side-Event vor für die Event-driven Kommunikation der Testleiter-Konsole:
Dies ausprobieren und überdenken.
Siehe:
Beispielanwendungen:
Client: https://github.com/fleckandreas/ng-sse-example
Server: https://github.com/fleckandreas/slim-sse-example

PHP ist grundsätzlich für so etwas ungeeignet. Man kann durch einen endlos Loop die Verbindung ewig offen halten, wie es im SSE_Beispiel gemacht wird.. Das hat aber zur Folge, dass alle 3 Sekunden (oder was immer) eine Datenbank-Abfrage stattfindet. Mit Event-Driven hat das nichts zu tun und spart auch keine Ressourcen gegenüber eine simplen Poll-getriebenen Architektur ist nur schwerer umzusetzen und zu testen :/
Man könnte ein in.memory-datenbank anschließen, führt aber zur doppelten Datenhaltung und einen Extremen Überbau.
Das würde sich nur lohnen, wenn man den offenen Stream irgendwie zwsichenspeichern kann und bei push wieder hervorholt.

repo: iqb-berlin/testcenter-iqb-ng


text:
running the example FileNotFoundError appeared

When I install the irl_control but when I run the example, it shows me the following error:
Traceback (most recent call last):   File "/home/lif/irl_control/build/lib/irl_control/examples/gain_test.py", line 180, in <module>     demo = GainTest(robot_config_file="default_xyz.yaml", scene_file="gain_test_scene.xml")   File "/home/lif/irl_control/build/lib/irl_control/examples/gain_test.py", line 22, in __init__     super().__init__(robot_config_file, scene_file)   File "/usr/local/lib/python3.10/dist-packages/irl_control-1.0.0-py3.10.egg/irl_control/mujoco_app.py", line 15, in __init__     with open(robot_config_path, 'r') as file: FileNotFoundError: [Errno 2] No such file or directory: '/usr/local/lib/python3.10/dist-packages/irl_control-1.0.0-py3.10.egg/irl_control/robot_configs/default_xyz.yaml'
Please tell me how to avoid this error, thank you.

It may not be a good solution, but it can be a makeshift.
you can edit the variable "main_dir" at mujoco_app.py line 13 and insertion_task.py line 137. change the variable from os.path.dirname(irl_control.file) to the exact path where you can find yaml files.

Hello, sorry for the late reply here, but I will close this issue as it looks like this was due to not installing the package with pip properly. If you install it as an editable installation (using "pip install -e .") it should avoid this problem.


text:
Integrate doctor appointments and history

Integrete doctor appointments and history
https://user-images.githubusercontent.com/24855641/188983968-cb985a41-cf1d-477d-bcd9-23a256b89a33.mp4

@Jeetu303 Please approve the video.

While an appointment is requested and is in process. it should not show the time. Remove the time slot field from appointments (in the process).
When a requested appointment is rejected, it should show only rejected not the timing. Only Approved appointments should show timing... Neither rejected nor in process, the appointment should show timing.
All other things are fine @ashutoshc8101

@Jeetu303 Please re-review

Great All good
Go ahead

repo: iraapp/ira


text:
Implement Handler for Fn(Mut) + Send + Sync

Unboxed closures are here to stay, and mostly stable now. I don't think there are any issues with this.

This appears to already be done: https://github.com/iron/iron/blob/master/src/middleware.rs#L279
Is there something else that this doesn't cover?

Ah. The docs just need rebuilt then. :smile:

repo: iron/iron


text:
Additional Custom API Activities

There are more Activities in Teams now that are not listed in the presence state list on the Configure Custom API tab.
Seemingly missing:

InAConferenceCall
Inactive
OffWork
OutOfOffice
PresenceUnknown
UrgentInterruptionsOnly

List of current states on https://docs.microsoft.com/en-us/graph/api/resources/presence?view=graph-rest-beta
If these could be added for the next release, that would be great.

If this should be a feature request, apologies in advance.

Two different things here Availability vs Activity. PresenceLight at this time does not change lights based on Activities. I would welcome a PR to add such functionality, but would need to ensure that users had the option of using one or the other and can control light color accordingly.

Ah, got it. Thanks.

repo: isaacrlevin/PresenceLight


text:
question about implementation details

Hi, I like graceful-fs an am thinking to use it in http://npmjs.com/package/fildes I have a couple of questions and hope it is ok to ask here.

Retrying the queue, happens on some of the 'shimed' methods like close, closeSync. Does that work in multiple child processes that each try to write many files, as I suppose if one child process gets too many file descriptors error and the other process then calls close, the first isn't informed that something happend?

What does the polyfills.js and legacy-streams.js do? and what impact has it if I only want to use Node.js 4.x

what is require('constants'), seems to be something Node.js internal is that correct? Is there any documentation on it somewhere?
Thanks and I hope you don't mind me asking here.

To partly answer my own question

flags can also be a number as documented by open(2); commonly used constants are available from require('constants'). On Windows, flags are translated to their equivalent ones where applicable, e.g. O_WRONLY to FILE_GENERIC_WRITE, or O_EXCL|O_CREAT to CREATE_NEW, as accepted by CreateFileW.

https://nodejs.org/api/fs.html#fs_fs_open_path_flags_mode_callback

File descriptors are per-process.  So, you typically don't open a file descriptor in one process and close it in another.  This can be done by sending the file descriptors via a sendmsg syscall, but that's rare.  Even if you do sendmsg file descriptors between processes, the actual limits that cause EMFILE and ENFILE errors are per-process, so they'll requeue the opens in that process when the error is encountered.

polyfills.js is polyfills for things that are broken in some versions of node or which don't exist on some operating systems.  For example, lchmod is turned into a no-op instead of a nonexistent function.  legacy-streams.js is there to fix streams in node v0.8.

I don't know if there are any documentation pages for require('constants') but it's been there for a very long time.

I don't know if there are any documentation pages for require('constants') but it's been there for a very long time.

Hope it’s okay to comment here! There is no documentation on it, and while it’s likely going to keep being around for a long time, the long-term direction in which Node is headed is replacing it by explicit constants properties of modules, e.g. fs.constants, which are available and documented now (in Node >= v6.3.0). See https://github.com/nodejs/node/pull/6534 for a bit of context on that, if you’re interested.

@addaleax Cool.  Since it's only used for older versions (0.6 and before, I believe?) probably we can just add a guard around the require().

I think var constants = fs.constants || require('constants') would be safe to use here, if that’s what you’re suggesting?

Or even just try { var constants = require('constants') } catch (e) { constants = {} } would probably work.  I believe it only uses it when the version is below 0.6.5 or something hella old like that.

Hm – patchLutimes seems to use it for the lutimes polyfill, and I can’t seem to find fs.lutimes on any standard Node.js fs module?
I doubt it matters much. :D

thank you both

authors: addaleax isaacs thisconnect

repo: isaacs/node-graceful-fs

license: isc


text:
Custom keymaps configuration option

I usually like to map "q" to close the current buffer for various files such as http, diffview, etc... diffview has a configuration option for keymaps which uses vim.keymap.set under the hood. For others that don't provide this kind of option, I resort to using a filetype autocmd to set said keymap. Unfortunately that doesn't seem possible because of how the file type is being set in this plugin
vim.cmd('noautocmd silent! set filetype=gitgraph')

Would it be possible to add a keymaps config option like diffview does or at least not use 'noautocmd' if it's not necessary?

Can you show me more specifically what you mean?

Here's my current lazy.nvim configuration for sindrets/diffview.nvim:
return {
  "sindrets/diffview.nvim",
  keys = {
    { "<leader>gd", "<cmd>DiffviewOpen<CR>", desc = "Diff View", mode = "n" },
    { "<leader>gf", "<cmd>DiffviewFileHistory %<CR>", desc = "File History (This)", mode = "n" },
    { "<leader>gF", "<cmd>DiffviewFileHistory<CR>", desc = "File History (All)", mode = "n" },
  },
  opts = {
    keymaps = {
      view = {
        q = "<cmd>DiffviewClose<CR>",
      },
    },
  },
}

in the opts table you will see one of the keys is called "keymaps". This key allows me to set keymaps to be applied in the diffview windows. In this specific example, I'm setting "q" to "DiffviewClose" to close the diffview tab. I would like a similar option in gitgraph.
Alternatively, if a plugin doesn't provide this kind of option I usually do something like this:
local cmd = vim.api.nvim_create_autocmd

-- close some filetypes with <q>
cmd("FileType", {
  group = ugroup("close_with_q"),
  pattern = {
    "gitgraph",
  },
  callback = function(event)
    ---@type string|function
     vim.bo[event.buf].buflisted = false
     vim.keymap.set("n", "q", "<cmd>close<cr>", { buffer = event.buf, silent = true })
  end,
})

This doesn't work with gitgraph because the gitgraph draw command doesn't trigger autocmds because of the use of "noautocmd" here (gitgraph.lua:1821):
vim.cmd('noautocmd silent! set filetype=gitgraph')

I hope this clears it up for you.

Thanks, that was very clear, I'm not the author of this vim.cmd('noautocmd silent! set filetype=gitgraph') that would be @letieu  I believe, ... I wonder why he added the noautocmd 🤔  would be nice to get an explanation, perhaps you already know @eslam-allam ? I would like the answer to this for curiosity and learnings sake.
I'll consider just adding a close command that you could bind in whatever way you like @eslam-allam , in the meantime I'll wait a bit for a reply on the purpose or need for or reasons for wanting to have noautocmd 🤔

we can delete noautocmd, I just copy it from mini.starter plugin, but I think in out case, we don't need it.
if use noautocmd , we can't listen the file type with autocmd.
I was created a new PR, please take a look.
https://github.com/isakbm/gitgraph.nvim/pull/16

authors: eslam-allam isakbm letieu


text:
Issue parser

Parser issue fixed as mentioned by you

gg @Aadityagoel15

repo: ishaanbedi/woyage


text:
Kotlin Gradle plugin error

#34
updated build with the latest Kotlin and Gradle plugin versions.
This pull request is for issue  #34  " Kotlin Gradle plugin error "
This works fine now and can be used in the Flutter projects.

@ishaquehassan  Please check this

@ishaquehassan When you are going to create a release including latest fixes?


text:
The README without instructions

Details
The README does not have steps or any other documentation. Of course I understand this is the intention of the project for the target it looks for, but README still missing

It'll be expanded upon when time permits

Closed by #216

authors: achetronic ishioni

repo: ishioni/homelab-ops


text:
tsdoc supports

https://github.com/microsoft/tsdoc

no plan for now

repo: islishude/wallet-rpc


text:
🛑 COBELEN.isolucion.co is down

In 37f6b36, COBELEN.isolucion.co (https://COBELEN.isolucion.co) was down:

HTTP code: 500
Response time: 8386 ms

Resolved: COBELEN.isolucion.co is back up in 7dde203.

repo: isolucionco/EstadoIsolucionHosting


text:
add initializer uninstall cmd in setup

as titled

Jenkins job istio.github.io/presubmit passed

Jenkins job istio.github.io/presubmit passed

Jenkins job istio.github.io/presubmit passed

authors: istio-testing linsun


text:
go test fails in pkg/log

mjog-macbookpro:log mjog$ go version
go version go1.9.2 darwin/amd64
mjog-macbookpro:log mjog$ go test -v .
=== RUN   TestBasic
=== RUN   TestBasic/0
=== RUN   TestBasic/1
=== RUN   TestBasic/2
=== RUN   TestBasic/3
=== RUN   TestBasic/4
=== RUN   TestBasic/5
=== RUN   TestBasic/6
=== RUN   TestBasic/7
=== RUN   TestBasic/8
=== RUN   TestBasic/9
=== RUN   TestBasic/10
=== RUN   TestBasic/11
=== RUN   TestBasic/12
=== RUN   TestBasic/13
=== RUN   TestBasic/14
=== RUN   TestBasic/15
=== RUN   TestBasic/16
=== RUN   TestBasic/17
=== RUN   TestBasic/18
=== RUN   TestBasic/19
=== RUN   TestBasic/20
=== RUN   TestBasic/21
2017-12-18 10:59:29.583602515 -0800 PST m=+0.013352556 write error: write /var/folders/j_/fq241wf558v_n2ph_dtmf06m00cbnf/T/log_test190309110: file already closed
--- FAIL: TestBasic (0.01s)
    --- FAIL: TestBasic/0 (0.00s)
    	log_test.go:100: Got '2017-12-18T10:59:29.571-0800	debug	Hello', expected a match with '.*Z	debug	Hello'
    --- FAIL: TestBasic/1 (0.00s)
    	log_test.go:100: Got '2017-12-18T10:59:29.572-0800	debug	Hello', expected a match with '.*Z	debug	Hello'
    --- FAIL: TestBasic/2 (0.00s)
    	log_test.go:100: Got '2017-12-18T10:59:29.573-0800	debug	Hello', expected a match with '.*Z	debug	Hello'
    --- FAIL: TestBasic/3 (0.00s)
    	log_test.go:100: Got '2017-12-18T10:59:29.573-0800	debug	Hello', expected a match with '.*Z	debug	Hello'
    --- FAIL: TestBasic/4 (0.00s)
    	log_test.go:100: Got '2017-12-18T10:59:29.573-0800	info	Hello', expected a match with '.*Z	info	Hello'
    --- FAIL: TestBasic/5 (0.00s)
    	log_test.go:100: Got '2017-12-18T10:59:29.574-0800	info	Hello', expected a match with '.*Z	info	Hello'
    --- FAIL: TestBasic/6 (0.00s)
    	log_test.go:100: Got '2017-12-18T10:59:29.575-0800	info	Hello', expected a match with '.*Z	info	Hello'
    --- FAIL: TestBasic/7 (0.00s)
    	log_test.go:100: Got '2017-12-18T10:59:29.576-0800	info	Hello', expected a match with '.*Z	info	Hello'
    --- FAIL: TestBasic/8 (0.00s)
    	log_test.go:100: Got '2017-12-18T10:59:29.576-0800	warn	Hello', expected a match with '.*Z	warn	Hello'
    --- FAIL: TestBasic/9 (0.00s)
    	log_test.go:100: Got '2017-12-18T10:59:29.577-0800	warn	Hello', expected a match with '.*Z	warn	Hello'
    --- FAIL: TestBasic/10 (0.00s)
    	log_test.go:100: Got '2017-12-18T10:59:29.577-0800	warn	Hello', expected a match with '.*Z	warn	Hello'
    --- FAIL: TestBasic/11 (0.00s)
    	log_test.go:100: Got '2017-12-18T10:59:29.578-0800	warn	Hello', expected a match with '.*Z	warn	Hello'
    --- FAIL: TestBasic/12 (0.00s)
    	log_test.go:100: Got '2017-12-18T10:59:29.578-0800	error	Hello', expected a match with '.*Z	error	Hello'
    --- FAIL: TestBasic/13 (0.00s)
    	log_test.go:100: Got '2017-12-18T10:59:29.579-0800	error	Hello', expected a match with '.*Z	error	Hello'
    --- FAIL: TestBasic/14 (0.00s)
    	log_test.go:100: Got '2017-12-18T10:59:29.579-0800	error	Hello', expected a match with '.*Z	error	Hello'
    --- FAIL: TestBasic/15 (0.00s)
    	log_test.go:100: Got '2017-12-18T10:59:29.580-0800	error	Hello', expected a match with '.*Z	error	Hello'
    --- FAIL: TestBasic/16 (0.00s)
    	log_test.go:100: Got '2017-12-18T10:59:29.580-0800	debug	Hello	{"key": "value"}', expected a match with '.*Z	debug	Hello	{"key": "value"}'
    --- FAIL: TestBasic/17 (0.00s)
    	log_test.go:100: Got '2017-12-18T10:59:29.581-0800	debug	log/log_test.go:65	Hello', expected a match with '.*Z	debug	log/log_test.go:.*	Hello'
    --- FAIL: TestBasic/18 (0.00s)
    	log_test.go:100: Got '{"level":"debug","time":"2017-12-18T10:59:29.581-0800","caller":"log/log_test.go:67","msg":"Hello","stack":"istio.io/istio/pkg/log.Debug\n\t/Users/mjog/GOHOME/src/istio.io/istio/pkg/log/log.go:152\nistio.io/istio/pkg/log.TestBasic.func19\n\t/Users/mjog/GOHOME/src/istio.io/istio/pkg/log/log_test.go:67\nistio.io/istio/pkg/log.TestBasic.func23.1\n\t/Users/mjog/GOHOME/src/istio.io/istio/pkg/log/log_test.go:91\nistio.io/istio/pkg/log.captureStdout\n\t/Users/mjog/GOHOME/src/istio.io/istio/pkg/log/log_test.go:218\nistio.io/istio/pkg/log.TestBasic.func23\n\t/Users/mjog/GOHOME/src/istio.io/istio/pkg/log/log_test.go:79\ntesting.tRunner\n\t/usr/local/Cellar/go/1.9.2/libexec/src/testing/testing.go:746"}', expected a match with '{"level":"debug","time":".*T.*Z","caller":"log/log_test.go:.*","msg":"Hello","stack":".*"}'
    --- FAIL: TestBasic/19 (0.00s)
    	log_test.go:100: Got '{"level":"info","time":"2017-12-18T10:59:29.582-0800","caller":"log/log_test.go:69","msg":"Hello","stack":"istio.io/istio/pkg/log.Info\n\t/Users/mjog/GOHOME/src/istio.io/istio/pkg/log/log.go:239\nistio.io/istio/pkg/log.TestBasic.func20\n\t/Users/mjog/GOHOME/src/istio.io/istio/pkg/log/log_test.go:69\nistio.io/istio/pkg/log.TestBasic.func23.1\n\t/Users/mjog/GOHOME/src/istio.io/istio/pkg/log/log_test.go:91\nistio.io/istio/pkg/log.captureStdout\n\t/Users/mjog/GOHOME/src/istio.io/istio/pkg/log/log_test.go:218\nistio.io/istio/pkg/log.TestBasic.func23\n\t/Users/mjog/GOHOME/src/istio.io/istio/pkg/log/log_test.go:79\ntesting.tRunner\n\t/usr/local/Cellar/go/1.9.2/libexec/src/testing/testing.go:746"}', expected a match with '{"level":"info","time":".*T.*Z","caller":"log/log_test.go:.*","msg":"Hello","stack":".*"}'
    --- FAIL: TestBasic/20 (0.00s)
    	log_test.go:100: Got '{"level":"warn","time":"2017-12-18T10:59:29.582-0800","caller":"log/log_test.go:71","msg":"Hello","stack":"istio.io/istio/pkg/log.Warn\n\t/Users/mjog/GOHOME/src/istio.io/istio/pkg/log/log.go:210\nistio.io/istio/pkg/log.TestBasic.func21\n\t/Users/mjog/GOHOME/src/istio.io/istio/pkg/log/log_test.go:71\nistio.io/istio/pkg/log.TestBasic.func23.1\n\t/Users/mjog/GOHOME/src/istio.io/istio/pkg/log/log_test.go:91\nistio.io/istio/pkg/log.captureStdout\n\t/Users/mjog/GOHOME/src/istio.io/istio/pkg/log/log_test.go:218\nistio.io/istio/pkg/log.TestBasic.func23\n\t/Users/mjog/GOHOME/src/istio.io/istio/pkg/log/log_test.go:79\ntesting.tRunner\n\t/usr/local/Cellar/go/1.9.2/libexec/src/testing/testing.go:746"}', expected a match with '{"level":"warn","time":".*T.*Z","caller":"log/log_test.go:.*","msg":"Hello","stack":".*"}'
    --- FAIL: TestBasic/21 (0.00s)
    	log_test.go:100: Got '{"level":"error","time":"2017-12-18T10:59:29.583-0800","caller":"log/log_test.go:73","msg":"Hello","stack":"istio.io/istio/pkg/log.Error\n\t/Users/mjog/GOHOME/src/istio.io/istio/pkg/log/log.go:181\nistio.io/istio/pkg/log.TestBasic.func22\n\t/Users/mjog/GOHOME/src/istio.io/istio/pkg/log/log_test.go:73\nistio.io/istio/pkg/log.TestBasic.func23.1\n\t/Users/mjog/GOHOME/src/istio.io/istio/pkg/log/log_test.go:91\nistio.io/istio/pkg/log.captureStdout\n\t/Users/mjog/GOHOME/src/istio.io/istio/pkg/log/log_test.go:218\nistio.io/istio/pkg/log.TestBasic.func23\n\t/Users/mjog/GOHOME/src/istio.io/istio/pkg/log/log_test.go:79\ntesting.tRunner\n\t/usr/local/Cellar/go/1.9.2/libexec/src/testing/testing.go:746"}', expected a match with '{"level":"error","time":".*T.*Z","caller":"log/log_test.go:.*","msg":"Hello","stack":".*"}'
=== RUN   TestEnabled
=== RUN   TestEnabled/0
=== RUN   TestEnabled/1
=== RUN   TestEnabled/2
=== RUN   TestEnabled/3
=== RUN   TestEnabled/4
--- PASS: TestEnabled (0.00s)
    --- PASS: TestEnabled/0 (0.00s)
    --- PASS: TestEnabled/1 (0.00s)
    --- PASS: TestEnabled/2 (0.00s)
    --- PASS: TestEnabled/3 (0.00s)
    --- PASS: TestEnabled/4 (0.00s)
=== RUN   TestOddballs
--- PASS: TestOddballs (0.00s)
=== RUN   TestCapture
=== RUN   TestCapture/0
=== RUN   TestCapture/1
=== RUN   TestCapture/2
--- FAIL: TestCapture (0.00s)
    --- FAIL: TestCapture/0 (0.00s)
    	log_test.go:202: Got '2017-12-18T10:59:29.585-0800	info	log/log_test.go:218	Hello', expecting to match '.*Z	info	log/log_test.go:.*	Hello'
    --- FAIL: TestCapture/1 (0.00s)
    	log_test.go:202: Got '2017-12-18T10:59:29.585-0800	info	log/log_test.go:186	There', expecting to match '.*Z	info	log/log_test.go:.*	There'
    --- FAIL: TestCapture/2 (0.00s)
    	log_test.go:202: Got '2017-12-18T10:59:29.585-0800	info	log/log_test.go:189	Goodbye', expecting to match '.*Z	info	log/log_test.go:.*	Goodbye'
=== RUN   TestOpts
=== RUN   TestOpts/0
=== RUN   TestOpts/1
=== RUN   TestOpts/2
=== RUN   TestOpts/3
=== RUN   TestOpts/4
=== RUN   TestOpts/5
=== RUN   TestOpts/6
=== RUN   TestOpts/7
=== RUN   TestOpts/8
=== RUN   TestOpts/9
=== RUN   TestOpts/10
=== RUN   TestOpts/11
=== RUN   TestOpts/12
--- PASS: TestOpts (0.00s)
    --- PASS: TestOpts/0 (0.00s)
    --- PASS: TestOpts/1 (0.00s)
    --- PASS: TestOpts/2 (0.00s)
    --- PASS: TestOpts/3 (0.00s)
    --- PASS: TestOpts/4 (0.00s)
    --- PASS: TestOpts/5 (0.00s)
    --- PASS: TestOpts/6 (0.00s)
    --- PASS: TestOpts/7 (0.00s)
    --- PASS: TestOpts/8 (0.00s)
    --- PASS: TestOpts/9 (0.00s)
    --- PASS: TestOpts/10 (0.00s)
    --- PASS: TestOpts/11 (0.00s)
    --- PASS: TestOpts/12 (0.00s)
=== RUN   TestLevel
=== RUN   TestLevel/0
=== RUN   TestLevel/1
=== RUN   TestLevel/2
=== RUN   TestLevel/3
=== RUN   TestLevel/4
--- PASS: TestLevel (0.00s)
    --- PASS: TestLevel/0 (0.00s)
    --- PASS: TestLevel/1 (0.00s)
    --- PASS: TestLevel/2 (0.00s)
    --- PASS: TestLevel/3 (0.00s)
    --- PASS: TestLevel/4 (0.00s)
FAIL
exit status 1
FAIL	istio.io/istio/pkg/log	0.049s

Wow, blaze test works but go test doesn't... Strange.
On Mon, Dec 18, 2017 at 11:12 AM, mandarjog notifications@github.com
wrote:

Assigned #2227 https://github.com/istio/istio/issues/2227 to @geeknoid
https://github.com/geeknoid.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/istio/istio/issues/2227#event-1392757952, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AVucHaycgBHhlTscLVH-zd-x2XDhthsMks5tBrk2gaJpZM4RF8Bh
.

And it fails in GoLand too.
Somehow, when running the tests from bazel, date & time formatting includes
timezone info, but running go test or GoLand, the timezone info isn't
output.
On Mon, Dec 18, 2017 at 11:57 AM, Martin Taillefer mtail@google.com wrote:

Wow, blaze test works but go test doesn't... Strange.
On Mon, Dec 18, 2017 at 11:12 AM, mandarjog notifications@github.com
wrote:

Assigned #2227 https://github.com/istio/istio/issues/2227 to @geeknoid
https://github.com/geeknoid.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/istio/istio/issues/2227#event-1392757952, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AVucHaycgBHhlTscLVH-zd-x2XDhthsMks5tBrk2gaJpZM4RF8Bh
.

Bazel overrides the entire environment config (for reproducibility).
Why does the test depend on timezone?
On Mon, Dec 18, 2017 at 12:04 PM Martin Taillefer notifications@github.com
wrote:

And it fails in GoLand too.
Somehow, when running the tests from bazel, date & time formatting includes
timezone info, but running go test or GoLand, the timezone info isn't
output.
On Mon, Dec 18, 2017 at 11:57 AM, Martin Taillefer mtail@google.com
wrote:

Wow, blaze test works but go test doesn't... Strange.
On Mon, Dec 18, 2017 at 11:12 AM, mandarjog notifications@github.com
wrote:

Assigned #2227 https://github.com/istio/istio/issues/2227 to
@geeknoid
https://github.com/geeknoid.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/istio/istio/issues/2227#event-1392757952, or mute
the thread
<
https://github.com/notifications/unsubscribe-auth/AVucHaycgBHhlTscLVH-zd-x2XDhthsMks5tBrk2gaJpZM4RF8Bh

.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/istio/istio/issues/2227#issuecomment-352542431, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AJGIxlPsQZQCzivjugVSa_NDE2twO2Ydks5tBsU9gaJpZM4RF8Bh
.

The test ensures that logs look a consistent way. Turns out something is
being affected by the environment that wasn't supposed to. So the test
actually found a real problem. Now I just got to figure out what's
happening.
On Mon, Dec 18, 2017 at 12:07 PM, Kuat notifications@github.com wrote:

Bazel overrides the entire environment config (for reproducibility).
Why does the test depend on timezone?
On Mon, Dec 18, 2017 at 12:04 PM Martin Taillefer <
notifications@github.com>
wrote:

And it fails in GoLand too.
Somehow, when running the tests from bazel, date & time formatting
includes
timezone info, but running go test or GoLand, the timezone info isn't
output.
On Mon, Dec 18, 2017 at 11:57 AM, Martin Taillefer mtail@google.com
wrote:

Wow, blaze test works but go test doesn't... Strange.
On Mon, Dec 18, 2017 at 11:12 AM, mandarjog notifications@github.com
wrote:

Assigned #2227 https://github.com/istio/istio/issues/2227 to
@geeknoid
https://github.com/geeknoid.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/istio/istio/issues/2227#event-1392757952, or
mute
the thread
<
https://github.com/notifications/unsubscribe-
auth/AVucHaycgBHhlTscLVH-zd-x2XDhthsMks5tBrk2gaJpZM4RF8Bh

.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/istio/istio/issues/2227#issuecomment-352542431, or
mute
the thread
<https://github.com/notifications/unsubscribe-
auth/AJGIxlPsQZQCzivjugVSa_NDE2twO2Ydks5tBsU9gaJpZM4RF8Bh>
.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/istio/istio/issues/2227#issuecomment-352543168, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AVucHXEdD-Yj_ZtcdaySy5hUF9gl1ncoks5tBsX-gaJpZM4RF8Bh
.

I think this is a bug in the golang time libs.
For a given time format used with the time.Format function, the output string looks different when running in Bazel vs. running from go test. When running in bazel, the timezone is set to UTC whereas in go test it's PST (in my case).
I'm not sure I can make the time formats be consistent at this point, so I might just need to relax the test to tolerate the variations in format.

I've got a PR out to fix this. I forced all timestamps to UTC and that made things reliable.

Forcing UTC works, but you may want to add a test for a specific timezone if you want to check for that.

authors: geeknoid kyessenov mandarjog

repo: istio/istio


text:
istio-policy always crash

I use  istioctl manifest apply --set profile=demo  to install istio 1.4.10 on my kubernetes 1.13.
After install, the pod Istio-policy alway crash. plesase see the following image

the pod event show as following image

can you tell my how to solve this problem, thank you

@kengan istio 1.4 has reached end of life.
Please try it on a supported version of Istio. (1.5 +) at this time.
Please also include logs from the istio-policy pods. Thanks.

authors: kengan mandarjog


text:
mixer: "remove all this stuff by istio 0.5" in cmd/mixs/cmd/server.go

@ldemailly found a comment in mixer/cmd/mixs/cmd/server.go:
	// TODO: Remove all this stuff by the 0.5 release (don't forget all associated YAML templates and any other uses of these options in the code
	// base & docs)
	var dummy string
	var dummy2 uint16
	var dummy3 uint
	serverCmd.PersistentFlags().StringVarP(&sa.ConfigStoreURL, "configStore2URL", "", "", "deprecated")
	serverCmd.PersistentFlags().StringVarP(&dummy, "serviceConfigFile", "", "", "deprecated")
	serverCmd.PersistentFlags().StringVarP(&dummy, "globalConfigFile", "", "", "deprecated")
	serverCmd.PersistentFlags().Uint16VarP(&dummy2, "configAPIPort", "", 0, "deprecated")
	serverCmd.PersistentFlags().UintVarP(&dummy3, "configFetchInterval", "", 0, "deprecated")
	_ = serverCmd.PersistentFlags().MarkDeprecated("configStore2URL", "")
	_ = serverCmd.PersistentFlags().MarkDeprecated("serviceConfigFile", "")
	_ = serverCmd.PersistentFlags().MarkDeprecated("globalConfigFile", "")
	_ = serverCmd.PersistentFlags().MarkDeprecated("configAPIPort", "")
	_ = serverCmd.PersistentFlags().MarkDeprecated("configFetchInterval", "")
	_ = serverCmd.PersistentFlags().MarkHidden("configStore2URL")
	_ = serverCmd.PersistentFlags().MarkHidden("serviceConfigFile")
	_ = serverCmd.PersistentFlags().MarkHidden("globalConfigFile")
	_ = serverCmd.PersistentFlags().MarkHidden("configAPIPort")
	_ = serverCmd.PersistentFlags().MarkHidden("configFetchInterval")

https://github.com/istio/istio/blob/master/mixer/cmd/mixs/cmd/server.go#L76
Can we just remove them now?

This comment no longer exists. I think this was done.

replaced by
https://github.com/istio/istio/blob/23d2f39c506deaae382994154b3ad19f6e5ee932/pkg/log/options.go#L384  ;-)

authors: douglas-reid jmuk ldemailly


text:
double entry in accesslog when accesslogging is added via envoyfilter

Bug Description
I want to add custom access log for a specific namespace but i am seeing 2 entries in accesslog for each request. I want to see only one entry with new access log format specified in the filter. I have tried REPLACE and ADD as well but same issue
`apiVersion: networking.istio.io/v1alpha3
kind: EnvoyFilter
metadata:
name: custom-access-log
namespace: {{ .namespace }}
spec:
configPatches:

applyTo: NETWORK_FILTER
match:
context: ANY
listener:
filterChain:
filter:
name: envoy.filters.network.http_connection_manager
patch:
operation: MERGE
value:
typed_config:
'@type': type.googleapis.com/envoy.extensions.filters.network.http_connection_manager.v3.HttpConnectionManager
access_log:
- name: envoy.file_access_log`

Version
client version: 1.11.4
control plane version: 1.12.5
data plane version: 1.12.5 (30 proxies)

Additional Information
No response

this's an known limitation of protobuf merge.
can you try to use Telemetry API, I think it's available in v1.12.

authors: pitiwari zirain


text:
Routing with public domain names does not work

Is this the right place to submit this?

[X] This is not a security vulnerability or a crashing bug
[X] This is not a question about how to use Istio

Bug Description
Preamble:
Got most of the input from my colleague @PaoloC68, so he may have more infos.
We deployed istio with Helm. Helm chart version is 1.19.1, we have deployed the charts base, istiod and gateway.
Setup:
We need to route traffic from one pod to another to authenticate. The authentication address is a publicly resolvable domain name "auth.example.info". However, our container logs show, that we cannot connect to the respective pod. We tried many different configurations without any luck.
Issue Encountered
I am unable to establish a TLS connection to an external service that is part of the same Kubernetes cluster. The issue occurs only when I try to connect from a Pod within the cluster to the external service via its public DNS. This results in a TLS handshake error. The issue doesn't manifest when connecting from outside the cluster.
Expectation
I expect to be able to establish a TLS connection to the service both from within and outside the cluster seamlessly, without encountering a TLS handshake error.
Steps Taken

Validated the certificates and they are not the issue.
Tried direct queries using openssl and curl commands, which also failed.
Checked Istio's ServiceEntry and Gateway configurations to ensure they are set up correctly.

ServiceEntry with both MESH_EXTERNAL and MESH_INTERNAL (like described here)

Used istioctl analyze and found no significant issues.
Attempted to bypass Istio's sidecar for outbound traffic using the annotation traffic.sidecar.istio.io/excludeOutboundIPRanges: "0.0.0.0/0" but to no avail.
DNS lookup using nslookup works fine; it's just the actual connection that fails.

Logs & Error Messages
I get a Connection reset by peer error when I try to connect.
OpenSSL SSL_connect: Connection reset by peer in connection to auth.example.info:443

Version
$ istioctl version
no ready Istio pods in "istio-system"
1.19.1

$ istioctl version -i istio
client version: 1.19.1
control plane version: 1.19.1
data plane version: 1.19.1 (18 proxies)

$ kubectl version --short
Client Version: v1.26.3
Server Version: v1.27.4

Additional Information
istio_config_dump.txt
bug-report.tar.gz
apiVersion: networking.istio.io/v1beta1
kind: VirtualService
metadata:
  name: authentik-virtual-service
  namespace: istio
spec:
  hosts:
    - "auth.example.info"
    - "auth.example.net"
    - "auth.example.com"
  gateways:
  - wildcardgateway
  http:
  - match:
    - uri:
        prefix: /
    route:
    - destination:
        host: authentik.authentik.svc.cluster.local
        port:
          number: 80
---
apiVersion: networking.istio.io/v1beta1
kind: ServiceEntry
metadata:
  name: svc-redirect-auth
  namespace: istio
spec:
  endpoints:
   - address: "xxx.xxx.xxx.xxx" # The Ingress Gateway LB
   - address: "xxx.xxx.xxx.xxx" # The Ingress Gateway LB
  hosts:
    - auth.example.com
    - auth.example.info
    - auth.example.net
  location: MESH_INTERNAL
  ports:
    - name: https
      number: 443
      protocol: HTTPS
  resolution: DNS
#  workloadSelector:
#    labels:
#      app: authentik
---
apiVersion: networking.istio.io/v1beta1
kind: ServiceEntry
metadata:
  name: svc-redirect-backend
  namespace: istio
spec:
  endpoints:
   - address: "xxx.xxx.xxx.xxx" # The Ingress Gateway LB
   - address: "xxx.xxx.xxx.xxx" # The Ingress Gateway LB
  hosts:
    - backend.example.com
    - backend.example.info
    - backend.example.net
  location: MESH_INTERNAL
  ports:
    - name: https
      number: 443
      protocol: HTTPS
  resolution: DNS
#  workloadSelector:
#    labels:
#      app: django
---
apiVersion: networking.istio.io/v1beta1
kind: Gateway
metadata:
  name: wildcardgateway
  namespace: istio
spec:
  selector:
    istio: gateway
  servers:
  - port:
      number: 80
      name: http
      protocol: HTTP
    hosts:
    - "example.info"
    - "example.net"
    - "example.com"
    - "*.example.info"
    - "*.example.net"
    - "*.example.com"
    tls:
      httpsRedirect: true
  - port:
      number: 443
      name: https
      protocol: HTTPS
    hosts:
    - "example.info"
    - "example.net"
    - "example.com"
    - "*.example.info"
    - "*.example.net"
    - "*.example.com"
    tls:
      mode: SIMPLE
      credentialName: wildcard-example-tls
---
apiVersion: v1
kind: Service
metadata:
  name: additional-gateway
  namespace: istio
spec:
  type: LoadBalancer
  ports:
    - name: status-port
      protocol: TCP
      port: 15021
      targetPort: 15021
    - name: http2
      protocol: TCP
      port: 80
      targetPort: 80
    - name: https
      protocol: TCP
      port: 443
      targetPort: 443
  selector:
    app: gateway
    istio: gateway

I was able to solve this issue by adding the following annotation to the LoadBalancer:
service.beta.kubernetes.io/scw-loadbalancer-use-hostname: "true"

For the record:
We run our kubernetes cluster in Scaleway.


text:
SNI routing by egressgateway stopped working with Istio Auth

Describe the bug
SNI routing by egressgateway stopped working in https://gcsweb.istio.io/gcs/istio-prerelease/daily-build/release-1.0-20180723-09-15/ with Istio Auth
Expected behavior
Directing HTTPS traffic thru the egressgateway, as described in https://preliminary.istio.io/docs/tasks/traffic-management/egress-gateway/#direct-https-traffic-through-an-egress-gateway, must work.
Steps to reproduce the bug
Follow the steps in https://preliminary.istio.io/docs/tasks/traffic-management/egress-gateway/#direct-https-traffic-through-an-egress-gateway. In step 5, error code 35 will be returned.
Run istioctl proxy-config listeners $(kubectl get pod -l istio=egressgateway -n istio-system -o jsonpath='{.items[0].metadata.name}') -n istio-system. You will get Error: no listeners found
Version
https://gcsweb.istio.io/gcs/istio-prerelease/daily-build/release-1.0-20180723-09-15/
Is Istio Auth enabled or not?
Yes
Environment
Kubernetes

The bug does not exist in https://github.com/istio/istio/releases/tag/1.0.0-snapshot.1

Your gateway spec doesn't have SNI in the tls section

Gateway TLS options do not have SNI.

Split the virtual service into two parts. Tls route for mesh to egress. And then tcp route for egress gateway. All under same virtual service

To specify the requirements:

Allow egress access to edition.cnn.com and to www.google.com, forbid access to anything else:

cat <<EOF | istioctl create -f -
    apiVersion: networking.istio.io/v1alpha3
    kind: ServiceEntry
    metadata:
      name: cnn
    spec:
      hosts:
      - edition.cnn.com
      ports:
      - number: 443
        name: tls
        protocol: TLS
      resolution: DNS
EOF

@rshriram

And then tcp route for egress gateway. All under same virtual service

but how the tcp route will route by the hostname? I need to distinguish edition.cnn.com and www.google.com.

The configuration 3a in https://github.com/istio/istio/issues/7361#issuecomment-407720960 works, closing the issue.

Trying with two virtual services combined:
cat <<EOF | istioctl create -f -
apiVersion: networking.istio.io/v1alpha3
kind: ServiceEntry
metadata:
  name: cnn
spec:
  hosts:
  - edition.cnn.com
  ports:
  - number: 443
    name: tls
    protocol: TLS
  resolution: DNS
---
apiVersion: networking.istio.io/v1alpha3
kind: ServiceEntry
metadata:
  name: google
spec:
  hosts:
  - www.google.com
  ports:
  - number: 443
    name: tls
    protocol: TLS
  resolution: DNS
---
  apiVersion: networking.istio.io/v1alpha3
  kind: Gateway
  metadata:
    name: istio-egressgateway
  spec:
    selector:
      istio: egressgateway
    servers:
    - port:
        number: 443
        name: tls-cnn
        protocol: TLS
      hosts:
      - edition.cnn.com
      tls:
        mode: MUTUAL
        serverCertificate: /etc/certs/cert-chain.pem
        privateKey: /etc/certs/key.pem
        caCertificates: /etc/certs/root-cert.pem
    - port:
        number: 443
        name: tls-google
        protocol: TLS
      hosts:
      - www.google.com
      tls:
        mode: MUTUAL
        serverCertificate: /etc/certs/cert-chain.pem
        privateKey: /etc/certs/key.pem
        caCertificates: /etc/certs/root-cert.pem
---
apiVersion: networking.istio.io/v1alpha3
kind: VirtualService
metadata:
  name: cnn-to-egressgateway
spec:
  hosts:
  - edition.cnn.com
  gateways:
  - mesh
  tls:
  - match:
    - gateways:
      - mesh
      port: 443
      sni_hosts:
      - edition.cnn.com
    route:
    - destination:
        host: istio-egressgateway.istio-system.svc.cluster.local
        subset: cnn
        port:
          number: 443
      weight: 100
    tcp:
  - match:
    - gateways:
      - istio-egressgateway
      port: 443
    route:
    - destination:
        host: edition.cnn.com
        port:
          number: 443
      weight: 100
---
apiVersion: networking.istio.io/v1alpha3
kind: VirtualService
metadata:
  name: google-to-egressgateway
spec:
  hosts:
  - www.google.com
  gateways:
  - mesh
  tls:
  - match:
    - gateways:
      - mesh
      port: 443
      sni_hosts:
      - www.google.com
    route:
    - destination:
        host: istio-egressgateway.istio-system.svc.cluster.local
        subset: google
        port:
          number: 443
      weight: 100
  tcp:
  - match:
    - gateways:
      - istio-egressgateway
      port: 443
    route:
    - destination:
        host: www.google.com
        port:
          number: 443
      weight: 100
---
apiVersion: networking.istio.io/v1alpha3
kind: DestinationRule
metadata:
   name: set-sni-for-egressgateway
spec:
  host: istio-egressgateway.istio-system.svc.cluster.local
  subsets:
      - name: cnn
        trafficPolicy:
          loadBalancer:
            simple: ROUND_ROBIN
          portLevelSettings:
          - port:
              number: 443
            tls:
              mode: ISTIO_MUTUAL
              sni: edition.cnn.com
      - name: google
        trafficPolicy:
          loadBalancer:
            simple: ROUND_ROBIN
          portLevelSettings:
          - port:
              number: 443
            tls:
              mode: ISTIO_MUTUAL
              sni: www.google.com
EOF

test:
kubectl exec -it $(kubectl get pod -l app=sleep -o jsonpath={.items..metadata.name}) -c sleep -- curl -sL -o /dev/null -w "%{http_code}\n" https://edition.cnn.com; kubectl exec -it $(kubectl get pod -l app=sleep -o jsonpath={.items..metadata.name}) -c sleep -- curl -sL -o /dev/null -w "%{http_code}\n" https://www.google.com ; kubectl exec -it $(kubectl get pod -l app=sleep -o jsonpath={.items..metadata.name}) -c sleep -- curl -sL -o /dev/null -w "%{http_code}\n" https://www.wikipedia.org

the expected output:
200
200
000

verify that the traffic went thru the egress gateway:
kubectl exec -it $(kubectl get pod -l istio=egressgateway -n istio-system -o jsonpath='{.items[0].metadata.name}') -c egressgateway -n istio-system -- curl -s localhost:15000/stats | grep edition.cnn.com.upstream_cx_total ; kubectl exec -it $(kubectl get pod -l istio=egressgateway -n istio-system -o jsonpath='{.items[0].metadata.name}') -c egressgateway -n istio-system -- curl -s localhost:15000/stats | grep www.google.com.upstream_cx_total

expected output:
cluster.outbound|443||edition.cnn.com.upstream_cx_total: 1
cluster.outbound|443||www.google.com.upstream_cx_total: 1

cleanup:
istioctl delete serviceentry cnn google
istioctl delete virtualservice cnn-to-egressgateway google-to-egressgateway
istioctl delete gateway istio-egressgateway
istioctl delete destinationrule set-sni-for-egressgateway

@vadimeisenbergibm trying to set up egress rules for external services similar to https://github.com/istio/istio/issues/7361#issuecomment-407720960 (Direct the egress traffic thru the egress gateway with disabled mtls) but that generates pilot outbound listener conflict
"pilot_conflict_outbound_listener_tcp_over_current_tcp": {
            "0.0.0.0:443": {
                "proxy": "reviews-v2-65fbdc9f88-c8dqj.digital-services",
                "message": "Listener=0.0.0.0:443 AcceptedTCP=www.google.com RejectedTCP=edition.cnn.com TCPServices=1"
            }
        },

Any suggestion to resolve that conflict?
Istio version 1.4.4

authors: anoopwebs rshriram vadimeisenbergibm


text:
Add support for metadata constraints in RBAC

This adds support for mapping RBAC constraints with keys in the a[b] format to Envoy's filter metadata matcher.

I've made a few changes as described below.

This matcher logic will only work for keys beginning with envoy.filters. and of format envoy.filters.a.b[c].
If the value is described as [value], then a list matcher is created.
If the value is of format value, then a string matcher is created.

@venilnoronha: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-k8s-tests.sh
689bf76be0c2a7cab71c0bf43169201e048b88d4
link
/test istio-integ-k8s-tests

prow/istio-pilot-multicluster-e2e.sh
3746b91f149834959cc5578f416479fdb21e57ca
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@venilnoronha: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-multicluster-e2e.sh
83a0e83d5ec6ea3d3abd0303a801e0e76e4872d9
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@liminw I can update the documentation on istio.io.

@venilnoronha: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-multicluster-e2e.sh
83a0e83d5ec6ea3d3abd0303a801e0e76e4872d9
link
/test istio-pilot-multicluster-e2e

prow/istio-integ-k8s-tests.sh
5858330d2d5d19d73155a8e557631720374c6874
link
/test istio-integ-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@venilnoronha: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-k8s-tests.sh
5858330d2d5d19d73155a8e557631720374c6874
link
/test istio-integ-k8s-tests

prow/istio-pilot-multicluster-e2e.sh
5858330d2d5d19d73155a8e557631720374c6874
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@venilnoronha When updating the doc, please make sure it's an experimental feature that could be changed at any time without prior notice (no backward compatibility support), customer should use it at their own risk.
/lgtm

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: venilnoronha, yangminzhu
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

pilot/pkg/networking/plugin/authz/OWNERS [yangminzhu]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yangminzhu sounds good, thanks!

authors: istio-testing venilnoronha yangminzhu


text:
Auto bind to services for Sidecar listeners with specific ports

fixes #12536
cc @howardjohn @mdgreenfield - could you check to see if it resolves the above issue?

@rshriram I confirmed this fix works, for my tests setup at least. And my test setup was based on @mdgreenfield so should be good.
The test failures look real though
Thanks for fixing this

/lgtm

authors: howardjohn rshriram


text:
Remove AllowOrigin from route since it is deprecated in istio API

This PR removes the AllowOrigin and relies completely on AllowOrigins from route since it is deprecated in istio API.

@Nino-K: PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Nino-K: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-mixer-k8s-tests_istio
5905434873c6855df6774f60dfc62c1c21774a23
link
/test integ-mixer-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Nino-K: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-mixer-k8s-tests_istio
5905434873c6855df6774f60dfc62c1c21774a23
link
/test integ-mixer-k8s-tests_istio

integ-galley-k8s-tests_istio
5905434873c6855df6774f60dfc62c1c21774a23
link
/test integ-galley-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Nino-K: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-mixer-k8s-tests_istio
5905434873c6855df6774f60dfc62c1c21774a23
link
/test integ-mixer-k8s-tests_istio

integ-galley-k8s-tests_istio
5905434873c6855df6774f60dfc62c1c21774a23
link
/test integ-galley-k8s-tests_istio

integ-telemetry-k8s-tests_istio
5905434873c6855df6774f60dfc62c1c21774a23
link
/test integ-telemetry-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Nino-K: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-mixer-k8s-tests_istio
5905434873c6855df6774f60dfc62c1c21774a23
link
/test integ-mixer-k8s-tests_istio

integ-galley-k8s-tests_istio
5905434873c6855df6774f60dfc62c1c21774a23
link
/test integ-galley-k8s-tests_istio

integ-telemetry-k8s-tests_istio
5905434873c6855df6774f60dfc62c1c21774a23
link
/test integ-telemetry-k8s-tests_istio

lint_istio
5905434873c6855df6774f60dfc62c1c21774a23
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Nino-K: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-mixer-k8s-tests_istio
5905434873c6855df6774f60dfc62c1c21774a23
link
/test integ-mixer-k8s-tests_istio

integ-galley-k8s-tests_istio
5905434873c6855df6774f60dfc62c1c21774a23
link
/test integ-galley-k8s-tests_istio

integ-telemetry-k8s-tests_istio
5905434873c6855df6774f60dfc62c1c21774a23
link
/test integ-telemetry-k8s-tests_istio

lint_istio
5905434873c6855df6774f60dfc62c1c21774a23
link
/test lint_istio

integ-pilot-k8s-tests_istio
5905434873c6855df6774f60dfc62c1c21774a23
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Nino-K: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-mixer-k8s-tests_istio
5905434873c6855df6774f60dfc62c1c21774a23
link
/test integ-mixer-k8s-tests_istio

integ-galley-k8s-tests_istio
5905434873c6855df6774f60dfc62c1c21774a23
link
/test integ-galley-k8s-tests_istio

integ-telemetry-k8s-tests_istio
5905434873c6855df6774f60dfc62c1c21774a23
link
/test integ-telemetry-k8s-tests_istio

lint_istio
5905434873c6855df6774f60dfc62c1c21774a23
link
/test lint_istio

integ-pilot-k8s-tests_istio
5905434873c6855df6774f60dfc62c1c21774a23
link
/test integ-pilot-k8s-tests_istio

unit-tests_istio
5905434873c6855df6774f60dfc62c1c21774a23
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Nino-K: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-mixer-k8s-tests_istio
5905434873c6855df6774f60dfc62c1c21774a23
link
/test integ-mixer-k8s-tests_istio

integ-galley-k8s-tests_istio
5905434873c6855df6774f60dfc62c1c21774a23
link
/test integ-galley-k8s-tests_istio

integ-telemetry-k8s-tests_istio
5905434873c6855df6774f60dfc62c1c21774a23
link
/test integ-telemetry-k8s-tests_istio

lint_istio
5905434873c6855df6774f60dfc62c1c21774a23
link
/test lint_istio

integ-pilot-k8s-tests_istio
5905434873c6855df6774f60dfc62c1c21774a23
link
/test integ-pilot-k8s-tests_istio

unit-tests_istio
5905434873c6855df6774f60dfc62c1c21774a23
link
/test unit-tests_istio

release-test_istio
5905434873c6855df6774f60dfc62c1c21774a23
link
/test release-test_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Nino-K: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-mixer-k8s-tests_istio
5905434873c6855df6774f60dfc62c1c21774a23
link
/test integ-mixer-k8s-tests_istio

integ-galley-k8s-tests_istio
5905434873c6855df6774f60dfc62c1c21774a23
link
/test integ-galley-k8s-tests_istio

integ-telemetry-k8s-tests_istio
5905434873c6855df6774f60dfc62c1c21774a23
link
/test integ-telemetry-k8s-tests_istio

lint_istio
5905434873c6855df6774f60dfc62c1c21774a23
link
/test lint_istio

integ-pilot-k8s-tests_istio
5905434873c6855df6774f60dfc62c1c21774a23
link
/test integ-pilot-k8s-tests_istio

unit-tests_istio
5905434873c6855df6774f60dfc62c1c21774a23
link
/test unit-tests_istio

release-test_istio
5905434873c6855df6774f60dfc62c1c21774a23
link
/test release-test_istio

integ-conformance-k8s-tests_istio
5905434873c6855df6774f60dfc62c1c21774a23
link
/test integ-conformance-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Nino-K: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-mixer-k8s-tests_istio
5905434873c6855df6774f60dfc62c1c21774a23
link
/test integ-mixer-k8s-tests_istio

integ-galley-k8s-tests_istio
5905434873c6855df6774f60dfc62c1c21774a23
link
/test integ-galley-k8s-tests_istio

integ-telemetry-k8s-tests_istio
5905434873c6855df6774f60dfc62c1c21774a23
link
/test integ-telemetry-k8s-tests_istio

lint_istio
5905434873c6855df6774f60dfc62c1c21774a23
link
/test lint_istio

integ-pilot-k8s-tests_istio
5905434873c6855df6774f60dfc62c1c21774a23
link
/test integ-pilot-k8s-tests_istio

unit-tests_istio
5905434873c6855df6774f60dfc62c1c21774a23
link
/test unit-tests_istio

release-test_istio
5905434873c6855df6774f60dfc62c1c21774a23
link
/test release-test_istio

integ-conformance-k8s-tests_istio
5905434873c6855df6774f60dfc62c1c21774a23
link
/test integ-conformance-k8s-tests_istio

integ-security-k8s-tests_istio
5905434873c6855df6774f60dfc62c1c21774a23
link
/test integ-security-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Nino-K: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-mixer-k8s-tests_istio
5905434873c6855df6774f60dfc62c1c21774a23
link
/test integ-mixer-k8s-tests_istio

integ-galley-k8s-tests_istio
5905434873c6855df6774f60dfc62c1c21774a23
link
/test integ-galley-k8s-tests_istio

integ-telemetry-k8s-tests_istio
5905434873c6855df6774f60dfc62c1c21774a23
link
/test integ-telemetry-k8s-tests_istio

lint_istio
5905434873c6855df6774f60dfc62c1c21774a23
link
/test lint_istio

integ-pilot-k8s-tests_istio
5905434873c6855df6774f60dfc62c1c21774a23
link
/test integ-pilot-k8s-tests_istio

unit-tests_istio
5905434873c6855df6774f60dfc62c1c21774a23
link
/test unit-tests_istio

release-test_istio
5905434873c6855df6774f60dfc62c1c21774a23
link
/test release-test_istio

integ-conformance-k8s-tests_istio
5905434873c6855df6774f60dfc62c1c21774a23
link
/test integ-conformance-k8s-tests_istio

integ-security-k8s-tests_istio
5905434873c6855df6774f60dfc62c1c21774a23
link
/test integ-security-k8s-tests_istio

gencheck_istio
5905434873c6855df6774f60dfc62c1c21774a23
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Nino-K: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-mixer-k8s-tests_istio
5905434873c6855df6774f60dfc62c1c21774a23
link
/test integ-mixer-k8s-tests_istio

integ-galley-k8s-tests_istio
5905434873c6855df6774f60dfc62c1c21774a23
link
/test integ-galley-k8s-tests_istio

integ-telemetry-k8s-tests_istio
5905434873c6855df6774f60dfc62c1c21774a23
link
/test integ-telemetry-k8s-tests_istio

lint_istio
5905434873c6855df6774f60dfc62c1c21774a23
link
/test lint_istio

integ-pilot-k8s-tests_istio
5905434873c6855df6774f60dfc62c1c21774a23
link
/test integ-pilot-k8s-tests_istio

unit-tests_istio
5905434873c6855df6774f60dfc62c1c21774a23
link
/test unit-tests_istio

release-test_istio
5905434873c6855df6774f60dfc62c1c21774a23
link
/test release-test_istio

integ-conformance-k8s-tests_istio
5905434873c6855df6774f60dfc62c1c21774a23
link
/test integ-conformance-k8s-tests_istio

integ-security-k8s-tests_istio
5905434873c6855df6774f60dfc62c1c21774a23
link
/test integ-security-k8s-tests_istio

gencheck_istio
5905434873c6855df6774f60dfc62c1c21774a23
link
/test gencheck_istio

integ-distroless-k8s-tests_istio
5905434873c6855df6774f60dfc62c1c21774a23
link
/test integ-distroless-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Nino-K: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-mixer-k8s-tests_istio
5905434873c6855df6774f60dfc62c1c21774a23
link
/test integ-mixer-k8s-tests_istio

integ-galley-k8s-tests_istio
5905434873c6855df6774f60dfc62c1c21774a23
link
/test integ-galley-k8s-tests_istio

integ-telemetry-k8s-tests_istio
5905434873c6855df6774f60dfc62c1c21774a23
link
/test integ-telemetry-k8s-tests_istio

lint_istio
5905434873c6855df6774f60dfc62c1c21774a23
link
/test lint_istio

integ-pilot-k8s-tests_istio
5905434873c6855df6774f60dfc62c1c21774a23
link
/test integ-pilot-k8s-tests_istio

unit-tests_istio
5905434873c6855df6774f60dfc62c1c21774a23
link
/test unit-tests_istio

release-test_istio
5905434873c6855df6774f60dfc62c1c21774a23
link
/test release-test_istio

integ-conformance-k8s-tests_istio
5905434873c6855df6774f60dfc62c1c21774a23
link
/test integ-conformance-k8s-tests_istio

integ-security-k8s-tests_istio
5905434873c6855df6774f60dfc62c1c21774a23
link
/test integ-security-k8s-tests_istio

gencheck_istio
5905434873c6855df6774f60dfc62c1c21774a23
link
/test gencheck_istio

integ-distroless-k8s-tests_istio
5905434873c6855df6774f60dfc62c1c21774a23
link
/test integ-distroless-k8s-tests_istio

integ-local-tests_istio
5905434873c6855df6774f60dfc62c1c21774a23
link
/test integ-local-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Nino-K: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-mixer-k8s-tests_istio
5905434873c6855df6774f60dfc62c1c21774a23
link
/test integ-mixer-k8s-tests_istio

integ-galley-k8s-tests_istio
5905434873c6855df6774f60dfc62c1c21774a23
link
/test integ-galley-k8s-tests_istio

integ-telemetry-k8s-tests_istio
5905434873c6855df6774f60dfc62c1c21774a23
link
/test integ-telemetry-k8s-tests_istio

lint_istio
5905434873c6855df6774f60dfc62c1c21774a23
link
/test lint_istio

integ-pilot-k8s-tests_istio
5905434873c6855df6774f60dfc62c1c21774a23
link
/test integ-pilot-k8s-tests_istio

unit-tests_istio
5905434873c6855df6774f60dfc62c1c21774a23
link
/test unit-tests_istio

release-test_istio
5905434873c6855df6774f60dfc62c1c21774a23
link
/test release-test_istio

integ-conformance-k8s-tests_istio
5905434873c6855df6774f60dfc62c1c21774a23
link
/test integ-conformance-k8s-tests_istio

integ-security-k8s-tests_istio
5905434873c6855df6774f60dfc62c1c21774a23
link
/test integ-security-k8s-tests_istio

gencheck_istio
5905434873c6855df6774f60dfc62c1c21774a23
link
/test gencheck_istio

integ-distroless-k8s-tests_istio
5905434873c6855df6774f60dfc62c1c21774a23
link
/test integ-distroless-k8s-tests_istio

integ-local-tests_istio
5905434873c6855df6774f60dfc62c1c21774a23
link
/test integ-local-tests_istio

integ-multicluster-k8s-tests_istio
5905434873c6855df6774f60dfc62c1c21774a23
link
/test integ-multicluster-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

authors: Nino-K istio-testing


text:
Improve the Mixer perf testing framework.

Add support for writing tests directly against runtime.Dispatcher interface.
Make the perf test execution type (i.e inprocess/coprocess/dispatcher) a flag.
Rename perf.Env to perf.Settings, both to avoid conflict with adapter.Env, and to put additional, generic settings.

This depends on: https://github.com/istio/istio/pull/2323 Also renames dispatcherForTesting => dispatcher.

@ozevren: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
36828a433cc33cb22ac4428a9ce14e582d465cb3
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test istio-presubmit

@ozevren: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
36828a433cc33cb22ac4428a9ce14e582d465cb3
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test istio-presubmit

@ozevren: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
36828a433cc33cb22ac4428a9ce14e582d465cb3
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test istio-presubmit

@ozevren: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
36828a433cc33cb22ac4428a9ce14e582d465cb3
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ozevren: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
90862cfbb45961efdbb5a322987f720bec43bc2a
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Accomodated most feedback. PTAL.

/test istio-presubmit

authors: istio-testing ozevren


text:
Fix deprecation message typos in meshConfig validation

Succeeding PR of #25033 for fixing the concurrency and envoyAccessLogService deprecation messages.

Hi @namco1992. Thanks for your PR.
I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

/ok-to-test

authors: istio-testing namco1992 nschhina


text:
Fix bad wasm remote load test flaky.

fixes #30593
[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
Pull Request Attributes
Please check any characteristics that apply to this pull request.
[ ] Does not have any changes that may affect Istio users.

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

/test integ-telemetry-mc-k8s-tests_istio

/test integ-telemetry-mc-k8s-tests_istio

@bianpengyuan: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
46857b71bfcb46877b54713f182737896e8524e7
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@istio/wg-policies-and-telemetry-maintainers ptal, thanks!

authors: bianpengyuan istio-testing