text:
PowerShell Script v2 - Task group parameter is not being converted to environment variable

Environment

Server - Azure Pipelines
Agent - Hosted
Task - PowerShell 2.140.0

Issue Description
I have an inline PowerShell script inside of a task group. In the PowerShell script I want to use a task group parameter value however it is not being converted correctly to the environment variable.
Expected Result:
The environment variable contains the correct value that is defined in the task group parameter. In my screenshots below I expect Get-ChildItem Env:MyFooFooEnvVar to return I want to use to use this value in my PowerShell script
Actual Result
The task group parameter is not converted.

My release definition

My Task Group

Note: I'm just using a Visual Studio Build task to generate the task group parameter $(FooFoo).

Note

Release variables values are correctly converted to the environment variable in the PowerShell script.

This issue is stale because it has been open for a year with no activity. Remove the stale label or comment on the issue otherwise this will be closed in 5 days

source: gharchive/issue

authors: leantk oishii-code

license: MIT

license_type: permissive

license_source: github-api


text:
Remove versions upper-bounds limits for dependency packages

Changes
This PR follows the move from the Azure SDK Core Libraries for Python to not have upper-bound version limits for the dependency packages.
Rationale
Having upper-bound version limits for the dependency packages prevent potential and unexpected breaking changes.
However, it also prevents our customers from accessing the latest versions of these dependencies, potentially blocking them from applying security patches or integrating our libraries with other tools.
Since the azure-quantum package will eventually need to support newer versions as they become available (to apply security patches or unblocking customers, it's better to use the latest dependencies' versions by default and set an upper-bound version limit as a (temporary) exception / workaround.
Tests
Our unit tests cover 77% of our code in general, but the most used scenarios and features have a code coverage of 90+%.
The CI, Release and E2E test pipelines will always install the latest dependencies and we can quickly identify breaking changes.
In case of breaking changes
There are two potential types of breaking changes:

The latest version of a dependency package has a breaking change in their surface API or behavior that breaks part of the azure-quantum functionality.
The latest versions of two different packages depend on a common dependency and each of these packages impose version limits that are incompatible (for example, PackageA depends on PackageC>=1.0,<1.2 and PackageB depends on PackageC>=1.3 ). This will make the azure-quantum package un-installable because it's impossible to resolve the dependency graph.

Mitigation 1

Find which dependency packages are creating the issue.
Identify the latest previous version that does not contain the issue.
Create an issue in the azure-quantum-python with the workaround (ask customer to install the specific versions of dependency packages that does not cause the issue before installing the azure-quantum package)
Create issues in the repositories of the offending dependency packages (and link them to our issue)

Mitigation 2

After Mitigation 1
Set upper-limits in the appropriate requirements.txt files
Release a new patch for the azure-quantum package
Update our issue created in Mitigation 1 with the workaround to install the latest azure-quantum package (which will basically do Mitigation 1 during the azure-quantum package installation).

@vxfield , @xinyi-joffre, @ArthurKamalov
As discussed offline we're going to keep upper bounds for dependency packages for now to avoid introducing breaking changes for customers. We could re-consider doing this at a later point.
Closing this PR as agreed.

source: gharchive/pull-request

authors: kikomiss vxfield

repo: microsoft/azure-quantum-python


text:
@deprecated createModelViewDialog - ambiguous hint

Azure Data Studio Version:

Version: 1.29.0 (system setup)
Commit: 0f5cfdc2c8c2433028842e16dc5ac1a65da24292
Date: 2021-05-15T01:12:11.112Z
VS Code: 1.53.0
Electron: 11.2.2
Chrome: 87.0.4280.141
Node.js: 12.18.3
V8: 8.7.220.31-electron.0
OS: Windows_NT x64 10.0.19043
Steps to Reproduce:

Create a new dialog extension
Open the main.ts

The deprecated message is ambiguous: createModelViewDialog is deprecated use createModelViewDialog
        /**
         * @deprecated please use the method createModelViewDialog(title: string, dialogName?: string, width?: DialogWidth) instead.
         * Create a dialog with the given title
         * @param title The title of the dialog, displayed at the top
         * @param isWide Indicates whether the dialog is wide or normal
         */
        export function createModelViewDialog(title: string, dialogName?: string, isWide?: boolean): Dialog;

Question
createModelViewDialog is deprecated or not?

That version of the function is (with the isWide parameter) - you should use the version that takes a width?: DialogWidth parameter. It provides all the same functionality and more.

No createModelViewDialog(title: string, dialogName?: string, width?: DialogWidth) with the width parameter inside the d.ts

A solid point - forgot that one is still in proposed : https://github.com/microsoft/azuredatastudio/blob/main/src/sql/azdata.proposed.d.ts#L648
We're not going to remove the old function anytime soon so feel free to continue using it until we get the new one into the stable API.
@alanrenmsft - Note to us that we probably shouldn't be deprecating stuff in the main API until we have a replacement there - it's pretty confusing if people aren't familiar with the proposed API and given our usual time frame for actually removing stuff waiting a bit longer for it to make it into stable isn't a huge deal.

repo: microsoft/azuredatastudio


text:
Export Notebook as SQL file has no query editor toolbar

Azure Data Studio Version: 1.31 rc

Steps to Reproduce:
https://user-images.githubusercontent.com/23462877/125516982-9c3c3880-7259-4ece-81bf-48f2536034a1.mov

@Charles-Gagnon do you have any context here? Could this be related to what was previously editor replacement?

Almost positively, I'll investigate.

Thanks @Charles-Gagnon


text:
Tries to run a notebook everytime I start azuredatastudio

Issue Type: Bug
1.Run the notebook DynamicBPCheck until crashes
2. Restart azuredatastudio  It tries to open the notebook.  The windows times out and I can close it.
If I want to use azuredatastudio I must open another window while waiting for this window running the failed notebook to timeout.  If I do not I can't open a new window that does not try to run the notebook that crashed.
It happens with the extensions disabled or enabled.
Azure Data Studio version: azuredatastudio 1.32.0 (4a45ba7cf20dd4129f1a08e5e776dfb33e3d1d1e, 2021-08-16T18:08:28.086Z)
OS version: Windows_NT x64 10.0.19042

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-8700 CPU @ 3.20GHz (12 x 3192)

GPU Status
2d_canvas: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onoop_rasterization: enabledopengl: enabled_onrasterization: enabledskia_renderer: enabled_onvideo_decode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabled

Load (avg)
undefined

Memory (System)
31.83GB (20.66GB free)

Process Argv

Screen Reader
no

VM
0%

Extensions (1)

Extension
Author (truncated)
Version

profiler
Mic
0.11.0

Hi @LanceHMCH, can you provide the DynamicBPCheck notebook so I can repro this specific issue.

I no longer have a copy of this notebook.
I have uninstalled an reinstalled the program and it still tries to run this notebook.
Are there instructions to completely remove azure data studio and it configuration files?
How does a new install still reference that notebook?
Lance Harra
Database Administrator
@.***
Educationhttps://education.mchdata.com/data/education  |  Healthcarehttps://education.mchdata.com/data/healthcare  |  Governmenthttps://www.mchdata.com/data/government  |  Religionhttps://education.mchdata.com/data/religion
800-776-6373  |  mchdata.comhttps://www.mchdata.com/
Stay up to date as K-12 policies continue to evolve
with our exclusive COVID-19 Map and Data Resourcehttps://www.mchdata.com/covid19/schoolclosings.
From: Vasu Bhog @.>
Sent: Tuesday, November 2, 2021 5:35 PM
To: microsoft/azuredatastudio @.>
Cc: Lance Harra @.>; Mention @.>
Subject: Re: [microsoft/azuredatastudio] Tries to run a notebook everytime I start azuredatastudio (Issue #17433)
EXTERNAL: This email originated from outside of MCH. Do not click any links or open any attachments unless you trust the sender and know the content is safe.
Hi @LanceHMCHhttps://github.com/LanceHMCH, can you provide the DynamicBPCheck notebook so I can repro this specific issue.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/microsoft/azuredatastudio/issues/17433#issuecomment-958299107, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AMOW5A4SUGMACY3CRGB6QTTUKBYS7ANCNFSM5GOJZXRA.
Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

Hello, if I understand the problem correctly. No matter if you uninstall ADS and reinstall it will open this previous notebook again. This is expected behavior if you do not close the notebook before closing ADS. If you are unable to close the notebook via the traditional method of clicking the x (shown below):

then you can use the command palette (ctrl+shift+p) and search for View: Close All Editors. This will ensure that it closes all notebooks/editors that are currently open.
Once that is done, please close ADS and see if the issue remains.

@LanceHMCH Sorry to hear you're having issues, could you try these steps to clear the backup cache? That may be what's causing

Close all instances of ADS
Browse to %appdata%/azuredatastudio
Delete the Backups folder (it just contains hot reload backups for editors so shouldn't affect any of your settings)
Start up ADS again

Let us know if you're still seeing the Notebook open up at launch after those steps

Thanks,
Deleting the backup directory fixed my problem.
Lance Harra
Database Administrator
@.***
Educationhttps://education.mchdata.com/data/education  |  Healthcarehttps://education.mchdata.com/data/healthcare  |  Governmenthttps://www.mchdata.com/data/government  |  Religionhttps://education.mchdata.com/data/religion
800-776-6373  |  mchdata.comhttps://www.mchdata.com/
Stay up to date as K-12 policies continue to evolve
with our exclusive COVID-19 Map and Data Resourcehttps://www.mchdata.com/covid19/schoolclosings.
From: Charles Gagnon @.>
Sent: Wednesday, November 3, 2021 11:39 AM
To: microsoft/azuredatastudio @.>
Cc: Lance Harra @.>; Mention @.>
Subject: Re: [microsoft/azuredatastudio] Tries to run a notebook everytime I start azuredatastudio (Issue #17433)
EXTERNAL: This email originated from outside of MCH. Do not click any links or open any attachments unless you trust the sender and know the content is safe.
@LanceHMCHhttps://github.com/LanceHMCH Sorry to hear you're having issues, could you try these steps to clear the backup cache? That may be what's causing

Close all instances of ADS
Browse to %appdata%/azuredatastudio
Delete the Backups folder (it just contains hot reload backups for editors so shouldn't affect any of your settings)
Start up ADS again

Let us know if you're still seeing the Notebook open up at launch after those steps
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/microsoft/azuredatastudio/issues/17433#issuecomment-959685544, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AMOW5A7RT6KGL33VLQ4LEH3UKFXTTANCNFSM5GOJZXRA.
Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

Glad to hear it! I'll close this issue now - if you keep running into issues with a particular notebook please let us know and we can investigate!

authors: Charles-Gagnon LanceHMCH VasuBhog


text:
Building empty legacy .sqlproj fails

Azure Data Studio Version: RC build

Building an empty legacy style sqlproj fails with these errors (non-empty legacy project fails too):
    stdout: /Users/kisantia/.azuredatastudio-rc1/extensions/microsoft.sql-database-projects-0.19.0/BuildDirectory/Microsoft.Data.Tools.Schema.SqlTasks.targets(525,5): Build error 72002: The extension type Microsoft.SqlServer.Dac.Deployment.Internal.InternalDeploymentPlanExecutor could not be instantiated. [/Users/kisantia/SqlProjects/azureLegacy/azureLegacy.sqlproj]
    stdout:
    stdout: /Users/kisantia/.azuredatastudio-rc1/extensions/microsoft.sql-database-projects-0.19.0/BuildDirectory/Microsoft.Data.Tools.Schema.SqlTasks.targets(525,5): Build error 72002: The extension type Microsoft.SqlServer.Dac.Deployment.Internal.InternalDeploymentPlanModifier could not be instantiated. [/Users/kisantia/SqlProjects/azureLegacy/azureLegacy.sqlproj]
    stdout:
    stdout:
    stdout: Build FAILED.
    stdout:
    stdout:
    stdout: /Users/kisantia/.azuredatastudio-rc1/extensions/microsoft.sql-database-projects-0.19.0/BuildDirectory/Microsoft.Data.Tools.Schema.SqlTasks.targets(525,5): Build error 72002: The extension type Microsoft.SqlServer.Dac.Deployment.Internal.InternalDeploymentPlanExecutor could not be instantiated. [/Users/kisantia/SqlProjects/azureLegacy/azureLegacy.sqlproj]
    stdout: /Users/kisantia/.azuredatastudio-rc1/extensions/microsoft.sql-database-projects-0.19.0/BuildDirectory/Microsoft.Data.Tools.Schema.SqlTasks.targets(525,5): Build error 72002: The extension type Microsoft.SqlServer.Dac.Deployment.Internal.InternalDeploymentPlanModifier could not be instantiated. [/Users/kisantia/SqlProjects/azureLegacy/azureLegacy.sqlproj]
    stdout:     0 Warning(s)
    stdout:     2 Error(s)
    stdout:
    stdout: Time Elapsed 00:00:01.72
    stdout:
    >>> "/usr/local/share/dotnet/dotnet"  build "/Users/kisantia/SqlProjects/azureLegacy/azureLegacy.sqlproj" /p:NetCoreBuild=true /p:NETCoreTargetsPath="/Users/kisantia/.azuredatastudio-rc1/extensions/microsoft.sql-database-projects-0.19.0/BuildDirectory"    … exited with code: 1
	>>> "/usr/local/share/dotnet/dotnet"  build "/Users/kisantia/SqlProjects/azureLegacy/azureLegacy.sqlproj" /p:NetCoreBuild=true /p:NETCoreTargetsPath="/Users/kisantia/.azuredatastudio-rc1/extensions/microsoft.sql-database-projects-0.19.0/BuildDirectory"   … errored out: Process exited with code 1

I suspect this is caused by the update to newer DacFx preview nuget, 160.6263.0-preview. When changing the STS version back to 4.2.0.10, which has DacFx 160.6253.0-preview, building legacy style sqlproj succeeds.
Building sdk-style projects still works as expected, likely because it uses an older version of DacFx that's bundled with the Microsoft.Build.Sql nuget.

investigation update: this error not from the newer DacFx nuget, but because of a different version of System.ComponentModel.Composition in STS 4.2.0.16.
STS 4.2.0.10 has System.ComponentModel.Composition 4.6.26515.6 and STS 4.2.0.16 has System.ComponentModel.Composition 4.700.19.56404. This is one of the dlls used when building a sqlproj.

update: confirmed that this new version was brought in by the upgrade of Microsoft.SqlServer.Migration.Assessment in https://github.com/microsoft/sqltoolsservice/pull/1617, which increased the System.ComponentModel.Composition dependency to 4.7.0.
As a workaround for the August release, Raymond has helped create a new nuget of Microsoft.SqlServer.Migration.Assessment that has the System.ComponentModel.Composition dependency to 4.6.0. The follow task for me is to remove sql project's dependency on getting these dlls from STS so sql projects won't be vulnerable to breaking again like this in the future https://github.com/microsoft/azuredatastudio/issues/20374.


text:
Excel export can't filter on dates

Issue Type: Bug
When I save as Excel, the date filter in Excel can't parse the dates correctly so that it can collapse all the dates in a year and let you expand specific years to get to the months.
If I copy the data to my clipboard, and paste it into Excel the date filtering works just fine.
Azure Data Studio version: azuredatastudio 1.40.1 (3a32679ab590c1023ab4de6f191769e7e127d25b, 2022-11-22T19:35:40.769Z)
OS version: Darwin x64 22.1.0
Restricted Mode: No
Preview Features: Enabled

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-8850H CPU @ 2.60GHz (12 x 2600)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: disabled_offdirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmetal: disabled_offmultiple_raster_threads: enabled_onoop_rasterization: enabledopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okskia_renderer: enabled_onvideo_decode: enabledvideo_encode: enabledwebgl: enabledwebgl2: enabled

Load (avg)
4, 5, 6

Memory (System)
32.00GB (0.62GB free)

Process Argv

Screen Reader
no

VM
0%

Extensions (1)

Extension
Author (truncated)
Version

profiler
Mic
0.11.0

@caohai please take a look.

Yes, that it is what I'm referring to.  That behavior works if I copy the results to the clipboard and paste it into Excel. If I export it to Excel it doesn't work.

@caohai Yes, that it is what I'm referring to. That behavior works if I copy the results to the clipboard and paste it into Excel. If I save as Excel it doesn't work.

I see. This feature was working for me when I tested it. I'm guessing it's some issue with the data in date column. Can you share the following if possible?

A copy of the Excel file (w/o any sensitive info) that data filter doesn't work.
The data type of the date column. (It would be great if you can provide a small script that can create a similar table and insert a few rows of data that have have this issue reproduced)

Needs more info to proceed, feel free to reopen once we have that.

authors: BisonFan alanrenmsft caohai


text:
Update schema compare extension in insiders

Update schema compare extension in insiders to 1.5.0 for the changes that Sql Project needs. This PR fixes #10967.

have you already updated the version of the this extension in main branch? shall i just grab the vsix from there?

@alanrenmsft Nope haven't updated the version in main yet. Yup the vsix in the current builds should be good to take.

@kisantia confused 😕 , I just checked, it is 1.15 now, what do you mean by "Haven't updated the version in main yet" ?😆

@alanrenmsft the version got bumped to 1.5 after 1.4 got released last time in March. I meant I haven't updated again since that.

i see, i have uploaded the latest vsix.

Thanks Alan! :)

@kisantia extension gallery updated, I was able to install it, please do some testing to make sure

authors: alanrenmsft kisantia


text:
delete duplicate workflow

This PR fixes #

Coverage decreased (-0.07%) to 35.317% when pulling 5a40142bcff9d940183e425c44f61b0888737ea8 on anthonydresser/duplicatecodeanal into e540096e07ebbd3b98966da56aa73ce0bbd19a20 on main.

authors: anthonydresser coveralls


text:
add required indicator

This PR fixes #16621

add required indicator for server and user name
previously for integrated auth mode, we will show user name/password as disabled, I am changing the code to hide the fields to be consistent with the behavior of other fields.
code refactoring

Pull Request Test Coverage Report for Build 1129135863

7 of 26 (26.92%)  changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.02%) to 41.43%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/sql/base/browser/ui/inputBox/inputBox.ts
2
3
66.67%

src/sql/workbench/browser/modal/dialogHelper.ts
5
9
55.56%

src/sql/workbench/services/connection/browser/connectionWidget.ts
0
14
0.0%

Totals

Change from base Build 1129119074:
0.02%

Covered Lines:
26406

Relevant Lines:
57819

💛  - Coveralls

LGTM. Is password not a required field?

@kburtram SQL Server does allow SQL Login without password.

authors: alanrenmsft coveralls


text:
Switch to microsoft/bond casing

Microsoft has renamed its GitHub organization from "Microsoft" to
"microsoft". This commit fixes various paths, as not all tools are able
to follow the Microsoft -> microsoft redirects that are in place.
These replacements were made with the following script:
for f in $(grep -l -r -e 'github.com/Microsoft' -e 'Microsoft/bond' -e 'Microsoft.github.io' *); do
    sed -i -e 's~github.com/Microsoft~github.com/microsoft~g; s~Microsoft/bond~microsoft/bond~g;s~Microsoft.github.io~microsoft.github.io~g' "$f"
done

LGTM

authors: chwarr sapek

repo: microsoft/bond


text:
[LG] Import fallback not working as it used to

Github issues should be used for bugs and feature requests. Use Stack Overflow for general "how-to" questions.
Version
4.9.3
Describe the bug
In earlier versions, I believe 4.8.x, when importing LG files it used the following fallback rules: "en-us" -> "en" -> "". As of version 4.9.x it doesn't fallback to the last option with the empty language. It first tries to resolve "en-us" then "en" and then fails with the message There is no matching LG resource for common.lg.
To Reproduce
Steps to reproduce the behavior:

Use the Bot Framework Composer to create a new bot using the Echo Bot example
Navigate to %AppData%\Roaming\BotFrameworkComposer\hostedBots<bot id>\language-generation\en-us and rename common.en-us.lg to common.lg
Start the bot from the Bot Framework Composer and test it in the Bot Framework Emulator
Notice the error message There is no matching LG resource for common.lg

Expected behavior
I would expect the LanguagePolicy to fallback to the empty language rule for imports, so I can share the same common.lg with all languages.
Additional context
The LanguagePolicy class comments clearly describe that the output of the default policy for example "en-us" should be ["en-us", "en", ""]. The actual output for example "en-us" is actually ["en-us", "en"], so it makes sense it would not fallback to "". However by looking at the history of the LanguagePolicy class I couldn't figure out why it worked using 4.8.x since it appears this logic hasn't really changed over time.
[bug]

@chrimc62 @vishwacsena could you please take a look?

This was broken by @boydc2014 with commit a457ec6d when he allowed specifying default languages.  He only added those if the language was empty which will never happen.  He should remove the lines below from LanguagePolicy.
              if (language.Length == 0)
                {

@boydc2014 could you please take a look?

@chrimc62 @sschutten sorry for the late response,  short summary is

the import behavior of lg was impacted because of the language policy change
but the root cause is not language policy structure is wrongly updated, it's a by design change to support more flexible fallback behavior, more context is added in below
the root cause is LG importing is not using customized language policy

Also, in Composer, we were designing for giving every lg a locale, even for common.lg. I will work for a mitigation of this pattern and get back to you later @sschutten .
TL, DR version
in 4.9.3 and before the policy class is like
en-us => en=> ""
fr-fr => fr => ""
it's a fixed list and user can't customize that, so in latest, we have some upgrade on the structure to support the scenario of Composer (which are moving to multi-locale support), we are removing the the trailing "", and add a specific entry "", so the new dict will look like
en-us => en
fr-fr => fr
"" => [list of default language(s) that user can specify]
If user don't set this list of default languages, it would work as same as before.
LG import impact
The root issue is LG import resolving is happened before user even feed this customized language-policy, so LG import resolving is using a default language policy which don't have "" anymore in this change.

@boydc2014 thank you for the answer. I've read your answer but I fail to fully understand. Can you help me clear this up?

Also, in Composer, we were designing for giving every lg a locale, even for common.lg.

Does this mean that a shared common.lg across all languages is no longer supported?

in 4.9.3 and before the policy class is like
en-us => en=> ""
fr-fr => fr => ""

My issue is referring 4.9.3. In 4.9.3 the policy class is like:
en-us => en
fr-fr => fr
So the last "" is missing.

we are removing the the trailing "", and add a specific entry "", so the new dict will look like
en-us => en
fr-fr => fr
"" => [list of default language(s) that user can specify]

As I understand this won't help resolve a common.lg (without language) from any LG file with a language. Let me clarify.
E.g. I have the following two LG files:

Main.en-us.lg
common.lg
Main.en-us.lg imports common.lg

The LanguageGeneratorManager will load a list of LG resources grouped by language
https://github.com/microsoft/botbuilder-dotnet/blob/e469816cca0c3aaefa67b6207320534c5a8115e5/libraries/Microsoft.Bot.Builder.Dialogs.Adaptive/Generators/LanguageGeneratorManager.cs#L34
This looks like:
[
"en-us": ["Main.en-us.lg"],
"": ["common.lg"]
]

This dictionary is then forwarded to the TemplateEngineLanguageGenerator
https://github.com/microsoft/botbuilder-dotnet/blob/e469816cca0c3aaefa67b6207320534c5a8115e5/libraries/Microsoft.Bot.Builder.Dialogs.Adaptive/Generators/LanguageGeneratorManager.cs#L92

The TemplateEngineLanguageGenerator constructs a ResourceExplorerResolver with this dictionary
https://github.com/microsoft/botbuilder-dotnet/blob/e469816cca0c3aaefa67b6207320534c5a8115e5/libraries/Microsoft.Bot.Builder.Dialogs.Adaptive/Generators/TemplateEngineLanguageGenerator.cs#L54

A user sends a message to the bot with locale 'en-us'

The ResourceExplorerResolver retrieves the fallback locale. Since 'en-us' exists as a locale in the dictionary keys, the locale is 'en-us'.
https://github.com/microsoft/botbuilder-dotnet/blob/e469816cca0c3aaefa67b6207320534c5a8115e5/libraries/Microsoft.Bot.Builder.Dialogs.Adaptive/Generators/LanguageGeneratorManager.cs#L60

Since the ResourceExplorerResolver keeps using the locale 'en-us' for each resolve attempt, it will never find resources with language "".
Before the change the dictionary of LG resources grouped by language in step 1. would look like the following, which means it would be able to resolve the "common.lg".
[
"en-us": ["Main.en-us.lg", "common.lg"],
"": ["common.lg"]
]
I can specify a list of default languages, but those would only be added when language is "". I believe that's what @chrimc62 is referring to in their comment.

repo: microsoft/botbuilder-dotnet


text:
[LG] refine inline text evaluator

Originally, we do parse the additional inline text directly.
In this pr, we will add a new text parser, that accepts the text and original LGFile both.
So, there will be no intermediate error messages appearing in parse directly.
At the same time, no impact on parse performance.
close: #3352

Pull Request Test Coverage Report for Build 105875

0 of 0   changed or added relevant lines in 0 files are covered.
29 unchanged lines in 2 files lost coverage.
Overall coverage increased (+0.004%) to 79.408%

Files with Coverage Reduction
New Missed Lines
%

/libraries/Microsoft.Bot.Builder.LanguageGeneration/LGFile.cs
12
88.41%

/libraries/Microsoft.Bot.Builder.LanguageGeneration/LGParser.cs
17
77.45%

Totals

Change from base Build 105849:
0.004%

Covered Lines:
10759

Relevant Lines:
13549

💛  - Coveralls

:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.dll compared against version 4.6.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.AI.Luis.dll compared against version 4.6.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.AI.QnA.dll compared against version 4.6.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.ApplicationInsights.dll compared against version 4.6.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.Azure.dll compared against version 4.6.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.Dialogs.dll compared against version 4.6.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.Integration.ApplicationInsights.Core.dll compared against version 4.6.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.Integration.AspNet.Core.dll compared against version 4.6.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.TemplateManager.dll compared against version 4.6.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.Testing.dll compared against version 4.6.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Configuration.dll compared against version 4.6.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Connector.dll compared against version 4.6.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Schema.dll compared against version 4.6.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Streaming.dll compared against version 4.6.3

authors: Danieladu coveralls fuselabs


text:
fix: streaming client should connect under Node.js

Fixes #4412.
Description
NodeWebSocket.connect() is not implemented correctly and should never work. There are multiple problems in the original implementation:

It expects the first argument is hostname

Instead, it should be server URL (for example, ws://your-bot.azurewebsites.net/.bot/v3/directline?token=123)

It is using a server, fake handshake, to get the WebSocket object out, which is probably not working
It is waiting for close event for connection to established, which is wrong

We are not sure why the original implementation has done this way.
We are updating the implementation to use ws package to connect.
Designs
Removing second argument (port = 8082)
We are removing the second argument (port = 8082) because:

The serverAddress will contain the port number (by default, ws: is 80, and wss: is 443)
If we keep the current logic, we will always ignore the port number in serverAddress because port is default to 8082

This does not sound intuitive to developer because the port number in serverAddress will always get replaced.
If we don't default port number to 8082, we will need to change the API saying there is no default (i.e. undefined). At the end of the day, we are still modifying the API and will introduce breaking changes.
Regardless of whether we keep port or not, we are still introducing breaking changes. Thus, we are choosing to remove port to simplify our code.
If the developer need to change the port to 8082, they could use the following code snippet:
const url = new URL(serverAddress);

url.port = 8082;

await nodeWebSocket.connect(url.href);

Specific Changes
❗This PR will introduce breaking changes and modified the API. Please bump version appropriately.

Update NodeWebSocket.connect() to connect to a Web Socket server as a client
Add tests

We did not add unhappy path (connect() rejections) because it will print errors to console and there is no easy way to suppress

Cleaned up code related to watershed

watershed was one of the candidate packages for using Web Socket in Node.js
However, ultimately, we chose ws
There are no binary, data, and text event in the ws version of Web Socket
Thus, we are removing test code related to these events

Separating mocks

Instead of using an uber FauxSock which mocks Web Socket and TCP/IP Socket, we are opting for a more specific mock for TCP/IP Socket, namely FauxSocket

Testing
Added tests to ensure NodeWebSocket can connect to a real Web Socket server.

Pull Request Test Coverage Report for Build 3969621782

4 of 4 (100.0%)  changed or added relevant lines in 1 file are covered.
13072 unchanged lines in 619 files lost coverage.
Overall coverage decreased (-62.3%) to 22.358%

Files with Coverage Reduction
New Missed Lines
%

libraries/adaptive-expressions/src/builtinFunctions/abs.ts
1
80.0%

libraries/adaptive-expressions/src/builtinFunctions/average.ts
1
87.5%

libraries/adaptive-expressions/src/builtinFunctions/binary.ts
1
88.89%

libraries/adaptive-expressions/src/builtinFunctions/ceiling.ts
1
80.0%

libraries/adaptive-expressions/src/builtinFunctions/countWord.ts
1
88.89%

libraries/adaptive-expressions/src/builtinFunctions/dataUriToBinary.ts
1
88.89%

libraries/adaptive-expressions/src/builtinFunctions/dataUriToString.ts
1
88.89%

libraries/adaptive-expressions/src/builtinFunctions/dataUri.ts
1
88.89%

libraries/adaptive-expressions/src/builtinFunctions/equal.ts
1
83.33%

libraries/adaptive-expressions/src/builtinFunctions/exists.ts
1
83.33%

Totals

Change from base Build 3841042555:
-62.3%

Covered Lines:
6916

Relevant Lines:
22374

💛  - Coveralls

@ckkashyap @compulim What is the expected impact of this being a breaking change?  What would be a shame is to correct one issue and break another set of customers.

I am modifying the API to become connect(serverAddressOrHostName: string, port = 8082). So it is conceptually backward-compatible.

If serverAddressOrHostName is a valid URL (via new URL), then use it as-is, without the second argument (ignore port)
Otherwise, serverAddressOrHostName is a host name, then

Construct an URL object by using serverAddressOrHostName as hostname and second argument as port
The protocol used is ws: and not wss:
This is for backward compatibility as previous version suggests non-secure protocol

As we do not have any existing tests that proves the existing code is working, we are doing our best efforts to make it backward compatible.

I tried to write a test to show how previous signature would work. However, there are obvious mistakes in the code that made it very unlikely to work:

options.headers.upgrade must set to 'websocket'
Second argument of WebSocket.server.completeUpgrade should be {}, instead of undefined

I am keeping the old code as-is, without any tests.

authors: compulim coveralls tracyboehrer

repo: microsoft/botbuilder-js


text:
VSCode / Pylance complaints about type annotation issues the libraries

Version
4.11
Describe the bug
VSCode's pylance complained about this, the message was:
List expression not allowed in type annotation
  Use List[T] instead

Screenshots

Additional context
I'll add a PR for the instance of this I've found, but a code scan of the whole repo for this issue would be a good idea.

Thanks for submitting the PR! The Python codeowners will review it as soon as they are back from the holidays.

This issue will be closed when the linked PR is corrected and merged.  Currently, there is a build error during validation.

This issue will be closed when the linked PR is corrected and merged.  Currently, there is a build error during validation.

authors: asdkant-ey joshgummersall tracyboehrer

repo: microsoft/botbuilder-python


text:
Simple 'fix' for undocumented hotkeys

So many issues have touched upon hotkeys being difficult to discover. It was revealing to see someone mention that toggling the Alt key was one partial method. Nice...
But otherwise there's no online help and no documentation to consult. I saw mention of a possible web search target of Keyboard shortcuts in apps, back when someone mentioned that page was 'new' (in 2019?!)  Kind of unfortunate the in-page links there don't work though... nor the HTML entities...
But wait! There's a real simple 'fix. The nearest thing you've got to a link to online help is ín the "About" popup from the window hamburger menu, which (at the bottom of the popup) has a link to here, Github.  Which shows the README.md!  Online!
And if only that readme (quite often used for usage information by other projects) had... keyboard shortcuts documented... wow!
I've copy-n-pasted and markdown'ed that text below:

Press this key
To do this

Alt + 1
Switch to Standard mode

Alt + 2
Switch to Scientific mode

Alt + 3
Switch to Graphing mode

Alt + 4
Switch to Programmer mode

Alt + 5
Switch to Date Calculation mode

Ctrl + M
Store in memory, in Standard mode, Scientific mode, and Programmer mode

Ctrl + P
Add to memory, in Standard mode, Scientific mode, and Programmer mode

Ctrl + Q
Subtract from memory, in Standard mode, Scientific mode, and Programmer mode

Ctrl + R
Recall from memory, in Standard mode, Scientific mode, and Programmer mode

Ctrl + L
Clear memory

Delete
Clear current input (select CE)

Esc
Fully clear input (select C)

Tab
Navigate to the next UI item and give it focus

Spacebar
Selects UI item that has focus

Enter
Selects = in Standard mode, Scientific mode, and Programmer mode

F9
Select +/- in Standard mode, Scientific mode, and Programmer mode

R
Select 1/x in Standard mode and Scientific mode

@
Select 2√x in Standard mode and Scientific mode

%
Select % in Standard mode and Programmer mode

Ctrl + H
When history button is visible, selects the history button in Standard mode and Scientific mode

Up arrow
Move up in history list, memory list, and menu items

Down arrow
Move down in history list, memory list, and menu items

Ctrl + Shift + D
Clear history

F3
Select DEG in Scientific mode

F4
Select RAD in Scientific mode

F5
Select GRAD in Scientific mode

G
Select 2x in Scientific mode

Ctrl + G
Select 10x in Scientific mode

S
Select 10x in Scientific mode

Shift + S
Select sin-1 in Scientific mode

Ctrl + S
Select sinh in Scientific mode

Ctrl + Shift + S
Select sinh-1 in Scientific mode

T
Select tan in Scientific mode

Shift + T
Select tan-1 in Scientific mode

Ctrl + T
Select tanh in Scientific mode

Ctrl + Shift + T
Select tanh-1 in Scientific mode

O
Select cos in Scientific mode

Shift + O
Select cos-1 in Scientific mode

Ctrl + O
Select cosh in Scientific mode

Ctrl + Shift + O
Select cosh-1 in Scientific mode

U
Select sec in Scientific mode

Shift + U
Select sec-1 in Scientific mode

Ctrl + U
Select sech in Scientific mode

Ctrl + Shift + U
Select sech-1 in Scientific mode

I
Select csc in Scientific mode

Shift + I
Select csc-1 in Scientific mode

Ctrl + I
Select csch in Scientific mode

Ctrl + Shift + I
Select csch-1 in Scientific mode

J
Select cot in Scientific mode

Shift + J
Select cot-1 in Scientific mode

Ctrl + J
Select coth in Scientific mode

Ctrl + Shift + J
Select coth-1 in Scientific mode

Ctrl + Y
Select y√x in Scientific mode

Shift + \
Select |x| in Scientific mode

[
Select ⌊x⌋ in Scientific mode

]
Select ⌈x⌉ in Scientific mode

L
Select log in Scientific mode

Shift + L
Select logyx in Scientific mode

M
Select dms in Scientific mode

N
Select ln in Scientific mode

Ctrl + N
Select ex in Scientific mode

P
Select Pi in Scientific mode

Q
Select x2 in Standard mode and Scientific mode

V
Toggles on/off F-E buttonin Scientific mode

X
Select exp in Scientific mode

Y, ^
Select xy in Scientific mode

#
Select x3 in Scientific mode

!
Select n! in Scientific mode

%
Select mod in Scientific mode

Ctrl ++ on numpad
Graph zooms in while in Graphing mode

Ctrl +- on numpad
Graph zooms out while in Graphing mode

F2
Select DWORD in Programmer mode

F3
Select WORD in Programmer mode

F4
Select BYTE in Programmer mode

F5
Select HEX in Programmer mode

F6
Select DEC in Programmer mode

F7
Select OCT in Programmer mode

F8
Select BIN in Programmer mode

F12
Select QWORD in Programmer mode

A-F
Select letters A-F in Programmer mode while HEX is selected

Shift + ,
Select RoL in Programmer mode when Bit Shift is set to either "Circular" shift

Shift + .
Select RoR in Programmer mode when Bit Shift is set to either "Circular" shift

Shift + ,
Select Lsh in Programmer mode when Bit Shift is set to "Arithmetic" or "Logical" shift

Shift + .
Select Rsh in Programmer mode when Bit Shift is set to "Arithmetic" or "Logical" shift

%
Select % in Programmer mode

|
Select OR in Programmer mode

^
Select XOR in Programmer mode

\
Select NOR in Programmer mode

~
Select NOT in Programmer mode

&
Select AND in Programmer mode

.
Select NAND in Programmer mode

Please consider adding this usage information to the README.md.

The Keyboard shortcuts in apps page is the official documentation for this. Instead of duplicating the content, we'd rather fix the existing page. I've submitted a request internally to get the in-page links fixed.
I don't think it's wise to add a duplicate copy of this documentation in the README. Mixing end-user and developer content can make it harder for both audiences to find the information they need.

authors: mcooley tshinnic

repo: microsoft/calculator


text:
Import using Upgrade: Timeout after 60 mins

While deploying solution using Upgrade method, the pipeline timesout after 1 hr.

@rajyraman moving this over to microsoft/coe-starter-kit to track in one place

authors: mikefactorial rajyraman

repo: microsoft/coe-alm-accelerator-templates


text:
[BUG]

Description

In which platform does it happen?

How do we replicate the issue?

Expected behavior (i.e. solution)

Other Comments

Hi, hello

Closing since this is empty.

repo: microsoft/computervision-recipes


text:
Pennsylvania updates 4/5

Adjusted phase 1b (added high risk individuals, essential workers)
Recreated phase 1c (duplicated 1b and added more essential workers)
Set 1b as active for state, 1c active for Philly
Also made phase 2 for later updates

[{"key":"pennsylvania","type":"regions","value":{"philadelphia":{"vaccination":{"content":{"activePhase":"1c"}}}}},{"key":"pennsylvania","type":"vaccination","value":{"content":{"activePhase":"1b","phases":[{"id":"1a","qualifications":[{"question":"c19.eligibility.question/healthcare_worker","moreInfoText":"c19.eligibility.moreinfo/healthcare_worker.pa.1a"},{"question":"c19.eligibility.question/long_term_care_resident"},{"question":"c19.eligibility.question/exposure_to_infectious_material.do","moreInfoText":"c19.eligibility.moreinfo/exposure_to_infectious_material.do.pa.1a"},{"question":"c19.eligibility.question/age.65_up"},{"question":"c19.eligibility.question/age.are_you_age","moreInfoText":"c19.eligibility.moreinfo/age.are_you_age.pa.1a"}]},{"id":"1b","qualifications":[{"question":"c19.eligibility.question/healthcare_worker","moreInfoText":"c19.eligibility.moreinfo/healthcare_worker.pa.1b","moreInfoUrl":"https://www.health.pa.gov/topics/disease/coronavirus/Vaccine/Pages/Vaccine.aspx"},{"question":"c19.eligibility.question/long_term_care_resident.are"},{"question":"c19.eligibility.question/essential_worker","moreInfoText":"c19.eligibility.moreinfo/essential_worker.pa.1b","moreInfoUrl":"https://www.health.pa.gov/topics/disease/coronavirus/Vaccine/Pages/Vaccine.aspx"},{"question":"c19.eligibility.question/age.65_up"},{"question":"c19.eligibility.question/health.1b.pa"},{"question":"c19.eligibility.question/congregate"},{"question":"c19.eligibility.question/health","moreInfoText":"c19.eligibility.moreinfo/age.are_you_age.pa.1b","moreInfoUrl":"https://www.cdc.gov/coronavirus/2019-ncov/need-extra-precautions/people-with-medical-conditions.html"}]},{"id":"1c","label":"1C","qualifications":[{"question":"c19.eligibility.question/healthcare_worker","moreInfoUrl":"https://www.health.pa.gov/topics/disease/coronavirus/Vaccine/Pages/Vaccine.aspx","moreInfoText":"c19.eligibility.moreinfo/healthcare_worker.pa.1c"},{"question":"c19.eligibility.question/long_term_care_resident.are"},{"question":"c19.eligibility.question/essential_worker","moreInfoUrl":"https://www.health.pa.gov/topics/disease/coronavirus/Vaccine/Pages/Vaccine.aspx","moreInfoText":"c19.eligibility.moreinfo/essential_worker.pa.1c"},{"question":"c19.eligibility.question/age.65_up"},{"question":"c19.eligibility.question/health.1b.pa"},{"question":"c19.eligibility.question/congregate"},{"question":"c19.eligibility.question/health","moreInfoUrl":"https://www.cdc.gov/coronavirus/2019-ncov/need-extra-precautions/people-with-medical-conditions.html","moreInfoText":"c19.eligibility.moreinfo/age.are_you_age.pa.1c"}]},{"id":"2","label":"2","qualifications":[{"question":"c19.eligibility.question/age.16_up","moreInfoText":"c19.eligibility.moreinfo/age.16_up.pa.2"}]}]}}},{"key":"pennsylvania","type":"strings","value":{"content":{"c19.eligibility.moreinfo/healthcare_worker.pa.1b":{"en-us":"Health care personnel including, but not limited to:\n- Emergency medical service personnel\n- Nurses\n- Nursing assistants\n- Physicians\n- Dentists\n- Dental hygienists\n- Chiropractors\n- Therapists\n- Phlebotomists\n- Pharmacists\n- Technicians\n- Pharmacy technicians\n- Health professions students and trainees\n- Direct support professionals\n- Clinical personnel in school settings or correctional facilities\n- Contractual HCP not directly employed by the health care facility"},"c19.eligibility.moreinfo/essential_worker.pa.1b":{"en-us":"These include:\n- People in congregate settings not otherwise specified as long-term care facilities, and persons receiving home and community-based services\n- First responders (including Law enforcement and Firefighters)\n- Correctional officers and other workers serving people in congregate care settings not included in Phase 1A  \n- Food and agricultural workers\n- U.S. Postal Service workers\n- Manufacturing workers  \n- Grocery store workers  \n- Education workers \n- Clergy and other essential support for houses of worship \n- Public transit workers\n- Individuals caring for children or adults in early childhood and adult day programs"},"c19.eligibility.moreinfo/age.are_you_age.pa.1b":{"en-us":"This includes:\n- Cancer\n- Chronic kidney disease\n- Chronic lung diseases, including COPD (chronic obstructive pulmonary disease), asthma (moderate-to-severe), interstitial lung disease, cystic fibrosis, and pulmonary hypertension\n- Dementia or other neurological conditions\n- Diabetes (type 1 or type 2)\n- Down syndrome\n- Heart conditions (such as heart failure, coronary artery disease, cardiomyopathies or hypertension)\n- HIV infection\n- Immunocompromised state (weakened immune system)\n- Liver disease\n- Overweight and obesity\n- Pregnancy\n- Sickle cell disease or thalassemia\n- Smoking, current or former\n- Solid organ or blood stem cell transplant\n- Stroke or cerebrovascular disease, which affects blood flow to the brain\n- Substance use disorders"},"c19.eligibility.moreinfo/healthcare_worker.pa.1c":{"en-us":"Health care personnel including, but not limited to:\n- Emergency medical service personnel\n- Nurses\n- Nursing assistants\n- Physicians\n- Dentists\n- Dental hygienists\n- Chiropractors\n- Therapists\n- Phlebotomists\n- Pharmacists\n- Technicians\n- Pharmacy technicians\n- Health professions students and trainees\n- Direct support professionals\n- Clinical personnel in school settings or correctional facilities\n- Contractual HCP not directly employed by the health care facility"},"c19.eligibility.moreinfo/essential_worker.pa.1c":{"en-us":"These include:\n- People in congregate settings not otherwise specified as long-term care facilities, and persons receiving home and community-based services\n- First responders (including Law enforcement and Firefighters)\n- Correctional officers and other workers serving people in congregate care settings not included in Phase 1A  \n- Food and agricultural workers\n- U.S. Postal Service workers\n- Manufacturing workers  \n- Grocery store workers  \n- Education workers \n- Clergy and other essential support for houses of worship \n- Public transit workers\n- Individuals caring for children or adults in early childhood and adult day programs\nTransportation and logistics workers\n- Water and wastewater workers\n- Food service workers\n- Housing construction workers\n- Finance, including bank tellers workers\n- Information technology workers\n- Communications workers\n- Energy, including nuclear reactors workers\n- Legal services workers\n- Federal, state, county and local government workers, including county election workers, elected officials and members of the judiciary and their staff\n- Media workers\n- Public safety workers\n- Public health workers"},"c19.eligibility.moreinfo/age.are_you_age.pa.1c":{"en-us":"This includes:\n- Cancer\n- Chronic kidney disease\n- Chronic lung diseases, including COPD (chronic obstructive pulmonary disease), asthma (moderate-to-severe), interstitial lung disease, cystic fibrosis, and pulmonary hypertension\n- Dementia or other neurological conditions\n- Diabetes (type 1 or type 2)\n- Down syndrome\n- Heart conditions (such as heart failure, coronary artery disease, cardiomyopathies or hypertension)\n- HIV infection\n- Immunocompromised state (weakened immune system)\n- Liver disease\n- Overweight and obesity\n- Pregnancy\n- Sickle cell disease or thalassemia\n- Smoking, current or former\n- Solid organ or blood stem cell transplant\n- Stroke or cerebrovascular disease, which affects blood flow to the brain\n- Substance use disorders"},"c19.eligibility.moreinfo/age.16_up.pa.2":{"en-us":"All individuals not previously covered who are 16 and older and do not have a contraindication to the vaccine (note that at this time, only the Pfizer-BioNTech product is approved for those age 16 and 17)"}}}}]

repo: microsoft/covid-vaccine-bot


text:
Azure function support

Azure functions are basically Websites, Why is the tooling (debug menu UI) not available on azure function projects? Would be of so much use there.

Can you share more on the scenarios where you believe this would be useful?

DevTunnels appears for me for an Azure Functions v1 SDK style project. After manually configuring the port number it seems to work fine. Some automation there to hook it all up would be nice.
It's useful for eg. testing webhooks.

Thanks for the feedback. At this time, we don't plan on changing the experience here. However, the tunnel can manually be created in VS and also via the devtunnel CLI.

authors: bzuidgeest derekbekoe fowl2

repo: microsoft/dev-tunnels


text:
The Windows 10 .Net 4.8 Oct update removes TLS 1.1, 1.2. 1.3 from default security protocols from .Net apps forcing traffic to use SSL3 and TLS 1.0.

These are the updates to the Windows 10 versions that downgrade the security protocols.
Win 10 1803, KB4519572
Win 10 1809, KB4519565
Win 10 1903, KB4519573
Before applying the updates the default security protocols have this value:
System.Net.ServicePointManager.SecurityProtocol: Tls, Tls11, Tls12, Tls13
After the updates are applied to the Windows 10 pc's this is the default value for the security protocol:
System.Net.ServicePointManager.SecurityProtocol: Ssl3, Tls
Our application was using .net 4.6.  I tried updating our app to .net 4.6.2, 4.7.2, and 4.8 and none of those versions fixed the issue.

We seem to have discovered the exact same issue, but I can't help but notice that there aren't any comments here and this ought to be a gigantic problem if widespread. Are there any updates to this or any additional information about this issue?

No updates at all.  I ended up having to check the default protocols before
calling my web services and if TLS 1.1 and TLS 1.2 are missing then I have
to manually include them.  This seems like a huge bug in the .NET Framework.
On Fri, Feb 21, 2020 at 8:54 AM pete-bloomerang notifications@github.com
wrote:

We seem to have discovered the exact same issue, but I can't help but
notice that there aren't any comments here and this ought to be a gigantic
problem if widespread. Are there any updates to this or any additional
information about this issue?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/microsoft/dotnet/issues/1138?email_source=notifications&email_token=AGWBPX6CONR2LGD2XY5J4XDRD7TKTA5CNFSM4JKYCKH2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEMS6TQY#issuecomment-589687235,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AGWBPX2GHIDQ4LHAWRNQU53RD7TKTANCNFSM4JKYCKHQ
.

Thanks; we'll do the same. If we find anything else out I'll post an update here.

cc @karelz

This is a surprising report. I would not expect anything like this happening. Given the limited number of people reporting it, I assume it is not something widespread, but rather something interfering in the apps ... let's find out.
@baschlegel @pete-bloomerang can you please post your exact versions of Windows and of Cumulative update for .NET Framework you have installed on machines that show these symptoms? (@baschlegel listed 3 versions with KBs and I haven't seen any version info from @pete-bloomerang)
Can you try a simple HelloWorld app on those "buggy" machines?
Here's what I tried:
class Program {
    static void Main() => System.Console.WriteLine(System.Net.ServicePointManager.SecurityProtocol);
}

Targeting 4.6 (App.config):
<?xml version="1.0" encoding="utf-8" ?>
<configuration>
    <startup>
        <supportedRuntime version="v4.0" sku=".NETFramework,Version=v4.6" />
    </startup>
</configuration>

Output on Win10 version 1909 (client OS) with latest KB 4534132 (Feb 11 Cumulative Update for .NET Framework), targeting .NET Framework 4.6:
Tls, Tls11, Tls12, Tls13

I am curious if this HelloWorld will have different output in your environments.
Also note, that once you target 4.7.1+, the result is different:
<?xml version="1.0" encoding="utf-8"?>
<configuration>
    <startup>
        <supportedRuntime version="v4.0" sku=".NETFramework,Version=v4.7.1"/>
    </startup>
</configuration>

Output on Win10 version 1909 (client OS) with latest KB 4534132 (Feb 11 Cumulative Update for .NET Framework), targeting .NET Framework 4.7.1:
SystemDefault

And here's result, when your application targets 4.5 (while running on newer version of .NET Framework):
Targeting 4.5 (App.config):
<?xml version="1.0" encoding="utf-8"?>
<configuration>
    <startup>
        <supportedRuntime version="v4.0" sku=".NETFramework,Version=v4.5"/>
    </startup>
</configuration>

Output on Win10 version 1909 (client OS) with latest KB 4534132 (Feb 11 Cumulative Update for .NET Framework), targeting .NET Framework 4.5:
Ssl3, Tls

Looking at TLS best practices, I have a suspicion that this is what might have happened:

Your app targets .NET 4.5.2 or earlier
You don't have necessary registry keys set (see registry key settings for targeting .NET 3.5-4.5.2)

Wild guess: One of the OS updates may have nuked these registry keys from your registry (I think we have had such case in the past ... I have to check older emails)

I'm able to reproduce all three outputs exactly on one of the machines with your code. I'll check the other machine too.
One of the services having the issue is targeting 4.7.2 (matching that in the app.config). I'll check registry values and windows updates and provide an update.

I do have 4534132 installed as the latest .NET update (followed by a cumulative update for Windows 10: kb4532693)

If you are able to reproduce the same (correct) output on my minimal repro on machines where your real app has troubles suddenly after updates, then one of these things is possible:

Either your app targets something different than you think (please double check app.config) and the reg keys for <4.5.2 are not set, or
Something in your app sets the SecurityProtocol explicitly (maybe a library, maybe based on some version detection?)

I can't come up with different explanations ...

Unfortunately all of my test machines have had Windows updates applied
since I posted this issue and I'm not longer able to replicate the original
problem.  When I first post the issue I had code similar to yours and it
would return System.Net.ServicePointManager.SecurityProtocol: Tls, Tls11,
Tls12, Tls13 before the security updates were applied.  After the update
the code would only return
System.Net.ServicePointManager.SecurityProtocol: Ssl3, Tls.  Your nuked
registry idea is possible.  This is an older app that started out as .NET
3.5 and has be migrated up to .NET 4.6.2 over the years.
On Fri, Feb 21, 2020 at 1:01 PM Karel Zikmund notifications@github.com
wrote:

If you are able to reproduce the same (correct) output on my minimal repro
on machines where your real app has troubles suddenly after updates, then
one of these things is possible:

Either your app targets something different than you think (please
double check app.config) and the reg keys for <4.5.2 are not set, or
Something in your app sets the SecurityProtocol explicitly (maybe a
library, maybe based on some version detection?)

I can't come up with different explanations ...
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/microsoft/dotnet/issues/1138?email_source=notifications&email_token=AGWBPX4JGO7T72O6J6CBRHTREAQIZA5CNFSM4JKYCKH2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEMTXTCA#issuecomment-589789576,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AGWBPX3ZBZK7UVMMYJEBJCDREAQIZANCNFSM4JKYCKHQ
.

I believe HKEY_LOCAL_MACHINE\SOFTWARE\WOW6432Node\Microsoft.NETFramework\v4.0.30319 is the correct location? I have no SchUseStrongCrypto or SystemDefaultTlsVersions entries set there. I actually don't have those set in any of the versions under .NETFramework.

Or one more idea: You have the reg keys SchUseStrongCrypto and/or SystemDefaultTlsVersions set to value 0 ... that will override behavior even if targeting 4.7.2
Output on Win10 version 1909 (client OS) with latest KB 4534132 (Feb 11 Cumulative Update for .NET Framework), targeting .NET Framework 4.5 with reg keys SchUseStrongCrypto and SystemDefaultTlsVersions set to 0:
Ssl3, Tls

Reg key paths for .NET Framework 4.x are:

HKEY_LOCAL_MACHINE\SOFTWARE\WOW6432Node\Microsoft.NETFramework\v4.0.30319
HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft.NETFramework\v4.0.30319

@pete-bloomerang let me know if you want to use more interactive troubleshooting channel ... I am curious what is happening on your machines.
gitter IM / Teams / Skype / Twitter DM - see my email in my profile.

Reg key paths for .NET Framework 4.x are:

HKEY_LOCAL_MACHINE\SOFTWARE\WOW6432Node\Microsoft.NETFramework\v4.0.30319
HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft.NETFramework\v4.0.30319

I do not have either SchUseStrongCrypto or SystemDefaultTlsVersions in either of those locations (assuming that the slash keeps getting dropped between Microsoft and .NETFramework).
To be clear, those keys should exist?

I'm curious too. I've seen it locally while debugging and can reproduce it consistently through at least one particular code path. Let me re-read our conversation so far and take a look at the other server this may be occurring on to make sure it looks like the exact same thing. I'll reach out and let you know how that goes.

I do not have either SchUseStrongCrypto or SystemDefaultTlsVersions in either of those locations (assuming that the slash keeps getting dropped between Microsoft and .NETFramework).

Yes, sorry, the slash was dropped - fixed above.

To be clear, those keys should exist?

They have to exist IF you target 4.5.2 or lower. Otherwise NOT having them is ok.

@karelz:
Turns out the debugger (VS 2015) seems to be forcing SecurityProtocol to "Ssl, Tls". When I run the apps from the command line directly, they all produce SystemDefault--when I debug them, they all show "Ssl, Tls". So now I'm not at all sure if there's even an issue (except that it would be nice to have SystemDefault even when debugging, but I read something indicating that was fixed for VS 2017 at some point).
If I do determine that there is still some weirdness here, I'll reach out to you via email.
Thanks for all of your help!

Oh, VS 2015 is ancient ... I bet it has its own config, targets older version of .NET Framework (<=4.5.2) and therefore you have to set the reg keys I linked above to 1.
Can you try to set the reg keys above to 1 and confirm it works?
Should I take it as confirmation that your original problem was only under debugger? That you did NOT see TLS downgrade in production of your services?

@karelz I set the registry keys as described and both the console app and our own application now show "SystemDefault" while debugging, so you're right; those values need to be set for VS 2015--great call!
We had a report of a TLS issue in a production service (and have seen a spike in "Could not create SSL/TLS secure channel." messages while communicating with a third party's API since late last year). Unfortunately, the VS 2015 confusion caused us to believe we were able to consistently reproduce the production TLS issue. So Friday was a bit of a wash for us, I'm afraid, and it looks like we're back to square one on the original production issue.

@pete-bloomerang glad you identified at least part of the problem (on dev machines under debugger).
Let me know once you find more about your production issue ...

Looks like not enough info to troubleshoot. Closing.
If there is evidence pointing to weird unexpected behavior, feel free to reopen.

authors: baschlegel karelz nakarnam pete-bloomerang

repo: microsoft/dotnet


text:
Create C4BB initial files for testing

Description
Create test files to load search parameters and profiles for C4BB and create resources to test
Related issues
N/A
Testing
Manual & touchstone
FHIR Team Checklist

[X] Update the title of the PR to be succinct and less than 50 characters
[X] Add a milestone to the PR for the sprint that it is merged (i.e. add S47)
[X] Tag the PR with the type of update: Bug, Dependencies, Enhancement, or New-Feature
[X] Tag the PR with Azure API for FHIR if this will release to the managed service
Review squash-merge requirements

Semver Change (docs)
Skip

@Ivanidzo4ka - Third times the charm? :)

/azp

/azp run

/azp

/azp run

/azp run

repo: microsoft/fhir-server


text:
PowerBI Template App for MCA

📝 Scenario
the template app in PowerBI looks like a really useful feature. It seems only to work for EA agreements: https://microsoft.github.io/finops-toolkit/power-bi/template-app
Is there a timeline when this will be available for MCA as well?
🙋♀ Ask for the community

We could use your help:

Please vote this issue up (👍) to prioritize it.
Leave comments to help us solidify the vision.

That Power BI report is a copy of the Cost Management template app for EA accounts. It uses data that is only available for EA and there is no direct parity with MCA.
Please use the Cost Management connector report, which does work for MCA. The connector report is the subset of the EA template app that works for both plus some updates that we added since then.
As an FYI, the Cost Management connector is no longer being maintained. The Cost Management team is moving to exports as the medium to build Power BI reports. We'll have a version of this in 0.5. This will be the recommended approach as the connector does not support savings plan reporting and has a lower threshold of cost that can be monitored due to Power BI data size ingestion limitations. For details, see Help me choose.

repo: microsoft/finops-toolkit


text:
Remove TableViewCellFileAccessoryView

Platforms Impacted

[ X] iOS
[ ] macOS

Description of changes
Removing the TableViewCellFileAccessoryView as it does align with the goal of this repository anymore.
Microsoft Reviewers: Open in CodeFlow

i would expect podspec file needs to be updated too

@harrieshin thanks for the tip!
I looked at the podspec and it seems like the only place for TableViewCellFileAccessoryView would be under Other Cells. But it seems like TableViewCellFileAccessoryView isnt specified directly. Or is there something else you are referring to that would need to change?

The PR check is failing because the TableViewCellFileAccessoryView XCUITest is still there. Delete TableViewCellFileAccessoryViewTest.swift and the check should pass.

@harrieshin / @joannaquu  could I please get a review on this PR?
@joannaquu and I discussed offline the failing build, which is unrelated to this change and is a non-required build to pass.

i don't understand why is this test failure not related? working-directory /Users/runner/work/fluentui-apple/fluentui-apple/ios/FluentUI.Demo -Xfrontend -serialize-debugging-options -experimental-emit-module-separately
2023-06-21T16:33:26.8501480Z error: Build input file cannot be found: '/Users/runner/work/fluentui-apple/fluentui-apple/ios/FluentUI.Demo/FluentUIDemoTests/TableViewCellFileAccessoryViewTest.swift'. Did you forget to declare this file as an output of a script phase or custom build rule which produces it? (in target 'FluentUIDemoTests' from project 'FluentUI.Demo')

Alex had mentioned some Avatar tests failing which were unrelated. As for the current test failure, my hunch is there is some script running on GitHub that'll be updated once this is merged and the test file is removed. The yml file runs all of the tests at once, not specific tests so there shouldn't be anything else to update. However, we've never removed a test before so I'm not completely sure.

authors: alexanderboswell harrieshin joannaquu

repo: microsoft/fluentui-apple


text:
use kube-batch scheduling batch job

integration kube-batch gang scheduling, queue scheduling, priority scheduling strategy to scheduling batch job.

@ruanxingbaozi
Thanks for this big PR :), will take it a look later.
BTW, have you checked the HivedScheduler (HS) in the Recommended Kubernetes Scheduler Section? :
https://github.com/microsoft/frameworkcontroller#recommended-kubernetes-scheduler
It also supports gang (i.e. take the whole job as into one cell in HS), queue (i.e. cell's virtual cluster in HS) and priority (i.e. cell's priority in HS) scheduling.
Besides, it also supports GPU topology aware scheduling, very very few resource fragmentation and even if fragmentation will never hurt queue capacity.
FrameworkController(FC) can intergate with HS seamlessly, but FC does not really aware HS and have not made any code changes to adapt it.
So, why we have to make FC code changes to adapt kube-batch?
Why not take the same apporach as FC intergate with HS (i.e. a top layer service leverage both FC and HS, and when it submits a framework, it will generate the scheduling spec inside the framework spec)?
Please check FC and HS intergation examples in:
https://github.com/microsoft/frameworkcontroller/blob/master/example/framework/scenario/tensorflow/gpu/tensorflowdistributedtrainingwithhivedscheduledgpu.yaml
and
https://github.com/microsoft/pai/blob/c6c216473a631f22b066d1547ef0f709f4aaaddf/subprojects/GOPATH/src/github.com/microsoft/hivedscheduler/example/request/design/request.yaml#L132

"ignore": "",

Why add so many vendors? Did you use the Gopkg.toml in our project?

Refers to: vendor/vendor.json:3 in ec5ed29. [](commit_id = ec5ed2953d4df906dfe25cedd3f817cf7a109161, deletion_comment = False)

Thanks for your reply, The reason why kube-batch is used is because some extensions have been made on kube-batch, so I hope that FrameworkController will adapt kube-batch.In addition, the HivedScheduler project has done some abstract design, which is closer to some of Hadoop's design, and the migration of the strategy on kube-batch to HivedScheduler will do more work.

"ignore": "",

Why add so many vendors? Did you use the Gopkg.toml in our project?
Refers to: vendor/vendor.json:3 in ec5ed29. [](commit_id = ec5ed29, deletion_comment = False)

sorry,I am using govendor, dep is too slow, I will update it.

FrameworkController(FC) can intergate with HS seamlessly, but FC does not really aware HS and have not made any code changes to adapt it.
So, why we have to make FC code changes to adapt kube-batch?
Why not take the same apporach as FC intergate with HS (i.e. a higher level component leverage both FC and HS, and when it submits a framework, it will auto generate the scheduling spec inside the framework spec)?

FrameworkController(FC) can intergate with HS seamlessly, but FC does not really aware HS and have not made any code changes to adapt it.
So, why we have to make FC code changes to adapt kube-batch?
Why not take the same apporach as FC intergate with HS (i.e. a higher level component leverage both FC and HS, and when it submits a framework, it will auto generate the scheduling spec inside the framework spec)?

Ok, I agree to do these things at a higher level component .I will try to use HS

I just propose the intergation approach with kube-batch, and it is fine to still use kube-batch if you need its dedicated features. Check intergation examples in my first comment.

I just propose the intergation approach with kube-batch, and it is fine to still use kube-batch if you need its dedicated features. Check intergation examples in my first comment.

thanks，I understand what you mean by adapting kube-batch in the rest-server instead of in the frameworkcontroller.

yeap :) The rest server may not have to be the PAI rest server, it can be any your own service or client.

authors: ruanxingbaozi yqwang-ms

repo: microsoft/frameworkcontroller


text:
Fix CR/LF using dos2unix utility

Follow up from https://github.com/kubernetes/kubernetes/pull/127713/#issuecomment-2383191880

would adding a root .gitattributes file pinning EOL to LF help as well?
e.g. https://github.com/kubernetes/kubernetes/commit/e9b35e7a3ea5a4a456bc7147d12bea0530e52db1

would adding a root .gitattributes file pinning EOL to LF help as well?

good point @liggitt doing that now!

lgtm

authors: dims kiashok liggitt

repo: microsoft/hnslib


text:
support for consumer device to support volume control

Volume control is done via a HID consumer device. page 120 or so.
https://www.usb.org/sites/default/files/hut1_21_0.pdf

@pelikhan - does this necessitate change to services, as well as firmware?

authors: pelikhan tballmsft

repo: microsoft/jacdac


text:
Device: M.Klein Calliogamer v1.0

This pull request will start the registration of your device in the Jacdac catalog.

@tballmsft

authors: MKleinSB pelikhan


text:
Using the Semantic Kernel plugin raises the error "System.Collections.Generic.KeyNotFoundException: 'The given key 'url' was not present in the dictionary.'"

I have two projects:

One that, using Kernel Memory, stores documents as embeddings into Azure AI Search
One, based on Semantic Kernel, that I want to use to ask questions about documents that I have stored using the first project

I don't know if the problem is because I'm using the RC version of Semantic Kernel, which is a bit unstable these days (more precisely, RC3), but as soon as the Ask function from the Semantic Kernel plugin is invoked, the operation always throws the following exception:
System.Collections.Generic.KeyNotFoundException:` 'The given key 'url' was not present in the dictionary.'

This is the code I'm using:
string apiKey = configuration["AzureOpenAI:ApiKey"];
string deploymentChatName = configuration["AzureOpenAI:DeploymentChatName"];
string deploymentEmbeddingName = configuration["AzureOpenAI:DeploymentEmbeddingName"];
string endpoint = configuration["AzureOpenAI:Endpoint"];

string searchApiKey = configuration["AzureSearch:ApiKey"];
string searchEndpoint = configuration["AzureSearch:Endpoint"];

var embeddingConfig = new AzureOpenAIConfig
{
    APIKey = apiKey,
    Deployment = deploymentEmbeddingName,
    Endpoint = endpoint,
    APIType = AzureOpenAIConfig.APITypes.EmbeddingGeneration,
    Auth = AzureOpenAIConfig.AuthTypes.APIKey
};

var chatConfig = new AzureOpenAIConfig
{
    APIKey = apiKey,
    Deployment = deploymentChatName,
    Endpoint = endpoint,
    APIType = AzureOpenAIConfig.APITypes.ChatCompletion,
    Auth = AzureOpenAIConfig.AuthTypes.APIKey
};

var kernelMemory = new KernelMemoryBuilder()
    .WithAzureOpenAITextGeneration(chatConfig)
    .WithAzureOpenAITextEmbeddingGeneration(embeddingConfig)
    .WithAzureAISearch(searchEndpoint, searchApiKey)
    .Build();

var kernel = new KernelBuilder()
    .AddAzureOpenAIChatCompletion(deploymentChatName, deploymentChatName, endpoint, apiKey)
    .Build();

var plugin = new MemoryPlugin(kernelMemory, waitForIngestionToComplete: true);
kernel.ImportPluginFromObject(plugin, "memory");

var prompt = @"
            Question to Kernel Memory: What is Contoso Electronics?

            Kernel Memory Answer: {{memory.ask What is Contoso Electronics?}}

            If the answer is empty say 'I don't know' otherwise reply with a preview of the answer, truncated to 15 words.
            ";

OpenAIPromptExecutionSettings settings = new()
{
    FunctionCallBehavior = FunctionCallBehavior.EnableKernelFunctions,
};

var chatHistory = new ChatHistory();
chatHistory.AddUserMessage(prompt);

var chatCompletionService = kernel.GetRequiredService<IChatCompletionService>();
var result = await chatCompletionService.GetChatMessageContentAsync(chatHistory, settings, kernel);

//as long as the content is null, it means that the chat completion service is waiting for a function call to be processed
var functionCall = ((OpenAIChatMessageContent)result).GetOpenAIFunctionResponse();
while (functionCall != null)
{
    KernelFunction pluginFunction;
    KernelArguments arguments;
    kernel.Plugins.TryGetFunctionAndArguments(functionCall, out pluginFunction, out arguments);
    var functionResult = await kernel.InvokeAsync(pluginFunction!, arguments!);
    var jsonResponse = functionResult.GetValue<string>();
    chatHistory.AddFunctionMessage(jsonResponse, pluginFunction.Name);

    result = await chatCompletionService.GetChatMessageContentAsync(chatHistory, settings, kernel);

    //as long as the content is null, it means that the chat completion service is waiting for a function call to be processed
    functionCall = ((OpenAIChatMessageContent)result).GetOpenAIFunctionResponse();
}

Console.WriteLine(result.Content);
Console.ReadLine();

The problem is triggered by this line of code inside the loop:
 var functionResult = await kernel.InvokeAsync(pluginFunction!, arguments!);

I can see that Semantic Kernel has properly figured out that it need to use the Ask function from the Kernel Memory plugin and that the argument to pass is the question in my prompt "What is Contoso Electronics?". However, when the function is called through InvokeAsync(), I always get that exception.
As a reference, I used manual function calling with EnableKernelFunctions to better diagnose what's going on. I can simplify the code this way, but I'm getting the same exception:
var prompt = @"
            Question to Kernel Memory: {{$input}}

            Kernel Memory Answer: {{memory.ask $input}}

            If the answer is empty say 'I don't know' otherwise reply with a preview of the answer, truncated to 15 words.
            ";

OpenAIPromptExecutionSettings settings = new()
{
    FunctionCallBehavior = FunctionCallBehavior.AutoInvokeKernelFunctions,
};

KernelArguments arguments = new KernelArguments(settings)
{
    { "input", "What is Contoso Electronics?" },
};

var response = await kernel.InvokePromptAsync(prompt, arguments);

Console.WriteLine(response.GetValue<string>());
Console.ReadLine();

If it's a problem connected to the RC status of Semantic Kernel no worries, but I wanted to open an issue to track it and make sure that it doesn't slip once 1.0 gets released 😊
Package versions:
<PackageReference Include="Microsoft.KernelMemory.Core" Version="0.21.231214.1" />
<PackageReference Include="Microsoft.KernelMemory.SemanticKernelPlugin" Version="0.21.231214.1" />
<PackageReference Include="Microsoft.SemanticKernel" Version="1.0.0-rc3" />

Thank you @qmatteoq - I believe this might be connected to https://github.com/microsoft/kernel-memory/issues/205 and both should be addressed next week when SK v1.0 is released.

could you double check which version of SK you are using? if you are on SK RC3, your scenario should work. See this notebook https://github.com/microsoft/kernel-memory/blob/main/examples/000-notebooks/002-semantic-kernel-plugin.ipynb for example

I created a new empty project, copied and ran your code and I see output below, everything seems to work fine.
info: Microsoft.KernelMemory.Handlers.TextExtractionHandler[0]
      Handler 'extract' ready
info: Microsoft.KernelMemory.Handlers.TextPartitioningHandler[0]
      Handler 'partition' ready
info: Microsoft.KernelMemory.Handlers.SummarizationHandler[0]
      Handler 'summarize' ready
info: Microsoft.KernelMemory.Handlers.GenerateEmbeddingsHandler[0]
      Handler 'gen_embeddings' ready, 1 embedding generators
info: Microsoft.KernelMemory.Handlers.SaveRecordsHandler[0]
      Handler save_records ready, 1 vector storages
info: Microsoft.KernelMemory.Handlers.DeleteDocumentHandler[0]
      Handler 'private_delete_document' ready
info: Microsoft.KernelMemory.Handlers.DeleteIndexHandler[0]
      Handler 'private_delete_index' ready
info: Microsoft.KernelMemory.Handlers.DeleteGeneratedFilesHandler[0]
      Handler 'delete_generated_files' ready
info: Microsoft.KernelMemory.Pipeline.BaseOrchestrator[0]
      Queueing upload of 1 files for further processing [request ce01]
info: Microsoft.KernelMemory.Pipeline.BaseOrchestrator[0]
      File uploaded: content.txt, 449 bytes
info: Microsoft.KernelMemory.Pipeline.BaseOrchestrator[0]
      Handler 'extract' processed pipeline 'default/ce01' successfully
info: Microsoft.KernelMemory.Pipeline.BaseOrchestrator[0]
      Handler 'partition' processed pipeline 'default/ce01' successfully
info: Microsoft.KernelMemory.Pipeline.BaseOrchestrator[0]
      Handler 'gen_embeddings' processed pipeline 'default/ce01' successfully
info: Microsoft.KernelMemory.Pipeline.BaseOrchestrator[0]
      Handler 'save_records' processed pipeline 'default/ce01' successfully
info: Microsoft.KernelMemory.Pipeline.BaseOrchestrator[0]
      Pipeline 'default/ce01' complete
Contoso Electronics is a cutting-edge technology company that specializes in designing and manufacturing consumer electronics and smart devices. They are known for their innovative and sleek product lineup.

Project:
<Project Sdk="Microsoft.NET.Sdk">

    <PropertyGroup>
        <OutputType>Exe</OutputType>
        <TargetFramework>net6.0</TargetFramework>
        <ImplicitUsings>enable</ImplicitUsings>
        <Nullable>enable</Nullable>
        <ManagePackageVersionsCentrally>false</ManagePackageVersionsCentrally>
        <NoWarn>CA2007</NoWarn>
    </PropertyGroup>

    <ItemGroup>
      <None Remove=".env" />
      <Content Include=".env">
        <CopyToOutputDirectory>Always</CopyToOutputDirectory>
      </Content>
    </ItemGroup>

    <ItemGroup>
      <PackageReference Include="Microsoft.KernelMemory.Core" Version="0.21.231214.1"/>
      <PackageReference Include="Microsoft.KernelMemory.SemanticKernelPlugin" Version="0.21.231214.1"/>
      <PackageReference Include="Microsoft.SemanticKernel" Version="1.0.0-rc3"/>
      <PackageReference Include="dotenv.net" Version="3.1.3"/>
    </ItemGroup>

</Project>

Code:
// Copyright (c) Microsoft. All rights reserved.

using Microsoft.KernelMemory;
using Microsoft.SemanticKernel;
using Microsoft.SemanticKernel.AI.ChatCompletion;
using Microsoft.SemanticKernel.Connectors.AI.OpenAI;

// =============
// == SETUP
// =============

dotenv.net.DotEnv.Load();
var env = dotenv.net.DotEnv.Read();

var embeddingConfig = new AzureOpenAIConfig
{
    Endpoint = env["AZURE_OPENAI_EMBEDDING_ENDPOINT"],
    APIKey = env["AZURE_OPENAI_EMBEDDING_API_KEY"],
    Deployment = env["AZURE_OPENAI_EMBEDDING_DEPLOYMENT"],
    APIType = AzureOpenAIConfig.APITypes.EmbeddingGeneration,
    Auth = AzureOpenAIConfig.AuthTypes.APIKey
};

var chatConfig = new AzureOpenAIConfig
{
    Endpoint = env["AZURE_OPENAI_CHAT_ENDPOINT"],
    APIKey = env["AZURE_OPENAI_CHAT_API_KEY"],
    Deployment = env["AZURE_OPENAI_CHAT_DEPLOYMENT"],
    APIType = AzureOpenAIConfig.APITypes.ChatCompletion,
    Auth = AzureOpenAIConfig.AuthTypes.APIKey
};

var kernelMemory = new KernelMemoryBuilder()
    .WithAzureOpenAITextGeneration(chatConfig)
    .WithAzureOpenAITextEmbeddingGeneration(embeddingConfig)
    .WithAzureAISearch(env["AZURE_SEARCH_ENDPOINT"], env["AZURE_SEARCH_API_KEY"])
    .Build();

var kernel = new KernelBuilder()
    .AddAzureOpenAIChatCompletion(chatConfig.Deployment, chatConfig.Deployment, chatConfig.Endpoint, chatConfig.APIKey)
    .Build();

MemoryPlugin plugin = new MemoryPlugin(kernelMemory, waitForIngestionToComplete: true);

// ======================
// == IMPORT DATA
// ======================

await plugin.SaveAsync(
    "Contoso Electronics is a cutting-edge technology company at the forefront of innovation in the electronics industry. " +
    "Established in the visionary year of 2035, Contoso Electronics has rapidly become a global leader in designing and manufacturing state-of-the-art consumer electronics and smart devices. " +
    "With a mission to simplify and enhance daily life through technology, Contoso Electronics is renowned for its sleek and futuristic product lineup.",
    documentId: "ce01");

// ==============================
// == QUERY MEMORY WITH PLUGIN
// ==============================

kernel.ImportPluginFromObject(plugin, "memory");

var prompt = @"
            Question to Kernel Memory: What is Contoso Electronics?

            Kernel Memory Answer: {{memory.ask What is Contoso Electronics?}}

            If the answer is empty say 'I don't know' otherwise reply with a preview of the answer, truncated to 15 words.
            ";

OpenAIPromptExecutionSettings settings = new()
{
    FunctionCallBehavior = FunctionCallBehavior.EnableKernelFunctions,
};

var chatHistory = new ChatHistory();
chatHistory.AddUserMessage(prompt);

var chatCompletionService = kernel.GetRequiredService<IChatCompletionService>();
var result = await chatCompletionService.GetChatMessageContentAsync(chatHistory, settings, kernel);

//as long as the content is null, it means that the chat completion service is waiting for a function call to be processed
var functionCall = ((OpenAIChatMessageContent)result).GetOpenAIFunctionResponse();
while (functionCall != null)
{
    KernelFunction pluginFunction;
    KernelArguments arguments;
    kernel.Plugins.TryGetFunctionAndArguments(functionCall, out pluginFunction, out arguments);
    var functionResult = await kernel.InvokeAsync(pluginFunction!, arguments!);
    var jsonResponse = functionResult.GetValue<string>();
    chatHistory.AddFunctionMessage(jsonResponse, pluginFunction.Name);

    result = await chatCompletionService.GetChatMessageContentAsync(chatHistory, settings, kernel);

    //as long as the content is null, it means that the chat completion service is waiting for a function call to be processed
    functionCall = ((OpenAIChatMessageContent)result).GetOpenAIFunctionResponse();
}

Console.WriteLine(result.Content);
Console.ReadLine();

.env
MEMORY_API_KEY=...

AZURE_OPENAI_CHAT_ENDPOINT=https://....openai.azure.com/
AZURE_OPENAI_CHAT_API_KEY=...
AZURE_OPENAI_CHAT_DEPLOYMENT=gpt-35-turbo-16k

AZURE_OPENAI_EMBEDDING_ENDPOINT=https://....openai.azure.com/
AZURE_OPENAI_EMBEDDING_API_KEY=...
AZURE_OPENAI_EMBEDDING_DEPLOYMENT=text-embedding-ada-002

AZURE_SEARCH_ENDPOINT=https://....search.windows.net
AZURE_SEARCH_API_KEY=...

Thanks a lot @dluc and sorry for wasting your time! I figured out now what happened. My vector index was created with another web application, always based on Kernel Memory, but a quite older version (0.15). I've upgraded it to the latest version (matching this way the version I'm using in my console app with Semantic Kernel), I've recreated the index by reuploading the Contoso Electronics document and now everything works.
Thanks a ton!

no problem, I'll take the blame for the many backward incompatible changes :-) Glad all is working fine!

authors: dluc qmatteoq

repo: microsoft/kernel-memory


text:
Functional tests for Elasticsearch extension

Test coverage for third party extension

Currently tests are failing /cc @afederici75


text:
Extra comma in serialized json output

When serializing an object that has a nested object, and setting the nested object to undefined, we're getting an extra comma in the serialized output:
const updateWidgetRequest: UpdateWidgetRequest = {
  name: 'Sproket',
  size: 5,
  inspectionDetails: undefined,
};

const jsonSerializationWriter = new JsonSerializationWriter();

jsonSerializationWriter.writeObjectValue(
  undefined,
  updateWidgetRequest,
  serializeUpdateWidgetRequest
);

const jsonBuffer = jsonSerializationWriter.getSerializedContent();
const decoder = new TextDecoder('utf-8');
const json = decoder.decode(jsonBuffer);

console.log(json);

The logged json will have:
{,"name":"Sproket","size":5}
The serializeUpdateWidgetRequest function is from the generated code.

Hi @mbursill
Thanks for using kiota and for reaching out.
Can you make the following change:
-jsonSerializationWriter.writeObjectValue(
-  undefined,
-  updateWidgetRequest,
-  serializeUpdateWidgetRequest
-);
+serializeUpdateWidgetRequest(jsonSerializationWriter, updateWidgetRequest);

And see whether that solves your issue?

The output in this case would be:
,"name":"Sproket","size":5,
It's worth noting that the issue happens when making an endpoint call that sends the root object. If I capture the traffic it looks like this:

The schema:
swagger.json
It was tested on Kiota 1.13, 1.14 and the latest preview.

Thanks for the additional information.
Are you generating with or without the backing store?
Seems related to #1190

closing as duplicate of #1190

authors: baywet mbursill

repo: microsoft/kiota-typescript


text:
error "sslv3 alert handshake failure" on access attempt to vscode yum repos

on
	lsb_release -rd
		Description:    Fedora release 38 (Thirty Eight)
		Release:        38

with
	rpm -qa | grep -i ^code
		code-1.81.1-1691620770.el7.x86_64

previously installed from repo,
	cat /etc/yum.repos.d/vscode.repo
		[code]
		name=Visual Studio Code
		baseurl=https://packages.microsoft.com/yumrepos/vscode
		enabled=1
		gpgcheck=1
		gpgkey=https://packages.microsoft.com/keys/microsoft.asc

on update, FAILs
	dnf update
		...
		Visual Studio Code                                                            0.0  B/s |   0  B     00:00
		Errors during downloading metadata for repository 'code':
		  - Curl error (35): SSL connect error for https://packages.microsoft.com/yumrepos/vscode/repodata/repomd.xml [OpenSSL/3.0.9: error:0A000410:SSL routines::sslv3 alert handshake failure]
		Error: Failed to download metadata for repo 'code': Cannot download repomd.xml: Cannot download repodata/repomd.xml: All mirrors were tried
		Ignoring repositories: code
		...

checking
	curl -v https://packages.microsoft.com/yumrepos/vscode/repodata/repomd.xml
		* processing: https://packages.microsoft.com/yumrepos/vscode/repodata/repomd.xml
		*   Trying 40.117.131.251:443...
		* Connected to packages.microsoft.com (40.117.131.251) port 443
		* ALPN: offers h2,http/1.1
		* TLSv1.3 (OUT), TLS handshake, Client hello (1):
		*  CAfile: /etc/pki/tls/certs/ca-bundle.crt
		*  CApath: /etc/ssl/certs
		* TLSv1.3 (IN), TLS alert, handshake failure (552):
		* OpenSSL/3.0.9: error:0A000410:SSL routines::sslv3 alert handshake failure
		* Closing connection
		curl: (35) OpenSSL/3.0.9: error:0A000410:SSL routines::sslv3 alert handshake failure

comparing
	curl -v https://download.virtualbox.org/virtualbox/rpm/fedora/36/x86_64/repodata/repomd.xml
		* processing: https://download.virtualbox.org/virtualbox/rpm/fedora/36/x86_64/repodata/repomd.xml
		*   Trying 23.215.200.105:443...
		* Connected to download.virtualbox.org (23.215.200.105) port 443
		* ALPN: offers h2,http/1.1
		* TLSv1.3 (OUT), TLS handshake, Client hello (1):
		*  CAfile: /etc/pki/tls/certs/ca-bundle.crt
		*  CApath: /etc/ssl/certs
		* TLSv1.3 (IN), TLS handshake, Server hello (2):
		* TLSv1.3 (OUT), TLS change cipher, Change cipher spec (1):
		* TLSv1.3 (OUT), TLS handshake, Client hello (1):
		...
		(success)
		* Connection #0 to host download.virtualbox.org left intact

@pgnd,
Apologies that you're encountering issues here.

I'm unable to repro your error on Fedora 38. The download occurs with no errors in my testing, using the latest fedora:38 container image with no modifications.
From the output, it looks like your client may be forcing the use of TLSv1.3, which may be contributing to the error.
Could you try running your command against our beta instance, and see if it repros?
curl -v https://beta.packages.microsoft.com/yumrepos/vscode/repodata/repomd.xml

@mbearup
tls v1.3 @ ms
curl -v https://packages.microsoft.com/yumrepos/vscode/repodata/repomd.xml
	* processing: https://packages.microsoft.com/yumrepos/vscode/repodata/repomd.xml
	*   Trying 13.90.56.68:443...
	* Connected to packages.microsoft.com (13.90.56.68) port 443
	* ALPN: offers h2,http/1.1
	* TLSv1.3 (OUT), TLS handshake, Client hello (1):
	*  CAfile: /etc/pki/tls/certs/ca-bundle.crt
	*  CApath: /etc/ssl/certs
	* TLSv1.3 (IN), TLS alert, handshake failure (552):
	* OpenSSL/3.0.9: error:0A000410:SSL routines::sslv3 alert handshake failure
	* Closing connection
	curl: (35) OpenSSL/3.0.9: error:0A000410:SSL routines::sslv3 alert handshake failure

curl -v https://beta.packages.microsoft.com/yumrepos/vscode/repodata/repomd.xml
	* processing: https://beta.packages.microsoft.com/yumrepos/vscode/repodata/repomd.xml
	*   Trying 20.221.151.72:443...
	* Connected to beta.packages.microsoft.com (20.221.151.72) port 443
	* ALPN: offers h2,http/1.1
	* TLSv1.3 (OUT), TLS handshake, Client hello (1):
	*  CAfile: /etc/pki/tls/certs/ca-bundle.crt
	*  CApath: /etc/ssl/certs
	* TLSv1.3 (IN), TLS alert, handshake failure (552):
	* OpenSSL/3.0.9: error:0A000410:SSL routines::sslv3 alert handshake failure
	* Closing connection
	curl: (35) OpenSSL/3.0.9: error:0A000410:SSL routines::sslv3 alert handshake failure

tls v1.2 @ ms
curl --tlsv1.2 --tls-max 1.2 -v https://packages.microsoft.com/yumrepos/vscode/repodata/repomd.xml
	* processing: https://packages.microsoft.com/yumrepos/vscode/repodata/repomd.xml
	*   Trying 13.90.56.68:443...
	* Connected to packages.microsoft.com (13.90.56.68) port 443
	* ALPN: offers h2,http/1.1
	* TLSv1.2 (OUT), TLS handshake, Client hello (1):
	*  CAfile: /etc/pki/tls/certs/ca-bundle.crt
	*  CApath: /etc/ssl/certs
	* TLSv1.2 (IN), TLS alert, handshake failure (552):
	* OpenSSL/3.0.9: error:0A000410:SSL routines::sslv3 alert handshake failure
	* Closing connection
	curl: (35) OpenSSL/3.0.9: error:0A000410:SSL routines::sslv3 alert handshake failure

curl --tlsv1.2 --tls-max 1.2 -v https://beta.packages.microsoft.com/yumrepos/vscode/repodata/repomd.xml
	* processing: https://beta.packages.microsoft.com/yumrepos/vscode/repodata/repomd.xml
	*   Trying 20.221.151.72:443...
	* Connected to beta.packages.microsoft.com (20.221.151.72) port 443
	* ALPN: offers h2,http/1.1
	* TLSv1.2 (OUT), TLS handshake, Client hello (1):
	*  CAfile: /etc/pki/tls/certs/ca-bundle.crt
	*  CApath: /etc/ssl/certs
	* TLSv1.2 (IN), TLS alert, handshake failure (552):
	* OpenSSL/3.0.9: error:0A000410:SSL routines::sslv3 alert handshake failure
	* Closing connection
	curl: (35) OpenSSL/3.0.9: error:0A000410:SSL routines::sslv3 alert handshake failure

tls v1.2 @ oracle
curl --tlsv1.2 --tls-max 1.2 -v https://download.virtualbox.org/virtualbox/rpm/fedora/36/x86_64/repodata/repomd.xml
	* processing: https://download.virtualbox.org/virtualbox/rpm/fedora/36/x86_64/repodata/repomd.xml
	*   Trying 23.45.32.76:443...
	* Connected to download.virtualbox.org (23.45.32.76) port 443
	* ALPN: offers h2,http/1.1
	* TLSv1.2 (OUT), TLS handshake, Client hello (1):
	*  CAfile: /etc/pki/tls/certs/ca-bundle.crt
	*  CApath: /etc/ssl/certs
	* TLSv1.2 (IN), TLS handshake, Server hello (2):
	* TLSv1.2 (IN), TLS handshake, Certificate (11):
	* TLSv1.2 (IN), TLS handshake, Server key exchange (12):
	* TLSv1.2 (IN), TLS handshake, Server finished (14):
	* TLSv1.2 (OUT), TLS handshake, Client key exchange (16):
	* TLSv1.2 (OUT), TLS change cipher, Change cipher spec (1):
	* TLSv1.2 (OUT), TLS handshake, Finished (20):
	* TLSv1.2 (IN), TLS handshake, Finished (20):
	* SSL connection using TLSv1.2 / ECDHE-ECDSA-CHACHA20-POLY1305
	* ALPN: server accepted http/1.1
	* Server certificate:
	*  subject: C=US; ST=California; L=Redwood City; O=Oracle Corporation; CN=download.oracle.com
	...

We've the packages.microsoft.com service infrastructure to offer TLSv1.3 (in addition to TLSv1.2) during HTTPS negotiation. Please open a new issue if you see this problem again (vs. reopening this issue).

@jasonzio
it's not just an issue of "offering" TLS 1.3/1.2
as above, it's also an issue of enabling key exchange groups beyond simply older/weaker secp384r1
the FAIL continues @ MS' servers as per OP if key exchange ciphers don't include it

@pgnd, thanks for validating and providing additional details.
Our ciphers and algorithms are governed by corporate policy, and I'm following up with our crypto experts for the latest guidance.   Will follow-up here when we have clarity, but I expect we'll be able to enable, at a minimum, secp521r1 and prime256v1.

@pgnd we've gotten approval to enable prime256v1 and X25519, and I've deployed these changes to beta.packages.microsoft.com. Could you confirm that https://beta.packages.microsoft.com/ now works for you? If so, we'll proceed to deploy these changes to our packages.microsoft.com mirrors.

@mbearup
confirming key exchange @ beta.packages.microsoft.com
x25519     OK
prime256v1 OK
x448       FAIL

ref: https://www.ietf.org/rfc/rfc8422.txt
detail
grep Groups /etc/ssl/openssl.cnf
	Groups = x25519

curl -v https://beta.packages.microsoft.com/yumrepos/vscode/repodata/repomd.xml
	* processing: https://beta.packages.microsoft.com/yumrepos/vscode/repodata/repomd.xml
	*   Trying 20.221.151.72:443...
	* Connected to beta.packages.microsoft.com (20.221.151.72) port 443
	* ALPN: offers h2,http/1.1
	* TLSv1.3 (OUT), TLS handshake, Client hello (1):
	*  CAfile: /etc/pki/tls/certs/ca-bundle.crt
	*  CApath: /etc/ssl/certs
	* TLSv1.3 (IN), TLS handshake, Server hello (2):
	* TLSv1.3 (IN), TLS handshake, Encrypted Extensions (8):
	* TLSv1.3 (IN), TLS handshake, Certificate (11):
	* TLSv1.3 (IN), TLS handshake, CERT verify (15):
	* TLSv1.3 (IN), TLS handshake, Finished (20):
	* TLSv1.3 (OUT), TLS change cipher, Change cipher spec (1):
	* TLSv1.3 (OUT), TLS handshake, Finished (20):
	* SSL connection using TLSv1.3 / TLS_AES_256_GCM_SHA384
	* ALPN: server accepted http/1.1
	* Server certificate:
	*  subject: C=US; ST=WA; L=Redmond; O=Microsoft Corporation; CN=beta.packages.microsoft.com
	...

grep Groups /etc/ssl/openssl.cnf
	Groups = prime256v1

curl -v https://beta.packages.microsoft.com/yumrepos/vscode/repodata/repomd.xml
	* processing: https://beta.packages.microsoft.com/yumrepos/vscode/repodata/repomd.xml
	*   Trying 20.221.151.72:443...
	* Connected to beta.packages.microsoft.com (20.221.151.72) port 443
	* ALPN: offers h2,http/1.1
	* TLSv1.3 (OUT), TLS handshake, Client hello (1):
	*  CAfile: /etc/pki/tls/certs/ca-bundle.crt
	*  CApath: /etc/ssl/certs
	* TLSv1.3 (IN), TLS handshake, Server hello (2):
	* TLSv1.3 (IN), TLS handshake, Encrypted Extensions (8):
	* TLSv1.3 (IN), TLS handshake, Certificate (11):
	* TLSv1.3 (IN), TLS handshake, CERT verify (15):
	* TLSv1.3 (IN), TLS handshake, Finished (20):
	* TLSv1.3 (OUT), TLS change cipher, Change cipher spec (1):
	* TLSv1.3 (OUT), TLS handshake, Finished (20):
	* SSL connection using TLSv1.3 / TLS_AES_256_GCM_SHA384
	* ALPN: server accepted http/1.1
	* Server certificate:
	*  subject: C=US; ST=WA; L=Redmond; O=Microsoft Corporation; CN=beta.packages.microsoft.com
	...

grep Groups /etc/ssl/openssl.cnf
	Groups = x448

curl -v https://beta.packages.microsoft.com/yumrepos/vscode/repodata/repomd.xml
	* processing: https://beta.packages.microsoft.com/yumrepos/vscode/repodata/repomd.xml
	*   Trying 20.252.182.97:443...
	* Connected to beta.packages.microsoft.com (20.252.182.97) port 443
	* ALPN: offers h2,http/1.1
	* TLSv1.3 (OUT), TLS handshake, Client hello (1):
	*  CAfile: /etc/pki/tls/certs/ca-bundle.crt
	*  CApath: /etc/ssl/certs
	* TLSv1.3 (IN), TLS alert, handshake failure (552):
	* OpenSSL/3.0.9: error:0A000410:SSL routines::sslv3 alert handshake failure
	* Closing connection
	curl: (35) OpenSSL/3.0.9: error:0A000410:SSL routines::sslv3 alert handshake failure

authors: jasonzio mbearup pgnd

repo: microsoft/linux-package-repositories


text:
npm-lsif fails in version 0.1.0

Running the tsc-lsif and npm-lsif tools version 0.1.0 fails on certain typescript repos with the following error:

..\node_modules\npm-lsif\lib\main.js:104
let outUri = this.mapToOut(document.uri);
^
TypeError: Cannot read property 'uri' of undefined
at ExportLinker.exports (C:\VSCloudKernel.jepetty\bin\LSIFLanguageServer\Debug\netcoreapp2.1\node_modules\npm-lsif\lib\main.js:104:45)
at Interface.rd.on (C:\VSCloudKernel.jepetty\bin\LSIFLanguageServer\Debug\netcoreapp2.1\node_modules\npm-lsif\lib\main.js:255:34)
at emitOne (events.js:116:13)
at Interface.emit (events.js:211:7)
at Interface._onLine (readline.js:280:10)
at Interface._normalWrite (readline.js:422:12)
at Socket.ondata (readline.js:139:10)
at emitOne (events.js:116:13)
at Socket.emit (events.js:211:7)
at addChunk (_stream_readable.js:263:12)
events.js:183
throw er; // Unhandled 'error' event
^
Error: EPIPE: broken pipe, write
at Socket._write (internal/net.js:23:7)
at doWrite (_stream_writable.js:396:12)
at writeOrBuffer (_stream_writable.js:382:5)
at Socket.Writable.write (_stream_writable.js:290:11)
at Socket.write (net.js:711:40)
at Object.emit (C:\VSCloudKernel.jepetty\bin\LSIFLanguageServer\Debug\netcoreapp2.1\node_modules\tsc-lsif\lib\emitters\line.js:14:19)
at Visitor.emit (C:\VSCloudKernel.jepetty\bin\LSIFLanguageServer\Debug\netcoreapp2.1\node_modules\tsc-lsif\lib\lsif.js:1321:22)
at Visitor.endVisitSourceFile (C:\VSCloudKernel.jepetty\bin\LSIFLanguageServer\Debug\netcoreapp2.1\node_modules\tsc-lsif\lib\lsif.js:1070:22)
at Visitor.doVisit (C:\VSCloudKernel.jepetty\bin\LSIFLanguageServer\Debug\netcoreapp2.1\node_modules\tsc-lsif\lib\lsif.js:994:18)
at Visitor.visit (C:\VSCloudKernel.jepetty\bin\LSIFLanguageServer\Debug\netcoreapp2.1\node_modules\tsc-lsif\lib\lsif.js:954:22)

The repo/pull request this repros on is https://github.com/vsls-contrib/pomodoro/pull/3/files and the command used to invoke the tools is node ..\tsc-lsif\lib\main.js -p C:\pomodoro\tsconfig.json --outputFormat=line | node .\lib\main.js -p C:/pomodoro/package.json

@jepetty works for me using latest on master. Produces
lsif.txt
which commit is the tool on you are using.

@jepetty are you still seeing this?

Closing as no longer reproducing

authors: dbaeumer jepetty

repo: microsoft/lsif-node