text:
TemporalFusionTransformerEstimator gives error with previously unseen categorical feature during prediction

Description
The torch version of TFT seemingly does not play well during prediction with previously unseen categorical feature values, in the example below I have a categrocial feature in my dataset color; which could take 2 categories during in the train dataset. I set the static_cardinalities accordingly implicitly from the train dataset. During prediction an additional category appears as in a cold-start like scenario, and the prediction generation fails with an IndexError as the input to the Embedding layer to get the embeddings has an additional index.
Maybe a possible workaround would be to set the cardinalities with additional possible values as [len(cats) + possible_new_cats for cats in stats.feat_static_cat], however that feels a bit leeky as well.
To Reproduce
import numpy as np
import pandas as pd
import pytorch_lightning as pl
from gluonts.dataset.pandas import PandasDataset
from gluonts.dataset.stat import calculate_dataset_statistics
from gluonts.evaluation import make_evaluation_predictions
from gluonts.torch import TemporalFusionTransformerEstimator

np.random.seed(42)
pl.seed_everything(42)
#%%
def generate_single_ts(date_range, item_id=None) -> pd.DataFrame:
    """create sum of `n_f` sin/cos curves with random scale and phase."""
    n_f = 2
    period = np.array([24 / (i + 1) for i in range(n_f)]).reshape(1, n_f)
    scale = np.random.normal(1, 0.3, size=(1, n_f))
    phase = 2 * np.pi * np.random.uniform(size=(1, n_f))
    periodic_f = lambda x: scale * np.sin(np.pi * x / period + phase)

    t = np.arange(0, len(date_range)).reshape(-1, 1)
    target = periodic_f(t).sum(axis=1) + np.random.normal(0, 0.1, size=len(t))
    ts = pd.DataFrame({"target": target}, index=date_range)
    if item_id is not None:
        ts["item_id"] = item_id
    return ts

def generate_single_ts_with_features(date_range, item_id) -> pd.DataFrame:

    ts = generate_single_ts(date_range, item_id)
    T = ts.shape[0]
    # static features are constant for each series
    ts["dynamic_real_1"] = np.random.normal(size=T)
    ts["dynamic_real_2"] = np.random.normal(size=T)
    # ... we can have as many static or dynamic features as we like
    return ts

#%%
prediction_length, freq = 24, "1H"
T = 15 * prediction_length
date_range = pd.date_range("2021-01-01", periods=T, freq=freq)
ts = generate_single_ts(date_range)

N = 15

multiple_ts = {
    i: generate_single_ts_with_features(date_range, item_id=i) for i in range(N)
}
static_features = pd.DataFrame(
    {
        "color": np.random.choice(["red", "green", "blue"], size=N),
        "height": np.random.normal(loc=100, scale=15, size=N),
    },
    index=list(multiple_ts.keys()),
)
multiple_ts_long = pd.concat(multiple_ts.values()).reset_index()
multiple_ts_long = multiple_ts_long.rename(columns={"index": "date"})
multiple_ts_long["dynamic_real_1"] = multiple_ts_long["dynamic_real_1"].astype(
    np.float32
)
multiple_ts_long["dynamic_real_2"] = multiple_ts_long["dynamic_real_2"].astype(
    np.float32
)
multiple_ts_long = multiple_ts_long.merge(
    static_features.reset_index(), how="left", right_on="index", left_on="item_id"
)
multiple_ts_long = multiple_ts_long.drop(columns="index")

#%%
# keep only the first 10*24 timesteps for training but without greens.
multiple_ts_long_train = multiple_ts_long[
    ~multiple_ts_long["color"].isin(["green"])
    & (multiple_ts_long["date"] < pd.to_datetime("2021-01-10"))
]
# cast to category
multiple_ts_long_train["color"] = multiple_ts_long_train["color"].astype("category")

# keep only the last 5*24 timesteps for testing but only greens.
greens = multiple_ts_long[
    multiple_ts_long["color"].isin(["green"])
    & (multiple_ts_long["date"] >= pd.to_datetime("2021-01-10"))
]
# all the blues and reds with full history for testing
blue_red = multiple_ts_long[multiple_ts_long["color"].isin(["blue", "red"])]

# concatenate the two test sets.
multiple_ts_long_test = pd.concat([blue_red, greens])
multiple_ts_long_test["color"] = multiple_ts_long_test["color"].astype("category")

#%%
# for long-dataset we use a different constructor and need a `item_id` column
multiple_ts_long_dataset_train = PandasDataset.from_long_dataframe(
    multiple_ts_long_train.set_index("date"),
    item_id="item_id",
    feat_dynamic_real=["dynamic_real_1", "dynamic_real_2"],
    static_feature_columns=["color"],
)
multiple_ts_long_dataset_test = PandasDataset.from_long_dataframe(
    multiple_ts_long_test.set_index("date"),
    item_id="item_id",
    feat_dynamic_real=["dynamic_real_1", "dynamic_real_2"],
    static_feature_columns=["color"],
)
#%%
stats = calculate_dataset_statistics(multiple_ts_long_dataset_train)
#%%
estimator = TemporalFusionTransformerEstimator(
    freq=freq,
    prediction_length=prediction_length,
    static_cardinalities=[len(cats) for cats in stats.feat_static_cat],
    batch_size=5,
    dynamic_dims=[1, 1],
    trainer_kwargs={"max_epochs": 3, "deterministic": True},
)
#%%
predictor = estimator.train(training_data=multiple_ts_long_dataset_train)
#%%
fss, tss = make_evaluation_predictions(
    predictor=predictor, dataset=multiple_ts_long_dataset_test, num_samples=2000
)
#%%
preds_list = list(fss)

Error message or code output
Traceback (most recent call last):
  File "/Users/guti1/.pyenv/versions/tft/lib/python3.9/site-packages/IPython/core/interactiveshell.py", line 3508, in run_code
    exec(code_obj, self.user_global_ns, self.user_ns)
  File "<ipython-input-75-e4c8290a6d4e>", line 1, in <module>
    preds_list = list(fss)
  File "/Users/guti1/.pyenv/versions/3.9.16/envs/tft/lib/python3.9/site-packages/gluonts/torch/model/predictor.py", line 85, in predict
    yield from self.forecast_generator(
  File "/Users/guti1/.pyenv/versions/3.9.16/envs/tft/lib/python3.9/site-packages/gluonts/model/forecast_generator.py", line 119, in __call__
    outputs = predict_to_numpy(prediction_net, inputs)
  File "/Users/guti1/.pyenv/versions/3.9.16/lib/python3.9/functools.py", line 888, in wrapper
    return dispatch(args[0].__class__)(*args, **kw)
  File "/Users/guti1/.pyenv/versions/3.9.16/envs/tft/lib/python3.9/site-packages/gluonts/torch/model/predictor.py", line 38, in _
    return prediction_net(*args).cpu().numpy()
  File "/Users/guti1/.pyenv/versions/3.9.16/envs/tft/lib/python3.9/site-packages/torch/nn/modules/module.py", line 1501, in _call_impl
    return forward_call(*args, **kwargs)
  File "/Users/guti1/.pyenv/versions/3.9.16/envs/tft/lib/python3.9/site-packages/gluonts/torch/model/tft/lightning_module.py", line 66, in forward
    return self.model(*args, **kwargs)
  File "/Users/guti1/.pyenv/versions/3.9.16/envs/tft/lib/python3.9/site-packages/torch/nn/modules/module.py", line 1501, in _call_impl
    return forward_call(*args, **kwargs)
  File "/Users/guti1/.pyenv/versions/3.9.16/envs/tft/lib/python3.9/site-packages/gluonts/torch/model/tft/module.py", line 312, in forward
    ) = self._preprocess(
  File "/Users/guti1/.pyenv/versions/3.9.16/envs/tft/lib/python3.9/site-packages/gluonts/torch/model/tft/module.py", line 284, in _preprocess
    embs = self.feat_static_embed(feat_static_cat)
  File "/Users/guti1/.pyenv/versions/3.9.16/envs/tft/lib/python3.9/site-packages/torch/nn/modules/module.py", line 1501, in _call_impl
    return forward_call(*args, **kwargs)
  File "/Users/guti1/.pyenv/versions/3.9.16/envs/tft/lib/python3.9/site-packages/gluonts/torch/model/tft/layers.py", line 26, in forward
    concat_features = super().forward(features=features)
  File "/Users/guti1/.pyenv/versions/3.9.16/envs/tft/lib/python3.9/site-packages/gluonts/torch/modules/feature.py", line 44, in forward
    [
  File "/Users/guti1/.pyenv/versions/3.9.16/envs/tft/lib/python3.9/site-packages/gluonts/torch/modules/feature.py", line 45, in <listcomp>
    embed(cat_feature_slice.squeeze(-1))
  File "/Users/guti1/.pyenv/versions/3.9.16/envs/tft/lib/python3.9/site-packages/torch/nn/modules/module.py", line 1501, in _call_impl
    return forward_call(*args, **kwargs)
  File "/Users/guti1/.pyenv/versions/3.9.16/envs/tft/lib/python3.9/site-packages/torch/nn/modules/sparse.py", line 162, in forward
    return F.embedding(
  File "/Users/guti1/.pyenv/versions/3.9.16/envs/tft/lib/python3.9/site-packages/torch/nn/functional.py", line 2210, in embedding
    return torch.embedding(weight, input, padding_idx, scale_grad_by_freq, sparse)
IndexError: index out of range in self

Environment

Operating system: MacOS
Python version: 3.9.16
GluonTS version: 0.12.7
MXNet version: 1.9.1
Torch version: 2.0.0

Have you checked if other models like DeepAR (PyTorch version) handle this differently? This looks like expected behavior to me.
If we include the extra categories when creating the model, but these categories are not present in the training set, the model won't learn meaningful embeddings for them.
My recommendation would be to implement a preprocessing step outside the model, where all categories not present in the training set are replaced by some dummy value (e.g., by the most frequent category in the training set).

Hi,
thanks for looking into it! Yes, the DeepAR with the pytorch backend behaves the same way, the MXnet version however does not have a problem with that scenario.

To me this looks like something that should be handled outside the models, as this is default behavior of torch.nn.Embedding and the user should themselves decide what strategy is appropriate for their use case (extra token for missing values, imputing mode, etc). Not sure how the MXNet deal with it. @lostella, what is your take on this?

I think the embedding silently handling new categorical values is a bug hidden waiting to be found, the way torch handles it makes much more sense to me. So probably yes, this is expected behaviour.

That sounds all reasonable, thanks for checking, I think we could close the issue than.

authors: guti1 lostella shchur

repo: awslabs/gluonts


text:
Restarting Logstash

Am I missing something or is it not possible for the dynamodb input plugin to only send newer items to elasticsearch? Right now all I can find is that it will duplicate items on each restart ...

@ahmedammar you need to set the perform_scan variable to false in the input plugin to prevent logstash scanning the entire table upon restarting.  Read the README here: https://github.com/awslabs/logstash-input-dynamodb

Thanks for the quick response, trust me I've read that README plenty of times :)
I guess I misunderstood the meaning and set it to 'true'. Just tried with 'false', seems to be working. Awesome thanks!

Sure, :+1:

source: gharchive/issue

authors: ahmedammar marcosnils

repo: awslabs/logstash-input-dynamodb

license_type: permissive

license_source: bigquery


text:
[uniffi] Expose RosterUpdate on Commit

Issues:
Addresses #81.
Description of changes:
More infrastructure to let us talk about roster updates on a group.
Call-outs:
The deep clones are potentially worry-some here. The clone in signing_identity is also annoying. I don't know if it'll be a problem yet, but because we cannot return borrowed data across the FFI boundary, this is probably the best we can do right now.
Testing:
New integration test.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT license.

See https://github.com/mozilla/uniffi-rs/issues/2043 for the problem of exposing PartialEq and friends via UniFFI — I don't think it's possible right now, but I would love to be proven wrong :smile:

See mozilla/uniffi-rs#2043 for the problem of exposing PartialEq and friends via UniFFI — I don't think it's possible right now, but I would love to be proven wrong 😄

This is fixed, thank to the help of @mhammond in the linked issue! :tada:

Codecov Report
Attention: Patch coverage is 94.44444% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 89.51%. Comparing base (5b83cac) to head (0d90266).

Files
Patch %
Lines

mls-rs-uniffi/src/lib.rs
94.44%
2 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #127      +/-   ##
==========================================
+ Coverage   89.49%   89.51%   +0.01%
==========================================
  Files         173      173
  Lines       31404    31438      +34
==========================================
+ Hits        28106    28141      +35
+ Misses       3298     3297       -1

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

source: gharchive/pull-request

authors: codecov-commenter mgeisler

repo: awslabs/mls-rs

license_source: github-api


text:
[Feature Request]DuckDB as another analytic engine for Deequ

Is your feature request related to a problem? Please describe.
Today, PyDeequ is a PySpark binding for Deequ which is in Scala and Spark only. While it is a good fit for DEs, Spark is not a great fit for many DS use-cases who will have datasets fit in memory and do not want to setup Spark.
See initial ideas here https://youtu.be/fvKFOfaLwBA?t=1393  from @sscdotopen.
Describe the solution you'd like
As discussed in above video, it would be good to create the proper abstractions to support another analytic engine. DuckDB who has gained popularity recently can be another analytic engine. The designs need more thoughts/discussion.

Hi, I am a PhD student who has worked with @sscdotopen on implementing this idea. The main challenge was indeed seperating the business logic from the execution engine. We published a workshop paper about that (https://ssc.io/pdf/duckdq.pdf) and released the source code here: https://github.com/tdoehmen/duckdq

@tdoehmen happy to hear from you! We will take a look at the paper and the repo. Will you be open to evolve/migrate some code to Pydeequ if that's the right thing to do?
In addition to bring another analytic engine, in general we want to improve the ergonomics of Deequ working for Python users.

For the business logic - execution engine separation, I think ibis could be an useful candidate to help. We might add a detailed write-up on design here.

I am a bit limited on time, but happy to look over a more detailed design. When parts of duckdq should make sense to be migrated I'm happy to help out. Just a few more random thoughts on the challenges involved in extending (py)deequ with another execution engine:

since pydeequ is mainly a wrapper around the original deequ scala library, in my eyes, changing the execution engine either requires far-reaching changes to the deequ scala codebase, or a (potentially more lightweight) replication of the deequ architecture inside the pydeequ library. In DuckDQ we went for the second approach. One reason that makes it hard to re-use the existing deequ codebase for another execution engine is that it heavily builds on Spark's DataFrame API rather than a more generic language such as SQL (or in the python world maybe something like ibis).
another thing to keep in mind is that some deequ analyzers need functionality that is not necessarily exposed by the execution engine. E.g. to compute the intermediate state for the stddev analyzer, we need the count, mean and dsquared value (see this DuckDB branch we did for this purpose https://github.com/tdoehmen/duckdb/commit/077129acea4efac936beea26348690f9b9c1a1e6). Same for Sketch-based analyzers like the ApproxQuantile and ApproxCountDistinct. In DuckDQ, we used apache-datasketches to compute these.
one other key design improvement we did in duckdq was to decouple state merging (engine-indepdent) from state computation (engine-dependent), which is kind of intermingled in the analyzers of the original deequ codebase and makes using different compute backends more complex than necessary because merging states is not computationally intensive (apart from edge cases like exact uniqueness). I dug out a more detailed architecture diagram of duckdq that shows the separtion more clearly. State Engine is the engine-agnostic part that can merge states (pure python, apart from sketch merging), and Base Engine is then quite straightforward to implement for any desired computational backend. E.g. we implemented a generic SQL engine based on SQLAlchemy, and a DuckDB SQL engine that exploits DuckDB-specifics like the stddev-extension and the zero-copy handover of Pandas DataFrames, which makes it very efficient to do data quality validation on them:

repo: awslabs/python-deequ


text:
upgrade to gradle 8.11.1

https://docs.gradle.org/8.11.1/release-notes.html
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
yes

This won't actually update gradlew on this repository. Wondering if you could send a new revision after running ./gradlew wrapper --gradle-version=8.11.1 on your locally checked out repository?

authors: domingosnovo sullis


text:
[Bug] Only certificate from us-east-1 is allowed

Describe the bug
When deploying service workbench in us-east-2 and a certificate from us-east-2, the installer complains that the certificate is not from us-east-1.
To Reproduce
Steps to reproduce the behavior:

regular installation process, with region set to us-east-2 and a certificate from us-east-2

Expected behavior
The certificate should be accepted, however, it now only works with another certificate created from us-esst-1, despite the fact that the cloud formation stack is created on us-east-2.
Screenshots

Versions (please complete the following information):

Release Version installed: 5.2.7
Is the deployment from a forked version of the repository? no

Hi @BoPeng! Thanks for the report!
Where are you specifying that you are deploying to us-east-2? I see that the full error link is in us-east-2, but can you check that the awsRegion and the certificateArn in your stage file (prod.yaml) specify us-east-2?
I also see that you are using the "default" AWS profile--is there a region specified in that profile in the .aws/config file?
Thanks,
Marianna

Is this because CloudFront always requires a certificate in us-east-1?

Oh @manics that seems right! Thanks for the input! According to this AWS Documentation, the cert must be created or imported to us-east-1. Here's some information on how to do that with your cert in us-east-2!
Thank you @manics! I'll mark a room for improvement for our documentation to mention this!
-Marianna

authors: BoPeng maghirardelli manics

repo: awslabs/service-workbench-on-aws


text:
Support granular control of specifying runtime crate versions

Motivation and Context
Related: https://github.com/awslabs/smithy-rs/issues/1416
Support a more granular control on specifying runtime crate versions in smithy-build.json runtime config.
The current behaviour is not ideal. You need to specify { version: "DEFAULT" } to get the default version. You can only specify the same version for all runtime crates, which is somehow inconvenient.
Description
This PR mainly deals with two things:

Make default default. You don't need to specify anything to become default.
Give users the ability to specify different versions for different runtime crates.

BREAKING: after this PR, in smity-build.json the path
rust-codegen.runtimeConfig.version no longer exists. Instead, a new
field versions comes in. It's an objct mapping a runtime crate name
to a version string. There is also a special key DEFAULT, which is
presetted as detected runtime version but open to override. Crates
without version specified would be set as the same version as which
associated to key DEFAULT.
An example smithy-build.json might look like:
{
  "version": "1.0",
  "projections": {
    "simple": {
      "plugins": {
        "rust-codegen": {
          "runtimeConfig": {
            "versions": {
               "DEFAULT": "0.48", // Set your own default version.
                                  // Leave blank for codegen auto-detecting a version.
               "aws-smithy-http": "0.47", // Can specify a different version.
               "aws-smithy-types": "0.46",
               "aws-smithy-json": "0.45",
            }
          },
          "service": ...
        }
      }
    }
  }
}

Testing
Tweak the value in buildSrc/src/main/kotlin/CodegenTestCommon.kt and see if your runtime crate version changed.
Checklist

[x] I have updated CHANGELOG.next.toml if I made changes to the smithy-rs codegen or runtime crates
[ ] I have updated CHANGELOG.next.toml if I made changes to the AWS SDK, generated SDK code, or SDK runtime crates

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Open question:

Shall we support more customizations such like setting relative path for each runtime crate?
Shall we be compatible with the old version field without breaking everyone's build script?

I'm thinking that it would also be cool if we allowed the user to specify concrete versions for third-party crates e.g. the http crate. That would allow them to mitigate a CVE-like situation by rolling back that crate version without us having to publish a new version of smithy-rs.
We can probably tackle it in another PR.

I'm thinking that it would also be cool if we allowed the user to specify concrete versions for third-party crates e.g. the http crate. That would allow them to mitigate a CVE-like situation by rolling back that crate version without us having to publish a new version of smithy-rs.

@jdisanti and I discussed this recently—I think it would be a great idea and it would also allow us to unify dependency versions across the entire codebase

Tests added. Thanks @david-perez for the suggestion.

If the user specifies a version in the versions map for a crate whose name does not correspond to a runtime crate, we fail.

This has yet been implemented. Shall we add the check?

If the user specifies a version in the versions map for a crate whose name does not correspond to a runtime crate, we fail.

This has yet been implemented. Shall we add the check?

We can leave it if you want. I was thinking that it would be a UX improvement (think a frustrated user who misspelled a crate name in the versions map and wondering why they're not seeing the override in the code generated crate).
But delivering this feature would entail us having to maintain a list of the crates that we're publishing and keeping it up to date when there are additions or removals. Unless we automate this check in CI, we're likely going to forget.

All review commented addressed. Thank you!

If the user specifies a version in the versions map for a crate whose name does not correspond to a runtime crate, we fail.

This has yet been implemented. Shall we add the check?

We can leave it if you want. I was thinking that it would be a UX improvement (think a frustrated user who misspelled a crate name in the versions map and wondering why they're not seeing the override in the code generated crate).
But delivering this feature would entail us having to maintain a list of the crates that we're publishing and keeping it up to date when there are additions or removals. Unless we automate this check in CI, we're likely going to forget.

That's exactly what I worry about. We could have a separate PR to do that if we want.

authors: david-perez rcoh weihanglo

repo: awslabs/smithy-rs


text:
Enable TurboRepo Cache with S3 in GitHub Actions

Issue #, if available:
Refs: https://github.com/ducktors/turborepo-remote-cache
Description of changes:
Enables TurboRepo Cache with S3 in GitHub Actions

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Caching is somehow not successful:
• Remote caching enabled
@smithy/types:build: cache miss, executing 85ce425152146037
@smithy/is-array-buffer:build: cache miss, executing c047473f8d8f07ea
...
 Tasks:    57 successful, 57 total
Cached:    0 cached, 57 total
  Time:    17m45.292s

Logs: https://github.com/awslabs/smithy-typescript/actions/runs/6340586590/job/17222319127?pr=972

repo: awslabs/smithy-typescript


text:
Add nil/zero slice check to gzip_zinfo

Signed-off-by: Jin Dong jindon@amazon.com
Issue #, if available:
Description of changes:
This change checks if slices are zero-length and return error if so. Otherwise the snapshotter will panic if a zero/nil slice is used when taking pointer of the slice. (for example, a ztoc with valid format but malicious data within it)
Testing performed:
make test && make check && make integration
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

LGTM. Can you add unit tests for this too?

LGTM. Can you add unit tests for this too?

How about creating an issue for this first? Currently gzip_zinfo doesn't have any unit test and I think we should add tests to it more thoroughly in a separate PR.
Also this change blocks #280. After adding integration test for #280, the error case triggers panic in gzip_zinfo instead of fuse operation failure.

LGTM. Can you add unit tests for this too?

How about creating an issue for this first? Currently gzip_zinfo doesn't have any unit test and I think we should add tests to it more thoroughly in a separate PR.
Also this change blocks #280. After adding integration test for #280, the error case triggers panic in gzip_zinfo instead of fuse operation failure.

You can at least add unit tests that test your changes in particular and create an issue to provide more extensive coverage. My guess, that writing unit tests for gzip_zinfo (within the new ticket) will not be high priority for a while and constantly be postponed, so having at least something for newly added code should definitely help.

LGTM. Can you add unit tests for this too?

How about creating an issue for this first? Currently gzip_zinfo doesn't have any unit test and I think we should add tests to it more thoroughly in a separate PR.
Also this change blocks #280. After adding integration test for #280, the error case triggers panic in gzip_zinfo instead of fuse operation failure.

You can at least add unit tests that test your changes in particular and create an issue to provide more extensive coverage. My guess, that writing unit tests for gzip_zinfo (within the new ticket) will not be high priority for a while and constantly be postponed, so having at least something for newly added code should definitely help.

SGTM. Will add some tests.

authors: djdongjin rdpsin vkuzniet

repo: awslabs/soci-snapshotter


text:
MOV files not supported?

Hi, I see that the whole suite works well when i place a .MP4 file to the Source Bucket. Roughly around 4 mins later i can see the 3 different types of Streamable CDN links.
However when I upload a .MOV file(i recorded a 1 minute video in my iPhone 6s(default settings) which is around 120MB, i dont see the workflow getting triggered at all! There is notification to my email.
Where can i find the Input video file types that are supported?

I digged a bit deeper to find out from the documentation that "it is not enough to place the video file alone but also a metadata file in the specific format!" Is this correct?
But this aws forum post says .MOV is already supported and I should in fact find a lambda on the source bucket Events configured already! Rightly so i did find it but still when i place the .MOV file i dont see the workflow triggering.
going deeper now ...

The list of supported formats is: mpg, mp4, m4v, mov, and m2ts. However, the extensions are case sensitive, so video.mov will start the workflow, but video.MOV will not.
For the second question, when you launch the template, there's a WorkflowTrigger parameter, and you can select one of these values:

VideoFile: With this option, all you have to do is upload a file to the S3 bucket.
MetadataFile: With this option, in addition to uploading the video file, you also have to upload a json file with the workflow details. The details are explained on the README file (https://github.com/awslabs/video-on-demand-on-aws#source-metadata-option)

You only have to upload a metadata file if you selected MetadataFile when creating the stack.

The list of supported formats is: mpg, mp4, m4v, mov, and m2ts. However, the extensions are case sensitive, so video.mov will start the workflow, but video.MOV will not.
For the second question, when you launch the template, there's a WorkflowTrigger parameter, and you can select one of these values:

VideoFile: With this option, all you have to do is upload a file to the S3 bucket.
MetadataFile: With this option, in addition to uploading the video file, you also have to upload a json file with the workflow details. The details are explained on the README file (https://github.com/awslabs/video-on-demand-on-aws#source-metadata-option)

You only have to upload a metadata file if you selected MetadataFile when creating the stack.

Awesome! Thanks these points helped a lot.

authors: dscpinheiro khazaddoom

repo: awslabs/video-on-demand-on-aws


text:
Nullable fields on Tortoise model are required in create route

Hello!, I have simple model with a nullable field:
from tortoise import fields, models

class Scan(models.Model):
    id = fields.IntField(pk=True)
    scan_data = fields.JSONField()
    time_stamp = fields.DatetimeField(auto_now=True, null=True)
    class Meta:
        table = "scans"

router = TortoiseCRUDRouter(
    schema=models.Scan_Pydantic,
    db_model=models.Scan
}

If I send some data to the post route, I expect that the "time_stamp" field will not need to be present in the payload because it is declared as nullable.
{
    "carrier": "FEDEX",
    "scan_data": {"scan_code":  "CD",  "scan_description":  "DELAY"}
}

but instead this fails with a 422 saying the "time_stamp" field is required.
I understand that adding the field with a null value work but I feel like declaring the field as nullable  on model should make the field optional entirely in body of create requests.
I'd be happy to submit a pr for this change if there is support for it ! :)

If you want to PR this you totally can. If not, I would be happy to pick up the implementation sometime in the future. This is somewhat related to #73

repo: awtkns/fastapi-crudrouter

license: MIT


text:
ShouldBindJSON修改为ShouldBind兼容json和form表单

func SignInRouter(c *gin.Context) {
var (
input SignInParams
err   error
res   = schema.Response{}
)
defer func() {
	if err != nil {
		res.Data = nil
		res.Message = err.Error()
	}
	c.JSON(http.StatusOK, res)
}()
**if err = c.ShouldBindJSON(&input);** err != nil {
	err = exception.InvalidParams
	return
}

res = SignIn(controller.NewContext(c), input)

}
在学习您的代码，ShouldBindJSON改为ShouldBind可以兼容前端json和form，会不会好一些

我是坚定的 json 派，form 和 xml 那种什么的老古董，不会支持的[手动狗头]

哦哦，明白

authors: axetroy dongshanlang

repo: axetroy/go-server


text:
Placeholder Styling Issue

This is a great package for React developers!
But there is an issue with placeholder, we cannot style the placeholder in case of any error like if there is a requirement that the multi email box is required, in this case placeholder will be showing and we can't style it. we need to fix it.

Sorry, i read the more documentation and found that it can accepts 'string | React.ReactNode' of type placeholder and we can handle the above case, so there is not any issue.

repo: axisj/react-multi-email


text:
Add (missing) parameter 'drawLineToCenter' to 'drawSolidCircle(...)'

Describe your changes
Add parameter drawLineToCenter to drawSolidCircle:

Issue ticket number and link
Checklist before requesting a review
For each PR

[ ] Add Copyright if it missed:
- "Copyright (c) 2019-present Axmol Engine contributors (see AUTHORS.md)."

[x] I have performed a self-review of my code.
Optional:

[ ] I have checked readme and add important infos to this PR.
[ ] I have added/adapted some tests too.

For core/new feature PR

[ ] I have checked readme and add important infos to this PR.
[ ] I have added thorough tests.

Add drawSolidTriangle(...)

@halx99
Please merge it.

repo: axmolengine/axmol


text:
fix unsupported maps warning message

fix #1081
the proposed solution is to remove the warning log and instead provide more meaningful information directly within the error itself.
without considering the issue, right now we have just a warning log (which contains the important information), but this is misleading since it actually leads to an error. I believe this can cause confusion because the critical details should be part of the error itself. For this reason I consolidated all the relevant information into the error message.
Additionally, I updated the map_type field type in Unsupported error fromu32 to bpf_map_type, as an unsupported map has a specific map type, which is distinct from a generic u32 used in cases like the InvalidMapType error.
PS: Regarding InvalidMapType and other map-related errors, I believe they should also include the names of the maps.

This change is

Thanks!

authors: banditopazzo tamird

repo: aya-rs/aya


text:
Implement FdLink conversions

Implement TryFrom functions to convert Fdlink to PerfLink/TracePointLink/ KprobeLink, and UprobeLink and vice-versa.
This allows us to pin taken links for perf programs, ultimately ensuring the link isn't dropped when the loading process exits.
Required for https://github.com/redhat-et/bpfd/issues/306
TODO: It'd be nice to add some documentation around this API somewhere...
    let mut bpf = BpfLoader::new()
    // load pinned maps from /sys/fs/bpf/my-program
    .map_pin_path("/sys/fs/bpf")
    // finally load the code
    .load_file("/home/astoycos/go/src/github.com/redhat-et/bpfd/examples/go-tracepoint-counter/bpf_bpfel.o")?;
    let program: &mut TracePoint = bpf.program_mut("tracepoint_kill_recorder").unwrap().try_into()?;
    program.load()?;
    let link_id = program.attach("syscalls", "sys_enter_kill")?;
    program.pin("/sys/fs/bpf/tracepoint_kill_recorder_pin")?;
    let owned_link: TracePointLink = program.take_link(link_id)?;
    let fd_link: FdLink = owned_link.try_into()?;
    fd_link.pin("/sys/fs/bpf/tracepoint_kill_recorder_link")?;

Hrm I don't know if this error is related:
Error: e: 19:33:45 [ERROR] llvm: Unknown attribute kind (86) (Producer: 'LLVM16.0.0-rust-1.70.0-nightly' Reader: 'LLVM 15.0.7')
          error: failure linking module /home/fedora/aya/test/integration-ebpf/../../target/bpfel-unknown-none/debug/deps/map_test-a9de5ef8344e854d.3hyxcigylsh430vj.rcgu.o
          19:33:45 [ WARN] ignoring file "/tmp/rustcIDSCW0/symbols.o": no embedded bitcode

error: could not compile `integration-ebpf` (bin "map_test") due to previous error

Sorry It's been so long @alessandrod I fixed the issues and added integration testing for TracePoint, Uprobe and Kprobe programs.  I'm happy to do it for perf_event progs here or in a follow up I'm just not 100% sure how to ATM and this is what I got to today.
@dave-tucker PTAL at how I also changed the integration test tooling to verify that a program is loaded AND linked in certain cases.

We could add docs here https://docs.aya-rs.dev/user/aya/programs/links/struct.fdlink? Explain that FdLink allows you to pin, and that many links can be converted to FdLink by using either into() or try_into(), giving examples of both.

Shoot and I still need to do this :)

Shoot and I still need to do this.

done

Poke @alessandrod :)

Rebased 👍

@tamird and I are working on redoing the integration test infrastructure such that the tests themselves do not rely on userspace to execute. Today the cycle time of compiling and running tests in the VM is less than wonderful. I chatted with @alessandrod about it here.
The preferred solution would be to have aya provide the relevant APIs for reading these links. If it's easy to implement the functionality you need in aya as opposed to shelling out, would you be open to it?

Hiya @ajwerner and yeah I totally agree, we need a loaded_links() API for bpfd regardless to go along with the work I did here: https://github.com/aya-rs/aya/pull/637
I'd rather go ahead and get this bit in for now since I've been carrying it for quite some time 😄 , but in the meantime I'll start working on a basic loaded_links() API.

can this just be assert_loaded followed by assert linked? i don't think we need to retry the bpftool invocation separately from waiting for loadedness

This is the only thing I didn't get to, simply because these functions are built as macros and if we were to reuse them I'd need to return the program id from assert_loaded().  This will change anyways with #645 so I think it's alright for now.

Whelp ended up having to rebase again :/

authors: ajwerner astoycos


text:
🛑 Sompo Sigorta is down

In e2d345b, Sompo Sigorta (https://www.somposigorta.com.tr/) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Sompo Sigorta is back up in b934d62 after 27 minutes.

repo: aydgn/upptime


text:
Auth fails with a 404 Error

Here is what I did:

install the wf
do a search
the wf request google drive access
I confirm
After click ALLOW, the browser opens http://127.0.0.1:1337/?code=<redacted> and fails with
{"statusCode":404,"error":"Not Found"}

Please include log as described here.
Please also state OS version, version of Alfred, and the browser you are using.

OS: OSX 10.13.1
Alfred 3.5.1 (883)
I use Chrome.
The logs are:
[2017-11-18 15:15:26.113] [32240] [DEBUG] ./google-drive.rb ["--filter", "t"]
[2017-11-18 15:15:26.179] [32240] [ERROR] Already waiting for authentication: Address already in use - bind(2) for "127.0.0.1" port 1337
[2017-11-18 15:15:26.179] [32240]  [INFO] Requesting user authentication via browser
[2017-11-18 15:15:26.296] [32240] [FATAL] Uncaught exception: No access token
[2017-11-18 15:15:26.296] [32240] [FATAL] ./google-drive.rb:243:in `abort'
[2017-11-18 15:15:26.296] [32240] [FATAL] ./google-drive.rb:243:in `token'
[2017-11-18 15:15:26.296] [32240] [FATAL] ./google-drive.rb:320:in `get_items'
[2017-11-18 15:15:26.296] [32240] [FATAL] ./google-drive.rb:335:in `items'
[2017-11-18 15:15:26.296] [32240] [FATAL] ./google-drive.rb:499:in `<main>'
[2017-11-18 15:15:26.296] [32240] [DEBUG] Execution took 0.184 seconds
[2017-11-18 15:15:26.720] [32250] [DEBUG] ./google-drive.rb ["--filter", "te"]
[2017-11-18 15:15:26.788] [32250] [ERROR] Already waiting for authentication: Address already in use - bind(2) for "127.0.0.1" port 1337
[2017-11-18 15:15:26.788] [32250]  [INFO] Requesting user authentication via browser
[2017-11-18 15:15:26.877] [32250] [FATAL] Uncaught exception: No access token
[2017-11-18 15:15:26.877] [32250] [FATAL] ./google-drive.rb:243:in `abort'
[2017-11-18 15:15:26.877] [32250] [FATAL] ./google-drive.rb:243:in `token'
[2017-11-18 15:15:26.877] [32250] [FATAL] ./google-drive.rb:320:in `get_items'
[2017-11-18 15:15:26.878] [32250] [FATAL] ./google-drive.rb:335:in `items'
[2017-11-18 15:15:26.878] [32250] [FATAL] ./google-drive.rb:499:in `<main>'
[2017-11-18 15:15:26.878] [32250] [DEBUG] Execution took 0.158 seconds

I tried on a second machine and ran into the same issue.
The issue comes from a service already running on :1337. It is called corsproxy.
A workaround is to stop corsproxy and then do the auth.
Would it be an option to take a higher port? or check if the port is in used and jump to another?

The port number is part of the OAuth client setup and cannot be
dynamically changed, but we can do new client credentials.
Though the current client credentials are setup and controlled by
@azai91 so I think it should be his call, if we should jump to another
port. Personally I do find 1337 to be a non-ideal port to use for
“production” software.
On 18 Nov 2017, at 21:28, Chevdor wrote:

OS: OSX 10.13.1
Alfred 3.5.1 (883)
I use Chrome.
The logs are:
[2017-11-18 15:15:26.113] [32240] [DEBUG] ./google-drive.rb
["--filter", "t"]
[2017-11-18 15:15:26.179] [32240] [ERROR] Already waiting for
authentication: Address already in use - bind(2) for "127.0.0.1" port
1337
[2017-11-18 15:15:26.179] [32240]  [INFO] Requesting user
authentication via browser
[2017-11-18 15:15:26.296] [32240] [FATAL] Uncaught exception: No
access token
[2017-11-18 15:15:26.296] [32240] [FATAL] ./google-drive.rb:243:in
`abort'
[2017-11-18 15:15:26.296] [32240] [FATAL] ./google-drive.rb:243:in
`token'
[2017-11-18 15:15:26.296] [32240] [FATAL] ./google-drive.rb:320:in
`get_items'
[2017-11-18 15:15:26.296] [32240] [FATAL] ./google-drive.rb:335:in
`items'
[2017-11-18 15:15:26.296] [32240] [FATAL] ./google-drive.rb:499:in
`<main>'
[2017-11-18 15:15:26.296] [32240] [DEBUG] Execution took 0.184 seconds
[2017-11-18 15:15:26.720] [32250] [DEBUG] ./google-drive.rb
["--filter", "te"]
[2017-11-18 15:15:26.788] [32250] [ERROR] Already waiting for
authentication: Address already in use - bind(2) for "127.0.0.1" port
1337
[2017-11-18 15:15:26.788] [32250]  [INFO] Requesting user
authentication via browser
[2017-11-18 15:15:26.877] [32250] [FATAL] Uncaught exception: No
access token
[2017-11-18 15:15:26.877] [32250] [FATAL] ./google-drive.rb:243:in
`abort'
[2017-11-18 15:15:26.877] [32250] [FATAL] ./google-drive.rb:243:in
`token'
[2017-11-18 15:15:26.877] [32250] [FATAL] ./google-drive.rb:320:in
`get_items'
[2017-11-18 15:15:26.878] [32250] [FATAL] ./google-drive.rb:335:in
`items'
[2017-11-18 15:15:26.878] [32250] [FATAL] ./google-drive.rb:499:in
`<main>'
[2017-11-18 15:15:26.878] [32250] [DEBUG] Execution took 0.158 seconds

I tried on a second machine and ran into the same issue.
The issue comes from a service already running on :1337. It is called
corsproxy.
A workaround is to stop corsproxy and then do the auth.
Would it be an option to take a higher port? or check if the port is
in used and jump to another?
--
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
https://github.com/azai91/alfred-drive-workflow/issues/48#issuecomment-345445637

Run into the same problem. What helped: lsof -n -i:1337 lists the offending process, in my case Tunnelblick.
Killing it temporarily was enough.

authors: chevdor sorbits thomasrichner-oviva


text:
🛑 Sukri Online is down

In fccd9f9, Sukri Online (https://discord-aklx.onrender.com/) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Sukri Online is back up in 4a4185f after 13 minutes.

repo: azrielbsi/monitor


text:
🛑 Sukri Online is down

In c1008e1, Sukri Online (https://discord-aklx.onrender.com/) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Sukri Online is back up in 6746d19 after 6 minutes.


text:
feat(redux): dispatcher with middleware

一般的によくみるDispatcherをベースとしたmiddlewareの実装を追加
#58

[Current coverage][cc-pull] is 96.22%

Merging [#97][cc-pull] into [master][cc-base-branch] will increase coverage by <.01%

@@             master        #97   diff @@
==========================================
  Files             6          6
  Lines          1032       1033     +1
  Methods           0          0
  Messages         39         39
  Branches          0          0
==========================================
+ Hits            993        994     +1
  Misses           39         39
  Partials          0          0

Powered by Codecov. Last updated by [b5f4779...17b9949][cc-compare]
[cc-base-branch]: https://codecov.io/gh/azu/JavaScript-Plugin-Architecture/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/azu/JavaScript-Plugin-Architecture/compare/b5f4779bd428a694730d1b09d7e0cce1721628c4...17b99498f0350a513fd56ce85b2ad9f760ab44ad
[cc-pull]: https://codecov.io/gh/azu/JavaScript-Plugin-Architecture/pull/97?src=pr

authors: azu codecov-io

repo: azu/JavaScript-Plugin-Architecture

license: mit


text:
[Docker] If running inside vm, do not monitor Docker

This PR closes #525.
Add AZK_DOCKER_MONITOR env var which defaults to true if running on linux.

LGTM

ok to test

Sync tests failing at CI. Further investigation needed.

I've Just tested it again at CI box and everything went well. Looks like an intermittent error.

@teodor-pripoae we've mentioned this PR on the azk v0.16.0 release blog post.
https://medium.com/azuki-news/azk-v-016-0-building-together-8b41f455a59d
On behalf of azk core team, I'd like to say thank you!

Thank you !

authors: fearenales teodor-pripoae

repo: azukiapp/azk


text:
USB hub issues with MXRT1064EVK

Both the NXP SDK and USBX have issues with many USB hubs on the MXRT platform. After lots of investigation, I was able to at least somewhat get the NXP SDK examples to consistently enumerate and communicate with all devices on a hub by increasing the hub port reset delay. However, the NXP USB drivers tend to have other issues that makes me not want to use them compared to USBX.
I've tested USBX with USB hubs to connect a mouse and keyboard to a single port without luck so far. USBX always enumerates the hub but fails to enumerate any devices on the hub. I get a USBX error callback due to a transaction not getting a response that is triggered by the stack trying to set an address of a device on the hub after that device's port has been reset.
I am unfortunately unable to provide much more information than this as I do not have access to a USB protocol analyzer at the moment.

Thanks for the feedback.
Based on USB spec. if a low-speed (LS) device (usually HID devices are low speed) are connected to a high-speed (HS) port through a high-speed hub, the operations on that device needs special way of transfer, the split transfer, the split-transfer sent to high-speed hub is translated to full speed (FS) or LS transfer. I think that's possible your case. The host is sending high-speed set address request to the device but not split transfer set_address, so device is not able to recognize the request and there is no response.
If there is a full speed port, please use full speed port for hub with HIDs.
The possible workaround for high speed port.

Directly connect HID devices to the port and see if they work to confirm the port can work in FS/LS mode.
Connect a full speed hub to the port to force the port sends FS signal to the hub.
Connect HIDs to the full speed hub downstream port to check if they works.

@xiaocq2001
Thanks for the quick response. Would you then consider this to be a USBX bug? This sounds like something the stack should handle.
One thing is that NXP's example works. I notice that in the phy_init code that is used by both USBX and the NXP example I see this:
    usbPhyBase->CTRL |= USBPHY_CTRL_SET_ENUTMILEVEL2_MASK; /* support LS device. */     usbPhyBase->CTRL |= USBPHY_CTRL_SET_ENUTMILEVEL3_MASK; /* support external FS Hub with LS device connected. */
It seems like these settings should make what I'm doing work, right? However, as I said, USBX init code uses this and I still have problems.
I think you might have suggested that forcing the USB interface to be full speed might help, is this correct?

So I got everything working which is great. All I had to do is force the USB PHY to full-speed mode instead of high-speed as you suggested.
Atleast on MXRT, the timing of when you set the force full speed register is important. So I ended up modifying ux_hcd_ehci_initialize.c to call an extern function in my main application. I made this call happen after the global reset and right under UX_HCD_EHCI_EXT_USB_HOST_MODE_ENABLE(hcd_ehci);. The function that forces fullspeed is below in-case anyone wants it.
void force_fullspeed_usb() {
    // USB1 is the port closest to the eth port on the MIMXRT1064EVK board.
    // ideally this function takes the hcd_ehci value from the caller and computes the correct peripheral pointer from that.
    USB1->PORTSC1 |= USB_PORTSC1_PFSC(1);
}

Good to here your things working.
Thanks for the feedback and we will keep improving USBX.

@xiaocq2001 Again, can I get clarification if this is something that USBX intends to support out of the box? Thank you for your support though.

Thanks Maxkunes. We will support this in future releases.

repo: azure-rtos/usbx


text:
Request to Add Assumption Day for Bavaria in Yasumi

Hello Yasumi Team,
I'm using Yasumi to manage public holidays in Germany but noticed that Assumption Day (August 15th), which is a public holiday in Bavaria, is missing from the library. Could you please consider adding this holiday to the Bavaria provider? This addition would help accurately reflect local holidays for users managing schedules in this region.
For reference on the holiday, please see: Assumption Day in Bavaria
Thank you for considering this request.
Best regards,

Hello Yasumi Team,
I wanted to follow up on my previous request regarding adding Assumption Day (August 15th) as a public holiday for Bavaria in the Yasumi library. Is there any update on whether this will be implemented?
Thank you for your attention to this matter.
Best regards,

@Hatemnaser Apologies for the late reply as I have been traveling for business. Let me check this week.

@Hatemnaser I've added the Assumption of Mary to Bavaria. It is available in the dev branch and targeted for the 2.8.0 release (not date determined yet).

Thank you very much for the update, look forward to the 2.8.0 release.

Hello @stelgenhof, do you have an estimate on when the 2.8.0 release might be available?

authors: Hatemnaser stelgenhof

repo: azuyalabs/yasumi


text:
🛑 Flask on Render is down

In 47ce83f, Flask on Render (https://td-flask.onrender.com) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Flask on Render is back up in 8ecbd78 after 23 minutes.


text:
Ignore timer?

Hey!
The description states that devices running any media/timers/etc will be ignored.
From what I understand of that, is that "If i have an active timer on the display" nothing will be casted to this device.
However, during today's dinner preparation, my Rice-timer were interupted several times.
I expected it to continue display the Timer, until atleast finished, but that did not work.
Any issues regaring that?
Everything updated, latest OS/Integration/etc..

Hey @Takst3in sorry about my bad wording! The timer does go off the screen but it should continue in the background. You should still be able to ask "Hey Google, show my timer" And it will show. But it will go off eventually when the refresh comes around. The Google Hub unfortunately does not report a "status" when the timer is on the screen, so there is no way to stop this unfortunately 👍

Updated the documentation to fix the wording. Closing this issue 👍thanks!


text:
Powerline symbols on ends

I would like to use Powerline symbols such as U+E0BC/E0BC (upper left and right triangle) on the ends of the winline, to make it a trapezoid instead of rectangle. But these work poorly on a nontransparent background, and I don't know how to set the background to transparent without messing up the rest of the display. Any idea on how to do this?
Somewhat similar to #13, and might be implementable through it, by setting only left and right border and fiddling with hl-FloatBorder.

Is this along the lines of what you're trying to do?

incline.setup {
  render = function(props)
    local bg = '#A694ED'
    local fg = '#120433'
    local fname = vim.fn.fnamemodify(vim.api.nvim_buf_get_name(props.buf), ':t')
    return {
      { '', guifg = bg },
      {
        ' ' .. fname .. ' ',
        guibg = bg,
        guifg = fg,
      },
      { '', guifg = bg },
    }
  end,
}

Yep, that turns out to be pretty much exactly what I'm looking for, thanks. Here's a lazy.nvim snippet that applies this style to an arbitrary render function.
    {
        "b0o/incline.nvim",
        opts = function(plug, opts)
            return vim.tbl_deep_extend("force", opts, {
                window = { padding = 0 },
                highlight = {
                    groups = {
                        InclineNormal = { guibg = "none" },
                        InclineNormalNC = { guibg = "none" },
                    }
                },
                render = function(params)
                    local content = opts.render(params)
                    local hl = vim.api.nvim_get_hl(0, { name = "NormalFloat", link = false })
                    local bg = string.format("#%06x", hl.bg);
                    return {
                        { '', guifg = bg },
                        {
                            {" ", content, " "},
                            guibg = bg,
                        },
                        { '', guifg = bg },
                    }
                end
            })
        end
    },

Didn't realize the markup was this nestable. That's super cool.


text:
see original repository license

https://github.com/BetterMC/raknet-rs/blob/master/LICENSE.md

i will remove any your code

To ensure compliance with your license, I will make this repository private within 24 hours, and make sure to remove your code (write.rs and read.rs) before making it public. If you have any other questions, you can reply me within 24 hours, if there is no reply, I will acquiesce you to approve this way of handling.

Due to the ample working time on weekends, I will delete the relevant code (reader.rs and writer.rs) of your project within 24 hours, I will close this issue after deletion, if you have any other license issues, Reply me here, or email me. thanks.


text:
Add ngrok

Ngrok v3 uses the XDG spec.
Source:
https://ngrok.com/docs/guides/upgrade-v2-v3/

Thank you!


text:
Add support for hashicorp/aws v4 in new major version

This is best reviewed commit-by-commit

@jansiwy I'm confident this transition won't take long and we can go ahead with it.

repo: babbel/terraform-aws-athena


text:
link to slack is https://slack.babeljs.io/ and should be https://babeljs.slack.com

im no expert into slack, but https://slack.babeljs.io got some issue

always asks me for an invite, even if im already invited
it doesnt allow me to login with my account

https://babeljs.slack.com seems to fix all those issues

https://babeljs.slack.com doesn't provide a way to register though, only log in, from what I can see.

Yeah, no it should be slack.babeljs.io

even if https://slack.bablejs.io doesnt allow to login ?
if you guys controls this page, maybe simply add a button 'login' which would allow to login ?

authors: jeromeetienne loganfsmyth thejameskyle


text:
Stable release is using beta versions of Babel packages

The latest stable version of your package is based on beta versions of Babel packages, which lead to weird issues (in my case unmeet peer dependencies and missing babel-core) and is against good practices of making stable releases.
Will be nice if you will change this release also to beta, same as you already did with 8.0.

cc https://github.com/babel/gulp-babel/issues/132

Could you clarify what you mean? The stable version is 7.0.0 which still relies on babel-core. We've published 8.0.0-beta.0 under the tag next, but it's definitely not meant to be stable.

Your stable 7.0.0 release is based on the bunch of unstable dependencies, so shouldn't be released as a stable, but as a 7.0.0-beta
    "babel-core": "7.0.0-alpha.18",
    "babel-plugin-transform-es2015-arrow-functions": "7.0.0-alpha.18",
    "babel-plugin-transform-es2015-block-scoping": "7.0.0-alpha.18",
    "babel-plugin-transform-es2015-classes": "7.0.0-alpha.18",

Those are dev dependencies. The only dependencies that matters for users is the peer dependency, which allows both Babel 6 and 7.

Sorry for the misunderstanding, but for me, it's kinda weird that I have to install babel-core separately while installing a gulp-babel, b/c I never saw something like this in any gulp plugin.

That's generally the approach Babel is moving toward. We've done it consistently when using Babel with Webpack, but the rest of our Babel wrappers haven't until recently. Sorry the docs are outdated.

authors: Igloczek loganfsmyth zalog

repo: babel/gulp-babel


text:
Add ECMAScript 2020 features?

@babel/plugin-proposal-nullish-coalescing-operator and @babel/plugin-proposal-optional-chaining were just added to @babel/preset-env with the release of 7.8.0 — should they also make an appearance here?

I updated our preset to 7.8, and when the preset-modules is enabled, optional chaining and nullish coalescing are not transformed anymore, while they should.

@rdmurphy I think these make more sense to be handled via preset-env. Currently, preset-modules transforms only syntax that is broken in modern browsers, not syntax that has varying degrees of support. This is the same reason preset-modules doesn't currently include transforms for class fields.
That being said, if we're looking to bridge the gap until preset-env landing the modules fixes, perhaps it'd be worth bringing in these transforms.

Note that the inline helper (it's not a polyfill) it's just an optimization: it will make your code shorter if you use 3-4+ class fields, and uses [[Set]] instead of Object.defineProperty (which is more expensive) when it's not observable.

It’s not stage 4, but it’s stage 3 and shipping in browsers.

Optional chaining and nullish coalescing are standard / stage 4.
Class fields are stage 3, and shipping in browsers, which is a more important milestone for Babel imo than the stage.

Alright, spent an hour putting together a dedicated plugin for class fields. Not sure what I'll end up doing with it, but for those interested here it is:
https://astexplorer.net/#/gist/31dbcb25cfb4b322ce10591a3cd2daaf/3bb90ae34957cee457f862de6beb54864d483392
For me this solves an issue where including plugin-proposal-class-properties produces ES5 class output since I'm not using preset-env.
@nicolo-ribaudo good point about the helper being a helper and not a polyfill. I've included a somewhat naive compile-time version of that logic in this alternative plugin, curious to have folks poke holes in that approach. It fails for assignment to this in inherited classes, as well as for dynamic property assignment (this[window.whatever]=2).

Class fields are stage 3, and shipping in browsers, which is a more important milestone for Babel imo than the stage.

preset-env has the shippedProposals option, for proposals which are not part of the specification yet but are already shipped in at least one browser/node. We should probably add class-fields to that option.
@developit Looking at your plugin, I think that you misinterpreted the reason for using the optimized [[Set]] in the plugin.
Object.defineProperty is unrelated to this.bar = 2 in the constructor: it's needed when there is a setter on the prototype of the class (almost always coming from a superclass) because the setter shouldn't be triggered. This isn't statically analyzable, because almost always the base and derived classes are in two different files.
Also, the descriptor you pass to defineProperty must have the enumerable: true, configurable: true, writable: true properties.
I don't think that it's possible to make a spec-compliant version of the plugin smaller than the current one, and if someone isn't concerned with spec compliancy in the [[Set]] vs [[Define]] case they can already enable loose mode, which produces this output:
class A extends B {
  x = 2;
}

// ->

class A extends B {
  constructor(...args) {
    super(...args);
    this.x = 2;
  }
}

@nicolo-ribaudo indeed, the approach in my link is over-simplified.

authors: developit ljharb nicolo-ribaudo pascalduez rdmurphy

repo: babel/preset-modules


text:
🛑 SM Service is down

In b9d85aa, SM Service (http://smservice.de) was down:

HTTP code: 0
Response time: 0 ms

Resolved: SM Service is back up in 3ca83da after 19 minutes.

repo: bachmannschumacher/upptime


text:
🛑 SM Service is down

In 517b0c4, SM Service (http://smservice.de) was down:

HTTP code: 0
Response time: 0 ms

Resolved: SM Service is back up in f439832 after 19 minutes.


text:
matchValueIn: [] does not filter entities in NextEntitiesCatalog

Expected Behavior
When a filter with matchValueExists set to [] is passed to NextEntitiesCatalog.entities, it seems like no entities should be returned, since this filter represents a query clause of <key> IN [], which can't ever match.
Note: I don't think it's actually possible to generate a filter like this through the catalog-backend API, so I don't think this bug will have any user impact for now. As such this is super low priority.
Current Behavior
When an empty array is supplied, the logic for adding an additional where clause to the entities query is skipped entirely. As such, this filter will be entirely ignored when retrieving entities.
Possible Solution
Perhaps it's enough to change the else if (matchValueIn.length > 1) to an unqualified else, such that this branch handles both matchValueExists.length === 0 and matchValueExists.length > 1. That way when the length is zero, we should correctly end up calling this.andWhere('value', 'in', []).
Steps to Reproduce
I don't think there's a super convenient repro for this - I ran into it while working on something unrelated in a branch.

This was fixed in https://github.com/backstage/backstage/pull/7817.

repo: backstage/backstage


text:
Add bitbucket cloud scaffolder action "bitbucket-cloud:repo:create"

Signed-off-by: Andrew Kundrock akundrock@somalogic.com
Hey, I just made a Pull Request!
This PR adds a new sub folder in the scaffolder-backend actions to separate advanced functions for Bitbucket Cloud. The first "action" is "bitbucket-cloud:repo:create"
The new action is essentially a clone of the existing "publish:bitbucket-cloud" action but breaks out a few helper functions and tests so their functions are easier to understand. Additionally, I have added the ability to "enable Bitbucket Pipelines" upon repo creation. In the future, I would like to see additional options on the action to allow for default branch permissions, etc.
:heavy_check_mark: Checklist

[X] A changeset describing the change and affected packages. (more info)
[ ] Added or updated documentation
[X] Tests for new functionality and regression tests for bug fixes
[ ] Screenshots attached (for UI changes)
[X] All your commits have a Signed-off-by line in the message. (more info)

@pjungermann
Here is the PR related to the RFC for bitbucketCloud specific actions.
Thanks!

@freben Do you think it makes sense to start splitting this into separate modules like at the catalog? E.g., scaffolder-backend-module-bitbucket-cloud?

Having a "create repo" action makes sense to me. I wonder a bit about the relationship to and future of publish:bitbucketCloud which also creates a repo, initializes a git repo locally and pushes this to the created remote at Bitbucket Cloud -- and in a similar way other publish:{...} actions.
If they are supposed to exist alongside, how would I use them? They seem to conflict now.
Maybe it makes sense to have a separate "create {provider} repo" action and then pushing content to it and hence, splitting these publish:{...} actions. E.g., into "create repo" and (a more generic) "(git) push"?

Per @pjungermann 's comments above, this PR could have been a simple update to the existing "publish:bitbucket-cloud" action.
Since I plan to add several more functions similar to the github:* actions I thought it would be wise to start breaking these apart from the "publish:* actions" to avoid breaking changes to the existing actions.
So I can:
1: Add the enablePipeline flag to the existing publish:bitbucketCloud action
2: Leave publish alone and start breaking out bitbucket cloud actions to a new folder (which I have done here)
3: Create a whole new submodule for bitbucket cloud specific actions (as suggested above)
As a reminder, I opened an RFC (linked above) to discuss these issues. I'm open to ideas and would like to do this in a way that we can all agree on and is effective for the long-term direction of Backstage
Thanks for your time!

@akundrock the extension to the client seems ok.

I just checked GitHub and there is github:repo:create and github:repo:push which seems to be a split of publish:github. So likely, builtin/github/* should supersede/replace builtin/publish/github*.
So far, publish:github is not yet deprecated though. What you think about that @benjdlambert?
Similarly, it could make sense for publish:bitbucketCloud and your new bitbucketCloud:repo:create.

Re: putting this into scaffolder-backend vs scaffolder-backend-module-bitbucket-cloud:
I'm strongly of the opinion that we should move this out. Same for the other SCM actions. (Currently, there was mostly just the publish:{...} action which likely didn't feel like justifying it.)
Esp. when introducing the dependency to @backstage/plugin-bitbucket-cloud-common which is unnecessary for all which don't use Bitbucket Cloud. Same applies to octokit for GitHub, etc.

PS: also I wonder a bit about the initRepo part of initRepoAndPush (or initRepoAndProtect). E.g., this seems to lack support for existing non-empty remotes. Instead of git init, git clone could be used, etc.

another thought: maybe it even makes sense to have "enable pipeline" as separate action (on top or only).

bitbucketCloud:repo:create
bitbucketCloud:repo:pipelines (with enable: true)
git:push

THanks for all of the input! I have decided to close this PR and move this work to another module

authors: akundrock pjungermann


text:
Create port.yaml

Hey, I just made a Pull Request!
I added a new plugin we have created.
:heavy_check_mark: Checklist

[X] Added or updated documentation

Thanks for your feedback :)
I’ll address the unauthenticated endpoint issue – that’s definitely a mistake. Could you clarify what you meant about the following?

I'd doesn't seem to integrate with existing Backstage features properly.

@fokolo Looking at things like this: https://github.com/port-labs/backstage-plugin/blob/ac9d85d3ea61fc20dec4191996fbf91bed840a81/frontend-plugin/src/features/HomePage.tsx#L3-L13

Thank you so much for the feedback!
We fixed you have mentioned. looking forward for your thoughts :)

@Rugvip Can you please review again? and approve or give more comments?
Thanks a lot!

authors: Rugvip fokolo


text:
[DOC] Add ACL requirements for kafka-backend plugin

Hey, I just made a Pull Request!
I ran into the problem in our environment where i was not sure what ACL was required by this plugin to work correctly. After some trial and error, this seems to be the minimum set of ACLs required, which also don't provide any write or commit rights. Hopefully that will be helpful to others!
:heavy_check_mark: Checklist

[ ] A changeset describing the change and affected packages. (more info)
[ ] Added or updated documentation
[ ] Tests for new functionality and regression tests for bug fixes
[ ] Screenshots attached (for UI changes)
[x] All your commits have a Signed-off-by line in the message. (more info)

Thanks! This actually need a changeset so that your additions end up in the readme on npm :)

Thanks! This actually need a changeset so that your additions end up in the readme on npm :)

Thanks, i have added one.

authors: gotson jhaals


text:
Request: Remove Tulin's WeeOO sound

Hey there!
Any chance for a cheat that will just get rid of this sound? XD It's super annoying.
Thanks!

Hey there!
Any chance for a cheat that will just get rid of this sound? XD It's super annoying.
Thanks!

It'll most likely have to be a mod, gamebanana or you can go there and see what tools they use.


text:
Template literal templates

This has a good bit of work left to go, though I figured maybe if I put up the PR it might encourage me to nudge it along.
http://shields-staging-pr-3637.herokuapp.com/dev/styles
Closes #2428

Messages

:book:
:sparkles: Thanks for your contribution to Shields, @paulmelnikow!

  Generated by :no_entry_sign: dangerJS against 74484f3b00718f2226a1663d22ae219109081064

How far do you think you are from having this ready for review? I can see this is a big job, but given this one has a big impact on the other package v3 work, it would be really useful if we could try and get this one landed. Do you have a handle on what the remaining tasks are? If its useful to provide comments on the WIP, I'm happy to find some time over the weekend.

So, I’d tried to refactor this while keeping everything working, but I didn’t run tests along the way so what I’ve got is substantially refactored code which neither works nor is as clear as I’d like. The work left is to get it working, and more elegant, at the same time.
There’s some discussions we could start having around SVGO and how we want to handle that. I’m thinking we should not run SVGO at all in production, and instead encode the optimizations into the template, and write a test that SVGO is a no-op.
Put another way, I’m aiming for pixel perfect badges, maybe ones that work better than before, rather than total parity.

I actually have a few hours on a ✈ tomorrow and was thinking I might look at this again then.

I picked this up in #4459 which is now ready for review, so I'm going to close this.

authors: chris48s paulmelnikow shields-ci

repo: badges/shields


text:
Supporting status as query parameter

Adding a status parameter to override the right-hand-side text of a badge.
This implements feature request on #835

Thanks for your patch!
Query parameters are meant to have an effect on all badges; they mustn't be badge-type-dependent.

@espadrine Gotcha. I though it made sense to include it just on the general badge in order to avoid customizing the other badges which could potentially defeat the whole purpose of having them in the first place. Seemed like the general badge was general enough to include it there alone.
Taking into account my situation describen on #835, should I try to work on applying it to the other badges as well?
Thanks a lot in advance.

@espadrine would appreciate a response on this to manage other options, although seems like a perfectly good feature to customize better a badge

Closing in favor of direct implementation presented on #852 rather than this workaround.

authors: espadrine leog


text:
Custom BubbleView Position in Cell

Hi, Im creating a custom bubbleView inside a cell. But currently the position of the bubbleView in the cell is weird. I tried to debug it, but not fix it yet. Pleas help me, Thanks.

There are two issues.

The userAvatar is above the bubble.
The outcoming message is exceed the edge of the screen

hi can you share the code or details how you are able embed custom view in Bubble, I want to implement the same thing
Thanks

repo: badoo/Chatto


text:
Unable to add plugin

Hi,
When i follow the steps to add library getting following error at run time.
Caused by: java.lang.IllegalStateException: This app has been built with an incorrect configuration. Please configure your build for VectorDrawableCompat.

Are you sure this is related to this lib? This lib is not using VectorDrawables.
Maybe a conflict with support lib versions?

authors: badoualy k-srikanth

repo: badoualy/stepper-indicator


text:
Unique variable name detection

Variable names should be unique if they have default values specified or not -- right now it uses the raw value for detecting unique names.

Ok, there were some bad bugs in the variable substitution logic but they have been resolved now, pending additional testing (so far things are looking good though!)

repo: badvision/curly


text:
Add Roku Channel for Bad Voltage, please.

The BadVoltage Channel needs to viewed on the Official Roku Downloadable channels.
This is to kickstart the whole process, kindly adopted by @stuartlangridge
Please leave comments and amendments below, thank-you.

@flexiondotorg thank-you & have a hat-tip in return: https://v.gd/8P220z

repo: badvoltage/roku-app


text:
UI issue when customer redirect to reset password page through received email.

Bug report
Title
UI issue when customer redirect to reset password page through received email.
Issue Description
UI issue when customer redirect to reset password page through received email.
Preconditions
1. framework Version.- master

Steps to reproduce
1. step1- Go to Forgot password link
2. step2- Enter your email and click on send reset password link.
3. step3- Go to email and click the received link.

Expected result
Ui should be correct.
Actual result

Fixed

authors: jyoti-webkul vaishaliwebkul

repo: bagisto/bagisto


text:
Inventory status field should be passed through validation for boolean in its backend controller.

https://github.com/bagisto/bagisto/blob/cce548f2cd674db7f4973e7738a48bd5667b6e92/packages/Webkul/Admin/src/Resources/views/settings/inventory_sources/create.blade.php#L72
https://github.com/bagisto/bagisto/blob/cce548f2cd674db7f4973e7738a48bd5667b6e92/packages/Webkul/Inventory/src/Http/Controllers/InventorySourceController.php#L79
No validation in controller done for status its validation should be passed as boolean.

Hi @dejavuejs
We don't need validation for this one, simply, if we get this field from view at controller then it is active otherwise not.


text:
there should be  less  spacing in compare section

Bagisto Version

[ ] master branch

Steps To Reproduce

Login as a customer
then compare any products

Actual Result

now its working fine


text:
PHP版都出了，啥时候能出个Java版

PHP版都出了，啥时候能出个Java版

暂时没有Java版的计划

authors: JiangSongBai lyc-baidu

repo: baidu/unit-dmkit


text:
Move Main.hx out of source directory (Kha support)?

Hi,
first of all: thanks for this awesome library!
I plan to use hxdsp on a project, but unfortunately it currently doesn't work directly as a Git submodule because of src/Main.hx and the Kha framework which my project uses:
Kha's build tool adds libraries by adding their source directory as a class path to the hxml (-cp path/to/library/src), but in combination with -main Main this will make the main file of hxdsp the main file of the whole project. Also, Main.hx requires the format libary which might not be needed/wanted by the project that uses hxdsp.
Main.hx itself is just an example file, so maybe there is a way to move it out of the src directory? I would open a PR for this, but because I only use Kha which has its own build system I'm not very well informed about the specifics of pure-Haxe projects. Of course I could just create a fork of this library but if there is a way to change it in this repository, others may profit from it more easily :)

The actual library lives in src/dsp, would it be easy enough to point Kha to that path instead?

No, unfortunately not. I get a bunch of errors like Type not found : dsp.Complex then, and I suspect that this would be the same result without Kha (as Kha just adds the source directory to the hxml file and nothing more). Apparently the folder structure has to match with the package structure.
Also, simply declaring an arbitrary package at the top of Main.hx doesn't work, maybe for the same reasons. You'll then get the error Invalid commandline class : Main should be dsp.Main (it's the same for every other package name as well), so somehow the Main class still shadows the project's main class. Also, the format package is still required then.
I can try to test it in pure Haxe in the next days to see whether it is really a general issue or only Kha related. I'm currently a bit busy, so I might not get time before next weekend though.

repo: baioc/hxdsp

license: Unlicense


text:
feature request: docker image

as all my apps are running as Docker apps,. would be great if you can create a Docker app

There is currently an image LinuxServer.io is testing which can be used: https://github.com/TheSpad/docker-adguardhome-sync
Hopefully this is something we will get into the main repository soon.

The docker image is building and running on my system.
Just note I created the config file and then just mapped it from disk to container using -v :/config/adguardhome-sync.yaml

I added a docker image that is hosted on quay.io.
See the instructions in the readme.

works great, I like the very small image 3.5mb!!

authors: JoshStark bakito elRadix lg0killer

repo: bakito/adguardhome-sync


text:
Feature Request: Shell Specific Shortcuts

Currently butterflish does not feel super well integrated with the fish shell.
Here are some shortcuts that I would like when prompting the AI:

alt+right / alt+left: move to next/previous word
alt+backspace: remove word
right: accept suggestion

Here is a more expansive list of available shortcuts: https://fishshell.com/docs/current/interactive.html#shared-bindings

The alt+right / alt+left shortcuts are on main now, FYI, but still a lot of common shortcuts still not covered so leaving this open.

authors: bakks pomdtr

repo: bakks/butterfish


text:
Update LazyServiceFactoryFactoryTest.php

Just saving you a few minutes by writing tests that literally everyone could have written ;)

Thanks!


text:
How to set default value for DATETIME type

I have tried to use
type: "DATETIME"
defaultsTo: new Date(), but it failed.
Is there an elegant way to set default value?

Now that functions in defaultsTo are deprecated, what's the right way to do this?
{
  my_time: {
    type: 'ref',
    columnType: 'datetime',
    defaultsTo: () => new Date() // Causes an error
  }
}

Note that the type 'ref' and columnType 'datetime' are the new way to do mysql datetime fields in Sails 1.0.

authors: alflennik wehtta

repo: balderdashy/waterline


text:
Staging site docs are indexed by Google

I noticed when using Google to search the docs that some results were coming from the staging site - we shouldn't let search engines index this for duplicate content reasons, but it could also be confusing to the reader if the docs on staging are different from those on prod and they find them in search results.

This also applies to the marketing site: https://github.com/balena-io/resin-site/issues/877

I've had the same issue, I have typed manual BalenaOS releases and got this page https://www.balena-staging.io/os/docs/raspberrypi3/getting-started/

@chrisys @georgiats it was discussed with @alexandrosm that we should let staging results be there. Not able to find the Thread for it now :/

Normal practice is to use canonical links in these cases : https://en.wikipedia.org/wiki/Canonical_link_element

@iamsolankiamit Any definitive reason as to why that was the case so the issue can be closed?

authors: chrisys georgiats iamsolankiamit srlowe vipulgupta2048

repo: balena-io/docs


text:
OrangePi Zero LTS - soundcore / alsa kernel modules

Can you please include in future releases of this build the soundcore 'snd' and all relevant kernel modules for enabling the onboard audio chipset -- as well as any usb-audio peripherals?

Same problem with NanoPi NEO Air

Please also Orange Pi One (Allwinner H3)

authors: SamEureka harborretail tmigone

repo: balena-os/balena-allwinner


text:
Update layers/meta-balena digest to d21da1f

This PR contains the following updates:

Package
Update
Change

layers/meta-balena
digest
c7ef4ad -> d21da1f

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

Can one of the admins verify this patch?

authors: balena-ci resin-jenkins

repo: balena-os/balena-connectcore


text:
Add Pimoroni Pirate Audio to list

Change-type: patch
@Fiqq90 does it work with this dtoverly value?

@AlexProgrammerDE great thanks! Could you remove the link from the 'Yes' unless we have evidence of it working with balenaSound somewhere?

@chrisys Fiqq90 did approve that it works: https://github.com/balenalabs/balena-sound/pull/125#pullrequestreview-381677899
But if you want it i will remove the link.

@balena-ci retest

@chrisys can you do a squash merge?

@AlexProgrammerDE no, versionbot doesn't like squash merges - you can squash it first and update the PR if you like?

@balena-ci retest

@chrisys versionbot can parse squash commit. Works great in my own repo: https://github.com/AlexProgrammerDE/balena-minecraft-server
I use balena-versionist in a github ci workflow and i made many squash commits.

@nazrhom did the approach regarding squash merges change? I know we have it turned off on all our repos for a reason but @AlexProgrammerDE is saying it works fine

@nazrhom you can see my commits here: https://github.com/AlexProgrammerDE/balena-minecraft-server/commits/master
There are some squash commits.

authors: AlexProgrammerDE chrisys

repo: balenalabs/balena-sound


text:
Wrong suggestions + add all attributes completion not working for a nested record

Refer to the following gif

When I try to use the "add all attributes" completion from within the nested record literal, it completes the record with the fields of the enclosing record type.

Code sample:
public function main() {
    Person p = {name: "Pubudu", age: 28, address: {}};
}

type Address record {|
    string street = "";
    string city = "";
    string country = "";
    record {
        int countryCode = 0;
        int phoneNo = 0;
    } phone = {

    };
|};

type Person record {
    string name = "John Doe";
    int age = 0;
    Address address = {};
};

This issue has been fixed in the latest master. Hence closing the issue

repo: ballerina-platform/ballerina-lang


text:
Create variable code action not suggested for table literal

Description:
Create variable code action not suggested for table literal
Steps to reproduce:
public function main() {
table {
        {key id, name, salary},
        [
            e1,
            e2
        ]
    };
}

Affected Versions:
1.2.0

This issue is no longer valid for new table implementation.

authors: mohanvive rasika


text:
Module prefixes are referred to as 'alias' in module BBE

Description:
In spec what’s called module-prefix is referred to as module alias in module BBE https://ballerina.io/v1-2/learn/by-example/modules.html
Spec reference: https://ballerina.io/ballerina-spec/spec.html#section_8.1
Steps to reproduce:
Affected Versions:
OS, DB, other environment details and versions:
Related Issues (optional):

Suggested Labels (optional):

Suggested Assignees (optional):

Fixed via [1] & [2].
[1] https://github.com/ballerina-platform/ballerina-lang/pull/26245
[2] https://github.com/ballerina-platform/ballerina-distribution/pull/859

authors: praneesha rdhananjaya


text:
Evaluate module level variables in debugger

Please add the ability to eventuate module level variables in the watch panel in VSCode. We need support for both current module variables x and other module variables m:x

@manuranga We already support same/other module-level variables in debugger view and expression evaluation console as shown below.

Can you please test this nballerina repo. I can't evaluate t:NIL as show in the screen below

@manuranga I tested evaluations on nballerina compiler and evaluations are working for me as expected. However the constant t:NIL which you mentioned does not exist in the types module and therefore you might have got an evaluation output as below for t:NIL. (Note that the evaluator has returned a result for the existing constant: t:UL_NIL)

Closing with https://github.com/ballerina-platform/ballerina-lang/pull/34533


text:
[Bug]: Runtime error: (current frame, stack[0]) is not assignable to integer

Description
Reproducible with the following
public function main() {
    _ = testError();
}

function testError() returns boolean {
    do {
        from var testVar in check getErrorArray()
        do {

        };
    } on fail error err {
        return false;

    }
    return true;
}

public isolated function getErrorArray() returns string[]|error {
    return [];
}

Steps to Reproduce
No response
Affected Version(s)
No response
OS, DB, other environment details and versions
No response
Related area
-> Runtime
Related issue(s) (optional)
No response
Suggested label(s) (optional)
No response
Suggested assignee(s) (optional)
No response

The issue happens at desugaring the from clause with check expressions.
When we compare the check expression with and without the from clause as follows,
function testError() returns boolean {
    do {
        string[] listResult = check getErrorArray();  // without `from`
        // with `from`
        from var testVar in  check getErrorArray()
        do {

        };
    } on fail error err {
        return false;

    }
    return true;
}

Without the from clause
The block statement of the check contains a BLangFail statement

With the from clause
The block statement of the check contains a BLangReturn statement. This results in the wrong assignment of an ErrorValue to the boolean typed return variable

We can use a workaround as the following.
function testError() returns boolean {
    do {
        string[] listResult = check getErrorArray();
        from var testVar in listResult
        do {

        };
    } on fail error err {
        return false;

    }
    return true;
}

authors: HindujaB warunalakshitha


text:
[Bug]: Test parallel execution fails with following sample

Description
$subject
sample - https://github.com/gayaldassanayake/training-content/tree/parallel-test
Steps to Reproduce
No response
Affected Version(s)
No response
OS, DB, other environment details and versions
No response
Related area
-> Test Framework
Related issue(s) (optional)
No response
Suggested label(s) (optional)
No response
Suggested assignee(s) (optional)
No response

This issue comes when a common global client is mocked differently(same object method is mocked in different ways) across different test functions. When parallel execution is enabled, one mocking behavior of the client is replaced with another mocking behavior.  So, there are failures in the test function assertion.


text:
[Bug]: Getting Existing generated directory was not found during bal clean when a generated dir exists outside the bal project

Description
I got this when the generated dir was immediately outside the ballerina project.
Steps to Reproduce

Affected Version(s)
2201.9.0
OS, DB, other environment details and versions
No response
Related area
-> Compilation
Related issue(s) (optional)
No response
Suggested label(s) (optional)
No response
Suggested assignee(s) (optional)
No response

This issue is not reproducible for Update 9 as a fix was added before the release. Added the same fix for master.

authors: Dilhasha ShammiL


text:
Move jsonutils module to java interop

Purpose

$title.

Fixes #
Approach

Describe how you are implementing the solutions along with the design details.

Samples

Provide high-level details about the samples related to this feature.

Remarks

List any other known issues, related PRs, TODO items, or any other notes related to the PR.

Check List

[ ] Read the Contributing Guide
[ ] Required Balo version update
[ ] Updated Change Log
[ ] Checked Tooling Support (#)
[ ] Added necessary tests

[ ] Unit Tests
[ ] Spec Conformance Tests
[ ] Integration Tests
[ ] Ballerina By Example Tests

[ ] Increased Test Coverage
[ ] Added necessary documentation

[ ] API documentation
[ ] Module documentation in Module.md files
[ ] Ballerina By Examples

Codecov Report

Merging #20072 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #20072   +/-   ##
=======================================
  Coverage    19.9%    19.9%
=======================================
  Files          55       55
  Lines        1437     1437
  Branches      218      218
=======================================
  Hits          286      286
  Misses       1138     1138
  Partials       13       13

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 85308fc...af5ea1b. Read the comment docs.

authors: codecov-io wggihan


text:
Add instance-id to LDAP connection record [1.2.x]

Purpose
$subject
Fixes https://github.com/ballerina-platform/ballerina-lang/issues/24985
Check List

[x] Read the Contributing Guide
[ ] Updated Change Log
[ ] Checked Tooling Support (#)
[ ] Added necessary tests

[ ] Unit Tests
[ ] Spec Conformance Tests
[ ] Integration Tests
[ ] Ballerina By Example Tests

[ ] Increased Test Coverage
[ ] Added necessary documentation

[ ] API documentation
[ ] Module documentation in Module.md files
[ ] Ballerina By Examples

Codecov Report

Merging #25007 into ballerina-1.2.x will not change coverage.
The diff coverage is n/a.

@@               Coverage Diff                @@
##           ballerina-1.2.x   #25007   +/-   ##
================================================
  Coverage            14.59%   14.59%
================================================
  Files                   51       51
  Lines                 1411     1411
  Branches               219      219
================================================
  Hits                   206      206
  Misses                1189     1189
  Partials                16       16

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8aaf651...e1f63d6. Read the comment docs.

authors: codecov-commenter ldclakmal


text:
Add FunctionTypeDesc completion items to ReturnTypeDescriptor context

Purpose
To provide function type desc related completions when the cursor is positioned in a return type desc context.
Fixes #30555
Approach
Route and get completions related to function type desc if the return type descriptor node's  type is function type desc
Samples

Check List

[x] Read the Contributing Guide
[ ] Updated Change Log
[ ] Checked Tooling Support (#)
[x] Added necessary tests

[x] Unit Tests
[ ] Spec Conformance Tests
[ ] Integration Tests
[ ] Ballerina By Example Tests

[x] Increased Test Coverage
[ ] Added necessary documentation

[ ] API documentation
[ ] Module documentation in Module.md files
[ ] Ballerina By Examples

Closed as the fix has to be done at parser level


text:
Button re-write with unified hover implementation

Purpose

Button re-write with unified hover implementation
Move digram editing code to a seperate module called "GraphicalEditor"
Add HoverGroup component to define hover regions
Resolves https://github.com/ballerina-platform/ballerina-lang/issues/8088, https://github.com/ballerina-platform/ballerina-lang/issues/4820, https://github.com/ballerina-platform/ballerina-lang/issues/4821, https://github.com/ballerina-platform/ballerina-lang/issues/8053, https://github.com/ballerina-platform/ballerina-lang/issues/6470

Approach

Learning
React Portals https://reactjs.org/docs/portals.html
React synthetic events https://reactjs.org/docs/events.html

:white_check_mark: Build ballerina-lang 191 completed (commit https://github.com/ballerina-platform/ballerina-lang/commit/ff880d3646 by @pahans)

authors: AppVeyorBot pahans


text:
GraphQL build failed on Windows due to an intermittent error

Description:

When building the graphql package, a test case was failed due to an intermittent error. It occurred while a WebSocket client is initiating.
https://github.com/ballerina-platform/module-ballerina-graphql/runs/7545316864?check_suite_focus=true#step:4:222
This happened only on Windows.

This is the excerpt from the error log:
Error: null

    at ballerina.websocket.2.Client:initEndpoint(websocket_sync_client.bal:62)
    ballerina.websocket.2.Client:init(websocket_sync_client.bal:59)
    ballerina.graphql_tests$test.1.tests.36_subscriptions:testInvalidSubscription(tests/36_subscriptions.bal:190)

authors: Nuvindu ThisaruGuruge


text:
Bal persist generated client should be marked as isolated

I am using bal persist generated client inside resource functions, and all the functions are giving me this warning.

Re-opening the issue as we can make the generic clients isolated as well

This issue is fixed in update 06, hence closing

authors: daneshk kaneeldias sameerajayasoma


text:
Common path parameters are not getting generated in client/service method generation for 3.1.x OpenAPIs

Description:
In the OpenAPI we can define parameters that are common to all the methods in a given path in the path level .
Ex:
  /pet/{petId}:
    parameters:
      - name: petId
        in: path
        description: ID of pet to return
        required: true
        schema:
          type: integer
          format: int64
    post:
      summary: Updates a pet in the store with form data
      operationId: updatePetWithForm
      parameters:
        - name: name
          in: query
          description: Name of pet that needs to be updated
          schema:
            type: string
      responses:
        '405':
          description: Invalid input

Operations with common parameters are correctly generated for the definitions written in OpenAPI spec 3.0.x; However when the OpenAPI spec is written in 3.1 version, the generated code is missing the common parameter.
Ex:
    remote isolated function updatePetWithForm(int petId, string? name = (), string? status = ()) returns http:Response|error {
        string resourcePath = string `/pet/${getEncodedUri(petId)}`;
        map<anydata> queryParam = {"name": name, "status": status};
        resourcePath = resourcePath + check getPathForQueryParam(queryParam);
        http:Request request = new;
        http:Response response = check self.clientEp-> post(resourcePath, request);
        return response;
    }

Steps to reproduce:
Affected Versions:
OpenAPI 3.1

For OpenAPI definitions written in version 3.0.x, the tool's Swagger parser automatically includes common parameters in the operation parameter list. There's no need for explicit checks regarding the presence of these common parameters. However, it appears that starting from OpenAPI 3.1 definitions, the parser no longer follows this approach. Therefore, explicit checks for common parameters are necessary.

repo: ballerina-platform/openapi-tools


text:
Get Ballerina version dynamically and use relevant based image

Current container support is hard corded with the docker based image name. The latest Ballerina tool release (0.8.3) packed the 0.8.1 container support and it is using ballerina 0.8.1 docker image, which is wrong.

Closing as per above commit .

authors: chamilad lakwarus

repo: ballerinalang/container-support


text:
Service validation for media_player component

Description:
I wanted to get stricter validation for the content_type and content_id arguments to play media, i.e. force content_type to be a mime type that starts with either image/ or video/ and make sure content_id roughly matches an URI ([a-z]+://[^/]+/) but that broke tests that tried to pass things like None or 'youtube' at which point I wasn't sure what the expected values really are.
Related issue (if applicable): #1657
Checklist:
If the code does not interact with devices:

[x] Local tests with tox run successfully. Your PR cannot be merged unless tests pass
[ ] Tests have been added to verify that the new code works.

This is good to merge after the coerce comment has been addressed :dolphin: :+1:

authors: balloob jaharkes

repo: balloob/home-assistant


text:
进入照片预览时，会遇到视频的对应缩略图

偶然发现的这个BUG，后来出于好奇去微信看了看，也存在同样的问题。

是的，因为避免这个比较耗性能，所以微信就干脆没处理...  我也于是没有处理，问题不大，视频缩略图也是一张图片咯~

authors: Hesland banchichen

repo: banchichen/TZImagePickerController


text:
TKN Modal

Fixed #487

[ ] some tokens are not clickable and nothing happens when you click the "upgrade" CTA
tested on: DAI, GNO,

[ ] once clicking the popup -> upgrade all CTA -> please close the popup
currently: popup stays open

[ ] bottom disclaimer text is not using the same font as the rest of our popups
div class="flex items-center text-secondary text-[13px] justify-center">100% Protected • 7 day cooldown • 0.25% withdrawal fee

div class="font-semibold text-12 text-black-low dark:text-white-low">100% Protected • 7 day cooldown • 0.25% withdrawal fee

authors: RanCohenn ashachaf