text:
Coldtype App Icon is Blurry

OS: macOS Catalina (Version 10.15.1)
App Version: 0.0.1 (0.0.1)
Let me know if I can provide you with any more information. Just figured I'd report things as they come up, whether they are important at this point or not.

Strangely this seems to have resolved itself. Though I do wonder why at first it had the low-res CT icon.

Closing since the coldtype-viewer app no longer exists (GUI is now an integrated part of the python CLI process), but thanks for the report!

No problem! Excited where you're taking this with Skia support!
On Mon, Oct 19, 2020 at 1:53 PM Rob Stenson notifications@github.com
wrote:

Closing since the coldtype-viewer app no longer exists (GUI is now an
integrated part of the python CLI process), but thanks for the report!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/goodhertz/coldtype/issues/5#issuecomment-712435517,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AB4TYENUU7XPU2UO2L5TJGDSLSRLNANCNFSM4OF22ZMQ
.

authors: stenson tallpauley

repo: goodhertz/coldtype


text:
E/native: camera_image_stream.cc:118 Failed to extract the metadata or correct the timestamp, status=generic::deadline_exceeded: Timed out waiting for metadata.

getting above error with these too...
E/eglCodecCommon: glUtilsParamSize: unknow param 0x00008919
E/eglCodecCommon: glUtilsParamSize: unknow param 0x00008919
everything is working fine but my characters are not placing on the surface.

camera_image_stream.cc:120 Failed to extract the metadata or correct the timestamp, status=generic::deadline_exceeded: Timed out waiting for metadata.

The following error occurs.

source: gharchive/issue

repo: google-ar/sceneform-android-sdk

license_type: permissive

license_source: bigquery


text:
TypeError: _dense() missing 2 required positional arguments: 'axes' and 'with_reshape'

I've installed ferminet on Linux with Python 3.11 today using the following commands:
python -m venv --system-site-packages ~/venv/ferminet
. ~/venv/ferminet/bin/activate
pip install -U "jax[cuda12_pip]" -f https://storage.googleapis.com/jax-releases/jax_cuda_releases.html
pip install -e .

But when I try to run example calculation as
ferminet --config ferminet/configs/atom.py --config.system.atom Li --config.batch_size 256 --config.pretrain.iterations 100

I'm getting the following output:
<...>
I1129 13:46:55.584216 139750111250240 train.py:384] Starting QMC with 1 XLA devices per host across 1 hosts.
converged SCF energy = -7.43242052759577  <S^2> = 0.75000054  2S+1 = 2.0000005
I1129 13:46:56.988999 139750111250240 train.py:584] No checkpoint found. Training new model.
I1129 13:47:01.371712 139750111250240 pretrain.py:344] Pretrain iter 00000: 0.0532642 0.890625
<...pretrain iterations...>
I1129 13:47:01.964662 139750111250240 pretrain.py:344] Pretrain iter 00099: 0.000944124 0.945312
Traceback (most recent call last):
  File "/home/ktokarev/venv/ferminet/bin/ferminet", line 7, in <module>
    exec(compile(f.read(), __file__, 'exec'))
  File "/mnt/storage/src/git/ferminet/bin/ferminet", line 39, in <module>
    app.run(main)
  File "/usr/lib/python3.11/site-packages/absl/app.py", line 308, in run
    _run_main(main, args)
  File "/usr/lib/python3.11/site-packages/absl/app.py", line 254, in _run_main
    sys.exit(main(argv))
             ^^^^^^^^^^
  File "/mnt/storage/src/git/ferminet/bin/ferminet", line 35, in main
    train.train(cfg)
  File "/mnt/storage/src/git/ferminet/ferminet/train.py", line 852, in train
    opt_state = optimizer.init(params, subkeys, data)
                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/ktokarev/venv/ferminet/lib/python3.11/site-packages/kfac_jax/_src/optimizer.py", line 1025, in init
    return self._init(params, rng, batch, func_state)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/ktokarev/venv/ferminet/lib/python3.11/site-packages/kfac_jax/_src/utils/staging.py", line 277, in decorated
    outs = func(instance, *args)
           ^^^^^^^^^^^^^^^^^^^^^
  File "/home/ktokarev/venv/ferminet/lib/python3.11/site-packages/kfac_jax/_src/optimizer.py", line 993, in _init
    estimator_state=self.estimator.init(
                    ^^^^^^^^^^^^^^^^^^^^
  File "/home/ktokarev/venv/ferminet/lib/python3.11/site-packages/kfac_jax/_src/utils/misc.py", line 342, in wrapped
    return method(instance, *args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/ktokarev/venv/ferminet/lib/python3.11/site-packages/kfac_jax/_src/curvature_estimator/block_diagonal.py", line 390, in init
    self.finalize(func_args)
  File "/home/ktokarev/venv/ferminet/lib/python3.11/site-packages/kfac_jax/_src/utils/misc.py", line 315, in finalize
    self._finalize(*args, **kwargs)
  File "/home/ktokarev/venv/ferminet/lib/python3.11/site-packages/kfac_jax/_src/curvature_estimator/block_diagonal.py", line 375, in _finalize
    self._jaxpr = self._jaxpr_extractor(func_args)
                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/ktokarev/venv/ferminet/lib/python3.11/site-packages/kfac_jax/_src/tracer.py", line 466, in get_processed_jaxpr
    closed_jaxpr, _ = retrieve(func_args)
                      ^^^^^^^^^^^^^^^^^^^
  File "/home/ktokarev/venv/ferminet/lib/python3.11/site-packages/kfac_jax/_src/tracer.py", line 432, in retrieve
    processed_jaxpr = ProcessedJaxpr.make_from_func(
                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/ktokarev/venv/ferminet/lib/python3.11/site-packages/kfac_jax/_src/tracer.py", line 321, in make_from_func
    func = tgm.auto_register_tags(
           ^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/ktokarev/venv/ferminet/lib/python3.11/site-packages/kfac_jax/_src/tag_graph_matcher.py", line 2080, in auto_register_tags
    func_graph, tagged_locations = _auto_register_tags(
                                   ^^^^^^^^^^^^^^^^^^^^
  File "/home/ktokarev/venv/ferminet/lib/python3.11/site-packages/kfac_jax/_src/tag_graph_matcher.py", line 1849, in _auto_register_tags
    sub_graph, sub_tag_locations = _auto_register_tags(
                                   ^^^^^^^^^^^^^^^^^^^^
  File "/home/ktokarev/venv/ferminet/lib/python3.11/site-packages/kfac_jax/_src/tag_graph_matcher.py", line 1915, in _auto_register_tags
    matches = find_layer_tags_and_patterns(
              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/ktokarev/venv/ferminet/lib/python3.11/site-packages/kfac_jax/_src/tag_graph_matcher.py", line 864, in find_layer_tags_and_patterns
    match = match_pattern(
            ^^^^^^^^^^^^^^
  File "/home/ktokarev/venv/ferminet/lib/python3.11/site-packages/kfac_jax/_src/tag_graph_matcher.py", line 767, in match_pattern
    if len(pattern.jaxpr.outvars) != len(root_eqn.outvars):
           ^^^^^^^^^^^^^
  File "/home/ktokarev/venv/ferminet/lib/python3.11/site-packages/kfac_jax/_src/tag_graph_matcher.py", line 478, in jaxpr
    return self.graph.jaxpr
           ^^^^^^^^^^
  File "/usr/lib/python3.11/functools.py", line 1001, in __get__
    val = self.func(instance)
          ^^^^^^^^^^^^^^^^^^^
  File "/home/ktokarev/venv/ferminet/lib/python3.11/site-packages/kfac_jax/_src/tag_graph_matcher.py", line 488, in graph
    return make_jax_graph(
           ^^^^^^^^^^^^^^^
  File "/home/ktokarev/venv/ferminet/lib/python3.11/site-packages/kfac_jax/_src/tag_graph_matcher.py", line 355, in make_jax_graph
    closed_jaxpr, out_shapes = jax.make_jaxpr(func, return_shape=True)(*func_args)
                               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
TypeError: _dense() missing 2 required positional arguments: 'axes' and 'with_reshape'
--------------------

Same error reproduces for me with other calculations. I also tried switching used kfac_jax revision from the head of main branch to a few recent commits, with exactly the same error happening.
Any idea what's going on and how can I make it work?

This bug also popped up when I tried to run it on a server. It seems that problems are resulted from kfac optimizer. After I substitude it by adam, everything works fine. However, the same version of modified codes on my own server works perfect with kfac optimzer, which was deployed in September. I'm also trying to figure out what's wrong with the mess. It is puzzling for kfac lib hasn't be updated since April and I use version 0.0.6 consistently.

It is puzzling for kfac lib hasn't be updated since April and I use version 0.0.6 consistently.

By default FermiNet uses master of kfac-jax which is updated quite often (and, according to its git history, those updates sometimes break things in other projects). I've tried to use 0.0.6 but it just didn't work.

It occurs to me that kfac-jax has a recent commit, which seems not to be compatible with this version of ferminet. So you can just pull down a history commit of version 0.0.6  kfac-jax and mannualy install it via python -m build command. I fixed this problem by replacing the latest version with commit hash code "315f59e".

It occurs to me that kfac-jax has a recent commit, which seems not to be compatible with this version of ferminet. So you can just pull down a history commit of version 0.0.6 kfac-jax and mannualy install it via python -m build command. I fixed this problem by replacing the latest version with commit hash code "315f59e".

Hi @SeldonHarry
Thanks for the inspiring hint! I am also struggling with running the sample code, but with a different error. I am wondering if you have encountered this problem #88
And I can't appreciate more if you can share the environment configuration that you are using. Many thanks in advance.

I fixed this problem by replacing the latest version with commit hash code "315f59e".

I'm sorry but I can see no such commit in kfac-jax: google-deepmind/kfac-jax@315f59e

This is from a change in the KFAC API (specifically this commit). I've just push an update which handles this change. (An alternative, as @SeldonHarry suggests, is to ping kfac-jax to a version just before the API change.)
Please re-open if this doesn't fix things for you.

@dibbla I haven't met such error till now. But I guess that it's caused  by jax and jaxlib. My packgages managed by pip is listed as follows:

config
Package                  Version     Editable project location

absl-py                  2.1.0
attrs                    24.2.0
build                    1.2.2.post1
cachetools               5.5.0
chex                     0.1.87
cloudpickle              3.1.0
decorator                5.1.1
distrax                  0.1.5
dm-tree                  0.1.8
etils                    1.11.0
ferminet                 0.2         /mnt/nas2/home/pankaisen/seldon/GraphQMC
flax                     0.10.2
folx                     0.2.12
fsspec                   2024.10.0
gast                     0.6.0
h5py                     3.12.1
humanize                 4.11.0
immutabledict            4.2.1
importlib_resources      6.4.5
iniconfig                2.0.0
jax                      0.4.34
jax-cuda12-pjrt          0.4.34
jax-cuda12-plugin        0.4.34
jaxlib                   0.4.34
jaxtyping                0.2.36
jraph                    0.0.6.dev0
kfac-jax                 0.0.6
markdown-it-py           3.0.0
mdurl                    0.1.2
ml_collections           1.0.0
ml_dtypes                0.5.0
msgpack                  1.1.0
nest-asyncio             1.6.0
numpy                    2.1.3
nvidia-cublas-cu12       12.6.4.1
nvidia-cuda-cupti-cu12   12.6.80
nvidia-cuda-nvcc-cu12    12.6.85
nvidia-cuda-runtime-cu12 12.6.77
nvidia-cudnn-cu12        9.6.0.74
nvidia-cufft-cu12        11.3.0.4
nvidia-cusolver-cu12     11.7.1.2
nvidia-cusparse-cu12     12.5.4.2
nvidia-ml-py             12.535.161
nvidia-nccl-cu12         2.23.4
nvidia-nvjitlink-cu12    12.6.85
nvitop                   1.3.2
opt_einsum               3.4.0
optax                    0.2.4
orbax-checkpoint         0.10.2
packaging                24.2
pandas                   2.2.3
parameterized            0.9.0
pip                      24.2
pluggy                   1.5.0
protobuf                 5.29.1
psutil                   6.1.0
pyblock                  0.6
Pygments                 2.18.0
pyproject_hooks          1.2.0
pyscf                    2.7.0
pytest                   8.3.4
python-dateutil          2.9.0.post0
pytz                     2024.2
PyYAML                   6.0.2
rich                     13.9.4
scipy                    1.14.1
setuptools               75.1.0
simplejson               3.19.3
six                      1.17.0
tensorflow-probability   0.25.0
tensorstore              0.1.69
termcolor                2.5.0
toolz                    1.0.0
typing_extensions        4.12.2
tzdata                   2024.2
wheel                    0.44.0
zipp                     3.21.0

authors: SeldonHarry annulen dibbla jsspencer

repo: google-deepmind/ferminet

license_source: github-api


text:
Colab demo limit

Is there a limit on the number of times someone can run the gencast_demo_cloud_vm.ipynb demo on the Colab using the TPU2 hardware?  I ran it yesterday as far as plotting the ensemble outputs.  Now I want to run the training part of the demo, but it won't let me past the part where it asks for paths to model data.

Works via this link
https://colab.research.google.com/github/deepmind/graphcast/blob/master/gencast_mini_demo.ipynb

repo: google-deepmind/graphcast


text:
Shirt/Cloth Simulation with <flexcomp> diverging

Hi!
I'm an undergrad student trying to use MuJoCo for cloth simulation, specifically that of a t-shirt, for robot-assisted dressing.
I'm looking for some help with setting up the XML file correctly with the elasticity plugin and other flexcomp parameters to get the shirt to behave correctly.
Here is the shirt XML I'm currently working with:

Shirt `worldbody` XML
<worldbody>
    <geom name="floor" pos="0 0 -1" size="0 0 .25" type="plane" material="plane" condim="3" />

    <!-- Shirt -->
    <flexcomp name="shirt_flex" type="mesh" radius="0.01" dim="2" pos="0 0 2"
      file="shirt_lowpoly_tetra_again.obj">
      <contact solref="0.003" />
      <edge equality="true" damping="0.1" />
      <plugin plugin="mujoco.elasticity.shell">
        <config key="poisson" value="0" />
        <config key="thickness" value="8e-3" />
        <config key="young" value="3e5" />
      </plugin>
    </flexcomp>
</worldbody>

When I run the simulation with simulate.exe, I see the shirt violently diverge to infinity and crash repeatedly:

Shirt Diverging
https://github.com/google-deepmind/mujoco/assets/47724806/5038c8d8-a199-43ae-ab69-3772f0ac79fb

I receive the following output in the simulate terminal:

Terminal Output

Finally, here's a quick visual of the tetrahedron mesh I'm using, which I generated with fTetWild:

Shirt Mesh
https://github.com/google-deepmind/mujoco/assets/47724806/f4b3966f-0bf3-4b49-865d-f9d0a5296a73

Any idea on what I can change? I'm expecting similar-ish results to the poncho_flex.xml example provided with MuJoCo, which is what I used to model this scene after.

Hey, can you share shirt_lowpoly_tetra_again.obj with us?
Here are some steps you can try on your own:
1.Ftetwild outputs .msh format. This format will be in gmsh2.2

You need to convert this using gmsh app. Import the file with extention .msh generated by ftetwild and then export it to format 4.

Use the file exported by gmsh app in your xml. The file should have extension .msh.

If you share the .obj file I can also test it :)

Does it still diverge if you reduce the time step?

Hey, can you share shirt_lowpoly_tetra_again.obj with us?
Here are some steps you can try on your own: 1.Ftetwild outputs .msh format. This format will be in gmsh2.2

You need to convert this using gmsh app. Import the file with extention .msh generated by ftetwild and then export it to format 4.
Use the file exported by gmsh app in your xml. The file should have extension .msh.

If you share the .obj file I can also test it :)

Sure, here's the file I'm using: Google Drive Link
Although I did get a .msh mesh, I needed to use the .stl output since the .stl "tracked surface" mesh is the only once that has a hollow inside--the other mesh outputs all had closed sleeves, torso holes, etc. To generate my .obj file, I then converted this .stl file into a .obj with MeshLab.
I just tried converted the .stl to a .msh with gmsh, but get an error when using this mesh for my MJCF:

Does it still diverge if you reduce the time step?

Unfortunately, yes. I reduced the timestep at least to where I can see the diverging happening incrementally, though, if it's helpful (reset happens at ~3 seconds):
https://github.com/google-deepmind/mujoco/assets/47724806/0e3d6141-0b47-4e8a-80a2-bad5beb636df

Can you share the entire XML?

Can you share the entire XML?

Of course! Here's the entire XML content (in shirt.xml). The timestep might be absurdly low just because I wanted to test the above behavior.
<mujoco model="Shirt">
  <option timestep="0.0002" solver="CG" iterations="30" tolerance="1e-6" />

  <size memory="200M" />

  <extension>
    <plugin plugin="mujoco.elasticity.shell" />
  </extension>

  <visual>
    <map force="0.1" zfar="30" />
    <rgba haze="0.15 0.25 0.35 1" />
    <quality shadowsize="2048" />
    <global offwidth="800" offheight="800" />
  </visual>

  <asset>
    <texture name="plane" type="2d" builtin="checker" rgb1=".2 .3 .4" rgb2=".1 0.15 0.2"
      width="512" height="512" mark="cross" markrgb=".8 .8 .8" />
    <texture name="hammock" type="2d" builtin="checker" rgb1=".1 .5 .1" rgb2=".5 .1 .1"
      width="512" height="512" mark="edge" markrgb=".8 .8 .8" />
    <material name="plane" reflectance="0.3" texture="plane" texrepeat="1 1" texuniform="true" />
    <material name="hammock" texture="hammock" />
  </asset>

  <worldbody>
    <geom name="floor" pos="0 0 -1" size="0 0 .25" type="plane" material="plane" condim="3" />

    <!-- Shirt -->
    <flexcomp name="shirt_flex" type="mesh" radius="0.01" dim="2" pos="0 0 2"
      file="shirt_lowpoly_tetra_again.obj">
      <contact solref="0.003" selfcollide="none" />
      <edge equality="true" damping="0.1" />
      <plugin plugin="mujoco.elasticity.shell">
        <config key="poisson" value="0" />
        <config key="thickness" value="8e-3" />
        <config key="young" value="3e5" />
      </plugin>
    </flexcomp>

    <!-- Lights -->
    <light directional="true" diffuse=".2 .2 .2" specular="0 0 0" pos="0 0 5" dir="0 0 -1"
      castshadow="false" />
    <light directional="false" diffuse=".8 .8 .8" specular="0.3 0.3 0.3" pos="0 0 4" dir="0 0 -1" />
  </worldbody>
</mujoco>

Let me know if you'll need anything else!

It looks like a time step stability issue to me.
Also note that the cloth model assumes a flat equilibrium configuration. I haven't had the time yet to implement the case of a curved cloth. You should still get some smoothing effect by setting a lower bending that the one you have because anyway the bending forces are not strong enough to counteract gravity.
Finally, please check carefully that your mesh doesn't have very tiny triangles with nearly zero area.

Hi @thisjustin123 I've been playing with the model and I can give the following recommendations:

Use internal="false" in your flex contact parameters since there are vertices that overlap and generate huge contact forces (turn on Contact Point and Flex Vert in the rendering panel if you want to see).
Decrease the young to something like 5e3, if I turn off gravity a value higher than this does not seem realistic for a cloth because it flattens everything too quickly.
Perhaps increase the damping to 1 or 10.

repo: google-deepmind/mujoco


text:
Unsupported PDF type

Description of the bug:
Trying to process a pdf throws an error saying the file type is not supported. gemini-1.5-pro-latest:generateContent: [400 Bad Request] Unsupported MIME type: application/pdf
Actual vs expected behavior:
Throughs the error of mime type not supported when in theory it is.
Any other information you'd like to share?
I'm using the code generated from Gemini Studio with small changes as the js version from studio does not seem to be the same as the latest release on npm.
For example the GoogleAIFileManager has to be access through the /serve subpath and not the /files subpath as Gemeni Studio does.
All files seem to upload without an issue and their state is active.
Thanks for the work in advance if I can be of assistance, happy to help.

@Flucadetena, Gemini API doesn't directly handle PDFs yet. This is not related to JS SDK. You can do something like this to upload the text and/or screenshots: convert a PDF file so that it can be read by the Gemini API.
If the above tutorial doesn't fits your use-case, we would suggest you to use "Send Feedback" option in Gemini docs. Ref: Screenshot below. You can also post this issue on Discourse forum.

@singhniraj08 great thank you very much for the quick answer. It was just confusing as the code generate by "Google Studio" uses de JS SDK of Gemini and works. But I understand that it may use some version in development or use some workaround with Vertex AI that does not share.
Thanks a lot!

repo: google-gemini/generative-ai-js


text:
Giving ncon a pythonic makeover

The function ncon is powerful and beloved by veteran tensor networkers. Yet despite its prowess, its matlabian exterior prevents it from feeling like a natural python function. First, edge indices that start at 1 don't mesh well with python nor with TN in general where tensor axes that start at index 0. Second, python has a nice alternative to passing in two lists of associated things.
Here are a few ideas on how to adapt ncon to python.
Given tensors left, mid and right, an example of the current syntax is:
ncon([left, mid, right],  [[1, -1], [1, -2, 2], [2, -3]])
If instead of negative numbers, complex numbers are used to represent dangling edges, 0-based indexing is possible. In addition, replacing the two related lists with a dictionary brings edge indices next to their associated tensors, removes a nesting of lists and reduces the number of function arguments by one:
ncon({left:[0, 0j], mid:[0, 1j, 1], right: [1, 2j]})
Alternatively, one could use strings instead of lists with d representing dangling edges:
ncon({left:'0, 0d', mid:'0, 1d, 1', right:'1, 2d'})
I'd be curious to hear thoughts from the various stakeholders, especially the black belt ncon users.

Hey @repst thanks for the proposal. Sounds very interesting to me! Let me think a bit about this. Also roping in @gevenbly on this one!

This seams very much in the spirit of the "functional node" design we discussed months prior.
The idea was very similar to what you are describing, only instead of wrapping everything in a single ncon function, you would build the contraction like
left = tn.Tensor(...)
mid = tn.Tensor(...)
right = tn.Tensor(...)
resultbuilder = left['0,0d'] @ mid['0, 1d, 1'] @ right['1, 2d']
result = resultbuilder['0d,1d,2d'].to_tensor() # tn.Tensor

oh no

wait didn't Martin and Glen implement the string thing as "fancy ncon"? what happened to that?
anyway so basically the concern is how to handle contractions involving, say, 10 or more tensors with 15 legs each or something. in addition one needs a means to specify the contraction order, ideally without having to rewrite the whole thing
it's felt by some that ncon improves this situation compactly and by others that it leads to weird and ugly code with three 900 character lines. I personally maintain a skillful balance of harmonious neutrality equal to that of the resting crane.

anyway ncon probably needs to exist roughly as is because the old tn guard will otherwise flatly refuse to use the library. however alternative interfaces useful to others are welcome, at least to my mind.

Ultimately, it seems like it would essentially be a shim to just calling ncon outright with a different user facing API. I welcome PRs for desired interfaces! No reason we can't evolve things.

I have a couple of issues with the syntax @repst has suggested.
(i) It is a relatively common occurrence to contract networks containing many copies of the same tensor. I don't see how this would work using a dictionary, unless each tensor copy was first given a distinct name (which is something that should be avoided).
(ii) It is also a relatively common occurrence to evaluate the same network geometry with different sets of input tensor lists, such as:
TA = ncon(tensorsA,connects)
TB = ncon(tensorsB,connects)

I may be missing something, but I don't see how this could be handled in an elegant way when using dicts. It is also sometimes necessary to evaluate different network geometries that contain exactly the same set of tensors. For these reasons, having the two separate arguments to ncon (a list of tensors and a list of connections) is often quite convenient.
In general, I don't have any problem with the thought of introducing a more pythonic version of ncon, but I think the ncon name should be reserved for a function which remains compatible with the existing syntax. I think that it is very useful to be able to easily port ncon based tensor network codes between Python, Julia and Matlab.

As Glen has pointed out, using a single input tensor many times within ncon would not be possible with a dict without introducing additional steps for the user. I agree that this is something that we want to avoid (calls to ncon should remain as compact as they are now).
As @alewis mentioned, the current version of ncon supports strings for labelling tensor legs. The idea of using imaginary numbers to denote dangling edges sounds interesting. This convention should though be as seamlessly as possible be applicable to string labels. At the moment we are using a hyphen ("-") to denote dangling edges with string labels, i.e.
AB = ncon([A,B],[['-final_row', 'contracted'],['contracted','-final_column']])

which looks similar to the minus sign for integers.

I actually like the interface Chase suggested in this thread, to be clear. In many (not all) cases I think it will lead to more
comprehensible code, for example by allowing a complicated tensor network with a recursive structure to be built as a recursion. Mostly I think we dropped the matter because we decided the numerics took a higher priority.

While I'm all in favor of developing ideas for new interfaces, I think we should avoid having too many different APIs available to the user in parallel.

I would generally agree, but in this case I think we'll be ok. Like you said we only have 2 APIs at the moment (the all-in-one ncon and the node/edge object oriented design), and each have some pretty strong weaknesses. Ncon becomes unmanageable beyond a handful of tensors, and the node/edge design is really cumbersome when you want to do anything beyond basic contractions.
I think I can build a prototype of the functional design that's built off the existing ncon pretty easily.

Thanks for indulging the new guy stirring up trouble. This is very helpful discussion. Let me stuff some of the worms back in the can for the moment and focus on the most important part (to me): mixed use of 1-based and 0-based indexing in the TN library. This is a bit of a sore subject as my coworker has spent many hours tracking down a bug in our code due to iTensor's 1-based indexing in 0-based C++.
@gevenbly, what would you think about a minimal change to ncon syntax for languages with 0-based indexing? Using imaginary instead of negative numbers to indicate dangling edges seems the most similar to me but there are other options as well. Thinking about implications for TensorTrace, since one already specifies which language to use, it could adapt the ncon indexing to the language.

Does base Python support imaginary int types? I think it would be sorta bad to make the labels floats.

@mganahl's point about keeping the dangling flag similar for string types is important as well.

@repst, I think that ncon could be written to simultaneously accommodate 0-based and 1-based indexing, and it is a good idea to do so. This could be done using the existing syntax, where one could either label the dangling indices [-0,-1,-2,...] or [-1,-2,-3,...]. The only restriction would be, in the former case, that 0 could not be used as a label over the internal (contracted) indices. This should not be a problem as the labels over the internal indices are only dummy labels so it does not matter what we call them (i.e. whether one labels internal indices as [1,2,3,...] or [8,12,15...] or [1,2,'a1','a2',...] does not make any difference, as they are just used to match pairs of contracted indices)

Yeah Glen's answer might be the correct one. We currently disallow 0, so reallowing it and always making it a dangling leg might be ok.

@alewis @mganahl Didn't 0 have a special meaning in the original matlab ncon?

I like Glen's answer. I don't really know how the original matlab ncon worked, so I'll leave that to @mganahl

I'm happy with @gevenbly's solution too as it resolves the main issue. I think it could be made clear in the documentation that -0 should be used instead of 0 by convention for code readability.

Oh, @gevenbly, do you mind providing a code snippet of repeated use of the same tensor with ncon? I think it would be useful to have that documented here lest I suggest dictionaries again some day!

@repst Here is a short example of applying an H gate twice.
a = np.array(...)
H = np.array(...)
result = tn.ncon([a, H, H], [[1], [1, 2], [2, -1]])

The version of ncon on arxiv had something called 'zeros-in-sequence' notation, where the outer product of two tensors could be understood as having two tensors connected by a trivial-dim index labelled 0 by convention. This could be used to force an outer product to be evaluated in the middle of a contraction. This was something introduced solely at the discretion of Rob Pfeifer (who wrote that ncon version). I never used this feature myself, nor do I feel that it is a useful thing to have (as I don't think there exists any cases in which this would result in a more efficient contraction).

Great! We should allow 0 as a dangling leg then. Erroring out when seeing multiple 0s should fix any (unlikely) porting issues.

I'll assign myself unless someone else is eager to fix it!

Erroring out when seeing multiple 0s should fix any (unlikely) porting issues.

I assume we'll still want open batch labels.

That's right, multiple free labels are fine.

authors: Thenerdstation alewis gevenbly mganahl repst

repo: google/TensorNetwork


text:
[IT] Feedback for: /fundamentals/layouts/rwd-fundamentals/use-media-queries.html

Subito dopo l'esempio con le media query per selezionare i diversi file CSS da applicare, la frase "Se l’altezza del browser è superiore all’altezza viene applicato portrait.css." è sbagliata. In particolare, la seconda "altezza" dovrebbe essere sostituita da "larghezza".

Translation: Immediately following the example with media queries to select the different CSS files to be applied, the phrase "If the height is greater than the height of the browser is applied portrait.css." is wrong. In particular, the second "height" should be replaced by "width".

Fixed, not 100% sure I got it right, but it's better than it was.

authors: msorgato petele

repo: google/WebFundamentals


text:
Deprecate KV storage

What's changed, or what was fixed?

deprecate KV storage

cc: @philipwalton

Whoops!
There were 10 warnings that will prevent this PR from being merged. Please take a look, and either fix, or provide a justification for why they can't be fixed.
WARNINGS
src/content/en/updates/2019/03/kv-storage.md#L188 - '

source: gharchive/pull-request

authors: WebFundBot petele


text:
Rename from CamelCase to snake_case

[ ] Tests pass
[ ] Appropriate changes to README are included in PR

CamelCase filename should be renamed to snake_case.
If ac-library.cr was installed via shards, it can be used like below and can be used like other standard library.
require "atcoder/fenwick_tree"
tree = AtCoder::FenwickTree(Int64).new(10)

And I add src/atcoder.cr to load all library.
Reference

05. Shards _ Introducing Crystal Programming Language （日本語）

List

atcoder.cr
convolution.cr
dsu.cr
fenwick_tree.cr
graph.cr
lazy_seg_tree.cr
math.cr
max_flow.cr
min_cost_flow.cr
mod_int.cr
prime.cr
priority_queue.cr
red_black_tree.cr
scc.cr
seg_tree.cr
skew_heap.cr
two_sat.cr

Codecov Report

Merging #7 (79097d5) into master (1e5a209) will not change coverage.
The diff coverage is n/a.

:exclamation: Current head 79097d5 differs from pull request most recent head 939f7fa. Consider uploading reports for the commit 939f7fa to get more accurate results

@@           Coverage Diff           @@
##           master       #7   +/-   ##
=======================================
  Coverage   85.90%   85.90%
=======================================
  Files          13       13
  Lines         830      830
=======================================
  Hits          713      713
  Misses        117      117

Impacted Files
Coverage Δ

src/convolution.cr
88.23% <ø> (ø)

src/dsu.cr
96.00% <ø> (ø)

src/fenwick_tree.cr
88.00% <ø> (ø)

src/graph.cr
92.50% <ø> (ø)

src/lazy_seg_tree.cr
77.77% <ø> (ø)

src/math.cr
82.82% <ø> (ø)

src/min_cost_flow.cr
93.67% <ø> (ø)

src/mod_int.cr
100.00% <ø> (ø)

src/prime.cr
94.35% <ø> (ø)

src/priority_queue.cr
91.17% <ø> (ø)

... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


text:
Accessing the SAM D09's 12-bit ADC

The Vision Bonnet exposes a few of the SAM D09's analog pins (PA04 and PA05). Are there any Python API examples of reading voltage values from these pins?

You can use kernel IIO subsystem to read voltages:
cat /sys/bus/iio/devices/iio\:device0/in_voltage0_user0_input
cat /sys/bus/iio/devices/iio\:device0/in_voltage1_user1_input
cat /sys/bus/iio/devices/iio\:device0/in_voltage2_user2_input
cat /sys/bus/iio/devices/iio\:device0/in_voltage3_user3_input

I just confirmed this works for PA04 (A). Cool! And thank you...
I'm surprised you can use PA10 (C) and PA11 (D) for analog input. According to the SAM D09 datasheet, those are digital pins.

Datasheet actually looks correct:

You're right. The datasheet I was looking at had a diagram that led me to believe those were digital-only pins.

Alright, I guess this can be closed :)

authors: Exscotticus dmitriykovalev

repo: google/aiyprojects-raspbian


text:
Allow AudioNodes to be GCed when DevTools is closed.

The extension maintains a mapping between node ID (a unique value assigned to each AudioNode) and AudioNode for each web page.
https://github.com/google/audion/blob/795545d1692d11a0348556827622c997dbc9502e/js/entry-points/tracing.js#L108
This means that AudioNodes are never garbage-collected, but we do allow the user to obtain a reference to any AudioNode via the __node__ function. However, when Developer Tools is closed, there should be no reason for the extension to maintain references to AudioNodes.
Today, when the extension's background script receives a web audio update from a tab, it tries to find a connection to a dev tools instance (and such a connection only exists if dev tools is open for that tab):
https://github.com/google/audion/blob/795545d1692d11a0348556827622c997dbc9502e/js/entry-points/background.js#L119
We should add an else block to that logic: If dev tools is closed, we send a MISSING_AUDIO_UPDATES message ...
https://github.com/google/audion/blob/795545d1692d11a0348556827622c997dbc9502e/js/entry-points/background.js#L192
back to the content script of the tab telling the page to drop all references. This message is routed through the content script to code injected within the page itself.
https://github.com/google/audion/blob/795545d1692d11a0348556827622c997dbc9502e/js/entry-points/inject-tracing.js#L30
The injected logic would then handle that message appropriately.
https://github.com/google/audion/blob/795545d1692d11a0348556827622c997dbc9502e/js/entry-points/tracing.js#L1184

Fixed in 0.1.4.

repo: google/audion


text:
warning for missing require when using addSingletonGetter

I have this code:
// app.js
goog.module('app');

var ColorWheel = goog.require('pstj.graphics.ColorWheel');
var cw = ColorWheel.getInstance();

// colorwheel.js
goog.module('pstj.graphics.ColorWheel');

var ColorWheel = class ColorWheel {
  constructor() {/** impl */
};
goog.addSingletonGetter(ColorWheel);
exports = ColorWheel;

and I get this warning:
missing require: 'module$exports$pstj$graphics$ColorWheel.getInstance'
var cw = ColorWheel.getInstance();
         ^

Why is this a missing require? I think this might be a bug.

I just saw a similar case recently and @blickly and I were discussing a plan to fix this. Eventually we'll move the checkRequires pass before the goog.module rewriting pass, and that should make this go away. For now, you can make that pass locally in your own copy of the compiler, or turn off the lintChecks group. I would recommend the latter both because it's simpler and because you can get the same checks from the standalone linter, without these false positives.

It looks like this might be fixed already.
https://closure-compiler-debugger.appspot.com/#input0%3Dgoog.module('pstj.graphics.ColorWheel')%253B%250A%250Avar%2520ColorWheel%2520%253D%2520class%2520ColorWheel%2520%257B%250A%2520%2520constructor()%2520%257B%252F**%2520impl%2520*%252F%257D%250A%257D%253B%250Agoog.addSingletonGetter(ColorWheel)%253B%250Aexports%2520%253D%2520ColorWheel%253B%26input1%3Dgoog.module('app')%253B%250A%250Avar%2520ColorWheel%2520%253D%2520goog.require('pstj.graphics.ColorWheel')%253B%250Avar%2520cw%2520%253D%2520ColorWheel.getInstance()%253B%26conformanceConfig%26externs%3Dvar%2520goog%253B%250Agoog.addSingletonGetter%253B%26refasterjs-template%26includeDefaultExterns%3D1%26CHECK_REQUIRES%3D1%26CHECK_SYMBOLS%3D1%26CHECK_TYPES%3D1%26CLOSURE_PASS%3D1%26LANG_IN_IS_ES6%3D1%26MISSING_PROPERTIES%3D1%26PRESERVE_TYPE_ANNOTATIONS%3D1%26PRETTY_PRINT%3D1%26TRANSPILE%3D1

Looks like this has been fixed. Closing.

I think the strictMissingRequires check in the v20160713 compiler reintroduces this issue.

Okay I'll try to take another look soon.

@pstjvn @hochhaus I think this has been fixed (again) ?

Yes, I have not seen these issues recently.

@hochhaus Great, thanks for verifying.

I am constantly seeing this issue whenever i try to do getInstance.

authors: Dominator008 MatrixFrog dashersw hochhaus pstjvn

repo: google/closure-compiler


text:
Getters and setters with computed property names crash the compiler

This a regression since v20190415, observed on latest master (9b7948222de73987cceff3e394147b4218a50559).
Here are the steps to reproduce.
First build the mentioned commit with:
mvn -DskipTests -pl externs/pom.xml,pom-main.xml,pom-main-shaded.xml

Create the file test.js with:
class Bug {
  get ["member"]() {
    return 42;
  };
}
console.log(new Bug());

Then run:
$ java -jar target/closure-compiler-1.0-SNAPSHOT.jar --js_output_file=out.js -O SIMPLE_OPTIMIZATIONS --language_out ECMASCRIPT_2015 --jscomp_off '*' test.js

Observe the following result:
java.lang.RuntimeException: INTERNAL COMPILER ERROR.
Please report this problem.

COMPUTED_PROP 2 [length: 37] [source_file: test.js] [computed_prop_getter: 1] is not a string node
  Node(CLASS_MEMBERS): test.js:1:0
class Bug {
  Parent(CLASS): test.js:1:0
class Bug {

        at com.google.javascript.rhino.Node.getString(Node.java:1234)
        at com.google.javascript.jscomp.DeadPropertyAssignmentElimination$GetterSetterCollector.visit(DeadPropertyAssignmentElimination.java:529)
        at com.google.javascript.jscomp.NodeTraversal.traverseClassMembers(NodeTraversal.java:965)
        at com.google.javascript.jscomp.NodeTraversal.traverseBranch(NodeTraversal.java:859)
        at com.google.javascript.jscomp.NodeTraversal.traverseClass(NodeTraversal.java:951)
        at com.google.javascript.jscomp.NodeTraversal.traverseBranch(NodeTraversal.java:857)
        at com.google.javascript.jscomp.NodeTraversal.traverseChildren(NodeTraversal.java:979)
        at com.google.javascript.jscomp.NodeTraversal.handleScript(NodeTraversal.java:804)
        at com.google.javascript.jscomp.NodeTraversal.traverseBranch(NodeTraversal.java:839)
        at com.google.javascript.jscomp.NodeTraversal.traverseChildren(NodeTraversal.java:979)
        at com.google.javascript.jscomp.NodeTraversal.traverseBranch(NodeTraversal.java:863)
        at com.google.javascript.jscomp.NodeTraversal.traverse(NodeTraversal.java:371)
        at com.google.javascript.jscomp.NodeTraversal.traverse(NodeTraversal.java:381)
        at com.google.javascript.jscomp.DeadPropertyAssignmentElimination.process(DeadPropertyAssignmentElimination.java:80)
        at com.google.javascript.jscomp.PhaseOptimizer$NamedPass.process(PhaseOptimizer.java:328)
        at com.google.javascript.jscomp.PhaseOptimizer$Loop.process(PhaseOptimizer.java:473)
        at com.google.javascript.jscomp.PhaseOptimizer.process(PhaseOptimizer.java:237)
        at com.google.javascript.jscomp.Compiler.performOptimizations(Compiler.java:2380)
        at com.google.javascript.jscomp.Compiler.lambda$stage2Passes$1(Compiler.java:780)
        at com.google.javascript.jscomp.CompilerExecutor$2.call(CompilerExecutor.java:102)
        at java.util.concurrent.FutureTask.run(FutureTask.java:266)
        at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
        at java.lang.Thread.run(Thread.java:748)
Caused by: java.lang.UnsupportedOperationException: COMPUTED_PROP 2 [length: 37] [source_file: test.js] [computed_prop_getter: 1] is not a string node
        ... 24 more

The issue cannot be reproduced with v20190415. It also cannot be reproduced with WHITESPACE_ONLY (it is only triggered by the simple or advanced optimizations).
The issue can also be reproduced with a setter instead of a getter.
git bisect says that the culprit is d52df21eb3dbd31d47d385de38e72ce5327745b3. git reverting that commit on top of master fixes the issue.

Created internal issue http://b/132178796
@sjrd,  thanks a lot for identifying the breaking commit!

Fixed by 4ff08d2

Thank you!

authors: EatingW brad4d sjrd


text:
Create release process

We need to determine the process to follow when creating a release. It should include at least:

Building and testing on all supported platforms.
Updating the OpenGEE website with the documentation for the latest release (we plan to make the documentation for several releases available, but the website should go to the docs for the latest release by default).

Also publish 5.2.0 documentation on opengee.org

The website for this is available at https://tst-eclamar.github.io/earthenterprise/

The release process is documented here: https://github.com/google/earthenterprise/wiki/Development:-Release-Process.

authors: tst-eclamar tst-lsavoie

repo: google/earthenterprise


text:
Cannot pickle linen Modules

I am using 0.3.4 and I am getting an error when trying to pickle flax modules, specifically Dense seems to be the problem but other might have similar issues.
Problem you have encountered:
from flax import linen
import pickle

with open("model.pkl", "wb") as f:
    model = pickle.dump(linen.Dense(10), f)

Traceback (most recent call last):
File "test.py", line 8, in
model = pickle.dump(linen.Dense(10), f)
AttributeError: Can't pickle local object 'variance_scaling..init'

While the previous is solved with cloudpickle, this other code doesn't work:
import cloudpickle
from flax import linen
import pickle

class IndentityFlax(linen.Module):
    def __call__(self, x):
        return x

with open("mlp.pkl", "wb") as f:
    cloudpickle.dump(IndentityFlax(), f)

Traceback (most recent call last):
File "test.py", line 25, in
cloudpickle.dump(IndentityFlax(), f)
File "/data/cristian/elegy/.venv/lib/python3.8/site-packages/cloudpickle/cloudpickle_fast.py", line 55, in dump
CloudPickler(
File "/data/cristian/elegy/.venv/lib/python3.8/site-packages/cloudpickle/cloudpickle_fast.py", line 563, in dump
return Pickler.dump(self, obj)
TypeError: cannot pickle '_thread._local' object

Ok, this exact example seems to work with cloudpickle but I am getting another error serializing a flax.linen.Module object. I will try to get a reproducible example.

So I found an example that doesn't work with cloudpickle, see updated issue.

(cloud)pickle issues are a little tricky. For some reason cloudpickle tries to serialize Flax internals. I spend some time before looking into it but my main issue with cloudpickle is that there doesn't seem to be a specification of their algorithm and of course the implementation is black-magic Python. I think the minimal thing we need to officially support a library like cloudpickle is a guide that explains what constraints we should adhere to in order to support cloudpickle. Perhaps something like this does exist but I couldn't find anything last time I looked for it.
You could of course also raise an issue with the cloudpickle team to see if this is even expected behavior from their side in the first place.

@jheek You happen to know which Flax internal object its trying to serialize? I am a bit hesitant to ping cloudpickle without a reproducible example that doesn't involve a whole library (flax) as part of it.
If flax users are not using pickle, what is the current recommended way to serialize flax models?

Yeah I agree we should try to minimize the repro. I tried out your pickle example and I was able to remove Flax from the equation:
init_fn = jax.nn.initializers.lecun_normal()
with open("model.pkl", "wb") as f:
    model = pickle.dump(init_fn, f)

So here it's really JAX that is producing a partial function that cannot be pickled.
For cloudpickle I'm not so sure what's going on but it essentially finds an internal ThreadLocal object and decides that it needs to serialize it. This I think doesn't make sense. After all only library methods touch this object (which it shouldn't serialize) and the ThreadLocal object is itself is defined top-level in the module so again it shouldn't try to serialize this object. This pattern of having state in a ThreadLocal object is quite common in Python so I think this should really be fixed in cloudpickle but perhaps I'm overlooking some edge case in how we implemented this in Flax.

@jheek thanks for looking into this!
Its very weird as you say since both elegy and haiku Modules use ThreadLocal but only flax is having issues with cloudpickle. I am more interested about cloudpickle than pickle since its generally more robust and pickle doesn't work for haiku and elegy either so its not really an option.
I will send a PR to flax with a test using cloudpickle to make this effort a little more formal and maybe others can try to give it a shot if that is OK with the flax team.

I am curious indeed why other libraries that use ThreadLocal don't have this problem...

@cgarciae I found the issue. cloudpickle will not serialize functions that are part of a library but it does serialize other globals. I guess this is a python limitation (missing qualname I suppose?). We use the threadlocal inside a decorator function which will get serialized. All we have to do is factor out the body of the decorator into a method so cloudpickle doens't serialize its closure variables. I'm working on a PR

I had a similar issue with pickle recently and then simply switched to dill.
from flax import linen
import dill as pickle

with open("model.pkl", "wb") as f:
    model = pickle.dump(linen.Dense(10), f)

import jax
import dill as pickle

init_fn = jax.nn.initializers.lecun_normal()
with open("model.pkl", "wb") as f:
    model = pickle.dump(init_fn, f)

Both of these examples work with Flax 0.3.4 and Jax 0.2.18.

@jheek that is great news!
@matthias-wright I'll give dill a try :)

According to this answer on SO, cloudpickle seems to more aggressively pick up objects from the context than dill, which seems to be hurting in this case.

Just tested dill and it seems to fail for complex cases similar to regular pickle for flax, haiku, and elegy modules.

If flax users are not using (cloud)pickle, what is the current recommended way to serialize flax models?

We recommend that people serialize data, not code.  Our native serialization API only deals with model data, not model code.

for corporate users the use of libraries like pickle is often not allowed since it can enable arbitrary-code-execution payload vulnerabilities.
any pickle-like library leads to extreme brittleness in my experience as even small changes to code can break the import of older pickled save files.  So basically this imposes an indirect and ill-specified backwards-compatibility constraint on a library.  That's just unworkable inside a company monorepo environment, perhaps bearable with the library versioning available in the open-source world but still a footgun.  (So we for instance explicitly do not promise support for old cloudpickle serialized files in newer versions.)
the way we restore data from checkpoints lets us verify a "structural match" against the model the code creates vs that saved to disk, giving us an extra check that code and data are in sync.

Pickle was originally intended for RPC, and I know that cloudpickle is needed to support things like python in Spark.  For that use-case it's understandable wanting to be able to serialize for distributed engine support... but even there it's better to define remote calls that exchange data rather than serialized code objects.

+1 to the comments by @levskaya
Especially remote code execution is really overlooked. This is of course intended for RPC protocols like (but we really don't want a protocol with remote code execution as the standard way of distributing Flax models. I'm really curious how the PyTorch worlds thinks about this. The remote code execution problems is not mentions in the torch.save/load docs.

authors: avital cgarciae jheek levskaya matthias-wright

repo: google/flax


text:
Implement layout_minWidth and layout_minHeight

This allows you to specify a minimum size your view is allowed to
shrink to. #1
I plan to implement max-width/height as well in a separate commit, but I want to make sure I'm on the right track first.

Wow thank you! I won't have access to my laptop for a day or so, once I have one, let me start reviewing your code, thanks!

Took a first round of look. Could you confirm the comments? Thanks!

Updated in response to above comments

Hi, thanks for your continuous effort.
If any of my review comments are not clear, please feel free to let me know.

Hi, thank you for your contribution!
I self addressed my review comments in another PR based on your PR.
https://github.com/google/flexbox-layout/pull/51
So let me close this PR.

authors: evant thagikura

repo: google/flexbox-layout


text:
add rolename field to user struct

As a follow on from this PR - I also need to be able to access the role_name returned from the Repositories.ListCollaborators endpoint, and therefore have raised this PR to include the field in the user struct.

Hey @gmlewis - any chance we could get a release with this functionality?

repo: google/go-github


text:
Update the generator to es6 imports, run generator

Just another step in the TypeScript #503 work

This is broke.  Will fix in a bit....

repo: google/google-api-nodejs-client


text:
Could you please add the "trash method" of Files.php  like delete method?

Like   public function delete($fileId, $optParams = array())
{
$params = array('fileId' => $fileId);
$params = array_merge($params, $optParams);
return $this->call('delete', array($params));
}
Why not have the trash method aswell?
I know i can hack the file and  do it on my own, but i think you could also add it to the source code

Duplicate of #1366

@MiguelQueiroz The DIY workaround is to run the generator on the v2 json file. It may require a little Python knowledge though.

@MiguelQueiroz, I ran into this page last week: https://developers.google.com/drive/api/v3/migration
It explains why trash went away.
Looks like you can call update(['trashed'=>true])

authors: MiguelQueiroz mattwhisenhunt

repo: google/google-api-php-client


text:
proxy no working

Hi, I following this to set proxy:
// FOR DEBUGGING ONLY
$httpClient = new GuzzleHttp\Client([
    'proxy' => 'localhost:8888', // by default, Charles runs on localhost port 8888
    'verify' => false, // otherwise HTTPS requests will fail.
]);

$client = new Google_Client();
$client->setHttpClient($httpClient);

but it doesn't work,and if I try to set export https_proxy=127.0.0.1:10245 , the proxy is working.

@orvice What proxy application are you using? It looks like your proxy is listening on a different port. Try changing my example code to:
$httpClient = new GuzzleHttp\Client([
    'proxy' => '127.0.0.1:10245', // since this is what yours is running on
    'verify' => false, // otherwise HTTPS requests will fail.
]);

@bshaffer
Hi,
$httpClient = new GuzzleHttp\Client([
    'proxy' => '127.0.0.1:10245', // since this is what yours is running on
    'verify' => false, // otherwise HTTPS requests will fail.
]);

its still not working, and this proxy is working in my chrome.

What proxy software are you using? And what are you using the proxy for?

hi, I am using privoxy to cover a socket proxy to http  proxy,and this http proxy is working in chrome.
because google is blocked in china.

Using privoxy, I was able to do the following and get this to work:
$httpClient = new GuzzleHttp\Client([
    'proxy' => '127.0.0.1:8118', // this is the default privoxy port
    'verify' => false, // otherwise HTTPS requests will fail (THIS IS FOR DEBUGGING ONLY)
]);

authors: bshaffer orvice


text:
Add jwt access credentials

Add ServiceAccountJwtAccessCredentials class
Change updateMetadata callback function signature to accept authUri parameter
if no scope is set in ServiceAccountCredentials, use ServiceAccountJwtAccessCredentials instead
to calculate the token for the ServiceAccountJwtAccessCredentials class, use the passed in authUri to encode the JWT. no outbound call needs to be made
add some unit tests

Fixes issue #43

Please review, thanks!

Yes, this looks already done in this case.

authors: anthmgoogle stanley-cheung

repo: google/google-auth-library-php


text:
Use fence timeout of 60s with Amber.  Also adapted construction of c…

Instruct Amber to use a generous fence timeout for image and compute jobs.

Looks good. Check the commit message before merging: should be 60s.

authors: afd paulthomson

repo: google/graphicsfuzz


text:
SQL: prototypes for dialects, frontend and lowering

This PR adds the following:

a dialect that mirrors the ibis datastructures
a dialect for relational algebra
a frontend for ibis to ibis dialect conversion
a lowering for a simple query from the ibis dialect to the relational dialect

The only really working query currently is countries['continent'] == 'AS'. This is one of the examples of the ibis user guide.

Thanks for the configs, I used them to format properly. As for your questions:

I have a driver, but it relies on a sqlite database that ibis distributes with their tutorial. I am uncertain how licensing works with respect to that since the database is not actually mine, so I decided to not upload it currently. I think we should spin this into a discussion on which backend we actually want to support and then provide running testcases for that.
I mainly decided to split different dialects and different passes in the current pipeline. I will add some comments to each file what it does exactly.

I think it makes sense to keep this as a PR until we have a running testcase in.

Cool, thanks for the explanation!
For a long-term solution for input data, we might want to look how the pandas backend does things. From the documentation:
import ibis
ibis.pandas.connect({"t": pd.DataFrame({"a": [1, 2, 3]})})

That should allow to produce test data easily. Also, pandas data frames can be wrapped into structs of arrays without copies, i.e., by using the original allocations of the different columns, so we could essentially process pandas data frames with our code directly. (That's what CVM does.)
About the SQLite: is it possible to split the driver into code that you wrote, which you can commit, and external code, which one has to download (and patch)? How about other dependencies such as xDSL? A requirements.txt shouldn't be a problem with licenses; the same is probably true for git submodules. The objective of all of that is to enable us to run your code...

I included a testcase that uses Pandas instead of Sqlite. Additionally, I added comments to the files explaining what they contain/do. I will now setup the requirements and take a look at CI integration.

I added filecheck tests and a file that mirrors MlirOpt basically. xDSL has nice support for this since the last version.

I went over the README. Installing and running went exactly like described. Nice!
I think that this is good enough for a first iteration. Ready to merge from my side.

LGTM (looks good to me), but I think @nicolasvasilache should at least check the CI integration.

Looks still good to me! A final stamp by @nicolasvasilache would be great, in particular for the CI targets.

I see it does a lot of stuff at once with XDSL that I am still not familiar with.
In particular, this single PR introduces 2 dialects with 2 classes of tests, a frontend and a conversion.
Can we split all this into smaller CLs that do 1 thing at a time ?
I think this would be a few simple git/github commands to stage the PRs and a little more documentation.
This way it will be easier to review without getting lost between things that are really simple and things that require more attention

repo: google/iree-llvm-sandbox


text:
Fixing leak on particular VM ABI patterns + unused registers

Fixes #2455 and fixes #2252.

👍 👍 👍

authors: antiagainst benvanik

repo: google/iree


text:
Closes #1

Updated the validations.py python script.
Fixed the behavior of validate_user function in validations.py
Fixes #<issue_number_goes_here>

It's a good idea to open an issue first for discussion.

[ ] Tests pass
[ ] Appropriate changes to README are included in PR

hmm first try

repo: google/it-cert-automation-practice


text:
Fix non alphabetic start character check condition

Closes: #1
Updated validations.py python script.
Fixed the behavior of validate_user function in validations.py.
Fixes #<issue_number_goes_here>

It's a good idea to open an issue first for discussion.

[x] Tests pass
[x] Appropriate changes to README are included in PR

@googlebot I signed it!


text:
Updated validations.py python script.

Fixed the behavior of validate_user function in validations.py.
Closes:#1
Fixes #<issue_number_goes_here>

It's a good idea to open an issue first for discussion.

[ ] Tests pass
[ ] Appropriate changes to README are included in PR

fixed validation.py


text:
Update jarjar with asm-7.0 for Java 11

This commit includes a script and patch that will do the following:

Clone github.com/google/jarjar
Download asm-7.0.jar using curl
Download asm-commons-7.0.jar using curl
Delete the older asm jars (their presence would break ant build)
Patch jarjar code specifying new asm jars
Run ant build script

Requirements: git, curl, Java 11, ant
Directions:

Place script and patch in same directory
Invoke script
Retrieve newly generated jarjar/dist/jarjar-11.jar
Modify java_deps/jars.mk when ready to use the new jar

The email I used for my commit did not match the email of my CLA. I will try again using the correct email.

Don't bother with a pull request, as Antonio separately updated this earlier this week. I'll do a push from our internal repository so you have his change.

Thanks for the offer, but there's no point in your pushing something specially for me as I would not be able to integrate it right away.
I've long felt that I should contribute something to the J2ObjC project, and I thought that I finally had a timely fix for you. I'm now able to translate OpenJDK 10 with my version of J2ObjC, but it's not obvious how I can contribute to J2ObjC given the differences in our codebases. The jarjar fix, with fewer dependencies, seemed like a good opportunity. I could have done it sooner, but until recently I didn't think you had interest yet in Java 11.
Thanks again for the J2ObjC project, and please let me know if there's any way I can help.
Alan

It's awesome that you want to contribute, and I didn't mean to dampen your enthusiasm. Antonio has been focused on updating to Java 11 since it's a LTS release. We won't support new API right away, though, as the jre_emul library is a fork of Android's libcore library.

authors: alanpincus tomball


text:
Building from source failed test

Hi,
I'm trying to build jax 0.2.19 using EasyBuild. During the test phase, I have two failed tests:
jax/test_util.py:146: AssertionError
========================================================================================================== short test summary info ==========================================================================================================
FAILED tests/lax_numpy_einsum_test.py::EinsumTest::test_einsum_kpmurphy_example - AssertionError:
FAILED tests/lax_test.py::LaxTest::testOpAgainstNumpyDigamma_float32[2,3,4] - AssertionError:
========================================================================================= 2 failed, 13216 passed, 684 skipped in 3672.05s (1:01:12) =========================================================================================

https://gist.github.com/ysagon/afc9ce91060c8fd1872452e86d74a0a0
https://gist.github.com/ysagon/3b2d3d445d74b6a04aa8b0654e22e435
Any clue?

I think both of these indicate that the test tolerances are a bit too tight and changes in vectorization, etc. might be perturbing the output. Do you want to send a PR relaxing the test tolerances for those two tests?

Although I note that v0.2.19 is old: v0.2.25 is current for jax.

Hi, sorry for not following. In fact, I'm trying to build AlphaFold and this version of Jax is a dependency. I don't know if I can upgrade it. I may give a try.
About increasing the tolerance: can you please let me know which file should I modify? I must admit I have no clue at all how jax is working.

You could try bumping up the atol and rtol arguments here and adding e.g. float32: 1e-3 here.

Closing because we can't reproduce. If you can, please send a PR increasing the tolerances!

authors: apaszke hawkinsp ysagon

repo: google/jax


text:
Add pshuffle to docs

This would likely explain why no one uses it.

Thanks!

authors: Thenerdstation jakevdp


text:
add random.loggamma and improve dirichlet & beta implementation

Fixes #9896
This roughly follows the strategy of TFP, which computes the underlying gamma distribution in normal space and the boost offset in log space (see https://github.com/tensorflow/probability/blob/dc5b6b094cfc1f18f949e120c3491acb2e2af6eb/tensorflow_probability/python/distributions/gamma.py#L453-L459).

I did a bit of cleanup and improved the grad implementation to avoid infinities. PTAL!


text:
Use specific 'gcr.io/distroless/java' image digest.

To ensure reproducibility at the plugin version level, each plugin version should be tied to a specific release of the default gcr.io/distroless/java image.
For example, the current latest digest is @sha256:6af3b801e2beef75307d1eb683e2da792357cacb675a60c10ede16481d2cea741.

Hmm, is that what Bazel rule does?  I'm thinking that most of the time people want the latest updates.  It might make sense to add a digest field to the config and make it required if reproducible builds is enabled..
The way I can imagine this working for people is that their master or dev branch is also at head in terms of the latest up-to-date distroless image, while their release branches are set to reproducible with the digest explicitly specified in the config.

Yea, the Bazel rules_docker defines specific digests to use for each image. The image doesn't seem to actually change much, since this digest that is being used is from back in January and there has been 6 new gcr.io/distroless/java images since then.
The digest field is currently part of the from field. It might be confusing if they specified a from image with a specific tag and then a separate digest field replaces that tag with a digest. It does make sense to have release branches use reproducible with a specific digest that is independent of the plugin version though.

authors: coollog patflynn

repo: google/jib


text:
Admin server for adding / deleting domains

This PR creates a basic Key Transparency administration API.
This is part of supporting multi-tenancy #534

Codecov Report

Merging #845 into master will decrease coverage by 0.3%.
The diff coverage is 50%.

@@            Coverage Diff             @@
##           master     #845      +/-   ##
==========================================
- Coverage   46.94%   46.64%   -0.31%
==========================================
  Files          35       35
  Lines        2833     2817      -16
==========================================
- Hits         1330     1314      -16
  Misses       1296     1296
  Partials      207      207

Impacted Files
Coverage Δ

core/crypto/vrf/p256/p256.go
80.54% <ø> (ø)
:arrow_up:

integration/testutil.go
61.53% <50%> (-4.63%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e0bc4c...ecf68ff. Read the comment docs.

Codecov Report

Merging #845 into master will decrease coverage by 0.42%.
The diff coverage is 44.35%.

@@            Coverage Diff             @@
##           master     #845      +/-   ##
==========================================
- Coverage   46.94%   46.52%   -0.43%
==========================================
  Files          35       36       +1
  Lines        2833     2917      +84
==========================================
+ Hits         1330     1357      +27
- Misses       1296     1343      +47
- Partials      207      217      +10

Impacted Files
Coverage Δ

core/crypto/vrf/p256/p256.go
80.54% <ø> (ø)
:arrow_up:

core/adminserver/admin_server.go
43% <43%> (ø)

integration/testutil.go
61.53% <50%> (-4.63%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e0bc4c...9ff3a64. Read the comment docs.

authors: codecov-io gdbelvin

repo: google/keytransparency


text:
Typo in comments

Hi,
In the leveldb source code, there are many places the word if is misspelled as iff.

That is likely shorthand for if and only if.

aha! That explains. @ashoemaker Thank you for the note.

repo: google/leveldb


text:
Line length of text

The design spec recommends a line length around 60 characters. (See http://www.google.be/design/spec/style/typography.html#typography-other-typographic-guidelines)
However, this is not followed consistently by Material Design Lite templates and/or website. Some examples:

The Text-heavt webpage template seems to have around 95-100 characters.
The FAQ has around 100-120.
The Stand-alone article template goes up to around 150.
The Blog template seems to follow it.

So the question is: should I follow the recommendation or not? If no, when should I and should I not?

Good question. All of our templates and websites have been developed with the MD team. Maybe @santokii can give a quick answer on how to use the 60-character recommendation.

50-60 characters is best practice (for web) which I would recommend for optimal legibility (http://baymard.com/blog/line-length-readability). This is something we should address in MDL as a P2. It was in the original redlines, but something I should have quality checked before launch.

authors: niknetniko santokii surma

repo: google/material-design-lite


text:
I do not understand the purpose of add stylesheet with no valid link

I do not understand the purpose of add stylesheet with no valid link
<link rel="stylesheet" href="$$hosted_libs_prefix$$/$$version$$/material.teal-red.min.css">

the gulp and bower things are becoming very boring

Where are you seeing that reference?

Just confirmed our getting started guide does show the proper links.
Doesn't seem to be an issue with anything. Closing until we know where this is being seen from.

authors: Garbee onigetoc


text:
MediaPipe dose not run on GPU after installing it using "pip install mediapipe"

I looked over #1651 but I could not understand how to add GPU graph and modifications to the python package after installing it using "pip install mediapipe". Any step-by-step instruction?

yeah facing the same issue

MediaPipe GPU support on macOS and Windows are not released yet. To keep the wheel pakcages on linux, macos,and windows in sync, MediaPipe only have CPU graphs in the wheel packages. You can follow https://github.com/google/mediapipe/issues/1651#issuecomment-790176010 to run the GPU graphs. Sorry for the inconvenience.

authors: Abhinavkriti abzargar jiuqiant

repo: google/mediapipe


text:
Adding support to fine-tune models?

Are there any plans to allow fine-tuning the models for specific needs? Or will it be possible to share the training code?

@ahmed-shariff There is no plan to share the training code or the dataset (due to privacy issues) for any of the MediaPipe example TF models

@mgyong are there plans for a (probably paid) fine-tune service, so that I can upload somewhere my training data and get an optimized model back? I'm working with the 3D Human Pose Estimator and some moves I try to detect seem to be out of scope...

authors: ahmed-shariff cagcoach mgyong


text:
Is there a downloader?

Is your feature request related to a problem? Please describe.
I have a need to export output table/dataframe to a spreadsheet for a user to download
Describe the solution you'd like
Just like the "Uploader" component, when user clicks, a file explorer pops up to choose a folder/file to save.
Describe alternatives you've considered
Not sure if the "Link" component would work as a downloader?
Additional context
No.

Right now there is no clean way to do this. But it is not impossible to do I think.
Easiest option may be to use a data url with the me.html component (See https://github.com/google/mesop/discussions/453)
Drawback here is that it's not going to be great if the file is huge. Also you have less control over styling with me.html, though you can try embedding your own stylesheet.

There is also another way, which is to mount a Fast API server with Mesop. You can then use expose a download link via Fast API. This will require saving the data you want the user to download on the file system / database / cloud storage. Then having your Fast API endpoint retrieve that file from the file system / database / cloud storage endpoint.
This way is better for larger data files. And also you have more control over the look.
It's not super hard, but also not trivial.

Thank you so much for the reply! I'll try the easy option first, my output file is small.

👍🏾

Thanks, download file would be nice feature, for now I am just using download link option.

authors: loretoparisi ml2s raphsaeed richard-to

repo: google/mesop


text:
Mypy-protobuf files missing on windows release

What version of OR-Tools and what language are you using?
Version: master
Language: Python
Which solver are you using (e.g. CP-SAT, Routing Solver, GLOP, BOP, Gurobi)
CP-SAT
What operating system (Linux, Windows, ...) and version?
Windows
What did you do?
Expected my IDE to autocomplete solver.parameters.
What did you expect to see
Autocompletion
What did you see instead?
The package did not contain *.pyi files
Anything else we should know about
I built from source and they were generated, so I believe you just have to add:
set PATH=%PATH%;C:\python3%%v-64\Scripts

in the build_delivery_win.cmd script, but I have not tested it.
https://github.com/google/or-tools/blob/b37d9c786b69128f3505f15beca09e89bf078a89/tools/release/build_delivery_win.cmd#L313-L314

It seems protoc-mymy-gen.exe is installed in:
%userprofile%\appdata\roaming\python\python3%%v\Scripts

Yep, autocompletion works like a charm in ortools-9.1.9490, thanks!

repo: google/or-tools


text:
Add CoffFile::LoadRuntimeFunctionsAsSymbols

This simply uses CoffFileImpl::GetUnwindRanges and turns them into SymbolInfos.
It also indirectly finally adds unit tests for GetUnwindRanges.
I decided to assign the arbitrary name [function@<address>] right away here. I guess this is mostly for simplicity as it saves other code from having to take care of the empty-name case in multiple places.
Bug: http://b/245680119
Test:

Unit tests.
As part of the larger symbol loading fallback prototype.

What do you think of LoadSymbolsFromExceptionTable instead? I'm leaning towards renaming.

What do you think of LoadSymbolsFromExceptionTable instead? I'm leaning towards renaming.

Sounds better, actually.

What do you think of LoadSymbolsFromExceptionTable instead? I'm leaning towards renaming.

Sounds better, actually.

The downside is that these are not really symbols, we make them symbols, and the Load...AsSymbols reflects that. On the other hand I would prefer saying "Exception Table" than "RUNTIME_FUNCTIONs" as it's more high level. But if I have to call it "LoadExceptionTableEntriesAsSymbols" then might as well say "RuntimeFunctions".

The downside is that these are not really symbols, we make them symbols, and the Load...AsSymbols reflects that. On the other hand I would prefer saying "Exception Table" than "RUNTIME_FUNCTIONs" as it's more high level. But if I have to call it "LoadExceptionTableEntriesAsSymbols" then might as well say "RuntimeFunctions".

I see the points. Honestly, I like LoadExceptionTableEntriesAsSymbols most. But all are fine, I guess.

The downside is that these are not really symbols, we make them symbols, and the Load...AsSymbols reflects that. On the other hand I would prefer saying "Exception Table" than "RUNTIME_FUNCTIONs" as it's more high level. But if I have to call it "LoadExceptionTableEntriesAsSymbols" then might as well say "RuntimeFunctions".

I see the points. Honestly, I like LoadExceptionTableEntriesAsSymbols most. But all are fine, I guess.

I think I'm convinced, I'll rename to this.

The downside is that these are not really symbols, we make them symbols, and the Load...AsSymbols reflects that. On the other hand I would prefer saying "Exception Table" than "RUNTIME_FUNCTIONs" as it's more high level. But if I have to call it "LoadExceptionTableEntriesAsSymbols" then might as well say "RuntimeFunctions".

I see the points. Honestly, I like LoadExceptionTableEntriesAsSymbols most. But all are fine, I guess.

I think I'm convinced, I'll rename to this.

Renamed.

authors: dpallotti florian-kuebler

repo: google/orbit


text:
fix: trim leading and trailing newlines off SARIF output

I don't know a lot about SARIF so maybe these are required but that would be surprising to me whereas trimming these off make it a bit consistent for editors and such.
Obviously if these are required then lets close this PR

Codecov Report

Merging #606 (60fe2d5) into main (c00f630) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #606   +/-   ##
=======================================
  Coverage   80.61%   80.61%
=======================================
  Files          78       78
  Lines        5334     5334
=======================================
  Hits         4300     4300
  Misses        866      866
  Partials      168      168

Files
Coverage Δ

internal/output/sarif.go
90.42% <100.00%> (ø)

😞

Oh, did you used to just press the delete branch button?

Yeah that's what I've always been doing on this repo and e.g. what I did after posting that screenshot - I guess you were right it just doesn't work across forks 🤷

authors: G-Rath another-rex codecov-commenter

repo: google/osv-scanner


text:
[Heapprofd client] Reconnect when sockets are disconnected

When using heapprofd, I found that the sockets would occasionally get disconnected and would not reconnect, resulting in data loss

@fmayer

@fmayer

Hi! Thanks for getting in touch.
This is not generally an error: this just means that the service that is responsible for the profiling disconnected. This can mean the service either disconnected voluntarily, because the profile ended; or alternatively, that it crashed. The log message here is confusing, which we have addressed in newer releases; we now distinguish between those two cases in the log.
Could you share:

Your build fingerprint (run adb shell getprop ro.build.fingerprint)
How you start the profile
Some more context around the log line you showed

Hi! Thanks for getting in touch.
This is not generally an error: this just means that the service that is responsible for the profiling disconnected. This can mean the service either disconnected voluntarily, because the profile ended; or alternatively, that it crashed. The log message here is confusing, which we have addressed in newer releases; we now distinguish between those two cases in the log.
Could you share:

Your build fingerprint (run adb shell getprop ro.build.fingerprint)
How you start the profile
Some more context around the log line you showed

authors: dodola fmayer primiano

repo: google/perfetto


text:
Fix pylint

Ignore linting python notebook cache and tests (I am ok with enabling linting tests later).
Fix quotes. Other linting error fixes in subsequent PRs.

Closing as this is already a part of another PR (https://github.com/google/scaaml/pull/66) I tried to stack.

repo: google/scaaml


text:
Status of UTCTiming spec?

I was asked the following question regarding UTCTiming:
Do you know why the players e.g. Shaka implement this when the spec is not finalized?
I'm not familiar with the history of UTCTiming in the spec, or what it's current status is. Some people are concerned that UTCTiming is in draft form and not finalized, and thus we should not implement it.
I understand Shaka team can't advise on my organization's specific situation, but I'm hoping to offer a coherent answer to the question above.

I didn't know this, but apparently UTCTiming isn't in the DASH spec itself.  So they may be correct about it being in the draft spec.  But, it has been in the IOP guidelines (which have several finalized versions) for a while now.  Also, we focus on implementing the IOP guidelines, not really the DASH spec itself.  UTCTiming is in the finalized versions of the IOP.  I would also think that it is a stable feature since it has been pushed by DASH IF.
As for why it should implemented, because there is no other way to synchronize the client and server.  The DASH spec just says that it must be synchronized already, but doesn't specify how.  The IOP adds the UTCTiming element to allow clients and servers to synchronize the clocks.  This is really important for live streams since segment availability is based on the current wall-clock time.

Also, we support syncing with the Date header of an arbitrary URL via configuration, so you don't really need to use UTCTiming in the manifest if that particular method works.  (That is also one of several UTCTiming schemes currently specified.)  Any uncacheable endpoint you control would work, so long as the server returns a Date header corresponding to "now".

Thanks for the information!

UTCTiming is specified in ISO/IEC 23009-1:2014/Amd 1:2015.

authors: TheModMaker chrisfillmore joeyparrish sandersaares

repo: google/shaka-player


text:
Update EME usage to match latest spec & Chrome implementation

The EME spec has changed in several ways, as has Chrome's implementation.  As Chrome is the only implementation of EME tracking the spec, we will update our usage of EME and our polyfills to match Chrome 46.

No changes necessary right now.

At some point we will need to change how we handle the output-restricted key status. If the key system indicates the output-restricted key status then we should not raise an error or restrict the key's associated track(s), as the key system may still be able to use that key for different tracks. See http://www.w3.org/TR/encrypted-media/#idl-def-MediaKeyStatus.output-restricted

Updated key status forEach argument order in b1141d5

authors: joeyparrish tdrews


text:
Make spacer growable in order to align control elements

Test case

Open the test page
Load the Angel asset
Enter full screen mode

Expected
The current time element is left-aligned and other controls are right-aligned.
Actual
The current time element isn't left-aligned but has an indentation. For example:

I signed it!

Looks good! Let me run the tests.

Merged! Thanks for the contribution!

authors: ismena tomasz-oponowicz


text:
Added lowercase split value and passing tests#42

This pull request takes care of the lower case support issue and enables the users to follow the normal convention as mentioned in #42
This is mainly a cosmetic change and the dataset labels such as 'TRAIN' ,'TEST', 'VALIDATE' are not compatible as lower cases versions. It does not affect the broader scope of the project. however it may require documentation changes.
Fixes  #42
Cosmetic change. as explained in summary above.
Please delete options that are not relevant.

[ Y ] New feature (non-breaking change which adds functionality)
[ Y ] This change requires a documentation update

Checklist

[Y] My code adheres to the Google Python Style Guide
[Y] I ran make test and all tests pass
[Y] I ran the tool and verified the change works
[Y] I have adequately commented my code, particularly in hard-to-understand areas
[Y] My changes generate no new warnings
[Y] I have corrected any misspellings in my code
[Y] (For feature) I made sure that I'm merging to the dev branch

@cfezequiel kindly review the new commits

@cfezequiel Kindly review the changes

@cfezequiel Did you review the changes ?

@cfezequiel alright,
I will make the changes and hopefully we can publish these last changes as well.

@cfezequiel can you kindly review again and approve ?

@Samad999777 looks like there is a conflict with one of the files. Could you please check?

@cfezequiel its actually fine, My file is updated with lower case values, it should be fine to merge it

@cfezequiel I've resolved the conflict. Can you review ?

@Samad999777 got it. There seems to be a cla issue but it looks like something I need to resolve on my end.

@cfezequiel yes, i think you need to re-submit your CLA.

@cfezequiel can you kindly take care of the CLA so these changes can be pushed?

@Samad999777 I may need to update the commit in your PR and push the change to your branch to address the CLA issue (basically remove the unregistered email address there). Are you ok with that?

@cfezequiel As long as i get to be the contributer of this pull request in the project. I am very much okay with it.

@Samad999777 are you able to revert this commit: "Merge branch 'dev' into main" and do a rebase against the dev branch instead? That way, your commits come out on top in the commit history.

@cfezequiel I have reverted the commit: "Merge branch 'dev' into main". However when i attempted to rebase it says that it is already upto date [see image below]. Am i doing this right ?

@Samad999777 Thanks for the change. Have you tried rebasing the main branch in your fork with this repo's dev branch? PRs should be made off of the dev branch unless it's a hotfix.

repo: google/tensorflow-recorder


text:
Solving #155 Hook to run tests on current code before pushing

For #155
When configured to be used, runs linter tests before pushing and checks if the tests passed (1 line in output only in this case). If tests fail, option to push anyway.
Karma test not set up yet.

@seanlip PTAL

@seanlip PTAL
Both linter and karma tests run before the push command.

@seanlip I've made the changes based on comments. The last commit replaces the old karma config with the new one. The only noticeable difference between them is "singleRun: true", which closes the browser and exits the script once it completes the tests. If this is not desirable, I will revert that commit and use the 2 separate config files.

(Just fix one minor thing please, but after that feel free to merge without further review.)

@seanlip please merge (I do not have the permissions). Requested changes made.

authors: seanlip shaman-rajan

repo: google/tie


text:
Add option flag to disable type assertions for memberVariables

When using typeAssertions:true, memberVariables:true, member variables are wrapped into getters/setters that do type checks. However, there is no option to disable this wrapping while keeping type assertions and member fields in classes.
We would like to disable this behavior for

traceur uses field names based on numbers, which can lead to collisions when creating a subclass in a separate compiler run.
this rename of fields makes debugging via the repl harder (e.g. via DevTools console)
this rename can break JSON conversion of instances

Demo
Applies to traceur 0.82

Duplicate of https://github.com/google/traceur-compiler/issues/1625. Closing.

repo: google/traceur-compiler


text:
feat: UUIDs slice type with Strings() convenience method

I often work with slices of UUIDs and want to include them in log messages. It is therefore convenient to be able to easily transform a slice of UUIDs into a slice of strings. In the interest of avoiding repeating code across many projects to accomplish this, I suggest defining a slice type in this project.
This PR adds such a type and defines a convenience method Strings() on it.
This type additionally gives maintainers the opportunity to add further convenience methods; for instance one could implement the sort interface on this new type.

Would love to see also the Scanner and Value interface for the UUID slice in this pkg - i could create a PR for this if there is some interest

authors: dzbee loeffel-io

repo: google/uuid


text:
The predicted front normals are zeros using the pretrained model

Thanks for your wonderful work. I'm trying to use your method and pretrained model to generate relighting images. The albedo image seems correct, but I find the predicted values of the front normals['full']  are all 0 with different input latent codes. Did I use the model in a wrong way, hope for your respones, Thank you very much.

change the device ='cpu' to device = 'gpu', then will return the nomals

Hi. I tried the notebook but get such error info:
WARNING:tensorflow:Value in checkpoint could not be found in the restored object: (root).optimizers.depth_discriminator's state 'v' for (root).models.depth_discriminator.network.3.conv2d_0.weight
WARNING:tensorflow:Value in checkpoint could not be found in the restored object: (root).optimizers.depth_discriminator's state 'v' for (root).models.depth_discriminator.network.3.conv2d_1_down.weight
I guess this is because the wrong version of the dependent package.So could you show me your package info? Thank you.

authors: endlessll ohjarwa

repo: google/volux-gan


text:
Allow changing number values with up/down keys

Summary
Allow arrow up/down to increment/decrement a value when focused on a numeric input field.
Relevant Technical Choices
For float values, its value will first be rounded up/down to an integer and afterwards incremented / decrements. @samitron7 @pbakaus does that make sense?
Fixes #1027

For float values, its value will first be rounded up/down to an integer and afterwards incremented / decrements. @samitron7 @pbakaus does that make sense?

I would personally apply the Chrome DevTools philosophy here:

Up/down on a float changes just the integer-part, so you go from 1.5 to 2.5 and so on
Alt+up/down on a float increments the first fractional part, so you go from 1.5 to 1.6 and so on

@pbakaus I like that approach. Will change to it!

authors: pbakaus winterDroid

repo: google/web-stories-wp


text:
Replace amp-story-bookend with amp-story-social-share

Context

Summary
Change amp-story-bookend with amp-story-social-share.
Relevant Technical Choices

To-do

User-facing changes

Testing Instructions

QA

[ ] This is a non-user-facing change and requires no QA

This PR can be tested by following these steps:
Requires you to opting in to pre-release channels using the experiments page.

Open a story in the editor, click preview.
Navigate to the end story.
See share sheet.

UAT

[ ] UAT should use the same steps as above.

This PR can be tested by following these steps:

Reviews
Does this PR have a security-related impact?

Does this PR change what data or activity we track or use?

Does this PR have a legal-related impact?

Checklist

[x] This PR addresses an existing issue and I have linked this PR to it in ZenHub
[x] I have tested this code to the best of my abilities
[x] I have verified accessibility to the best of my abilities (docs)
[x] I have verified i18n and l10n (translation, right-to-left layout) to the best of my abilities
[x] This PR contains automated tests (unit, integration, and/or e2e) to verify the code works as intended (docs)
[x] I have added documentation where necessary
[x] I have added a matching Type: XYZ label to the PR

Fixes #6852

The test_print_social_share test now needs updating it seems.
Otherwise looks good!

The test_print_social_share test now needs updating it seems.
That is what I get for reverting something at the end of the day before you leave.

Reverted change to test now as well

@swissspidy I am seeing on browsers with opting in beta channel now.

It should be safe to merge.

authors: spacedmonkey swissspidy


text:
Update copyright messages to xi-editor

Following guidance from https://opensource.google.com/docs/releasing/authors/
this patch changes the copyright message to "The xi-editor Authors" and
creates an AUTHORS file for contributors to record their name.
Also minor update to the contribution guidelines to remind people to add their
name to AUTHORS, and tweak the rules for approving and merging patches.

See google/xi-editor#778 for the parallel patch in the main xi-editor repo.

repo: google/xi-mac


text:
FromZeros boxed slice method supports slice DSTs

Makes progress on #29

Codecov Report
Attention: Patch coverage is 86.27451% with 7 lines in your changes missing coverage. Please review.

Project coverage is 87.76%. Comparing base (02dc876) to head (d16421a).
Report is 2 commits behind head on main.

Files with missing lines
Patch %
Lines

src/lib.rs
86.00%
7 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1478      +/-   ##
==========================================
- Coverage   87.83%   87.76%   -0.08%
==========================================
  Files          15       15
  Lines        5623     5638      +15
==========================================
+ Hits         4939     4948       +9
- Misses        684      690       +6

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

authors: codecov-commenter joshlf

repo: google/zerocopy