text:
Context and functional components

I wanted to rewrite everything without the Redux dependency (using Context instead), with functional components that use hooks, and with async methods. This mostly works, in my limited testing I haven't ran into any blatantly obvious issues.
Though this really deviates from the project quite a bit especially with a heavy amount of linting to keep it as close to vanilla Airbnb style as possible. If this strays too far from the original project I'd be happy to maintain it in my own fork or adapt the code if appropriate.

Hi @ethanx94, thank you for your PR, out team will review and test your PR

Can you do this for RNVideoChat also?

@stephanoparaskeva By request I've added RNVideoChat to get it up to speed with async functions, etc. This project had no real Redux dependency but I changed all the class based components to be functional at least. This one however, is even less tested as I do not have two phones on me currently to do so. Please run with the provided .vscode debug scripts (attach to packager after you have it running on a device) and see if you can track down any bugs.

@stephanoparaskeva By request I've added RNVideoChat to get it up to speed with async functions, etc. This project had no real Redux dependency but I changed all the class based components to be functional at least. This one however, is even less tested as I do not have two phones on me currently to do so. Please run with the provided .vscode debug scripts (attach to packager after you have it running on a device) and see if you can track down any bugs.

Awesome stuff. Will test asap and fingers crossed

@stephanoparaskeva By request I've added RNVideoChat to get it up to speed with async functions, etc. This project had no real Redux dependency but I changed all the class based components to be functional at least. This one however, is even less tested as I do not have two phones on me currently to do so. Please run with the provided .vscode debug scripts (attach to packager after you have it running on a device) and see if you can track down any bugs.

After testing with 2 mobiles the video calling seems to have only a few issues.

When you start a call, the speaker doesn't seem to be on. So you can only hear each device if you put the phone to your ear.
The video stream of the remote device does not show on screen. So you basically see a fullscreen video of yourself on each phone as if only the local video is shown on each.

I can try and look further to fix these and will let you know but as of yesterday I haven't been able to locate what is causing this problem

Thanks for the updateRemoteStream fix. I noticed hangup doesn't bring you back. Since this branch was a few months ago I am getting further away from master. I need to sync back up and see if there's anything new I missed. I pushed up another update which might fix the cameras not working. I wasn't referencing the ref properly for "isAvailableToSwitch" which I think controls the swap camera button.
I do call the setSpeakerphoneOn in a useEffect any time the remoteStreams change...the value should be true. But you're right I'm not hearing anything on speaker at any point.

Thanks for the updateRemoteStream fix. I noticed hangup doesn't bring you back. Since this branch was a few months ago I am getting further away from master. I need to sync back up and see if there's anything new I missed. I pushed up another update which might fix the cameras not working. I wasn't referencing the ref properly for "isAvailableToSwitch" which I think controls the swap camera button.
I do call the setSpeakerphoneOn in a useEffect any time the remoteStreams change...the value should be true. But you're right I'm not hearing anything on speaker at any point.

Have been testing and trying to debug but have had no luck. I can't seem to figure out how to fix these and offer consistent calling. Right now the problems I've found:

Speaker doesn't work on IOS
Android camera switch freezes
Calling and hanging up sometimes doesn't return to home screen
[CRITICAL] Calling another phone and then hanging up. If you call again, it says 'User B is Busy' and call sound occurs on other phone but no prompt occurs. Have to refresh app to fix both phones.

Will have to work through these but I can't seem to get this to work consistently. Perhaps we've missed something. What's your thoughts?

Hey, sorry been a bit pressed with work this week. As far as the critical issue, I would check closely into the listeners. Its almost as though the state isn't resetting when the call ends. I tried to use a ref to keep the previous state and I observe the stateful value in my useEffect dependency array. The problem may very well lie there.
With that said my conversion to hooks may not be the most performant, and that should come as a disclaimer. There may be times when it is appropriate to do useCallback/useMemo but I'm not familiar enough with the codebase and hooks in general to make those optimizations just yet. I didn't personably run into this, but I know it might be a problem in the RNChat example with large dialogs.
Here is possibly the problem area in RNVideoChat.

Hey, sorry been a bit pressed with work this week. As far as the critical issue, I would check closely into the listeners. Its almost as though the state isn't resetting when the call ends. I tried to use a ref to keep the previous state and I observe the stateful value in my useEffect dependency array. The problem may very well lie there.
With that said my conversion to hooks may not be the most performant, and that should come as a disclaimer. There may be times when it is appropriate to do useCallback/useMemo but I'm not familiar enough with the codebase and hooks in general to make those optimizations just yet. I didn't personably run into this, but I know it might be a problem in the RNChat example with large dialogs.
Here is possibly the problem area in RNVideoChat.

It's awesome work. I've managed to fix these issues:

Speaker phone doesn't work.
Call doesn't return to home.
Sometimes is busy is on.

The problem is that I can't make a PR into your work because my code is all TypeScript and also I completely removed the call_service and moved it all into video_screen and I use (react-native-callkeep)[https://github.com/react-native-webrtc/react-native-callkeep] instead of awesome alerts for the call screen And I made calling only peer-to-peer no conferences.
But to fix speaker phone you have to invoke incallmanager like this:
  const onRemoteStreamListener = async (
    _session: Session,
    userId: number,
    stream: Stream
  ) => {
    InCallManager.start({ media: 'video' });
    setRemoteStreams([...remoteStreams, { userId, stream }]);
  };

The whole file is here:
https://pastebin.com/BR2NCzxY
Problems I have now:

Sometimes if I leave apps running for 20+ minutes they no longer respond to calls from eachother.
Android phone doesn't work and is buggy so must fix this
Switch camera no longer works (will be an easy fix)

Is it possible for you to help advise me on this one:
Sometimes if I leave apps running for 20+ minutes they no longer respond to calls from eachother. as I need to make calling consistent and I have no idea why this might not be working.

As far as the 20 minute idle time, there was a similar issue a while back. Maybe this is related? I would try some workarounds in this thread.
https://github.com/ConnectyCube/connectycube-reactnative-samples/issues/64

As far as the 20 minute idle time, there was a similar issue a while back. Maybe this is related? I would try some workarounds in this thread.
#64

After upgrading to 3.1.0 I think it may have fixed this for me.
I've integrated RN-CallKeep and here's the code. I've got lot's of issues right now and I'm working through them. It's really quite tricky:
import React, { useRef, useState, useEffect } from 'react';
import {
  SafeAreaView,
  StatusBar,
  Platform,
  View,
  TouchableOpacity,
  StyleSheet,
} from 'react-native';
import ConnectyCube from 'react-native-connectycube';
import InCallManager from 'react-native-incall-manager';
import RNCallKeep from 'react-native-callkeep';
import MaterialIcon from 'react-native-vector-icons/MaterialIcons';
import { v4 as uuid } from 'uuid';
import VideoScreen from './video_screen';
import UsersSelect from './users_select';
import {
  Session,
  Stream,
  Listener,
  users,
  Extension,
  Track,
  MEDIA_OPTIONS,
  SETUP_OPTIONS,
} from '../config';
import useStateCallback from '../../components/common/hooks/state_callback';

const isIOS = Platform.OS === 'ios';

const CallControl = ({ route }: { route: any }) => {
  const initSession = {
    ID: '',
    initiatorID: 0,
    currentUserID: 0,
    opponentsIDs: [],
    getUserMedia: () => {},
    accept: () => {},
    call: () => {},
    stop: () => {},
    mute: () => {},
    unmute: () => {},
    reject: () => {},
  };
  const initExtension = { busy: false };

  const sess = useRef<Session>(initSession);
  const ext = useRef<Extension>(initExtension);
  const callId = useRef<string>('');
  const currentUser = route?.params?.currentUser || {};

  const [localStream, setLocalStreams] = useState<any>([]);
  const [remoteStreams, setRemoteStreams] = useStateCallback<
    [] | Array<Stream>
  >([]);

  const [selectedUserId, setSelectedUser] = useState<null | number>(null);

  const [isAudioMuted, setIsAudioMuted] = useState(false);
  const [isFrontCamera, setIsFrontCamera] = useState(true);

  const cam = true;

  const reset = async () => {
    const id = oneTimeId();
    RNCallKeep.endCall(id);
    await ConnectyCube.videochat.clearSession(sess.current.ID);
    RNCallKeep.endAllCalls();

    InCallManager.stop();
    setRemoteStreams([]);
    setLocalStreams([]);
    setSelectedUser(null);
    setIsAudioMuted(false);
    setIsFrontCamera(true);
    sess.current = initSession;
    ext.current = initExtension;
    callId.current = '';
  };

  const oneTimeId = () => {
    callId.current = callId.current || uuid();
    return callId.current;
  };

  // Start/Stop onPress call handlers
  const startCall = async () => {
    if (!selectedUserId) {
      return;
    }

    const t = ConnectyCube.videochat.CallType.VIDEO; // AUDIO is also possible
    sess.current = ConnectyCube.videochat.createNewSession([selectedUserId], t);

    const stream = await sess.current?.getUserMedia?.(MEDIA_OPTIONS);
    await sess.current?.call({});

    setLocalStreams([{ userId: 'localStream', stream }]);
    setRemoteStreams([{ userId: selectedUserId, stream: null }]);

    if (isIOS) {
      const id = oneTimeId();
      const name = users.find(u => u.id === selectedUserId)?.name || '';
      RNCallKeep.startCall(id, name, name, 'generic', cam);
    }
  };

  const stopCall = async () => {
    await sess.current?.stop?.({});
    await reset();
  };

  // CallKeep button actions
  const acceptCall = async () => {
    const id = oneTimeId();
    RNCallKeep.setCurrentCallActive(id);

    const stream = await sess.current?.getUserMedia?.(MEDIA_OPTIONS);
    await sess.current?.accept?.({});

    setLocalStreams([{ userId: 'localStream', stream }]);
    setRemoteStreams([{ userId: selectedUserId, stream: null }]);
  };

  const rejectCall = async () => {
    await sess.current?.reject?.(ext.current);
    await reset();
  };

  // ConnectyCall Listeners
  const onCallListener: Listener = async (session, _userId, extension) => {
    ext.current = extension || initExtension;
    sess.current = session || initSession;

    const name =
      users.find(u => u.id === sess?.current?.initiatorID)?.name || '';
    const id = oneTimeId();
    RNCallKeep.displayIncomingCall(id, name, name, 'generic', cam);
  };

  const onAcceptCallListener: Listener = async (session, _, extension) => {
    ext.current = extension || initExtension;
    sess.current = session || initSession;
  };

  const onRemoteStreamListener = async (
    _session: Session,
    userId: number,
    stream: Stream
  ) =>
    setRemoteStreams([...remoteStreams, { userId, stream }], () => {
      InCallManager.start({ media: 'video', auto: false });
      InCallManager.setSpeakerphoneOn(true);
      RNCallKeep.backToForeground();
    });

  const onRejectCallListener = async () => {
    await reset();
  };

  const onStopCallListener = async () => {
    await reset();
  };

  const onUserNotAnswerListener = async () => {
    if (!remoteStreams[0]) {
      await reset();
    }
  };

  // Init
  const initializeConnectyCube = () => {
    ConnectyCube.videochat.onCallListener = onCallListener;
    ConnectyCube.videochat.onAcceptCallListener = onAcceptCallListener;
    ConnectyCube.videochat.onRemoteStreamListener = onRemoteStreamListener;
    ConnectyCube.videochat.onRejectCallListener = onRejectCallListener;
    ConnectyCube.videochat.onStopCallListener = onStopCallListener;
    ConnectyCube.videochat.onUserNotAnswerListener = onUserNotAnswerListener;
  };

  const initializeCallKeep = async () => {
    await RNCallKeep.setup(SETUP_OPTIONS);
    RNCallKeep.setAvailable(true);
    RNCallKeep.addEventListener('answerCall', acceptCall);
    RNCallKeep.addEventListener('endCall', rejectCall);
  };

  const cleanup = () => {
    RNCallKeep.removeEventListener('answerCall');
    RNCallKeep.removeEventListener('endCall');
    stopCall();
  };

  useEffect(() => {
    initializeConnectyCube();
    initializeCallKeep();
    return cleanup;
  }, []);

  // Actions
  const toggleMute = () => {
    const mute = !isAudioMuted;
    setIsAudioMuted(mute);
    mute ? sess.current?.mute?.('audio') : sess.current?.unmute?.('audio');
  };

  const toggleCamera = () => {
    setIsFrontCamera(!isFrontCamera);
    localStream[0]?.stream
      ?.getVideoTracks?.()
      .forEach((track: Track) => track._switchCamera());
  };

  // Buttons
  const renderCallStartStopButton = () => (
    <TouchableOpacity
      style={[
        styles.buttonContainer,
        remoteStreams[0] ? styles.buttonCallEnd : styles.buttonCall,
      ]}
      onPress={remoteStreams[0] ? stopCall : startCall}>
      <MaterialIcon
        name={remoteStreams[0] ? 'call-end' : 'call'}
        size={32}
        color='white'
      />
    </TouchableOpacity>
  );

  const renderMuteButton = () => (
    <TouchableOpacity
      style={[styles.buttonContainer, styles.buttonMute]}
      onPress={toggleMute}>
      <MaterialIcon
        name={isAudioMuted ? 'mic-off' : 'mic'}
        size={32}
        color='white'
      />
    </TouchableOpacity>
  );

  const renderSwitchVideoSourceButton = () => (
    <TouchableOpacity
      style={[styles.buttonContainer, styles.buttonSwitch]}
      onPress={toggleCamera}>
      <MaterialIcon
        name={isFrontCamera ? 'camera-rear' : 'camera-front'}
        size={32}
        color='white'
      />
    </TouchableOpacity>
  );

  return (
    <SafeAreaView style={{ flex: 1, backgroundColor: 'black' }}>
      <StatusBar backgroundColor='black' barStyle='light-content' />
      {remoteStreams[0] ? (
        <View style={styles.inColumn}>
          <VideoScreen
            mirror={false}
            stream={remoteStreams?.[0]?.stream}
            userId={remoteStreams?.[0]?.userId}
          />
          <VideoScreen
            mirror={isFrontCamera}
            stream={localStream?.[0]?.stream}
            userId={localStream?.[0]?.userId}
          />
        </View>
      ) : (
        <UsersSelect
          currentUser={currentUser}
          selectedUserId={selectedUserId}
          setSelectedUser={setSelectedUser}
        />
      )}
      <SafeAreaView style={styles.container}>
        <View style={styles.toolBarItem}>
          {remoteStreams[0] && renderMuteButton()}
        </View>
        {(selectedUserId || remoteStreams[0]) && (
          <View style={styles.toolBarItem}>{renderCallStartStopButton()}</View>
        )}
        <View style={styles.toolBarItem}>
          {remoteStreams[0] && localStream && renderSwitchVideoSourceButton()}
        </View>
      </SafeAreaView>
    </SafeAreaView>
  );
};

const styles = StyleSheet.create({
  container: {
    position: 'absolute',
    bottom: 20,
    left: 0,
    right: 0,
    height: 60,
    flex: 1,
    justifyContent: 'center',
    flexDirection: 'row',
    zIndex: 100,
  },
  toolBarItem: {
    flex: 1,
    justifyContent: 'center',
    alignItems: 'center',
  },
  buttonContainer: {
    height: 50,
    width: 50,
    borderRadius: 25,
    marginHorizontal: 25,
    justifyContent: 'center',
    alignItems: 'center',
  },
  buttonCall: {
    backgroundColor: 'green',
  },
  buttonCallEnd: {
    backgroundColor: 'red',
  },
  buttonMute: {
    backgroundColor: 'blue',
  },
  buttonSwitch: {
    backgroundColor: 'orange',
  },
  inColumn: {
    flex: 1,
    flexDirection: 'column',
  },
});

export default CallControl;```

RNChat is already re-written in functional components and merged into master.
RNVideoChat - will be done with https://github.com/ConnectyCube/connectycube-reactnative-samples
We decide to keep using redux because of its popularity among developers.

both RNChat and RNVideoChat are re-written with functional components,
please refer to master branch for the latest src code

authors: DaveLomber banshiAnton eastcoastcoder ethanx94 stephanoparaskeva


text:
Hidden pair rule for shorter ASTs

Substituted in the grammar.js file the pair rule with the _pair rule and updated the tests.

Sorry, I have overseen that I have to include all the other updated files as well. In the next pull request, those should be included as well.

source: gharchive/pull-request

repo: ConradIrwin/tree-sitter-conl

license: MIT

license_type: permissive

license_source: github-api


text:
Use npmjs registry for erc820 to avoid jbaylina/ERC820#24

Installing erc820 via github causes npm prepack to run on the ERC820 side, which will fail if mocha is not installed globally. This replaces the github address dependency with npmjs/erc820

Hi Shane,
Thanks for your interest and contribution!
As the imported code is critical and can lead to security issues through dep injection, we need to ensure its content. Using the checksum through git is the only way I found.
Happy to discuss and know if you have another solution for that!

Thanks for your welcoming message Julien!
I see what you mean - actually, I was under the impression that package-lock enforced package integrity, but I see that your workflow is yarn based and I don't know if that is also the case there (and furthermore, neither lockfile would affect downstream packages as far as I know)
I'll do a bit of research and submit an issue for discussion if I find some evidence or another approach to your integrity requirement.

authors: julien-marchand shane-t


text:
CODE: LevelDB support

Submission #252303 by N1k1tung to the challenge
https://www.topcoder.com/challenges/30063861

@b-mueller actually just change
headHeaderKey = b'LastBlock'

(was 'LastHeader'), it should point to the available root

Hi @N1k1tung, thanks I changed this. Still can't get it to work though on fully synced Rinkeby:
$ geth --rinkeby --syncmode full

$ $MYTH --leveldb /Users/bernhardmueller/Library/Ethereum/rinkeby/geth/chaindata --search "code#PUSH#"/
Traceback (most recent call last):
  File "/Users/bernhardmueller/Projects/mythril/myth", line 248, in <module>
    ethDB.search(args.search, searchCallback)
  File "/Users/bernhardmueller/Projects/mythril/mythril/leveldb/client.py", line 86, in search
    contracts = self.get_active_contracts()
  File "/Users/bernhardmueller/Projects/mythril/mythril/leveldb/client.py", line 79, in get_active_contracts
    self.get_all_contracts() # optimized
  File "/Users/bernhardmueller/Projects/mythril/mythril/leveldb/client.py", line 54, in get_all_contracts
    state = self._get_head_state()
  File "/Users/bernhardmueller/Projects/mythril/mythril/leveldb/client.py", line 138, in _get_head_state
    self.headState = State(self.db, root)
  File "/Users/bernhardmueller/Projects/mythril/mythril/leveldb/state.py", line 98, in __init__
    self.trie = Trie(self.db, root)
  File "/Users/bernhardmueller/.pyenv/versions/mythril/lib/python3.6/site-packages/ethereum/trie.py", line 150, in __init__
    self.set_root_hash(root_hash)
  File "/Users/bernhardmueller/.pyenv/versions/mythril/lib/python3.6/site-packages/ethereum/trie.py", line 192, in set_root_hash
    self.root_node = self._decode_to_node(root_hash)
  File "/Users/bernhardmueller/.pyenv/versions/mythril/lib/python3.6/site-packages/ethereum/trie.py", line 229, in _decode_to_node
    o = rlp.decode(self.db.get(encoded))
  File "/Users/bernhardmueller/.pyenv/versions/mythril/lib/python3.6/site-packages/rlp/codec.py", line 217, in decode
    rlp = str_to_bytes(rlp)
  File "/Users/bernhardmueller/.pyenv/versions/mythril/lib/python3.6/site-packages/rlp/utils_py3.py", line 20, in str_to_bytes
    return bytes(value, 'utf-8')

Seems to be an error when initializing the Trie object. Any ideas?

@b-mueller the general issue is head block state root doesn't actually point to a valid db entry.
geth is storing a couple references to the head block, it's header, last fast synced block (accessible in db by keys 'LastBlock', 'LastHeader', 'LastFast' respectively).
Particularly 'LastBlock' looks to correspond to web3.eth.getBlock('latest')
Now for specific cases:
With headHeaderKey = b'LastHeader' it works for me with full sync (including rinkeby).
headHeaderKey = b'LastBlock' it works with full and fast sync (including rinkeby):
Nikitas-MacBook-Pro-3:mythril nrodin$ python3 myth --leveldb /Volumes/MyPassport/Rinkeby/geth/chaindata -s "code#PUSH#"
Matched contract with code hash de526501e452ecb64e38cba0cbd2f71e
Address: 0x5aacf1f0feacf617854a6cc33cdd298e5caa53384d8d0f38c9b3d5533117954e, balance: 99999999999999950
Matched contract with code hash bc1a0c304f417a1b49ada52f1bd1dfa3
Address: 0x7bbb06ff14501665ef44dc24b5f2386d8d505bccbaccbaec63c8969a43c29df9, balance: 1048411
Matched contract with code hash bc1a0c304f417a1b49ada52f1bd1dfa3
Address: 0xfa235a135ab445434781ec37ac38b5bf022d4c4298db7697857f5ddc63bf8ca9, balance: 1048408
Matched contract with code hash 5facb6bfdd420e10479bc4ed1a1bd20a
Address: 0x4f8c1fae5f53a88d82e8a9fbb4ef2fbb86dee7f6e68b50437e0d633ad6c82dbc, balance: 10000000000000000
Matched contract with code hash bc1a0c304f417a1b49ada52f1bd1dfa3
Address: 0xa49c2308c66587b91bd75a90105481bd0e96f5e797b5c04fac0bf2d3fff9735d, balance: 1048414
Matched contract with code hash d7184590aa1c74f1caf166d247d383fa
Address: 0x958648d6804a11a8342d95446df59426ea63223d4d748ec7201158ef0aeaf0d4, balance: 1140000000000000
Matched contract with code hash 31680b06566db0021f62864752a8f511
Address: 0x1ab42352267dae74772415e43785e982487752349bb0f872cd6b008ee5d6b2f5, balance: 8529
Matched contract with code hash bc1a0c304f417a1b49ada52f1bd1dfa3
Address: 0x29b97e53ba734eab72287bb83c617ca1d6ce6dd0d19bda24772db30dc44d0dc7, balance: 1048418
Matched contract with code hash bc1a0c304f417a1b49ada52f1bd1dfa3
...
...

One thing is I'm currently using geth 1.8.3:
Geth
Version: 1.8.3-stable
Architecture: amd64
Protocol Versions: [63 62]
Network Id: 1
Go Version: go1.10
Operating System: darwin
GOPATH=
GOROOT=/usr/local/Cellar/go/1.10/libexec

I'll retry with 1.8.0 and will post my results

Cool, that fixed it.

authors: N1k1tung b-mueller birdofpreyru

repo: ConsenSys/mythril


text:
Add DataFrame.iloc

This PR add iloc to _Frame.
import pandas as pd
import dask.dataframe as dd
df = dd.from_pandas(pd.DataFrame({'x': [1, 2, 3, 4], 'y': [5, 6, 7, 8]}), 2)
df.compute()
#    x  y
# 0  1  5
# 1  2  6
# 2  3  7
# 3  4  8

df.iloc[1].compute()
# x    2
# y    6
# Name: 1, dtype: int64

df.iloc[1:3].compute()
#    x  y
# 1  2  6
# 2  3  7

iloc with Series is not supported as the same as pandas.
pd.DataFrame([1, 2, 3]).iloc[pd.Series([True, False, True])]
# NotImplementedError: iLocation based boolean indexing on an integer type is not available

Nice solution.  I find myself conflicted here.  This achieves functionality that people will undoubtedly want but which is also fairly slow.  All iloc queries will result in a full scan over the data just to create the graph.  Do we support this because we can or exclude it to wean users off of it?

I don't have an answer to this question.  I suspect that the Pandas developers have a better understanding than I do of what is valuable and not valuable.

Thanks for your consideration.

All iloc queries will result in a full scan over the data

Not sure I could understand what you mean, but the slowness also applies to loc? Followings are dask graphs of related part.
import pandas as pd
import dask.dataframe as dd
df = dd.from_pandas(pd.DataFrame({'x': [1, 2, 3, 4, 5, 6, 7, 8, 9],
                                  'y': [5, 6, 7, 8, 9, 10, 11, 12, 13]}), 4)
df
df.loc[3].dask
#  ...
#  Index: [], ('loc-element-29', 0): (<function dask.dataframe.core.<lambda>>,
#   ('from_pandas-2', 1))}

df.iloc[3].dask
#  ...
#  Index: [], ('iloc-element-30', 0): (<function dask.dataframe.core.<lambda>>,
#   ('from_pandas-2', 1))}

df.loc[3:6].dask
#  ...
#  Index: [], ('loc-slice-39', 0): (<function dask.dataframe.core._loc>,
#   ('from_pandas-2', 1),
#   3,
#   None), ('loc-slice-39', 1): (<function dask.dataframe.core._loc>,
#   ('from_pandas-2', 2),
#   None,
#   6)}

df.iloc[3:6].dask
#  Index: [], ('iloc-slice-40', 0): (<function dask.dataframe.core._iloc>,
#   ('from_pandas-2', 1),
#   0,
#   None), ('iloc-slice-40', 1): (<function dask.dataframe.core._iloc>,
#   ('from_pandas-2', 2),
#   None,
#   0)}

I think iloc is useful to split some part of data based on its number, and there are following options.

Not support it
Show PerformanceWarning like pandas
Not show warning, describe a note in the doc

@cpcloud @shoyer TomAugspurger Any opinions?

Not sure I could understand what you mean, but the slowness also applies to loc?

The difference is that dask dataframes are partitioned by label, not chunk size. Thus, you need to compute/load the entire dataframe to know integer positions. This is at odds with the general convention that indexing is cheap, because it only requires looking up a small portion of the data. In contrast, with .loc, you can do label based lookup without computing the entire dataframe.
So, I would lean against including .iloc unless there are strong use cases..

This touches an important API decision for dask dataframe: how to balance matching the pandas API with the differing goals of dask. IMO we should be slow to add methods that don't fit well with dask's design.

Nice examples @sinhrks .  The performance difference between iloc and loc in this case is that the cost to produce the graph for loc operations is almost free because we know from the divisions metadata everything we need to construct the graph.  In the iloc case you have a call to compute in _idivisions, so the construction of the graph will trigger a full computation.  Usually we try to make graph construction free; we don't always succeed though.  Operations like set_index do trigger evaluation; we should try to keep these operations very rare though.
All of the options you suggest seem reasonable to me; I don't have a strong opinion here.

Thanks.,I understood the issue. Based on @shoyer and @TomAugspurger 's suggestion, pls leave it until someone strongly request the feature.

OK.  Closing this for now.  Lets keep this PR in mind if someone asks for this in the future.

Just a quick question from someone who uses iloc a lot with pandas dataframes:
I'm just wondering why this is a problem: iloc indexes based on the order and loc indexes based on the label. A label corresponds to an original index so surely we can partition based on either and use a lookup table to map the other?
For example if we keep the current procedure (partition on labels) can there not be a list of tuples ([(label, index)])?
Maybe I just don't understand the issue properly since I've on just started using dask+distributed, but it's a pandas-feature I use often and its a shame that I have to roughly implement it myself with a locally-bound lookup table.

It's hard to propagate count information lazily.
For example with operations like groupby, set_index, join, query, etc.. we can't determine how many values are in each partition without actually performing the computation and looking at all of the values.

I think I'll look at the code to get a better idea of how this works.
But isn't the number of values known? Since we partitioned them at instantiation and track subsequent operations' output?

On 18 Jul 2016, at 13:49, Matthew Rocklin notifications@github.com wrote:
It's hard to propagate count information lazily.
For example with operations like groupby, set_index, join, query, etc.. we can't determine how many values are in each partition without actually performing the computation and looking at all of the values.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

For some operations, like query, the number of values depends on the values themselves.  We would need to do all of the work of the computation in order to maintain this metadata.
df = df.query('x > 0')

In the case above we genuinely need to know how many positive x values we had to keep track of the length metadata.  This kills laziness.

authors: TomAugspurger mrocklin philastrophist shoyer sinhrks

repo: ContinuumIO/dask

license_source: bigquery


text:
Need tests to verify whether ds == eval(str(ds)) for all datashapes

A recent PR (https://github.com/ContinuumIO/datashape/pull/89) came about because one could make a datashape where eval(str(ds)) != ds. It would be helpful if we exhaustively tested this within datashape.

i think truly exhaustive testing of this is not practically doable. However a subset of dshapes that tries to characterize the scope of possible dshapes is definitely doable. Putting up a PR in a few

source: gharchive/issue

authors: cpcloud talumbau

repo: ContinuumIO/datashape


text:
Remove readme's content and fix fake bug

This PR isn't going to be checked-in until the new quickstart goes live.

This PR isn't going to be checked-in until the new quickstart goes live.

Closing the PR as this change is going to be pushed on the new repository.

repo: ContosoBikeRental/BikeSharingSampleApp


text:
Prime players to enable autoplay when out of focus

My version of https://github.com/CookPete/react-player/pull/12 that attempts to fix autoplay issues when ReactPlayer is not in a focused tab. In short:

Render all players at once, but only give props to the player that can play the current url
Each player then sets display: none on itself if url is not present
When ReactPlayer mounts, if YouTube or Vimeo players don't have a url, then prime the player by playing a short, silent video whilst hidden. This allows the players to autoplay any URLs given later on, even if not in a focused tab.

@Fauntleroy, any thoughts?

I was thinking of making the priming functionality manual by using a configuration parameter:
const reactPlayerProps = {
  youtubeConfig: {
    preload: true
  },
  vimeoConfig: {
    preload: true
  }
};
<ReactPlayer {...reactPlayerProps} />

This way we could avoid loading those APIs for those who don't intend on using them.

Updated. Moved priming logic from Base into Youtube and Vimeo players, so they can check their config and decide whether to prime or not. Should probably align the config name (currently preload) with the variable name (currently priming) and add some documentation. It also makes prop logic in ReactPlayer rather awkward so there's potential for improvement there.

Updated. Now using slightly less ambiguous preloading var name

Updated (again) with a short explanation in README.md

Looking to merge this soon even if it's a bit weird.. @Fauntleroy are you happy enough?

@CookPete I'll take a look at this soon to ensure that it works properly. My initial test earlier this week was having some problems. Can you check and see if youtubeConfig makes it all the way to the player?

Can you check and see if youtubeConfig makes it all the way to the player?

Ah yeah that should have been sorted by https://github.com/CookPete/react-player/commit/52574f8aafffded6392016b8ede7b6c9d9d75fc1

Something is definitely wrong when I try to use this in my application. I'm going to try a few things and see if I can resolve the problem.

Autoplay seems to behave differently than it did before, but with playing and youtubeConfig i've managed to get that settled.
Volume, however, is broken. Looks like you just need to make sure volume is included in shouldComponentUpdate:
shouldComponentUpdate (nextProps) {
    return (
      this.props.url !== nextProps.url ||
      this.props.playing !== nextProps.playing ||
      this.props.volume !== nextProps.volume
    )
  }

I'm also running into Uncaught TypeError: Cannot read property 'getFractionLoaded' of undefined when using the SoundCloud player, though I'm trying to figure out how it's even happening.

The issue with getFractionLoaded can be solved by checking to see if this.refs.player exists during the if statement wrapping the contents of progress in ReactPlayer:
progress = () => {
    if (this.props.url && this.refs.player) {
      let progress = {}
      const loaded = this.refs.player.getFractionLoaded()
      const played = this.refs.player.getFractionPlayed()

I'm also having issues rendering all of the players inside my application. For some reason only YouTube will bother to render. Here's what my React inspector is showing me:

I imagine something horrible is happening to important parts of the code when minification occurs. Maybe all of the component names are being destroyed, and that's causing a few things to break here and there?

Wow, thanks very much @Fauntleroy for the testing! I've added some more fixups to hopefully solve most of the issues.

Separate load and play methods are now used to clarify between actually loading media and playing it. Media will play after load if props.playing is true at the time. This should clear up the autoplay issues we've been seeing, and solidify the logic between loading and playing. For example, you can now keep playing: false but click through the demo and load media ready for playing whenever playing becomes `true.

This actually makes autoplay config overrides sort of obsolete/pointless. If you have playing: true, media should autoplay no matter what, and if playing is false then it shouldn't. Any other autoplay settings would just confuse the logic and the players' state.

I've added the volume and getFractionLoaded fixes you suggested. Good spot!
I need to look more at the minified problems. What exact compressor/options are you using?

@CookPete it might not have to do with minification. I seem to remember being able to replicate the issue without minified code, but I can't remember exactly how that came about. I'll look into it more soon.

I'm gonna merge this in an attempt to avoid conflicts with other fixes. Hopefully all problems (other than the weird minified issue) have been sorted

authors: CookPete Fauntleroy

repo: CookPete/react-player


text:
⚠ Samsung has degraded performance

In 05fb910, Samsung (https://samsung.com) experienced degraded performance:

HTTP code: 200
Response time: 2119 ms

Resolved: Samsung performance has improved in b2be75b.

repo: CoopPlayzz/Webstatus-electronicbrands


text:
⚠ Samsung has degraded performance

In 6c0f5c5, Samsung (https://samsung.com) experienced degraded performance:

HTTP code: 200
Response time: 2164 ms

Resolved: Samsung performance has improved in 20670bb.


text:
⚠ Samsung has degraded performance

In 8bced1f, Samsung (https://samsung.com) experienced degraded performance:

HTTP code: 200
Response time: 2110 ms

Resolved: Samsung performance has improved in b45584e.


text:
⚠ Fortnite has degraded performance

In 317bf5a, Fortnite (https://fortnite.com) experienced degraded performance:

HTTP code: 200
Response time: 1325 ms

Resolved: Fortnite performance has improved in d5fd36d.

repo: CoopPlayzz/Webstatus-games


text:
⚠ Fortnite has degraded performance

In 8258170, Fortnite (https://fortnite.com) experienced degraded performance:

HTTP code: 200
Response time: 1494 ms

Resolved: Fortnite performance has improved in 59ae799.


text:
[WIP] Tile bounds that fall within aoi_boundary but not a src_img ignored. isntance_mask only rasterizes labels where there is good data in reference_im

Issue
I found the tile bounds issue by trying to use split_geom via the raster tiler to tile a single Landsat scene that partially intersected with the state of Nebraska (my aoi_boundary). Thjis resulte din many empty tiles because tile bounds outside the landsat image were included.
The instance_mask issue is shown here:

Where the tile partially falls outside the raster image labels shouldn't be created because no data values like -9999.0 will be associated with those labels. This also handles issues that could arise if there are no data values in the corners of rasters (like there are for some Landsat collections).
Type of change

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected - these changes will not be merged until major releases!)

How Has This Been Tested?
I self tested on my own datasets and ran this against existing tests. Whereas before the aoi_boundary fix the following tile would be empty and before the isntance_mask fix there would be labeled pixels where the image had nodata, the issues are shown to be fixed below when I plot the first raster tile and overlay the label tile. I can add a test later.

Checklist:

[x] My PR has a descriptive title
[ ] My code follows PEP8
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new errors
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] My PR passes Travis CI tests
[ ] My PR does not reduce coverage in Codecov

closed because of a messy rebase

repo: CosmiQ/solaris


text:
filter on map

Subject: filter on map
Description:
tried using filter on the map search
Results:
I see 60 users in budapest, but when I filter for all three of can/might/doesn't host, then rather than seein all of them, I see none.  Any filter settings seem to remove all the users.
Backend version: develop-8cfcaa68
Frontend version: develop-8cfcaa68
User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/95.0.4638.54 Safari/537.36
Page: https://app.couchers.org/search?hostingStatusOptions=2&hostingStatusOptions=3&hostingStatusOptions=4
User: rosselet (3361)

Dupe of something: this is known and in the roadmap

authors: CouchersBot aapeliv

repo: Couchers-org/couchers


text:
cannot create event

Subject: cannot create event
Description:
I fill the form. then I click create and nothing happens
Results:
Backend version: develop-3cdcce6b
Frontend version: develop-3cdcce6b
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/96.0.4664.110 Safari/537.36
Page: https://app.couchers.org/event/new
User: stec (7466)

Can't reproduce.


text:
Can't close an host request if expired

Subject: Can't close an host request if expired
Description:
Like in the title the expired host request remain in pending and I can't close it
Results:
Backend version: develop-58373f44
Frontend version: develop-58373f44
User Agent: Mozilla/5.0 (Linux; Android 10; K) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/126.0.0.0 Mobile Safari/537.36
Page: https://couchers.org/messages/chats/91713
User: andreaa (40293)

#3526


text:
Countries => regions visited / lived in

fixes #1464
hey @ShmuelTreiger, how does this look? Let me know if this needs any changes! Thanks

Thanks! Did you check all the tests are passing with yarn test?

In about.tsx, "country" is used in a bunch of variable names. Do those need changing? (I don't know much about the front end)

hey @lucaslcode! How does this look now?
Thanks1

Sure!

done! @lucaslcode Feel free to review when you have time!

authors: ShmuelTreiger lucaslcode rbrishabh


text:
Add chat muting

Closes #2510

[x] Formatted my code with yarn format && yarn lint --fix
[x] There are no warnings from yarn lint
[x] There are no console warnings when running the app
[ ] Added any new components to storybook
[x] Added tests where relevant
[x] All tests pass
[x] Clicked around my changes running locally and it works
[x] Checked Desktop, Mobile and Tablet screen sizes

Haven't delved too deep yet, but not sure why the translations are not applying properly...

I have no idea why the translations are not working. They are working for me locally. Maybe a vercel issue?

Maybe a vercel issue?

Possibly, but it's a bit weird it works fine for things like the donations page and not this...

authors: darrenvong lucaslcode


text:
Retrieving delimiters from syntax nodes like LuaCallArgList

Hello! I'm asking this not as a user of emmylua-analyzer, but as a fellow dev working on a language toolkit. I'm currently implementing a CST based on rowan, and am struggling to find any example of how to get delimiters out of things like call expression arguments. Going through the reverse-dependents on rowan, i've found this repository, which seems fairly active and uses a recent rowan version.
Looking at the syntax module you have, and at LuaCallArgList specifically, there doesn't seem to be any way to retrieve delimiters between function arguments. Did you think of how to solve this yet? Or maybe i overlooked a solution?
Thank you in advance, and i hope i don't disturb your project's development too much with unrelated questions.
UPD: Just 10 minutes after opening this, i found out about SyntaxNode.children_with_tokens(), which seems exactly like what i need. I'll leave this open if you have anything to add, but if not feel free to close right away. Sorry!

You can find many uses of rowan in my parser. My parser is based on the one from rust-analyzer, except all the code is handwritten.

authors: CppCXY elenakrittik

repo: CppCXY/emmylua-analyzer-rust


text:
CASMCMS-8248: Fix reverse proxy authentication

Summary and Scope
Fixes reverse proxy authentication so that logging into the UI through keycloak also logs users into gitea.  The headers changed when we switched from keycloak-gatekeeper to oauth2-proxy.
Issues and Related PRs

Resolves CASMCMS-8248

Testing
Tested on:

Surtur

Test description:
Successfully logged into the UI through keycloak
Risks and Mitigations
No
Pull Request Checklist

[X] Version number(s) incremented, if applicable
[X] Copyrights updated
[X] License file intact
[X] Target branch correct
[X] CHANGELOG.md updated
[X] Testing is appropriate and complete, if applicable
[X] HPC Product Announcement prepared, if applicable

Can you use this to start removing invalid e-mails from our repos as well?
https://github.com/Cray-HPE/gitea/blob/develop/kubernetes/gitea/Chart.yaml#L41-L42

authors: dlaine-hpe rbak-hpe

repo: Cray-HPE/gitea


text:
[DRAFT] Highly experimental changes.

I will explain what everything does later.
This pull request is to improve Crazy Crates and phase out Spigot support.
A few things to be added is Adventure API so you will be able to use those sweet sweet gradients. A few decent optimizations, A few extra features from our to do list and so much more.

[ ] Re-work all current menus using Triumph GUI
[ ] Re-work current commands to use Cloud for multi impl ( Improve them as well , reduce duplicate code as much as possible )
[ ] Add json as an extra data type with an easy convert command with that being the default type. YAML will no longer be used.
[ ] Fix any and all bugs across the plugin duh.
[ ] Add support for CMI Holograms.
[ ] Make crate previews much more configurable i.e defining specific slots instead of ordering them based on the number in the crate file but only after re-working current menus. We can go from there.
[ ] Clean up kotlin/java impl
[ ] Start laying the ground work for multi platform implementations.
[ ] Remove CrateOnTheGo & turn it into its own isolated plugin like Portable LootChests.

ew

repo: Crazy-Crew/Crazy-Crates


text:
Translations update from Hosted Weblate

Translations update from Hosted Weblate for Flashy/Flashy.
Current translation status:

Thank you so much for your support, @Prasanta-Hembram! 😘

You're welcome! I'm glad I could help.

authors: CrazyMarvin Prasanta-Hembram weblate

repo: Crazy-Marvin/Flashy


text:
🛑 sneak.page is down

In ee58982, sneak.page (https://sneak.page) was down:

HTTP code: 404
Response time: 120 ms

Resolved: sneak.page is back up in 852b2f4 after 8 minutes.

repo: Crazy-Marvin/upptime


text:
Add portuguese (adicionar português)

Just a pull request.

Thank you 👍

did they do the json-schema tho

yessir

authors: CannonStealth Exxonnnnnn Maxisthemoose

repo: CreativeDevelopments/CDCommands


text:
🛑 cris book is down

In e99c25b, cris book (http://cristo.top/) was down:

HTTP code: 502
Response time: 492 ms

Resolved: cris book is back up in d0960bf after 8 minutes.

repo: CristoMonte/uptime-demo


text:
🛑 cris book is down

In 83dbc44, cris book (http://cristo.top/) was down:

HTTP code: 502
Response time: 1559 ms

Resolved: cris book is back up in 2e5bea8 after 5 minutes.


text:
🛑 cris book is down

In 56285ab, cris book (http://cristo.top/) was down:

HTTP code: 0
Response time: 0 ms

Resolved: cris book is back up in 50e0ee0 after 20 minutes.


text:
Build a Mobile Application for CAMS

CAMS is a community-oriented map-based, disaster risk information and early warning service with customizable and automated tools to minimize disruptions in service continuity.
At present the application is available in mobile format via the browser; however, this is somewhat limited and can be awkward to use. We would love to have a proper mobile application that people responding to disasters can use.
If you are working on an asset in the middle of a natural disaster, you want to have the most responsive tool possible. A mobile application that seamlessly integrates with the application will allow responders to use the information available in CAMS effectively and provide robust early warning of potential cascading failure.
We don’t really mind how it is implemented.

As it is likely that people will be working in areas of limited connectivity, the mobile application should work offline and sync when reconnected. The CAMS database TerminusDB can facilitate this functionality.

repo: CriticalAssetManagement/CAMS-Dashboard


text:
[BUG] Window scaling with Windows messed up past 100%

Describe the issue
Cannot resize the window, i.e. the mouse doesn't turn into the resizing mode to resize the window.
(have to use the lower right corner to resize (intended))
I maximized and moved the window by right clicking the preview while hovering the icon on the taskbar.
Maximizing it covers the taskbar as well.
Update:
Scaling is messed up past 100% in Windows.
Steps to reproduce
Steps to reproduce the issue:

Open the .exe.

Screenshots

Desktop (please complete the following information):

OS: Win11
App Version: 3.4
Selected HUD: N/A

Resizing has already been added back
https://github.com/CriticalFlaw/TF2HUD.Editor/issues/250
Maybe increase your screen resolution

I've added all-side resizing in https://github.com/CriticalFlaw/TF2HUD.Editor/commit/6646fb2635f681066955ab6bf33ab87849904528 which should help address the issue.
Nothing much I can do about it when you scale up your resolution though. Here's how the app looks maximized on my monitor (3440x1440)

Try this release and see if it works better: https://github.com/CriticalFlaw/TF2HUD.Editor/releases/tag/3.4.1

Try this release and see if it works better: https://github.com/CriticalFlaw/TF2HUD.Editor/releases/tag/3.4.1
Resizing from any side works, the title bar snaps back into view if its outside of view, making it able to maximize without using workarounds.
Just that question on maximize being windowed full screen, covering the taskbar, other than that this is fine to be closed.

authors: CriticalFlaw sparaan


text:
CrossFirebasePushNotification.Current.UnregisterForPushNotifications() crashes app

🐛 Bug Report
Value cannot be null.
Parameter name: str
at Foundation.NSString..ctor (System.String str) [0x0002e] in /Library/Frameworks/Xamarin.iOS.framework/Versions/14.7.0.166/src/Xamarin.iOS/Foundation/NSString.cs:162
at Foundation.NSUserDefaults.SetString (System.String value, System.String defaultName) [0x00000] in /Library/Frameworks/Xamarin.iOS.framework/Versions/14.7.0.166/src/Xamarin.iOS/Foundation/NSUserDefaults.cs:37
at Plugin.FirebasePushNotification.FirebasePushNotificationManager.DidReceiveRegistrationToken (Firebase.CloudMessaging.Messaging messaging, System.String fcmToken) [0x0006f] in /Users/runner/runners/2.169.1/work/1/s/Plugin.FirebasePushNotification/FirebasePushNotificationManager.ios.cs:567
at (wrapper managed-to-native) UIKit.UIApplication.UIApplicationMain(int,string[],intptr,intptr)
at UIKit.UIApplication.Main (System.String[] args, System.IntPtr principal, System.IntPtr delegate) [0x00005] in /Library/Frameworks/Xamarin.iOS.framework/Versions/14.7.0.166/src/Xamarin.iOS/UIKit/UIApplication.cs:86
at UIKit.UIApplication.Main (System.String[] args, System.String principalClassName, System.String delegateClassName) [0x0000e] in /Library/Frameworks/Xamarin.iOS.framework/Versions/14.7.0.166/src/Xamarin.iOS/UIKit/UIApplication.cs:65
at SinglesProject.iOS.Application.Main (System.String[] args) [0x0001f] in /Users/Developer/Projects/Apps/App.iOS/Main.cs:18
Expected behavior
Set the token to empty string
Reproduction steps
For me I can reproduce it by adding this line of code to my logout method:
CrossFirebasePushNotification.Current.UnregisterForPushNotifications()
The app logs out and shows the login screen for a second and then crashes.
Configuration
Version: 3.3.10
Platform:

[x] :iphone: iOS
[ ] :robot: Android
[ ] :checkered_flag: WPF
[ ] :earth_americas: UWP
[ ] :apple: MacOS
[ ] :tv: tvOS
[x] :monkey: Xamarin.Forms

I faced the same issue after Firebase packages update. Probably, updating Firebase packages in Plugin will fix the issue (it needs more investigation).

This line:
https://github.com/CrossGeeks/FirebasePushNotificationPlugin/blob/cda71416f3f847df1b01708868bc1ef1196e33f6/Plugin.FirebasePushNotification/FirebasePushNotificationManager.ios.cs#L305
triggers a call to Plugin.FirebasePushNotification.FirebasePushNotificationManager.DidReceiveRegistrationToken(Messaging messaging, string fcmToken)
This line:
https://github.com/CrossGeeks/FirebasePushNotificationPlugin/blob/cda71416f3f847df1b01708868bc1ef1196e33f6/Plugin.FirebasePushNotification/FirebasePushNotificationManager.ios.cs#L568
crashes the app.
It seems "fcmToken" is null and app tries to construct NSString with null string (that's what crashes the app).
Easy fix should be:
NSUserDefaults.StandardUserDefaults.SetString(fcmToken ?? string.Empty, FirebaseTokenKey);

@sasa-bobic seems like it. I just looked into it quick with the intent to create a pull request. The thing is that the user defaults is already overwritten to string.Empty before. I'd wonder if it's not better to move up that line of code to within the if(!String.IsNullOrEmpty()) block so it will never be set when empty or null. But that might mess up more logic if for some reason it can be null or empty string on another condition except for unregistered.
Besides that: from how it works now, the OnTokenRefresh in that case will also not be called with unregister, so the developer needs to be aware to remove the token him-/herself while on unregistered.
Not sure what the wanted behavior is here.

As of latest version app crashes on android when Calling the UnregisterForPushNotifications()

Is this library still being maintained?

I don't know @jtorvald, but I hope this fix is applied soon along with the updated firebase cloud messaging package.

@jtorvald I think you found your answer..

authors: LeoJHarris antixaker jtorvald sasa-bobic vhugogarcia


text:
Update README.md

Added Falcon Contain PowerShell tool link

Added Falcon Contain as a script contribution.

repo: CrowdStrike/community


text:
Allow disabling of server label in all metrics

Version 0.5.x of postgres_exporter enabled support for multi-server connections from a single exporter. This necessitated a need to be able to distinguish different servers on a per metric basis, so the server label was introduced. However, with our current implementation of pgmonitor, this breaks things in several ways.
Proposed fix is to add a --disable_server_label flag to the exporter startup to remove this new label.
We do not currently connect to multiple pg clusters from the same exporter, so not having the label doesn't break anything for us and fixes several issues we're encountering:

The biggest issue is that the pg_up metric does not have this label applied to it. This breaks our Overview dashboard which does some math along with the replication status metric to determine if a system is up and what it's type is (Primary/Replica). Math can only be done between metrics with matching label sets. I've opened an issue on the postgres_exporter repo itself about this. Maybe we could see about fixing it ourselves as well in another PR?

When upgrading the postgres_exporter to 0.5.x and higher, this also causes all graphs to have their line colors changed and puts duplicated entries into the legend. This is because Prometheus presents a metric with a different label set as a unique metric. This also breaks our single panel metric for pgbackrest due to it causes a multi-series error because it's presenting the same named metric twice to a single metric panel.

The second problem above is only really an issue on upgrades, but it means it would be an ongoing issue until the "old" metrics before the upgrade were phased out. The first issue is a problem even on brand new installs.

Assuming that Promtheus is the target monitoring system, could you not simply configure a scrape config to drop the label from metrics?
https://prometheus.io/docs/prometheus/latest/configuration/configuration/#scrape_config
https://prometheus.io/docs/prometheus/latest/configuration/configuration/#metric_relabel_configs
https://prometheus.io/docs/prometheus/latest/configuration/configuration/#relabel_config
For instance:
scrape_configs:
- job_name: foo

  metric_relabel_configs:
  - regex: 'server'
    action: labeldrop

You could and we did that already. However, unless you do the upgrade in a very specific order (prometheus config update first, then postgres_exporter), you end up with a period of about 5-10 minutes where prometheus is grabbing metrics with the server label. This is currently tricky to require on the HA side of things.
Also, the fact that the pg_up variable completely breaks our overview is a big problem as well. If that wasn't there, we may just be able to say "as of this point forward, all metrics get this new label" and be done with it. Perhaps if they fix that in the future, we can have a release where we bring in support for the server label.

Actually had to do that slightly differently as well to only drop the label on our own postgres_exporter metrics and not possibly interfere with other exporters people may be running
https://github.com/keithf4/pgmonitor/blob/3.3rc1/prometheus/crunchy-prometheus.yml#L34
    - source_labels: [__name__, server]
      regex: "ccp_.*;.+"
      action: replace
      target_label: server
      replacement: ""

Yeah, that makes sense for pg_up. I suppose you could possibly set up a separate scrape config for 'your' postgres_exporters, so that it's only concerned about your labels? Though, it seems like the <filename_pattern> on the file_sd_configs is pretty limited and might not be able to handle all your cases. :thinking: That's unfortunate.


text:
Add Events page and uuid for React list elements

work in progress for issue #30
Changes proposed
Add Events header button to the Navbar
Add Events section to the Homepage
Add padding to the bottom of the page's body
Add uuid library and provide unique keys for list elements in React
Screenshots
Navbar:

Events section on the homepage with events preview cards

Event card after clicking (the event card expands and show more information about the event)

Note to reviewers:
I'd love to hear opinions and suggestions to improve. I wasn't able to figure out how to make smoother transitions from the preview cards to the expanded cards. I believe that adding some images to the Events and Jobs sections would be nice and consistent with the other sections.

Code of Conduct

[x] By submitting this pull request, I confirm I've read and complied with the CoC 🖖

Check List (Check all the applicable boxes)

[x] My code follows the code style of this project.
[ ] My change requires changes to the documentation.
[ ] I have updated the documentation accordingly.
[ ] All new and existing tests passed.
[x] This PR does not contain plagiarized content.
[x] The title of my pull request is a short description of the requested changes.

You can also join our Discord community.
Feel free to check out other cool repositories of the Cryptoverse Web3.
Join the Cryptoverse Web3 GitHub Organisation by raising an issue (you will be sent an invitation).

I decided to change a few other things, so I'm going to close this pr and open another one.

I decided to change a few other things, so I'm going to close this pr and open another one.

you don't have to close
if you push the code on the same branch. the code will reflect in this pr automatically

Thanks, @kabir0x23. I also wanted to change the screenshots and the PR description. I just finished creating the new PR.

and that you can edit pr from the top
but its okay now

Oh, I didn't know. Next time I'll do it like that. Thanks


text:
Mobile login Button on User Profile

Bug Report
System Information

Ubuntu 22.04.4
2.5.0.4 - 20240404.5
Mainline

I confirm:

[x] that I have searched for an existing bug report for this issue.
[x] that I am using the latest available version of AMP.
[x] that my operating system is up-to-date.

Mobile Login button doesn't show qr code and the finish button does not close out the pop up screen. You get a full panel lockup. It can be related to .wizardTab .wizardContents not being setup right

game.danielelliott.info-1712943170482.log

If you don't see the QR code then you've got a plugin blocking it. Likely a privacy plugin of some variety.

This one was tested with a browser that has zero plugins and the error I got is when pressing finish in the pop-up with console up.

I can confirm that. And the link to QR shows 404 error. I've tried two browsers (Arc and empty Safari) and the result is the same.

Is that can be related to using IP address directly instead of domain?
And "Finish" button error:
Unhandled Promise Rejection: TypeError: undefined is not an object (evaluating 'wizardCallbacks[wizName].callback')

authors: MarynaNikitna PhonicUK ssfdre38

repo: CubeCoders/AMP


text:
job_10msがずれる問題について

https://github.com/CuboRex-Development/cugo_ros_motorcontroller/blob/4165f275f6fc6b53f749042103baec29ffac93a5/cugo_ros_motorcontroller/cugo_ros_motorcontroller.ino#L787
current_time - prev_time_10ms > 10000だと、10001usでJobが動くのでJobの度に1us誤差が出てしまい、10秒後に1msずれる気がしました。
current_time - prev_time_10ms >= 10000にしたら改善されないでしょうか？

job_100msは1秒で約1msずれるとのことなので、別要因かもしれませんが。


text:
Toggle visibility of multiple Y axis | remember selected datapoints per device

Is your feature request related to a problem? Please describe.
The multiple-axis lines on the right side significantly impair the readability of the widget.
Ideally, there should be only a single axis visible for all data points with the same range (min and max), similar to the standard “Data Point Graph” widget. This would greatly improve the clarity and user-friendliness of the display.
Furthermore, when attempting to use an identical dashboard for multiple devices of the same type,
the widget remembers the selected data points for the first device set. There should be a possibility to change the selected datapoints per device.
Describe the solution you'd like
An option to show/hide Y axis per datapoint.
An option to remember data points settings per device.
Additional context

Hi @piotrchabros , can you share the version of the plugin which you are using? We recently added the requested feature which allows the merging of the axes with the same min/max values.

authors: eniosultan piotrchabros


text:
🛑 Cust+ is down

In 0390d70, Cust+ (https://cust.cc) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Cust+ is back up in 02c4e00.

repo: CustedNG/upptime


text:
Armor features not loading

Having an odd problem while using using MCDSaveEdit 1.5.2.0 and the Steam version of MCD 1.13.1.0, related to armor.  If I either change an existing piece or add a new piece of armor, it does not load the armor's appropriate feature-set.  For newly added armor, the features are completely missing and I'd have to manually add them myself.  If I replace a piece of existing armor the old armor's features remain and are transferred to the newly selected version.
I've previously used the 1.4.2 version and do not recall having this issue at the time, so this seems new to 1.5.2.  I can't check because 1.4.2 reports that it cannot decrypt the pak file at the standard Steam location:
C:\Program Files (x86)\Steam\steamapps\common\MinecraftDungeons\Dungeons\Content\Paks
The 1.5.2 app doesn't complain when launching and pointing at that location, so I'm assuming it is able to decrypt the pak files, but perhaps it is having trouble with the armor files?

Are you talking about selecting an enchantment for a weapon/armour? If so the same thing is happening to me. I click the Enchantment icon, and I can see that the window opens, but when trying to select it I get kicked back to the main window.
Existing enchantments I can select and upgrade as expected though.
Please fix!

I am referring to the armor features, like the weapon damage aura on Mercenary Armor.  If I have that armor in my inventory, it loads fine when I select it.  However, if I either add a new piece or swap an existing armor to a new type, none of that new armor’s characteristics load.  It thought it might be a visual bug, but it loads that way in the game too.

For newly added armor, the features are completely missing and I'd have to manually add them myself

This is actually intended behavior of MCDSaveEdit. I cannot find in the pak files where it defines what armor properties belong on each of the different armors, probably because they want some of them to have randomizations to them. So, if you want an armor with the expected properties you will have to look it up on a wiki page somewhere (I don't have the time to keep something like that updated).

I think the idea is that the window is supposed to appear next to the primary window

Yes, that was the idea. I didn't think anyone would run MCDSaveEdit in fullscreen. I will have to make some code changes to handle that. Thanks for finding a bug!

authors: CutFlame TreeBranches kurai01

repo: CutFlame/MCDSaveEdit


text:
Управление паролем

[ ] эндпоинт /account/password/lost, принимающий адрес электронной почты, и высылающий на неё письмо с токеном для восстановления, если этот адрес был подтвержден, иначе - отправляющий ошибку с адресом почты поддержки
[ ] эндпоинт /account/password/reset, принимающий токен для восстановления или старый пароль, а также новый пароль

Потеряло смысл из-за задачи #19

repo: CyberDAS-Dev/API


text:
Nous necessitons un salon pour francais - #français

On a besoin d'un nouveau salon...
Dans le monde, il y a une grande problème que beaucoup des gens ne veulent pas apprendre des nouveaux langues. Je pense que c'est nécessaire encourager les gens pour parler dans les autres langues et, par ce que je peux voir, le français est le plus populaire dans ce serveur.
S'il vous plaît, pouvons-nous avoir un salon pour français ou les langues pas anglais ?
Merci !

We need a new living room ...
Around the world, there is a big problem that many people do not want to learn new languages. I think it is necessary to encourage people to speak in other languages and, from what I can see, French is the most popular on this server.
Please, can we have a lounge for French or languages not English?
Thank you !

Pardon, mais non. C'est ne pas necessaire.

Je ne suis pas d'accord.

@lightspeedana C'est dégoûtant que tu ne peux pas voir les importances de cette problème -_-

@NicholasG04 well the fact that it seems only 1 moderator can understand you easily may demonstrate one of the issues here....

C'est pour les intellectuels @SSAFuze

no u

authors: NicholasG04 Rowanyeet SSAFuze lightspeedana thebeanogamer

repo: CyberDiscovery/meta


text:
strip leading "http(s)//", add placeholder

Blame VSCode "Prettier" Extension for formatting changes

I missed the testing thing... AGAIN

There

repo: CyberFurz/furryfediverse-site


text:
UI: Badlisted tags are not colored in file details view

Describe the bug
I see that for some time, badlisted tags are not colored in the file details view, in on the top (they are usually colored in sections view). I'm sure it was working previously, I observed the change a few weeks ago. I'm not 100% sure it's always like this, but it's NOT about tags badlisted after analyzing a file (which is obvious they cannot be marked), but existing before, even for months. I haven't seen such a problem with allowlisted tags.
To Reproduce
Steps to reproduce the behavior:

Upload a file that generates a badlisted tag.
After finishing the submission, compare the summary page and file details view.
Observe badlisted tags colored in the summary view, but not in the file details view.

Expected behavior
Badlisted tags are colored everywhere.
Screenshots
Here, both tags are badlisted. You can also see, that in the section view, tags are colored only in the detailed view for a source and not the first summary-like. I suspect this may be the source of confusion for the UI.

The summary view is handled correctly:

Environment (please complete the following information if pertinent):

Assemblyline Version: 4.5.0.12, Badlist 4.5.0.5
Browser: Firefox

Additional context

This might be coming down to some inconsistency at the API-level between the two endpoints for marking the tags verdicts:

/api/v4/submission//file//
/api/v4/file/result//

repo: CybercentreCanada/assemblyline


text:
Annotation improvements - part 5

Where the sbom is describing a container, use the tagging information from obom

With more components getting auto-tagged, cdxgen bot can answer some questions like a pro.

perplexity

repo: CycloneDX/cdxgen


text:
[WIP] Propose new environmental consideration information for ML models

The fact that datasets used to train AI models are increasingly large and take an enormous amount of energy (and indirectly produce large CO2 emissions) to develop, train and run has come to the forefront.  This PR contains proposed additions to the "modelCard" type to account for these considerations when selecting/utilizing a model.
Fixes https://github.com/CycloneDX/specification/issues/396

TODO

[x] modify JSON schema
[x] modify XML schema
[x] modify protobuf schema
[ ] add examples & test resources

NOTE: we need to add "externalReferences' and "properties" where applicable

@mrutkows is this PR related to an existing issue?
If not, please create an issue that describes the reasoning, use cases, edge cases, out-of-scopes, and such.

this issue claims to solve #396
well, since the #396 does in no way describe a problem yet, I cannot see how this PR intends to solve it.
@mrutkows , please take the 10 minute to describe the actual problem, before I take the two hours to actually review the "solution"

@mrutkows I think we have consensus to use the current model card approach to adding support for environmental concerns and then in v1.7, we can expand that support to every component and service.
What is the status of this PR? We likely have one week to flush this out, otherwise it will need to be postponed to v1.7.

I still have questions and concerns. I vote for postponing and continued discussions in #396
If the data is needed earlier, we still could create CDX properties for this - and ses how it is adopted.

@mrutkows , Vinod and I had a discussion and will work on having this moved forward, having this part of 1.6

a followp will be https://github.com/CycloneDX/specification/issues/406

Please note that I added a new folder to hold "examples" under docgen (with one example so far) as it seems these should become part of the automated doc. generation.

For those following, here is a snapshot of the (JSON) model visualization for just the subtree with the environmental consideration types:

Please note that I did not expand the postal address type above.

test resources still missing.
the one example in docgen is never applied to any test, so i do not count this one.

Where can I find an example of a test reference?  My belief was that the CI automation linted and checked for format?

@mrutkows here is the neeed fix for the examples: https://github.com/mrutkows/specification/pull/3
as soon as this is merged, we should be golden.

@mrutkows here is the neeed fix for the examples: mrutkows#3
as soon as this is merged, we should be golden.

Thanks Jan!!!
BTW, there is still something wrong in the XSD in that I should have an energyConsumptionsType (plural) as well as the current energyConsumptionType to account for the corresponding anonymous type in the JSON schema... I will commit that change shortly.

authors: jkowalleck mrutkows stevespringett

repo: CycloneDX/specification


text:
RecyclerView通过LinearLayoutManager(this, LinearLayoutManager.VERTICAL, true)反转之后，会无限加载，直至加载完毕。并且滑动列表会出现跳动现象。不反转则没有问题

Describe the bug
A clear and concise description of what the bug is.
To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Additional context
Add any other context about the problem here.

尝试在历史问题搜索答案。
尝试阅读文档找到答案。
尝试阅读Demo找到答案。
尝试自己检查或试验以找到答案。
尝试阅读源代码以找到答案。
请勿将产品的一些特殊交互需求 和 该库暂不支持作为bug混为一谈，请您仔细甄别

如果以上都尝试过了请提一个新的issues
参考提問的智慧
如果还是没有找到答案，提问请带上这几个必要信息

当前使用的版本号
复现操作描述
使用代码
crash日志
gif复现效果
抽取demo
将你出现的问题代码抽出来成一个可直接运行的项目。（最好fork本库修改）
在本地修改demo，然后把commit push到github上，在issue里贴下demo的地址。

有详细的描述才能使得我们更快速的定位问题并解决问题，感谢配合！

你反转的目的是？

像聊天那样最新得消息在底部，而后台是倒叙查得。到前端就需要把每个list进行反转。所以就试了下直接把RecyclerView反转

建议直接反转list，而不是反转布局，反转布局不适合你当前的需求

authors: CosmicRayLucky CymChad limuyang2

repo: CymChad/BaseRecyclerViewAdapterHelper


text:
🛑 Documentación Developer is down

In 9bcc1ed, Documentación Developer (https://api.cymasuite.com/api-docs/index.html) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Documentación Developer is back up in 20f1dbb.

repo: CymaSuite/upptime


text:
Fix bug# 14546 - Make the druntime documentation buildable again.

This makes it so that ClockType isn't actually used in core.time in the
documentation build (since if it is, it triggers static assertions,
since none of the systems support all of the ClockTypes, but they all
have to be defined for the documentation build in order to show up in
the docs).

Thanks.

Auto-merge toggled on

authors: CyberShadow MartinNowak jmdavis

repo: D-Programming-Language/druntime


text:
🛑 Sibirian_health is down

In 49cd3d3, Sibirian_health (https://ru.siberianhealth.com/ru/) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Sibirian_health is back up in b535038 after 16 minutes.


text:
fix(hmi-server): use correct url

We need to point to simulation service to make this work.
Resolves #2002

LOL

repo: DARPA-ASKEM/terarium


text:
🛑 DAZSER Web App is down

In 631f165, DAZSER Web App (https://www.dazser.net) was down:

HTTP code: 0
Response time: 0 ms

Resolved: DAZSER Web App is back up in fc7974a after 1 hour, 21 minutes.

repo: DAZSER/status


text:
Change the name of the $risk-adjustment operation

IS: the operation is named $risk-adjustment
SHOULD BE: update the operation name to $evaluate-risk-condition-category

Resolved in #580

authors: c-schuler rob-reynolds

repo: DBCG/cqf-ruler


text:
feat: limit cobra logs to warnings

With the merge of https://github.com/opencobra/cobrapy/pull/774, it becomes clear that the log output from cobra is a bit too verbose. Hopefully limiting levels to warning+ shouldn't hide any relevant information during development.

Codecov Report

Merging #129 into devel will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##            devel     #129   +/-   ##
=======================================
  Coverage   74.73%   74.73%
=======================================
  Files          20       20
  Lines         756      756
=======================================
  Hits          565      565
  Misses        191      191

Impacted Files
Coverage Δ

src/model/settings.py
81.57% <ø> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa4cc81...d7be75e. Read the comment docs.

authors: codecov-io kvikshaug

repo: DD-DeCaF/model


text:
If chant switches segments, should "extra" information be removed on save

With the Benedicamus Domino segment, we've introduced some fields on BaseChant that should only be populated for chants in that segment.
Imagine the following workflow:

a chant is created in the BD segment and these "extra" fields are filled out
the chant is edited and removed from the BD segment...currently, these fields are hidden on the chant edit template

If this edit is saved, the chant is now in a non-BD segment, but has BD-only fields still non-Null in the database. Given that only one person is indexing BD chants, I'm not sure this is an immediate issue, but if we add new segments/extra fields this may be something we want to revisit.

this actually seems potentially relevant for sequence/chant moves as well...certainly there are some objects that can exist in both segments!

certainly there are some objects that can exist in both segments!

objects meaning? I think a "chant" (the colloquial meaning, not our CantusDB specific meaning of chant vs sequence) will only belong to one or the other...

certainly there are some objects that can exist in both segments!

objects meaning? I think a "chant" (the colloquial meaning, not our CantusDB specific meaning of chant vs sequence) will only belong to one or the other...

bleh, problems trying to write on GitHub right before meeting! I mean that there are things like https://cantusdatabase.org/chant/671489 and https://cantusdatabase.org/sequence/628349 which refer to the same real-life chant in different ways....

I see...gotcha. Yeah, that'll be a bit of a data migration headache when we get there!

authors: annamorphism dchiller

repo: DDMAL/CantusDB


text:
eliminate backtracking - use choiceDispatchKey or occursCountKind 'expression'

This schema is old and pre-dates the introduction of DFDL features like choiceDispatchKey.
Presence indicators should be done via choiceDIspatchKey or occursCountKind 'expresion' to eliminate the overhead of backtracking.
It also makes this a better example of how to best handle presence flags in DFDL.

Presence bits no longer backtrack. Repeat bits do, but there is no getting around that.
Fixed in 3af6cbb7ea6e3dd48438a1ef5367b514c2688d1d

license: NCSA


text:
Prepend Heroku app name to config.hosts

Context
We call authorised_hosts.first in HostingEnvironment#hostname when ENV["CUSTOM_HOSTNAME"] is not defined. On Heroku, authorised_hosts always contains apply-for-teacher-training.herokuapp.com as the first item in a review app. Because of this, our review apps send magic link emails that tell users to go to apply-for-teacher-training.herokuapp.com.
This is a bit annoying, but we can easily work around it by prepending the desired hostname.
Changes proposed in this pull request
Prepend the Heroku app hostname instead of appending it. Do this in HostingEnvironment so we're modifying only one source of truth.
Guidance to review
Test this by trying to log into the review app. The email you receive should contain a link that works.
Link to Trello card
Nope.
Things to check

[x] This code doesn't rely on migrations in the same Pull Request
[x] If this code includes a migration adding or changing columns, it also backfills existing records for consistency
[x] API release notes have been updated if necessary
[x] New environment variables have been added to the Azure config

Tested this on the review app, and it doesn't work yet.

Nice:

@tijmenb have made an attempt to make this more resilient locally but I don't think it's great (because: it calls ENV['HEROKU_APP_NAME'] in two places), pushed it up as a branch: https://github.com/DFE-Digital/apply-for-postgraduate-teacher-training/compare/heroku-app-name?expand=1
If you have better ideas for how to improve, reply here or push to that branch 👍


text:
Make Slack poster channel aware

Context
We currently use a channel-specific webhook, but we now have a webhook configured that is allowed to post to all channels. This will make the app more flexible, for example we'll be able to post important messages to #twd_apply too.
Changes proposed in this pull request
This specifies the channel, username and emoji for the Slack posts, so that it goes to the correct one.
Guidance to review
It should all work on QA - we'll know if it doesn't.
I've tried the code in https://ukgovernmentdfe.slack.com/archives/CN1MCQCHZ/p1585585959026100.
Things to check

[x] This code doesn't rely on migrations in the same Pull Request
[x] If this code includes a migration adding or changing columns, it also backfills existing records for consistency
[x] API release notes have been updated if necessary
[x] New environment variables have been added to the Azure config

Merging to reduce number of open PRs 👷

authors: tijmenb tvararu


text:
Add support for testing EoC features

Context
Because most of the features we are implementing to support the changeover from 2020 to 2021 recruitment cycles are date dependent there is no simple way to test them in qa, review apps or local development systems. At a minimum we need to setup up a system to test the features that are activated when the current cycle ends but before the new one begins.
Changes proposed in this pull request

Add a simulate_time_between_cycles feature flag
Use this feature flag to change the behaviour of EndOfCycleTimetable to return results consistent with the closed period between recruitment cycles regardless of the true date.
Add a check to ensure that the new feature flag has no effect in production environments.

Guidance to review

This is meant to be the simplest thing that will work - to make the EoC features testable. There are better (more flexible) ways to do this such as storing the configuration for EndOfCycleTimetable in the database. In particular this implementation makes no distinction between Apply 1 & 2 applications (despite them having different deadlines in real life). Is this a reasonable first step?
Do we need to cache the date values in EndOfCycleTimetable to avoid the repeated feature flag lookups (DB hits).

Link to Trello card
https://trello.com/c/IWsNEUtT/1957-implement-a-way-to-test-eoc-features-in-qa-and-review-apps
Things to check

[x] This code does not rely on migrations in the same Pull Request
[x] If this code includes a migration adding or changing columns, it also backfills existing records for consistency
[x] API release notes have been updated if necessary
[x] New environment variables have been added to the Azure config

The approach LGTM. Just a few minor comments on the test names :shipit:

This is meant to be the simplest thing that will work - to make the EoC features testable. There are better (more flexible) ways to do this such as storing the configuration for EndOfCycleTimetable in the database. In particular this implementation makes no distinction between Apply 1 & 2 applications (despite them having different deadlines in real life). Is this a reasonable first step?

Yes, can refine and think about changing the storage mechanism for these dates if the need arises. :+1:

Do we need to cache the date values in EndOfCycleTimetable to avoid the repeated feature flag lookups (DB hits).

I think this is fine, as the way you've written the boolean check means that the DB lookup will only happen on the test environments.

authors: davidgisbey malcolmbaig stevehook

repo: DFE-Digital/apply-for-teacher-training


text:
Mailing-list-landing-pages-variants-for-split-testing

Trello card
https://trello.com/c/lDSHurFE/5717-create-variants-for-mailing-list-landing-page-split-test
Context
The split tests we have run for a variant mailing list landing page have not shown positive results so we want to test some alternate variants.
Changes proposed in this pull request
We want to create three further variants to test where we:

shorten body copy
remove image and bullets
different CTA text

Guidance to review

@jenhadfield-dfe would you mind taking a look at variant 2 and deleting the image and H1 as I can't work out how to do it. Thanks

@gemmadallmandfe just wondering on version 1 if we lose this bit too?
Whether you’re just thinking about teaching or you’re ready to apply, we’re here to guide you through the steps to becoming a teacher.
So we just have the H2 and bullets?

repo: DFE-Digital/get-into-teaching-app


text:
[4080] Funding payment schedule page

Context
https://trello.com/c/bh4kk55Z/4080-l-funding-monthly-payments-page
Changes proposed in this pull request

Add HTML and ruby logic to display the various tables starting from payments, predicted payments and finally the payment breakdown which are wrapped in accordian boxes

Guidance to review

Open the review app https://register-pr-2355.london.cloudapps.digital/ and log in as Denise Theominis
Select provider on the org page
Navigate to https://register-pr-2355.london.cloudapps.digital/funding/payments-schedule page
Check through the content here, you'll see tables for summary, bursary, scholarships and EYITT

Screenshot

Important business

[x] Does this PR introduce any PII fields that need to be overwritten or deleted in db/scripts/sanitise.sql?
[x] Does this PR change the database schema? If so, have you updated the config/analytics.yml file and considered whether you need to send 'import_entity' events?

NB: Please notify the #twd_data_insights team and ask for a review if new fields are being added to analytics.yml

 [L] funding/monthly-payments page

repo: DFE-Digital/register-trainee-teachers


text:
[1232] Create courses from TTAPI

Context
https://trello.com/c/nPORPb0g/1232-m-retrieve-courses-from-ttapi
Changes proposed in this pull request
This PR:

Adds a scheduled job TeacherTrainingApi::CreateCoursesJob which is currently set to run every day 2am.

Unless the feature flag is on, this does nothing.
If the feature flag is on, the job fans out to one job per provider (currently all providers):

Adds a job TeacherTrainingApi::CreateProviderCoursesJob which takes a provider, and retrieves all of their courses from TTAPI via new service TeacherTrainingApi::RetrieveCourses
It then iterates over these returned course objects and find-or-creates a course for the provider via new service TeacherTrainingApi::CreateCourse.
Adds this new model Course, which currently only has a name and a provider_id

Guidance to review

You can test each of the services manually by running them from the command line. You'll need to ensure that your providers have their actual codes attached.

 [M] Retrieve Courses from TTAPI

@defong @gpeng @darokel thanks for the review - all updates from feedback here a8a665b5c0735a2271a7b604143dcc36ebf64917

Ummm I can kinda see that if api ain't playing nicely we going to flood ourselves with lots of errors

Is there anything we can do to mitigate this? I decided to fan out individual jobs to isolate errors per provider, but maybe there's other things we could do?
Or we just give it a go!


text:
3308 negate subject provider search

Context

https://trello.com/c/XSJooptJ/3308-m-6a-api-add-negated-subject-filtering-support-to-providers-endpoint
Enables searching of training providers that do not offer specified subjects

Changes proposed in this pull request

Refactor AccreditedProviderTrainingProvidersController with internal service class
CourseSearchService now supports subjects prefixed with - which will negate these subjects from the search

Guidance to review

curl "http://localhost:3001/api/v3/recruitment_cycles/2020/courses?filter%5Bhas_vacancies%5D=true&include=site_statuses.site%2Cprovider%2Csubjects&page%5Bpage%5D=1&page%5Bper_page%5D=10&sort=provider.provider_name%2Cname" | json_pp
curl "http://localhost:3001/api/v3/recruitment_cycles/2020/courses?filter%5Bhas_vacancies%5D=true&include=site_statuses.site%2Cprovider%2Csubjects&page%5Bpage%5D=1&page%5Bper_page%5D=10&sort=provider.provider_name%2Cname&filter[subjects]=-00" | json_pp
these should now return different results with Primary courses removed

Checklist

[x] Make sure all information from the Trello card is in here
[x] Attach to Trello card
[x] Rebased master
[x] Cleaned commit history
[x] Tested by running locally

 [M] 6a. (API) Add negated subject filtering support to providers endpoint

I don't think this will work in a way we want 😞
We want it to return training_providers that don't offer a specific subject (say PE). Currently a training provider will not be returned if they only offer that negated subject. However, if they have some other ones eg. biology and PE, biology will be returned by CourseSearchService and this provider's id will end up in eligible_training_provider_ids.

authors: AgaDufrat asmega

repo: DFE-Digital/teacher-training-api


text:
Create deployments role

Jira ticket URL
https://dfedigital.atlassian.net/browse/TEVA-2161
Changes in this PR:

create deployers group
allow members of deployers group to assume deployments role, without needing MFA
attach existing policies associated with the deploy user to the deployments role

Does not yet have a second commit which would remove the policy attachment directly to the deploy user

As discussed please add a policy for the deploy user to assumer the role deployments

As discussed please add a policy for the deploy user to assumer the role deployments

Not needed if the deploy user is granted membership of the Deploymers group which can assume the role Deployments

authors: nickromneydfe saliceti

repo: DFE-Digital/teaching-vacancies


text:
Feature/small issues

This pull request fixes multiple small issues. Namely #499 and #454. So I've changed the cover image and change all occurences of UIL OTS to ILS. UIL OTS was featured in a fixture, which I've changed, but I've also changed this on the server through the admin site, following Michael's advice. Changing the fixture and running loaddata caused no errors on my local version of the code.
I also looked at issue #472, changing the names of UDS and DH Lab, but I've found no occurences of them, so this issue can also be closed IMHO.

We don't have a credit for that image; it's pulled from sites.uu.nl

Ok, I took a new cover image from the beeldbank, and credited the appropriate author. What do you think, @miggol ?

repo: DH-IT-Portal-Development/ethics


text:
[thing to consider] how to communicate that subsection is distinct from the previous subsection

we don't see the beginning and end of module.
each new section should announce itself as start of new section
(when h2's follow h1's)

the next and previous links are clearer now.

authors: leanne-fan szweibel

repo: DHRI-Curriculum/DHRIFT


text:
any plans to extend this for 3D data?

question in the title

see https://github.com/DHZS/tf-dropblock/issues/2#issuecomment-496510184

The code was updated.

authors: DHZS SebastianPopescu maxstrobel

repo: DHZS/tf-dropblock


text:
Moved spacecrafts to sc_ prefix

What it says in the title.
Next step would be to add a custom airframe but that will be for later.
Tackling custom control_allocator now.

sc_ is now the prefix, instead of sr_ or ss_

@Pedro-Roque But what was affected? I don't see any of sr_ or ss_ being changed in the PR

Sorry @Jaeyoung-Lim my bad, that change has been done before, this PR is mostly for adding the 2D and 3D vehicles and some small changes to the CMakeLists (I noticed that old installation files were being kept and not overwritten, so I had a quick fix for that).
Best,
Pedro

authors: Jaeyoung-Lim Pedro-Roque


text:
Add khronos to gitignore in order to avoid "modified" git status

I use submodule to include DPF to my project.
DPF clones khronos in its directory, but it causes "modified" status on git.
This PR adds khronos to gitignore to avoid that status.

I'm recreating the branch to make it go to develop branch

repo: DISTRHO/DPF

license: isc


text:
Factory and test

Related issue

#60 and #61

Proposed changes

Add a simple static stub web server for testing
Update the factory pattern in order to inject the stub webServer
Add automated tests for the CarSelect page

Apparently there is an issue with Travis and instrumented test when we need to verify the popup window text. We were forced to comment out test_case 3 in CarSelect test in order to build and run the tests in Travis. The test runs fine and passes when you run it on local emulator. There is an issue with the way Travis treats pop-up windows in relationship with the root screen. The test needs to be rewritten or we need to find a solution for the Travis set-up.

First of all, I could also verify that indeed the tests pass perfectly fine locally. I even changed the emulator using the armeabi-v7a Instruction Set, with the tests still passing.
Secondly, do we actually need to include inRoot(RootMatchers.isPlatformPopup()) in line 120 of CarSelectTest that obviously is the root of the problem (in Travis side at least)? Because I tested it without it and it passes the TravisCI check in a private repository. I don't think that it affects entirely the logic of the test, so that might be a worth-looking workaround?
Lastly, while giving it more time to test how to circumvent that issue, I tried to alter .travis.yml file and re-run the tests based on the following changes (among other configuration changes as well), adding them at before_screen section, without any luck:
  - adb shell settings put global window_animation_scale 0 &
  - adb shell settings put global transition_animation_scale 0 &
  - adb shell settings put global animator_duration_scale 0 &

So, all in all, in order to not having them commented out, basically we could change the aforementioned line to that: onView(withId(R.id.infoPopup)).check(matches(isDisplayed()));

Yes I agree that will not change the verification in the pop-up. Can you commit the updated test?

Alright, the TravisCI check has passed without any errors, but since I commited last and in order to be inline with the logic of reviews, it would be wiser either someone else to approve it, or just comment if you agree with the last commit so I can approve it.


text:
Payments | Add payout_day_of_month validation

Validation for the maximum date (max=28) and minimum date (min=1) has been added to the payout_day_of_month field

Please, add new migrations

authors: SalimAliev lsoulworkerl

repo: DJWOMS/GSpot


text:
Define "completeness" for adding public plans to list

Related issue #84
To manage the public DMPs list we need to identify some threshold of plan "completeness" without introducing formal status indicators just yet. A percentage of questions answered (>1 question) but something pretty low as @sjDCC suggested (45%) is looking like the best option. The goal is to avoid cluttering the public list with blank/test plans.

recently set to 50% in #713

authors: briri stephaniesimms

repo: DMPRoadmap/roadmap

license: mit


text:
Mark some strings for translation.

This PR marks some unmarked strings for translation. Specifically, this PR fixes #3057 and #3058.
Changes proposed in this PR:

Mark roles presented in "Add a Contributor" pane, defined in app/presenters/contributor_presenter.rb.
Mark "Grant Number" label under "Project Details" tab, defined in app/views/plans/_project_details.html.erb.

Will fix the problems and re-submit a new PR.


text:
Prevent rate limiting

Slow down fetch process because i had the following error
Fetched bundle information... (97/112)
Fetched bundle information... (98/112)
Fetched bundle information... (99/112)
An error occured, exiting.
{ Error: connect ETIMEDOUT 216.58.207.51:443
    at Object.exports._errnoException (util.js:1033:11)
    at exports._exceptionWithHostPort (util.js:1056:20)
    at TCPConnectWrap.afterConnect [as oncomplete] (net.js:1099:14)
  code: 'ETIMEDOUT',
  errno: 'ETIMEDOUT',
  syscall: 'connect',
  address: '216.58.207.51',
  port: 443 }

Hi!
Thanks for bringing this issue up. I added a delay using Bottleneck rather than settimeout/asyncconcat, limiting it to 5 concurrent requests and a 100ms delay.
I releasead this as an update, version 1.0.1, could you try it and see if it works for you now?

Yea this is working. Thanks @DMarby

authors: DMarby maluramichael

repo: DMarby/humblebundle-ebook-downloader

license: Unlicense


text:
Maven repository 400 error

The maven repository doesn't work right now:
http://varscript.ru/artifactory/snapshots/me/dpohvar/powernbt/PowerNBT/0.8.1/PowerNBT-0.8.1.jar
returns a 400 error

fixed:
https://repo.varscript.ru/
https://repo.varscript.ru/release
https://repo.varscript.ru/snapshots

repo: DPOH-VAR/PowerNBT


text:
I apologize for the disturbance again, regarding the query about L1LOSS in the paper

I noticed that the paper calculates the L1 loss between the predicted image's unmasked region and the actual image's unmasked region. What is the significance of this? My understanding is that should we calculate the L1 loss between the repaired (masked) regions?

Firstly, calculates the L1 loss for unmasked region can promote the generated images preserving the unmasked content. Secondly, we may not expect the inpainted image to reproduce the content within the masked regions, for example, when we mask some foreground object of image, we can not expect the network to reproduce the foreground objects from the umasked background. So we let the GAN loss to constrain the generation of masked region solely.

Firstly, calculates the L1 loss for unmasked region can promote the generated images preserving the unmasked content. Secondly, we may not expect the inpainted image to reproduce the content within the masked regions, for example, when we mask some foreground object of image, we can not expect the network to reproduce the foreground objects from the umasked background. So we let the GAN loss to constrain the generation of masked region solely.

Clear answer, thank you!

authors: DQiaole LanTianBy


text:
Setup API Endpoints to get user information

Implement API endpoint to retrieve user points, progress, badges, accomplishments, available quizzes and tasks

Interested


text:
applied a few changes

logo rotate
side nav ease in-out
background img fixed
coloured logo in dark mode
scrollbar changed

Accept if you like them!

Ohh...I forgot..my bad!😅
On Sun, Dec 6, 2020, 5:34 PM Ayush Singh notifications@github.com wrote:

@singhayushh commented on this pull request.
In rawdesign/resources/css/style.css
https://github.com/DSCKGEC/DSCK-Website/pull/11#discussion_r537024521:

@@ -14,6 +14,23 @@ body {

 font-family: 'Mulish', sans-serif;

}
+::-webkit-scrollbar {

width: 0.5rem;

}

+::-webkit-scrollbar-track {

background: repeating-linear-gradient(rgb(255, 87, 87), rgb(88, 88, 230), rgb(76, 228, 76),rgb(241, 241, 88));

}

+::-webkit-scrollbar-thumb {

background:#484849;

Would have been better if the colors for the light theme were kept in the
light.css file, works anyway 😅
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/DSCKGEC/DSCK-Website/pull/11#pullrequestreview-545698607,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ANEXFCYBFTMNSWCQDO2U3BDSTNXNVANCNFSM4UPEGRXQ
.

repo: DSCKGEC/DSCK-Website


text:
🛑 SSO Unhas is down

In e7061ce, SSO Unhas (https://sso.unhas.ac.id) was down:

HTTP code: 0
Response time: 0 ms

Resolved: SSO Unhas is back up in e8d0003 after 5 minutes.


text:
🛑 Sister Unhas is down

In b0fa973, Sister Unhas (http://sister.unhas.ac.id) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Sister Unhas is back up in b0f5d24 after 14 minutes.


text:
🛑 SSO Unhas is down

In ca7503f, SSO Unhas (https://sso.unhas.ac.id) was down:

HTTP code: 0
Response time: 0 ms

Resolved: SSO Unhas is back up in 56efb8b after 5 minutes.


text:
🛑 Fakultas Kedokteran Gigi is down

In b65c857, Fakultas Kedokteran Gigi (https://dent.unhas.ac.id) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Fakultas Kedokteran Gigi is back up in 6e80e41 after 4 minutes.


text:
DS-1028: CAS authentication

https://jira.duraspace.org/browse/DS-1028
It is currently failing building. I am leaving this here for ideas and tips on trying to get it working.
[ERROR] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Compilation failure
/home/dspace/dspace-src/dspace-xmlui/src/main/java/org/dspace/app/xmlui/aspect/administrative/eperson/AddEPersonForm.java:[182,25] cannot find symbol
symbol  : variable ConfigurationManager
location: class org.dspace.app.xmlui.aspect.administrative.eperson.AddEPersonForm

I created an implementation based on some other work that enables CAS and SAML authentication (the latter with attribute discovery). Please check it out from my repo (https://github.com/tboinski/DSpace/tree/CAS_SAML_5_x), the pull request is located at https://github.com/DSpace/DSpace/pull/804. Fell free to check it out and report on the PR page.

authors: misilot tboinski

repo: DSpace/DSpace


text:
Set node version to 18.x in Github workflows

This PR sets the node version in our github workflow actions to at least version 18. Reason to do this is that Github actions use Node v16 by default, but because we are using Yarn v4, we want to ensure yarn installs are running in an environment using at minimum Node v18.

Check out a preview of your pull request here: https://app-servicecanadalabs-dev-pr-preview-3.azurewebsites.net

repo: DTS-STN/Service-Canada-Labs


text:
考虑引入 Turborepo 简化本地 dev 的命令

目标
访问本地运行的页面，修改 monaco-sql-languages 的内容，能够实时反应到 website 中，简化这些步骤的命令
现状

期望
pnpm i
pnpm dev

为了尽可能的减少 git diff，不整块整块的移动文件夹，遇到了一个问题，pnpm-workspace.yaml 中有 ./ 时，turbo 运行有报错：

https://github.com/vercel/turborepo/issues/8599
https://github.com/vercel/turborepo/issues/9017

repo: DTStack/monaco-sql-languages


text:
Trjanav jun20 2024

This is a small touchup of Ana Paula's PR 10 in order to get it to compile with the new cetmodules and fix a cout.

This constitutes an approving review for Ana Paula's PR 10

repo: DUNE/dunecalib