text:
remove init fetch timeout env var

We already use default fetch time out for clusters and listeners via bootstrap and 0s for SDS. Only EDS and RDS use this flag which I think should behave similar to clusters and listeners. So there is no need for this env var.
[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ X] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
Pull Request Attributes
Please check any characteristics that apply to this pull request.
[X ] Does not have any changes that may affect Istio users.

@ramaraochavali: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
cd32f2f1da857bf06e5d977b8537c4503d659597
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ramaraochavali: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
cd32f2f1da857bf06e5d977b8537c4503d659597
link
/test unit-tests_istio

integ-security-multicluster-tests_istio
cd32f2f1da857bf06e5d977b8537c4503d659597
link
/test integ-security-multicluster-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ramaraochavali: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-security-multicluster-tests_istio
3487a94f42e92ec4ba18965a798f60a8922c26b1
link
/test integ-security-multicluster-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ramaraochavali: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-security-multicluster-tests_istio
3487a94f42e92ec4ba18965a798f60a8922c26b1
link
/test integ-security-multicluster-tests_istio

integ-security-k8s-tests_istio
3487a94f42e92ec4ba18965a798f60a8922c26b1
link
/test integ-security-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@ramaraochavali: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-security-multicluster-tests_istio
3487a94f42e92ec4ba18965a798f60a8922c26b1
link
/test integ-security-multicluster-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ramaraochavali: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-security-multicluster-tests_istio
518f3b1975062674dd5da4ea9936ab1d0a879512
link
/test integ-security-multicluster-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ramaraochavali: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-security-multicluster-tests_istio
518f3b1975062674dd5da4ea9936ab1d0a879512
link
/test integ-security-multicluster-tests_istio

unit-tests_istio
164867f13a1b5410f5b73f771e9420f9df5144b6
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

I think current behavior is unset which defaults to 15s. New behavior is 0s
(forever)
On Fri, Feb 19, 2021, 9:18 PM Istio Automation notifications@github.com
wrote:

@ramaraochavali https://github.com/ramaraochavali: The following tests
failed, say /retest to rerun all failed tests:
Test name Commit Details Rerun command
integ-security-multicluster-tests_istio 518f3b1
https://github.com/istio/istio/commit/518f3b1975062674dd5da4ea9936ab1d0a879512
link
https://prow.istio.io/view/gs/istio-prow/pr-logs/pull/istio_istio/30948/integ-security-multicluster-tests_istio/1362771307636199424 /test
integ-security-multicluster-tests_istio
unit-tests_istio 164867f
https://github.com/istio/istio/commit/164867f13a1b5410f5b73f771e9420f9df5144b6
link
https://prow.istio.io/view/gs/istio-prow/pr-logs/pull/istio_istio/30948/unit-tests_istio/1362993668922806272 /test
unit-tests_istio
Instructions for interacting with me using PR comments are available here
https://git.k8s.io/community/contributors/guide/pull-requests.md. If
you have questions or suggestions related to my behavior, please file an
issue against the kubernetes/test-infra
https://github.com/kubernetes/test-infra/issues/new?title=Prow issue:
repository. I understand the commands that are listed here
https://go.k8s.io/bot-commands.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
https://github.com/istio/istio/pull/30948#issuecomment-782562963, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAEYGXJSSRMKR5XV5NO4BZ3S75AZRANCNFSM4X4FK6DQ
.

I think current behavior is unset which defaults to 15s. New behavior is 0s
(forever)

Sorry I did not follow. This is for which SDS?

I see what you mean.  I did not fully look at this method
	timeout, f := testTimeoutVar.Lookup()
		if !f {
			return nil
		}
		return ptypes.DurationProto(timeout)

@ramaraochavali: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
9a356780bef1fd5667d761e7cb0c7c9c5a50b9e8
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn I cleanup all the stuff but still removed the env var because

I think EDS and RDS should be consistent with CDS and LDS (We default it to 15s and do not provide ability to override for them) and I think EDS and RDS do not need the ability. Let me know if you think there are any special cases in them that need that behaviour
Defaulted the SdsAdsConfig and ConstructSdsSecretConfig to same 15s

Do you have any other concerns on why we need that control?

authors: howardjohn istio-testing ramaraochavali


text:
fix command

Signed-off-by: zackzhangkai zhangkaiamm@gmail.com
[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
Pull Request Attributes
Please check any characteristics that apply to this pull request.
[ ] Does not have any changes that may affect Istio users.

@zackzhangkai: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
d03a41a24788da9af521a10aa6f4b183bb31aeb2
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@zackzhangkai: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
07042cb8cb19bfdcf43a90606814147d5c3e917b
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@zackzhangkai: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
07042cb8cb19bfdcf43a90606814147d5c3e917b
link
/test release-notes_istio

integ-distroless-k8s-tests_istio
07042cb8cb19bfdcf43a90606814147d5c3e917b
link
/test integ-distroless-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

source: gharchive/pull-request

authors: bianpengyuan istio-testing zackzhangkai

repo: istio/istio

license_type: permissive

license_source: github-api


text:
Automator: update ztunnel@release-1.19 in istio/istio@release-1.19

Generated by Automator - 2023-11-08T21:27:36+00:00

@istio-testing: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests_istio_release-1.19
1b167b946c6edae09b8b3e802bf8497ea782a278
link
true
/test unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test unit-tests

authors: hanxiaop istio-testing


text:
Remove runAs from test deployment files

They're not strictly required and do not play well with OpenShift.

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

/test integ-pilot

/test all

@jwendell: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
962552502be77fe2abc0b6124d5595996682193a
link
true
/test unit-tests-arm64

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jwendell: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
962552502be77fe2abc0b6124d5595996682193a
link
true
/test unit-tests-arm64

unit-tests_istio
962552502be77fe2abc0b6124d5595996682193a
link
true
/test unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test all

A bit worried about this. I think this means it will run as root since that is the image default?

AFAIK it means processes inside the container will run as root inside the container. OpenShift won't actually run the processes as root on the node, though.

And running as root makes the test moot, IIUC, since we have different iptables rules for root vs non-root?
Plausible I am wrong

I'm not sure what we're testing here? The only things that actually do anything with UID 1338 are

pkg/test/echo/docker/Dockerfile.app_sidecar_base_centos
`pkg/test/echo/docker/Dockerfile.app_sidecar_base
but we never actually use that user for anything.

Either way adding USER application to both of those dockerfiles would be equivalent to specifying the runAs stuff in the manifest, and shouldn't affect the tests and probably won't make OShift unhappy.

Yeah if we add USER to those SGTM
On Wed, Nov 15, 2023 at 12:54 PM Ben Leggett @.***>
wrote:

A bit worried about this. I think this means it will run as root since
that is the image default?
AFAIK it means processes inside the container will run as root inside the
container. OpenShift won't actually run the processes as root on the node,
though.
And running as root makes the test moot, IIUC, since we have different
iptables rules for root vs non-root?
Plausible I am wrong
I'm not sure what we're testing here? The only things that actually do
anything with UID 1338 are

pkg/test/echo/docker/Dockerfile.app_sidecar_base_centos
`pkg/test/echo/docker/Dockerfile.app_sidecar_base
but we never actually use that user for anything.

Either way adding USER application to both of those dockerfiles would be
equivalent to specifying the runAs stuff in the manifest, and shouldn't
affect the tests and probably won't make OShift unhappy.
—
Reply to this email directly, view it on GitHub
https://github.com/istio/istio/pull/47850#issuecomment-1813248002, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAEYGXNX5D6D57OFDZJ6BZTYEUT2HAVCNFSM6AAAAAA7LXUE4KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMJTGI2DQMBQGI
.
You are receiving this because your review was requested.Message ID:
@.***>

We'd need to add USER to pkg/test/echo/docker/Dockerfile.app which is the main Dockerfile for the echo app. Let me try.

@jwendell: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-ambient_istio
fc0a61b6e031a7a39594d5316fff2988b876f779
link
true
/test integ-ambient

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jwendell: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-ambient_istio
fc0a61b6e031a7a39594d5316fff2988b876f779
link
true
/test integ-ambient

integ-pilot-istiodremote_istio
fc0a61b6e031a7a39594d5316fff2988b876f779
link
true
/test integ-pilot-istiodremote

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jwendell: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-ambient_istio
fc0a61b6e031a7a39594d5316fff2988b876f779
link
true
/test integ-ambient

integ-pilot-istiodremote_istio
fc0a61b6e031a7a39594d5316fff2988b876f779
link
true
/test integ-pilot-istiodremote

integ-basic-arm64_istio
fc0a61b6e031a7a39594d5316fff2988b876f779
link
true
/test integ-basic-arm64

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jwendell: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-ambient_istio
fc0a61b6e031a7a39594d5316fff2988b876f779
link
true
/test integ-ambient

integ-pilot-istiodremote_istio
fc0a61b6e031a7a39594d5316fff2988b876f779
link
true
/test integ-pilot-istiodremote

integ-basic-arm64_istio
fc0a61b6e031a7a39594d5316fff2988b876f779
link
true
/test integ-basic-arm64

integ-operator-controller_istio
fc0a61b6e031a7a39594d5316fff2988b876f779
link
true
/test integ-operator-controller

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jwendell: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-ambient_istio
fc0a61b6e031a7a39594d5316fff2988b876f779
link
true
/test integ-ambient

integ-pilot-istiodremote_istio
fc0a61b6e031a7a39594d5316fff2988b876f779
link
true
/test integ-pilot-istiodremote

integ-basic-arm64_istio
fc0a61b6e031a7a39594d5316fff2988b876f779
link
true
/test integ-basic-arm64

integ-operator-controller_istio
fc0a61b6e031a7a39594d5316fff2988b876f779
link
true
/test integ-operator-controller

integ-ds_istio
fc0a61b6e031a7a39594d5316fff2988b876f779
link
true
/test integ-ds

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jwendell: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-ambient_istio
fc0a61b6e031a7a39594d5316fff2988b876f779
link
true
/test integ-ambient

integ-pilot-istiodremote_istio
fc0a61b6e031a7a39594d5316fff2988b876f779
link
true
/test integ-pilot-istiodremote

integ-basic-arm64_istio
fc0a61b6e031a7a39594d5316fff2988b876f779
link
true
/test integ-basic-arm64

integ-operator-controller_istio
fc0a61b6e031a7a39594d5316fff2988b876f779
link
true
/test integ-operator-controller

integ-ds_istio
fc0a61b6e031a7a39594d5316fff2988b876f779
link
true
/test integ-ds

integ-helm_istio
fc0a61b6e031a7a39594d5316fff2988b876f779
link
true
/test integ-helm

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jwendell: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-ambient_istio
fc0a61b6e031a7a39594d5316fff2988b876f779
link
true
/test integ-ambient

integ-pilot-istiodremote_istio
fc0a61b6e031a7a39594d5316fff2988b876f779
link
true
/test integ-pilot-istiodremote

integ-basic-arm64_istio
fc0a61b6e031a7a39594d5316fff2988b876f779
link
true
/test integ-basic-arm64

integ-operator-controller_istio
fc0a61b6e031a7a39594d5316fff2988b876f779
link
true
/test integ-operator-controller

integ-ds_istio
fc0a61b6e031a7a39594d5316fff2988b876f779
link
true
/test integ-ds

integ-helm_istio
fc0a61b6e031a7a39594d5316fff2988b876f779
link
true
/test integ-helm

integ-pilot-multicluster_istio
fc0a61b6e031a7a39594d5316fff2988b876f779
link
true
/test integ-pilot-multicluster

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jwendell: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-ambient_istio
fc0a61b6e031a7a39594d5316fff2988b876f779
link
true
/test integ-ambient

integ-pilot-istiodremote_istio
fc0a61b6e031a7a39594d5316fff2988b876f779
link
true
/test integ-pilot-istiodremote

integ-basic-arm64_istio
fc0a61b6e031a7a39594d5316fff2988b876f779
link
true
/test integ-basic-arm64

integ-operator-controller_istio
fc0a61b6e031a7a39594d5316fff2988b876f779
link
true
/test integ-operator-controller

integ-ds_istio
fc0a61b6e031a7a39594d5316fff2988b876f779
link
true
/test integ-ds

integ-helm_istio
fc0a61b6e031a7a39594d5316fff2988b876f779
link
true
/test integ-helm

integ-pilot-multicluster_istio
fc0a61b6e031a7a39594d5316fff2988b876f779
link
true
/test integ-pilot-multicluster

integ-ipv6_istio
fc0a61b6e031a7a39594d5316fff2988b876f779
link
true
/test integ-ipv6

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jwendell: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-ambient_istio
fc0a61b6e031a7a39594d5316fff2988b876f779
link
true
/test integ-ambient

integ-pilot-istiodremote_istio
fc0a61b6e031a7a39594d5316fff2988b876f779
link
true
/test integ-pilot-istiodremote

integ-basic-arm64_istio
fc0a61b6e031a7a39594d5316fff2988b876f779
link
true
/test integ-basic-arm64

integ-operator-controller_istio
fc0a61b6e031a7a39594d5316fff2988b876f779
link
true
/test integ-operator-controller

integ-ds_istio
fc0a61b6e031a7a39594d5316fff2988b876f779
link
true
/test integ-ds

integ-helm_istio
fc0a61b6e031a7a39594d5316fff2988b876f779
link
true
/test integ-helm

integ-pilot-multicluster_istio
fc0a61b6e031a7a39594d5316fff2988b876f779
link
true
/test integ-pilot-multicluster

integ-ipv6_istio
fc0a61b6e031a7a39594d5316fff2988b876f779
link
true
/test integ-ipv6

integ-distroless_istio
fc0a61b6e031a7a39594d5316fff2988b876f779
link
true
/test integ-distroless

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jwendell: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-ambient_istio
fc0a61b6e031a7a39594d5316fff2988b876f779
link
true
/test integ-ambient

integ-pilot-istiodremote_istio
fc0a61b6e031a7a39594d5316fff2988b876f779
link
true
/test integ-pilot-istiodremote

integ-basic-arm64_istio
fc0a61b6e031a7a39594d5316fff2988b876f779
link
true
/test integ-basic-arm64

integ-operator-controller_istio
fc0a61b6e031a7a39594d5316fff2988b876f779
link
true
/test integ-operator-controller

integ-ds_istio
fc0a61b6e031a7a39594d5316fff2988b876f779
link
true
/test integ-ds

integ-helm_istio
fc0a61b6e031a7a39594d5316fff2988b876f779
link
true
/test integ-helm

integ-pilot-multicluster_istio
fc0a61b6e031a7a39594d5316fff2988b876f779
link
true
/test integ-pilot-multicluster

integ-ipv6_istio
fc0a61b6e031a7a39594d5316fff2988b876f779
link
true
/test integ-ipv6

integ-distroless_istio
fc0a61b6e031a7a39594d5316fff2988b876f779
link
true
/test integ-distroless

integ-pilot-istiodremote-mc_istio
fc0a61b6e031a7a39594d5316fff2988b876f779
link
true
/test integ-pilot-istiodremote-mc

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jwendell: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-ambient_istio
fc0a61b6e031a7a39594d5316fff2988b876f779
link
true
/test integ-ambient

integ-pilot-istiodremote_istio
fc0a61b6e031a7a39594d5316fff2988b876f779
link
true
/test integ-pilot-istiodremote

integ-basic-arm64_istio
fc0a61b6e031a7a39594d5316fff2988b876f779
link
true
/test integ-basic-arm64

integ-operator-controller_istio
fc0a61b6e031a7a39594d5316fff2988b876f779
link
true
/test integ-operator-controller

integ-ds_istio
fc0a61b6e031a7a39594d5316fff2988b876f779
link
true
/test integ-ds

integ-helm_istio
fc0a61b6e031a7a39594d5316fff2988b876f779
link
true
/test integ-helm

integ-pilot-multicluster_istio
fc0a61b6e031a7a39594d5316fff2988b876f779
link
true
/test integ-pilot-multicluster

integ-ipv6_istio
fc0a61b6e031a7a39594d5316fff2988b876f779
link
true
/test integ-ipv6

integ-distroless_istio
fc0a61b6e031a7a39594d5316fff2988b876f779
link
true
/test integ-distroless

integ-pilot-istiodremote-mc_istio
fc0a61b6e031a7a39594d5316fff2988b876f779
link
true
/test integ-pilot-istiodremote-mc

integ-cni_istio
fc0a61b6e031a7a39594d5316fff2988b876f779
link
true
/test integ-cni

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jwendell: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-ambient_istio
fc0a61b6e031a7a39594d5316fff2988b876f779
link
true
/test integ-ambient

integ-pilot-istiodremote_istio
fc0a61b6e031a7a39594d5316fff2988b876f779
link
true
/test integ-pilot-istiodremote

integ-basic-arm64_istio
fc0a61b6e031a7a39594d5316fff2988b876f779
link
true
/test integ-basic-arm64

integ-operator-controller_istio
fc0a61b6e031a7a39594d5316fff2988b876f779
link
true
/test integ-operator-controller

integ-ds_istio
fc0a61b6e031a7a39594d5316fff2988b876f779
link
true
/test integ-ds

integ-helm_istio
fc0a61b6e031a7a39594d5316fff2988b876f779
link
true
/test integ-helm

integ-pilot-multicluster_istio
fc0a61b6e031a7a39594d5316fff2988b876f779
link
true
/test integ-pilot-multicluster

integ-ipv6_istio
fc0a61b6e031a7a39594d5316fff2988b876f779
link
true
/test integ-ipv6

integ-distroless_istio
fc0a61b6e031a7a39594d5316fff2988b876f779
link
true
/test integ-distroless

integ-pilot-istiodremote-mc_istio
fc0a61b6e031a7a39594d5316fff2988b876f779
link
true
/test integ-pilot-istiodremote-mc

integ-cni_istio
fc0a61b6e031a7a39594d5316fff2988b876f779
link
true
/test integ-cni

integ-pilot_istio
fc0a61b6e031a7a39594d5316fff2988b876f779
link
true
/test integ-pilot

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jwendell: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-ambient_istio
fc0a61b6e031a7a39594d5316fff2988b876f779
link
true
/test integ-ambient

integ-pilot-istiodremote_istio
fc0a61b6e031a7a39594d5316fff2988b876f779
link
true
/test integ-pilot-istiodremote

integ-basic-arm64_istio
fc0a61b6e031a7a39594d5316fff2988b876f779
link
true
/test integ-basic-arm64

integ-operator-controller_istio
fc0a61b6e031a7a39594d5316fff2988b876f779
link
true
/test integ-operator-controller

integ-ds_istio
fc0a61b6e031a7a39594d5316fff2988b876f779
link
true
/test integ-ds

integ-helm_istio
fc0a61b6e031a7a39594d5316fff2988b876f779
link
true
/test integ-helm

integ-pilot-multicluster_istio
fc0a61b6e031a7a39594d5316fff2988b876f779
link
true
/test integ-pilot-multicluster

integ-ipv6_istio
fc0a61b6e031a7a39594d5316fff2988b876f779
link
true
/test integ-ipv6

integ-distroless_istio
fc0a61b6e031a7a39594d5316fff2988b876f779
link
true
/test integ-distroless

integ-pilot-istiodremote-mc_istio
fc0a61b6e031a7a39594d5316fff2988b876f779
link
true
/test integ-pilot-istiodremote-mc

integ-cni_istio
fc0a61b6e031a7a39594d5316fff2988b876f779
link
true
/test integ-cni

integ-pilot_istio
fc0a61b6e031a7a39594d5316fff2988b876f779
link
true
/test integ-pilot

integ-telemetry-istiodremote_istio
fc0a61b6e031a7a39594d5316fff2988b876f779
link
true
/test integ-telemetry-istiodremote

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jwendell: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-ambient_istio
fc0a61b6e031a7a39594d5316fff2988b876f779
link
true
/test integ-ambient

integ-pilot-istiodremote_istio
fc0a61b6e031a7a39594d5316fff2988b876f779
link
true
/test integ-pilot-istiodremote

integ-basic-arm64_istio
fc0a61b6e031a7a39594d5316fff2988b876f779
link
true
/test integ-basic-arm64

integ-operator-controller_istio
fc0a61b6e031a7a39594d5316fff2988b876f779
link
true
/test integ-operator-controller

integ-ds_istio
fc0a61b6e031a7a39594d5316fff2988b876f779
link
true
/test integ-ds

integ-helm_istio
fc0a61b6e031a7a39594d5316fff2988b876f779
link
true
/test integ-helm

integ-pilot-multicluster_istio
fc0a61b6e031a7a39594d5316fff2988b876f779
link
true
/test integ-pilot-multicluster

integ-ipv6_istio
fc0a61b6e031a7a39594d5316fff2988b876f779
link
true
/test integ-ipv6

integ-distroless_istio
fc0a61b6e031a7a39594d5316fff2988b876f779
link
true
/test integ-distroless

integ-pilot-istiodremote-mc_istio
fc0a61b6e031a7a39594d5316fff2988b876f779
link
true
/test integ-pilot-istiodremote-mc

integ-cni_istio
fc0a61b6e031a7a39594d5316fff2988b876f779
link
true
/test integ-cni

integ-pilot_istio
fc0a61b6e031a7a39594d5316fff2988b876f779
link
true
/test integ-pilot

integ-telemetry-istiodremote_istio
fc0a61b6e031a7a39594d5316fff2988b876f779
link
true
/test integ-telemetry-istiodremote

integ-telemetry-mc_istio
fc0a61b6e031a7a39594d5316fff2988b876f779
link
true
/test integ-telemetry-mc

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jwendell: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-ambient_istio
fc0a61b6e031a7a39594d5316fff2988b876f779
link
true
/test integ-ambient

integ-pilot-istiodremote_istio
fc0a61b6e031a7a39594d5316fff2988b876f779
link
true
/test integ-pilot-istiodremote

integ-basic-arm64_istio
fc0a61b6e031a7a39594d5316fff2988b876f779
link
true
/test integ-basic-arm64

integ-operator-controller_istio
fc0a61b6e031a7a39594d5316fff2988b876f779
link
true
/test integ-operator-controller

integ-ds_istio
fc0a61b6e031a7a39594d5316fff2988b876f779
link
true
/test integ-ds

integ-helm_istio
fc0a61b6e031a7a39594d5316fff2988b876f779
link
true
/test integ-helm

integ-pilot-multicluster_istio
fc0a61b6e031a7a39594d5316fff2988b876f779
link
true
/test integ-pilot-multicluster

integ-ipv6_istio
fc0a61b6e031a7a39594d5316fff2988b876f779
link
true
/test integ-ipv6

integ-distroless_istio
fc0a61b6e031a7a39594d5316fff2988b876f779
link
true
/test integ-distroless

integ-pilot-istiodremote-mc_istio
fc0a61b6e031a7a39594d5316fff2988b876f779
link
true
/test integ-pilot-istiodremote-mc

integ-cni_istio
fc0a61b6e031a7a39594d5316fff2988b876f779
link
true
/test integ-cni

integ-pilot_istio
fc0a61b6e031a7a39594d5316fff2988b876f779
link
true
/test integ-pilot

integ-telemetry-istiodremote_istio
fc0a61b6e031a7a39594d5316fff2988b876f779
link
true
/test integ-telemetry-istiodremote

integ-telemetry-mc_istio
fc0a61b6e031a7a39594d5316fff2988b876f779
link
true
/test integ-telemetry-mc

integ-telemetry-discovery_istio
fc0a61b6e031a7a39594d5316fff2988b876f779
link
true
/test integ-telemetry-discovery

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jwendell: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-ambient_istio
fc0a61b6e031a7a39594d5316fff2988b876f779
link
true
/test integ-ambient

integ-pilot-istiodremote_istio
fc0a61b6e031a7a39594d5316fff2988b876f779
link
true
/test integ-pilot-istiodremote

integ-basic-arm64_istio
fc0a61b6e031a7a39594d5316fff2988b876f779
link
true
/test integ-basic-arm64

integ-operator-controller_istio
fc0a61b6e031a7a39594d5316fff2988b876f779
link
true
/test integ-operator-controller

integ-ds_istio
fc0a61b6e031a7a39594d5316fff2988b876f779
link
true
/test integ-ds

integ-helm_istio
fc0a61b6e031a7a39594d5316fff2988b876f779
link
true
/test integ-helm

integ-pilot-multicluster_istio
fc0a61b6e031a7a39594d5316fff2988b876f779
link
true
/test integ-pilot-multicluster

integ-ipv6_istio
fc0a61b6e031a7a39594d5316fff2988b876f779
link
true
/test integ-ipv6

integ-distroless_istio
fc0a61b6e031a7a39594d5316fff2988b876f779
link
true
/test integ-distroless

integ-pilot-istiodremote-mc_istio
fc0a61b6e031a7a39594d5316fff2988b876f779
link
true
/test integ-pilot-istiodremote-mc

integ-cni_istio
fc0a61b6e031a7a39594d5316fff2988b876f779
link
true
/test integ-cni

integ-pilot_istio
fc0a61b6e031a7a39594d5316fff2988b876f779
link
true
/test integ-pilot

integ-telemetry-istiodremote_istio
fc0a61b6e031a7a39594d5316fff2988b876f779
link
true
/test integ-telemetry-istiodremote

integ-telemetry-mc_istio
fc0a61b6e031a7a39594d5316fff2988b876f779
link
true
/test integ-telemetry-mc

integ-telemetry-discovery_istio
fc0a61b6e031a7a39594d5316fff2988b876f779
link
true
/test integ-telemetry-discovery

integ-telemetry_istio
fc0a61b6e031a7a39594d5316fff2988b876f779
link
true
/test integ-telemetry

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jwendell: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-ambient_istio
fc0a61b6e031a7a39594d5316fff2988b876f779
link
true
/test integ-ambient

integ-pilot-istiodremote_istio
fc0a61b6e031a7a39594d5316fff2988b876f779
link
true
/test integ-pilot-istiodremote

integ-basic-arm64_istio
fc0a61b6e031a7a39594d5316fff2988b876f779
link
true
/test integ-basic-arm64

integ-operator-controller_istio
fc0a61b6e031a7a39594d5316fff2988b876f779
link
true
/test integ-operator-controller

integ-ds_istio
fc0a61b6e031a7a39594d5316fff2988b876f779
link
true
/test integ-ds

integ-helm_istio
fc0a61b6e031a7a39594d5316fff2988b876f779
link
true
/test integ-helm

integ-pilot-multicluster_istio
fc0a61b6e031a7a39594d5316fff2988b876f779
link
true
/test integ-pilot-multicluster

integ-ipv6_istio
fc0a61b6e031a7a39594d5316fff2988b876f779
link
true
/test integ-ipv6

integ-distroless_istio
fc0a61b6e031a7a39594d5316fff2988b876f779
link
true
/test integ-distroless

integ-pilot-istiodremote-mc_istio
fc0a61b6e031a7a39594d5316fff2988b876f779
link
true
/test integ-pilot-istiodremote-mc

integ-cni_istio
fc0a61b6e031a7a39594d5316fff2988b876f779
link
true
/test integ-cni

integ-pilot_istio
fc0a61b6e031a7a39594d5316fff2988b876f779
link
true
/test integ-pilot

integ-telemetry-istiodremote_istio
fc0a61b6e031a7a39594d5316fff2988b876f779
link
true
/test integ-telemetry-istiodremote

integ-telemetry-mc_istio
fc0a61b6e031a7a39594d5316fff2988b876f779
link
true
/test integ-telemetry-mc

integ-telemetry-discovery_istio
fc0a61b6e031a7a39594d5316fff2988b876f779
link
true
/test integ-telemetry-discovery

integ-telemetry_istio
fc0a61b6e031a7a39594d5316fff2988b876f779
link
true
/test integ-telemetry

integ-security-istiodremote_istio
fc0a61b6e031a7a39594d5316fff2988b876f779
link
true
/test integ-security-istiodremote

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jwendell: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-ambient_istio
fc0a61b6e031a7a39594d5316fff2988b876f779
link
true
/test integ-ambient

integ-pilot-istiodremote_istio
fc0a61b6e031a7a39594d5316fff2988b876f779
link
true
/test integ-pilot-istiodremote

integ-basic-arm64_istio
fc0a61b6e031a7a39594d5316fff2988b876f779
link
true
/test integ-basic-arm64

integ-operator-controller_istio
fc0a61b6e031a7a39594d5316fff2988b876f779
link
true
/test integ-operator-controller

integ-ds_istio
fc0a61b6e031a7a39594d5316fff2988b876f779
link
true
/test integ-ds

integ-helm_istio
fc0a61b6e031a7a39594d5316fff2988b876f779
link
true
/test integ-helm

integ-pilot-multicluster_istio
fc0a61b6e031a7a39594d5316fff2988b876f779
link
true
/test integ-pilot-multicluster

integ-ipv6_istio
fc0a61b6e031a7a39594d5316fff2988b876f779
link
true
/test integ-ipv6

integ-distroless_istio
fc0a61b6e031a7a39594d5316fff2988b876f779
link
true
/test integ-distroless

integ-pilot-istiodremote-mc_istio
fc0a61b6e031a7a39594d5316fff2988b876f779
link
true
/test integ-pilot-istiodremote-mc

integ-cni_istio
fc0a61b6e031a7a39594d5316fff2988b876f779
link
true
/test integ-cni

integ-pilot_istio
fc0a61b6e031a7a39594d5316fff2988b876f779
link
true
/test integ-pilot

integ-telemetry-istiodremote_istio
fc0a61b6e031a7a39594d5316fff2988b876f779
link
true
/test integ-telemetry-istiodremote

integ-telemetry-mc_istio
fc0a61b6e031a7a39594d5316fff2988b876f779
link
true
/test integ-telemetry-mc

integ-telemetry-discovery_istio
fc0a61b6e031a7a39594d5316fff2988b876f779
link
true
/test integ-telemetry-discovery

integ-telemetry_istio
fc0a61b6e031a7a39594d5316fff2988b876f779
link
true
/test integ-telemetry

integ-security-istiodremote_istio
fc0a61b6e031a7a39594d5316fff2988b876f779
link
true
/test integ-security-istiodremote

integ-security_istio
fc0a61b6e031a7a39594d5316fff2988b876f779
link
true
/test integ-security

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jwendell: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-ambient_istio
fc0a61b6e031a7a39594d5316fff2988b876f779
link
true
/test integ-ambient

integ-pilot-istiodremote_istio
fc0a61b6e031a7a39594d5316fff2988b876f779
link
true
/test integ-pilot-istiodremote

integ-basic-arm64_istio
fc0a61b6e031a7a39594d5316fff2988b876f779
link
true
/test integ-basic-arm64

integ-operator-controller_istio
fc0a61b6e031a7a39594d5316fff2988b876f779
link
true
/test integ-operator-controller

integ-ds_istio
fc0a61b6e031a7a39594d5316fff2988b876f779
link
true
/test integ-ds

integ-helm_istio
fc0a61b6e031a7a39594d5316fff2988b876f779
link
true
/test integ-helm

integ-pilot-multicluster_istio
fc0a61b6e031a7a39594d5316fff2988b876f779
link
true
/test integ-pilot-multicluster

integ-ipv6_istio
fc0a61b6e031a7a39594d5316fff2988b876f779
link
true
/test integ-ipv6

integ-distroless_istio
fc0a61b6e031a7a39594d5316fff2988b876f779
link
true
/test integ-distroless

integ-pilot-istiodremote-mc_istio
fc0a61b6e031a7a39594d5316fff2988b876f779
link
true
/test integ-pilot-istiodremote-mc

integ-cni_istio
fc0a61b6e031a7a39594d5316fff2988b876f779
link
true
/test integ-cni

integ-pilot_istio
fc0a61b6e031a7a39594d5316fff2988b876f779
link
true
/test integ-pilot

integ-telemetry-istiodremote_istio
fc0a61b6e031a7a39594d5316fff2988b876f779
link
true
/test integ-telemetry-istiodremote

integ-telemetry-mc_istio
fc0a61b6e031a7a39594d5316fff2988b876f779
link
true
/test integ-telemetry-mc

integ-telemetry-discovery_istio
fc0a61b6e031a7a39594d5316fff2988b876f779
link
true
/test integ-telemetry-discovery

integ-telemetry_istio
fc0a61b6e031a7a39594d5316fff2988b876f779
link
true
/test integ-telemetry

integ-security-istiodremote_istio
fc0a61b6e031a7a39594d5316fff2988b876f779
link
true
/test integ-security-istiodremote

integ-security_istio
fc0a61b6e031a7a39594d5316fff2988b876f779
link
true
/test integ-security

integ-security-multicluster_istio
fc0a61b6e031a7a39594d5316fff2988b876f779
link
true
/test integ-security-multicluster

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

If actually running the test app as the application user doesn't work, then that means @howardjohn was correct and the runAs was a no-op - we don't actually use that created user for any tests.

@howardjohn @bleggett  Adding USER to the Dockerfile works as before. This is good, right?
@linsun Where specifically do you expect such documentation? These are test files, only used in integration tests.

@howardjohn @bleggett Adding USER to the Dockerfile works as before. This is good, right?

Yep! My bad, I saw the previous failure and didn't realize it was because some of the changes were missing in that push.

@howardjohn @bleggett Adding USER to the Dockerfile works as before. This is good, right?

Yep! My bad, I saw the previous test failure and didn't realize it was because some of the changes were missing in that particular push, ignore that comment.

Yeah, those failures were related to USER application. It works with USER 1338 though.

@jwendell: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-ambient_istio
7947293031c4dd845220964b7ccb8f0f77db1336
link
unknown
/test integ-ambient

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jwendell: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-ambient_istio
7947293031c4dd845220964b7ccb8f0f77db1336
link
unknown
/test integ-ambient

integ-security-multicluster_istio
7947293031c4dd845220964b7ccb8f0f77db1336
link
unknown
/test integ-security-multicluster

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@howardjohn @bleggett Adding USER to the Dockerfile works as before. This is good, right?
@linsun Where specifically do you expect such documentation? These are test files, only used in integration tests.

Sorry for not replying this earlier, i think you documented well in #47898

In response to a cherrypick label: new pull request created: #47966

authors: bleggett howardjohn istio-testing jwendell linsun


text:
Use go 1.22

Please provide a description of this PR:
Go 1.22 includes changes to the language (see https://tip.golang.org/doc/go1.22#language). It's possible that some unit tests may break or bugs appear. Let's start testing this early before 1.22.

We can hold off for now. Still need to fix any linting issues. Let's see if anything breaks. I don't intend to change api as that may break other users.

Should we wait until quic-go has support for 1.22?

Do you think now would be a good time to get this merged?

@jacob-delgado: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-ds_istio
0b453047d77605a815e9c93083dc9289a3112864
link
unknown
/test integ-ds

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test integ-ds

authors: ericvn istio-testing jacob-delgado keithmattix


text:
Ambient: support DNS backends with waypoint

Today these are EDS clusters with 0 endpoints.
Added a test that excercises the full flow

@howardjohn: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-ambient_istio
cd23f770c12153cddef41b58ace47c5171ddaf79
link
true
/test integ-ambient

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

authors: howardjohn istio-testing


text:
Cleanup circle zombies

Also moved some jobs around, to reduce load - nightly doesn't need to re-run everything that periodic does, some jobs were disabled long ago but left around.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: rshriram
Assign the PR to them by writing /assign @rshriram in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

.circleci/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: costinm
Assign the PR to them by writing /assign @costinm in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

.circleci/OWNERS
tests/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@costinm: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
aadba15a7416cac29cef2e7aed17da11cab6cf84
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
aadba15a7416cac29cef2e7aed17da11cab6cf84
link
/test istio-pilot-e2e

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
15277adb6fc4748c96b8c82e648c64c4e4cca563
link
/test istio-pilot-e2e-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
15277adb6fc4748c96b8c82e648c64c4e4cca563
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-pilot-e2e.sh
15277adb6fc4748c96b8c82e648c64c4e4cca563
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
15277adb6fc4748c96b8c82e648c64c4e4cca563
link
/test istio-pilot-e2e

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
942d758daf1cf739b9dd41b3220ebe2976178084
link
/test istio-pilot-e2e-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
942d758daf1cf739b9dd41b3220ebe2976178084
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-pilot-e2e.sh
942d758daf1cf739b9dd41b3220ebe2976178084
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
942d758daf1cf739b9dd41b3220ebe2976178084
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-pilot-e2e.sh
942d758daf1cf739b9dd41b3220ebe2976178084
link
/test istio-pilot-e2e

prow/e2e-bookInfoTests-v1alpha3.sh
942d758daf1cf739b9dd41b3220ebe2976178084
link
/test e2e-bookInfo-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: costinm
Assign the PR to them by writing /assign @costinm in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

.circleci/OWNERS
pilot/OWNERS
tests/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
942d758daf1cf739b9dd41b3220ebe2976178084
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-pilot-e2e.sh
942d758daf1cf739b9dd41b3220ebe2976178084
link
/test istio-pilot-e2e

prow/e2e-bookInfoTests-v1alpha3.sh
942d758daf1cf739b9dd41b3220ebe2976178084
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/istio-unit-tests.sh
967143a7a798f35a2e5cf3da9dea91bfb580e537
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
942d758daf1cf739b9dd41b3220ebe2976178084
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-pilot-e2e.sh
942d758daf1cf739b9dd41b3220ebe2976178084
link
/test istio-pilot-e2e

prow/e2e-bookInfoTests-v1alpha3.sh
942d758daf1cf739b9dd41b3220ebe2976178084
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/istio-unit-tests.sh
967143a7a798f35a2e5cf3da9dea91bfb580e537
link
/test istio-unit-tests

prow/istio-presubmit.sh
967143a7a798f35a2e5cf3da9dea91bfb580e537
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: costinm
Assign the PR to them by writing /assign @costinm in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

.circleci/OWNERS
tests/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
942d758daf1cf739b9dd41b3220ebe2976178084
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-pilot-e2e.sh
942d758daf1cf739b9dd41b3220ebe2976178084
link
/test istio-pilot-e2e

prow/e2e-bookInfoTests-v1alpha3.sh
942d758daf1cf739b9dd41b3220ebe2976178084
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/istio-presubmit.sh
967143a7a798f35a2e5cf3da9dea91bfb580e537
link
/test istio-presubmit

prow/istio-unit-tests.sh
82ba6f4bae5d4b9f5b700997be6d82d10716cff7
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
942d758daf1cf739b9dd41b3220ebe2976178084
link
/test istio-pilot-e2e

prow/e2e-bookInfoTests-v1alpha3.sh
942d758daf1cf739b9dd41b3220ebe2976178084
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/istio-unit-tests.sh
82ba6f4bae5d4b9f5b700997be6d82d10716cff7
link
/test istio-unit-tests

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
82ba6f4bae5d4b9f5b700997be6d82d10716cff7
link
/test istio-pilot-e2e-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
942d758daf1cf739b9dd41b3220ebe2976178084
link
/test istio-pilot-e2e

prow/istio-unit-tests.sh
82ba6f4bae5d4b9f5b700997be6d82d10716cff7
link
/test istio-unit-tests

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
82ba6f4bae5d4b9f5b700997be6d82d10716cff7
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-bookInfoTests-v1alpha3.sh
82ba6f4bae5d4b9f5b700997be6d82d10716cff7
link
/test e2e-bookInfo-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
82ba6f4bae5d4b9f5b700997be6d82d10716cff7
link
/test istio-unit-tests

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
82ba6f4bae5d4b9f5b700997be6d82d10716cff7
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-bookInfoTests-v1alpha3.sh
82ba6f4bae5d4b9f5b700997be6d82d10716cff7
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/istio-pilot-e2e.sh
82ba6f4bae5d4b9f5b700997be6d82d10716cff7
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
82ba6f4bae5d4b9f5b700997be6d82d10716cff7
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-bookInfoTests-v1alpha3.sh
82ba6f4bae5d4b9f5b700997be6d82d10716cff7
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/istio-pilot-e2e.sh
82ba6f4bae5d4b9f5b700997be6d82d10716cff7
link
/test istio-pilot-e2e

prow/istio-unit-tests.sh
bf6eb33e5b2f29233f305109cc0b81dd35e16370
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
82ba6f4bae5d4b9f5b700997be6d82d10716cff7
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-bookInfoTests-v1alpha3.sh
82ba6f4bae5d4b9f5b700997be6d82d10716cff7
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/istio-pilot-e2e.sh
82ba6f4bae5d4b9f5b700997be6d82d10716cff7
link
/test istio-pilot-e2e

prow/istio-unit-tests.sh
bf6eb33e5b2f29233f305109cc0b81dd35e16370
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test istio-unit-tests

/retest

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
82ba6f4bae5d4b9f5b700997be6d82d10716cff7
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-bookInfoTests-v1alpha3.sh
82ba6f4bae5d4b9f5b700997be6d82d10716cff7
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/istio-pilot-e2e.sh
82ba6f4bae5d4b9f5b700997be6d82d10716cff7
link
/test istio-pilot-e2e

prow/istio-unit-tests.sh
bf6eb33e5b2f29233f305109cc0b81dd35e16370
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-v1alpha3.sh
82ba6f4bae5d4b9f5b700997be6d82d10716cff7
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/istio-pilot-e2e.sh
82ba6f4bae5d4b9f5b700997be6d82d10716cff7
link
/test istio-pilot-e2e

prow/istio-unit-tests.sh
bf6eb33e5b2f29233f305109cc0b81dd35e16370
link
/test istio-unit-tests

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
bf6eb33e5b2f29233f305109cc0b81dd35e16370
link
/test istio-pilot-e2e-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-v1alpha3.sh
82ba6f4bae5d4b9f5b700997be6d82d10716cff7
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/istio-pilot-e2e.sh
82ba6f4bae5d4b9f5b700997be6d82d10716cff7
link
/test istio-pilot-e2e

prow/istio-unit-tests.sh
bf6eb33e5b2f29233f305109cc0b81dd35e16370
link
/test istio-unit-tests

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
bf6eb33e5b2f29233f305109cc0b81dd35e16370
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-bookInfoTests.sh
bf6eb33e5b2f29233f305109cc0b81dd35e16370
link
/test e2e-bookInfo

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
82ba6f4bae5d4b9f5b700997be6d82d10716cff7
link
/test istio-pilot-e2e

prow/istio-unit-tests.sh
bf6eb33e5b2f29233f305109cc0b81dd35e16370
link
/test istio-unit-tests

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
bf6eb33e5b2f29233f305109cc0b81dd35e16370
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-bookInfoTests.sh
bf6eb33e5b2f29233f305109cc0b81dd35e16370
link
/test e2e-bookInfo

prow/e2e-bookInfoTests-v1alpha3.sh
bf6eb33e5b2f29233f305109cc0b81dd35e16370
link
/test e2e-bookInfo-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
bf6eb33e5b2f29233f305109cc0b81dd35e16370
link
/test istio-unit-tests

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
bf6eb33e5b2f29233f305109cc0b81dd35e16370
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-bookInfoTests.sh
bf6eb33e5b2f29233f305109cc0b81dd35e16370
link
/test e2e-bookInfo

prow/e2e-bookInfoTests-v1alpha3.sh
bf6eb33e5b2f29233f305109cc0b81dd35e16370
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/istio-pilot-e2e.sh
bf6eb33e5b2f29233f305109cc0b81dd35e16370
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
bf6eb33e5b2f29233f305109cc0b81dd35e16370
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-bookInfoTests.sh
bf6eb33e5b2f29233f305109cc0b81dd35e16370
link
/test e2e-bookInfo

prow/e2e-bookInfoTests-v1alpha3.sh
bf6eb33e5b2f29233f305109cc0b81dd35e16370
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/istio-pilot-e2e.sh
bf6eb33e5b2f29233f305109cc0b81dd35e16370
link
/test istio-pilot-e2e

prow/istio-unit-tests.sh
bf6eb33e5b2f29233f305109cc0b81dd35e16370
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
bf6eb33e5b2f29233f305109cc0b81dd35e16370
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-bookInfoTests.sh
bf6eb33e5b2f29233f305109cc0b81dd35e16370
link
/test e2e-bookInfo

prow/e2e-bookInfoTests-v1alpha3.sh
bf6eb33e5b2f29233f305109cc0b81dd35e16370
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/istio-pilot-e2e.sh
bf6eb33e5b2f29233f305109cc0b81dd35e16370
link
/test istio-pilot-e2e

prow/istio-unit-tests.sh
bf6eb33e5b2f29233f305109cc0b81dd35e16370
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests.sh
bf6eb33e5b2f29233f305109cc0b81dd35e16370
link
/test e2e-bookInfo

prow/e2e-bookInfoTests-v1alpha3.sh
bf6eb33e5b2f29233f305109cc0b81dd35e16370
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/istio-pilot-e2e.sh
bf6eb33e5b2f29233f305109cc0b81dd35e16370
link
/test istio-pilot-e2e

prow/istio-unit-tests.sh
bf6eb33e5b2f29233f305109cc0b81dd35e16370
link
/test istio-unit-tests

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
bf6eb33e5b2f29233f305109cc0b81dd35e16370
link
/test istio-pilot-e2e-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests.sh
bf6eb33e5b2f29233f305109cc0b81dd35e16370
link
/test e2e-bookInfo

prow/istio-pilot-e2e.sh
bf6eb33e5b2f29233f305109cc0b81dd35e16370
link
/test istio-pilot-e2e

prow/istio-unit-tests.sh
bf6eb33e5b2f29233f305109cc0b81dd35e16370
link
/test istio-unit-tests

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
bf6eb33e5b2f29233f305109cc0b81dd35e16370
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-bookInfoTests-v1alpha3.sh
bf6eb33e5b2f29233f305109cc0b81dd35e16370
link
/test e2e-bookInfo-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests.sh
bf6eb33e5b2f29233f305109cc0b81dd35e16370
link
/test e2e-bookInfo

prow/istio-unit-tests.sh
bf6eb33e5b2f29233f305109cc0b81dd35e16370
link
/test istio-unit-tests

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
bf6eb33e5b2f29233f305109cc0b81dd35e16370
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-bookInfoTests-v1alpha3.sh
bf6eb33e5b2f29233f305109cc0b81dd35e16370
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/istio-pilot-e2e.sh
bf6eb33e5b2f29233f305109cc0b81dd35e16370
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
bf6eb33e5b2f29233f305109cc0b81dd35e16370
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-bookInfoTests-v1alpha3.sh
bf6eb33e5b2f29233f305109cc0b81dd35e16370
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/istio-pilot-e2e.sh
bf6eb33e5b2f29233f305109cc0b81dd35e16370
link
/test istio-pilot-e2e

prow/istio-unit-tests.sh
bf6eb33e5b2f29233f305109cc0b81dd35e16370
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-v1alpha3.sh
bf6eb33e5b2f29233f305109cc0b81dd35e16370
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/istio-pilot-e2e.sh
bf6eb33e5b2f29233f305109cc0b81dd35e16370
link
/test istio-pilot-e2e

prow/istio-unit-tests.sh
bf6eb33e5b2f29233f305109cc0b81dd35e16370
link
/test istio-unit-tests

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
bf6eb33e5b2f29233f305109cc0b81dd35e16370
link
/test istio-pilot-e2e-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
bf6eb33e5b2f29233f305109cc0b81dd35e16370
link
/test istio-pilot-e2e

prow/istio-unit-tests.sh
bf6eb33e5b2f29233f305109cc0b81dd35e16370
link
/test istio-unit-tests

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
bf6eb33e5b2f29233f305109cc0b81dd35e16370
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-bookInfoTests-v1alpha3.sh
bf6eb33e5b2f29233f305109cc0b81dd35e16370
link
/test e2e-bookInfo-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
bf6eb33e5b2f29233f305109cc0b81dd35e16370
link
/test istio-pilot-e2e

prow/istio-unit-tests.sh
bf6eb33e5b2f29233f305109cc0b81dd35e16370
link
/test istio-unit-tests

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
bf6eb33e5b2f29233f305109cc0b81dd35e16370
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-bookInfoTests-v1alpha3.sh
bf6eb33e5b2f29233f305109cc0b81dd35e16370
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/e2e-bookInfoTests.sh
bf6eb33e5b2f29233f305109cc0b81dd35e16370
link
/test e2e-bookInfo

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
bf6eb33e5b2f29233f305109cc0b81dd35e16370
link
/test istio-unit-tests

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
bf6eb33e5b2f29233f305109cc0b81dd35e16370
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-bookInfoTests-v1alpha3.sh
bf6eb33e5b2f29233f305109cc0b81dd35e16370
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/e2e-bookInfoTests.sh
bf6eb33e5b2f29233f305109cc0b81dd35e16370
link
/test e2e-bookInfo

prow/istio-pilot-e2e.sh
bf6eb33e5b2f29233f305109cc0b81dd35e16370
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

authors: costinm istio-testing


text:
Generate LICENSES, make --branch required

Couple of items in this PR:

make --branch mandatory so that LICENSES URLs point to license text on correct branch.
initial output of LICENSES for 1.0 release

License notes:

github.com/signalfx/com_signalfx_metrics_protobuf is only used in testing. In general we need some automated mechanism to ignore anything that doesn't end up in a binary (https://github.com/istio/istio/issues/7288).
siphash is used in open-policy-agent/opa. The version we have in 1.0 uses 0.7.1 which still points to the old siphash which doesn't have a license. The new one is 0.8.2 which does have a license (https://github.com/istio/istio/issues/7287)
github.com/BurntSushi/toml has WTFPL but this is only used in helm and is transitively included through k8s.

Proposal: will delete 1 & 3 manually and fix 2 to get the right version.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: ostromart
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: myidpt
If they are not already assigned, you can assign the PR to them by writing /assign @myidpt in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ostromart: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
afe88ccb6f51a16261d305b3e153d403827eb709
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Do we need to include this file? its 5.3MB!

@ostromart: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
afe88ccb6f51a16261d305b3e153d403827eb709
link
/test istio-unit-tests

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
afe88ccb6f51a16261d305b3e153d403827eb709
link
/test istio-pilot-e2e-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

I think we should generate it during the release and not commit it in our repo. Its huge and unnecessary. Out of curiosity, are there any GPL style licenses in there?

@rshriram I think we are ok with the file size. It has huge redundancy so it zips to ~97k. git will compress it automatically per https://gist.github.com/matthewmccullough/2695758.

authors: istio-testing ostromart rshriram


text:
update istio api

update istio api, this has minimum changes to Gopkg.lock file, probably because of older dep

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: rkpagadala
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: myidpt
If they are not already assigned, you can assign the PR to them by writing /assign @myidpt in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Flaky test. Merging.

authors: costinm istio-testing rkpagadala


text:
Let "pilot_grpc_address" take over param DiscoveryAddress in WriteBootstrap

It is kind of ugly to hard code the pilot ports here,
and since the generated opts "pilot_address" is not used any more, I think it reasonable to Let "pilot_grpc_address" reuse the DiscoveryAddress param.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers: ijsnellf, nmittler
If they are not already assigned, you can assign the PR to them by writing /assign @ijsnellf @nmittler in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

install/OWNERS
pkg/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Hi @lichuqiang. Thanks for your PR.
I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

/ok-to-test

@lichuqiang: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
b8b362e52f768072e3970bcb37532035a18c4a5c
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@lichuqiang: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
b8b362e52f768072e3970bcb37532035a18c4a5c
link
/test istio-unit-tests

prow/e2e-simpleTests.sh
b8b362e52f768072e3970bcb37532035a18c4a5c
link
/test e2e-simple

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@lichuqiang: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
b8b362e52f768072e3970bcb37532035a18c4a5c
link
/test istio-unit-tests

prow/e2e-simpleTests.sh
b8b362e52f768072e3970bcb37532035a18c4a5c
link
/test e2e-simple

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
b8b362e52f768072e3970bcb37532035a18c4a5c
link
/test istio-pilot-e2e-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: costinm
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

install/OWNERS [costinm]
pkg/OWNERS [costinm]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/retest

@lichuqiang: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests.sh
b8b362e52f768072e3970bcb37532035a18c4a5c
link
/test e2e-simple

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
b8b362e52f768072e3970bcb37532035a18c4a5c
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-unit-tests.sh
b8b362e52f768072e3970bcb37532035a18c4a5c
link
/test istio-unit-tests

prow/e2e-bookInfoTests-v1alpha3.sh
b8b362e52f768072e3970bcb37532035a18c4a5c
link
/test e2e-bookInfo-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@lichuqiang: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
b8b362e52f768072e3970bcb37532035a18c4a5c
link
/test istio-unit-tests

prow/e2e-bookInfoTests-v1alpha3.sh
b8b362e52f768072e3970bcb37532035a18c4a5c
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/istio-pilot-multicluster-e2e.sh
b8b362e52f768072e3970bcb37532035a18c4a5c
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test e2e-bookInfo-envoyv2-v1alpha3

Seems some of the circleci tasks are flaky.
@costinm Do you know how to trigger them again? Seems command "/retest" won't take effect on the circleci ones.

New changes are detected. LGTM label has been removed.

@costinm  I rebased it with newest code.
Can you give it a lgtm?

/retest

@lichuqiang: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
2735658b5d6b5052e2d220939c6d83cf5a1bdde0
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

re tag
/lgtm

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: costinm, hzxuzhonghu
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

install/OWNERS [costinm]
pkg/OWNERS [costinm]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

authors: hzxuzhonghu istio-testing lichuqiang rshriram


text:
Update mock redis to improve test coverage.

Added a time machine in mock redis (have a PR under review).  The unit test now can cover expiring keys.
Keep working on improve code coverage now...

This change is

Jenkins job mixer/presubmit passed

Jenkins job mixer/e2e-smoketest passed

Jenkins job mixer/e2e-smoketest passed

Jenkins job mixer/manager-regression passed

Jenkins job mixer/manager-regression passed

Jenkins job mixer/presubmit passed

Jenkins job mixer/presubmit passed

Jenkins job mixer/e2e-smoketest passed

Jenkins job mixer/manager-regression passed

Jenkins job mixer/e2e-smoketest passed

Jenkins job mixer/manager-regression passed

repo: istio/mixer


text:
Increase model coverage

What this PR does / why we need it:
Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #
Special notes for your reviewer:
Release note:

contributes to #1233

repo: istio/pilot


text:
Cannot build app Xcode 15.0 / 15.1

Hello everyone
After following Get Started i coudunt get app compiled. Xcode giving me this error :
Error (Xcode): Cycle inside Runner; building could produce unreliable results.
Cycle details:
→ Target 'Runner': CodeSign /Users/radoslavkucinsky/Developer/dynamic_island/build/ios/Debug-iphonesimulator/Runner.app
○ That command depends on command in Target 'Runner': script phase “[CP] Embed Pods Frameworks”
○ Target 'Runner' has copy command from '/Users/radoslavkucinsky/Developer/dynamic_island/build/ios/Debug-iphonesimulator/widget-extensionExtension.appex' to '/Users/radoslavkucinsky/Developer/dynamic_island/build/ios/Debug-iphonesimulator/Runner.app/PlugIns/widget-extensionExtension.appex'
○ That command depends on command in Target 'Runner': script phase “Thin Binary”
○ Target 'Runner' has process command with output '/Users/radoslavkucinsky/Developer/dynamic_island/build/ios/Debug-iphonesimulator/Runner.app/Info.plist'
○ Target 'Runner' has copy command from '/Users/radoslavkucinsky/Developer/dynamic_island/build/ios/Debug-iphonesimulator/widget-extensionExtension.appex' to '/Users/radoslavkucinsky/Developer/dynamic_island/build/ios/Debug-iphonesimulator/Runner.app/PlugIns/widget-extensionExtension.appex'

Raw dependency cycle trace:

target:  ->

node: <all> ->

command: <all> ->

node: /Users/radoslavkucinsky/Developer/dynamic_island/build/ios/Debug-iphonesimulator/Runner.app/_CodeSignature ->

command: P0:target-Runner-18c1723432283e0cc55f10a6dcfd9e0288a783a885d8b0b3beb2e9f90bde3f49-:Debug:CodeSign /Users/radoslavkucinsky/Developer/dynamic_island/build/ios/Debug-iphonesimulator/Runner.app ->

node: /Users/radoslavkucinsky/Developer/dynamic_island/build/ios/Debug-iphonesimulator/Runner.app/Frameworks/Mantle.framework/ ->

directoryTreeSignature: w ->

directoryContents: /Users/radoslavkucinsky/Developer/dynamic_island/build/ios/Debug-iphonesimulator/Runner.app/Frameworks/Mantle.framework ->

node: /Users/radoslavkucinsky/Developer/dynamic_island/build/ios/Debug-iphonesimulator/Runner.app/Frameworks/Mantle.framework ->

command: P2:target-Runner-18c1723432283e0cc55f10a6dcfd9e0288a783a885d8b0b3beb2e9f90bde3f49-:Debug:PhaseScriptExecution [CP] Embed Pods Frameworks /Users/radoslavkucinsky/Library/Developer/Xcode/DerivedData/Runner-bmgdisgplxmgkqetgapmzblppccw/Build/Intermediates.noindex/Runner.build/Debug-iphonesimulator/Runner.build/Script-BC3E10562D9D84620574C484.sh ->

node: /Users/radoslavkucinsky/Library/Developer/Xcode/DerivedData/Runner-bmgdisgplxmgkqetgapmzblppccw/Build/Intermediates.noindex/Runner.build/Debug-iphonesimulator/Runner.build/InputFileList-BC3E10562D9D84620574C484-Pods-Runner-frameworks-Debug-input-files-80d8f83f4640d9ead2253dc2de61282a-resolved.xcfilelist ->

command: P2:target-Runner-18c1723432283e0cc55f10a6dcfd9e0288a783a885d8b0b3beb2e9f90bde3f49-:Debug:WriteAuxiliaryFile /Users/radoslavkucinsky/Library/Developer/Xcode/DerivedData/Runner-bmgdisgplxmgkqetgapmzblppccw/Build/Intermediates.noindex/Runner.build/Debug-iphonesimulator/Runner.build/InputFileList-BC3E10562D9D84620574C484-Pods-Runner-frameworks-Debug-input-files-80d8f83f4640d9ead2253dc2de61282a-resolved.xcfilelist ->

node: <target-Runner-18c1723432283e0cc55f10a6dcfd9e0288a783a885d8b0b3beb2e9f90bde3f49--fused-phase5-copy-files> ->

command: P0:::Gate target-Runner-18c1723432283e0cc55f10a6dcfd9e0288a783a885d8b0b3beb2e9f90bde3f49--fused-phase5-copy-files ->

node: <Copy /Users/radoslavkucinsky/Developer/dynamic_island/build/ios/Debug-iphonesimulator/Runner.app/PlugIns/widget-extensionExtension.appex> ->

CYCLE POINT ->

command: P0:target-Runner-18c1723432283e0cc55f10a6dcfd9e0288a783a885d8b0b3beb2e9f90bde3f49-:Debug:Copy /Users/radoslavkucinsky/Developer/dynamic_island/build/ios/Debug-iphonesimulator/Runner.app/PlugIns/widget-extensionExtension.appex /Users/radoslavkucinsky/Developer/dynamic_island/build/ios/Debug-iphonesimulator/widget-extensionExtension.appex ->

node: <target-Runner-18c1723432283e0cc55f10a6dcfd9e0288a783a885d8b0b3beb2e9f90bde3f49--fused-phase4-thin-binary> ->

command: P0:::Gate target-Runner-18c1723432283e0cc55f10a6dcfd9e0288a783a885d8b0b3beb2e9f90bde3f49--fused-phase4-thin-binary ->

node: <execute-shell-script-18c1723432283e0cc55f10a6dcfd9e02f1eee2015e8ff5ebcd27678f788c2826-target-Runner-18c1723432283e0cc55f10a6dcfd9e0288a783a885d8b0b3beb2e9f90bde3f49-> ->

command: P2:target-Runner-18c1723432283e0cc55f10a6dcfd9e0288a783a885d8b0b3beb2e9f90bde3f49-:Debug:PhaseScriptExecution Thin Binary /Users/radoslavkucinsky/Library/Developer/Xcode/DerivedData/Runner-bmgdisgplxmgkqetgapmzblppccw/Build/Intermediates.noindex/Runner.build/Debug-iphonesimulator/Runner.build/Script-3B06AD1E1E4923F5004D2608.sh ->

node: /Users/radoslavkucinsky/Developer/dynamic_island/build/ios/Debug-iphonesimulator/Runner.app/Info.plist/ ->

directoryTreeSignature: f ->

directoryContents: /Users/radoslavkucinsky/Developer/dynamic_island/build/ios/Debug-iphonesimulator/Runner.app/Info.plist ->

node: /Users/radoslavkucinsky/Developer/dynamic_island/build/ios/Debug-iphonesimulator/Runner.app/Info.plist ->

command: P0:target-Runner-18c1723432283e0cc55f10a6dcfd9e0288a783a885d8b0b3beb2e9f90bde3f49-:Debug:ProcessInfoPlistFile /Users/radoslavkucinsky/Developer/dynamic_island/build/ios/Debug-iphonesimulator/Runner.app/Info.plist /Users/radoslavkucinsky/Developer/dynamic_island/ios/Runner/Info.plist ->

node: /Users/radoslavkucinsky/Developer/dynamic_island/build/ios/Debug-iphonesimulator/Runner.app/PlugIns/widget-extensionExtension.appex ->

command: P0:target-Runner-18c1723432283e0cc55f10a6dcfd9e0288a783a885d8b0b3beb2e9f90bde3f49-:Debug:Copy /Users/radoslavkucinsky/Developer/dynamic_island/build/ios/Debug-iphonesimulator/Runner.app/PlugIns/widget-extensionExtension.appex /Users/radoslavkucinsky/Developer/dynamic_island/build/ios/Debug-iphonesimulator/widget-extensionExtension.appex

This is output of Flutter Doctor
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel stable, 3.13.3, on macOS 14.0 23A344 darwin-arm64, locale
    en-GB)
[✓] Android toolchain - develop for Android devices (Android SDK version
    34.0.0-rc2)
[✓] Xcode - develop for iOS and macOS (Xcode 15.0.1)
[✓] Chrome - develop for the web
[✓] Android Studio (version 2022.1)
[✓] VS Code (version 1.84.1)

Thank you for help.

@Rakura-cloud the link no longer works. How did you resolve this?

What's the solution to this?

What's the solution to this?

Goto Build Phase, rearranging the order of Embed Foundation Extensions to be right after Copy Bundle Resources.

source: gharchive/issue

authors: Rakura-cloud agelogeo fabiototh slowlow79464

license: MIT


text:
Feature/txpool junhui

txpool 작업 브랜치입니다.
현재 txpool_api를 작업중에 있습니다.
timeTicker가 생성되면 그 때부터 타이머가 바로 시작되어서 timeoutTicker라는 모델을 새로 만들었는데, timeTicker에 대해 더 알아본 후 필요없다면 삭제할 수도 있을 것 같습니다.
현재 남은 일은

txpool/api 완성
infra/messaging/rabbitmq Impliment

입니다.
config, messaging 부분 pull을 위해 현재 작업 사항 pull request 날립니다 ㅎㅎ

리뷰어 등록하는 칸이 안떠서 등록 못했습니다ㅜㅜ

@hihiboss
개인적으로 궁금해서 질문남깁니다!
혹시 timeTicker가 하는 역할이 tx를 모으는 시간 timeout을 해주는 것인가요?

@zeroFruit
네 그렇습니다!
txpool은 두 가지 조건 중 하나라도 만족하면 leader에게 transaction을 보내도록 합니다.

timeout일 때
모인 tx 사이즈가 max byte 사이즈를 넘어갈 때

입니다.
이 timeout을 체크하기 위해 timeTicker를 사용합니다!

txpool_event 의 TransactionCreateEvent 구조를 변경하였는데 이렇게 바꿔도 될지 확인 부탁드립니다!
더불어,  client의 요청으로 받은 txData를 transaction으로 만들어 저장하기 위해 SaveTxData 함수를 따로 구현하였는데 적절한지 검토 부탁드립니다!

좋은것 같습니다. 테스트 case 함수를 추가하고 일단은 머지하면 될 것 같습니다.

authors: hihiboss junbeomlee zeroFruit

repo: it-chain/it-chain-Engine


text:
Create tests for videolink logic from EditProfile.tsx

Create some tests in different situations for videolink logic in EditProfile.tsx.

Link the issue:

repo: ita-social-projects/SpaceToStudy-Client


text:
change svg files

dev
JIRA

Main JIRA ticket

Code reviewers

[ ] @github_username

Second Level Review

[ ] @github_username

Summary of issue
ToDo
Summary of change
ToDo
Testing approach
ToDo
CHECK LIST

[ ]  СI passed
[ ]  Сode coverage >=95%
[ ]  PR is reviewed manually again (to make sure you have 100% ready code)
[ ]  All reviewers agreed to merge the PR
[ ]  I've checked new feature as logged in and logged out user if needed
[ ]  PR meets all conventions

repo: ita-social-projects/what-front


text:
Mancato recapito tessere sanitarie in comune fuso subentrato in ANPR

Il comune di Valsamoggia è nato l’1/01/2014 per fusione dei comuni di Bazzano, Castello di Serravalle, Crespellano, Monteveglio e Savigno.
La denominazione degli ex comuni è stata mantenuta come frazione, anche per gestire il problema delle aree di circolazione aventi la stessa denominazione, considerato che Poste Italiane non ha concesso il mantenimento dei vecchi codici di avviamento postale; quindi il cap 40053, che era quello di Bazzano, è andato a costituire il cap di tutto il comune di Valsamoggia (40056 di Crespellano, 40050 di Castello di Serravalle – Monteveglio e 40060 Savigno sono stati soppressi).
Nei primi mesi del 2014 abbiamo fatto un’operazione massiva di allineamento dei codici fiscali dei residenti e l’Agenzia delle Entrate aveva regolarmente recepito l’indicazione della frazione.
Succede poi che il 10/07/2018 il comune di Valsamoggia subentra in ANPR e, nonostante i tecnici della nostra software house (Maggioli) abbiano verificato che il dato riferito alla frazione fosse stato regolarmente trattato, la sua indicazione è sparita dal dato relativo al domicilio fiscale dell'Agenzia delle Entrate.
Ci stiamo rendendo conto, in seguito a numerosissime segnalazioni dei cittadini, che questo ha un impatto fortissimo sulle operazioni di recapito della tessera sanitaria.
Infatti, con la collega che si occupa della gestione delle anagrafiche della nostra Asl di riferimento, abbiamo simulato una richiesta di duplicato ed il risultato del nostro esempio è il seguente:

persona residente al seguente indirizzo anpr
Via Borghetto 6 CRESPELLANO
40053 VALSAMOGGIA BO
la visura del domicilio fiscale di Punto Fisco  è
Via Borghetto 6
40053 VALSAMOGGIA BO
l’indirizzo di recapito della nuova tessera sanitaria viene generato nel seguente modo
BAZZANO VIA BORGHETTO BAZZANO 6
40053 VALSAMOGGIA BO
Quindi sembrerebbe che il sistema di invio delle tessere sanitarie associ automaticamente la frazione Bazzano al cap 40053.
Inizialmente abbiamo pensato che il problema si presentasse solamente per i residenti in via la cui denominazione compariva in più di una frazione, ma ora ci stiamo rendendo conto che è generalizzato: Via Borghetto, per intenderci, esiste solo a Crespellano, ma la tessera sanitaria non è stata comunque recapitata.
Vorrei quindi capire se esiste la possibilità di risolvere il problema in forma massiva, considerato il fatto che ormai stiamo ricevendo più segnalazioni al giorno.

E' previsto un intervento sui sistemi di Agenzia Entrate per allineare i dati relativi alla residenza ad ANPR (#1944 )

authors: iolandacavallin rvinzani

repo: italia/anpr


text:
Richiesta sullo stato di salute del progetto

Ciao,
Vorrei chiedere aggiornamenti sulla Roadmap di questo progetto per risoluzione delle issues e delle Pull Request.
Abbiamo ricevuto alcune segnalazioni da parte degli sviluppatori che ci indicano che questo repository conterrebbe risorse
non allineate con lo stato attuale delle Specifiche SPID.
Spero di ottenere un tuo gentile feedback entro la prossima settimana,
Grazie e a presto

Il progetto importante è https://github.com/italia/spid-sp-shibboleth, mentre questo progetto dovrebbe esclusivamente usare il primo per integrarlo in ruoli ansible.
Mantengo questo repo as-is fino a quando non avremo un avanzamento concreto di spid-sp-shibboleth

repo: italia/spid-ansible-shibboleth-example


text:
Messaggi di errore non conformi alle indicazioni di AgID

Describe the bug
settimana scorsa ho iniziato il processo di accreditamento a SPID come fornitore di servizi e ho ricevuto come risposta un report dove mi vengono segnalate diverse anomalie relative ai messaggi di errore restituiti dal mio applicativo.
Siccome sfrutto le eccezioni generate dalla libreria in questione e i relativi messaggi credo che esista un problema di allineamento tra le risorse messe a disposizione dalla libreria e quanto richiesto da AgID.
Expected behavior
Vorrei fare un PR per correggere i messaggi di errore e cogliere l'occasione per produrre un eccezione ad hoc per queste verifiche di modo che chiunque possa capire il codice del test a cui è legata la segnalazione ed eventualmente customizzare i propri messaggi di errore.

Salve,
su quali messaggi hai riscontrato un disallineamento?

Loro mi hanno segnalato il test 104 e 111 oltre ad altri test dove si attendono un messaggio di errore generico (su cui non ho idea se sia necessario un formato specifico) mentre la libreria ritorna un messaggio di errore relativo all'anomalia riscontrata (tipo per il test 2 vogliono un messaggio di errore generico mentre la libreria ritorna Signature Response non trovata).
Per esempio sull'errore 104 (Anomalia 19) la libreria ritorna:
Autenticazione fallita per ripetuta sottomissione di credenziali errate (superato numero tentativi secondo le policy adottate)
Mentre AgID mi segnala:
Autenticazione fallita per ripetuta sottomissione di credenziali errate.

La modifica eventualmente richiederebbe un rilascio Major, dal momento che consiste in una modifica non retrocompatibile dei contracts (nel caso specifico cambierebbe il tipo dell'eccezione sollevata)
In tal caso comunque si potrebbe sollevare una "SpidException" che al suo interno contenga le seguenti property:

Message: override della property Message della classe base Exception che contiene il messaggio da stampare a video (e.g. nel caso dell'errore 111 potrebbe essere "Errore generico")
Reason: la motivazione legata al sollevamento dell'eccezione, da usare per troubleshooting (e.g. nel caso dell'errore 111 potrebbe essere "Signature Response non trovata")
ErrorCode: codice di errore Spid (-1 per gli altri casi)

Questa modifica ha un impatto consistente, e riguarda tutti i punti in cui il codice solleva una eccezione, ivi compresi i metodi di validazione della response.
Sono aperto a PR.

eh si ho visto.... io ci provo e spero di trovare tutti i punti in cui serve questa modifica. Su ErrorCode volevo utilizzare un enum per ogni test che AgID mi ha notificato di modo che un utente possa fare quello che vuole nel momento in cui intende customizzare un messaggio specifico.
Ovviamente se sei d'accordo su questa scelta e se sei d'accordo a non definire tutti e 112 gli enum in questo sviluppo...magari qualche dev di buon cuore quanto creera la sua issue e il PR per impementare gli enum mancanti.

Nel momento in cui si rilascia una Major, e questa Major introduce una nuova gestione custom delle eccezioni, mi aspetto che tutti gli errorCode e tutti i messaggi delle regole tecniche di agid siano gestiti, la libreria a questo serve, fa lei il lavoro che dovrebbero fare gli altri. Capisco la tua necessità contingente, ma la libreria è a disposizione di tutti, non possiamo tirar fuori una versione che gestisce solo alcuni errori e non altri.

Ho aperto una pull request in draft così puoi dare un occhio a quello che sto facendo di modo che se hai delle richieste da farmi possiamo già vederli durante il work in progress.
Buon weekend e grazie.

authors: PiemP danielegiallonardo

repo: italia/spid-aspnetcore


text:
Validazione metadata Comune di Oristano

Buongiorno,
per conto del Comune di Oristano
abbiamo predisposto metadata  e pubblicati all'URL
https://bitonto.comune-online.it/serviziSPID/metadata.xml
cordiali saluti
Facondini Stefano
Maggioli Spa
metadata_oristano-signed.zip

Il Metadata è stato inoltrato verso gli IdP e da essi caricato.

authors: AntonioGiovanniSchiavone sfacondini

repo: italia/spid