text:
TestRootCertRotatorGoroutineForSigningCitadel test flake

https://prow.istio.io/view/gs/istio-prow/logs/unit-tests_istio_postsubmit/3407

https://prow.istio.io/view/gs/istio-prow/logs/unit-tests_istio_postsubmit/3770

Jimmy, could you submit a PR to skip this test?

could we close it?

it should be closed when the test is re-enabled
On Wed, Dec 16, 2020 at 2:58 PM FENGXIANGLI notifications@github.com
wrote:

could we close it?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/istio/istio/issues/26570#issuecomment-747091476, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAEYGXIHUARVNKDS3ARQ5W3SVE3SDANCNFSM4QB2A6UQ
.

source: gharchive/issue

authors: FENGXIANGLI howardjohn myidpt

license_type: permissive

license_source: github-api


text:
ssh_exchange_identification : read: Connection reset by peer error after injecting sidecar.

Bug description
Trying to establish ssh between two pods but the sidecar proxy is denying some of the ssh connections with
ssh_exchange_identification: read: Connection reset by peer error.
I ran a simple test where I am running the date command on both the pods but if you see there are errors while establishing the connection and because of that my application crashes as ssh connection fails while connecting to other pods. May I know why is this happening and any workaround available? Please note this happens only when pods have a sidecar.
[dashmpp-head-0 - Db2wh ~]$ for i in {1..100}; do ssh dashmpp-data1-0 date; done
Thu Feb 25 20:25:25 UTC 2021
Thu Feb 25 20:25:25 UTC 2021
Thu Feb 25 20:25:26 UTC 2021
Thu Feb 25 20:25:26 UTC 2021
Thu Feb 25 20:25:27 UTC 2021
Thu Feb 25 20:25:27 UTC 2021
Thu Feb 25 20:25:28 UTC 2021
Thu Feb 25 20:25:28 UTC 2021
Thu Feb 25 20:25:29 UTC 2021
Thu Feb 25 20:25:29 UTC 2021
Thu Feb 25 20:25:30 UTC 2021
Thu Feb 25 20:25:30 UTC 2021
Thu Feb 25 20:25:31 UTC 2021
Thu Feb 25 20:25:31 UTC 2021
Thu Feb 25 20:25:31 UTC 2021
Thu Feb 25 20:25:32 UTC 2021
Thu Feb 25 20:25:32 UTC 2021
Thu Feb 25 20:25:33 UTC 2021
Thu Feb 25 20:25:33 UTC 2021
Thu Feb 25 20:25:34 UTC 2021
Thu Feb 25 20:25:34 UTC 2021
Thu Feb 25 20:25:35 UTC 2021
Thu Feb 25 20:25:35 UTC 2021
Thu Feb 25 20:25:35 UTC 2021
Thu Feb 25 20:25:36 UTC 2021
Thu Feb 25 20:25:36 UTC 2021
Thu Feb 25 20:25:37 UTC 2021
Thu Feb 25 20:25:37 UTC 2021
Thu Feb 25 20:25:37 UTC 2021
Thu Feb 25 20:25:38 UTC 2021
Thu Feb 25 20:25:38 UTC 2021
Thu Feb 25 20:25:38 UTC 2021
Thu Feb 25 20:25:39 UTC 2021
Thu Feb 25 20:25:39 UTC 2021
Thu Feb 25 20:25:40 UTC 2021
Thu Feb 25 20:25:40 UTC 2021
Thu Feb 25 20:25:40 UTC 2021
Thu Feb 25 20:25:41 UTC 2021
Thu Feb 25 20:25:41 UTC 2021
ssh_exchange_identification: read: Connection reset by peer
Thu Feb 25 20:25:51 UTC 2021
Thu Feb 25 20:25:52 UTC 2021
Thu Feb 25 20:25:52 UTC 2021
Thu Feb 25 20:25:53 UTC 2021
Thu Feb 25 20:25:53 UTC 2021
Thu Feb 25 20:25:53 UTC 2021
Thu Feb 25 20:25:54 UTC 2021
Thu Feb 25 20:25:54 UTC 2021
Thu Feb 25 20:25:55 UTC 2021
Thu Feb 25 20:25:55 UTC 2021
Thu Feb 25 20:25:56 UTC 2021
Thu Feb 25 20:25:56 UTC 2021
Thu Feb 25 20:25:57 UTC 2021
Thu Feb 25 20:25:57 UTC 2021
Thu Feb 25 20:25:58 UTC 2021
Thu Feb 25 20:25:58 UTC 2021
Thu Feb 25 20:25:59 UTC 2021
Thu Feb 25 20:25:59 UTC 2021
Thu Feb 25 20:26:00 UTC 2021
Thu Feb 25 20:26:00 UTC 2021
Thu Feb 25 20:26:00 UTC 2021
Thu Feb 25 20:26:01 UTC 2021
Thu Feb 25 20:26:01 UTC 2021
Thu Feb 25 20:26:02 UTC 2021
Thu Feb 25 20:26:02 UTC 2021
Thu Feb 25 20:26:03 UTC 2021
Thu Feb 25 20:26:03 UTC 2021
Thu Feb 25 20:26:04 UTC 2021
Thu Feb 25 20:26:04 UTC 2021
Thu Feb 25 20:26:04 UTC 2021
ssh_exchange_identification: read: Connection reset by peer
Thu Feb 25 20:26:15 UTC 2021
Thu Feb 25 20:26:15 UTC 2021
Thu Feb 25 20:26:15 UTC 2021
Thu Feb 25 20:26:16 UTC 2021
Thu Feb 25 20:26:16 UTC 2021
Thu Feb 25 20:26:16 UTC 2021
Thu Feb 25 20:26:17 UTC 2021
Thu Feb 25 20:26:17 UTC 2021
Thu Feb 25 20:26:18 UTC 2021
Thu Feb 25 20:26:18 UTC 2021
Thu Feb 25 20:26:18 UTC 2021
Thu Feb 25 20:26:19 UTC 2021
Thu Feb 25 20:26:19 UTC 2021
Thu Feb 25 20:26:19 UTC 2021
Thu Feb 25 20:26:20 UTC 2021
Thu Feb 25 20:26:20 UTC 2021
Thu Feb 25 20:26:20 UTC 2021
Thu Feb 25 20:26:21 UTC 2021
Thu Feb 25 20:26:21 UTC 2021
Thu Feb 25 20:26:22 UTC 2021
Thu Feb 25 20:26:22 UTC 2021
Thu Feb 25 20:26:23 UTC 2021
Thu Feb 25 20:26:23 UTC 2021
Thu Feb 25 20:26:23 UTC 2021
Thu Feb 25 20:26:24 UTC 2021
Thu Feb 25 20:26:24 UTC 2021
Thu Feb 25 20:26:25 UTC 2021
Thu Feb 25 20:26:25 UTC 2021
Thu Feb 25 20:26:25 UTC 2021

[ ] Docs
[ ] Installation
[*] Networking
[ ] Performance and Scalability
[ ] Extensions and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
[ ] Upgrade
[*] Multi Cluster
[ ] Virtual Machine
[ ] Multi Control Plane
Expected behavior
it should not throw ssh_exchange_identification error.
Version (include the output of istioctl version --remote and kubectl version --short and helm version --short if you used Helm)
$ istioctl version                                                                                [16:01:10]
client version: 1.9.0
control plane version: 1.9.0
data plane version: 1.9.0 (3 proxies)

So both sides have a sidecar, right?
Can you try connecting directly to the pod IP? And can you also show the yaml of the dashmpp-data1-0 service?
if its intermittent its probably best to look at the debug logs (https://github.com/istio/istio/wiki/Troubleshooting-Istio) and see what error is thrown

Actually a full config dump may be useful as well

@vinemish looking at the access logs, 10000 corresponds to a duration.  All the failures seem to occur at about 10s which is the default connect_timeout applied to traffic considered outside the service mesh (i.e. traffic routed through PassthroughCluster).  Is port 50022 defined for the destination dashmpp-data1-0 service?  To test, you could modify the mesh's global default connectTimeout or you can write an EnvoyFilter to modify the PassthroughCluster's connectTimeout directly.
For understanding access logs, you can check out Engarde, Envoy's docs for access logs , or try a tool here which combines both of them.

Talked offline, user used the excludeOutboundPorts annotation for the ssh port.  Closing until more info is requested

Talked offline, user used the excludeOutboundPorts annotation for the ssh port. Closing until more info is requested

This solution worked for me too. I added this to the source pod spec from where I want to do ssh to connect to other pod or vm which has ssh server running:
traffic.sidecar.istio.io/excludeOutboundPorts: "22"

authors: GregHanson cheekykesav howardjohn vinemish

repo: istio/istio


text:
where can i find envoyfilter yaml demos

(NOTE: This is used to report product bugs:
To report a security vulnerability, please visit https://istio.io/about/security-vulnerabilities
To ask questions about how to use Istio, please visit https://discuss.istio.io)
Bug description
where can i find envoyfilter yaml demos*Affected product area (please put an X in all that apply)**
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Extensions and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
[ ] Upgrade
Expected behavior
Steps to reproduce the bug
Version (include the output of istioctl version --remote and kubectl version --short and helm version --short if you used Helm)
How was Istio installed?
Environment where the bug was observed (cloud vendor, OS, etc)
Additionally, please consider running istioctl bug-report and attach the generated cluster-state tarball to this issue.
Refer cluster state archive for more details.

https://github.com/istio/istio/wiki/EnvoyFilter-Samples contains some unofficial ones


text:
debug piggyback does not detach when request is complete

I ran a single piggyback request, and now each push is sending the debug info again.
istiod shows: istio.io/debug/syncz: PUSH for node:shell-7854df9c5-c6rjd.default-2 resources:3 size:191B
proxy shows: tap response "istio.io/debug/syncz" arrived too late; discarding

I've started looking at this.
Investigating https://github.com/istio/istio/blob/master/pilot/pkg/xds/ads.go#L200 which was intended to make sure the debug requests never make it far enough to remember the debug request.

authors: esnible howardjohn


text:
Istio ingress will silently ignore the mesh config if installed to any namespace other than istio-system

Bug Description
Based on the suggested setup from Installing Gateways if the gateway is installed to the namespace istio-ingress it will still try to look up the istio config at cm/istio. However, the istio configmap still resides in namespace istio-system and thus the ingress will boot up without the mesh config (as the config map is set to optional), thus ignoring settings like e.g. tracing options.
Version
$ istioctl version
client version: 1.12.1
control plane version: 1.12.1
data plane version: 1.12.1 (18 proxies)
$ kubectl version --short
Client Version: v1.21.1+k3s1
Server Version: v1.21.1+k3s1
$ # no helm used, deployed via the operator

Additional Information
istioctl bug-report is irrelevant to the bug as this is a helm chart configuration issue.

Are you sure the setting is ignored? If gateway is deployed in namespaces other than istio-system with namespace injection, mesh config will be injected via PROXY_CONFIG env var.

Yep. Here's the config dump of the ingress when config isn't present:

to me it looks like the defaults coming from here? https://github.com/istio/istio/blob/master/pkg/config/mesh/mesh.go#L54

How do you deployed the gateway exactly and what is your gateway deployment look like?

I have the following snippet in my IstioOperator resource:
    spec: {
      profile: 'default',
      components: {
        cni: {
          enabled: true,
        },
        ingressGateways: [
          {
            enabled: true,
            name: 'istio-ingressgateway',
            namespace: 'istio-ingress',
            k8s: {
              service: {
                externalTrafficPolicy: 'Local',
              },
            },
          },
        ],
      },

The istio-ingress is created with istio-injection=enabled.

Only the following env vars are present on the ingress:
    Environment:
      JWT_POLICY:                   third-party-jwt
      PILOT_CERT_PROVIDER:          istiod
      CA_ADDR:                      istiod.istio-system.svc:15012
      NODE_NAME:                     (v1:spec.nodeName)
      POD_NAME:                     istio-ingressgateway-865d6cbccb-swbpb (v1:metadata.name)
      POD_NAMESPACE:                istio-ingress (v1:metadata.namespace)
      INSTANCE_IP:                   (v1:status.podIP)
      HOST_IP:                       (v1:status.hostIP)
      SERVICE_ACCOUNT:               (v1:spec.serviceAccountName)
      ISTIO_META_WORKLOAD_NAME:     istio-ingressgateway
      ISTIO_META_OWNER:             kubernetes://apis/apps/v1/namespaces/istio-ingress/deployments/istio-ingressgateway
      ISTIO_META_MESH_ID:           cluster.local
      TRUST_DOMAIN:                 cluster.local
      ISTIO_META_UNPRIVILEGED_POD:  true
      ISTIO_META_CLUSTER_ID:        Kubernetes

I guess it's because ingresses specifically disallow injection? https://github.com/istio/istio/blob/master/manifests/charts/gateways/istio-ingress/templates/deployment.yaml#L45

Do you set values to enable gateway injection following the doc https://istio.io/latest/docs/setup/additional-setup/gateway/#deploying-a-gateway?
  values:
    gateways:
      istio-ingressgateway:
        # Enable gateway injection
        injectionTemplate: gateway

...
I sure should have done something better with my time than trying to tinker with service meshes one day before the year ends.
That was indeed it, thanks!

authors: bianpengyuan farcaller


text:
Gateway api: custom changes to deployment

Hi,
After investigating the istiod helm chart, i found that the deployment of the gateway deployment is here: https://github.com/istio/istio/blob/master/manifests/charts/istio-control/istio-discovery/files/kube-gateway.yaml
I want to change some properties of this deployment such as lifecycle hooks and nodeSelector.
Istio is deployed at my cluster with helm, and I can't use kustomize to change these properties because the kube-gateway.yaml file is injected to the isito-sidecar-injector configmap and according to: https://stackoverflow.com/questions/76475946/kustomize-how-to-add-a-section-for-a-config-file-generated-by-a-configmap and few attemps of mine I believe there is no way to customize the gateway deployment without pasting the whole configmap (bad idea as istio can make changes during versions).
How can I use custom values to change the gateway deployment with helm?
(with istio ingress gateway, a deployment was created so the kustomize solution was fine)
In addition, I tried to adjust the lifecycle hook with the istiod values like this, because I saw that lifecycle is supported in the helm chart:
global:
proxy:
lifecycle:
preStop:
exec:
command:
- /bin/sleep
- "60"
But I keep getting  .spec.template.spec.containers[name="istio-proxy"].exec: field not declared in schema.
How to fix this error? and in general how to add custom values to the gateway api deployment?

No


text:
istioctl appears to generate incorrect patch content for a DATA plane upgrade

Continued from here: https://github.com/istio/istio/issues/5638#issuecomment-389565862
I followed step 2 of the above upgrade document (upgrade the control plane) using this workflow:
cd $DAILY
sudo cp bin/istioctl /usr/bin
istioctl kube-inject -i istio-system --meshConfigMapName istio -f bi.yaml -o bi2.yaml
kubectl apply -f bi2.yaml
And receive these complaints.

for: "bi2.yaml": The order in patch list:
[map[name:istio-init args:[-p 15001 -u 1337 -m REDIRECT -i * -x  -b 9080, -d ] image:gcr.io/istio-release/proxy_init:release-0.8-20180515-17-26] map[resources:map[] securityContext:map[capabilities:map[add:[NET_ADMIN]]] args:[-p 15001 -u 1337] image:docker.io/istio/proxy_init:0.7.1 imagePullPolicy:IfNotPresent name:istio-init] map[image:gcr.io/istio-release/proxy_init:release-0.8-20180515-17-26 name:enable-core-dump] map[resources:map[] securityContext:map[privileged:true] args:[-c sysctl -w kernel.core_pattern=/etc/istio/proxy/core.%e.%p.%t && ulimit -c unlimited] command:[/bin/sh] image:alpine imagePullPolicy:IfNotPresent name:enable-core-dump]]
 doesn't match $setElementOrder list:
[map[name:istio-init] map[name:enable-core-dump] map[name:istio-init] map[name:enable-core-dump]]

Error from server: error when applying patch:
{"metadata":{"annotations":{"kubectl.kubernetes.io/last-applied-configuration":"{\"apiVersion\":\"extensions/v1beta1\",\"kind\":\"Deployment\",\"metadata\":{\"annotations\":{},\"creationTimestamp\":null,\"name\":\"reviews-v3\",\"namespace\":\"default\"},\"spec\":{\"replicas\":1,\"strategy\":{},\"template\":{\"metadata\":{\"annotations\":{\"sidecar.istio.io/status\":\"{\\\"version\\\":\\\"8f6b9e7976b57430401df413f46449cd66cb26386144f0c853ae1e6d53863e70\\\",\\\"initContainers\\\":[\\\"istio-init\\\",\\\"enable-core-dump\\\"],\\\"containers\\\":[\\\"istio-proxy\\\"],\\\"volumes\\\":[\\\"istio-envoy\\\",\\\"istio-certs\\\"],\\\"imagePullSecrets\\\":null}\"},\"creationTimestamp\":null,\"labels\":{\"app\":\"reviews\",\"version\":\"v3\"}},\"spec\":{\"containers\":[{\"image\":\"istio/examples-bookinfo-reviews-v3:1.5.0\",\"imagePullPolicy\":\"IfNotPresent\",\"name\":\"reviews\",\"ports\":[{\"containerPort\":9080}],\"resources\":{}},{\"args\":[\"proxy\",\"sidecar\",\"--configPath\",\"/etc/istio/proxy\",\"--binaryPath\",\"/usr/local/bin/envoy\",\"--serviceCluster\",\"reviews\",\"--drainDuration\",\"45s\",\"--parentShutdownDuration\",\"1m0s\",\"--discoveryAddress\",\"istio-pilot.istio-system:8080\",\"--discoveryRefreshDelay\",\"1s\",\"--zipkinAddress\",\"zipkin.istio-system:9411\",\"--connectTimeout\",\"10s\",\"--statsdUdpAddress\",\"istio-mixer.istio-system:9125\",\"--proxyAdminPort\",\"15000\",\"--controlPlaneAuthPolicy\",\"NONE\"],\"env\":[{\"name\":\"POD_NAME\",\"valueFrom\":{\"fieldRef\":{\"fieldPath\":\"metadata.name\"}}},{\"name\":\"POD_NAMESPACE\",\"valueFrom\":{\"fieldRef\":{\"fieldPath\":\"metadata.namespace\"}}},{\"name\":\"INSTANCE_IP\",\"valueFrom\":{\"fieldRef\":{\"fieldPath\":\"status.podIP\"}}}],\"image\":\"docker.io/istio/proxy:0.7.1\",\"imagePullPolicy\":\"IfNotPresent\",\"name\":\"istio-proxy\",\"resources\":{},\"securityContext\":{\"privileged\":false,\"readOnlyRootFilesystem\":true,\"runAsUser\":1337},\"volumeMounts\":[{\"mountPath\":\"/etc/istio/proxy\",\"name\":\"istio-envoy\"},{\"mountPath\":\"/etc/certs/\",\"name\":\"istio-certs\",\"readOnly\":true}]},{\"args\":[\"proxy\",\"sidecar\",\"--configPath\",\"/etc/istio/proxy\",\"--binaryPath\",\"/usr/local/bin/envoy\",\"--serviceCluster\",\"reviews\",\"--drainDuration\",\"45s\",\"--parentShutdownDuration\",\"1m0s\",\"--discoveryAddress\",\"istio-pilot.istio-system:15007\",\"--discoveryRefreshDelay\",\"1s\",\"--zipkinAddress\",\"zipkin.istio-system:9411\",\"--connectTimeout\",\"10s\",\"--statsdUdpAddress\",\"istio-statsd-prom-bridge.istio-system:9125\",\"--proxyAdminPort\",\"15000\",\"--controlPlaneAuthPolicy\",\"NONE\"],\"env\":[{\"name\":\"POD_NAME\",\"valueFrom\":{\"fieldRef\":{\"fieldPath\":\"metadata.name\"}}},{\"name\":\"POD_NAMESPACE\",\"valueFrom\":{\"fieldRef\":{\"fieldPath\":\"metadata.namespace\"}}},{\"name\":\"INSTANCE_IP\",\"valueFrom\":{\"fieldRef\":{\"fieldPath\":\"status.podIP\"}}},{\"name\":\"ISTIO_META_POD_NAME\",\"valueFrom\":{\"fieldRef\":{\"fieldPath\":\"metadata.name\"}}},{\"name\":\"ISTIO_META_INTERCEPTION_MODE\",\"value\":\"REDIRECT\"}],\"image\":\"gcr.io/istio-release/proxy:release-0.8-20180515-17-26\",\"imagePullPolicy\":\"IfNotPresent\",\"name\":\"istio-proxy\",\"resources\":{},\"securityContext\":{\"privileged\":false,\"readOnlyRootFilesystem\":true,\"runAsUser\":1337},\"volumeMounts\":[{\"mountPath\":\"/etc/istio/proxy\",\"name\":\"istio-envoy\"},{\"mountPath\":\"/etc/certs/\",\"name\":\"istio-certs\",\"readOnly\":true}]}],\"initContainers\":[{\"args\":[\"-p\",\"15001\",\"-u\",\"1337\"],\"image\":\"docker.io/istio/proxy_init:0.7.1\",\"imagePullPolicy\":\"IfNotPresent\",\"name\":\"istio-init\",\"resources\":{},\"securityContext\":{\"capabilities\":{\"add\":[\"NET_ADMIN\"]}}},{\"args\":[\"-c\",\"sysctl -w kernel.core_pattern=/etc/istio/proxy/core.%e.%p.%t \\u0026\\u0026 ulimit -c unlimited\"],\"command\":[\"/bin/sh\"],\"image\":\"alpine\",\"imagePullPolicy\":\"IfNotPresent\",\"name\":\"enable-core-dump\",\"resources\":{},\"securityContext\":{\"privileged\":true}},{\"args\":[\"-p\",\"15001\",\"-u\",\"1337\",\"-m\",\"REDIRECT\",\"-i\",\"*\",\"-x\",\"\",\"-b\",\"9080,\",\"-d\",\"\"],\"image\":\"gcr.io/istio-release/proxy_init:release-0.8-20180515-17-26\",\"imagePullPolicy\":\"IfNotPresent\",\"name\":\"istio-init\",\"resources\":{},\"securityContext\":{\"capabilities\":{\"add\":[\"NET_ADMIN\"]}}},{\"args\":[\"-c\",\"sysctl -w kernel.core_pattern=/etc/istio/proxy/core.%e.%p.%t \\u0026\\u0026 ulimit -c unlimited\"],\"command\":[\"/bin/sh\"],\"image\":\"gcr.io/istio-release/proxy_init:release-0.8-20180515-17-26\",\"imagePullPolicy\":\"IfNotPresent\",\"name\":\"enable-core-dump\",\"resources\":{},\"securityContext\":{\"privileged\":true}}],\"volumes\":[{\"emptyDir\":{\"medium\":\"Memory\"},\"name\":\"istio-envoy\"},{\"name\":\"istio-certs\",\"secret\":{\"optional\":true,\"secretName\":\"istio.default\"}},{\"emptyDir\":{\"medium\":\"Memory\"},\"name\":\"istio-envoy\"},{\"name\":\"istio-certs\",\"secret\":{\"optional\":true,\"secretName\":\"istio.default\"}}]}}},\"status\":{}}\n"},"creationTimestamp":null},"spec":{"template":{"metadata":{"annotations":{"sidecar.istio.io/status":"{\"version\":\"8f6b9e7976b57430401df413f46449cd66cb26386144f0c853ae1e6d53863e70\",\"initContainers\":[\"istio-init\",\"enable-core-dump\"],\"containers\":[\"istio-proxy\"],\"volumes\":[\"istio-envoy\",\"istio-certs\"],\"imagePullSecrets\":null}"}},"spec":{"$setElementOrder/containers":[{"name":"reviews"},{"name":"istio-proxy"},{"name":"istio-proxy"}],"$setElementOrder/initContainers":[{"name":"istio-init"},{"name":"enable-core-dump"},{"name":"istio-init"},{"name":"enable-core-dump"}],"$setElementOrder/volumes":[{"name":"istio-envoy"},{"name":"istio-certs"},{"name":"istio-envoy"},{"name":"istio-certs"}],"containers":[{"$setElementOrder/env":[{"name":"POD_NAME"},{"name":"POD_NAMESPACE"},{"name":"INSTANCE_IP"},{"name":"ISTIO_META_POD_NAME"},{"name":"ISTIO_META_INTERCEPTION_MODE"}],"args":["proxy","sidecar","--configPath","/etc/istio/proxy","--binaryPath","/usr/local/bin/envoy","--serviceCluster","reviews","--drainDuration","45s","--parentShutdownDuration","1m0s","--discoveryAddress","istio-pilot.istio-system:15007","--discoveryRefreshDelay","1s","--zipkinAddress","zipkin.istio-system:9411","--connectTimeout","10s","--statsdUdpAddress","istio-statsd-prom-bridge.istio-system:9125","--proxyAdminPort","15000","--controlPlaneAuthPolicy","NONE"],"env":[{"name":"ISTIO_META_POD_NAME","valueFrom":{"fieldRef":{"fieldPath":"metadata.name"}}},{"name":"ISTIO_META_INTERCEPTION_MODE","value":"REDIRECT"}],"image":"gcr.io/istio-release/proxy:release-0.8-20180515-17-26","name":"istio-proxy"},{"args":["proxy","sidecar","--configPath","/etc/istio/proxy","--binaryPath","/usr/local/bin/envoy","--serviceCluster","reviews","--drainDuration","45s","--parentShutdownDuration","1m0s","--discoveryAddress","istio-pilot.istio-system:8080","--discoveryRefreshDelay","1s","--zipkinAddress","zipkin.istio-system:9411","--connectTimeout","10s","--statsdUdpAddress","istio-mixer.istio-system:9125","--proxyAdminPort","15000","--controlPlaneAuthPolicy","NONE"],"env":[{"name":"POD_NAME","valueFrom":{"fieldRef":{"fieldPath":"metadata.name"}}},{"name":"POD_NAMESPACE","valueFrom":{"fieldRef":{"fieldPath":"metadata.namespace"}}},{"name":"INSTANCE_IP","valueFrom":{"fieldRef":{"fieldPath":"status.podIP"}}}],"image":"docker.io/istio/proxy:0.7.1","imagePullPolicy":"IfNotPresent","name":"istio-proxy","resources":{},"securityContext":{"privileged":false,"readOnlyRootFilesystem":true,"runAsUser":1337},"volumeMounts":[{"mountPath":"/etc/istio/proxy","name":"istio-envoy"},{"mountPath":"/etc/certs/","name":"istio-certs","readOnly":true}]}],"initContainers":[{"args":["-p","15001","-u","1337","-m","REDIRECT","-i","*","-x","","-b","9080,","-d",""],"image":"gcr.io/istio-release/proxy_init:release-0.8-20180515-17-26","name":"istio-init"},{"args":["-p","15001","-u","1337"],"image":"docker.io/istio/proxy_init:0.7.1","imagePullPolicy":"IfNotPresent","name":"istio-init","resources":{},"securityContext":{"capabilities":{"add":["NET_ADMIN"]}}},{"image":"gcr.io/istio-release/proxy_init:release-0.8-20180515-17-26","name":"enable-core-dump"},{"args":["-c","sysctl -w kernel.core_pattern=/etc/istio/proxy/core.%e.%p.%t \u0026\u0026 ulimit -c unlimited"],"command":["/bin/sh"],"image":"alpine","imagePullPolicy":"IfNotPresent","name":"enable-core-dump","resources":{},"securityContext":{"privileged":true}}],"volumes":[{"emptyDir":{"medium":"Memory"},"name":"istio-envoy"},{"name":"istio-certs","secret":{"optional":true,"secretName":"istio.default"}}]}}}}
to:
&{0xc4200cf440 0xc4203be150 default reviews-v3 bi2.yaml 0xc4200d8018 18007 false}
for: "bi2.yaml": The order in patch list:
[map[args:[-p 15001 -u 1337 -m REDIRECT -i * -x  -b 9080, -d ] image:gcr.io/istio-release/proxy_init:release-0.8-20180515-17-26 name:istio-init] map[args:[-p 15001 -u 1337] image:docker.io/istio/proxy_init:0.7.1 imagePullPolicy:IfNotPresent name:istio-init resources:map[] securityContext:map[capabilities:map[add:[NET_ADMIN]]]] map[image:gcr.io/istio-release/proxy_init:release-0.8-20180515-17-26 name:enable-core-dump] map[imagePullPolicy:IfNotPresent name:enable-core-dump resources:map[] securityContext:map[privileged:true] args:[-c sysctl -w kernel.core_pattern=/etc/istio/proxy/core.%e.%p.%t && ulimit -c unlimited] command:[/bin/sh] image:alpine]]
 doesn't match $setElementOrder list:
[map[name:istio-init] map[name:enable-core-dump] map[name:istio-init] map[name:enable-core-dump]]

istioctl kube-inject isn't idempotent. I believe ORIGINAL_DEPLOYMENT_YAML in https://docs.google.com/document/d/1oxrlCgL7R0b_r4aIIFyBne2IxN1Lof3edo9YPy6h2Yk refers to the original YAML before the sidecar was added.
cc @yusuoh. Related https://github.com/istio/istio/issues/3738

@ayj thanks - I should have caught that in the docs.  Will verify and then close if its not a problem.

operator error.

authors: ayj sdake


text:
RedisQuota don't work

Describe the bug
A clear and concise description of what the bug is.
memquota work, but the redisquota don't work
Expected behavior
A clear and concise description of what you expected to happen.
redisquota can work
Steps to reproduce the bug
Steps to reproduce the behavior.
in install/kubernetes/istio-demo.yml i don't find redisquota, so i create it using the config below
redisquota
kind: CustomResourceDefinition
apiVersion: apiextensions.k8s.io/v1beta1
metadata:
  name: redisquotas.config.istio.io
  labels:
    app: mixer
    package: redisquota
    istio: mixer-adapter
spec:
  group: config.istio.io
  names:
    kind: redisquota
    plural: redisquotas
    singular: redisquota
  scope: Namespaced
  version: v1alpha2
---

Then according to the redisquota,the adaptor config is:
apiVersion: "config.istio.io/v1alpha2"
kind: redisquota
metadata:
  name: handler
  namespace: istio-system
spec:
  quotas:
  - name: requestcount.quota.istio-system
    maxAmount: 2
    validDuration: 2s
    bucketDuration: 1s
    rateLimitAlgorithm: ROLLING_WINDOW
    overrides:
    - dimensions:
        destination: svc1
      maxAmount: 1
  redisServerUrl: redis.xxx.xxx:6379
  connectionPoolSize: 1
---

apiVersion: "config.istio.io/v1alpha2"
kind: quota
metadata:
  name: requestcount
  namespace: istio-system
spec:
  dimensions:
    source: source.labels["app"] | source.service | "unknown"
    sourceVersion: source.labels["version"] | "unknown"
    destination: destination.labels["app"] | destination.service | "unknown"
    destinationVersion: destination.labels["version"] | "unknown"

---

apiVersion: "config.istio.io/v1alpha2"
kind: rule
metadata:
  name: quota
  namespace: istio-system
spec:
  actions:
  - handler: handler.redisquota
    instances:
    - requestcount.quota
---
apiVersion: "config.istio.io/v1alpha2"
kind: QuotaSpec
metadata:
  name: request-count
  namespace: istio-system
spec:
  rules:
  - quotas:
    - charge: "1"
      quota: requestcount

---
apiVersion: "config.istio.io/v1alpha2"
kind: QuotaSpecBinding
metadata:
  name: request-count
  namespace: istio-system
spec:
  quotaSpecs:
  - name: request-count
    namespace: istio-system
  services:
  - name: svc1
    namespace: svc

Version
What version of istio and Kubernetes are you using? Use istioctl version and kubectl version
istio:0.8.0
Is Istio Auth enabled or not?
Did you install the stable istio.yaml, istio-auth.yaml.... or if using the Helm chart please provide full command line input.
not
Environment
Which environment, cloud vendor, OS, etc are you using?
kubernetes

Thanks for the bug report.
@tahler can you investigate ?

I think it's because redisquota is not added to mixer/adapter/inventory.yaml which this PR tries to fix: https://github.com/istio/istio/pull/6720/files..
@wansuiye : this should not affect redisquota not working but for later.. source.service and destination.service are deprecated and you can use source.workload.name and destination.workload.name instead of them.

hello guys,
Was this bug fixed in 1.0? I have tried the sample but no lucy. I'm wondering we have fixed the bug or not in 1.0.

by the way, how to check the logs?

@dotw: Yes, this bug was fixed in 1.0.
We just found one bug with the way it evaluates which quota override to choose which is fixed in this pr: https://github.com/istio/istio/pull/7913
you can look for logs in istio-policy pod logs..

Closing this issue as it's fixed now.. please re-open if you feel otherwise

@gargnupur I'm using redisquota now and found it's not so accurate even using rolling window. e.g. I define a rate with 1 request in 10 seconds, and then I using a curl to request the service to display the result. I found sometimes 2 or more requests are permitted in 10 seconds. Is this a correct behavior? As my understanding, only 1 request is permitted in 10 seconds.

authors: dotw gargnupur mandarjog wansuiye


text:
Enable retries for specified status codes

This PR enables the retriable status code flag in retry_on, this is needed before the status code values can be evaluated for retries.
The PR also reduces the number of retries to 2 as discussed with @rshriram @nmittler and @duderino

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: knrc
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: zackbutcher
If they are not already assigned, you can assign the PR to them by writing /assign @zackbutcher in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

pilot/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Hi @knrc. Thanks for your PR.
I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

/ok-to-test
Wonderful contribution @knrc

@knrc: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests.sh
cc7f5bc4f4bc0bc7806e8ad3ec145d4968f42e02
link
/test e2e-simpleTests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@knrc: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests-cni.sh
74a4947457da746fe3f2640aa8e76f4b1bda4620
link
/test e2e-simpleTests-cni

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@knrc: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests-cni.sh
74a4947457da746fe3f2640aa8e76f4b1bda4620
link
/test e2e-simpleTests-cni

prow/istio-integ-k8s-tests.sh
74a4947457da746fe3f2640aa8e76f4b1bda4620
link
/test istio-integ-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: knrc, nmittler
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

pilot/OWNERS [nmittler]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knrc: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests-cni.sh
74a4947457da746fe3f2640aa8e76f4b1bda4620
link
/test e2e-simpleTests-cni

prow/istio-integ-k8s-tests.sh
74a4947457da746fe3f2640aa8e76f4b1bda4620
link
/test istio-integ-k8s-tests

prow/istio-pilot-multicluster-e2e.sh
74a4947457da746fe3f2640aa8e76f4b1bda4620
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

I worry that both circleci runs for this PR failed the same required test:
https://circleci.com/gh/istio/istio/343105?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link
TestIngressGateway503DuringRuleChange - pilot
Failed
gateway "istio-ingressgateway" created
destinationrule "destination-rule-c" created
virtualservice "gateway-bound-route" created
destinationrule "destination-rule-c" configured
virtualservice "gateway-bound-route" configured
destinationrule "destination-rule-c" configured
virtualservice "gateway-bound-route" deleted
destinationrule "destination-rule-c" deleted
gateway "istio-ingressgateway" deleted
ingressgateway_test.go:258: Got non 200 status code while changing rules: map[503:2 200:498]

@duderino +1, I'm investigating

@knrc I found one other recent case of that failure that's independent of this change:  https://circleci.com/gh/istio/istio/342827
I'm kicking it off again to see if it fails a third time

@duderino  It would be quite a coincidence if it wasn't related, there must be something to it.

If it fails a third time I'll revert the second commit and try again

/retest

@knrc retest only retriggers prow jobs.  you have to click on the Details link on the circleci failures and clikc on the rerun workflow in the upper right corner

@duderino Ah, I don't have access in that case

Hi. How does the envoy know what status code can be configured? Looking at the istio docs I cannot find the answer.  Thanks.

oh, it's a bit obscure. Looks like you can configure through virtualservice's header values.

It's part of the virtual service

@nmittler oh, it needs to append the retry headers in the virtualservice to tell Envoy to retry on certain status code.

@iandyh

@nmittler oh, it needs to append the retry headers in the virtualservice to tell Envoy to retry on certain status code.

Not exactly ... this has nothing to do with HTTP headers. We're configuring Envoy's routes directly. If you were to provide headers in the request to modify this behavior, Envoy would process those headers normally.

@nmittler Thanks for the correction. Looks likes the status code atm is being hard coded as http.StatusServiceUnavailable? ref: https://github.com/knrc/istio/blob/cc7f5bc4f4bc0bc7806e8ad3ec145d4968f42e02/pilot/pkg/networking/core/v1alpha3/route/retry/retry.go#L34

Yes, that's the default.

source: gharchive/pull-request

authors: duderino iandyh istio-testing knrc nmittler


text:
WIP Debug 503 during rule change

For https://github.com/istio/istio/issues/11929 and https://github.com/istio/istio/issues/11700

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: esnible
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: greghanson
If they are not already assigned, you can assign the PR to them by writing /assign @greghanson in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

tests/e2e/tests/pilot/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@esnible: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-k8s-tests.sh
1859e9c923ca61d98f690503e2d6911431ce7651
link
/test istio-integ-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test istio-pilot-e2e-envoyv2-v1alpha3

@esnible: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-k8s-tests.sh
1859e9c923ca61d98f690503e2d6911431ce7651
link
/test istio-integ-k8s-tests

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
1859e9c923ca61d98f690503e2d6911431ce7651
link
/test istio-pilot-e2e-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

authors: esnible istio-testing


text:
guard mysql proxy with version check

Signed-off-by: Shriram Rajagopalan shriramr@vmware.com

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: rshriram
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

pilot/pkg/networking/OWNERS [rshriram]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rshriram: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-k8s-tests.sh
8c0fea38ac28cf27bf778431c8be2aca21ad9a71
link
/test istio-integ-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rshriram: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-k8s-tests.sh
8c0fea38ac28cf27bf778431c8be2aca21ad9a71
link
/test istio-integ-k8s-tests

prow/istio-pilot-multicluster-e2e.sh
8c0fea38ac28cf27bf778431c8be2aca21ad9a71
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/approve
/lgtm

authors: GregHanson istio-testing rshriram


text:
[release-1.3] remove EnableHeadlessService env from Pilot.go

Please provide a description for what this PR is for.
And to help us figure out who should review this PR, please
put an X in all the areas that this PR affects.
[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure

@yxue: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

e2e-bookInfoTests-envoyv2-v1alpha3-release-1.3
237f608a8c545e85e65a503af04c2a0501dbc1ee
link
/test e2e-bookInfoTests-envoyv2-v1alpha3-release-1.3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test e2e-bookInfoTests-envoyv2-v1alpha3-release-1.3

@yxue: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

e2e-bookInfoTests-envoyv2-v1alpha3-release-1.3
237f608a8c545e85e65a503af04c2a0501dbc1ee
link
/test e2e-bookInfoTests-envoyv2-v1alpha3-release-1.3

istio-pilot-e2e-envoyv2-v1alpha3-release-1.3
237f608a8c545e85e65a503af04c2a0501dbc1ee
link
/test istio-pilot-e2e-envoyv2-v1alpha3-release-1.3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test istio-pilot-e2e-envoyv2-v1alpha3-release-1.3

@yxue: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

e2e-mixer-no_auth-release-1.3
237f608a8c545e85e65a503af04c2a0501dbc1ee
link
/test e2e-mixer-no_auth-release-1.3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test e2e-mixer-no_auth-release-1.3

@yxue: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

e2e-mixer-no_auth-release-1.3
237f608a8c545e85e65a503af04c2a0501dbc1ee
link
/test e2e-mixer-no_auth-release-1.3

istio-racetest-release-1.3
237f608a8c545e85e65a503af04c2a0501dbc1ee
link
/test istio-racetest-release-1.3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test istio-racetest-release-1.3

authors: istio-testing yxue


text:
Improvements on echo test app/framework

Log GRPC requests
Add Workload.Logs() to retrieve app container logs
Allow users to send the Message field in GRPC calls

@jwendell: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

lint_istio
17c96abb33f1855e9f0ffd28c04a95d63a9a10cc
link
/test lint

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jwendell: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

lint_istio
17c96abb33f1855e9f0ffd28c04a95d63a9a10cc
link
/test lint

unit-tests_istio
17c96abb33f1855e9f0ffd28c04a95d63a9a10cc
link
/test unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jwendell: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

lint_istio
17c96abb33f1855e9f0ffd28c04a95d63a9a10cc
link
/test lint

unit-tests_istio
17c96abb33f1855e9f0ffd28c04a95d63a9a10cc
link
/test unit-tests

racetest_istio
17c96abb33f1855e9f0ffd28c04a95d63a9a10cc
link
/test racetest

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jwendell: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

unit-tests_istio
17c96abb33f1855e9f0ffd28c04a95d63a9a10cc
link
/test unit-tests

racetest_istio
17c96abb33f1855e9f0ffd28c04a95d63a9a10cc
link
/test racetest

lint_istio
fc0986b7f9c0e074ca7023d009293efff1c32326
link
/test lint

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@jwendell: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

lint_istio
fc0986b7f9c0e074ca7023d009293efff1c32326
link
/test lint

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jwendell: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-mixer-k8s-tests_istio
ce44fcd15c7f214bb9bf5dc382522778305d7af8
link
/test integ-mixer-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

authors: howardjohn istio-testing jwendell


text:
[release-1.4] Sort messages before finishing analysis

This is an automated cherry-pick of #17940

@istio-testing: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-new-install-k8s-tests_istio_release-1.4
f2aea2f3bdf4385c0f87602424178218d626df97
link
/test integ-new-install-k8s-tests_istio_release-1.4

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@istio-testing: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-new-install-k8s-tests_istio_release-1.4
f2aea2f3bdf4385c0f87602424178218d626df97
link
/test integ-new-install-k8s-tests_istio_release-1.4

integ-mixer-k8s-tests_istio_release-1.4
f2aea2f3bdf4385c0f87602424178218d626df97
link
/test integ-mixer-k8s-tests_istio_release-1.4

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@istio-testing: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-new-install-k8s-tests_istio_release-1.4
f2aea2f3bdf4385c0f87602424178218d626df97
link
/test integ-new-install-k8s-tests_istio_release-1.4

integ-mixer-k8s-tests_istio_release-1.4
f2aea2f3bdf4385c0f87602424178218d626df97
link
/test integ-mixer-k8s-tests_istio_release-1.4

e2e-mixer-no_auth_istio_release-1.4
f2aea2f3bdf4385c0f87602424178218d626df97
link
/test e2e-mixer-no_auth_istio_release-1.4

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@istio-testing: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-new-install-k8s-tests_istio_release-1.4
f2aea2f3bdf4385c0f87602424178218d626df97
link
/test integ-new-install-k8s-tests_istio_release-1.4

integ-mixer-k8s-tests_istio_release-1.4
f2aea2f3bdf4385c0f87602424178218d626df97
link
/test integ-mixer-k8s-tests_istio_release-1.4

e2e-mixer-no_auth_istio_release-1.4
f2aea2f3bdf4385c0f87602424178218d626df97
link
/test e2e-mixer-no_auth_istio_release-1.4

integ-security-k8s-tests_istio_release-1.4
f2aea2f3bdf4385c0f87602424178218d626df97
link
/test integ-security-k8s-tests_istio_release-1.4

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@istio-testing: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-new-install-k8s-tests_istio_release-1.4
f2aea2f3bdf4385c0f87602424178218d626df97
link
/test integ-new-install-k8s-tests_istio_release-1.4

integ-security-k8s-tests_istio_release-1.4
f2aea2f3bdf4385c0f87602424178218d626df97
link
/test integ-security-k8s-tests_istio_release-1.4

integ-mixer-k8s-tests_istio_release-1.4
f2aea2f3bdf4385c0f87602424178218d626df97
link
/test integ-mixer-k8s-tests_istio_release-1.4

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@istio-testing: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-security-k8s-tests_istio_release-1.4
f2aea2f3bdf4385c0f87602424178218d626df97
link
/test integ-security-k8s-tests_istio_release-1.4

integ-mixer-k8s-tests_istio_release-1.4
f2aea2f3bdf4385c0f87602424178218d626df97
link
/test integ-mixer-k8s-tests_istio_release-1.4

integ-new-install-k8s-tests_istio_release-1.4
f2aea2f3bdf4385c0f87602424178218d626df97
link
/test integ-new-install-k8s-tests_istio_release-1.4

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@istio-testing: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-mixer-k8s-tests_istio_release-1.4
f2aea2f3bdf4385c0f87602424178218d626df97
link
/test integ-mixer-k8s-tests_istio_release-1.4

integ-new-install-k8s-tests_istio_release-1.4
f2aea2f3bdf4385c0f87602424178218d626df97
link
/test integ-new-install-k8s-tests_istio_release-1.4

unit-tests_istio_release-1.4
f2aea2f3bdf4385c0f87602424178218d626df97
link
/test unit-tests_istio_release-1.4

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@istio-testing: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-mixer-k8s-tests_istio_release-1.4
f2aea2f3bdf4385c0f87602424178218d626df97
link
/test integ-mixer-k8s-tests_istio_release-1.4

integ-new-install-k8s-tests_istio_release-1.4
f2aea2f3bdf4385c0f87602424178218d626df97
link
/test integ-new-install-k8s-tests_istio_release-1.4

unit-tests_istio_release-1.4
f2aea2f3bdf4385c0f87602424178218d626df97
link
/test unit-tests_istio_release-1.4

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

/retest

authors: howardjohn istio-testing


text:
[release-1.5]  fix(gateways): add canonical service labels to gateways

Manual cherry-pick of #21417. Had to make adjustments to the canonical-revision labeling.
/cc @howardjohn
[ X ] Installation
[ X ] Policies and Telemetry

@douglas-reid: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio_release-1.5
092817a35521543903faeec5282469e8ee48d9cc
link
/test gencheck_istio_release-1.5

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@douglas-reid: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio_release-1.5
092817a35521543903faeec5282469e8ee48d9cc
link
/test gencheck_istio_release-1.5

lint_istio_release-1.5
092817a35521543903faeec5282469e8ee48d9cc
link
/test lint_istio_release-1.5

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@douglas-reid: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio_release-1.5
092817a35521543903faeec5282469e8ee48d9cc
link
/test gencheck_istio_release-1.5

lint_istio_release-1.5
092817a35521543903faeec5282469e8ee48d9cc
link
/test lint_istio_release-1.5

unit-tests_istio_release-1.5
092817a35521543903faeec5282469e8ee48d9cc
link
/test unit-tests_istio_release-1.5

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@douglas-reid: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio_release-1.5
092817a35521543903faeec5282469e8ee48d9cc
link
/test lint_istio_release-1.5

unit-tests_istio_release-1.5
719fe00597205471da60c51fd2cde5c3636a8ba4
link
/test unit-tests_istio_release-1.5

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test unit-tests_istio_release-1.5

authors: douglas-reid istio-testing


text:
echoboot.NewBuilder cannot return error

This function never fails, so adjust the API to express this

@howardjohn: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
e930a4c1272df4b733daa909281fc5eadf757fb8
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@howardjohn: PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@howardjohn: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
85f069022d558652e0848a16e4a5b144f65d1a4f
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
85f069022d558652e0848a16e4a5b144f65d1a4f
link
/test lint_istio

gencheck_istio
85f069022d558652e0848a16e4a5b144f65d1a4f
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
85f069022d558652e0848a16e4a5b144f65d1a4f
link
/test lint_istio

gencheck_istio
85f069022d558652e0848a16e4a5b144f65d1a4f
link
/test gencheck_istio

integ-pilot-k8s-tests_istio
85f069022d558652e0848a16e4a5b144f65d1a4f
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio
85f069022d558652e0848a16e4a5b144f65d1a4f
link
/test integ-pilot-k8s-tests_istio

unit-tests_istio
bf45035f4a389e937b6d07780721404b0e6c7e9b
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest


text:
[release-1.9] remove unused operator resource permissions.

This is an automated cherry-pick of #30983

@googlebot I consent.

authors: istio-testing morvencao


text:
Add vm to authz test

This splits out of #31618.
Add VM to TestAuthorization_Conditions, TestAuthorization_GRPC, TestAuthorization_Path and TestAuthorization_Audit.
[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
Pull Request Attributes
Please check any characteristics that apply to this pull request.
[x] Does not have any changes that may affect Istio users.

@JimmyCYJ: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-telemetry-mc-k8s-tests_istio
57bc8ba7366f78eb5ab6f649535646b4864e4bf6
link
/test integ-telemetry-mc-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test integ-telemetry-mc-k8s-tests_istio

@JimmyCYJ: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-multicluster-tests_istio
57fa89c9ef4da0e3274062e1a5721dd56133a83b
link
/test integ-pilot-multicluster-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test integ-pilot-multicluster-tests_istio

@JimmyCYJ: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-multicluster-tests_istio
57fa89c9ef4da0e3274062e1a5721dd56133a83b
link
/test integ-pilot-multicluster-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test integ-pilot-multicluster-tests_istio

@JimmyCYJ: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-multicluster-tests_istio
57fa89c9ef4da0e3274062e1a5721dd56133a83b
link
/test integ-pilot-multicluster-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test integ-pilot-multicluster-tests_istio

In response to a cherrypick label: new pull request created: #32192

In response to a cherrypick label: #31883 failed to apply on top of branch "release-1.9":
Applying: add vm to authz test
Using index info to reconstruct a base tree...
M	tests/integration/security/authorization_test.go
M	tests/integration/security/testdata/authz/v1beta1-audit.yaml.tmpl
M	tests/integration/security/testdata/authz/v1beta1-conditions.yaml.tmpl
M	tests/integration/security/testdata/authz/v1beta1-grpc.yaml.tmpl
M	tests/integration/security/testdata/authz/v1beta1-path.yaml.tmpl
Falling back to patching base and 3-way merge...
Auto-merging tests/integration/security/testdata/authz/v1beta1-path.yaml.tmpl
Auto-merging tests/integration/security/testdata/authz/v1beta1-grpc.yaml.tmpl
Auto-merging tests/integration/security/testdata/authz/v1beta1-conditions.yaml.tmpl
CONFLICT (modify/delete): tests/integration/security/testdata/authz/v1beta1-audit.yaml.tmpl deleted in add vm to authz test and modified in HEAD. Version HEAD of tests/integration/security/testdata/authz/v1beta1-audit.yaml.tmpl left in tree.
Auto-merging tests/integration/security/authorization_test.go
CONFLICT (content): Merge conflict in tests/integration/security/authorization_test.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 add vm to authz test
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to a cherrypick label: new issue created for failed cherrypick: #32193

authors: JimmyCYJ istio-testing


text:
Automator: update common-files@master in istio/istio@master

Generated by Automator - 2022-03-08T18:14:00+00:00

@istio-testing: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-telemetry-istiodremote_istio
0f08f4300ab0f85c092b0d40d965b00411594e4b
link
unknown
/test integ-telemetry-istiodremote_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@istio-testing: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-telemetry-istiodremote_istio
0f08f4300ab0f85c092b0d40d965b00411594e4b
link
unknown
/test integ-telemetry-istiodremote_istio

integ-operator-controller_istio
0f08f4300ab0f85c092b0d40d965b00411594e4b
link
unknown
/test integ-operator-controller_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@istio-testing: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-telemetry-istiodremote_istio
0f08f4300ab0f85c092b0d40d965b00411594e4b
link
unknown
/test integ-telemetry-istiodremote_istio

integ-operator-controller_istio
0f08f4300ab0f85c092b0d40d965b00411594e4b
link
unknown
/test integ-operator-controller_istio

integ-pilot-multicluster_istio
0f08f4300ab0f85c092b0d40d965b00411594e4b
link
unknown
/test integ-pilot-multicluster_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@istio-testing: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-telemetry-istiodremote_istio
0f08f4300ab0f85c092b0d40d965b00411594e4b
link
unknown
/test integ-telemetry-istiodremote_istio

integ-operator-controller_istio
0f08f4300ab0f85c092b0d40d965b00411594e4b
link
unknown
/test integ-operator-controller_istio

integ-pilot-multicluster_istio
0f08f4300ab0f85c092b0d40d965b00411594e4b
link
unknown
/test integ-pilot-multicluster_istio

integ-pilot-istiodremote_istio
0f08f4300ab0f85c092b0d40d965b00411594e4b
link
unknown
/test integ-pilot-istiodremote_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@istio-testing: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-telemetry-istiodremote_istio
0f08f4300ab0f85c092b0d40d965b00411594e4b
link
unknown
/test integ-telemetry-istiodremote_istio

integ-operator-controller_istio
0f08f4300ab0f85c092b0d40d965b00411594e4b
link
unknown
/test integ-operator-controller_istio

integ-pilot-multicluster_istio
0f08f4300ab0f85c092b0d40d965b00411594e4b
link
unknown
/test integ-pilot-multicluster_istio

integ-pilot-istiodremote_istio
0f08f4300ab0f85c092b0d40d965b00411594e4b
link
unknown
/test integ-pilot-istiodremote_istio

integ-pilot-istiodremote-mc_istio
0f08f4300ab0f85c092b0d40d965b00411594e4b
link
unknown
/test integ-pilot-istiodremote-mc_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

authors: ericvn istio-testing


text:
fix iop with custom hpa failed

Please provide a description of this PR:
fix: https://github.com/istio/istio/issues/41011
if you install an iop like following:
apiVersion: install.istio.io/v1alpha1
kind: IstioOperator
spec:
  components:
    ingressGateways:
    - enabled: true
      k8s:
        hpaSpec:
          metrics:
          - resource:
              name: cpu
              targetAverageUtilization: 80
            type: Resource
      name: istio-ingressgateway
  values:
    pilot:
      cpu:
        targetAverageUtilization: 80

translateDeprecatedAutoscalingFields will change global.autoscalingv2API to false, and then translateHPASpec override hpa metirc to somehting like following, which is invalid for v1beta1.
- type: Resource
  resource:
    name: cpu
    target:
      type: Utilization
      averageUtilization: %f`

translateHPASpec should not translate configuration if global.autoscalingv2API is false.

@zirain: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
78f669687878e825072dfde9bff7f7bb964a4018
link
true
/test release-notes

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

This may only work if users explicitly define autoscalingv2: false in the IOP spec, which might not be the case most of the time since it servers as an internal settings only. I created: https://github.com/istio/istio/pull/41079 for a fix. PTAL

user can not set autoscalingv2API via IOP, it's an internal setting

@zirain: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

lint_istio
026cdc4c010e5e76fea407c60bb51c26a9504a85
link
true
/test lint

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

replaced by https://github.com/istio/istio/pull/41079

authors: istio-testing richardwxn zirain


text:
WIP: Add manifest translate command

Please provide a description of this PR:
The manifest translate command takes similar arguments to manifest generate, but outputs the Helm values.yaml file needed to perform the equivalent installations with helm.  Critically, helm cannot perform any K8s overlay tasks associated with the IstioOperator input, so those inputs are ignored.  A separate command could be created to postRended k8s overlays in helm, but that will be a separate PR.
At the moment, the output includes a lot of values which appear to be defaults, but are not included in the respective chart values.yaml, which is where defaults are specified.  I will need to add logic to identify implicit defaults and scrub them from the output to keep the output as clean as possible.

@therealmitchconnors: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
ee36db9c987ccccf29b7e4531e7a93ce38c5afdd
link
true
/test release-notes

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@therealmitchconnors: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
ee36db9c987ccccf29b7e4531e7a93ce38c5afdd
link
true
/test release-notes

lint_istio
ee36db9c987ccccf29b7e4531e7a93ce38c5afdd
link
true
/test lint

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

authors: istio-testing therealmitchconnors


text:
Fix otel samples

Please provide a description of this PR:
This is a folllow-up of https://github.com/istio/istio/pull/49143, to make the otel samples working with the demo profile.

cc @zirain


text:
Add health check flag to the Citadel

Enables adding the livenessProbe to the Citadel container.
Fixes #6922

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: ymesika
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: ijsnellf
Assign the PR to them by writing /assign @ijsnellf in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

install/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ymesika: PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

authors: istio-testing ymesika


text:
update base debug docker image reference

This change is

Jenkins job mixer/presubmit passed

authors: ayj istio-testing

repo: istio/mixer


text:
switch to kube client to apply manifest and support kubeconfig context.

Resolve: https://github.com/istio/istio/issues/15844

@morvencao: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

operator-lint-master
ccd1a9cc4250a809c3a151775b7f70ec1db4212c
link
/test operator-lint-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@morvencao: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

operator-lint-master
ccd1a9cc4250a809c3a151775b7f70ec1db4212c
link
/test operator-lint-master

operator-build-master
ccd1a9cc4250a809c3a151775b7f70ec1db4212c
link
/test operator-build-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@morvencao: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

operator-lint-master
ccd1a9cc4250a809c3a151775b7f70ec1db4212c
link
/test operator-lint-master

operator-build-master
ccd1a9cc4250a809c3a151775b7f70ec1db4212c
link
/test operator-build-master

operator-test-master
ccd1a9cc4250a809c3a151775b7f70ec1db4212c
link
/test operator-test-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@morvencao: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

operator-build
789afb8fc8bc5fdb35f912ba6bd0929c21c801f6
link
/test operator-build

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@morvencao: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

operator-build
789afb8fc8bc5fdb35f912ba6bd0929c21c801f6
link
/test operator-build

operator-test
789afb8fc8bc5fdb35f912ba6bd0929c21c801f6
link
/test operator-test

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@morvencao: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

operator-build
789afb8fc8bc5fdb35f912ba6bd0929c21c801f6
link
/test operator-build

operator-test
789afb8fc8bc5fdb35f912ba6bd0929c21c801f6
link
/test operator-test

operator-lint
789afb8fc8bc5fdb35f912ba6bd0929c21c801f6
link
/test operator-lint

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@morvencao: PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@morvencao: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

operator-build
789afb8fc8bc5fdb35f912ba6bd0929c21c801f6
link
/test operator-build

operator-test
789afb8fc8bc5fdb35f912ba6bd0929c21c801f6
link
/test operator-test

operator-lint
789afb8fc8bc5fdb35f912ba6bd0929c21c801f6
link
/test operator-lint

operator-mandiff
789afb8fc8bc5fdb35f912ba6bd0929c21c801f6
link
/test operator-mandiff

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

The --context portion of this PR has been addressed in https://github.com/istio/istio/pull/16392.
Can we use the kubectl binary for the apply implementation until server-side apply is ready? This would simplify the implementation while retaining the existing apply semantics w.r.t patching and pruning. The downside is it would mean the istioctl binary would depend on the kubectl binary in the PATH. cc @esnible on whether he thinks this is a reasonable assumption for istioctl users deploying to Kubernetes.

@ayj I don't understand the question ... this code already uses kubectl.  (This surprised me yesterday when I tested the new subcommands!)

Is it reasonable for istioctl manifest apply to depend on the kubectl binary? The alternative is to implement the equivalent functionality with client-go.

@ayj It is strange that istioctl now depends on a kubectl binary.  Even helm doesn't need kubectl!  However, it seems too late to refactor for 1.3.  istioctl now depends on helm and it would be strange to allow that but complain about kubectl.

I've chatted about this with @morvencao previously and we agree to park this work for the time being and go with the kubectl approach for now. It's a lot more work to replicate the behavior of kubectl apply semantics, especially --prune, so we probably wait until server-side apply is available.

Should we close this PR? It will get quiet out of date before server-apply is available by default.

yes, i think it's a good idea to close it, but i'll let morven decide what he wants to do with it.

I'm OK to close this.

authors: ayj esnible istio-testing morvencao ostromart

repo: istio/operator

license_source: bigquery


text:
[DO NOT MERGE] Auto PR to update dependencies of pilot

This PR will be merged automatically once checks are successful.
none

@istio-testing: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/pilot-presubmit.sh
8e2a031e49f90c38b463abe71cf0ff1aba6bef6f
link
/test pilot-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

repo: istio/pilot


text:
Seeing warnings in ztunnel logs that could cause unnecessary concerns

Happening every 30 mins:
2023-02-15T20:54:40.204428Z  WARN xds{id=1}: ztunnel::xds::client: XDS client error: gRPC error (Unknown error): error reading a body from connection: broken pipe, retrying
2023-02-15T21:24:40.813192Z  WARN xds{id=2}: ztunnel::xds::client: XDS client error: gRPC error (Unknown error): error reading a body from connection: broken pipe, retrying
@howardjohn mentioned this is ztunnel disconnects with istiod every 30 mins so istiod can rebalance and we hide this with Envoy.

This may be useful in debug log?  In default seems it is unnecessary

repo: istio/ztunnel


text:
French translation

hi,
i made french translation, how can i update your project ?

Hello, propose a PR request in Github Desktop (or via command)

i never do that .... how can i do ?
when i try to create a pull request, the button is greyed

On github desktop, do you have checked all box ?

i have a message now : authentication failed, when i send a pull request

Try to disconnect and reconnect again

Now online thanks !

repo: istornz/iPokeGo

license: mit


text:
10.0 ir attachment url ecommerce

related with https://github.com/it-projects-llc/misc-addons/pull/714

This branch has conflicts that must be resolved
Use the web editor or the  to resolve conflicts.
Conflicting files
.travis.yml

superseded by #775

repo: it-projects-llc/misc-addons


text:
Add custom Pageable functionality for order- controller

Realise custom pagination for  /ubs/management/orders controller

repo: ita-social-projects/GreenCity

license: MIT


text:
Investigate options to add auditing into the application

In order to control changes among the data in the application, we have to have history. Please research existing approaches to accomplish it in our application.

https://app.zenhub.com/files/298601645/48ab20d7-c5b8-4897-96a0-9755510637dc/download

repo: ita-social-projects/Home


text:
Create "org card"

Task description
Create "org card".
Component should accept organization object and generate the view.

done

repo: ita-social-projects/OoS-Frontend


text:
Errore EN403 in allineamento dati AE -> ANPR

Arianna Nozzoli Comune di Prato in produzione
Andando su webapp ANPR a fare "Risoluzione disallineamenti con agenzia entrate" riceviamo l'errore EN403 codice operazione 240356568. Il cittadino ha l'anomalia da subentro EC030 come possiamo risolvere? Grazie

Buongiorno, può indicare un recapito telefonico per favore?

E' stato contattato l'utente e fornita l'assistenza richiesta per l'aggiornamento luogo di nascita.
Per problematiche puntuali che richiedono un contatto telefonico si suggerisce di aprire un ticket attraverso il numero verde dedicato.
Grazie
N. Capozzi

authors: anozzoli ncapozzi

repo: italia/anpr


text:
[5008] tipoMutazione 18 (TEST): l'esito del servizio è 0000 ma i dati di unione civile non sono aggiornati

Buongiorno, stiamo provando l'invio di una mutazione per variare i dati di unione civile di un soggetto.
Nonostante l'esito sia positivo i dati non risultano aggiornati (data evento e numero atto).
Ambiente di TEST Comune PISA
ID operazioni 55257943 55257944 55257943 55258151
Potete aiutarci a capire qual è il problema?
Grazie
Monia Pedrazzoli
APKAPPA s.r.l.

Riprovando la variazione ora i dati vengono aggiornati pertanto chiudo la issue


text:
[SC]: Anteprima - Matrimonio: ordine dei firmatari in calce all'atto

Ambiente
produzione
Servizio
R010 - Servizi cooperativi anteprima
idOperazione
66307
idEvento o idAnsc
2024-7790-339-037054
Provenienza segnalazione
Software House
Comune di riferimento e operatore
SAN LAZZARO DI SAVENA
Data del test (yyyy-mm-dd)
2024-04-05
Descrivi il problema
nell'anteprima dell'atto i firmatari vengono in questo ordine:

i testimoni
gli sposi
l'officiante

gli sposi dovrebbero venire prima dei testimoni.
Come riprodurre il problema
No response
Payload (json)
No response

Buongiorno verifichiamo e le facciamo sapere

Buon pomeriggio con il rilascio della versione 1.29.0 la segnalazione è stata corretta. Chiudiamo pertanto la issue

authors: AMonopoliADS asqueglia

repo: italia/ansc


text:
Richiesta di validazione dei metadati - Comune di Correzzana

Buongiorno,
per conto del comune si richiede la verifica e il deploy dei metadati esposti all'URL:
https://sportellotelematico.comune.correzzana.mb.it/simplesaml/module.php/saml/sp/metadata.php/spid

Il Metadata è stato inoltrato verso gli IdP e da essi caricato.

authors: AntonioGiovanniSchiavone globogis

repo: italia/spid


text:
Rotating spell templates stalls the Foundry server

Similar to "BUG: Breaks when rotating token too fast #17".
If I rotate a placed template using shift + mouse wheel too far, regardless of how quickly I'm doing it, zoom/pan options will stall the Foundry server.  Sometimes it recovers after a delay.  Sometimes I have to manually restart the Foundry process.
I narrowed this down to absolutely being within Zoom/Pan Options by disabling modules until I could get to the minimal set that caused this.  This is occurring in module version 1.4.0.  I'm uncertain if this is new to this specific version, but I know I didn't used to have this problem some weeks ago.

Well that's very concerning!  I can't manage to reproduce it, though.
Could you share your options for this module?
i.e. this page:

Also - what is your browser, your foundry version, and does this happen even with no other modules running?

Screenshot taken while I have my normal modules enabled, but I did confirm this happened with as little as Zoom/Pan Options and "Tidy UI - Game Settings".  I've also now seen it from Firefox on Windows 10, and Firefox on Linux Mint.
I'll email you a URL and user/password for a guest player to see if it repros for you there.  This is on a server that runs 24/7, though I do occasionally back out of the world to update modules, etc.

Fixed, in 1.5.0, hopefully.  If not, reopen the ticket.  Thanks a lot for giving me access to your server to help debug it, even though at the end I think I found the problem just by looking at the code differences (Foundry has added some code to rate-limit rotations).

Confirmed the fix in 1.5.0!  Thanks much!  :)

authors: Akaito itamarcu

repo: itamarcu/ZoomPanOptions


text:
Outlet instead of Switch?

Hi,
is it possible to change the device type from switch to outlet?
thx, Chris

Not a bug, as it is simply not supported at the moment.
Possible duplicate of #45 / #279.

Hi,
thx, for the answer. And sorry, I can't found a correct tag for my questions thus I used "bug".
Do you plan to support this feature in the future? Also a device renaming would be ingenious.
BTW, I love you plugin. very good job.
br, chris

Do you plan to support this feature in the future?

I'm not against it, but as mentioned in #45, it doesn't really have a high priority to me. I don't see what the real benefit would be, at least not within how I use HomeKit/Siri (but your use cases might be different of course).
Therefor I'm open for suggestions/PRs from others to provide such functionality in a generic way, without breaking backwards compatibility for users that don't care about this.

Also a device renaming would be ingenious.

Not sure what you mean by this?
You can rename devices in the frontend of Zigbee2MQTT and/or via the HomeKit app (these are not synced however).
If you change a name in the Zigbee2MQTT frontend, it should automatically be picked up by this plugin and if you have not set a custom name in the HomeKit app, it should also propogate there.
As mentioned in #76, you might have to restart Homebridge for HomeKit to also pick up the new name for some reason.

BTW, I love you plugin. very good job.

Thank you. Glad you enjoy it!

Hi,
you are right. No benefit, only optic ;)
Other plugins support this feature.
Homematic: "outlets": [ "HmIP-RF.00021A4995E371:3","BidCos-RF.LEQ0532532:1","BidCos-RF.LEQ1344292:1" ]
I have no clue how complex this is.
Rename:
I have about over 70 zigbee devices in my configuration.yaml file with a own name schema. I used this in my node red config.
The name schema is not Homekit friendly thus I must rename the devices in the Homekit App. Is not user friendly on phone ;)
But again I have no idea how complicated this is.
thx for your time, Chris

hi, yes. thx. this issue can be close.

authors: cnekola itavero


text:
🛑 GPTW CARCA is down

In 3ae1020, GPTW CARCA (https://greatplacetoworkcarca.com/es) was down:

HTTP code: 0
Response time: 0 ms

Resolved: GPTW CARCA is back up in aa2b9bb after 8 minutes.

repo: itbm-services/projects


text:
Replace package satori/go.uuid

This issue has been opened automaticaly because we think you are using satori/uuid in your code. Unfortunately, satori/uuid has a critical defect where it doesn't generate random UUIDV4s satori/go.uuid#73 and should be replaced as the maintainer has been unresponsive for 5 months with the bug still open. Alternative packages you should consider: https://github.com/google/uuid https://github.com/pborman/uuid

Thanks for the heads up, I just switched to github.com/google/uuid. :+1:

authors: fasterthanlime josselin-c

repo: itchio/butler


text:
Fix errors around collab settlement and rollover

There were multiple cases where we would stop trying to finish a protocol instead of appending a "failed" event.
See commits for details (and new tests).

I am not sure about the test that shows the rollover bug... I think we should rather have a failing test (and potentially ignore it, if you don't want to fix it here...).

I added the test as it fixes a concrete problem (that's why I wanted to keep it active) - the fact that it uncovered a different weirdness is orthogonal to this PR.

bors r+

repo: itchysats/itchysats


text:
Another auto rollover

After discussion with @thomaseizinger we decided to put the rollover logic on the cfd and unit-test it.
Auto-rollover actually only depends on the cfd expiry. We hardcode the roll-over offset as 1 hour for the moment. The unit-tests should cover all bounds and should help understand the logic. (If not please scream :)
Auto-rollover itself is not tested as part of the actor tests. The unit tests should cover the logic. The rest is just wiring things together and should not require testing.
We are adding an actor test for ProposeRollover (to test the logic related to rollover itself - accept, reject...) in a follow up PR. This test will be triggered through sending the ProposeRollover message to the actor in the tests.
In the production code we don't send this message to the cfd actor from the outside (it is triggered internally upon auto-rollover).

After discussion with @thomaseizinger we decided to put the rollover logic on the cfd and unit-test it.
Auto-rollover itself is not tested as part of the actor tests. The unit tests should cover the logic. The rest is just wiring things together and should not require testing.
We are adding a test for ProposeRollover (to test the logic related to rollover itself - accept, reject...) in a follow up PR though. This test will be triggered through sending the ProposeRollover message to the actor in the tests.
In the production code we don't send this message to the cfd actor from the outside (it is triggered internally upon auto-rollover).

somehow the logic is still messed up. sry, needs another round

somehow the logic is still messed up. sry, needs another round

correction, the logic seems to be correct (the unit tests are sane - we still improved them...), but the behavior is still not what is expected. Have to dig deeper and see if we pick the oracle event correctly when rolling over.

Unfortunately we found a severe problem: Roll over actually is incomplete and  a non-collaborative close would have never worked on the current implementation of rollover (master).
The problem is, that we never update the oracle event id that we use for rollover in the cfd's data. the only oracle event id that is actually stored in the database is the initial one that is stored as part of the order.
That's probably why on some instances we see problems like this #644
At this point I think we have to take a step back and start tackling the cfd model restructuring, otherwise this will be a never ending story.
What we have to do is don't use the Order as source of the event_id on the cfd, but put the event_id on the Cfd itself (in the database as well). This will require updating the Cfd and not updating the state.
Introducing the event_id into the state is not a good idea, it won't help and will make our current state handling even more messy.
@scratchscratchscratchy @itchymax

Outdated, will tackle feature once new model is introduced.

authors: da-kami thomaseizinger


text:
cmd ref: explain remote://myremote notation in import & run

[x] import/get-url
[ ] run
[ ] add

Also dvc add remote://

I unchecked "import" above.

Actually this only applies to import/get-url right? And it's explained in those already. So only add and run are pending (only mentioned for those in the external data guides ATM).

only mentioned for those in the external data guides

After reviewing the add and run refs I see they link to those guides in the appropriate places so I'm not seeing a need to explain remote:// directly in them. We don't go over all the other URLs either. But lmk if you have a specific idea on how else to address this!

authors: efiop jorgeorpinel


text:
fix issue template

Fix https://github.com/iterative/dvc.org/pull/3636

Per https://docs.github.com/en/communities/using-templates-to-encourage-useful-issues-and-pull-requests/syntax-for-issue-forms#top-level-syntax

Hmmm this is not what I wanted to push...

This was a test for pull request template 🤦🏼

See https://github.com/iterative/dvc.org/pull/3689


text:
[WIP] Add interactive button to run get-started/ tutorials as Google Colabs, Katacoda, Kaggle kernels, etc. #670

This is a first draft for the feature then we show links to tutorials in the sidebar.
We can add links to tutorials to the sidebar.json file now like that:
tutorials: {
  katacoda: "https://www.katacoda.com/loodse/courses/docker/docker-02-install"
}

I assume for now that we will only have one tutorial link per site. If it is not correct, we will need to change the structure.
Links will be shown in the right panel on the documentation page under the list of headers. If the tutorial's key is in the list of known sites, an icon will be shown before it (right now, I only added katacoda.com icon).
You can check how it looks right now at the /doc/get-started/connect-code-and-data page.
ToDo:

[ ] Update design.
[ ] Add multiple tutorial site icons. (And somehow decide how we can get icons that we can use according to copyright).
[ ] Replace an example link with the real links to the tutorials.

Direct link to example: https://dvc-org-pr-824.herokuapp.com/doc/get-started/connect-code-and-data

I don't see a good place for explicit links - before content they distract too much, after content they are not visible.
I think PR deprecates the one here https://github.com/iterative/dvc.org/pull/786 . If we'll need multiple buttons, or a button per example we'll use links and/or add a special syntax.

@shcheklein Replaced tutorials to the ones from #786, updated link to look like button, made katacoda icon larger.
What should we write in the tooltip?

Let's change screen icon with a play button icon.
Tooltip. Do you mean that "Need a tutorial?" text? I would replace it with "It can be run online".
We need to do something with a mobile version. As I suggested let's show an icon close to the main title.
@dashohoxha @jorgeorpinel what do you think, is the current button visible enough?

what do you think

I don't really have anything to say, other than @iAdramelk has done a nice job.

Added mobile styles for the tutorial buttons and changed icon+text for the right column.

@iAdramelk looks great! One issue I see is that button is not clickable on the mobile version, some minor bug probably.

Also, please rebase/merge.

Should the description say "Fixes #670"?

Direct link to example: https://dvc-org-pr-824.herokuapp.com/doc/get-started/connect-code-and-data
@jorgeorpinel what do you think, is the current button visible enough?

I don't see the button at the moment. Please lmk when to review. 🙂

@jorgeorpinel check this link - https://dvc-org-pr-824.herokuapp.com/doc/get-started :)

Fixed bug with unclickable buttons, and rebased branch to master.

@iAdramelk looks great!
Out of three checkboxes what are still pending? I'm not sure I understand the Add multiple tutorial site icons.
Update design, I assume, is done, right?

@shcheklein  If we are ok with the design, we can check design item out.
Add multiple tutorial site icons –  it is about different possible platforms that we can use in the future. Right now I only added Katacoda icon, but I didn't add icons for Kaggle, Google Collabs and other platforms. Not sure if we need them right now through.
Replace an example link with the real links to the tutorials. – I transferred 4 links that I know about from the other PR. But I'm not sure if I found and added all of the existing tutorials on Katacoda.

But I'm not sure if I found and added all of the existing tutorials on Katacoda.

Right now there are also these corresponding Katacoda tutorials that you might add:

https://dvc.org/doc/tutorials/versioning --> https://katacoda.com/dvc/courses/tutorials/versioning
https://dvc.org/doc/tutorials/pipelines --> https://katacoda.com/dvc/courses/tutorials/pipelines
https://dvc.org/doc/tutorials/deep --> https://katacoda.com/dvc/courses/tutorials/pipelines

@iAdramelk you might also need to fix this PR by adding interactive buttons to the corresponding pages: https://github.com/iterative/dvc.org/pull/784
But I am not sure, you may need approval for doing this.
Anyways, it might be better to wait until that PR is merged (if it is merged) and add the interactive buttons later.

@dashohoxha added links to the three pages above (same link for pipelines and deep). Will skip #784 for now.

@dashohoxha I would also probably add button to some get started sections to point to specific Get Started interactive tutorials? That was the idea, right?

@iAdramelk
Thanks : 🙏

Not sure if we need them right now through.

we don't need them now

Replace an example link with the real links to the tutorials.

No need to do all the links as part of this PR. This is about engine in the first place.

authors: dashohoxha iAdramelk jorgeorpinel shcheklein


text:
Update web.go

Przetłumaczyłem trochę i chyba dobrze.

Poprawa błędów t.

repo: itsChix/policjant


text:
Processing channel clones too fast, results in rate limit

No matter what delay I set in config, once it reaches "Processing channels clone" part, it does it too quickly resulting in rate limited. How can this be solved?

ok i fixed that shit, thank you for submitting issue and help investigate problem.

It fixed the channel clone speed, but now the same issue is happening again once it starts processing emoji.

ok i fixed that shit, thank you for submitting issue and help investigate problem.

I have skipped emojis this time setting it to false. The message cloning works fine so far with the webhook, it skips certain messages, but otherwise emojis are still a problem. But that is not so important.

yes, my wrong. Fixed.

repo: itskekoff/discord-server-copy


text:
Help me how to make him start copying messages

I have all the channels copied and the message is not just stuck on [GTA 5 RP | EMS/INFO] | Processing server messages... Help me figure it out

I am having the same issue.
On a quick debug, I have found two things. Not sure if it is fully correct.

if the queue is enabled, it does not seem to be going for the history.
tasks.append(self.clone_channel_messages(channel, limit, clear))
is not called in
if self.clone_parallel and self.clone_queue:

It actually reads the message and reaches the semaphore_task and is awaiting
func(*args, **kwargs)

And how to fix it ?

I don't know either. I was hoping someone would help. Just added my findings. That's all.

Your messages are adding to queue, u can disable queue and messages will copy immediately

I did try with queue disabled, but without avail.

authors: Germanso88 itskekoff jacobjonz


text:
Remove DeferredElementImpl from ParserBase and fix Room database compiler error

We used the internal Java DeferredElementImpl class, this PR removed it from ParserBase.

IllegalAccessError: cannot access class com.sun.org.apache.xerces.internal.dom.DeferredElementImpl

Fix Room database compiler error by adding an extra attribute in @Database.

@reactormonk Sure will work on this.

@reactormonk The fix was released in v2.2.1, please try it out. https://github.com/ivanisidrowu/KtRssReader/releases/tag/v2.2.1

repo: ivanisidrowu/KtRssReader