text:
Status bar not responding to setEnabledSyustemUiMode Android 11

Steps to Reproduce

Have a device with android 11 or create virtual device with android 11.
create fresh new flutter project
add   SystemChrome.setEnabledSystemUIMode(SystemUiMode.immersiveSticky); to main.dart file
Run project on device
Status does not hide on app startup.

Expected results:
I expected the status bar to hide automatically.
Actual results:
Status bar does not hide. The only way I was able to get it to hide was by moving the  SystemChrome.setEnabledSystemUIMode(SystemUiMode.immersiveSticky); to the build section of the widget and this leaves behind a black bar taking up the space of the status bar. On android 10 upon placing this line of code in the build function you are able to correctly hide the status bar. Although moving the code to the line above runApp(constMyApp()); the status bar does not hide in both 11 and 10.
Correctly working code Android 10
import 'package:flutter/services.dart';

void main() {
  runApp(const MyApp());
}

class MyApp extends StatelessWidget {
  const MyApp({Key? key}) : super(key: key);

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Flutter Demo',
      theme: ThemeData(
        primarySwatch: Colors.blue,
      ),
      home: const MyHomePage(title: 'Flutter Demo Home Page'),
    );
  }
}

class MyHomePage extends StatefulWidget {
  const MyHomePage({Key? key, required this.title}) : super(key: key);
  final String title;

  @override
  State<MyHomePage> createState() => _MyHomePageState();
}

class _MyHomePageState extends State<MyHomePage> {
  int _counter = 0;

  void _incrementCounter() {
    setState(() {
      _counter++;
    });
  }

  @override
  Widget build(BuildContext context) {
    SystemChrome.setEnabledSystemUIMode(SystemUiMode.immersiveSticky);

    return Scaffold(
      appBar: AppBar(
        title: Text(widget.title),
      ),
      body: Center(
        child: Column(
          mainAxisAlignment: MainAxisAlignment.center,
          children: <Widget>[
            const Text(
              'You have pushed the button this many times:',
            ),
            Text(
              '$_counter',
              style: Theme.of(context).textTheme.headline4,
            ),
          ],
        ),
      ),
      floatingActionButton: FloatingActionButton(
        onPressed: _incrementCounter,
        tooltip: 'Increment',
        child: const Icon(Icons.add),
      ), // This trailing comma makes auto-formatting nicer for build methods.
    );
  }
}

InCorrectly working code Android 11 and 10
import 'package:flutter/services.dart';

void main() {
    SystemChrome.setEnabledSystemUIMode(SystemUiMode.immersiveSticky);
  runApp(const MyApp());
}

class MyApp extends StatelessWidget {
  const MyApp({Key? key}) : super(key: key);

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Flutter Demo',
      theme: ThemeData(
        primarySwatch: Colors.blue,
      ),
      home: const MyHomePage(title: 'Flutter Demo Home Page'),
    );
  }
}

class MyHomePage extends StatefulWidget {
  const MyHomePage({Key? key, required this.title}) : super(key: key);
  final String title;

  @override
  State<MyHomePage> createState() => _MyHomePageState();
}

class _MyHomePageState extends State<MyHomePage> {
  int _counter = 0;

  void _incrementCounter() {
    setState(() {
      _counter++;
    });
  }

  @override
  Widget build(BuildContext context) {

    return Scaffold(
      appBar: AppBar(
        title: Text(widget.title),
      ),
      body: Center(
        child: Column(
          mainAxisAlignment: MainAxisAlignment.center,
          children: <Widget>[
            const Text(
              'You have pushed the button this many times:',
            ),
            Text(
              '$_counter',
              style: Theme.of(context).textTheme.headline4,
            ),
          ],
        ),
      ),
      floatingActionButton: FloatingActionButton(
        onPressed: _incrementCounter,
        tooltip: 'Increment',
        child: const Icon(Icons.add),
      ), // This trailing comma makes auto-formatting nicer for build methods.
    );
  }
}

flutter run --verbose
[  +50 ms] executing: [D:\flutter/] git -c log.showSignature=false log -n 1 --pretty=format:%H
[ +204 ms] Exit code 0 from: git -c log.showSignature=false log -n 1 --pretty=format:%H
[   +1 ms] 18116933e77adc82f80866c928266a5b4f1ed645
[        ] executing: [D:\flutter/] git tag --points-at 18116933e77adc82f80866c928266a5b4f1ed645
[  +27 ms] Exit code 0 from: git tag --points-at 18116933e77adc82f80866c928266a5b4f1ed645
[        ] 2.5.3
[   +6 ms] executing: [D:\flutter/] git rev-parse --abbrev-ref --symbolic @{u}
[  +40 ms] Exit code 0 from: git rev-parse --abbrev-ref --symbolic @{u}
[        ] origin/stable
[        ] executing: [D:\flutter/] git ls-remote --get-url origin
[  +19 ms] Exit code 0 from: git ls-remote --get-url origin
[        ] https://github.com/flutter/flutter.git
[  +98 ms] executing: [D:\flutter/] git rev-parse --abbrev-ref HEAD
[  +40 ms] Exit code 0 from: git rev-parse --abbrev-ref HEAD
[        ] stable
[  +48 ms] Artifact Instance of 'AndroidGenSnapshotArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'AndroidInternalBuildArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'IOSEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'FlutterWebSdk' is not required, skipping update.
[   +2 ms] Artifact Instance of 'WindowsEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'WindowsUwpEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'MacOSEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'LinuxEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'LinuxFuchsiaSDKArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'MacOSFuchsiaSDKArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'FlutterRunnerSDKArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'FlutterRunnerDebugSymbols' is not required, skipping update.
[  +38 ms] executing: C:\Users\deleo\AppData\Local\Android\sdk\platform-tools\adb.exe devices -l
[  +28 ms] List of devices attached
           R5CN213S5HK            device product:y2qsqw model:SM_G986U device:y2q transport_id:1
           emulator-5554          device product:sdk_gphone_x86 model:Android_SDK_built_for_x86 device:generic_x86
           transport_id:5
[   +7 ms] C:\Users\deleo\AppData\Local\Android\sdk\platform-tools\adb.exe -s R5CN213S5HK shell getprop
[  +81 ms] C:\Users\deleo\AppData\Local\Android\sdk\platform-tools\adb.exe -s emulator-5554 shell getprop
[  +22 ms] Artifact Instance of 'AndroidInternalBuildArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'IOSEngineArtifacts' is not required, skipping update.
[   +6 ms] Artifact Instance of 'WindowsEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'WindowsUwpEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'MacOSEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'LinuxEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'LinuxFuchsiaSDKArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'MacOSFuchsiaSDKArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'FlutterRunnerSDKArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'FlutterRunnerDebugSymbols' is not required, skipping update.
[  +50 ms] Multiple devices found:
[   +3 ms] ro.hardware = qcom
[   +1 ms] ro.hardware = ranchu
[  +22 ms] SM G986U (mobile)                  • R5CN213S5HK   • android-arm64  • Android 11 (API 30)
[   +1 ms] Android SDK built for x86 (mobile) • emulator-5554 • android-x86    • Android 10 (API 29) (emulator)
[   +1 ms] Chrome (web)                       • chrome        • web-javascript • Google Chrome 95.0.4638.54
[        ] Edge (web)                         • edge          • web-javascript • Microsoft Edge 94.0.992.50
[   +1 ms] [1]: SM G986U (R5CN213S5HK)
[        ] [2]: Android SDK built for x86 (emulator-5554)
[        ] [3]: Chrome (chrome)
[        ] [4]: Edge (edge)
[   +1 ms] Please choose one (To quit, press "q/Q")
[        ] :

flutter doctor -v
[√] Flutter (Channel stable, 2.5.3, on Microsoft Windows [Version 10.0.19043.1288], locale en-US)
    • Flutter version 2.5.3 at D:\flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 18116933e7 (8 days ago), 2021-10-15 10:46:35 -0700
    • Engine revision d3ea636dc5
    • Dart version 2.14.4

[√] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
    • Android SDK at C:\Users\deleo\AppData\Local\Android\sdk
    • Platform android-31, build-tools 31.0.0
    • Java binary at: C:\Users\deleo\AppData\Local\JetBrains\Toolbox\apps\AndroidStudio\ch-0\203.7784292\jre\bin\java
    • Java version OpenJDK Runtime Environment (build 11.0.10+0-b96-7249189)
    • All Android licenses accepted.

[√] Chrome - develop for the web
    • Chrome at C:\Program Files\Google\Chrome\Application\chrome.exe

[√] Android Studio (version 2020.3)
    • Android Studio at C:\Users\deleo\AppData\Local\JetBrains\Toolbox\apps\AndroidStudio\ch-0\203.7784292
    • Flutter plugin can be installed from:
       https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
       https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.10+0-b96-7249189)

[√] VS Code, 64-bit edition (version 1.61.2)
    • VS Code at C:\Program Files\Microsoft VS Code
    • Flutter extension can be installed from:
       https://marketplace.visualstudio.com/items?itemName=Dart-Code.flutter

[√] Connected device (4 available)
    • SM G986U (mobile)                  • R5CN213S5HK   • android-arm64  • Android 11 (API 30)
    • Android SDK built for x86 (mobile) • emulator-5554 • android-x86    • Android 10 (API 29) (emulator)
    • Chrome (web)                       • chrome        • web-javascript • Google Chrome 95.0.4638.54
    • Edge (web)                         • edge          • web-javascript • Microsoft Edge 94.0.992.50

• No issues found!

Android 11 code above runApp(const MyApp())

Android 11 code in build function

Without additional information, we are unfortunately not sure how to resolve this issue.
We are therefore reluctantly going to close this bug for now.
Please don't hesitate to comment on the bug if you have any more information for us; we will reopen it right away!
Thanks for your contribution.
Could everyone who still has this problem please file a new issue with the exact description of what happens, logs, and the output of flutter doctor -v.
All system setups can be slightly different, so it's always better to open new issues and reference related issues.

authors: danagbemava-nc joshuaanthonydeleon


text:
[web] [canvaskit] Resizing the browser is janky

Steps to Reproduce

Run the given sample code.
Resize the window as in the videos below.
Observe the behavior

To observe the behavior again, simply refresh the page or hot reload if in debug mode.

Note:  the issue only occurs after the first time that window was fully resized and it doesn't appear again unless the page was refreshed.
Actual results: (from --web-renderer=canvaskit in release mode)
https://user-images.githubusercontent.com/46427323/144128011-87430890-54bd-42d1-a42d-c167d1325159.mov
Here's an example where there's nothing but a background color:
https://user-images.githubusercontent.com/46427323/144127134-13c0fa89-5a75-4174-91e0-dd7b9e0b7d81.mov
Expected results: (from --web-renderer=html in debug mode)
https://user-images.githubusercontent.com/46427323/144128036-dd6c8460-a5b9-4da2-b2db-e50944e451ae.mov

Fully Runnable Code sample
import 'package:flutter/material.dart';

void main() {
  runApp(const MyApp());
}

class MyApp extends StatelessWidget {
  const MyApp({Key? key}) : super(key: key);
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
        title: 'Resizing Web Jank',
        theme: ThemeData(
          primarySwatch: Colors.blue,
        ),
        debugShowCheckedModeBanner: false,
        home: const ResizingJank());
  }
}

class ResizingJank extends StatelessWidget {
  const ResizingJank({Key? key}) : super(key: key);
  @override
  Widget build(BuildContext context) {
    return Scaffold(
      backgroundColor: Colors.yellow,
      body: ListView(
        children: List.generate(
            10,
            (index) => Padding(
                  padding: const EdgeInsets.all(8.0),
                  child: Container(
                    height: 100,
                    width: 100,
                    color: Colors.blue,
                  ),
                )),
      ),
    );
  }
}

Flutter Doctor
[✓] Flutter (Channel stable, 2.5.3, on macOS 11.6 20G165 darwin-x64, locale en)
    • Flutter version 2.5.3 at /Users/osaxma/fvm/versions/stable
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 18116933e7 (7 weeks ago), 2021-10-15 10:46:35 -0700
    • Engine revision d3ea636dc5
    • Dart version 2.14.4

[!] Android toolchain - develop for Android devices (Android SDK version 29.0.2)
    • Android SDK at /Users/osaxma/Library/Android/sdk
    ✗ cmdline-tools component is missing
      Run `path/to/sdkmanager --install "cmdline-tools;latest"`
      See https://developer.android.com/studio/command-line for more details.
    ✗ Android license status unknown.
      Run `flutter doctor --android-licenses` to accept the SDK licenses.
      See https://flutter.dev/docs/get-started/install/macos#android-setup for more details.

[✓] Xcode - develop for iOS and macOS
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 12.5.1, Build version 12E507
    • CocoaPods version 1.11.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)

[✓] VS Code (version 1.62.3)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.28.0

[✓] Connected device (2 available)
    • macOS (desktop) • macos  • darwin-x64     • macOS 11.6 20G165 darwin-x64
    • Chrome (web)    • chrome • web-javascript • Google Chrome 96.0.4664.55

! Doctor found issues in 1 category.

Reproducible using sample provided by OP above.
The jank seems to stop after a few resizes. The jank is only experienced with canvaskit, html works just fine.
Possibly related: https://github.com/flutter/flutter/issues/77084
Profile canvaskit.json.zip

videos
html
https://user-images.githubusercontent.com/88313112/144206234-100f398f-1c56-4017-9fc4-2b21fee2ff60.mov
canvaskit
https://user-images.githubusercontent.com/88313112/144206506-348e43f9-9fcc-4d3f-a86d-5174c569a526.mov

flutter doctor -v
[✓] Flutter (Channel stable, 2.5.3, on macOS 11.6 20G165 darwin-arm, locale en-GB)
    • Flutter version 2.5.3 at /Users/nexus/dev/sdks/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 18116933e7 (7 weeks ago), 2021-10-15 10:46:35 -0700
    • Engine revision d3ea636dc5
    • Dart version 2.14.4

[✓] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
    • Android SDK at /Users/nexus/Library/Android/sdk
    • Platform android-31, build-tools 31.0.0
    • Java binary at: /Applications/Android Studio.app/Contents/jre/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.10+0-b96-7249189)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 13.0, Build version 13A233
    • CocoaPods version 1.11.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2020.3)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.10+0-b96-7249189)

[☠] IntelliJ IDEA Community Edition (the doctor check crashed)
    ✗ Due to an error, the doctor check did not complete. If the error message below is not helpful, please let us know about this issue at https://github.com/flutter/flutter/issues.
    ✗ FormatException: Unexpected extension byte (at offset 5)
    • #0      _Utf8Decoder.convertSingle (dart:convert-patch/convert_patch.dart:1788:7)
      #1      Utf8Decoder.convert (dart:convert/utf.dart:318:42)
      #2      InputStream.readString (package:archive/src/util/input_stream.dart:199:30)
      #3      new ZipDirectory.read (package:archive/src/zip/zip_directory.dart:40:30)
      #4      ZipDecoder.decodeBuffer (package:archive/src/zip_decoder.dart:19:30)
      #5      ZipDecoder.decodeBytes (package:archive/src/zip_decoder.dart:14:12)
      #6      IntelliJPlugins._findPluginXml (package:flutter_tools/src/intellij/intellij.dart:130:44)
      #7      IntelliJPlugins._readPackageVersion (package:flutter_tools/src/intellij/intellij.dart:141:40)
      #8      IntelliJPlugins.validatePackage (package:flutter_tools/src/intellij/intellij.dart:63:35)
      #9      IntelliJValidator.validate (package:flutter_tools/src/intellij/intellij_validator.dart:103:15)
      #10     asyncGuard.<anonymous closure> (package:flutter_tools/src/base/async_guard.dart:111:32)
      #11     asyncGuard.<anonymous closure> (package:flutter_tools/src/base/async_guard.dart:109:18)
      #12     _rootRun (dart:async/zone.dart:1428:13)
      #13     _CustomZone.run (dart:async/zone.dart:1328:19)
      #14     _runZoned (dart:async/zone.dart:1863:10)
      #15     runZonedGuarded (dart:async/zone.dart:1851:12)
      #16     runZoned (dart:async/zone.dart:1782:12)
      #17     asyncGuard (package:flutter_tools/src/base/async_guard.dart:109:3)
      #18     Doctor.startValidatorTasks (package:flutter_tools/src/doctor.dart:200:9)
      #19     Doctor.diagnose (package:flutter_tools/src/doctor.dart:304:47)
      #20     DoctorCommand.runCommand (package:flutter_tools/src/commands/doctor.dart:50:47)
      #21     FlutterCommand.verifyThenRunCommand (package:flutter_tools/src/runner/flutter_command.dart:1274:12)
      <asynchronous suspension>
      #22     FlutterCommand.run.<anonymous closure> (package:flutter_tools/src/runner/flutter_command.dart:1125:27)
      <asynchronous suspension>
      #23     AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:150:19)
      <asynchronous suspension>
      #24     CommandRunner.runCommand (package:args/command_runner.dart:209:13)
      <asynchronous suspension>
      #25     FlutterCommandRunner.runCommand.<anonymous closure> (package:flutter_tools/src/runner/flutter_command_runner.dart:288:9)
      <asynchronous suspension>
      #26     AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:150:19)
      <asynchronous suspension>
      #27     FlutterCommandRunner.runCommand (package:flutter_tools/src/runner/flutter_command_runner.dart:236:5)
      <asynchronous suspension>
      #28     run.<anonymous closure>.<anonymous closure> (package:flutter_tools/runner.dart:62:9)
      <asynchronous suspension>
      #29     AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:150:19)
      <asynchronous suspension>
      #30     main (package:flutter_tools/executable.dart:92:3)
      <asynchronous suspension>

[✓] VS Code (version 1.62.3)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.28.0

[✓] Connected device (2 available)
    • macOS (desktop) • macos  • darwin-arm64   • macOS 11.6 20G165 darwin-arm
    • Chrome (web)    • chrome • web-javascript • Google Chrome 96.0.4664.55

! Doctor found issues in 1 category.

[✓] Flutter (Channel master, 2.6.0-12.0.pre.868, on macOS 11.6 20G165 darwin-arm, locale en-GB)
    • Flutter version 2.6.0-12.0.pre.868 at /Users/nexus/dev/sdks/flutters
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision fff85f9c57 (5 hours ago), 2021-11-30 23:09:05 -0500
    • Engine revision c2fcadef89
    • Dart version 2.16.0 (build 2.16.0-56.0.dev)
    • DevTools version 2.8.0

[✓] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
    • Android SDK at /Users/nexus/Library/Android/sdk
    • Platform android-31, build-tools 31.0.0
    • Java binary at: /Applications/Android Studio.app/Contents/jre/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.10+0-b96-7249189)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 13.0)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • CocoaPods version 1.11.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2020.3)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.10+0-b96-7249189)

[☠] IntelliJ IDEA Community Edition (the doctor check crashed)
    ✗ Due to an error, the doctor check did not complete. If the error message below is not helpful, please let us know about this issue at https://github.com/flutter/flutter/issues.
    ✗ FormatException: Unexpected extension byte (at offset 5)
    • #0      _Utf8Decoder.convertSingle (dart:convert-patch/convert_patch.dart:1789:7)
      #1      Utf8Decoder.convert (dart:convert/utf.dart:351:42)
      #2      InputStream.readString (package:archive/src/util/input_stream.dart:207:30)
      #3      new ZipDirectory.read (package:archive/src/zip/zip_directory.dart:40:30)
      #4      ZipDecoder.decodeBuffer (package:archive/src/zip_decoder.dart:19:30)
      #5      ZipDecoder.decodeBytes (package:archive/src/zip_decoder.dart:14:12)
      #6      IntelliJPlugins._findPluginXml (package:flutter_tools/src/intellij/intellij.dart:130:44)
      #7      IntelliJPlugins._readPackageVersion (package:flutter_tools/src/intellij/intellij.dart:141:40)
      #8      IntelliJPlugins.validatePackage (package:flutter_tools/src/intellij/intellij.dart:63:35)
      #9      IntelliJValidator.validate (package:flutter_tools/src/intellij/intellij_validator.dart:103:15)
      #10     asyncGuard.<anonymous closure> (package:flutter_tools/src/base/async_guard.dart:111:32)
      #11     asyncGuard.<anonymous closure> (package:flutter_tools/src/base/async_guard.dart:109:18)
      #12     _rootRun (dart:async/zone.dart:1426:13)
      #13     _CustomZone.run (dart:async/zone.dart:1328:19)
      #14     _runZoned (dart:async/zone.dart:1861:10)
      #15     runZonedGuarded (dart:async/zone.dart:1849:12)
      #16     runZoned (dart:async/zone.dart:1780:12)
      #17     asyncGuard (package:flutter_tools/src/base/async_guard.dart:109:3)
      #18     Doctor.startValidatorTasks (package:flutter_tools/src/doctor.dart:198:9)
      #19     Doctor.diagnose (package:flutter_tools/src/doctor.dart:302:47)
      #20     DoctorCommand.runCommand (package:flutter_tools/src/commands/doctor.dart:50:48)
      #21     FlutterCommand.verifyThenRunCommand (package:flutter_tools/src/runner/flutter_command.dart:1320:12)
      <asynchronous suspension>
      #22     FlutterCommand.run.<anonymous closure> (package:flutter_tools/src/runner/flutter_command.dart:1161:27)
      <asynchronous suspension>
      #23     AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:150:19)
      <asynchronous suspension>
      #24     CommandRunner.runCommand (package:args/command_runner.dart:209:13)
      <asynchronous suspension>
      #25     FlutterCommandRunner.runCommand.<anonymous closure> (package:flutter_tools/src/runner/flutter_command_runner.dart:281:9)
      <asynchronous suspension>
      #26     AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:150:19)
      <asynchronous suspension>
      #27     FlutterCommandRunner.runCommand (package:flutter_tools/src/runner/flutter_command_runner.dart:229:5)
      <asynchronous suspension>
      #28     run.<anonymous closure>.<anonymous closure> (package:flutter_tools/runner.dart:62:9)
      <asynchronous suspension>
      #29     AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:150:19)
      <asynchronous suspension>
      #30     main (package:flutter_tools/executable.dart:94:3)
      <asynchronous suspension>

[✓] VS Code (version 1.62.3)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.28.0

[✓] Connected device (2 available)
    • macOS (desktop) • macos  • darwin-arm64   • macOS 11.6 20G165 darwin-arm
    • Chrome (web)    • chrome • web-javascript • Google Chrome 96.0.4664.55

! Doctor found issues in 1 category.

[✓] Flutter (Channel beta, 2.8.0-3.1.pre, on macOS 11.6 20G165 darwin-arm, locale en-GB)
    • Flutter version 2.8.0-3.1.pre at /Users/nexus/dev/sdks/flutter_beta
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 3dab555040 (3 weeks ago), 2021-11-12 11:50:00 -0800
    • Engine revision 09f1520e8b
    • Dart version 2.15.0 (build 2.15.0-268.8.beta)

[✓] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
    • Android SDK at /Users/nexus/Library/Android/sdk
    • Platform android-31, build-tools 31.0.0
    • Java binary at: /Applications/Android Studio.app/Contents/jre/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.10+0-b96-7249189)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 13.0)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • CocoaPods version 1.11.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2020.3)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.10+0-b96-7249189)

[☠] IntelliJ IDEA Community Edition (the doctor check crashed)
    ✗ Due to an error, the doctor check did not complete. If the error message below is not helpful, please let us know about this issue at https://github.com/flutter/flutter/issues.
    ✗ FormatException: Unexpected extension byte (at offset 5)
    • #0      _Utf8Decoder.convertSingle (dart:convert-patch/convert_patch.dart:1789:7)
      #1      Utf8Decoder.convert (dart:convert/utf.dart:318:42)
      #2      InputStream.readString (package:archive/src/util/input_stream.dart:207:30)
      #3      new ZipDirectory.read (package:archive/src/zip/zip_directory.dart:40:30)
      #4      ZipDecoder.decodeBuffer (package:archive/src/zip_decoder.dart:19:30)
      #5      ZipDecoder.decodeBytes (package:archive/src/zip_decoder.dart:14:12)
      #6      IntelliJPlugins._findPluginXml (package:flutter_tools/src/intellij/intellij.dart:130:44)
      #7      IntelliJPlugins._readPackageVersion (package:flutter_tools/src/intellij/intellij.dart:141:40)
      #8      IntelliJPlugins.validatePackage (package:flutter_tools/src/intellij/intellij.dart:63:35)
      #9      IntelliJValidator.validate (package:flutter_tools/src/intellij/intellij_validator.dart:103:15)
      #10     asyncGuard.<anonymous closure> (package:flutter_tools/src/base/async_guard.dart:111:32)
      #11     asyncGuard.<anonymous closure> (package:flutter_tools/src/base/async_guard.dart:109:18)
      #12     _rootRun (dart:async/zone.dart:1428:13)
      #13     _CustomZone.run (dart:async/zone.dart:1328:19)
      #14     _runZoned (dart:async/zone.dart:1863:10)
      #15     runZonedGuarded (dart:async/zone.dart:1851:12)
      #16     runZoned (dart:async/zone.dart:1782:12)
      #17     asyncGuard (package:flutter_tools/src/base/async_guard.dart:109:3)
      #18     Doctor.startValidatorTasks (package:flutter_tools/src/doctor.dart:197:9)
      #19     Doctor.diagnose (package:flutter_tools/src/doctor.dart:301:47)
      #20     DoctorCommand.runCommand (package:flutter_tools/src/commands/doctor.dart:53:47)
      #21     FlutterCommand.verifyThenRunCommand (package:flutter_tools/src/runner/flutter_command.dart:1289:12)
      <asynchronous suspension>
      #22     FlutterCommand.run.<anonymous closure> (package:flutter_tools/src/runner/flutter_command.dart:1140:27)
      <asynchronous suspension>
      #23     AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:150:19)
      <asynchronous suspension>
      #24     CommandRunner.runCommand (package:args/command_runner.dart:209:13)
      <asynchronous suspension>
      #25     FlutterCommandRunner.runCommand.<anonymous closure> (package:flutter_tools/src/runner/flutter_command_runner.dart:288:9)
      <asynchronous suspension>
      #26     AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:150:19)
      <asynchronous suspension>
      #27     FlutterCommandRunner.runCommand (package:flutter_tools/src/runner/flutter_command_runner.dart:236:5)
      <asynchronous suspension>
      #28     run.<anonymous closure>.<anonymous closure> (package:flutter_tools/runner.dart:62:9)
      <asynchronous suspension>
      #29     AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:150:19)
      <asynchronous suspension>
      #30     main (package:flutter_tools/executable.dart:93:3)
      <asynchronous suspension>

[✓] VS Code (version 1.62.3)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.28.0

[✓] Connected device (2 available)
    • macOS (desktop) • macos  • darwin-arm64   • macOS 11.6 20G165 darwin-arm
    • Chrome (web)    • chrome • web-javascript • Google Chrome 96.0.4664.55

! Doctor found issues in 1 category.

I'm guessing there's still no way possible to stop Flutter web, from resizing below certain pixels?
For example - Admin dashboards, that are not meant to run on mobile; how do we restrict their window pane from resizing below a Tabs resolution?
Current workaround I use, is to show a notification that said endpoint should be run on desktop; but that surely doesn't suffice ... Any new alternatives?

I am facing a similar issue the basic counter app feels a lot janky on resizing the window, This happens only on the first few resizes. The app is running in debug mode with the default renderer.
https://github.com/flutter/flutter/assets/31410839/bf064a95-c09e-4d5e-87b6-9526dfb3fc41
[✓] Flutter (Channel stable, 3.10.1, on macOS 13.1 22C65 darwin-arm64, locale en-IN)
    • Flutter version 3.10.1 on channel stable at /Users/mahesh/Development/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision d3d8effc68 (3 days ago), 2023-05-16 17:59:05 -0700
    • Engine revision b4fb11214d
    • Dart version 3.0.1
    • DevTools version 2.23.1

Any updates on this issue? I added a Scaffold background color on my Flutter web app, and I am experiencing the same janky issue the first couple times the browser window is resized.

source: gharchive/issue

authors: Serticode danagbemava-nc maheshmnj mattostanik osaxma

repo: flutter/flutter

license_type: permissive

license_source: github-api


text:
Remove dev channel from Flutter builds

This issue tracks all the action items required for removing dev channel from Flutter builds. The entire premise of the discussion (why and what) has been documented here for additional context.
Implementation Tasks

[ ]  #94967
[x]  #94969
[ ]  #94970
[ ] #94971
[x] #94973
[ ] #94974. This bug is mirrored in dartpad repo to track backend work - #2111

@khyati82 Another item to add to this list is that we should remove the dev channel from presubmit tests on the website (and anywhere else). See, for example, https://github.com/flutter/website/runs/4767648310?check_suite_focus=true


text:
Flutter doctor crashed with Intellij Community 2021.3

Steps to Reproduce

flutter doctor -v

Logs

Logs

Closing this as duplicate of https://github.com/flutter/flutter/issues/94060

authors: arisAlexis darshankawar


text:
closeCaptureSession  Session 1: Exception while stopping repeating:

I got this error in my app while I'm used  startImageStream
/Camera  ( 6455): open | onError
I/Camera  ( 6455): close
I/Camera  ( 6455): closeCaptureSession
E/CameraCaptureSession( 6455): Session 1: Exception while stopping repeating:
E/CameraCaptureSession( 6455): android.hardware.camera2.CameraAccessException: CAMERA_ERROR (3): The camera device has encountered a serious error
E/CameraCaptureSession( 6455): 	at android.hardware.camera2.impl.CameraDeviceImpl.checkIfCameraClosedOrInError(CameraDeviceImpl.java:2023)
E/CameraCaptureSession( 6455): 	at android.hardware.camera2.impl.CameraDeviceImpl.stopRepeating(CameraDeviceImpl.java:952)
E/CameraCaptureSession( 6455): 	at android.hardware.camera2.impl.CameraCaptureSessionImpl.close(CameraCaptureSessionImpl.java:395)
E/CameraCaptureSession( 6455): 	at io.flutter.plugins.camera.Camera.closeCaptureSession(Camera.java:1114)
E/CameraCaptureSession( 6455): 	at io.flutter.plugins.camera.Camera.close(Camera.java:1121)
E/CameraCaptureSession( 6455): 	at io.flutter.plugins.camera.Camera$1.onError(Camera.java:302)
E/CameraCaptureSession( 6455): 	at android.hardware.camera2.impl.CameraDeviceImpl$CameraDeviceCallbacks$1.run(CameraDeviceImpl.java:1684)
E/CameraCaptureSession( 6455): 	at android.os.Handler.handleCallback(Handler.java:751)
E/CameraCaptureSession( 6455): 	at android.os.Handler.dispatchMessage(Handler.java:95)
E/CameraCaptureSession( 6455): 	at android.os.Looper.loop(Looper.java:179)
E/CameraCaptureSession( 6455): 	at android.os.HandlerThread.run(HandlerThread.java:61)

Hi @oscar02r, Thanks for filing the issue. Please share a minimal and complete reproducible code sample along with the output of flutter doctor -v and flutter run -v.
This is a duplicate of https://github.com/flutter/flutter/issues/94232 (closed)
Thanks


text:
Roll Flutter Engine from 93b86eb6260a to 0cec24fed9d9 (12 revisions)

https://github.com/flutter/engine/compare/93b86eb6260a...0cec24fed9d9
2022-10-18 skia-flutter-autoroll@skia.org Roll Skia from d2ed2ffdca06 to 0f9cdfafa145 (2 revisions) (flutter/engine#36839)
2022-10-18 chillers@google.com Stop using u8string which breaks in C++20 (flutter/engine#36696)
2022-10-18 skia-flutter-autoroll@skia.org Roll Skia from 942b285f0f13 to d2ed2ffdca06 (4 revisions) (flutter/engine#36838)
2022-10-18 skia-flutter-autoroll@skia.org Roll Skia from 8941e05187e8 to 942b285f0f13 (1 revision) (flutter/engine#36835)
2022-10-18 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from CW9-6BIlFFDbRCs-c... to oMrS1TjaSIjntnBvR... (flutter/engine#36833)
2022-10-18 skia-flutter-autoroll@skia.org Roll Dart SDK from 4d40ff624a32 to 77e83fcc14fa (2 revisions) (flutter/engine#36832)
2022-10-18 skia-flutter-autoroll@skia.org Roll Skia from a69707947d73 to 8941e05187e8 (1 revision) (flutter/engine#36831)
2022-10-18 skia-flutter-autoroll@skia.org Roll Skia from d6e083bb4acc to a69707947d73 (3 revisions) (flutter/engine#36830)
2022-10-18 skia-flutter-autoroll@skia.org Roll Dart SDK from 29965a3d05bc to 4d40ff624a32 (1 revision) (flutter/engine#36829)
2022-10-18 skia-flutter-autoroll@skia.org Roll Skia from 87d97e03342c to d6e083bb4acc (1 revision) (flutter/engine#36828)
2022-10-18 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from SBV4OIwp1ahu_iq_v... to Hesny8PCo_AwxfJ6I... (flutter/engine#36827)
2022-10-18 skia-flutter-autoroll@skia.org Roll Skia from 8c73a59cd417 to 87d97e03342c (4 revisions) (flutter/engine#36823)
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from CW9-6BIlFFDb to oMrS1TjaSIjn
fuchsia/sdk/core/mac-amd64 from SBV4OIwp1ahu to Hesny8PCo_Aw
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Commit queue failed; closing this roll.

source: gharchive/pull-request


text:
Roll Flutter Engine from c7a4bbab0e75 to f2d3dbda083e (1 revision)

https://github.com/flutter/engine/compare/c7a4bbab0e75...f2d3dbda083e
2023-02-04 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from y0pMcSL4ejAh7JYTq... to D0jJKibnSzSOs68QJ... (flutter/engine#39386)
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from y0pMcSL4ejAh to D0jJKibnSzSO
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Commit queue failed; closing this roll.


text:
Add viewSearchOnChanged to SearchAnchor

I started investigating the #132915 issue. The first thing I noticed was that onChanged was not working when the searchbar view was open, but it was working when it was closed. When I examined the code, I saw that the onChanged argument was not in the arguments given to the opened search view. I added the viewSearchOnChanged argument, which will work when the view is open. This solved the #132915 issue and the onChange state was triggered when the search view was open.

#132915

 Code Example (The code is the new and working version of the #132915)
import 'package:flutter/material.dart';

class SearchBarIssueView extends StatefulWidget {
  const SearchBarIssueView({super.key});

  @override
  State<SearchBarIssueView> createState() => _SearchBarIssueViewState();
}

class _SearchBarIssueViewState extends State<SearchBarIssueView> {
  bool isDark = false;

  @override
  Widget build(BuildContext context) {
    final ThemeData themeData = ThemeData(useMaterial3: true, brightness: isDark ? Brightness.dark : Brightness.light);

    return MaterialApp(
      theme: themeData,
      home: Scaffold(
        appBar: AppBar(title: const Text('Search Bar Sample')),
        body: Padding(
          padding: const EdgeInsets.all(8.0),
          child: SearchAnchor(
            viewSearchOnChanged: (value) {
              print('OnChanged While Open: $value');
            },
            builder: (BuildContext context, SearchController controller) {
              return SearchBar(
                controller: controller,
                padding: const MaterialStatePropertyAll<EdgeInsets>(EdgeInsets.symmetric(horizontal: 16.0)),
                onTap: () {
                  controller.openView();
                },
                onChanged: (value) {
                  print('OnChanged While Close: $value');
                },
                leading: const Icon(Icons.search),
                trailing: <Widget>[
                  Tooltip(
                    message: 'Change brightness mode',
                    child: IconButton(
                      isSelected: isDark,
                      onPressed: () {
                        setState(() {
                          isDark = !isDark;
                        });
                      },
                      icon: const Icon(Icons.wb_sunny_outlined),
                      selectedIcon: const Icon(Icons.brightness_2_outlined),
                    ),
                  )
                ],
              );
            },
            suggestionsBuilder: (BuildContext context, SearchController controller) {
              return List<ListTile>.generate(5, (int index) {
                final String item = 'item $index';
                return ListTile(
                  title: Text(item),
                  onTap: () {
                    setState(() {
                      controller.closeView(item);
                    });
                  },
                );
              });
            },
          ),
        ),
      ),
    );
  }
}

 Logs
flutter: OnChanged While Open: f
flutter: OnChanged While Open: fl
flutter: OnChanged While Open: flu
flutter: OnChanged While Open: flut
flutter: OnChanged While Open: flutt
flutter: OnChanged While Open: flutte
flutter: OnChanged While Open: flutter
flutter: OnChanged While Close: flutterr

Pre-launch Checklist

[X] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[X] I read the Tree Hygiene wiki page, which explains my responsibilities.
[X] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[X] I signed the CLA.
[X] I listed at least one issue that this PR fixes in the description above.
[X] I updated/added relevant documentation (doc comments with ///).
[ ] I added new tests to check the change I am making, or this PR is test-exempt.
[ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Could we somehow make the existing onChange also receive onChange events from the search view?  I'm not sure about having two onChange callbacks for the user to listen.
Also this need tests.

Could we somehow make the existing onChange also receive onChange events from the search view? I'm not sure about having two onChange callbacks for the user to listen.
Also this need tests.

If we think that it will only be received by SearchAnchor, we can give the parameter to the builder and have the man give the new extra onChange parameter. If it is in the SearchBar, we cannot send this parameter to the opened search view, since SearchAnchor cannot access it directly.
After finalizing the solution process, I can add the solution to the existing sample test widgets

That's an interesting problem.
@HansMuller Any thoughts?

I agree that the onChanged callback is associated with the search bar's text field, which (from the user's point of view) is visible whether the search view is open or not. Hopefully this could be made to work by just passing the callback along, i.e. without any inherited widget intermediary.
Unrelated: it's a bit of a shame that the onTap and onChanged callbacks are needed by default. I would have thought that overriding them would only be needed if the app didn't just want to have them call controller.openView().
@QuncCccccc - would like to hear your opinion about this.

Maybe we can pass onChanged method as 3rd parameter in builder. By default, the developer can pass it into the onChange inside the SearchBar. Thus, it will not be rewritten, but there will be 2 onChanges again.
SearchAnchor(
            viewSearchOnChanged: (value) {
              print('OnChanged While Open: $value');
            },
            builder: (BuildContext context, SearchController controller, ValueSetter<String> viewSearchOnChanged) {
            return SearchBar(
                controller: controller,
                padding: const MaterialStatePropertyAll<EdgeInsets>(EdgeInsets.symmetric(horizontal: 16.0)),
                onTap: () {
                  controller.openView();
                },
                onChanged: viewSearchOnChanged,
            ...

I don't know if I can contribute anything, but I would like to leave here the way I tried to somehow deal with all the "problems" with the widget...
If there really is something strange in my code, I apologize and open it for new implementations... Thank you very much!
`class SearchComponent extends StatefulWidget {
final SearchController searchController;
final Titles resultData;
final Function(String text) fetchDataFromBackend;
const SearchComponent({
Key? key,
required this.searchController,
required this.resultData,
required this.fetchDataFromBackend,
}) : super(key: key);
@override
State createState() => _SearchComponentState();
}
class SearchComponentState extends State {
@override
Widget build(BuildContext context) {
return SearchAnchor(
isFullScreen: true,
searchController: widget.searchController,
builder: (context, controller) {
return SearchBar(
controller: controller,
onTap: () =>
controller.text.isNotEmpty ? controller.openView() : null,
onChanged: () =>
controller.text.isNotEmpty ? controller.openView() : null,
);
},
suggestionsBuilder: (context, controller) async {
List titles =
await widget.fetchDataFromBackend(controller.value.text);
widget.resultData.update(titles);
    return List.generate(
      widget.resultData.items.length,
      (index) => ListTile(
        title: Text(
          widget.resultData.items[index],
        ),
      ),
    );
  },
);

}
}
`

@burakJs
Are you still working on this? Do you have any response for https://github.com/flutter/flutter/pull/132924#issuecomment-1688695104

@QuncCccccc Do you any comment regarding https://github.com/flutter/flutter/pull/132924#issuecomment-1688695104?

@QuncCccccc Do you any comment regarding #132924 (comment)?

I think a fix(#136840) was already merged last year:) Sorry I didn't notice this PR before. I added a viewOnChanged for SearchAnchor because the search view can also be opened by clicking any widget which isn't a search bar.

@QuncCccccc
Do we close this PR then?

Thanks so much for the contribution! I'll close this issue because the fix is already in #136840 :)

@QuncCccccc I'm on stable channel 3.16.9. How can I get the new change for SearchAnchor that has viewOnChanged?

authors: HansMuller LincolnFerreira QuncCccccc TahaTesser aloh86 burakJs


text:
Roll Flutter Engine from 92d88c7e4e9a to a582980c7e75 (5 revisions)

https://github.com/flutter/engine/compare/92d88c7e4e9a...a582980c7e75
2023-12-18 skia-flutter-autoroll@skia.org Roll Skia from 10e7ee119ea9 to 83f8fe8bbcee (1 revision) (flutter/engine#49193)
2023-12-18 barpac02@gmail.com Delete SemanticsUpdateBuilderNew and all references and usages (flutter/engine#49139)
2023-12-18 chinmaygarde@google.com Opt into unstable libcxx ABI and add a custom namespace. (flutter/engine#49002)
2023-12-18 skia-flutter-autoroll@skia.org Roll Skia from 4b2639427e7e to 10e7ee119ea9 (10 revisions) (flutter/engine#49191)
2023-12-18 skia-flutter-autoroll@skia.org Roll Dart SDK from e1a26302800d to ff7e92c7886d (1 revision) (flutter/engine#49185)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Commit queue failed; closing this roll.


text:
Add unintended_html_in_doc_comment lint and fixes.

This change adds the unintended_html_in_doc_comment lint. Proposal: https://github.com/dart-lang/linter/issues/4793.
This will replace the typeAsHtml Dartdoc warning, which is being deprecated and eventually removed.
I changed the unintended html tags in a couple ways:

If it's a private method or field, I didn't bother using < or > since it will be ignored by Dartdoc anyways. If it isn't meant to be code, I just added a lint ignore to maintain the readability of the comment.
If it looks like it should be a code block or code span, I added those around the tag.
If it's none of the above, I used < or > to make sure the angle brackets still appear as we wanted.

Examples of some API docs changed:

https://api.flutter.dev/flutter/services/DefaultProcessTextService-class.html which had some funky code blocks have been cleaned up.
https://api.flutter.dev/flutter/semantics/SemanticsProperties/onSetText.html "Voice access users can trigger this handler by speaking "type <text>" to their Android devices." The <text> tag is no longer absorbed.
https://api.flutter.dev/flutter/services/DeferredComponent/installDeferredComponent.html "This method returns a Future<void>..." where Future<void> is no longer absorbed.

Pre-launch Checklist

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I read the Tree Hygiene wiki page, which explains my responsibilities.
[x] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[x] I signed the CLA.
[x] I listed at least one issue that this PR fixes in the description above.
[x] I updated/added relevant documentation (doc comments with ///).
[x] I added new tests to check the change I am making, or this PR is test-exempt.
[x] I followed the breaking change policy and added Data Driven Fixes where supported.
[ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Examples of some API docs changed:

Nice fixes!
Could you also update/remove this here: https://github.com/flutter/flutter/blob/a557f0439c5ab68388b66243a4e19b8ded27b86f/dartdoc_options.yaml#L41

We decided to close this for now as it is currently blocked on https://github.com/dart-lang/sdk/issues/55458.

authors: goderbauer kallentu


text:
Roll Flutter Engine from 55c62ff82c7e to 70de32b3e13f (2 revisions)

https://github.com/flutter/engine/compare/55c62ff82c7e...70de32b3e13f
2024-05-14 34871572+gmackall@users.noreply.github.com Fix non-vd android platform view input event offsets (flutter/engine#52532)
2024-05-14 skia-flutter-autoroll@skia.org Roll Dart SDK from 0380354e2448 to 0b77fbab8cf5 (1 revision) (flutter/engine#52827)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Commit queue failed; closing this roll.


text:
Adds lazyAnimation property to AnimatedList and AnimatedGrid.

This PR adds lazyAnimation property to AnimatedList and AnimatedGrid to optionally start animation of item when the item is first rendered instead of starting the animation when its first inserted to the list.
Fixes: #148379
Pre-launch Checklist

[x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
[x] I read the [Tree Hygiene] wiki page, which explains my responsibilities.
[x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
[x] I signed the [CLA].
[x] I listed at least one issue that this PR fixes in the description above.
[x] I updated/added relevant documentation (doc comments with ///).
[x] I added new tests to check the change I am making, or this PR is [test-exempt].
[x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported.
[x] All existing and new tests are passing.

@chinmoy12c Hello from triage! Are you still interested in getting this PR ready for review? This would include adding a test and making sure it passes all the checks.

(triage) I am going to close this as inactive, feel free to reopen when you have time

authors: chinmoy12c chunhtai goderbauer


text:
Introduce DoctorValidatorsProvider to improve extensibility of flutter_tools

By injecting DoctorValidatorsProvider into the Doctor to provide validators, validators can be overridden without needing to override the whole Doctor. This makes the case of overriding validators less prone to complications should the Doctor API change.

Merging on red because of suspected flake.

authors: josephmr tvolkert


text:
Add a layoutDirection parameter to AndroidView

Companion engine changes: flutter/engine#6057
Fixes: #19417

Will land on green

@fkorotkov I feel like lately "Agent is not responding!" is pretty common, e.g https://cirrus-ci.com/task/4784657677680640
Not sure if you're already collecting this data or you want to get reports when that happens? (and if so how would you prefer to get the reports)


text:
some performance optimizations for starting apps

Some performance optimizations for starting apps:

only seed the random value if we're going to use it (~600ms)
switch to the sha256 implementation from crypto (~700ms => 70ms)
default to not calling stop when starting an app. Android is ok w/ it, and stop isn't implemented for iOS (stop was ~500ms)
reduce the number of times we call simctl list --json - each call was ~100ms, and we had 5-6 calls. Down to 2 now. This is the isConnected change. The semantics of that method are different now that we only create a Device instance for devices that actually exist

The biggest outstanding piece of work now is zipping the snapshot into an flx. We can re-write to shell out to zip when it's available, and save about 1000ms.

flutter -v run:
[  17 ms] - Using Android SDK at /Users/devoncarew/tools/android-sdk-macosx/.
[  17 ms] - [/Users/devoncarew/tools/android-sdk-macosx/, SDK version 23, build-tools 23.0.2]
[  39 ms] - xcodebuild -version
[ 102 ms] - Xcode 7.2.1
Build version 7C1002
[ 105 ms] - /Users/devoncarew/tools/android-sdk-macosx/platform-tools/adb devices -l
[ 115 ms] - List of devices attached
TA95000FQA             device usb:336592896X product:peregrine_retus model:XT1045 device:peregrine
[ 149 ms] - which idevice_id
[ 152 ms] - /Users/devoncarew/homebrew/bin/idevice_id
[ 152 ms] - /Users/devoncarew/homebrew/bin/idevice_id -l
[ 161 ms] - /usr/bin/xcrun simctl list --json devices
[ 242 ms] - Downloading toolchain.
[ 270 ms] - /usr/bin/defaults read /Users/devoncarew/flutter/flutter_sunflower/ios/Info CFBundleIdentifier
[ 314 ms] - io.flutter.runner.Runner
[ 315 ms] - /Users/devoncarew/tools/android-sdk-macosx/platform-tools/adb devices -l
[ 325 ms] - List of devices attached
TA95000FQA             device usb:336592896X product:peregrine_retus model:XT1045 device:peregrine
[ 330 ms] - /Users/devoncarew/homebrew/bin/idevice_id -l
[ 336 ms] - /usr/bin/xcrun simctl list --json devices
[ 413 ms] - Running build command.
[ 416 ms] - APK up to date. Skipping build step.
[ 416 ms] - Running install command.
[ 417 ms] - /Users/devoncarew/tools/android-sdk-macosx/platform-tools/adb -s TA95000FQA shell pm path com.example.flutter_sunflower
[ 871 ms] - package:/data/app/com.example.flutter_sunflower-1/base.apk
[ 874 ms] - /Users/devoncarew/tools/android-sdk-macosx/platform-tools/adb -s TA95000FQA shell cat /data/local/tmp/sky.com.example.flutter_sunflower.sha1
[ 898 ms] - c5ea78f5d3d30eb1e2c19c29a8100836ce2522cc
[1156 ms] - Running build command for AndroidDevice TA95000FQA.
[1156 ms] Starting lib/main.dart on XT1045...
[1157 ms] - /Users/devoncarew/tools/android-sdk-macosx/platform-tools/adb version
[1166 ms] - Android Debug Bridge version 1.0.32
Revision 09a0d98bebce-android
[1168 ms] - /Users/devoncarew/tools/android-sdk-macosx/platform-tools/adb -s TA95000FQA start-server
[1178 ms] - /Users/devoncarew/tools/android-sdk-macosx/platform-tools/adb -s TA95000FQA shell getprop ro.build.version.sdk
[1213 ms] - 22
[1291 ms] - /Users/devoncarew/projects/flutter/flutter/bin/cache/artifacts/engine/darwin-x64/sky_snapshot /Users/devoncarew/flutter/flutter_sunflower/lib/main.dart --package-root=packages --snapshot=/var/folders/00/0w978000h01000cxqpysvccm003j4x/T/flutter_toolsZTLoaB/snapshot_blob.bin
[1684 ms] - Building /var/folders/00/0w978000h01000cxqpysvccm003j4x/T/flutter_toolsZTLoaB/app.flx
[1710 ms] - KeyPair from privatekey.der: null.
[1710 ms] - Encoding zip file.
[2543 ms] - Creating flx at /var/folders/00/0w978000h01000cxqpysvccm003j4x/T/flutter_toolsZTLoaB/app.flx.
[2592 ms] - Built and signed flx at /var/folders/00/0w978000h01000cxqpysvccm003j4x/T/flutter_toolsZTLoaB/app.flx.
[2592 ms] - Starting bundle for AndroidDevice TA95000FQA.
[2594 ms] - AndroidDevice TA95000FQA startBundle
[2594 ms] - /Users/devoncarew/tools/android-sdk-macosx/platform-tools/adb -s TA95000FQA forward tcp:8181 tcp:8181
[2606 ms] - /Users/devoncarew/tools/android-sdk-macosx/platform-tools/adb -s TA95000FQA -s TA95000FQA logcat -c
[2645 ms] - /Users/devoncarew/tools/android-sdk-macosx/platform-tools/adb -s TA95000FQA push /var/folders/00/0w978000h01000cxqpysvccm003j4x/T/flutter_toolsZTLoaB/app.flx /data/local/tmp/dev.flx
[2787 ms] - /Users/devoncarew/tools/android-sdk-macosx/platform-tools/adb -s TA95000FQA shell am start -a android.intent.action.RUN -d /data/local/tmp/dev.flx -f 0x20000000 --ez enable-background-compilation true --ez enable-checked-mode true com.example.flutter_sunflower/org.domokit.sky.shell.SkyActivity
[3411 ms] - Starting: Intent { act=android.intent.action.RUN dat=/data/local/tmp/dev.flx flg=0x20000000 cmp=com.example.flutter_sunflower/org.domokit.sky.shell.SkyActivity (has extras) }
Warning: Activity not started, its current task has been brought to the front
[3412 ms] - Finished run command.

LGTM

authors: abarth devoncarew


text:
Roll engine 3496156bd9bf..be9067cc764d (2 commits)

https://github.com/flutter/engine/compare/3496156bd9bf...be9067cc764d
git log 3496156bd9bfe61788bf64ce3ca3cf1bc2663f95..be9067cc764d4adced316db8a96186089d87892e --no-merges --oneline
be9067cc7 Roll src/third_party/skia 37a9294d2eb9..d7d93001ead2 (2 commits) (flutter/engine#8223)
ee4abba58 Roll src/third_party/skia 2894d13a0d9b..37a9294d2eb9 (1 commits) (flutter/engine#8222)
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (liyuqian@google.com), and stop
the roller if necessary.

Trybots failed. These were the failed builds: https://cirrus-ci.com/task/5534270457118720

Commit queue failed; closing this roll.


text:
fix Applying decoration for a table row widget will cause render exce…

…ption
Description
Pushing an overlay route will cause the previous route to detach and rebuild. Table widget does not correctly handle the detach and rebuild. This pr fixes it.
Related Issues
https://github.com/flutter/flutter/issues/17243
Tests
I added the following tests:
"Table widget can be detached and re-attached"
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I signed the CLA.
[x] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[x] I updated/added relevant documentation (doc comments with ///).
[x] All existing and new tests are passing.
[x] The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
[x] I am willing to follow-up on review comments in a timely manner.

Breaking Change
Does your PR require Flutter developers to manually update their apps to accommodate your change?

[ ] Yes, this is a breaking change (Please read Handling breaking changes). Replace this with a link to the e-mail where you asked for input on this proposed change.
[x] No, this is not a breaking change.

addressed all coments


text:
Roll engine e96900df2f27..fb263322102b (21 commits)

https://github.com/flutter/engine/compare/e96900df2f27...fb263322102b
git log e96900df2f273920f7da46ae589b859d5a1fccb3..fb263322102b005316f17f882ed84a41455e725d --no-merges --oneline
fb2633221 Roll fuchsia/sdk/core/linux-amd64 from d2VK3FYSEKQ35UdZw5FdbOZUI_xgT0-1h8DnGDUHPVAC to w7VVL0dntMhd75uB9Yby88ecIJkWGhBsr8mqCMNKurcC (flutter/engine#9596)
5d4a6832e Roll src/third_party/skia 1ddee025229a..0d8c1aefd127 (1 commits) (flutter/engine#9594)
131085eca [crash] switch to async crash analysis
0ea826d72 [dart/flutter_runner] Copy package.resolved_url for TRACE_DURATION
c13374b9e [meta] add fuchsia.{net.NameLookup,posix.socket.Provider}
97eb094aa [flutter] Re-enable unhandled error reporting
a48c21a73 [flutter_runner] Rename outgoing 'public' to 'svc'.
98f55f0e6 [trace clients] Remove fuchsia.tracelink.Registry
38b382726 [flutter_runner] use external image create info
366c88174 [trace clients] Add fuchsia.tracing.provider.Registry to cmx files
06b29ae83 [trace clients] Replace trace-provider with trace-provider-with-fdio
ffba2f68d Roll src/third_party/dart b37aa3b036...0abff7b2bb (flutter/engine#9588)
62514cb77 Roll fuchsia/sdk/core/mac-amd64 from n9fZpXVmsbgKZzS8Q2GXxB453q8AbLpfGztsPsq47pMC to BYCwsJf7r7zfd2THSGinFeIHv552AEVchXdc7VZzP0IC (flutter/engine#9587)
9f2721284 Roll src/third_party/skia e4c88bb1f848..1ddee025229a (7 commits) (flutter/engine#9586)
03a31e0ad Roll fuchsia/sdk/core/linux-amd64 from F9oY0d56X3aONxwv5vw9Gco--AHmC8SHuDXdhdWCnnMC to d2VK3FYSEKQ35UdZw5FdbOZUI_xgT0-1h8DnGDUHPVAC (flutter/engine#9583)
45b66b722 Revert " Roll src/third_party/dart b37aa3b036...1eb113ba27 (#9559)" (flutter/engine#9584)
fc1d86b75 Revert "Avoid a full screen overlay within virtual displays (#9343)" (flutter/engine#9581)
140b2aef5  Roll src/third_party/dart b37aa3b036...1eb113ba27 (flutter/engine#9559)
94bb7a7ff Adds API for retaining intermediate engine layers (flutter/engine#9461)
7d1508d98 Roll fuchsia/sdk/core/mac-amd64 from cFEtOUFvy2XYSKuSmCMDaMQV8_Y7GOif521L3x86J_4C to n9fZpXVmsbgKZzS8Q2GXxB453q8AbLpfGztsPsq47pMC (flutter/engine#9579)
7a0bbf935 Fixed memory leak by way of accidental retain on implicit self (flutter/engine#9329)
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (chinmaygarde@google.com), and stop
the roller if necessary.

Trybots failed. These were the failed builds: https://cirrus-ci.com/task/4519522879406080 , https://cirrus-ci.com/task/5619034507182080 , https://cirrus-ci.com/task/6463459437314048

Commit queue failed; closing this roll.


text:
Popup menu in Stocks throws exception

Previously, we were putting a ForcedLayer just below the overlay, but that
causes trouble for routes like the popup menu that want to position themselves
inside the overlay. Instead, I've moved the ForcedLayer down into ModalRoute.
Also, rename ForcedLayer to RepaintBoundary, which is more descriptive of what
this widget does.
Fixes #485

TBR @Hixie (to fix regression)

LGTM

authors: Hixie abarth


text:
Remove InlineSpan type check

Remove InlineSpan type check because it successful work with WidgetSpan
before: https://ibb.co/GCzSH9N
after: https://ibb.co/4FV3Nty
My code:
SelectableText.rich(
        TextSpan(children: [
          TextSpan(
            children: [
              TextSpan(
                text: "gjgjgjg",
              ),
              TextSpan(
                text: " gjgjgjg",
                style: TextStyle(fontWeight: FontWeight.bold),
              ),
            ],
          ),
          WidgetSpan(
            child: CachedNetworkImage(
              imageUrl:
                  "https://ranobehub.org/img/media/66266/conversions/poster-big.webp",
            ),
          ),
          TextSpan(
            children: [
              TextSpan(
                text: "gjgjgjg",
              ),
              TextSpan(
                text: " gjgjgjg",
                style: TextStyle(fontWeight: FontWeight.bold),
              ),
            ],
          )
        ]),
      ),

@googlebot I signed it!


text:
Roll Plugins from f6d93a765063 to dc7b8641174f (3 revisions)

https://github.com/flutter/plugins/compare/f6d93a765063...dc7b8641174f
2021-10-02 stuartmorgan@google.com [ci] Remove obsolete Dockerfile (flutter/plugins#4405)
2021-10-01 stuartmorgan@google.com Fix order-dependant platform interface tests (flutter/plugins#4406)
2021-10-01 Murray.meller@gmail.com [google_maps_flutter]: LatLng longitude loses precision in constructor #90574 (flutter/plugins#4374)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-plugins-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Commit queue failed; closing this roll.


text:
Refactored CardTheme: CardTheme, CardThemeData

This is a work in progress...

I'd forgotten that I'd started this.


text:
Update Scrollbar to support infinite scrollable widget

Fixes https://github.com/flutter/flutter/issues/41434
CC @Piinks Looking forward to your thoughts.
Test Demo
// Copyright 2018 The Flutter team. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

import 'package:english_words/english_words.dart';
import 'package:flutter/material.dart';

void main() {
  runApp(const MyApp());
}

class MyScrollBehavior extends ScrollBehavior {
  @override
  Widget buildScrollbar(
      BuildContext context, Widget child, ScrollableDetails details) {
    return child;
  }
}

// #docregion MyApp
class MyApp extends StatelessWidget {
  const MyApp({Key? key}) : super(key: key);

  // #docregion build
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      scrollBehavior: MyScrollBehavior(),
      title: 'Startup Name Generator',
      home: RandomWords(),
    );
  }
// #enddocregion build
}
// #enddocregion MyApp

// #docregion RWS-var
class _RandomWordsState extends State<RandomWords> {
  final _suggestions = <WordPair>[];
  final _biggerFont = const TextStyle(fontSize: 18.0);
  final controller = ScrollController();
  // #enddocregion RWS-var

  // #docregion _buildSuggestions
  Widget _buildSuggestions() {
    return ListView.builder(
      // itemCount: 1000,
      key: Key('value'),
      // cacheExtent: 25000,
      // reverse: true,
        controller: controller,
        padding: const EdgeInsets.all(1.0),
        itemBuilder: /*1*/ (context, i) {
          if (i.isOdd) return const Divider(); /*2*/

          final index = i ~/ 2; /*3*/
          if (index >= _suggestions.length) {
            _suggestions.addAll(generateWordPairs().take(1000)); /*4*/
          }
          return _buildRow(_suggestions[index], index);
        });
  }
  // #enddocregion _buildSuggestions

  void _loadData() {
    Future.delayed(const Duration(milliseconds: 200)).then((value) {
      _suggestions.addAll(generateWordPairs().take(10)); /*4*/
    });
  }

  // #docregion _buildRow
  Widget _buildRow(WordPair pair, int index) {
    return ListTile(
      title: Text(
        '$index - ' + pair.asPascalCase,
        style: _biggerFont,
      ),
    );
  }
  // #enddocregion _buildRow

  // #docregion RWS-build
  @override
  Widget build(BuildContext context) {
    return Scaffold(
      floatingActionButton: FloatingActionButton(
        onPressed: () {
          controller.jumpTo(700);
        },
      ),
      appBar: AppBar(
        title: const Text('Startup Name Generator'),
      ),
      body: Scrollbar(
        controller: controller,
        thickness: 17,
        isAlwaysShown: true,
        interactive: true,
        child: _buildSuggestions(),
      ),
    );
  }
// #enddocregion RWS-build
// #docregion RWS-var
}
// #enddocregion RWS-var

class RandomWords extends StatefulWidget {
  const RandomWords({Key? key}) : super(key: key);

  @override
  State<RandomWords> createState() => _RandomWordsState();
}

Hey @xu-baolin! I have been working on this too, I dusted off a proposal I had for it today, see https://github.com/flutter/flutter/pull/96825
I am cleaning up and old design doc to discuss further too. Maybe we can collaborate with your ideas here for the finished product. :)
Let me know what you think. I'll add the design doc to the PR once it is ready

Hey @xu-baolin I think we're going to move forward with #96825, although I have to push a bunch of changes. I am going to close this, I really appreciate your contributions on this. :)

authors: Piinks xu-baolin


text:
[url_launcher] Added draggable property [#102735]

Allowing use of the Link widget in lists with mouse drag enabled.
In a desktop web browser, links are be default draggable. If they are put in e.g. a list, then that list cannot be scrolled by dragging it with the mouse. This PR makes it possible to disable this behavior.
Issues fixed: #102735
Pre-launch Checklist

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I read the Tree Hygiene wiki page, which explains my responsibilities.
[x] I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
[x] I signed the CLA.
[x] The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
[x] I listed at least one issue that this PR fixes in the description above.
[ ] I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
[ ] I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
[ ] I updated/added relevant documentation (doc comments with ///).
[ ] I added new tests to check the change I am making, or this PR is test-exempt.
[ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@ditman Ping on this review?

Apologies! I'm going to bump this to @mdebbar, he knows the Link widget much better than I do.
Mouad, do you mind taking a look? Thanks!!

From triage: @mdebbar Ping on this review.

Could you prepare a separate PR for each of the packages, so we can merge and publish them in order?

We actually just do this one at a time; see https://github.com/flutter/flutter/wiki/Contributing-to-Plugins-and-Packages#changing-federated-plugins
So the next step is to make just the platform interface PR, then once that lands, the implemenation package PR, then finally rebase this one.

@stuartmorgan: Yeah, but I'm not sure if we've reached a conclusion on this: https://github.com/flutter/plugins/pull/5430/files#r896078916. I can make pull requests that adds draggable and preventDefault (ie, what's done for Firefox here: https://github.com/flutter/plugins/pull/5430/files#diff-77a04b3b00b00a4480b7d5e75e089dde7cca99ccebcc4f43e0e25d2bba5346e0R255), then you can always tweak it to your heart's content afterwards?

@ditman You marked this as approved; what was your take on the resolution of that comment thread?

@kristoffer-zliide It sounds from the above like this was ready for a platform interface PR; are you still planning on splitting that out to move this forward?

@stuartmorgan: here you go

Status update from triage: blocked on resolving the breaking change issue in https://github.com/flutter/plugins/pull/6282.

Status from triage: still blocked on https://github.com/flutter/plugins/pull/6282

Since this is still blocked on the other PR, I'm going to go ahead and mark this as a draft just to avoid having it come up in our triage queue. Once the blocking issue is resolved, this can be marked as ready for review again.

Closing since https://github.com/flutter/plugins/pull/6282 is now closed.

authors: ditman kristoffer-zliide stuartmorgan

repo: flutter/plugins


text:
Flutter 3.3 stable - use loadBuffer instead of load in ExtendedNetworkImageProvider and other providers

Hey,
As suggested here - https://docs.flutter.dev/release/breaking-changes/image-provider-load-buffer
Please update the package to support faster image decoding.
Thanks.

do it later

done

authors: naamapps zmtzawqlp

license: MIT


text:
dio 3.0.0 cookie DioError [DioErrorType.RESPONSE]: Http status error [400]

Let me simulate the request. It's always 400 or 404
thank you
Map<String,dynamic> params ={
'Accept-Encoding': 'gzip, deflate',
'Accept-Language': 'zh-Hans-CN;q=1',
'Connection': 'keep-alive',
'Content-Type': 'application/json;charset=utf-8;',
'Host': 'http://apihome.ishangclub.com/',
'User-Agent': 'AishanTribal/2.1.0 (iPhone; iOS 13.2.3; Scale/3.00)',
"Accept": "application/json",
"${HttpHeaders.cookieHeader}":"PHPSESSID=hrffobvrqtg3n8342s4qr49na6"
};
var dio =  Dio(
// BaseHttp.baseConfig()
);
//http://apihome.ishangbuluo.com/versionCheck
//http://www.mocky.io/v2/5e02db7e31000059006b2a14
// dio.options.baseUrl='http://apihome.ishangclub.com/';
dio.options.headers=params;
Response response= await dio.get("http://apihome.ishangclub.com/versionCheck");
print(response.data);
print("头====${dio.options.headers}");
print("头====${response.data}");

这是我抓取iOS 请求服务器的参数，总是请求头错误，你知道到为什么？

repo: flutterchina/dio


text:
[4.0] fix get http headers

New Pull Request Checklist

[x] I have read the Documentation
[x] I have searched for a similar pull request in the project and found none
[x] I have updated this branch with the latest master to avoid conflicts (via merge from master or rebase)
[x] I have added the required tests to prove the fix/feature I am adding
[x] I have updated the documentation (if necessary)
[x] I have run the tests and they pass

This merge request fixes / refers to the following issues: ...
Pull Request Description
...
fix #1059

this will fix my problems too

finally someone fixed this problem, great day! :)

This will fix my problems too

i waiting this :)

This will fix my problems too

This will fix my problems too

Good job, sir. I was waiting for it.

That's a miracle! Thank you a lot!

Approve please, i need so much this.

fixed in 4.0.0-prev2, example: https://github.com/flutterchina/dio/blob/7534c1c9aa4577914a176e055a915b9b1220027a/dio/test/options_test.dart#L195

it not fix the problem, in GET method continue removing content-type from headers....

fixed in 4.0.0-prev2, example:
https://github.com/flutterchina/dio/blob/7534c1c9aa4577914a176e055a915b9b1220027a/dio/test/options_test.dart#L195

in this test, you confirm that the headers will be always deleted in GET Method !!
it's not make sense deleting this!!

I have tested too. Really it's not solved! The fix have no link with the initial issue.

set dio.options.setRequestContentTypeWhenNoPayload = true;

@wendux, this flag works here!!!! thanks a lot!

@fogaiht @MaxweelFreitas set dio.options.setRequestContentTypeWhenNoPayload = true;

thank you man. Solvev my problem :100:

authors: BlackLeg15 JBDionisio MaxweelFreitas OrlandoEduardo101 arthurgiani fogaiht matheusperez toshiossada vianafgbluiz wendux


text:
[Question]: ¿Why i can share PDFs from Android but not from iOS?

What is your question?
I'm using this library to share an PDF document into whatsapp, messenger and gmail, Android works pretty fine but in iOS i recibe a message without the pdf.

Checklist before submitting a question

[X] I Google'd a solution and I couldn't find it
[X] I searched on StackOverflow for a solution and I couldn't find it
[X] I read the README.md file of the plugin
[X] I am using the latest version of the plugin
[X] All dependencies are up to date with flutter pub upgrade
[X] I did a flutter clean
[X] I tried running the example project

license_source: bigquery


text:
fix(battery_plus): battery save mode check on Huawei devices

Description
There was an issue with the Huawei P30 Lite and the battery check.
Related Issues
https://stackoverflow.com/a/70500770
Checklist

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I titled the PR using Conventional Commits.
[x] I did not modify the CHANGELOG.md nor the pubspec.yaml files.
[x] All existing and new tests are passing.
[x] The analyzer (flutter analyze) does not report any problems on my PR.

Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?

[ ] Yes, this is a breaking change (please indicate that with a ! in the title as explained in Conventional Commits).
[x] No, this is not a breaking change.

Works for me on a real Huawei P30. I don't have any other Huawei.

Alright, that is enough to know that it is tested on some real device.
In such case I would like to address the comment above about changing if ( ... to annotation and we are good to merge.

@stefanschaller If you don't want to follow-up on requested changes at least do not block the write access to original repo maintainers.

Closing this one and will open my own PR with these changes as I don't have feedback from the author and the fork is closed for modification.

authors: stefanschaller vbuberen


text:
Upgrade Terraform version to v1.6.x for tf-runner

I see TF version has been upgraded to v1.5.7 in ToFu controller release v0.16.0-rc4.
However, I need some fix in Terraform v1.6.x. Can you please upgrade TF version to v1.6.x?

Without involved to the project and the discussions in the background, I think the Hashicorp Terraform License change (https://www.doppler.com/blog/what-the-terraform-license-change-means-for-devops) makes this impossible without legal topic/problems
Currently I think this project moves strong to OpenTofu.
Disclaimer I'm not a project member this is only my opinion to this topic.

Thank you @krone-rose , I'm also aware of that. I think Terraform v1.5.x is the last version under MPL licence.
So the question is, what's the roadmap of tf-runner in the future?

The current roadmap is mainly focusing on getting native openTofu support, but keeping support for the latest MPL licensed version of the hashicorp terraform as well.
The license change blocks us from upgrading due to legal concerns.
It is possible to build a custom runner image yourself, and include the updated terraform binary and it should work, but we can't officially support it.

Closing as completed. Please reopen if needed.

authors: akselleirv ilithanos krone-rose tao-zhang-shell

repo: flux-iac/tofu-controller


text:
Add getting started SDK docs (#912)

Description of change
Checklist

[ ] Tested in playground or other setup
[x] Documentation is changed or added
[ ] Tests and/or benchmarks are included
[ ] Breaking changes

This change is

@hasit , looks like our documentation PRs have some overlap; Should we have a sync on how to combine those?

repo: fluxninja/aperture


text:
🛑 AOL is down

In d634325, AOL (https://extranet.osam.org.ar/OSAM) was down:

HTTP code: 0
Response time: 0 ms

Resolved: AOL is back up in 930547c after 13 minutes.

repo: flvanney/OSAMuptime


text:
fix: prevents pre and post deployer from running into an error on spe…

Fixes #115
Checklist
All items have to be completed before a PR is merged

[x] Adhere to Contribution Guidelines
[x] Updates to Decision Records considered?
[x] Updates to documentation at flxbl-sfp Guide considered?
[x] Tested changes?
[x] Unit Tests new and existing passing locally?

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

authors: CLAassistant Schuchie

repo: flxbl-io/sfp


text:
The app scanner for ActionCable should check if the config needs Redis

Right now, if ActionCable is being using, we try to add redis even if ActionCable is not configured to use redis. It would be better to make the check a bit smarter in determining if redis is actually required.

Take a peek at https://github.com/fly-apps/dockerfile-rails/blob/main/lib/dockerfile-rails/scanner.rb, and look for references to anycable.
Also, you can experiment with:
bin/rails console
> YAML.load_file('config/cable.yml')

repo: fly-apps/dockerfile-rails


text:
CLISuite.TestPs: timed out waiting for scale events

FAIL: test_cli.go:174: CLISuite.TestPs

++ 02:20:51.367 created app shrews-capture-latchford (2446b3e2b3e040c7b603273f67b6a69e)
++ 02:20:51.441 /home/ubuntu/go/src/github.com/flynn/flynn/test/../cli/bin/flynn -a shrews-capture-latchford ps
ID  TYPE

++ 02:20:51.486 /home/ubuntu/go/src/github.com/flynn/flynn/test/../cli/bin/flynn -a shrews-capture-latchford scale echoer=3
scaling echoer: 0=>3

02:20:54.601 ==> echoer dcc5935e-99ce4080b31a40cfbcdd423fef8a31c7 up
02:20:55.761 ==> echoer dcc5935e-30f2ba9112cc465896573bd7fed136c4 up
timed out waiting for scale events

test_cli.go:184:
    t.Assert(app.flynn("scale", "echoer=3"), Succeeds)
... result *main.CmdResult = &main.CmdResult{Cmd:[]string{"/home/ubuntu/go/src/github.com/flynn/flynn/test/../cli/bin/flynn", "-a", "shrews-capture-latchford", "scale", "echoer=3"}, Output:"scaling echoer: 0=>3\n\n02:20:54.601 ==> echoer dcc5935e-99ce4080b31a40cfbcdd423fef8a31c7 up\n02:20:55.761 ==> echoer dcc5935e-30f2ba9112cc465896573bd7fed136c4 up\ntimed out waiting for scale events\n", Err:(*exec.ExitError)(0xc20803b218)}

https://ci.flynn.io/builds/20150322021041-b34029e3

Duplicate of #907.

authors: jvatic lmars

repo: flynn/flynn


text:
Dynamic scaling for applications

Some of our developers are going to need the ability to dynamically scale their applications according to in-app load, which may present in any number of ways (e.g. SQS queue length, number of records in a ES query, etc.) not directly available to Flynn. It would be good if there was a way for those applications to handle measurement of those variables themselves, and then signal Flynn (from within the app) to scale up or down processes in response.

It would be good if there was a way for those applications to handle measurement of those variables themselves, and then signal Flynn to scale up or down processes in response.

This can currently be done by having the monitoring process use the Flynn API to scale the formation up, though hooking up "auto scaling" of some type is definitely a future thing we want.

Issue is that such would currently involve giving the monitoring process the keys to the API, which is (to my eye, at least) a security risk.

Makes sense. We'll be adding granular authorization throughout Flynn in the near future so that risk will be mitigated.

Any progress on this?

@abagshaw beyond the idea of having a monitoring process which runs flynn scale as required, no explicit progress has been made on this.

If we were using GCP - is there some way to use Google's auto-scaler to automatically bring new compute instances online from an image that contains Flynn if the CPU usage reaches a certain threshold - and when the new instance is brought online it is automatically added to the Flynn cluster and Flynn can begin to spread processes to it?

Actually I suppose one problem with this would be scaling down - GCP's auto scaler could terminate a node that may be still handling a few requests resulting in those final few requests failing. Is that why auto-scaling and load-balancing has to be done by the same service?

Not sure about GCP but AWS for instance has lifecycle hooks and termination notices for ASGs that you can use to drain nodes when scaling down.

Does Flynn have an easy way to pipe those terminations notices in and then automatically drain the node - or is that something that will require custom modification of the source?

Flynn currently doesn't have this capability but it is something that could be added to the scheduler.
If you are interested in working on this feature I am sure myself or other Flynn developers can provide guidance.

I don't have time to work on that right now - but if I do have some time in the future I'll get in touch and get some direction on how to tackle this. Thanks!

This is the last feature I really need to move a whole bunch of clients' systems off of AWS ElastiBean.
@lmars What are the odds we could get a "checkbox" right next to the process control in the dashboard (web, console, and such) that would just bump the number by 1 (if resources are being used close to the max - CPU, RAM in the underlying docker container) and decrease the number by 1 (if resource use is dropping)?
I don't need super granular control (over what exactly what the amount to trigger a resize should be) but something that won't exceed the Layer 0 hardware and cause instability would be awesome, and I could sell it as the "future plan". Help me Obi Wan Marshall, you're my only hope.
If I could write Go code in some manner, I'd take a crack at it myself but I'm a total noob that went the Rails route.

Several of our users are currently running per-application autoscaling, by installing Flynn within the application and using it to signal the cluster as necessary. This feels a "more correct" path to take, as what counts as load worth responding to is a very individual thing to the process: some of them, for instance, scale based on the size of an external queue that they process.

@temujin9 I rather like this approach but there should be some official documentation with best practices for this. I don't want to throw a .flynnrc file in there, commit it to Github and start loading it into Rails.

@temujin9 regarding "using it to signal the cluster as necessary" - could you please share an example of how Flynn can signal when the app requires scaling?

@temujin9 Oh man, we just kicked a hornet's nest. There's like 7 people on this Issue and all of them want their Flynn scaling and they want it now.

@WriteCodeEveryday We currently use a sidecar application to ship credentials (via S3) in a secure manner. You could also use environmental variables, if you don't want to go that far.
@eyalrosen Unfortunately, the example code is proprietary, so I cannot share it directly. However, the core of it is simple to describe: ship in Flynn credentials, make your scaling decisions in your code, and then shell out to the flynn binary and call flynn scale [proc]=[N] as appropriate.

@temujin9 Now I want to write a Rails gem for this. Maybe something on top of resource_monitor.
Why do you hate my weekends, man?

@WriteCodeEveryday that would be amazing :)

Flynn is unmaintained and our infrastructure will shut down on June 1, 2021. See the README for details.

authors: WriteCodeEveryday abagshaw eyalrosen josephglanville lmars temujin9 titanous


text:
Push git tag to master fails if tag has a message

When deploying to Flynn I frequently push a tag rather than a branch git push flynn v1.0.0:master. When creating the tag if I use the message option git tag v1.0.0 -m "any message" I get a failure when pushing to flynn. The application actually successfully deploys, but then I immediately get the following error:
fatal: protocol error: bad line length character: erro
fatal: The remote end hung up unexpectedly
fatal: The remote end hung up unexpectedly
error: failed to push some refs to 'https://git.flynn.hostname.com/app-name.git'

Without the -m option I don't get the error.

This is easily reproducible, we'll work on a fix.

Thanks!

@kevinob11 ok so this kind of push leads to an error from git on the server side:
error: Trying to write non-commit object e51a7409abe1a08aade57c8ce6f7afdd8f50887a to branch refs/heads/master

I came across this SO answer which explains why this is failing (you cannot push an annotated tag to a branch), and you can get around it by using the ^{type} "peeling" operator like so:
$ git push flynn v1.0.0^{commit}:master

Do you want to give that a try?

Ah yes, that works great, and even better the following shorthand:
git push flynn v1.0.0~0:master


text:
추가 요청입니다

Slack Nickname: 슬랙 닉네임 입력
Daniel Kim
https://github.com/dkim0827

추가 완료! 감사합니다~

repo: flynnpark/nomadcoders-github-list


text:
[Graph] Dynamic workflows should be visualized in the UI

Motivation: Why do you think this is important?
It's not really helpful to see a generic node placeholder in the UI graph overview of a workflow. Sending the DJO spec would allow the UI to render the dynamic job graph.
Goal: What should the final outcome look like, ideally?
It should be possible to visualize dynamic workflow structure.
Describe alternatives you've considered
Not implementing this.
[Optional] Propose: Link/Inline OR Additional context
If you have ideas about the implementation please propose the change. If inline keep it short, if larger then you link to an external document.

Already merged in, available from flyteconsole v.0.44.0

authors: anrusina katrogan

repo: flyteorg/flyteconsole


text:
fixing max parallelism

TL;DR
Removing the BarrierTick code from the TaskHandler resulted in scenarios where parallelism is not incremented when tasks are frequently evaluated with no change in phase / phase version. This can result in more task executing in parallel than configured.
Type

[x] Bug Fix
[ ] Feature
[ ] Plugin

Are all requirements met?

[x] Code completed
[x] Smoke tested
[x] Unit tests added
[ ] Code documentation added
[ ] Any pending items have an associated Issue

Complete description
^^^
Tracking Issue
fixes https://github.com/flyteorg/flyte/issues/3883
Follow-up issue
NA

is there any way we can verify this behavior with a local test (or a relatively cheap automated test)?

authors: eapolinario hamersaw

repo: flyteorg/flytepropeller


text:
Support for Teradata database

Motivation:
This PR aims to add support of Teradata database to Flyway. #1360
Context:
Teradata is a fairly standard database but like all others has its specificities.

Teradata does not have the notion of schema.
Teradata has a very convenient built-in SQL statement to clean a database (DELETE DATABASE).
Teradata does not support rollback for DDL statements.
Moreover, inside a transaction, the JDBC driver throws an exception if any statement (SQL or DDL) is found after a DDL statement.
SQLException : [Teradata Database] [TeraJDBC] [Error 3932] [SQLState 25000] Only an ET or null statement is legal after a DDL Statement.
In order to manage this specific behavior, Flyway will not wrap the migration in a transaction if any DDL statements is found in the file.

Tests:
I use the VMware image of a Teradata Express 15.0 available at http://downloads.teradata.com/download/database/teradata-express-for-vmware-player
The test ensures that mixing transactional and non-transactional statements within the same migration works.
It is really the only difficulty I had to manage.
Looking forward to your feedback.

Hello
I am very interesting by this PR. I am using Teradata and wanted to use Flyway to manage the sql migration with Flyway. Do have you any plan when this PR will be merged ?

@lecaillon Could you sign the CLA?

@axelfontaine CLA signed

@lecaillon
Tanks 😃

@axelfontaine, Any plan for merging this PR ?

@camory This is the main cause for delaying the merge: https://github.com/flyway/flyway/issues/1360#issuecomment-376153256

Any update about this PR ?

Any news about this PR ?

Wow, this is cool - thank you @lecaillon.  Would you be able to sign the CLA and address the merge conflicts?  I can help with further testing and development if you are interested.  I have working Teradata 15 & 16 VMs which I have used on other FOSS project work.

Hi Guys, what's the status on the PR? We would also be very interested in using Flyway with Teradata.

Hi there!
Whats the Status of the PR?
It would be great to implement Flyway at our warehouse.
Best, Matthias

Thank you for your submission. We cannot merge this at this time as it would need re-implementing in the https://github.com/flyway/flyway-community-db-support repository.

authors: Crudelis-rgb PhilippeDupont adrianyorke axelfontaine camory lecaillon othmaneH9 piers-williams schupp

repo: flyway/flyway


text:
Geometry

Add tesselation with geometry example

By the way, thank you for all your work! These examples are a huge help for people who want to use OpenGLAda.
I have corrected some small issues in the code I already accepted, including the spelling of tessellation in the other example. This was faster than requesting changes from you, I don't want it to take months to accept all your examples ;).

Its a pleasure working with you.
I hope to complete the frame buffer example sometime.
However I'm currently distracted trying to implement a similar example from http://www.opengl-tutorial.org/intermediate-tutorials (Tutorial 14) which is proving very difficult and has led me to attempting to "Adaerize" some of the SOIL code. I'm not sure how successful I'll be with this!
I have completed a couple of the basic opengl-tutorial tutorials.
Might it be useful to include these in the examples?
I still have trouble with .ignore "Conflicting files" in that I don't really understand the error message.

Every example code is useful. If you have others, please push them!

repo: flyx/OpenGLAda

license: mit


text:
🛑 Site suite is down

In cd0fd95, Site suite ($SECRET_SITE_1) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Site suite is back up in d9275d9.

repo: fmmaia/fmAtAllUptime


text:
Implemented Binary Search Tree with Python

Hello geek
Implemented BST with Python.
Let me know if you have a doubt!

@fms12 please review and let me know if you have other similar tasks.

pass these checks

For example, So your directory structure could be like this;
- DATA-STRUCTURE-AND-ALGORITHM-IN-PY
   -  LinkedList
       - Doubly
       - Singly
       - ReversedSingly     <----------- This will be your newly created folder
           - solution.py       <----------- Write the code for the implementation here
           - test_solution.py <----------- Write a test for it here to make sure it's working

There is already a LinkedList directory, which includes full Doubly and Singly linked list implementation. You can add yours Has a new directory ReversedSingly, then write the solution and test for it there.
Anyone could also add tests for it in the future to learn it.

Hey @fms12 can you guide me.
I want to know how to successfully passed the pytest run by github!

click s

Hey @fms12 can you guide me. I want to know how to successfully passed the pytest run by github!

go and click on the details of every pytest.

then you will get the error.

Thanks for helping me with that.
I check but there are also errors in different file!

I resolved error from my file!

@devvspaces  can you look at this?

Please help me in that!
I give a lot of try. Still can't figure out where gone wrong.

@devvspaces  can you look at this?

Sure I wil

@devvspaces @fms12 I found the reason for failure.
It's bcoz of others file which get merged in main before setting the automated pytest.
https://pybit.es/articles/linting-with-flake8/
Now we have 2 options we can ignore those error by a ignore script. (I can do this )
Or we can make change in each file.
Let me know what to do.

Hope this time Mayank it will get merge.
I tried each file having error. Can you please run the test.

Hope this time Mayank it will get merge. I tried each file having error. Can you please run the test.

@Kd-Here  you have to add comments in the binary search code .

Hope this time Mayank it will get merge. I tried each file having error. Can you please run the test.

@Kd-Here you have to add comments in the binary search code .

In file binary_search.py?
I think we need to change testing part. Because testing part was added after many PR. Which giving error in latest PR.
Can you merge  my PR. I will try to edit all code later with automated tool.

Hope this time Mayank it will get merge. I tried each file having error. Can you please run the test.

@Kd-Here you have to add comments in the binary search code .

In file binary_search.py? I think we need to change testing part. Because testing part was added after many PR. Which giving error in latest PR. Can you merge my PR. I will try to edit all code later with automated tool.

all things are good just add comment in your code "Binary search  tree code "

Hi, i am on this now

@Kd-Here , this was the first error you got in your PR, it's just a deep source python error. This is the first commit https://github.com/fms12/DATA-STRUCTURE-AND-ALGORITHM-IN-PY/pull/216/commits/4d81a910fcacb5ada7512566cd6db671cdadc6cc
When you started having flake8 problems was here https://github.com/fms12/DATA-STRUCTURE-AND-ALGORITHM-IN-PY/pull/216/commits/9e547ad4ca6a8db165bf921fcb7c92bde18e6a20.

I see you have edited others code too, what you can do now, to not worry yourself is this.

Copy the folder that contains just your code. Place is somewhere else, outside of your repo.
Create another repo using fork
Place your folder back to it's position and make a PR, let's start from there.

Reason is this, when i run flake8 now on the current code base there were zero errors. Now i see you have edited a lot of other files, that are now showing error with flake8

Do you understand me @Kd-Here

Yes I got it.
I will create a PR of only changes in my code.

authors: Kd-Here devvspaces fms12


text:
fix: available_locales to come from backend instead of I18n

This resolves an issue, in which available_locales for fallbacks are different than the ones provided in the custom backend. The change will allow the existing behaviour (with SimpleBackend) to remain the same but fixes the value returned when the custom backend is being used.
Co-Authored-By: @jfhinchcliffe

Thanks for submitting a PR
Can you explain more about the issue?
What's the difference between I18n.available_locales and I18n.backend.available_locales?
Is it possible to add test case? Or can you explain how you verify this change fixes the issue?

Oopsie! We've prematurely opened a pull request. We will follow up with the updated test suite and examples early next week.

authors: PikachuEXE blazeblazeblaze