text:
Feature Request: @topic would be nice

This is a feature request, not a bug report.
I hate making feature requests because the response is inevitably a recommendation that I read the docs more carefully since I just proposed a supported feature.  Still, I did a search and did some reading and web searching but came up empty.  Here's my request.
As I understand it, @all and @everyone are synonyms that refer to everybody subscribed to the stream.  Sometimes, though, it would be useful to notify everybody participating in a topic.  @topic might be nice for that purpose.
Incidentally, I'm not sure @all and @everyone are documented.  A search for "@everyone" on your "read the docs" site yields six responses, none of which include the "@" and none of which refer to this feature. http://zulip.readthedocs.io/en/latest/search.html?q=%40everyone&check_keywords=yes&area=default#

What do you mean by everyone participating in a topic? Everyone who has sent a message in that topic?

I think an @topic that mentions everyone who has participate in the topic would be fairly doable, implementation-wise.  I kinda like the idea.  Tagging this with priority: medium so we don't forget about it.
@jvasile on the point of documentation have you seen https://chat.zulip.org/help/, specifically e.g. https://chat.zulip.org/help/at-mention-a-team-member, which isn't our best work, but does discuss it?  There's a copy at /help on any Zulip server (linked from the gear menu), and that's where this sort of user-facing documentation lives.
ReadTheDocs is only for developer and sysadmin documentation (is there a place we should explain this more explicitly?).

Ah, it makes sense that Read The Docs is for devs, not users.  I'm in both camps, so the line between the two is blurry.  That fail is on me and won't hit your normal users, so it might not be worth fixing.
That said, if I were writing your docs, I might want to be explicit about intended audience.  The place I would end up putting that is probably on the landing page for the documentation.  You currently have as paragraph 3 at http://zulip.readthedocs.io/en/latest/:
Further information on the Zulip project and its features can be
found at https://www.zulip.org and in these docs. Our code is
available at our GitHub repository.

Maybe insert as sentence 2:
These docs are aimed at developers and sysadmins.
Users should head to https://chat.zulip.org/help/ for help
on using Zulip.

One other thing I note is that chat.zulip.org doesn't have a search box.
Hope this helps!

@zulipbot claim

@zulipbot claim
Currently #1191 is on hold.

Ongoing work: #25828

Closing in favor of #22829.

authors: jvasile lonerz prakhar1144 timabbott umairwaheed


text:
api/tests : Adding tests for untested endpoints.

This pull request adds tests for the untested endpoints from the python-zulip-api repository.
The endpoints are mentioned below.
remove_reaction
delete_stream
get_alert_words
add_alert_words
remove_alert_words
create_user_group
update_user_group
remove_user_group
update_user_group_members
update_notification_settings
update_presence
update_stream

@eeshangarg Please review.

@eeshangarg Please review. It should be ready to get merged now.

@sameerchoubey: Looks good now, merged! Thanks for working on this! :)

source: gharchive/pull-request

authors: eeshangarg sameerchoubey

repo: zulip/zulip

license_type: permissive

license_source: github-api


text:
unread: Convert ids.push(...a) to a loop

Calling a function with hundreds of thousands to millions of arguments, depending on the browser, can throw a RangeError. This was true of both ids.push(...a) and the [].concat.apply construction that it replaced in commit 59d55d1e065bfabc105b97dd5664e186dc69f4a0, although the old one was less likely to overflow due to bucketing. Use a loop instead.

(The idea of hundreds of thousands of messages passing through here is slightly terrifying, though…)

When you "hundreds of thousands of messages", you're mostly talking about "message_ids" here, correct?

Merged, thanks @andersk!  We saw relevant exceptions in production which was the motivation for this change, though I believe by construction it was likely with 50K messages or less, since that's the most unread messages the server will send data on to the client.

authors: andersk showell timabbott


text:
apidocs: Add documentation of deactivate-my-account endpoint.

Fixes #16163
Testing plan:

Tested on localhost
Ran ./tools/test-api
Ran ./tools/test-backend

GIFs or screenshots:

@Hypro999 @orientor does either of you have time to review this?

@MSurfer20 thanks for working on this! deactivate-my-account seems a little bit out of the naming convention. For the rest of the endpoints of this type they are usually named as reactivate_own_user, etc. Hence I think you should change the operation ID of this endpoint in zulip.yaml and then change the filename accordingly. Other than that everything else LGTM.

Thanks for the review @orientor! I have made the required changes.

LGTM. @timabbott I think this is ready for a review.

@timabbott A ping regarding this PR, in case you lost track of this.

Thanks for all your work on this @MSurfer20!  This is pretty close, and I made the following minor manual changes in preparation for merging this:
diff --git a/templates/zerver/help/include/rest-endpoints.md b/templates/zerver/help/include/rest-endpoints.md
index 6ddb7a4732..d1b9f2d5ce 100644
--- a/templates/zerver/help/include/rest-endpoints.md
+++ b/templates/zerver/help/include/rest-endpoints.md
@@ -34,13 +34,13 @@

 * [Get all users](/api/get-users)
 * [Get own user](/api/get-own-user)
-* [Deactivate own user](/api/deactivate-own-user)
 * [Get a user](/api/get-user)
 * [Get a user by email](/api/get-user-by-email)
 * [Update a user](/api/update-user)
 * [Create a user](/api/create-user)
 * [Deactivate a user](/api/deactivate-user)
 * [Reactivate a user](/api/reactivate-user)
+* [Deactivate own user](/api/deactivate-own-user)
 * [Set "typing" status](/api/set-typing-status)
 * [Get user presence](/api/get-user-presence)
 * [Get attachments](/api/get-attachments)
diff --git a/zerver/openapi/python_examples.py b/zerver/openapi/python_examples.py
index 6b25f5c9db..9d241e5347 100644
--- a/zerver/openapi/python_examples.py
+++ b/zerver/openapi/python_examples.py
@@ -394,16 +394,17 @@ def get_profile(client: Client) -> None:

 @openapi_test_function("/users/me:delete")
 def deactivate_own_user(client: Client, owner_client: Client) -> None:
-
     user_id = client.get_profile()["user_id"]
+
     # {code_example|start}
-    # Deactivate the profile of the user/bot that requests this endpoint,
-    # which is `client` in this case:
+    # Deactivate the account of the current user/bot that requests.
     result = client.call_endpoint(
         url="/users/me",
         method="DELETE",
     )
     # {code_example|end}
+
+    # Reactivate the account to avoid polluting other tests.
     owner_client.reactivate_user_by_id(user_id)
     validate_against_openapi_schema(result, "/users/me", "delete", "200")

diff --git a/zerver/openapi/zulip.yaml b/zerver/openapi/zulip.yaml
index e449f14874..db526abaf7 100644
--- a/zerver/openapi/zulip.yaml
+++ b/zerver/openapi/zulip.yaml
@@ -4555,7 +4555,12 @@ paths:
       operationId: deactivate_own_user
       tags: ["users"]
       description: |
-        Delete the requesting user from the realm.
+        Deactivates the user's account.  See also the administrative endpoint for
+        [deactivating another user](/api/deactivate-user).
+
+        `DELETE {{ api_url }}/v1/users/me`
+
+        This endpoint is primarily useful to Zulip clients providing a user settings UI.
       responses:
         "200":
           description: Success.

However, I have one code cleanup thing I need you to fix before it's ready (will comment inline).

I ended up deciding to merge this after posting https://github.com/zulip/zulip/pull/17014/commits/6e6e820f001845d0672eba0f92686491a632540f#r601173277, after some reflection on how much work it'll be to do something that's significantly cleaner.

@timabbott Thanks for the merge! Opened #17795 for the issue.

authors: MSurfer20 orientor timabbott


text:
templates: Fix  →  to be parseable by FormatJS

Fixes #18220.

Merged, thanks @andersk!  Is there a way we could make new strings not parseable by FormatJS fail CI?

One obvious thing to do is #18228. For JS, I plan to enable eslint-plugin-formatjs, but first I need to fix it to support additionalFunctionNames.

authors: andersk timabbott


text:
Fix modal button colors in dark theme.

discussion: https://chat.zulip.org/#narrow/stream/101-design/topic/modal.20buttons.20in.20dark.20theme

Merged, thanks @amanagr!

authors: amanagr timabbott


text:
settings: Show all bots in organization settings.

As stated in the help documentation, the user should be able to see all bots in the organization. This extends people.js to provide a way to access all bot users, and update organization settings to display all bots for non-admin users as well.
chat

Screenshots and screen captures:

Self-review checklist

[ ] Self-reviewed the changes for clarity and maintainability
(variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

[ ] Explains differences from previous plans (e.g., issue description).
[ ] Highlights technical choices and bugs encountered.
[ ] Calls out remaining decisions and concerns.
[ ] Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

[ ] Each commit is a coherent idea.
[ ] Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

[ ] Visual appearance of the changes.
[ ] Responsiveness and internationalization.
[ ] Strings and tooltips.
[ ] End-to-end functionality of buttons, interactions and flows.
[ ] Corner cases, error conditions, and easily imagined bugs.

Works for me in manual testing! @sahil839 could you please review this one?

Looks good to me.

Merged, thanks @PIG208!


text:
[WIP]GoCD integration not working

Implemented the new approach by using a 3rd party plugin and added docs according to new implementation techniques.
To Do:

[ ] Write appropriate message for the Bot
[ ] Write tests

Will potentially fix #21224

Screenshots and screen captures:

Two major comments:

Look at our webhook documentation and follow the guide -- e.g. you need to capture a set of test fixtures for the integration.
The formatting is not great. Look at our other continuous integration/delivery integrations for samples of more natural/readable formatting.

@laurynmm can you review this one?

@laurynmm Can you please take a look at this PR.

Thanks for the fix! To get the PR ready for review, please update your commit message to match the commit style guidelines.

@alya Thank you for the review. I've updated the commit message to match the guidelines.

The message still does not match the guidelines -- you need to use correct capitalization and punctuation.

@alya Made the corrections.

Thanks for the effort on this @swayam0322!

authors: alya swayam0322 timabbott


text:
info_density: Express Markdown and message-box spacing as CSS variables.

This PR introduces variables for the 5px and 10px inter-element spacing variables found in the Markdown area. It preserves the legacy values inside .more-dense-mode, and calculates the database-stored values outside of that.
CZO discussion
Screenshots and screen captures:

Before
After, legacy vars (no change)
After, db vars

Self-review checklist

[x] Self-reviewed the changes for clarity and maintainability
(variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

[x] Explains differences from previous plans (e.g., issue description).
[x] Highlights technical choices and bugs encountered.
[x] Calls out remaining decisions and concerns.
[x] Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

[x] Each commit is a coherent idea.
[x] Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

[x] Visual appearance of the changes.
[x] Responsiveness and internationalization.
[x] Strings and tooltips.
[x] End-to-end functionality of buttons, interactions and flows.
[x] Corner cases, error conditions, and easily imagined bugs.

I can't decide how I feel about the minor rounding changes; they seem like a wash though I'm a bit surprised as to their scale. In any case, the approach seems solid and the risk to main is basically none.
Great to see these variables defined, merged, thanks @karlstolley!

Yeah. Especially given the precise areas that will take some of the internment spaces, there's an argument to be made to round those off to whole-pixel values. Most other UI elements have their own line-height that's adjusted for icons and other furniture, so I'm less concerned about subpixel rounding of that value.
Regardless, I expect a lot of discussions around these issues on CZO in the coming days and weeks.

authors: karlstolley timabbott


text:
attachment: Add file icon to the green box when file has no extension

Fixes #3848.

Looks reasonable to me.
@brockwhittaker can you give this one a review, since it's patching code you recently added?

Looks mostly good to me, but I'd consider moving the icon down ~2px so that it is vertically centered?

@brockwhittaker ready for review

Merged, thanks @refeed!!

authors: brockwhittaker refeed timabbott


text:
adding helloworld bot with readme file

Try attempt #3 with a hello world bot. (Each previous attempt files from other branches kept polluting this request)

Automated message from Dropbox CLA bot
@theairportexplorer, thanks for the pull request! It looks like you haven't yet signed the Dropbox CLA. Please sign it here.

Tested the new bot, works! Thanks @theairportexplorer, ready to merge from my side.

Merged, thanks @theairportexplorer!  I think a good follow-up step might be to use the new reply code here.

Automated message from Dropbox CLA bot
@theairportexplorer, thanks for signing the CLA!

authors: derAnfaenger smarx theairportexplorer timabbott


text:
subscriptions: Fix broken line wrapping in subscriptions modal.

Also includes miscellaneous CSS modifications (e.g. cleaning up broken selectors). Fixes #8718.
Testing Plan:
Manual testing on various screen widths.
GIFs or Screenshots:
Before:

After:

Merged all but the last commit.  I think the last commit isn't quite right: what we actually want is for the tooltip notice to appear above the other content, not inline with it (where it causes things to transition to the ... overflow styling).  I think we want to change z-index to make the tooltips in the same plane as the rest of the content.
I also noticed and opened https://github.com/zulip/zulip/issues/8743 while manually testing this...

@timabbott

@synicalsyntax can we have the text appear in a slightly different location so it points to the icon rather than covering over it?  Actually, thinking about this a bit more, we should possibly be using the same widget we use for the gear/magnifying class icons in the left sidebar.

@timabbott

Changed to use the same tooltips as the left sidebar icons.

Looks great!  Can you fix the node tests?

@timabbott Fixed!

@synicalsyntax that new version has the bug that the tooltips don't show up properly for a newly created stream, since you're only registering them for the initial streams.

@timabbott I'm getting a weird TypeError: $(...).tooltip is not a function error with my original solution; for some reason webpack can't compile correctly with it?

@synicalsyntax I think it's just that feature is defined by Bootstrap, which isn't required in the test file (Our node tests use a much more explicit-dependency model than the production code).

This suffices to fix the tests for the original implementation:
diff --git a/frontend_tests/node_tests/subs.js b/frontend_tests/node_tests/subs.js
index 1c431d5..e88fc71 100644
--- a/frontend_tests/node_tests/subs.js
+++ b/frontend_tests/node_tests/subs.js
@@ -15,6 +15,8 @@ zrequire('subs');
 var jsdom = require("jsdom");
 var window = jsdom.jsdom().defaultView;
 global.$ = require('jquery')(window);
+set_global('window', window);
+zrequire('bootstrap', 'third/bootstrap/js/bootstrap');

 subs.stream_name_match_stream_ids = [];
 subs.stream_description_match_stream_ids = [];

@timabbott Worked great, thanks so much! Waiting on tests to pass now :)

authors: synicalsyntax timabbott


text:
Manage dynamic z-index for multiple open off-canvas

How to reproduce this bug:

Have two off-canvas panels; add triggers inside off-canvas contents to trigger each-other
Open first-off-canvas; with any trigger from the page
From off-canvas content trigger the second-off-canvas
Second-off-canvas is  open,  from it's content trigger back the first-off-canvas

What should happen:

Last triggered off-canvas should be on top by changing Z-index.

What happened instead:

Both off-canvas panels are open, last off-canvas on Dom is on top, as they have fixed z-index

Browser(s) and Device(s) tested on:
MBA/Chrome
Foundation Version(s) you are using:
6.4

Is this a real bug or feature request?

Hi @klihelp, can you provide a codepen or some more clear instructions how we can test and reproduce this?

Closing as we did not receive further feedback.

source: gharchive/issue

authors: DanielRuf klihelp

repo: zurb/foundation-sites

license: mit

license_source: bigquery


text:
Foundation init

Hi,
I'm new to foundation (6), and I had some newbie problems with the library initialisation.
I now know that you need to call $(document).foundation(); to init the library but I could not find any reference in the documentation.
If I'm mistaken, I'd gladly have someone showing me where I can find this information :)
If not, please make it obvious in the documentation.

It's in the JavaScript page of the docs:
http://foundation.zurb.com/sites/docs/javascript.html#initializing

Thank you @colin-marshall :+1:
I thought it would be easily found, like on top of a Getting Started page.

Ya it would probably help to have something like a "Project Setup" page under the "Getting Started" section.

authors: colin-marshall nimaen


text:
Fix Off-canvas In-canvas feature

Fixes https://github.com/zurb/foundation-sites/issues/10585
To sum up the problem:
Most of the In-canvas feature is done via CSS only. But when opening the Off-canvas on e.g. small viewport (as regular offcanvas) and then doing a window resize to large viewport where it becomes in-canvas, some issues occur (overlay still visible etc.)
This PR fixes this by adding an inCanvasOn option.
To fix existing projects automatically (easy upgrading) I'm extracting the breakpoint name from the .is-in-canvas-for-[BREAKPOINT] class (if available) and use it as option if none set.
The docs have been updated accordingly with a callout.

I took a quick look at it in the subway and (obviously) did not understood everything. I'll take an other look tomorrow.

Thank @ncoden for the review and sorry for the late response: have been really busy at work...
I've adjusted the code now according to your feedback.
I really like to priority order you suggested and have implemented it this way:
CSS class > option > default
Besides I've adjusted the docs accordingly and prevented duplicate code by using a _checkInCanvas() method.
But regarding your question abt my changes in the open() method I haven't understood you.
My intention was to prevent any open action if inCanvas is currently true. So I'm just triggering a return in such a case.
Do you have another solution in mind?

@SassNinja Could you resolve conflicts ? (merge dev)

ok, I've merged develop into the in-canvas feature branch now

Ok I understand how incanvas works now. So to make the element going "in-canvas" we have off-canvas.in-canvas-for-#{$name} that take care of everything. But this is CSS-only so when opening the off-canvas and going back to in-canvas, the state of the Js offCanvas component doesn't change (and the overlay is still visible).
I think we could go further, making the whole inCanvas state controlled in Js (instead of having both CSS and Js media query). Instead of duplicating the @mixin in-canvas code across breakpoint, we would have a .is-in-canvas modifier added and removed by the Js, like .is-open. Also, we do not close the offCanvas when going "in canvas" but hide it, so when going back to offCanvas the offCanvas stay open.
@SassNinja What do you think ? Just an idea, this does not have be in this PR.

Right @ncoden that's exactly how the incanvas is supposed to work!
I like your idea to reduce the code and thought about it.
But I think moving the breakpoint logic from CSS to JS will also cause FOUC.
The incanvas feature is supposed to 'tranform' an off-canvas elem into regular page content and if this styling is dependent on JS there will be delay until the content appears.
So I think it's best way here to not move the breakpoint logic into JS and leave as it is.

But I think moving the breakpoint logic from CSS to JS will also cause FOUC.

You're right. I'll try to think of an other solution. If I got nothing before Friday I'll merge it.

@ncoden regarding you haven't posted an other solution I assume it's good to merge? :-)

@SassNinja Friday is not finished yet ;)

Delaying this to v6.6.0 because this add a new feature.

authors: SassNinja ncoden


text:
Interchange + Layout switching on Tablets

I devved a site, with a background-image container interchanged right between body and /body:
<body>
    <div id="bgcontainer"
            data-interchange="[/files/layout/bg_1000.png,(only screen and (min-width: 900px))],
                              [/files/layout/bg_1200.png,(only screen and (min-width: 1150px))],
                              [/files/layout/bg_1600.png,(only screen and (min-width: 1550px))]">
    </div>
</body>

Then, for JS screwups + tin foil heads I added some css to load depending on the available min-width:

#bgcontainer
{
    width: 100%;
    height: 100%;
    background-repeat: no-repeat;
    background-position: top left;
    background-attachment: fixed;
    background-size: 100%;
    overflow-y: scroll;
    overflow-x: hidden;
    @media(only screen and min-width: 900px) {

        background-image: url('/files/layout/bg_1000.png');
    }
    @media(only screen and min-width: 1150px) {

        background-image: url('/files/layout/bg_1200.png');
    }
    @media(only screen and min-width: 1550px) {

        background-image: url('/files/layout/bg_1600.png');
    }
}

But now comes the ipad 3 / Galaxy node pro 12.1 screwup when flipping the device:
Agile foo:
As the site's visitor, when changing the perspective from horizontal to vertical, I expect the background image to either resize or disappear because the min-width is not longer valid. Secondary sounds more reasonable.
Expected behaviour:
The perspective is changed, and the horizontal background image displays in filling 100% of the page's height. Or not at all, as mentioned above.
Actual result:
The horizontal background image displays in filling only 50% of the pages height.
Now that the docs only mention "replace" as an interchange container's available events, we either have to fix this or make the user aware then when a perspective is being changed certain js commands have to be set. Either way, awesome module!
tested in android: ff + chrome @ latest + ios: safari + chrome @ latest

This looks like it works in the newest version of interchange. Sorry, for the delay in the close here. If I'm mistaken please feel free to reopen or just ping me.

authors: doertedev zurbrandon

repo: zurb/foundation


text:
Backend

Merge "backend" into main

Merge "backend" into main

license: MIT


text:
Updating web dependencie web 0.5.1 to web 1.0.0

Hello
With the new flutter updates, is necessary to update dependencies of flutter_mapkit_js; specific the web 0.5.1 to web 1.0.0

Updated. Please check it.

authors: sesanchezra zuvola


text:
refactor: replace xstate with a simple built-in state machine

This PR introduces a custom state machine implementation, which is much less powerful than xstate but at the same time much less complex. It now replaces xstate where that was previously used (sending frames, node status, receiving transport service frames).

@zwave-js-bot automerge

repo: zwave-js/node-zwave-js


text:
fix(ui): preferred scales alignment

Correctly align preferred scales with log enabled on settings -> Zwave.
Currently:

After:

Pull Request Test Coverage Report for Build 7300540499

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 22.208%

Totals

Change from base Build 7297927674:
0.0%

Covered Lines:
3735

Relevant Lines:
17888

💛  - Coveralls

I don't remember now, does it align well on MD sceeens too?

I see it well on 900px screens using Chrome 120.0.6099.109:

But on SM screens I see bad others as Max files or Inclusion/Exclusion timeout:

I will also fix this in the PR.

@zwave-js-bot fix lint

authors: alexojegu coveralls robertsLando

repo: zwave-js/zwave-js-ui


text:
fix: unknown manufacturer

Fixes #373
Fixes #347

Pull Request Test Coverage Report for Build 518169074

0 of 24 (0.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.02%) to 21.88%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

lib/ZwaveClient.js
0
24
0.0%

Totals

Change from base Build 517679755:
-0.02%

Covered Lines:
2058

Relevant Lines:
9627

💛  - Coveralls

Pull Request Test Coverage Report for Build 518169074

0 of 24 (0.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.02%) to 21.88%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

lib/ZwaveClient.js
0
24
0.0%

Totals

Change from base Build 517679755:
-0.02%

Covered Lines:
2058

Relevant Lines:
9627

💛  - Coveralls

Like we discussed, I would do it differently. When node is ready, use getDefinedValueIDs() to

detect which values are added and add them
detect which values were removed and remove them
update the others.

Like we discussed, I would do it differently. When node is ready, use getDefinedValueIDs() to

detect which values are added and add them
detect which values were removed and remove them
update the others.

Like we discussed, I would do it differently. When node is ready, use getDefinedValueIDs() to

Isn't the result of what I did the same?

Like we discussed, I would do it differently. When node is ready, use getDefinedValueIDs() to

Isn't the result of what I did the same?

The way I'm seeing it, you do 2. but not 1. or 3.

The way I'm seeing it, you do 2. but not 1. or 3.

@AlCalzone When node is ready I get a reference of the existing node values, clear all actual node values , I get all the new defined values, I parse one by one and I check if it was existing (and if it has changed). The removed ones are not there so and the new ones are reported

@AlCalzone When node is ready I get a reference of the existing node values, clear all actual node values , I get all the new defined values, I parse one by one and I check if it was existing (and if it has changed). The removed ones are not there so and the new ones are reported

Ok then I didn't understand the consequences.

Ok then I didn't understand the consequences.

authors: AlCalzone coveralls robertsLando


text:
feat: split prioritized CCs and discover first

This PR tries to help dependent CCs to be discovered first.

Add Constant to allow easy addition of priority CCs
add a small function to create split list
iterate through the list

Pull Request Test Coverage Report for Build 579073570

16 of 33 (48.48%)  changed or added relevant lines in 2 files are covered.
11 unchanged lines in 1 file lost coverage.
Overall coverage increased (+0.2%) to 19.454%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

lib/Gateway.js
13
30
43.33%

Files with Coverage Reduction
New Missed Lines
%

lib/Gateway.js
11
20.46%

Totals

Change from base Build 578909566:
0.2%

Covered Lines:
2034

Relevant Lines:
10723

💛  - Coveralls

This is part of multiple PRs to solve the RGBW
this first PR is to increase HASS flexibility and tries to partially solve : #595 #477 and #351
After that another pr will introduce an improved Color Switch

authors: billiaz coveralls


text:
Current status of the project

@zyedidia Will there be any new commits/merges soon?

Finding time to work on the project has been difficult for me lately. The most recent progress can be seen on the "refactor2.0" branch (I have done some development recently) but I'm not sure when that branch can be merged (all that remains is plugins). When it is ready to merge I plan to go through all the issues and close the ones it fixes as well as rebase it with pull requests that have been merged since it was started.

@zyedidia Thanks for the info, it is good to know what is going on. I hope you can figure out a way how to get along with the little time you have at your disposal.

repo: zyedidia/micro


text:
Missing License

It's a great project.
But If it's not under an open-source license it would be great if you could be clear about that.
I would like to use it for my project if possible.

Apologies, I will update it with a license.

Done. #5

authors: darakuneko zykrah

repo: zykrah/firmware-scripts


text:
🛑 Auth Portal is down

In 43e37a6, Auth Portal (https://auth.zyradyl.moe) was down:

HTTP code: 523
Response time: 2817 ms

Resolved: Auth Portal is back up in a296711 after 9 minutes.


text:
🛑 Maple - Access Portal is down

In 428bd9f, Maple - Access Portal (https://maple.zyradyl.moe) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Maple - Access Portal is back up in 90e29a4 after 7 minutes.


text:
🛑 N40 at FRP is down

In 4875c6e, N40 at FRP (origin.$DOMAIN_CN) was down:

HTTP code: 0
Response time: 0 ms

Resolved: N40 at FRP is back up in 4bdc8a0 after 8 minutes.

repo: zzc-tongji/upptime


text:
add loading component and keycolor

loading component, prototype 추가

데이터 연동 작업할 때 생각보다 로딩 시간이 생겨서 로딩 컴포넌트를 추가했어요.
데이터 연동 시작전에 로딩을 시작하고 연동 완료되면 로딩을 끄도록 로직에 추가하면 될거에요.

keycolor 추가

keycolor 4가지를 variables.scss에 추가했어요.

=> 두 가지 모두 사용 예시는 코드에 설명 남길테니 참고해주세요.

Progress Bar 처리가 인상 깊네요 굿

repo: zzeulki/MiracleMorning


text:
Method Not Found when delete. Using preview 6 of .NET Core 5.

I am having a similar issue to #604 , but on preview 6 of .NET Core 5.
'Method not found: 'Void Microsoft.EntityFrameworkCore.Query.Internal.ParameterExtractingExpressionVisitor..ctor(Microsoft.EntityFrameworkCore.Query.IEvaluatableExpressionFilter, Microsoft.EntityFrameworkCore.Query.IParameterValues, System.Type, Microsoft.EntityFrameworkCore.Metadata.IModel, Microsoft.EntityFrameworkCore.Diagnostics.IDiagnosticsLogger`1<Query>, Boolean, Boolean)'.'
at .(IQueryable , RelationalQueryContext& , QuerySqlGenerator& )\r\n
at Z.EntityFramework.Extensions.BatchDelete.CreateCommand(IQueryable query, IEntityType entity)\r\n
at Z.EntityFramework.Extensions.BatchDelete.Execute[T](IQueryable`1 query)\r\n
at Z.EntityFramework.Plus.BatchDeleteExtensions.Delete[T](IQueryable`1 query, Action`1 batchDeleteBuilder)\r\n
at Z.EntityFramework.Plus.BatchDeleteExtensions.Delete[T](IQueryable`1 query)\r\n
at KratorLab.Services.EntityService.DeleteEntity(Guid id) in D:\\Lab\\Krator\\KratorLab\\Services\\EntityService.cs:line 114"

My code:
appDbContext.EntityRelationships
    .Where(r => r.Id == relationship.InverseRelationship.Id)
    .Delete();

Hello @DPiaz ,
Thank you for reporting, we had already a task planned this weekend to check the compatibility with the latest preview version.
It should be fixed by the start of next week,
Best Regards,
Jon

Performance Libraries
context.BulkInsert(list, options => options.BatchSize = 1000);
Entity Framework Extensions • Entity Framework Classic • Bulk Operations •  Dapper Plus
Runtime Evaluation
Eval.Execute("x + y", new {x = 1, y = 2}); // return 3
C# Eval Function • SQL Eval Function

Ok, thanks.

Hello @DPiaz ,
A new version has been released which support the latest preview of EF Core 5,
Let us know if everything works as expected.
Best Regards,
Jon

Hi.
Great, now this works.
Thanks.

authors: DPiaz JonathanMagnan

repo: zzzprojects/EntityFramework-Plus


text:
Signed Nuget Package seems to be much slower

Currently using the Signed Version but the Performace is really bad. Same Code with the Unsigned Version works great.

It looks like the signed NuGet package has been compiled as Debug rather than Release. Unfortunately as the original maintainers of the project are not working on the project - unless you (or somebody else) wanted to take on it's maintenance and release a new signed package - this won't change anytime soon.
Check it using Assembly Explorer:
https://assemblyinformation.codeplex.com/

Hello @Franklin89 , @deenairn ,
I'm the new owner of GraphDiff,
Where can you find this signed version? I just want to make sure it's not an official package from the old owner. Obviously, I can easily find some signed version on NuGet that are unofficial, I just want to make sure I have not missed something.
I normally sign all my assembly and offer only the signed version, so I believe I will release soon a signed version.
Best Regards,
Jonathan

It's here:
https://www.nuget.org/packages/RefactorThis.GraphDiff.Signed/
It's not official as far as I can see, it wasn't uploaded by the original repo owner.

Hello @deenairn ,
Thank you. Yes, that's not an official package.
I will release a signed version this weekend. The package will be now always signed.
I will contact all owners that have a Signed version to redirect to the main package if they want.
This package was already on my list, I just wanted to make sure ;)
Best Regards,
Jonathan

Hello @deenairn , @Franklin89 ,
Starting by the v3.0.0, the official package will now use a signed version.
Other owners have been contacted to remove package to avoid confusion
Best Regards,
Jonathan

Thats awesome :-) thanks. @JonathanMagnan

authors: Franklin89 JonathanMagnan deenairn

repo: zzzprojects/GraphDiff


text:
chore(deps): pnpm update

Pull Request Test Coverage Report for Build 12023240431
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 74.451%

Totals

Change from base Build 12022635074:
0.0%

Covered Lines:
12422

Relevant Lines:
16505

💛  - Coveralls

authors: coveralls kelsin


text:
[important] 代码重构

一个Form类写一千行代码离谱了，得想办法处理下

我觉得有必要重构


text:
Add files via upload

This is plagiarised clearly , need to make some changes


text:
Update build.gradle to enable assertions

Codecov Report

Merging #128 (8323b0f) into master (124b0a8) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #128   +/-   ##
=========================================
  Coverage     66.00%   66.00%
  Complexity      501      501
=========================================
  Files            95       95
  Lines          1721     1721
  Branches        193      193
=========================================
  Hits           1136     1136
  Misses          530      530
  Partials         55       55

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 124b0a8...8323b0f. Read the comment docs.


text:
Update final ppp

Codecov Report

Merging #336 (ab414ab) into master (5c62c33) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #336   +/-   ##
=========================================
  Coverage     83.85%   83.85%
  Complexity     1121     1121
=========================================
  Files           140      140
  Lines          2861     2861
  Branches        389      389
=========================================
  Hits           2399     2399
  Misses          384      384
  Partials         78       78

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


text:
Update dg

Codecov Report

Merging #224 (a77f973) into master (4e30818) will increase coverage by 0.01%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##             master     #224      +/-   ##
============================================
+ Coverage     39.53%   39.54%   +0.01%
  Complexity      363      363
============================================
  Files           113      113
  Lines          2130     2129       -1
  Branches        198      197       -1
============================================
  Hits            842      842
+ Misses         1216     1215       -1
  Partials         72       72

Impacted Files
Coverage Δ

.../travelr/logic/commands/AddEventToTripCommand.java
0.00% <0.00%> (ø)

...elr/logic/commands/DeleteEventFromTripCommand.java
0.00% <ø> (ø)

...rc/main/java/seedu/travelr/model/ModelManager.java
31.63% <0.00%> (-0.33%)
:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

authors: codecov-commenter gerardstevan


text:
Help window

Thank you! Looks great!


text:
As a user, I can give them zero or more tags so that I can easily classify different groups of patients by their illness, medication and other information to serve their specific needs.

Upload wrong


text:
Add find by one tag feature

LGTM!
nit:
it is not immediately clear to me (person without context) whats the diff btw FindTag and FindTagOr from just the name of the command itself. Could consider renaming.
could consider adding a simple summary on ur PR giving context to the PR itself to let reviewers have an idea of what to look out for. Title helps but I think as the PRs get more complex, having context would greatly aid the reviewers in their effectiveness as well.

LGTM!
nit: it is not immediately clear to me (person without context) whats the diff btw FindTag and FindTagOr from just the name of the command itself. Could consider renaming.
could consider adding a simple summary on ur PR giving context to the PR itself to let reviewers have an idea of what to look out for. Title helps but I think as the PRs get more complex, having context would greatly aid the reviewers in their effectiveness as well.

Excellent nits

Deleted the redundant find by 1 tag feature, please merge after looking through, thank you

authors: SimHanKiong tanyunchao ziyang27


text:
Add rocket league reward logging

Closing, as I think this is no longer in scope. Will open again on the new repo once we move the RocketLeague environment out of this package.

authors: benjamincburns some-rando-rl

repo: AechPro/distrib-rl


text:
update packages

:white_check_mark: Build TheIdServer 3.0.1-fix-dependencies1-0072 completed (commit https://github.com/Aguafrommars/TheIdServer/commit/856ea2f7b9 by @)

authors: AppVeyorBot aguacongas

repo: Aguafrommars/TheIdServer


text:
Fails to run on linux because of usage of backslashes in paths

solved


text:
Enforce the right HTTP methods on all API endpoints

@shahbaz-mehar the changes have been reviewed.

authors: maf-embraceit shahbaz-mehar


text:
add props logic and structure the project

added al requirement needed


text:
2023.1.1_rebuild

Linter check found the following problems:
The following problems have been found:
ERROR: /tmp/abs_bet_qmym9f/clone/recipe/meta.yaml:31: cython_needs_compiler: Cython generates C code, which will need to be compiled
ERROR: /tmp/abs_bet_qmym9f/clone/recipe/meta.yaml:31: cython_needs_compiler: Cython generates C code, which will need to be compiled
ERROR: /tmp/abs_bet_qmym9f/clone/recipe/meta.yaml:37: host_section_needs_exact_pinnings: Packages in host must have exact version pinnings, except python build tools.
ERROR: /tmp/abs_bet_qmym9f/clone/recipe/meta.yaml:38: host_section_needs_exact_pinnings: Packages in host must have exact version pinnings, except python build tools.
ERROR: /tmp/abs_bet_qmym9f/clone/recipe/meta.yaml:67: missing_imports_or_run_test_py: Python packages require imports or a python test file in tests.
ERROR: build.sh:31: uses_setup_py: python setup.py install is deprecated.
Errors were found

Linter check found the following problems:
The following problems have been found:
ERROR: /tmp/abs_dayei6t0in/clone/recipe/meta.yaml:31: cython_needs_compiler: Cython generates C code, which will need to be compiled
ERROR: /tmp/abs_dayei6t0in/clone/recipe/meta.yaml:31: cython_needs_compiler: Cython generates C code, which will need to be compiled
ERROR: /tmp/abs_dayei6t0in/clone/recipe/meta.yaml:37: host_section_needs_exact_pinnings: Packages in host must have exact version pinnings, except python build tools.
ERROR: /tmp/abs_dayei6t0in/clone/recipe/meta.yaml:38: host_section_needs_exact_pinnings: Packages in host must have exact version pinnings, except python build tools.
ERROR: /tmp/abs_dayei6t0in/clone/recipe/meta.yaml:67: missing_imports_or_run_test_py: Python packages require imports or a python test file in tests.
ERROR: build.sh:31: uses_setup_py: python setup.py install is deprecated.
Errors were found

authors: anaconda-pkg-build skupr-anaconda


text:
refactor:重构公招代码

方正雅宋是有版权的字体，不要提交到仓库里

recruit.pkl 是怎样生成的？用在哪里？

agent_token_first.png 或许截“首次获得”比较好？

recruit_config 不要通过参数传给 RecruitSolver，直接走 arknights_mower.utils.config

recruit_tags 方法中，把“根据词条计算招募结果”的逻辑与发邮件、识别等分开，为公招词条计算逻辑编写单元测试

agent_token_first.png 或许截“首次获得”比较好？

因为高级凭证正好和xxx的信物会在同一个区域，而且只是为了防止在初次获得的时候识别不出是开包界面，所以只要能识别出是开包就行

还差一个单元测试，明日再战

recruit_tags 方法中，把“根据词条计算招募结果”的逻辑与发邮件、识别等分开，为公招词条计算逻辑编写单元测试

计算结果是一个单独的recruit_cal方法,然后我试着摸了一个单元测试这样

authors: EightyDollars ZhaoZuohong

repo: ArkMowers/arknights-mower


text:
Fix error when redis password is None

Yup, thanks!


text:
Bugfix

Hi @Malik166 - kindly provide the context for this update so I can understand the ratonale.

Closing as there's been no response to @mswaweru We can reopen as needed once more info is provided.

authors: CelesteDG Malik166 msewaweru

repo: Azure/azure-docs-powershell-azuread


text:
Log Uncaught and Unhandled Errors in Tests

/azp run java - storage - tests

/azp run java - storage - tests

/azp run java - storage - tests

Closing as what this was attempting to troubleshoot has been resolved.

repo: Azure/azure-sdk-for-java


text:
Adding example for web app running on docker

@lonegunmanb is this PR good to merge?

authors: grayzu xiaxyi

repo: Azure/terraform


text:
Generate common types swagger from common type lib

All changed packages have been documented.

:white_check_mark: @azure-tools/typespec-azure-resource-manager

Show changes
@azure-tools/typespec-azure-resource-manager - internal ✏

Reorganize ARM library internal models into fully version controlled Azure.ResourceManager.CommontTypes namespace.

You can try these changes at https://cadlplayground.z22.web.core.windows.net/typespec-azure/prs/976/
Check the website changes at https://tspwebsitepr.z22.web.core.windows.net/typespec-azure/prs/976/

authors: azure-sdk timotheeguerin

repo: Azure/typespec-azure


text:
Implement API for request extra data

Accidentally implement this API instead of fetching :D


text:
Update _sidebar.md

Closes #2


text:
create license

done with 393836f854685157e04db585488ba0904599174b

repo: BeethovensWerkstatt/publications


text:
add icon to exe file

 Задать приложению иконку

authors: BeloMaximka DDeenis

repo: BeloMaximka/MystatDesktopWpf


text:
socket在发送方设置页面点击会导致崩溃

已修复

repo: BlacksheepJane/TranspondSms


text:
iOS audio always on speaker and can't switch to earpiece

My lib a layer on top of flutter_webrtc. Maybe there you will find help

My lib a layer on top of flutter_webrtc. Maybe there you will find help

Correct, thanks u!

authors: Blancduman un-hongly

repo: Blancduman/mediasoup-client-flutter


text:
feature(form):fluentValidation support dependencyInjection

@capdiem PTAL

repo: BlazorComponent/BlazorComponent


text:
Loop optimisations

Makes no sense


text:
Where can I find semantic_codebook.pt?

nevermind You have to generate it using the code

repo: CNChTu/Diffusion-SVC


text:
Rupok

rupok merge

repo: CardiacRecorder/CardiacMonitorFinal


text:
Add missing React imports for fragments

Pull Request Test Coverage Report for Build 5079010844

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 72.309%

Totals

Change from base Build 5078407832:
0.0%

Covered Lines:
2082

Relevant Lines:
2655

💛  - Coveralls

authors: VictorVelarde coveralls

repo: CartoDB/carto-react


text:
no-lonely-if

Current dependencies on/for this PR:

main

PR #124   👈

This comment was auto-generated by Graphite.

repo: CatChen/eslint-suggestion-action


text:
[FSDE-13865] Added value watcher to Search Input wc

The CI pipeline run successfully in https://jenkinsprod.corp.intranet:8443/job/UX-CHI/job/Productive/job/Chi/job/PR-311/4/. :white_check_mark:

You can check this PRs instance in https://280554a9c4f65e61cdf1e8615651e4347dcf3200-chi-pr.enterprise.ctl.io (external) and in https://nginx-pr-311-ux-chi.kubeodc-test.corp.intranet/ (internal)

authors: SCMAUTO janibolkvadze

repo: CenturyLink/Chi


text:
update protobuffer

Hi @richardbeumer ,
thank you for spending time on this project.
A description would help understanding what this PR is doing.
I assume this PR is now no more up to date, so I am closing it.
Feel free to let me know if there as an issue with protobuffer version.
Thanks

authors: Chavithra richardbeumer

repo: Chavithra/degiro-connector


text:
Bump version to 0.4.4

bors try

bors r+


text:
Session id per connection

Ci/cd don't work properly - windows & Macos build are not starting:
Invalid workflow file: .github/workflows/macOS.yml#L1
invalid `cron` attribute "0.0.*.*.1"

I've committed the fix in https://github.com/ClickHouse/clickhouse-odbc/pull/399
and now Macos builds fails... :|

Ci/cd don't work properly - windows & Macos build are not starting:
Invalid workflow file: .github/workflows/macOS.yml#L1
invalid `cron` attribute "0.0.*.*.1"

I've committed the fix in #399 and now Macos builds fails... :|

will try to fix it...

authors: Enmk filimonov

repo: ClickHouse/clickhouse-odbc


text:
CI for Node

Contains the compiled JavaScript

repo: ClintonBaker/github-actions-for-ci


text:
Board is GET now

LGTM

authors: maksimowiczm pzajaczkowski

repo: CodendDev/Codend


text:
Issue Tracking and Management:

The core functionality of the application is to track and manage issues in open-source repositories. Users should be able to create, view, edit, and close issues. Each issue typically includes information such as a title, description, issue type, severity, status, and comments.


text:
frontend of Contribute Feature

Hi @pradeeban ,
I want to ask something could you please add me as a member of the organization because I want to test that I can create PRs from my account (say bot account)? I know in the last meeting you informed me that we can push the code to the wrong place by mistake but I ensure you I will only work with my forks and not directly push code to main repos. After I have tested u can revoke the membership .
Thanks for the consideration

We want you to have a third repository and create a PR from that repository to yours.
So, it will be a third github, bot account, parteekbot -> parteekcoder.
We discussed the rationale behind this approach last week. Perhaps, due to poor Internet, you did not catch that.
In this approach, parteekcoder will be like the CONTROL-CORE. As we discussed last week, please reach out to @Rahuljagwani first to make sure you start from where he left off. That way, his contributions so far won't be wasted (and you can contribute to his project too, when you have contributions).

We can discuss this Wednesday again, if something is not clear.

We can discuss this Wednesday again, if something is not clear.

yeah sure

That is awesome! Let's discuss on Wednesday!

authors: parteekcoder pradeeban

repo: ControlCore-Project/concore-editor


text:
[TASK]: AMR Updated, client and server need updating now.

Header already added by Dan https://github.com/DARPA-ASKEM/Terarium/pull/1810

repo: DARPA-ASKEM/Terarium


text:
Error on staging: flat pages don't show when logged in

Ok, I think this will go away once the "bad" source created without a shelfmark is deleted.

This was indeed the problem for me.
@lucasmarchd01 Could you try on staging logged in to your account? It turns out that when we both tried to create a source without a shelfmark, the source was actually created but the 500 error was on the source detail page that is returned when you create a source. And then when it tried to show the source in the "My Sources" panel, another error occurred.
I deleted all the sources on staging that didn't have a shelfmark and then it worked when I was logged in.

repo: DDMAL/CantusDB


text:
Fix task4

fixes #51


text:
Svelte 5

I do not think we will merge from a pr.

authors: f-elix nitriques


text:
readme: Fix Alacritty home page URL

Thanks for the catch.

authors: EdenEast powerjungle


text:
Update SavedBooks.js

test


text:
[upstream PR #773]: Fix some compile problems on weird/old compilers.

Generated this PR automatically by looking at the list of merged PRs upstream and creating new PRs (from the same commit) here.

@apoelstra What's the plan here? Is this just a test for your scripts? Or should we review this?

@real-or-random both. If we can merge this I can do a series of these PRs, until we hit a merge conflict, then we can decide on a process for how to deal with that.
My proposal here is that we start continuously merging PRs from upstream into libsecp-zkp, rather than rebasing (and rather than doing the subtree-based schemed that @jonasnick has been experimenting with).

authors: apoelstra real-or-random


text:
1.20.4

Looks good for the most part. Is there a reason why you changed the dependency from being just the fabric resource loader to the fabric API as a whole?

just some lazy XD
---Original---
From: @.>
Date: Thu, Dec 28, 2023 02:27 AM
To: @.>;
Cc: @.@.>;
Subject: Re: [End-Tech/syncmatica] 1.20.4 (PR #69)
Looks good for the most part. Is there a reason why you changed the dependency from being just the fabric resource loader to the fabric API as a whole?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: @.***>

Generally why my PR only changes the method code, so the maintainers can do the build script and mod version.

I build from your PR and test with mods:

fabric-api-0.92.0+1.20.4
syncmatica-1.20.4-0.3.11-dev

crash-2023-12-28_15.04.18-client.txt
Same crash as I add Malilib and Litematica. Or even disable Fabric API.

I build from your PR and test with mods:

Same crash as I add Malilib and Litematica. Or even disable Fabric API.

Which PR did you use ?

Which PR did you use ?

This PR's author @s-yh-china

i will test it, it work in my idea

Which PR did you use ?

This PR's author @s-yh-china

I was looking at your log file.  Are you running JDK 21 (Azul) ?  Perhaps try using JDK 17 and then lastly try fabric-api-0.91.1+1.20.4.

I was looking at your log file. Are you running OpenJDK 21 (Azul) ? Perhaps try using JDK 17/18 for Minecraft and then lastly try fabric-api-0.91.1+1.20.4 or fabric-api-0.91.3+1.20.4 .

I tried both Oracle JDK 17.0.3.1 and Azul JDK 17.0.9, but still crash.
This time only Syncmatica, no Fabric API.
crash-2023-12-28_17.35.24-client.txt

Adding Malilib and Litematica has no help.
I was playing well using Azul JDK 21:

with 100+ mods with Syncmatica in MC1.20.2
with the same mods (have updated from 1.20.2) without Syncmatica in MC1.20.4

@FlameFire26 --
Can you try with this build and see if you have the same results ?  I am just curious if it has something to do with how you built the jar file.
https://github.com/sakura-ryoko/syncmatica/releases

Sorry, I didnt notice that you have built yours. It seems to work well when I enter world and open Litematica config.

I usually only do that under the "releases" when I need to test something, so I uploaded it during this conversation for the most part.

I even have a 23w51b working branch if you're interested, but built against my own forks of malilib / litematica that I've been working with masa a bit to help him get them ported without needing to have him focus as much energy on it versus his re-write project.

authors: FlameFire26 kpzip s-yh-china sakura-ryoko

repo: End-Tech/syncmatica


text:
Definir Estratégia de Testes

https://docs.google.com/document/d/1yFQgiF1KpM1X33WHiFklAiy-d3txH3QpNna9WI_y-tc/edit#heading=h.d9cye5qjsje8

authors: camilalabes noliveir

repo: Enegrecer/enegrecer-web


text:
wip: Discover old code.

Test done.

repo: Energinet-DataHub/greenforce-frontend


text:
WIP Remove db constraint. Use school id for yaml key.

Closing as dormant..

repo: Energy-Sparks/energy-sparks


text:
adding duplicated organism metadata to mz genmetaconf

tested on rs8t_mgen/metadata metazoan load

repo: Ensembl/ensembl-genomio


text:
Add bigger timout for debug_tracetransaction (default is 5 or 10s)

it was, changed to 60s

repo: EthTx/ethtx


text:
Update README.md

s


text:
refactor(plugins/tidy-css): remove param reassign

Pull Request Test Coverage Report for Build 1258810875

2 of 2 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.0002%) to 99.864%

Totals

Change from base Build 1244999876:
0.0002%

Covered Lines:
548

Relevant Lines:
549

💛  - Coveralls

authors: Fdawgs coveralls

repo: Fdawgs/docsmith


text:
chore(.env.template): double-quote example strings

Pull Request Test Coverage Report for Build 1927908273

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build 1922163829:
0.0%

Covered Lines:
347

Relevant Lines:
347

💛  - Coveralls

Pull Request Test Coverage Report for Build 1927908273

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build 1922163829:
0.0%

Covered Lines:
347

Relevant Lines:
347

💛  - Coveralls

repo: Fdawgs/ydh-community-contacts-api


text:
Fix db history

This PR separates the logic of different DB entities. To not bloat the PR further I will continue in a new one

repo: Flagro/TelegramRPBot


text:
Prevent null feature type

Note: I have validated that we don't have any null feature types in the staging and production databases already.

repo: Flagsmith/flagsmith


text:
Added jax support

New attempt in #505

repo: FlorianPfaff/pyRecEst


text:
feat: isHexColor method

Yep

repo: FnrDev/fnr


text:
Fran flowerz patch 1

ll

repo: FranFlowerz/github-slideshow


text:
[channels,rdpdr] fix state check

@freerdp-bot test please

@fujames1 thank you for the pull request.
could you run git clang-format on your changes please? (you can git commit --amend and git push --force to replace your current commit, so that it passes the ci checks.

hi @akallabeth,  I reformatted the code and force-pushed.

@freerdp-bot test please

repo: FreeRDP/FreeRDP


text:
Fixed Pre-event hero section

Deployed

repo: GDSC-PLM/Ready-Set-Grow


text:
version and read-me update

0.4.0-dev.4

authors: ahujaraghav geekruchika

repo: GeekyAnts/flick-video-player


text:
fix: add release nx config

:tada: This PR is included in version 1.17.0-alpha.11 :tada:
The release is available on:

npm package (@alpha dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 2.6.0-alpha.1 :tada:
The release is available on:

npm package (@alpha dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 2.6.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

authors: chrisolsen tzuge

repo: GovAlta/ui-components


text:
Avilla Commander - 指令触发体系

交给你了.
聊天记录请自行整理

async def check_valid(permission: str):
    if permission not in ALL_PERMISSIONS:
        # raise ExecutionStop 很有效, 但是我们需要更好的方案.
        raise CommandParamInvalid(
            "permission",
            MessageChain.create("无效的权限: {}".format(permission))
        )
    return permission

@commander.command("luckperm group {0} permission set {1} {2|permission}", {
    "group": Slot(0, selector=mainline_selector),
    "permission": Slot(1, type=str),
    "value": Slot(2, type=bool, default=True),
})
async def permission_set(group: mainline_selector, permission: str = Depend(check_valid), value: bool):
    ...

repo: GraiaProject/Avilla


text:
feat(openapi): design and complete the request in openapiv2

Task linked: CU-2j40ybw OpenAPIv2 对接 —— Dataset

authors: GravitiRob willandfree

repo: Graviti-AI/graviti-python-sdk


text:
polished the 'Command Line Todo List' module series

I like some of this proposal, namely that absence of the tasks.json file should not crash. But I can imagine use cases in which the desired initial state includes a set of tasks. So I suggest that the specs recommend, rather than mandate, a repo either without a tasks.json file or with one that is empty of tasks.

authors: deadlyicon jrpool

repo: GuildCrafts/curriculum


text:
Initial data

initial test data from Sina

authors: Hackathorn sinakhsh

repo: Hackathorn/MultiCategory-Doc-Clustering


text:
add acknowledgements

not sure why the docs suddenly fail, though
.

repo: Helsinki-NLP/mammoth


text:
Fix vite dependency in web

Hello, thanks for the PR. Quick question, why should vite not be in the devDependency? When I scaffold the vite app it is listed as a dev dependency by default. Things might have changed and I might have missed out on it. thank you

I was running into an issue where the build would fail with:
sh: vite: command not found
after I run docker-compose up.
The issue resolved after I moved it out of devDependencies and based on this comment:
https://github.com/vitejs/vite/issues/1215#issuecomment-876482803

Hi sorry for the late reply.
I'm still quite unsure if vite should be moved out of devDependencies since it's a tool for development. For now, I'm keeping this PR open for alternative solutions. Also, I'm working on a rewrite of twitter clone since the codebase is quite a mess. Thanks for your time.

authors: HotPotatoC yzernik

repo: HotPotatoC/twitter-clone


text:
vue3 组合式写法能识别吗？

可以

我想直接用  const { t } = useI18n() 的 t，有什么办法吗，现在是会转成 this.$t

这样子的话是会把选项式的写法也改掉了，有什么办法两个区分开来吗？❤

这是文档地址

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
此 issue 已被自动锁定，因为关闭后没有任何近期活动。如果有相关 bug，请重新创建一个新 issue。

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
此 issue 已被自动锁定，因为关闭后没有任何近期活动。如果有相关 bug，请重新创建一个新 issue。

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
此 issue 已被自动锁定，因为关闭后没有任何近期活动。如果有相关 bug，请重新创建一个新 issue。

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
此 issue 已被自动锁定，因为关闭后没有任何近期活动。如果有相关 bug，请重新创建一个新 issue。

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
此 issue 已被自动锁定，因为关闭后没有任何近期活动。如果有相关 bug，请重新创建一个新 issue。

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
此 issue 已被自动锁定，因为关闭后没有任何近期活动。如果有相关 bug，请重新创建一个新 issue。

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
此 issue 已被自动锁定，因为关闭后没有任何近期活动。如果有相关 bug，请重新创建一个新 issue。

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
此 issue 已被自动锁定，因为关闭后没有任何近期活动。如果有相关 bug，请重新创建一个新 issue。

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
此 issue 已被自动锁定，因为关闭后没有任何近期活动。如果有相关 bug，请重新创建一个新 issue。

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
此 issue 已被自动锁定，因为关闭后没有任何近期活动。如果有相关 bug，请重新创建一个新 issue。

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
此 issue 已被自动锁定，因为关闭后没有任何近期活动。如果有相关 bug，请重新创建一个新 issue。

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
此 issue 已被自动锁定，因为关闭后没有任何近期活动。如果有相关 bug，请重新创建一个新 issue。

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
此 issue 已被自动锁定，因为关闭后没有任何近期活动。如果有相关 bug，请重新创建一个新 issue。

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
此 issue 已被自动锁定，因为关闭后没有任何近期活动。如果有相关 bug，请重新创建一个新 issue。

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
此 issue 已被自动锁定，因为关闭后没有任何近期活动。如果有相关 bug，请重新创建一个新 issue。

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
此 issue 已被自动锁定，因为关闭后没有任何近期活动。如果有相关 bug，请重新创建一个新 issue。

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
此 issue 已被自动锁定，因为关闭后没有任何近期活动。如果有相关 bug，请重新创建一个新 issue。

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
此 issue 已被自动锁定，因为关闭后没有任何近期活动。如果有相关 bug，请重新创建一个新 issue。

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
此 issue 已被自动锁定，因为关闭后没有任何近期活动。如果有相关 bug，请重新创建一个新 issue。

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
此 issue 已被自动锁定，因为关闭后没有任何近期活动。如果有相关 bug，请重新创建一个新 issue。

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
此 issue 已被自动锁定，因为关闭后没有任何近期活动。如果有相关 bug，请重新创建一个新 issue。

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
此 issue 已被自动锁定，因为关闭后没有任何近期活动。如果有相关 bug，请重新创建一个新 issue。

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
此 issue 已被自动锁定，因为关闭后没有任何近期活动。如果有相关 bug，请重新创建一个新 issue。

authors: IFreeOvO zprial


text:
fix bugs search

fix bugs serach

repo: Innapoliakova/set

license: ISC


text:
Floating names on map

@ItsiW what's the idea here? show the name of restaurants on the map automatically so that people don't have to hover over (desktop) or press down on (mobile) the circles to see the name?

Yes that was the idea, but I've already made the changes. They start appearing at a certain zoom level so things aren't crowded

authors: ItsiW schradert

repo: ItsiW/VILF


text:
[4ptx] Recursion

REcursion


text:
Jkl 262 deposit address param for rns

@dahn510 i need your help 😱 i dont know why sim test keeps failing

It's because a test case timed out for running longer than 10 mintues. The sim test cases such as TestFullImportExport and TestFullAppSimulation takes a long time as it simulates the txs for 500 (default) blocks. @TheMarstonConnell can you increase the timeout to 15minutes?

i added a fix for issue JKL-263 in this PR as well https://jackallabs.atlassian.net/browse/JKL-263

repo: JackalLabs/canine-chain


text:
Option to replace Singleplayer or Realms button

Thanks!

repo: JamCoreModding/quicker-connect-button


text:
Use copysign

the problem is in the rewrite of the tests -- if you deal with that, I will put this through and check timings later

Tests are now passing @JeffreySarnoff.

Thanks! Could you tag a new release, please?

Thanks! Could you tag a new release, please?
On 1 Jun 2017 2:36 p.m., "Jeffrey Sarnoff" notifications@github.com wrote:
Merged #7 https://github.com/JeffreySarnoff/AdjacentFloats.jl/pull/7.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/JeffreySarnoff/AdjacentFloats.jl/pull/7#event-1106051030,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AALtTqSM-K9yzomyKNgqobZo6xPFmeyNks5r_r5fgaJpZM4NqWKf
.

done

Thanks!

authors: JeffreySarnoff dpsanders


text:
tasks

👷 Deploy Preview for marvelous-begonia-42596c processing.

Name
Link

🔨 Latest commit
b52ef52ab588c15c13f6ca98c2c7ff545792900d

🔍 Latest deploy log
https://app.netlify.com/sites/marvelous-begonia-42596c/deploys/65d2459b1be6e200081af7e3


text:
Add files via upload

@JustTryAgain First stage of verification passed, official domain is zac.org.ua as far as I verified. This is just an informational note. Pull request is still in the review. I appreciate your patience while waiting for the final decision.

@JustTryAgain Pull request merged. Thank you.

authors: JustTryAgain philipto

repo: JetBrains/swot


text:
MSKH School

@Areg472 I am sorry, the domain mskh.am is removed from our trusted domains list because it was abused in the past. If you are the student of this school, please enroll to GitHub Student Developer Program. Then apply for JetBrains educational subscription with your GitHub account (GitHub tab at https://www.jetbrains.com/shop/eform/students).


text:
Add Pierce College Domains

@karmstrong5095 I am sorry, the domain smail.pcd.edu is removed from our trusted domains list because it was abused in the past. If you are the student of this school, please enroll to GitHub Student Developer Program. Then apply for JetBrains educational subscription with your GitHub account (GitHub tab at https://www.jetbrains.com/shop/eform/students).


text:
Amir's Changes to Test Connectivity

Rebasing this branch on the top main has cluttered this PR. I am going to make a new PR based on top of main to avoid the clutter here.

authors: amircybersec fortuna

repo: Jigsaw-Code/outline-sdk


text:
update

update


text:
Refactor Grid checks in Aggregate and Transfer

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 93.72%. Comparing base (fc7a45f) to head (6c8c153).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #51      +/-   ##
==========================================
- Coverage   94.93%   93.72%   -1.22%
==========================================
  Files          20       20
  Lines         869      860       -9
==========================================
- Hits          825      806      -19
- Misses         44       54      +10

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

authors: codecov-commenter juliohm


text:
feat: add orchid driver

I do not implement createTableIfNotExists, is this necessary?

Cool! Thanks a lot for the PR dude. I came across Orchid ORM a while back and thought it looked like Lucid with other some cool features

I do not implement createTableIfNotExists, is this necessary?

Yes, bentocache will automatically create the table if autoCreateTable is true. This allows seamless use of Bentocache without having to manually create a migration if you're lazy: https://bentocache.dev/docs/cache-drivers#databases. You can refer to the Knex or Kysely driver, it should be pretty easy to implement

And I can't setup local test, for my new driver and existing drivers, could you please help me run the test?

What's the problem? There's nothing in particular to do other than launch the docker-compose in the repo which starts a postgres. then launch the tests. But let me know if anything else is giving you trouble
Looks we have some lint issues too

@Julien-R44 lint error and peerDependencies has been fixed.
As for createTableIfNotExists, I do not find createTable related method from the #connection, Orchid ORM has a separate package rake-db for migrations and table creations, but it's very heavy to import it into runtime, so I don't want to introduce it only for createTable.
@romeerez Hi, does orchid-orm package provide some lightweight way to createTable

@bingtsingw it's very nice to see this PR!
I'm seeing this Bentocache library for the first time and I'm not sure yet what exactly is required from a db driver.
In some cases, it can be enough to just write a bit of custom SQL to create a table. But looks like in this case, it should happen dynamically.
Imagine that OrchidORM has an exported separate function createTable. But how about changing a table? Wouldn't you need much more functionality to add/drop/change/rename columns? No way there is no need to ever change a table.
So I'll look into Bentocache to see what should be changed in Orchid to support it.

@romeerez  Thank you for your support, in Bentocache, it has an autoCreateTable option which needs  to implement createTableIfNotExists, this is the Kysely version of implementation:
  async createTableIfNotExists(): Promise<void> {
    await this.#connection.schema
      .createTable(this.#tableName)
      .addColumn('key', 'varchar(255)', (col) => col.primaryKey().notNull())
      .addColumn('value', 'text')
      .addColumn('expires_at', 'bigint')
      .ifNotExists()
      .execute()
  }

There is no need to change it in this situation.

@Julien-R44 Thank you for your explain, I thought it was a must.
@romeerez Seems there is no need to add extra methods, I'll test if it works

@bingtsingw I have looked around, and, well, any ORM is an overkill for this case, even Knex and Kysely are overkill, since Bentocache requires only limited functionality from a driver, it should be easy enough and better for performance to do all queries (to create a table, get value, set value) with raw SQL by calling pg or postgres libs directly.
ORM has a ton of additional functionality that won't be used: relations management, various features like callbacks on create/update/delete, deletedAt, and many more. Query builder also has a ton of functionality that is redundant for this: various ways of doing joins, and wrappers for various SQL statements.

@romeerez Yes, in fact ORM is overkill for this tiny cache table, that's why I do not use Knex or Kysely and want to implement an orchid driver, cause I already use it in my project, making it a driver of bentocache is natural.

Aha, yes that makes sense.
In such case, IMO it would be better for Bentocache to have a pg lib adapter, then it could work with any ORM that depends on pg driver.
You could extract pg.Pool from the db instance and the Bentocache pg driver would use it for performing queries directly:
const db = orchidORM({ ...options }, { ...tables })

// extract pg.Pool from db instance:
const pgPool = db.$adapter.pool

const value = await pgPool.query('SELECT value FROM cache WHERE key = ?', ['key'])

@bingtsingw I have looked around, and, well, any ORM is an overkill for this case, even Knex and Kysely are overkill, since Bentocache requires only limited functionality from a driver, it should be easy enough and better for performance to do all queries (to create a table, get value, set value) with raw SQL by calling pg or postgres libs directly.
ORM has a ton of additional functionality that won't be used: relations management, various features like callbacks on create/update/delete, deletedAt, and many more. Query builder also has a ton of functionality that is redundant for this: various ways of doing joins, and wrappers for various SQL statements.

Yeah, this is actually something I've hesitated about on bentocache. Do I create adapter for pg, sqlite, @libsql/client etc rather than adapters for ORMs. In the end, I preferred to use ORMs because there are almost more dialects than ORMs. So it seemed simpler to me to maintain the adapters of the most popular ORMs.
For example, just for Postgres, I would have had to make adapters for @neondatabase/serverless, @xata.io/client, pg, postgres, drizzle-orm/node-postgres etc... Where I can just add a Drizzle Adapter that will do all this work for me
I hope I didn't make a mistake :sweat_smile:

Thank you!
It's indeed similar to Lucid, since Lucid is on Knex, and Orchid is syntactically inspired by Knex to be familiar for node.js devs.
Lucid's creator posted some interesting notes about reaching a good type-safety level with ORMs, and this is the exact main goal of Orchid ORM to reach.

@Julien-R44 Hi, I setup the test, seems it fails with expires_at column type.

Weird. I'm not sure why. The tests run fine in CI though: https://github.com/Julien-R44/bentocache/actions/runs/8880648142/job/24383374119?pr=17#step:7:128
So i would say, probably a configuration issue on your side
Maybe you can ignore the local execution of the knex tests. Just run the tests you added on Orchid. Or even let the CI execute them

@Julien-R44 Hi, I've completed this pr including autoCreateTable.

Awesome. thanks a lot for taking the time to create this PR. I will give a final look at it and merge it before the end of the week

Some tests did not pass, I took a look at the error messages, not sure if it's related to orchid driver

Okay that looks perfect to me. Let's merge it. Thanks again for the PR !

Released with bentocache@1.0.0-beta.9

authors: Julien-R44 bingtsingw romeerez


text:
elastalert2 2.19.0 support

https://github.com/Karql/elastalert2-server/releases/tag/5.8.0

authors: Karql nsano-rururu


text:
cmake: Update update_deps

CI Vulkan-Tools build queued with queue ID 1119.

CI Vulkan-Tools build queued with queue ID 1119.

CI Vulkan-Tools build # 1061 running.

CI Vulkan-Tools build # 1061 passed.

authors: ci-tester-lunarg juan-lunarg

repo: KhronosGroup/Vulkan-Tools


text:
[note] Поправить note с учетом вынесенных классов

fixed in proj-42

repo: KiYari/K-Note


text:
feat(crop): add crop planes to state file

LGTM!

repo: KitwareMedical/VolView


text:
Bug: Add 'nsfw' Option to NAIv3 and FurryV3

miss click

repo: LlmKira/novelai-python


text:
fix blog description from submitting entire blog on save.

disable save button on modal and it will post the form when you hit publish for the entire blog.

repo: LucasMERN/project-night-blog


text:
add circuit plan

closed

Done


text:
Fix repeat not working

@heliocosta-dev I didn't manage to reproduce it. Do you have a reproduction example/repository? That would be great.

Managed to reproduce it. Reopening
Tested the changess. Good job 👍 Thank you

authors: LunatiqueCoder heliocosta-dev


text: tests (#22) : tests generate case of UuidV4 class (#21)


text:
events section added

Please test your changes before submitting them.

Teams section already uses selected key for sessionStorage, it should not be used for others.
Do not simply copy and paste code without alteration.
Use proper names for ids and classes.
There is no need for quotes in events section.

I will update soon and let you know

Please test your changes before submitting them.

Teams section already uses selected key for sessionStorage, it should not be used for others.
Do not simply copy and paste code without alteration.
Use proper names for ids and classes.
There is no need for quotes in events section.

updated with new changes

repo: MLSCMMCOE/mlsc-website


text:
First API testing

@manuelq12 Hello!
I can erase them, it is just to see that everything is going well,
I will erase them now
Thank you!

@manuelq12
I have already erased console logs in Rev3.
Thank you! I wait for your approval to continue with next step.


text:
removing fonts from history

Will close for now since I don't want to re-write the repos history -- I will try an approach with bfg, but if not we can reopen and merge

repo: Metaculus/metaculus


text:
feat(21): adaptation for amiblitz3 - Part 1

In stand by, waiting for an update of amiblitz update arexx code is not fully working right now.

In fact, some month ago I seperated all the arexx-code into another source file and started to convert some parts back to basic. I never tried anything with arexx. Later I forgot to continue work on it as noone seem to use it.
I used looked into it and realized I missed the function that actually counts the parameters!
I am going to add this soon...

I updates AmiBlitz3 with fixes to the arexx-interface: https://github.com/AmiBlitz/AmiBlitz3/blob/master/System/PED
Arexx-command "COMPILE" should work now.
Please consider using the command line options instead of arexx.

TX
command line options ?
Any documentation somewhere?

At least, all commandline options are listed, if you run AB3 from a shell:

The advantage of using the shell parameters is that in this mode the compiler does not need the editor PED, whereas the arexx-interface in inside of PED. So using the shell parameters saves memory.
But its up to you. If you need anything, for example new arexx-Commands let me know.

❤

authors: honitos youenchene

repo: MickGyver/vscode-amiga-blitzbasic


text:
Fixup stuff for the card pages

@ganicke,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

Merge or no merge?

authors: ganicke msftclas

repo: Microsoft/pxt-common-packages


text:
4/20 PM Publish

Docs Build status updates of commit 16f9134:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs-conceptual/azps-7.4.0/index.yml
:white_check_mark:Succeeded
View (azps-7.4.0)

docs-conceptual/azps-7.4.0/toc.yml
:white_check_mark:Succeeded
View (azps-7.4.0)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

repo: MicrosoftDocs/azure-docs-powershell


text:
10/12/2021 Publish

Docs Build status updates of commit fe5b1b9:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error-PullRequestMergeConflict] Cannot sync git repo to specified state. Please make sure the pull request is mergeable.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 7165f2d:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error-PullRequestMergeConflict] Cannot sync git repo to specified state. Please make sure the pull request is mergeable.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit abac23e:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error-PullRequestMergeConflict] Cannot sync git repo to specified state. Please make sure the pull request is mergeable.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

This will be merged by other means

repo: MicrosoftDocs/azure-docs-sdk-node


text:
Fix typo

@changeworld : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#sign-off

@ktoliver : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Hi - Per https://docs.microsoft.com/contribute/code-in-docs#fenced-code-blocks, code fencing syntax includes using all lowercase letters. However, it renders correctly regardless of casing, so we don't proactively seek to update the content. I've made this change here and will merge. Thanks!

repo: MicrosoftDocs/azure-docs


text:
[Bulk] Validation: description fixes

Docs Build status updates of commit eeecbde:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

BingMaps/rest-services/common-parameters-and-types/supported-culture-codes.md
:white_check_mark:Succeeded
View

BingMaps/rest-services/common-parameters-and-types/type-identifiers/eat-drink-types.md
:white_check_mark:Succeeded
View

BingMaps/rest-services/common-parameters-and-types/type-identifiers/index.md
:white_check_mark:Succeeded
View

BingMaps/rest-services/common-parameters-and-types/type-identifiers/see-do-types.md
:white_check_mark:Succeeded
View

BingMaps/rest-services/common-parameters-and-types/type-identifiers/shop-types.md
:white_check_mark:Succeeded
View

BingMaps/rest-services/common-parameters-and-types/user-context-parameters.md
:white_check_mark:Succeeded
View

BingMaps/rest-services/common-response-description.md
:white_check_mark:Succeeded
View

BingMaps/rest-services/developer-resources.md
:white_check_mark:Succeeded
View

BingMaps/rest-services/directly-accessing-the-bing-maps-tiles.md
:white_check_mark:Succeeded
View

BingMaps/rest-services/elevations/elevation-data.md
:white_check_mark:Succeeded
View

BingMaps/rest-services/elevations/get-elevations.md
:white_check_mark:Succeeded
View

BingMaps/rest-services/elevations/index.md
:white_check_mark:Succeeded
View

BingMaps/rest-services/elevations/point-compression-algorithm.md
:white_check_mark:Succeeded
View

BingMaps/rest-services/examples/distance-matrix-asynchronous-example.md
:white_check_mark:Succeeded
View

BingMaps/rest-services/examples/distance-matrix-example.md
:white_check_mark:Succeeded
View

BingMaps/rest-services/examples/distance-matrix-histogram-example.md
:white_check_mark:Succeeded
View

BingMaps/rest-services/examples/driving-route-example.md
:white_check_mark:Succeeded
View

BingMaps/rest-services/examples/driving-route-using-tolerances-example.md
:white_check_mark:Succeeded
View

BingMaps/rest-services/examples/driving-route-with-route-path-example.md
:white_check_mark:Succeeded
View

BingMaps/rest-services/examples/isochrone-asynchronous-example.md
:white_check_mark:Succeeded
View

BingMaps/rest-services/examples/isochrone-example.md
:white_check_mark:Succeeded
View

BingMaps/rest-services/examples/snap-to-road-example.md
:white_check_mark:Succeeded
View

BingMaps/rest-services/examples/truck-route-asynchronous-example.md
:white_check_mark:Succeeded
View

BingMaps/rest-services/examples/truck-route-example.md
:white_check_mark:Succeeded
View

BingMaps/rest-services/examples/walking-route-example.md
:white_check_mark:Succeeded
View

This comment lists only the first 25 files in the pull request.
For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

@stevemunk
This PR has fixes from a previous PR that you've already reviewed. There were issues incorporating your suggestions. This PR should have all of your feedback incorporated. Your review is appreciated! Thank you!
Global effort to fix validation errors
The Content & Learning team is fixing build validation errors on docs.microsoft.com. This effort will eliminate potential accessibility, security, and usability issues. This PR includes only build validation fixes and does not change other content. I’d very much appreciate your timely review and feedback on these changes I’ve suggested. Thank you!

#sign-off

repo: MicrosoftDocs/bingmaps-docs


text:
[Doc Improvement][webhook note updated][3937634]

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/includes/deprecation-note.md
81
4
link
:white_check_mark:

msteams-platform/webhooks-and-connectors/how-to/add-incoming-webhook.md
95
7
link
:white_check_mark:

msteams-platform/webhooks-and-connectors/how-to/connectors-creating.md
90
17
link
:white_check_mark:

msteams-platform/webhooks-and-connectors/how-to/connectors-using.md
94
9
link
:white_check_mark:

msteams-platform/webhooks-and-connectors/what-are-webhooks-and-connectors.md
90
15
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/includes/deprecation-note.md
86
2
link
:white_check_mark:

msteams-platform/webhooks-and-connectors/how-to/add-incoming-webhook.md
95
7
link
:white_check_mark:

msteams-platform/webhooks-and-connectors/how-to/connectors-creating.md
90
17
link
:white_check_mark:

msteams-platform/webhooks-and-connectors/how-to/connectors-using.md
94
9
link
:white_check_mark:

msteams-platform/webhooks-and-connectors/what-are-webhooks-and-connectors.md
90
15
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/includes/deprecation-note.md
86
2
link
:white_check_mark:

msteams-platform/webhooks-and-connectors/how-to/add-incoming-webhook.md
95
7
link
:white_check_mark:

msteams-platform/webhooks-and-connectors/how-to/connectors-creating.md
90
17
link
:white_check_mark:

msteams-platform/webhooks-and-connectors/how-to/connectors-using.md
94
9
link
:white_check_mark:

msteams-platform/webhooks-and-connectors/what-are-webhooks-and-connectors.md
90
15
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/includes/deprecation-note.md
93
1
link
:white_check_mark:

msteams-platform/webhooks-and-connectors/how-to/add-incoming-webhook.md
95
7
link
:white_check_mark:

msteams-platform/webhooks-and-connectors/how-to/connectors-creating.md
90
17
link
:white_check_mark:

msteams-platform/webhooks-and-connectors/how-to/connectors-using.md
94
9
link
:white_check_mark:

msteams-platform/webhooks-and-connectors/what-are-webhooks-and-connectors.md
90
15
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/includes/deprecation-note.md
100
0
link
:white_check_mark:

msteams-platform/webhooks-and-connectors/how-to/add-incoming-webhook.md
95
7
link
:white_check_mark:

msteams-platform/webhooks-and-connectors/how-to/connectors-creating.md
90
17
link
:white_check_mark:

msteams-platform/webhooks-and-connectors/how-to/connectors-using.md
94
9
link
:white_check_mark:

msteams-platform/webhooks-and-connectors/what-are-webhooks-and-connectors.md
90
15
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/includes/deprecation-note.md
100
0
link
:white_check_mark:

msteams-platform/webhooks-and-connectors/how-to/add-incoming-webhook.md
95
7
link
:white_check_mark:

msteams-platform/webhooks-and-connectors/how-to/connectors-creating.md
90
17
link
:white_check_mark:

msteams-platform/webhooks-and-connectors/how-to/connectors-using.md
94
9
link
:white_check_mark:

msteams-platform/webhooks-and-connectors/what-are-webhooks-and-connectors.md
90
15
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/includes/deprecation-note.md
100
0
link
:white_check_mark:

msteams-platform/webhooks-and-connectors/how-to/add-incoming-webhook.md
95
7
link
:white_check_mark:

msteams-platform/webhooks-and-connectors/how-to/connectors-creating.md
90
17
link
:white_check_mark:

msteams-platform/webhooks-and-connectors/how-to/connectors-using.md
94
9
link
:white_check_mark:

msteams-platform/webhooks-and-connectors/what-are-webhooks-and-connectors.md
90
15
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

repo: MicrosoftDocs/msteams-docs


text:
[Doc enhancement][Add-links-to-auto-answer-teams-calls]

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/bots/calls-and-meetings/call-notifications.md
87
10
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit 1aa5282:
:warning: Validation status: warnings

File
Status
Preview URL
Details

msteams-platform/bots/calls-and-meetings/call-notifications.md
:warning:Warning
View
Details

msteams-platform/bots/calls-and-meetings/call-notifications.md

Line 96, Column 3: [Warning: file-not-found - See documentation] Invalid file link: 'microsoftteams/create-a-phone-system-auto-attendant'.
Line 97, Column 3: [Warning: file-not-found - See documentation] Invalid file link: 'microsoftteams/set-up-auto-answer-on-teams-android'.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/bots/calls-and-meetings/call-notifications.md
87
10
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/bots/calls-and-meetings/call-notifications.md
87
10
link
:white_check_mark:

msteams-platform/bots/calls-and-meetings/calls-meetings-bots-overview.md
85
29
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit dbc2ce5:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/bots/calls-and-meetings/call-notifications.md
:white_check_mark:Succeeded
View

msteams-platform/bots/calls-and-meetings/calls-meetings-bots-overview.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


text:
[GO Live][29 June]

Docs Build status updates of commit 37542c6:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

.openpublishing.redirection.json
:white_check_mark:Succeeded

msteams-platform/get-started/get-started-overview.md
:white_check_mark:Succeeded
View

msteams-platform/messaging-extensions/how-to/action-commands/create-task-module.md
:white_check_mark:Succeeded
View

msteams-platform/messaging-extensions/how-to/enable-SSO-auth-me.md
:white_check_mark:Succeeded
View

msteams-platform/task-modules-and-cards/cards/cards-actions.md
:white_check_mark:Succeeded
View

msteams-platform/toolkit/add-single-sign-on.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel