text:
kwmc window -m  activates border

When I use this command it seems like its also marking the window that is in the direction that I am moving to. I can get rid of it by marking and unmarking the current window. Here's a screencast:

Well this is awkward, I can't reproduce..

i got a fatal: corrupt patch at line 35. need to push some changes first?

yup, that fixed it.

authors: koekeishiya matthewdias


text:
Border offset adjustment

Hello!
This is in regards tot he "off by 1 pixel" border issue for us not-able-to-disable-SIP folk: https://github.com/koekeishiya/yabai/issues/753
I feel like there used to be a way to get this to sort of look right by subtracting 1 from the origin xy coordinates of the border, and then increasing the size of the border by 1 pixel each way, but I'm not seeing a way to do this currently.
Is there any way we could implement such a thing so as to have everything look a bit better in this circumstance?
The two benefits I could see from it is:

SIP-enabled folk are able to have a better visual experience
Folk who like having heavy borders could have some 20 pixel thick border and provide an offset so they can have their borders, and still be able to see a majority of the window contents
Edit: Third thought: Peeps who have SIP disabled but like the shadows macos provides for whatever reason

I imagine main focus is on the SIP-disabled environment, so no worries if you'd rather not work on this.
Thanks for all the hard work on this! Makes the mac a lot more usable to me.

This will be fixed with the changes being made for #1430

source: gharchive/issue

authors: distek koekeishiya

repo: koekeishiya/yabai

license: MIT

license_type: permissive

license_source: github-api


text:
Since updating to 1.8, I continually have to resize preview window to get animations to work

Every time I make a change in the new Framer build (1.8) I have to grab the window of the Mac app and resize it to get any of my animations to work... not sure what's going on here. Pressing the "Refresh" button doesn't properly reset the prototype only resizing the whole Framer Application will allow me to see any of my animations.

This is no longer an issue :)

repo: koenbok/Framer

license: mit

license_source: bigquery


text:
Add support for PR reviews preview

@reviewbybees

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

Hi, I'm interested in this PR, actually I've even enchanced this with support of new Events (Status and PullRequestReview). But to submit my PR, I'd need this merged first.

I think only @kohsuke can do that.

Fixes #305

I have accidentally created a  pull request for the same purpose (#366) and I must confess that I'm very surprised that it's similar in so many ways. Regardless of that, since this PR has been created before and has already been reviewed by a CloudBees employee, I will close mine in favour or this one.
I will do my review on this one too since we both spent a significant time working on this matter and I would love to see this merged in the short-term as some of the automation process I created at work would really benefit of it.
@kohsuke when you have a spare time, please merge it ;)

Hi, I'm interested in this PR, actually I've even enchanced this with support of new Events (Status and PullRequestReview). But to submit my PR, I'd need this merged first.

@porcelli Now that this is merged and released would you be able to issue your PR to add event support for PR reviews?

@mattnelson the new events (Status and PullRequestReview) that @porcelli mentioned were already merged in this PR: https://github.com/kohsuke/github-api/pull/363/files

@PauloMigAlmeida thanks, I missed that.
I was specifically looking for the data binding in GHEventPayload as I was wanting to implement a hook on the PullRequestReview event. If this hasn't been implemented yet, I will look into it. The rest of the parts are already there, so it should be pretty strait forward.

Hi @mattnelson
If what you want it to implement a hook based on the PullRequestReview event from ``GHEvent``` class. This is what you can do:
PS.: This is a piece of code extracted from an internal system of ours that does exactly you just described.
public class GitConfigRepositoryOperation extends AbstractGitHubOperation<Void> {

    private GHRepository repository;
    private final static String webhookUrl;

    static{
        webhookUrl = KMSEnvironmentalVariableDecryptService.getInstance().decryptKey("GitWebhookUrl");
    }

    public GitConfigRepositoryOperation(GHRepository repository) throws IOException {
        super(repository.getFullName());
        this.repository = repository;
    }

    @Override
    public Void performOperation() throws Exception {

        // Configure Webhook
        Map<String, String> configMap = new HashMap<>(2);
        configMap.put("url", webhookUrl);
        configMap.put("content_type", "json");
        this.repository.createHook("web",
                configMap,
                Arrays.asList(
                    GHEvent.PULL_REQUEST,
                    GHEvent.PULL_REQUEST_REVIEW,
                    GHEvent.PULL_REQUEST_REVIEW_COMMENT,
                    GHEvent.PUSH,
                    GHEvent.CREATE
                ), true);

        return null;
    }

Hope that it helps.

source: gharchive/pull-request

authors: PauloMigAlmeida henryju jglick mattnelson porcelli reviewbybees stephenc

repo: kohsuke/github-api


text:
Fix gl test field example

Continuing #55
This PR:

fixes example/gl_test_field_example.cpp segmentation vault by correctly (?) initializing the number of color buffers in gl_canvas. Please let me know if my thinking is correct here.
Correctly loads bunny texture: The gui menu doesn't exactly match the main switch case in Primitives::create_primitive. Because case COORDINATE_SYSTEM falls through to SOLID_COORDINATE_SYSTEM increment bunny toggle from gui (in items) by one if primitive type is 6. To maintain a valid imGui combo, this has to be done in a separate variable

Note: I used your clang format file for formatting, which introduced some syntax changes

Thanks a lot for your PR. I did a quick test for the updates, and they look good to me. I merge it :+1:


text:
Bug: 本地sd是否支持img2img

Describe the bug
本地部署的sd,text2img成功，但是img2img一直失败，无报错信息,qq机器人调用报错500，接口信息如下：
Steps to reproduce
本地部署
Expected behavior
支持图生图模式
Screenshots

Relevant log output
No response
Launcher
Koishi Desktop
Backend
Stable Diffusion WebUI (AUTOMATIC1111)
Versions

OS:
Adapter:
Node version:
Koishi version:
全部最新版本

Additional context
No response

你尝试在这个界面调用此接口，如果也报错 500 请前往 SD-WebUI 报告 issue

当我调用这个接口 报错500

当我调用这个接口 报错500

是的，这就说明问题出在那边

There should be error messages output from your sd-webui side, did you get anything about it?
应该有错误信息从sd-webui方面输出，你得到任何东西了吗？

暂时没有有用的信息，有用的我都会复制给你，我在本地部署的webui界面调用，图生图功能是正常的，不明白为嘛接口调用不行，是网络问题么？比如跨域？我不懂网络

暂时没有有用的信息，有用的我都会复制给你，我在本地部署的webui界面调用，图生图功能是正常的，不明白为嘛接口调用不行，是网络问题么？比如跨域？我不懂网络

不出意外的话，你的 webui console 里应该有至少一条 IndexError: list index out of range 报错

Well, the img2img feature was implemented in #79 already, although it is still experimental.
Maybe should I give you a check list so you can trouble shoot on your side.

Make sure you are using the latest commit of https://github.com/AUTOMATIC1111/stable-diffusion-webui
Use Python 3.10 (DO NOT use any other versions of Python)
Make sure the --api parameter was passed
If your bot and webui were deployed on different machines, you should pass --listen as well

嗯，img2img的功能已经在#79中实现了，尽管它仍然是实验性的。
也许我应该给你一个检查清单，这样你就可以在你那边进行故障排除。

确保你使用的是 https://github.com/AUTOMATIC1111/stable-diffusion-webui 的最新提交版本
使用 Python 3.10 (不要使用任何其他版本的 Python)
确保--api参数已经通过
如果你的机器人和webui被部署在不同的机器上，你也应该传递--listen。

恩这几点我都检查了，我确实是在另一个机器上，--listen必须加才能访问，我刚才登陆另一台本地访问接口，也报相同错误 Internal Server Error 没有其他有用信息，明天再查一遍

我在控制台找到一些错误信息@MaikoTan @MirrorCY
ERROR:    Exception in ASGI application
Traceback (most recent call last):
File "/home/yyl/stable-diffusion-webui/venv/lib/python3.10/site-packages/uvicorn/protocols/http/h11_impl.py", line 407, in run_asgi
result = await app(  # type: ignore[func-returns-value]
File "/home/yyl/stable-diffusion-webui/venv/lib/python3.10/site-packages/uvicorn/middleware/proxy_headers.py", line 78, in call
return await self.app(scope, receive, send)
File "/home/yyl/stable-diffusion-webui/venv/lib/python3.10/site-packages/fastapi/applications.py", line 270, in call
await super().call(scope, receive, send)
File "/home/yyl/stable-diffusion-webui/venv/lib/python3.10/site-packages/starlette/applications.py", line 124, in call
await self.middleware_stack(scope, receive, send)
File "/home/yyl/stable-diffusion-webui/venv/lib/python3.10/site-packages/starlette/middleware/errors.py", line 184, in call
raise exc
File "/home/yyl/stable-diffusion-webui/venv/lib/python3.10/site-packages/starlette/middleware/errors.py", line 162, in call
await self.app(scope, receive, _send)
File "/home/yyl/stable-diffusion-webui/venv/lib/python3.10/site-packages/starlette/middleware/gzip.py", line 24, in call
await responder(scope, receive, send)
File "/home/yyl/stable-diffusion-webui/venv/lib/python3.10/site-packages/starlette/middleware/gzip.py", line 43, in call
await self.app(scope, receive, self.send_with_gzip)
File "/home/yyl/stable-diffusion-webui/venv/lib/python3.10/site-packages/starlette/middleware/cors.py", line 92, in call
await self.simple_response(scope, receive, send, request_headers=headers)
File "/home/yyl/stable-diffusion-webui/venv/lib/python3.10/site-packages/starlette/middleware/cors.py", line 147, in simple_response
await self.app(scope, receive, send)
File "/home/yyl/stable-diffusion-webui/venv/lib/python3.10/site-packages/starlette/middleware/exceptions.py", line 75, in call
raise exc
File "/home/yyl/stable-diffusion-webui/venv/lib/python3.10/site-packages/starlette/middleware/exceptions.py", line 64, in call
await self.app(scope, receive, sender)
File "/home/yyl/stable-diffusion-webui/venv/lib/python3.10/site-packages/fastapi/middleware/asyncexitstack.py", line 21, in call
raise e
File "/home/yyl/stable-diffusion-webui/venv/lib/python3.10/site-packages/fastapi/middleware/asyncexitstack.py", line 18, in call
await self.app(scope, receive, send)
File "/home/yyl/stable-diffusion-webui/venv/lib/python3.10/site-packages/starlette/routing.py", line 680, in call
await route.handle(scope, receive, send)
File "/home/yyl/stable-diffusion-webui/venv/lib/python3.10/site-packages/starlette/routing.py", line 275, in handle
await self.app(scope, receive, send)
File "/home/yyl/stable-diffusion-webui/venv/lib/python3.10/site-packages/starlette/routing.py", line 65, in app
response = await func(request)
File "/home/yyl/stable-diffusion-webui/venv/lib/python3.10/site-packages/fastapi/routing.py", line 231, in app
raw_response = await run_endpoint_function(
File "/home/yyl/stable-diffusion-webui/venv/lib/python3.10/site-packages/fastapi/routing.py", line 162, in run_endpoint_function
return await run_in_threadpool(dependant.call, **values)
File "/home/yyl/stable-diffusion-webui/venv/lib/python3.10/site-packages/starlette/concurrency.py", line 41, in run_in_threadpool
return await anyio.to_thread.run_sync(func, *args)
File "/home/yyl/stable-diffusion-webui/venv/lib/python3.10/site-packages/anyio/to_thread.py", line 31, in run_sync
return await get_asynclib().run_sync_in_worker_thread(
File "/home/yyl/stable-diffusion-webui/venv/lib/python3.10/site-packages/anyio/_backends/_asyncio.py", line 937, in run_sync_in_worker_thread
return await future
File "/home/yyl/stable-diffusion-webui/venv/lib/python3.10/site-packages/anyio/_backends/_asyncio.py", line 867, in run
result = context.run(func, *args)
File "/home/yyl/stable-diffusion-webui/modules/api/api.py", line 84, in img2imgapi
mask = decode_base64_to_image(mask)
File "/home/yyl/stable-diffusion-webui/venv/lib/python3.10/site-packages/gradio/processing_utils.py", line 45, in decode_base64_to_image
content = encoding.split(";")[1]
IndexError: list index out of range

You are the n-th one I don't know that has this error occurred.
Obviously this is the issue of sd-webui itself, so it cannot be fixed on our side. I would recommend you to report bugs on their side.
What I can do is continuously tracking commits from sd-webui and update if anything broken. Amen.
你是第n个我不知道的人有这个错误发生。
很明显这是sd-webui自身的议题，因此它不能在我们这边修复。我会推荐你在他们方面报告缺陷。
我能做的是继续跟踪来自sd-webui的提交，并且在有东西损坏的时候更新。阿门。

Oh, I think it can be fixed on our side.
The patch is on the way, please give it another heure.
噢，我想它可以在我们这边修复。
这个补丁在路上，请给它另一个小时。

authors: MaikoTan MirrorCY yulongyu

repo: koishijs/novelai-bot


text:
🛑 Leo Pizza is down

In 7b3df7e, Leo Pizza (https://leo-pizzaservice.de) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Leo Pizza is back up in 11e3e36 after 10 minutes.

repo: koko-io/up


text:
Bytes version upgrade to 1.0

Please make sure these boxes are checked, before submitting a new PR.

[✅] You ran rustfmt on the code base before submitting (on latest nightly with rustfmt support)
[✅] You reference which issue is being closed in the PR text (if applicable)

Breaking Changes
Please document any breaking changes in this PR.

Bytes Dependency upgraded to 1.0
Buf.bytes() method is renamed to Buf.chunk(), implemented by ChunkRef and ChunkLease and likely used in deserialisation methods.

Other Changes
Replaced the deprecated compare_and_swap() call with the newer compare_exchange() method.

Did Travis die

Did Travis die

Did Travis die

Yeah, we are working on it. We ran out of credit and their team is too slow making it an open source project. It's a bloody nuisance.

Did Travis die

Yeah, we are working on it. We ran out of credit and their team is too slow making it an open source project. It's a bloody nuisance.

@Bathtor are you interested in switching to GH actions at all?

@Bathtor are you interested in switching to GH actions at all?

@Bathtor are you interested in switching to GH actions at all?

@huitseeker We are considering it as a backup option. I'm giving Travis another week to get their shit together and then we gotta evaluate if there are alternatives (such as GH Actions) that can actually run all the stuff we need them to run.

@Bathtor are you interested in switching to GH actions at all?

@huitseeker We are considering it as a backup option. I'm giving Travis another week to get their shit together and then we gotta evaluate if there are alternatives (such as GH Actions) that can actually run all the stuff we need them to run.

authors: Bathtor Max-Meldrum adamhass huitseeker

repo: kompics/kompact


text:
if naz cant send to smsc it should stop consuming from queue

if this fails: https://github.com/komuw/naz/blob/14fe3bec4039b6aa27f65e3046e215244a807b5c/naz/client.py#L1495-L1501
we should set a flag to smsc_down=True and if it succeeds set it to smsc_down=False
Then in the while loop for dequeue_messages: https://github.com/komuw/naz/blob/14fe3bec4039b6aa27f65e3046e215244a807b5c/naz/client.py#L1551-L1597
we should check that flag and if smsc_down=True we should not consume and instead sleep.
Now, the loop for enquire_link; https://github.com/komuw/naz/blob/14fe3bec4039b6aa27f65e3046e215244a807b5c/naz/client.py#L826
will continue running. So when an enquire link succeeds, the flag will change to smsc_down=False and we are back in business

The PR: https://github.com/komuw/naz/pull/137 will get merged with minor cosmetic changes but not any of the substantive changes needed for this issue.
We will not implement this feature.
What if we implement this feature and then 1 out of every 3 requests to smsc fail?  will we be sleeping for 60seconds once every 3times. No, which means to imply that maybe we only need set smsc_down flag based on percentage failure.
It gets sloppy and complicated.
People should pause queues on their own, or use the ratelimit interface

repo: komuw/naz


text:
fix(RELEASE-967): incorrect bevior in apply-mapping when no tags defined

When loading the default tags or component tags, there was no default value, so if there were no tags defined, we would end up with a null value / empty string. And this would cause an error message when running jq 'length' on this.

/test release-pipelines-e2e-suite

Typo in title and first commit

Typo in title and first commit

oh, thanks! the word did seem a bit short :D

/test release-pipelines-e2e-suite

/test release-pipelines-e2e-suite

authors: johnbieren mmalina scoheb

repo: konflux-ci/release-service-catalog


text:
Add featured report (EPA Flint, MI)

"The EPA's OIG found that EPA Region 5 should have intervened sooner in the Flint, MI water crisis. Since Michigan's actions failed to protect the public, the Safe Drinking Water Act gave the EPA the authority to issue an emergency order, though they didn't do so until seven months later."

:+1:

authors: divergentdave konklone


text:
merge from konsum-frontend-svelte,template-css,template-svelte-app

package.json

chore(deps): add ^14.8.1 remove ^14.8.0 (devDependencies.stylelint)

:tada: This PR is included in version 1.31.17 :tada:
The release is available on:

npm package (@latest dist-tag)
v1.31.17
GitHub release

Your semantic-release bot :package::rocket:

repo: konsumation/konsum-frontend-svelte


text:
Expose more internal methods for individual use

Motivation
I'd like to be able to leverage diffing logic defined in this library for individual use cases rather than all in one go.
For example, when writing a script to handle migrating assets between Kontent.ai environments, I'd like to be able to also compare and sync asset folders to ensure that all folders exist before attempting to move assets.
Proposed solution
Export more functions via public.js.
Additional context
#76 needs to be resolved before this is possible.

Hey @nkooman-bzs
Thanks for the issue.
What functions would you like to see exported?

I see your use case.
I will think about the solution - we will probably expose the functions you want or update the existing diffEnvironment function and add some supporting to it.

Hey @nkooman-bzs.
I am thinking about exposing the diff functionality through diffEnvrironments function - that one would load source and target model and return DiffModel object. However, DiffModel uses the data-ops internal patch operations to update the entity. Those operations needs to be additionally processed before syncing. That would need to be documented, and also some other functions would need to be exposed like printDiff or createAdvancedDiff. That led me to question whether it is worth exposing that function or creating some new for comparing the environments. What exactly would you like to do with the DiffModel object? Do you only want to see whether there are empty properties or even something else?

We are working on partial sync, where you would be able to define which entities you want to sync. Like there would be a parameter --entities in which you would define assetFolders and then only assetFolders would sync. Would that help you?

If I'm able to do so programmatically, I think that would work.

Hey @nkooman-bzs,
partial sync is now available in data-ops 2.0 :) Let me know if it fixes your use case.
Thanks

@IvanKiral unfortunately my current project has a dependency on migration-toolkit@1.x. I will not be able to verify directly whether or not this works. However, I have reviewed the new changes and from what I can tell this will absolutely resolve my issue. These changes are great, thanks!

authors: IvanKiral nkooman-bzs

repo: kontent-ai/data-ops


text:
REFRESH

[ ] Redmine Issue: https://redmine.pfsense.org/issues/NNNN
[ ] Ready for review

CLOSED

repo: kontrol-br/pfsense


text:
MIG-249 - [WIP] Fix orphaned stage pods

Updating stage pods labels to include migplan which allows its correct deletion
even it would be executed by a rollback migration (where migmigration labels
wouldn't match).
Fixes: https://github.com/konveyor/mig-controller/issues/700

Labels on a stage pods now look like:
  labels:
    app.kubernetes.io/part-of: openshift-migration
    migmigration: f45f026c-cc6f-48c4-953b-d0497f1d0fd7
    migplan: 368ee6fa-07f9-48be-af46-93e3991ed946
    migration-included-stage-backup: f45f026c-cc6f-48c4-953b-d0497f1d0fd7
  name: stage-stage-bm-amq-producer-bmxp2-9p92j

Updated the PR with deletion lookup correlationLabels change to migplan. Controller log example deleting an orphaned stage pod from previously failed migration:
...
{"level":"info","ts":1604063025.0978706,"logger":"migration|th82b","msg":"[RUN]","migration":"mig-run","stage":false,"phase":"Started"}
{"level":"info","ts":1604063025.3906949,"logger":"migration|c2kg9","msg":"[RUN]","migration":"mig-run","stage":false,"phase":"StartRefresh"}
{"level":"info","ts":1604063027.9710095,"logger":"migration|skgmv","msg":"[RUN]","migration":"mig-run","stage":false,"phase":"WaitForRefresh"}
{"level":"info","ts":1604063028.7104301,"logger":"migration|h2d82","msg":"[RUN]","migration":"mig-run","stage":false,"phase":"Prepare"}
{"level":"info","ts":1604063029.1045384,"logger":"migration|h2d82","msg":"Stage pod deleted.","migration":"mig-run","ns":"amq-producer","name":"stage-stage-bm-amq-producer-bmxp2-9p92j"}
{"level":"info","ts":1604063029.3879786,"logger":"migration|h2d82","msg":"PVC annotations/labels removed.","migration":"mig-run","ns":"amq-producer","name":"producer-state"}
{"level":"info","ts":1604063031.1422539,"logger":"migration|56w29","msg":"[RUN]","migration":"mig-run","stage":false,"phase":"EnsureCloudSecretPropagated"}
{"level":"info","ts":1604063032.775739,"logger":"migration|cqp65","msg":"[RUN]","migration":"mig-run","stage":false,"phase":"EnsureCloudSecretPropagated"}
{"level":"info","ts":1604063034.1915019,"logger":"migration|pgk7z","msg":"[RUN]","migration":"mig-run","stage":false,"phase":"PreBackupHooks"}
{"level":"info","ts":1604063034.5929632,"logger":"migration|hxd6n","msg":"[RUN]","migration":"mig-run","stage":false,"phase":"EnsureInitialBackup"}
...

repo: konveyor/mig-controller


text:
update ClusterColocationProfile CRD

Signed-off-by: Tao Li joseph.t.lee@outlook.com

/lgtm
/approve

authors: eahydra stormgbs

repo: koordinator-sh/charts


text:
[BUG]I install koordinator on huaweicloud cce,but I can't get the right result for the spark-pi job.

What happened:
when I use koordinator on huaweiCloud cce.

I describe the pod:

I can't find batch-cpu and batch-memory information from the node:

I fetch logs from koordlet use kubectl logs ds:
kubectl logs --tail=10 koordlet-cd9xg

So I modify the kubelet config for the node:

I get the error info when the koordlet send request to kubelet:
this is the logs on the koordlet pod:

this is the thumbnail on the node:

kubelet config:
`kind: KubeletConfiguration
apiVersion: kubelet.config.k8s.io/v1beta1
address: 0.0.0.0
#address: 7.183.231.172
authentication:
anonymous:
enabled: false
x509:
clientCAFile: /opt/cloud/cce/srv/kubernetes/cluster-ca.crt
authorization:
mode: Webhook
clusterDNS:
- 10.247.3.10
clusterDomain: cluster.local
enableControllerAttachDetach: true
evictionHard:
memory.available: 100Mi
nodefs.available: 10%
nodefs.inodesFree: 5%
imagefs.available: 10%
featureGates:
DevicePlugins: true
MultiGPUScheduling: true
ExpandCSIVolumes: true
CSIInlineVolume: true
CSIMigrationFlexVolumeFuxi: true
CSIMigrationFlexVolumeFuxiComplete: true
CSIMigration: true
IPv6DualStack: false
ReserveMemoryCgroupForPageCache: false
SizeMemoryBackedVolumes: true
OversubscriptionResource: false
maxPods: 110
podPidsLimit: -1
port: 10250
readOnlyPort: 10255
staticPodPath: "/opt/cloud/cce/kubernetes/manifests"
serverTLSBootstrap: true
imageGCHighThresholdPercent: 80
imageGCLowThresholdPercent: 70
kubeAPIQPS: 100
kubeAPIBurst: 100
cpuManagerPolicy: none
tlsCipherSuites:
- TLS_ECDHE_ECDSA_WITH_AES_128_GCM_SHA256
- TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256
- TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
- TLS_ECDHE_ECDSA_WITH_AES_256_GCM_SHA384
kubeletCgroups: "/kubelet"
eventRecordQPS: 5
`
kubernetes version:

What you expected to happen:
kubelet response the pod information to the koordlet
How to reproduce it (as minimally and precisely as possible):
use huawei cloud cce and helm install koordinator.
Anything else we need to know?:
Environment:

App version:
Kubernetes version (use kubectl version):
Install details (e.g. helm install args):
Others:

test

Hi @forcoder, according to this article, Huawei CCE is supposed to supoort 10255 port. Can you confirm with people from Huawei?

@forcoder as discuss in DingDing group, could you submit a PR compatible with the mode of list-watch pods from apiserver？

@forcoder as discuss in DingDing group, could you submit a PR compatible with the mode of list-watch pods from apiserver？

I have a try

authors: forcoder hormes jasonliu747

repo: koordinator-sh/koordinator


text:
[BackEnd] doesn't work with github.

this Error when  click SIGNUP WITH GITHUB button.
Is this working normally? If don't go to the main page with github user information, I will need to rewrite the code for the Chrome extension.
Plz when signin our service with github, send to the main page if users are already signed up.
Could this be because of a problem with github's server today?

Solved now


text:
New StrictlyPositiveDouble type

Description
We would like to implement a new StrictlyPositiveDouble type representing strictly positive floating-point numbers represented by the Double type.
This new type should also be serializable.
/** Represents strictly positive floating-point numbers represented by the [Double] type. */
sealed interface StrictlyPositiveDouble : Comparable<StrictlyPositiveDouble> {
    /**
     * Compares this floating-point number with the other one for order.
     * Returns zero if this floating-point number equals the other one,
     * a negative number if it's less than the other one,
     * or a positive number if it's greater than the other one.
     */
    override fun compareTo(other: StrictlyPositiveDouble): Int

    /** Returns this floating-point number as a [Double]. */
    fun toDouble(): Double

    /** Returns the string representation of this floating-point number. */
    override fun toString(): String
}

// TODO: This function should also be present in the ResultContext type.
/**
 * Returns this number as an encapsulated [StrictlyPositiveDouble], which may involve rounding or truncation,
 * or returns an encapsulated [IllegalArgumentException] if this number is negative.
 */
fun Number.toStrictlyPositiveDouble(): Result<StrictlyPositiveDouble> = TODO()

Checklist

[x] Implement the type with its builder.
[x] Make the type serializable.
[x] Test on all platforms.
[x] Refactor.
[x] Update the Unreleased section in changelog.

These new declarations should be introduced as experimental features.
Here's a list of tasks to do before resolving this issue:

[ ] Add an ExperimentalFloatingPointNumberApi annotation in the kotools.types.experimental package.
[ ] Mark declarations introduced by this issue with the new annotation.
[ ] Update the Unreleased section in the changelog.

repo: kotools/types


text:
[Build] Upgrade Python version to 3.11 for CI/CD pipeline

Problem (Why?)
just upgrading
Solution (What/How?)

[x] Python version to 3.11 for CI/CD pipeline
[x] codecov/codecov-action to v3
[x] remove CUDA-related packages from the dependencies manually
[x] upgrade dev dependencies
[x] replace lint.py with pylint built-in option (fail-under)

Other changes (bug fixes, small refactors)
nope
Notes
nope

Codecov Report

Merging #86 (98d6e69) into main (d316d1c) will not change coverage.
The diff coverage is 100.00%.

:exclamation: Current head 98d6e69 differs from pull request most recent head e3c1f97. Consider uploading reports for the commit e3c1f97 to get more accurate results

@@           Coverage Diff           @@
##             main      #86   +/-   ##
=======================================
  Coverage   96.30%   96.30%
=======================================
  Files          31       31
  Lines        2218     2218
=======================================
  Hits         2136     2136
  Misses         82       82

Impacted Files
Coverage Δ

pytorch_optimizer/lr_scheduler/cosine_anealing.py
100.00% <100.00%> (ø)

pytorch_optimizer/optimizer/adapnm.py
98.64% <100.00%> (ø)

pytorch_optimizer/optimizer/fp16.py
68.57% <100.00%> (ø)

pytorch_optimizer/optimizer/pnm.py
98.36% <100.00%> (ø)

pytorch_optimizer/optimizer/ranger21.py
98.32% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

authors: codecov-commenter kozistr


text:
Update to Mirth 4.x

Can you update the example to use the Mirth Connect 4.x libs?
Thanks
Paul.

Pushing the request. :)

That would be a big help, @kpalang

Fixed!
Sorry @mcswaip1 it took so long...

repo: kpalang/mirth-sample-plugin


text:
Proceed with the Django Girls tutorial

Do a PR per each tutorial page. For simplicity of tracking progress, you may add markdown checkboxed list here.

@webknjaz https://github.com/kpi-web-guild/django-girls-blog-serhii73/pull/21 - I passed the first page.
Did I understand correctly that I need a new branch for each page?
From what branch I need new branch? From master? Right?
I need to merge into master, and only then create a new branch?
Am I not able to create a parallel branch? Before I merge into master?

Sometimes you can do stuff in parallel. According to GitHub Flow (which you should check out), you have to create new feature branches from master and then sync your branches with mater using merge or rebase (but I strongly don't recommend you mixing these two techniques).
So you don't have to wait till merging some feature into master unless it depends on that code. It this case you could create new branch from dependent one, but after it's merged to master sync your code in newer branch with rebase or merge.

[ ]  django_start_project

[ ]  django_models

[ ]  django_admin

[ ] deploy

[ ] django_urls

[ ] django_views

[ ] html

[ ] django_orm

[ ] dynamic_data_in_templates

[ ] django_templates

[ ] css

[ ] template_extending

[ ] extend_your_application

[ ] django_forms

@webknjaz I finished the tutorial.
http://serhii73.pythonanywhere.com/
https://github.com/kpi-web-guild/django-girls-blog-serhii73/pull/31

Finishing tutorial was never the point. The main goal is to show you how to work with code/github


text:
Follow all redirects with request

When running vault in HA mode, you must follow redirects on PUT/POST/DELETE. By default the request module only follows redirects for GET requests. To enable this you just have to set followAllRedirects to true when making a request. Only work around I see at the moment is to monkey patch the _request method:
  vault._request = function(opts, done) {
      debug(opts);
    var uri;
    if (opts == null) {
      opts = {};
    }
    uri = this.endpoint + "/" + this.apiVersion + opts.path;
    uri = this.mustache.render(uri, opts.json);
    uri = uri.replace(///g, '/');
    debug(opts.method + " " + uri);
    if (!opts['headers']) {
      opts.headers = {};
    }
    if (this.token != null) {
      opts.headers['X-Vault-Token'] = this.token;
    }
    opts.uri = uri;
    opts.followAllRedirects = true;
    return this.request(opts, function(err, res, body) {
      if (err) {
        debug(err);
        return done(err);
      }
      debug("RES " + (res != null ? res.statusCode : void 0));
      if (body) {
        if (typeof body !== 'object') {
          body = JSON.parse(body);
        }
        debug(body);
      }
      return done(err, res, body);
    });
  };

@crazed Thanks for the hint. But it was already possible to pass a requestOptions key to any vault method.
See https://github.com/kr1sp1n/node-vault/blob/a168210eae75ba705beb4534de0d2bff1eec5e0b/example/auth.js for an example.


text:
Mojo::JSON Boolean compability

Mojo::JSON::_Bool has recently been replaced with JSON::PP::Boolean. I suggest to use JSON::true and JSON::false instead and check for boolean values with JSON::is_bool. It improves compability with JSON, which can have JSON::PP or JSON::XS as backend.
I'm currently struggling with encoding errors when I try to re-encode data with JSON::XS which has previously been decoded by Mojo::JSON (and vice versa).

Would you be able to provide a testcase that demonstrates the problem?
I can't reproduce this on my box:
$ perl -MMojo::JSON=j -MJSON::XS=encode_json -wlE 'say encode_json j "[false, true]"'
[false,true]

Does it work the other way around? I'm using an older version of JSON::XS, but I've just seen that in version 3.0 the class Types::Serialiser::Boolean is used which is an alias for JSON::PP::Boolean. Previously they used JSON::XS::Boolean.

Use of JSON::XS is discouraged actually, we recommend Cpanel::JSON::XS and Mojo::JSON::MaybeXS.

One more thing, we've specifically chosen JSON::PP::Boolean because it ships with core Perl, in the hopes that other serializers will standardize on it as well, since it is as close to a core boolean type as we can get with Perl.

Does it work the other way around?
Yes.

I'm using an older version of JSON::XS
Confirming the problem exists with an outdated JSON::XS, but that's solved by simply upgrading it to the latest version.

As stated above use of JSON::XS is discouraged. Cpanel::JSON::XS, Mojo::JSON::MaybeXS, and JSON::MaybeXS are all fine alternatives.

Unfortunately some Mojo classes uses a stringify overload, which only works with Mojo::JSON. Maybe a TO_JSON method can be added in those classes to also work with Mojo::JSON::MaybeXS.

There is already an open issue for Cpanel::JSON::XS. :wink: https://github.com/rurban/Cpanel-JSON-XS/issues/37

authors: cziebuhr kraih zoffixznet

repo: kraih/mojo


text:
Fixed typo in lua.md

Signed-off-by: Atul Krishna atultherajput@gmail.com
There was a typo error in lua.md file.

Thank you @atultherajput, the website will be updated in a few days

authors: alombarte atultherajput

repo: krakendio/krakend-documentation


text:
Enhancement: Toggle CSS class on xcomponent container.

I like the ability of being able to resize the surronding xcomponent container on the parent site. It would be even better if we could give the child component the ability to apply a class to its container instead of just having the resize option.

Hey sorry I missed this issue when you first posted it -- was out on vacation and missed the notification.
I'd rather not add special library support for this since it can be done fairly easily through a prop with a default value:
let MyComponent = xcomponent.create({

    addClass: {
        type: 'function',
        value: function(selector, className) {
            document.querySelector(selector).classList.add(className);
        }
    }
});

That should do the trick! thanks!

repo: krakenjs/xcomponent


text:
model name not found

hey @qin-yu
I got this error when trying to use the plantseg config at this line
https://github.com/kreshuklab/go-nuclear/blob/12caacbabca35a3d386fe038afa8fd47cc61f495/plantseg/configs/config_pred_wide_applicability.yaml#L40
RuntimeError: key: model_name has got value: generic_plant_nuclei_3D, but value must be one of ['generic_confocal_3D_unet', 'generic_light_sheet_3D_unet', 'confocal_3D_unet_ovules_ds1x', 'confocal_3D_unet_ovules_ds2x', 'confocal_3D_unet_ovules_ds3x', 'confocal_2D_unet_ovules_ds2x', 'lightsheet_3D_unet_root_ds1x', 'lightsheet_3D_unet_root_ds2x', 'lightsheet_3D_unet_root_ds3x', 'lightsheet_2D_unet_root_ds1x', 'lightsheet_3D_unet_root_nuclei_ds1x', 'lightsheet_2D_unet_root_nuclei_ds1x', 'confocal_2D_unet_sa_meristem_cells', 'confocal_3D_unet_sa_meristem_cells', 'lightsheet_3D_unet_mouse_embryo_cells', 'confocal_3D_unet_mouse_embryo_nuclei', 'PlantSeg_3Dnuc_platinum']

I assumed PlantSeg_3Dnuc_platinum is the generalist model.

Sorry @JoOkuma, I somehow completely overlooked all the issues and PRs for this repo. I might have accidentally clicked "unwatch" several months ago.
You’re absolutely right: PlantSeg_3Dnuc_platinum is the model name we ultimately decided on. Initially, I proposed using generic_plant_nuclei_3D to align with the naming conventions of PlantSeg models, but we finalized the new name for the manuscript.
Feel free to submit a PR if you'd like! Otherwise, I’ll make the changes in a few days.

I just noticed #3 reporting the same issue. I’ll make a quick commit to fix it asap.
Thank you so much for trying this out and reporting the issue!

authors: JoOkuma qin-yu

repo: kreshuklab/go-nuclear


text:
cdn.jsdelivr.net is serving v6.5.0

Fuse v6.5.0 is being served from https://cdn.jsdelivr.net/npm/fuse.js/dist/fuse.min.js:
/**
 * Fuse.js v6.5.0 - Lightweight fuzzy-search (http://fusejs.io)
 *
 * Copyright (c) 2021 Kiro Risk (http://kiro.me)
 * All Rights Reserved. Apache Software License 2.0
 *
 * http://www.apache.org/licenses/LICENSE-2.0
 */
undefined

It looks like there was a problem with the release for this version, so it was pulled from Github, but cdn.jsdelivr.net is still serving it.  Is there any way that this can be fixed within cdn.jsdelivr.net?

Best thing to do is probably release a fixed 6.5.1 and purge the CDN cache. Let me know when its done and we can purge

6.5.1 has been released. Though I'm still seeing `undefined'

Ok, I know the problem. Currently fixing it.

6.5.2 has been released. The issue was due to Terser which affected minification.

Everything should be good on the jsDelivr side too. Let me know if we can help with anything else

authors: jimaek krisk michaeljoelphillips

repo: krisk/Fuse


text:
Angular-nvd3 as a child directive

Hello,
I am trying to write an angular directive with isolated scope that has a template containing the angular-nvd3 directive
angular.module('myApp', ['nvd3'])
  .directive('myD', [function() {
    return {
      template: '<div nvd3 options="ctrl.options" data="ctrl.data"></div>',
      bindToController: true,
      scope: {
        w: '=',
        h: '='
      },
      controllerAs: 'ctrl',
      controller: [function() {
        var ctrl = this;
        ctrl.options = ctrl.options || {
         ... // nvd3 options object
        };
        ctrl.options.chart.width = ctrl.w;
        ctrl.options.chart.width = ctrl.w;
      }]
    }
  }]);

The problem is in my testing when I modify the props to my parent directive, the nvd3 graph does not update. Looking at the code for angular-nvd3, I would have thought that any change to the options prop would trigger a refresh(it certainly seems to when it's not a child directive).
Any thoughts/suggestions to achieve this?

The nvd3 directive lets you say
<nvd3 api="api" ...>
as a way to pass through an 'api' object that you can call various update/refresh methods on.  I think that's the answer to your problem, though I haven't tried it.  See http://krispo.github.io/angular-nvd3/#/quickstart and look for the keyword API.


text:
adding an event/callback on mouse clicks

Hi,
How do I add an event/callback for mouse clicks?  I've tried adding dispatch and would see the console logs inside the functions, but unable it is unable to see my component variables.
In the code below, i could see console logging, but the setting of displayData is not done.  I've also tried calling a function inside dispatch, but the browser says it is undefined.  What I want to is to be able to call my own function on a mouse click event.
  displayData: string = "abc";  ngOnInit(){     this.options = {       chart: {         type: 'historicalBarChart',         height: 70,         color: ["#2BBED8"],         margin : {           top: 0,           right: 10,           bottom: 10,           left: 10         },       dispatch: { //container of event handlers                   elementMousemove: function(e){                      console.log("mousemove"+ JSON.stringify(e));                     this.displayData = "xyz"                   },                   elementMouseout: function(e){ console.log('mouseout'+ JSON.stringify(e)) },                   chartClick: function(e){ this.displayData = "xyz"; console.log('chartClick'+ JSON.stringify(e)) },                   elementClick: function(e){ console.log('elementClick'+ JSON.stringify(e)) },                   elementDblclick: function(e){ console.log('double click' + JSON.stringify(e)) }               },
Thanks,

I think we're having the same issue here...
http://stackoverflow.com/questions/38392390/bind-ng2-nvd3-chart-with-component-in-angular-2-using-dispatch


text:
🛑 ISS Tracker API is down

In 4ae30ac, ISS Tracker API (https://hobbies-backend.vercel.app/open-notify/iss-now) was down:

HTTP code: 504
Response time: 10279 ms

Resolved: ISS Tracker API is back up in 3b2f748 after 6 minutes.


text:
B/google api

Pull Request for initial Implementation
Backend
Make sure, you have done de following before merging this pull request:

[ ] Your code is documented using doc comments.
[ ] You added appropriate logging in your code.
[ ] You added unit tests to all your implemented functions.
[ ] You ran cargo format to format your code.
[ ] You ran cargo clippy to check for improvements.

Tests, docs and probably logging still needs to be done

All tests that fail depend on the json file. Idk where that file is or how that path gets passed by...

repo: kronos-et-al/MensaApp


text:
Do graceful shutdown of http server in Inference Graph router

/kind bug
What steps did you take and what happened:
While active traffic is being received, if router pods are getting re-stacked (due to any changes say minReplica change), we observed 5xx for in-flight requests.
First suspicion is that we are not handling SIGTERM signal and not shutting down http server gracefully in router.
What did you expect to happen:
Graceful shutdown of http server and in-flight requests should not have been impacted.
What's the InferenceService yaml:
[To help us debug please run kubectl get isvc $name -n $namespace -oyaml and paste the output]
Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]
Environment:

Istio Version:
Knative Version:
KServe Version:
Kubeflow version:
Cloud Environment:[k8s_istio/istio_dex/gcp_basic_auth/gcp_iap/aws/aws_cognito/ibm]
Minikube/Kind version:
Kubernetes version: (use kubectl version):
OS (e.g. from /etc/os-release):

/assign

repo: kserve/kserve


text:
upgrade vllm/transformers version

Upgrade vllm and transformers version to support latest models

/approve

authors: johnugeorge yuzisun


text:
Fix LocalModelCache controller reconciles deleted resource

What this PR does / why we need it:

Fixes LocalModeCachel controller reconciles deleted resource.

~Fixes flaky localmodel test~ (Addressed in #4105)

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Type of changes
Please delete options that are not relevant.

[x] Bug fix (non-breaking change which fixes an issue)

Release note:

NONE

Re-running failed tests

/rerun-all - rerun all failed workflows.
/rerun-workflow <workflow name> - rerun a specific failed workflow. Only one workflow name can be specified. Multiple /rerun-workflow commands are allowed per comment.

/lgtm
/approve


text:
InferenceService scale to zero

Hi, is it possibile to dynamically unload an InferenceService (so a ML model) from a ServingRuntime if no traffic is received?
Basically to unload the GPU when there are no incoming requests for a specific InferenceService and then reload it on the GPU when requests start arriving again.
I don't know if it's the right place to look into, but from this page https://kserve.github.io/website/0.10/modelserving/autoscaling/autoscaling/#create-inferenceservice seems that the InferenceService CRD can scale automatically to zero by setting minReplicas: 0 under spec.predictor in the YAML definition.
Is it possible? If so, do we need KNative to enable the zero-scaling behaviour or the standalone KServe ModelMesh Serving is enough?
Thanks in advance

@andreapairon -- did you already take a look at question/issue #353 ?

@ckadner just saw. Yeah, my question is basically the same as the issue you linked

authors: andreapairon ckadner

repo: kserve/modelmesh-serving


text:
DADATA - added country and region ISO code properties

Just for your information. This was created from master and merged to master. This doesn't affect to v1.1.*. To have it there, changes should be applied to 1.1 branch.

I have prepared a request to merge the branches according to your recommendations.

Thanks!

v1.1.17

authors: AndreyProkofyev kstkn

repo: kstkn/dadata


text:
Append function

Can I somehow write a function "append" that takes a random tuple and appends something to it?
Example:
append([1,'2',3], true) // should be [1,'2',3,true]
append([], 1) // should be [1]

I have tried something like this:
function append<A extends any[], V>(a: A, v: V): Append<A, V>;

but I keep receiving "Infinite Tuple" Error.
I was wondering if you could help me.

You should try Prepend

Ignore my idiotic comment above.
I discovered that ts-toolbelt works just fine.

authors: KSXGitHub SadTomato

repo: ksxnodemodules/typescript-tuple


text:
[BUG] VMI measurements are not collected if the VMI template does not include any labels

Bug Description
If the VMI template does not include any labels, VMI measurements are not collected
Output of kube-burner version
Version: 1.10.9
Git Commit: 14132166a0f6c276454a529cabfbf5b0ad36720a
Build Date: 2024-10-16T11:09:49Z
Go Version: go1.21.13
OS/Arch: darwin arm64
Describe the bug
If the VMI template does not include any labels, VMI measurements are not collected
To Reproduce
Steps to reproduce the behavior:

Use kube-burner to create a VM without setting any labels in the VMI template object
Make sure to add vmiLatency messurement

Expected behavior
VMI measurements exist
Screenshots or output
No VMI measurements

ok, so the issue is that the injected runid label from the vmi is not being copied to the vm object, correct?

ok, so the issue is that the injected runid label from the vmi is not being copied to the child vm object, correct?

Yes (along with the rest of the labels)

repo: kube-burner/kube-burner


text:
OpenCost dependency is old

https://github.com/kubecost/kubectl-cost/blob/main/go.mod#L9
I bring this up because 1.108 had a substantial refactor and we probably can't just bump up the version to the latest

Good point! kubectl-cost should only depend on opencost/core, so we'll have to update some imports but we'll likely benefit from a reduced dependency footprint.

authors: mattray michaelmdresser

repo: kubecost/kubectl-cost


text:
remove controllers/cache/suite_test.go

Ⅰ. Describe what this PR does
fix the master branch test failure. This test file is not much useful, so remove it
II. Does this pull request fix one issue?

III. Special notes for reviewers if any.

Codecov Report

Merging #213 (c5b5830) into master (fd31820) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #213   +/-   ##
=======================================
  Coverage   23.74%   23.74%
=======================================
  Files          78       78
  Lines        4764     4764
=======================================
  Hits         1131     1131
  Misses       3480     3480
  Partials      153      153

Flag
Coverage Δ

unittests
23.74% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd31820...c5b5830. Read the comment docs.

authors: codecov-commenter jian-he

repo: kubedl-io/kubedl


text:
argo-workflows logs are not displayed in ui

Which version of kubefirst are you using?
v2.3.5
Which cloud provider?
Civo
Which DNS?
Cloud ones (default)
Which installation type?
UI (Console app)
Which distributed Git provider?
GitHub
Did you use a fork of gitops-template?
No
Which Operating System?
macOS
What is the issue?
the rbac rules for argo-workflows are such that logs stream fine through github or gitlab, but as a logged in user trying to get logs through the argo workflows ui, you only receive a blank page.
logs from argo workflows should be accessible to vault users.
Code of Conduct

[X] I agree to follow this project's Code of Conduct

this fixed will be included in 2.3.6

repo: kubefirst/kubefirst


text:
AWS - Github TF not following install Region

Overview
cat ~/.aws/config

If is missing the region:
[profile starter]
region = us-east-1

Then the install will generate the following error:
LOG: 2022/12/12 16:10:56.219660 /home/developer/app/pkg/shell.go:64: OUT:  If you ever set or change modules or backend configuration for Terraform,
LOG: 2022/12/12 16:10:56.220095 /home/developer/app/pkg/shell.go:64: OUT:  rerun this command to reinitialize your working directory. If you forget, other
LOG: 2022/12/12 16:10:56.220576 /home/developer/app/pkg/shell.go:64: OUT:  commands will detect it and remind you to do so if necessary.
LOG: 2022/12/12 16:10:56.221772 /home/developer/app/pkg/shell.go:35: INFO: Running /home/developer/.k1/tools/terraform
LOG: 2022/12/12 16:10:56.223084 /home/developer/app/pkg/shell.go:39:  export AWS_SDK_LOAD_CONFIG = *
LOG: 2022/12/12 16:10:56.223655 /home/developer/app/pkg/shell.go:39:  export AWS_PROFILE = *******
LOG: 2022/12/12 16:10:56.224172 /home/developer/app/pkg/shell.go:39:  export GITHUB_TOKEN = ****************************************
LOG: 2022/12/12 16:10:56.224578 /home/developer/app/pkg/shell.go:39:  export GITHUB_OWNER = **************
LOG: 2022/12/12 16:10:56.225158 /home/developer/app/pkg/shell.go:39:  export TF_VAR_atlantis_repo_webhook_secret = ********************
LOG: 2022/12/12 16:10:56.225661 /home/developer/app/pkg/shell.go:39:  export TF_VAR_kubefirst_bot_ssh_public_key = *********************************************************************************
LOG: 2022/12/12 16:11:02.528185 /home/developer/app/pkg/shell.go:70: ERR:  ╷
LOG: 2022/12/12 16:11:02.530531 /home/developer/app/pkg/shell.go:70: ERR:  │ Error: Invalid provider configuration
LOG: 2022/12/12 16:11:02.531286 /home/developer/app/pkg/shell.go:70: ERR:  │
LOG: 2022/12/12 16:11:02.531837 /home/developer/app/pkg/shell.go:70: ERR:  │ Provider "registry.terraform.io/hashicorp/aws" requires explicit
LOG: 2022/12/12 16:11:02.532373 /home/developer/app/pkg/shell.go:70: ERR:  │ configuration. Add a provider block to the root module and configure the
LOG: 2022/12/12 16:11:02.532893 /home/developer/app/pkg/shell.go:70: ERR:  │ provider's required arguments as described in the provider documentation.
LOG: 2022/12/12 16:11:02.533497 /home/developer/app/pkg/shell.go:70: ERR:  │
LOG: 2022/12/12 16:11:02.533930 /home/developer/app/pkg/shell.go:70: ERR:  ╵
LOG: 2022/12/12 16:11:02.534371 /home/developer/app/pkg/shell.go:70: ERR:  ╷
LOG: 2022/12/12 16:11:02.534752 /home/developer/app/pkg/shell.go:70: ERR:  │ Error: configuring Terraform AWS Provider: error validating provider credentials: error calling sts:GetCallerIdentity: operation error STS: GetCallerIdentity, failed to resolve service endpoint, an AWS region is required, but was not found
LOG: 2022/12/12 16:11:02.535222 /home/developer/app/pkg/shell.go:70: ERR:  │
LOG: 2022/12/12 16:11:02.535836 /home/developer/app/pkg/shell.go:70: ERR:  │   with provider["registry.terraform.io/hashicorp/aws"],
LOG: 2022/12/12 16:11:02.536390 /home/developer/app/pkg/shell.go:70: ERR:  │   on <empty> line 0:
LOG: 2022/12/12 16:11:02.536972 /home/developer/app/pkg/shell.go:70: ERR:  │   (source code not available)
LOG: 2022/12/12 16:11:02.537376 /home/developer/app/pkg/shell.go:70: ERR:  │
LOG: 2022/12/12 16:11:02.537895 /home/developer/app/pkg/shell.go:70: ERR:  ╵
LOG: 2022/12/12 16:11:02.572220 /home/developer/app/pkg/shell.go:77: error: /home/developer/.k1/tools/terraform failed exit status 1
LOG: 2022/12/12 16:11:02.573068 /home/developer/app/internal/github/github.go:47: error: terraform apply for github failed exit status 1
LOG: 2022/12/12 16:11:02.573834 /home/developer/app/cmd/create.go:41: [000] Create duration is 20.495873799s

Meaning that the region provided by the installer is ignored by this terraform.

Source:
LOG: 2022/12/12 16:12:46.303003 /home/developer/app/cmd/githubAdd.go:33: Org used: org-demo-6za-2
LOG: 2022/12/12 16:12:46.303462 /home/developer/app/cmd/githubAdd.go:34: dry-run: false
LOG: 2022/12/12 16:12:46.304104 /home/developer/app/cmd/createUtils.go:299: Creating gitops repository with terraform in GitHub
LOG: 2022/12/12 16:12:46.304777 /home/developer/app/internal/github/github.go:18: Executing ApplyGithubTerraform
LOG: 2022/12/12 16:12:46.305361 /home/developer/app/pkg/shell.go:35: INFO: Running /home/developer/.k1/tools/terraform
LOG: 2022/12/12 16:12:46.305808 /home/developer/app/pkg/shell.go:39:  export AWS_SDK_LOAD_CONFIG = *
LOG: 2022/12/12 16:12:46.306385 /home/developer/app/pkg/shell.go:39:  export AWS_PROFILE = *******
LOG: 2022/12/12 16:12:46.306845 /home/developer/app/pkg/shell.go:39:  export GITHUB_TOKEN = ****************************************
LOG: 2022/12/12 16:12:46.307299 /home/developer/app/pkg/shell.go:39:  export GITHUB_OWNER = **************
LOG: 2022/12/12 16:12:46.307710 /home/developer/app/pkg/shell.go:39:  export TF_VAR_atlantis_repo_webhook_secret = ********************
LOG: 2022/12/12 16:12:46.308164 /home/developer/app/pkg/shell.go:39:  export TF_VAR_kubefirst_bot_ssh_public_key = *********************************************************************************

Code impacted:
https://github.com/kubefirst/kubefirst/blob/main/internal/github/github.go

We need to double-check if this issue still in play, if yes to fix it.


text:
Endpoint is not available after deployment

Behavior: endpoint is not available after deployment
Cause: for time to time iap-enabler,  backend-updater, and cloud-endpoints-enabler workloads fail to finish IAP setup due wrong timing.

Fixed in v1.6.0

repo: kubeflow/gcp-blueprints


text:
Document how to use STORAGE_URI especially in case of custom framework

/kind feature
Describe the solution you'd like
Describe how to use STORAGE_URI environment variable in InferenceService schema with custom framework.
It could be added in space: kfserving/docs/samples/custom/
This feature is not documented. I would like to know if this feature is official and if it is expected to be available in the future.
Anything else you would like to add:
Important information about feature:

container schema can have STORAGE_URI environment variable,when used in InferenceService, it provides standard storage-initializer functionality.
container name has to be : kfserving-container.
The storage mounts to /mnt/models.

This feature can be very beneficial if someone needs to create a custom docker image with specific dependencies. There was a case in my organization where the serialized model had such dependencies that it was impossible to extract them into a transformer.
STORAGE_URI feature basic locations:
https://github.com/kubeflow/kfserving/blob/master/pkg/apis/serving/v1alpha2/framework_custom.go#L30
https://github.com/kubeflow/kfserving/blob/master/pkg/apis/serving/v1beta1/predictor_custom.go#L57
other examples where STORAGE_URI is used:
https://github.com/kubeflow/kfserving/blob/master/docs/samples/custom/torchserve/torchserve-custom-pv.yaml
https://github.com/kubeflow/kfserving/blob/master/docs/samples/custom/torchserve/bert-sample/bert.yaml
https://github.com/kubeflow/kfserving/tree/master/docs/samples/v1alpha2/triton/bert
I'd like to offer my help, but first I need some initial answer and maybe some instructions.

@marcinkosztolowicz I wanted to know if there is any way to use STORAGE_URI which supports cloud storage just like sklearn and PyTorch model? Currently, I am using custom torchserve for more GPU utilization but I am not able to figure out how to use STORAGE_URI.

@iavinas I believe the answer is yes, it is possible to use cloud storage with STORAGE_URI. I am using it with aws S3. I have only used sklearn so far, then I do not know torchserve specific. Nevertheless I think both sklearn and torchserve should be similar, when it comes to using of STORAGE_URI.
Could you elaborate more about what is your problem. Probably InferenceService manifest would be helpfull

@marcinkosztolowicz sorry for the late reply, it would be great to document this. I think what you described is pretty accurate, thanks a lot!

Hi @marcinkosztolowicz @yuzisun , so after adding STORAGE_URI, are the models available in "/mnt/models"? Or how could I access it from a class extending KFServe.KFModel like this one: https://github.com/kserve/kserve/blob/master/docs/samples/v1alpha2/custom/kfserving-custom-model/model-server/model.py

@juangon
Yes that's right.
The following model would be available at /mnt/models/model.lgb
env:
    - name: STORAGE_URI
      value: "https://aisp.navercorp.com/files/model.lgb"

authors: iavinas juangon marcinkosztolowicz markwinter yuzisun

repo: kubeflow/kfserving


text:
Tensorflow example not working

/kind bug
What steps did you take and what happened:
[A clear and concise description of what the bug is.]
I tried to apply the config described in https://github.com/kubeflow/kfserving/tree/master/docs/samples/tensorflow
So I tried this config:
apiVersion: "serving.kubeflow.org/v1alpha2"
kind: "InferenceService"
metadata:
  name: "flowers-sample"
spec:
  default:
    predictor:
      tensorflow:
        storageUri: "gs://kfserving-samples/models/tensorflow/flowers"

And running kubectl apply -f tensorflow.yaml
When running kubectl get inferenceservice I get:
$ kubectl get inferenceservice
NAME                   URL   READY   DEFAULT TRAFFIC   CANARY TRAFFIC   AGE
flowers-sample               False                                      61s

I'm getting this when running kubectl get all
service.serving.knative.dev/power-price-forecast-predictor-default   http://power-price-forecast-predictor-default.kubeflow.example.com   power-price-forecast-predictor-default-89gcr                 Unknown   RevisionMissing

This URL is not going to work so how can I change it to something that will?
What did you expect to happen:
Get a working endpoint to access over HTTP.
When I run
MODEL_NAME=flowers-sample
INPUT_PATH=@./input.json
CLUSTER_IP=$(kubectl -n istio-system get service istio-ingressgateway -o jsonpath='{.status.loadBalancer.ingress[0].ip}')
SERVICE_HOSTNAME=$(kubectl get inferenceservice ${MODEL_NAME} -o jsonpath='{.status.url}' | cut -d "/" -f 3)

curl -v -H "Host: ${SERVICE_HOSTNAME}" http://$CLUSTER_IP/v1/models/$MODEL_NAME:predict -d $INPUT_PATH

Both CLUSTER_IP and SERVICE_HOSTNAME are empty.
Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]
Environment:
(How do I get these versions?)

Istio Version:
Knative Version:
KFServing Version:
Kubeflow version:
Minikube version:
Kubernetes version: (use kubectl version):
Client Version: version.Info{Major:"1", Minor:"14+", GitVersion:"v1.14.10-dispatcher", GitCommit:"f5757a1dee5a89cc5e29cd7159076648bf21a02b", GitTreeState:"clean", BuildDate:"2020-02-06T03:29:33Z", GoVersion:"go1.12.12b4", Compiler:"gc", Platform:"linux/amd64"} Server Version: version.Info{Major:"1", Minor:"14+", GitVersion:"v1.14.8-gke.33", GitCommit:"2c6d0ee462cee7609113bf9e175c107599d5213f", GitTreeState:"clean", BuildDate:"2020-01-15T17:47:46Z", GoVersion:"go1.12.11b4", Compiler:"gc", Platform:"linux/amd64"}
OS (e.g. from /etc/os-release): Arch Linux

@Anderssorby can you get more detailed output with following command ?
Kubectl get ksvc power-price-forecast-predictor -oyaml

Here:
apiVersion: serving.knative.dev/v1alpha1
kind: Service
metadata:
  annotations:
    serving.knative.dev/creator: system:serviceaccount:kubeflow:default
    serving.knative.dev/lastModifier: system:serviceaccount:kubeflow:default
  creationTimestamp: "2020-02-21T10:16:22Z"
  generation: 1
  name: power-price-forecast-predictor-default
  namespace: kubeflow
  ownerReferences:
  - apiVersion: serving.kubeflow.org/v1alpha2
    blockOwnerDeletion: true
    controller: true
    kind: InferenceService
    name: power-price-forecast
    uid: 3597ddbb-5493-11ea-a0c3-42010af00141
  resourceVersion: "586104"
  selfLink: /apis/serving.knative.dev/v1alpha1/namespaces/kubeflow/services/power-price-forecast-predictor-default
  uid: 359a0127-5493-11ea-a0c3-42010af00141
spec:
  template:
    metadata:
      annotations:
        autoscaling.knative.dev/class: kpa.autoscaling.knative.dev
        autoscaling.knative.dev/target: "1"
        internal.serving.kubeflow.org/storage-initializer-sourceuri: gs://flex-ml-models/test.pb
        queue.sidecar.serving.knative.dev/resourcePercentage: "0.2"
      creationTimestamp: null
      labels:
        serving.kubeflow.org/inferenceservice: power-price-forecast
    spec:
      containers:
      - args:
        - --port=9000
        - --rest_api_port=8080
        - --model_name=power-price-forecast
        - --model_base_path=/mnt/models
        command:
        - /usr/bin/tensorflow_model_server
        image: 'tensorflow/serving:'
        name: kfserving-container
        readinessProbe:
          successThreshold: 1
          tcpSocket:
            port: 0
        resources: {}
      timeoutSeconds: 60
  traffic:
  - latestRevision: true
    percent: 100
status:
  conditions:
  - lastTransitionTime: "2020-02-21T10:16:22Z"
    status: Unknown
    type: ConfigurationsReady
  - lastTransitionTime: "2020-02-21T10:16:22Z"
    message: Configuration "power-price-forecast-predictor-default" is waiting for
      a Revision to become ready.
    reason: RevisionMissing
    status: Unknown
    type: Ready
  - lastTransitionTime: "2020-02-21T10:16:22Z"
    message: Configuration "power-price-forecast-predictor-default" is waiting for
      a Revision to become ready.
    reason: RevisionMissing
    status: Unknown
    type: RoutesReady
  latestCreatedRevisionName: power-price-forecast-predictor-default-qfhwj
  observedGeneration: 1
  url: http://power-price-forecast-predictor-default.kubeflow.example.com

I got more hang of it now and I got it working with Tensorflow Serving. Possibly coming back to this project later though.

@Anderssorby I noticed that you deployed the service to kubeflow namespace, that won’t work because it is system namespace and service deployed there does not call  kfserving pod mutator. If you deploy to default namespace or other user namespaces that should work.

/close
Please check docs here https://github.com/kubeflow/kfserving/blob/master/README.md#kfserving-in-kubeflow-installation.

authors: Anderssorby yuzisun


text:
TfJobs dashboard doesn't work with K8s API server proxy or envoy proxy

I have the dashboard running and tried accessing it over the K8s API server proxy. For a brief second I see the dashboard but then I just get a grey screen.
When I connect via kubectl port-forward to the pod it works.
is this expected?

What does the Ambassador annotation added for this service look like?

This is the generated TFJob service YAML:
apiVersion: v1
kind: Service
metadata:
  annotations:
    getambassador.io/config: |-
      ---
      apiVersion: ambassador/v0
      kind:  Mapping
      name: tfjobs-ui-mapping
      prefix: /tfjobs/ui/
      rewrite: /
      service: tf-job-dashboard.kubeflow
  name: tf-job-dashboard
  namespace: kubeflow
spec:
  ports:
  - port: 80
    targetPort: 8080
  selector:
    name: tf-job-dashboard
  type: ClusterIP

If I'm reading things correctly in the report above, then switching the annotation to use rewrite: /tfjobs/ui seems like it should probably fix the issue.

Let me try it out. Thank you for your comments @kflynn.

Mea culpa -- left out a /:
rewrite: /tfjobs/ui/

Ah I made the same mistake, last time as well.
This is the corrected service YAML:
apiVersion: v1
kind: Service
metadata:
  annotations:
    getambassador.io/config: |-
      ---
      apiVersion: ambassador/v0
      kind:  Mapping
      name: tfjobs-ui-mapping
      prefix: /tfjobs/ui/
      rewrite: /tfjobs/ui/
      service: tf-job-dashboard.kubeflow
  creationTimestamp: 2018-02-22T21:05:18Z
  name: tf-job-dashboard
  namespace: kubeflow
  resourceVersion: "3670"
  selfLink: /api/v1/namespaces/kubeflow/services/tf-job-dashboard
  uid: 163eda24-1814-11e8-9a3c-025000000001
spec:
  clusterIP: 10.107.237.136
  ports:
  - port: 80
    protocol: TCP
    targetPort: 8080
  selector:
    name: tf-job-dashboard
  sessionAffinity: None
  type: ClusterIP
status:
  loadBalancer: {}

This is the curl output:
$ curl -v http://localhost:8080/tfjobs/ui/
$ curl -v http://localhost:8080/tfjobs/ui/
*   Trying ::1...
* TCP_NODELAY set
* Connection failed
* connect to ::1 port 8080 failed: Connection refused
*   Trying 127.0.0.1...
* TCP_NODELAY set
* Connected to localhost (127.0.0.1) port 8080 (#0)
> GET /tfjobs/ui/ HTTP/1.1
> Host: localhost:8080
> User-Agent: curl/7.54.0
> Accept: */*
>
< HTTP/1.1 404 Not Found
< content-type: text/plain; charset=utf-8
< x-content-type-options: nosniff
< date: Thu, 22 Feb 2018 21:36:29 GMT
< content-length: 19
< x-envoy-upstream-service-time: 5
< server: envoy
<
404 page not found
* Connection #0 to host localhost left intact

This is where I suggest dropping into the Ambassador Gitter channel so we can get this sorted out. :)

Sure thing 👍

To summarize the conversation from the Ambassador Gitter channel: I misunderstood what @jlewi said a month ago about where the application was expecting to be rooted vs where the Ambassador Mapping was ing to root it. Oops.
Given that the application thinks it's rooted at /, and that it uses absolute paths without any capability for configuration, pretty much the only way to do this is with an Ambassador Mapping that specifies
prefix: /
rewrite: /

If this is the only such application that needs to live behind this Ambassador, that should be enough -- Ambassador knows how to sort Mappings such that very broad matches come later for exactly this reason.
If this is not the only such application, you'll need another constraint in the Mapping. The simplest thing to do is probably to add host, so that only requests to a particular domain name will match (we use this a lot at Datawire, actually).

Just a thought. We could change the dashboard service slightly.
This is from https://github.com/kubeflow/tf-operator/blob/master/dashboard/backend/main.go
Current:
p := ":8080"
log.Println("Listening on", p)
http.ListenAndServe(p, nil)

Proposed change:
p := ":8080"
log.Println("Listening on", p+"/tfjobs/ui/")
http.ListenAndServe(p+"/tfjobs/ui/", nil)

And then the ambassador service annotation to be,
prefix: /tfjobs/ui/
rewrite: /tfjobs/ui/

Would this be a viable solution? I don't know about the ramifications of this change.
cc/ @Jimexist @wbuchwalter @jlewi

@swiftdiaries I don't see any issue with your approach, however this would need a bit of testing.
@kflynn

Given that the application thinks it's rooted at /, and that it uses absolute paths without any capability for configuration

I haven't been very active as I am finishing a round of non-stop travel for work, but if you think this issue can be more cleanly solved by modifying the front-end let me know and I will try to find some time to do that.

@swiftdiaries per @kflynn's comment above
Given that the application thinks it's rooted at /

Can we fix the APP (its our code :)) so it will use the correct root?
I believe we want to configure Ambassador using
prefix: /tf-jobs/ui/
rewrite: /tf-jobs/ui/

If we do this then I'd expect the request that hits the UI has in it somewhere the URL
https://my-domain/tf-jobs/ui/

So we'd like the UI to use https://my-domain/tf-jobs/ui/ as the root for the application and then all paths like "main.e7655508.js" should be computed in terms of that root.
So can we update our REACT app to correctly compute the ROOT and then use that as a prefix for URLs?

I'll take a look at this.

try adding homepage to package.json in tf-operator/dashboard/frontend
{
  "name": "tensorflowk8s-dashboard",
  "version": "0.1.0",
  "description": "Dashboard for kubeflow/tf-operator.",
  "private": true,
  "homepage": ".",
  "dependencies": {

See https://github.com/facebook/create-react-app/issues/527 and https://github.com/facebook/create-react-app/blob/master/packages/react-scripts/template/README.md#building-for-relative-paths

authors: jlewi kflynn kkasravi swiftdiaries wbuchwalter

repo: kubeflow/tf-operator


text:
error with kubeflow instalation

im installing toolkit for begin in kubernetes and with command "kubeflow-tools/install-kubeflow.sh"
i cant done the installation, this is the issue

'[' 0 -eq 0 ']'
echo 'namespace kubeflow already exists'
namespace kubeflow already exists
set +e
++ ks env describe default
O='name: default
kubernetesversion: v1.14.1
path: default
destination:
server: https://127.0.0.1:16443
namespace: kubeflow
targets: []
libraries: {}'
RESULT=0
set -e
'[' 0 -eq 0 ']'
echo 'environment default already exists'
environment default already exists
ks apply default -c ambassador
ERROR handle object: patching object from cluster: merging object with existing state: Get https://direction _ip /api/v1/namespaces/kubeflow/services/ambassador: net/http: TLS handshake timeout

i hope you can help me!!

It seems that your problem is about kubeflow, not tf-operator. Maybe asking in kubeflow/kubeflow is better.

I am closing the issue since it is stale

authors: gaocegege luistrange


text:
fix https://github.com/kubeflow/training-operator/issues/1704

Which issue(s) this PR fixes : Fixes https://github.com/kubeflow/training-operator/issues/1704
Checklist:

[ ] Docs included if any changes are user facing

And I found the event reason constant is a little "messy", so I use string literal but I am waiting to rebase my codes

@HeGaoYuan Can you sign the CLA?

@johnugeorge what is your suggestion about event reason constant.
I found the event reason constant is a little "messy". I am sorry that I am a code clean freak.
https://github.com/kubeflow/training-operator/blob/69813fbc37f33857e59044d14caa7e2765851d98/pkg/controller.v1/pytorch/pytorchjob_controller.go#L399
https://github.com/kubeflow/training-operator/blob/69813fbc37f33857e59044d14caa7e2765851d98/pkg/controller.v1/tensorflow/tfjob_controller.go#L489

Pull Request Test Coverage Report for Build 3763236896

0 of 17 (0.0%)  changed or added relevant lines in 6 files are covered.
10 unchanged lines in 6 files lost coverage.
Overall coverage decreased (-0.005%) to 39.184%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

pkg/controller.v1/mpi/mpijob_controller.go
0
2
0.0%

pkg/controller.v1/mxnet/mxjob_controller.go
0
3
0.0%

pkg/controller.v1/paddlepaddle/paddlepaddle_controller.go
0
3
0.0%

pkg/controller.v1/pytorch/pytorchjob_controller.go
0
3
0.0%

pkg/controller.v1/tensorflow/tfjob_controller.go
0
3
0.0%

pkg/controller.v1/xgboost/xgboostjob_controller.go
0
3
0.0%

Files with Coverage Reduction
New Missed Lines
%

pkg/controller.v1/mxnet/mxjob_controller.go
1
0%

pkg/controller.v1/pytorch/pytorchjob_controller.go
1
59.1%

pkg/controller.v1/tensorflow/tfjob_controller.go
1
70.48%

pkg/controller.v1/xgboost/xgboostjob_controller.go
1
0%

pkg/controller.v1/mpi/mpijob_controller.go
2
76.89%

pkg/controller.v1/paddlepaddle/paddlepaddle_controller.go
4
56.84%

Totals

Change from base Build 3759228064:
-0.005%

Covered Lines:
2661

Relevant Lines:
6791

💛  - Coveralls

One problem that i see is, If we return error after validation failure, the job will be still reconciled again and again. Should we mark job as failed?
/cc @gaocegege

/cc @tenzen-y

One problem that i see is, If we return error after validation failure, the job will be still reconciled continuously though not recoverable. Should we mark job as failed?
/cc @gaocegege

Yes, I also notice this problem. If you want to mark the job as failed, it is like about the problem I said "state transition table". As I said now the "state transition table" is now clear, so we should be careful to add new "state transition". Reconciled continuously is common and not a big problem? We can decide it later when we conclude the "state transition table"?

Can we create an issue to track?  The validation failure is non recoverable error and I don't see any value in wasting resources to do continuous reconciliation.  We may track it in a different PR. Others, thoughts ?
/cc @kubeflow/wg-training-leads @kubeflow/common-team

One problem that i see is, If we return error after validation failure, the job will be still reconciled continuously though not recoverable. Should we mark job as failed?
/cc @gaocegege

@johnugeorge Does that mean, in the following validation step, the training-operator should mark Failed to JobCondition if validations failed and then if JobCondiction is Failed, skip reconciling CustomJob (e.g. TFJob)?
https://github.com/kubeflow/training-operator/blob/69813fbc37f33857e59044d14caa7e2765851d98/pkg/controller.v1/tensorflow/tfjob_controller.go#L155-L157

@johnugeorge what is your suggestion about event reason constant.
I found the event reason constant is a little "messy". I am sorry that I am a code clean freak.
https://github.com/kubeflow/training-operator/blob/69813fbc37f33857e59044d14caa7e2765851d98/pkg/controller.v1/pytorch/pytorchjob_controller.go#L399
https://github.com/kubeflow/training-operator/blob/69813fbc37f33857e59044d14caa7e2765851d98/pkg/controller.v1/tensorflow/tfjob_controller.go#L489

Some inconsistencies happened because  operators from multiple repos were merged into training operator couple of releases ago.  we can use commonutil.JobSucceededReason

@johnugeorge what is your suggestion about event reason constant.
I found the event reason constant is a little "messy". I am sorry that I am a code clean freak.
https://github.com/kubeflow/training-operator/blob/69813fbc37f33857e59044d14caa7e2765851d98/pkg/controller.v1/pytorch/pytorchjob_controller.go#L399
https://github.com/kubeflow/training-operator/blob/69813fbc37f33857e59044d14caa7e2765851d98/pkg/controller.v1/tensorflow/tfjob_controller.go#L489

Some inconsistencies happened because operators from multiple repos were merged into training operator couple of releases ago. we can use commonutil.JobSucceededReason

I see. I agree with using commonutil.JobSucceededReason. We might need to do refactoring across controllers.

One problem that i see is, If we return error after validation failure, the job will be still reconciled continuously though not recoverable. Should we mark job as failed?
/cc @gaocegege

@johnugeorge Does that mean, in the following validation step, the training-operator should mark Failed to JobCondition if validations failed and then if JobCondiction is Failed, skip reconciling CustomJob (e.g. TFJob)?
https://github.com/kubeflow/training-operator/blob/69813fbc37f33857e59044d14caa7e2765851d98/pkg/controller.v1/tensorflow/tfjob_controller.go#L155-L157

I am thinking so. Is there a better solution without a webhook?

A possible another solution is not return ctrl.Result{}, err but return ctrl.Result{}, nil after validate fails. Then controller-runtime will not reconciled continuously.

A possible another solution is not return ctrl.Result{}, err but return ctrl.Result{}, nil after validate fails. Then controller-runtime will not reconciled continuously. @johnugeorge @tenzen-y

Yeah. I referred to that earlier. We should do that as this error is non recoverable anyways

@johnugeorge what is your suggestion about event reason constant.
I found the event reason constant is a little "messy". I am sorry that I am a code clean freak.
https://github.com/kubeflow/training-operator/blob/69813fbc37f33857e59044d14caa7e2765851d98/pkg/controller.v1/pytorch/pytorchjob_controller.go#L399
https://github.com/kubeflow/training-operator/blob/69813fbc37f33857e59044d14caa7e2765851d98/pkg/controller.v1/tensorflow/tfjob_controller.go#L489

Some inconsistencies happened because operators from multiple repos were merged into training operator couple of releases ago. we can use commonutil.JobSucceededReason

I see. I agree with using commonutil.JobSucceededReason. We might need to do refactoring across controllers.

If you recomment to use commonutil.JobSucceededReason, then I need to open a PR in kubeflow/common to add a JobFailedValidation reason constant. @johnugeorge @tenzen-y

One problem that i see is, If we return error after validation failure, the job will be still reconciled continuously though not recoverable. Should we mark job as failed?
/cc @gaocegege

@johnugeorge Does that mean, in the following validation step, the training-operator should mark Failed to JobCondition if validations failed and then if JobCondiction is Failed, skip reconciling CustomJob (e.g. TFJob)?
https://github.com/kubeflow/training-operator/blob/69813fbc37f33857e59044d14caa7e2765851d98/pkg/controller.v1/tensorflow/tfjob_controller.go#L155-L157

If we don't return error for ValidationError , reconciliation won't happen again. Is there a better solution?

@johnugeorge Another better option; if a validation error occurs, add a special annotation to the target CRD (e.g. TFJob) then run return ctrl.Result{}, err. And watcher rejects (use predicators) to enqueue CRDs with the special annotation to the workqueue.
https://github.com/kubeflow/training-operator/blob/69813fbc37f33857e59044d14caa7e2765851d98/pkg/controller.v1/tensorflow/tfjob_controller.go#L206-L211

One problem that i see is, If we return error after validation failure, the job will be still reconciled continuously though not recoverable. Should we mark job as failed?
/cc @gaocegege

@johnugeorge Does that mean, in the following validation step, the training-operator should mark Failed to JobCondition if validations failed and then if JobCondiction is Failed, skip reconciling CustomJob (e.g. TFJob)?
https://github.com/kubeflow/training-operator/blob/69813fbc37f33857e59044d14caa7e2765851d98/pkg/controller.v1/tensorflow/tfjob_controller.go#L155-L157

If we don't return error for ValidationError , reconciliation won't happen again. Is there a better solution?

@johnugeorge Another better option; if a validation error occurs, add a special annotation to the target CRD (e.g. TFJob) then run return ctrl.Result{}, err. And watcher rejects (use predicators) to enqueue CRDs with the special annotation to the workqueue.
https://github.com/kubeflow/training-operator/blob/69813fbc37f33857e59044d14caa7e2765851d98/pkg/controller.v1/tensorflow/tfjob_controller.go#L206-L211

A little complex 😂.
Imaging this situation,  users will find their Job spec has problem, then they are going to fix it. They need to know the annotion and remove the annotation, or our codes should add additional logic.

If you recomment to use commonutil.JobSucceededReason, then I need to open a PR in kubeflow/common to add a JobFailedValidation reason constant. @johnugeorge @tenzen-y

@HeGaoYuan  For now, we can go ahead by adding a new constant in kubeflow/common and then get this PR merged. We will do further cleanup post 1.6 release after merging kubeflow/common as described in https://github.com/kubeflow/training-operator/issues/1714#issuecomment-1374537434

If you recomment to use commonutil.JobSucceededReason, then I need to open a PR in kubeflow/common to add a JobFailedValidation reason constant. @johnugeorge @tenzen-y

@HeGaoYuan For now, we can go ahead by adding a new constant in kubeflow/common and then get this PR merged. We will do further cleanup post 1.6 release after merging kubeflow/common as described in #1714 (comment)

I got it

@HeGaoYuan Can you update it?

A possible another solution is not return ctrl.Result{}, err but return ctrl.Result{}, nil after validate fails. Then controller-runtime will not reconciled continuously. @johnugeorge @tenzen-y

@johnugeorge Yes, I can update. But then how about this? Should I keep return ctrl.Result{}, err or change to return ctrl.Result{}, nil

I would recommend to update the PR to use  JobFailedValidationReason https://github.com/kubeflow/common/blob/9ec55d141f90faaf52fd6df271e987e5a6781945/pkg/util/status.go#L21  and keep return ctrl.Result{}, err (as in the  current PR)
In the next release, we can discuss and implement the state change in #1711

@HeGaoYuan We are creating a release tomorrow. Can you update this PR and rebase ?

I would recommend to update the PR to use JobFailedValidationReason https://github.com/kubeflow/common/blob/9ec55d141f90faaf52fd6df271e987e5a6781945/pkg/util/status.go#L21 and keep return ctrl.Result{}, err (as in the current PR) so as to remain consistent with all controllers.
In the next release, we can discuss and implement the state change in #1711
/cc @tenzen-y What do you think?

Sorry for the late response. I was missing the notification.
That makes sense. It would be better to discuss that after the next release since we should handle the behavior of Job conditions, carefully.
So, it would be better to change only an error reason.

@johnugeorge Would you like to take over this PR before we cut the new release? Or, we postpone releasing this improvement after the next release?

@johnugeorge @tenzen-y
I am so sorry for replying late, because it is Spring Festival recently.
I have updated it by merge master branch.

@tenzen-y Have you noticed that tests are really flaky now?

@tenzen-y Have you noticed that tests are really flaky now?

Is it E2E?

Thanks @HeGaoYuan
/approve

@tenzen-y Have you noticed that tests are really flaky now?

Is it E2E?

There are e2e failures. Also, Publish Images workflows take longer time

@johnugeorge I don't think these changes caused these flaky tests.

There are e2e failures

As I can see, training jobs sometimes fail... We might need to improve sample training codes.

Publish Images workflows take longer time

I guess building jobs have taken longer times since #1692.

authors: HeGaoYuan coveralls johnugeorge tenzen-y

repo: kubeflow/training-operator


text:
Update customizing-gke.md

Fixes #843

This change is

/assign @kkasravi

/lgtm
/approve

authors: abhi-g richardsliu

repo: kubeflow/website


text:
GHA > Publishing Output Should Include Path

The output of the action should be a mapping from a list of files/directories/inputs to a list of names/CIDs/outputs. Currently it is just the latter, which is usable but could be made moreso -- users want to know WHICH file is the CID abc123 and the name def456.

Done.


text:
More QoS features supported in NATGW

Feature request
Trying to implement more QoS features supported in NATGW.
Use case
The following QoS features will be supported:

Bandwidth rate limit for NATGW net1 NIC
Bandwidth rate limit for NATGW net1 EIP (already supported in #2496)
Bandwidth rate limit for external network traffic on NATGW net1

This is a simple test using tc tc-qos.md

repo: kubeovn/kube-ovn


text:
add argument to invert the behavior of alert-filter-regexp

Adding "--alert-filter-match-only" argument which inverts the behavior of "alert-filter-regexp". When alert-filter-match-only=true, kured will block on any active alerts that match the regexp defined in 'alert-filter-regexp'
A use case for this is:
Fire alerts if the cluster is becoming unhealthy (a % of nodes are no longer == Ready). Immediately prevent kured from continuing to drain and reboot.

@jimliming I just pushed some small code-improvements and unit-tests to simplify things and to not ignore the --alert-firing-only flag.

makes sense - good catch on alert-firing-only

authors: ckotzbauer jimliming

repo: kubereboot/kured


text:
containerd support

What feature would you like to be added?
containerd should be an option for Container Runtime as a docker replacement
What are use cases of the feature?
Lower system requirements, lower feature surface (equals to less bugs).

Any updates/planned release date? Also, will there be an ability to specify the runtime version (containerd/docker)?

repo: kubermatic/kubeone


text:
Support Debian

What feature would you like to be added?
Please support Debian stable (version 10, aka "buster").
What are use cases of the feature?
Debian is very popular on servers. It would be nice if I could stay with debian and not move to Ubuntu on my servers just for kubeone. Thanks!

As far as I know, KubeOne should work on Debian too, but we haven't tested it at all. If you're using our Terraform examples, you only need to change the operating system image to Debian one and KubeOne should work out of the box.
However, machine-controller, the component that creates and manages worker nodes, isn't supporting Debian, so you would have to use a supported OS or manage workers manually.

KubeOne should be able to use Debian out of the box, so I'm going to close this issue.
/close

authors: varac xmudrii


text:
Add email scope to GCP provided credential refresh

This would fix the issue described in: https://github.com/kubernetes-client/python-base/issues/54
This is similar to the PR to fix the issue with refreshing the service account token, except this is specifically targeted at addressing service account tokens that are authenticated using RBAC.
The issue is essentially that if the service account that is making a request to the Kubernetes API server and the request is authenticated using RBAC, then the access token will be invalid because it isn't signed by an email. By passing the "https://www.googleapis.com/auth/userinfo.email" when creating the credentials it will generate an access token that can be authenticated using RBAC.

Codecov Report

Merging #110 into master will not change coverage.
The diff coverage is 0%.

@@           Coverage Diff           @@
##           master     #110   +/-   ##
=======================================
  Coverage   92.04%   92.04%
=======================================
  Files          13       13
  Lines        1182     1182
=======================================
  Hits         1088     1088
  Misses         94       94

Impacted Files
Coverage Δ

config/kube_config.py
84.24% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c242ea...1637d56. Read the comment docs.

/lgtm

Hey there @mbohlool and @yliaog, (sorry for the ping) it's no big rush, but would you guys mind taking a look at this if you have any time soon? :)

thanks for the pr. so you have tested it manually that it works, right? just want to double confirm.

Yes, we've been running a patched version of this client with this change for the past few months in production and we haven't seen any adverse behaviour.

/lgtm
/approve

authors: axelsteingrimsson codecov-io micw523 yliaog

repo: kubernetes-client/python-base


text:
Preserve the tag of the pulled image's name

When we pull an image, preserve the tag portion of the name that we were asked to use for pulling it, instead of unconditionally replacing it with "latest".  This aims to fix #403.

LGTM

Tested on an actual k8s deployment on top of ocid, works as expected.

LGTM

Thanks for the quick fix @nalind :)

Let's follow up on my comment and get this fix in now :)

LGTM

authors: mrunalp nalind runcom sameo

repo: kubernetes-incubator/cri-o


text:
Tell oci-umount where to remove mountpoints inside container

This patch set add crio-umount.conf file which tells oci-umount plugin
to look for leaked mount points in /var/lib/containers/storage/* and
/var/run/containers/*
Signed-off-by: Daniel J Walsh dwalsh@redhat.com

This patch should not go in, until https://github.com/projectatomic/oci-umount/pull/19 is approved.

Looks fine. @rhvgoyal PTAL.

@mrunalp @runcom The oci-umount was updated, this should go into rc3.

/test all

/test all

/test e2e_rhel

/test integration_rhel

LGTM

authors: mrunalp rhatdan


text:
take record type into account when determining ELBs

when detecting the type from the hostname, we have to take the recordType into account if it's set. This allows to pres switch between CNAME and ALIAS and allows ExternalDNS to work correctly when removing one for the other. It preserves the type which is required for deleting and updating records.

LGTM

authors: ideahitme linki

repo: kubernetes-incubator/external-dns


text:
Kompose will keep trying its job

fixes #270

Please use git commit --amend as well to update your git message so it's more descriptive!

Anyway the code this PR is editing is gonna go away because @procrypt is working on new approach of deleting things! https://github.com/kubernetes-incubator/kompose/pull/483

It is not going to go away. This logic will be still needed, #483 is not solving this problem.
But it will create lot of annoying conflicts :-(

cc @kadel @surajssd @cdrage

Okay, shouldn't we use https://golang.org/pkg/go/scanner/#ErrorList instead? @kadel

It looks like that ErrorList is specially made for scanner package.

@cdrage done with changes

LGTM

I just found that there is a BIG mistake in there.
If it can't connect to cluster it panics.
Problem is that we continue after every error.
There should be return after some errors, and after every error in switch  should be break

@kadel Yeah. I thought we were brute-forcing the force down since we're iterating right through each-one of them.
I've opened up a PR to revert this so we can at least push a release today.

yeh, that was a bit  too much brute-forcing :-)
For example we can't continue and call Stop if client creation failed. In that case it should continue and try to create client again for next object.

authors: cdrage kadel surajnarwade surajssd

repo: kubernetes-incubator/kompose


text:
Gang scheduling

Signed-off-by: Da K. Ma klaus1982.cn@gmail.com

@mindprince , there's the design doc on gang-scheduling API in kube-arbitrator as we discuss before, please share your comments :)
/cc @vishh , @bsalamat

/cc @jlewi @gaocegege

Moved to https://github.com/kubernetes/community/pull/2337 for broader review :)

repo: kubernetes-incubator/kube-arbitrator


text:
Etcd Subnets not honoured on stack render.

Changes

etcd subnets are not respected when generating a new etcd stack, this ensures we at least look at the declared etcd subnets and try to match them up.

Resolves #1579

/lgtm

Codecov Report

Merging #1583 into master will decrease coverage by 0.03%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master    #1583      +/-   ##
==========================================
- Coverage   25.86%   25.83%   -0.04%
==========================================
  Files          98       98
  Lines        5068     5075       +7
==========================================
  Hits         1311     1311
- Misses       3610     3617       +7
  Partials      147      147

Impacted Files
Coverage Δ

pkg/model/stack_new.go
32.02% <0%> (-1.32%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de82a15...ffb23de. Read the comment docs.

Is this change now ready?

I can confirm that this patch resolves https://github.com/kubernetes-incubator/kube-aws/issues/1579
Thanks!

Thanks for your contribution! 🙏

authors: DominicGunn codecov-io davidmccormick paalkr

repo: kubernetes-incubator/kube-aws


text:
cfn-signal depends on install-kube-system

These changes add the functionality so that cfn-signal fires if and only if the install-kube-system has finished successfully.
We add StartLimitInterval of 5m20s as a timeout value, so that the service does not cycle indefinitely on "ExecStartPre=/usr/bin/systemctl is-active install-kube-system.service"

Nice! Had been wondering why faults in kube system install were introduced a few times recently.

Codecov Report

Merging #835 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #835   +/-   ##
=======================================
  Coverage   34.38%   34.38%
=======================================
  Files          57       57
  Lines        3743     3743
=======================================
  Hits         1287     1287
  Misses       2311     2311
  Partials      145      145

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5780b59...fdc5ef1. Read the comment docs.

@dvdthms Thanks for the contribution 👍
LGTM overall. I've left two minor comments though.

Any more thoughts? @mumoshu

@dvdthms Sorry for the long silence due to my vacation - no, this LGTM 👍 Thanks for the contribution.

authors: c-knowles codecov-io dvdthms mumoshu


text:
Add private dns server for a specific zone

Currently there is no option to resolve a private dns zone with some private dns server.
This PR shows a possible way to do this.

Very necessary

No worries, I understand your point.
I'll let you know once I make changes.

I've resolved the issues that you mentioned.
If I define upstream_dns_servers in the following way while using dns_mode: kubedns, Docker is not able to start.
upstream_dns_servers:
  - /resolvethiszone.with/10.0.4.250
  - 8.8.8.8

Jun 02 13:35:43 kubenode01 docker[7047]: Status: invalid argument "/lo.mobbtech.com/10.0.4.250" for --dns: /lo.mobbtech.com/10.0.4.250 is not an ip address

@fieryvova you should set only this var:
dnsmasq_upstream_dns_servers:
  - /resolvethiszone.with/10.0.4.250

@mattymo OK. So does this PR make sense for you?
What can I do to get it merged into master?

@mattymo is there anything that prevents this PR from getting merged?
The issues that you mentioned have been fixed.

Any update?

Fix your commit so the email of the commit matches your github address

@mattymo I've changed commit's email and registered as Linux Foundation contributor.
What else can I do to get it merged?

ci check this

ci check this

ci is being dumb. looking in to it
$ /bin/sh scripts/premoderator.sh
jq: error (at <stdin>:5): Cannot index string with string "body"

@fieryvova Will you rebase against master to bring the latest updates into this PR? There are breaking CI changes in your branch right now so we can't test it.

@rsmitty Thanks for the update. This PR passed all CI checks.

authors: Arslanbekov SpiLLeR bradbeam fieryvova mattymo rsmitty

repo: kubernetes-incubator/kubespray


text:
docs: promote Lior to conformance approver

What type of PR is this?
/kind documentation
What this PR does / why we need it:
@LiorLieberman has been highly active and earned a promotion from conformance reviewer to approver, thank you Lior we appreciate your efforts on Gateway API! :vulcan_salute:
/cc @mlavacca @robscott @youngnick

Thanks @LiorLieberman!
/release-note-none
/lgtm

authors: robscott shaneutt

repo: kubernetes-sigs/gateway-api


text:
Revert "Modified FakeTime to allow advances in time."

What type of PR is this?
/kind regression

What this PR does / why we need it:
Reverting #373
Which issue(s) this PR fixes:

Special notes for your reviewer:
Does this PR introduce a user-facing change?
NONE

Reverting FakeTime back to a simple, non-sleeping, structure.

/assign @listx

Thanks!
/lgtm
/approve

authors: listx tylerferrara


text:
Remove deprecate klog flag usage

/kind feature
Hey, in K8s 1.23 we are planning to deprecate multiple klog flags. KEP-2845
Deprecated flags: --log-dir, --log-file, --log-flush-frequency, --logtostderr, --alsologtostderr, --one-output, --stderrthreshold, --log-file-max-size, --skip-log-headers, --add-dir-header, --skip-headers, --log-backtrace-at
One of the alpha milestones is requires us to remove usage of deprecated flags within K8s repo. Examples found for kubefed:

https://github.com/kubernetes-sigs/kubefed/blob/2fc7e363a78e5e4ab9853382e799b00a66dfa429/scripts/sync-up-helm-chart.sh#L84
/wg structured-logging

@serathius I would like to contribute for this case. I am little bit confused about how to remove deprecated klog flags usage in this case, could you please give me some direction about how to proceed while tackling this issue.

We need to stop using --log-file=${WORKDIR}/kube-apiserver.log --logtostderr=false flags and use other means to redirect command output to file. In case of this script I think we can use standard bash redirection. You can read about them here https://www.gnu.org/software/bash/manual/html_node/Redirections.html
My first guess would be that we should replace
${ROOT_DIR}/bin/kube-apiserver --etcd-servers=http://127.0.0.1:2379 --service-cluster-ip-range=10.0.0.0/16 --cert-dir=${WORKDIR} --log-file=${WORKDIR}/kube-apiserver.log --logtostderr=false 2> /dev/null &

with
${ROOT_DIR}/bin/kube-apiserver --etcd-servers=http://127.0.0.1:2379 --service-cluster-ip-range=10.0.0.0/16 --cert-dir=${WORKDIR} 2> ${WORKDIR}/kube-apiserver.log &

kube-apiserver writes by default to stderr, in the line we are chaning it uses:

--logtostderr=false to disable writing to stderr
 2>/dev/null drop any output send to stderr
 --log-file=${WORKDIR}/kube-apiserver.log write log to file

Instead we use 2> ${WORKDIR}/kube-apiserver.log which just redirects stderr to file.

/assign

authors: NikhilSharmaWe serathius

repo: kubernetes-sigs/kubefed


text:
fix(plugins/plugin-kubectl): kubectl create --dry-run | kubectl apply…

… -f - does not work
Fixes #7443

Description of what you did:

My PR is a:

[ ] 💥 Breaking change
[x] 🐛 Bug fix
[ ] 💅 Enhancement
[ ] 🚀 New feature

Please confirm that your PR fulfills these requirements

[x] Multiple commits are squashed into one commit.
[x] The commit message follows Conventional Commits, which allows us to autogenerate release notes; e.g. fix(plugins/plugin-k8s): fixed annoying bugs
[x] All npm dependencies are pinned.

/lgtm

repo: kubernetes-sigs/kui


text:
switch to using upstream vllm with new metric

switch to using upstream vllm with new metric
use latest series in gauge metric vllm:lora_requests_info
Use label pair running_lora_adapters

/assign

authors: coolkp liu-cong

repo: kubernetes-sigs/llm-instance-gateway


text:
MTB: Add test for Block use of bind mounts

https://github.com/kubernetes-sigs/multi-tenancy/blob/master/benchmarks/e2e/tests/block_bind_mounts/README.md

closing as the project is being restructured

repo: kubernetes-sigs/multi-tenancy


text:
Spelling corrections

Spelling corrections

Hi @wavell, can you sign the Linux Foundatino CLA? Details here: https://identity.linuxfoundation.org/projects/cncf
/assign @JimBugwadia

/ok-to-test

/lgtm
/approve

/assign @JimBugwadia

Hi @wavell, thanks for the PR!
It is approved and pending your signature of the Linux Foundatino CLA (see: https://identity.linuxfoundation.org/projects/cncf).

@JimBugwadia  I think we can just decline this? Seems the author isn't going to sign the CLA?

@rjbez17 - I duplicated @wavell's contributions to https://github.com/kubernetes-sigs/multi-tenancy/pull/800. Please review. Will close this PR.

/close

authors: JimBugwadia rjbez17 wavell