text:
Improve Worker logging to make CSharpWorkerFunc stacktrace clear

Currently, the CSharpWorkerFunc stacktrace looks like the same with exception stack trace. It is really confusing to users. This change is to improve CSharpWorker logging to make CSharpWorkerFunc stacktrace looks like below:
[2016-08-31T18:42:36.1260640Z] [HEBIN-Z420] [Debug] [Worker]
------------------------ Printing stack trace of workerFunc for ** debugging ** ------------------------------
[STACK] Microsoft.Spark.CSharp.Core.CSharpWorkerFunc..ctor(Func3 func) [STACK] Microsoft.Spark.CSharp.Core.CSharpWorkerFunc..ctor(Func3 func, String innerStackTrace)
[STACK] Microsoft.Spark.CSharp.Core.PipelinedRDD1.MapPartitionsWithIndex[U1](Func3 newFunc, Boolean preservesPartitioningParam)
[STACK] SelectionSensorsAgg.Program.<>c.b__35_6(RDD1 rdd) in E:\GitSrc\Discsel\private\indexgen\DiscoverySelection\Spark\SensorDelta\SelectionSensorsAgg\Program.cs:line 245 [STACK] System.Linq.Enumerable.<>c__DisplayClass7_03.b__0(TSource x)
[STACK] System.Linq.Enumerable.WhereSelectEnumerableIterator2.MoveNext() [STACK] System.Linq.Enumerable.First[TSource](IEnumerable1 source)
[STACK] Microsoft.Spark.CSharp.Proxy.Ipc.SparkContextIpcProxy.Union(IEnumerable1 rdds) [STACK] Microsoft.Spark.CSharp.Core.SparkContext.Union[T](IEnumerable1 rdds)
[STACK] SelectionSensorsAgg.Program.Main(String[] args) in E:\GitSrc\Discsel\private\indexgen\DiscoverySelection\Spark\SensorDelta\SelectionSensorsAgg\Program.cs:line 245
[STACK] System.AppDomain._nExecuteAssembly(RuntimeAssembly assembly, String[] args)
[STACK] System.AppDomain.ExecuteAssembly(String assemblyFile, Evidence assemblySecurity, String[] args)
[STACK] Microsoft.VisualStudio.HostingProcess.HostProc.RunUsersAssembly()
[STACK] System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx)
[STACK] System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx)
[STACK] System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state)
[STACK] System.Threading.ThreadHelper.ThreadStart()
[STACK] --- Inner stack trace: ---
[STACK] Microsoft.Spark.CSharp.Core.CSharpWorkerFunc..ctor(Func3 func) [STACK] Microsoft.Spark.CSharp.Core.CSharpWorkerFunc..ctor(Func3 func, String innerStackTrace)
[STACK] Microsoft.Spark.CSharp.Core.PipelinedRDD1.MapPartitionsWithIndex[U1](Func3 newFunc, Boolean preservesPartitioningParam)
[STACK] Microsoft.Spark.CSharp.ScopeWrapper.ScopeWrapper.<>c__DisplayClass17_0.b__0(RDD1 rdd) in E:\GitSrc\Discsel\private\indexgen\DiscoverySelection\Spark\ScopeWrapper\ScopeWrapper.cs:line 193 [STACK] System.Linq.Enumerable.<>c__DisplayClass7_03.b__0(TSource x)
[STACK] System.Linq.Enumerable.<>c__DisplayClass7_03.b__0(TSource x) [STACK] System.Linq.Enumerable.WhereSelectEnumerableIterator2.MoveNext()
[STACK] System.Linq.Enumerable.FirstTSource
[STACK] Microsoft.Spark.CSharp.Proxy.Ipc.SparkContextIpcProxy.Union(IEnumerable1 rdds) [STACK] Microsoft.Spark.CSharp.Core.SparkContext.Union[T](IEnumerable1 rdds)
[STACK] SelectionSensorsAgg.Program.Main(String[] args) in E:\GitSrc\Discsel\private\indexgen\DiscoverySelection\Spark\SensorDelta\SelectionSensorsAgg\Program.cs:line 245
[STACK] System.AppDomain._nExecuteAssembly(RuntimeAssembly assembly, String[] args)
[STACK] System.AppDomain.ExecuteAssembly(String assemblyFile, Evidence assemblySecurity, String[] args)
[STACK] Microsoft.VisualStudio.HostingProcess.HostProc.RunUsersAssembly()
[STACK] System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx)
[STACK] System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx)
[STACK] System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state)
[STACK] System.Threading.ThreadHelper.ThreadStart()

Current coverage is 81.91% (diff: 87.17%)

Merging #559 into master will decrease coverage by 0.22%

@@             master       #559   diff @@
==========================================
  Files            67         67
  Lines          7447       7448     +1
  Methods        1171       1171
  Messages          0          0
  Branches        953        957     +4
==========================================
- Hits           6117       6101    -16
- Misses          978        993    +15
- Partials        352        354     +2

Powered by Codecov. Last update 9f4276e...07ad612

LGTM.
I think it's a good fix.  And I wonder if we can go further that output the stack just on error ? (store it first)
Because I found (previous month on yarn cluster) the stack log was too many in one log file and made the log file huge in size, most of the stacks are useless and just noise.
However, in the developing stage, the log may be helpful, so how about gather the opinions from whom need this [DEBUG] level logs ?

@hebinhuang can you address the Codecov drop?

@skaarthik, The cove dropped on ByteBuf.cs and RiosocketWrapper.cs. This change does not touch the code. No idea why it happened.

@hebinhuang : may be you should contact with the CodeCov : [Steve] (https://github.com/stevepeak)

@skaarthik Now, the cover number is 82.15%. After add one case for ByteBuf.

@hebinhuang good to know that CodeCov issue is addressed

authors: codecov-io hebinhuang qualiu skaarthik

repo: Microsoft/Mobius


text:
[EN DateTimeV2] Support hemisphere property conf, so DatePeriodParser can properly resolve seasons

TestDatePeriodParser.cs
BasicTestFuture("I'll leave this summer", 2016, 6, 1, 2016, 9, 1);
BasicTestFuture("I'll leave in summer", 2017, 6, 1, 2017, 9, 1);
BasicTestFuture("I'll leave in winter", 2016, 12, 1, 2017, 3, 1);
BasicTestFuture("I'll leave in winter, 2017", 2017, 12, 1, 2018, 3, 1);
Resolution of season is a matter of difference between north and south hemispheres. Code should support conf parameter for this. And assume a default (north, mentioned in the schema).

This won't be exposed as a property, but as part of a new policy scheme for resolutions. No ETA yet.

source: gharchive/issue

repo: Microsoft/Recognizers-Text

license: MIT

license_type: permissive

license_source: github-api


text:
Bug fixes in PT and CN

Fixing temperature being wrongly also recognized as dimension in PT;
Fixing some area, length, and volume bugs in Chinese and English;
Adding unit tests for English age recognizers;
Adding initial unit tests for Chinese age and temperature recognizers;
Minor renames to match code standard.

@tellarin,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

source: gharchive/pull-request

authors: msftclas tellarin


text:
TEST: remove integration spark test with large dataset

Description
Temporarily remove Spark integration test
Motivation and Context
Spark integration test is a replicate of Spark smoke test. Use of large data sets lead to issues in the CI/CD pipeline.
Temporarily remove the tests until there are good fix.
Releated Issues
#369
Checklist:

[x] My code follows the code style of this project, as detailed in our contribution guidelines.
[x] I have added tests.
[x] I have updated the documentation accordingly.

It looks it is taking longer than 40min, so it time out:
2018-12-13T15:03:18.1314392Z
2018-12-13T15:42:17.9239285Z tests/integration/test_notebooks_pyspark.py FF
2018-12-13T15:42:17.9856461Z ##[error]The task has timed out.

probably some of the new changes make the notebook to take longer

@anargyri good point - also given characteristics of 100k and 1mil may not be homogeneous based on our observations in the evaluation results.

I think the change of TOL to 0.5 is extreme, as in PR 371. I would make sure everything is deterministic (seed, split etc.) for the tests. If you give ALS the same seed it should do the same thing every time. There is some variation due to machine precision etc. but this should not be 50%.

@anargyri will hold this PR until update of the ALS seed.

Resolved in #376

authors: anargyri miguelgfierro yueguoguo

repo: Microsoft/Recommenders


text:
New Commands to Handle Subscriptions

Get-RsSubscription
Set-RsSubscription
Remove-RsSubscription
Also the Pester tests for each one

@ClaudioESSilva,
Thanks for your contribution.
To ensure that the project team has proper rights to use your work, please complete the Contribution License Agreement at https://cla.microsoft.com.
It will cover your contributions to all Microsoft-managed open source projects.
Thanks,
Microsoft Pull Request Bot

@ClaudioESSilva, thanks for signing the contribution license agreement. We will now validate the agreement and then the pull request.
Thanks, Microsoft Pull Request Bot

Just to remind that I have commented the describe block from RsEncryptionKey.Tests.ps1 per @jtarquino suggestion.

I think all of your suggestions has been addressed. Can you please give another look?

authors: ClaudioESSilva msftclas

repo: Microsoft/ReportingServicesTools


text:
inferred js projects do not get maxNodeModuleJsDepth set

mkdir test
cd test
npm init --y
npm install express3-handlebars
echo var exphbs = require('express3-handlebars'); > file.js
code .

now hover over exphbs, it shows any.
create an empty jsconfig.json and reload the project, hover over it is a function.
the issue seems to be that we do not set the maxNodeModuleJsDepthfor inferred projects.

We made it zero internationally. Consider users with allowjs who have a few JS files they want to transpile. If the default is 2 they suddenly get errors from their jquery package in npm-modules for instance. We have it set to 2 for jsconfig, but not offered projects.

repo: Microsoft/TypeScript


text:
Incorrect type inference for array rest assignment and inability to add annotation

TypeScript Version:  2.7.1-insiders.20180127

Search Terms: array destructuring rest assignment
Code
// A *self-contained* demonstration of the problem follows...
// Test this by running `tsc` on the command-line, rather than through another build tool such as Gulp, Webpack, etc.
const [stringA, ...numbers] = ['string', 1, 2];
// const [stringA, ...numbers] = <[string, number, number]>['string', 1, 2];
// const [stringA, ...numbers]: [string, number[]] = ['string', 1, 2];
// const [stringA, ...numbers]: [string, [number, number]] = ['string', 1, 2];

Expected behavior: Expect numbers to be of type number[] rather than (string | number)[].
TS also does not allow annotating as a tuple
Actual behavior: const numbers: (string | number)[]
Playground Link:  http://www.typescriptlang.org/play/index.html#src=const [stringA%2C ...numbers] %3D ['string'%2C 1%2C 2]%3B
%2F%2F const [stringA%2C ...numbers] %3D <[string%2C number%2C number]>['string'%2C 1%2C 2]%3B
%2F%2F const [stringA%2C ...numbers]%3A [string%2C number[]] %3D ['string'%2C 1%2C 2]%3B
%2F%2F const [stringA%2C ...numbers]%3A [string%2C [number%2C number]] %3D ['string'%2C 1%2C 2]%3B
Related Issues:

@mhegazy so how would the numbers rest assignment be annotated as a tuple? I believe I tried to this in the last line:
const [stringA, ...numbers]: [string, [number, number]] = ['string', 1, 2];

The right type should be const [stringA, ...numbers]: [string, number, number]. and numbers should be inferred correctly. that is a bug we should fix.

I have run into this issue too with overload function

// I have tried this but it does not work
interface OperatorTuple extends Array<OperatorFunction<any, any>> {
  0: OperatorFunction<any, any>;
  1: OperatorFunction<any, any>;
  2: OperatorFunction<any, any>;
  3: OperatorFunction<any, any>;
  4: OperatorFunction<any, any>;
  5: OperatorFunction<any, any>;
  6: OperatorFunction<any, any>;
  7: OperatorFunction<any, any>;
  length: 8;
}

// this is an overload function
export function Select<A, B>(mapFn: ((state: A) => B), ...operators: OperatorFunction<any, any>[]) {
  return function(target: any, name: string): void {
    if (typeof mapFn !== 'function') {
      throw new TypeError(
        `Unexpected type '${typeof mapFn}' in select operator,` + ` expected 'function'`
      );
    }

    // trying to cast type tuple
    operators = [...operators] as OperatorTuple;

    const descriptor = Object.getOwnPropertyDescriptor(target, name);

    if (delete target[name]) {
      Object.defineProperty(target, name, {
        get() {
          const source$ = NgrxSelect.store;

          if (!source$) {
            throw new Error('NgrxSelect not connected to store!');
          }

         // I have tried this too but have failed
         if (operators.length > 8) {
            throw new Error()
         }

          // Error: Expect 0-9 arguments but received 1 or more
          return source$.pipe(select(mapFn), ...operators);
        },
        ...descriptor
      });
    }
  };
}

The issue in the opening post is fixed in typescript@next, maybe even 3.0.0-rc.
numbers is now of type number[].

authors: ajafff mhegazy sandangel theseyi


text:
[2.8.0-rc] Segfault when running compiler with --d or --watch (out of memory)

Hello,
I was using 2.8.0-dev-20180216 and recently switched to 2.8.0-rc. I immediately noticed, that, when launching compiler with --watch it started to take a lot longer for the initial compilation. The subsequent compilations on file change were working fine.
But now, after some code refactoring, launching with --watch segfaults with out of memory error (after a long wait). Running w/o --watch works just fine (and fast enough).
So there's definitely some regression related to the initial compilation of the project in --watch mode.
Here's an output from the shell session. Note, how compilation w/o --watch worked fine (3rd command):
nickolay@outpost:~/workspace/Bryntum/SchedulingEngine0.x$ ./node_modules/.bin/tsc --version
Version 2.8.0-rc
nickolay@outpost:~/workspace/Bryntum/SchedulingEngine0.x$ node --version
v8.9.4
nickolay@outpost:~/workspace/Bryntum/SchedulingEngine0.x$ ./node_modules/.bin/tsc
nickolay@outpost:~/workspace/Bryntum/SchedulingEngine0.x$ ./node_modules/.bin/tsc --watch

16:40:41 - Starting compilation in watch mode...

<--- Last few GCs --->

[4089:0x23b2e20]    92678 ms: Mark-sweep 1411.0 (1459.8) -> 1411.0 (1443.8) MB, 1653.6 / 0.5 ms  (+ 0.0 ms in 0 steps since start of marking, biggest step 0.0 ms, walltime since start of marking 1655 ms) last resort GC in old space requested
[4089:0x23b2e20]    94301 ms: Mark-sweep 1411.0 (1443.8) -> 1411.0 (1443.8) MB, 1622.7 / 0.6 ms  last resort GC in old space requested

<--- JS stacktrace --->

==== JS stack trace =========================================

Security context: 0x43f5ef25ee1 <JSObject>
    1: getTextOfNode(aka getTextOfNode) [/home/nickolay/workspace/Bryntum/SchedulingEngine0.x/node_modules/typescript/lib/tsc.js:~60023] [pc=0xc63f1afcb97](this=0x212ba7e02311 <undefined>,node=0x27070b5c3fd9 <Node map = 0x136dd41e54c1>,includeTrivia=0x212ba7e02421 <false>)
    2: emitIdentifier(aka emitIdentifier) [/home/nickolay/workspace/Bryntum/SchedulingEngine0.x/node_modules/typescript/lib/t...

FATAL ERROR: CALL_AND_RETRY_LAST Allocation failed - JavaScript heap out of memory
 1: node::Abort() [node]
 2: 0x122563c [node]
 3: v8::Utils::ReportOOMFailure(char const*, bool) [node]
 4: v8::internal::V8::FatalProcessOutOfMemory(char const*, bool) [node]
 5: v8::internal::Factory::NewFixedArray(int, v8::internal::PretenureFlag) [node]
 6: v8::internal::LoadIC::LoadFromPrototype(v8::internal::Handle<v8::internal::Map>, v8::internal::Handle<v8::internal::JSObject>, v8::internal::Handle<v8::internal::Name>, v8::internal::Handle<v8::internal::Smi>) [node]
 7: v8::internal::LoadIC::GetMapIndependentHandler(v8::internal::LookupIterator*) [node]
 8: v8::internal::IC::ComputeHandler(v8::internal::LookupIterator*) [node]
 9: v8::internal::LoadIC::UpdateCaches(v8::internal::LookupIterator*) [node]
10: v8::internal::LoadIC::Load(v8::internal::Handle<v8::internal::Object>, v8::internal::Handle<v8::internal::Name>) [node]
11: v8::internal::Runtime_LoadIC_Miss(int, v8::internal::Object**, v8::internal::Isolate*) [node]
12: 0xc63f178463d
Aborted (core dumped)
nickolay@outpost:~/workspace/Bryntum/SchedulingEngine0.x$

Correction - it actually fails with 2.8.0-dev.20180216 as well, but now, it just takes forever for the initial compilation with --watch. Compilation w/o --watch works fine with 2.8.0-dev.20180216 as well.

The application does a heavy use of mixins if that matters.

Potentially a duplicate of #21140, but @sheetalkamat can you take a look?

@SamuraiJack can you please share your project so i can repro and investigate this. So far we haven't gotten repro on this issue so its hard to predict without looking at it what might be going wrong. Thanks.

@sheetalkamat Ok, I'll prepare the reproducible test case, on Monday already..

Unfortunately, preparing a test case is not easy - I can't share the code.
But you should check the code, that performs the initial compilation during --watch. That initial compilation takes a lot longer than normal compilation without --watch. I guess it also uses more memory and thus crash at certain project size. So that initial compilation is done in some different mode and bug is there.

I've seen this too.
I believe this may have relation with https://github.com/Microsoft/TypeScript/issues/22668 if you use cnpm too. @SamuraiJack

Nope, we don't use cnpm. I believe its some algorithm with quadratic behavior in "watch" compilation mode. At certain project size it becomes noticeable and process crashes with OOM.
@sheetalkamat To reproduce this, you could try to generate huge dummy project, based on the template like:
type Constructable<T = {}> = new (...args : any[]) => T

export const Mixin1 = <T extends Constructable>(base : T) =>

    class Mixin1 extends base {
        method1() {
        }
    }

export const Mixin2 = <T extends Constructable>(base : T) =>

    class Mixin2 extends base {
        method2 () {
        }
    }

export const Mixin3 = <T extends Constructable>(base : T) =>

    class Mixin3 extends Mixin2<Constructable>(base) {
        method3 () {
        }
    }

export const Mixin4 = <T extends Constructable>(base : T) =>

    class Mixin4 extends Mixin1(Mixin3(base)) {
        method4 () {
            this.method1()

            this.method2()
        }
    }

The idea is that Mixin(N) includes Mixin(N-1). Mixins should be in different files. This roughly corresponds to what we have in our project (of course we don't have such deep mixins "inheritance", only 2-3 levels, but there are many sibling mixins). I believe at certain N the issue will manifest itself.

Tried with 2.9.0-dev.20180329 - no changes, did you mean 2.9.0-dev.20180330 perhaps?
I have only 54 TS files. The internal typing references are a lot more complex than in the example I posted of course..

Tried with 2.9.0-dev.20180330 - no change.

@sheetalkamat I'm happy to do a screenshare session at your convenience if that is possible.

@samura	Are you still able to repro this issue with typescript@next? If yes, can you please check if you see this when you run tsc --d (ensure emit is not disabled)? I am guessing this has to do with the declaration emit (which is used to build incrementally in watch mode) but would like to confirm that. Thank you.

wrong username? I'm not @SamuraiJack

@sheetalkamat Tried with 3.0.0-dev.20180626 - seems there's no difference, I see
[11:29:03] Starting compilation in watch mode...

And then nothing.

wrong username? I'm not @SamuraiJack

Sorry about that.

@SamuraiJack Are you still able to repro this issue with typescript@next? If yes, can you please check if you see this when you run tsc --d (ensure emit is not disabled)? I am guessing this has to do with the declaration emit (which is used to build incrementally in watch mode) but would like to confirm that. Thank you.

Were you able to check if this repros when emit is not disabled and emitting declarations?

Were you able to check if this repros when emit is not disabled and emitting declarations?

@sheetalkamat How do you mean? Some particular command line switch? I'm just launching ./node_modules/.bin/tsc --watch

@SamuraiJack run it as ./node_modules/.bin/tsc --d --extendedDiagnostics

@sheetalkamat
Ok, here are the results:
nickolay@outpost:~/workspace/Bryntum/SchedulingEngine0.x$ ./node_modules/.bin/tsc --version
Version 3.0.0-dev.20180703
nickolay@outpost:~/workspace/Bryntum/SchedulingEngine0.x$ ./node_modules/.bin/tsc --d --extendedDiagnostics

^C
nickolay@outpost:~/workspace/Bryntum/SchedulingEngine0.x$ ./node_modules/.bin/tsc --d --extendedDiagnostics --watch
[10:35:21] Starting compilation in watch mode...

Current directory: /home/nickolay/workspace/Bryntum/SchedulingEngine0.x CaseSensitiveFileNames: true
FileWatcher:: Added:: WatchInfo: /home/nickolay/workspace/Bryntum/SchedulingEngine0.x/tsconfig.json 2000 Config file
Synchronizing program
CreatingProgramWith::
  roots: ["/home/nickolay/workspace/Bryntum/SchedulingEngine0.x/lib/chrono/ChronoGraph.ts","/home/nickolay/workspace/Bryntum/SchedulingEngine0.x/lib/data/general/PartOfProjectGenericMixin.ts","/home/nickolay/workspace/Bryntum/SchedulingEngine0.x/lib/data/model/AssignmentMixin.ts","/home/nickolay/workspace/Bryntum/SchedulingEngine0.x/lib/data/model/CalendarIntervalMixin.ts","/home/nickolay/workspace/Bryntum/SchedulingEngine0.x/lib/data/model/CalendarMixin.ts","/home/nickolay/workspace/Bryntum/SchedulingEngine0.x/lib/data/model/DependencyMixin.ts","/home/nickolay/workspace/Bryntum/SchedulingEngine0.x/lib/data/model/EventMixin.ts","/home/nickolay/workspace/Bryntum/SchedulingEngine0.x/lib/data/model/ProjectMixin.ts","/home/nickolay/workspace/Bryntum/SchedulingEngine0.x/lib/data/model/ResourceMixin.ts","/home/nickolay/workspace/Bryntum/SchedulingEngine0.x/lib/data/model/mixin/ChronoModelMixin.ts","/home/nickolay/workspace/Bryntum/SchedulingEngine0.x/lib/data/model/mixin/HasBehaviorMixin.ts","/home/nickolay/workspace/Bryntum/SchedulingEngine0.x/lib/data/model/mixin/HasCalendarMixin.ts","/home/nickolay/workspace/Bryntum/SchedulingEngine0.x/lib/data/model/mixin/HasFieldsStubMixin.ts","/home/nickolay/workspace/Bryntum/SchedulingEngine0.x/lib/data/model/mixin/PartOfProjectMixin.ts","/home/nickolay/workspace/Bryntum/SchedulingEngine0.x/lib/data/store/AssignmentStoreMixin.ts","/home/nickolay/workspace/Bryntum/SchedulingEngine0.x/lib/data/store/CalendarIntervalStore.ts","/home/nickolay/workspace/Bryntum/SchedulingEngine0.x/lib/data/store/CalendarManagerStoreMixin.ts","/home/nickolay/workspace/Bryntum/SchedulingEngine0.x/lib/data/store/DependencyStoreMixin.ts","/home/nickolay/workspace/Bryntum/SchedulingEngine0.x/lib/data/store/EventStoreMixin.ts","/home/nickolay/workspace/Bryntum/SchedulingEngine0.x/lib/data/store/ResourceStoreMixin.ts","/home/nickolay/workspace/Bryntum/SchedulingEngine0.x/lib/data/store/mixin/ChronoStoreMixin.ts","/home/nickolay/workspace/Bryntum/SchedulingEngine0.x/lib/data/store/mixin/PartOfProjectMixin.ts","/home/nickolay/workspace/Bryntum/SchedulingEngine0.x/lib/scheduling/DateInterval.ts","/home/nickolay/workspace/Bryntum/SchedulingEngine0.x/lib/scheduling/Interfaces.ts","/home/nickolay/workspace/Bryntum/SchedulingEngine0.x/lib/scheduling/Types.ts","/home/nickolay/workspace/Bryntum/SchedulingEngine0.x/lib/scheduling/behaviour/assignment/BaseBehavior.ts","/home/nickolay/workspace/Bryntum/SchedulingEngine0.x/lib/scheduling/behaviour/calendar/BaseBehavior.ts","/home/nickolay/workspace/Bryntum/SchedulingEngine0.x/lib/scheduling/behaviour/dependency/BaseBehavior.ts","/home/nickolay/workspace/Bryntum/SchedulingEngine0.x/lib/scheduling/behaviour/dependency/EndToStartBehaviorMixin.ts","/home/nickolay/workspace/Bryntum/SchedulingEngine0.x/lib/scheduling/behaviour/event/BaseBehavior.ts","/home/nickolay/workspace/Bryntum/SchedulingEngine0.x/lib/scheduling/behaviour/event/ChildBehaviorMixin.ts","/home/nickolay/workspace/Bryntum/SchedulingEngine0.x/lib/scheduling/behaviour/event/EffortDrivenBehaviorMixin.ts","/home/nickolay/workspace/Bryntum/SchedulingEngine0.x/lib/scheduling/behaviour/event/FloatingBehaviorMixin.ts","/home/nickolay/workspace/Bryntum/SchedulingEngine0.x/lib/scheduling/behaviour/event/ParentBehaviorMixin.ts","/home/nickolay/workspace/Bryntum/SchedulingEngine0.x/lib/scheduling/behaviour/project/BaseBehavior.ts","/home/nickolay/workspace/Bryntum/SchedulingEngine0.x/lib/scheduling/behaviour/resource/BaseBehavior.ts","/home/nickolay/workspace/Bryntum/SchedulingEngine0.x/lib/scheduling/calendar/CalendarCache.ts","/home/nickolay/workspace/Bryntum/SchedulingEngine0.x/lib/scheduling/calendar/CalendarCacheInterval.ts","/home/nickolay/workspace/Bryntum/SchedulingEngine0.x/lib/scheduling/calendar/CalendarCacheIntervalMultiple.ts","/home/nickolay/workspace/Bryntum/SchedulingEngine0.x/lib/scheduling/calendar/CalendarCacheMultiple.ts","/home/nickolay/workspace/Bryntum/SchedulingEngine0.x/lib/scheduling/calendar/CalendarCacheSingle.ts","/home/nickolay/workspace/Bryntum/SchedulingEngine0.x/lib/scheduling/functions/DependencyFunctions.ts","/home/nickolay/workspace/Bryntum/SchedulingEngine0.x/lib/scheduling/functions/EventFunctions.ts","/home/nickolay/workspace/Bryntum/SchedulingEngine0.x/lib/util/Common.ts","/home/nickolay/workspace/Bryntum/SchedulingEngine0.x/lib/util/DateHelper.ts","/home/nickolay/workspace/Bryntum/SchedulingEngine0.x/lib/util/IntervalCache.ts","/home/nickolay/workspace/Bryntum/SchedulingEngine0.x/lib/util/SortedMap.ts","/home/nickolay/workspace/Bryntum/SchedulingEngine0.x/tests/chrono/basic_calculations.ts","/home/nickolay/workspace/Bryntum/SchedulingEngine0.x/tests/chrono/performance.ts","/home/nickolay/workspace/Bryntum/SchedulingEngine0.x/tests/chrono/topo_ordering.ts","/home/nickolay/workspace/Bryntum/SchedulingEngine0.x/tests/scheduling/basic.ts","/home/nickolay/workspace/Bryntum/SchedulingEngine0.x/tests/scheduling/basic_with_calendar.ts","/home/nickolay/workspace/Bryntum/SchedulingEngine0.x/tests/scheduling/date_interval.ts","/home/nickolay/workspace/Bryntum/SchedulingEngine0.x/tests/scheduling/floating.ts","/home/nickolay/workspace/Bryntum/SchedulingEngine0.x/tests/scheduling/inheritance_from_model.ts","/home/nickolay/workspace/Bryntum/SchedulingEngine0.x/tests/scheduling/calendars/backward.ts","/home/nickolay/workspace/Bryntum/SchedulingEngine0.x/tests/scheduling/calendars/benchmark.ts","/home/nickolay/workspace/Bryntum/SchedulingEngine0.x/tests/scheduling/calendars/crud.ts","/home/nickolay/workspace/Bryntum/SchedulingEngine0.x/tests/scheduling/calendars/empty_calendar.ts","/home/nickolay/workspace/Bryntum/SchedulingEngine0.x/tests/scheduling/calendars/forward.ts","/home/nickolay/workspace/Bryntum/SchedulingEngine0.x/tests/scheduling/calendars/inverted.ts","/home/nickolay/workspace/Bryntum/SchedulingEngine0.x/tests/scheduling/calendars/multi.ts","/home/nickolay/workspace/Bryntum/SchedulingEngine0.x/tests/scheduling/calendars/parent_child.ts","/home/nickolay/workspace/Bryntum/SchedulingEngine0.x/tests/scheduling/scheduling_modes/effort_driven.ts","/home/nickolay/workspace/Bryntum/SchedulingEngine0.x/tests/util/interval_cache.ts","/home/nickolay/workspace/Bryntum/SchedulingEngine0.x/tests/util/sorted_map.ts"]
  options: {"target":2,"lib":["lib.es2015.d.ts","lib.es2016.d.ts"],"declaration":true,"extendedDiagnostics":true,"watch":true,"configFilePath":"/home/nickolay/workspace/Bryntum/SchedulingEngine0.x/tsconfig.json"}
FileWatcher:: Added:: WatchInfo: /home/nickolay/workspace/Bryntum/SchedulingEngine0.x/lib/chrono/ChronoGraph.ts 250 Source file
DirectoryWatcher:: Added:: WatchInfo: /home/nickolay/workspace/Bryntum/SchedulingEngine0.x 1 Failed Lookup Locations
FileWatcher:: Added:: WatchInfo: /home/nickolay/workspace/Bryntum/SchedulingEngine0.x/lib/util/Common.ts 250 Source file
DirectoryWatcher:: Added:: WatchInfo: /home/nickolay/workspace/Bryntum/Grid0.x 1 Failed Lookup Locations
FileWatcher:: Added:: WatchInfo: /home/nickolay/workspace/Bryntum/SchedulingEngine0.x/lib/scheduling/Types.ts 250 Source file
FileWatcher:: Added:: WatchInfo: /home/nickolay/workspace/Bryntum/SchedulingEngine0.x/lib/util/DateHelper.ts 250 Source file
FileWatcher:: Added:: WatchInfo: /home/nickolay/workspace/Bryntum/SchedulingEngine0.x/lib/data/general/PartOfProjectGenericMixin.ts 250 Source file
FileWatcher:: Added:: WatchInfo: /home/nickolay/workspace/Bryntum/SchedulingEngine0.x/lib/data/store/EventStoreMixin.ts 250 Source file
FileWatcher:: Added:: WatchInfo: /home/nickolay/workspace/Bryntum/SchedulingEngine0.x/lib/data/store/mixin/ChronoStoreMixin.ts 250 Source file
FileWatcher:: Added:: WatchInfo: /home/nickolay/workspace/Bryntum/SchedulingEngine0.x/lib/data/model/EventMixin.ts 250 Source file
FileWatcher:: Added:: WatchInfo: /home/nickolay/workspace/Bryntum/SchedulingEngine0.x/lib/data/model/mixin/ChronoModelMixin.ts 250 Source file
FileWatcher:: Added:: WatchInfo: /home/nickolay/workspace/Bryntum/SchedulingEngine0.x/lib/data/model/mixin/HasBehaviorMixin.ts 250 Source file
FileWatcher:: Added:: WatchInfo: /home/nickolay/workspace/Bryntum/SchedulingEngine0.x/lib/scheduling/Interfaces.ts 250 Source file
FileWatcher:: Added:: WatchInfo: /home/nickolay/workspace/Bryntum/SchedulingEngine0.x/lib/data/model/ResourceMixin.ts 250 Source file
FileWatcher:: Added:: WatchInfo: /home/nickolay/workspace/Bryntum/SchedulingEngine0.x/lib/scheduling/behaviour/resource/BaseBehavior.ts 250 Source file
FileWatcher:: Added:: WatchInfo: /home/nickolay/workspace/Bryntum/SchedulingEngine0.x/lib/data/model/CalendarMixin.ts 250 Source file
FileWatcher:: Added:: WatchInfo: /home/nickolay/workspace/Bryntum/SchedulingEngine0.x/lib/scheduling/behaviour/calendar/BaseBehavior.ts 250 Source file
FileWatcher:: Added:: WatchInfo: /home/nickolay/workspace/Bryntum/SchedulingEngine0.x/lib/scheduling/calendar/CalendarCacheInterval.ts 250 Source file
FileWatcher:: Added:: WatchInfo: /home/nickolay/workspace/Bryntum/SchedulingEngine0.x/lib/data/model/CalendarIntervalMixin.ts 250 Source file
FileWatcher:: Added:: WatchInfo: /home/nickolay/workspace/Bryntum/SchedulingEngine0.x/lib/data/model/mixin/HasFieldsStubMixin.ts 250 Source file
FileWatcher:: Added:: WatchInfo: /home/nickolay/workspace/Bryntum/SchedulingEngine0.x/lib/data/store/CalendarIntervalStore.ts 250 Source file
FileWatcher:: Added:: WatchInfo: /home/nickolay/workspace/Bryntum/SchedulingEngine0.x/lib/scheduling/calendar/CalendarCacheSingle.ts 250 Source file
FileWatcher:: Added:: WatchInfo: /home/nickolay/workspace/Bryntum/SchedulingEngine0.x/lib/scheduling/calendar/CalendarCache.ts 250 Source file
FileWatcher:: Added:: WatchInfo: /home/nickolay/workspace/Bryntum/SchedulingEngine0.x/lib/util/IntervalCache.ts 250 Source file
FileWatcher:: Added:: WatchInfo: /home/nickolay/workspace/Bryntum/SchedulingEngine0.x/lib/util/SortedMap.ts 250 Source file
FileWatcher:: Added:: WatchInfo: /home/nickolay/workspace/Bryntum/SchedulingEngine0.x/lib/data/model/mixin/HasCalendarMixin.ts 250 Source file
FileWatcher:: Added:: WatchInfo: /home/nickolay/workspace/Bryntum/SchedulingEngine0.x/lib/data/store/CalendarManagerStoreMixin.ts 250 Source file
FileWatcher:: Added:: WatchInfo: /home/nickolay/workspace/Bryntum/SchedulingEngine0.x/lib/data/store/mixin/PartOfProjectMixin.ts 250 Source file
FileWatcher:: Added:: WatchInfo: /home/nickolay/workspace/Bryntum/SchedulingEngine0.x/lib/data/store/AssignmentStoreMixin.ts 250 Source file
FileWatcher:: Added:: WatchInfo: /home/nickolay/workspace/Bryntum/SchedulingEngine0.x/lib/data/model/AssignmentMixin.ts 250 Source file
FileWatcher:: Added:: WatchInfo: /home/nickolay/workspace/Bryntum/SchedulingEngine0.x/lib/scheduling/behaviour/assignment/BaseBehavior.ts 250 Source file
FileWatcher:: Added:: WatchInfo: /home/nickolay/workspace/Bryntum/SchedulingEngine0.x/lib/scheduling/functions/EventFunctions.ts 250 Source file
FileWatcher:: Added:: WatchInfo: /home/nickolay/workspace/Bryntum/SchedulingEngine0.x/lib/scheduling/DateInterval.ts 250 Source file
FileWatcher:: Added:: WatchInfo: /home/nickolay/workspace/Bryntum/SchedulingEngine0.x/lib/scheduling/calendar/CalendarCacheMultiple.ts 250 Source file
FileWatcher:: Added:: WatchInfo: /home/nickolay/workspace/Bryntum/SchedulingEngine0.x/lib/scheduling/calendar/CalendarCacheIntervalMultiple.ts 250 Source file
FileWatcher:: Added:: WatchInfo: /home/nickolay/workspace/Bryntum/SchedulingEngine0.x/lib/data/store/DependencyStoreMixin.ts 250 Source file
FileWatcher:: Added:: WatchInfo: /home/nickolay/workspace/Bryntum/SchedulingEngine0.x/lib/data/model/DependencyMixin.ts 250 Source file
FileWatcher:: Added:: WatchInfo: /home/nickolay/workspace/Bryntum/SchedulingEngine0.x/lib/scheduling/behaviour/dependency/EndToStartBehaviorMixin.ts 250 Source file
FileWatcher:: Added:: WatchInfo: /home/nickolay/workspace/Bryntum/SchedulingEngine0.x/lib/scheduling/functions/DependencyFunctions.ts 250 Source file
FileWatcher:: Added:: WatchInfo: /home/nickolay/workspace/Bryntum/SchedulingEngine0.x/lib/scheduling/behaviour/dependency/BaseBehavior.ts 250 Source file
FileWatcher:: Added:: WatchInfo: /home/nickolay/workspace/Bryntum/SchedulingEngine0.x/lib/data/store/ResourceStoreMixin.ts 250 Source file
FileWatcher:: Added:: WatchInfo: /home/nickolay/workspace/Bryntum/SchedulingEngine0.x/lib/data/model/mixin/PartOfProjectMixin.ts 250 Source file
FileWatcher:: Added:: WatchInfo: /home/nickolay/workspace/Bryntum/SchedulingEngine0.x/lib/scheduling/behaviour/event/BaseBehavior.ts 250 Source file
FileWatcher:: Added:: WatchInfo: /home/nickolay/workspace/Bryntum/SchedulingEngine0.x/lib/scheduling/behaviour/event/ChildBehaviorMixin.ts 250 Source file
FileWatcher:: Added:: WatchInfo: /home/nickolay/workspace/Bryntum/SchedulingEngine0.x/lib/scheduling/behaviour/event/ParentBehaviorMixin.ts 250 Source file
FileWatcher:: Added:: WatchInfo: /home/nickolay/workspace/Bryntum/SchedulingEngine0.x/lib/scheduling/behaviour/event/FloatingBehaviorMixin.ts 250 Source file
FileWatcher:: Added:: WatchInfo: /home/nickolay/workspace/Bryntum/SchedulingEngine0.x/lib/scheduling/behaviour/event/EffortDrivenBehaviorMixin.ts 250 Source file
FileWatcher:: Added:: WatchInfo: /home/nickolay/workspace/Bryntum/SchedulingEngine0.x/lib/data/model/ProjectMixin.ts 250 Source file
FileWatcher:: Added:: WatchInfo: /home/nickolay/workspace/Bryntum/SchedulingEngine0.x/lib/scheduling/behaviour/project/BaseBehavior.ts 250 Source file
FileWatcher:: Added:: WatchInfo: /home/nickolay/workspace/Bryntum/SchedulingEngine0.x/tests/chrono/basic_calculations.ts 250 Source file
FileWatcher:: Added:: WatchInfo: /home/nickolay/workspace/Bryntum/SchedulingEngine0.x/tests/chrono/performance.ts 250 Source file
FileWatcher:: Added:: WatchInfo: /home/nickolay/workspace/Bryntum/SchedulingEngine0.x/tests/chrono/topo_ordering.ts 250 Source file
FileWatcher:: Added:: WatchInfo: /home/nickolay/workspace/Bryntum/SchedulingEngine0.x/tests/scheduling/basic.ts 250 Source file
FileWatcher:: Added:: WatchInfo: /home/nickolay/workspace/Bryntum/SchedulingEngine0.x/tests/scheduling/basic_with_calendar.ts 250 Source file
FileWatcher:: Added:: WatchInfo: /home/nickolay/workspace/Bryntum/SchedulingEngine0.x/tests/scheduling/date_interval.ts 250 Source file
FileWatcher:: Added:: WatchInfo: /home/nickolay/workspace/Bryntum/SchedulingEngine0.x/tests/scheduling/floating.ts 250 Source file
FileWatcher:: Added:: WatchInfo: /home/nickolay/workspace/Bryntum/SchedulingEngine0.x/tests/scheduling/inheritance_from_model.ts 250 Source file
FileWatcher:: Added:: WatchInfo: /home/nickolay/workspace/Bryntum/SchedulingEngine0.x/tests/scheduling/calendars/backward.ts 250 Source file
FileWatcher:: Added:: WatchInfo: /home/nickolay/workspace/Bryntum/SchedulingEngine0.x/tests/scheduling/calendars/benchmark.ts 250 Source file
FileWatcher:: Added:: WatchInfo: /home/nickolay/workspace/Bryntum/SchedulingEngine0.x/tests/scheduling/calendars/crud.ts 250 Source file
FileWatcher:: Added:: WatchInfo: /home/nickolay/workspace/Bryntum/SchedulingEngine0.x/tests/scheduling/calendars/empty_calendar.ts 250 Source file
FileWatcher:: Added:: WatchInfo: /home/nickolay/workspace/Bryntum/SchedulingEngine0.x/tests/scheduling/calendars/forward.ts 250 Source file
FileWatcher:: Added:: WatchInfo: /home/nickolay/workspace/Bryntum/SchedulingEngine0.x/tests/scheduling/calendars/inverted.ts 250 Source file
FileWatcher:: Added:: WatchInfo: /home/nickolay/workspace/Bryntum/SchedulingEngine0.x/tests/scheduling/calendars/multi.ts 250 Source file
FileWatcher:: Added:: WatchInfo: /home/nickolay/workspace/Bryntum/SchedulingEngine0.x/tests/scheduling/calendars/parent_child.ts 250 Source file
FileWatcher:: Added:: WatchInfo: /home/nickolay/workspace/Bryntum/SchedulingEngine0.x/tests/scheduling/scheduling_modes/effort_driven.ts 250 Source file
FileWatcher:: Added:: WatchInfo: /home/nickolay/workspace/Bryntum/SchedulingEngine0.x/tests/util/interval_cache.ts 250 Source file
FileWatcher:: Added:: WatchInfo: /home/nickolay/workspace/Bryntum/SchedulingEngine0.x/tests/util/sorted_map.ts 250 Source file
FileWatcher:: Added:: WatchInfo: /home/nickolay/workspace/Bryntum/SchedulingEngine0.x/node_modules/@types/node/index.d.ts 250 Source file
FileWatcher:: Added:: WatchInfo: /home/nickolay/workspace/Bryntum/SchedulingEngine0.x/node_modules/@types/node/inspector.d.ts 250 Source file
DirectoryWatcher:: Added:: WatchInfo: /home/nickolay/workspace/Bryntum 0 Failed Lookup Locations
DirectoryWatcher:: Added:: WatchInfo: /home/nickolay/workspace/Bryntum/node_modules 1 Failed Lookup Locations
FileWatcher:: Added:: WatchInfo: /home/nickolay/workspace/Bryntum/SchedulingEngine0.x/node_modules/typescript/lib/lib.es2015.d.ts 250 Source file
FileWatcher:: Added:: WatchInfo: /home/nickolay/workspace/Bryntum/SchedulingEngine0.x/node_modules/typescript/lib/lib.es5.d.ts 250 Source file
FileWatcher:: Added:: WatchInfo: /home/nickolay/workspace/Bryntum/SchedulingEngine0.x/node_modules/typescript/lib/lib.es2015.core.d.ts 250 Source file
FileWatcher:: Added:: WatchInfo: /home/nickolay/workspace/Bryntum/SchedulingEngine0.x/node_modules/typescript/lib/lib.es2015.collection.d.ts 250 Source file
FileWatcher:: Added:: WatchInfo: /home/nickolay/workspace/Bryntum/SchedulingEngine0.x/node_modules/typescript/lib/lib.es2015.generator.d.ts 250 Source file
FileWatcher:: Added:: WatchInfo: /home/nickolay/workspace/Bryntum/SchedulingEngine0.x/node_modules/typescript/lib/lib.es2015.promise.d.ts 250 Source file
FileWatcher:: Added:: WatchInfo: /home/nickolay/workspace/Bryntum/SchedulingEngine0.x/node_modules/typescript/lib/lib.es2015.iterable.d.ts 250 Source file
FileWatcher:: Added:: WatchInfo: /home/nickolay/workspace/Bryntum/SchedulingEngine0.x/node_modules/typescript/lib/lib.es2015.symbol.d.ts 250 Source file
FileWatcher:: Added:: WatchInfo: /home/nickolay/workspace/Bryntum/SchedulingEngine0.x/node_modules/typescript/lib/lib.es2015.proxy.d.ts 250 Source file
FileWatcher:: Added:: WatchInfo: /home/nickolay/workspace/Bryntum/SchedulingEngine0.x/node_modules/typescript/lib/lib.es2015.reflect.d.ts 250 Source file
FileWatcher:: Added:: WatchInfo: /home/nickolay/workspace/Bryntum/SchedulingEngine0.x/node_modules/typescript/lib/lib.es2015.symbol.wellknown.d.ts 250 Source file
FileWatcher:: Added:: WatchInfo: /home/nickolay/workspace/Bryntum/SchedulingEngine0.x/node_modules/typescript/lib/lib.es2016.d.ts 250 Source file
FileWatcher:: Added:: WatchInfo: /home/nickolay/workspace/Bryntum/SchedulingEngine0.x/node_modules/typescript/lib/lib.es2016.array.include.d.ts 250 Source file
DirectoryWatcher:: Added:: WatchInfo: /home/nickolay/workspace/Bryntum/SchedulingEngine0.x/node_modules/@types 1 Type roots
DirectoryWatcher:: Added:: WatchInfo: /home/nickolay/workspace/Bryntum/node_modules/@types 1 Type roots

@SamuraiJack  do not run it with watch just this command: ./node_modules/.bin/tsc --d --extendedDiagnostics what we are trying to figure out is if the issue is in the declaration emit rather than anything just specific to watch (which uses declaration emit)) If that command hangs we can certainly say that the issue is in declaration emit. Thank you.

@sheetalkamat Yes, it hangs - see the output above, which I had to interrupt with CTRL+C

Oh, actually after leaving for some time there's additional output:
nickolay@outpost:~/workspace/Bryntum/SchedulingEngine0.x$ ./node_modules/.bin/tsc --d --extendedDiagnostics

<--- Last few GCs --->

[1219:0x408f5f0]   350399 ms: Mark-sweep 1402.0 (1444.8) -> 1402.0 (1429.8) MB, 1012.9 / 0.0 ms  (+ 0.0 ms in 0 steps since start of marking, biggest step 0.0 ms, walltime since start of marking 1013 ms) last resort GC in old space requested
[1219:0x408f5f0]   351391 ms: Mark-sweep 1402.0 (1429.8) -> 1402.0 (1429.8) MB, 992.4 / 0.0 ms  last resort GC in old space requested

<--- JS stacktrace --->

==== JS stack trace =========================================

    0: ExitFrame [pc: 0x337f3b58427d]
Security context: 0x127b263206a9 <JSObject>
    1: getSynthesizedClone [/home/nickolay/workspace/Bryntum/SchedulingEngine0.x/node_modules/typescript/lib/tsc.js:~46408] [pc=0x337f3be4bbd2](this=0x3567fe203691 <Object map = 0x38b563cef531>,node=0x19c8bcf32ce1 <Node map = 0x38b563cb4ac1>)
    2: symbolToParameterDeclaration(aka symbolToParameterDeclaration) [/home/nickolay/workspace/Bryntum/SchedulingEng...

FATAL ERROR: CALL_AND_RETRY_LAST Allocation failed - JavaScript heap out of memory
 1: node::Abort() [node]
 2: 0x876afc [node]
 3: v8::Utils::ReportOOMFailure(char const*, bool) [node]
 4: v8::internal::V8::FatalProcessOutOfMemory(char const*, bool) [node]
 5: v8::internal::Factory::NewLoadHandler(int) [node]
 6: v8::internal::LoadHandler::LoadFullChain(v8::internal::Isolate*, v8::internal::Handle<v8::internal::Map>, v8::internal::Handle<v8::internal::Object>, v8::internal::Handle<v8::internal::Smi>) [node]
 7: v8::internal::LoadIC::UpdateCaches(v8::internal::LookupIterator*) [node]
 8: v8::internal::LoadIC::Load(v8::internal::Handle<v8::internal::Object>, v8::internal::Handle<v8::internal::Name>) [node]
 9: v8::internal::Runtime_LoadIC_Miss(int, v8::internal::Object**, v8::internal::Isolate*) [node]
10: 0x337f3b58427d
Aborted (core dumped)

@weswigham Another repro to look at for declaration emit optimization since thats the one causing the watch to go on forever as it uses declaration emit result

@sheetalkamat I assume this is similar to #25023, if the OP makes heavy use of mixins.

Seems like this is extremely nontrivial to fix. @weswigham may have some time to review this.

Any updates on this? Still present in 3.1.6

authors: DanielRosenwasser SamuraiJack samura sheetalkamat taoqf weswigham


text:
Type inference for maps inside generic functions

I'd like type inference inside generic functions to infer precise types for elements of maps.
In the screenshot below, you can see that TS does not infer that val is a number. I'm proposing to improve the type inference so that the types will be inferred correctly.

TypeScript Version:  3.4.0-dev.201xxxxx

Search Terms: maps generic inference
Code
type Names = 'foo' | 'bar';

function func<T extends string>(arg: T) {
  const a: { [key in T]?: number } = {};
  const val = a[arg];

  // I'm expecting `val`` to be of type number here
  type ShouldBeNumber = typeof val;

  return val;
}

// `val`` is number here
const val = func<Names>('foo');
type IsNumber = typeof val;

Playground Link: https://www.typescriptlang.org/play/#src=type Names %3D 'foo' | 'bar'%3B

function func<T extends string>(arg%3A T) {
  const a%3A { [key in T]%3F%3A number } %3D {}%3B
  const val %3D a[arg]%3B

  %2F%2F I'm expecting `val`` to be of type number here
  type ShouldBeNumber %3D typeof val%3B

  return val%3B
}

%2F%2F `val`` is number here
const val %3D func<Names>('foo')%3B%0D%0Atype%20IsNumber%20%3D%20typeof%20val%3B%0D%0A
Related Issues:  no, but I'm probably not using the right keywords

Hi @domoritz, it is actually number.
{ [key in T]?: number; }[T] resolves to number.
The playground is showing you how it is actually resolving it. Typescript keeps this information till it is not needed (i.e. within the function scope.) Any type checking that happens will be with number only.
Or if you want you can use a Map directly.
type Names = 'foo' | 'bar';

function func<T extends string>(arg: T) {
  const a = new Map<T, number>();
  const val = a.get(arg);

  // ShouldBeNumber is number here.
  type ShouldBeNumber = typeof val;

  return val;
}

(All of this is assuming that you have strictNullChecks turned off. When you turn it on, number will become number | undefined)

Ahh, I see. Thanks!

authors: azizhk domoritz


text:
Compile-on-save not resolving macros

Hi,
I have the following settings.
On the "Build" settings page I have

On the "TypeScript Build" settings page I have

When I build the whole project, things work correctly and the output is written to bin.
However, compile-on-save writes the output to a folder called $(OutDir).

Looks a bit like https://github.com/Microsoft/TypeScript/issues/4109

Ah, yes, thanks... looks like a duplicate. Leaving it open for the moment as it works on build but fails on compile-on-save.

Incidentally, writing bin in the box (instead of $(OutDir) does fix the problem, but then we have the output directory hard-coded in two places.

That is a dupe of  #4109. @paulvanbrenk is looking into it.

authors: DickvdBrink NoelAbrahams mhegazy


text:
error TS17004: Build: Cannot use JSX unless the '--jsx' flag is provided.

C:\WINDOWS\Microsoft.NET\Framework\v4.0.30319\MSBuild.exe "D:\Projects\FooProject\Foo.sln"
When I run this command I am getting "Build: Cannot use JSX unless the '--jsx' flag is provided." errors.
If I build solution from VS 2013 it is fine, am I missing any parameter to pass into msbuild for TypeScript specific?

You should be able to set this in the project properties page, or in your tsconfig.json (depending on which you're using)

For commandline options see https://github.com/Microsoft/TypeScript/wiki/Compiler-Options, these also map to tsconfig.json settings
For MSBuild projects, all these properties have a mapping to MSBuild properties. you can find the mapping in https://github.com/Microsoft/TypeScript/wiki/Setting-Compiler-Options-in-MSBuild-projects

I have following settings;

False
False
react

According to link you supplied;
--jsx	TypeScriptJSXEmit should be working fine. But msbuild still gives this error.

tsconfig is not supported in VS2013. so that is not relevant to this discussion. can you share your project file? i am interested in the relative location of your PropertyGroup and the import to Microsoft.TypeScript.targets.

Hello,
Here is all related tags with my webproject.csproj
<Project ToolsVersion="12.0" DefaultTargets="Build" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
  <Import Project="$(MSBuildExtensionsPath32)\Microsoft\VisualStudio\v$(VisualStudioVersion)\TypeScript\Microsoft.TypeScript.Default.props" Condition="Exists('$(MSBuildExtensionsPath32)\Microsoft\VisualStudio\v$(VisualStudioVersion)\TypeScript\Microsoft.TypeScript.Default.props')" />
  <PropertyGroup>
   <Configuration Condition=" '$(Configuration)' == '' ">Debug</Configuration>
    <TypeScriptToolsVersion>1.7</TypeScriptToolsVersion>
	 </PropertyGroup>
	  <ItemGroup>
    <TypeScriptCompile Include="JavaScript\Controllers\CategoryNews.ts" />
    <TypeScriptCompile Include="JavaScript\Controllers\NewsCategories.ts" />
	  </ItemGroup>

	<PropertyGroup Condition="'$(Configuration)' == 'Debug'">
    <TypeScriptSourceMap>False</TypeScriptSourceMap>
    <TypeScriptNoEmitOnError>False</TypeScriptNoEmitOnError>
    <TypeScriptJsxEmit>react</TypeScriptJsxEmit>
  </PropertyGroup>

  <Import Project="$(MSBuildExtensionsPath32)\Microsoft\VisualStudio\v$(VisualStudioVersion)\TypeScript\Microsoft.TypeScript.targets" Condition="Exists('$(MSBuildExtensionsPath32)\Microsoft\VisualStudio\v$(VisualStudioVersion)\TypeScript\Microsoft.TypeScript.targets')" />

  </Project>

what version of TS are you using? This project seems to be working fine for me on the latest: https://github.com/Microsoft/TypeScript/releases/tag/v1.8.7

OK, something weird is happening...
So if I run build from vs 2013 folder:
Build succeeded.
    0 Warning(s)
    0 Error(s)

Time Elapsed 00:00:24.93

C:\Program Files (x86)\MSBuild\12.0\Bin>

But if I run from "C:\Windows\Microsoft.NET\Framework\v4.0.30319" I am getting error at the first post.
I do not mind using build.exe under 12.0\Bin but the problem happens when I publish this project on Azure.
Please see related question at:
http://stackoverflow.com/questions/35473168/azure-website-cannot-register-typescriptbuildconfigurations-via-kudu

is there a sample project we can look at?

Closing for now. please reopen if you have a project we can look at.

I can reproduce this on a fresh VS project. I cannot compile a React project because the TS targets are trying to execute and not looking at the JSX option in my tsconfig. It will work if I remove all the targets and compile manually, but VS will add the targets back as soon as I add a new TS file to the project.
ReactVsTest.zip
Versions
Microsoft Visual Studio Community 2015
Version 14.0.25431.01 Update 3
Microsoft .NET Framework
Version 4.6.01586

Installed Version: Community

Visual Basic 2015   00322-20000-00000-AA140
Microsoft Visual Basic 2015

Visual C# 2015   00322-20000-00000-AA140
Microsoft Visual C# 2015

Visual C++ 2015   00322-20000-00000-AA140
Microsoft Visual C++ 2015

Windows Phone SDK 8.0 - ENU   00322-20000-00000-AA140
Windows Phone SDK 8.0 - ENU

Application Insights Tools for Visual Studio Package   7.10.01020.1
Application Insights Tools for Visual Studio

ASP.NET and Web Tools 2015.1   14.1.20624.0
ASP.NET and Web Tools 2015.1

ASP.NET Web Frameworks and Tools 2012.2   4.1.41102.0
For additional information, visit http://go.microsoft.com/fwlink/?LinkID=309563

ASP.NET Web Frameworks and Tools 2013   5.2.40314.0
For additional information, visit http://www.asp.net/

Azure App Service Tools v2.9   14.0.20316.0
Azure App Service Tools v2.9

Bundler & Minifier   1.0.21
Adds support for bundling and minifying JavaScript, CSS and HTML files in any project.

Common Azure Tools   1.8
Provides common services for use by Azure Mobile Services and Microsoft Azure Tools.

DataFactoryProject   1.0
Microsoft Data Factory Package

JavaScript Language Service   2.0
JavaScript Language Service

JavaScript Project System   2.0
JavaScript Project System

JetBrains ReSharper Ultimate 2016.2    Build 106.0.20160818.163633
JetBrains ReSharper Ultimate package for Microsoft Visual Studio. For more information about ReSharper Ultimate, visit http://www.jetbrains.com/resharper. Copyright © 2016 JetBrains, Inc.

Microsoft .NET Core Tools (Preview 2)   14.1.20624.0
Microsoft .NET Core Tools (Preview 2)

Microsoft Azure Data Factory Node Node   1.0
Azure Data Factory extension for Visual Studio Server Explorer.

Microsoft Azure HDInsight HQL Service   2.0.6000.0
Language service for Hive query

Microsoft Azure HDInsight Tools for Visual Studio   2.0.6000.0
An integrated development environment for HDInsight application development.

Microsoft Azure Mobile Services Tools   1.4
Microsoft Azure Mobile Services Tools

Microsoft Azure Tools   2.7
Microsoft Azure Tools for Microsoft Visual Studio 2015 - v2.7.30818.1601

Microsoft Azure Tools   2.8
Microsoft Azure Tools for Microsoft Visual Studio 2015 - v2.8.40211.2

Microsoft Azure Tools   2.9
Microsoft Azure Tools for Microsoft Visual Studio 2015 - v2.9.40323.3

Node.js Tools   1.1.31117.00
Adds support for developing and debugging Node.js apps in Visual Studio

Node.js Tools - Profiling   1.1.31117.00
Profiling support for Node.js projects.

NuGet Package Manager   3.5.0
NuGet Package Manager in Visual Studio. For more information about NuGet, visit http://docs.nuget.org/.

PreEmptive Analytics Visualizer   1.2
Microsoft Visual Studio extension to visualize aggregated summaries from the PreEmptive Analytics product.

Rebracer   1.0
Saves editor formatting settings as part of each solution.

SQL Server Data Tools   14.0.60519.0
Microsoft SQL Server Data Tools

TechTalk SpecFlow   2015.1
TechTalk SpecFlow - Binding business requirements to .NET code, http://www.specflow.org
Copyright © 2009–2013 TechTalk

TypeScript   2.0.6.0
TypeScript tools for Visual Studio

Typewriter   1.8.1
Typewriter generates TypeScript files from c# code files using TypeScript Templates. This allows you to create fully typed TypeScript representations of server side API that automatically updates when you make changes to your c# code.

Visual Studio Tools for Apache Cordova   Update 10
Visual Studio Tools for Apache Cordova

Visual Studio Tools for Unity   2.1.0.0
Visual Studio Tools for Unity

Visual Studio Tools for Universal Windows Apps   14.0.25420.01
The Visual Studio Tools for Universal Windows apps allow you to build a single universal app experience that can reach every device running Windows 10: phone, tablet, PC, and more. It includes the Microsoft Windows 10 Software Development Kit.

Web Compiler   1.11.319
Compiler for LESS, Sass and CoffeeScript files

Web Essentials 2015.3   3.0.235
Adds many useful features to Visual Studio for web developers. Requires Visual Studio 2015

Windows Installer XML Toolset   3.10.2.2516
Windows Installer XML Toolset version 3.10.2.2516
Copyright (c) Outercurve Foundation. All rights reserved.

Xamarin   4.1.0.530 (2e39740)
Visual Studio extension to enable development for Xamarin.iOS and Xamarin.Android.

Xamarin.Android   6.1.0.71 (4e27558)
Visual Studio extension to enable development for Xamarin.Android.

Xamarin.iOS   9.8.0.323 (39ebb77)
Visual Studio extension to enable development for Xamarin.iOS.

@paulvanbrenk can you take a look.

The build action for the tsconfig.json has to be set to Content, not None. How did you add that file?

I added a TS/JS file and renamed it to JSON. It's usually faster for me to
do that via right click menu than searching for the item in the Add Item
dialog. Who knew that made a difference?
On Mon, Nov 7, 2016, 15:40 Nathan Shively-Sanders notifications@github.com
wrote:

[image: capture]
https://cloud.githubusercontent.com/assets/293473/20077034/90e0f166-a4ef-11e6-9ee7-e45d9cb955f7.PNG
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/Microsoft/TypeScript/issues/7394#issuecomment-258971164,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAiaa3kJH4UK8CJO_IYYHc7-ffhZyyfMks5q75q6gaJpZM4Hpsj-
.

@kamranayub can you please try to build same project from "C:\WINDOWS\Microsoft.NET\Framework\v4.0.30319\MSBuild.exe" "C:\yourSolution.sln"
I am just wondering you will be getting same error as me.

authors: RyanCavanaugh kamranayub mhegazy paulvanbrenk reyou sandersn


text:
Fix broken test

From https://github.com/Microsoft/TypeScript/pull/18508.

@amcasey,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

authors: amcasey msftclas


text:
When contextual type doesnt find property in unit type, use the index signature from unit type(fix the incorrectly used union type to get the signature)

Fixes #27949

Build failure seems unrelated; it's happening elsewhere. I'm guessing tslint updated or something?

authors: sheetalkamat weswigham


text:
Enable ability to customize VFSForGit Upgrade

This issue tracks the different parts of the work to make VFSForGit upgrade extensible. This extensibility can be used by organizations to custom the VFSForGit upgrade process to meet their specific requirements.
Design Doc
#547
Initial changes to enable feature
#674
TODO - Required

[ ] Verify Nuget Package signature
[ ] Limit access to temp file directories
[ ] Limit access to GVFS.Config
[ ] Anonymous polling for available updates

TODO - Nice to have

[ ] Add concept of "minimum version allowed to upgrade from"

Completed Pull Requests
Associated issues
#704

Other nice to haves:

Update unit tests to validate that VFS4G code that writes new version to a marker file is writing the expected version.  Currently it only validates that VFS4G has written something.

Cleanup PhysicalFileSystem and IPlatformFileSystem.  Their interaction (and how they differ) is not clear, and the more we add to them the more confusing it becomes.

Switch from calling Exit to letting unhandled exceptions bring down the process.  Some investigation is required to makes sure that all native\background threads with unhandled exceptions will crash the VFS4G process.

Cleanup PhysicalFileSystem.DeleteDirectory it currently just calls RecusiveDelete, so why have both?

Update upgrade functional tests to use Test.GVFS.Upgrade folder rather than GVFS.Upgrade

Cleanup gvfs log so that file paths are all aligned in the same column.  Currently it looks like this:
Most recent log files:
  clone     : E:\repo6\.gvfs\logs\gvfs_clone_20181024_094528.log
  mount     : E:\repo6\.gvfs\logs\gvfs_mount_verb_20190130_140733.log
  prefetch  : E:\repo6\.gvfs\logs\gvfs_prefetch_20181024_094548.log
  dehydrate : None
  repair    : E:\repo6\.gvfs\logs\gvfs_repair_20181105_163128.log
  service   : C:\ProgramData\GVFS\GVFS.Service\Logs\gvfs_service_20190207_143020.log
  productupgrade: C:\ProgramData\GVFS\GVFS.Upgrade\Logs\gvfs_productupgrade_process_20190207_144030.log

@jrbriggs FYI - This is the work item I've been using for collecting upgrader follow up work items.

@wilbaker I have spun out #755 #756 #757 #758 #759 #760 as carry-over work. I'm going to close this issue since it was tracking the work delivered in #748.

authors: jamill jrbriggs wilbaker

repo: Microsoft/VFSForGit


text:
SplashScreen Example Not Working on Mobile Emulator

Hi,
The SplashScreen example does not work on the latest mobile emulator with Visual Studio 2015 Update 1. Could someone get the sample fixed?
Thanks!
Weidong Shen

Please be more specific what you mean by "does not work".

authors: WeidongShen oldnewthing

repo: Microsoft/Windows-universal-samples

license: mit

license_source: bigquery


text:
StreamSocket listener

Hi,
I try to create UWP app on javascript that received third party application that will send data via Web Socket
So I download sample on StreamSocket ( https://github.com/Microsoft/Windows-universal-samples/tree/master/Samples/StreamSocket )
The project is work as it should be create a Listener , connect and send data.
however if I move the code that connect and send data to another project and run 2 project , one to be a listener and another project to send data , the one that do send data is throw exception that cannot connect to server. not sure what I did wrong there.
Thank you,
Thanawut

The issue you are running into is not about a sample that is not working. As you noted, the sample itself works fine. You can open a support case with our Developer Support team who can further help with the specific problem you are experiencing. Please use these steps below for further help:

Visit http://aka.ms/storesupport and sign-in with your Microsoft account
Under the “App Development” section choose "Windows 10 universal app development", then choose the appropriate problem type and category to get engaged through a formal support channel.

authors: ThanawutZiios oldnewthing


text:
Using Transform2DEffect with BackdropBrush

Issue Type

[ ] Bug Report
[ ] Feature Request
[x] Sample request
[ ] Documentation issue or request
[ ] Other – Please describe:
Current Behavior

System.ArgumentException
HResult=0x80070057
Message=Falscher Parameter.
Invalid argument to parameter value. Backdrop brushes cannot be transformed.
Source=Windows
StackTrace:
at Windows.UI.Composition.CompositionEffectBrush.SetSourceParameter(String name, CompositionBrush source)
at OffsetEffectTest.OffsetBrush.OnConnected() in C:\temp\OffsetEffectTest\OffsetEffectTest\OffsetBrush.cs:line 37
Expected Behavior

I'm trying to make a brush that takes a BackdropBrush, makes offset in X coordinate and combines the result with the original BackdropBrush. So it like same image doubled and shifted on X.
But I get the Exception that Transform2DEffect (win2d) can't be used with BackdropBrush. How do I make transformation to the BackdropBrush?
Your Environment

SDK #:  17134
Operating System build # :  17134.112
Visual Studio Version # : 15.7.4

@nesherhh Sorry I didn't answer this sooner.  We have a very specific solution we use for optimizing BackdropBrush and could not guarantee good results with transforms so we unfortunately prevent that case.  Do you have a sketch or comp of what you want these effects to look like?  There could be another option using something like blend modes and opacity if you don’t require effects drawn on contents underneath a visual.

Closing due to inactivity, please re-open if needed.

authors: krenner nesherhh

repo: Microsoft/WindowsCompositionSamples


text:
Add color box to the hex codes

Is your feature request related to a problem? Please describe.
It should be easier to verify you've got the right colors and know how to act on it.
Make it easier to see/understand color contrast problems. Sometimes what the color contrast tool is testing isn't what appears on the page.  It would be good to clearly show a box with the background/foreground color in the message.
Might be also useful to remind folks that there may be additional testing required if there are gradients or background images.
Describe the desired outcome
There is a good description but most of haven't internalized the hex codes to know what foreground color: #00836d & background color: #fbf5ee look like.
You could also possibly suggest colors like would meet the requirements like http://contrast-finder.tanaguru.com/
Additional context

Thanks for the Suggestion @mgifford we will keep this feature request in our backlog.

@ferBonnin @mgifford This is on canary now.

awesome!
@mgifford please let us know what you think!

That looks great now, Thanks!

authors: ferBonnin mgifford smoralesd

repo: Microsoft/accessibility-insights-web


text:
Add support for Windows Server 2019

The Windows Server Core Docker image is GA now  at mcr.microsoft.com/windows/servercore:1809 - it would be great to get ASP.NET images for 1809 (we already have them for ASP.NET Core via PR 719).

I'm with you @sixeyed , actually I'm waiting, and ready to test my apps on it.
Please put it at Docker Hub too!

We have the PR staged at https://github.com/Microsoft/aspnet-docker/tree/RS5update and are working on bootstrapping new infrastructure to publish to Windows Server 2019

Excellent, looking forward to download it once it's ready

Any ETA on this?
Thanks

Thanks a lot!! I've been refreshing docker hub everyday checking for it to be available :smile:

Any ETA on this?
Thanks

it's here: docker image pull mcr.microsoft.com/dotnet/framework/aspnet:4.7.2-windowsservercore-ltsc2019

Still not on docker hub yet

@Mozanrath The images are already live.
As you may have noticed in the docker pull command, the image is now being served from the Microsoft Container Registry (MCR). Starting with Windows Server 2019 and going forwards, all new tags will be published exclusively to MCR. All existing tags have been syndicated from DockerHub to MCR.
If your existing Dockerfile begins by specifying microsoft/iis as the base layer as shown below-
FROM microsoft/aspnet:4.7.2-windowsservercore-ltsc2016
…

Our guidance is to move to adopting MCR as your base layer. You should change your Dockerfile to what’s shown below-
FROM mcr.microsoft.com/dotnet/framework/aspnet:4.7.2-windowsservercore-ltsc2016
…

As part of this transition, we are only changing the source from where you download your images to MCR. DockerHub continues to be the preferred medium for container image discovery.
Take a look this blog post for the motivation behind this change.

Where can we see a list of images on mcr? Is there a web UI like docker hub?

@rotata Could you help answer with that question?

Starting with Windows Server 2019 and going forwards, all new tags will be published exclusively to MCR. All existing tags have been syndicated from DockerHub to MCR.

Hey @shirhatti, or @rotata, how can I list or explore all images and tags from mcr.microsoft.com?

@sanguedemonstro as I've read elsewhere, Docker Hub is still the place to explore/search images and mcr is just a place where they get pulled from. It's kind of weird and unexpected, but makes sense in a way

@biiiipy from ltsc2019 on, tags are no longer in the docker hub. So now it is hard to know if there is any variant of ltsc2019, like other languages as pt-BR... Maybe there is but who knows?!

authors: Mozanrath biiiipy pbering radyz sanguedemonstro shirhatti sixeyed

repo: Microsoft/aspnet-docker


text:
Fix: redisCacheLocation is no longer used by the referenced template

See change history of https://github.com/Azure/azure-quickstart-templates/blob/master/101-redis-cache/azuredeploy.json - now it deploys to the resource group location, in line with some of their recommended best practices: "Do not use a parameter to specify the location. Use the location property of the resourceGroup instead. By using the resourceGroup().location expression for all your resources, the resources in the template will automatically be deployed in the same location as the resource group."

Hi @TimLovellSmith, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, MSBOT;

@TimLovellSmith : Thanks for your contribution to the Azure documentation! The author, @steved0x, has been notified to review your proposed change.

@TimLovellSmith Thank you for this contribution.

#sign-off

authors: PRmerger TimLovellSmith msftclas steved0x

repo: Microsoft/azure-docs


text:
Add e2e test for plugin archetype

Add e2e test for plugin archetype, for issue #78

@pragnagopa  Please help take a look when you have time.

repo: Microsoft/azure-maven-archetypes


text:
Fresh Install shows Black Screen without any icons

Azure Data Studio Version:

Version 1.2.4
Commit 1ebfd0235690ad044ed2874a02e65188f5fea01c
Date 2018-11-02T21:50:52.634Z
VS Code 1.26.1
Shell 2.0.9
Renderer 61.0.3163.100
Node 8.9.3
V8: 6.1.534.41
Architecture x64
Steps to Reproduce:
Default installation on Microsoft Windows 10 Pro [Version 10.0.16299.371].
The inner screen of the Azure Data Studio is completely black.

@kburtram Yes, full uninstall and reinstall. Same issue with versión 1.2.4.
I have uninstalled version 1.2.4 and installed the actual version 1.4.5. The issue has been corrected. Thanks a lot!

@MarianoKovo great to hear it's working now!  Not sure exactly what changed for this area.  I'll close the issue now.  Please let us know if the issue reoccurs.

authors: MarianoKovo kburtram

repo: Microsoft/azuredatastudio


text:
Results are being displayed in 2 tables

Issue Type: Bug
Azure Data Studio Version: 1.3.9
Open a new query window connected to a DB, and run a single SQL select command to display data from one database table.
The "Results" window has 2 tables showing the same data.
Rerunning the query a second time fixes the issue and I see only one table in the "Results" window.
Azure Data Studio version: azuredatastudio 1.3.9 (cacf0777c747046af6839de3688d709b10ef9fca, 2019-01-14T23:30:09.442Z)
OS version: Windows_NT x64 10.0.16299

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-3770 CPU @ 3.40GHz (8 x 3392)

GPU Status
2d_canvas: enabledchecker_imaging: disabled_offflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onnative_gpu_memory_buffers: disabled_softwarerasterization: unavailable_softwarevideo_decode: enabledvideo_encode: enabledwebgl: enabledwebgl2: enabled

Memory (System)
31.81GB (14.08GB free)

Process Argv
C:\Program Files\Azure Data Studio\azuredatastudio.exe

Screen Reader
no

VM
0%

Extensions (4)

Extension
Author (truncated)
Version

agent
Mic
0.35.2

profiler
Mic
0.5.1

server-report
Mic
0.1.3

sql-search
Red
0.2.1

(1 theme extensions excluded)

Most likely, running the query for second time doesn't fix the issue.

This is fixed in the master (and the latest insiders builds) and the fix will be included in the Feb release planned for this week.

authors: Diganth kburtram vidhyasagarreddy


text:
cleemullins:Application Insights build fixes

Add Microsoft.Bot.Builder.ApplicationInsights assembly.
Fix unused references.
Fix the namespaces.

Pull Request Test Coverage Report for Build 44941

0 of 0   changed or added relevant lines in 0 files are covered.
7 unchanged lines in 3 files lost coverage.
Overall coverage remained the same at 55.792%

Files with Coverage Reduction
New Missed Lines
%

/libraries/Microsoft.Bot.Builder.ApplicationInsights/BotTelemetryClient.cs
1
98.85%

/libraries/integration/Microsoft.Bot.Builder.Integration.ApplicationInsights.Core/TelemetryBotIdInitializer.cs
3
87.8%

/libraries/integration/Microsoft.Bot.Builder.Integration.ApplicationInsights.Core/ServiceCollectionExtensions.cs
3
85.11%

Totals

Change from base Build 44913:
0.0%

Covered Lines:
5500

Relevant Lines:
9858

💛  - Coveralls

authors: coveralls daveta

repo: Microsoft/botbuilder-dotnet


text:
Analytics Blade doesn’t track Skype for business.

This is unlikely a node-specific issue, but I'm moving it here from services (https://github.com/Microsoft/BotFramework-Services/issues/13) due to this being an easier location for tracking and reporting:
Original:
I have bots working with the Bot Framework v3 and v4 through Web, Skype for Business, MS Teams and Slack. In the Azure Portal, in the Bot service I go to analytics and see usage data but not for Skype for Business. Also when I query for custom events in App Insights Analytics I only see entries for the other channels.
Is there a problem with that channel? Is there something that has to be done in order to enable it? I didn't see any mention about that in the documentation, and interestingly enough the example screenshot contains a lot of channels but not Skype for business, odd being a Microsoft documentation.

The right place for such an issue is the Microsoft/BotFramework-Services repo. Ping @dandriscoll for updates on that repo.
Closing this one.

authors: nyxsys yochay

repo: Microsoft/botbuilder-js


text:
Extract class declarations into separate files, update project structure

I understand reasoning behind the current state of things.
Preserving history and compatibility with existing forks, etc.
But now, when the next major update is coming, maybe it's time to move on? :)
One-class-per-file approach brings so much more satisfaction compared to the current monstrous all-in-one files with 2K+ lines of code wrapped in multiple regions.
Easier to get the whole picture, easier to edit and navigate, easier to detect outdated/duplicated/unused stuff, easier to understand for the newcomers, less conflicts, etc. etc.
Of course, this can be considered as a personal preference, but... maybe I'm not alone? :)

That's a pretty reasonable request.  I've been wanting to do this myself for exactly the reasons you outline, but I've avoided it wanting to preserve file history (and also anyone with outstanding code changes/forks of ClrMD are going to have a tough time).
You are right, that with the large influx of changes it's a good time to do this.  I'll see what I can do.

Done.

tyvm! :)

authors: isakiev leculver

repo: Microsoft/clrmd


text:
UWP target Windows Store appxupload

vcpkg install cppwinrt:x64-uwp cppwinrt:arm-uwp cppwinrt:x86-uwp seems to triplicate headers. Will later releases refactor them?
https://github.com/Microsoft/cppwinrt/blob/master/Getting Started.md should cover applying something like https://msdn.microsoft.com/en-us/library/windows/desktop/hh446767(v=vs.85).aspx for making appxupload, specially for builds using alternate IDE like VSCode, for distributing through the Windows Store.

(1) While I know of vcpkg, I'm not familar with how it works. Ideally, you shouldn't get three copies of the headers when installing for three architectures. I would raise this as an issue in the vcpkg repository so they can figure out a solution.
(2) I'm not sure what you are asking here. The link you provide talks about MakeAppx.exe, which doesn't apply to source code such as cppwinrt. We also do not plan on distributing the source code via the Windows Store. This GitHub repository is our distribution vehicle. Happy to respond further if you can clarify the question.

Using Visual Studio is an overkill considering XAML is unneeded. When building an app consuming C++/WinRT rather than C++/CX for (the app's, and definitely not the GitHub C++/WinRT source repository) distribution, is something like https://msdn.microsoft.com/en-us/library/hh561383.aspx needed prior to making package (assuming MakeAppx is the next step of the development cycle)?

Regardless of what library(ies) you use (C++/WinRT, Boost, etc.), when you build an application that you want to distribute via the Windows Store, you need to package the app appropriately for upload to the Windows Store.
Clearly, using Visual Studio makes this process lots easier as it has built-in functionality to do this packaging. But if you are not using Visual Studio, you would need to perform this packaging some other way (makefiles, batch scripts, etc.)

For C++/CX, the Visual C++ compiler cl.exe required the /ZW switch when making appxupload. (bad example, as there might be whole lot of others, that Visual Studio keeps track of for us). Eventually C++/WinRT will get deeper IDE integration with Visual Studio with it's own UWP porject templates. In the meantime, should /ZW, as an example, be used with C++/WinRT as well, or was it for legacy C++/CX apps only?

That's up to you. You can use /ZW or not use /ZW when include the C++/WinRT library.
Cl.exe requires the /ZW switch to enable the Windows Runtime extensions (ref class, ref new, hats, etc.). The /ZW switch has nothing to do with the remainder of the build process. It's a C++ compiler-only switch.

Wrong. TIL, leaving it gives error APPX0702 . Searching web led to an unofficial explanation url tl;dr: Without /ZW, no .winmd making clean rebuild fail, i. e. console or desktop program using Store ready WinRT API, rather than actual package for deployment to devices is obtained.

authors: BrentRe VSChawathe

repo: Microsoft/cppwinrt


text:
DevKit SDK 1.3.7 Release Candidates

[x] #785 Display more useful info for default firmware
[x] #821 Memory usage API bug fix
[x] #828 Add sleep mode for power saving
[x] #831 Add HTTPClient document
[x] #832 Remove sdk dependency from installation script
[x] #834 [User Feedback] Improve error message for serial port access denied
[x] #835 The rule of temperatureAlert is wrong
[x] #839 The size of .bin file increased a lot after enable DPS

Due to some underlying RTX issue, we have to postpone this release.

repo: Microsoft/devkit-sdk


text:
Output of exec'ed things corrupts non-ASCII-range characters on .NET Core

On machine with CurrentUICulture=fr-FR:
c:\temp>type test.proj
<Project>
  <Target Name="Repro">
    <Exec Command="dir" />
  </Target>
</Project>

C:\temp>c:\src\cli\artifacts\win10-x64\stage2\dotnet.exe msbuild
Microsoft (R) Build Engine version 15.3.378.6360 pour .NET Core
Copyright (C) Microsoft Corporation. Tous droits réservés.

   Le volume dans le lecteur C n'a pas de nom.
   Le num?ro de s?rie du volume est 7893-1CCC

   R?pertoire de C:\temp

  08/06/2017  10:57    <DIR>          .
  08/06/2017  10:57    <DIR>          ..
  24/05/2017  15:54    <DIR>          artifacts
  24/05/2017  18:07    <DIR>          packages
  02/06/2017  12:54    <DIR>          qqq
  08/06/2017  10:57                87 test.proj
                 1 fichier(s)               87 octets
                 5 R?p(s)  169?783?300?096 octets libres

Notes:

MSBuild's own copyright message renders é correctly, but the output from dir replaces non-ASCII-range characters with ?.
We have test code that launches process and captures their stdout/stderr on .NET Core that does not suffer from this, so it is something about the way MSBuild is doing it.
This does not repro with desktop msbuild, and may not repro on non-Windows (I haven't tried yet).
This repros for ToolTasks as well, not just Exec

@AndyGerlicher @cdmihai This is going to be a blocker for CLI localization. Please triage appropriately.

Conveniently this is fixed by the same change as #2187. Closing this as a duplicate.
With that change:
C:\temp>C:\cli\artifacts\win10-x64\stage2\dotnet.exe msbuild
Microsoft (R) Build Engine version 15.3.389.3129 pour .NET Core
Copyright (C) Microsoft Corporation. Tous droits réservés.

   Le volume dans le lecteur C n'a pas de nom.
   Le numéro de série du volume est A4FA-05C0

   Répertoire de C:\temp

  20/06/2017  19:02    <DIR>          .
  20/06/2017  19:02    <DIR>          ..
  20/06/2017  19:02                89 test.proj
                 1 fichier(s)               89 octets
                 2 Rép(s)  83 383 787 520 octets libres

authors: nguerrera rainersigwald

repo: Microsoft/msbuild


text:
Copy .mdb files

Copy .mdb files when they are generated by the compiler instead of .pdb files.

Hi @ValMenn, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
The agreement was validated by .NET Foundation and real humans are currently evaluating your PR.
TTYL, DNFBOT;

Also resolves #38

LGTM

authors: ValMenn dnfclas sarajoiner


text:
Attaching to Node process launched with --debug-brk causes Node error

Launching with node debug or node --debug and then attaching works, however when launching a process with node --debug-brk <script> to cause a break on the first line, and then attaching VS via NodeJS Remote Debugging transport, results in the below error in the Node process:
Debugger listening on port 5858
events.js:85
      throw er; // Unhandled 'error' event
            ^
Error: read ECONNRESET
    at exports._errnoException (util.js:746:11)
    at TCP.onread (net.js:559:26)

This is with NodeJS 0.12.7 and NTVS 1.1 RC2.

Some more data: It errors when it disconnects in NodeRemoteEnumDebugProcesses.cs@92
    string request = @"{""command"":""disconnect"",""seq"":1,""type"":""request"",""arguments"":null}";
    request = string.Format("Content-Length: {0}\r\n\r\n{1}", request.Length, request);
    buffer = Encoding.UTF8.GetBytes(request);
    stream.WriteAsync(buffer, 0, buffer.Length, new CancellationTokenSource(5000).Token).GetAwaiter().GetResult();

This occurs just when entering the 'localhost:5858' and clicking 'Refresh' to see the processes in the Attach dialog.
According to the comments just above these lines, sending a disconnect is required though. Need to investigate more...

I'm seeing this now that I've started using the cluster module. I start my application which forks. Then I try to attach to the newly forked process, where the debugger is listening on port 5859, and as you mentioned, when I click 'Refresh' it dies. Do you have any workaround for it? It seems I have to connect the debugger because otherwise the new forked process just sits there waiting for a debugger to connect.

Is there any way to start node with --debug instead of --debug-brk?

This still happens on Node 6, and NTVS 1.3... it doesn't on Node 8 though.

Closing as this works as expected in Node 8, and there is a workaround

authors: billti paulvanbrenk samizzo

repo: Microsoft/nodejstools


text:
prepare run_tests to run multiple tests

Hello!
In this PR I've made some minor adjustments to allow for run_tests to be able to actually run a list of tests, instead of just one-at-a-time.
There are some issues that have arisen/will arise moving forward and I'd like to open a dialogue to see your opinion on how I should go about this.
Firstly, about mocha.grep...
I see now the reason why mocha tests are being run with multiple calls to before() and after() hooks -- each call to run_tests also called mocha.grep, turning a singular test suite containing 10 tests into 10 test suites containing 1 test. As my ultimate goal is to make mocha tests run properly, I would have to either remove the grep call completely (this would mean ALL mocha tests in a file will always run, breaking "Run Selected Tests" functionality) or construct a long grep string containing all selected tests and pass that to the grep call.
Second problem -- recording start and end times:
The approach by NTVS currently is to call RecordStart on the given test case, send mocha the testName and testFile and have mocha grep the one testName out of the provided testFile. Then once that process exits, it's safe to call RecordEnd and record the end time for the test, then repeat.
However, I want to run a list of tests-- in order to do so, I have to provide mocha with the list up front so it can adjust its test suite accordingly. If I'm providing mocha with a list of tests to run up front, we can no longer record accurate Start and End times for those tests. I could try to record the times in mocha.js, but this adds another requirement for the run_tests interface, and might make changes more difficult down the road.
Any guidance is welcome and appreciated. Please let me know if you need me to elaborate on anything written here, hopefully I haven't rambled too much...
Thanks again

Hi @ozyx, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
The agreement was validated by Microsoft and real humans are currently evaluating your PR.
TTYL, MSBOT;

@ozyx Thanks for the work. Good progress overall.
For Mocha, I took and look at their programmatic api and it unfortunately seems poorly designed for this use case. I think you are correct that you'll have to construct a grep string for mocha. Starting from a list of tests cases, the flow would probably look something like this:

Group tests cases by file.
For each file:

Create a new instance of mocha.
Create a grep string by joining together all the test names. This would be something like:

// https://developer.mozilla.org/en/docs/Web/JavaScript/Guide/Regular_Expressions
function escapeRegExp(string){
   return string.replace(/[.*+?^${}()|[\]\\]/g, '\\$&'); // $& means the whole matched string
 }

var testGrepString = '^(' + testCases.map(function(testCase){
    return escapeRegExp(testCase.title)
}).join('|') + ')$';

call Mocha.grep
call Mocha.addFile
call Mocha.run

This adds extra work because you now have to worry about managing a run of Mocha for each file, but  this is the only way I can see to properly support this.

For the timing, you'll want to move the execution time calculation from the C# code into test runner JavaScript implementations themselves. This would be another property on the result object.
In the case of Mocha, in the test event, set a startTime property on the result using Date.now(). Then in the test end event, compute the taken time using startTime and Date.now(). A similar approach should work for the tape and the export runners.
Let me know if that makes sense.

authors: mjbvz msftclas ozyx


text:
#584 VS2015 crashes if change code while debugging w/ Node.js v5

v8 has recently removed the "stack_update_needs_step_in" property in
responses. It looks like it always returned the same value as
"stack_modified" anyways, so go ahead and ignore the property altogether.
https://codereview.chromium.org/1247363002/diff/1/src/liveedit-debugger.js

Yes, I verified it with 0.10.20 and 4.1.2 too and have yet to run into a case when the values aren't the same - I can try a few other configs as well. 0.10.33 and 0.12.7 would be good to try too

Yeah, those would be good, as some tools install (or point to) those specific versions. If they work, then :+1:   Thanks :smile:

authors: billti mousetraps


text:
Do not inject targetversion when using "pxt build"

Background: applying upgrade rules to Adafruit bundled projects leads to stack overflow issues. Upgrade rules should not be applied to bundled packages.

[ ] inject targetversion when saving project
[ ] log every file write with size

In order to track down what goes on in the build, I've added a lot on every written file. This helps debugging when someone funny happens.

No always on.

Uh, can we put it behind a verbose flag?

Agree with --verbose flag

authors: guillaumejenkins pelikhan riknoll

repo: Microsoft/pxt


text:
Publish coverage reports?

Now that we have Jacoco maybe we can also get a nice badge to display coverage? These are 2 options that I know:

coveralls.io, here is a sample report
codecov.io, here is a sample report

Integration should be straightforward for public Github project that builds using Travis. Though for a multi-project setup codecov seems to be easier.

coveralls integration guide
codecov integration guide

I looked at coveralls since I've used it before, but Gradle projects have no official support so I passed.  Didn't know about codecov.io, I'll take a look - thanks!

authors: benjamin-bader hidroh

repo: Microsoft/thrifty


text:
Ignore npm@5 package-lock.json

Currently running npm test in DefinitelyTyped repo with npm version 5 results in generating package-lock.json for definitions having package.json, e.g. multer-s3. Because of that npm test fails with:

Error: Directory /../DefinitelyTyped/types/multer-s3 has unused file package-lock.json
at /.../DefinitelyTyped/node_modules/types-publisher/src/lib/definition-parser.ts:348:11
at Generator.next ()
at fulfilled (/.../DefinitelyTyped/node_modules/types-publisher/bin/lib/definition-parser.js:4:58)

I'm having the same issue. Any luck with resolutions?

@nik-john I submitted #351 which fixes this issue.

authors: mxl nik-john

repo: Microsoft/types-publisher


text:
TabLib wants CreateFile2 function

Win7 64-bit, Visual Studio 2017. TagLib installed with command:
./vcpkg install taglib:x64-windows-static

When using TagLib in VC2017 project errors happens:
The procedure entry point CreateFile2 could not be located in the dynamic link library KERNEL32.dll."

This is Windows 8 and higher function, not suppotred even under Win7.
The only reference to CreateFile2 is in tfilestream.cpp:
#if defined(_WIN32_WINNT) && (_WIN32_WINNT >= 0x0602)
    return CreateFile2(path.wstr().c_str(), access, FILE_SHARE_READ, OPEN_EXISTING, NULL);
#else
    return CreateFileW(path.wstr().c_str(), access, FILE_SHARE_READ, NULL, OPEN_EXISTING, 0, NULL);
#endif

if _WIN32_WINNT is not directly, WinSDK defines it to maximum value.
The solution is to set _WIN32_WINNT to value lower then 0x600 value when configuring.

если поможет, то наверно надо так

If it helps, you probably need something like this

https://msdn.microsoft.com/en-us/library/6sehtctf.aspx

Looks like we have a new pivot for triplets over here :)

@zabulus, what do you mean? The source was this article.

I guess i can fix it.

authors: Voskrese evpobr zabulus

repo: Microsoft/vcpkg


text:
Improve mongo client port.

This PR fixed some some small issues record in https://github.com/Microsoft/vcpkg/pull/148:

removed find_program(POWERSHELL powershell)
LIBBSON_DIR uses ${CURRENT_INSTALLED_DIR} instead of ${CURRENT_PACKAGES_DIR}
mongo-cxx-driver directly requires libbson now.

Hi @sdcb, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
The agreement was validated by Microsoft and real humans are currently evaluating your PR.
TTYL, MSBOT;

authors: msftclas sdcb


text:
Added globjects

This pull request adds support for the globjects library by cginternals. https://github.com/cginternals/globjects
Both dynamic and static libraries are built correctly

Hi @mattiascibien, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
We will now validate the agreement and then real humans will evaluate your PR.
TTYL, MSBOT;

@mattiascibien CLA marked as ok, sorry for the confusion, CLA bot was acting weird the last few days!

@alexkaratarakis thanks for your help. Let me know if this requires more work. Works fine for me.

Looks solid!
One minor issue: there are two copies of AUTHORS, VERSION, LICENSE, README.md, on in ${CURRENT_PACKAGES_DIR} and one in ${CURRENT_PACKAGES_DIR}\debug.
Can you move them (one copy) to ${CURRENT_PACKAGES_DIR}\share\globjects\ ? Also, LICENSE is the same as the copyright file which is already there, so no need to have it.
Reason: Upon installation, the files of each package are copied from the packages\ directory over to the  installed\x86-windows\ directory.
Thus, files in the root of a package cannot work, because if two packages have a file like VERSION in the root directory, they will overwrite each other. The files BUILD_INFO and CONTROL are exceptions and we explicitly handle those names in the code. ${CURRENT_PACKAGES_DIR}\share\globjects\ does not have this issue, because the name globjects is "reserved" for this port.
I am guessing the files are automatically placed by the build. If this cannot be suppressed, you can just rename them (or delete them if they are not needed) at the end of the portfile.

I will have a look shortyle... Thanks for the explaination

@alexkaratarakis can you check also the glbinding port as it seem to have the same issue?

You are right, glbinding has the same issue. I will add a check for this.

Thanks for the solid PR!
I have added a check for files present in the package dir and debug dir.
I also went ahead and added code to the glbinding's and globject's portfile that removes the misplaced files so they pass the new vcpkg checks.

authors: alexkaratarakis mattiascibien msftclas


text:
Syntax Colorizer doesn't recognise computation expressions with generic types

Originally opened at CodePlex by ashtonkj
The default syntax highlighter will highlight a computation expression without a generic type parameter, but once a generic type parameter is provided then the syntax highlighter will not colour the computation expression. See the following code for example (In the default Visual Studio dark theme ceBoolBuilder is coloured blue, but ceBuilder<System.DateTimeKind> is not):
type TestCE<'T>() =
    member this.ReturnFrom(value) =
        if System.String.IsNullOrEmpty(value) then
            None
        else
            let typeT = typeof<'T>
            if typeT.IsEnum then
                box (System.Enum.Parse(typeT, value)) |> Some
            else if typeT = typeof<bool> then
                box (bool.Parse(value)) |> Some
            else None

let ceBuilder<'T> = TestCE<'T>()
let ceBoolBuilder = TestCE<bool>()

let exampleIncorrect = ceBuilder<System.DateTimeKind> { return! System.DateTimeKind.Local.ToString() }
let exampleCorrect = ceBoolBuilder { return! "true" }
Image

comments
coza99 wrote Sep 3, 2014 at 3:54 AM [x]
This is also true if the builder function is parameterized. Taking the case from above an example

type TextCE<'T>(name:string) =
..........
let ceBuilder<'T> name = TestCE<'T>(name)

@ashtonkj do you still have the image from when you originally filed this one? Seems like it's broken now: http://namelessinteractive.com/media/Example.png

Hi @latkin. Image attached.Sorry for the delay, just installed windows 10 and broke everything else (not window's fault, driver issue caused me to have to do a clean install).

FWIW this was a known limitation when we implemented this colorization feature.

@dsyme does that mean it won't be changed?

@ashtonkj Not necessarily! It may not be that hard

But would reduce the priority

Closing this as "by design" - perhaps Visual F# Power Tools can do something here.

authors: KevinRansom ashtonkj dsyme latkin

repo: Microsoft/visualfsharp


text:
Partial recovery from Assembly.GetTypes exceptions

@mgoertz-msft points out that VS MEF needn't entirely discard a MEF catalog assembly when Assembly.GetTypes() throws an exception, because ReflectionTypeLoadException.Types actually gives us a subset of the types in the assembly that we can still operate on.

The AssemblyDiscoveryDropsProblematicTypesAndSalvagesOthersInSameAssembly already verifies that VS MEF does this. However, it only verifies it on individual V1 and V2 part discovery modules. It does not verify the combined PartDiscovery class, which doesn't handle this like the others do.

OK, even the combined PartDiscovery class has the right behavior. I'm adding tests to prove it, but it looks like this is a non-issue.

repo: Microsoft/vs-mef


text:
The containers which name begins with $ don't display in VS Code

Repro Steps:

Select and expand one storage account which contains the containers which name begins with $ in Storage Explorer.
Navigate to the same storage account and check whether the containers which name begins with $ display or not in VS Code .

Expect:
The containers beginning with $ display and they are consistent between Storage Explorer and VS Code.
Actual:
The containers which name begins with $ don't display in VS Code.

More info:
Fail to expand the node which only contains the containers which name begins with $ like below.

This is currently by design, but we should make sure it's documented in the README.

It's in the README.

authors: StephenWeatherford v-dantch

repo: Microsoft/vscode-azurestorage


text:
Investigate test failures: Autopep 526 Tests

Windows & macOS for Python 3.4 & 3.5.

Also problematic on Linux!

PEP 526 applies to Python>=3.6

#3555 closes this issue out.

repo: Microsoft/vscode-python


text:
Make editor.snippetSuggestions: bottom the default

I think we should make editor.snippetSuggestions: bottom the default. If I am a user and I see this:

My first reaction is that IntelliSense is stupid and not picking up the valid values. When I change to the setting, I get this:

Which indicates to  me that the editor actually knows what I am doing.
@jrieken @aeschli @egamma fyi

👍

No objections.

How can I revert this strange change to make VSC wonderful again?

Add the following to your settings: "editor.snippetSuggestions": "top"

authors: animanoir bpasero egamma jrieken

repo: Microsoft/vscode


text:
[c#] wrong colorization for unsafe code pointer

hi
please see the attachment, I'm writing unsafe code in c#, but the color for the parameters of pointers is wired, I think this should be a bug.
Thank you

Same problem with Atom (languages-csharp 0.11.0)

This issue was moved to atom/language-csharp#46

Now tracked in https://github.com/OmniSharp/omnisharp-vscode/issues/101


text:
Format using custom keybinding no longer working

VSCode Version: 1.7.1

OS Version: Windows 10 Build 14959.rs_prerelease.161026-1700

Steps to Reproduce:

{ "key": "ctrl+e d", "command": "editor.action.format" }

Use keycombo to format document

This worked in 1.6, stopped working in  @1.7.1.
I can make it work using editor.action.formatDocument, but I would expect the old command also still to work. (Or make it clear to the user they need to replace the old command as it no longer works)

We've updated the command in 1.7.

@rozzzly
It is still listed in the keyboard shortcuts as an available command:
// Here are other available commands:
// - editor.action.format
I agree about not spamming the user with popups for every minor change, but if it has been succeeded by another command, it should just be replaced with the new command.

@CoenraadS I agree, if they disabled it, then it should be removed from the list of available commands. But I guess this is being tracked in #15312 now.

authors: CoenraadS rebornix rozzzly


text:
Changing a selection to the end or beginning of a line while selecting multiple lines behaves wrong

VSCode Version: 1.8.0-insider 40243d1e01f426f54670f3dbaa6b77d18469310d
OS Version: macOS 10.11.6

Steps to Reproduce:

Open a file with multiple lines of text (for simplicity assume 2 lines of text in here)
Place cursor in the middle of line 1
Start selection with Shift + Down (now the text from the start column, line 1 until start column, line 2 is selected, which is as intended)
Now change the selection to the start of line with Cmd + Shift + Left
Selection now goes from start column, line 1 to column 1, line 1 (expected selection: start column, line 1 to column 1, line 2)

This gif should clarify the problem:

Here is the selection I would expect:

This problem appears in different scenarios based on if you started your selection upwards or downwards and if you want to change the selection to the start or the end of a line.

Let's track in #17011

authors: alexandrudima t-sauer


text:
How to publish test results in build step of visual studio online

VSCode Version:2015
OS Version:

Steps to Reproduce:

Visual studio online 2015
Sign in to vs
Create new project
4.add build step with step publish test result

I am trying to publish test results but every time I am getting an error that not test.xml found I  project.
Can you please help me with how to publish test results

Sorry it's a Visual Studio issue while we are Visual Studio Code, please report issues to them :)

Hi Peng Lyu,
Thanks for your reply.
Can you please tell me correct branch to ask this question.
Thanks in advance! !
On 2 Jan 2017 11:36, "Peng Lyu" notifications@github.com wrote:

Sorry it's a Visual Studio issue while we are Visual Studio Code, please
report issues to them :)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Microsoft/vscode/issues/17987#issuecomment-269936846,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AWTB7DWOsKzD_HwG9_FYqp65BIOJWzE6ks5rOJPqgaJpZM4LYtua
.

authors: nipobhsnro rebornix


text:
Add line per line in Git panel

It would be nice to have an equivalent of git add -p.
For example when looking at a file diff, on the left, close to line number have a + symbol to add only that line in staging.

This feature is already supported, although not in the same way as in your example. Just open your diff view, select the line(s) you want to add and use Stage Selected Lines from the menu in the upper right corner:

This is awesome I totally missed it.
Thanks @kaiwood !

@kaiwood on the opposite, can we reset line per line ? For example if I want to keep a bloc somewhere, I'll do it you way but I also have another block (or even a line) that I want to remove.
Can I reset it somewhere ?

It works both ways, yes.
You have to open a diff view for the stage changes here by clicking the file here:

Then simply select the lines you want (you can select multiple lines by tripple-clicking the first line and then alt+tripple-click the additional lines you want). There should now be Unstage Selected Lines in the same menu:

Yes this is for unstaging and it's already great ! But how about a possibility to reset a line ?
Just like a git reset --soft HEAD for only one line (or a group).
It would be available in "Staged Changes" and "Changes" sections. :)

Ah, reset like in "undoing the changes". Misread that, sorry.
So basically a menu item for git reset -p. Looks like this is not supported currently, but might be worth to have. You should absolutely open an issue with a feature request for this 👍

For the record : https://github.com/Microsoft/vscode/issues/19118
Thanks @kaiwood