text:
Unit tests for compas_fab.robots.robot.py

@tetov do you plan to continue on this one? or do you prefer if we take over?

@tetov do you plan to continue on this one? or do you prefer if we take over?
I can see if I can find some time to update these tests, but take over if you want!

Coming back to this PR exactly one year after opening it!
I made these tests quite fancy since I wanted to learn pytest. There's a lot of parametrized tests that ironpython-pytest doesn't understand.
We could either:

Add test parametrization to ironpython-pytest
Rewrite the failing tests
Add a way to skip tests, maybe by marking the test function with a # ipy-pytest: SKIP or something.

I could do either 2 or 3, 1 I leave to you @gonzalocasas ;).

We could either:

Add test parametrization to ironpython-pytest
Rewrite the failing tests
Add a way to skip tests, maybe by marking the test function with a # ipy-pytest: SKIP or something.

I could do either 2 or 3, 1 I leave to you @gonzalocasas ;).

I was checking the tests and they could easily be rewritten to not need this feature from pytest. Eventually I'll add it to ironpython-test, but for now, I'd ask you to go for option 2.

I was checking the tests and they could easily be rewritten to not need this feature from pytest. Eventually I'll add it to ironpython-test, but for now, I'd ask you to go for option 2.

Done! Now there's something with the fixtures though. Multiple failed tests with:
 __________ tests\robots\test_robot.py::test_get_base_frame_w_artist[1] __________
Traceback (most recent call last):
  File "C:\ProgramData\Chocolatey\lib\ironpython\Lib\site-packages\pytest\test_runner.py", line 127, in run
    kwargs[argkey] = FIXTURES[argkey]()
TypeError: panda_robot_instance_w_artist() takes exactly 1 argument (0 given)

Integration test failing with a 404 from compas.get('faces.obj').
=================================== FAILURES ===================================
_______ [doctest] compas_fab.robots.constraints.BoundingVolume.from_mesh _______
119         -------
120         :class:`BoundingVolume`
121             Mesh to define :class:`BoundingVolume` with.
122
123         Examples
124         --------
125         >>> import compas
126         >>> from compas.datastructures import Mesh
127         >>> from compas_fab.robots import BoundingVolume
128         >>> mesh = Mesh.from_obj(compas.get('faces.obj'))
UNEXPECTED EXCEPTION: <HTTPError 404: 'Not Found'>

Integration test failing with a 404 from compas.get('faces.obj').
=================================== FAILURES ===================================
_______ [doctest] compas_fab.robots.constraints.BoundingVolume.from_mesh _______
119         -------
120         :class:`BoundingVolume`
121             Mesh to define :class:`BoundingVolume` with.
122
123         Examples
124         --------
125         >>> import compas
126         >>> from compas.datastructures import Mesh
127         >>> from compas_fab.robots import BoundingVolume
128         >>> mesh = Mesh.from_obj(compas.get('faces.obj'))
UNEXPECTED EXCEPTION: <HTTPError 404: 'Not Found'>

resolved!

The nested fixture issue is now resolved in ironpython-pytest v0.4.0.

Jippie!!

authors: gonzalocasas tetov


text:
Roc confusion matrices in latex now like in rcourses

this is no longer relevant, slides have been chaged in the mean time

source: gharchive/pull-request

authors: KatyFisch fabian-s

license_type: permissive

license_source: github-api


text:
Bump version to 1.8.6

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

authors: conda-forge-linter nehaljwani

repo: conda-forge/go-feedstock


text:
added Alberto as maintainer

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@conda-forge-admin, please rerender

@conda-forge-admin, please rerender

@conda-forge-admin, please update team

@conda-forge-admin, please rerender

This feedstock was created 2 days ago, there is nothing to re-render.

@ocefpaf I just don't get why the staged recipe build on Unix, while now it doesn't. When it got accepted it build on Unix without problems. Hence, I tried to rerender the PR because I wanted it to accept the Unix build.
Again, I haven't changed anything but the team, before it got merged it build on unix, now the unix-build is disabled?

Please drop the py36 part from the skip and re-render. Selecting python version makes no sense here as this doesn’t depend on python. Expect that is causing the issue.

Are we sure it was actually building at staged-recipes?

Yes:
https://circleci.com/gh/conda-forge/staged-recipes/23654?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link
See PR here: https://github.com/conda-forge/staged-recipes/pull/5026 the CI builds all the binaries for Unix and correctly says that for Mac and Win it is disabled.

Ok, I think that has to do with the fact that conda-build-all effectively forces a Python matrix. So even though your recipe does not depend on python, that skip would still be meaningful in that context.

authors: conda-forge-linter jakirkham ocefpaf zerothi

repo: conda-forge/siesta-feedstock


text:
Support encoding on coreos.units

Nah.

source: gharchive/issue

repo: coreos/coreos-cloudinit

license_source: bigquery


text:
Update maintainers list

This is not critical here but we usually conform to a specific commit message format, in short: sybsystem: the change.
For example:
MAINTAINERS: remove eyakubovich; add eyakubovich, tomdee, philips

authors: steveeJ tomdee

repo: coreos/flannel


text:
Update submodule

Ah yeah, also I have to create a pull request using the new libclangmm methods (I have committed the code to eidheim/jucipp before we do this merge.

See #95.

Maybe the absolutely best way to do it is to create the link in #95 so that the new link and the code utilising the new libclangmm methods are merged together.

Closing this pull request, I'll add the link in #95, and it will then be easier to test #95 for us both when it is ready Tomorrow or so.

authors: eidheim zalox

repo: cppit/jucipp

license: mit


text:
replaced the author comment

Awesome.

On Feb 4, 2015, at 17:14, alexam2179 notifications@github.com wrote:
You can view, comment on, or merge this pull request online at:
https://github.com/cst1201-d644/lab1/pull/5 https://github.com/cst1201-d644/lab1/pull/5
Commit Summary
replaced the author comment
File Changes
M Lab1/src/lab1/Pay.java https://github.com/cst1201-d644/lab1/pull/5/files#diff-0 (4)
M Lab1/src/lab1/SalesTax.java https://github.com/cst1201-d644/lab1/pull/5/files#diff-1 (4)
Patch Links:
https://github.com/cst1201-d644/lab1/pull/5.patch https://github.com/cst1201-d644/lab1/pull/5.patch
https://github.com/cst1201-d644/lab1/pull/5.diff https://github.com/cst1201-d644/lab1/pull/5.diff
—
Reply to this email directly or view it on GitHub https://github.com/cst1201-d644/lab1/pull/5.

Looks good.

license: MIT


text:
this should be window

Is there a reason it should be changed to window?
I'm not seeing why that variable would be called window instead of this as it seems to be working in my tests.
Is there a situation where it's breaking?

It fails if video.js and this plugin are used with browserify. this is not window because browserify scopes with a function.

Thanks!


text:
Improve _routines_manipulation

I fixed.

Jenkins, test this please.

Jenkins CI test (for commit c04644ceca1f17d70ea38566ee287cac064cd221, target branch master) failed with status FAILURE.
(For contributors, please wait until the reviewer confirms the details of the error.)

The Jenkins failure
tests.chainer_tests.functions_tests.activation_tests.test_elu.TestELU_use_chainerx_false__chainerx_device_None__use_cuda_true__cuda_device_1__use_cudnn_never__cudnn_deterministic_false__autotune_false__cudnn_fast_batch_normalization_false__use_ideep_never_param_12_{alpha_range=(0.0,  2.0), shape=(3, 2), dtype=<type  'numpy.float16'>}.test_double_backward

is unrelated to the PR.

authors: chainer-ci okuta toslunar

repo: cupy/cupy


text:
Ignore TransitionAborted errors and add didCaptureException hook

LGTM 👍

Hey guys! Thanks for your great work on this.
Do you have a timeframe of when this will be merged and released?

authors: damiencaselli michelegera tchak

repo: damiencaselli/ember-cli-sentry


text:
Added cloud build for unit-tests

/gcbrun

/gcbrun

/gcbrun

/gcbrun

/gcbrun

repo: data-integrations/condition-plugins


text:
Remove E suffix from all tables

this is done!

repo: datadesk/census-data-downloader


text:
Migrate companies page

Ok, moved that to a separate commit

repo: datagovsg/beeline-admin


text:
Fixes ember-runtime.action-handler-_actions deprecation

@locks I assume that mixing in the actions hash now works as expected?

Ah, found it: https://github.com/emberjs/ember.js/pull/12028

authors: davewasmer locks

repo: davewasmer/ember-cli-reset-scroll


text:
Create new class to represent DcosReleaseVersion

@jsancio please review

repo: dcos/cosmos


text:
fix(influx):copy the api and ui services for influx properly

thanks for catching that.

authors: jchauncey kmala

repo: deis/charts


text:
Tuples

Renaming to simply "tuples" because the current implementation support only named tuples. Unnamed tuples might be added in the future.

authors: Coolnesss emlai

repo: delta-lang/delta


text:
Documentation

Hey, Whats wrong is there any way i can help with documentation?

authors: CubeUlations dennissergeev

repo: dennissergeev/umtools


text:
maybe looks better

Thanks.

authors: qclaogui yangwenmai

repo: developer-learning/night-reading-go


text:
Refactor/nodes

Thanks for the feedback, as said in the commits it was a tractopelle refactoring so I wanted to have your feedback in between. Will continue tomorrow.

repo: developer-vault/developer-vault


text:
Microsoft graph powershell hotfix

I am adding @dfds-pwes as reviewer too. I think he would be better suited to review the Powershell code.

authors: ZaradarDFDS avnes

repo: dfds/ce-toolbox


text:
New site for "Built With" page: https://heliumdev.com/themes/carbon

Dupe of #138.

repo: discolabs/cartjs


text:
Merge 3.1 into 3.2

OK to merge

Ok to merge

Coverage decreased (-0.3%) to 88.639% when pulling 7d011c9c5286f31ac96c57e338cfc11071297309 on yakky:merge/5078_3.2b into f82c132a9956bd1f79b8bd460cd86b8359b71c1a on divio:release/3.2.x.

Coverage decreased (-0.1%) to 88.818% when pulling 7d011c9c5286f31ac96c57e338cfc11071297309 on yakky:merge/5078_3.2b into f82c132a9956bd1f79b8bd460cd86b8359b71c1a on divio:release/3.2.x.

Coverage decreased (-0.1%) to 88.818% when pulling 03d18d69687e246bb45de6a1102b0ad18c2d830e on yakky:merge/5078_3.2b into f82c132a9956bd1f79b8bd460cd86b8359b71c1a on divio:release/3.2.x.

@mkoistinen @czpython @vxsx merging!

it's missing compiled bundles (gulp bundle)
as long as we don't forget to do that before release 👍

@vxsx bundle added, merging this

authors: coveralls czpython mkoistinen vxsx yakky

repo: divio/django-cms


text:
Fixed #25378 -- Improved tab through experience in admin.

@elky can you review this PR?

Do we really need color indication for :focus states? Most browsers do their own implementation like this:

This is on OSX. Windows does the same thing as fas as I know.
Is there any advantages of your solution?

I removed the outline: none; settings so the default browser outline is left intact for all elements. Now there should be no unexpected behavior for tab users. I do think that setting the :hover styling for :focus as well compliments the tab through experience, and is a good fallback if a browser for some reason doesn't have the built-in blue outline.

A quick test on Linux looks okay to me. Any more concerns?

I'm going to do review code to make sure that all OK

It's not critical, but if you have time to review it by Monday, we can include it in the 1.9 alpha release. Thanks!

Code looks good for me, just noticed one only UX thing -- @ryangallen please see my comment above.

Ryan, do you have time to make that update?

@elky Since Ryan hasn't responded in a couple days, if you have time to provide a patch for your comments that'd be great. (Or Ryan if you are there, just let us know.)

I'll check it out, sorry for the delay!

Should be good to go.

Cool. Thanks @ryangallen! @timgraham I think it's ready to merge if it's possible according to release plan.

merged in 25cccca0a286585b9896546d57559e41b4e2ca16, thanks both!

authors: elky ryangallen timgraham

repo: django/django


text:
Login signup

Please open a pull request from master branch

repo: djunicode/placement-portal-web


text:
Fixed typos

Those are not typos. "Iff" with two Fs is a thing: https://en.wikipedia.org/wiki/If_and_only_if

repo: dlang/phobos


text:
Some lint fixes

Discussed that we are going to close this for now and re-open later when the refactoring changes have been merged upstream.

repo: docker/machine


text:
Two more spelling corrections

Hi @JosephWoodward, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, DNFBOT;

Seems like this was fixed in some other PR. Thanks!

authors: JosephWoodward KrzysztofCwalina dnfclas

repo: dotnet/corefxlab


text:
Refactor interactivity

Codecov Report

Merging #99 into master will increase coverage by 0.86%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master      #99      +/-   ##
==========================================
+ Coverage    44.8%   45.66%   +0.86%
==========================================
  Files          21       21
  Lines        1433     1406      -27
==========================================
  Hits          642      642
+ Misses        791      764      -27

Impacted Files
Coverage Δ

src/plotting/utils.py
0% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57eb4a8...b2e6939. Read the comment docs.

authors: Kalakuh codecov-io

repo: dpEmu/dpEmu


text:
Corrected closing tag on chrome page

Thanks @pxgamer!

authors: pxgamer zenorocha


text:
Name the yet to be named project

[ ] Do coasters dream of electric drinks

[ ] A scanner orderly

[ ] A brave new coaster

[ ] The drunkards guide to the bar

[ ] All quiet on the ordering front

repo: dropofwill/yet-to-be-named-embed


text:
Better logging of URIExtractionNamespace failures due to missing files

:+1:

authors: drcrallen fjy

repo: druid-io/druid


text:
is there a plan to support angular 4.0?

I have made a rapid test and it seems to work fine.

Is it possible to update the dependencies? I'm getting warning when using npm install.
A new version that officially supports angular 4 would be great, this can be achieved by writing which previous version supports angular 2 in the readme file...

authors: HarelM drusso85 nevernet


text:
Remove Dry::Types::Struct and Dry::Types::Value in favor of Dry::Struct

@solnic could you review this?

I think we should remove anything related to dry-struct and add struct-specific error handling to dry-struct itself. WDYT?

Yeah I agree @solnic. I'll followup with that

@solnic squeezed out the remaining Struct references

@solnic benchmarks removed

@solnic should be ready for another pass

@solnic ping

@backus thanks, could you update CHANGELOG in master?

@solnic done: https://github.com/dry-rb/dry-types/commit/18f8928d70c3583f601f044cea4e48f8e7518e09

authors: backus solnic

repo: dry-rb/dry-types


text:
feat(transcoders): add transcoder for dates

Updated PR.

repo: dscheerens/ngx-webstorage-service


text:
Adding eslint and cleaning up liniting errors.

Codecov Report

Merging #18 into master will not change coverage.
The diff coverage is 91.66%.

@@           Coverage Diff           @@
##           master      #18   +/-   ##
=======================================
  Coverage   97.36%   97.36%
=======================================
  Files           2        2
  Lines          76       76
  Branches       14       14
=======================================
  Hits           74       74
  Misses          2        2

Impacted Files
Coverage Δ

find.js
100% <100%> (ø)
:white_check_mark:

generate.js
96.42% <90%> (ø)
:white_check_mark:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a0ce9c...313c400. Read the comment docs.

authors: codecov-io dwmkerr

repo: dwmkerr/app-icon


text:
improve app UI

home page - emulate google classroom

repo: eahs/FBLAManager


text:
CI for Node

Initializes with two players (4 ms)

repo: edoarad/github-actions-for-ci


text:
Issue 994 refactoring

EhcacheEntityMessage entity messages are divided into two subtypes: ServerStoreOpMessages and LifeCycleOpMessages. And this reflects in the encoded messages as well. We have a byte reserved to identify this top-level split and another byte specifying the actual operation. Do we really need this extra byte in the message payload itself. It is just one byte but one that gets added to all cache operation messages making it a bit costly. Can't we get rid of this top level type byte somehow? Looks like an implementation details leaking out to the messages. I know this is a perf improvement and could be looked at later.

Decoupled the codecs and messages.

Rebased and removed all message factories from constructor visibility..

Still have a number of remarks on the internals of a few classes. However, structure looks ok and since there are dependencies on it, merging now.

authors: AbfrmBlr albinsuresh ljacomet


text:
deploy to vercel

solved

repo: einSelbst/feehikel


text:
License. MIT

@hnakamur, got it! MIT it is.

@ejcx Thanks!

authors: ejcx hnakamur

repo: ejcx/passgo


text:
Add support for topic propagation IRC -> Slack

I'll fix the lint issues above and update the pull req later today.

Thanks! I'm a bit unsure if this is good default behavior though. Would you necessarily want the Slack topic to match the IRC topic? For most of the channels that I use slack-irc for, the topic is set to something like "Bridge to #channel on Freenode" or similar, to explain what's happening.

I'll add a config option if you specify name + bahavior for it.

Slack seems to have a 250 char max on titles, whereas many IRC servers do not. It would be nice to get a warning or something on IRC if the change on slack fails for that reason.

What if I just truncated it?

I would prefer if truncation would produce some warning instead of silently truncating.

Sorry for the extremely late answer. I'm going to close this, as I think it would be tricky to define a sane default behavior for it. Hiding it behind a configuration option is definitely possible, but with an already quite large configuration file I'd prefer to keep it as small as possible. There's also the question about what directions should be synced: Would it make sense to be able to choose if you wanted this to happen the other way around too (i.e. from Slack to IRC as well)?
Sending a message to Slack whenever the topic changes on IRC is a good idea though, and something I don't think a configuration option would be needed for. I don't think the direction is much of a problem here either, and what you've already done here is a good solution, which I'd be happy to merge if you wanted to send a separate pull request for that.

authors: ekmartin jpouellet marcuswanner

repo: ekmartin/slack-irc


text:
Move nyc traffic accidents to 5.0

https://github.com/elastic/examples/issues/54

Closed by https://github.com/elastic/examples/pull/70

repo: elastic/examples


text:
Fix Issue #30

I will be PR'ing shortly, a more flexible PR.

repo: elcattivo/CloudFlareUtilities


text:
nrf: add watchdog

I believe this was done in #354

Yup!

authors: Dirbaio jacobrosenthal

repo: embassy-rs/embassy


text:
Default value in repeat doesn't work except the first question instance.

[ ] fix
[ ] add test
[ ] double-check with Esri form

will be in next alpha release (5.0.0-alpha.1)

repo: enketo/enketo-core


text:
initial commit

Very good!

authors: bendyboo spectreman

repo: enova/saigo


text:
api should render json only

closed with PR #16

repo: eth-library-lab/open-image-search


text:
Fix element sizing after changing etherpad to use box-sizing: border-box by default

put live

authors: JohnMcLear seballot


text:
Made it flashier

:tada: This PR is included in version 1.4.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

authors: SirFredric nprail

repo: eventOneHQ/npm-audit-html


text:
页面启动后，一直报错，network error

可能是你没有启动后端，或者前端的代理没有配置正确

后端启动成功 还是network error

后端启动成功 还是network error

通过这个命令进行前端代码的编译：npm run build
如果前端编译成功，然后后端启动正常，访问 localhost:8080 就可以访问到页面首页了。

请问如何才能通过9528访问且不报错network error呢？看起来这像是一个跨域的问题

谢谢！我这边实际测试情况是想要进行前后端分离使用，并不是用来本地调试的。。。不知这种应该如何解决跨域问题，是要使用cas登录吗？
从 Windows 版邮件https://go.microsoft.com/fwlink/?LinkId=550986发送
发件人: @.>
发送时间: 2021年10月9日 14:32
收件人: @.>
抄送: @.>; @.>
主题: Re: [everythingbest/dubbo-postman] 页面启动后，一直报错，network error (#18)
请问如何才能通过9528访问且不报错network error呢？看起来这像是一个跨域的问题
直接对页面请求进行mock 测试的话，可以修改 src/main/frontend/main.js 文件，把
//如果是本地调试就使用,在build的时候正注释掉这行
//import './mock'
上面的注释去掉，然后npm run dev，就可以了。
―
You are receiving this because you commented.
Reply to this email directly, view it on GitHubhttps://github.com/everythingbest/dubbo-postman/issues/18#issuecomment-939238973, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AIIXWGR2CQTZCVJ6I5HTFXTUF7OX7ANCNFSM4TMKUSDQ.
Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

谢谢！我这边实际测试情况是想要进行前后端分离使用，并不是用来本地调试的。。。不知这种应该如何解决跨域问题，是要使用cas登录吗？ 从 Windows 版邮件<https://go.microsoft.com/fwlink/?LinkId=550986>发送 发件人: @.> 发送时间: 2021年10月9日 14:32 收件人: @.> 抄送: @.>; @.> 主题: Re: [everythingbest/dubbo-postman] 页面启动后，一直报错，network error (#18) 请问如何才能通过9528访问且不报错network error呢？看起来这像是一个跨域的问题 直接对页面请求进行mock 测试的话，可以修改 src/main/frontend/main.js 文件，把 //如果是本地调试就使用,在build的时候正注释掉这行 //import './mock' 上面的注释去掉，然后npm run dev，就可以了。 ― You are receiving this because you commented. Reply to this email directly, view it on GitHub<#18 (comment)>, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AIIXWGR2CQTZCVJ6I5HTFXTUF7OX7ANCNFSM4TMKUSDQ. Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

看readme文件：
先编译前端ui: npm run build
再编译后端代码：  maven clean package
然后启动：  java -jar target/dubbo-postman.jar
访问地址：http://localhost:8080/  就可以了。

authors: binaryjerry everythingbest wzq-xzwj yiyuzhou

repo: everythingbest/dubbo-postman


text:
一覧画面(python)

突合情報はフォーマットに合わせて整形する必要あり

repo: exastro-suite/oase


text:
😢Save doesn't work.  The saved Json file is empty.

Hello. What's your OS & Browser?

Ok, I can repro on Chromium 84 (Edge/Canary).
/cc @tomayac is it possibly some origin-trial error, or Native FS regression?

I’ll have a look tomorrow.

The prev bug was about createWritable while this one is about createWriter. I couldn't quite figure out the code path by looking at your source.
Also it only manifests in Chromium 83+ so I don't think it's cache problem.
Anyway, since it's not on stable channel, it's not a priority, so take your time!

Thanks for the fix Thomas. :tada:

authors: dwelle miguelhau tomayac

repo: excalidraw/excalidraw


text:
Add all your base exercise

@kytrinyx fixed everything, let me know if you think of any other change or improvement

Here is my next crazy idea (though this is not the first time I had this crazy idea, as I said it on https://github.com/exercism/xrust/pull/170#issuecomment-233162831)
Right now we are enforcing in tests that negative values in inputDigits, inputBase, outputBase all result in errors. And it will never be the case that there should be a negative value in outputDigits.
So, what if we make them all uint64? That way we can use the type system to enforce this, not the tests. Yes, this means that we don't have all the tests in canonical-data.json, and that's OK as long as the ones that are being omitted are just the ones that the type system forbids.

Moved to type uint64 as @petertseng suggested and fixed all the other issues. Only thing that's left is knowing where to document the decisions on how to treat zeroes and the position of the exercise in config.json

Only thing that's left is knowing where to document the decisions on how to treat zeroes

Looks like that'll want to go in the test file. the other alternative is some other file that gets served to students (that rules out the example), or HINTS.md to get it included in the README.

Looks like that'll want to go in the test file.

I have placed it there, due to inactivity on this PR. Merging now, with thanks to @mvader for the work!

authors: mvader petertseng

repo: exercism/xgo


text:
added localhost option for hostname.

Thank you for this, but the JavaScript expression '127.0.0.1' || 'localhost' will never return the second value added here, as the first value is a fixed string and will always be true.

Thank you for this, but the JavaScript expression '127.0.0.1' || 'localhost' will never return the second value added here, as the first value is a fixed string and will always be true.

Yes, you are right, thanks for the quick response.

authors: RishabhKodes dougwilson

repo: expressjs/generator


text:
Update README with Medium links

Codecov Report

Merging #18 into master will decrease coverage by 39.17%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master      #18       +/-   ##
===========================================
- Coverage   71.45%   32.28%   -39.18%
===========================================
  Files          27       19        -8
  Lines         536      254      -282
  Branches       12        0       -12
===========================================
- Hits          383       82      -301
- Misses        153      172       +19

Impacted Files
Coverage Δ

Foursquare Clone/Networking/PlacesApi.swift
0% <0%> (-100%)
:arrow_down:

Foursquare Clone/State/AppState.swift
0% <0%> (-86.67%)
:arrow_down:

Foursquare Clone/Services/PlacesService.swift
28.57% <0%> (-71.43%)
:arrow_down:

Models/LocationPlaces.swift
0% <0%> (-53.85%)
:arrow_down:

Foursquare Clone/Reducers/AppReducer.swift
43.47% <0%> (-49.12%)
:arrow_down:

...oursquare Clone/Services/NearbyPlacesService.swift
55.55% <0%> (-44.45%)
:arrow_down:

...oursquare Clone/Services/UserLocationService.swift
69.23% <0%> (-30.77%)
:arrow_down:

...es/PlacesViewController/PlacesViewController.swift
57.14% <0%> (-2.39%)
:arrow_down:

Models/Group.swift
0% <0%> (ø)
:arrow_up:

Foursquare Clone/AppDelegate.swift
100% <0%> (ø)
:arrow_up:

... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a4a2c9...039d6bb. Read the comment docs.

authors: codecov-io fabiothiroki

repo: fabiothiroki/foursquare-clone-ios


text:
Make CompositeDraftDecorator's DELIMITER customizable.

This variable is private to the CompositeDraftDecorator module. Can you provide details on why you would need it to be customizable?

Apologies, looks like I misread.

authors: aviraldg hellendag

repo: facebook/draft-js


text:
Add vm definitions

Yeah it will. Updated.

repo: facebook/flow


text:
turn DefinitelyTyped.org into a link

lol, no ;)


text:
Update strings.xml SK

Thank you very much!

authors: farmerbb ja-som

repo: farmerbb/SecondScreen


text:
Fixed: If the expiration = None

Why there is not expiration in the document?

If the permanent == False the expires is set to None
get_expiration_time method.
expires = self.get_expiration_time(app, session)
Here "expires" is None
Therefore error.
    if document and document.get('expiration') <= datetime.utcnow():
TypeError: can't compare datetime.datetime to NoneType

Flask-Session only works when permanent is True, if you need non-permanent session, use the builtin cookie session.

authors: fengsp yuryatr

repo: fengsp/flask-session


text:
Merge from upstream

Wrong repo, my bad

repo: fgosc/fgosccnt


text:
Create Benchmark_Constituent.md

Hi @ingridbruch-epam
Please let me know if you need someone on the Glue team to review this PR and I'll show you how to assign.
All the best,
James.

Hi James,
Yasen from epam, will do these PRs when he gets in,
All is fine.
Thanks, Ingrid
From: James McLeod notifications@github.com
Sent: 07 October 2020 17:32
To: finos/glue glue@noreply.github.com
Cc: Ingrid Bruchhof Ingrid_Bruchhof@epam.com; Mention mention@noreply.github.com
Subject: Re: [finos/glue] Create Benchmark_Constituent.md (#18)
Hi @ingridbruch-epamhttps://urldefense.com/v3/__https:/github.com/ingridbruch-epam__;!!GF_29dbcQIUBPA!kaSstKUNyyazS1l3CaEp8K9gj38NA16d0Z7eeaOEG6G_eDXH6iR93bjo8VvQ7MAgfuqK$
Please let me know if you need someone on the Glue team to review this PR and I'll show you how to assign.
All the best,
James.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https:/github.com/finos/glue/pull/18*issuecomment-705052742__;Iw!!GF_29dbcQIUBPA!kaSstKUNyyazS1l3CaEp8K9gj38NA16d0Z7eeaOEG6G_eDXH6iR93bjo8VvQ7CQP-mtk$, or unsubscribehttps://urldefense.com/v3/__https:/github.com/notifications/unsubscribe-auth/ARIMQYAK3IV4AD3HIW5L2NLSJSJWHANCNFSM4SHTFNUA__;!!GF_29dbcQIUBPA!kaSstKUNyyazS1l3CaEp8K9gj38NA16d0Z7eeaOEG6G_eDXH6iR93bjo8VvQ7GUZvIAR$.

authors: ingridbruch-epam mcleo-d

repo: finos/glue


text:
Job not scheduling on oreo  device while the same code is working on marshmallow device.

In April 2019 we announced that Firebase Job Dispatcher would be deprecated today, April 7th 2020.  For this reason we are going to close all open issues and archive the repository.  We will also stop supporting FJD for new app installations (such as those targeting sdk versions greater than Android Q).  Existing apps that rely on FJD should continue to function as usual.
While we will no longer work on FJD, we encourage you to migrate to Work Manager which is a superior tool and fully supported by the Android team.
Thank you for taking the time to try the library and provide this feedback.  We sincerely appreciate your effort and we apologize for not addressing it in time.

authors: samtstern shashankchandak

repo: firebase/firebase-jobdispatcher-android


text:
exportした変数の展開がされない

#15 で修正されました。再現したらreopenください

authors: hiro-hori so-tomoshira


text:
Display & JSON

Accident - meant to push it my fork's master branch.


text:
ImageFit.fitWidth/fitHeight and minor docs fixes

LGTM

authors: Hixie abarth

repo: flutter/flutter


text:
host: Add version to status

LGTM

authors: jvatic lmars

repo: flynn/flynn


text:
[varLib] Support sparse masters

Great that this is getting done, thanks!
I have an idea that relates to this, and I wonder what you'd think.
Sometimes I've had a need to have masters/deltas for metrics (HVAR/GPOS) but not for outlines. With your current work, it may become feasible to implement the following: if a (non-neutral) glyph exists, but has no outlines or components, then interpolation compatibility checks are bypassed, and only the advance width/height values are taken into consideration.

Okay. First chunk of work is mostly done.  HVAR was tricky but done.  Only need to allow masters without GPOS and would be done for the first phase.  More complicated GPOS kerning work is next stage.

(Fixing the tests.)

This is ready as far as I'm concerned.

Sometimes I've had a need to have masters/deltas for metrics (HVAR/GPOS) but not for outlines. With your current work, it may become feasible to implement the following: if a (non-neutral) glyph exists, but has no outlines or components, then interpolation compatibility checks are bypassed, and only the advance width/height values are taken into consideration.

The more I think about this, the more it doesn't make sense to me, at least not if glyph advance is also ignored.  Setting different advance width without drawing the glyph sounds wrong to me.

I'm now going to dig deeper into GPOS, trying merging GPOS where a master misses a glyph.   Maybe that isn't a common use case and I shouldn't try.  Probably yes.  It's easy to do for anchors and possibly kerning, but if there's any other feature, it becomes nasty.  But maybe getting that much done would make it UFO-based fontmake workflow where there's no handwritten features.fea file work without any changes needed in the rest of the stack, and that's a good start?

Reached another milestone: sparse mark-base positioning is also merged now.
The way I tested this:

Built UFO from Glyphs file for NotoSerifTamil:

$ fontmake -o ufo -g NotoSerifTamil-MM.glyphs

Modified master_ufo/NotoSerifTamil-Light.ufo/glyphs/contents.plist and master_ufo/NotoSerifTamil-Light.ufo/features.fea and deleted a-tamil from them.

Built interpolatable masters:

$ fontmake -o ttf-interpolatable -m master_ufo/NotoSerifTamil.designspace

Built variable font using varLib:

$ fonttools varLib master_ufo/NotoSerifTamil.designspace

It builds for me now.
Next: find a glyph with mark-to-mark positioning, and implement that.  Then mark-to-ligature.
Next next: kerning; it's almost there.  Needs tiny amount of work.  Right now merger assumes missing kerning is 0.  Need to distinguish that from glyph-not-in-font.

Next next: kerning; it's almost there. Needs tiny amount of work. Right now merger assumes missing kerning is 0. Need to distinguish that from glyph-not-in-font.

That's a tricky issue.  One can argue that if kerning is missing it should not be assumed 0, and discard the master for that pair.  Might result in surprises, eg, if one doesn't kern a pair in Bold master because it wasn't needed, but is kerned in Black, then if we don't assume 0, the kern for Black will interpolate all the way to Regular, changing the desired kern at Bold.
However, not assuming 0 allows for having sparse masters with no kerning at all, or no kerning for particular glyphs...  which otherwise would have to.

MarkMarkPos implemented as well.

Okay, fixed.  Again, ready to merge.

The more I think about this, the more it doesn't make sense to me, at least not if glyph advance is also ignored. Setting different advance width without drawing the glyph sounds wrong to me.

That is the whole point, to have a delta for the advance and not the outline. It may make no sense to you, but I have actually needed this for a real project. The use case exists.

That is the whole point, to have a delta for the advance and not the outline. It may make no sense to you, but I have actually needed this for a real project. The use case exists.

Did you really just needed to add more space just to the right side of the glyph shape, and not left side?  Because that's what happens if only advance width varies.  And this sounds like as quite an arbitrary limitation / need to me. (the one-sided-ness)

Did you really just needed to add more space just to the right side of the glyph shape, and not left side? Because that's what happens if only advance width varies. And this sounds like as quite an arbitrary limitation / need to me. (the one-sided-ness)

Yes, exactly. It was about tweaking the metrics of an intermediate master, so it would match the metrics of an existing static font perfectly. We stuck with pure interpolation for most outlines, as that was good enough, and metrics compatibility was more important than exact outline matching. And saving space was an issue. This solution gave us the best tradeoffs among all requirements.

Yes, exactly. It was about tweaking the metrics of an intermediate master, so it would match the metrics of an existing static font perfectly. We stuck with pure interpolation for most outlines, as that was good enough, and metrics compatibility was more important than exact outline matching. And saving space was an issue. This solution gave us the best tradeoffs among all requirements.

Yeah okay sure, that is one legitimate use case :).

Yeah okay sure, that is one legitimate use case :).

I don't insist that varLib implements this (I managed ok with a post processing script), I was just thinking that perhaps with your current work it would be trivial to support. In which case it would be a win-win :)

I don't insist that varLib implements this (I managed ok with a post processing script), I was just thinking that perhaps with your current work it would be trivial to support. In which case it would be a win-win :)

Oh I already did last night. https://github.com/fonttools/fonttools/pull/1368/commits/446ee2a4d011909eaa14fa5ccbd8c4d6df3329de

Advance width comes from hmtx/HVAR. You are thinking UFO.

I'm thinking phantom points. Shouldn't they stay in sync with HVAR?

Advance width comes from hmtx/HVAR. You are thinking UFO.

I'm thinking phantom points. Shouldn't they stay in sync with HVAR?

There's no way I can include phantom points but not the rest of the glyph.

But yeah, for that reason, maybe this is not a good idea.
The alternative is hard: to interpolate the glyph and insert it if it's missing.  I don't want to go that far.

There's no way I can include phantom points but not the rest of the glyph.

Uh, of course you can: you can have deltas for the phantom points and no deltas for the rest of the points.

Uh, of course you can: you can have deltas for the phantom points and no deltas for the rest of the points.

Sometimes you can.  In general you can't.
Imagine a simple system with Regular, Bold, and Black masters.  There's two ways to model that.  Both result in same output normally (modulo rounding issues):

Black can go from Regular all the way to Black; Bold will go from Regular up to Bold and down to Black.  Note how Bold master here will be "patching up" whatever Black master leaves as bold at the location of Bold master.

Bold starts from Regular going up to Bold and going down to Black; Black master starting at Bold and going up to Black.

In the two equivalent systems above, in the first one, if you don't encode deltas for a glyph shape in Bold master, you get whatever else the system would do.  Ie. this system is equivalent to what you get if you deleted the Bold master.  The second solution however is not.  If you don't encode glyph shape in Bold master, you get the shape for Regular, which is not what you expect.
So, basically what you want, is to use the variation model without a particular master, encode glyph shapes, then add phantom-point deltas to fix up advance width to pre-defined values at particular points.  That's more than just a couple lines here or there, and needs more thought as to how that would interact with other masters.

Got it, I see that it's more complicated than I thought. What you describe is if I recall correctly indeed more or less what I implemented in my post processing script. But it didn't need to cover all possibilities, as the font in question had a simple predictable model and only one axis.

Should I revert that commit then?  Because, as you point out, according to spec, HVAR and glyph phantom points must agree on the glyph width.

Should I revert that commit then?

I think so, yes.

If someone wants to give me a test case (smaller better) with kerning, I can look into that.  Right now the code assumes a kerning of 0 if a kerning pair doesn't appear in a master, even if the master does not contain one or two of those glyphs.

authors: behdad justvanrossum

repo: fonttools/fonttools


text:
Add crypto-enigma

Thanks @orome!

authors: lwm orome

repo: fpco/stackage


text:
bootstrap-italia updated to v1.3.9

merged


text:
TEST: enable chords in soundsequenceController

leads to less results due to differences in pattern notes (no chord tag) and xml notes (chord tag!)

repo: freakimkaefig/Music-XML-Analyzer


text:
set lat and lon to correct field when clicking on osm map

@andibraeu Do you have a solution to getting the lat and lon fields to work properly in modules/luci-mod-freifunk/luasrc/model/cbi/freifunk/basics.lua too?

@andibraeu Do you have a solution to getting the lat and lon fields to work properly in modules/luci-mod-freifunk/luasrc/model/cbi/freifunk/basics.lua too?

I just made the changes manually on a WDR4900, and it makes the map on modules/luci-mod-freifunk/luasrc/model/cbi/freifunk/basics.lua work properly.  It would have been helpful to have this information in the PR description.  Looks good.  Merging.

I just made the changes manually on a WDR4900, and it makes the map on modules/luci-mod-freifunk/luasrc/model/cbi/freifunk/basics.lua work properly.  It would have been helpful to have this information in the PR description.  Looks good.  Merging.

authors: andibraeu pmelange

repo: freifunk/openwrt-packages


text: Add screen shot

repo: frogcat/saigo-no-hitomoji-chizu


text:
retest

so it looks like you still have a syntax error in this file, and the tests weren't run. Looks like your method definitions got exploded or something.

authors: brandonkoo fishermanswharff


text:
move ToIndexEntity to another class, currently in a file where it foesnt belongs

what?

repo: gabrieldelaparra/SparQLforHumans


text:
Rev planemo for latest fixes.

Perfect, looks way better. Lets try in real.

authors: bgruening jmchilton

repo: galaxyproject/planemo-monitor


text:
Delete obsolete tool wrapper files

@bgruening It seems removing .shed.yml from the main msconvert directory, which doesn't have a current tool in it, makes planemo fail to find the tests. Or maybe it's the lack of a tool wrapper that stops it from recursing.

Mh, it can also be that I only changed modified and added files and only test in this case. I do not remember how I implemented it. Let's modify a file.

You're right. It was due to planemo ci_find_repos not finding any changes. Which I guess is strictly speaking true!

Thanks @chambm!

authors: bgruening chambm

repo: galaxyproteomics/tools-galaxyp


text:
Format code using 'cargo fmt'

This is your second rejected PR to format the code. I highly recommend finding other ways to contribute to projects than mass tool-automated format requests.

that's annoying. this user's entire account history is this same stuff. reported to github as it really shouldn't be allowed

sorry, I didn't check the closed PR.

@gamozolabs @evanrichter sorry, I didn't check the closed PR.

authors: Atul9 evanrichter gamozolabs


text:
improve plotting

Coverage increased (+0.2%) to 92.605% when pulling ccf46a69befd21f15f0f9021be6279de06ed3ce6 on feature into 38cfa7d1392811bb7422d62937178db1593c2f06 on master.

authors: coveralls gboeing

repo: gboeing/osmnx


text:
Gh 1984 to freq map

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.6 out of 7 committers have signed the CLA.:white_check_mark: gaffer01:white_check_mark: d47853:white_check_mark: GCHQDev404:white_check_mark: m55624:white_check_mark: GCHQDeveloper404:white_check_mark: p013570:x: d21211122You have signed the CLA already but the status is still pending? Let us recheck it.

repo: gchq/Gaffer


text:
Gh 618 graph hook

Current coverage is 61.31% (diff: 83.33%)

Merging #654 into develop will increase coverage by 0.04%

@@            develop       #654   diff @@
==========================================
  Files           370        370
  Lines         11362      11362
  Methods           0          0
  Messages          0          0
  Branches       1659       1659
==========================================
+ Hits           6962       6967     +5
+ Misses         3852       3847     -5
  Partials        548        548

Powered by Codecov. Last update 4d006e3...cca0909


text:
Update models.txt

I'm actually going to decline this -- its kind of irrelevant anyway since I'm not using this file anymore, but if I were it would be a bit onerous as I don't think I have definitions for those terminal types handy on my system.

authors: LeapofAzzam gdamore

repo: gdamore/tcell


text:
Added Chinese translation

Hi, I am a student which look your article in zhihu, thanks for your experience. This helped me a lot in the progress of building self-confidence

repo: geoman-io/leaflet-geoman


text:
Adjusted asset types to enable extension of asset classes

What is the specific use case for extending assets class?

I'd like to handle my front-end assets differently. Are you against the idea of extending grav?
I'm using s3 to store my assets instead of local.

Currently I apply this change via patch file when I build my local. I'd like to see it as part of the official source.

if you have the assets externally, do you even need to use grav's assets?

I actually don't have a problem making this more extensible, i was really just curious :)

I hear that, I moved my docroot folder below the base directory. For images I host the content via s3 and css files I host them locally but have the webroot deeper into the folder structure. I've got an extension of BaseUtils that modifies the uri method and I've also got extensions to the Assets and Medium classes.

authors: jackthomasatl rhukster ricardo118

repo: getgrav/grav


text:
Scala 2.12.0

Coverage remained the same at 92.135% when pulling d042a58b80e3e43dc542dc5b5fe198cfe1851ae7 on scala-2.12.0 into c6f6f1cec54b10e5b97301188ce43f2cec84ddb8 on master.

authors: coveralls sullis

repo: gilt/gfc-time


text:
Add transform-async-to-generator plugin for es5 builds to support async/await

This is not good enough on its own to support async await in older es5 browsers. I'm going to close this in favor of an issue.

repo: glimmerjs/glimmer-build


text:
Aggregations

(1) These look really useful -- especially the sum_by_owner aggregates.

Thanks :)

(2) There are a lot of new metrics here.
(3) If we send a PR to the OSS project, we might get push-back on the overall number of metrics. There could also be multiple points of view as to whether these should be aggregated at this level -- it is good for our use case, but users that do not have the same problems of scale and data retention may think that using labels to aggregate with PromQL is better, and this would look redundant to them.

Yup. I went through the metrics to see what could be useful, didn't really take into account our internal needs so we'll probably want to revisit it.
The aggregations are disabled by default, so if you don't need them, you don't pay the cost. In a perfect world, I'd use PromQL too but we'd be dead long before we put the metrics anywhere that supports PromQL.

(4) Since our flag "--enable-aggregations" is orthogonal to to the "--metric-allowlist" and "--metric-denylist" flags, it would bring in aggregates for things that are denied, right? That could be a source of confusion for OSS users.

If you --enable-aggregations --metric-denylist "^kube_pod_phase$" then you will get the kube_pod_phase_sum_by_... metrics but with --enable-aggregations --metric-denylist "^kube_pod_phase" (or just --enable-aggregations --metric-denylist kube_pod_phase) you won't. Aggregations respect the filtering rules just like normal metrics.

I'll keep adding comments as I go. I'm liking the code so far :-)

Thanks :)

repo: gnosek/kube-state-metrics


text:
DevTools: m57 isn't canary any longer. removing note.

I always replace the words stable, canary, and dev with a specific version whenever I find them for exactly this reason.

I have an open PR that fixes this... #4372
But ya, I'm going to stop mentioning stable / canary / etc. and just use the version of Chrome

That other PR fell through so using this one...

authors: jpmedley kaycebasques paulirish

repo: google/WebFundamentals


text:
build: add shared config to parent pom, fix any build errors

Please extract the copyright changes to a separate PR... they create too much noise

@igorbernstein2 updated this PR to be only about headers, PTAL

repo: googleapis/java-bigtable-hbase


text:
Fix LRO to have scopes passed to operations client

Current coverage is 83.36% (diff: 100%)

Merging #823 into master will not change coverage

@@             master       #823   diff @@
==========================================
  Files           315        315
  Lines         12059      12059
  Methods           0          0
  Messages          0          0
  Branches       1596       1596
==========================================
  Hits          10053      10053
  Misses         1577       1577
  Partials        429        429

Powered by Codecov. Last update d1a4e00...a850d00

Thanks for the review!

authors: codecov-io landrito

repo: googleapis/toolkit


text:
Add Serpstat Community Connector

Hi, it looks like you might be from serpstat (based on your GitHub name), we recommend that connectors that are maintained by the data source they connect to be managed in a standalone repo, though we're happy to accept it here.
The main benefits of a standalone repo is that you can manage/update the deployments & make bug fixes more quickly. The full details on the difference between open source and partner connectors can be found here. If you're happy for us to maintain the deployment, just let me know and I'll move forward with the review!
Thanks,
Matt

Hello!
Thank you for guiding us on the difference between open source and partner connectors.
We would still like to deploy a partner connector.
In this regard, we close our pull request.
Thanks,
Ekateryna

authors: diminishedprime kaisa-serpstat

repo: googledatastudio/community-connectors


text:
fix bug with nationalPrefixOptionalWhenFormatting being dropped for the US when writing nanoproto files

Should do removal of the conditional in the existing (regular proto) code to ensure tests pass and metadata doesn't change.

Rendered unnecessary by googlei18n/libphonenumber#883

Did you mean by googlei18n/libphonenumber#884 ?

Still need to merge though and update js metadata etc.

Yes, of course, I meant googlei18n/libphonenumber#884. :-)
I cherry-picked the change from master. It's effective the same change as this one:
googlei18n/libphonenumber#885

authors: dlyongemallo keghani


text:
Expose API to implement stubs

Closing since this issue can be split up into documentation - #12 and the stubs themselves which are heavily commented.

repo: googleinterns/smart-home-local


text:
Sheets - BQML Forecasting sample

Submitted PR to ml-integration-samples repo instead. Closing this PR.

repo: googleworkspace/apps-script-samples


text:
Add examples and basic documentation

We desperately need some documentation :) (#10 and #11 and possibly more in the future…)

repo: graphp/graphviz


text:
Hi grip looks nice! Will there be more documentation and examples?

I think the documentation is enough at the moment, for a bit more in detail look you can review the Kemal framework documentation

authors: epoch grkek

repo: grip-framework/grip


text:
example api

Performance differences noted:
Benchmark                                                                  cpu_time    real_time
-----------------------------------------------------------------------  ----------  -----------
BM_CallCreateDestroy<InsecureChannel>                                        -85.50       -85.50
BM_ClosureSched2OnTwoCombiners                                               -19.00       -19.00
BM_ClosureSched4OnTwoCombiners                                               -30.00       -30.00
BM_CreateDestroyCore                                                         -24.50       -24.50
BM_EmptyCore                                                                -126.00      -126.00
BM_HpackEncoderEncodeHeader<EmptyBatch>/0/16k                                 -5.50        -5.50
BM_HpackEncoderEncodeHeader<RepresentativeServerTrailingMetadata>/1/16k       -9.50        -9.50
BM_HpackEncoderEncodeHeader<SingleInternedBinaryElem<100>>/0/16k              -8.50        -8.50
BM_HpackEncoderEncodeHeader<SingleInternedBinaryElem<1>>/0/16k                -7.50        -7.50
BM_HpackEncoderEncodeHeader<SingleInternedBinaryElem<31>>/0/16k               -9.50        -9.50
BM_HpackEncoderEncodeHeader<SingleInternedElem>/0/16k                         -7.50        -7.50
BM_HpackEncoderEncodeHeader<SingleInternedKeyElem>/0/16k                     -15.50       -15.50
BM_HpackEncoderInitDestroy                                                  -130.00      -130.00
BM_HpackParserParseHeader<NonIndexedElem>                                    -37.00       -37.00
BM_IsolatedFilter<CompressFilter, SendEmptyMetadata>                          -7.50        -7.50
BM_Pass1Core                                                                 -22.00       -22.00
BM_Pluck1Core                                                                -24.00       -24.00
BM_Zalloc/512                                                                 -6.50        -6.50

[trickle] No significant performance differences

authors: ctiller grpc-jenkins

repo: grpc/grpc


text:
Backport 12493 to 1.7.x

test failures:

interop cloud to prod kokoro: https://github.com/grpc/grpc/issues/10763


text:
Enrich census initialization and feature code

The change LGTM.
I see "Visual Studio 2013 build" has a red status label but didn't know how to investigate.  Should I merge now or wait it to turn green?

I can't look at the VS 2013 log (the details link doesn't go anywhere), so I wouldn't worry about it. I also took a look at the Jenkins failures, and they seem to be git-related, so I think thats OK as well.

authors: a-veitch maxwell-demon


text:
second branch practice PR

branch number 2


text:
Add NotEqualTo assert

Any chance of looking at this PR @guillaumepotier? Thanks!

@guillaumepotier is it possible to merge this PR and release a new version?

ping @guillaumepotier

Yes,
Sorry guys for doing it so late :(
Packaging a new version right now.
Thanks a lot
Best

authors: fixe guillaumepotier nunofgs ruimarinho


text:
Doesn't take AFK players into sleep required count anymore

@ifvictr thoughts on this based on the previous converstation?

when i first added this, i kinda wanted to discourage afk servers, where everyone just hops on to afk instead of actually playing

looks good to me.
i think this is beyond the scope of the pr but this may introduce a situation in which one person sleeps and the other people on the server (who are not really afk) type /afk and the server sleeps.

I agree with @ifvictr to an extent, because while we don't want to make the server an AFK server, it also severely inconveniences active players when they're trying to skip the night.

severely inconveniences active players when they're trying to skip the night.

it definitely does inconvenience people

Another thing to Nick's point: people already leave the game to speed up the night; why not make it easier to do that with the /afk?

repo: hackclub/HCCore


text:
Clean up and enlarge Hack Club text logo

Just got an offline confirmation from @MaxWofford that this is good to merge.

repo: hackclub/meta


text:
Hi, I can't find the images_test.txt and bounding_boxes_test.txt in Birds-200-2011 dataset，where are them？

Hey

The dataset can be found here. Updated README.md reflects the same.
There is additional information provided  (such as segmentation)  which I have not used
Additionally the code has some bugs and the results are a little less then expected. I will try to modify them as I find more time.

Thanks for your anwer.  But I have downloaded the dataset, there are "attributes  bounding_boxes.txt  classes.txt  image_class_labels.txt  images  images.txt  parts  train_test_split.txt" in the dataset. The bounding_boxes.txt, images.txt and image_class_labels.txt are the train file you used in bird_dataset_generator.py, howerver, images_test.txt and bounding_boxes_test.txt  are not in the dataset.

Uploaded the required files in the "/data" folder.

Hey, what about the images_train.txt bounding_boxes_train.txt files? Should i use train_generator  to create them?

It seems that the dataset I downloaded and the one present in the UCSD website are a little different in terms of their structure (the data is still the same).  This is evident from the Dataset-Readme file ( in "/dataset-readme") and the Caltech Dataset-Readme file (http://www.vision.caltech.edu/visipedia-data/CUB-200-2011/README.txt).
But this issue is easily solvable. Use "train_test_split.txt", "images.txt" to get the files images_train.txt and images_test.txt. Similarly use "train_test_split","bounding_boxes.txt" to get bounding_boxes_train.txt and bounding_boxes_test.txt.
Apologies for the wrong dataset information earlier and I will update the code to reflect the original dataset in a week.

Hey @8ANDfinalrule  please go through the update README . Let me know if the issue is resolved.

Hey, I was busy for some time, thanks for fixing this one. I am afraid there's also vgg16_weights.npz missing. Attempt to run the main.py ends with missing file error.

Hey its a very well known file. You can use the following link to find the same.
http://www.cs.toronto.edu/~frossard/post/vgg16/

authors: 8ANDfinalrule Mrsunsunshine halwai


text:
[Users and Authentication] Social login doesnt talk about adding client secret to secrets

[ ] Applies for google and facebook
[ ] Typo in facebook at line "For mobile users, you ...."

Tracked in #483

repo: hasura/docs


text:
HWKBTM-347 : Placeholder for No Data at Pie Chart

Thanks Alexandre!

authors: ammendonca objectiser

repo: hawkular/hawkular-btm


text:
Added charset utf-8 to Content-Type response header. supports iOS

We should test this in all major browsers when it's in staging to make sure it didn't break any other clients.

In our testing, this didn't change the behavior so I'm closing the pull request.

authors: jkutner tt

repo: heroku/busl


text:
Add missing name and description to POM

thanks, I keep forgetting about that ordering rule. Merged and followed up with 5a107d77663c72b56fe01b4c212732e16f270fba

authors: Sanne yrodiere

repo: hibernate/hibernate-reactive


text:
CB-3921 | Modified cluster proxy registration request to include ssh …

Waiting for a fix for https://jira.cloudera.com/browse/CB-4196

This should go to master at this point.

authors: dvguruprasad keyki

repo: hortonworks/cloudbreak


text:
Alluvial diagram component

Starting work on this in https://github.com/humanitiesplusdesign/palladio-alluvial-component

Alluvial functionality is fairly complete at this point in the sibling repository.

repo: humanitiesplusdesign/palladio


text:
CRD controller to refresh the gvk map

/lgtm

/approve

authors: kuanf rbmateescu

repo: hybridapp-io/ham-application-assembler


text:
trigger build to address CVE issues

/lgtm

repo: hybridapp-io/ham-placement


text:
XML namespace fix for metadata elements 'Source' and 'Relation'

Can one of the admins verify this patch?

@mohamedmorsy Can you review this?

@hyi This PR includes a custom migration. Would like you to review.

@hyi Let me if there are any other issues for me to address.

authors: hydrobuild pkdash

repo: hydroshare/hydroshare


text:
Add HashedSecureURL and use it on ViaSecureURL

I'm sorry! I didn't see this one when I started mine

authors: jon-betts marcospri

repo: hypothesis/h-vialib


text:
小于3张图片的时候，请问怎么解决。

@BaiCanLin 你好，我没有重现到你说的出现一半的问题，平时也没有出现过，你能详细说明一下吗？

你好，iPhone6 plus下，只有2张图的时候，会越滚左边位移越大，其他设备目前没发现这个问题

authors: chengyifly iOSNerd zn88358800

repo: iOSNerd/PagedScrollView


text:
Create Issue template

I want to take this one.

Hey @feedbacker1991 take a look on this PR please:
https://github.com/ifactory-solutions/awesome-react-app/pull/46
Try to follow similar idea

I am on it.

Nice @feedbacker1991

I think we can improve this. @feedbacker1991 added a nice template in #42. But I though better and I don't agree with the first sentence.
In my opinion, issue tracker isn't just for reporting bugs, but also to discuss (or make a question) about an improvement or a new feature, for example. And we could use StackOverflow to reference bugs, questions, discussions, etc.
I've taken a look into create-react-app issue template and we could follow the first section style, which gives the option of create a free form discussion/question if the issue isn't related to a bug report.

I think its just too much for opening an issue.

repo: ifactory-solutions/inside-client


text:
store size on disk for each database and RP in the _internal database

Fixed via #5758 and #5810

authors: beckettsean jwilder

repo: influxdata/influxdb


text:
add possibility to pass tags to resources

Available in 0.7.0


text:
Fix and enable Windows tests

Previously some windows tests were disabled.  We desired to run all tests in nightly builds so those remaining tests should be enabled.
Unfortunately, some of those tests fail because they invoke bash to run a script that then calls the CLI.  The failure arises because the Haskell test code is unable to locate the bash executable.
This PR fixes that by allowing CI to defined BASH_PATH before invoking the tests so that the can look it up to find the bash executable.

bors merge

repo: input-output-hk/cardano-node


text:
[PM-1681] Remove peergroups unused by midnight

tag created https://github.com/input-output-hk/scalanet/releases/tag/v0.1.7

repo: input-output-hk/scalanet


text:
release 0.1.2

Closed by https://github.com/inveniosoftware/dcxml/issues/10.

authors: diegodelemos ppanero

repo: inveniosoftware/dcxml


text:
docs: rewrite usage documentation

Finally tests are passing!

lgtm

authors: lnielsen remileduc

repo: inveniosoftware/invenio-access


text:
(Solution Needed) Sort a set of strings in ascending alphabetical order

i'd like to contribute to this

i would like to do this task

authors: RKRohk harrisdurrani mundraroshan


text:
new arch split data and logic

not necessary,need new architecture

repo: iotexproject/iotex-did


text:
Fill the list !

Cool! Ideas?
Awesome archives
Awesome use cases
Awesome apps using IPFS
Awesome community tools

@RichardLitt done

authors: Dignifiedquire RichardLitt

repo: ipfs/awesome-ipfs


text:
Update reference docs.

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: geeknoid
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [geeknoid]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

authors: geeknoid istio-testing


text:
docs: add 'dvc unprotect' to command reference

WIP

authors: efiop shcheklein


text:
Update deps

Coverage remained the same at 97.774% when pulling e6f2157295ba7ad1baa5c174e78a524a8e4fcc10 on update-deps into 2499f5545f9f3517673a70a869f7eb7b9519570d on master.


text:
Hello !NEW! Hello

Another one please

repo: jaapbrasser/jaapbrasser


text:
Aligned the agent service with the Kubernetes version and using latest image

I don't know where we agreed on this

authors: jpkrohling pavolloffay

repo: jaegertracing/jaeger-openshift


text:
Add documentation to DnD

Codecov Report

Merging #64 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #64   +/-   ##
=======================================
  Coverage   80.98%   80.98%
=======================================
  Files          13       13
  Lines         284      284
  Branches       42       42
=======================================
  Hits          230      230
  Misses         45       45
  Partials        9        9

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 43463d6...f06f603. Read the comment docs.


text:
Make SVIs sort numerically (instead of alphabetically) in NextHopSummary.py

Pushed update to fix.

repo: jamiecaesar/SecureCRT


text:
Optimize Events.trigger method

IIRC it was done in a similar fashion before, but was changed for perfs considerations. See 2c8398483ef3589a1b01b52fd11923c26e68a0df

authors: Florian-R wovchok

repo: jashkenas/backbone


text:
Create Dockerfile

good

repo: javamania/hello-github-actions


text:
identifierNamesGenerator option

Coverage increased (+0.002%) to 98.169% when pulling 74351be7501e2c640fbb098a80d7034b46cf47fd on identifier-names-generator-option into fb8b604ec4c9eac877b3c7fc7a81db5959e3f85c on master.


text:
Fixes javaslang/javaslang#246

Coverage increased (+0.03%) to 99.74% when pulling aaca75f1ef105c2f4b3cf79314eec0e56bf8e199 on danieldietrich:master into 6735ae7e7076d0966b0be33bd0b2dd0b10509e4c on javaslang:master.

Coverage increased (+0.03%) to 99.74% when pulling b1d2b880a2b2b41996ba847b926d906f6cd8e0fa on danieldietrich:master into 6735ae7e7076d0966b0be33bd0b2dd0b10509e4c on javaslang:master.

Coverage increased (+0.1%) to 99.82% when pulling b1d2b880a2b2b41996ba847b926d906f6cd8e0fa on danieldietrich:master into 6735ae7e7076d0966b0be33bd0b2dd0b10509e4c on javaslang:master.

authors: coveralls danieldietrich

repo: javaslang/javaslang


text:
Applied fixes from FlintCI

Lint errors were found.
Please see the report: https://flintci.io/repositories/3669/analyses/4017
This comment was posted by FlintCI. It can be disabled in the repository settings.

authors: FlintCIBot jderusse

repo: jderusse/acmephp


text:
make changes to list of watchers and subticket contents

Fixed in release 1.2.9

repo: jfix/pac-toolkit


text:
websocket-client python

delete

repo: joewalnes/websocketd


text:
Remove gulp-util.

Coverage remained the same at 95.652% when pulling 7d15b0ba08a80b1881f5ea382349468cf5994faf on remove-gulp-util into 375a13f18d911f629329e5e993771ca890f84636 on master.

authors: coveralls jonkemp

repo: jonkemp/extract-css


text:
Update lingua-rs to 1.2.2

Pull Request Test Coverage Report for Build 02263baba929dc5d35983d4bbe3529a6be002738-PR-8

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 85.714%

Totals

Change from base Build fe67fd8f34026f0f14559e22ce446334fff8ff62:
0.0%

Covered Lines:
18

Relevant Lines:
21

💛  - Coveralls

authors: coveralls joshrotenberg


text:
Mentioned installation dependencies

Hmm I don't know why this build failed. This change does not affect the application logic since it only modifies CONTRIBUTING.md

LGTM, waiting on travis to rebuild.

When I was first installing binderhub, it failed since I did not have socat installed. While I don't see it as a direct dependency it might be tornado that relies on it.

Would you guys think that this statement is too basic to include?
Make sure that your current working directory is a copy of this repository.

While this step is probably automatic for Github veterans, I was confused during my installation since this step is never mentioned in the instructions. Based on this, I had assumed that the instructions would have included something like a curl command or git clone to download binderhub like you did with jupyterhub and helm.

@Miniland1333 adding a git clone as the first step is great idea. Let's start with cloning the repository:
git clone https://github.com/jupyterhub/binderhub

Okay I made both the socat and git clone changes. In the "before you begin" section, I am not sure if docker and socat would be better off in their own discreet step rather than with the "before you begin".
@minrk I gave you push access if you'd like to make additional formatting changes.

LGTM, we can refine later on if needed.

authors: Carreau Miniland1333 betatim minrk

repo: jupyterhub/binderhub


text:
add udp connection function

Status?

Closing in favor of #17

authors: hit9 kavu matishsiao


text:
[add] exit code

All CI has passed.

repo: kazukazuinaina/vimstartup


text:
Fix typos on gh-pages landing page

Thank you!! :+1:

authors: cdrage robin-owen

repo: kedgeproject/kedge


text:
Publish

Codecov Report

Merging #235 (0275973) into main (9c168ca) will increase coverage by 0.00%.
The diff coverage is 100.00%.

:exclamation: Current head 0275973 differs from pull request most recent head 53f6d45. Consider uploading reports for the commit 53f6d45 to get more accurate results

@@           Coverage Diff           @@
##             main     #235   +/-   ##
=======================================
  Coverage   86.69%   86.70%
=======================================
  Files         526      526
  Lines        6526     6529    +3
  Branches      595      595
=======================================
+ Hits         5658     5661    +3
  Misses        794      794
  Partials       74       74

Impacted Files
Coverage Δ

src/modules/widgets/saga/datePickerWidget.ts
98.42% <100.00%> (+0.03%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c168ca...53f6d45. Read the comment docs.

authors: codecov-commenter maciejrybaniec

repo: keen/dashboard-creator


text:
Design: Ability to disconnect / sign out of wallet

Design for this in Figma: https://www.figma.com/file/Su61MwHLrQn3ld24q85pMx/Token-Dashboard-dApp?node-id=6474%3A33920

repo: keep-network/keep-core


text:
Why are you wasting GitHub's servers on this crap

shit pressed the enter key by mistake

GitHub is hosting lottsa code, and their servers are being wated on this hot trash xD

That's the point!
By writing no code, we save them a lot of precious data space!!!

What about the documentation?
that wastes more space than I am in the universe

Instead, I think this repo could be moved to this place.

GitHub's server doesn't mind. why do you mind?

Lorem ipsum dolor sit amet, consectetur adipiscing elit. Morbi velit elit, condimentum in turpis non, facilisis malesuada lorem. Etiam ligula nisi, convallis fermentum dolor iaculis, vulputate feugiat sapien. Duis aliquet quis magna in ullamcorper. Pellentesque fermentum elit vel nisl pharetra, vel semper ligula tincidunt. Nam id viverra tortor, id viverra neque. Nulla pretium nunc ac ipsum suscipit aliquam. In consectetur pretium sapien, vitae rhoncus ligula lacinia ac. Nam leo eros, tempus eu metus id, rutrum gravida nibh. Sed eu eleifend arcu.
Sed ac ultricies lorem. Maecenas id nibh nec eros congue aliquet. Pellentesque enim tellus, hendrerit a sem a, euismod cursus mauris. Nullam eleifend libero in tellus eleifend, commodo fringilla augue ullamcorper. In tincidunt volutpat nisi, vel aliquet sapien dignissim quis. Morbi quis ante mi. Duis luctus nisi lectus, sed gravida enim egestas vitae.
Duis vel sapien non turpis tempus rhoncus. Sed velit ipsum, vehicula sed sapien a, iaculis aliquet massa. Donec quis blandit mi. Quisque placerat ligula vitae dapibus porttitor. Quisque et urna nec ex mattis fringilla. Proin mollis consequat augue congue volutpat. Nunc metus nibh, dapibus non ligula eu, venenatis interdum tortor. Duis gravida lectus et fermentum sagittis. Sed pharetra nibh viverra varius ultricies. Maecenas eu odio dui. Nunc purus odio, efficitur in aliquet id, molestie non erat.
Fusce at nunc imperdiet libero feugiat venenatis vitae eu ex. Proin malesuada tempor tortor, nec malesuada nibh placerat sed. Cras non tortor nibh. Suspendisse eleifend nunc sollicitudin, efficitur elit vitae, rhoncus ipsum. Nulla ut dolor nisi. Mauris congue leo odio, in pulvinar odio vulputate eu. Integer efficitur porttitor sapien lobortis blandit. Class aptent taciti sociosqu ad litora torquent per conubia nostra, per inceptos himenaeos. Duis maximus ac ex ac sollicitudin. Aenean ut nibh nec mi aliquet lobortis id at purus.
Donec eu quam mollis, pellentesque magna id, interdum lectus. Sed pretium placerat lacinia. Maecenas eu accumsan ante, vitae sodales purus. Sed pulvinar orci sed velit faucibus vulputate. Cras pharetra sapien eget posuere consequat. Nulla magna tellus, porttitor mattis augue eu, fermentum aliquet nunc. Aenean et mollis dui. Fusce id posuere urna. Suspendisse nisl tortor, feugiat a nisi ac, venenatis vehicula sapien. Duis in sapien in augue fringilla sagittis. Mauris laoreet tortor lorem, a auctor ex vulputate eu. Pellentesque aliquam pellentesque ligula, ut tristique orci condimentum ac. Vestibulum convallis vitae nisi a dignissim. Etiam scelerisque malesuada nibh in consectetur.

You're right, the load might be too much... we should replicate nocode to Bitbucket and Gitlab too. Just to be safe.

authors: 06chaynes GNOME-IS-LIFE Pizzacus Somefive lewisdonovan zLinz

repo: kelseyhightower/nocode


text:
try to revert problematic part of commit

It caused compile options to be dropped by the makefile.

repo: kframework/llvm-backend


text:
Appveyor2

Download:
Environment: QT=5.12, ARCH=32, CONFIGURATION=release, QTIFW=C:\Qt\Tools\QtInstallerFramework\3.1

authors: AppVeyorBot khodand

repo: khodand/trik-studio


text:
fix: CLI crash when an explicit example is specified in endpoint definition

Codecov Report

Merging #393 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master   #393   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files          25     25
  Lines        1787   1787
  Branches      280    280
=====================================
  Hits         1787   1787

Flag
Coverage Δ

#unittests
100% <100%> (ø)
:arrow_up:

Impacted Files
Coverage Δ

src/schemathesis/_hypothesis.py
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c4df8d5...c60bc49. Read the comment docs.

repo: kiwicom/schemathesis


text:
Set jobs to done when handler throws

Not needed with Bee-Queue.

repo: kjellmorten/integreat-queue-redis

license: ISC


text:
initial implementation of transform command

Minor update to the commit to remove a commented-out debug line that I forgot to get rid of.

Not sure if this matters or not but I was running the creation of crane from a container and hit
go: github.com/sirupsen/logrus@v1.6.0: missing go.sum entry; to add it:
454
	go mod download github.com/sirupsen/logrus```

authors: cooktheryan sseago

repo: konveyor/crane


text:
Adding type to log.

Part of #1279

repo: kubernetes-incubator/service-catalog


text:
Fix JSON object for service account policy

Looks like this has been fixed now.

authors: ghodss pwittrock


text:
ClusterOverview: Improve prometheus query for CPU Capacity

@mareklibra wouldnt it be better to use the same query as Utilization is using and just take the latest value ? We could just delete CPU_TOTAL and CPU_USED and in web-ui-components take utilization cpu result a parse it there.
It would result in less remote requests.

The number of remote requests grows rapidly ...
We can merge even in https://github.com/kubevirt/web-ui/pull/259

authors: mareklibra rawagner

repo: kubevirt/web-ui


text:
Skip worker_bootstrap when cloud_framework is openstack, bsc#1089652

Travis is complaining
Offenses:
app/controllers/setup_controller.rb:67:3: C: Metrics/CyclomaticComplexity: Cyclomatic complexity for worker_bootstrap is too high. [8/6]
  def worker_bootstrap
  ^^^
app/controllers/setup_controller.rb:67:3: C: Metrics/PerceivedComplexity: Perceived complexity for worker_bootstrap is too high. [8/7]
  def worker_bootstrap
  ^^^
166 files inspected, 2 offenses detected

Don't know if should I fix it or we are fine?

Don't know if should I fix it or we are fine?

Ehh - Lets add a ignore comment for now to keep travis happy. We want to merge ASAP.

codeclimate can be ignored i guess +1

That's a bug in GitHub! (really .. theres something horribly wrong with GitHub the last few days ;))

 Bug 1089652 - Can't bootstrap cluster due to missing /srv/velum/config/data/openstack-types.json in the velum image

authors: kiall mjura

repo: kubic-project/velum


text:
update

update

repo: kuluoluoji/AdminLTE


text:
Link to GIFVs instead of GIFs

Do you happen to have an example of a GIF being mirrored so I can take a look?

@Shugabuga https://www.reddit.com/r/stevenuniverse/comments/4zkk3z/oldtimey_pearl_and_garnet_animation/d6wjq4u

@Vicyorus  Like this?

@Shugabuba Well, yes it'd help if imgur wouldn't redirect you to their crappy site, but yes, adding a "v" at the end. Kupiakos told me to open an issue to remind me of it, so I did.

Yeah, and that's great that you did!
I don't really know how the imgur export plugin works (or any export plugins), but maybe @kupiakos can add a link to both GIF and GIFV??? Just an idea.

I think I've got it. In line 308 of lapis.py,
the code links_display = ''.join(links_display_parts) is combining the links into a string. A simple regex check and replace ".gif" with ".gifv" in said string, and then reassignment should do it. Should work with every plugin as this is processed after the export data returns.

Any code involving gifv should be in the imgur export plugin, not in
lapis.py. Also, I'm not sure it's guaranteed that animations end in .gif on
imgur.
On Oct 12, 2016 7:58 AM, "Shamee Mahmud" notifications@github.com wrote:

I think I've got it. In line 308 of lapis.py,
the code links_display = ''.join(links_display_parts) is combining the
links into a string. A simple regex check and replace ".gif" with ".gifv"
in said string, and then reassignment should do it. Should work with every
plugin as this is processed after the export data returns.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

Got it, I see where its being exported in imgur.py.
Maybe there's a way to get the mime type of an Imgur URL and determine what the proper url should be from there? I'll take a look into that.

Also, it may be worth noting that GIFVs on Imgur (tested on the one provided by Vicyorus using cURL) have a MIME type of text/html; charset=utf-8, but the normal GIFs are normal (image/gif).

Hmm, what about... there's an interesting thing with the way imgur works. What if you just linked every imgur image (not albums) as a .gifv? Regardless of the extension, if it exists, if you replace the extension with a .gifv, it should always return the correct type. If you linked say, a .jpg image with .gifv, a .jpg image would be returned. If you linked a .gif image with .gifv, a .webm image would be returned.

@spiral6 I'd prefer not. The HEAD request that is done normally in many cases could be used to add information from the import plugin about whether it's animated or not, if it doesn't already. A HEAD request will contain the MIME-type of the content, and we can check if it's an animated format during import.

authors: Shugabuga Vicyorus kupiakos spiral6

repo: kupiakos/LapisMirror


text:
[5.3] Container - Replacing call_user_ calls

Closing. Broken on PHP 5.6. 🤔

repo: laravel/framework


text:
inclusion of courses and removal of repeated data

Valeu @vitoravale 🎉
Obrigado pelo PR

authors: oguhpereira vitoravale

repo: learnbr/javascript


text:
#428: add email_validator in the install_requires list

Codecov Report

Merging #429 (eb1cfac) into master (c25fdf0) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #429   +/-   ##
=======================================
  Coverage   98.03%   98.03%
=======================================
  Files          18       18
  Lines         967      967
  Branches       75       75
=======================================
  Hits          948      948
  Misses         17       17
  Partials        2        2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c25fdf0...eb1cfac. Read the comment docs.

Duplicate of #421

authors: codecov-io davidism emregeldegul

repo: lepture/flask-wtf


text:
希望可以尽快支持ios，安卓端感觉还不错

See https://github.com/leyan95/qrcode_scanner/pull/38


text:
PM981a可以作从盘吗？

No description provided.

在苹果系统下需要把981屏蔽，在windows系统下可以用


text:
Two reverts to resurrect the builds

The commits being reverted has broken the build (all the targets):
https://ci.linaro.org/view/All/job/lhg-oe-build/174/
These changes need to be re-implemented and then resubmitted via pull requests.

repo: linaro-home/meta-lhg


text:
Fixed bug that character encoding changed.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

authors: CLAassistant uich

repo: line/clova-cek-sdk-java


text:
fix dataset path conversion

Coverage remained the same at 27.651% when pulling f841e5f68ee9907b7c5d0f90720595da6ce42109 on theseyi:dataset-path into d4347b70faf3c365b175b2dc91400325d0655f41 on linkedin:master.

Codecov Report

Merging #987 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #987      +/-   ##
==========================================
+ Coverage   27.42%   27.43%   +<.01%
==========================================
  Files         170      170
  Lines        4638     4640       +2
  Branches     1219     1220       +1
==========================================
+ Hits         1272     1273       +1
- Misses       3366     3367       +1

Impacted Files
Coverage Δ

wherehows-web/app/utils/validators/urn.ts
73.68% <100%> (-2.79%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d4347b7...f841e5f. Read the comment docs.

authors: codecov-io coveralls theseyi

repo: linkedin/WhereHows


text:
Job state stored in distributed cache in MR mode.

@chavdar @sahilTakiar can you review? This addresses https://github.com/linkedin/gobblin/issues/911

Coverage decreased (-0.3%) to 42.703% when pulling 210c4e28162478726b2576188d90ef361a991d7d on ibuenros:serialize-state-replication into 6c53d517994aa6737d65a8530331f4878cb6d519 on linkedin:master.

@sahilTakiar I tried using MRJobLauncher.addHDFSFiles but I couldn't get it working. DistributedCache.getLocalCacheFiles(context.getConfiguration()) throws an NPE, and trying to simply load new File(name) cannot find the file.
Any suggestions?

Coverage decreased (-0.1%) to 43.505% when pulling 3ea72ab60acb7444e82a5fa8af204cecf6a800a1 on ibuenros:serialize-state-replication into 5344ec223062ebd51d99a4aa0aebf55cbbc98061 on linkedin:master.

Talked with @sahilTakiar offline. Merging.

authors: coveralls ibuenros

repo: linkedin/gobblin


text:
Allow paste in number input

@steadicat fix for this is in the next release. Thanks for reporting

authors: jorilallo steadicat

repo: lionsharecapital/lionshare-desktop


text:
有没有混淆规则

默认的不需要混淆
如果集成了ijkplayer，只需要添加ijkplayer的混淆

repo: lipangit/JiaoZiVideoPlayer


text:
Can it play videos from yourube and vimeo via url?

maybe no,  you can try it.


text:
Create DB class

Add new columns to properties table based on api fetching more info:
Columns: latitude(float), longitude(float), city_hebrew(varchar), state_hebrew(varchar), address_hebrew(varchar)

repo: lnros/real-estate-web-scraping


text:
add xml converter

closing in favor of https://github.com/locationtech/geomesa/pull/677

authors: BrittEvans elahrvivaz

repo: locationtech/geomesa


text:
Link some javascript file

Close to resolve conflicts


text:
find out how to make tewifw actually work

What does tewifw mean?

Well there's a bold and medium version of it in the repo...

authors: NetOperatorWibby lucy patrick-motard

repo: lucy/tewi-font


text:
Syncing to Original

Syncing...

repo: luismieryteran/zika


text:
Build layout for component glossary

CSS/HTML design for component glossary

Love it @roi - if I had suggestions, they would be:

Info on the left could remove the 'comprised of' and 'related elements' section and instead give a list of the locals the block expects, along with a brief description of each one (i.e. in a table, like Stripe)
Top 'Layout/HAML/Sass' -> could we make these more 'tab-like'? At the moment I worry they look a bit like 'vertical' buttons

This is the sex, though. We have a blockquote element but it doesn't look anything as sexy as yours

Thanks @sjmog, I shall be implementing your suggestions fo' sho. :space_invader:

I'm researching how to pull in files automatically so this always stays up-to-date when new components are added (automating documentation)

Fixed in website_docs repo.

authors: pitchinvasion roidriscoll sjmog


text:
Add the ability to tippecanoe-decode a standalone .pbf tile

Coverage decreased (-0.08%) to 82.906% when pulling d960963623a871599d6bfe42cb6a89727c4c3015 on decode-pbf into 7140a3dd912024326bf49541ad10dcf02b47080a on master.

Coverage decreased (-0.008%) to 82.982% when pulling 962f82d44ededf9f573a1f41aa5d6e175da2e65e on decode-pbf into 7140a3dd912024326bf49541ad10dcf02b47080a on master.

authors: coveralls ericfischer

repo: mapbox/tippecanoe


text:
4.3.2 Create db route for getting chats

The functionality in this ticket has been manually tested in the test database on Firebase


text:
Delete Experiment

The first level was finished where it doesn't show up in the ui. However there is a lot of cruft left over in the database.


text:
Add test showing verifying failing general caveat fails

LGTM

authors: NegativeMjark illicitonion

repo: matrix-org/pymacaroons


text:
Added test case for JsonTypeInfo.As.EXISTING_PROPERTY

Thanks.. Looks like this shows that #36 is already fixed

authors: andrii-NIX mbknor

repo: mbknor/mbknor-jackson-jsonSchema


text:
Add modernizr to vendor assets

Obsolete.

repo: mdotasia/mdotasia-theme


text:
Configure the banana dashboard to show the data from last 10 days

Actually, it shows from a specific date: 5/31, but it accomplished the same thing.

repo: memex-explorer/sce


text:
[INFINITY-1396] Remove unused MIGRATION labels

I couldn't find evidence that marathon actually reads these endpoints. It probably should... @aquamatthias ?

@jasongilanfarr the readiness check defines the contract (incl. path etc). Marathon still has checks for the tags: https://github.com/mesosphere/marathon/blob/master/src/main/scala/mesosphere/marathon/state/AppDefinition.scala#L484

I know that we have the validation checks, but i didn't see us actually use the fields.

It is used by the UI to query the plan and do the proceed operations.

The DC/OS UI team doesn't use this.

repo: mesosphere/dcos-commons


text:
Add pinned vendor/ dependencies

Could you please add a short section or command line that can be used to update & maintain the vendored deps?

Here's a quick intro on how to set up govendor, the dependency management tool we're using. https://github.com/mesosphere/mesos_exporter/wiki/Dependency-management

Thanks! :)

authors: StephanErb jonashaag


text:
machine lock/unlock, small refactoring

Codecov Report

Merging #1 into master will increase coverage by 0.1%.
The diff coverage is 0%.

@@            Coverage Diff            @@
##           master       #1     +/-   ##
=========================================
+ Coverage   12.52%   12.62%   +0.1%
=========================================
  Files           8        8
  Lines         623      618      -5
=========================================
  Hits           78       78
+ Misses        532      527      -5
  Partials       13       13

Impacted Files
Coverage Δ

machine.go
16.03% <0%> (+0.58%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8304ab5...a01124d. Read the comment docs.

repo: metal-pod/metal-go


text:
Skills + OAuth + Conversation IDs: Populate RelatesTo field with root conversation reference and pass to token service

This will be resolved when porting this: https://github.com/microsoft/botbuilder-python/issues/711

repo: microsoft/botbuilder-python


text:
Add command to update VS Code from command palette

I merged https://github.com/microsoft/vscode/pull/77515 instead, thanks anyway!

repo: microsoft/vscode


text:
Fix/mw support auto load plugin

Codecov Report

Merging #29 (3738eed) into master (084f647) will increase coverage by 0.07%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #29      +/-   ##
==========================================
+ Coverage   90.12%   90.20%   +0.07%
==========================================
  Files          35       35
  Lines        2410     2429      +19
  Branches      589      592       +3
==========================================
+ Hits         2172     2191      +19
  Misses        217      217
  Partials       21       21

Impacted Files
Coverage Δ

packages/command-core/src/npm.ts
92.68% <ø> (ø)

packages/command-core/src/cli.ts
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 084f647...3738eed. Read the comment docs.

authors: codecov-io echosoar

repo: midwayjs/cli


text:
Added DateTimeEventArgs and improved data and time validation.

I would recommend changing the Time backing field from a DateTime to TimeSpan

I would recommend changing the Time backing field from a DateTime to TimeSpan

@grahamehorner It has already been done.. Thank you for your recommendation.

I don't understand the move from DateTime to TimeSpan.

@tig I don't think it makes much sense for a Time control to present the date as it was initially happening because both DateField and TimeField are both DateTime types. Also as TimeSpan it is useful in cases where TimeField is used as a timer, timeouts, elapsed time, etc

authors: BDisp grahamehorner


text:
Add test

Coverage increased (+1.6%) to 74.955% when pulling f063f29f4d62b906faf7f505972d97f7d3945eeb on add-test into ae818f42124d208048bca217d78b4f142d088d41 on master.

Codecov Report

Merging #48 into master will increase coverage by 1.86%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master      #48      +/-   ##
============================================
+ Coverage     73.04%   74.91%   +1.86%
+ Complexity     5722     5714       -8
============================================
  Files           331      331
  Lines         11903    11903
============================================
+ Hits           8695     8917     +222
+ Misses         3208     2986     -222

Impacted Files
Coverage Δ
Complexity Δ

src/Factory/Device/Mobile/PipoFactory.php
100% <ø> (ø)
9 <0> (-1)
:arrow_down:

src/Factory/BrowserFactory.php
43.31% <ø> (-2.05%)
1122 <0> (-10)

src/Factory/Device/MobileFactory.php
82.36% <100%> (+3.06%)
530 <0> (+2)
:arrow_up:

src/Helper/MobileDevice.php
89.13% <100%> (+0.49%)
23 <0> (+1)
:arrow_up:

src/Factory/Device/Mobile/FlytouchFactory.php
100% <100%> (+100%)
3 <0> (ø)
:arrow_down:

src/Factory/Device/Mobile/SamsungFactory.php
96.17% <100%> (ø)
732 <0> (ø)
:arrow_down:

src/Factory/Device/Mobile/MicrosoftFactory.php
100% <100%> (+100%)
3 <0> (ø)
:arrow_down:

src/Factory/PlatformFactory.php
82.23% <100%> (ø)
81 <0> (ø)
:arrow_down:

... and 33 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae818f4...f063f29. Read the comment docs.

authors: codecov-io coveralls mimmi20


text:
Add toarray

Changes Unknown when pulling 35239aa650239cac15cf42f97f3f68b193f59754 on add-toarray into ** on master**.

Changes Unknown when pulling 35239aa650239cac15cf42f97f3f68b193f59754 on add-toarray into ** on master**.

Changes Unknown when pulling 35239aa650239cac15cf42f97f3f68b193f59754 on add-toarray into ** on master**.

Changes Unknown when pulling 35239aa650239cac15cf42f97f3f68b193f59754 on add-toarray into ** on master**.

Changes Unknown when pulling 288b600028a65ec88c06e19b18bc700cd757fc13 on add-toarray into ** on master**.

Changes Unknown when pulling 288b600028a65ec88c06e19b18bc700cd757fc13 on add-toarray into ** on master**.

Changes Unknown when pulling 288b600028a65ec88c06e19b18bc700cd757fc13 on add-toarray into ** on master**.

Changes Unknown when pulling 0a35a4047f17cbef09efbccf73c21f031c1e9442 on add-toarray into ** on master**.

Changes Unknown when pulling 0a35a4047f17cbef09efbccf73c21f031c1e9442 on add-toarray into ** on master**.

Changes Unknown when pulling 0a35a4047f17cbef09efbccf73c21f031c1e9442 on add-toarray into ** on master**.


text:
Update NPM deps

Are you going to bump the version?
Also, what about the shelljs vulnerability? Did github/snyk remove it or have we silenced it?

True, version bumped!
I don't see any vulnerabilities occurring

https://github.com/shelljs/shelljs/issues/945#issuecomment-506019725

authors: solidgoldpig umaar

repo: ministryofjustice/fb-specification


text:
feat: 增加阅读器事件和尝试接收

构建成功，请点击链接获取编译代码或预览效果
Built with commit 4ff686f922cf8339672dfc89203d89f7193d9d53
https://deploy-preview-111--mip2-deploy-preview.netlify.com


text:
Conditional compilation of Trace module using cppo

Squashed and merged in #23 - thanks!

repo: mirage/mirage-profile


text:
Use svg for python package badge

Thank you!

authors: MartinDelille miurahr

repo: miurahr/aqtinstall


text:
Feature/manpages

Awesome! :confetti_ball:

authors: neolynx randombenj

repo: molior-dbs/molior-tools


text:
Remove conversion from CurrencyPair

Good call @sagikazarmark. Obviously I was not aware of these methods. But I should have looked better.

Will merge after Travis is happy.

authors: frederikbosch sagikazarmark

repo: moneyphp/money


text:
Updated currencies

This cannot be accepted. We use this https://github.com/moneyphp/iso-currencies package as source for currencies, which in turn uses some official source. If you want to update iso currencies, update via that package.

Most probably I should have written that in the description but what I did was run the composer command that you have in the current package and commit the changes.

I am talking about this command which uses the iso-currencies package.

Ah, then it is completely reasonable. I will check after weekend and merge it then.

authors: frederikbosch gmponos


text:
Make API spec examples more specific for a few fields

Codecov Report

Merging #940 (fc06db1) into master (6b7c502) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #940   +/-   ##
=======================================
  Coverage   91.30%   91.30%
=======================================
  Files          66       66
  Lines        5246     5246
=======================================
  Hits         4790     4790
  Misses        283      283
  Partials      173      173

authors: codecov-commenter nlakritz

repo: moov-io/ach


text:
transfers/pipeline/notify: log Multi Sender types and errors encountered

Codecov Report

Merging #623 (c6df438) into master (274711c) will decrease coverage by 0.28%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #623      +/-   ##
==========================================
- Coverage   51.73%   51.44%   -0.29%
==========================================
  Files          95       95
  Lines        3236     3244       +8
==========================================
- Hits         1674     1669       -5
- Misses       1211     1221      +10
- Partials      351      354       +3

Impacted Files
Coverage Δ

pkg/transfers/pipeline/aggregate.go
12.92% <0.00%> (ø)

pkg/transfers/pipeline/notify/multi.go
0.00% <0.00%> (ø)

pkg/upload/sftp.go
63.42% <0.00%> (-2.86%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 274711c...c6df438. Read the comment docs.

authors: adamdecaf codecov-io

repo: moov-io/paygate


text:
Add missing CSS variable (--bar-menu-min-width) to the README

Ok now I understand what you meant, but this is useless to specify it because the variable default value is already 160px.
https://github.com/motla/vue-file-toolbar-menu/blob/672a34d24508c214dc452f5fe32fa13cd79353c4/src/Bar/imports/bar-default-styles.scss#L122
I guess the styling section is unclear, so I will make it a bit clearer.
Thank you

authors: Josef-Friedrich motla

repo: motla/vue-file-toolbar-menu


text:
Create examples

We could have a discussion on which examples, we’d like to build.

Examples made:

counter
traffic light
sokoban
drag-n-drop

authors: Frikki TylorS

repo: motorcyclets/motorcycle


text:
Switch primary email for MFAd accounts.

Coverage remained the same at 90.708% when pulling bcf9240ae6eb9cb5f549f3e20156b195c96229a4 on akatsoulas:multiple-idps-returned into 600d5e922aaf9d5029c00d5f8b0c7dd286b40bbc on mozilla:master.

authors: akatsoulas coveralls

repo: mozilla/mozillians


text:
Add appveyor testing

The tests actually fail, I think that is the same problem as #65.
You also have to enable appveyor for the repo, and then add the badges etc.

Coverage remained the same at 85.241% when pulling 2191794f384ffdb1edd4e2a3652d61ceaddb59c9 on davidanthoff:appveyor into 33fb6db33c18ffd63c712dfbd30bc80d51364018 on mpastell:master.

Thanks! This is very useful, I'll try to set it up.

@davidanthoff do you know of a good way install PyPlot on appveyor? Or to detect when the test is running on appveyor and skipping certain tests?
The tests on win64 now run fine until PyPlot is needed.

Setting the environment variable PYTHON to empty should get PyPlot working on appveyor

authors: coveralls davidanthoff mpastell tkelman


text:
How to use gpu? I get a error

Which error do you get?

Closing due to inactivity.

authors: WoshiBoluo mseitzer

repo: mseitzer/pytorch-fid