text:
Conversion Error from string[] to string for Message in Enable-PriviledgedRoleAssignment

found that when you get an error back for mfa restrictions that script had issues with printing out the debug messages in the catch. Reworked catch to handle empty variables.
 try{
            Open-AzureADMSPrivilegedRoleAssignmentRequest `
            -ProviderId 'aadRoles' `
            -ResourceId $global:AzureConnDirectoryId `
            -RoleDefinitionId $SelectedRoleAssignmentDefinition."RoleDefinitionId" `
            -SubjectId $global:CurrentLoggedInUser.ObjectId `
            -Type 'UserAdd' `
            -AssignmentState 'Active' `
            -schedule $schedule `
            -reason $Reason

        }catch{
            if($EligibleRoles -eq $null){ Write-Debug "Eligible Roles is empty"} else { Write-Debug $EligibleRoles }
            if($SelectedRoleAssignments -eq $null) {Write-Debug "Selected Role Assignments is empty"} else {Write-Debug $SelectedRoleAssignments.ToString()}
            if($SelectedRoleAssignmentDefinition -eq $null) {Write-Debug "Selected Role Assignment Definition is empty"} else {Write-Debug $SelectedRoleAssignmentDefinition }
             throw "$_."
        }

Thanks, this is now fixed in latest. Should be available in PS Gallery shortly


text:
Google Drive links fail with Error 401 Unauthorized

I'm trying to embed a Google Sheet in an Obsidian note. I'd like to not have to make the sheet publicly accessible, but if I make it private, I get this Error 401 Unauthorized when displaying the note with the embed.
I'm using Obsidian 1.1.16.

Did you log in to your Google account in Obsidian before opening the sheet? You might have to temporarily create a separate frame that links to the Google home page (or some other part of Google that makes it easy to log in) and log in once before you can check the sheet. You can find more info about this sort of issue at #40 as well!

I'll try that, thanks!

Hi! I'm closing this issue for now due to inactivity. If you're still experiencing it, please leave a comment so I can reopen it.

source: gharchive/issue

authors: Ellpeck oscarlosu

repo: Ellpeck/ObsidianCustomFrames

license: MIT

license_type: permissive

license_source: github-api


text:
Hide and Seek

Hey! I´ve been checking out your data-preservation branch and I catch a bug. On your js file, line number 24 up to line number 28 you wrote :
-document.getElementById('.close_btn').classList.remove('show');
-document.getElementById('.menu_hamburger').classList.remove('hide');
-document.getElementById('.menuIcon').classList.remove('mobile_menu');
-document.getElementById('.nav_').classList.remove('mobile_header');
-document.getElementById('.menuIcon').classList.add('menu');
If you want to use classes to select an element from your HTML file, you will want to use querySelector, otherwise, you can remove the class selection and use the ids (work without the dot at the start of your id selector)

Thank you zamora...........great job! and nice working with you

authors: Ellyboi hernandanielzamora

repo: Ellyboi/Desktop-portfolio-website


text:
Not working with react-native: 0.59.4

I just downgraded the react native version to 0.59.2 and it seems working fine.
When I try (actually tried on android only) to pick pdf or text or all files, it opens the document picker successfully but without any file. And when I tried to open it second time, app freezes and not able to do anything...

not working on 0.59.2 ...

any update on this ?
Here too having the same issue
"react-native": "0.59.1"
Nothing is happening while calling the   method "DocumentPicker.pick(....)"

Have you guys found the minimal version where it is working with?

You'll have to downgrade while someone investigates.

@danielsGit What changed between .2 and .4?

import {
DocumentPicker,
DocumentPickerUtil
} from "react-native-document-picker";
...
DocumentPicker.show(
{
filetype: [DocumentPickerUtil.pdf()]
},
(error, res) => {
if (error) {
console.log(error);
} else {
console.log(
res.uri,
res.type, // mime type
res.fileName,
res.fileSize
);
this.props.callback({ fileUrl: res.uri, type: "pdf" });
}
}
);
Will cause the app to crash on iOS, on Android works fine.
"react-native": "0.59.5",
Anyone know what's going on? Thanks in advance

@QuevedoIB can you try using https://github.com/Elyx0/react-native-document-picker/pull/230 to see if that fixes the issue on iOS?

@rajivshah3 is it related with #236 ?

closing, 0.59.4 is an old version

license: mit

license_source: bigquery


text:
Erpc better mbf_static buffer implementation

Hi,
I couldn't stand the static buffer implementation because it

arbitrarily Creates more buffers than needed
Is unreadable because of random shifting
Does things at runtime that should be done at compile time (> c++17 is a thing)
is not templated

Im pretty sure there are people who would disagree with my statements (that's fine) :) , so I'll post my implementation here for anyone who likes a more modern approach for this buffer
How to use:

Create two buffers of length 256 * uint_8
erpc_mbf_t c_message_buffer_factory = erpc_mbf_static_fixed_init<2, 256>();

/*
 * Copyright (c) 2014-2016, Freescale Semiconductor, Inc.
 * Copyright 2016-2020 NXP
 * Copyright 2021 ACRIOS Systems s.r.o.
 * Copyright 2021 DroidDrive GmbH
 * All rights reserved.
 *
 *
 * SPDX-License-Identifier: BSD-3-Clause
 */
#ifndef _ERPC_SETUP_MBF_STATIC_FIXED_H_
#define _ERPC_SETUP_MBF_STATIC_FIXED_H_

#include "erpc_config_internal.h"
#include "erpc_manually_constructed.h"
#include "erpc_mbf_setup.h"
#include "erpc_message_buffer.h"

#include <assert.h>
#include <string.h>
#include <array>

using namespace erpc;

////////////////////////////////////////////////////////////////////////////////
// Classes
////////////////////////////////////////////////////////////////////////////////

/*!
 * @brief Static Message buffer factory
 */
template <size_t BUFFER_COUNT, size_t WORD_COUNT, class WORD_SIZE=uint8_t>
class StaticFixedMessageBufferFactory : public MessageBufferFactory
{
private:
    static constexpr std::array<bool, BUFFER_COUNT> init_free_buffer_bitmap() {
        std::array<bool, BUFFER_COUNT> a{};
        for(size_t i = 0; i < BUFFER_COUNT; i++) {
            a[i] = true;
        }
        return a;
    };
    template<typename T>
    static constexpr void init_buffer(T* b) {
        for(size_t j = 0; j < WORD_COUNT; j++){
                b[j] = T{0};
        }
        return;
    };
    static constexpr std::array<std::array<WORD_SIZE, WORD_COUNT>, BUFFER_COUNT> init_buffers() {
        std::array<std::array<WORD_SIZE, WORD_COUNT>, BUFFER_COUNT> bufs = {{}};
        for(size_t i = 0; i < BUFFER_COUNT; i++) {
            init_buffer(bufs[i].data());
        }
        return bufs;
    };
public:
    /*!
     * @brief Constructor.
     */
    StaticFixedMessageBufferFactory(void) {}
    /*!
     * @brief This function creates new message buffer.
     *
     * @return MessageBuffer New created MessageBuffer.
     */
    virtual MessageBuffer create(void)
    {
        WORD_SIZE* bufPtr = nullptr;
        /// check free buffers and return first free one
        for(size_t i = 0; i < BUFFER_COUNT; i++){
            bool free = free_buffer_bitmap_[i];
            if(free)
            {
                free_buffer_bitmap_[i] = false;
                bufPtr = static_cast<WORD_SIZE*>(buffers_[i].data());
                break;
            }
        }
        // if free buffer found, return that
        assert(nullptr != bufPtr);
        uint8_t* buf = static_cast<uint8_t*>(bufPtr);
        return MessageBuffer(buf, WORD_COUNT);
    }

    /*!
     * @brief This function disposes message buffer.
     *
     * @param[in] buf MessageBuffer to dispose.
     */
    virtual void dispose(MessageBuffer *buf)
    {
        assert(buf);
        uint8_t* bufPtr = buf->get();
        if (bufPtr != nullptr)
        {
            // check buf ptr against all current buffers to see which one it was
            for(size_t i = 0; i < BUFFER_COUNT; i++)
            {
                uint8_t* internalBufPtr = static_cast<uint8_t*>(buffers_[i].data());
                if(bufPtr == internalBufPtr){
                    free_buffer_bitmap_[i] = true;
                    init_buffer(bufPtr);
                }
            }
        }
    }

protected:
    static inline auto free_buffer_bitmap_ = init_free_buffer_bitmap();
    static inline auto buffers_ = init_buffers();
};

#endif // _ERPC_SETUP_MBF_STATIC_FIXED_H_

Is there a need for this? :)

Hello @kikass13 , thank you, yes it looks fine. Would you create a PR? Thanks.

repo: EmbeddedRPC/erpc


text:
Simplify query

Per https://docs.rs/bevy/latest/bevy/ecs/prelude/struct.Changed.html, I think this should be have the same way. Disclaimer: this is untested

This is a neat little change! :)
Can confirm that it's working

source: gharchive/pull-request

authors: EmiOnGit janhohenheim

repo: EmiOnGit/warblersneeds


text:
Stuck at executing https://github.com/Emotiv/cortex-v2-example/blob/master/python/sub_data.py

I do not have the license to the raw data stream, I want to access the free APIs
I made the following changes to https://github.com/Emotiv/cortex-v2-example/blob/master/python/sub_data.py
list data streams
streams = ['mot','met','pow', 'dev']
s.start(streams)

My python is stuck at this

Hi @vishwasdalal ,
I think the problem might from missing a python lib such as python-dispatch or something wrong when receive response message from websoscket. So

do you install python-dispatch via "pip install python-dispatch" ?
Please add a debug log to on_message function at cortex.py as below? And let us know the result
def on_message(self, *args):      recv_dic = json.loads(args[1])      print( recv_dic)      if 'sid' in recv_dic:
Thanks

hi @tungntEmotiv
1.do you install python-dispatch via "pip install python-dispatch" ?

I have python-dispatch installed already

Please add a debug log to on_message function at cortex.py as below? And let us know the result

well I inserted a breakpoint at on_message and the program is stuck before that, on_message is never called.

this is where this shows up, this is in threading.py

authors: tungntEmotiv vishwasdalal


text:
Empire does not start

Empire Version
2.0
OS Information (Linux flavor, Python version)
Kali 2017.1 rolling
Expected behavior and description of the error, including any actions taken immediately prior to the error. The more detail the better.
After install and trying to run script gives an error
Screenshot of error, embedded text output, or Pastebin link to the error
root@kali:~/Empire# ./empire
Traceback (most recent call last):
File "./empire", line 11, in
from lib.common import empire
File "/root/Empire/lib/common/empire.py", line 27, in
import agents
File "/root/Empire/lib/common/agents.py", line 64, in
from zlib_wrapper import compress
ImportError: No module named zlib_wrapper
Any additional information

pip install zlib_wrapper ?

root@kali:~/Empire/setup# pip install zlib_wrapper
Requirement already satisfied: zlib_wrapper in /usr/local/lib/python3.5/dist-packages

You need to use python 2.7

pip2.7 install zlib_wrapper solved it.. thx for help

repo: EmpireProject/Empire


text:
Frontend Documentation

We need to have documentation for the Frontend, to have an easier time developing in the future

Initiated by #112

authors: koseward mcauley-penney

repo: Empyrean-Capstone/Empyrean


text:
Feature: Create Alert for DeviceList

Type of change

new feature

Description
The alert component for DeviceListPage has been created along with unit tests.

added some review comments

Thanks for your review @ajaypratap003. Knowing about these standards will certainly help me in improving my PRs in future. Do have a look at the updated PR. :)

repo: EnMasseProject/enmasse


text:
🛑 OculusDB is down

In e9a2532, OculusDB (https://oculusdb.rui2015.me/) was down:

HTTP code: 0
Response time: 0 ms

Resolved: OculusDB is back up in 71a9b69.

repo: EnderdracheLP/Beat-Saber-Uptime


text:
Perform validations for connect consumption MP (task for accept/reject story)

The following Validations are applicable for connect MP
Input Input validations have been split into its own issue #247 (zenhub)
~~- [ ] The identification of a metering point is mandatory (Use GsrnNumber object for format validation) ~~
~~ - [ ] The occurrence of a metering point is mandatory ~~
~~ - [ ] The occurrence of a metering point has format YYYY-MM-DD HH:MI:SS (UTC+0) (Use Occurrence-value object) ~~
~~ - [ ] The occurrence of a metering point has format YYYY-MM-DD 00:00:00 (local time) (Use Occurrence-value object) ~~
~~ - [ ] The identification of a transaction is mandatory ~~
Authorization

[ ] The sender of a message must currently be an existing and active market party (company)
[ ] The sender role of a message must be DDM (Grid access provider)

XML Schema

[ ] The energy business process of a metering point is mandatory
[ ] The physical status of a metering point is mandatory
[ ] The sender of a message is mandatory
[ ] The document type of a message must be E58 (Request update master data metering point)
[ ] The energy business process of a message must be D15 (Connect metering point)

Business rule (Policy)

[ ] The data information must be received within the correct time period
[ ] The identification of a transaction is unique for the sending market player

Business rule (invariant)

[ ] The physical status of the Metering Point to which the master data applies must change from New to Connected
[ ] The production Metering Point to which the master data information applies may only be connected if a Balance Supplier is registered on the effectuation date.
[ ] The consumption Metering Point with supply obligation to which the master data information applies may only be connected if a Balance Supplier is registered on the effectuation date.
[ ] If the physical status is not New (D03) and type of a metering point is Net production (D05), Supply to grid (D06) or Consumption from grid (D07) then sub type must be Physical (D01).
[ ] If physical status of a D20 metering point is changed to Connected (E22), the metering point must be coupled to a parent

** Needs clarification**

[ ] The recipient of a message is mandatory
[ ] The recipient of a message must currently be an existing and active market party (company)
[ ] The ScheduledMeterReadingDate1 is mandatory for the type of metering point if (MP is profiled) or (MP is non-profiled or flex, NSG6 and physical status not NEW)

https://github.com/Energinet-DataHub/geh-market-roles/issues/469

Look into what validations we need to implement for

@erduna I have updated with revised validations from business.

Covered by individual create MP stories. This one is closed.

repo: Energinet-DataHub/geh-metering-point


text:
WSDL in XML-service  (synchronous error). INC0285495 (overført af Irene)

When they deliver messages to DataHub 3.0, thgey receive sometime an error message synchronously (described in the XIM XML and CIM JSON web service document). It can e.g. be a schedule error so that the message can not be persisted. Please see attached an example of such an error.
Is there a WSDL on this message type and what fields will the error message contain?

@PerTHenriksen this has nothing to do with API Management so I'm not sure we in Mighty Ducks can be helpful in solving this issue.
@Christian-Meyer @Tm1807 does this issue look familiar to you?

Efter aftale med Titan får I denne sag

Der forefindes ikke en WSDL. Beskrivelsen findes i dokumentet 'Web Service Definition'.
Link er her: https://energinet.dk/-/media/DAC4FC8BF0B04259BEEE94240B1D4C77.pdf

authors: IreneDataHub PerTHenriksen Tm1807 mknic

repo: Energinet-DataHub/green-energy-hub


text:
Support for SketchUp Make (free)?

Hi there. I'd love to use this in a personal project I'm doing with SketchUp Make (free version), but your plugin page seems to indicate it only works with the "Pro" version. Is there a technical reason for this? Or just a decision to only support the Pro version?

I am also interested !

Yup, this limitation is because of the Extension Warehouse user agreement. You can download the plugin here from GitHub and remove the check for Pro.

@Eneroth3 Yes, good idea but can you tell me in a few words how to easily build an .rbz in Windows?

Good idea. Thank you so much.
For Windows users, go here: C: \ Users \ xxxxxx \ AppData \ Roaming \ SketchUp \ SketchUp 2017 \ SketchUp \ Plugins \ ene_solids and modify the menu.rb file ;-)

This is superb solid tools for 2017


text:
update endpoint docs

Copy of PR https://github.com/Ensembl/ensembl-rest/pull/376 (release/98) now on master
Description
Using one or more sentences, describe in detail the proposed changes.
One more VEP plugin will be available through the VEP endpoint. The documentation in this PR is needed for the plugin. The corresponding parameters config are in PR https://github.com/Ensembl/ensembl-rest_private/pull/61
Use case
Describe the problem. Please provide an example representing the motivation behind the need for having these changes in place.
Plugin functionality available through REST.
live: http://rest.ensembl.org/documentation/info/vep_id_get
sandbox: http://ves-hx2-76.ebi.ac.uk:6083/documentation/info/vep_id_get
Benefits
If applicable, describe the advantages the changes will have.
Without this documentation, the endpoint will not display the availability of the functionality in the background.
Possible Drawbacks
If applicable, describe any possible undesirable consequence of the changes.
Testing
Have you added/modified unit tests to test the changes?
No tests added. Local test server page checked manually.
If so, do the tests pass/fail?
pass
Have you run the entire test suite and no regression was detected?
No change to code. Test ran.
Tested : http://hx-noah-74-15:3000/vep/human/id/rs699?content-type=application/json;CADD=1
Changelog
Are you changing the functionality of an endpoint? If so, please give a one line summary for the public facing changelog.
[/vep/:species/hgvs/] new plugin option added: CADD
[/vep/:species/id/] new plugin option added: CADD
[/vep/:species/region/] new plugin option added: CADD

Coverage decreased (-0.001%) to 44.288% when pulling 969c14c8e3d60a1bd70776b3c4a135f250687a44 on ima23:update_docs_m into bc765fb62b2cee55605011a90ea90663a65cdbf4 on Ensembl:master.

repo: Ensembl/ensembl-rest


text:
Use Feature::species() as the only source for species name

This would ease making Compara's ConstrainedElement a sub-class of Feature. ConstrainedElement's adaptor does not derive from BaseFeatureAdaptor. It is Compara's ConstrainedElementAdaptor which "species" is "Multi".
With the proposed change in, we only have to override ConstrainedElement::species()

that looks reasonable to me

Agreed, it probably should have been using that method all along.

authors: magaliruffier muffato nerdstrike

repo: Ensembl/ensembl


text:
Fix EMBL-format sequence print outs for lengths over 1Gb

Description
For sequence regions over 1 billion bases in length, when these are printed out in EMBL file format, a space is currently missing on lines between the sequence and the sequence coordinates (when the coordinates go over 1 billion).
This PR fixes the issue by adding a space character to the EMBL sequence string.
Use case
A number of metazoan species now have sequence regions over one billion bases in length.
One example is the sequence region NC_064626.1 from species (with production name) schistocerca_cancellata_gca023864275v2rs with the length of 1288847234 bases.
In the current FTP file, a space is missing between the DNA sequence and the sequence position coordinates:
$ grep -C 10 '1288847220' Schistocerca_cancellata-GCA_023864275.2-2023_03-genes.embl
     ATGTTGAATA CACCGGTTCT CGTCCGATCA CCGAAGTTAA GCAACATCGG GCCCGGTTAG1288846620
     TACTTGGATG GGTGACCGCC TGGGAACACC GGGTGCTGTT GGCTCTATCT CATTTTTTCC1288846680
     TTCTTACGTC GCTGCACCTG CCAGGCCTCT TTTTCATGCT AACTATCAGG TGTGACAAAG1288846740
     ATGCTTCCAC AAGCATTTTA AACTACTGTA TCAAACGTAA GATACGAAAT TACAGTAATG1288846800
     AACTCAGTTT GCGCAAGAAT GCGCGAAAGA AGAGAGTGCT GGAACGCCTT GAAAATAACA1288846860
     AACACACTAC GAATCGACAG ATGAGTTCTG AAATAAGTCA GGGCCTACTG TTTTGTAGCA1288846920
     GTGCTGAATT CCACAAAGTA AATAAACAAA AAAAAAAAAA AAAAACAAAA AAAACAAAAA1288846980
     ATCTTCCGTT CTCGTCCGAT CACCGAAGTG AAGCAACAAC GTTAGTACTC GGAAGGGTGA1288847040
     GCGCCTGGGA ACTCTGGCTG TCTTCATTTT TCGCTTTTTA GTCGCTACTC CTGCCAGCCC1288847100
     TCTTTCCATA GCAATTTTCT GTTGTGACAA AGAGACTTCC TTAAGCATTT GAAACGGCCG1288847160
     TAAGGTACGA AACTGCAGTA ATTAACTCAG TTTGAAGGAG AATGTGGCAA CCAAGTTTGC1288847220
     CAGGAAGTCT TTGA                                                  1288847234

After applying the fix, this is the same region printed out, which now has a space:
$ tail out.schistocerca_cancellata_gca023864275v2rs.embl.dat
     AACTCAGTTT GCGCAAGAAT GCGCGAAAGA AGAGAGTGCT GGAACGCCTT GAAAATAACA 1288846860
     AACACACTAC GAATCGACAG ATGAGTTCTG AAATAAGTCA GGGCCTACTG TTTTGTAGCA 1288846920
     GTGCTGAATT CCACAAAGTA AATAAACAAA AAAAAAAAAA AAAAACAAAA AAAACAAAAA 1288846980
     ATCTTCCGTT CTCGTCCGAT CACCGAAGTG AAGCAACAAC GTTAGTACTC GGAAGGGTGA 1288847040
     GCGCCTGGGA ACTCTGGCTG TCTTCATTTT TCGCTTTTTA GTCGCTACTC CTGCCAGCCC 1288847100
     TCTTTCCATA GCAATTTTCT GTTGTGACAA AGAGACTTCC TTAAGCATTT GAAACGGCCG 1288847160
     TAAGGTACGA AACTGCAGTA ATTAACTCAG TTTGAAGGAG AATGTGGCAA CCAAGTTTGC 1288847220
     CAGGAAGTCT TTGA                                                   1288847234

Benefits
A space between the sequence and the sequence coordinates will be retained for sequences over the length of 1 billion.
Possible Drawbacks
Considered the impact on the current EMBL file format but cannot see anything online regarding why adding an addition column to the sequence section would cause negative impacts.
Testing
Have you added/modified unit tests to test the changes?
If so, do the tests pass/fail?
Have you run the entire test suite and no regression was detected?

@sgiorgetti @nwillhoft I'll need this backported on release/110 111 and 112 as well. please.

@marcoooo  - why 110? Aren't we going to roll 111 out soon?

@marcoooo @sgiorgetti Please can I double-check about PRs against 110 and 111 - I'd understood from Monday's RelCo meeting that 111 data had been patched (so am now assuming 110 will have also been patched).

authors: marcoooo nwillhoft sgiorgetti


text:
Relayout landing page

Make spielwiese and editor more prominent,
quests are ordered by tag (not tagged separately)
GitHub -> über das Projekt

wow, took a while, but it now looks good

repo: Entkenntnis/robot-karol-online


text:
Compiler Explorer - Opt-17 not working

LLVM ERROR: Could not load library '/opt/compiler-explorer/main/LLVMEnzyme-17.so': /opt/compiler-explorer/main/LLVMEnzyme-17.so: undefined symbol: _ZN4llvm16AAReturnedValues2IDE

fixed

repo: EnzymeAD/enzyme-explorer


text:
[NF] Coupling with Altair Flux

Hello,
I am opening this issue to start discussion around Altair Flux coupling:
-What would be the objectives of the coupling (import results from Flux, build models in Flux, launch simulations etc.)?
-Is there already any Python package that we could use to interface with Flux? We already did some functions a while ago to build geometry in Flux and that we can provide to anyone who is willing to contribute.
-How could we implement the Flux coupling eventually?
Best regards,
Emile

Hello Emile,
It is an interesting project. In Altair Flux Forum, their engineer shared some documentations about coupling Altair Flux and Python as follows:
Altair_Memento_python_GB-v2.1.pdf
Altair_Memento_pyFlux_GB-v2.2.pdf
If I understand well, Altair allows using "Python code" to operate Flux object. That means you can program Python scripts (it is called PyFlux) in Altair Flux window. But it is impossible to drive Flux in Python IDE. If you want to operate Flux with python code, you have to launch Flux and charge your own PyFlux script.
Best regards,
Sijie

authors: EmileDvs Sijie-NI

repo: Eomys/pyleecan


text:
Use Pixel Streaming Plugin from 4.27 in Unreal 5.2

Hi! In Azure you used Unreal 4.27 Pixel Streaming Signalling Server... so, if I export in unreal 5.2, my app si not compatible with the signalling server, and that makes a lot of troubles with the auto-generated infrastructure in Azure...
My idea is find a way to use the 4.27 plugin in my Unreal 5.2...
This is posible?
I tried but an Include is old, so I changed to the same in 5.2 version. After that I suppose it's failing because a plugin with the same name already exist...
If you can help me, I will appreciate!

Hi @lcdlv

In Azure you used Unreal 4.27 Pixel Streaming Signalling Server

The Azure team maintains what is on Azure, not us. I believe they need to upgrade what they ship to be compatible with the latest PSInfra.

My idea is find a way to use the 4.27 plugin in my Unreal 5.2... This is posible?

No, not really. There have been significant changes to UE codebase between 4.27 and 5.2, simply putting the 4.27 version of the Pixel Streaming plugin into UE 5.2 would result in many compilation issues that would have to be resolved due to underlying API changes (especially due to the changes in rendering and WebRTC between those versions). You could attempt this backport and try to modify it to use the correct calls but it is not something we have any bandwidth to assist with.
My recommendation would be to reach out to the Azure team and aks them to upgrade their offering to work with the latest PSInfra.

authors: lcdlv lukehb

repo: EpicGames/PixelStreamingInfrastructure


text:
Bug in pool.py, Connection class

Hi,
the method Connection.send_cmd_all() (pool.py) calls host.mark_dead(msg) on a socket.error: but the Host class doesn't implement such method, so the AttributeError is raised.
I have written this method in the Host class (host.py):
def mark_dead(self, msg):
    logging.error(msg)
    self.close_socket()

I don't know if this could be a solution, but it seems to work.

@gianpaolo-lopresti thanks for your feedback. I will try to make test to repeat it. I have some idea when it can happen.

@ErDmKo a sample use case is to have continuous calls to the memcache service (i used a for loop with a sleep() at the end to simulate a production environment), while the memcache deamon is restarted.

@gianpaolo-lopresti thank again
Now i add new commit https://github.com/ErDmKo/asyncmc/commit/6c204fbaf0cd5c46619baeae39362262beba6d59 and up version in pypi. In next time i will do try reconnect in this case after "DEAD_RETRY" seconds.

Thanks a lot @ErDmKo !! Bye!

authors: ErDmKo gianpaolo-lopresti

repo: ErDmKo/asyncmc


text:
Fixed error introduced with early fingerprint patch.

I missed two occasions where "dtlsInfo." should have been inserted. I think this one should be merged ASAP.

Assigning @superdump for the time being.

Looks good to me. I'll merge it when I get to my computer next.

authors: stefhak superdump

repo: EricssonResearch/openwebrtc


text:
Cs/Apply-Unique-Value-Renderer

Added comments in code and tried matching the rendering color with the common design
Added screenshot
Updated metadata
Added README

oops target wrong branch

repo: Esri/arcgis-maps-sdk-flutter-samples


text:
final tooling

🔨 🔧

@nikolaswise so do you want to leave those images in there?

@paulcpederson Yes those are the ones for the responsive images.

authors: nikolaswise paulcpederson

repo: Esri/calcite-web


text:
Coordinate Conversion input format doesn't support / coordinate pair separator character (ArcGIS Pro)

According to the following help topic, ArcGIS Pro supports the forward-slash character / as the coordinate pair separator, however, the Coordinate Convert addin does not. The addin does support the back-slash character.
http://pro.arcgis.com/en/pro-app/tool-reference/data-management/supported-notation-formats.htm
NOTEs:

The addin should support this capability when the input format is in DD, DDM, and DMS.
The addin should also support this when entering in Longitude Latitude order.
The addin should support /, /space, and space/space as coordinate pair separtors.

Here is an example, using the forward-slash. Note: the tool should also support: forward-slash space
45.00N/70.00W
Here is an example in ArcGIS Pro. I had previously entered 0 0 as the coordinates, then I pasted in 45.00N/70.00W:

Tested the Pro addin built on 1.2 and installed on ArcGIS Pro 1.2

@jmhauck Installed Pro addin dated 05 Jan 2017 09:08 and tested on Pro build 1.4.7197 and the / character is working. Closing issue.

repo: Esri/coordinate-conversion-addin-dotnet


text:
Default Date/Time 12/29/1899 4:00 PM

Here is the feature service - date is set as a required field - not sure why the Default Date is set to 12/29/1899 4:00 PM when I use preview mode.
http://disasterresponse.maps.arcgis.com/home/item.html?id=03e7ac020c964d5fb5af8a43b0ff01f4
Expected behavior would default to today's date?

Matt -
This popped up again...

I will see if I can fix the feature service, but why wouldn't the date / time picker just default to today's date instead of 1899. When would 1899 ever be expected behavior?
I know it may not be a bug - but perhaps this could be 'enhanced'?

We have encountered this also in the latest version of the Geoform as well when a date field is set to required (NULL not allowed in the Geodatabase). When making an on premise feature service where the date field is required the default value is 00:00:00 in the feature's default edit template (in ArcMap).
I think I got around this last time (at least with on premise feature services) by managing the feature's edit template in the AGOL web map after publishing the service and putting it in the web map. There you should be able to set the default value of the date field on new features to "empty" and then it starts empty in the Geoform.
I've forgotten to do that a couple of times and users constantly complain about it :)

Here is a potential workaround using ArcGIS Pro. Design the Field - change the default to January 1 of the current year. This returns expected behavior on the GeoForm. I am not sure how you would do this without ArcGIS Pro other than creating a new field via the attribute table in the web map.
Please consider and enhancement for this feature.

@driskull if you drop the last three zeros from -2209161600000 > the UTC equivalent is Sat, 30 Dec 1899 00:00:00 GMT.
@nixta where else were you seeing this behavior the other day?

@jgravois I was trying to get the max date out of a Feature Service table based off a date field, for which I had to use statistics. Once I'd figured out the JSON parameters, it was returning the max date including milliseconds (and also setting the output statistic field to a numeric type, as it happens).

There should be an option in the GeoForm to set the current date. There's a gear options icon you can see more checkboxes when configuring a date field. That should do it.
Otherwise, I could look into automatically handling it when the date is matched to "00:00:00" or whatever it is that is causing the issue.
-Matt

It is worth testing on your end - but it did not appear that the current date setting was able to override the 1899 issue.
Sent from my iPhone

On Jan 19, 2016, at 09:19, Matt Driscoll notifications@github.com wrote:
There should be an option in the GeoForm to set the current date. There's a gear options icon you can see more checkboxes when configuring a date field. That should do it.
Otherwise, I could look into automatically handling it when the date is matched to "00:00:00" or whatever it is that is causing the issue.
-Matt
—
Reply to this email directly or view it on GitHub.

Should be fixed in next update. You could download and test or test via the github URL.
http://esri.github.io/geoform-template-js/
http://esri.github.io/geoform-template-js/?appid=[my apps id]

Excellent!
Sent from my iPhone

On Jan 19, 2016, at 16:52, Matt Driscoll notifications@github.com wrote:
Should be fixed in next update. You could download and test or test via the github URL.
http://esri.github.io/geoform-template-js/
http://esri.github.io/geoform-template-js/?appid=[my apps id]
—
Reply to this email directly or view it on GitHub.

authors: bogibrynjar driskull jgravois nixta pjdohertygis

repo: Esri/geoform-template-js


text:
Sorting by title is not working

Sorting by title is not working.

It has been merged in master

repo: Esri/geoportal-server-catalog


text:
Tile Package Errors with images to show

I've been asked to enhance our mobile html5 application with the tile package feature for viewing offline.  The errors show after the callback(tileInfo).  Both tileInfo and the lods assigned to them on the previous line are valid as far as I can tell.
Are there lod requirements for the tile package when it is viewed by itself?  This is a small tile package with only features, 6 lods, state plane projection in feet.
What i've done is use the sample tile package app and add the code into a widget.  I set the map extent and projection to be the same as the information returned from the server in the GET request.

@Ricardh522 Here's the How to doc. All the API and How To's for this repo can be found here.
If you are using a tiled base map with a .TPK (tile package) the TPKs Levels of Detail (LODs) must match the tiled map services LODs exactly. In other words, State Plane tile packages will have to be used on top of a State Plane base map, etc.
The basemap (base tiled layer) defines the LODs that the map can display. Any other operational tiled layers on the map will not display if they don’t match the basemap’s LODs. Esri.Map doesn’t apply a union to LODs of all tiled layers on the map.

@Ricardh522 any luck?

Hey Andy,  No luck with the tile packages.  It was a short lived attempt then I jumped back onto my track with the multiple features from the map service and downloading tiled imagery.  As far as I could tell though my empty map and the tile package were in the same projection.  What is the required MIME type for using the .zip file as a tile package?

The MIME type for IIS should be application/zip.
Can you send me a URL to the app and a link to the TPK? If you don't want it public you can email it to me agup at esri.
I'd really like to know if there is something in your TPK that is unique or if there is a bug in the TPKLayer library.

repo: Esri/offline-editor-js


text:
Will "ProductsGallery" web app be released?

@CraigCleveland  Will the web app SolutionsWeb\Apps\NationalIntel\ProductsGallery be released? The associated portal item is owned by you. If it's not going to be released that please remove this app folder from the SolutionsWeb\Apps\NationalIntel so it's not shipped with the release. Alternatively, I can remove to another location on the server so it's not included, but you'll have a backup of this files. Thank you.

@CraigCleveland Moved this ProductsGallery app out of the SolutionsWeb\Apps\NationalIntel to the folder c:\EricL\TEM2016Release\SolutionsWeb_files_removed_from_release\Apps\NationalIntel\ProductsGallery on the server, so if you need it back let me know.

@elinz there was never any intention of this app making it into the Ops Server release.  I created the app for Tom Oaks/Phil Suarez/Daniel Maso & Co. for this years DIET.  Since the requirement was to use the NSEC Portal and the Ops Server that's where it ended up.  So long story short that's totally fine what you've done with it.

@CraigCleveland Thanks for the info Craig.

authors: CraigCleveland elinz

repo: Esri/ops-server-config


text:
Web map "Artillery Deployment Location Analysis" references external basemap

Web map "Artillery Deployment Location Analysis" (id: 6be4ecc1f7cf4e0ca12cd195c0ac142a) is referencing an ArcGIS online basemap http://services.arcgisonline.com/ArcGIS/rest/services/World_Topo_Map/MapServer.
If the operation layers of a web map reference a service on the dev server then the basemap should be a service on the dev server also.

Fixed. Changed basemap to NSEC.

Verified. Closing issue.

authors: elinz jrweakland


text:
Can we make rectangle sketch tool default instead of Select feature tool in the select panel and refine tabs

Select tool does not seem to do much, so wondering if we can make Rectangle sketch tool default instead.
feedback got from Alix and Chris

@aparveen  I've added the hide select tool and auto set the rectangle.
I wonder if we will get feedback about auto setting of the rectangle though. It could be annoying if you first want to pan/zoom to the area of interest before you start sketching and try to do so and get a sketch and then need to delete it and deselect the sketch tool before you can simply pan the map. It would be nice if you are already at the area of interest but I just wonder if that will be the case in workflows that are not just simple test cases.
If we think some will want and some will not it could have a config option but seems like that would need to wait for next release as it would require a new string.

Final decision was to keep the pan tool as default in the selection panel and in Refine panel we decided to keep the selected tool active after completing an sketch so users do not have to select the same tool again if they want to continue with drawing more sketches.
The final changes are looking good.

authors: aparveen jmhauck

repo: Esri/solutions-components


text:
🛑 Diagnostico Zarate is down

In 32de8ef, Diagnostico Zarate (http://www.diagnosticozarate.com.ar) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Diagnostico Zarate is back up in c8b2fd1.

repo: Etixen/upptime


text:
🛑 Watervan is down

In e05fd88, Watervan (http://watervan.com.ar) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Watervan is back up in e6eac12.


text:
Bwockner/add ud config

add udConfig to API

I ignored any change that wasn't to do with the class udConfig in this PR

authors: Pavocracy bwockner

repo: Euclideon/udSDKPython


text:
Extend the Transparency slider

The transparency - even when on max value (I guess it controls window opacity) - is too transparent.
This makes some color themes hardly readable (eg. MaterialDark) when the underlying window is bright.

In comparison, here is a dark bg:

This works in the settings pane fine, however, somehow it applies it twice on the console windows.
It is highly visible in the 'border':

If you're using hterm as the frontend, it might apply to hterm's body as well. You can narrow it down to body.vibrant

Thanks!

@Eugeny So how about another slider for the background opacity?

I'm not able to use transparency.
My settings:

Terminus Alpha 73
Ubuntu 18.04.2
Gnome 3.28.2
Nvidia GeForce GTX 1050 Ti/PCIe/SSE2

Driver nvidia-driver-418 (open source)

authors: Eugeny douglasmiranda mrmeszaros wtdcode

repo: Eugeny/terminus


text:
BUG 描述
上传了一个mp3文件，实际被解析为一段语音，

预期效果
预期效果是一个可下载的mp3文件
信息

系统: [iOS]
系统版本: [macOS Monterey 12.1]
浏览器: [chrome 114.0.5735.198（正式版本） (arm64)]

#79 已修复

authors: Evansy xyqfei

repo: Evansy/MallChatWeb


text:
Share a wishlist

Add feature so that user's are able to share their wishlist via e-mail with given e-mail address.

Added

repo: Ewa-Anna/Bookstore


text:
Trigger changed event when scheduler's datepicker dateClicked is triggered

Fixes #1344.
Also adds datepicker dateClicked console logging to index.js in order to document more events and was helpful in diagnosing why changed.fu.scheduler was not being triggered.

Fixes #1183.

repo: ExactTarget/fuelux


text:
WIP additional picard iterations

companion PR to https://github.com/Exawind/nalu-wind/pull/940

Ok I think this is good to go... except that #19 broke something so this is based on acae22c

repo: Exawind/exawind-driver


text:
Payment requests in chat shows my name instead of "you"

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

Make sure you have some name set to your profile.
Open a chat where you have received a payment request.

Expected Result:
Payment request text should be like "Requested $1.00 from you"
Actual Result:
Payment request text is "Requested $1.00 from my name"
Workaround:
unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

Version Number: 1.2.96-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:
Issue reported by: @priyeshshah11
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1674924960670839
View all open jobs on GitHub

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@twisterdotcom Whoops! This issue is 2 days overdue. Let's get this updated quick!

@twisterdotcom Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

I am OOO. This was assigned at 9pm on Friday eve. Sorry, reassigning.

Triggered auto assignment to @michaelhaxhiu (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Bug0 Triage Checklist (Main S/O)

[ ] This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
[ ] This bug is not a duplicate report (check E/App issues and #expensify-bugs)

If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead

[ ] This bug is reproducible using the reproduction steps in the OP. S/O

If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
If the reproduction steps aren't clear and you determine the correct steps, please update the OP.

[ ] This issue is filled out as thoroughly and clearly as possible

Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.

[ ] I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

Actually, @michaelhaxhiu could you move it along, but I'll still take all the work at the end for this because I'll be back by then.

Bumping thread again. I'm not convinced this is a bug yet, but it could be!! 🤔

closing, since we are refactoring much of this UI.

authors: MelvinBot kavimuru michaelhaxhiu twisterdotcom

repo: Expensify/App


text:
Up button does not redirect to LHN when other chats are opened previously and window was resized to mobile

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Issue found when executing PR https://github.com/Expensify/App/pull/19263
Action Performed:
Scenario 1:

Go to https://staging.new.expensify.com/
Make sure that user lands on Chat A (other than Concierge).
Go to Concierge chat.
Resize the window to half the size to trigger mobile interface.
Click Back icon on the page.

Scenario 2:

Go to https://staging.new.expensify.com/
Make sure that user lands on Chat A (other than Concierge).
Go to Chat B, C and D.
Go to Concierge chat.
Resize the window to half the size to trigger mobile interface.
Click Back icon on the page.

Expected Result:
User is redirected to LHN.
Actual Result:
Scenario 1: User is redirected to Chat A. User needs to click on the back button again to return to LHN.
Scenario 2: User is redirected to chats that are opened previously (Chat D, C, B and A). User needs to click on the back button several times to return to LHN.
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[x] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: 1.3.25.2
Reproducible in staging?:  Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/78819774/7f191ba5-98f0-4764-889a-4e3151f365b1
https://github.com/Expensify/App/assets/78819774/c6897530-740c-42b9-a6dc-5491ddb1b6a1
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
View all open jobs on GitHub

I'm actually unsure if this is expected behavior or not

I think in any event we should not block deploys on this, so I'm going to demote it.

It's actually unclear to me that this is even a bug, so I'm going to assign this to @mountiny who will have better context on how to address this issue, even if it's just to close it.

Making it Daily again to be worked on by SWM

Hey, I just wanted to drop in some information if it would be useful in this case:
It is possible to use the logic from  subscribeToReportCommetPushNotifications
https://github.com/Expensify/App/blob/8bd25c75b72a12ffcf8c27f97e610a220c3ce31f/src/libs/Notification/PushNotification/subscribeToReportCommentPushNotifications.js#L22-L25
And use it in SidebarLinks.js
https://github.com/Expensify/App/blob/2a1c36d5bea964ee92ebfad11f92d8a22bbb7e4c/src/pages/home/sidebar/SidebarLinks.js#L140-L147
This will make sure that if we click on another report, the previous one is popped off the stack and only then the new one opens. I'm not sure if this is the intended approach that we should choose but I'll let you be the judge...

Thanks, still waiting for swm to find time for this one

Not overdue.

I'd like more information of how it should work. The scenario I want to know is:

Start with wide screen and do some navigation between the reports
Resize to small screen and go through e.g. some deeplinks to go to other reports.
Click back button in header

What should happen then? Should we still go to LHN or go back to the previous report? If so, should we go back till we get back to the report at which we resized and then go to LHN when pressing back button in it? Or should we still be popping the reports from before the resize?
I think it gets unnecessary complicated really fast. Simplest solution would be to just always go back to LHN when pressing back button in the report. Then we would have browser back/forward buttons for navigation between reports and back button for popping the whole stack. WDYT @mountiny @roryabraham @parasharrajat ?

I think it gets unnecessary complicated really fast. Simplest solution would be to just always go back to LHN when pressing back button in the report. Then we would have browser back/forward buttons for navigation between reports and back button for popping the whole stack. WDYT @mountiny @roryabraham @parasharrajat ?

I think we can start with going to the LHN everytime after the resize. So even if you had threads/ deeplinks to other reports, lets navigate to LHN as you can find the reports from there.
Lets make sure the navigation does not break once you resize back to the wide screen after going to LHN in mobile view.
I believe we will have a dedicated link to parent report so even after resize you should be bale to click on that and go to the parent report and its safer to go to LHN. As mentioned, the main thing is to ensure that the navigation state does not get screwed so the back button behaves as expected even after resizing to small view, taking some actions and resizing back to the wide layout.

@WoLewicki is handling this one

Weird how Melvin didn't ~annoy me~ tag me in the above comment. BTW @mountiny this is just waiting for your approval

This was merged

The PR that introduced the bug has been identified: https://github.com/Expensify/App/pull/18350
The offending PR has been commented on: https://github.com/Expensify/App/pull/18350#discussion_r1256691042
A discussion in #expensify-bugs has been started: This is an edge case, I doubt it could have been caught during PR testing and there is pretty much nothing to discuss here.
Determine if we should create a regression test for this bug: Given this is an edge case (unlikely to be reproduced by a real user) I'm leaning towards a No.

@mountiny Can you please remove/add Bug label to auto-assign a BZ member here.

Payment is due at the end of the week

I'm catching up from being OOO, it looks like payment is due on July 14.

Since this is a payment, I've updated it to Weekly.

@mountiny - can you please share what the payment structure should be here? Also, is there an Upwork job to send over and assign to @s77rt? Thanks!

$1000 to @s77rt for internal PR review

@alexpensify Accepted! Thanks!

@s77rt has been paid via Upwork and I closed the job there. I'm going to close this GH too.

authors: WoLewicki alexpensify esh-g lanitochka17 mountiny roryabraham s77rt


text:
[$1000] Web -  Inconsistent error messages text on wrong magic code

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:
Action Performed:

Signout if you are logged in
Enter an email > continue
Enter wrong magic code
Login
Go to contact methods
Add an email > verify
Enter wrong magic code

Expected Result:
same error message
Actual Result:
Inconsistent error messages text on wrong magic code
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[x] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: 1.3.35.4
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/93399543/a0f6fb15-a5e1-40b6-8410-5b4769b4489d
https://github.com/Expensify/App/assets/93399543/9d39325a-dc6a-4e63-b348-29da8bf35cac
Expensify/Expensify Issue URL:
Issue reported by: @chiragxarora
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1688221719614829
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~0150dd5082869ecc1c
Upwork Job ID: 1675276504517607424
Last Price Increase: 2023-07-01

Proposal
Please re-state the problem that we are trying to solve in this issue.
inconsistent error message on incorrect magic code
What is the root cause of that problem?
Root cause of the issue is the different error messages being passed from backend. When user enters an incorrect code while signing in, different error message comes from backend, when wrong code on secondary login, different error message.
What changes do you think we should make in order to solve the problem?
We should make the error message consistent on backend, we should pick one error message out of two and use it on both flows.
We should use the one which says "incorrect magic code, please try again or request a new one" because other message mentioning code expiry doesn't make much sense

Results

### What alternative solutions did you explore? (Optional)
None

Agree this is expected: "incorrect magic code, please try again or request a new one"

@chiragxarora  Could you provide references for your proposal? https://github.com/Expensify/App/issues/22017#issuecomment-1615943468
From code I could see places where we are setting the magic code error locally. Gentle suggestion would be to provide references and more information in proposal, so that we don't have to assume certain parts of proposal.

I think backend should change the error message, because right now it is showing what backend is sending in error
https://github.com/Expensify/App/blob/c614ed94a61ff37c248828a33f0f147cdb0a2143/src/pages/settings/Profile/Contacts/ValidateCodeForm/BaseValidateCodeForm.js#L168

We have a fresh proposal for you to review @abdulrahuman5196

@MitchExpensify
In the signin page we show This magic code is invalid or has expired, please request a new code and try again which is got from backend
In contact verification page we show Failed to validate contact method with given magic code. Please request a new code and try again. which is shown with local data.
Which one should be the right one to maintain consistency? Based on that we can make the change.

This is expected: "Incorrect magic code, please try again or request a new one"

I think this has been fixed, error message while verifying contact method has been replaced by a more appropriate message.

The text is changed but still inconsistent as per the OP. Correct me if wrong. @MitchExpensify

Can you tell when that new text was introduced @abdulrahuman5196 ? curious to see that

friendly bump @abdulrahuman5196

No overdue, Melvin!

Thank you! Yes I agree this is the expected text

Confirmed this is the expected text. As such, do any of the existing proposals sound good to you @abdulrahuman5196 ?

Reviewing this now

On @chiragxarora 's proposal here https://github.com/Expensify/App/issues/22017#issuecomment-1616463336
There is one major issue - currently backend error messages are not translated. I think that could have been the historical reason of showing local error in terms for secondary validation and not for signin (Because signin is not expected to be translated AFAIK). So If we relay on backend error, we won't be able to shown translated content in secondary verification page.

@HezekielT 's proposal here https://github.com/Expensify/App/issues/22017#issuecomment-1617841843 looks good and works well. Since we are already showing the local error message, we can update it to have consistency.
🎀 👀 🎀
C+ Reviewed
cc: @MitchExpensify

@MitchExpensify @abdulrahuman5196 sorry if this was already discussed, but should we perhaps figure out what the final copy should be before making the update? Otherwise somebody can change one of them and we'll be back to square one
I briefly looked at the PR that introduced this copy (cc @Beamanator @aldo-expensify) and I couldn't find a linked issue with the Waiting for Copy label -- again, I took a quick look, so I could've missed it.

I guess we can also move forward with the proposal, since part of the checklist is to make an issue with the Waiting for Copy label to finalize the copy, but since it sounds like this message was updated recently, I think we should go a step further than "it's inconsistent, therefore it's a bug".
I actually find the copies to be appropriate for the different cases/flows

I figured this was the expected text seeing as its taken from the most prominent real estate (Sign in) so if it is wrong I would think it would have been noticed by now. Is that solid enough reasoning to move forward with or do we need to get a label on this do you think @cead22 ?

I think that's reasonable. However, I think if we simply update this using this reasoning, then nothing stops the next person from thinking this text is wrong, it's the same as in the sign in page, but this is a different flow, which is also reasonable. And then we'll just continue creating PRs to update this over and over
I think we should discuss in product or with marketing such that when the next person thinks this is wrong, and finds the last PR that updated it, they can also find the slack discussion where this was agreed on, which should either settle it, or they can re-start the discussion to change it again

@chiragxarora yes, but I may have missed the point you were trying to make. Can you perhaps clarify? I think my previous comment still stands

firstly, we should remove/replace the errorField from the failure data and let the onyx use the error message received from backend while validating code

I agree with this, but we need to figure out what to do with the other message first, and I'm proposing we discuss what we want these messages to be moving forward, instead of simply changing them to be consistent even though the error messages make sense for the both flows

Agree on the concern @cead22 . I am assuming @MitchExpensify confirmed for this question. https://github.com/Expensify/App/issues/22017#issuecomment-1627395700.
We could check again from product if the confirmation is correct to be safe @MitchExpensify ?

Ah yes, that makes sense, and I think it's in line with what I commented here

@cead22 Just checking back. I assume we are waiting on product comeback.
On another note. from your comment

firstly, we should remove/replace the errorField from the failure data and let the onyx use the error message received from backend while validating code

I agree with this, but we need to figure out what to do with the other message first, and I'm proposing we discuss what we want these messages to be moving forward, instead of simply changing them to be consistent even though the error messages make sense for the both flows

I was not inclined to this because, backend error messages don't have translation as of now. It is not a problem for login page, but will be in secondary verification, if we remove current onyx error and rely on backend error message, we would regress the translation capability in secondary verification page.
If people unknowingly changing the text is the concern means, we could add a comment mentioning a similar text is used in login page and some information and we can say change both places if required.

@cead22 is better placed to help out with the technical considerations here 👍

@MitchExpensify we're waiting for you to lead this product discussion, not on anything technical

Ah got it! Thanks @cead22
This seems be essentially be a copy issue so I'm applying the Waiting for Copy label.
@LLPeckham - what do you think is the best copy for all cases whenever
In the signin page we show "This magic code is invalid or has expired, please request a new code and try again"
In contact verification page we show "Failed to validate contact method with given magic code. Please request a new code and try again"
Both make sense but we need to decide which is best for both cases so we don't keep changing them endlessly. Thanks!

Got it. @MitchExpensify - Question: would this error code also show up if someone entered a code just incorrectly? It seems like we basically want to decide on a blanket error message for any time a code is either invalid or entered incorrectly? LMK if that is what we're trying to figure out here, because if so, I agree we should just have one standard error message. Thoughts on something like: "Incorrect or invalid magic code. Please try again or request a new code."
With "This magic code is invalid or has expired, please request a new code and try again." invalid = expired, but doesn't cover the case where it's just incorrect, so I like saying it's either entered wrong or invalid altogether and the next steps for the user is to either try again or request a new code.
What do ya think?

Both make sense but we need to decide which is best for both cases so we don't keep changing them endlessly. Thanks!

To clarify, having different messages for different flows -- specially if they make sense for their respective flow, imo, is also an option

"Incorrect or invalid magic code. Please try again or request a new code."

This sounds good to me @LLPeckham !

@cead22 got it. So either I'd recommend one message per flow, which is if I'm understanding correctly:

Flow 1 - When a user is trying to validate a contact method and uses an invalid/incorrect code. So the message would be: Failed to validate contact method with given magic code. Please try again or request a new code.

Flow 2 - When a user is at the sign in page and uses an invalid/incorrect code. So the message would be: "Incorrect or invalid magic code. Please try again or request a new code."

Or just use the blanket code for both: Incorrect or invalid magic code. Please try again or request a new code.
I'm open to both if you think it makes sense to have 2 separate messages for the different scenarios (cc @MitchExpensify @cead22), but that's the copy I'd recomend for either case!

I think we should just go with one message for this error code, so I'd suggest sticking with: Incorrect or invalid magic code. Please try again or request a new code.

Thanks!
@abdulrahuman5196 I think we're ready to move forward, do you still think @HezekielT 's proposal is the one to go with?

Yeah. I still think, @HezekielT 's proposal here https://github.com/Expensify/App/issues/22017#issuecomment-1617841843 looks good and works well. We also need translation for the new string.
We also need to update the backend error message separately on server. @cead22
🎀 👀 🎀
C+ Reviewed

I think we should just go with one message for this error code, so I'd suggest sticking with: Incorrect or invalid magic code. Please try again or request a new code.

@LLPeckham If possible could you also provide the required translation for the new string?

Asked for translation here, will report back

Bumped the thread in Slack for the translation

Translation here:  Código mágico incorrecto o no válido. Inténtalo de nuevo o solicita otro código.

We also need to update the backend error message separately on server. @cead22

@abdulrahuman5196 I can take care of this part (or ask an internal engineering to do it). What's the API call that's returning the error message we need to update?

The proposal is complete because we only expect front end changes in the proposal, or at least that's my understanding. If you feel differently, I think you should feel encouraged to start a discussion about this in #expensfy-open-source, but I don't think it's worth changing this decision after having selected a proposal and having a PR submitted

Payment summary:
Reporting: @chiragxarora $250
C: @HezekielT $1500
C+: @abdulrahuman5196 $1500

The PR that introduced the bug has been identified. Link to the PR:
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

Not a regression. We have made the error message consistent.

Determine if we should create a regression test for this bug.
If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression test needs to be added. But can only be added after backend fix is also done. So we can add regression test part of that.
@MitchExpensify / @cead22  Could you kindly create separate issue for backend string update if required?

@MitchExpensify / @cead22 Could you kindly create separate issue for backend string update if required?

Is this update required do you think?

Reporting: @chiragxarora $250 - Paid and contract ended
C: @HezekielT $1500 - Please accept the Upwork offer 👍
C+: @abdulrahuman5196 $1500 - Paid and contract ended

Thanks @HezekielT , Paid and contract ended 👍

Is this update required do you think? @cead22

Not really since the PR to fix the backend message is already merged and deployed. @abdulrahuman5196 given that can you  add the regression test now?

Regression test:

Go to login
Enter your email address and click continue.
Add incorrect magic codes in the magic code inputs.
Verify that an error messages that says Incorrect or invalid magic code. Please try again or request a new code. is displayed.
Now enter the correct magic code and login.
Navigate to Settings => Profile => Contact methods
Click on New contact method.
Enter your email and click on Add option.
From Contact methods options click on Please verify this contact method.
Add incorrect magic codes in the magic code inputs.
Verify that an error messages that says Incorrect or invalid magic code. Please try again or request a new code. is displayed.
Change the language to Spanish.
Repeat step 10 and 11.
Verify that an error messages that says Código mágico incorrecto o no válido. Inténtalo de nuevo o solicita otro código. is displayed in spanish.

@cead22 @MitchExpensify

Added the test request. Thanks all! Closing

authors: LLPeckham MitchExpensify abdulrahuman5196 alitoshmatov cead22 kbecciv nishancx


text:
IOS - Remove admin user after the invite new member in WS

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

Create new WS(profile-> worspace-> create new WS)
Then click on members
Click on invites
Select some email and invite
Observe the email list

Expected Result:
Admin email should not be gone
Actual Result:
After inviting the users, i not able to see admin user in list of members list.
When i am go back and again go to member list then it is showing.
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[x] iOS / native
[ ] iOS / Safari
[ ] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: 1.3.36-5
Reproducible in staging?: n/a
Reproducible in production?: n/a
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/93399543/49875d5a-47bb-4d47-8d49-a77889358c1b
Expensify/Expensify Issue URL:
Issue reported by: @niravkakadiya25
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1688786931252889
View all open jobs on GitHub

I cannot reproduce this!

Commented in slack, neither me nor applause can repro. closing!

authors: kbecciv zanyrenney


text:
[$500] Security -  At close account, contact method confirmation doesn't has max length

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

Go To https://staging.new.expensify.com/settings/security/closeAccount
"At Please type your default contact method to confirm you wish to close your account. Your default contact method is: "
Type your email or anything and before put space
You will see that eventually text will disappear going to the right of the screen

Expected Result:
The input for default contact method should restrict the max length of the field to match default contact method max lengthDescribe what you think should've happened
Actual Result:
We can add as many letters/numbers in the input without any limitation, even tho the confirmation email has a length of 50 chars, for example, you can input 100 chars or over.
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

Version Number: 1.3.77.5
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/93399543/1d1cae0a-0d7b-48db-ad11-ef13be05b707
https://github.com/Expensify/App/assets/93399543/cd087b31-aadf-4656-99e2-c0372f989740
https://github.com/Expensify/App/assets/93399543/97440a5f-4306-4cb8-bf89-2e5afe189bc6
https://github.com/Expensify/App/assets/93399543/69be6b9a-5646-4d36-b586-02c3262bf444
https://github.com/Expensify/App/assets/93399543/0a63259e-726f-4fb3-ba5f-6b7bebfb2457
https://github.com/Expensify/App/assets/93399543/370fb68b-315c-435c-aacd-d836c9c581b4
https://github.com/Expensify/App/assets/93399543/c3c3b44c-b7ed-47e2-85b5-b9c3ea8ecffe
Expensify/Expensify Issue URL:
Issue reported by: @lcsvcn
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1696253725837449
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~0176cc528da6909cef
Upwork Job ID: 1709584187341242368
Last Price Increase: 2023-10-04

Proposal
Please re-state the problem that we are trying to solve in this issue.
Email validations are not allowed
What is the root cause of that problem?
We are not validating email or phone number here.
https://github.com/Expensify/App/blob/2faa3b58c99c2fcc3acba20e4f39c9d0f0ef4dde/src/pages/settings/Security/CloseAccountPage.js#L65-L74
What changes do you think we should make in order to solve the problem?
Just like how we do in base login form, we should have similar checks here as well.
https://github.com/Expensify/App/blob/a29fd40a4b59f601f62e8c7b28be9df7efc246bb/src/pages/signin/LoginForm/BaseLoginForm.js#L134-L145
We can use the above checks and use same in CloseAccountPage as well.
What alternative solutions did you explore? (Optional)
N/A

Proposal by: @lcsvcn
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1696253725837449
Proposal
Please re-state the problem that we are trying to solve in this issue
At close account, contact method confirmation doesn't has max length
What is the root cause of that problem?
The root cause of the problem is that TextInput has no max length defined, accepting a large amount of chars. We should define a maxLength for the component, since we know what is the maximum length of the input.
What changes do you think we should make in order to solve the problem?
We can avoid that bug with a simple solution, by setting the maxLength variable for the TextInput field. So it could be a fixed value for example 50 chars or the amount that we expect at userEmailOrPhone.
At src/pages/settings/Security/CloseAccountPage.js:
   <TextInput
        inputID="phoneOrEmail"
       (...)
        maxLength={50}
    />

In the example above, it is a fixed value of 50 chars.
We can alternatively use the userEmailOrPhone variable, like below:
   <TextInput
        inputID="phoneOrEmail"
       (...)
        maxLength={userEmailOrPhone.length}
    />

I would recommend going with the userEmailOrPhone length, since it is a confirmation text input and we know how many chars we should accept.
So that way, we only accept the max amount is required to confirm the contact method. If is email, length of email, if is phone length of phone.
What alternative solutions did you explore? (Optional)
N/A

Proposal
Please re-state the problem that we are trying to solve in this issue.
Close account email/phone input is allowing more characters then allowed.
What is the root cause of that problem?
In CloseAccountPage.js we are comparing sanitised version of userEmailOrPhone with value inputted so basically we should allow sanitised email/phone length to be inputted since user can add spaces which are not necessary.
What changes do you think we should make in order to solve the problem?
Add maxLength={sanitizePhoneOrEmail(userEmailOrPhone).length} prop in input text field that will let user only enter sanitised version of phone and email.
What alternative solutions did you explore? (Optional)
N/a

Proposal from @lcsvcn looks good to me https://github.com/Expensify/App/issues/28823#issuecomment-1747068883
🎀 👀 🎀 C+ reviewed

I think we're reaching a bit here and don't think this is a bug tbh. It sounds like the root "problem" is that the user can enter an email that is wrong (too long)... but that is kind of the purpose of the input? As long as the app doesn't blow up when you enter a long string like this, I don't think there's anything to fix. Thoughts @muttmuure @narefyev91?

if we need to add max length to the input, please help add for other inputs components entire the app, for example, the contact method input https://expensify.slack.com/archives/C049HHMV9SM/p1696432763969089

why not just disallow user to enter space since it is getting sanitised already. Will make input much cleaner.

@arosiclair login page - seems working in the same manner - we only have limitation for LOGIN_CHARACTER_LIMIT: 254 - and we allow adding spaces - we can only add limitation for LOGIN_CHARACTER_LIMIT: 254 (if we really needed it) - to following the same pattern across the app.
Or we can close this one

The issue I raised here is because this input is quite different for others from others I saw in the app (I think it is unique, as I don't remember any other page with confirmation of anything), as we have an expected input text right above, since this is just a confirmation input. we can and should enforce the input max length to avoid any behaviour such as the one I show in the video, like getting out of screen or that we can type twice amount of text of the confirmation. Since this is a confirmation input, it doesn't make sense for the user to input any amount of chars. I agree that there will be inputs that doesn't has limitation and therefore it is expected to get out of screen, but in this case we know the maxLength before and we can avoid that in most cases, why not fix that for the given scenario?

@arosiclair login page - seems working in the same manner - we only have limitation for LOGIN_CHARACTER_LIMIT: 254 - and we allow adding spaces - we can only add limitation for LOGIN_CHARACTER_LIMIT: 254 (if we really needed it) - to following the same pattern across the app.
Or we can close this one

Yeah that might help but I think we can close this anyway. Let's not spend $1000 to add a character limit that's not really fixing any problems and makes it easier for people to close their accounts (possibly by accident) which is not actually something we want people to do 😄. @muttmuure feel free to reopen if you feel strongly otherwise.

authors: DylanDylann arosiclair ayazalavi kbecciv lcsvcn narefyev91 saranshbalyan-1234


text:
[$500]  Avatar - Primary and secondary contacts use the same profile Avatar

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.4.15-1
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Action Performed:
Precondition:

User B is secondary contact method to User A
Both users have default profile Avatars
Steps:
Navigate to staging.new.expensify.com
Login as User B
Navigate to Settings> Profile> Upload custom photo
Navigate to Settings> Profile> Contact Method
Set User B as default contact method
Change between contact method users and take a note of Avatar

Expected Result:
Profile Avatar photo should not be the same for both users
Actual Result:
Both Users (Primary contact and secondary contact) have the same profile Avatar
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[x] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[x] Windows: Chrome
[ ] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence

https://github.com/Expensify/App/assets/78819774/8e5786c5-69e5-4762-866a-90e2dfa477eb
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~0188df459b3d097847
Upwork Job ID: 1737943403119042560
Last Price Increase: 2023-12-21

this doesn't look like a bug, do we consider 2 seperate contact method as 2 seperate accounts? if yes, it'll be weird to receive message sent to primary contact method while secondary contact method is default 😅

Agree, not sure if it's posted on Upwork by a bot Or if they really want someone to fix it.

Contributor details
Your Expensify account email: upendrasengar456@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/~01877ad79621257dfe

I'm available to work on this.

I've been OoO, reviewing this now.

Hmm, I agree this isn't a bug and am in favor of closing this.


text:
[$500] mweb - Animations missing in offline mode

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: v.1.4-38.0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Action Performed:

Navigate to staging.new.expensify.com
Create new account with gmail
Go offline once onboarding modal is displayed
Close the modal
Tap on bottom settings icon
Select Workspaces option
Select top settings icon
Select Preferences & Security menu

Expected Result:
Animations across the application should load in offline mode
Actual Result:
Animations missing in offline mode
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[x] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence
https://github.com/Expensify/App/assets/93399543/346ccf42-305f-4e88-843f-4e582c42e353

View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01de6190c174f9a8cb
Upwork Job ID: 1755223473745489920
Last Price Increase: 2024-02-07

I can't reproduce this and we aren't getting bites - this is off our roadmap so I'm closing for now

Sorry for the delay @adelekennedy I was investigating.
I can reproduce in dev.new.expensify... (both staging server or not), not just by following the steps proposed above, the animations do not work in Offline. In staging.new.expensify... and new.expensify... the animations work well in offline mode. I will continue investigating.

Sorry for the delay @adelekennedy I was investigating.
I can reproduce in dev.new.expensify... (both staging server or not), not just by following the steps proposed above, the animations do not work in Offline.
In staging.new.expensify... and new.expensify... the animations work well in offline mode.

Reproduce-36021/dev-new-expensify - 02/15/2024

https://github.com/Expensify/App/assets/95647348/6937523e-a3f4-4adc-9d09-7152b7eb768d

Reproduce-36021/staging-new-expensify - 02/15/2024

https://github.com/Expensify/App/assets/95647348/d45bb281-a11c-4f5f-8981-1271a82c45b5

Still investigating the root causes of this issue

Sorry for the delay @adelekennedy I was investigating.
I can reproduce in dev.new.expensify... (both staging server or not), not just by following the steps proposed above, the animations do not work in Offline.
In staging.new.expensify... and new.expensify... the animations work well in offline mode.

Reproduce-36021/dev-new-expensify - 02/15/2024

https://github.com/Expensify/App/assets/95647348/6937523e-a3f4-4adc-9d09-7152b7eb768d

Reproduce-36021/staging-new-expensify - 02/15/2024

https://github.com/Expensify/App/assets/95647348/d45bb281-a11c-4f5f-8981-1271a82c45b5

Maybe I'm missing something here, but I believe this PR should have fixed it. I will continue to investigate the root causes of it.

authors: adelekennedy brunovjk kbecciv


text:
[$250] IOU - Markdown isn't applied to the "Hold" message

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.4.43.0
Reproducible in staging?: y
Reproducible in production?: new feature
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: applause internal team
Slack conversation:
Action Performed:

Create an IOU in a chat
Put it on hold
Format the reason with markdowns

Expected Result:
Markdown should be applied.
Actual Result:
Markdown isn't applied to the "Hold" message.
Workaround:
unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence

View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~011f83ef4d2ad62f49
Upwork Job ID: 1760293330198360064
Last Price Increase: 2024-03-25

Proposal
Please re-state the problem that we are trying to solve in this issue.
IOU - Markdown isn't applied to the "Hold" message
What is the root cause of that problem?
We do not pars hold comment
What changes do you think we should make in order to solve the problem?
Update comment  with getParsedComment(comment)
What alternative solutions did you explore? (Optional)

@BartoszGrajdek @MonilBhavsar @robertjchen I see you in https://github.com/Expensify/App/pull/33897, can you please have a look here?

Proposal
Please re-state the problem that we are trying to solve in this issue.
What is the root cause of that problem?
What changes do you think we should make in order to solve the problem?

Update the comment here and here with getParsedComment(comment)
There need updates in backbend too . The hold action will not contain html key in messages and originalMessage

What alternative solutions did you explore? (Optional)

Proposal
Please re-state the problem that we are trying to solve in this issue.
On hold message not shown as HTML
What is the root cause of that problem?
The message from description for HOLD reason is saved as simple string
What changes do you think we should make in order to solve the problem?
There's 2 main areas that needs to be fixed.
1 - use ReportUtils.getParsedComment(comment)
We need to save the message as parsed before passed to Onyx here
https://github.com/Expensify/App/blob/20ca041595e76cdd289977e55b2af3fbb9618868/src/libs/ReportUtils.ts#L3530
2- Use <RenderHTML> not <Text>
After adding the ReportUtils.getParsedComment(comment)  the UI will display the markdown as it it is, something like <em> text </em>, so we need to use RenderHTML component here
https://github.com/Expensify/App/blob/20ca041595e76cdd289977e55b2af3fbb9618868/src/pages/home/report/ReportActionItemFragment.tsx#L135-L144

Proposal
Updated

On hold, pending the splitting of the message in  #36979

Looks like Robert has got this issue

Not overdue, on hold.  Robert is working on this https://github.com/Expensify/App/issues/36979

not overdue - Robert is still working on this: https://github.com/Expensify/App/issues/36979#issuecomment-1999128350

Off hold! 👍 Note that the hold message is now an independent message

cc: @hoangzinh for proposal review, thanks!! 🙇

@dragnoir there are significant differences in our proposals . And, as you can see, in my proposal there is no mention of the <RenderHTML> component. I suggested using RenderCommentHTML

Hm, the backend logs report that the comment field is missing when calling the HoldRequest API comand. Can you please try again on a fresh request with a comment when holding? 🤔

Good question, I'll update the backend to return HOLDCOMMENT as well for consistency 🤔

Actually, let's change the frontend to the ADDCOMMENT for now as there are many considerations on the backend 👍

Thanks for the review, the backend change should be going out later today so we can proceed here 👍

Fix: @dragnoir
PR Review: @hoangzinh
PR not merged yet

I'm suggesting we close this issue, to reflect where we've landed in the PR. https://github.com/Expensify/App/issues/40408#issuecomment-2123384330 - any thoughts, comment there. CC: @JmillsExpensify

Yes, agreed. Let's close.

Cool, thanks ya'll!

authors: JmillsExpensify MonilBhavsar abekkala dragnoir flodnv kavimuru robertjchen shahinyan11 trjExpensify


text:
[HOLD #50120][$250] Chat- Inconsistent display of deleted image from deep link in search chat and Inbox chat

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0.46-3
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:  N/A
Email or phone of affected tester (no customers): applausetester+tw4335353535355335@applause.expensifail.com
Issue reported by: Applause - Internal Team
Action Performed:

Open any chat and upload an image
Hover over the image > click three dots > copy link
Paste the link in the composer and send it > delete the image
Click on the link in the chat > It shows empty composer
Go to search > select the chat > click on the same link > "Hmm... it's not here" error appears

Expected Result:
Clicking the link in both the search chat and inbox should show the same result since the links are identical
Actual Result:
After deleting the image, clicking the link in the inbox chat and search chat shows different results
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/user-attachments/assets/9c3ffe88-56ac-4ac7-bda7-07bb7b4d477f
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~021843744700304943378
Upwork Job ID: 1843744700304943378
Last Price Increase: 2024-10-08

Issue OwnerCurrent Issue Owner: @DylanDylann

@puneetlath  FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

We think that this bug might be related to #wave-control

This issue is fixed, can't reproduce any more

@daledah could you able to reproduce this issue?

If not, we can close this one
cc @puneetlath

Sounds good. Closing!

authors: DylanDylann lanitochka17 puneetlath


text:
Global create opening in workspace configuration screen

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

Sign up to OldDot using a new domain/account (a domain not used before)
Select "Business"
Select "Expensify Card" > Submit
See Global Create open in Workspace configuration:

Expected Result:
Global Create should not be open in the workspace configuration screen. This change was intended to fix that - Skip showing create for new users if user already has a workspace
Actual Result:
Global Create is open in the workspace configuration screen
Workaround:
Ignore it and click "Get Started". This is the mainline flow so we can't expect users to follow this workaround. They could easily select a global create option and get diverted from the mainline flow.
Platform:

Web

View all open jobs on GitHub

Triggered auto assignment to @Christinadobrzyn (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

Latest Slack thread here.
Basically it's pretty easy to reproduce in dev, and was determined that currently there shouldn't be any race condition weirdness with one possible solution (@marcaaron 's PR: https://github.com/Expensify/App/pull/5394/files).
However, @TomatoToaster is working on changing some of the flow so we're planning to hold on this until that change is done.

Hmm so this is actually really tricky to solve now because of the latest changes.
Basically when the Sidebar loads we need to know if we have a free policy, but we might not have created one yet.
Before the most recent changes we were only redirecting after the policy was created. But now the sidebar loads (inside the MainDrawerNavigator) at the same time as the LoginWithShortLivedTokenPage. So we can no longer guarantee that allPolicies will contain the policy we just created.
I'm struggling to think of a clean way to get around this but we can hack it for now by looking at what route we're on. Unless someone has a better idea... I'm a little stumped since the sidebar doesn't know that we are trying to create a policy via WorkspaceNew and the two things don't really have any relationship to eachother.

Probably a better way to fix this would be to stop triggering the modal to open via the SidebarScreen in componentDidMount() entirely and instead do it programmatically (unsure if there's a clear reason why it should be there vs. somewhere like Expensify.js), but that's going to be more complicated than referring to the navigation state.

Ah wait are you seeing it workspace/new as well? I only saw it with workspace/12312/card when I was transitioning from the existing policy. Is the invalid workspace closing bug also happening for if you hit localhost:8080/workspace/new?

you seeing it workspace/new as well?

Yeah global create thing pops open for workspace/new because we are creating it via New Expensify and the sidebar may load before that happens e.g. if it takes longer than 1.5 seconds to create the policy.

Ahh wait sorry I'm getting this discussion and the inconsistent InvalidWorkspace thing mixed up. Ignore what I said there.
This is kind of hacky behavior on top of hacky behavior, but one thing we could do is set this NVP for the user while we're doing the transition in LogInWithShortToken or anywhere in its flow.
Anyone who's coming in from OldDot is going to be routed to a Workspace so we don't need to automatically open the global create menu.

It makes sense to me to move the isFirstTimeNewExpensifyUser out of the SidebarScreen and pass a prop to trigger the create menu to open when it has to, or save a ref somewhere so that it can be triggered like SidebarScreen.toggleCreateMenu()

It just that the logic should be synchronised to have the firstTimeUser check and the policy check as well as trigger the create menu no sooner than 1500ms (to avoid the modal bug)
e.g. something like
Promise.all([
  waitForFirstUserCheck,
  waitForPolicyCheck,
  delay(1500),
])
 .then(results => /* open the create menu if any of the checks passed `true` */)

@TomatoToaster Oh hmm so basically set them as "not a first time user"? That could work, but creates a weird condition where we must block navigating until after the NVP has been set + also block on the two API calls @kidroca is calling out.
Either way I think we'll have to reorganize the code after, but looking at the route works for now.

authors: Beamanator MelvinBot MitchExpensify TomatoToaster kidroca marcaaron


text:
[$125] mWeb - 2FA - In 2FA magic code page, after refresh briefly error message is displayed

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: V9. 0.75-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
Issue reported by: Applause Internal Team
Device used: Redmi note 10s android 13
App Component: User Settings
Action Performed:
Pre-condition: Login with unverified gmail account

Go to https://staging.new.expensify.com/home
Go to settings- security - two factor authentication
Enter incorrect magic code
Refresh the page

Expected Result:
In 2FA magic code page, after refresh briefly error message must not be displayed.
Actual Result:
In 2FA magic code page, after refresh briefly error message is displayed.
Workaround:
Unknown
Platforms:

[ ] Android: Standalone
[ ] Android: HybridApp
[x] Android: mWeb Chrome
[ ] iOS: Standalone
[ ] iOS: HybridApp
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
https://github.com/user-attachments/assets/2df08823-e574-42a1-809b-adaaefc48f22
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~021867646284163514204
Upwork Job ID: 1867646284163514204
Last Price Increase: 2024-12-20

Issue OwnerCurrent Issue Owner: @dominictb

I'm currently OoO - but will be back on Tuesday - Reassigning to get the ball rolling, but happy to take back on Tuesday

@dominictb please attempt reproduction and review the above proposals - thanks!

@dominictb lmk if this needs to wait until the new year! 🎄

@dominictb Could you review my proposal? thanks

@nyomanjyotisa's proposal looks promising. Onyx update is the async action and calling func in did-mount happens after rendering the component.
So using canShowError and clear the error on mount are the good ideas to solve the issue and be consistent with this PR
But I just wonder:

Should we call clearValidateCodeActionError along with clearError like what we did here?
If we use canShowError, I don't think we need to clear error in clean-up function. Please correct me if I miss something.

@dominictb Why are we even considering a problem that is hypothetical raised linked to other PR. I have uploaded a video on my proposal as POC that the problem @nyomanjyotisa is claiming doesn't even exist. The approach I am suggesting is used in other places in our code base such as here here @nyomanjyotisa proposal is my proposal plus a solution for a problem that doesn't even exist from my testing. Can you provide an evidence of the brief display of the error occuring in this issue's case?

If you can prove the issue doesn't happen anymore (by plain text not just record the video), I'll consider the decision again. Thanks 🙏

I am not saying my video should be taken as evidence but if you guys are sure the problem can also happen here give me a proof otherwise what is the point of applying a workaround solution for an edge case problem that's not even there.
The explanation that I can give you here is

BTW useOnyx is late in loading data I remember an issue arising on mWeb of not auto-populating tag on iou confirmation page when withFullTransactionOrNotFound HOC was migrated to use useOnyx from withOnyx and transaction was being undefined on useEffect run on render that used to work well with withOnyx and regarding the pr https://github.com/Expensify/App/pull/52303#issuecomment-2470033635 linked by @nyomanjyotisa you can see that the useOnys migration commit was made later. It might be because we are getting the error data from useOnyx that I am not reproducing the issue he is claiming and the problem wouldn't occur here because we would be clearing the error even before it is read from onyx in mWeb.

It doesn't really convince me. Can you show me the code?

@dominictb Just proceed with your review and let the assigned engineer decide whether we should apply a fix for an invisible bug or not 👍

authors: FitseTLT IuliiaHerets OfstadC huult michaelkwardrop


text:
Workspace - The new member disappears from the list after being deselected

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0.77-6
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/5364702&group_by=cases:section_id&group_order=asc&group_id=229065
Issue reported by: Applause - Internal Team
Component Workspace Settings
Action Performed:
1.Open the app
2.Navigate to the Workspace editor
3.Click on any Workspace name
4.Click on Members
5.Click on the invite member button
6.Search for an email of an account you have not chatted or interacted before
7.Select member in search result list
8.Unselect above selecting member
Expected Result:
The new member is still displayed in the list after being deselected
Actual Result:
The new member disappears from the list after being deselected
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Standalone
[ ] Android: HybridApp
[ ] Android: mWeb Chrome
[x] iOS: Standalone
[x] iOS: HybridApp
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/user-attachments/assets/69a3069b-7a98-49e0-b667-db06fc5ef988
View all open jobs on GitHub

yes I agree that this is expected - Asking QA for a little more information on why this might be a bug. https://expensify.slack.com/archives/C9YU7BX5M/p1735060202932979

We have this steps in TestRail and step 8 says: "Verify the default avatar stays the same when selecting and deselecting"

Ah okay thank you @izarutskaya!
I think that can be removed as I think it's misleading but I'll double check with the team to confirm this is true.

Thanks @parasharrajat - discussion the best method to update the regression test steps here - https://expensify.slack.com/archives/C9YU7BX5M/p1735065262683469?thread_ts=1735060202.932979&cid=C9YU7BX5M

Just a heads up that I'm going to be ooo until Dec 30th. I don't think this is urgent and I think it likely just needs an update to the regression test.
I'm not going to assign this to a BZ teammate but if anything is urgent, please reach out to the team for a volunteer.