text:
Kids: games tab missing on v4.6.x

Describe the bug
The games tab is missing on v4.6.0 at least on my iPhone.
Only 4.6.0 and 4.6.1, and only on an actual device? works locally in sim.
Note: these versions are not released publicly yet, only beta.
Technically its because the feature flag "games-tab" is not active. But I don't see why, as everything unleash-related is configured identically locally and on codemagic.
And otherwise unleash seems to work, it's successfully setting e.g. flutterPlayerControls to true.

Fixed by https://github.com/bcc-code/bcc-media-app/commit/8040f960155d14b17333b2ef71b9c47be5e65125
Building v4.6.2 now

repo: bcc-code/bcc-media-app


text:
BCC Media: "Back" from an episode screen minimizes/exits the app

Expected: Land back on the previous screen
Other: Android 14, 5.6.29

might have to do with Flutter 3.24

https://github.com/flutter/engine/pull/52302

Might have something to do with Androids predictive back gesture

https://github.com/flutter/flutter/issues/149753
https://docs.flutter.dev/release/breaking-changes/android-predictive-back

Might have something to do with auto_router

https://github.com/Milad-Akarie/auto_route_library/issues/2059
https://github.com/Milad-Akarie/auto_route_library/issues/1788

Seems like there might be some problems with the newest Flutter update: https://github.com/flutter/engine/pull/54256

@mulundapm This is more than 2 story points

@sifferhans Suggest working on other tasks and will look into this by the end of the sprint if there are extra time.

Some learnings

This issue is present from Android 13 and up
Only reproducible on Google Pixel devices

source: gharchive/issue

authors: mulundapm sifferhans

license_type: permissive

license_source: github-api


text:
Update name of role "Representant" to Representative

as shown in this picture:

I think it's the other way around. They want the roles in Norwegian. @amelienbawolski

@cs1m0n ah okay but than it should be okay now?

Yes

repo: bcc-code/bcc-wp


text:
provide a java example how to check whether a certificate is in the certificate transparency logs

in analogy to
https://github.com/google/certificate-transparency/blob/master/python/ct/client/tools/verify_single_proof.py
Would be willing to give a little "bounty" to whoever does this.

see also https://github.com/google/certificate-transparency/issues/1416

https://bugzilla.mozilla.org/show_bug.cgi?id=1315648

repo: bcgit/bc-java

license: MIT


text:
org.bouncycastle.util.encoders.DecoderException: unable to decode base64 string: invalid characters encountered in base64 data

i got  the DecoderException using this lib from bouncycastle, i konw is not latest version but i used too the version xxx-jdk16to18 but i got same issue.
Maven depencencies:
<dependency>
<groupId>org.bouncycastle</groupId>
 <artifactId>bcprov-jdk15on</artifactId>
<version>1.67</version>
</dependency>
<dependency>
<groupId>org.bouncycastle</groupId>
<artifactId>bcpkix-jdk15on</artifactId>
<version>1.67</version>
</dependency>
<dependency>
<groupId>org.bouncycastle</groupId>
<artifactId>bcprov-ext-jdk15on</artifactId>
<version>1.66</version>
</dependency>
Someone do know how fix it?

Show the exception please, and we'll probably need an example piece of data that fails to decode.

closed as inactive and insufficient information.

authors: devOpsDocker1x dghgit peterdettman


text:
Reports - Filter Freeze

freeze the RF filters at the top of the screen to better control the grid from anywhere.

As a (type of user)
I want (goal)
so that (reason/ why/ value)
Acceptance Criteria
Scenario 1:
GIVEN ... (you or your condition)
WHEN ... (what you do)
THEN ... (what you see)
Scenario 2:
xxxxxx
Validation Rules?
(If yes, list here)
Screenshot
(Link above will always be the most up-to-date version.)

Hey team! Please add your planning poker estimate with Zenhub @dinesh-aot @djnunez-aot @jadmsaadaot


text:
BCMOHAM-13541 || Added prescriberResult and patientResult

Deployment Tracker:
Added this.prescriberResult and this.patientResult in the "force-app/main/default/lwc/odrLookup/odrLookup.js"
Reason:
It was looping when we don't give any details in the create SA request and click on the Next button instead of giving an error message

Reviewed the quality gate error, the formatting of the test could be improved. We will try an adjust to this method. @RanadheerRG

source: gharchive/pull-request

authors: RanadheerRG cgijeffolsen

repo: bcgov/MoH-SAT


text:
#2446 - Revise Offering Length Validations

Removed the current validation on minimum offering lengths which require FT offerings to be at least 84 days, and PT offerings to be at least 42 days for study breaks validation

Added validation on minimum offering weeks studyPeriodMinWeeks for FT offerings (12 weeks) and PT offerings (6 weeks)

Removed any associated warning message banner as well that is displayed when offering length does not meet those requirements.
Applied a new validation on FT offerings which require that the Total Funded Weeks field is 12 or higher. If 11 or below, display an warning banner message below the "Study Period Breakdown" which reads:

"Full-time offerings must be at least 12 weeks of study or longer to be eligible. Any shorter offerings can be submitted but will require SABC review."

Applied a new validation on PT offerings which require that the Total Funded Weeks field is 6 or higher. If 5 or below, display an warning banner message below the "Study Period Breakdown" which reads:

"Part-time offerings must be at least 6 weeks of study or longer to be eligible. Any shorter offerings can be submitted but will require SABC review."

Adjusted validations of PIR process during student application to remove the current validation on students when they enter study length which does not comply with the number of weeks policy.
Created new E2E tests for the new scenarios.

Screenshot of warning banner for part-time offering with invalid total funded weeks and no study breaks

Screenshot of warning banner for part-time offering with invalid total funded weeks and study breaks

Screenshot of warning banner with total funded days more than max allowed days

Screenshot of error text for validating PIR program max allowed days during student application

Nice work. Please take a look at the comments.
Please add at least one FT and PT offering test to following test suites.
education-program-offering.institutions.controller.createOffering.e2e-spec.ts
education-program-offering.institutions.controller.createOffering.e2e-spec.ts
education-program-offering.institutions.controller.bulkInsert.e2e-spec.ts

Thanks for doing the changes @lewischen-aot. Added few more comments. Mostly on E2E area.

authors: dheepak-aot lewischen-aot

repo: bcgov/SIMS


text:
Technical debt cleanup

[ ] Fin Indy work by Clecio
[ ] Rename overridden screens to BCSplash etc so its obvious which one is being edited
[ ] Rename App to src in bifold
[ ] Update RN and other packages as much as possible - even if we don't get all the way to the latest and greatest in one sprint
[x] Integrate CodeClimate in Build to make sure PRs don't drop code coverage %.
[x] Convert to yarn
[x] Get syntax hi-lighting fixed in Jest tests (VSCodes shows most jest related keywords with red underline).

Done or tracked by independent tickets.

repo: bcgov/bc-wallet-mobile


text:
Display Credential Offer

As a holder I need to approve any offered credential so I feel in control of my wallet.
Wireframes
Hi-Fi wireframes
https://xd.adobe.com/view/3db881d4-e963-42ec-a2c4-6b5ca23862a3-68eb/
https://xd.adobe.com/view/efd8f0c6-3ba0-436e-b72c-2dad62569aa2-ba8b/screen/8ae142a3-e175-4f2c-b59f-ac0d4e4f7a32
Scenario: Holder receives a credential offer
Given the holder has a connection with an issuer
When the issuer sends a credential offer
Then the credential offer will arrive in the form of a notification in the home screen
Scenario: Holder selects a credential offer
Given the holder has received a credential offer from a connected issuer
When the holder selects on the credential offer
Then the holder is taken to the credential offer screen/flow
Scenario: Holder accepts a credential offer
Given the holder selects a credential offer
When the holder accepts the credential offer
Then the holder will be taken to a loading screen that informs them that their credential is coming
Given the holder accepts a credential offer from an issuer they are connected with
When the credential arrives in the wallet
Then the screen will change from the loading screen to the credential list with the offered credential at the top of the list
Scenario: Holder declines a credential offer
Given the holder selects a credential offer
When the holder declines the credential offer
Then the holder will be taken to the credential list page
And a temporary notification will appear that informs the holder of the declined action

@knguyenBC A few ways I deviated from the designs (and why):

We don't have any branding (logo) ATM so I just re-used the first letter of the issuer like we did in credential list
We don't have a great way to show who issued the credential (yet) so I've used what exists now until we figure out a better way;
I removed the duplicates of usage of branding. In the design we have the logo at the top, then just below. Not sure if duplicating them so close adds much but LMK if you want it as per the designs;
I changed "Issued: Pending" to "Issued: Jan 21, 222". Since its an "offer" that is not yet accepted "Pending" seems implied to me also, a date fits better with the word "Issued". LMK if Pending is what you want. It'll be hard coded as an offer is always "Pending" until a following screen (After they hit Accept or Decline). Otherwise the only state that comes from a credential is   "state": "offer-received"

@jleach
First two points: a-okay
3rd point: a-okay for now. Makes sense since there isn't any branding yet but later, we might need to revisit once branding is available.
4th point: the pending label from the designs comes from a misconception of issued date. The field for issued date should be the date that the credential offer was generated by the issuer. So it shouldn't say "Pending" it should use the createdAt property of the credential.

authors: amanji jleach knguyenBC


text:
19793 - Add tests for Significant Individual Change Date.

*Issue:19793 *https://github.com/bcgov/entity/issues/19793
Description of changes:
Add tests for Significant Individual Change Date.
this test is to verify that no existing SIs have their significant date changed when we select/add new SI.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the namex license (Apache 2.0).

/gcbrun

Temporary Url for review: https://bcregistry-btr-dev--pr-126-yx3m12q9.web.app

authors: bcregistry-sre hfekete

repo: bcgov/business-transparency-registry


text:
Tune up resources for data warehouse namespace

The minimal resources we currently have in our namespace will not be enough. Tune these up as needed.

Please add your planning poker estimate with Zenhub @dleard

authors: dleard mikevespi

repo: bcgov/cas-data-warehouse


text:
Add a roles table to the database

We will need to have a table that defines the different app roles that can be assigned to a user. The user table should also have a role column that is a foreign key to the role table.
The roles should be:
cas_admin
cas_analyst
cas_pending
industry_user
AC:

[ ] a new table is created in the database (app_role)
[ ] the new table has a column (role) with a row for each role defined above
[ ] the user table has a foreign key to the app_role table

Hey team! Please add your planning poker estimate with Zenhub @andrea-williams @dleard @joshgamache @JoshLarouche @marcellmueller @mikevespi @Sepehr-Sobhani

@Sepehr-Sobhani role_name is an alternative

@dleard or permission!!

authors: Sepehr-Sobhani dleard

repo: bcgov/cas-registration


text:
Email validation

As a program analyst, I want the email address fields to be validated so that I am confident the correct information is input.
Add help text next to field description for desired format enforcement.

Use native email type of email field.

Next step - estimate this card.

@BryanGK the toolkit says it can have input type set as email which will use a browser's validation. Has this been implemented?

@elliottSlee can you point me to where it says that?

@elliottSlee Ah while that is part of the toolkit, that type of element is not implemented on the form-builder. It could be, but at present, is not.

authors: BryanGK elliottSlee rgreensp

repo: bcgov/connectivity-intake


text:
Mat/Pat - UX - Inform applicants what can be edited and what cannot be edited

Inform applicants what can be edited and what cannot be edited before and after supervisor approval & start date

duplicate

repo: bcgov/digital-journeys


text:
Dm 895 new product page

Draft WIP - waiting on feature flags as to not release visible unusable changes. NOT FOR REVIEW

Reviewed with team.  Closing this PR, as it will not be merged into the code base.

authors: BryanGK SteveChapmanBCDX


text:
Credit Balance | Display credit balance in main header at the top of the screen |2|

Our fuel supplier users would like their org's credit balance to be more visible; we have received an increasing number of requests to put the credit balance on this page and that page.
This card is to put the org's credit balance in either the main header of TFRS or on the main nav bar, so that it is visible on all pages
https://trello.com/c/wFztdOQM/2072-credit-balance-display-credit-balance-in-main-header-at-the-top-of-the-screen-0

 Credit Balance | Display credit balance in main header at the top of the screen |2|

repo: bcgov/tfrs


text:
$this->db->insert_batch( ) === false not working

insert_batch($table[, $set = NULL[, $escape = NULL[, $batch_size = 100]]])
参数:
$table (string) -- Table name
$set (array) -- Data to insert
$escape (bool) -- Whether to escape values and identifiers
$batch_size (int) -- Count of rows to insert at once
返回:
Number of rows inserted or FALSE on failure
返回类型:
mixed
$this->db->insert_batch($this->table_statistics, $statistics)  === false
not working
0 === false

Reports in English, please - we don't speak Chinese or Korean.

I will choose laravel.

When using the strict comparison (===) 0 != false. They only equal each other with loose comparison (==). And that's a PHP thing, not a CodeIgniter thing.

https://www.codeigniter.com/user_guide/database/query_builder.html?highlight=insert_batch#CI_DB_query_builder::insert_batch
Returns: | Number of rows inserted or FALSE on failure
Actually return 0 on failure

authors: ganl jim-parry lonnieezell

repo: bcit-ci/CodeIgniter


text:
Documentation grammar and punctuation changes

Mostly correcting incorrect past tense 'ran' to past participle 'run'.  A few other edits in the interest of clarity.

The suggestions make sense. Given that it is documentation, I am not inlined to be too strict, but we do expect contributions to be GPG-signed :-/

authors: dafriend jim-parry

license: mit

license_source: bigquery


text:
【Unsolicited PR】Give download a header conforming to RFC 6266

Description
When I created an application to download multibyte file name, the file name got corrupted.
Changed give download proccess a header conforming to "RFC6266"
The phenomenon that the file name is garbled can be confirmed with Internet Explorer 11 older.
Checklist:

[x] Securely signed commits
[ ] Component(s) with PHPdocs
[x] Unit testing, with >80% coverage
[ ] User guide updated
[x] Conforms to style guide

Thanks merged!😍


text:
Multi(chain) userOp Validator

This branch features an ECDSA validator that can validate any userOp from a list of userOps represented by a root of the Merkle tree.

Initially it was planned to make a multichain validator: only chain specific parameters such as chainId, nonce, gas etc could vary
However, for flexibility and gas efficiency, I decided to use the whole userOpHash-es as leaves of the Merkle Tree.
This effectively makes this module not just a Multichain Validator, but a Multi UserOp Validator, since now even userOp.calldata may vary.
Of course , if the calldata is the same, this module can be used for multichain deployment + userOp processing.
So with this module user can only sign once for any amount of userOps. It significantly improves UX for crosschain dapps, allowing for example deployment of SA and enabling the first Session Key on any number of chains with only one signature required.
This module can work as single chain ECDSA validator as well.

fixed both issues

as bundler integration is merged, you need to resolve some conflicts here

Conflicts resolved

added descriptions and natspecs

Factory is staked. One more issue (not on our end btw) detected.
Details: https://linear.app/biconomy/issue/SMA-1#comment-5eb1b60e

Submitted changes as per discussion here:
https://linear.app/biconomy/issue/SMA-1/implement-multi-chain-signature-validator-module
Removed extocodesize check from initForSmartAccount method in ECDSAOwnershipModule

it won't be possible to deploy a SA with smart contract as owner via userOp even w/o this check
for deployments via directly calling factory :
-- via SDK: a check in the SDK can be implemented
-- directly:   initForSmartAccount parameter renamed owner => eoaOwner so it's cleat that eoa is expected to be there

@livingrockrises you agree to merge?

Merging as per https://linear.app/biconomy/issue/SMA-1#comment-e783a9ff

authors: filmakarov livingrockrises

repo: bcnmy/scw-contracts


text:
Add in wercker to validate tests

only test:quick is called
eventually will build in rspec, functional testing
and a publish step

@fishnix  this will be just for unit tests for now.
We can merge this now or we can wait to have auto-version bump capabilities.  mid-term is to get kitchen tests automated as well.
let me know what you think.

@fishnix yay/nay. this will have capabilities to cut new releases.

Thats my only comment, otherwise :+1:

Sorry I had 2 comments :)

Sorry if I was confusing, I think it should be 2 spaces.... like this?

box: ubuntu:15.04
build:
  steps:
    - script:
        name: install wget
        code: |
          sudo apt-get update -y
          sudo apt-get install -y wget
    - poppen/chefdk:
        version: 0.10.0
    - script:
        name: test
        code: |
          chef exec "rake test:quick"
deploy:
  - install-packages:
      packages: wget curl
  - poppen/chefdk:
      version: 0.10.0
  - script:
      name: get version from rake
      code: |`
        export APP_VERSION=$(chef exec rake version)
        echo $APP_VERSION
  - github-create-release:
      token: $GITHUB_TOKEN
      tag: $APP_VERSION
  # TODO: setup stove to push to supermarket

@fishnix review again.

f4b83dac67da2ad4735707c1a4af62cc80181631 looks good :+1:

authors: bdangit fishnix

repo: bdangit/chef-influxdb


text:
Fix getPermissions for "Master" user

also has admin rights

Signed-off-by: Ben Dang me@bdang.it

#3

repo: bdangit/scm-gitlab


text:
🐛 Handle enter click in a NumberBox and add onEditingComplete event

Describe the bug
When a NumberBox has the focus, a click on enter should exit the focus.
It would also be great to add onEditingComplete.

I just debugged the issue and noticed that onEditingComplete is being the root of the issue. We provide it internally, but when not provided the Enter key exists the focus. onEditingComplete also overrides the default behavior of handling according to the TextInputAction.

authors: WinXaito bdlukaa


text:
[PreviewSystem]Rendering stopped because the data for mesh does not match the expected mesh data size and vertex stride.

プレビュー中のSMRのメッシュを差し替えると以下のようなエラーが発生しました
SkinnedMeshRenderer: Rendering stopped because the data for mesh 'Anon_Body' on Game Object 'Proxy renderer for Anon_Body' does not match the expected mesh data size and vertex stride.

再現例ありますか？

特別なことはやってないですが、M1 環境(harmony無効環境)にてあのんちゃんで適当なボーンにScale AdjusterをつけたじょうたいでAnon_BodyのSMRにAnon_Dressのメッシュをつっこみました

repo: bdunderscore/ndmf


text:
Source code not available

If you try to download the sourcecode from
http://www.beanshell.org/bsh-2.0b4-src.zip
you get an 404 Error.
Reported by: *anonymous
Original Ticket: "beanshell/bugs/304":https://sourceforge.net/p/beanshell/bugs/304

This has been fixed now. Thanks!

authors: pgiffuni sourceforge-issue-exporter

repo: beanshell/beanshell


text:
Creation date gets changed.

Compare the file creation dates on these two screenshots. The created date should be the same on both.
Windows file properties box for this file:

Obsidian metadata:

@beaussan
This is happening to me too. This is a MAJOR bug. It changes the create date every time it changes the updated time, and it seems to be changing the date to the past. One file example, which was created this year, had its created date changed to 2022-05-02, and then another time it was changed to 2022-05-04. This file was certainly not created that long ago. Screenshot below.
I am going to disable this plugin until the issue is resolved. It has terribly destroyed the validity of all my file dates, which will be a massive headache to find a solution for, if I even can.

In this issue post, Mrienstra quotes a suggestion from another message that people use the Linter plugin instead.
I've done that - uninstalled this one, installed Linter - and Linter seems to be adding the dates perfectly, as best I can tell in 24 hours.
If you're not already familiar with Linter (I wasn't), it's a much bigger plugin with many, many features. Make sure to go through and double-check that anything you don't want is turned off. Most things seem to be off by default - opt-in, not opt-out - but it can change your files so it's worth checking.
If Linter doesn't generate the created/modified frontmatter automatically, you can trigger it manually by "saving" with Ctrl-S. That works. (I'm too new to it to understand the whys and wherefores.)

Oh - @profucius - in Settings > Core Plugins, do you have File Recovery turned on? That might help you. (I'm not very familiar with it, either.)

Wellll, I did have File Recovery turned on at one point, but disabled it due to using Syncthing to sync my vault to my android obsidian app. It comes with its own versioning, so I was relying on it instead, but then I just noticed that this bug caused Syncthing to go haywire and create hundreds of sync-conflict versions, all with either the same content and only the frontmatter dates changed, or sometimes with the content also changed (due to editing the file on my phone). Its a file-versioning nightmare that unfortunately I don't have the time to untangle. The good news at the very least is that I don't edit on my phone very much, so I will just fall back to a previous vault backup, and restore a few files.
Linter looks interesting, thanks for mentioning that! I'll be giving it a try after I get my vault stable again (and another backup!)
Let this thread be a cautionary tale to any who may come across this. Unfortunately without the author updating the Readme.md landing page, some more people will probably fall victim to the bug until then.

In this issue post, Mrienstra quotes a suggestion from another message that people use the Linter plugin instead.
I've done that - uninstalled this one, installed Linter - and Linter seems to be adding the dates perfectly, as best I can tell in 24 hours.
If you're not already familiar with Linter (I wasn't), it's a much bigger plugin with many, many features. Make sure to go through and double-check that anything you don't want is turned off. Most things seem to be off by default - opt-in, not opt-out - but it can change your files so it's worth checking.
If Linter doesn't generate the created/modified frontmatter automatically, you can trigger it manually by "saving" with Ctrl-S. That works. (I'm too new to it to understand the whys and wherefores.)

I tested Linter and it worked perfectly. I only enabled the dates section settings. FYI, you can actually make it write to all files. If you're comfortable with the settings and you've tested it on some select files, then you can open the command palette and type Linter and there is an option to lint all files in vault. I went ahead and did that (after a backup) and everything I've looked at is perfect so far. Thanks again for bringing that to my attention, you saved my toosh there.

Hi, sorry for the delay. This should now be fixed as of 2.0.0. If that's still an issue, feel free to re open a new issue !

authors: Inclement9 beaussan profucius

repo: beaussan/update-time-on-edit-obsidian


text:
https://api.foursquare.com/v2/venues/explore?near=Toronto&limit=10&client_id=4WKEKC34G3MDMOKWRFSKHNEDTO0SLBNHNPKQTP00PH4LIOGB&client_secret=1XONTZ1RBNE4ABEQ5H4MKWPJIXEEYG3HRSVYJEWV0SJ4VWAP&v=20180101

Description

Input
The code looked like this before beautification:
https://api.foursquare.com/v2/venues/explore?near=Toronto&limit=10&client_id=4WKEKC34G3MDMOKWRFSKHNEDTO0SLBNHNPKQTP00PH4LIOGB&client_secret=1XONTZ1RBNE4ABEQ5H4MKWPJIXEEYG3HRSVYJEWV0SJ4VWAP&v=20180101

Current Output
The  code actually looked like this after beautification:
https: //api.foursquare.com/v2/venues/explore?near=Toronto&limit=10&client_id=4WKEKC34G3MDMOKWRFSKHNEDTO0SLBNHNPKQTP00PH4LIOGB&client_secret=1XONTZ1RBNE4ABEQ5H4MKWPJIXEEYG3HRSVYJEWV0SJ4VWAP&v=20180101

Expected Output
The code should have looked like this after beautification:
/* Your desired output text */

Environment
Browser User Agent:
Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_4) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/13.1 Safari/605.1.15
Language Selected:
Beautify JavaScript
Settings
{
  "indent_size": "4",
  "indent_char": " ",
  "max_preserve_newlines": "5",
  "preserve_newlines": true,
  "keep_array_indentation": false,
  "break_chained_methods": false,
  "indent_scripts": "normal",
  "brace_style": "collapse",
  "space_before_conditional": true,
  "unescape_strings": false,
  "jslint_happy": false,
  "end_with_newline": false,
  "wrap_line_length": "0",
  "indent_inner_html": false,
  "comma_first": false,
  "e4x": false,
  "indent_empty_lines": false
}

Please paste the code into this issue.  Also point to what specifically is wrong.

authors: bitwiseman lisusmikhail

repo: beautify-web/js-beautify


text:
Suggestion for webapp example in the docs

Hello, I just found Briefcase and it looks great. I skipped to the end of the tutorial to see if it has webapp capabilities to create the "hexafecta" of platforms and saw "Coming Soon". No worries, I just wanted to mention the Python package called FastAPI that I just used in the tutorial below to stand up a webapp in minutes using a very sparse amount of code. Perhaps this might help filling in the Docs for webapps.
https://github.com/andreRibeiro1989/medium/blob/main/chatbot/README.md
https://towardsdatascience.com/develop-a-conversational-ai-bot-in-4-simple-steps-1b57e98372e2

Thanks; but that suggestion doesn't really help here.
The goal of the web step of the tutorial isn't "write a web app quickly" - there are dozens of tutorials for doing that, using Django, Flask, FastAPI, and others. Rather, the goal is to take the same source code that has been used in the first steps of the tutorial, run the same code, and generate a web app with the same behavior.
Although we haven't updated the tutorial yet, it is possible to do this today - Toga and Briefcase have support for web deployment backend. I'm hoping we'll be able to update the tutorial to include this extra step in the near future.

@freakboy3742
Great, thats awesome. Does Toga use one of those mentioned tools, or was it written from scratch? Really good to know, I may try to do that.
Quick question.. are there any toolsets you know of that cross-compile Python like Golang does (maybe even a wrapper to golang with mypy for typing?) I've seen some tools like bazel-zig-cc and cross-env. Many use Cython in some fashion.
This issue below was closed, but it doesnt seem that Breifcase cross-compiles.
Is there a more efficient way to implement BeeWare? https://github.com/beeware/beeware/issues/84
I'm just trying to survey the current options before getting invested into a particular path. Thank you.

Toga doesn't involve a web server at all. it uses PyScript to get a client-side Python interpreter, and renders what is effectively a "single page app".
Briefcase formalises the packaging process and rendering into a HTML to load that page. It provides a simple web server for debug purposes, but the content generated by Briefcase could be served by any web server.
I have no idea what is going on with the ticket you've referenced; the user who opened it, closed minutes after it was opened. However, I'm not sure what they're trying to achieve with compiling in the form they describe - it won't actually speed anything up. Cython isn't "magical speed juice" - it has very specific situations in which it will make things faster.
More generally, what are you actually trying to do when you say "cross compile"? The two links you've provided are two completely unrelated use cases, so it's not clear what it is you're actually trying to achieve.

@freakboy3742 thanks for your reply..
Basically, I want the broadest reach possible for an application. It seems like Electron is the popular tool, maybe it does actually cross-compile to the big 3 OS platforms, and there are tools for mobile apps, but it uses html for the user interface. That makes using as a webapp easy, but adds size to the mobile apps.
Golang can do actual cross-compiling to the big 3 (without needing to run them), and results in very compact and efficient applications. It can also target ios, android and arm, etc. It seems if apps were written in exclusively Cython compatible code, the cross-compilation could be similar to Golang. Afaik, the Python packagers (like Appimage) include the entire Python interpreter (probably how Briefcase does .app and msi).
So I'm trying to figure out if there exists other tools that do cross-compilation like Golang. The first link discussed exactly that. The second one discussed cross-env, a tool I havent heard of. But I did find the one I was thinking of called Nuitka. In the SO page below, the top answer discusses the "freeze" strategy which packages the entire python interpreter versus Cython and Nuitka (which I just learned doesnt do  cross-compilation yet). The latter does however "executes uncompiled code and compiled code together in an extremely compatible manner" link. Taking care of packages that are not Cython compatible.
https://stackoverflow.com/questions/12059509/create-a-single-executable-from-a-python-project
So, I'm not looking for magical "speed-juice" so much as magical interoperability, unification and standardization. It does look like the path would be Cython or Nuitka > bazel-zig-cc. I figured since this project is in the related field, you all might know the state of the art on this matter. Thank you

So - I still don't entirely understand what you're trying to do. You've mentioned a bunch of different technologies, but they're all solving different problems in different ways - and none of them are related to the "web app" that was the start of this discussion.
Briefcase is a tool for producing the type of application that end users of desktop and mobile operating systems are familiar with - the sort of app that appears on a Start menu or Launchpad, presents as an icon that is clicked, and has a GUI. Briefcase is able to take a body of Python code that displays a GUI, and package it for macOS, Windows, Linux, iOS, Android and the web. Briefcase solves the problem of getting a standalone Python interpreter and code onto the user's computer in a way that means the end-user doesn't have to care about the fact that they're running a Python interpreter.
Cython doesn't make an application "cross platform". It provides a way to produce optimised code modules. It's a way to make a computationally intense loop faster by giving hints to the code that CPU-optimized instructions can be used. It still requires you to compile the module for every target platform where you want the code to run.
cross-env solves a completely different problem again - it provides a way to compile C modules for a platform other than the platform you're currently on. This doesn't normally matter for Python; but it's critical if you're dealing with iOS or Android because you can't (or don't) run a C compiler on those platforms.
Go is solving a different packaging problem. It doesn't produce GUI apps - it produces command line apps. It produces a single binary, because that's the style of tool it's targeting. You can probably use Go to produce a GUI app - but you'll need to use some other tool to handle the rest of the "App packaging" problem that lets a binary appear as an app on a Launchpad. Nuitka is roughly analogous here; there are certain modes of operation of PyInstaller that are also similar.
Electron is a different tool again. It is effectively a GUI framework - a way of making a GUI for an app using HTML+JS. You still need to work out how to package and distribute your application for distribution.
You keep using the words "Cross Compilation"... but your usage of that phrase doesn't map onto any usage that I'm familiar with. Cross compiliation is using a Windows machine to produce a macOS binary. That will be, at the very least, difficult, because the tools needed aren't cross platform. Xcode is only available on macOS. Visual Studio is only available on Windows. I'm sure someone who is sufficiently motivated can make that work... but why would you bother? After you've cross compiled your Windows app on macOS... you won't be able to test it - so you'll need to seek out a Windows machine to test on. If the issue is having availability of development machines on which to do compilation: GitHub Actions provides CI environments that lets you build native binaries on any platform you want. Go is able to do this because the Go compiler and standard library is an ecosystem unto itself - but the side effect is that the apps are usually only command line apps.
And none of this has anything to with web apps, which is where this thread started.
So - once again: What are you actually trying to do? What specific problem are you trying to solve? It's very difficult to advise whether BeeWare is a good match for your use case when all you're telling me is the selection of wildly unrelated technologies you're considering. If you can tell us what your actual end use-case is, we might be able to provide advice.

@freakboy3742 great, thanks again..
First, good points regarding Go being mostly CLI. In fact, that explains a bit of why other platforms arent strictly necessary to test and debug on. And thanks for pointing me towards that GitHub Actions feature.
I am envisioning not testing GUI apps on some platforms. I'm not going to buy an iPhone or a Mac to test on unless the success of the application warrants it. Users of proprietary platforms have to accept that barrier for devs, but thats another story.
The speed of Cython is almost irrelevant to me compared to the cross-platform compilation it allows through C. Yes, I mean cross-compilation. I'm developing a webapp that I want available on mobile and keep options open for desktop platforms. So that's why I started asking about webapps. Electron would work, but Python is important to me, so I landed here. I did just find a page discussing translating Python to JS with Transcrypt, and it looks like Capacitor is the popular mobile side of Electron. It connects to native mobile APIs and doesnt need to be as large as Electron. Briefcase still interests me for being able to stay in Python (it is amazing intrinsically). If it can create a mobile app and a web app with the same code, that is excellent.
I'm trying to distill these technologies down to some common denominators. Cross-compilation of GUI apps may be asking too much. I appreciate your replies.
I guess I need to compare the Briefcase web and mobile apps, with Electron and Capacitor either with JS or using Transcrypt. Could you share the code for your or an example Briefcase web app?

So - I have literally just walked off stage at DjangoCon US where I discussed this specific use case - wrapping a web app as a native app. And I can point you at an example: the Toga examples folder contains two examples: positron-static and positron-Django, which generate an Electron-style "app" whose GUI is a web app that is served internally.
Using Briefcase to target the web is a different approach: it uses Pyscript to treat the web browser as a native platform.

repo: beeware/beeware


text:
Tutorial 1 file - Instructions on how to address a 'requirements not met' or 'pip unable to connect' error

I inserted notifications of what to do if an error were to be encountered during the tutorial. It contains a set of instructions on what to do if the message "Unable to install requirements. This may be because one of your requirements is invalid, or because pip was unable to connect to the PyPI server" was encountered

This solves an issue where the virtual environment is set up with an unsupported version of python (ie 3.13), leading to the resulting error.

PR Checklist:

[x] All new features have been tested
[x] All new features have been documented
[x] I have read the CONTRIBUTING.md file
[x] I will abide by the code of conduct

Apologies, I was suffering from a condition known as "I did not know what I was doing and this was my first pull request", leading to the errors.


text:
多gpu训练问题

您好，请问下此版本可以用多gpu训练吗？我修改了hparams.py中num_gpus = 1，train.py中--distributed-run True，然后在train_tacotron2.sh中CUDA_VISIBLE_DEVICES=0,1。
可是始终只用到了0号gpu，1上面没有。
是还需要设置什么吗？

此版本暂不支持多GPU训练，如需多GPU训练，请参考NVIDIA/tacotron2的相关代码自行修改。
我在单1080Ti上也能训练出好的效果，且无需训练很长时间。几个小时内训练到20个epoch的时候log曲线就挺不错了，然后可以继续训练至200或者更多epoch以达到更好的除噪效果。

此版本暂不支持多GPU训练，如需多GPU训练，请参考NVIDIA/tacotron2的相关代码自行修改。
我在单1080Ti上也能训练出好的效果，且无需训练很长时间。几个小时内训练到20个epoch的时候log曲线就挺不错了，然后可以继续训练至200或者更多epoch以达到更好的除噪效果。


text:
Splashes not always splash when you get sick/marvelous

Describe your bug here.
Splashes not always splash when you get sick/marvelous
Crash Log or logcat logs (if existing)
No response
Are you modding a build from source or with Lua?
I am not modding
What is your build target?
Desktop (Linux, Windows or Mac)
Did you edit anything in this build? If so, mention or summarize your changes.
/

It did get broken in one of the v1.1.2 updates, I will fix it

fixed


text:
Add driver api for usage inside scripts

This would allow sending data from the scripts without relying on actions and builders

Added support in 0.3.0

repo: bel-log/bellog


text:
Canceling csharpier while it is formatting files can end up with lost code.

If you start running csharpier and ctrl-c the process in the middle it will sometimes leave a file half written, resulting in lost code and no indication that the code was lost.

A non-async write method is now used to write files and cancellation tokens are pass to all relevant async methods.
In my testing now, I wasn't able to reproduce the problem of half written files.

repo: belav/csharpier


text:
Better error handling when given a csproj or sln file

When I attempted to use this, I misread the command line instructions and passed in a .sln file or a .csproj file because this is how the dotnet formatter works.  This resulted in this output:
+dotnet csharpier Foo.sln
/Foo.sln                                                                                - failed to compile
total time:                                                                          243ms
Total files:                                                                           1
Failed syntax tree validation:                                                         0
Threw exceptions while formatting:                                                     0
files that threw exceptions while validating syntax tree:                              0

Which led me to believe that the sln file was not compiling, and not that I was supplying an invalid file.  I understand now how it is meant to work, but wanted to just suggest that this error message be improved.   When not given a .cs file or a directory, can it print out clearer instructions?
EDIT:  Or, alternatively, actually process csproj / sln files and format all the C# scripts inside them

I like the idea of allowing someone to pass a csproj/sln file, I created #399 for adding support for it.
Even with that implemented, if someone passes a path to csharpier that it can't format it should definitely let the user know.

authors: belav svermeulen


text:
Enforce trailing commas in object and collection initializer

Take the following code:
var foos = new[]
{
    new Foo(),
    new Bar()
};

If later a new item is added:
var foos = new[]
{
    new Foo(),
    new Bar(),
    new Baz()
};

This causes the following issues:

A misleading commit diff of +2/-1 even though there isn't really any code deletion.
Polluting git blame.

These issues also occur when deleting/reordering the last item in initializers.
These issues can be fixed by enforcing trailing commas.
Relevant Prettier option: https://prettier.io/docs/en/options.html#trailing-commas

I had considered this early on - #23. I think it was closed because we decided to not have csharpier changing anything besides whitespace. But there are good arguments for transforming code in some cases, and there are good arguments for forcing tailing commas. The discussions I found around making trailing commas the default in prettier - https://github.com/prettier/prettier/issues/9369 and https://github.com/prettier/prettier/issues/68
I think I am in favor of adding this. If it were to follow the prettier way, it would only include the trailing comma when the initializer breaks.

Conversely, it would also be nice if CSharpier removed the trailing comma when the object initializer fits on single line.
I think it's a common style guide to not have the final comma on a single line, and include it on multiple lines, i.e. this format:
Dictionary<string, string> headers;

// No trailing comma after If-Match
headers = new()  { { "OData-Version", "4.0" }, { "If-Match", "*" } };

// Trailing comma after If-Match
headers = new()
{
  { "OData-Version", "4.0" },
  { "Accept", "application/json;odata.metadata=minimal" },
  { "If-Match", "*" },
};

I think this makes a strong argument for CSharpier adding/removing that comma automatically:

Depending on the length of initializers, CSharpier will reflow on single or multiple lines.
Currently if you want to adhere to the style above, you need to manually add/remove that comma based on CSharpier reflow, so after CSharpier runs.
This is not doable if you run CSharpier automatically, e.g. as part of a git commit hook. Even if you Format on Save, it's easy to miss.

Also csharpier could act as Black (popular python code formatter) about trailing commas. It forces multiline output if sees trailing comma.
So this code in python
def foo(a: int, b: str,) -> None:

will be formatted to
def foo(
    a: int,
    b: str,
) -> None

And vice versa this code
def foo(
    a: int,
    b: str
) -> None:

will be formatted to
def foo(a: int, b: str) -> None:

because it doesn't have trailing comma and statement fits to one line.
It is really useful behaviour and gives power to users to force multiline output when it improves readability.

@tkukushkin I'm personally against that. The biggest benefit of Prettier is to simply stop people from arguing about style and just get things done. Introducing choices especially to the degree of being able to vary place by place, will devolve it back into arguing about when should we break into multiple lines or not.

I understand your point and I can say from my experience, that I've never seen any arguments over someone splitting one statement into several lines when it fits into one. Nobody cares about such things. But this is my personal experience and maybe your experience is different.
I think Black was created with the same principle in mind, only few basic configuration options, it is uncompromising, opinionated. And this behaviour works for Black, then why wouldn't it work for csharpier?

I'm not sure that's a good reasoning, on the flip side "Prettier doesn't allow you the force a line split at all, why wouldn't it work for CSharpier?"
It's one less thing to worry about: if the line was too long when I originally wrote it, formatter should split it and insert the trailing comma; if later a parameter or two was removed and the line is no longer too long to fit in one line, formatter should just change it back to one line and also remove that trailing comma in the process, rather than keeping it split. The fact that you can arrive at the same code in two different ways and ends up with two different formatting of the exact same code, is imo not desirable.

I'm gonna side with @NonSpicyBurrito on this one.
I like that CSharpier (or Prettier) handles like length for me. Managing line breaks manually just feels wrong.
Consider: after I (globally) rename a type in my solution, some method declaration may have significantly changed length.
I don't want to review each one manually to make them (un-)wrap based on the last comma.
I want CSharpier to just reformat them appropriately.

Consider: after I (globally) rename a type in my solution, some method declaration may have significantly changed length.
I don't want to review each one manually to make them (un-)wrap based on the last comma.

If new name is longer and some statement (method call for example) doesn't fit in one line anymore, it will be formatted as multiline, no changes to current behaviour here.
If new name is shorter and some statement is already multiline, has trailing comma and could fit in one line, it will not be unwrapped, yes. And it is not common case IMHO, I have never reviewed each change manually, because it is not so important. There is no problem for me that some statements remain multiline.
I think we can stop arguing about this, I understand your point and respect your decision.

It would be really nice to have this as a configuration option.

It would be really nice to have this as a configuration option.

Is it posible to turn off this feature ? I really thinks it downgrades the quality of source the code

Is it posible to turn off this feature ? I really thinks it downgrades the quality of source the code

@martinib77 there will not be a configuration option added for this. Can you elaborate why you don't like it? There are plenty of arguments for why they should be included but I have not come across any against it.

Is it posible to turn off this feature ? I really thinks it downgrades the quality of source the code

@martinib77 there will not be a configuration option added for this. Can you elaborate why you don't like it? There are plenty of arguments for why they should be included but I have not come across any against it.

Sorry, code quality was not the best sentence. I wanted to refer to something more abstract, about the beauty and presentation of the code. Sentences that end in a comma and then close the block do not seem very pleasant to me.

Is it posible to turn off this feature ? I really thinks it downgrades the quality of source the code

@martinib77 there will not be a configuration option added for this. Can you elaborate why you don't like it? There are plenty of arguments for why they should be included but I have not come across any against it.

Could it be argued that since prettier has an option for that (trailingComma) csharpier should have, too?

Sorry, code quality was not the best sentence. I wanted to refer to something more abstract, about the beauty and presentation of the code. Sentences that end in a comma and then close the block do not seem very pleasant to me.

I share the feeling :(

Could it be argued that since prettier has an option for that (trailingComma) csharpier should have, too?

From my understanding, the reason Prettier has an option for trailingComma is mainly because of the need to support old versions of JS where trailing comma is not legal syntax, and not necessarily because community opinion on it is split to a point where an option must be provided (like with tabs vs spaces, 2 vs 4, etc). See Prettier's 3.0 release blog post where trailing comma default value changed from es5 to all, the PR https://github.com/prettier/prettier/pull/11479 associated with the change, and the prior PR https://github.com/prettier/prettier/pull/6963 which changed from none to es5.
I personally wouldn't care if an option was added since I'd leave it enabled either way, but I think "Prettier has it so CSharpier should also have it" is not necessarily a strong point, because JS and C# are fundamentally different in that you do not control the language version in user's browser.

Is it posible to turn off this feature ? I really thinks it downgrades the quality of source the code

@martinib77 there will not be a configuration option added for this. Can you elaborate why you don't like it? There are plenty of arguments for why they should be included but I have not come across any against it.

I just noticed csharpier doing this and it really got my back up.
Prettier has a config for this and our project has it turned off as trailing commas are gross for anyone with any sense of tidyness!

trailing commas are gross for anyone with any sense of tidyness!

Somehow many people, who lack any sense of tidyness apparently, like them. Including Prettier authors.
One key philosophy of Prettier/CSharpier is to remove style discussion in project teams, by not providing options.
This trailing comma is such a small thing that I'm sure you can live with it and it doesn't warrant an option.
(There's a good legacy reason for Prettier having this option, see comments above.)
Personally, there are other formatting choices from Prettier that I find way worse than a trailing comma, yet I just learnt to accept them and go along. Why? because overall the formatting is good, I like not having to bother with formatting and I value consistency in projects. Convenience wins over personal nitpicks.
I think that if you want full control over tiny details like trailing commas, CSharpier might not be the right tool for you.
Maybe look into using dotnet-format instead: everything is fully configurable.

authors: Meowtimer NonSpicyBurrito Sahasrara alastair-todd belav jods4 martinib77 tkukushkin


text:
add: menambahkan algoritma baru

Closes

Deskripsi (Description)

[x] saya menambahkan algoritma terbaru
[ ] saya memperbaiki algoritma yang sudah ada
[ ] saya menambahkan materi/sub materi belajar
[ ] saya memperbaiki materi/sub materi belajar
[ ] saya menambah dokumentasi
[ ] saya memperbaiki dokumentasi

Contributor Requirements (Syarat Kontributor)

[x] saya sudah membaca (i have read) CONTRIBUTING dan sudah menyetujui semua
[ ] saya telah menambahkan docstring yang memberikan penjelasan maksud dari kode yang saya buat
[x] saya menggunakan bahasa indonesia untuk memberikan penjelasan dari kode yang saya buat

Environment
saya menggunakan (im used):

os = windows

Testing

[ ] doctesting js
[x] lint testing eslint

bang ini analysis dari codacy harus pass kah?

makasih sarannya bang @slowy07, ntar saya coba terapin

waduh, ini codacy 😭 😭 udah diubah pdhl

repo: bellshade/Javascript


text:
[FEATURE] Show commit activity

Imagine it could scan a directory for repositories with changes, and then submit those as a list of dones.

By way of enhancement, let me supply a date, so for example I can see git activity for yesterday. Or tge past week

You may say --since=yesterday

repo: ben-biddington/idonethis-cli


text:
Hardware acceleration

Doesn't replacing items like translate3d with translate reduce performance of the animation? I thought translate3d invoked hardware acceleration, unless that's changed in more modern browsers?

I don't think that is the case, though I would love to see any benchmarks proving or disproving this. I'm just going off what MDN has to say in this area, which is that certain values for 3D transforms can be converted to a shorter 2D transform;

The rotateX() CSS function defines a transformation that moves the element around the abscissa without deforming it. The amount of movement is defined by the specified angle; if positive, the movement will be clockwise, if negative, it will be counter-clockwise. The axis of rotation passes by the origin, defined by [the] transform-origin CSS property.
rotateX(a) is a shorthand for rotate3D(1, 0, 0, a).

https://developer.mozilla.org/en-US/docs/Web/CSS/transform-function

authors: ben-eb gregorypratt

repo: ben-eb/postcss-reduce-transforms


text:
Add an option to not replace value in case of null

This is related to #163
Suppose I've got Job class with Set<Employee> employees = new HashSet<>(); field. If randomizer will return null default HashSet will be replaced with null.
Is it possible to not replace default value in case of null? Something like  DefaultValueOrNullRandomizer

Hi,
Just to make sure I understand your requirement, you have the following class:
public class Job {
     private Set<Employee> employees = new HashSet<>();
}

and you ask random beans to generate a random instance of Job. What are you expecting to get in the employees field? An empty set?
As of version 3.1, random beans will randomize the employees field and I believe this is a bug (somehow related to inline initialization. Inline initialization of fields should not be changed in regards to what the class designer has decided.
If I have the following class:
@Data
    public static class BeanWithDefaultValues {
        Set<String> strings = new HashSet<>();
        List<Integer> integers = Arrays.asList(1, 2, 3);

        public BeanWithDefaultValues() {
            integers = Arrays.asList(1, 2, 3);
        }
    }

random beans will randomize both strings and integers fields and this is not what I'm expecting. The following test is failing with 3.1:
@Test
public void inlineInitializationShouldNotBeChanged() {
        EnhancedRandom enhancedRandom = aNewEnhancedRandomBuilder().build();

        BeanWithDefaultValues bean = enhancedRandom.nextObject(BeanWithDefaultValues.class);

        assertThat(bean).isNotNull();
        assertThat(bean.getStrings()).isEmpty();
        assertThat(bean.getIntegers()).containsExactly(1, 2, 3);
}

So this should be the default behavior, not a configurable feature. Do you agree?
Kind regards
Mahmoud

Hi Mahmoud,
I agree. Not overwriting fields values follows the principle of least surprise and should be the default.

I always predefine lists/maps and etc (as I described before) to prevent NullPointerException. But I still want this fields to be randomized (as it works now). I think this is correct behavior.

What are you expecting to get in the employees field? An empty set?
Sometimes empty set / sometimes set with random values. But not null value.

Sorry, I still don't clearly understand

Sometimes empty set / sometimes set with random values. But not null value.

I don't see how random beans can set this field to null. As of current version 3.1, it will randomize the field

Is it possible to not replace default value in case of null?

what do you mean by "in case of null" ?

Here is full example - https://gist.github.com/anonymous/ec5b65984524df99cd0438842e62c76b - I hope it will explain you an idea.
DefaultValueOrNullRandomizer will return null for Article.tags and new HashSet<>() for ArticleWithDefault.tags

Ok I see, thank you for the example. This is a very specific requirement and I'm not sure it should be part of the library out of the box. Random Beans provides the RandomizerRegistry extension point specifically for this kind of custom requirements. So I suggest you use a custom registry for that.
BTW, @PascalSchumacher has kindly added support to override default initialization with the overrideDefaultInitialization parameter. You can try it out already with version 3.2.0-SNAPSHOT.
Kind regards
Mahmoud

authors: PascalSchumacher benas fedotxxl

repo: benas/random-beans


text:
DOC Pin sphinx version to 4.5.0

With sphinx 5.0 I could not build the doc, as in https://github.com/alphacsc/alphacsc/pull/95

little fix to add @Melvin-klein 's name

Codecov Report

Merging #501 (e872971) into main (aa4c930) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #501   +/-   ##
=======================================
  Coverage   53.70%   53.70%
=======================================
  Files          40       40
  Lines        2696     2696
  Branches      494      494
=======================================
  Hits         1448     1448
  Misses       1135     1135
  Partials      113      113

authors: codecov-commenter mathurinm

repo: benchopt/benchopt


text:
bulk selection needs to add all row indexes to the selection store

If you click the bulk check box, all the rows are visually selected but the indexes array is not available like it is when you check the rows individually.
const indexes = this.props.selection.get("myGrid").get("indexes");

indexes should be defined as an array with all the row indexes after clicking the bulk checkbox.
For instance, in a grid with 10 rows. If you begin with a bulk check then manually uncheck a row, you should now have 9 indexes but indexes is undefined.   If you check that same row again, indexes is now defined but with 1 not 10.
@bencripps I'm going to try to fix this and update the tests. I just wanted to capture it. Please assign it to me.

the workaround is not use to indexes - instead the selected state of each row which is actually included within selection although its not reflected in indexes.
const selection = this.props.selection.get("workbench");
const selectionData = selection.toJS();
const selectedIds = [];
   for (var key in selectionData) {
     if (selectionData[key]) {
       let selectedId = key.split("row-")[1];
       selectedIds.push(Number(selectedId));
     }
    }

selectionData looks like:
{
indexes: Array[0],
lastUpdate: 6,
row-0: true,
row-1:false,
row-2:true,
row-3:true
}

This was resolved with #160

authors: bencripps headwinds

repo: bencripps/react-redux-grid


text:
Check that b:neomake_signs_cleared exists before reading it.

b:neomake_signs_cleared is set in the buffer where :Neomake is called, but if a maker returns
errors in another buffer, then this variable won't be defined.
Should fix #64.

Thanks for figuring this out! By the way, I went ahead and made you a contributor. If for some reason you'd rather not be, just ask me and I'll undo that. Thanks again!

Fixing the bugs I created myself seems normal to me :)
I still think there may be a deeper issue, because I think I encountered this bug even with a maker that to the best of my knowledge emit errors only for the current file (rubocop). But I can not reproduce it.
Thanks for the access to the repo! However, I don't promise anything about the frequency of my contributions.

That's fine :)

authors: Neki benekastah

repo: benekastah/neomake


text:
🛑 ChooChoo API is down

In fb33560, ChooChoo API (https://benfoster.dev/choochoo/rug-bhm) was down:

HTTP code: 0
Response time: 0 ms

Resolved: ChooChoo API is back up in ec50ae4.


text:
Docs/html css

Upskilling HTML and CSS knowledge
Fixes # (issue)
Type of change
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as
expected)
[ ] Documentation (update or new)

How Has This Been Tested?
Passed all the tests in the github.
Testing Checklist:

[ ] Tested in latest Chrome
[ ] Tested in latest Safari
[ ] Tested in latest Firefox

Checklist:

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have requested a review from ... on the Pull Request

 Upskill HTML and CSS

repo: benmathewthomas/documentation


text:
fix: adds missing dependency to the docs

@unocss/preset-wind

@delight thanks for this, I forgot to do it yesterday :)

authors: bennymi delight

repo: bennymi/ato-ui


text:
Does not work on windows

The application panicked (crashed).
Message:  HOME directory not set: NotPresent
Location:
https://github.com/bensadeh/tailspin/blob/c148d6a72617203318cf126c5e4317697606f0a2/src/theme_io/mod.rs#L14
The HOME environment variable name is USERPROFILE on Windows.

Just set an environment variable  name _XDG_CONFIG_HOME, then it will work.
`-c, --config-path CONFIG_PATH
Specify the path to a custom configuration file. Defaults to XDG_CONFIG_HOME/tailspin/config.toml or ~/.config/tailspin/config.toml if not set.

`

Thanks for opening up this issue and letting me know about this.
In time, I'd like to move away from the UNIX-specific implementation to support to a more open one that supports Windows. However, I don't use Windows myself, so it is not something I'm able to test myself.

@bensadeh Replace to env::var("HOME").or(env::var("USERPROFILE")).expect("HOME directory not set"); should work.

I'd be happy to help test any PRs for this on Windows (though I am away next week)
I tried something similar to @Cologler's suggestion, and it works but now I have further issues:
The way colors are encoded appear to need changing to work with Windows, at least on the AWS SSM session I have:
PS D:\software> .\tspin.exe
Missing filename (?[35mtspin --help?[39m for help)

It also fails to find less:
PS D:\software> .\tspin.exe -t D:\apps\logs\web.log.20231109
Failed to open file with less

tail -f D:\apps\logs\web.log.20231109 | .\tspin.exe  does work though

@alicekaerast Colors work on my environment (windows 11 + Windows Terminal + PowerShell core).

Interesting, how are you building it? I'm not sure if that makes any difference, but I have to cross-compile from my Macbook and I used cargo build --target=x86_64-pc-windows-gnu. The colors are broken for me on Powershell terminal and command prompt via RDP as well as via SSM connections
I do already have less.exe in my path, so running less on its own already works
This is all on Windows Server 2019

how are you building it?

I built it on my Macbook with the following:
curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh
rustup target add x86_64-pc-windows-gnu
brew install mingw-w64
cargo build --target=x86_64-pc-windows-gnu

I don't have the ability to build it in Windows directly due to network restrictions

@bensadeh Work as expected. Keep this open until release.

Just released 2.1.0. Hope everything works well.

authors: Cologler Innocence alicekaerast bensadeh

repo: bensadeh/tailspin


text:
Suggestion: Add a name field to item attachment editor (ChatColor)

BkCommonLib version: -
TrainCarts version: -
Spigot version: -

Description
In commit 7ce7cb9, fields have been added to toggle Unbreakable and CustomModelData, but I want to suggest a name field since I have attachments change texture using different item names, controlled by Optifine. (Oh and ChatColor as well)

I could add a little button on the same page as the custom model data field which when activated opens up an anvil editor where you can input this. (with a command equivalent of course)

🤗

I've implemented this now. https://github.com/bergerhealer/TrainCarts/commit/59db1af910fa223c6f53bb9130ca371dbf6c24bf

Thanks, sometimes colour may also be required, do you think you can parse some colours in the input widget?

Pasting those weird color code characters doesnt work?

They never worked properly on lower versions, i.e. 1.12.2 and also 1.8.9

strange, because Im using the Bukkit ChatFormat -> IChatComponent stuff which does accept those characters regardless of mc version. Or does the client side not send those characters back when you type it in?

It's the client that refuses to put those characters in, using the windows shortcut of ALT+that number, as well as doing a copy and paste has never succeeded back in 1.12.2 as well as 1.8.8. However, if the item (talking about anvils) already had colour, then it can be manipulated as long as you don't delete the section signs

I see. Then the same applies to the text attachment. I can add some color code handling to the MapWidgetSubmitText in BKCommonLib so it covers all future ground

Can confirm that pasting the section sign into 1.12.2 does not work, also doesn't work in 1.14.4

Pasting text will section signs mixed within causes the section signs to be completely removed on paste, not even changing the colours.

This is also true for the player chat, meaning that the command /train menu set value will also be affected.

Eh, you know what, it's good enough. Closing my own issue.

repo: bergerhealer/TrainCarts


text:
Client stalls on startup & resourcepack load/reload when loading a model with missing parent bones

GeckoLib Version
geckolib-forge-1.20.1-4.4.4
Bug Description
The client stalls on startup or resourcepack load/reload when geckolib tries to load model geometry with bones that reference a non-existing parent bone.
Profiling has shown that GeometryTree.fromModel() is the culprit for the stalling.
https://github.com/bernie-g/geckolib/blob/c6a809c18a080defe1d74028c73d7ca4eafa3881/Forge/src/main/java/software/bernie/geckolib/loading/object/GeometryTree.java#L17
Expected Behavior
The client should crash or skip loading of the faulty model.
How to replicate
Place the following model into your assets/<namespace>/geo folder or use this resourcepack geckolib_bug.zip
{
	"format_version": "1.12.0",
	"minecraft:geometry": [
		{
			"description": {
				"identifier": "geometry.unknown",
				"texture_width": 16,
				"texture_height": 16,
				"visible_bounds_width": 2,
				"visible_bounds_height": 1.5,
				"visible_bounds_offset": [0, 0.25, 0]
			},
			"bones": [
				{
					"name": "orphan",
					"parent": "missing_parent",
					"pivot": [0, 0, 0],
					"cubes": [
						{"origin": [-1, 0, -1], "size": [2, 2, 2], "uv": [0, 0]}
					]
				}
			]
		}
	]
}

[!important]
The bone "orphan" is referencing the non-existing parent bone "missing_parent"

How to easily produce faulty models with Blockbench

[!important]
Please take note of how i disabled the export of the parent bone

This is fixed in 4.5 and if backported will be fixed in 1.20.1

authors: Elenterius Tslat

repo: bernie-g/geckolib


text:
Fix potential crash when stack is resized

Fix a rare bug discovered in Tasmota.
When calling a virtual method or virtual member, GETMBR and GETMET indirectly call a function (native or Berry). This calls checks the stack size and may in rare circumstances resize the stack; hence relocates the stack at a different address.
Unfortunately in such case, RA() address is no more valid and still points to the old stack location. This patch stores the result to a temporary location on the C stack, and defers the computation of RA() until after the call to the function was made.

I removed the gcc warning by adding an assignment that is actually never reached. This avoids a useless initialization that would negatively impact performance.

repo: berry-lang/berry


text:
默认用户名不能修改吗

默认用户名不能修改吗

username 字段因为涉及到初始化，是不能更改的。如果您是指登录时用的邮箱的话，是可以的。没做这个功能，您可以直接去数据库改，做这个功能感觉没啥必要。

嗯嗯嗯，就是那个默认邮箱，我可以在启动的时候加一些环境变换替换一下吗，还是怎么改

修改 users 表的 email 的值即可。

好的

authors: besscroft zzkuner

repo: besscroft/PicImpact


text:
Issue with nuxt 3.9.0

Cannot start nuxt:  Nuxt module should be a function: [object Object]
Please look into your module

Hi @rahulkumarsingh73690,
This happened due to breacking changes in new versions of Nuxt. I updated the version of nuxt-kit. Now everything works

repo: bestkolobok/nuxt-jsoneditor


text:
Add Embla Carousel React

Hi Michael (@michaelrambeau)!
I love the new BestOfJS design and UI, great work 👍. I'd like to add embla-carousel-react to the BestOfJS list. It's:

A tiny React.js wrapper for Embla Carousel.

Thank you in advance and have a nice one!
Cheers,
David

Hello David,
Thank you for your comments about the latest changes, there are still a lot things to do, starting with a better home page.
OK, I understand your point of view, Embla Carousel React, will be available, but to be honest, I feel it's not totally right because Embla Carousel and Embla Carousel React are not really 2 different projects, they should belong to the same entity. Both projects have the same home page so they are really "connected".
We have already had this discussion but it could be nice to have a single repo in the future.
Now, from the developer point of view, if you make a change that impacts the 2 projects you have to publish changes to 2 different repos at the same time.
From the user point of view, you have to switch to 2 different repos to get the documentation.
Same problem about where to create an issue: you have to figure out if it's a problem in the core package or in the React package.
For Pull Requests, you have to coordinate 2 processes in the same time.
A lot of projects have solved this issue using the concept of "mono-repo", a single repo in GitHub split into multiples packages.
Actually we had a discussion about a feature to be see the packages that belong to a mono-repo in Best of JavaScript: https://github.com/michaelrambeau/bestofjs/issues/297#issuecomment-563382980
FYI, for my projects I'm thinking about using Yarn workspaces but there are other solutions: https://bestofjs.org/projects?tags=monorepo
An other idea: maybe the simplest solution would be to restore the ability of adding "links" to projects.
Anyway I will tell you when Embla Carousel React is available on Best of JavaScript, these are only ideas to be discussed.

Hello again @michaelrambeau,
Thinking about it, you're right and I agree. It's basically the same project so let's skip this process. Thank you for your attention 👍!
Best,
David

Don't misunderstand me David @davidcetinkaya I really want to help you promote Embla, your request was accepted, it will be online in 24 hours.
We will adjust things when we both make progress (when _Best of JS handles mono-repos packages and when your project structure changes), no worries 😄

No worries Michael, and no hard feelings! It's just that you convinced me 🙂. Thinking twice, the react package will be redundant so let's not do anything about it for now 👍.

Hello David! @davidcetinkaya
It's online, search for "Embla" and you will find 2 occurrences.
Is it OK?
At least until we provide a way to link several NPM packages from a single project?
Or if you prefer I can remove it, waiting for the "multi-package" feature? As you want 😃
It's just that I'm afraid that other package authors ask me to create several entries of for all variants of their projects!

Hi Michael @michaelrambeau,
Thank you for your efforts 😄. You convinced me before and I very much agree with your reasoning so I'd prefer if you could remove it if that's ok with you? Sorry if I caused any trouble. It's pretty much the same project so it feels kind of redundant 👍.
Best,
David

authors: davidcetinkaya michaelrambeau

repo: bestofjs/bestofjs-webui


text:
Rename MUI to Material UI

This is a follow-up on https://github.com/bestofjs/bestofjs/pull/126#issuecomment-1030942781

Michael Rambeau: it used to be called Material UI but I changed to "MUI" in December when I noticed the description in the official home page was:

For the last 12 months+ we worked toward having only Material UI for the name of the open-source project. We limited the use of MUI to the name of the organization working on this.

https://bestofjs.org/projects/mui
Could we:

Change "MUI" to "Material UI"
Change the URL to https://mui.com/material-ui/. Linking to https://mui.com/core/ is OK, but we moved Base UI into its own repository, out of the Material UI repository, and plan to do the same with Pigment CSS.
Change the URL slug from /projects/mui to /projects/material-ui

Thanks
(cc @danilo-leal for context)

Hello Olivier! @oliviertassinari
Thank you so much for your interest in Best of JS, that means a lot to me 😄
The project has just been renamed, please check https://bestofjs.org/projects/material-ui
Is it OK to update the project name in the JS Rising Stars project too? (I will update the URLs, at least, to avoid 404 errors)

Is it OK to update the project name in the JS Rising Stars project too? (I will update the URLs, at least, to avoid 404 errors)

Oh yes; please, amazing, thanks!

OK Olivier, MUI has been renamed in the Rising Stars projects:
https://risingstars.js.org/2023/en#section-react

There is no 301 redirect feature for project details URL (/projects/:slug) but that could be an interesting feature for projects with a long history, like Material UI 😄

@michaelrambeau Appreciated ✨

authors: michaelrambeau oliviertassinari

repo: bestofjs/bestofjs


text:
🛑 API Camino is down

In 70c27ec, API Camino (https://api.camino.beta.gouv.fr/titres) was down:

HTTP code: 0
Response time: 0 ms

Resolved: API Camino is back up in 52c440a.


text:
🛑 Shine at Date is down

In f3119db, Shine at Date (https://shineatdate.com) was down:

HTTP code: 404
Response time: 755 ms

Resolved: Shine at Date is back up in e1d9672 after 13 minutes.

repo: betterwithagency/status-page


text:
Can cgpath be supported？

What problem does this solve or what need does it fill?
A description of why this particular feature should be added.
What solution would you like?
The solution you propose for the problem presented.
What alternative(s) have you considered?
Other solutions to solve and/or work around the problem presented.
Additional context
Any other information you would like to add such as related previous work,
screenshots, benchmarks, etc.

Do you mind providing more information about this? A quick google shows cgpath as being a Swift UI API? How would you imagine a Bevy integration here working?

Do you mind providing more information about this? A quick google shows cgpath as being a Swift UI API? How would you imagine a Bevy integration here working?

Bevy is using glam for math: https://crates.io/crates/glam
You can enable the mint feature on cgmath and glam to have compatibility between them, but cgmath won't be supported as first party.

repo: bevyengine/bevy


text:
Use u32 over usize for ComponentSparseSet indicies

Objective
Use less memory to store SparseSet components.
Solution
Change ComponentSparseSet to only use Entity::id in it's key internally, and change the usize value in it's SparseArray to use u32 instead, as it cannot have more than u32::MAX live entities stored at once.
This should reduce the overhead of storing components in sparse set storage by 50%.

As @TheRawMeatball stated, the cast is likely inconsequential. Here are the relevant benchmark results, most of these are within a reasonable margin of error, but there are notable speedups in sparse set iteration with the indexes being smaller, and thus cache friendly.
group                                                    main                                     u32-component-sparse-set
-----                                                    ----                                     ------------------------
add_remove_component/sparse_set                          1.02  1319.4±91.25µs        ? ?/sec      1.00  1291.4±78.07µs        ? ?/sec
add_remove_component_big/sparse_set                      1.02  1500.2±336.32µs        ? ?/sec     1.00  1473.8±321.34µs        ? ?/sec
query_get/50000_entities_sparse                          1.07  1127.2±55.93µs        ? ?/sec      1.00  1053.6±22.41µs        ? ?/sec
query_get_component/50000_entities_sparse                1.02  1287.5±52.23µs        ? ?/sec      1.00  1257.3±167.29µs        ? ?/sec
simple_iter/sparse                                       1.09     61.3±0.32µs        ? ?/sec      1.00     56.1±1.11µs        ? ?/sec
simple_iter/sparse_foreach                               1.12     50.4±0.76µs        ? ?/sec      1.00     44.8±1.89µs        ? ?/sec
sparse_fragmented_iter/base                              1.09     12.8±0.86ns        ? ?/sec      1.00     11.7±1.18ns        ? ?/sec
sparse_fragmented_iter/foreach                           1.03      8.9±0.14ns        ? ?/sec      1.00      8.7±0.31ns        ? ?/sec
world_get/50000_entities_sparse                          1.00    548.2±8.05µs        ? ?/sec      1.00   547.7±13.61µs        ? ?/sec
world_query_for_each/50000_entities_sparse               1.17     95.8±0.91µs        ? ?/sec      1.00     81.9±1.48µs        ? ?/sec
world_query_get/50000_entities_sparse                    1.00   398.2±10.82µs        ? ?/sec      1.00   397.8±11.95µs        ? ?/sec
world_query_iter/50000_entities_sparse                   1.19    102.8±3.31µs        ? ?/sec      1.00     86.7±1.59µs        ? ?/sec

@bevyengine/ecs-team more performance optimizations that are ready to review.


text:
Improve OrthographicCamera consistency and usability

Objective

Terminology used in field names and docs aren't accurate
window_origin doesn't have any effect when scaling_mode is ScalingMode::None
left, right, bottom, and top are set automatically unless scaling_mode is None. Fields that only sometimes give feedback are confusing.
ScalingMode::WindowSize has no arguments, which is inconsistent with other ScalingModes. 1 pixel = 1 world unit is also typically way too wide.
OrthographicProjection feels generally less streamlined than its PerspectiveProjection counterpart
Fixes #5818
Fixes #6190

Solution

Improve consistency in OrthographicProjection's public fields (they should either always give feedback or never give feedback).
Improve consistency in ScalingMode's arguments
General usability improvements
Improve accuracy of terminology:

"Window" should refer to the physical window on the desktop
"Viewport" should refer to the component in the window that images are drawn on (typically all of it)
"View frustum" should refer to the volume captured by the projection

Changelog
Added

Added argument to ScalingMode::WindowSize that specifies the number of pixels that equals one world unit.
Added documentation for fields and enums

Changed

Renamed window_origin to viewport_origin, which now:

Affects all ScalingModes
Takes a fraction of the viewport's width and height instead of an enum

Removed WindowOrigin enum as it's obsolete

Renamed ScalingMode::None to ScalingMode::Fixed, which now:

Takes arguments to specify the projection size

Replaced left, right, bottom, and top fields with a single area: Rect
scale is now applied before updating area. Reading from it will take scale into account.
Documentation changes to make terminology more accurate and consistent

Migration Guide

Change window_origin to viewport_origin; replace WindowOrigin::Center with Vec2::new(0.5, 0.5) and WindowOrigin::BottomLeft with Vec2::new(0.0, 0.0)
For shadow projections and such, replace left, right, bottom, and top with area: Rect::new(left, bottom, right, top)
For camera projections, remove l/r/b/t values from OrthographicProjection instantiations, as they no longer have any effect in any ScalingMode
Change ScalingMode::None to ScalingMode::Fixed

Replace manual changes of l/r/b/t with:

Arguments in ScalingMode::Fixed to specify size
viewport_origin to specify offset

Change ScalingMode::WindowSize to ScalingMode::WindowSize(1.0)

Ping @bzm3r for review.

@alice-i-cecile shouldn't this be tagged with "breaking change"?

Yep, thank you!

I have a few minor suggestions but I like the changes! Worth noting this breaks the current 2d examples as is - they all appear way more zoomed in than they should be. But that's just a matter of adjusting the defaults to be closer to how it was before.

Oh, I didn't notice that. That's probably because I made the default for WindowSize 10 since the camera is usually way too zoomed out by default, but I can change it back.

Not sure how I managed to screw up the commit message this much

I'm trying to add a separate "config" struct, but it's a bit of a mess (and might be unnecessarily complicated). Maybe using a builder or just a simple constructor would work better?

Unfortunately no; you can't use struct update syntax unless the fields are pub. I think a builder pattern or an elaborate constructor is the way to go.

Thanks for the change! I salute the documenting part which is much welcome ♥ But I'm more skeptical about the builder pattern refactoring. For one, it feels those two changes are unrelated and should maybe be done in separate PRs. I also personally don't like the pattern so much, mostly as it increases inconsistency with the rest of the Bevy codebase.

I sort of agree with this. Do you have any suggestions for alternatives? Every other method I've looked at has had some other downside. I could also just leave the fields public.

I sort of agree with this. Do you have any suggestions for alternatives? Every other method I've looked at has had some other downside. I could also just leave the fields public.

Because this is the recommended and promoted pattern in the rest of the codebase, yes I would just leave those as public fields for now. We can discuss whether this is the right pattern or not (I doubt we can convince anyone of a change at this point though), but I wouldn't make this object inconsistent unless there's an overwhelming benefit to the builder pattern, which I don't think we showed here.

I sort of agree with this. Do you have any suggestions for alternatives? Every other method I've looked at has had some other downside. I could also just leave the fields public.

Because this is the recommended and promoted pattern in the rest of the codebase, yes I would just leave those as public fields for now. We can discuss whether this is the right pattern or not (I doubt we can convince anyone of a change at this point though), but I wouldn't make this object inconsistent unless there's an overwhelming benefit to the builder pattern, which I don't think we showed here.

That's fair. Clearly documenting that l/r/b/t should be for reading only should be fine for now.

I've been kind of busy lately but I have some time this week for some minor fixes and to test examples. This should be ready for review after that.

@xgbwei once this is rebased I'd like to merge it.

Did I do that right?

Rebase looks almost correct: you have an empty scene_viewer file :)

bors r+

authors: alice-i-cecile djeedai xgbwei


text:
rename add_plugin_group to add_plugins

Its slightly less explicit, but I like the terseness more.

It's fun being involved in the break-everything stage. 😄

authors: CleanCut cart


text:
Local setup 2

Failing at this stage now:
cd assets && npm install && node node_modules/webpack/bin/webpack.js --mode development

added 877 packages, and audited 881 packages in 12s

45 vulnerabilities (15 moderate, 30 high)

To address issues that do not require attention, run:
  npm audit fix

To address all issues (including breaking changes), run:
  npm audit fix --force

Run `npm audit` for details.
[hardsource:99c17de1] Writing new cache 99c17de1...
[hardsource:99c17de1] Tracking node dependencies with: package-lock.json.
Browserslist: caniuse-lite is outdated. Please run:
npx browserslist@latest --update-db

Why you should do it regularly:
https://github.com/browserslist/browserslist#browsers-data-updating
Hash: 4e099235670d234a813e
Version: webpack 4.41.5
Time: 1225ms
Built at: 11/04/2021 10:48:04 PM
                       Asset       Size  Chunks             Chunk Names
    ../css/bootstrap.min.css    156 KiB          [emitted]
../css/bootstrap.min.css.map    627 KiB          [emitted]
           ../css/c3.min.css   2.39 KiB          [emitted]
           ../css/layout.css   1.92 KiB          [emitted]
          ../css/select2.css   15.5 KiB          [emitted]
    ../css/shards-extras.css   4.36 KiB          [emitted]
           ../css/shards.css    119 KiB          [emitted]
           ../css/styles.css   11.5 KiB          [emitted]
      ../js/bootstrap.min.js   58.6 KiB          [emitted]
  ../js/bootstrap.min.js.map    190 KiB          [emitted]
             ../js/c3.min.js    204 KiB          [emitted]
                 ../js/d3.js    242 KiB          [emitted]
          ../js/flowchart.js   74.1 KiB          [emitted]
         ../js/jquery.min.js   86.1 KiB          [emitted]
        ../js/jquery.min.map    133 KiB          [emitted]
             ../js/popper.js   20.5 KiB          [emitted]
       ../js/quick_action.js   7.99 KiB          [emitted]
            ../js/select2.js   70.7 KiB          [emitted]
           ../js/sortable.js   12.4 KiB          [emitted]
               ../robots.txt  202 bytes          [emitted]
                      app.js    395 KiB     app  [emitted]  app
Entrypoint app = app.js
[0] multi ./js/app.js 28 bytes {app} [built]
[../deps/phoenix/priv/static/phoenix.js] 38.9 KiB {app} [built]
[../deps/phoenix_html/priv/static/phoenix_html.js] 2.21 KiB {app} [built]
[../deps/phoenix_live_view/priv/static/phoenix_live_view.js] 113 KiB {app} [built]
[./js/app.js] 2.1 KiB {app} [built]
[./js/chat.js] 1.52 KiB {app} [built]
[./js/communication_notification.js] 4.11 KiB {app} [built]
[./js/live_search.js] 791 bytes {app} [built]
[./js/socket.js] 2.2 KiB {app} [built]
    + 1 hidden module

ERROR in ./js/app.js
Module not found: Error: Can't resolve './load_test' in '/home/gajop/projects/teiserver_tei/assets/js'
 @ ./js/app.js 12:0-35 17:2-10
 @ multi ./js/app.js

I've pushed a fix that should sort it, please test and let me know if this resolves the issue. I won't close this issue until it's working "out of the box" for you.

seems to have passed without errors now

authors: Teifion gajop

repo: beyond-all-reason/teiserver


text:
Landing Page

This PR handles #5.
It adds a basic Django app (main_app) that will serve the main application of the platform. With that, it adds a landing page that includes the basic structure of html templates and static css files. The css here is separated by files for the appropriate matching html templates.
This PR depends on #14. Therefore, the files that are relevant for this PR review are mainly the files under  sellotape/sellotape_dj/main_app:

static folder (css files)
templates folder (html files)
views.py, urls.py
Other files within this directory are Django generated untouched files.

In addition, modifications (to review as well) were made to settings.py and urls.py under sellotape/sellotape_dj/sellotape_dj to include the new app in this Django project.

@ifireball Pulled from master (it did shrink down). Toda

@alonweissfeld I still see 15 commits - did you rebase? Please try the following:
# Assuming you configured the `upstream` remote to point to the main project repo
# the following will hard-reset your local master to match it
git checkout master
git reset --hard upstream/master
# Now to rebase your feture branch on the master
git checkout landing-page
git rebase master
# in the output of the following command you should only see commits that contain
# changes that are related to the new feature listed between the last commit of the
# master branch and this branch
git log --oneline --decorate
# If all looks well you can force-push the new state to your fork, that will also cause the PR to
# be updated
git push --force origin landing-page

@ifireball Except a few merges during development, all the commits here are part of this PR. I split the work to small commits for readability.
I did try to rebase at first, but since this branch started from a branch that was later reduced - the rebased caused some conflicts which later were mistakenly saved in the editor. So, now, the rebase did clean some merge commits from before - all other 12 commits are part of the PR, and the last commit is for the cleanup (more details are in this last commit)

Ok, if you have a PR with 12 different commits and 17 changed files - you should know its too big already... do reviewers really need to read and understand 12 different steps to realize what you're trying to change and how?
I'm going to review and merge because it seems to be a big blocker for your team, but please improve in the future.

The right way to manage the introduction of auto-generated files to a project is to separate the addition of auto-generated files from manual changes. When you say a PR that everything in it is auto-generated, and clearly indicate it - then it can be reviewed and merged very quickly.
When you put the two together I have to ask myself which things are auto-generated, which did you write, and whihc are auto-generated things that you've later made manual changes to.

@ifireball Got it. I will pay attention to this on the upcoming work. Thank you

authors: alonweissfeld ifireball

repo: beyond-io/sellotape


text:
Add keyboard navigation to the color palette, for accessibility.

Allow tabbing into the color picker, and focus to be set on a
square in the color picker.  Allow using arrow keys to move around
the color palette and set focus.  Allow Enter key to select the
focused color.  This is done with a new keydown handler.
This is needed in order to comply with accessibility requirements.
Note that the color gradient is not yet accessible, just the palette.
https://github.com/bgrins/spectrum/issues/295

Thanks for this.  I've pulled this down and played with it, it's a very good start.  As this kind of navigation gets tricky, I've noticed a couple of issues:

when I click on a swatch, it'd be nice if arrow navigation started working for consistency
when I press enter to select a swatch, it'd be nice if arrow navigation continued to work
when trying to go up/down between nodes within a single row (but that have wrapped visually like in the top colorpicker on http://bgrins.github.io/spectrum/) it doesn't move as I'd expect.  This is probably really hard to get right, since it's not obvious which node is visually below the other - they are all siblings.  The only way I can think of to address this would be to use elementFromPoint to try and find an element if possible, and if not fall back to the current algorithm.  Let me try and put something together with that and respond later.

Here are a couple of other bugs that are maybe not as important in a first version:

when I press escape, I'd like the colorpicker to close (this is an existing general issue in https://github.com/bgrins/spectrum/issues/281, but it'd be great to get it fixed)
when pressing 'left' on the first swatch in a row or 'right' on the last, it'd be nice if it continued wrapping into the previous/next row.

OK, I've updated the https://github.com/bgrins/spectrum/compare/ajssd-master branch to handle the left/right and up/down behavior I was discussing.  Let me know what you think so far.
I'd still like if we could get navigation to work after pressing Enter, and also if it was enabled after clicking on a swatch.  I think we also need to make escape close the picker so people have a way to get out of the picker if they want to use the keyboard to scroll the page, for instance.
We also need some basic test coverage for this in https://github.com/bgrins/spectrum/blob/master/test/tests.js.

I think we also need to make escape close the picker so people have a way to get out of the picker if they want to use the keyboard to scroll the page, for instance.

Just landed ESC closing the picker on master for #281

I added two more minor accessibility-related changes, both aria-labels on user-navigable elements (the initial/current color swatches, and the input field).  An aria-label is read aloud by screen readers but is otherwise not visible; it is required for accessibility when there isn't an explicit label.

I made one additional change -- instead of putting the tabindex on the focused swatch (sp-thumb-el) now the tabindex is on on the palette itself.  This way, we don't have to add and remove tab stops as the user tabs around.  Also, if a color is chosen from the rgb picker on the right, and that color is not in the palette, previously there was no way to regain focus in the palette.  Now it is possible.  Please consider accepting this pull request in order to make Spectrum keyboard-navigable and compliant with Accessibility requirements.

This still needs tests, you can add a new test function at the bottom of https://github.com/bgrins/spectrum/blob/master/test/tests.js and run them locally either by loading the test/index.html page in a browser or by running grunt test after setting it up with: https://github.com/bgrins/spectrum#building-spectrum-locally.
jQuery allows you to create new events to trigger custom key presses like this: http://api.jquery.com/category/events/event-object/

OK I've gone through and made a few notes.  I will still need to apply this locally and do a test, but I think getting basic accessibility in place (once there is some test coverage) will be a great start and we can handle enhancements in follow up work.  Thanks for following up with this!

What's missing in this PR to hit master?
I could help

Nothing that I know of ... we have been pulling from this branch since Sep 1, without issue.  I would recommend Brian fold this into master and release 1.7.1.

Brian, would it be possible to merge these changes into the forthcoming 1.8.0 release?  My team is interested in leveraging Spectrum in our product, however we will most likely be unable to take the dependency until accessibility support has been added.  Thanks!

I'm sorry for dropping this. I've asked @miketoth if he could review the patch and advise if we can land it straight away or if it needs changes.

Thanks bgrins! I should be able to review this tomorrow

Hey guys. I'm fairly new to github branching stuff. Is this accessibility stuff checked into the main branch? E.g. if I get the main branch, it will have accessibility already. If it isn't checked into the main branch, this branch has no conflicts with the main. So I could also use this child branch? Thanks

Downloaded the branch. Would like better keyboard functionality, unless I've missed something. Going to branch this branch.

Hi guys, I appreciate your effort for doing these accessibility updates. I'm interested to use this updated version. Can it be already merged with master?
The thing is I'm managing my project with Composer by using asset-packagist and there is no option to use these specific branches as you can see https://asset-packagist.org/package/npm-asset/spectrum-colorpicker
Thanks for understanding!

@dekisha if they do merge it. I hope they merge the changes on my fork. I did some more accessibility changes. Check my merge request.

authors: NickersWeb SirRidesAlot ajssd bgrins dekisha miketoth p4bl1t0

repo: bgrins/spectrum


text:
netcat dependency

Following up on the issue #562 and changes in https://github.com/galaxyproject/ansible-galaxy-extras/pull/244:
Adding the netcat dependency to the dockerfile + update of the github modules, although this might need to be updated after my PR https://github.com/galaxyproject/ansible-galaxy-extras/pull/244 is merged.

A container based on those changes can be found here: https://github.com/bedroesb/docker-galaxy-stable

@bedroesb can you apply this to the 20.05 branch, please?

@bedroesb it can be that you need to update the submodules not to track the latest changes in 20.05

Thanks to @jyotipm29 we are back on track :smile:
The new 24.1 image contains a lot of changes and reflects the latest developments in Galaxy. I would like to close this PR, but please feel free to reopen and rebase against the latest version.
Please give it a try:
docker run -p 8080:80 -p 8021:21 -p 4002:4002 --privileged=true -e "GALAXY_DESTINATIONS_DEFAULT=slurm_cluster_docker"   -v /tmp/galaxy-data/:/export/ quay.io/bgruening/galaxy:24.1

... or any other combination. The readme has been updated. Please add any useful tip to it.
For a list of changes, see the Changelog.

authors: bedroesb bgruening

repo: bgruening/docker-galaxy


text:
Fix startup.sh for Galaxy's running with UID 1450.

This is needed because of 75e2620 and #35 right?

@jmchilton yes it is! I hope you did not spend to much time on this bug.
We fixed it already in https://github.com/bgruening/docker-ipython-notebook/tree/15.05
How can I keep to branches in sync? master and 15.05 in this case :(
Big sorry.

Uhhh now that I've woken up and y'all merged this...this worries me, https://github.com/bgruening/docker-ipython-notebook/commit/b789503efcf4ed410a68fd7a710c947e11d1b549 too.
I'm looking at that file and maybe someone can re-assure me, but it feels like it will fail in a couple ways:

if the user's id is NOT 1450, we assume they have permissions to create groups. That's a root only permission, so I'm guessing that's going to fail in unpleasant ways if UID or GID is not 0.
both of you applied the same changes, so I'm guessing that it does something correctly, but as I see it... in the case UID=1450, GID=1000 we fail the first part of the conditional, and reach the second where we su as IPython. I don't remember su playing nicely with non-interactive sessions, and I don't remember it being available to non-root users.

@bgruening (not a list of complaints, promise, your work is all awesome, just some thoughts for us):

in the future you might've rejected this PR and just opened up a PR from 15.05 to master. By merging this, we'll get merge conflicts that'll have to be manually resolved later.
we might want to switch to http://nvie.com/img/git-model@2x.png fully, i.e. work completely on dev and merge from dev to release_15.0X whenever we need.

@erasche I guess this goes back to my confusion on the -u comment on the RStudio container also.  The IPython container needs to run as root now (and is configured to). The $uid here isn't the current container's UID (which is always and must be 0) - it is the target UID. So I think it is safe to assume it can create groups.

Aha. That makes a lot more sense. Sorry, early morning brain for getting to me.
Since IPython now requires -u, then it's not a problem that you remove the RStudio snippet which automatically removed it in the command. That should be perfectly fine. No extra docs needed.

@erasche ok let's develop only on :dev from now on. Are your other questions resolved with John's answer?

Yep! We're all good! :)

authors: bgruening erasche jmchilton

repo: bgruening/docker-ipython-notebook