text:
support react-native 0.60+ auto link?

now react-native version has been 0.60.4, and it needs autolink

@vinurs what is the error you are seeing?

error React Native CLI uses autolinking for native dependencies, but the following modules are linked manually:

@react-native-community/picker (to unlink run: "react-native unlink @react-native-community/picker")
This is likely happening when upgrading React Native from below 0.60 to 0.60 or above. Going forward, you can unlink this dependency via "react-native unlink " and it will be included in your app automatically. If a library isn't compatible with autolinking, disregard this message and notify the library maintainers.
Read more about autolinking: https://github.com/react-native-community/cli/blob/master/docs/autolinking.md

@vinurs did you try unlinking and the error is still there?

@bartolkaruza i tried in 0.60.4 again, and without do react-native link, it works well, so the document need update? when u use 0.60+ u needn't do
react-native link @react-native-community/picker

I found [!] No podspec found for 'react-native-picker' in '../node_modules/@react-native-community/picker' when doing pod install
Then I changed the name of react-native-camera.podspec to react-native-picker.podspec
and added a homepage to package.json,  it work

But it shows duplicate symbol
duplicate symbol _OBJC_IVAR_$_RCTPicker._selectedIndex in:
    /ios/build/PROJECT/Build/Products/Debug-iphonesimulator/React-Core/libReact-Core.a(RCTPicker.o)
    /ios/build/PROJECT/Build/Products/Debug-iphonesimulator/react-native-picker/libreact-native-picker.a(RCTPicker.o)

Closing as it's fixed, If you are facing issues feel free to comment

the README should be updated to reflect that running react-native link is not necessary anymore for RN 0.60+

authors: bartolkaruza chakrihacker dg92 fattomhk schumannd vinurs


text:
Getting error "Response =  {error: "Couldn't get file path for photo"}"

Description
I have used a library named 'react-native-mauron85-background-geolocation' along with 'react-native-image-picker' in my app, when I add 'react-native-mauron85-background-geolocation'  dependencies and link it my camera doesn't open when i click 'take photo' button and gives an error 'Response =  {error: "Couldn't get file path for photo"}' in log but gallery is opening successfully, and when I remove all dependencies of  'react-native-mauron85-background-geolocation' then everything works fine.
How to repeat issue and example
My code is :
export default class App extends React.Component {
state = {
avatarSource: null,
videoSource: null
};
selectPhotoTapped() {
quality: 1.0,
maxWidth: 500,
maxHeight: 500,
storageOptions: {
skipBackup: true
}
};
ImagePicker.showImagePicker(options, (response) => {
  console.log('Response = ', response);

  if (response.didCancel) {
    console.log('User cancelled photo picker');
  }
  else if (response.error) {
    console.log('ImagePicker Error: ', response.error);
  }
  else if (response.customButton) {
    console.log('User tapped custom button: ', response.customButton);
  }
  else {
    let source = { uri: response.uri };

    // You can also display the image using data:
    // let source = { uri: 'data:image/jpeg;base64,' + response.data };

    this.setState({
      avatarSource: source
    });
  }
});

}
selectVideoTapped() {
const options = {
title: 'Video Picker',
takePhotoButtonTitle: 'Take Video...',
mediaType: 'video',
videoQuality: 'medium'
};
ImagePicker.showImagePicker(options, (response) => {
  console.log('Response = ', response);

  if (response.didCancel) {
    console.log('User cancelled video picker');
  }
  else if (response.error) {
    console.log('ImagePicker Error: ', response.error);
  }
  else if (response.customButton) {
    console.log('User tapped custom button: ', response.customButton);
  }
  else {
    this.setState({
      videoSource: response.uri
    });
  }
});

}
render() {
return (

<View style={[styles.avatar, styles.avatarContainer, {marginBottom: 20}]}>
{ this.state.avatarSource === null ? Select a Photo :

}

    <TouchableOpacity onPress={this.selectVideoTapped.bind(this)}>
      <View style={[styles.avatar, styles.avatarContainer]}>
        <Text>Select a Video</Text>
      </View>
    </TouchableOpacity>

    { this.state.videoSource &&
      <Text style={{margin: 8, textAlign: 'center'}}>{this.state.videoSource}</Text>
    }
  </View>
);

}
}
Link to library of react-native-mauron85-background-geolocation: https://github.com/mauron85/react-native-background-geolocation#http-locations-posting
Solution
I want to link both the libraries successfully without an issue
Additional Information

React Native version: [0.56.0]
Platform: [Android]
Development Operating System: [MacOs]
Dev tools: [Android SDK version : 27] navigation crash for Android

did u found any solution i get same issue ?

@kapil708 : Yeah I made it work, I changed the buildToolsVersion to 27.0.3 and supportLibVersion to 27.1.0 and added the latest version of both the plugins/libraries and it is working now.  My build.gradle now is:
ext {
buildToolsVersion = "27.0.3"
minSdkVersion = 16
compileSdkVersion = 26
targetSdkVersion = 26
supportLibVersion = "27.1.0"
googlePlayServicesVersion = "11.8.0"
androidMapsUtilsVersion = "0.5+"
gradle3EXPERIMENTAL = "yes"
oreoEXPERIMENTAL = "yes"
}
Tell me if it works....:)

not working.
i do all things

clear project
npm install
uninstall & install

it give same error.
did there any steps to set this.

still not working

Can u give the following information:
Error, android version of testing device, your react-native version
also test it in a real device
and if all doesn't work start a new project with all latest version of react-native and latest version of both the libraries/plugins and use code of image picker example:
https://github.com/react-community/react-native-image-picker/tree/master/Example
and for background-geolocation just link the library using react-native link
(I also did the same and after adding both, my camera wasn't opening when I clicked on 'Select a photo' but it camera was opening when I clicked 'Select a video' camera was opening)

any other image picker to use

Yes there are but they are a bit more complicated and have more issues, this is the most stable one....You can try https://github.com/ivpusic/react-native-image-crop-picker, but I recommend you to try above method and any other possible way to make it work

don't know k=how to solve this issue i am stuck from 2 days in it

give me your email id so i will send you my source code if you can give some help.

Anyone able to solve this issue?

I had the same issue, if you're project already has filepaths.xml under app/res/xml like mine does (which was added as part of react-native-share) you need to add the following path config (taken from this PR https://github.com/react-community/react-native-image-picker/pull/951/commits/307a278f8cdd287e50015a8a252e74ad93b5ac76)
<?xml version="1.0" encoding="utf-8"?>
<paths xmlns:android="http://schemas.android.com/apk/res/android">
    <...any existing config...>
    <files-path name="shared" path="."/>
    <external-path name="shared" path="."/>
    <external-files-path name="shared" path="."/>
    <root-path name="root" path="."/>
</paths>

@brycepavey thx
It worked

@brycepavey I was wondering how the feature got broken in my app. thanks so much for the solution.

@brycepavey works beautifully 😄

@jose2007kj , You can get file path using response.uri

As @AmrAlmagic points out in his comment, this is actually a permission issue. No need to add extra stuff in the native android files.
All you need is to request and get CAMERA and WRITE_EXTERNAL_STORAGE permissions before calling launchCamera:
const getImageFromCamera = async () => {
  if (Platform.OS === 'android') {
    try {
      await PermissionsAndroid.requestMultiple([
        PermissionsAndroid.PERMISSIONS.CAMERA,
        PermissionsAndroid.PERMISSIONS.WRITE_EXTERNAL_STORAGE,
      ])

      const permissionCamera = await PermissionsAndroid.check('android.permission.CAMERA')
      const permissionWriteStorage = await PermissionsAndroid.check('android.permission.WRITE_EXTERNAL_STORAGE')

      if (!permissionCamera || !permissionWriteStorage) {
        return {
          error: 'Failed to get the required permissions.'
        }
      }
    } catch (error) {
      return {
        error: 'Failed to get the required permissions.'
      }
    }
  }
  return ImagePicker.launchCamera(options, response => response)
}

I found this problem too on android 10 this is my setting i used
"react-native-image-picker": "^2.3.1",
ImagePicker.showImagePicker(
{
title: 'Choose Image',
maxWidth: 1000,
maxHeight: 1000,
quality: 0.7,
mediaType: 'photo',
storageOptions: {
skipBackup: true,
path: 'Pictures/myAppPicture/', //-->this is neccesary
privateDirectory: true
}
        },
        response => {
            console.log(response);

        },
    );

also adding
filpaths.xml like someone told above
BUT I still have problem when open androi gallery because it access denied, althought I I have add permission to read file on manifest.xml
thanks I hope it help

I had the same issue, if you're project already has filepaths.xml under app/res/xml like mine does (which was added as part of react-native-share) you need to add the following path config (taken from this PR 307a278)
<?xml version="1.0" encoding="utf-8"?>
<paths xmlns:android="http://schemas.android.com/apk/res/android">
    <...any existing config...>
    <files-path name="shared" path="."/>
    <external-path name="shared" path="."/>
    <external-files-path name="shared" path="."/>
    <root-path name="root" path="."/>
</paths>

external

i don't have any file like this

it not working with android 10 :(( help me

For now passing following storage option, seemed to have fixed launchCamera on Android 10 for me.
{ storageOptions: { privateDirectory: true } }
In my case private directory serves the purpose.
build.gradle settings:
ext {         buildToolsVersion = "29.0.2"         minSdkVersion = 17         compileSdkVersion = 29         targetSdkVersion = 29         supportLibVersion = "28.0.0"         renderscriptVersion = 21     }
Lib Version:
"react-native-image-picker": "2.3.1"

For now passing following storage option, seemed to have fixed launchCamera on Android 10 for me.
{ storageOptions: { privateDirectory: true } }
In my case private directory serves the purpose.
build.gradle settings:
ext { buildToolsVersion = "29.0.2" minSdkVersion = 17 compileSdkVersion = 29 targetSdkVersion = 29 supportLibVersion = "28.0.0" renderscriptVersion = 21 }
Lib Version:
"react-native-image-picker": "2.3.1"

it worked for me on android 10
after  add  "{ storageOptions: { privateDirectory: true } }", I can open camera ,but i can't choose photo from gallery

For now passing following storage option, seemed to have fixed launchCamera on Android 10 for me.
{ storageOptions: { privateDirectory: true } }
In my case private directory serves the purpose.
build.gradle settings:
ext { buildToolsVersion = "29.0.2" minSdkVersion = 17 compileSdkVersion = 29 targetSdkVersion = 29 supportLibVersion = "28.0.0" renderscriptVersion = 21 }
Lib Version:
"react-native-image-picker": "2.3.1"

it worked for me on android 10
after add "{ storageOptions: { privateDirectory: true } }", I can open camera ,but i can't choose photo from gallery

I can access photo in gallery now, this is solution
add  android:requestLegacyExternalStorage="true" to my <application ... > tag in AndroidManifest.xml.

For now passing following storage option, seemed to have fixed launchCamera on Android 10 for me.
{ storageOptions: { privateDirectory: true } }
In my case private directory serves the purpose.
build.gradle settings:
ext { buildToolsVersion = "29.0.2" minSdkVersion = 17 compileSdkVersion = 29 targetSdkVersion = 29 supportLibVersion = "28.0.0" renderscriptVersion = 21 }
Lib Version:
"react-native-image-picker": "2.3.1"

it worked, thank you so much, i love you

For now passing following storage option, seemed to have fixed launchCamera on Android 10 for me.
{ storageOptions: { privateDirectory: true } }
In my case private directory serves the purpose.
build.gradle settings:
ext { buildToolsVersion = "29.0.2" minSdkVersion = 17 compileSdkVersion = 29 targetSdkVersion = 29 supportLibVersion = "28.0.0" renderscriptVersion = 21 }
Lib Version:
"react-native-image-picker": "2.3.1"

it worked for me on android 10
after add "{ storageOptions: { privateDirectory: true } }", I can open camera ,but i can't choose photo from gallery

I can access photo in gallery now, this is solution
add android:requestLegacyExternalStorage="true" to my <application ... > tag in AndroidManifest.xml.

Seems like a solution, but in my case If Camera & External Permissions were granted, I'd no issue
PermissionsAndroid.PERMISSIONS.CAMERA
PermissionsAndroid.PERMISSIONS.WRITE_EXTERNAL_STORAGE (were asked)
You might try with asking for these permissions first and then go on with the library functions. Hope this works as well.

For now passing following storage option, seemed to have fixed launchCamera on Android 10 for me.
{ storageOptions: { privateDirectory: true } }
In my case private directory serves the purpose.
build.gradle settings:
ext { buildToolsVersion = "29.0.2" minSdkVersion = 17 compileSdkVersion = 29 targetSdkVersion = 29 supportLibVersion = "28.0.0" renderscriptVersion = 21 }
Lib Version:
"react-native-image-picker": "2.3.1"

it worked, thank you so much, i love you

Pleasure and no problem, love you too !!!

android:requestLegacyExternalStorage="true"

This was helpful.  I appreciate

I had the same issue, if you're project already has filepaths.xml under app/res/xml like mine does (which was added as part of react-native-share) you need to add the following path config (taken from this PR 307a278)
<?xml version="1.0" encoding="utf-8"?>
<paths xmlns:android="http://schemas.android.com/apk/res/android">
    <...any existing config...>
    <files-path name="shared" path="."/>
    <external-path name="shared" path="."/>
    <external-files-path name="shared" path="."/>
    <root-path name="root" path="."/>
</paths>

pls include this line also in your AndroidMenifest.xml

solved joiining @muhammadaqibkhan and @shixiaoquan answers. ty

For now passing following storage option, seemed to have fixed launchCamera on Android 10 for me.
{ storageOptions: { privateDirectory: true } }
In my case private directory serves the purpose.
build.gradle settings:
ext { buildToolsVersion = "29.0.2" minSdkVersion = 17 compileSdkVersion = 29 targetSdkVersion = 29 supportLibVersion = "28.0.0" renderscriptVersion = 21 }
Lib Version:
"react-native-image-picker": "2.3.1"

It works!! Thank you.

`const takeImageHandler = () => {
const options = {
title: 'Select Image',
storageOptions: {
privateDirectory: true,
skipBackup: true,
// path: 'Image_test_',
},
};
ImagePicker.launchCamera(options, (res) => {
  console.log('Response ===>', res);
  if (res.didCancel) {
    console.log('User cancelled image picker');
  } else if (res.error) {
    console.log('Image Picker Error: ', res.error);
  } else {
    console.log('response', JSON.stringify(res));
    let source = {uri: res.uri};
    console.log(source);
    // setPickedImage(image.source);
    setPickedImage({
      image: {source},
    });
    // props.onImageTaken(image.uri);
  }
});

};`
Lib Version: react-native-image-picker: '2.3.4'
It does working! Thanks

For now passing following storage option, seemed to have fixed launchCamera on Android 10 for me.
{ storageOptions: { privateDirectory: true } }
In my case private directory serves the purpose.
build.gradle settings:
ext { buildToolsVersion = "29.0.2" minSdkVersion = 17 compileSdkVersion = 29 targetSdkVersion = 29 supportLibVersion = "28.0.0" renderscriptVersion = 21 }
Lib Version:
"react-native-image-picker": "2.3.1"

For now passing following storage option, seemed to have fixed launchCamera on Android 10 for me.
{ storageOptions: { privateDirectory: true } }
In my case private directory serves the purpose.
build.gradle settings:
ext { buildToolsVersion = "29.0.2" minSdkVersion = 17 compileSdkVersion = 29 targetSdkVersion = 29 supportLibVersion = "28.0.0" renderscriptVersion = 21 }
Lib Version:
"react-native-image-picker": "2.3.1"

It's so good. Thank you very much!

but if I choose a video from the gallery to upload in android ,its getting me a relative path of the video which is not uploading, this is only happening in android ,in iOS its giving me the absolute path

but if I choose a video from the gallery to upload in android ,its getting me a relative path of the video which is not uploading, this is only happening in android ,in iOS its giving me the absolute path ,please help

any solution bro ?

source: gharchive/issue

license: MIT

license_type: permissive

license_source: github-api


text:
Show button on Map

Guys, I have used 'MapView' and I need to use button on Map to implement some functionality. So how can I place button on Map ? Help needed

Have Marker onPress if the button is location specific or place a button over the map as if it was another view (absolute positioning)

I tried by placing button on Map but it's giving me errors. Can post the example if you have.

Any one to help?

@SirPhemmiey @ShaikhKabeer this does the trick: SO answer
<View style={{ flex: 1 }}>
    <MapView
      style={{ flex: 1 }}
    />
    <View
        style={{
            position: 'absolute',//use absolute position to show button on top of the map
            top: '50%', //for center align
            alignSelf: 'flex-end' //for align to right
        }}
    >
        <Button />
    </View>
</View>

@SirPhemmiey @ShaikhKabeer this does the trick: SO answer
<View style={{ flex: 1 }}>
    <MapView
      style={{ flex: 1 }}
    />
    <View
        style={{
            position: 'absolute',//use absolute position to show button on top of the map
            top: '50%', //for center align
            alignSelf: 'flex-end' //for align to right
        }}
    >
        <Button />
    </View>
</View>

Thanks, I managed to get the button on top of the map, but it is not clickable. What could be the issue?

authors: ShaikhKabeer SirPhemmiey alvelig amsimoes wecoon

repo: react-native-maps/react-native-maps


text:
(Expo) Ram memory increased after reload metro

Summary
The ram is significantly increased when I reload the expo app, I dont know reason. I think the mapview doesnt unmount after refreshed.
Reproducible sample code

First, the ram is 300MB

After I reload the metro, the ram is increased to 400MB

Steps to reproduce
Reload the map on expo app
Expected result
Ram is same
Actual result
Ram is increased
React Native Maps Version
1.0.2
What platforms are you seeing the problem on?
iOS (Apple Maps)
React Native Version
0.68.2
What version of Expo are you using?
SDK 45
Device(s)
iPhone 11 Pro simulator
Additional information

What does "reload" mean in this context? Are you hot reloading from JS. Are you conditionally rendering the component? Are you navigation back and forth in your react-navigation navigators? :)
Your reproducible sample code doesn't contain anything regarding "reloading", so any change you could provide a specific code snippet or snack reproducing the issue? Also, how are you tracking the ram usage? :)

Sure man. The app is hot reloading from JS. I track the ram with perofrmance monitor. I toggle reload via expo cli each time, the number of ram is increased.

What does "reload" mean in this context? Are you hot reloading from JS. Are you conditionally rendering the component? Are you navigation back and forth in your react-navigation navigators? :)
Your reproducible sample code doesn't contain anything regarding "reloading", so any change you could provide a specific code snippet or snack reproducing the issue? Also, how are you tracking the ram usage? :)

I updated the reproduce, how could I solve this issue?

Unfortunately I'm unable to reproduce this - tried with both the react-native-maps that expo installs and with the latest version. Ram usage stays at ~220mb even after multiple reloads done as you described.
Are you reproducing this in a clean project?

I didn't since your reproducible sample code indicated that the issue is reproducible in a clean project.

@1997roylee @Simon-TechForm  I am facing same issue in stack navigator once i enter the stack with only map view the memory increase when i go out and come back again it increases more as well.
there is an issue for sure with stack navigator

am using "react-native-maps": "^1.3.1", and  "react-native-screens": "3.13.1",  "@react-navigation/bottom-tabs": "^6.3.1", "@react-navigation/native": "^6.0.10", "@react-navigation/native-stack": "^6.6.1",
am not using expo

why was this closed 🤔

authors: 1997roylee FadiAboMsalam Simon-TechForm


text:
Cannot read property 'configureProps' of null

Current behaviour
When "import { createBottomTabNavigator } from 'react-navigation-tabs';
", error occured.
What have you tried
I do as https://reactnavigation.org/docs/en/getting-started.html, but it doesn't work.
Your Environment

software
version

android
8.1.0

react-native
0.60.6

react-navigation-tabs
2.5.5

react-native-gesture-handler
1.4.1

react-native-reanimated
1.3.0

node
12.10.0

yarn
1.17.3

Probably you have not installed peer deps (RN Reanimated)

In android my case I just got an error with install and link. If you sync later, it will be solved.

authors: kojongDev osdnk zhnd

repo: react-navigation/tabs


text:
Add fourth level of power set permutations

Hi @simmerer ! 👋
I guess 3 is not enough, so I added a 4th level of power set permutations.
gzipped size increase: 280 bytes
execution time: 1ms (6x CPU throttle on MacBook Pro 2016)
This will not run on very many class combinations, but interpolation punctuation is an example of one:
https://github.com/PrismJS/prism-themes/pull/108

looks good, thanks for fixing!

Glad to help, thanks for the merge! I guess this will be in 15.3.1?

✅  https://github.com/react-syntax-highlighter/react-syntax-highlighter/releases/tag/v15.3.1

source: gharchive/pull-request

authors: conorhastings karlhorky simmerer


text:
Compiled CSS Organization

I've noticed that the way the compiled CSS works is from bottom to top. Meaning that any custom styles I add on my app are compiled first, thus appear first on my final CSS, where as if I include commons.scss at the root of my document, the final CSS version has those styles right at the end of my CSS.
I think the compiled CSS should have the inverse order for this. We are basically having ~normalize be the last section of our compiled CSS, which doesnt make any sense.
Is there a way to modify this behaviour ?
I noticed this issue because I was trying to create some kind of overwrites file, with a few minor resets of my own. But I was unable to make it work normally because normalize is the last part of my CSS and it trumps whichever styles I created ( unless i used specificity ).

Hi @coljung!
I guess it all depends on your build tool. You can always boost a little of priority just assigning a class on top of your customized component.
Also I think there is no way to control this from the library but normalize being added at the bottom is definitively an issue. I've tried some different configurations in webpack and what you require first gets bundled first but probably there is no guarantee on that.
Let's keep this open a bit in case somebody figured out a way to set up the order :)

Thanks for the reply.
What i did in order to have a global overwrites file was:
On my entry point to the App, where we import react-toolbox/lib/commons.scss i added:
import 'react-toolbox/lib/commons.scss';
require('./styles/overwrites.scss');

This then fixes my problem with having a global overwrites rewritten by normalize.
Now, the problem persists where common.scss ( and my overwrites file ) are compiled AFTER the rest of the CSS of my application.

Yeah exactly, that makes sense. I guess that you are doing both imports at the top of your app and then requiring App.js later? If that's the case if should work the same

Please @coljung try out this:
https://twitter.com/javivelasco/status/810763888690163712
This plus react-toolbox@2.0.0-beta.4 should solve the issues

Great, thanks again!

authors: coljung javivelasco

repo: react-toolbox/react-toolbox

license: mit

license_source: bigquery


text:
!tck - clarifies error publisher, and method name change (?)

add better readme on what this method is
add better javadoc on this method

removes reference to old style spec annotation from readme

proposing to change method name to "createFailed..." as it is the wording used in the spec and reactive manifesto (footnote 1.1)

Resolves #237, #235

@reactive-streams/contributors Opinions on this one? Will merge on Mar 20 unless objections are raised.

:+1: LGTM

Addressed comments, good to merge from my side - unless anyone has more comments :)

@reactive-streams/contributors Please comment if you object since it is a backwards incompatible change in the TCK (method name change). Merging this on the 18th of March in case there are no objections. Thank you!

I'm okay with changes to the TCK.

authors: benjchristensen ktoso rkuhn viktorklang

repo: reactive-streams/reactive-streams-jvm


text:
could kubegres made upgrade major posgresql version without downtime?

Hello guys, thanks for your great work ;) kubegres look like simple operator which cover most of my use cases, but
could kubegres made upgrade major posgresql version without downtime?
will you run pg_upgrade if I will change PostgreSQL image in custom resource to v14?

Thank you so much for your kind feedback. Excellent suggestion. I am going to add it to our backlog now.
Currently, Kubegres allows upgrading the versions of a Postgres container without any specific logics meaning it deleguates to that to postgres container .
Postgresql guarantees compatibilities between minor versions upgrade (e.g. 13.1 to 13.3) and consequently it's working fine with Kubegres.
However, as you rightly suggested, if there is an attempt to upgrade a Postgres container with a major version (e.g. from version 12 to 13), PostgreSql will not allow it.
We will add a logic to run the "pg_upgrade" command as you mentioned.
I am going to use this ticket as a feature enhancement.
Thank you!

authors: Slach alex-arica

repo: reactive-tech/kubegres


text:
Use podcast meta data to make podcast header

@cilice said we can use the podcast meta data to show the podcast name and artwork at the top of the reviews. @ollicle do you want to make an attempt at designing it?

We could add the link for adding reviews into the header as well from ticket: https://github.com/reactivepod/fido-web/issues/3

repo: reactivepod/fido-web


text:
How to use renderToNodeStream?

I'm using these library versions:

ReactJS.NET: 3.1.0
JavaScriptEngineSwitcher: 2.4.9

When we run a Lighthouse audit on our production website, one the the suggestions is to use renderToNodeStream() or renderToStaticNodeStream():

I checked the docs at https://reactjs.net/docs, and searched issues on GitHub but could not find any reference to how this Lighthouse suggestion may be implemented. Is this supported by ReactJS.NET?

Gentle bump.

No it’s not supported at this time.
On Sun, May 17, 2020 at 01:16, Anurag Bhandari notifications@github.com
wrote:

Gentle bump.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/reactjs/React.NET/issues/1105#issuecomment-629760464,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAHGCFS7RBXNQYU2OV3F3YTRR6MMLANCNFSM4M3BIBKQ
.

Thanks for clarifying that, @dustinsoftware.

authors: anuragbhd dustinsoftware


text:
번역 합의가 도출되기 전인 단어들의 통일된 임시 표기법

Translate Glossary 작성된 시점이 오래되었고 그에 따른 번역은 잘 이루어졌지만 그 이후 새로운 개념들이 들어왔고 (Suspense, Hydration 등) 그에 맞춘 새로운 번역어 합의가 제대로 이루어 지지 않음

생명주기(Lifecycle) / Lifecycle(생명주기) / Lifecycle(생명주기, 임시표기)

와 같은 형태로 https://github.com/reactjs/ko.reactjs.org/issues/2 에서 번역 합의가 도출되기 전인 단어들의 통일된 임시 표기법을 정해 놓으면 이후 번역 속도 및 유지 관리 측면에서 좋을 것 같음
참고
https://github.com/reactjs/ko.reactjs.org/issues/555#issuecomment-1427024229
@SyingSHY

@goofcode 요거 제가 언제 이슈를 만들어 놨었네요 .
여기서 하시면 될것 같군요

https://github.com/reactjs/ko.react.dev/pull/599
하면서 추가할만한것들이 보입니다. 여기서 이어서 이야기해보면 좋을것 같네요

API reference -> API 참고서
user interfaces -> 사용자 인터페이스
markup -> 마크업
interactivity -> 상호작용
architecture -> 아키텍처
full-stack -> full-stack (번역하지 않음)

일단 제가 했을때에 애매한 단어들은 위와 같았고 일단 위의 PR 에서는 위에 보이는것처럼 번역했습니다.
추가 의견 있으시면 부탁드립니다.
@hg-pyun @taggon @MaxKim-J

API reference -> API 레퍼런스
user interfaces -> 사용자 인터페이스
markup -> 마크업
interactivity -> 상호작용
architecture -> 아키텍처
full-stack -> full-stack (번역하지 않음)

기술용어나 라이브러리에서 사용되는 키워드들은 원문그대로, 우리말로 번역때 더 자연스러운것들은 번역하고, 그렇지 않은것들은 음역을하면 어떨까요?

넵 큰 이견 없습니다.
저것만 https://github.com/reactjs/ko.react.dev/wiki/Translate-Glossary 요기에 추가하면 될것 같네요

@eomttt https://github.com/reactjs/ko.react.dev/wiki/Translate-Glossary 에 추가했습니다. 확인후 이슈 클로즈 부탁드릴게요!

authors: eomttt gnujoow


text:
How to render something outside ReactModal__Content but within ReactModal__Overlay

I am using 3.11.1
Our UI requirements, is the close button of a modal is not inside the modal, but at the top-right corner of the screen.
I tried position: absolute and fixed, works on everything but some mobile Safari, it just won't show it at all, the only way is to lift the button outside the ReactModal__Content div
Anyway to render something outside the ReactModal__Content

you can try this:
<ReactModal isOpen>
    X

your content

</ReactModal>

Thanks, tried, but some iOS safari will hate this, I think Apple honors HTML structure more than position: fixed, as long as it is inside, it won't render it outside.

you are right, but try with overflow: 'none' for content styles
<ReactModal isOpen
    style={{
        content: {
            overflow: 'none'
        }
    }}
>
    X

your content

</ReactModal>

this worked for me

I would really like a way to do this without having to resort to fixed positioning. I would like to use non-fixed position for the elements inside my overlay:

close button
previous page button
next page button
modal content

Actually, tried fixed, as I mentioned when posted, but some version of safari does not like it, absolute is better but still has its incompatibility with some devices, will just use absolute for now. A fully control of the content would be better. Otherwise, it will have this constraint of having everything inside a box.

You can always use display: contents (At least for newer-ish browsers)
https://caniuse.com/#feat=css-display-contents
const customStyles = {
  content: {
    display: "contents",
    borderWidth: 0,
    padding: 0,
    margin: 0
  }
};

(.....)

const MyModal = () => (
	<Modal style={customStyles}>
		<TheActualContentComponent />
	</Modal>
)

You can work around this by grabbing a ref to the overlay and rendering your content there with a portal. Incomplete example:
const MyModal: React.FC = () => {
  const [overlayDiv, setOverlayDiv] = useState<HTMLDivElement | null>(null);

  return (
    <ReactModal overlayRef={setOverlayDiv}>
      {overlayDiv &&
        ReactDOM.createPortal(
          <button onClick={/* handle the close button click */} />,
          overlayDiv
        )}
    </ReactModal>
  );
};

Sorry for bumping an old thread, but in case anyone was trying to figure it out: I think you can do this now using the custom overlayElement prop.
An example of it is in the tests: https://github.com/reactjs/react-modal/blob/827796d48e7d4c74b4362cf90955e162082ee46d/specs/Modal.spec.js#L309-L321
// Custom overlay element to hold the close button outside of the actual modal
  const OverlayElement = (
    props: JSX.IntrinsicAttributes &
      ClassAttributes<HTMLDivElement> &
      HTMLAttributes<HTMLDivElement>,
    contentElement:
      | string
      | number
      | boolean
      | ReactElement<any, string | JSXElementConstructor<any>>
      | ReactFragment
      | ReactPortal
      | null
      | undefined
  ) => {
    return (

          <CloseIcon
            onClick={closeModal}
            position="absolute"
            right="20px"
            top="20px" />
        {contentElement}

    );
  };

const MyModal = () => <Modal overlayElement={OverlayElement}>this is my modal!</Modal>

authors: Albert-Gao OliverJAsh fforres fo-fo llorentegerman timngyn

repo: reactjs/react-modal


text:
Get over shallow comparison issues?

I was working on an issue today that I wasn't able to explain in other way than shallow comparison.
Essentially I have a state similar to following:
{
 meta: {},
 contents: [
   { content_type: 1, text:"" },
   { content_type: 2, text:"" },
   { content_type: 1, text:"" }
 ]
}

there are many content types, this is just a simple example. What I am doing is re ordering these in state to cause re ordering on ui side, ie I can move first object from contents array down or second one up just fine, but when it comes to re ordering 2 object with same content type, it successfully updates the redux state, however react doesn't re-render the ui, and I came to conclusion that this could be caused by shallow comparison, as objects that switched places are very very similar, only their text fields are different.
I am looking for a way to work around this.
following is how I update my redux state:
...
case STORY_ACTIONS.UPDATE_STORY_CONTENTS:
      return { ...state, contents: action.payload }
...

where action.payload is correctly re-ordered contents array, I don't think this is an issue, as it does update redux state correctly.

Update: I started adding random number field as additional parameter so:
{ content_type: 1, text:"", order: random_number }
Still no luck, so I am not so sure now if it is due to shallow comparising, hence am open for suggestions to what can be causing this.

Can you show the component code?

This is a very stripped down version of it, that shows all necessary bits:

// -- Dependencies -------------------------------------------------------------
import React, { Component } from 'react';
import { connect } from 'react-redux';

...

// -- Class --------------------------------------------------------------------
class StoryEditor extends Component {

  //Render story block
  renderStoryContent(content, index, array) {
    switch(content.content_type) {
      // Media block
      case 1:
        return (
          ...
        );
      // Text block
      case 2:
        return (
        ...
        );
      default:
        console.warn("Unable to proccess following content ", content);
    }
  }

  render() {

    // Handle existing story
    return (

        { this.props.story.contents.map(this.renderStoryContent) }

    );
  }
}

// -- Promote component to container -------------------------------------------
function mapStateToProps(state) {
  return { story: state.story }
}

// -- Export -------------------------------------------------------------------
export default connect(mapStateToProps)(StoryEditor);

Where are the parts that don’t update? Are they in child components? Do those components use local React state?

Alright, sorry for delayed response, but here goes:
The switch statement you can see above within renderStoryContent function is responsible for rendering StoryBlock components that have another blocks inside that are content_type specific, so example of text block (one of which has the issue I am talking about) would look like
case 2:
  return (
     <StoryBlock
            key={index}
            order={index}
            type={CONTENT_TYPES.TEXT}
            title="text">
            <StoryBlockText
              order={index}
              ids={ content.ids ? content.ids : [] }
              content={ content.content_body.text.html ? content.content_body.text.html : ""} />
          </StoryBlock>
             );

And this is how StoryBlock component looks:

// -- Dependencies -------------------------------------------------------------
import React, { Component, PropTypes } from 'react';
import { connect } from 'react-redux';
import { bindActionCreators } from 'redux';

// -- App ----------------------------------------------------------------------
import TextButton from '../App/text-button';
import {
  sortStoryBlockDown,
  sortStoryBlockUp,
  removeStoryBlock,
  duplicateStoryBlock }
from '../../actions/Story/story';

// -- Class --------------------------------------------------------------------
class StoryBlock extends Component {
  constructor(props) {
    super(props);
    this.state = { parentContent: "" };
  }

  componentWillUnmount() {
    this.parentContent = "";
  }

  //Pass child contents to parent
  updateBlockContent(childContent) {
    this.parentContent = childContent;
  }

  //Render
  render() {

    //Create children with props
    var childrenWithProps = React.cloneElement(this.props.children, { updateBlockContent: this.updateBlockContent.bind(this) });

    return (
      <section className={`story-block ${this.props.type}`}>

 {this.props.title}

            <TextButton
              helpers="uppercase"
              onClick={ () => this.props.duplicateStoryBlock(this.props.story, this.props.order, this.props.type, this.parentContent) }>
              Duplicate {}
            </TextButton>
            <TextButton
              helpers="uppercase"
              onClick={ () => this.props.removeStoryBlock(this.props.story, this.props.order, this.props.type) }>
              Remove
            </TextButton>
             this.props.sortStoryBlockDown(this.props.story, this.props.order, this.props.type, this.parentContent) }>

             this.props.sortStoryBlockUp(this.props.story, this.props.order, this.props.type, this.parentContent) }>

          {childrenWithProps}

          Place here

    );
  }
}

// -- Promote component to container -------------------------------------------
function mapStateToProps(state) {
  return { story: state.story }
}

function mapDispatchToProps(dispatch) {
  return bindActionCreators({
    sortStoryBlockDown: sortStoryBlockDown,
    sortStoryBlockUp: sortStoryBlockUp,
    removeStoryBlock: removeStoryBlock,
    duplicateStoryBlock: duplicateStoryBlock
  }, dispatch);
}

// -- Export -------------------------------------------------------------------
export default
  connect(mapStateToProps, mapDispatchToProps)(StoryBlock);

Similarly, if you need it, here is StoryBlockText component (This one uses react-medium-editor plugin, but I don't think it is an issue, as I get similar bug on another component that doesn't require it, however both of these components have elements with contentEditable) :
// -- Dependencies -------------------------------------------------------------
import React, { Component } from 'react';
import ReactDOM from 'react-dom';
import Editor from 'react-medium-editor';

// -- App ----------------------------------------------------------------------
import { updateText } from '../../actions/Story/story-block-text.js';

// -- Helpers ------------------------------------------------------------------
const editorOptions =  {
  placeholder: { text: 'Start typing yo.' },
  anchor: {placeholderText: 'Paste link and press enter.'},
  toolbar: {
    buttons: [
      {name: 'bold', contentDefault: 'Bold'},
      {name: 'italic', contentDefault: 'Italic'},
      {name: 'underline', contentDefault: 'Underline'},
      'h1',
      'h2',
      {name: 'orderedlist', contentDefault: '1. List'},
      {name: 'unorderedlist', contentDefault: '• List'},
      {name: 'anchor', contentDefault: 'Link'}
    ]
  }
}

// -- Class --------------------------------------------------------------------
class StoryBlockText extends Component {
  constructor(props) {
    super(props)
    this.state = {text: this.props.content}
  }

  componentDidMount() {
    this.props.updateBlockContent(this.props.content);
  }

  //Handle on change
  handleOnChange(text, medium) {
    this.setState({text: text});
    this.props.updateBlockContent(this.state.text);
  }

  //Render
  render() {
    return (
      <div className="story-block-text" ref={`textBlock${this.props.order}`}>
        <Editor
          text={ this.state.text }
          onChange={ this.handleOnChange.bind(this) }
          options={ editorOptions } />

    );
  }
}

// -- Promote component to container -------------------------------------------
function mapStateToProps(state) {
  return { story: state.story }
}

function mapDispatchToProps(dispatch) {
  return bindActionCreators({
    updateText: updateText
  }, dispatch);
}

// -- Export -------------------------------------------------------------------
export default StoryBlockText;

By any chance, are you mutating the state to re-order the contents?

@Sunakujira1 I don't think so, you can see from my first comment how my states look and how I update its contents. It works fine in majority of cases as well, only when two neigbour contents with similar type are sorted it doesn't. I'm starting to think that this could be something to do with contentEditable as all elements that have an issue have it within them.

@IljaDaderko Hmm, you are right, state seems fine.
Do you have key specified for each StoryBlock? Seems to be quite important as specified here.
Also, I am not as familiar with this.props.children, but I'm guessing it may be the case that StoryBlockText are not being re-rendered due to the StoryBlock not having any difference in props.

@Sunakujira1 I got it! so I was setting key of each storyBlock to index gathered from map() somehow this led to isues, changing this key to something like uniqe random id I generated for each block helps.

This is why I asked about the local state. If you don’t specify the key, components will receive each other’s props on reorder. Which makes reorder slower but that is not the root of the problem.
The root of the problem is you derive local state from initial props in the constructor. But props may be received by the component more than once. When your components receive new props during reorder, you forget to reset the state to reflect those new values.
To do it, you would need to implement componentWillReceiveProps(nextProps) that calls setState if nextProps.text !== this.props.text. Adding a key also helps but it heals the symptom rather than the actual cause of the problem.

Hi @gaearon , thanks for your answer. I am having a similar problem (check http://stackoverflow.com/questions/39513753/how-can-i-force-re-rendering-when-redux-state-is-changed-but-react-does-not-trig).
As far as I understand, React will re-render a component if nextProps and actual props differ. Why is it then needed to call the componentWillReceiveProps(nextProps) method, should the component do this automatically?
Thanks again!

repo: reactjs/react-redux


text:
Connect swallows errors

TL;DR - the error information forwarded through selector is not sufficient. How can we get the full error?
We are currently testing our app on IE11 and noted a regression that can be traced back to a dependency upgrade.
      Connect.prototype.render = function render() {
        var selector = this.selector;
        selector.shouldComponentUpdate = false;

        if (selector.error) {
          throw selector.error; // error is thrown.
        } else {
          return Object(react__WEBPACK_IMPORTED_MODULE_2__["createElement"])(WrappedComponent, this.addExtraProps(selector.props));
        }
      };

The only error we get is the following

No line number or any additional diagnostic information is passed.
The selector object only has the key error populated with a string that does not give us any additional information.
We were digging for the last few hours with no success, also tried downgrading the react dependencies but were not able to fix it.
We use have the following deps:
    "@types/enzyme": "^3.1.9",
    "@types/enzyme-adapter-react-16": "^1.0.2",
    "@types/isomorphic-fetch": "0.0.34",
    "@types/jest": "^22.2.0",
    "@types/lodash": "^4.14.105",
    "@types/node": "^9.4.7",
    "@types/react": "^16.0.40",
    "@types/react-dom": "^16.0.4",
    "@types/react-loadable": "^5.3.3",
    "@types/react-redux": "^5.0.15",
    "@types/react-test-renderer": "^16.0.1",
    "@types/redux-mock-store": "0.0.13",
    "@types/jsdom": "^11.0.4",
    "@types/react-hot-loader": "^3.0.5",
    "array-find-polyfill": "^0.1.0",
    "autoprefixer": "^8.1.0",
    "awesome-typescript-loader": "^5.0.0-1",
    "copy-webpack-plugin": "^4.5.1",
    "core-js": "^2.5.3",
    "css-loader": "^0.28.11",
    "date-fns": "^1.29.0",
    "enzyme": "^3.3.0",
    "enzyme-adapter-react-16": "^1.1.1",
    "es6-object-assign": "^1.1.0",
    "es6-promise": "^4.2.4",
    "eslint": "^4.18.2",
    "eslint-config-standard-with-typescript": "^4.0.0",
    "eslint-loader": "^2.0.0",
    "eslint-plugin-import": "^2.9.0",
    "eslint-plugin-jest": "^21.15.0",
    "eslint-plugin-node": "^6.0.1",
    "eslint-plugin-promise": "^3.7.0",
    "eslint-plugin-standard": "^3.0.1",
    "eslint-plugin-typescript": "^0.10.0",
    "extract-text-webpack-plugin": "^4.0.0-beta.0",
    "file-loader": "^1.1.11",
    "generate-json-webpack-plugin": "^0.2.2",
    "html-webpack-plugin": "^3.0.6",
    "html-webpack-template": "^6.1.0",
    "identity-obj-proxy": "^3.0.0",
    "idx": "^2.2.0",
    "intersection-observer": "^0.5.0",
    "isomorphic-fetch": "^2.2.1",
    "jest": "^22.4.2",
    "node-sass": "^4.7.2",
    "postcss-loader": "^2.1.1",
    "raf": "^3.4.0",
    "react": "^16.2.0",
    "react-dom": "^16.2.0",
    "react-hot-loader": "^4.0.0",
    "react-intersection-observer": "^3.0.3",
    "react-loadable": "^5.3.1",
    "react-redux": "^5.0.7",
    "react-test-renderer": "^16.2.0",
    "redux": "^3.7.2",
    "redux-mock-store": "^1.5.1",
    "redux-test-utils": "^0.2.2",
    "redux-thunk": "^2.2.0",
    "sass-loader": "^6.0.7",
    "style-loader": "^0.20.3",
    "stylelint": "^9.1.3",
    "stylelint-config-sass-guidelines": "^5.0.0",
    "stylelint-order": "^0.8.1",
    "stylelint-scss": "^2.5.0",
    "stylelint-webpack-plugin": "^0.10.3",
    "ts-jest": "^22.4.1",
    "typescript": "^2.7.2",
    "typescript-eslint-parser": "^14.0.0",
    "typings-for-css-modules-loader": "^1.7.0",
    "webpack": "^4.1.1",
    "webpack-cli": "^2.0.12",
    "webpack-dev-server": "^3.1.1",
    "webpack-merge": "^4.1.2"

Duplicate of #802 .  I'm not sure we have a specific repro or a solution yet.

Are you sure? We are using the regular connect function, not advancedConnect

connect uses connectAdvanced. It's a wrapper for it.

authors: FranzSkuffka markerikson timdorr


text:
Fix hover background color in StrictMode examples

The StoryTray examples in StrictMode.md intend to change the background color on hover.
But it is not working. The reason is that <li> elements are styled with float: left CSS property, which makes the height of the parent <ul> element zero and thus makes the background color invisible.
This PR fixes the problem by adding overflow: auto CSS property to the <ul> element to clear floats, which is well supported by modern browsers.

Before fix
After fix

I just signed CLA.


text:
Improved createRoot() example

Thanks but we don’t plan to be changing the current docs — would you take a look at the version on beta.reactjs.org and whether you’re satisfied with the example there?

It's been 2 hours and the system hasn't detected my CLA yet. Why? This other PR I also made detected my CLA and according to the details of the missing CLA check it should take no more than 1 hour:

@gaearon How do I edit the beta.reactjs.org version? I don't see amy Edit this page button anywhere as most articles do in reactjs.org.

It's on the main branch in the beta folder.

authors: adriancuadrado gaearon


text:
react-redux sample blog

A simple blog written using react and redux (see here). You might consider add it to examples.

Thanks for the link.  Opening this as an issue doesn't really make sense, though, and I don't see us copying the repo contents and adding it to the examples folder.

There is no sense to copy content, you can just add a link.

authors: akornatskyy markerikson

repo: reactjs/redux


text:
Added payload to the request build. This fixes #30.

As of right now, if one passes a payload on a request to react/http, such as the following:
curl -X POST http://<myurl>/ --data "{\"key\": \"value\"}" -H "Content-Type: application/json"

The payload is unreachable within the server. It won't be parsed as a querystring on RequestHeaderParser::parseRequest and will thus be discarded.
This can't happen, and I believe this PR fixes the issue.
It adds a new parameter to the Request constructor ($payload), at the end, with a default value (null), as a way to not break backwards compatibility with classes that may omit this parameter. It also adds a getPayload() method to the request.

Notice this leaves the queryString untouched in a way to allow even for GET requests with both a querystring and a payload. This allows even for some weirder requests, like the second elasticsearch example here.

In fact, as of right now, react/http fails to parse even a regular form submit, if it's done using POST/PUT/DELETE/PATCH.
curl -X POST http://<myurl>/ -d 'var1=value1&var2=value2'

Results in the following:
var_dump($_POST); //This prints: array(0) { }

This fixes #30.

This will only work for non-streamed requests. See this comment for buffering and reading the entire body for non-streamed requests.

Obsolete because of b36fb250ba0db01e8df752be45a1cae3f1f4b39a

authors: cboden naroga

repo: reactphp/http


text:
Any possibility to know if Stream has finished writing?

In Buffer there's event full-drain but it's not proxified on Stream level.

Can you elaborate on your use case for this?
(FWIW: Similar requests have been filed via #16 and #23.)

https://github.com/cursedcoder/eprocess/blob/master/EProcess/Adapter/ChildProcess.php#L70
I'm using this to pass initial php code to interpreter and close this stream so php can execute it.

Sounds like the perfect use case for using end($data) instead of write($data)?
The end() method will close the stream once the last byte has been sent.

Another case when communicating via unix socket data should be sent synchronously and you need full-drain to schedule messages.

I'd like to check this out, can you give a real world example on this use case?

@clue https://github.com/cursedcoder/emessenger/commit/16230158fc7227c618874bc4361b124bb54296a1
There is a red test when I'm trying to communicate more than 1 message at time.

I'm still curious because I've implemented quite a few protocols and have yet to come up with a reason to wait for the outgoing buffer to flush.
I'm not sure I follow this code, but it looks like the write()s may be mixed up (see my comment on your commit).
Can you create a simple gist to exhibit this?

I believe this has been resolved? :shipit:
FWIW, https://github.com/reactphp/stream/pull/16#issuecomment-71862449 also contains a possible workaround to use the full-drain event to check when the outgoing buffer has been flushed.
I'm closing this due to lack of feedback for now, please feel free to report back if this persists and we can reopen this :+1:

authors: clue cursedcoder

repo: reactphp/stream


text:
Annotation delete alert disappearing immediately.

This issue is a Bug
Expected Behaviour
Annotation alert stays on window until clicked.
Observed behaviour
When an annotation browser alert appears it automatically disappears.
Steps to reproduce

Click delete on an existing annotation
Behaviour occurs

Product
Choose one of the following (and delete the others)

Readium cloud reader app

A custom integration
Browser and version: Chrome (recent)
OS and version: WIndows 10

Additional information
See video for behaviour: http://recordit.co/H8N8V7E8Xk
I have localized this issue to being triggered here:

Delete button on Annotation is clicked
readium.reader.on(ReadiumSDK.Events.PAGINATION_CHANGED, function (pageChangeData) function is triggered
savePlace(); is called from page change function
history.replaceState is called which seems to cause the trouble behaviour.

@JCCR have you seen this before?

@coler-j Thanks for the report.  Unfortunately, the ReadiumJS codebase that you are using is part of "Readium-1"  which has recently been moved to "maintenance status".  We will fix crashes or data loss which occur in the master or develop.  But the annotation support has always been an experiment (most folks implemented their own support - and didn't push it back).
We would strongly encourage you to take a look at "Readium-2" which is the main focus.  However, the "Desktop" version (which will support MacOS, Windows and Linux is currently in alpha so if Windows support is critical you may need to stick with your implementation in the short term.

@rkwright that is very interesting. I would have thought I was using the most recent version after having followed the documentation for installation from master branch (within the past 30 days). How is a new developer to the library supposed to known the difference between Readium 1 vs Readium 2, and how do I know what version I am using? This is the first time I am hearing about this (I have also read through many of the open and closed issues over the past few weeks).

authors: coler-j danielweck rkwright

repo: readium/readium-js-viewer


text:
reflowable first page is temporarily shown (flash) when last page is reached from next spine item

To reproduce, open:
https://readium.firebaseapp.com/?epub=https%3A%2F%2Frawgit.com%2Fdbelinson%2FsimpityReader%2FnewOnlyOneBook%2Fapp%2Fsrc%2Fmain%2Fassets%2Fpushkin_.epub&goto={"idref"%3A"bookcontent294_0"%2C"elementCfi"%3A"%2F4%2F2[t_d01471]%2F2%2F2%2C%2F1%3A0%2C%2F1%3A1"}
...and press the "previous page" button (or hit the left arrow key).

I forgot to say: the EPUB is in Cyrillic (I think), but this is probably not the cause of the pagination event "latency".
Source: https://github.com/dbelinson/simpityReader/blob/newOnlyOneBook/app/src/main/assets/pushkin_.epub

I cannot reproduce this on OSX 10.10 in Chrome.  Version 48.0.2564.116 (64-bit)

I am able to reproduce this rendering behaviour on Windows 10 with Chrome (100% repro rate), Firefox (95% repro, estimated :) ), but Edge and Internet Explorer do not seem to exhibit this problem.

Fixed here:
https://github.com/readium/readium-shared-js/commit/3a1709b3507c11be45876ab2c0832b8d1560e3a8

authors: danielweck rkwright

repo: readium/readium-shared-js


text:
Fix canonical URLs with dirhtml builder

As suggested by @ericholscher in #285, using the logic from the
readthedocs-sphinx-ext package.
Currently if you set the canonical_url theme option (for example, to
https://example.com/), a canonical link like the following will be
generated for source files like foo/bar.rst:
<link rel="canonical" href="https://example.com/foo/bar.html"/>

This is good for the html builder, but doesn't match the output of the
dirhtml builder. This commit changes canonical link generation like
the above example to the following when the dirhtml builder is used:
<link rel="canonical" href="https://example.com/foo/bar/"/>

Canonical link generation remains the same as before when the dirhtml
builder is not used.

Thanks for the contribution, this is in sphinx itself now https://www.sphinx-doc.org/en/master/usage/configuration.html#confval-html_baseurl, we should deprecate the canonical_url option in favor of html_baseurl https://github.com/sphinx-doc/sphinx/blob/e886cc21710e23bc53af83d011131828b1020848/sphinx/themes/basic/layout.html#L135-L137

https://github.com/readthedocs/sphinx_rtd_theme/pull/1003

authors: justinludwig stsewd


text:
model inheritance

Допустим есть классы с наследованием
@dataclass
class A:
   a: int

@dataclass
class B(A):
   b: int

Сейчас, если мы хотим сделать предобработку поля a, мы должны сделать две схемы: для класс A и для класса B и в обеих определить pre_parse.
Необходимо продумать как это делать более удобно

This issue is not actual with the new major version

repo: reagento/adaptix


text:
fix parse_func

Fixes https://github.com/reagento/dataclass-rest/issues/44

Let's make new test with type hint as a string

repo: reagento/dataclass-rest


text:
bug: 中英文评论区问题 && 评论通知功能缺失

评论中英文url应对应相同的评论区。
一旦有评论，应直接将该评论作为邮箱内容发送给主人邮箱。

已经修复。

repo: real-jiakai/next-blog


text:
Filter using object property called 'size' results in exception

How frequently does the bug occur?
All the time
Description
Using Filter() with a property name of 'size' causes a crash.
See ViewController below for full example (tested with RealmSwift v10.27.0)
class TestObject: Object {
    @objc dynamic var _id = UUID().uuidString
    @objc dynamic var tstamp: Date = Date()
    @objc dynamic var code: String = ""
    @objc dynamic var name: String = ""

/// The unhappy 'size' property
    @objc dynamic var size: String = ""

    override static func primaryKey() -> String? {
        return "_id"
    }
}

// this work fine
let filtered = realm.objects(TestObject.self).filter("code contains[c] %@", "2")

// The following line throws an exception
// "Predicate expressions must compare a keypath and another keypath or a constant value"
// It seems it does not like using a proper name of 'size'

let filtered = realm.objects(TestObject.self).filter("size contains[c] %@", "2")

// This code works fine

let filtered = objects.filter("%K contains[c] %@", "size", "2")

Stacktrace & log output
"Predicate expressions must compare a keypath and another keypath or a constant value"

Can you reproduce the bug?
Yes, always
Reproduction Steps
//
//  ViewController.swift
//  RealmTest
//
//  Created by Duncan Groenewald on 21/6/2022.
//

import Cocoa
import RealmSwift

class ViewController: NSViewController {

    override func viewDidLoad() {
        super.viewDidLoad()

        // Do any additional setup after loading the view.

        test()
    }

    override var representedObject: Any? {
        didSet {
        // Update the view, if already loaded.
        }
    }

    var realm: Realm? {
        do {
            let realm = try Realm()
            return realm
        } catch {
            return nil
        }
    }

    func test() {

        guard let realm = self.realm else {
            print("Error opening realm")
            return
        }

        let objects = realm.objects

        if objects.isEmpty {
            realm.createObjects()
        }

        let filtered1 = objects.filter("name contains[c] %@", "2")

        for obj in filtered1 {
            print("\(obj.code), \(obj.name), \(obj.size)")
        }

        // The following line will crash with the following error
        // 'Predicate expressions must compare a keypath and another keypath or a constant value'
        // It seems 'size' is not allowed as a property name ??

        let filtered = objects.filter("size contains[c] %@", "2")

        for obj in filtered {
            print("\(obj.code), \(obj.name), \(obj.size)")
        }

    }

}

class TestObject: Object {
    @objc dynamic var _id = UUID().uuidString
    @objc dynamic var tstamp: Date = Date()
    @objc dynamic var code: String = ""
    @objc dynamic var name: String = ""
    @objc dynamic var size: String = ""

    override static func primaryKey() -> String? {
        return "_id"
    }
}

extension Realm {
    var objects: Results<TestObject> {
        self.objects(TestObject.self)
    }
    func createObjects(){

        self.beginWrite()

        for i in 1...100 {
            let obj = TestObject()
            obj.code = "\(i)"
            obj.name = "Name_\(i)"
            obj.size = "Size_\(i)"

            self.add(obj)
        }

        do {
            try self.commitWrite()
        } catch {
            print("Error: \(error.localizedDescription)")
        }
    }

}

Version
RealmSwift v 10.27.0
What SDK flavour are you using?
Local Database only
Are you using encryption?
No, not using encryption
Platform OS and version(s)
macOS 12.4
Build environment
Xcode version: 13.4.1
Dependency manager and version: SPM

Formatted test code
/```
/
//  ViewController.swift
//  RealmTest
//
//  Created by Duncan Groenewald on 21/6/2022.
//
import Cocoa
import RealmSwift
class ViewController: NSViewController {
override func viewDidLoad() {
    super.viewDidLoad()

    // Do any additional setup after loading the view.

    test()
}

override var representedObject: Any? {
    didSet {
    // Update the view, if already loaded.
    }
}

var realm: Realm? {
    do {
        let realm = try Realm()
        return realm
    } catch {
        return nil
    }
}

func test() {

    guard let realm = self.realm else {
        print("Error opening realm")
        return
    }

    let objects = realm.objects

    if objects.isEmpty {
        realm.createObjects()
    }

    let filtered1 = objects.filter("name contains[c] %@", "2")

    for obj in filtered1 {
        print("\(obj.code), \(obj.name), \(obj.size)")
    }

    // The following line will crash with the following error
    // 'Predicate expressions must compare a keypath and another keypath or a constant value'
    // It seems 'size' is not allowed as a property name ??

    let filtered = objects.filter("size contains[c] %@", "2")

    for obj in filtered {
        print("\(obj.code), \(obj.name), \(obj.size)")
    }

}

}
class TestObject: Object {
@objc dynamic var _id = UUID().uuidString
@objc dynamic var tstamp: Date = Date()
@objc dynamic var code: String = ""
@objc dynamic var name: String = ""
@objc dynamic var size: String = ""
override static func primaryKey() -> String? {
    return "_id"
}

}
extension Realm {
var objects: Results {
self.objects(TestObject.self)
}
func createObjects(){
    self.beginWrite()

    for i in 1...100 {
        let obj = TestObject()
        obj.code = "\(i)"
        obj.name = "Name_\(i)"
        obj.size = "Size_\(i)"

        self.add(obj)
    }

    do {
        try self.commitWrite()
    } catch {
        print("Error: \(error.localizedDescription)")
    }
}

}

Hmm - any tips for ensuring correctly formatted source code ??

HI @duncangroenewald we use Apple's framework NSExpression API to determine the expressionType of the NSPredicate, the returned expression type is not been parsed to a key path expression because size is a reserved word in the foundation framework.
You can use instead #size if you want to, or use any of the alternatives you proposed in the post above.
let filtered = realm.objects(TestObject.self).filter("#size contains[c] %@", "2")

@dianaafanador3 thanks - thanks, sorry I was a bit lazy, I should have checked that.

repo: realm/realm-swift


text:
Add history flag for writeCopy

Introduces a flag on writeCopy which allows a copied realm to include sync history. This allows a copied realm to synchronize data.
Introduces a seedFilePath option on RLMRealmConfiguration and Realm.Configuration. If this
option is set then instead of creating an empty, the realm at the seedFilePath will
be copied to the fileURL of the new realm.
This enables use cases like bundling a synchronized realm with an application.

We probably need something like Java's feature where you can set a bundled Realm path in your config that'll be copied to the appropriate location on open if we don't already have a local Realm.

So this would be a configuration option, on the file that is to be copied? Would this only be used for local realms? Since sync realm URLs are generated differently?

This is being reworked.

I tried creating something similar to assetFile in realm-java but felt the extra code wasn’t necessarily worth the benefit.

I couldn’t figure out a good way without changing the hot path realmWithConfiguration.
There was some weirdness with toggling back and forth between in-memory.
It would obscure a developer’s ability to wait for uploads, should they need.
Didn't believe the immediate usefulness justified adding to public API of RLMRealm.

Most of what is necessary is just the ease of access to the path the realm was copied to. So I wanted to expose the ability to tell where a realm would be opened before it is opened. But this is already available after constructing a sync configuration and before opening the realm, in syncConfig.fileURL.

Needs changelog

syncConfig.fileURL is not public. Even if it was, we'd just be asking developers to copy/paste some boilerplate code to do something we could just be taking care of for them.
I don't understand the relevance of in-memory Realms or why this'd have any effect on waiting for uploads. The non-cache hit path of realmWithConfiguration isn't a hot-path; it's actually pretty expensive to open a Realm from scratch already.

config.fileURL contains the path of the sync realm.
The inMemoryIdentifier option is relevant because it's not compatible with an assetFile path. Switching a configuration to and from inMemoryIdentifier would not return back to the previous state easily.

Clearing the asset file path when a configuration is set to in-memory and not restoring it when the configuration is set to a non-in-memory mode is how everything else on RLMConfiguration works.

@tgoyne I don't really agree with adding an assetFileURL to the config. It doesn't save the user much boilerplate and adds confusion– notably because they will not be able to use the same configuration (containing the assetFileURL) to use their new Realm.
Considering writeCopy is not a hot path, I do not see an issue with this just being a flag in writeCopy (albeit not named history since that exposes an implementation a detail). So the steps would be:

Open asset realm A.
Write Copy asset realm A to destination 1.
Open realm at destination 1 with configuration with fileURL pointing to destination 1.

Why complicate that?

That's not how you use bundled Realms. You use writeCopy() to produce the Realm which you will include in your app bundle, not to open the bundled Realm and copy it to the writeable location. The full flow is:

Either use Studio or writeCopy() in a simulator to produce a Realm with no client ID.
Move that file into your app's project and add it to the bundled files.
On app startup, construct your app's Realm.Configuration normally.
Do if !Realm.fileExists(for: config) { try! FileManager.default.copy(from: Bundle.main.url(forResource: "bundledRealm", ext: "realm")!, config.fileURL) }
Open the Realm normally

Java's assetURL just replaces step 4 with config.assetURL = Bundle.main.url(forResource: "bundledRealm", ext: "realm"). We didn't bother adding it when they did because it is just one line of code, but that one line of code is incorrect (it'll crash and/or corrupt data if another thread tries to open the Realm while the copy is happening) and it seems sort of silly to have some code in the documentation for people to copy/paste when we could just take care of it for them.

That makes sense, I assumed writeCopy was being used in the same process. assetURL makes sense given what you're saying, but the name is confusing. An asset is congruous to a file so having assetURL and fileURL seem super error prone. I'm open to better names.

Yeah, I don't like the name very much.

Ready for review again.
Added the ability to set a file path that will be copied.
I went with seedFilePath.
Other options included:
assetFile: To confusing with fileURL. Maybe assetFile would work better if we didn't already have fileURL
assetFilePath
inputFilePath
originFilePath
copyFilePath

The CI tests should fail with an exception until this is merged and updated to: https://github.com/realm/realm-core/pull/5161
After that mismatching enableSync to the kind of configuration that's ultimately used should throw:
  Realm file’s history format is incompatible with the
  settings in the configuration object being used to open
  the Realm. Note that Realms configured for sync cannot be
  opened as non-synced Realms, and vice versa. Otherwise, the
  file may be corrupt. Path: xyz

Core updated.
Ready for review again.

We will deprecate this PR in favour of https://github.com/realm/realm-swift/pull/7613

@leemaguire No problem - should I close this PR?

The seedFilePath part of this is still relevant after #7613.

authors: ericjordanmossman jsflax leemaguire tgoyne


text:
Problem with build nxt-lnk

Hello, I tried to build nxt-lnk on cloudflare pages, but that did not work. Can you explain how nxt-lnk can be used on the cloudflare pages service?

Hey,
I didn't tried it on cloudflare. I tested on netflify and vercel and it works smoothly.
Try to download the repository and configure it manaully based on cloudflare documentation? Let me know the issue if you found I'll update.

Yes, I tried testing nxt-lnk on cloudflare Pages a lot, but this error appears
2023-12-13T15:40:12.977581Z	Cloning repository... 2023-12-13T15:40:13.982142Z	From https://github.com/aflamrip/nxtlnk 2023-12-13T15:40:13.982824Z	 * branch            a3279e40c772684809d5c8be73a8e86bd98b91d7 -> FETCH_HEAD 2023-12-13T15:40:13.983022Z	 2023-12-13T15:40:14.061433Z	HEAD is now at a3279e4 Initial commit 2023-12-13T15:40:14.062441Z	 2023-12-13T15:40:14.170955Z	 2023-12-13T15:40:14.204976Z	Success: Finished cloning repository files 2023-12-13T15:40:15.098592Z	Detected the following tools from environment: yarn@3.6.3, nodejs@18.17.1 2023-12-13T15:40:15.099813Z	Installing project dependencies: yarn 2023-12-13T15:40:15.82705Z	➤ YN0070: Migrating from Yarn 1; automatically enabling the compatibility node-modules linker 👍 2023-12-13T15:40:15.8276Z	 2023-12-13T15:40:15.886362Z	➤ YN0000: ┌ Resolution step 2023-12-13T15:40:16.256679Z	➤ YN0061: │ react-particles-js@npm:3.6.0 is deprecated: This package has been deprecated in favor of react-tsparticles. 2023-12-13T15:40:24.290518Z	➤ YN0060: │ realvjy@workspace:. provides react (p38ff5) with version 18.2.0, which doesn't satisfy what react-particles-js requests 2023-12-13T15:40:24.290948Z	➤ YN0060: │ realvjy@workspace:. provides react (p01f84) with version 18.2.0, which doesn't satisfy what use-dark-mode and some of its descendants request 2023-12-13T15:40:24.291153Z	➤ YN0002: │ realvjy@workspace:. doesn't provide react-is (p37fc1), requested by styled-components 2023-12-13T15:40:24.291325Z	➤ YN0002: │ realvjy@workspace:. doesn't provide tsparticles (p31657), requested by react-particles-js 2023-12-13T15:40:24.291501Z	➤ YN0000: │ Some peer dependencies are incorrectly met; run yarn explain peer-requirements <hash> for details, where <hash> is the six-letter p-prefixed code 2023-12-13T15:40:24.295688Z	➤ YN0000: └ Completed in 8s 409ms 2023-12-13T15:40:24.319184Z	➤ YN0000: ┌ Post-resolution validation 2023-12-13T15:40:24.319444Z	➤ YN0028: │ The lockfile would have been modified by this install, which is explicitly forbidden. 2023-12-13T15:40:24.319613Z	➤ YN0000: └ Completed 2023-12-13T15:40:24.319803Z	➤ YN0000: Failed with errors in 8s 435ms 2023-12-13T15:40:24.39503Z	Error: Exit with error code: 1 2023-12-13T15:40:24.395435Z	    at ChildProcess.<anonymous> (/snapshot/dist/run-build.js) 2023-12-13T15:40:24.395676Z	    at Object.onceWrapper (node:events:652:26) 2023-12-13T15:40:24.395861Z	    at ChildProcess.emit (node:events:537:28) 2023-12-13T15:40:24.396022Z	    at ChildProcess._handle.onexit (node:internal/child_process:291:12) 2023-12-13T15:40:24.402508Z	Failed: build command exited with code: 1 2023-12-13T15:40:25.338149Z	Failed: error occurred while running build command

I was exploring about cloudflare and found need to configure something called Edge Runtime.
So, I think currently sturcuure I created will not directly work there need to work on some configuaration. Just download/fork this repositry and see the link  - Cloudflare Nextjs.
I don't have time to work on it at the moement but if you success please open a pull request and I'll have a look.

Closing for now. If you have some idea let me know and open a new Pull request. thanks

authors: aflamrip realvjy

repo: realvjy/nxt-lnk


text:
Rei and phone

This is a simple pull request that does one thing and does it well.
JK, this thing is all over the place:

Update Relude version and fix functions that needed labels
Enable more Bucklescript warnings and fix anything that needed fixing
Move "extras" (parser examples) to their own folder to avoid clutter
Generate rei files, prune out invalid constructors, add some doc comments
Consistently add helper functions to parse a string as a result, option, or to raise an exception (unsafe* functions now throw instead of returning invalid values)
Add types and parsing for North American phone numbers

This is awesome! Thanks for doing all the cleanup and figuring out a good way to have better safety for these extra types. I didn't know about failwith... That's handy for these unsafe crash now situations

repo: reazen/relude-parse


text:
Cleaned up code and added some text to output

Added a user prompt for the number of people you want to pick.

Awesome, thanks @bahadasx !

authors: bahadasx rebeccabilbro

repo: rebeccabilbro/pickr


text:
Master blaster

Reintroces commits deleted by force push.
Locks Stripe to < 1.42 to avoid failing tests with new subscriptions API introduced in 1.42 (https://github.com/stripe/stripe-ruby/blob/master/History.txt).

See https://github.com/rebelidealist/stripe-ruby-mock/pull/326 for the rabbit hole I went down with this one.

cc @mindeavor @alexmamonchik

:clap: thanks a lot @typeoneerror

authors: alexmamonchik typeoneerror

repo: rebelidealist/stripe-ruby-mock


text:
Fix request normalization for request body with a list as a JSON root

Fixes #536

Codecov Report

Merging #538 (a4312c3) into master (6399848) will decrease coverage by 0.14%.
The diff coverage is 77.77%.

@@            Coverage Diff             @@
##           master     #538      +/-   ##
==========================================
- Coverage   98.53%   98.38%   -0.15%
==========================================
  Files          18       18
  Lines        1294     1302       +8
  Branches      204      207       +3
==========================================
+ Hits         1275     1281       +6
- Misses         10       11       +1
- Partials        9       10       +1

Impacted Files
Coverage Δ

requests_cache/cache_keys.py
95.78% <77.77%> (-1.92%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6399848...a4312c3. Read the comment docs.

authors: JWCook codecov-commenter

repo: reclosedev/requests-cache


text:
[Install] update the installation docs recomending the python -m rubrix.server way

The idea is following default installation:
# install server dependencies
pip install rubrix[server]

# if no ES running
docker run ...

# run web app
python -m rubrix.server

advantage:

without docker-compose: easier to update the rubrix version
with ES container running in the background, easier to avoid data loss,

disadvantage:

we include the server dependencies in the default installation

note:

in the conda package we need to update the dependencies

@frascuchon @dvsrepo

I like it a lot this way. Also, it's a good opportunity to have a very clear documentation for installation section

We can include also the basics of howto launch with uvicorn directly

authors: dcfidalgo dvsrepo frascuchon

repo: recognai/rubrix


text:
[FEATURE] Edit a Wordlist file

Mockups
Old version examples

Acceptance Criteria

A Wordlist file will be editted as Github edits files
Edit option will be visible only if the file size is less than 20 MB
User will be able to open the Wordlist file in Edit mode by clicking on the filename. The name will be a link for edit the file, only if the file size is less than 20 MB, otherwise, the filename will appear as plain text
If the file is candidate for edition, there will be a tooltip in its name with the text: "Click here for edit this file"
After clicking Edit, the content of the file will appear in an Editor or big textarea, the file can be eddited by the user and then saved

Working as expected, as documented in https://github.com/reconness/reconness-frontend/issues/446#issuecomment-1031976838

@YanetABUC Duplicate ticket https://github.com/reconness/reconness-frontend/issues/500

@YanetABUC  instead 20 MB we are going to use 5 MB

This ticket is duplicated, hence I'm closing it

authors: YanetABUC gorums

repo: reconness/reconness-frontend


text:
Error: This component must be used inside a  component.

I tried to develop with yarn add link:<local path> and got the following error
Server Error
Error: This component must be used inside a <RecoilRoot> component.

It seems to be related to the following issue, but I tried it with reac@17 and recoil@0.7.2 and got an error.
https://github.com/facebookexperimental/Recoil/issues/1802

Probably it is caused by a conflict between two Recoil packages.

<app>/node_modules/recoil
<recoil-sync-next>/node_modules/recoil

Can you try the following steps?
cd <app>
yarn unlink recoil-sync-next

cd <recoil-sync-next>
yarn unlink
yarn pack

cd <app>/node-modules
tar zxf <recoil-sync-next>/recoil-sync-next-v0.0.0.tgz
mv package recoil-sync-next
cd ..
yarn dev

Thanks, It worked!
l close this issue.

authors: AkifumiSato koichik

repo: recruit-tech/recoil-sync-next


text:
[6.2] use Symfony\Bundle\SecurityBundle\Security; instead of Symfony\Component\Security\Core\Security;

Hi, I would like to contribute for such Symfony v6.2 deprecation
Perhaps in the SymfonyLevelSetList::UP_TO_SYMFONY_62 ?

// src/Controller/MyController.php

- use Symfony\Component\Security\Core\Security;
+ use Symfony\Bundle\SecurityBundle\Security;

 class MyController extends AbstractController
 {
    public function index(Security $security)
    {
        // ...
    }
 }

I do not know if rector-symfony is relevant for this, but I think so that is why I propose
Feel free to close, thanks !

See https://github.com/rectorphp/rector-symfony/pull/285

repo: rectorphp/rector-symfony


text:
Fix yard doc link in README.md

Hi!
Fixed the link.
I often access the documentation from the README.
That's why I noticed this.
Thank you.

@kojix2 Thank you very much!

repo: red-data-tools/red-palette


text:
Update image with digest for caikit-tgis-serving

update:
from https://redhat-internal.slack.com/archives/C05NXTEHLGY/p1693892566876919?thread_ts=1693555419.145589&cid=C05NXTEHLGY, what suggest that it should use modh not opendathaub
https://quay.io/repository/modh/caikit-tgis-serving?tab=tags
old:
see https://quay.io/repository/opendatahub/caikit-tgis-serving?tab=tags with stable-27c0d61
I am not 100% if this should target for 1.32 branch or main, create this PR only for QE to verify image is correct.
leave reviewers to decide how you can to use this PR.
P.S: if needed you might also make a sync to upstream ODH repo. but with quay.io/opendatahub image

Closing this, since it was done in this PR

authors: heyselbi zdtsw


text:
sync release-2024a from opendatahub-io:2024a

sync release-2024a from opendatahub-io:2024a
fixed: https://github.com/red-hat-data-services/notebooks/pull/307

Merging to get this ready.

repo: red-hat-data-services/notebooks


text:
Update the visual editor wording

Update the visual text on the empty Pipeline state.
https://issues.redhat.com/browse/RHODS-8373

/lgtm

repo: red-hat-data-services/odh-dashboard


text:
sync upstream devel with downstream

syncing upstream devel with downstream devel to get the latest changes from upstream. which contains the important bug fix for scheduling workaround https://github.com/ceph/ceph-csi/pull/2669
Signed-off-by: Madhu Rajanna madhupr007@gmail.com

/assign @agarwal-mudit
/assign @nixpanic

/lgtm

repo: red-hat-storage/ceph-csi


text:
provider-controller: check StorageConsumers in disable case too

The earlier code verifyNoStorageConsumerExist only if user deletes a
storagecluster. But we also need to make sure the same when user disable
the provider but do not delete the storageCluster.
fix the test as well.
Signed-off-by: Nitin Goyal nigoyal@redhat.com

/cherry-pick release-4.10

/lgtm

authors: agarwal-mudit iamniting nb-ohad

repo: red-hat-storage/ocs-operator


text:
RDR: exporting client info

Handles exporting the incoming data found in the on-boarded consumer's request into the consumer's status, that in turn will populate the ODF info CM's ConnectedClients via the StorageCluster's reconciler (addressed as part of #2440).

/test ocs-operator-bundle-e2e-aws

/cc @umangachapagain

/cc @umangachapagain @nb-ohad

/test ocs-operator-bundle-e2e-aws

/lgtm

authors: nb-ohad raaizik


text:
Changes to onboarding token api to add quota parameter

Setting 0 quota means unlimited quota
Added a new quota as URL parameter

@rchikatw Why use 0 or unlimited/unbound? why not have it a pointer and use nil instead?

/lgtm

/lgtm

authors: nb-ohad rchikatw


text:
Appstudio update test-component-pac-kpyy

Pipelines as Code configuration proposal

Pipelines as Code CI/test-component-pac-kpyy-on-pull-request has successfully validated your commit.

StatusDurationName

✅ Succeeded
8 seconds
init

✅ Succeeded
17 seconds
clone-repository

✅ Succeeded
1 minute
build-container

✅ Succeeded
25 seconds
deprecated-base-image-check

✅ Succeeded
24 seconds
sanity-inspect-image

✅ Succeeded
48 seconds
clamav-scan

✅ Succeeded
3 minutes
clair-scan

✅ Succeeded
15 seconds
sbom-json-check

✅ Succeeded
8 seconds
sanity-optional-label-check

✅ Succeeded
8 seconds
sanity-label-check

✅ Succeeded
15 seconds
show-summary

Pipelines as Code CI/test-component-pac-kpyy-on-pull-request has successfully validated your commit.

StatusDurationName

✅ Succeeded
7 seconds
init

✅ Succeeded
13 seconds
clone-repository

✅ Succeeded
36 seconds
build-container

✅ Succeeded
18 seconds
deprecated-base-image-check

✅ Succeeded
15 seconds
sanity-inspect-image

✅ Succeeded
9 seconds
clair-scan

✅ Succeeded
39 seconds
clamav-scan

✅ Succeeded
8 seconds
sbom-json-check

✅ Succeeded
8 seconds
sanity-optional-label-check

✅ Succeeded
8 seconds
sanity-label-check

✅ Succeeded
6 seconds
show-summary

Pipelines as Code CI/test-component-pac-kpyy-on-pull-request has successfully validated your commit.

StatusDurationName

✅ Succeeded
7 seconds
init

✅ Succeeded
13 seconds
clone-repository

✅ Succeeded
36 seconds
build-container

✅ Succeeded
18 seconds
deprecated-base-image-check

✅ Succeeded
15 seconds
sanity-inspect-image

✅ Succeeded
9 seconds
clair-scan

✅ Succeeded
39 seconds
clamav-scan

✅ Succeeded
8 seconds
sbom-json-check

✅ Succeeded
8 seconds
sanity-optional-label-check

✅ Succeeded
8 seconds
sanity-label-check

✅ Succeeded
6 seconds
show-summary


text:
try enabling chains deep inspection via infra change only given tekto…

to test the konflux e2e's against openshift-pipelines/pipeline-service#985 before merging openshift-pipelines/pipeline-service#985

/lgtm
@yashvardhannanavati  @lcarva FYI

It sounds like we should have a single place to define the Chains config?

It sounds like we should have a single place to define the Chains config?

that is a long term goal @lcarva not just for chains, but for all tekton related config, given how truly dead "tekton as a service" is; I
n fact I recently prototyped a first step in unwinding things, and having a "infra-deployments only" gitops / kustomize approach, and @enarha and I have had some preliminary discussions on the details of it; however, that prototype could be cleaned up even more, and then we have to worry about the feeders into pipeline-service repo

consumption of the openshift pipeline nightlies as part of Red Hat's "Service First" initiative
our downstream results fork (while the operator's version still lags too far behind for Konflux's needs)
the metrics exporter (for the stats we are still iterating on, where upstreaming again is too long of a loop)

authors: enarha gabemontero lcarva

repo: redhat-appstudio/infra-deployments


text:
Removing Spot Instance Option for Multi-Platform Build

Removing Spot Instance Option for Multi-Platform Build.
We must handle the scenario to run an on-demand instance when the capacity is full.

/lgtm

authors: arewm manish-jangra


text:
Add a crashloopbackoff alert for tekton

I noticed that the PipelinePodsRepeatedRestarts alert has a problem: at first, when pods are restarting, it fires. Good! But then, after a short while, the pod enters CrashLoopBackOff and it starts restarting less frequently. This causes PipelinePodsRepeatedRestarts to stop firing, making it appear as if the outage has resolved itself, when in fact it hasn't.
Adding this second alert will cause a second alert to fire when the situation cements itself into a CrashLoopBackOff.
Perhaps we should just remove the PipelinePodsRepeatedRestarts alert and replace it with this second one? Or - we could try both for a while and see how they play together before deciding?

@ralphbean there seems to be a gitlint issue
+ gitlint --fail-without-commits --commits origin/main..HEAD
WARNING: I4 - ignore-by-author-name: gitlint will be switching from using Python regex 'match' (match beginning) to 'search' (match anywhere) semantics. Please review your ignore-by-author-name.regex option accordingly. To remove this warning, set general.regex-style-search=True. More details: https://jorisroovers.github.io/gitlint/configuration/#regex-style-search
1: CT1 Title does not follow ConventionalCommits.org format 'type(optional-scope): description': "Add a crashloopbackoff alert for tekton"

Other than that, LGTM

/retest

Adding rpms-signature-scan task in https://github.com/redhat-appstudio/o11y/pull/413 to address that policy failure.

@ralphbean looks like the enterprise contract is failing, I've looked into it and can't really figure out why. Do you have any insight here?

Perhaps we should just remove the PipelinePodsRepeatedRestarts alert and replace it with this second one? Or - we could try both for a while and see how they play together before deciding?

hmm. The idea of using kube_pod_container_status_restarts_total metric is to alert when there is a restart without specifying the reason. The new alert would only alert if there is a crashloop. I don't think there would be alert when there is a restart due to resource limitations.
Are we planning to bump the grafana dashboard to include this alert? I don't see there is an update in app-interface or open MR for that.

Does it make sense to have tests for the alert? something similar to these: https://github.com/redhat-appstudio/o11y/tree/main/test/promql/tests/data_plane

authors: mftb ralphbean zanssa


text:
Workflow to publish images to quay using tag "dev" and not "latest"

"latest" image will be used for GA and as such should not include further development.
Publish to latest will need to be a manual check.

I've adjusted quay.io to publish images using the branch name as tag, and not publish a "latest" tag.
The configuration can be found here, at the bottom of the page. In the case you don't have access to the repository in quay.io, please let either @isutton, @pedjak or @baijum know as we currently are the organization admins.

@isutton my quay user name is mmulholl

@mmulholla I've added you as admin in the redhat-certification org in quay.io.

authors: isutton mmulholla

repo: redhat-certification/chart-verifier


text:
Migration of python-kopf-s2i and python-kopf-s2i-example repositories

Type of repository request
migration of existing repository
Requested name for the repository
https://quay.io/repository/jkupferer/python-kopf-s2i -> redhat-cop/python-kopf-s2i
https://quay.io/repository/jkupferer/python-kopf-s2i-example -> redhat-cop/python-kopf-s2i-example
Repository Description
The python-kopf-s2i repository creates a source-to-image builder for the Python kopf operator framework.
https://kopf.readthedocs.io/en/latest/
The python-kopf-s2i-example repository is an example of how to use the source-to-image.
The s2i scripts have been tested and are compatible with odo, which should allow for a variety of IDE integrations for python operator development with kopf.
Admin Access
The babylon team.
Write Access
none
Read Access
none
Additional details
These repositories also will need quay.io integration. This can be requested in a separate issue...

Review request:
cc: @redhat-cop/container-cop-core

Hey @jkupferer I'm not seeing any source code included in this request. Either way, it looks to me like this would fit nicely in the [container-quickstarts] repo. We keep several other custom s2i images there.  That repo also already contains a secret config for pushing images to quay, so we then just need to create the image repositories.
If you want to go ahead and work on the PR for that repo, I will get the image repository.
I'm also a bit confused about the difference between python-kopf-s2i and python-kopf-s2i-example. Can you elaborate?

I can switch this to a PR to container-quickstarts, just need to figure out how to add that there.
python-kopf-s2i is the base s2i builder image while python-kopf-s2i-example is an example repository showing how to use python-kopf-s2i.

The PR has been merged to container-quickstarts, but it seems either the python-kopf-s2i repository does not exist or permissions are not configured for the robot account:
https://github.com/redhat-cop/containers-quickstarts/runs/691145587?check_suite_focus=true

All set on this! :D

authors: etsauer jkupferer

repo: redhat-cop/org


text:
unable to get deployment frequency metric when using external Registry

we are using

Pelorus branch master

i am using  this demo:
https://github.com/siamaksade/openshift-cd-demo
and we try to use Pelorus to get metrics.
Expected result

Dashboard showing the metrics of deployments

Actual Result

the dashboard not show the metrics and the deploytime-exporter pod show the following log

08-27-2020 17:35:31 DEBUG    Skipping unresolved image reference: quay.io/cduarter/tasks-app:latest
08-27-2020 17:35:31 DEBUG    Skipping unresolved image reference: quay.io/cduarter/tasks-app:latest
08-27-2020 17:35:31 DEBUG    Skipping unresolved image reference: quay.io/cduarter/tasks-app:latest
08-27-2020 17:35:31 DEBUG    Skipping unresolved image reference: quay.io/cduarter/tasks-app:latest
08-27-2020 17:35:31 DEBUG    Skipping unresolved image reference: quay.io/cduarter/tasks-app:latest
08-27-2020 17:35:31 DEBUG    Skipping unresolved image reference: quay.io/cduarter/tasks-app:latest
08-27-2020 17:35:31 DEBUG    Skipping unresolved image reference: quay.io/cduarter/tasks-app:stage
08-27-2020 17:35:31 DEBUG    Skipping unresolved image reference: quay.io/cduarter/tasks-app:stage
Watching namespaces: ['dev-opentlc', 'stage-opentlc']
ANALISYS
I think that i am using a external registry and the exported does not find an image registry.
how  pelorus  should work when using an external registry?

@ChrystianDuarte can you provide a sample of the Deployment/DeploymentConfig that's using this image?

hello guys,
the deployment config is:
kind: DeploymentConfig
apiVersion: apps.openshift.io/v1
metadata:
annotations:
openshift.io/generated-by: OpenShiftNewApp
selfLink: /apis/apps.openshift.io/v1/namespaces/dev-opentlc/deploymentconfigs/tasks
resourceVersion: '1437414'
name: tasks
uid: 598bcbba-d63f-474c-ba53-fa98ee2dd5e6
creationTimestamp: '2020-08-25T19:43:00Z'
generation: 13
namespace: dev-opentlc
labels:
app: tasks
spec:
strategy:
type: Rolling
rollingParams:
updatePeriodSeconds: 1
intervalSeconds: 1
timeoutSeconds: 600
maxUnavailable: 25%
maxSurge: 25%
resources: {}
activeDeadlineSeconds: 21600
triggers: []
replicas: 1
revisionHistoryLimit: 10
test: false
selector:
app: tasks
deploymentconfig: tasks
template:
metadata:
creationTimestamp: null
labels:
app: tasks
deploymentconfig: tasks
annotations:
openshift.io/generated-by: OpenShiftNewApp
spec:
containers:
- resources: {}
readinessProbe:
httpGet:
path: /ws/demo/healthcheck
port: 8080
scheme: HTTP
initialDelaySeconds: 30
timeoutSeconds: 1
periodSeconds: 10
successThreshold: 1
failureThreshold: 10
terminationMessagePath: /dev/termination-log
name: tasks
livenessProbe:
httpGet:
path: /ws/demo/healthcheck
port: 8080
scheme: HTTP
initialDelaySeconds: 180
timeoutSeconds: 1
periodSeconds: 10
successThreshold: 1
failureThreshold: 10
ports:
- containerPort: 8080
protocol: TCP
imagePullPolicy: Always
terminationMessagePolicy: File
image: 'quay.io/cduarter/tasks-app:latest'
restartPolicy: Always
terminationGracePeriodSeconds: 30
dnsPolicy: ClusterFirst
securityContext: {}
schedulerName: default-scheduler
status:
observedGeneration: 13
details:
message: manual change
causes:
- type: Manual
availableReplicas: 1
unavailableReplicas: 0
latestVersion: 9
updatedReplicas: 1
conditions:
- type: Available
status: 'True'
lastUpdateTime: '2020-09-02T13:36:46Z'
lastTransitionTime: '2020-09-02T13:36:46Z'
message: Deployment config has minimum availability.
- type: Progressing
status: 'True'
lastUpdateTime: '2020-09-02T14:03:30Z'
lastTransitionTime: '2020-09-02T14:03:27Z'
reason: NewReplicationControllerAvailable
message: replication controller "tasks-9" successfully rolled out
replicas: 1
readyReplicas: 1

@ChrystianDuarte thanks. Could you also provide a ReplicationController YAML for the latest rollout?

guys,
I attach the all objects of my namespace pelorus
pelorus-objects.zip
Thanks

hey @ChrystianDuarte I wasn't asking to see the Pelorus deployment info, but the info about the application that you've cited that's being "skipped". The deploytime exporter is looking to key off of the sha256 hash in the image field of a ReplicationController, or ReplicaSet, so what I'm looking for is an example of the ReplicationController you'd find at:
oc get replicationcontroller -l deploymentconfig=tasks -n dev-opentlc -o yaml

hey @etsauer
when I execute you command the output is
[cduarte@ronnie pelorus]$ oc get replicationcontroller -l deploymentconfig=tasks -n dev-opentlc -o yaml
apiVersion: v1
items: []
kind: List
metadata:
resourceVersion: ""
selfLink: ""
but the replication controllers of the namespaces of dev-opentlc are the following:
[cduarte@ronnie pelorus]$ oc get rc -n dev-opentlc
NAME      DESIRED   CURRENT   READY   AGE
tasks-1   0         0         0       8d
tasks-2   0         0         0       8d
tasks-3   0         0         0       8d
tasks-4   0         0         0       7d1h
tasks-5   0         0         0       6d23h
tasks-6   0         0         0       6d23h
tasks-7   0         0         0       6d21h
tasks-8   0         0         0       6d19h
tasks-9   1         1         1       26h
I attach the last , task-9
rc-task-9.zip

ok, I've taken a look, and I believe you're right. There is probably a better way for us to get the ImageIDs for this case. I'll mark this as a bug, and we can get to work on that.

Closing. Assumed complete.

authors: ChrystianDuarte etsauer

repo: redhat-cop/pelorus


text:
chore: POC for updated list of Connectors

What this PR does / why we need it:

Making a list of the Connectors

Verification steps

< PROOFOFCONCEPTS > < connectors >

Special notes for your reviewer:

The icons on the far left are temporary till the ones in the mock-up are available

@gashcrumb I applied the comments you mentioned :)

I think we can close this as this effort was moved over to the cos-ui repo.


text:
fix: add timeout period for login to finish

Fix #45.

Added #103. Merging this one.


text:
Add Chart for WildFly

the wildfly-common library chart does not need to be indexed as it is bundled
inside the wildfly-1.3.0.tgz application chart
remove the alpha/wildfly/charts/wildfly-common-1.2.0.tgz that does
need to be included in the Helm chart sources

Signed-off-by: Jeff Mesnil jmesnil@redhat.com

After testing the charts in OpenShift, I noticed that it was listing wildfly-common that is a library chart and does not need to be exposed to the UI (as it is bundled inside the wildfly application chart)

repo: redhat-developer/redhat-helm-charts


text:
typo do -> to

Which issue(s) this PR addresses:

Closes #

Well-spotted, thank you!
/lgtm

authors: fzdarsky kaovilai

repo: redhat-et/microshift-documentation


text:
operator grafana-operator (4.6.0)

Updates to existing Operators

[X] Did you create a ci.yaml file according to the update instructions?
[X] Is your new CSV pointing to the previous version with the replaces property if you chose replaces-mode via the updateGraph property in ci.yaml?
[X] Is your new CSV referenced in the appropriate channel defined in the package.yaml or annotations.yaml ?
[X] Have you tested an update to your Operator when deployed via OLM?
[X] Is your submission signed?

Your submission should not

[X] Modify more than one operator
[X] Modify an Operator you don't own
[X] Rename an operator - please remove and add with a different name instead
[X] Modify any files outside the above mentioned folders
[X] Contain more than one commit. Please squash your commits.

Operator Description must contain (in order)

[X] Description of the managed Application and where to find more information
[X] Features and capabilities of your Operator and how to use it
[X] Any manual steps about potential pre-requisites for using your Operator

Operator Metadata should contain

[X] Human readable name and 1-liner description about your Operator
[X] Valid category name1
[X] One of the pre-defined capability levels2
[X] Links to the maintainer, source code and documentation
[X] Example templates for all Custom Resource Definitions intended to be used
[X] A quadratic logo

Remember that you can preview your CSV here.
--
1 If you feel your Operator does not fit any of the pre-defined categories, file an issue against this repo and explain your need
2 For more information see here

/merge possible

/merge possible

@jozzi @mvalarh seems like there is a bug in the CI, the prow jobs got aborted, I would assume this is thanks to the others jobs finished first and then the bot thought it was okay to merge it anyway so it did.

authors: NissesSenap framework-automation