text:
Invalid file id using PHP SDK

Testing uploading and deleting a file
I uploaded a file:
$pcloudFile = new pCloud\File();
$fileName = 'test.pdf';
$fileMetadata = $pcloudFile->upload($_FILES["attachment"]["tmp_name"], $folderId, $fileName);
return $fileMetadata->metadata->fileid;

Then I passed the fileid to the delete.php and tried to call delete():
$pcloudFile = new pCloud\File();
$fileMetadata = $pcloudFile->delete($_POST["fileid"]);

Result:
Fatal error: Uncaught InvalidArgumentException: Invalid file id in pCloud\File.php on line 113
Stack Trace: delete.php:31
Which is this line: $fileMetadata = $pcloudFile->delete($_POST["fileid"]);
I have validated that in delete.php the $_POST["fileid"] is exactly the same as what is returned in upload.php in $fileMetadata->metadata->fileid
It's throwing a Fatal Error and not even a passing an error in the return array.

My bad.  Please delete. After writing I followed the steps and found the problem.

repo: pCloud/pcloud-sdk-php


text:
Simplify return type of createForm

Is your feature request related to a problem? Please describe.
Simplify return type of createForm
Describe the solution you'd like
To have a single generic type for the return type of createForm. It would allow passing the form between components in a typesafe way.
At present, what would be the type of a property on a component that accepts a createForm() value?
Describe alternatives you've considered
Using any.
Additional context
Using Solidjs

Catching up a bit. Currently I don't export any types for it but is it generic enough if you do something such as this?
export type FelteForm = ReturnType<typeof createForm>;

source: gharchive/issue

authors: aryzing pablo-abc

repo: pablo-abc/felte

license: MIT

license_type: permissive

license_source: github-api


text:
SAML2 client not working if IdP is in different time zone

Turns out the function that detemines whether a SAML2 authentication request is still valid does not take time zones into consideration.
SAML2DefaultResponseValidator.isDateValid() returns false if the IdP is in a different time zone and leads to an invalid authentication request.

as workaround until this is fixed, set the setMaximumAuthenticationLifetime to 24h:
((SAML2DefaultResponseValidator) saml2Client.getResponseValidator()).setMaximumAuthenticationLifetime(24 * 3600 * 1000);
it would probably be nice to expose that setter method on the interface as well in future...

Thanks for the report. Looks like the time received is handled via joda time which should consider time zones, but the sp time is handled by system milliseconds which does not. I think both time instances should be based on jodatime to mitigate the problem.

Thanks for reporting and the workaround. Would you mind proposing some PR to mitigate the problem?

I'll put together a PR for this issue today.

Thanks.

authors: DanielVocke leleuj mmoayyed


text:
Separate out internal-use-only protos

Our protos currently include some messages that are meant to be used internally only. In particular, I'm thinking of EtcdJobInfo and EtcdPipelineInfo in pps.proto, though there may be others as well. These should be separated out to their own proto files, since they unnecessarily bloat the size of client bindings.

I think auth.GetAuthToken() may be another example of this (see #3869)

We generally do have very segregated protos, with only external ones in src/client the Etcd* ones are an exception because they're forms of other protos that are stored in etcd, and as such any time you add a field to the Etcd version of the proto you need to add the same field to the other public facing protos. For this reason I think it makes sense to keep these as an exception, since it adds overhead to have to switch between 2 files to do this (and most editors don't have jump to definition for protos), and I think having them in the proto file is probably not that big a cost to pay.
I'm going to close this because I think we basically are doing this with the exception of Etcd* protos which are a conscious exception we're making, but feel free to reopen if you think there are other places we could change this.

@jdoliner I'm guessing you already considered this, but heads up that this makes autogenerated client libraries a little less ergonomic, because there's some messages/structs/objects exposed that shouldn't actually be used.

There's a few more messages/gRPC functions that appear to be private as well, so resurrecting this:

PFS' BuildCommit
PPS' ActivateAuth and CreateJob

authors: gabrielgrant jdoliner ysimonson

repo: pachyderm/pachyderm


text:
remove deploy/releases from the repository and upload assets at release time

Closes #55

CI is stuck, but it just is the report part, not anything related to build, so I am merging it in.

source: gharchive/pull-request

repo: packethost/packet-ccm


text:
Prepare file structure for object-specific methods

Fixes #232

@mfocko can I send you a fix for github to your branch? (You can use the same approach for other implementations.)

@mfocko can I send you a fix for github to your branch? (You can use the same approach for other implementations.)

Sure, added you to repo

@mfocko Waiting for #238 can help you a bit.

/packit copr-build

Tested:

[x] packit
[x] packit-service (fixed: https://github.com/packit-service/packit-service/pull/162)
[x] release-bot (unrelated comptaiblity fix: https://github.com/user-cont/release-bot/pull/240)

authors: lachmanfrantisek mfocko

repo: packit-service/ogr


text:
Convert HTTP module to use GRPC module instead of CAPNP module

Description
This converts the HTTP module to use the GRPC module instead of the CAPNP module. This also required some more extensions to the GRPC module as there was some missing information. Since this was the last user of the CAPNP module, it is also removed.
Related issue(s)
This should close #418. It should also close #401 since the output was fixed during the conversion. And it should also close #373 and close #374 since I added the missing payload types to GRPC module to finish this conversion.
Checklist

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[x] Breaking change (fix or feature that would cause existing functionality to change)
[x] My code follows the code style of this project.
[ ] I have added tests to cover my changes.
[x] All new and existing tests passed.
[ ] CHANGELOG is updated.

@braewoods Thanks. All looks good. JUst the tests folder is removed. That test is really important to make sure the system works fine

@braewoods Thanks. All looks good. JUst the tests folder is removed. That test is really important to make sure the system works fine

I thought they were exclusive to CAPNP so that's why it was removed.

It should now fix all the discussed issues.

repo: pactus-project/pactus


text:
Add column level summary stats modal on hover

Checks

[X] I have checked that this enhancement has not already been requested

How would you categorize this request.  You can select multiple if not sure
Summary stats, Developer ergonomics (defaults, error messages), Other (please describe in Issue Description)
Enhancement Description
Show the summary stats for a single column when you hover over that column's header
Pseudo Code Implementation
No response
Prior Art
n/a

Fixed by #201 for release 0.6.1

repo: paddymul/buckaroo


text:
Observer Mode

Let someone just watch the poker session without the ability to vote. This would be great for sharing the screen in Remoto-video-call-sessions.

Maybe call it just "Guest View".


text:
Do you have any scheduled task built in?

Hi do you have schedule task like WP did?

We released the Pagekit Beta today. I close this issue because the code base completely changed. Please open a new issue if it still exists.

authors: ghprod saschadube

repo: pagekit/pagekit

license: mit

license_source: bigquery


text:
IMN-516 Remove expectedApprovalDate from purpose version

[To be merged after #473]
This pull request is for removing the expectedApprovalDate field from purpose version and for deleting the endpoint that is not going to be implemented (/purposes/{purposeId}/versions/{versionId}/update/waitingForApproval)

LGTM, expect for the linter error

authors: beetlecrunch taglioni-r

repo: pagopa/interop-be-monorepo


text:
IMN-605 Authorization router - /support

Re-open of https://github.com/pagopa/interop-be-monorepo/pull/691
Closes IMN-617

In the original PR there still was a comment to address from Zibo: #691 (comment)
I did not review thoroughly the logic/model of the SAML validation & response. Did you perform some tests on SAML files that are expected to fail/pass?

I addressed the comment, yes I used a SAML that I received from the team


text:
Remove nl_pos and point_pos from dispatch.py (not used anymore)

The substitutions $(user:num_lines), $(user:num_lines_rank), $(user:points), $(user:points_rank) replace these dispatch functions
As far as I could see none of the other code uses these functions, but there could be bots out there still using these instead of the substitution based commands

Looks good to me

repo: pajbot/pajbot


text:
Change default BP_JVM_VERSION from 17 to 21

Describe the Enhancement

Change the default java version from 17 to 21 (see RFC 14)

[x] sap-machine: https://github.com/paketo-buildpacks/sap-machine/pull/445
[x] adoptium: https://github.com/paketo-buildpacks/adoptium/pull/493
[x] amazon-corretto: https://github.com/paketo-buildpacks/amazon-corretto/pull/383
[x] alibaba-dragonwell: https://github.com/paketo-buildpacks/alibaba-dragonwell/pull/282
[x] azul-zulu: https://github.com/paketo-buildpacks/azul-zulu/pull/488
[x] bellsoft-liberica: https://github.com/paketo-buildpacks/bellsoft-liberica/pull/726
[x] eclipse-openj9: https://github.com/paketo-buildpacks/eclipse-openj9/pull/463
[x] graalvm: https://github.com/paketo-buildpacks/graalvm/pull/422
[x] microsoft-openjdk: https://github.com/paketo-buildpacks/microsoft-openjdk/pull/280
[x] oracle: https://github.com/paketo-buildpacks/oracle/pull/265
[x] Announcement (comment, blog pr)

Possible Solution

Motivation

RFC 14

Wow! Thank you so much for opening up all these PRs and helping to drive this effort. Much appreciated.
I've got the Slack/Discussion notifications done. And a PR for a blog entry drafted https://github.com/paketo-buildpacks/blog/pull/73. I'm working to get that published ASAP.
The plan will be to merge these towards the end of the month & cut individual releases. Then we'll cut a composite Java release with an updated Bellsoft Liberica late Oct 31st or early on Nov 1.

Ok, those are all merged and I've cut releases of the component buildpacks. We'll merge that change into the Java & Java Native Image buildpacks later this week.

Perfect! thanks @dmikusa and @c0d1ngm0nk3y !

completed in latest build: https://github.com/paketo-buildpacks/java/releases/tag/v17.0.0

authors: anthonydahanne c0d1ngm0nk3y dmikusa

repo: paketo-buildpacks/java


text:
Adds docker pull command

By adding this we will be able to pull some of our more complicated setup into our test suite. It will also facilitate a use case where you want to test with an already released buildpack. For example in our samples or in our buildpackless-builder test
Checklist

[x] I have viewed, signed, and submitted the Contributor License Agreement.
[ ] I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
[x] I have added an integration test, if necessary.
[x] I have reviewed the styleguide for guidance on my code quality.
[x] I'm happy with the commit history on this PR (I have rebased/squashed as needed).

@sophiewigmore I can do some testing really quickly. I am not sure what your concern of DockerImageRemove working it though?

@sophiewigmore I have tested the docker.Pull.Execute() locally and it works. I have also ensured that it works with docker.Image.Remove.Execute() and it does indeed work in that capacity as well!

@ForestEckhardt my concern was just making sure we can remove any images we pull with the existing functionality, which it looks like we can

authors: ForestEckhardt sophiewigmore

repo: paketo-buildpacks/occam


text:
Update stacks documentation

Thanks for contributing. To speed up the process of reviewing your pull request
please provide us with:

A short explanation of the proposed change:
Resolves #50

The stacks documentation was unclear and out of date. I've updated this to include the latest information. Soon-to-come stacks are hidden in a commented-out state in the file.
Please confirm the following:

[x] I have viewed, signed, and submitted the Contributor License Agreement.

[ ] (For UX change) I have made sure this feature works well on both mobile- and desktop-sized screens.

[ ] (For UX change) I have followed BEM naming conventions for my CSS (see README).

[x] (For docs change) I have proofread for spelling, grammar, and accuracy.

[ ] (For docs change) I have used {{< ref >}} and {{< relref >}} shortcodes for internal links (see Hugo docs).

[x] (For docs change) I have checked that all the links I added point to the intended content.

[ ] (For docs change) I have tested that all code samples run correctly as written.

@fg-j I am a little confused by this PR would you want this merged now or are we still waiting for some functionality to be implemented?

It can be merged as-is now. As/when more stacks and builders are available, it can be updated further.

authors: ForestEckhardt fg-j

repo: paketo-buildpacks/paketo-website


text:
Conflicted nodes

It appears there's a conflict with this node: https://github.com/taabata/LCM_Inpaint_Outpaint_Comfy
If your node is included in a workflow and LCM_Inpaint_Outpaint_Comfy is installed while your node isn't, it will default to using LCM_Inpaint_Outpaint_Comfy instead.
Additionally, in a scenario where neither node is installed and a workflow containing your node is loaded, both nodes are visible under "install missing node."
I'm uncertain if the issue lies with your node.

Yes, they also have a node called ImageResize. I don’t think there is an issue with either tool, ComfyUI simply has no way of resolving naming conflicts. And naming conflicts are bound to happen.

It might be why some nodes add a unique ID at the end like "KSampler (Efficient)". That would be useful, I have 4 different ResizeImage node, which can be confusing haha.
Thank for the quick answer sir. I love your node. Very useful 👍

authors: palant poluramus

repo: palant/image-resize-comfyui


text:
fix Attachment.Field Value name

This is a small bugfix for Roboslack's mapping of the Field Attachment's Value property. Roboslack is currently passing the JSON field name text when it should be passing value instead.
Documentation here: https://api.slack.com/docs/message-attachments
Before:

After:

@dotCipher for PR.

Good catch, thanks!

Just fix up the tests and this should be gtg

repo: palantir/roboslack


text:
"ERROR Type literal has only a call signature -- use" suggesting invalid ts code

Bug Report

TSLint version: 5.12.1
TypeScript version: 3.3.1
Running TSLint via: CLI

TypeScript code being linted
declare var process: {
	cwd: Function;
	webpackModule: {
		validate: Function;
		WebpackOptionsValidationError: {
			new(errors: string[]): {
				message: string;
			},
		};
	};
	stdout: {
		write: Function;
	};
	exitCode: number;
};

with tslint.json configuration:
{
    "defaultSeverity": "error",
    "extends": [
        "tslint:recommended"
    ],
    "jsRules": {},
    "rules": {
      "indent": [
        true,
        "tabs",
        4
      ],
      "ban-types": [
        false
      ],
      "no-console": [true, "log"]
    },
    "rulesDirectory": [],
    "linterOptions": {
      "exclude": [
        "node_modules/**",
        "packages/*/node_modules/**"
      ]
    }
}

Actual behavior
It gives me
 ERROR: packages/migrate/index.ts:20:4 - Type literal has only a call signature — use `new(errors: string[]) => {
                                 message: string;
                         },` instead.

That is not valid typescript
packages/migrate/index.ts:20:26 - error TS1005: ':' expected.
    new(errors: string[]) => {

Expected behavior
I think is should suggest to use:
new: (errors: string[]) => {
     message: string;
};

Please, correct me if I'm wrong.

Hey @misterdev! This looks like a duplicate of #4291, which was fixed in 5.12.0. If you update to that version, the incorrect code suggestion should go away.
Closing this issue as duplicate as I can't duplicate it locally, but please do post again if it still shows up!

authors: JoshuaKGoldberg misterdev

repo: palantir/tslint


text:
The default static folder is being ignored if the number of params to the route are 3

@app.route('///path:filename')
@login_required
@nocache
def custom_static(filename, username, date):
path = os.path.join(app.config['CUSTOM_STATIC_PATH'],"username", username, date)
print "Path: {}".format(path)
if os.path.isfile(os.path.join(path, filename)):
return send_from_directory(path, filename)
else:
print "File does not exist: {}".format(filename)
return
Path: ./DataWebserver/username/js/static
File does not exist: bootstrap-datepicker.min.js
enter code here

Please provide a minimal reproducible example, not a random piece of code from your software.

authors: amehta untitaker

repo: pallets/flask


text:
Cant Run a flask server with FLASK_ENV=development or production

Expected Behavior
Should be able to run flask with FLASK_ENV=development or production
Actual Behavior
I get the output

Serving Flask app "simple" (lazy loading)
Environment: production
WARNING: This is a development server. Do not use it in a production deployment.
Use a production WSGI server instead.
Debug mode: on
Restarting with stat
c:\users\Riprock\Projects\simple s&r\venv\scripts\python.exe: No module named C:\Users\Riprock\Projects\Simple S&R\venv\Scripts\flask

Environment

Python version: 3.7.4
Flask version: 1.1.1
Werkzeug version:  0.15.5

I can't seem to get a flask server running after updating to the latest version of Flask and python. Before the update my FLASK_ENV=development and FLASK_DEBUG=1. Then I updated and started to encounter the error. I tried rebuilding my venv and getting the same error.

Duplicate of pallets/werkzeug#1614

Just prefix with "set" for windows and "export" for OSX.
Example: set FLASK_ENV=development
Then, flask run

authors: Azzzizzz Riprock davidism


text:
Flask return a list directly

from flask import Flask

app = Flask(__name__)

@app.route('/')
def index():
    return [1, 2, 3]

if __name__ == '__main__':
    app.run()

It will raise TypeError: The view function did not return a valid response. The return type must be a string, dict, tuple, Response instance, or WSGI callable, but it was a list.
Then I have to do like this.
from flask import Flask, jsonify

app = Flask(__name__)

@app.route('/')
def index():
    return jsonify([1, 2, 3])

if __name__ == '__main__':
    app.run()

And I found that a dict can be jsonify automatically in app.py#L1924
So why does flask can't jsonify a list like a dict ?

Because a sequence of values already has another meaning.

How to auto jsonify a list before make_response()?

How to auto jsonify a list before make_response()?

@app.route('/') is a decorator which adds an endpoint to the app object. So you have two ways to do it.

implement a function decorator.
create a class MyFlask that inherites from class Flask, and override class method route.

I would actually be better to override the make_response method on the Flask class as the route just registers the function and rule.
As David has said though, returning ["Hello", 201] means return "Hello" and the status code 201. So you'll need to somehow distinguish between this and your JSON list response.

So @greyli ended up implementing this in #4672. I'm a bit worried that you can return so many different things that looks somewhat similar but do different things now, but I guess everything is distinct enough still and seems to align with expectations.

tuple is not a list, it will not be serialized to json because it provides headers and status instead
iter[list[str | bytes]] is a streaming response, not json
list is converted to json

authors: DrizztDU davidism pgjones vba34520


text:
fix model parameter is missing

missing argument in example code

Remember to make docs changes on a separate branch, and against the 2.2.x fix branch. Also, there were other code issues in these docs. Addressed in d94634b1

authors: davidism sattamjh


text:
Escape target attribute in the urlize function in utils.py.

See PR #356.

Review please?

Target doesn't really seem like the kind of thing a user would be entering for you, but ok, this seems fine.

authors: darkryder davidism

repo: pallets/jinja


text:
SERVER_SOFTWARE in environ for test client

Would it make sense for the test client Client to add the key SERVER_SOFTWARE to the request environment which it constructs, with a value of something like 'werkzeug test client/$WERKZEUG_VERSION'? Currently the Client sets up a bunch of default value for the environment, which can be overwritten by the creator of the Client object. These include SERVER_NAME, SERVER_PORT, SERVER_HOST, etc., but not SERVER_SOFTWARE. SERVER_SOFTWARE seems to be set by werkzeug itself, by gunicorn and gevent, etc.
Adding this key would make it possible for a request handler to do something with this value, which wouldn't break or have to be worked around, when tests are run using the test client. It would mean that application code which does something different, depending on which server it's run by could handle running as a test in the test client smoothly.
Happy to submit a patch (which would probably be pretty simple).

Could you give a concrete example whete this could be useful?
On 25 April 2017 02:11:24 GMT+02:00, jwg4 notifications@github.com wrote:

Would it make sense for the test client Client to add the key
SERVER_SOFTWARE to the request environment which it constructs, with a
value of something like 'werkzeug test client/$WERKZEUG_VERSION'?
Currently the Client sets up a bunch of default value for the
environment, which can be overwritten by the creator of the Client
object. These include SERVER_NAME, SERVER_PORT, SERVER_HOST, etc., but
not SERVER_SOFTWARE. SERVER_SOFTWARE seems to be set by werkzeug
itself, by gunicorn and gevent, etc.
Adding this key would make it possible for a request handler to do
something with this value, which wouldn't break or have to be worked
around, when tests are run using the test client. It would mean that
application code which does something different, depending on which
server it's run by could handle running as a test in the test client
smoothly.
Happy to submit a patch (which would probably be pretty simple).
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/pallets/werkzeug/issues/1112

--
Sent from my Android device with K-9 Mail. Please excuse my brevity.

Yes, when we deploy a HTTP API, we want to add a generic endpoint which does something like
def get_server_info(request):
    data = {
        'SERVER_SOFTWARE': request.environ['SERVER_SOFTWARE'],
        ...
    }
    ...
    return response(data)

The purpose of this is so that we can query our servers to identify exactly which web server versions, etc they are running on. We would like this code to work without modification when running unit tests.

Is SERVER_SOFTWARE actually a required environment value? If not you should probably use .get() there n - then your test code will work fine as long as it doesn't choke on a None (or whatever default you use)

Tbh I think this stuff should be part of your own code.

Changing behavior based on what server is running seems like a bad pattern. Also, exposing the server software probably isn't safe. It's why you can disable it in Apache/Nginx.

Fair enough.

authors: ThiefMaster davidism jwg4 untitaker

repo: pallets/werkzeug


text:
Endpoint Request Timeout

getting Endpoint Request Timeout error when validating OTP

Inside utils.py generate_token_otp function
add request_header={.....} part given below just after data={....} lines
change the request_header in  requests.post to given below
while not valid_token:         try:             data = {"mobile": mobile,                     "secret": "U2FsdGVkX1+Co0Y47weon+N6VW49nH9oa8wv4KZBaBMt4vD7yhGuncYMK5R4Q6l7O9Nn/VFTmguVTEx+lFVLvw=="             }             request_header={"accept": "application/json, text/plain, */*",                             "accept-encoding": "gzip, deflate, br",                             "accept-language": "en-GB,en-US;q=0.9,en;q=0.8",                             "content-length": "121",                             "content-type": "application/json",                             "origin": "https://selfregistration.cowin.gov.in",                             "referer": "https://selfregistration.cowin.gov.in/",                             "sec-fetch-dest": "empty",                             "sec-fetch-mode": "cors",                             "sec-fetch-site": "cross-site",                             "sec-gpc": "1",                             "user-agent": "Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/90.0.4430.212 Safari/537.36"}             txnId = requests.post(url=OTP_PRO_URL, json=data, headers=request_header, timeout=None)
Solves the issue for me
@pallupz @Dugdudada

yea this issue is resolved in the latest code

authors: Dugdudada pallupz thesct22

repo: pallupz/covid-vaccine-booking


text:
Support built-in dataframe checks and dataframe-level options

Is your feature request related to a problem? Please describe.
Discussion in https://github.com/pandera-dev/pandera/issues/382 has lead to the need to support validation checks at the dataframe level. We'll need to discuss further to converge on the ideal API for this, keeping in mind that we need to optimize for (a) a good UX for the object-based and class-based API and (b) support data synthesis strategies, as all schemas should be able to produce data synthesis strategies that produce valid data.

Jumping off of this comment: https://github.com/pandera-dev/pandera/issues/382#issuecomment-759025907
To decompose this issue into 2 problems:
Should we have keyword validation options in the DataFrameSchema constructor?

One issue with 2. is that it could bloat the api, especially SchemaModel. Afterwards we could imagine other checks that could be done dataframe-wide, where do we draw the line?

I think the slope isn't so slippery here. On a case-by-case basis we can determine whether a validation check is so fundamental that it should be a keyword option.
For example, the pandas_dtype and nullable options in SeriesSchemaBase could be implemented as a Check, however it is intertwined with how to implement the validation routine when it comes to type-coercion. The built-in Checks, on the other hand, are self-contained and don't really interact with any other part of the validation process besides checking the contents of the dataframe/series.
Similarly, the min number of rows in a dataframe is (i) a common use case, (ii) determines whether the validated dataframe can be empty (min_rows = 0 means it can, which ties nicely into https://github.com/pandera-dev/pandera/issues/332), and (iii) interacts with the data synthesis strategy because the size argument would need to be at least min_rows. I think this is enough to justify min_rows as a keyword option in the DataFrameSchema constructor.
How to best-support built-in checks in the SchemaModel API?
That said, we should also support built-in checks at the dataframe-level. I believe all of the built-in Checks currently implemented support both a dataframe and column/series input (will need to refactor the types, e.g. https://github.com/pandera-dev/pandera/blob/master/pandera/checks.py#L460, which are mis-leading). The new extensions module introduced the concept of supported_types for checks, which should probably be folded into the Check class.
pa.DataFrameSchema(..., checks = pa.Check.NotEmpty())

class Schema(pa.SchemaModel):
    class Config:
        checks = [pa.Check.NotEmpty()] # new

I think this solution works, my concern here is that there would then be a discrepency between how built-in checks are expressed in Fields and how they're expressed at the dataframe-level.
Field(gt=100)

# vs

Field(checks=[pa.Check.gt(100)])

I wonder if we could follow this by doing something like:
class Schema(pa.SchemaModel):
    class Config:
        # support built-in checks as config attributes
        gt = 0
        lt = 100

Jumping off of this comment: https://github.com/pandera-dev/pandera/issues/382#issuecomment-759025907
To decompose this issue into 2 problems:
Should we have keyword validation options in the DataFrameSchema constructor?

One issue with 2. is that it could bloat the api, especially SchemaModel. Afterwards we could imagine other checks that could be done dataframe-wide, where do we draw the line?

I think the slope isn't so slippery here. On a case-by-case basis we can determine whether a validation check is so fundamental that it should be a keyword option.
For example, the pandas_dtype and nullable options in SeriesSchemaBase could be implemented as a Check, however it is intertwined with how to implement the validation routine when it comes to type-coercion. The built-in Checks, on the other hand, are self-contained and don't really interact with any other part of the validation process besides checking the contents of the dataframe/series.
Similarly, the min number of rows in a dataframe is (i) a common use case, (ii) determines whether the validated dataframe can be empty (min_rows = 0 means it can, which ties nicely into https://github.com/pandera-dev/pandera/issues/332), and (iii) interacts with the data synthesis strategy because the size argument would need to be at least min_rows. I think this is enough to justify min_rows as a keyword option in the DataFrameSchema constructor.
How to best-support built-in checks in the SchemaModel API?
That said, we should also support built-in checks at the dataframe-level. I believe all of the built-in Checks currently implemented support both a dataframe and column/series input (will need to refactor the types, e.g. https://github.com/pandera-dev/pandera/blob/master/pandera/checks.py#L460, which are mis-leading). The new extensions module introduced the concept of supported_types for checks, which should probably be folded into the Check class.
pa.DataFrameSchema(..., checks = pa.Check.NotEmpty())

class Schema(pa.SchemaModel):
    class Config:
        checks = [pa.Check.NotEmpty()] # new

I think this solution works, my concern here is that there would then be a discrepency between how built-in checks are expressed in Fields and how they're expressed at the dataframe-level.
Field(gt=100)

# vs

Field(checks=[pa.Check.gt(100)])

I wonder if we could follow this by doing something like:
class Schema(pa.SchemaModel):
    class Config:
        # support built-in checks as config attributes
        gt = 0
        lt = 100

Should we have keyword validation options in the DataFrameSchema constructor?

I agree with all your points about adding min_rows :+1:

How to best-support built-in checks in the SchemaModel API?

Built-in checks as config attributes is indeed more consistent. We should interpret unknown attributes as registered checks. At the moment, unknown attributes are ignored.
Side note, we should encourage this style if we add more attributes:
import pandera as pa
from pandera.model import BaseConfig

class Schema(pa.SchemaModel):
    class Config(BaseConfig): # IDE can help auto-complete valid attributes
        gt = 0
        lt = 100

Should we have keyword validation options in the DataFrameSchema constructor?

I agree with all your points about adding min_rows :+1:

How to best-support built-in checks in the SchemaModel API?

Built-in checks as config attributes is indeed more consistent. We should interpret unknown attributes as registered checks. At the moment, unknown attributes are ignored.
Side note, we should encourage this style if we add more attributes:
import pandera as pa
from pandera.model import BaseConfig

class Schema(pa.SchemaModel):
    class Config(BaseConfig): # IDE can help auto-complete valid attributes
        gt = 0
        lt = 100

Are there plans for making global checks serializable? I'd like to use pandera as a data definition on disk of sorts. Right now, global checks are just dropped when calling to_yaml. It would be nice to save them as keywords and look up from the extension API, but as far as I know, there is no way to do this.

Hey @antonl, I had to double check, but any check registered via extensions.register_check_method should be serializable as a yaml file or python script, see this post I just made: https://github.com/pandera-dev/pandera/discussions/417.
I did find a bug in the current serialization implementation that errors out when providing pandas_dtype arguments that are not of type PandasDtype, so for now you'll have to use e.g. pa.Int, pa.Float, pa.String, etc. instead of python built-in types, pandas type string aliases, or numpy types. Will make an issue and fix for this.

Hi @cosmicBboy!  Thank you for your quick reply, I really like the library! I've posted a test case to demonstrate what I meant in the discussion you've linked.

@jeffzi @cosmicBboy I'm interested in working on this.
How would you support checks with multiple parameters?
import pandera as pa
from pandera.model import BaseConfig

class Schema(pa.SchemaModel):
    class Config(BaseConfig): # IDE can help auto-complete valid attributes
        # zero_stat_check ?
        one_stat_check = 0
        # two_stat_check = ("a", 2)? {"first": "a", "second": 2}?

thanks @antonl, work on this would be much appreciated!
Currently the way these are handled for Field checks is with a dict.
class Schema(pa.SchemaModel):
    col: Series[int] = pa.Field(in_range={"min_value": 0, "max_value": 100})

So the {"first": "a", "second": 2} makes sense, although the tuple idea also makes sense, maybe that syntax should be supported too (thoughts @jeffzi?)
Another thought I had about this issue is I wonder whether built-in dataframe checks make sense to specify in Config. This may be over-engineering it, but semantically it would make more sense to put in a different class, where Config should be reserved for configuration options.
class Schema(pa.SchemaModel):
    class Checks(GlobalChecks):
        eq = 0
        ....

...the tuple idea also makes sense and potentially more concise in some cases,

Agreed, we could interpret a tuple as positional arguments and dict as keyword arguments.
Regarding DataFrame-level checks (global checks). I'm reluctant to add another inner class. That's not very pythonic (as far as I know). Config was inspired by pydantic to increase adoption, and I couldn't find a better alternative.
Config mirrors DataFrameSchema arguments. Adding built-in checks would be the exception but it's a similar concept to built-in checks in Field so it should be intuitive.
@antonl Your help is appreciated indeed :tada: Any thoughts about the inner class idea?

Regarding the inner class idea, I'm not a fan. Most python people don't even know you can declare classes like this.
How about keeping the same field syntax for cols/index and making a class decorator to enable this sugar,
@with_checks(pa.Check.min_rows(5), ...)
class Schema(pa.SchemaModel):
    col: Series[int] = pa.Field(in_range={"min_value": 0, "max_value": 100})

The implementation would just attach a _checks/checks field to the type. Subclassing would just append to the field if it exists.
You could even enable something like this,
@with_checks(min_rows={"count": 5})
class Schema(pa.SchemaModel):
   ...

That maintains the feel of Field checks as desired.

I think for consistency of the SchemaModel interface, I'd like to keep two requirements:

the user doesn't have to worry about Check objects because checks are either built-in or expressed as methods decorated with @check or @dataframe_check.
minimize the surface area of how checks are expressed. Currently its with Field(<builtin_check>=...), @check methods, and registering custom checks with the extensions API and then using them as built-ins in Field.

Regarding DataFrame-level checks (global checks). I'm reluctant to add another inner class.

Regarding the inner class idea, I'm not a fan

I do agree, but I figured it was worth considering 🤔

That's not very pythonic (as far as I know).

As an aside, my understanding of what is "pythonic" has changed so many times over the years I don't really even know what it means anymore 😅
Anyway, I'm inclined to stick with defining built-in dataframe checks in Config with the same behavior as Field: built-in and registered checks can be specified as attributes, where custom checks are expressed as @dataframe_check methods.

Let me know if #478 looks acceptable, @cosmicBboy and @jeffzi! It's a little weird that we have to specify stuff on the Config class implicitly, but it is easy enough to implement.
We should perhaps have a "best practices" section in the doc that highlights the difference between methods decorated with dataframe_check and through Config. Do we recommend one or the other?

Best practices and cookbook sections would be great.

It's a little weird that we have to specify stuff on the Config class implicitly,

I kind of agree but Field can also implicitly swallow custom checks. Perhaps it feels less natural with the inner class Config because this mechanism is  uncommon.
An alternative to the inner class could be a special attribute __config__ that must be assigned a Config class.

class Base(pa.SchemaModel):
    a: Series[int]
    __config__ = Config(
        name="Base schema",
        coerce=True,
        ordered=True,
        multiindex_coerce=True,
        multiindex_strict=True,
        multiindex_name="mi",
    )

Just testing the water, I can open a discussion if any of you @antonl @cosmicBboy think something like that is worth investigating.

We should perhaps have a "best practices" section in the doc that highlights the difference between methods decorated with dataframe_check and through Config. Do we recommend one or the other?

Imho, @check and @dataframe_check decorators are for defining one-offs, similarly to a Check defined with a lambda function in the DataFrameSchema api, or at least checks specific to a given model. Registered checks are for reusable checks.

Sorry I wasn't clear @jeffzi . I think the Config class is fine. I was just concerned that there are two ways to add dataframe checks (using methods and adding keys to Config), and they look totally different.
Also, the two ways have trade-offs: one is a one-off, but prevents serialization, and the other is global.

authors: antonl cosmicBboy jeffzi

repo: pandera-dev/pandera


text:
cannot install extension on paneron alpha 18

Hi @strogonoff, I am HSU student who is working on address profile project.
We are faced a problem that when we trying to build an extension from the latest version of paneron/extension-template-registry using Paneron v1 (alpha18).
By this command env PANERON_DEV_PLUGIN=template-registry_ yarn dev, and this extension is placed on /Users/beemak/Library/Application Support/Electron/plugins/@riboseinc/paneron-extension-template-registry_
The paneron will notify that @riboseinc/paneron-extension-template-registry_ not installed error.

The terminal response:
    type: 'message',
    data: {
      type: 'error',
      uid: 14,
      error: {
        __error_marker: '$$error',
        message: "Failed to get package '@riboseinc/paneron-extension-template-registry_' Response error 404 Not Found",
        name: 'Error',
        stack: "Error: Failed to get package '@riboseinc/paneron-extension-template-registry_' Response error 404 Not Found\n" +
          '    at Object.eval (webpack-internal:///./node_modules/live-plugin-manager/dist/src/httpUtils.js:55:19)\n' +
          '    at Generator.next (<anonymous>)\n' +
          '    at fulfilled (webpack-internal:///./node_modules/live-plugin-manager/dist/src/httpUtils.js:5:58)\n' +
          '    at processTicksAndRejections (internal/process/task_queues.js:97:5)'
      }
    }
  }

Even we have tried to use the default provided extension e.g. paneron-extension-geodetic-registry, it will still notify that @riboseinc/paneron-extension-geodetic-registry not installed error.

However, when we try to run paneron with this command yarn dev.
The default provided extension e.g. paneron-extension-geodetic-registry will launch successfully.

Thanks @beebeebeeebeee for the report. @strogonoff could you help? This would be a good chance to update the developer docs too.

Thanks @beebeebeeebeee for the report. @strogonoff could you help? This would be a good chance to update the developer docs too.

Sorry, We have misunderstood the step and sloved the problem now. We found that the package.json name columns should be same with the extension folder name. And the extension works fine now.

Sorry, We have misunderstood the step and sloved the problem now. We found that the package.json name columns should be same with the extension folder name. And the extension works fine now.

authors: beebeebeeebeee ronaldtse

repo: paneron/extension-kit


text:
Adding GeoPHP to the GIS section

Project name: GeoPHP
Project website/repository: https://github.com/phayes/geoPHP
License: This library is open-source and dual-licensed under both the Modified BSD License and GPLv2.

Checklist for new projects:

[x] The project is open-source and accessible.
[x] Searched the existing entries to make sure this is not a duplicate.
[x] Contains only a single addition (make separate PRs if adding more than one).
[x] Added the link to the bottom of the relevant category.
[x] Add icon from the media/icon/ folder if applicable (like ![Python](media/icon/python.png) ).
[x] Created a new category only if necessary.
[x] Checked spelling and grammar.
[x] Removed trailing whitespace and periods.
[x] Confirm the dash – is not a minus -.
[x] Used title-casing (AP style) for project name.

Thanks @bogomil!

authors: bogomil rabernat


text:
[FEAT] Add initialFetchSize and caseSensitiveSearch field to useSelect's props

Is your feature request related to a problem? Please describe.

useSelect is by default only fetch 10 initial data candidates, in my case i have more than 10 candidates to show under the select component, would be nice if we can have more.

useSelect search results seems to be only returning elements filtered with 'contains' operator. Also would be nice to have option to use 'containss' operator.

Describe the solution you'd like

add initialFetchSize inside UseSelectProps that specify initial size of data to fetch.
add caseSensitiveSearch inside UseSelectProps that specify whether the search should be case sensitive.

Not quite sure how to implement it as i haven't skim through useSelect code yet.
Please correct me if i'm missing something. Thank you.

Hey @RayhanHamada ,
Thanks for the feature request. We'll get it in our backlog as soon as possible!

Hey @RayhanHamada ,
We've released 2.5.0. We've added [fetchSize](https://refine.dev/docs/api-references/hooks/field/useSelect/#fetchsize) and [onSearch](https://refine.dev/docs/api-references/hooks/field/useSelect/#onsearch) support!

authors: RayhanHamada omeraplak

repo: pankod/refine


text:
因为旧版可以配合脚本儿一键同步步数给多个小号。

这个需求真奇怪，都是求适配新版的多，还有来求适配旧版的
Originally posted by @klever1988 in https://github.com/pansong291/XQuickEnergy/issues/45#issuecomment-538709058

欢迎进QQ辅助群交流：323175670


text:
fix: OneLogin detections were comparing int to str (event_type_id)

Background
Customer noticed that since changing the OneLogin schema, several of our provided detections no longer function as intended.
Changes

The schema changed the event_type_id column to a string, which caused detections to fail when comparing values.

Testing

Changed the python code to cast the event_type_id value to a string, then compared to a string
Ran the unaltered unit tests, which still have the event_type_id value as an integer, to ensure that the changes are backwards compatible (for users with the old schema version).
Updated the unit tests to have event_type_id values as strings, as the new schema would have them
Ran the unit tests again

Ah crap, apparently a bunch of deleted files ended up on this commit... that wasn't intentional. I'll see if I can fix that

Okay I've re-added all the files I deleted. Hopefully that's the last time I forget what branch I'm working on...

repo: panther-labs/panther-analysis


text:
Edge Drag

I do not speak English well, so I use Google Translate.
I modified it so that I can change the target vertex by dragging the edge.
Edge routing is not yet applied when you drag.
Please acknowledge the inexperience of using Github.

Hello! Looks very interesting. Have to check the code as there are too much changes. Seems like you have different code style so there are many of blanks and refactoring, including the classes not affected by described feature.

authors: LaborJos panthernet

repo: panthernet/GraphX


text:
Game Attendance Data Availability?

Wanted to reach out to see if attendance data was available through the API

@msussman I'll poke around and see what data MLB provides.

I'm unable to find anything in the XML files around attendance, though the venue name is widely available.

I'm digging around in their new stats API statsapi.mlb.com/docs but the lack of documentation isn't getting me very far.
I did find attendance in their live game endpoint, buried in an info property, here's a Dodgers @ Marlins game in 2016
 "info": [
        {
          "label": "Game Scores",
          "value": "Kershaw 41; Fernandez 84."
        },
        {
          "label": "HBP",
          "value": "Suzuki, I (by Fields, J)."
        },
        {
          "label": "Pitches-strikes",
          "value": "Kershaw 66-46; Coleman 10-6; Norris, B 15-7; Howell 1-1; Fields, J 9-3; Avilan 20-12; Ravin 17-11; Liberatore 7-5; Fernandez 102-66; Barraclough 14-11; Rodney 16-11; Ramos 11-8."
        },
        {
          "label": "Groundouts-flyouts",
          "value": "Kershaw 3-1; Coleman 1-1; Norris, B 1-1; Howell 0-0; Fields, J 0-0; Avilan 3-0; Ravin 1-0; Liberatore 0-2; Fernandez 4-1; Barraclough 2-0; Rodney 0-0; Ramos 0-1."
        },
        {
          "label": "Batters faced",
          "value": "Kershaw 14; Coleman 3; Norris, B 4; Howell 1; Fields, J 2; Avilan 5; Ravin 3; Liberatore 3; Fernandez 27; Barraclough 4; Rodney 3; Ramos 3."
        },
        {
          "label": "Inherited runners-scored",
          "value": "Howell 2-1; Fields, J 2-1; Avilan 3-0; Ramos 2-0."
        },
        {
          "label": "Umpires",
          "value": "HP: Brian Knight. 1B: Tony Randazzo. 2B: Bill Miller. 3B: Tom Woodring."
        },
        {
          "label": "Weather",
          "value": "77 degrees, roof closed."
        },
        {
          "label": "Wind",
          "value": "0 mph, None."
        },
        {
          "label": "First pitch",
          "value": "7:11 PM."
        },
        {
          "label": "T",
          "value": "3:08."
        },
        {
          "label": "Att",
          "value": "22,940."
        },
        {
          "label": "Venue",
          "value": "Marlins Park"
        },
        {
          "label": "September 9, 2016"
        }
      ],

It might be available through some smaller endpoints as this one is ENORMOUS, but would require some more research. As it is, I'm thinking this would be a good feature for mlbgame v3 (Stats API usage) since this info doesn't appear to be available in their XML files.

It's available through rawboxscore.xml. Here's a random example: http://gd2.mlb.com/components/game/mlb/year_2017/month_04/day_16/gid_2017_04_16_milmlb_cinmlb_1/rawboxscore.xml

@trevor-viljoen If you have time, could you go ahead and add that in a PR. I don't really have much time but I could get to it if you can't.

@panzarino I'll try to find some time to do it this week. I'll also take a look at rawboxscore vs boxscore and see how different they are from each other. The fix might be as simple as using rawboxscore instead of boxscore.

Is anyone working on this? I've done some work with MLB's rawboxscore.xml and boxscore.xml in another project. I'd be interested in doing this.

Have at it, I could use another release soon.

Which class should the attendance attribute go in? Each of the classes is associated with a corresponding xml file in the MLB API: Overview goes with linescore.xml, GameBoxScore goes with boxscore.xml, and GameScoreboard goes with scoreboard.xml. I think attendance data would fit the best in the Overview class, where were you expecting it to go?

@Pertempto I think that it would fit well with the other stats provided by the Overview class.

Great! I'm working on it now, and I'll probably have a pull request in the next few hours.

I've implemented the attendance feature, but I was wondering if I should add all the top level attributes from the rawboxscore.xml to the game overviews. Here is an example. This would add useful data like the weather, wind, elapsed time, and exact start time. The only problem I found is that rawboxscore.xml includes a venue_name attribute, while the Overview class already has an venue attribute. Is it bad to have two attributes with the same value? Maybe I should add all the attributes from rawboxscore.xml and remove the venue_name attribute.

@Pertempto It would be great if you could add that. It is fine to have duplicate attributes, just report everything.

@panzarino Where am I supposed to "report everything"? Is it as simple as adding the new attributes to the Overview docstring or do I need to document these new attributes somewhere else as well?

I've created a pull request with all the new attributes. #71

Merged

Thanks all.  When are you planning on releasing a new version?
On Sat, Mar 24, 2018, 3:47 PM Zach Panzarino notifications@github.com
wrote:

Merged
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/panzarino/mlbgame/issues/68#issuecomment-375919863,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AIEW6xH-GIbpdqnTpT0Qrg5JYbTn_eMQks5thqLfgaJpZM4Sa9QM
.

I could definitely use a 2.5. Only missing piece from the LED board before the regular season starts is the probable starters which is just waiting for a new tag.

I'll work on updating a few things and hopefully pushing out a new release in the coming days.

Sounds great!  Looking forward to checking out the update.
On Sun, Mar 25, 2018 at 2:05 PM Zach Panzarino notifications@github.com
wrote:

I'll work on updating a few things and hopefully pushing out a new release
in the coming days.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/panzarino/mlbgame/issues/68#issuecomment-375990471,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AIEW63td8NwGtqNfUTM77JNJIkNMn4Jwks5th9xmgaJpZM4Sa9QM
.

@msussman Sorry to disappoint, but I just looked at my schedule and I have almost no time this week so I'll have to push it back to sometime next week.

No worries.  I won't need it in earnest until next month
On Mon, Mar 26, 2018, 3:46 PM Zach Panzarino notifications@github.com
wrote:

@msussman https://github.com/msussman Sorry to disappoint, but I just
looked at my schedule and I have almost no time this week so I'll have to
push it back to sometime next week.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/panzarino/mlbgame/issues/68#issuecomment-376288698,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AIEW67L835ZdkRcU5B8m2Vq5pc8PqsGWks5tiUWhgaJpZM4Sa9QM
.

@panzarino, I just updated to the new release and am finding some issues with the attendance implementation.

Mixed Data Times: When attendance is data is missing due to a double header, the attendance attribute is set to 0 (ex. Gameid 2011/07/02/pitmlb-wasmlb-1,  'attendance': 0), but when it's populated it's a string (ex. '2011/07/02/pitmlb-wasmlb-2', 'attendance': '39,636')

Game Ids not found with Game_Overview method:  I had pulled all games for the Nationals 2010-2018 previously without issue, but when I tried with the new release I'm getting quite a few games where the Game_Overview method returns this error "ValueError: Could not find a game with that id."  Example  - 2010_04_03_bosmlb_wasmlb_1

@Pertempto could you look into this?

@panzarino just updated my local repo, hopefully I'll be able to look at it in next week.

Sorry, but I was busy last week and wasn't able to work on this. Someone else might want to do this because I can't promise that I'll have the time.

authors: Pertempto ajbowler msussman panzarino trevor-viljoen

repo: panzarino/mlbgame


text:
Support static peers

Describe the feature
#9201 added a new peerkind: static peers

// Static nodes are used as pre-configured connections which are always
// maintained and re-connected on disconnects.

we should prefer connections to static peers by ranking them higher:
https://github.com/paradigmxyz/reth/blob/2a9fa4869e658ca89e050d0d985a7ccbfa360bfa/crates/net/network/src/peers.rs#L804-L814
and only penalize them temporarily like we do for trusted peers:
https://github.com/paradigmxyz/reth/blob/2a9fa4869e658ca89e050d0d985a7ccbfa360bfa/crates/net/network/src/peers.rs#L376-L379
https://github.com/paradigmxyz/reth/blob/2a9fa4869e658ca89e050d0d985a7ccbfa360bfa/crates/net/network/src/peers.rs#L447-L447
TODO

add same exemptions for static peers as for trusted wrt banning/reputation
prefer connections to static peers

Additional context
No response

pick this issue

just following up @jsvisa
do you have bandwidth for this?
this feature is not urgent, just nice to have.

Sorry not have started yet, I'm going to implement it this week

authors: jsvisa mattsse

repo: paradigmxyz/reth


text:
chore(rpc): decompose function reth_rpc_types_compat::from_block_full

Extracts code for assembling transactions from reth_rpc_types_compat::block::from_block_full, into new function reth_rpc_types_compat::transaction::from_block_parts.
Needed for https://github.com/paradigmxyz/reth/pull/7416

closing in favour changes introduced as part of https://github.com/paradigmxyz/reth/pull/10600

closing in favour changes introduced as part of https://github.com/paradigmxyz/reth/pull/10600


text:
feat: add rate limit implementation

Add a rate limit implementation.
This can be used to enforce rate limits like max 10 req / s
Will be used to rate limit DNS lookups

added async wait
there's no tokio::time::advance though

Codecov Report

Merging #813 (6c1907d) into main (2e87017) will increase coverage by 0.13%.
The diff coverage is 87.35%.

@@            Coverage Diff             @@
##             main     #813      +/-   ##
==========================================
+ Coverage   72.84%   72.98%   +0.13%
==========================================
  Files         274      275       +1
  Lines       28533    28624      +91
==========================================
+ Hits        20784    20890     +106
+ Misses       7749     7734      -15

Flag
Coverage Δ

unit-tests
72.98% <87.35%> (+0.13%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

crates/net/common/src/lib.rs
100.00% <ø> (ø)

crates/net/common/src/ratelimit.rs
87.35% <87.35%> (ø)

crates/net/eth-wire/src/capability.rs
61.79% <0.00%> (-1.13%)
:arrow_down:

crates/net/network/src/session/active.rs
83.39% <0.00%> (-0.40%)
:arrow_down:

bin/reth/src/node/mod.rs
0.00% <0.00%> (ø)

crates/net/network/src/peers/manager.rs
82.40% <0.00%> (+0.09%)
:arrow_up:

crates/net/network/src/peers/reputation.rs
65.78% <0.00%> (+2.63%)
:arrow_up:

bin/reth/src/config.rs
63.26% <0.00%> (+63.26%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

authors: codecov-commenter mattsse


text:
Remove stress test on Travis CI for PKCS 11

Adds a command line option on the CI script to be able to not execute
the stress tests.
On Travis CI, the stress test fails for the PKCS 11 provider, see #116.
This commit disables them until the reason is found.
Signed-off-by: Hugues de Valon hugues.devalon@arm.com

Does travis not pick up the changes from the branch? it seems to have failed

Does travis not pick up the changes from the branch? it seems to have failed

Yes you are right, it was failing during the persistence tests for the PKCS 11 provider (Broken pipe) and the stress tests for the Mbed Crypto provider.
I am curious to see if this problem is because the timeout on the service side for the tests is too small. I am trying to put it to 5 seconds to match the timeout on the test client.

When trying to write the response on the stream to the client, the service sometimes has a Broken Pipe error. This might be due because, for some reason, the client disconnects from the socket.

authors: hug-dev ionut-arm

repo: parallaxsecond/parsec


text:
Dancing Tabs

Describe the bug
When I first start platform.bible, I see the first tab is shrinking towards the left which causes the other two tabs to move left and then it grows and pushes all of the tabs back to the right. It does this over and over so that the tabs look like they are flickering/dancing.
To Reproduce
Start platform.bible on debug mode.
Look at the About tab (and Test Tab two and Test Tab One tabs) in the lower left
Expected behavior
The About tab should not keep adjusting its size forever. It should be stable.

https://github.com/paranext/paranext-core/assets/4229598/d8ba195f-6bf7-4370-854b-c0e4c0876786

FYI this issue is a continuation of #66. Good to have this filed.
Ira filed a bug report with rc-dock at https://github.com/ticlo/rc-dock/issues/215

Do be aware that if you remove our CSS customizations from rc-dock it doesn't happen (or maybe only rarely). So we will likely need to fix this in rc-dock ourselves. In the issue I filed above I noted that the first step (which maybe enough) is to update rc-dock to use the latest rc-tabs.

authors: irahopkinson katherinejensen00 tjcouch-sil tombogle

repo: paranext/paranext-core


text:
ci: Support newest version of Minikube

The auto-upgrade is broken; apparently, some changes on Minikube causes our end-to-end tests to fail https://github.com/parca-dev/parca-agent/pull/1425
The root cause needs to be tracked down, and we should check whether we can upgrade to the most recent minikube version.
(I haven't even tested to upgrade the newest version locally).

Submitted the fixes here: medyagh/setup-minikube#74

One more bug before we can upgrade: medyagh/setup-minikube#110

Worked around upstream issue for now

authors: kakkoyun maxbrunet

repo: parca-dev/parca-agent


text:
runAndWait() doesn't return when calling say(..) with umlauts

engine = pyttsx.init()
engine.say("Bächtig möse")
engine.runAndWait() # <--- This call won't return

Hi, was just wondering why my program doesn't continue. Of course, quick fix is to just replace such characters before calling say(..). Don't know if there are other characters causing that behavior.
Tested with python 2.7 under Windows 7

Have you tried u"Bächtig möse"?
What you posted is not actually a valid Python 2.7 string (it will decode the 14 UTF-8 bytes into a 14 byte ASCII string) without the u prefix.

x = "Bächtig möse"
x
'B\xc3\xa4chtig m\xc3\xb6se'
len(x)
14
x = u"Bächtig möse"
x
u'B\xe4chtig m\xf6se'
len(x)
12

I have tested with the u prefix on my fork and know it works there but I cannot confirm if that is because of changes I have made on the fork or simply this u prefix issue.

authors: datenstrudel westonpace

repo: parente/pyttsx

license: isc


text:
Uncaught Error: new BigNumber() number type has more than 15 significant digits

When I go to "Send Ether" with an account balance of 0.998957 and enter an amount of 11111111111111111 (17 digits or more) it crashes with error
Uncaught Error: new BigNumber() number type has more than 15 significant digits: 11111111111111112
    at raise (bignumber.js:1190)
    at new BigNumber (bignumber.js:262)
    at toWei (wei.js:36)
    at Send._this.preValidate (TxForm.js:170)
    at gas (TxForm.js:52)
    at final-form-calculate.es.js:50
    at Array.forEach (<anonymous>)
    at runUpdates (final-form-calculate.es.js:48)
    at final-form-calculate.es.js:80
    at Array.forEach (<anonymous>)
    at final-form-calculate.es.js:78
    at Array.forEach (<anonymous>)
    at final-form-calculate.es.js:64
    at Object.batch (final-form.es.js:799)
    at form.subscribe.values (final-form-calculate.es.js:28)
    at final-form.es.js:319
    at notifySubscriber (final-form.es.js:394)
    at final-form.es.js:404
    at Array.forEach (<anonymous>)
    at notify (final-form.es.js:400)
    at notifyFormListeners (final-form.es.js:781)
    at final-form.es.js:842
    at runValidation (final-form.es.js:656)
    at Object.change (final-form.es.js:840)
    at Object.change (final-form.es.js:931)
    at onChange (react-final-form.es.js:378)
    at HTMLUnknownElement.callCallback (react-dom.development.js:100)
    at Object.invokeGuardedCallbackDev (react-dom.development.js:138)
    at Object.invokeGuardedCallback (react-dom.development.js:187)
    at Object.invokeGuardedCallbackAndCatchFirstError (react-dom.development.js:201)
    at executeDispatch (react-dom.development.js:461)
    at executeDispatchesInOrder (react-dom.development.js:483)
    at executeDispatchesAndRelease (react-dom.development.js:581)
    at executeDispatchesAndReleaseTopLevel (react-dom.development.js:592)
    at Array.forEach (<anonymous>)
    at forEachAccumulated (react-dom.development.js:560)
    at runEventsInBatch (react-dom.development.js:723)
    at runExtractedEventsInBatch (react-dom.development.js:732)
    at handleTopLevel (react-dom.development.js:4476)
    at batchedUpdates$1 (react-dom.development.js:16659)
    at batchedUpdates (react-dom.development.js:2131)
    at dispatchEvent (react-dom.development.js:4555)
    at interactiveUpdates$1 (react-dom.development.js:16714)
    at interactiveUpdates (react-dom.development.js:2150)
    at dispatchInteractiveEvent (react-dom.development.js:4532)
raise @ bignumber.js:1190
BigNumber @ bignumber.js:262
toWei @ wei.js:36
Send._this.preValidate @ TxForm.js:170
gas @ TxForm.js:52
(anonymous) @ final-form-calculate.es.js:50
runUpdates @ final-form-calculate.es.js:48
(anonymous) @ final-form-calculate.es.js:80
(anonymous) @ final-form-calculate.es.js:78
(anonymous) @ final-form-calculate.es.js:64
batch @ final-form.es.js:799
form.subscribe.values @ final-form-calculate.es.js:28
(anonymous) @ final-form.es.js:319
notifySubscriber @ final-form.es.js:394
(anonymous) @ final-form.es.js:404
notify @ final-form.es.js:400
notifyFormListeners @ final-form.es.js:781
(anonymous) @ final-form.es.js:842
runValidation @ final-form.es.js:656
change @ final-form.es.js:840
change @ final-form.es.js:931
onChange @ react-final-form.es.js:378
callCallback @ react-dom.development.js:100
invokeGuardedCallbackDev @ react-dom.development.js:138
invokeGuardedCallback @ react-dom.development.js:187
invokeGuardedCallbackAndCatchFirstError @ react-dom.development.js:201
executeDispatch @ react-dom.development.js:461
executeDispatchesInOrder @ react-dom.development.js:483
executeDispatchesAndRelease @ react-dom.development.js:581
executeDispatchesAndReleaseTopLevel @ react-dom.development.js:592
forEachAccumulated @ react-dom.development.js:560
runEventsInBatch @ react-dom.development.js:723
runExtractedEventsInBatch @ react-dom.development.js:732
handleTopLevel @ react-dom.development.js:4476
batchedUpdates$1 @ react-dom.development.js:16659
batchedUpdates @ react-dom.development.js:2131
dispatchEvent @ react-dom.development.js:4555
interactiveUpdates$1 @ react-dom.development.js:16714
interactiveUpdates @ react-dom.development.js:2150
dispatchInteractiveEvent @ react-dom.development.js:4532
index.js:1851 Refused to execute inline script because it violates the following Content Security Policy directive: "default-src 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-hfwx1vycHF5eMRHxd8KVOWB4EykA4iqXT24HqLnyLU0='), or a nonce ('nonce-...') is required to enable inline execution. Note also that 'script-src' was not explicitly set, so 'default-src' is used as a fallback.

loadingIframe.onload @ index.js:1851
update @ index.js:1855
handleRuntimeError @ index.js:1807
(anonymous) @ index.js:1792
(anonymous) @ index.js:1931
index.js:2178 Error: new BigNumber() number type has more than 15 significant digits: 11111111111111112
    at raise (bignumber.js:1190)
    at new BigNumber (bignumber.js:262)
    at toWei (wei.js:36)
    at Send._this.preValidate (TxForm.js:170)
    at TxForm.js:200
    at flush (index.js:62)
__stack_frame_overlay_proxy_console__ @ index.js:2178
(anonymous) @ TxForm.js:220
flush @ index.js:62
setTimeout (async)
debounced @ index.js:40
runRecordLevelValidation @ final-form.es.js:508
runValidation @ final-form.es.js:604
change @ final-form.es.js:840
change @ final-form.es.js:931
onChange @ react-final-form.es.js:378
callCallback @ react-dom.development.js:100
invokeGuardedCallbackDev @ react-dom.development.js:138
invokeGuardedCallback @ react-dom.development.js:187
invokeGuardedCallbackAndCatchFirstError @ react-dom.development.js:201
executeDispatch @ react-dom.development.js:461
executeDispatchesInOrder @ react-dom.development.js:483
executeDispatchesAndRelease @ react-dom.development.js:581
executeDispatchesAndReleaseTopLevel @ react-dom.development.js:592
forEachAccumulated @ react-dom.development.js:560
runEventsInBatch @ react-dom.development.js:723
runExtractedEventsInBatch @ react-dom.development.js:732
handleTopLevel @ react-dom.development.js:4476
batchedUpdates$1 @ react-dom.development.js:16659
batchedUpdates @ react-dom.development.js:2131
dispatchEvent @ react-dom.development.js:4555
interactiveUpdates$1 @ react-dom.development.js:16714
interactiveUpdates @ react-dom.development.js:2150
dispatchInteractiveEvent @ react-dom.development.js:4532

Relates to https://github.com/paritytech/fether/issues/247

Other PRs have already fixed issue #298 and now avoid encountering Uncaught Error: [format/input::inNumber16] the given number is not an integer

repo: paritytech/fether


text:
Hide Fether windows by left clicking on the taskbar icon

On Linux, clicking the taskbar icon (left or right click) doesn't hide Fether right away, it shows the following:

clicking on the Click to toggle.. does actually toggle Fether window.
It'd be better to:

show/hide Fether right away on left click
show the menu on right click

@Tbaut This is associated with platform limitations of Linux (see Electron API docs https://electronjs.org/docs/api/tray#event-right-click-macos-windows). I've tried different ways to get rid of the popup so it just opens the Fether window on click straight away without success.
Removing the tooltip doesn't make any difference. Uninstalling sudo apt-get remove libappindicator1 doesn't make any difference.
Due to not being able to avoid this and the fact that right-click on the tray icon doesn't work on Linux either, I've proposed that for all OSes that we just toggle show/hide the Fether window with the tray icon (without having a right-click that shows a menu, since it won't work on Linux), and instead just show the Fether menu when the user right-clicks on the Fether window, which is what I've done in the latest changes of PR https://github.com/paritytech/fether/pull/440

I answered in the PR

authors: Tbaut ltfschoen


text:
Consider exporting a cli "umbrella" interface

While considering pathways to https://github.com/paritytech/opstooling/issues/125, I realised that we probably will have more than one shared script between projects.
WDYT on adding bin section to the package, with subcommands to later extension?
I have something like this in mind:

File structure:

/src
  /cli
    /commands
      generate-types.ts
      other-stuff.ts
    opstooling-scripts.ts

package.json:

...
"bin": {
  "opstooling-scripts": "./dist/cli/opstooling-scripts.js"
},
...

Usage (in the dependants):

npx opstolling-scripts --help
npx opstolling-scripts generate-types --schemas <path-to-schema-dir> --out <path-to-types-dir>

In terms of libraries, I'm a big fan of commander package, but anything aside from inventing it from scratch is fine by me.
I'm also open to other approaches for the sharing scripts problem.
cc/ @paritytech/opstooling

Fine with me too :)

Any opinions on compiling code on install vs. using ts-node on execution?

authors: koenw mutantcornholio

repo: paritytech/opstooling-js


text:
Improve codec implement for u8 and array.

Signed-off-by: koushiro koushiro.cqx@gmail.com
Changes
Implement Encode and Decode for u8;
Remove impl Encode for [u8], impl Encode for Vec<u8> and impl Decode for Vec<u8>.
Details
Why not add Encode and Decode for u8?  In #47, Gavin said it would make the two encodings: Vec<u8> and Vec<T: Codec> clash.
But we already have these:

impl<T: Encode> Encode for [T]
impl<T: Encode> Encode for Vec<T>
impl<T: Decode> Decode for Vec<T>

If we add Encode and Decode implementations for u8, we won't need impl Encode for [u8], impl Encode for Vec<u8> and impl Decode for Vec<u8>.
I think this will be clearer. Maybe I got something wrong?

The implementation differs, for [T] the function write len in a compact way and then all item using:
		for item in self {
			item.encode_to(dest);
		}

on the other hand the implementation of [u8] write len in a compact way and then call
		dest.write(self)

there may be a performance issue there, also maybe it could be rewrite with a condition if T is typeid of u8 but at first at least implementation doesn't seems equivalent

@thiolliere Thanks for your reply. You are right, there is indeed a performance issue after the benchmark, and the performance is about 7-8 times slower on my computer. I will close the PR.
BTW, what do you think about adding more u8 array types in impl_non_endians!(...), like in impl_array!(...). I think this is more consistent for encoding and decoding array types.

I think it the array types are enough as you can also just cast an array to a slice and encode this.
As you wanted to close your pr anyway, I will do it for you.

authors: bkchr koushiro thiolliere

repo: paritytech/parity-codec


text:
Feature gate node building

In relation to: https://github.com/paritytech/polkadot-sdk/issues/5940. I assume this is the place where this change should be made since the polkadot-sdk README points users to this repo to actually build the templates.

Closing this since the repo is updated automatically based on: https://github.com/paritytech/polkadot-sdk/blob/master/.github/workflows/misc-sync-templates.yml

license: Unlicense


text:
Keep or remove --ipfs-server

Our network, Fragnova, heavily relies on the bitswap protocol feature provided by substrate. However, we've noticed that this feature has not been working properly for several months now, due to some libp2p complications introduced by recent pull requests.
Given the importance of this feature to our network, we would greatly appreciate some clarity on Parity's intentions for its future. If the intention is to keep it, we hope that the necessary steps can be taken to fix it. However, if it is no longer being maintained, we will need to explore alternative options for reading large chunks of binary data from node blocks.
🙏

I'm not aware of any direct requirements for bitswap, but there were some ideas. I think for now we could keep it. We would also be happy to accept some prs to fix the current issues, together with some tests to ensure that it doesn't break again :)

authors: bkchr sinkingsugar

repo: paritytech/substrate


text:
Add codeownership for runtime lib.rs's files

This PR update CODEOWNERS file by assigning code ownership of runtime's lib.rs files to @paritytech/substrateteamleads according to this issue
Whether submitted PR touches one of above mentioned files it will require at least one approval from  @paritytech/substrateteamleads

As a team lead that never touches anything related to the runtime whatsoever (I don't think I was concerned by this issue), can I somehow exclude myself/disable these notifications?
Hi @tomaka
I'm afraid it is quite problematic. Other solution would be to use persons list instead of paritytech/substrateteamleads group. But this will require manual update on every group change.

I could also remove myself from that GitHub team. I don't really see what it brings to be in there.

I kinda feel like it is 100x more important to have this in polkadot repo. The substrate-node is not deployed anywhere and is essentially a kitchen sink of all pallets.

@kianenigma don't worry, CODEOWNERS will be everywhere at some point.

@tomaka  I could also remove myself from that GitHub team. I don't really see what it brings to be in there.

I agree with this. I think we should re-consider using that team and/or Github team structure for that in general. This team was initially created to allow for some release-based shortcuts and overwrites, but hasn't been maintained nor given any other special privileges or responsibilities since. I doubt that it is (as it currently exists) up to date in terms of the members, nor is it maintained and – in this area – shoots further than what is applicable. I and @tomaka (as current members of that team) shouldn't even have these privileges. I think using a newly created runtime-owners-github-team makes a lot more sense...

Well, actually this change is not needed for how we decided to implement this check. It will be a separate CI job and all this logic including mentioning the reviewers groups.
@gnunicorn you're right, this should be a separate group. In my opinion, all these groups assignments should be maintained by security team and be a part of on-/offboarding processes.

authors: TriplEight gnunicorn kianenigma sergejparity tomaka


text:
Actually use the pre-runtime digests in the runtime

The pre-runtime digests have been available to the runtime since #2466, but they have not been used yet.  This PR begins the use of them in the runtime, starting with that of BABE.

Does this close #2918 ? It should say so in the PR description if so. Then GitHub can automatically close it.

Does this close #2918 ? It should say so in the PR description if so. Then GitHub can automatically close it.

It does not, to my understanding ― it makes pre-runtime digests accessible to the SRML modules, but not to authorship.

Also, the randomness beacon implemented here isn't what BABE specifies -- we shouldn't merge it until it is.
Refer to https://research.web3.foundation/en/latest/polkadot/BABE/Babe/#3-epoch-update
To translate into psuedocode:
Rather than maintain a single randomness: [u8; 32], we maintain 3 fields epoch_randomness, under_construction, next_epoch_randomness. all [u8; 32].
For every block in the epoch, we XOR in the VRF output into under_construction.
At the end of an epoch with number m:
let rho = under_construction;
under_construction = [0; 32];

let last_epoch_randomness = epoch_randomness;
epoch_randomness = next_epoch_randomness;
next_epoch_randomness = H((last_epoch_randomness, m + 1, rho));

This also implies that we maintain an EpochIndex storage item to track the epoch number.

@bkchr @rphmeier worth another review?

authors: DemiMarie-parity gavofyork rphmeier


text:
Implements anonymous behavior

The plugin must allow the execution of other authentification that run after.
It is usually implemented by the config.anonymous parameter which can be found in other authentification plugin.

Hello @pariviere ,
401 still occured
Jul 26 14:43:02 UAGWRRP1 kong[57461]: {"tries":[],"consumer":{"created_at":1654241046,"id":"5ee84acc-382e-4401-affd-25a2cac0923b","username":"anonymous"},"latencies":{"proxy":-1,"kong":29,"request":29},"started_at":1658832182004,"response":{"headers":{"server":"kong/2.4.0","vary":"Origin","content-type":"application/json; charset=utf-8","content-length":"26","connection":"close","x-kong-response-latency":"29"},"status":401,"size":246},"client_ip":"10.241.46.123","upstream_uri":"/status","service":{"created_at":1654241046,"updated_at":1654241046,"name":"svi-facade-preprod-service","connect_timeout":60000,"write_timeout":60000,"read_timeout":60000,"id":"f27478d9-72c8-4fd7-9565-64dc59e66021","retries":5,"host":"svi-facade","port":443,"protocol":"https","ws_id":"0246cf14-d412-45e3-8b52-d2c113430f74"},"route":{"created_at":1657198184,"updated_at":1657198184,"path_handling":"v0","protocols":["http","https"],"https_redirect_status_code":426,"id":"4068fb8e-0864-4392-a063-00c9ecf81d5c","paths":["/sviFacade-preprod/v1"],"name":"svi-facade-preprod-route-v1","service":{"id":"f27478d9-72c8-4fd7-9565-64dc59e66021"},"strip_path":true,"request_buffering":true,"response_buffering":true,"preserve_host":false,"regex_priority":0,"ws_id":"0246cf14-d412-45e3-8b52-d2c113430f74"},"request":{"uri":"/sviFacade-preprod/v1/status","headers":{"postman-token":"e4cc94c3-ea47-4751-a192-bbde15049094","accept-encoding":"gzip, deflate, br","x-consumer-username":"anonymous","authorization":"REDACTED","x-anonymous-consumer":"true","x-consumer-id":"5ee84acc-382e-4401-affd-25a2cac0923b","connection":"keep-alive","host":"gwapi-ua.si.reunion.ftm.francetelecom.fr","user-agent":"PostmanRuntime/7.29.2","accept":"*/*"},"size":329,"querystring":{},"tls":{"version":"TLSv1.3","cipher":"TLS_AES_128_GCM_SHA256","client_verify":"NONE"},"method":"GET","url":"https://gwapi-ua:8443/sviFacade-preprod/v1/status"}}
Any idea ?

Hello,
Can you be more specific ?
You have to use anonymous config if you want to allow the use of other authentication plugin like basic-auth.
The following declarative configuration works great with the last version of the plugin
_format_version: "1.1"
services:
  - name: mockbin-service
    url: http://mockbin.org
    routes:
      - name: mockbin-path
        paths:
          - /
        preserve_host: false
        protocols:
          - http
          - https
plugins:
  - name: basic-auth
    config:
      anonymous: anonymous
  - name: jwt
    enabled: true
    config:
      anonymous: anonymous
  - name: jwt-ext
    config:
      anonymous: anonymous
      scopes_claim: roles
      scopes_required:
        - administrator
      claims_headers:
        - iss:x-jwt-iss
        - sub:x-jwt-sub
        - scope:x-jwt-scope
        - "client_id: x-jwt-client-id"
        - application_roles:x-jwt-application-roles
        - _validated_scope:x-jwt-validated-scope

consumers:
  - username: anonymous
    plugins:
      - name: request-termination
        config:
          status_code: 401
  - username: demo_basic
    basicauth_credentials:
     - username: foo
       password: bar
  - username: demo_jwt
    jwt_secrets:
      - key: demo_key
        algorithm: HS256
        secret: demo_secret

With this configuration :

if no basic auth nor jwt is found : 401
if basic auth can not validate credential: 401
if JWT is not verified: 401
if JWT-ext can not validate scope claim: 401
Valid basic auth: 200
Valid JWT and JWT-ext: 200

NOTE : with e9a481a4d9f5611166593313c177fa0f3f5f0762 jwt-ext was not executed if jwt can authenticate user. It should be fixed with 6be69af311abe989c90b0e503dd33c38a281477c

repo: pariviere/kong-plugin-jwt-ext


text:
UWP local file access issue

So I cannot get version 1.7 to work with a .NET standard library and VS 2017 15.9.3 so I followed the directions and built from source... added the using in my .NET Standard App.xaml.cs and then the Parse client initialize just before the main form is constructed.
I have a Xamarin.Forms app and when I try to run the UWP version I get the following error:
_Access to the path 'C:\Users\Stephen\source\repos\WatchMeWork\WatchMeWork.UWP\bin\x86\Debug\AppX\C' is denied.
at System.IO.Win32FileSystem.CreateDirectory(String fullPath)
at System.IO.Directory.CreateDirectory(String path)
at Parse.Internal.Utilities.StorageManager.GetWrapperForRelativePersistentStorageFilePath(String path)
at Parse.ParseClient.Configuration.IdentifierBasedStorageConfiguration.get_RelativeStorageFilePath()
at Parse.Internal.Utilities.StorageManager..cctor()_
I am not sure why Parse wants to write to the local path anyway but ....
I haven't tried beyond UWP at this point ...

I think maybe I'm facing the same or a similar issue.(https://stackoverflow.com/questions/55085681/parse-initialize-throws-ioexception-with-parse-net-sdk-on-net-core-2-2-hosted). @stephenhauck  Did you find a solution?

@kentrh could you check if the fixes inside my feature branch might fix this issue on your side?https://github.com/TobiasPott/Parse-SDK-dotNET/tree/feature/fix-currentinstallation-caching
I've had several issues within Unity regarding the path and caching location and also the trailing "\C" in the path (which comes from, as I assume, erroneous usage of the "VolumeSeparatorCharacter" when the storage file path is assembled).
Unfortunately I've got distracted on this and did not that much testing on it aside from what I need in my own application. If you could give it a try and tell me how it works for you, I'll try to pick up working on it and preparing a PR for the main repository.

As this issue received no update for a while I close it.
The SDK should work fine on the UWP platform (including some configurations using mutators).
If this problem persist feel free to reopen this issue and provide additional information.

authors: TobiasPott kentrh stephenhauck

repo: parse-community/Parse-SDK-dotNET


text:
Undefined constant Doctrine\ORM\Query\Lexer::T_IDENTIFIER

Hey, thanks for the package!
Unfortunately, I encounter following error running a similar query to below, in Symfony 7:
Undefined constant Doctrine\ORM\Query\Lexer::T_IDENTIFIER
$qb = $this->entityManager->createQueryBuilder();
$qb->select('e')
    ->from('App:Embeddings', 'e')
    ->orderBy('distance(e.vectors, :vector)')
    ->setParameter('vector', $floatArray, 'vector')
    ->setMaxResults(5)
    ;
$result = $qb->getQuery()->getResult();
dump($result);

Do you have any idea why?

what version of ORM are you using ?
ORM 2? if so, try v0.0.5 and it should be ok

Hey @GeraudBourdin ,
Using "name": "doctrine/orm", version": "3.2.1", and "name": "partitech/doctrine-pgvector", version": "v0.0.6",

Works! Thank you very much for the ultra fast fix @GeraudBourdin ! 🚀

authors: AykutCevik GeraudBourdin

repo: partITech/doctrine-pgvector


text:
Profile Doesn't Show Entries Contributed

These entries were submitted by Claire and go to the profile page shown above (note that text also reads "you haven't added any content yet" which should only show on my profile)
https://participedia.xyz/organization/5302
https://participedia.xyz/organization/5297

fixed

authors: ascott scottofletcher

repo: participedia/frontend


text:
Mail template

The default template mail need to be changed, when registering a new user

Not really important... can be done later

repo: pascalgrimaud/qualitoast


text:
Kills processes that print to stderr

If you spawn npm install, you'll get warning messages like:
npm WARN package.json pkgName@2.2.1 No license field.

And this is printed to stderr, which triggers
cp.on('error', deferred.reject);

at https://github.com/patrick-steele-idem/child-process-promise/blob/master/lib/index.js#L120

I just double checked and writing to stderr does not cause the promise to be rejected. The error event does not get emitted when writing to stderr: https://nodejs.org/api/child_process.html#child_process_event_error
I added a test case to verify and everything is working as expected (the promise is not rejected when writing to stderr): https://github.com/patrick-steele-idem/child-process-promise/commit/2a650240d459dc5fcaba58b20c3ce69f164938e8
Please let me know if I am missing anything.

Well, glad you added a test case. Sad it wasn't the problem. haha
It appears that I was running npm install and it was passing through the NODE_ENV to the child process which since it returned early and didn't install the packages I was expecting was causing things to throw. Sorry for the goose-chase.

authors: TheSavior patrick-steele-idem


text:
Run on_role_change cb after a failed primary start

Additionally run on_role_change callback in post_recover() for a primary that failed to start after a crash to increase chances the callback is executed, even if the further start as a replica fails

Pull Request Test Coverage Report for Build 11591715026
Details

1 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 99.875%

Totals

Change from base Build 11550559465:
0.0%

Covered Lines:
14354

Relevant Lines:
14372

💛  - Coveralls

authors: coveralls hughcapet

repo: patroni/patroni


text:
🛑 PCNA production home page is down

In 33fa245, PCNA production home page (https://www.pcna.com) was down:

HTTP code: 503
Response time: 100 ms

Resolved: PCNA production home page is back up in f1d2baa after 6 minutes.

repo: patstha/upptime


text:
fix(dropdown): trigger button should never be disabled

What I did

Removed disabled from toggle button.

Testing Instructions

In Dropdown docs -> disabled, use a keyboard to navigate to toggle the dropdown.
Verify the menuitems can be read, by a screenreader but are disabled.

Notes to Reviewers

WAI-ARIA recommends elements of a larger composite widget remain focusable.

http://v4-archive.patternfly.org/v4/components/dropdown#disabled-toggles demonstrates a disabled trigger button, as such we must align with upstream behaviours. if this is an accessibility issue upstream, we should file there

If a keyboard user is able to open the menu, then a mouse click should do the same.  BOTH shouldn't be able to select a sub item.

Blocked by #2716

If a keyboard user is able to open the menu, then a mouse click should do the same. BOTH shouldn't be able to select a sub item.

@hellogreg @zeroedin and I decided that disabled menu should open for both keyboard and mouse but that menu items can't be clicked

@bennypowers ptal

FYI: looks like the disabled button and menu items are not giving an indication to VoiceOver/Safari or JAWS/Chrome that they are disabled:

The menu items do announce "unavailable" to NVDA/Firefox.

@nikkimk @hellogreg does d8eaf8d help?

@bennypowers in the DP's disabled example, the second menu item has a pointer cursor.

A little weirdness here with VoiceOver. The first time a menu item receives focus, VO announces, "[text], menu item." But on subsequent focus, it just reads the text.

This may not be a showstopper. Other menu button examples (e.g., WAI's Navigation Menu Button) don't announce "menu item" with the initial text at all. And VoiceOver does ultimately indicate it is a menu item (as it does in the WAI example):

But the inconsistency might be worth investigating. If we're okay with launching it with this, I can open another issue afterward.

Windows (Chrome/JAWS and Firefox/NVDA) and mobile (Android and iOS) working as expected.

authors: bennypowers hellogreg nikkimk zeroedin

repo: patternfly/patternfly-elements


text:
chore(pf-issues): Updated to github actions to add to PF Issues Project.

Updated extensions action to add to issues to the PF-Issues project.

Preview: https://react-component-groups-pr-component-groups-126.surge.sh

authors: dlabaj patternfly-build

repo: patternfly/react-component-groups


text:
fix(MessageBox): Announce new messages

Messages should be announced to assistive devices. I added a prop to MessageBox to allow for this and updated our two demos with message sending so they make announcements. I also documented this in the Chatbot container docs. I checked this worked with VoiceOver, but I can't speak to any other tools.

Preview: https://virtual-assistant-pr-virtual-assistant-229.surge.sh

authors: patternfly-build rebeccaalpert

repo: patternfly/virtual-assistant