text:
AngioTK Documentation

Documentation for AngioTK:

[x] Build instructions
[x] General description of AngioTK
[x] Description of the different modules

[x] Input and output of the modules
[x] Document the different options available

[x] Document the graphical tool for editing centerlines
[x] Document how output files are stored for the Pipeline and how files are stored for the result matrix
[ ] Creation of Angiotk Book

Since the AngioTK Book system was abandoned and we moved to Antora, we can close this issue.

authors: aancel francoisdh

repo: feelpp/angiotk


text:
There can only be one default filter in GtFiltersElement

Currently only one filter can be the default filter in a GtFiltersElement, even if multiple are applicable.
Cheers

source: gharchive/issue

repo: feenkcom/gtoolkit

license: mit

license_type: permissive

license_source: bigquery


text:
Help message is not very clear

~ » ctc address                                       caleb@DESKTOP-8BF3E2A
usage: __main__.py [-h] [-v] [--network NETWORK]
                   [--new_dir_tempfile NEW_DIR_TEMPFILE]
                   address
__main__.py: error: the following arguments are required: address

__main__.py is confusing

all cli help messages now significantly improved

authors: ditchfieldcaleb sslivkoff

repo: fei-protocol/checkthechain

license_source: github-api


text:
how can also dismiss the menu if tap anywhere else on the screen?

Newbie question, Currently the menu retracts if you click the tap button again, but I also want the menu to retract if the user taps anywhere else on the screen expect the buttons. ANy suggestions?

The problem I'm running into is that I am implementing this in navbar with tabbarcontroller, what happens is that if i tap the button to open the menu and then click on the different tab without collapsing the bubble menu.  And then if I come back to the same tab, the bubble menu is visually still open but in code it still thinks it is collapsed, that leads to weird behavior of adding another subview

call dismissButtons() method when you need hide.
downMenuButton.dismissButtons()
upMenuView.dismissButtons()

cool thanks

authors: feiin jasan-s


text:
bootcamp-9:adding code for text component

adding solution for bootcamp 9

Creating a new PR targeting my own base repo

source: gharchive/pull-request

repo: felipe-londonol/aem-bootcamp


text:
Update bignumber.js to v2.0.5

Regrettably, a critical (though very rarely manifesting) bug has been found in the division operation in versions v2.0.0 - v2.0.3 of bignumber.js.
Please update to v2.0.5.

https://github.com/MikeMcl/bignumber.js/issues/58
it probably does not directly affect this library as we are only constructing bignum and not doing any math (but users might have the issue by using result)

Thanks, @MikeMcl for the note!
And @sidorares all we do is .plus and .times and then we call .toString() and give the user a string; the users do not have any idea that we are even using bignumber.js :)

authors: MikeMcl dougwilson sidorares

repo: felixge/node-mysql


text:
SUPPORT: BullBoard doesn´t read Redis in another host

Hello, how can i set the Redis connection to the BullBoard when the redis instance is on another host. The redis instance is in the 6379 port, but in different ip than localhost.

I already resolved it, its automatic the connection to redis based on the queues connections. it was my mistake at configuring the queues.

repo: felixmosh/bull-board

license: MIT


text:
Invalid salt version: 2

The deployment went perfectly - thank you!.  When navigating to /ghost/settings (for initial config) and clicking save, I got the error "Invalid salt version: 2" screenshot.
Subsequently navigating to /ghost/settings/ redirects to /ghost/signin/ where entering username and password again throws the error "Invalid salt version: 2".

Well, I deleted the Azure Web App and repeated the process, and it worked this time. I suppose I will close the issue. Thank you.

Thanks for reporting though! I have to admit that I have no idea what happened (I guess something inside bcrypt), but I'll ignore this one for now :)

It happens here:  Invalid salt version: 2

I just discovered the underlying cause of this error. There was a bit of code in Ghost that was missed during a refactor, meaning the second char of the password hash was being stored instead of the whole hash.
This particular piece of code only gets executed if something else goes wrong though! It only happens in the exact case that you try to setup your blog and the 'owner user' fixture is not in place in the users table. This means in the case of an older blog that a previous migration must have failed to complete successfully, or in the case of a new blog, that the fixtures were not populated properly on the first run.
I am not sure if there is anything about the Azure environment which may cause fixture population to fail more than on other environments, so thought I'd flag up this explanation here just in case.
The password hashing bug will be fixed in the next version of Ghost (0.7).
Note this explanation is only true for the exact error 'Invalid salt version: 2' when trying to setup a Ghost blog.

authors: ErisDS bokeyy felixrieseberg markau

repo: felixrieseberg/Ghost-Azure


text:
datepicker is not accessible

nice datepicker but its not accessible using keyboard.
are you planning adding this ability?

Not support keyboard.

authors: fengyuanchen kisin

repo: fengyuanchen/datepicker


text:
Can't get example to work

I just copy pasted the example but can't get it to work
First image in editing mode, second in view mode.

It looks like something weird happens between copying from github and pasting to obsidian. It seems to work okay if you copy the contents inside the raw syntax (```)

Yes, copying the contents inside works!

authors: Flecart fenjalien

repo: fenjalien/obsidian-typst


text:
What happens if we already have BEARER_TOKEN_FILE set to an invalid token?

@cathulhu asked a good question yesterday while we were discussing job submission and tokens:  If we have an invalid token (whether expired or for the wrong experiment), and try to submit a job, how does jobsub_lite handle it?
If BEARER_TOKEN_FILE is not set in the environment, we should be fine, because jobsub_lite should ignore the bad credential and get the correct token.  However, if it is set, do we just crash and burn, or give a helpful error message?  We should investigate this, and if needed, make sure we handle that use case gracefully.
I think the correct behavior should be that if BEARER_TOKEN_FILE is set to an invalid credential:

We fail the submission.
Do not get a new token.
Let the user know WHY the submission failed,
Advising the user to either:
a. Unset BEARER_TOKEN_FILE, or
b. Get a new token into the location BEARER_TOKEN_FILE is set to.

For (3) above, I don't think we'd need to give a concrete reason besides the fact that BEARER_TOKEN_FILE is set to an invalid token.
@marcmengel - would you agree that this is the correct behavior or do you have another suggestion?

Did some investigation, and we do indeed need to fix this.  Here were my tests (using the 1.5 release):
Using an invalid file for BEARER_TOKEN_FILE
$ echo "thisisabadfile" > /tmp/testbadtoken
$ export BEARER_TOKEN_FILE=/tmp/testbadtoken
$ jobsub_submit -G fermilab file:///usr/bin/sleep 300
Error: InvalidTokenFormat: Serialized token is not a readable format.

This is OK, but we should probably give a better explanation of what's going on there.

## Using a valid token, but for the wrong VO

$ htgettoken -a htvaultprod.fnal.gov -i dune
...
Storing bearer token in /tmp/testbadtoken
$ jobsub_submit -G fermilab file:///usr/bin/sleep 300
...
Submitting job(s).
1 job(s) submitted to cluster 65770261.

OK, so job submission succeeded.  That's somewhat expected.  Here's what's bad.  In the JDF (.cmd file), we see the following lines:
use_oauth_services = fermilab

fermilab_oauth_permissions_6e4d19314c = " compute.read compute.create compute.cancel compute.modify storage.read:/dune storage.create:/fermigrid/jobsub/jobs ..."

So the job gets submitted, but the requested scopes are wrong, which could have bad downstream effects, since now the token being ostensibly handed to the job has the wrong scopes.
We should be doing some sort of check here, and failing the job submission, IMO.

This work is done.  Here are the new tests:
Using an invalid file for BEARER_TOKEN_FILE
$ echo "thisisabadfile" > /tmp/testbadtoken
$ export BEARER_TOKEN_FILE=/tmp/testbadtoken
$ jobsub_submit -G fermilab file:///usr/bin/sleep 300

Error: InvalidTokenFormat: Token stored in $BEARER_TOKEN_FILE is not in a readable format. Please inspect the token with httokendecode or unset $BEARER_TOKEN_FILE and allow jobsub to create a new token.

Same as before, but more helpful.  Good.
Using a valid token, but for the wrong VO
This was the big problem in 1.5.  Here's what happens now:
$ htgettoken -a htvaultprod.fnal.gov -i dune
...
Storing bearer token in /tmp/testbadtoken
$ ~/jobsub_lite/bin/jobsub_submit -G fermilab file:///usr/bin/sleep 300

Error: ValueError: BEARER_TOKEN_FILE contains a token with the wrong group or role. jobsub expects a token with group fermilab and role Analysis. Instead, BEARER_TOKEN_FILE contains a token with group dune and role Analysis.

Much better.

Fixed by #509


text:
Fermyon-branded Hippo

EDIT: now working with both the local and AWS installers. Ready for review!
Currently working through a style sheet bug, but here's a preview!

The color scheme from fermyon/styleguide is not being applied to the project. Currently working through that. Hold up

Okay... This is not my best code, but I could not see a way to get artifacts to overwrite assets prior artifacts downloaded without performing a mv after fetching the asset down.
That being said, things are working!

Now working with the AWS installer:

Good question.
The logo.svg comes from fermyon.com's embedded logo, but with a few tweaks to the XML metadata so it can stand alone. I just realized there's a standalone version at https://github.com/fermyon/styleguide/blob/main/image/fermyon.svg. I will go and update that URL.
The favicon.ico is also available there: https://raw.githubusercontent.com/fermyon/styleguide/main/image/icon/favicon.ico
As for the styles.css, that comes from my local fermyon-branding branch of hippo. The styles.css is the end-result of a custom-compiled sass file that fixes a few issues with fermyon/styleguide and Bulma. These changes have been proposed upstream to https://github.com/fermyon/styleguide/pull/30, so eventually we could import fermyon.css from there.
As for config.json... We could just echo '{"title": "Fermyon"}' > config.json. There's no real need to pull that from an external source.
What do you think about that plan?

Awesome, thank you for the breakdown @bacongobbler .
I like the plan.  Another idea, perhaps not necessarily mutually exclusive to the strategy you've laid out -- thoughts on a dedicated fermyon/hippo-styles (or, any name that might be better) holding all such assets dealing with Fermyon's custom branding on top of Hippo?

Ideally fermyon/styleguide would be analogous to fermyon/hippo-styles. But yes, I can create a repository at some point to host it there to serve as an example.

authors: bacongobbler vdice

repo: fermyon/installer


text:
Unable to create examples for endpoints with multiple query parameters

Describe the bug
When I try to create an example with multiple values for a query parameter, I get an error.
To reproduce
Steps to reproduce the behavior:
Try to create an endpoint example like this:
examples:
  - query-parameters:
      entities:
        - abcd
        - efgh

Observe error Expected example to be a string. Example is: ["abcd","efgh"]
Expected behavior
If you can build a spec that accepts multiple values for a query parameter, you should be able to create an example use case with multiple values for a query parameter.
Screenshots
N/A
Versions

Desktop OS: macOS
Fern Version: 0.16.3

@davidkonigsberg if you're still facing this issue, let me know. Closing as stale in the meantime.
Happy to re-engage if anyone else runs into this!

authors: dannysheridan davidkonigsberg

repo: fern-api/fern


text:
Wrong Unsaved Changes message when closing individual file

When a file with unsaved changes is closed. The message says:

File xyz.xlam has unsaved changes. Do you want to save them before exiting the program?

This should mention that just the file is being closed, not the entire program.

Fixed in 56b5c20. Now the message just talks about the document being closed, even if exiting the app completely. The reason behind this is that, if there is more than one document open, the same message will appear once for each unsaved document, so it seems intuitive enough this way.

repo: fernandreu/wpf-custom-ui-editor


text:
Abandon / Redirect standardjs.com domain to something else

From the FAQ, emphasis mine

But this isn't a real web standard!
Of course it's not! The style laid out here is not affiliated with any official web standards groups, which is why this repo is called feross/standard and not ECMA/standard.

But the domain is just standardJS.com, right?
There is another case of Standard Markdown, someone who didn't create Markdown ignored the authority of Markdown (here JavaScript), and claimed to own (the domain of) the standard style.
Too many flames later, it became CommonMark, NOT StandardMarkdown or StandardMark even.
Is this story something that this project can learn from? It isn't that different of a situation, is it?
This effort to make less argumentative JS style is fine (ignore the 14 standards becoming 15 joke). THANKS FOR THAT.
However, would it make sense if we are avoiding bikeshedding about the style...
To avoid it about the name as well?
Can we step away from StandardJS, or have some prefix for the word Standard or so?

There is several other threads you could have read before opening this.

This is not the same.
It doesn't say Abandon the name completely. If it's to be called "feross/standard" as the FAQ states it is, that's perfectly fine.
So, keep it as StandardJS if that's what the project perfers to be, no problem with that at all.
But the domain is conflicting with the intention stated in the FAQ. It doesn't say FerossStandardJS.com for example. It just claims the absolute (non constrained) Standard naming.
Sorry for not making an explicit statement in the issue description about that this is NOT to rename the project itself, only the domain.
Would that make it a separate issue worth opening and looking into?
Thanks again for the effort put into this.

Like those before you were told. This isn't going to change. So go be productive instead.

Like those before you were told

Regarding those, the Github issue is about the domain name not the project rules or any other set of things.

This isn't going to change

Would that be contradicting the point made in the quoted FAQ?
I wouldn't have created this Github issue if it weren't for it. Thanks a lot for the project making that FAQ point clear.

So go be productive

Thanks for the advice. It's kind of off-topic for the Github issue, but I appreciate your thinking of my time.
P.S.
Just in case I need to repeat this once more, the Github issue is not about the name of the project, the strive to come up with frustration-free standard style or anything, only the domain name, and in the context explained in the Github issue description.

And if someone goes to standardjs.com and reads http://standardjs.com/#but-this-isnt-a-real-web-standard then the problem is mitigated. But like the name standard on the package itself, it's just another way of someone trying to make invalid misconceptions just to get the name changed.
Everyone behind this module has stated multiple times they won't be making any changes to the names. So move on. You can paint the shed a different color, it's still a bike shed.

I truly appreciate your declaration of the name change as a popular request, so popular that the project keeps facing it multiple times. However, I hope you do realise that earlier note that I'm not asking to change the name.
As you state, people might go to to the domain, check the note, read the "feross/standard" part, look back at the URL, and just get confused. There is an obvious contradiction here. It might well be why many people keep asking for a name change. Whether it is or not, there is a contradiction, and potential confusion.
NPM is another story. There is a whole mess in NPM (and bower for that matter) around the authority of package names. This project is not "significant" contributor to this universal issue. That's why I have not included it in this Github issue. If the project is to pick a new domain, it needs to have the word standard in it of course, which will still link it to the NPM package.

I'm happy to donate the new domain name and domain to the project by the way, in case the project makes a choice to go on with a new domain name without changing the project name.

https://yourlogicalfallacyis.com/slippery-slope

I will not suggest that you are doing this https://yourlogicalfallacyis.com/strawman
And I hope you are not doing anything like: https://yourlogicalfallacyis.com/the-fallacy-fallacy
Thanks.
I'm saying there is a contradiction between the non-constrained domain name, and the explicit note in the docs (FAQ) saying:

this repo is called feross/standard and not ECMA/standard.

I'm assuming that the explicit docs is the correct source of truth, and suggesting implying this in the domain name to avoid confusion.

Your main argument is that new comers could be confused and think it is THE official ECMAScript standard, yet nobody has came forward saying they had that issue. Your fallacy is all that it is, a fallacy.

Uh, ok, you have earned this:
https://yourlogicalfallacyis.com/strawman
My main argument is that there is a conflict. I said there will also be a "potential" confusion, but the main argument is that there is a conflict between a global domain name standardJS.com and a specific username repository "feross/standard", which (the repo name) it seemed an explicit (at least correct) choice based on the FAQ.
If the repository was called standardjs/standard for example, this Github issue wouldn't have made any sense. But it's not.

Look, move on with your life. You can argue your point until you're blue in the face. The maintainers have expressed no desire in deviating away from any of the names. Get on with your life man.

That's not to say that I wasn't confused myself with this as well. When I saw the domain name I was like "Are they claiming to be THE JavaScript standard?!!!".
Then I looked in the FAQ and saw the note, then thought "Oh, so it is feross/standard, or standardJS? Even the logo just keeps it without any affiliation. This is a just not right".
If you choose to ignore my confusion that's all cool. I still hope that you, project coordinators, at least recognize the conflict between the two names and kindly and thankfully work on improving the experience by removing the conflict.

You know how many businesses claim to be the number 1 in their field, so much that even the most widely known businesses in that field all claim the same feat... Maybe call Comcast and Timer Warner Cable and let them know they need to stop advertising that, because clearly it's going to confuse potential new customers and choose their horrible services over a better provider.

Perfect argument for changing the project name not just the domain name, but remember, the project maintainers have made their mind on project name as obvious in the closed Github issues above.

So you think that because they won't change their mind on the npm package name, maybe you can convince them to change their mind on the domain name?

you can argue your point until you're blue in the face. The maintainers have expressed no desire in deviating away from any of the names.

By looking here https://github.com/feross/standard/graphs/contributors (there was no contributors.md file that I could find), you don't seem to be one of the project maintainers.
So, I'm gently and firmly asking you to not talk in their name or decide what they may choose to listen to or not. A project maintainer has chosen to keep the Github issue as you see.

the project maintainers have made their mind on project name as obvious in the closed Github issues above.

@Meligy,  I think then, you have your answer.  The website name is a direct representation of the projects name.
I don't see any reason why they should be different.
Any argument to change the former could also be made appropriately for the latter,  for which a decision has already been made.
I appreciate your positivity throughout the thread @Meligy,  but I'm going to close this for now.  @feross if you feel otherwise please don't hesitate to re-open :)

@dcousens Thanks a lot. Regarding "I don't see any reason why they should be different.". I have explained the FAQ note conflict as the reason. Would you agree that there is a conflict in the first place?
Another suggestion that would also make sense (I hope) is to make the domain name redirect to the readme of the file, which can include the FAQ. In that case, the note will make perfect sense because that's where the user has ended up landing anyway.
Right now, as I hope you might agree, it talks about how the repo is name constrained, while is is on the non constrained domain.

Apologies for reanimating this issue, but standardjs.com is really just a HTML version of the README itself. It includes the entire text of the README in the repo including the referenced FAQ:
http://standardjs.com/#but-this-isnt-a-real-web-standard

authors: Flet Meligy dcousens joshmanders

repo: feross/standard


text:
Exec tachikoma update 20161113165807

:hamster::hamster::hamster:   Strategy david
Powered by David Update as a Service - Tachikoma.io Announcement: 2015-06-28 Updated permissions - Tachikoma.io

Coverage decreased (-2.2%) to 75.87% when pulling edf549229ace34e3eca805fb565ca00cb2525e06 on pazjacket:tachikoma/update-20161113165807 into 561aeec19d8836578f0838fe4cbff883050bb66d on festivals-tech:master.

authors: coveralls pazjacket

repo: festivals-tech/npm-festivals-importer


text:
如果一个页面内多个webuploader上传实例，怎么实现？

同一个订单中，有多个商品，每一个商品需要单独上传评价图。

@alongchengtian0 可以具体说一下么。谢谢

订单->商品1->评论图片展示区

每一个评论去放一个上传功能就好了~
用class的方式初始化，可以在点击事件触发的时候，加全局索引，这样就知道是谁被点击了，然后找相应布局需要展示图片的区域，将上传成功后的图片追加到该区域。

@alongchengtian0 怎么加全局索引？ 我想多实例化的时候在uploadBeforeSend 动态设置参数， 参数来源当前实例设置的一个隐藏域。

repo: fex-team/webuploader


text:
Question for mass checking a list of sites for /.git/HEAD

Hi
I have a list of site that i would like to check for /.git/HEAD
basically what I want to do is for fuffs to check if the body response contains something like
ref: refs/heads/main
ref: refs/heads/master

The acme_subfinder_results containts all the sites I want to test and the word list only contains /.git/HEAD
ffuf -w acme_subfinder_result.txt:DOMAIN -w versioning_metafiles.txt -u DOMAIN/FUZZ -o acme_versioning -of html -p 0.1-2.0 -mc 200 -t 10
I was wonder which flag can i use to matched the body response I am looking for ?
Thank you kindly

Hi @Darkcast, you can use -mr to match Regex as you need.

Hi @Darkcast, you can use -mr to match Regex as you need.

Thank you, could you help me out making a correct regex (i suck )
:)

Something like ffuf -u "URL/.git/config" -w urls_list:URL -mr "\[core\]" -c -r must works, then you can play with any other conditions you need, like threads, output, combining the matches/filters, etc.

ok.thank you :)

authors: Darkcast bsysop

repo: ffuf/ffuf


text:
News please stopping in AWS EC2

In a AWS Ec2 instance with Ubuntu t2.micro instance, I have setup news-please to test if news-please works properly or not. But whenever, I am starting news-please, its failing giving  error "Unhandled error in Deferred:".
I tried starting in DEBUG mode also. I am attaching the stacktrace over here:
_

/usr/local/lib/python3.5/dist-packages/requests/init.py:80: RequestsDependencyWarning: urllib3 (1.13.1) or chardet (2.3.0) doesn't match a supported version!
RequestsDependencyWarning)
[newsplease.config:165|INFO] Loading config-file (/home/ubuntu/news-please-repo/config/config.cfg)
[newsplease.config:167|DEBUG] Option not literal_eval-parsable (maybe string): [Crawler] default
[newsplease.config:167|DEBUG] Option not literal_eval-parsable (maybe string): [Files] url_input_file_name
[newsplease.config:167|DEBUG] Option not literal_eval-parsable (maybe string): [Files] working_path
[newsplease.config:167|DEBUG] Option not literal_eval-parsable (maybe string): [Files] local_data_directory
[newsplease.config:167|DEBUG] Option not literal_eval-parsable (maybe string): [MySQL] host
[newsplease.config:167|DEBUG] Option not literal_eval-parsable (maybe string): [Elasticsearch] host
[newsplease.config:167|DEBUG] Option not literal_eval-parsable (maybe string): [Elasticsearch] ca_cert_path
[newsplease.config:167|DEBUG] Option not literal_eval-parsable (maybe string): [Elasticsearch] client_cert_path
[newsplease.config:167|DEBUG] Option not literal_eval-parsable (maybe string): [Elasticsearch] client_key_path
[newsplease.config:167|DEBUG] Option not literal_eval-parsable (maybe string): [Scrapy] log_level
[newsplease.config:167|DEBUG] Option not literal_eval-parsable (maybe string): [Scrapy] log_format
[newsplease.config:167|DEBUG] Option not literal_eval-parsable (maybe string): [Scrapy] log_dateformat
[newsplease.config:167|DEBUG] Option not literal_eval-parsable (maybe string): [Scrapy] log_encoding
[newsplease.config:167|DEBUG] Option not literal_eval-parsable (maybe string): [Scrapy] jobdirname
[newsplease.config:267|DEBUG] Loading JSON-file (/home/ubuntu/news-please-repo/config/sitelist.hjson)
[newsplease.main:255|DEBUG] Calling Process: ['/usr/bin/python3', '/usr/local/lib/python3.5/dist-packages/newsplease/single_crawler.py', '/home/ubuntu/news-please-repo/config/config.cfg', '/home/ubuntu/news-please-repo/config/sitelist.hjson', '0', 'False', 'False']
[newsplease.main:255|DEBUG] Calling Process: ['/usr/bin/python3', '/usr/local/lib/python3.5/dist-packages/newsplease/single_crawler.py', '/home/ubuntu/news-please-repo/config/config.cfg', '/home/ubuntu/news-please-repo/config/sitelist.hjson', '1', 'False', 'False']
[newsplease.main:255|DEBUG] Calling Process: ['/usr/bin/python3', '/usr/local/lib/python3.5/dist-packages/newsplease/single_crawler.py', '/home/ubuntu/news-please-repo/config/config.cfg', '/home/ubuntu/news-please-repo/config/sitelist.hjson', '2', 'False', 'False']
/usr/local/lib/python3.5/dist-packages/requests/init.py:80: RequestsDependencyWarning: urllib3 (1.13.1) or chardet (2.3.0) doesn't match a supported version!
RequestsDependencyWarning)
/usr/local/lib/python3.5/dist-packages/requests/init.py:80: RequestsDependencyWarning: urllib3 (1.13.1) or chardet (2.3.0) doesn't match a supported version!
RequestsDependencyWarning)
/usr/local/lib/python3.5/dist-packages/requests/init.py:80: RequestsDependencyWarning: urllib3 (1.13.1) or chardet (2.3.0) doesn't match a supported version!
RequestsDependencyWarning)
[newsplease.config:165|INFO] Loading config-file (/home/ubuntu/news-please-repo/config/config.cfg)
[newsplease.config:167|DEBUG] Option not literal_eval-parsable (maybe string): [Crawler] default
[newsplease.config:167|DEBUG] Option not literal_eval-parsable (maybe string): [Files] url_input_file_name
[newsplease.config:167|DEBUG] Option not literal_eval-parsable (maybe string): [Files] working_path
[newsplease.config:167|DEBUG] Option not literal_eval-parsable (maybe string): [Files] local_data_directory
[newsplease.config:167|DEBUG] Option not literal_eval-parsable (maybe string): [MySQL] host
[newsplease.config:167|DEBUG] Option not literal_eval-parsable (maybe string): [Elasticsearch] host
[newsplease.config:167|DEBUG] Option not literal_eval-parsable (maybe string): [Elasticsearch] ca_cert_path
[newsplease.config:167|DEBUG] Option not literal_eval-parsable (maybe string): [Elasticsearch] client_cert_path
[newsplease.config:167|DEBUG] Option not literal_eval-parsable (maybe string): [Elasticsearch] client_key_path
[newsplease.config:167|DEBUG] Option not literal_eval-parsable (maybe string): [Scrapy] log_level
[newsplease.config:167|DEBUG] Option not literal_eval-parsable (maybe string): [Scrapy] log_format
[newsplease.config:167|DEBUG] Option not literal_eval-parsable (maybe string): [Scrapy] log_dateformat
[newsplease.config:167|DEBUG] Option not literal_eval-parsable (maybe string): [Scrapy] log_encoding
[newsplease.config:167|DEBUG] Option not literal_eval-parsable (maybe string): [Scrapy] jobdirname
[main:88|DEBUG] Config initialized - Further initialisation.
[newsplease.config:267|DEBUG] Loading JSON-file (/home/ubuntu/news-please-repo/config/sitelist.hjson)
[newsplease.config:165|INFO] Loading config-file (/home/ubuntu/news-please-repo/config/config.cfg)
[main:192|DEBUG] Using crawler RecursiveCrawler for https://www.dig-in.com/.
[main:253|INFO] Removed /home/ubuntu/news-please-repo/.resume_jobdir/55ae9ff89e530b083b20633a558d116b since '--resume' was not passed to initial.py or this crawler was daemonized.
[newsplease.config:167|DEBUG] Option not literal_eval-parsable (maybe string): [Crawler] default
[newsplease.config:167|DEBUG] Option not literal_eval-parsable (maybe string): [Files] url_input_file_name
[newsplease.config:167|DEBUG] Option not literal_eval-parsable (maybe string): [Files] working_path
[newsplease.config:167|DEBUG] Option not literal_eval-parsable (maybe string): [Files] local_data_directory
[newsplease.config:167|DEBUG] Option not literal_eval-parsable (maybe string): [MySQL] host
[newsplease.config:167|DEBUG] Option not literal_eval-parsable (maybe string): [Elasticsearch] host
[newsplease.config:167|DEBUG] Option not literal_eval-parsable (maybe string): [Elasticsearch] ca_cert_path
[newsplease.config:167|DEBUG] Option not literal_eval-parsable (maybe string): [Elasticsearch] client_cert_path
[newsplease.config:167|DEBUG] Option not literal_eval-parsable (maybe string): [Elasticsearch] client_key_path
[newsplease.config:167|DEBUG] Option not literal_eval-parsable (maybe string): [Scrapy] log_level
[newsplease.config:167|DEBUG] Option not literal_eval-parsable (maybe string): [Scrapy] log_format
[newsplease.config:167|DEBUG] Option not literal_eval-parsable (maybe string): [Scrapy] log_dateformat
[newsplease.config:167|DEBUG] Option not literal_eval-parsable (maybe string): [Scrapy] log_encoding
[newsplease.config:167|DEBUG] Option not literal_eval-parsable (maybe string): [Scrapy] jobdirname
[main:88|DEBUG] Config initialized - Further initialisation.
[newsplease.config:267|DEBUG] Loading JSON-file (/home/ubuntu/news-please-repo/config/sitelist.hjson)
[newsplease.config:165|INFO] Loading config-file (/home/ubuntu/news-please-repo/config/config.cfg)
[newsplease.config:167|DEBUG] Option not literal_eval-parsable (maybe string): [Crawler] default
[newsplease.config:167|DEBUG] Option not literal_eval-parsable (maybe string): [Files] url_input_file_name
[newsplease.config:167|DEBUG] Option not literal_eval-parsable (maybe string): [Files] working_path
[newsplease.config:167|DEBUG] Option not literal_eval-parsable (maybe string): [Files] local_data_directory
[newsplease.config:167|DEBUG] Option not literal_eval-parsable (maybe string): [MySQL] host
[newsplease.config:167|DEBUG] Option not literal_eval-parsable (maybe string): [Elasticsearch] host
[newsplease.config:167|DEBUG] Option not literal_eval-parsable (maybe string): [Elasticsearch] ca_cert_path
[newsplease.config:167|DEBUG] Option not literal_eval-parsable (maybe string): [Elasticsearch] client_cert_path
[newsplease.config:167|DEBUG] Option not literal_eval-parsable (maybe string): [Elasticsearch] client_key_path
[newsplease.config:167|DEBUG] Option not literal_eval-parsable (maybe string): [Scrapy] log_level
[newsplease.config:167|DEBUG] Option not literal_eval-parsable (maybe string): [Scrapy] log_format
[newsplease.config:167|DEBUG] Option not literal_eval-parsable (maybe string): [Scrapy] log_dateformat
[newsplease.config:167|DEBUG] Option not literal_eval-parsable (maybe string): [Scrapy] log_encoding
[newsplease.config:167|DEBUG] Option not literal_eval-parsable (maybe string): [Scrapy] jobdirname
[main:88|DEBUG] Config initialized - Further initialisation.
[newsplease.config:267|DEBUG] Loading JSON-file (/home/ubuntu/news-please-repo/config/sitelist.hjson)
[main:192|DEBUG] Using crawler RecursiveCrawler for http://www.insurancejournal.com/.
[main:253|INFO] Removed /home/ubuntu/news-please-repo/.resume_jobdir/8294b9c2cc3db1cadb6b4a98109c8590 since '--resume' was not passed to initial.py or this crawler was daemonized.
[main:192|DEBUG] Using crawler RecursiveCrawler for http://www.dnaindia.com/.
[main:253|INFO] Removed /home/ubuntu/news-please-repo/.resume_jobdir/6906ed0b1a6ca7bd359e919a4fd74596 since '--resume' was not passed to initial.py or this crawler was daemonized.
Unhandled error in Deferred:
Unhandled error in Deferred:
Unhandled error in Deferred:
[newsplease.main:270|INFO] Graceful stop called manually. Shutting down.

_
Please help.

I've seen the error Unhandled error in Deferred multiple times and it was always related to a dependency issue. Which version of news-please are you using?
Your log contains several warnings about using an unspported version, e.g, /usr/local/lib/python3.5/dist-packages/requests/init.py:80: RequestsDependencyWarning: urllib3 (1.13.1) or chardet (2.3.0) doesn't match a supported version! RequestsDependencyWarning) Are you testing news-please on a fresh machine?

I'm closing this issue, feel free to reopen in case the issue remains.

authors: fhamborg perfecxus

repo: fhamborg/news-please


text:
🛑 Novios PE is down

In a7097dc, Novios PE (https://www.noviosfalabella.com.pe/novios-pe/public/inicio.do) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Novios PE is back up in da03574.

repo: fhonores/upptime


text:
I can not use addUsersToListWithID

This happening this error :
Error Domain=NSURLErrorDomain Code=-1012 "(null)" UserInfo={NSErrorFailingURLKey=https://api.twitter.com/1.1/lists/members/create_all.json, NSErrorFailingURLStringKey=https://api.twitter.com/1.1/lists/members/create_all.json, NSUnderlyingError=0x155a3490 {Error Domain=kCFErrorDomainCFNetwork Code=-1012 "(null)" UserInfo={_kCFURLErrorAuthFailedResponseKey=<CFURLResponse 0x15560230 [0x3aa38840]>{url = https://api.twitter.com/1.1/lists/members/create_all.json}}}}

@Thuran your app needs read/write permission

If you are using the demo app, it only has read only

It worked. Thank you

authors: Thuran dkhamsing

repo: fhsjaagshs/FHSTwitterEngine


text:
"No issues found" message if no checks return any errors/warnings

If I have an ESLint error or two, then fix them, I see nothing in the console that indicates that I have done so.
On top of that, the Typescript checker currently seems to emit its own message ("Found X errors. Watching for file changes"). However it's not clear that it's coming from TS.
Instead of the above, I propose this:

If all checkers run and there are no issues with any of them, print a pretty "No issues found, waiting for file changes..." message (maybe in green or something cool, maybe with a checkmark, idk)
Mute TypeScripts own message

OR

If a checker runs and there are no issues, print a pretty "[ESLint] No issues found, waiting for file changes..." message (so one for each checker)
Mute TypeScripts own message

The first solution is preferred I think, but if everything is running async the latter might be better.
In short, it should be clear when the checker(s) run and there were no issues, just to clarify that if there were previously issues, there are none anymore.

fixed in #61

This wasn't fixed in #61, it needs more work. E.g. the outputting of another message etc.

Found 0 errors. Watching for file changes. is the standard error message from the TSC in watch mode.
When there is an error, the message is in red, and very easy to see.

ERROR(TypeScript)  Property 'sa' does not exist on type 'PaletteColor'

Perhaps the all clear could be green? Prefix could be INFO, MESSAGE, SUCCESS, etc

INFO(TypeScript) Found 0 errors. Watching for file changes

implemented in 0.4.2. ESLint and VLS check summary are added.


text:
try npmcdn

See https://npmcdn.com, it could be perfect for client side additional functions.

now it is called unpack, I will try with cdnjs

repo: fibo/dflow


text:
Pressed on "Play" in Budgie Stream but there is no sound coming out of my speaker

Hello,
i just downloaded Budgie Stream and i started a song on YouTube, selected the speaker in Budgie Stream and pressed on play. But there is no sound coming out of it. There is a playlist with 4 stream.mp3 files but its not playing.

Sounds like it's something wrong in the capture stage. If it's possible for you then I would recommend firing up the dev environment and have a look at console output. I'm planning to implement a way to see the current status and catch errors in the client. But in the meantime try the dev environment

authors: filahf zMasterSkill

repo: filahf/budgie-stream


text:
bacalhau get is hanging

After processing some videos - I have about 30Mb of results from my job...
I was running the job with --wait which will try to use the download codepath so it can print stdout when finihsed
The problem is the bacalhau get code is hanging trying to download the CID - even after adding --timeout-secs 100000.  Using the ipfs cli however downloads it right away:
kai@xwing:~/projects/protocol-labs/example-files$ ipfs --api /ip4/127.0.0.1/tcp/34079 get /ipfs/QmS2r4MNtbE1dFERwEiMnhFY9dpzFQM8WjHQgDTu92LvDw/outputs
Saving file(s) to outputs
 28.13 MiB / 28.13 MiB [==============================================================================================================] 100.00% 0s

is this with devstack? does the local ipfs client need to be educated about devstackiness?

is this with devstack? does the local ipfs client need to be educated about devstackiness?

this is an excellent point thank you!

@binocarlos is this still an issue?

authors: binocarlos lukemarsden wdbaruni

repo: filecoin-project/bacalhau


text:
Client Allocation Request for: denchance

Client Allocation Questions
Core Information

Name: denchance
Website / Social Media: https://github.com/denchance
Region: Greater China
DataCap Requested: 5TiB
Addresses to be Notarized: f13vxumwujwwu3xpcrv2xrwjx5ni2thcv4jn7ruma
Notary Requested: swatchliu

@denchance Please subscribe to notifications for this Issue to be aware of updates. Notaries may request additional information on the Issue.

Closed


text:
Refactor go-f3 to Separate Simulation Code from GPBFT Library Implementation

The go-f3 library is designed to implement the GPBFT algorithm and is currently being prepared for integration with Lotus. Originally developed as a simulator, the library includes a sim package and other related packages used primarily for stress testing the implementation.
The presence of simulation-related packages within the production scope increases the API surface unnecessarily and potentially elevates the risk of errors. This configuration is not ideal for a production environment where a leaner, more secure implementation is preferable.
Proposed Solutions:

Move Simulation-Related Code to Test Scope: This would involve relocating the sim package and any other non-essential packages to the test directories. This reorganisation will clarify that these packages are intended for testing and not for production use.

Separate Simulator into a Different Go Module: By creating a distinct module for the simulator, the GPBFT implementation can reduce its exported APIs, focusing solely on functionalities critical to its operation.

Either way, the changes should streamline the library, minimising the exposed API surface and reducing the scope for errors for a smoother integration with Lotus.

I'm not familiar with Go workspaces, but I've heard you talk about them. Can we use them here to keep this code in one repository but separate logical modules? If so, sounds great.

Not worth doing. Closing.

authors: anorth masih


text:
feat: add STM annotations/增加STM注解

关联的Issues (Related Issues)

close filecoin-project/venus/issues/5306
改动 (Proposed Changes)

增加STM annotaiton
附注 (Additional Info)

自查清单 (Checklist)
在你认为本 PR 满足被审阅的标准之前，需要确保 / Before you mark the PR ready for review, please make sure that:

[ ] 符合Venus项目管理规范中关于PR的相关标准 / The PR follows the PR standards set out in the Venus project management guidelines
[ ] 具有清晰明确的commit message / All commits have a clear commit message.
[ ] 包含相关的的测试用例或者不需要新增测试用例 / This PR has tests for new functionality or change in behaviour or not need to add new tests.
[ ] 包含相关的的指南以及文档或者不需要新增文档 / This PR has updated usage guidelines and documentation or not need
[ ] 通过必要的检查项 / All checks are green

Codecov Report

Merging #103 (0dc5f2f) into feat/lt/refactor-user-related (3667cbc) will increase coverage by 3.33%.
The diff coverage is 50.00%.

Additional details and impacted files

@@                        Coverage Diff                        @@
##           feat/lt/refactor-user-related     #103      +/-   ##
=================================================================
+ Coverage                          42.36%   45.69%   +3.33%
=================================================================
  Files                                 35       35
  Lines                               3739     3729      -10
=================================================================
+ Hits                                1584     1704     +120
+ Misses                              1912     1814      -98
+ Partials                             243      211      -32

Flag
Coverage Δ

unittests
45.69% <50.00%> (+3.33%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

auth/transport.go
50.00% <ø> (ø)

storage/mysql.go
62.50% <0.00%> (+4.96%)
:arrow_up:

storage/store.go
56.20% <ø> (ø)

auth/app.go
51.18% <100.00%> (+15.90%)
:arrow_up:

storage/badger_helper.go
66.45% <0.00%> (+1.89%)
:arrow_up:

storage/badger.go
64.13% <0.00%> (+2.45%)
:arrow_up:

core/const.go
48.64% <0.00%> (+2.70%)
:arrow_up:

jwtclient/auth_client.go
63.49% <0.00%> (+3.85%)
:arrow_up:

auth/jwt.go
61.62% <0.00%> (+4.05%)
:arrow_up:

... and 1 more

repo: filecoin-project/venus-auth


text:
Not sure if right place if so let me know. Diskmgmt issue

Description
I cannot extend a drive in windows when there is a drive between as shown in the screenshot
Steps To Reproduce
Shrink a disk
Put a drive inbetween empty and one you want extended
Steps to fix
Not sure
Files Version
Not sure as i dont have custom one
Windows Version
11 22H2
Relevant Assets/Logs

This is not a Files issue.

This is not a Files issue. However, Aomei partition assistant will properly work for your use case to make sure you review the changes before running them

repo: files-community/Files


text:
Bug right click

Description
When i right click on a file, the app just crash...
Steps To Reproduce

Go into your Files app
Right click on any file
it will crash...

Steps to fix

eg. Fix crash that occurs when right clicking on a file

Files Version
Version 2.3.12.0
Windows Version
Windows 10 22H2 19045.2251
Relevant Assets/Logs
I didn't find the way too found them...

Can you please upload the debug.log and debug_fulltrust.log files directly to GitHub (email attachments don't work) . You can get them in files settings > about > open log folder.

Is this still an issue in the preview version? https://files.community/download/preview


text:
Bug relate cloud drive

Description
I have 2 error relate cloud drive

Red Color: I have 2 sharepoint (cicamt and Vilai Viet same as Win explorer), but in File (right), it shows only cicamt sharepoint, but when i click to cicamt folder, it show folder in vilai viet sharepoint. How can Files show both 2 sharepoint?
Green color: I use Autodesk Drive (https://drive.autodesk.com/) and it shows in Explorer same as a drive, can Files add Autodesk Docs and Drive as a cloud drive.

Thank you so much.
Steps To Reproduce
.
Steps to fix
.
Files Version
2.4.25.0
Windows Version
Win 10 22H2 19045.2486
Log file
debug.log

Thank you for your feedback, we're tracking the SharePoint issue here #4966. Can you open a feature request for Autodesk?


text:
Bug: Renaming item result in 2 files

Description
Re naming result in 2 files

Steps To Reproduce
Re name a file
Especially a zip file
Requirements
The previous file should not be there after a rename.
Files Version
2.5.21.0
Windows Version
10.0.22621.2134
Log File
debug.log

Thanks for the report. What the name your expecting?

Does refreshing the folder show the one file?

No. I did that too.
Both files exist. I had to delete the file manually after the rename.

Can you see if this is an issue in the preview version. https://files.community/download

Even in the release version this happens very rarely. So cannot confirm if it is fixed.

Does this only happen in the downloads folder?

I don't know if it happens only in the download folder.

Please let us know

@sirinath would you be able to upload a screen recording?

https://github.com/files-community/Files/assets/637415/e4b5efd7-094d-43e2-8098-e47b4ea96be0

Non download folder.
https://github.com/files-community/Files/assets/637415/44d2d207-1cc5-46e2-9bd7-3dbd1a0f6eb5

Is this only when dual pane is open? Can you also check if it's happening when turning off grouping?

@sirinath

Single plane it still happens.
If you have the same directory open in 2 tabs and do the renaming in you you get this in the other tab:

If you rename without grouping and without dual panel it is fine but if you have dual panel you get something like:

I can also replicate this issue in the latest preview version.

Thanks for the updates

Another issue is if you disable dual panel nothing happens to the current tab. You still have dual panel.
If you close and open then again nothing happens if you have it set to start from where you left off.


text:
Files stable

What feature or improvement do you think would benefit Files?
How come the download for Files does not have a version number, I have no idea what I downloading, if the same version or a newer version.
Currently running v3.7.0.0, its this the latest?
Requirements

This proposal will accomplish X
This proposal will accomplish Y
This proposal will accomplish Z
How come the download for Files does not have a version number,

Files Version
3.7.0.0
Windows Version
19045.4842
Comments
No response

3.7 is the latest for stable. Files won't show an install update button if no updates available, you can also check the Files discord https://discord.gg/files app updates channel or the website blog posts https://files.community/blog for what the latest version is

Thank you for your feedback, just to confirm, the confusion is that the website doesn't explicitly display the version number before you download?


text:
Recycle Bin deletes the format of my files

Description

When I accidentally delete a photo or document, when I recover it from the recycle bin, it loses its file format and I have to add it manually
Steps To Reproduce
No response
Expected behavior
Hope they can fix it
Files Version
Versión: 2.0.34.0 OS Version: 10.0.22000.348
Windows Version
Windows 11 21h2 (compilation SO 22000.348)
Relevant Assets/Logs
idk

Thanks for the report. This is fixed in latest code. In the meantime the workaround is to enable "show file extensions for known file types" option in Windows Explorer.


text:
Include language resources in the app package

This change will allow users to change the language even if the user did not install the region from the Windows settings app.

@duke7553 I updated the description.


text:
🛑 Website is down

In 07e8628, Website (https://filii.be/) was down:

HTTP code: 403
Response time: 159 ms

Resolved: Website is back up in 42a81d7.

repo: filii-lamberti/uptime


text:
Added directive and vue component data snippets

I think it's looking good, the directive snippets are specially helpful, try for yourself.
Some directive and other snippets are missing which I'll add as i need them, cheers.

Thanks man, now you're a collaborator :smile:

Thanks hehe, I don't know if you are using Vue + vue snippets atm but the directive snippets for html are damn useful. Cheers.

I'm not using Vue anymore. I'm studying other things to use in my job :disappointed:

Oh well, I'm happy to have introduced vuejs to the company I'm in, tho now the pressure is on me when something is not right so no easy routes.. abraço, depois faz update no packagecontrol.io qdo puderes a package já diz lá "trending" heheh, fica bem.

Do you have any other snippet which you want to add? I want to add a 1.0.0 release and update the package.io :smile:

I think it's fine for a 1.0.0 release, there are directives there are not there but it's a good release as it is. ( Normally i only add snippets as i need/use them)

authors: filipelinhares tiagolr

repo: filipelinhares/vuejs-snippets-sublime

license: WTFPL


text:
Regression when no data rows

[Sumitted on behalf of @msturdikova]
Seen in v3.0.1 in console on empty data set:
Canvas.js:305
TypeError: Cannot read property 'top' of undefined
at Constructor.paintGridlines (index.js:839)
at Constructor.paintCellsByColumnsAndRows (by-columns-and-rows.js:116)
at Constructor.renderGrid (index.js:559)
at Constructor.paint (index.js:198) | Error

Fixed in PR #742 : Hypergrid v3.0.2 which will be released today or over weekend.

repo: fin-hypergrid/core


text:
CalmHub: Store Architecture Decision Records (ADR)

Feature Request
Description of Problem:
Whilst centralising the store of patterns and architectures, it also makes sense to centralise the store of architecture decision records that accompany these assets.
Potential Solutions:

Pick a JSON structure to store ADRs
Create a RESTful API for managing ADRs and changing their status

Proposal for what the API could look like:
# Retrieve all ADRs in a namespace
GET /calm/namespaces/{namespace}/adrs
- Fetch all ADRs within a specific namespace.

# Create a new ADR in draft state
POST /calm/namespaces/{namespace}/adrs
- Create a new ADR in the draft state. Returns an ADR id.

# Update ADR state to proposed
PUT /calm/namespaces/{namespace}/adrs/{id}/propose
- Transition the ADR to the "Propose" state.

# Update ADR state to accepted
PUT /calm/namespaces/{namespace}/adrs/{id}/accept
- Transition the ADR to the "Accepted" state.

# Mark ADR as superseded
PUT /calm/namespaces/{namespace}/adrs/{id}/supersede
- Mark an ADR as superseded by another ADR. Accepts the id of the superseding ADR in the request body.

# Mark ADR as outdated
PUT /calm/namespaces/{namespace}/adrs/{id}/outdate
- Mark an ADR as outdated.

# Reject ADR
PUT /calm/namespaces/{namespace}/adrs/{id}/reject
- Transition the ADR to the "Rejected" state.

I'd propose that the body content of these is the MADR specification for ADRs in JSON: https://adr.github.io/madr/

What is the difference between outdate and supersede?

I'd propose that the body content of these is the MADR specification for ADRs in JSON: https://adr.github.io/madr/

JSON to make it schema-verifiable?  Markdown would be more human-friendly.
Also need to think about extensibility, as an organisation may want to add additional metadata, and potentially additional sections.

Presumably you'll also need GET /calm/namespaces/{namespace}/adrs/{id}...

What metadata would we expect to be returned for all ADRs?  E.g. created by, last updated data, etc.

Do we need to support querying the version history?
GET /calm/namespaces/{namespace}/adrs/{id}/history (returns a list of versionIDs with some other info about each)
and
GET /calm/namespaces/{namespace}/adrs/{id}/history/{versionID}

What is the difference between outdate and supersede?

@yt-ms from my perspective, outdated means that there has been a change in circumstances/architecture/direction meaning that this ADR is no longer relevant. Superseded is a form of outdated, but there is now a specific ADR that should be used instead. Some ADRs are outdated and out of the control of the team.

What metadata would we expect to be returned for all ADRs? E.g. created by, last updated data, etc.

I'll have a go at defining a sample JSON and adding it to this issue. I'll make sure to incorporate room for additional metadata. I'll also consider the history aspect.

What is the difference between outdate and supersede?

@yt-ms from my perspective, outdated means that there has been a change in circumstances/architecture/direction meaning that this ADR is no longer relevant. Superseded is a form of outdated, but there is now a specific ADR that should be used instead. Some ADRs are outdated and out of the control of the team.

OK, but if the current ADR is now wrong (even if not due to this team) then people need to know what they should be doing instead, so that feels like it's still superseded to me.
Having said that, the MADR docs have deprecated as a status, so we should probably align with that instead.

Revised API Paths:
# Retrieve all ADRs in a namespace
GET /calm/namespaces/{namespace}/adrs
- Fetch all ADRs within a specific namespace.

# Retrieve a specific ADR by ID
GET /calm/namespaces/{namespace}/adrs/{id}
- Fetch details of a specific ADR by its ID.

# Retrieve the version history of an ADR
GET /calm/namespaces/{namespace}/adrs/{id}/history
- Fetch the version history of a specific ADR.
- Returns a list of version IDs along with metadata for each version (e.g., timestamp, status, updatedBy).

# Retrieve a specific version of an ADR
GET /calm/namespaces/{namespace}/adrs/{id}/history/{versionID}
- Fetch the details of a specific version of an ADR.

# Create a new ADR in draft state
POST /calm/namespaces/{namespace}/adrs
- Create a new ADR in the draft state. Returns an ADR ID.

# Update ADR state to proposed
PUT /calm/namespaces/{namespace}/adrs/{id}/propose
- Transition the ADR to the "Propose" state.

# Update ADR state to accepted
PUT /calm/namespaces/{namespace}/adrs/{id}/accept
- Transition the ADR to the "Accepted" state.

# Mark ADR as superseded
PUT /calm/namespaces/{namespace}/adrs/{id}/supersede
- Mark an ADR as superseded by another ADR. Accepts the ID of the superseding ADR in the request body.

# Mark ADR as deprecated
PUT /calm/namespaces/{namespace}/adrs/{id}/deprecate
- Mark an ADR as deprecated.

# Reject ADR
PUT /calm/namespaces/{namespace}/adrs/{id}/reject
- Transition the ADR to the "Rejected" state.

JSON Schema for content of ADR returned:
{
  "$schema": "https://json-schema.org/draft/2020-12/schema",
  "title": "MADR Schema",
  "type": "object",
  "properties": {
    "title": {
      "type": "string",
      "description": "Title of the ADR"
    },
    "status": {
      "type": "string",
      "enum": ["Draft", "Proposed", "Accepted", "Superseded", "Rejected", "Outdated"],
      "description": "Current state of the ADR"
    },
    "date": {
      "type": "string",
      "format": "date",
      "description": "Date when the ADR was created"
    },
    "contextAndProblemStatement": {
      "type": "string",
      "description": "Description of the problem or context driving the decision"
    },
    "decisionDrivers": {
      "type": "array",
      "items": {
        "type": "string"
      },
      "description": "List of decision drivers"
    },
    "consideredOptions": {
      "type": "array",
      "items": {
        "type": "object",
        "properties": {
          "name": {
            "type": "string",
            "description": "Name of the option"
          },
          "description": {
            "type": "string",
            "description": "Description of the option"
          },
          "positiveConsequences": {
            "type": "array",
            "items": {
              "type": "string"
            },
            "description": "List of positive consequences"
          },
          "negativeConsequences": {
            "type": "array",
            "items": {
              "type": "string"
            },
            "description": "List of negative consequences"
          }
        },
        "required": ["name", "description"]
      },
      "description": "List of options considered"
    },
    "decisionOutcome": {
      "type": "object",
      "properties": {
        "chosenOption": {
          "type": "string",
          "description": "Chosen option"
        },
        "rationale": {
          "type": "string",
          "description": "Rationale for the decision"
        },
        "positiveConsequences": {
          "type": "array",
          "items": {
            "type": "string"
          },
          "description": "List of positive consequences"
        },
        "negativeConsequences": {
          "type": "array",
          "items": {
            "type": "string"
          },
          "description": "List of negative consequences"
        }
      },
      "required": ["chosenOption", "rationale"],
      "description": "Outcome of the decision"
    },
    "links": {
      "type": "array",
      "items": {
        "type": "object",
        "properties": {
          "rel": {
            "type": "string",
            "description": "Relationship type (e.g., 'reference', 'related')"
          },
          "href": {
            "type": "string",
            "format": "uri",
            "description": "URL or path"
          }
        },
        "required": ["rel", "href"]
      },
      "description": "Links to related resources"
    },
    "metadata": {
      "type": "object",
      "description": "Custom metadata for organizational use",
      "additionalProperties": {
        "anyOf": [
          { "type": "string" },
          { "type": "array", "items": { "type": "string" } },
          { "type": "object" }
        ]
      }
    }
  },
  "required": ["title", "status", "date", "contextAndProblemStatement", "decisionDrivers", "consideredOptions", "decisionOutcome"],
  "additionalProperties": false
}

JSON schema has "outdated" rather than "deprecated".

Can we give "date" a more descriptive name?  Is the creation date useful once it's been approved?

"positiveConsequences" and "negativeConsequences" is confusing two different things - the pros/cons of each option, and the consequences of the decision.  Can we rename to be "pros" and "cons" maybe?

Can you get JSON schema to validate that the content of a field is valid Markdown? ;)

authors: jpgough-ms yt-ms

repo: finos/architecture-as-code


text:
Method for sending additional fields with SMS

Firstly, thanks for really awesome work. I have used and tested this package for simple sms and it works on smppsim simulator. My real smpp provided wants addrton,dest_addr_ton, source_addr_npi and addr_npi to be provided. If I send sms without these fields using Submit method it says invalid source address.
Method func (t *Transmitter) Submit(sm *ShortMessage) (*ShortMessage, error) doesn't support a parmeter to send additional fields along with simple ones. May I suggest a new method with signature:
func (t *Transmitter) SubmitWithFields(sm *ShortMessage, fields map[string]interface{}) (*ShortMessage, error)
I tried implementing above using following code:

// SubmitWithFields sends a short message along with extra pdu fields and returns and updates the given
// sm with the response status. It returns the same sm object.
func (t *Transmitter) SubmitWithFields(sm *ShortMessage, fields map[string]int) (*ShortMessage, error) {
	p := pdu.NewSubmitSM()
	f := p.Fields()
	f.Set(pdufield.SourceAddr, sm.Src)
	f.Set(pdufield.DestinationAddr, sm.Dst)
	f.Set(pdufield.ShortMessage, sm.Text)
	f.Set(pdufield.RegisteredDelivery, uint8(sm.Register))
	for k, v := range fields {
		err := f.Set(pdufield.Name(k), v)
		if err != nil {
			return sm, fmt.Errorf("Couldn't set field %s with value %s. Error: %s", k, v, err)
		}
	}
	// Check if the message has validity set.
	if sm.Validity != time.Duration(0) {
		f.Set(pdufield.ValidityPeriod, convertValidity(sm.Validity))
	}
	resp, err := t.do(p)
	if err != nil {
		return nil, err
	}
	sm.resp.Lock()
	sm.resp.p = resp.PDU
	sm.resp.Unlock()
	if id := resp.PDU.Header().ID; id != pdu.SubmitSMRespID {
		return sm, fmt.Errorf("unexpected PDU ID: %s", id)
	}
	if s := resp.PDU.Header().Status; s != 0 {
		return sm, s
	}
	return sm, resp.Err
}

but when I submit with this method, smppsim disconnects and times out. Is there any better way via which I can send additional fields?

I'd rather extend the ShortMessage struct to support additional fields instead of creating another method for the Transmitter. This should be an easy fix, see transmitter.go for more.
I can work on this next week when I'm back home. Currently traveling with limited internet access and time.

Could you please share sample values you're using for your tests, for the extra PDUs?

Thanks for replying fast. Have a question if I am not bothering you on your trip:
Why is calling f.Set(pdufield.Name(k), v) causing packet to become malformed and showing exception in smppsim. Same method is being called for SourceAddr and DestinationAddr but as soon as I do f.Set(pdufield.Name("addr_ton"), 1) smppsim starts complaining and sends error: "timeout waiting for response" before disconnecting.

Ok, give it a try now and let me know if you have any troubles. I can reopen in case of problems, but according to the tests I've done it should work just fine now.

I love you man :D #nohomo

lol :)

authors: fiorix haisum

repo: fiorix/go-smpp


text:
Generalise assumed command-line format

<main_file> <parameter_file> is not the only way to run scripts, e.g. <main_file> <secondary_file>, or <secondary_file> <main_file>, multiple parameter files, arguments, options
Imported from Bitbucket issue 12,  created by apdavison on 06-26-2010 at 21:08, last modified: 02-14-2011 at 15:30

A proposal for implementing this:

<main_file> (supplied by the --main option to smt run, for example) may be a space-separated list of scripts
smt run may have any number of arguments. These are treated as follows:
a. test whether the arg is the path to a file. if so, try to interpret it as a parameter file. If this can't be done, it is taken to be a generic "input file", and stored in a new attribute of Record, inputs. We should perhaps store the md5sum of the file as well as its path, to catch the case that a different file is later created with the same name.
b. any args that look like "param=val" are treated as at present, and added to the parameter file
c. anything else is assumed to be an argument of the <main_file> script, passed on unchanged during launch, and added to Record.inputs.

I can think of two possibilities for storing inputs:

Put both input files (as datastore.DataFile objects) and script arguments in the same place: Record.inputs
Have separate attributes: Record.input_files and Record.script_arguments

I think option (1) is best, as it preserves the argument order. We can always provide the extra attributes in option (2) as properties giving views of Record.inputs.
We can probably generalize "check if it is a file" to "check if it exists in a DataStore" to support inputs that come from online databases, etc.
Trac comment by apdavison on 07-19-2010 at 16:47

Multiple arguments for smt run has been done in [177:6d960b24419c], although I didn't go for the Record.inputs idea in the end since it involved a lot more hassle in the DjangoRecordStore backend to keep the ordering right. Instead we have Record.input_data and Record.script_arguments. The latter is just a string.
Multiple main files remains to do.
Trac comment by apdavison on 07-20-2010 at 19:20

Support for multiple main files implemented in [210:2498dcbd8da1], although the implementation is rather simplistic and assumes no spaces in file names.
Trac comment by apdavison on 02-14-2011 at 15:30

repo: fipymigrate/sumatra


text:
Incorrect event names in API doc for $firebaseArray.$watch

The API doc for $firebaseArray.$watch (https://github.com/firebase/angularfire/blob/master/src/FirebaseArray.js#L245) is incorrect.
Wrong: { type: 'added|updated|moved|removed', key: 'key_of_item_affected'}
Right: { event: 'child_added|child_updated|child_moved|child_removed', key: 'key_of_item_affected'}

If you find yourself depending on those event names (i.e. listening to server events), it's likely that you've misunderstood the purpose of the AngularFire classes and there's probably a better way to accomplish your goals. I'm surprised to see, in fact, that we pass anything into the $watch callback. That should have been removed before the 1.0 release.
In general, using $extend to modify the $$added, $$updated, and $$removed would be more appropriate for manipulating data and intercepting server events.  Anything that can't be done with these should probably use a custom service and tap directly into the Firebase SDK.

BTW: the $watch method is also documented here: https://www.firebase.com/docs/web/libraries/angular/api.html#angularfire-firebasearray-watchcb-context

authors: gjungb katowulf

repo: firebase/angularfire


text:
$firebaseUtils.toJSON() drops keys starting with underscore

Version info
Angular: 1.5.6
Firebase: 3.6.2
AngularFire: 2.2.0
Issue
StackOverflow question

This was a design decision, based on the fact that a common JavaScript convention for declaring private variables is to prefix them with _.
For context on why it's different than the default SDK behavior, keep in mind that AngularFire is creating class instances that can be extended, and provide client-side functionality (not just raw JSON objects for data transfer). So our goal here is to make it as simple and straightforward as possible to extend and use $firebaseArray and $firebaseObject, and to make saving and server sync as transparent as possible.
To do so, you need a simple convention to separate "local" or private things from ones you want sent to the server. Since $ is technically reserved by the Angular libs, _ continues to be the appropriate way to prefix your private variables and methods pre-ES6.
We could revisit if there were significant numbers of people having issues here, but given that it's been implemented this way nearly 3 years and this is the first comment on it, I suspect it's fine as is.


text:
Documents nesting paths

Add nesting paths documentation to language.md.
Fix #194.

I signed it!

repo: firebase/bolt


text:
Add App-scoped API For Firebase Project management

App-scoped actions for Firebase apps within Firebase projects. Uses Firebase Management REST APIs (https://firebase.google.com/docs/projects/api/reference/rest/)

This PR only contains previously reviewed changes.

I fixed some iOS vs Android mistakes in the Javadoc for various methods in FirebaseProjectManagement. I will assign a reviewer in case there are comments about that change.

I also just adjusted the error codes list. Both Android certificates and Apps are handled by the same error codes map, so I changed the term "App" to simply "resource." Please take a look.

Still LGTM

Unfortunately I discovered more things to fix. :(

Thanks for the review. Aside from the asynchronous polling question that remains, we have another small issue: I noticed that for the AndroidApp.deleteShaCertificate() method, the caller must pass in a ShaCertificate, constructed with the name field set. This means we either force the caller to only be able to pass in a ShaCertificate returned by the getShaCertificates() method, or we should expose a public method allowing them to create a ShaCertificate with a caller-supplied name field. I think we should allow the user to delete Android SHA certificates without having to call getShaCertificates first, if they happen to know the full resource name of the certificate they want to delete prior to calling it, but this isn't that critical. Please let me know what you think.

Thank you for the reviews. I have added the client version header as we discussed.

authors: schmidt-sebastian weixifan xiangkangjw

repo: firebase/firebase-admin-java


text:
[FR]: Add - (void)setNumberOfStackFramesToSkipForNotFatalErrors:(NSUInteger)frames to Crashlytics

Description

When reporting non-fatal error to Crashlytics we might use our helper function or class
This cause errors to be shown with same title on our dashboard. See https://github.com/firebase/firebase-ios-sdk/issues/11474
Proposal:
add method to set number of stack trace frames to be skipped, e.g. - (void)setNumberOfStackFramesToSkipForNotFatalErrors:(NSUInteger)frames
remove given number of frames from error stack trace when reporting

API Proposal
@interface FIRCrashlytics
- (void)setNumberOfStackFramesToSkipForNotFatalErrors:(NSUInteger)frames;
@end

Firebase Product(s)
Crashlytics

similar to what BugSnag does:
https://docs.bugsnag.com/platforms/ios/customizing-error-reports/#modifying-stack-traces

repo: firebase/firebase-ios-sdk


text:
Firebase Message Create issue with Video recording

Xcode version: 11.2.1
Firebase SDK version: 6.12.0
Firebase Component: Messaging

The problem:
when i set message delegate self, it affect on recording video, the cancel button when recording video will disappear and after stop recording video Retake and Use Video also disappear and app freeze
Relevant Code:
Messaging.messaging().delegate = self
if #available(iOS 10.0, *) {
// For iOS 10 display notification (sent via APNS)
UNUserNotificationCenter.current().delegate = self
let authOptions: UNAuthorizationOptions = [.alert, .badge, .sound]
UNUserNotificationCenter.current().requestAuthorization(
options: authOptions,
completionHandler: {_, _ in })
// For iOS 10 data message (sent via FCM)
Messaging.messaging().delegate = self
}
To reproduce the problem:
// Messaging.messaging().delegate = self
all i done is hint the code but this create new issue i do not receive Token key so notification not working in this case

What object have you chosen as your messaging delegate? Can you share a full sample project?

//
//  LeimoNotificationManager.swift
//
//  Created by Mahmoud Elmoghazy on 6/18/19.
//  Copyright © 2019 Mawaqaa. All rights reserved.
//
import UIKit
import Foundation
import UserNotifications
import FirebaseFirestore
import Firebase
import FirebaseInstanceID
import FirebaseMessaging
class LeimoNotificationManager: NSObject, MessagingDelegate, UNUserNotificationCenterDelegate {
let userID: String
init(userID: String) {
    self.userID = userID
    super.init()
}

func registerForPushNotifications() {
    if #available(iOS 10.0, *) {
        // For iOS 10 display notification (sent via APNS)
        UNUserNotificationCenter.current().delegate = self
        let authOptions: UNAuthorizationOptions = [.alert, .badge, .sound]
        UNUserNotificationCenter.current().requestAuthorization(
            options: authOptions,
            completionHandler: {_, _ in })
        // For iOS 10 data message (sent via FCM)
        //Messaging.messaging().delegate = self
    } else {
        let settings: UIUserNotificationSettings =
            UIUserNotificationSettings(types: [.alert, .badge, .sound], categories: nil)
        UIApplication.shared.registerUserNotificationSettings(settings)
    }
    UIApplication.shared.registerForRemoteNotifications()
    updateFirestorePushTokenIfNeeded()
    updateBadgeCount()
}

func updateFirestorePushTokenIfNeeded() {
    if let token = Messaging.messaging().fcmToken {
        print("Firebase registration token: \(token)")
        let usersRef = Firestore.firestore().collection("users_table").document(userID)
        usersRef.setData(["fcmToken": token], merge: true)
    }
}

func messaging(_ messaging: Messaging, didReceive remoteMessage: MessagingRemoteMessage) {
    print(remoteMessage.appData)
}

func messaging(_ messaging: Messaging, didReceiveRegistrationToken fcmToken: String) {
    updateFirestorePushTokenIfNeeded()

    print("Firebase registration token: \(fcmToken)")
    GlobalVariablesManager.sharedManager.firebaseMessageTokenKey = fcmToken
    let dataDict:[String: String] = ["token": fcmToken]
    NotificationCenter.default.post(name: Notification.Name("FCMToken"), object: nil, userInfo: dataDict)

    LeimoDoLocalize.LeimoDoExchange()
}

@available(iOS 10.0, *)
func userNotificationCenter(_ center: UNUserNotificationCenter,  willPresent notification: UNNotification, withCompletionHandler completionHandler: @escaping (_ options: UNNotificationPresentationOptions) -> Void) {

    // Reading message body
    var messageBody:String?
    var messageTitle:String?
    let dict = notification.request.content.userInfo["aps"] as! NSDictionary

    if let alertDict = dict["alert"] as? Dictionary<String, String> {
        messageBody = alertDict["body"]!
        messageTitle = alertDict["title"]!
        if alertDict["title"] != nil {
            messageTitle  = alertDict["title"]!
        }
    }
    else{
        messageBody = dict["alert"] as? String
    }

    completionHandler([.alert,.sound, .badge])
    updateBadgeCount()
}

@available(iOS 10.0, *)
func userNotificationCenter(_ center: UNUserNotificationCenter, didReceive response: UNNotificationResponse, withCompletionHandler completionHandler: @escaping () -> Void) {

    // Reading message body
    var messageBody:String?
    var messageTitle:String?
    let dict = response.notification.request.content.userInfo["aps"] as! NSDictionary

    if let alertDict = dict["alert"] as? Dictionary<String, String> {
        messageBody = alertDict["body"]!
        messageTitle = alertDict["title"]!
        if alertDict["title"] != nil {
            messageTitle  = alertDict["title"]!
        }
    }
    else{
        messageBody = dict["alert"] as? String
    }
    updateBadgeCount()
}

func updateBadgeCount(){
    var badgeCount = UIApplication.shared.applicationIconBadgeNumber
    if badgeCount > 0{
        badgeCount = 0
    }
    UIApplication.shared.applicationIconBadgeNumber = badgeCount
}

}
// when ever want to push notifications to other users from device use this
//let sender = LeimoNotificationSenderManager()
//sender.sendPushNotification(to: GlobalVariablesManager.sharedManager.firebaseMessageTokenKey, title: "Notification title", body: "Notification body")
class LeimoNotificationSenderManager {
func sendPushNotification(to token: String, title: String, body: String) {
let urlString = "https://fcm.googleapis.com/fcm/send"
let url = NSURL(string: urlString)!
let paramString: [String : Any] = ["to" : token,
"notification" : ["title" : title, "body" : body],
"data" : ["user" : "test_id"]
]
let request = NSMutableURLRequest(url: url as URL)
request.httpMethod = "POST"
request.httpBody = try? JSONSerialization.data(withJSONObject:paramString, options: [.prettyPrinted])
request.setValue("application/json", forHTTPHeaderField: "Content-Type")
request.setValue(GlobalVariablesManager.sharedManager.FCMServerKey, forHTTPHeaderField: "Authorization")
let task =  URLSession.shared.dataTask(with: request as URLRequest)  { (data, response, error) in
do {
if let jsonData = data {
if let jsonDataDict  = try JSONSerialization.jsonObject(with: jsonData, options: JSONSerialization.ReadingOptions.allowFragments) as? [String: AnyObject] {
NSLog("Received data:\n(jsonDataDict))")
}
}
} catch let err as NSError {
print(err.debugDescription)
}
}
task.resume()
}
}
in AppDelegate
import Firebase
func application(_ application: UIApplication, didFinishLaunchingWithOptions launchOptions: [UIApplication.LaunchOptionsKey: Any]?) -> Bool {
    //Firebase notification
    FirebaseApp.configure()
    let pushManager = LeimoNotificationManager(userID: "")
    pushManager.registerForPushNotifications()

    return true
}

Messaging code shouldn't be interacting with video capture or camera code in any way, so if it is that's a bug. The sample code you shared doesn't include any camera-related code.
Can you try profiling the freeze when the bug happens to see what method call is causing the freeze?

Actually before Xcode 11 i never face this issue with  same application and same codes was working very fine, after upgrade Xcode to version 11, i find out this issue and i never thought it will be because firebase messaging, i was looking what make this issue in many files in the project and i was too surprised when i hint messaging delegate line and find out record video return work fine as should be, and to be clear it is not make app freeze as freeze but it remove cancel button, use video button and retake button and at this point user stuck and this lead user to close the application and open it again

The sample code you shared doesn't include any camera-related code.
Can you try profiling the freeze when the bug happens to see what method call is causing the freeze?


text:
Zip builder binary framework generation does not support bitcode

Xcode version: 11.6
Firebase SDK version: 6.27.0

I use Carthage and would like to build FirebaseFirestoreSwift. As mentioned in #5287  I am trying to use ZipBuilder.
Everything works great but when I try to create an archive build I get an error to bitcode support. So my question is how to support bitcode, when I build a binary framework with Zip builder?
Here's the command I used:
swift run ReleasePackager -templateDir $(pwd)/Template -zipPods pods.json
And this is the zipPods files pods.json:
[
  {
    "name": "FirebaseFirestoreSwift"
  }
]

Here is the error message:
bitcode bundle could not be generated because '/Users/erno/Library/Developer/Xcode/DerivedData/HorseRider-cmwsijeipqkrmbdpxmmyvqjbivnh/Build/Intermediates.noindex/ArchiveIntermediates/HorseRiderRelease/BuildProductsPath/Release-iphoneos/FirebaseFirestoreSwift.framework/FirebaseFirestoreSwift(CodableErrors.o)' was built without full bitcode. All object files and libraries for bitcode must be generated from Xcode Archive or Install build file '/Users/erno/Library/Developer/Xcode/DerivedData/HorseRider-cmwsijeipqkrmbdpxmmyvqjbivnh/Build/Intermediates.noindex/ArchiveIntermediates/HorseRiderRelease/BuildProductsPath/Release-iphoneos/FirebaseFirestoreSwift.framework/FirebaseFirestoreSwift' for architecture arm64

@agergely Thanks for the report A few follow up questions:
What Xcode version was the xcframework built with? What Xcode version is the app built with?
Does bitcode show in the binary. From this stackoverflow post:
$ otool -l FirebaseFirestoreSwift.xcframework/ios-arm64_armv7/FirebaseFirestoreSwift.framework/FirebaseFirestoreSwift  | grep __LLVM | head
   segname __LLVM
   segname __LLVM
   segname __LLVM
   segname __LLVM
   segname __LLVM
   segname __LLVM
   segname __LLVM
   segname __LLVM
   segname __LLVM
   segname __LLVM
$ otool -l FirebaseFirestoreSwift.xcframework/ios-arm64_armv7/FirebaseFirestoreSwift.framework/FirebaseFirestoreSwift  | grep bitcode | head
  sectname __bitcode
  sectname __bitcode
  sectname __bitcode
  sectname __bitcode
  sectname __bitcode
  sectname __bitcode
  sectname __bitcode
  sectname __bitcode
  sectname __bitcode
  sectname __bitcode

BTW, the build is faster with
swift run ReleasePackager -templateDir $(pwd)/Template -zipPods pods.json -buildDependencies NO

@paulb777 Thanks for your reply.
The framework and the app were built with the same version: XCode 11.6
Thanks for the suggestion. I've checked the tool and got the same result as you.
.../FirebaseFirestoreSwift | grep __LLVM | head
   segname __LLVM
   segname __LLVM
   segname __LLVM
   segname __LLVM
   segname __LLVM
   segname __LLVM
   segname __LLVM
   segname __LLVM
   segname __LLVM
   segname __LLVM

And
.../FirebaseFirestoreSwift | grep bitcode | head
  sectname __bitcode
  sectname __bitcode
  sectname __bitcode
  sectname __bitcode
  sectname __bitcode
  sectname __bitcode
  sectname __bitcode
  sectname __bitcode
  sectname __bitcode
  sectname __bitcode

But I still cannot make a successful archive build. Do you have any idea?

@agergely Sorry about the inconvenience and thanks for the report.
I was able to reproduce the issue, track down a fix, and successfully archive an app with the rebuild FirebaseFirestoreSwift.xcframework.
See #6366

@paulb777 Thank you so much, it sounds great!
I am excited about your MR and I'm waiting for it to try it out.

I've tested and It is working. Thank you so much again for the quick fix!