text:
Add initial documentation

The goal of this PR is to start the conversation about the documentation.
Idea is to work together to build an initial documentation version including legal information, samples, etc.
Included so far:

Draft of the index page
Draft of the samples documentation

It's a great start for issue #32
We should also document the config settings and what each of them do, what the defaults are etc.

We should also document the config settings and what each of them do, what the defaults are etc.

We should also document the config settings and what each of them do, what the defaults are etc.

I have added the configuration information, please take a look.

I also would like to set the expectation right for people looking at the repository, stating that this is in development and there are no guarantees. No SLAs, not built-in Azure.
How would you phrase that? There might be a common test already used in different projects we can reuse.

Can you remove Draft from this so we can merge what you have so that others can take this task and work on it

authors: fbeltrao ryancrawcour


text:
Provision Traffic Manager profile per environment

Via terraform, we should provision a traffic manager profile that has endpoints identified by the IP addresses provisioned by #207

The traffic manager profile is created per environment with Multiple AKS Clusters Deployment with Azure Traffic Manager template. Are you using this template or a different one?

source: gharchive/issue

authors: bnookala sarath-p

repo: Microsoft/bedrock

license: MIT

license_type: permissive

license_source: github-api


text:
AI.Luis project exists in samples/ but doesn't compile when added to Solution

We should delete the project from the repo, or add to SLN & fix it so it compiles

Working on it to make it alive again

fixed in #331

authors: brandonh-msft cleemullins nrobert

repo: Microsoft/botbuilder-dotnet


text:
Attachments with incorrect base64 contentUrl in sendActivity fails silently

Versions
What package version of the SDK are you using: 4.0.8 (botbuilder, botbuilder-dialogs)
What nodejs version are you using:  v.8.12.0
What browser version are you using: Chrome v69
What os are you using: Windows 10
Describe the bug
When trying to create an attachment that is intentionally corrupt (via an incorrect base64 url), the bot fails silently without throwing an error.
To Reproduce

Create bot with command to trigger send activity with an attachment with the following code:

  try {
    console.log('Start');

    await context.sendActivity({
      type: 'message',
      attachments: [{
        contentType: 'text/plain',
        contentUrl: 'data:image/png;base64,abc\nabc',
        name: 'dot.png'
      }]
    });

    console.log('Succeeded');
  } catch (err) {
    console.log(err);
    throw err;
  }

And on the BotFrameworkAdapter instance, register an onTurnError handler like so:
adapter.onTurnError = async (context, error) => {
  console.log(error);
  await context.sendActivity(`Sorry, ran into an error!\n  ${ error.message }`);
}

Run bot, send command utterance to send activity
Sending the command failed
Note that there is no error in the console, and the line console.log("Succeeded"); is never reached. Similarly, onTurnError is never triggered.

The message fails silently, and after timing out, the Web Chat instance logs a 502 Bad Gateway error.
Sending other messages pass through successfully.
Expected behavior
Since the contentUrl is invalid, the bot should try and catch an error when this command is initiated.
[bug]

Update: Currently not reproing with botbuilder 4.1.7 and the emulator 4.1.0

Was able to repro with the full-bundle sample from WebChat, spoke with @compulim in person and he agreed it is a WebChat issue. @daveta can you transfer this to WebChat please?

authors: corinagum stevengum

repo: Microsoft/botbuilder-js


text:
Run tests before check ESLint rules

Proposed Changes

Run tests before check ESLint rules.
Disable ESLint indent rule.

Pull Request Test Coverage Report for Build 992

0 of 0   changed or added relevant lines in 0 files are covered.
241 unchanged lines in 14 files lost coverage.
Overall coverage decreased (-5.4%) to 63.856%

Files with Coverage Reduction
New Missed Lines
%

packages/Ludown/lib/ludown-translate.js
1
96.67%

packages/QnAMaker/lib/api/knowledgebase.js
1
50.0%

packages/QnAMaker/lib/api/createasync.js
2
50.0%

packages/QnAMaker/lib/api/operations.js
2
50.0%

packages/QnAMaker/lib/api/knowledgebases.js
2
50.0%

packages/QnAMaker/lib/api/dataModels/updateKbOperationDto.js
4
15.38%

packages/QnAMaker/lib/api/dataModels/metadataDto.js
6
14.29%

packages/QnAMaker/lib/api/dataModels/fileDto.js
6
14.29%

packages/QnAMaker/lib/api/dataModels/createKbDto.js
7
18.18%

packages/QnAMaker/lib/api/dataModels/qnAdto.js
7
16.67%

Totals

Change from base Build 990:
-5.4%

Covered Lines:
3187

Relevant Lines:
4750

💛  - Coveralls

source: gharchive/pull-request

authors: coveralls enzocanoo

repo: Microsoft/botbuilder-tools


text:
Add ref counting to DacLibrary to prevent AV when app is exiting

#126
This fixes an AV that can happen when the application is shutting down. CallableCOMWrapper holds a ref to the DAC lib, but the CallableCOMWrapper dtor assumes that the DAC lib dtor is always called after its own dtor. This is not always true when the app is shutting down.
ClrRuntime now implements IDisposable and has a dtor so DacLibrary can be freed.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: 0xd4d sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

Thank you for the PR!  I decided to go a slightly different direction to fix this:  https://github.com/Microsoft/clrmd/commit/4a16cfa3c42a1c5f8899aa772543a72dd9b63622
Instead of putting Dispose on ClrRuntime, I wanted to put that on DacLibrary instead, as I use DacLibrary directly in some of my projects.  I've also split out the code to actually release the library into its own class with its own lifetime.
I'm not done with lifetime management here.  I still want the call to DataTarget.Dispose to clean up everything instead of waiting for finalizers.  I also need to go through and fully test all the addref/release to make sure everything is clean.
For now though, this should stop the AVs.  If it doesn't please let me know and I'll reopen the issue and take another swing.

authors: 0xd4d leculver msftclas

repo: Microsoft/clrmd

license: mit

license_source: bigquery


text:
Xcopy not working -

Hi, Could it be that xcopy is not working anymore?
PS C:\> xcopy
PS C:\> echo $LASTEXITCODE
-1073741511
PS C:\> xcopy -version
-1073741511
Tested on latest dotnet-framework and dotnet-framework-build (Deprecated) images.
Heard of other people having the same issue and "fixed" it by using an older image.
Host: Windows 2016 Server Datacenter
DockerEE: Docker version 17.06.2-ee-8, build 4e8ed51
Thanks,
Ignacio

@ideabelleyra - Can you provide the specific steps used to reproduce this?  I tried the following, which works as expected.

docker pull microsoft/dotnet-framework:latest
docker run --rm microsoft/dotnet-framework:latest xcopy /?

Hi Michael, thanks a lot for your help.
Did command #2 provide any output?
 C:\Users\Administrator> docker pull microsoft/dotnet-framework:latest
latest: Pulling from microsoft/dotnet-framework
Digest: sha256:9939fe883e17d61198733806dca6df4ae6bd562226ceb24627e39d09328aca1c
Status: Image is up to date for microsoft/dotnet-framework:latest
PS C:\Users\Administrator> docker run --rm microsoft/dotnet-framework:latest xcopy /?
PS C:\Users\Administrator>
Specific steps used to reproduce the error:
A) What I did was get into the container by running:  docker exec -it <container_id> powershell
B) Then I did run the xcopy command inside the container: xcopy /?
C) As it did not provide any output I did run echo $LASTEXITCODE in order to retrieve the "xcopy /?" command's exit code. I got -1073741511 as exit code.
Cannot even find what this error code number means in the web.
Thanks,

Thank you,

When you run docker exec -it <container_id> powershell, what image is the container you are using based on?

docker inspect <container_id> shows:
"Image": "microsoft/dotnet-framework:latest",

and
"Image": "sha256:023c98ee4c6b950c468e790e1febf1c4f0babd124f1079a2b66948eb904a2b01",

While docker ps shows:
REPOSITORY                         TAG            IMAGE ID            CREATED             SIZE
microsoft/dotnet-framework         latest         023c98ee4c6b        10 days ago         12.6GB

What happens when you run docker run --rm microsoft/windowsservercore:latest xcopy /??

It takes me back to the command prompt, and does not show any output at all:
PS C:\Users\Administrator> docker run --rm microsoft/windowsservercore:latest xcopy /? PS C:\Users\Administrator>

Can you include the output of docker info?

Containers: 1
 Running: 1
 Paused: 0
 Stopped: 0
Images: 15
Server Version: 17.06.2-ee-8
Storage Driver: windowsfilter
 Windows:
Logging Driver: json-file
Plugins:
 Volume: local
 Network: l2bridge l2tunnel nat null overlay transparent
 Log: awslogs etwlogs fluentd json-file logentries splunk syslog
Swarm: inactive
Default Isolation: process
Kernel Version: 10.0 14393 (14393.447.amd64fre.rs1_release_inmarket.161102-0100)
Operating System: Windows Server 2016 Standard
OSType: windows
Architecture: x86_64
CPUs: 1
Total Memory: 4GiB
Name: WIN-NF1EHB05SS5
ID: 5Q6K:LAIA:R4PV:DBKS:HA7M:RC5P:6LJC:OPVT:CYQW:MJ3Q:5AYI:Y7XR
Docker Root Dir: C:\ProgramData\docker
Debug Mode (client): false
Debug Mode (server): false
Registry: https://index.docker.io/v1/
Experimental: false
Insecure Registries:
 127.0.0.0/8
Live Restore Enabled: false

It is strange

I presume you get a similar behavior (e.g. no std output appearing) when you run something like docker run --rm microsoft/windowsservercore:latest dir?  What happens if you try to run something interactive?

docker run -it --rm microsoft/windowsservercore:latest
xcopy /?

I'm not sure I am going to be much help on this one.  Something is different about your Docker environment that I can't put a finger on immediately.  We've shown this is not something specific to the microsoft/dotnet-framework images.  You might have better luck getting an answer on StackOverflow where the audience is much larger or logging an issue with Docker
Closing issue as this is not specific to microsoft/dotnet-framework.  Feel free to continue the conversation and post anything you find.

docker run --rm microsoft/windowsservercore:latest dir

I get the following error:
PS C:\Users\Administrator> docker run --rm microsoft/windowsservercore:latest dir
C:\Program Files\Docker\docker.exe: Error response from daemon:
container 44bd2da05093bc54cdce9a721a5faf398e086ce8bf4583366a31e220a0971311
encountered an error during CreateProcess:
failure in a Windows system call:
The system cannot find the file specified.
(0x2) extra info: {"ApplicationName":"","CommandLine":"dir","User":"","WorkingDirectory":
"C:\\","Environment":{},"EmulateConsole":false,"CreateStdInPipe":true,"CreateStdOutPipe":
true,"CreateStdErrPipe":true,
"ConsoleSize":[0,0]}.
PS C:\Users\Administrator>

docker run -it --rm microsoft/windowsservercore:latest
2.xcopy /?

Microsoft Windows [Version 10.0.14393]
(c) 2016 Microsoft Corporation. All rights reserved.

C:\>xcopy /?
C:\>

MichaelSimons closed this 3 minutes ago

Thank you for your help, I understand.

@ideabelleyra @MichaelSimons  I am facing similar issue. I am using base image as microsoft/windowsservercore. xcopy is returning the same error code (-1073741511). Any idea how to fix this ?

Facing the same issue.

This is an issue to take up with the Windows base images.  Please post in Windows Containers forum.

authors: Francommit MichaelSimons RenganathanV ideabelleyra

repo: Microsoft/dotnet-framework-docker


text:
fix pr-commit relationship

changed pullrequest to have a collection of commits rather than a relation (revert a change from a few days ago)
make the commits collection pull-request specific (i.e., pull_request_commits)

Note that the individual commit objects are still of type "commit", not pull_request_commit.  I think that still makes sense.

Hi @jeffmcaffer, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

It looks like you're a Microsoft contributor (Jeff McAffer). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;

authors: jeffmcaffer msftclas

repo: Microsoft/ghcrawler


text:
Unable to create a network with "NetBIOS over Tcpip" disabled

We are using struct HNSNetwork to create a network and would like to set the "NetBIOS over Tcpip" to disabled on network creation. After looking through the api, we were not able to find a way to do this. Is this use-case supported by hcsshim?
cc @sophiewigmore

To the best of my knowledge, it's not a scenario that's been considered. But I'd have to defer to the networking team to comment further. @davidschott

repo: Microsoft/hcsshim


text:
Unable to build or run microsoft/iis image due to error: The driver was not loaded because it failed its initialization call.

Issue: Unable to build or run microsoft/iis docker images
Environment: Microsoft Windows 10 Version 1803 (OS Build 17134.165)
Error:
container <sha1> encountered an error during Start: failure in a Windows system call: The driver was not loaded because it failed its initialization call. (0x287)

Procedure:

Pulled microsoft/iis image. (also attempted on microsoft/iis:windowsservercore-1803 image)
Attempted to build the pulled microsoft/iis image

Dockerfile:
FROM microsoft/iis

RUN powershell -NoProfile -Command Remove-Item -Recurse C:\inetpub\wwwroot\*

WORKDIR /inetpub/wwwroot

COPY ./Executables/ .
COPY ./HostWebServer/ .

Output:
PS C:\Users\xxxxx\Documents\WORKDIR\xxxxx> docker build -t testimg .
Sending build context to Docker daemon  3.714MB
Step 1/6 : FROM microsoft/iis
 ---> 248afbbe0fd1
Step 2/6 : SHELL ["powershell"]
 ---> Running in fea62fa54616
Removing intermediate container fea62fa54616
 ---> 8c0aa999c671
Step 3/6 : RUN Remove-Item -Recurse C:\inetpub\wwwroot\*
 ---> Running in 9090104f6805
container 9090104f6805d52797163bb335174a5ca45e674282e0b12a395af6c6220bc5eb encountered an error during Start: failure in a Windows system call: The driver was not loaded because it failed its initialization call. (0x287)

Docker info
Containers: 2
 Running: 0
 Paused: 0
 Stopped: 2
Images: 4
Server Version: 18.03.1-ce
Storage Driver: windowsfilter
 Windows:
Logging Driver: json-file
Plugins:
 Volume: local
 Network: ics l2bridge l2tunnel nat null overlay transparent
 Log: awslogs etwlogs fluentd gelf json-file logentries splunk syslog
Swarm: inactive
Default Isolation: hyperv
Kernel Version: 10.0 17134 (17134.1.amd64fre.rs4_release.180410-1804)
Operating System: Windows 10 Pro
OSType: windows
Architecture: x86_64
CPUs: 8
Total Memory: 15.89GiB
Name: MyComputer
ID: H6NA:JZQF:OU6J:Q4RB:KF2N:APGW:2Z7Z:V6RP:MS5C:H73U:KWNN:DLF3
Docker Root Dir: C:\ProgramData\Docker
Debug Mode (client): false
Debug Mode (server): true
 File Descriptors: -1
 Goroutines: 27
 System Time: 2018-07-23T17:48:15.7928097+09:00
 EventsListeners: 0
Registry: https://index.docker.io/v1/
Labels:
Experimental: false
Insecure Registries:
 127.0.0.0/8
Live Restore Enabled: false

Making a container directly from the microsoft/iis image gives the same error:
PS C:\Users\xxxxx\Documents\WORKDIR\xxxxx> docker run -it microsoft/iis powershell
C:\Program Files\Docker\Docker\Resources\bin\docker.exe: Error response from daemon: container 306db7788b403d8e468c82d45de8a23bf27f95787676733cc9ec5e19a09b95e9 encountered an error during Start: failure in a Windows system call: The driver was not loaded because it failed its initialization call. (0x287).

If there are any other information needed, I will gladly provide.
This is driving me nuts. Haha

I believe this issue better belongs under docker/for-win.
Please refer to newly created issue.

repo: Microsoft/iis-docker


text:
Delete folder sends no message.

When I delete a file I get the "workspace/didChangeWatchedFiles" message, but nothing seems to happen when I remove a folder full of files.
I have the following setup:
let clientOptions: LanguageClientOptions = {
        documentSelector: [LanguageId, 'json'],
        synchronize: {
            configurationSection: LanguageId,
            fileEvents: vscode.workspace.createFileSystemWatcher('**/*.foo')
        }
    }

Is it by design or have I missed something?

This issue was moved to Microsoft/vscode-languageserver-node#141

This should be discussed on the implementation side.

authors: PedersenThomas dbaeumer

repo: Microsoft/language-server-protocol


text:
Added more property function fastpaths

Added all functions from #3051

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: BenVillalobos sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

fyi @KirillOsenkov

authors: BenVillalobos dnfclas rainersigwald

repo: Microsoft/msbuild


text:
Update Setup / Shim Files

Update setup vsix package (renamed package to Microsoft.Build).
Add default MSBuild.rsp (we ship with this today).
Add shim files to setup package and renamed for consistency.

These changes are made to match the setup package we produce internally with what we currently ship.

:shipit:

authors: AndyGerlicher rainersigwald


text:
CDC does not work with CU8

Project Debezium is used to stream CDC events from (not only) SQL Server database into Kafka. We have been developing the SQL Sever plugin with CU8 and CDC worked nicely OOTB. After CU9 update the CDC tables are created but not populated. Comparing the startup log between CU8 and CU9 we see these last lines missing
   Configuration option 'show advanced options' changed from 0 to 1. Run the RECONFIGURE statement to install.
13:41:35.969 sqlserver
2018-07-24 11:41:35.96 spid51      Configuration option 'Agent XPs' changed from 0 to 1. Run the RECONFIGURE statement to install.
13:41:35.996 sqlserver
2018-07-24 11:41:35.99 spid51      Configuration option 'show advanced options' changed from 1 to 0. Run the RECONFIGURE statement to install.
13:41:36.195 sqlserver
2018-07-24 11:41:36.19 spid51      Attempting to load library 'xpsqlbot.dll' into memory. This is an informational message only. No user action is required.
13:41:36.201 sqlserver
2018-07-24 11:41:36.19 spid51      Using 'xpsqlbot.dll' version '2017.140.3029' to execute extended stored procedure 'xp_qv'. This is an informational message only; no user action is required.
13:41:36.271 sqlserver
2018-07-24 11:41:36.27 spid51      Attempting to load library 'xpstar.dll' into memory. This is an informational message only. No user action is required.
13:41:36.309 sqlserver
2018-07-24 11:41:36.30 spid51      Using 'xpstar.dll' version '2017.140.3029' to execute extended stored procedure 'xp_sqlagent_notify'. This is an informational message only; no user action is required.

Does default confiugration changed somehow?
Thanks a lot

is this SQL Server on Linux containers? are you using the SQL Server CDC feature? this is not supported on Linux at the moment.
https://docs.microsoft.com/en-us/sql/linux/sql-server-linux-release-notes?view=sql-server-linux-2017#Unsupported
what SQL Server functionality does Project Debezium require?

Hi, yes this is on Linux containers. We are using SQL Server on Linux containers for development and testing purposes - https://github.com/debezium/debezium-incubator/pull/12. It is not important for us if the feature itself is supported or not in the sense of commercial support. But I can positively confirm that it worked in CU8 image and is not working in CU9 any longer. And as I mentioned the log output has change between image tags hence I have a suspicion that some services are not started now.

can you try adding the MSSQL_AGENT_ENABLED environment variable in your docker run? From CU4-8 Agent was started automatically in containers, but it is now off by default and we have introduced a flag to turn it on.
Example:

docker run -e "ACCEPT_EULA=Y" -e "SA_PASSWORD=<YourStrong!Passw0rd>" -e "MSSQL_AGENT_ENABLED=true" `
   -p 1433:1433 --name sql1 `
   -d microsoft/mssql-server-linux:2017-latest

Yeah, that was it thanks! Unfortunately the env var is not document neither in Docker Hub doc (https://hub.docker.com/r/microsoft/mssql-server-linux/) nor in the list of all env vars https://docs.microsoft.com/en-us/sql/linux/quickstart-install-connect-docker?view=sql-server-linux-2017

The full list of env vars is documented here:  https://docs.microsoft.com/en-us/sql/linux/sql-server-linux-configure-environment-variables?view=sql-server-linux-2017

authors: jpechane twright-msft vin-yu

repo: Microsoft/mssql-docker


text:
Allow Mocha to be installed Globally

Hello,
I have a Visual Studio solution which contains multiple Node.js projects. I would like to run all tests of all projects using mocha. For that I have to install mocha for every project locally, so that the tests can be found by NTVS. So I'll have mocha installed multiple times on my harddrive. Isn't it possible to have it installed once only?
Thanks,
Natascha

I needed this for one of my setups. I sent a pull request to improve the module look up: #1456.
@SchmuckerN do you want to give it a try and see if that works for you? You can just replace your existing mocha.js file under the path "C:\Program Files (x86)\Microsoft Visual Studio 14.0\Common7\IDE\Extensions\Microsoft\Node.js Tools for Visual Studio\1.1\TestFrameworks\Mocha\mocha.js" with the file in the pull request (please keep a backup before you replace it).

authors: SchmuckerN andreesteve

repo: Microsoft/nodejstools


text:
vcpkg update check keeps warning to update after running bootstrap.

Vcpkg keeps reporting an update to be available. After running .\bootstrap-vcpkg.bat.
vcpkg update returns:
Warning: Different source is available for vcpkg (0.0.113 -> 2018.10.20). Use .\bootstrap-vcpkg.bat to update.
There were no build errors.

Thanks for the bug report!
Could you confirm which vcpkg you're using and what the local version is?
D:\src\vcpkg> vcpkg version
Vcpkg package management program version 2018.10.20

See LICENSE.txt for license information.
D:\src\vcpkg> where.exe vcpkg
D:\src\vcpkg\toolsrc\x64\Release\vcpkg.exe
D:\src\vcpkg> type .\toolsrc\VERSION.txt
"2018.10.20"

On Win10 with VS2017, and a WSL install using the same directory.
Only the windows version shows this issue.
C:\src\vcpkg [master ≡]> git pull
Already up to date.
C:\src\vcpkg [master ≡]> .\bootstrap-vcpkg.bat

Building vcpkg.exe ...
....
  vcpkglib.vcxproj -> C:\src\vcpkg\toolsrc\Build\Win32\Release\vcpkglib.lib
  vcpkg.cpp
  Generating code
  All 15263 functions were compiled because no usable IPDB/IOBJ from previous compilation was found.
  Finished generating code
  vcpkg.vcxproj -> C:\src\vcpkg\toolsrc\Build\Win32\Release\vcpkg.exe
  vcpkgmetricsuploader.cpp
  Generating code
  All 5401 functions were compiled because no usable IPDB/IOBJ from previous compilation was found.
  Finished generating code
  vcpkgmetricsuploader.vcxproj -> C:\src\vcpkg\toolsrc\Build\Win32\Release\vcpkgmetricsuploader.exe

Building vcpkg.exe... done.
C:\src\vcpkg [master ≡]> vcpkg update
Warning: Different source is available for vcpkg (0.0.113 -> 2018.10.20). Use .\bootstrap-vcpkg.bat to update.
Using local portfile versions. To update the local portfiles, use `git pull`.
No packages need updating.
C:\src\vcpkg [master ≡]> vcpkg version
Vcpkg package management program version 0.0.113-nohash

See LICENSE.txt for license information.
C:\src\vcpkg [master ≡]> where.exe vcpkg
C:\src\vcpkg\vcpkg
C:\src\vcpkg\vcpkg.exe
C:\src\vcpkg [master ≡]> type .\toolsrc\VERSION.txt
"2018.10.20"

After looking at this, I noticed that while the executable for Linux (C:\src\vcpkg\vcpkg) has a recent modification date, the Windows executable (C:\src\vcpkg\vcpkg.exe) was last modified at May 22.
New builds are now generated in .\toolsrc\Build\Win32\Release.
While the old build-files (dated in May) remain in .\toolsrc\Release.

The problem here is that the build is happening in .\toolsrc\Build\Win32\Release.
We expect it to be at .\toolsrc\Release.
We do a build, and then we copy the file to the vcpkg root after the build:
Copy-Item "$vcpkgReleaseDir\vcpkg.exe" "$vcpkgRootDir\vcpkg.exe"

It looks like there is an old build in \toolsrc\Release, so in your case, the script is doing a build in another dir, completely ignores that dir and then copies vcpkg.exe from the old build.
I am wondering why your build directory is what it is, but regardless: please try this branch
https://github.com/Microsoft/vcpkg/tree/dev/alkarata/bootstrapOutDir
It explicitly sets the output directory which should render us unaffected to issues like this.

Related: #3641
@aalpert-bluescape This also addresses your case-sensitivity issue. Please let me know if it indeed does.

@alexkaratarakis Doesn't look like this branch helps for that issue. I'll reproduce the error message I get:
Building vcpkg.exe ...

  pch.cpp
CL : fatal error C1083: Cannot open compiler intermediate file: 'c:\dev\vcpkg\toolsrc\vcpkglib\release\vcpkglib.pch': No such file or directory [C:\dev\vcpkg\toolsrc\vcpkglib\vcpkglib.vcxproj]

The problem is that it's looking for 'c:\dev\vcpkg\toolsrc\vcpkglib\release\vcpkglib.pch', when the file is 'C:\dev\vcpkg\toolsrc\vcpkglib\Release\vcpkglib.pch'. Your branch appears to only change the output dir for the vcpkg.exe built executable to 'toolsrc\msbuild.rel.x86', but I'm still seeing the intermediate files in 'toolsrc\vcpkglib\Release'.

@aalpert-bluescape
I missed the intermediate paths. Alright, I modified the vcxproj files to explicitly specify output AND intermediate path. Since I am doing that, I made the build be out-of-source. I have pushed the changes to the same same branch.
https://github.com/Microsoft/vcpkg/tree/dev/alkarata/bootstrapOutDir
@Farwaykorse Please let me know if the branch fixes your issue.
I made the output path in vcxproj the same as the OutDir override in bootstrap so if it does NOT fix the issue, I will remove the OutDir parameter and look into ignoring props files, which I suspect are the cause of this.

@alexkaratarakis the branch dev/alkarata/bootstrapOutDir @ commit f89621e works for me.
Though I did notice double backslashes in the paths.
  vcpkglib.vcxproj -> C:\src\vcpkg\toolsrc\msbuild.x86.release\\vcpkglib.lib
[...]
  vcpkg.vcxproj -> C:\src\vcpkg\toolsrc\msbuild.x86.release\\vcpkg.exe
[...]
  vcpkgmetricsuploader.vcxproj -> C:\src\vcpkg\toolsrc\msbuild.x86.release\\vcpkgmetricsuploader.exe

I found the reason for my issue (the paths did seem somewhat familiar...).
I've modified my default output and intermediate directories in Microsoft.Cpp.(x64/Win32).user.props to use the Build\$(Platform) directory.
Hardening dependencies should work against this.
Or maybe better, unless you want to offer this kind of customisation, would be to remove the inclusion of user defined default properties from the .vcxproj files.
<Import Project="$(UserRootDir)\Microsoft.Cpp.$(Platform).user.props" Condition="exists('$(UserRootDir)\Microsoft.Cpp.$(Platform).user.props')" Label="LocalAppDataPlatform" />

@alexkaratarakis With f89621e59f8287b7deab5fc961252d2b133b0f33 it is building for me now, so that looks to have fixed the case-sensitivity issue.

All fixed after 5a1a75d2d6bb27675bca2f009c7ae5579e84cea7.
Thanks @ all :).

authors: Farwaykorse aalpert-bluescape alexkaratarakis ras0219-msft

repo: Microsoft/vcpkg


text:
FSC and FSI usage text and code comments inaccurate regarding debug defaults

Both FSI and FSC print the following usage info for the --debug flag:
                - CODE GENERATION -
--debug[+|-]                   Emit debug information (Short form: -g)
--debug:{full|pdbonly}         Specify debugging type: full, pdbonly. ('full' is the default and enables attaching a
                               debugger to a running program).

It says full is the default debug setting.  However this is not true, either in FSC or in FSI.
(note that -g ==  --debug+ == --debug:full)

In FSC the relevant code reads:
    // Preset: --optimize+ -g --tailcalls+ (see 4505)
    SetOptimizeSwitch tcConfigB On
    SetDebugSwitch    tcConfigB None Off
    SetTailcallSwitch tcConfigB On

The call to SetDebugSwitch is actually equivalent to --debug-, so both the usage text and the comment are incorrect.

In FSI the relevant code reads:
    // Preset: --optimize+ -g --tailcalls+ (see 4505)
    do SetOptimizeSwitch tcConfigB On
    do SetDebugSwitch    tcConfigB (Some "pdbonly") On
    do SetTailcallSwitch tcConfigB On

The call to SetDebugSwitch is actually equivalent to --debug:pdbonly, so both the usage text and the comment are incorrect

We should either

Modify the true defaults so they match the documentation/comments
Modify the documentation/comments so they match the true defaults

I believe we need to modify the documentation/comments to match the behavior.

I think I have this updated. Is it ok to have the PR created to double check the changes while the CLA is in process?

@jwood803 sure, that's fine to get it started before the CLA is done

Awesome! I'll submit it later tonight.
-----Original Message-----
From: "Lincoln Atkinson" notifications@github.com
Sent: 3/20/2015 7:48 PM
To: "Microsoft/visualfsharp" visualfsharp@noreply.github.com
Cc: "Jon Wood" woodjon@gmail.com
Subject: Re: [visualfsharp] FSC and FSI usage text and code commentsinaccurate regarding debug defaults (#311)
@jwood803 sure, that's fine to get it started before the CLA is done
—
Reply to this email directly or view it on GitHub.

To be clear, here's what I'd prefer to see.
Old usage:
--debug[+|-]                   Emit debug information (Short form: -g)
--debug:{full|pdbonly}         Specify debugging type: full, pdbonly. ('full' is the default and enables attaching a
                               debugger to a running program).

Proposed usage:
--debug[+|-|:full|:pdbonly]    Emit debug information (Short form: -g)
                               -g, --debug, --debug+, --debug:full : full debug information
                               --debug:pdbonly                     : limited debug information
                               --debug-                            : no debug information (default)

I'd certainly be open to suggestions on how else to make this more clear.

The msdn suggests that -g[+|-|:full|:pdbonly] should work as well. This just hit me here

Fixed by above PR

authors: KevinRansom dsyme jwood803 latkin matthid

repo: Microsoft/visualfsharp


text:
"Step into (F11)" doesn't seem to work in Visual Studio when debugging through F# Interactive

I was experimenting with the new F# Interactive debugging feature in Visual Studio 2015 RC and found out that "Step into" (as well as the other buttons next to it) doesn't seem to work correctly. Instead of stopping on the next line, they simply resume program execution (as if I had clicked on "Continue", instead).
This behavior is not observed when debugging a standard F# executable, which seems to work fine.

F# interactive generates optimized code by default, which leads to a fairly poor debugging experience.  You might just be seeing that.
If you check the F# Interactive options, is the top script debugging setting marked "true"?  "true" will enable debug-friendly options for F# interactive (you'll need to reset the session, though).

My current settings are:

I've tried also removing the "--optimize", as it could be changing in strange ways the generated code but it was of no avail. The previously described behavior still persists.

Then this is likely just some kind of code pattern that has poor sequence-point generation.
Can you share your code and the exact debugging steps you tried?

Sure:

Added x() definition to the FSI (ALT + ENTER), then started F# Interactive debugging session, then executed x(). The debugging session starts and stops in the breakpoint. I then:

It just resumes execution and doesn't stop on the next line.

Hmm, I don't repro with the latest builds here.

Do you have "Enable Just My Code" enabled in the debugger?

Yes, I had. I disabled it and now it works perfectly! That was it.

This is unrelated to the issue, but that GIF video is really impressive. Lincoln, may I know how you created that?

Screen2Gif - http://screentogif.codeplex.com/

Thank you! I especially like how smooth the rendering is.

authors: 21c-HK exercitusvir jorgedfbranco latkin


text:
Remove dead code for fixup sequence points

Whilst looking at a portable PDB issue I noticed that, fixupOverlappingSequencePoints  was only ever set to false.  So that allows me to remove some code, arguments, fields et.c.
Anyway here it is:

Good job

authors: KevinRansom dsyme


text:
Restarting log stream after disconnect results in multiple streams with the same name

while streaming logs, the dropdown selection becomes polluted with old Log Streams.

sometimes the log becomes disconnected, sometimes during a deploy. Start streaming does not check for existing "session?" in the dropdown under output.

Did a few tests. Normally, when you try to start the log stream and there is a log stream already active, you get an information message.
Still, if you deploy and start the stream log again you will get a second log stream in the output window.
Thanks!

I can't verify but I think a few times the log stream became disconnected without a deploy and created another log stream in the output window. I think the solution would be to always check for an existing log stream output and either remove the old one and create a new log stream output or reconnect to the old one.

Fixed in https://github.com/Microsoft/vscode-azurefunctions/pull/501

authors: EricJizbaMSFT pcnate ubikusss

repo: Microsoft/vscode-azurefunctions


text:
Add support for debugging cherrypy

[ ] Ensure debugging cherrypy works as expected
[ ] Consider adding a template for cherrypy debugging (TBD)

To help manage our issues and to better communicate what the team plans to work on we are closing issues that we don't plan to work on but would accept a pull request from a volunteer for. To be clear, closing this issue does not mean we won't consider a pull request for this enhancement as outlined in our contributing guide, just that the development team has no plans to work on it themselves.

authors: DonJayamanne brettcannon

repo: Microsoft/vscode-python


text:
Unable to open '<string>' FIle not found

Getting this error when debugging this file:
import typing
from dataclasses import dataclass, field

@dataclass
class Thing:
    a: typing.Any
    b: typing.Any
    c: typing.Any = field(init=False, repr=False)

    def __post_init__(self):
        self.c = self.a + self.b

Thing(a=1, b=2)

If I set a breakpoint at the self.c =  line and then click 'step over', I see
Unable to open '<string>': File not found (file:///Users/malmaud/Dropbox (MIT)/Desktop/fun/<string>).

I guess this is related to https://github.com/Microsoft/vscode-python/issues/3063.
VSCode 1.29.1
Python 3.6.7 with dataclasses package  installed via  pip install dataclasses
Extension 2018.10.1
Screenshot:

What's the name of the file you are debugging

/Users/malmaud/Dropbox (MIT)/Desktop/fun/debug.py

I got this error after update to the latest version. my code doesn't involve any file. When debugging the point is going nowhere when i user "Step into" and outputting this error:

Unable to open '': File not found (file:///Users/asyraf/Documents/Experimental/).

VSCode - version 1.32.3
vscode-python  - 2019.2.5558

I got this error after update to the latest version. my code doesn't involve any read or write file. When debugging the point is going nowhere when i user "Step into" and outputting this error:

 Unable to open '<string>': File not found (file:///Users/asyraf/Documents/Experimental/<string>).

VSCode: version 1.32.3
vscode-python: 2019.2.5558
OS: Mac OS 10.14.3

Downgrading to vscode-python 2019.1.0 seems to fix the error message. Update 2019.2.x until 2019.2.5558 seems to cause this error message.

Me too. Let me know if you need any log files.

I found another work around; don't install your virtual environment directly in the project folder, use a sub directory.

Fixed upstream (https://github.com/microsoft/ptvsd/issues/1071)

authors: DonJayamanne asyrafasch berkobob luabud malmaud


text:
Debugging pipenv with '-e .' package does not seem to find subpackage

$ cat settings.json
{
    "python.pythonPath": "${workspaceFolder}/.venv/bin/python",
    "python.linting.pylintEnabled": true,
    "python.terminal.activateEnvironment": false
}
$ cat launch.json
{
    "configurations": [
        {
            "name": "start my program",
            "type": "python",
            "request": "launch",
            "program": "${workspaceFolder}/myproject/mainpy",
            "console": "integratedTerminal",
            "args": [],
            "cwd": "${workspaceFolder}"
        }
    ]
}

If I start my program manually:
pipenv run myprogram

This works great. I cannot use the myprogram entrypoint (defined in my setup.py) in launch.json so I have to point to the module containing the magic if __name__ == '__main__':. Annoying but not so much.
But when I start the vscode debugger my main module is not found. All other packages from the virtualenv (managed by pipenv) is found, but not the main one, that is sourced with pipenv run pip install -e ..
The package is well declared in my virtual env:
$ pipenv run pip freeze
alabaster==0.7.12
...
gitdb2==2.0.5
-e git+https://gitserver/path/to/mymodule.git@e2c52d7c163b9c51ecfb98af6ee544325eb9a243#egg=MyModuleName
GitPython==2.1.11
...

and I can import it:
```bash
$ pipenv run python -c "import mymodule"

But when started with the debugger, I get:
Exception has occurred: ModuleNotFoundError
No module named 'mymodule.mysubmodule'; 'mymodule' is not a package

This happens within the code mymodule (which import mymodule.mysubmodule). So mymodule is in the sys.path somehow, mymodule.mysubmodule isn't.
Printing sys.path shows some difference:
=> VSCode Debugger
['/path/to/mymodule/mymodule', '/home/myuser/.vscode/extensions/ms-python.python-2019.1.0/pythonFiles', '/path/to/mymodule/.venv/lib/python36.zip', '/path/to/mymodule/.venv/lib/python3.6', '/path/to/mymodule/.venv/lib/python3.6/lib-dynload', '/usr/lib/python3.6', '/path/to/mymodule/.venv/lib/python3.6/site-packages', '/path/to/mymodule']

=> pipenv run

['/path/to/mymodule/.venv/bin', '/path/to/mymodule/.venv/lib/python36.zip', '/path/to/mymodule/.venv/lib/python3.6', '/path/to/mymodule/.venv/lib/python3.6/lib-dynload', '/usr/lib/python3.6', '/path/to/mymodule/.venv/lib/python3.6/site-packages', '/path/to/mymodule']

Thanks for letting us know about this problem, @gsemet.  From what you have described, your directory structure looks like the following:
${workspaceFolder}/
    myproject/
        mainpy  # imports "mymodule"
    mymodule/
        __init__.py  # "imports "mymodule.mysubmodule"
        mysubmodule.py
    Pipfile
    Pipfile.lock
    setup.py

If that is the case and sys.path is as described then I would expect as you did, that it would work.  So I expect I've misunderstood how your project is laid out or missed some other detail.  Would you mind providing a simple example, including directory structure, file content, and steps (for pipenv) that can reproduce the problem?

Also it isn't clear how -e . factors in here.  Do you mean you ran pipenv install --dev -e . at the project root?  From sys.path it looks like that is working fine.  Do you mean everything works if you don't pipenv install --dev -e .?

Because we have not heard back with the information we requested, we are closing this issue for now. If you are able to provide the info later on then we will be happy to re-open this issue to pick up where we left off.

authors: brettcannon ericsnowcurrently gsemet


text:
smart tips are slow in arcpy

when i write arcpy code in vscode,the smart tips are very slow.There is a verion that seems to hav been solved before.
Please solve this performance problem,Thks.

video.zip
@DonJayamanne This is the operation I recorded.

@zhangvv, thanks for letting us know about this problem.  Please ensure you are using the new language server.  See #3977 for instructions.  If you still have a problem then please re-open this issue.  Thanks!

authors: ericsnowcurrently zhangvv


text:
Feature Request: Preview changes of CodeAction before applying them

VS provides preview panel for its CodeActions showing diff of the file. Here's the sample:

I wonder if we could get something like that in Code :)

:kiss:

+1

FYI @jrieken

Tricky - in our API a code action is just any command and not necessarily a text edit, like fetch d.ts file etc. We should extend the API to return something more specific, like a WorkspaceEdit with a label. That would allow us to show a preview then

This feature request will not be considered in the next 6-12 months roadmap and as such will be closed to keep the number of issues we have to maintain actionable. Thanks for understanding and happy coding!

authors: Krzysztof-Cieslak egamma forki jrieken tamizhvendan

repo: Microsoft/vscode


text:
Report Issues doesn't work

VSCode Version: 1.8.1
OS Version: Windows 10.0.14393

Steps to Reproduce:

Press Help - Report Issues (or trigger it via F1)

Result: nothing happens. Nothing shows up in the Dev Tools console.

@Leon99 It works for me in both VS Code stable and insiders version. Can you please try again or try by disabling all extension and provide any helpful information?
Thanks

@Leon99 does it work eventually when you wait long enough? we do some integrity checking before opening a browser and that can take up to 10 seconds or more.

Doesn't work with all extensions disabled either. Search Feature Requests works and opens in a browser almost instantly. No workspace opened, I even tried to remove all the user settings with no success.

@Leon99 how about waiting longer?

@bpasero 4 hours now and counting :)

Can you try to reproduce with our nightly insider builds? You can give our preview releases a try from: http://code.visualstudio.com/Download#insiders

Works fine with 1.9.0-insider.

@Leon99 when you install all the extensions you have in stable to the insiders version, does it then fail again? I still wonder if an extension could cause this. Would also help to know which extension you have installed.

I synced using Shan.code-settings-sync, the Insiders ver was still fine after that. Here is the GIST ID I used: ece838568ac438cee805a66359b6437d


text:
Text is not saved when file is renamed

VSCode Version: Code 1.8.1 (ee428b0eead68bf0fb99ab5fdc4439be227b6281, 2016-12-19T14:42:49.304Z)
OS Version: Darwin x64 16.3.0
Extensions:

Extension
Author
Version

aurelia
AureliaEffect
0.2.0

vscode-pandoc
DougFinke
0.0.8

Aurelia
behzad88
1.2.1

path-intellisense
christian-kohler
1.2.0

tslint
eg2
0.7.1

Go
lukehoban
0.6.52

debugger-for-chrome
msjsdiag
2.4.2

todotasks
sandy081
0.4.0

code-spell-checker
streetsidesoftware
0.13.3

Steps to Reproduce:

open a new window and type in some text.
save file eg as "test" (no extension).
add some more text.
click on file in the Explorer window and change file name to eg "test.md"

Expected:

text entered in step 3 is saved OR a prompted to save changes.

what happened:

text entered in step 3 is not saved without prompt or warning.

https://github.com/Microsoft/vscode/issues/11997

authors: DrGo bpasero


text:
Visual problem when dark color themes are used

VSCode Version: 1.10.2
OS Version: macOS 10.12.3

Steps to Reproduce:

Just use dark color theme

It is possible that this issue is caused by an installed extension. Can you try to run VS Code without extensions? From the command line, execute: code --disable-extensions and try your steps again to see if it reproduces. If you see it is an issue with the extension, please file it against the extension repository itself.

https://github.com/Microsoft/vscode/issues/12473

authors: RookieZn bpasero weinand


text:
First word in a string highlighted as a keyword in Clojure

VSCode Version: Code 1.11.1 (d9484d12b38879b7f4cdd1150efeb2fd2c1fbf39, 2017-04-06T13:55:56.395Z)
OS Version: Linux x64 4.4.0-67-generic
Extensions:

Extension
Author
Version

javadebugger
donjayamanne
0.0.2

python
donjayamanne
0.6.0

cpptools
ms-vscode
0.10.5

Steps to Reproduce:

Create a .clj or .edn file
Paste this:

For some reason, "Word is treated as a keyword, therefore this and all further strings in a file are not highlighted as strings (but spaces between them are).

I guess the syntax highlighter treats all unescaped ( '() ) lists as function calls, but that's actually not the case in Clojure: inside macros or in .edn data files lists can be just that: lists.

Seems like an issue in the Clojure grammar. Opened https://github.com/atom/language-clojure/issues/63 to track the problem
Closing as upstream


text:
workbench.colorCustomizations.input.foreground/background have no effect?

VSCode Version: Code 1.12.1 (f6868fce3eeb16663840eb82123369dec6077a9b, 2017-05-04T21:26:50.689Z)
OS Version: Windows_NT ia32 6.1.7601
Extensions:

Extension
Author
Version

Theme-NaturalContrast-With-HC
74th
1.0.0

vscode-eslint
dbaeumer
1.2.8

dark-plus-plus-theme
DryWolf
0.0.9

vscode-babel-coloring
dzannotti
0.0.4

EditorConfig
EditorConfig
0.9.3

Theme-Blueprint
gerane
0.0.2

Theme-Iceberg
gerane
0.0.2

Theme-Monokai-Contrast
gerane
0.0.2

Theme-Monokai-Midnight
gerane
0.0.2

Theme-Pastel
gerane
0.0.2

Theme-PastelsonDark
gerane
0.0.2

Theme-Seafoam-Pastel-Dark
gerane
0.0.2

theme-dark-plus-contrast
k3a
0.1.101

debugger-for-chrome
msjsdiag
3.1.1

annotator
ryu1kn
0.10.1

theme-cyanicpastels
SamuelLampa
0.0.9

theme-tinacious-contrast
sugarpirate
0.0.2

theme-gneak
velok
0.2.1

join-lines
wmaurer
0.2.2

Steps to Reproduce:

Set workbench.colorCustomizations entry 'input.foreground', eg to '#FFFFFF'
Set workbench.colorCustomizations entry 'input.background', eg to '#aa0033'
The 'search files' input box background and foreground appear unchanged

An hour later, with no changes, it has started working. I guess it is NTFS at my new, restrictive workspace. Sorry to trouble you.


text:
CSS not syntax highlighted or auto-complete in SVG like it is in HTML

Not sure if this is covered by  #728 as there is no description.
In HTML the CSS highlighting and Intelisense is applied when CSS inside the style element. However, in SVG it is just treated as regular text content.

I think it would be covered by #728, currently SVG is just highlighted using the XML language mode. I'll clarify in the title. Closing.

authors: Tyriar dstorey


text:
Cannot read property 'getFullModelRange' of null

Issue Id: 24bb544a-f029-bda8-5ea0-ed088ed25c16Versions - 1.12.2Stack TypeError: Cannot read property 'getFullModelRange' of null/vs/editor/contrib/find/common/findModel.ts#L143:23 (getFullModelRange)/vs/editor/contrib/find/common/findModel.ts#L379:48 (_getSearchRange)/vs/editor/contrib/find/common/findModel.ts#L168:25 (_findMatches)/vs/editor/contrib/find/common/findModel.ts#L130:9 (research)/vs/editor/contrib/find/common/findModel.ts#L113:65 (_onStateChanged)/vs/base/common/eventEmitter.ts#L295:14 (arg1)/vs/base/common/eventEmitter.ts#L162:29 (i)/vs/base/common/eventEmitter.ts#L181:8 (_emitToSpecificTypeListeners)/vs/base/common/eventEmitter.ts#L196:8 (_emitEvents)/vs/editor/contrib/find/common/findState.ts#L216:22 (emit)

Source code has changed since then ...

authors: alexandrudima vscodeerrors


text:
ShellTask executed in wrong working directory when the Terminal is reused

I've added multi root support for the npm script runner. I now pass the cwd of the package.json containing the script to the ShellTask as an option. This works fine in the single root case and the reuse of the terminal works.
In the multi root case a different cwd can be passed for npm scripts that are located in different root folders. In this setup a script can be executed inside the wrong working directory.
As a workaround I killed the Terminal in between task runs and the issue doesn't show up.

I can reproduce this even in a config file setup. I debugged and everzthing is passed correctly to the terminal reuseTerminal call but for some reason the terminal uses the cwd of its initial first launch. Here are steps to reproduce (tested under Windows):

Workspace, now multi root with a folder client and server and different files in it.
tasks.json

{
	// See https://go.microsoft.com/fwlink/?LinkId=733558
	// for the documentation about the tasks.json format
	"version": "2.0.0",
	"tasks": [
		{
			"type": "shell",
			"taskName": "build",
			"command": "dir",
			"problemMatcher": [],
			"options": {
				"cwd": "${workspaceRoot}\\client"
			}
		}
	]
}

run the task
Observe: the content of the client folder is listed
change the options literal to

			"options": {
				"cwd": "${workspaceRoot}\\server"
			}

run the task
Observe: the content of the client folder is listed. It should list the content of the server folder.

I debugged it and TerminalInstance._createProcess receives a shell configuration with the correct cwd set. So it seems to be a problem how a process is launched if the terminal is reused.

authors: dbaeumer egamma


text:
Reveal debug configuration when pressing edit

testing #31396
Unsure if I have filed this already before

open the vscode workspace which has ~15 launch configs
select one to launch, notice you want to reconfigure it
press the gear icon
you are lost, the file is large, and the part which defines the currently selected configuration isn't revealed (but the last I have edited)

An alternative (or addition) would be to have a special outline provider for that file. Today it's not very helpful and I'd prefer seeing the names of the launch configs in there...

I would love to have this feature (since my launch.jsons have 30++ entries)

I think this can be quite useful for large launch.json -> august

Now when pressing edit I reveal the select configuration.
I have also added a special outline provider for the launch.json. However I am having issues that my results are being merged in with the default results which make the feature useless.
@jrieken looking at the docs here it seems that is expected behavior. Is there some workaround for this to make this feature useful.
You can find my provider here

@isidorn Since the results are merged, is it possible to show your results on the top?

Nah, they are all sorted by range (start_pos) and that's show it currently works... Little we can do

authors: isidorn jrieken sandy081 weinand


text:
TSLint is not linting

VSCode Version: 1.15.1
OS Version: Mac OS Sierra 10.12.6

Steps to Reproduce:

Check out the code on SO

I have a completely valid tslint.json and tsconfig.json. When I run my lint script, "lint": "tslint ./src/**/*.ts --exclude \"./**/node_modules/**/*.ts\"", I do get output from my Terminal. But VS Code doesn't highlight or underline any issues. It does not work with or without the extension. I've force-quit several times. I've restarted my computer. I grabbed someone else's tsconfig and tslint from a public repo, with no luck. I even cloned a reputable repo and still get no linting. (apollographql/apollo-server). So, not really knowing what to do, here I am, hopeful to get some help. Thanks!

Reproduces without extensions: Yes

This issue was moved to Microsoft/vscode-tslint#248

authors: egamma iamclaytonray


text:
Command-E on Mac behaves differently from other applications

In most Mac applications, pressing Command-E fills the find buffer with the currently selected text. However, in Visual Studio Code, it appears to invoke the Quick Open menu.

We chose to use ⌘E for VS Code for one of the most powerful actions in the editor itself. With it you can quickly navigate to any file as well as navigate back in history. I must say it's my most used shortcut in all of Code. Give it a spin!
In any case, you can always overwrite this in your keybindings file:
{ "key": "cmd+e", "command": "editor.action.nextSelectionMatchFindAction", "when": "editorFocus" }

Command-E isn't even documented on the Visual Studio code site, and it's a duplicate of Command-P.
Why does an undocumented, duplicate shortcut need to take precedence over standard system behavior?

Good point about being a duplicate: I argue that its a way to trigger it using only the left hand.
Good point about the lack of documentation. Ping @chrisdias @seanmcbreen @waderyan, when are we going to talk about ⌘E as the greatest keybinding ever?

@gregvanl

I too found this super confusing. Command-E is core to text editing on the Mac I feel.
Maybe this should be added as documentation? I think on the Mac, quite a lot of people would want to make the above keybindings change.

I vote for not overriding a default system-wide shortcut people are used to on other systems ⌘E on mac for putting text in copy buffer.

Not sure if this is still open or not, ideally there is a command to support the mac cmd-e, cmd-g behavior.
@joaomoreno, where is the best place to file this feature request? Thanks!

cc @bpasero

I never use Cmd+E so do not ping me or I will remove it if I read more about this issue :)

@alexandrudima I am fine adding this (pressing Cmd+E moves the selected text into the find widget). Do we already have a place where I can add it and maybe have this action already, just bound to a different keybinding?

@bpasero The action exists and is called "actions.find"

@alexandrudima, @bpasero  thanks for actions.find!
From using Atom and VSCode there seems to be a difference in how each operating system handles the concept of a "find pasteboard".
MacOS supports several system-level named pasteboards:
https://developer.apple.com/library/mac/documentation/Cocoa/Conceptual/PasteboardGuide106/Articles/pbConcepts.html
NSFindPboard is the one that cmd-e/cmd-g use. I can use cmd-e to copy text in Chrome, TextEdit, Sublime, TextMate and then switch to another app and use cmd-g to search for that text.
Based on actions.find in VSCode, each open buffer seems to have it's own (non-shared) find pasteboard. So actions.find works fine in a single buffer, but I can't cmd-e some text in one file, then cmd-g it in my next file...
Full support of the system NSFindPboard would be ideal, but allowing actions.find (or similar) to allow for easy searching in other open buffers would handy as well.
For reference, this has also come up in the Atom issue trackers (https://github.com/atom/atom/issues/4650).
I'm really liking the level of polish in VSCode, and it's made me far more efficient in writing NodeJS code full time :) Anything that can be done to enable this workflow would be most welcome.
Thanks again!

@xmas your request should go into a new issue idealy.

@bpasero was a new ticket opened?  I'd say this is a usability defect when working on macOS.
Seems we may need to add a new API to electron.

No ticket opened so far.

@joaomoreno editor.action.nextSelectionMatchFindAction as you describe above does not enable the behavior that cmd-e has in pretty much every Mac application (not just editors) .
cmd-e is usually called "Use Selection for Find". It does exactly that. The current selection does not change. But when you hit cmd-g it will use selection to search. Is there any way to get this behavior in TS Code?

Using "actions.find" only works as a substitute if you leave the setting "editor.find.seedSearchStringFromSelection" set to true. And in that case, it's just a duplicate mapping of ⌘F.
I have "editor.find.seedSearchStringFromSelection" set to false. When I press ⌘F, sometimes I want to search again for the text that's already in the search buffer. The default behavior is that if you have multiple characters selected when you press ⌘F then you begin searching for whatever you had selected.
So now my only way to select some text and search for it is:

⌘C (copy selected text)
⌘F (open search... at this point the search buffer might have old search text in it)
⌘V (paste in new search text)

As others have stated, the desired behavior would be that selecting text and searching can be accomplished with:

⌘E (put selected text in search buffer)
⌘F (open search)

authors: BurntCaramel alexandrudima bpasero david-mitchell egamma joaomoreno miller-time rgigger wprater xmas


text:
Improve keybinding documentation

VSCode Version: Version 1.19.0-insider (1.19.0-insider)
OS Version: macOS 10.13

First let me say that the VSCode team is doing a fabulous job on the whole, andI moved to VSCode from Sublime Text specifically because the documentation on task configuration was superior.
However, I still find myself wasting a lot of time hunting around for the right configuration key for nearly every customization effort I make. The documentation is great for intro articles, but quite weak as reference material.
For example, take this article section: https://code.visualstudio.com/docs/getstarted/keybindings#_advanced-customization

The list above isn't exhaustive and you may see some when contexts for specific VS Code UI in the Default Keyboard Shortcuts.

What this means in practice is that if I want to use a "when context" I have to pour over 1000+ lines of Json. I just spent the better part of an hour discovering inDebugRepl. In fact I resorted to writing a script to extract all of the defaults and contexts and format them out as a quick reference. This was not very hard, and I think it would be well worth it if VSCode started publishing generated reference material like this. Then the article could just link to a complete list that was up to date. I suspect there are other areas that would also benefit greatly from more autogenerated docs as well.
Thanks for taking the time to consider this!

This issue was moved to Microsoft/vscode-docs#1288

There is also https://github.com/Microsoft/vscode/issues/9303 to provide when clause context IntelliSense in keybindings.json.

authors: gregvanl gwk


text:
Provide proper display name, description and icon for out of the box extensions

With #17068, Built-in extensions will be shown in the extension viewlet. This needs adopting all extensions to provide proper name, description, read me and an icon (if no icon is provided it, defaults to VS Code icon) so that user will know about what each extension is for.
I am assigning users based on the last change done to the extension. If you are not the owner, please assign it to actual owner, otherwise me. Also please check it off, if the current details are good enough
NOTE: Make sure display name and descriptions are translated using nls

[x] bat @aeschli
[x] clojure @aeschli
[x] coffeescript @aeschli
[x] configuration-editing @sandy081
[x] cpp - @sandy081
[x] csharp @aeschli
[x] css @aeschli
[x] diff @aeschli
[x] docker @aeschli
[ ] emmet @ramya-rao-a
[x] extension-editing @sandy081
[x] fsharp @aeschli
[x] git @joaomoreno
[x] gitsyntax @joaomoreno
[ ] go @ramya-rao-a
[x] groovy @aeschli
[ ] grunt @dbaeumer
[ ] gulp @dbaeumer
[x] handlebars @aeschli
[x] hlsl @aeschli
[x] html @aeschli
[x] ini @aeschli
[ ] jake @dbaeumer
[x] java @aeschli
[ ] javascript @mjbvz
[x] json @aeschli
[x] less @aeschli
[x] log @sandy081
[x] lua @aeschli
[x] make @aeschli
[ ] markdown @mjbvz
[ ] merge-conflict @chrmarti
[x] npm @egamma
[x] objective-c @aeschli
[x] perl @aeschli
[ ] php @roblourens
[x] powershell @aeschli
[x] python @aeschli
[x] r @aeschli
[x] razor @aeschli
[x] ruby @aeschli
[x] rust @aeschli
[x] scss @aeschli
[x] shaderlab @aeschli
[x] shellscript @aeschli
[x] sql @aeschli
[x] swift @aeschli
[x] theme-abyss @sandy081
[x] theme-defaults @sandy081
[x] theme-kimbie-dark @sandy081
[x] theme-monokai-dimmer @sandy081
[x] theme-monokai @sandy081
[x] theme-quietlight @sandy081
[x] theme-red @sandy081
[x] theme-seti @sandy081
[x] theme-solarized-dark @sandy081
[x] theme-solarized-light @sandy081
[x] theme-tomorrow-night-blue @sandy081
[ ] typescript @mjbvz
[x] vb @aeschli
[x] yaml @aeschli

Also please make sure that Read me is updated.

@sandy081 Do we have a common template for the readme? Or maybe have it generated from the description?
IMO it would be good to mention that the extension is a built-in extension, cannot be uninstalled but disabled.

Now that @joaomoreno has started it with the git extension I suggest that we add icons for the bundled extensions as well.

Any guidelines on where should (or shoudlnt) we get the icons from?

Read me will be auto generated from extension manifest details if not provided

@aeschli, @ramya-rao-a, @joaomoreno, @dbaeumer, @mjbvz, @chrmarti, @egamma, @roblourens
Looks like most of the extensions versions are at 0.1. Can you please check your extensions versions and bump them at least to 1.0

Done!

Done!

Done for Emmet. The only remaining thing for Emmet is the icon for which I have contacted the Emmet library owner. Should be able to get something in a day or 2

@sandy081 I've updated all extensions such that

the least version is 1.0.0
the Display Name for language related extensions are appropriately Basics/Features
removed "and other language features" from the description for all Language Basics extensions. That will just mislead users to expect more from the extension

The only thing left is to get icons for

Emmet
Typescript
Html
Css
Json
Markdown
Php

which is tracked in #44626.
We can close this issue

Thanks @ramya-rao-a
Closing this

authors: aeschli egamma joaomoreno ramya-rao-a sandy081


text:
Support mac/linux/windows subkeys in keybindings.json the same as extensions.contributes.keybindings...

Issue Type: Feature Request
For users running on multiple machines/platforms, it is common to sync the vs settings.  Without support for the default 'key' and override-platform-specific 'windows/mac/linux' subkeys, there's no good way to share keybindings.json.
Keeping multiple copies is a pain to keep in sync; and with the commonality of 'cmd' on Mac in particular, it's hard to have a true common config that works across platforms.
I may be underestimating the work, but it looks like the most tedious/difficult part would be extending the localization of the schema in keybindingservice.ts. :)
There does not seem to be a write model that would need to preserve the original values.
(writeKeybindingItem looked like it might be it, but it's generating very specific formatting for the Default Keybindings window.  I guess it could be used by something more general and OS specific bindings would be lost?)
VS Code version: Code 1.21.0 (9a199d77c82fcb82f39c68bb33c614af01c111ba, 2018-03-07T10:54:22.798Z)
OS version: Darwin x64 16.7.0

The attached PR https://github.com/Microsoft/vscode/pull/45995 has an implementation; and tests.  I've attempted to make sure there are no downstream effects; but not being fluent in non-extension code, I won't claim it's ship ready.

Duplicate of https://github.com/Microsoft/vscode/issues/8962

authors: bpasero joerohde


text:
Completion items for settings.json always include true and false for boolean type regardless of enum

This issue was discovered in https://github.com/rubyide/vscode-ruby/issues/295.
Add a configuration contribution to an extension's package.json that accepts both boolean and string types, but give it an enum that doesn't include one of the boolean options:
"ruby.codeCompletion": {
  "type": ["boolean", "string"],
  "enum": [false, "rcodetools"],
  "default": false,
  "description": "Method to use for code completion. Use `false` if another extension provides this feature."
}

When editing the configuration in User Settings, the completion items include true despite the enum:

@aeschli I think it is related to JSON


text:
Omnisharp unable to load project

VSCode Version: 1.21.1 79b44aa704ce542d8ca4a3cc44cfca566e7720f1 x64
OS Version: Windows 10

Steps to Reproduce:

Open up C# project
Error message appears on bottom of screen
Open output window
See this error message

Does this issue occur when all extensions are disabled?: Yes/No
No. Enabling the C# extension does cause an error though.

via GIPHY

I can not read the message in the screen cast. It is simply to little.
Since this is related to a C# project I am pretty sure that the error is related to the C# extension. Can you please report the error there (https://github.com/OmniSharp/omnisharp-vscode) or provide a screen cast that is more readable.

@dbaeumer Sorry, I was so excited about including the GIF I forgot to paste the error message :/
This is the failing message I receive:
[fail]: OmniSharp.MSBuild.ProjectLoader         The "Microsoft.CodeAnalysis.BuildTasks.Csc" task could not be loaded from the assembly C:\Program Files (x86)\Microsoft Visual Studio\2017\Professional\MSBuild\15.0\Bin\Roslyn\Microsoft.Build.Tasks.CodeAnalysis.dll. Could not load file or assembly 'file:///C:\Program Files (x86)\Microsoft Visual Studio\2017\Professional\MSBuild\15.0\Bin\Roslyn\Microsoft.Build.Tasks.CodeAnalysis.dll' or one of its dependencies. The system cannot find the file specified. Confirm that the <UsingTask> declaration is correct, that the assembly and all its dependencies are available, and that the task contains a public class that implements Microsoft.Build.Framework.ITask.

@jtleaming this comes from the C# extension. Please report the issue here: https://github.com/OmniSharp/omnisharp-vscode

authors: dbaeumer jtleaming


text:
Error while formatting range for file HTML

Here's a regression in some latest nightlies, it happens when formatting code. Formatting fails:
[Error - 1:18:06 PM] Error while formatting range for file:///<path edited out by issuer for security>.html: Ovelapping edit
Error: Ovelapping edit
    at Object.applyEdits (<vscn path edited out for security> /VSCode-linux-x64/resources/app/extensions/html-language-features/server/node_modules/vscode-languageserver-types/lib/umd/main.js:803:27)
    at Object.format (<vscn path edited out for security> /VSCode-linux-x64/resources/app/extensions/html-language-features/server/out/modes/formatting.js:75:72)
    at Object.<anonymous> (<vscn path edited out for security> /VSCode-linux-x64/resources/app/extensions/html-language-features/server/out/htmlServerMain.js:415:64)
    at step (<vscn path edited out for security> /VSCode-linux-x64/resources/app/extensions/html-language-features/server/out/htmlServerMain.js:36:23)
    at Object.next (<vscn path edited out for security> /VSCode-linux-x64/resources/app/extensions/html-language-features/server/out/htmlServerMain.js:17:53)
    at fulfilled (<vscn path edited out for security> /VSCode-linux-x64/resources/app/extensions/html-language-features/server/out/htmlServerMain.js:8:58)
    at <anonymous>
[Error - 1:18:06 PM] Error while formatting range for file:///<path edited out by issuer for security>.html: Ovelapping edit
Error: Ovelapping edit
    at Object.applyEdits (<vscn path edited out for security> /VSCode-linux-x64/resources/app/extensions/html-language-features/server/node_modules/vscode-languageserver-types/lib/umd/main.js:803:27)
    at Object.format (<vscn path edited out for security> /VSCode-linux-x64/resources/app/extensions/html-language-features/server/out/modes/formatting.js:75:72)
    at Object.<anonymous> (<vscn path edited out for security> /VSCode-linux-x64/resources/app/extensions/html-language-features/server/out/htmlServerMain.js:415:64)
    at step (<vscn path edited out for security> /VSCode-linux-x64/resources/app/extensions/html-language-features/server/out/htmlServerMain.js:36:23)
    at Object.next (<vscn path edited out for security> /VSCode-linux-x64/resources/app/extensions/html-language-features/server/out/htmlServerMain.js:17:53)
    at fulfilled (<vscn path edited out for security> /VSCode-linux-x64/resources/app/extensions/html-language-features/server/out/htmlServerMain.js:8:58)
    at <anonymous>

VSCode Version:
code-insider-1.23.0-1523596516_amd64.tar.gz
code-insider-1.23.0-1523942099_amd64.tar.gz

Platform
Ubuntu 14.04 but I bet it's irrelevant.

-R

Hi @ramya-rao-a and thanks for your caring:

Does this occur when you run code with extensions disabled as well? Run code --disable-extensions to try it out.

Yes

Can you provide sample code where you see this along with edits made to the file after which this occurs?

No. But the same page formatted properly on some nightly older than a week ago (no change)

Does this occur in the stable version as well?

stable is OK.

Does this occur when you run formatting manually or you are using the format on save / format on type features?

Both.
I hope of having been helpful. I will investigate further as soon as I have more time.
--R

Having a sample code where we can see the issue will help a lot.

I'll set up an example project as soon as I have time.
Thanks for caring.
--R

<html>
<head>
</head>

<body>

    <script>
        function f(x) {}
        f(function () {
        //

        console.log(" vsc crashes on formatting")
        });
    </script>

        </body>

</html>

@ramya-rao-a here it is!
(I tried to restrict the issue a bit)
It's rather weird.
Fails formatting on the following nightlies:
code-insider-1.23.0-1523510016_amd64.tar.gz
code-insider-1.23.0-1523510016_amd64.tar.gz
code-insider-1.23.0-1523596516_amd64.tar.gz
code-insider-1.23.0-1523942099_amd64.tar.gz
code-insider-1.23.0-1524028477_amd64.tar.gz
code-insider-1.23.0-1524201267_amd64.tar.gz
code-insider-1.23.0-1524633233_amd64.tar.gz

Thanks @RobertoMalatesta
I can repro this both in stable and Insiders

@RobertoMalatesta @ramya-rao-a Thanks a lot for taking your time. Strangely I'm not able to reproduce. I even created a test case for it.
I also tried with code-insider-1.23.0-1524633233_amd64.tar.gz (on Ubuntu 16.04)
Do you have any settings html or indentation settings enabled?

@aeschli I dont have any such settings and can repro this even with all extensions disabled.
I was able to find the root cause in the compare function passed to mergeSort when applying the edits.
See https://github.com/Microsoft/vscode-languageserver-node/blob/4c66383e92a2f7d513f93e5ecc74b21b4889d3a5/types/src/main.ts#L1602
We should be returning diff there not 0

Do you have any html, javascript or indentation settings defined?
No. A clean one with no extensions.

@ramya-rao-a Good catch, thanks!

it will take a while until we get the fix in VSCode...

Thanks @ramya-rao-a and @aeschli .
Unbeatable support.
Now I'll try to break some other thing... :P

Fix is now in VSCode insiders

:ok:

authors: RobertoMalatesta aeschli ramya-rao-a


text:
TextEditorRevealType.AtTop does not always reveal at top

If the requested range is below the current position in the editor, this will be revealed at the bottom, even if AtTop is requested.
When requesting AtTop, I expect it to be revealed at the top no matter what as far as possible.

@h0rdak I cannot reproduce. Here is what I am trying:

package.json:

{
  "name": "50457",
  "publisher": "alex",
  "version": "0.0.0",
  "engines": { "vscode": "^1.22.0" },
  "activationEvents": [ "*" ],
  "main": "index.js"
}

index.js:

const vscode = require('vscode');

exports.activate = function() {
    const ed = vscode.window.activeTextEditor;
    ed.revealRange(new vscode.Range(9, 0, 9, 0), vscode.TextEditorRevealType.AtTop);
}

test.txt:

This is line number 1
This is line number 2
This is line number 3
This is line number 4
This is line number 5
This is line number 6
This is line number 7
This is line number 8
This is line number 9
This is line number 10
This is line number 11
This is line number 12
This is line number 13
This is line number 14
This is line number 15
This is line number 16
This is line number 17
This is line number 18
This is line number 19
This is line number 20
This is line number 21
This is line number 22
This is line number 23
This is line number 24
This is line number 25
This is line number 26
This is line number 27
This is line number 28
This is line number 29

I then position the editor to show line number 29 and proceed to reload the window. Line number 10 is correctly shown at the top of the editor:


text:
Apply an account to join vscode-dev-community.slack.com

Could you let me know how to apply an account to access vscode-dev-community.slack.com? I couldn't find anywhere mentioned the process so I create an issue here.

Hi,
You can join the community run Slack channel by using this link, https://vscode-dev-community.slack.com/join/shared_invite/enQtMjIxOTgxNDE3NzM0LWU5M2ZiZDU1YjBlMzdlZjA2YjBjYzRhYTM5NTgzMTAxMjdiNWU0ZmQzYWI3MWU5N2Q1YjBiYmQ4MzY0NDE1MzY
/k

New link for the Slack community, https://aka.ms/vscode-dev-community


text:
Windows 10 1px black border at bottom

Issue Type: Bug
Steps to Reproduce:

Open Code
Expand Code window to full-screen.
Look at 1px border at bottom of window, when it is hovered cursor become s-resize, but window is not resizing by dragging it.

This bug occurs only in full-screen-expanded window...

Screenshot 1(window is expanded):

Screenshot 2(window is attached to right):

Does this issue occur when all extensions are disabled?: Yes
VS Code version: Code 1.28.2 (7f3ce96ff4729c91352ae6def877e59c561f4850, 2018-10-17T00:23:51.859Z)
OS version: Windows_NT x64 10.0.17134

System Info

Item
Value

CPUs
AMD Phenom(tm) II X4 955 Processor (4 x 3215)

GPU Status
2d_canvas: enabledchecker_imaging: disabled_offflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onnative_gpu_memory_buffers: disabled_softwarerasterization: unavailable_softwarevideo_decode: enabledvideo_encode: enabledwebgl: enabledwebgl2: enabled

Memory (System)
8.00GB (1.60GB free)

Process Argv

Screen Reader
no

VM
0%

Extensions: none

Step 2 should be maximize the window, not switch to full-screen.

duplicate of https://github.com/Microsoft/vscode/issues/58427


text:
Re-toggle panel upon debug/code run exit

Dear developers, contributors, users
I like to work on vertical screen with hidden output panel.
Once I run/debug code it pops up automatically.
When the run/debug process is finished, it stays shown, and I have to hide it (CTRL + J) each time.
It would be nice to have some configurable option, that would check my appearance preferences, and re-apply them, upon such process' completion.
Kind regards,
Piotr Rarus

Please use this debug.internalConsoleOptions
More than that is currently out of scope and not on our plan

authors: isidorn piotr-rarus


text:
Issue with Terminal placement

Issue Type: Bug
Hello Team,
Command prompt which is like C:> is not placed correctly. Please find the attachment for your reference. I have clean installed the latest version of VS code.
It is getting some empty space above that prompt.

VS Code version: Code 1.30.1 (dea8705087adb1b5e5ae1d9123278e178656186a, 2018-12-18T18:12:07.165Z)
OS version: Windows_NT x64 10.0.17763

System Info

Item
Value

CPUs
Intel(R) Core(TM) i5-3210M CPU @ 2.50GHz (4 x 2494)

GPU Status
2d_canvas: enabledchecker_imaging: disabled_offflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onnative_gpu_memory_buffers: disabled_softwarerasterization: unavailable_softwarevideo_decode: enabledvideo_encode: enabledwebgl: enabledwebgl2: unavailable_off

Memory (System)
7.88GB (3.09GB free)

Process Argv

Screen Reader
no

VM
0%

Extensions: none

What does your terminal look like if you just open cmd?

Me too, I thought it was a problem with PowerShell.

What does your terminal look like if you just open cmd outside of VSCode?

It looks normal outside of VSCode.

Me too, I thought it was a problem with PowerShell.

Don't know...for both Powershell and Command prompt terminal in VS Code, I noticed the same thing.

It still has a space, I have obsessive-compulsive disorder, it’s too bad.

https://github.com/Microsoft/vscode/issues/57803

authors: Abhinav3718 Tyriar arrebole saites


text:
Show message that 'Insiders' build is updated more frequently

If the Insiders release becomes the new alpha, we'll have to communicate to existing users that they can expect more frequent updates when continuing with the Insiders.
For this a message "The Insider release will be updated more frequently..." should be shown once when starting the new version for the first time.
The message should include a link to the corresponding blog-post.
@chrisdias @seanmcbreen please provide the wording for the message.
/cc @bpasero

FWLink to the blog post: http://go.microsoft.com/fwlink/?LinkID=798816
"Insider builds to become daily builds! For more information, please see our blog."

@chrisdias They will be at least daily. Many days they will be built multiple times. Maybe a different phrase that indicates this?

@joaomoreno Not sure how to phrase this... I can make the blog post to be more clear about this, and that is a more durable document.

authors: chrisdias joaomoreno weinand


text:
OSX - Rightclick on dock icon no longer shows workspaces

Issue Type: Bug
I work with 2 workspaces. When VSCode opens, it only opens the last active one. Until very recently, a quick shortcut was to right-click the dock icon and select the other workspace.
But workspaces no longer show up there?
To Reproduce

Be on OSX
Have 2 recent workspaces
Open VSCode - last workspace opens.
Right-click on Dock

Expected: Workspace can be selected and opens in new window.
Currently: Workspaces are not shown.

VS Code version: Code 1.31.0 (7c66f58312b48ed8ca4e387ebd9ffe9605332caa, 2019-02-05T22:32:14.164Z)
OS version: Darwin x64 17.7.0

No, that is not the same issue.

Duplicate of #57272

authors: Nimja bpasero


text:
Links with vscode: URI scheme are inert in Markdown preview window

Issue Type: Bug
Clicking a link in the Markdown preview with the vscode:extension/... URI scheme + path doesn't launch the extension page. vscode does not display an error
Might be related to #69998, and #71622. Discovered while fixing #71414.
Steps to reproduce
Create a Markdown file that contains a link with the vscode: URI scheme:
[Link to Python extension for vscode](vscode:extension/ms-python.python)

Click link in preview window. Nothing happens.
Expected behavior is to launch the extension page for extension/ms-python.python.
VS Code version: Code 1.34.0 (df4988d54438247ebd8046f573e38e62176531db)
OS version: Darwin x64 18.0.0

System Info

Item
Value

CPUs
Intel(R) Core(TM) i5-5257U CPU @ 2.70GHz (4 x 2700)

GPU Status
2d_canvas: enabledchecker_imaging: disabled_offflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onnative_gpu_memory_buffers: enabledrasterization: enabledsurface_synchronization: enabled_onvideo_decode: enabledwebgl: enabledwebgl2: enabled

Load (avg)
3, 3, 4

Memory (System)
8.00GB (0.02GB free)

Process Argv

Screen Reader
no

VM
0%

Extensions (34)

Extension
Author (truncated)
Version

rtf
ale
2.0.1

solargraph
cas
0.19.3

vscode-modelines
chr
2.0.2

npm-intellisense
chr
1.3.0

vscode-npm-script
eg2
0.3.5

vscode-diff
fab
1.4.0

vscode-git-history
fab
2.0.5

beautify
Hoo
1.4.11

vscode-duplicate
mrm
1.2.1

python
ms-
2019.3.6139

cpptools
ms-
0.22.1

csharp
ms-
1.18.0

mono-debug
ms-
0.15.8

incrementor
nms
0.1.0

printcode
nob
3.0.0

openhab
ope
0.4.1

vscode-docker
Pet
0.6.1

platformio-ide
pla
1.6.0

diff
raf
0.0.1

ruby
reb
0.22.3

java
red
0.41.0

LiveServer
rit
5.5.1

partial-diff
ryu
1.4.0

code-settings-sync
Sha
3.2.7

code-spell-checker
str
1.6.10

unity-debug
Uni
2.7.2

vscodeintellicode
Vis
1.1.5

vscode-arduino
vsc
0.2.25

vscode-java-debug
vsc
0.17.0

vscode-java-dependency
vsc
0.4.0

vscode-java-pack
vsc
0.6.0

vscode-java-test
vsc
0.15.1

vscode-maven
vsc
0.15.2

markdown-all-in-one
yzh
2.2.0

(1 theme extensions excluded)

@mjbvz In the latest Insiders, the link seems to be rewritten to:

I pushed a fix for that. Here's what I see on 0ab39f4148f242e7b0802330385fc99b4845aa31

Yup that fixes it. Pushing another related fix.

On insiders, you need to use the vscode-inssiders scheme instead:
[Link to Python extension for vscode](vscode-insiders:extension/ms-python.python)

I just tested this again and those links seem to work in the preview and in the editor
We discuss this limitation #71622 but for now you need to use the scheme specific to the product being used

authors: joaomoreno mjbvz phaseOne


text:
Improve snap metadata

Issues:

No mention of "vscode" and their search does exact text matching so that won't show the app
Use of markdown ** looks bad

The website does show Markdown: https://snapcraft.io/code
The editing page even says it is supported:

I guess they didn't implement that on the Software Center. I'll remove it.

authors: Tyriar joaomoreno


text:
branch: toggleWordWrap_1a

desc:  Add word wrap toggle function.
hotkey: Alt-Z

Hi @ivanixgames, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.microsoft.com.

TTYL, MSBOT;

@ivanixgames, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.
Thanks, MSBOT;

authors: ivanixgames msftclas


text:
A video on how to use the tool

I created a video on how to use the tool so anyone can get quickly overview of it, I thought to make a pull request to add it to the readme then I thought it's better to leave that to you if you think it could help.
Thanks!
https://www.youtube.com/watch?v=aHbiLYUfomc&feature=youtu.be

Thanks for help, @DevOpsFounder

No problem @Paulohcsantos

Fixed with #59

authors: DevOpsFounder Paulohcsantos sferg-msft

repo: Microsoft/vsts-work-item-migrator


text:
ByteArrayToImageSourceConverter

Documentation added for .NET MAUI Community Toolkit proposals:

[Proposal] ByteArrayToImageSourceConverter  https://github.com/CommunityToolkit/Maui/issues/51 includes:

Docs Build status updates of commit 00edaa2:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/maui/TOC.yml
:white_check_mark:Succeeded
View

docs/maui/converters/byte-array-to-image-source-converter.md
:white_check_mark:Succeeded
View

docs/maui/converters/index.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

PRMerger Results

Issue
Description

Added File(s)
This PR contains added files. New files require human review.

Yaml File(s)
This PR includes changes to .yml file(s) owned by another author.

File Change Percent
This PR contains file(s) with more than 20% file change.

Index File
This PR contains a change to the index file.

Docs Build status updates of commit b538a03:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/maui/TOC.yml
:white_check_mark:Succeeded
View

docs/maui/converters/byte-array-to-image-source-converter.md
:white_check_mark:Succeeded
View

docs/maui/converters/index.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

PRMerger Results

Issue
Description

Added File(s)
This PR contains added files. New files require human review.

Yaml File(s)
This PR includes changes to .yml file(s) owned by another author.

File Change Percent
This PR contains file(s) with more than 20% file change.

Index File
This PR contains a change to the index file.

Docs Build status updates of commit c578945:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/maui/TOC.yml
:white_check_mark:Succeeded
View

docs/maui/converters/byte-array-to-image-source-converter.md
:white_check_mark:Succeeded
View

docs/maui/converters/index.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

PRMerger Results

Issue
Description

Added File(s)
This PR contains added files. New files require human review.

Yaml File(s)
This PR includes changes to .yml file(s) owned by another author.

File Change Percent
This PR contains file(s) with more than 20% file change.

Index File
This PR contains a change to the index file.

Docs Build status updates of commit 29e20d9:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/maui/TOC.yml
:white_check_mark:Succeeded
View

docs/maui/converters/byte-array-to-image-source-converter.md
:white_check_mark:Succeeded
View

docs/maui/converters/index.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

PRMerger Results

Issue
Description

Added File(s)
This PR contains added files. New files require human review.

Yaml File(s)
This PR includes changes to .yml file(s) owned by another author.

File Change Percent
This PR contains file(s) with more than 20% file change.

Index File
This PR contains a change to the index file.

Docs Build status updates of commit 6590853:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/maui/TOC.yml
:white_check_mark:Succeeded
View

docs/maui/converters/byte-array-to-image-source-converter.md
:white_check_mark:Succeeded
View

docs/maui/converters/index.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

PRMerger Results

Issue
Description

Added File(s)
This PR contains added files. New files require human review.

Yaml File(s)
This PR includes changes to .yml file(s) owned by another author.

File Change Percent
This PR contains file(s) with more than 20% file change.

Index File
This PR contains a change to the index file.

Docs Build status updates of commit 9ebf896:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/maui/TOC.yml
:white_check_mark:Succeeded
View

docs/maui/converters/byte-array-to-image-source-converter.md
:white_check_mark:Succeeded
View

docs/maui/converters/index.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

PRMerger Results

Issue
Description

Added File(s)
This PR contains added files. New files require human review.

Yaml File(s)
This PR includes changes to .yml file(s) owned by another author.

File Change Percent
This PR contains file(s) with more than 20% file change.

Index File
This PR contains a change to the index file.

Docs Build status updates of commit 069862e:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/maui/TOC.yml
:white_check_mark:Succeeded
View

docs/maui/converters/byte-array-to-image-source-converter.md
:white_check_mark:Succeeded
View

docs/maui/converters/index.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

PRMerger Results

Issue
Description

Added File(s)
This PR contains added files. New files require human review.

Yaml File(s)
This PR includes changes to .yml file(s) owned by another author.

File Change Percent
This PR contains file(s) with more than 20% file change.

Index File
This PR contains a change to the index file.

repo: MicrosoftDocs/CommunityToolkit


text:
Update how-to-write-quick-edits.md

Made a couple of Microsoft Writing Style Guide revisions.
Contributor guide pull request
Thanks for contributing to the Microsoft Learn contributor guide. Please read these instructions for processing your pull request (PR). Once you've read this text, delete it and write a brief description of the changes you're proposing.
Quality control

[ ] 1. Successful build with no warnings or errors: Review the build status to make sure all checks are green (Succeeded).

[ ] 2. #Sign-off: Once the PR is finalized and ready to be merged, indicate so by typing #sign-off in a new comment in the PR. Signing off means the document is ready for review and can be published at any time.

Merge and publish

All PRs to this repository are manually reviewed and merged.
Once all feedback on the PR is addressed, we'll merge the PR into the main branch.

Need help?
If you have an open PR, tag the PR reviewers in a comment with your question: @carlyrevier, @jehchow

@ragged993 - Great suggestions. Thanks for helping improve our content!

repo: MicrosoftDocs/Contribute


text:
Update validate-the-my-site-host-and-individual-my-sites-are-on-a-ded…

…icated-web-applica.md
Add !important to note the removal of the rule.

@bentoncity Hi Steve, changes look correct. Could you please check and merge? Thanks!

authors: scanum tseward

repo: MicrosoftDocs/OfficeDocs-SharePoint


text:
Incorrect Documentation

There is a note "To save time or automate this, you can use the Set-CsOnlineDialInConferencingBridge cmdlet", but this command doesn't appear to have the option to change this setting. Perhaps you should include an example.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 02fca567-f57d-89b9-e342-354df84f0a5f
Version Independent ID: 3f12a800-3722-d015-e522-a5db4eed4b0c
Content: Turn on or off entry and exit announcements for meetings
Content Source: Skype/SfbOnline/audio-conferencing-in-office-365/turn-on-or-off-entry-and-exit-announcements-for-meetings.md
Service: skype-for-business-online
Product: unspecified
GitHub Login: @tonysmit
Microsoft Alias: tonysmit

@NickDorak - we are currently adding more examples to the cmdlets. I opened an issue in the repo where the cmdlet lives so you can track. Here is a link: https://github.com/MicrosoftDocs/office-docs-powershell/issues/1406
Thanks for the feedback and for taking the time to provide this gap. It is appreciated!

@NickDorak - I was able to confirm today you were exactly right. Thank you for taking the time to report. This should be to: https://docs.microsoft.com/en-us/powershell/module/skype/set-csonlinedialinconferencingtenantsettings?view=skype-ps
I have submitted a Pull Request with the fix here: https://github.com/MicrosoftDocs/OfficeDocs-SkypeForBusiness/pull/538

authors: NickDorak kenwith


text:
Need Clarification - Chatting with an external account

This document doesn't include the scenario or reference to how to chat 1:1 with an external contact. Can you create a new document or edit this one with more clarity.
Scenario - tenant 1 with a Teams license, wants to 1:1 chat with another contact in Teams tenant 2. Assumption, both have external access enabled. Search by e-mail address in Teams doesn't find the other contact. Something must be missing. This document may be technically correct, but it doesn't answer why you cannot find the other contact.
Still investigating, but found this UserVoice post, https://microsoftteams.uservoice.com/forums/555103-public/suggestions/39232003-i-want-to-be-able-to-chat-with-an-external-member

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 5f080a5c-4268-1db4-566f-f1edc27920b5
Version Independent ID: ac556a92-58af-3e05-f53b-0fc00afc96c0
Content: Communicate with users from other organizations in Microsoft Teams - Microsoft Teams
Content Source: Teams/communicate-with-users-from-other-organizations.md
Service: msteams
GitHub Login: @LolaJacobsen
Microsoft Alias: lolaj

@vinbelms can you weigh in here please?

Alright, it may seem basic but it just is no where to be found and one simply and clearly written article would be great.
There are several complimentary articles but none is very clear. They all have technical information that may be accurate but for a lay person, the guidance is not very straight forward.
Here is one thread that I found. https://techcommunity.microsoft.com/t5/microsoft-teams/getting-started-creating-a-team-accross-two-tenants/m-p/304576
It has a nice title "Getting started creating a team across two tenants"
I think I figured it out. Here are the steps.

You basically have to have guest access turned on. From at least one of the tenants.
Once you do that from the tenant that can accept guests, you can then invite the other person. There is an article about that. https://support.office.com/en-us/article/Add-guests-to-a-team-in-Teams-fccb4fa6-f864-4508-bdde-256e7384a14f
They will receive a notification in e-mail, and once they click on it, basically they are accepting the invitation. They key here is that they have to accept the invitation. It goes through a series of checks (magical configuration that only the wizard knows)(We can revisit this later, especially when it comes to troubleshooting)
Once that step 3 is complete and seemingly only then can the two chat one another.

Once you write it up, you can the add cross-references to
https://docs.microsoft.com/en-us/microsoftteams/native-chat-for-external-users
https://docs.microsoft.com/en-us/MicrosoftTeams/guest-joins (this one does provide the information that once a guest joins then they can chat, but if I were searching for "chat in Teams across two tenants" I wouldn't find it.

@vinbelms what content updates should we make, based on Jmartinez589's suggestions?

@Jmartinez589 @vinbelms
WRT 1:1 chat with an external access user: Check out our external access article: https://docs.microsoft.com/en-us/MicrosoftTeams/manage-external-access
See this note, which explains why you may not be able to start a 1:1 chat with an external user:
Currently, to federate within the Microsoft Teams app to an external user outside of your organization who's not currently a guest of your Azure Active Directory (Azure AD) or tenant, you must be correctly set up for hybrid and moved to Skype for Business Online. As of February 25, 2019, Teams doesn't support native federation without the user of the SIP profile being homed in Skype for Business Online. For more on setting up your account for hybrid and then moving to Teams, see Upgrade Skype for Business hybrid deployment to Teams.


text:
excel file available to capture the data

Has anyone ported the questionaire into excel?  If so please advise wher I can download from thanks!

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: a0a91395-2df9-c611-9a82-e25889f97387
Version Independent ID: c59d6141-1dc1-8e9b-3663-796d31dc6f39
Content: Microsoft Teams Upgrade - Microsoft Teams
Content Source: Teams/upgrade-plan-journey-discovery-questionnaire.md
Service: msteams
GitHub Login: @LanaChin
Microsoft Alias: v-lanac

Thank you for submitting feedback.
I think the best way forward is if you open a service ticket in your tenant so this can get resolved ASAP. Based on the outcome let me know if it is something that can be called out in the docs.
Please follow this link to contact support for business products:https://docs.microsoft.com/office365/admin/contact-support-for-business-products
Please keep us posted here on the resolution so we can feed whatever information you discover into the content.

authors: petermccrindle scanum