text:
chore: remove manage all file permission

Closes #702

confirmed that this PR works for MediaTek internal devices.

this PR worked for MediaTek internal devices except imagenet accuracy. dunno why yet.

Did you rename the file imagenet_val_full.txt to imagenet_val_full.txt.pseudo.png?

this PR worked for MediaTek internal devices except imagenet accuracy. dunno why yet.

Did you rename the file imagenet_val_full.txt to imagenet_val_full.txt.pseudo.png?

surely I did. For mobiledet + coco, it ran well.
I tried it on my Pixel 7a, the app also crashed. See the attached logcat log mobilenet_crash.txt

If I use only the first 1000 ILSVRC2012_val_000*.JPEG, it works

Looking at the crash log, I guess maybe a file is corrupted.

Looking at the crash log, I guess maybe an image file is corrupted.

with binary search, it shows ILSVRC2012_val_00001644.JPEG is incompatible with Android Exif related functions.
I am not sure if it's corrupted. It displayed well on both Android (with File app) and macOS Preview.
07-18 09:27:20.497  3254  5045 W System.err: java.lang.NumberFormatException: For input string: "????"
07-18 09:27:20.498  3254  5045 W System.err:    at java.lang.Integer.parseInt(Integer.java:747)
07-18 09:27:20.498  3254  5045 W System.err:    at java.lang.Integer.parseInt(Integer.java:865)
07-18 09:27:20.498  3254  5045 W System.err:    at android.media.ExifInterface$ExifAttribute.getIntValue(ExifInterface.java:1010)
07-18 09:27:20.498  3254  5045 W System.err:    at android.media.ExifInterface.handleThumbnailFromJfif(ExifInterface.java:4328)
07-18 09:27:20.498  3254  5045 W System.err:    at android.media.ExifInterface.setThumbnailData(ExifInterface.java:4301)
07-18 09:27:20.498  3254  5045 W System.err:    at android.media.ExifInterface.loadAttributes(ExifInterface.java:2033)
07-18 09:27:20.498  3254  5045 W System.err:    at android.media.ExifInterface.<init>(ExifInterface.java:1568)
07-18 09:27:20.498  3254  5045 W System.err:    at com.android.providers.media.MediaProvider.getRedactionRanges(MediaProvider.java:9050)
07-18 09:27:20.498  3254  5045 W System.err:    at com.android.providers.media.MediaProvider.getRedactionRanges(MediaProvider.java:9023)
07-18 09:27:20.498  3254  5045 W System.err:    at com.android.providers.media.MediaProvider.getRedactionRangesForFuse(MediaProvider.java:9005)
07-18 09:27:20.498  3254  5045 W System.err:    at com.android.providers.media.MediaProvider.onFileOpenForFuse(MediaProvider.java:9260)

I stripped EXIF information from the ILSVRC2012_val_00001644.JPEG file with exiftool, https://exiftool.org
exiftool -EXIF=  ILSVRC2012_val_00001644.JPEG

and push it back to Android, then it went well.
I am not sure if there are other problematic ones.

@freedomtan to try to remove EXIF information from all the jpeg files which have EXIF to if we can finish reading all the 50, 000 imagenet validation files. < --- this doesn't look elegant.
How MS office apps work on Android (do they use all file permission?)

for a in *.JPEG
  do exiftool -EXIF=  $a
done

@freedomtan to try to remove EXIF information from all the jpeg files which have EXIF to if we can finish reading all the 50, 000 imagenet validation files. < --- this doesn't look elegant.
How MS office apps work on Android (do they use all file permission?) @freedomtan

Confirmed that

if I remove all the EXIF in jpeg files, I can get expected accuracy number on my Pixel 7a
MS 365 apps DO need the "all file permission"

Let's try to see if we can get the apk accepted to Play Store with the "all file permission" option there. If that doesn't work, then we can to use this one.

The app is now accepted by Google for public testing at
https://play.google.com/store/apps/details?id=org.mlcommons.android.mlperfbench

@anhappdev I didn't realize it's in "public testing" now. Could we back to "internal testing" because we don't have the EULA fixed and all the backends tested.

@anhappdev I didn't realize it's in "public testing" now. Could we back to "internal testing" because we don't have the EULA fixed and all the backends tested.

Ok. Done.

I tried to run the app on my galaxy s23... but it crashes. Do we know of any known issues?

I tried to run the app on my galaxy s23... but it crashes. Do we know of any known issues?

Can you test the build 136?
The compileSdkVersion was changed from 33 to 34 in that commit. Maybe that is the issue.

@mohitmundhragithub to test build 136 and build 134

Hi @anhappdev @freedomtan,  I tried both build 134 and build 136 on my galaxy S23 ultra. Both of them are able to run the testcases just fine.

I tried to run the app on my galaxy s23... but it crashes. Do we know of any known issues?

@mohitmundhragithub Can you share the crash log?

I tried to run the app on my galaxy s23... but it crashes. Do we know of any known issues?

@mohitmundhragithub Can you share the crash log?

Looks like the app is not available in playstore anymore.

I tried to run the app on my galaxy s23... but it crashes. Do we know of any known issues?

@mohitmundhragithub Can you share the crash log?

Looks like the app is not available in playstore anymore.

Can you test the AKP here in the CI.

I tried to run the app on my galaxy s23... but it crashes. Do we know of any known issues?

@mohitmundhragithub Can you share the crash log?

Looks like the app is not available in playstore anymore.

@mohitmundhragithub Can you test the APK here in the CI?

I tried this apk: https://github.com/mlcommons/mobile_app_open/actions/runs/9476794795/artifacts/1592456513
which i got from here (this PR's CI): https://github.com/mlcommons/mobile_app_open/actions/runs/9476794795/job/26110387649?pr=745
This also works fine.

Could play store put some restrictions which makes the app to fail?

I don’t know yet. But if the crash is not related to this PR. Let’s merge this, then we will have a new build in Play Store and we can test the Play Store build again.

Could play store put some restrictions which makes the app to fail?

I don’t know yet. But if the crash is not related to this PR. Let’s merge this, then we will have a new build in Play Store and we can test the Play Store build again.

I am fine with it.
does it work for everyone else as well?

authors: anhappdev freedomtan mohitmundhragithub


text:
About Server scenario

Hi guys! Thank you always!
I tried to run server scenario while I was running it. I had some question about the scenario.

About Server metric.

What I know that the metric is queries per second.

I know that usually metric is on the top of the log_summary.
1-1) On this, Scheduled samples per second? is it correct?
since samples per query is 1. queries per second will be same as samples per second.
1-2) If you see, I tested with different qps. And samples per second is linearly increasing with qps.
I wonder that I could see the result as correct metric since it changed like that.

About Server test setting.

First, I tried to test without any command line parameter. but I couldn't get valid result. I got something like "nan".

I tried with --max-latency 1 and it worked.
2-1) I wonder why this parameter make valid result and what this parameter stands for?
2-2) I changed value of --max-latency and I could see target latency as multiple of 10*--max-latency.
But I tried this with Multi stream scenario. But in multi stream scenario, it doesn't change.
Do you know why it change and why it isn't change?

Thank you!
Kwan

unfortunately the current MLPerf documentation is not there. Please consult the source code under the loadgen folder

source: gharchive/issue

repo: mlperf/inference

license_type: permissive

license_source: github-api


text:
Adam Equivalence

Original Pytorch Adam doesn't match paper; resnet50 reference uses this different optimizer. Recently, pytorch changed Adam (to match paper). Slightly different numerics. TF matches what pytorch used to do; TF explicitly documents that they do not implement Adam's numerics as described by the paper.
Currently, latest pytorch and TF differ in Adam implementations and numerics.
(1) Allow both optimizers -- non ideal from an equivalence perspective.
(2) Implement "MLPerf Adam" which should be used for in the framework which differs. (either (a) create one for TF, or (b) create one for pytorch) (downside is adding engineering work)
(3a) Have the frameworks change default Adam (unlikely)
(3b) Add a special flag for compatibility (to TF for paper adam, or to pytorch for tf style adam)
AI(everyone) prepare for vote next week.

Proposal:
Create a pytorch adam optimizer (which matches tensorflow) and have MLPerf submitters using pytorch "plug in" this optimizer.
We will move forward with this proposal; pending details who makes pytorch optimizer.

We are waiting on investigation into this from FB/pytorch.

@bitfort Any update on this?

AI(NV) - push forward on this, volunteered in John's absence.

SWG direction to submitters: if you are using pytorch Adam, remember to see the allow optimizer table here:
https://docs.google.com/spreadsheets/d/1be3ueG_NXY1Ei7rVem7R9FC5Xymu5d8naFaD645wFr0/edit#gid=1978307898
This lists the optimizers which have been checked for equivalence. If you do not use one of these optimizers, you will have to check and ensure equivalence yourself.

No further action required.


text:
Add ConcurrentExecution step

ML-6015
Based on the preexisting internal _ConcurrentJobExecution class. With support for three concurrency mechanisms: asyncio, threading, and multiprocessing.

Do we want to address this issue within the current pull request?
To make mlrun context serializable isn't something we can do in storey anyway.

It seems that the 'pass_context' flag may not be the best solution for the problem
Why is it the flag's fault? :) Do you have some change in mind?

Do we want to address this issue within the current pull request?

To make mlrun context serializable isn't something we can do in storey anyway.

It seems that the 'pass_context' flag may not be the best solution for the problem

Why is it the flag's fault? :) Do you have some change in mind?

Can you check if indeed https://github.com/uqfoundation/dill can serialize lambdas?

@assaf758, I don't believe multiprocessing allows for replacing pickle with dill or anything else. Do you have a solution in mind?

@assaf758, it can, but it's not obvious how to use that to solve the problem. I'll try to find a way.

It turns out that mlrun GraphContext contains the entire graph, which even dill fails to serialize. Ironically, it's there for ParallelRun.

source: gharchive/pull-request

repo: mlrun/storey


text:
Google and Facebook auth

Hey there, great article / demo!
Are you still planning to expand your demo a little bit to include Google auth?
I noticed this comment.
Thanks!

Hey, Thanks for the feedback, Adam, and good eye!
Ya, I think at the time of writing that I had bigger plans to support Google, etc. but as always just never found the time.  I have no plans on extending this demo, but if you're up to the task you should be able to take this project and extend it without too much effort to use google auth provider by following this guide:
http://docs.identityserver.io/en/aspnetcore1/quickstarts/4_external_authentication.html
It doesn't look like there's too much to it.  You need to follow the steps to register your app with Google in the developer portal, then enable the middleware config in the comment you found and plug in the values you get from Google for the ClientId and ClientSecret.
If you attempt the experiment, let me know how it works out - good luck!
Regards,
Mark

authors: aplocher mmacneil

repo: mmacneil/AngularASPNETCoreOAuth

license: MIT


text:
Any luck with Eddystone?

Hi, just wanted to check back to see whether you got a chance to look into the Eddystone support for this module. Man, this library is awesome :) If we could add Eddystone & Background service, that would cover most of the things.

Hello there!
Unfortunately I can't test Eddystone support myself, I only have a bunch of Estimotes and Kontakt beacons for testing purpose.
I can help you debug their monitoring though!  It's really not that hard, and no Java knowledge is needed.
First of all let's check if the default log I included can be helpful.
Start you application and in the terminal type: adb logcat | grep 'BeaconsAndroid' (you might also need to use the adb-reverse command because you're working on a real device).
Then start ranging for Eddystone beacons and tell me if you see anything logged in the console.
#8 is related

Regarding the background service... the last time I took a look at it it didn't seem doable on React-Native... but I would be happy to be proved wrong.

Hi, I really appreciate your prompt response. I just followed your instruction and here is some of the log content,

I started Ranging with Estimote on Android device (Primary Packet Type - Eddystone URL/UID - I tried both)

Here is code that I am using in my JS component file,
`Beacons.detectCustomBeaconLayout('s:0-1=feaa,m:2-2=00,p:3-3:-41,i:4-13,i:14-19');
Beacons.detectCustomBeaconLayout('s:0-1=feaa,m:2-2=00,p:3-3:-41,i:4-13,i:14-19;d:20-21');
Beacons.detectCustomBeaconLayout('x,s:0-1=feaa,m:2-2=20,d:3-3,d:4-5,d:6-7,d:8-11,d:12-15');
Beacons.detectCustomBeaconLayout('s:0-1=feaa,m:2-2=10,p:3-3:-41,i:4-20v');
Beacons.startRangingBeaconsInRegion('REGION1')
.then(() => console.log(Beacons ranging started succesfully!))
.catch(error => console.log(Beacons ranging not started, error: ${error}))
DeviceEventEmitter.addListener('beaconsDidRange', (data) => {
console.log('Found beacons!', data.beacons)
})`

Once installed on the device, I ran this command adb logcat | grep 'BeaconsAndroid'

Below is the log content that I have got,

D/BeaconsAndroidModule( 6382): BeaconsAndroidModule - started
D/BeaconsAndroidModule( 6382): rangingConsumer didRangeBeaconsInRegion, beacons: []
D/BeaconsAndroidModule( 6382): rangingConsumer didRangeBeaconsInRegion, region: id1: null id2: null id3: null
E/AndroidRuntime( 6382): 	at com.mmazzarolo.beaconsandroid.BeaconsAndroidModule.sendEvent(BeaconsAndroidModule.java:105)
E/AndroidRuntime( 6382): 	at com.mmazzarolo.beaconsandroid.BeaconsAndroidModule.access$200(BeaconsAndroidModule.java:41)
E/AndroidRuntime( 6382): 	at com.mmazzarolo.beaconsandroid.BeaconsAndroidModule$2$1.didRangeBeaconsInRegion(BeaconsAndroidModule.java:233)
D/BeaconsAndroidModule( 8023): BeaconsAndroidModule - started
D/BeaconsAndroidModule( 8023): BeaconsAndroidModule - started
D/BeaconsAndroidModule( 8023): addParser - parser: s:0-1=feaa,m:2-2=00,p:3-3:-41,i:4-13,i:14-19
D/BeaconsAndroidModule( 8023): addParser - parser: s:0-1=feaa,m:2-2=00,p:3-3:-41,i:4-13,i:14-19;d:20-21
D/BeaconsAndroidModule( 8023): addParser - parser: x,s:0-1=feaa,m:2-2=20,d:3-3,d:4-5,d:6-7,d:8-11,d:12-15
D/BeaconsAndroidModule( 8023): addParser - parser: s:0-1=feaa,m:2-2=10,p:3-3:-41,i:4-20v
D/BeaconsAndroidModule( 8023): startRanging, rangingRegionId: REGION1, rangingBeaconUuid: null
D/BeaconsAndroidModule( 8023): startRanging, success
D/BeaconsAndroidModule( 8023): rangingConsumer, called startRangingBeaconsInRegion()
D/BeaconsAndroidModule( 8023): rangingConsumer didRangeBeaconsInRegion, beacons: []
D/BeaconsAndroidModule( 8023): rangingConsumer didRangeBeaconsInRegion, region: id1: null id2: null id3: null
D/BeaconsAndroidModule( 8023): rangingConsumer didRangeBeaconsInRegion, beacons: []
D/BeaconsAndroidModule( 8023): rangingConsumer didRangeBeaconsInRegion, region: id1: null id2: null id3: null
D/BeaconsAndroidModule( 8023): rangingConsumer didRangeBeaconsInRegion, beacons: []
D/BeaconsAndroidModule( 8023): rangingConsumer didRangeBeaconsInRegion, region: id1: null id2: null id3: null
D/BeaconsAndroidModule( 8023): rangingConsumer didRangeBeaconsInRegion, beacons: []
D/BeaconsAndroidModule( 8023): rangingConsumer didRangeBeaconsInRegion, region: id1: null id2: null id3: null
D/BeaconsAndroidModule( 8023): rangingConsumer didRangeBeaconsInRegion, beacons: []
D/BeaconsAndroidModule( 8023): rangingConsumer didRangeBeaconsInRegion, region: id1: null id2: null id3: null
D/BeaconsAndroidModule( 8023): rangingConsumer didRangeBeaconsInRegion, beacons: []
D/BeaconsAndroidModule( 8023): rangingConsumer didRangeBeaconsInRegion, region: id1: null id2: null id3: null
D/BeaconsAndroidModule( 8023): rangingConsumer didRangeBeaconsInRegion, beacons: []
D/BeaconsAndroidModule( 8023): rangingConsumer didRangeBeaconsInRegion, region: id1: null id2: null id3: null
D/BeaconsAndroidModule( 8023): rangingConsumer didRangeBeaconsInRegion, beacons: []
D/BeaconsAndroidModule( 8023): rangingConsumer didRangeBeaconsInRegion, region: id1: null id2: null id3: null
D/BeaconsAndroidModule( 8023): rangingConsumer didRangeBeaconsInRegion, beacons: []
It's always null. But not sure why isn't working for EddyStone. I switched the Primary Packet Type to default(iBeacon) in my Estimote and it's working awesome. Here is the log cat content for iBeacon
D/BeaconsAndroidModule( 9029): BeaconsAndroidModule - started
D/BeaconsAndroidModule( 9029): rangingConsumer didRangeBeaconsInRegion, beacons: []
D/BeaconsAndroidModule( 9029): rangingConsumer didRangeBeaconsInRegion, region: id1: null id2: null id3: null
E/AndroidRuntime( 9029): 	at com.mmazzarolo.beaconsandroid.BeaconsAndroidModule.sendEvent(BeaconsAndroidModule.java:105)
E/AndroidRuntime( 9029): 	at com.mmazzarolo.beaconsandroid.BeaconsAndroidModule.access$200(BeaconsAndroidModule.java:41)
E/AndroidRuntime( 9029): 	at com.mmazzarolo.beaconsandroid.BeaconsAndroidModule$2$1.didRangeBeaconsInRegion(BeaconsAndroidModule.java:233)
D/BeaconsAndroidModule( 9589): BeaconsAndroidModule - started
D/BeaconsAndroidModule( 9589): addParser - parser: m:0-3=4c000215,i:4-19,i:20-21,i:22-23,p:24-24
D/BeaconsAndroidModule( 9589): startRanging, rangingRegionId: REGION1, rangingBeaconUuid: null
D/BeaconsAndroidModule( 9589): startRanging, success
D/BeaconsAndroidModule( 9589): rangingConsumer, called startRangingBeaconsInRegion()
D/BeaconsAndroidModule( 9589): rangingConsumer didRangeBeaconsInRegion, beacons: []
D/BeaconsAndroidModule( 9589): rangingConsumer didRangeBeaconsInRegion, region: id1: null id2: null id3: null
D/BeaconsAndroidModule( 9589): rangingConsumer didRangeBeaconsInRegion, beacons: []
D/BeaconsAndroidModule( 9589): rangingConsumer didRangeBeaconsInRegion, region: id1: null id2: null id3: null
D/BeaconsAndroidModule( 9589): rangingConsumer didRangeBeaconsInRegion, beacons: [id1: b9407f30-f5f8-466e-aff9-25556b57fe6d id2: 19295 id3: 60697]
D/BeaconsAndroidModule( 9589): rangingConsumer didRangeBeaconsInRegion, region: id1: null id2: null id3: null
D/BeaconsAndroidModule( 9589): rangingConsumer didRangeBeaconsInRegion, beacons: []
D/BeaconsAndroidModule( 9589): rangingConsumer didRangeBeaconsInRegion, region: id1: null id2: null id3: null
D/BeaconsAndroidModule( 9589): rangingConsumer didRangeBeaconsInRegion, beacons: []
D/BeaconsAndroidModule( 9589): rangingConsumer didRangeBeaconsInRegion, region: id1: null id2: null id3: null
D/BeaconsAndroidModule( 9589): rangingConsumer didRangeBeaconsInRegion, beacons: [id1: b9407f30-f5f8-466e-aff9-25556b57fe6d id2: 19295 id3: 60697]
D/BeaconsAndroidModule( 9589): rangingConsumer didRangeBeaconsInRegion, region: id1: null id2: null id3: null
D/BeaconsAndroidModule( 9589): rangingConsumer didRangeBeaconsInRegion, beacons: [id1: b9407f30-f5f8-466e-aff9-25556b57fe6d id2: 19295 id3: 60697]
D/BeaconsAndroidModule( 9589): rangingConsumer didRangeBeaconsInRegion, region: id1: null id2: null id3: null
D/BeaconsAndroidModule( 9589): rangingConsumer didRangeBeaconsInRegion, beacons: []
D/BeaconsAndroidModule( 9589): rangingConsumer didRangeBeaconsInRegion, region: id1: null id2: null id3: null
D/BeaconsAndroidModule( 9589): rangingConsumer didRangeBeaconsInRegion, beacons: []
Thanks again for helping me out.

For the background service, I went through some forums and it seems, we can do it on React Native. Here is the stackoverflow link where people discussing on Background intent service,
http://stackoverflow.com/questions/34687473/background-service-on-react-native-android
Also, the below listed repo have this background service but it's been commented now. @devfd mentioned that he would release the new one with background service that even work when the android app is killed from app switcher.
Here is the link to his repo, https://github.com/devfd/react-native-workers
Here is the background service related files that are commented by author for now,
https://github.com/devfd/react-native-workers/blob/master/android/src/main/java/co/apptailor/Worker/JSService.java
https://github.com/devfd/react-native-workers/blob/master/android/src/main/java/co/apptailor/Worker/WorkerModule.java (find the startService() function.
Also, from the below article, it seems it's possible to use existing android native module, https://shift.infinite.red/shopping-external-libs-in-react-native-cfbc0c6e25cf#.fnrz9qh57
In that case, if we could integrate this, that would solve the back ground problem.
https://android-arsenal.com/details/1/4179
Of course, I could be wrong but I thought of sharing what I came up with in my findings. I also have to be honest with you that I never tried JAVA before.

Thank you so much @sudharsan1988, you've been incredibly helpful!
Regarding the Eddystone: you did everything right (you followed this, am I right?), but it still seems that the AltBeacons Library (the one I implemented in this module) is not able to detect the Eddystone beacons... that's weird and unfortunately without an Eddystone beacon it's not easy for me debugging this issue.
I'm sorry man, the only thing I can do is keeping this issue open hoping for the help of someone with a bit of Java knowledge and an Eddystone beacon to test.
Regarding the background service: thanks again, it seems doable now 👍 , the only thing I need to investigate further is understanding if I can keep the service in the background even when the app is not in memory (aka when you swipe it from the recent apps).  If it was a standard Android app it would be easy, but I don't know if being tied to JS can be a problem...

I also updated the readme!

@mmazzarolo , really thanks for updating the readme. I'm sorry that I couldn't help you with Java part but whenever you need, I can do testing with the Eddystone(Estimote) that I have got.
Also, for the background service, could you take a look at this library as it's using the background service even when the app is killed. I have tested this myself and that works fine. I can get the push notifications even after I killed the app from the app switcher.
https://github.com/zo0r/react-native-push-notification
I'm sure, it can help us to understand how to integrate the Background service. I'm also trying to find out if there is any open source background service library is already out there for us to use. I will keep you posted.

Hi, this article may be helpful for background service. https://dzone.com/articles/how-to-develop-a-simple-step-counter-app-on-reactn
I tried their example app on Android Emulator but no luck. There are some issues in the Example app.
Here is their github repo, https://github.com/Singree/react-native-example-app

I'll take a look on this.

@sudharsan1988 sorry, I'm having two busy week at work, I'll take a look at all the links you posted as soon as you can.
@levint That's awesome :) hope to hear news soon, ping me if you need anything
Thank you guys!

@mmazzarolo , no worries! I will keep digging for the background service and keep you posted :)
@levint , thank you for helping us out. I have a Eddystone beacon(Estimote) with me. I can help you with any testing you want.

@mmazzarolo I have an Estimote beacon but with a firmware update now supports Eddystone!

It's not yet working on mine, as of this moment. I also tried installing Beacon Toy on my mobile phone and set it to broadcast as Eddystone-URL, but it still cannot be detected by the react-native app.

@levint thank you for your support.
It seems an altBeacon issue... if you still have some spare time you might try updating the altBeacon library (in the build.gradle).
I had a similiar issue in the past that was fixed just by downgrading the lib. 👍

@mmazzarolo
UPDATE: I made it to work using an Eddystone-capable Beacon. I'll post my findings later.

Hi @mmazzarolo, do you want me to submit a PR or would you like to do it on your own as per my findings?
Technically, adding a BeaconParser should be done before the Consumer (in the library's case, the ReactContextBaseJavaModule subclass) is binded to the BeaconManager instance via (mBeaconManager.bind(this)).
My proposed solution would be to check if the consumer is already bound to the manager instance before ranging and/or monitoring is done, probably on the start of startRanging/startMonitoring methods. If not yet bound, then we should bind it. (Instead of doing it in the constructor).
It is also possible to do it on the react-native side :)

@levint that's awesome!
Unfortunately I have two really busy weeks ahead, so PRs are welcome!
Otherwise I'll have to take a look at it next month :(
Thank you again!

@mmazzarolo Okay, will do before this week ends :)

@levint , awesome news! Is it possible for you to share your forked version of repo, I am very excited to test it :)

@levint, just curious to know whether you have got any chance to PR the changes regarding the Eddystone?

Hey @levint, sorry to bother you... do you have any info regarding Eddystone? Thanks!

@levint can u send ur PR regarding eddystone
Thanks

Hi,
May I ask if the library could support Eddystone now ?

authors: 1453026 levint micheletedeschi mmazzarolo nitkuk sudharsan1988

repo: mmazzarolo/react-native-beacons-android

license: mit

license_source: bigquery


text:
Decide how to handle stages that require metadata to contain all codes in the (train set) of the dataset.

Right now, some stages, like reorder_measurements.py, fit_vocabulary_indices.py, etc. all assume that all codes in the dataset are present in the metadata/codes.parquet file. This is not necessarily guaranteed unless these stages are immediately preceded by either (1) a code aggregation stage or (2) a set of stages that all guaranteeably introduce no new codes which are themselves preceded by a code aggregation stage.
It is not clear to me what the best way is to solve this problem. We can either

Simply update the documentation and leave it to users to run an aggregation stage if they so desire (we may want to make a stage that just collects codes and doesn't compute anything in that case).
Make it so that the codes.parquet file is always current with the most recent stage. This can be done by ensuring
1. That datasets always start with a metadata file that has all the codes and
2. That any stage that adds new codes updates the running metadata/codes.parquet file with records for those new codes. These records could either:

Be empty except for the code name. This would be the simplest to add, but would also mean that one could no longer rely on the other columns in the metadata file (e.g., aggregation counts) as they would be missing.
Dynamically compute all missing aggregations via aggregation column name and link parent_codes to their original source codes in the dataset when possible. This would be more complex and would fail for stages that don't use the same aggregation names.

Note that the failure mode here is not necessarily too egregious -- I don't think we'll drop data or anything like that in cases where this is most likely to come up, but it is likely that things won't work as expected (e.g., newly added codes won't be assigned the right order if they aren't in the codes.parquet file when the reorder_measurements.py stage is run).

@prenc and @Oufattole, I don't think this is particularly urgent as we can just use the documentation solution for now, but I'd be interested in both of your takes (especially yours @prenc, given you employ both a number of "add new code" operations and "reorder" operations).


text:
Using pure javascript instead of node dependencies

I'm developing a product on Cloudflare Workers and I wanted to use io-ts-extra for handling optional types. Unfortunately, workers platform does not support Node, so It's not possible to use the library in workers environments. I wonder if it's possible to shift node dependencies to javascript API for the library's more useability?

I thought I replied to this a few weeks ago, not sure where it went. Isn’t webpack a good option for this use case?

Cloudflare does not recommend using webpack for the new modules version of the workers. Even if so, I don't think the webpack is capable of transforming complex libraries like fs.

fs isn’t used so should be fine. Admittedly I haven’t use CF workers but webpack can just bundle the same code that you plan on running. I can’t see what the issue would be.

You might be right but even if webpack polyfills all of the libraries without an issue, using webpack is such a headache by itself. io-ts-types worked without a problem so I went with that.

Ok. It’s worth noting that io-ts-extra doesn’t have any node dependencies beyond import {EOL} from ‘os’ which any bundler would be able to handle, I would hope! Great that io-ts-types ended up working for you, but if you need to use this or other libraries as your project grows, maybe it’d be worth looking at parcel if you want something with less configuration than webpack, or esbuild if you want something faster.

authors: mmkal omertoast

repo: mmkal/ts


text:
[Snyk] Upgrade @typescript-eslint/parser from 6.12.0 to 6.13.1

This PR was automatically created by Snyk using the credentials of a real user.Snyk has created this PR to upgrade @typescript-eslint/parser from 6.12.0 to 6.13.1.
:information_source: Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.

The recommended version is 11 versions ahead of your current version.
The recommended version was released 22 days ago, on 2023-11-28.

Release notes

Package name: @typescript-eslint/parser

6.13.1 - 2023-11-286.13.1 (2023-11-28)
Bug Fixes

default to parse all JSDoc and provide options to configure it (#7999) (779e13e)

You can read about our versioning strategy and releases on our website.

6.13.1-alpha.0 - 2023-11-27

6.13.0 - 2023-11-276.13.0 (2023-11-27)
Note for eslint plugin authors and other API consumers
TypeScript v5.3 shipped with a type change that was incompatible with our types. This change has been fixed and will be released in v5.3.3. Until that time you can work around this error using skipLibCheck.
Bug Fixes

typescript-estree: ensure backwards compat with pre-5.3 import attributes (#7967) (810fc8c)

Features

support TS 5.3 (#7968) (fb50638)
typescript-estree: pass jsDocParsingMode everywhere (#7997) (3d2a344)

You can read about our versioning strategy and releases on our website.

6.12.1-alpha.7 - 2023-11-27

6.12.1-alpha.6 - 2023-11-27

6.12.1-alpha.5 - 2023-11-24

6.12.1-alpha.4 - 2023-11-24

6.12.1-alpha.3 - 2023-11-24

6.12.1-alpha.2 - 2023-11-23

6.12.1-alpha.1 - 2023-11-21

6.12.1-alpha.0 - 2023-11-20

6.12.0 - 2023-11-206.12.0 (2023-11-20)
Bug Fixes

eslint-plugin: [class-methods-use-this] detect a problematic case for private/protected members if ignoreClassesThatImplementAnInterface is set (#7705) (155aa1f)
eslint-plugin: [no-unnecessary-condition] fix false positive with computed member access and branded key type (#7706) (f151b26)
eslint-plugin: [switch-exhaustiveness-check] enum members with new line or single quotes are not being fixed correctly (#7806) (a034d0a), closes #7768
utils: add missing fields to flat config types (#7933) (533861a)
utils: allow string processor in flat config (024ed9e)

Features

[member-ordering] add accessor support for member-ordering (#7927) (3c8312d)
eslint-plugin: [switch-exhaustiveness-check] add requireDefaultForNonUnion option (#7880) (4cfcd45)
update TypeScript to 5.3-rc (#7923) (9034d17)

You can read about our versioning strategy and releases on our website.

    from @typescript-eslint/parser GitHub release notes

Commit messages

Package name: @typescript-eslint/parser

14f3ff0 chore: publish v6.13.1
779e13e fix: default to parse all JSDoc and provide options to configure it (#7999)
39c437a chore: publish v6.13.0
3d2a344 feat(typescript-estree): pass jsDocParsingMode everywhere (#7997)
fb50638 feat: support TS 5.3 (#7968)
d244b0e chore(deps): update dependency @ types/node to v20.9.3 (#7989)
d378f9e chore(deps): update dependency @ swc/core to v1.3.99 (#7985)
8b1e09e chore: update sponsors (#7981)
a9fbeb7 docs: fix incorrect example command (#7976)
810fc8c fix(typescript-estree): ensure backwards compat with pre-5.3 import attributes (#7967)
9139b9d chore: revert "chore(deps): update dependency react-resizable-panels to ^0.0.57" (#7963)

Compare

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.
For more information:
🧐 View latest project report
🛠 Adjust upgrade PR settings
🔕 Ignore this dependency or unsubscribe from future upgrade PRs

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (62538c7) 92.34% compared to head (e8703f8) 92.34%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #42   +/-   ##
=======================================
  Coverage   92.34%   92.34%
=======================================
  Files           6        6
  Lines         418      418
  Branches       11       11
=======================================
  Hits          386      386
  Misses         32       32

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

authors: codecov-commenter mmomtchev

repo: mmomtchev/everything-json

license: ISC


text:
^telemetry[-.]  doesn't block all telemetry sites

The option  ^telemetry[-.]  doesn't block sites like:
reports.wes.df.telemetry.microsoft.com
services.wes.df.telemetry.microsoft.com
sqm.df.telemetry.microsoft.com
sqm.telemetry.microsoft.com
sqm.telemetry.microsoft.com.nsatc.net
telecommand.telemetry.microsoft.com
telecommand.telemetry.microsoft.com.nsatc.net
watson.telemetry.microsoft.com
watson.telemetry.microsoft.com.nsatc.net
etc.
Beter is to use
(^|.)telemetry[-.]
which also covers the examples above.

Made a change to reflect this in https://github.com/mmotti/pihole-regex/commit/3b38c283493cad8d99449f8dd2f46c3050661e7e

authors: eejeel mmotti

repo: mmotti/pihole-regex


text:
Drop testing of mayavi plotting

And focus on pyvista instead

Codecov Report

Merging #365 (1db5049) into main (813efd6) will decrease coverage by 7.70%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #365      +/-   ##
==========================================
- Coverage   95.92%   88.21%   -7.71%
==========================================
  Files          49       49
  Lines        1765     1757       -8
  Branches      229      229
==========================================
- Hits         1693     1550     -143
- Misses         30      166     +136
+ Partials       42       41       -1

Impacted Files
Coverage Δ

mne_nirs/visualisation/tests/test_visualisation.py
80.85% <100.00%> (-19.15%)
:arrow_down:

mne_nirs/statistics/_roi.py
13.88% <0.00%> (-75.00%)
:arrow_down:

...e_nirs/visualisation/_plot_nirs_source_detector.py
20.83% <0.00%> (-75.00%)
:arrow_down:

mne_nirs/tests/test_examples.py
38.88% <0.00%> (-50.00%)
:arrow_down:

mne_nirs/visualisation/_plot_GLM_topo.py
68.11% <0.00%> (-28.27%)
:arrow_down:

mne_nirs/statistics/_statsmodels.py
80.51% <0.00%> (-10.39%)
:arrow_down:

...rs/datasets/fnirs_motor_group/fnirs_motor_group.py
93.33% <0.00%> (-6.67%)
:arrow_down:

mne_nirs/statistics/_glm_level_first.py
80.70% <0.00%> (-6.58%)
:arrow_down:

...e_nirs/signal_enhancement/_negative_correlation.py
100.00% <0.00%> (ø)

... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 813efd6...1db5049. Read the comment docs.

authors: codecov-commenter rob-luke

repo: mne-tools/mne-nirs


text:
eliminate_stim_artifact for evoked

eliminate_stim_artifact only accepts raw objects. It makes more sense to remove the artifact on evoked.
eliminate_stim_artifact should accept evoked object.
any taker?

I think its solution is that copy notch_filter method in .io.base.py to evoked.py.

what do you mean the solution?

If you copy notch_filter method in .io.base.py to evoked.py, you can eliminate stim_artifact for evoked, I think.

? stim artifact is not corrected with notch_filter. See how it is done with
raw files.

Oops.. Sorry for my mistake.. I have misunderstood about this issue..

issue should be simpler than dealing with notch filter

It's eliminate_stim_artifact not eliminate stim_artifact :)
Take a look here: https://github.com/mne-tools/mne-python/search?utf8=✓&q=eliminate_stim_artifact

@agramfort Now we can close this issue.

authors: agramfort dlsrnsi mainakjas

repo: mne-tools/mne-python


text:
EGI file import

Hi,
First of all, thank you very much for the EGI file import, it saves us a lot of time!
We have been using the function mne.io.read_raw_egi on our EGI data (version5.3) but encountered several issues:

There seems to be a trigger exclusion problem, where the first trigger gets excluded. This happens about 50% of the time, it is always the first trigger in the stimulation protocol, but never one of the manually set triggers in the EGI software (that happen before). I set both the include and exclude criteria to None, and all my triggers happen more than once. I have tried to set include to a list of all triggers, this did not help. I have to admit that I am having problems understanding the documentation on the inclusion/exclusion, maybe I am missing something?

There is one subject for which we had to pause the recording within the EGI software. The import of this data throws an indexError (out of bounds) as shown in the error message attached.

errorMessage_EGIdatapaused.txt
Please let me know if you'd like me to sent you the data with the pause (700mb)
I hope you can help, thank you!

@LizetteH you will need to look at the code to figure out what is happening. I don't know if @jaeilepp will find the time to look. It can be useful to share the data so someone can replicate and maybe help.

Can confirm, if you pause the recording, you get this error.
Inside the MFF file you have two epochs.
I don't have time to create the test file and address this issue right now. But if someone does create a 10s file with a pause in between, I can take a look.

authors: LizetteH agramfort fraimondo


text:
WIP: STC baseline correction

Thanks for contributing a pull request! Please make sure you have read the
contribution guidelines
before submitting.
Please be aware that we are a loose team of volunteers so patience is
necessary. Assistance handling other issues is very welcome. We value
all user contributions, no matter how minor they are. If we are slow to
review, either the pull request needs some benchmarking, tinkering,
convincing, etc. or more likely the reviewers are simply busy. In either
case, we ask for your understanding during the review process.
Again, thanks for contributing!
Reference issue
#8232
What does this implement/fix?
Baseline-correction for source estimates is recommended/necessary for some processing steps. For example, for unsigned source estimates, differences in noise levels may result in differences in intensities (e.g. for conditions with very different numbers of trials). This can be compenstated for by baseline-correction.
I will add a method appy_baseline() to source_estimate.py, analogous to evoked.py. I will add documentation to highlight the caveats of baseline correction for source estimates.
Additional information
Any additional information you think is important.

@jona-sassenhagen Thanks a lot - I hope I managed to implement all your suggestions.

I don't think the remaining errors have anything to do with me - please let me know.

I restarted Azure and it's green now.

@olafhauk You need to mark this PR as ready for review so it can be merged

Docs look good: https://23142-1301584-gh.circle-artifacts.com/0/dev/generated/mne.SourceEstimate.html?highlight=sourceestimate#mne.SourceEstimate.apply_baseline

@jona-sassenhagen Merge if you're happy

was missing a what's new entry...
@olafhauk can you make a PR to get credit for this work?

authors: GuillaumeFavelier agramfort hoechenberger olafhauk


text:
[BUG, MRG] fix coordinate frame in fNIRS bug

Fixes #9627.

Look okay to you @rob-luke?

Does this require that a user converts their montage to head frame in advance? Or is this done in the upstream function before this internal function is called?
I'm imagining the use case where your optode positions have been specified in MRI frame. How should a user load that montage?
Perhaps we should make it an option for users to specify the frame? Or if not, we should make it clear in the documentation that you must use head frame.
But I'm still learning about coordinatede frames. And I would defer to @larsoner and @agramfort opinions here.

Does this require that a user converts their montage to head frame in advance? Or is this done in the upstream function before this internal function is called?
I'm imagining the use case where your optode positions have been specified in MRI frame. How should a user load that montage?
Perhaps we should make it an option for users to specify the frame? Or if not, we should make it clear in the documentation that you must use head frame.
But I'm still learning about coordinatede frames. And I would defer to @larsoner and @agramfort opinions here.

They are converted to head in mne.channels.montage._set_montage.

Thanks for clarifying. The fNIRS IO page isn't rendering with the example usage of set montage, but i assume it looks identical to before?

Yes, should be identical

Thanks @alexrockhill

authors: alexrockhill larsoner rob-luke


text:
BL1850B 5.0Ah replaced the cells, and it stopped showing the charge on the indicator.

Hello. They brought a BL1850B 5.0Ah battery, it was working, but it was quickly discharged. I replaced the cells, and it stopped showing the charge on the indicator.
I suppose it got locked. I found your development and decided to try to remove the lock with it. But I failed (((
The 240080 chip was not mentioned anywhere, but I decided to try anyway, because I had an Arduino Nano at hand.
I apologize if there are any inaccuracies, I used Google Translate.

Hi, this should be supported. Try to follow the instructions on the README, for both OpenBatteryInformation and ArduinoOBI,
Once you have connected an interface you should read an interface version, this indicates that everything was set up properly

I can't check it anymore, I've already given the battery away. I made arrangements with a friend who has a charger and a load (a screwdriver) and decided to check it.
As soon as I inserted it into the charger, the battery came to life, and it accepts the charge and the indicator started working. And it works in the load too.
Although I couldn't read it, but still, thank you very much for the program, I think it will help many people!!!

authors: Vovan-sar mnh-jansson

repo: mnh-jansson/open-battery-information


text:
Add support for field title and short attributes

It would be great to align with supporting the additional attributes for a field.  The following field xml should work.
<field>
    <title>Project Version</title>
    <value>${project.version}</value>
    <short>true</short>
</field>

Thanks in advance for considering this request!

Nevermind, I hadn't understood the field structure earlier...

repo: moacyrricardo/maven-slack


text:
Inferred versions from gradle gitflow plugin are wrong

fix inferred versions for previous versions and in develop.

deleted bad tags. Everything seems good from gradle.

repo: moaxcp/graph-dsl


text:
Add CDNJS version badge in README.md

This badge will show the latest library version on CDNJS!

Thanks!


text:
Changes from #297

Changes from https://github.com/mobie/mobie-viewer-fiji/pull/297

Looks good to me. Feel free to merge your own PRs in this repository if you think they are ready to go @KateMoreva.
Since we are not depending on this yet in MoBIE there's no risk of breaking things :).

Thanks, I started working on cleaning the code as it a bit essential to work with 2-5d, once it is done (hope today) I'll merge.

dimensionSeparator is read from metadata
can open example ome.zar files of both versions from file system (form s3 fully not tested yet (can open https://s3.embl.de/i2k-2020/em-raw.ome.zarr))
In progress:
[ ] - functionality should be tested for different scales (possible problems with 2d and 4d)
[ ] - code cleaning (also for n5-zarr as a dependency)

I was working on opening 2d and 4d ome.zarr images, but faces some errors. @tischi, if you ever faced such problems, can you please share ideas on how to solve them?
When I try to open 4d image I get:
Exception in thread "PainterThread" java.lang.ArrayIndexOutOfBoundsException: 3
	at net.imglib2.img.cell.CellGrid.cellDimensions(CellGrid.java:153)
	at bdv.viewer.render.ProjectorFactory.prefetch(ProjectorFactory.java:317)
	at bdv.viewer.render.ProjectorFactory.createSingleSourceVolatileProjector(ProjectorFactory.java:241)
	at bdv.viewer.render.ProjectorFactory.createSingleSourceProjector(ProjectorFactory.java:202)
	at bdv.viewer.render.ProjectorFactory.createProjector(ProjectorFactory.java:170)
	at bdv.viewer.render.MultiResolutionRenderer.createProjector(MultiResolutionRenderer.java:628)
	at bdv.viewer.render.MultiResolutionRenderer.paintFullFrame(MultiResolutionRenderer.java:465)
	at bdv.viewer.render.MultiResolutionRenderer.paint(MultiResolutionRenderer.java:439)
	at bdv.viewer.ViewerPanel.paint(ViewerPanel.java:473)
	at bdv.viewer.render.PainterThread.run(PainterThread.java:82)

When I try to open 4d image I get

Could you please put code into src/test that opens such an image?
Then I can have a look!
Just one comment already: I think that the output that you feed into SpimData must have the same number of dimensions as in the old code where we were reading 5D data. That means if you have now less dimensions somewhere you may have to  add singleton dimensions using Views.addDimension( );

When I try to open 4d image I get

Could you please put code into src/test that opens such an image?
Then I can have a look!
Just one comment already: I think that the output that you feed into SpimData must have the same number of dimensions as in the old code where we were reading 5D data. That means if you have now less dimensions somewhere you may have to add singleton dimensions using Views.addDimension( );

Thank you! I'll try to add a new dimension and load the code if the problem still exists.

The reader can open files with cyx, czyx, tcyx, tczyx, tyx, tzyx, zyx axes and old versions without axes in .zattrs

So it indeed seems like supporting 2d data is a bit more complex, see https://github.com/mobie/mobie-viewer-fiji/issues/310. I think we should go ahead and merge this when everything but 2d works and then work on the 2d problem separately.

ok

authors: KateMoreva constantinpape tischi

repo: mobie/bigdataviewer-ome-zarr


text:
🛑 Pan y Pizza is down

In 1ffadea, Pan y Pizza (https://panypizza.uy) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Pan y Pizza is back up in a760f78.

repo: mobilitysol/monitorweb


text:
🛑 PizzaTime Web is down

In 7dd1cd7, PizzaTime Web (https://pizzatime.uy) was down:

HTTP code: 0
Response time: 0 ms

Resolved: PizzaTime Web is back up in 54bfbff.


text:
Iso week helpers

Here are implementations for all ISO week helper functions, and a couple of ISO Week-numbering year helpers that I needed to implement the week helpers.
I have tried to adhere to the way you have previously done, and I think I have full test coverage. The tests are mainly copied from corresponding tests in date-fns. The implementation is also done with the same logic as in date-fns.

Thanks for all your feedback! I'm away from computer for a few days, but I'll update this PR next week 😊

thank you @mikaello! let me know if you either need more clarification or help ;)

authors: mikaello mobily

repo: mobily/re-date


text:
hqq+ lora ValueError || ValueError: Unable to create tensor, you should probably activate truncation and/or padding with 'padding=True' 'truncation=True'

ValueError: Unable to create tensor, you should probably activate truncation and/or padding with 'padding=True' 'truncation=True' to have batched tensors with the same length. Perhaps your features (text in this case) have excessive nesting (inputs type list where type int is expected).

Can you please explain a bit and provide a code snippet to reproduce the error?

This issue happening from here: https://github.com/mobiusml/hqq/blob/master/examples/lora/train_hqq_lora_example.py

Hi, that's an old issue. HQQ works directly in Peft for a while now: https://huggingface.co/docs/peft/developer_guides/quantization#hqq-quantization

authors: SAIVENKATARAJU mobicham tellyoung

repo: mobiusml/hqq


text:
Fix test for observable propTypes

Addresses #81

Thanks!

authors: jtraub mweststrate

repo: mobxjs/mobx-react


text:
vendor: github.com/docker/docker v23.0.1

follow-up to https://github.com/moby/swarmkit/pull/3117

vendor: github.com/onsi/ginkgo v1.16.4
full diff:

https://github.com/onsi/ginkgo/compare/v1.12.1...v1.16.4
https://github.com/nxadm/tail/compare/v1.4.4...v1.4.8

vendor: github.com/onsi/gomega v1.15.0
full diff: https://github.com/onsi/gomega/compare/v1.10.5...v1.15.0
vendor: github.com/docker/docker v23.0.1
no changes in vendored code
full diff: https://github.com/docker/docker/compare/v23.0.0...v23.0.1
- Description for the changelog

Wait; what happened? I think it was green the first time?
# github.com/moby/swarmkit/v2/manager/csi [github.com/moby/swarmkit/v2/manager/csi.test]
manager/csi/manager_test.go:9:2: Gomega redeclared in this block
	/go/src/github.com/docker/swarmkit/vendor/github.com/onsi/gomega/gomega_dsl.go:44:6: other declaration of Gomega
manager/csi/manager_test.go:9:2: Assertion redeclared in this block
	/go/src/github.com/docker/swarmkit/vendor/github.com/onsi/gomega/gomega_dsl.go:402:6: other declaration of Assertion
manager/csi/manager_test.go:9:2: AsyncAssertion redeclared in this block
	/go/src/github.com/docker/swarmkit/vendor/github.com/onsi/gomega/gomega_dsl.go:380:6: other declaration of AsyncAssertion
FAIL	github.com/moby/swarmkit/v2/manager/csi [build failed]

let me check

ugh.. looks like there's more
# github.com/moby/swarmkit/v2/manager/orchestrator/jobs/replicated [github.com/moby/swarmkit/v2/manager/orchestrator/jobs/replicated.test]
manager/orchestrator/jobs/replicated/reconciler_test.go:6:2: Gomega redeclared in this block
	/go/src/github.com/docker/swarmkit/vendor/github.com/onsi/gomega/gomega_dsl.go:44:6: other declaration of Gomega
manager/orchestrator/jobs/replicated/reconciler_test.go:6:2: AsyncAssertion redeclared in this block
	/go/src/github.com/docker/swarmkit/vendor/github.com/onsi/gomega/gomega_dsl.go:380:6: other declaration of AsyncAssertion
manager/orchestrator/jobs/replicated/reconciler_test.go:6:2: Assertion redeclared in this block
	/go/src/github.com/docker/swarmkit/vendor/github.com/onsi/gomega/gomega_dsl.go:402:6: other declaration of Assertion

@dperny @neersighted @corhere ptal

repo: moby/swarmkit


text:
Update or enhance sourceset

A nice enhancement would be to pass an already processed sourceset into ultimatethumb again. It's meant to be an update on the given sourceset. An example use can look like this:
{% ultimatethumb 'image_sourceset' image '320x0,400x0' %}

...

{% ultimatethumb 'image_sourceset' image_sourceset '320x0,400x0,500x0' retina=True %}

This can be used when the reference to the original source image may not be available in the context of the second call.

Not needed, you can use image_sourceset.0.source

authors: schorfES stephrdev

repo: moccu/django-ultimatethumb


text:
Panic due to unwrapping  None during codegen of tokio crate

Steps to reproduce:

cargo new foo
cd foo
Add tokio to the dependencies in Cargo.toml:

[dependencies]
tokio = { version = "1.14.0", features = ["full"] }

Run:

RUST_BACKTRACE=1 RUSTFLAGS=$(rmc-rustc --rmc-flags) RUSTC=$(rmc-rustc --rmc-path) cargo build --target x86_64-unknown-linux-gnu -j1

with RMC version: 7d0d4cfc6da
I expected to see this happen: Verification successful

Instead, this happened:
thread 'rustc' panicked at 'called `Option::unwrap()` on a `None` value', compiler/rustc_codegen_rmc/src/codegen/typ.rs:1194:91
stack backtrace:
   0: rust_begin_unwind
             at /home/ubuntu/tools/rmc/library/std/src/panicking.rs:498:5
   1: core::panicking::panic_fmt
             at /home/ubuntu/tools/rmc/library/core/src/panicking.rs:107:14
   2: core::panicking::panic
             at /home/ubuntu/tools/rmc/library/core/src/panicking.rs:48:5
   3: <rustc_codegen_rmc::context::goto_ctx::GotocCtx>::fn_typ
   4: <rustc_codegen_rmc::context::goto_ctx::GotocCtx>::declare_function::{closure#0}
             at /home/ubuntu/tools/rmc/compiler/rustc_codegen_rmc/src/codegen/function.rs:194:17
   5: <rustc_codegen_rmc::context::goto_ctx::GotocCtx>::ensure::<<rustc_codegen_rmc::context::goto_ctx::GotocCtx>::declare_function::{closure#0}, &alloc::string::String>
             at /home/ubuntu/tools/rmc/compiler/rustc_codegen_rmc/src/context/goto_ctx.rs:135:23
   6: <rustc_codegen_rmc::context::goto_ctx::GotocCtx>::declare_function
             at /home/ubuntu/tools/rmc/compiler/rustc_codegen_rmc/src/codegen/function.rs:190:9
   7: <rustc_codegen_rmc::compiler_interface::GotocCodegenBackend as rustc_codegen_ssa::traits::backend::CodegenBackend>::codegen_crate::{closure#0}
             at /home/ubuntu/tools/rmc/compiler/rustc_codegen_rmc/src/compiler_interface.rs:80:35
   8: <rustc_codegen_rmc::context::goto_ctx::GotocCtx>::call_with_panic_debug_info::<<rustc_codegen_rmc::compiler_interface::GotocCodegenBackend as rustc_codegen_ssa::traits::backend::CodegenBackend>::codegen_crate::{closure#0}>::{closure#0}
             at /home/ubuntu/tools/rmc/compiler/rustc_codegen_rmc/src/utils/debug.rs:87:13
   9: <std::thread::local::LocalKey<core::cell::RefCell<(core::option::Option<alloc::string::String>, core::option::Option<cbmc::goto_program::location::Location>)>>>::try_with::<<rustc_codegen_rmc::context::goto_ctx::GotocCtx>::call_with_panic_debug_info<<rustc_codegen_rmc::compiler_interface::GotocCodegenBackend as rustc_codegen_ssa::traits::backend::CodegenBackend>::codegen_crate::{closure#0}>::{closure#0}, ()>
             at /home/ubuntu/tools/rmc/library/std/src/thread/local.rs:399:16
  10: <std::thread::local::LocalKey<core::cell::RefCell<(core::option::Option<alloc::string::String>, core::option::Option<cbmc::goto_program::location::Location>)>>>::with::<<rustc_codegen_rmc::context::goto_ctx::GotocCtx>::call_with_panic_debug_info<<rustc_codegen_rmc::compiler_interface::GotocCodegenBackend as rustc_codegen_ssa::traits::backend::CodegenBackend>::codegen_crate::{closure#0}>::{closure#0}, ()>
             at /home/ubuntu/tools/rmc/library/std/src/thread/local.rs:375:9
  11: <rustc_codegen_rmc::context::goto_ctx::GotocCtx>::call_with_panic_debug_info::<<rustc_codegen_rmc::compiler_interface::GotocCodegenBackend as rustc_codegen_ssa::traits::backend::CodegenBackend>::codegen_crate::{closure#0}>
             at /home/ubuntu/tools/rmc/compiler/rustc_codegen_rmc/src/utils/debug.rs:84:9
  12: <rustc_codegen_rmc::compiler_interface::GotocCodegenBackend as rustc_codegen_ssa::traits::backend::CodegenBackend>::codegen_crate
             at /home/ubuntu/tools/rmc/compiler/rustc_codegen_rmc/src/compiler_interface.rs:79:25
  13: rustc_interface::passes::start_codegen::{closure#0}
             at /home/ubuntu/tools/rmc/compiler/rustc_interface/src/passes.rs:1077:9
  14: <rustc_data_structures::profiling::VerboseTimingGuard>::run::<alloc::boxed::Box<dyn core::any::Any>, rustc_interface::passes::start_codegen::{closure#0}>
             at /home/ubuntu/tools/rmc/compiler/rustc_data_structures/src/profiling.rs:644:9
  15: <rustc_session::session::Session>::time::<alloc::boxed::Box<dyn core::any::Any>, rustc_interface::passes::start_codegen::{closure#0}>
             at /home/ubuntu/tools/rmc/compiler/rustc_session/src/utils.rs:16:9
  16: rustc_interface::passes::start_codegen
             at /home/ubuntu/tools/rmc/compiler/rustc_interface/src/passes.rs:1076:19
  17: <rustc_interface::queries::Queries>::ongoing_codegen::{closure#0}::{closure#0}
             at /home/ubuntu/tools/rmc/compiler/rustc_interface/src/queries.rs:254:20
  18: <rustc_interface::passes::QueryContext>::enter::<<rustc_interface::queries::Queries>::ongoing_codegen::{closure#0}::{closure#0}, core::result::Result<alloc::boxed::Box<dyn core::any::Any>, rustc_errors::ErrorReported>>::{closure#0}
             at /home/ubuntu/tools/rmc/compiler/rustc_interface/src/passes.rs:805:42
  19: rustc_middle::ty::context::tls::enter_context::<<rustc_interface::passes::QueryContext>::enter<<rustc_interface::queries::Queries>::ongoing_codegen::{closure#0}::{closure#0}, core::result::Result<alloc::boxed::Box<dyn core::any::Any>, rustc_errors::ErrorReported>>::{closure#0}, core::result::Result<alloc::boxed::Box<dyn core::any::Any>, rustc_errors::ErrorReported>>::{closure#0}
             at /home/ubuntu/tools/rmc/compiler/rustc_middle/src/ty/context.rs:1778:50
  20: rustc_middle::ty::context::tls::set_tlv::<rustc_middle::ty::context::tls::enter_context<<rustc_interface::passes::QueryContext>::enter<<rustc_interface::queries::Queries>::ongoing_codegen::{closure#0}::{closure#0}, core::result::Result<alloc::boxed::Box<dyn core::any::Any>, rustc_errors::ErrorReported>>::{closure#0}, core::result::Result<alloc::boxed::Box<dyn core::any::Any>, rustc_errors::ErrorReported>>::{closure#0}, core::result::Result<alloc::boxed::Box<dyn core::any::Any>, rustc_errors::ErrorReported>>
             at /home/ubuntu/tools/rmc/compiler/rustc_middle/src/ty/context.rs:1762:9
  21: rustc_middle::ty::context::tls::enter_context::<<rustc_interface::passes::QueryContext>::enter<<rustc_interface::queries::Queries>::ongoing_codegen::{closure#0}::{closure#0}, core::result::Result<alloc::boxed::Box<dyn core::any::Any>, rustc_errors::ErrorReported>>::{closure#0}, core::result::Result<alloc::boxed::Box<dyn core::any::Any>, rustc_errors::ErrorReported>>
             at /home/ubuntu/tools/rmc/compiler/rustc_middle/src/ty/context.rs:1778:9
  22: <rustc_interface::passes::QueryContext>::enter::<<rustc_interface::queries::Queries>::ongoing_codegen::{closure#0}::{closure#0}, core::result::Result<alloc::boxed::Box<dyn core::any::Any>, rustc_errors::ErrorReported>>
             at /home/ubuntu/tools/rmc/compiler/rustc_interface/src/passes.rs:805:9
  23: <rustc_interface::queries::Queries>::ongoing_codegen::{closure#0}
             at /home/ubuntu/tools/rmc/compiler/rustc_interface/src/queries.rs:245:13
  24: <rustc_interface::queries::Query<alloc::boxed::Box<dyn core::any::Any>>>::compute::<<rustc_interface::queries::Queries>::ongoing_codegen::{closure#0}>
             at /home/ubuntu/tools/rmc/compiler/rustc_interface/src/queries.rs:38:28
  25: rustc_driver::run_compiler::{closure#1}::{closure#2}
             at /home/ubuntu/tools/rmc/compiler/rustc_driver/src/lib.rs:409:13
  26: <rustc_interface::interface::Compiler>::enter::<rustc_driver::run_compiler::{closure#1}::{closure#2}, core::result::Result<core::option::Option<rustc_interface::queries::Linker>, rustc_errors::ErrorReported>>
             at /home/ubuntu/tools/rmc/compiler/rustc_interface/src/queries.rs:394:19
  27: rustc_driver::run_compiler::{closure#1}
             at /home/ubuntu/tools/rmc/compiler/rustc_driver/src/lib.rs:314:22
  28: rustc_interface::interface::create_compiler_and_run::<core::result::Result<(), rustc_errors::ErrorReported>, rustc_driver::run_compiler::{closure#1}>::{closure#1}
             at /home/ubuntu/tools/rmc/compiler/rustc_interface/src/interface.rs:220:13
  29: rustc_span::with_source_map::<core::result::Result<(), rustc_errors::ErrorReported>, rustc_interface::interface::create_compiler_and_run<core::result::Result<(), rustc_errors::ErrorReported>, rustc_driver::run_compiler::{closure#1}>::{closure#1}>
             at /home/ubuntu/tools/rmc/compiler/rustc_span/src/lib.rs:971:5
  30: rustc_interface::interface::create_compiler_and_run::<core::result::Result<(), rustc_errors::ErrorReported>, rustc_driver::run_compiler::{closure#1}>
             at /home/ubuntu/tools/rmc/compiler/rustc_interface/src/interface.rs:214:5
  31: rustc_interface::interface::run_compiler::<core::result::Result<(), rustc_errors::ErrorReported>, rustc_driver::run_compiler::{closure#1}>::{closure#0}
             at /home/ubuntu/tools/rmc/compiler/rustc_interface/src/interface.rs:236:12
  32: rustc_interface::util::setup_callbacks_and_run_in_thread_pool_with_globals::<rustc_interface::interface::run_compiler<core::result::Result<(), rustc_errors::ErrorReported>, rustc_driver::run_compiler::{closure#1}>::{closure#0}, core::result::Result<(), rustc_errors::ErrorReported>>::{closure#0}::{closure#0}
             at /home/ubuntu/tools/rmc/compiler/rustc_interface/src/util.rs:145:13
  33: <scoped_tls::ScopedKey<rustc_span::SessionGlobals>>::set::<rustc_interface::util::setup_callbacks_and_run_in_thread_pool_with_globals<rustc_interface::interface::run_compiler<core::result::Result<(), rustc_errors::ErrorReported>, rustc_driver::run_compiler::{closure#1}>::{closure#0}, core::result::Result<(), rustc_errors::ErrorReported>>::{closure#0}::{closure#0}, core::result::Result<(), rustc_errors::ErrorReported>>
             at /home/ubuntu/.cargo/registry/src/github.com-1ecc6299db9ec823/scoped-tls-1.0.0/src/lib.rs:137:9
  34: rustc_span::create_session_globals_then::<core::result::Result<(), rustc_errors::ErrorReported>, rustc_interface::util::setup_callbacks_and_run_in_thread_pool_with_globals<rustc_interface::interface::run_compiler<core::result::Result<(), rustc_errors::ErrorReported>, rustc_driver::run_compiler::{closure#1}>::{closure#0}, core::result::Result<(), rustc_errors::ErrorReported>>::{closure#0}::{closure#0}>
             at /home/ubuntu/tools/rmc/compiler/rustc_span/src/lib.rs:109:5
  35: rustc_interface::util::setup_callbacks_and_run_in_thread_pool_with_globals::<rustc_interface::interface::run_compiler<core::result::Result<(), rustc_errors::ErrorReported>, rustc_driver::run_compiler::{closure#1}>::{closure#0}, core::result::Result<(), rustc_errors::ErrorReported>>::{closure#0}
             at /home/ubuntu/tools/rmc/compiler/rustc_interface/src/util.rs:143:9
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.

error: internal compiler error: unexpected panic

note: the compiler unexpectedly panicked. this is a bug.

note: we would appreciate a bug report: https://github.com/rust-lang/rust/issues/new?labels=C-bug%2C+I-ICE%2C+T-compiler&template=ice.md

note: rustc 1.59.0-dev running on x86_64-unknown-linux-gnu

note: compiler flags: -Z codegen-backend=gotoc -Z trim-diagnostic-paths=no -Z human_readable_cgu_names -C embed-bitcode=no -C debuginfo=2 -C overflow-checks=on --crate-type lib

note: some of the compiler flags provided by cargo are hidden

query stack during panic:
end of query stack

[RMC] current codegen item: declare_function: sync::watch::Receiver::<T>::changed::{closure#0}
[RMC] current codegen location: Loc { file: "/home/ubuntu/.cargo/registry/src/github.com-1ecc6299db9ec823/tokio-1.14.0/src/sync/watch.rs", function: None, line: 360, col: Some(69) }

RMC unexpectedly panicked during code generation.

If you are seeing this message, please file an issue here instead of on the Rust compiler: https://github.com/model-checking/rmc/issues/new?labels=bug&template=bug_report.md
error: could not compile `tokio`

With af11d38d93a, the panic is not reproducible. However, cargo kani --only-codegen produces the following errors:
error[E0382]: borrow of moved value: `subsys.base`
   --> /home/ubuntu/.cargo/registry/src/github.com-1ecc6299db9ec823/num_cpus-1.13.1/src/linux.rs:177:45
    |
174 |             subsys.base, mntinfo.root, mntinfo.mount_point
    |             ----------- value moved here
...
177 |         let rel_from_root = some!(Path::new(&subsys.base).strip_prefix(&mntinfo.root).ok());
    |                                             ^^^^^^^^^^^^ value borrowed here after move
    |
    = note: move occurs because `subsys.base` has type `std::string::String`, which does not implement the `Copy` trait

error[E0382]: borrow of moved value: `mntinfo.root`
   --> /home/ubuntu/.cargo/registry/src/github.com-1ecc6299db9ec823/num_cpus-1.13.1/src/linux.rs:177:72
    |
174 |             subsys.base, mntinfo.root, mntinfo.mount_point
    |                          ------------ value moved here
...
177 |         let rel_from_root = some!(Path::new(&subsys.base).strip_prefix(&mntinfo.root).ok());
    |                                                                        ^^^^^^^^^^^^^ value borrowed here after move
    |
    = note: move occurs because `mntinfo.root` has type `std::string::String`, which does not implement the `Copy` trait

error[E0382]: use of moved value: `mntinfo.mount_point`
   --> /home/ubuntu/.cargo/registry/src/github.com-1ecc6299db9ec823/num_cpus-1.13.1/src/linux.rs:182:38
    |
174 |             subsys.base, mntinfo.root, mntinfo.mount_point
    |                                        ------------------- value moved here
...
182 |         let mut path = PathBuf::from(mntinfo.mount_point);
    |                                      ^^^^^^^^^^^^^^^^^^^ value used here after move
    |
    = note: move occurs because `mntinfo.mount_point` has type `std::string::String`, which does not implement the `Copy` trait

For more information about this error, try `rustc --explain E0382`.
error: could not compile `num_cpus` due to 3 previous errors

The errors are not reproducible with cargo build or cargo +nightly-2022-03-09-x86_64-unknown-linux-gnu build.

With the fix in #1061, this now panics with:
thread 'rustc' panicked at 'not yet implemented: [static generator@/home/ubuntu/.cargo/registry/src/github.com-1ecc6299db9ec823/tokio-1.17.0/src/sync/watch.rs:453:69: 467:6] Generator(DefId(0:12852 ~ tokio[9b1b]::sync::watch::{impl#0}::changed::{closure#0}), [(), std::future::ResumeTy, (), std::result::Result<(), sync::watch::error::RecvError>, for<'r, 's> {std::future::ResumeTy, &'r mut sync::watch::Receiver<()>, sync::notify::Notified<'s>, ()}, (&mut sync::watch::Receiver<()>,)], Static)', src/kani-compiler/src/codegen_cprover_gotoc/codegen/typ.rs:833:39
stack backtrace:
   0: rust_begin_unwind
             at /rustc/5f37001055c29982f4c27ee9edd90449c8e07774/library/std/src/panicking.rs:584:5
   1: core::panicking::panic_fmt
             at /rustc/5f37001055c29982f4c27ee9edd90449c8e07774/library/core/src/panicking.rs:143:14
   2: kani_compiler::codegen_cprover_gotoc::codegen::typ::<impl kani_compiler::codegen_cprover_gotoc::context::goto_ctx::GotocCtx>::codegen_ty_ref
             at /home/ubuntu/git/kani/src/kani-compiler/src/codegen_cprover_gotoc/codegen/typ.rs:833:39
   3: kani_compiler::codegen_cprover_gotoc::codegen::typ::<impl kani_compiler::codegen_cprover_gotoc::context::goto_ctx::GotocCtx>::codegen_ty_inner
             at /home/ubuntu/git/kani/src/kani-compiler/src/codegen_cprover_gotoc/codegen/typ.rs:547:76
   4: kani_compiler::codegen_cprover_gotoc::codegen::typ::<impl kani_compiler::codegen_cprover_gotoc::context::goto_ctx::GotocCtx>::codegen_ty
             at /home/ubuntu/git/kani/src/kani-compiler/src/codegen_cprover_gotoc/codegen/typ.rs:484:24
   5: kani_compiler::codegen_cprover_gotoc::codegen::typ::<impl kani_compiler::codegen_cprover_gotoc::context::goto_ctx::GotocCtx>::codegen_struct_fields
             at /home/ubuntu/git/kani/src/kani-compiler/src/codegen_cprover_gotoc/codegen/typ.rs:671:74
   6: kani_compiler::codegen_cprover_gotoc::codegen::typ::<impl kani_compiler::codegen_cprover_gotoc::context::goto_ctx::GotocCtx>::codegen_variant_struct_fields
             at /home/ubuntu/git/kani/src/kani-compiler/src/codegen_cprover_gotoc/codegen/typ.rs:921:9
   7: kani_compiler::codegen_cprover_gotoc::codegen::typ::<impl kani_compiler::codegen_cprover_gotoc::context::goto_ctx::GotocCtx>::codegen_struct::{{closure}}
             at /home/ubuntu/git/kani/src/kani-compiler/src/codegen_cprover_gotoc/codegen/typ.rs:907:13
   8: kani_compiler::codegen_cprover_gotoc::context::goto_ctx::GotocCtx::ensure_struct
             at /home/ubuntu/git/kani/src/kani-compiler/src/codegen_cprover_gotoc/context/goto_ctx.rs:222:30
   9: kani_compiler::codegen_cprover_gotoc::codegen::typ::<impl kani_compiler::codegen_cprover_gotoc::context::goto_ctx::GotocCtx>::codegen_struct
             at /home/ubuntu/git/kani/src/kani-compiler/src/codegen_cprover_gotoc/codegen/typ.rs:904:9
  10: kani_compiler::codegen_cprover_gotoc::codegen::typ::<impl kani_compiler::codegen_cprover_gotoc::context::goto_ctx::GotocCtx>::codegen_ty_inner
             at /home/ubuntu/git/kani/src/kani-compiler/src/codegen_cprover_gotoc/codegen/typ.rs:507:21
  11: kani_compiler::codegen_cprover_gotoc::codegen::typ::<impl kani_compiler::codegen_cprover_gotoc::context::goto_ctx::GotocCtx>::codegen_ty
             at /home/ubuntu/git/kani/src/kani-compiler/src/codegen_cprover_gotoc/codegen/typ.rs:484:24
  12: kani_compiler::codegen_cprover_gotoc::codegen::typ::<impl kani_compiler::codegen_cprover_gotoc::context::goto_ctx::GotocCtx>::fn_typ
             at /home/ubuntu/git/kani/src/kani-compiler/src/codegen_cprover_gotoc/codegen/typ.rs:1240:32
  13: kani_compiler::codegen_cprover_gotoc::codegen::function::<impl kani_compiler::codegen_cprover_gotoc::context::goto_ctx::GotocCtx>::declare_function::{{closure}}
             at /home/ubuntu/git/kani/src/kani-compiler/src/codegen_cprover_gotoc/codegen/function.rs:232:17
  14: kani_compiler::codegen_cprover_gotoc::context::goto_ctx::GotocCtx::ensure
             at /home/ubuntu/git/kani/src/kani-compiler/src/codegen_cprover_gotoc/context/goto_ctx.rs:165:23
  15: kani_compiler::codegen_cprover_gotoc::codegen::function::<impl kani_compiler::codegen_cprover_gotoc::context::goto_ctx::GotocCtx>::declare_function
             at /home/ubuntu/git/kani/src/kani-compiler/src/codegen_cprover_gotoc/codegen/function.rs:228:9
  16: <kani_compiler::codegen_cprover_gotoc::compiler_interface::GotocCodegenBackend as rustc_codegen_ssa::traits::backend::CodegenBackend>::codegen_crate::{{closure}}
             at /home/ubuntu/git/kani/src/kani-compiler/src/codegen_cprover_gotoc/compiler_interface.rs:72:35
  17: kani_compiler::codegen_cprover_gotoc::utils::debug::<impl kani_compiler::codegen_cprover_gotoc::context::goto_ctx::GotocCtx>::call_with_panic_debug_info::{{closure}}
             at /home/ubuntu/git/kani/src/kani-compiler/src/codegen_cprover_gotoc/utils/debug.rs:67:13
  18: std::thread::local::LocalKey<T>::try_with
             at /rustc/5f37001055c29982f4c27ee9edd90449c8e07774/library/std/src/thread/local.rs:442:16
  19: std::thread::local::LocalKey<T>::with
             at /rustc/5f37001055c29982f4c27ee9edd90449c8e07774/library/std/src/thread/local.rs:418:9
  20: kani_compiler::codegen_cprover_gotoc::utils::debug::<impl kani_compiler::codegen_cprover_gotoc::context::goto_ctx::GotocCtx>::call_with_panic_debug_info
             at /home/ubuntu/git/kani/src/kani-compiler/src/codegen_cprover_gotoc/utils/debug.rs:64:9
  21: <kani_compiler::codegen_cprover_gotoc::compiler_interface::GotocCodegenBackend as rustc_codegen_ssa::traits::backend::CodegenBackend>::codegen_crate
             at /home/ubuntu/git/kani/src/kani-compiler/src/codegen_cprover_gotoc/compiler_interface.rs:71:25
  22: <rustc_session::session::Session>::time::<alloc::boxed::Box<dyn core::any::Any>, rustc_interface::passes::start_codegen::{closure#0}>
  23: <rustc_interface::passes::QueryContext>::enter::<<rustc_interface::queries::Queries>::ongoing_codegen::{closure#0}::{closure#0}, core::result::Result<alloc::boxed::Box<dyn core::any::Any>, rustc_errors::ErrorGuaranteed>>
  24: <rustc_interface::queries::Queries>::ongoing_codegen
  25: <rustc_interface::interface::Compiler>::enter::<rustc_driver::run_compiler::{closure#1}::{closure#2}, core::result::Result<core::option::Option<rustc_interface::queries::Linker>, rustc_errors::ErrorGuaranteed>>
  26: rustc_span::with_source_map::<core::result::Result<(), rustc_errors::ErrorGuaranteed>, rustc_interface::interface::create_compiler_and_run<core::result::Result<(), rustc_errors::ErrorGuaranteed>, rustc_driver::run_compiler::{closure#1}>::{closure#1}>
  27: rustc_interface::interface::create_compiler_and_run::<core::result::Result<(), rustc_errors::ErrorGuaranteed>, rustc_driver::run_compiler::{closure#1}>
  28: <scoped_tls::ScopedKey<rustc_span::SessionGlobals>>::set::<rustc_interface::interface::run_compiler<core::result::Result<(), rustc_errors::ErrorGuaranteed>, rustc_driver::run_compiler::{closure#1}>::{closure#0}, core::result::Result<(), rustc_errors::ErrorGuaranteed>>
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.

Kani unexpectedly panicked during compilation.
If you are seeing this message, please file an issue here: https://github.com/model-checking/kani/issues/new?labels=bug&template=bug_report.md

[Kani] current codegen item: declare_function: std::pin::Pin::<&'a mut T>::map_unchecked_mut
[Kani] current codegen location: Loc { file: "/home/ubuntu/.rustup/toolchains/nightly-2022-03-23-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/core/src/pin.rs", function: None, line: 788, col: Some(5) }
error: could not compile `tokio`

As of 7cc65683e9a, the panic now has this signature (omitting the rustc lines):
thread 'rustc' panicked at 'Expected self type to be a trait', kani-compiler/src/codegen_cprover_gotoc/codegen/typ.rs:924:21
stack backtrace:
   2: kani_compiler::codegen_cprover_gotoc::codegen::typ::<impl kani_compiler::codegen_cprover_gotoc::context::goto_ctx::GotocCtx>::codegen_dynamic_function_sig::{{closure}}
             at /home/ubuntu/git/kani/kani-compiler/src/codegen_cprover_gotoc/codegen/typ.rs:924:21
  10: kani_compiler::codegen_cprover_gotoc::codegen::typ::<impl kani_compiler::codegen_cprover_gotoc::context::goto_ctx::GotocCtx>::codegen_dynamic_function_sig
             at /home/ubuntu/git/kani/kani-compiler/src/codegen_cprover_gotoc/codegen/typ.rs:915:22
  11: kani_compiler::codegen_cprover_gotoc::codegen::typ::<impl kani_compiler::codegen_cprover_gotoc::context::goto_ctx::GotocCtx>::trait_method_vtable_field_type
             at /home/ubuntu/git/kani/kani-compiler/src/codegen_cprover_gotoc/codegen/typ.rs:299:21
  12: kani_compiler::codegen_cprover_gotoc::codegen::typ::<impl kani_compiler::codegen_cprover_gotoc::context::goto_ctx::GotocCtx>::trait_vtable_field_types::{{closure}}
             at /home/ubuntu/git/kani/kani-compiler/src/codegen_cprover_gotoc/codegen/typ.rs:424:34
  26: kani_compiler::codegen_cprover_gotoc::codegen::typ::<impl kani_compiler::codegen_cprover_gotoc::context::goto_ctx::GotocCtx>::trait_vtable_field_types
             at /home/ubuntu/git/kani/kani-compiler/src/codegen_cprover_gotoc/codegen/typ.rs:416:32
  27: kani_compiler::codegen_cprover_gotoc::codegen::typ::<impl kani_compiler::codegen_cprover_gotoc::context::goto_ctx::GotocCtx>::codegen_trait_vtable_type::{{closure}}
             at /home/ubuntu/git/kani/kani-compiler/src/codegen_cprover_gotoc/codegen/typ.rs:319:13
  28: kani_compiler::codegen_cprover_gotoc::context::goto_ctx::GotocCtx::ensure_struct
             at /home/ubuntu/git/kani/kani-compiler/src/codegen_cprover_gotoc/context/goto_ctx.rs:225:30
  29: kani_compiler::codegen_cprover_gotoc::codegen::typ::<impl kani_compiler::codegen_cprover_gotoc::context::goto_ctx::GotocCtx>::codegen_trait_vtable_type
             at /home/ubuntu/git/kani/kani-compiler/src/codegen_cprover_gotoc/codegen/typ.rs:318:9
  30: kani_compiler::codegen_cprover_gotoc::codegen::typ::<impl kani_compiler::codegen_cprover_gotoc::context::goto_ctx::GotocCtx>::codegen_fat_ptr
             at /home/ubuntu/git/kani/kani-compiler/src/codegen_cprover_gotoc/codegen/typ.rs:844:13
  31: kani_compiler::codegen_cprover_gotoc::codegen::typ::<impl kani_compiler::codegen_cprover_gotoc::context::goto_ctx::GotocCtx>::codegen_ty_ref
             at /home/ubuntu/git/kani/kani-compiler/src/codegen_cprover_gotoc/codegen/typ.rs:860:20
  32: kani_compiler::codegen_cprover_gotoc::codegen::typ::<impl kani_compiler::codegen_cprover_gotoc::context::goto_ctx::GotocCtx>::codegen_ty_inner
             at /home/ubuntu/git/kani/kani-compiler/src/codegen_cprover_gotoc/codegen/typ.rs:604:76
  33: kani_compiler::codegen_cprover_gotoc::codegen::typ::<impl kani_compiler::codegen_cprover_gotoc::context::goto_ctx::GotocCtx>::codegen_ty
             at /home/ubuntu/git/kani/kani-compiler/src/codegen_cprover_gotoc/codegen/typ.rs:537:24

This suggests things are working now?
$ cargo new tokio-test
     Created binary (application) `tokio-test` package
$ cd tokio-test/
$ cargo add tokio --features full
    Updating crates.io index
      Adding tokio v1.20.1 to dependencies.
$ cargo kani
   Compiling libc v0.2.132
   Compiling proc-macro2 v1.0.43
   Compiling quote v1.0.21
   Compiling cfg-if v1.0.0
   Compiling unicode-ident v1.0.3
   Compiling log v0.4.17
   Compiling parking_lot_core v0.9.3
   Compiling syn v1.0.99
   Compiling smallvec v1.9.0
   Compiling memchr v2.5.0
   Compiling scopeguard v1.1.0
   Compiling once_cell v1.13.1
   Compiling bytes v1.2.1
   Compiling lock_api v0.4.7
   Compiling tokio v1.20.1
   Compiling socket2 v0.4.6
   Compiling num_cpus v1.13.1
   Compiling mio v0.8.4
   Compiling signal-hook-registry v1.4.0
   Compiling parking_lot v0.12.1
   Compiling tokio-macros v1.8.0
   Compiling tokio-test v0.1.0 (/home/ubuntu/experiments/specific_crate_failures/tokio-test)
    Finished dev [unoptimized + debuginfo] target(s) in 1m 00s
Error: No proof harnesses (functions with #[kani::proof]) were found to verify.

Perhaps we can close this one.

Confirmed. Closing it.

authors: tedinski zhassan-aws

repo: model-checking/kani


text:
Guess value for thermodynamicstate.X

Reported by filip.jorissen on 10 Jun 2014 16:55 UTC
I have a model where 'X[2]' of a moist air was chosen by Dymola as the iteration variable of a nonlinear system of equations. The default guess value is 0, which causes an error:
The following error was detected at time: 0

Model error - power: (r1) ** (n[1]) = (-3.83338) ** (-1.5)

The stack of functions is:
Buildings.Media.PerfectGases.MoistAir.sublimationPressureIce
Buildings.Media.PerfectGases.MoistAir.saturationPressure
Buildings.Media.GasesPTDecoupled.MoistAir.T_phX
Buildings.Media.GasesPTDecoupled.MoistAir.T_phX(menergaAdsolair.heating.state_a1_inflow.p, menergaAdsolair.filter.port_b.h_outflow, menergaAdsolair.filter.port_b.Xi_outflow)
First evaluation failed for non-linear solver.

etc etc

ERROR: Failed to solve non-linear system using Newton solver.
To get more information: Turn on Simulation/Setup/Debug/Nonlinear solver diagnostics/Details
Solution to systems of equations not found at time = 0
   Nonlinear system of equations number = 15
   Failed to evaluate any residual. Try to give better start-values.
   Iteration is not making good progress.
   Accumulated number of residue calculations: 4
   Last values of solution vector:
menergaAdsolair.heating.state_a1_inflow.X[2] = 1E-09
menergaAdsolair.thermostatic3WayValve.k = 0.5
menergaAdsolair.filter.port_b.h_outflow = 45301
Error: could not solve simplified initialization for homotopy method.
Error: could not solve simplified initialization for homotopy method.
Error: Failed to start model.

I solved this by setting the initial guess value for ThermodynamicState.X equal to reference_X. I suggest to implement this by default in MSL and possibly also for p, T and h.
The hotfix for my own package was:
redeclare record extends ThermodynamicState(X(start=reference_X))
  "ThermodynamicState record for moist air"
end ThermodynamicState;

Migrated-From: https://trac.modelica.org/Modelica/ticket/1509

Comment by hubertus on 10 Jun 2014 17:55 UTC
Thanks for the report, this is actually the intention of the variable reference_X. I am not sure whether it shoudl be set int the library though: the problem is that the mere existence of a value for the start attribute influences a number of algorithms (e.g. state selection, afaik at least in some tools), so that there can be unintended consequences from adding it. I'll think a bit about this and might introduce your fix.
For that matter: it would probably be nicer if setting start values would have no other effects than exactly setting a start value. In that case, the fix shoudl of course be applied

Comment by fcasella on 31 Aug 2015 11:24 UTC
I got a similar request on Stackoverflow (http://stackoverflow.com/questions/31644258/fluidport-connector-with-start-values-for-composition) which suggests adding reference_X as a default start value for connector variables.
In fact, a better choice would be to add start = reference_X to MassFraction type definition of the medium, which would cover all the cases at once.
I am also unsure that this might trigger negative consequences on existing models. Maybe it would be worth trying on the existing testuites. What do you think?

Comment by hubertus on 12 Dec 2015 22:53 UTC
Francesco, your ideas does not work because the mass fraction type is not a vector. It maybe should be and should be used, but that would not be an allowed change for a minor version number update.

Comment by hubertus on 12 Dec 2015 23:03 UTC
Fixed in trunk in 67ba73b85115cf06cc6707d83b8dd1c55253335a

Changelog modified by hubertus on 12 Dec 2015 23:03 UTC
Fixes missing start value for composition vector in ThermodynamicState

Modified by beutlich on 13 Dec 2015 08:26 UTC

Changelog modified by beutlich on 13 Dec 2015 08:26 UTC
Fixed missing start value for composition vector in ThermodynamicState

Comment by fcasella on 14 Dec 2015 13:55 UTC
Replying to [comment:3 hubertus]:

Francesco, your ideas does not work because the mass fraction type is not a vector. It maybe should be and should be used, but that would not be an allowed change for a minor version number update.

You're right, I overlooked this.

repo: modelica/Modelica


text:
Failed mapping of inheritance hierarchy in two different object model

Hi,
I have studied the inheritance example and was able to run it successfully.
However, I have a different case which does not seem to work.
I reused all the BaseDest.java, BaseDestA.java, BaseDestB.java, BaseSrc.java, BaseSrcA.java, BaseSrc.B.java except for changing BaseDest.java and BaseSrc.java to be abstract class. I ran the inheritance example, and it still worked fine.
Now, for my case, I create
ObjectContainer.java with a
private BaseSrc instance
ObjectContainer2.java with a
private BaseDesc instance
For the test class,
I did the following:
ObjectContainer oc = new ObjectContainer();
BaseSrc srcA = new BaseSrcA();
// Note, I had to add a setter method and really need to call it before modelmapper was invoked.
srcA.setaString("testA");
oc.setInstance(srcA);

with the same type mapping code,
Now,
ObjectContainer2 oc2 = modelMapper.map( oc, ObjectContainer2.class);

It throwed out exception:
1) Failed to instantiate instance of destination com.test.BaseDest. Ensure that com.test.BaseDest has a non-private no-argument constructor.

Also note that the type mapping was not actually invoked (I added debug code)
If I redefine the BaseDest so that it is not abstract class, the exception is gone, but the instance is not mapped to the sub type (BaseDestA).
I created this simpler test case to show that modelmapper does not work well in this type of scenario. I actually identified this issue in a more complex scenario, and just want to use a simpler model to clarify the problem.
I am hoping there is a different way to configure modelmapper in order to allow subtype mapping properly.
Thanks,
Wayne

Note: the only difference between my case and the example from source code is the container in my case has one instance defined super type while the container in the example has a List of instance defined as super type.
I actually changed my Container to have a list of instances defined as super type, and the type mapping code was invoked too.
This seems to be a bug that happened when there is only one instance defined as super type.

I pulled the master branch (2.2.1) and tested with both of the following configurations. However, the issue remains. As I indicated before, the issue will be resolved if the ObjectContainer.java has a List instead of one instance of BaseSrc. If the ObjectContainer had only one instance of BaseSrc, then the typemapping would not be invoked, and modelmapper will try to create an instance of super type BaseDest, insteader of BaseDestA.
(1) Your recommended method
modelMapper.typeMap(BaseSrcA.class, BaseDestA.class).include(BaseDest.class)
or
(2) method in the inheritance example
TypeMap<BaseSrc, BaseDest> typeMap = modelMapper.createTypeMap( BaseSrc.class, BaseDest.class )
.include( BaseSrcA.class, BaseDestA.class )
.include( BaseSrcB.class, BaseDestB.class );
The error:
Exception in thread "main" org.modelmapper.MappingException: ModelMapper mapping errors:

Failed to instantiate instance of destination com.test.BaseDest. Ensure that com.test.BaseDest has a non-private no-argument constructor.

1 error
at org.modelmapper.internal.Errors.throwMappingExceptionIfErrorsExist(Errors.java:380)
at org.modelmapper.internal.MappingEngineImpl.map(MappingEngineImpl.java:84)
at org.modelmapper.ModelMapper.mapInternal(ModelMapper.java:576)
at org.modelmapper.ModelMapper.map(ModelMapper.java:407)

I would like to share one piece of information I identified:
When I add some debug message to the method of MappingEngineImpl.java (public <S, D> D map(MappingContext<S, D> context) {...})
I can see the following message when I test the inheritance example code:
converter: org.modelmapper.internal.converter.CollectionConverter
Basically this converter was invoked. Then the typemapping configuration was invoked.
When I test my test case where it is not a array of super type, this message was not found, and the typemapping configuration was NOT invoked, and it tried to find a non argument non private constructor of super type

Thanks for this report. I can reproduce this bug and I will fix it.

any news on this issue ?

I got the same issue. Any news?

I am also experiencing this issue, in the following scenario:
`AbstractEntity {
A a;
}
Entity extends AbstractEntity {
B b;
}
Container {
Entity entity;
}
EntityDTO {
A a;
B b;
}
ContainerDTO {
EntityDTO entityDTO;
}`
I've compressed the logic in the following method:
`private static Container convert(final ContainerDTO containerDTO) {
final ModelMapper containerMapper = new ModelMapper();
final TypeMap<ContainerDTO, Container> containerTypeMap =
    containerMapper.createTypeMap(ContainerDTO.class, Container.class);

final ModelMapper contentMapper = new ModelMapper();
contentMapper.createTypeMap(EntityDTO.class, Entity.class);

containerTypeMap.addMappings(m -> m.using(
    ctx -> contentMapper.map(ctx.getSource(), Entity.class)
).map(ContainerDTO::getEntityDTO, Container::setEntity));

return containerMapper.map(containerDTO, Container.class); // ERROR

}`
Which gives the following error:
`...
Caused by: org.modelmapper.MappingException: ModelMapper mapping errors:

Failed to instantiate instance of destination AbstractEntity. Ensure that AbstractEntity has a non-private no-argument constructor.`

Is this a known problem?
Am I missing something?

repo: modelmapper/modelmapper


text:
🛑 Zeichen gegen Mobbing e. V. is down

In 18abede, Zeichen gegen Mobbing e. V. (https://zeichen-gegen-mobbing.de) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Zeichen gegen Mobbing e. V. is back up in 3f1e39c after 13 minutes.

repo: modelrailroader/status-upptime-jh


text:
add resource limiter

Add resource limiter module
Description
This PR adds a resource limiter module that limits the number of concurrent executions of a function based on available resources using Redis.
Changes

Added resource_limiter.py which includes the resources_limit decorator and helper functions.
Implemented Redis-based resource counting and queuing mechanisms.
Added a simulation/test script within the module.

How to test

Set up a Redis server and configure the REDIS_HOST, REDIS_PORT, and REDIS_DB environment variables.
Run the script and follow the prompts to test the resource limiter.

Notes

The module uses redis libraries, ensure they are installed in your environment.

TODO
Add a timeout for the function call.
Checklist
Please check the following items before code is ready to be reviewed.

[X]  Code has passed all tests
[X]  Docstrings have been added/updated in Google Style
[X]  Documentation has been updated
[X]  Code is ready for review

Why do we need to support redis here?

authors: DavdGao rayrayraykk

repo: modelscope/agentscope


text:
1.20.0版本代码增加了import yaml，却没有更新依赖列表

Checklist

[x]  I have searched the tutorial on modelscope  doc-site
[x]  I have searched related issues but cannot get the expected help.
[x]  The bug has not been fixed in the latest version.

Describe the bug
安装modelscope之后直接使用snapshot_download时提示缺少依赖
Traceback (most recent call last):
  File "/Users/myhloli/PycharmProjects/pythonProject/.venv/lib/python3.10/site-packages/modelscope/utils/import_utils.py", line 451, in _get_module
    return importlib.import_module('.' + module_name, self.__name__)
  File "/Library/Frameworks/Python.framework/Versions/3.10/lib/python3.10/importlib/__init__.py", line 126, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
  File "<frozen importlib._bootstrap>", line 1050, in _gcd_import
  File "<frozen importlib._bootstrap>", line 1027, in _find_and_load
  File "<frozen importlib._bootstrap>", line 1006, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 688, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 883, in exec_module
  File "<frozen importlib._bootstrap>", line 241, in _call_with_frames_removed
  File "/Users/myhloli/PycharmProjects/pythonProject/.venv/lib/python3.10/site-packages/modelscope/fileio/io.py", line 8, in <module>
    from .format import JsonHandler, YamlHandler
  File "/Users/myhloli/PycharmProjects/pythonProject/.venv/lib/python3.10/site-packages/modelscope/fileio/format/__init__.py", line 5, in <module>
    from .yaml import YamlHandler
  File "/Users/myhloli/PycharmProjects/pythonProject/.venv/lib/python3.10/site-packages/modelscope/fileio/format/yaml.py", line 2, in <module>
    import yaml
ModuleNotFoundError: No module named 'yaml'

To Reproduce

What command or script did you run?

pip install modelscope
python3
from modelscope import snapshot_download

Your Environments (required)

OS: Darwin Mac-mini.local 22.6.0 Darwin Kernel Version 22.6.0: Mon Apr 22 20:54:28 PDT 2024; root:xnu-8796.141.3.705.2~1/RELEASE_X86_64 x86_64
CPU: 2 GHz 四核Intel Core i7
Commit id (master)

Model hub related: @liuyhwangyh @tastelikefeet @wangxingjun778

thanks, we are looking into this issue.

authors: myhloli yingdachen

repo: modelscope/modelscope


text:
Easy way to bind IMemoryPool?

I want to bind memory pools as interfaces so they can easily be stubbed out in unit tests. How can I achieve something like below?
[Inject]
IMemoryPool<IFoo> fooPool;

You can do this by supplying an extra generic argument to the bind statement with the class/interface that you want to use for the contract.  For example:
public class Foo
{
    public class Pool : MemoryPool<Foo>
    {
    }
}

public class FooInstaller : MonoInstaller<FooInstaller>
{
    public override void InstallBindings()
    {
        Container.BindMemoryPool<Foo, Foo.Pool, IMemoryPool<Foo>>();
    }
}

Then any injected members with type IMemoryPool<Foo> will get your memory pool

Thanks for your response. That's one solution but is it possible to bind it to an interface of IMemoryPool<IFoo>?

Yes, you can bind an interface too.  You mean like this?
    public class Foo
    {
        public class Pool : MemoryPool<Foo>, IMyPool
        {
        }
    }

    public interface IMyPool : IMemoryPool<Foo>
    {
    }

    public class FooInstaller : MonoInstaller<FooInstaller>
    {
        public override void InstallBindings()
        {
            Container.BindMemoryPool<Foo, Foo.Pool, IMyPool>();
        }
    }

That works, thanks.

authors: bendangelo svermeulen

repo: modesttree/Zenject


text:
DataFrame unable to apply a function that calling itself

System information

OS Platform and Distribution: Windows 10 1909
Modin version (modin.__version__): 0.7.2
Python version: 3.7.4, Pandas Version: 1.0.1
Code we can use to reproduce:

df.timeoffset.apply(lambda x:df.index.slice_indexer(x,x+60))

Literally the df looks like this, where df.index is the same as df.timeoffset
| timeoffset | data | data | data
-- | -- | -- | -- | --
5400  | 5400 | 29200 | 29.25 | 4600
5403  | 5403 | 93900 | 29.27 | 400
5406  | 5406 | 2200 | 29.24 | 1100
.. | ...   . | ... | ... | ...
25005 | 25005 | 15500 | 29.57 | 7700
25008 | 25008 | 15500 | 29.61 | 9400
25011 | 25011 | 11500 | 29.61 | 14400
Describe the problem
I'm trying to create some rolling windows according to df.timeoffset, and obtain the index of these rolling windows.
But it won't work except giving me the following log output.
Source code / logs
UserWarning: `DataFrame.__getstate__` defaulting to pandas implementation.
To request implementation, send an email to feature_requests@modin.org.
distributed.nanny - WARNING - Restarting worker
distributed.nanny - WARNING - Restarting worker
distributed.nanny - WARNING - Restarting worker
...(Won't stop until I manually interrupt it)

I'm think there's nothing wrong with df.index.slice_indexer or df.apply,
So I guess the problem is that, the df itself was called again within the apply lambda function.

BTW, the Modin implementation of  pd.read_table() function is really nice, reducing the running time by 65% on i7-9750h (6 cores).
Thanks for creating this wonderful toolkit.

Hi @Michany, thanks for the report.
The problem here is that accessing the df from within the apply function is attempting to pickle the entire dataframe, which isn't supported (#672). We do plan on allowing this, but there are challenges with allowing each partition to interact with the entire dataframe. This is where the __getstate__ comes in.
One workaround for your case using functionality that is implemented (until we can get the functionality you need implemented):
df[["timeoffset"]].apply(lambda x: x.apply(lambda z: x.index.slice_indexer(z, z+60))).squeeze()

Since you only need the index values, we can use the DataFrame.apply method to call the Series.apply. It'll unfortunately have limited parallelism, but it will be better than defaulting to pandas or throwing an error. apply is very challenging, and we are constantly iterating on it. pandas allows nearly unbounded functions to be passed in, so we are constantly trying to improve. The next step is inspecting the user's function and calculating parallelism and optimization based on that. That will take some time to implement and test.

Thanks, this actually works! Hope to see more features coming.

authors: Michany devin-petersohn

repo: modin-project/modin


text:
Series.pop() doesn`t work correctly at MODIN_STORAGE_FORMAT=omnisci

When I run:
import modin.pandas as pd
from modin.pandas.test.utils import test_data_values
import modin.config as cfg
cfg.StorageFormat.put('omnisci')

data = test_data_values[0]
modin_series = pd.Series(data[next(iter(data.keys()))])
for key in modin_series.keys():
    modin_series.pop(key)

I have error:
AssertionError: Only column drop is supported

@modin-project/modin-omnisci  could someone please check if this still happens?

authors: Rubtsowa vnlitvinov


text:
REFACTOR-#2748: CSV IO part refactoring

What do these changes do?
This PR refactores csv_dispatcher.py module, most significant changes are:

Some code blocks moved into functions.
Fallback-to-pandas checks grouped and moved on the top of _read function.
Modification of original read_csv kwargs parameters was removed
Skipping of rows replaced from partitioned_file into csv_dispatcher.py module

[x] commit message follows format outlined here
[x] passes flake8 modin
[x] passes black --check modin
[x] signed commit with git commit -s
[x] Resolves #2748
[x] tests passing

Measurements results are next:
   before           after      ratio (lower is better)
 [d1321f5f]       [4f2a1457]
 148±10ms          147±6ms     1.00  io.csv.TimeReadCsvSkiprows.time_skiprows((1000000, 10), 500)
  451±5ms          459±4ms     1.02  io.csv.TimeReadCsvSkiprows.time_skiprows((1000000, 10), lambda x: x % 2, default_to_pandas)
  141±5ms         151±10ms     1.07  io.csv.TimeReadCsvSkiprows.time_skiprows((1000000, 10), None)
2.21±0.03s       2.18±0.01s     0.98  io.csv.TimeReadCsvSkiprows.time_skiprows((5000, 5000), 500)
1.45±0.01s       1.44±0.01s     0.99  io.csv.TimeReadCsvSkiprows.time_skiprows((5000, 5000), lambda x: x % 2, default_to_pandas)
2.13±0.02s       2.12±0.03s     1.00  io.csv.TimeReadCsvSkiprows.time_skiprows((5000, 5000), None)

So, refactoring doesn't affected read_csv performance.

Hi @devin-petersohn, can this PR be merged or you have any comments?

Hi @devin-petersohn please take a look at this PR.


text:
DOCS-#6452: Update copyright year

What do these changes do?

[x] first commit message and PR title follow format outlined here

NOTE:  If you edit the PR title to match this format, you need to add another commit (even if it's empty) or amend your last commit for the CI job that checks the PR title to pick up the new PR title.

[ ] passes flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
[ ] passes black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
[ ] signed commit with git commit -s
[x] Resolves #6452
[ ] tests added and passing
[ ] module layout described at docs/development/architecture.rst is up-to-date

We should also update it here. https://github.com/modin-project/modin/blob/5240febacfcf56a94619862f5b3917cf13f06749/docs/conf.py#L65

We should also update it here.
https://github.com/modin-project/modin/blob/5240febacfcf56a94619862f5b3917cf13f06749/docs/conf.py#L65

Thanks! Updated.

authors: YarShev anmyachev