text:
Detect when closed

Is it possible to know when the dialog closes?
When the user presses onBack it doesn't fire any closing event, is it possible to know when it closes?
Scenery:

Elegant Notification with progressIndicator
When the notification is showing the user presses 'on Back'.
The notification is hidden/closed.
Is it possible to detect that event? <--

Thank you!

Hello @thorito thanks for the suggesstion
I just added this scenery you can check in the latest version 1.6.2
https://pub.dev/packages/elegant_notification
Now when you use  onDismiss you will get notified when the back button is pressed (onDismiss is invoked)

It has worked well
Thank you

authors: koukibadr thorito

repo: koukibadr/Elegant-Notification


text:
Custom pages?

This is pretty great (works great on OpenBSD too), but I'd love to add custom pages for my local scripts & commands.
What about being able to specify a second lookup directory path? tinytldr could look there first, then fallback to the one specified in PAGES_PATH... ?

Great idea. Feel free to submit a pull request, or wait for me to implement it in the nearest future.

source: gharchive/issue

authors: kovmir neezer

repo: kovmir/tinytldr

license: MIT

license_type: permissive

license_source: github-api


text:
Failed Ruff runs should be displayed as errors, not raised as IDE exception

Describe the bug
When the plugin calls ruff binary and it exits with an unexpected error (e.g. there is a typo in ruff.toml), the user will not get notified about that, but instead, an IDE exception is being raised. Since those are not easy to find (small red icon in the right corner) and require you to parse Kotlin traceback message with your eyes it is difficult to debug the exact cause of an error.
To Reproduce
Steps to reproduce the behavior:

Create sample ruff.toml with the following contents:

python = "3.12"

In the plugin settings choose this file as a chosen Ruff configuration.
Make some changes to an open Python file.
Save the file.

Expected behavior
A pop-up that relays the exact error message produced by failed ruff run.
Environments (please complete the following information):

IDE: PY-232.10072.31
OS: macOS Ventura 13.6
Ruff Version: 0.0.292
Plugin version: 0.0.24

If you agree that this is a valid issue but don't have time to work on it, I can make a PR for that.

@lensvol
Thank you for creating the issue and sponsoring me 🙇

If you agree that this is a valid issue but don't have time to work on it, I can make a PR for that.

I agree with your observation. It would be great if you could create a PR to address this. However, before that, I have one concern. How would the plugin behave if the user is in the middle of editing the toml file and ruff gets executed, resulting in an error? Would it not become a nuisance alert for the user?

I do not see how that specific scenario is possible when editing TOML in the IDE, honestly. As far as I can see, Ruff binary will only get called in the following situations:

Explicit call via Run Ruff
When the current file is going to be saved.
When code is being reformatted.

Cases 2 and 3 have safeguards in the form of isApplicableTo, which will prevent Ruff execution due to the file not being a Python one.
Case 1 probably will not annoy the user, since the appearance of that pop-up is caused by their own hands.
Speaking more broadly, Ruff execution errors could also be reported via notification balloon instead of a modal pop-up.

@lensvol
Sorry, I did not consider that isApplicableTo .
Please ignore my concern.

Speaking more broadly, Ruff execution errors could also be reported via notification balloon instead of a modal pop-up.

I prefer a notificaiton ballon :)

How would the plugin behave if the user is in the middle of editing the toml file and ruff gets executed, resulting in an error? Would it not become a nuisance alert for the user?

This would actually be highly based if the plugin could run on pyproject.toml
[tool.ruff]
target-version = "py312"
asdf = true

> ruff check
ruff failed
  Cause: Failed to parse C:\Users\bartholomewm\projects\myhr\pyproject.toml
  Cause: TOML parse error at line 521, column 1
    |
521 | [tool.ruff]
    | ^^^^^^^^^^^
unknown field `asdf`

So we could show the error in the toml file:
[tool.ruff] # ruff failed: unknown field `asdf`
target-version = "py312"
asdf = true

I'll raise a separate issue for this!

Could I suggest a file level banner error over a balloon notification, I fell it would be better suited.

authors: KotlinIsland koxudaxi lensvol

repo: koxudaxi/ruff-pycharm-plugin


text:
Support more roms

1941
astorm
astorm3
bnj
brapboys
bublboblr
chelnov
chopliftbl
citycon
commandou
cotton2
cyvern
gtfore06
bchopper
mrheli

Thanks @marchah!

source: gharchive/pull-request

authors: kpshek marchah

repo: kpshek/ledblinky-controls-colors


text:
Accept SameSite cookie attribute.

Also allow it to be set for the session cookie.
https://tools.ietf.org/html/draft-ietf-httpbis-cookie-same-site-00
Only supported in some of the important browsers as of now (cf. http://caniuse.com/#feat=same-site-cookie-attribute). I believe it eventually will be supported by all, but I have no hard evidence on that.
If you consider it a premature addition maybe keep the pull request around in a branch?

Don't think we will support this before it hasn't been accepted as an RFC and is supported by more browsers.

I'm closing this issue for now, since we've had too many bad experiences with supporting features based on drafts. But that does not mean it has been rejected, just that it's too early for a discussion.

Apparently this is still not part of RFC 6265 (or a successor) but according to http://caniuse.com/#feat=same-site-cookie-attribute all major browsers support this now.
Maybe it is time to reopen this pull request?

authors: heikojansen kraih

repo: kraih/mojo

license_source: bigquery


text:
How about using LoadWithLogger in LoadPlugins method

I was created a custom plugin but althrough defined RegisterLogger, it not be called.
I see plugin.go, it call client.Load and server.Load without specific logger.
How about using client.LoadWithLogger and server.LoadWithLogger ?
I made a pull request https://github.com/devopsfaith/krakend-ce/pull/344

fixed at https://github.com/krakendio/krakend-ce/pull/374

authors: banv kpacha

repo: krakendio/krakend-ce


text:
Cancel function on the event listener

If I initialize the listener in this way, postRobot.listener and register more than one on,
var listener = postRobot.listener({ window: childWindow, domain: 'http://zombo.com' });

listener.on('getUser', function(event) {
    return {
        id:   event.data.id,
        name: 'Frodo'
    };
});

listener.on('getManager', function(event) {
    return {
        id:   event.data.id,
        name: 'Erik'
    };
});

it would be great if I can simply call
listener.cancel()

to cancel all the event listeners, rather than I have to store the listener handler of each on function and cancel them one by one.

Then you might potentially cancel listeners set up by other apps, libraries, etc. It's safer to have you only be able to cancel listeners that you explicitly set up.

oh, I get your point, it's fine for me know, I just need to store all the on and cancel them.
Just to discuss a little bit more, I didn't know that when different apps call the .listern method they are re-using the same listener object? does it only happen when the window and domain are the same?
and then they may possibly overwrite each other's handle function if the event name is the same? or is the on method actually is an add listener operation? if so, maybe it would also be better if this .listen return a unique listener object and add it to an internal .listener array of that window and domain?

If you try to register a new listener with the same combination of name + window + domain, you'll end up with an exception. The safest bet would be to namespace your messages; on('myapp:somethinghappened', () => { ... })

sure, of course. Although if this postRobot.listener({ window: childWindow, domain: 'http://zombo.com' }); can return a unique listener object and add it to an internal .listener array, which has that window and domain as the array identifier,  then we can allow the app developer to cancel all the on by calling listern.cancel and name the event whatever they want without worrying about name conflicts.
I am not asking for that feature right now, just some thoughts on small things can be improved maybe?  Thank you for asking my questions @bluepnume

authors: bluepnume nosus

repo: krakenjs/post-robot


text:
Added the materializecss's tooltip feature

It was impossible to make a directive named "tooltip" because of ambiguous error into data-tooltip attribute and the directive. So I named it : "tooltipped".

It's weird...my directive works only for the last li and I don't have a solution for that.

That it only works on the last is a general problem, and I've found why.
If you look at the following line: https://github.com/Dogfalo/materialize/blob/ce5e0ba9f0ac2e32e0f2d9f8859928af32c6b0dd/js/tooltip.js#L16
//Remove previously created html
$('.material-tooltip').remove();

When it initializes a new tooltip, it first removes all the previously created tooltips.
The solution is to initialize all tooltips whenever the link function in the directive runs. Which I did in 242203d2acd821da01c00f242b13395fc9dcc9d6

"The solution is to initialize all tooltips whenever the link function in the directive runs. "
I didn't want to do that because it's overkill. If you have a big table with a lots of tooltips (like I have), it will take a lots of ressources.
I fixed that for the moment directly into the materialize.js.
You can see my solution here :
https://github.com/Dogfalo/materialize/issues/1386
Now...we have to wait a fix from them....

Okay, I helped them a bit Dogfalo/materialize#1547.
If they update their code, then we can change the implementation here as well.

authors: toben webbiesdk

repo: krescruz/angular-materialize

license: mit


text:
Download flag gif

Please how can someone download the flag as a gif?

FlagWaver doesn't have such a feature. There are a number of browser plugins that let you capture your screen to a gif, so maybe try one of those

authors: Francisobiagwu krikienoid

repo: krikienoid/flagwaver


text:
Added undocumented Api calls :

I have added a few undocumented api calls which are useful.
users.admin.invite (email invite)
users.admins.setInactive (deactivate a team member : Only for paid plans)
users.admin.setRegular (reactivate a team member : Only for paid plans)

Thanks!

authors: SamirL krishamoud

repo: krishamoud/meteor-slack-api


text:
10m-pass.sh line 35: instagram-py: command not found

Please fix this

Please ensure that you have the latest version of python3 installed on your machine, if problem persists, please open a new issue and I'll look out at the script for the necessary changes, thanks for using.

repo: krishealty/venom-instagram-bruteforce


text:
Create Type for fetchLatestMovie function ILatestMoviesResponse

What to do?
Create ILatestMoviesResponse type into ./types/dejavu.d.ts file & add it into ./utils/dejavu.ts file within the fetchLatestMovie function.

Is this still active?, can you assign it to me, can I contribute to it?


text:
extended searching option isn't working in fusejs.io now

I'm not sure here is a good place to report it. I think latest fuse.js has some problems with the extended searching feature. @krisk

Good catch, and oops. Will fix it now.

repo: krisk/Fuse


text:
Create a flag emptyGetsAll

Is there an existing issue or pull request for this?

[X] I have searched the existing issues and pull requests

Feature description
Create an option that when the query is empty, instead of getting no results, all results are returned.
Desired solution
non-empty query: current behavior
emptyGetsAll is set to true: all results returned on empty input
emptyGetsAll is set to false: no results returned on empty input
default for flag should be false.
Alternatives considered
Hardcoding outside of library; ugly.
Additional context
No response

I have a branch ready with this feature, documentation, and tests, but am unable to push my branch because of permissions.

Love the product but this feature is must have.

Workaround in my Svelte project:
    $: if (fuse) {
        if (searchInput == "") {
            graphNodesStore.set(fuse._docs); // <= to get all results
        } else {
            graphNodesStore.set(fuse.search(searchInput).map((row) => row.item));
        }
    }

authors: aworld1 jimmi-rbn stephane-klein


text:
angular nvd3 chart tooltips are not working in android ios devices

Hi,
I'am using angular nvd3 library for my ionic app, but the major concern is tool tip[ which is very basic behavior for any chart component] is not functioning in mobile/tablet devices. Only tooltip for line chart works not for rest of the chart types. Please suggest how to get this tool tips in devices.
Note: in browser tolltip functionality works but not on mobile devices.
Thanks,
Srinivas

The angular-nvd3 component only creates an angular-wrapper for the nvd3 library. If you experience browser-specific issues, you should create an issue with the nvd3 developers.

authors: dlmh srigurajala


text:
Add CONTRIBUTING.md

Per discussion in #64. I don't have Adobe Illustrator so wasn't able to check the contents of ai_icon_template.ait or ai_icon_template_generic.ait, but otherwise tried to add enough specifications and information to have some kind of published framework. Obviously, feel free to edit/change anything you want.

Ugh, I still have difficulties to merge, but I slightly corrected the few things for now and submitted in. :)
I will add/correct more stuff later.

Thank you for merging that, it looks good with your changes 🚀
It looks like I didn't enable "Allow edits from maintainers". It appears to be off by default. Perhaps that's why you had difficulty making changes before merging?
I would have been happy to turn that button on for you, if it's helpful. I don't think I've needed to do that for any other repos I've contributed to, but I'm pretty new at all this as well. If I forget that checkbox the future or it doesn't make a difference for you anyway, here what's happened when I made Pull Requests to the anki-ultimate-geography project:

The project owner merges my pull request to master, then commits new changes on top of mine. Or, they
Ask me to make the changes on my branch. Optionally they leave a code change suggestion block, which then gives me a button to put your changes into my PR.

I'm pretty new to this as well, so hopefully it's smoother on future PRs 🚀
Here's my screen, with the button I didn't enable:


text:
Display Track Info

Beneath carousel display track name, artist, and album name of the current song

This issue was moved to kroehl/MusicDiscoveryApp#5


text:
issues about briage

Hello, thank you very much for providing such an excellent image. After deploying with Greenlink Cloud SSH, the address obtained by DSM is 20.20.20.21, and it is unable to communicate with the host and mount Samba devices on the host. I am considering that the issue may arise in the briage method. Can you obtain the address 172.17.0. * as the internal address of DSM to try to solve this problem? Thank you for reading.
您好，非常感谢您提供如此优秀的镜像，我使用绿联云ssh部署后，DSM获取到的地址是20.20.20.21，无法和宿主机通信，不能挂载宿主机samba设备。我考虑问题可能出现在briage这种方式上，能否获取172.17.0.*的地址作为DSM内部地址，以尝试解决这个问题，感谢阅读。

Thank you for your reply and providing such an excellent product. I have installed iputils and attempted to ping other devices and hosts, both of which can be pinged and mounted with Samba from other devices. However, I am unable to mount Samba from the host, resulting in data interoperability issues.

感谢回复以及提供如此优秀的产品，我安装了iputils并尝试ping其他设备和宿主机，都可以ping通，也可以挂载其他设备的samba，但是无法挂载宿主机的samba，导致数据无法互通。

I am installed on a UGREEN-NAS device, Like synology or QNAP. I hope to be able to mount the host's directory through vDSM for data sharing. Currently, vDSM can mount other devices on the local area network, but it cannot mount the host's samba.

How do I give the container a dedicated IP address?
By default the container uses bridge networking, and is reachable by the IP of the docker host.
If you want to give it a seperate IP address, create a MACVLAN network that matches your local subnet:
$ docker network create -d macvlan \
    --subnet=192.168.0.0/24 \
    --gateway=192.168.0.1 \
    --ip-range=192.168.0.100/28 \
    -o parent=eth0 macvlan0

And change the network of the container to macvlan0 in your run command:
 --network macvlan0 --ip=192.168.0.100

This has the advantage that you don't need to do any portmapping anymore.

Thank You very much， it works!

如何为容器提供专用IP地址？
默认情况下，容器使用桥接网络，并且可以通过docker主机的IP访问。
如果你想给它一个单独的IP地址，创建一个匹配你本地网的MACVLAN网络：
$ docker network create -d macvlan \
    --subnet=192.168.0.0/24 \
    --gateway=192.168.0.1 \
    --ip-range=192.168.0.100/28 \
    -o parent=eth0 macvlan0

并在您的运行命令中将容器的网络更改为macvlan0：
 --network macvlan0 --ip=192.168.0.100

这样做的好处是您不再需要进行任何终端口投射。

If I have tailscale installed on my system with an intranet ip of 100.64.0.X/32, how do I use this command to connect via tailscale?

version: '3.8'
services:
vm:
container_name: dsm
image: kroese/virtual-dsm:latest
restart: on-failure
environment:
DISK_SIZE: "32G"
RAM_SIZE: "512M"
CPU_CORES: "1"
devices:
- /dev/kvm
cap_add:
- NET_ADMIN
ports:
- 5000:5000
- 5001:5001
volumes:
- ./data:/storage
networks:
macvlan0:
ipv4_address: 192.168.0.100
networks:
macvlan0:
external: true
I wrote it this way, docker-compose.yml, and although he ran it, it didn't work correctly, and I don't know how to write docker-compose.yml correctly to make it work

@ziyou2 Can you tell what didn't work correctly? Because first you were talking about Tailscale so Im a bit confused.

Tailscale solution didn't work because I was using the headscale build
I tried to “docker exec” dsm container and install headscale, but it didn't work

You can login to vDSM, go to Package Center, and search for Tailscale and you will see the app, install it, and it will work fine.

Tailscale solution didn't work because I was using the headscale build
version: "3"
services:
dsm:
container_name: dsm
image: kroese/virtual-dsm:latest
environment:
DISK_SIZE: "16G"
devices:
- /dev/kvm
cap_add:
- NET_ADMIN
ports:
- 5000:5000
- 5001:5001
volumes:
- ./data:/storage
networks:
vdsm:
ipv4_address: 192.168.0.100
networks:
vdsm:
external: true
I use this docker-compose after editing it myself although it returns Creating dsm ... done, but it doesn't work properly

@a11505 Hello, I see that you are using ugreen cloud and can normally use macvlan, but I find that ugreen cloud has not installed MACVLAN-related kernel modules
# lsmod | grep macvlan
# opkg info kmod-macvlan
Package: kmod-macvlan
Version: 5.10.186-1
Depends: kernel (= 5.10.186-1-64a64673aeb2b14d6f0f78fbfb7a1f84)
Status: unknown ok not-installed
Section: kernel
Architecture: x86_64
Size: 10967
Filename: kmod-macvlan_5.10.186-1_x86_64.ipk
Description: A kernel module which allows one to create virtual interfaces that
 map packets to or from specific MAC addresses to a particular interface

I try to install it manully, but got
# opkg install kmod-macvlan
Multiple packages (libgcc1 and libgcc1) providing same name marked HOLD or PREFER. Using latest.
Multiple packages (libgcc1 and libgcc1) providing same name marked HOLD or PREFER. Using latest.
Multiple packages (libpthread and libpthread) providing same name marked HOLD or PREFER. Using latest.
Multiple packages (librt and librt) providing same name marked HOLD or PREFER. Using latest.
Multiple packages (libpthread and libpthread) providing same name marked HOLD or PREFER. Using latest.
Unknown package 'kmod-macvlan'.
Collected errors:
 * pkg_hash_check_unresolved: cannot find dependency kernel (= 5.10.186-1-64a64673aeb2b14d6f0f78fbfb7a1f84) for kmod-macvlan
 * pkg_hash_fetch_best_installation_candidate: Packages for kmod-macvlan found, but incompatible with the architectures configured
 * opkg_install_cmd: Cannot install package kmod-macvlan.

If  using docker to create an image without kmod-macvlan, I would get an error
docker: Error response from daemon: failed to create the macvlan port: operation not supported.

Could you please tell me how to solve it?

是的，绿联云没有该模块，且没有兼容的模块可以安装，极空间支持MACVLAN，我有多台设备，该解决方案在极空间有效，绿联云使用openwrt作为底层，有天生缺陷，可能无解。
---Original---
From: @.>
Date: Tue, Jul 4, 2023 00:17 AM
To: @.>;
Cc: @.@.>;
Subject: Re: [kroese/virtual-dsm] issues about briage (Issue #24)
@a11505 Hello, I see that you are using ugreen cloud and can normally use macvlan, but I find that ugreen cloud has not installed MACVLAN-related kernel modules
lsmod | grep macvlan # opkg info kmod-macvlan Package: kmod-macvlan Version: 5.10.186-1 Depends: kernel (= 5.10.186-1-64a64673aeb2b14d6f0f78fbfb7a1f84) Status: unknown ok not-installed Section: kernel Architecture: x86_64 Size: 10967 Filename: kmod-macvlan_5.10.186-1_x86_64.ipk Description: A kernel module which allows one to create virtual interfaces that  map packets to or from specific MAC addresses to a particular interface
I try to install it manully, but got
opkg install kmod-macvlan Multiple packages (libgcc1 and libgcc1) providing same name marked HOLD or PREFER. Using latest. Multiple packages (libgcc1 and libgcc1) providing same name marked HOLD or PREFER. Using latest. Multiple packages (libpthread and libpthread) providing same name marked HOLD or PREFER. Using latest. Multiple packages (librt and librt) providing same name marked HOLD or PREFER. Using latest. Multiple packages (libpthread and libpthread) providing same name marked HOLD or PREFER. Using latest. Unknown package 'kmod-macvlan'. Collected errors:  * pkg_hash_check_unresolved: cannot find dependency kernel (= 5.10.186-1-64a64673aeb2b14d6f0f78fbfb7a1f84) for kmod-macvlan  * pkg_hash_fetch_best_installation_candidate: Packages for kmod-macvlan found, but incompatible with the architectures configured  * opkg_install_cmd: Cannot install package kmod-macvlan.
If  using docker to create an image without kmod-macvlan, I would get an error
docker: Error response from daemon: failed to create the macvlan port: operation not supported.
Could you please tell me how to solve it?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: @.***>

repo: kroese/virtual-dsm


text:
Virtual clusters should support multiple listeners

Is your feature request related to a problem? Please describe.
Users will sometimes need multiple routes into the same virtual cluster.  For instance, on Kubernetes they might want to admit traffic from application deployed to the same cluster (dialing using a cluster-ip) and off cluster applications, perhaps dialing in via a load balancer.
You can kind of achieve this right now by duplicating your virtual cluster definition (although this relies on the fact that #379 isn't implemented).
Describe the solution you'd like
The ability to define a Virtual Cluster with n listeners.
I think the configuration should try to follow the Apache Kafka terminology where appropriate (i.e. advertisedListener) etc so that it is more familiar to users who are already comfortable with configuring Kafka listeners..
I think we'd want to start by proposing some API.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

This impacts the CRD schema for the operator. So even if we don't support multiple listeners in the proxy for a while, we should ensure that the CR API won't need an incompatible change once it is supported. We could, for instance, use an array-typed listeners property, but constrain the maximum length to 1 for the time being.

authors: k-wall tombentley

repo: kroxylicious/kroxylicious


text:
dsmetadata api has an issue with verbose set to true

Describe the bug
while calling the dsmetadata api on ui with verbose set to true either its not giving all the data or there is not enough data.
How to reproduce it
check dsmetadata api on nerc cluster
http://kruize-ui-nginx-service-openshift-tuning.apps.nerc-ocp-test-2.nerc.mghpcc.org/api/dsmetadata?datasource=prometheus-1&cluster_name=default&verbose=true
this is the api call being made from the ui
Expected behavior
UI expects to receive either complete data (nsp name, workload name , container details) or some notification if data is not available.
Environment:

nerc cluster

Additional context

@bhanvimenghani can you please test the latest Kruize build - quay.io/kruize/autotune_operator:0.1 and verify if the dsmetadata?datasource=prometheus-1&cluster_name=default&verbose=true API with verbose=true returns the container details.

This is working fine, I can see workload and container details under each namespace with the latest build.

repo: kruize/autotune


text:
Latest version of Postscribe Occassionaly display JS code instead of evaluting it

Hi @sethyates and @jnewman,
Sorry, I was not able to produce a jsfiddle for this, but I would be as descriptive as I could be. I've tried the latest version, and I found that couple of my ads were not rendering, instead inline JS code was displayed as shown following.

As you could see, on the right side of logo, it displays the JS code instead of evaluating it as a JS code. The reason behind that, as shown in the firebug, is the code is injected just outside of "script" tag. So, we've blank "script" tag and the code sits after that, so it won't be parsed as JS.
In case if it helps you, here's my ad code I'm using.

<script>
postscribe("#ad10", '<script src="http://eas3.emediate.se/eas?cu=8272;cre=mu;js=y;pageviewid=;target=_blank" type="text/javascript"><\/script>');
</script>

Is that using the latest version of postscribe from an npm build?  There was a bug in the html parser in an earlier version that would sometimes do that but I thought that was fixed in a more recent version.

Yes, @sethyates I'm using this one.
https://raw.githubusercontent.com/sajalsoni/testing_sks/master/postscribe.js

Confirmed this is broken in latest and works in an older version. Looking into a fix. Can repro in a unit test like:
// in remote-file.js

// Hello
document.write('<script>');
document.write("'Oh, no!'");
document.write('<\/script>');

// In write-comparisons

'only:wlma: writes code inside tag': '<script src="remote/multi-write-script.js" type="text/javascript"><\/script>'

The issue is caused by a difference in behavior in prescribe. Calling readToken w/ a startTag previously would return null, now it returns the start token, which is then autoclosed by postscribe. Investigating a fix.

Hi @sethyates, I think it's not fixed yet as I've just tested the 2.0.5 version (cloud link) and still couple of (not all) my ads produce inline JS code. Following are the specific ads that produce inline JS code.
postscribe('#ad5', '

The fix was in 2.0.6. Please retest with that version.

Thanks @sethyates, just in case you would like to fix cloud link point out to 2.0.6 instead of 2.0.5!

Thanks. I've updated that link.

authors: jnewman sajalaspl sethyates

repo: krux/postscribe


text:
Move some unused code to a new unused.cpp file

There is lots of code in StrobeAlign that is unused. It is either commented out or it exists as a function that is never called. Since I would like to focus on the relevant code when working on the program, I would like to somehow get rid of it. I usually just delete old code, knowing that I can find it again in the Git history if the need arises.
However, I can see that you may be reluctant to do that as it appears that you sometimes run experiments by quickly commenting/uncommenting a function call (for example, to switch out the hash function). So to still have the code somewhere more easily accessible, I suggest to move it to a file "unused.cpp" for the moment. This PR adds that file and moves some unused functions from index.cpp into it. Additionally, this adds an unused-code target to CMake, which is only there to ensure that the code in unused.cpp is compiled when running "make". This ensures that the functions are runnable should they be needed.

I’ve gone through aln.cpp as well and moved everything I found that was unused over to unused.cpp as well. With this, aln.cpp is now down to 3000 lines (from 4000 lines when I started a couple of weeks ago).

repo: ksahlin/StrobeAlign


text:
If R1 and R2 map to same position, treat them as proper pair

The first change is to factor out an is_proper_nam_pair() function. This changes behavior slightly as the code wasn’t identical at the two call sites. The condition for the distance was a-b < 2000 in one case and a-b < mu+10*sigma in the other. The factored-out function uses the latter because taking the distribution into account seems to be the intended behavior.
The second change is to treat a pair of NAM as being a "proper pair" even if the query start positions are the same.
Both commits change accuracy slightly. The overall difference is as follows:

dataset
aed4738
cd26078
difference

drosophila-50
90.1908
90.19065
-0.0002

drosophila-100
92.3875
92.38865
+0.0012

drosophila-200
93.5184
93.52115
+0.0028

drosophila-300
95.3617
95.3612
-0.0005

maize-50
71.47185
71.472
+0.0002

maize-100
87.13235
87.13245
+0.0001

maize-200
92.921
92.92045
-0.0005

maize-300
96.7109
96.7086
-0.0023

CHM13-50
90.6348
90.63435
-0.0004

CHM13-100
93.2195
93.21995
+0.0004

CHM13-200
94.43375
94.43415
+0.0004

CHM13-300
95.62465
95.62665
+0.0020

The case that R1 and R2 map to the same location doesn’t occur in our test datasets as far as I can tell, so it’s expected that the numbers don’t improve. The actual benefit would be on real data.
Closes #317

Very nice! Approved.

btw, the change in cd26078 highlights that we use mu +5sigma and mu +10sigma for proper pair. Should we stick to the same? If sigma is low or poorly estimated (underestimated), it would be very bad. So we would win on having a lenient cutoff I think.

Sure, I can make that more consistent. There’s also the is_proper_pair_function, which uses mu + 6*sigma:
https://github.com/ksahlin/strobealign/blob/aed473814e427afad24526595a39b8b215efd554/src/sam.cpp#L311-L321
But that one is only for setting the "properly paired" flag in SAM output, not for making any mapping decisions, so I guess it’s ok if it is a bit more restrictive.

I added 47cb5c2 to make things more consistent. For completeness, these are the accuracy changes from that commit alone:

dataset
cd26078
47cb5c2
difference

drosophila-50
90.19065
90.189
-0.0016

drosophila-100
92.38865
92.38785
-0.0008

drosophila-200
93.52115
93.52085
-0.0003

drosophila-300
95.3612
95.36085
-0.0003

maize-50
71.472
71.4703
-0.0017

maize-100
87.13245
87.13175
-0.0007

maize-200
92.92045
92.92045
+0.0000

maize-300
96.7086
96.70835
-0.0002

CHM13-50
90.63435
90.635
+0.0007

CHM13-100
93.21995
93.21985
-0.0001

CHM13-200
94.43415
94.43405
-0.0001

CHM13-300
95.62665
95.62665
+0.0000

But that one is only for setting the "properly paired" flag in SAM output, not for making any mapping decisions, so I guess it’s ok if it is a bit more restrictive.

Ah I see. yes agreed. Most important is that pairs within 10sigma is scored higher than e.g. reads on different chromosomes.
Related: do you think it would make sense / be worth to score read pairs on the same chromosome (but far away) higher than reads on separate chromosomes? Currently I think there is only the binary 'close and proper' or 'not close and proper' classification.

I think we’re on the same page about this PR, so merging it now.

authors: ksahlin marcelm

repo: ksahlin/strobealign


text:
F Distribution CDF and PDF return NaNs at X=Inf

Calling stats:pf(Inf, 2,2) or stats:df(Inf, 2,2) would return NaNs instead of the expected 1.0 and 0.0, respectively.

PR #27 solves this issue

PR #27 solves this issue

Thanks, merged.

authors: brgirgis kthohr

repo: kthohr/stats


text:
Feature/zod parser tests

Added a few repro tests for zod code generation.
I hope the tests make sense and are okay.

The failing test complains about
SyntaxError: /home/runner/work/kubb/kubb/packages/swagger-zod/mocks/zod_parser.yaml is not a valid Openapi API definition

However, I tried multiple validators and none complains...

@helt Is this related to your issue? https://github.com/kubb-project/kubb/issues/658

@stijnvanhulle Yes. Sorry for the intermixing of issues here.
The tests document the following discoveries:

.nullable() is added incorrectly (E. G. In test NullableStringWithAnyOf
format UUID seems not to be added at all. See NullableStringUuid
const  keyword should be translated to z.literal(...) if I understand correctly. Eg NumberValueConst test

But please note, that the expected values of the tests are merely what I think it should be, and have been written manually, and therefore might contain syntax and semantic errors!

@helt Added your tests to https://github.com/kubb-project/kubb/pull/683 and also fixed the issue :)

authors: helt stijnvanhulle

repo: kubb-project/kubb


text:
Update the pause images

Type of change

[ ] Refactor
[ ] New feature
[x] Bug fix
[ ] Optimization
[ ] Documentation Update

Description
This PR updates the pause images, which are multi-arch in nature
Related Tickets & Documents

Related Issue #
Closes #

Checklist before requesting a review

[x] I have performed a self-review of my code.
[ ] If it is a core feature, I have added thorough tests.

@krishvoor could you please take a look at the failing tests before moving on?
Thanks!

Hi @josecastillolema: this is looking good now.

authors: josecastillolema krishvoor

repo: kube-burner/kube-burner-ocp


text:
[Bug]: upgrading a clean cluster( just installed) 1.27 to 1.28  - one of the nodes stuck in emergency mode

Description
i have installed the cluster on 1.27 after it was done without doing anything else i have upgraded it to 1.28 (~3:42 UTC)
all nodes were up and running except one ( see screenshot).
i used hetzner console to have a look at that node , terminal is stuck in emergency mode (see screenshot 2)
i pressed 'Enter' and everything started and the node is now online again and upgraded (this was at 6:41 UTC).
upon following the recommendation by the OS looking into journalctl -xb (output_reducted.txt attached) i see that the root cause of the issue as far as i gather is that /boot/writable could not be mounted
any idea why this would happen?
Kube.tf file
## All values are referenced from here - https://github.com/kube-hetzner/terraform-hcloud-kube-hetzner/blob/master/kube.tf.example

module "kube-hetzner" {
  providers = {
    hcloud = hcloud
  }

  source = "kube-hetzner/kube-hetzner/hcloud"

  hcloud_token = var.hcloud_token

  rancher_install_channel = "latest"
  initial_k3s_channel = "v1.28"

  version = "2.13.5"
  # ssh_port = 2222clear
  base_domain = "${replace(var.app_name,"-",".")}.XXX.XX"
  cluster_name = "${var.app_name}"
  # rancher_hostname = "XX.XX.XX"

  enable_cert_manager = false
  enable_rancher = false
  enable_longhorn = false
  # enable_traefik = false
  enable_klipper_metal_lb = "false"
  control_plane_lb_enable_public_interface = true
  # enable_nginx = true

  load_balancer_disable_public_network = false

  ssh_public_key = file("./ssh-key/id_rsa.pub")

  # For more details on SSH see https://github.com/kube-hetzner/kube-hetzner/blob/master/docs/ssh.md
  ssh_private_key = file("./ssh-key/id_rsa")
  network_region = "eu-central" # change to `us-east` if location is ash

  control_plane_nodepools = [
    {
      name        = "control-plane-nbg1",
      server_type = "cx21",
      location    = "nbg1",
      labels      = [],
      taints      = [],
      count       = 2
    },
    {
      name        = "control-plane-hel1",
      server_type = "cx21",
      location    = "hel1",
      labels      = [],
      taints      = [],
      count       = 1
    }
  ]

  agent_nodepools = [
    {
      name        = "workload-agent-0",
      server_type = "cx41",
      location    = "nbg1",
      labels = [
        "node.kubernetes.io/pool=workload-agent-cx41"
      ],
      taints      = [],
      count       = 3,
      # longhorn_volume_size = 50
    },
    {
      name        = "longhorn-agent-0",
      server_type = "cx41",
      location    = "nbg1",
      labels = [
        "node.kubernetes.io/server-usage=storage",
        "node.kubernetes.io/pool=longhorn-agent-0"
      ],
      taints      = [],
      count       = 3,
      longhorn_volume_size = 50
    }
  ]

  # * LB location and type, the latter will depend on how much load you want it to handle, see https://www.hetzner.com/cloud/load-balancer
  load_balancer_type     = "lb11"
  load_balancer_location = "nbg1"

  ### The following values are entirely optional (and can be removed from this if unused)

  # You can refine a base domain name to be use in this form of nodename.base_domain for setting the reserve dns inside Hetzner

  # To use local storage on the nodes, you can enable Longhorn, default is "false".

  # The file system type for Longhorn, if enabled (ext4 is the default, otherwise you can choose xfs)
  # longhorn_fstype = "xfs"

  # how many replica volumes should longhorn create (default is 3)
  longhorn_replica_count = 1
  disable_hetzner_csi = false

  kured_options = {
    "concurrency": 3
  }

  # If you want to disable the Traefik ingress controller, to use the Nginx ingress controller for instance, you can can set this to "false". Default is "true".

  # We give you the possibility to use letsencrypt directly with Traefik because it's an easy setup, however it's not optimal,
  # as the free version of Traefik causes a little bit of downtime when when the certificates get renewed. For proper SSL management,
  # we instead recommend you to use cert-manager, that you can easily deploy with helm; see https://cert-manager.io/.
  # traefik_acme_tls = true
  ingress_controller = "none"
  automatically_upgrade_os = true

  allow_scheduling_on_control_plane = false
  automatically_upgrade_k3s = true

  cni_plugin = "cilium"
  cilium_version = "v1.15.4"
  cilium_routing_mode = "native"
}

Screenshots
status after upgrade:

stuck at emergency:

output_reducted.txt
Platform
Linux

@asafbennatan You are in HA, so just turn off and turn back on the node. Normally it should work.

authors: asafbennatan mysticaltech


text:
Add helper for creating a controller owner_ref on Resource

Motivation
Controllers frequently have to create owned objects with owner references pointing back to the object we get passed to reconcile.
We would like a way to quickly populate the OwnerReference struct for this case to avoid having to hand-cook this in every controller.
Solution
Grab the function in configmapgen_controller and add it as a Resource::controller_owner_ref impl.
It's possible we should put this elsewhere, am open to ideas, but we should have something like this.

Codecov Report

Merging #850 (da52814) into master (47fcf10) will decrease coverage by 0.12%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #850      +/-   ##
==========================================
- Coverage   70.42%   70.29%   -0.13%
==========================================
  Files          59       59
  Lines        4203     4212       +9
==========================================
+ Hits         2960     2961       +1
- Misses       1243     1251       +8

Impacted Files
Coverage Δ

kube-core/src/resource.rs
51.35% <0.00%> (-7.12%)
:arrow_down:

kube-runtime/src/wait.rs
70.00% <0.00%> (+2.00%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47fcf10...da52814. Read the comment docs.

authors: clux codecov-commenter

repo: kube-rs/kube-rs


text:
same title, but actually they are not the same

What type of PR is this?

What this PR does / why we need it:
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:

/lgtm

/lgtm

/lgtm

/lgtm

/approve

authors: ErikJiang hangscer8 wenting-guo yanggangtony

repo: kubean-io/kubean


text:
feat: add a label to trigger repository restart

What type of PR is this?

What this PR does / why we need it
Which issue(s) this PR fixes

Fix: https://github.com/kubebb/core/issues/318
Special notes for your reviewer
Only a way to enable manually restart with this new lable. Not tested yet. Not committed to work....

i forgot to add the tests…

repo: kubebb/core


text:
[WIP] feat: add k8s apiserver to no proxy

What does this PR change?
closes #1139
Does this PR rely on any other PRs?
Nope
How does this PR impact users? (This is the kind of thing that goes in release notes!)
It should make their lives easier when setting proxies on the containers as env variables
Links to Issues or ZD tickets this PR addresses or fixes

#1139

How was this PR tested?
Unit test and locally (still to come)
Have you made an update to documentation?
No but I can

thanks @rumstead !

Closing as the issue is now closed.

authors: dramich kirbsauce rumstead

repo: kubecost/cost-model


text:
Correct onnx readme steps

What this PR does / why we need it:
Readme step has some issues
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #565
Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:

NONE

This change is

@googlebot I signed it!

@googlebot I signed it!

repo: kubeflow/kfserving


text:
kubebench package install error

I follow this guide to install kubeflow on my single ubuntu18.04 machines, and I want to try kubebench but I got bellow error
root@kobe:~/kubeflow# kubectl version
Client Version: version.Info{Major:"1", Minor:"15", GitVersion:"v1.15.0", GitCommit:"e8462b5b5dc2584fdcd18e6bcfe9f1e4d970a529", GitTreeState:"clean", BuildDate:"2019-06-19T16:40:16Z", GoVersion:"go1.12.5", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"15", GitVersion:"v1.15.0", GitCommit:"e8462b5b5dc2584fdcd18e6bcfe9f1e4d970a529", GitTreeState:"clean", BuildDate:"2019-06-19T16:32:14Z", GoVersion:"go1.12.5", Compiler:"gc", Platform:"linux/amd64"}

Below are the commands I ran
ks init kubeflow --namespace kubeflow
export KB_VERSION=master
export KB_ENV=default

curl https://raw.githubusercontent.com/kubeflow/kubebench/master/scripts/install_quickstarter.sh | bash

Error messgae
root@kobe:~/kubeflow# curl https://raw.githubusercontent.com/kubeflow/kubebench/master/scripts/install_quickstarter.sh | bash
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   775  100   775    0     0   3934      0 --:--:-- --:--:-- --:--:--  3914
ERROR resolving package metadata: kubebench/kubebench-quickstarter@master: GET https://api.github.com/repos/kubeflow/kubebench/contents/kubebench/kubebench-quickstarter/parts.yaml?ref=bc682c1c9a7f5bd1281442965567764daecb0e68: 403 API rate limit exceeded for 140.116.247.211. (But here's the good news: Authenticated requests get a higher rate limit. Check out the documentation for more details.) [rate reset in 24m45s]
ERROR resolving package metadata: kubebench/kubebench-examples@master: GET https://api.github.com/repos/kubeflow/kubebench/commits/master: 403 API rate limit exceeded for 140.116.247.211. (But here's the good news: Authenticated requests get a higher rate limit. Check out the documentation for more details.) [rate reset in 24m44s]
ERROR no prototype names matched 'kubebench-quickstarter-service'
ERROR no prototype names matched 'kubebench-quickstarter-volume'
Error from server (NotFound): services "kubebench-nfs-svc" not found
ERROR unable to find component kubebench-quickstarter-volume

After Downgrade Kubernetes version 1.14.3, it works.
I think it's related to https://github.com/kubeflow/kubeflow/issues/3544

repo: kubeflow/kubebench


text:
kubeflow: remove operator test in pr check

Description

Remove the operator check during the PR build check as not needed in kubeflow
How Has This Been Tested?

Merge criteria:

[x] The commits and have meaningful messages; the author will squash them after approval or will ask to merge with squash.
[x] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
[x] The developer has manually tested the changes and verified that the changes work

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

:exclamation: No coverage uploaded for pull request base (main@198fb0e). Click here to learn what that means.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff           @@
##             main      #16   +/-   ##
=======================================
  Coverage        ?   81.16%
=======================================
  Files           ?       12
  Lines           ?      600
  Branches        ?       74
=======================================
  Hits            ?      487
  Misses          ?       90
  Partials        ?       23

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

/approve
/lgtm

authors: codecov-commenter lampajr tarilabs

repo: kubeflow/model-registry


text:
Upgrade to Spark 3.5.3

Purpose of this PR

Upgrade from Spark 3.5.2 to 3.5.3 (https://spark.apache.org/releases/spark-release-3-5-3.html)
Use new unversioned example JAR path e.g. https://github.com/apache/spark/blob/039fd13eacb1cef835045e3a60cebf958589e1a2/resource-managers/kubernetes/docker/src/main/dockerfiles/spark/Dockerfile#L59

Change Category

[ ] Bugfix (non-breaking change which fixes an issue)
[X] Feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that could affect existing functionality)
[ ] Documentation update

Checklist

[X] I have conducted a self-review of my own code.
[X] I have updated documentation accordingly.
[ ] I have added tests that prove my changes are effective or that my feature works.
[X] Existing unit tests pass locally with my changes.

/hold
The official spark:3.5.3 image hasn't been published yet
https://github.com/apache/spark-docker?tab=readme-ov-file#step-3-publish-spark-docker-official-images

/assign @ChenYi015 @ImpSy

Will merge this PR for image spark:3.5.3 has already been released.
/unhold

repo: kubeflow/spark-operator


text:
Step in Installing kustomize throws an error

Following the link https://www.kubeflow.org/docs/other-guides/kustomize/ to install kustomize.
when I tried to run the mv command mentioned below, throws an error.  It looks like tar ball is not extracting with the name of the file. Instead i noticed that it extracts as the file "kustomize" under the current directory.
Error:
$ mv kustomize__${opsys}amd64 ${HOME}/bin/kustomize
mv: cannot stat ‘kustomize_linux_amd64’: No such file or directory

Move the binary:
mv kustomize_*_${opsys}_amd64 ${HOME}/bin/kustomize

Thanks @arshashi . Very good catch!
/assign

repo: kubeflow/website


text:
Create a guide to the ModelDB component

We had a guide to the the ModelDB component. PR https://github.com/kubeflow/website/pull/942 removed the guide, because it was out of date. Google Analytics shows that readers viewed the guide reasonably often (1,500 views over the last two months, compared with Katib (1,800) and Jupyter notebooks (1,700) and Pipelines component page (1,000)).
We should add an up-to-date guide to the ModelDB component.

@mvartakAtVerta Will you be able to tackle these docs?

I'm closing this issue as there's been no activity on it for 4 months. If anyone would like to work on a ModelDB doc, please do re-open the issue.
/close


text:
Updated version for GCP deployment UI

The GCP click-to-deploy app now supports Kubeflow v1.0.0

This change is

/assign @abhi-g

Preview of a page that uses the shortcode:
https://deploy-preview-1784--competent-brattain-de2d6d.netlify.com/docs/gke/deploy/deploy-ui/


text:
Update interfaces.md

correct the link

Thank you @slitery1234 for this fix!
/lgtm
/approve


text:
Add documentation for JAXJob

Ref: https://github.com/kubeflow/training-operator/issues/1619 https://github.com/kubeflow/training-operator/issues/2145

/area gsoc
/cc @tenzen-y @andreyvelich @terrytangyuan

@sandipanpanda Did you get a chance to review the remaining comments ?

Thanks for this @sandipanpanda!
/hold cancel

authors: andreyvelich sandipanpanda


text:
Create new multi-arch workflow

This will create arm64 images too. Have a look for nashant/kubemod-crt on dockerhub for verification (tag v1.1.4)

Closes #13.

Thank you @nashant!
Please remove build/deploy-image.sh as it is not used anymore.

I've removed the cleanup too, that wasn't being used either

Closes #13

authors: nashant vassilvk

repo: kubemod/kubemod-crt


text:
Add GKE support

(and small cleanup)

Nicely done!

authors: telepenin ynnt

repo: kuberlogic/kuberlogic


text:
Authorization

What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
Documentation:

Does this PR introduce a user-facing change?:

NONE

Why do we need this exactly? Why not just perform the operation in the users name and let the k8s handle if it's allowed or not?

/retest

/retest

/hold

/lgtm

/retest

/lgtm

/unhold

/retest

/retest

/retest

/lgtm

/test pull-kubecarrier-e2e-v1.17
/test pull-kubecarrier-e2e-v1.16

/retest

/retest

/test pull-kubecarrier-e2e-v1.16

/retest

/retest

/retest

/retest

authors: jiachengxu nmiculinic thetechnick

repo: kubermatic/kubecarrier


text:
Fix multiple load balancers in one tenant

What this PR does / why we need it:
This PR fixes having multiple load balancer for a single tenant. If you continue after checking if the addressesMap, no second cluster and listener(s) will be created leaving only a single service on the load balancer.
Which issue(s) this PR fixes:

Fixes #
What type of PR is this?
/kind bug
Special notes for your reviewer:
This blocks a customer, a fast review would be appreciated.
Does this PR introduce a user-facing change? Then add your Release Note here:

Fix a bug that prevented multiple load balancer from a single tenant.

Documentation:

NONE

/ok-to-test

/retest

authors: embik jan-walther

repo: kubermatic/kubelb


text:
Update machine-controller to v1.56.4

What this PR does / why we need it:
Update machine-controller to the latest v1.56 release (v1.56.4). OSM is already at the latest v1.2 release (v1.2.2).
What type of PR is this?
/kind chore
Does this PR introduce a user-facing change? Then add your Release Note here:
Update machine-controller to v1.56.4

Documentation:
NONE

/assign @kron4eg

/approve
/lgtm

cc @kubermatic/sig-release-managers

repo: kubermatic/kubeone


text:
Remove Windows versions 1909 and 2004 which have reached EOL

/hold
/cc @jingxu97 @pohly @andyzhangx
Removing support for some Windows versions that have reached EOL https://endoflife.date/windows, the versions that we still maintain are ltsc2019, 20H2 and ltsc2022.
I think we could merge this in 1.24.

/approve

/release-note-none

/remove-hold

authors: mauriciopoppe pohly

repo: kubernetes-csi/csi-release-tools


text:
Support mount propagation.

We should support mount propagation after CRI supports it https://github.com/kubernetes/kubernetes/pull/46444.

kubernetes/kubernetes#46444 is going to be merged soon. We should update kubernetes version and support it after it is merged.

The Kubernetes PR has been merged. We should add the mount propagation support.
Feel free to grab this one if you are interested @yanxuean @miaoyq. :)

I don't understand this PR, Can you give me more detail.

@Random-Liu @yanxuean  I will work for this.

@Random-Liu  First of all, we should sync k8s.io/kubernetes/staging/src/k8s.io/api to k8s.io/api project.
Cloud you help me sync this?  I don't have permission.

@miaoyq Hm, their bot is broken, we may have to wait for them to sync.

@miaoyq @yanxuean I've sent Collaborators invitation to you, so that I could assign issue to you. :)

@Random-Liu  Looks like we don't need to update api, the change is used in k8s.
I have created a pr for this.

authors: Random-Liu miaoyq yanxuean

repo: kubernetes-incubator/cri-containerd


text:
Release v1.9.11

@rhatdan @runcom @umohnani8 PTAL

LGTM, assuming happy tests.

speak of the devil, happy green test buttons.

LGTM

Merging.

@mrunalp You need to create a Tag and a Release.

LGTM

authors: TomSweeneyRedHat mrunalp rhatdan runcom umohnani8

repo: kubernetes-incubator/cri-o


text:
Google Cloud: Error 403: Request had insufficient authentication scopes

Hello! Could you please help me to figure out what I do in wrong way?
I'm creating External-Dns resources (serviceaccount, ) according to this readme:
https://github.com/kubernetes-incubator/external-dns/blob/master/docs/tutorials/gke.md
First I create clusterrolebinding for my account like:
kubectl create clusterrolebinding your-user-cluster-admin-binding --clusterrole=cluster-admin --user=your.google.cloud.email@example.org

Then I'm applying the manifest for clusters with RBAC.
After this I observe logs in external-dns pod and always getting the following type of errors:
time="2018-08-27T12:08:53Z" level=error msg="googleapi: Error 403: Request had insufficient authentication scopes., forbidden"

Please help me to understand what am I doing wrong.

How did you create the cluster? I don't have much experience with GCP/GKE
but this looks like an issue with the nodes permission. It might have to do
with the following  --scopes " https://www.googleapis.com/auth/ndev.clouddns.readwrite".
On Mon, Aug 27, 2018 at 2:23 PM PavelKarpenka notifications@github.com
wrote:

Hello! Could you please help me to figure out what I do in wrong way?
I'm creating External-Dns resources (serviceaccount, ) according to this
readme:
https://github.com/kubernetes-incubator/external-dns/blob/master/docs/tutorials/gke.md
First I create clusterrolebinding for my account like:
kubectl create clusterrolebinding your-user-cluster-admin-binding --clusterrole=cluster-admin --user=your.google.cloud.email@example.org
Then I'm applying the manifest for clusters with RBAC.
After this I observe logs in external-dns pod and always getting the
following type of errors:
time="2018-08-27T12:08:53Z" level=error msg="googleapi: Error 403: Request had insufficient authentication scopes., forbidden"
Please help me to understand what am I doing wrong.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/kubernetes-incubator/external-dns/issues/690, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AApv1PuxPBQNmTKAOMzw5ne3musc-A1iks5uU-SzgaJpZM4WNsPN
.

--
Raffaele Di Fazio

@Raffo thank you!
I recreated my cluster with correct scopes and everything works.
Thanks a lot again!

No problem! Closing the issue 😉

authors: PavelKarpenka Raffo

repo: kubernetes-incubator/external-dns


text:
Add aws-evaluate-target-health flag

This is to add a new --aws-evaluate-target-health which allows the
user to override the default EvaluateTargetHealth value (currently set
to true) when creating AWS Route53 ALIAS records. To disable, pass
--no-aws-evaluate-target-health as outlined in the help page.
Closes https://github.com/kubernetes-incubator/external-dns/issues/627

/lgtm

authors: hjacobs peterbale


text:
How to add noresvport to mount NAS

How to add noresvport to mount NAS ？

same question

authors: willmao zhuhelei

repo: kubernetes-incubator/external-storage


text:
Verify if br_netfilter module exists

Fixed #1272
In the installation process of Weave network plugin, br_netfilter module is loaded unconditionally. (#1152)
When br_netfilter module is built-in to the kernel and not a loadable kernel module, the installation process fails.
I added a task to verify whether br_netfilter is a loadable kernel module.

I have signed the CLA.

ci check this

It seems like that Pipeline #10488388 is Passed, but the status of this PR is failed.
Is there anything I should do?

@shiftky CI reports failure often. It's something we need to fix still.

authors: bradbeam mattymo shiftky

repo: kubernetes-incubator/kubespray


text:
cert-manager: Add version label to pod

Add image_tag as pod version label

@ant31 i just simplify this PR for adding version label, please review


text:
Use field selector for broker delete

Make use of field selectors when deleting brokers

Looks like the tests didn't work though:
Deleting broker...
clusterservicebroker "ups-broker" deleted
Waited unsuccessfully for no occurrence of "4f6e6cf6-ffdd-425f-a2c7-3c9258ad2468" in: "NAME                                   KIND
4f6e6cf6-ffdd-425f-a2c7-3c9258ad2468   ClusterServiceClass.v1alpha1.servicecatalog.k8s.io"
NAME                                   KIND
4f6e6cf6-ffdd-425f-a2c7-3c9258ad2468   ClusterServiceClass.v1alpha1.servicecatalog.k8s.io
/var/lib/jenkins/workspace/service-catalog-PR-testing2/src/github.com/kubernetes-incubator/service-catalog/contrib/jenkins/test_walkthrough.sh: line 222: Service classes not successfully removed upon deleting ups-broker. (exit 1)

Yeah, I found a bug with the field selector on ServiceClass; fixed and added a test.

authors: pmorie vaikas-google

repo: kubernetes-incubator/service-catalog


text:
Service created for kubernetes api access may add other cluster as endpoint

/kind bug
When multiple workload cluster created on the same management cluster, the service created for workload cluster api access may add other cluster as endpoint, because of the in-proper selector is using.
For example, I have two cluster been created and  kvcluster01 and kvcluster02 on the same management cluster
root@ny5-infra04:~# kubectl get svc
NAME                                 TYPE           CLUSTER-IP       EXTERNAL-IP     PORT(S)          AGE
kvcluster01-lb                       LoadBalancer   10.109.112.46    10.223.31.231   6443:30255/TCP   77m
kvcluster02-lb                       LoadBalancer   10.109.43.60     10.223.31.235   6443:31612/TCP   66m

Name:                     kvcluster01-lb
Namespace:                default
Labels:                   cluster.x-k8s.io/cluster-name=kvcluster01
Annotations:              <none>
Selector:                 cluster.x-k8s.io/role=control-plane.  <<<
Type:                     LoadBalancer
IP Family Policy:         SingleStack
IP Families:              IPv4
IP:                       10.109.112.46
IPs:                      10.109.112.46
LoadBalancer Ingress:     10.223.31.231
Port:                     <unset>  6443/TCP
TargetPort:               6443/TCP
NodePort:                 <unset>  30255/TCP
Endpoints:                10.244.1.135:6443,10.244.2.13:6443
Session Affinity:         None
External Traffic Policy:  Cluster
Events:                   <none>

Name:                     kvcluster02-lb
Namespace:                default
Labels:                   cluster.x-k8s.io/cluster-name=kvcluster02
Annotations:              <none>
Selector:                 cluster.x-k8s.io/role=control-plane.  <<<<
Type:                     LoadBalancer
IP Family Policy:         SingleStack
IP Families:              IPv4
IP:                       10.109.43.60
IPs:                      10.109.43.60
LoadBalancer Ingress:     10.223.31.235
Port:                     <unset>  6443/TCP
TargetPort:               6443/TCP
NodePort:                 <unset>  31612/TCP
Endpoints:                10.244.1.135:6443,10.244.2.13:6443
Session Affinity:         None
External Traffic Policy:  Cluster
Events:                   <none>

Both cluster control node has the same label  cluster.x-k8s.io/role=control-plane, so this is not enough to identify each cluster.
root@ny5-infra04:~# kubectl get vmi  --show-labels
NAME                              AGE    PHASE     IP             NODENAME      READY   LABELS
kvcluster01-control-plane-c4tjz   81m    Running   10.244.2.13    ny5-infra06   True    cluster.x-k8s.io/role=control-plane,kubevirt.io/nodeName=ny5-infra06,kubevirt.io/vm=kvcluster01-control-plane-c4tjz,name=kvcluster01-control-plane-c4tjz
kvcluster02-control-plane-7zzsc   69m    Running   10.244.1.135   ny5-infra05   True    cluster.x-k8s.io/role=control-plane,kubevirt.io/nodeName=ny5-infra05,kubevirt.io/vm=kvcluster02-control-plane-7zzsc,name=kvcluster02-control-plane-7zzsc

From endpoint list you can see each service add both cluster as endpoint because of selector.
root@ny5-infra04:~# kubectl get ep
NAME                                 ENDPOINTS                            AGE
kvcluster01-lb                       10.244.1.135:6443,10.244.2.13:6443   78m
kvcluster02-lb                       10.244.1.135:6443,10.244.2.13:6443   66m

Kubectl command may fail because the request may loadbalancing to differnet cluster.
root@ny5-infra04:~# KUBECONFIG=kubeconfig.yaml kubectl get node
NAME                              STATUS   ROLES                  AGE   VERSION
kvcluster01-control-plane-c4tjz   Ready    control-plane,master   76m   v1.21.0
kvcluster01-md-0-zfsvc            Ready    <none>                 75m   v1.21.0
root@ny5-infra04:~# KUBECONFIG=kubeconfig.yaml kubectl get node
Unable to connect to the server: x509: certificate is valid for 10.96.0.1, 10.244.1.135, 10.109.43.60, not 10.223.31.231

Fix merged, close the issue.


text:
Incorporate logging guide

Publish Logging Conventions within https://k8s.dev/
/kind feature
/sig instrumentation
/sig contributor-experience

We want to add the whole developer guide, but much of the content is not in a state that should be published. An audit is in the works (https://github.com/kubernetes/community/issues/5229), and either alongside that audit or after need to think about information organization.

@sftim thanks for the tag! This should get covered as part of the structured logging migration. I'll make sure there's an issue open for it

authors: ehashman mrbobbytables sftim

repo: kubernetes-sigs/contributor-site


text:
Accept detach sequence for attached containers

What would you like to be added:
This is the continuation of a feature request that was made in the containerd project.
When running crictl attach -i -t, there should be a way to detach from the session without ending the process.
Docker provides a way to detach from an attached container, using a specified key sequence (the default key sequence
being ctrl-p ctrl-q). This could be implemented in the crictl tool as well.
Why is this needed:
Improves user experience and usability. See this feature request in the containerd repository for more details.

/remove-lifecycle rotten

repo: kubernetes-sigs/cri-tools


text:
Equivalent docker cp command

What would you like to be added:
docker cp similar command to sync files between a container and host file system.
Why is this needed:
Very often there is a need to copy files around. I couldn't find the equivalent command in crictl.

Hey @honnix. thank you for the feature request. Unfortunately the Container Runtime Interface (CRI) does not support that functionality. crictl only implements this interface and kinda mimics partly the kubelet's interface. I think sticking to kubectl cp might be the best alternative here.

@saschagrunert Thanks for explaining! Yeah that is indeed the best alternative, although the limitation of kubectl cp is annoying for certain cases.

Looking to debug a connectivity issue in a container built on scratch by copying in a shell. Issue with kubectl cp is it utilizes tar, which is also not present :)
Figured I'd see if there was any ideas here as it's the place I keep landing back on.

Looking to debug a connectivity issue in a container built on scratch by copying in a shell. Issue with kubectl cp is it utilizes tar, which is also not present :)
Figured I'd see if there was any ideas here as it's the place I keep landing back on.

@CharlyRipp did you find an alternative way to copy files without using kubectl cp ?
I am trying to copy a file to a distroless container which is missing tar, vi, sed and most other tools.
I only have cat, tee and echo.

authors: Ahmad-Faizan CharlyRipp honnix saschagrunert


text:
Add pod.Status.Reason to the list of reasons

Hello,
I noticed that RemoveFailedPods strategy is actually not checking reason in pod status.
This causes that pods in the state like in the example below are ignored by the policy.
status:
  message: Node is shutting, evicting pods
  phase: Failed
  reason: Shutdown

This MR updates the reasons so descheduler can evict Shutdown pods.
Example of the policy:
    strategies:
      "RemoveFailedPods":
        enabled: true
        params:
          failedPods:
            excludeOwnerKinds:
            - Job
            includingInitContainers: true
            reasons:
            - Shutdown

/check-cla

Thank you. TBH I am not sure what is the best way to set reason in buildTestPod. Will think about it, but meanwhile I've added 2 simple unit tests to see it "in the action".

Of course. Commits squashed.

/lgtm
/approve

authors: damemi ingvagabund kirecek

repo: kubernetes-sigs/descheduler


text:
Add a new API Types Page

What would you like to be added:
It would be great to have a new API Types overview page at https://gateway-api.sigs.k8s.io/api-types/ for Gateway API that had a similar structure to https://kubernetes.io/docs/reference/kubernetes-api/ and linked out to each of our individual API Type docs. This page could then be linked from kubernetes.io docs. To accomplish this we'd need to add a new index page to site-src/api-types.
Why this is needed:
This would enable better integration with kubernetes.io documentation, as suggested by @sftim in Slack: https://kubernetes.slack.com/archives/CR0H13KGA/p1697817925108689.

No need to copy the structure of https://kubernetes.io/docs/reference/kubernetes-api/ too closely - that layout there is a work in progress.

authors: robscott sftim

repo: kubernetes-sigs/gateway-api


text:
Make gwctl work with Policies having multiple targetRefs

As per recent updates to the Policy related GEPs in https://github.com/kubernetes-sigs/gateway-api/discussions/2927#discussioncomment-8991869, Policies are now allowed to target multiple resources i.e. targetRefs (which previously was limited to a single targetRef).
Make gwctl work with this new pattern. Common places that need to be updated include:

Displaying/handling multiple resources appropriately when using gwctl get policies
Code changes required within https://github.com/kubernetes-sigs/gateway-api/blob/28e408013bd1084ca731e1a4559e38234d235182/gwctl/pkg/policymanager/manager.go#L277-L303

/area gwctl
/kind feature

Can I assign it to myself? I want to try it

Hi @deszhou, sure go ahead, though there's a few minor open questions here which may need to be ironed out. Like for example what exactly would the following output:
gwctl get policies

gwctl describe policies

Would be nice if you can give a sample of what you have in mind before diving deep

你好@deszhou当然可以，不过这里还有一些小问题需要解决。例如，以下输出到底是什么：
gwctl get policies

gwctl describe policies

如果你能在深入探讨之前给出一个示例，那就太好了

gwctl get policies -A

Indented Format:

NAME                          KIND                       TARGET NAME           TARGET KIND     POLICY TYPE  AGE
health-check-gateway          HealthCheckPolicy.foo.com  foo-gateway           Gateway         Inherited    20d
                                                         foo-gatewayclass      GatewayClass    Inherited    20d
timeout-policy-gatewayclass   TimeoutPolicy.bar.com      foo-gatewayclass      Gatewayclass    Direct       5m
timeout-policy-httproute      TimeoutPolicy.bar.com      foo-httproute         HTTPRoute       Direct       13m

Comma-Separated Format:

NAME                          KIND                       TARGET REFS                                            POLICY TYPE  AGE
health-check-gateway          HealthCheckPolicy.foo.com  foo-gateway (Gateway),foo-gatewayclass (GatewayClass)  Inherited    20d
timeout-policy-gatewayclass   TimeoutPolicy.bar.com      foo-gatewayclass (Gatewayclass)                        Direct       5m
timeout-policy-httproute      TimeoutPolicy.bar.com      foo-httproute (HTTPRoute)                              Direct       13m

gwctl describe policies health-check-gateway

Name: health-check-gateway
Group: foo.com
Kind: HealthCheckPolicy
Inherited: "true"
Spec:
  ...
  targetRefs:
	 - group: gateway.networking.k8s.io
	   kind: Gateway
	   name: foo-gateway
	 - group: gateway.networking.k8s.io
	   kind: GatewayClass
	   name: foo-gatewayclass

Which of these two output formats do you think is better for gwctl get policies, or do you have any suggestions for improving the output format?

Hi @deszhou, sure go ahead, though there's a few minor open questions here which may need to be ironed out. Like for example what exactly would the following output:
gwctl get policies

gwctl describe policies

Would be nice if you can give a sample of what you have in mind before diving deep

gwctl get policies -A

Indented Format:

NAME                          KIND                       TARGET NAME           TARGET KIND     POLICY TYPE  AGE
health-check-gateway          HealthCheckPolicy.foo.com  foo-gateway           Gateway         Inherited    20d
                                                         foo-gatewayclass      GatewayClass    Inherited    20d
timeout-policy-gatewayclass   TimeoutPolicy.bar.com      foo-gatewayclass      Gatewayclass    Direct       5m
timeout-policy-httproute      TimeoutPolicy.bar.com      foo-httproute         HTTPRoute       Direct       13m

Comma-Separated Format:

NAME                          KIND                       TARGET REFS                                            POLICY TYPE  AGE
health-check-gateway          HealthCheckPolicy.foo.com  foo-gateway (Gateway),foo-gatewayclass (GatewayClass)  Inherited    20d
timeout-policy-gatewayclass   TimeoutPolicy.bar.com      foo-gatewayclass (Gatewayclass)                        Direct       5m
timeout-policy-httproute      TimeoutPolicy.bar.com      foo-httproute (HTTPRoute)                              Direct       13m

gwctl describe policies health-check-gateway

Name: health-check-gateway
Group: foo.com
Kind: HealthCheckPolicy
Inherited: "true"
Spec:
  ...
  targetRefs:
     - group: gateway.networking.k8s.io
        kind: Gateway
        name: foo-gateway
     - group: gateway.networking.k8s.io
        kind: GatewayClass
	name: foo-gatewayclass

Which of these two output formats do you think is better for gwctl get policies, or do you have any suggestions for improving the output format?

Let's choose the "comma-separated one" which is consistent with others. Let's just display 2 targets and then +n more pattern.
Though the other one also seems good but we can revisit this later.

/assign

@gauravkghildiyal we should transfer this over to the gwctl repository as well.

Moved to https://github.com/kubernetes-sigs/gwctl/issues/1
/close

authors: deszhou gauravkghildiyal shaneutt


text:
conformance: Add Conformance report for cilium

The conformance tests are run with Cilium v1.14.0.

What type of PR is this?
/area conformance
What this PR does / why we need it:
This PR is to add the conformance report for Cilium version v1.14.0.
Which issue(s) this PR fixes:

NA
Does this PR introduce a user-facing change?:

NONE

/approved

/ok-to-test

Thanks @sayboras!
/lgtm
/approve

authors: robscott sayboras youngnick


text:
Add ParametersRef to Gateway.spec.infrastructure

What type of PR is this?
/kind gep
What this PR does / why we need it:
Follow up to https://github.com/kubernetes-sigs/gateway-api/pull/1868, which was down-scoped to only include labels and annotations to reduce friction on the initial GEP
Which issue(s) this PR fixes:

Fixes #
Does this PR introduce a user-facing change?:

A new `parametersRef` field has been added to `Gateway.spec.infrastructure`. This allows configuration of arbitrary implementation-specific parameters. This field previously existed only on `GatewayClass`.

@mikemorris from my POV this is good enough to close #567

I'm still a little worried that this will drop the incentive for people to bring further changes to infrastructure upstream (since you can now do whatever you want in your own paramsRef), but not enough to hold off on this. I would really like to see us consider what things end up in custom paramsRef objects that should be lifted out into standard infrastructure fields instead.
That said,
/approve

fwiw I don't think we have plans to implement paramsref in istio in the near term so we are incentivezed to keep pushing for first class fields once this lands :-)

/assign @robscott

/lgtm

authors: howardjohn robscott youngnick


text:
WIP: add integration test where service/job are created before jobset

Fixes #18
I am adding some integration tests to fix 18 but I am running into some trouble.
 2023-05-01T22:00:32Z  ERROR   creating jobs   {"controller": "jobset", "controllerGroup": "jobset.x-k8s.io", "controllerKind": "JobSet", "JobSet": {"name":"test-js","namespace":"test-ns-fp9mx"}, "namespace": "test-ns-fp9mx", "name": "test-js", "reconcileID": "c0982dd3-313f-45e7-9fda-b4192b6c00c5", "jobset": {"name":"test-js","namespace":"test-ns-fp9mx"}, "error": "jobs.batch \"test-js-replicated-job-b-2\" is forbidden: unable to create new content in namespace test-ns-fp9mx because it is being terminated"}
  sigs.k8s.io/jobset/pkg/controllers.(*JobSetReconciler).Reconcile
        /home/ec2-user/Work/GIT/jobset-kevin/pkg/controllers/jobset_controller.go:129
  sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Reconcile
        /home/ec2-user/go/1.20.2/pkg/mod/sigs.k8s.io/controller-runtime@v0.14.6/pkg/internal/controller/controller.go:122
  sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler
        /home/ec2-user/go/1.20.2/pkg/mod/sigs.k8s.io/controller-runtime@v0.14.6/pkg/internal/controller/controller.go:323
  sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem
        /home/ec2-user/go/1.20.2/pkg/mod/sigs.k8s.io/controller-runtime@v0.14.6/pkg/internal/controller/controller.go:274
  sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2
        /home/ec2-user/go/1.20.2/pkg/mod/sigs.k8s.io/controller-runtime@v0.14.6/pkg/internal/controller/controller.go:235
  2023-05-01T22:00:32Z  ERROR   creating jobs   {"controller": "jobset", "controllerGroup": "jobset.x-k8s.io", "controllerKind": "JobSet", "JobSet": {"name":"test-js","namespace":"test-ns-fp9mx"}, "namespace": "test-ns-fp9mx", "name": "test-js", "reconcileID": "2468a498-600d-4aa6-b240-fa7876de3b0b", "jobset": {"name":"test-js","namespace":"test-ns-fp9mx"}, "error": "jobs.batch \"test-js-replicated-job-b-2\" is forbidden: unable to create new content in namespace test-ns-fp9mx because it is being terminated"}
  sigs.k8s.io/jobset/pkg/controllers.(*JobSetReconciler).Reconcile

I am getting namespace being terminated when trying to create Jobs/Services before creating the jobservice.

@kannon92 Looks like you figured it out, what was the issue?

@kannon92 Looks like you figured it out, what was the issue?

I haven't actually.  No idea the problem.
The tests are just saying they passed without issue.

@kannon92 I've ran into this issue before but it seemingly self-resolved.. that is super weird, the BeforeEach() and AfterEach() should be taking care of the namespace creation/deletion correctly

/hold cancel

/cancel hold

repo: kubernetes-sigs/jobset


text:
Optionally delay job garbage collection

Add the job.gcDelay operator configuration property to delay the garbage collection of successful build and signing jobs.
Add the new kmm.node.kubernetes.io/gc-delay finalizer to all new jobs.
Only clear the finalizer after deletionTimestamp+gcDelay.
Fixes #572
/cc @yevgeny-shnaidman @mresvanis @ybettan

/hold

@qbarrand Why is it being held?

/unhold

/lgtm

authors: qbarrand ybettan


text:
migrate to discovery/v1

@uablrek @astoycos my take on topology migration. It also includes zone filtering so we get TopologyAwareHints support here. Node name relies on the EndpointSliceNodeName feature gate, which is GA since 1.21.
Fixes #317
Fixes #262

I applied this PR and applied it. Build works fine.
I was hoping that it would make [Feature:ServiceInternalTrafficPolicy] tests pass, but;
FAILED [sig-network] Services should respect internalTrafficPolicy=Local Pod (hostNetwork: true) to Pod [Feature:ServiceInternalTrafficPolicy]
FAILED [sig-network] Services should respect internalTrafficPolicy=Local Pod and Node, to Pod (hostNetwork: true) [Feature:ServiceInternalTrafficPolicy]
FAILED [sig-network] Services should respect internalTrafficPolicy=Local Pod to Pod [Feature:ServiceInternalTrafficPolicy]

@uablrek I've added a test to make sure service traffic policy was correctly forwarded to the global service model, and it is. Combined with the test in server/pkg/endpoints/node_test.go, there's some good confidence that the chain is correct. But then, the backend shouldn't even know about the other endpoints. #287 comes with a more precise job on this. Maybe we should report this issue after all this is merged?

/hold pulls #319

/unhold

authors: mcluseau uablrek

repo: kubernetes-sigs/kpng


text:
Preempted RayJob will not resume when resource reclaimed

What happened:
I tried with rayJob, but I guess this applies to other jobs as well. Correct me if not.
So when a lower priority rayJob preempted by a higher one and the higher rayJob completed, the lower priority rayjob will not resume.
What you expected to happen:
Resume when resource is sufficient.
How to reproduce it (as minimally and precisely as possible):

Inside a clusterQueue, configured with preemption.withinClusterQueue=LowerPriority
submit a low priority rayjob
submit a high priority rayjob, since resource is insufficient, the high priority rayjob will preempted the lower one.
when the high priority rayjob completed, the lower one will not resume.

Anything else we need to know?:
Environment:

Kubernetes version (use kubectl version):
Kueue version (use git describe --tags --dirty --always):
Cloud provider or hardware configuration:
OS (e.g: cat /etc/os-release):
Kernel (e.g. uname -a):
Install tools:
Others:

We saw this exact problem in Jobset, but it turned out that Jobset didn't have permission to update/patch jobs.
Maybe there's a problem in the rayjob implementation of suspend?

Or maybe it's a problem in the integration controller, but I don't think this problem is generalized for all jobs

It's a bug of rayjob controller, also maybe related to the upstream ray, but let me focus on kueue at first.
/assign

authors: alculquicondor kerthcet

repo: kubernetes-sigs/kueue


text:
update readme and sample

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
remove unused contents in readme and sample. make it clean for users.
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:

/retest

/lgtm
/approve

authors: ahg-g denkensk


text:
[KEP] Add retry strategy to the ProvisionigRequestConfig API

What type of PR is this?
/kind documentation

What this PR does / why we need it:
Introduces configurable retry strategy for ProvisioningRequests
Which issue(s) this PR fixes:

Fixes #1353
Special notes for your reviewer:
Does this PR introduce a user-facing change?

NONE

/assign @mimowo
cc @mwielgus @yaroslava-serdiuk @tenzen-y @trasc

/cc

RE: https://github.com/kubernetes-sigs/kueue/pull/3278#discussion_r1808678982
I discussed the necessity for the requeue: true | false field with @PBundyra offline.
In conclusion, we decided not to introduce the field and introduce the KeepQuotaForProvReqRetry feature gate to the existing Retry mechanism as a deprecated default disabled feature gate, then we will completely remove the KeepQuotaForProvReqRetry in the v0.10 or v0.11 so that we can give users a reprieve period. This could be justified since the CA ProvisioningRequest API is still in the alpha stage, and Kueue integration could potentially be broken.
So, if they keep wanting a proper migration period, they need to enable the KeepQuotaForProvReqRetry feature gate, obviously.
@PBundyra Could you add ACTION REQUIRED to the release note in the implementation PR (not this PR)?

/hold cancel

authors: PBundyra tenzen-y trasc


text:
Environment variables should be inherited afresh each time I do kui shell

I type kui shell for the first time on my terminal, and kui starts and inherits all the environment variables defined at that point in time
I close the kui window, go back to the terminal and create a new environment variable by export FOO=BAR
I reopen the kui window by typing kui shell. This time, it does not inherit the variable FOO
If go to my dock, and quit kui, and then retype kui shell in the terminal, it picks up the environment variable FOO

Desired feature: It would good not to have to quit kui in 4. above. When I type kui shell, the kui window that comes up needs to pickup the environment variables at that point in time

i see, thanks for this report. i believe what is happening here is that the main electron process stays up  after you close all kui windows. this seems to be a regression, as it is not the intended behavior.

ah, i see. this is not a regression, i was thinking of work from another branch that never got merged. thanks again for the report.

update: we have a few options right now, none ideal.

kill the electron process when the last window closes; the consequence of this is that users will not see any amortization of the costs of launching electron; this also won't address the problem of passing environment updates if you have a window already open.

stop using a single electron process; this will result in bloat (one full chromium per kui window)

use a self-managed mechanism for passing env var updates back to the main process; we can use the filesystem as a conduit for this, as long as we pay some care to concurrency issues

the self-managed part of 3 is necessitated by a gap in the current electron API; the second-instance event does not pass the environment variable map of the second process to the first (it does pass the second's commandLine and workingDirectory). see https://github.com/electron/electron/issues/18434

/remove-lifecycle rotten
Electron finally has the support we need for this.

This was fixed a while back in #8858 The fix should be live in the latest builds.

authors: sriumcp starpit

repo: kubernetes-sigs/kui


text:
Support get status of all clusters (stop or running) when execute 'kwokctl get clusters'

What would you like to be added?
When i execute 'kwokctl get clusters', i can know the status of every cluster.
Why is this needed?
Like kubectl get node, i think kwokctl get clusters also need status(running or stop)

To do this, it may be necessary to split it into two items

Implementing the ability to get detailed status information about individual clusters
And then there's this, which displays abbreviated status information for each cluster in a list.

I don't have enough bandwidth, Let's add it to the milestone. 😄

/assign

/remove-lifecycle rotten

authors: forgocode hangscer8 wzshiming

repo: kubernetes-sigs/kwok


text:
Restructure handle() in the namespace validator

Split handle() and checkForest() into smaller functions.
Tested manually and by make test.
Part of #847

/assign @adrianludwin
/assign @rjbez17
/cc @GinnyJI @adrianchung

Thanks for the suggestion I used the 1st one you suggested. As for the 2nd, they do always use the same parameters, but some of the checkers don't need both. They may only use either req or ns. @adrianludwin

/approve

repo: kubernetes-sigs/multi-tenancy


text:
tests: Run the flaky tests, too

What type of PR is this?
/kind bug

What this PR does / why we need it:
Turns out that my previous patch to run the flaky tests was incomplete.
We need some more changes:
- the testify.m parameter must be, for some reason, specified last
or else the go test call fails with "no Go files in XYZ".
- after the namespaced tests (last in the regular non-flaky tests),
we need to reset the namespace or else we test everything in the
test-ns namespace
- we need to tear down the operator after the namespaced tests to
be able to roll it out again in the flaky tests
The tests are still flaky, but at least they run now.
Which issue(s) this PR fixes:
None

Does this PR have test?
implicit

Special notes for your reviewer:
N/A
Does this PR introduce a user-facing change?

NONE

Codecov Report

Merging #1153 (0f255a1) into main (7d5b719) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1153   +/-   ##
=======================================
  Coverage   50.70%   50.70%
=======================================
  Files          42       42
  Lines        4753     4753
=======================================
  Hits         2410     2410
  Misses       2266     2266
  Partials       77       77

authors: codecov-commenter jhrozek


text:
Adds ServicePort field to HTTPRouteAction API type

Adds a ServicePort field to the HTTPRouteAction API type. Previously, the HTTPRoute resource did not provide the ability to specify a destination port to use when forwarding a request to a backend Service resource. This capability is present in Ingress v1 and should be supported by Service APIs.
This PR also includes a regenerated gatewayclasses CRD missing from PR #126.
Fixes Issue https://github.com/kubernetes-sigs/service-apis/issues/48.
/assign @bowei
/cc @robscott @Miciah @jpeach

/retest

This PR also includes a regenerated gatewayclasses CRD missing from PR #126.

Could you make a stand-alone PR with just that change? that makes it easier to reconstruct history and understand why changes were made.
I thought that there was a CI job that would prevent the generated files going stale?

Could you make a stand-alone PR with just that change? that makes it easier to reconstruct history and understand why changes were made.

@jpeach done with PR https://github.com/kubernetes-sigs/service-apis/pull/145.

I've been thinking about the easy path with this problem.
While we have forwardTo and extensions in that HTTPRouteAction, does it make sense to have a port and serviceName as another fields under forwardTo?
I feel that the most common use case will be routing traffic to k8s services and putting in the object reference to service seems a little verbose to me (writing out kind, apiVersion etc).
Thoughts?

@hbagdi I refactored the PR, PTAL.

/lgtm

Thanks!
/lgtm

/approve

/retest

authors: bowei danehans hbagdi jpeach robscott

repo: kubernetes-sigs/service-apis


text:
added override to use the right persistent volume

The kafka command line use the log.dirs from the server.properties which put the logs (data) into /tmp/kafka-logs by default.
As we want to use the persistent volume mounted in the container (defined in the value file to /opt/kafka/data), I added an override on the command line.

CLA signed !

/cc @faraazkhan

/ok-to-test

repo: kubernetes/charts


text:
Create secret issue

Hi, I am trying to create a secret as below:
newSecret := &v1.Secret{
ObjectMeta: metav1.ObjectMeta{
Name:      secretName,
Namespace: namespace,
},
Data: map[string][]byte{
"sslTruststoreLocationMountFolder": []byte(jks.sslTruststoreLocationMountFolder),
"sslTruststoreLocation":            []byte(jks.sslTruststoreLocation),
"sslTruststorePassword":            []byte(jks.sslTruststorePassword),
"truststore.jks":                    []byte(jks.truststore),
},
The issue is I do not want the go client to base64 encode the value in the field truststore.jks. How can I achieve this. I want the value in the field to remain as string. Pls help

json-encoding of []byte is base64-encoded, and there is no way to avoid that. When mounted into a pod, the content is base64-decoded so that the original byte content is placed in a file inside the pod
/close

repo: kubernetes/client-go


text:
update tags and vendor for 1.26

needed for release 1.26.3
Release note:

NONE

/test openstack-cloud-controller-manager-e2e-test-release-126
/test openstack-cloud-csi-manila-e2e-test-release-126
/test openstack-cloud-csi-cinder-sanity-test-release-126
/test openstack-cloud-csi-manila-sanity-test-release-126

/test openstack-cloud-controller-manager-e2e-test-release-126
/test openstack-cloud-csi-manila-e2e-test-release-126
/test openstack-cloud-csi-cinder-sanity-test-release-126
/test openstack-cloud-csi-manila-sanity-test-release-126

cc @jichenjc

@zetaab so I assume we first get this in, then we should have 1.26.3 .. then we trigger another CI and lucky we should pass the CI for cinder?

Yup

/override openstack-cloud-csi-cinder-e2e-test-release-126
/override openstack-cloud-csi-manila-e2e-test-release-126
/lgtm
/approve

authors: jichenjc zetaab

repo: kubernetes/cloud-provider-openstack


text:
Improve Keystone Application Credential docs

What this PR does / why we need it:
It adds documentation for the changes pushed in #282

/lgtm

/lgtm

/lgtm

/approve

authors: adisky jichenjc lingxiankong ramineni zioproto


text:
[ansible] Insure PyYAML module is installed for the master role.

From kubernetes/kubernetes#37352.
A user was using the ansible repo but failed to start kube-dns using Addon Manager. Turned out his cluster was based on CentOS 7 and did not have PyYAML module installed (this module is needed by Addon Manager to parse out objects from yaml files). Addon manager's logging might not be good so it was not obviously showing what was wrong.
We may insure PyYAML module is installed for the master role to make sure kube-dns could be managed by the Addon Manager. Manually create kube-dns works but it is not desired.
@eparis @ingvagabund

Looking into kubernetes-addons role, the PyYAML is installed (roles/kubernetes-addons/tasks/generic-install.yml):
- name: Set pyyaml package name
  set_fact:
    pyyaml_name: python-yaml

- name: Overwrite pyyaml package name for non-Debian
  set_fact:
    pyyaml_name: PyYAML
  when: ansible_distribution != "Debian" and ansible_distribution != "Ubuntu"

- name: Install PyYAML for non-debian
  action: "{{ ansible_pkg_mgr }}"
  args:
    name: "{{ pyyaml_name }}"
    state: latest

Looking into one of the CentOS CI ansible deployment [1], the PyYAML is installed as well:
TASK [kubernetes-addons : Set pyyaml package name] *****************************
ok: [10.8.175.180]

TASK [kubernetes-addons : Overwrite pyyaml package name for non-Debian] ********
ok: [10.8.175.180]

TASK [kubernetes-addons : Install PyYAML for non-debian] ***********************
ok: [10.8.175.180]

[1] https://console.cloud.google.com/m/cloudstorage/b/kubernetes-contrib-github-redhat/o/pr-logs/pull/2033/kubernetes-pull-build-redhat-tests/6/index.html

@MrHohn, can you share the kubernetes-addons role logs to see if the PyYAML is installed or not?

@ingvagabund Thanks for the investigation!
Ping @mootezbessifi for the logs. Original issue : kubernetes/kubernetes/issues/37352

Seems like this issue is getting stale. Closing it for now.

Sorry for the delay,
Unfortunately, i installed PyYaml package into my CentOS7 with 'yum' package manager but the problem persists.
the mentioned generic-install does not resolve the mentioned problem in    kubernetes/kubernetes#37352.
when i tried to import the yaml into python as mentioned in kube-addon-update.sh an error was occured and the import fails.
The solution which i found suitable, is to write roles to install LibYaml and PyYaml like following:
#LibYaml installation

stat: path=/opt/yaml-{{ libyaml_version }}
register: st
name: Download LibYaml tar file
get_url:
url: "{{ libyaml_download_url }}"
dest: "/opt"
validate_certs: False
environment:
http_proxy: "{{ http_proxy|default('') }}"
https_proxy: "{{ https_proxy|default('') }}"
no_proxy: "{{ no_proxy|default('') }}"
when: st.stat.isdir is not defined
tags: download_libyaml
name: Extract tar file
unarchive:
src: "/opt/yaml-{{ libyaml_version  }}.tar.gz"
dest: "/opt"
copy: no
when: st.stat.isdir is not defined
name: Build and Install LibYaml
command: "{{ item }} chdir=/opt/yaml-{{ libyaml_version }}"
with_items:

./configure
make
make install

#PyYaml installation

stat: path=/opt/PyYAML-{{ yaml_version }}
register: st
name: Download PyYAML tar file
get_url:
url: "{{ yaml_download_url }}"
dest: "/opt"
validate_certs: False
environment:
http_proxy: "{{ http_proxy|default('') }}"
https_proxy: "{{ https_proxy|default('') }}"
no_proxy: "{{ no_proxy|default('') }}"
when: st.stat.isdir is not defined
tags: download_PyYAML
name: Extract tar file
unarchive:
src: "/opt/PyYAML-{{ yaml_version }}.tar.gz"
dest: "/opt"
copy: no
when: st.stat.isdir is not defined
name: Install PyYaml
command: python setup.py install chdir="/opt/PyYAML-{{ yaml_version }}"

Please @MrHohn  reopen the issue. it is not really resolved yet.
PS: sorry for the messy ansible roles format. i have an uploading issue in my network company.

Hi,
I'm facing this issue. I installed kubernetes 1.7 version using packagemanager in Azure. After running the scripts, I get the below errors in journalctl -xe. Pods in namespace=kube-system are ultimately getting created, but only after 7 to 10 minutes of the cluster getting created. Since, I am running automation, and the kube-dns service needs to be available immediately, I'm facing issues. Could you please guide me in resolving this?
Sep 08 15:02:15 k8s-0 kube-addons.sh[28965]: Error from server (AlreadyExists): error when creating "STDIN": secrets "token-system-scheduler-k8srandom0.eastus.cloudapp.azure.com" already exists
Sep 08 15:02:15 k8s-0 kube-addons.sh[28965]: == Failed to start Secret-for-token-for-user-system:scheduler-k8srandom0.eastus.cloudapp.azure.com in namespace kube-system at 2017-09-08T15:02:15+0
Sep 08 15:02:18 k8s-0 kube-addons.sh[28965]: Error from server (AlreadyExists): error when creating "STDIN": secrets "token-system-kubelet-k8srandom2.eastus.cloudapp.azure.com" already exists
Sep 08 15:02:18 k8s-0 kube-addons.sh[28965]: == Failed to start Secret-for-token-for-user-system:kubelet-k8srandom2.eastus.cloudapp.azure.com in namespace kube-system at 2017-09-08T15:02:18+000
Sep 08 15:02:18 k8s-0 kube-addons.sh[28965]: Error from server (AlreadyExists): error when creating "STDIN": secrets "token-system-kubectl-k8srandom0.eastus.cloudapp.azure.com" already exists
Sep 08 15:02:18 k8s-0 kube-addons.sh[28965]: == Failed to start Secret-for-token-for-user-system:kubectl-k8srandom0.eastus.cloudapp.azure.com in namespace kube-system at 2017-09-08T15:02:18+000
Sep 08 15:02:18 k8s-0 kube-addons.sh[28965]: Error from server (AlreadyExists): error when creating "/etc/kubernetes/addons/kube-dash/kube-dash-svc.yaml": services "kubernetes-dashboard" alread
Sep 08 15:02:18 k8s-0 kube-addons.sh[28965]: INFO: == Failed to execute /usr/bin/kubectl create --namespace=kube-system -f /etc/kubernetes/addons/kube-dash/kube-dash-svc.yaml at 2017-09-08T15:0

Thanks.

authors: MrHohn githubvick ingvagabund mootezbessifi

repo: kubernetes/contrib


text:
Request addition of "auto" TLS option

I would like to request the addition of some sort of configuration option that automatically acts as if --tls is enabled.  As an alternative, the subcommands which do not use the --tls flag could silently ignore its presence.
Rationale:
When interacting with helm manually, adding --tls on (almost) every command is cumbersome.
The simplest/least intrusive way to add a config option would probably be with an environment variable. HELM_USE_TLS or some such.
It would be possible to create a shell function/alias to add this for me, if it didn't cause local-only commands to then fail, due to the unrecognized option. Thus I would consider ignoring extraneous --tls flags as a reasonable alternative approach to solve the same problem.

https://github.com/kubernetes/helm/pull/3496

authors: bacongobbler flimzy

repo: kubernetes/helm


text:
Support for waiting on multiple deployments to complete and also support for timeouts

Is this a request for help?
No.
What keywords did you search in Kubernetes issues before filing this one?
rollout status

Is this a BUG REPORT or FEATURE REQUEST? (choose one):
FEATURE REQUEST
Kubernetes version (use kubectl version):
N/A
Environment:

Cloud provider or hardware configuration:
N/A
OS (e.g. from /etc/os-release):
N/A
Kernel (e.g. uname -a):
N/A
Install tools:
N/A
Others:
N/A

What happened:
% kubectl rollout status -w deployment/{foo,bar}
error: rollout status is only supported on individual resources and resource collections - 2 resources were found
%

% kubectl rollout status --help|grep -ci timeout
0
%

What you expected to happen:
I expected kubectl to wait until both deployments were complete and I also expected to be able to set a timeout.
How to reproduce it (as minimally and precisely as possible):
kubectl rollout status -w deployment/{foo,bar}
kubectl rollout status --help|grep -ci timeout
Anything else we need to know:
No.

/remove-lifecycle stale

/remove-lifecycle stale

/remove-lifecycle stale

/remove-lifecycle stale

/remove-lifecycle stale

/kind feature

I'd suggest checking kubectl wait since that'd be a better fit for multiple wait condition. If it doesn't support it would be a nice addition there. I don't think we will support multiple deployments in kubectl rollout status.
/close

authors: brianpursley soltysh wknapik

repo: kubernetes/kubectl


text:
Image Pull Secret on SA is not properly documented anywhere

http://kubernetes.io/docs/user-guide/images/#specifying-imagepullsecrets-on-a-pod

However, setting of this field can be automated by setting the imagePullSecrets in a serviceAccount resource.

No mention of how to do so or pointers at additional docs.
Worse yet:
http://kubernetes.io/docs/user-guide/kubectl/kubectl_create_secret_docker-registry/

When creating applications, you may have a Docker registry that requires authentication. In order for the nodes to pull images on your behalf, they have to have the credentials. You can provide this information by creating a dockercfg secret and attaching it to your service account.

And then the example that follows doesn't actually do the "attach it to your service account" part...

FWIW you can find the answer here: https://kubernetes.io/docs/tasks/configure-pod-container/configure-service-account/

Similar to #20910

authors: colemickens derfred sftim


text:
Small corrections how to curl eviction endpoint

@mml || @davidopp  ptal

This change is

@devin-donnelly updated, ptal


text:
Remove commas at the end of "containerPort"

"containerPort": 8000, should be "containerPort": 8000

@jaredbhatti Thanks for chipping in!

authors: jaredbhatti pwittrock