text:
Highlight newly added tests in TC bot visa

Changes are made by @sergeyuttsel.
Looks good to me.
@dspavlov, can you take a look as well?

Merged to masted manually

source: gharchive/pull-request

authors: dspavlov glukos

repo: apache/ignite-teamcity-bot

license_type: permissive

license_source: github-api


text:
ARIA-399: Added Dockerfile, docker-compose and README to execute ARIA in a container environment

Feedback was given by Tom N and Arthur to move this to the "incubator-ariatosca" repo, hence closing this PR.

repo: apache/incubator-ariatosca-website


text:
Add rle page

LGTM

authors: gaodayue kangpinghuang

repo: apache/incubator-doris


text:
Dockerfile Support for Distributed Deployment

@yuanchenl Please review and minimize your changes (i.e, using a stable version of cmake instead of rc version, why installing grpc twice (once using apt-get and built from source code), and so does protobuf).
Does this PR achieve the goal that by starting a container specified by the modified Dockerfile, quickstep_cli_shell is running as a server to accept queries from some input interface (say browser)?

The repeated installations are removed. CMake version is changed to 3.10.2 (stable).
The goal of this PR is to simply get the distributed quickstep correctly built in a docker image.
Since different container instances have different roles (conductor, cli, executor) and different configurations, I am currently running the image using pseudoTTY (docker run -ti) and manually specify the role and the conductor address for quickstep_distributed_cli_shell inside the tty.
Do you want me to change the dockerfile so that we can specify those information during building phase and run the image without the stdin attached?

Before merging this PR, please rebase this branch with the master.

Rebased

authors: yuanchenl zuyu

repo: apache/incubator-quickstep


text:
Adding LINE corp logo to streams page

@dguy @guozhangwang  I have committed "Adding Line corp logo to streams page"

LGTM. Merged to trunk.

authors: guozhangwang manjuapu

repo: apache/kafka


text:
KAFKA-7063: Update documentation to remove references to old producers and consumers

cc @ybyzek

The old/new consumer is still being referenced in ops.html(inside the table under "Monitoring" section). Should that reference be updated too?

Thanks for the review. Yes, I think we can remove the reference from Monitoring section. updated the  PR.

@hachikuji Pinging for review. I have updated the consumer implementation page with basic details. It will be good, If you can update the page with more details.

@hachikuji just a regular ping :)

authors: ijuma omkreddy vahidhashemian


text:
TAJO-1432: Support compressed result stream

As a user, I like this patch, @superpiggy . :)

authors: dongjoon-hyun superpiggy

repo: apache/tajo


text:
THRIFT-3154: tornado tutorial fail to work

@jfarrell this is closed fixed in Jira.  This PR can be closed.

repo: apache/thrift


text:
Add an interface to unify Base and LogAdapter.

Codecov Report

Merging #17 into master will increase coverage by -0.26%.

@@            Coverage Diff             @@
##           master      #17      +/-   ##
==========================================
- Coverage   95.57%   95.32%   -0.26%
==========================================
  Files          11       11
  Lines         746      748       +2
==========================================
  Hits          713      713
- Misses         30       32       +2
  Partials        3        3

Impacted Files
Coverage Δ

log_adapter.go
97.64% <ø> (-2.36%)
:x:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa760b3...796ec9f. Read the comment docs.

I'm increasing coverage, stand by.

authors: codecov-io efritz

repo: aphistic/gomol

license: mit

license_source: bigquery


text:
recent items stays at top

I couldn't understand of the issue. Can you explain it more?

Recent Items is obviously a feature, not an issue, but it's not one that I enjoy either. I'd prefer to be able to turn it off or for it only to show up if what I'm typing is somehow related to one of the recent items. If I've previously opened Excel, and I start typing something that contains some of the same letters that are in Excel's PATH, I don't think Excel should be matched.

Give the latest v0.6 a try and see if this still an issue.  If so, please re-open.

source: gharchive/issue

authors: PiratedVirus acbee appetizermonster cpriest

repo: appetizermonster/hain


text:
Updated: mark-text 0.13.65.51

Newer version of mark-text (0.15.1.1354) is now available in master.


text:
CFString alternatives for tests

What is the rationale for removing some of the CFString... calls?

CF* APIs are not supposed to be exposed, but, were accidentally exposed on Linux.  This clean up is required for Windows which properly completely obscures all CoreFoundation access.  The result is that the CoreFoundation APIs are unavailable for the tests unless they are in the header.  Alternatively, I suppose, the tests could link their own copy of CoreFoundation, but, it seemed that @millenomi was in favour of migrating to the use of the Foundation APIs for testing as long as the test still made sense.

@swift-ci please test

@swift-ci please test Linux platform

@swift-ci please test Linux platform

@swift-ci please test

@swift-ci please test Linux platform

@swift-ci please test and merge

authors: compnerd millenomi spevans

repo: apple/swift-corelibs-foundation


text:
Memberwise init defaults

Accidentally opened up the PR too soon. Please ignore.

repo: apple/swift-evolution


text:
Bring back SourceManager::rangeContainsCodeCompletionLoc()

@swift-ci please smoke test and merge

Pulled into https://github.com/apple/swift/pull/26981

repo: apple/swift


text:
ERROR: Command errored out with exit status 1:

@Rhutus - Please include the full output you get when you try to pip install. Also please let us know your version of Python and your operating system.

@Rhutus - Please include the full output you get when you try to pip install. Also please let us know your version of Python and your operating system.

Full Output:
ERROR: Command errored out with exit status 1:
command: /home/anaconda3/envs/virtual_environment_name/bin/python -c 'import sys, setuptools, tokenize; sys.argv[0] = '"'"'/tmp/pip-install-htv5zwat/turicreate/setup.py'"'"'; file='"'"'/tmp/pip-install-htv5zwat/turicreate/setup.py'"'"';f=getattr(tokenize, '"'"'open'"'"', open)(file);code=f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, file, '"'"'exec'"'"'))' egg_info --egg-base /tmp/pip-install-htv5zwat/turicreate/pip-egg-info
cwd: /tmp/pip-install-htv5zwat/turicreate/
Complete output (5 lines):
Traceback (most recent call last):
File "", line 1, in
File "/home/anaconda3/envs/virtual_environment_name/lib/python3.7/tokenize.py", line 447, in open
buffer = _builtin_open(filename, 'rb')
FileNotFoundError: [Errno 2] No such file or directory: '/tmp/pip-install-htv5zwat/turicreate/setup.py'
----------------------------------------
ERROR: Command errored out with exit status 1: python setup.py egg_info Check the logs for full command output.
Here is Version: Python 3.7.4
ubuntu 16.04 LTS

Dupe of #788. This is coming soon in 6.0!

authors: Rhutus TobyRoseman srikris

repo: apple/turicreate


text:
Test di Accessibilità

A questo link ci sono delle informazioni che riguardano l'accessibility testing.

Seguendo le linee guida a questo link, ciò che dovrebbe essere testato in ambito accessibilità è:

Markup semantico

elementi semantici (<nav>, <header>, <main>,... al posto dei semplici <div>)
attributi alt alle immagini
meta attributi ARIA (https://www.w3.org/TR/wai-aria/)

Accessibilità via tastiera

gestione del focus sugli elementi della pagina
gestione corretta dei tabindex per definire la corretta sequenza di focus degli elementi della pagina
transizioni di focus ad esempio all'apertura di Dialog modali
comportamenti Angular assegnati agli elementi a cui di default il browser permette di essere focusable (<button>, <input>, <a>)

In generale una applicazione dovrebbe essere:
Leggibile
Rispondere alle seguenti domande:

La pagina può essere ridimensionata al 200% ed essere usabile?
Le dimensioni del testo sono appropriate sui diversi dispositivi?
Il contrasto dei colori è sufficiente?

Predicibile
Rispondere alle seguenti domande:

L'autoplay di video e musica è spento?
L'utente è avvisato di qualsiasi cambio di contesto (cambio pagina, ...)?
Gli screen reader hanno abbastanza tempo per leggere gli elementi che compaiono dinamicamente nella pagina (alerts, contenuto renderizzato via javascript)?

Navigabile
Rispondere alle seguenti domande:

Tutti i task di base possono essere completati utilizzando esclusivamente la tastiera?
I form possono essere completati esclusivamente usando la tastiera?
E' presente una indicazione visuale che indichi l'elemento con il focus in un determinato momento?
Durante i cambi di contesto il focus viene spostato in maniera appropriata?

Inoltre si dovrebbe testare le componenti utilizzando uno screen reader oltre che i classici browser.

Aggiungere la descrizione di cosa dovrebbe essere testato nel file README.

Nel README è già presente un link alle linee guida per il design. In generale, per ogni componente, dovrebbero essere specificati esplicitamente nell'issue tracker i requisiti di accessibilità.

repo: apuliasoft/design-angular-kit


text:
Adds moltres image and description

Did you intend to do this here in the hackathon people, or here among the arfc projects: http://arfc.npre.illinois.edu/research/software/ ?

I am think add it here just for fun. Then show it for Alex and if he accept
it - we could add it to Research -> Software...
It is from Public gallery
2017-02-25 13:43 GMT-06:00 Katy Huff notifications@github.com:

Did you intend to do this here in the hackathon people, or here among the
arfc projects: http://arfc.npre.illinois.edu/research/software/ ?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/arfc/hipython/pull/5#issuecomment-282507397, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ATrGGDc9kgVqghXYU96ym7bsM7YWQ_ogks5rgIRtgaJpZM4MMHTn
.

authors: andrewryh katyhuff

repo: arfc/hipython


text:
plop ?

Sorry

;-) np

authors: arkadianriver genuinegreg

license: MIT


text:
Fixes typo that prevented setting backend.

@bergkoet I accidentally accepted this PR. But in the future can you send the PR to devel ? We usually cherry pick fixes to master if there is something critical.

@pavanky No problem, this is my first contribution so I just wasn't sure of the protocol.  Thanks!

authors: bergkoet pavanky

repo: arrayfire/arrayfire-python


text:
add ES locales

Coverage remained the same at 91.949% when pulling 2b8f2e179d699b5017d1c6a95a6c73db468adcf9 on mgaitan:master into 00458cf508b8a0066f8e318b3125a19ac4d39285 on arteria:master.

Thanks for adding translations @mgaitan.

authors: coveralls mgaitan walterrenner

repo: arteria/django-hijack


text:
[TINY] removing a workaround in Gears model

:shipit:

authors: maumar mikary

repo: aspnet/EntityFramework


text:
Converted test project to run on netcoreapp2.0

ping

repo: aspnet/JsonPatch


text:
Map DotNetRestoreSources => RestoreSources for metapackage builds

I did quick validation. The error message before says:
:45]C:\b\w\33bdfc1cae7b2a38\.w\Microsoft.AspNetCore.App\Microsoft.AspNetCore.App.csproj : error NU1102: Unable to find package Microsoft.AspNetCore.NodeServices with version (= 2.1.0-preview2-30312)
[11:41:45]C:\b\w\33bdfc1cae7b2a38\.w\Microsoft.AspNetCore.App\Microsoft.AspNetCore.App.csproj : error NU1102:   - Found 33 version(s) in nuget.org [ Nearest version: 2.1.0-preview1-final ]

With this change it shows that the additional restore sources are available.

Sounds good to me.

authors: natemcmaster ryanbrandenburg

repo: aspnet/Universe


text:
Create test configurations for OSPF

Test created, new configurations should be added to the appropriate directory.

repo: atopuzov/pyzebos


text:
Add sample notebook for image classification training with list format

@gurumurthys  fix review comments

I am not able to 👀 the notebook on Github. Locally running jupyter notebook see this error:
Unreadable Notebook: /Users/test/repos/xzhou33/amazon-sagemaker-examples/introduction_to_amazon_algorithms/imageclassification_caltech/Image-classification-lst-format.ipynb NotJSONError('Notebook does not appear to be JSON: \'{\\n "cells": [\\n {\\n "cell_type": "m...',)

@djarpin  Fixed the notebook format

@djarpin  fix review comments.

repo: awslabs/amazon-sagemaker-examples


text:
Add typescript

📝Changed routes:

/404
/

(view full size)
(view full size)

Commit 6c107f5f5fafc74c6cbabbe1a9b0e072f2c5c41b (https://axelekwallse-git-add-typescript.axelekwall.now.sh).


text:
TO MASTER: Fix tab index

👍

yo creo que en este repo podemos trabajar en master directamente xD

authors: axelhzf-tuguu nestorcamacho


text:
Build a static binary  in confd.

@bacongobbler I noticed that confd binaries are not statically linked.

That is correct. Is there a particular reason why they should be statically linked? Statically presents the following disadvantages:

higher memory usage since the binary cannot share libraries with the host
the binary must be re-compiled if a library must be updated. e.g. TLS security fixes.

For those reasons that's why I opted towards dynamic linking.

I'd be open to providing both dynamic and statically linked binaries if you can write that into the build script.

authors: TamalSaha bacongobbler

repo: bacongobbler/confd


text:
Clean up some text and html and fix view-source links

Are you fine with commit Replace : with # in view-source links?  I didn't take the time to understand how those links worked before.

It was kind of merge-conflct, and # fix was working not so perfect, so I implemented it by myself in https://github.com/barbushin/javascript-errors-notifier/commit/4533f926eecfe25fe27953fdea06d81d80b41008 and https://github.com/barbushin/javascript-errors-notifier/commit/8195b28bdfe0969565015f5ea549e531d99b280c
Thank you!

Awesome, thanks.

authors: barbushin pjvandehaar

repo: barbushin/javascript-errors-notifier


text:
update bazel_skylib dependency to 0.6.0 and rules_sass to 1.15.1

Looks good... except that it conflicts with my commit (https://github.com/bazelbuild/skydoc/commit/1cdb612e31448c2f6eb25b8aa67d406152275482). Sorry about that :(

I've overridden your 1cdb612 commit as part of this PR, as this way we point to a release tag :)

authors: c-parsons laurentlb

repo: bazelbuild/skydoc


text:
Enable dynamic reconfiguration of murmur without restarting.

This is not currently possible given that murmur runs in the foreground of the container. Instead, configuration changes should be handled while the container is running, and then the new image built, and then the new container should be swapped in place of the running container.

repo: bddenhartog/docker-murmur


text:
Select randomly a card

La modification permet de choisir aléatoirement une "card" dans celles affichés sur la page.


text:
Menril planks cannot be creosoted

Closed via https://github.com/belathus/Wanderlust-Renewed/commit/ce6ea0f55e3bd6ab6cfe7a218555e340ede94bce

authors: Divineaspect belathus

repo: belathus/Wanderlust-Renewed


text:
Fixed tests

I see you are a first time contributor welcome! 🎉 @lewis150193
I see one failing test for Header.test.js

Thanks, I will also get on fixing the Header.test.js, This is one of my first ever open PRs :D

repo: benhalverson/react-budget-app


text:
add .eslintrc.js & yarn.lock to .npmignore

Thank you!

repo: betit/known-css-properties


text:
CI for Node

Contains the compiled JavaScript

repo: billpun/github-actions-for-ci


text:
Qingwei/trackjs

Coverage decreased (-0.007%) to 29.402% when pulling 76ac7924b52cceab565e348f24a6a436cde3ba0f on qingweibinary:qingwei/trackjs into 3a7040760e84b0fee5c05673bb4bb10d7559c5ce on binary-com:master.

authors: coveralls qingweibinary

repo: binary-com/binary-next-gen


text:
chore: updated deps

:tada: This PR is included in version 2.12.6 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

authors: MrsFlux simlu

repo: blackflux/lambda-tdd


text:
fix: broken link

Thank you!

repo: blitz-js/awesome-blitzjs


text:
Class 'Mdanter\Ecc\Math\Gmp' not found

I also have this problem. Have you got a solution? because I had to mess up my dependencies to make it work .  Its a problem in bitwasp/boitcoin 0.0.7.*  You remove blockcypher and install bitwasp/bitcoin dev-master. it works fine. Problem is now You don't have blockcypher.

@ofumbi Yes I have got solution. Don't remove blockcypher. Please follow the following steps:

Install blockcypher using composer
composer require blockcypher/php-client

Then add following content in composer.json
"require": {
"mdanter/ecc": "dev-bugfix as 0.3.0"
}

Then run composer update command on terminal.

@sachin-lalaworld  Thanks.  it works now

@sachin-lalaworld Today I got the next error:
Problem 1
- bitwasp/buffertools v0.4.1 requires mdanter/ecc ~0.4 -> satisfiable by mda
nter/ecc[0.4.x-dev, v0.4.0, v0.4.1, v0.4.2, v0.4.3, v0.4.4, v0.5.0] but these co
nflict with your requirements or minimum-stability.
- bitwasp/buffertools v0.4.1 requires mdanter/ecc ~0.4 -> satisfiable by mda
nter/ecc[0.4.x-dev, v0.4.0, v0.4.1, v0.4.2, v0.4.3, v0.4.4, v0.5.0] but these co
nflict with your requirements or minimum-stability.
- bitwasp/buffertools v0.4.1 requires mdanter/ecc ~0.4 -> satisfiable by mda
nter/ecc[0.4.x-dev, v0.4.0, v0.4.1, v0.4.2, v0.4.3, v0.4.4, v0.5.0] but these co
nflict with your requirements or minimum-stability.
- Installation request for bitwasp/buffertools (locked at v0.4.1) -> satisfi
able by bitwasp/buffertools[v0.4.1].
The bitwasp/buffertools is using the ~0.4 and is not satisfiable by 0.3.x...
This library if full out of date...

Oh I got a better solutiuon
composer require "bitwasp/bitcoin":"dev-master as 0.0.7.x-dev",

Nice solution, you can send me how to create and sign the transaction using bitwsap. The signer of php-client is the problem with my current project dependencies...

Try using v2.0.0-beta.1 and please report back. Thank you!

authors: ofumbi oyepez003 quentinlesceller sachin-lalaworld

repo: blockcypher/php-client


text:
补充日志解决deadcheck问题

LGTM

authors: imotai leoYY

repo: bluebore/galaxy


text:
WIP: Cards

 Card

repo: bottable/fiber


text:
IOS-16116: replace boxnote icons

Hi @ric0liva, thanks for the pull request. Before we can merge it, we need you to sign our Contributor License Agreement. You can do so electronically here: http://opensource.box.com/cla
Once you have signed, just add a comment to this pull request saying, "CLA signed". Thanks!

CLA signed

Verified that @ric0liva has just signed the CLA. Thanks, and we look forward to your contribution.

repo: box/box-ios-browse-sdk


text:
Brainer3220

AI can with learning Geometry Dash Miss image

AI can with learning Geometry Dash Miss image


text:
Add SELinux support

You should also add in the conf dir since selinux assumes the conf files are /etc/redis.*\.conf
selinux_policy_fcontext "#{current['configdir']}(/.*)?" do
  secontext 'redis_conf_t'
end

Okay, added that.

Think it would be relatively easy to add testing in test-kitchen, can you have a look at that?

Done! I think the Travis failure was unrelated.

Re-triggered travis and it passes

repo: brianbianco/redisio


text:
Export sites HT to hand off to Laura for VQSR

Ideally we would have two runs: one standard AS_VQSR, and one with transmitted singletons (AS_VQSR_TS)

Blocked because of: https://discuss.hail.is/t/out-of-memory-in-allele-specific-and-site-level-info-calculation-on-a-sparse-matrix-table/1660

authors: gtiao jkgoodrich


text:
Reverted bad change

Really important, given this broke the tests.

(well, not important for consumers of the library, but you know what i mean)

repo: bugsnag/bugsnag-php


text:
Use docker login for image publishing

Everything is setup ready for this to be merged 👌🏼

repo: buildkite/agent


text:
unicode method for models

We should break this up into a ticket for each model


text:
Use vendoring

Fixed by #163

repo: camptocamp/conplicity


text:
Switch to go mod for dependency management

LGTM

authors: jonathana jonbodner

repo: capitalone/checks-out


text:
.{env}_cache file should invalidate upon kernel.php or config.php update

This is solved by 3415691cf18ad88faa9f3b7c8b7d390c6b7e3b95

repo: carbontwelve/tapestry


text:
Pull Vitess image when we know if it's a Vitess data source or not

If this PR is still relevant, then please fix conflicts, rebase and get a green CI build.
If the PR is no longer relevant please close.
This PR will be closed at the end of January 2021 otherwise.

If this PR is still relevant, then please fix conflicts, rebase and get a green CI build.
If the PR is no longer relevant please close.
This PR will be closed at the end of January 2021 otherwise.

Closing request as per previous announcement.

Closing request as per previous announcement.

authors: chris-ryan-square tirsen

repo: cashapp/misk


text:
Fix pkg source file not found in isyncr Cask

Thank you for the contribution. It needed some fixes, so they were made in 83d2ef47c87395c628335c70f2cba82fce91b5fe. Your contribution is still included (and still credited to you), with the appropriate modifications. Please feel free to ask about any of the changes.

authors: vitorgalvao ydesgagn

repo: caskroom/homebrew-cask


text:
Upgrade calibre.app to v2.44.1

Merged as 5908554697cdc8c0e0e9b9ca1cbaf9d7b8721166.


text:
Created folder with my name in it

You deleted the first line that contains the bash script identifier

authors: cengique xaaviair

license: Unlicense


text:
PersonDoor

+1

repo: cerner/one-cerner-style-icons


text:
Readonly when using bootstrapTyling="true, i'm using bootstrap4

More explanation needed.

try this
input-class="form-control bg-white"

repo: charliekassel/vuejs-datepicker


text:
第9676行，关汉卿《包待制智斩鲁斋郎・耍孩儿》中，删除Unicode字符 \u0027 ，此字符为单引号，保存进数据库时会导致数据库报错

菩薩慈悲：不能用跳脫字元(escape character)或引號包起來傳遞嗎？感恩感恩　南無阿彌陀佛

repo: chinese-poetry/chinese-poetry


text:
Add Example

i think your prev PR changes got added into this.

Yes, wanted to get the other branch merged first so the diff would not include the other commits

@chirag04 this one should be good to go if you want to test it out.


text:
merging upstream master on Github

Hi.
I'm trying to figure out the request. It seems as if those are the changes that were already introduced by me on main branch or am I missing something?
I can be wrong though as I have not worked on multiple branches (all were solo updates on master) and maybe I missed something in commits.

Hi,
I didn't do any changes. Just wanted to synchronize my repository with changes you did yesterday, and at the end appears info to create PR. So I clicked it :)
Sorry, I am not well experienced with GitHub yet.
I think you can simply reject this PR.

No problem, just checking if I have missed something

authors: chomupashchuk smarthomepch

repo: chomupashchuk/ariston-remotethermo-api


text:
please add wget URL or git clone URL of rocksdb 5.9.2 to the document

someone maybe install rocksdb master branch，but It don't work. So  add obvious URL of rocksdb 5.9.2 can help someone

#172 will fixed

authors: awzhgw halleyshx

repo: chubaofs/chubaofs


text:
Fixed compatibility with construct >=2.9.41

Coverage decreased (-0.3%) to 91.848% when pulling 38f519eecad597b9a87761879f641c62ce2d48b4 on release1.2.3 into ab473da017018a2c3add8ec4b7253fd2d32fb3ee on master.

Coverage decreased (-0.3%) to 91.848% when pulling 38f519eecad597b9a87761879f641c62ce2d48b4 on release1.2.3 into ab473da017018a2c3add8ec4b7253fd2d32fb3ee on master.

authors: citruz coveralls

repo: citruz/beacontools


text:
Add 'show tables' to autocomplete for Flink

Best is probably to start with a simple SHOW TABLES|VIEWS|DATABASES, similarly to 'sql_show' in https://github.com/cloudera/hue/tree/master/desktop/core/src/desktop/js/parse/jison/sql/ksql and add it to the generic https://github.com/cloudera/hue/tree/master/desktop/core/src/desktop/js/parse/jison/sql/generic
Then import it in the structure.json. That way it would kickstart a basic reusable SHOW grammar, and then we can see for the dialect/Calcite specific as we go deeper.

Flink 'SHOW' statement https://ci.apache.org/projects/flink/flink-docs-release-1.12/dev/table/sql/show.html
ksql example https://github.com/cloudera/hue/commit/04ab447238e63ce5ee736e4fc0b2aba013a7c3f3#diff-f0a0b26331f281bf8942ef9ce306371934fc02988fdad643f73c94a1aac7b39b
Dask SQL https://github.com/cloudera/hue/blob/master/desktop/core/src/desktop/js/parse/jison/sql/dasksql/show/show.jison

Best is probably to start with a simple SHOW TABLES|VIEWS|DATABASES, similarly to 'sql_show' in https://github.com/cloudera/hue/tree/master/desktop/core/src/desktop/js/parse/jison/sql/ksql and add it to the generic https://github.com/cloudera/hue/tree/master/desktop/core/src/desktop/js/parse/jison/sql/generic
Then import it in the structure.json. That way it would kickstart a basic reusable SHOW grammar, and then we can see for the dialect/Calcite specific as we go deeper.

Flink 'SHOW' statement https://ci.apache.org/projects/flink/flink-docs-release-1.12/dev/table/sql/show.html
ksql example https://github.com/cloudera/hue/commit/04ab447238e63ce5ee736e4fc0b2aba013a7c3f3#diff-f0a0b26331f281bf8942ef9ce306371934fc02988fdad643f73c94a1aac7b39b
Dask SQL https://github.com/cloudera/hue/blob/master/desktop/core/src/desktop/js/parse/jison/sql/dasksql/show/show.jison

docker-compose to easily boot a Flink DB https://gethue.com/blog/tutorial-query-live-data-stream-with-flink-sql/

docker-compose to easily boot a Flink DB https://gethue.com/blog/tutorial-query-live-data-stream-with-flink-sql/

@romainr  assigning this to myself.

@romainr  assigning this to myself.

authors: Akhilsnaik romainr

repo: cloudera/hue


text:
Fix minor typo in docs

This PR should be closed as the files the PR changes were deleted.

Yup, not a problem :+1:

authors: grant helio-frota

repo: cloudevents/sdk-javascript


text:
Use Material Design sizing for menus in desktop browsers

Having seen the trimmed down menu, it does look much better on desktop. I think this might be worth getting in. @KlapTrap @irfanhabib :+1: :-1: ?

Closing this for now.

@KlapTrap Why did you close this?

authors: KlapTrap nwmac richard-cox

repo: cloudfoundry-incubator/stratos


text:
WIP: deployment-steps

This is a WIP which is fine; just curious of there's particular discussion questions here?

Question is: any feedback? I’m really not sure how useful it is to expose all steps given the limited amount of use cases I could come up with.
There’s also the question around how to deal with step combinations that most likely don’t make sense, e.g. skipping delete or create.
Wdyt?
On 19. Oct 2017, at 19:13, Danny Berger <notifications@github.commailto:notifications@github.com> wrote:
This is a WIP which is fine; just curious of there's particular discussion questions here?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/cloudfoundry/bosh-notes/pull/34#issuecomment-337975438, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ACJv98j8e_asTiLxV7R7Yy8_spOCzSuIks5st4NKgaJpZM4PqY0u.

repo: cloudfoundry/bosh-notes


text:
Added new docs for huaweicloud cpi

Hey @zhongjun2 happy to take a look at this and start reviewing. Before we merge it though, can you please sign the CLA referenced in the above comment and then close and reopen this PR?

Hi mfine30, Thanks for your remind. I just signed the CLA. I am waiting for it pass.

repo: cloudfoundry/docs-bosh


text:
fix a bug and add type information required by dart_sip_ua

LGTM

repo: cloudwebrtc/dart-sdp-transform


text:
Account for change of polarity format

@zupon, this isn't the problem you are looking for yet, but the code you are working on is somewhat old and it isn't accounting for the change made in the WorldModelers/Ontologies project.  Perhaps that jitpack isn't getting you the most recent version of the ontology.  This change should work with both the new and old version.

This on the fly creation of rules in CompositionalGrounder.getModifierMentions can result in things like
   pattern: |
      trigger = °

which odin can't process.  Maybe you've already noticed.  Some escaping is going to be necessary, perhaps quite  a bit because valid yml is required.  I'm thinking of SQL injection kinds of problems.

This on the fly creation of rules in CompositionalGrounder.getModifierMentions can result in things like
   pattern: |
      trigger = °

which odin can't process. Maybe you've already noticed. Some escaping is going to be necessary, perhaps quite a bit because valid yml is required. I'm thinking of SQL injection kinds of problems.

@kwalcock Can you elaborate on this? I don't follow how the rule in CompositionalGrounder.getModifierMentions will give us something like your example. What sorts of changes/fixes need done to remedy this?

In this case ${synHeadWord} must have been °.  It came from whatever test file I happened to have been using last.  Pasting it in the middle of a rule seems to result in an invalid rule as far as Odin is concerned and the program crashes.  Perhaps it doesn't deal well with unicode.
In the case of [chunk=/NP$$/ & !word=${synHeadWord} & !tag=DT]+, if synHeadWord is something like ha & word=ha  or just ] probably something undesired will happen at an inopportune time.

BTW it is not intended to ground during testing, especially not on Travis/Jenkins.  The test will need to be disabled later (until we figure out a good way around this).

authors: kwalcock zupon

repo: clulab/eidos


text:
Add pg_settings to the catalog

This has been added into PR #260 .
Implemented as a global catalog. (Postgres implements as a view into an internal function).

repo: cmu-db/terrier


text:
Invalidate directory listing cache for source and destination of file move

Finished and polished in 2c0e96d

https://github.com/cnap-cobre/synapse/commit/2c0e93d0b62da8b456604f63f8714ca446c1b1ed

repo: cnap-cobre/synapse


text:
rename cobalt.conf to cobalt.json

Done on Android & iOS. Updated Catalog. TODO: update others samples & projects

repo: cobaltians/Cobalt


text:
Fixes to python katacoda

This change is

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/f4dcad9d27d3636b4dc9858cf7c7bda4e6a9fc96/
Edited pages:

tutorials/katacoda/build-python-app/step1.md
tutorials/katacoda/build-python-app/step2.md
tutorials/katacoda/build-python-app/step3.md

authors: cockroach-teamcity jseldess

repo: cockroachdb/docs


text:
Misc dev guide commit sync

This change is

This change is

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/f596fce9d6e3cb626eef00e014da8a4b856afc7e/
Edited pages:

v21.1/bulk-delete-data.md
v21.1/connect-to-the-database.md
v21.1/connection-parameters.md
v21.1/connection-pooling.md
v21.1/delete.md
v21.1/developer-guide-overview.md
v21.1/force-index-selection.md
v21.1/hash-sharded-indexes.md
v21.1/indexes.md
v21.1/install-client-drivers.md
v21.1/limit-offset.md
v21.1/pagination.md
v21.1/query-order.md
v21.1/schema-design-database.md
v21.1/schema-design-indexes.md
v21.1/schema-design-overview.md
v21.1/schema-design-schema.md
v21.1/schema-design-table.md
v21.1/schema-update-modify-objects.md
v21.1/schema-update-remove-objects.md
v21.1/selection-queries.md

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/f596fce9d6e3cb626eef00e014da8a4b856afc7e/
Edited pages:

v21.1/bulk-delete-data.md
v21.1/connect-to-the-database.md
v21.1/connection-parameters.md
v21.1/connection-pooling.md
v21.1/delete.md
v21.1/developer-guide-overview.md
v21.1/force-index-selection.md
v21.1/hash-sharded-indexes.md
v21.1/indexes.md
v21.1/install-client-drivers.md
v21.1/limit-offset.md
v21.1/pagination.md
v21.1/query-order.md
v21.1/schema-design-database.md
v21.1/schema-design-indexes.md
v21.1/schema-design-overview.md
v21.1/schema-design-schema.md
v21.1/schema-design-table.md
v21.1/schema-update-modify-objects.md
v21.1/schema-update-remove-objects.md
v21.1/selection-queries.md

authors: cockroach-teamcity ericharmeling


text:
Implement layout constraints/auto-layout for all the windows

Fixed in #80

repo: code-ready/tray-macos


text:
Moves snap data to more logical places

Dang, forgot to all-caps the snap data. Will do that as a next step if there's a chance.

repo: codeforboston/cliff-effects


text:
typo: yor -> your

Thanks!

authors: marwahaha schneems

repo: codetriage/codetriage


text:
Remove solved issues

Thanks!

authors: commonsguy philipgiuliani


text:
Frameの追加時に、「どこの後ろに追加するのか」が選べるようにする

追加した後に、順序を入れ替えればいいし、そんな手間ではないので、
なおさないようにします。

repo: comozilla/Parapara-Canvas-Editor


text:
cleanup of 'general' section

AFAIK we need to have a vote on any change in the language of the constitution, even for things like typo corrections so will need to wait til the EGM for this. @qaisjp is that right?

Unfortunately we can't merge the duplicated clause now, but we can merge the single quote fix. Might be better to split and merge the quote fixes separately?

Also, it being merged doesn't mean it's part of the constitution — just means we don't need to worry about voting it in as we'll quote it as "General stylistic changes" (refer to one of the previous releases)

commit to fix #15 reverted, single quote fix still present

The package import textcomp was required for the single quote stuff so that can now be removed.

Please submit a new pull request @JMaio as it looks like @findoslice prematurely merged...

authors: JMaio findoslice qaisjp

repo: compsoc-edinburgh/constitution


text:
Boost 1.63

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

authors: conda-forge-linter jschueller


text:
MNT: Re-rendered with conda-smithy 1.7.0

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

Want to add yourself to the maintainers?  I'll go ahead and merge this now.  If you want to be a maintainer, then go ahead and do another PR.

authors: conda-forge-linter mrocklin msarahan

repo: conda-forge/sortedcontainers-feedstock


text:
代币上传

你好，代币信息提交有误，请参考此教程 https://github.com/consenlabs/token-profile/blob/master/README.zh-CN.md，
建议和你们的技术和设计协作完成资料的提交。

repo: consenlabs/token-profile


text:
Game Manager - refactoring

Taken in charge. It will take place on Jun 28 2020 PDT evening


text:
Fix allocation of podIP in subnet larger than 64bits

Coverage decreased (-0.1%) to 76.116% when pulling 3440c1e54eb6bba6f07fd4012136ddefceaf8d77 on lukasmacko:ipv6 into 22c0be9ba5267dd9fb39f60f5a14053b6ba68937 on contiv:dev.

authors: coveralls lukasmacko

repo: contiv/vpp


text:
running-coreos: align DO examples on stable channel

LGTM

Whoops, I just changed part of this without looking closely. Thanks for spotting this.

authors: bcwaldon crawford robszumski

repo: coreos/docs


text:
Mozh/t500 graceful restart

LGTM

authors: mozhmike vixentael

repo: cossacklabs/acra


text:
feature: german lang file

Merged and fixed 👍

repo: crip-laravel/filesys


text:
Add JSON serialization

at a glance, looks good! at some point this might be revisited to add endpoint.ipv6, but that's a different feature anyway

You're right, I just created #48 to track it

authors: adriancole fedj


text:
Add messages to Nymeria Sand and Renly's Pavilion

Darn, i didn't notice this one, and just submitted #576 to add a log message to Renly's Pavilion.
If you don't mind, though, I'd rather use the implementation in there for Pavilion as it doesn't leave around attributes (plusCard/minusCard) after the effect is completed.
I didn't touch Nym in that PR though so @cryogen, if he agrees, will need to merge your implementation for Nym and mine for Pavilion.

That's fine.

As per discussion with @cryogen, to make merge easier I've integrated this into #576 — attributing the relevant commit to @DukeTax. This PR can then be closed as superseded by that one.

authors: DukeTax zacchiro

repo: cryogen/throneteki


text:
add economics model docs

@kaikai1024 fixed

I'll squash pr after approved

@leeyr338 @kaikai1024 @CipherWang Already fixed this pr, please review it again.

@leeyr338 @kaikai1024 @CipherWang Already fixed this pr, please review it again.

repo: cryptape/citahub-docs


text:
Implement stack probe for x86

Could you provide some reference/motivation for this? :)

@jhass
Sure :)
The problem is that if a stack frame which is larger than the OS-thread guard page, a function could skip over the guard page and may corrupt the heap or another thread. This patch solves by using LLVM's stackprobe.
According to LLVM LangRef Manual

This attribute indicates that the function will trigger a guard region in the end of the stack. It ensures that accesses to the stack must be no further apart than the size of the guard region to a previous access of the stack. It takes one required string value, the name of the stack probing function that will be called.

other references/implementations:

Rust
Zig

Huh, so another thing you would expect LLVM to just handle for you.

Could you provide some code that is broken without this patch? Otherwise, I feel like we'll be merging something without really knowing or understand what this does.

authors: asterite jhass kubo39

repo: crystal-lang/crystal


text:
Create ref

Closed in #414


text:
Add ability to process generics to the doclet

Looks good, thanks.

authors: ctnitchie mnitchie

repo: ctnitchie/freemarkerdoclet


text:
Footer and header span width of page

Mike, do you mean the black background of the footer/header, or the margins of the icons and text? On my computer the black spans the screen and the icons/text are aligned with the margins for each homepage widget.

Does the black footer background span the page? The header I made it look like it by specifying that background black. We must need to just make the homepage span the full screen and add a margin around it (for readability). Then the black footer will span the width.

Oh yeah, nm, I don't know why I thought the footer's black background was spanning the page. I think I can fix that real quick

Oh snap, the webpage has a white background on Safari and a dark gray background on Chrome.
Sigh

Also the sticky-topclass works in Chrome but not Safari, BOOOO!

Oh goodness. I did not think that we would be having issues that spanned different browsers. Not a fan of that.

Ok, I apparently screwed up associating a particular commit with fixing this issue, so just know there is a commit that resolves the footer problem by creating a new top-level GoHTML script, /layouts/_default/baseof.html, which overrides /themes/academic/layouts/_default/baseof.html


text:
Update Jenkinsfile

New Jenkins publish location

repo: cwiederspan/kubernetes-hackfest


text:
improvised Docs

Sure, why not. It's a bit more "improved" than "improvised", I'd say, but it reads better. Thanks.

repo: cython/cython


text:
add toolchain endpoint (Xcode 7.3)

Thanks for the contribution, @lgaches! Definitely very useful going forward.
Would you mind adding a DVR-based test, where you record the response json to verify we parse properly? Thanks!

@czechboy0  added a DVR-based test

Amazing. Thanks do much! :)


text:
Update VJSF to 2.1.3

Seems like the performance is actually worsened on this new version. Marking as draft for now.

how are you measuring performance?

how are you measuring performance?

I was measuring performance manually for the comparison between vjsf 2.0.2 and 2.1.3.

authors: mvandenburgh satra

repo: dandi/dandiarchive


text:
Spring支持@Bean注解, 添加SpringJobScheduler构造方法

Coverage decreased (-0.2%) to 89.527% when pulling d325f8a82e1776d95fad0ee5061a72324b53a90a on Antergone:master into 0fb7dd4b888bcffbe7743262308c5bffee80ab7a on dangdangdotcom:master.

感谢贡献代码

authors: Antergone coveralls terrymanu

repo: dangdangdotcom/elastic-job


text:
Add support for optional patterns

this needs to be reflected on compile, field access and iterator

repo: daschl/grok


text:
B2

/merge

/merge

repo: dashandslash/playground


text:
Fixed Default RPC Ports

Good find! I knew I missed smth :)

repo: dashpay/dash


text:
408 - Fix: Allow reconnection if SSL fails because of encrypt/decrypt errors

👍  Merge at will.

Rebased and merged at 23f4572e2fd52ed3f567b16bd392eefb66cf7608.

repo: datastax/cpp-driver


text:
Setup Travis

FIXED

repo: datopian/datahub-frontend


text:
Have an other or add option for experience

not required

repo: davetaz/EDSA


text:
How can make it work with TensorFlow_gpu VERSION 1.8 ?

Have you installed cuda-toolkit and cudnn sdk?

repo: davidsandberg/facenet


text:
Elixir (Plugs/Ecto/Phoenix)

closed, thanks to @artukrap!

repo: deadtrickster/beam-dashboards


text:
Current style function does not account for clustering (at least show the number)

Styling needs rewriting to properly allow using of images anyhow.
A useful API needs to be created.

Fixed.

repo: dennisguse/TheKarte


text:
希望告警屏蔽那边可以增加基于服务的告警，不然贴一大批IP 屏蔽告警有点麻烦

https://github.com/didi/nightingale/issues/704 重复的issue

authors: UlricQin chixianliangGithub

repo: didi/nightingale


text:
작업자 이름에 마우스를 올리면 내선번호 나오게

마우스를 오버하는 것은 핸드폰에서는 안된다. 프로필로 바로 연결하도록 하기.

http://192.168.31.172/user?id=khw7096

607bb21


text:
csi.go 304번째 줄. 트렌젝션을 효율적으로 수정하기.

587aab7

79dccd9


text:
Refactor code to read and compile solidity contract once

looks good

repo: digitalsherpas/tickether


text:
how can we connect web socket with this drawing board?

@akshita-kamani This repo is actually provide a pure render component. you can create a wrapper component and use other packages such as socket.io to send and receive drawing actions.

authors: akshita-kamani dilidili

repo: dilidili/react-drawing-board


text:
https://github.com/discountry/react/blob/master/content/docs/faq-functions.md

认领～

authors: discountry onlyliubara

repo: discountry/react


text:
fix issue 15991 - std.datetime.StopWatch is not @nogc

Just adding a bunch of @nogcs, looks good to me.

👍

++LGTM

By the way...I pity the guy who'll have the bad idea to take "nogc" as nickname on GH.

Auto-merge toggled on

authors: BBasile Hackerpilot JackStouffer ZombineDev aG0aep6G

repo: dlang/phobos


text:
aliases is not working, after reloading a bash ( a new tab, or new window )

source ~/.aliases

it works.

repo: dobestan/dotfiles


text:
Examples

I do not like this approach, commented code is not code. If we need some of this code in future, we implement this in future. It's a long discussion :stuck_out_tongue_winking_eye:


text:
Guvnor-1774: Standalone Process Editor: Expose before and after save events to client applications

Rikkola, Esteban, I haven't merged this pull request (like 26 an 27) as I get a sense that the two of you are debating it.

Not me :) Toni, something to add?
XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX
Esteban Aliverti

Developer @ http://www.plugtree.com
Blog @ http://ilesteban.wordpress.com

On Tue, Dec 13, 2011 at 12:17 PM, Michael Anstis <
reply@reply.github.com

wrote:

Rikkola, Esteban, I haven't merged this pull request (like 26 an 27) as I
get a sense that the two of you are debating it.

Reply to this email directly or view it on GitHub:
https://github.com/droolsjbpm/guvnor/pull/28#issuecomment-3121759

Toni? Can we merge this pull request?

Sure sure, I'm on it. GitHub should harras me if there are pull requests that are not merged. ...or I should just check every morning.

authors: Rikkola esteban-aliverti manstis

repo: droolsjbpm/guvnor


text:
UF-305 Upgrade GwtBootstrap to version 0.9.3

Depends on https://github.com/droolsjbpm/kie-wb-common/pull/407

+1 @cristianonicolai thank you!

authors: cristianonicolai pefernan

repo: droolsjbpm/livespark


text:
Introducing some superior strategies

These look very cool!

authors: drvinceknight langner

repo: drvinceknight/Axelrod


text:
Adds Limited retaliate strategy

Looks great @meatballs , could you just add a test for your new init method? I know that it is super simple but just want to make sure every thing is well tested... (Planning on going through and making sure all the strategies even have their init tested).

All sorted now

Thanks :)

I don't seem able to 're-open' this. I think you'll need to send me another pull request. Apologies for the confusion, my fault entirely, I just clicked merge on my phone but I think I'd feel better if there was a reset method (tested) as I describe here: #64
Sorry for the confusion.

authors: drvinceknight meatballs


text:
Ajout du projet « livre Node.js »

:+1:

authors: DavidBruant oncletom


text:
Android upload

woops.. sorry wrong one :)

repo: dunghuynh/react-native-webview-bridge


text:
Question: Is there any java implementation planned?

@ecmnet
We have an implementation in Java called KIARA, but this implementation is not so used an maintained and lacks many features of Fast RTPS. Please take a look.
As another option, what you can always do is call Fast RTPS through JNI.

Take a look thus repo:
https://github.com/esteve/ros2_java
@esteve could help you.
Cheers

authors: JaimeMartin ecmnet jabrena

repo: eProsima/Fast-RTPS


text:
Add alpha 3 changelog.

I don't see that we now extract constants from EdgeQL and GraphQL queries mentioned anywhere.

I suppose that constant extraction can go into "Sever" section rather than EdgeQL/GraphQL since fundamentally it's not so much about the languages as it is about more efficient caching for the server.

Will Migrations be part of alpha3 ?

Will Migrations be part of alpha3 ?

Alas, the implementation isn't ready yet.  We decided to cut a release and not wait until RFC1000 is fully implemented to give other features and fixes the opportunity to get tested.  That said, we'll be switching to time-based 6-week release cadence for the alphas, betas and rcs from now on.

Thanks Victor!

authors: 1st1 elprans haikyuu vpetrovykh

repo: edgedb/edgedb


text:
Please add support for action sheet too

i agree


text:
Croatian translation

thanks for the heads-up

repo: egoist/vue-timeago


text:
Added CastAction

Thanks!

authors: NathanWolf grisstyl

repo: elBukkit/MagicPlugin


text:
Metricdb: Return number of metrics deleted

@nrzipher

repo: eleme/banshee


text:
Remove code dependencies to underscore

Tested in test_app and demo and looks like it still works.

authors: alaibe jrainville

repo: embark-framework/embark


text:
closing the keyboard on signup screen for click on login to work

@emmasuzuki Can you review this PR.

repo: emmasuzuki/CucumberEspressoDemo


text:
Print dependency version in CI

Codecov Report

Merging #49 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master     #49   +/-   ##
======================================
  Coverage    96.6%   96.6%
======================================
  Files           5       5
  Lines         206     206
======================================
  Hits          199     199
  Misses          7       7

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b244e0d...fe09878. Read the comment docs.

Print version of dependencies in CI

authors: codecov-io erikzenker

repo: erikzenker/inotify-cpp


text:
fix(package): bump eth json rpc spec

:tada: This PR is included in version 1.2.2 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

authors: shanejonas zcstarr

repo: etclabscore/jade-explorer


text:
能不能直接编译成app

暂时不可以，你可以去了解一下weex @lizhi2013

repo: eteplus/vue-sui-demo


text:
feat: expose pinning functions

Generally LGTM, it would be good to include tests as well, but if it is important to have it in the release I guess we can do that as part of #156 work.

repo: ethersphere/bee-js


text:
settlement persistence and debug api

Short PR description would be good (or at least a reference to the relevant issue, in case there is one) :+1:

authors: acud ralph-pichler

repo: ethersphere/bee


text:
automatically deploy @ cluster upon PR merge

This would be nice. What is needed to deploy to the yandex cluster?

authors: anaderi betatim

repo: everware/everware


text:
Added benchmarks to isbn_verifier

Hi @h311ion, thanks so much for your PR! Was there a discussion about adding this benchmark anywhere? What was the motivation? (I'm not opposed, I just am wondering what led to the PR being opened).

Hi @kytrinyx, there is an a description in task that it may contain benchmarks but it's missing, so i decided to add them

repo: exercism/go


text:
Added support for Swift Package Manger

Hi Florian! Thank you for this work, we just merged it to the master version.

authors: hirschfl ystrot

repo: exyte/Macaw


text:
Resetting read deadline

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Craig Day seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

authors: CLAassistant craigday

repo: fabiolb/fabio


text:
fix: remove ngx-base dependency and use internal broadcast service

You can do whatever you want, just wondering why?
And why would you submit a change to ngx-base along these lines if you don't want to use it?

@joshuawilson we are waiting for it to be release in ngx-base in order to be able to use it.

authors: edewit ia3andy joshuawilson


text:
we now use app not project as labels

[merge]


text:
Pull request for differential revisions D1001, D1002 and D1004

Thanks!

authors: epriestley mareksapota-fb

repo: facebook/phabricator


text:
Bits and Bobs

This looks good to me. :shipit:

authors: TysonRV farridav

repo: farridav/django-adminlte-ui


text:
Shortcuts don't work in Glutin Morphic World

works now

repo: feenkcom/gtoolkit


text:
readme: bundle filename

thanks!

No problem mate :+1:

authors: LinusU feross

repo: feross/drag-drop


text:
Using topsort for circular dependency check

Hey thanks for your pull request. I hope I can find some time on the weekend :)

awesome, thanks. I have found an issue with my implementation. Will update the diff.

Fixed the tests & logic too, please take a look.

Hey , in ur dfs implementation , following breaks
a -> b, c , d
b -> c
c ->
d ->
There r no cycles in this , but detectcycle fails because when it visits b dependencies it sees c and it would have already seen c when visiting a . Thats why i had to introduce topsort to detect cycles

hey @pavankris just a short update for you: I haven't forgotten the PR but I simply had not time so far to revisit the topic. I will also not have time this week but I promise to take a look next week :)

I finally had some time looking into the pull request again (sorry for the long delay).

Hey , in ur dfs implementation , following breaks
a -> b, c , d
b -> c
c ->
d ->
There r no cycles in this , but detectcycle fails because when it visits b dependencies it sees c and it would have already seen c when visiting a . Thats why i had to introduce topsort to detect cycles

I created the following test to see if there is actually an error in my implementation:
It("should not return an error given a simple DAG", func() {
	// Given the following graph:
	//    --- a ---
	//    ↓   ↓   ↓
	//    b → c   d
	a := goldi.NewType(NewTypeForServiceInjectionMultipleArgs, "@b", "@c", "@d")
	b := goldi.NewType(NewTypeForServiceInjectionMultipleArgs, "@c")
	c := goldi.NewType(NewTypeForServiceInjection, new(MockType))
	d := goldi.NewType(NewTypeForServiceInjection, new(MockType))

	registry.Register("a", a)
	registry.Register("b", b)
	registry.Register("c", c)
	registry.Register("d", d)

	Expect(validator.Validate(container)).To(Succeed())
})

This test works without an issue. This is the output after I added some temporary logging to make the validation more visible:
2017/06/13 12:13:20 validating "a": Checking type reference for type ID "b"
2017/06/13 12:13:20 check: typeID: "b" seen: "[a]"
2017/06/13 12:13:20 check: typeID: "c" seen: "[a, b]"
2017/06/13 12:13:20 validating "a": referenced type "b" has no circular dependencies
2017/06/13 12:13:20 validating "a": Checking type reference for type ID "c"
2017/06/13 12:13:20 check: typeID: "c" seen: "[a]"
2017/06/13 12:13:20 validating "a": referenced type "c" has no circular dependencies
2017/06/13 12:13:20 validating "a": Checking type reference for type ID "d"
2017/06/13 12:13:20 check: typeID: "d" seen: "[a]"
2017/06/13 12:13:20 validating "a": referenced type "d" has no circular dependencies
2017/06/13 12:13:20 validating "b": Checking type reference for type ID "c"
2017/06/13 12:13:20 check: typeID: "c" seen: "[b]"
2017/06/13 12:13:20 validating "b": referenced type "c" has no circular dependencies

As you can see the set of seen types is always reset for each checked reference.
I will manualy merge the new test and also the test cases that you added into master. If you are still conviced that there is an issue I suggest you open a github issue where we can continue debugging.
I think it will be best if we can start with a failing unit test first without modifying the existing code.

Closing due to two weeks of inactivity. Feel free to reopen but consider creating an issue first (see last comment): )

authors: fgrosse pavankris

repo: fgrosse/goldi


text:
Add logging

Retest this please

Retest this please

Retest this please

Retest this please

closing since seems bogus w/ the Syso "logging"

authors: PhilipGough matskiv matzew

repo: fheng/aerogear-unifiedpush-server


text:
test issue

Was testing a feature of GitHub projects. If you have the same label in multiple projects, you can filter by that label on the project, and if that label exists in multiple repos, the filter will work as you want - i.e., you can see work from all repos with that label.

repo: fishtown-analytics/fishtown-ui


text:
Extract DB and sample DB command

Student tam byl na ověření ze je z FITu. Což je ale spatne. Dal bych tam teda jen "B-1800": authId, a ono se to koukne jestli tam je aspoň jedna role co začíná na ten klíč

repo: fit-ctu-discord/honza-botner-dev


text:
Switching containers while showing logtail should show logtail for newly selected container

Fixed in 2.x branch

repo: floto/floto


text:
all: Add Joseph to MAINTAINERS

LGTM :smile:

authors: lmars titanous

repo: flynn/flynn


text:
Feature/sensor input hass mqtt discovery

Awesome, thanks!

authors: adrian-vlad flyte

repo: flyte/pi-mqtt-gpio


text:
Add hasbolt

Thanks!

authors: lwm zmactep

repo: fpco/stackage


text:
请问手机号解密的有吗？

aes解密


text:
fix struct tag

👍

authors: g-hyoga mikoim

repo: g-hyoga/kyuko


text:
Fix crash on launch for demo project (iOS 11)

I am unable to produce a crash on launch running Demo scheme with iPhone X sim/iOS 11.
Can you provide any more information relating to the crash?

I'm also unable to produce the crash, on an iPhone 8 simulator running iOS 11.

Awesome, thanks for testing!

authors: dylanmaryk gabek macbellingrath

repo: gabek/GitYourFeedback


text:
Disable Sequelize operator aliases

Coverage remained the same at 98.135% when pulling 3027f49de29757f548b9ca3388b28727a22e0054 on sequelize-op into 4770afa974609aa57738bf5c75b8963c5a028812 on master.

authors: coveralls gabrieltanchen

repo: gabrieltanchen/xpns-api


text:
OpenMS 2.6.1 release

https://github.com/galaxyproteomics/tools-galaxyp/pull/653

repo: galaxyproteomics/tools-galaxyp


text:
你好  可以转载到"深圳湾码农"公众号吗  会注明作者和来源

嗯，可以

authors: gamedilong qappleh

repo: gamedilong/SoftwareArchitect-CN


text:
add prefix argument to support different specs/blueprints

Thanks!

authors: alejoar atlithorn

repo: gangverk/flask-swagger


text:
Release polish

Codecov Report

Merging #8 (8b5a403) into master (4f87afa) will decrease coverage by 0.76%.
The diff coverage is 90.00%.

@@            Coverage Diff             @@
##           master       #8      +/-   ##
==========================================
- Coverage   96.37%   95.60%   -0.77%
==========================================
  Files           8        8
  Lines         607      615       +8
==========================================
+ Hits          585      588       +3
- Misses         22       27       +5

Impacted Files
Coverage Δ

src/progshot/progshot.py
95.19% <88.88%> (-1.72%)
:arrow_down:

src/progshot/__init__.py
100.00% <100.00%> (ø)

src/progshot/cli.py
94.85% <0.00%> (-0.97%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f87afa...8b5a403. Read the comment docs.

authors: codecov-commenter gaogaotiantian

repo: gaogaotiantian/progshot


text: Button: привести размеры иконок к размерам в фигме

repo: gazprom-neft/consta-uikit


text:
Update example detect_variants YAML file.

Looks good to me.

repo: genome/cancer-genomics-workflow


text:
Fix dead link in tests/README.txt

Thanks @rouault !

authors: rouault tomkralidis

repo: geopython/pycsw


text:
Implement CustomerStorage

I'm starting here, and moving to hash table there after

authors: clamars gesingle

repo: gesingle/inventory-automation


text:
submission versions and review state

I took a look at actionCondition() in query/audits.js, and it has some logic around submissions that I didn't remember:
const actionCondition = (action) => {
  if (action === 'nonverbose')
    return sql`action not in ('submission.create', 'submission.attachment.update', 'backup')`;
  else if (action === 'user')
    return sql`action in ('user.create', 'user.update', 'user.delete', 'assignment.create', 'assignment.delete')`;
  else if (action === 'project')
    return sql`action in ('project.create', 'project.update', 'project.delete')`;
  else if (action === 'form')
    return sql`action in ('form.create', 'form.update', 'form.delete', 'form.attachment.update', 'form.update.draft.set', 'form.update.draft.delete', 'form.update.publish')`;
  else if (action === 'submission')
    return sql`action in ('submission.create', 'submission.attachment.update')`;
  return sql`action=${action}`;
};

Now that there's submission.update and submission.update.version, I think those should be included for action === 'submission'.
action === 'nonverbose' excludes the existing submission actions. Should it also exclude the new submission actions? My instinct is that it should, because if submission edits are part of your workflow, you probably don't want to see those on the System audits page.

I'm noticing that at least some of the PATCH endpoints don't seem to be calling forApi(). For example, the submission PATCH endpoint is returning an object with a deletedAt property even though the Submission frame doesn't include deletedAt. I think I'm seeing something similar for the project PATCH endpoint.
If they don't already, maybe it'd be useful for tests of PATCH endpoints to make assertions about the response body?

@issa-tseng, just wanted to make sure that you saw my comments above about actionCondition() and about PATCH endpoints.
Also, I think X-Action-Notes needs to be percent-decoded.

i don’t think it should be? it’s comparing against a decoded string no?

On Mar 25, 2021, at 07:45, Matthew White @.***> wrote:

@matthew-white commented on this pull request.
In lib/resources/submissions.js:

           `/submissions/${params.instanceId}`,

           `/submissions/${rootId}/versions/${params.instanceId}`

It looks like c1e41ba encodes the second URL, but I think the first still needs to be encoded.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.

I thiiink originalUrl is encoded, but params.instanceId is decoded. If that's right, I think params.instanceId need to be encoded in order to be found in originalUrl.

authors: issa-tseng matthew-white

repo: getodk/central-backend


text:
[wip] feat: Deep vars

Codecov Report

Merging #249 into master will decrease coverage by 0.6%.
The diff coverage is 69.23%.

@@            Coverage Diff            @@
##           master    #249      +/-   ##
=========================================
- Coverage   81.71%   81.1%   -0.61%
=========================================
  Files          32      34       +2
  Lines        2745    2810      +65
  Branches      443     461      +18
=========================================
+ Hits         2243    2279      +36
- Misses        340     362      +22
- Partials      162     169       +7

Impacted Files
Coverage Δ

sentry_sdk/events.py
40% <40%> (ø)

sentry_sdk/integrations/deep_vars.py
87.5% <87.5%> (ø)

sentry_sdk/debug.py
92.85% <0%> (-3.58%)
:arrow_down:

sentry_sdk/integrations/django/transactions.py
87.93% <0%> (-3.45%)
:arrow_down:

sentry_sdk/integrations/django/__init__.py
81.72% <0%> (-1.53%)
:arrow_down:

sentry_sdk/utils.py
83.4% <0%> (-0.6%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30eddcf...1a84076. Read the comment docs.

Let's revisit when we decide to do this in more sdks

authors: codecov-io untitaker

repo: getsentry/sentry-python


text:
toggling a field visibility of a tree node should intelligently toggle all children

implemented in 5f2aabfb5ad1df6c169f23bb0658cffcfb69d821

repo: ghorn/Plot-ho-matic


text:
Always use dask instead of pandas

Is good though to use dask when the data we work with is small enough? https://docs.dask.org/en/latest/dataframe-best-practices.html#use-pandas
Anyway, closing this in favor of #36

repo: giganticode/bohr-framework


text:
adicionar conceitos do capítulo 5

Não localizei no livro-jogo os conceitos.

authors: Jessica-ps boidacarapreta

repo: glass-queens/jogoweb


text:
MOE Sync

Thanks Ron!

authors: ronshapiro sameb

repo: google/guice


text:
add register_pytree_node_class, fixes #2396

Thanks Matt!

authors: mattjj shoyer

repo: google/jax


text:
chore: gts fix a few test files

Codecov Report

Merging #109 into master will decrease coverage by 0.06%.
The diff coverage is 93.46%.

@@            Coverage Diff             @@
##           master     #109      +/-   ##
==========================================
- Coverage   98.29%   98.23%   -0.07%
==========================================
  Files          15       15
  Lines        2820     2830      +10
  Branches      166      168       +2
==========================================
+ Hits         2772     2780       +8
  Misses         25       25
- Partials       23       25       +2

Impacted Files
Coverage Δ

test/paginator.ts
100% <100%> (ø)
:arrow_up:

test/operation.ts
99.44% <90%> (ø)
:arrow_up:

test/service-object.ts
97.46% <91.34%> (-0.42%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8274e6b...2f43c12. Read the comment docs.

authors: JustinBeckwith codecov-io

repo: googleapis/nodejs-common


text:
functions that start with underscores is not valid Go syntax

:100:

authors: Jasdev briankassouf

repo: gophergala/ImgurGo


text:
[WIP] Fix concatenation where divisions are unknown or divisions need to be interleaved

LGTM!


text:
Addressing pull request findings

@jeffbrown , your recommendation worked fine.  By the way, what's the process for getting this version published?  Thanks.

@jeffbrown, can you merge the fixes for the pull request findings when you get a chance?  Also, what's the process for publishing the latest version of the plugin?  Thanks.

repo: grails-plugins/grails-scaffolding


text:
[wishlist] It would be nice if the cached object has the expiration and gets deleted to free the memory space

Just realized that you have the cache interface for people to implement that.

repo: gregjones/httpcache


text:
Tomibranch-ParaComparar

Codecov Report

:exclamation: No coverage uploaded for pull request base (Entrega-1@867e58e). Click here to learn what that means.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             Entrega-1      #12   +/-   ##
============================================
  Coverage             ?   77.65%
  Complexity           ?       20
============================================
  Files                ?        9
  Lines                ?       94
  Branches             ?        6
============================================
  Hits                 ?       73
  Misses               ?       18
  Partials             ?        3

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 867e58e...71df08c. Read the comment docs.

authors: NicolasAmigo codecov-commenter


text:
SF-1204: Fix repository, issues, and homepage fields in package.json files

Codecov Report

Merging #34 into master will decrease coverage by 0.07%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #34      +/-   ##
==========================================
- Coverage   92.89%   92.82%   -0.08%
==========================================
  Files         200      196       -4
  Lines        5165     5112      -53
  Branches      627      627
==========================================
- Hits         4798     4745      -53
  Misses        282      282
  Partials       85       85

Impacted Files
Coverage Δ

...storefront/breadcrumbs/src/original-query/index.ts
100% <0%> (ø)
:arrow_up:

...orefront/breadcrumbs/src/refinement-crumb/index.ts
100% <0%> (ø)
:arrow_up:

...storefront/navigation/src/refinement-pill/index.ts
100% <0%> (ø)
:arrow_up:

...ckages/@storefront/collections/src/option/index.ts
100% <0%> (ø)
:arrow_up:

...torefront/breadcrumbs/src/corrected-query/index.ts
100% <0%> (ø)
:arrow_up:

packages/@storefront/template/src/index.ts

packages/@storefront/collections/src/index.ts

packages/@storefront/navigation/src/index.ts

packages/@storefront/query/src/index.ts

packages/@storefront/sort/src/index.ts

... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f21bafb...bab1d4f. Read the comment docs.

authors: codecov-io jrmykolyn

repo: groupby/storefront


text:
regen with intra-doc links 1/3

Apart from that doesn't actually change anything with regards to docs :)

@sdroege Indeed, this doesn't change anything for the docs themselves. I have a change in progress to teach generator.py to invoke gir for that (for GStreamer-rs), but gtk(4)-rs seem to do it in the CI. Let's move to IRC and discuss the best way forward :)

authors: MarijnS95 bilelmoussaoui sdroege


text:
add support kafka

close #99

repo: gudaoxuri/dew


text:
您好，请问有语义角色标注功能么，SRL

感谢您对HanLP1.x的支持，我一直为没有时间回复所有issue感到抱歉，希望您提的问题已经解决。或者，您可以从《自然语言处理入门》中找到答案。
时光飞逝，HanLP1.x感谢您的一路相伴。我于东部标准时间2019年12月31日发布了HanLP1.x在上一个十年最后一个版本，代号为最后的武士。此后1.x分支将提供稳定性维护，但不是未来开发的焦点。
值此2020新年之际，我很高兴地宣布，HanLP2.0发布了。HanLP2.0的愿景是下一个十年的前沿NLP技术。为此，HanLP2.0采用TensorFlow2.0实现了最前沿的深度学习模型，通过精心设计的框架支撑下游NLP任务，在海量语料库上取得了最前沿的准确率。作为第一个alpha版本，HanLP 2.0.0a0支持分词、词性标注、命名实体识别、依存句法分析、语义依存分析以及文本分类。而且，这些功能并不仅限中文，而是面向全人类语种设计。HanLP2.0提供许多预训练模型，而终端用户仅需两行代码即可部署，深度学习落地不再困难。更多详情，欢迎观看HanLP2.0的介绍视频，或参与论坛讨论。
展望未来，HanLP2.0将集成1.x时代继承下来的高效率务实风范，同时冲刺前沿研究，做工业界和学术界的两栖战舰，请诸君继续多多指教，谢谢。

repo: hankcs/HanLP


text:
HAWKULAR-633 : Add support for Remove JDBC Driver Operation

Merged #62

repo: hawkular/hawkular-ui-services


text:
HAWKULAR-20: Add navbar banner to the console

@ammendonca can we add an image of some sort, just so we are able to add assets such as images, etc to the hawt.io 2 framework.

repo: hawkular/hawkular


text:
Removed warnings from TestRunner. Fixed toString in CommandRequest.

Can do do a rebase? After that it is good to go.

Rebase done.

authors: Donnerbart pveentjer

repo: hazelcast/hazelcast-stabilizer


text:
[Feature] Implement Firebase Authentication

can you give the firebase config file plz?? i mailed you

i trying to learn React Native

repo: henettaja/water-tracker


text:
MSDKUI-2185: Update HEREMaps (3.14.2) and deployment target (iOS 12)

Codecov Report

Merging #158 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #158   +/-   ##
=======================================
  Coverage   87.53%   87.53%
=======================================
  Files          59       59
  Lines        3683     3683
=======================================
  Hits         3224     3224
  Misses        459      459

Flag
Coverage Δ

#ios
87.53% <ø> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f75d6b...d1b1f3e. Read the comment docs.

authors: PiotrSzmyt codecov-io

repo: heremaps/msdkui-ios


text:
HHH-11149 : Update plugin parameters for maven enhancer plugin

Merged. Thanks!

authors: gbadner johnaohara

repo: hibernate/hibernate-orm


text:
Test against JDK17 EA

Maybe we should stop testing JDK15 now that 16 is GA, but personally I'd wait until Quarkus starts running their CI against JDK16.

(JDK15 will EOL in about two weeks: https://endoflife.date/java)

Maybe we should stop testing JDK15 now that 16 is GA, but personally I'd wait until Quarkus starts running their CI against JDK16.

I think we can wait.

Looks like the Github action used to fetch the JDK does not provide JDK16 GA yet. Understandable, it's rather soon. I reverted part of my commit to only add JDK17 to the matrix.

Merged https://github.com/hibernate/hibernate-reactive/pull/664
Thanks!

Why did this commit check in jpamodelgen-generated code?

No idea... ? I just changed the Github config in my IDE.

Some missing entries in .gitignore, maybe?

My bad, I didn't notice

I will update the .gitignore

Some missing entries in .gitignore, maybe?

We updated the folders structure of the example and our rule wasn't generic enough.
I'm surprised they have been generated in the src folder and not in the build one though.
The fact that we had a rule implies it's not the first time it happens.

Some missing entries in .gitignore, maybe?

We updated the folders structure of the examples and our rule wasn't generic enough.
I'm surprised they have been generated in the src folder and not in the build one though.
The fact that we had a rule implies it's not the first time it happens.

Right, something must have gone wrong... maybe IDEA generating sources before it updated its metadata based on Gradle's? I hadn't worked on HR for a while.
Sorry about that, I'll be more careful next time.

authors: DavideD gavinking yrodiere

repo: hibernate/hibernate-reactive


text:
Add svg as alias in xml

@lukasoppermann Don't we need to update the README also?

Good point: #2165


text:
PRO Cursor

Solved!

repo: himakhaitan/github-portfolio


text:
adding audio element sample

Good work @peppertech .
Thanks for contributing :smile:

authors: himanshu-daga peppertech

repo: himanshu-daga/Webster


text:
Fix attention/CTC plotting

Codecov Report

Merging #172 into master will increase coverage by 0.04%.
The diff coverage is 43.20%.

@@            Coverage Diff             @@
##           master     #172      +/-   ##
==========================================
+ Coverage   37.74%   37.78%   +0.04%
==========================================
  Files          86       86
  Lines       10045    10065      +20
  Branches     2099     2111      +12
==========================================
+ Hits         3791     3803      +12
- Misses       6056     6065       +9
+ Partials      198      197       -1

Impacted Files
Coverage Δ

neural_sp/bin/asr/plot_attention.py
0.00% <ø> (ø)

neural_sp/bin/asr/plot_ctc.py
0.00% <0.00%> (ø)

neural_sp/bin/plot_utils.py
0.00% <0.00%> (ø)

neural_sp/models/seq2seq/encoders/build.py
0.00% <ø> (ø)

neural_sp/models/seq2seq/encoders/conformer.py
62.03% <0.00%> (-2.45%)
:arrow_down:

neural_sp/models/seq2seq/encoders/rnn.py
82.83% <42.85%> (ø)

neural_sp/models/seq2seq/encoders/subsampling.py
83.69% <81.81%> (ø)

neural_sp/models/seq2seq/encoders/transformer.py
79.55% <84.48%> (+0.07%)
:arrow_up:

neural_sp/models/modules/transformer.py
49.35% <0.00%> (-1.29%)
:arrow_down:

neural_sp/models/modules/cif.py
91.13% <0.00%> (+3.79%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a07eb4...abf23e3. Read the comment docs.


text:
Navigate by hash

This issue was moved to mercadolibre/Popeye#5

repo: hmammana/Popeye


text:
Use cdkTable to remove material styling

Looks good

authors: Louisblack mike-suggitt

repo: hmcts/jui-webapp


text:
enables parsing of scraped dictionary

Thanks for the PR, have you run the unit tests on this?

Yes and no breakage


text:
global: add i18n

@CarterLi

repo: housepower/ckman-fe


text:
Add archive page for past events. Fixes #304.

Coverage remained the same at 100.0% when pulling 5a39a2805064048efee3a48a39411e774e7fb20b on 304_event_archive into ba518d3dc7bf2a286a8667a466e94f05dd7bf2bd on dev.

Coverage remained the same at 100.0% when pulling 5a39a2805064048efee3a48a39411e774e7fb20b on 304_event_archive into ba518d3dc7bf2a286a8667a466e94f05dd7bf2bd on dev.

Coverage remained the same at 100.0% when pulling a3758fad6bb5f92d16bf0d61016f858d813146db on 304_event_archive into ba518d3dc7bf2a286a8667a466e94f05dd7bf2bd on dev.

Coverage remained the same at 100.0% when pulling b6b6a5de0290326135c147a9b3ccfa35103bd2c4 on 304_event_archive into ba518d3dc7bf2a286a8667a466e94f05dd7bf2bd on dev.

Coverage remained the same at 100.0% when pulling cb0811b99520af7f7d2355f742e304fb8ca6a068 on 304_event_archive into deda02c78cc9cb9b03a7b52d3344cb7caaf572cd on dev.


text:
Test pr on master

Hi ! This project doesn't usually accept pull requests on master. If this wasn't intentionnal, you can change the base branch of this pull request to devel (No need to close it for that). Best, a bot.


text:
Create clatest

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

authors: CLAassistant hudl-cla

repo: hudl/iOS-FFmpeg-processor


text:
5 tp algo

close. Implemented in #1174

repo: hugegraph/hugegraph


text:
Manage Transfers: View entity-to-entity mutual credit transfers

duplicate of #105


text:
Update setup script

Nice :)

authors: dNitza timriley

repo: icelab/berg


text:
Front Camera saves image in the right orientation instead of being mirrored

I need it to be in the right direction and not mirrored. How can i do that ?

authors: FaridHaddad raviranderia

repo: imaginary-cloud/CameraManager


text:
completed simple rails auth and basic posting fuctionality

sorry, we forgot and merged to develop branch.

I can create a post without a title or content, please address
I feel it is good to have validation and required field for title and content as a project

There required changes yo be made 😅.
Submit another review request after making changes and explain the
situation. 😊
On Fri, Sep 6, 2019, 12:28 AM Pon Muthu Selvam N notifications@github.com
wrote:

sorry, we forgot and merged to develop branch.

I can create a post without a title or content, please address
I feel it is good to have validation and required field for title and
content as a project

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/imhta/simple_rails_auth/pull/1?email_source=notifications&email_token=AHN7VX3NRPWJB5LHWJRSNL3QIHL5XA5CNFSM4ITUGW4KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6BV32I#issuecomment-528702953,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AHN7VX3D2NHVO467Q65JVILQIHL5XANCNFSM4ITUGW4A
.

Let's do this 💪
Hi Team,
You have implemented MOST of the required changes. Thank you soo much for hearing me out! 🙏
However, you have forgotten to address the helper method issue. Please address and submit another code review. Here's the link to the article again: http://codefol.io/posts/Where-Do-I-Put-My-Code/
Congrats on successfully fixing your linter issues 🎊 😅
Everything else looks fine!
Please makes changes and submit another review request. If you have any questions, let me know here or on slack and I will be glad to clarify with you. You can also reach me and connect with me on my social media or email.
Happy coding 😄,
--Maya
GitHub Twitter linkedin GitLab

Let's do this 💪
Hi Team,
You have implemented MOST of the required changes. Thank you soo much for hearing me out! 🙏
However, you have forgotten to address the helper method issue. Please address and submit another code review. Here's the link to the article again: http://codefol.io/posts/Where-Do-I-Put-My-Code/
Congrats on successfully fixing your linter issues 🎊 😅
Everything else looks fine!
Please makes changes and submit another review request. If you have any questions, let me know here or on slack and I will be glad to clarify with you. You can also reach me and connect with me on my social media or email.
Happy coding 😄,
--Maya
GitHub Twitter linkedin GitLab

I thought it was optional. Then for reference, I just looked into your repo for this project. Sorry, I believe session helper in your repo and ours are exactly the same. then what we have to change?.

Hello @imhta :wave:
You did a great job on this project. :1st_place_medal:
[OPTIONAL]

Files generated under app/helpers/controller_helper.rb are used to create helper methods for the views(templates) of that particular controller.
In other words when your views are getting bigger and maybe complex you can split your logic and create helper methods(on these helpers files) and then call them on your view.

You have some methods defined (current_user,logged_in?,store_location)on your app/helpers/sessions_helper.rband you are  calling them on your posts_controller.rb and sessions_controller.rb which is not a good practise.

If you want a method to be available on all controllers then a good place to declare them is the app/controllers/application_controller.rb.

You can go ahead and merge it.

authors: azdrenymeri imhta mcrd25


text:
Add notes on how to avoid downtime when upgrading

@beckettsean

:+1:

@mjdesa Can you rebase.  :+1:  otherwise.

@mjdesa I updated the wording in https://github.com/influxdata/docs.influxdata.com/pull/212/files#r52399685, I suggest updating this to reflect those changes.

Opening https://github.com/influxdata/influxdb/pull/5620 in favor of rebasing.

authors: beckettsean jwilder mjdesa

repo: influxdata/influxdb


text:
nixos module: do not depend on iohkNix being in provided pkgs.

bors r+

bors r-

bors r-

bors r+

authors: disassembler jbgi

repo: input-output-hk/cardano-db-sync


text:
Delegation update: incentives

@kantp there has been a repo reorganization the doc now lives in shelley/design-spec/

authors: kantp mgudemann

repo: input-output-hk/cardano-ledger-specs


text:
Update README.md

improve intro

repo: integeruser/FP-growth


text:
Deprecation markers were added

make test

make test

repo: intel/daal


text:
docs: examples: ML assisted GUI testcase execution

operation yielding video frames, operation to filter out changes such as clock, model to decide what to do, state machine?

Demo of web UI to create a data flow
Execute the data flow we created

Data flow is ML assisted testcase of Xeon platforms

Dive into how it works behind the scenes
  - Explain what operations are (building blocks of Data Flows), how can we implement them
  - How can we use ML operations in Data Flows (or without Data Flows) for inference
Show people how they can train models
  - Show how this approach to a unified model training interface benefits researchers and engineers in the community

Show how people can use models in their data flows

Re-run the dataflow from the demo again now that people know what's happening behind the scenes
Talk about how we hope to use this at Intel
  - Test case modernization, portability, and maintainability

Future applications

Questions

repo: intel/dffml


text:
Add the flag -description(desc) to the Search(Find) command; display their description with a list of modules

Description to take from a module element or readme.md file repo

repo: intersystems-community/zpm


text:
Make OmniAuth::Builder compatible with pre and post 1.4 Rack

Just ran into this (Rails 3.2 RC2 depends on Rack 1.4). Looking forward to the fix!

I got error on Rails 3.2 rc2:
undefined method `include?' for nil:NilClass

omniauth (1.0.1) lib/omniauth/builder.rb:33:in `call'
actionpack (3.2.0.rc2) lib/action_dispatch/middleware/best_standards_support.rb:17:in `call'
rack (1.4.0) lib/rack/etag.rb:23:in `call'
rack (1.4.0) lib/rack/conditionalget.rb:25:in `call'
actionpack (3.2.0.rc2) lib/action_dispatch/middleware/head.rb:14:in `call'
actionpack (3.2.0.rc2) lib/action_dispatch/middleware/params_parser.rb:21:in `call'
actionpack (3.2.0.rc2) lib/action_dispatch/middleware/flash.rb:242:in `call'
rack (1.4.0) lib/rack/session/abstract/id.rb:205:in `context'
rack (1.4.0) lib/rack/session/abstract/id.rb:200:in `call'
actionpack (3.2.0.rc2) lib/action_dispatch/middleware/cookies.rb:338:in `call'
activerecord (3.2.0.rc2) lib/active_record/query_cache.rb:64:in `call'
activerecord (3.2.0.rc2) lib/active_record/connection_adapters/abstract/connection_pool.rb:443:in `call'
actionpack (3.2.0.rc2) lib/action_dispatch/middleware/callbacks.rb:28:in `block in call'
activesupport (3.2.0.rc2) lib/active_support/callbacks.rb:405:in `_run__322102024380979004__call__3712922931995220657__callbacks'
activesupport (3.2.0.rc2) lib/active_support/callbacks.rb:405:in `__run_callback'
activesupport (3.2.0.rc2) lib/active_support/callbacks.rb:385:in `_run_call_callbacks'
activesupport (3.2.0.rc2) lib/active_support/callbacks.rb:81:in `run_callbacks'
actionpack (3.2.0.rc2) lib/action_dispatch/middleware/callbacks.rb:27:in `call'
actionpack (3.2.0.rc2) lib/action_dispatch/middleware/reloader.rb:63:in `call'
actionpack (3.2.0.rc2) lib/action_dispatch/middleware/remote_ip.rb:31:in `call'
actionpack (3.2.0.rc2) lib/action_dispatch/middleware/debug_exceptions.rb:16:in `call'
actionpack (3.2.0.rc2) lib/action_dispatch/middleware/show_exceptions.rb:56:in `call'
railties (3.2.0.rc2) lib/rails/rack/logger.rb:26:in `call_app'
railties (3.2.0.rc2) lib/rails/rack/logger.rb:16:in `call'
actionpack (3.2.0.rc2) lib/action_dispatch/middleware/request_id.rb:22:in `call'
rack (1.4.0) lib/rack/methodoverride.rb:21:in `call'
rack (1.4.0) lib/rack/runtime.rb:17:in `call'
activesupport (3.2.0.rc2) lib/active_support/cache/strategy/local_cache.rb:72:in `call'
rack (1.4.0) lib/rack/lock.rb:15:in `call'
actionpack (3.2.0.rc2) lib/action_dispatch/middleware/static.rb:53:in `call'
railties (3.2.0.rc2) lib/rails/engine.rb:479:in `call'
rack (1.4.0) lib/rack/content_length.rb:14:in `call'
railties (3.2.0.rc2) lib/rails/rack/log_tailer.rb:14:in `call'
rack (1.4.0) lib/rack/handler/webrick.rb:59:in `service'
/Users/caojinhua/.rvm/rubies/ruby-1.9.2-p290/lib/ruby/1.9.1/webrick/httpserver.rb:111:in `service'
/Users/caojinhua/.rvm/rubies/ruby-1.9.2-p290/lib/ruby/1.9.1/webrick/httpserver.rb:70:in `run'
/Users/caojinhua/.rvm/rubies/ruby-1.9.2-p290/lib/ruby/1.9.1/webrick/server.rb:183:in `block in start_thread'

@qichunren your issue is fixed in HEAD

Verified that using
gem 'omniauth', :git => 'git://github.com/intridea/omniauth.git'

in Gemfile fixes the
undefined method `include?' for nil:NilClass

exception. Can't wait for a full release!

I'm still getting this issue with HEAD, the only different thing from the trace is that sass (3.1.12) is called by builder?  could this affect the issue?
NoMethodError (undefined method include?' for nil:NilClass):   /home/sashko/.rvm/gems/ruby-1.9.3-p0@rails313/bundler/gems/omniauth-7840608a02a9/lib/omniauth/builder.rb:41:in call'
sass (3.1.12) lib/sass/plugin/rack.rb:54:in call'   actionpack (3.2.0.rc2) lib/action_dispatch/middleware/best_standards_support.rb:17:in call'
rack (1.4.0) lib/rack/etag.rb:23:in call'   rack (1.4.0) lib/rack/conditionalget.rb:25:in call'
actionpack (3.2.0.rc2) lib/action_dispatch/middleware/head.rb:14:in call'   actionpack (3.2.0.rc2) lib/action_dispatch/middleware/params_parser.rb:21:in call'
actionpack (3.2.0.rc2) lib/action_dispatch/middleware/flash.rb:242:in call'   rack (1.4.0) lib/rack/session/abstract/id.rb:205:in context'
rack (1.4.0) lib/rack/session/abstract/id.rb:200:in call'   actionpack (3.2.0.rc2) lib/action_dispatch/middleware/cookies.rb:338:in call'
activerecord (3.2.0.rc2) lib/active_record/query_cache.rb:64:in call'   activerecord (3.2.0.rc2) lib/active_record/connection_adapters/abstract/connection_pool.rb:443:in call'
actionpack (3.2.0.rc2) lib/action_dispatch/middleware/callbacks.rb:28:in block in call'   activesupport (3.2.0.rc2) lib/active_support/callbacks.rb:405:in _run__16222380__call__822328421__callbacks'
activesupport (3.2.0.rc2) lib/active_support/callbacks.rb:405:in __run_callback'   activesupport (3.2.0.rc2) lib/active_support/callbacks.rb:385:in _run_call_callbacks'
activesupport (3.2.0.rc2) lib/active_support/callbacks.rb:81:in run_callbacks'   actionpack (3.2.0.rc2) lib/action_dispatch/middleware/callbacks.rb:27:in call'
actionpack (3.2.0.rc2) lib/action_dispatch/middleware/reloader.rb:63:in call'   actionpack (3.2.0.rc2) lib/action_dispatch/middleware/remote_ip.rb:31:in call'
actionpack (3.2.0.rc2) lib/action_dispatch/middleware/debug_exceptions.rb:16:in call'   actionpack (3.2.0.rc2) lib/action_dispatch/middleware/show_exceptions.rb:56:in call'
railties (3.2.0.rc2) lib/rails/rack/logger.rb:26:in call_app'   railties (3.2.0.rc2) lib/rails/rack/logger.rb:16:in call'
actionpack (3.2.0.rc2) lib/action_dispatch/middleware/request_id.rb:22:in call'   rack (1.4.0) lib/rack/methodoverride.rb:21:in call'
rack (1.4.0) lib/rack/runtime.rb:17:in call'   activesupport (3.2.0.rc2) lib/active_support/cache/strategy/local_cache.rb:72:in call'
rack (1.4.0) lib/rack/lock.rb:15:in call'   actionpack (3.2.0.rc2) lib/action_dispatch/middleware/static.rb:53:in call'
railties (3.2.0.rc2) lib/rails/engine.rb:479:in call'   rack (1.4.0) lib/rack/content_length.rb:14:in call'
railties (3.2.0.rc2) lib/rails/rack/log_tailer.rb:14:in call'   rack (1.4.0) lib/rack/handler/webrick.rb:59:in service'
/home/sashko/.rvm/rubies/ruby-1.9.3-p0/lib/ruby/1.9.1/webrick/httpserver.rb:138:in service'   /home/sashko/.rvm/rubies/ruby-1.9.3-p0/lib/ruby/1.9.1/webrick/httpserver.rb:94:in run'
/home/sashko/.rvm/rubies/ruby-1.9.3-p0/lib/ruby/1.9.1/webrick/server.rb:191:in `block in start_thread'

@stubailo :
To use rack 1.4.0 with the good release number :
gem "rack", git: "https://github.com/rack/rack.git", ref: "e20baec005238f9876281c0d083fe5a4e01aa034"

I'm getting this error too and slainer68's suggestion worked.

So what do you think I should do here guys...I could try to rewrite the patch so that it depends on behavior not Rack.release, but that seems brittle and wrong. On the other hand, this is going to keep cropping up for people trying to use OmniAuth with 3.2 until a patch release of Rack is out.
Sigh.

I dunno man, it's really not your problem :(. A new Rack gem needs to be released ASAP (Rack::Static is completely busted in 1.4.0 as well). In the meantime, might be worth adding a note to the README?

I'm not sure about how you should deal with it. Some ducktape code to keep the system working might be a good idea, you'd just have to keep a really close eye on Rack releases to make sure things don't break.
Does anyone have a link to the related Rack bug? Because depending on how things are going over there, you might be able to glean an idea of how long this will take to fix, and whether it's worth your time to patch around.

rack 1.4.1 released fyi

Can anyone confirm that with Rack 1.4.1 this problem is fixed?

Works for me with Rack 1.4.1.

Thank you, it works fine.
I added these.
gem "rack", git: "https://github.com/rack/rack.git", ref: "e20baec005238f9876281c0d083fe5a4e01aa034"
gem 'omniauth', :git => 'git://github.com/intridea/omniauth.git'

@tanakahiroki : rack 1.4.1 was released, you don't have to stick to a git ref anymore.

I missed. I'll get 1.4.1, thank you.

authors: evilmarty icco jbhannah mbleigh qichunren slainer68 stubailo tanakahiroki twmills zapnap

repo: intridea/omniauth


text:
logger: fix logging to cluster the events

Closed in favor of #71

authors: Glignos slint

repo: inveniosoftware/invenio-github


text:
is47's file

bmbn


text:
test latest build with istioctl_url taken out

@rkpagadala: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/daily-e2e-rbac-no_auth-default.sh
dafd8e2f8e200236197a94a6a9e789ab3c47c603
link
/test daily-e2e-rbac-no_auth-default

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rkpagadala: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/daily-e2e-rbac-no_auth-default.sh
dafd8e2f8e200236197a94a6a9e789ab3c47c603
link
/test daily-e2e-rbac-no_auth-default

prow/daily-e2e-rbac-no_auth.sh
dafd8e2f8e200236197a94a6a9e789ab3c47c603
link
/test daily-e2e-rbac-no_auth

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rkpagadala: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/daily-e2e-rbac-no_auth-default.sh
dafd8e2f8e200236197a94a6a9e789ab3c47c603
link
/test daily-e2e-rbac-no_auth-default

prow/daily-e2e-rbac-no_auth.sh
dafd8e2f8e200236197a94a6a9e789ab3c47c603
link
/test daily-e2e-rbac-no_auth

prow/daily-e2e-cluster_wide-auth-default.sh
dafd8e2f8e200236197a94a6a9e789ab3c47c603
link
/test daily-e2e-cluster_wide-auth-default

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rkpagadala: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/daily-e2e-rbac-no_auth-default.sh
dafd8e2f8e200236197a94a6a9e789ab3c47c603
link
/test daily-e2e-rbac-no_auth-default

prow/daily-e2e-rbac-no_auth.sh
dafd8e2f8e200236197a94a6a9e789ab3c47c603
link
/test daily-e2e-rbac-no_auth

prow/daily-e2e-cluster_wide-auth-default.sh
dafd8e2f8e200236197a94a6a9e789ab3c47c603
link
/test daily-e2e-cluster_wide-auth-default

prow/daily-e2e-rbac-auth-default.sh
dafd8e2f8e200236197a94a6a9e789ab3c47c603
link
/test daily-e2e-rbac-auth-default

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rkpagadala: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/daily-e2e-rbac-no_auth-default.sh
dafd8e2f8e200236197a94a6a9e789ab3c47c603
link
/test daily-e2e-rbac-no_auth-default

prow/daily-e2e-rbac-no_auth.sh
dafd8e2f8e200236197a94a6a9e789ab3c47c603
link
/test daily-e2e-rbac-no_auth

prow/daily-e2e-cluster_wide-auth-default.sh
dafd8e2f8e200236197a94a6a9e789ab3c47c603
link
/test daily-e2e-cluster_wide-auth-default

prow/daily-e2e-rbac-auth-default.sh
dafd8e2f8e200236197a94a6a9e789ab3c47c603
link
/test daily-e2e-rbac-auth-default

prow/daily-e2e-rbac-auth.sh
dafd8e2f8e200236197a94a6a9e789ab3c47c603
link
/test daily-e2e-rbac-auth

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rkpagadala: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/daily-e2e-rbac-no_auth-default.sh
dafd8e2f8e200236197a94a6a9e789ab3c47c603
link
/test daily-e2e-rbac-no_auth-default

prow/daily-e2e-rbac-no_auth.sh
dafd8e2f8e200236197a94a6a9e789ab3c47c603
link
/test daily-e2e-rbac-no_auth

prow/daily-e2e-cluster_wide-auth-default.sh
dafd8e2f8e200236197a94a6a9e789ab3c47c603
link
/test daily-e2e-cluster_wide-auth-default

prow/daily-e2e-rbac-auth-default.sh
dafd8e2f8e200236197a94a6a9e789ab3c47c603
link
/test daily-e2e-rbac-auth-default

prow/daily-e2e-rbac-auth.sh
dafd8e2f8e200236197a94a6a9e789ab3c47c603
link
/test daily-e2e-rbac-auth

prow/daily-e2e-cluster_wide-auth.sh
dafd8e2f8e200236197a94a6a9e789ab3c47c603
link
/test daily-e2e-cluster_wide-auth

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

authors: istio-testing rkpagadala

repo: istio-releases/daily-release


text:
little fix on materials test

🔥

🔥

authors: Kiyooooko ivan-bonk


text:
org.jeasy.rules.core.DefaultRulesEngine.java NullPointerException #329

Thank you for raising this issue and opening this PR 👍  I think we need to add null checks for rules and facts parameters in the check and fire methods. The same issue would happen in InferenceRulesEngine which I fixed in 8109230ca08adbc69d9a889cf80e399247652b79. Don't hesitate to add your name to the contributors list in the README as well! Thank you upfront.

Thank you for your reply.
I will resubmit later.
I wish you a happy Chinese New Year.

repo: j-easy/easy-rules


text:
问下,弹幕停留5秒,如果视频暂停,让他停留时间也延长,一般是怎么做?

暂停和启动弹幕通过 start() 和 stop()。弹幕默认时间是4s。
不太明白这个问题？延长弹幕停留时间是指让弹幕暂停后变慢？

authors: jabbany whstudy

repo: jabbany/CommentCoreLibrary


text:
mark CopyDone as frontend too

Thanks!

authors: jackc mjibson


text:
Deleting accounts doesn't remove them from client configuration

Released in v9.0.0

repo: jakcodex/muledump


text:
test without skips

/gha run r-valgrind

/gha run r-valgrind

/gha run r-valgrind

/gha run r-valgrind

/gha run r-valgrind

/gha run r-valgrind

/gha run r-valgrind

repo: jameslamb/LightGBM


text:
and getter and setter for response cache

Gonna close this PR as I'm working on v4 which will have a solution for this issue ✌

Actually gonna base the implementation off of this work, so...reopening time!

well that was short-lived. I rebased it and am finishing this up over in #47 . Closing 😆

authors: conorhastings jamesplease

repo: jamesplease/fetch-dedupe


text:
Fix typos in "Actions FAQ" doc page

I think for other links I’m including the .md extension; is that approach not working on L27?

At the moment cancellation link on Actions FAQ points to https://github.com/jamesplease/redux-resource/tree/e0d24c6c69879d54e94c1ab9976b4b6a9d5adb7f/docs/recipes/canceling-requests/README.md which is 404 GitHub page.
I've added .md extension in a hope that it will fix the problem.

Ahhh right, right. Sorry I misread the diff. Thank you!! 😁

authors: gamtiq jamesplease

repo: jamesplease/redux-resource


text:
Delete legacy graphics files

Done.

repo: jbmorley/fileaway


text:
feat(tree): Added maximum binary tree problem.

Coverage remained the same at 100.0% when pulling e3f67ab70491d15459b7e440fd627b719174f987 on maximum-binary-tree into 12129f4eb2f9e75e098760a87fe90f5782e4dc5f on master.

authors: coveralls jeantimex


text:
Support multiple passwords/secrets on a single line.

Fixed by using a regexp with different start and end characters.

repo: jekor/hidepw


text:
fix: lets try the latest helmfile

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign jstrachan
You can assign the PR to them by writing /assign @jstrachan in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/approve

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: jstrachan
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [jstrachan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

authors: jenkins-x-bot-test jstrachan

repo: jenkins-x-plugins/jx-gitops


text:
Update Dockerfile update jenkins from 2.19.1 to 2.19.2

Merged this in master a0f92a484d8194c143f22b8dcfa479aaa85eaceb

authors: carlossg mudrii

repo: jenkinsci/docker


text:
README: add Macports install info

Great! Thank you!

authors: herbygillot jhspetersson

repo: jhspetersson/fselect


text:
Externalized config

Also fixes self preservation issue.

repo: jjparsons/ServiceRegistry


text:
Dino catalog updated

This is looking good.  Take a look at the comments for suggestions and improvements.  Add some command line functionality to your main runner.  Please resubmit when finished.

authors: djkotowski schwerdt


text:
1930 match data added

Great! Thanks Michael.

authors: jokecamp michaelkunc

repo: jokecamp/FootballData


text:
Add a link to an example to README.md

Working on deploying this to my site.

Example is live here

README.md has been updated to include a link to an example. Closing issue.


text:
feat: Only count languages that should be counted for jw.org

Thanks, this was a great start. I modified it further in 65a853432ebc85fd5b9eaa85bdd2e27dd18e894f to include formatter changes and more detailed info on counted and uncounted languages.

repo: jthomerson/jworg-language-info