text:
TestLocality test flakes

https://prow.istio.io/view/gs/istio-prow/pr-logs/pull/istio_istio/28170/integ-pilot-k8s-tests_istio/22361
Seems very often, likely a regression

https://prow.istio.io/view/gcs/istio-prow/pr-logs/directory/integ-pilot-k8s-tests_istio/22362

https://prow.k8s.io/view/gcs/istio-prow/pr-logs/directory/integ-pilot-k8s-tests_istio/22310
https://prow.k8s.io/view/gcs/istio-prow/pr-logs/directory/integ-pilot-k8s-tests_istio/22321
https://prow.k8s.io/view/gcs/istio-prow/pr-logs/directory/integ-pilot-k8s-tests_istio/22327
https://prow.k8s.io/view/gcs/istio-prow/pr-logs/directory/integ-pilot-k8s-tests_istio/22335

Given the first failure was on an update for proxy sha: https://github.com/istio/istio/pull/27786
and the all the other failures start exactly 5 minutes after https://github.com/istio/istio/commit/f25374ee22f8a24d848c9fe2b6cb07fac97cb2aa
I strongly suspect this is due to the Envoy update. Bumping to release blocker

multiclsuter TestTelemetry follows the same pattern - first failure is on https://github.com/istio/istio/pull/28073

https://prow.istio.io/view/gcs/istio-prow/pr-logs/directory/integ-multicluster-k8s-tests_istio/12740
https://prow.istio.io/view/gcs/istio-prow/pr-logs/directory/integ-multicluster-k8s-tests_istio/12747
https://prow.istio.io/view/gcs/istio-prow/pr-logs/directory/integ-multicluster-k8s-tests_istio/12764
https://prow.istio.io/view/gcs/istio-prow/pr-logs/directory/integ-multicluster-k8s-tests_istio/12767
for mc failures

https://storage.googleapis.com/istio-prow/pr-logs/pull/istio_istio/28176/integ-pilot-k8s-tests_istio/22370/artifacts/pilot-ffde774304c84b5bbb62c8d8f/TestTraffic/virtualservice/shifting-80_from_cluster-0/_test_context/echo-1-28407-state222252164/cluster-0/b-v1-68dcc4f485-5zhfr_istio-proxy.previous.log
Pure virtual function called!
2020-10-21T23:14:51.879473Z	critical	envoy backtrace	Caught Aborted, suspect faulting address 0x53900000018
2020-10-21T23:14:51.879502Z	critical	envoy backtrace	Backtrace (use tools/stack_decode.py to get line numbers):
2020-10-21T23:14:51.879507Z	critical	envoy backtrace	Envoy version: 46911db29bde31ba416b3d90c32f9880aebaa597/1.16.0/Clean/RELEASE/BoringSSL
2020-10-21T23:14:51.879817Z	critical	envoy backtrace	#0: __restore_rt [0x7f1a0ca528a0]
2020-10-21T23:14:51.892839Z	critical	envoy backtrace	#1: Envoy::Extensions::Common::Wasm::Context::getProperty() [0x561c22e0f28e]
2020-10-21T23:14:51.905688Z	critical	envoy backtrace	#2: proxy_wasm::exports::get_property() [0x561c22ecafb6]
2020-10-21T23:14:51.918548Z	critical	envoy backtrace	#3: Wasm::Common::(anonymous namespace)::populateRequestInfo() [0x561c22513382]
2020-10-21T23:14:51.930733Z	critical	envoy backtrace	#4: Wasm::Common::populateHTTPRequestInfo() [0x561c22512533]
2020-10-21T23:14:51.943027Z	critical	envoy backtrace	#5: proxy_wasm::null_plugin::Stats::PluginRootContext::report() [0x561c224a2138]
2020-10-21T23:14:51.955122Z	critical	envoy backtrace	#6: proxy_wasm::null_plugin::Stats::PluginContext::onLog() [0x561c224a563b]
2020-10-21T23:14:51.967397Z	critical	envoy backtrace	#7: std::__1::__function::__func<>::operator()() [0x561c22ed108c]
2020-10-21T23:14:51.979637Z	critical	envoy backtrace	#8: proxy_wasm::ContextBase::onLog() [0x561c22ec7675]
2020-10-21T23:14:51.992045Z	critical	envoy backtrace	#9: Envoy::Extensions::Common::Wasm::Context::log() [0x561c22e16385]
2020-10-21T23:14:52.004386Z	critical	envoy backtrace	#10: Envoy::Http::FilterManager::log() [0x561c23fa6ecb]
2020-10-21T23:14:52.016812Z	critical	envoy backtrace	#11: Envoy::Http::ConnectionManagerImpl::doDeferredStreamDestroy() [0x561c23fa6aa8]
2020-10-21T23:14:52.029125Z	critical	envoy backtrace	#12: Envoy::Http::ConnectionManagerImpl::doEndStream() [0x561c23fa666e]
2020-10-21T23:14:52.041761Z	critical	envoy backtrace	#13: Envoy::Http::FilterManager::encodeData() [0x561c23fbc836]
2020-10-21T23:14:52.054033Z	critical	envoy backtrace	#14: Envoy::Router::UpstreamRequest::decodeData() [0x561c2406c69e]
2020-10-21T23:14:52.068001Z	critical	envoy backtrace	#15: Envoy::Http::ResponseDecoderWrapper::decodeData() [0x561c23e788db]
2020-10-21T23:14:52.068049Z	critical	envoy backtrace	#16: Envoy::Http::ResponseDecoderWrapper::decodeData() [0x561c23e788db]
2020-10-21T23:14:52.084447Z	critical	envoy backtrace	#17: Envoy::Http::Legacy::Http1::ClientConnectionImpl::onMessageComplete() [0x561c23fce0e4]
2020-10-21T23:14:52.098235Z	critical	envoy backtrace	#18: Envoy::Http::Legacy::Http1::ConnectionImpl::onMessageCompleteBase() [0x561c23fc9c8f]
2020-10-21T23:14:52.110689Z	critical	envoy backtrace	#19: Envoy::Http::Legacy::Http1::ConnectionImpl::$_8::__invoke() [0x561c23fc6a2d]
2020-10-21T23:14:52.123525Z	critical	envoy backtrace	#20: http_parser_execute [0x561c24145d25]
2020-10-21T23:14:52.135982Z	critical	envoy backtrace	#21: Envoy::Http::Legacy::Http1::ConnectionImpl::dispatchSlice() [0x561c23fc83aa]
2020-10-21T23:14:52.148297Z	critical	envoy backtrace	#22: Envoy::Http::Legacy::Http1::ConnectionImpl::innerDispatch() [0x561c23fc7f2f]
2020-10-21T23:14:52.161917Z	critical	envoy backtrace	#23: std::__1::__function::__func<>::operator()() [0x561c23fd1002]
2020-10-21T23:14:52.174371Z	critical	envoy backtrace	#24: Envoy::Http::Utility::exceptionToStatus() [0x561c241176b7]
2020-10-21T23:14:52.187865Z	critical	envoy backtrace	#25: Envoy::Http::Legacy::Http1::ConnectionImpl::dispatch() [0x561c23fc7bc1]
2020-10-21T23:14:52.201119Z	critical	envoy backtrace	#26: Envoy::Http::CodecClient::onData() [0x561c23ed0713]
2020-10-21T23:14:52.214202Z	critical	envoy backtrace	#27: Envoy::Http::CodecClient::CodecReadFilter::onData() [0x561c23ed1f4d]
2020-10-21T23:14:52.227259Z	critical	envoy backtrace	#28: Envoy::Network::FilterManagerImpl::onContinueReading() [0x561c23d092e3]
2020-10-21T23:14:52.240551Z	critical	envoy backtrace	#29: Envoy::Network::ConnectionImpl::onReadReady() [0x561c23d05165]
2020-10-21T23:14:52.253185Z	critical	envoy backtrace	#30: Envoy::Network::ConnectionImpl::onFileEvent() [0x561c23d0301b]
2020-10-21T23:14:52.265773Z	critical	envoy backtrace	#31: Envoy::Event::FileEventImpl::assignEvents()::$_1::__invoke() [0x561c23cf8826]
2020-10-21T23:14:52.278810Z	critical	envoy backtrace	#32: event_process_active_single_queue [0x561c2413f1db]
2020-10-21T23:14:52.291354Z	critical	envoy backtrace	#33: event_base_loop [0x561c2413db3e]
2020-10-21T23:14:52.304261Z	critical	envoy backtrace	#34: Envoy::Server::WorkerImpl::threadRoutine() [0x561c23ce9913]
2020-10-21T23:14:52.316754Z	critical	envoy backtrace	#35: Envoy::Thread::ThreadImplPosix::ThreadImplPosix()::{lambda()#1}::__invoke() [0x561c24305783]
2020-10-21T23:14:52.316834Z	critical	envoy backtrace	#36: start_thread [0x7f1a0ca476db]
ActiveStream 0x3f853ec0e300, stream_id_: 2471138315549335972&filter_manager_:
  FilterManager 0x3f853ec0e378, state_.has_continue_headers_: 0, state_.decoding_headers_only_: 0, state_.encoding_headers_only_: 0
  filter_manager_callbacks_.requestHeaders():
    ':authority', 'b.echo-1-28407.svc.cluster.local'
    ':path', '/'
    ':method', 'GET'
    ':scheme', 'http'
    'user-agent', 'Go-http-client/1.1'
    'origin', 'cors.com'
    'accept-encoding', 'gzip'
    'x-forwarded-proto', 'http'
    'x-request-id', '0bd4d150-2f58-4a21-b671-033a2cdd1df9'
    'x-envoy-attempt-count', '1'
    'content-length', '0'
    'x-forwarded-client-cert', 'By=spiffe://cluster.local/ns/echo-1-28407/sa/default;Hash=ed2c3b7f35cf569c1d7b027316bef056103dc5dcde8fd123336f20db60a9ee62;Subject="";URI=spiffe://cluster.local/ns/echo-1-28407/sa/default'
    'x-b3-traceid', '9d0bd59f70103f956d835b7a7de1c40f'
    'x-b3-spanid', 'd3babae78a0cb11d'
    'x-b3-parentspanid', '6d835b7a7de1c40f'
    'x-b3-sampled', '0'
  filter_manager_callbacks_.requestTrailers():   empty
  filter_manager_callbacks_.responseHeaders():
    ':status', '200'
    'date', 'Wed, 21 Oct 2020 23:14:51 GMT'
    'content-length', '700'
    'content-type', 'text/plain; charset=utf-8'
    'x-envoy-upstream-service-time', '0'
    'x-envoy-peer-metadata', 'ChcKDkFQUF9DT05UQUlORVJTEgUaA2FwcAoaCgpDTFVTVEVSX0lEEgwaCkt1YmVybmV0ZXMKGgoNSVNUSU9fVkVSU0lPThIJGgcxLjktZGV2CuQBCgZMQUJFTFMS2QEq1gEKCgoDYXBwEgMaAWIKGQoMaXN0aW8uaW8vcmV2EgkaB2RlZmF1bHQKIQoRcG9kLXRlbXBsYXRlLWhhc2gSDBoKNjhkY2M0ZjQ4NQokChlzZWN1cml0eS5pc3Rpby5pby90bHNNb2RlEgcaBWlzdGlvCiYKH3NlcnZpY2UuaXN0aW8uaW8vY2Fub25pY2FsLW5hbWUSAxoBYgorCiNzZXJ2aWNlLmlzdGlvLmlvL2Nhbm9uaWNhbC1yZXZpc2lvbhIEGgJ2MQoPCgd2ZXJzaW9uEgQaAnYxChoKB01FU0hfSUQSDxoNY2x1c3Rlci5sb2NhbAofCgROQU1FEhcaFWItdjEtNjhkY2M0ZjQ4NS01emhmcgobCglOQU1FU1BBQ0USDhoMZWNoby0xLTI4NDA3Ck0KBU9XTkVSEkQaQmt1YmVybmV0ZXM6Ly9hcGlzL2FwcHMvdjEvbmFtZXNwYWNlcy9lY2hvLTEtMjg0MDcvZGVwbG95bWVudHMvYi12MQqBBQoRUExBVEZPUk1fTUVUQURBVEES6wQq6AQKPQoQZ2NwX2djZV9pbnN0YW5jZRIpGidna2UtcHJvdy10ZXN0LXBvb2wtdWJ1bnR1LTY3NzJjY2I5LXNwZ3EKhAEKG2djcF9nY2VfaW5zdGFuY2VfY3JlYXRlZF9ieRJlGmNwcm9qZWN0cy81NjA0MjczNzQwNjQvem9uZXMvdXMtd2VzdDEtYS9pbnN0YW5jZUdyb3VwTWFuYWdlcnMvZ2tlLXByb3ctdGVzdC1wb29sLXVidW50dS02NzcyY2NiOS1ncnAKLAoTZ2NwX2djZV9pbnN0YW5jZV9pZBIVGhM4NjIzNjU4MTYxOTgwMzg5OTY4CnAKGWdjcF9nY2VfaW5zdGFuY2VfdGVtcGxhdGUSUxpRcHJvamVjdHMvNTYwNDI3Mzc0MDY0L2dsb2JhbC9pbnN0YW5jZVRlbXBsYXRlcy9na2UtcHJvdy10ZXN0LXBvb2wtdWJ1bnR1LTRlZGRmZWMxCh4KFGdjcF9na2VfY2x1c3Rlcl9uYW1lEgYaBHByb3cKeQoTZ2NwX2drZV9jbHVzdGVyX3VybBJiGmBodHRwczovL2NvbnRhaW5lci5nb29nbGVhcGlzLmNvbS92MS9wcm9qZWN0cy9pc3Rpby1wcm93LWJ1aWxkL2xvY2F0aW9ucy91cy13ZXN0MS1hL2NsdXN0ZXJzL3Byb3cKHAoMZ2NwX2xvY2F0aW9uEgwaCnVzLXdlc3QxLWEKIQoLZ2NwX3Byb2plY3QSEhoQaXN0aW8tcHJvdy1idWlsZAokChJnY3BfcHJvamVjdF9udW1iZXISDhoMNTYwNDI3Mzc0MDY0ChcKDVdPUktMT0FEX05BTUUSBhoEYi12MQ=='
    'x-envoy-peer-metadata-id', 'sidecar~10.244.0.13~b-v1-68dcc4f485-5zhfr.echo-1-28407~echo-1-28407.svc.cluster.local'
    'server', 'istio-envoy'
  filter_manager_callbacks_.responseTrailers():   empty
  &stream_info_:
    StreamInfoImpl 0x3f853ec0e450, protocol_: 1, response_code_: 200, response_code_details_: via_upstream, health_check_request_: 0, route_name_: default

Can it be reproduced with a standalone envoy? Debug build or core would really help.

I have an ingress crashlooping in my cluster in mixologist. I am not sure a more minimal way but I am sure if you patched it with debug build it would be reproduced

Repro it with local test: https://github.com/istio/proxy/compare/master...bianpengyuan:cluster-metadata?expand=1, which send continuous cluster update with different cluster metadata. So there is race condition that during onLog, cluster metadata is deleted.

This is much easier to expose when increase concurrency, that explains why it is bad at ingress.

authors: bianpengyuan howardjohn kyessenov


text:
Support node local traffic routing

Describe the feature request
In k8s, users can specify routing traffic to node local endpoints via setting InternalTrafficPolicy = Local. In istio, we donot respect it.
But node local traffic routing is required by many users.
Options we can do:

directly use k8s api InternalTrafficPolicy, but requires Kubernetes 1.21
Support it via enhanced topology-aware load balancing.

Describe alternatives you've considered
[ ] Docs
[ ] Installation
[x] Networking
[ ] Performance and Scalability
[ ] Extensions and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
Additional context

@howardjohn @ramaraochavali @stevenctl

I think we can do 1 and 2 both?
2 is technically just using an existing API in a new way, no special code changes
for 1 it's slightly different, it means we ONLY send local - no fail over at all

I agree with @howardjohn that we probably want to have both options in the long run

source: gharchive/issue

authors: howardjohn hzxuzhonghu nrjpoddar

repo: istio/istio

license_type: permissive

license_source: github-api


text:
Failed to update validatingwebhookconfiguration

Bug Description
Hi Colleagues,
During the istio upgrade from version 1.12.8 to 1.13.9, we noticed the below error message, can you please help/suggest here?
2022-11-03T11:28:02.077131Z     error   klog    Operation cannot be fulfilled on validatingwebhookconfigurations.admissionregistration.k8s.io "istio-validator-istio-system": the object has been modified; please apply your changes to the latest version and try again
2022-11-03T11:28:02.541452Z     error   controllers     error handling /istio-sidecar-injector, retrying: Operation cannot be fulfilled on mutatingwebhookconfigurations.admissionregistration.k8s.io "istio-sidecar-injector": the object has been modified; please apply your changes to the latest version and try again     controller=webhook patcher

Version
Istio version: 1.13.9
Kubernetes Version: 1.21.14

Additional Information
No response

Hi Colleagues,
we are performing the upgrade through the helm chart its kind of a canary upgrade, initially, we noticed during the upgrade, and currently noticed that every restart of the istiod pod.
can you pls help us the impact ..!!

@thennetirajesh have you solved this problem? Is the error occurs in every istiod?

/not stale

authors: hzxuzhonghu thennetirajesh


text:
Update on conformance testing

I am curious if there is a status update on a conformance test suite for istio, similar to the K8s conformance project.
I saw there are previous, closed issues related to conformance(#14887), but the conformance tests were removed(https://github.com/istio/istio/pull/23541).   I am interested to see if tools built for  k8s conformance(apisnoop) could be extended to help with Istio's test suites.

There hasn't been any movement since 2019 until a few weeks ago where it was brought up again. There is no current decision on what will happen there, though

authors: howardjohn zachmandeville


text:
Ingress - allow headers manipulation

It should be possible to add/remove/modify headers. It would also be nice to use template-like expressions through ingress annotations or in some other way, e.g. optional-header: "Authorization: $some-existing-header"  , to create new header from existing if request contains some existing header.
There would also have to be some way to specify required values, e.g. required-header: "Something: $something | default('value')"
https://www.envoyproxy.io/docs/envoy/latest/configuration/http_conn_man/headers#custom-request-response-headers

Our upcoming gateway resource provides these features. Its unlikely to land in Kubernetes ingress implementation as it gets extremely complicated. The gateway can be stood up as a load balancer service, and configured easily through our routing rules for these purposes.

Actually could you file an issue in istio/api for ability to generate headers via routing rules? we allow adding/removing headers, but what you are asking for requires automatic generation of headers through template values..

Done.
In our case, we would need it, because our ingress will be behind Citrix's Netscaler Gateway that can remove some specific headers, so one potential solution is to "rename" headers on ingress.

@rshriram Hi! I'm using Istio ingress gateway and I can see in my browser that HTTP response headers contains some fields like:

server: envoy
x-envoy-upstream-service-time: 3

For security purpose I would like to hide this kind of information. Do you know how I could do that please?
I just found information about CORS policy with exposeHeaders property.
Thank you 🙂

It seems related to this PR (https://github.com/istio/api/pull/625) so I guess it will be released in Istio v1.0.3 ?
I hope we will have the ability to use a wildcard to use x-envoy-*

@sneko: the ability to remove response headers is being worked on here: https://github.com/istio/istio/pull/8340

@ijsnellf indeed that's a solution we can put on every VirtualService.
I'm also interested in a global solution such as removing Server header from all Istio ingress responses. Someone found a workaround by patching envoy sidecars https://github.com/istio/istio/issues/13861#issuecomment-534477416, but that's unfortunately not specific to Istio (so we cannot scope to a gateway...).

authors: Adiqq ijsnellf rshriram sneko


text:
[Helm install] ImagePullSecret does not apply to charts that doen't use serviceaccounts

Describe the bug
Istio Helm Charts applies ImagePullSecrets to ServiceAccount and the deployment(statefulset) that uses the serviceaccount inherits the ImagePullSecret from the serviceaccount.
The problem is imagePullSecrets isn't applied for components (i.e. grafana, servicegraph, tracing)  that doesn't use serviceaccounts. (Since its basically uses the default serviceaccount).
And the pods states are in ImagePullErr.
Expected behavior
ImagePullSecrets must be applied to all components of istio for users that use private image repository.
Steps to reproduce the bug
Install istio through helm with ImagePullSecret values.
helm install istio --name istio --namespace istio-system --set global.imagePullSecrets={privateregistrysecret}
Environment
Kubernetes on BM
Version
kubernetes version: 1.10.3
istio version: 1.0.0
There were a couple of workaround to make it work for my environment (Using private registry)

Simply add imagePullSecrets to deployments that doen't need RBAC (serviceaccounts)

Adjust the template in install/kubernetes/helm folder

Add imagePullSecrets to the default service-account.

I'll put in a PR with the changes I made to the deployment template

#7560

Closing due to PR merge


text:
Remove hyperistio

Signed-off-by: Chun Lin Yang clyang@cn.ibm.com
Fixed #19742

@clyang82: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

unit-tests_istio
d0bbce68fb22bbe67e7bf15e20a5f1845146a23d
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test unit-tests_istio

source: gharchive/pull-request


text:
istioctl manifest --set path updates manually cherry-picked from master

Cherry picks
https://github.com/istio/istio/pull/20631
https://github.com/istio/istio/pull/20949

@esnible: PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@esnible: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-local-tests_istio
e9ef36b93738588a8fc38c57f3b7b48c70d5e507
link
/test integ-local-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@esnible: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-local-tests_istio
e9ef36b93738588a8fc38c57f3b7b48c70d5e507
link
/test integ-local-tests_istio

integ-distroless-k8s-tests_istio
e9ef36b93738588a8fc38c57f3b7b48c70d5e507
link
/test integ-distroless-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@esnible: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-local-tests_istio
e9ef36b93738588a8fc38c57f3b7b48c70d5e507
link
/test integ-local-tests_istio

integ-distroless-k8s-tests_istio
e9ef36b93738588a8fc38c57f3b7b48c70d5e507
link
/test integ-distroless-k8s-tests_istio

integ-conformance-k8s-tests_istio
e9ef36b93738588a8fc38c57f3b7b48c70d5e507
link
/test integ-conformance-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@esnible: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-local-tests_istio
e9ef36b93738588a8fc38c57f3b7b48c70d5e507
link
/test integ-local-tests_istio

integ-distroless-k8s-tests_istio
e9ef36b93738588a8fc38c57f3b7b48c70d5e507
link
/test integ-distroless-k8s-tests_istio

integ-conformance-k8s-tests_istio
e9ef36b93738588a8fc38c57f3b7b48c70d5e507
link
/test integ-conformance-k8s-tests_istio

integ-security-k8s-tests_istio
e9ef36b93738588a8fc38c57f3b7b48c70d5e507
link
/test integ-security-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@esnible: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-local-tests_istio
e9ef36b93738588a8fc38c57f3b7b48c70d5e507
link
/test integ-local-tests_istio

integ-distroless-k8s-tests_istio
e9ef36b93738588a8fc38c57f3b7b48c70d5e507
link
/test integ-distroless-k8s-tests_istio

integ-conformance-k8s-tests_istio
e9ef36b93738588a8fc38c57f3b7b48c70d5e507
link
/test integ-conformance-k8s-tests_istio

integ-security-k8s-tests_istio
e9ef36b93738588a8fc38c57f3b7b48c70d5e507
link
/test integ-security-k8s-tests_istio

lint_istio
e9ef36b93738588a8fc38c57f3b7b48c70d5e507
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@esnible: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-local-tests_istio
e9ef36b93738588a8fc38c57f3b7b48c70d5e507
link
/test integ-local-tests_istio

integ-distroless-k8s-tests_istio
e9ef36b93738588a8fc38c57f3b7b48c70d5e507
link
/test integ-distroless-k8s-tests_istio

integ-conformance-k8s-tests_istio
e9ef36b93738588a8fc38c57f3b7b48c70d5e507
link
/test integ-conformance-k8s-tests_istio

integ-security-k8s-tests_istio
e9ef36b93738588a8fc38c57f3b7b48c70d5e507
link
/test integ-security-k8s-tests_istio

lint_istio
e9ef36b93738588a8fc38c57f3b7b48c70d5e507
link
/test lint_istio

integ-pilot-k8s-tests_istio
e9ef36b93738588a8fc38c57f3b7b48c70d5e507
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@esnible: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-local-tests_istio
e9ef36b93738588a8fc38c57f3b7b48c70d5e507
link
/test integ-local-tests_istio

integ-distroless-k8s-tests_istio
e9ef36b93738588a8fc38c57f3b7b48c70d5e507
link
/test integ-distroless-k8s-tests_istio

integ-conformance-k8s-tests_istio
e9ef36b93738588a8fc38c57f3b7b48c70d5e507
link
/test integ-conformance-k8s-tests_istio

integ-security-k8s-tests_istio
e9ef36b93738588a8fc38c57f3b7b48c70d5e507
link
/test integ-security-k8s-tests_istio

lint_istio
e9ef36b93738588a8fc38c57f3b7b48c70d5e507
link
/test lint_istio

integ-pilot-k8s-tests_istio
e9ef36b93738588a8fc38c57f3b7b48c70d5e507
link
/test integ-pilot-k8s-tests_istio

gencheck_istio
e9ef36b93738588a8fc38c57f3b7b48c70d5e507
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@esnible: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-local-tests_istio
e9ef36b93738588a8fc38c57f3b7b48c70d5e507
link
/test integ-local-tests_istio

integ-distroless-k8s-tests_istio
e9ef36b93738588a8fc38c57f3b7b48c70d5e507
link
/test integ-distroless-k8s-tests_istio

integ-conformance-k8s-tests_istio
e9ef36b93738588a8fc38c57f3b7b48c70d5e507
link
/test integ-conformance-k8s-tests_istio

integ-security-k8s-tests_istio
e9ef36b93738588a8fc38c57f3b7b48c70d5e507
link
/test integ-security-k8s-tests_istio

lint_istio
e9ef36b93738588a8fc38c57f3b7b48c70d5e507
link
/test lint_istio

integ-pilot-k8s-tests_istio
e9ef36b93738588a8fc38c57f3b7b48c70d5e507
link
/test integ-pilot-k8s-tests_istio

gencheck_istio
e9ef36b93738588a8fc38c57f3b7b48c70d5e507
link
/test gencheck_istio

integ-mixer-k8s-tests_istio
e9ef36b93738588a8fc38c57f3b7b48c70d5e507
link
/test integ-mixer-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@esnible: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-local-tests_istio
e9ef36b93738588a8fc38c57f3b7b48c70d5e507
link
/test integ-local-tests_istio

integ-distroless-k8s-tests_istio
e9ef36b93738588a8fc38c57f3b7b48c70d5e507
link
/test integ-distroless-k8s-tests_istio

integ-conformance-k8s-tests_istio
e9ef36b93738588a8fc38c57f3b7b48c70d5e507
link
/test integ-conformance-k8s-tests_istio

integ-security-k8s-tests_istio
e9ef36b93738588a8fc38c57f3b7b48c70d5e507
link
/test integ-security-k8s-tests_istio

lint_istio
e9ef36b93738588a8fc38c57f3b7b48c70d5e507
link
/test lint_istio

integ-pilot-k8s-tests_istio
e9ef36b93738588a8fc38c57f3b7b48c70d5e507
link
/test integ-pilot-k8s-tests_istio

gencheck_istio
e9ef36b93738588a8fc38c57f3b7b48c70d5e507
link
/test gencheck_istio

integ-mixer-k8s-tests_istio
e9ef36b93738588a8fc38c57f3b7b48c70d5e507
link
/test integ-mixer-k8s-tests_istio

unit-tests_istio
e9ef36b93738588a8fc38c57f3b7b48c70d5e507
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@esnible: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-local-tests_istio
e9ef36b93738588a8fc38c57f3b7b48c70d5e507
link
/test integ-local-tests_istio

integ-distroless-k8s-tests_istio
e9ef36b93738588a8fc38c57f3b7b48c70d5e507
link
/test integ-distroless-k8s-tests_istio

integ-conformance-k8s-tests_istio
e9ef36b93738588a8fc38c57f3b7b48c70d5e507
link
/test integ-conformance-k8s-tests_istio

integ-security-k8s-tests_istio
e9ef36b93738588a8fc38c57f3b7b48c70d5e507
link
/test integ-security-k8s-tests_istio

lint_istio
e9ef36b93738588a8fc38c57f3b7b48c70d5e507
link
/test lint_istio

integ-pilot-k8s-tests_istio
e9ef36b93738588a8fc38c57f3b7b48c70d5e507
link
/test integ-pilot-k8s-tests_istio

gencheck_istio
e9ef36b93738588a8fc38c57f3b7b48c70d5e507
link
/test gencheck_istio

integ-mixer-k8s-tests_istio
e9ef36b93738588a8fc38c57f3b7b48c70d5e507
link
/test integ-mixer-k8s-tests_istio

unit-tests_istio
e9ef36b93738588a8fc38c57f3b7b48c70d5e507
link
/test unit-tests_istio

release-test_istio
e9ef36b93738588a8fc38c57f3b7b48c70d5e507
link
/test release-test_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@esnible: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-local-tests_istio
e9ef36b93738588a8fc38c57f3b7b48c70d5e507
link
/test integ-local-tests_istio

integ-distroless-k8s-tests_istio
e9ef36b93738588a8fc38c57f3b7b48c70d5e507
link
/test integ-distroless-k8s-tests_istio

integ-conformance-k8s-tests_istio
e9ef36b93738588a8fc38c57f3b7b48c70d5e507
link
/test integ-conformance-k8s-tests_istio

integ-security-k8s-tests_istio
e9ef36b93738588a8fc38c57f3b7b48c70d5e507
link
/test integ-security-k8s-tests_istio

lint_istio
e9ef36b93738588a8fc38c57f3b7b48c70d5e507
link
/test lint_istio

integ-pilot-k8s-tests_istio
e9ef36b93738588a8fc38c57f3b7b48c70d5e507
link
/test integ-pilot-k8s-tests_istio

gencheck_istio
e9ef36b93738588a8fc38c57f3b7b48c70d5e507
link
/test gencheck_istio

integ-mixer-k8s-tests_istio
e9ef36b93738588a8fc38c57f3b7b48c70d5e507
link
/test integ-mixer-k8s-tests_istio

unit-tests_istio
e9ef36b93738588a8fc38c57f3b7b48c70d5e507
link
/test unit-tests_istio

release-test_istio
e9ef36b93738588a8fc38c57f3b7b48c70d5e507
link
/test release-test_istio

integ-galley-k8s-tests_istio
e9ef36b93738588a8fc38c57f3b7b48c70d5e507
link
/test integ-galley-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@esnible: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-local-tests_istio
e9ef36b93738588a8fc38c57f3b7b48c70d5e507
link
/test integ-local-tests_istio

integ-distroless-k8s-tests_istio
e9ef36b93738588a8fc38c57f3b7b48c70d5e507
link
/test integ-distroless-k8s-tests_istio

integ-conformance-k8s-tests_istio
e9ef36b93738588a8fc38c57f3b7b48c70d5e507
link
/test integ-conformance-k8s-tests_istio

integ-security-k8s-tests_istio
e9ef36b93738588a8fc38c57f3b7b48c70d5e507
link
/test integ-security-k8s-tests_istio

lint_istio
e9ef36b93738588a8fc38c57f3b7b48c70d5e507
link
/test lint_istio

integ-pilot-k8s-tests_istio
e9ef36b93738588a8fc38c57f3b7b48c70d5e507
link
/test integ-pilot-k8s-tests_istio

gencheck_istio
e9ef36b93738588a8fc38c57f3b7b48c70d5e507
link
/test gencheck_istio

integ-mixer-k8s-tests_istio
e9ef36b93738588a8fc38c57f3b7b48c70d5e507
link
/test integ-mixer-k8s-tests_istio

unit-tests_istio
e9ef36b93738588a8fc38c57f3b7b48c70d5e507
link
/test unit-tests_istio

release-test_istio
e9ef36b93738588a8fc38c57f3b7b48c70d5e507
link
/test release-test_istio

integ-galley-k8s-tests_istio
e9ef36b93738588a8fc38c57f3b7b48c70d5e507
link
/test integ-galley-k8s-tests_istio

integ-telemetry-k8s-tests_istio
e9ef36b93738588a8fc38c57f3b7b48c70d5e507
link
/test integ-telemetry-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@googlebot I consent.

/retest

Closing in favor of https://github.com/istio/istio/pull/21418

authors: esnible istio-testing


text:
[release-1.5] Add annotations for setting cpu/memory limits on sidecar

When a limitrange is active, not setting the limits will result
in an error. This patch will allow setting limits for the sidecar.
Fixes https://github.com/istio/istio/issues/16126

Hi @rolandkool. Thanks for your PR.
I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

This is a manual backport of https://github.com/istio/istio/pull/22395 for the 1.5 branch.

/ok-to-test

@rolandkool: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio_release-1.5
f8d22a38745bdce7d5a52519e7f97f21ae354d7c
link
/test unit-tests_istio_release-1.5

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test unit-tests_istio_release-1.5

@rolandkool: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio_release-1.5
f8d22a38745bdce7d5a52519e7f97f21ae354d7c
link
/test unit-tests_istio_release-1.5

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rolandkool: PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rolandkool: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio_release-1.5
f8d22a38745bdce7d5a52519e7f97f21ae354d7c
link
/test unit-tests_istio_release-1.5

integ-pilot-k8s-tests_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test integ-pilot-k8s-tests_istio_release-1.5

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rolandkool: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio_release-1.5
f8d22a38745bdce7d5a52519e7f97f21ae354d7c
link
/test unit-tests_istio_release-1.5

integ-pilot-k8s-tests_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test integ-pilot-k8s-tests_istio_release-1.5

gencheck_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test gencheck_istio_release-1.5

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rolandkool: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test integ-pilot-k8s-tests_istio_release-1.5

gencheck_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test gencheck_istio_release-1.5

unit-tests_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test unit-tests_istio_release-1.5

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rolandkool: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test integ-pilot-k8s-tests_istio_release-1.5

gencheck_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test gencheck_istio_release-1.5

unit-tests_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test unit-tests_istio_release-1.5

integ-conformance-local-tests_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test integ-conformance-local-tests_istio_release-1.5

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rolandkool: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test integ-pilot-k8s-tests_istio_release-1.5

gencheck_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test gencheck_istio_release-1.5

unit-tests_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test unit-tests_istio_release-1.5

integ-conformance-local-tests_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test integ-conformance-local-tests_istio_release-1.5

integ-galley-local-tests_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test integ-galley-local-tests_istio_release-1.5

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rolandkool: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test integ-pilot-k8s-tests_istio_release-1.5

gencheck_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test gencheck_istio_release-1.5

unit-tests_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test unit-tests_istio_release-1.5

integ-conformance-local-tests_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test integ-conformance-local-tests_istio_release-1.5

integ-galley-local-tests_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test integ-galley-local-tests_istio_release-1.5

pilot-multicluster-e2e_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test pilot-multicluster-e2e_istio_release-1.5

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rolandkool: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test integ-pilot-k8s-tests_istio_release-1.5

gencheck_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test gencheck_istio_release-1.5

unit-tests_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test unit-tests_istio_release-1.5

integ-conformance-local-tests_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test integ-conformance-local-tests_istio_release-1.5

integ-galley-local-tests_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test integ-galley-local-tests_istio_release-1.5

pilot-multicluster-e2e_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test pilot-multicluster-e2e_istio_release-1.5

lint_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test lint_istio_release-1.5

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rolandkool: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test integ-pilot-k8s-tests_istio_release-1.5

gencheck_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test gencheck_istio_release-1.5

unit-tests_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test unit-tests_istio_release-1.5

integ-conformance-local-tests_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test integ-conformance-local-tests_istio_release-1.5

integ-galley-local-tests_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test integ-galley-local-tests_istio_release-1.5

pilot-multicluster-e2e_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test pilot-multicluster-e2e_istio_release-1.5

lint_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test lint_istio_release-1.5

integ-mixer-k8s-tests_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test integ-mixer-k8s-tests_istio_release-1.5

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rolandkool: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test integ-pilot-k8s-tests_istio_release-1.5

gencheck_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test gencheck_istio_release-1.5

unit-tests_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test unit-tests_istio_release-1.5

integ-conformance-local-tests_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test integ-conformance-local-tests_istio_release-1.5

integ-galley-local-tests_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test integ-galley-local-tests_istio_release-1.5

pilot-multicluster-e2e_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test pilot-multicluster-e2e_istio_release-1.5

lint_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test lint_istio_release-1.5

integ-mixer-k8s-tests_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test integ-mixer-k8s-tests_istio_release-1.5

release-test_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test release-test_istio_release-1.5

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rolandkool: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test integ-pilot-k8s-tests_istio_release-1.5

gencheck_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test gencheck_istio_release-1.5

unit-tests_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test unit-tests_istio_release-1.5

integ-conformance-local-tests_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test integ-conformance-local-tests_istio_release-1.5

integ-galley-local-tests_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test integ-galley-local-tests_istio_release-1.5

pilot-multicluster-e2e_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test pilot-multicluster-e2e_istio_release-1.5

lint_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test lint_istio_release-1.5

integ-mixer-k8s-tests_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test integ-mixer-k8s-tests_istio_release-1.5

release-test_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test release-test_istio_release-1.5

e2e-dashboard_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test e2e-dashboard_istio_release-1.5

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rolandkool: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test integ-pilot-k8s-tests_istio_release-1.5

gencheck_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test gencheck_istio_release-1.5

unit-tests_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test unit-tests_istio_release-1.5

integ-conformance-local-tests_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test integ-conformance-local-tests_istio_release-1.5

integ-galley-local-tests_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test integ-galley-local-tests_istio_release-1.5

pilot-multicluster-e2e_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test pilot-multicluster-e2e_istio_release-1.5

lint_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test lint_istio_release-1.5

integ-mixer-k8s-tests_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test integ-mixer-k8s-tests_istio_release-1.5

release-test_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test release-test_istio_release-1.5

e2e-dashboard_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test e2e-dashboard_istio_release-1.5

integ-security-local-tests_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test integ-security-local-tests_istio_release-1.5

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rolandkool: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test integ-pilot-k8s-tests_istio_release-1.5

gencheck_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test gencheck_istio_release-1.5

unit-tests_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test unit-tests_istio_release-1.5

integ-conformance-local-tests_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test integ-conformance-local-tests_istio_release-1.5

integ-galley-local-tests_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test integ-galley-local-tests_istio_release-1.5

pilot-multicluster-e2e_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test pilot-multicluster-e2e_istio_release-1.5

lint_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test lint_istio_release-1.5

integ-mixer-k8s-tests_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test integ-mixer-k8s-tests_istio_release-1.5

release-test_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test release-test_istio_release-1.5

e2e-dashboard_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test e2e-dashboard_istio_release-1.5

integ-security-local-tests_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test integ-security-local-tests_istio_release-1.5

integ-security-k8s-tests_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test integ-security-k8s-tests_istio_release-1.5

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rolandkool: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test integ-pilot-k8s-tests_istio_release-1.5

gencheck_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test gencheck_istio_release-1.5

unit-tests_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test unit-tests_istio_release-1.5

integ-conformance-local-tests_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test integ-conformance-local-tests_istio_release-1.5

integ-galley-local-tests_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test integ-galley-local-tests_istio_release-1.5

pilot-multicluster-e2e_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test pilot-multicluster-e2e_istio_release-1.5

lint_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test lint_istio_release-1.5

integ-mixer-k8s-tests_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test integ-mixer-k8s-tests_istio_release-1.5

release-test_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test release-test_istio_release-1.5

e2e-dashboard_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test e2e-dashboard_istio_release-1.5

integ-security-local-tests_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test integ-security-local-tests_istio_release-1.5

integ-security-k8s-tests_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test integ-security-k8s-tests_istio_release-1.5

integ-telemetry-k8s-tests_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test integ-telemetry-k8s-tests_istio_release-1.5

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rolandkool: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test integ-pilot-k8s-tests_istio_release-1.5

gencheck_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test gencheck_istio_release-1.5

unit-tests_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test unit-tests_istio_release-1.5

integ-conformance-local-tests_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test integ-conformance-local-tests_istio_release-1.5

integ-galley-local-tests_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test integ-galley-local-tests_istio_release-1.5

pilot-multicluster-e2e_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test pilot-multicluster-e2e_istio_release-1.5

lint_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test lint_istio_release-1.5

integ-mixer-k8s-tests_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test integ-mixer-k8s-tests_istio_release-1.5

release-test_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test release-test_istio_release-1.5

e2e-dashboard_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test e2e-dashboard_istio_release-1.5

integ-security-local-tests_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test integ-security-local-tests_istio_release-1.5

integ-security-k8s-tests_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test integ-security-k8s-tests_istio_release-1.5

integ-telemetry-k8s-tests_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test integ-telemetry-k8s-tests_istio_release-1.5

e2e-bookInfoTests-envoyv2-v1alpha3_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test e2e-bookInfoTests-envoyv2-v1alpha3_istio_release-1.5

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rolandkool: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test integ-pilot-k8s-tests_istio_release-1.5

gencheck_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test gencheck_istio_release-1.5

unit-tests_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test unit-tests_istio_release-1.5

integ-conformance-local-tests_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test integ-conformance-local-tests_istio_release-1.5

integ-galley-local-tests_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test integ-galley-local-tests_istio_release-1.5

pilot-multicluster-e2e_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test pilot-multicluster-e2e_istio_release-1.5

lint_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test lint_istio_release-1.5

integ-mixer-k8s-tests_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test integ-mixer-k8s-tests_istio_release-1.5

release-test_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test release-test_istio_release-1.5

e2e-dashboard_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test e2e-dashboard_istio_release-1.5

integ-security-local-tests_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test integ-security-local-tests_istio_release-1.5

integ-security-k8s-tests_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test integ-security-k8s-tests_istio_release-1.5

integ-telemetry-k8s-tests_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test integ-telemetry-k8s-tests_istio_release-1.5

e2e-bookInfoTests-envoyv2-v1alpha3_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test e2e-bookInfoTests-envoyv2-v1alpha3_istio_release-1.5

integ-istioio-k8s-tests_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test integ-istioio-k8s-tests_istio_release-1.5

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rolandkool: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test integ-pilot-k8s-tests_istio_release-1.5

gencheck_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test gencheck_istio_release-1.5

unit-tests_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test unit-tests_istio_release-1.5

integ-conformance-local-tests_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test integ-conformance-local-tests_istio_release-1.5

integ-galley-local-tests_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test integ-galley-local-tests_istio_release-1.5

pilot-multicluster-e2e_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test pilot-multicluster-e2e_istio_release-1.5

lint_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test lint_istio_release-1.5

integ-mixer-k8s-tests_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test integ-mixer-k8s-tests_istio_release-1.5

release-test_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test release-test_istio_release-1.5

e2e-dashboard_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test e2e-dashboard_istio_release-1.5

integ-security-local-tests_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test integ-security-local-tests_istio_release-1.5

integ-security-k8s-tests_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test integ-security-k8s-tests_istio_release-1.5

integ-telemetry-k8s-tests_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test integ-telemetry-k8s-tests_istio_release-1.5

e2e-bookInfoTests-envoyv2-v1alpha3_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test e2e-bookInfoTests-envoyv2-v1alpha3_istio_release-1.5

integ-istioio-k8s-tests_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test integ-istioio-k8s-tests_istio_release-1.5

integ-conformance-k8s-tests_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test integ-conformance-k8s-tests_istio_release-1.5

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rolandkool: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test integ-pilot-k8s-tests_istio_release-1.5

gencheck_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test gencheck_istio_release-1.5

unit-tests_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test unit-tests_istio_release-1.5

integ-conformance-local-tests_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test integ-conformance-local-tests_istio_release-1.5

integ-galley-local-tests_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test integ-galley-local-tests_istio_release-1.5

pilot-multicluster-e2e_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test pilot-multicluster-e2e_istio_release-1.5

lint_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test lint_istio_release-1.5

integ-mixer-k8s-tests_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test integ-mixer-k8s-tests_istio_release-1.5

release-test_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test release-test_istio_release-1.5

e2e-dashboard_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test e2e-dashboard_istio_release-1.5

integ-security-local-tests_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test integ-security-local-tests_istio_release-1.5

integ-security-k8s-tests_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test integ-security-k8s-tests_istio_release-1.5

integ-telemetry-k8s-tests_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test integ-telemetry-k8s-tests_istio_release-1.5

e2e-bookInfoTests-envoyv2-v1alpha3_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test e2e-bookInfoTests-envoyv2-v1alpha3_istio_release-1.5

integ-istioio-k8s-tests_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test integ-istioio-k8s-tests_istio_release-1.5

integ-conformance-k8s-tests_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test integ-conformance-k8s-tests_istio_release-1.5

integ-distroless-k8s-tests_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test integ-distroless-k8s-tests_istio_release-1.5

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rolandkool: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test integ-pilot-k8s-tests_istio_release-1.5

gencheck_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test gencheck_istio_release-1.5

unit-tests_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test unit-tests_istio_release-1.5

integ-conformance-local-tests_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test integ-conformance-local-tests_istio_release-1.5

integ-galley-local-tests_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test integ-galley-local-tests_istio_release-1.5

pilot-multicluster-e2e_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test pilot-multicluster-e2e_istio_release-1.5

lint_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test lint_istio_release-1.5

integ-mixer-k8s-tests_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test integ-mixer-k8s-tests_istio_release-1.5

release-test_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test release-test_istio_release-1.5

e2e-dashboard_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test e2e-dashboard_istio_release-1.5

integ-security-local-tests_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test integ-security-local-tests_istio_release-1.5

integ-security-k8s-tests_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test integ-security-k8s-tests_istio_release-1.5

integ-telemetry-k8s-tests_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test integ-telemetry-k8s-tests_istio_release-1.5

e2e-bookInfoTests-envoyv2-v1alpha3_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test e2e-bookInfoTests-envoyv2-v1alpha3_istio_release-1.5

integ-istioio-k8s-tests_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test integ-istioio-k8s-tests_istio_release-1.5

integ-conformance-k8s-tests_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test integ-conformance-k8s-tests_istio_release-1.5

integ-distroless-k8s-tests_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test integ-distroless-k8s-tests_istio_release-1.5

e2e-mixer-no_auth_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test e2e-mixer-no_auth_istio_release-1.5

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rolandkool: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test integ-pilot-k8s-tests_istio_release-1.5

gencheck_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test gencheck_istio_release-1.5

unit-tests_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test unit-tests_istio_release-1.5

integ-conformance-local-tests_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test integ-conformance-local-tests_istio_release-1.5

integ-galley-local-tests_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test integ-galley-local-tests_istio_release-1.5

pilot-multicluster-e2e_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test pilot-multicluster-e2e_istio_release-1.5

lint_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test lint_istio_release-1.5

integ-mixer-k8s-tests_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test integ-mixer-k8s-tests_istio_release-1.5

release-test_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test release-test_istio_release-1.5

e2e-dashboard_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test e2e-dashboard_istio_release-1.5

integ-security-local-tests_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test integ-security-local-tests_istio_release-1.5

integ-security-k8s-tests_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test integ-security-k8s-tests_istio_release-1.5

integ-telemetry-k8s-tests_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test integ-telemetry-k8s-tests_istio_release-1.5

e2e-bookInfoTests-envoyv2-v1alpha3_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test e2e-bookInfoTests-envoyv2-v1alpha3_istio_release-1.5

integ-istioio-k8s-tests_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test integ-istioio-k8s-tests_istio_release-1.5

integ-conformance-k8s-tests_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test integ-conformance-k8s-tests_istio_release-1.5

integ-distroless-k8s-tests_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test integ-distroless-k8s-tests_istio_release-1.5

e2e-mixer-no_auth_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test e2e-mixer-no_auth_istio_release-1.5

pilot-e2e-envoyv2-v1alpha3_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test pilot-e2e-envoyv2-v1alpha3_istio_release-1.5

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rolandkool: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test integ-pilot-k8s-tests_istio_release-1.5

gencheck_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test gencheck_istio_release-1.5

unit-tests_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test unit-tests_istio_release-1.5

integ-conformance-local-tests_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test integ-conformance-local-tests_istio_release-1.5

integ-galley-local-tests_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test integ-galley-local-tests_istio_release-1.5

pilot-multicluster-e2e_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test pilot-multicluster-e2e_istio_release-1.5

lint_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test lint_istio_release-1.5

integ-mixer-k8s-tests_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test integ-mixer-k8s-tests_istio_release-1.5

release-test_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test release-test_istio_release-1.5

e2e-dashboard_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test e2e-dashboard_istio_release-1.5

integ-security-local-tests_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test integ-security-local-tests_istio_release-1.5

integ-security-k8s-tests_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test integ-security-k8s-tests_istio_release-1.5

integ-telemetry-k8s-tests_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test integ-telemetry-k8s-tests_istio_release-1.5

e2e-bookInfoTests-envoyv2-v1alpha3_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test e2e-bookInfoTests-envoyv2-v1alpha3_istio_release-1.5

integ-istioio-k8s-tests_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test integ-istioio-k8s-tests_istio_release-1.5

integ-conformance-k8s-tests_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test integ-conformance-k8s-tests_istio_release-1.5

integ-distroless-k8s-tests_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test integ-distroless-k8s-tests_istio_release-1.5

e2e-mixer-no_auth_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test e2e-mixer-no_auth_istio_release-1.5

pilot-e2e-envoyv2-v1alpha3_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test pilot-e2e-envoyv2-v1alpha3_istio_release-1.5

integ-galley-k8s-tests_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test integ-galley-k8s-tests_istio_release-1.5

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rolandkool: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test integ-pilot-k8s-tests_istio_release-1.5

gencheck_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test gencheck_istio_release-1.5

unit-tests_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test unit-tests_istio_release-1.5

integ-conformance-local-tests_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test integ-conformance-local-tests_istio_release-1.5

integ-galley-local-tests_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test integ-galley-local-tests_istio_release-1.5

pilot-multicluster-e2e_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test pilot-multicluster-e2e_istio_release-1.5

lint_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test lint_istio_release-1.5

integ-mixer-k8s-tests_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test integ-mixer-k8s-tests_istio_release-1.5

release-test_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test release-test_istio_release-1.5

e2e-dashboard_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test e2e-dashboard_istio_release-1.5

integ-security-local-tests_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test integ-security-local-tests_istio_release-1.5

integ-security-k8s-tests_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test integ-security-k8s-tests_istio_release-1.5

integ-telemetry-k8s-tests_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test integ-telemetry-k8s-tests_istio_release-1.5

e2e-bookInfoTests-envoyv2-v1alpha3_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test e2e-bookInfoTests-envoyv2-v1alpha3_istio_release-1.5

integ-istioio-k8s-tests_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test integ-istioio-k8s-tests_istio_release-1.5

integ-conformance-k8s-tests_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test integ-conformance-k8s-tests_istio_release-1.5

integ-distroless-k8s-tests_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test integ-distroless-k8s-tests_istio_release-1.5

e2e-mixer-no_auth_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test e2e-mixer-no_auth_istio_release-1.5

pilot-e2e-envoyv2-v1alpha3_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test pilot-e2e-envoyv2-v1alpha3_istio_release-1.5

integ-galley-k8s-tests_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test integ-galley-k8s-tests_istio_release-1.5

integ-pilot-local-tests_istio_release-1.5
d7079fef8c9c9e5285008030cba0c433c79a9365
link
/test integ-pilot-local-tests_istio_release-1.5

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

authors: fpesce istio-testing rolandkool stewartbutler


text:
Mark TestAnalysisWritesStatus as requiring custom setup

Since test setup has
		Setup(istio.Setup(nil, func(_ resource.Context, cfg *istio.Config) {
			cfg.ControlPlaneValues = `
values:
  pilot:
    env:
      PILOT_ENABLE_STATUS: true
  global:
    istiod:
      enableAnalysis: true
`
		})).

should be marked as requiring custom setup

@Monkeyanator: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
78f5e975bb6e21412b27d5e2188713dd084ba0f8
link
true
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test release-notes_istio

authors: Chen-Xintong Monkeyanator istio-testing


text:
Cherry pick 39947

Please provide a description of this PR:
manual cherrypick of https://github.com/istio/istio/pull/39947
also includes cherrypicks of https://github.com/istio/istio/pull/37824 and https://github.com/istio/istio/pull/37892

@GregHanson: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-pilot-multicluster_istio_release-1.13
258af01092b17c29323ebcb5e51fda4ce6f9826e
link
true
/test integ-pilot-multicluster_istio_release-1.13

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@GregHanson: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-pilot-multicluster_istio_release-1.13
258af01092b17c29323ebcb5e51fda4ce6f9826e
link
true
/test integ-pilot-multicluster_istio_release-1.13

integ-security_istio_release-1.13
258af01092b17c29323ebcb5e51fda4ce6f9826e
link
true
/test integ-security_istio_release-1.13

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Also reran CLA to get that cleared.

authors: GregHanson ericvn istio-testing


text:
basic istio ascii art

Please provide a description of this PR:
location still TBD, suggestions please
the intent would be to use this in istioctl. potentially components might embed and print during startup

@ilrudie: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
39dbbb2d31b7bebb09fa5effee455880de29c077
link
true
/test release-notes

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

https://pkg.go.dev/github.com/fatih/color may be an option for adding colored output

Would love to preview the result in istioctl before approval - is it possible?

Yeah, I think that would be possible.

@ilrudie: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
00a929e153ef52c1462184af71976634db273cda
link
true
/test release-notes

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ilrudie: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
00a929e153ef52c1462184af71976634db273cda
link
true
/test release-notes

lint_istio
00a929e153ef52c1462184af71976634db273cda
link
true
/test lint

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ilrudie: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

lint_istio
00a929e153ef52c1462184af71976634db273cda
link
true
/test lint

release-notes_istio
c12cff0212d16f05985365dd2a907d6521e91f4e
link
true
/test release-notes

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ilrudie: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

lint_istio
00a929e153ef52c1462184af71976634db273cda
link
true
/test lint

release-notes_istio
c12cff0212d16f05985365dd2a907d6521e91f4e
link
true
/test release-notes

unit-tests-arm64_istio
c12cff0212d16f05985365dd2a907d6521e91f4e
link
true
/test unit-tests-arm64

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ilrudie: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
c12cff0212d16f05985365dd2a907d6521e91f4e
link
true
/test release-notes

unit-tests-arm64_istio
c12cff0212d16f05985365dd2a907d6521e91f4e
link
true
/test unit-tests-arm64

lint_istio
c12cff0212d16f05985365dd2a907d6521e91f4e
link
true
/test lint

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ilrudie: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
c12cff0212d16f05985365dd2a907d6521e91f4e
link
true
/test unit-tests-arm64

lint_istio
c12cff0212d16f05985365dd2a907d6521e91f4e
link
true
/test lint

release-notes_istio
3bf4287aee24af8736879970adba34ca998f43af
link
true
/test release-notes

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ilrudie: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
3bf4287aee24af8736879970adba34ca998f43af
link
true
/test release-notes

lint_istio
3bf4287aee24af8736879970adba34ca998f43af
link
true
/test lint

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ilrudie: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

lint_istio
3bf4287aee24af8736879970adba34ca998f43af
link
true
/test lint

release-notes_istio
4c5ccaccfd661d2d9d082e230b212da2f07ee5a9
link
true
/test release-notes

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

example colored ascii art

/test unit-tests

authors: ilrudie istio-testing linsun


text:
proxy segfault

Happened after testing with ~1000 requests for a long time.
Stack trace on envoy:
(gdb) bt
#0  0x0000000003357c08 in ?? ()
#1  0x0000000000448acf in std::_Function_handler<void (google::protobuf::util::Status const&), Http::Mixer::Instance::decodeHeaders(Http::HeaderMap&, bool)::{lambda(google::protobuf::util::Status const&)#1}>::_M_invoke(std::_Any_data const&, google::protobuf::util::Status const&) ()
#2  0x0000000000526946 in Event::DispatcherImpl::runPostCallbacks() ()
#3  0x000000000078ef81 in event_process_active_single_queue (base=base@entry=0x308e2c0, activeq=0x2efc210, max_to_process=max_to_process@entry=2147483647, endtime=endtime@entry=0x0) at event.c:1646
#4  0x000000000078f887 in event_process_active (base=0x308e2c0) at event.c:1738
#5  event_base_loop (base=0x308e2c0, flags=0) at event.c:1961
#6  0x00000000005213d1 in Worker::threadRoutine(Server::GuardDog&) ()
#7  0x00000000005c797e in Thread::Thread::Thread(std::function<void ()>)::{lambda(void*)#1}::_FUN(void*) ()
#8  0x00007f3a7aec766a in __reclaim_stacks () at allocatestack.c:946
#9  0xa7db176b218c89d7 in ?? ()
#10 0x0000000000000000 in ?? ()

@qiwzhang @mandarjog another race...

Created https://github.com/istio/proxy/issues/286 in istio/proxy

Could you

@costinm which version of proxy are you using?   It seems I may have fixed it by https://github.com/istio/proxy/pull/280

please follow the issue upstream in istio/proxy.

authors: costinm kyessenov qiwzhang

repo: istio/manager


text:
Maint/70 translate class names and ids to english

Description

Translated code (class names, IDs, comments) to english
Translated constants (e.g. messages) to english
Translated templates to english

Reference
Issues #70

Info: Still have to do formatting here.

repo: it-at-m/refarch-templates

license: MIT


text:
Update architecture doc

오랜만에 풀리퀘입니다... 회사 일 때문에 바쁘다 보니 ㅜㅜ
아키텍처 문서를 업데이트 했습니다. 우선,

Logical architecture (개념 수준 아키텍처)
개념 수준 아키텍처는 "실행 시 시스템 구조"를 묘사하는 아키텍처 모델입니다. 이 그림에서 CLI 컴포넌트는 아키텍처적으로 중요하지도 않은데 마치 핵심 요소인것처럼 묘사되어 혼동을 주기 때문에 삭제했습니다. 이 그림에서 핵심은 우린 독립적으로 동작하는 여러 컴포넌트들이 존재하고, 이들이 RabbitMQ를 통해 비동기로 소통하며, RabbitMQ도 독립적인 프로세스로 구동된다는 점을 보여주는 것입니다.

Module architecture (모듈 아키텍처)
모듈 아키텍처는 "코드 측면에서의 시스템 구조"를 묘사하는 아키텍처 모델입니다. 주된 목적은 실제 코드에서 infra, api, domain 사이의 의존 관계(사용 관계)를 정리하기 위함입니다. 개발 할 때 도움이 되면 좋겠습니다.

@frontalnh @byron1st
기존내용중에서 Domain, infra, api, factory등을 설명하는 부분을 추가된 부분에 추가 설명으로 넣는거는 어떤가요?

@frontalnh @junbeomlee 님 말씀대로 기존 내용 중 Domain, infra, .. 등 설명은 남기는 것이 좋을 것 같습니다. 그 설명이 있어서 제가 따로 달지 않았었습니다.

@frontalnh 님 추가 작업을 위해 일단 머지하겠습니다.

늦게 확인해 죄송합니다 좋습니다~~!

authors: byron1st junbeomlee junk-sound

repo: it-chain/it-chain-Engine


text:
[QUESTION] multissesion sync

Hello, it's possible to sync information trought terminals but avoid the screen to go to top or bottom when the sync is done?
If for some reason in one terminal i'm looking for something (note in plate or other thing) and I scrolled to specific point, if someone do a change in the other terminal, the scroll go to the end of the order and I need search the line i need to see again.

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@dhecar Hello, which version of Odoo? I will check

@dhecar Yes, it is a problem for the same orders only.
It most likely that we will work on this issue only if you provide proof of the payment for this module
https://www.odoo.com/apps/modules/11.0/pos_multi_session_restaurant/

@GabbasovDinar No, if I make a change in other order i get the same, every sync make an update in all orders and move the scroll

@dhecar Hello, we have tested versions 10.0, 11.0 and 12.0 for this problem. Order scrolling causes only for the same order.
This is because the user must see the total order amount to ensure before making the payment.
Do you have any other suggestions on this subject?

repo: it-projects-llc/pos-addons

license: mit

license_source: bigquery


text:
[UBS courier] Field "Your order numbers"  is displayed incorrectly

Environment: Windows 10 Pro, Browser: Google Chrome 91.0.4472.124 (Official Build) (64-bit)
Reproducible: always
Build found: July 13 2021
Preconditions
1.Go to the GreenCity : https://ita-social-projects.github.io/GreenCityClient/#/
2.Click on 'Увійти'
3.Log in as a registered user .
4.Click on 'UBS кур'єр' tab
Steps to reproduce
1.On "Деталі замовлення" step choose the order amount (Minimal amount is 500 UAH)
2.In "Еко магазин" block type first order number and second order number(e.g., 1111111111,2222222222)
3.Click on "Далі" button
4.Fill in the fields with correct data
5.Click on "Далі" button
6.Check the "Доставка з Еко магазину" block
Actual result
Numbers are displayed  with comma after second number

Expected result
The text "Номери ваших замовлень:
1111111111, 2222222222  " is displayed.

User story and test case links
[Test case]https://jira.softserve.academy/browse/GC-2060
https://jira.softserve.academy/browse/GC-2059
Labels to be added
"Bug"

The same bug as https://github.com/ita-social-projects/GreenCity/issues/2949

repo: ita-social-projects/GreenCity


text:
[UBS Admin.Orders] Admin cannot save changes in the 'Information about client(Sender)' block after modifying the information.

Environment:
Windows 11 Pro (Version 22H2)
Chrome version 114.0.5735.199
Reproducible: always,
Build found: 11/07/2023
Preconditions

Go to https://www.testgreencity.ga/GreenCityClient/#/ubs
Sign in as Super Admin
Go to the Super Admin profile and choose the UBS-Admin item
Choose the 'Orders' item
Click on the Order's number in the Order table (except orders with 'Done'/ 'Canceled' statuses)

Steps to reproduce

Go to the block 'Information about client of Sender'
Change Name, Surname, Phone or Email
Scroll down to the save button and click on

Actual result
The block 'Information about client(Sender)' is not changed
Expected result
The block 'Information about client(Sender)' must contain modified information
https://github.com/ita-social-projects/GreenCity/assets/117460264/51da6eb5-02a6-44b9-a26b-e4002e48de28

The admin has no permission to edit the data of the sender.
This is already not a bug. This functionality work is correct.
Tnx.


text:
Create input field component

Implemented a reusable InputField component that meets the standards of the design system. This component will be used throughout the application to maintain consistency in input field styles, behavior, and accessibility. Added it to the storybook, wrote tests for it
https://youtu.be/rINxNyt-b8E

teammate that add comment should resolve it

authors: Mav-Ivan PavloButynets

repo: ita-social-projects/SpaceToStudy-Client


text:
EN112 - Il procedimento indicato èinesistente

Comune di Cortina d'Ampezzo - Produzione
Inviando e concludendo l'operazione numero 1428698 operazione di cancellazione del cittadino IDANPR 19086436 ho l'errore in oggetto.
Tuttavia l'operazione pare conclusa correttamente.
Grazie

Il messaggio in oggetto non si riferisce all'operazione indicata.  Chiarito telefonicamente

authors: RBiasi gcarbonin

repo: italia/anpr


text:
Credential Request Client Assertion Type

[ ] client_assertion_type=urn:ietf:params:oauth:client-assertion-type:jwt-key-attestation doesn't exist in the IANA Registry and in the vcstuff drafts, like OAuth 2.0 Attestation-Based Client Authentication.

Do you have any ref to the draft where the current client_attestation_type is defined?
If not, I suggest to change it to urn:ietf:params:oauth:client-assertion-type:jwt-bearer or urn:ietf:params:oauth:client-assertion-type:jwt-client-attestation

Please note that in the current example in the specs the client_assertion is missing
{
"response_type":"code",
"client_id":"$thumprint-of-the-jwk-in-the-cnf-wallet-attestation$",
"state":"fyZiOL9Lf2CeKuNT2JzxiLRDink0uPcd",
"code_challenge":"E9Melhoa2OwvFrEMTJguCHaoeK1t8URWbuGJSstw-cM",
"code_challenge_method":"S256",
"authorization_details":[
{
    "type":"openid_credential",
    "format": "vc+sd-jwt",
    "credential_definition": {
        "type": ["PersonIdentificationData"]
    }
}
],
"redirect_uri":"eudiw://start.wallet.example.org",
"client_assertion_type":"urn:ietf:params:oauth:client-assertion-type:jwt-key-attestation",
}

The value was taken from a OAuth 2.0 Attestation-Based Client Authentication draft but in the meantime was changed.
https://github.com/vcstuff/draft-ietf-oauth-attestation-based-client-auth/pull/11/files
I'm in favour of  urn:ietf:params:oauth:client-assertion-type:jwt-client-attestation.

authors: fmarino-ipzs peppelinux

repo: italia/eudi-wallet-it-docs


text:
Perdita della sessione al rientro sull'Error action

Siamo partiti dall'applicazione Asp.Net e l'abbiamo personalizzata, introducendo l'uso di una sessione su cookie (quindi i classici app.UseSession() e services.AddSession(opts)) per poter garantire che richieste contemporanee da parte di utenti diversi non si sovrappongano.
Il primo punto dove usiamo la sessione è nell'Index action, dove ci salviamo una serie di parametri di rientro.
Quando l'autenticazione con l'IdP va a buon fine e rientriamo nella LoggedIn action, la sessione è corretta e ritroviamo i parametri salvati.
Quando l'autenticazione invece fallisce per qualsiasi motivo, rientriamo nell'Error action e la sessione è diversa.
Non riusciamo a capire la ragione di questo comportamento. Qualche aiuto?

Non è necessario usare la sessione per correlare le richieste e le risposte o per orchestrare richieste diverse da parte di utenti diversi, la libreria già si occupa di queste questioni, ed in particolare salva le informazioni che le occorrono all'interno del cookie criptato "Spid.Properties". Occhio che il cookie è "Secure", per cui è necessario verificare che le pagine siano ospitate in https.
Per altre questioni "esterne" rispetto all'uso specifico della libreria (visto che la libreria non usa, e quindi non invalida, la sessione) non so darti molto aiuto senza vedere il codice, ma, appunto, in quel caso è codice esterno.

Eppure qualche differenza ci deve essere, perché trattiamo la sessione esattamente nello stesso modo tra le due action, ma in un caso c'è e nell'altro no.
Dovrebbe essere semplice da replicare, partendo dall'applicazione Asp.Net così com'è:

Si aggiunge la gestione della sessione via cookies in Startup.cs.
Nella Index action si salva un valore convenzionale in sessione (HttpContext.Session).
Nella LoggedIn action si prova a recuperarlo e loggarlo.
Idem nella Error action, si prova a recuperarlo e loggarlo.

Fatto questo, usando il Validator locale già si dovrebbe vedere il problema. Se la risposta dal Validator è positiva, nella LoggedIn dovrebbe recuperare correttamente il valore in sessione. Viceversa, se la risposta dal Validator è negativa (per es. uno qualsiasi degli errori di credenziali), il valore sulla sessione dovrebbe essere assente.

Come detto da Daniele, la libreria non fa uso di variabili di sessione o affini. Tuttavia, per essere sicuri di non avere problemi, prova a inviare un progetto di test che riproduce il problema e proveremo a dargli un'occhiata.

Sul cookie, oltre a SECURE, che sia samesite none altrimenti Chrome lo blocca e httponly come buona pratica . FYI

Si Giuseppe, è già impostato come SameSite=None, non lo avevo specificato nella risposta perchè non mi sembrava pertinente al problema specifico, ma hai fatto bene a sottolinearlo

Se non ci sono aggiornamenti su questa Issue sarei propenso a chiuderla.

authors: danielegiallonardo gianlucabertani peppelinux sm15455

repo: italia/spid-aspnetcore