text:
Fix Current_user being NULL after reset connection (#2994)

Before this commit, if the current session had triggered a Tds Reset Connection then the current_user of the session would be set to NULL instead of the databases' default user. This was happening since we were resetting session_authorization which was initially copied from PG's Discard All function. This is not needed since we have fixed the Database Context being reset in an earlier commit, removing this redundant line of code will maintain the user being set after the "USE DB" execution for DbContextReset. With this commit we also enable pooling=true for the dotnet framework.
Check List

[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is under the terms of the Apache 2.0 and PostgreSQL licenses, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Pull Request Test Coverage Report for Build 11218607952
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.001%) to 73.678%

Totals

Change from base Build 11160092314:
-0.001%

Covered Lines:
42958

Relevant Lines:
58305

💛  - Coveralls

authors: KushaalShroff coveralls


text:
fix the bug instead of trigger behaves wrongly in recursively call

recursively call the instead of trigger may lose the last DML to the triggered table
instead of trigger behaves wrongly in recursively call
It happens in this scenario when there is recursively call inside the instead of trigger like this:
when DML trigger instead of trigger A_trigger, and inside A_trigger statement block

condition i : it'll execute a DML statement and trigger A_trigger again
condition ii : it'll execute a DML statement and trigger another B_trigger, and inside definition of B_trigger, it'll meets the condition i or condition ii

the right behavior should be : second call of A_trigger should not be triggered, which is to say, the second DML should execute as normal DML do, not executed like a DML with instead of trigger.
Task: BABEL-3115 & BABEL-3116 & BABEL-3118
Signed-off-by: Zhibai Song szh@amazon.com
Description
Row inserted by an INSTEAD-OF INSERT trigger is missing in the example below:
-- repro in Babelfish:
1>
2> CREATE TABLE t
3> (
4> c1 int IDENTITY(1,1) PRIMARY KEY,
5> c2 varchar(20) UNIQUE,
6> );
7>
8> INSERT INTO t(c2)
9> VALUES ('Joe'), ('Steve');
10>
11>
12> SELECT * FROM t
13> GO
c1          c2
----------- --------------------
          1 Joe
          2 Steve
1>
2> CREATE TRIGGER TR_t ON t
3> INSTEAD OF INSERT
4> AS
5>  DECLARE @c1 int, @c2 varchar(20)
6> SELECT @c1 = c1, @c2 = c2 FROM inserted
7> INSERT INTO t (c2) VALUES(@c2 + '2') --BUG: This INSERT disappears
8> GO
1>
2> INSERT INTO t(c2) VALUES ('Joe')
3> GO
1>
2> --There should be 3 rows, but there are only 2 rows. The INSERT from the trigger is lost.
3> SELECT * FROM t
4> GO
c1          c2
----------- --------------------
          1 Joe
          2 Steve

Explanation:

Insert inside instead of trigger causes a recursive trigger execution
A recursive trigger execution is capped at nesting level of one and should be a no-op.
We skip both DML and trigger execution but we should execute the original DML as trigger is a no-op.

The same problem will happen for Delete/Update as well.
Issues Resolved
The fix identifies a recursive instead of trigger and do the DML execution without instead of trigger
Check List

[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is under the terms of the Apache 2.0 and PostgreSQL licenses, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

This PR also removes the unnecessary logfile. Once #337 is merged, we just need to resolve the conflict. But, we should improve the commit message.

I have updated my commit msg

It's because this behavior is different from PG

source: gharchive/pull-request

authors: forestkeeper kuntalghosh

license_type: permissive

license_source: github-api


text:
Set different class to tabs for different window

Fix: https://github.com/babyman/quick-tabs-chrome-extension/issues/350

Thanks for this, if you're using it to create something cool would you consider sharing in https://github.com/babyman/quick-tabs-chrome-extension/tree/master/3rdParty/css?
I have submitted the changes to the app store for review and release.
Evan

I make the PR to show how I use that.
https://github.com/babyman/quick-tabs-chrome-extension/pull/352

authors: babyman kjelly

repo: babyman/quick-tabs-chrome-extension


text:
🛑 SM Service is down

In b6d0075, SM Service (http://smservice.de) was down:

HTTP code: 0
Response time: 0 ms

Resolved: SM Service is back up in 1e5bf2c.

source: gharchive/issue

repo: bachmannschumacher/upptime

license: MIT


text:
🛑 SM Service is down

In afcbcff, SM Service (http://smservice.de) was down:

HTTP code: 0
Response time: 0 ms

Resolved: SM Service is back up in beaf3d6 after 16 minutes.


text:
🛑 SM Service is down

In 1a6445a, SM Service (http://smservice.de) was down:

HTTP code: 0
Response time: 0 ms

Resolved: SM Service is back up in 893c5c1 after 14 minutes.


text:
🛑 SM Service is down

In fd1546b, SM Service (http://smservice.de) was down:

HTTP code: 0
Response time: 0 ms

Resolved: SM Service is back up in 88f9f89 after 14 minutes.


text:
Ghost Toast?

There seems to be some invisible/ghost toast near the top of my app's screen which stops me from being able to press any button is the region

any idea why this happens?

@kyle-belle I noticed that as well. After a toast is dismissed, it stays on the screen for half a second while being invisible (0 opacity). It still reacts to taps. Here's my patch to push it off the screen (I use npx patch-package):
`diff --git a/node_modules/@backpackapp-io/react-native-toast/src/components/Toast.tsx b/node_modules/@backpackapp-io/react-native-toast/src/components/Toast.tsx
index a16cb43..9e1f067 100644
--- a/node_modules/@backpackapp-io/react-native-toast/src/components/Toast.tsx
+++ b/node_modules/@backpackapp-io/react-native-toast/src/components/Toast.tsx
@@ -86,9 +86,9 @@ export const Toast: FC = ({
const startingY = useMemo(
() =>
toast.position === ToastPosition.TOP

   ? -50

   ?  - (toast.height || DEFAULT_TOAST_HEIGHT) - insets.top - 50
   : height - insets.bottom - Platform.select({ ios: 0, default: 32 }),

[height, toast.position, insets.bottom]

[height, toast.position, insets.bottom, insets.top, toast.height]
);

const opacity = useSharedValue(0);
`

@kyle-belle I noticed that as well. After a toast is dismissed, it stays on the screen for half a second while being invisible (0 opacity). It still reacts to taps. Here's my patch to push it off the screen (I use npx patch-package):
@backpackapp-io+react-native-toast+0.10.0.patch

Thanks! @marcin-spotio should be fixed in next version

authors: kyle-belle marcin-spotio nickdebaise

repo: backpackapp-io/react-native-toast


text:
error Entity reference must not be empty

Expected Behavior
Hi, I just updated some packages, but I got an error when using template.  It seemed cannot create pull request
Actual Behavior

Steps to Reproduce

Context

Also, I created this app in June last year, so some packages might have legacy version, and I just update some package manually.
Your Environment

Browser Information:

Output of yarn backstage-cli info:

➜ backstage (SIP-4394) ✗ yarn backstage-cli info
yarn run v1.22.15
$ /Users/chuliang.zhang/sre/backstage/node_modules/.bin/backstage-cli info
OS:   Darwin 20.6.0 - darwin/x64
node: v14.17.6
yarn: 1.22.15
cli:  0.10.5 (installed)

Dependencies:
  @backstage/app-defaults                         0.1.9, 0.2.1
  @backstage/backend-common                       0.10.9, 0.12.1, 0.13.1
  @backstage/catalog-client                       0.5.5, 0.6.0, 0.7.2, 0.8.0, 0.9.0, 1.0.0
  @backstage/catalog-model                        0.10.1, 0.11.0, 0.12.1, 0.13.0, 0.9.10, 1.0.0
  @backstage/cli-common                           0.1.8
  @backstage/cli                                  0.10.5
  @backstage/config-loader                        0.9.7, 1.0.0
  @backstage/config                               0.1.15, 1.0.0
  @backstage/core-api                             0.2.23
  @backstage/core-app-api                         0.3.1, 0.5.4, 0.6.0
  @backstage/core-components                      0.8.10, 0.9.2
  @backstage/core-plugin-api                      0.1.13, 0.4.1, 0.5.0, 0.6.1, 0.7.0, 0.8.0, 1.0.0
  @backstage/core                                 0.7.14
  @backstage/dev-utils                            0.2.25
  @backstage/errors                               0.1.5, 0.2.2, 1.0.0
  @backstage/integration-react                    0.1.25
  @backstage/integration                          0.7.5, 0.8.0, 1.0.0
  @backstage/plugin-api-docs                      0.6.22
  @backstage/plugin-app-backend                   0.3.30
  @backstage/plugin-auth-backend                  0.5.2
  @backstage/plugin-auth-node                     0.1.6
  @backstage/plugin-catalog-backend-module-github 0.1.1
  @backstage/plugin-catalog-backend-module-ldap   0.3.15
  @backstage/plugin-catalog-backend               0.23.1, 0.24.0, 1.0.0
  @backstage/plugin-catalog-common                0.1.4, 0.2.2, 1.0.0
  @backstage/plugin-catalog-import                0.7.10
  @backstage/plugin-catalog-react                 0.6.15, 0.9.0, 1.0.0
  @backstage/plugin-catalog                       0.10.0, 0.7.12
  @backstage/plugin-cost-insights                 0.10.2
  @backstage/plugin-github-actions                0.4.36
  @backstage/plugin-kubernetes-backend            0.4.13
  @backstage/plugin-kubernetes-common             0.2.8
  @backstage/plugin-kubernetes                    0.5.8
  @backstage/plugin-org                           0.5.3
  @backstage/plugin-pagerduty                     0.3.30
  @backstage/plugin-permission-common             0.5.3
  @backstage/plugin-permission-node               0.5.5
  @backstage/plugin-permission-react              0.3.4
  @backstage/plugin-proxy-backend                 0.2.24
  @backstage/plugin-scaffolder-backend            0.18.0
  @backstage/plugin-scaffolder-common             0.1.3, 0.2.3, 0.3.0, 1.0.0
  @backstage/plugin-scaffolder                    0.11.18
  @backstage/plugin-search-common                 0.3.2
  @backstage/plugin-search                        0.5.6
  @backstage/plugin-tech-radar                    0.5.10
  @backstage/plugin-techdocs-backend              0.12.3
  @backstage/plugin-techdocs-node                 1.0.0
  @backstage/plugin-techdocs                      0.12.14
  @backstage/plugin-user-settings                 0.3.21
  @backstage/search-common                        0.2.4, 0.3.2
  @backstage/techdocs-common                      0.11.13
  @backstage/test-utils                           0.2.6, 0.3.0
  @backstage/theme                                0.2.15
  @backstage/types                                0.1.3, 1.0.0
  @backstage/version-bridge                       0.1.2, 1.0.0
✨  Done in 0.74s.

Hi, thank you for reporting! Could you upgrade to a more recent release before we investigate this any further? Just to make sure this isn't something that has already been fixed. You can find more information about the upgrade process over here.

Hi @Rugvip, I fixed it when I upgrade all the packages. I got one more question when I do a migration to v1beta3 templates. I got an error.

I think the problem is here.

repo: backstage/backstage


text:
🐛 Bug Report: yarn backstage-cli versions:bump --release X.Y.Z installs latest instead for many plugins

📜 Description
if we try to use backstage-cli to target an intermediate non-latest release version, e.g.
yarn backstage-cli versions:bump --release 1.7.2,
the versions added/installed to package.json use ^ which for A.B.C version format would increase B to latest available, but for most/all Backstage plugins that is the effectively major version, i.e. can have breaking changes when increased.
👍 Expected behavior
It seems like it would make more sense to hard pin the version (no ^, ~ etc)
👎 Actual Behavior with Screenshots
yarn backstage-cli versions:bump --release 1.7.2 produces installed plugins with many much more recent versions, eg we had to implement fixes only mentioned in release notes for 1.15.1.
👟 Reproduction steps
On an older installation of Backstage, eg 1.5.1, run:
yarn backstage-cli versions:bump --release 1.7.2
and compare installed version in yarn.lock against package.json. Many plugins will have a version that is the latest Backstage release instead of the targeted version in the command
📃 Provide the context for the Bug.
As we were behind on versions recently we wanted to target an intermediate version to avoid too many breaking changes in one upgrade task, but hit on the above problem, causing other complications, as we get versions different from upgrade-helper, we see items to fix covered in release notes of versions far beyond our target version, etc.
Also different developers working on their plugins running the same command ended up with different plugin versions in yarn.lock, depending on when they ran it and what was the latest released for the plugin, instead of a pinned target version.
🖥 Your Environment
Should occur on any environment, as this is due to the ^ included in package.json versions.
👀 Have you spent some time to check if this bug has been raised before?

[X] I checked and didn't find similar issue

🏢 Have you read the Code of Conduct?

[X] I have read the Code of Conduct

Are you willing to submit PR?
No, I don't have time to work on this right now

@Rugvip I would like to work on this. Could you please assign me this?

Assigned!
I'm not sure what the exact best behavior is here - semver to "equal or best compatible higher" should ideally be safe. Maybe it could be an option to use exact versions or not? @Rugvip FYI.

Note also that ^ for 0.x versions only is meant to bump the patch version, because for zero-major packages. This is what npm and yarn do. Did you see a different behavior than that?

@freben I saw that mostly ^ has been used which is automatically updating to major versions.

Are you sure? Do you have an example of a package name, and the version range that it started with, and the version you got resolved to in the end?

Note the separate treatment of 0.x versions in the NPM docs

@freben
https://github.com/backstage/backstage/blob/5623a818b957b0ef3d44434cd4b8afbf9ae43f7d/packages/integration-react/package.json
Can we replace ^ with either ~ or just version and then having a script to bump in the latest version of packages like backstage/core-components?

@aakankshabhende we prefer using ^ because it minimizes package duplication and in general results in the fewest headaches for users. This generally shouldn't be a problem for projects on old versions either because Yarn will install dependencies in a way which satisfies all ranges.
An important think to note here is that the Backstage version does not adhere to semver, meaning that a bump from for example 1.5.0 to 1.7.0 will most likely contain breaking changes. That has nothing to do with Yarn or dependency ranges in our packages, it's simply how we version things. The k8s version policy is what inspired us to go for that particular system.
Now we could discuss whether it's worth locking down out package dependency ranges to either ~ or exact version. We do have the tooling that still makes it convenient to stay on top of the latest releases anyway. Though I don't like it for two reasons, one is that it will make patching harder, it's more straightforward to have automated dependency bumps when you only need to unlock yarn.lock entries for patches. The other is that the @backstage/ packages would become "special" in the backstage ecosystem, because a fixed version would not make sense for any other packages since you want that range to be there to avoid duplication and receive patches faster. I think it's better if we just have a single preferred way to handle dependencies in the ecosystem.
As a final note I'd also say that we optimize for the best experience for users that keep their projects up to date. If we can improve the experience for users on older versions that's fine, but it can not come at the cost of a worse experience for the aforementioned users.
I'm going to close this issue as the original bug reported is intended behavior that we do not intend to change. At least not without a broader discussion that would require an RFC.

authors: Rugvip aakankshabhende adrianke77 freben


text:
🐛 Bug Report: BackendInitializer Error after backstage-cli versions:bump

📜 Description
After running
yarn backstage-cli versions:bump
yarn backstage-cli versions:bump --pattern "@spotify/backstage*"
yarn backstage-cli versions:bump --pattern "@roadiehq/*"
yarn backstage-cli versions:bump --pattern "@pagerduty/*"

The build breaks when trying to yarn dev with this error
[1] 2024-10-24T15:22:58.992Z soundcheck info Soundcheck backend started.
[1] 2024-10-24T15:22:58.995Z soundcheck info Task worker starting: refresh-applicable-entities, {"version":2,"cadence":"PT30M","initialDelayDuration":"PT5M","timeoutAfterDuration":"PT30M"} task=refresh-applicable-entities
[1] 2024-10-24T15:22:58.998Z rbac info Starting RBACPolicy...
[1] /Users/.../Documents/repos/backstage/node_modules/@backstage/backend-app-api/src/wiring/BackendInitializer.ts:121
[1]       const ep = this.#extensionPoints.get(ref.id);
[1]                                                ^
[1]
[1]
[1] TypeError: Cannot read properties of undefined (reading 'id')
[1]     at BackendInitializer.#getInitDeps (/Users/.../Documents/repos/backstage/node_modules/@backstage/backend-app-api/src/wiring/BackendInitializer.ts:121:48)
[1]     at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
[1]     at <anonymous> (/Users/.../Documents/repos/backstage/node_modules/@backstage/backend-app-api/src/wiring/BackendInitializer.ts:329:32)
[1]     at async Promise.allSettled (index 13)
[1]     at BackendInitializer.#doStart (/Users/.../Documents/repos/backstage/node_modules/@backstage/backend-app-api/src/wiring/BackendInitializer.ts:278:21)
[1]     at BackendInitializer.start (/Users/.../Documents/repos/backstage/node_modules/@backstage/backend-app-api/src/wiring/BackendInitializer.ts:187:5)
[1]     at BackstageBackend.start (/Users/.../Documents/repos/backstage/node_modules/@backstage/backend-app-api/src/wiring/BackstageBackend.ts:38:11)
[1]
[1] Node.js v18.19.1

👍 Expected behavior
build and run successfully
👎 Actual Behavior with Screenshots
Build fails with the above error
👟 Reproduction steps
N/A
📃 Provide the context for the Bug.
No response
🖥 Your Environment
No response
👀 Have you spent some time to check if this bug has been raised before?

[X] I checked and didn't find similar issue

🏢 Have you read the Code of Conduct?

[X] I have read the Code of Conduct

Are you willing to submit PR?
Yes I am willing to submit a PR!

Hi @FourShore, could you provide us with a repro repo so we can try to run it locally? That would be helpful for us to debug the error.

Almost the same problem here (BackendInitializer error: Cannot read properties of undefined (reading 'id'))
after 1.31.3 -> 1.32.3 upgrade (deleting node_modules and yarn install didn't help):
2024-10-28T12:29:00.015Z backstage error Plugin 'catalog' thew an error during startup, waiting for 13 other plugins to finish before shutting down the process type=initialization
2024-10-28T12:29:00.056Z kubernetes info Initializing Kubernetes backend
2024-10-28T12:29:00.057Z kubernetes info action=LoadingCustomResources numOfCustomResources=0
2024-10-28T12:29:00.059Z auth info Configuring "database" as KeyStore provider
2024-10-28T12:29:00.063Z techdocs info Creating Azure Blob Storage Container publisher for TechDocs
2024-10-28T12:29:00.083Z scaffolder info Starting scaffolder with the following actions enabled publish:azure, github:actions:dispatch, github:autolinks:create, github:deployKey:create, github:environment:create, github:issues:label, github:repo:create, github:repo:push, github:webhook, publish:github, publish:github:pull-request, github:pages:enable, github:branch-protection:create, azure:keyvault:get, azure:pipeline:create, azure:pipeline:permit, azure:pipeline:run, azure:repo:clone, azure:repo:pr, azure:repo:push, azure:workitem:create, azure:workitem:update, fetch:plain:file:try, roadiehq:utils:fs:parse, roadiehq:utils:fs:write, roadiehq:utils:json:merge, roadiehq:utils:jsonata:yaml:transform, roadiehq:utils:merge, roadiehq:utils:serialize:json, roadiehq:utils:serialize:yaml, fetch:plain, fetch:plain:file, fetch:template, fetch:template:file, debug:log, debug:wait, catalog:register, catalog:fetch, catalog:write, fs:delete, fs:rename
2024-10-28T12:29:00.085Z search info Added DefaultCatalogCollatorFactory collator factory for type software-catalog
2024-10-28T12:29:00.085Z search info Added DefaultTechDocsCollatorFactory collator factory for type techdocs
2024-10-28T12:29:00.182Z scaffolder info using working directory: /tmp
2024-10-28T12:29:00.233Z auth info Configuring auth provider: github
2024-10-28T12:29:00.235Z auth info Configuring auth provider: microsoft
/Users/.../devhub-app-backstage/node_modules/@backstage/backend-app-api/src/wiring/BackendInitializer.ts:297
provides: Array.from(moduleInit.consumes).map(c => c.id),
^
TypeError: Cannot read properties of undefined (reading 'id')
at  (/Users/.../devhub-app-backstage/node_modules/@backstage/backend-app-api/src/wiring/BackendInitializer.ts:297:70)
at Array.map ()
at  (/Users/.../devhub-app-backstage/node_modules/@backstage/backend-app-api/src/wiring/BackendInitializer.ts:297:59)
at Array.map ()
at  (/Users/.../devhub-app-backstage/node_modules/@backstage/backend-app-api/src/wiring/BackendInitializer.ts:291:35)
at async Promise.allSettled (index 3)
at BackendInitializer.#doStart (/Users/.../devhub-app-backstage/node_modules/@backstage/backend-app-api/src/wiring/BackendInitializer.ts:278:21)
at BackendInitializer.start (/Users/.../devhub-app-backstage/node_modules/@backstage/backend-app-api/src/wiring/BackendInitializer.ts:187:5)
at BackstageBackend.start (/Users/.../devhub-app-backstage/node_modules/@backstage/backend-app-api/src/wiring/BackstageBackend.ts:38:11)
Node.js v20.11.0

@famibo are you seeing any errors if you run yarn tsc?

@Rugvip you re right ! This is the same issue as described hier: https://github.com/backstage/backstage/issues/27242
In our case the problem was this wrong (in 1.32.3) import:
import { microsoftGraphOrgEntityProviderTransformExtensionPoint } from '@backstage/plugin-catalog-backend-module-msgraph/alpha';
Should be instead:
import { microsoftGraphOrgEntityProviderTransformExtensionPoint } from '@backstage/plugin-catalog-backend-module-msgraph';
Our backstage app starts now again :-) Many thanks !!!

@camilaibs unfortunately I can not provide a repo but I think we may have resolved it after @Rugvip comment led us to fixing some typescript errors.

authors: FourShore Rugvip camilaibs famibo


text:
Errors when Github Bot is only installed on some repositories

Expected Behavior
When I install my Github Bot on only some of an organisations repositories.
I would like Github Discovery to successfully crawl all repositories that it has access to, without erroring on repositories it doesn't have access to.
I'd likely do this by telling the Github Credentials Manager to not limit by repositories, as I don't (think) I need that behaviour.
Current Behavior
GithubAppManager will attempt to create an installation for specific repos, returning the below error.

catalog warn Processor GithubDiscoveryProcessor threw an error while reading github-discovery:https://github.com/{org}/*/blob/master/{custom-file}; caused by HttpError: There is at least one repository that does not exist or is not accessible to the parent installation. type=plugin

Possible Solution
I tested a workaround to this solution by changing the following line to not limit the access token by repository.
https://github.com/backstage/backstage/blob/29d616592bd2349d8e9bdd6bb0b1713cd435f8ab/packages/integration/src/github/GithubCredentialsProvider.ts#L107
const repositories = repositorySelection !== 'all'  && repo !== '*' ? [repo!] : undefined;

This worked, but likely isn't a good idea for everyone. To suggest a solution I'd first need to understand why the access tokens are being created limited by repository, my guess is that's just not needed for a Github App access but not sure.
Steps to Reproduce

Create a Github App and install it only one some repositories in an organisation

Add The Github App and a Catalog item

integrations:
  github:
    - host: github.com
      apps:
        - $include: github-app-credentials.yaml
catalog:
  locations:
    - type: github-discovery
      target: https://github.com/{ORG}/*/blob/master/app-config.yaml

Context
I'm investigating the use of BackStage and would like to trial it without giving full access to the entire organisation. I'd typically do this by limiting the repositories it has access to.
I'm also going to have rate limiting problems due to the large number of repositories on the org, so whilst testing it can be helpful to limit to a subset of repos, so I can avoid rate limit problems for now.
Your Environment

NodeJS Version (v12): v14
Operating System and Version (e.g. Ubuntu 14.04): Mac OS

I believe @punkle got you covered :grin: #6539, will prolly be part of the next release

Awesome. Glad it's already in the pipeline. Thanks.

Fix from #6539 should be released this Thursday

Confirmed this is working in the latest version. Thanks for the great work @punkle

You are welcome @jahredhope. Glad to have been able to help.

authors: Rugvip jahredhope punkle


text:
backend-test-utils: unify mock services and service factory exports

Hey, I just made a Pull Request!
We'll need to export both all of the mock factories, as well as all of the mock service implementations. The factories are needed to set up custom factories with options for starting test backends. The implementations are needed for lower-level unit tests for services implementations themselves.
It's all in two new exports: mockFactories and mockServices
:heavy_check_mark: Checklist

[x] A changeset describing the change and affected packages. (more info)
[ ] Added or updated documentation
[ ] Tests for new functionality and regression tests for bug fixes
[ ] Screenshots attached (for UI changes)
[x] All your commits have a Signed-off-by line in the message. (more info)

Another pattern we could use:
mockServices.config() // <- service implementation
mcokServices.config.factory() // <- service factory


text:
Refactor the backend-plugin-managerto meet Backstage API design style guidelines

Description
Refactor the backend-plugin-managerto meet Backstage API design style guidelines.
Which issue(s) does this PR fix
This PR doesn't fix any issue, but is a followup PR of the main dynamic backend plugins PR, especially of this comment.
It's a additional step towards the promotion to the backend-plugin-manager package to public API.
PR acceptance criteria
Please make sure that the following steps are complete:

[ ] GitHub Actions are completed and successful
[x] Unit Tests are updated and passing
[ ] E2E Tests are updated and passing
[ ] Documentation is updated if necessary (requirement for new features)
[ ] Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

@Rugvip As you mentioned in the previous Adoption SIG call, I assume that the remaining blocker to making the backend-plugin-manager package public is to rename it to a less generic name.
In this PR I renamed the main class DynamicPluginManager instead of BackendPluginManager
But I didn't rename the package itself, to make the review of this PR easier.
Would it make sense to simple rename the package (in a followup PR) to: dynamic-plugin-manager or, if we want to keep the information that it is a backend service: backend-dynamic-plugin-manager ?

(we'll merge this in a bit, waiting for the main branch to get unlocked after today's mainline release)

@Rugvip As you mentioned in the previous Adoption SIG call, I assume that the main remaining blocker to making the backend-plugin-manager package public is to rename it to a more precise name.
In this PR I already renamed the main class DynamicPluginManager instead of BackendPluginManager
But I didn't rename the package itself, to make the review of this PR easier.
Would it make sense to simple rename the package (in a followup PR) to: dynamic-plugin-manager or, if we want to keep the information that it is a backend service: backend-dynamic-plugin-manager ?

@Rugvip Now that these remaining required refactoring steps have been implemented, are we ready to rename the package and make it public, so that it would be published ?
And about the final package name, what would be the preferred one between these two:

dynamic-plugin-manager
backend-dynamic-plugin-manager

Personally I tend to prefer the first one, since it discovers and manages both dynamic backend and frontend plugins.

@davidfestal what do you think about @backstage/backend-plugin-loader?

Well, I have mixed feelings:

it provides backend components, so it seems obvious to start with backend- =>  :+1:
it loads backend plugins, so it is a plugin loader=> :+1:

but

it also discovers both frontend and backend plugins, and provides a list of frontend plugins, along with their package.json content, so starting with backend-plugin- may convey they idea that it only manages backend plugins => :-1:
it is aimed at loading dynamic plugins, which are external plugins available in a separate root directory and not included in the main application package.json. The -plugin-loader naming might then be confusing, as if it was a component required to load any plugin, which is it not. => :-1:

These are the reasons why I was more in favour of something like dynamic-plugin-manager

authors: davidfestal freben


text:
Set 001-notifications BEP to "implementable"

Moving the 001-BEP forward, almost all features set are already implemented.
We need to stabilize the API and refer future changes to separate BEPs.
:heavy_check_mark: Checklist

[ ] A changeset describing the change and affected packages. (more info)
[ ] Added or updated documentation
[ ] Tests for new functionality and regression tests for bug fixes
[ ] Screenshots attached (for UI changes)
[x] All your commits have a Signed-off-by line in the message. (more info)

I believe the implementable is a good state for now.
To reach implemented, we need to resolve/agree on the https://github.com/backstage/backstage/pull/25066.
If anyone see another blocker towards implemented, please feel free to list it here.
Cc @freben , @Rugvip

I think we should also implement the user specific settings for notifications as there are going to be multiple different processors available in the upcoming releases

This is a more general comment around BEPs but we should have some sort of gate at this point that there must be documentation in place before we make this change. For initial stages using READMEs is fine but at this point having it on backstage.io/docs is a must.
Notes: there are docs for this in the PR to add this to create-app so my comment here isn't intended to block anything. 👍

@awanlin Documentation before even setting it to implementable? Implemented I agree, but not probably for this status right?

authors: awanlin drodil freben mareklibra


text:
Add oauth2-redirect.html of OAuth2 Authorization Code callback

Hey, I just made a Pull Request!

Fixes #4668
Adds /oauth2-redirect.html to enable Oauth2 Authorization Code flow with Swagger UI in the api-docs plugin.
:heavy_check_mark: Checklist

[x] A changeset describing the change and affected packages. (more info)
[x] Added or updated documentation
[ ] Tests for new functionality and regression tests for bug fixes
[ ] Screenshots attached (for UI changes)

Tugboat has finished building the preview for this pull request!
Link:

https://pr4703-pgn5ckmxkrfgka934b9tjuqjfrrguv1t.tugboat.qa

Dashboard:

https://dashboard.tugboat.qa/6037ea1965f8170f13faa85b

Tugboat has finished building the preview for this pull request!
Link:

https://pr4703-pgn5ckmxkrfgka934b9tjuqjfrrguv1t.tugboat.qa

Dashboard:

https://dashboard.tugboat.qa/6037ea1965f8170f13faa85b

Tugboat has finished building the preview for this pull request!
Link:

https://pr4703-pgn5ckmxkrfgka934b9tjuqjfrrguv1t.tugboat.qa

Dashboard:

https://dashboard.tugboat.qa/6037ea1965f8170f13faa85b

Tugboat has finished building the preview for this pull request!
Link:

https://pr4703-pgn5ckmxkrfgka934b9tjuqjfrrguv1t.tugboat.qa

Dashboard:

https://dashboard.tugboat.qa/6037ea1965f8170f13faa85b

Tugboat has finished building the preview for this pull request!
Link:

https://pr4703-pgn5ckmxkrfgka934b9tjuqjfrrguv1t.tugboat.qa

Dashboard:

https://dashboard.tugboat.qa/6037ea1965f8170f13faa85b


text:
More Lookup Options

Lookup monsters (https://roll20.net/compendium/dnd5e/Monsters:Goblin/#h-Goblin)

Lookup abilities (recursive search?)

Monsters can now be looked up.


text:
🛑 Linx is down

In b730d86, Linx (https://i.zhem.us/) was down:

HTTP code: 521
Response time: 335 ms

Resolved: Linx is back up in a8721dc.

repo: baddate/uptime-monitor


text:
Rendering background when logo is present

Currently, when adding only a logo on the left side, the background is not rendered and using colorA has not effect while colorB shows normally.  For example
https://img.shields.io/badge/-test-red.svg?colorA=ffffff&colorB=cf2020&logo=data%3Aimage%2Fpng%3Bbase64%2CiVBORw0KGgoAAAANSUhEUgAAAA4AAAAOCAMAAAAolt3jAAABC1BMVEUAAAD%2FAAC%2FAADMGhrRFxfSHh7VHBzJGxvTISHKICDMHx%2FOHR3RJCTTIyPOISHPICDMHR3NIyPNICDRISHQHx%2FQHx%2FOHx%2FQISHOICDQICDQHx%2FOHx%2FPISHQISHQICDOICDQISHOICDQICDPISHPICDQISHPICDPICDOHx%2FPISHPISHQISHPICDPISHPISHQICDOICDOICDPHx%2FPICDPICDOICDPICDPICDPICDPHx%2FPICDPICDQICDPICDPHx%2FQISHOICDPICDPICDPICDPICDPHx%2FMISHOICDPICDQICDPICDPISHPHx%2FPICDPICDPICDPICDPICDPICDOICDPHx%2FPICDPICDPICDPICDi8V76AAAAWHRSTlMAAgQKCxESExcYGRocHR8gIyRITVFSU1ZYYWJjZGZnaWxucXV5fH%2BAg4SFjI%2BUlZeYqKuusbK2ubrDxcbHycvMzdHU2Nrb4uLl5%2Bnq6%2Bzt7u%2F09vf7%2FP3%2B%2FHERCQAAAKVJREFUeAEdx%2BVCg2AAhtHHAANDMQRD7ECwO7DDjViM7b3%2FK9n4zr9Dxdk6jjc4s02si46kK7tMLGDuW%2Fq%2FvdxZlt5shh7VWhsGTqWvTVYll0q4PjMyy7VuYHQ7nIL98oVMAey183sI9EtNPpzXfz7BV8aHIpi%2Fe3ch1iuHysYxnFxHTDf1bD7xpMKBxa6Kk6WVKFXPY8BLZTQWMMYOHvK%2FZHcS6AOapR0V%2FpSSVQAAAABJRU5ErkJggg%3D%3D
renders as

A quick workaround (thanks to @paulmelnikow ) consists in adding a blank space right after the icon
https://img.shields.io/badge/%20-INSIGNEO-red.svg?colorA=ffffff&colorB=cf2020&logo=data%3Aimage%2Fpng%3Bbase64%2CiVBORw0KGgoAAAANSUhEUgAAAA4AAAAOCAMAAAAolt3jAAABC1BMVEUAAAD%2FAAC%2FAADMGhrRFxfSHh7VHBzJGxvTISHKICDMHx%2FOHR3RJCTTIyPOISHPICDMHR3NIyPNICDRISHQHx%2FQHx%2FOHx%2FQISHOICDQICDQHx%2FOHx%2FPISHQISHQICDOICDQISHOICDQICDPISHPICDQISHPICDPICDOHx%2FPISHPISHQISHPICDPISHPISHQICDOICDOICDPHx%2FPICDPICDOICDPICDPICDPICDPHx%2FPICDPICDQICDPICDPHx%2FQISHOICDPICDPICDPICDPICDPHx%2FMISHOICDPICDQICDPICDPISHPHx%2FPICDPICDPICDPICDPICDPICDOICDPHx%2FPICDPICDPICDPICDi8V76AAAAWHRSTlMAAgQKCxESExcYGRocHR8gIyRITVFSU1ZYYWJjZGZnaWxucXV5fH%2BAg4SFjI%2BUlZeYqKuusbK2ubrDxcbHycvMzdHU2Nrb4uLl5%2Bnq6%2Bzt7u%2F09vf7%2FP3%2B%2FHERCQAAAKVJREFUeAEdx%2BVCg2AAhtHHAANDMQRD7ECwO7DDjViM7b3%2FK9n4zr9Dxdk6jjc4s02si46kK7tMLGDuW%2Fq%2FvdxZlt5shh7VWhsGTqWvTVYll0q4PjMyy7VuYHQ7nIL98oVMAey183sI9EtNPpzXfz7BV8aHIpi%2Fe3ch1iuHysYxnFxHTDf1bD7xpMKBxa6Kk6WVKFXPY8BLZTQWMMYOHvK%2FZHcS6AOapR0V%2FpSSVQAAAABJRU5ErkJggg%3D%3D

The icon is not centred but the icon is clearly visible.
Would it possible to reintroduce the background rendering in this case? Alternatively, I'd suggest of simply updating the documentation to point out this turnaround.
Thanks!

Thanks for opening this issue, I'll have a look into it and see if i can figure something out 😄

repo: badges/shields

license_source: bigquery


text:
Filter für Bio-Produkte

Analog zu den Billigmarkenfiltern hier ein Filter für Bio-Produkte.
Ich bin mir nicht sicher ob/wie das mit einer bestehenden Datenbank mergt, aber es funktioniert jedenfalls from scratch

Nice, danke.

authors: badlogic simmac

repo: badlogic/heissepreise


text:
The status filters need to be updated to display "Active/Inactive" instead of "True/False" for consistency with the datagrid.

Describe the bug
The status filters need to be updated to display "Active/Inactive" instead of "True/False," matching the values shown in the datagrid. In the Admin datagrid filters, data should appear consistently to maintain uniformity.
To Reproduce
Steps to reproduce the behavior:

Go to admin -> Products -> Filters -> Status -> True/False
Go to admin -> Products -> Status -> Active /Inactive

Expected behavior
The status filters need to be updated to display "Active/Inactive" instead of "True/False" for consistency with the datagrid.
Screenshots
https://prnt.sc/4ht40RSicrU_

Checked and Found that the Improvement has been done and verified. I have checked the details in below section and found it working properly.
Catalog -> Products
Catalog -> Categories
Catalog -> Attributes
Customers -> Customers
Marketing  ->Promotions -> Cart Rule
Marketing  ->Promotions -> Catalog Rule
Marketing  -> Communications -> Email Templates
Marketing  -> Communications -> Campaigns
Marketing  -> Communications -> Newsletter Subscriptions.
Settings -> Inventory Sources
Settings -> Users
Settings -> Themes

repo: bagisto/bagisto


text:
can add to homescreen on mobile device in velocity theme

can add to homescreen on mobile device in velocity theme ?
This repository is only for reporting bugs or issues. If you need support, please use
other channels:

Write an email - mailto:support@bagisto.com

Create support ticket on https://bagisto.uvdesk.com

Visit forums to get support from our community (https://forums.bagisto.com)

Alternatively, you may use Facebook (https://www.facebook.com/groups/bagisto/).
We promise that more channels are coming soon!!!

You can use our PWA app for bagisto, pleae checkout the following repository:
https://github.com/bagisto/laravel-pwa

authors: jitendra-webkul marcelowu


text:
Error when using date-fns

Versions

vee-validate: 2.2.0
vue: 2.6.10
date-fns: 2.0.0-alpha.27

Describe the bug
As @JamesAnelay said in the isuue #1732, if I add a simple rule such as v-validate="'required'" to a type="date" input  then I get the following error in the console and the validation rules e.g require in this case fail to work.
RangeError: `options.awareOfUnicodeTokens` must be set to `true` to use `YYYY` token; see: https://git.io/fxCyr
    at throwProtectedError (vee-validate.esm.js:6378)
    at parse (vee-validate.esm.js:8509)
    at parseDate$1 (vee-validate.esm.js:8637)
    at validate$9 (vee-validate.esm.js:9086)
    at Validator._test (vee-validate.esm.js:3508)
    at vee-validate.esm.js:3727
    at Array.some (<anonymous>)
    at Validator._validate (vee-validate.esm.js:3725)
    at Validator.attach (vee-validate.esm.js:3093)
    at ScopedValidator.attach (vee-validate.esm.js:2654)

Desktop (please complete the following information):

Chrome 73.0.3683.86 (Build oficial) (64 bits)

Thanks, and I hope you help me

Relevant comment in previous issue : https://github.com/baianat/vee-validate/issues/1732#issuecomment-476826944

I'm also getting this issue now - using v-validate="{ date_format: 'DD/MM/YYYY' }"

Thanks for reporting this, I didn't notice James's comment on the issue, this is fixed in aea95e25
@onfire The formats was changed, I suggest you follow the link logged to track down the issue. You have to change your format to dd/MM/yyyy which is a standard.

authors: JamesAnelay logaretm onfire ranaclyde

repo: baianat/vee-validate

license: mit


text:
ValidationObserver doesn't validate the form until all the inputs are dirty

Versions

vee-validate: 2.2.2
vue: 2.6.7

Describe the bug
ValidationObserver doesn't validate the form until all the inputs (even optional) are dirty.
To reproduce
Steps to reproduce the behavior:

Use ValidationProvider and ValidationObserver to create a form with required and optional inputs
Use ValidationObserver scoped slot data (pristine and invalid for example) to disable the submit button until the form is valid
Fill only the required inputs
The form isn't validated and the submit button is still disabled

Expected behavior
The form should be validated and valid after filling properly all the required inputs.
Demo link
https://codepen.io/VictorCazanave/pen/jRwVay
Desktop

OS: MacOS 10.14.4
Browser: Chrome 73 (I haven't tried other browsers)

Additional context
It's the first time I use VeeValidate in a project and although I read the documentation many times, all the examples use rules="required" (no optional input), so I may have misunderstood how to use the validation components.

Thanks for reporting this, this is indeed a bug and the fix should be available in the next release.

@logaretm Thanks for your quick reply and fix!

authors: VictorCazanave logaretm


text:
mod_access日志问题

我浏览器中输入一个js路径，access日志中REQUEST_LOG打印出来，但是过了一段时间才会出闲SESSION_LOG，而且SESSION_LOG中的ses_overhead很长，看截图：这是什么问题？

access日志中REQUEST_LOG打印出来，但是过了一段时间才会出闲SESSION_LOG
请求日志在请求处理完成时输出；
会话日志在连接处理完成（即连接关闭）时输出

SESSION_LOG中的ses_overhead很长
代表连接持续时间。你的场景中在连接上发送请求响应后，连接被放入浏览器连接池被未立即关闭

authors: iyangsj willzhujian

repo: baidu/bfe


text:
feat: add advertise route annotation

支持给 node 添加 annotation 告诉 CCM 不去 VPC 创建 实例路由

@tianyuansun 这个是什么功能，有文档描述吗

close，reopen when needed

repo: baidu/cloud-provider-baiducloud


text:
🛑 docs.ohmy.xin is down

In 7f7ba94, docs.ohmy.xin (https://docs.ohmy.xin) was down:

HTTP code: 500
Response time: 453 ms

Resolved: docs.ohmy.xin is back up in 27621ac.

repo: baizhiheizi/upptime


text:
Create an endpoint for the Stability fund

Related to https://github.com/balancednetwork/balanced-network-info/issues/109
We will need to query stability fund balances based on timestamp, it would be ideal to have it similar to DAO fund endpoint, see https://balanced.sudoblock.io/api/v1/docs#/stats/get_daofund_balance_sheet_api_v1_stats_daofund_balance_sheet_get
example timestamp 1652252887000000

@hetfly this endpoint should help you. @robcxyz can answer questions if it's not clear from the docs. You enter a timestamp and it returns a blockheight closest to the timestamp. From there, the UI can ping the node for balanceOf (blockHeight) for different tokens and different contracts. We should migrate all single-point-in-time API usage to this model. It's a new feature supported by ICON Nodes that allows you to query state at a given block height
https://tracker.v2.mainnet.sng.vultr.icon.community/api/v1/docs/index.html#/Blocks/get_api_v1_blocks_timestamp__timestamp

This should also help when calling the icon node once you have the blockHeight
https://www.icondev.io/icon-stack/client-apis/json-rpc-api/v3.
So to summarize, this can be used for single-point-in-time queries. For example, let's compare today's DAO Fund holdings to the holdings on May 1st.
Calling backend API:

Call for blockheight today, return = x
Call for blockheight for May 1st, return = y

Calling ICON Node API:

balanceOf (DAOFund, blockheight = x)
balanceOf (DAOFund, blockheight = y)

authors: BennyOptions hetfly

repo: balancednetwork/balanced-network-info


text:
Debug: Test empty homepage

Description
Please include a summary of the change and if relevant which issue is fixed. Please also include relevant motivation and context.
Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Dependency changes
[ ] Code refactor / cleanup
[ ] Documentation or wording changes
[ ] Other

How should this be tested?
Please provide instructions so we can test. Please also list any relevant details for your test configuration.

[ ] Test A
[ ] Test B

Visual context
Please provide any relevant visual context for UI changes or additions. This could be static screenshots or a loom screencast.
Checklist:

[ ] I have performed a self-review of my own code
[ ] I have requested at least 1 review (If the PR is significant enough, use best judgement here)
[ ] I have commented my code where relevant, particularly in hard-to-understand areas
[ ] If package-lock.json has changes, it was intentional.
[ ] The base of this PR is master if hotfix, develop if not

Closed after debug.


text:
Feat/api voting list [don't merge until latest API changes are in production]

Description
Migrates vebal voting list to use new API endpoint VeBalGetVotingList (that is already deployed in production)
Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Dependency changes
[x] Code refactor / cleanup
[ ] Documentation or wording changes
[ ] Other

How should this be tested?
Please provide instructions so we can test. Please also list any relevant details for your test configuration.

[ ] Test A
[ ] Test B

Visual context
Please provide any relevant visual context for UI changes or additions. This could be static screenshots or a loom screencast.
Checklist:

[ ] I have performed a self-review of my own code
[ ] I have requested at least 1 review (If the PR is significant enough, use best judgement here)
[ ] I have commented my code where relevant, particularly in hard-to-understand areas
[ ] If package-lock.json has changes, it was intentional.
[ ] The base of this PR is master if hotfix, develop if not

LGTM. It does take a few seconds to load becuase of a subgraph query to fetch all pools on the veBAL page. Is that query needed? Does the veBAL table need to wait for it before showing?

That AllPools query is triggered by balancer-sdk dependency (from PoolCacher) that we use from many different places but it is not blocking.
As we discussed in slack the main blocker here would be the decorator that wraps pools/gauges with voting data from onchain multicalls: https://github.com/balancer/frontend-v2/blob/478fccf4ca31d93abb19584d6dcb4cba24f74033/src/services/balancer/gauges/gauge-controller.decorator.ts#L73

Let's get Zekraken to do a round of testing just on voting to make sure that's all working correctly, but he can do that on beta.

The code is ready in canary but Franz is testing some new infra in production so we need to wait for him to finish. I will merge then.


text:
"sails generate model" from outside of sails project directory

When I generate controller from outside of sails root project directory, I receive error:
Sorry, this command can only be used in the root directory of a Sails project.
When I generate model:
info: Created a new model ("TestModel") at api/models/TestModel.js!
I think, there should be same error message for model
My sailsjs version 0.11.2

@FurkhatKasymov thanks!

authors: FurkhatKasymov mikermcneil

repo: balderdashy/sails-generate-model


text:
Enable feature cross-adapter tests

To make use of the new feature tests introduced by balderdashy/waterline-adapter-tests#64.
For now features is empty as sails-redis will likely break the cross-adapter tests.

Thanks @particlebanana, the last 3 PRs that were merged should make it easier to spot improvements in upcoming PRs. The only other thing I can think of to improve the situation is to disable bail in runner.js#L62 so we can see all tests that fail. This would make it easier to see if a given PR fixes any breaking test.

@particlebanana, I've disabled mocha: bail on PR #70. Please take a look.

repo: balderdashy/sails-redis


text:
watch

Model.watch(req) print a debug message :
debug: sails.sockets.id() is deprecated; use sails.sockets.getId() (see http://sailsjs.org/documentation/concepts/upgrading/to-v-0-12)

Thanks @ljacques - there's a fix in place on master and we'll be removing this message in a patch release this week (.watch() formerly called .id() instead of .getId() and we forgot to switch it over during the upgrade.  The only reason for the name change was to make the behavior clearer, and .id() is just an alias- so there's nothing to worry about in the mean time).

Thanks @mikermcneil
I keep testing ;-)

authors: ljacques mikermcneil

repo: balderdashy/sails


text:
curFrame

which one of the following refers to curFrame in the previous API of pyrenderdoc?
APIProps
AddLogProgressListener
AddLogViewer
AddMessages
AppWindow
CaptureDialog
CloseLogfile
Config
ConfigDirectory
ConfigFilename
CurBuffers
CurD3D11PipelineState
CurD3D12PipelineState
CurDrawcall
CurDrawcalls
CurEvent
CurGLPipelineState
CurPipelineState
CurTextures
CurVulkanPipelineState
DebugMessages
Equals
FrameInfo
GetAPIInspector
GetBuffer
GetDebugMessages
GetDrawcall
GetDrawcalls
GetEventBrowser
GetHashCode
GetMeshViewer
GetPipelineStateViewer
GetStatisticsViewer
GetTexture
GetTextureViewer
GetTimelineBar
GetType
IsLogLocal
LoadLogfile
LogFileName
LogLoaded
LogLoading
MemberwiseClone
ReferenceEquals
RefreshStatus
RemoveLogViewer
Renderer
SetEventID
Shutdown
TempLogFilename
TimelineBar
ToString
UnreadMessageCount
__class__
__delattr__
__doc__
__format__
__getattribute__
__hash__
__init__
__new__
__reduce__
__reduce_ex__
__repr__
__setattr__
__sizeof__
__str__
__subclasshook__

As I told you yesterday, I removed the support for multiple frames in a single capture (which never worked, but had some legacy code for it). The CurFrame property was removed as part of that.

authors: baldurk monajalal

repo: baldurk/renderdoc


text:
Compare kernel config between genericx86_64-ext and generic-amd64

The genericx86_64-ext has its own defconfig based on Ubuntu with some extra changes necessary to boot flasher on a variety of devices while the generic-amd64 is based on x86_64_defconfig. We should unify this as the two device types are fairly similar.

Closed by https://github.com/balena-os/balena-generic/pull/35

authors: jakogut mtoman

repo: balena-os/balena-generic


text:
Update layers/meta-balena digest to ccab775

This PR contains the following updates:

Package
Update
Change

layers/meta-balena
digest
c3560cf -> ccab775

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

Can one of the admins verify this patch?

authors: balena-ci resin-jenkins

repo: balena-os/balena-raspberrypi


text:
balena-yocto-scripts: Update to v1.17.2

Update balena-yocto-scripts from v1.17.0 to v1.17.2
Change-type: patch
Changelog-entry: Update balena-yocto-scripts to v1.17.2
Signed-off-by: Alex Gonzalez alexg@balena.io

@balena-ci retest

repo: balena-os/balena-ts


text:
Clean up Json test summaries

combine the json summaries for all test suites that ran into a single json
add error handling for when the worker is unreachable and we can't fetch the summary

Also add the compute the number of skips: Forumla: Total tests - (passed tests + failed tests)

repo: balena-os/leviathan


text:
Signature help support within query do action

Description:
$title
Related to #20975
Steps to reproduce:
Affected Versions:
v1.2.0-SNAPSHOT at least

No changes needed

authors: nadeeshaan rasika

repo: ballerina-platform/ballerina-lang


text:
Calling Java Code from Ballerina doc does not have mapping to arrays, maps

Description:
It seems https://ballerina.io/learn/calling-java-code-from-ballerina/ missing how user can map ballerina arrays,map, record and other types to java classes when writing interop methods. IMO we can improve the doc with those data.

https://github.com/ballerina-platform/ballerina-dev-website/pull/1739
Above PR will provide the requirements.

https://github.com/ballerina-platform/ballerina-dev-website/pull/1739
Above PR will provide the requirements.

authors: gabilang warunalakshitha


text:
Make Ballerina compiler and the BVM, two independent programs

I.e. Ballerina docker images should only contain the BVM code.

With the new organization and positioning, I think this is no longer valid.

authors: afkham sameera-jayasoma


text:
[Task]: Document integrating nBallerina type engine into jballerina

Description
$subject.

Closing with #40564

First Draft: https://drive.google.com/file/d/1ZqNG0C4iH1F-bX4ZnEp1ALxPWyfEBdCE/view?usp=sharing

Second Draft: https://drive.google.com/file/d/1S72Za3kSnJE8fWDPf7rZ3fl2CNLJHf6U/view?usp=sharing

Closing with the doc v2 above.


text:
[Improvement]: Running Code Analyzers Inside Code Modifiers at Tooling Phases

Description
In the Ballerina GraphQL package, we have a code modifier that annotates the corresponding GraphQL schema to a Ballerina service. Following is the process of code modification:

Register a code modifier as a compiler plugin
The code modifier will first run an analyzer to analyze the Ballerina service to,

Validate the service and report diagnostics (if there are any)
Generate a data model to represent the corresponding GraphQL schema

The generated data model is passed to the code modifier
Code modifier then serializes the data model and annotates it to the GraphQL service

Describe your problem(s)
The problem we are facing now is that the diagnostics reported in the GraphQL service analyzer are not showing in the VS Code editor, which is bad UX. The errors are shown in the bal build, but not in the editor. So the user does not know the errors in the code until they build the code.
Describe your solution(s)
If there is a way to run the analyzer inside the code modifier without running the modifier, this can be fixed. Generating the schema using this analyzer is used in multiple places, including the GraphQL Visual Designer tool and the bal graphql tool.
Related area
-> Compilation
Related issue(s) (optional)
No response
Suggested label(s) (optional)
No response
Suggested assignee(s) (optional)
No response

The Language Server uses a separate API to call the analyzer by passing the position of the service node and the semantic model to visualize the GraphQL service.
The bal graphql tool generates the SDL file from the Ballerina service. It first runs a compilation in order to run the code modifier and then reads the annotation from the modified code to generate the SDL file.
We can improve both these functionalities if we can run the analyzer separately and get the generated schema (data model).
CC: @DimuthuMadushan @sachiniSam


text:
Fix recursive issue of isAnydata method while checking record types with same refrence

Purpose

Stack over flow issue can be observed in isAnydata method  while manipulating record types which has same reference. This PR will fix that.
ex.

type Person record {
    string name = "";
    int age = 0;
    Person? parent = ();
    json info = ();
    map<anydata>? address = ();
    int[]? marks = ();
    anydata a = ();
    float score = 0.0;
    boolean alive = false;
    Person[]? children = ();
    !...
};

function testCyclicRecordAssignment() returns (anydata) {
    Person p = {name:"Child",
                age:25,
                parent:{name:"Parent", age:50},
                address:{"city":"Colombo", "country":"SriLanka"},
                info:{status:"single"},
                marks:[67, 38, 91]
    };
    anydata adp = p;
    any p2 =  <Person>adp;
    if(p2 is anydata){
        return p2;
    } else {
        return ();
    }
}

testCyclicRecordAssignment function will produce stack overflow issue at compiler time and runtime due to isAnydata method not supporting cyclic record types.

Closing this. Please find new PR  for df-endpoint-change branch.
https://github.com/ballerina-platform/ballerina-lang/pull/11781


text:
[WIP] Update annotation declaration syntax and introduce the annotation access expression

Purpose
$title, according to the spec.

Annotations - "Annotations" section under metadata
Annotation Access Expression - "Annotation access expression" section under Expressions

This PR also:

introduces invoke() methods in BRunUtil to accept JVM values to run functions
migrates mime, http utils to use JVM values instead of BValues

Note: .balx generating tasks/modules, where annotations are used, have been disabled since CodeGen (phase) does not work with these changes.
Initial implementation addressing https://github.com/ballerina-platform/ballerina-lang/issues/14352
Approach

Describe how you are implementing the solutions along with the design details.

Samples

Provide high-level details about the samples related to this feature.

Remarks

List any other known issues, releated PRs, TODO items or any other notes related to the PR.

Check List

[ ] Read the Contributing Guide
[ ] Required Balo version update
[ ] Updated Change Log
[ ] Checked Tooling Support (#)
[ ] Added necessary tests

[ ] Unit Tests
[ ] Spec Conformance Tests
[ ] Integration Tests
[ ] Ballerina By Example Tests

[ ] Increased Test Coverage
[ ] Added necessary documentation

[ ] API documentation
[ ] Module documentation in Module.md files
[ ] Ballerina By Examples

Codecov Report

Merging #15884 into jballerina will decrease coverage by 0.12%.
The diff coverage is 5.99%.

@@               Coverage Diff                @@
##             jballerina   #15884      +/-   ##
================================================
- Coverage         13.82%    13.7%   -0.13%
+ Complexity         4389     4364      -25
================================================
  Files              1978     1973       -5
  Lines             91614    91837     +223
  Branches          12758    12769      +11
================================================
- Hits              12669    12586      -83
- Misses            76731    77055     +324
+ Partials           2214     2196      -18

Impacted Files
Coverage Δ
Complexity Δ

.../ballerinalang/compiler/codegen/CodeGenerator.java
0% <ø> (ø)
0 <0> (ø)
:arrow_down:

.../ballerinalang/compiler/BIRPackageSymbolEnter.java
0% <0%> (ø)
0 <0> (ø)
:arrow_down:

...ballerinalang/langserver/common/LSNodeVisitor.java
3.5% <0%> (-0.03%)
6 <0> (ø)

...ballerinalang/compiler/desugar/ASTBuilderUtil.java
0% <0%> (ø)
0 <0> (ø)
:arrow_down:

...wso2/ballerinalang/compiler/bir/model/BIRNode.java
0% <0%> (ø)
0 <0> (ø)
:arrow_down:

...alang/compiler/semantics/analyzer/TypeChecker.java
0% <0%> (ø)
0 <0> (ø)
:arrow_down:

...java/org/ballerinalang/net/http/WebSocketUtil.java
0% <0%> (ø)
0 <0> (ø)
:arrow_down:

...alang/compiler/tree/BLangAnnotationAttachment.java
0% <0%> (ø)
0 <0> (ø)
:arrow_down:

...ompiler/tree/expressions/BLangAnnotAccessExpr.java
0% <0%> (ø)
0 <0> (?)

...lerinalang/compiler/desugar/AnnotationDesugar.java
0% <0%> (ø)
0 <0> (ø)
:arrow_down:

... and 56 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36a2143...e304c22. Read the comment docs.

@arukshani, @chamil321 - Can y'all please have a look at the changes to HTTP and MIME tests?

authors: MaryamZi codecov-io


text:
Fix completion ordering for module completions

Purpose

When user types the exact pattern of module prefix or alias, completions gives the priority to the exact pattern match

Fixes #33271
Samples

https://user-images.githubusercontent.com/46120162/139018187-590f88f8-7232-4644-a9ef-9ec94423021e.mov
Check List

[x] Read the Contributing Guide
[ ] Updated Change Log
[ ] Checked Tooling Support (#)
[ ] Added necessary tests

[ ] Unit Tests
[ ] Spec Conformance Tests
[ ] Integration Tests
[ ] Ballerina By Example Tests

[ ] Increased Test Coverage
[ ] Added necessary documentation

[ ] API documentation
[ ] Module documentation in Module.md files
[ ] Ballerina By Examples

@gayalkuruppu can you please attend these comments and fix the conflicts?

authors: gayalkuruppu mohanvive


text:
Tooling support for OracleDB

Description:
Add Tooling support for the OracleDB connector.
Following tooling support must be implemented,

[ ] Diagnostics
[ ] Code completions
[ ] Code actions
[ ] Formatting
[ ] Hover

Diagnostics,
loginTimeout, connectTimeout, connectTimeout needs to be validated for negative values.

authors: kaneeldias niveathika


text:
Parameterized and multiple argument functionality enabled

Purpose
$title
Goals

Parameterization of variables in the code base
Supporting multiple arguments in a ballerina function
Resolving bugs of supporting multiple function declaration

Approach
New parameters were defined in the xml file to enable the multiple arguments. Singleton introduced for connector and the xml generation will be done at the LifeCycle phase. New parameters and methods introduced to connector to parameterize the variables.
User stories

Summary of user stories addressed by this change>

Release note

Brief description of the new feature or bug fix as it will appear in the release notes

Documentation

Link(s) to product documentation that addresses the changes of this PR. If no doc impact, enter “N/A” plus brief explanation of why there’s no doc impact

Training

Link to the PR for changes to the training content in https://github.com/wso2/WSO2-Training, if applicable

Certification

Type “Sent” when you have provided new/updated certification questions, plus four answers for each question (correct answer highlighted in bold), based on this change. Certification questions/answers should be sent to certification@wso2.com and NOT pasted in this PR. If there is no impact on certification exams, type “N/A” and explain why.

Marketing

Link to drafts of marketing content that will describe and promote this feature, including product page changes, technical articles, blog posts, videos, etc., if applicable

Automation tests

Unit tests

Code coverage information

Integration tests

Details about the test cases and coverage

Security checks

Followed secure coding standards in http://wso2.com/technical-reports/wso2-secure-engineering-guidelines? no
Ran FindSecurityBugs plugin and verified report? no
Confirmed that this PR doesn't commit any keys, passwords, tokens, usernames, or other secrets? yes

Samples

Provide high-level details about the samples related to this feature

Related PRs

List any other related PRs

Migrations (if applicable)

Describe migration steps and platforms on which migration has been tested

Test environment

List all JDK versions, operating systems, databases, and browser/versions on which this feature/fix was tested

Learning

Describe the research phase and any blog posts, patterns, libraries, or add-ons you used to solve the problem.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.samithkavishke seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

authors: CLAassistant samithkavishke


text:
zwave component unable to initialize python-openzwave

I recently did a fresh install of home-assistant on an Ubuntu 14.10, AMD64 machine, where I forced all python package installations to be local (either via the --user flag for pip, or by using the setuptools --prefix $HOME/.local/ option for the python-openzwave installation).  The local user is a member of the dialout group, and can access the /dev/ttyUSB0 device.
When I try to run home-assistant, I get the following tracebacks:
ERROR:homeassistant.bootstrap:Error during setup of component zwave
Traceback (most recent call last):
  File "/home/edgimar/.local/lib/python3.4/site-packages/python_openzwave_api-0.2.6-py3.4.egg/openzwave/option.py", line 67, in __init__
    if os.path.exists(config_path):
  File "/usr/lib/python3.4/genericpath.py", line 19, in exists
    os.stat(path)
TypeError: stat: can't specify None for path argument

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/home/edgimar/home-assistant/homeassistant/bootstrap.py", line 75, in _setup_component
    if component.setup(hass, config):
  File "/home/edgimar/home-assistant/homeassistant/components/zwave.py", line 75, in setup
    user_path=hass.config.config_dir)
  File "/home/edgimar/.local/lib/python3.4/site-packages/python_openzwave_api-0.2.6-py3.4.egg/openzwave/option.py", line 74, in __init__
    raise ZWaveException("Can't retrieve config from %s" % config_path)
openzwave.object.ZWaveException: "Zwave Generic Exception : Can't retrieve config from None"

Z-Wave support is broken and will be based on a different version of Python Open Z-Wave, closing all issues related to old one

If Z-wave is broken, it should be removed from https://home-assistant.io/components/#all so we don't waste hours trying to get it to work before finally finding this post.

But it's not broken.
This problem is known and fixed in the latest dev branch.
On Sat, Nov 28, 2015, 06:38 id628 notifications@github.com wrote:

If Z-wave is broken, it should be removed from
https://home-assistant.io/components/#all so we don't waste hours trying
to get it to work before finally finding this post.
—
Reply to this email directly or view it on GitHub
https://github.com/balloob/home-assistant/issues/84#issuecomment-160305449
.

Actually I think it is still broken. If you build python-openzwave with the script from the current dev branch, your end up with:
15-11-28 21:13:29 root: Z-Wave Notification DriverReady : ['Traceback (most recent call last):\n', '  File "/usr/lib/python3.5/site-packages/python_openzwave_api-0.2.6-py3.5.egg/openzwave/network.py", line 855, in _handle_driver_ready\n    logging.debug(\'Network %s\' % self )\n', '  File "/usr/lib/python3.5/site-packages/python_openzwave_api-0.2.6-py3.5.egg/openzwave/network.py", line 297, in __str__\n    (self.home_id_str,  self.controller)\n', '  File "/usr/lib/python3.5/site-packages/python_openzwave_api-0.2.6-py3.5.egg/openzwave/controller.py", line 139, in __str__\n    (self._network.home_id_str, self._object_id, self._node.name, self._node.product_name, self.capabilities, self.library_description)\n', '  File "/usr/lib/python3.5/site-packages/python_openzwave_api-0.2.6-py3.5.egg/openzwave/node.py", line 91, in name\n    return self._network.manager.getNodeName(self.home_id, self.object_id).decode("UTF-8")\n', "AttributeError: 'str' object has no attribute 'decode'\n"]
15-11-28 21:13:29 homeassistant.components.sensor: Error while setting up platform zwave
Traceback (most recent call last):
  File "/usr/lib/python3.5/site-packages/homeassistant-0.9.0.dev0-py3.5.egg/homeassistant/helpers/entity_component.py", line 136, in _setup_platform
    self.hass, platform_config, self.add_entities, discovery_info)
  File "/usr/lib/python3.5/site-packages/homeassistant-0.9.0.dev0-py3.5.egg/homeassistant/components/sensor/zwave.py", line 51, in setup_platform
    specific_sensor_key = (value.node.manufacturer_id,
  File "/usr/lib/python3.5/site-packages/python_openzwave_api-0.2.6-py3.5.egg/openzwave/node.py", line 459, in manufacturer_id
    return self._network.manager.getNodeManufacturerId(self.home_id, self.object_id).decode("UTF-8")
AttributeError: 'str' object has no attribute 'decode'
15-11-28 21:13:29 homeassistant.components.sensor: Error while setting up platform zwave
Traceback (most recent call last):
  File "/usr/lib/python3.5/site-packages/homeassistant-0.9.0.dev0-py3.5.egg/homeassistant/helpers/entity_component.py", line 136, in _setup_platform
    self.hass, platform_config, self.add_entities, discovery_info)
  File "/usr/lib/python3.5/site-packages/homeassistant-0.9.0.dev0-py3.5.egg/homeassistant/components/sensor/zwave.py", line 51, in setup_platform
    specific_sensor_key = (value.node.manufacturer_id,
  File "/usr/lib/python3.5/site-packages/python_openzwave_api-0.2.6-py3.5.egg/openzwave/node.py", line 459, in manufacturer_id
    return self._network.manager.getNodeManufacturerId(self.home_id, self.object_id).decode("UTF-8")
AttributeError: 'str' object has no attribute 'decode'
15-11-28 21:13:29 homeassistant.components.sensor: Error while setting up platform zwave
Traceback (most recent call last):
  File "/usr/lib/python3.5/site-packages/homeassistant-0.9.0.dev0-py3.5.egg/homeassistant/helpers/entity_component.py", line 136, in _setup_platform
    self.hass, platform_config, self.add_entities, discovery_info)
  File "/usr/lib/python3.5/site-packages/homeassistant-0.9.0.dev0-py3.5.egg/homeassistant/components/sensor/zwave.py", line 51, in setup_platform
    specific_sensor_key = (value.node.manufacturer_id,
  File "/usr/lib/python3.5/site-packages/python_openzwave_api-0.2.6-py3.5.egg/openzwave/node.py", line 459, in manufacturer_id
    return self._network.manager.getNodeManufacturerId(self.home_id, self.object_id).decode("UTF-8")
AttributeError: 'str' object has no attribute 'decode'
15-11-28 21:13:30 homeassistant.components.switch: Error while setting up platform zwave
Traceback (most recent call last):
  File "/usr/lib/python3.5/site-packages/homeassistant-0.9.0.dev0-py3.5.egg/homeassistant/helpers/entity_component.py", line 136, in _setup_platform
    self.hass, platform_config, self.add_entities, discovery_info)
  File "/usr/lib/python3.5/site-packages/homeassistant-0.9.0.dev0-py3.5.egg/homeassistant/components/switch/zwave.py", line 31, in setup_platform
    add_devices([ZwaveSwitch(value)])
  File "/usr/lib/python3.5/site-packages/homeassistant-0.9.0.dev0-py3.5.egg/homeassistant/helpers/entity_component.py", line 70, in add_entities
    self.entity_id_format, entity.name,
  File "/usr/lib/python3.5/site-packages/homeassistant-0.9.0.dev0-py3.5.egg/homeassistant/components/switch/zwave.py", line 61, in name
    name = self._node.name or "{}".format(self._node.product_name)
  File "/usr/lib/python3.5/site-packages/python_openzwave_api-0.2.6-py3.5.egg/openzwave/node.py", line 91, in name
    return self._network.manager.getNodeName(self.home_id, self.object_id).decode("UTF-8")
AttributeError: 'str' object has no attribute 'decode'

according to @sandro1005 from here this is an problem with python-openzwave itself.

authors: balloob deisi edgimar id628

repo: balloob/home-assistant


text:
Bitcoin sensor

The 'Bitcoin' sensor is able to show the amount of Bitcoins in an online wallet at blockchain.info and the exchange rate to a given currency if wished. The other options are only interesting for people who have a keen curiosity about what going on in the Bitcoin network and want to see those details all the times.

Coverage increased (+0.03%) to 75.53% when pulling 34eca591616bca3d5b57090854327e939bb6880c on fabaff:bitcoin into a4e0a7f2353c6c55f803969c055d3789e9ea62b9 on balloob:dev.

You've used Throttle not quite in the right way. By putting it on the class method it will throttle all calls to the update method per instance of this object. So right now it is throttled to only call it every 120 seconds but it will still call it once for each sensor. To have it work right we should pull it out of the class and into a separate object.
from blockchain import statistics, exchangerates

class BitcoinData(object):
  def __init__(self):
    self.stats = None
    self.ticker = None

  @Throttle(MIN_TIME_BETWEEN_UPDATES)
  def update(self):
    self.stats = statistics.get()
    self.ticker = exchangerates.get_ticker()

class BitcoinSensor(Entity):
  def __init__(self, data, …):
    self.data = data
    …

  def update(self):
    self.data.update()
    stats = self.data.stats
    ticker = self.data.ticker
    …

def setup_platform(…):
  …
  dev = []
  data = BitcoinData()
  dev.append(BitcoinSensor(data, …))
  add_devices(dev)

Coverage remained the same at 74.75% when pulling 2d1b934a1c2f1630ce8c167e7bcb6466841fa7bc on fabaff:bitcoin into 0466ae5e07d0b7c8d4c1340e688616ae685e0298 on balloob:dev.

Coverage remained the same at 74.75% when pulling 2d1b934a1c2f1630ce8c167e7bcb6466841fa7bc on fabaff:bitcoin into 0466ae5e07d0b7c8d4c1340e688616ae685e0298 on balloob:dev.

Ups...

Don't worry about the LimitlessLED commits, it was my fault that I accepted a PR pointing at the master instead of dev branch.

BTW, thanks for your help.

authors: balloob coveralls fabaff


text:
docs: changed headline on welcome page

Closes #
{{short description}}
Changelog
New

{{new thing}}

Changed

{{change thing}}

Removed

{{removed thing}}

:rocket: Welcome to Baloise ChatOps based GitOps Bot :tada:
- If you want to enable preview environments for this PullRequest, comment with `/preview`.
- If you want to disable the preview environment for this PR, comment with `/undeploy`.
- If you need help or want to see the docs, comment with `/help`.

Make sure to refresh this page after submitting a command.
Preview environments can be redeployed automatically if you enable the webhook for updates to the source branch. :new:

Have fun building awesome apps! :hammer:  :whale2:  :truck:  :ship:

will be done with https://github.com/baloise/design-system/pull/449 due to format issue

repo: baloise/design-system


text:
Password characters

I am see this error when I try to create accounts using a Create Account Link and use a complex password (it seems):

When I installed my test installation, I used much simpler passwords and did not have this problem.
When I set up my production install accounts, I was able to work around this and successfully create accounts by removing most of the special characters from the password.
I guess there's no harm (and good diagnostic info) in revealing that one of the passwords that would not work was: s9m/4Tu:sL@_nFf-. It was generated with a password manager. There was another that failed but unfortunately I don't have that any more.
A couple of weird things I noticed:

the admin account I set up initially has a few of what I assume are similar problem characters
as Admin, I can see the "failed" accounts in the list of users, even though they can't log in (I tried that too)

I think you should be able to reproduce this easily. Just ask if you want more info :)

Heh, I just noticed a typo in that popup dialogue too: "you administrator" → "your administrator".

Hmm, the fix should be quick. I am wrapping up a feature in the next couple days, and then I'll address this. Thanks for catching this!

This should be fixed in the latest container. When you have time, could you verify the fix?
With the 'failed' accounts, the password was saved incorrectly. Those accounts can be accessed from the admin panel with the 'lock' icon, and then the password can be reset (correctly this time), or they can just be deleted.
Thanks for your help with this project.

authors: balzack hughbris

repo: balzack/databag


text:
fixed incorrect startBlock for the cleanup

fixes: #81

closes #81

repo: bancorprotocol/carbon-backend


text:
Unstaked pool tokens from protection but they still appear on protection page

I unstaked CHERRYBNT and sold CHERRY for ETH, but CHERRYBNT still appears in the protection screen.

Same issue occurred when unstaking other pool tokens, such as BATBNT.
Refreshing the page does not resolve the issue and liquidated pool tokens still linger in the protection screen.

user misunderstanding.
closing.

authors: AdamOnChain ashachaf

repo: bancorprotocol/webapp


text:
Support for FormattedHTMLMessage

Hi, I'm curious as to why you don't support FormattedHTMLMessage (as mentioned in your README).
I'm using this library in my project which uses FormattedHTMLMessage in a few places, so I've had to modify this library to support it, which only took a minor change and it seems to work well. I'd be happy to submit a PR for this if you're interested.

Because most of them can use FormattedMessage  instead. so

Thanks for the response. I was mainly curious to know whether you knew of any problems or difficulties in supporting FormattedHTMLMessage that I might have missed.
Most of the time FormattedMessage is fine. However, I have some text in the UI that needs formatting within the string (e.g. some words bold), which would need an ugly hack with the "dangerouslySetInnerHTML" property and a callback function, or splitting the string into incomplete parts, which I'd like to avoid.
I'll raise a PR to make the change to include support for it.

@jtimlin-immt you can try to make a PR and  then we can discuss it, but IMO i think we should not put any HTML tag in a locale message which needs translation. and translate the parts which we really needs it. Maybe some codes for this will explain it more clearly if you have some code snippets.

I don't think splitting the string is really an option. Consider something like this:
When receiving spam email, do not click on it, and instead delete it immediately.

It would be wrong to split the string into the following 4 strings and have them translated individually:
When receiving spam email,
do not
click on it, and instead delete it
immediately

Without context, a translator would have a hard time translating these individual strings. It also doesn't necessarily make sense in all languages to emphasize the same parts of the sentence to convey the same meaning.
FormattedMessage can't be used here, because the parts of the message to be affected by HTML tags are not values like numbers, so cant use placeholders.

On Wed, Sep 27, 2017 at 6:20 AM jtimlin-immt notifications@github.com
wrote:

I don't think splitting the string is really an option. Consider something
like this:
When receiving spam email, do not click on it, and instead delete it immediately.
It would be wrong to split the string into the following 4 strings and
have them translated individually:
When receiving spam email,
do not
click on it, and instead delete it
immediately
Without context, a translator would have a hard time translating these
individual strings. It also doesn't necessarily make sense in all languages
to emphasize the same parts of the sentence to convey the same meaning.
FormattedMessage can't be used here, because the parts of the message to
be affected by HTML tags are not values like numbers, so cant use
placeholders.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/bang88/typescript-react-intl/issues/8#issuecomment-332363595,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAacay0G5-1CHSItmbGH8LbaB-xpEkl5ks5smYa3gaJpZM4PetKE
.

Agree with you. Haha

So I just realized that HTMLFormattedMessage is not getting processed at all and was very surprised by this behavior, but it looks like passing it in options.tagNames works (gets added in here https://github.com/bang88/typescript-react-intl/blob/master/index.ts#L232), eg:
var results = parse(contents, {
  tagNames: ["HTMLFormattedMessage"],
});

Just leaving that in here in case it helps someone else.

authors: bang88 ccnokes jtimlin-immt


text:
Use Reacts component API

I am wondering if an API such as this would be of interest. It would be possible to add a component alongside the mixin. It gives people options. What do you think?
let App = React.createClass({
  getDefaultProps() {
    return {
      text: "foo bar :100: :)",
    };
  },

  render() {
    return (

          <ReactEmoji text = {this.props.text} />

    );
  }
});

The props would be everything listed here.

@vinnymac
Sounds good :smile:

@banyan I started work on it, and it is going well, doing some tests now.
The revised idea is something like this. Thoughts?
// you can still access the mixin and emojify method.
import ReactEmoji, {ReactEmojiMixin, emojify} from 'react-emoji';

let App = React.createClass({
  getDefaultProps() {
    return {
      text: "foo bar :100: :)",
    };
  },

  render() {
    return (

          <ReactEmoji emojiType = 'emojione'>
            {this.props.text}
          </ReactEmoji>

    );
  }
});

authors: banyan vinnymac

repo: banyan/react-emoji


text:
Allow env to be set in vault init container

This is a resubmission of this PR so the CI could run again and it could be merged for the next release.

Q
A

Bug fix?
no

New feature?
yes

API breaks?
no

Deprecations?
no

Related tickets
fixes #1782

License
Apache 2.0

What's in this PR?
This feature enables environment variables to be set In the vault init container
Checklist

[x] Code meets the Developer Guide

This made the original PR all green, closing it.

repo: banzaicloud/bank-vaults


text:
Enable possibility for JSON logging

Q
A

Bug fix?
no

New feature?
yes

API breaks?
no

Deprecations?
no

Related tickets
none

License
Apache 2.0

What's in this PR?
Added the possibility of logging in JSON format in both vault-secrets-webhook as well as in vault-env. Furthermore I've added a global hook for adding additional field to all log entries. I added app as a first field, for easier debugging.
Enabling JSON logging can be configured through the environment variable enable_json_log and can be overridden individually through the annotation: vault.security.banzaicloud.io/enable-json-log to control the output of vault-env.
Cleanup and parity of log methods were also done. So now logrus is used everywhere.
Why?
JSON logging is very useful for structured logging, and is easily parseable for tools such as Datadog,
Papertrail, etc. Furthermore JSON logging makes it easy to add new fields.
Checklist

[x] Logging code meets the guideline (TODO)

To Do
I would like if someone could help me thoroughly test this feature for any regression.

Hi @tommy-dk, thanks for the PR, tbh looks good to me, the acceptance test would have been failed if this caused any regression. Nice job!

Awesome, thank you! 👍

authors: bonifaido tommy-dk


text:
多租户自定义sql分页查询及Count问题

当前使用版本(必填,否则不予处理)
3.2.0
该问题是如何引起的？(确定最新版也有问题再提!!!)
重现步骤(如果有就写完整)
1.自定义SQL如下

多租户条件是手动传递进去的，但MybatsiPlus进行count的时候自动的把多租户条件加上去了，而且 boolean where 是false。

所以想问下这种情况是自己手动分页，然后自己手动写查询汇总sql么？
报错信息

不走租户插件就method上加注解过滤掉

不走租户插件就method上加注解过滤掉

不走租户插件就method上加注解过滤掉

不走租户插件就method上加注解过滤掉
@miemieYaho 好的，知道了，一开始我以为自定义sql不会自动加上租户条件，刚刚研究了下发现会，谢谢

authors: linkangsheng miemieYaho

repo: baomidou/mybatis-plus


text:
SpringCloud配置文件读取问题

当前使用版本
            <dependency>
                <groupId>com.baomidou</groupId>
                <artifactId>mybatis-plus</artifactId>
                <version>3.3.2</version>
            </dependency>

            <dependency>
                <groupId>org.mybatis.spring.boot</groupId>
                <artifactId>mybatis-spring-boot-starter</artifactId>
                <version>1.3.0</version>
            </dependency>

该问题是如何引起的？

SpringCloud工程有bootstrap.yml、applications.yml2个配置文件，在Springboot的加载顺序中前者的优先级比后者高

当mybatis的配置信息写在bootstrap.yml文件中，执行SQL查询时会出现无法找到BaseMapper定义的函数：org.apache.ibatis.binding.BindingException: Invalid bound statement (not found): com.company.springcloud.dao.UserDao.selectList

重现步骤(如果有就写完整)
1.集成BaseMapper配置：public interface UserDao extends BaseMapper<User> {}
2.执行功能测试
@RunWith(SpringRunner.class)
@SpringBootTest(classes = NacosProvider9001.class)
@Slf4j
public class SampleTest {

    @Resource
    UserDao userDao;

    @Test
    public void testSelect(){
        List<User> infoList = userDao.selectList(null);
        infoList.forEach(System.out::println);
    }
}

报错信息
org.apache.ibatis.binding.BindingException: Invalid bound statement (not found): com.useease.springcloud.dao.UserDao.selectList

	at org.apache.ibatis.binding.MapperMethod$SqlCommand.<init>(MapperMethod.java:225)
	at org.apache.ibatis.binding.MapperMethod.<init>(MapperMethod.java:48)
	at org.apache.ibatis.binding.MapperProxy.cachedMapperMethod(MapperProxy.java:65)
	at org.apache.ibatis.binding.MapperProxy.invoke(MapperProxy.java:58)
	at com.sun.proxy.$Proxy137.selectList(Unknown Source)
	at com.useease.springcloud.SampleTest.testSelect(SampleTest.java:26)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
	at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
	at org.springframework.test.context.junit4.statements.RunBeforeTestExecutionCallbacks.evaluate(RunBeforeTestExecutionCallbacks.java:74)
	at org.springframework.test.context.junit4.statements.RunAfterTestExecutionCallbacks.evaluate(RunAfterTestExecutionCallbacks.java:84)
	at org.springframework.test.context.junit4.statements.RunBeforeTestMethodCallbacks.evaluate(RunBeforeTestMethodCallbacks.java:75)
	at org.springframework.test.context.junit4.statements.RunAfterTestMethodCallbacks.evaluate(RunAfterTestMethodCallbacks.java:86)
	at org.springframework.test.context.junit4.statements.SpringRepeat.evaluate(SpringRepeat.java:84)
	at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
	at org.springframework.test.context.junit4.SpringJUnit4ClassRunner.runChild(SpringJUnit4ClassRunner.java:251)
	at org.springframework.test.context.junit4.SpringJUnit4ClassRunner.runChild(SpringJUnit4ClassRunner.java:97)
	at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
	at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
	at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
	at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
	at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
	at org.springframework.test.context.junit4.statements.RunBeforeTestClassCallbacks.evaluate(RunBeforeTestClassCallbacks.java:61)
	at org.springframework.test.context.junit4.statements.RunAfterTestClassCallbacks.evaluate(RunAfterTestClassCallbacks.java:70)
	at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
	at org.springframework.test.context.junit4.SpringJUnit4ClassRunner.run(SpringJUnit4ClassRunner.java:190)
	at org.junit.runner.JUnitCore.run(JUnitCore.java:137)
	at com.intellij.junit4.JUnit4IdeaTestRunner.startRunnerWithArgs(JUnit4IdeaTestRunner.java:68)
	at com.intellij.rt.junit.IdeaTestRunner$Repeater.startRunnerWithArgs(IdeaTestRunner.java:33)
	at com.intellij.rt.junit.JUnitStarter.prepareStreamsAndStart(JUnitStarter.java:230)
	at com.intellij.rt.junit.JUnitStarter.main(JUnitStarter.java:58)
2020-06-03 14:31:25.315  INFO 7448 --- [extShutdownHook] o.s.s.concurrent.ThreadPoolTaskExecutor  : Shutting down ExecutorService 'applicationTaskExecutor'

用 mybatis-plus-boot-starter 而不是 mybatis-spring-boot-starter

删除mybatis其他依赖，只引入以下依赖即解决问题：
        <dependency>
            <groupId>com.baomidou</groupId>
            <artifactId>mybatis-plus-boot-starter</artifactId>
            <version>3.3.2</version>
        </dependency>

authors: ChanaLii miemieYaho


text:
3.4版本 分页插件失效 数据库是MSSQL 退回3.3版本正常

当前使用版本(必填,否则不予处理)
该问题是如何引起的？(确定最新版也有问题再提!!!)
重现步骤(如果有就写完整)
报错信息

这个问题我也碰到过 你需要自行配置分页插件的配置
比如
package com.miaozhen.crutch.config;
import com.baomidou.mybatisplus.annotation.DbType;
import com.baomidou.mybatisplus.autoconfigure.ConfigurationCustomizer;
import com.baomidou.mybatisplus.extension.plugins.MybatisPlusInterceptor;
import com.baomidou.mybatisplus.extension.plugins.inner.PaginationInnerInterceptor;
import org.springframework.context.annotation.Bean;
import org.springframework.context.annotation.Configuration;
import org.springframework.core.annotation.Order;
/**

@author
*/
@Order(1)
@Configuration
public class MybatisPlusConfig {
/**

新的分页插件,一缓和二缓遵循mybatis的规则,需要设置 MybatisConfiguration#useDeprecatedExecutor = false 避免缓存出现问题(该属性会在旧插件移除后一同移除)
需要在sqlsessionFactory指定 sqlSessionFactoryBean.setPlugins(xxxxxxxx);
*/
@Bean("mybatisPlusInterceptor")
public MybatisPlusInterceptor mybatisPlusInterceptor() {
MybatisPlusInterceptor interceptor = new MybatisPlusInterceptor();
interceptor.addInnerInterceptor(new PaginationInnerInterceptor(DbType.MYSQL));
return interceptor;
}

//TODO 使用高版本配置
@Bean
public ConfigurationCustomizer configurationCustomizer() {
return configuration -> configuration.setUseDeprecatedExecutor(false);
}
}

authors: 2524685265 miemieYaho yanxinren


text:
fastjson 1.2.80及以下存在新的风险需要更新

当前使用版本(必填,否则不予处理)
3.4.0
该问题是如何引起的？(确定最新版也有问题再提!!!)
https://github.com/alibaba/fastjson/wiki/security_update_20220523?spm=5176.b45069876.sas.30.3f282b72UnBdfA
重现步骤(如果有就写完整)
报错信息

没用它

authors: michealzh miemieYaho


text:
Spring Boot 升级到 3.0 版本后无法进行自动配置

当前使用版本(必填,否则不予处理)
MyBatis Plus Boot Starter v3.5.2
该问题是如何引起的？(确定最新版也有问题再提!!!)
由于 Spring 团队在 Spring Boot 3.x 版本中移除了通过 META-INF/spring.factories 文件注册自动配置的方式，导致在 Spring Boot 3.0 环境下没有探测到 MyBatis Plus 内的 AutoConfiguration

可参考 Spring 官方迁移文档

重现步骤(如果有就写完整)
创建 Spring Boot 3.0 项目并引入 MP，随意设置一些 Mapper 后，通过 @Autowired 引用 Mapper 时会提示没有这个 bean

https://github.com/baomidou/mybatis-plus/issues/4971

authors: miemieYaho theodorehills


text:
代码生成器，entity格式不准确

mybatis-plus 版本为：3.5.6
生成的entity，格式化不对有点别扭。希望可以修改模板；
目前我通过复制修改entity.java.ftl 已经解决自己的问题；希望作者有时间的时候可以修改下模板；

解决办法为：
1.依赖中添加

org.freemarker
freemarker

2. 代码生成器中添加
.templateConfig(builder -> {
builder.entity("templates/entity.java.ftl");
}).templateEngine(new FreemarkerTemplateEngine())

指定自己的模板
其中entity.java.ftl是从

复制过来的；
我把自己的模板发一下， 下载后请修改下名称后缀( 这里不支持传这个后缀的文件)
entity.java.txt

提供复现工程.

authors: nieqiurong tb-bear


text:
Upgrade local dependencies (bundle update)

All the tests are passing with rails test

Closing in favor of #82

authors: dorianmariecom jeremy


text:
utility functions needs to moved out  from the Curve class

There are several utility functions (pow, perm, comb, fac) that can be moved out to a seperate utility/helper function header file.

Also note that these functions are used in other files as well.

repo: baskinburak/splx


text:
Custom turn_on & turn_off services

Not sure how feasible this would be, but it'd be great if AL had custom turn_on/_off services that could be called, which would then package the appropriate brightness and color temp into a light.turn_on command and send that to home assistant. I use a lot of motion sensors so if someone hasn't been in the room since it's been light out, there's often a pop of light when motion is triggered b/c the light is turned on first to it's previous state and then quickly adjusted by AL. I know some have their light.turn_on commands packaged with a brightness of 1, but having AL handle the initial turn_on command seems more elegant. Thanks for all your work! Because of your component (and motion sensors) I never have to manually turn on/off or adjust lights anymore!

Not used it myself, as of yet, but adaptive_lighting.apply service looks to be what you're after.

This is what I do to avoid that transition and prime the light with the right colour temp and brightness ahead of switching on:
service: light.turn_on data_template:   entity_id: light.corridor_lights   kelvin: >-     {{ state_attr('switch.adaptive_lighting_corridor', 'color_temp_kelvin') |     int }}   brightness_pct: >-     {{ state_attr('switch.adaptive_lighting_corridor', 'brightness_pct') | int     }}

Not used it myself, as of yet, but the adaptive_lighting.apply service looks to be what you're after.

I'll have to test this out. My initial reading of it was that it would operate just like the component normally does (e.g. turn on light, then adapt), but on demand.

This is what I do to avoid that transition and prime the light with the right colour temp and brightness when turning the lights on using motion sensors. I get no jump in temp or brightness as a result.
service: light.turn_on
data_template:
entity_id: light.corridor_lights
kelvin: >-
{{ state_attr('switch.adaptive_lighting_corridor', 'color_temp_kelvin') |
int }}
brightness_pct: >-
{{ state_attr('switch.adaptive_lighting_corridor', 'brightness_pct') | int
}}
The adaptive light switch needs to be on for the variables colour temp and brightness to be populated.

I always keep AL on so this should work. Thanks! I'll give it a go!

I'll have to test this out. My initial reading of it was that it would operate just like the component normally does (e.g. turn on light, then adapt), but on demand.

Sorry, should have highlighted the turn_on_lights attribute of the service.

turn_on_lights
Whether to turn on lights that are currently off.

That was what I had in mind—though behaviour can be pretty variable per brand/model: it's good to have finer control in those situations; igiannakas' use of a data template looks perfect for such.
You might also look towards Template Light, to completely handle functionality. I suspect that's a little too much manual control, though, as it steps around much of the convenience afforded by the Adaptive Lighting integration.

turn_on_lights isn't the perfect solution. My IKEA Tradfri bulbs need separate commands for brightness and color.
When I trigger the adaptive_lighting.apply the two transitions of the service and the two transitions of the initial_transition start and if a transition start while another transition is still ongoing the ongoing transition gets cancelled. And if the timing is bad they cancel each other in a way that bulb does not reach it's final color/brightness.
Is there an easy way to suppress the the initial_transition?

For testing purposes I removed the following call in line 917 in switch.py
await self._update_attrs_and_maybe_adapt_lights(
    lights=[entity_id],
    transition=self._initial_transition,
    force=True,
    context=self.create_context("light_event"),
)

Without this the adaptive_lighting.apply with turn_on_lights works like a charm and just the two service calls for brightness and color are issued.
Does this function call do anything else than the initial_transition? If it's only for the initial_transition than a checkbox in the UI could be added and the function could be called depending on the checkbox.

I've had success with my ikea lights by setting the initial transition to zero.
On Mar 23, 2021, 17:26 -0400, Slinky-Wrangle-Punch @.***>, wrote:

For testing purposes I removed the following call in line 917 in switch.py
await self._update_attrs_and_maybe_adapt_lights(
lights=[entity_id],
transition=self._initial_transition,
force=True,
context=self.create_context("light_event"),
)
Without this the adaptive_lighting.apply with turn_on_lights works like a charm and just the two service calls for brightness and color are issued.
Does this function call do anything else than the initial_transition? If it's only for the initial_transition than a checkbox in the UI could be added and the function could be called depending on the checkbox.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

I am also this issue, had a hope zigbee2mqtt will speed things up (compared to Tradfri and Hue), but it's not that much.
It would be great to have a service that preloads light.turn_on with appropriate settings!

I'm currently in the process of doing version 2. This will be added/fixed.
Keep this ticket open until you can verify that it's properly working in the upcoming version 2.

This is currently done/waiting-for-review

The problem described by @Slinky-Wrangle-Punch here https://github.com/basnijholt/adaptive-lighting/issues/86#issuecomment-805222134 is no longer present.
Right now AL will wait for transitions that have been set (thanks to @th3w1zard1! :tada:)
Therefore, I think the request has an existing solution (use adaptive_lighting.apply with turn_on_lights and desired transition). Then just use the normal light.turn_off.

authors: KrzysztofHajdamowicz RubenKelevra Slinky-Wrangle-Punch basnijholt igiannakas jackemerson th3w1zard1 trevorbenyack

repo: basnijholt/adaptive-lighting


text:
Sidebar Added

This has a toggle button which opens the sidebar and closes it in a sliding fashion.
Folders have been made just like you instructed.
Here is a screenshot :)

Thanks for your contribution , do keep contributing and leave a star if you liked the repo .😃


text:
add Floating support

presently quite some mathematical operations are defined on the Floating typeclass.
would you be willing to take a PR adding support for this extra functionality?

I don't see how they would work.

i'm not sure how to implement things like exp/log/sin on Scientific yet either, but if we're at the question of implementation already then that sounds like progress i guess. :)

I think that they don't have reasonable implementations, that's why I asked. You would need to pick some arbitrary precision and that doesn't sound like a good idea. I there are other option or a clever trick, I'm curious to hear about tit!

i'm not sure i have the answers.
until we have indication there is a solution here, perhaps i should mark this as closed, given this doesn't presently seem actionable from an implementation standpoint.

authors: KiaraGrouwstra phadej

repo: basvandijk/scientific