text:
Akka Stream integration

Hi folks,
I'm looking for a replacement to the postgresql-async Netty driver and found this one, which is very cool. I've taken a look at the rxJava2 API and I've been attempting to integrate with Akka Streams with limited success.
Integration between rxJava and Akka Streams seems fine when we're publishing data (select), but becomes problematic when we just want to insert data and end the stream. Based on the Java docs I've found the following, which looks promising:
Completable completable = pool
  .rxBegin()
  .flatMapCompletable(tx -> tx
    .rxQuery("INSERT INTO Users (first_name,last_name) VALUES ('Julien','Viet')")
    .flatMap(result -> tx.rxQuery("INSERT INTO Users (first_name,last_name) VALUES ('Emad','Alblueshi')"))
    .flatMapCompletable(result -> tx.rxCommit()));

completable.subscribe(() -> {
  // Transaction succeeded
}, err -> {
  // Transaction failed
});

From what I can tell, Completable will never work as a Subscriber, so Akka Streams cannot take advantage of the above code, some it would need to be extended to accept something like Completable (which naively seems like a Future).
Akka Streams does have the handy mapAsync for such deferred computation, but normally takes a Future as input. My thought then is could a query/transaction return a Future, aside from a Handler callback?
Thanks in advance!
Cheers,
Rowland

Just saw this issue: https://github.com/reactiverse/reactive-pg-client/issues/270, Single can also be wrapped as a java.util.concurrent.Future:
Single.just(contract)
              .map(JsonObject::mapFrom)
              .map(Json::create)
              .flatMap( foo -> pool.rxPreparedQuery(CREATE_QUERY, Tuple.of(foo)) )
              .map(ar -> uuid)
              .toFuture()

I'll try this, cheers!

@rowlandwatkins a Completable can be converted to a Publisher. I'm curious how that doesn't work for you?

Hi @tsegismont, I'm not sure how a publisher will help, since I need a Subscriber... Or am I looking at this the wrong way?

@rowlandwatkins can't Akka streams create a subscriber from any Publisher?

authors: rowlandwatkins tsegismont yieldone

repo: reactiverse/reactive-pg-client


text:
WIP #479 [BUG] System.ObjectDisposedException: 'Can not access a closed Stream.'

What kind of change does this PR introduce?
Bug fix
closes #479
closes #509
What is the current behavior?
Android bitmap loader can throw an exception for stream
What is the new behavior?
add bytes onto a stream if not read only and then load it.
What might this PR break?
any image source not expecting termination bytes as specified.
Please check if the PR fulfills these requirements

[x] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

Other information:
i'm not particularly happy with this, it feels like a hack to deal with a downstream problem

i need to de-dupe the test image assets and link them across unit test project and android runner then should be good to go

source: gharchive/pull-request

repo: reactiveui/splat

license: MIT

license_type: permissive

license_source: github-api


text:
React-PropTypes-to-prop-types.js has a transformation error

When trying to upgrade to the latest version of React (migrating prop types and create class stuff), I found a LOT of errors with this particular codemod when running it on my codebase:
~/Developer/paypal/p2pnodeweb (pr/upgrade-react)
🚀  $ jscodeshift -t react-codemod/transforms/React-PropTypes-to-prop-types.js public/js/
Processing 691 files...
Spawning 7 workers...
Sending 50 files to free worker...
Sending 50 files to free worker...
Sending 50 files to free worker...
Sending 50 files to free worker...
Sending 50 files to free worker...
Sending 50 files to free worker...
Sending 50 files to free worker...

...

 ERR public/js/calculator/containers/to-country/__tests__/skip-to-xoom.js Transformation error
TypeError: Cannot read property 'name' of undefined
    at /Users/kdodds/Developer/paypal/p2pnodeweb/react-codemod/transforms/React-PropTypes-to-prop-types.js:91:7
    at Array.filter (native)
    at Collection.filter (/Users/kdodds/.nvm/versions/node/v4.7.0/lib/node_modules/jscodeshift/dist/Collection.js:65:46)
    at removeDestructuredPropTypeStatements (/Users/kdodds/Developer/paypal/p2pnodeweb/react-codemod/transforms/React-PropTypes-to-prop-types.js:90:6)
    at module.exports (/Users/kdodds/Developer/paypal/p2pnodeweb/react-codemod/transforms/React-PropTypes-to-prop-types.js:163:22)

...

All done.
Results:
168 errors
0 unmodified
436 skipped
87 ok

Here's what that __tests__/skip-to-xoom.js file looks like:
import React from 'react'
import { render } from 'enzyme'
import SkipToXoom from '../skip-to-xoom'

test('the rendered button redirects to the proper URL when clicked', () => {
	const toCountryData = { countryName: 'India', countryCode: 'IN' }
	const div = renderToDiv({ toCountryData, userLang: 'en_us' })
	const { attribs: { href } } = div.find('a')[0]
	expect(href).toBe('#')
})

/**
 * Render the <SkipToXoom /> component to a div with the given props
 * We have to do some fancy footwork with the Router component to get
 * the Link component in our SkipToXoom component to render out the href
 * @param {Object} props - the props to apply to the component
 * @returns {Element} - the div that contains the element
 */
function renderToDiv(props = {}) {
	return render(<SkipToXoom {...props} dispatch={() => {}} userLang="en" />)
}

Any ideas?

Note that I did get errors for files that do actually utilize PropTypes (like this one):
import React, { PropTypes } from 'react'
import { StyleSheet, css } from 'aphrodite'
import * as ViewActions from '../../actions/actions'

import content from '../../lib/content'
const i18n = content('crossBorder/calc')

// Allows User to skip straight to Xoom if they want to repeat the
// prior Xoom transaction
const styles = StyleSheet.create({
	skipContainer: {
		lineHeight: '60px',
		marginBottom: 30,
		borderRadius: 5,
		backgroundColor: '#f5f7fa',
		fontSize: 15,
	},
})
const SkipToXoom = React.createClass({
	propTypes: {
		dispatch: PropTypes.func.isRequired,
		toCountryData: PropTypes.shape({
			countryName: PropTypes.string.isRequired, // localized country name
			countryCode: PropTypes.string.isRequired,
		}),
	},
	redirectToXoom() {
		this.props.dispatch(ViewActions.redirectToXoom({
			type: 'repeatUser',
			countryCode: this.props.toCountryData.countryCode,
		}))
	},
	render() {
		const { toCountryData: { countryName } } = this.props
		return (

					{i18n('skipToXoom.body', { country: {countryName} })}

				{' '}

					{i18n('skipToXoom.link')}

		)
	},
})

export default SkipToXoom

Yeah, I'm seeing the same error.

Still seeing this. Is it because my babel setup is in my webpack instead of babelrc?

Hey @kentcdodds! Sorry for not seeing this issue earlier. Have had my hands full the past few days.
I committed a few bug fixes this evening that should resolve the issues you reported above. (I ran the code snippets you provided to make certain.)
One thing to note: In your second example, the codemod will insert semicolons after the react and prop-types imports. (Sorry!)

Have had my hands full the past few days.

No worries. Understandable :)

I committed a few bug fixes this evening that should resolve the issues you reported above. (I ran the code snippets you provided to make certain.)

Great! Thanks!

One thing to note: In your second example, the codemod will insert semicolons after the react and prop-types imports. (Sorry!)

No worries! We can autofix that away!

source: gharchive/issue

authors: bvaughn ericdfields kentcdodds lloydh

repo: reactjs/react-codemod

license: mit

license_source: bigquery


text:
[fixed] Issue #526 Import PropTypes as default import.

Fixes #526 .
Changes proposed:

Import PropTypes as default.

Acceptance Checklist:

[x] All commits have been squashed to one.
[x] The commit message follows the guidelines in CONTRIBUTING.md.
[x] Documentation (README.md) and examples have been updated as needed.
[x] If this is a code change, a spec testing the functionality has been added.
[x] If the commit message has [changed] or [removed], there is an upgrade path above.

Coverage increased (+0.04%) to 86.375% when pulling 97a4f7171faebee7b42762e8796ee419f1447d11 on kennykaye:proptypes-import into a2a71286fc18781b235770ce0a985e6853eddb49 on reactjs:master.

Thank you, @kennykaye!

Released v3.0.2.

authors: coveralls diasbruno kennykaye

repo: reactjs/react-modal


text:
if componentDidMount() throws, subscription in connect() fails

I have a reduced test case here:

http://codepen.io/jokeyrhyme/pen/wGjxNo

When my componentDidMount() method throws, the store subscription set up within connect() doesn't work, so neither my mapStateToProps() function nor render() method are called.
As it happened, in this particular case I wasn't able to review the console log live, so I did not immediately notice that my componentDidMount() was broken.
Should the connect()ed component be more resilient to lifecycle bugs caused by the wrapped component?
I'm not really sure there's much that can be done here. But I figured I'd leave a trail just in case someone else has a similar problem.

When React officially supports error boundaries (https://github.com/facebook/react/pull/5602 started work on this, and you can track it in https://github.com/facebook/react/issues/2461), you’ll be able to catch those errors. We can’t really do anything on the library level here because it’s impossible to guess every possible combination of things going wrong.

authors: gaearon jokeyrhyme

repo: reactjs/react-redux


text:
Returning partial state

I looked at the redux examples, the egghead & pluralsight videos but I can't figure out how this problem is solved.
The Problem:
I have a large json dataset for products which I call it the products source of truth. Using some filtering, I have to filter this dataset and return a subset of products that match the filter. I can use different filters and it should return a subset from the source of truth. The filters can be (1) products having the keyword 'javascript' in the title (2) products with price greater than $10. I can also add a new product to this source of truth. I can apply filter again and the newly added product may return in the result subset.
All the reducer examples that I saw are returning a state from the previous state. So, in my case if I follow that reducer principle, I can apply a filter on the products source of truth and get a new state. Now if I apply another filter, I can apply that only on the new state and not on the source of truth. So, the filter is done on the already filtered products state.
I want the filter to apply on the original/master products source of truth. I don't want the filter to be applied on the already filtered state.
Can someone help?

The general suggested approach is to keep your base data in Redux, and derive additional data as needed, usually using memoized "selector" functions.  See http://redux.js.org/docs/recipes/ComputingDerivedData.html.
Also, note that this is a usage question, and those should be posted over on Stack Overflow.  Closing this here, but please feel free to re-post the question on SO and paste the link in this issue.

The question is moved to Stack Overflow.

authors: markerikson varghesep

repo: reactjs/redux


text:
[Feature Request] [hooks] input#value bindings with useState

From https://github.com/facebook/react/issues/18611 including dmytro-lymarenko's ideas
Summary
Many of the popular JavaScript frameworks support binding value to a HTMLInputElement
The purpose of value binding is to eliminate the need both the value and the onchange property.
I think, with the new useState syntax, it became possible to implement this in react with a nice syntax and no breaking changes.
Detailed design
function MyComponent() {
  const bind = useState('')
  const [value, setValue] = bind
  return (
    <input bind={bind} />
    // ...
  )
}

Alternatives
By introducing a new hook.
In my opinion, this is easier to learn.
const [value, bind] = useStateBind('')

{value}

<input bind={bind} />

What is the benefit of not passing the value? Seems like your introduce API complexity and possible confusion to save a very minimal amount of typing. You could always do something like this yourself with a custom hook
const useBinding = (defaultValue) => {
  const [value, onChange] = useState(defaultValue)

  return { value, onChange }
}

// ...

const bind = useBinding('')

{bind.value}

<input {...bind} />

Almost every website has some sort of forms. By using a bind, the code will be cleaner and more failsafe.
And I think that this is not that confusing, and it takes seconds to learn it.

But with jquence's suggestion to make a custom hook, you're not going to be writing that. You'll be writing this:
<input type="text" placeholder="Hello World" {...bind} />

...which actually happens to be shorter than the proposed syntax, without introducing new API or new concepts

api implies low-level things, what you offer ALREADY can be described by the available api.

It would be great if exist an small standard library with a set of the most necessary hooks.
It’s bad when there is no standard, and everyone implements by himself such commonly used things as two way binding.

Hi, thanks for your suggestion. RFCs should be submitted as pull requests, not issues. I will close this issue but feel free to resubmit in the PR format.

authors: MaxmaxmaximusGitHub gaearon jquense kingdaro sergeysibara tomitheninja

repo: reactjs/rfcs


text:
Suggestion for using forwardRef for imperative API (QUESTION)

I'm not sure it's the right place but it's not a bug so I'm not sure where is the right place. (Maybe a new API)
In project I work on, there is a TextField component which is more than a wrapper for <input>. It wraps the <input> element with a <div> to overcome some limitation that needed by a requested design.
TL;DR
The forwardRef API as is seems to not be usable for this use case, because:

The actual wrapper is a <div> which is not what you expect when you manually want the textfield element. Because you would expect the <input> for using commands such as #focus() or #checkValidity() and so

But sometimes you do need the <div> container because you need to measure the element which the inner <input> is useless for. ReactDOM.findDOMNode from what I've search isn't recommended. But it also blocks the ability to use the code in React Native or other renderers

Today, I add functions to the component class such as TextField#focus() (that calls focus on the <input>) and I'll probably need to add one for TextField#getClientRects() (for measure the <div>). But, it seams redundant and not very stable as more native DOM functionality is needed to warped by the component class for imperative needs use cases (as the project grows and more needs are added).
What do you think I should do?
Maybe forwardRef need some tweaks?
Maybe a new API is needed?
Or maybe the current scenario of what I do is the least worst option?

You could set up your forwardRef to target the actual <input>, then add a wrapperRef or containerRef prop that you can then pass to the <div>, allowing people to choose which element to reference.

@j-f1 First of all, thanks for the response. But than it wouldn't be straight forward to use in cases when ref comes from a "render prop" pattern. For example <Tooltip {…} renderTooltip={…}  render={(props) => <TextField {...props} />} />.

If you need the <div> ref more often, you could make the ref prop connect to the <div> and have a inputRef param that connects to the <input>.

I would like to add an example to be sure i'm not missing something here.
Sometimes we want to get the DOM node without caring what type of children we get (function, text, class or regular DOM element).
findDOMNode was the perfect tool for this task.
Given this component:
class Trap extends React.Component {
  state = {
    trapped: false
  };

  componentDidMount() {
    const { event } = this.props;
    this.ref = findDOMNode(this);
    document.addEventListener(event, this.handleEvent);
  }

  componentWillUnmount() {
    const { event } = this.props;
    document.removeEventListener(event, this.handleEvent);
  }

  handleEvent = ({ target }) => {
    if (this.ref && this.ref.contains) {
      const trapped = this.ref.contains(target);
      this.setState({ trapped });
    }
  };

  render() {
    const { children } = this.props;
    const { trapped } = this.state;

    if (typeof children === "function") {
      return children(trapped);
    } else {
      return null;
    }
  }
}

We could use it with a simple API:
<Trap event="click">{trapped => <Box isFocused={trapped} />}</Trap>
But now with out findDOMNode we invert the responsibility of handling the  ref to the consumer.
So our API must change and expose the ref function for the consumer to use it:
class TrapWithRef extends React.Component {
  state = {
    trapped: false
  };

  componentDidMount() {
    const { event } = this.props;
    document.addEventListener(event, this.handleEvent);
  }

  componentWillUnmount() {
    const { event } = this.props;
    document.removeEventListener(event, this.handleEvent);
  }

  handleEvent = ({ target }) => {
    if (this.ref && this.ref.contains) {
      const trapped = this.ref.contains(target);
      this.setState({ trapped });
    } else {
      console.log("no ref -> ", this.ref);
    }
  };

  render() {
    const { children } = this.props;
    const { trapped } = this.state;

    if (typeof children === "function") {
      return children(trapped, ref => (this.ref = ref));
    } else {
      return null;
    }
  }
}

The consumer will use it this way:
<TrapWithRef event="click">
  {(trapped, ref) => <Box innerRef={ref} isFocused={trapped} />}
</TrapWithRef>

Of course this is limiting as the consumer can't "just" render anything. for example text is out of the question, but more important the consumer will need to pass the ref down to <Box /> and attach it somewhere (let's say box is not a class component).
I don't mind this change as i understand this is a minor downgrade compare to the benefits we gain with ditching findDOMNode. I just want to be sure I'm not missing anything or maybe there is a way to keep this behavior without findDOMNode .


text:
yarn android 编译失败

上周已经下载运行成功过了 没有使用代理软件 今天在跑一下就这样了

检查下你的配置环境，看看环境配置是否完整
npx react-native info

repo: reactnativecn/react-native-website


text:
How to put hidden per size (i.e. hidden-xs) on Col?

I am trying to do <Col xs={{hidden: true}}>... but it looks like hidden is not supported on the ColumnProps
Is there a simple way of adding this? Or should I just use className?
Thanks,
Ben

Since this is a utility and not restricted to just Col it is not supported by Col in that way. For now, className is how to achieve this.

I am closing this as the question has been answered and the issue is no longer active. If you are not satisfied with the answer or have further concerns on this topic, please feel free to reopen and/or comment

@TheSharpieOne Can you show us an example what this should look like? This won't work:
<Row>                         <Col xs="6" sm="4">.col-6 .col-sm-4</Col>                         <Col xs="6" sm="4">.col-6 .col-sm-4</Col>                         <Col className="hidden-xs" sm="4">.col .col-sm-4</Col>                     </Row>

Got it, I'm using v4 which uses something like d-*-none. See https://getbootstrap.com/docs/4.0/migration/#responsive-utilities

try with xs-hidden not hidden-xs
<Col xl="2" md="2" className="text-center xs-hidden">

FULL HD
HD
SD
MOBILE

authors: TheSharpieOne bherila klabusta reversTeam thiagomatrix

repo: reactstrap/reactstrap


text:
git flow and submodule workflow problems

We have run into a number of problems that SEEM to be related to our use of submodules and git-flow.  This issue is simply providing a place to discuss these issues.  Note that this is in readium-js-viewer, but could have been in any repo as it affects all of them.
Currently, Ric tried to push the 0.20 release but somehow, the changed folder structure in the 0.20 release (where readium-js changed significantly and readium-shared-js is a in a different folder and other parts of the folder structure changed) caused git flow to throw errors and abort - sort of (being a bash script, it's error handling is minimal at best).  Result is that when the dust settled, readium-shared-js in master had been nuked.  This has been reverted but the bad commit is still there.  However, that is a separate problem.  More generally it is not easy to see how git-flow can be used seamlessly with submodules.  The following threads are exploring this.

Some random notes as I work through this:

SourceTree.

Seems to see some submodules but not all.  For example, it doesn’t see the readium-cfi-js submodule in readium-shared-js as a submodule.  Git does if you do ‘git submodule status’ from the command line but ST doesn’t.  Bug, one presumes.

Daniel’s documentation says do:  git submodule foreach —recursive “git checkout develop”

Note the use of double-quotes.  If you use single-quotes (as the doc does) it works in the terminal on OSX but NOT in a bash script.  Has to be double-quotes.
Note that this does NOT operate on the root folder where the command is executed.  So the status of the root folder doesn’t change
There is a gotcha here because in order to use git-flow, one has to do 'git flow init’ in each folder to be part of the release.  BUT git flow init doesn’t work unless the “master” branch has been initialized (checked out) in each folder.

git flow init

This really puzzles me.  If you look at the git-flow decomposition:
git flow init becomes “git init”, “git commit —allow-empty –m 'Initial commit', "git checkout –b develop master”
This last command makes no sense to me.  Why would I want to create a new “develop" branch based on master?
OTOH, git flow release start is:  “git checkout –b release/n.n develop
This makes more sense as I am now creating the new release branch by cloning develop
Also, note that the action of “git flow init” in the submodule folders causes them to be changed, so that each parent of the submodule now detects that the underlying submodule has changed and the parent now needs to be updated.

Seems like the right flow (just plain git commands) is:
Initialization
 None

Start
git checkout develop                               # develop has to exist locally first
git checkout –b release/0.20.1 develop  # create the release by cloning develop
git push origin release/0.20.1                 # push the local changes to the remote to make them public

Finish
git checkout master		             # switch to the master branch
git merge —no-ff release/0.20.1	     # merge into master from the release branch
git tag –a 0.20.1				     # tag that location in the master branch
git checkout develop			     # now switch to the develop branch
git merge —no-ff release/0.20.1	     # merge the release branch back
git branch –d release/0.20.1	     # finally, delete the release branch

With these commands, one can start at the bottom (readium-js-cfi) and create a new release branch.  When all 4 (e.g. for readium-js-viewer) repos are good with the right submodule pointers, repo is clean.
One still has the issue that various changes (including merging the previous release to master) may have made "master" ahead of develop (and hence the release branch).
To resolve this:
 git checkout release/0.20.1
 git merge --no-ff master

Just a clarification:
@rkwright quote:

Daniel’s documentation says do: git submodule foreach —recursive “git checkout develop”
Note the use of double-quotes. If you use single-quotes (as the doc does) it works in the terminal on OSX but NOT in a bash script. Has to be double-quotes.

The documentation was updated a while ago to replace single with double quotes (thank you by the way for pointing this out): https://github.com/readium/readium-js-viewer/blob/develop/README.md#git-initialisation

Note that this does NOT operate on the root folder where the command is executed. So the status of the root folder doesn’t change

True, but that's exactly why the full command stated in the documentation is: git checkout BRANCH_NAME && git submodule foreach --recursive "git checkout BRANCH_NAME", not just the second part :)

Just a note about git merge --no-ff: this is useful as it forces Git to record a separate merge commit for a given feature branch when it gets merged into develop, or for when a release branch is finalised and gets merged into master (typically, feature and release branches are deleted afterwards, so it helps to have some identifiable standalone merge commit in the Git history). However, there is another use of the git merge command in the context of maintaining a ongoing feature branch up-to-date with the latest changes from develop. In this case, fast-forward is the default behaviour of git merge, which I think makes sense because we do not want a new "intermediary" commit everytime this happens. We just want to be able to "mark" the finalisation of a feature or release branch.

We're not using GitFlow -style branching anymore, see updated release process documentation:
https://docs.google.com/document/d/17-1k__eJUqeK0GWcH9eYqz8i-2U6CWj88_u7LTZHxwc

authors: danielweck rkwright

repo: readium/readium-js-viewer


text:
Fixes #362 add a focus ring to content area

I'm not quite ready to submit but would like someone to review my approach to fixing this before I test on all platforms.  Seems simple enough but there may be subtleties that I missed.
thanks,
-becky

Hello Becky, I produced a new PR using your code (now merges fine in refactored develop branch):
https://github.com/readium/readium-js-viewer/pull/371/files


text:
needsFixedLayoutScalerWorkAround ReaderView setting cannot be used with zoom function > 100% (clipped viewport)

Currently, only OSX uses the needsFixedLayoutScalerWorkAround workaround (to fix a WebView-specific rendering / clipping bug), see:
https://github.com/readium/SDKLauncher-OSX/issues/21#issuecomment-60068155
Code references:
https://github.com/readium/SDKLauncher-OSX/commit/e9092698a7eaa728325a4d83f9c24b8d7f1ec7be#diff-14a5cfdb45121ceecfd23a430ab5652cL58
https://github.com/readium/readium-shared-js/commit/ca4e1d02eb7b83f22435f2a58cfd63c0828b09e0#diff-7f14747656265ce3e39fee34e732d161R78
var reader = new ReadiumSDK.Views.ReaderView(
                 {
                    needsFixedLayoutScalerWorkAround: true,
                     el:"#viewport",
                     etc...
                 });

_needsFixedLayoutScalerWorkAround = options.needsFixedLayoutScalerWorkAround;
this.needsFixedLayoutScalerWorkAround = function() { return _needsFixedLayoutScalerWorkAround; }

...but, there are discussions to use the same workaround to address a Chrome rendering glitch, see:
https://github.com/readium/readium-js-viewer/issues/313#issuecomment-92677508

Seems fixed here:
https://github.com/readium/readium-shared-js/commit/ac77726c26cd49607a484dc77629dddb238277fc
Needs testing with OSX WebView.

I forgot to mention, the above fix is committed to a "feature" branch: https://github.com/readium/readium-shared-js/compare/feature/177-scalerDivZoomedSize

Follow-up: also test scroll view! See https://github.com/readium/readium-js-viewer/issues/313#issuecomment-92982632

Fixed by Pull Request: https://github.com/readium/readium-shared-js/pull/183

repo: readium/readium-shared-js


text:
Trigger a CustomEvent on config load

This would be useful for theme authors
https://developer.mozilla.org/en-US/docs/Web/API/CustomEvent

The idea behind this is to communicate that the API call is done and the data is available for usage. This is, window.readthedocs object is ready.
This object will have the same data structure than the API response. This is on purpose to avoid maintaining multiple data structures. Authors will pin the version they are compatible with by using the meta tag: #61

repo: readthedocs/readthedocs-client


text:
fix broken pipeline

i don't know why the pipeline goes brrrrrrrrr fix it

done

repo: realAP/myfinance


text:
Cannot build Realm by using Carthage on XCode 7.3 final

Hello,
I'm trying to build Realm Lib from carthage but this problem happen.
Please spend your time to investigate it.
Error:(7, 8) module file was created by an older version of the compiler; rebuild 'RealmSwift' and try again: /Users/myname/Workspace/project/Carthage/Build/iOS/RealmSwift.framework/Modules/RealmSwift.swiftmodule/x86_64.swiftmodule
Xcode 7.3
Carthage latest version
Thanks,

As a temporary workaround, you can build the framweworks manually:
$ git clone https://github.com/realm/realm-cocoa.git
$ cd realm-cocoa/
$ git checkout v0.98.5
$ REALM_SWIFT_VERSION=2.2 sh build.sh build
and replace the ones installed by Carthage:
$ cp build/ios/swift-2.2/Realm.framework /Carthage/Build/iOS
$ cp build/ios/swift-2.2/RealmSwift.framework /Carthage/Build/iOS

This solution work to compile and run on an 9.3 device, but does not upload to iTunes connect. Is there a timeline to get it working with Carthage again?

@jpsim's comment in #3355 goes into why you're seeing this error, and what you can do to work around it. It boils down to having Carthage build Realm from source rather than using pre-built binaries, as pre-built binaries of Swift frameworks require that you're using the same version of Xcode that a Realm release was built with.

thanks @antfarm , it worked.

We have just released Realm Swift v0.98.6, built with Xcode 7.3, to address this issue.

authors: FabianMerkle antfarm awesomeswift bdash

repo: realm/realm-cocoa


text:
Can't update RealmSwift with CocoaPods

Cocoapods fails trying to install RealmSwift  10.5.2 when using pod update. It appears to be looking for RLMAccessor.h in the wrong directory.
Goals
Update to the latest RealmSwift and be able to build again in Xcode
Expected Results
Update to the RealmSwift 10.5.2  and be able to build again in Xcode
Actual Results
Here is the output from Terminal
Stack
   CocoaPods : 1.10.1
        Ruby : ruby 2.6.3p62 (2019-04-16 revision 67580) [universal.x86_64-darwin20]
    RubyGems : 3.0.3
        Host : macOS 11.2.1 (20D74)
       Xcode : 12.4 (12D4e)
         Git : git version 2.24.3 (Apple Git-128)
Ruby lib dir : /System/Library/Frameworks/Ruby.framework/Versions/2.6/usr/lib
Repositories : trunk - CDN - https://cdn.cocoapods.org/

Plugins
cocoapods-deintegrate : 1.0.4
cocoapods-plugins     : 1.0.0
cocoapods-search      : 1.0.0
cocoapods-stats       : 1.1.0
cocoapods-trunk       : 1.4.1
cocoapods-try         : 1.1.0

Podfile
# Uncomment the next line to define a global platform for your project
platform :ios, '12.4'

target 'Takedown' do
  # Comment the next line if you're not using Swift and don't want to use dynamic frameworks
  use_frameworks!

  # Pods for Takedown
    pod 'Firebase'
    pod 'Firebase/Core'
    pod 'Firebase/Messaging'
    pod 'Firebase/Auth'
    pod 'Firebase/Functions'
    pod 'Firebase/Analytics'
    pod 'Firebase/Database'
    pod 'Firebase/Storage'
    pod 'Firebase/RemoteConfig'
    pod 'Firebase/Crashlytics'
    pod 'Firebase/InAppMessaging'
    pod 'Harpy'
    pod 'SDWebImage/Core'
    pod 'FirebaseUI/Storage'
    pod 'UIImageColors'
    pod 'MBProgressHUD'
    pod 'TTOpenInAppActivity'
    pod 'YoutubePlayer-in-WKWebView'
    pod 'GoogleAPIClientForREST/YouTube'
    pod 'GoogleSignIn'
    pod 'CorePlot'
    pod 'Realm', '=10.5.2'
    pod 'RealmSwift', '=10.5.2'
    pod 'TwitterKit5'
    pod 'Purchases', '3.10.3'

    post_install do |installer|
      installer.pods_project.targets.each do |target|
        target.build_configurations.each do |config|
          config.build_settings.delete 'IPHONEOS_DEPLOYMENT_TARGET'
        end
      end
    end
end

Error
Errno::ENOENT - No such file or directory @ realpath_rec - /Users/9a/Documents/CodingProjects/Takedown3.x/Pods/Realm/Realm/RLMAccessor.h
/Library/Ruby/Gems/2.6.0/gems/cocoapods-1.10.1/lib/cocoapods/project.rb:326:in `realpath'
/Library/Ruby/Gems/2.6.0/gems/cocoapods-1.10.1/lib/cocoapods/project.rb:326:in `realpath'
/Library/Ruby/Gems/2.6.0/gems/cocoapods-1.10.1/lib/cocoapods/project.rb:326:in `reference_for_path'
/Library/Ruby/Gems/2.6.0/gems/cocoapods-1.10.1/lib/cocoapods/project.rb:269:in `add_file_reference'
/Library/Ruby/Gems/2.6.0/gems/cocoapods-1.10.1/lib/cocoapods/installer/xcode/pods_project_generator/file_references_installer.rb:224:in `block (2 levels) in add_file_accessors_paths_to_pods_group'
/Library/Ruby/Gems/2.6.0/gems/cocoapods-1.10.1/lib/cocoapods/installer/xcode/pods_project_generator/file_references_installer.rb:223:in `each'
/Library/Ruby/Gems/2.6.0/gems/cocoapods-1.10.1/lib/cocoapods/installer/xcode/pods_project_generator/file_references_installer.rb:223:in `block in add_file_accessors_paths_to_pods_group'
/Library/Ruby/Gems/2.6.0/gems/cocoapods-1.10.1/lib/cocoapods/installer/xcode/pods_project_generator/file_references_installer.rb:213:in `each'
/Library/Ruby/Gems/2.6.0/gems/cocoapods-1.10.1/lib/cocoapods/installer/xcode/pods_project_generator/file_references_installer.rb:213:in `add_file_accessors_paths_to_pods_group'
/Library/Ruby/Gems/2.6.0/gems/cocoapods-1.10.1/lib/cocoapods/installer/xcode/pods_project_generator/file_references_installer.rb:96:in `block in add_source_files_references'
/Library/Ruby/Gems/2.6.0/gems/cocoapods-1.10.1/lib/cocoapods/user_interface.rb:145:in `message'
/Library/Ruby/Gems/2.6.0/gems/cocoapods-1.10.1/lib/cocoapods/installer/xcode/pods_project_generator/file_references_installer.rb:95:in `add_source_files_references'
/Library/Ruby/Gems/2.6.0/gems/cocoapods-1.10.1/lib/cocoapods/installer/xcode/pods_project_generator/file_references_installer.rb:46:in `install!'
/Library/Ruby/Gems/2.6.0/gems/cocoapods-1.10.1/lib/cocoapods/installer/xcode/pods_project_generator.rb:102:in `block in install_file_references'
/Library/Ruby/Gems/2.6.0/gems/cocoapods-1.10.1/lib/cocoapods/user_interface.rb:145:in `message'
/Library/Ruby/Gems/2.6.0/gems/cocoapods-1.10.1/lib/cocoapods/installer/xcode/pods_project_generator.rb:100:in `install_file_references'
/Library/Ruby/Gems/2.6.0/gems/cocoapods-1.10.1/lib/cocoapods/installer/xcode/single_pods_project_generator.rb:17:in `generate!'
/Library/Ruby/Gems/2.6.0/gems/cocoapods-1.10.1/lib/cocoapods/installer.rb:312:in `block in create_and_save_projects'
/Library/Ruby/Gems/2.6.0/gems/cocoapods-1.10.1/lib/cocoapods/user_interface.rb:64:in `section'
/Library/Ruby/Gems/2.6.0/gems/cocoapods-1.10.1/lib/cocoapods/installer.rb:307:in `create_and_save_projects'
/Library/Ruby/Gems/2.6.0/gems/cocoapods-1.10.1/lib/cocoapods/installer.rb:299:in `generate_pods_project'
/Library/Ruby/Gems/2.6.0/gems/cocoapods-1.10.1/lib/cocoapods/installer.rb:178:in `integrate'
/Library/Ruby/Gems/2.6.0/gems/cocoapods-1.10.1/lib/cocoapods/installer.rb:166:in `install!'
/Library/Ruby/Gems/2.6.0/gems/cocoapods-1.10.1/lib/cocoapods/command/update.rb:63:in `run'
/Library/Ruby/Gems/2.6.0/gems/claide-1.0.3/lib/claide/command.rb:334:in `run'
/Library/Ruby/Gems/2.6.0/gems/cocoapods-1.10.1/lib/cocoapods/command.rb:52:in `run'
/Library/Ruby/Gems/2.6.0/gems/cocoapods-1.10.1/bin/pod:55:in `<top (required)>'
/usr/local/bin/pod:23:in `load'
/usr/local/bin/pod:23:in `<main>'

Steps for others to Reproduce
Don't know if it can be reproduced
Code Sample
N.A.
Version of Realm and Tooling
ProductName:	macOS
ProductVersion:	11.2.1
BuildVersion:	20D74

/Applications/Xcode.app/Contents/Developer
Xcode 12.4
Build version 12D4e

/usr/local/bin/pod
1.10.1
Realm (10.5.1)
RealmSwift (10.5.1)
Realm (= 10.5.1)
RealmSwift (= 10.5.1)

/bin/bash
GNU bash, version 3.2.57(1)-release (x86_64-apple-darwin20)

carthage not found
(not in use here)

/usr/bin/git
git version 2.24.3 (Apple Git-128)

@levelchanger can you test doing a clean pod install, instead of using pod update. First run pod deintegrate and then instead of using the update command, run pod install --verbose. If you still get an error, can you paste the logs here? so we can continue to help you.

I built a project yesterday with 10.5.2 and it worked correctly. I also updated an existing project as well. I was using macOS 10.14.6 and then on a completely different Mac, used 10.15.
Your podfile has 'Realm' - remove that and try just RealmSwift
pod 'Realm', '=10.5.2'
pod 'RealmSwift', '=10.5.2'

Our pod just uses
pod 'RealmSwift', '>= 10.0.0'

@visdyn I have a mixed ObjC/Swift project so I need both SDKs.
@dianaafanador3 I followed your instructionss and here is the output
podoutput.txt

Is this the same issue as this https://github.com/realm/realm-cocoa/issues/6943

As mentioned by @visdyn, referring to issue #6943, can you please clean your pod cache?

@visdyn, @dianaafanador3  Yes, it is the same problem and removing the pod cache and Xcode derived data fixed everything. Thank you!

authors: dianaafanador3 levelchanger visdyn


text:
chore(main): release 1.0.8

:robot: I have created a release beep boop
1.0.8 (2024-08-19)
Bug Fixes

restore exports (898b506)

This PR was generated with Release Please. See documentation.

:robot: Created releases:

v1.0.8
:sunflower:

repo: reasonai/cli


text:
An option for refmt line length

Is the max line length for refmt hardcoded at 120 chars? Or is there some option I’m missing?
In case the option doesn’t exist, I’d like to request it. I easily switch between 2 spaces and 4 spaces, but 120 cars for me is next to unreadable.

Disregard that. I was using the plugin for Jetbrains IDEs and it has its own settings for line length.

repo: reasonml/reason-cli


text:
Run Dialyzer with known problems

I have a code base with some known dialyzer issues, I would like to run dialyzer in my CI Build with some way of saying "only fail" if the number of errors is > N, or if an error not on this list shows up. Is there a way to do this?

@zkessin in 18.0 -dialyzer attribute was added that allows you to selectively ignore warnings. There is no mechanism in rebar3 itself to ignore warnings because it would be inferior to using the attribute. The attribute is not effected by line changes nor different OTP releases.

@zkessin did this answer your question? Can we close this?

Yes close it

authors: fishcakez tsloughter zkessin


text:
Top menu to filter my View.

Hi @rechsteiner,
I want to use your top menu fo filter the content on my tableView as the following image:
Is that possible to select an item on top menu and says reloadData to my table?

Hi @jeremiasdsa! Do you mean using the menu header as a standalone view and just having a single table view below instead of the paging view controllers? If so, that's unfortunately not possible at the moment. But I'm working on adding support for as we speak 🙂

authors: jeremiasdsa rechsteiner

repo: rechsteiner/Parchment


text:
Add python highlighting in the README.md

Am unsure whether the README.md is being used elsewhere for documentation generation which is not compatible with Github Flavored Markdown's code highlighting syntax. Hence, merge with caution.

Perfect - thanks!

authors: musically-ut robintw

repo: recipy/recipy


text:
Feature:  Want to add a feature to go on home page when Click on Recode Hive logo

Is your feature request related to a problem? Please describe.
When user will click on the logo so the user must route to the home page

https://recodehive.com/
redirect them to here: https://recodehive.com/github-tutorials/

repo: recodehive/awesome-github-profiles


text:
form's onSubmit callback doesn't work when the TextAnnotator parent is present

Issue
I noticed that if my component contains even a basic form and it's a descendant of React's TextAnnotator - the onSubmit callback on it doesn't work 👁
For example, I placed the following form in the example App.tsx file:
<form
  onSubmit={(e) => {
    e.preventDefault();
    console.log('SUBMIT');
  }}>
  <label>
    Name:
    <input type="text" name="name"/>
  </label>
  <input type="submit" value="Submit"/>
</form>

But clicking the submit button has no effect and I don't receive any logs 🤷🏻♂
https://github.com/recogito/text-annotator-js/assets/68850090/41ddec5b-eac9-4c51-bbac-63327cb34129
However, when I remove the wrapper - the form starts to work as expected again...
https://github.com/recogito/text-annotator-js/assets/68850090/a807aee5-7542-4f9f-99d3-dc7375b3338f

I also tried commenting out all the listeners registering in the SelectionHandler, but it didn't help 🤔

I suppose to prevent undesired click handling, it can be disabled when the click happens in the not-annotatable area
https://github.com/recogito/text-annotator-js/blob/3f22130d7342897eed3bc7c93900bdd0415730bc/packages/text-annotator/src/utils/splitAnnotatableRanges.ts#L1

repo: recogito/text-annotator-js


text:
Add tuples

TODO:

[x] TypeScript output
[x] Tooling output
[x] Docs

PR is ready for review.

repo: red-blox/zap


text:
Fix library path version on rsession.conf file

Related to: https://github.com/red-hat-data-services/notebooks/pull/149
Missed one bit here to be totally fixed...
End to end image testing shows only one folder as expected

/cherrypick release-2023b

repo: red-hat-data-services/notebooks


text:
Empty-Commit

FILL IN THE PR DESCRIPTION HERE
FIX #xxxx (link existing issues this PR will resolve)
BEFORE SUBMITTING, PLEASE READ THE CHECKLIST BELOW AND FILL IN THE DESCRIPTION ABOVE

 PR Checklist (Click to Expand)
Thank you for your contribution to vLLM! Before submitting the pull request, please ensure the PR meets the following criteria. This helps vLLM maintain the code quality and improve the efficiency of the review process.
PR Title and Classification
Only specific types of PRs will be reviewed. The PR title is prefixed appropriately to indicate the type of change. Please use one of the following:

[Bugfix] for bug fixes.
[CI/Build] for build or continuous integration improvements.
[Doc] for documentation fixes and improvements.
[Model] for adding a new model or improving an existing model. Model name should appear in the title.
[Frontend] For changes on the vLLM frontend (e.g., OpenAI API server, LLM class, etc.)
[Kernel] for changes affecting CUDA kernels or other compute kernels.
[Core] for changes in the core vLLM logic (e.g., LLMEngine, AsyncLLMEngine, Scheduler, etc.)
[Hardware][Vendor] for hardware-specific changes. Vendor name should appear in the prefix (e.g., [Hardware][AMD]).
[Misc] for PRs that do not fit the above categories. Please use this sparingly.

Note: If the PR spans more than one category, please include all relevant prefixes.
Code Quality
The PR need to meet the following code quality standards:

We adhere to Google Python style guide and Google C++ style guide.
Pass all linter checks. Please use format.sh to format your code.
The code need to be well-documented to ensure future contributors can easily understand the code.
Include sufficient tests to ensure the project to stay correct and robust. This includes both unit tests and integration tests.
Please add documentation to docs/source/ if the PR modifies the user-facing behaviors of vLLM. It helps vLLM user understand and utilize the new features or changes.

Notes for Large Changes
Please keep the changes as concise as possible. For major architectural changes (>500 LOC excluding kernel/data/config/test), we would expect a GitHub issue (RFC) discussing the technical design and justification. Otherwise, we will tag it with rfc-required and might not go through the PR.
What to Expect for the Reviews
The goal of the vLLM team is to be a transparent reviewing machine. We would like to make the review process transparent and efficient and make sure no contributor feel confused or frustrated. However, the vLLM team is small, so we need to prioritize some PRs over others. Here is what you can expect from the review process:

 After the PR is submitted, the PR will be assigned to a reviewer. Every reviewer will pick up the PRs based on their expertise and availability.
 After the PR is assigned, the reviewer will provide status update every 2-3 days. If the PR is not reviewed within 7 days, please feel free to ping the reviewer or the vLLM team.
 After the review, the reviewer will put an  action-required label on the PR if there are changes required. The contributor should address the comments and ping the reviewer to re-review the PR.
 Please respond to all comments within a reasonable time frame. If a comment isn't clear or you disagree with a suggestion, feel free to ask for clarification or discuss the suggestion.

Thank You
 Finally, thank you for taking the time to read these guidelines and for your interest in contributing to vLLM. Your contributions make vLLM a great tool for everyone!

/ok-to-test

authors: Xaenalt heyselbi

repo: red-hat-data-services/vllm


text:
Add design doc

Do the thing we talked about in #143

Sweet.  There are probably a number of design principles involved in react-server that aren't covered by this doc, but I'm glad to at least have these there. :)
👍

@gigabo if you know of any, let me know; I'm more than happy to add them to the doc before merging/announcing.

/me has no principles.

authors: doug-wade gigabo

repo: redfin/react-server


text:
Set cookie whenever request has Set-Cookie header

As per https://stackoverflow.com/a/10359837/2831606, if we are not using persistent cookies (allow_persistent_cookies=false) then CouchDB can change/refresh our cookie during any request. If this happens, we should update the locally stored cookie. The code to set the cookie would look something like this

I can access set-cookie header in the response in EnhancedRequest.prototype._request but not sure how to access RequestWrapper.prototype.setCookie from there.

Figured this out. Will raise PR.

authors: layanto redgeoff

repo: redgeoff/slouch


text:
Appstudio update test-component-pac-wrgu

Pipelines as Code configuration proposal
To start the PipelineRun, add a new comment with content /ok-to-test
For more detailed information about running a PipelineRun, please refer to Pipelines as Code documentation Running the PipelineRun
To customize the proposed PipelineRuns after merge, please refer to Build Pipeline customization

Pipelines as Code CI/test-component-pac-wrgu-on-pull-request has successfully validated your commit.

StatusDurationName

✅ Succeeded
5 seconds
init

✅ Succeeded
19 seconds
clone-repository

✅ Succeeded
1 minute
build-container

✅ Succeeded
26 seconds
inspect-image

✅ Succeeded
26 seconds
deprecated-base-image-check

✅ Succeeded
59 seconds
clamav-scan

✅ Succeeded
2 minutes
clair-scan

✅ Succeeded
34 seconds
sbom-json-check

✅ Succeeded
9 seconds
label-check

✅ Succeeded
5 seconds
show-sbom

✅ Succeeded
5 seconds
show-summary

Pipelines as Code CI/test-component-pac-wrgu-on-pull-request has successfully validated your commit.

StatusDurationName

✅ Succeeded
7 seconds
init

✅ Succeeded
12 seconds
clone-repository

✅ Succeeded
30 seconds
build-container

✅ Succeeded
14 seconds
deprecated-base-image-check

✅ Succeeded
14 seconds
inspect-image

✅ Succeeded
9 seconds
clair-scan

✅ Succeeded
35 seconds
clamav-scan

✅ Succeeded
8 seconds
sbom-json-check

✅ Succeeded
14 seconds
label-check

✅ Succeeded
6 seconds
show-sbom

✅ Succeeded
9 seconds
show-summary


text:
Appstudio update test-component-pac-wful

Pipelines as Code configuration proposal
To start the PipelineRun, add a new comment with content /ok-to-test
For more detailed information about running a PipelineRun, please refer to Pipelines as Code documentation Running the PipelineRun
To customize the proposed PipelineRuns after merge, please refer to Build Pipeline customization

Pipelines as Code CI/test-component-pac-wful-on-pull-request has successfully validated your commit.

StatusDurationName

✅ Succeeded
16 seconds
init

✅ Succeeded
17 seconds
clone-repository

✅ Succeeded
1 minute
build-container

✅ Succeeded
42 seconds
inspect-image

✅ Succeeded
45 seconds
deprecated-base-image-check

✅ Succeeded
3 minutes
clair-scan

✅ Succeeded
1 minute
clamav-scan

✅ Succeeded
21 seconds
sbom-json-check

✅ Succeeded
21 seconds
label-check

✅ Succeeded
7 seconds
show-summary

✅ Succeeded
6 seconds
show-sbom

Pipelines as Code CI/test-component-pac-wful-on-pull-request has successfully validated your commit.

StatusDurationName

✅ Succeeded
6 seconds
init

✅ Succeeded
23 seconds
clone-repository

✅ Succeeded
43 seconds
build-container

✅ Succeeded
24 seconds
inspect-image

✅ Succeeded
24 seconds
deprecated-base-image-check

✅ Succeeded
11 seconds
clair-scan

✅ Succeeded
53 seconds
clamav-scan

✅ Succeeded
10 seconds
sbom-json-check

✅ Succeeded
18 seconds
label-check

✅ Succeeded
7 seconds
show-summary

✅ Succeeded
6 seconds
show-sbom


text:
Disable rekor integration

This aligns with the current plan to not have Rekor enabled initially, but introduce it post-mvp phase.
Signed-off-by: Luiz Carvalho lucarval@redhat.com

@redhat-appstudio/enterprise-contract ptal

I guess e2e tests need an update first...
[INFO] Cloning tests from branch pre-kcp repository https://github.com/redhat-appstudio/e2e-tests.git
Cloning into '/go/src/github.com/redhat-appstudio/infra-deployments/tmp/e2e-tests'...
fatal: Remote branch pre-kcp not found in upstream origin
Unexpected end of command stream
[ERROR] Job failed with code 128.

/approve
/lgtm

e2e test failures seem to be unrelated.

So https://github.com/redhat-appstudio/infra-deployments/blob/main/hack/preview.sh#L78-L80 should be removed as well?

So https://github.com/redhat-appstudio/infra-deployments/blob/main/hack/preview.sh#L78-L80 should be removed as well?

I'd rather not as part of this PR. Rekor is something we still want, just not right now. There's still value in setting transparency.url because it allows us to simply toggle transparency.enabled to use Rekor which is helpful in a dev environment.
There's more work that needs to be done around Rekor. This PR is the bare minimum needed right now.

/lgtm
(re-adding label after rebase)

authors: Michkov lcarva zregvart

repo: redhat-appstudio/infra-deployments


text:
[WIP] Register and Unregister backend api endpoint

Proposal doc: https://docs.google.com/document/d/13M5WjmIXwVsExNVK_xk4YINFqohVvZw4gwLAZTPdq-k/edit?usp=sharing

@adambkaplan This pr is for actual implementation of the proxy with kube-rbac-proxy secured endpoints. As per my understanding I have added the --upstream and --ignore-path but its working as expected. I have also tried to change the --upstream to the server where current proxy is listening to. But that also doesn't work. I am still able to add backends without rbac authentication. In other examples I have seen this --bind flag. Is it what I am missing 😕
Could you please have a look and let me know what I am missing.
auth-proxy-client-clusterrolebinding which needs to be added to infra-repo as per my understanding:
apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRoleBinding
metadata:
  name: sprayproxy-api-reader-rolebing
roleRef:
  apiGroup: rbac.authorization.k8s.io
  kind: ClusterRole
  name: sprayproxy-api-reader
subjects:
  - kind: ServiceAccount
    name: sprayproxy
    namespace: sprayproxy

Updating here so that you can identify what am I missing.

ok I think I need to create ServiceMonitor as well

These endpoints should not be added if enableDynamicBackends is false. Let gin take care of sending an appropriate response.

@adambkaplan do we want to completely disable this endpoint for production or staging. Or we can have this endpoint accessible for all and for production and dev you will get some response like
statuscode 406, "Not registered, Please set enable-dynamic-backends flag."

when you are trying to access it. WDYT?

@adambkaplan I have tested the kube-rbac-proxy behaviour for both the ports 8080 and 6000 with sidecars on secure-listen-port 9443 and 8443.Its working as expected. This PR is ready for review now. cc_ @xinredhat @rhopp

@enarha @sayan-biswas This is long pending PR, needs your help on reviewing it.

@enarha I have pushed the requested change in commit . Let me know if it looks good, I will squash the commit after your green check.

repo: redhat-appstudio/sprayproxy


text:
PDC: Require a tarball and omit chart-uri from report

Added code for provider control delivery:

require report is created using a tarball from which a package digest can be calculated.
set chart-uri in report to "N/A"

Existing tests extended to check both scenarios.
Readme doc updated.
https://issues.redhat.com/browse/HELM-352

/lgtm

authors: Kartikey-star mmulholla

repo: redhat-certification/chart-verifier


text:
Add ServiceMonitor to allow Metrics to be sent to Prometheus

Given the operator already exposes a metrics endpoint through a service, I recommend creating a ServiceMonitor to sink the metrics to Prometheus.
This will eliminate the need for manual intervention to accomplish this task.

should this be added to the helm chart or created by the operator when it starts?

It should not matter where it is added. It however makes sense to create the ServiceMonitor after the metrics service.
An example would appear as shown below.
apiVersion: monitoring.coreos.com/v1
kind: ServiceMonitor
metadata:
  name: cert-utils-service-monitor
  labels:
    role: metrics-sink
spec:
  selector:
    matchLabels:
      name: cert-utils-operator
  endpoints:
  - port: http-metrics

This should have been done in helm with a default of not installing it to follow other community standards that have already been set on this. The code is making an assumption that you are using Prometheus in your k8s cluster, if you are not, the code fails and is unusable. If you are going to do this in code even though this is largely done in the helm chart with a flag, it should at minimum be configurable.

I agree.
@trevorbox would you be able to fix this?

authors: OchiengEd raffaelespazzoli silverbp

repo: redhat-cop/cert-utils-operator


text:
Fix sealed secrets example url

Remove redundant "catalog" word in the kustomization file example
fix #120

Thanks for the fix!

authors: natifridman pittar

repo: redhat-cop/gitops-catalog


text:
Please add me as a member flow

A few people have messaged me asking why when they request to be added to the org, the following happens:

they get an email saying you've been added
a few hours later, they get an email saying they've been deleted
then a few more, once the PR is merged, they have access

I presume this is because of how the automation is running, i.e.: to test it, its executed for real.
Can this be tweaked? or if not, at least called out/documented to stop confusion?

Review request:
cc: @redhat-cop/container-cop-core

@garethahealy the CoP SRE team made a few adjustments recently. Please let us know if the end user experience has improved as a result

repo: redhat-cop/org


text:
JBDS-4119 Uninstaller - remove files with too long path

In case some files cant get deleted due to too long path, use robocopy (available in Win 7+) to purge the directories.

released to master, thanks!


text:
[WIP]: Issues #1429 and #1440

[WIP] Issues #1429 (Allow to "mute" the output of the Kafka topic creation command) and #1440 (Artifact rules enable --config should only propose values for specific rule) are addressed in this commit.

@gowriswarupk please check why go build is failing.
run
make lint
make format
to be sure

Needs rebase

authors: gowriswarupk rkpattnaik780 wtrocki

repo: redhat-developer/app-services-cli


text:
odo project list does not return just created project

[kind/bug]

What versions of software are you using?

Operating System: Win10 Pro
Output of odo version:

odo v0.0.19 (61f278a1)

Server: https://172.17.247.235:8443
OpenShift: v3.9.31
Kubernetes: v1.9.1+a0ce1bc657

How did you run odo exactly?
odo project create test1 && odo project list
Actual behavior
 ✓  New project created and now using project : test1
ACTIVE     NAME
           myproject

Expected behavior
 ✓  New project created and now using project : test1
ACTIVE     NAME
           myproject
           test1

Any logs, error output, etc?
Reproduced with 0.0.18, not with 0.0.17

works for me though
 $ odo version
odo v0.0.19 (HEAD)

Server: https://192.168.42.67:8443
Kubernetes: v1.11.0+d4cacc0

$ odo project create test1
 ✓  New project created and now using project : test1

$ odo project list
ACTIVE     NAME
           myproject
*          test1

I think odo project create test1 takes some seconds to settle but you were running odo project create test1 && odo project list where odo project list don't give time to odo project create to settle.

this seems to be worked also:
odo project create test1 && sleep 1 && odo project list

I was able to reproduce this.
This will have the same root cause as https://github.com/redhat-developer/odo/issues/1329.

authors: jeffmaury kadel surajnarwade

repo: redhat-developer/odo


text:
Errors out when passing in '.' as a name into url create

/kind bug

What versions of software are you using?
Operating System: Linux
Output of odo version: odo v2.5.0 (724f16e68)
How did you run odo exactly?
I'm able to pass in the name "." to url create despite it being obviously invalid.
~/odo-quickstart/frontend  main ✗                                                                                119d ◒
▶ odo url create . --port 3000 --host k8s.land
 ✓  URL . created for component: frontend

To apply the URL configuration changes, please use `odo push`

~/odo-quickstart/frontend  main ✗                                                                                119d ◒
▶ odo url list
 ✗  failed to parse the devfile devfile.yaml, with error: failed to populateAndParseDevfile: invalid devfile schema. errors :
- components.0.container.endpoints.2.name: Does not match pattern '^[a-z0-9]([-a-z0-9]*[a-z0-9])?$'

Actual behavior
Errors out
Expected behavior
Validation error / not a valid name for a URL
Any logs, error output, etc?
See above

/triage unresolved
This can't work. you are saying that the URL/endpoint should be named . which is an invalid name.
I guess that the reason you were trying this was to achieve https://github.com/redhat-developer/odo/issues/5383. #5383 is a real problem, but naming URL . is not a proper solution for it
/close

Ah no, that's unrelated to #5383 . This issue is that there is no character / variable validation and odo should not accept . as an input.

authors: cdrage kadel


text:
odo telemetry prompt can interfere with bash commands

/kind bug
What versions of software are you using?
Operating System: Linux
Output of odo version: odo v3.15.0 (10b5e8a8f)
How did you run odo exactly?
With the goal of getting the current odo version:
odo version --client | grep -Eo 'v?[0-9]+\.[0-9]+\.[0-9]+'

(on first run, before seeing telemetry prompt)
Actual behavior
The command hangs indefinitely and cannot be cancelled (i.e. ctrl+c does not work).
Expected behavior
Either odo should prompt for telemetry on stderr (instead of stdout) so that users see the prompt in these cases, or it should avoid prompting when output is redirected to a file/pipe.
Any logs, error output, etc?
Can be reproduced with the following Dockerfile
FROM registry.access.redhat.com/ubi8-minimal:8.8-860

RUN microdnf install -y curl \
    && curl -L https://developers.redhat.com/content-gateway/rest/mirror/pub/openshift-v4/clients/odo/v3.15.0/odo-linux-amd64 -o /usr/local/bin/odo \
    && chmod a+x /usr/local/bin/odo \
    && microdnf -y clean all

RUN echo -e '#!/bin/bash \n\
             odo version --client | grep -Eo "v?[0-9]+\.[0-9]+\.[0-9]+" \n\
             exec "$@"' > /entrypoint.sh \
    && chmod a+x /entrypoint.sh

ENTRYPOINT [ "/entrypoint.sh" ]

If I build an image from this Dockerfile, then

If I run podman run <image> it prints odo's version
If I run podman run -it --rm <image> /bin/bash, it hangs indefinitely and must be podman killed

More background
The Web Terminal Operator includes odo as part of its built-in tooling. In order to be able to list the software and versions installed, the web-terminal-tooling container generates a "installed-versions.txt" file at startup using the above command, which can hang if e.g. it is run from an interactive prompt.
As a workaround, we just close stdin before calling the script, which avoids the issue.

/area telemetry
/remove-status needs-triage
Hi @amisevsk,
Thanks for reporting this issue.
While I agree it makes sense for odo to avoid prompting when the output is piped or redirected to a file, I'd like to suggest two more things:

It is possible to disable the consent prompt via the ODO_TRACKING_CONSENT environment variable. See https://odo.dev/docs/overview/configure#environment-variables-controlling-odo-behavior
Most of the odo commands expose a JSON output to make it easier for other programs to consume the output; so I think using odo version --client -o json might be simpler to use. However, I guess that would still prompt for telemetry consent. So using the ODO_TRACKING_CONSENT would still be needed.

Would that work for you?


text:
Adds option to trigger manual sync, updates UI of odo dev

What type of PR is this:

/kind feature
What does this PR do / why we need it:
This PR:

Adds the ability to press "p" to "push" changes manually / syncing
Updates the general UI / flow of odo dev

Which issue(s) this PR fixes:

Fixes https://github.com/redhat-developer/odo/issues/5634
PR acceptance criteria:

[ ] Unit test

[ ] Integration test

[ ] Documentation

How to test changes / Special notes to the reviewer:

/retest

Working on passing the tests! 💯

/retest


text:
Don't fail on ConfigMap

Addresses https://github.com/redhat-documentation/vale-at-red-hat/issues/326
This rule catches Camel and Pascal case terms in body text and suggests wrapping them in backticks mark up.

Won't pass until https://github.com/redhat-documentation/vale-at-red-hat/pull/330 gets merged.

I've totally reworked this, dropping all the Pascal case changes. This is more straightforward.

repo: redhat-documentation/vale-at-red-hat


text:
[gluster] when using glusterFS, set it to default storage class

If we're going to setup GlusterFS on the cluster, then we might as well make it the default storage backend (since it'll be the only StorageClass on the cluster likely).
We can set it to be the default storage class with the following command post-deploy:
kubectl patch storageclass gluster -p '{"metadata": {"annotations":{"storageclass.kubernetes.io/is-default-class":"true"}}}'

Actually, I'm going to close this, because there are several situations where you'd actually just want to revert this. For example, in Prometheus Operator, it tells you to drop the default label on your storage and specify what you want directly. Just going to close this out as you don't really need this.

repo: redhat-nfvpe/kube-ansible


text:
operator t8c-certified (42.53.0-beta.1)

operator t8c-certified (42.53.0-beta.1)

/pipeline restart operator-hosted-pipeline


text:
operator [O] gitlab-operator-kubernetes (0.17.0)

Thanks for submitting your Operator. Please check the below list before you create your Pull Request.
New Submissions

[ ] Are you familiar with our contribution guidelines?
[ ] Have you packaged and deployed your Operator for Operator Framework?
[ ] Have you tested your Operator with all Custom Resource Definitions?
[ ] Have you tested your Operator in all supported installation modes?
[ ] Have you considered whether you want to use semantic versioning order?
[ ] Is your submission signed?
[ ] Is operator icon set?

Updates to existing Operators

[ ] Did you create a ci.yaml file according to the update instructions?
[ ] Is your new CSV pointing to the previous version with the replaces property if you chose replaces-mode via the updateGraph property in ci.yaml?
[ ] Is your new CSV referenced in the appropriate channel defined in the package.yaml or annotations.yaml ?
[ ] Have you tested an update to your Operator when deployed via OLM?
[ ] Is your submission signed?

Your submission should not

[ ] Modify more than one operator
[ ] Modify an Operator you don't own
[ ] Rename an operator - please remove and add with a different name instead
[ ] Modify any files outside the above mentioned folders
[ ] Contain more than one commit. Please squash your commits.

Operator Description must contain (in order)

[ ] Description of the managed Application and where to find more information
[ ] Features and capabilities of your Operator and how to use it
[ ] Any manual steps about potential pre-requisites for using your Operator

Operator Metadata should contain

[ ] Human readable name and 1-liner description about your Operator
[ ] Valid category name1
[ ] One of the pre-defined capability levels2
[ ] Links to the maintainer, source code and documentation
[ ] Example templates for all Custom Resource Definitions intended to be used
[ ] A quadratic logo

Remember that you can preview your CSV here.
--
1 If you feel your Operator does not fit any of the pre-defined categories, file an issue against this repo and explain your need
2 For more information see here

Closing, this was the wrong version.


text:
add os_domain_name #335

Added support for v3 endpoint and os_domain_name in openstack configuration.
This works smoothly on my RHOSP9 + OCP 3.4

Is there a reference that shows that openshift-ansible will accept this new parameter?

@markllama  I found the following. Let me know if it's ok or if I should reformat something.
Thx++Peace,
R.
https://github.com/openshift/openshift-docs/blob/be87faceca521d52347d33e49b4ba6b6a2a1da26/install_config/configuring_openstack.adoc
Added in
https://github.com/openshift/openshift-docs/pull/2967/files#diff-21f3ad43dcaf3f821f666e867bcf3221R63

todo: working to disable os_domain when using v2

Thanks!

authors: ioggstream markllama tomassedovic

repo: redhat-openstack/openshift-on-openstack


text:
🛑 Redhcp is down

In 08b510b, Redhcp (www.redhcp.work/) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Redhcp is back up in 0053429 after 25 minutes.

repo: redhcp/status-page


text:
Implement more idiomatic query and index creation with new version of redis-py

This PR updates the code to use the inteface as defined in the following redis-py PR:
https://github.com/redis/redis-py/pull/2957
Once this is merged and released, I'll need to update requirements.txt on this branch to pick up the latest redis-py release before merging it.  Until then, merging is blocked.
This closes #1

This needs redis-py 5.1.0 to be released.  Draft release here: https://github.com/redis/redis-py/releases/tag/untagged-addc0fc2d47b1bd864b9


text:
Update createArray to take size_t

This makes createArray consistent with createString, which also takes size_t. Bounds-check and unit tests are updated to allow up to min(SIZE_MAX,LLONG_MAX). Changelog is updated to mention this API break.
Also included is a missed Changelog entry mentioning the integer parsing changes.

Good catch on 300fc01.  I went ahead and cherry-picked that into master.
The breaking change is trickier but it would appear that the main downstream repos hiredis-rb, hiredis-py, and hiredis-node all pin to specific versions.
I figure we leave this up for a few days and then go ahead and get it merged if there are no objections.

authors: justinbrewer michael-grunder

repo: redis/hiredis


text:
Add support for the latest Pydantic versions

The current redis-om-python's dependency constraint for Pydantic version is pydantic = ">=1.10.2,<2.1.0".
ATM, the latest Pydantic version is v2.6.1. Its development pace is quite fast. Within one year, lots of features are added and bugs are fixed.
Could you please add support for a higher version of Pydantic? Then our projects don't need to hold onto the lower versions.

I went through all chats in the pull requests and issues. Noticed there are already a few PRs updating the Pydantic's version.
They are still waiting for approval for quite a long time. We are in a hurry to migrate to the latest Pydantic version in our project, so I created a fork and updated the version to pydantic = ">=1.10.2,<3.0.0".  I tested it in my own environments, it is working fine so far. For people in the same situation, feel free to use it:
# put this in your package management file (eg, `pyproject.toml`)
redis-om = {git = "https://github.com/yanbo-huang/redis-om-python.git"}

what is the current status on this? @slorello89 @uglide

Fixed by #597

Thanks, @gaby!

authors: banker gaby prutheus yanbo-huang

repo: redis/redis-om-python


text:
Can't execute CLUSTER_NODES,which version solved?

@mrniko hello,i had view some close issues,but i dont know which version  really solved this problem.
redis on port 7001 is master
redisson version:2.8.2
the following is my error log
18-12-22.00:10:55.177 [redisson-netty-4-5] ERROR ClusterConnectionManager  - Can't execute CLUSTER_NODES with /xxx.xxx.xxx.xxx:7001
java.lang.IllegalArgumentException: java.net.MalformedURLException: unknown protocol: redis
	at org.redisson.misc.URLBuilder.create(URLBuilder.java:125) ~[redisson-2.8.2.jar:na]

@hisenyuan Please can I ask you to try it again with a later version of Redisson?

ok,thank you for your reply. Which version do you recommend?

@hisenyuan Please can I ask you to try it again with a later version of Redisson?

ok,thank you for your reply. Which version do you recommend?

I would always suggestion the latest version but you should read the release note and make sure you have done all the necessary tasks to ensure your application is compatible.

I am using the latest version of redisson and still have this problem. 3.11.1 and 3.11.2 are the latest

fixed

authors: hisenyuan jackygurui mrniko wenzhisheng

repo: redisson/redisson


text:
How to Perform HealthCheck for RedissonClient

Can you please provide way to implement healthcheck with RedissonClient

You can use org.redisson.api.RedissonClient.getRedisNodes().pingAll() method

authors: ankitaCogno mrniko


text:
Expire RRateLimiter

I want to delete RRateLimiter hash from redis, post rate interval is over. e.g. I set rate interval of 10 sec then hash must be removed post 10 sec.
Is there any built in api for this functinality exists?

You need to use expire() method

Thanks.
Actually we are using redisson 3.12.x version, hence I was unable to call expire() method. However as workaround I've tried to expire using RMap  with expiry value of "rate interval" as below
RRateLimiter limiter = redis.getRateLimiter(name);
RMap<Object, Object> keyMap = redis.getMap(name);
keyMap.expire(10, TimeUnit.SECONDS); // 10 sec is rate interval of limitter


text:
In read-write separation mode, how to ensure that the data read is the latest?

Hello everyone, does redission support the scenario of writing first and then reading data immediately in the same thread like Apache ShardingSphere, forcing the data to be read from the main library? This is done to solve the problem that the delay in master-slave replication data causes the read operation to obtain data that is not the latest.

you can do it with RBucket.getAndSet() method

authors: liuxinwen mrniko


text:
example/widgets.rs: Executable size jump from 2MB to 17MB

I noticed that the executable size for cargo build --example widgets --release jumps

from ~2MB for 0.3.1-alpha1 with rustc 1.37
to ~17MB for 5cb3649 (latest commit 20 days ago) with rustc 1.41

Not sure if this means anything, but I thought I'd bring it up anyway just in case it's important.

I've noticed the same. But it's not a matter of the Rust version and the increase seemed to happen much earlier.

.rodata section of the release executable jumps from 500Kb to 12Mb in a9653954fed7275328bc8e893c3465506154571e (this commit embeds ~12Mb font file OpenMoji-Color.ttf into theme crate)

Thank you for your research. OpenMoji is not yet used in OrbTk, I will remove it.

Remove openmoij font.

repo: redox-os/orbtk


text:
Chart version 5.6.x introduces issues with deployment via helm operator

What happened?
Tried to upgrade from version 5.5.4 to version 5.6.21. I got the following error in helm operator:
ts=2023-10-19T10:04:55.193374123Z caller=release.go:79 component=release release=redpanda-aceph targetNamespace=redpanda-1 resource=redpanda-1:helmrelease/redpanda-aceph helmVersion=v3 info="starting sync run"
ts=2023-10-19T10:04:55.396299836Z caller=release.go:353 component=release release=redpanda-aceph targetNamespace=redpanda-1 resource=redpanda-1:helmrelease/redpanda-aceph helmVersion=v3 info="running upgrade" action=upgrade
ts=2023-10-19T10:04:55.454822716Z caller=helm.go:69 component=helm version=v3 info="preparing upgrade for redpanda-aceph" targetNamespace=redpanda-1 release=redpanda-aceph
ts=2023-10-19T10:04:55.530582727Z caller=helm.go:69 component=helm version=v3 info="resetting values to the chart's original version" targetNamespace=redpanda-1 release=redpanda-aceph
ts=2023-10-19T10:04:56.046419772Z caller=release.go:357 component=release release=redpanda-aceph targetNamespace=redpanda-1 resource=redpanda-1:helmrelease/redpanda-aceph helmVersion=v3 error="upgrade failed: template: redpanda/templates/post-upgrade.yaml:73:40: executing \"redpanda/templates/post-upgrade.yaml\" at <eq (floor $value) $value>: error calling eq: incompatible types for comparison" action=upgrade

What did you expect to happen?
Upgrade succeeds. I've also tried to completely remove the HelmRelease object and deploy from scratch but fails with the same issue.
How can we reproduce it (as minimally and precisely as possible)?. Please include values file.
Try to deploy redpanda with helm operator.
Anything else we need to know?
No response
Which are the affected charts?
Redpanda
Chart Version(s)
5.6.21
Cloud provider

This is fixed in 5.6..36+

authors: aneagoe joejulian

repo: redpanda-data/helm-charts


text:
internal: Rename iterator._XXX to more explicit names.

From #1399

Rename _isRunning to _isTaskRunning (same for _isCancelled and _isAborted)
Rename _result to _taskResult; rename _error to _taskError.

This looks good, I'm only thinking that maybe keeping those on iterator is somewhat leaky. It feels wrong to mutate it. Maybe we could try to keep those flags on the task's instance instead? It's our custom object and makes more sense to keep it there. WDYT?

I came up with several options:
Option-1
Like in this PR now, rename _isRunning to _isTaskRunning (same for _isCancelled and _isAborted)
rename _result to _taskResult; rename _error to _taskError.

pros: make the names more explicit.

cons: keeping those on iterator is somewhat leaky

Option-2
Convert task.isRunning / task.isCancelled ... from methods to properties, and use these properties to track the running status of the task. I have tried this option in my little-saga, and it works pretty well (passed almost all of redux-saga test cases).

pros: It is simple, intuitive and explicit.
cons: It introduces breaking changes since that the API doc already says task.isRunning ... are methods.

Option-3
Like in #1404 , using properties and methods at the same time. Using properties task._isRunning / task_.isCancelled ...  to track running status, while still provides task.isRunning() / task.isCancelled().

pros: get rid of iterator._xxx
cons: having methods and properties at the same time seems unnecessary

My opinion
I think Task.isRunning() / Task.isCancelled()... are not popular APIs and we are toward version 1.0, so option-2 is the best option. How do you think ?

I'm not against introducing breaking changes for this, so option 2 is fine. It has additional drawback though - properties might imply that they can be changed and those should really be read-only outside of redux-saga code. So I'm kinda leaning towards option 3 at the moment.

I have tried this option in my little-saga

That is really cool! What are your goals for this project? You might be also interested in this project.

@restrry WDYT about this?

little-saga is a slim version of redux-saga. I made some breaking change (including using task.isRunning / task.isCancelled ... to track running status) to keep little-saga as simple as possible. And I wrote an article in Chinese to help people understand the internals of redux-saga/little-saga.

properties might imply that they can be changed and those should really be read-only outside of redux-saga code

We can document that task.isRunning / task.isCancelled is read-only and add readonly modifier in typescript declaration file. On the other hand, I think most users will use join/cancel/cancelled effects
rather than using these APIs to inspect the running status. These APIs could be think as advanced APIs and maybe we can trust these advanced APIs users 😆 .
@Andarist If you think option-2 is okay, I am glad to make a PR. Or if you think option-3 is better, I can reopen #1404.

👍 for option-3.
pros: no breaking changes. and if we need add some addition logic (in future) for getting/setting those flags, we already have isolation from external api.
the only remark - does it make sense to rename mainTask.isRunning -> mainTask._isRunning to have  make them more consistent?

So let's pick option-3.   mainTask._isRunning is very reasonable though mainTask is private in proc(). I will add commits in #1475.

authors: Andarist restrry shinima

repo: redux-saga/redux-saga


text:
The type of createSelector in ts4.1 doesn't support memoizeOptions as the last parameter

Hi,
I got TS2769: No overload matches this call when I followed this example in docs.
// Selector behavior can be customized
const customizedSelector = createSelector(
  state => state.a,
  state => state.b,
  (a, b) => a + b,
  {
    // New in 4.1: Pass options through to the built-in `defaultMemoize` function
    memoizeOptions: {
      equalityCheck: (a, b) => a === b,
      maxSize: 10,
      resultEqualityCheck: shallowEqual
    }
  }
)

The type defined in this file ./src/typesVersions/ts4.1/index.d.ts doesn't support memoizeOptions
Am I missing something or does it need to be fixed?
Thank you

What version of TS are you using? Can you put together a project that shows this happening?

Hi @markerikson,
Thank you for the quick reply. Yes, we are using typescript 4.1.6.  I'll see if we can use the newer version of TS.

authors: Yupeng-li markerikson

repo: reduxjs/reselect


text:
Allow use inside describe!

First of all, thanks for this awesome library!
It would be great if use works directly inside describe! so I don't have to import stuff (or use super::super::) in every it block.
Test code with commentary inline:
#![feature(phase)]

#[phase(plugin)]
extern crate stainless;

const FOO: uint = 1;

#[cfg(test)]
mod test {
    use super::FOO;

    // This compiles fine
    #[test]
    fn works() {
        assert_eq!(FOO, 1)
    }

    describe! foo {
        // This fails with
        // error: Expected one of: `before_each, after_each, before, after, it,
        // bench, failing, describe`, but found: `use`
        // use super::FOO;

        it "equals 1" {
            // This works, but doesn't look too good.
            use super::super::FOO;
            assert_eq!(FOO, 1)
        }
    }
}

Thanks, I was also confused by this so I proposed this note in the readme: #36

authors: thijsc utkarshkukreti

repo: reem/stainless


text:
Sometimes the image json posted is "{}"

I want to make the user upload multiple files. So I'm using cocoon.
https://github.com/nathanvda/cocoon
The problem is that sometimes then JSON that should look like this:
{"id":"7c0f42f667737c5b49694fb1ff220c3209b70ba968c08bc7105001aedfa","filename":"5.png","content_type":"image/png","size":4101555}
Becomes:
{}
I have verified that the file is correctly uploaded by showing a preview of the image. Is there a way to "trigger" the transfer from the JS? I know this is a bug but as a temporary solution. I will now search for a solution of my own and post it here if I find it. :smile_cat:

The root of the problem is definitely that in cocoon the JS doesn't generate a new "data-reference" attribute. So when it refers to the hidden field then it's refering just to the last element:
https://github.com/refile/refile/blob/master/app/assets/javascripts/refile.js#L29-L30
Because every element is the same.
I don't know how to "solve" this. But I probably do some editing when adding a new nested attribute in Cocoon.
Maybe change it to search for siblings or search in parent of the file input field would solve this? Hmmmm...
Do you really need the data-reference? Couldn't you just refer to previous hidden input sibling?
Lot's of idea and I don't know what is the ideal.

This seems to work. If you replace:
https://github.com/refile/refile/blob/master/app/assets/javascripts/refile.js#L29-L30
With:
var metadataField = input.previousElementSibling;
I really don't know if that's the "correct" solution because it seems a bit more brittle if you want to customize it a bit. The data-reference seems like a much more robust solution but it's a complicated one.

No, that doesn't work. When Rails encounters a form error it will wrap the field in an error div, getting the previous sibling is not a reliable way to get the hidden field, unfortunately. Neither is the name, since the same form could occur multiple times on the same page.

The data-reference thing is a pretty bizarre hack I'll admit, but I can't think of any other way to implement this that isn't completely unreliable. For strictly valid markup, the id field would work, but I suspect that it's going to cause lots of problems, because people are not diligent about keeping their markup valid, and it's very easy to generate duplicated ids.
I suspect that running Refile inside Cocoon is a somewhat edge use case, so I'd rather prefer to keep the better behaviour for the majority case.
Do you have any other ideas how this could be fixed?

if we pretend we only need to solve this for cocoon... then adding our own data-reference can be done during
$(document).on('cocoon:after-insert', function(e, insertedItem) {
  // do things
});

Closing this. I don't think we can solve this in a better way than we currently do.

authors: choonkeat jnicklas lephyrius

repo: refile/refile


text:
rgh-feature-descriptions only works when opened in a new page

Description
Navigate to the following file (e.g. via Go to file) vs opening it in a new tab, rgh-feature-descriptions only works for the latter
How to replicate the issue + URL
https://github.com/refined-github/refined-github/blob/main/source/features/linkify-code.tsx
Extension version
23.4.10
Browser(s) used
Chrome

😅 Well this is probably the AJAX related one
download-file-button is also missing sometimes

I think you're using the sidebar to change files, which basically isn't supported by our turbo: event listener, for which we already have an issue open.

Duplicate of https://github.com/refined-github/refined-github/issues/6554

authors: fregante kidonng

repo: refined-github/refined-github


text:
Update App Store icon

@sindresorhus does a palette inversion quench your refresh thirst? 😃

Before
After

Making the icon completely flat white could also work, similar style to GitHub Desktop’s:

Not a big fan. The gradient clashes with the artwork.

(inner shadow would be better probably)

Before
After

Inner shadow

Before
After

I'm fine with just keeping the existing icon.

authors: fregante sindresorhus


text:
[DOC] All code examples on MUI List view are broken

Documentation issue
All code examples are broken on this page
https://refine.dev/docs/api-reference/mui/components/basic-views/list/

Describe the thing to improve
Fix the code examples.
Describe the solution (optional)
No response

We are aware of this problem, it will be resolved after the release.

repo: refinedev/refine


text:
[BUG] use refine with next and antd

Describe the bug
I try to use refine with next antd y turbobuild
Steps To Reproduce
change package.json
"dev": "next dev --turbo", or
"dev": "cross-env NODE_OPTIONS=--max_old_space_size=4096 refine dev --turbo"
Expected behavior
I have this error:

Packages
"@ant-design/icons": "^5.0.1",
"@ant-design/nextjs-registry": "^1.0.0",
"@refinedev/antd": "^5.37.4",
"@refinedev/cli": "^2.16.21",
"@refinedev/core": "^4.47.1",
"@refinedev/devtools": "^1.1.32",
"@refinedev/kbar": "^1.3.6",
"@refinedev/nextjs-router": "^6.0.0",
"@refinedev/supabase": "^5.7.4",
"@supabase/ssr": "^0.3.0",
"antd": "^5.0.5",
"js-cookie": "^3.0.5",
"next": "^14.1.0",
"react": "^18.0.0",
"react-dom": "^18.0.0"
Additional Context
No response

Hi @ccdarvin, thanks for the report. We will reproduce this bug with turbopack and investigate it.

Hey @ccdarvin, I think turbo should ignore installed package's tsconfig file. It could be an issue with turbopack configuration.

I think the issue is in the package @refinedev/antd", because when I comment this line //transpilePackages: ['@refinedev/antd'], in next.config.mjs, it works well.

The problem between Next.js and Ant Design has existed for a long time. Since create refine-app doesn't create the project with Turbo, I prefer not to remove transpilePackages.
Thank you for the issue and solution. From now on, anyone with this problem can easily fix it.

Hi I get same issue as you but after remove @refinedev/antd from transpilePackages now it work well

authors: BatuhanW alicanerdurmaz ccdarvin jackytank


text:
Update core.md

change "posts" to "/posts" because it is shown as undefined.
IMPORTANT: Please do not create a Pull Request without creating an issue first.
Any change needs to be discussed before proceeding. Failure to do so may result in the rejection of the pull request.
Please provide enough information so that others can review your pull request:

Explain the details for making this change. What existing problem does the pull request solve?

Test plan (required)
Demonstrate the code is solid. If not, please add WIP: in its title.

Closing issues
Put closes #XXXX in your comment to auto-close the issue that your PR fixes (if such).
Self Check before Merge
Please check all items below before review.

[ ] Corresponding issues are created/updated or not needed
[ ] Docs are updated/provided or not needed
[ ] Examples are updated/provided or not needed
[ ] TypeScript definitions are updated/provided or not needed
[ ] Tests are updated/provided or not needed
[ ] Changesets are provided or not needed

Hey @charilaouc, thank you for reporting this issue. But typing /posts does not solve the problem. Can you open an issue about this situation?
We will try our best to solve the problem 🚀

Actually i went throught the tutorial and that was my only issue. Everything Else works okay.

authors: charilaouc yildirayunlu


text:
Remove embedded refract

Embedded Refract is not used anywhere, and is not specified anywhere. I think we can safely remove this Embedded Refract support given it is not used and doesn't look like it will be used.

It is actually specced out in the main refract spec repo, but yes, we can remove it from minim since it's not being used.

authors: kylef pksunkara

repo: refractproject/minim


text:
fix to accept multitype param for nullable

To Accept  openapi type like
- string
- null

becouse API DOG generate like this if i allow null to params.
logic is like
if type is array and just have a 2 choice and 1 is "null" that means the type is the onather  nullable.
so I changed

Could you please add a test case to TypeResolverTest and also in the acceptance.yml one test object.

I'm tring to write a test code but currentry facing this error
  PHP Fatal error:  Non-readonly class PHPUnit\Framework\TestStatus\Known cannot extend readonly class PHPUnit\Framework\TestStatus\TestStatus in /home/kurari/Repos/github.com/reinfi/openapi-models/vendor/phpunit/phpunit/src/Framework/TestStatus/Known.php
  on line 19

I will work on later.
thank you

authors: HajimeMat-AVAP reinfi

repo: reinfi/openapi-models


text:
Can you explain why the following DDPG code errors out.

import gym
import numpy as np
import tensorforce
from tensorforce.agents import PPOAgent,TRPOAgent,DDPGAgent
#from tensorforce import Configuration
NUM_GAMES_TO_PLAY = 70000
CLIP_ACTIONS = False #set to true if you want actions to be clipped between [-1,1]
env = gym.make("CartPole-v0")
print("Observations ", env.observation_space, " Actions",env.action_space)
network_config = [{"type": "dense", "size": 64, "activation": "tanh"},
{"type": "dense", "size": 64, "activation": "tanh"}]
network_specs  =[
dict(type='dense', size=32),
dict(type='dense', size=32),
dict(type='dense', size=32)
]
critic_network_specs  =[
dict(type='dense', size=32),
dict(type='dense', size=32),
dict(type='dense', size=32)
]
agent = DDPGAgent(states=dict(type='float32', shape=(4,)),
actions=dict(type='int', num_actions=2),
network=network_specs,
update_mode={
"unit": "timesteps",
"batch_size": 64,
"frequency": 64
},
memory = {
"type": "replay",
"capacity": 100000,
"include_next_states": True
},
optimizer = {
"type": "adam",
"learning_rate": 1e-4
},
discount = 0.99,
entropy_regularization = None,
critic_network = {
"size_t0": 64,
"size_t1": 64
},
critic_optimizer = {
"type": "adam",
"learning_rate": 1e-3
},
target_sync_frequency = 1,
target_update_weight = 0.999,
actions_exploration = {
"type": "ornstein_uhlenbeck",
"sigma": 0.3,
"mu": 0.0,
"theta": 0.15
},
execution = {
"type": "single",
"session_config": None,
"distributed_spec": None
}
                )

allRewards = np.zeros(shape=(1,1))
for game in range(NUM_GAMES_TO_PLAY):
obs = env.reset()
gameTotalReward = 0
for step in range(1000):
env.render()
a = agent.act(obs)
#print("ACTION ->",a)
if CLIP_ACTIONS:
for i in range (np.alen(a)):
if a[i] < -1: a[i]=-0.99999999999
if a[i] > 1: a[i] = 0.99999999999
obs, reward, done, info = env.step(a)
#reward = reward/100
gameTotalReward = gameTotalReward + reward
allRewards = np.vstack((allRewards, np.array([reward])))
if done:
agent.observe(reward=reward, terminal=True)
else:
agent.observe(reward=reward, terminal=False)
    #print("Action: {} Observations Size:{} score: {}".format(a,obs.shape,reward))
    if done:
        print("#",game," last game average ", (gameTotalReward/step)*100,"global avg", allRewards.mean()*100, "max",allRewards.max()*100,"min",allRewards.min()*100 , "steps", step)

        break

============
The code above gives the following error
============
Observations  Box(4,)  Actions Discrete(2)
Traceback (most recent call last):
File "C:\Project\SpaceXRocket\cartpole_test_2_.py", line 64, in
"distributed_spec": None
File "C:\Users\maka\AppData\Local\Continuum\anaconda3\envs\py35\lib\site-packages\tensorforce\agents\ddpg_agent.py", line 140, in init
entropy_regularization=entropy_regularization
File "C:\Users\maka\AppData\Local\Continuum\anaconda3\envs\py35\lib\site-packages\tensorforce\agents\learning_agent.py", line 141, in init
batching_capacity=batching_capacity
File "C:\Users\maka\AppData\Local\Continuum\anaconda3\envs\py35\lib\site-packages\tensorforce\agents\agent.py", line 80, in init
self.model = self.initialize_model()
File "C:\Users\maka\AppData\Local\Continuum\anaconda3\envs\py35\lib\site-packages\tensorforce\agents\ddpg_agent.py", line 167, in initialize_model
target_update_weight=self.target_update_weight
File "C:\Users\maka\AppData\Local\Continuum\anaconda3\envs\py35\lib\site-packages\tensorforce\models\dpg_target_model.py", line 166, in init
requires_deterministic=True
File "C:\Users\maka\AppData\Local\Continuum\anaconda3\envs\py35\lib\site-packages\tensorforce\models\distribution_model.py", line 90, in init
discount=discount
File "C:\Users\maka\AppData\Local\Continuum\anaconda3\envs\py35\lib\site-packages\tensorforce\models\memory_model.py", line 114, in init
reward_preprocessing=reward_preprocessing
File "C:\Users\maka\AppData\Local\Continuum\anaconda3\envs\py35\lib\site-packages\tensorforce\models\model.py", line 220, in init
self.setup()
File "C:\Users\maka\AppData\Local\Continuum\anaconda3\envs\py35\lib\site-packages\tensorforce\models\model.py", line 273, in setup
independent=independent
File "C:\Users\maka\AppData\Local\Continuum\anaconda3\envs\py35\lib\site-packages\tensorforce\models\memory_model.py", line 607, in create_operations
independent=independent
File "C:\Users\maka\AppData\Local\Continuum\anaconda3\envs\py35\lib\site-packages\tensorforce\models\model.py", line 1100, in create_operations
self.create_observe_operations(reward=reward, terminal=terminal)
File "C:\Users\maka\AppData\Local\Continuum\anaconda3\envs\py35\lib\site-packages\tensorforce\models\model.py", line 1078, in create_observe_operations
reward=reward
File "C:\Users\maka\AppData\Local\Continuum\anaconda3\envs\py35\lib\site-packages\tensorflow\python\ops\template.py", line 278, in call
result = self._call_func(args, kwargs, check_for_new_variables=False)
File "C:\Users\maka\AppData\Local\Continuum\anaconda3\envs\py35\lib\site-packages\tensorflow\python\ops\template.py", line 217, in _call_func
result = self._func(*args, **kwargs)
File "C:\Users\maka\AppData\Local\Continuum\anaconda3\envs\py35\lib\site-packages\tensorforce\models\memory_model.py", line 526, in tf_observe_timestep
batch = self.memory.retrieve_timesteps(n=batch_size)
File "C:\Users\maka\AppData\Local\Continuum\anaconda3\envs\py35\lib\site-packages\tensorflow\python\ops\template.py", line 278, in call
result = self._call_func(args, kwargs, check_for_new_variables=False)
File "C:\Users\maka\AppData\Local\Continuum\anaconda3\envs\py35\lib\site-packages\tensorflow\python\ops\template.py", line 217, in _call_func
result = self._func(*args, **kwargs)
File "C:\Users\maka\AppData\Local\Continuum\anaconda3\envs\py35\lib\site-packages\tensorforce\core\memories\replay.py", line 91, in tf_retrieve_timesteps
false_fn=resample_fn
File "C:\Users\maka\AppData\Local\Continuum\anaconda3\envs\py35\lib\site-packages\tensorflow\python\util\deprecation.py", line 316, in new_func
return func(*args, **kwargs)
File "C:\Users\maka\AppData\Local\Continuum\anaconda3\envs\py35\lib\site-packages\tensorflow\python\ops\control_flow_ops.py", line 1864, in cond
orig_res_f, res_f = context_f.BuildCondBranch(false_fn)
File "C:\Users\maka\AppData\Local\Continuum\anaconda3\envs\py35\lib\site-packages\tensorflow\python\ops\control_flow_ops.py", line 1725, in BuildCondBranch
original_result = fn()
File "C:\Users\maka\AppData\Local\Continuum\anaconda3\envs\py35\lib\site-packages\tensorforce\core\memories\replay.py", line 83, in resample_fn
maximum_iterations=10
TypeError: while_loop() got an unexpected keyword argument 'maximum_iterations'
originally defined at:
File "C:\Users\maka\AppData\Local\Continuum\anaconda3\envs\py35\lib\site-packages\tensorforce\models\model.py", line 249, in setup
self.setup_components_and_tf_funcs()
File "C:\Users\maka\AppData\Local\Continuum\anaconda3\envs\py35\lib\site-packages\tensorforce\models\dpg_target_model.py", line 173, in setup_components_and_tf_funcs
custom_getter = super(DPGTargetModel, self).setup_components_and_tf_funcs(custom_getter)
File "C:\Users\maka\AppData\Local\Continuum\anaconda3\envs\py35\lib\site-packages\tensorforce\models\distribution_model.py", line 119, in setup_components_and_tf_funcs
custom_getter = super(DistributionModel, self).setup_components_and_tf_funcs(custom_getter)
File "C:\Users\maka\AppData\Local\Continuum\anaconda3\envs\py35\lib\site-packages\tensorforce\models\memory_model.py", line 141, in setup_components_and_tf_funcs
summary_labels=self.summary_labels
File "C:\Users\maka\AppData\Local\Continuum\anaconda3\envs\py35\lib\site-packages\tensorforce\core\memories\memory.py", line 196, in from_spec
kwargs=kwargs
File "C:\Users\maka\AppData\Local\Continuum\anaconda3\envs\py35\lib\site-packages\tensorforce\util.py", line 175, in get_object
return obj(*args, **kwargs)
File "C:\Users\maka\AppData\Local\Continuum\anaconda3\envs\py35\lib\site-packages\tensorforce\core\memories\replay.py", line 48, in init
summary_labels=summary_labels
File "C:\Users\maka\AppData\Local\Continuum\anaconda3\envs\py35\lib\site-packages\tensorforce\core\memories\queue.py", line 59, in init
summary_labels=summary_labels
File "C:\Users\maka\AppData\Local\Continuum\anaconda3\envs\py35\lib\site-packages\tensorforce\core\memories\memory.py", line 59, in init
self.setup_template_funcs()
File "C:\Users\maka\AppData\Local\Continuum\anaconda3\envs\py35\lib\site-packages\tensorforce\core\memories\queue.py", line 63, in setup_template_funcs
custom_getter = super(Queue, self).setup_template_funcs(custom_getter=custom_getter)
File "C:\Users\maka\AppData\Local\Continuum\anaconda3\envs\py35\lib\site-packages\tensorforce\core\memories\memory.py", line 84, in setup_template_funcs
custom_getter_=custom_getter
originally defined at:
File "C:\Users\maka\AppData\Local\Continuum\anaconda3\envs\py35\lib\site-packages\tensorforce\models\model.py", line 249, in setup
self.setup_components_and_tf_funcs()
File "C:\Users\maka\AppData\Local\Continuum\anaconda3\envs\py35\lib\site-packages\tensorforce\models\dpg_target_model.py", line 173, in setup_components_and_tf_funcs
custom_getter = super(DPGTargetModel, self).setup_components_and_tf_funcs(custom_getter)
File "C:\Users\maka\AppData\Local\Continuum\anaconda3\envs\py35\lib\site-packages\tensorforce\models\distribution_model.py", line 119, in setup_components_and_tf_funcs
custom_getter = super(DistributionModel, self).setup_components_and_tf_funcs(custom_getter)
File "C:\Users\maka\AppData\Local\Continuum\anaconda3\envs\py35\lib\site-packages\tensorforce\models\memory_model.py", line 132, in setup_components_and_tf_funcs
custom_getter = super(MemoryModel, self).setup_components_and_tf_funcs(custom_getter)
File "C:\Users\maka\AppData\Local\Continuum\anaconda3\envs\py35\lib\site-packages\tensorforce\models\model.py", line 527, in setup_components_and_tf_funcs
custom_getter_=custom_getter

First, please explain your problem instead of just dumping an error log.
Second, please crop the error log to only include the relevant part.
Third, you're using tensorflow <= 1.4. Tensorforce is currently compatible with tensorflow >= 1.6 - just upgrade tensorflow (preferably to 1.7) and that error should be gone.

authors: FitMachineLearning krfricke

repo: reinforceio/tensorforce


text:
ImportError: cannot import name 'Configuration'

Just installed the latest version and got this error:
from tensorforce import Configuration
Traceback (most recent call last):
File "", line 1, in
from tensorforce import Configuration
ImportError: cannot import name 'Configuration'

The Configuration object has been deprecated multiple version ago, please update -


text:
max of 1 to max of epsilon

This was using a max of one which led to funny behaviour where it didn't use epsilon see plot here. This fixes it.

Thanks! As with the other PR, it might take a few days until we integrate it because of a major update.

authors: AlexKuhnle wassname


text:
🛑 GreatNusa.com is down

In f948b7b, GreatNusa.com (https://greatnusa.com) was down:

HTTP code: 403
Response time: 86 ms

Resolved: GreatNusa.com is back up in 32cb3d3.


text:
🛑 GreatNusa.com is down

In 6b9e896, GreatNusa.com (https://greatnusa.com) was down:

HTTP code: 403
Response time: 85 ms

Resolved: GreatNusa.com is back up in c8f299e.


text:
🛑 BINUSMAYA CDN (newcontent.binus.ac.id) is down

In bc1f593, BINUSMAYA CDN (newcontent.binus.ac.id) (https://newcontent.binus.ac.id) was down:

HTTP code: 0
Response time: 0 ms

Resolved: BINUSMAYA CDN (newcontent.binus.ac.id) is back up in 4022a13.