text:
Marked the Model property on the DataGridRowValidator as virtual

Marked the Model property on the DataGridRowValidator as virtual so, that it can be overriden. Existing DatagridRowValidator.Model throws the NotImplementedexception when accessed. See open discussion for more details: https://github.com/MudBlazor/MudBlazor/discussions/7767
Description
I would like to use the built in mudblazor validation (For) in the MudDataGrid in combination with the FluentValidator. That could potentially be done quite nicely in a similar clean way as it's already possible with other controls like MudTextField.
Here is the problem:
MudDataGrid.razor.cs contains the validator property:
public Interfaces.IForm Validator { get; set; } = new DataGridRowValidator();
There is currently no working implementation in place for the DataGrid and trying to use the mentioned validator leads to a crash because of the following implementation in the DataGridRowValidator :
public object? Model { get => throw new System.NotImplementedException(); set => throw new System.NotImplementedException(); }
The MudFormComponent would start the validation using "For" and crashes because of Form?.Model
protected virtual async Task ValidateModelWithFullPathOfMember(Func<object, string, Task<IEnumerable<string?>>> func, List<string> errors)
{
    try
    {
        if (Form?.Model is null)
        {
            return;
        }

The implementation is just not in place yet, which is perfectly fine.
Unfortunately it is currently impossible to extend or override the functionality because of the Model Property implementation (or rather the fact that it's missing and throws an exception) on the DataGridRowValidator. It's also impossible to provide a completely new implementation for the IForm since some of te properties are marked as internal.
    public interface IForm
    {
        public bool IsValid { get; }
        public string[] Errors { get; }
#nullable enable
        public object? Model { get; set; }
        public void FieldChanged(IFormComponent formControl, object? newValue);
#nullable disable
        internal void Add(IFormComponent formControl);
        internal void Remove(IFormComponent formControl);
        internal void Update(IFormComponent formControl);
    }

The easiest solution would probably be to mark the Model property on the DataGridRowValidator as virtual
The alternative would be to allow setting of Model on DataGridRowValidator. If you would prefer that let me know and I'll provide a new PR.
How Has This Been Tested?
I've created a small application to check whether the change would suffice for what I was intending to do. (override model and provide my own implementation. Honestly a normal get/set instead of an exception would have probably already be enough but I just wanted to have as little of an impact as possible.
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[X] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

[X] The PR is submitted to the correct branch (dev).
[X] My code follows the code style of this project.
[ ] I've added relevant tests.

The failing unit test is completely unrelated to the change (DateTimePicker) and seems to be a timing problem as it does not finish in the alloted time. I run all the unit tests locally just to be sure even though the provided commit is completely unintrusive and should have 0 impact.

Hi.
Thanks for the PR.
@tjscience I will accept this PR as compromise, because as it was said it's not possible to provide fully custom IForm implementation since some things are internal.
It's interesting to me that the interface has some internal methods but it doesn't provide at least default implementation for them.
I find it an anti pattern if the interface is public and contains internal things, but it is what it is.

authors: ScarletKuro iDerrien


text:
Updates CONTRIBUTING.md with info on viewing changes locally

Description
Added information to the documentation explaining how to better test changes locally before check-in.
How Has This Been Tested?
visually
Type of Changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[x] Documentation (fix or improvement to the website or code docs)

Checklist

[x] The PR is submitted to the correct branch (dev).
[x] My code follows the code style of this project.
[x] I've added relevant tests.

Oops. Just a minute. I need to revert my last commit. More changes than expected.

That's better... for some reason when I made the change it touched the TOC unnecessarily, so there's a big block of changes, which aren't necessary compared to the origin.  I'm not a fan of that. If you guys want, I could nuke this PR and take another stab at it without the TOC nonsense, though it doesn't seem to harm the layout or content overall.
The rest of the content contains the correct spelling and grammar corrections.  Let me know what you think.

The TOC was auto generated by @ScarletKuro using a special tool. I am not sure if we ever need to re-generate the TOC, but if we did then it would undo your cosmetic changes again. But it doesn't matter all that much, merging as is. Thanks for the additions

The TOC was done with https://derlin.github.io/bitdowntoc/ if anyone needs that.

source: gharchive/pull-request

authors: ScarletKuro henon marknoble

repo: MudBlazor/MudBlazor

license: MIT

license_type: permissive

license_source: github-api


text:
remaining material flags and blending modes

I have encountered a problem with material errors. When will the remaining materials that require shaders be completed?

What materials require custom shaders?

source: gharchive/issue


text:
Passing value from props

How can i pass arbitrary value from outside of the component as for example :
        <IntlPhoneInput
               ref={(ref) => this.phoneInput = ref}
               onChangeText={(props) => model.phone = props.phoneNumber}
               value={model.phone}
               defaultCountry="TR"
               lang="TR"
           />

Hi,
You can use the ref like that ;
this.phoneInput.onChangeText(data.phoneNumber);


text:
Command to pre-generate chunks?

Is it possible to implement a command, or possibly add to the /mv create command, which would tell Bukkit to create a number of chunks in advance?
I.e. specifying 128 would create a world with 128 chunks in each direction made up in advance -- giving you a large square world already. -- Edit: I'm not really bothered if this would generate a square world or a circular world. Circular would look more cool though :)
This would be useful so we could make a world, generate a map (tectonicus, mcmap, whatever), to not only see if we like the land around the spawn area but also show players the land at a distance around spawn to give them a choice of where to set up their first camp.
Possibly by adding parameter "-c numberofchunks" to the /mv create command.

So i'm pretty sure a plugin already does this, but i'm not turning it down because it should be pretty easy
It won't be advanced though, something like:
mvm generate X for chunks, that way you don't have to do it on creation.

Apparently worldborder or something already does this and it's not in the bukkit API. A requirement of MV2 is to be able to compile against Bukkit (and not CraftBukkit) so i'm gonna close this one. This is so we can be compatible with other projects that use the Bukkit API (such as Glowstone).
I think @Rigby90 knows what plugin can provide you this functionality.

For those who may want this, I've found that a Bukkit plug-in called WorldGenerationControl does exactly this with many advanced options. It can also prioritise the generation lower to not lag your server.
http://dev.bukkit.org/server-mods/worldgenerationcontrol/

Apparently worldborder or something already does this and it's not in the bukkit API. A requirement of MV2 is to be able to compile against Bukkit (and not CraftBukkit) so i'm gonna close this one. This is so we can be compatible with other projects that use the Bukkit API (such as Glowstone).

Hey you only asked me how I did it :P, I did it on 1.8 before there was a 1.8 Bukkit.
But this is possible, just do world.loadChunk(x,z);
Same way as how WorldBorder and WorldGenerationControl does it :P.

But this is possible, just do world.loadChunk(x,z);

Well then you confused me in IRC the other day, when I asked "is this in the API" You responded with something like "I did it in a modded bukkit server" :P
anywho, I think that worldgencontrol or worldborder are both better solutions than implementing it ourselves.

authors: Adambean FernFerret Rigby90

repo: Multiverse/Multiverse-Core


text:
Fixing line endings! +Test reporting

I'm not entirely sure this will pass travises muster.  my goal is here is to normalize all of our files to have the same line endings, LF.
I also added minitest-reporter so that results from tests will appear in IDEs like Rubymine.

Passed finally. Thank god.

That's weird.  I just checked out this branch and when I ran 'rake' it started downloading something:
$ rake
[Coveralls] Set up the SimpleCov formatter.
[Coveralls] Using SimpleCov's 'rails' settings.
Run options: --seed 29
Started
189/1193: [=====                            ] 8.3/s 15% 00:00:34, ETA: 00:02:01
Any idea what would cause this?
I had already run "bundle install".

Oh, weird.  I guess this is just how tests run now.

For a long time (> 6 months), tests have started like this:
vm:mushroom-observer$ rake
[Coveralls] Set up the SimpleCov formatter.
[Coveralls] Using SimpleCov's 'rails' settings.
Run options: --seed 40219

The new stuff:
Started
189/1193: [===== ] 8.3/s 15% 00:00:34, ETA: 00:02:01

is almost certainly from the newly-installed minitest-reporters gem.

authors: JoeCohen mo-nathan raysuelzer

repo: MushroomObserver/mushroom-observer


text:
Change deprecated render :text to render :plain

Exception: observation_controller/other.rb, where it's changed to render(html
Question: should others be html instead of plain?
See http://edgeguides.rubyonrails.org/upgrading_ruby_on_rails.html#rendering-content-from-string,
https://github.com/rails/rails/issues/12374

Whenever I used "render text: xxx" I meant for it to be plain text, not
html.
On Fri, Sep 1, 2017 at 2:25 PM, Joseph D. Cohen notifications@github.com
wrote:

Exception: observation_controller/other.rb, where it's changed to
render(html
Question: should others be html instead of plain?
See http://edgeguides.rubyonrails.org/upgrading_ruby_on_rails.
html#rendering-content-from-string,
rails/rails#12374 https://github.com/rails/rails/issues/12374
You can view, comment on, or merge this pull request online at:
https://github.com/MushroomObserver/mushroom-observer/pull/342
Commit Summary

Change deprecated render :text to render :plain

File Changes

M app/controllers/account_controller.rb
https://github.com/MushroomObserver/mushroom-observer/pull/342/files#diff-0
(2)
M app/controllers/ajax_controller.rb
https://github.com/MushroomObserver/mushroom-observer/pull/342/files#diff-1
(4)
M app/controllers/ajax_controller/api_key.rb
https://github.com/MushroomObserver/mushroom-observer/pull/342/files#diff-2
(4)
M app/controllers/ajax_controller/auto_complete.rb
https://github.com/MushroomObserver/mushroom-observer/pull/342/files#diff-3
(4)
M app/controllers/ajax_controller/exif.rb
https://github.com/MushroomObserver/mushroom-observer/pull/342/files#diff-4
(2)
M app/controllers/ajax_controller/external_link.rb
https://github.com/MushroomObserver/mushroom-observer/pull/342/files#diff-5
(6)
M app/controllers/ajax_controller/old_translation.rb
https://github.com/MushroomObserver/mushroom-observer/pull/342/files#diff-6
(2)
M app/controllers/ajax_controller/upload_image.rb
https://github.com/MushroomObserver/mushroom-observer/pull/342/files#diff-7
(2)
M app/controllers/application_controller.rb
https://github.com/MushroomObserver/mushroom-observer/pull/342/files#diff-8
(6)
M app/controllers/image_controller.rb
https://github.com/MushroomObserver/mushroom-observer/pull/342/files#diff-9
(4)
M app/controllers/name_controller.rb
https://github.com/MushroomObserver/mushroom-observer/pull/342/files#diff-10
(2)
M app/controllers/observer_controller/create_and_edit_
observation.rb
https://github.com/MushroomObserver/mushroom-observer/pull/342/files#diff-11
(2)
M app/controllers/observer_controller/other.rb
https://github.com/MushroomObserver/mushroom-observer/pull/342/files#diff-12
(2)
M app/controllers/translation_controller.rb
https://github.com/MushroomObserver/mushroom-observer/pull/342/files#diff-13
(2)

Patch Links:

https://github.com/MushroomObserver/mushroom-observer/pull/342.patch
https://github.com/MushroomObserver/mushroom-observer/pull/342.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/MushroomObserver/mushroom-observer/pull/342, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ADE2tUmhjby0A-YCh9KaPPxKAaeugbEeks5seHY5gaJpZM4PKpdl
.

Thanks for the comment!
This branch is a looong way from even a tentative merge with master.
I made this PR within the ror50 branch so that I could put comments on Github. It will help me keep track of things. Please don't feel obliged to look at the code, Github comments. (Of course, your comments are always welcome and helpful.)
I am going to merge this into the ror50, and begin adding comments so that I don't forget what I've done and need to do.

The only place where I used html instead of plain is observer_controller/other.rb#test_flash_redirection:

      # (sleight of hand to prevent localization_file_text from complaining
      # about missing test_flash_redirection_title tag)
      @title = "test_flash_redirection_title".to_sym.t
      render(html: "", layout: "application")

If I use plain here I get:

Error:
AmateurTest#test_language_tracking:
NoMethodError: undefined method 'document' for nil:NilClass
test/session_extensions.rb:266:in 'click'
test/integration/amateur_test.rb:307:in 'run_test'
test/integration/amateur_test.rb:301:in 'test_language_tracking'

Sure, I understand, was just answering your question.  Good catch re:
test_flash_redirection.  Strange test, but no doubt important for some
reason!
On Fri, Sep 1, 2017 at 2:55 PM, Joseph D. Cohen notifications@github.com
wrote:

Merged #342
https://github.com/MushroomObserver/mushroom-observer/pull/342.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/MushroomObserver/mushroom-observer/pull/342#event-1232076761,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADE2taGM2bkOVdS7dAfdCRUZFZX8CFuqks5seH1QgaJpZM4PKpdl
.

Your answer (re intending plain/text was indeed very helpful. It means that
I can put this set of deprecation fixes to bed.
On Fri, Sep 1, 2017 at 3:07 PM Jason Hollinger notifications@github.com
wrote:

Sure, I understand, was just answering your question. Good catch re:
test_flash_redirection. Strange test, but no doubt important for some
reason!
On Fri, Sep 1, 2017 at 2:55 PM, Joseph D. Cohen notifications@github.com
wrote:

Merged #342
https://github.com/MushroomObserver/mushroom-observer/pull/342.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<
https://github.com/MushroomObserver/mushroom-observer/pull/342#event-1232076761
,
or mute the thread
<
https://github.com/notifications/unsubscribe-auth/ADE2taGM2bkOVdS7dAfdCRUZFZX8CFuqks5seH1QgaJpZM4PKpdl
.

—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/MushroomObserver/mushroom-observer/pull/342#issuecomment-326693826,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AACxlKyyXr67c65TY2_8_mwlYiJR1LDfks5seIAIgaJpZM4PKpdl
.

My proposed method of leaving GitHub comments doesn't work. I can comment only on commits and PRs, not code generally.  Maybe I just need to leave comments in the code.

authors: JoeCohen pellaea


text:
Safe-auto-correct Layout/SpaceInsideStringInterpolation

Also updated the .rubocop_todo.yml.

Coverage remained the same at 91.929% when pulling cc6397815cb95a51da283030d8e565844b6b7ca5 on sac-Layout-SpaceInsideStringInterpolation into 79e1fe99a436439d5b91b5cfc68f98386d61a9a7 on master.

authors: coveralls mo-nathan


text:
Update gems in response to 2020-05-26 Security Alerts

Update gems in response to CVE-2020-8162 to -66 [finish #173024162]
See

CVE-2020-8162
CVE-2020-8165
CVE-2020-8166

Update all gems, although these alerts are for only 3 gems.
Finishes https://www.pivotaltracker.com/story/show/173024162

Coverage remained the same at 91.988% when pulling 4ac4df20d52b59ecffeda5970801f4f0dc0e6bc4 on JoeCohen:cve-2020-8166 into 7fccbdb8aac8c37019d2ba0738685b5efb905ff5 on MushroomObserver:master.

authors: JoeCohen coveralls


text:
DLCs

Opening for now so I can better document changes I need to make
Currently can open and close DLCs with my dummy function test_send_dlc_offer.
Has some current problems

[x] Privacy leak same keys used across all DLCs (need changes to rust_dlc)
[x] ~Same nostr key for DLCs~ Cannot statically receive bets without this
[x] Need to do proper coin selection, not just use them all
[ ] Currently using damus relay with random kind, need to do this properly
[x] Encrypt raw bytes of DLC messages instead of base64 encodings (needs rust-nostr v26)
[x] Respond with errors
[x] Docs
[ ] Tests

Some other todos for usability

[x] Make functions for decoding oracle announcements and attestations
[ ] Better wasm model

Longer term todos

[ ] nostr market place
[ ] local social tagging
[ ] dlc "zaps"

Code looks pretty clean and self contained, nice job so far. What's the status on it?

needs rebase

authors: TonyGiorgio benthecarman

repo: MutinyWallet/mutiny-node


text:
unexpected channel closed

Could you revert it ?
Channel closed because counterparty force-closed with message: Offered HTLC 17 SENT_ADD_ACK_REVOCATION cltv 833547 hit deadline
ID
1babc6f3185c73b6f2b227b104c77c82b9496bd8af3fe49d33731a40f19be0ee
#support

I'm guessing this is the same issue as
https://github.com/MutinyWallet/mutiny-node/issues/1055

We can't "revert" it but we can take a look at what happened.
Please upload the logs from the emergency toolkit page of the settings.

authors: TonyGiorgio benthecarman chainiso

repo: MutinyWallet/mutiny-web


text:
Bug/devtooling-606 Export Managed sites as data sources

Due to https://inindca.atlassian.net/browse/DEVTOOLING-606, this PR:
Removes managed attribute from sites data source
Automatically sets managed sites to data on export
Searches both managed and unmanaged sites on getSiteByName function call
Due to import cycles, the genesyscloud_resource_exporter will read the DataSourceManagedSites on export to determine which resources should be exported as data

@bbbco your requested changes were made in this PR


text:
[move] Add save hooks for extracting compiler information

Description

Most of the usages of the stepped compiler are to simply clone out portions of the AST

Particularly for the move-model and move-model-2

I added generalized hooks that let you save any step of compilation, including ProgramInfo, which might be helpful for the IDE

Test plan

Internal change

Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.

[ ] Protocol:
[ ] Nodes (Validators and Full nodes):
[ ] Indexer:
[ ] JSON-RPC:
[ ] GraphQL:
[ ] CLI:
[ ] Rust SDK:

Can we simplify this implementation quite a bit?
pub struct SavedInfo {
    parser: Option<P::Program>,
    expansion: Option<E::Program>,
    naming: Option<N::Program>,
    typing: Option<T::Program>,
    typing_info: Option<Arc<program_info::TypingProgramInfo>>,
    hlir: Option<H::Program>,
    cfgir: Option<G::Program>,
}

#[derive(Ord, PartialOrd)]
pub enum SavedInfoFlag {
    Parser,
    Expansion,
    Naming,
    Typing,
    TypingInfo,
    HLIR,
    CFGIR,
}

pub type SavedInfoSettings = BTreeSet<SavedInfoFlag>;

...

pub struct CompilationEnv {
    ...,
    saved_info: Rc<RefCell<SavedInfo>>,
    save_info_flags: SavedInfoSettings,
}

...

impl CompilationEnv {

    ...

    pub fn save_parser_ast(&self, ast: &P::Program) {
        if self.save_info_flags.contains(SavedInfoFlag::Parser) {
            self.saved_info.borrow_mut().parser = Some(ast.clone());
        }
    }

    ...

    pub fn set_saved_flag(&mut self, flag: SavedInfoFlag) {
        self.saved_info_flags.insert(flag);
    }
}

Can we simplify this implementation quite a bit?

I like it. Will do

authors: cgswords tnowacki

repo: MystenLabs/sui


text:
[docs] fix a url work unexcepted

Description
fix a url work unexcepted
before : https://sdk.mystenlabs.com/radix-ui.com/primitives
now: https://www.radix-ui.com/primitives
Test plan
How did you test the new or updated feature?

Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.

[ ] Protocol:
[ ] Nodes (Validators and Full nodes):
[ ] Indexer:
[ ] JSON-RPC:
[ ] GraphQL:
[ ] CLI:
[ ] Rust SDK:

Thanks @ooooo-create for finding this and fixing it!

authors: ooooo-create stefan-mysten


text:
Walrus Site Builder: Error on deploy: Could not find the referenced transaction

Console log
2024-07-05T07:38:21.043318Z  INFO site_builder: initializing site builder
2024-07-05T07:38:21.043555Z  INFO site_builder: configuration loaded config=Config { portal: "walrus.site", package: 0x514cf7ce2df33b9e2ca69e75bc9645ef38aca67b6f2852992a34e35e9f907f58, general: GeneralArgs { rpc_url: None, wallet: Some("/home/kos/suibase/workdirs/testnet/config/client.yaml"), walrus_binary: Some("walrus"), walrus_config: None, gas_budget: Some(500000000) } }
2024-07-05T07:38:21.043600Z  INFO site_builder::util: Using wallet configuration from /home/kos/suibase/workdirs/testnet/config/client.yaml
Parsing the directory ./dist and locally computing blob IDs ... [Ok]
Storing resource on Walrus: /android-chrome-192x192.png ... [Ok]
Storing resource on Walrus: /android-chrome-512x512.png ...
Error during execution
Error: running the command exited with error: 2024-07-05T07:39:11.642004Z  INFO walrus: running in JSON mode
2024-07-05T07:39:11.642097Z  INFO walrus_service::cli_utils: Using Walrus configuration from /home/kos/.walrus/client_config.yaml
2024-07-05T07:39:11.642197Z  INFO walrus_service::cli_utils: Using wallet configuration from /home/kos/suibase/workdirs/testnet/config/client.yaml
2024-07-05T07:39:11.793691Z  WARN sui_sdk::wallet_context: Client/Server api version mismatch, client api version : 1.27.2, server api version : 1.29.0
[warn] Client/Server api version mismatch, client api version : 1.27.2, server api version : 1.29.0
2024-07-05T07:39:12.344443Z  INFO walrus: Storing blob read from the filesystem file=./dist/android-chrome-512x512.png
2024-07-05T07:39:13.139700Z  WARN reserve_and_store_blob{blob_id="6VQgs6WPlApGbLY03w8DSNyX-Tkqe4EFngEAb32onnc"}:verify_blob_status{blob_id=BlobId(6VQgs6WPlApGbLY03w8DSNyX-Tkqe4EFngEAb32onnc) status=Existent { end_epoch: 1, status: Certified, status_event: EventID { tx_digest: TransactionDigest(G73DLxgEVrt3aigiCiBnbMTe5PBNnpe3iQEGcjxPNeRf), event_seq: 0 } }}: walrus_service::client: error=RPC call failed: ErrorObject { code: InvalidParams, message: "Could not find the referenced transaction [TransactionDigest(G73DLxgEVrt3aigiCiBnbMTe5PBNnpe3iQEGcjxPNeRf)].", data: None }
Error: did not receive a valid blob status from the quorum of nodes

Just in case you need it, the file that caused the error is https://github.com/kkomelin/sui-dapp-starter/blob/main/packages/frontend/public/android-chrome-512x512.png
Versions
OS: Ubuntu 22.04 LTS
Walrus and Walrus Site Builder: Latest (intentionally updated)
How to reproduce
# Clone the reproduction project
git clone git@github.com:kkomelin/sui-dapp-starter.git
cd sui-dapp-starter
# Install deps
pnpm install
# Run local testnet interfaces (through Suibase)
pnpm testnet:start
# Get current testnet address from the output of this command
pnpm testnet:address
# Fund the address via Sui Discord #testnet-faucet channel
# and then try to deploy the app to Walrus
pnpm frontend:deploy:walrus

Thanks for the report. Does this issue persist? The output indicates an error during the RPC call to verify the blob status, this might have been a temporary issue of the used full node.
If the issue persists, however, I need to take a closer look.

Hey @mlegner,
I saw this issue a few days ago with previous version of Walrus and Site Builder. I thought my stuff is just outdated. Today I found time to upgrade both Walrus and Site Builder and experienced the issue again.
Just run the deployment again and received a bit different error message:
2024-07-05T10:40:55.894813Z  INFO site_builder: initializing site builder
2024-07-05T10:40:55.899457Z  INFO site_builder: configuration loaded config=Config { portal: "walrus.site", package: 0x514cf7ce2df33b9e2ca69e75bc9645ef38aca67b6f2852992a34e35e9f907f58, general: GeneralArgs { rpc_url: None, wallet: Some("/home/kos/suibase/workdirs/testnet/config/client.yaml"), walrus_binary: Some("walrus"), walrus_config: None, gas_budget: Some(500000000) } }
2024-07-05T10:40:55.900230Z  INFO site_builder::util: Using wallet configuration from /home/kos/suibase/workdirs/testnet/config/client.yaml
Parsing the directory ./dist and locally computing blob IDs ... [Ok]
Storing resource on Walrus: /android-chrome-192x192.png ... [Ok]
Storing resource on Walrus: /android-chrome-512x512.png ... [Ok]
Storing resource on Walrus: /apple-touch-icon.png ... [Ok]
Storing resource on Walrus: /assets/index-Bl1oXb_-.js ... [Ok]
Storing resource on Walrus: /assets/index-Cc9PsNB6.css ... [Ok]
Storing resource on Walrus: /browserconfig.xml ... [Ok]
Storing resource on Walrus: /emoji/1.svg ... [Ok]
Storing resource on Walrus: /emoji/10.svg ...
Error during execution
Error: running the command exited with error: 2024-07-05T10:42:21.800741Z  INFO walrus: running in JSON mode
2024-07-05T10:42:21.800871Z  INFO walrus_service::cli_utils: Using Walrus configuration from /home/kos/.walrus/client_config.yaml
2024-07-05T10:42:21.801002Z  INFO walrus_service::cli_utils: Using wallet configuration from /home/kos/suibase/workdirs/testnet/config/client.yaml
2024-07-05T10:42:21.963419Z  WARN sui_sdk::wallet_context: Client/Server api version mismatch, client api version : 1.27.2, server api version : 1.28.2
[warn] Client/Server api version mismatch, client api version : 1.27.2, server api version : 1.28.2
2024-07-05T10:42:22.429975Z  INFO walrus: Storing blob read from the filesystem file=./dist/emoji/10.svg
Error: client internal error: Error in ObjectResponse: NotExists { object_id: 0xb2dddc6ff6e5905d4e16364f7ffc64db841444cf958bd0b704b8dcdb5ed5efc3 }

Looks like android-chrome-512x512.png is not the reason of the problem.

Hmm... Also the new error indicates a problem with the full node, which doesn't find some Sui object (although related to a different file now).
I haven't been able to reproduce either error locally. For example, when I check for the status of the file android-chrome-512x512.png, I get:
walrus blob-status -b 6VQgs6WPlApGbLY03w8DSNyX-Tkqe4EFngEAb32onnc
2024-07-05T12:20:31.728928Z  INFO walrus_service::cli_utils: Using Walrus configuration from /Users/markuslegner/.walrus/client_config.yaml
2024-07-05T12:20:31.729113Z  INFO walrus_service::cli_utils: Using wallet configuration from /Users/markuslegner/.sui/sui_config/client.yaml
2024-07-05T12:20:31.729493Z  INFO walrus_service::cli_utils: Using RPC URL set in wallet configuration
2024-07-05T12:20:32.318631Z  WARN sui_sdk::wallet_context: Client/Server api version mismatch, client api version : 1.27.2, server api version : 1.28.2
[warn] Client/Server api version mismatch, client api version : 1.27.2, server api version : 1.28.2
Status for blob ID 6VQgs6WPlApGbLY03w8DSNyX-Tkqe4EFngEAb32onnc: certified
End epoch: 1
Related event: (tx: G73DLxgEVrt3aigiCiBnbMTe5PBNnpe3iQEGcjxPNeRf, seq: 0)

What full node is configured in your /home/kos/suibase/workdirs/testnet/config/client.yaml?

Sure, here are my configs:
/home/kos/suibase/workdirs/testnet/config/client.yaml
---
keystore:
  File: /home/kos/suibase/workdirs/testnet/config-default/sui.keystore
envs:
  - alias: testnet_proxy
    rpc: "http://0.0.0.0:44342"
    ws: ~
    basic_auth: ~
  - alias: testnet
    rpc: "https://fullnode.testnet.sui.io:443"
    ws: ~
    basic_auth: ~
active_env: testnet_proxy
active_address: "0xc2e474f74bf8e8b9e013cb7f223f4f56c24aeba51299459bf5a9ed64d1a63888"

walrus.yaml - site-builder config
package: 0x514cf7ce2df33b9e2ca69e75bc9645ef38aca67b6f2852992a34e35e9f907f58

Thanks for the info. Could it be a problem with the currently active local testnet_proxy? That is, can you check if the problem persists if you switch the env to testnet?

@mlegner Thank you for your help! You were right.
I've updated local testnet Sui cli and removed --wallet ~/suibase/workdirs/testnet/config/client.yaml from:
site-builder --config ./walrus.yaml --wallet ~/suibase/workdirs/testnet/config/client.yaml  publish ./dist

to use Sui cli directly (not through Suibase proxy) and it worked.
Will report this issue to Suibase.

@kkomelin I suspect it might relate to some RPC services may purge their older data. Since Suibase may load-balance among multiple servers, that might also cause the issue to be inconsistent.
Can you please dig to identify the exact JSON-RPC call (so I can curl it) and I can manually try with various servers?

If it is confirm that the problem relates to purging... then the solution is to find how Suibase may help make Walrus more robust by:

Force "history sensitive" RPC calls to be directed to servers with full history.
Allow such RPC calls to be automatically retried in case a server does not have a requested object.

( In the end, I assume Mysten Labs server is not the intended solution for production )

An update from my site... After updating Sui cli today and now Suibase, the site deployment went well with no issues.
For Walrus Sites, I have to keep the Sui cli updated because Walrus Site Builder actually uses the official Sui cli (not the one that Suibase provides).
Anyways, I think we can consider this issue resolved until I see it again (hopefully not).
Thank you very much everyone for all your help 🙏

(@kkomelin thanks for sharing the logs offline)
I have verified that the Walrus RPC sui_getObject succeed with all community nodes integrated with Suibase.
BTW, I was probably wrong about the history "theory"... all existing object should be observable with sui_getObject. Pruning is more relevant when trying to retrieve old transaction (which I assume does not matter for Walrus).
What is the root cause?
Likely a temporary glitch/rate limiting from one server, which might become more common once Mysten Labs go ahead with their planned rate limiting.
What's next (for me)
On detecting response failure, will make Suibase retry with up to 2 other community server(s). This retry would apply only to "read-only" method such as "sui_getObject".
@mlegner Does Walrus already retry on sui_getObjects failure? I assume not, but asking just in case.

@mlegner is it possible that there is a race condition between the moment an object is created and the moment it can be "read back" by all RPC services worldwide? (Sorry if it does not apply, admittedly I have limited knowledge of Walrus)

@mlegner is it possible that there is a race condition between the moment an object is created and the moment it can be "read back" by all RPC services worldwide? (Sorry if it does not apply, admittedly I have limited knowledge of Walrus)
--> asking this because the error in Walrus logs says "NotExists", which suggest the server did not rate limit or failed to respond.

This potential cause sounds very probable to me.
@mlegner What do you think about adding 1-2-second delay until the object existence check to Walrus/Walrus Site Builder?

Thanks for your investigations, @kkomelin and @mario4tier. I'm answering here in bulk (let me know if I missed something).

I suspect it might relate to some RPC services may purge their older data.

BTW, I was probably wrong about the history "theory"... all existing object should be observable with sui_getObject. Pruning is more relevant when trying to retrieve old transaction (which I assume does not matter for Walrus).

This could actually be part of the problem. Walrus uses events for some purposes, including communicating the status of blobs. These events are also checked by the client to verify information obtained from storage nodes.
Given that some full nodes purge event data, we may have to use a different mechanism to verify the status of a blob. I've created an internal issue for this (https://github.com/MystenLabs/walrus/issues/586).

For Walrus Sites, I have to keep the Sui cli updated because Walrus Site Builder actually uses the official Sui cli.

Just a remark here: Neither Walrus nor the site builder uses the Sui CLI directly. It just uses the configuration files defining the active address and the RPC node.

Does Walrus already retry on sui_getObject failure? I assume not, but asking just in case.

No, in this case we don't. It's also unclear how this would help as the full node would probably reply with the same error when asked again (unless it's a proxy that sends requests to different full nodes).

is it possible that there is a race condition between the moment an object is created and the moment it can be "read back" by all RPC services worldwide?

What do you think about adding 1-2-second delay until the object existence check to Walrus/Walrus Site Builder?

I've looked into the Error: client internal error: Error in ObjectResponse: NotExists { object_id: 0xb2dddc6ff6e5905d4e16364f7ffc64db841444cf958bd0b704b8dcdb5ed5efc3 } a bit more, and I believe this is indeed such a race condition.
The reason why this occurs is that the on-chain registration of a blob is a two-step process consisting of (1) obtaining a storage resource and (2) using that resource to register the blob. The problem doesn't occur when using the same RPC node for both requests as it obviously has the data of the first request, but it can happen when the requests are proxied to different RPC nodes (which is what I suspect happened here).
A delay would be one option, but in this specific case I think using a PTB to combine the two calls would be a better solution. I've created an internal issue for this (https://github.com/MystenLabs/walrus/issues/587).

Again, thank you so much for reporting and investigating these issues! This type of feedback is extremely valuable for us to make the whole system more robust.

Thanks for the clear explanations and path forward. Learning a few things along the way :smile:
Suibase proxy now mitigates with "retries on NotExists" with up to 3 different servers (and 1 second delay in-between).

@mlegner @mario4tier Thank you very much guys for your diverse help here! I really appreciate it.
I've just tested my app deployment with the latest Suibase snapshot. No issues noticed.
Do you think we can close this issue for now?

Yes, I'll close this issue, we will work on the things we noticed here in the background. 🙂

authors: kkomelin mario4tier mlegner

repo: MystenLabs/walrus-sites


text:
Assassin stars do not get counted to supplies

Title explains it.

It works all fine for me. Try to update your memory addresses.
This Button

authors: KuerbisGnu Titowam

repo: Mytherin/Tibialyzer

license_source: bigquery


text:
Fix scheduler issue

Tickets addressed: Fixes #1165
Review: By commit
Merge strategy: Merge (no squash)

Description

In the case that

a goal is totally satisfied
initial simulation results were used
only association is checked

The duration pulling from simulation is not performed (as there is no simulation performed) and the durations of activities were not pulled from the initial simulation results.
The last commit of this branch makes it so durations are pulled from initial sim results if available.
On the way there, I found some things to improve.
Verification

All tests are passing.

[x] reproduce bug as e2e test

Documentation

None
Future work

None

I have added an e2e test.

repo: NASA-AMMOS/aerie


text:
Show comment button only to authorized users

Fixes https://github.com/NASA-IMPACT/nasa-apt/issues/542

Adds a permissions check to the hasCommentButton flag
Pass the ATBD object for the permissions check

How to test
Use the public ATDB http://localhost:9000/documents/test-atbd-1/v1.1
Switch to different users and check of the comment button shows when you hover over a headline

Owner Olivia should see the button
Andre Author should see the button
Allison Auth should not see the button

Log out completely, you should have access to the ATDB but not see the button

Confirmed.

authors: naomatheus oliverroick

repo: NASA-IMPACT/nasa-apt-frontend


text:
No parentheses should enclose a reference if it is at the beginning of a sentence

From #781

There should not be a parenthesis when a sentence begins a reference.

AC

[ ] No parentheses should enclose a reference if it is at the beginning of a sentence

@kamicut, if this is difficult, could you scope out the LoE earlier in the sprint?

@wrynearson We identified three types of potential cases of adding reference(s).

At the beginning of a sentence, which has a different format. Note there may or may not be a comma following the reference. Examples:
According to the American Psychological Association (2000), .....
Doe (2009) states that .....

Somewhere in the middle of the sentence. Note there is no punctuation following the reference and the reference gets parenthesis. Multiple citations would get one set of parenthesis. Example:
However, a parallel study (Berndt, 1981; Doe, 2002) resulted in ......

At the end of a sentence, which is followed by a period. Example:
This is a test sentence (Berndt, 1981; Doe, 2002; Johnson et al., 2001).

There are multiple ways we can tackle this ticket as well as #784:
In order of difficulty (in my opinion, but I differ to @frozenhelium on frontend difficulty)

Remove parentheses by default, and have them be written in manually in the editor around the citation by the user
Create a fixed ruleset for citations so that formatting & merging of the citations could follow the ruleset (example, no parentheses when starting a line, two citations next to each other should merge, etc.)
Create a "citation display editor" component upon inserting a reference, that will allow the editor to display how a citation will look like before it's inserted into the text box.

These have varying degrees of complexity and flexibility. (1) and (3) require some manual work on the side of the user, but are a little bit more flexible. (2) would be less flexible.

Thanks @kamicut for the summary! I think historically (before any of the DS members current working on the project joined), the idea was to value flexibility and to give the responsibility of sorting the specific details and edge cases to the user. It's a very deep rabbit hole to try to account for all of the different use cases required by users, and citations/references seem to be a pain point for users.

@bwbaker1 we're going to meet next week and deep-dive into the AGU citation rules to help us decide how to move forward with this, because this is more than just a question about parentheses

@wrynearson I discussed the issues related to in-text citations with Aaron.

We agree that the best solution is to do nothing for this use case. Hopefully, this will encourage user(s) to rephrase their sentences and place the citations at the end. Citations at the beginning of a sentence are less common anyways.

We can reassess this after the one-year maintenance period based on user feedback.

authors: bwbaker1 kamicut wrynearson

repo: NASA-IMPACT/nasa-apt


text:
Add io module and add save to collection

A first step towards enabling saving/reading in collections

[x]  Borrow from zarr's approach of writing a consolidated metadata file (.xcollection.json). This  "special" JSON file would be written in the root directory and will contain a list of "valid" keys/paths of xarray datasets within that root directory. This allows us to avoid listing everything within the root directory.
[x] Add .to_zarr(self, directory, **kwargs) method. directory would point to the root directory that contains .xcollection.json file
[x]  Add .to_netcdf(self, directory, *, mode: str = 'w', **kwargs) method
[ ] xc.open_collection(directory, **kwargs)  function: if directory doesn't contain .xcollection.json file, we raise an error and exit.
[ ] BONUS: make this functionality file-system agnostic via fsspec.

@andersy005 here it is! Feel free to leave comments/suggestions

@andersy005 I was able to implement all of those except for fsspec...

@andersy005 should we wait to review until I implement fsspec?

@mgrover1, my latest commit includes changes we discussed in last week's meeting. With these changes, I expect this to work with any fsspec compatible store.

Thanks @andersy005 !!

repo: NCAR/xcollection


text:
Clarify Semantics of CIViC data provided by SPOKE

Spin off of a tangential question that arose in #246, namely:

What are the plain language semantics of the assertions represented in SPOKE Edges created from on CIViC records? And what SPO structure is used to capture is this? I gather from above that relate a subject gene to an object chemical/drug? Using what predicate?

Rather than copy all discussion from that ticket, please pick up the thread on this topic at this comment, and continue discussion below.  The concluding thought from @brettasmi that ticket to work from here was:

It sounds like a re-evaluation (of the current SPOKE representation) is necessary and the time is right to get something more accurate into Biolink. I will defer to @karthiksoman, who is much better with the modeling of SPOKE than I am.

Ball is in your court @karthiksoman.  We can discuss here, or on a modeling call (Monday Helpdesk, Tues EPC, or Fri predicates are all possible venues)

On the SPOKE documentation, these CIViC based associations are framed as "Compound - affects - (mutant)Gene" Associations, and grouped alongside associations based on ClinicalTrials.gov and GDSC. When we address the question of CIViC statement semantics, we should also look at that of associations based on CT.org and GDSC data.

repo: NCATSTranslator/minihackathons


text:
GitHub Action Repair

First pass at getting GitHub actions (R-CMD check and pkgdown site build) to work again. I'd like to merge this PR to see if the changes I've implemented fix things at least on a sort of macro level. I can get the pkgdown site to render locally and my devtools check returns 1 NOTE (orphaned package) with no ERROR/WARNINGs and a bunch of issues with the testthat tests--that I'm not sure would cause a functioning R-CMD check GitHub action to fail.
This is directly related to issue #140 and #143 with possible relevance to other issues.

Update
Got both GitHub actions (R check + pkgdown build) to work on any update to a PR so I should be able to use this PR as a testing ground as I experiment with the GitHub action. Sorry if this makes a bunch of email pings for you Julien!

Progress Report
I've gotten the R-CMD check to run locally and return 0 errors/warnings/notes (on my computer--Mac OS--at least). The pkdown site also builds correctly for me when running pkgdown::build_site(). I've re-worked both GitHub actions to exactly mirror the GHAs YAMLs of one of my personal R packages where both GHAs work.
In the "details" of the failed GHAs here it seems like they all fail at the following step: Run r-lib/actions/setup-r-dependencies@v2 and the details of that step you get something like "Cache not found for input keys: ...". I don't know enough about how GitHub does cache actions but this is starting to feel like a bug beyond the actual structure / contents of metajam.
@brunj7, do you have any insight on a solution and/or better problem identification here?
For what it's worth, I'd pitch merging this PR regardless of the GitHub action issues because the package itself is in better shape in this branch than it is in the 'main' branch currently

Huge Progress!
While searching for other instances of this issue I found this Posit Community post which seems very closely related to what we're experiencing here. In that post, they link this issue which suggests the following changes to the GitHub Action YAMLs:

In the env var, set the PKH_SYSREQS to false
Add the following code chunk to the steps var:

- name: dependencies on Linux
if: runner.os == 'Linux'
run: sudo apt-get install -y make libicu-dev libxml2-dev libssl-dev pandoc librdf0-dev libnode-dev libcurl4-gnutls-dev

Implementing both of these has fixed the pkgdown website build GHA as well as the ubuntu release & "oldrel-1" checks! However, the ubuntu devel and windows checks are still failing. So 4/6 success at this point which feels like progress

Progress!
Adding the libjq-dev installation fixed the issues on the remaining version of ubuntu (dev)! Only the Windows check still fails and it looks like actual real errors in the testthat scripts that I can address and use pushes to this PR to see when they resolve.

GitHub Actions Fixed!
That last tweak fixed the R-CMD check for Windows OS and that means that all 6 GitHub Actions now succeed! We are ready to merge this PR whenever it is convenient. To help with other documentation I'm listing below all open metajam issues that are resolved by this PR merge.
Related Issues
Solved:

#143 - R-CMD check GitHub Action now works
#140 - pkgdown GitHub Action now works
#136 - Fixed this because udunits2 isn't actually needed by the package. It was used as a convenience for a unit conversion (from ft to m) in the third vignette but nowhere else. By changing that vignette to just do the algebra for the unit conversion I was able to safely remove this package from the "Suggests" field of the DESCRIPTION and silence the note
#133 - I'm not getting this warning anywhere at this point and I think all instances of write_csv don't specify argument names at all so I think this is solved
#132 was actually fixed by a combination of this PR and the previous one (PR #134 )

Maybe Solved:

#141 - Not sure if this is fixed but if it is supposed to throw an error/warning on R-CMD check it isn't
#137 - Ran into a ton of problems with function failures when data already existed so I just amended data download functions to add a "_copy#" to the end of the folder name and re-download there. Because file paths are very rarely actually specified (most are just passed as objects among functions) we avoid any actual error and users who re-run download functions can be satisfied that they have successfully download (a copy of) their desired data

repo: NCEAS/metajam


text:
Added coverage to workflow

Okay I finally got everything working and I think it's a massive improvement:

Separates unit tests and integration tests, this is good for two reasons: makes everything run faster as the unit tests and integration tests run in parallel, and lets us split up their coverage (I decided not to have the integration tests have a coverage report as I believe we should really just care about it for the unit tests)
Made it so the github action for integration tests will fail after 3 minutes for an individual test, or 5 minutes for the entire job
Added coverage report for just the airbrakes/ dir
Made the unit tests fail if coverage is under 80%
Added an html report to show coverage. Because we're not using something like codecov, if you want to see it you have to go to the github action's artifacts, then download the zip file, extract it, and open index.html. I don't feel like setting codecov up, or getting it to use github pages, so for now this is good enough.

~I still don't know why/how the servo has coverage.~
I think the servo has coverage because we just use the mock pin factory

I couldnt figure out how to make it so the integration tests didn't count for coverage, but I did manage to exclude the tests/ from the coverage report as who cares

Can we just switch to codecov now itself, cause I want a CI check on coverage actually. pytest-cov also has basically the same feature, which outputs coverage on console. Also the numbers are quite deceiving cause we definitely have zero tests for the servo.

Yeah idk what the problem with the numbers are, that is weird. Codecov uses this though, its just like a nice UI I think. I can look into pytest-cov

I'll just add the instructions on how to run it to our readme where we talk about pytest. That being said, you might have to double check if it works cause I can't really run tests locally.

the artifacts don't upload rn, otherwise LGTM.

Okay I fixed it. Everything should be good


text:
Field Precision - Regarding Lines 1022-1029 within schema_fgdb_v2.py

Hey Tom and/or Jason,
I'm currently reviewing the RoadCenterline section within schema_fgdb_v2.py (lines 1022-1029 specifically).
Within the GIS Data Model, the field width is capped at 6 digits. However, the schema script does not have this limitation set.
FromAddr_L, ToAddr_L, FromAddr_R, and ToAddr_R all have the index 2 position set as empty strings. Should this field precision value at Index 2 be "6" instead of an empty string?
Link to the lines of code:
https://github.com/NENA911/NG911GISDataModel/blob/986686da9ae68cdcadf9766cd5943f93969fbbf9/esri_geodatabase/NENA_NG911_Scripts/schema/schema_fgdb_v2.py#L1022-L1029
GIS Data Model specifications:

The current Index 2 values within the schema template for field precision:

Refresher on Field Precision (I won't lie, I had to look it up again...):

Just double checking,
David L.

Hey Tom, thanks for the explanation. I hadn't made it to the Domain section yet when I sent that (my apologies).
However, now that you mention the domain constraints, I went in and did some testing with the Esri File GDB template in ArcMap. Turns out, those domain constraints are not being enforced (at least with 10.8.1). The domain constraints list the max value of 999999, but I was able to successfully add/save integer values up to 2,147,483,647 (long int max). It finally tossed an error at me when I exceeded that value. I'm unable to compare the behavior in PostgreSQL.

Thank you for the additional checks. It's always interesting finding the differences between ArcMap and ArcGIS Pro and agree that values should error instead of converting. Regarding rabbit holes, in ArcGIS Pro, this issue could be handled using Constraint or Validation Rules, which would provide a specific error code. However, Attribute Rules do not work with ArcMap.
One of our balancing acts will be determining how many "workarounds" are appropriate for vendor software issues versus just listing them under a Known Issues section. There is only so far back that we can support a software product that has been discontinued.

I would consider this particular issue an Esri Bug.  Nothing, as far as I can tell, we're doing wrong but it should be reported to Esri.

authors: NCT911-DLindsey jasonhorning tomneer


text:
nz-menu多次选择后，样式问题。（垂直菜单和菜单收起状态都存在此问题）

Reproduction link
https://ng-zorro-antd-start.stackblitz.io
Steps to reproduce
官网例子中的垂直菜单为例（请忽略重现链接）
https://ng.ant.design/components/menu/zh#components-menu-demo-vertical

选择Navigation One的Option
选择Navigation Two的Option
选择Navigation Three的Option
...
多次选择后，样式显示不正确。多个菜单显示被选中的状态。

What is expected?
选择一个菜单后，之前菜单的显示为未选中样式。
What is actually happening?
之前选中的菜单依然显示选中的样式。

Environment
Info

ng-zorro-antd
7.3.3

Browser
Chrome

Duplicate of #3434

Fixed by #3455

repo: NG-ZORRO/ng-zorro-antd


text:
form 在Modal里时，对表单的input 设置[disabled]是无效的

Reproduction link
https://stackblitz.com/edit/ng-zorro-antd-start-zhxsmy
Steps to reproduce
点击show dialog 后，表单的username仍然可以输入，我已经设置disabled为true
What is expected?
username无法输入
What is actually happening?
username可以输入

Environment
Info

ng-zorro-antd
7.5.1

Browser
Chrome 版本 74.0.3729.169（正式版本） （64 位）

angular文档和页面报错都已经非常非常明显了，[disabled] 是不能可 ReactiveForm 一起使用的，打开console直接就能看到报警
It looks like you're using the disabled attribute with a reactive form directive. If you set disabled to true
when you set up this control in your component class, the disabled attribute will actually be set in the DOM for
you. We recommend using this approach to avoid 'changed after checked' errors.

Example:
form = new FormGroup({
first: new FormControl({value: 'Nancy', disabled: true}, Validators.required),
last: new FormControl('Drew', Validators.required)
});

angular文档和页面报错都已经非常非常明显了，[disabled] 是不能可 ReactiveForm 一起使用的，打开console直接就能看到报警
It looks like you're using the disabled attribute with a reactive form directive. If you set disabled to true
when you set up this control in your component class, the disabled attribute will actually be set in the DOM for
you. We recommend using this approach to avoid 'changed after checked' errors.

Example:
form = new FormGroup({
first: new FormControl({value: 'Nancy', disabled: true}, Validators.required),
last: new FormControl('Drew', Validators.required)
});

angular文档和页面报错都已经非常非常明显了，[disabled] 是不能可 ReactiveForm 一起使用的，打开console直接就能看到报警
It looks like you're using the disabled attribute with a reactive form directive. If you set disabled to true
when you set up this control in your component class, the disabled attribute will actually be set in the DOM for
you. We recommend using this approach to avoid 'changed after checked' errors.

Example:
form = new FormGroup({
first: new FormControl({value: 'Nancy', disabled: true}, Validators.required),
last: new FormControl('Drew', Validators.required)
});

authors: tangjiandeng vthinkxie


text:
the nzErrorTip of  notworking When [formGroup] changed

Reproduction link
https://codesandbox.io/s/ng-zorro-antd-ivy-forked-59ozsr
Steps to reproduce

clear <input/> value.
input someting to <input/>
click reset button.
do step 1.

What is expected?
step 4 should show the errorTips as step 1
What is actually happening?
errorTips  not showing

Environment
Info

ng-zorro-antd
13.0.1

Browser
chrome

the pupose for change the formGroup is https://github.com/angular/angular/pull/11051#issue-173083337


text:
refactor: use  to instead of [nz-icon]

PR Checklist
Please check if your PR fulfills the following requirements:

[x] The commit message follows our guidelines: https://github.com/NG-ZORRO/ng-zorro-antd/blob/master/CONTRIBUTING.md#commit
[x] Tests for the changes have been added (for bug fixes / features)
[x] Docs have been added / updated (for bug fixes / features)

PR Type
What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A
What is the new behavior?
将所有 [nz-icon] 替换为推荐的 <nz-icon> 写法。
如果用户在 CSS 中使用了 [nz-icon] 属性选择器去选择 zorro 组件内部的 icon，则需要更新为使用元素选择器。
组件内部的 DOM 结构通常不是 public 的，这属于 breaking changes 吗？
如果属于 breaking changes，那么应该也可以进入 beta 版本中。
Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

我认为属于 breaking changes，事实上 19.0.0-beta.0 中我们已经在一些组件中将 [nz-icon] 改成了 <nz-icon>，已经可能会导致用户原来 css 中的选择器失效。
所以我觉得我们不妨在这个 major 版本一次性做完，并且在 release note 中声明后续组件内部都会采用 <nz-icon> 写法，如果需要选择内部元素请更新为新选择器。用户组件自行根据偏好管理


text:
Fixed group description bug

GroupDescription was being displayed at the LocationModel level which confused the response. Now it is removed and only appears at the Group level as 'Description'.

The new grouping makes this fix redundant.

repo: NHSChoices/location-service


text:
AGE AT ATTENDANCE DATE

Age at Attendance Date has a default code: see https://www.datadictionary.nhs.uk/data_elements/age_at_attendance_date.html
We have looked in Mauro and cannot find the default code.
James has said this is because the item has not been properly migrated to Mauro and has asked for a ticket to be raised so he can investigate.

29/07/24 - James still investigating this.

James will investigate this as there is a problem with the ingest and is high priority.

I've had to investigate this as part of #540. The problem with the ingest is that it does not consider that an Attribute may not have any National Codes, meaning no Attribute Terminology is created. In the case of AGE AT ATTENDANCE DATE element (plus others), they also have no National Codes, but they do have Default Codes. At this point though, no code set is created because of a lack of matching Attribute Terminology within Mauro, so no Default Codes are imported.

James is working on this and will be testing to see if this is fixed. This is the same as #528 .

authors: AngelaFaulding pjmonks

repo: NHSDigital/DataDictionaryPublication


text:
website should have a dedicated download page

as a user wanting to download NHSbuntu
I should be able to click on a download tab
and see the available downloads, including current stable x64, 32bit, ARM, and virtualbox image/vagrant boxen

Duplicate of #26
Closing

authors: pacharanero robdyke

license: mit


text:
fix: 修复红包祝福语和视频号信息描述

修复部分 issue 中反馈的问题

https://github.com/NICEXAI/WeWorkFinanceSDK/issues/15

Hi @NICEXAI ，可以帮忙看看代码吗？

repo: NICEXAI/WeWorkFinanceSDK


text:
Unit and Integration test should be separated

The Unit and Integration tests should be separated in jenkins, sonar, the ant build file, and source code.

[ ] Jenkins
[ ] Sonar
[ ] Ant (perhaps with a seperate test-it and test-unit target in addition to the test target that runs all)
[ ] Sources (Use IT in every class description, perhaps use Junit Categories?)

Once the gradle build is ready, ant can be replaced by gradle in the task list above. Note that ant and gradle already separate unit and integration tests: package nl.esciencecenter.xenon.integration and filenames matching IT*.java and *IT.java are marked as integration tests. In gradle they also have different tasks (integrationTest vs test, use check for both).

Gradle build file now uses include/exclude rules to split the tests. The integration tests should be moved to the src/integrationtest/java folder so we don't need to use include/exclude rules anymore and there is a clear seperation between unit and integration tests.

Parts 3 and 4 are fixed when #278 and #277 get merged.

Parts 1 and 2 are also fixed. See https://sonar.esciencecenter.nl/dashboard/index/3128 for unit and integration tests.

authors: blootsvoets nielsdrost sverhoeven

repo: NLeSC/Xenon


text:
Add tools to python chapter: pylint, yapf, isort, venv

Add tools to python chapter: pylint, yapf, isort, venv

Thank you!

authors: bouweandela jvdzwaan

repo: NLeSC/guide


text:
Does the sequence of parts of unbound.conf matter?

Hi,
I've got a question on the sequence of entries in unbound.conf.
Unbound has been used at my home for a couple of years now (together with Pi-Hole), and over time I had perfected my unbound.conf to my own liking (including a.o. hyper local functionality and long TTLs). Initially this all ran on dedicated Raspberry Pi devices in a 'bare metal' setup
Recently, I installed a Firewall (a Firewalla Blue) that allows me to run functionality on it in Docker containers.
I've decided to use Kyle Harding's Unbound Docker image ( https://github.com/klutchell/unbound-docker ) and that has worked well, together with the 'official' Pi-Hole docker.
The yaml file that runs this can be found below:

version: "3"
services:
pihole:
hostname: firewalla
container_name: pihole
image: pihole/pihole:nightly
networks:
default:
ipv4_address: 172.16.0.2
environment:
TZ: 'Europe/Brussels'
DNS1: '172.16.0.4'
DNS2: '172.16.0.4'
WEBPASSWORD: [EDITED OUT]
volumes:
- '/data/pi-hole/etc-pihole:/etc/pihole'
- './etc-dnsmasq:/etc/dnsmasq.d'
- '/etc/localtime:/etc/localtime:ro'
restart: unless-stopped
links:
- unbound
unbound:
image: klutchell/unbound:latest
networks:
default:
ipv4_address: 172.16.0.4
ports:
- 5335:5335/tcp
- 5335:5335/udp
restart: unless-stopped
volumes:
- './unbound-conf:/etc/unbound/custom.conf.d'
networks:
default:
driver: bridge
ipam:
config:
- subnet: 172.16.0.0/24

Recently, I'd asked https://github.com/klutchell to add some more support for custom configs, which he did.
Initially, this was added in the 'server:' section of his base config: include: /etc/unbound/custom.conf.d/*.conf
This worked well, for additional configuration of parameters that are supposed to be part of the server: section.
if you wanted to add config that needed to be, that seemed ot possible
I'd asked Kyle to move it to the base level, outside of the server section, as I wanted to include other sections (namely the hyper local config, to name one). He was so kind to oblige.
However, since this happened - the include: /etc/unbound/custom.conf.d/*.conf line was moved out of the server:  section and put before it, my custom config seems not to be taken into account anymore: TTLs have gone down significantly again, making me quite sure that my TTL parameters are not being taken into account.
Hence my question: is there a certain sequence that needs to be followed in unbound.conf or did something else happen that stopped Unbound from considering my custom config file.
For reference, the unbound.conf that is used by the Docker container can be found here: https://github.com/klutchell/unbound-docker/blob/main/rootfs_overlay/etc/unbound/unbound.conf, and this is my custom conf in the unbound-conf subdir:

server:
cache-min-ttl: 86400
cache-max-negative-ttl: 86400
infra-host-ttl: 86400
serve-expired: yes

harden-referral-path: yes
harden-algo-downgrade: yes
harden-below-nxdomain: yes
harden-short-bufsize: yes

use-caps-for-id: yes

minimal-responses: yes

hide-version: yes

prefetch-key: yes

private-domain: plex.direct

A new feature was added for moving the include to the base level, the toplevel include, include-toplevel: "/etc/unbound/custom.conf.d/*.conf" that starts a new toplevel for every include file. Otherwise the order matters and statements from previous conf files can change the section that the next one is parsed in.
Other than that, the order of statements and includes makes a difference. In some cases, as some statements override previous statements.
Distros have changed their include to have the include-toplevel used. That is to make the .conf files more separate from each other. Perhaps you should as well, and this is what causes the issue? Or your configuration options have been superseded in other config files that are loaded later?

Thank you for the very swift response @wcawijngaards . Heel sterk geapprecieerd :)
Will take this up further and report back in case any useful info for this community might become available.

You do not always have to do so, but it is a good idea to make the conf files more independent. The older include statement continues to work.
If you include with that include at the start, you have to set the section in the config files and their section influences the next config file that is read. But I guess it is better to use the include-toplevel.

The changes were made (include to include-toplevel and the change in sequence) and all is well now - thanks a lot for the swift support!

authors: churchofnoise wcawijngaards

repo: NLnetLabs/unbound


text:
access-control-view: netmasks shorter than 8 don't work

Netmasks shorter than 8 bits don't work in directive access-control-view.
To reproduce
Steps to reproduce the behavior:

Create config

unbound.conf
server:
    use-syslog:                 no

    do-ip6:                     no
    do-udp:                     yes
    do-tcp:                     yes
    verbosity:                  0
    statistics-interval:        0
    module-config:              "respip iterator"
    pidfile:                    /run/unbound.pid
    chroot:                     ""
    hide-identity:              yes
    hide-version:               yes

    num-threads:                2
    interface:                  0.0.0.0
    so-reuseport:               yes
    target-fetch-policy:        "0 0 0 0 0"
    minimal-responses:          yes
    rrset-roundrobin:           yes

    access-control:             127.0.0.0/8     allow_snoop

# works
#    access-control-view:       127.0.0.1       test_view
#    access-control-view:       127.0.0.0/8     test_view
#    access-control-view:       127.0.0.1/8     test_view

# does not work
#    access-control-view:       127.0.0.1/0     test_view
#    access-control-view:       127.0.0.0/7     test_view
#    access-control-view:       126.0.0.0/7     test_view
    access-control-view:        0.0.0.0/0       test_view

# global definition
    local-zone:                 .       typetransparent
    local-data:                 "qqq.   IN      CNAME   ERROR--global-record"

view:
    name:                       test_view

    local-zone:                 .       typetransparent
    local-data:                 "qqq.   IN      CNAME   OK--test-view-record"

#remote-control:
#    control-enable:             yes
#    control-interface:          127.0.0.1

Uncomment one of access-control-view directives.
Send DNS query from the same host:

host -t cname qqq. 127.0.0.1

or
host -t a qqq. 127.0.0.1

Do the test for access-control-view with netmask shorter than 8 and for 8 or longer.
For shorter netmasks you will get:

qqq is an alias for ERROR--global-record.

for 8 and longer:
qqq is an alias for OK--test-view-record.

Expected behavior
The same answer for all netmasks:
qqq is an alias for OK--test-view-record.

System:

Unbound version: 1.17.1
OS: Ubuntu 23.04
unbound -V output:

Version 1.17.1

Configure line: --build=x86_64-linux-gnu --prefix=/usr --includedir=${prefix}/include --mandir=${prefix}/share/man --infodir=${prefix}/share/info --sysconfdir=/etc --localstatedir=/var --disable-option-checking --disable-silent-rules --libdir=${prefix}/lib/x86_64-linux-gnu --runstatedir=/run --disable-maintainer-mode --disable-dependency-tracking --with-pythonmodule --with-pyunbound --enable-subnet --enable-dnstap --enable-systemd --with-libnghttp2 --with-chroot-dir= --with-dnstap-socket-path=/run/dnstap.sock --disable-rpath --with-pidfile=/run/unbound.pid --with-libevent --enable-tfo-client --with-rootkey-file=/usr/share/dns/root.key --enable-tfo-server
Linked libs: libevent 2.1.12-stable (it uses epoll), OpenSSL 3.0.8 7 Feb 2023
Linked modules: dns64 python subnetcache respip validator iterator
TCP Fastopen feature available

BSD licensed, see LICENSE in source package for details.
Report bugs to unbound-bugs@nlnetlabs.nl or https://github.com/NLnetLabs/unbound/issues

Additional information
The same problem is in unbound-1.6.7 (Ubuntu 18.04).

This is not a problem with netmasks.
Unbound will try to match the most specific ACL for a client. In this case 127.0.0.0/8 is already defined. If there is no configured view for that it will go to global local records or resolution based on the acl type.
Furthermore, 127.0.0.0/8 is special in the way that it is implicitly configured in Unbound with an 'allow' access to allow localhost connections. This means that an ACL for 127.0.0.0/8 always exists by default with no view attached to it. You can overwrite the acl type like in your configuration, but you cannot remove it altogether.
You can check that netmasks shorter than 8 do work by using the following configuration for example:
server:
    ...
    interface: 192.168.1.1 # I'll use this address as another address available to the system; you can pick your real one
    ...
    access-control: 192.168.1.1/7 allow_snoop  # You need explicit access-control for anything other than 'allow'

# works :)
    access-control-view: 192.168.1.1/7 test_view  # If an access-control option is not defined above, an implicit one set to 'allow' will be created

# global definition
    local-zone: . typetransparent
    local-data: "qqq.   IN      CNAME   ERROR--global-record"

view:
    name: test_view
    local-zone: . typetransparent
    local-data: "qqq.   IN      CNAME   OK--test-view-record"

Closing this as a non-issue but feel free to reopen for further questions/clarifications :)


text:
ReplaceFileContentsOnEachWrite with Footer. The footer will overwrite the content

NLog version: 4.7
Platform:  all
Current NLog config (xml or C#, if relevant)

What is the current result? When ReplaceFileContentsOnEachWrite is enabled with the Footer, then the content will be overwritten when the footer is written.
What is the expected result? Footer is written after content
Did you checked the Internal log?
Please post full exception details (message, stacktrace, inner exceptions) -
Are there any workarounds? no
Is there a version in which it did work? none probably
Can you help us by writing an unit test?

This is probably not an issue after checking the unit tests

repo: NLog/NLog


text:
Added escape testcases

As discussed at https://github.com/NLog/yamtp/issues/3#issuecomment-239945884

Current coverage is 100% (diff: 100%)

Merging #24 into master will not change coverage

@@           master   #24   diff @@
===================================
  Files           3     3
  Lines         215   215
  Methods        31    31
  Messages        0     0
  Branches       29    29
===================================
  Hits          215   215
  Misses          0     0
  Partials        0     0

Powered by Codecov. Last update ab250eb...e122162

They pass parsing but pretty sure they don't render correctly.
I bet that {{{d}}}, 3 render {3} instead of {d} and {{{0{{}, 3 renders {3{{ instead of {3{.

yes, I see it renders {3}
But at least this is a good case to keep in the unit test.
I really don't understand why the result should be {d} ? (to focus on the first case)

repo: NLog/yamtp


text:
versions of ZAXREPLACE() for other axes

Reported by andrew wittenberg on 20 Dec 2012 22:56 UTC
It would be very helpful to have analogues of ZAXREPLACE() for the other axes: XAXREPLACE(), YAXREPLACE() etc.  I often use ZAXREPLACE to find the value of a field along a contour, which is not necessarily vertically oriented.  (One common use-case is computing a quantile function for a field that may have different numbers of missing values at different locations.)
A workaround is to use TRANSPOSE_XZ and TRANSPOSE_ZX before and after ZAXREPLACE, but this is awkward and inefficient.
Note that I am not asking for all many variants of ZAXREPLACE_*, just the vanilla ZAXREPLACE that does linear interpolation.
Migrated-From: http://dunkel.pmel.noaa.gov/trac/ferret/ticket/2015

Comment by steven.c.hankin on 20 Dec 2012 23:39 UTC
Funny you'd mention this topic.  Just this morning I was writing some notes on how to make it easier to work with "feature collections" (time series, profiles, cruise tracks, etc.).   In that case I am envisioning (nothing offical yet) that a collection of SST time series might appear inside of Ferret as a pair of variables
     sst[M=1:<nfeatures>](L=1:<Lmax>,)
 and
    time[M=1:<nfeatures>](L=1:<Lmax>,)

The M axis is the "instance" axis, and it is convenient to have it as a slower moving axis than the time axis, so that one can issue
  yes?  PLOT/VS sst, time

(Lots of details not discussed here yet.)
Anyway, to get the SST time series into a form where we can do statistics on them (e.g. time average them all at once, or get an ensemble average of all of the features) we want to get them onto a common axis.  The function to do that would presumably be
LET sst_Tax = TAXREPLACE(sst, time, myTaxis)

So this is yet another member of the family of functions you have referred to.
Note that we would also want TAXREPLACE_AVG.  It would be worth considering, now that we have string support, to redesign this broad family of functions with a single function
REPLACEAX(field, coords, axTarget, 'xform')

with examples such as
REPLACEAX(myTimeSeries, times, T['ave')
   and
REPLACEAX(myProfiles, depths, Z[gz=myZ](gt=myT],), 'lin')

implementing this approach might require a little tweak to the logic that determines the resulting grid of a "grid-changing function".  But it would be nice to reduce the number of functions that one must keep track of.

Comment by steven.c.hankin on 21 Dec 2012 01:33 UTC
Good to see a confirmation that better handling of feature collections could be put into harness.  It will be a pretty major project, though, so need other workable solutions at this point.
Would a TAXREPLACE do the job as a place-holder for the moment?  (Until the bigger issues are discussed.)  Your application might also benefit (slightly) by using the M axis as the ensemble (or instance) axis as it makes some kinds of quick plotting easier.  (Most convenient if you leave a single missing point at the end of each time axis)

Comment by andrew.wittenberg on 21 Dec 2012 16:54 UTC
Adding TAXREPLACE() and EAXREPLACE() would take care of 90% of my needs here.

Modified by ansley.b.manke on 21 Aug 2014 16:36 UTC

Comment by ansley.b.manke on 18 Oct 2016 18:26 UTC
Can this be taken care of by the Auxiliary regridding syntax introduced in V6.95?
http://ferret.pmel.noaa.gov/Ferret/documentation/users-guide/Grids-Regions/GRIDS#_4.2.6
let evar = var[gE(auxcoord)=newaxis@PLAVE]
Are further regridding transformations needed beyond @LIN and @PLAVE ?  Perhaps @BIN?

Comment by andrew.wittenberg on 18 Oct 2016 20:39 UTC
Yes indeed, sorry for the oversight!
One minor issue: why do the following give slightly different vertical axes in the plot?
 	NOAA/PMEL TMAP
 	FERRET v7.02 (beta/optim)
 	Linux 2.6.32-642.1.1.el6.x86_64 64-bit - 10/13/16
 	18-Oct-16 16:12

yes? use levitus_climatology
yes? let zval = z[let a = zval[gz(temp)=0:30:1](gz=temp]+0*temp
yes?)
yes? let b = zaxreplace(zval,temp,z[can view; set view ul; shade/j=90 zval[gz(temp)=0:30:1](gz=0:30:1])
yes?)
yes? set view ur; shade/j=90 a
yes? set view ll; shade/j=90 zaxreplace(zval,temp,z[set view lr; shade/j=90 b

I'm attaching the resulting plot.
When shading the explicit expression (top left), the vertical axis is a half-cell narrower at the bottom and top, than when using a user-defined variable A (top right).  SHOW GRID/Z shows exactly the same info for both zgz(temp)=0:30:1
yes?) and A, and if we use /VLIMITS=0:30 then the plots look identical.  But for some reason the default vertical axis limits differ between them.  Is this a bug?
I'm thinking that the top-right plot is the correct one.  For ZAXREPLACE, using either an expression or a user variable gives the same plot as the top right.  And it makes sense that the resulting z-centers are at the requested target points.
Does the top-left plot not know how to expand the vertical range slightly, to accommodate the inferred cell bounds?

Comment by ansley.b.manke on 21 Oct 2016 22:55 UTC
It's a bug in the getting the values that will become the ends of the plot axes, but it's not unique to auxiliary regridding. I have made a separate ticket outlining this, # 2476, and will close this ticket.

Attachment from andrew.wittenberg on 18 Oct 2016 20:40 UTC
REPLACE THIS TEXT WITH UPLOADED FILE ./attachments/TRAC_2015_GIT_1287/plot.gif

repo: NOAA-PMEL/Ferret

license: Unlicense


text:
Field properties - Edit action button não funciona

Funcional agora

authors: NOSiopen paulopereiralr

repo: NOSiCode-CV/IGRP-Framework


text:
images_to_samples.py: create footprints (polygons) of train/val data

generate a geojson (or alternatives) with footprints of train/val data that could be read by mlflow

More explanation on the use of those?

Using stac items will close this. Stac items come with a footprint. #222

authors: CharlesAuthier remtav

repo: NRCan/geo-deep-learning


text:
Ev1.7

No associated issue.
Changes:

Updated EV model to accept new EV charging data

Added EV event_day_ratio and max_power parameters

added EV average SOC and unmet load metrics

Updated PV model to use latitude/south for tilt/azimuth if no roof model exists

Enabled .epw files with leap year data (we remove Feb 29, similar to Cambium)

Updates for pandas v2.2

Added EV fleet example code

Added co-optimization example code (for panel project)

[x] Reference the issue your PR is fixing

[x] Assign at least 1 reviewer for your PR

[x] Test with run_dwelling.py or other script

[x] Update documentation as appropriate

[x] Update changelog as appropriate

Just realized I never requested a review from you on this. It'd be good to merge it into dev soon

@jmaguire1 just addressed #144, I think we're good to merge this?

repo: NREL/OCHRE


text:
strange checkbox behavior in Firefox browser

When configuring an admin group on the Add Admin Group page ( admin/#/admin_groups/new ), the checkboxes are not behaving as expected.
Observed behavior

When single clicking a checkbox, the checkbox is highlighted, but no checkmark appears
When double clicking a checkbox the highlighting is removed and the checkmark appears

Expected behavior

When single clicking a checkbox, the checkmark should appear
When double clicking a checkbox the checkmark should appear and disappear (one event with each click)

Whoops, this definitely slipped past me, but this should be fixed in v0.9: https://github.com/18F/api.data.gov/issues/271

authors: GUI brylie

repo: NREL/api-umbrella


text:
CH: Project missing in list of transfers on country page

Its also missing in Mongo

No longer missing in API output but still missing on page. Closing; see #106

repo: NRGI/rp-org-frontend


text:
Display sources

Sources need to diplay on project (and other entity) sites.
Display both source name, type, year, etc. as in input tables.

Ive got source tables on the project detail and concession detail page. @KseniyaKuprina can you throw these on the rest of the entity pages?

authors: byndcivilization davidmihalyi


text:
Custom filenames for Bluesky scans

When using the scan_1d function, bluesky overwrites the user-specified filename in the IOC's HDF5 plugin with the scan's uid. Is it possible to get the scan to save images using a custom filename, instead of the scan's uid?

Hi @bsobhani , thanks for opening the issue.
Using a unique id as the filename (not actually the scans uid) is required for the use of databroker. So unfortunately we can not have it save a custom filename.
What we can do is that databroker can be used to export hdf5 files, after the fact, with any custom name. This reproduces the data in 2 files but does give you a file with any name you like. This new file will also contain all the meta-data saved into bluesky so that is a benefit of this solution.
If you would like to discuss this offline let me know, I would be happy to show you how to generate a hdf5 file from a databroker entry.
thanks again for the post.

Reopening to continue the discussion.
Of course you are right, @prjemian. This is a common request and a major sticking point. I think there are a couple concerns behind those requests that need to considered separately.
One is fear of data loss. If all the files have inscrutable names, what happens if the index is lost or corrupted? In a world where we're taking more and more data, human-readable filenames won't help you because there will be too many files for a human to sort through. We have to get machine-readable names right and then rely on that system. And of course, since the index is critical, we back it up!
Another is that most people are accustomed to using files, not APIs, access their data for processing, visualization, analysis. And some existing software requires certain file formats. As you know, we'd like to move people toward APIs and away from files, but that is a decades-long cultural change that cannot be forced as a step function. In the mean time, I believe we need to meet them where they are and let them discover the advantages of APIs when they encounter the need for them.
To address both concerns, our recommendation is that instruments who really want or need files set up callbacks on the RunEngine that export files or create soft-links when a run has completed. The "ground truth" files managed by databroker keep their UUID4 names, but the user can deal with files of any filetype and naming scheme they like. Since these files are derived artifacts, they can always be regenerated if naming preferences change.
As our "suitcase" project moves from a hairy prototype to a first-class component of the bluesky ecosystem, we'll have better tooling and more examples supporting this kind of workflow.
Do you think we are on the right path?

With such competing objectives, we need to try out our ideas and see
what becomes acceptable.
On 2018-11-01 2:07 PM, Dan Allan wrote:

Do you think we are on the right path?

Another callback approach, alternative to creating soft links, is to
create an index of the large files associated with the scan.  That makes
less assumptions about the filesystem being used.  Just an idea.

How would you like to see such an index implemented? Of course there already is an index (databroker!) so it's down to a question of what redundant forms to copy that information into for user reassurance/accessibility.

I like this slide from the webinar about using interfaces:

authors: awalter-bnl bsobhani danielballan mrakitin prjemian

repo: NSLS-II/bluesky


text:
NTUEPLUS-39 adjust RWD and theme for sidebar

What is this PR for?

add logo in sidebar when the screen is small
change sidebar's theme color into light
What type of PR is it?
[Bug Fix | Improvement | Feature | Documentation | Hot Fix | Refactoring]
bug fix and improvement
Todos

[ ] - little more css

What is the Jira issue?

https://ntueeplus.atlassian.net/browse/NTUEEPLUS-39
Screenshots (if appropriate)
light theme sidebar:

when screen is small, logo still appears:

when screen is tiny, logo still appears:

@featherchen  finish!

repo: NTUEE-PLUS/EndOfWeb


text:
Tumbling is very slow, lot's of Client's redeem broadcasted

It seems the transaction monitor (class responsible for broadcasting transactions on time), is too slow to run when there is too many transaction.
The reason is that the RPCTrustedBroadcaster and RPCBroadcaster are calling listtransactions once per transaction. This can quickly escalate an take several minutes if there is 50 transactions.
It is in theory possible to call listtransactions once for both.

This issue is related to the following error messages?
I got the messages in case of test cycle parameters below the message.
info: Main[0]
      New block of height 1112038
info: Main[0]
      New registering cycle 1112038
fail: Main[0]
      Uncaught exception StateMachineExecutor : DBreeze.Exceptions.DBreezeException: Creation of the database folder failed! ---> DBreeze.Exceptions.DBreezeException: Database is not operable, please find out the problem and restart the engine! FSR INIT FAILED: /home/takayaimai/.ntumblebit/TestNet/db/Cycle_1112038/_DBreezeSchema ---> System.IO.IOException: Too many open files
         at Interop.ThrowExceptionForIoErrno(ErrorInfo errorInfo, String path, Boolean isDirectory, Func`2 errorRewriter)
         at Interop.CheckIo[TSafeHandle](TSafeHandle handle, String path, Boolean isDirectory, Func`2 errorRewriter)
         at Microsoft.Win32.SafeHandles.SafeFileHandle.Open(String path, OpenFlags flags, Int32 mode)
         at System.IO.UnixFileStream..ctor(String path, FileMode mode, FileAccess access, FileShare share, Int32 bufferSize, FileOptions options, FileStream parent)
         at System.IO.UnixFileSystem.Open(String fullPath, FileMode mode, FileAccess access, FileShare share, Int32 bufferSize, FileOptions options, FileStream parent)
         at System.IO.FileStream.Init(String path, FileMode mode, FileAccess access, FileShare share, Int32 bufferSize, FileOptions options)
         at DBreeze.Storage.FSR.InitFiles()
         --- End of inner exception stack trace ---
         at DBreeze.Storage.FSR.InitFiles()
         at DBreeze.Storage.StorageLayer..ctor(String fileName, TrieSettings trieSettings, DBreezeConfiguration configuration)
         at DBreeze.Scheme.OpenSchema()
         at DBreeze.DBreezeEngine.InitDb()
         --- End of inner exception stack trace ---
         at DBreeze.DBreezeEngine.InitDb()
         at NTumbleBit.Client.Tumbler.Services.DBreezeRepository.GetEngine(String partitionKey)
         at NTumbleBit.Client.Tumbler.Services.DBreezeRepository.Get[T](String partitionKey, String rowKey)
         at NTumbleBit.Client.Tumbler.StateMachinesExecutor.<Start>b__30_0()
fail: Main[0]
      Uncatched exception in BroadcasterJob: System.Threading.Tasks.TaskSchedulerException: An exception was thrown by a TaskScheduler. ---> System.OutOfMemoryException: Exception of type 'System.OutOfMemoryException' was thrown.
         at System.Threading.Thread.StartInternal(IPrincipal principal, StackCrawlMark& stackMark)
         at System.Threading.Thread.Start(Object parameter)
         at System.Threading.Tasks.ThreadPoolTaskScheduler.QueueTask(Task task)
         at System.Threading.Tasks.Task.ScheduleAndStart(Boolean needsProtection)
         --- End of inner exception stack trace ---
         at System.Net.HttpWebRequest.EndGetResponse(IAsyncResult asyncResult)
         at System.Net.WebRequest.<>c.<GetResponseAsync>b__37_2(IAsyncResult iar)
         at System.Threading.Tasks.TaskFactory`1.FromAsyncCoreLogic(IAsyncResult iar, Func`2 endFunction, Action`1 endAction, Task`1 promise, Boolean requiresSynchronization)
      --- End of stack trace from previous location where exception was thrown ---
         at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
         at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
         at NBitcoin.RPC.RPCClient.<SendCommandAsync>d__21.MoveNext()
      --- End of stack trace from previous location where exception was thrown ---
         at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
         at NBitcoin.RPC.RPCClient.SendCommand(RPCRequest request, Boolean throwIfRPCError)
         at NBitcoin.RPC.RPCClient.GetBlockCount()
         at NTumbleBit.Client.Tumbler.Services.RPCServices.RPCBlockExplorerService.GetCurrentHeight() in /home/takayaimai/NTumbleBit/NTumbleBit.TumblerServer/Services/RPCServices/RPCBlockExplorerService.cs:line 38
         at NTumbleBit.Client.Tumbler.Services.BroadcasterJob.<Start>b__18_0() in /home/takayaimai/NTumbleBit/NTumbleBit.TumblerServer/Services/BroadcasterJob.cs:line 65

test cycle parameters
                               cycle.RegistrationDuration = 2;
                               cycle.ClientChannelEstablishmentDuration = 1;
                               cycle.TumblerChannelEstablishmentDuration = 1;
                               cycle.SafetyPeriodDuration = 1;
                               cycle.PaymentPhaseDuration = 1;
                               cycle.TumblerCashoutDuration = 1;
                               cycle.ClientCashoutDuration = 1;

this is unrelated, but thanks for reporting "Too many open files" I have an idea where it comes from, will fix,

https://github.com/NTumbleBit/NTumbleBit/issues/35

I think if this get merged the issue can be easily resolved: https://github.com/bitcoin/bitcoin/pull/9991, right?

I normally fixed it. I am using ListTransaction once for all transaction to broadcast.

I guess you can close it and if still a problem then reopen it.

this is still an issue... trying to debug it.

fixed. Was caused by very low fee on testnet.

authors: NicolasDorier nopara73 takaya-imai

repo: NTumbleBit/NTumbleBit


text:
The completed activities on a path tracking should be 1 of 2 rather than 50%

We should show path progress as n of m rather than as a percentage.

should existing solution be changed also? Or only new solutions?

Only for new solutions is fine.

authors: Brainenjii scboesch

repo: NUS-ALSET/achievements


text:
基于mmdetion3d pointpillar改进

我改进了代码，能够利用mmdetion3d训练的pointpillar tensorrt部署，速度为15ms

可以参考我的残酷https://github.com/fpeanut/Pointpillar_tensorrt，希望给个小星星

repo: NVIDIA-AI-IOT/CUDA-PointPillars


text:
❓ [Question] module 'trtorch' has no attribute 'Input'

Why the installed trtorch has no attribute 'Input'? Thanks
trtorch version: 0.3.0

Input is added in TRTorch v0.4.0. In TRTorch v0.3.0 you pass in the shapes as tuples or dicts https://nvidia.github.io/TRTorch/v0.3.0/tutorials/getting_started.html#compiling-with-trtorch-in-python

(moving to discussions as it seems to be mostly a usage question)

authors: gaosanyuan narendasan

repo: NVIDIA/TRTorch


text:
Convert the output type of bool operation to int

Description
There is a case
code
  x1 = torch.to(torch.ge(x0, 0.5), torch.device("cuda:0"), 3, False, False)
  _136 = torch.sum(torch.mul(x1, CONSTANTS.c0), [1], False)

graph
  %1284 : Tensor = prim::Constant[value=<Tensor>]()
  %1275 : Tensor = aten::ge(%x0.1, %1274)
  %x1.1 : Tensor = aten::to(%1275, %1315, %1278, %484, %484, %486)
  %1285 : Tensor = aten::mul(%x1.1, %1284)

The output of aten::ge is Bool type, and there are three way to support the above graph

implement aten::to, to convert datatype from Bool to Int
convert datatype in aten::mul (see https://github.com/NVIDIA/TRTorch/pull/321), but I found the trtorch framework doesn't support specifying input data type, so I cann't test this method
convert the output type of Boolean Operation (that's what this PR does)

Type of change

New feature (non-breaking change which adds functionality)
Convert ouput type from bool to int

Checklist:

[x] My code follows the style guidelines of this project (You can use the linters)
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas and hacks
[ ] I have made corresponding changes to the documentation
[x] I have added tests to verify my fix or my feature
[x] New and existing unit tests pass locally with my changes

Can you write test cases for this?

Can you write test cases for this?

I think we already have test cases for boolean operation

Does this code only works when we set precision to INT?
When I update my code with your code,

Please check my pull #350

We now support aten::to operator which handles such masked multiplications. Closing this PR


text:
How to deal with slice when there's -1 in the dims?

Hi, I met a problem during the development of rwkv model support.
When building the model I have a tensor with shape (-1, -1, 2048) and I want to execute x.slice[:, -1:, :]. If I could convert the expression to using starts and lengths, which is x.slice([0, x.size(1) - 1, 0], [x.size(0), 1, x.size(2)]), the -1 in the shape leads to the following error.
 [TRT] [E] 9: [graphShapeAnalyzer.cpp::addVolumeCheck::879] Error Code 9: Internal Error ((Unnamed Layer* 6671) [Slice]_output: dimension 0 never exceeds -1)

How should I do to implement x.slice[:, -1:, :] in TensorRT-LLM? I'll really appreciate for any help! :)

Another saying is that, if we just don't want to slice a dim, and this dim is -1, is there a way to express it?

@AsakusaRinne I did something similar by using set_input, but I'm sure there might be a better solution. By the way, I returned the slice layer from the slice function and then used set_input on a shape, which can have -1 in its dimensions It worked for me initially, but after some time, I decided to move the slicing out of the TensorRT network and pass it as input parameters, which, in my case, is doable. However, in your case, it might not be. I hope the team have better approach.
https://docs.nvidia.com/deeplearning/tensorrt/api/python_api/infer/Graph/Layers.html?highlight=islicelayer#tensorrt.ISliceLayer.set_input

Thank you a lot for your help! I 'm trying using select to replace slice. However I'm not sure if everything will go well at runtime. :)

@AsakusaRinne
could you try to replace the x.size(1) - 1 to be
s = gather(shape(x), 1) - constant(int32_array([1]))

See  https://github.com/NVIDIA/TensorRT-LLM/blob/main/tensorrt_llm/functional.py#L1504 for the shape function usage.
x.size(1) here returns the -1, but what you really need is a symbolic value of that shape such that the runtime could use the actual shape to do slice.
(We may enhance the syntax in the future, but now to get the dynamic dimension, you need to use the def shape(...) function, instead of the Tensor.size

@AsakusaRinne could you try to replace the x.size(1) - 1 to be
s = gather(shape(x), 1) - constant(int32_array([1]))

See https://github.com/NVIDIA/TensorRT-LLM/blob/main/tensorrt_llm/functional.py#L1504 for the shape function usage.
x.size(1) here returns the -1, but what you really need is a symbolic value of that shape such that the runtime could use the actual shape to do slice.
(We may enhance the syntax in the future, but now to get the dynamic dimension, you need to use the def shape(...) function, instead of the Tensor.size

Thank you for the reply! May I ask why using gather here? And the gather accepts three inputs instead of two in your example.

authors: AsakusaRinne litaotju robosina

repo: NVIDIA/TensorRT-LLM


text:
[submodule-sync] bot-submodule-sync-branch-22.08 to branch-22.08 [skip ci] [bot]

submodule-sync to create a PR keeping thirdparty/cudf up-to-date.
HEAD commit SHA: 5a7e59270380c2f0bb54555149daec3ebb114d21, cudf commit SHA: https://github.com/rapidsai/cudf/commit/544f039ae23743169e45ee3c99886f26847698df
This PR will be auto-merged if test passed. If failed, it will remain open until test pass or manually fix.

HEAD commit SHA: 5a7e59270380c2f0bb54555149daec3ebb114d21, CUDF commit SHA: https://github.com/rapidsai/cudf/commit/544f039ae23743169e45ee3c99886f26847698df
Test passed: True

SUCCESS - auto-merge

repo: NVIDIA/spark-rapids-jni


text:
[FEA] Qualification Tool: For Databricks eventlog capture more information in output csv file

Currently when using Qualification tool to process lots of Eventlogs on Databricks, the result normally would be:
==================================================================================================================================================================================
|        App Name|                 App ID|App Duration|SQL DF Duration|GPU Opportunity|Estimated GPU Duration|Estimated GPU Speedup|Estimated GPU Time Saved|      Recommendation|
==================================================================================================================================================================================
|Databricks Shell|app-20220723004538-0000|      361338|         312741|         251138|             196206.05|                 1.84|               165131.94|         Recommended|
|Databricks Shell|app-20220723003957-0000|       82457|          34752|          27630|              64289.11|                 1.28|                18167.88|     Not Recommended|
|Databricks Shell|app-20220721173352-0000|       47549|           6439|           3593|              45326.82|                 1.04|                 2222.17|     Not Recommended|
==================================================================================================================================================================================

Most of times the "App Name=Databricks Shell" and the "App ID" is not useful for us to identify which job it is.
Eg, we do not know where is the event log for app-20220723004538-0000.
Because the Databricks eventlog is named as "eventlog" , "eventlog.2",etc without appID in the file name.
If we can capture below information from eventlog and save the mapping relationship between appID and them, that would be helpful for us to find out what job is for this specific appID:
spark.databricks.clusterUsageTags.clusterLogDestination	dbfs:/cluster-logs/xxx/testjoincpu_recom/
spark.databricks.clusterUsageTags.clusterId 0723-004502-qy8s8g1d

spark.databricks.clusterUsageTags.clusterAllTags [{"key":"Vendor","value":"Databricks"},{"key":"Creator","value":"xxx@xxx.com"},{"key":"ClusterName","value":"job-708382488055798-run-52523-testbyxxx_job_cluster"},{"key":"ClusterId","value":"0723-004502-qy8s8g1d"},{"key":"JobId","value":"708382488055798"},{"key":"RunName","value":"test_join_cpu_recommended"},{"key":"Name","value":"8721196619973675-2699ba82-ab92-479e-8ab1-102a1d7b07a6-worker"}]

Can we please use the "spark.databricks.clusterUsageTags.clusterAllTags" to parse and identify jobs related to the cluster

authors: krajendrannv viadea

repo: NVIDIA/spark-rapids


text:
[AUDIT] consider utilizing a new callback readyForExecution

I speculate that we have scenarios in the plugin such as metrics where this callback is useful

@gerashegalov can you add the Spark commit/issue that this is related to?  That will help us assess priority and scope.

@mattahrens done!

authors: gerashegalov mattahrens


text:
Update NOTICE copyrights to 2021

Signed-off-by: Sameer Raheja sraheja@nvidia.com
Update NOTICE and NOTICE-binary copyrights to 2021.

build


text:
Fix merge conflict with branch-22.08

Fixes the merge conflict reported in #6295.  GpuParquetScan.getParquetOptions takes an extra readDataSchema argument in 22.10 and thus had a context conflict with the revert of binary Parquet changes recently in #6292.
NOTE: This must be merged with a merge commit, not squashed!

build