text:
error loading package '': Every .bzl file must have a corresponding package, but '@rules_pods//BazelExtensions:workspace.bzl'

I trying to use PodToBUILD master latest version, but i got an error
WORKSPACE FILE
load("@bazel_tools//tools/build_defs/repo:git.bzl", "git_repository")

git_repository(
    name = "build_bazel_rules_apple",
    remote = "https://github.com/bazelbuild/rules_apple.git",
    tag = "0.31.3",
)

#git_repository(
#    name = "build_bazel_rules_swift",
#    remote = "https://github.com/bazelbuild/rules_swift.git",
#    tag = "0.18.0",
#)

load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive")

http_archive(
    name = "build_bazel_rules_swift",
    sha256 = "d0e5f888b2ccce42c92e6d4686b5507b4230462627f965f9d39862e11ae9fb35",
    url = "https://github.com/bazelbuild/rules_swift/releases/download/0.18.0/rules_swift.0.18.0.tar.gz",
)

load(
    "@build_bazel_rules_swift//swift:repositories.bzl",
    "swift_rules_dependencies",
)

swift_rules_dependencies()

load(
    "@build_bazel_rules_swift//swift:extras.bzl",
    "swift_rules_extra_dependencies",
)

swift_rules_extra_dependencies()

git_repository(
    name = "build_bazel_apple_support",
    remote = "https://github.com/bazelbuild/apple_support.git",
    tag = "0.11.0",
)

git_repository(
    name = "bazel_skylib",
    remote = "https://github.com/bazelbuild/bazel-skylib.git",
    tag = "1.0.3",
)

http_archive(
    name = "rules_pods",
    urls = ["https://github.com/pinterest/PodToBUILD/archive/refs/heads/master.zip"],
)

load("@rules_pods//BazelExtensions:workspace.bzl", "new_pod_repository")

Pods.WORKSPACE

new_pod_repository(
  name = "RxSwift",
  url = "https://github.com/ReactiveX/RxSwift/archive/5.0.0.zip",
)

new_pod_repository(
  name = "RxRelay",
  url = "https://github.com/ReactiveX/RxSwift/archive/5.0.0.zip",
)

new_pod_repository(
  name = "RxCocoa",
  url = "https://github.com/ReactiveX/RxSwift/archive/5.0.0.zip",
)

new_pod_repository(
  name = "Alamofire",
  url = "https://github.com/Alamofire/Alamofire/archive/5.4.0.zip",
)

BUILD file
load("@build_bazel_rules_apple//apple:ios.bzl", "ios_application")

load("@build_bazel_rules_swift//swift:swift.bzl", "swift_library")

load("@rules_cc//cc:defs.bzl", "objc_library")

swift_library(
    name = "Source",
    srcs = glob([
        "*.swift",
    ]),
    data = [
        "Main.storyboard",
        "LaunchScreen.storyboard"
    ],
    deps = [
        "//ios-app/submodules/FeatureA",
        "//ios-app/submodules/FeatureB",
        "//ios-app/submodules/FeatureC",
        "//ios-app/submodules/FeatureD",
        "//Vendor/Alamofire:Alamofire",
        "//Vendor/RxSwift:RxSwift",
        "//Vendor/RxRelay:RxRelay",
        "//Vendor/RxCocoa:RxCocoa",
    ],
)

ios_application(
    name = "ios-app-swift",
    bundle_id = "br.com.example-app-swift",
    families = [
        "iphone",
        "ipad",
    ],
    minimum_os_version = "11.0",
    infoplists = [":Info.plist"],
    visibility = ["//visibility:public"],
    deps = [
        ":Source"
    ],
)

when run command bazel run @rules_pods//:update_pods -- --src_root $PWD
i got
error loading package '': Every .bzl file must have a corresponding package, but '@rules_pods//BazelExtensions:workspace.bzl' does not have one. Please create a BUILD file in the same or any parent directory. Note that this BUILD file does not need to do anything except exist.

This version works fine (install) update_pods command
https://github.com/pinterest/PodToBUILD/releases/download/3.4.1-ea20598f/PodToBUILD.zip
but is outdated, i got error when build the app, the BUILD.bazel file generated inside each pod is outdated generation

It seems you have to use a release version of PodToBUILD. You could clone this repo and make it on you own, or use the one I just created https://github.com/iftechio/PodToBUILD/releases/download/3.4.2/PodToBUILD.zip

@mcfans
I tried to use this version https://github.com/iftechio/PodToBUILD/releases/download/3.4.3-c538dab/PodToBUILD.zip
but in RxCocoa dependency I got this error
 /Users/dafle/Desktop/project/Vendor/RxCocoa/BUILD.bazel:47:14: Compiling Swift module RxCocoa failed: (Exit 1): worker failed: error executing command bazel-out/host/bin/external/build_bazel_rules_swift/tools/worker/worker swiftc ... (remaining 1 argument(s) skipped)
<module-includes>:1:9: note: in file included from <module-includes>:1:
#import "../RxCocoa_umbrella_header.h"
        ^
/private/var/tmp/_bazel_dafle/95ebb7f9aadb563e67eff2a44c6579b0/execroot/__main__/bazel-out/ios-x86_64-min11.0-applebin_ios-ios_x86_64-fastbuild-ST-1665503f7bef/bin/Vendor/RxCocoa/RxCocoa_module_map/../RxCocoa_umbrella_header.h:19:9: note: in file included from /private/var/tmp/_bazel_dafle/95ebb7f9aadb563e67eff2a44c6579b0/execroot/__main__/bazel-out/ios-x86_64-min11.0-applebin_ios-ios_x86_64-fastbuild-ST-1665503f7bef/bin/Vendor/RxCocoa/RxCocoa_module_map/../RxCocoa_umbrella_header.h:19:
#import "Vendor/RxCocoa/RxCocoa/RxCocoa.h"
        ^
/private/var/tmp/_bazel_dafle/95ebb7f9aadb563e67eff2a44c6579b0/execroot/__main__/./Vendor/RxCocoa/RxCocoa/RxCocoa.h:10:9: error: '_RX.h' file not found
#import "_RX.h"
        ^
<unknown>:0: error: could not build Objective-C module 'RxCocoa'
<module-includes>:1:9: note: in file included from <module-includes>:1:
#import "../RxCocoa_umbrella_header.h"
        ^
/private/var/tmp/_bazel_dafle/95ebb7f9aadb563e67eff2a44c6579b0/execroot/__main__/bazel-out/ios-x86_64-min11.0-applebin_ios-ios_x86_64-fastbuild-ST-1665503f7bef/bin/Vendor/RxCocoa/RxCocoa_module_map/../RxCocoa_umbrella_header.h:19:9: note: in file included from /private/var/tmp/_bazel_dafle/95ebb7f9aadb563e67eff2a44c6579b0/execroot/__main__/bazel-out/ios-x86_64-min11.0-applebin_ios-ios_x86_64-fastbuild-ST-1665503f7bef/bin/Vendor/RxCocoa/RxCocoa_module_map/../RxCocoa_umbrella_header.h:19:
#import "Vendor/RxCocoa/RxCocoa/RxCocoa.h"
        ^
/private/var/tmp/_bazel_dafle/95ebb7f9aadb563e67eff2a44c6579b0/execroot/__main__/./Vendor/RxCocoa/RxCocoa/RxCocoa.h:10:9: error: '_RX.h' file not found
#import "_RX.h"
        ^
<unknown>:0: error: could not build Objective-C module 'RxCocoa'
<module-includes>:1:9: note: in file included from <module-includes>:1:
#import "../RxCocoa_umbrella_header.h"
        ^
/private/var/tmp/_bazel_dafle/95ebb7f9aadb563e67eff2a44c6579b0/execroot/__main__/bazel-out/ios-x86_64-min11.0-applebin_ios-ios_x86_64-fastbuild-ST-1665503f7bef/bin/Vendor/RxCocoa/RxCocoa_module_map/../RxCocoa_umbrella_header.h:19:9: note: in file included from /private/var/tmp/_bazel_dafle/95ebb7f9aadb563e67eff2a44c6579b0/execroot/__main__/bazel-out/ios-x86_64-min11.0-applebin_ios-ios_x86_64-fastbuild-ST-1665503f7bef/bin/Vendor/RxCocoa/RxCocoa_module_map/../RxCocoa_umbrella_header.h:19:
#import "Vendor/RxCocoa/RxCocoa/RxCocoa.h"
        ^
/private/var/tmp/_bazel_dafle/95ebb7f9aadb563e67eff2a44c6579b0/execroot/__main__/./Vendor/RxCocoa/RxCocoa/RxCocoa.h:10:9: error: '_RX.h' file not found
#import "_RX.h"
        ^
<unknown>:0: error: could not build Objective-C module 'RxCocoa'
<module-includes>:1:9: note: in file included from <module-includes>:1:
#import "../RxCocoa_umbrella_header.h"
        ^
/private/var/tmp/_bazel_dafle/95ebb7f9aadb563e67eff2a44c6579b0/execroot/__main__/bazel-out/ios-x86_64-min11.0-applebin_ios-ios_x86_64-fastbuild-ST-1665503f7bef/bin/Vendor/RxCocoa/RxCocoa_module_map/../RxCocoa_umbrella_header.h:19:9: note: in file included from /private/var/tmp/_bazel_dafle/95ebb7f9aadb563e67eff2a44c6579b0/execroot/__main__/bazel-out/ios-x86_64-min11.0-applebin_ios-ios_x86_64-fastbuild-ST-1665503f7bef/bin/Vendor/RxCocoa/RxCocoa_module_map/../RxCocoa_umbrella_header.h:19:
#import "Vendor/RxCocoa/RxCocoa/RxCocoa.h"
        ^
/private/var/tmp/_bazel_dafle/95ebb7f9aadb563e67eff2a44c6579b0/execroot/__main__/./Vendor/RxCocoa/RxCocoa/RxCocoa.h:10:9: error: '_RX.h' file not found
#import "_RX.h"
        ^
<unknown>:0: error: could not build Objective-C module 'RxCocoa'
<module-includes>:1:9: note: in file included from <module-includes>:1:
#import "../RxCocoa_umbrella_header.h"
        ^
/private/var/tmp/_bazel_dafle/95ebb7f9aadb563e67eff2a44c6579b0/execroot/__main__/bazel-out/ios-x86_64-min11.0-applebin_ios-ios_x86_64-fastbuild-ST-1665503f7bef/bin/Vendor/RxCocoa/RxCocoa_module_map/../RxCocoa_umbrella_header.h:19:9: note: in file included from /private/var/tmp/_bazel_dafle/95ebb7f9aadb563e67eff2a44c6579b0/execroot/__main__/bazel-out/ios-x86_64-min11.0-applebin_ios-ios_x86_64-fastbuild-ST-1665503f7bef/bin/Vendor/RxCocoa/RxCocoa_module_map/../RxCocoa_umbrella_header.h:19:
#import "Vendor/RxCocoa/RxCocoa/RxCocoa.h"
        ^
/private/var/tmp/_bazel_dafle/95ebb7f9aadb563e67eff2a44c6579b0/execroot/__main__/./Vendor/RxCocoa/RxCocoa/RxCocoa.h:10:9: error: '_RX.h' file not found
#import "_RX.h"
        ^
<unknown>:0: error: could not build Objective-C module 'RxCocoa'
Target //ios-app:ios-app-swift failed to build
Use --verbose_failures to see the command lines of failed build steps.

Yeah, I met this problem too. Swift library in generated BUILD file missed some include path, so we got this error in swift-objc mixed pod because swift compiler can't find the objc headers. I am trying to solve this, but not too soon

@mcfans
inside BUILD file generated RxCocoa I replaced the line 124 by 125, and it works fine.

looks like the problem is relative to
header_visibility attribute.

authors: daflecardoso mcfans

repo: pinterest/PodToBUILD


text:
Check extra whitespace success, but check extra tab character in the begin of line does not work

gradle task ktlint failed if there are extra whitespaces with
error line="9" column="1" severity="error" message="Unexpected indentation (11) (it should be 8) (cannot be auto-corrected)" source="indent"
for example.
but if there are extra tab character in the begining of line - the task finish success, which is not expected.

@ElenaSpb can you give a small code snippet demonstrating the issue? Thanks!

I'm not sure if this is related, but this code snippet does not provoke an error in KtLint, which it should:
class Foo {
    private fun doBar(): Int =
        if (somethingIsTrue) {
            doThis()
    } else {
        doThat()
    }
    ...
}

Notice how the indentation of the else block is not following the one of the if block. This is with ktlint 0.34.2 btw. and was also the case with 0.31 and earlier versions before.

I think he means this case:
class Foo {
    private fun doBar() {
            doThis()
    }

    private fun doFoo() {
        doThis()
    }
    ...
}```

So this case it succeeds when linting although there's an extra tab on the `doBar()` method.

thanks a lot, just I already config ktlint properly and it works fine.

only if package in class is not the same as location - it does not show such errors..

@ElenaSpb I run into the same issue. How did you change the configuration to fix this?

@ggajews is it happening for you as well?

execuse me - I thought I leave comment in another issue.
this 2 bugs which I describe are still reproduced
may be there were made some changes
but in
ktlint "com.github.shyiko:ktlint:0.31.0"
it is reproduces

@Tapchicoma yes, we are using spaces for formatting, and if I add a random tab in the line, ktlint does not report it.

Problem is that lines that are properly indented at the correct level but are using the wrong indentation style (tabs instead of space or vice versa) are not autocorrected. In the example of this issue, only the the improperly indented lines were fixed. PR is on its way.

source: gharchive/issue

authors: ElenaSpb Tapchicoma alejandrorosas ggajews paul-dingemans realdadfish shashachu

repo: pinterest/ktlint

license: MIT

license_type: permissive

license_source: github-api


text:
Add initial implementations for kafka ingestion start/stop APIs.

This diff adds the implementations for start/stop kafka API's which will be
called by helix during state transitions.
This is just in initial implementation focussing on the kafka consumer
threads synchronization.

Can you provide some context about how our kafka consumer library is structured and how it's supposed to be used? Such as thread pool, threading model etc. This can help us to see if the logic in admin handler is the best way to use it.

The kafka consumer library is structured into 3 classes:

KafkaConsumer: This is simple wrapper around librdkafka's KafkaConsumer class, has additional logic of retrying if there are failures, among other minor additions.
KafkaConsumerPool: This constructs a pool (or a queue) of KafkaConsumers, where each consumer consumes messages in a separate thread. From what I understand, a larger queue size is used while consuming high volume of traffic from multiple partitions. For our use case, since each KafkaConsumerPool is responsible only for a single partition, and for the sake of simplicity, we set the size to 1.
KafkaWatcher: Base class for watchers that want to consume from kafka. Manages the kafka
consumer and the consuming thread. Provides functions to seek to a timestamp, consume messages and then do the live consumption in a separate thread. As of now, the base class is good enough for our use case. If in the future, we need more functionality, we can create a derived class.

source: gharchive/pull-request

repo: pinterest/rocksplicator

license_source: bigquery


text:
Adding timeout to prevent webhook failures

If a webhook never returns, it will hang forever and all subsequent webhooks will not be called.  This resolves the issue.

Manually tested and verified to work.

repo: pinterest/teletraan


text:
Windows Target Platform Version

Windows Target Platform Version can be written as 10.0 Which means the lastest windows 10 SDK.
From Visual studio 16.2, the default windows SDK is 10.0.18362.0 not 10.0.17763.0 and it can support v141_xp too.

I'll also make a proper v142 config, since installing v141_xp toolset is usually not a requirement nowadays in 2019.

FYI - RGTools x64 does not work on XP64:
Cannot load file 'E:/Apps/VideoTools/AVSPlugins/AutoLoad64/RgTools.dll'. Platform returned code 14001:
This application has failed to start because the application configuration is incorrect. Reinstalling the application may fix this problem.

FYI - RGTools x64 does not work on XP64 (no big deal, I just wanted to mention it):
Cannot load file 'E:/Apps/VideoTools/AVSPlugins/AutoLoad64/RgTools.dll'. Platform returned code 14001:
This application has failed to start because the application configuration is incorrect. Reinstalling the application may fix this problem.

@Groucho2004: sorry for the delay, you are right, an x64 build compiled with an earlier LLVM version was copied to the release pack, instead of the XP build. I'll prepare an 0.99 version later.

Is there any binary build of version 1.0 for Windows readily for download? I can't find one anywhere.

Code|Releases (on the right side)
https://github.com/pinterf/RgTools/releases/tag/1.0

Ah yes. I overlooked the assets drop-down. Thanks.

repo: pinterf/RgTools


text:
Handle POST from user on the serverless side

Hoooooooooooooooorayyy!!!
This is saved as...

this!!!

Yeah of course twitter:creator is wrong. That should be fixed by #28

repo: pinvite/react-app


text:
Add E2E testing for Srflx and Relay candidates

Using pion/turn add tests for both candidates types
Resolves #47

I expect this to leak pion/turn doesn't have graceful shutdown yet. Will merge when green/doesn't blow up though!

Codecov Report

Merging #66 into master will increase coverage by 5.57%.
The diff coverage is 81.81%.

@@            Coverage Diff             @@
##           master      #66      +/-   ##
==========================================
+ Coverage   69.49%   75.06%   +5.57%
==========================================
  Files          20       20
  Lines        1452     1460       +8
==========================================
+ Hits         1009     1096      +87
+ Misses        358      260      -98
- Partials       85      104      +19

Impacted Files
Coverage Δ

gather.go
57.02% <100%> (+21.7%)
:arrow_up:

candidate_relay.go
84.9% <80%> (+49.35%)
:arrow_up:

agent.go
76.05% <0%> (+0.7%)
:arrow_up:

selection.go
70.18% <0%> (+2.48%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 06c58b8...9a78b89. Read the comment docs.

authors: Sean-Der codecov-io

repo: pion/ice

license: mit


text:
media engine updates

if the client pc doesn't define codecs, use defaults. this should resolve the issue where the initial offerer doesn't have audio/video track and as such media engine doesn't contain codecs

@cameronej i think this resolves the issue you were seeing previously. the offerer should still receive video/audio even if the initial offer doesn't contain audio/video tracks

Hi @tarrencev I've tested these changes and it does solve the issue I was having before (and does so without having to manually add the video transceiver on the client who has audio only)

authors: cameronej tarrencev

repo: pion/ion-sfu


text:
ci(workflow): test action

working on moving ci to github actions. integration is nicer and tests run faster (no queueing)
@Sean-Der @at-wat let me know what you think. i will migrate others if you are fine with it

:fire: I am all for this!

We can do this one piece at a time. I am up for pushing this to https://github.com/pion/.goassets and migrating more stuff later. Don't think it needs to be perfect for us to start moving :)
Do you know if TEST_EXTRA_ARGS is still getting picked up?

It would be worth looking at other Go projects in github actions, and see if they need the following. I feel like we are doing something wrong to need all these extra steps.
      - name: set test packages
        run: echo ::set-env name=TEST_PACKAGES::$(go list ./... | grep -v examples)

      - name: set cover packages
        run: echo ::set-env name=COVER_PACKAGES::$(echo "${TEST_PACKAGES}" | paste -s -d ',')

It doesnt look like TEST_EXTRA_ARGS is being used. afaict the reason for TEST_PACKAGES is to filter examples from the test packages

authors: Sean-Der tarrencev

repo: pion/webrtc


text:
[FE] As a user, I should be able to make a transaction even when there is no Internet connectivity

Defination of Done

A user should be able to make transaction even in offline mode.
Transaction should get stored in queueing mechanism and when internet connection is back
transaction will initiate.
Keep offline notification displayed at all times at the top. User can't even close it. As soon as internet
connectivity is restored, the notification should go away.
All links should be disabled except send-money and name of the user
as soon as dashboard page loads receiver list should be stored
whenever new exchange rate appears store it as cache
If the user is in offline mode and exchange rate could not be fetched transaction can't continue and
continue button should be disabled
on the review page add new receiver should be hidden
this transfer will appear on an alert after clicking on continue button on dashboard
on summary page on clicking send money button user will be redirected to dashboard page and transfer will appear as an alert.
when internet is restored user continues transfer from the alert and lands on to the summary page(fetch new exchange rate)
if user is already in offline mode then continue button disable
Store information
user profile, user account, history, receiver list, summary, exchange rate, offline transfer

Make some corrections.
design frontend.
Do error handling.

repo: pioneer-pay/pioneer-pay-web-app


text:
Fix Menu Button Visibility

This pull request fixes the issue of the main menu button disappearing since ChatGPT moved the profile button to a new location. This PR implements a robust solution for relocating the menu button to the profile button div.
Changes Made:

Main Menu Button Placement: The export menu button now resides as the first child of the profile button div. This visually groups it with the profile button.
Optimized Injection: The injectMenu() function utilizes setInterval to actively check if the menu button already exists in the profile button div. If not, it injects it. The setInterval loop is immediately stopped after successful injection to minimize unnecessary checks and improve performance.
Minor Aesthetic Optimizations: Since the menu button now shares a container with the profile button, the extra border and divider line have been removed for a cleaner look.

Testing:

Tested these changes in MS Edge by updating the userscript manually.
Performed a hard refresh (Ctrl+Shift+R or Cmd+Shift+R) on ChatGPT to clear the cache and ensure a clean reload.
Confirmed the export menu button consistently appears next to the share chat and profile button in the header.

Benefits:

Improved Visibility: The menu button is visible again after ChatGPT moved the profile button.
Improved Performance: The optimized injection logic, including the setInterval termination, reduces unnecessary DOM manipulation for better performance.

Screenshot:

Closing Issues
This PR closes issue #251.

Do you still have the team workspace button on the left side? If so, I would still prefer to put the menu there.

the team workspace button is still on the left side. The improvement moves the export button to the top right, alongside the profile and share buttons. This does solve the issue of the menu disappearing caused by some extensions. I noticed that enabling certain scripts can still cause the menu to disappear, but it’s not a major problem.

Thanks for the contribution. But I still want to keep it in the same place. We can work on fixing the disappearing issue. I will merge the PR if we can't find or fix the problem.

Thanks for the contribution. But I still want to keep it in the same place. We can work on fixing the disappearing issue. I will merge the PR if we can't find or fix the problem.

Update:
The menu disappeared again today. I’m not sure what happened, but the only thing I’m certain of is that it conflicts with some scripts or extensions—sometimes with extensions, sometimes with scripts. The most challenging part is that it doesn’t conflict with any specific extension or script.

Thanks for feedback 👍. An additional observation is that the menu button
in my PR didn't survive switching from desktop to mobile to desktop view.
Op do 5 sep 2024 om 19:11 schreef kgsjtl @.***>:

Thanks for the contribution. But I still want to keep it in the same
place. We can work on fixing the disappearing issue. I will merge the PR if
we can't find or fix the problem.
Update:
The menu disappeared again today. I’m not sure what happened, but the only
thing I’m certain of is that it conflicts with some scripts or
extensions—sometimes with extensions, sometimes with scripts. The most
challenging part is that it doesn’t conflict with any specific extension or
script.
—
Reply to this email directly, view it on GitHub
https://github.com/pionxzh/chatgpt-exporter/pull/252#issuecomment-2332244834,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AKTLWPE62XOE5I5G3VERKVTZVCGC3AVCNFSM6AAAAABNQSKGMSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMZSGI2DIOBTGQ
.
You are receiving this because you authored the thread.Message ID:
@.***>

Latest version restores the menu button visibillity provided that another user script doesn't break it.

authors: SzVLsY danielhamelberg pionxzh

repo: pionxzh/chatgpt-exporter


text:
Lambda rollback stage implementation

What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?:

Failed lambda application deployment can be rolled back automatically

I was taking a walk around the implementation for lambda cloud provider, then I looked out for this part:
https://github.com/pipe-cd/pipe/blob/d4d222200a9fb5df5c558f9b13c3256e51f202de/pkg/app/piped/cloudprovider/lambda/client.go#L274-L275
Instead it'd better be:
	for version, weight := range cfg.RoutingConfig.AdditionalVersionWeights {
		newerVersionTraffic = percentageToPercent(aws.Float64Value(weight))

Also, as you may know all around here should be replaced with aws.StringValue().
https://github.com/pipe-cd/pipe/blob/d4d222200a9fb5df5c558f9b13c3256e51f202de/pkg/app/piped/cloudprovider/lambda/client.go#L266
https://github.com/pipe-cd/pipe/blob/d4d222200a9fb5df5c558f9b13c3256e51f202de/pkg/app/piped/cloudprovider/lambda/client.go#L282
https://github.com/pipe-cd/pipe/blob/d4d222200a9fb5df5c558f9b13c3256e51f202de/pkg/app/piped/cloudprovider/lambda/client.go#L194
I should've mentioned on previous review, but hopefully it helps you.

I was taking a walk around the implementation for lambda cloud provider, then I looked out for this part:
https://github.com/pipe-cd/pipe/blob/d4d222200a9fb5df5c558f9b13c3256e51f202de/pkg/app/piped/cloudprovider/lambda/client.go#L274-L275
Instead it'd better be:
	for version, weight := range cfg.RoutingConfig.AdditionalVersionWeights {
		newerVersionTraffic = percentageToPercent(aws.Float64Value(weight))

Also, as you may know all around here should be replaced with aws.StringValue().
https://github.com/pipe-cd/pipe/blob/d4d222200a9fb5df5c558f9b13c3256e51f202de/pkg/app/piped/cloudprovider/lambda/client.go#L266
https://github.com/pipe-cd/pipe/blob/d4d222200a9fb5df5c558f9b13c3256e51f202de/pkg/app/piped/cloudprovider/lambda/client.go#L282
https://github.com/pipe-cd/pipe/blob/d4d222200a9fb5df5c558f9b13c3256e51f202de/pkg/app/piped/cloudprovider/lambda/client.go#L194
I should've mentioned on previous review, but hopefully it helps you.

I was taking a walk around the implementation for lambda cloud provider, then I found out this part:
https://github.com/pipe-cd/pipe/blob/d4d222200a9fb5df5c558f9b13c3256e51f202de/pkg/app/piped/cloudprovider/lambda/client.go#L274-L275
Instead it'd better be:
	for version, weight := range cfg.RoutingConfig.AdditionalVersionWeights {
		newerVersionTraffic = percentageToPercent(aws.Float64Value(weight))

Also, as you may know all around here should be replaced with aws.StringValue().
https://github.com/pipe-cd/pipe/blob/d4d222200a9fb5df5c558f9b13c3256e51f202de/pkg/app/piped/cloudprovider/lambda/client.go#L266
https://github.com/pipe-cd/pipe/blob/d4d222200a9fb5df5c558f9b13c3256e51f202de/pkg/app/piped/cloudprovider/lambda/client.go#L282
https://github.com/pipe-cd/pipe/blob/d4d222200a9fb5df5c558f9b13c3256e51f202de/pkg/app/piped/cloudprovider/lambda/client.go#L194
I should've mentioned on previous review, but hopefully it helps you.

Thanks for your comment, I will make a separate PR for those fixes 😁

I was taking a walk around the implementation for lambda cloud provider, then I found out this part:
https://github.com/pipe-cd/pipe/blob/d4d222200a9fb5df5c558f9b13c3256e51f202de/pkg/app/piped/cloudprovider/lambda/client.go#L274-L275
Instead it'd better be:
	for version, weight := range cfg.RoutingConfig.AdditionalVersionWeights {
		newerVersionTraffic = percentageToPercent(aws.Float64Value(weight))

Also, as you may know all around here should be replaced with aws.StringValue().
https://github.com/pipe-cd/pipe/blob/d4d222200a9fb5df5c558f9b13c3256e51f202de/pkg/app/piped/cloudprovider/lambda/client.go#L266
https://github.com/pipe-cd/pipe/blob/d4d222200a9fb5df5c558f9b13c3256e51f202de/pkg/app/piped/cloudprovider/lambda/client.go#L282
https://github.com/pipe-cd/pipe/blob/d4d222200a9fb5df5c558f9b13c3256e51f202de/pkg/app/piped/cloudprovider/lambda/client.go#L194
I should've mentioned on previous review, but hopefully it helps you.

Thanks for your comment, I will make a separate PR for those fixes 😁

I was taking a walk around the implementation for lambda cloud provider, then I found out this part:
https://github.com/pipe-cd/pipe/blob/d4d222200a9fb5df5c558f9b13c3256e51f202de/pkg/app/piped/cloudprovider/lambda/client.go#L274-L275
Instead it'd better be:
	for version, weight := range cfg.RoutingConfig.AdditionalVersionWeights {
		newerVersionTraffic = percentageToPercent(aws.Float64Value(weight))

Also, as you may know all around here should be replaced with aws.StringValue().
https://github.com/pipe-cd/pipe/blob/d4d222200a9fb5df5c558f9b13c3256e51f202de/pkg/app/piped/cloudprovider/lambda/client.go#L266
https://github.com/pipe-cd/pipe/blob/d4d222200a9fb5df5c558f9b13c3256e51f202de/pkg/app/piped/cloudprovider/lambda/client.go#L282
https://github.com/pipe-cd/pipe/blob/d4d222200a9fb5df5c558f9b13c3256e51f202de/pkg/app/piped/cloudprovider/lambda/client.go#L194
I should've mentioned on previous review, but hopefully it helps you.

@nakabonne PTAL 😁
https://github.com/pipe-cd/pipe/pull/1464

I was taking a walk around the implementation for lambda cloud provider, then I found out this part:
https://github.com/pipe-cd/pipe/blob/d4d222200a9fb5df5c558f9b13c3256e51f202de/pkg/app/piped/cloudprovider/lambda/client.go#L274-L275
Instead it'd better be:
	for version, weight := range cfg.RoutingConfig.AdditionalVersionWeights {
		newerVersionTraffic = percentageToPercent(aws.Float64Value(weight))

Also, as you may know all around here should be replaced with aws.StringValue().
https://github.com/pipe-cd/pipe/blob/d4d222200a9fb5df5c558f9b13c3256e51f202de/pkg/app/piped/cloudprovider/lambda/client.go#L266
https://github.com/pipe-cd/pipe/blob/d4d222200a9fb5df5c558f9b13c3256e51f202de/pkg/app/piped/cloudprovider/lambda/client.go#L282
https://github.com/pipe-cd/pipe/blob/d4d222200a9fb5df5c558f9b13c3256e51f202de/pkg/app/piped/cloudprovider/lambda/client.go#L194
I should've mentioned on previous review, but hopefully it helps you.

@nakabonne PTAL 😁
https://github.com/pipe-cd/pipe/pull/1464

@nghialv @nakabonne PTAL 🙏

@nghialv @nakabonne PTAL 🙏

Thank you.
/lgtm

Thank you.
/lgtm

🚀
/approve

🚀
/approve

authors: khanhtc1202 nakabonne nghialv

repo: pipe-cd/pipe


text:
Add Helm value to pass kubeconfig

What this PR does / why we need it:
For those whose environment can use neither in-cluster config nor master URL, this is needed.
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?:

NONE

Duplicate to https://github.com/pipe-cd/pipe/pull/1965
/close


text:
Update determine version for s3 stored zip packing lambda deployment

What this PR does / why we need it:
Which issue(s) this PR fixes:
Follow PR #2567
Does this PR introduce a user-facing change?:

NONE

/approve


text:
Django 1.7 changes model registration, breaks test_app.models hack

Sort of a trainwreck, hinging on the fact that the models dictionary in Django 1.7's internals is no longer finding our patched-in test models.  It looks like the models dictionary needs some kind of a refresh after the INSTALLED_APPS hack, before the syncdb (?)
Traceback (most recent call last):
  File "/Users/Kaori/.virtualenvs/dtv3/lib/python3.4/site-packages/django/apps/config.py", line 152, in get_model
    return self.models[model_name.lower()]
KeyError: 'relatedmodel'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/Users/Kaori/.virtualenvs/dtv3/lib/python3.4/site-packages/django/core/serializers/python.py", line 156, in _get_model
    return apps.get_model(model_identifier)
  File "/Users/Kaori/.virtualenvs/dtv3/lib/python3.4/site-packages/django/apps/registry.py", line 190, in get_model
    return self.get_app_config(app_label).get_model(model_name.lower())
  File "/Users/Kaori/.virtualenvs/dtv3/lib/python3.4/site-packages/django/apps/config.py", line 155, in get_model
    "App '%s' doesn't have a '%s' model." % (self.label, model_name))
LookupError: App 'test_app' doesn't have a 'relatedmodel' model.

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/Users/Kaori/.virtualenvs/dtv3/lib/python3.4/site-packages/django/core/serializers/json.py", line 75, in Deserializer
    for obj in PythonDeserializer(objects, **options):
  File "/Users/Kaori/.virtualenvs/dtv3/lib/python3.4/site-packages/django/core/serializers/python.py", line 93, in Deserializer
    Model = _get_model(d["model"])
  File "/Users/Kaori/.virtualenvs/dtv3/lib/python3.4/site-packages/django/core/serializers/python.py", line 158, in _get_model
    raise base.DeserializationError("Invalid model identifier: '%s'" % model_identifier)
django.core.serializers.base.DeserializationError: Invalid model identifier: 'test_app.RelatedModel'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/Users/Kaori/.virtualenvs/dtv3/lib/python3.4/site-packages/django/test/testcases.py", line 182, in __call__
    self._pre_setup()
  File "./datatableview/tests/testcase.py", line 18, in _pre_setup
    super(DatatableViewTestCase, self)._pre_setup()
  File "/Users/Kaori/.virtualenvs/dtv3/lib/python3.4/site-packages/django/test/testcases.py", line 754, in _pre_setup
    self._fixture_setup()
  File "/Users/Kaori/.virtualenvs/dtv3/lib/python3.4/site-packages/django/test/testcases.py", line 907, in _fixture_setup
    'skip_checks': True,
  File "/Users/Kaori/.virtualenvs/dtv3/lib/python3.4/site-packages/django/core/management/__init__.py", line 115, in call_command
    return klass.execute(*args, **defaults)
  File "/Users/Kaori/.virtualenvs/dtv3/lib/python3.4/site-packages/django/core/management/base.py", line 337, in execute
    output = self.handle(*args, **options)
  File "/Users/Kaori/.virtualenvs/dtv3/lib/python3.4/site-packages/django/core/management/commands/loaddata.py", line 60, in handle
    self.loaddata(fixture_labels)
  File "/Users/Kaori/.virtualenvs/dtv3/lib/python3.4/site-packages/django/core/management/commands/loaddata.py", line 90, in loaddata
    self.load_label(fixture_label)
  File "/Users/Kaori/.virtualenvs/dtv3/lib/python3.4/site-packages/django/core/management/commands/loaddata.py", line 141, in load_label
    for obj in objects:
  File "/Users/Kaori/.virtualenvs/dtv3/lib/python3.4/site-packages/django/core/serializers/json.py", line 81, in Deserializer
    six.reraise(DeserializationError, DeserializationError(e), sys.exc_info()[2])
  File "/Users/Kaori/.virtualenvs/dtv3/lib/python3.4/site-packages/django/utils/six.py", line 549, in reraise
    raise value.with_traceback(tb)
  File "/Users/Kaori/.virtualenvs/dtv3/lib/python3.4/site-packages/django/core/serializers/json.py", line 75, in Deserializer
    for obj in PythonDeserializer(objects, **options):
  File "/Users/Kaori/.virtualenvs/dtv3/lib/python3.4/site-packages/django/core/serializers/python.py", line 93, in Deserializer
    Model = _get_model(d["model"])
  File "/Users/Kaori/.virtualenvs/dtv3/lib/python3.4/site-packages/django/core/serializers/python.py", line 158, in _get_model
    raise base.DeserializationError("Invalid model identifier: '%s'" % model_identifier)
django.core.serializers.base.DeserializationError: Problem installing fixture '/Users/Kaori/Projects/Pivotal/django-datatable-view/datatableview/tests/test_app/fixtures/test_data.json': Invalid model identifier: 'test_app.RelatedModel'

Fixed via #99


text:
Render 16 bit RGBA Texture

I'm trying to configure the gl renderer to render unsigned 16 bit RGBA images. I've read the documentation and it seems that all I have to do is extend the PIXI.resources.Resource class and pass it the correct configuration (internalFormat, format, type, etc...).
I'm running into an issue and I have no clue how to debug this. A warning message of this shows up whenever load my page.
WebGL warning: drawElementsInstanced: TEXTURE_2D at unit 0 is of type UINT, but the shader samples as FLOAT.
The sample code is a bit too complicated to post here, but here's the gist of what I'm doing
// this variables are part of the webgl2 enums.
// needed for the resource to know that i'm passing in UInt16 RGBA data.
const UNSIGNED_INT_TYPE = 5125;
const RGBA_INTEGER = 36249;

// Assume this array is filled with UINT16 values in RGBA format.
// width and height are made up for this purposes, assume it'll always match the data array length.
const data = new Uint16Array();
const width = 800;
const height = 800;

// Buffer16RGBAResource is the a custom resource that I've made.
// This class will set the internalFormat to be GL_RGBA16I
const resource = new Buffer16RGBAResource(data, {
    width,
    height,
});

const baseTexture = new BaseTexture(resource, {
    format: RGBA_INTEGER,
    type: UNSIGNED_INT_TYPE,
    scaleMode: PIXI.SCALE_MODES.NEAREST,
});

// Use this texture to pass to the stage / sprite.
const texture = new Texture(baseTexture);

There might be a reason why Pixi.js doesn't support Uint16 or Uint32 data. Maybe someone with more experience with Pixi.js can help me understand why.
Thanks.

First time i try to use those webgl constants.
How its usually done: we take existing webgl example, and put same constants and typed arrays to PixiJS :)
16-bit RGBA... hm, do you mean 16 bit per pixel or you want 5-6-5 stuff?
Imagine that you do it, what value should return texture2D() inside shader? Is it normalized vector4 (0-1), or actual vector4 of ints (0-65535) ?

i'm afraid we need full example. Please make it as simple as possible. zip-file, jsfiddle, or codesandbox is fine

My assumption is that texture2D should return a normalized vec4 (0 -1). I'm pretty new to WebGL, so I'm learning as I go. My buffer is in 16 bit per pixel. The original image is 16-bit grayscale, but I made it into a RGBA format for simplicity sake.

Here's a quick example I forked from this comment
https://jsfiddle.net/w9zsmcbx/
If you open the console, you'll notice the warning message I'm getting.

This is my result, but it doesnt work: https://jsfiddle.net/Hackerham/ydoxj2r7/13/
Because https://github.com/pixijs/pixi.js/blob/dev/packages/core/src/shader/utils/generateUniformsSync.ts#L56 doesnt have usampler2D (need same value as usampler)
You can rebuild pixi with that extra string and test it, I cant test this in a few hours.

Fixed !
https://jsfiddle.net/Hackerham/ydoxj2r7/17/
copy link to pixijs build from this fiddle.

I changed sampler type to usampler2D
/65535.0 inside shader
alphaMode should be NPM (0) , so premultiplyAlpha wont be triggered.

3b. Alternatively: false in corresponding place in upload. This is not recommended because premultiplyTint function somewhere on js side depends on alphaMode.

authors: Mason-Chou ivanpopelyshev


text:
Multiple BitmapFonts with same tint render incorrectly in CanvasRenderer

This is a bit of a strange bug, and I'm assuming it might be related to the fix put in for my last bug in #6764 . It again only occurs in the CanvasRenderer, and only with PIXI v5.3.1. Basically, if you are using two or more BitmapFonts in BitmapTexts with the same value for their tint property, the BitmapText objects using any font except the first BitmapFont will show up scrambled. It seems like they might be using the character information from the first BitmapFont or something? This does not occur if tint is not used.

Expected Behavior
All tinted BitmapText objects render properly, regardless of which BitmapFont they use.
Current Behavior
Only tinted BitmapText objects using the first initialized BitmapFont render properly, if they are using the same tint.
Possible Solution
I imagine it's related to the caching logic in here: https://github.com/pixijs/pixi.js/pull/6764/files#diff-5332f871658531ea1f88558c83f52c4cR129
My instinct would be just to get rid of this conditional and always generate a new _tintedCanvas but I have a pretty naive understanding of this code at present, and I imagine there's a performance hit to just not using a caching mechanism at all here.
Steps to Reproduce

Use Canvas Renderer
Create two or more different BitmapFonts
Create two or more BitmapTexts using the same tint but different BitmapFonts

Environment

pixi.js version: 5.3.1
Browser & Version: current Chrome, Safari, and Firefox
OS & Version: Mac OS 10.14.6
Running Example: https://codepen.io/andrew-luminal/pen/WNrBNzv

@JetLua would you mind taking a look at this?

No problem. I'll keep an eye on it.

authors: JetLua andrew-luminal bigtimebuddy


text:
Fix not respecting target of mouseup events.

Fixes #3466, which was also reported in #3790.
The issue was not looking at the event target on our window listeners for mouseup/pointerup. This change looks at that and emits mouseupoutside/pointerupoutside as appropriate.
For the MockPointer changes, it turns out that target is not a parameter for Events, and is a read only property. It is configurable, however, which is why I am setting the target in a roundabout way.

Looks good. Is there a fiddle that you can demo a before and after?

Before: https://jsfiddle.net/sbxoya8x/
After: https://jsfiddle.net/e7ujs4a0/

These both seem to be using 4.4.4

Ugh, unsaved edits. Link should be fixed now.

authors: andrewstart bigtimebuddy


text:
Removed the ceil'ing of width and height in base texture

As otherwise you lose precision going from one to the other.
Just trying to create some demo's that show up the issue in pixi playground

Grrr, thought this would be an easy one to reproduce - will come back and have a fresh think about why this fixed an issue in my version of the libs and why it's not doing anything here.

As otherwise you lose precision going from one to the other.

Just trying to create some demo's that show up the issue in pixi playground

Grrr, thought this would be an easy one to reproduce - will come back and have a fresh think about why this fixed an issue in my version of the libs and why it's not doing anything here.

Welcome to the X-Files. I told you about extra eps before!

v5: https://www.pixiplayground.com/#/edit/wpSKMBzOgh1zvO6q~_iBw
v5 with this PR: https://www.pixiplayground.com/#/edit/RVnw2iNv3lVmSmNf5kBcA
v4: https://www.pixiplayground.com/#/edit/ZtI5gS5beIhU~UqRTx98b

Tbf, in this test, even v4 gets the height wrong.... works fine with Texture.WHITE

Good examples. My eps doesnt help there: https://www.pixiplayground.com/#/edit/VofrhNr_0CURPAIW2LB49

Codecov Report

Merging #5959 into dev will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##              dev    #5959   +/-   ##
=======================================
  Coverage   70.43%   70.43%
=======================================
  Files         208      208
  Lines       10518    10518
=======================================
  Hits         7408     7408
  Misses       3110     3110

Impacted Files
Coverage Δ

packages/core/src/textures/BaseTexture.js
90.06% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a302f0c...d1d04e4. Read the comment docs.

authors: codecov-io ivanpopelyshev themoonrat


text:
Fix BufferResource/DepthResource.upload()

BufferResource/DepthResource.upload() uses BaseTexture.width/height, but it should be BaseTexture.realWidth/realHeight.
Pre-Merge Checklist

[ ] Tests and/or benchmarks are included
[x] Lint process passed (npm run lint)
[x] Tests passed (npm run test)

Is there a way to unit-testing this, i.e. by checking the glTexture's dimensions?

Thank you @dev7355608 :tada:

authors: SukantPal bigtimebuddy dev7355608


text:
Faq fast follow work

Work done

Animation  on toggle

allow only one section to be open at a time

Reinstitute spanish page to look like old page until we have new translations

There is some wonkiness around the animation and autoclosing sections as pictured below. I will remove the logic to autoclose sections logic so we can keep the animation looking smooth.

repo: pizza-to-the-polls/power-the-polls


text:
[BUG] System.UnauthorizedAccessException

Acknowledgement of preliminary instructions

[x] I have read the preliminary instructions, and I am certain that my problem has not already been addressed.

What problem did you encounter?
System.UnauthorizedAccessException: Access to the path 'C:\Users\Антон\AppData\Local\Bloxstrap\Logs' is denied.
when trying to open bloxstrap.
Recently i changed the name of root of my user and my pc cant find many programs which are using user folder. Any way to fix? I belive its a path problem because i changed username from "Антон" to "Anton"

Duplicate of #1000

repo: pizzaboxer/bloxstrap


text:
🛑 WAY👌 Blog is down

In bd64dc9, WAY👌 Blog (https://wayok.cn) was down:

HTTP code: 0
Response time: 0 ms

Resolved: WAY👌 Blog is back up in 5466c41 after 5 days, 4 hours, 23 minutes.


text:
🛑 WAY👌 Blog is down

In 058bcfe, WAY👌 Blog (https://wayok.cn) was down:

HTTP code: 0
Response time: 0 ms

Resolved: WAY👌 Blog is back up in 7e45187 after 52 minutes.


text:
[Feature Request] To add automatic letsencrypt DNS-01 challenge just like caddy web server

The biggest selling point of caddy web server is the automatic letsencrypt DNS-01 challenge,
the configuration of Caddyfile is very simple:
{
    servers {
        protocols h3
    }
    acme_dns cloudflare <api token>
}

:443, mysite.com:443 {
  respond / "Hello, world!"

}

So I'm expecting this in fullmoon.

I've definitely considered this, but it's likely that HTTP-01 challenge is implemented first (https://letsencrypt.org/docs/challenge-types/). Things are not going to be simple for a couple of reasons: (1) if you look at Caddy's implementation of the cert management, there is a lot of things that need to be handled (with some of them implemented by other libraries, which are not going to be available here), and (2) some of the crypto methods needed to generate certificate-signing-request, signing requests, and a couple of other things (well described here: https://github.com/alexpeattie/letsencrypt-fromscratch#d-option-2-completing-the-dns-01-challenge) need to be added to redbean to allow them to be used from fullmoon.

I found a lua repo that support http-01: https://github.com/fffonion/lua-resty-acme

Yes, but it depends on lua-resty-openssl, which in turn depends on both Lua JIT/FFI (not supported in redbean) and openssl library (not available in redbean either, which is using MbedTLS). It's still useful to have, as it implements the actual packaging. request/response, and the challenge logic, but the underlying crypto methods it uses, still need to be implemented in redbean.

Here is the list of openssl calls from ACME.pm that shows relevant OpenSSL function that may need to be implemented using MbedTLS:
capturex('openssl', ('genrsa', '-out', $_, KEY_SIZE));
capturex('openssl', ('rsa', '-text', '-in', $self->{domain}{account}, '-noout', '-modulus'));
capturex('openssl', ('rsa', '-in', $self->{domain}{account}, '-pubout')));
capturex('openssl', ('dgst', '-sha256', '-binary', '-sign', $self->{domain}{account}, $stf->filename))
capturex('openssl', ('req', '-new', '-outform', 'DER', '-key', $self->{domain}{key}, '-config', $oct->filename, '-out', $self->{req}{csr}));

authors: diyism pkulchenko

repo: pkulchenko/fullmoon


text:
support vec/array impl for DnsResolver

It would allow you to chain multiple dns resolvers together, where it would try the next in case of error.
Note that this should not be used just to use multiple dns providers, as that can be configured already in a single resolver (eg Hickory)

@parkma99 is picking this up

This issue is available once again. Feel free to start from scratch or use @parkma99's original attempt as a starting point. All the same, whatever works best for the one picking this issue up.

This issue is available once again. Feel free to start from scratch or use @parkma99's original attempt as a starting point. All the same, whatever works best for the one picking this issue up.

I'd like to pick this up

All yours @NOOMA-42 , let me know if you need guidance, help or feedback

repo: plabayo/rama


text:
Documentation typo

There is a typo in the documents at http://spotipy.readthedocs.io/en/latest/#authorization-code-flow
util.prompt_for_user_token(username,scope,client_id='your-app-redirect-url',client_secret='your-app-redirect-url',redirect_uri='your-app-redirect-url')
Should be...
util.prompt_for_user_token(username,scope,client_id='your-app-client-id',client_secret='your-app-client-secret',redirect_uri='your-app-redirect-url')
Or to be clearer to new programmers you could have...
clientID = 'Paste your client ID here'
clientSecret = 'Paste your client secret here'
redirectURL = 'Paste your redirect url here'  # We/Spotify suggest http://localhost:8888/callback/ or http://localhost/

token = util.prompt_for_user_token(username,scope,client_id='your-app-client-id',client_secret='your-app-client-secret',redirect_uri='your-app-redirect-url')

Doc is now fixed

authors: Hurstwood stephanebruckert

repo: plamere/spotipy


text:
Rename mixed unmixed accounts after manual setup

After manual setup of cspp the accounts are not currently renamed. Auto setup does rename the accounts.

By default, when auto setting up the mixer accounts, the default account name is Mixed and unmixed and these can also renamed from mixed and unmixed to any name of your choice.
What manual setup does is enable the user decide which account to use for the set up rather than the automatic account creation.
Manual set up removes the option of creating additional accounts.
After pointing to the desired accounts, the user can choose to rename it or leave it so.

Yeah, what sirmorrison has explained is correct

This is so that instead of having to remember that account-1 is unmixed for example, it will say unmixed in the UI instead of account-1. It makes it more intuitive to use godcr once privacy has been enabled, so that you know exactly what account you're looking at when using the functions. It would be identical to renaming the account in the wallet view, but done automatically based on what the user mapped.

authors: Sirmorrison dreacot monsa00

repo: planetdecred/godcr

license: ISC


text:
Send page cleanup

Move send page to it's package and separate send page code into modules package
Cleanup tx validate and construct code
Change send max button background to indicate active state

Clicking any of the max buttons changes both of them to blue colour as in the screenshot above. They should always be grey with the background #3D5873.
Clicking the cancel button to close the page doesn't work.
How to reproduce

from the overview page, click the send button on the top nav to open the send page
click the cancel button to attempt to close the send page

Expected Behaviour
The page should change back to the overview page
What happens
The application view remains on the send page.

authors: C-ollins oshorefueled


text:
Inconsistent Boolean Representation

The ILVM interpreter returns "1" corresponding to "true" for binary operators "==" & "<". However, the "ifz" instruction evaluates the true-branch on "0". The simple program included below exhibits this behavior.
block 0 {
r0 = 0 == 0;
ifz r0 {
  exit(0);
} else {
  exit(1);
}
}

I believe that is intended behavior. ifz stands for "if zero", so it evaluates the first branch if the condition is 0.

repo: plasma-umass/ilvm


text:
Specific build_flags in [env:*] cause PlatformIO runtime error.

I've found a fault in how PlatformIO processes CCFLAGS-modifying options in the build_flags environment section of platformio.ini.
I've attached a brief overview of my system, my platformio.ini file, and the log of platformio run's output.
https://gist.github.com/myrrlyn/c1f3a2fd5e6a8d0ef613

If you use PlatformIO IDE, please click on Gear(Settings) icons, Community Packages > platformio-ide > Settings > Use development version of PlatformIO.

Please re-test it.

Also, build_flags = -include Arduino.h will raise error. That is OK, because you are going "to insert" into EACH build file "Arduino.h" which raises conflicts.

authors: ivankravets myrrlyn

repo: platformio/platformio


text:
Area light in editor engine fixes/changes

Engine changes needed to work with editor changes to expose area lights:

no public APIs changed
area light luts are now in a versioned binary format asset, that can is set on a project setting for editor projects, and for engine only projects can be loaded and set on the app
engine example adjusted to use binary asset
also some other small fixes to correspond with editor PR

I confirm I have signed the Contributor License Agreement.

What's the size of zipped up binary file vs zipped up .js file from betore?

What's the size of zipped up binary file vs zipped up .js file from betore?

This engine example is so much better showcasing area lights.
If you adjust VSM shadow to lower resolution with higher blur, it will look softer. And probably some various colors for light sources will do a nice color mixings on illuminated parts.
Long slim area light sources - are good to showcase area lights, like ceiling lights.

This engine example is so much better showcasing area lights.
If you adjust VSM shadow to lower resolution with higher blur, it will look softer. And probably some various colors for light sources will do a nice color mixings on illuminated parts.
Long slim area light sources - are good to showcase area lights, like ceiling lights.

What's the size of zipped up binary file vs zipped up .js file from before?

binary zips to 102kb and js zips to 109kb on my machine - so pretty close when zipped.

What's the size of zipped up binary file vs zipped up .js file from before?

binary zips to 102kb and js zips to 109kb on my machine - so pretty close when zipped.

What's the size of zipped up binary file vs zipped up .js file from before?

binary zips to 102kb and js zips to 109kb on my machine - so pretty close when zipped.

What's the size of zipped up binary file vs zipped up .js file from before?

binary zips to 102kb and js zips to 109kb on my machine - so pretty close when zipped.

And one more question (or two):

have you stripped out those unused zeros from lut2?
how do we re-generate this binary file if we need to do changes in the future .. is there some tool you wrote that we can use?

And one more question (or two):

have you stripped out those unused zeros from lut2?
how do we re-generate this binary file if we need to do changes in the future .. is there some tool you wrote that we can use?

This engine example is so much better showcasing area lights.

Nice and easy to set up in the editor :)

If you adjust VSM shadow to lower resolution with higher blur, it will look softer. And probably some various colors for light sources will do a nice color mixings on illuminated parts.

I wasn't able to get good blurry shadow results using VSMs - I just got thinner shadows with more leaking - maybe something that would help is negative bias? I will investigate further.

Long slim area light sources - are good to showcase area lights, like ceiling lights.

I'll try adding add some to my test scenes.

Also, if you add outside walls, then shadows will not leak light in corners: https://developer.playcanvas.com/en/user-manual/graphics/lighting/lightmapping/#other-tips

Updated the scene remove light leaking and updated the image

This engine example is so much better showcasing area lights.

Nice and easy to set up in the editor :)

If you adjust VSM shadow to lower resolution with higher blur, it will look softer. And probably some various colors for light sources will do a nice color mixings on illuminated parts.

I wasn't able to get good blurry shadow results using VSMs - I just got thinner shadows with more leaking - maybe something that would help is negative bias? I will investigate further.

Long slim area light sources - are good to showcase area lights, like ceiling lights.

I'll try adding add some to my test scenes.

Also, if you add outside walls, then shadows will not leak light in corners: https://developer.playcanvas.com/en/user-manual/graphics/lighting/lightmapping/#other-tips

Updated the scene remove light leaking and updated the image

And one more question (or two):

have you stripped out those unused zeros from lut2?

Haven't yet - didn't want to change your texture gen code until got other things working.

how do we re-generate this binary file if we need to do changes in the future .. is there some tool you wrote that we can use?

I wrote a small script - I'll include it in this PR.

And one more question (or two):

have you stripped out those unused zeros from lut2?

Haven't yet - didn't want to change your texture gen code until got other things working.

how do we re-generate this binary file if we need to do changes in the future .. is there some tool you wrote that we can use?

I wrote a small script - I'll include it in this PR.

Should we perhaps rename luts.bin to something like area-lights-luts.bin?

Should we perhaps rename luts.bin to something like area-lights-luts.bin?

I added few small comments, looks good otherwise!

I added few small comments, looks good otherwise!

I've just realized the problem we had when the float LUT texture was the preferred option and it didn't work on iOS. We use float texture together with linear filtering, and so in addition to extTextureFloat we also need to test extTextureFloatLinear - could you please make this change when this._areaLightLutFormat is initialized. And perhaps change it to this.areaLightLutFormat (remove _) to match other capabilities .. like this.textureFloatRenderable or this.supportsMorphTargetTexturesCore and similar. @raytranuk

I've just realized the problem we had when the float LUT texture was the preferred option and it didn't work on iOS. We use float texture together with linear filtering, and so in addition to extTextureFloat we also need to test extTextureFloatLinear - could you please make this change when this._areaLightLutFormat is initialized. And perhaps change it to this.areaLightLutFormat (remove _) to match other capabilities .. like this.textureFloatRenderable or this.supportsMorphTargetTexturesCore and similar. @raytranuk

I've just realized the problem we had when the float LUT texture was the preferred option and it didn't work on iOS. We use float texture together with linear filtering, and so in addition to extTextureFloat we also need to test extTextureFloatLinear - could you please make this change when this._areaLightLutFormat is initialized. And perhaps change it to this.areaLightLutFormat (remove _) to match other capabilities .. like this.textureFloatRenderable or this.supportsMorphTargetTexturesCore and similar. @raytranuk

I've added extTextureFloatLinear checks - I'm getting some strange results on my iPhone - I will investigate further.

I've just realized the problem we had when the float LUT texture was the preferred option and it didn't work on iOS. We use float texture together with linear filtering, and so in addition to extTextureFloat we also need to test extTextureFloatLinear - could you please make this change when this._areaLightLutFormat is initialized. And perhaps change it to this.areaLightLutFormat (remove _) to match other capabilities .. like this.textureFloatRenderable or this.supportsMorphTargetTexturesCore and similar. @raytranuk

I've added extTextureFloatLinear checks - I'm getting some strange results on my iPhone - I will investigate further.

I've added extTextureFloatLinear checks - I'm getting some strange results on my iPhone - I will investigate further.

After upgrading to iOS 14.4 it works as expected.

I've added extTextureFloatLinear checks - I'm getting some strange results on my iPhone - I will investigate further.

After upgrading to iOS 14.4 it works as expected.

I've just realized this .. the version should be the first two int16s in the file, not the last? How can you change the file when the version is at fixed offset from start? It would be it impossible to make the file smaller.

I should have realized this - sorry about that - now versions are correctly at the beginning of the binary (like pretty much every other binary format out there...)

I've just realized this .. the version should be the first two int16s in the file, not the last? How can you change the file when the version is at fixed offset from start? It would be it impossible to make the file smaller.

I should have realized this - sorry about that - now versions are correctly at the beginning of the binary (like pretty much every other binary format out there...)

authors: Maksims mvaligursky raytranuk

repo: playcanvas/engine


text:
[JVM] Publish next releases to release repository (fixed versions)

📦 Published PR as canary version: 0.7.5--canary.428.14992

Try this version out locally by upgrading relevant packages to 0.7.5--canary.428.14992

/canary

/canary

/canary

/canary

repo: player-ui/player


text:
[Bug] False throw of valid-title

Let's have following test file
import { TestDetails, test } from '@playwright/test'

test.describe('Suite', () => {
  async function makeTest (testTitle: string, testOptions: TestDetails, urlPath: string) {
    test(testTitle, testOptions, async ({ page }) => {
      await page.goto('www.mywebsite.com/' + urlPath, { waitUntil: 'load' })
    })
  }

  makeTest('Test1', { tag: ['@smoke'] }, 'url_path_1')
  makeTest('Test2', { tag: ['@smoke'] }, 'url_path_2')
  makeTest('Test3', { tag: ['@smoke'] }, 'url_path_3')
})

I get this error

which is wrong regarding docs https://github.com/playwright-community/eslint-plugin-playwright/blob/main/docs/rules/valid-title.md

package
version

eslint-plugin-playwright
1.6.2

@playwright/test
1.44.0

@MartinPilny This is not a bug. The Playwright ESLint plugin does not have type information from TypeScript, so it must rely solely on static analysis. Your code is a correct error according to the plugin and should be explicitly ignored with an ESLint disable comment.

authors: MartinPilny mskelton


text:
CRA example

What do you think about creating an example with usage of create-react-app? I can make PR)

What do you think about creating an example with usage of create-react-app? I can make PR)

sounds good!

@mxschmitt I've got configured this repo but for now IDK how can I add this to your example. What do you think?

Looks awesome, I would maybe remove the service worker stuff. otherwise its super!

@mxschmitt I think we can close it

authors: mmarkelov mxschmitt


text:
Implement multi-version documentation

Implement versioning in the documentation so user can check old versions of an API also.
Documentation for a version is generated on official builds only. The documentation should be pushed to a different branch.

It would be better to migrate to Docusaurus. It's modern and support versioning.

Decision is to stick to DocFX with the modern template. It should be possible to support versioning in DocFX although it's not easy. But as Docusuarus says it's not recommended for most projects to do it.

Closing as it's not recommended for most projects. A single document explaining what features are available in what version should simplify.


text:
Tool for adding texture

Sometimes we need to be able to wrap a picture around a shape:
addTexture.py --input <input_file> [--ascii] --output <output_file> --texture <texture_file>

addTexture.py --input [--ascii] --output --texture <texture_file>

There should be a <texture_file> argument following --texture. The texture file should be a png, gif, or jpeg file.

Done

repo: pletzer/icqsol


text:
Feature/includes

Hey this pr closes issue https://github.com/plexis-js/plexis/issues/93

Hey @Nauthiz-Jera, thanks for contributing. Neat approach and solution.

authors: Nauthiz-Jera vorillaz

repo: plexis-js/plexis


text:
Updating license

Describe your changes
This updates the license while including the original notice.
Issue ticket number and link
Closes #x
Checklist before requesting a review

[x] I have performed a self-review of my code
[x] I have added thorough tests (when necessary).
[x] I have added the right documentation in the docstring and changelog (when needed)

:books: Documentation preview :books:: https://jupysql--198.org.readthedocs.build/en/198/

On viewing the license file this still shows MIT License. Will this update after the merge?

How about here? Need to change to Apache?
https://github.com/ploomber/jupysql/pull/198/files#diff-60f61ab7a8d1910d86d9fda2261620314edcae5894d5aaa236b821c7256badd7R66

Looks good!

authors: idomic neelasha23 tonykploomber

repo: ploomber/jupysql


text:
Add R Snippet

Hi @rpkyle , I added this R snippet (the same python snippet is right above). If you have time could you take a look?

This is the python snippet:
import dash
import dash_vtk
import dash_html_components as html

app = dash.Dash(__name__)

app.layout = html.Div(
    style={"width": "100%", "height": "calc(100vh - 16px)"},
    children=dash_vtk.View([
        dash_vtk.GeometryRepresentation([
            dash_vtk.Algorithm(
                vtkClass="vtkConeSource",
                state={"resolution": 64, "capping": False},
            )
        ]),
    ]),
)

if __name__ == "__main__":
    app.run_server(debug=True)

This is the python snippet:
import dash
import dash_vtk
import dash_html_components as html

app = dash.Dash(__name__)

app.layout = html.Div(
    style={"width": "100%", "height": "calc(100vh - 16px)"},
    children=dash_vtk.View([
        dash_vtk.GeometryRepresentation([
            dash_vtk.Algorithm(
                vtkClass="vtkConeSource",
                state={"resolution": 64, "capping": False},
            )
        ]),
    ]),
)

if __name__ == "__main__":
    app.run_server(debug=True)

@rpkyle @alexcjohnson I removed all the old py/R/Rd/jl files, and the NAMESPACE was also regenerated (see PR https://github.com/plotly/dash-vtk/pull/11) This is the new namespace; would the new syntax be vtkView or dashVtk::vtkView?

@rpkyle @alexcjohnson I removed all the old py/R/Rd/jl files, and the NAMESPACE was also regenerated (see PR https://github.com/plotly/dash-vtk/pull/11) This is the new namespace; would the new syntax be vtkView or dashVtk::vtkView?

@rpkyle @alexcjohnson I removed all the old py/R/Rd/jl files, and the NAMESPACE was also regenerated (see PR #11) This is the new namespace; would the new syntax be vtkView or dashVtk::vtkView?

:medal_sports: Either works, but the latter is often used when a package is not attached to the current session, or to avoid namespace collisions (which we had before with utils::View and dashVtk::View). We can just leave references to vtkView as is, assuming we've already invoked library(dashVtk) earlier in the code.

@rpkyle @alexcjohnson I removed all the old py/R/Rd/jl files, and the NAMESPACE was also regenerated (see PR #11) This is the new namespace; would the new syntax be vtkView or dashVtk::vtkView?

:medal_sports: Either works, but the latter is often used when a package is not attached to the current session, or to avoid namespace collisions (which we had before with utils::View and dashVtk::View). We can just leave references to vtkView as is, assuming we've already invoked library(dashVtk) earlier in the code.

@rpkyle Thanks, I pushed the new demo:
library(dash)
library(dashVtk)
library(dashHtmlComponents)

layout <- htmlDiv(
    style = list("width" = "100%", "height" = "calc(100vh - 16px)"),
    children = vtkView(list(
        vtkGeometryRepresentation(
            vtkAlgorithm(
                vtkClass = "vtkConeSource",
                state = list("resolution" = 64, "capping" = FALSE),
            )
        )
    ))
)

app <- Dash$new()

app$layout(layout)

app$run_server()

@rpkyle Thanks, I pushed the new demo:
library(dash)
library(dashVtk)
library(dashHtmlComponents)

layout <- htmlDiv(
    style = list("width" = "100%", "height" = "calc(100vh - 16px)"),
    children = vtkView(list(
        vtkGeometryRepresentation(
            vtkAlgorithm(
                vtkClass = "vtkConeSource",
                state = list("resolution" = 64, "capping" = FALSE),
            )
        )
    ))
)

app <- Dash$new()

app$layout(layout)

app$run_server()

@rpkyle Thanks, I pushed the new demo:

@xhlulu Cool, it works for me as well! I'd recommend rewriting this as
app <- Dash$new()

app$layout(htmlDiv(
    style = list("width" = "100%", "height" = "calc(100vh - 16px)"),
    children = vtkView(list(
        vtkGeometryRepresentation(
            vtkAlgorithm(
                vtkClass = "vtkConeSource",
                state = list("resolution" = 64, "capping" = FALSE),
            )
        )
    ))
))

app$run_server()

@rpkyle Thanks, I pushed the new demo:

@xhlulu Cool, it works for me as well! I'd recommend rewriting this as
app <- Dash$new()

app$layout(htmlDiv(
    style = list("width" = "100%", "height" = "calc(100vh - 16px)"),
    children = vtkView(list(
        vtkGeometryRepresentation(
            vtkAlgorithm(
                vtkClass = "vtkConeSource",
                state = list("resolution" = 64, "capping" = FALSE),
            )
        )
    ))
))

app$run_server()

Looks good to me! :woman_dancing:

Looks good to me! :woman_dancing:

authors: rpkyle xhlulu

repo: plotly/dash-vtk


text:
🛑 My Grafana dashboard is down

In 6c62a1c, My Grafana dashboard (https://$UPPTIME_GRAFANA) was down:

HTTP code: 0
Response time: 0 ms

Resolved: My Grafana dashboard is back up in 744fb0f.


text:
🛑 My Grafana dashboard is down

In 010cdf4, My Grafana dashboard (https://$UPPTIME_GRAFANA) was down:

HTTP code: 0
Response time: 0 ms

Resolved: My Grafana dashboard is back up in 2d9c704.


text:
🛑 KCG is down

In 531570b, KCG (https://kunstrijclubgroningen.nl) was down:

HTTP code: 0
Response time: 0 ms

Resolved: KCG is back up in 647085a after 10 minutes.


text:
🛑 Dick Pluim.com is down

In 716ff71, Dick Pluim.com (https://dickpluim.com) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Dick Pluim.com is back up in d7c1ec7 after 46 minutes.


text:
🛑 Dick Pluim.com is down

In 48f773d, Dick Pluim.com (https://dickpluim.com) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Dick Pluim.com is back up in feb2695 after 22 minutes.


text:
Seek the write buffer to zero after flushing

While .truncate(0) is called on the buffer object
after writing, this won't reset the current position
to zero. Subsequent writes will therefore just keep
extending the buffer and writing more and more data.
The fix is pretty simple -- .seek(0) after truncating.
It looks like this will come up any time an avro file
grows past 64,000 bytes (i.e., SYNC_INTERVAL bytes).

Good catch! I no longer have write access to the repo so I can't merge it (I'm no longer with Pluralsight, so I'll see if someone there can do it for us). All of the use cases for Spavro I'm aware of have used the streaming interface instead of the files interface, but I'm still surprised no one hit this in python 3.
I think it might be worth it to review and or merge some of the new upstream work happening in the Apache python code. That repo was quiet for years but apparently they've recently (last 2 years) started making fixes (including updating for py3).
The new datafile.py in the latest repo has this same fix in it: https://github.com/apache/avro/commit/4cd778a7e0de048eacf2a06abe3d0e310bbcc343#diff-18c6af8dbfc695c7321667a85214b2cfR252
Anyway, thanks for the help and PR!

Merging - Thanks for bringing this to my attention, @mikepk !

Great, thanks guys! @mikepk, thanks for ushering it in so quickly and @tenth10th thanks for merging!

If I may impose once more, would you mind cutting a release so we can grab this version from pypi?

Ok pushed 1.1.23... although I'm a little suspicious my build script didn't work (it's got some cobwebs on it). Let me know if it looks OK.

authors: JohnEmhoff mikepk tenth10th

repo: pluralsight/spavro


text:
Script works but doesn't take effect

Great script works like a charm! however my rtx3070s worked by changing [3] by [4] in the commands like:
log "$(nvidia-settings -c :0 -a '[gpu:0]/GPUGraphicsClockOffset[4]=-500' -a '[gpu:0]/GPUMemoryTransferRateOffset[4]=2400')"
As an additional note, in order to get the startx running lightdm must be purged previously...

Yes, depending on your graphics card it turns out the array value may be different.  I probably won't update the script to do any kind of auto detection or removal of lightdm, but I can add these to the README as additional pieces of documentation.

perfect! great work and thanks for sharing again!

I had to do this:
nvidia-settings -a [gpu:0]/GPUMemoryTransferRateOffsetAllPerformanceLevels=2000 -a [gpu:0]/GPUGraphicsClockOffsetAllPerformanceLevels=-300
otherwise it just errored out on my RTX 2060

authors: ahnick fedesuarez79 iopq


text:
parameterized paths

Sometimes a parameter appears in the middle of a path, e.g.:
/users/{user_id}/profile
/users/{user_id}/friends
/users/{user_id}/preferences

The filesystem based routing scheme doesn't currently accommodate this use case well. Ideally we would model the above like so:
- users
   - user_id
       - friends.js
       - preferences.js
       - profile.js

But that will only match these URLs
/users/user_id/friends
/users/user_id/preferences
/users/user_id/profile

Whereas we want it to match URLs that look like this:
/users/12345/friends
/users/12345/preferences
/users/12345/profile

/users/86753/friends
/users/86753/preferences
/users/86753/profile

/users/99999/friends
/users/99999/preferences
/users/99999/profile

We need a way to identify that the user_id directory is a wildcard, not meant to be matched literally. Where would be the right place to encode that information? How about in user.js?
- users
   - user_id
       - friends.js
       - preferences.js
       - profile.js
- users.js <--- here

// users.js
const USER_ID_REGEX = /^\d{3,10}$/;

export function wildcard(key) {
   if(USER_ID_REGEX.test(key) {
       return 'user_id';
   }
   return key;
}

When parsing the URL /users/99999/profile, Counterfact will look at users.js and find that it has a wildcard function. Since "99999" is a valid user ID, it will next look for ./users/user_id.js and ./users/user_id/profile.js instead of ./users/99999.js and ./users/99999/profile.js
Profile.js will then look something like this:
//profile.js

export function GET({path, store}) {
   return {
      body: `User profile for ${path.user_id}: ${store.users[path.user_id].profile}`
   }
}

export function PUT({path, store, body}) {
    store.users[path.user_id].profile = body;
   return {
      body: `ok`
   }
}

Here's the new logic to look up the most specific matching GET/POST/PUT/PATCH/DELETE function. (I have not tested this code. It's a spike that I plan to rewrite with TDD.)
 endpoint(method, url) {
    function findHandler(tree, path, fallback) {
      const handler = tree.script?.[method] ?? fallback;

      if (path.length === 0) {
        return handler;
      }

      if (tree.children[path[0]]) {
        return findHandler(tree.children[path[0]], path.slice(1), handler);
      }

      const wildcard = tree.script?.wildcard?.(path[0]);

      if (wildcard) {
        return findHandler(wildcard, path.slice(1), handler);
      }

      return handler;
    }

    function notFoundFallback() {
      return {
        status: 404,
        body: `${method} method for endpoint at "${url}" does not exist`,
      };
    }

    return findHandler(
      this.moduleTree,
      url.split("/").slice(1),
      notFoundFallback
    );
  }

Im not sure if you've ever seen how next.js does this, but I really like it. https://nextjs.org/docs/routing/dynamic-routes

Oh, that's nice! Yeah I think I'm gonna steal that instead.

A incomplete and buggy implementation of next.js style routes: #2

I think I may have made this harder than it needs to be. With the current implementation, when Counterfact recieves a request for GET /foo/bar/baz, it will look for a GET function in ./foo/bar/baz.js. If it doesn't find one it will look in ./foo/bar.js and ./foo.js
With next.js style routing, we don't need to support that fallback pattern, and that should make the code a lot simpler.

This is "done" in the main branch now. (Still need to add more tests, update docs, and update the demo app.)

Docs and demo app are updated and I created #25 for tests.

authors: KameronKales pmcelhaney

repo: pmcelhaney/counterfact


text:
⚠ Slack has degraded performance

In 81f3fd0, Slack (https://status.slack.com/api/v2.0.0/current) experienced degraded performance:

HTTP code: 200
Response time: 77 ms

Resolved: Slack performance has improved in 678a153.

repo: pmmmwh/upptime


text:
fix: throw when useFiber is used without a FiberProvider

I spent some time debugging why my app (which uses useContextBridge) wasn't working in production, the reason was I didn't have a FiberProvider. This might be a breaking change so I can of course change it, but would it be possible to add some kind of error or warning when there's no FiberContext? Is there any reason it should not throw?

I removed this during the Codesandbox outage where package.exports wasn't resolved correctly and this error kept confusing people as React was merely mismatched. We can safely add it back, sorry to see that it was needed in the intervening time.

All good, I aligned it with previous changes w/tests.

authors: CodyJasonBennett hansottowirtz

repo: pmndrs/its-fine


text:
Purge jsx files

Right now when you make a production build the styles from Tailwind gets lost since the incorrect files are getting purged

Ah! that was that! Nice catch thank you 😊

authors: RenaudRohlinger emaLorenzo

repo: pmndrs/react-three-next


text:
Include response output: aad commands

Related to #3754

Add the response output for all the commands under the service:

aad documentation location

Be sure to include all the output types: JSON, Text, CSV, and Markdown.
You can reference the commands planner plan and planner bucket. They are already contain the Response heading in their documentation.
For more information what guidelines to follow, be sure to check out the epic issue #3754

Could I be assigned to this issue?

All yours @Saurabh7019. I would suggest not yet starting your work. We'll be changing our docs framework soon and the syntaxes will look a little different.

@appieschot, I got a question from @Saurabh7019 regarding the command aad user hibp. Seems like this command requires an API key which you have to purchase. Since you created this command, do you still have an API key we can use to add the response of the command to the docs?

authors: Jwaegebaert Saurabh7019 milanholemans


text:
Extends commands "teams team remove", "teams team archive", and "teams team unarchive" to add an extra option to get to the correct team. Closes #3483

Extends commands teams team remove, teams team archive, and teams team unarchive to add an extra option to get to the correct team. Closes #3483

Thank you @nanddeepn! We'll review it asap

Thank you very much. Looks good. Manually merged.
Created issue #3502 to track the removal of the teamId property in the v6 release.
Cheers

authors: nanddeepn plamber waldekmastykarz


text:
Refactor spo file move to use util instead of calling other command, Closes #5260

Closes #5260

Thanks for another awesome PR 💪👍. You are on 🔥 today. We will review it ASAP

Because of this issue: https://github.com/pnp/cli-microsoft365/issues/5302, I'm wondering if it's worth it to still process this PR. The entire command will be written from scratch in our v7 release.

Because we are in a code freeze now and the next release will be v7, there's not really a point anymore to merge this PR. The whole command was written from scratch in v7.
I'm sorry for this, but let's close this PR, Nico.

authors: Adam-it milanholemans nicodecleyre


text:
New Asset is Grey out

I'm trying to add a new asset in the Playlist Asset Section of the CustomLearningAdmin.aspx page but the "New Asset" button is greyed out.  is this a bug or is there something I need to enable? thanks.

never mind, i figured it out


text:
[BUG] Set-PnPPageTextPart : CSOM service exception

Reporting an Issue or Missing Feature
Set-PnPPageTextPart  command is throwing error when I try to set client side text webpart through PowerShell.
Expected behavior
The webpart text should be set with the text passed to the command.
Actual behavior
Getting this error: Set-PnPPageTextPart : CSOM service exception
A more detailed exception is thrown using Azure Function:
ERROR: CSOM service exception Exception : Type : PnP.Core.CsomServiceException Error : HttpResponseCode: 200 Message: Column 'OData__AuthorByline' does not exist. It may have been deleted by another user. /sites/mytestsite/SitePages ClientRequestId: 6fb4c29f-a0e5-2000-c487-16bb23dcb45e ErrorTypeName: "System.ArgumentException" TargetSite : Name : ProcessCsomBatchResponse DeclaringType : PnP.Core.Services.BatchClient, PnP.Core, Version=1.1.27.0, Culture=neutral, PublicKeyToken=null MemberType : Method Module : PnP.Core.dll StackTrace : at PnP.Core.Services.BatchClient.ProcessCsomBatchResponse(CsomBatch csomBatch, String batchResponse, HttpStatusCode statusCode) at PnP.Core.Services.BatchClient.ExecuteCsomBatchAsync(Batch batch) at PnP.Core.Services.BatchClient.ExecuteBatch(Batch batch) at PnP.Core.Model.BaseDataModel1.RequestAsync(ApiCall apiCall, HttpMethod method, String operationName) at PnP.Core.Model.BaseDataModel1.RawRequestAsync(ApiCall apiCall, HttpMethod method, String operationName) at PnP.Core.Model.SharePoint.ListItem.SystemUpdateAsync() at PnP.Core.Model.SharePoint.Page.SaveAsync(String pageName) at PnP.Core.Model.SharePoint.Page.Save(String pageName) at PnP.PowerShell.Commands.Pages.SetClientSideText.ExecuteCmdlet() in D:\a\powershell\powershell\src\Commands\Pages\SetPageTextPart.cs:line 36 at PnP.PowerShell.Commands.PnPSharePointCmdlet.ProcessRecord() in D:\a\powershell\powershell\src\Commands\Base\PnPSharePointCmdlet.cs:line 60 Message : CSOM service exception Data : System.Collections.ListDictionaryInternal Source : PnP.Core HResult : -2146233088 CategoryInfo : WriteError: (:) [Set-PnPPageTextPart], CsomServiceException FullyQualifiedErrorId : EXCEPTION,PnP.PowerShell.Commands.Pages.SetClientSideText ErrorDetails : CSOM service exception InvocationInfo : MyCommand : Set-PnPPageTextPart ScriptLineNumber : 82 OffsetInLine : 9 HistoryId : 1 ScriptName : C:\home\site\wwwroot\TestFunc\run.ps1 Line : Set-PnPPageTextPart -Page $newPage -InstanceId $textControl.InstanceId -Text $translatedControlText PositionMessage : At C:\home\site\wwwroot\TestFunc\run.ps1:82 char:9 + Set-PnPPageTextPart -Page $newPage -InstanceId $textControl.I … + ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ PSScriptRoot : C:\home\site\wwwroot\TestFunc PSCommandPath : C:\home\site\wwwroot\TestFunc\run.ps1 InvocationName : Set-PnPPageTextPart CommandOrigin : Internal ScriptStackTrace : at , C:\home\site\wwwroot\TestFunc\run.ps1: line 82 PipelineIterationInfo :
Steps to reproduce behavior
$newPage = Get-PnPClientSidePage "testpage.aspx"
$textControls = $newPage.Controls | Where-Object {$_.Type.Name -eq "PageText"}
$text = "Hello, this is a sample text"
foreach ($textControl in $textControls){
Set-PnPPageTextPart -Page $newPage -InstanceId $textControl.InstanceId -Text $text
}
What is the version of the Cmdlet module you are running?
(you can retrieve this by executing Get-Module -Name "PnP.PowerShell" -ListAvailable)
1.5.27     PnP.PowerShell
Which operating system/environment are you running PnP PowerShell on?

[x ] Windows
[ ] Linux
[ ] MacOS
[ ] Azure Cloud Shell
[ ] Azure Functions
[ ] Other : please specify

I am having the same CSOM Exception when trying to us Invoke-PnPBatch as well. I wonder if they are related

@280237 / @prawnz : I've been able to reproduce and fix this in PnP Core SDK. Issue was due to the fact that we did not correctly handle the odata field name prefixing: when a field starts with an _ that underscore is replaced by OData__ when doing certain SPO rest queries. CSOM however needs the normal field name, so that's why this went wrong.
@prawnz : if you can run get-pnpexception after you see the error that can possibly also clarify if this is also related to an _ field. If not maybe best to create a dedicated issue with more details.

Wait for the nightly build of the coming night, so you should be able to test this tomorrow

Closing it as the fix is available in the nightly build.

authors: 280237 gautamdsheth jansenbe prawnz

repo: pnp/powershell


text:
 Add properties for default library- & folderPath for

Category

[x] Enhancement

Version
3.1.0
Desired Behavior
It would be great if the <FilePicker/> could accept a property/properties for setting a default selected library and folder which would apply to the <SiteFilePicker/> child.
Implementation
I'm up for submitting a Pull Request and I might even take a look into #725 while I'm at it as a multiple file select is applicable for my use case as well.
Right now I'm thinking of just giving a single property named defaultFolderAbsolutePath (perhaps with a suffix to indicate its intention for the SiteFilesTab) and parse it in the <SiteFilePickerTab/>  constructor for the state variables (and breadcrumb ofc).

For anyone interested I've started working on this here, I've added one commit for the initial logic of parsing the string property "defaultFolderAbsolutePath". Next up is to add everything to the breadcrumb to preserve current functionality. Feel free to comment.

@Katli95 Both are great suggestions!
Also, the FilePicker control was recently updated to return an array of results (instead of a single file) so this should make things easier to enable the selection of multiple files.
I have assigned this issue to you so others know it's already being addressed and we avoid duplication of effort.
Let me know if you need any help

@joelfmrodrigues awesome! Thank you, no need for help as is, just a question: do you have an idea of how long it may take to get this released once I submit? I'm working on a project atm that requires this feature 😇

It should not take long to review the PR, and after it's merged a new beta version is automatically created and published to npm so you can install it and then update later to a major release.
PRs from the last last 2-3 weeks have been delayed a bit as only Alex was able to review them but things should be better now as I was able to close 3 projects this week and can focus on this again😊

Awesome, glad to hear it! How free should I feel to generally refactor the code? (Nothing major ofc, but somehting like changing variable names and removing obsolete code?

@Katli95 Ideally, try to only modify the code that is relevant and necessary to what you are implementing. This is a common approach with many open source projects as otherwise code reviews would be more complex and someone else implementing features on related code could be impacted and have to deal with code conflicts, etc. If for example, you move a block of code, it's all marked as a change in the code review and impossible to identify if something changes unless we compare line by line. Even something simple like letting VS Code format an entire document can cause a lot of changes in the pull-request and is discouraged.
Please check the Do's and Dont's section of the documentation:
https://pnp.github.io/sp-dev-fx-controls-react/guides/contributing/#dos-donts

Awesome, ok, good to know, hahah yeah, first thing I did was to disable prettier. And yeah, I looked through those before I began. I was mainly thinking of renaming state variables to make their intention clearer as I had some trouble understanding them at first and also removing some which don't seem to be used anymore. But I'll restrain myself and let it lie 😅
Should submit the pull request this weekend 🙌 I've finished most of the actual work, just have to add the docs and learn to rebase. If you have the time I'd be grateful if you could look at it and let me know if I'm doing something wrong, if not ofc I understand.

Well, this is a bit of a different story then 😊
I would be fine with removing unused variables and even rename variables if the name is not indicative of their purpose and confusing.
One thing that I would suggest, is that you do this as a separate PR (using a new branch from dev, not your previous branch) as it's not directly related to the feature you are implementing and can be submitted as a completely isolated improvement to the code

My pull request has been merged, so I'm closing the issue :)

Please don't close until the version is released.

Oh, sorry, didn't know that's how this works ✌

authors: AJIXuMuK Katli95 joelfmrodrigues

repo: pnp/sp-dev-fx-controls-react


text:
Can't mention two people with the same name

I use this, but I can't find the way two or more people with same name.
Note: it don't mean mentioning one people twice, mentioning peoples with same name.
For example: There is many people named "James".
Please let me know the way to solve this.

@michelwilliam624 - if you don't want to make each one unique, you can set allowRepeat to true in your settings and that will allow you to mention two people with the same name (although it does also mean you can mention the same person twice too).

repo: podio/jquery-mentions-input


text:
Add From implementation for I18NArgs

I think the tuple way of mapping I18NArgs is very poor. For instance, when you don't know the amount of args, you must handle each amounts. So I implemented From<HashMap>.
My personal use case is making a filter translate for tera templating:
<h1>{{ "hello" | translate(name=name) }}</h1>

fn filter(&self, id: &Value, args: &HashMap<String, Value>) -> Result<Value> {
    self.locale
        .text_with_args(id.as_str().unwrap(), args)
        .map(|str| Value::String(str))
        .map_err(|err| Error::msg(err))
}

Let me know, fellow poem users, if you want me to implement this i18n tera filter directly into poem.

You are right, I need this.

repo: poem-web/poem


text:
Deprecated Font Asset font-inconsolata-g-for-powerline

TASK: tmux | ensure inconsolata-g is present
failed: [default] => {"failed": true}
msg: Error: Download failed on Cask 'font-inconsolata-g-for-powerline' with message: Download failed: https://github.com/powerline/fonts/trunk/Inconsolata-g

On an attempt to manually brew cask install font-inconsolata-g-for-powerline, the response is:
curl: (22) The requested URL returned error: 404 Not Found
Error: Download failed on Cask 'font-inconsolata-g-for-powerline' with message:
Download failed: https://github.com/powerline/fonts/trunk/Inconsolata-g

PR #10 fixed this.

repo: poetic/short-stack-tmux


text:
Add an allocator test that backtracks across claims

Adds an allocator test to backtrack not only across requests within the same claim, but across two different claims.

Looks like the commit was pulled in, closing.

repo: pohly/kubernetes


text:
Add a more ergonomic way to create effects from delegate protocol implementations

I was analyzing how you implemented the live LocationManager for ComposableCoreLocation as I was looking to integrate another delegate protocol for the app I'm working on. I thought that it might be nice to have a more ergonomic, less boilerplate way to integrate a delegate protocol into an effect, so this PR is what I came up with.
All protocols that need to take advantage of this will need to also conform to the new EffectDelegate protocol I created, which just stores an Effect.Subscriber. That delegate protocol implementation is then expected to have each of its delegate methods call subscriber?.send() directly, instead of having to create closure properties for each delegate method (which gets very unwieldy really fast in my opinion). After that, you can create your Effect using one of the fromDelegate static methods easily, without having to assign lots of closures to a delegate instance.
The benefit of this approach (aside from far less boilerplate) is that it's much harder to forget to implement an analogous action for a given delegate protocol method. I realized this as I was converting ComposableCoreLocation to demonstrate this new approach, as you can see that I've added a case to LocationManger.Action to cover the delegate method that was previously missing a corresponding action.
Let me know what you think of this! I do have some qualms with how I've written things so far, and I'd love to discuss what some changes might look like:

I'm not the biggest fan of the fromDelegate method name (and the parameters might deserve better names too). I thought of using Effect.for(delegate:) but that doesn't read as nicely when you need to create a delegate in a closure, like ComposableCoreLocation does. Any suggestions here would be welcome.
I've constrained EffectDelegates to never be allowed to send failures, which makes intuitive sense to me but I might be missing a possible use case here. if so, we can definitely let the failure type on EffectDelegate be generic as well.
I tried to document usage of the new protocol/methods well, but I'm not practiced at this so I'm sure improvements can be made here, and I'm happy to make any edits that anyone feels is appropriate.

Hey @klundberg, thanks for the PR! You've definitely stumbled upon a really great simplification of this delegate dance we do. However, I think there's a spot between what we have today and what you have which may be the sweet spot.
I believe the core of what you have discovered is that it makes far more sense to simply hand the delegate the subscriber rather than have the delegate expose a bunch of closures which then wrap the subscriber and call .send on the inside of the closure. And I think this insight vastly cleans up the style even without the protocols.
Would you be willing to update the PR to remove the protocols and just pass the subscriber directly to the delegate? If you don't have time for that update I'm more than happy to help out.
Thanks!

Sure, I can experiment with that! That'll obviate some of my more specific concerns with what I've done here so far, I'll see what I can do :)

This was pretty easy to do actually. I haven't tested this on device so I don't know if there's any other specific core location gotchas. Your suggestions make this much simpler and I think this'll be a great guide for people looking to do something similar for any protocols they need to wrap into their apps using the architecture :). Let me know if there's anything else you want me to change!

authors: klundberg mbrandonw


text:
Error: Cannot read property 'rootNode' of undefined

Every now and then I get an error when trying to issue a command, for example take vest.

My Talon log reports this:
2021-07-14 11:17:25 ERROR    13:                                talon\scripting\talon_script.py:590|
   12:                                talon\scripting\talon_script.py:297|
   11:                                talon\scripting\talon_script.py:557|
   10:                                     talon\scripting\actions.py:75 |
    9:                                       talon\scripting\types.py:366|
    8:                           user\cursorless-talon\src\command.py:22 | actions.user.cursorless_multiple_targe..
    7:                                     talon\scripting\actions.py:75 |
    6:                                       talon\scripting\types.py:366|
    5:                           user\cursorless-talon\src\command.py:59 | actions.user.vscode_with_plugin_and_wa..
    4:                                     talon\scripting\actions.py:75 |
    3:                                       talon\scripting\types.py:366|
    2: user\knausj_talon\apps\vscode\command_client\command_client.py:321| run_vscode_command(
    1: user\knausj_talon\apps\vscode\command_client\command_client.py:194| raise Exception(decoded_contents["error"])
Exception: Running the contributed command: 'cursorless.command' failed.

[The below error was raised while handling the above exception(s)]
2021-07-14 11:17:25 ERROR cb error topic="phrase" cb=<bound method SpeechSystem.engine_event of <talon.scripting.speech_system.SpeechSystem object at 0x000000000559E6D0>>
   30:                     threading.py:912* # cron thread
   29:                     threading.py:954*
   28:                     threading.py:892*
   27:                    talon\cron.py:155|
   26:                    talon\cron.py:106|
   25:                     talon\vad.py:21 |
   24: talon\scripting\speech_system.py:331|
   23:             talon\engines\w2l.py:924|
   22:      talon\scripting\dispatch.py:105|
   21:      talon\scripting\dispatch.py:144|
   20:      talon\scripting\dispatch.py:133|
   19:          talon\scripting\rctx.py:233| # 'phrase' main:_redispatch()
   18: talon\scripting\speech_system.py:61 |
   17:      talon\scripting\dispatch.py:105|
   16:      talon\scripting\dispatch.py:144|
   15:      talon\scripting\dispatch.py:133|
   14: ------------------------------------# cron thread
   13:          talon\scripting\rctx.py:233| # 'phrase' main:engine_event()
   12: talon\scripting\speech_system.py:382|
   11:       talon\scripting\actions.py:75 |
   10:         talon\scripting\types.py:366|
    9:     talon\scripting\core\core.py:100|
    8:       talon\scripting\actions.py:75 |
    7:         talon\scripting\types.py:366|
    6:     talon\scripting\core\core.py:131|
    5:       talon\scripting\actions.py:75 |
    4:         talon\scripting\types.py:366|
    3:     talon\scripting\core\core.py:136|
    2:  talon\scripting\talon_script.py:691|
    1:  talon\scripting\talon_script.py:594|
talon.scripting.talon_script.TalonScriptError:
 in script at C:\Users\USERNAME\AppData\Roaming\talon\user\cursorless-talon\src\cursorless.talon:6:
 > user.cursorless_single_target_command(cursorless_simple_action, cursorless_target)
Exception: Running the contributed command: 'cursorless.command' failed.

I have the latest version of vs code, talon, cursorless, and knausj.
This is on windows 10, while working in a .vue file.

Are you sure the command recognised properly as "take vest"? That error message probably is caused by cursorless looking for a syntax tree for your file, which means it probably thought you said something like "take class" or "take funk"

Either way, we should catch this error and instead report "could not select containing SCOPE_TYPE because LANGUAGE parser functionality is not yet supported"

Are you sure the command recognised properly as "take vest"? That error message probably is caused by cursorless looking for a syntax tree for your file, which means it probably thought you said something like "take class" or "take funk"

You might be correct. I thought the Talon subtitles showed take vest, but maybe I'm wrong. I'll update this issue if I get this error again.

authors: awulkan pokey

repo: pokey/cursorless-vscode


text:
🛑 Pokko - au-syd1 is down

In 076412f, Pokko - au-syd1 (https://au-syd1.pokko.io) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Pokko - au-syd1 is back up in f0c7720 after 5 minutes.

repo: pokkocms/pokko-status


text:
🛑 Pokko - auth service is down

In 15d7bbc, Pokko - auth service (https://id.pokko.io) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Pokko - auth service is back up in edd0d4f after 8 minutes.