text:
Create a reusable FixAllProvider based on IntroduceFieldFromConstructorCodeFixProviderAll

Related to #352 (Test fix all providers)
The Roslyn BatchFixAllProvider often fails to fix several diagnostics in a document because it merges code changes. The Roslyn team discussed the pro and cons of several approaches for FixAllProvider and I think there is a sweet-spot between the Sequential and the Batch approaches that can be used for a variety of fixes.
I propose to create a custom FixAllProvider with the following characteristics:

Runs for all documents in the scope in parallel.
Runs the fixes for a single document in sequence like that:

Get all fixable diagnostics for the document
Track the nodes associated with the diagnostic with SyntaxAnnotations
Apply the fixes within the document in sequence
Remove the SyntaxAnnotations from the tree.

The  IntroduceFieldFromConstructorCodeFixProviderAll already works like that.
This new custom FixAllProvider would have the limitation, that the fix for a diagnostic is only allowed to change the current document (otherwise there would be merge conflicts).
To make the FixAllProvider reusable I propose the following architecture:
The IntroduceFieldFromConstructorCodeFixProviderAll reuses the CodeFixProvider logic by calling the static IntroduceFieldFromConstructorCodeFixProvider.IntroduceFieldFromConstructor method.
This would be abstracted by introducing an interface that the CodeFixProvider needs to implement.
This interface might look like that:
/// <summary>
/// This interface must be implemented by the associated CodeFixProvider. The CodeFixProvider must operate on a single document and
/// should only change the document. This limits the possible operations of the CodeFixProvider to change only document internals without
/// effecting other parts of the solution.
/// </summary>
public interface IFixDocumentInternalsOnly
{
    Task<Document> FixDocumentAsync(SyntaxNode nodeWithDiagnostic, Document document, CancellationToken cancellationToken);
}

The custom FixAllProvider would operate on all the Documents in scope in parallel:
private async static Task<Solution> GetFixedDocumentsAsync(FixAllContext fixAllContext, IEnumerable<Document> documents)
{
    var solution = fixAllContext.Solution;
    var newDocuments = documents.ToDictionary(d => d.Id, d => GetFixedDocumentAsync(fixAllContext, d));
    await Task.WhenAll(newDocuments.Values).ConfigureAwait(false);
    var changedDocuments = from kvp in newDocuments
                           where kvp.Value.Result != null
                           select new { DocumentId = kvp.Key, Document = kvp.Value.Result };
    foreach (var newDocument in changedDocuments)
        solution = solution.WithDocumentSyntaxRoot(newDocument.DocumentId, await newDocument.Document.GetSyntaxRootAsync().ConfigureAwait(false));
    return solution;
}

A single document is fixed like that:
private async static Task<Document> GetFixedDocumentAsync(FixAllContext fixAllContext, Document document)
{
    var codeFixer = fixAllContext.CodeFixProvider as IFixDocumentInternalsOnly;
    if (codeFixer == null) throw new ArgumentException("This CodeFixAllProvider requires that your CodeFixProvider implements the IFixDocumentInternalsOnly.");
    var diagnostics = await fixAllContext.GetDocumentDiagnosticsAsync(document).ConfigureAwait(false);
    if (diagnostics.Length == 0) return null;
    var root = await document.GetSyntaxRootAsync(fixAllContext.CancellationToken).ConfigureAwait(false);
    var nodes = diagnostics.Select(d => root.FindNode(d.Location.SourceSpan)).Where(n => !n.IsMissing);
    var annotations = new List<SyntaxAnnotation>();
    var newRoot = root.ReplaceNodes(nodes, (original, rewritten) =>
        {
            var annotation = new SyntaxAnnotation(SyntaxAnnotationKey);
            annotations.Add(annotation);
            var newNode = original.WithAdditionalAnnotations(annotation);
            return newNode;
        });
    var newDocument = document.WithSyntaxRoot(newRoot);
    newDocument = await FixCodeForAnnotatedNodesAsync(newDocument, codeFixer, annotations, fixAllContext.CancellationToken).ConfigureAwait(false);
    newDocument = await RemoveAnnontationsAsync(newDocument, annotations).ConfigureAwait(false);
    return newDocument;
}

private static async Task<Document> FixCodeForAnnotatedNodesAsync(Document document, IFixDocumentInternalsOnly codeFixer, IEnumerable<SyntaxAnnotation> annotations, CancellationToken cancellationToken)
{
    foreach (var annotation in annotations)
    {
        var newRoot = await document.GetSyntaxRootAsync(cancellationToken).ConfigureAwait(false);
        var annotatedNodes = newRoot.GetAnnotatedNodes(annotation);
        var node = annotatedNodes.FirstOrDefault();
        if (node == null) continue;
        document = await codeFixer.FixDocumentAsync(node, document, cancellationToken).ConfigureAwait(false);
    }
    return document;
}

private static async Task<Document> RemoveAnnontationsAsync(Document document, IEnumerable<SyntaxAnnotation> annotations)
{
    var root = await document.GetSyntaxRootAsync().ConfigureAwait(false);
    var nodes = annotations.SelectMany(annotation => root.GetAnnotatedNodes(annotation));
    root = root.ReplaceNodes(nodes, (original, rewritten) => original.WithoutAnnotations(annotations));
    var newDocument = document.WithSyntaxRoot(root);
    return newDocument;
}

I started a local branch for such a FixAllProvider for the new analyzer #904 that is already working on my machine.
If there is interest in such a FixAllProvider we need to discuss

Where it should be located (CodeCracker.Common.dll or CodeCracker.CSharp.dll)
The proposed architecture (especially the interface approach)
How to proceed with the consumers (I think it is okay to first merge Pull Request #904 than create another Pull Request with the new FixAllProvider and related test and then change IntroduceFieldFromConstructorCodeFixProvider and ReplaceWithGetterOnlyAutoPropertyCodeFixProvider to use the new FixAllProvider)

As I worked on the implementation I came across some issues I would like to document:

The fixer might need the SemanticModel of the SyntaxTree. That's why I used the Document instead of the Root SyntaxTree for the parameters in the interface (The SemanticModel is only available via Document.GetSemanticModelAsync).
This approach will fail on partial classes that are defined in two ore more documents (the Fixer will not be able to operate on nodes in the other documents).

@MaStr11 I would like to see a PR. The idea seems interesting. There are several of our fix all providers that work that way.
One thing to evaluate, though, is that instead of using annotations, use SyntaxNodeExtensions.TrackNodes.
Why don't you submit the PR with an update to an existing fix all provider? It can be IntroduceFieldFromConstructorCodeFixProviderAll itself.

TrackNodes ist an option,  but this might interfere with the actual CodeFixProvider (if it uses TrackNodes for the transformations). Using Annotations this would not be the case. I would like to keep it as it is.

Ok, send the PR so we can check it out.

Closed on #937.


text:
sensor calibration

I'm following the instructions you provided for Kinect calibration
https://github.com/code-iai/iai_kinect2/blob/master/kinect2_calibration/README.md
I have the forrowing running

roscore
rosrun kinect2_bridge kinect2_bridge _fps_limit:=2
rosrun kinect2_calibration kinect2_calibration chess5x7x0.03 record color

I get the following error message, but I'm able to save the images
[ERROR] Tried to advertise a service that is already advertised in this node [/kinect2_calib_1461090415983227522/compressed/set_parameters]
[ERROR] Tried to advertise a service that is already advertised in this node [/kinect2_calib_1461090415983227522/compressed/set_parameters]
should I just ignore the error messages?

just ignore it

source: gharchive/issue

authors: pnambiar wiedemeyer

license_type: permissive

license_source: bigquery


text:
Getting big Extrinsics re-projection errors after calibration with kinect2_calibration

Hi,
I'm running ROS with the iai_kinect2 tool, on a Jetson TK1 board.
Specifically, I'm trying to calibrate the RGB camera and the depth camera, to create aligned RGBD point clouds.
I followed the tutorial here: https://github.com/mintar/iai_kinect2/tree/master/kinect2_calibration, while using a large chess board 7x9x0.05 in size.
All the steps of the calibration worked as expected, the camera recognized the chess pattern and I took many pictures using the record application from different distances and orientations of the board, while using a chair to hold the board, so the images were stable.
I received low intrinsics re-projection errors: The RGB camera error was 0.212018, the IR camera error was 0.0957678.
But the error I received for the sync calibration (extrinsics re-projection error) was: 17.431, which is very high. I tried this process multiple times with very similar results.
It's also visible when running the kinect2_viewer app that the cameras aren't aligned smoothly.
Have you ever encountered difficulties with the calibration process? I guess something in my calibration process is incorrect, and I would be very thankful to hear if you have any tips or ideas why I'm getting these results.
Regards,
Arik.

Hi,
the intrinsic parameters are looking fine. I don't know your exact setup, so I can only guess, but for the extrinsic parameters, each pair of images from both sensors (IR and RGB) has to be taken from the exact same position. It is very important that the device is not moving, therefore is has to be mounted on a tripod. Holding it in the hand, will not work.

Thanks for the comment!
I use a kind of book-stand to hold the Kinect, and I put the chessboard pattern on a chair in front of it, which I move to different angles in front of the Kinect. It means that for each synced image I take, both the camera and the pattern are static.
I still get bad synchronized re-projection error.
Is it possible there is a problem with the camera itself?
Or maybe there are some angles that I should emphasize which I maybe missed?
I would love to hear what angles you used during your calibration that produced the best results.
Thanks again,
Arik.

I am also running Jetson TK1s and so far haven't had issues with the calibration. Your process sounds better than mine :)
I will be calibrating sixteen kinects over the next few days, though, so I will post if I see anything similar.
I did have one kinect that was malfunctioning, for whatever it's worth.

Well it looks like the camera definitely was part of the problem. I tried the same process with a different Kinect, and received very similar intrinsics re-projection errors, but this time I received an extrinsics re-projection error of  0.44.
The synchronized point cloud now looks a lot better than before, but it still looks a bit un-synchronized. For example - I record a chair, and a bit of it's color is on the background of the chair.
I'm wondering what extrinsics re-projection error you receive in your calibration process, and if you manage to receive a good synchronization from it.

That is similar to the extrinsics re-projection error that I see. Here is a screenshot from one of the cameras after it has been calibrated. For this one, I used only about 50 images per calibration set.

Looks good!
When you said you had a camera malfunction, what were the symptoms?
I'm wondering if big extrinsics re-projection errors is a common symptom for a malfunctioning camera...
wiedemeyer - I would be glad to hear from your experience if you encountered such an error as well.

I think a malfunction that prevents a proper calibration is very unlikely. Most probably something in the calibration process went wrong. There are some very important things:

The pattern has to match exactly the dimensions that you set. Some printers are not as precise as others. Measure the printed pattern carefully. Length of each field, length over multiple fields, etc.
Placing of the pattern is very important, which less images, or many images of a similar view to the pattern you can get a good reprojection error, but a bad calibration. I normally capture around 100 - 200 images by following these steps:

place the pattern near to the camera
position the pattern in the top left corner of the image
move it along that row while taking pictures
go down one row and do step iii. again until you end up in the right bottom corner
rotate the pattern so that (1) the left border is further away from the camera than the right side, (2) the other way around, (3) the top border is further away than the bottom one, (4) the other way around, (5) left top corner is pointing up and the lower right corner is pointing down. For each of those rotations go back to step ii.
place the pattern further away from the camera and go to step ii. Do this for 3 different distances, near (<= 1m), middle range (> 1m, < 2.5m) and far (>= 2.5m). (The possible distances depend on the chess board size.)

Especially for the extrinsic calibration, it is important that the sensor and the pattern are not moving while taking the images.

My bad kinect was not reliably powering on. I spent a long time trying to figure it out!
I don't know enough about the hardware to have an idea if your problem might have a mechanical cause. It's strange that we're using all of the same devices, though, with different results. Sorry I can't be of more help with your issue. Good luck!

Hi @arik1089, can you confirm that the camera was the issue? I am also facing the problem that the reprojection error is very high, after several trials.

authors: Tobias-Fischer arik1089 awhampton wiedemeyer


text:
Build Problem (Ubuntu 12.04 - ROS Hydro)

I'm following the installation procedure and I have problem here:
  catkin_make -DCMAKE_BUILD_TYPE="Release"

when it tries to compile the registration_viewer, I have:
   Could NOT find PCL (missing: PCL_LIBRARIES)

Usually I use ROS and PCL without problems so I changed the CMakeLists.txt file of the registration_viewer removing the line "find_package(PCL REQUIRED)" and adding pcl_conversions pcl_ros to the "find_package catkin REQUIRED COMPONENTS", as usually I do.
The problem is gone but now I have:
      Built target kinect2_bridge       Built target kinect2_bridge_nodelet         /usr/bin/ld: CMakeFiles/viewer.dir/src/viewer.cpp.o: undefined reference to symbol 'vtkCellArray::New()'         /usr/bin/ld: note: 'vtkCellArray::New()' is defined in DSO /usr/lib/libvtkFiltering.so.5.8 so try adding it to the linker command line          /usr/lib/libvtkFiltering.so.5.8: could not read symbols: Invalid operation
How can I solve my problem? Any help is appreciated!

I solved it by adding  libvtkCommon.so libvtkFiltering.so
to the CMakeLists.txt file.


text:
refactor: add code-pushup.preset.ts

This PR adds a code-pushup.preset.ts and uses the preset in code-pushup.config.ts
Notice:
Coverage helper still unfinished.

Sry for the mess in the first version of the PR!

source: gharchive/pull-request

repo: code-pushup/cli

license: MIT

license_source: github-api


text:
With error, exit code is still zero

host -R 3 foo.apps-crc.testing
SSH cmd err, output: exit status 255:
ERRO Failed internal dns query: ssh command error:
command : host -R 3 foo.apps-crc.testing
err     : exit status 255
output  :  :
Making call to close driver server
(crc) Calling .Close
Successfully made call to close driver server
Making call to close connection to plugin binary
Making call to close driver server
(crc) Calling .Close
(crc) DBG | Closing plugin on server side
Successfully made call to close driver server
Making call to close connection to plugin binary
INFO Running
ERRO ssh command error:
command : host -R 3 foo.apps-crc.testing
err     : exit status 255
output  :
[root@n61 bin]# echo $?
0

Closed via #208

authors: anjannath praveenkumar

repo: code-ready/crc


text:
telemetry: enable tracking between Red Hat products

It allows us to know if a user also uses others products like vscode or
odo.
Telemetry must be enabled on both products.

/retest

authors: guillaumerose praveenkumar


text:
[Podman] Create podman bundle for aarch64 which should work on M1

Some of the changes we need to do to make bundle for aarch64.
diff --git a/snc.sh b/snc.sh
index 66cc76a..5852670 100755
--- a/snc.sh
+++ b/snc.sh
@@ -35,14 +35,18 @@ ssh-keygen -t ecdsa -b 521 -N "" -f id_ecdsa_crc -C "core"
 ${YQ} eval --inplace ".passwd.users[0].ssh_authorized_keys[0] = \"$(cat id_ecdsa_crc.pub)\"" ${CRC_INSTALL_DIR}/fcos-config.yaml

 # Create the ign config
-${PODMAN} run -i --rm quay.io/coreos/butane:release --pretty --strict < ${CRC_INSTALL_DIR}/fcos-config.yaml > ${CRC_INSTALL_DIR}/fcos-config.ign
+curl -L -O https://github.com/coreos/butane/releases/download/v0.14.0/butane-aarch64-unknown-linux-gnu
+chmod +x butane-aarch64-unknown-linux-gnu
+./butane-aarch64-unknown-linux-gnu  --pretty --strict < ${CRC_INSTALL_DIR}/fcos-config.yaml > ${CRC_INSTALL_DIR}/fcos-config.ign

 # Validate ign config
-${PODMAN} run --pull=always --rm -i quay.io/coreos/ignition-validate:release - < ${CRC_INSTALL_DIR}/fcos-config.ign
+curl -L -O https://github.com/coreos/ignition/releases/download/v2.13.0/ignition-validate-aarch64-linux
+chmod +x ignition-validate-aarch64-linux
+./ignition-validate-aarch64-linux - < ${CRC_INSTALL_DIR}/fcos-config.ign

 # Download the latest fedora coreos latest qcow2
-${PODMAN} run --pull=always --rm -v ${PWD}/${CRC_INSTALL_DIR}:/data:Z -w /data quay.io/coreos/coreos-installer:release download -s stable -p qemu -f qcow2.xz --decompress
-mv ${CRC_INSTALL_DIR}/fedora-coreos-*-qemu.x86_64.qcow2 ${CRC_INSTALL_DIR}/fedora-coreos-qemu.x86_64.qcow2
+coreos-installer download -s stable -p qemu -f qcow2.xz --decompress -C ${CRC_INSTALL_DIR}
+mv ${CRC_INSTALL_DIR}/fedora-coreos-*-qemu.aarch64.qcow2 ${CRC_INSTALL_DIR}/fedora-coreos-qemu.aarch64.qcow2

 # Update the selinux context for ign conig and ${CRC_INSTALL_DIR}
 chcon --verbose ${current_selinux_context} ${CRC_INSTALL_DIR}
@@ -56,7 +60,7 @@ create_json_description
 sudo ${VIRT_INSTALL} --name=${CRC_VM_NAME} --vcpus=2 --ram=2048 \
        --import --network=bridge=virbr0 --graphics=none \
        --qemu-commandline="-fw_cfg name=opt/com.coreos/config,file=${PWD}/${CRC_INSTALL_DIR}/fcos-config.ign" \
-       --disk=size=31,backing_store=${PWD}/${CRC_INSTALL_DIR}/fedora-coreos-qemu.x86_64.qcow2 \
+       --disk=size=31,backing_store=${PWD}/${CRC_INSTALL_DIR}/fedora-coreos-qemu.aarch64.qcow2 \
        --os-variant=fedora-coreos-stable \
        --noautoconsole --quiet
 sleep 120

diff --git a/createdisk.sh b/createdisk.sh
index 55aaa38..22ef6ff 100755
--- a/createdisk.sh
+++ b/createdisk.sh
@@ -32,7 +32,7 @@ install_additional_packages ${VM_IP}

 # Add gvisor-tap-vsock
 ${SSH} core@${VM_IP} 'sudo bash -x -s' <<EOF
-  podman create --name=gvisor-tap-vsock --privileged --net=host -v /etc/resolv.conf:/etc/resolv.conf -it quay.io/crcont/gvisor-tap-vsock:3231aba53905468c22e394493a0debc1a6cc6392
+  podman create --name=gvisor-tap-vsock --privileged --net=host -v /etc/resolv.conf:/etc/resolv.conf -it quay.io/crcont/gvisor-tap-vsock:arm
   podman generate systemd --restart-policy=no gvisor-tap-vsock > /etc/systemd/system/gvisor-tap-vsock.service
   systemctl daemon-reload
   systemctl enable gvisor-tap-vsock.service

# git diff createdisk-library.sh
diff --git a/createdisk-library.sh b/createdisk-library.sh
index c77a795..4ec982c 100755
--- a/createdisk-library.sh
+++ b/createdisk-library.sh
@@ -48,13 +48,13 @@ function create_qemu_image {
     local destDir=$2

     sudo cp /var/lib/libvirt/images/${CRC_VM_NAME}.qcow2 $destDir
-    sudo cp ${sourceDir}/fedora-coreos-qemu.x86_64.qcow2 $destDir
+    sudo cp ${sourceDir}/fedora-coreos-qemu.aarch64.qcow2 $destDir

     sudo chown $USER:$USER -R $destDir
-    ${QEMU_IMG} rebase -F qcow2 -b fedora-coreos-qemu.x86_64.qcow2 $destDir/${CRC_VM_NAME}.qcow2
+    ${QEMU_IMG} rebase -F qcow2 -b fedora-coreos-qemu.aarch64.qcow2 $destDir/${CRC_VM_NAME}.qcow2
     ${QEMU_IMG} commit $destDir/${CRC_VM_NAME}.qcow2

-    sparsify $destDir fedora-coreos-qemu.x86_64.qcow2 ${CRC_VM_NAME}.qcow2
+    sparsify $destDir fedora-coreos-qemu.aarch64.qcow2 ${CRC_VM_NAME}.qcow2

     # Before using the created qcow2, check if it has lazy_refcounts set to true.
     ${QEMU_IMG} info ${destDir}/${CRC_VM_NAME}.qcow2 | grep "lazy refcounts: true" 2>&1 >/dev/null
@@ -66,7 +66,7 @@ function create_qemu_image {
     # Update the qcow2 image permission from 0600 to 0644
     chmod 0644 ${destDir}/${CRC_VM_NAME}.qcow2

-    rm -fr $destDir/fedora-coreos-qemu.x86_64.qcow2
+    rm -fr $destDir/fedora-coreos-qemu.aarch64.qcow2
 }

 function update_json_description {

The kernel most likely needs to be gunzipped before being added to the bundle?

@cfergeau Yes, I am thinking to create another issue for that.

These changes are in https://github.com/code-ready/snc/pull/503 , uncompressing the kernel is https://github.com/cfergeau/snc/commit/07c6a4c3a95492263aab49a4463f64b1d8a314ff

Closing this one since this is also now fixed.

authors: cfergeau praveenkumar

repo: code-ready/snc


text:
test PR for workflow

Just testing workflow action.

I have read the CLA Document and I hereby sign the CLA


text:
Issue in QR Image

I need to generate QR Image for below code. But QR Coder does not create correct image for it. Can I know a way to do it. it works for other codes well.
www.bethelonline.cn/certificate/PTGJQ9Q6

Hi @nadeekapf1 ,
could you please specify what exactly you want to encode (=payload) as QrCode? The url you posted? Contents of the website the url links to?

HI Raffael,
below is the exact text (code) which needs to be converted to a QRImage.
www.bethelonline.cn/certificate/PTGJQ9Q6
Thanks & Regards
Nadeeka Fernando
On 12 April 2017 at 22:05, Raffael Herrmann notifications@github.com
wrote:

Hi @nadeekapf1 https://github.com/nadeekapf1 ,
could you please specify what exactly you want to encode (=payload) as
QrCode? The url you posted? Contents of the website the url links to?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/codebude/QRCoder/issues/67#issuecomment-293636160,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AaFZUg3xCo66CsvsbcXIt6GfzWvy9MV1ks5rvP1QgaJpZM4M7WGj
.

HI raffael,
I have an issue with this code also.
www.bethelonline.cn/certificate/Z4Z7MOYH

I created the following for QR codes (they differ in the ECC levels) for your payload. The QR codes are generated with the latest QrCoder version and I'm unable to see any error.
http://fs5.directupload.net/images/170419/7biaznjk.jpg
http://fs5.directupload.net/images/170419/tjxbbghs.jpg
http://fs5.directupload.net/images/170419/2572yfkv.jpg
http://fs5.directupload.net/images/170419/8ztdgyem.jpg

Hi,
Yes I was using a previous version. (https://www.aspsnippets.com/Articles/Dynamically-generate-and-display-QR-code-Image-in-ASPNet.aspx)
Now I updated from Nuget Package. It's working now. Thanks for helping us to find the issue

Is this tutorial valid still? If not, a take-down request/modification should be made.

I already wrote the author, and requested to update the tutorial and in best case remove the binaries and provide a Nuget link instead. Let's what happens.

authors: Hydroque codebude nadeekapf1

repo: codebude/QRCoder

license: mit


text:
Remove framework overrides

Summary
The QRCoder solution won't build on my Windows 11 laptop with a fresh installation of Visual Studio 2022, even with the .NET Framework 3.5 development tools installed.  It seems to be related to the framework override csproj properties.  It builds fine when I remove them.
Can we remove these properties?
Test plan
Ensure it builds without these excess properties, both locally and in CI.

The framework overrides were added a good 4 years ago by @csturm83 via https://github.com/codebude/QRCoder/commit/0d084052bc8957fa12766deddc465903afe8c4f3. Maybe he can still remember why.
Unfortunately, I no longer know. I can only assume that it was due to the build pipeline at the time via MyGet, where the .NET framework was not in the default path. But I'm not 100 percent sure. If csturm83 doesn't veto it, we can merge it.

How do we test if it is needed anymore? Dotnet pack from within CI?

@Shane32 Not sure. There was an update in the comment that was referenced in the workaround (https://github.com/dotnet/msbuild/issues/1333#issuecomment-296346352) to reference ref assemblies via a NuGet package. You could try that if removing the overrides doesn't work.

You could try that if removing the overrides doesn't work.

I would say it works. At least the pipeline logs say that the net35 binaries were successfully build: https://github.com/codebude/QRCoder/actions/runs/9334333660/job/25692441349?pr=560#step:5:13

I had problems a while back where I was required to add the NuGet package reference to the .NET Reference Assemblies.  However, I don't need to anymore, and in fact it breaks builds within the latest .NET SDK.  See link below.  The .NET team recommended that I remove the reference, even though there still exists MS documentation stating to include the reference for certain scenarios.  Supposedly the reference is automatically included by the .NET SDK for .NET Framework builds or something.  I would assume that the issue requiring the patch has since been resolved.
See: https://github.com/dotnet/aspnetcore/issues/54544

the net35 binaries were successfully build:

The original issue was surrounding dotnet pack. I suspect the issue in the SDK has since been resolved as @Shane32 suggests.


text:
Separate Meshes for Each Brush

This plugin creates a single Array Mesh for the entire map. In old BSP game engines, you could hit individual brushes with a raycast for doing various things like getting the texture name for that specific brush. Please change it so that Build Meshes creates separate meshes and collision shapes for each brush.

Dupe of #71

authors: humansandbag krazyjakee

repo: codecat/godot-tbloader


text:
Setup tunning

Reduce image size from 894Mb to 432Mb with Alpine
Add install script and use latest checkstyle

@maxjacobson Did the same thing (make upgrade) for both PMD and Checkstyle

repo: codeclimate/codeclimate-checkstyle


text:
Homepage: the regular campaign's "Play Now" button is not shown when the user is in a course

It seems that when my user is in a course, the "Play Now" button (for the regular campaign) does not appear in the homepage. I'm talking about this button:

I'm not sure whether this change was intended as to reduce the confusion and UI clutter for course students, but I find it unfortunate for players that may be playing both versions and suddenly can't find the link to the regular campaign play mode.

I am teaching it in my ICT lessons... and when a student change to the class version he is not able to play the campaign and just some 18 levels of the game... which is for 1-2 hour... :(  the children said to me to not create classes because it's not worth it... I hope it is just a mistake... :(

I guess this is more of a conceptual debate. Do you also want to let students play the same levels that they can also play within the course, by themselves without keeping track of their progress. It is an interesting question though.

I believe this is most troublesome when the user is already playing the campaign, and then signs up for a course and can no longer see the button to play the campaign.

We are working on some designs to address this issue; will update soon when we have something to show.

Thank you...
Dňa 18.5.2016 2:06 používateľ "Nick Winter" notifications@github.com
napísal:

We are working on some designs to address this issue; will update soon
when we have something to show.
—
You are receiving this because you commented.
Reply to this email directly or view it on GitHub
https://github.com/codecombat/codecombat/issues/3563#issuecomment-219890106

This isn't going to be supported for now; we're continuing to work on better separation of the classroom and individual game versions of CodeCombat.

authors: Izsof UltCombo bdekk nwinter

repo: codecombat/codecombat


text:
Issue with codecov checksum

We're using the following snippet to verify the codecov bash uploader:
curl -s https://codecov.io/bash > codecov
VERSION=$(grep -o 'VERSION=\"[0-9\.]*\"' codecov | cut -d'"' -f2)
for i in 1 256 512
do
  "sha${i}sum" -c <(curl -s "https://raw.githubusercontent.com/codecov/codecov-bash/${VERSION}/SHA${i}SUM" | grep codecov)
done

It stopped working this morning and is now blocking our CI/CD pipeline, it might be due to the hotfix mentioned in #448?
The version downloaded is 1.0.3.
I have the following checksum:
$ sha1sum codecov
ae30de7e8b98fb5f0cddce64771c53c3613a8ae2  codecov
$ sha256sum codecov
af719f83d08be837ebeba214729e5b76dbe0b1d073de1efc4e2cd5d73c8da7c2  codecov
$ sha512 codecov
4de731fb90c196025daca480182adc080bb53ae24a5e634734810887515377ce33ed9b7ef4729013aa33fc7c6bbce76c8d248d1bd6e894be24368111cee6ee56  codecov

I just realised this is a duplicate of #446.

repo: codecov/codecov-bash


text:
Properly handle completed contracts in conductor

They currently 404, which is certainly a bug.

Right now, we expose the basic information and we are relying on the county scraper to get the newer line item information. However, we aren't exposing the company/company contacts. We'll need to create ways to manage this information. I see two possible options:

Instead of re-inventing the wheel, we take people to the contract's admin page (screenshot below) and have them fill out the relevant information (companies, for example) there.
We build out our own meta page to do basically the same thing, but with better control over the styling/experience.

So, there are numerous problems with the simple model that @shellicious and I discussed offline a few days ago.
The model that we have been working with attaches a financial ID to a contract. This is all well and good, but in actuality there is one contract per company-contract pairing. The current workflow doesn't properly handle this. If there are six companies assigned to a contract, we will need to create six new contract objects, each with their own individual controller number. Right now the UI/flow only works when you have one company. I think we are going to need to go back to the drawing board and bit and game this out.


text:
Implement page printing for Somerschool Launch

Our goal is to test the student profile views by sharing them with teachers during Summer School.(Somerschool! Somersession!) To do that we'll need a function to create printable PDFs of each profile page.

Gems that could help us: PDFKit, Wicked PDF.

In today's standup with @marimuraki we decided we'll try to test the web version rather than a print version over summer school. Testing the web version will let us see if features like the sortable roster and detailed Highcharts graphs add value for teachers. Closing this for now.

repo: codeforamerica/somerville-teacher-tool


text:
Define Registration Process

Online
Day of event
Our POC for this event's pre-registration
Any packets, or handouts?
Name badge prep or self name badges

Using Meetup.com event site - name badges moved to supplies

authors: BluesGuy cdoelling


text:
Kakomimasu core 内、できればsetIntervalを使いたくない

coreを他の言語への移植がしやすいように

具体的にはどんな感じにするといいでしょう？
kakomimasu.jsでsetIntervalするんじゃなくて、apiserver.tsの方でした方がいいのでしょうか…
それとも別の方法みたいなのがあるのでしょうか…

apiserver.ts 側でsetIntervalで待ってくれ方がいいね
ポーリングするか、コールバックするか、コアを使ってどう実装するかは利用側で決められるようにした方が使い勝手アップ

authors: kamekyame taisukef

repo: codeforkosen/Kakomimasu


text:
pay Brice's

Meet up with Kris and reserve their services

When are you planning to go over there?

Don't know. I plan on going over giving him my CC, signing the agreement
and leaving. Going to be pop in and pop out.
Chris Mathews
On Fri, Aug 25, 2017 at 1:47 PM, aikimark notifications@github.com wrote:

When are you planning to go over there?
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/codeforraleigh/NCOpenPass/issues/589#issuecomment-324991247,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAOGtWIPIynm-H8dFxF0_fVuN19iz9Tkks5sbwjFgaJpZM4PC9dv
.

When is he usually there?

I don't know. he is in and out.

Put down 50%. contact is David

authors: ChrisTheDBA aikimark

repo: codeforraleigh/NCOpenPass


text:
Bug: site defaced

PHP Version
8.1
CodeIgniter4 Version
4.5.5
CodeIgniter4 Installation Method
Manual (zip or tar.gz)
Which operating systems have you tested for this bug?
Linux
Which server did you use?
apache
Database
MariaDB 10.1
What happened?
My site has been defaced by some people and their index page has been changed.
Steps to Reproduce
I have used validation in my forms and also have ssl
Expected Output
some files have been uploaded on my host and index has also been changed through .htaccess
As long as I was on CodeIgniter 4.3.7 I had no problems, after updating to 4.5.5 was defaced
Anything else?
No response

Read security guideline https://github.com/codeigniter4/CodeIgniter4/blob/develop/SECURITY.md .

authors: Under-Wow samsonasik


text:
Improve site part2

Description
https://datamweb.github.io/shield
See https://github.com/timvink/mkdocs-git-revision-date-localized-plugin
You need pip3 install mkdocs-git-revision-date-localized-plugin.
Checklist:

[x] Securely signed commits
[ ] Component(s) with PHPDoc blocks, only if necessary or adds value
[ ] Unit testing, with >80% coverage
[ ] User guide updated
[ ] Conforms to style guide

@datamweb How can I run mkdocs?
$ mkdocs serve
ERROR   -  Config value 'theme': Unrecognised theme name: 'material'. The available installed themes are: mkdocs, readthedocs
ERROR   -  Config value 'markdown_extensions': Failed to load extension 'pymdownx.superfences'.
           ModuleNotFoundError: No module named 'pymdownx'

Aborted with 2 configuration errors!

Resolved.
$ pip3 install mkdocs
$ pip3 install mkdocs-material
$ pip3 install mkdocs-git-revision-date-localized-plugin

authors: datamweb kenjis


text:
Update nltk version

nltk 2.0.5 doesn't seem to install. How about we update to a version that works?
Tests pass with these changes:
$ python tests/unit_tests.py
        testing function 'test_config_build'
        [OK] in 'test_config_build' 0.01 sec
.       testing function 'test_chinese_fulltext_extract'
Building prefix dict from <OBSCURED>/lib/python2.7/site-packages/jieba/dict.txt ...
Loading model from cache /var/folders/mt/4fq_3q8s6hzg69gy03lq40zm0000gn/T/jieba.cache
Loading model cost 0.455691099167 seconds.
Prefix dict has been built succesfully.
        [OK] in 'test_chinese_fulltext_extract' 0.93 sec
        testing function 'test_arabic_fulltext_extract'
        [OK] in 'test_arabic_fulltext_extract' 0.32 sec
        testing function 'test_spanish_fulltext_extract'
        [OK] in 'test_spanish_fulltext_extract' 41.24 sec
.       testing function 'test_valid_urls'
        [OK] in 'test_valid_urls' 0.00 sec
.       testing function 'test_url'
        [OK] in 'test_url' 0.00 sec
        testing function 'test_download_html'
        [OK] in 'test_download_html' 0.00 sec
        testing function 'test_pre_download_parse'
You must download() an article before parsing it!
        [OK] in 'test_pre_download_parse' 0.00 sec
        testing function 'test_parse_html'
        [OK] in 'test_parse_html' 0.31 sec
        testing function 'test_meta_type_extraction'
        [OK] in 'test_meta_type_extraction' 0.00 sec
        testing function 'test_meta_extraction'
        [OK] in 'test_meta_extraction' 0.00 sec
        testing function 'test_pre_download_nlp'
You must download and parse an article before parsing it!
        [OK] in 'test_pre_download_nlp' 0.00 sec
        testing function 'test_pre_parse_nlp'
You must download and parse an article before parsing it!
        [OK] in 'test_pre_parse_nlp' 0.00 sec
        testing function 'test_nlp_body'
        [OK] in 'test_nlp_body' 0.00 sec
.       testing function 'test_hot_trending'
        [OK] in 'test_hot_trending' 0.31 sec
        testing function 'test_popular_urls'
        [OK] in 'test_popular_urls' 0.00 sec
.
----------------------------------------------------------------------
Ran 5 tests in 43.129s

OK

@codelucas, the Travis failure looks unrelated to these changes. Am I misunderstanding?

@codelucas or @yprez , have either of you gotten the chance to look this over?

@ssaamm I think that travis is not configured on the py2 branch, that's why it's failing.
Is this version fully compatible with Python2.7? If so, I see no reason not to merge this in.
Thanks.

@yprez ah, that makes sense. Thank you for clarifying.
Yes, (a) NLTK says they're 2.7 compatible and (b) the tests seem to work when I run them with a 2.7 interpreter.

Sounds good enough to me. Thanks!

so newspaper will never be compatible with python 3?

@MichaelBaumgarn Newspaper already is compatible with python 3 and has been for some time.
We maintain two separate branches in this repo, 'master' is purely python 3 while 'python-2-head' (this branch) is purely python 2.
These separate branches are separate projects in pip, download the python 3 version with pip3 install newspaper3k or python 2 version via pip install newspaper

yes my bad newspaper3k did the trick

authors: MichaelBaumgarn codelucas ssaamm yprez

repo: codelucas/newspaper


text:
Add Super Admin Functionality From Artisan

To ensure that the app is secure, create the add admin user functionality from an Artisan command.
For now, this will only add the user if there does not exist a user with the admin role, allow additions.

Completed in #c08ba6319c32b29ee47e5afae926dffc71ac654a

repo: codelust/laravel-skeleton


text:
[Question] cross-provider support

Hi @codemation,
Hope you find very well.
This tool looks fantastic. I was wondering if there will be plans in the roadmap to make this tool cross-provider, e.g. to work with microsoft login as well.

@dtcMLOps , hope you find the tool useful so far. Hope to add Microsoft login very son actually!

This package looks very useful.  For my purposes, I was looking for some additional capability. Are you considering some of these:

Support for a consolidated identify provider, like Firebase.

FYI, I do have a working prototype of a python server using Firebase services to validate a passed Firebase ID token, and create a JWT that can be used by the local site

Can I put and get my own claims in the JWT you create?
Client side libraries, or even a reference implementation.  Certain auth flows are hard to get right (eg. forgot password)
an extensible endpoint decorator.  I'm using connexion to define and create my REST endpoints
a pluggable resource (or needs) interface.  Eg. I'd like to require my endpoint to require a 'user' by using your library, but then let me manage which users can access specific resources represented by that endpoint.
Thanks for your time!

authors: codemation dtcMLOps johnbyrne7

repo: codemation/easyauth


text:
codemirror.css missing coma

In codemirror.css and many other css file under theme directory there is a ',' missing before .cm-type.
.cm-s-default .cm-variable-3, .cm-s-default .cm-type {color: #085;}
Therefore syntax highlightning won't work on "type" tokens.

The line I'm seeing is:
.cm-s-default .cm-variable-3, .cm-s-default .cm-type {color: #085;}

Which looks valid. Why do you think there's a missing comma?

I am by no mean an expert in css syntax.
But the style is not applied on "type" tokens with this css (on Opera) . If i write ".cm-s-default, .cm-type" instead the style is applied. Other style i ve test "keywords comment ..." works perfectly.

If i write ".cm-s-default, .cm-type" instead the style is applied. Other style i ve test "keywords comment ..." works perfectly.

Then I guess you're using a different theme. Adding a comma there will make the style apply to any cm-type element, whereas it should only be applied to elements with a parent element that has class cm-s-default

authors: marijnh vinklein

repo: codemirror/CodeMirror


text:
Add support for partial column reduction

This PR refactors the reduction kernel and adds support for partial reduction along the columns.

Thanks, @sgeor255 you need to add a read me explaining the reduction function and its parameters. Also, the function operations in a reduction inside the code and the class reduction in the code are not properly explained. You need to add doxygen comment on top of each properly explaining the parameters. See (https://github.com/codeplaysoftware/sycl-blas/blob/master/doc/Gemm.md) for readme and (https://github.com/codeplaysoftware/sycl-blas/blob/master/include/operations/blas3_trees.h#L61) for doxygen comments

Added more comments in the code and a file describing the kernel.

repo: codeplaysoftware/sycl-blas


text:
Output Module Values

Specifically, I am looking to output the DOTFILES_URI to reference as metadata.
Docs for reference: https://saturncloud.io/blog/terraform-how-to-output-a-field-from-a-module/

Check out #82 and let me know if this is what you were looking for.

LGTM

authors: djarbz stirby

repo: coder/modules


text:
use more interesting example for gh-pages exercise

just an html file isn't so exciting

I believe this is now solved.

authors: bast wikfeldt

repo: coderefinery/documentation


text:
Merge in new version of html-tag-validator

Just about ready to publish and test out new html-tag-validator on Unmasking HTML Emails course.
Previous version's files moved to .prev/ directory. New README.md contains updated documentation and todo.md / codeschool/htmlTagValidator#5 contains changes made.

:+1:

repo: codeschool/htmlTagValidator


text:
Robinhood authentication change

I was able to change Robinhood.py per the link below and continue to use this branch:
https://github.com/westonplatter/fast_arrow/issues/13#issuecomment-414080185

@gdgabq, Thanks... were we able to do the same in the master branch to get it to work.
Thanks

authors: codesociety gdgabq

repo: codesociety/friartuck


text:
Things

Purpose of PR

Type of PR

[ ] Documentation changes
[ ] Code changes
[ ] Test changes
[ ] CI-CD changes
[ ] GitHub Template changes

Issues Closed

Closes #issue_number

whoops

repo: codespaces-lab/kubernetes-in-codespaces


text:
comment coding-solution, while email is not verified

If you are writing a comment to someon's coding-solution, while your email isn't yet verified, hitting the apply/send-comment button seems dummy. He is clickable but nothing happens. There should be some message that informs the user about the need to verify the email adress.
Though it's frustrating that you are able to type in a long comment, but then fail at sending it.
Also, the http-response from this button-press returns a 200 code, but internally it contains an error.
Since this is an error, the http response 200 is wrong.

Fixed

authors: kazk mhombach


text:
CW notifications taking a loooong break ?

It seems starting from a week ago the code wars notifications have been a bit of issue.
You some times get notification, sometimes you don't but its there in you profile (Discourse tab) and sometimes you get none (as in neither the notification and  the discourse tab doesn't show you got a message).
Can also confirm I'm not the only one (since I asked another person) and they too seem to be suffering from it.

yes, CW notification is basically "not working" (...as you'd expect ;o )
from what I remember, the current "rules" are something like:

you get notifications when...:

you're the author of the thread
that's a comment on one of your solutions
a new issue/suggestion is opened on a kata where you did raise something before (that one is pretty weird, yes)

you DON'T get notifications when...:

the answer is posted with a spoiler flag
someone answer to any message you posted while you're not the author of the thread (meaning when "your answer is an answer too")

(I'm not sure this is fully documented in an issue yet, actually...)

@Blind4Basics :
Shouldn't I get notification when I'm the author of Kata and also have commented on said post ?

@Blind4Basics Even if there's a spoiler flag, he should still get notified. Because, well, he's the author.


text:
count size of array

Why: Count the size/length of an array
Closes #814
Closes #815
Closes #812
What's being changed: Nothing changed but 3 files were added (js/py/php)
Check off the following:

[X] I have reviewed my changes in staging (look for "Automatically generated comment" and click Modified to view your latest changes).
[X] For content changes, I have completed the self-review checklist.

Hey @0ME9A
Thanks for contributing to this project 😃
This PR will be reviewed and merged shortly 🚀

Thanks

repo: codinasion/codinasion-programme


text:
[Program]: Write a Scala program to print numbers from n to 1 without using a loop

Description
Write a Scala program to print numbers from n to 1 without using a loop
Input  : 5
Output : 5 4 3 2 1

How to contribute

Save the solution in program/program/print-numbers-from-n-to-1-without-using-a-loop/program/printNumbersFromNTo1WithoutUsingALoop.scala file

!assign

-->
📑 Description

🐞 Related Issue

Closes #3329
@harshraj8843 Please check my PR.
Thank You!

-->
📑 Description

🐞 Related Issue

Closes: #3329
@harshraj8843 Please check my PR.
Thank You!

repo: codinasion/codinasion


text:
Find volume of a cone

Description
Volume of cone = 1/3 × π × Radius^2 × Height
Radius : 2
Height : 3

Volume : 25.132741228718345

Program added successfully :tada:
Thanks for your contribution :hugs:

repo: codinasion/program


text:
Calculate simple interest

Description
Simple interest = principal amount * rate of interest * time
Principal : 1000
Rate      : 10
Time      : 5

Simple interest : 500

Program added successfully :tada:
Thanks for your contribution :hugs:


text:
[ 🚧 WIP ] Check Palindrome String using (TS, C, C++)

Why:

This PR is linked with issue #1559 #1541 #1539

Closes #1559
Closes #1541
Closes #1539
What's being changed:
A TypeScript file (CheckPalindromeString.ts) is added to the folder "program/check-palindrome-string" containing a function to check if the string is palindrome or not.
A C file (CheckPalindromeString.c) is added to the folder "program/check-palindrome-string" containing a function to check if the string is palindrome or not.
A C++ file (CheckPalindromeString.cpp) is added to the folder "program/check-palindrome-string" containing a function to check if the string is palindrome or not.

TS and CPP functions look good.
Copied and pasted c function to online editor, and it printed not a palindrome. Can you check the code?

Thank you!

Hey @victoriacheng15
I just re-checked the code and for me its working fine, the problem might be with the compilers as many people use different compilers. Currently I'm using GCC compiler and it works fine!
Here is the screenshot of it too!

Hey @victoriacheng15 I just re-checked the code and for me its working fine, the problem might be with the compilers as many people use different compilers. Currently I'm using GCC compiler and it works fine!
Here is the screenshot of it too!

I tried different online editor, and it works. Makes sense about the compilers.
Thank you for checking and contributing! 👍


text:
Change placeholder styling + add dates to episode cards

Closes #140
Not sure if the style for the placeholder text is quite right, but I hope the rest of you agree it should be different in some way. Usually placeholder text will be a bit transparent - for now I've just changed the color.

I think you're right in everything you said, it should be different, I thought about changing it before. And it should not be a different color, just more transparent. That's usually how I'm styling things here.
Something like:
color: rgba(255, 255, 255, 0.5);

Could you try something like that instead? I think it will look better, and it will always suit whatever changes we make to the theme colors.

authors: Madsn MinimumViablePerson

repo: codingblocks/podcast-app


text:
Roman penza patch 1

Added datetime_utils module that contains only one function at the moment: add_time function. This function takes a date as a string input in the 'yyyy-mm-dd' format and returns transpose of the date, given the specified number of days, months and years. To substract days, months, years from the date passed, use negative values.

Hi @RomanPenza
We have fixed the bug with docs deployment. However, we have also updated our contribution guide and your merge request currently conflicts with bullet point 3:
Duplicated functionality. For example, if your function is already done by another well known package.
In my opinion, the functionality that you have wrote can already be accessed using the datetime package, which is why I have challenged your merge request. If you disagree, please let me know by the 20th November or I will have to reject the merge request.
Apologies about this, I did originally agree to accept the function, but all active and future merge requests must adhere to the updated contribution guide.

authors: RomanPenza georgeRobertson

repo: codonlibrary/codonPython


text:
URL preview breaks some article pages

When visiting this page, it gives 500 internal server error.
https://cofacts.g0v.tw/article/1goyooqk2mtrh
the error log in production server (Nothing in Rollbar...)
site_1          | { TypeError: Cannot read property 'size' of null
site_1          |     at Hyperlinks (/srv/www/.next/server/bundles/pages/article.js:2955:18)
site_1          |     at d (/srv/www/node_modules/react-dom/cjs/react-dom-server.node.production.min.js:26:492)
site_1          |     at wa (/srv/www/node_modules/react-dom/cjs/react-dom-server.node.production.min.js:28:493)
site_1          |     at a.render (/srv/www/node_modules/react-dom/cjs/react-dom-server.node.production.min.js:33:48)
site_1          |     at a.read (/srv/www/node_modules/react-dom/cjs/react-dom-server.node.production.min.js:32:288)
site_1          |     at renderToString (/srv/www/node_modules/react-dom/cjs/react-dom-server.node.production.min.js:43:6)
site_1          |     at renderPage (/srv/www/node_modules/next/dist/server/render.js:275:26)
site_1          |     at Function.getInitialProps (/srv/www/.next/server/bundles/pages/_document.js:181:25)
site_1          |     at _callee$ (/srv/www/node_modules/next/dist/lib/utils.js:111:30)
site_1          |     at tryCatch (/srv/www/node_modules/regenerator-runtime/runtime.js:62:40) sourceMapsApplied: true }

looks like article page & reply page is both having issues
site_1          | { TypeError: Cannot read property 'size' of null
site_1          |     at Hyperlinks (/srv/www/.next/server/bundles/pages/article.js:2955:18)
site_1          |     at d (/srv/www/node_modules/react-dom/cjs/react-dom-server.node.production.min.js:26:492)
site_1          |     at wa (/srv/www/node_modules/react-dom/cjs/react-dom-server.node.production.min.js:28:493)
site_1          |     at a.render (/srv/www/node_modules/react-dom/cjs/react-dom-server.node.production.min.js:33:48)
site_1          |     at a.read (/srv/www/node_modules/react-dom/cjs/react-dom-server.node.production.min.js:32:288)
site_1          |     at renderToString (/srv/www/node_modules/react-dom/cjs/react-dom-server.node.production.min.js:43:6)
site_1          |     at renderPage (/srv/www/node_modules/next/dist/server/render.js:275:26)
site_1          |     at Function.getInitialProps (/srv/www/.next/server/bundles/pages/_document.js:181:25)
site_1          |     at _callee$ (/srv/www/node_modules/next/dist/lib/utils.js:111:30)
site_1          |     at tryCatch (/srv/www/node_modules/regenerator-runtime/runtime.js:62:40) sourceMapsApplied: true }
site_1          | { TypeError: Cannot read property 'size' of null
site_1          |     at Hyperlinks (/srv/www/.next/server/bundles/pages/reply.js:2950:18)
site_1          |     at d (/srv/www/node_modules/react-dom/cjs/react-dom-server.node.production.min.js:26:492)
site_1          |     at wa (/srv/www/node_modules/react-dom/cjs/react-dom-server.node.production.min.js:28:493)
site_1          |     at a.render (/srv/www/node_modules/react-dom/cjs/react-dom-server.node.production.min.js:33:48)
site_1          |     at a.read (/srv/www/node_modules/react-dom/cjs/react-dom-server.node.production.min.js:32:288)
site_1          |     at renderToString (/srv/www/node_modules/react-dom/cjs/react-dom-server.node.production.min.js:43:6)
site_1          |     at renderPage (/srv/www/node_modules/next/dist/server/render.js:275:26)
site_1          |     at Function.getInitialProps (/srv/www/.next/server/bundles/pages/_document.js:181:25)
site_1          |     at _callee$ (/srv/www/node_modules/next/dist/lib/utils.js:111:30)
site_1          |     at tryCatch (/srv/www/node_modules/regenerator-runtime/runtime.js:62:40) sourceMapsApplied: true }

Fixed by #143, closing

repo: cofacts/rumors-site


text:
auto-revert if unedited -- just put a status message up.

Also probably auto-save?  If underlying file has not changed, and we have edits sitting there for some kind of timeout period, then probably just autosave?  instead of doing the # file thing.

did the auto revert on unchanged.  not sure about autosave..

repo: cogentcore/cogent


text:
GetRowAsync does not deserialize result into custom data model

I have a row in a CDF Raw table as below:

If I try to retrieve specific row using key as below:
var row = await client.Raw.GetRowAsync<Dictionary<string, JsonElement>>(cdfDevDbName, "PDPStageStoppedMessage", "fb56afe7-ea31-4af1-9481-ee100fb3f438");
System.Console.WriteLine($"RawRow: {row}");
System.Console.WriteLine($"RawRow Columns: {row.Columns}");
System.Console.WriteLine($"JobId: {row.Columns["JobId"]}");
I get below results:
RawRow: RawRow1 {     Key = "fb56afe7-ea31-4af1-9481-ee100fb3f438"     Columns = {         JobId = 873bc853-bb55-4b56-bd0d-8501334ab9a5         WellId = 86ccce2a-c20e-4c96-a4e7-166aaabc9d0b         StageId = 339fec85-f550-4ed9-8bad-b3bd4b034da0         Workflow = PDP     }     LastUpdatedTime = 1680220613823 } RawRow Columns: System.Collections.Generic.Dictionary2[System.String,System.Text.Json.JsonElement]
JobId: 873bc853-bb55-4b56-bd0d-8501334ab9a5
But when I try:
var row = await client.Raw.GetRowAsync(cdfDevDbName, "PdpStageStoppedMessage", "fb56afe7-ea31-4af1-9481-ee100fb3f438");
System.Console.WriteLine($"RawRow: {row}");
System.Console.WriteLine($"RawRow Columns: {row.Columns}");
System.Console.WriteLine($"JobId: {row.Columns.JobId}");
where:
public class PdpStageStoppedMessage
{
public string JobId { get; set; }
public string WellId { get; set; }
public string StageId { get; set; }
public string Workflow { get; set; }
}
I get below:
RawRow: RawRow`1 {
Key = "fb56afe7-ea31-4af1-9481-ee100fb3f438"
Columns = Test.Program+PdpStageStoppedMessage
LastUpdatedTime = 1680220613823
}
RawRow Columns: Test.Program+PdpStageStoppedMessage
JobId:
Why does GetRowAsync not deserialize the result in RawRow.Columns to my custom data model?
If this is not the expected usage, how can we deserialize retrieved RawRow data into our custom models?

Closing this issue. The table was created manually through CDF portal. Column name first letters were capitalized, JobId, WellId and so on.
When the .net api tries to read/write, the .net model property names get serialized as lower cased.
Hence read to custom model was failing due to mismatch.
Read works fine when data was first written using the sdk.

repo: cognitedata/cognite-sdk-dotnet


text:
Update license copyright owner

As title. cc @hayesgb

Thanks, @jrbourbeau. Looking good, this goes in :tada:

authors: jrbourbeau ncclementi

repo: coiled/coiled-runtime


text:
使用脚本无法关闭和重启客户端

执行命令bash status.sh c的时候，发现无法关闭客户端，提示一下错误
status.sh: line 1109: /etc/init.d/status-server: No such file or directory

使用vi查看脚本，发现1109行执行的是/etc/init.d/status-server stop

把status-server改成status-client就能停止客户端了，希望作者能更改一下

使用的版本是这个，ServerStatus 一键安装管理脚本 [v0.2.0]

repo: cokemine/ServerStatus-Hotaru


text:
colcon test exits with exit code 0 even when test fails

colcon test returns with error code 0 even when the test fails.
Example test:
cmake_minimum_required(VERSION 3.16)
set(PROJECT_NAME fail_test)
project(${PROJECT_NAME} VERSION 0.0.1)

find_package(ament_cmake)

ament_add_test(fail COMMAND bash -c "echo colcon test should have non zero exit code! >&2; exit 1")

ament_package()

Running the above with colcon test --event-handlers console_direct+
Starting >>> fail_test
UpdateCTestConfiguration  from :/home/koonpeng/ws-osrf/tmp/build/fail_test/CTestConfiguration.ini
Parse Config file:/home/koonpeng/ws-osrf/tmp/build/fail_test/CTestConfiguration.ini
   Site: ubuntu2204
   Build name: (empty)
 Add coverage exclude regular expressions.
Create new tag: 20221203-0158 - Experimental
UpdateCTestConfiguration  from :/home/koonpeng/ws-osrf/tmp/build/fail_test/CTestConfiguration.ini
Parse Config file:/home/koonpeng/ws-osrf/tmp/build/fail_test/CTestConfiguration.ini
Test project /home/koonpeng/ws-osrf/tmp/build/fail_test
Constructing a list of tests
Done constructing a list of tests
Updating test list for fixtures
Added 0 tests to meet fixture requirements
Checking test dependency graph...
Checking test dependency graph end
test 1
    Start 1: fail

1: Test command: /usr/bin/python3.10 "-u" "/opt/ros/humble/share/ament_cmake_test/cmake/run_test.py" "/home/koonpeng/ws-osrf/tmp/build/fail_test/test_results/fail_test/fail.xml" "--package-name" "fail_test" "--command" "bash" "-c" "echo colcon test should have non zero exit code! >&2" " exit 1"
1: Test timeout computed to be: 60
1: -- run_test.py: invoking following command in '/home/koonpeng/ws-osrf/tmp/build/fail_test':
1:  - bash -c echo colcon test should have non zero exit code! >&2  exit 1
1: colcon test should have non zero exit code!
1: -- run_test.py: return code 0
1: -- run_test.py: generate result file '/home/koonpeng/ws-osrf/tmp/build/fail_test/test_results/fail_test/fail.xml' with failed test
1: -- run_test.py: verify result file '/home/koonpeng/ws-osrf/tmp/build/fail_test/test_results/fail_test/fail.xml'
1/1 Test #1: fail .............................***Failed    0.05 sec

0% tests passed, 1 tests failed out of 1

Total Test time (real) =   0.05 sec

The following tests FAILED:
          1 - fail (Failed)
Errors while running CTest
Output from these tests are in: /home/koonpeng/ws-osrf/tmp/build/fail_test/Testing/Temporary/LastTest.log
Use "--rerun-failed --output-on-failure" to re-run the failed cases verbosely.
--- stderr: fail_test
Errors while running CTest
Output from these tests are in: /home/koonpeng/ws-osrf/tmp/build/fail_test/Testing/Temporary/LastTest.log
Use "--rerun-failed --output-on-failure" to re-run the failed cases verbosely.
---
Finished <<< fail_test [0.07s]  [ with test failures ]

Summary: 1 package finished [0.20s]
  1 package had stderr output: fail_test
  1 package had test failures: fail_test

and checking the exit code:
$ echo $?
0

Running ctest directly:
$ ctest --test-dir build/fail_test/
Internal ctest changing into directory: /home/koonpeng/ws-osrf/tmp/build/fail_test
Test project /home/koonpeng/ws-osrf/tmp/build/fail_test
    Start 1: fail
1/1 Test #1: fail .............................***Failed    0.06 sec

0% tests passed, 1 tests failed out of 1

Total Test time (real) =   0.06 sec

The following tests FAILED:
          1 - fail (Failed)
Errors while running CTest
Output from these tests are in: /home/koonpeng/ws-osrf/tmp/build/fail_test/Testing/Temporary/LastTest.log
Use "--rerun-failed --output-on-failure" to re-run the failed cases verbosely.

$ echo $?
8

This is intentional behavior. To get the behavior you seem to desire, use the --return-code-on-test-failure argument to colcon test.
Unlike ctest, colcon differentiates between a "failure to test" and a "test failure" using the return code. The former could occur if, for example, you were missing dependencies to run tests, such as an ImportError when invoking pytest or if ctest wasn't found. If that would have been the case, you would have a non-zero return value from the colcon test invocation even without --return-code-on-test-failure.
The primary colcon workflow for testing also involves another step: the use of the test-result verb. That can also give you a non-zero return code if there were any test failures, and aggregates all of the test failure information for the whole workspace (even across multiple colcon test invocations).

Thanks for the explanation, just wondering what is the rational to go with this approach? All the test runners I used before exit with non-zero exit code when the test fails, CIs also usually look at the exit code to determine success/failure.

what is the rational to go with this approach?

This decision predates my time with colcon, but these threads capture some relevant insights:

colcon/colcon-core#21
colcon/colcon-core#146
colcon/colcon-cmake#3

authors: cottsay koonpeng

repo: colcon/colcon-core


text:
feature: enhance to a batch job scheduler

Hi at collectiveidea,
I'm using delayed_job with great success.
Today I enabled delayed_job:cron, seems to work quite well.
I'd like to discuss with yours if it would be feasible,
to extend delayed_job towards a more generic batch job engine.
One thing that comes to my mind,
I want to enqueue a job to run only once (or fail otherwise)
(we might need a new columns like :max_attempts)
I'd also like to add more interaction with the jobs.
There should be a shell interface to admin the jobs.

Closing stale


text:
What to do with BaseURI in the RDF4J parser?

We currently parse a RDF file as follows:
Model model = Rio.parse(new FileInputStream(file), "http://example.uri", RDFFormat.RDFXML);
It's not working unless we add a (random) baseURI (like http://example.uri for example).
Why is this? And how can we make this a bit more clean?

Currenlty we decided to use PowSyBl (CgmesModel part) to read the CIM File.
So this issue is not applicable anymore.

authors: Flurb dlabordus

repo: com-pas/compas-cim-mapping


text:
fix: remove 2 Dockerfiles that reference deprecated versions of Go

amazon linux Dockerfile is configured for go v1.12.x -- it is clearly unused
tests Dockerfile is configured for go v1.15.x -- it's clearly unused

The presence of these files is a bug/technical debt or such.  They make the code harder to read and understand and create the impression that they may serve a purpose.
closes: #2134

PR checklist

[ ] Tests written/updated
[x] Changelog entry added in .changelog (we use unclog to manage our changelog)
[ ] Updated relevant documentation (docs/ or spec/) and code comments
[ ] Title follows the Conventional Commits spec

Nice catch @andynog -- I'll address that now

@andynog I just reviewed the Pr and I do believe that it updates the make file as well.

ah :).  Also that one lol :)

test/docker/Dockerfile is used by test_integrations cmd, which I'm not sure we use anymore. So we should remove it along with any sub-commands it calls.

Makes sense to me. I'll have a look.

@melekes -- the Dockerfile was broken anyhow, as it tried to build make tools which no longer exists.
I think it might make sense to put the rest of this into an issue, unless you think it is alright to change the e2e image to include a folder, let's call it /testnet in which case I think that we could make this a part of the e2e image.
So, now instead of removing this extra Dockerfile, it's fixed, so that when we next make a release, that process will go smoothly.

authors: faddat melekes

repo: cometbft/cometbft


text:
Helper tag can be rendered in layout, but not via cms_snippet_content

I have a helper,
which can be rendered correctly in my Layouts
{{ cms:helper:pages_menu }}

but when it is put in my snippet and was triggered in my application.html.erb
<%= cms_snippet_content('header').html_safe %>

The whole string is not rendered
Snippet  - "header"
<div>
         {{ cms:helper:pages_menu }}
</div>

Try cms_snippet_render helper. It will do tag rendering as well.

authors: GBH arthurtalkgoal

repo: comfy/comfortable-mexican-sofa


text:
Removed self-assignments

Removed self-assignments from manager.py and test_lateral_mpc.py

Can you make sure the submodules are not changed?

Submodules are still changed.

repo: commaai/openpilot


text:
refactor OMX encoder

1.convert to c++
2.downscale on GPU

Closing since the code has changed so much

Closing since the code has changed so much

authors: adeebshihadeh deanlee


text:
Hyundai CAN FD: log hvac FW version

https://github.com/commaai/cereal/pull/427

hopefully this is all we need!


text:
Ford: detect missing LKAS from EPS configuration

Description
Detect when the PSCM isn't configured for Traffic Jam Assist/Lane Centering Assist and disable openpilot.
In tools such as Forscan these two features are configured seperately, but I don't know how every EPS/model would respond to only having one set, and whether openpilot could work properly, so we check for both.
openpilot will only check this during fingerprinting, so upon changing their PSCM configuration, the user would have to clear the car params cache. (I think?)
Verification

[x] I collected the "As-Built data" for thousands of VINs (downloaded from Ford) and could reliably determine whether the car had ACC/TJA features enabled
[ ] Pending verification on openpilot logs using responses gathered with https://github.com/commaai/openpilot/pull/31569

Route with LCA/TJA disabled: TODO
Route with LCA/TJA enabled: TODO

I couldn't find a CAN signal denoting if LCA was allowed or not across cars with the LCA byte and without, so I think checking this is the best option for now. This becomes more important after https://github.com/commaai/openpilot/pull/31124 which would fingerprint many more vehicles. Right now, we would enable on a car without LCA, but I'm not sure what would happen after. I'm guessing no fault would be logged.
Ford route w/ no TJA or LCA: 58609189e4a2bac4/2023-07-18--19-35-17

Checked 140 total dongles (one seg each from 11k routes) on 0.9.7 after https://github.com/commaai/openpilot/pull/31569 was merged on all remotes, 57 non-CAN FD dongles. So far no car was missing the AsBuilt data, except some CAN FD users (Lighting, F-150, Mach-E).
I checked the F-150 brochure, and it at least always packages ACC with LCA, never LCA without ACC, so our ACC check should catch any lack of API. We can further explore this in the future if needed.

The nonAdaptive cruise check we have catches all of them, as TJA was never True with LCA being False. I just noticed this, so we don't need this PR as a pre-req for https://github.com/commaai/openpilot/pull/31124 as I had thought.
Here's the Bronco brochure, ACC is packaged with LCA like the Q4 F-150:

https://cdn.dealereprocess.org/cdn/brochures/ford/2021-broncosport.pdf

The only model I know has this potential problem is the Escape 2020. Here's the brochure: https://cdn.dealereprocess.org/cdn/brochures/ford/2020-escape.pdf

"Adaptive Cruise Control" is part of the "Co-Pilot360 Assist" package (available on SE/SEL, standard on Titanium)
"Lane Centering" is part of "Co-Pilot360 Assist+" package (standard on Titanium)

So, the Escape 2020 SE/SEL trims can have ACC without LCA.

@incognitojam if you add a new event and open a PR to cereal we can review and copy and merge

@incognitojam can you open a new PR for the alert again?

authors: incognitojam sshane


text:
Wrong link in the Roadmap/Resources

IN Roadmaps/DevRel , when I click on the "Learning in public and getting opportunities" and on " How to become DevRel " it is showing some other Blog. Detailed in below screenshots.

Thanks for reporting @Sreekar-Shodhan. Will be fixed soon

@Sreekar-Shodhan this has been fixed now, thanks for reporting

authors: Sreekar-Shodhan kaiwalyakoparkar

repo: commclassroom/roadmaps


text:
issuance: Unconfirmed asset issuance transaction - does not refresh showing confirmed

Issue an asset to the wallet and transaction remains unconfirmed. Double clicking on the unconfirmed transaction in electrum wallet shows below error.
Wallet must be closed and then reopened in order to see tx's confirm (despite many blocks)
Traceback
Traceback (most recent call last):
File "/Users/cryptopoly/cb-client-wallet/electrum/gui/qt/history_list.py", line 302, in on_doubleclick
self.parent.show_transaction(tx)
File "/Users/cryptopoly/cb-client-wallet/electrum/gui/qt/main_window.py", line 810, in show_transaction
show_transaction(tx, self, tx_desc)
File "/Users/cryptopoly/cb-client-wallet/electrum/gui/qt/transaction_dialog.py", line 57, in show_transaction
d = TxDialog(tx, parent, desc, prompt_if_unsaved)
File "/Users/cryptopoly/cb-client-wallet/electrum/gui/qt/transaction_dialog.py", line 163, in init
self.update()
File "/Users/cryptopoly/cb-client-wallet/electrum/gui/qt/transaction_dialog.py", line 256, in update
fee = self.tx.get_fee()
File "/Users/cryptopoly/cb-client-wallet/electrum/transaction.py", line 1153, in get_fee
return self.input_value() - self.output_value()
File "/Users/cryptopoly/cb-client-wallet/electrum/transaction.py", line 1140, in input_value
return sum(x['value'] for x in self.inputs())
File "/Users/cryptopoly/cb-client-wallet/electrum/transaction.py", line 1140, in
return sum(x['value'] for x in self.inputs())
KeyError: 'value'

Fixed too by @tomt1664

authors: cryptopoly nkostoulas

repo: commerceblock/cb-client-wallet


text:
Use js-auth for token decoding and new Auth API on test suite

Description
This Task will add js-auth for token decoding and remove the jwt creation for test suite purposes.

:tada: This issue has been resolved in version 4.9.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

repo: commercelayer/mfe-checkout


text:
Add integration tests and fixes for ts-sdk-v3

I added some integration tests for the middlewares and updated the middlewares as well.
JIRA: https://commercetools.atlassian.net/browse/DEVX-358

Please include a release changeset for this implementations. Thank you.

Please include a release changeset for this implementations, I believe we will be needing one right?

https://github.com/commercetools/commercetools-sdk-typescript/pull/708/commits/227d90a0de62777b8efbbb67a5e1b1edd320ab4c

authors: ajimae lojzatran


text:
yesod-simple I18N

I can't find the internationalization stuff in yesod-simple, why??? I have manage to configure it with persistent-odbc, but messages directory isn't present. Do I need to setup the I18N stuff myself?
Side note: Yesod is really awesome!

The i18n stuff is no longer included in the scaffold, you'll need to set it
up yourself.
Glad you're liking Yesod :)
On Tue, Mar 1, 2016 at 10:06 PM, FtheBuilder notifications@github.com
wrote:

I can't find the internationalization stuff in yesod-simple, why??? I have
manage to configure it with persistent-odbc, but messages directory isn't
present. Do I need to setup the I18N stuff myself?
Side note: Yesod is really awesome!
—
Reply to this email directly or view it on GitHub
https://github.com/commercialhaskell/stack-templates/issues/42.

authors: felipexpert snoyberg

repo: commercialhaskell/stack-templates


text:
feat: support new pre-commit hook check-merge-base

closes #195

Summary by CodeRabbit

New Features

Introduced a new pre-commit hook, check-merge-base, to ensure branches are rebased onto the target branch during commits.

Documentation

Updated README.rst to include the new check-merge-base hook and modified command usage for clarity and consistency.

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 97.27%. Comparing base (67a6560) to head (6bba256).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #197   +/-   ##
=======================================
  Coverage   97.27%   97.27%
=======================================
  Files           7        7
  Lines         294      294
=======================================
  Hits          286      286
  Misses          8        8

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

authors: codecov-commenter shenxianpeng

repo: commit-check/commit-check


text:
Option to specify MANUAL_VERSION

Hi. As described in the cli cz bump MANUAL_VERSION, is it possible to specify the MANUAL_VERSION in the Github Action? If not, can the option be added? Thank you!

Hi again. Can this be accomplished? Thanks.

repo: commitizen-tools/commitizen-action


text:
feature: use tox for testing

Move test automization to test from travis, this allows to easily test outside of travis

For some reason in Travis there are way more tests passing than in my local machine :smile:

For those failing 7 tests I wonder if they are the same ones that were marked as unsupported features in the last successful build (https://travis-ci.org/common-workflow-language/cwl-tes/jobs/327356336)...

Otherwise this looks like a nice improvement! I have never tried using tox before.

I've seen that the package published lacks the readme, so I took he liberty to add it, this is how it looks like (on the test pypi): https://test.pypi.org/project/cwl-tes-random/
I could also add git-tag-based package version instead of parsing __init__.py with regex.
Is there any way to add the 7 failing tests to unsupported if they are ideed the failing ones?

Thanks for updating the README as well.
As far as versioning goes, I prefer to use semantic versioning.
I suspect the reason they are failing rather than being marked as unsupported may have something to do with your updating the cwltest version

The git-tag-based system is only to avoid repetition, set the (semantic) version as a tag and the package version comes for free.
The only change it would produce is that untagged commits would compile to a package version with the closest tagin the predecessors with the commit's hash appended. e.g. 2.0.0-65b8c0f.
As for the tests, before this PR the cwltest version was not upper-bound in requirements.txt. I'll check if fixing a particular version solves the issue.

Huh, it's failing when building the package on python 3.4, it works fine on my machine :/

Alternatively I can conly allow 2.7, 3.5 and 3.6, as it is on master. I've tried to debug the build on travis, but couldn't find why

authors: adamstruck psafont

repo: common-workflow-language/cwl-tes


text:
5.1.7 FPT_VIV_EXT.1.2

It's unclear what the pupose of the detailed "should enforce the following" list is.  This requirement just needs attestation, so explanation of what might be valuable tests has no place here.
Spurious detail in a requirement that just needs attestation.

Let's see if the TC comes up with a test before addressing this.

Let's see if the TC comes up with a test before addressing this.

I took out the attestation and replaced it with a TSS description. The list in the notes now serves as examples for the TSS.

repo: commoncriteria/virtualization

license: Unlicense


text:
App corrupts Commons description

App erroneously modified |description= to |descriptio
https://commons.wikimedia.org/w/index.php?title=File%3A九十九里浜_7.jpg&type=revision&diff=655568871&oldid=655568708
Another example: https://commons.wikimedia.org/w/index.php?title=File:Fishtbnk_truck_near_Kujukuri_beach.jpg&diff=prev&oldid=656180711
I believe that happened when editing the caption.
Current master

@nicolas-raoul Could you share the exact steps to reproduce this issue?

Also pinging @Ayan-10 as this seems related to https://github.com/commons-app/apps-android-commons/pull/4672

@madhurgupta10 @nicolas-raoul I have investigated the issue. This issue occurs when the file doesn't have any description in any language and user only add a caption without a description. Like this file: https://commons.wikimedia.org/w/index.php?title=File:Fishtbnk_truck_near_Kujukuri_beach.jpg&diff=prev&oldid=656180711 doesn't have any description or caption, now if user add a caption in a language without a description in the editor screen. This issue will occur.
The lines, causing the issue are
Line 157: buffer.deleteCharAt(buffer.length - 1)
Line 158: buffer.deleteCharAt(buffer.length - 1)

in the DescriptionEditActivity. But these lines are important if the file has any description. I think the issue can be resolved by checking if any description is present in the list.
Thanks

@madhurgupta10 @nicolas-raoul I have investigated the issue. This issue occurs when the file doesn't have any description in any language and user only add a caption without a description. Like this file: https://commons.wikimedia.org/w/index.php?title=File:Fishtbnk_truck_near_Kujukuri_beach.jpg&diff=prev&oldid=656180711 doesn't have any description or caption, now if user add a caption in a language without a description in the editor screen. This issue will occur.
The lines, causing the issue are
Line 157: buffer.deleteCharAt(buffer.length - 1)
Line 158: buffer.deleteCharAt(buffer.length - 1)

in the DescriptionEditActivity. But these lines are important if the file has any description. I think the issue can be resolved by checking if any description is present in the list.
Thanks

Thanks for the detailed investigation, I believe these two lines are added to remove the extra ,    from the buffer string, in that case, I think replacing them with a regex pattern is a much better solution

repo: commons-app/apps-android-commons


text:
Fixing issue #2090 Searching night mode

Searching for images or categories in night mode works but the words doesn't show neither the recent researches.
Fixes #2090 Searching on Night Mode
What changes did you make and why?
Ux changes to be more clean on night mode
Tests performed (required)
Exploratory testing
Screenshots showing what changed (optional - for UI changes)

Codecov Report

Merging #2095 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #2095   +/-   ##
======================================
  Coverage    4.02%   4.02%
======================================
  Files         226     226
  Lines       11467   11467
  Branches     1064    1064
======================================
  Hits          461     461
  Misses      10972   10972
  Partials       34      34

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 677e009...2420127. Read the comment docs.

Thanks for your first time contribution @pereiraJr :) I have made some notes, please consider them. By the way it can be nice adding before after UI comparisons for such UI changes
Basically before:

And after:

There is a nice UI improvement. But you changed some of files you shouldn't. Whenever you fixed them we can review your PR again.

As final decision, I request changes @pereiraJr :)

authors: codecov-io neslihanturan pereiraJr


text:
Added Forgot Password Unit Test

Description
Added Forgot Password Unit Test for Login Activity in Kotlin
Fixes #2686 Write Unit Test for Login Activity
What changes did you make and why?
Added Unit Test for Forgot Password URL
Tests performed
Tested betaDebug on Xiaomi Mi A1 with API level 28.
Logs
Testing started at 06:36 PM ...
03/23 18:36:24: Launching isForgotPasswordWo...()
No apk changes detected since last installation, skipping installation of C:\Users\madhu\Desktop\apps-android-commons\app\build\outputs\apk\beta\debug\app-commons-v2.10.1-master-beta-debug.apk
No apk changes detected since last installation, skipping installation of C:\Users\madhu\Desktop\apps-android-commons\app\build\outputs\apk\androidTest\beta\debug\app-commons-v2.10.1-master-beta-debug-androidTest.apk
Running tests
$ adb shell am instrument -w -r   -e debug false -e class 'fr.free.nrw.commons.LoginActivityTest#isForgotPasswordWorks' fr.free.nrw.commons.beta.test/androidx.test.runner.AndroidJUnitRunner
Connected to process 21700 on device xiaomi-mi_a1-7af99b9c0404
Started running tests
Tests ran to completion.
Test Passed

Codecov Report

Merging #2723 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #2723   +/-   ##
======================================
  Coverage    2.71%   2.71%
======================================
  Files         267     267
  Lines       12838   12838
  Branches     1141    1141
======================================
  Hits          349     349
  Misses      12463   12463
  Partials       26      26

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7302d4...b1bab0f. Read the comment docs.

@maskaravivek Sorry didn't see that, Closing this PR since the test is already covered #2700


text:
Update to Gradle 5

Description (required)
Fixes #2824 Update to Gradle 5
What changes did you make and why?
Updated Gradle from version 4.10 to 5.3.1 to
get faster builds and help towards fixing #1941.
Added 'org.apache.commons:commons-lang3:3.8.1'
to fix import errors.
Tested {betaDebug} on Nexus 5X Emulator with API level {24}.
Screenshots showing what changed (optional - for UI changes)
Need help? See https://support.google.com/android/answer/9075928

Note: Please ensure that you have read CONTRIBUTING.md if this is your first pull request.

Codecov Report

Merging #2860 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #2860   +/-   ##
======================================
  Coverage    3.42%   3.42%
======================================
  Files         246     246
  Lines       12193   12193
  Branches     1071    1071
======================================
  Hits          418     418
  Misses      11744   11744
  Partials       31      31

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 07c335e...cefff8e. Read the comment docs.

I am on board with the Gradle update. Not so sure about adding the dependency. Could you please elaborate on what import errors are being experienced, and how the dependency fixes them? Also, should that be in a separate PR from the Gradle update as it addresses a different issue?

I am on board with the Gradle update. Not so sure about adding the dependency. Could you please elaborate on what import errors are being experienced, and how the dependency fixes them? Also, should that be in a separate PR from the Gradle update as it addresses a different issue?

I believe it's been added to build.gradle as it should really have been an app dependency, but previously it just worked because either Gradle 4 added it automatically or some other library we use depended on it. As this updates Gradle to Gradle 5, the dependency is no longer automatically included. So really this PR does not add a dependency, it just makes it explicit.

Ah, thanks for clarifying! In that case I am good with it. Sorry for the slow response, as I have just returned back from the hackathon trip. :)

authors: aadilahmed codecov-io domdomegg misaochan


text:
#3601 [structured-commons] Wrong thumbnails at the "depictions" step when uploading

Description (required)
Fixes #3601
What changes did you make and why?
fix imageview rendering code
Rework Rx flow to return lists of data that are inserted into LiveData
Tests performed (required)
TestedProdDebug on Nexus5x with API level 27
Screenshots (for UI changes only)
Need help? See https://support.google.com/android/answer/9075928

Even if this were passing the tests I don't think it is ready yet, I realised I had forgot to retrieve the selected depictions and insert them at top of the list and the images began to load a bit weirdly, will investigate further

Codecov Report

Merging #3696 into master will increase coverage by 0.06%.
The diff coverage is 48.27%.

@@             Coverage Diff             @@
##             master   #3696      +/-   ##
===========================================
+ Coverage      7.35%   7.42%   +0.06%
- Complexity      335     340       +5
===========================================
  Files           292     292
  Lines         12883   12874       -9
  Branches       1016    1014       -2
===========================================
+ Hits            948     956       +8
+ Misses        11858   11842      -16
+ Partials         77      76       -1

Impacted Files
Coverage Δ
Complexity Δ

.../nrw/commons/explore/depictions/DepictsClient.java
0.00% <0.00%> (ø)
0.00 <0.00> (ø)

...s/explore/depictions/SearchDepictionsRenderer.java
0.00% <0.00%> (ø)
0.00 <0.00> (ø)

...nrw/commons/repository/UploadRemoteDataSource.java
0.00% <0.00%> (ø)
0.00 <0.00> (ø)

.../free/nrw/commons/repository/UploadRepository.java
0.00% <ø> (ø)
0.00 <0.00> (ø)

...n/java/fr/free/nrw/commons/upload/FileProcessor.kt
0.00% <0.00%> (ø)
0.00 <0.00> (ø)

...free/nrw/commons/upload/UploadDepictsRenderer.java
0.00% <0.00%> (ø)
0.00 <0.00> (ø)

...ee/nrw/commons/upload/depicts/DepictsFragment.java
0.00% <0.00%> (-1.62%)
0.00 <0.00> (-1.00)

...mons/upload/mediaDetails/UploadMediaPresenter.java
67.85% <0.00%> (-2.52%)
17.00 <0.00> (ø)

...commons/upload/structure/depictions/DepictModel.kt
0.00% <0.00%> (ø)
0.00 <0.00> (ø)

...ree/nrw/commons/upload/depicts/DepictsPresenter.kt
88.88% <88.88%> (ø)
17.00 <17.00> (?)

... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 67faa40...39d0eee. Read the comment docs.

I can't manually test this PR because I experience this bug #3706 and can not go further steps:/ How do you test?

@neslihanturan turn do not keep activities off

authors: codecov-io macgills neslihanturan


text:
Convert "__" to ":" in enviroment variables

The documentation states that "__" in enviroment variable names should be converted to ":". This seems to be missing in the implementation, and is added by this PR.

The failure of the checks seems to be caused by the "Cargo Test" step using unstable options while the installed compiler is apparenly stable.

This is a good catch. Not sure why the CI workflow for PRs is behaving strangely. I shouldn't have to manually kick it off. I have several other Rust repos setup the same way (or at least they are supposed to be). I'll look into. Regardless, these changes will merge in. It was definitely an oversight.

:+1: Thanks/

I've added the flag to use nightly. Strange that this has been working. Running on a machines that just happen to have nightly installed seems an unlikely coincidence. I followed the same process a few other repos. I don't need nightly for building. I only need it for the CI test output reports.
I've added the necessary change, tested it, and merged it. I re-ran against your changes, but it's still using the old workflow definition. You might have to pull in the changes, rebase, and push again. If that's too much hassle, I can also cherry pick your changes in.

Hmmm. I'm not very used to do PRs between repos like this. It now says "1 workflow awaiting approval". As far as I can tell it's your approval, because we're merging into your repo. But I'm not completely sure...

I'm not sure why the workflow didn't just automatically run. I feel like it should and has in the past. My Rust projects are the first time I've used GitHub workflows to run CI for PRs so I'm still learning some of its quirks. Once you pulled in the updated workflow, it's happy now. 😄
Aside: All my other Rust repos use the same configuration and automatically run at least once a week. I just noticed they all started failing for the same reason. Strange since they've all be stable for months. 🤷🏽♂ At least I know the fix.
Thank again.

I discovered some information about workflows in public forks. This is apparently from people abusing it. Effectively, the first time a PR from a fork is run and you are a first-time contributor to the repo, it requires approval. After that, it doesn't.
https://docs.github.com/en/actions/managing-workflow-runs/approving-workflow-runs-from-public-forks
I've heard of malicious people adding crypto mining scripts into builds/workflows and submitting PRs which triggers them to run automatically. Lame that it messes things up for the rest of us. I could turn it off, but it's probably a reasonable, one-time inconvenience. GTK for the future.

FYI, I bumped the patch version and published to crates.io

authors: commonsensesoftware peterallin

repo: commonsensesoftware/more-rs-config


text:
V2 - Project Console - Able to enroll foundation for a project level CLA Group

Create CLA Group at Project Level

Enroll foundation to existing CLA Group

Observed that foundation is enrolled and project level CLA Group is converted to Foundation level CLA Group

To test/evaluate:
Create CLA Group A
Assign projects:
Foundation A -> not assigned to CLA Group A
---- Project A1 -> Assigned to CLA Group A
---- Project A2 -> Assigned to CLA Group A
User comes back to edit ‘CLA Group A’ project assignment: user should not be able to assign ‘Foundation A’ to the CLA Group. This can only happen initially (for now).  Need to update the validation logic for the enroll API endpoint to prevent users from selecting/adding the 'Foundation A' on when editing.

Now we are not able to enroll foundation for a project level CLA Group, So issue is fixed as expected
Test Data:
foundation project_sfid : a096s0000003k9pAAA
Child project_sfid : a096s0000003kFRAAY
Child project_sfid : a096s0000003mDnAAI
Cla_group_id : f9dcf171-6e75-440b-bfad-6d22c12fb4ce
Below Scenario covered :

Try to enroll foundation project to project level CLA Group
Results : As expected foundation project is not enroll in project level CLA group
Foundation project API Response : 400 Bad Request - Unable to enroll salesforce foundation project: a096s0000003k9pAAA in project level cla-group. [https://prnt.sc/w267w3](https://prnt.sc/w267w3)

Try to enroll existing project to project level CLA Group
Enroll Existing project Response: 400 Bad Request - bad request: invalid project_sfid provided: [a096s0000003kFRAAY]. One or more of the provided projects are already enrolled in an existing cla_group [https://prnt.sc/w26lsh](https://prnt.sc/w26lsh)

Enroll fresh project to project level CLA Group
Enroll new project  API Response: Getting 200 OK status & x-request-id in RESPONSE HEADERS [https://prnt.sc/w26nyn](https://prnt.sc/w26nyn)

authors: dealako nirupamav thakurveerendras

repo: communitybridge/easycla


text:
Closing and opening LN channels - White screen issue

I closed both my LN channels. When trying to open new ones I get the above view. When re-starting br I get the same result. I'm unable to get past this screen.
I also tried deleting / reinstalling 0.1.8 still getting the same screen. Not able to setup new channels or move backwards, forward or see main pages.

Fixed, thank you!

repo: companyzero/bisonrelay

license: ISC


text:
figure out best practices for keeping this fork up to date with upstream improvements

for now we can just rebase our commits on top of upstream changes but...
https://github.com/comses/planning/issues/263
https://meta.discourse.org/t/beginners-guide-to-using-discourse-themes/91966

could add something like https://github.com/wei/pull. I suppose the workflow would be automatically syncing main and then getting PRs to a dev branch

authors: alee sgfost

repo: comses/discourse-mint-theme


text:
🛑 shiyouhuagong is down

In da0fbe1, shiyouhuagong (https://www.shiyouhuagong.com.cn) was down:

HTTP code: 0
Response time: 0 ms

Resolved: shiyouhuagong is back up in 0a8f871 after 1 day, 24 minutes.

repo: conanlm/upptime-demo


text:
Readd the zoom level indicator to the editor UI

## Description
The zoom level indicator was lost when the top menu was dropped, and this PR readds it in two forms:

a simple label and button in the canvas toolbar
a floating, auto-hiding indicator on the editor canvas

TODO

[ ] decide which of the two solutions should be kept

I'd just put it in the toolbar as permanently visible (no time-out), underneath or above the zoom in / out buttons for minimum clutter.

authors: bkrmendy maltenuhn

repo: concrete-utopia/utopia


text:
SQL-error when deleting user who uploaded files

Unable to delete user who has uploaded files in v8

Errormessage
Doctrine\DBAL\Exception\ForeignKeyConstraintViolationException thrown with message "An exception occurred while executing 'DELETE FROM Users WHERE uID = ?' with params [2]:
SQLSTATE[23000]: Integrity constraint violation: 1451 Cannot delete or update a parent row: a foreign key constraint fails (concrete58.files, CONSTRAINT FK_C7F46F5DFD71026C FOREIGN KEY (uID) REFERENCES Users (uID))"
Stacktrace

#42 Doctrine\DBAL\Exception\ForeignKeyConstraintViolationException in E:\concrete58\concrete\vendor\doctrine\dbal\lib\Doctrine\DBAL\Driver\AbstractMySQLDriver.php:60
#41 Doctrine\DBAL\Driver\AbstractMySQLDriver:convertException in E:\concrete58\concrete\vendor\doctrine\dbal\lib\Doctrine\DBAL\DBALException.php:116
#40 Doctrine\DBAL\DBALException:driverExceptionDuringQuery in E:\concrete58\concrete\vendor\doctrine\dbal\lib\Doctrine\DBAL\Connection.php:996
#39 Doctrine\DBAL\Driver\PDOException in E:\concrete58\concrete\vendor\doctrine\dbal\lib\Doctrine\DBAL\Driver\PDOStatement.php:93
#38 PDOException in E:\concrete58\concrete\vendor\doctrine\dbal\lib\Doctrine\DBAL\Driver\PDOStatement.php:91
#37 PDOStatement:execute in E:\concrete58\concrete\vendor\doctrine\dbal\lib\Doctrine\DBAL\Driver\PDOStatement.php:91
#36 Doctrine\DBAL\Driver\PDOStatement:execute in E:\concrete58\concrete\vendor\doctrine\dbal\lib\Doctrine\DBAL\Connection.php:987
#35 Doctrine\DBAL\Connection:executeUpdate in E:\concrete58\concrete\vendor\doctrine\dbal\lib\Doctrine\DBAL\Connection.php:595
#34 Doctrine\DBAL\Connection:delete in E:\concrete58\concrete\vendor\doctrine\orm\lib\Doctrine\ORM\Persisters\Entity\BasicEntityPersister.php:580
#33 Doctrine\ORM\Persisters\Entity\BasicEntityPersister:delete in E:\concrete58\concrete\vendor\doctrine\orm\lib\Doctrine\ORM\UnitOfWork.php:1098
#32 Doctrine\ORM\UnitOfWork:executeDeletions in E:\concrete58\concrete\vendor\doctrine\orm\lib\Doctrine\ORM\UnitOfWork.php:406
#31 Doctrine\ORM\UnitOfWork:commit in E:\concrete58\concrete\vendor\doctrine\orm\lib\Doctrine\ORM\EntityManager.php:356
#30 Doctrine\ORM\EntityManager:flush in E:\concrete58\concrete\src\User\UserInfo.php:177
#29 Concrete\Core\User\UserInfo:delete in E:\concrete58\concrete\src\Workflow\Request\DeleteUserRequest.php:38
#28 Concrete\Core\Workflow\Request\DeleteUserRequest:approve in E:\concrete58\concrete\src\Workflow\EmptyWorkflow.php:17
#27 Concrete\Core\Workflow\EmptyWorkflow:start in E:\concrete58\concrete\src\Workflow\Progress\Progress.php:236
#26 Concrete\Core\Workflow\Progress\Progress:start in E:\concrete58\concrete\src\Workflow\Request\UserRequest.php:68
#25 Concrete\Core\Workflow\Request\UserRequest:addWorkflowProgress in E:\concrete58\concrete\src\Workflow\Request\Request.php:141
#24 Concrete\Core\Workflow\Request\Request:triggerRequest in E:\concrete58\concrete\src\Workflow\Request\UserRequest.php:45
#23 Concrete\Core\Workflow\Request\UserRequest:trigger in E:\concrete58\concrete\src\User\UserInfo.php:134
#22 Concrete\Core\User\UserInfo:triggerDelete in E:\concrete58\concrete\controllers\single_page\dashboard\users\search.php:158
#21 Concrete\Controller\SinglePage\Dashboard\Users\Search:update_status in E:\concrete58\concrete\src\Controller\AbstractController.php:172
#20 call_user_func_array in E:\concrete58\concrete\src\Controller\AbstractController.php:172
#19 Concrete\Core\Controller\AbstractController:runAction in E:\concrete58\concrete\src\Http\ResponseFactory.php:191
#18 Concrete\Core\Http\ResponseFactory:controller in E:\concrete58\concrete\src\Http\ResponseFactory.php:372
#17 Concrete\Core\Http\ResponseFactory:collection in E:\concrete58\concrete\src\Routing\DispatcherRouteCallback.php:41
#16 Concrete\Core\Routing\DispatcherRouteCallback:execute in E:\concrete58\concrete\src\Http\DefaultDispatcher.php:115
#15 Concrete\Core\Http\DefaultDispatcher:handleDispatch in E:\concrete58\concrete\src\Http\DefaultDispatcher.php:53
#14 Concrete\Core\Http\DefaultDispatcher:dispatch in E:\concrete58\concrete\src\Http\Middleware\DispatcherDelegate.php:39
#13 Concrete\Core\Http\Middleware\DispatcherDelegate:next in E:\concrete58\concrete\src\Http\Middleware\ThumbnailMiddleware.php:61
#12 Concrete\Core\Http\Middleware\ThumbnailMiddleware:process in E:\concrete58\concrete\src\Http\Middleware\MiddlewareDelegate.php:38
#11 Concrete\Core\Http\Middleware\MiddlewareDelegate:next in E:\concrete58\concrete\src\Http\Middleware\FrameOptionsMiddleware.php:39
#10 Concrete\Core\Http\Middleware\FrameOptionsMiddleware:process in E:\concrete58\concrete\src\Http\Middleware\MiddlewareDelegate.php:38
#9 Concrete\Core\Http\Middleware\MiddlewareDelegate:next in E:\concrete58\concrete\src\Http\Middleware\CookieMiddleware.php:37
#8 Concrete\Core\Http\Middleware\CookieMiddleware:process in E:\concrete58\concrete\src\Http\Middleware\MiddlewareDelegate.php:38
#7 Concrete\Core\Http\Middleware\MiddlewareDelegate:next in E:\concrete58\concrete\src\Http\Middleware\ApplicationMiddleware.php:29
#6 Concrete\Core\Http\Middleware\ApplicationMiddleware:process in E:\concrete58\concrete\src\Http\Middleware\MiddlewareDelegate.php:38
#5 Concrete\Core\Http\Middleware\MiddlewareDelegate:next in E:\concrete58\concrete\src\Http\Middleware\MiddlewareStack.php:86
#4 Concrete\Core\Http\Middleware\MiddlewareStack:process in E:\concrete58\concrete\src\Http\DefaultServer.php:85
#3 Concrete\Core\Http\DefaultServer:handleRequest in E:\concrete58\concrete\src\Foundation\Runtime\Run\DefaultRunner.php:100
#2 Concrete\Core\Foundation\Runtime\Run\DefaultRunner:run in E:\concrete58\concrete\src\Foundation\Runtime\DefaultRuntime.php:102
#1 Concrete\Core\Foundation\Runtime\DefaultRuntime:run in E:\concrete58\concrete\dispatcher.php:39
#0 require in E:\concrete58\index.php:3

#5323 should fix this

Sorry to wake the dead, but I get a similar error related to Calendar Events.

We're on version 8.5.2. Has this already been fixed (ref please, if so), or should I log it as a new bug?

authors: Ruud-Zuiderlicht mlocati stephenr85


text:
@conda-forge-admin, please rerender

Additional comment:
@conda-forge-admin, please rerender

Hi! This is the friendly automated conda-forge-webservice.
I just wanted to let you know that I rerendered the recipe in conda-forge/aemcmc-feedstock#14.

authors: brandonwillard conda-forge-linter

repo: conda-forge/aemcmc-feedstock