text:
Improve firewall on the prod server

Most attacks are not possible on the server. (like Xss, Sql Injection)
NGINX is only used for routing.

repo: matthewkoncz/ivosjatek


text:
added GtkEntryCompletion

good!

source: gharchive/issue

authors: fedesog mattn

repo: mattn/go-gtk

license_type: permissive

license_source: github-api


text:
Add files to .gitignore & install lodash types

Thank you for your contribution. Can you explain me what build errors you've got and which IDE you use?

source: gharchive/pull-request


text:
Fix missing points in total values

any updates on this issue?

Fixed :)

authors: deepakravisankar mcubik

repo: mcubik/goverreport

license: MIT


text:
Fix releases URL on readme

shiiiiiii


text:
TASK_FINISHED is never sent for config update task.

Fixed by #94

repo: mesosphere/cassandra-mesos

license_source: bigquery


text:
Add python unit tests

@brendandburns Can you please review and merge this PR ?

repo: metaparticle-io/package


text:
Cache refactored, tests added

Landed in c87b5ba

repo: metarhia/common


text:
Results edits

Codecov Report

Merging #617 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #617   +/-   ##
=======================================
  Coverage   90.37%   90.37%
=======================================
  Files          21       21
  Lines        1538     1538
=======================================
  Hits         1390     1390
  Misses        148      148

Flag
Coverage Δ

#unittests
90.37% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8eee3e3...3f62d50. Read the comment docs.

authors: aarmey codecov-commenter

repo: meyer-lab/tHMM


text:
Can i use google photo?

Yes, but sync does not work, see #184

authors: mar-v-in naturs


text:
Update Azure Spatial Anchors dependencies to v2.0.0

master now uses v2.0.0+

repo: microsoft/MixedReality-SpectatorView


text:
Experimental change to enable .NET CI.

/azp run mrtk_pr

/azp run mrtk_pr

Having some issues with getting Azure Pipelines to actually kick off the build in response to /azp run mrtk_pr, so I manually kicked off a build here and it's green
https://dev.azure.com/aipmr/MixedRealityToolkit-Unity-CI/_build/results?buildId=1763

/azp run mrtk_pr

repo: microsoft/MixedRealityToolkit-Unity


text:
cherrypick: settings memory scope fix, orchestrator runtime compatible package

Pull Request Test Coverage Report for Build 775897701

0 of 0   changed or added relevant lines in 0 files are covered.
2 unchanged lines in 2 files lost coverage.
Overall coverage increased (+0.06%) to 84.761%

Files with Coverage Reduction
New Missed Lines
%

libraries/botbuilder-dialogs/src/memory/scopes/settingsMemoryScope.ts
1
93.2%

libraries/botbuilder-lg/src/templateExtensions.ts
1
84.48%

Totals

Change from base Build 756466170:
0.06%

Covered Lines:
18920

Relevant Lines:
21247

💛  - Coveralls

authors: coveralls joshgummersall

repo: microsoft/botbuilder-js


text:
Create security guidance around automation options

Close as solved by #226

authors: TessFerrandez anthturner


text:
started to re-work the page all-up

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: sehodges sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

@sehodges is this ready to be merged?

Not yet, I have further work to do on it.
Steve
From: Peli de Halleux notifications@github.com
Sent: 22 May 2019 17:49
To: microsoft/pxt-arcade pxt-arcade@noreply.github.com
Cc: Steve Hodges Steve.Hodges@microsoft.com; Mention mention@noreply.github.com
Subject: Re: [microsoft/pxt-arcade] started to re-work the page all-up (#927)
@sehodgeshttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fsehodges&data=02|01|Steve.Hodges%40microsoft.com|616e615b9b4147759e9908d6ded56fd2|72f988bf86f141af91ab2d7cd011db47|1|0|636941405618866575&sdata=smovEANVoZ5ly5auZ6c3J3lCF5GSS1U%2B%2BxCbj4a%2FeLg%3D&reserved=0 is this ready to be merged?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmicrosoft%2Fpxt-arcade%2Fpull%2F927%3Femail_source%3Dnotifications%26email_token%3DAC6R2Z5FISJP5UVLQQU6JZTPWV2RBA5CNFSM4HIOXW62YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODV7VE7Y%23issuecomment-494883455&data=02|01|Steve.Hodges%40microsoft.com|616e615b9b4147759e9908d6ded56fd2|72f988bf86f141af91ab2d7cd011db47|1|0|636941405618876569&sdata=%2BYR4jknNJH%2FLTsVKAvCQCzbyRCNLXNd%2FR2mxFWMLQM0%3D&reserved=0, or mute the threadhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAC6R2Z3Q6VENYUS5RMRU73TPWV2RBANCNFSM4HIOXW6Q&data=02|01|Steve.Hodges%40microsoft.com|616e615b9b4147759e9908d6ded56fd2|72f988bf86f141af91ab2d7cd011db47|1|0|636941405618876569&sdata=GCY1NKnk6ixRweG6QKjHmIBFQSISNc1A%2B8TlnDv89Dk%3D&reserved=0.

@sehodges I have merged master, which had 320x240 screen changes and a section about CF2 configuration. If everything still looks good, we should merge.

Looks good to me. @pelikhan do you want to look it over?

@sehodges I have merged this branch... start a new one if you want to do edits

authors: mmoskal msftclas pelikhan sehodges

repo: microsoft/pxt-arcade


text:
Support "Clone with new name" in place of "rename"

Closing until there are customer requests for renaming.

authors: nturinski wwlorey

repo: microsoft/vscode-azurestorage


text:
Xamarin

Docs Build status updates of commit 3b6f790:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

.openpublishing.publish.config.json
:white_check_mark:Succeeded

breadcrumb/toc.yml
:white_check_mark:Succeeded

docfx.json
:white_check_mark:Succeeded

tutorials/xamarin.yml
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

repo: microsoftgraph/microsoft-graph-training


text:
Fix README link & standardize texts in variables.tf

@nicolasochem did you have the chance to look at this PR?

@nicolasochem did you have the chance to look at this PR?

Not yet, I'll include it for the v2.0 release.

Not yet, I'll include it for the v2.0 release.

Thank you! Please keep the PRs coming.

Thank you! Please keep the PRs coming.

authors: denver-s nicolasochem

repo: midl-dev/tezos-on-gke


text:
fix: entry afterRuntimeStart to  beforeFunctionStart

Codecov Report

Merging #14 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #14   +/-   ##
=======================================
  Coverage   66.81%   66.81%
=======================================
  Files          32       32
  Lines        2007     2007
  Branches      491      491
=======================================
  Hits         1341     1341
  Misses        614      614
  Partials       52       52

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d52802e...27be45c. Read the comment docs.

authors: codecov-io echosoar

repo: midwayjs/cli


text:
Fixes #919 Initialized and CanFocus.

looks good to me!

I forgot to remove the new functionality that I am still working on.

please rebase

authors: BDisp tig


text:
Duplicate requests can be generated when one is in flight

Fixed by https://github.com/mikeboharsik/sentry/commit/e0b8e1664527e07fba3a4f041f9280bd40d38e0b#r52370369

repo: mikeboharsik/sentry


text:
Attempt to fix feature flakey spec

The problem is not with the app code, the html is:
<base href='http://localhost:3000' />

There are a bunch of errors by poltergeist (?):
[2016-09-27T08:27:50.200965 #18003]  INFO -- omniauth: (mojsso) Request phase initiated.
[18098:18098:0927/082750:ERROR:browser_main_loop.cc(173)] Running without the SUID sandbox! See https://code.google.com/p/chromium/wiki/LinuxSUIDSandboxDevelopment for more information on developing with the sandbox on.
Xlib:  extension "RANDR" missing on display ":99".
[18098:18098:0927/082750:ERROR:browser_main_loop.cc(219)] GLib-GObject: Attempt to add property GtkSettings::gtk-label-select-on-focus after class was initialised
[18098:18098:0927/082750:ERROR:browser_main_loop.cc(219)] GLib-GObject: Attempt to add property GtkSettings::gtk-entry-select-on-focus after class was initialised
[18098:18098:0927/082750:ERROR:browser_main_loop.cc(219)] GLib-GObject: Attempt to add property GtkSettings::gtk-entry-password-hint-timeout after class was initialised
Xlib:  extension "RANDR" missing on display ":99".
[18126:18126:0927/082750:ERROR:sandbox_linux.cc(340)] InitializeSandbox() called with multiple threads in process gpu-process
[18098:18098:0927/082750:ERROR:browser_main_loop.cc(219)] GLib-GObject: Attempt to add property GtkSettings::gtk-button-images after class was initialised

license: mit


text:
[문서 번역] docs/custom-observables

@iChenLei merge please~!


text:
Processing spinner when inference take a second..

#57

repo: modelhub-ai/modelhub-docker


text:
obsoleted class MONDO_0002932. Closes #567

something funny happened to this PR, so i am going to close and redo these edits.

repo: monarch-initiative/mondo


text:
практика 8

практическое работа 8


text:
Fix typo

Duplicates https://github.com/moszinet/BKKCrypt/pull/106

authors: adamschmideg akoskovacs

repo: moszinet/BKKCrypt


text:
Version 2.0 merge

/botio test

I know that we treat https://github.com/mozilla/pdf.js/blob/985c700bd564cc0449b3932b3f4d51801104360e/package.json#L3 more or less like a dummy field, but nonetheless, do we want to update that as well here?

Cross-link to https://github.com/mozilla/pdf.js/projects/5

authors: Snuffleupagus yurydelendik


text:
unlanded: remove useless str in unlanded.html

Coverage remained the same at 28.731% when pulling b649b1ebbd70d9e05745e674884c7a9cd31294f0 on calixteman:fix_unlanded into 597ec33a878dcf495ba90e511e1732a7b9df8d21 on mozilla:master.

authors: calixteman coveralls

repo: mozilla/relman-auto-nag


text:
Getting started guide

I've started on this in the Google Team Drive. I'll be cleaning it up and appending to it as we roll this out to alpha.

authors: jedahan revdancatt

repo: mplusmuseum/mplusmuseum-www


text:
Add extras parameter action Incomplete ApiAi

Codecov Report

Merging #283 into master will increase coverage by 0.01%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master     #283      +/-   ##
============================================
+ Coverage     83.92%   83.94%   +0.01%
- Complexity      635      636       +1
============================================
  Files            53       53
  Lines          1910     1912       +2
============================================
+ Hits           1603     1605       +2
  Misses          307      307

Impacted Files
Coverage Δ
Complexity Δ

src/Mpociot/BotMan/Middleware/ApiAi.php
97.61% <100%> (+0.11%)
13 <0> (+1)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb00909...e20d777. Read the comment docs.

Thanks for the PR. Will this fix #282?

@mpociot Hi, yes it solves my question to some extent. Can you create a new release version with this change?

@mpociot I found a bug, now I'm fixing it

@mpociot I'm fixing it, and create pr

authors: codecov-io iboldurev mpociot

repo: mpociot/botman


text:
in app, links should open in safari

This seems fixed now

Not working anymore :(

repo: mrjohnmorrow/thepapertrail


text:
Carthage support

warning: no umbrella header found for target 'NMRangeSlider', module map will not be generated
warning: no umbrella header found for target 'NMRangeSlider', module map will not be generated
warning: no umbrella header found for target 'NMRangeSlider', module map will not be generated
warning: no umbrella header found for target 'NMRangeSlider', module map will not be generated

I'm not sure it's a problem, those are just warnings, the framework is still generated and usable

@muZZkat: I'd love to get this merged in so I can stop maintaining my fork, let me know if theres anything else I can do to get this PR into a mergeable state

authors: AndrewSB arrrnas

repo: muZZkat/NMRangeSlider


text:
Update munit-maven-plugin-configuration.adoc

Thanks for contribuiting, but at this time we don't link to anchors in our documentation site.
We'll keep your suggestions in mind for future revisions of this content.

authors: dhimate fermujica

repo: mulesoft/docs-munit


text:
Match travis node versions on appveyor

We just added travis ci support for node versions 4, 5, and 6. Makes sense to add them to appveyor as well.

Coverage remained the same at 98.953% when pulling e35d9efc19127fc9123105de8c911e4c242ac5f9 on amilajack-patch-2 into ae1a1584f564335b31332e755877a2df2329a2c5 on dev.

Seems reasonable, let's 🚢

authors: amilajack coveralls mxstbr

repo: mxstbr/react-boilerplate


text:
Update

https://joel.net/how-one-guy-ruined-hacktoberfest2020-drama


text:
12Factor: Reactのデプロイ方法調査(to S3)

本番ビルド方法の調査

公式サイト を見ると、yarn buildで実行可能らしい。(package.jsonに定義済み)

S3のホスト機能設定→次の qiita を参考に設定。設定済みのサイトは こちら

S3ホスティングで、独自ドメインを割り当てたい場合、バケット名＝ドメイン名にする必要がありそう。
https://qiita.com/Ichiro_Tsuji/items/c174d580587a622d3358
Aレコードとか、CNAMEレコードとか、全然わからないので、明日教えて下さい、＞坪井先生

Reactのデプロイ方法は調査したのでクローズ。
別途、ネットワーク周りを見直すIssueを作成した。


text:
Fix several core_test issues

We still have the occasional crash on node shutdown, right?

Two tests failing in this PR's latest Travis run:
[ RUN      ] network.send_valid_publish
/workspace/rai/core_test/network.cpp:242: Failure
Expected: (latest2) != (latest3), actual: 32-byte object <04-27 0D-7F 11-C4 B2-B4 72-F2 85-4C 5A-59 F2-A7 E8-42 26-CE 9E-D7 99-DE 75-74 4B-D7 D8-5F C9-D9> vs 32-byte object <04-27 0D-7F 11-C4 B2-B4 72-F2 85-4C 5A-59 F2-A7 E8-42 26-CE 9E-D7 99-DE 75-74 4B-D7 D8-5F C9-D9>
[  FAILED  ] network.send_valid_publish (61 ms)
[ RUN      ] node.fork_pre_confirm
/workspace/rai/core_test/node.cpp:1072: Failure
Expected: (iterations) < (400), actual: 400 vs 400
[  FAILED  ] node.fork_pre_confirm (238 ms)

Which is wondering me why it's not failed in multiple runs for me. I'll check with Ubuntu Clang

It's failing only witn Debug build

system.generate_send_new times out on my system (ledger.cpp line 640) and then the test suite hangs.

Should we merge this and require core_test to pass in Travis? It seems to be consistent there now.

But failed on your system with system.generate_send_new ?

Yes, it consistently fails there on my system. I don't know why. I'll do more investigation later, but it doesn't appear to occur in Travis.

That issue was fixed in https://github.com/nanocurrency/raiblocks/pull/967

authors: PlasmaPower SergiySW

repo: nanocurrency/raiblocks


text:
feat(admin): New Organization Landing page [EP-2209]

:tada: This PR is included in version 1.3.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

authors: ancashoria dan-qc

repo: natgeosociety/marapp-frontend


text:
Main: switch lang to the same page (now redirect to section home)

obsolete

repo: navix/ngrefs


text:
test

Can one of the admins verify this patch?

repo: nc-pwo/playground


text:
update to change deployment to not prompt from jenkins

:+1:

authors: jaronkk jonhartzler

repo: ndlib/honeycomb


text:
Show AP for each class in evaluation

done in #65


text:
Symfony Console 4.0

Resolved via 5e54d23

repo: nettrine/fixtures


text:
Test packaging run modes

Still missing the "PRIVILEGED" test

is there, isn't it?  https://github.com/newrelic/infrastructure-agent/pull/431/files#diff-d08e1a36f33b3f8808c193adc88be853def09c772a9a9c4e34c0b1b980ba5f3c

repo: newrelic/infrastructure-agent


text:
schematics: create ng-add

ng add @ngneat/transloco
Prompts:

Which languages do you need? en,es (this will create a folder named i18n inside the assets with two files en.json and es.json)
Which loader do you want to use? Webpack or HTTP (this will create a file with the loader and inject it in the app.module providers).

authors: NetanelBasal itayod

repo: ngneat/transloco


text:
multiple calendars per guild

new setCalendar setter
new setChannel per calendar
unified updater

new setCalendar setter
new setChannel per calendar
unified updater

I would really need this feature!

authors: mchangrh mikylucky

repo: niles-bot/niles


text:
Shortcut in aggregation

Codecov Report

Merging #174 (bed18f7) into main (649cd94) will decrease coverage by 0.09%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##              main     #174      +/-   ##
===========================================
- Coverage   100.00%   99.90%   -0.10%
===========================================
  Files           57       57
  Lines         2200     2196       -4
  Branches       300      300
===========================================
- Hits          2200     2194       -6
- Misses           0        2       +2

Impacted Files
Coverage Δ

dask_sql/physical/rel/logical/aggregate.py
100.00% <100.00%> (ø)

dask_sql/physical/utils/sort.py
100.00% <100.00%> (ø)

dask_sql/input_utils/hive.py
90.00% <0.00%> (-10.00%)
:arrow_down:

dask_sql/utils.py
100.00% <0.00%> (ø)

dask_sql/mappings.py
100.00% <0.00%> (ø)

dask_sql/physical/rex/core/call.py
100.00% <0.00%> (ø)

dask_sql/physical/rel/custom/predict.py
100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 649cd94...bed18f7. Read the comment docs.

authors: codecov-commenter nils-braun

repo: nils-braun/dask-sql


text:
Update README.md

Hi Zening, thank you for the PR. We are in the process of migrating all content (examples, documentation) to NL4DV's webpage for better maintainability.
Since this PR is no longer applicable, I am closing it. Feel free to raise new ones as and when you find issues / have a feature request, etc. More guidelines on hows and whens of those are coming soon. :)

Awesome! Thanks for pointing me to the new website! Looking cool!

authors: ZeningQu arpitnarechania


text:
Sync upstream changes from base

Merge complete without issue.

repo: nocontent/portaldocs


text:
[WORK-IN-PROGRESS] Merge back core/client/component/server in

Quick update; I'm not gonna merge back client/server/component/core together, but I'll continue my refactors on this branch as it's much easier and then rebase/port for each project.

repo: node-xmpp/node-xmpp

license: isc


text:
Create VoteCollector in migrations

Ok. I will check this this evening.

authors: jwinzer normanjaeckel

repo: normanjaeckel/openslides-votecollector


text:
Insert semi-colons after return, continue, and break

:+1:

Ideally, we would do this in all places where an expression is used as a value and has void type, but we don't yet have type information in rustfmt, so can't do that. And sometimes people do this intentionally. Doing it just for void keywords seems easier and safer.

As long as there is an option for this.

I personally prefer not to, since they add no value whatsoever and are generally just a waste of bytes 😉

Strongly agree.

@Ms2ger with which opinion?

With the title of this issue: add them.

repo: nrc/rustfmt


text:
add web tests

Codecov Report

Merging #9 into master will increase coverage by 41.72%.
The diff coverage is 80%.

@@             Coverage Diff             @@
##           master       #9       +/-   ##
===========================================
+ Coverage   31.88%   73.61%   +41.72%
===========================================
  Files           3        3
  Lines          69       72        +3
===========================================
+ Hits           22       53       +31
+ Misses         42       11       -31
- Partials        5        8        +3

Impacted Files
Coverage Δ

pkg/server/message.go
100% <100%> (ø)
:arrow_up:

pkg/server/web.go
79.48% <77.77%> (+79.48%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8771af...05d9cb7. Read the comment docs.


text:
Modernize

Current coverage is 67.95% (diff: 100%)

Merging #65 into master will decrease coverage by 15.65%

@@             master        #65   diff @@
==========================================
  Files             9          9
  Lines           805        805
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
- Hits            673        547   -126
- Misses          132        258   +126
  Partials          0          0

Powered by Codecov. Last update 4babc02...0021623

authors: codecov-io nschloe

repo: nschloe/meshio


text:
Swift4.0 Translation-Language Guide-Automatic Reference Counting

领取

authors: chenmingbiao shanksyang


text:
[T6A1][W10-B4] Shannon Yong

Ack by closing PR

authors: gillro hwkchia


text:
[W6.6c][T10-B2] Yan Wei Cheng

@Affalen
Accepting this PR with minimal review and I found no important issue.

authors: Affalen jeffryhartanto


text:
Remove unused Viewer dependency in Editor.vue

Done. d91741c

authors: amoshydra jiayingy


text:
chore(c): remove obsolete todo

Merged in efa53171cda43b55a070691d9a9f089d2c1bf822

repo: ockam-network/ockam


text:
add codebeat badge

Pull Request Test Coverage Report for Build 32

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at ?%

Totals

Change from base Build 29:
0.0%

Covered Lines:

Relevant Lines:
0

💛  - Coveralls

authors: coveralls oleg-balunenko

repo: oleg-balunenko/kafka-dump


text:
Bump Yank to 0.16.2

Woohoo!

authors: Lnaden jchodera

repo: omnia-md/conda-recipes


text:
Pymapd backports

retest this please

retest this please

repo: omnisci/pyomnisci


text:
Topic/typo

Thanks for cleaning up :)

authors: ceedubs jedesah

repo: oncue/remotely


text:
Code | Numeric Pattern 22

@aryashah2k kindly assign it to me.

repo: openAOD/Python-PatternHouse


text:
Removes IAM specific functions to the iam.go file

/retest

/lgtm
Tested locally and was working fine for me as well.

/lgtm

authors: clcollins fahlmant iamkirkbater

repo: openshift/aws-account-operator


text:
WIP: HAproxy write-up

lgtm

authors: mvazquezc scollier

repo: openshift/federation-dev


text:
Added bug link for haproxy-close-wait mitigation script.

+1d in stg pr #1938

repo: openshift/openshift-tools


text:
Use Openthread Hardware Entropy Collector

LGTM 👍

@jwhui , one problem that encountered after including mbedtls_hardware_entropy in embedcrypto.c is the linking order dependency.
libmbedcrypto.a depends on libopenthread-posix.a, meanwhile libopenthread-posix.a depends on libmbedcrypto.a.
Just like the previous patch, creating a new mbedentropy.c. That depends on libopenthread-posix.a, but libopenthread-posix.a does not depend on it.
Or do we have any other better ways?

@luwannest, that makes sense.  FYI, I'm currently working on changes to OT's use of mbedtls.  You can view that pending change at 097e4ec.

@jwhui , could you take a look at this code? This is needed after enable commissioning.

LGMT:+1:

Thanks for updating this.  We recently updated the mbedtls bindings to all be placed in src/core/crypto rather than in third_party.  Is it possible to add this binding to mbedtls.cpp instead?

The main reason I put in third_party/mbedtls is that mbedtls_hardware_entropy calls OT API to get the entropy source.
To my understanding of core/crypto, it is to use mbedtls, but not be used by mbedtls.
Not sure it makes sense or not. If not, I will try to move it.

I understand your reasoning.  However, in general, any original code contributed to the OpenThread project should live in src/.

Current coverage is 67.21% (diff: 0.00%)

Merging #484 into master will increase coverage by 3.25%

@@             master       #484   diff @@
==========================================
  Files            88         84     -4
  Lines         12171      11560   -611
  Methods        1686       1591    -95
  Messages          0          0
  Branches       1429       1381    -48
==========================================
- Hits           7785       7770    -15
+ Misses         3971       3388   -583
+ Partials        415        402    -13

Powered by Codecov. Last update 6243511...abe98d8

@jwhui , I encountered the library dependency order problem while trying to move mbedtls_entropy_poll to crypto folder.
If I move mbedtls_entropy_poll to crypto folder, it will be in libopenthread.a, but it will be used by libmbedcrypto.a. And here I can't change the order,because libopenthread.a depends on libmbedcrypto.a.
One option is to put mbedtls_entropy_poll in crypto folder, but build as a standalone archive, and put it behind libmbedcrypto.a and before libopenthread-posix.a (and any other hardware platforms).
But this seems not to be consistent with current build system, that src/core will be the libopenthread.a.
Could you give me any comments on this?

Okay, I see what you mean.  In the interest of moving this forward, let's keep the mapping in third_party/mbedtls as you had it before.  Thanks.

Will figure out a way to move this to src later, if this is ok only for now.

LGTM 👍

authors: chshu codecov-io jwhui luwannest mszczodrak

repo: openthread/openthread


text:
Fix: add extension for document

@akushniruk Are you sure we are not using this endpoint to get array of documents?
I just wondering cause we call .upload function here

authors: akushniruk chumaknadya

repo: openware/barong


text:
Add a new weave vendor ID for Google

Codecov Report

Merging #77 into master will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #77      +/-   ##
==========================================
+ Coverage   60.12%   60.13%   +0.01%
==========================================
  Files         306      306
  Lines       49367    49367
==========================================
+ Hits        29680    29687       +7
+ Misses      19687    19680       -7

Impacted Files
Coverage Δ

src/test-apps/TestCASE.cpp
96.09% <0%> (+0.22%)
:arrow_up:

src/lib/profiles/security/WeaveCASEEngine.cpp
93.28% <0%> (+0.23%)
:arrow_up:

src/lib/profiles/security/WeaveToX509.cpp
88.8% <0%> (+0.26%)
:arrow_up:

src/lib/profiles/security/WeaveCert.cpp
84.09% <0%> (+0.64%)
:arrow_up:

src/lib/support/ASN1Writer.cpp
85.51% <0%> (+0.93%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23ada12...92d91d3. Read the comment docs.

authors: codecov-io yufengwangca

repo: openweave/openweave-core


text:
Merge 2.0.3.

Coverage remained the same at 100.0% when pulling 22010c48e9999db1c1a926448bf3ae2b32d3a805 on mng/2.0.3 into 5636b9d114852680c8967b58a5eb48286fd4f205 on 2.0.x.

repo: optimizely/ruby-sdk


text:
First update form this file - system messages

We released the Pagekit Beta today. I close this pull request because the code base completely changed. Please create a new one

repo: pagekit/pagekit


text:
Finish QosIoExceptionInterceptor and add tests

This seems uncontroversial, merging into rfink/qos

repo: palantir/http-remoting


text:
Restrict dependency versions to ones that support Python2.

Should be done as a PR to the release branch.

repo: parkassist/xgboost


text:
Lexer hangs when encountering a void tag that is missing it's self-closing /

not able to repro

was able to repro in integration tests with:
<Context.Parent>
  <Context.Child />
</Context.Parent>
<Context.Sibling>

repo: patbenatar/rbexy


text:
Switch to setupmeta, update maintainer etc

Moved to https://github.com/pdbpp/pdbpp/pull/258.

repo: pdbpp/rebased-pdbpp


text:
Inspect uploaded plain Sqlite3 file for views

Done.

repo: pekrau/DbPortal


text:
[BACKLOG-21800] JMS Consumer plugin

Build Failed
:x: Something went wrong while validating this pull request.
Build Commands
mvn -Dsurefire.runOrder=alphabetical -B -fn -f 'pom.xml' -pl 'plugins' -P '!assemblies' -amd clean install && mvn -B -f 'pom.xml' -pl 'plugins' -P '!assemblies' -amd site

Stdout log
(last 100 lines)
[INFO] PDI Get Previous Row Field Assemblies .............. SUCCESS [  0.007 s]
[INFO] PDI Get Previous Row Field Plugin .................. SUCCESS [  0.027 s]
[INFO] PDI Aggregate Rows Plugin .......................... SUCCESS [  0.007 s]
[INFO] PDI Aggregate Rows Plugin Core ..................... SUCCESS [  0.019 s]
[INFO] PDI Aggregate Rows Plugin Assemblies ............... SUCCESS [  0.006 s]
[INFO] PDI Aggregate Rows Plugin Distribution ............. SUCCESS [  0.006 s]
[INFO] PDI Elasticsearch Bulk Insert Plugin ............... SUCCESS [  0.004 s]
[INFO] PDI Elasticsearch Bulk Insert Plugin Core .......... SUCCESS [  0.007 s]
[INFO] PDI Elasticsearch Bulk Insert Plugin Assemblies .... SUCCESS [  0.006 s]
[INFO] PDI Elasticsearch Bulk Insert Plugin Distribution .. SUCCESS [  0.004 s]
[INFO] PDI Google Analytics Plugin ........................ SUCCESS [  0.006 s]
[INFO] PDI Google Analytics Plugin Core ................... SUCCESS [  0.012 s]
[INFO] PDI Google Analytics Plugin Assemblies ............. SUCCESS [  0.005 s]
[INFO] PDI Google Analytics Plugin Distribution ........... SUCCESS [  0.009 s]
[INFO] PDI GP Bulk Loader Plugin .......................... SUCCESS [  0.005 s]
[INFO] PDI GP Bulk Loader Plugin Core ..................... SUCCESS [  0.026 s]
[INFO] PDI GP Bulk Loader Plugin Assemblies ............... SUCCESS [  0.008 s]
[INFO] PDI GP Bulk Loader Plugin Distribution ............. SUCCESS [  0.008 s]
[INFO] Pentaho Google Drive VFS ........................... SUCCESS [  0.008 s]
[INFO] Pentaho Google Drive VFS Plugin Core ............... SUCCESS [  0.015 s]
[INFO] Pentaho Google Drive VFS Assemblies ................ SUCCESS [  0.008 s]
[INFO] Pentaho Google Drive VFS Plugin Distribution ....... SUCCESS [  0.007 s]
[INFO] PDI HL7 Plugin ..................................... SUCCESS [  0.010 s]
[INFO] PDI HL7 Plugin Core ................................ SUCCESS [  0.014 s]
[INFO] PDI HL7 Plugin Assemblies .......................... SUCCESS [  0.009 s]
[INFO] PDI HL7 Plugin Distribution ........................ SUCCESS [  0.009 s]
[INFO] PDI Drools Plugin .................................. SUCCESS [  0.007 s]
[INFO] PDI Drools Plugin Core ............................. SUCCESS [  0.017 s]
[INFO] PDI Drools Plugin Assemblies ....................... SUCCESS [  0.006 s]
[INFO] PDI Drools Plugin Distribution ..................... SUCCESS [  0.006 s]
[INFO] PDI Dummy Plugin ................................... SUCCESS [  0.006 s]
[INFO] PDI Dummy Plugin Core .............................. SUCCESS [  0.007 s]
[INFO] PDI Dummy Plugin Assemblies ........................ SUCCESS [  0.010 s]
[INFO] PDI Dummy Plugin Distribution ...................... SUCCESS [  0.005 s]
[INFO] PDI Json Plugin .................................... SUCCESS [  0.004 s]
[INFO] PDI Json Plugin Core ............................... SUCCESS [  0.012 s]
[INFO] PDI Json Plugin Assemblies ......................... SUCCESS [  0.010 s]
[INFO] PDI Json Plugin Distribution ....................... SUCCESS [  0.010 s]
[INFO] PDI S3 CSV Input Plugin ............................ SUCCESS [  0.008 s]
[INFO] PDI S3 CSV Input Plugin Core ....................... SUCCESS [  0.018 s]
[INFO] PDI S3 CSV Input Plugin Assemblies ................. SUCCESS [  0.008 s]
[INFO] PDI S3 CSV Input Plugin Distribution ............... SUCCESS [  0.004 s]
[INFO] PDI SAP Plugin ..................................... SUCCESS [  0.008 s]
[INFO] PDI SAP Plugin Core ................................ SUCCESS [  0.012 s]
[INFO] PDI SAP Plugin Assemblies .......................... SUCCESS [  0.007 s]
[INFO] PDI SAP Plugin Distribution ........................ SUCCESS [  0.008 s]
[INFO] PDI Shape File Reader Plugin ....................... SUCCESS [  0.007 s]
[INFO] PDI Shape File Reader Plugin Core .................. SUCCESS [  0.015 s]
[INFO] PDI Shape File Reader Plugin Assemblies ............ SUCCESS [  0.007 s]
[INFO] PDI Shape File Reader Plugin Distribution .......... SUCCESS [  0.006 s]
[INFO] PDI GPLoad Plugin .................................. SUCCESS [  0.005 s]
[INFO] PDI GPLoad Plugin Core ............................. SUCCESS [  0.011 s]
[INFO] PDI GPLoad Plugin Assemblies ....................... SUCCESS [  0.008 s]
[INFO] PDI GPLoad Plugin Distribution ..................... SUCCESS [  0.007 s]
[INFO] PDI Openerp Plugin ................................. SUCCESS [  0.007 s]
[INFO] PDI Openerp Plugin Core ............................ SUCCESS [  0.007 s]
[INFO] PDI Openerp Plugin Assemblies ...................... SUCCESS [  0.006 s]
[INFO] PDI Openerp Plugin Distribution .................... SUCCESS [  0.018 s]
[INFO] PDI Palo Plugin .................................... SUCCESS [  0.010 s]
[INFO] PDI Palo Plugin Core ............................... SUCCESS [  0.007 s]
[INFO] PDI Palo Plugin Assemblies ......................... SUCCESS [  0.007 s]
[INFO] PDI Palo Plugin Distribution ....................... SUCCESS [  0.011 s]
[INFO] PDI Version Checker Plugin ......................... SUCCESS [  0.007 s]
[INFO] PDI Version Checker Plugin Core .................... SUCCESS [  0.008 s]
[INFO] PDI Version Checker Plugin Assemblies .............. SUCCESS [  0.010 s]
[INFO] PDI Version Checker Plugin Distribution ............ SUCCESS [  0.009 s]
[INFO] PDI Lucid DB Streaming Loader Plugin ............... SUCCESS [  0.007 s]
[INFO] PDI Lucid DB Streaming Loader Plugin Core .......... SUCCESS [  0.010 s]
[INFO] PDI Lucid DB Streaming Loader Plugin Assemblies .... SUCCESS [  0.012 s]
[INFO] PDI Lucid DB Streaming Loader Plugin Distribution .. SUCCESS [  0.009 s]
[INFO] PDI Salesforce Plugin .............................. SUCCESS [  0.003 s]
[INFO] PDI Salesforce Plugin Core ......................... SUCCESS [  0.006 s]
[INFO] PDI Salesforce Plugin Assemblies ................... SUCCESS [  0.008 s]
[INFO] PDI Salesforce Plugin Distribution ................. SUCCESS [  0.007 s]
[INFO] PDI PUR Plugin ..................................... SUCCESS [  0.004 s]
[INFO] PDI PUR Plugin Core ................................ SUCCESS [  0.007 s]
[INFO] PDI PUR Plugin Assemblies .......................... SUCCESS [  0.004 s]
[INFO] PDI PUR Plugin Distribution ........................ SUCCESS [  0.004 s]
[INFO] PDI Ms Access Bulk Loader Plugin ................... SUCCESS [  0.007 s]
[INFO] PDI MS Access Bulk Loader Plugin Core .............. SUCCESS [  0.005 s]
[INFO] MS Access Steps Backend ............................ SUCCESS [  0.005 s]
[INFO] MS Access Step Dialogs ............................. SUCCESS [  0.004 s]
[INFO] PDI Ms Access Bulk Loader Plugin Assemblies ........ SUCCESS [  0.004 s]
[INFO] PDI Ms Access Bulk Loader Plugin Distribution ...... SUCCESS [  0.005 s]
[INFO] PDI XML Plugin ..................................... SUCCESS [  0.004 s]
[INFO] PDI XML Plugin Core ................................ SUCCESS [  0.005 s]
[INFO] PDI XML Plugin Assemblies .......................... SUCCESS [  0.004 s]
[INFO] PDI XML Plugin Distribution ........................ SUCCESS [  0.004 s]
[INFO] Pentaho Streaming Plugins .......................... SUCCESS [  0.003 s]
[INFO] pentaho-streaming-impls ............................ SUCCESS [  0.004 s]
[INFO] pentaho-jms-plugin Blueprint Bundle ................ SUCCESS [  0.004 s]
[INFO] Pentaho Streaming Plugin Assembly .................. SUCCESS [  0.004 s]
[INFO] Pentaho Streaming Plugin Feature ................... SUCCESS [  0.008 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 16.289 s
[INFO] Finished at: 2018-03-16T17:26:36+00:00
[INFO] Final Memory: 70M/1065M
[INFO] ------------------------------------------------------------------------

Stderr log
(last 100 lines)
java.lang.Exception: org.pentaho.build.buddy.bundles.orchestrator.OrchestratorImpl$BuildException: java.io.IOException: Head build returned with code 1
	at org.pentaho.build.buddy.bundles.orchestrator.OrchestratorImpl.orchestrate(OrchestratorImpl.java:381)
	at Proxyfed9b22d_d11f_4240_bb61_c708fabd556c.orchestrate(Unknown Source)
	at org.pentaho.build.buddy.bundles.rest.OrchestratorRestService$1.write(OrchestratorRestService.java:62)
	at org.apache.cxf.jaxrs.provider.BinaryDataProvider.writeTo(BinaryDataProvider.java:172)
	at org.apache.cxf.jaxrs.utils.JAXRSUtils.writeMessageBody(JAXRSUtils.java:1381)
	at org.apache.cxf.jaxrs.interceptor.JAXRSOutInterceptor.serializeMessage(JAXRSOutInterceptor.java:244)
	at org.apache.cxf.jaxrs.interceptor.JAXRSOutInterceptor.processResponse(JAXRSOutInterceptor.java:120)
	at org.apache.cxf.jaxrs.interceptor.JAXRSOutInterceptor.handleMessage(JAXRSOutInterceptor.java:83)
	at org.apache.cxf.phase.PhaseInterceptorChain.doIntercept(PhaseInterceptorChain.java:308)
	at org.apache.cxf.interceptor.OutgoingChainInterceptor.handleMessage(OutgoingChainInterceptor.java:83)
	at org.apache.cxf.phase.PhaseInterceptorChain.doIntercept(PhaseInterceptorChain.java:308)
	at org.apache.cxf.transport.ChainInitiationObserver.onMessage(ChainInitiationObserver.java:121)
	at org.apache.cxf.transport.http.AbstractHTTPDestination.invoke(AbstractHTTPDestination.java:253)
	at org.apache.cxf.transport.servlet.ServletController.invokeDestination(ServletController.java:234)
	at org.apache.cxf.transport.servlet.ServletController.invoke(ServletController.java:208)
	at org.apache.cxf.transport.servlet.ServletController.invoke(ServletController.java:160)
	at org.apache.cxf.transport.servlet.CXFNonSpringServlet.invoke(CXFNonSpringServlet.java:180)
	at org.apache.cxf.transport.servlet.AbstractHTTPServlet.handleRequest(AbstractHTTPServlet.java:298)
	at org.apache.cxf.transport.servlet.AbstractHTTPServlet.doPost(AbstractHTTPServlet.java:217)
	at javax.servlet.http.HttpServlet.service(HttpServlet.java:707)
	at org.apache.cxf.transport.servlet.AbstractHTTPServlet.service(AbstractHTTPServlet.java:273)
	at org.eclipse.jetty.servlet.ServletHolder.handle(ServletHolder.java:812)
	at org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:587)
	at org.ops4j.pax.web.service.jetty.internal.HttpServiceServletHandler.doHandle(HttpServiceServletHandler.java:71)
	at org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:143)
	at org.eclipse.jetty.security.SecurityHandler.handle(SecurityHandler.java:577)
	at org.eclipse.jetty.server.session.SessionHandler.doHandle(SessionHandler.java:223)
	at org.eclipse.jetty.server.handler.ContextHandler.doHandle(ContextHandler.java:1127)
	at org.ops4j.pax.web.service.jetty.internal.HttpServiceContext.doHandle(HttpServiceContext.java:287)
	at org.eclipse.jetty.servlet.ServletHandler.doScope(ServletHandler.java:515)
	at org.eclipse.jetty.server.session.SessionHandler.doScope(SessionHandler.java:185)
	at org.eclipse.jetty.server.handler.ContextHandler.doScope(ContextHandler.java:1061)
	at org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:141)
	at org.ops4j.pax.web.service.jetty.internal.JettyServerHandlerCollection.handle(JettyServerHandlerCollection.java:80)
	at org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:97)
	at org.eclipse.jetty.server.Server.handle(Server.java:499)
	at org.eclipse.jetty.server.HttpChannel.handle(HttpChannel.java:311)
	at org.eclipse.jetty.server.HttpConnection.onFillable(HttpConnection.java:257)
	at org.eclipse.jetty.io.AbstractConnection$2.run(AbstractConnection.java:544)
	at org.eclipse.jetty.util.thread.QueuedThreadPool.runJob(QueuedThreadPool.java:635)
	at org.eclipse.jetty.util.thread.QueuedThreadPool$3.run(QueuedThreadPool.java:555)
	at java.lang.Thread.run(Thread.java:745)
Caused by: org.pentaho.build.buddy.bundles.orchestrator.OrchestratorImpl$BuildException: java.io.IOException: Head build returned with code 1
	at org.pentaho.build.buddy.bundles.orchestrator.OrchestratorImpl.doOrchestrate(OrchestratorImpl.java:609)
	at org.pentaho.build.buddy.bundles.orchestrator.OrchestratorImpl.orchestrate(OrchestratorImpl.java:364)
	... 41 more
Caused by: java.io.IOException: Head build returned with code 1
	... 43 more

@pentaho/ackbar @buildguy
The plugin build shows success:  http://wingman.pentaho.com:8080/job/wingman/25526/consoleFull.   Not sure why wingman failed.

Looking into why a test fails on wingman.

authors: mkambol wingman-pentaho

repo: pentaho/pentaho-kettle


text:
Add script that make Accessor and return status:200.

added body in response.

repo: personium/app-personium-calendar


text:
Add Cell export import function.

Solved in v1.5.5.

repo: personium/personium-lib-es-adapter


text:
Added suspendable property resolvers

Coverage decreased (-0.1%) to 87.511% when pulling be6327c3e715fe6d64428bdc87ee1701e07abcb4 on jeggy:master into 15262db356c82a7be77bd4147a00b6cc14c387f3 on pgutkowski:master.

Figured it wasn't this simple to implement this. Opened issue #38

authors: coveralls jeggy

repo: pgutkowski/KGraphQL


text:
show build status for master

Thank you

authors: Nyholm dbu

repo: php-http/boilerplate


text:
Add rule for PHP's @ operator

Agree, this could be useful. A PR is welcome.

repo: phpmd/phpmd


text:
*: bump 0.3.0

LGTM

authors: BusyJay siddontang

repo: pingcap/grpc-rs


text:
Create image for 5.1.1

This is ready to tag and push. Just waiting on Jimmi to release the plug-in.

Thanks!!
On Thu, Dec 15, 2016, 10:29 AM Paulo Pires notifications@github.com wrote:

Closed #23
https://github.com/pires/docker-elasticsearch-kubernetes/issues/23 via
a8c1986
https://github.com/pires/docker-elasticsearch-kubernetes/commit/a8c1986ba89ca54f282fb295e08eac814c7c3172
.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/pires/docker-elasticsearch-kubernetes/issues/23#event-895379152,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AHbZgtngpADt3As6KK3sqzaJXfOmSUYwks5rIVzVgaJpZM4LNKc2
.

authors: jcscottiii pires

repo: pires/docker-elasticsearch-kubernetes


text:
Added swedish translation

@Swedneck Thanks for the contribution!

Looks like an awesome project, glad to have a minor part in it!

@Swedneck I really appreciate translations, the pixelfed app will need l10n too so if you are up to it, you could play a bigger part in it!

authors: Swedneck dansup

repo: pixelfed/project-website


text:
tagging Apache POI (org/apache/poi)

Next PR pending (new version of APKTool for v1). Shall I push it straight away (then it would end up in this PR unless you've merged it before :wink:)?

repo: pkumza/LibRadar


text:
Version 3.1.0

this is outdated, closing

authors: anjiren skylarmb

repo: plaid/react-plaid-link


text:
Fix typo

It seems the docs aren't building because references to the spec docs have disappeared.

authors: grahamgower jeromekelleher

repo: popsim-consortium/demes-python

license: ISC


text:
extract function in sketcher

added.

repo: popupcad/popupcad


text:
2.0"

@rultor release tag is 2.0

@rultor release tag is 2.0

@portlek OK, I will release it now. Please check the progress here

@rultor release tag is 2.0

@portlek Done! FYI, the full log is here (took me 4min)

authors: portlek rultor

repo: portlek/SmartInventory


text:
Milestone 0.0.16

Changes Unknown when pulling 7aa1e07bd23d0e9107899afa8371db1d32e55ccd on milestone-0.0.16 into ** on master**.

authors: GitScrum coveralls

repo: post-org/post-load-plugins


text:
Gemmolo 536: Advsurveys formfields label case

@projectmushroom please review

repo: praekelt/molo-gem


text:
upgrade to latest version of molo and plugins

❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤

👍 🍰

authors: codiebeulaine miltontony saeedmb8


text:
Pin molo.core to 3.10.0

@miltontony @phalamag tiny review

+1

repo: praekelt/nurseconnect


text:
refractored outliers_module

Can you add tests as well for this class? Refer tests for other modules.

Okay, will do.

repo: preprocessy/preprocessy


text:
#488 Clear localStorage on tab start

Thanks for this! We'll run some tests on this soon.

Thanks for the pull request!

authors: maciejmrozinski thoop

repo: prerender/prerender


text:
Various tests improvements

CI failed -- https://github.com/prestosql/presto/issues/4173, https://github.com/prestosql/presto/pull/5211

repo: prestosql/presto


text:
Rename "graphcool" to "prismagraphql" in URI

@brikou : Thanks for the PR 🙌

:tada: This PR is included in version 1.16.4 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

authors: brikou divyenduz timsuchanek

repo: prisma/graphql-yoga


text:
initial papr.yml check in

i guess @rhatdan has this

bot, retest this please

bot, retest this please

repo: projectatomic/libpod


text:
Tweaks to node run text

@robbrockbank I think the node run command is trying to pull an image that doesn't exist now since the latest image was tagged this morning, breaking the demo
it's trying to pull calico/node:v1.0.0-beta-8-gb43719b and fails because that's not a valid tag

as discussed, let's have a separate issue/PR for the image version issue, which is outside of the scope of this PR. This one is ok to merge

repo: projectcalico/calico-containers


text:
Support @include and @mixin in stylelint.

What does this do? There are no code changes.

This allows the use of @mixin and @include in scss files. Changes are coming that will use it (just want to land it now)

authors: piscisaureus ry

repo: propelml/propel


text:
Add gentx maxlevush

@stakebotbot Hey! Why build is failing?

ok. I going to delete node

nice answer, guys

answer was given on discrod IIRC
https://discord.com/channels/755548171941445642/755567300152918077/863359222107734026

authors: jhernandezb maxlevush

repo: public-awesome/networks


text:
Add Python API docs

Here's my plan for this:

Fix https://github.com/pulumi/pulumi-terraform/issues/168. Doing this will make it monumentally easier to generate high-quality documentation.
Python makes it extremely easy to inspect modules and programmatically extract documentation from them. This is what pydoc does. Pydoc is very opinionated about its output HTML format so we should do what Boto has done here and write a script that extracts documentation from our packages and formats it as documentation.
With our documentation tool in-hand, we can then begin annotating fields of type TypeMap in Terraform with the exact dictionary state that TF is expecting, so that we can generate documentation for them. Python has no explicit syntax for this but, if we own the documentation generator, we can use normal Python metaprogramming techniques to accomplish this.

The end result is high-quality generated documentation from Python modules. This involves writing a pydoc-like Python script for inspected our own modules. Luckily Python has extremely robust standard library support for doing this (inspect and importlib`). The big downside here is that writing a program like this is advanced Python that can get confusing.
For M20, I plan on taking steps 1 and 2. Step 3 is absolutely required for good documentation but it's out of scope for M20 since it's a bit more work.

To elaborate on 2, Boto accomplishes this by reflecting over the services that it provides and generates files that are ultimately fed to Sphinx, which generates HTML.
This may or may not be a good idea for us to adopt - I'm not sure yet. We've had a lot of success using tsdoc to generate json which we can then use to produce documentation that is still within the style and scheme of our existing documentation. Sphinx is opinionated and wants to control its output format. It may be hard to get Sphinx to play well with our existing documentation theme.
That said, Sphinx is the "standard" tool in this space and it would be nice just for practical reasons to stick as close to the "standard" path as possible.

authors: joeduffy swgillespie

repo: pulumi/docs


text:
bump to 1.0.0 as it will be supported

@eputnam  moving to 1.0.0 because it will be supported.

repo: puppetlabs/puppetlabs-translate


text:
adding plotly to ecosystem

Thanks!

Thanks for adding us @jorisvandenbossche; we're delighted to be included and a pandas tool :hammer:

@msund No problem!
Just one question (which I didn't think of before merging it ..): I don't think plotly is fully open source, but you have a free (limited?) version? Is that correct?
If so, would you mind to add one sentence explaining the situation a little bit? (something in the line of "The free version includes .." or "The cloud based environment is free for public files", but you will know that better :-))

Good idea, thanks. Does https://github.com/pydata/pandas/pull/10714 do it in the way you had in mind?

yes, that looks good! thanks

authors: jorisvandenbossche msund

repo: pydata/pandas


text:
Data prepare, prepare dict and lm train

Thanks, this is useful for running the recipe end-to-end, but I was actually hoping to avoid having to add the shell scripts from Kaldi. I asked Yenda and Guoguo to upload the lexicon and the LM to OpenSLR so that I can simply download them and skip these scripts entirely.
I'm hoping we'll eventually have "icefall-native" LM and dict preparation.

Hey, I never said thanks - thanks! 😁

authors: jimbozhang pzelasko

repo: pzelasko/snowfall


text:
build-snapshot: integrate selenoid auto-download option into artifacts verification

:+1:

authors: ivansnytko vdelendik

repo: qaprosoft/carina


text:
Add support for offset and limit to the invoke endpoint

So I don't know what's up with github but the commit that got accidentally added is now in master...

repo: quasar-analytics/quasar


text:
Alpine

Sorry, this was supposed to go against my fork.

repo: raintank/graphite-mt


text:
Remove object quoting

Merging, based on discussion with @ibuildthecloud

authors: cloudnautique ibuildthecloud

repo: rancherio/cattle


text:
Fix errors in dumpRawTraffic example

totally forgot that we had the dumpRawTraffic in the codebase :D thanks again!

I just created it yesterday as part of the raw handling, but it wasn't quite correct. :)

authors: rastapasta trisk

repo: rastapasta/pokemon-go-mitm


text:
Cleanup from maven

Еще gitmodules дропнуть и репу на обязательный апрув донастрой, плиз

Еще gitmodules дропнуть и репу на обязательный апрув донастрой, плиз

repo: rbkmoney/java-checkstyle-config


text:
Update README to include space after link

Good catch!

authors: MarcelCutts saschatimme

repo: reasonml-community/bs-react-native


text:
Provide modify interface subscription map

I guess this modifies all matches and not a subscription. This is not complete i would say


text:
Variable "_sonata_admin" does not exist.

Can you provide some description, how to reproduce this?

repo: redco/sonata-admin-tree-bundle


text:
Cygwin 2.9.0-3 update

test this


text:
Fix nil pointer

/lgtm

authors: akram jkhelil

repo: redhat-developer/jenkins-operator


text:
将SFUD更新到自己的fork

1、【更新】SFUD的fork;

repo: redocCheng/SFUD


text:
fix #334 Compilation failed if method has @Nonnull annotations

@mkristian
Hi, when you have time, could you review this PR?
Thanks

repo: resty-gwt/resty-gwt


text:
prevent error due to undefined variable

Thanks for catching this

repo: rhysd/vim-crystal


text:
XMLRFC v2: Push Asciidoc v2 converter output through to rfc2xml and rfc2html and rfc2md

#23 is test enough of this.

authors: opoudjis ronaldtse

repo: riboseinc/asciidoctor-rfc


text:
Improve windows build README

Jenkins Build Summary
Built from this commit
Built at 20190403 - 20:18:08
Test Results

Build Type
Log
Result
Status

rpm
logfile
1158 cases, 0 failed, t: n/a
PASS :white_check_mark:

gcc.Release -Dassert=ON, MANUAL_TESTS=true
logfile
915 cases, 0 failed, t: 5m8s
PASS :white_check_mark:

docs, TARGET=docs
logfile
1 cases, 0 failed, t: 0m1s
PASS :white_check_mark:

clang.Debug
logfile
1158 cases, 0 failed, t: 2m54s
PASS :white_check_mark:

gcc.Debug -Dcoverage=ON, TARGET=coverage_report, SKIP_TESTS=true
logfile
1158 cases, 0 failed, t: 17m4s
PASS :white_check_mark:

gcc.Debug
logfile
1158 cases, 0 failed, t: 3m5s
PASS :white_check_mark:

clang.Debug -Dunity=OFF
logfile
1157 cases, 0 failed, t: 10m49s
PASS :white_check_mark:

gcc.Debug -Dunity=OFF
logfile
1157 cases, 0 failed, t: 3m9s
PASS :white_check_mark:

msvc.Debug
logfile
1158 cases, 0 failed, t: 587s
PASS :white_check_mark:

clang.Release -Dassert=ON
logfile
1158 cases, 0 failed, t: 4m53s
PASS :white_check_mark:

gcc.Release -Dassert=ON
logfile
1158 cases, 0 failed, t: 5m10s
PASS :white_check_mark:

gcc.Debug -Dstatic=OFF
logfile
1158 cases, 0 failed, t: 3m4s
PASS :white_check_mark:

msvc.Debug, NINJA_BUILD=true
logfile
1158 cases, 0 failed, t: 627s
PASS :white_check_mark:

gcc.Debug -Dstatic=OFF -DBUILD_SHARED_LIBS=ON
logfile
1158 cases, 0 failed, t: 3m7s
PASS :white_check_mark:

gcc.Debug, NINJA_BUILD=true
logfile
1158 cases, 0 failed, t: 2m56s
PASS :white_check_mark:

msvc.Debug -Dunity=OFF
logfile
1157 cases, 0 failed, t: 1130s
PASS :white_check_mark:

clang.Debug -Dunity=OFF -Dsan=address, PARALLEL_TESTS=false, DEBUGGER=false
logfile
1157 cases, 0 failed, t: 11m18s
PASS :white_check_mark:

clang.Debug -Dunity=OFF -Dsan=undefined, PARALLEL_TESTS=false
logfile
1157 cases, 0 failed, t: 12m43s
PASS :white_check_mark:

msvc.Release
logfile
1158 cases, 0 failed, t: 416s
PASS :white_check_mark:

repo: ripple/rippled


text:
Dependency Updates

LGTM! 😃

authors: BuJo rkcpi

repo: rkcpi/logback-gelf-appender


text:
Issue and Pull Request Templates

@StackKorora please review changes.

Just wanted to leave a comment (as requested) -- I've looked over these and they seem like a good starting point.  I'm sure we'll probably adjust as we move forward, but looks good.

@StackKorora please squash and merge.

authors: grayeul tcooper

repo: rocky-linux/testing


text:
Added support for omitting fields

exciting stuff! I've wanted this feature for a while; just haven't found the time to implement.
One question -- why use of different arguments names ("omit" vs "exclude") for passing via query parameters vs passing directly into a serializer class constructor? Seems like using one would make the API more consistent?

This was something I wasn't too sure about. When you specify a default include in the serializer options, it feels natural that any include in the query params would be treated as an overwrite. In this case, I was using an options exclude in the capacity of removing any superfluous parent links in the nested serializer, and it felt more intuitive that any query param omit would be additive rather than an overwrite in this case (seemed a little strange that more fields would appear and you had to explicitly add them back!) However I also appreciate that it feels cleaner that the two operations would behave the same and it gives the client full control.

Closing this ... this feature has been in for a while now.


text:
fix LICENSE link

Oops! Thanks. :)

authors: mhor rszrama

repo: rszrama/negotiation-middleware


text:
Add sensible timeouts to network requests

Done for debrid.
Scrapers still TODO.

Done

repo: ruinernin/foxystreams

license: WTFPL


text:
Strip indents and empty lines in check_apply_diagnostic_fix_from_position

bors r+
🤖

repo: rust-analyzer/rust-analyzer


text:
Revert "Merge #2629"

bors r+
🤖


text:
Haiku: no IPv6 available; use SO_KEEPALIVE & FD_CLOEXEC.

Thanks for the PR! Out of curiosity, are the ipv6 constants just not available at all on Haiku? Or do the functions just unconditionally return errors?

IPV6_ADD_MEMBERSHIP/IPV6_DROP_MEMBERSHIP are missing in Haiku. But IPv6 is fairly broken, so figured I'd just return an error for all of them there.

Would it be best to let the syscalls themselves return errors? We could update the cfg_if! at the top of the file to account for the missing constants, maybe forcing the sycalls to return an error?
I'm just trying to think of the best way to cut down on the #[cfg] traffic here.

Hmm, I dunno. IPv6 registers just enough to look like it's functional, but actually isn't. We currently explicitly use IPv4 in WebPositive for example to avoid lots of routing problems.

Ok  in that case could we perhaps just let the system return the errors here? These all need to be opted in to anyway so I don't think we'd enable broken functionality by default, for example?

Definitely seeing an issue due to this one still being outstanding:
     Running `rustc --crate-name net2 /boot/home/.cargo/registry/src/github.com-1ecc6299db9ec823/net2-0.2.33/src/lib.rs --color always --crate-type lib --emit=dep-info,link -C debuginfo=2 --cfg 'feature="default"' --cfg 'feature="duration"' -C metadata=272c071196038a44 -C extra-filename=-272c071196038a44 --out-dir /boot/home/rune/target/debug/deps -L dependency=/boot/home/rune/target/debug/deps --extern cfg_if=/boot/home/rune/target/debug/deps/libcfg_if-bf3f0834fba0aadc.rlib --extern libc=/boot/home/rune/target/debug/deps/liblibc-0ccb3d987de5e000.rlib --cap-lints allow`
error[E0432]: unresolved import `libc::TCP_KEEPIDLE`
   --> /boot/home/.cargo/registry/src/github.com-1ecc6299db9ec823/net2-0.2.33/src/ext.rs:663:13
    |
663 |         use libc::TCP_KEEPIDLE as KEEPALIVE_OPTION;
    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ no `TCP_KEEPIDLE` in the root

error[E0425]: cannot find value `IPV6_ADD_MEMBERSHIP` in this scope
    --> /boot/home/.cargo/registry/src/github.com-1ecc6299db9ec823/net2-0.2.33/src/ext.rs:1115:50
     |
1115 |         set_opt(self.as_sock(), v(IPPROTO_IPV6), IPV6_ADD_MEMBERSHIP,
     |                                                  ^^^^^^^^^^^^^^^^^^^ did you mean `IP_ADD_MEMBERSHIP`?

error[E0425]: cannot find value `IPV6_DROP_MEMBERSHIP` in this scope
    --> /boot/home/.cargo/registry/src/github.com-1ecc6299db9ec823/net2-0.2.33/src/ext.rs:1134:50
     |
1134 |         set_opt(self.as_sock(), v(IPPROTO_IPV6), IPV6_DROP_MEMBERSHIP,
     |                                                  ^^^^^^^^^^^^^^^^^^^^ did you mean `IP_DROP_MEMBERSHIP`?

error[E0308]: mismatched types
  --> /boot/home/.cargo/registry/src/github.com-1ecc6299db9ec823/net2-0.2.33/src/sys/unix/mod.rs:54:23
   |
54 |             ioctl(fd, FIOCLEX);
   |                       ^^^^^^^ expected i32, found u64

error: aborting due to 4 previous errors

Some errors occurred: E0308, E0425, E0432.
For more information about an error, try `rustc --explain E0308`.
error: Could not compile `net2`.

@kallisti5 @jessicah If you're still interested in getting this integrated, could you rebase onto master and re-test?

@pfmooney see #103 , it solves things a bit more simply. This one can likely close.

Closing this in light of #103.  Please re-open if it should be revisited.  Thanks.

authors: alexcrichton jessicah kallisti5 pfmooney


text:
Move a few scheduling related functions from linux to notbsd.

r? @alexcrichton
(rust_highfive has picked a reviewer for you, use r? to override)

Thanks!

authors: alexcrichton fiveop rust-highfive

repo: rust-lang/libc


text:
RFC: The {:?} format specifier should not print values in release builds

I think I'm in favour, but it would make debugging the compiler itself much harder.

:-1: I'm not in favor.

This adds another place where something can change the output based on release (previously log and cfg(ndebug)).
It seems valid to write info!("response status = {}, payload = {:?}", res.status, res.payload). I would hope that when I enable INFO logging, that the information I was looking for is there.

The alternative seems better to me. Add something like:
#[cfg(not(ndebug))]
fn unwrap(self) -> T {
    match self { Ok(t) => t, Err(e) => panic!("could not unwrap {:?}", e) }
}

#[cfg(ndebug)]
fn unwrap(self) -> T {
    match self { Ok(t) => t, Err(_) => panic!("could not unwrap") }
}

Are there so many methods that do this that it would be a large burden? The confusion seems heavier to me.

It should be trivial to implement this via cfg, yes? Could we do so and then make concrete measurements regarding its impact?
@pcwalton, yesterday you also mentioned wanting the ability to collapse multiple subsequent calls to panic! (or was that abort...), does this enable that?

Or you could add a new modifier ?? (in the spirit of -vvvv) which means "really, really print debug info even in release builds".

:-1: The idea that programs should do roughly the same thing in debug and release modes is very well ingrained in software engineering.  If it is truly important, cfg should be sufficient.

:-1: If I have any say in this. First objection is that the code which worked in the debug mode would suddenly break in release, that's the opposite of what we want to achieve with static type checking. Second, there are lots of things without Display which one might want to print (for example I might log a *pointer when dealing with FFI), I don't see why one should reinvent the wheel implementing Display for them if the Debug works very well.

I too am not fond of differences of behaviour between debug and release builds, that being said removing some bloat is a compelling argument.
@ArtemGr: How would it break? The only way it could cause breakage as far as I can see is if you used {:?} for serializing data and that's obviously not what it's meant to do.
Overall I think it might be worth a try. I think there should be a compiler flag to re-enable them even in release builds if needed otherwise it might make it very frustrating to debug problems that only occur when some optimizations are enabled (race conditions in unsafe code, things like that).

@simias

How would it break? The only way it could cause breakage as far as I can see is if you used {:?} for serializing data and that's obviously not what it's meant to do.

Well, not doing what it was intended to do might count. It's one of those hidden pits that any language would be better without. Whether it will actually make some functionality of the application to become unavailable is mostly a matter of chance. People make mistakes, you can't rely on the programmer to remember not to use the "{:?}"-printed values or to be aware that this value was "{:?}" printed..

Please don't do it. Having an ability to have debug logs even in release build is invaluable. Personally I also think that having the language or libraries behave differently in debug/release mode is a very bad thing in itself.

:-1: I don't like the idea of not being able to use Debug formatting in release/production. Release builds are exactly where logging is most important (when I am not allowed to bring my debugger, for instance). If the answer is "use Display", then what's the point of Debug in the first place?
Having a special flag for disabling Debug would be fine. I don't think it would be a good idea to have Debug-printing disabled by default (very surprising default for newcomers)

:-1: for this. Printing "raw" debug data could be useful in logging errors in production code. It is easy to imagine having supervisor process written in Rust that will print :? output data to log on failure.

I'm against this. I don't think that release/debugging settings should be changing the output of formatting strings. I think this an overly-broad solution to a fairly specific problem.

triage: I-nominated
nominating because I suspect the lang teams needs at the very least to assign this a shepherd from the lang team (and perhaps we should consider FCP'ing at this point...)

We discussed this at the @rust-lang/lang meeting and decided to close this RFC -- it's been hanging around for a long enough time that the context has completely changed, if nothing else, but also it's not clear that this change would be desirable.

authors: Aatch ArtemGr SealedSun TyOverby bstrie hauleth huonw mahkoh netvl nikomatsakis pcwalton pnkfelix seanmonstar simias

repo: rust-lang/rfcs


text:
Transform container lookup into owner lookup

It works!

repo: rwjblue/ember-qunit-codemod


text:
Fixes issue #14: Unlike all controls, WebView has 'fn did_load(&self, …)' with self as non-mutable

Appreciate it!

repo: ryanmcgrath/cacao


text:
Do not clobber the default or customized airline formatter

sorry for the delay. will try to get this in for next release

authors: blueyed ryanoasis

repo: ryanoasis/vim-webdevicons


text:
SAK-31108 Do not use $ as jQuery if $ is not jQuery.

LGTM! Great

authors: SedueRey juanjmerono

repo: sakaiproject/sakai


text:
SAK-40921 - Fix content Item / deep link flow

@csev WIP?

authors: csev mpellicer


text:
[WIP] Move some ClassTagTest checks to scala 2.x only

I assume that classOf[Nothing] and classOf[Null] was disabled on dotty. But that is not true
@smarter mentioned it may be disabled in the future but it still enabled.
ClassTagTest was running fine on my local branch. Now after upgrading to scalajs 1.1.1 and rebasing dotty the test no longer compiles. I will have another look to try to figure out why

This test class passes on dotty's master now, so I think we can close this.

authors: FabioPinheiro sjrd

repo: scala-js/scala-js


text:
feat(scale): add scale-metal-k8s playbook

Isn't it the same as
ansible-playbook metal-k8s.yml -l kube-node ?

Don't think so... it delegates to kubespray/scale.yml, not kubespray/cluster.yml.

authors: NicolasT Zempashi


text:
Update fibers version for node.js ver 0.12

Released under 2.1.24. Thanks for the pull request!

:+1:

authors: horiuchi scriby

repo: scriby/asyncblock


text:
테스트 환경 및 코드 개발

karma 환경 구축 완료

repo: sculove/Kiwoom-Helper


text:
Switch IS_DEV constant to false

Thank you @JeremyLorthioir for your contribution! You are the first contributor to Volcano :)

authors: JeremyLorthioir sebastianks

repo: sebastianks/volcano


text:
Attributes update

PTAL


text:
Add Windows/Linux keymap note

Thanks!

repo: seongjaelee/nvatom


text:
streamson-bin: analyzer per JSON

probably it would be required to limit JSON count to be analyzed otherwise it might eat all memory...

there can be also a limitation how many JSONs is used for analysis

repo: shenek/streamson


text:
[WIP] Adding a header

I meant to open this against the https://github.com/pdxgo/hugo-goa fork. Closing now, sorry!

repo: shenoybr/hugo-goa


text:
LinalgRefactor - remove HAVE_LINALG_LIB

Travis error unrelated. Merging

authors: OXPHOS karlnapf

repo: shogun-toolbox/shogun


text:
Con 2376 test fixes

Changes Unknown when pulling dd515c0b797bed1e030209ed0daba3108d39ef19 on CON-2376-test-fixes into ** on development**.

Coverage increased (+2.02%) to 22.226% when pulling 44384fa8ee89501f76ea77ae6fe91f13cbfc4642 on CON-2376-test-fixes into d27b9a62fb8ef53275bb2d0d38595e4e854b594a on master.

authors: coveralls mvonkeil-ecentral

repo: shopgate/theme-gmd


text:
PWA-314 Use img tag only.

Pull Request Test Coverage Report for Build 638

0 of 0 (NaN%) changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 41.445%

Totals

Change from base Build 637:
0.0%

Covered Lines:
1857

Relevant Lines:
4379

💛  - Coveralls

authors: coveralls devbucket


text:
PI-8943 Cart badge on bottom bar shows badge count 100 instead of 99+

Pull Request Test Coverage Report for Build 1180

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 47.093%

Totals

Change from base Build 1175:
0.0%

Covered Lines:
1759

Relevant Lines:
3643

💛  - Coveralls

authors: alexbridge coveralls


text:
neon/qrdmulh_lane: fix typo in undefs

Oops, thanks!

authors: nemequ ngzhian

repo: simd-everywhere/simde


text:
Update usage example. stringify does not include '?'

Actually, if you open your chrome devtools and take the following steps

location.search="foo=bar";
Enter
location.search
Enter

The output will be ?foo=bar. So in my opinion, the example is correct.

I've improved the usage example: https://github.com/sindresorhus/query-string/commit/47788b675646b0fd14e4e4adae439a4b51fb71b2 Hope that's clearer :)

Much clearer. Thanks!

authors: SamVerschueren alyssaq sindresorhus

repo: sindresorhus/query-string


text:
ES task step functions

Stale (already merged). Closing.

repo: slalom-ggp/dataops-infra


text:
Add simple Docker container to run

Thanks. Yep, dealing with latest Python3.5 is hard ;-).


text:
Scala Common Enrich: bump Scala to 2.12.10

Strangely enough, Travis fails with Scala 2.12.10. Reverting back to 2.12.8

authors: BenFradet chuwy

repo: snowplow/snowplow


text:
Swift 3 / xcode 8 adaptation

Hey Alex,
Thank you for your PR. I will review it once we have Xcode 8 GM. Hopefully today or tomorrow :)

Hey Alex,
thanks again for your PR. I have to decline it, since there are some changes to the project file that I don't want to accept, as well as some merge conflicts.
I have done the migration myself already, so if you want - you can update your project with the file from this repo. Cocoapods will be updated as soon as stable version of Xcode is available.
Thanks.

authors: alexfreud soberman

repo: soberman/ARSLineProgress


text:
Upgrade dependencies

Pull Request Test Coverage Report for Build 5921

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 35.309%

Totals

Change from base Build 5799:
0.0%

Covered Lines:
1839

Relevant Lines:
4813

💛  - Coveralls

authors: angelsl coveralls

repo: source-academy/cadet-frontend


text:
incorporate data logger code within waterchem

Added loggerScripts branch and this contains new loggers subpackage. Added docstrings to loggerScripts.py, but still need to document the individual toolkits.

repo: speleophysics/olm


text:
AWS SDK for Java version 1.11.333

superseded by https://github.com/spinnaker/spinnaker-dependencies/pull/189

authors: jrsquared sullis

repo: spinnaker/spinnaker-dependencies


text:
MQTT 5.0

Seems I have to code a complete new client for MQTT 5.0

If any help needed, im in

authors: nielsenaa sskaje

repo: sskaje/mqtt


text:
Update dependencies

Pull Request Test Coverage Report for Build 3115

0 of 0   changed or added relevant lines in 0 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage increased (+0.007%) to 66.036%

Files with Coverage Reduction
New Missed Lines
%

routes/my_recording.js
1
25.6%

Totals

Change from base Build 3112:
0.007%

Covered Lines:
6892

Relevant Lines:
9797

💛  - Coveralls

authors: coveralls gcampax

repo: stanford-oval/almond-cloud


text:
How to use webroot auth for certbot?

Here's how it was handled in the out fork https://github.com/henridwyer/docker-letsencrypt-cron/search?q=webroot

repo: staticfloat/docker-nginx-certbot


text:
seo优化相关

@bobdos I think right now all I need is a description of the home page (our web site) and we can add different metadata to each subpage if we want later.

@nosus
keyword:
steemGG STEEM blockchain HTML5 game publishing distribution platform
description:
SteemGG is STEEM blockchain based HTML5 Game distribution platform, allowing Game Developers to gain monetary rewards directly from Gamers' upvotes and likes. In return Gamers will receive rewards for actively upvoting games and posting game related contents.

verified on dev

@nosus
Key word 调整为： SteemGG - STEEM Blockchain Based HTML5 Gaming Platform

verified on staging

verified on prod

authors: bobdos bonjovis nosus

repo: steemgg/steemgg-website


text:
Fix typo in README (dam is decameter)

Thanks!

authors: onbjerg stevelacy

repo: stevelacy/pretty-metric


text:
Dev-dependency updates

Coverage remained the same at 100.0% when pulling 87583a341995a13811b85ceddb5e2d956806af52 on dev-dependency-updates into a9dbf1f5f36c6db58e0b600d91486ac70a3f0df7 on master.


text:
Feature/relations

merging work into master


text:
make a debian package

duplicate of https://github.com/subgraph/roflcoptor/issues/38

repo: subgraph/roflcoptor


text:
bugfix: set variable

ack

authors: notsure turbo-ele

repo: sulu-io/SuluSalesOrderBundle


text:
Find Rubik's Cube solving algorithm (from internet)

can we have someone write a pseudocode for this?

repo: supragya/CubedAI


text:
can not slide when I combine with bootstrap modal??

I have the same problem and the slide is not done
     <swiper class="swiper" :options="swiperOption" ref="shareSwiper">         <swiper-slide>Slide 1</swiper-slide>         <swiper-slide>Slide 2</swiper-slide>         <swiper-slide>Slide 3</swiper-slide>         <swiper-slide>Slide 4</swiper-slide>         <swiper-slide>Slide 5</swiper-slide>         <swiper-slide>Slide 6</swiper-slide>         <swiper-slide>Slide 7</swiper-slide>         <swiper-slide>Slide 8</swiper-slide>         <swiper-slide>Slide 9</swiper-slide>         <swiper-slide>Slide 10</swiper-slide>

       </swiper>

Same problem. Slider doesn't work when modal was opened first time after page updating but works in second time. So strange
`

        <swiper-slide v-for='presetImage in modalSwiper'
                      :key='presetImage.id'
        >

        </swiper-slide>

      </swiper>

`

authors: NikoPushkin akbarjoudi alziqziq

repo: surmon-china/vue-awesome-swiper


text:
Include all metadata in Readme and android 5.1 compatibility.

Moved readme suggestions to this wiki page as they are for more technical usage.

repo: surveycto/timed-grid-test


text:
Go Support

See the other libraries, we don't want to commit automatically generated files.

Go does not have a build step for dependencies so if we want to provide the library as a module via this repo we will have to check in the generated code (a user would then be able to use the dependency via github.com/svixhq/svix-libs/go.

See the other libraries, we don't want to commit automatically generated files.

Unfortunately, go doesn't have a build step for modules (dependencies) so you have to have all the code checked in if you want a user to be able to start using our library via a simple go get github.com/svixhq/svix-lib/go.

Btw moving the module to the root directory allows this lib to be used as such:
go get github.com/svixhq/svix-libs/go

package main

import (
	svix "github.com/svix-frank/svix-libs/go"
)

func main() {
	sx := svix.New("API_TOKEN", nil)
	_, _ = sx.Application.Create(&svix.ApplicationIn{Name: "test"})
}

Which I think is a good enough workflow and lets us keep it in one repo

We can't not have the generated files checked in in go?

We can't not have the generated files checked in in go?

Not if we want the library to be useable with a single go get go's module system just downloads the library at the given URL; there is no concept of a build step for dependencies in go, this is a common issue with go bindings for things like c libraries that require a per environment build step.  We will need to provide a git repo with generated openapi code either somewhere (either here or a separate repo).  Otherwise we have to ask our users to do the build step manually.

Also for review, verifying works a little different than javascript & python since you can't just arbitrarily parse json into an object, so I opted for the verify to just return an error:
secret := "MfKQ9r8GKYqrTwjUPD8ILPZIo2LaLaSw"

// These were all sent from the server
headers := http.Header{}
headers.Set("svix-id", "msg_p5jXN8AQM9LWM0D4loKWxJek")
headers.Set("svix-timestamp", "1614265330")
headers.Set("svix-signature", "v1,g0hM9SsE+OTPJTGt/tmIKtSyZlE3uFJELVlNIOLJ1OE=")

payload := `{"test": 2432232314}`

wh, _ := svix.NewWebhook(secret)
// Throws on error, returns nil
err := wh.Verify(payload, headers)
fmt.Println(err)

Alternatively, we can make it take an interface and expect it to json unmarshall to that
type Example struct {
	Name  string
	Order string
}
var examples []Example
 // here jsonBlob would be a byte array and on successful verification it would unmarshal it into examples
err := webhook.Verify(jsonBlob, headers, &examples)
if err != nil {
	fmt.Println("error:", err)
}

Generated files: OK, it is what it is then...
Verification without creating an object: that's fine.
Is the PR ready for review?

Generated files: OK, it is what it is then...
Verification without creating an object: that's fine.
Is the PR ready for review?

Yep!

authors: svix-frank tasn

repo: svixhq/svix-libs


text:
add Luke Hiesterman to stakeholders

LGTM. Merging.

authors: gravisman seabaylea

repo: swift-server/work-group


text:
PYD-29 Add set attachment field to none.

Docs

Pull request moved to https://github.com/swimlane/swimlane-python/pull/19. Branch on swimlane repo instead of fork for easier maintenance

repo: swimlane/swimlane-python


text:
[Misc] create root misc folder

👍


text:
Add "Rust" section and "garciparedes/leetcode" repo.

:slightly_smiling_face: :tada:

repo: tangweikun/awesome-leetcode


text:
Test/connection error or failure cases

Codecov Report

Merging #67 (ef254e5) into main (c91a687) will increase coverage by 0.54%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #67      +/-   ##
==========================================
+ Coverage   48.44%   48.98%   +0.54%
==========================================
  Files          13       13
  Lines         838      841       +3
==========================================
+ Hits          406      412       +6
+ Misses        401      399       -2
+ Partials       31       30       -1

Impacted Files
Coverage Δ

pkg/media/connection.go
92.59% <100.00%> (+0.09%)
:arrow_up:

pkg/media/video_clip.go
70.58% <0.00%> (+17.64%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c91a687...ef254e5. Read the comment docs.

authors: codecov-commenter tauraamui

repo: tauraamui/dragondaemon


text:
introduce pragmas and/or command line switches for language extensions

done in 38f7cca


text:
fix loadSchema bug that used undefined model

严老师真仔细

authors: sailxjx zensh

repo: teambition/limbo


text:
Adding docstring to tf.keras.activations.deserialize

I signed it!

Closing this PR as this not against master, please open a new PR against master
CC @mihaimaruseac

authors: eito-fis rthadur

repo: tensorflow/tensorflow


text:
Fix bug where TensorBoard will crash if it can't determine host ip address

LGTM
In a future change I'd like to have it display the hostname (if it's in DNS) rather than the IP address.

authors: danmane jart


text:
Re-arrange into es6 classes and remove Polymer.

@rhalff interesting! Learn anything from this?

Sorry, I meant to merge it into my own master branch as a conversion step and definitely did not intend to offer it to the-grid/master within this state :)

authors: forresto rhalff

repo: the-grid/the-graph


text:
Update to tokio 1.0 and reqwest 0.11

Thanks!

Thanks!

Released as 0.7.0.

Released as 0.7.0.

authors: theduke woelfman


text:
mark compatible with recent puppetlabs-concat

Thanks @mmoll.

authors: domcleal mmoll

repo: theforeman/puppet-dhcp


text:
Implement Transaction Entity

i would work on this

This issue became obsolete because it done with #10 as it is part of the bank domain

authors: MrIceman gzodx

repo: thenewboston-developers/Kotlin-SDK


text:
Fix/vercel root span operation name

Pull Request Test Coverage Report for Build df0a7523-5e7f-4618-af61-e2bbfd530d42

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 67.384%

Totals

Change from base Build 972849a0-7fa0-4d0a-98be-63ea9ad3caf1:
0.0%

Covered Lines:
1232

Relevant Lines:
1728

💛  - Coveralls

authors: coveralls fatihaydilek

repo: thundra-io/thundra-lambda-agent-nodejs


text:
Create new version for the tmc-cli.

LGTM

Coverage remained the same at 41.41% when pulling 52124c0f86d5627a3e1f7060a881c47f43af2094 on update-script-aleksi into 75fc13578d0ceda42662969e54c4e15d869ee3f3 on master.

Coverage remained the same at 41.41% when pulling 52124c0f86d5627a3e1f7060a881c47f43af2094 on update-script-aleksi into 75fc13578d0ceda42662969e54c4e15d869ee3f3 on master.

authors: Salmela coveralls juvester

repo: tmc-cli/tmc-cli


text:
Bump tmuxinator to 1.1.3

Any thoughts, @tmuxinator/tmuxinator?

repo: tmuxinator/tmuxinator


text:
Added Judge0 API

Thanks @hermanzdosilovic !

authors: davemachado hermanzdosilovic

repo: toddmotto/public-apis


text:
0316分のデータ更新です

曜日データが数字になっているようですがプレビューを見る限り影響がなさそうです。
（今後はデータ的に消してもいいかもしれません）


text:
Batch size in bytes rather than number of entries

Codecov Report

Merging #69 into master will increase coverage by 0.11%.
The diff coverage is 85.71%.

@@            Coverage Diff             @@
##           master      #69      +/-   ##
==========================================
+ Coverage   82.37%   82.49%   +0.11%
==========================================
  Files          51       51
  Lines        3949     3987      +38
==========================================
+ Hits         3253     3289      +36
- Misses        696      698       +2

Impacted Files
Coverage Δ

silkworm/db/buffer.hpp
50.00% <0.00%> (-16.67%)
:arrow_down:

silkworm/db/buffer.cpp
75.52% <78.94%> (+0.97%)
:arrow_up:

silkworm/types/account.cpp
89.70% <100.00%> (+2.20%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52f697f...72dd0ec. Read the comment docs.

authors: codecov-io yperbasis

repo: torquem-ch/silkworm


text:
[Optimisation] Don't buffer writes of receipts and change sets

using Append for changesets also?

using Append for changesets also?

No, not for change sets. Perhaps we should do it for change sets as well. Let me measure if it brings any performance gains.

authors: AskAlexSharov yperbasis


text:
Fixing installer uploading

Download:
Environment: QT=5.12, ARCH=64, PYTHON_PATH=C:\Python37-x64
Environment: QT=5.12, ARCH=32, PYTHON_PATH=C:\Python37

authors: AppVeyorBot khodand

repo: trikset/trik-studio


text:
Applatix workflow with build followed by test

LGTM.

authors: kramasamy objmagic

repo: twitter/heron


text:
如何下钻目录

如果分享的是文件夹，可以使用-f参数下载整个文件夹，例如：python baidu_wangpan_parse.py -f https://pan.baidu.com/s/1htWjWk0 5ykw
暂时没法单独下载目录中的子目录

authors: Lsgo tychxn

repo: tychxn/baidu-wangpan-parse


text:
Add Docks to showcase app

https://github.com/uberfire/uberfire-extensions/commit/4d22760311b92e72632465e9ad5d0629ec2cc2de

authors: cristianonicolai porcelli

repo: uberfire/uberfire-extensions


text:
Add support for unjailbroken devices

I can't jailbroken my devices.

me too

Im 13.3.1

Im 13.4.5 (17F5034c) the beta software.

In fact, it's OK. You only need the permission of file application similar to IOS 13.

The virtual machine can read the external device and start the external device without prison break.

However, this function cannot be implemented in IOS 12 and below systems.

Because there is no permission to read the external USB device.

I'm sorry for saying so much.

Please read https://getutm.app/install/

repo: utmapp/UTM


text:
Allow data from myria and pasted data

Yes, a modal instead of a popup would be better.

I've updated the pr

repo: uwdata/polestar


text:
add CAP_NET_ADMIN to v2ray.service when use TPROXY

默认的v2ray.service 只包含了CAP_NET_BIND_SERVICE CAP_NET_RAW两个权限，对于正常使用没有任何问题，但是如果需要用到透明代理，必需使用CAP_NET_ADMIN权限

这个问题会在上游改动

这个问题会在上游改动

意思是会直接更改v2ray.service么？我认为就平常使用时，使用当前权限即可，当需要用到透明代理时，才需要更换成ADMIN权限

正在考虑这个问题

@kslr 大佬，这题可有什么进展？

fixed in https://github.com/v2fly/v2ray-core/commit/c5842b91e62d05ba8b3bd7682c998fb66e238086

authors: kslr nicholascw zhouscd


text:
viofs-svc: implement GetDirInfoByName callback (a performance improvment)

Hi @hammerg,
There are some conflicts because of the previously merged PR. Please fix.

There are some conflicts because of the previously merged PR. Please fix.

Fixed. The previous PR had commits from another branch.

authors: YanVugenfirer hammerg

repo: virtio-win/kvm-guest-drivers-windows


text:
do we need to create the postgres database and user ourselves?

Hello,
Yes, if you want to use a Postgres database, you must create the database and the user first. After that using "syncdb", Django will create all the tables for you

Thanks for your fast response! thats very nice of you

repo: vitorfs/bootcamp


text:
Hazmat docker tests

oops wrong button

repo: voxmedia/autotune


text:
Shipping Options Minicart: Um paragrafo por seletor

Link do CRM.
Wiki da Integração.

Publicação com as Issues: 19,14,22,23,20,24 no ambiente 'Beta'

Publicação com as Issues: 19,14,22,23,20,24,15,16,17,18,13,12 no ambiente 'Produção'

authors: vmattos vtexcrmgithub


text:
Add vue-moveable to Miscellaneous

@probil Could you update this PR if it is relevant. In any case, let me know if something is necessary.

@Scrum done

authors: Scrum probil

repo: vuejs/awesome-vue


text:
可以做数量可变的item 吗

可以呀
//网络请求后
NSArray *array;//json解析出的数组
for (xx *model in array) {
[self.titleArray addObject:model.name];
}
self.titles = [self.titleArray copy];
[self reloadData];
然后就跟demo的一样   操作WM代理方法就行了

谢谢

repo: wangmchn/WMPageController


text:
注册接口报错400呢？

用的是https

repo: wangzailfm/WanAndroidClient


text:
Final touches

@bourdakos1 is this still in progress?


text:
Make tools a subtree, not a submodule

:+1:

Given the use of submodules for vendoring, it's unlikely we'd switch the tools dependency to use subtrees, so am closing this.

authors: awh errordeveloper tomwilkie

repo: weaveworks/weave


text:
Fixed a dead link in params.html

Thank you! LGTM.

repo: webrtc/apprtc


text:
[WIP] Pass around more structure in BagReplicaLocation

Closing due to inactivity.

repo: wellcometrust/storage-service


text:
I need its documentation.

You can find its wiki
https://github.com/wikichua/simplecontrolpanel/blob/master/wiki.md

authors: asimshazad manadinho

repo: wikichua/simplecontrolpanel


text:
WFCORE-2562 don't fail boot if we can't remove old configuration history

FYI, updated this to never throw, since its only used to remove old configuration backups and shouldn't prevent the server from starting.

repo: wildfly/wildfly-core


text:
Updated from Orginal

Update from Orginal

repo: wilkyit/EUCMonitoring


text:
[tests] use react-test-renderer [xy-chart] support moment in data.x

Coverage remained the same at 78.306% when pulling 36124cca10a36167dcb790cd1fb1449bc59f77fb on chris--test-deps-n-moment-props into 3160fb3f86d3299fc2acc72d4f0c7bc23292d577 on master.

authors: coveralls williaster

repo: williaster/data-ui


text:
fix Strings 'KeyError' issue

nice catch, thanks!

authors: williballenthin xmoeproject

repo: williballenthin/python-idb