text:
Map errors to -32000, -32602, and -32603

Description
Map variants in sui_json_rpc::Error to -32000, -32602, and -32603, and clean up some errors along the way.

removed NoEventStore, FullNodeInvalidTxRangeQuery, HandleConsensusTransactionFailure as these are not used
Metrics logger now increments server error metric only on -32603
QuorumDriverError wraps an inner SuiError - this inner SuiError is now used to determine error code
Consolidate most serde-related errors into one SuiError::SerializationError and DeserializationError
Removed DynamicFieldReadError as it was obscuring underlying errors - mapped errors to DeserializationError, DynamicFieldObjectNotFound, or SuiSystemStateReadError instead
Similarly remove TransactionOrchestratorLocalExecutionError to surface underlying SuiError
SuiError::DeserializationError gets mapped to sui_json_rpc::Error::SuiRpcInternalError where applicable (in scenarios where the deserialization error occurs on an object read from chain, which should not happen).
Remove BcsError in favor of SuiRpcInputError::Serialization and ::Deserialization for client-responsible errors, and ServerError::Serde(String) for error from server.

These are the errors that map to -32603 and will increment the metric:
            Error::InternalError(err) => to_internal_error(err),
            Error::BcsError(err) => to_internal_error(err),
            Error::UnexpectedError(err) => to_internal_error(err),
            Error::EncodingError(err) => to_internal_error(err),
            Error::TokioJoinError(err) => to_internal_error(err),
                QuorumDriverError::SystemOverload { .. } => to_internal_error(err),

            Error::SuiRpcInternalError(err) => match err {
                SuiError::ModuleDeserializationFailure { .. }
                | SuiError::DeserializationError { .. } => to_internal_error(err),
                _ => match_sui_error(err),
            },

        SuiError::ExecutionError(_err, status) => match status {
            ExecutionFailureStatus::VMInvariantViolation => to_internal_error(status),

        SuiError::StorageError { .. }
        | SuiError::GenericStorageError { .. }
        | SuiError::StorageMissingFieldError { .. }
        | SuiError::StorageCorruptedFieldError { .. }
        | SuiError::GenericAuthorityError { .. }
        | SuiError::MissingCommitteeAtEpoch { .. }
        | SuiError::FileIOError { .. }
        | SuiError::JWKRetrievalError
        | SuiError::ExecutionInvariantViolation
        | SuiError::SuiSystemStateReadError(_)
        | SuiError::FailObjectLayout { .. }
        | SuiError::Unknown { .. } => to_internal_error(sui_error),

Some of these already have existing alerts, such as InvariantViolation. To avoid redundancy, these could occupy their own custom error codes, so they won't be confused with the three designated error codes and tallied into the server error metric.
Test Plan
Existing tests + ci

If your changes are not user-facing and not a breaking change, you can skip the following section. Otherwise, please indicate what changed, and then add to the Release Notes section as highlighted during the release process.
Type of Change (Check all that apply)

[ ] protocol change
[x] user-visible impact
[x] breaking change for a client SDKs
[ ] breaking change for FNs (FN binary must upgrade)
[ ] breaking change for validators or node operators (must upgrade binaries)
[ ] breaking change for on-chain data layout
[ ] necessitate either a data wipe or data migration

Release notes

removed NoEventStore, FullNodeInvalidTxRangeQuery, HandleConsensusTransactionFailure as these are not used
Metrics logger now increments server error metric only on -32603
QuorumDriverError wraps an inner SuiError - this inner SuiError is now used to determine error code
Consolidate most serde-related errors into one SuiError::SerializationError and DeserializationError
Removed DynamicFieldReadError as it was obscuring underlying errors - mapped errors to DeserializationError, DynamicFieldObjectNotFound, or SuiSystemStateReadError instead
Similarly removed TransactionOrchestratorLocalExecutionError to surface underlying SuiError
SuiError::DeserializationError gets mapped to sui_json_rpc::Error::SuiRpcInternalError where applicable (in scenarios where the deserialization error occurs on an object read from chain, which should not happen)

Adding @longbowlu to advise on the meaning of some of these errors.  I know Lu has audited these errors in the past (to see if they were retryable or not) so can advise on what they mean.
I'm generally a fan of consolidating errors, but we should also be careful in case some of these errors end up being committed to on-chain, then we can only do the consolidation behind a protocol config (not sure if that applies here, but something to watch out for).

authors: amnn wlmyng


text:
zh_cn

zh_cn.zip

I'm not clicking that.

Sorry, this is the Chinese lang file I made for roots3

ok,here is the link
https://pastebin.com/jymcG8EB

I revised it again:
https://pastebin.com/JniK0cR1

This seems pretty good! I'll have @noobanidus take a look. Thanks!

source: gharchive/issue

authors: ByThePowerOfScience ukmojb

repo: MysticMods/Roots

license: MIT

license_type: permissive

license_source: github-api


text:
Tibialyzer beta v1.4.1 and Tibia 11 - ammunition

Well I don't know if this place is good for this, I just want to let you know that Tibialyzer 1.4.1 doesn't count used ammunition in Tibia 11 Beta (at least it is not shown under "Used items" in summary). Cheers :)

It was with the same problem has already been solved?

Here too. On tibia 11 the ammunition doesn't count on summary.

Yah I would like a solution for this issue

I can confirm that this is not working on 1.4.2 and tibia 11

authors: Dziaku fclaussen krustzer scoxdomain vinie1

repo: Mytherin/Tibialyzer

license_source: bigquery


text:
Fixed custom HTTP header support

Fixed potential typo preventing custom HTTP headers from working.

Very minor change but I thought I might as well do a PR, it will be my first ever!
I will try contributing more in the future.

source: gharchive/pull-request

repo: MythicAgents/Athena


text:
Deploy a live-demo website

As a sub-domain of buetian.org, we need to deploy a live workable version of this library.

won't do

repo: MythicAngel/BanglaDateJS


text:
Feat/map display

Refined map, added debugging code, displaying of live statistics.

I know someone had the same idea to create a Block model file. I guess this will be resolved during the merge?

I know someone had the same idea to create a Block model file. I guess this will be resolved during the merge?

Im guilty on that one XP

Now we would have to check if everything still works as intended.

The Block Enum now also has the Workplace Block...
The Map width and height had been renamed to MAP_WIDTH and MAP_HEIGHT and are implemented as static final...

I don't think we have to connect frontend and backend completly in this pr. I would use a seperate PR to achieve that. 😄

I have no objections, the code looks very good. I would like to merge the main branch into this one later. After that it would be great if you @joewilliams007 @Driemtax could take another look at it. If everything looks good, we can then merge the pull request into the main branch. 😄

@Driemtax mentioned that the map should be responsive to the frame size. Which i am implementing at the moment.


text:
Sequence File Browser improvements

Checked for duplicates
No - I haven't checked
Alternatives considered
No - I haven't considered
Related problems
We've received feedback that the sequence file browser could be improved. It can be challenging to find the right sequences in the sequence editor.
Describe the feature request
Some potential improvements

Checkbox allowing someone to filter contents to the logged in user
More robust filtering around username
Could be improvements to the table, or a new view
Future considerations: showing output files from sequences in some related view

Plays into a larger question about how we manage input / output files.

Seems like the most straightforward way to address this would be to add a Created by column that has our standard filter options. This would meet the need of allowing someone to quickly see what they had created. If we had control over the filter options, we could also suggest the current logged in username at the top of the list.

Another nice to have would be to have the default sort behavior have the current user at the top. Not sure how feasible that is. Fallback to filter to the user's sequences (if they exist).

Two directions here: I think in the short term we could add whichever one is easier / quicker.

https://www.figma.com/file/5DSUlQpSqAFAsVzc5nA5Y4/Aerie-%231206---Sequence-file-browsing?type=whiteboard&node-id=0%3A1&t=Yo0kbSVXOonUrpoX-1

repo: NASA-AMMOS/aerie-ui


text:
Updates

updating quarto and publishing to openscapes/python

Merged @betolink, and deleting the branch

repo: NASA-Openscapes/corn


text:
Search Details Page / DOI Landing Page

Design and Implement

I've completed the initial implementation of the DOI landing pages. You can see those changes here
This code is pushed to doi-mockup branch
Some known differences from mockups, with room for discussion:

I kept some of the iconography that we had initially in our design
The pill appended to the title is "PDS4 Bundle/Collection" instead of just "Bundle/Collection" because it also needed to support PDS3
I left Observing System components on the sidebar, as we originally had it on our site (still labeled as Spacecraft/Mission/Instrument) since I believe that's a better place for it, but it was also just easier.
I only auto-collapsed those side boxes if there are more than three items
I did not auto-expand the details on the high width breakpoint mostly because I really just ran out of time to do anything fancy ensuring that the primary Browse button was always visible above the fold
The Citation Builder is just some arbitrary patterns that show how we could go about dynamically constructing citations for the user. I looked into adding some real examples, but quickly realized how complicated and varied (and undocumented) widely-used citation styles are

Some additional handy new features to be aware of on that deployment:

If you append &mockup=true to the URL, additional mockup data will be integrated into the dataset pages, to highlight the additional features
If you append &pdsOnly=true to the URL, then any additional metadata that we have supplemented as part of the Archive Loader at PSI will be left out of the pages (so you can see results purely from the PDS core registry).

Meta-note: I'm out next week so don't find anything too broken too soon

October Schedule Status ⏳:  On track

1

Here is some crit for what is here

Is this supposed to adhere to our dark theme that we defined?
I think removing 'relevant tags' is ok. They are removed when adjusted for mobile, so I think it ok to remove this all together
Regarding the right-hand container (other versions, PDS3 Versions, etc.), is this something we can potentially push back in to an accordion header, much like 'show more'? Why do we have this in its own container (what makes it so special?)
Also, no good reason to have each version to be contained in their own card. We can just contain them in to one accordion or module container as you see in the mockup I've attached
I am confused as to why we use 'bundle' and 'dataset' when concerning Bundles. Are they the same thing? Or are we nudging user to browse the collection with the button? I am not sure what the distinction is.
We don't have that sized button defined in the design system - it is a bit excessive
Here is a mockup of what it should look like in the theme

Is this supposed to adhere to our dark theme that we defined?

Per Mike, we will create new ticket to track converting to using dark theme.

I think removing 'relevant tags' is ok. They are removed when adjusted for mobile, so I think it ok to remove this all together

Will be removed.

Regarding the right-hand container (other versions, PDS3 Versions, etc.), is this something we can potentially push back in to an accordion header, much like 'show more'? Why do we have this in its own container (what makes it so special?) Also, no good reason to have each version to be contained in their own card. We can just contain them in to one accordion or module container as you see in the mockup I've attached

Mike will try out accordion as an alternative to see if it makes sense to use instead of cards.

I am confused as to why we use 'bundle' and 'dataset' when concerning Bundles. Are they the same thing? Or are we nudging user to browse the collection with the button? I am not sure what the distinction is.

Mike to try out some different layouts to make this distinction more clear.

We don't have that sized button defined in the design system - it is a bit excessive

Will look to figure out a better way to display this.

We have icons defined in the design system - I have swapped for our flat 'folder' icon.

Copy. Mike will look into this.

@edwardbarraza can you provide a link to the figma mockup you have above?

Here is the link for the DOI work in Figma
I can also link to the Design System that is still WIP, here

Closing out this Epic per comments above and sub-ticket completion. See https://sbnarchivedemo.psi.edu/?identifier=urn:nasa:pds:cassini_iss_saturn:data_raw&mockup=true

authors: Astro-Joni edwardbarraza jordanpadams mdrum


text:
Move workshop to GitHub Pages

Big PR here, with the overall changes required for moving to GitHub Pages using Roy's Specky template for Quarto. In summary:

The website is now a Quarto-based website hosted at GitHub Pages, built and deployed using GitHub Actions.
The website is accessed at https://nbisweden.github.io/workshop-reproducible-research/. It has important pages in a header (home, schedule, content, syllabus, pre-course and info), while lectures and pages can be found through links either in the schedule or content pages.
The tutorials/ and lectures/ directories and unchanged, except that HTML lectures are no longer directly stored in the main Git repository, but are accessed from the website itself.
The schedule can be changed by editing the schedule.xlsx Excel file in the repo root and will be formatted with cool code made by Roy.
The website environment has been consolidated with the lecture environments into a single Docker image hosted in GHCR for this repository, and is automatically built using GHA whenever it is changed. It is used when building and deploying the website, but can also be used for local testing.
The only thing left on Canvas will be the first page, which will be used as a landing page.

Some things still need to be done:

[ ] Go through lectures and check that they are formatted correctly for how they are rendered now.
[ ] Go through the entirety of the material and make sure that there is no odd formatting left from the conversion of the material from Markdown to Quarto.
[ ] Check the other, already existing Actions and see which ones are not needed any more.
[ ] Make new images where required (e.g. the front page), Roy is helping out.
[ ] Resolve Jupyter conflicts (could you do this, John?)

My proposal for this new system would be that we only keep the main branch and either remove/archive or ignore the dev branch, which was only used for testing changes on Canvas. This is no longer necessary as new changes/contributions can be tested by building the website locally before opening a PR from a feature branch. We can keep tagging course rounds as we have done previously, which can be re-build locally if somebody wants to check out them, although experience leads me to believe that this is unlikely to be the case.
This PR is against the devel branch to get a better diff against the latest changes, but as soon as this PR is approved we should also merge it directly into main.

Regarding existing GitHub Actions:

docker-run.yml / docker-build-and-run: This just tests that the Container tutorial image (Dockerfile not Dockerfile_slim) can be built and run. As this is the "final" image of the Container tutorial and not edited by the students it makes sense to keep this, but we might optimise it if we want.
setup.yml / install: This attempts to install all Conda environments on both MacOS and Ubuntu. Good thing to test, but we should change the default fail-fast matrix option to false, as most jobs are currently being cancelled if a single job fails (which for this type of test we don't want). Some steps use outdated actions, which we should update.
setup-slim.yml / docker-slim-install: This does the same as the above action, but inside the image created with the tutorials/containers/Dockerfile_slim Dockerfile. I'm not sure why we do this. I have tried searching through the tutorials and the pre-course setup and find where this image is mentioned, but it just seems that it's the image the students starts with in the tutorial and add changes to. Did we use this before as well for Windows or something, before we required WSL2 for Windows students? Or am I missing something? Currently it seems we could remove this action. (If there is good reason to keep it the same issues as for the above action applies.)

Did we use this before as well for Windows or something, before we required WSL2 for Windows students?

Yes that's exactly what it was for

authors: fasterius johnne


text:
Incorrect time slicing for CMIP6 model(BCC-CSM2-MR)

Hi,
I've recently started using intake-esm for analyzing CMIP6 data. I use the following code to get a time slice of 2080 to 2100 for the BCC-CSM2-MR model, however, it selects the slice from 2090 to 2100. I tried different slicing like 2040-2100, 2050-2100, it works fine for those. However, as soon as it crosses 2070, the o/p falls back to 2090-2100 time slice. The code is working for some other models. This could be a naive doubt as I've started working on this recently and couldn't figure out what exactly might be happening.

#################
##Code:
################
scenario='ssp370'
model='BCC-CSM2-MR'
experiment_ids = ['ssp370']
variable_ids = ['pr']  ##pr: precipitation flux(kg m-1s-1)
table_ids = ['day']  ##Options: Amon(for monthly)
############
col = intake.open_esm_datastore("/glade/collections/cmip/catalog/intake-esm-datastore/catalogs/glade-cmip6.json")
subsethist = col.search(experiment_id=experiment_ids,
variable_id=variable_ids,
table_id=table_ids,source_id='BCC-CSM2-MR')
dset_dict_ssp =subsethist.to_dataset_dict(zarr_kwargs={'consolidated': True,'decode_times': False})
ssp370BCC_CSM2 = dset_dict_ssp['ScenarioMIP.BCC.BCC-CSM2-MR.ssp370.day.gn']
ssp370BCC_CSM280_100=ssp370BCC_CSM2.sel(time=slice('2080', '2100'))
ssp370BCC_CSM280_100
->Dimensions:    (bnds: 2, lat: 160, lon: 320, member_id: 1, time: 4015)
Coordinates:

time       (time) object 2090-01-01 12:00:00 ... 2100-12-31 12:00:00
lat        (lat) float64 -89.14 -88.03 -86.91 -85.79 ... 86.91 88.03 89.14
lon        (lon) float64 0.0 1.125 2.25 3.375 ... 355.5 356.6 357.8 358.9
member_id  (member_id) <U8 'r1i1p1f1'
Dimensions without coordinates: bnds
Data variables:
lat_bnds   (time, lat, bnds) float64 dask.array<chunksize=(4015, 160, 2), meta=np.ndarray>
lon_bnds   (time, lon, bnds) float64 dask.array<chunksize=(4015, 320, 2), meta=np.ndarray>
time_bnds  (time, bnds) object dask.array<chunksize=(4015, 2), meta=np.ndarray>
pr         (member_id, time, lat, lon) float32 dask.array<chunksize=(1, 4015, 160, 320), meta=np.ndarray>

@AkshayaNikumbh, Thanks for this nice write-up.
It appears that the issue is neither intake-esm nor xarray. The culprit here is missing data. When I looked at the list of unique years in the loaded data, I found the following:
[2040, 2041, 2042, 2043, 2044, 2045, 2046, 2047, 2048, 2049, 2050,
2051, 2052, 2053, 2054, 2055, 2056, 2057, 2058, 2059, 2060, 2061,
2062, 2063, 2064, 2090, 2091, 2092, 2093, 2094, 2095, 2096, 2097, 2098, 2099, 2100]

A quick search on ESGF website reveals that there should be at least 4 files ( which span years 2015-2100):

In light of this, I checked on Glade to see which files were available:
$ ls /glade/collections/cmip/CMIP6/ScenarioMIP/BCC/BCC-CSM2-MR/ssp370/r1i1p1f1/day/pr/gn/v20190318/pr
pr_day_BCC-CSM2-MR_ssp370_r1i1p1f1_gn_20400101-20641231.nc  pr_day_BCC-CSM2-MR_ssp370_r1i1p1f1_gn_20900101-21001231.nc

As you can see two files are missing:

pr_day_BCC-CSM2-MR_ssp370_r1i1p1f1_gn_20150101-20391231.nc
pr_day_BCC-CSM2-MR_ssp370_r1i1p1f1_gn_20650101-20891231.nc

My speculation is that something didn't go as expected during the file transfer to Glade and only two of the four files were copied.  One solution is to submit a request via this form: https://www2.cisl.ucar.edu/resources/cmip-analysis-platform/request-cmip6-data-sets, and mentioning in the notes section this problem of missing files. You can even link to this issue.
Pinging @bonnland as he could provide more information on whether other channels exist for reporting missing/corrupt data on CMIP Analysis Platform.
In [1]: import intake

In [2]: col = intake.open_esm_datastore("/glade/collections/cmip/catalog/intake-esm-datastore/catalogs/glade-cmip6.json")

In [3]: scenario='ssp370'

In [4]: model='BCC-CSM2-MR'

In [5]: experiment_ids = ['ssp370']

In [6]: variable_ids = ['pr']

In [7]: table_ids = ['day']

In [8]: subsethist = col.search(experiment_id=experiment_ids, variable_id=variable_ids, table_id=table_ids,source_id='BCC-CSM2-MR')

In [10]: dset_dict_ssp = subsethist.to_dataset_dict(cdf_kwargs={'chunks' : {}})
In [11]: dset_dict_ssp.keys()
Out[11]: dict_keys(['ScenarioMIP.BCC.BCC-CSM2-MR.ssp370.day.gn'])

In [15]: ds = dset_dict_ssp['ScenarioMIP.BCC.BCC-CSM2-MR.ssp370.day.gn']
In [17]: ds.time
Out[17]:
<xarray.DataArray 'time' (time: 13140)>
array([cftime.DatetimeNoLeap(2040-01-01 12:00:00),
       cftime.DatetimeNoLeap(2040-01-02 12:00:00),
       cftime.DatetimeNoLeap(2040-01-03 12:00:00), ...,
       cftime.DatetimeNoLeap(2100-12-29 12:00:00),
       cftime.DatetimeNoLeap(2100-12-30 12:00:00),
       cftime.DatetimeNoLeap(2100-12-31 12:00:00)], dtype=object)
Coordinates:
  * time     (time) object 2040-01-01 12:00:00 ... 2100-12-31 12:00:00
Attributes:
    bounds:         time_bnds
    axis:           T
    long_name:      time
    standard_name:  time
In [21]: import numpy as np
In [24]: unique_years = sorted(np.unique(ds.time.dt.year))

In [25]: print(unique_years)
[2040, 2041, 2042, 2043, 2044, 2045, 2046, 2047, 2048, 2049, 2050,
2051, 2052, 2053, 2054, 2055, 2056, 2057, 2058, 2059, 2060, 2061,
2062, 2063, 2064, 2090, 2091, 2092, 2093, 2094, 2095, 2096, 2097, 2098, 2099, 2100]

Thank you so much for the speedy reply. I hope this issue of missing files would be solved soon.

You are welcome! I submitted a request for the missing files via https://www2.cisl.ucar.edu/resources/cmip-analysis-platform/request-cmip6-data-sets requesting. I will post an update here in the coming days

Sure! I've submitted a request too.
Thanks again!

@AkshayaNikumbh,
I can confirm that this is issue is resolved:

Files that were missing are now available:

In [1]: import intake

In [2]: col = intake.open_esm_datastore("/glade/collections/cmip/catalog/intake-esm-datastore/catalogs/glade-cmip6.json")

In [3]: subsethist = col.search(experiment_id='ssp370', variable_id='pr', table_id='day', source_id='BCC-CSM2-MR')

In [4]: subsethist
Out[4]:
glade-cmip6-ESM Collection with 4 entries:
        > 1 activity_id(s)

        > 1 institution_id(s)

        > 1 source_id(s)

        > 1 experiment_id(s)

        > 1 member_id(s)

        > 1 table_id(s)

        > 1 variable_id(s)

        > 1 grid_label(s)

        > 0 dcpp_init_year(s)

        > 1 version(s)

        > 4 time_range(s)

        > 4 path(s)

In [5]: subsethist.df.path.tolist()
Out[5]:
['/glade/collections/cmip/CMIP6/ScenarioMIP/BCC/BCC-CSM2-MR/ssp370/r1i1p1f1/day/pr/gn/v20190318/pr/pr_day_BCC-CSM2-MR_ssp370_r1i1p1f1_gn_20150101-20391231.nc',
 '/glade/collections/cmip/CMIP6/ScenarioMIP/BCC/BCC-CSM2-MR/ssp370/r1i1p1f1/day/pr/gn/v20190318/pr/pr_day_BCC-CSM2-MR_ssp370_r1i1p1f1_gn_20400101-20641231.nc',
 '/glade/collections/cmip/CMIP6/ScenarioMIP/BCC/BCC-CSM2-MR/ssp370/r1i1p1f1/day/pr/gn/v20190318/pr/pr_day_BCC-CSM2-MR_ssp370_r1i1p1f1_gn_20650101-20891231.nc',
 '/glade/collections/cmip/CMIP6/ScenarioMIP/BCC/BCC-CSM2-MR/ssp370/r1i1p1f1/day/pr/gn/v20190318/pr/pr_day_BCC-CSM2-MR_ssp370_r1i1p1f1_gn_20900101-21001231.nc']

The time slicing also works:

In [6]: dset_dict_ssp = subsethist.to_dataset_dict(cdf_kwargs={'chunks' : {'time': 100}})
Progress: |███████████████████████████████████████████████████████████████████████████████| 100.0%

--> The keys in the returned dictionary of datasets are constructed as follows:
        'activity_id.institution_id.source_id.experiment_id.table_id.grid_label'

--> There are 1 group(s)

In [7]: ds = dset_dict_ssp['ScenarioMIP.BCC.BCC-CSM2-MR.ssp370.day.gn']

In [8]: ssp370BCC_CSM280_100=ds.sel(time=slice('2080', '2100'))

In [9]: ssp370BCC_CSM280_100.time
Out[9]:
<xarray.DataArray 'time' (time: 7665)>
array([cftime.DatetimeNoLeap(2080-01-01 12:00:00),
       cftime.DatetimeNoLeap(2080-01-02 12:00:00),
       cftime.DatetimeNoLeap(2080-01-03 12:00:00), ...,
       cftime.DatetimeNoLeap(2100-12-29 12:00:00),
       cftime.DatetimeNoLeap(2100-12-30 12:00:00),
       cftime.DatetimeNoLeap(2100-12-31 12:00:00)], dtype=object)
Coordinates:
  * time     (time) object 2080-01-01 12:00:00 ... 2100-12-31 12:00:00
Attributes:
    bounds:         time_bnds
    axis:           T
    long_name:      time
    standard_name:  time

Let me know if this is Ok to close.

Thank you so much! I'll close the issue!

You are welcome!

repo: NCAR/intake-esm


text:
Extract biological regions from an NCBI .gff3 file

zgrep -v "^#" interim_GRCh38.p10_top_level_2017-05-03.gff3.gz | awk 'BEGIN{FS="\t";OFS="\t"}$3 == "biological_region"{print $0}'

(not exactly EDirect, but really useful)

repo: NCBI-Hackathons/EDirectCookbook


text:
Introduce guicey-jdbi3

Part of dropwizard-guicey; used for database handle injection and transactions.

Will merge this administratively as we want to release a new version of ANET.

repo: NCI-Agency/anet

license: mit


text:
Remove clickable buttons from organisation preview

The Organisation Preview had buttons that you can click to create a position or to edit assigned superusers. Previews should not contain clickable buttons.
Closes AB#982
User changes

None

Superuser changes

None

Admin changes

Organisation Preview do not have clickable buttons anymore which Admins were able to click earlier.

System admin changes

[ ] anet.yml or anet-dictionary.yml needs change
[ ] db needs migration
[ ] documentation has changed
[ ] graphql schema has changed

Checklist

[x] Described the user behavior in PR body
[x] Referenced/updated all related issues
[x] commits follow a repo#issue: Title title format and these 7 rules
[x] commits have a clean history, otherwise PR may be squash-merged
[ ] Added and/or updated unit tests
[ ] Added and/or updated e2e tests
[ ] Added and/or updated data migrations
[ ] Updated documentation
[ ] Resolved all build errors and warnings
[ ] Opened debt issues for anything not resolved here

Obsoleted by #4549

authors: gjvoosten og-simsoft


text:
Treasury creation: add cancel button & tests

TODO:

cover full e2e flow with playwright

@race-of-sloths include

@rubycop Thank you for your contribution! Your pull request is now a part of the Race of Sloths!
You are true leader! Other sloths hot on your heels, keep moving!

Current status: waiting for scoring
We're waiting for maintainer to score this pull request with @race-of-sloths score [0,1,2,3,5,8,13] command. Alternatively, autoscoring [1,2] will be applied for this pull request
What is the Race of Sloths

Race of Sloths is a friendly competition where you can participate in challenges and compete with other open-source contributors within your normal workflow
For contributors:

Tag @race-of-sloths inside your pull requests
Wait for the maintainer to review and score your pull request
Check out your position in the Leaderboard
Keep weekly and monthly streaks to reach higher positions
Boast your contributions with a dynamic picture of your Profile

For maintainers:

Score pull requests that participate in the Race of Sloths and receive a reward
Engage contributors with fair scoring and fast responses so they keep their streaks
Promote the Race to the point where the Race starts promoting you
Grow the community of your contributors

Feel free to check our website for additional details!

Bot commands

For contributors

Include a PR: @race-of-sloths include to enter the Race with your PR

For maintainers:

Invite contributor @race-of-sloths invite to invite the contributor to participate in a race or include it, if it's already a runner.
Assign points: @race-of-sloths score [1/2/3/5/8/13] to award points based on your assessment.
Reject this PR: @race-of-sloths exclude to send this PR back to the drawing board.
Exclude repo: @race-of-sloths pause to stop bot activity in this repo until @race-of-sloths unpause command is called

Let's fix the Playwright test requirements described here https://github.com/NEAR-DevHub/neardevhub-treasury-dashboard/issues/193 before finalizing this Pull Request

authors: petersalomonsen race-of-sloths rubycop


text:
[feature request] Storing device specific values on NEEO.

Everytime I start a driver i first have to do a discovery. this in itself isn't an issue but in some cases it could help enormously if more values could be stored besides the unique id. An example i would like to store and be able to get using the SDK:
MAC address,  //Using this currently as deviceId. Important for the WOL feature of the driver.
Hostname,  //Using this to connect to the device without the need of additional discovery methods.
Password, //Storing password so that when the driver is killed you don't have to re add the device every time.
User settings. things like filter preference, what lists to show or not to show, thus providing some customizability through the driver.

We are considering adding some helpers for storage to the SDK, would that cover those needs?
The settings you listed look specific to the SDK device itself and not data that would be needed on the Brain.
I think it makes more sense for the SDK to be able to save/load it's own values than to push them too the Brain. It keeps the 2 more decoupled.

I believe that would cover most of my needs.
In my opinion storing local or storing on brain are both viable options. especially in a multi brain configuration like i have, parameters could differ per neeo combo while using the same driver. maybe I'm looking to far in the future as the SDK is currently not multi brain. Please forgive my enthusiasm ;-)
A good example is my kodi setup. I have one HTPC centralized in our home and I'm distributing the HDMI with a HD Anywhere MHUB to multiple TV's. every room with a TV also has a NEEO Combo. The living room would have different settings then the children's room. sure this is an edge case but it's easyer to share the things you like to solve than come up with other good examples.

I agree, that normaly it would make sense to store Infos in the Driver itself, but such things as Username and Password can be changed and needs to be updated from side of the user, without running through the setup again. Therefor it makes sense to use the Brain as Storage and also provide the ability to update these Informations. This is also half way implemented in the Brain, so it just needs the ability to overhand these Infos to the SDK.
Also makes sense to be able to check, if these Infos are allready implementes (in case of Spotify for example) if allready entered it would be great to use it for Spotify Connect drivers or other services.
OF COURSE the access to these Credentials needs to be allowed by the User through the Setup as well as when there was a change in the Credentials.

So to make this a bit more actionable I think we should focus on the driver specific implementation and exclude data stored and have a managed lifecycle (user can update, delete his account information for example).
So your request @nklerk was to store some data for the driver. So then it must be in the responsibility of the driver to maintain this data - so saving this data on the Brain is not a good idea.
To summarise:

you would like an option from the sdk to store some generic data (like last used playlist as example) which are NOT needed to run you driver.

@nklerk any input from you on this issue? the latest SDK supports a "security code" feature (the user can add enter security code - see ikea tradfri). we will implement a username/password feature in a future version too.
about storing data - the brain stored the device id the driver specify - but the rest should be stored by the driver itself.

The reason I request this feature is because i'm used to have this as a feature in another HA product. I can store values and read values in a structured way and every "driver" uses the same method. the SDK is in that case helping out people like me.
what I had in mind is something like this:
const sdk = require "neeosdk";

sdk.configuration.store('shared secret', 'Secr3T');

let secret = sdk.configuration.read('shared secret')

or
const sdk = require "neeosdk";

sdk.configuration.store('preferances', {a:"A",b:"B"});
let 'preferances'= sdk.configuration.read('preferances')

Since we're talking about doing the storage on the SDK side, I think it would make sense to do this via the https://github.com/NEEOInc/neeo-sdk-toolkit/tree/master/ repo via a separate package.
The advantage is it's decoupled from the SDK core and it's not tied to the Brain firmware versions and can be updated more frequently.
Perhaps we can reuse part of https://github.com/NEEOInc/neeo-sdk/pull/80 for that.

@nklerk I would recommend using https://www.npmjs.com/package/conf
I don't think we need a NEEO-SDK specific implementation yet.

Thanks!

authors: carp3-noctem neophob nklerk pfiaux

repo: NEEOInc/neeo-sdk


text:
ProvisioningPolygon missing Layer Indicator from the GIS Data layers registry table

Hello,
I am looking at the nena-sta-006.2-2022_ng9-1-1.pdf and came across a small issue.
The ProvisioningPolygon is one of the required features in the NG9-1-1 GIS Data Model and has the NGUID field required.
The abovementioned document should provide, on page 82, a value for this dataset in the Layer Indicator column but the table does not contain an entry for this dataset.
Please advise what is the appropriate Layer Indicator value for the ProvisioningPolygon.
Thank you.
Regards,
Cristina Cristea
cristina.cristea@calgary.ca

Cristina,
Excellent catch! You are correct. I can verify that the ProvisioningBoundary layer is not defined in Section 7.2 "GIS Data Layers" Registry of NENA-STA-006.2-2022.
I have passed forwarded this question for an official response and addition to the Errata of the upcoming NENA-STA-006.2a. In the meantime, I would guess that it would most likely be something like "Prov" which follows the Layer Name Indicator convention, but that is an unofficial response until I receive further direction.
-Tom

Thanks Tom.
Sounds good.
I will probably get the official answer in a short while (seeing how fast I got your answer).
Best regards,
Cristina
Cristina Cristea
Geospatial Analyst
Geospatial Business Solutions
Collaboration, Analytics & Innovation
The City of Calgary | Mail Code #8026
P.O. Box 2100, Station M, Calgary, AB Canada T2P 2M5
E: @.@.> C: 403-614-3834
From: Tom Neer @.>
Sent: Thursday, March 2, 2023 10:38 AM
To: NENA911/NG911GISDataModel @.>
Cc: Cristea, Cristina @.>; Author @.>
Subject: [External] Re: [NENA911/NG911GISDataModel] ProvisioningPolygon missing Layer Indicator from the GIS Data layers registry table (Issue #66)
Cristina, Excellent catch! You are correct. I can verify that the ProvisioningBoundary layer is not defined in Section 7. 2 "GIS Data Layers" Registry of NENA-STA-006. 2-2022. I have passed forwarded this question for an official response and
ZjQcmQRYFpfptBannerStart
This Message Is From an External Sender
This message came from outside your organization.
ATTENTION: Do not click links or open attachments from external senders unless you are certain it is safe to do so. Please forward suspicious/concerning email to @.@.>
ZjQcmQRYFpfptBannerEnd
Cristina,
Excellent catch! You are correct. I can verify that the ProvisioningBoundary layer is not defined in Section 7.2 "GIS Data Layers" Registry of NENA-STA-006.2-2022https://urldefense.com/v3/__https:/cdn.ymaws.com/www.nena.org/resource/resmgr/standards/nena-sta-006.2-2022_ng9-1-1_.pdf__;!!JYTOG454!dMKZh6rpSwjgk_lwM_r98a6xyToC8_2N08ijhtJxvTpaAhcJpXIg541x29lI4R_AJJ22potYa2CN0oFr8jFbwEr21VrtNyH_$.
I have passed forwarded this question for an official response and addition to the Errata of the upcoming NENA-STA-006.2a. In the meantime, I would guess that it would most likely be something like "Prov" which follows the Layer Name Indicator convention, but that is an unofficial response until I receive further direction.
-Tom
—
Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https:/github.com/NENA911/NG911GISDataModel/issues/66*issuecomment-1452258697__;Iw!!JYTOG454!dMKZh6rpSwjgk_lwM_r98a6xyToC8_2N08ijhtJxvTpaAhcJpXIg541x29lI4R_AJJ22potYa2CN0oFr8jFbwEr21V5oTQKX$, or unsubscribehttps://urldefense.com/v3/__https:/github.com/notifications/unsubscribe-auth/A6HOYCSMV24HWLFJHAC3SM3W2DLG5ANCNFSM6AAAAAAVNU6PQM__;!!JYTOG454!dMKZh6rpSwjgk_lwM_r98a6xyToC8_2N08ijhtJxvTpaAhcJpXIg541x29lI4R_AJJ22potYa2CN0oFr8jFbwEr21auYHXrs$.
You are receiving this because you authored the thread.Message ID: @.@.>>

NOTICE -
This communication is intended ONLY for the use of the person or entity named above and may contain information that is confidential or legally privileged. If you are not the intended recipient named above or a person responsible for delivering messages or communications to the intended recipient, YOU ARE HEREBY NOTIFIED that any use, distribution, or copying of this communication or any of the information contained in it is strictly prohibited. If you have received this communication in error, please notify us immediately by telephone and then destroy or delete this communication, or return it to us by mail if requested by us. The City of Calgary thanks you for your attention and co-operation.

Hi Tom,
If you don’t mind, I would like to ask you a question in regards to the Street Name Post types available for the RaodCenterLine feature.
Looking at the provided documentation - http://technet.nena.org/nrs/registry/StreetNamePreTypesAndStreetNamePostTyp, I can see that we- The City of Calgary, have a couple of names that are not in this list:

Parade
Link
Villas – this could be a variation of Villa, which is already in the table.
Is there a way that the reference material and the provided list could be updated with the missing values?
If your answer is ‘YES’, what do we need to do to have the above mentioned types added to the list?
If the answer is ‘No’, how do we deal with the roads that have these values to be able to add them in the GDB?
Thank you very much.
Best regards,
Cristina

Cristina Cristea
Geospatial Analyst
Geospatial Business Solutions
Collaboration, Analytics & Innovation
The City of Calgary | Mail Code #8026
P.O. Box 2100, Station M, Calgary, AB Canada T2P 2M5
E: @.@.> C: 403-614-3834
From: Tom Neer @.>
Sent: Thursday, March 2, 2023 10:38 AM
To: NENA911/NG911GISDataModel @.>
Cc: Cristea, Cristina @.>; Author @.>
Subject: [External] Re: [NENA911/NG911GISDataModel] ProvisioningPolygon missing Layer Indicator from the GIS Data layers registry table (Issue #66)
Cristina, Excellent catch! You are correct. I can verify that the ProvisioningBoundary layer is not defined in Section 7. 2 "GIS Data Layers" Registry of NENA-STA-006. 2-2022. I have passed forwarded this question for an official response and
ZjQcmQRYFpfptBannerStart
This Message Is From an External Sender
This message came from outside your organization.
ATTENTION: Do not click links or open attachments from external senders unless you are certain it is safe to do so. Please forward suspicious/concerning email to @.@.>
ZjQcmQRYFpfptBannerEnd
Cristina,
Excellent catch! You are correct. I can verify that the ProvisioningBoundary layer is not defined in Section 7.2 "GIS Data Layers" Registry of NENA-STA-006.2-2022https://urldefense.com/v3/__https:/cdn.ymaws.com/www.nena.org/resource/resmgr/standards/nena-sta-006.2-2022_ng9-1-1_.pdf__;!!JYTOG454!dMKZh6rpSwjgk_lwM_r98a6xyToC8_2N08ijhtJxvTpaAhcJpXIg541x29lI4R_AJJ22potYa2CN0oFr8jFbwEr21VrtNyH_$.
I have passed forwarded this question for an official response and addition to the Errata of the upcoming NENA-STA-006.2a. In the meantime, I would guess that it would most likely be something like "Prov" which follows the Layer Name Indicator convention, but that is an unofficial response until I receive further direction.
-Tom
—
Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https:/github.com/NENA911/NG911GISDataModel/issues/66*issuecomment-1452258697__;Iw!!JYTOG454!dMKZh6rpSwjgk_lwM_r98a6xyToC8_2N08ijhtJxvTpaAhcJpXIg541x29lI4R_AJJ22potYa2CN0oFr8jFbwEr21V5oTQKX$, or unsubscribehttps://urldefense.com/v3/__https:/github.com/notifications/unsubscribe-auth/A6HOYCSMV24HWLFJHAC3SM3W2DLG5ANCNFSM6AAAAAAVNU6PQM__;!!JYTOG454!dMKZh6rpSwjgk_lwM_r98a6xyToC8_2N08ijhtJxvTpaAhcJpXIg541x29lI4R_AJJ22potYa2CN0oFr8jFbwEr21auYHXrs$.
You are receiving this because you authored the thread.Message ID: @.@.>>

NOTICE -
This communication is intended ONLY for the use of the person or entity named above and may contain information that is confidential or legally privileged. If you are not the intended recipient named above or a person responsible for delivering messages or communications to the intended recipient, YOU ARE HEREBY NOTIFIED that any use, distribution, or copying of this communication or any of the information contained in it is strictly prohibited. If you have received this communication in error, please notify us immediately by telephone and then destroy or delete this communication, or return it to us by mail if requested by us. The City of Calgary thanks you for your attention and co-operation.

Cristina,
I have moved this question to another issue and will respond.
https://github.com/NENA911/NG911GISDataModel/issues/69
-Tom

Per this issue, we are having internal discussions on how to address the missing Provisioning Layer boundary. For right now, it is recommended to unofficially use "Prov".
This issue was identified and is in the process of being addressed. However, it may not be addressed until v3. Because NENA creates ANSI-accredited Standards Developer, there are procedures that need to be adhered to before we can make changes "officially".
I am going to close this issue as referred to NENA DS-NG GIS Data Model WG.

authors: CCCristea tomneer


text:
Add tr translation to SAO Utils 2

Thanks for your help, I finally uploaded it.
I like sao utils 2 very much. It's exactly the app I was looking for. :)

com.gpbeta.theme.zelda.botw
There is a translation of this theme, is it an extra problem?

I tested it, there doesn't seem to be any problem.

repo: NERvGear/locales


text:
Nest

Nest

Claim

Claim

repo: NEST-Protocol/NESTRedEnvelopesBot


text:
Should embed_tokens.weight and lm_head.weight be frozen in stage1 and stage 2

In stage1 and stage2 these two weights are trainable. And the layer name is "llama_model.model.embed_tokens.weight"  and  "llama_model.lm_head.weight"
But it seems that stage3 not load these two weights correctly, as the layer name are "llama_model.base_model.model.model.embed_tokens.weight" and "llama_model.base_model.model.lm_head.weight" in stage3

Thank you for your interest and for bringing up this issue. So this is indeed a bug, but fortunately has a minor influence. We actually updated the code three weeks ago and trained the system again into a new checkpoint.
You can use the new codes and download new checkpoints. Thanks!

authors: ChocoWu zzzzzzrc

repo: NExT-GPT/NExT-GPT


text:
 in  should generated correct padding

Version
1.8.0
Environment
Windows 10
Chrome 70.0.3538.102（正式版本） （64 位）
ng-zorro-antd@1.8.0
Reproduction link
https://stackblitz.com/edit/ng-zorro-antd-start-z14eiy?file=src%2Fapp%2Fapp.component.html
Steps to reproduce
<nz-form-item nzGutter="8">
  <nz-form-control nzSpan="10">
    <nz-form-text>Col 10 In Form</nz-form-text>
  </nz-form-control>
</nz-form-item>

What is expected?
<nz-form-control> get correct style padding-left: 4px; padding-right: 4px, like [nz-col] in [nz-row].
What is actually happening?
<nz-form-control>  has no style, but <nz-form-item> generated margin style.
Other?

Hi, I would like to look into this bug if that's okay, please?

@asincole 👏 Sure! Welcome to contribute. Feel free to open a pr.

Alright, great. I have forked already and will start working on it tonight. This is my first Contribution to an OSS, any tips or hints outside the ones in the CONTRIBUTING.md or general tips? @wendzhue

Hi, so I have taken a look at it, I discovered that the nz-form-control selector has no padding added, so I have added that, but then once nzSpan directive is added, the padding rule gets overwritten and then set to 0 which are the rules for nzSpan directive. So I added an extra rule to override it
 .@{form-prefix-cls}-item-control-wrapper {     display: block;     width: 100%;     padding-right: 4px;      padding-left: 4px;     &[class^="@{ant-prefix}-col-"] { // adds the padding rules to overwrite the nzSpan directive rules       padding-right: 4px;       padding-left: 4px;     }
is repeating the rules optimal or is there a better way I can do it?

@asincole You can just create a pr and we would review your code there.

@wendzhue alright. I'll do it in a bit.. sorry about the delay. Thanks.

@issuehuntfest has funded $20.00 to this issue. See it on IssueHunt

fixed in https://github.com/NG-ZORRO/ng-zorro-antd/pull/2493/files#diff-611562526e66dba4ffd92fb8fa6cdd54R126

authors: IssuehuntBot asincole vthinkxie wendzhue wheeljs

repo: NG-ZORRO/ng-zorro-antd


text:
tootlip文字提示多次点击，页面左上角会多出来一个黑块

Reproduction link
https://ng-zorro-antd-start.stackblitz.io
Steps to reproduce
tootlip文字提示多次点击，页面左上角会多出来一个黑块
What is expected?
不会出现多余的黑块
What is actually happening?
会出现黑块

Environment
Info

ng-zorro-antd
8.2.1

Browser
76.0.3809.132

同样的问题，而且多出的黑块会叠加

@michael2043 能够写一个复现吗，帮助我们排查这个问题。

StackBlitz上再现不出来，只能在我的工程里的某个操作下才能出现。我把控制台截给你们看看吧

bug repro https://stackblitz.com/edit/angular-r36j27?file=src/app/app.component.ts

@michael2043 I will take a deeper investigation into this. Thank you for your comment.

还是有同样的问题，同样还原至7.5.1不再现

closed by #4387


text:
docs: add components overview page

close #5356
PR Checklist
Please check if your PR fulfills the following requirements:

[x] The commit message follows our guidelines: https://github.com/NG-ZORRO/ng-zorro-antd/blob/master/CONTRIBUTING.md#commit
[ ] Tests for the changes have been added (for bug fixes / features)
[x] Docs have been added / updated (for bug fixes / features)

PR Type
What kind of change does this PR introduce?
Add components overview page like Ant Design Components Overview.

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #5356
What is the new behavior?
Does this PR introduce a breaking change?
[ ] Yes
[x] No

Other information

@wendellhu95 @vthinkxie preview 没更新的话清除一下浏览器缓存

authors: YuchenWell hsuanxyz


text:
Redesign profile and course information on profile pages

Closes #114
This does not only work with own profile information, but with other people information.

Looks great and works flawlessly for me. Only thing I'd point out is that this link is taking up the entire width of the box, which can lead to opening the link rather than the "box's content".

Looks great and works flawlessly for me. Only thing I'd point out is that this link is taking up the entire width of the box, which can lead to opening the link rather than the "box's content". This can be easily fixed with width: fit-content;.

Nice point! I'll try to fix it ^^
The card looks comically wide though, can you send an entire page screenshot, please? I think it's due to flex-basis: 45%; being the ideal on my resolution but on larger monitors maybe it stretches out the card, but the screenshot an confirm that ^^

Looks great and works flawlessly for me. Only thing I'd point out is that this link is taking up the entire width of the box, which can lead to opening the link rather than the "box's content". This can be easily fixed with width: fit-content;.

Nice point! I'll try to fix it ^^
The card looks comically wide though, can you send an entire page screenshot, please? I think it's due to flex-basis: 45%; being the ideal on my resolution but on larger monitors maybe it stretches out the card, but the screenshot can confirm that ^^

Here's the screenshot, to be honest I don't think it looks that bad, I do like the fact that these important parts take up a nice amount of real estate of the page. Regardless, do as you see fit. :)

Here's the screenshot, to be honest I don't think it looks that bad, I do like the fact that these important parts take up a nice amount of real estate of the page. Regardless, do as you see fit. :)

I'll cc. @ttoino @thePeras wdyt? should we keep as it is? or should we change it to try and make the cards try to fit the content?

Here's the screenshot, to be honest I don't think it looks that bad, I do like the fact that these important parts take up a nice amount of real estate of the page. Regardless, do as you see fit. :)

I'll cc. @ttoino @thePeras wdyt? should we keep as it is? or should we change it to try and make the cards try to fit the content?

I prefer fitting the content

Here's the screenshot, to be honest I don't think it looks that bad, I do like the fact that these important parts take up a nice amount of real estate of the page. Regardless, do as you see fit. :)

I'll cc. @ttoino @thePeras wdyt? should we keep as it is? or should we change it to try and make the cards try to fit the content?

It might look better if it fits to the content. Also, I think the cards should have the same height, I'm sure this can be achieved with some flex box property.

I've fixed the width of a card, and just in case the se-course-card-list container is too small for a card's width, we use container queries to resize the card to fit 100% of the se-course-card-list container ^^.

It might look better if it fits to the content. Also, I think the cards should have the same height, I'm sure this can be achieved with some flex box property.

Should the cards have the same size even though it implies that we might get unwanted extra space at the bottom? I prefer the look of this, but if the majority prefers the height being the same through out the cards, I can change it.

I've fixed the width of a card, and just in case the se-course-card-list container is too small for a card's width, we use container queries to resize the card to fit 100% of the se-course-card-list container ^^.

It might look better if it fits to the content. Also, I think the cards should have the same height, I'm sure this can be achieved with some flex box property.

Should the cards have the same size even though it implies that we might get unwanted extra space at the bottom? I prefer the look of this, but if the majority prefers the height being the same through out the cards, I can change it.

IMO the cards being the same height would look the best, and if we align the info to the bottom, then we won't have any weird empty space. Picture for clarity:

authors: LuisDuarte1 thePeras toni-santos ttoino

repo: NIAEFEUP/sigarra-extension


text:
Memoria: otros apuntes de diseño

hairlines (patrón IU)
responsive
imagenes por defecto

Yo lo juntaría todo dentro del rediseño de interfaz, no le veo sentido a tener 3 apartados nuevos extra referentes al nuevo diseño, pero que decida Virginia. Por lo demás, he realizado pequeñas correcciones

authors: Lurngi crisselene


text:
Added c code for binary search

For short term contributors: we understand that getting your commits well
defined like we require is a hard task and takes some learning. If you
look to help without wanting to contribute long term there's no need
for you to learn this. Just drop us a message and we'll take care of brushing
up your stuff for merge!
Fixes #188
By submitting this pull request I confirm I've read and complied with the
below declarations.

[x] I have read the Contribution guidelines and I am confident that my PR reflects them.
[x] I have followed the commit guidelines for this project.
[x] My code follows the standard code structure.
[x] This pull request has a descriptive title. For example, {Tag}: Add {Algorithm/DS name} [{Language}], not Update README.md or Added new code.
[x] This pull request will be closed if I fail to update it even once in a continuous time span of 7 days.
[x] This pull request shall only be reviewed and merged once all the checks passes. No maintainer or supporter shall be obliged to review it before this condition is met.
[x] I have mentioned the issue number correctly (with hyperlink) in this pull request description.

After you submit your pull request, DO NOT click the 'Update Branch' button.

Read the guidelines and ask for assignment of an issue before opening any Pull Request and wasting others time. Thank you for your time.

authors: sangamcse shimonaverma

repo: NITSkmOS/Algorithms


text:
Footer fix to the bottom.

Fix the footer to the bottom and make sure it doesn't overlap with other components

I would like to work on this issue. Can you please let me know how to proceed?

Set up the repo in your machine by following the readme.
Start it and add some data. You can then see that the footer creates problems.
Solve that.

@shreyateeza working on it?

Is anyone still working on this? I am willing to do it

Is anyone still working on this? I am willing to do it

Yeas, you may.

I have opened a pull request, can you please check it out?

authors: dev-sankhadip shreyateeza thebishaldeb

repo: NJACKWinterOfCode/Instances


text:
Fix python module len() implementations

They were all missing the self. prefix when accessing the obj
instance variable, causing the following exception when attempting to
call len() on (for example) a ReplyInfo_RRSet:
  File "/usr/lib/python3.7/site-packages/unboundmodule.py", line 377, in __len__
    def __len__(self): return obj.rrset_count
NameError: name 'obj' is not defined

Thanks! I'll merge this after the 1.11 release.

authors: ralphdolmans tobbez

repo: NLnetLabs/unbound


text:
MDLC support for .NET Core

Feature Inquiry/Request
NLog version: 4.4.0 - *
Platform: .Net Core
According to the Platform Support page, it seems that there is not yet planned support of MDLC for .Net Core yet, is this correct? And if so, do we know when can we expect the support to be available?
Ask because we currently rely on MDLC to track things like correlation IDs and stuff, to keep them "logic context safe" and the render layout is really convenient to output them.
Thanks.

According to the Platform Support page, it seems that there is not yet planned support of MDLC for .Net Core yet, is this correct? And if so, do we know when can we expect the support to be available?

The platform support page only shows the current support. We prefer to support everything which is available in NLog 4, but not everything has the same prio.
Currently the development for .NET core is limited 'cause:

The tools are not stable (not one my local machine, not on AppVeyor)
We are missing some needed classes in .NET core (planned for netstandard 2)
The non-core version of NLog (4.3.x) needs also some time (questions, bugs etc)

Will check now why MDLC is not implemented yet

it uses system.runtime.remoting.messaging.logicalcallcontext, which isn't available on .NET Core?

Thanks for the response.  And yes CallContext probably won't be on .NET Core due to its tie to remoting. Though it seems like possible to add a branch of implementation under MDLC API to use AsyncLocal for 4.6/Core CLR. I'll see if I can put together something for this.

That would be great! We like to support this!

Any luck in this?

I'm also interested in the status of this, and possibly submitting a pull request if it isn't already in the works. It seems like something along these lines (with AsyncLocal<> as mentioned above) could do the trick: http://theburningmonk.com/2015/05/a-consistent-approach-to-track-correlation-ids-through-microservices/

PR would be great !
AFAIK nobody is working in it

@304NotModified Has now been resolved

Yes!
Have to fix #2033 and then it will be releases (beta 7 )

@304NotModified Think this can be resolved with the release of NLog 5.0 BETA7

\0/ nice

authors: 304NotModified benchaikin snakefoot zhangsiy

repo: NLog/NLog


text:
Register NLog configuration items without assembly reflection

Instead of using reflection and class attributes, then it should be possible to register NLog Configuration Item Types directly:

NLog Target
NLog Layout
NLog LayoutRenderer (Along with ambient properties)
NLog Conditions
NLog Filters
NLog TimeSource

When having introduced the new system, then all default NLog Configuration Items (in NLog.dll + NLog.Extensions.Logging + NLog.Web + NLog.Web.AspNetCore) should use the new system, and only use the old reflection-based-approach for backwards-compatibility (Ex. loading assemblies with NLog-extensions).
I guess that means loosing the multi-type-alias-logic, since the obvious type-alias would be the class-name. And to have multiple-type-alias then one would just have inheritance-class-name for each alias.
I guess it also means obsoleting the old dependency injection override logic, where re-assigning ConfigurationItemFactory.CreateInstance-delegate.
This should be the stepping stone for moving from NLog v5 to NLog v6. Where NLog v6 will only support the new style. See also #3366

Step 2 would probably be to focus on not using reflection for property-assignment, where the NLog Configuration Item Type announces what options are available. Ex. implements interface with method that returns dictionary of functors for assigning available properties.

This should be the stepping stone for moving from NLog v5 to NLog v6. Where NLog v6 will only support the new style.

Looks like Step 2 can be "easily" reached by just using typeof(T).GetProperties() like this:
public static T RegisterType<[DynamicallyAccessedMembers(DynamicallyAccessedMemberTypes.PublicProperties)] T>(Func<T> targetCreator) where T : TargetBase
{
    var properties = () => typeof(T).GetProperties();
}

Was cheated by PolySharp, that apparently doesn't work correctly. PolySharp correctly declared DynamicallyAccessedMembers and DynamicallyAccessedMemberTypes for the compiler, but the linker didn't react to them. But having them directly in the NLog-assembly worked correctly.

Resolved by #5191


text:
[5pt] FIM 2 MS headwater mapping

Multiple areas where FIM 2 MS headwater mapping appears to extend much farther upstream of FIM 3 MS.  For example 12020006 the upstream most segment for MS configuration the FIM 2 (red) vs FIM 3 (blue):

@TrevorGrout-NOAA Is this still important?

authors: BradfordBates-NOAA TrevorGrout-NOAA

repo: NOAA-OWP/cahaba


text:
edits to only calculate subnetworks on first iteration of for loops

Changes made to only calculate subnetworks on first iteration of for loops. Subnetwork objects needed in compute.py are stored in a new list, subnetwork_list, which is passed to and returned from functions nwm_route and compute_nhd_routing_v02.
Additions

New object, subnetwork_list, stores either two (for "by-subnetwork-jit-clustered") or three (for "by-subnetwork-jit") subnetwork objects.
subnetwork_list is passed to and returned from two functions,  nwm_route and compute_nhd_routing_v02, as second item in list. The first item is the original returns from these functions.
Original returns and subnetwork list are extracted as individual objects upon completion of functions nwm_route and compute_nhd_routing_v02 so as to not interfere with ensuing operations to results.

Removals

Changes

Testing

Tested that code completes with loops for all parallel compute methods

Screenshots
Notes

Todos

Checklist

[ ] PR has an informative and human-readable title
[ ] Changes are limited to a single goal (no scope creep)
[ ] Code can be automatically merged (no conflicts)
[ ] Code follows project standards (link if applicable)
[ ] Passes all existing automated tests
[ ] Any change in functionality is tested
[ ] New functions are documented (with a description, list of inputs, and expected output)
[ ] Placeholder code is flagged / future todos are captured in comments
[ ] Visually tested in supported browsers and devices (see checklist below :point_down:)
[ ] Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
[ ] Reviewers requested with the Reviewers tool :arrow_right:

Testing checklist
Target Environment support

[ ] Windows
[ ] Linux
[ ] Browser

Accessibility

[ ] Keyboard friendly
[ ] Screen reader friendly

Other

[ ] Is useable without CSS
[ ] Is useable without JS
[ ] Flexible from small to large screens
[ ] No linting errors or warnings
[ ] JavaScript tests are passing

@awlostowski-noaa
I got the problem sorted, the model now runs without issues for both methods that require calculation of subnetworks.

repo: NOAA-OWP/t-route


text:
crash if we try to define a new attribute on a variable that's not defined.

Reported by ansley b manke on 4 Sep 2008 21:27 UTC
This worked correctly prior to Ferret v6.1, and is in the beta- and test versions of v6.13.
~ansley/build_v613/linux/FERRET/fer/ferretdods_gui
        NOAA/PMEL TMAP
        FERRET v6.13 (beta)
        Linux(g77) 2.4.21-32 - 08/28/08
         4-Sep-08 14:24

yes? define attribute novar.new = " a new attribute"
Segmentation fault

Should issue an error message.
 **ERROR: variable unknown or not in data set: novar.new
 **ERROR: invalid command: variable or axis does not exist in dset 1 novar

The bug is due to the fix for #1578, in cd_get_var_id.F.
Migrated-From: http://dunkel.pmel.noaa.gov/trac/ferret/ticket/1595

Comment by ansley.b.manke on 5 Jan 2011 22:15 UTC
Already fixed.

repo: NOAA-PMEL/Ferret

license: Unlicense


text:
Add tutorials

The tutorials are already in the docs src, it just needs to be re-enabled.

closed via #51


text:
PDF report template for PV-battery / Single Owner broken

Describe the bug
Page 2 of PDF report for PV-battery with PPA financial models has LK error messages:
[173]: operand to # ('sizeof') must be a array, string, or table type
[173]: eval error in statement list
[173]: error inside function call
[508]: eval error in statement list
[3]: eval error in statement list

To Reproduce
Steps to reproduce the behavior:

Create default PV-battery / Single Owner case.
Click Generate report on Case menu.

@cpaulgilman I can take a look at this if you'd like.

Thanks! Need to test with both PPA price and retail rate options  for battery charge power, and for the other PPA financial models.

I needed to take out the variables energy delivered to load for the PPA models as there is no load data. PR is up for review.

authors: cpaulgilman mjprilliman

repo: NREL/SAM


text:
Debug ETL on managed infrastructure, i.e. [new] staging

Because ideally this should work here too

@davidmihalyi Have you had any recent experience with this? I.e. can we do a full CH load and larger GS loads on staging.resourceprojects.org?

Still not able to get full CH import through on staging... :(

OK, thanks for trying!

also no error message either...

The CH import works on a version of staging with more memory (2G) and no LB that would kill it in the event of failing healthchecks (cc @iprunache that I am getting this right).
We need to make a final decision on whether this is a tenable solution for the future or whether we want to live with giving our instances more memory just because of infrequent imports.
Certainly I'm sure some optimization can be done, for example tuning what data is loaded from the DB (i.e. only certain fields, or tuning queries) when doing checks for existing items but we will probably not get away from the fact that importing is a) infrequent and b) more memory intensive than most site requests.
Once these decisions are made we can close this issue.

@mattfullerton, you described the issue accurately.

Understood.  We will have to push solving this issue (one way or the other) next year.
For now I would like one round of clean import this week (with extra memory) to use for a last data refresh for the year.
Thanks

authors: davidmihalyi iprunache mattfullerton


text:
Local Weather Data Collection

As an Analyst, I need to collect or identify where I can get local weather data to compare to incident date, time, city, and state so that I can ensure accurate weather reported in the dataset.
Note
The Federal Railroad Administration (FRA) incident report forms include weather data at the time/location of the incident. However, these reports are often filled out long after an incident and weather information may not be precise. Also, as part of the latter project would be to see extreme temperature fluctuations, so the weather the day before or after an incident, information that isn't included in the FRA report.
References
National Oceanic and Atmospheric Administration
Weather Underground
OpenWeather (API)
Key Variables are:
Temperature
Visibility
Weather Conditions
State
County

OpenWeather.com is a site that provides a free account and access to APIs to query historical data. @NRSchaaf created an account, obtained an API and configured code to pull historical weather data based on GPS coordinates and date range. Reference RR_Accident_Weather.ipynb file.


text:
[Bug]: improve user experience

Describe the bug

In the navlinks, projects page is empty so we can keep that at the last link in the navbar. As the user changes it's tab first page(project) comes empty which looks bad, so we can put this navlink at the end.
Secondly, in the resources page we can add hover animation on the cards which will improve the user experience.

To Reproduce
No response
Expected Behavior
empty pages links should be at the end. And we can add an hover effect on resources cards.
Screenshot/ Video
No response
Desktop (please complete the following information)
No response
Additional context
@pradeeptosarkar I would love to work on this.

someone is assigned with the task to build projects page
you can work on hover effect

ya @MadhuSaini22 you may proceed with the hover effects

ya @MadhuSaini22 you may proceed with the hover effects

Thanks

authors: MadhuSaini22 mnnkhndlwl pradeeptosarkar

repo: NSCC-BPIT/NSCC-BPIT-Website


text:
[Feature]: new page under devops for ansible

Is your feature request related to a problem? Please describe.
https://www.nsccbpit.tech/devops
create the page for the subject, connect it to the card.
On the page provide all information and resources related to the concerned topic such as tutorials, documentation, youtube channels, articles, courses etc.
Describe the solution you'd like
No response
Describe alternatives you've considered
No response
Additional context
No response

Can you assign this to me? @pradeeptosarkar

assigned to @Shruti700


text:
add link to view python source code

in doc/source/conf.py, add the sphinx.ext.viewcode extension to the list of Sphinx extension modules, this is useful documentation for learning how to write plans

Thanks for the suggestion, @prjemian.

authors: danielballan prjemian

repo: NSLS-II/bluesky


text:
FIX: fixing a typo using docker-py

Not sure how I overlooked it here: https://github.com/NSLS-II/lightsource2-recipes/pull/390/files#diff-f645538a35b21f9b4698a3b9cf8fb816R26.

Self-merging, tested locally.


text:
Improved code coverage of nspmessage app

Also new_message view doesn't create message object unless the following statements are true:
    if Follow.objects.filter(follower=sender, following=receiver):
        if Follow.objects.filter(follower=receiver, following=sender):

Pull Request Test Coverage Report for Build 32

34 of 35 (97.14%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+3.5%) to 77.185%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

nspmessage/views.py
4
5
80.0%

Totals

Change from base Build 30:
3.5%

Covered Lines:
998

Relevant Lines:
1293

💛  - Coveralls

repo: NSP-Community/NSP


text:
transparnet background does not work

Thanks for the great color scheme. I love it. After updating to the latest version, transparent doesn't work.
The code in the Customization variables doesn't run again after calling the setup function. move this block to load_colorscheme does work. I'm not familiar with lua, so I don't know if is not elegant to just move this block into load_colorscheme function. So I made no PR. : )

Have you ran 'PackerCompile' after change your configuration?

Didn't know this was a lazy-loader code. Shouldn't 'PackerSync' have don't the job already. I have a setting that runs 'PackerSync', every time there is change in my config. Guess I need to do that for compile as well. Thanks.

authors: aniketgm dragove


text:
Trivial: server should wait if port open or message could be made friendlier

A minor thing I noticed today: if bitcoind has been started but RPC server is still not up, TumbleServer suggests that server.config be changed:
info: Configuration[0]
      Testing RPC connection to http://localhost:18332/
fail: Configuration[0]
      Error connecting to RPC Rescanning...
fail: Main[0]
      Please, fix rpc settings in /home/testuser/.ntumblebitserver/TestNet/server.config

testuser@ubuntu:~/NTumbleBit/NTumbleBit.TumblerServer$ telnet localhost 18332
Trying ::1...
Connected to localhost.
Escape character is '^]'.
^C^C^CConnection closed by foreign host.

While not many users would start TumbleServer right away, some perhaps will and may wonder what's wrong with their configuration file.
Suggestion: Please, fix rpc settings  to Please ensure RPC server is running and accessible or fix RPC settings in may be better and cover both this and potential firewall issues as well.

fixed in https://github.com/NTumbleBit/NTumbleBit/commit/e63132175cf5d84a279026bb0b3e7e46d135a5e5

authors: NicolasDorier unsystemizer

repo: NTumbleBit/NTumbleBit


text:
Legge/wavreader module & role

This pull request creates a wav reader module inside module/input. It will take in a test wav file and output the string of its data. The intention of this module is to be used in a future module named "SpeechRecognition". The speech rec module will receive the wavreader's data to carry out future speech recognition.

There are a lot of changes in this PR that should not exist in this PR

Also, if all you want to do is read the entire file into a vector, we have a utility for that

There's a bunch of undefined reference errors during linking to names in fst and kaldi, I conjecture that we need a couple more find files.

authors: Bidski CMurtagh-LGTM thomaslegge98

repo: NUbots/NUbots


text:
Label shape incorrect

Hello,
I am creating a dataset for single class object detection. I have labelled my images with euclid. My label text files only contain one class: "Class1". I have verified this with a python script. When I create the dataset, I specify dontcare, Class1 as my custom labels. Unfortunately, when the datset is created my train label shape is (1, 3, 16) instead of (1, 2, 16). Furthermore, my validation set has a label shape of (1,2,16).
Any ideas?

Found an extra line in one of my label files. But it was still of the same class: "Class1". What does the label_shape actually represent?

repo: NVIDIA/DIGITS


text:
Remove HLSL/GLSL compatibility header

The key change here is the removal of HlslGlslCommon.h, which had been used to make a certain number of GLSL types available in HLSL code.
This is largely a byproduct of Falcor's legacy, starting as a GL-only framework.
Now that all of the shader code has been ported to HLSL, and cross-API compatibility will be handled via translation of that HLSL input, it makes sense to start writing things using more idiomatic pure HLSL.
The remaining changes here are just renaming changes in all of the affected shader code: vec3 becomes float3, etc.
The one notable exception to all this is toy.fs for the ShaderToy example, since the whole point there is that it is supposed to be GLSL code.
I've gone ahead and hand-copied a few definitions into toyContainer.fs just to make things work, but this isn't really a robust solution for arbitrary GLSL code.

Closing. I'll try to put up a more complete PR when it is ready.

repo: NVIDIA/Falcor


text:
possible bug in len penalty -- assumption that all logits have the same sign?

Hi,
On and around line 69 of kernels/beam_search_penalty_kernels.cu (https://github.com/NVIDIA/FasterTransformer/blob/main/src/fastertransformer/kernels/beam_search_penalty_kernels.cu#L69), shouldn't there be a check to see if logits[end_id + vocab_size_padded_offset] is > T(0) before deciding whether to multiply or divide by len_penalty? There is a check to see if logits[prev_id + vocab_size_padded_offset] is > T(0) but no similar check for logits[end_id + vocab_size_padded_offset]. Is there an assumption that the sign of the logits is the same for all logits?
Thanks!

Hi, kgimpel. Thanks for your fallback. This is really a bug. We will fix it in next release.

Hi, kgimpel. This bug is fixed in latest main branch.

Close this bug because it is inactivated. Feel free to re-open this issue if you still have any problem.

authors: byshiue kgimpel

repo: NVIDIA/FasterTransformer


text:
gptSessionBenchmark Failed Because of " Assertion failed: d == a + length " with 0.7.1 Release in tritonserver:23.12-trtllm-python-py3 Image

Trying to replicate the benchmark by following the official guide for Llama2-7b with latest release 0.7.1 and triton server image 23.12-trtllm-python-py3  on a single H100 GPU.
Build engine command (followed the official guide):
python examples/llama/build.py \
	--remove_input_padding \
	--enable_context_fmha \
	--parallel_build \
	--output_dir examples/llama/out/7b/fp16_1gpu/ \
	--dtype float16 \
	--use_gpt_attention_plugin float16 \
	--world_size 1 \
	--tp_size 1 \
	--pp_size 1 \
	--max_batch_size 64 \
	--max_input_len 2048 \
	--max_output_len 2048 \
	--enable_fp8 \
	--fp8_kv_cache \
	--strongly_typed \
	--n_layer 32 \
	--n_head 32 \
	--n_embd 4096 \
	--inter_size 11008 \
	--vocab_size 32000 \
	--n_positions 4096 \
	--hidden_act silu

Benchmark command:
./cpp/build/benchmarks/gptSessionBenchmark --model llama --engine_dir examples/llama/out/7b/fp16_1gpu/ --batch_size "1" --input_output_len "512, 200"
Error logs:
...
[TensorRT-LLM][ERROR] tensorrt_llm::common::TllmException: [TensorRT-LLM][ERROR] Assertion failed: d == a + length (/app/tensorrt_llm/cpp/tensorrt_llm/plugins/gptAttentionCommon/gp[72/1962]
nCommon.cpp:418)
1       0x7fff5fed512f /opt/tritonserver/backends/tensorrtllm/libnvinfer_plugin_tensorrt_llm.so.9(+0x4512f) [0x7fff5fed512f]
2       0x7fff5ff41846 tensorrt_llm::plugins::GPTAttentionPluginCommon::GPTAttentionPluginCommon(void const*, unsigned long) + 870
3       0x7fff5ff588b3 tensorrt_llm::plugins::GPTAttentionPlugin::GPTAttentionPlugin(void const*, unsigned long) + 19
4       0x7fff5ff58932 tensorrt_llm::plugins::GPTAttentionPluginCreator::deserializePlugin(char const*, void const*, unsigned long) + 50
5       0x7fff1afef8a6 /usr/local/tensorrt/lib/libnvinfer.so.9(+0x10d68a6) [0x7fff1afef8a6]
6       0x7fff1afe766e /usr/local/tensorrt/lib/libnvinfer.so.9(+0x10ce66e) [0x7fff1afe766e]
7       0x7fff1af82217 /usr/local/tensorrt/lib/libnvinfer.so.9(+0x1069217) [0x7fff1af82217]
8       0x7fff1af8019e /usr/local/tensorrt/lib/libnvinfer.so.9(+0x106719e) [0x7fff1af8019e]
9       0x7fff1af97c2b /usr/local/tensorrt/lib/libnvinfer.so.9(+0x107ec2b) [0x7fff1af97c2b]
10      0x7fff1af9ae32 /usr/local/tensorrt/lib/libnvinfer.so.9(+0x1081e32) [0x7fff1af9ae32]
11      0x7fff1af9b20c /usr/local/tensorrt/lib/libnvinfer.so.9(+0x108220c) [0x7fff1af9b20c]
12      0x7fff1afce9b1 /usr/local/tensorrt/lib/libnvinfer.so.9(+0x10b59b1) [0x7fff1afce9b1]
13      0x7fff1afcf777 /usr/local/tensorrt/lib/libnvinfer.so.9(+0x10b6777) [0x7fff1afcf777]
14      0x7fffa8713d22 tensorrt_llm::runtime::TllmRuntime::TllmRuntime(void const*, unsigned long, nvinfer1::ILogger&) + 482
15      0x7fffa86d03fb tensorrt_llm::runtime::GptSession::GptSession(tensorrt_llm::runtime::GptSession::Config const&, tensorrt_llm::runtime::GptModelConfig const&, tensorrt_llm::runtime::W
orldConfig const&, void const*, unsigned long, std::shared_ptr<nvinfer1::ILogger>) + 667
16      0x55555556c275 ./cpp/build/benchmarks/gptSessionBenchmark(+0x18275) [0x55555556c275]
17      0x7fff5fa3ad90 /lib/x86_64-linux-gnu/libc.so.6(+0x29d90) [0x7fff5fa3ad90]
18      0x7fff5fa3ae40 __libc_start_main + 128
19      0x55555556f765 ./cpp/build/benchmarks/gptSessionBenchmark(+0x1b765) [0x55555556f765]

[TensorRT-LLM][ERROR] tensorrt_llm::common::TllmException: [TensorRT-LLM][ERROR] Assertion failed: d == a + length (/app/tensorrt_llm/cpp/tensorrt_llm/plugins/gptAttentionCommon/gptAttentio
nCommon.cpp:418)
1       0x7fff5fed512f /opt/tritonserver/backends/tensorrtllm/libnvinfer_plugin_tensorrt_llm.so.9(+0x4512f) [0x7fff5fed512f]
2       0x7fff5ff41846 tensorrt_llm::plugins::GPTAttentionPluginCommon::GPTAttentionPluginCommon(void const*, unsigned long) + 870
3       0x7fff5ff588b3 tensorrt_llm::plugins::GPTAttentionPlugin::GPTAttentionPlugin(void const*, unsigned long) + 19
4       0x7fff5ff58932 tensorrt_llm::plugins::GPTAttentionPluginCreator::deserializePlugin(char const*, void const*, unsigned long) + 50
5       0x7fff1afef8a6 /usr/local/tensorrt/lib/libnvinfer.so.9(+0x10d68a6) [0x7fff1afef8a6]
6       0x7fff1afe766e /usr/local/tensorrt/lib/libnvinfer.so.9(+0x10ce66e) [0x7fff1afe766e]
7       0x7fff1af82217 /usr/local/tensorrt/lib/libnvinfer.so.9(+0x1069217) [0x7fff1af82217]
8       0x7fff1af8019e /usr/local/tensorrt/lib/libnvinfer.so.9(+0x106719e) [0x7fff1af8019e]
9       0x7fff1af97c2b /usr/local/tensorrt/lib/libnvinfer.so.9(+0x107ec2b) [0x7fff1af97c2b]
10      0x7fff1af9ae32 /usr/local/tensorrt/lib/libnvinfer.so.9(+0x1081e32) [0x7fff1af9ae32]
11      0x7fff1af9b20c /usr/local/tensorrt/lib/libnvinfer.so.9(+0x108220c) [0x7fff1af9b20c]
12      0x7fff1afce9b1 /usr/local/tensorrt/lib/libnvinfer.so.9(+0x10b59b1) [0x7fff1afce9b1]
13      0x7fff1afcf777 /usr/local/tensorrt/lib/libnvinfer.so.9(+0x10b6777) [0x7fff1afcf777]
14      0x7fffa8713d22 tensorrt_llm::runtime::TllmRuntime::TllmRuntime(void const*, unsigned long, nvinfer1::ILogger&) + 482
15      0x7fffa86d03fb tensorrt_llm::runtime::GptSession::GptSession(tensorrt_llm::runtime::GptSession::Config const&, tensorrt_llm::runtime::GptModelConfig const&, tensorrt_llm::runtime::W
orldConfig const&, void const*, unsigned long, std::shared_ptr<nvinfer1::ILogger>) + 667
                                                                                [33/1962]
16      0x55555556c275 ./cpp/build/benchmarks/gptSessionBenchmark(+0x18275) [0x55555556c275]
17      0x7fff5fa3ad90 /lib/x86_64-linux-gnu/libc.so.6(+0x29d90) [0x7fff5fa3ad90]
18      0x7fff5fa3ae40 __libc_start_main + 128
19      0x55555556f765 ./cpp/build/benchmarks/gptSessionBenchmark(+0x1b765) [0x55555556f765]
[28791db46ff1:44226:0:44226] Caught signal 11 (Segmentation fault: address not mapped to object at address (nil))
==== backtrace (tid:  44226) ====
 0 0x0000000000042520 __sigaction()  ???:0
 1 0x00000000010d475f createInferRuntime_INTERNAL()  ???:0
 2 0x000000000107dd42 getInferLibVersion()  ???:0
 3 0x00000000010808ec getInferLibVersion()  ???:0
 4 0x0000000001081e32 getInferLibVersion()  ???:0
 5 0x000000000108220c getInferLibVersion()  ???:0
 6 0x00000000010b59b1 createInferRuntime_INTERNAL()  ???:0
 7 0x00000000010b6777 createInferRuntime_INTERNAL()  ???:0
 8 0x0000000001fc9d22 tensorrt_llm::runtime::TllmRuntime::TllmRuntime()  ???:0
 9 0x0000000001f863fb tensorrt_llm::runtime::GptSession::GptSession()  ???:0
10 0x0000000000018275 main()  ???:0
11 0x0000000000029d90 __libc_init_first()  ???:0
12 0x0000000000029e40 __libc_start_main()  ???:0
13 0x000000000001b765 _start()  ???:0
=================================

=================================                                                                                [12/1962]
[28791db46ff1:44226] *** Process received signal ***
[28791db46ff1:44226] Signal: Segmentation fault (11)
[28791db46ff1:44226] Signal code:  (-6)
[28791db46ff1:44226] Failing at address: 0xacc2
[28791db46ff1:44226] [ 0] /lib/x86_64-linux-gnu/libc.so.6(+0x42520)[0x7fff5fa53520]
[28791db46ff1:44226] [ 1] /usr/local/tensorrt/lib/libnvinfer.so.9(+0x10d475f)[0x7fff1afed75f]
[28791db46ff1:44226] [ 2] /usr/local/tensorrt/lib/libnvinfer.so.9(+0x107dd42)[0x7fff1af96d42]
[28791db46ff1:44226] [ 3] /usr/local/tensorrt/lib/libnvinfer.so.9(+0x10808ec)[0x7fff1af998ec]
[28791db46ff1:44226] [ 4] /usr/local/tensorrt/lib/libnvinfer.so.9(+0x1081e32)[0x7fff1af9ae32]
[28791db46ff1:44226] [ 5] /usr/local/tensorrt/lib/libnvinfer.so.9(+0x108220c)[0x7fff1af9b20c]
[28791db46ff1:44226] [ 6] /usr/local/tensorrt/lib/libnvinfer.so.9(+0x10b59b1)[0x7fff1afce9b1]
[28791db46ff1:44226] [ 7] /usr/local/tensorrt/lib/libnvinfer.so.9(+0x10b6777)[0x7fff1afcf777]
[28791db46ff1:44226] [ 8] /opt/tritonserver/TensorRT-LLM/cpp/build/tensorrt_llm/libtensorrt_llm.so(_ZN12tensorrt_llm7runtime11TllmRuntimeC2EPKvmRN8nvinfer17ILoggerE+0x1e2)[0x7fffa8713d22]
[28791db46ff1:44226] [ 9] /opt/tritonserver/TensorRT-LLM/cpp/build/tensorrt_llm/libtensorrt_llm.so(_ZN12tensorrt_llm7runtime10GptSessionC1ERKNS1_6ConfigERKNS0_14GptModelConfigERKNS0_11WorldConfigEPKvmSt10shared_ptrIN8nvinfer17ILoggerEE+0x29b)[0x7fffa86d03fb]
[28791db46ff1:44226] [10] ./cpp/build/benchmarks/gptSessionBenchmark(+0x18275)[0x55555556c275]
[28791db46ff1:44226] [11] /lib/x86_64-linux-gnu/libc.so.6(+0x29d90)[0x7fff5fa3ad90]
[28791db46ff1:44226] [12] /lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0x80)[0x7fff5fa3ae40]
[28791db46ff1:44226] [13] ./cpp/build/benchmarks/gptSessionBenchmark(+0x1b765)[0x55555556f765]
[28791db46ff1:44226] *** End of error message ***
Segmentation fault (core dumped)

This seems to be a different issue from #656 even it is the same experiment.

From my experiences, it seems only the following combination works

Build engine using trtllm 0.6.1
Triton Server 23.11-trtllm-python-py3 to serve the engine

Yes. The previous version works. This seems to be a new issue in the new 0.7.1 release.

@taozhang9527
Try to recompile TRT_LLM and triton trt_llm backend, replace libtriton_tensorrtllm.so in the /opt/tritonserver/backends/tensorrtllm directory and delete the corresponding libnvinfer_plugin_tensorrt_llm.so*
it works for me~

It is often because the TRT LLM versions of engine and backend are different. By default, 23.12-trtllm-python-py3 installs the v0.7.0 instead of v0.7.1.

@wjj19950828 Which version of the tensorrtllm folder you used for the replacement?
I am using the folder in 23.11-trtllm-python-py to replace the one in 23.12-trtllm-python-py. It has the same error. Here is what I have after the replacement:
root@xxxxx:/opt/tritonserver/backends/tensorrtllm# ll
total 683980
drwxrwxrwx 1 triton-server triton-server       267 Jan  5 18:30 ./
drwxrwxrwx 1 triton-server triton-server        33 Dec 15 20:22 ../
-rw-rw-rw- 1 root          root          599044272 Dec 15 18:31 libnvinfer_plugin_tensorrt_llm.so
lrwxrwxrwx 1 root          root                 33 Nov 21 01:10 libnvinfer_plugin_tensorrt_llm.so.9 -> libnvinfer_plugin_tensorrt_llm.so
lrwxrwxrwx 1 root          root                 33 Nov 21 01:10 libnvinfer_plugin_tensorrt_llm.so.9.1.0 -> libnvinfer_plugin_tensorrt_llm.so
-rwxr-xr-x 1 root          root           31755152 Dec 15 18:31 libth_common.so*
-rw-rw-rw- 1 root          root           69590528 Nov 21 01:10 libtriton_tensorrtllm.so

@byshiue Is there any future plan to fix this? Work-around seems to be temporary solution here, right?

We have discussion about how to support compatibilities between different version, but we couldn't provide timeline now.

@taozhang9527 What settings worked for you?
Do you know if the previous version worked?
Or did you copy the file (from @wjj19950828 suggestion)?
->I don't know where to get that file as I can't find the path, from the other issue you created.

Hi there, I'm facing the same issue and am kinda new to the whole build process. I was also wondering what is the recommended way to verify one's own tensorRT-LLM/triton-inference-serve/tensorrtllm_backend versions? I'm building within a pre-built docker image tensorrt_llm/release:latest and then attempting to serve with nvcr.io/nvidia/tritonserver:23.12-trtllm-python-py3, which seems to be the versions that are on the left column of the frameworks matrix.
Separately I checkout a specific commit with the 0.7.0 version tag and run the build the commands within these docker images to ensure that I'm on v0.7.0 (based on what the framework states is the version for 23.12) but I still get these errors. If it helps, these are the commands I'm running:
docker run --rm -it --ipc=host --ulimit memlock=-1 --ulimit stack=67108864  \
    --gpus=all \
    --volume $HOME/TensorRT-LLM:/code/tensorrt_llm \
    --volume /models:/models \
    --env "CCACHE_DIR=/code/tensorrt_llm/cpp/.ccache" \
    --env "CCACHE_BASEDIR=/code/tensorrt_llm" \
    --workdir /code/tensorrt_llm \
    --hostname ip-172-31-43-170-release \
    --name tensorrt_llm-release-ubuntu \
    --tmpfs /tmp:exec \
    tensorrt_llm/release:latest

# edit this to point to your model path
export HF_LLAMA_MODEL=/models/mymodel
export ENGINE_DIR=/models/trt_engines

# build the engine and put it in /models/trt_engines
python3 examples/llama/build.py \
    --model_dir ${HF_LLAMA_MODEL} \
    --dtype float16 \
    --world_size 4 \
    --tp_size 4 \
    --pp_size 1 \
    --parallel_build \
    --use_gpt_attention_plugin float16 \
    --use_gemm_plugin float16 \
    --remove_input_padding \
    --use_inflight_batching \
    --paged_kv_cache \
    --max_batch_size 8 \
    --output_dir /models/trt_engines

# enter the triton-inference-server docker container
docker run \
  --rm \
  -it \
  --net host \
  --shm-size=2g \
  --ulimit memlock=-1 \
  --ulimit stack=67108864 \
  --gpus all \
  -v ${HOME}/tensorrtllm_backend:/tensorrtllm_backend \
  -v /models:/models \
  nvcr.io/nvidia/tritonserver:23.12-trtllm-python-py3 bash

pip install protobuf sentencepiece

cd /tensorrtllm_backend
cp all_models/inflight_batcher_llm/ llama_ifb -r
export HF_LLAMA_MODEL=/models/mymodel
export ENGINE_DIR=/models/trt_engines

python3 tools/fill_template.py -i llama_ifb/preprocessing/config.pbtxt tokenizer_dir:${HF_LLAMA_MODEL},tokenizer_type:auto,triton_max_batch_size:8,preprocessing_instance_count:1
python3 tools/fill_template.py -i llama_ifb/postprocessing/config.pbtxt tokenizer_dir:${HF_LLAMA_MODEL},tokenizer_type:auto,triton_max_batch_size:8,postprocessing_instance_count:1
python3 tools/fill_template.py -i llama_ifb/tensorrt_llm_bls/config.pbtxt triton_max_batch_size:8,decoupled_mode:False,bls_instance_count:1,accumulate_tokens:False
python3 tools/fill_template.py -i llama_ifb/ensemble/config.pbtxt triton_max_batch_size:8
python3 tools/fill_template.py -i llama_ifb/tensorrt_llm/config.pbtxt triton_max_batch_size:8,decoupled_mode:False,max_beam_width:1,engine_dir:${ENGINE_DIR},max_tokens_in_paged_kv_cache:2560,max_attention_window_size:2560,kv_cache_free_gpu_mem_fraction:0.5,exclude_input_in_output:True,enable_kv_cache_reuse:False,batching_strategy:inflight_batching,max_queue_delay_microseconds:600

# launch, but this line fails.
python3 scripts/launch_triton_server.py --world_size=4 --model_repo=llama_ifb

Hope this helps with reproducing

@wongjingping Could you include the scripts to clone repo, checking out the branch and build docker image to make sure we could reproduce your issue?

Hi @byshiue sorry I realised I made a mistake by not checking out the right tag in the TensorRT-LLM repository and ended up building off the wrong branch version. Checking out v0.7.0 for TensorRT-LLM worked.

hi do u still have further issue or question now? If not, we'll close it soon.

repo: NVIDIA/TensorRT-LLM


text:
Fix various races

Race during target runner start and stats runner log
Race during proxy start and keepalive runner
Race during target/proxy start and keepalive's first register call

@VladimirMarkelov @liangdrew @sasanap @alex-aizman

actually hod on to this review, let me run all tests, sorry forgot to run it

ok, please review, cleared all tests
thanks

repo: NVIDIA/dfcpub


text:
[auto-merge] bot-auto-merge-branch-23.04 to branch-23.06 [skip ci] [bot]

auto-merge triggered by github actions on bot-auto-merge-branch-23.04 to create a PR keeping branch-23.06 up-to-date. If this PR is unable to be merged due to conflicts, it will remain open until manually fix.

SUCCESS - auto-merge

repo: NVIDIA/spark-rapids-jni


text:
Fix out of bound write for get_json_object_multiple_paths

This fixes the code paths for handling out-of-bound write when there are more than one JSON paths in get_json_object_multiple_paths.
A unit test is also added to check for this particular code path.

build

I ran through all of the JSON tests and redid the performance testing I did before. Everything passed as expected, because this is just here for a very odd corner case that is not going to ever be needed in practice.


text:
[submodule-sync] bot-submodule-sync-branch-24.10 to branch-24.10 [skip ci] [bot]

submodule-sync to create a PR keeping thirdparty/cudf up-to-date.
HEAD commit SHA: 4664beb731bffe8481ed9b0932ee8963dbdc160a, cudf commit SHA: https://github.com/rapidsai/cudf/commit/211dbe43aafe9cd16ed9b85a72e67f1fcab65b91
This PR will be auto-merged if test passed. If failed, it will remain open until test pass or manually fix.

HEAD commit SHA: 4664beb731bffe8481ed9b0932ee8963dbdc160a, CUDF commit SHA: https://github.com/rapidsai/cudf/commit/211dbe43aafe9cd16ed9b85a72e67f1fcab65b91
Test passed: True

SUCCESS - auto-merge


text:
[submodule-sync] bot-submodule-sync-branch-22.04 to branch-22.04 [skip ci] [bot]

submodule-sync to create a PR keeping thirdparty/cudf up-to-date.
HEAD commit SHA: 2265ab6f0e7166171ff260797dc312a83e63ef48, cudf commit SHA: https://github.com/rapidsai/cudf/commit/a25a2ec58c60d044672d3761a8029a1ff20242fe
This PR will be auto-merged if test passed. If failed, it will remain open until test pass or manually fix.

HEAD commit SHA: 2265ab6f0e7166171ff260797dc312a83e63ef48, CUDF commit SHA: https://github.com/rapidsai/cudf/commit/a25a2ec58c60d044672d3761a8029a1ff20242fe
Test passed: True

SUCCESS - auto-merge


text:
Add NOTICE

Close: https://github.com/NVIDIA/spark-rapids-tools/issues/58
Signed-off-by: gashen gashen@nvidia.com

Contents look OK to me. I assumed you verified the build properly places the NOTICE-binary in the resulting artifact.

I verified there's META-INF/NOTICE file in the jar file, which has the content as same as NOTICE-binary.
Is that ok?

Contents look OK to me. I assumed you verified the build properly places the NOTICE-binary in the resulting artifact.

I verified there's META-INF/NOTICE file in the jar file, which has the content as same as NOTICE-binary. Is that ok?
This is what is done in rapids-tools repo.
According to Apache instructions,  binary distributions should be accounted for in LICENSE/NOTICE files.

repo: NVIDIA/spark-rapids-tools


text:
[FEA] Split up GpuParquetScan file

In review of adding coalesce parquet reader comment was made it would be nice to split the file up.  We have 3 types of reader so we can split it up by those.

changes in base have already happened, just going to close this and can reopen or open new one if needed

repo: NVIDIA/spark-rapids


text:
[DOC] update instructions/test script for udf_cudf_test.py on databricks

I see the following failure  when running the integration tests in databricks (7.3 or 8.2). I used ./jenkins/databricks/build.sh and ./jenkins/databricks/test.sh. It seems like we are missing an install in the python distribution.
=========================== short test summary info ============================
FAILED ../../src/main/python/udf_cudf_test.py::test_with_column[small data]
FAILED ../../src/main/python/udf_cudf_test.py::test_with_column[large data]
FAILED ../../src/main/python/udf_cudf_test.py::test_sql - py4j.protocol.Py4JJ...
FAILED ../../src/main/python/udf_cudf_test.py::test_select - py4j.protocol.Py...
FAILED ../../src/main/python/udf_cudf_test.py::test_map_in_pandas - py4j.prot...
FAILED ../../src/main/python/udf_cudf_test.py::test_group_apply - py4j.protoc...
FAILED ../../src/main/python/udf_cudf_test.py::test_group_apply_in_pandas - p...
FAILED ../../src/main/python/udf_cudf_test.py::test_group_agg - py4j.protocol...
FAILED ../../src/main/python/udf_cudf_test.py::test_sql_group - py4j.protocol...
FAILED ../../src/main/python/udf_cudf_test.py::test_window - py4j.protocol.Py...
FAILED ../../src/main/python/udf_cudf_test.py::test_cogroup[ALLOW_NON_GPU(GpuFlatMapCoGroupsInPandasExec,PythonUDF)]
============== 11 failed, 10532 deselected, 22 warnings in 48.86s ==============

Stack trace looks similar for all of the above:
21/09/14 16:20:59 WARN PythonWorkerFactory: Assuming that daemon unexpectedly quit, attempting to restart
INFO: Process 13967 found CUDA visible device(s): 0
Traceback (most recent call last):
  File "/home/ubuntu/spark-rapids/dist/target/rapids-4-spark_2.12-21.10.0-SNAPSHOT.jar/rapids/daemon_databricks.py", line 132, in manager
  File "/home/ubuntu/spark-rapids/dist/target/rapids-4-spark_2.12-21.10.0-SNAPSHOT.jar/rapids/worker.py", line 37, in initialize_gpu_mem
    from cudf import rmm
ModuleNotFoundError: No module named 'cudf'
21/09/14 16:20:59 ERROR Executor: Exception in task 5.2 in stage 35.0 (TID 220)
java.net.SocketException: Connection reset
	at java.net.SocketInputStream.read(SocketInputStream.java:210)
	at java.net.SocketInputStream.read(SocketInputStream.java:141)
	at java.net.SocketInputStream.read(SocketInputStream.java:224)
	at java.io.DataInputStream.readInt(DataInputStream.java:387)
	at org.apache.spark.api.python.PythonWorkerFactory.createSocket$1(PythonWorkerFactory.scala:210)
	at org.apache.spark.api.python.PythonWorkerFactory.liftedTree1$1(PythonWorkerFactory.scala:233)
	at org.apache.spark.api.python.PythonWorkerFactory.createThroughDaemon(PythonWorkerFactory.scala:225)
	at org.apache.spark.api.python.PythonWorkerFactory.create(PythonWorkerFactory.scala:119)
	at org.apache.spark.SparkEnv.createPythonWorker(SparkEnv.scala:192)
	at org.apache.spark.api.python.BasePythonRunner.compute(PythonRunner.scala:183)
	at org.apache.spark.sql.execution.python.PandasGroupUtils$.executePython(PandasGroupUtils.scala:44)
	at org.apache.spark.sql.execution.python.rapids.GpuPandasUtils$.executePython(GpuPandasUtils.scala:35)
	at org.apache.spark.sql.rapids.execution.python.GpuFlatMapCoGroupsInPandasExec.$anonfun$doExecute$1(GpuFlatMapCoGroupsInPandasExec.scala:137)
	at org.apache.spark.rdd.ZippedPartitionsRDD2.compute(ZippedPartitionsRDD.scala:101)
	at org.apache.spark.rdd.RDD.computeOrReadCheckpoint(RDD.scala:356)
	at org.apache.spark.rdd.RDD.iterator(RDD.scala:320)
	at org.apache.spark.scheduler.ResultTask.runTask(ResultTask.scala:90)
	at org.apache.spark.scheduler.Task.doRunTask(Task.scala:144)
	at org.apache.spark.scheduler.Task.run(Task.scala:117)
	at org.apache.spark.executor.Executor$TaskRunner.$anonfun$run$9(Executor.scala:655)
	at org.apache.spark.util.Utils$.tryWithSafeFinally(Utils.scala:1581)
	at org.apache.spark.executor.Executor$TaskRunner.run(Executor.scala:658)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
	at java.lang.Thread.run(Thread.java:748)

cudf_udf test needs more setup I think, the databricks nightly handles, we may need to document this better

I have missed a step in my installation, we need to have a conda environment created with cudf installed. The jenkins/databricks/test.sh script could try and detect an environment that isn't configured all the way, but I don't think there's a real bug here we need to be too worried about.
I am trying to find a doc that points at the environment creation.  The doc here https://github.com/NVIDIA/spark-rapids/blob/branch-21.10/docs/additional-functionality/rapids-udfs.md, doesn't point me at what the requirements in the system/pyhton install are. I am probably missing another doc somewhere.

Ah, here it is: https://github.com/NVIDIA/spark-rapids/blob/c0adff3e5149481d6e7f8620c9cb346ae420be1d/integration_tests/README.md#enabling-cudf_udf-tests

updated internal docs for running on databricks as well

the test.sh script only tries to run cudf_udf tests if its expcliilty asked for and now by default so with the documentation I think this is fine. If we hit more issues with this we can open a new issue.

authors: abellina tgravescs


text:
Connect UCX endpoints early during app startup

Signed-off-by: Alessandro Bellina abellina@nvidia.com
The following PR adds a heartbeat (default on, configurable) when the RapidsShuffleManager is enabled, allowing UCX to start connections to peers early, so it can exchange rkeys. Rkeys are opaque objects that UCX uses to encapsulate serialized handles to remote memory for RDMA and also for CUDA. Exchanging rkeys early helps because opening cuda IPC mem handles, and the various RoCE/Infiniband registrations, can take considerable time.
When all peers connect early, we have seen savings of up to 20%. This number is all over the place since we are lazily doing the registration as well. Especially for queries that are sub 1 minute in run length this can help because registration can be up to a few seconds, depending on system conditions.
Prior to this patch UCX connection establishment occurred at shuffle read time. spark.rapids.shuffle.transport.earlyStart can be set to false to go back to the late binding approach.
It is based on a patch from @jlowe. And early rkey unpacking was suggested by @Akshay-Venkatesh.
Closes https://github.com/NVIDIA/spark-rapids/issues/1558

build

Thanks @jlowe