text:
Need simple run test for GANs

We don't keep track of https://github.com/NVIDIAGameWorks/kaolin/tree/master/examples/GANs proper behavior in the CI.
We need to add a quick tests such as in https://github.com/NVIDIAGameWorks/kaolin/blob/master/tests/examples/run/test_classification.sh
And then add it's execution as in:
https://github.com/NVIDIAGameWorks/kaolin/blob/master/.gitlab-ci.yml#L20
(you can also add in .drone.yml if the example doesn't involve a dataset)
The arguments used should test different branching (gpu and cpu if necessary) but make the test run as short as possible (smallest categories of the dataset, fewest numbers of epochs) would check that the example run (we don't verify final performance).

Closing the bug as it is no longer relevant to this repo.

repo: NVIDIAGameWorks/kaolin


text:
Empty floodplain chart boxes

Add N/A where no data appears in floodplain charts for buildings in floodplain, DUs in floodplain, building age, basements, and building adjacency

Actually - let's use "0" for the Building and Dwelling Unit tables since most of the CDs with no floodplain structures already utilize that. Thanks for flagging

Agreed.  The first district I looked at (BK14) is out of the floodplain and I thought those charts were broken.

Closing, this appears to already be implemented: https://communityprofiles.planning.nyc.gov/brooklyn/6#floodplain

source: gharchive/issue

authors: allanz-dcp docmarionum1 hannahkates kerrygathers

repo: NYCPlanning/labs-community-portal

license: mit

license_type: permissive

license_source: bigquery


text:
DSD-892: Adding a11y docs for Typography components

Fixes JIRA ticket DSd-892
This PR does the following:

Adds table of contents and accessibility docs for Heading, List, and Text components.

How has this been tested?
Storybook.
Accessibility concerns or updates

More docs.

Checklist:

[ ] I have updated the Storybook documentation accordingly.
[ ] I have added relevant accessibility documentation for this pull request.
[ ] All new and existing tests passed.

Front End Review:

[ ] View the example in Storybook

Tugboat has finished building the preview for this pull request!
Link:

https://pr952-et1msqyvljb1nrc2vyqf7ywswswkhxno.tugboat.qa

Dashboard:

https://dashboard.tugboat.qa/625705acd9027707d3527e80

Tugboat has finished building the preview for this pull request!
Link:

https://pr952-et1msqyvljb1nrc2vyqf7ywswswkhxno.tugboat.qa

Dashboard:

https://dashboard.tugboat.qa/625705acd9027707d3527e80

Tugboat has finished building the preview for this pull request!
Link:

https://pr952-et1msqyvljb1nrc2vyqf7ywswswkhxno.tugboat.qa

Dashboard:

https://dashboard.tugboat.qa/625705acd9027707d3527e80

source: gharchive/pull-request

repo: NYPL/nypl-design-system

license_source: github-api


text:
Generate Go Clients From Server Implementations

Any server implementation should have a code generator that creates an idiomatic client for it where the end user has only two exported APIs:
type Service interface { ... } // contains all API calls.
func NewService(client *http.Client, url string) Service

I'm a bit more inclined to go the document-driven approach. Create a API spec and then create servers and clients based on the contract.
Also, if we do build a tool that enables this, I think we may want it in it's own repo and have the generation tied to a specific version. Thoughts?

authors: jprobinson marwan-at-work

repo: NYTimes/gizmo


text:
Feature/search results text

Modified "no search results" text

Coverage remained the same at 98.17% when pulling 797872e889f58892f229c3c67805924c3bd2c7f5 on feature/search_results_text into a5c982bac80253e015ea35824e5ec1a74c49df1e on development.

Coverage remained the same at 98.17% when pulling 797872e889f58892f229c3c67805924c3bd2c7f5 on feature/search_results_text into a5c982bac80253e015ea35824e5ec1a74c49df1e on development.

Coverage remained the same at 98.17% when pulling 7c362ac8681992f1c2cd794ac84a04d98f911663 on feature/search_results_text into a5c982bac80253e015ea35824e5ec1a74c49df1e on development.

Coverage remained the same at 98.17% when pulling 7c362ac8681992f1c2cd794ac84a04d98f911663 on feature/search_results_text into a5c982bac80253e015ea35824e5ec1a74c49df1e on development.

authors: coveralls ekate

repo: NYULibraries/findingaids


text:
Current dependency on Google-Mobile-Ads-SDK 7.68.0 break pod installation

The react-native-ad-manager depends on Google-Mobile-Ads-SDK 7.68.0 which depends on GoogleAppMeasurement (~> 7.0) as a dependency that fails during pod install. Also I tried both pod update and pod repo update. Here, I provided some screenshots for reference. Thanks!

I am currently upgrading the SDK on this branch: https://github.com/simpleTechs/react-native-ad-manager, however it does not provide Facebook integration but I made it work with firebase :)

Fixed in this PR: https://github.com/NZME/react-native-ad-manager/pull/35

authors: Ebizontek EyMaddis matejdr

repo: NZME/react-native-ad-manager

license: MIT


text:
[lm-game01] refactoring

This change is

Reviewed 4 of 5 files at r1.
Review status: 4 of 5 files reviewed at latest revision, all discussions resolved, some commit checks failed.

Comments from Reviewable

Reviewed 1 of 5 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.

Comments from Reviewable


text:
🛑 Damien is down

In 99f06f0, Damien (https://damien-doussaud.com/) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Damien is back up in eb2603e after 5 minutes.

repo: Namide/upptime


text:
Subfolders skew Content path

If I put a view in a sub folder, I can't access the /Content directory.
i.e. <script src="~/Content/...

@bluebaroncanada using what view engine? Could you give a short folder structure sample that we could use to reproduce this? Thanks

Going to close this for now because I cannot reproduce it
If you are using the Razor view engine, then you should use @Url.Content("~/......") for content paths and if you are using SSVE then the equivalent is @Path['~/....']
Should this still be an issue for you, please comment and re-open the issue.
Thank you

authors: bluebaroncanada thecodejunkie

repo: NancyFx/Nancy


text:
Kestrel Exception on urlencoded paths when Content Negotiation adds links to responses

Prerequisites

[x] I have written a descriptive issue title
[x] I have verified that I am running the latest version of Nancy
[x] I have verified if the problem exist in both DEBUG and RELEASE mode
[x] I have searched open and closed issues to ensure it has not already been reported

Description
When the path has urlencoded characters in it and content negotiation attempts to add link headers to the response. It does so in a manner that causes Kestrel to throw
System.InvalidOperationException: Invalid non-ASCII or control character in header: 0x00E5
   at Microsoft.AspNetCore.Server.Kestrel.Internal.Http.FrameHeaders.ThrowInvalidHeaderCharacter(Char ch)
   at Microsoft.AspNetCore.Server.Kestrel.Internal.Http.FrameHeaders.ValidateHeaderCharacters(String headerCharacters)
   at Microsoft.AspNetCore.Server.Kestrel.Internal.Http.FrameHeaders.ValidateHeaderCharacters(StringValues headerValues)
   at Microsoft.AspNetCore.Server.Kestrel.Internal.Http.FrameResponseHeaders.SetValueFast(String key, StringValues value)
   at Nancy.Owin.NancyMiddleware.RequestComplete(NancyContext context, IDictionary`2 environment, Func`2 performPassThrough, Func`2 next)

This happens because the characters that were encoded in the original url are passed unencoded to the response header, violating HTTP spec.
Steps to Reproduce

Setup a plain Nancy project with Kestrel as the host
Create a route Get("/{slug}", _ => new { Test = "Hello World"});
curl -v http://localhost:5000/george-%C3%A5

System Configuration

Nancy version: 2.0.0-clinteastwood (also present in barney, under slightly different trigger)
Nancy host

[ ] ASP.NET
[ ] OWIN
[ ] Self-Hosted
[x] Other: Kestrel

Other Nancy packages and versions:
Environment (Operating system, version and so on): OSX
.NET Framework version: 1.0.0-preview2-1-003177
Additional information:

As a workaround, you can return Response.AsJson() which bypasses the code to add links
e.g. Get("/foo/{slug}", _ => Response.AsJson(new { Test = "Hello World"}));
See https://github.com/NancyFx/Nancy/blob/master/src/Nancy/Responses/Negotiation/DefaultResponseNegotiator.cs#L42 for the bypass
By encoding a character that does not cause Kestrel to crash, you can see how it ends up unencoded in the response
$ curl -v http://localhost:5000/george-%3B
> GET /george-%3B HTTP/1.1
> Host: localhost:5000
> User-Agent: Mozilla/5.0 (compatible; MSIE 9.0; Windows NT 6.1; Trident/5.0)
> Accept: */*
> Referer:
>
< HTTP/1.1 200 OK
< Date: Mon, 30 Jan 2017 18:56:46 GMT
< Content-Type: application/json; charset=utf-8
< Server: Kestrel
< Transfer-Encoding: chunked
< Vary: Accept
< Link: </george-;.xml>; rel="alternate"; type="application/xml"
<
{"Test":"Hello World"}

Closed with #2903

authors: csainty khellang


text:
jsb_cocos2dx_pluginx_auto.hpp not found in AppDelegate

I'm trying to run a simple cocos2djs project but when I try to test on the simulator the build fails with this error:

I'm using the latest iOS SDK version (9.2) running in the MacOS 10.11.
I've already prebuilt the libraries, see below the result of rapidgame show command.
Rapidgame lives here: /Users/gzomer/.rapidgame
Latest static libs and headers: /Users/gzomer/.rapidgame/3.9
Static libs and headers have been built: YES

Have I missed any step?

I am getting the same error.
I am using RapidGame 1.0.3, Xcode 7.3 and MacOS 10.11.

Sorry guys. The JS templates are broken. If you can figure out how to get them working then please submit a pull request. Otherwise, I will probably remove them from Rapidgame.

authors: JamesBatesUK NatWeiss gzomer

repo: NatWeiss/RapidGame


text:
chore: promote jx3-spring-boot-test to version 0.0.1

chore: promote jx3-spring-boot-test to version 0.0.1
this commit will trigger a pipeline to generate the actual kubernetes resources to perform the promotion which will create a second commit on this Pull Request before it can merge

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Nathan-Smith
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [Nathan-Smith]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Nathan-Smith: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

verify
1b769da9971f23eab7e8e0d3d3b337975c257bae
link
/test verify

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

/retest

@Nathan-Smith: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

verify
556c145b83182639840a5fa3d03b649561dc997c
link
/test verify

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

@Nathan-Smith: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

verify
556c145b83182639840a5fa3d03b649561dc997c
link
/test verify

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.


text:
Update Github Repo 2019/07/01

push recent changes to github, with the following changes:
maitenance: removed usage of deprecated boost endian macros
mainenance: add more documentation on how to set up ni-media
bugfix: wav files with wavFormatExtensible format could not be read
bugfix: use a manually managed NSAutoreleasePool instead of @autoreleasepool in order to avoid memory leaks if exceptions are thrown

Codecov Report

Merging #30 into master will decrease coverage by 0.27%.
The diff coverage is 16.66%.

@@            Coverage Diff             @@
##           master      #30      +/-   ##
==========================================
- Coverage   86.65%   86.37%   -0.28%
==========================================
  Files          96       96
  Lines        1828     1835       +7
==========================================
+ Hits         1584     1585       +1
- Misses        244      250       +6

Impacted Files
Coverage Δ

audiostream/src/ni/media/audio/wav/wav_source.h
51.08% <16.66%> (-3.04%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 83f3d18...7d7bd58. Read the comment docs.

authors: codecov-io marcrambo

repo: NativeInstruments/ni-media


text:
fix traversal bug ignoring some directories; fix path bug on windows

This PR addresses the following issues with the JavaScript Parser tool needed to feed the static binding generator:

JavaScript input files paths contain whitespaces when read from the jsfilesparameter and node fails to open them as is. I was able to reproduce it on Windows OS
Some modules contained in a Nativescript project with an existing, but empty "nativescript" key in project json weren't traversed properly due to change in logic

Removed old invalid ast-parser tests
Refactored build.gradle for static-binding-generator to make it testable
Refactored test execution structure to conform to using gradle task
Added parser traversal test
@NativeScript/android-runtime

👍

repo: NativeScript/android-runtime


text:
broken when used inside of a  (iOS Only)

Environment
Provide version numbers for the following components (information can be retrieved by running tns info in your project folder or by inspecting the package.json of the project):
√ Getting NativeScript components versions information...
√ Component nativescript has 6.5.0 version and is up to date.
√ Component tns-core-modules has 6.5.1 version and is up to date.
√ Component tns-android has 6.5.0 version and is up to date.
√ Component tns-ios has 6.5.0 version and is up to date.
"nativescript-angular": "^8.21.0",
Describe the bug
When using  in iOS inside of a  route, I am running into an unfamiliar error:
CONSOLE ERROR [native code]: ERROR TypeError: undefined is not an object (evaluating 'this._control.addObserverForKeyPathOptionsContext')
The strange things I found:

If I remove all the  from within the first TabContentItem's view, it renders fine without errors.
If I put my first Tab's TabContentItem's view outside of the  layout and display it on its own, the view renders fine without errors.

Sample project
<Tabs (selectedIndexChanged)="onSelectedIndexChanged($event)">
  <TabStrip>
    <TabStripItem>

    </TabStripItem>
    <TabStripItem>

    </TabStripItem>
  </TabStrip>
  <TabContentItem>
    <StackLayout width="100%">
      <FlexboxLayout flexDirecton="row" justifyContent="space-between" class="m-x-20 m-t-10">
        <StackLayout width="100%" orientation="horizontal" color="gray">

        </StackLayout>
        <StackLayout orientation="vertical" color="gray" minWidth="70" minHeight="50" (tap)="toggleSaved()">

        </StackLayout>
      </FlexboxLayout>
      <ScrollView>
        <StackLayout orientation="vertical" class="m-x-20">

          ...
          <Button class="-primary" text="MORE DETAIL" (tap)="moreDetail()"></Button>
          <Button class="-alternate" text="Zoom to Map" (tap)="zoomToMap()"></Button>
          <Button class="-alternate" text="Get Directions" (tap)="getDirections()"></Button>
        </StackLayout>
      </ScrollView>
    </StackLayout>
  </TabContentItem>
  <TabContentItem>
    <StackLayout>

    </StackLayout>
  </TabContentItem>
</Tabs>

Partial stack trace: https://pastebin.com/08UEDqs1

Possibly related to https://github.com/NativeScript/nativescript-angular/issues/2001

repo: NativeScript/nativescript-angular


text:
Navigate with ClearHistory  error after making swipe in the second page

In case you use  RouterExtensions to navigate with clearHistory and make swipe from left to right in the second page, after return to the main page, only white screen will be shown. I am attaching sample project where this issue has been reproduced - https://github.com/tsonevn/NGNavClearHistory.git .
Possible workaround has been given in StackOverflow.
nativescript-angular: 0.3.0
tns-core-modules:2.2.0

Is there any new on this?

Looks like a duplicate of NativeScript/NativeScript#2836. The fix will go live with tns-core-modules@2.4.0.

authors: artonio hdeshev tsonevn


text:
feat: refactor shared structure

The Problem
Imports for Web or Mobile specific files cause errors in IDEs and build time.
Example:

You have service that has platform specific implementations for wen and mobile in service.tns.ts and service.web.ts.
The service is imported in another module with import { xxx } from ".../service"
IDE (ex. VsCode) will (rightfully) complain that it cannot find the service module

The Solution
Configure typescript to resolve platform specific files (with .tns.ts/.web.ts extension) with priority over shared files (just *.ts). The configuration is done by setting paths in tsconfig. Here is how the tsconfig.tns.json (used for mobile) looks:
"compilerOptions": {
   //...
   "paths": {
     "@src/*": [
       "src/*.android.ts",
       "src/*.ios.ts",
       "src/*.tns.ts",
       "src/*"
     ]
   }
 }

Important Remarks

The common config contains mapping for both web and mobile so that paths can work and be resolved inside IDE (ex. VS Code) while developing.
Platform specific configs contain mapping only for the platform (see example above).
We map @src/ to the src folder of the project. Other symbols be used - like @proj/. However, don’t use “~/" - this leads to confusing build-time errors and suffering. The reason: “~/" is reserved and is already used as an alias in webpack configuration it is needed for CSS files resolution.
The “paths” mapping only work for non-relative imports. This means that all imports that should be resolved to a plat-specific file should be defined with as non-relative paths starting with @src. Our suggestion is to adopt a convention to use @src for all project files imports and enforce it with a tslint rule.
Sometimes when building for NativeScript there is a problem with AOT compiler picking up “*.ts” extension that are intended for web-only. It then fails with a component/module not used error. To solve that we explicitly specify files in tns and web ts-configurations. These are the entry points to TS compilations. All lazy modules should be specified in “files” list in tsconfigs, as they are not directly imported in other TS files.

Tasks

[x] Modify ng-new schematic to create apps using the ts-configuration described above.
[x] Create tslint rule that enforces non-relative imports. It should have an auto-fix option that replaces relative imports with the @src scheme
[x] There are a couple of places in schematics that we need to resolve imports. Resolve them using the ts-configurations so that they can work with @src and basePath mappings
[x] Make sure all schematics work and produce code with @src imports (instead of relative). We can just reuse the tslint rule. We can execute the rule with --fix to make it fix relative imports that we have generated

[x] ng-new
[x] add-ns
[x] shared
[x] generate component
[x] generate module
[x] master-detail template
[x] migrate-module
[x] migrate-component

[ ] Update the documentation

Fixes #172

test

repo: NativeScript/nativescript-schematics


text:
Typographical error

Dear friend we want to specify that this repo is {N} Playground related.
Please use it to provide feedback or report an issue related to {N} Playground only.
If your issue is related to {N} itself please report it to the {N} repo
or search for solution in Stack Overflow.
All issues which are not related to {N} Playground will be closed.
We appreciate your feedback! While we are doing all we can to take care of every
issue, sometimes we get overwhelmed. Because of that, we will consider issues
that are not constructive or problems that cannot be reproduced "dead".
Additionally, we will treat feature requests or bug reports with unanswered
questions regarding the behavior/reproduction for more than 20 days "dead". All
"dead" issues will get closed.
Please, provide the details below:
Did you search for the problem in other open issues in this repo?
N/A
Tell us about the problem
Please, ensure your title is less than 63 characters long and starts with a capital
letter.
Typo: Word misspelled.
Did you try it outside of {N} Playground?

Yes - it has the same behavior as in the playground
Yes - but the behavior is different (give more information)
No

No
Which browser are you using?

Chrome
Safari
Mozilla
IE

Chrome
Are there any errors/warnings logged in your browser console?
N/A
Which platform(s) does your issue occur on?

iOS
Android
Both

Neither: On the web.
Are there any entries logged in the Device Logs tab?
N/A
Please provide the following information shown in devices tab in the playground:

Model
OS version
Preview app version
Runtime version

N/A
Please tell us how to recreate the issue with as much detail as possible.
The best approach would be to get your code running in the {N} Playground and share the link with us, along with any additional details or steps to reproduce needed for examining the issue there.
The word "replaces" should be "replace", since it is imperative. This is in Lesson 2, Step 4, Action a.
(Is there a simpler way to propose editorial corrections and improvements in the playground?)

Adding a PR is the better option. We will review the PRs.
Thanks for the feedback.
I will close this issue because you have added several PRs.

repo: NativeScript/playground-feedback


text:
顶部点击栏功能

社交媒体和论坛的需求

顶部栏颜色变化

authors: Nbuyu sxecd

repo: Nbuyu/marketsystem


text:
Training and testing steps

Can you provide the steps for training and testing, please?

Hi,
To run the code, the main.py script must be executed, this file reads the information from ./configs/training.cfg that contains instructions for training or testing. Specifically, the configuration file is divided into three sections: [Commons], [Training], and [Testing].

In [Commons] there are the keys train_model and test_model, which must be assigned values True or False, depending on whether you want to train or test.
In [Training], the most important keys are dataset_name, split_img, fixed_size_imgs and fine_tune.

The key dataset_name indicates the name of the folder where the images are located (within the data folder). The training dataset of the original paper is the Anime Sketch Colorization Pair, so the folder must be 'anime_sketch_colorization_pair'.
The split_img key indicates whether the images in the dataset should be split. This key exists because each image of the original training dataset (for the Main Model) is a pair of sketch and colored sketch.
The key fixed_size_imgs must be True if all images have the same size, and this is the case for the training dataset for the Main Model. On the other hand, the images to train the Fine-Tune Model have different sizes, so it should be left as False, this adds padding to make square images.
The fine_tune key indicates the type of architecture the network will have. Set the value to False to train the Main Model (from the original paper), and set the value to True to train the Fine-Tune Model (using the modifications I added). As a reminder, the Main Model uses one dataset and the Fine-Tune Model uses another.

In [Testing] there are the same keys, which indicate the same thing, but applied to the testing context.

To make the execution easier, I updated the values in training.cfg to train the Main Model. And also added an Execution section in the README.

Thank you so much for the clarification!
So, are you suggesting that the main model was trained on the Anime Sketch Colorization Pair dataset,
and the One Punch Man Manga Colorization dataset was utilized for training the fine-tuned model?

Yes, that's right.
The main model is the same model proposed by the original paper, and was trained on the Anime Sketch Colorization Pair dataset.
Once that model was trained, I wanted to improve it or adapt it to other images, so I created the One Punch Man Manga Colorization dataset and trained the main model with these new images (using the model weights from the first training). This new model I called 'fine-tuned model', and has some small modifications in the architecture, that I explain in the README. So, to clarify, in order to obtain the results of the fine-tuned model it is necessary to train the main model first.

Hello, first of all this model training need to use the official data set in the JSON file? Second, I added some code to save the test-generated result image after coloring. But I trained a lot of epoch, and the test results pictures for each epoch were not colored correctly. Is it because I added the wrong code? If I want to see what the finished image looks like, how do I change the code? Looking forward to your reply！

Yes, that's right. The main model is the same model proposed by the original paper, and was trained on the Anime Sketch Colorization Pair dataset.
Once that model was trained, I wanted to improve it or adapt it to other images, so I created the One Punch Man Manga Colorization dataset and trained the main model with these new images (using the model weights from the first training). This new model I called 'fine-tuned model', and has some small modifications in the architecture, that I explain in the README. So, to clarify, in order to obtain the results of the fine-tuned model it is necessary to train the main model first.

Apologies for the inconvenience. I am inquiring about the One Punch Man Manga Colorization dataset you shared via the Google link. When I attempt to download it, the size shows as over 4GB, but I encounter a failure during the extraction process. I've noticed that a single image in the test collection is an unusually large 127GB, which leads me to wonder if there has been an error? Or is this an expected size for the image?

Hello, first of all this model training need to use the official data set in the JSON file? Second, I added some code to save the test-generated result image after coloring. But I trained a lot of epoch, and the test results pictures for each epoch were not colored correctly. Is it because I added the wrong code? If I want to see what the finished image looks like, how do I change the code? Looking forward to your reply！

Hi @sjdfhw ,
For the first point, from the official dataset (Anime Sketch Colorization Pair) the images from the 'train' and 'val' folders are used, the JSON files in the 'cologram' folder are not used.
Regarding the second point, I assume that you are saving the images generated directly by the model, specifically, the out_img = net.colorization_network(...) variable in ./training/testing.py. However, the images generated by the model are normalized, this is because to better train the model the training images are normalized, which is why the inverse transformation must be performed to obtain the real images. This transformation is already in the code from the testing file, in the line inv_out_img = INVERSE_NORMALIZE(out_img), the inv_out_img variable has the finished images.

Yes, that's right. The main model is the same model proposed by the original paper, and was trained on the Anime Sketch Colorization Pair dataset.
Once that model was trained, I wanted to improve it or adapt it to other images, so I created the One Punch Man Manga Colorization dataset and trained the main model with these new images (using the model weights from the first training). This new model I called 'fine-tuned model', and has some small modifications in the architecture, that I explain in the README. So, to clarify, in order to obtain the results of the fine-tuned model it is necessary to train the main model first.

Apologies for the inconvenience. I am inquiring about the One Punch Man Manga Colorization dataset you shared via the Google link. When I attempt to download it, the size shows as over 4GB, but I encounter a failure during the extraction process. I've noticed that a single image in the test collection is an unusually large 127GB, which leads me to wonder if there has been an error? Or is this an expected size for the image?

@jamie212 I just downloaded the file from the same link, and I had no problems during the extraction process (it takes about 40 seconds for me). The specific size of the subfolders is 3.3 GB for train, 619.3 MB for test and 290.4 MB for val.
I don't know what the problem could be, maybe the extraction method? I use WinRAR to extract the file. If the problem continues, I could create another file with the images to see if that fixes it.

你好，首先这个模型训练需要用到JSON文件中的官方数据集吗？其次，我添加了一些代码来保存着色后测试生成的结果图像。但是我训练了很多 epoch，每个 epoch 的测试结果图片都没有正确着色。是因为我加错了代码吗？如果我想查看完成的图像是什么样子的，如何更改代码？期待您的回复！

嗨，对于第一点，来自官方数据集（Anime Sketch Colorization Pair）使用了“train”和“val”文件夹中的图像，不使用_“__cologram”_文件夹中的JSON文件。
关于第二点，我假设您正在保存模型直接生成的图像，特别是 中的变量。但是，模型生成的图像是归一化的，这是因为为了更好地训练模型，训练图像是归一化的，这就是为什么必须进行逆变换才能获得真实图像的原因。此转换已在测试文件的代码中，在行中，_inv_out_img_变量具有完成的图像。out_img = net.colorization_network(...)``./training/testing.py``inv_out_img = INVERSE_NORMALIZE(out_img)

Thank you very much, I have got the result of the test picture, “inv_color_sketch” can perfectly restore the reference picture, but “inv_out_img” generated only shape information, no color information. Second, I found that the loss of information during the training model has been particularly large, there is no downward trend, want to know how to solve? The server terminal displays the following information:
Start: 2023-11-06 09:11:17
Running epoch...
================================
2023-11-06 09:15:39 | Epoch 67
rec_loss: 197.004
adv_loss: 23766.821
total_loss: 23963.825
--- 261 seconds total ---

VALIDATION

Running validation...
WARNING: default feature extractor (InceptionNet V2) is used.
WARNING: default feature extractor (InceptionNet V2) is used.
Looking forward to your reply！

Hello, first of all this model training need to use the official data set in the JSON file? Second, I added some code to save the test-generated result image after coloring. But I trained a lot of epoch, and the test results pictures for each epoch were not colored correctly. Is it because I added the wrong code? If I want to see what the finished image looks like, how do I change the code? Looking forward to your reply！

Hi @sjdfhw , For the first point, from the official dataset (Anime Sketch Colorization Pair) the images from the 'train' and 'val' folders are used, the JSON files in the 'cologram' folder are not used.
Regarding the second point, I assume that you are saving the images generated directly by the model, specifically, the out_img = net.colorization_network(...) variable in ./training/testing.py. However, the images generated by the model are normalized, this is because to better train the model the training images are normalized, which is why the inverse transformation must be performed to obtain the real images. This transformation is already in the code from the testing file, in the line inv_out_img = INVERSE_NORMALIZE(out_img), the inv_out_img variable has the finished images.

Thank you very much, I have got the result of the test picture, “inv_color_sketch” can perfectly restore the reference picture, but “inv_out_img” generated only shape information, no color information. Second, I found that the loss of information during the training model has been particularly large, there is no downward trend, want to know how to solve? The server terminal displays the following information:
Start: 2023-11-06 09:11:17
Running epoch...
================================
2023-11-06 09:15:39 | Epoch 67
================================
--- 261 seconds total ---
rec_loss: 197.004
adv_loss: 23766.821
total_loss: 23963.825

VALIDATION

Running validation...
WARNING: default feature extractor (InceptionNet V2) is used.
WARNING: default feature extractor (InceptionNet V2) is used.
Looking forward to your reply！

Hello, first of all this model training need to use the official data set in the JSON file? Second, I added some code to save the test-generated result image after coloring. But I trained a lot of epoch, and the test results pictures for each epoch were not colored correctly. Is it because I added the wrong code? If I want to see what the finished image looks like, how do I change the code? Looking forward to your reply！

Hi @sjdfhw , For the first point, from the official dataset (Anime Sketch Colorization Pair) the images from the 'train' and 'val' folders are used, the JSON files in the 'cologram' folder are not used.
Regarding the second point, I assume that you are saving the images generated directly by the model, specifically, the out_img = net.colorization_network(...) variable in ./training/testing.py. However, the images generated by the model are normalized, this is because to better train the model the training images are normalized, which is why the inverse transformation must be performed to obtain the real images. This transformation is already in the code from the testing file, in the line inv_out_img = INVERSE_NORMALIZE(out_img), the inv_out_img variable has the finished images.

@NcolasDran
Thank you very much, I have got the result of the test picture, “inv_color_sketch” can perfectly restore the reference picture, but “inv_out_img” generated only shape information, no color information. Second, I found that the loss of information during the training model has been particularly large, there is no downward trend, want to know how to solve? The server terminal displays the following information:
2023-11-06 09:11:17 | Epoch 66
PSNR: 6.816
SSIM: 0.434
FID: 359.971
--- 703 seconds total ---
Creating checkpoint...
Checkpoint created in 'data/checkpoints'

Epoch 67

Start: 2023-11-06 09:11:17
Running epoch...
================================
2023-11-06 09:15:39 | Epoch 67
rec_loss: 197.004
adv_loss: 23766.821
total_loss: 23963.825
--- 261 seconds total ---

VALIDATION

Running validation...
WARNING: default feature extractor (InceptionNet V2) is used.
WARNING: default feature extractor (InceptionNet V2) is used.
Looking forward to your reply！

@NcolasDran Thank you very much, I have got the result of the test picture, “inv_color_sketch” can perfectly restore the reference picture, but “inv_out_img” generated only shape information, no color information. Second, I found that the loss of information during the training model has been particularly large, there is no downward trend, want to know how to solve? The server terminal displays the following information:

'inv_color_sketch' is the ground-truth image and 'inv_out_img' is the predicted image, and the prediction should be as close as possible to the ground-truth. If the generated prediction only show the shape information and the training loss value is high, then there is probably an error in the training. I think you may have different values in ./configs/training.cfg, please check the configuration as indicated in the Execution section in the README.

Regarding the evaluation phases (validation and testing), the WARNING messages displayed on the terminal come from the PIQ library, so there is nothing I can do unfortunately.
But I also realized that I had a mistake in the code, the validation phase should only be performed with the 'opm_colorization_dataset'. The 'anime_sketch_colorization_pair' dataset doesn't have validation phase because it only has 'train' and 'val' images, and the 'val' images are used for the testing phase (as done in the original paper). I apologize for this error and I have already updated the code with the changes.
So please download the new changes to have the updated version @sjdfhw @jamie212 .

authors: NcolasDran jamie212 sjdfhw


text:
(? - 23w31a) Text field

This texture file was added in 23w32a, so I presume this was a hardcoded, generated texture before this point.

repo: NeRdTheNed/MC-TextureGen

license: Unlicense


text:
Add Siafunds

The time has come to start thinking about how to add siafunds to consensus.
I have some ideas but a lot of them are inefficient.

The one I like the most right now is to have siafunds that mirror normal siacoins. Instead of being finitely divisible though they're just finite at 10,000. There's a global tracker that counts how many siacoins per siafund have been given out period.
Each siafund will have a number indicating how many coins that siafund had most recently received. When someone wants to do a cash out, they just issue a spend, and they'll get an output worth (global number of coins per siafund - most recent cashout value) * number of siafunds. Then the number gets updated so that it's equal to the global number of coins.
The coin output which gets created can't be spent for X blocks, where is is the number of blocks that miner subsidies and storage proofs aren't allowed to be spent (likely 108).
We should be able to fit this model into the standard way of doing diffs and state hashing that we currently have. Either the siafund thing exists or it doesn't, and when you cash out you consume the existing fund and it gets replaced with a new fund. Sending funds will move around who owns the funds.

repo: NebulousLabs/Sia


text:
Smarter SetAllowance + Auto-renew

SetAllowance will now only form contracts as needed, to make up the difference between the current number of contracts and the desired number.
This new scheme may result in "heterogenous" contracts, i.e. a set of contracts ending at different heights.
Contracts are renewed as soon as the blockheight enters their "renew window." The amount of funds allocated per contract is calculated such that each renewed contract can support the same number of sectors.
To prevent slow rescans, contracts are only checked for renewal when cs.Synced() == true.

To summarize discussion that happened offline:
The renter should be able to give users access to a larger allowance immediately, which requires creating new contracts if a larger allowance is specified. This should of course be accompanied by a test.
There was also some discussion about what should happen if the renter reduces the period of the contract, such that the new renew point is sooner than the previous renew point. Because we want to make sure that contracts always end at the same height, the best thing to do is probably to renew immediately, just the same as we would with a bigger allowance. This includes if the allowance has stayed the same or decreased.

I think we should consider restricting the /renter/allowance API call to a single settable value: the number of bytes the user wants to store. (The number of funds is also reasonable, but what if the value of the siacoin changes? Users care about bytes, not coins.)
The other allowance parameters are extraneous. Hosts certainly doesn't need to be settable; it should just be the number of pieces in the default erasure coding. Most users won't care about Period either, and certainly not RenewWindow.
To complement this, we would add form/renew endpoints to the renter to allow for manual contract management.

That creates a really huge gap on the customization spectrum. Either you you are choosing the number of bytes, or you are manually managing contracts. That's definitely too much of a gap.
When you are forming contracts based on a byte count, you are glossing over significant facts, such as how much downloading might be expected from the contract, volatility in the price of storage, volatility in the price of the siacoin, and the fact that you will lose a certain number of hosts each renew cycle.
I definitely don't want to see the 'pick a number of bytes' abstraction in the API.

A lack of a bytes abstraction in the API will be a hindrance to third party devs. I'm worried that this will offload the abstraction to the majority of applications built on top of our platform. I'm also worried that this bytes abstraction is complex enough to be difficult or bothersome to write without our domain specific knowledge.
With that said the bytes abstraction requires a lot of user interaction. What happens if the price of storage increased 2x? Certainly the user would want to know about that and have a chance to stop the contracts from renewing. Then again I suppose that is only necessary for applications that let the user interact directly with Sia. I imagine the majority of applications that could be built on Sia would only use Sia as a backend, and would not expose these details to the user and would instead consider the 2x increase in price as a cost of business.
So for the renter plugin in the GUI the bytes abstraction is necessary, whether in the API or the GUI. What other plugins or applications might want this abstraction?

pmknutsen's GNOME shell Sia extension and similar applications, for example a Sia FUSE extension.
Siaboxes (NAS with Sia support built in) might want this abstraction if they want to provide renting abilities to the user. Although I imagine most Siaboxes would be primarily used for hosting.

All other use cases I can think of would not need the bytes abstraction, as they would presumably store multiple user's files in the same file contracts.

I think I'm with David on this one. If you want to use bytes instead of coins, then you really need three args: bytes stored, bytes uploaded, and bytes downloaded.
It shouldn't be terribly difficult for API consumers to calculate an allowance if they know the average host settings, which we plan to make accessible.

Actually, another thought occurred to me, more in favor of bytes:
Internally, SetAllowance uses allowance.Funds and a sampling of hosts to determine how much money to allocate to each host. Currently, it do so by first calculating allowance.Funds / (averageSectorPrice * allowance.Hosts), which yields the number of sectors that the allowance can support. It then forms contracts with the hosts, multiplying numSectorsby the storage price for that host. But this leaves upload/download price entirely out of the picture! In order to properly account for them,SetAllowance` would have to know how many uploads/downloads the allowance can support -- but also what fraction of the allowance should be spent on uploads and downloads. How do we determine this? Wouldn't the user need to supply these values as well?

The new approach is to atomically replace the contract set only when all contracts have been formed/renewed.
This has the disadvantage that quitting siad mid-SetAllowance may result in loss of contracts. However, I think this is the better of the two naive implementations; the old implementation deleted the old contracts immediately, which is much more surprising to the user.
Later, if necessary, we can add support for resuming SetAllowance across sessions. But given that it should only take a minute or two, and the fact that no coins are at risk (they are "frozen" for the contract duration, but not lost) this feels like a low priority.
It would also be quite easy to parallelize the RPCs.
I also encountered a bug(?) where the host would reject renewals with the same WindowStart. These renewals will occur if the user changes the allowance funds, but not the period. I could have subverted this by always bumping the WindowStart by 1, but this seemed more correct.

Metrics reporting could use some improvements. Currently, ContractsSpending will contain the sum of c.contracts. This may not give a correct indication of how many funds are locked up in contracts.

I'm very strongly in favor of keeping it as a monetary allowance. Things like price changes, download behavior, and upload behavior are too difficult to predict. We don't want the API to be doing that level of management for the user. In the UI it makes sense to me to have this really blunt tool, but if you are developing on the API you need to have an understanding that creating contracts, uploading files, downloading files, and keeping storage around for a long time all incur different costs. Abstracting that away is taking too much power away from our developers and slamming them into a single paradigm that assumes a single usage pattern.
The whole point of supporting third party development is to give the ecosystem a way to cater to usage patterns and use cases that we don't have the resources to cater to directly.
If you are a GUI user, I don't want you to have to learn all the things about contracts and upload costs and whatnot, we want the least friction possible between hearing about Sia and performing your first upload. If you are an API developer, I'm assuming that you are building for some use case which is poorly covered by the GUI, which means you probably have different requirements and patterns. I want our API developers to have a good understanding of the mechanics behind setting an allowance, spending money to upload and storage files, spending money to renew, and spending money to download files.

Switching out the set of contracts atomically seems good enough. It's not ideal, ideally you'd be able to resume between sessions, but we can add that later as things evolve.

People who want precise control shouldn't be using SetAllowance anyway, since it doesn't let you pick your own hosts.
Perhaps instead of packaging everything into one super-smart SetAllowance route, we could split the functionality across multiple calls, and let the user decide how much "smartness" they want to rely on. e.g.:

Route
Params
Description

GET /renter/contracts

List contracts

GET /renter/contracts/:id

View contract info

POST /renter/contracts/:id
autorenew
Toggle auto-renew (?)

POST /renter/contracts/form
host, funds, endHeight
Form a contract

POST /renter/contracts/renew
id, funds, endHeight
Renew a contract

GET /renter/hosts
n, sort
List hosts

Given these routes, you could emulate SetAllowance via:

GET /renter/hosts?n=24&sort=price
Calculate how much to spend with each host
POST /renter/contracts/form (for each host)
POST /renter/contracts/:id?autorenew=true (for each contract)

I like this in principle because it is less "magic" and more "do one thing well," without sacrificing too much in the way of usability. The autorenew bit is a little ugly, but besides that the routes are all pretty straightforward.
The downside is that we offload some work to the caller. For example, step 2 requires them to know which host fields to use when calculating cost, and they have to remember to use big ints. But the larger problem is what to do when contract formation fails. You need to pick new hosts and try again, and you may need some state to persist across sessions. On the other hand, the UI might be better suited to handle these sorts of errors anyway. If initial formation fails, you can display a dialogue explaining what happened and give the user options for what to do next: Try to form contracts with more expensive hosts? Abort and try again later? Decrease allowance? This flexibility would be difficult to implement if everything were handled on the backend.
In general, when we design this stuff it's probably a good idea to bear in the mind the distinction between Simple and Easy.

I think that the difference between picking the amount of money you are spending and picking your own hosts is pretty huge. There are lots of reasons to have the renter do the host picking - the renter has a far better idea of which hosts are reliable, etc. It's something I can see being exposed later, but in the meantime I'd rather have filters that get passed in to block certain hosts, and maybe block certain prices or speeds.
And then we can start talking about optimizations like giving more money to certain hosts because we know that we will download from them more frequently. That's an optimization you'd expect from the renter, not from the person utilizing the API.
I also don't think it makes sense to have the developer managing renew schedules. As we've seen from implementing it ourselves, it's a pretty difficult thing to get right.
No part of managing files on Sia is simple. Getting a file safely onto Sia means making connections to multiple different hosts and giving it to them. Doing it cheaply means applying erasure coding and distinguishing between the hosts based on price, reliability, and utility. Getting scalability means pre-paying and utilizing file contract revisions. If you are in the UK, following the law means adding geographic filtering.
We should shape the API based on the use cases of the developers who will be using the API, keeping in mind that we can always expose lower level functions like what the contractor does at a later date. We need to think about what types of things we should be supporting early on, and what types of things we'd add support for later. We're only going to have a successful ecosystem emerge if people can figure out safe ways to get files on to Sia in ways that make sense for their application.

The simplest use case is uploading a file. It makes sense to have a route that gives you as little friction as possible on the road from getting a brand new Sia to uploading a file. In that case, you might even have the daemon automatically set an allowance and upload contracts based on that, refusing to get started unless enough coins were in the wallet. And then the renter can automatically manage renewals and per-host budget increases based on usage patterns.
The original idea behind setting the allowance was not to estimate the amount of coins you are supposed to allocate, but rather to put a leash on the renter and make sure it did not spend more than a specific amount. And this is how it should be presented to the user. They should not be trying to guess their usage, that's a pretty good way to make sure that they don't use it very much - they'll be thinking about spending money.
I think we all got lost in the weeds on this one. The renter should be doing all of the heavy lifting on the estimation and management. At some point, we'll want to expose lower level APIs for power users so they can control things like exact redundancy, and perhaps also do their own host selection, but that's not something that we need to support at the moment.
As far as the API goes, and also as far as the UI goes, I would like to see the allowance be used as a money field, and as a maximum instead of an estimate. Users should be encouraged to over-estimate, because they get their money back. And, as the renter evolves, I think it would make sense that the renter doesn't even use the whole allowance when forming contracts, instead forming contracts based on usage patterns and doing renewals when they start to run out of money, keeping tabs on the allowance.
An increased allowance should not result in renewals (it's okay for now), but instead renewals should always be performed on an as-needed basis. After finishing an action, some check should be made to see if the balance is running low, the same way that a check is made at the end of each block to see if time is running low.

btw: contractor coverage increased from 62.7% to 84.7%.

I think that the difference between picking the amount of money you are spending and picking your own hosts is pretty huge. There are lots of reasons to have the renter do the host picking - the renter has a far better idea of which hosts are reliable, etc.

The idea is that a /hosts endpoint would do the heavy lifting in terms of choosing good hosts. It would also give you flexibility to choose cheap, fast, best, etc.

I also don't think it makes sense to have the developer managing renew schedules. As we've seen from implementing it ourselves, it's a pretty difficult thing to get right.

Most of the difficulty lies in the error handling -- specifically, the fact that we can't just abort as soon as we get an error. We have to make decisions on behalf of the caller, like whether to form new contracts if renewal fails. And those decisions are opaque; the caller doesn't know how much money is being spent or why, and if something goes wrong, there's often nowhere to report the error except the log.

We should shape the API based on the use cases of the developers who will be using the API, keeping in mind that we can always expose lower level functions like what the contractor does at a later date.

True, but we can't un-expose SetAllowance. And if we finalize it, how much of it gets covered by the compatibility promise? Certainly the input parameters and the return values, but what about the behavior? Are we bound to continue supporting the quirks of SetAllowance in perpetuity, or are we allowed to say SetAllowance sets the maximum amount of coins the renter may spend in a given period; it may or may not form or renew contracts, and its specific effect on the user's wallet and contract set is subject to change?
Anyway, as I've said, I'm ok with having high-level contract formation behavior. I think part of the problem is that we're conflating SetAllowance with IntelligentlyFormContractsAndAutomaticallyRenewThem. We should reframe the situation: the contractor intelligently form contracts and automatically renews them. That's its job. The allowance only serves to inform the contractor of its spending limit. The point being: SetAllowance should not be treated as a call that causes contracts to be formed or renewed. This is usually a side effect, but it is not the primary function. The documentation should make it clear that the contractor will form and renew contracts in an opaque manner. And likewise, the SetAllowance documentation should make no indication that it can control when contracts are formed or renewed, how much is spent on each contract, or who the contracts are made with. I think I'm fine having this sort of call finalized, though perhaps it should be renamed to SetSettings or something equally ambiguous, if the plan is to potentially expand its functionality.

The renter-contractor stack has a long way to go. It's pretty daunting. A big concern is that we still don't have any repair functionality. If too many hosts reject your renewal, you risk losing data. This is especially dangerous given the current SetAllowance behavior, since it will blindly form new contracts to replace failed renewals. That means that if all your renewals are rejected due to some default host setting (e.g. the new height wasn't high enough), it may form new contracts to replace every old contract, and boom, all your data is gone. How should this be handled?

Most of the difficulty lies in the error handling -- specifically, the fact that we can't just abort as soon as we get an error. We have to make decisions on behalf of the caller, like whether to form new contracts if renewal fails. And those decisions are opaque; the caller doesn't know how much money is being spent or why, and if something goes wrong, there's often nowhere to report the error except the log.

And what to do if some succeed and others don't. When some succeed you've already blown funds on the ones that succeeded. To me the way forward there is pretty clear: keep making new contracts until you've got enough to sustain the files. I don't think that's an opaque decision. When you decide to create a set of contracts for X siacoins, it should complete the task.

The idea is that a /hosts endpoint would do the heavy lifting in terms of choosing good hosts. It would also give you flexibility to prioritize by cheap, fast, best, etc., or to use a blacklist or whitelist.

You could use a /hosts endpoint to establish what sorts of filters get applied to the hostdb. I don't see a problem with adding that later.

True, but we can't un-expose SetAllowance. And if we finalize it, how much of it gets covered by the compatibility promise?

I'm thinking that instead of SetAllowance, we should probably have something like a RenterSettings struct, because what we're really doing is trying to control the behavior of the renter the same ways that we try to control the behavior of the host. You're not really setting an allowance, you're establishing a behavior pattern for the renter to form contracts, renew contracts, and repair contracts. Then you can add a cheater-field that's something like contractmanagement: automatic, which gives us wiggle room to extend this functionality later. Then you can redact the contract management code simply by setting it to manual or automatic-EU or automatic-IBM-needs-this-specific-behavior-pattern-that-we-programmed-for-them or whatever.
And then it's pretty easy to deny calls to the contractor if contract management has not been set to manual.

SetAllowance sets the maximum amount of coins the renter may spend in a given period; it may or may not form or renew contracts, and its specific effect on the user's wallet and contract set is subject to change

The promise of the automatic contract manager can be as simple as 'we'll make sure you can still upload and download, and that we won't spend more than X coins per month. All other behavior undefined'.

The renter-contractor stack has a long way to go. It's pretty daunting. A big concern is that we still don't have any repair functionality. If too many hosts reject your renewal, you risk losing data. This is especially dangerous given the current SetAllowance behavior, since it will blindly form new contracts to replace failed renewals. That means that if all your renewals are rejected due to some default host setting (e.g. the new height wasn't high enough), it may form new contracts to replace every old contract, and boom, all your data is gone. How should this be handled?

You've got time before the existing contracts expire. You need to do a download and reupload. I don't think repair in the naive case is very difficult, it's just taxing to the bandwidth.

anything left that needs fixing in this PR?
My plan is to first fix the desync problem, and then refactor the contractor to use SetSettings instead of SetAllowance. In doing so, I plan to move the contract formation code out of SetSettings. Instead, it will be managed by a background thread, which will simply receive signals from SetSettings and ProcessConsensusChange when it might need to perform some work.


text:
Charcoal Kiln brennt nicht ab

Habe auf dem Server einen seit 10 min laufen. Keine Charcoal bis jetzt,

Liegt daran das in unserem modpack noch keine neue Version von forest mods ist.

authors: Nedelosk krakel

repo: Nedelosk/Forest-Mods


text:
🛑 Becpl Angular UI is down

In e1a7082, Becpl Angular UI ($BECPL_ANGULAR_URL) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Becpl Angular UI is back up in 3d144d9 after 5 minutes.

repo: NehalDamania/becpl-uptime


text:
🛑 Becpl Angular UI is down

In 7723d0f, Becpl Angular UI ($BECPL_ANGULAR_URL) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Becpl Angular UI is back up in 48a1b88 after 15 minutes.


text:
🛑 Becpl Angular UI is down

In 4b360f4, Becpl Angular UI ($BECPL_ANGULAR_URL) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Becpl Angular UI is back up in 3c18a80 after 22 minutes.


text:
🛑 Becpl Angular UI is down

In fbc2e5e, Becpl Angular UI ($BECPL_ANGULAR_URL) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Becpl Angular UI is back up in 449c3c9 after 11 minutes.


text:
🛑 Becpl Angular UI is down

In 8964737, Becpl Angular UI ($BECPL_ANGULAR_URL) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Becpl Angular UI is back up in 095411a after 7 minutes.


text:
🛑 Becpl Angular UI is down

In f2520a7, Becpl Angular UI ($BECPL_ANGULAR_URL) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Becpl Angular UI is back up in 0fbd738 after 51 minutes.


text:
🛑 Becpl Angular UI is down

In ed0c7a4, Becpl Angular UI ($BECPL_ANGULAR_URL) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Becpl Angular UI is back up in 96518bd after 16 minutes.


text:
🛑 Becpl Angular UI is down

In a0db668, Becpl Angular UI ($BECPL_ANGULAR_URL) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Becpl Angular UI is back up in 9344441 after 6 minutes.


text:
Papercut: pressing x (discard) on stash does nothing, should tell user to use Zd (stash, drop) instead

This is something only first-time users like me are going to run into. Pressing x on a stash prompts me whether I want to drop <stash name>, confirming does nothing. Need to use Zd instead.
Don't know whether it would be better to allow x on stash to work like Zd, or whether it should print a message ('To drop stash, use Zd').
Also I noticed that using x on other random lines in the neogit buffer asks me if I want to 'discard nil?'. That should probably be checked against too.

Yeah, I've got a big rewrite of the status buffer that should be done very very soon, that'll do the right thing for stashes, and a lot more goodies. Because I totally agree, it's confusing.

Looking forward to it! Used Neogit for a little bit today and it seems really nice, first time switching to an in-editor git integration. ^^

Try out the nightly branch if you want to use this before 0.10 is released :)

authors: CKolkey LunarLambda

repo: NeogitOrg/neogit


text:
Hi, is there some part of the code missing, perhaps my problem is not running successfully, can I ask you a question privately?

Hi, is there some part of the code missing, perhaps my problem is not running successfully, can I ask you a question privately? I really need your help, my email is: fangc0729@163.com or 23cfang@stu.edu.cn

thanks for question，you can put your problem here for public use.

感谢您的提问，您可以将您的问题放在这里供公众使用。或发送到我的电子邮件。neoyang@tongji.edu.cn

感谢回答，以经向您发邮件请教。

thanks for question，you can put your problem here for public use. or send to my email. neoyang@tongji.edu.cn

感谢您的回答，已经向您发送邮件请教。

您好，打扰您了，请问您收到邮件了嘛，主要问题就是nc文件的处理和输入到网络，以及详细的数据集信息。

authors: Fccccccc Neoyanghc

repo: Neoyanghc/HiGRN


text:
MKL components are not installed when make sysinstall

MKL install script is not included in sysinstall sections. Is that desired? Means MKL is not allowed to be installed in system wide?
env: $(MKL_ENGINE) $(DATA_LOADER) $(ACTIVATE)
...
$(MKL_ENGINE):
@echo "Building MKL Engine..."
@./install_mkl.sh intel
...
sysinstall_nodeps: $(DATA_LOADER) neon_install
sysinstall: sysdeps $(DATA_LOADER) neon_install

@Quallyjiang  Thank you for trying neon!
You are right about MKL components not installed when "make sysinstall". It it a bug that we will make sure we address it in our next release.
You may already know, you can make the following changes to install MKL components as well during sysinstall:
-sysinstall: sysdeps $(DATA_LOADER) neon_install
+sysinstall: $(MKL_ENGINE) sysdeps $(DATA_LOADER) neon_install
So in conclusion, MKL component is definitely allowed to be installed system-wide

If neon is to be shared by multiple users, the suggestion is to put neon directory on a shared location, the purpose is for all users to be able to locate neon's MKL library.  Please let us know if you encounter further issues.

thanks!

If we have already completed a system-wide install, how do we install the MKL library?

The way I did was:

"make sysuninstall"
Add the $(MKL_ENGINE) target to sysinstall
"make sysinstall"

Alternatively, I think you can also try the following if you do not want to do "make sysuninstall":
./install_mkl.sh

authors: Quallyjiang pabutcher wei-v-wang

repo: NervanaSystems/neon


text:
Fix OpenShift version discovery for 4.x

OpenShift 4.x client returns a version string that looks like Kubernetes
so if the oc binary exists we should first check to see if we have a
Kubernetes-like version string and if not fall back to checking for a
OpenShift 3.x style string.
I have done some minimal testing so far and will continue to test today
on my OCP 4.x cluster

Per discussion on Slack: https://netapppub.slack.com/archives/C1E3QH84C/p1562163688298000

Thanks for the PR, @kincl!  We've merged your commit with proper attribution, so we can close this PR.

authors: clintonk kincl

repo: NetApp/trident


text:
Carousel visuals

In the modal for driving environment, you can find this carousel. It consists of a content container (header + paragraph), and a few images with a caption text below them.
https://www.figma.com/file/yv0VtHTvMoGPqkv0RAYcVp/PDP?type=design&node-id=1812-24921&mode=dev
Requirements

Buttons with previous/next arrows are used to navigate

When the start or the end of the carousel is reached, the respective button will be shown as inactive/disabled

On desktop, the content container is shown next to the images
On mobile/tablet the content container is shown on the top
Content remains static
Images will have a caption
Animation is similar to Promises
The component uses scroll-snap, and its behaviour/implementation is the same as #11 on mobile

To be determined

[ ] How do we name this block?

related to #78

confirmed as done
as tested on https://70-content-carousel--vg-volvotrucks-us-rd--netcentric.hlx.page/drafts/lakshmi/content-carousel

repo: Netcentric/vg-volvotrucks-us-rd


text:
About the lastHealthCountsSnapshot

Hey Ben, one question:
Once the HystrixCircuiBreaker is open, all requests will be SHORT_CIRCUITED (one of the failure), then after circuitBreakerSleepWindowInMilliseconds, will try 1 time, if it is successful, will call metrics.resetCounter();
But the lastHealthCountsSnapshot is not be reseted. and when other request comes, and find the health.getErrorPercentage() > properties.circuitBreakerErrorThresholdPercentage().get()(because all requests in last several seconds are SHORT_CIRCUITED, so in lastHealthCountsSnapshot, all are failure)  , so comes in another short circuit, and so on and so on.
So my question is why metrics.resetCounter() not clear lastHealthCountsSnapshot, and why SHORT_CIRCUITED is one of failure when calculate getErrorPercentage?
Thanks very much.

Confirmed via code review that this issue was fixed in #236.  @jlming6 Please re-open if you see any evidence that demonstrates otherwise.

repo: Netflix/Hystrix


text:
bug: 2 separate functions annotated with DgsEntityFetcher for same entity works

Please read our contributor guide before
creating an issue.
Expected behavior
should result in some kind of compiler or bootup error
Actual behavior
no error, probably registers the function based on some custom order

Fixed in #2053

authors: paulbakker stejas

repo: Netflix/dgs-framework


text:
Add ability to override SourceArn for SES

This is a requirement in order to use an SES authorization policy.

Coverage increased (+0.006%) to 59.365% when pulling 5e696f36bf8762da59583e85cb2ad4647417bca2 on jtschladen:ses-arn-override into 54566ad4c3481e2e1213904e94c491bf6f8a3245 on Netflix:master.

authors: coveralls jtschladen

repo: Netflix/lemur


text:
exec ./gradlew clean build error

Hi ajoymajumdar.Firstly,Thanks to your open source code, I am glad to explore metacat, but when I follow your readme,I have met some errors. I have try some solutions in these issues, but it did not work to me, can you help me? The error is shown in the following figure. Thank you

Hi ajoymajumdar:
I have build successful, but I can not configure the data catalog, when I  request http:localhost:8080/mds/v1/catalog, the error is 404, can you share some doc with us? Thanks to your reply

@RoyalFeng .. the application.yml file exists as a resource under metacat-main project.
You can add the catalog as well as usermetadata config location in the file.

@sabarnwa Thanks for your reply,can i contact you with email?

@sabarnwa  I configure metacat.usermetdata.config.location in the application.yml, and new mkdir /etc/catalog, I put two files( sample and mysql-56-db.properties) in /etc/catalog. Is it right?

@RoyalFeng .. yes.. it looks fine. You can contact me via mail.

@sabarnwa  Thank for your reply , my own e-mail is royalfy@gmail.com, can you contact me by email?or you tell me your email (sorry,I can not find your email)

@sabarnwa  take the war file under metacat-war/build/libs directory and rename metacat-1.2.0-SNAPSHOT.war to ROOT.war? But Tomcat/webapp/ has root file, this will conflict,so can you tell me detailed
steps?Thank you

@sabarnwa Thanks for your reply. When I replace the ROOT.war and I start the tomcat,localhost:8080 is "can not find localhost page", The 8080 port is not configurated . so I do not know how to do. I think the building procedure has occurred some errors, and is the metacat project under /etc? Thank you

@sabarnwa I can not find mds directory in tomcat/webapp/. ROOT's directory structure is shown in the following figure. please help me see whether it is right. Thank you very much.

Can you check with this url: http://localhost:8080/swagger-ui.html#/
or "curl -X GET --header 'Accept: /' 'http://localhost:8080/mds'"

@sabarnwa  Thanks for your reply, If you do not mind ,can i contact with you via mail? I think this will be fast and efficient, Thank you very much.

@sabarnwa  In my opinion, if I can access http://localhost:8080/mds, "mds" directory must be under the directory "tomcat/webapp/ROOT/", is it right? But in my  scene, I can not find mds in ROOT directory.

authors: RoyalFeng sabarnwa

repo: Netflix/metacat


text:
Removed the useBytes toggle, always set bytes on pods

Now that we have 100% rollout of this feature, we are
ready to remove the toggle.
This change must be deployed after the titus-executor
change to always use bytes

The newer version of titus-executor that always assumes bytes is everywhere.
Should be safe to merge and deploy this now.

repo: Netflix/titus-control-plane


text:
Removes http-server

Addresses #158

Todo -- .md mime type

Rebased

repo: Netflix/x-element


text:
Bump oletools 0.60.1.dev6

Current olefy RPM does not block malicious macros designed to trick the stable oletools package. Check if a newer release of olefy+oletools is more effective.
Ref. olefy diffs from RPM version 1.2.3

I'm testing this RPM on a production environment /cc @filippocarletti

How's going? Can we release it or we can just drop it?

The newer 0.60.1 olefy version has not identified more malware.
I'm closing this pull request.

repo: NethServer/olefy


text:
SnapSync algorithm design

Use all content on SnapSync (clips, slides, quick-and-dirty implementation) to put down a high-level SnapSync algorithm specification in pseudo code or sequence/flow diagrams.
This should be the baseline for identification of alternative flows, failure scenarios, edge cases, etc. and be a spec for actual implementation.

Draft of the design can be found here
https://www.notion.so/nethermind/Snapsync-algorithm-design-c55065c45ed342c2be6d57dea6edac84

repo: NethermindEth/juno


text:
BiocamRawIO: Prevent loading whole array into memory

Iterate through channels to prevent loading the whole array into memory even during a channel slice.
@alejoe91, this was a complete stab in the dark by me. If you have a better solution happy to close this. Since I don't know this format at all I'll let the CI see if I completely messed things up.

Okay @alejoe91 I think this is ready for a final review when you have time. It passed tests when it was on draft so it should still pass now.
@GrimmSnark, do you want to test installing Neo from this PR and see if this fixes your issue?

@zm711 let's merge this one!

repo: NeuralEnsemble/python-neo


text:
niimath

https://github.com/rordenlab/niimath

@Vbitz that should be a quick and fun one

repo: NeuroDesk/neurocontainers


text:
[Draft] First take at static type checking

This is a first take at introducing static type checking to the SDK. This pull request does the following:

Adds the two Sorbet gems to the Gemfile
Initializes Sorbet by introducing the Sorbet folder structure ./sorbet/...
Adds # typed: ... sigils to each file
Turns on typed to strict for .lib/nexmo/sms.rb
Adds signature methods to the SMS class
Comments out the private class definitions for Nexmo::Logger because the return for @logger.warn could not be accessed in the private interface
Moved the #request method in Nexmo::Namespace to the public interface because it was unreachable in the type check.

@timcraft, Hope you had a good weekend. This is a first take at introducing static type checking into the gem, first in the SMS class. It necessitated some design choices and would love your thoughts on this.
I'm also going to tag @fabianrbz in this draft PR as another resident Rubyist.

I believe, but I could be wrong, that all files must have a # typed: ... sigil at the top. A designation of false means that Sorbet completely ignores that file; true means that it checks for code quality, and strict means every method must have a method signature. It is up to you to specify what level you want for each file in your code.

Yes, but that's not what I meant. That sorbet directory includes a lot of code which isn't related to this repo, the addressable.rbi file for example. Presumably the goal of this PR is to type check the code in lib, not to type check the tests, or type check third party dependencies?
Adding 37k loc to type check 1k loc seems a bit ridiculous. Is there a config option in sorbet that can be used to ignore the test files (and any gems used by the tests)?

To tack on from our 1:1 with @timcraft , we can ignore some of the folders through sorbet to help cut down on the amount of cruft in the sorbet/ directory, so we can probably cut down on sorbet looking at tests and any vendors: https://sorbet.org/docs/cli#including-and-excluding-files

@timcraft, after further exploration the auto-generated initialization files are non-negotiable. The link @dragonmantank referenced is for specifying which files to check during a runtime check, not during initialization. Having spent a couple of days further looking into this, we're ready to move forward and include this in the 6.3.0 release. The auto-generated files are maintained by the gem, no person touches them or is expected to, so let's go ahead and add this to the upcoming release. Thank you, hope you have a great weekend! 🙏

The auto-generated files are maintained by the gem, no person touches them or is expected to

If I understand how it works correctly they need to be updated whenever static type checking is added to a file? So they need to be maintained indirectly, albeit not editing the files by hand.
Just looking at this in more detail:

The sorbet/rbi/hidden-definitions/errors.txt file can be ignored. If you add that path to .gitignore that'll cut out 9,517 lines from the diff.

Can you move the sorbet-runtime require to lib/nexmo.rb after the zeitwerk require? That's where runtime dependencies should be loaded (avoids needing to add it to every file).

The sig for Nexmo::SMS#unicode? looks incorrect, the argument should be a string not nil. I'm pretty sure you can remove the T.nilable from there. Also it helps to format whitespace consistently, prefer sig { to sig{ for example in that case.

Instead of using T.let for every reference to @logger I think it could be simpler to eliminate the instance variable, reference config.logger directly, and add a protected accessor for the config attribute. It doesn't need to be an instance variable, that's just how it was written.

The private_constant calls exist in order to clearly mark "internal" code, and those constants don't show up in the generated documentation. If sorbet doesn't support that usage then the calls to private_constant need to be removed (not simply commented out), and they need to be marked as private so that YARD doesn't generate documentation for them.

Let me know if any of those don't make sense and we can discuss.

Hi @timcraft - I see a bunch of work has been done on this just now. Is this in good shape for next week? If not, what are we missing?

@benhayehudi I've rebased on master and fixed a number of outstanding issues.
I'll incorporate into v6.3.0 as discussed.

authors: benhayehudi dragonmantank timcraft

repo: Nexmo/nexmo-ruby


text:
Mcs 75

https://nextcentury.atlassian.net/browse/MCS-75

Added the missing unity assets should be ready for merge now


text:
Fixed localStorage cleaning on a form submit denial of the autosave feature

Firstly, I didn't get why npm install && gulp on my machine corrupts the compiled files the way they lose the topmost code including the part where CodeMirror is required. So I couldn't have compiled the minified version properly. I've spent an hour trying to figure out what's wrong with no luck. The contributing.md file does not contain any info on development.
Now, the reason of PR. There was a bug with localStorage.removeItem at least on Chrome 49.0.2623.108.
When form had been submitted, the last saved by the autosave feature value, was restored on the next page load no matter what.
Use case: I create a new item via CMS (uniqueId == model.name+object.id where object.id is empty), and then create another one. The second item form is populated with the old item's content of the SimpleMDE field.
I've found out there was an insane race condition, so I've added locks and it worked. I then copied the fix into all non-minified files.
BTW, guys, why didn't you merge in the master for so long?

Two things, first can you demonstrate this using JSFiddle? If possible, please provide a series of steps that will replicate the issue every time. Then show how your PR fixes that.
Secondly, can you not alter the files in the /debug/ folder? Only the single source file needs changes when you compare for the PR.

authors: WesCossick tinbka

repo: NextStepWebs/simplemde-markdown-editor


text:
03-react-essentials.mdx

@seongjoojin

@seongjoojin 이슈 할당 후 1주일 경과됐습니다, 작업 진행 부탁드립니다!

closed by #249


text:
bug: frozen pool due to insufficient reserves and LP share supply of 0

This issue describes a potential edge case in the dex module that we didn't account for.
Observed behavior
Image 1: Current output of nibid q dex get-pool 1  (devnet-2).
{
  "pool": {
    "id": "1",
    "address": "nibi1w00c7pqkr5z7ptewg5z87j2ncvxd88w43ug679",
    "pool_params": {
      "swap_fee": "0.010000000000000000",
      "exit_fee": "0.020000000000000000",
      "A": "0",
      "pool_type": "BALANCER"
    },
    "pool_assets": [
      {
        "token": {
          "denom": "unibi",
          "amount": "1"
        },
        "weight": "53687091200000000"
      },
      {
        "token": {
          "denom": "unusd",
          "amount": "424"
        },
        "weight": "53687091200000000"
      }
    ],
    "total_weight": "107374182400000000",
    "total_shares": {
      "denom": "nibiru/pool/1",
      "amount": "0"
    }
  }
}

Image 2:  Joining the pool using even 1unusd fails with "too few assets to join this pool"

Image 3: Joining the pool using just 1unibi also fails with "too few assets to join this pool"

Image 4: Matching the reserve ratio gives an "invalid coins" error since there are 0 pool shares.

Problem description
In other words, the pool is stuck. I've tried other variations of nibid tx dex join-pool and can't seem to get any new shares minted. Since reserves are highly imbalanced, the small amount of unibi also creates a problem. I guess that's checkmate for this pool.
How I created this scenario

I created a pool for unibi:unusd with healthy reserves.
I swapped away all of the unibi reserves.
I also burned all my LP shares for no reason.

Proposal
Provide a work-around feature that re-mints new shares if there aren't any for a live pool. The case created in this issue could be used for one of the test cases.

The single asset side of it seems to be fixed by this PR 1114

https://github.com/NibiruChain/nibiru/pull/1114

Reopening the issue to address the case where there are 0 shares in the pool.

repo: NibiruChain/nibiru


text:
[AUDIT] Zellic tracking issue [EPIC]

Main Task List

[x] #1374
[x] #1375
[x] #1376
[x] #1377
[x] #1378
[x] https://github.com/NibiruChain/cw-nibiru/issues/31
[x] #1415
[x] #1416
[x] #1438

Updates

2023-06-14: Initial draft sent highlighting above issues
2023-06-15: Enter remediation section
[x] Send commit hashes for fixes to Zellic

Follow-up Changes
Start Date: 2023-06-28

[x] #1457
[x] #1458

Looks closed now


text:
Integrated the Italian language

Integrated the Italian language

This PR should be made on the main frigate repo, not mine

This PR should be made on the main frigate repo, not mine

I opened the application here to contribute to your work #3718

This PR should be made on the main frigate repo, not mine

I opened the PR here to contribute to your work #3718


text:
🛑 cedro is down

In a16027d, cedro (https://www.cedro.org) was down:

HTTP code: 0
Response time: 0 ms

Resolved: cedro is back up in d9a711c.

repo: NicolasAbihaggle/serviciosestados


text:
Loan Prediction Project

I have added the project- Loan Prediction.

Please assign a level too for GsSoc'24. It is with regard to the issue I was assigned.

@Niketkumardheeryan please look into it.

hi @sanskritiagr  good work, jsut need to improve readme.md file, attach ss of after running your flask app ,And add more comments in your .ipynb file  for readability.

Done

Please merge it.

I have added the project- Loan Prediction.

Please assign me this Project I have a good experience in Data Science and Machine Learning.

Is there any problem merging this? @Niketkumardheeryan

Please merge this. It has been a long time now.

hi @sanskritiagr  good work, jsut need to improve readme.md file, attach ss of after running your flask app ,And add more comments in your .ipynb file  for readability.

Please assign me this Project as I have a good experience in working with projects in Data Science.

@Niketkumardheeryan I did the changes you wanted me to do. Please merge this file.

repo: Niketkumardheeryan/ML-CaPsule


text:
optimized the trading strategy based on sentiment analysis added

#563 resolved
Sentiment Analysis-Driven Trading Strategy

@invigorzz313 pls check it


text:
Storing secret data in .env and other fixes

Issue #9 has been solved.

Привет, все круто, можешь только в env еще и кофигурационные данные для вебхука на railway добавить (как альтернатива нынче нерабочему heroku).

Привет, спасибо за ответ, сейчас всё сделаю!

authors: NikolaySimakov tiomchik

repo: NikolaySimakov/Shop-bot


text:
Bug/input field fix

Фиксит https://github.com/Ninja-Official/rtu-mirea-mobile/issues/79
В рамках PR добавлен переиспользуемая логика, при которой обьект поднимается на размер равный клавиатуры, тем самым поле ввода становится видным для пользователей:
(Поле ввода "ваша группа" теперь будет над клавиатурой для любых устройств):

Так, стопе, wtf

А, тьфу, запулить последние изменения забыл. Ща переделаю

repo: Ninja-Official/rtu-mirea-mobile


text:
additional.py

verified operator

Your checklist for this pull request

[x] I have committed only those files that are required.
[x] I have tried commit messages concise and reflective of the code committed.
[x] I have used a branch name reflective of the issue.
[ ] If there is relavant issue for the PR, I have used closes #<issue number> to auto-close the issue once PR is merged.

Detailed description

Test plan (required)

Closing issues

"+" operator verified

fixed the error

fixed error

repo: NirmalManoj/aim-gsoc


text:
[FEAT] Add service folder.

Add service folder in the kubernetes practical folder. It is most important part of the kubernetes.

I want work on this issue. Assign hacktoberfest label on it.

@NishkarshRaj Can you please kindly add this repository to hacktoberfest so that we can get more contribution on it?

repo: NishkarshRaj/Docker-Kubernetes


text:
Seeder update3

G is done no comments now. i is done up to topic 95.
98 total topics, about 9 pages total.

vur niceee!

repo: Nitharios/but-devvy-said


text:
TagBot trigger issue

This issue is used to trigger TagBot; feel free to unsubscribe.
If you haven't already, you should update your TagBot.yml to include issue comment triggers.
Please see this post on Discourse for instructions and more details.
If you'd like for me to do this for you, comment TagBot fix on this issue.
I'll open a PR within a few hours, please be patient!

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/61618


text:
Firefox: about:crashes don't work

Describe the bug
Firefox crashed because my disk was full. I wanted to submit a crash report, but the site the documentation mentions don't exist.
https://support.mozilla.org/en-US/kb/mozillacrashreporter
To Reproduce
Steps to reproduce the behavior:

open about:crashes in firefox

Expected behavior
firefox works like an official release
Screenshots

Additional context
Add any other context about the problem here.
Notify maintainers
@eelco
Metadata

system: "x86_64-linux"
host os: Linux 5.10.1, NixOS, 21.03.git.173696f216f (Okapi)
multi-user?: yes
sandbox: yes
version: nix-env (Nix) 2.3.10
channels(root): "home-manager-20.09, nixos-20.09.2344.a3a3dda3bac, nixos-hardware, nixos-unstable-21.03pre257780.e9158eca70a"
nixpkgs: /nix/var/nix/profiles/per-user/root/channels/nixos

Maintainer information:
# a list of nixpkgs attributes affected by the problem
attribute:
# a list of nixos modules affected by the problem
module:

Firefox is compiled without crash reporting support by default: https://github.com/NixOS/nixpkgs/blob/85c8f75393d7b0e593b3accd3b52155f63daa4f1/pkgs/applications/networking/browsers/firefox/common.nix#L43. I don't know why.

Probably because it could be considered tracking. But i think it's optional to actually send the crash reports and they don't contain personal data and are very useful to fix crashes.
We would need clear guidelines which kind of tracking is OK.

I don't have time to open a discussion about that.
Since it crashed again, i tried with a workaround:
  environment.systemPackages = with pkgs; [
    chromium
    (firefox.override {
      crashreporterSupport = true;
    })
 ];

rebuild fails with this error. i guess it's due to the structure of the firefox packaging. the option is in the firefox/common.nix while the package is defined in firefox/packages.nix
error: 'wrapper' at /nix/store/m3a0x22ndfbgs53ml0isvlsrsmbqxvzg-nixos-20.09.2618.352481146d8/nixos/pkgs/applications/networking/browsers/firefox/wrapper.nix:23:5 called with unexpected argument 'crashreporterSupport', at /nix/store/m3a0x22ndfbgs53ml0isvlsrsmbqxvzg-nixos-20.09.2618.352481146d8/nixos/lib/customisation.nix:69:16
any idea?

I don't have time to open a discussion about that.
Since it crashed again, i tried with a workaround:
  environment.systemPackages = with pkgs; [
    chromium
    (firefox.override {
      crashreporterSupport = true;
    })
 ];

rebuild fails with this error. i guess it's due to the structure of the firefox packaging. the option is in the firefox/common.nix while the package is defined in firefox/packages.nix
error: 'wrapper' at /nix/store/m3a0x22ndfbgs53ml0isvlsrsmbqxvzg-nixos-20.09.2618.352481146d8/nixos/pkgs/applications/networking/browsers/firefox/wrapper.nix:23:5 called with unexpected argument 'crashreporterSupport', at /nix/store/m3a0x22ndfbgs53ml0isvlsrsmbqxvzg-nixos-20.09.2618.352481146d8/nixos/lib/customisation.nix:69:16
any idea?

Looking at the definition quickly, I'd try (wrapFirefox (firefox-unwrapped.override { crashreporterSupport = true; }) { })

Looking at the definition quickly, I'd try (wrapFirefox (firefox-unwrapped.override { crashreporterSupport = true; }) { })

The build starts with that, but fails exactly at the crashreporter. I guess no one has tested that in a while.
   Compiling dump_syms_rust_demangle v0.1.0 (/build/firefox-84.0.2/toolkit/crashreporter/rust)
     Running `CARGO=/nix/store/fd62fkbclh3s0jym0q6ia3fgd8mzhxzi-cargo-1.44.1/bin/.cargo-wrapped CARGO_MANIFEST_DIR=/build/firefox-84.0.2/toolkit/crashreporter/rust CARGO_PKG_AUTHORS= CARGO_PKG_DESCRIPTION= CARGO_PKG_HOMEPAGE= CARGO_PKG_NAME=dump_syms_rust_demangle CARGO_PKG_REPOSITORY= CARGO_PKG_VERSION=0.1.0 CARGO_PKG_VERSION_MAJOR=0 CARGO_PKG_VERSION_MINOR=1 CARGO_PKG_VERSION_PATCH=0 CARGO_PKG_VERSION_PRE= LD_LIBRARY_PATH='/build/firefox-84.0.2/obj-x86_64-pc-linux-gnu/release/deps:/nix/store/wzk6j6ijc0y91q30kndr8m9frlf90fsx-rustc-1.44.1/lib' /nix/store/wzk6j6ijc0y91q30kndr8m9frlf90fsx-rustc-1.44.1/bin/rustc --crate-name dump_syms_rust_demangle toolkit/crashreporter/rust/lib.rs --error-format=json --json=diagnostic-rendered-ansi --crate-type staticlib --emit=dep-info,link -C opt-level=2 -C panic=abort -C metadata=7cbd7ef9159eddf3 -C extra-filename=-7cbd7ef9159eddf3 --out-dir /build/firefox-84.0.2/obj-x86_64-pc-linux-gnu/x86_64-unknown-linux-gnu/release/deps --target x86_64-unknown-linux-gnu -C linker=/build/firefox-84.0.2/build/cargo-linker -L dependency=/build/firefox-84.0.2/obj-x86_64-pc-linux-gnu/x86_64-unknown-linux-gnu/release/deps -L dependency=/build/firefox-84.0.2/obj-x86_64-pc-linux-gnu/release/deps --extern rustc_demangle=/build/firefox-84.0.2/obj-x86_64-pc-linux-gnu/x86_64-unknown-linux-gnu/release/deps/librustc_demangle-5f31f71fe6b2c40e.rlib -C opt-level=2 -C debuginfo=2 --cap-lints warn -C codegen-units=1`
    Finished release [optimized] target(s) in 1.33s
make[3]: Leaving directory '/build/firefox-84.0.2/obj-x86_64-pc-linux-gnu/toolkit/crashreporter/rust'
make[3]: Entering directory '/build/firefox-84.0.2/obj-x86_64-pc-linux-gnu/toolkit/crashreporter/google-breakpad/src/tools/linux/dump_syms'
toolkit/crashreporter/google-breakpad/src/tools/linux/dump_syms/dump_syms
/nix/store/azayfhqyg9mjyv6rv9bcypi6ws8aqfmy-gcc-wrapper-9.3.0/bin/g++ -std=gnu++17 -o ../../../../../../../dist/host/bin/dump_syms -freorder-blocks -O2 -O2 -g  @/build/firefox-84.0.2/obj-x86_64-pc-linux-gnu/toolkit/crashreporter/google-breakpad/src/tools/linux/dump_syms/dump_syms.list /build/firefox-84.0.2/obj-x86_64-pc-linux-gnu/x86_64-unknown-linux-gnu/release/libdump_syms_rust_demangle.a -ldl -lpthread -lrt
/build/firefox-84.0.2/obj-x86_64-pc-linux-gnu/_virtualenvs/init_py3/bin/python -m mozbuild.action.check_binary --host ../../../../../../../dist/host/bin/dump_syms
BUILDTASK {"argv": ["/build/firefox-84.0.2/python/mozbuild/mozbuild/action/check_binary.py", "--host", "../../../../../../../dist/host/bin/dump_syms"], "start": 1610741244.609147, "end": 1610741244.6099205, "context": null}
make[3]: Leaving directory '/build/firefox-84.0.2/obj-x86_64-pc-linux-gnu/toolkit/crashreporter/google-breakpad/src/tools/linux/dump_syms'
collect2: error: ld returned 1 exit status
make[3]: *** [/build/firefox-84.0.2/config/rules.mk:545: libxul.so] Error 1
make[3]: Leaving directory '/build/firefox-84.0.2/obj-x86_64-pc-linux-gnu/toolkit/library/build'
make[2]: *** [/build/firefox-84.0.2/config/recurse.mk:72: toolkit/library/build/target] Error 2
make[2]: Leaving directory '/build/firefox-84.0.2/obj-x86_64-pc-linux-gnu'
make[1]: *** [/build/firefox-84.0.2/config/recurse.mk:34: compile] Error 2
make[1]: Leaving directory '/build/firefox-84.0.2/obj-x86_64-pc-linux-gnu'
make: *** [/build/firefox-84.0.2/config/rules.mk:355: default] Error 2
builder for '/nix/store/27cpp1va9ia77kc6ragbg195m880s1fx-firefox-unwrapped-84.0.2.drv' failed with exit code 2
cannot build derivation '/nix/store/wpsyb3imafddymm73023k6783gb2y3si-firefox-84.0.2.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/lbgnr6ygqpzh6y7vnal75nwa3lih1gyk-system-path.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/0xk6ds5w65i9hjky2b2z15g9fxw8b6qj-nixos-system-gaming-20.09.2618.352481146d8.drv': 1 dependencies couldn't be built
error: build of '/nix/store/0xk6ds5w65i9hjky2b2z15g9fxw8b6qj-nixos-system-gaming-20.09.2618.352481146d8.drv' failed

It took 33 minutes to get to that point with a i9 cpu (16x 4GHz). 32 GB RAM would be good, 16 will SWAP.

The build starts with that, but fails exactly at the crashreporter. I guess no one has tested that in a while.
   Compiling dump_syms_rust_demangle v0.1.0 (/build/firefox-84.0.2/toolkit/crashreporter/rust)
     Running `CARGO=/nix/store/fd62fkbclh3s0jym0q6ia3fgd8mzhxzi-cargo-1.44.1/bin/.cargo-wrapped CARGO_MANIFEST_DIR=/build/firefox-84.0.2/toolkit/crashreporter/rust CARGO_PKG_AUTHORS= CARGO_PKG_DESCRIPTION= CARGO_PKG_HOMEPAGE= CARGO_PKG_NAME=dump_syms_rust_demangle CARGO_PKG_REPOSITORY= CARGO_PKG_VERSION=0.1.0 CARGO_PKG_VERSION_MAJOR=0 CARGO_PKG_VERSION_MINOR=1 CARGO_PKG_VERSION_PATCH=0 CARGO_PKG_VERSION_PRE= LD_LIBRARY_PATH='/build/firefox-84.0.2/obj-x86_64-pc-linux-gnu/release/deps:/nix/store/wzk6j6ijc0y91q30kndr8m9frlf90fsx-rustc-1.44.1/lib' /nix/store/wzk6j6ijc0y91q30kndr8m9frlf90fsx-rustc-1.44.1/bin/rustc --crate-name dump_syms_rust_demangle toolkit/crashreporter/rust/lib.rs --error-format=json --json=diagnostic-rendered-ansi --crate-type staticlib --emit=dep-info,link -C opt-level=2 -C panic=abort -C metadata=7cbd7ef9159eddf3 -C extra-filename=-7cbd7ef9159eddf3 --out-dir /build/firefox-84.0.2/obj-x86_64-pc-linux-gnu/x86_64-unknown-linux-gnu/release/deps --target x86_64-unknown-linux-gnu -C linker=/build/firefox-84.0.2/build/cargo-linker -L dependency=/build/firefox-84.0.2/obj-x86_64-pc-linux-gnu/x86_64-unknown-linux-gnu/release/deps -L dependency=/build/firefox-84.0.2/obj-x86_64-pc-linux-gnu/release/deps --extern rustc_demangle=/build/firefox-84.0.2/obj-x86_64-pc-linux-gnu/x86_64-unknown-linux-gnu/release/deps/librustc_demangle-5f31f71fe6b2c40e.rlib -C opt-level=2 -C debuginfo=2 --cap-lints warn -C codegen-units=1`
    Finished release [optimized] target(s) in 1.33s
make[3]: Leaving directory '/build/firefox-84.0.2/obj-x86_64-pc-linux-gnu/toolkit/crashreporter/rust'
make[3]: Entering directory '/build/firefox-84.0.2/obj-x86_64-pc-linux-gnu/toolkit/crashreporter/google-breakpad/src/tools/linux/dump_syms'
toolkit/crashreporter/google-breakpad/src/tools/linux/dump_syms/dump_syms
/nix/store/azayfhqyg9mjyv6rv9bcypi6ws8aqfmy-gcc-wrapper-9.3.0/bin/g++ -std=gnu++17 -o ../../../../../../../dist/host/bin/dump_syms -freorder-blocks -O2 -O2 -g  @/build/firefox-84.0.2/obj-x86_64-pc-linux-gnu/toolkit/crashreporter/google-breakpad/src/tools/linux/dump_syms/dump_syms.list /build/firefox-84.0.2/obj-x86_64-pc-linux-gnu/x86_64-unknown-linux-gnu/release/libdump_syms_rust_demangle.a -ldl -lpthread -lrt
/build/firefox-84.0.2/obj-x86_64-pc-linux-gnu/_virtualenvs/init_py3/bin/python -m mozbuild.action.check_binary --host ../../../../../../../dist/host/bin/dump_syms
BUILDTASK {"argv": ["/build/firefox-84.0.2/python/mozbuild/mozbuild/action/check_binary.py", "--host", "../../../../../../../dist/host/bin/dump_syms"], "start": 1610741244.609147, "end": 1610741244.6099205, "context": null}
make[3]: Leaving directory '/build/firefox-84.0.2/obj-x86_64-pc-linux-gnu/toolkit/crashreporter/google-breakpad/src/tools/linux/dump_syms'
collect2: error: ld returned 1 exit status
make[3]: *** [/build/firefox-84.0.2/config/rules.mk:545: libxul.so] Error 1
make[3]: Leaving directory '/build/firefox-84.0.2/obj-x86_64-pc-linux-gnu/toolkit/library/build'
make[2]: *** [/build/firefox-84.0.2/config/recurse.mk:72: toolkit/library/build/target] Error 2
make[2]: Leaving directory '/build/firefox-84.0.2/obj-x86_64-pc-linux-gnu'
make[1]: *** [/build/firefox-84.0.2/config/recurse.mk:34: compile] Error 2
make[1]: Leaving directory '/build/firefox-84.0.2/obj-x86_64-pc-linux-gnu'
make: *** [/build/firefox-84.0.2/config/rules.mk:355: default] Error 2
builder for '/nix/store/27cpp1va9ia77kc6ragbg195m880s1fx-firefox-unwrapped-84.0.2.drv' failed with exit code 2
cannot build derivation '/nix/store/wpsyb3imafddymm73023k6783gb2y3si-firefox-84.0.2.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/lbgnr6ygqpzh6y7vnal75nwa3lih1gyk-system-path.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/0xk6ds5w65i9hjky2b2z15g9fxw8b6qj-nixos-system-gaming-20.09.2618.352481146d8.drv': 1 dependencies couldn't be built
error: build of '/nix/store/0xk6ds5w65i9hjky2b2z15g9fxw8b6qj-nixos-system-gaming-20.09.2618.352481146d8.drv' failed

It took 33 minutes to get to that point with a i9 cpu (16x 4GHz). 32 GB RAM would be good, 16 will SWAP.

I got it to build, on a second attempt 🤷🏽   Anyway, I don't think it will be that easy to actually use the reporter.  For example, I don't think our default build keeps debugging symbols, and I don't expect it can really report anything useful without them.

I got it to build, on a second attempt 🤷🏽   Anyway, I don't think it will be that easy to actually use the reporter.  For example, I don't think our default build keeps debugging symbols, and I don't expect it can really report anything useful without them.

I just built with crash-reporting enabled and everything seems to be working perfectly. Is there any reason we can't turn this on. In my case the reports are not even sending without asking first.
If tracking is a concern may we can change the default from false to !privacySupport.

Since I don't hear any clear objections I have opened https://github.com/NixOS/nixpkgs/pull/171900 to hopefully push this issue along.

authors: collares davidak kevincox vcunat

repo: NixOS/nixpkgs