text:
Select-String line number overflows

Prerequisites

[X] Write a descriptive title.
[X] Make sure you are able to repro it on the latest released version
[X] Search the existing issues.
[X] Refer to the FAQ.
[X] Refer to Differences between Windows PowerShell 5.1 and PowerShell.

Steps to reproduce
Using 'Select-String' on extremly big files can return negative line numbers. I've tested this with rockyou2024.txt, which has roughly 10 billion lines.
Expected behavior
The beginning looks fine (line numbers have been partly anonymized):

PS H:\FFDownloads> Select-String -Path .\rockyou2024.txt -SimpleMatch:$true -Pattern "[redacted]"

rockyou2024.txt:35x7454:[redacted]
rockyou2024.txt:373x742:[redacted]
rockyou2024.txt:22835x658:[redacted]
rockyou2024.txt:94x240763:[redacted]

Actual behavior
Excerpt from the middle, where multiple overflows happen:

rockyou2024.txt:-16155x8268:[redacted]
rockyou2024.txt:-16155x8252:[redacted]
rockyou2024.txt:-1615x88255:[redacted]
rockyou2024.txt:-8271632x7:[redacted]
rockyou2024.txt:-82716xx70:[redacted]
rockyou2024.txt:13197x054:[redacted]
rockyou2024.txt:1319871x7:[redacted]
rockyou2024.txt:1113x02014:[redacted]
rockyou2024.txt:11133x5056:[redacted]
rockyou2024.txt:111348x182:[redacted]
rockyou2024.txt:1594956x68:[redacted]
rockyou2024.txt:176566x256:[redacted]
rockyou2024.txt:18529x8022:[redacted]
rockyou2024.txt:1936742839:[redacted]
rockyou2024.txt:-2079296217:[redacted]
rockyou2024.txt:-2079092911:[redacted]
rockyou2024.txt:-2079088x42:[redacted]

Error details
No response
Environment data
PS H:\FFDownloads> $PSVersionTable | clip

Name                           Value
----                           -----
PSVersion                      7.4.3
PSEdition                      Core
GitCommitId                    7.4.3
OS                             Microsoft Windows 10.0.19045
Platform                       Win32NT
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0…}
PSRemotingProtocolVersion      2.3
SerializationVersion           1.1.0.1
WSManStackVersion              3.0

Visuals
No response

2³¹ = 2147483648 (or 2 147 483 648)
Does have an overflow the «Get-Content»?

Makes sense, Select-String uses a signed 32-bit integer to track the line number:
https://github.com/PowerShell/PowerShell/blob/dcf67544451425c98580d79a8381e9a07775c86d/src/Microsoft.PowerShell.Commands.Utility/commands/utility/MatchString.cs#L83

Makes sense, Select-String uses a signed 32-bit integer

I don't see a reason why it shouldn't be a 64Bit unsigned Int.
There can't exist negative linenumbers

FYI: I'm working on a fix


text:
Invoke-Command should support -StrictMode

This would effectly add the command "Set-StrictMode -version 5" at the beginning of the scriptblock.
The reason why should should be a parameter vs just having the user add that line to every script is that it allows someone to set this via $PSDefaultParameterValues and have it affect an entire corpus of scripts (without having to change the scripts itself).
Here is the workaround that I wrote to implement this:
https://www.powershellgallery.com/packages/Invoke-Command

I would like to work on this

Unfortunately, this would not be a trivial change.  The specified strictmode version would have to be communicated to the target, where it can be applied to the runspace being created in the remote session there.  But this means updating the remoting protocol, which means gaining approval, updating the protocol version, documentation, and handling down level (non-supported) cases.

This is not the first time that we talk about the fact that PSRP needs to be extended.
If we think about implementing new remoting subsystem why not think about PSRP enhancing, new transport like gRPC, and fallback to WinRM and old PSRP version?

Updating the protocol is an arduous undertaking, and we need to maintain compatibility with WindowsPowerShell, so I feel we need to have very strong reasons for doing it.  Maybe we can keep a collection of improvements that require protocol update and at some point we update the protocol when the benefits justify the effort.

The new remoting subsystem should definitely allow not only different transport but protocol versions too. :-)

Uh! 5 years to implement :-)

source: gharchive/issue

authors: PaulHigin faraazahmad iSazonov jpsnover

repo: PowerShell/PowerShell

license: MIT

license_type: permissive

license_source: github-api


text:
Pasting in reverse with right-click

Steps to reproduce
Copy text with LF line endings and paste into console with right-click
Expected behavior
Text is pasted in its original order
Actual behavior
Text is pasted in reverse
Environment data
Windows 10 Enterprise 10.0.15063

> $PSVersionTable
Name                           Value
----                           -----
PSVersion                      5.1.15063.296
PSEdition                      Desktop
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}
BuildVersion                   10.0.15063.296
CLRVersion                     4.0.30319.42000
WSManStackVersion              3.0
PSRemotingProtocolVersion      2.3
SerializationVersion           1.1.0.1

I have been able to reproduce this on every machine I've tried on and it appears to exist in PowerShell v6.0.0-alpha.17 Release as well. This doesn't seem to happen with a ctrl+v paste.

I didn't get this to repro with beta1, but does repro with Windows PowerShell 5.1.  At this time we're only taking critical security fixes for 5.1.

This is https://github.com/lzybkr/PSReadLine/issues/496

Was this ever actually fixed?  I am on PowerShell 7.0.0 and still see this issue.  In my scenario, I have some PowerShell scripts documented in Confluence as part of developer on-boarding.  Confluence saves all documentation with LF and so when I paste a script from Confluence into PowerShell, it reverses the whole script.
In addition, I tried running Update-Module PSReadLine based on @lzybkr  saying this is a PSReadLine issue, and I got the following error:
PS D:\Users\John.Zabroski> update-module PSReadLine
Update-Module: Module 'PSReadLine' was not installed by using Install-Module, so it cannot be updated.

I see that the official issue now is https://github.com/PowerShell/PSReadLine/issues/579 and it is not fixed.

authors: SteveL-MSFT jzabroski lzybkr tylorhl


text:
PowerShell Classes Typesafe?

Steps to reproduce

class Rock {
    [string]$Color
    [string]$Luster
    [string]$Shape
    [string]$Texture
    [string]$Pattern
    [string]$Size
    [int]$Location
    }

$rock = [rock]::New()
$rock.Color = 1

Expected behavior
Error Message that Color is of Type String and not of type int

Actual behavior
Color    : 1
Luster   :
Shape    :
Texture  :
Pattern  :
Size     :
Location : 0

Environment data

> $PSVersionTable
Name                           Value
----                           -----
PSVersion                      6.0.1
PSEdition                      Core
GitCommitId                    v6.0.1
OS                             Microsoft Windows 10.0.17093
Platform                       Win32NT
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}
PSRemotingProtocolVersion      2.3
SerializationVersion           1.1.0.1
WSManStackVersion              3.0

Additional Information
If I try to set the Location Variable with a string, It does the right thing.
class Rock {
    [string]$Color
    [string]$Luster
    [string]$Shape
    [string]$Texture
    [string]$Pattern
    [string]$Size
    [int]$Location
    }

$rock = [rock]::New()
$rock.Location = "Test"

Error Message:
Exception setting "Location": "Cannot convert value "Test" to type "System.Int32". Error: "Input string was not in a correct format.""
At line:12 char:1
+ $rock.Location = "Test"
+ ~~~~~~~~~~~~~~~~~~~~~~~
+ CategoryInfo          : NotSpecified: (:) [], SetValueInvocationException
+ FullyQualifiedErrorId : ExceptionWhenSetting

Is this normal or am I doing something wrong?

PowerShell is a shell and like many shells it performs some automatic type transformations for the user.
[int]$Int = "5"
$Int
[string]$String = 6.00
$string
[string]$String = 6
$string

5
6
6

Do we need strict typing in strict mode?

@iSazonov I don't thinks so. IMO, the nature of PowerShell is to handle many automatic type conversions. I think any attempt to take that away would just make PowerShell a thin wrapper for .NET. It would look more like Object Oriented Programming and less like command driven shell. the type conversions happen in so many places that users would find an option like that makes PowerShell very foreign. For example, so many parameters Enums and PowerShell handles the String to Enum conversion.
So, unless there was some way to limit it to just assignment operations, it wouldn't be a good idea, IMO. But, I'm not sure I see the value of doing it in the first place.

OK. Thank you for the information. In my opinion you can close the issue.

authors: constantinhager iSazonov markekraus


text:
Make PS-Committee reviewed experimental features stable

PR Summary
Each commit makes a feature non-experimental (although one extra due to my filter only looking at .cs files initially...).  Removed the advertising of the experimental feature and any code and tests that checked that the feature is enabled.
To avoid the headache of merge conflicts, I'm submitting this as a single PR.
PR Context
Fix https://github.com/PowerShell/PowerShell/issues/15862
PR Checklist

[x] PR has a meaningful title

Use the present tense and imperative mood when describing your changes

[x] Summarized changes
[x] Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
[x] This PR is ready to merge and is not Work in Progress.

If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.

Breaking changes

[x] None
OR
[ ] Experimental feature(s) needed

[ ] Experimental feature name(s):

User-facing changes

[ ] Not Applicable
OR
[x] Documentation needed

[x] Issue filed: https://github.com/MicrosoftDocs/PowerShell-Docs/issues/7917

Testing - New and feature

[ ] N/A or can only be tested interactively
OR
[x] Make sure you've added a new test if existing tests do not effectively test the code changed

Tooling

[x] I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
OR
[ ] I have considered the user experience from a tooling perspective and opened an issue in the relevant tool repository. This may include:

[ ] Impact on PowerShell Editor Services which is used in the PowerShell extension for VSCode
(which runs in a different PS Host).

[ ] Issue filed:

[ ] Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features.

[ ] Issue filed:

[ ] Impact on PSScriptAnalyzer (which provides linting & formatting in the editor extensions).

[ ] Issue filed:

[ ] Impact on EditorSyntax (which provides syntax highlighting with in VSCode, GitHub, and many other editors).

[ ] Issue filed:

CodeQL issue appears to have been fixed recently by GitHub in their action: https://github.com/github/codeql-action/commit/a00769bdfb6706a7400db6aa98570597be644555#diff-5bd808ec74194675da6319beb80c228163039f26c9ddf1b8bf3eef9b12c9341bR490

source: gharchive/pull-request


text:
Clone 1000 commits on Travis CI

The previous failure we saw was because the most recent annotated tag did not exist in the previous 50 commits. In my experience we've gone about ~300 commits between tags, so I believe 1000 to be safe, but know 100 will not be.
We should continue to use git describe because it encodes both the most recent version and the exact commit past it where it's built.
Resolves #2029.
Finding out right now from Travis CI if it's possible to completely disable shallow cloning.

Hi @andschwa, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

It looks like you're a Microsoft contributor (Andy Schwartzmeyer). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;

authors: andschwa msftclas


text:
Throw error message when MaxumimVersion is less than Version when using Import-Module cmdlet with -FullyQualifiedName parameter.

PR Summary
Fix #7337
Also fixing following error message to include 'MaximumVersion' in the list of 'valid members':
  <data name="InvalidModuleSpecificationMember" xml:space="preserve">
    <value>The hashtable describing a module contains one or more members that are not valid.  The valid members are ({0}). Remove the members that are not valid ({1}), then try again.</value>
  </data>

Concerning if the change is breaking, I would refer it to Unlikely Grey Area.
PR Checklist

[x] PR has a meaningful title

Use the present tense and imperative mood when describing your changes

[x] Summarized changes
[ ] Change is not breaking
[x] Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
[x] This PR is ready to merge and is not Work in Progress.

If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready.

User-facing changes

[x] Not Applicable
OR
[ ] User-facing Documentation needed

[ ] Issue filed - Issue link:

Testing - New and feature

[ ] Not Applicable or can only be tested interactively
OR
[x] Make sure you've added a new test if existing tests do not effectively test the code changed

[ ] Add [feature] if the change is significant or affects feature tests

@daxian-dbw @SteveL-MSFT please evaluate if this technically breaking (however unlikely) change has to go to PS Committee for review.

@PowerShell/powershell-committee agrees this is a breaking change.  For example using this in a pipeline would terminate the pipeline now whereas a $null being returned would not execute the rest of the pipeline.  We agree that this should have been an error and would accept returning a non-terminating error and not a terminating one.

Can you guide me a little bit?
How can I use WriteError in there?
https://github.com/PowerShell/PowerShell/blob/321537c6e52b24e9187afd267bb0b18b242bbed3/src/System.Management.Automation/engine/Modules/ModuleSpecification.cs#L167-L172
Or is there another way to return non-terminating error?

@sethvs I took a look at the code.  Since the validation is in the ModuleSpecification class that should continue to return an exception that gets thrown.  You'll probably need to update GetModuleCommand.cs to handle this specific case.

@SteveL-MSFT is it possible for a parameter binding exception to be non-terminating? The error when called with Get-Module will occur when the hashtable is cast to a ModuleSpecification; execution will never reach Get-Module.

Also for reference, here is Import-Module's version check:
https://github.com/PowerShell/PowerShell/blob/c94fc31f9767fe5bc835ee4921896b6331eaad4d/src/System.Management.Automation/engine/Modules/ImportModuleCommand.cs#L1686-L1690
I think that's a terminating error, no?

Is this OK with VSTS: PowerShell-CI-macos?

Close and reopen to restart tests.

@PowerShell/powershell-committee re-reviewed this.  The conclusion is that well-formed filters should return nothing if the result set is nothing and not return an error.  In this case, the filter is well-formed, although invalid.  Since this is also a breaking change, our recommendation is to not take this change as it's inconsistent with the desired filtering behavior and introduces a breaking change.

authors: SteveL-MSFT anmenaga rjmholt sethvs


text:
Update-ModuleManifest converts empty array @() to asterisk '*'

Steps to reproduce

create a module manifest with default values for CmdletsToExport, and AliasesToExport

snippet from foo.psd1:
# Cmdlets to export from this module, for best performance, do not use wildcards and do not delete the entry, use an empty array if there are no cmdlets to export.
CmdletsToExport = @()

# Variables to export from this module
VariablesToExport = '*'

# Aliases to export from this module, for best performance, do not use wildcards and do not delete the entry, use an empty array if there are no aliases to export.
AliasesToExport = @()

update an unrelated field

Update-ModuleManifest -Path ./foo.psd1 -Prerelease 'foo'

Expected behavior
snippet from updated foo.psd1 remains the same:
# Cmdlets to export from this module, for best performance, do not use wildcards and do not delete the entry, use an empty array if there are no cmdlets to export.
CmdletsToExport = @()

# Variables to export from this module
VariablesToExport = '*'

# Aliases to export from this module, for best performance, do not use wildcards and do not delete the entry, use an empty array if there are no aliases to export.
AliasesToExport = @()

Actual behavior
snippet from updated foo.psd1 has modified values for CmdletsToExport and AliasesToExport:
# Cmdlets to export from this module, for best performance, do not use wildcards and do not delete the entry, use an empty array if there are no cmdlets to export.
CmdletsToExport = '*'

# Variables to export from this module
VariablesToExport = '*'

# Aliases to export from this module, for best performance, do not use wildcards and do not delete the entry, use an empty array if there are no aliases to export.
AliasesToExport = '*'

Environment data
Name                           Value
----                           -----
PSVersion                      6.2.2
PSEdition                      Core
GitCommitId                    6.2.2
OS                             Darwin 18.7.0 Darwin Kernel Version 18.7.0: Thu Jun 20 18:42:21 PDT 2019; root:xnu-4903.270.47~4/RELEASE_X86_64
Platform                       Unix
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0…}
PSRemotingProtocolVersion      2.3
SerializationVersion           1.1.0.1
WSManStackVersion              3.0

Workaround is to use Update-ModuleManifest -Path $ModuleManiFestPath -AliasesToExport @($null) -FunctionsToExport @($null) -CmdletsToExport @($null).
However -VariablesToExport @($null) wont work since VariablesToExport parameter have the attribute [ValidateNotNullOrEmpty()] which Aliases, Functions and Cmdlets does not have.
My suggestion is to remove the attribute [ValidateNotNullOrEmpty()] from the VariablesToExport parameter and add "-or $VariablesToExport -is [array]" to the if($VariablesToExport) to better align with how Aliases, Functions and Cmdlets to export works.
Thumbs up if you want a Pull Request with this.

authors: PhilipHaglund eedwards-sk

repo: PowerShell/PowerShellGet


text:
SPSearchMetadataCategory

Pull Request (PR) description
New Resource to allow for the creation of new Search Metadata Categories
This Pull Request (PR) fixes the following issues
N/A
Task list

[x] Added an entry under the Unreleased section of the change log in the CHANGELOG.md.
Entry should say what was changed, and how that affects users (if applicable).
[x] Resource documentation added/updated in README.md in the resource folder.
[x] Resource parameter descriptions added/updated in schema.mof
and comment-based help.
[x] Comment-based help added/updated.
[x] Localization strings added/updated in all localization files as appropriate.
[x] Examples appropriately added/updated.
[x] Unit tests added/updated. See DSC Resource Testing Guidelines.
[x] New/changed code adheres to DSC Resource Style Guidelines and Best Practices.

This change is

@ykuijs AppVeyor didn't kick on that one either....

There are issues with GitHub: https://status.github.com/messages

Codecov Report

Merging #933 into v3.0-development will increase coverage by <1%.
The diff coverage is 100%.

@@                Coverage Diff                @@
##           v3.0-development    #933    +/-   ##
=================================================
+ Coverage                92%     92%   +<1%
=================================================
  Files                   111     112     +1
  Lines                 10931   10978    +47
  Branches                  1       1
=================================================
+ Hits                  10091   10138    +47
  Misses                  839     839
  Partials                  1       1

Why do you want to merge this to the v3.0 branch? A new resource can be merged into Dev, right?

Yep, just wasn’t sure what would be simpler. It doesn’t have to be included right now
Nik Charlebois
Senior Premier Field Engineer
613-790-2331

From: Yorick Kuijs notifications@github.com
Sent: Monday, October 22, 2018 5:30:42 PM
To: PowerShell/SharePointDsc
Cc: Nik Charlebois; Author
Subject: Re: [PowerShell/SharePointDsc] SPSearchMetadataCategory (#933)
Why do you want to merge this to the v3.0 branch? A new resource can be merged into Dev, right?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FPowerShell%2FSharePointDsc%2Fpull%2F933%23issuecomment-431995311&data=02|01|Nik.Charlebois%40microsoft.com|86f000d234d6455d940e08d638659f19|72f988bf86f141af91ab2d7cd011db47|1|0|636758406444151457&sdata=oE1oQTzHhQVoGPRFNpkoVtF0BhpZrcKYnfU4YKfW0ys%3D&reserved=0, or mute the threadhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FACbdzYY4hvFRFC7cGzAMSEgdrD2U0Xxuks5unjkCgaJpZM4XzbjJ&data=02|01|Nik.Charlebois%40microsoft.com|86f000d234d6455d940e08d638659f19|72f988bf86f141af91ab2d7cd011db47|1|0|636758406444151457&sdata=KfmO1a%2Fq%2Fu3Rs2rjORasvYV4Uet0zGC64t%2FSCUJR020%3D&reserved=0.

authors: NikCharlebois codecov-io ykuijs

repo: PowerShell/SharePointDsc


text:
Add files via upload

New install.json in .tar.gz file.
WHM 58 has an error with processing name strings where if it contains an apostrophe, it doesn't process the string and results in $LANG{'Let'sEncrypt'} being displayed in the customer cPanel. WHM 56 did not have this issue.
Changing install.json name attribute to use the HTML code for this name resolves the issue;
[
{
"icon":"letsencrypt.png",
"featuremanager":true,
"name":"Let'sEncrypt",
"uri":"/3rdparty/letsencrypt-cpanel-ui/index.live.pl",
"group_id":"security",
"order":"9",
"id":"letsencrypt",
"type":"link"
}
]
No other changes made to the .tar.gz file or it's contents. Tested and confirmed working on our production server.
-KP

Thank you for the PR. This will the issue #78

authors: Prajithp k-poole

repo: Prajithp/letsencrypt-cpanel

license: mit

license_source: bigquery


text:
SQL execution failed column "starttime" does not exist

Trying to use LEventStore.find specifying startTime and untilTime, but I am getting the following error:
 [ERROR] [StatementExecutor$$anon$1] SQL execution failed (Reason: ERROR: column "starttime" does not exist  Position: 305):
Looking at the logged select statement, it does containt startTime and even endTime:
10-18 00:00:00.0' and endTime < '2014-10-19 00:00:00.0' and entityType = 'GeoZone' and entityId = '56537' and event = 'open' and targetEntityType = 'Count' order by eventTime asc```

This is not inline with the schema of the events table (luckily I am currently testing out using PostgreSQL) where the only column is ```eventTime```

I forgot to mention that I am using the PredictionIO from the AWS as marketplace

What Template?
On Oct 26, 2015, at 8:41 AM, Younes Abouelnagah notifications@github.com wrote:
I forgot to mention that I am using the PredictionIO from the AWS as marketplace
—
Reply to this email directly or view it on GitHub https://github.com/PredictionIO/PredictionIO/issues/162#issuecomment-151178225.

I started with the vanilla, but changed it a lot by now.
http://corp.flipp.com
Younes Abouelnagah
Sr. Data Science Engineer
Flipp Corporation
p: 416-668-3423
e: younes.abouelnagah@flipp.com
On Mon, Oct 26, 2015 at 11:56 AM, Pat Ferrel notifications@github.com
wrote:

What Template?
On Oct 26, 2015, at 8:41 AM, Younes Abouelnagah notifications@github.com
wrote:
I forgot to mention that I am using the PredictionIO from the AWS as
marketplace
—
Reply to this email directly or view it on GitHub <
https://github.com/PredictionIO/PredictionIO/issues/162#issuecomment-151178225

.

—
Reply to this email directly or view it on GitHub
https://github.com/PredictionIO/PredictionIO/issues/162#issuecomment-151182057
.

--
IMPORTANT NOTICE:  This message, including any attachments (hereinafter
collectively referred to as "Communication"), is intended only for the addressee(s)
named above.  This Communication may include information that is
privileged, confidential and exempt from disclosure under applicable law.
If the recipient of this Communication is not the intended recipient, or
the employee or agent responsible for delivering this Communication to the
intended recipient, you are notified that any dissemination, distribution
or copying of this Communication is strictly prohibited.  If you have
received this Communication in error, please notify the sender immediately
by phone or email and permanently delete this Communication from your
computer without making a copy. Thank you.

Also, I see that you have fixed that in version 0.9.5 (
https://github.com/PredictionIO/PredictionIO/blob/v0.9.5/data/src/main/scala/io/prediction/data/storage/jdbc/JDBCLEvents.scala#L149)
but the AWS marketplace is still at 0.9.4 with the bug (
https://github.com/PredictionIO/PredictionIO/blob/v0.9.4/data/src/main/scala/io/prediction/data/storage/jdbc/JDBCLEvents.scala#L149
)
http://corp.flipp.com
Younes Abouelnagah
Sr. Data Science Engineer
Flipp Corporation
p: 416-668-3423
e: younes.abouelnagah@flipp.com
On Mon, Oct 26, 2015 at 11:57 AM, Younes Abouelnagah <
younes.abouelnagah@flipp.com> wrote:

I started with the vanilla, but changed it a lot by now.
http://corp.flipp.com
Younes Abouelnagah
Sr. Data Science Engineer
Flipp Corporation
p: 416-668-3423
e: younes.abouelnagah@flipp.com
On Mon, Oct 26, 2015 at 11:56 AM, Pat Ferrel notifications@github.com
wrote:

What Template?
On Oct 26, 2015, at 8:41 AM, Younes Abouelnagah notifications@github.com
wrote:
I forgot to mention that I am using the PredictionIO from the AWS as
marketplace
—
Reply to this email directly or view it on GitHub <
https://github.com/PredictionIO/PredictionIO/issues/162#issuecomment-151178225

.

—
Reply to this email directly or view it on GitHub
https://github.com/PredictionIO/PredictionIO/issues/162#issuecomment-151182057
.

--
IMPORTANT NOTICE:  This message, including any attachments (hereinafter
collectively referred to as "Communication"), is intended only for the addressee(s)
named above.  This Communication may include information that is
privileged, confidential and exempt from disclosure under applicable law.
If the recipient of this Communication is not the intended recipient, or
the employee or agent responsible for delivering this Communication to the
intended recipient, you are notified that any dissemination, distribution
or copying of this Communication is strictly prohibited.  If you have
received this Communication in error, please notify the sender immediately
by phone or email and permanently delete this Communication from your
computer without making a copy. Thank you.

Yes, we need to update the AWS Marketplace. Not so easy unfortunately a manual process--argh.

opened new issue #190 for us to update AWS, closing this one as fixed in 0.9.5

repo: PredictionIO/PredictionIO


text:
JAM-6 : Added filterAccessControl function in jcontroller

I used this signin.php controller file for testing.

<?php
class Controller_signin extends pController
{
    protected function accessRules(){
        return [

            'admission' => 'canAdminAccess',
            'login' => 'canUserAccess',

        ];

    }

    // test-cases
    public function action_index()
    {
        echo 'asdf';
    }
    public function action_admission()
    {
        echo 'should be accessed';
    }

    public function action_login()
    {
        echo 'should not be accessed';
    }

    public function canAdminAccess()
    {
        return true;
    }

    public function canUserAccess()
    {
        return false;
    }
}

Can you kindly elaborate on the comment about adding parameters to the access control methods? An example will be very much helpful.

This is the new signin.php controller file after recoding the jController.
It uses different cases such as:

When the method is present in the controller (using $this)
When the method is present in a different controller.
When there are parameters available and not.
When there are actions, methods and parameters are defined and not defined.

<?php
class Controller_signin extends pController
{
    protected function accessRules() : array
    {
        return [
            'login' => ['Controller_signin::canUserAccess','params' => ['mario','luigi'],'message'=> 'User Message'],
            // 'login' => [$this, 'canUserAccess','params' => ['mario', 'luigi']],
            'admission' => ['Controller_signin::canUserAccess','params' => ['mario', 'luigi'], 'message' => 'Error 101'],
            '*' => ['Controller_signin::canAdminAccess','params' =>['phinneas','ferb']],
            // 'general' => ['Controller_homepage::canUserAccess', 'params' => ['admin', 'user-management']],

        ];
    }

    // test-cases
    public function action_index()
    {
        echo 'Index Accessed';
    }

    public function action_admission()
    {
        echo 'should be accessed';
    }

    public function action_login()
    {
        echo 'should not be accessed';
    }

    public function action_general()
    {
        echo 'hi, I have the general access';
    }
    public static function canAdminAccess($params)
    {
        print_r($params);
        return true;
    }

    public static function canUserAccess()
    {
        return false;
    }
}

repo: Prepmock/jambura-core


text:
reviewed README

Rewording
Added links when available
Reviewed english part

PS: non, je ne fais pas de PrestaShop (désolé ^^)

Merci @mickaelandrieu !

thanks @mickaelandrieu :)

authors: PrestaSafe jf-viguier mickaelandrieu

repo: PrestaSafe/prettyblocks


text:
Possible Security Risk: nsec appears to have been retained after Primal App deletion on iOS.

Description
I was testing another issue. To make sure that issue wasn't caused by a persistent app/data state I deleted the Primal app from my device. I installed the Primal iOS app again from the App Store. Then, upon launching the app, I was surprised to be already logged in with my nsec.
Steps to reproduce
Log into app.
Delete app and data.
Install app.
Open app.
Successfully reproduced if your logged in state has persisted.
Expected Behavior
I would have expected to have to log back in due to App deletion clearing my nsec upon Delete App completion.
Environment
iPhone 15 Pro (MTU53LL/A)
Fresh upgrade to iOS 18.1.1
Fresh re-install of Primal v2.0.114
Fresh reboot of device after delete/install of Primal App
Additional Behavior Notes
In the "Delete App" dialogue upon deletion of the Primal App from iOS, the options are given to "Delete App", "Remove from Home Screen", and "Cancel". For this issue to occur I did select Delete App, so it was not expected that any data would persist related to the application. I would however, expect data to persist, which could include session key retention, if I had selected "Remove from Home Screen".

I can confirm reproducibility on my device.
iOS 18.1.1
iPhone 12 Pro

This is not a bug, and it's not a security issue. When you select delete app, the app code doesn't know the app is being deleted and no app code is being executed.
Because we are storing the nsec securely in apple keychain, it doesn't get deleted when the app gets deleted, but it is stored as securely as any other app login info that is stored in apple keychain.
There is no way to automatically delete keychain data when the app is being deleted, that is handled by the system, and in some earlier versions of iOS it was being automatically deleted.
If you want the keychain to be removed from the device, just log out of the app before deleting it.

There is no trigger to perform code when the app is deleted from the device. Access to the keychain is dependant on the provisioning profile that is used to sign the application. Therefore no other applications would be able to access this information in the keychain.

authors: PavleKreator amunrarara swbratcher

repo: PrimalHQ/primal-ios-app


text:
As a content editor, I want the option of a display title for use in the timetree so that I can use different titles in the leaf detail view and in the tree.

dev notes

[x] update parse script to look for display title field
[x] update json template to include display title in data used for the timetree
[x] update tree logic to use display title first if set (full title as fallback)

implemented in #99

repo: Princeton-CDH/lenape-timetree


text:
unpin wagtail dependency

test upgrading wagtail to latest.

from wagtail docs for 2.4:

Removed support for Django 1.11
Django 1.11 is no longer supported in this release; please upgrade your project to Django 2.0 or 2.1 before upgrading to Wagtail 2.4.

repo: Princeton-CDH/mep-django


text:
Improve deployment process and docs

[ ] Review Django Deployment Checklist
[ ] Update this issues with specific steps as needed
[ ] Document deployment steps to serve as a guide for production and future automation with ansible

Basic deployment process at https://nplcadmindocs.princeton.edu/index.php/TraceBase#Deployment_Process. This should be improved for the next cycle.

Note, I added:
https://nplcadmindocs.princeton.edu/index.php/TraceBase#TraceBase_Documentation

Note, I added:
https://nplcadmindocs.princeton.edu/index.php/TraceBase#TraceBase_Documentation

Thanks @hepcat72. I would suggest that we keep that sort of documentation together with the code in the repository. I'd like to keep as much in GitHub along with the code as possible. Only Princeton specific things should really need to be in the NPLCAdmin docs (e.g. server addresses, file paths, apache configs, etc.)

Note, I added:
https://nplcadmindocs.princeton.edu/index.php/TraceBase#TraceBase_Documentation

Thanks @hepcat72. I would suggest that we keep that sort of documentation together with the code in the repository. I'd like to keep as much in GitHub along with the code as possible. Only Princeton specific things should really need to be in the NPLCAdmin docs (e.g. server addresses, file paths, apache configs, etc.)

I had trouble finding information about the docs deployment and my instinct was to look where the other deployment info was (in nplcadmin), but I tried not to duplicate the info in the repo - just create a reference to it (aside from the brief summary), since it had taken me awhile to discover it was where it was. I didn't know that it even existed, so I think referencing it in nplcadmin is appropriate, though I generally agree with you where it should live.


text:
Tests: Additional checks for Prism functions

This adds some additional checks for the inputs of some Prism functions.
They work by replacing a function to test with another function calling both the test code and the original function.
This allows us to add complex checks without adding weight to Prism core.
Right now, I added checks for Prism.languages.extend and Prism.languages.insertBefore.

This resolves #1717.

This feels really hacky but it even gets us IDE support.
I added a pseudo require.

repo: PrismJS/prism


text:
Error when connecting to aternos server

Can you please attach console logs?

Closing due to lack of response from user.

authors: AwesomestCode KogutGaming

repo: PrismarineJS/prismarine-web-client


text:
Space War Game

My name is Anurag Mukherjee, a participant of Hacktober Fest'21.
Aim
A space war game made purely with python.
Details
Rules and features of the game:

There is a Spaceship, which is the main hero of the game.
You can control the hero using the left and right arrow keys in your keyboard.
Press space bar to shoot the enemies.
Each time you shoot an enemy, your score will increase by 1.
If the enemy touches you, the game will be over.

Modules will be used in this script:-

pygame
mixer from pygame
random
math

Preview of this game

I will write clean and easy to understand code. Please assign this issue to me.

@anuragmukherjee2001 PR this project


text:
Map Plot Error

Hello,
I'm having trouble while trying to plot a map. I'm using a switch function and I get an error that the calculated unit is "unitless", but I'm checking all terms separately and the units are correct. MY assumption is that there is a bug when plotting a map with a switch function. See image:

Thanks.

This certainly is not related to $Map. It occurs somewhere in the function. I can see that you have two switch cases "<" and "≡". It is not clear what happens when it is ">". My advice is always to have a "default" case - a final expression without check before it.

Thanks. That was the problem. Although my "y" is varying from 0...L, the function needs a general rule. When I fixed this, it worked fine.

authors: Proektsoftbg murilo-s

repo: Proektsoftbg/Calcpad


text:
Decode a Morse code message

Ruby :gem:

Run a program using the IRB command line.
Use Ruby syntax for basic programming operations.
Use Ruby to solve Morse code coding challenge.

Project Status: INVALIDATED :red_circle:
Hi @ProgramKingAbel , @derrick1451 and @sahlminkok ,
While you made a great effort in this project, I can't go ahead and review your code.

Invalid Code Review Request

This is because you have submitted a project, that is missing some of the sections of the Microverse README Template. This makes your project incomplete as every section of the readme template is required except for the FAQ section which is optional. So please make sure to add all the missing headers/sections in the README template to your project and fill in all the necessary contents :+1:

Your Code Review Request will be marked as invalid in your Dashboard, so please submit a new one once you are ready 🙏
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me @NahnahAJ in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

Invalid Code Review Request does not count into the code reviews limit.

authors: NahnahAJ ProgramKingAbel

repo: ProgramKingAbel/morse-message


text:
"Stay on" when continuing on the same road

Along the same lines as #30, it would be nice if we could say "Keep left to stay on Main St" if Main St. is the street both before and after the fork in the road.
/cc @freenerd @bsudekum @mayagao

Isn't this the purpose of the continue maneuver type? If not, what is the continue maneuver type for?
The OSRM docs say:
continue | Turn in direction of modifier to stay on the same road

I'm perplexed by the continue maneuver. Based on what the docs say about "staying on the same road", I'd expect both of these to be continue because they both involve staying on the same road:

Continue left onto South Airport Boulevard

Confusing because this feels like a left turn
Ideal instruction would be "Turn left to stay on South Airport Boulevard"

Keep right at the fork onto I 395

Confusing because this is staying on the same road (I'm already on I 395
Ideal instruction would be "Keep right at the fork onto I 395"

Does continue make sense as a maneuver type or is it a flag that belongs on all other maneuver types to indicate when a road is staying the same?
/cc @MoKob

Here's another example:

We get a "Continue right onto Marsh Road"
Then we get a "Turn left onto Marsh Road"

Why is the first one a continue and second a turn?

Why is the first one a continue and second a turn?

This is a bug that should be fixed in https://github.com/Project-OSRM/osrm-backend/pull/4400, but is not yet deployed.
Per voice with @daniel-j-h, the next action is to adjust the phrasing in our continue instructions to be more smooth. For example, instead of Continue slightly right onto {way_name} it should be Turn slightly right to stay on {way_name}.
This is immediately actionable and we should do this now.
However, I don't see how this will address the original fork case described in the OP. fork and continue are both maneuver types, but you can have a fork that continues. How we do handle that case? This leads me back to my original question:

Does continue make sense as a maneuver type or is it a flag that belongs on all other maneuver types to indicate when a road is staying the same?

This would allow any instruction to be rephrased with "stay on" instead of "onto" which is confusing when you're already on the road in question.

Here's an example of a fork instruction where the name is staying the same:
https://www.mapbox.com/get-directions/#16/36.9879/-122.0236?coordinates=-122.022312,36.989434;-122.02360473016304,36.987874443471256
Since this isn't a continue, I'm not sure we have enough information to make this instruction read "Keep right at the fork to stay on CA 1".

Next action is to improve whatever we can by rephrasing continue instructions to use "stay on" language.
Unless, I'm missing something we might need some fixes upstream in OSRM in order to support fork instructions that continue on the same road.

@willwhite are these the instructions you are saying need to be changed?
https://github.com/Project-OSRM/osrm-text-instructions/blob/master/languages/translations/en.json#L82
https://github.com/Project-OSRM/osrm-text-instructions/blob/master/languages/translations/en.json#L87

@willwhite in making this change I noticed a couple test failures worthy of additional consideration:

https://github.com/Project-OSRM/osrm-text-instructions/pull/142 is a big improvement but the instructions will still be bad for some of the example routes.

Will be "Continue left to stay on South Airport Boulevard" but should be "Turn left to stay on South Airport Boulevard"
Will be "Continue right to stay on Marsh Road" and "Continue left to stay on Marsh Road" but should be "Turn right to stay on Marsh Road" and "Turn left to stay on Marsh Road"

Thoughts on changing the "Continue" to "Turn" ?

authors: 1ec5 lyzidiamond mcwhittemore willwhite

repo: Project-OSRM/osrm-text-instructions


text:
:bug: Make app versions consistent

Closes #13 .

Cargo.toml and package.json versions are different, otherwise LGTM

package.json and Cargo.toml "version" keys are different, one is 0.3.0 and the other is 0.2.0. Otherwise, LGTM

Thanks for pointing out

package.json and Cargo.toml "version" keys are different, one is 0.3.0 and the other is 0.2.0. Otherwise, LGTM

Thanks for pointing out

repo: ProjectBlackPearl/pbpl


text:
Create "Essential Data" Task

Should handle data from Accels and Gyro
Functionality currently in sensor task

@tym0027

repo: ProjectKarman/avionics-firmware


text:
Fix website generation

This was working a while ago (in testing), but doesn't appear to now
https://github.com/naev/naev-website/pull/11
Offending run:
https://github.com/naev/naev-website/pull/11/checks?check_run_id=1756147403

Seems there is something wrong with running the optipng ruby stuff in docker..
Doesn't appear to be fixable.


text:
EventFiringOption and Target error

Hello,
I have downloaded the available build and tried to build the same ,but seeing the below error ,while building it.
1.Error	167	'ProtoTest.Golem.WebDriver.EventFiringWebDriver.EventFiringOptions' does not implement interface member 'OpenQA.Selenium.IOptions.Logs'

2.Error	168	'ProtoTest.Golem.WebDriver.EventFiringWebDriver.EventFiringTargetLocator' does not implement interface member 'OpenQA.Selenium.ITargetLocator.ParentFrame()'

The same error appeared.

Did you find a resolution to the problem ?

Same here, I have been unable to find a resolution.

Use the golem v2 branch temporarily.
On Jun 7, 2016 10:27 PM, "Matt Stannett" notifications@github.com wrote:

Same here, I have been unable to find a resolution.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/ProtoTest/ProtoTest.Golem/issues/22#issuecomment-224484024,
or mute the thread
https://github.com/notifications/unsubscribe/AAph_0Qg0ZZ4SH7mdp-fAfASW4RPLGDBks5qJkSVgaJpZM4Hb-4s
.

authors: BeigeBadger RollerIn aprajitamathur bkitchener1 oleg-zaporozhets


text:
lawnicons: Dynamically track all our icons [1/2]

It's a lot of hassle to maintain a different fork of icons which needs to be manually updated every few days. This will track icons directly from Lawnchair's repos so that the icons are automatically updated whenever lawnchair merges new icons.

Looks good!

Looks Fine.

Closing this due to inactivity and a lack of response.

Sorry, I didn't get a chance to look into this until now. I like the idea to auto-update Lawnicons as I've been forgetting to do it, but this results in unreproducible builds (i.e. same version will have different icons depending on when it was synced). Perhaps auto-updating it but still keeping it as a fork would be better.


text:
rename-sequence command

Implement command to rename a sequence.
rename-sequence <admin-key> <name> <new-name>

I don't think this is necessary. It's just unnecessary work, probably. Or I guess, leave the issue open, but don't implement it. There are more important things.

Fair enough. If we feel we want/need it, then it should be a quick add.

repo: ProtonLights/cli


text:
mailto links not parsing encoded characters, not parsing parameters at all on Android app

Browser + version? Firefox 61.0.1, Edge 42.17692.1004.0
OS + version? Windows / Android
Can you reproduce the problem each time? Yes

What steps will reproduce the problem?

Create a mailto link with several parameters (address/subject/body etc.)

i.e. mailto:person@example.com?subject=RE:%20Email%20Subject&body=%0D%0A%0D%0A--%0D%0A%20message

Encode characters as needed (spaces to %20 line breaks to %0D%0A etc.)
Send this to a ProtonMail address.
Open the email in the ProtonMail client and hover over/click the link.

What is the expected result?

A new email should open in the composition window, with the expected fields already filled out, and the encoded characters parsed back into their original forms.
This same mailto link works as expected when sent to non-ProtonMail addresses and opened in other clients.

What happens instead?

In Firefox, hovering over the link shows in the link preview that the encoded spaces are parsed as space characters.  In Edge, hovering over the link shows in the link preview the encoded spaces.  In both, the line breaks remain shown as encoded in the preview.  This may not be a ProtonMail issue and instead is a browser thing.  I don't know.
Clicking on the mailto link opens up the composition window.  In Edge, the fields are populated, but the encoded characters are not parsed and converted into their original forms.

In Firefox, the To field is populated with the address, but the subject and body are empty.

The Android client doesn't even seem to try.  Clicking the link just opens up a completely blank email in the composition window.

The fix is coming soon :) Thx for the issue :+1:

authors: dhoko euphemism

repo: ProtonMail/WebClient


text:
Add HSD_MemPiece stub.

Missing actual content but is needed for compilation to proceed.

HSD_MemPiece was renamed to HSD_FreeList, because the original code was incorrect.
Any usages of MemPiece need to be corrected/updated, so I don't want to accept a PR for fixing compilation on the basis of the incorrect code.

Alright, will close and remove this branch then!
Might look into replacing MemPiece with FreeList.

authors: PsiLupan filfat

repo: PsiLupan/FRAY

license: Unlicense


text:
Add permission management

It should be possible to see the current file or directory permissions and update them from within navitron.

Moved to https://github.com/PsychoLlama/navitron.nvim/projects/1


text:
Only auto-scroll terminal on new output when at the bottom

This updates jquery.terminal to version 0.11.22 to enable new (requested) features.
The server terminal now only automatically scrolls when it is scrolled all the way down.
If there is new output that is not visible a small notification appears at the bottom right. A click on it will scroll all the way down.
fixes #153

There are some issues with Chrome currently, I would put this on hold (but keep the PR open) until this is resolved, then i will update this.

With latest addition (d844c41) all Chrome issues on Ubuntu have been resolved. Works flawless.

Perfect. In my opinion it's ready to merge then.

authors: ET-Bent schrej

repo: Pterodactyl/Panel


text:
[主線] [PTT] 實作儲存草稿 - repository

實作細節 / Details of Implement

此為 #61 的子任務
修改 repository.go 與 user.go
因 go-bbs 尚未實作相關功能，可先 mock 一個結構出來儲存草稿，之後實作刪除草稿與取得草稿時可重用這個結構
要回傳 error

期程 / Schedule

討論時間：一週, 到 4/14
實作時間： 一週, 到 4/21
確認時間： 一週, 到 7/28

相關文件 / Documents
API文件

我可以幫忙這個

我可以幫忙這個

OK, 如果有問題的話再到 Slack 或是這邊發問

@weizhe0422  想確認一下目前這個 ISSUE 進度到哪邊了？

我可以幫忙這個，請給我一個禮拜完成

我可以幫忙這個，請給我一個禮拜完成

麻煩你了

authors: PichuChen titaneric wagaru weizhe0422

repo: Ptt-official-app/Ptt-backend


text:
Make side menu for the component pages dynamic (JSON)

For each of the components pages (forms-menu.php, controls-menu.php, content-menu.php, code-patterns-menu.php), create a markup via a JSON file to dynamically load the subsection titles/links for the side menu. This will make adding pages less error prone.  Currently, all of this is hardcoded for each page (see attached photo for example of current code for the Forms menu).

This was done as part of the redesign. Completed.

authors: basiabaldwin zoltan-dulac


text:
Add version that supports all versions of Minecraft

Hi, I'm creating a texture that uses this one and it works, but I use it from 1.20.4 onwards and this project works in one way for 1.20.4 and in another way for 1.20.6, couldn't they be merged?

Yesn't
They can’t be merged but you can always have "overlays", that’s a thing to tell a resource pack (or data pack) to load different files depending on the minecraft version.
Should be quite easy to set up after you’ve read up on the wiki about it.

What wiki?

https://minecraft.wiki/w/Pack.mcmeta

I may add this to NoShadow itself, once I get back to working on it
If you’ve done it and want to open a pull request I’ll merge it

So, I would like to have the rendertype_text_intensity.vsh file working with 1.20.4 and from 1.20.5 onwards, what should I do?

=1.20.5

§a§lʙᴇᴛᴛᴇʀ ѕᴜʀᴠɪᴠᴀʟ§f.zip
<=1.20.4
§a§lʙᴇᴛᴛᴇʀ ѕᴜʀᴠɪᴠᴀʟ§f.zip

Hey?

As I already said, you can do that using overlays, I also linked the wiki page where they are detailed, with that information you can also look for tutorials online.
With "I may add this […] once I get back to working on [NoShadow]" I indirectly said, that I am currently not working on NoShadow, so I will not implement it for you. If you can’t do it yourself, commission someone who knows how to do it or wait for me to implement it, but that will happen at some point in the future if at all.
Also, chill a little, don’t expect people to answer instantly, especially not if you’ve messaged them multiple times through multiple platforms, that is just rude and makes people less willing to help you, maybe something to keep in mind for future interactions.

.

authors: PuckiSilver VentureStudios

repo: PuckiSilver/NoShadow


text:
WebRTC module issue

By implementation WebRtc we have found that the following socket event doesn’t work -->
1)socket.on('appointment:status')
2)socket.on('appointment:messages')
We suppose that the issue is in this part of code on the server in file socket.js -->
1)http://prntscr.com/ibg9dx
2)http://prntscr.com/ibg9j9
3)http://prntscr.com/ibg9os
As the socket event emits doesn’t work, we suppose that the root of issue is in the file db.js, where there is a selection from Database. Could you please check it from your side as it is very important for our work on WEBRTC module.
Here in socket.emit('appointment:messages') --> http://prntscr.com/ibgbcp --> we give the following data for listening on the server, is our structure right?
Currently, these issues block our further work with WebRTC. This is urgent.
Related issue: https://github.com/RippleOSI/Ripple-Qewd/issues/80

ok after discussion with @robtweed, the issues seems to be with the TURN server that WebRTC needs. It appears the server that we had been running this on, has been removed.
see these line in videochat.js
https://github.com/PulseTile-Plugins/Carbon-Plugin-WebRTC/blob/6d140725479116ee5bf33e14426598d4468bde0e/scr/videochat/videochat.js#L107
@anna-otrokhova Can you please ask one of your team to follow these instructions to set up a TURN Server on dev.ripple.foundation as per these ubuntu based instructions
http://docs.pulsetile.com/angular-webRTC.html
Once a turn server is back up and working, according to the testing instructions outlined here... then an update to those lines 103-109 in this file, should get the webRTC system back up and running
https://github.com/PulseTile-Plugins/Carbon-Plugin-WebRTC/blob/6d140725479116ee5bf33e14426598d4468bde0e/scr/videochat/videochat.js

link  to #113

@anna-otrokhova
Please check update on linked issue on Qewd repo & update videochat.js & retest

please revisit this instruction @anna-otrokhova
Once a turn server is back up and working, according to the testing instructions outlined here... then an update to those lines 103-109 in this file, should get the webRTC system back up and running
https://github.com/PulseTile-Plugins/Carbon-Plugin-WebRTC/blob/6d140725479116ee5bf33e14426598d4468bde0e/scr/videochat/videochat.js

@tony-shannon
Thank you very much, Tony. We will check.

@tony-shannon
We have checked. As we can see the credentials mentioned in videochat.js (lines  103-109) are correct to the provided ones by Alexey.
But we still don't get responses to these socket Events appointment:messages, appointment:status
(Though such sockets as init and close work). We suppose that there are some configurations (conditions, limitations) that interfere the correct communication between client and server.
Could you ask Alexey to check it, please?

Please confirm the settings in videochat.js that you are testing against
On 21 Feb 2018 11:41 a.m., "Anna Otrokhova" notifications@github.com
wrote:

@tony-shannon https://github.com/tony-shannon
We have checked. As we can see the credentials mentioned in videochat.js
(lines 103-109) are correct to the provided ones by Alexey.
But we still don't get responses to these socket Events
appointment:messages, appointment:status
(Though such sockets as init and close work). We suppose that there are
some configurations (conditions, limitations) that interfere the correct
communication between client and server.
Could you ask Alexey to check it, please?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/PulseTile/PulseTile-React/issues/115#issuecomment-367300244,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA5X3FB2lCxZeom6b-H_qlzVrHi68Nckks5tXADxgaJpZM4R8-q9
.

@tony-shannon
Here is this part of code that was already configured  in videochat.js http://prntscr.com/ihr8nw
This config is responsible for the window of video chat and that part works.
The settings might be wrong in socket.js file they are responsible for appointment:messages, appointment:status .

suggest you try ip address rather than domain name
see if that helps
T
On 21 February 2018 at 12:20, Anna Otrokhova notifications@github.com
wrote:

@tony-shannon https://github.com/tony-shannon
Here is this part of code that was already configured in videochat.js
http://prntscr.com/ihr8nw
This config is responsible for the window of video chat and that part
works.
The settings might be wrong in socket.js file they are responsible for
appointment:messages, appointment:status .
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/PulseTile/PulseTile-React/issues/115#issuecomment-367308951,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA5X3OkTYtlddDLunMXB8qg9mpfP4xgBks5tXAoSgaJpZM4R8-q9
.

@tony-shannon
Thank you, Tony.
We have tried, but unfortunately, it doesn't work anyway. http://prntscr.com/iht9f8

authors: anna-otrokhova tony-shannon

repo: PulseTile/PulseTile-React


text:
Fix docs

i edited basic.md for good look

More consistent now, Thank you @suprohub

authors: Snowiiii suprohub

repo: Pumpkin-MC/Pumpkin-Website


text:
bean read_device_info does not show Software version

With version 0.3.1:

$ bean read_device_info -a $A1
Found Bean with name/address: /987bf358352b
Connected!
Manufacturer: Punch Through Design
Model Number: Bean+
Hardware Version: 2A
Firmware Version: 201608170000 Img-B
Software Version: Software Revision
Battery Level: 60%
Sketch Name: test3-bean-comditeng
Command completed successfully

I would have expected to see 0.3.1 instead of "Software Revision" ?

Hi @shuckle50
The information shown in this command is about the Bean itself, not the software connecting to it. However, the Bean does not use a software version so the string Software Revision is just hardcoded in the Bean's firmware, for potential use at a later time. I could remove it to avoid confusion.
-Steve

I've removed Software Version from the output for now, will be in next release.

repo: PunchThrough/bean-sdk-node


text:
Feature/data visualization

improve data visualization with image data and realtime timeseries data, initial version built by Peter Timpane

moved to foxglove for data vis. closing..


text:
Bug fix: https://github.com/PwQt/magic-items-2/issues/33

Bug fix : https://github.com/PwQt/magic-items-2/issues/33

Are you sure it works? I've tried it on my local station - it seems that the function is trying to parse a numerical value while it's being given a "string" (i'm not 100% sure what type it is, and that function doesn't work with it)
This way seems to be working:
  static isRealNumber = function (n) {
    return !isNaN(parseFloat(n)) && isFinite(n);
  }

New PR here: https://github.com/PwQt/magic-items-2/pull/35


text:
🛑 Gitea is down

In cf2ea98, Gitea (https://git.pxlbuzzard.com) was down:

HTTP code: 503
Response time: 91 ms

Resolved: Gitea is back up in ad1dde2.

repo: PxlBuzzard/upptime


text:
Encrypting PDF

I would like to work on this issue
Script Title - Encrypting PDF
what will change - It will ecrypt the PDF with a Password
Instructions

Create a new folder for your script and file/folder name should be appropriate.
Create a README.md in your folder for program Instructions
add requirements.txt if needed

Please add/delete options that are not relevant.

[x] Adding New Code

Programming Language

[x] Python

:star2: Star it :fork_and_knife:Fork it :handshake: Contribute to it!
Discord server  - https://discord.gg/FXyh2S3
Happy Coding,

Please Assign me this issue.
I would like to work on this

repo: Py-Contributors/awesomeScripts


text:
Compatibility with flake8 --extend-select

It doesn't work:
% python -m flake8 --select=Y091 tests/raise.pyi
tests/raise.pyi:4:9: Y091 Function body must not contain "raise"
tests/raise.pyi:7:9: Y091 Function body must not contain "raise"
% python -m flake8 --extend-select=Y091 tests/raise.pyi
%

https://flake8.pycqa.org/en/latest/plugin-development/index.html doesn't say anything about creating codes that are disabled by default, so probably there still isn't a native way to do this. In working on #86 I noticed that it's really easy to disable everything else while trying to turn on a disabled-by-default check, so I think it's going to be a better way forward to get rid of the disabled-by-default checks.

There's a comment that says the functionality is "Adapted from flake8-bugbear". We could look at how flake8-bugbear does this, and whether it has the same problems.

Their code is still basically the same: https://github.com/PyCQA/flake8-bugbear/blob/master/bugbear.py#L131.

Here's another idea: You typically want to use the most modern syntax that a specific Python version supports. For example, if you target 3.9+ you can use explicit type aliases, but if you target 3.8+ you can't.
Maybe a better approach would be configuring the python version to target, instead of enabling individual disabled-by-default error codes? Or if that isn't possible, enable everything by default (as if you targeted the latest Python version), and ask users to silence warnings if they support something older too?

Maybe a better approach would be configuring the python version to target

That doesn't make sense for stubs because stubs are mostly independent of Python version. TypeAlias for example should work in all Python versions in stubs (assuming you import it from typing_extensions); the problem is that pytype doesn't support it yet.

authors: Akuli JelleZijlstra


text:
release: 0.14.4

As discussed, backports #1834 to 0.14 line and releases a new version.
I'll put live tomorrow if no objections!

Release is live!


text:
Do not apply deferred ref count updates and prevent the GIL from being acquired inside of traverse implementations.

Closes #2301
Closes #3165

I see you have linked this to https://github.com/PyO3/pyo3/issues/3064, it's not quite clear to me why?

I misunderstood it as one of the symptoms described in #3165 but reading it less tired, that was nonsense. I removed the reference will give bors a try.
bors r=davidhewitt

So this was hit by the same problem that #3171 is trying to fix. I just moved the test case to the 1.63 section for now.
bors retry


text:
[WIP] YoloV5 integration

What does this PR do?
YoloV5 integration - #119
Before submitting

[x] Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
[x] Did you read the contributor guideline, Pull Request section?
[x] Did you make sure your PR does only one thing, instead of bundling different changes together?
[ ] Did you make sure to update the documentation with your changes?
[ ] Did you write any new necessary tests? [not needed for typos/docs]
[ ] Did you verify new and existing tests pass locally with your changes?
[ ] If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

[ ] Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃

Hello @aniketmaurya! Thanks for opening this PR.

In the file flash/image/backbones.py:

Line 215:52: W292 no newline at end of file

Do see the Hitchhiker's guide to code style

closing this one since #408 contains support for YoloV5 as well

repo: PyTorchLightning/lightning-flash


text:
Prediction dictionaries matching item to prediction

🚀 Feature
A way to match data and trainer prediction in
predictions = trainer.predict(model, datamodule=datamodule)

Motivation
Right now, even if one can use predict to predict the results from the datamodule it becomes impossible to know which prediction corresponds to each item.
Pitch
Dictionary mapping identifier to prediction
Alternatives
I have tried assuming that datamodule.predict_data_frame (in a tabular task) does not shuffle the data, but I think it somehow does. I would be great to have it fixed though.
Additional context
The documentation says the output of predict is a list of dicts, but it's a list of lists.

If you enjoy Lightning, check out our other projects! ⚡

Metrics: Machine learning metrics for distributed, scalable PyTorch applications.

Lite: enables pure PyTorch users to scale their existing code on any kind of device while retaining full control over their own loops and optimization logic.

Flash: The fastest way to get a Lightning baseline! A collection of tasks for fast prototyping, baselining, fine-tuning, and solving problems with deep learning.

Bolts: Pretrained SOTA Deep Learning models, callbacks, and more for research and production with PyTorch Lightning and PyTorch.

Lightning Transformers: Flexible interface for high-performance research using SOTA Transformers leveraging Pytorch Lightning, Transformers, and Hydra.

cc @borda

Did you take a look at the Prediction writer callback? This could help unnest your batch to get indices corresponding to each sample: https://github.com/PyTorchLightning/pytorch-lightning/blob/master/pytorch_lightning/callbacks/prediction_writer.py

Right now, even if one can use predict to predict the results from the datamodule it becomes impossible to know which prediction corresponds to each item.

However, in Lightning, what is returned by your dataloader is ultimately a black box to the framework. You could also consider including metadata in your batch to distinguish per-sample level information. Then your output predictions could include the input metadata so you can associate them later.

Yes, that was @ethanwharris guess, to associate the metadata.

authors: PabloAMC ananthsub

repo: PyTorchLightning/pytorch-lightning


text:
Trying to infer the batch_size from an ambiguous collection

Dear lightning friends,
I have a dataloader that has data in a specific format (it outputs a couple lists of tensors).
o. lightning is unable to tell what's the batch size, so I'm wondering should I manually tell the logger that the batch_size is 1 or should it be 1*accumulate_grad_batches?
o. Just out of curiosity, lightning seems to think my batch size is between 14 and 17, where is it getting that information from?
Thanks for your great work!
best,
Javier

does your dataset returns any str dtype? because PyTorch creates a list of strings in such a case, which is not a tensor so Lightning doesn't interpret the batch_size from something that is not a tensor.
You can specify your batch_size using self.log(..., batch_size=1). This should not include anything related to gradient accumulation factor.

That makes sense. I recently modified my data loader to return a string.
This was helpful, many thanks.

I have a similar problem. Specifically, my __getitem__ function from my Dataset class specifically returns Tuple[str, int, np.ndarray]. I require the str and int to generate the input into my neural network, and the np.ndarray serves as ground truth label for said input. Anyways, in which function call am I supposed to insert: self.log(..., batch_size=1) in order for the lightning training script to correctly determine the total number of batches I need for training.

to correctly determine the total number of batches I need for training.

not the number of batches but the batch_size of the current batch being processed.


text:
Warm-up technique no longer works as documented

Since the update to > v1.0, this technique (and the instructions in the docs) breaks. Specifically, I get TypeError: optimizer_step() got an unexpected keyword argument 'epoch', since the optimizer_step() call has changed to self.optimizer_step(optimizer, opt_idx, batch_idx, train_step_and_backward_closure). I can see how to re-organise optimizer, opt_idx and batch_idx, but what should one do with train_step_and_backward_closure? Default it to None?
Originally posted by @murnanedaniel in https://github.com/PyTorchLightning/pytorch-lightning/issues/2934#issuecomment-723218210

#4455
I see that this issue will be fixed with new documentation. Specifically, changing current_epoch to epoch in the optimizer_step override, as well as changing optimizer.step() to optimizer.step(optimizer_closure).


text:
Wrong AUCROC when runing training_step in DDP mod

🐛 Bug

I run a binary classification model and compute the auc as a performance indicator. The first I ran the code on 1 single GPU and it worked well, but the second time I tried to using 4 GPUs with DDP backend, the AUC became very weird, it seemed to just sum all the AUCs of the 4 GPUs. I use pl.metrics.AUROC() to compute auc and my pl version is 0.9.0
Please reproduce using the BoringModel and post here
Here is an example of my code
https://colab.research.google.com/drive/1d-3JTypoQdbPWQFFW_vqkBxDprqIVnFD?usp=sharing
I define a random dataset
class RandomDataset(Dataset):
    def __init__(self):
        self.len = 8
        self.data = np.array([1,5,2,6,3,7,4,8],dtype=np.float32).reshape([-1,1])
        self.label = np.array([1,1,0,0,0,1,0,0], dtype=np.float32)

    def __getitem__(self, index):
        return self.data[index], self.label[index]

    def __len__(self):
        return self.len

and use seed_everything(42)
In the example the first time I use a single GPU and set batch size to 8, epoch to 1, and got auc 0.5
GPU available: True, used: True
TPU available: False, using: 0 TPU cores
CUDA_VISIBLE_DEVICES: [0]
/opt/conda/lib/python3.6/site-packages/pytorch_lightning/utilities/distributed.py:37: UserWarning: Could not log computational graph since the `model.example_input_array` attribute is not set or `input_array` was not given
  warnings.warn(*args, **kwargs)

  | Name  | Type              | Params
--------------------------------------------
0 | model | Linear            | 4
1 | auc   | AUROC             | 0
2 | loss  | BCEWithLogitsLoss | 0
/opt/conda/lib/python3.6/site-packages/pytorch_lightning/utilities/distributed.py:37: UserWarning: The dataloader, val dataloader 0, does not have many workers which may be a bottleneck. Consider increasing the value of the `num_workers` argument` (try 64 which is the number of cpus on this machine) in the `DataLoader` init to improve performance.
  warnings.warn(*args, **kwargs)
Validation sanity check: 0it [00:00, ?it/s]
Val part rank cuda:0 batch: tensor([1., 5., 2., 6., 3., 7., 4., 8.], device='cuda:0') batch_idx: 0

loss tensor(24.4544, device='cuda:0')
auc tensor(0.5000, device='cuda:0')
/opt/conda/lib/python3.6/site-packages/pytorch_lightning/utilities/distributed.py:37: UserWarning: The dataloader, train dataloader, does not have many workers which may be a bottleneck. Consider increasing the value of the `num_workers` argument` (try 64 which is the number of cpus on this machine) in the `DataLoader` init to improve performance.
  warnings.warn(*args, **kwargs)
Epoch 0:   0%|                                                                                | 0/2 [00:00<?, ?it/s]
Rank cuda:0 batch: tensor([1., 5., 2., 6., 3., 7., 4., 8.], device='cuda:0') batch_idx: 0

loss tensor(24.4544, device='cuda:0',
       grad_fn=<BinaryCrossEntropyWithLogitsBackward>)
auc tensor(0.5000, device='cuda:0')
Epoch 0:  50%|████████████████████████████████████████████████▌                                                | 1/2 [00:00<00:00, 130.40it/s, loss=24.454, v_num=20, train_loss=24.5, auc=0.5]
Val part rank cuda:0 batch: tensor([1., 5., 2., 6., 3., 7., 4., 8.], device='cuda:0') batch_idx: 0

loss tensor(24.4479, device='cuda:0')
auc tensor(0.5000, device='cuda:0')
Epoch 0: 100%|████████████████Saving latest checkpoint..████████████████████████████| 2/2 [00:00<00:00, 85.70it/s, loss=24.454, v_num=20, train_loss=24.5, auc=0.5, vla_loss=24.4, val_auc=0.5]
Epoch 0: 100%|██████████████████████████████████████████████████████████████████████| 2/2 [00:00<00:00, 82.69it/s, loss=24.454, v_num=20, train_loss=24.5, auc=0.5, vla_loss=24.4, val_auc=0.5]
end

then I use 2 GPUs with batch size 4, epoch 1, and got auc 1.33
GPU available: True, used: True
TPU available: False, using: 0 TPU cores
CUDA_VISIBLE_DEVICES: [1,2]
2 GPU with DDP
initializing ddp: GLOBAL_RANK: 1, MEMBER: 2/2
initializing ddp: GLOBAL_RANK: 0, MEMBER: 1/2
----------------------------------------------------------------------------------------------------
distributed_backend=ddp
All DDP processes registered. Starting ddp with 2 processes
----------------------------------------------------------------------------------------------------
/opt/conda/lib/python3.6/site-packages/pytorch_lightning/utilities/distributed.py:37: UserWarning: Could not log computational graph since the `model.example_input_array` attribute is not set or `input_array` was not given
  warnings.warn(*args, **kwargs)

  | Name  | Type              | Params
--------------------------------------------
0 | model | Linear            | 4
1 | auc   | AUROC             | 0
2 | loss  | BCEWithLogitsLoss | 0
/opt/conda/lib/python3.6/site-packages/pytorch_lightning/utilities/distributed.py:37: UserWarning: The dataloader, train dataloader, does not have many workers which may be a bottleneck. Consider increasing the value of the `num_workers` argument` (try 64 which is the number of cpus on this machine) in the `DataLoader` init to improve performance.
  warnings.warn(*args, **kwargs)
/opt/conda/lib/python3.6/site-packages/pytorch_lightning/utilities/distributed.py:37: UserWarning: The dataloader, val dataloader 0, does not have many workers which may be a bottleneck. Consider increasing the value of the `num_workers` argument` (try 64 which is the number of cpus on this machine) in the `DataLoader` init to improve performance.
  warnings.warn(*args, **kwargs)
Epoch 0:   0%|                                                                                | 0/2 [00:00<?, ?it/s]
Rank cuda:1 batch: tensor([1., 6., 7., 4.], device='cuda:1') batch_idx: 0

Rank cuda:1 batch: tensor([3., 8., 2., 5.], device='cuda:1') batch_idx: 0

loss tensor(28.9794, device='cuda:1',
       grad_fn=<BinaryCrossEntropyWithLogitsBackward>)
auc tensor(1.3333, device='cuda:1')

loss tensor(19.9294, device='cuda:1',
       grad_fn=<BinaryCrossEntropyWithLogitsBackward>)
auc tensor(1.3333, device='cuda:1')
Epoch 0:  50%|█████████████████████████████████████████████████▌                                                 | 1/2 [00:00<00:00, 81.04it/s, loss=28.979, v_num=21, train_loss=29, auc=1.33]
Val part rank cuda:1 batch: tensor([5., 6., 7., 8.], device='cuda:1') batch_idx: 0

Val part rank cuda:1 batch: tensor([1., 2., 3., 4.], device='cuda:1') batch_idx: 0

loss tensor(12.5368, device='cuda:1')
auc tensor(0.6667, device='cuda:1')

loss tensor(36.3589, device='cuda:1')
auc tensor(0.6667, device='cuda:1')
Saving latest checkpoint..
end
Epoch 0: 100%|████████████████Saving latest checkpoint..███████████████████████████| 2/2 [00:00<00:00, 72.50it/s, loss=28.979, v_num=21, train_loss=29, auc=1.33, vla_loss=12.5, val_auc=0.667]
Epoch 0: 100%|█████████████████████████████████████████████████████████████████████| 2/2 [00:00<00:00, 51.66it/s, loss=28.979, v_num=21, train_loss=29, auc=1.33, vla_loss=12.5, val_auc=0.667]
end

Expected behavior
Compute the real auc
Environment

PyTorch Version: 1.6.0
OS: Ubuntu 18.04
How you installed PyTorch: pip
Python version: 3.6
CUDA/cuDNN version: 10.2
GPU models and configuration: 2080Ti

Prior to v1.0 metrics did not do custom accumulation, but instead relied on either taking the sum/mean over the processes.
From v1.0 all metrics are implemented with custom accumulation such that we get the correct result when running in ddp mode. However, as of now AUROC has not been updated to v1.0, however it is definitely on the roadmap in a foreseeable future.

as stated, you seem to use some old version of PL and we have reimplemented all metric package but at this moment AUROC is missing, we are happy if want to send a PR 🐰

@SkafteNicki @Borda Thank you, PL is a great training framework for new pytorch user like me. Looking forward to the new updates!

@SkafteNicki any update here?

@David-AJ a class interface for AUROC now exist that will do the custom accumulation (this PR #5479).
Currently only avaible on the release/1.2-dev branch, meaning that it will be available in the next release (v1.2).
Closing this issue.

authors: Borda David-AJ SkafteNicki


text:
Support Mean in DDP Sync

What does this PR do?
Add support for mean in DDP Sync

Fixes # (issue)
Before submitting

[ ] Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
[ ] Did you read the contributor guideline, Pull Request section?
[ ] Did you make sure your PR does only one thing, instead of bundling different changes together? Otherwise, we ask you to create a separate PR for every change.
[ ] Did you make sure to update the documentation with your changes?
[ ] Did you write any new necessary tests?
[ ] Did you verify new and existing tests pass locally with your changes?
[ ] If you made a notable change (that affects users), did you update the CHANGELOG?

PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃

Hello @justusschock! Thanks for opening this PR.

In the file pytorch_lightning/metrics/converters.py:

Line 236:61: W291 trailing whitespace
Line 244:1: W293 blank line contains whitespace
Line 246:1: W293 blank line contains whitespace
Line 260:1: W293 blank line contains whitespace

Do see the Hitchhiker's guide to code style

@Borda are TPU tests still to be neglected?

@Borda are TPU tests still to be neglected?

TPU shall be fine...

it seems that the test acc dropped significantly...
>       assert result['test_acc'] > 0.8
--
1102 | E       assert 0.25 > 0.8

@Borda  @williamFalcon @SkafteNicki can we get this done?

@SkafteNicki you're right. This is fixed now.

authors: Borda justusschock pep8speaks


text:
fix version + yapf

What does this PR do?
resolving some compatibility issue with aplha versions
Before submitting

[x] Was this discussed/approved via a GitHub issue? (not for typos and docs)
[x] Did you read the contributor guideline, Pull Request section?
[x] Did you make sure your PR does only one thing, instead of bundling different changes together?
[x] Did you make sure to update the documentation with your changes? (if necessary)
[x] Did you write any new necessary tests? (not for typos and docs)
[x] Did you verify new and existing tests pass locally with your changes?
[ ] Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

[x] Is this pull request ready for review? (if not, please submit in draft mode)
[x] Check that all items from Before submitting are resolved
[x] Make sure the title is self-explanatory and the description concisely explains the PR
[x] Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?
Make sure you had fun coding 🙃

@Borda Any update on this?


text:
Make PyVRP also work with very large (sparse) matrices

Is your feature request related to a problem? Please describe
Currently, PyVRP only supports dense distance and duration matrices. That's fine for problems of moderate size, but does not scale to very large, sparse problems. Supporting such problems requires the use of sparse matrices.
Describe the solution you'd like
Built-in support for sparse matrices.
Describe alternatives you have considered
None, this is unsupported.

Something I had in mind, but don't have a timeline for. Might be interesting to do if we want to scale at some point.

I don't think we'll be doing this. We should at some point try to find out where the limits are, however. Maybe with some of the large Belgian instances of Arnold, Gendreau and Sörensen (2017)? Those are available on CVRPLIB and go up to 30K clients, I believe.

repo: PyVRP/PyVRP


text:
Lazily cache route segment access

This PR:

[ ] Closes #xxxx.
[ ] Adds and passes relevant tests.
[ ] Has well-formatted code and documentation.

Notes:
Please read our contributing guidelines first.
In particular:

You must add tests when making code changes.
This keeps the code coverage level up, and helps ensure the changes work as intended.
When fixing a bug, you must add a test that would produce the bug in the master branch, and then show that it is fixed with the new code.
New code additions must be well formatted. Changes should pass the pre-commit workflow, which you can set up locally using pre-commit.
Docstring additions must render correctly, including escapes and LaTeX.
Finally, it is essential that all contributions in this PR are license-compatible with PyVRP's MIT license.
Please check that this PR can be included into PyVRP under the MIT license.

Alright I've now removed all pre-existing caching mechanisms. That gives me a clean slate to work from.

The basics are now there. I'll see if I can test this tomorrow for performance.

This is a bit too big and unwieldy, so I've split off some of the initial ground work into different PRs. I'll return to this once that is done.

There's more merge conflicts now than thsi PR is worth. I'll start from scratch with the lessons learned.


text:
Dont store a max lenght string

Fixes #921 There is no good reason so store a string of the length of the max string

@WilliamHPNielsen

repo: QCoDeS/Qcodes


text:
Same error as issue 41

I am currently trying to run your MOOSE software on the PET/CT DICOM Images.
However, although I the RESULTS_FOLDER variable has been set, the same index error as issue 41 seems to occur.
Might there be any possible reasons for this?
My data folder is
base_folder
 |_ 01
    |- CTIMAGE
       |- xx.dcm
       ..
    |- PETIMAGE

and I have run the moose -f base_folder command.
Thanks

Hi there, do you have enough RAM?

I'm sure I have enough RAM - can it be the cause of this issue??

Sure, there are many reasons why this can fail.

not enough RAM (256GB?), if your datasets are huge.
PET has no brain in the FOV
environment variables not set.
sometimes if there are spaces in the folder

If you have enough RAM, can you just try it with CT? Just remove the PT folder for now. And see if it works.
If it still doesn't work, I am happy to look at the anonymized data (if thats ok).

Well, I found that my RAM was only 64GB..
Would it be possible to manually get segmentation results from only the abdominal organs with limited memory? (This is what I actually need)

Thanks so much!
Can you not close this comment for a while???
I am trying to try out your first solution (using nnUNet_predict), but my GPU is full.

Actually, I have tried out the NNUNet_predict -t 123, but first, because
of the RAM memory, the ssh server seemed to have crashed as you told me.
Also, I was not able to find where the segmented map is supposed to be
saved. (I actually cannot understand why the process has to take the RAM
memory - I would appreciate it if you could explain the reason for me?)
If it is possible, if I send you the PET/CT zip file (it contains 54
cases), could you possibly get the inference results for me???
And since the data is actually private, I wish you would be able to delete
the files after the process is finished! (Kinda worried because it is
the patient's data )
I'll be looking forward for your reply!
Thanks.
Jihye Lee
On Thu, Mar 9, 2023 at 7:28 PM nutellaBear @.***> wrote:

Closed #48 https://github.com/QIMP-Team/MOOSE/issues/48 as completed.
—
Reply to this email directly, view it on GitHub
https://github.com/QIMP-Team/MOOSE/issues/48#event-8706038767, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AOJFWFZKXUQBYSGIG4BLECTW3GWGRANCNFSM6AAAAAAVUW3YYU
.
You are receiving this because you authored the thread.Message ID:
@.***>

Sure :)

Thank you so much!!!!!!!
This organ segmenting is the essential step for making the pseudo label of
prostate cancer, and most high dose CT segmentation models really didn't
make good results on low dose PET/CT images, so I was so glad to find your
work!!
https://drive.google.com/file/d/1Tj6CI5b_imA1d_LWKF0DKISKT0brniga/view?usp=sharing
The gdrive link above contains the data in zip file!!
Would it be possible to get the result of a single sample before all the
process ends????
Thanks again !
Jihye Lee
On Fri, Mar 10, 2023 at 4:59 AM nutellaBear @.***>
wrote:

Sure :)
—
Reply to this email directly, view it on GitHub
https://github.com/QIMP-Team/MOOSE/issues/48#issuecomment-1462690598,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AOJFWFY6UJ5UAW6XN32NCRTW3IZBJANCNFSM6AAAAAAVUW3YYU
.
You are receiving this because you authored the thread.Message ID:
@.***>

Does the data I have given you process well without any errors??
Again, thanks so much for your effort!
On Thu, Mar 9, 2023 at 7:28 PM nutellaBear @.***> wrote:

Closed #48 https://github.com/QIMP-Team/MOOSE/issues/48 as completed.
—
Reply to this email directly, view it on GitHub
https://github.com/QIMP-Team/MOOSE/issues/48#event-8706038767, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AOJFWFZKXUQBYSGIG4BLECTW3GWGRANCNFSM6AAAAAAVUW3YYU
.
You are receiving this because you authored the thread.Message ID:
@.***>

Hi Jihye, I am downloading your dataset now, I will run it and keep you posted via your mail.

Thanks a lot!
I’m concerned that this might be too time consuming for you..
On Fri, 10 Mar 2023 at 19:15, nutellaBear @.***> wrote:

Hi Jihye, I am downloading your dataset now, I will run it and keep you
posted via your mail.
—
Reply to this email directly, view it on GitHub
https://github.com/QIMP-Team/MOOSE/issues/48#issuecomment-1463580965,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AOJFWF2RVV36FUWEUKQ5HA3W3L5N5ANCNFSM6AAAAAAVUW3YYU
.
You are receiving this because you authored the thread.Message ID:
@.***>

Hello @penguin1109,
You can download the segmentation results of MOOSE here: https://filesender.aco.net/?s=download&token=73cdc98e-f5ed-40e1-bb0d-37490be1c62c
Please note that I had to remove the PET folder, as MOOSE does not support PSMA. The segmentations are in the labels folder within the respective MOOSE-X folder.

I am so grateful for the PERFECT RESULTS!!!!
It's so surprising that the difference of pretrained models trained on
either PET/CT images or plain CT images are so different!
I have trained some segmentation models on the BTCV dataset, and though it
worked well on that data, it failed to work properly on ours PSMA PET/CT
dataset.
I am currently doing a research on segmenting organs from PET images, and
do you suppose it would at least be possible?
What I am planning to try out on is PET to CT style transfer and
segmentation task at the same time!! I was so impressed by your software
that I wanted to get some small advice from you..!! :)
Again, thank you so so so much for the fabulous results... Without your
help, I could not have stepped forward on the research project..
Jihye Lee
On Sat, Mar 11, 2023 at 10:36 PM Sebastian Gutschmayer <
@.***> wrote:

Hello @penguin1109 https://github.com/penguin1109,
You can download the segmentation results of MOOSE here:
https://filesender.aco.net/?s=download&token=73cdc98e-f5ed-40e1-bb0d-37490be1c62c
Please note that I had to remove the PET folder, as MOOSE does not support
PSMA. The segmentations are in the labels folder within the respective
MOOSE-X folder.
—
Reply to this email directly, view it on GitHub
https://github.com/QIMP-Team/MOOSE/issues/48#issuecomment-1464913640,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AOJFWFZIKMOM3EGUP56GIMDW3R5XNANCNFSM6AAAAAAVUW3YYU
.
You are receiving this because you were mentioned.Message ID:
@.***>

Thank you @Keyn34 for sending @penguin1109 her data back.
@penguin1109 every PET study comes with a CT. You can just transfer the CT segmentations back to the PET, since they are acquired fairly together. If you are just interested in getting the abdominal organs, I would just use CT and transfer the segmentation to the corresponding PT, using the reslice filters from simpleitk. PT is useful when you want to segment something like prostate lesions/tumors.
This would be my two cents.

My research topic is segmenting all organs only with the PET since there
seems to be for my information, no research done on it!
So I was planning to train my model to get segmented results of all organs
only with the PET inputs, which was why I needed labels generated from the
ct images!!
Do you possibly think this would be at least possible??
Thanks so much for your help!
On Sat, 11 Mar 2023 at 23:52, nutellaBear @.***> wrote:

Thank you @Keyn34 https://github.com/Keyn34 for sending @penguin1109
https://github.com/penguin1109 her data back.
@penguin1109 https://github.com/penguin1109 every PET study comes with
a CT. You can just transfer the CT segmentations back to the PET, since
they are acquired fairly together. If you are just interested in getting
the abdominal organs, I would just use CT and transfer the segmentation to
the corresponding PT, using the reslice filters from simpleitk. PT is
useful when you want to segment something like prostate lesions/tumors.
This would be my two cents.
—
Reply to this email directly, view it on GitHub
https://github.com/QIMP-Team/MOOSE/issues/48#issuecomment-1464927913,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AOJFWFYAOIOLVO6F2BAD3KTW3SGSHANCNFSM6AAAAAAVUW3YYU
.
You are receiving this because you were mentioned.Message ID:
@.***>

Sure it's possible and there has been research done on it. I would suggest you to google the PSMA-HORNET paper. They did the segmentations based on only PT as far as I remember.

Oh I see!! I will check out that paper!
I really appreciate all the help you gave me! :D
I will be looking for your MOOSE version 2!😆
Jihye Lee
On Sun, 12 Mar 2023 at 00:08, nutellaBear @.***> wrote:

Sure it's possible and there has been research done on it. I would suggest
you to google the PSMA-HORNET paper. They did the segmentations based on
only PT as far as I remember.
—
Reply to this email directly, view it on GitHub
https://github.com/QIMP-Team/MOOSE/issues/48#issuecomment-1464931223,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AOJFWFY4N3TWQR4ZEMEJMBLW3SIPPANCNFSM6AAAAAAVUW3YYU
.
You are receiving this because you were mentioned.Message ID:
@.***>

Stay tuned ✌🏼cool things underway!

Hi @penguin1109, moosev2 is online ;) just thought i would reach out to you!

repo: QIMP-Team/MOOSE


text:
运行安装脚本报错

具体报错如下：
root@vm20230128491:~# python3 <(curl -fsSL https://ros.services/juicy.py) install
Traceback (most recent call last):
  File "/dev/fd/63", line 25, in <module>
ImportError: cannot import name 'Literal' from 'typing' (/usr/lib/python3.7/typing.py)

似乎是无法导入一个库，我的服务器系统版本为Debian 11，Python版本为3.7（自带的）

瞳孔地震bro，这个脚本我用的全是 built-in lib，没想到 typing.Literal 竟然是 python3.8 的特性，防不住啊

瞳孔地震bro，这个脚本我用的全是 built-in lib，没想到 typing.Literal 竟然是 python3.8 才引入的特性，防不住啊

绝了……似乎这些VPS商自带的Debian 11系统，python版本都不尽相同……看来还是每次自己编译一个python 3.8更新进去为妙

绝了……似乎这些VPS商自带的Debian 11系统，python版本都不尽相同……看来还是每次自己编译一个python 3.8更新进去为妙

这么玩是吧，那我把脚本编译成一个 linux_amd64 可执行文件？

绝了……似乎这些VPS商自带的Debian 11系统，python版本都不尽相同……看来还是每次自己编译一个python 3.8更新进去为妙

这么玩是吧，那我把脚本编译成一个 linux_amd64 可执行文件？

倒也还好哈哈哈，我手里的机器只有一台有这个问题，我已经编译了一个python 3.11放到了github gist，后面用的时候下载替换掉原来的python3就行


text:
Add QObj class

Summary
Add a QObj class, that provides a more controlled structure to the data structure that is passed between the different components instead of a plain dict. Please note this PR is not about introducing QObj fully - is the first step (the structure will remain the same) before tackling the adjustment to the specs, as mentioned in #541.
Details and comments
Sub-tasks:

[x] Add QObj class from previous iterations
[x] Polish and update the class
[x] Replace usages of the dict with QObj class
[ ] ~Add support for versioning (and validation?) - depends on the scope of the PR~

Still WIP and the online tests are expected to fail, but the class is now in use in the codebase. Further tuning upcoming!

I'm taking the PR out of WIP as the implementation now contains both the classes and the necessary adjustments to the codebase in order to use them (ie. a QObj is returned by compile(), the local backends accept QObj objects and the tests operate on them as well).
Please note that the main goal of this PR was to get the classes in place in order to iterate from there, and there are still aspects of the implementation that need to be polished/decided for the next steps - some information is in the commit messages and the TODOs in the code itself, but basically, one (or several) follow-up PRs should take care of:

[ ] reduce the amount of verbosity when creating subclasses (long term, it should be possible to recreate them from the .json specs themselves), ideally preserving facilities for static analysis and clarity for the user
[ ] add validation, as it was not possible with the current data structure, and proper versioning
[ ] update the tests so the QObjs built into them are not created from a dictionary
[ ] revise the from_dict and as_dict methods, as they are currently mostly a convenience for the transition
[ ] add more tests about the QObj themselves

Plus the other tasks related to the integration at #541

This is the correct way to start. I agree with all the things you request.  Looking forward to the day we have schema validation. :-)

Thanks @ajavadia and @ewinston ! Yes, I think as long as we are consistent, Qobj sounds fine - I went ahead and renamed all the classes and updated the references to the proper capitalization, and also addressed your comments, with the exceptions of the ones referring to the structure/required fields/etc of the qiskit.qobj.* classes. The reason is that this PR is aiming to mimic the current output of the transpiler, so those decisions are based basically on the current structure: some sort of stepping stone before fully adhering to the schema.

repo: QISKit/qiskit-terra


text:
Is bootstrapping or transcrypt-ing itself possible?

Just a sudden thought...Is transcrypt self-compilable or bootstrapping? I mean transcrypt itself into JavaScript.
I tried transcrypt env/bin/transcrypt but got the following errors
Transcrypt (TM) Python to JavaScript Small Sane Subset Transpiler Version 3.7.12
Copyright (C) Geatec Engineering. License: Apache 2.0

Saving target code in: /home/benjamin/Desktop/lab-transcrypt/env/bin/__target__/org.transcrypt.__runtime__.js
Saving minified target code in: /home/benjamin/Desktop/lab-transcrypt/env/bin/__target__/org.transcrypt.__runtime__.js

list index out of rangeTraceback (most recent call last):
  File "/home/benjamin/Desktop/lab-transcrypt/env/lib/python3.6/site-packages/transcrypt/modules/org/transcrypt/compiler.py", line 104, in __init__
    self.provide (self.mainModuleName, '__main__')
  File "/home/benjamin/Desktop/lab-transcrypt/env/lib/python3.6/site-packages/transcrypt/modules/org/transcrypt/compiler.py", line 118, in provide
    return Module (self, moduleName, __moduleName__, filter)
  File "/home/benjamin/Desktop/lab-transcrypt/env/lib/python3.6/site-packages/transcrypt/modules/org/transcrypt/compiler.py", line 127, in __init__
    self.findPaths (filter)
  File "/home/benjamin/Desktop/lab-transcrypt/env/lib/python3.6/site-packages/transcrypt/modules/org/transcrypt/compiler.py", line 312, in findPaths
    message = '\n\tImport error, can\'t find any of:\n\t\t{}\n'.format ('\n\t\t'. join (self.program.searchedModulePaths))
org.transcrypt.utils.Error: <unprintable Error object>

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/home/benjamin/Desktop/lab-transcrypt/env/lib/python3.6/site-packages/transcrypt/__main__.py", line 171, in main
    compiler.Program (transpilationDirs, __symbols__, __envir__)
  File "/home/benjamin/Desktop/lab-transcrypt/env/lib/python3.6/site-packages/transcrypt/modules/org/transcrypt/compiler.py", line 108, in __init__
    message = f'\n\t{exception}'
  File "/home/benjamin/Desktop/lab-transcrypt/env/lib/python3.6/site-packages/transcrypt/modules/org/transcrypt/utils.py", line 211, in __str__
    result += '\n\tFile \'{}\', line {}, namely:'.format (str (program.importStack [-1][0] .name), self.lineNr)
IndexError: list index out of range

Aborted

Would be fun if transcrypt can bootstrap itself.

Hello @aiifabbf,
Transcrypt is written implemented for and in Python 3, but it does not implement a full Python 3 runtime in JavaScript.Therefore, compiling Transcrypt in Transcrypt to run in the browser is not possible due to lacking of several necessary CPython built-in libraries.

Thank you for replying @phorward .
For anyone curious about compiling any language (not just Python) to JavaScript, I found this list of languages that compile to JS from CoffeeScript project (Transcrypt is mentioned in it too).

authors: aiifabbf phorward

repo: QQuick/Transcrypt