text:
Bug fix/reduce allocations in hashed collect executor

Scope & Purpose
The HashedCollectExecutor uses an unordered_map to gather all groups with their aggregate values. Previously the value type of the map was a std::unique_ptr<std::vector<std::unique_ptr<Aggregator>>>, and every group was initialized with an actual value, even there were no aggregators (i.e., the vector was empty). So without AGGREGATEwe had one allocation per group, with AGGREGATE we had 2 + <NumberOfAggregators> allocations.
The new implementation uses a single allocation for all aggregators using placement new, which should also result in better cache locality. In addition, the unnecessary allocation in case no aggregators are used is also removed. This resulted in a runtime improvement of ~4-8% on my machine.
Tested using this script in the arangod console:
queries = {
  group:    "FOR i IN 1..500 FOR j IN 1..500 COLLECT a = i, b = j RETURN {a,b}",
  count:    "FOR i IN 1..500 FOR j IN 1..500 COLLECT a = i, b = j WITH COUNT INTO cnt RETURN {a,b,cnt}",
  sum:      "FOR i IN 1..500 FOR j IN 1..500 COLLECT AGGREGATE sum = SUM(i), sum2 = SUM(j) RETURN {sum,sum2}",
  groupSum: "FOR i IN 1..500 FOR j IN 1..500 COLLECT a = i, b = j AGGREGATE sum = SUM(i), sum2 = SUM(j) RETURN {sum,sum2}"
}

for (var k in queries) {
  console.log(k);
  let total = 0;
  let rounds = 10;
  for (var i = 0; i < rounds; ++i) {
    let start = new Date().getTime()
    db._query(queries[k], null, {silent: true}).toArray().length;
    let diff = new Date().getTime() - start;
    total += diff;
    console.log(diff);
  }
  console.log(total / rounds);
  console.log("#############");
}

[ ] :hankey: Bugfix (requires CHANGELOG entry)
[ ] :pizza: New feature (requires CHANGELOG entry, feature documentation and release notes)
[x] :fire: Performance improvement
[ ] :hammer: Refactoring/simplification
[ ] :book: CHANGELOG entry made

Backports:

[x] No backports required

Testing & Verification

[x] This change is a trivial rework / code cleanup without any test coverage.

http://172.16.10.101:8080/view/PR/job/arangodb-matrix-pr/13004/

http://172.16.10.101:8080/view/PR/job/arangodb-matrix-pr/13032/

Tests blue

authors: jsteemann mpoeter


text:
[WIP] Foxx tweaks

General cleanup of Foxx internals.
Biggest change being that Foxx mostly foregoes the low-level routing. This may or may not be a good idea but should eventually allow us to reload services in a more granular way.

We're pleased to anounce that ArangoDB 3.2 containing this is now available for download - Closing.

@pluma: what is the state of this PR? will you update it, or will you close it? It's unclear to the rest of us.
Thanks!

I'm closing this as the PR tries to address too many things at once and has become unsustainable.

source: gharchive/pull-request

authors: dothebart jsteemann pluma

repo: arangodb/arangodb

license_type: permissive

license_source: bigquery


text:
Note what's needed to write a backend

In docs

Just to expand on this issue a bit: Currently, _backend is a dict. In the future, this class may be swappable. When that is the case, the class used for _backend must behave somewhat like a dictionary by implementing __setitem__, __getitem__, get, and pop.
For now, though, this is on hold.

We need a much higher level discussion: https://github.com/aranzgeo/properties/issues/220

source: gharchive/issue

authors: bsmithyman fwkoch

repo: aranzgeo/properties

license: mit


text:
New version impedes PCX importer to work: v0.4.0: URP/HDRP support, easier PLY workflow, smaller chunk info Latest

It's great to have this running in URP/HDRP but the new method of version 4 for creating the assets, through a ply importer, impedes other useful packages, as PCX for importing pointclouds, from working simultaneously in the scene, which wasn't the case until version 3. Would it be possible to incorporate the GaussianSplatURPFeature or GaussianSplatHDRPPass in version 3  that didn't have this conflict? Thank you!
As of now, this error occurs, when having both packages installed:
i get this error in unity: Multiple scripted importers are targeting the extension 'ply' and have all been rejected: Pcx.PlyImporter (assembly: C:\Unity_New\UnityGaussianSplatting-main\Library\ScriptAssemblies\Pcx.Editor.dll), GaussianPlyImporter (assembly: C:\Unity_New\UnityGaussianSplatting-main\Library\ScriptAssemblies\GaussianSplatting.dll)
UnityEditor.AssetImporters.ScriptedImporter:RegisterScriptedImporters ()

Ah! I guess I could make it so that people have to rename their gaussian splat point clouds to some other extension, e.g. .gply. Would that work?

Not the original poster but I think it would. However I think this points to a flaw somewhere. On one level - the Splatting community should probably settle on their own extension. These are regular .ply files only in the loosest sense so a new extension makes a lot of sense and would ideally be adopted widely.
But another aspect is that Unity's scripted importers are really annoying! This isn't the first time the tight coupling between importer and file extension has caused problems.

@andybak looks like Unity scripted importers do have some functionality where multiple importers could co-exist. I'll investigate https://docs.unity3d.com/ScriptReference/AssetDatabase.SetImporterOverride.html and friends and will report back. Thanks for notifying me, I was not aware that other packages also want to import PLY files!

Ah! I guess I could make it so that people have to rename their gaussian splat point clouds to some other extension, e.g. .gply. Would that work?

Thanks, I imagine that might work. PCX is very established for PLY, it has a lot of functionalities and works with VFX. I’m eager to produce visuals using both packages. I was able to add the GaussianSplatURPFeature to an asset renderer on version 3, but it only worked by replacing the GaussianSpla
TRenderer and deleting the GaussianAssetCreator, but my previous created assets still don’t visualize. The GaussianSplatRenderer panel even shows a message that say the asset was created in a previous version. Thank you for considering this issue!

I was hoping that using ScriptedImporterAttribute.overrideFileExtensions would work nicely, as in I'd register no "primary" extension, only the ply as an override extension. And then indeed it works nicely, if both GaussianSplat and PCX are in the project - PCX is used by default, but you can override the asset to be imported as GaussianSplat instead.
But! Then it does not work at all if PCX is not in the project; the asset just is not imported at all. Oooof!
I guess I'll get back to not using a custom importer afterall, i.e. back to the "create asset" window thingy.

Thank you for trying that! Yes, the create asset window, prior to the URP/HDRP update, worked great with PCX.

Should be fixed now in v0.5.0

Should be fixed now in v0.5.0

Thank you so much for implementing this, @aras-p . It works!
Sometimes I've had some memory leakage alerts when selecting ply files on the project window, but I've been able to ignore them. Runtime works normally.
[00:07:17] [Worker1] Internal: There are remaining Allocations on the JobTempAlloc. This is a leak, and will impact performance
[00:07:17] [Worker1] To Debug, run app with -diag-job-temp-memory-leak-validation cmd line argument. This will output the callstacks of the leaked allocations.
[00:07:26] [Worker4] Internal: There are remaining Allocations on the JobTempAlloc. This is a leak, and will impact performance
[00:07:26] [Worker4] To Debug, run app with -diag-job-temp-memory-leak-validation cmd line argument. This will output the callstacks of the leaked allocations.
[Worker4] To Debug, run app with -diag-job-temp-memory-leak-validation cmd line argument. This will output the callstacks of the leaked allocations.
A [Worker4] To Debug, run app with -diag-job-temp-memory-leak-validation cmd line argument. This will output the callstacks of the leaked allocations.

One thing I did so the various glTF importers could happily co-exist was to make a scripting define to specify if the „fileExtension“ should be used (default) or if „overrideFileExtension“ is used.
This allows for both, the nice import workflow and coexisting importers. People that have both pcx and splats have to set the scripting define manually (can also be automatic with a version define in an AsmDef).

@hybridherbst yeah that might work, but also a step that someone has to actually do :/ Right now I'll probably keep on not using a scripted importer, given that it has other issues (namely: there's no way to efficiently store the imported "bunch of bytes" without making either inspector slow, or domain reload slow -- waiting for Unity to add TextAsset constructor that takes byte array as input).

authors: andybak aras-p carlosnavarro-cn hybridherbst

repo: aras-p/UnityGaussianSplatting

license: MIT

license_source: github-api


text:
Add scheduler cron job

 Issue by aravinve
Friday Feb 11, 2022 at 02:00 GMT
Originally opened as https://github.com/neel1996/mimock/issues/27

Add a scheduler cron job that should flush out the mocks which have been deleted for more than 30 days.
EntityStatus should be deleted.
Deleted At should be more than 30days.

completed

repo: arbindo/mimock


text:
Improve sort

Note that this is different from #60, as that one concerns only scaling.
Here are some results from TIOGA (with CudaUVM). Three variants:

Upstream master
Using unsigned int for size_type template parameter in Kokkos' BinSort [here]
Using Thrust [here]

We should also improve the OpenMP sort while we are at it. For example, omega_h uses pss.

Benchmark (my workstation) --values=500000 --queries=200000
master:
-----------------------------------------------------------------------------------------------------------------
Benchmark                                                                          Time           CPU Iterations
-----------------------------------------------------------------------------------------------------------------
BM_construction<ArborX::BVH<Cuda>>/500000/0/manual_time                         7647 us       7623 us         84
BM_knn_search<ArborX::BVH<Cuda>>/500000/200000/10/0/0/manual_time              59053 us      59214 us         12
BM_radius_search<ArborX::BVH<Cuda>>/500000/200000/10/0/0/0/manual_time         14999 us      15171 us         47
BM_construction<ArborX::BVH<CudaUVM>>/500000/0/manual_time                     14634 us      16615 us         48
BM_knn_search<ArborX::BVH<CudaUVM>>/500000/200000/10/0/0/manual_time           67977 us      68386 us         10
BM_radius_search<ArborX::BVH<CudaUVM>>/500000/200000/10/0/0/0/manual_time      18624 us      18840 us         38

thrust:
-----------------------------------------------------------------------------------------------------------------
Benchmark                                                                          Time           CPU Iterations
-----------------------------------------------------------------------------------------------------------------
BM_construction<ArborX::BVH<Cuda>>/500000/0/manual_time                         6744 us       6784 us         95
BM_knn_search<ArborX::BVH<Cuda>>/500000/200000/10/0/0/manual_time              59140 us      59304 us         11
BM_radius_search<ArborX::BVH<Cuda>>/500000/200000/10/0/0/0/manual_time         15083 us      15252 us         46
BM_construction<ArborX::BVH<CudaUVM>>/500000/0/manual_time                     13090 us      15064 us         51
BM_knn_search<ArborX::BVH<CudaUVM>>/500000/200000/10/0/0/manual_time           67731 us      68131 us         11
BM_radius_search<ArborX::BVH<CudaUVM>>/500000/200000/10/0/0/0/manual_time      18031 us      18249 us         39

I guess the next step would be to rerun paper config to see the changes.

Please next time run with --benchmark_repetitions=X and  --benchmark_display_aggregates_only=false and post mean, median, and standard deviation.

@dalg24 Sorry, my bad. Will do the runs, and update the results. --benchmark_display_aggregates_only seems to be only in benchmark version 1.5.0, and not in 1.4.1 that I use.

Updated the comment.

Benchmark (my workstation), hollow_box-hollow_sphere
--values=500000 --queries=200000 --benchmark_repetitions=10 --benchmark_display_aggregates_only=false
master:
BM_construction<ArborX::BVH<Cuda>>/500000/1/manual_time_mean                           9481 us         9630 us           10
BM_construction<ArborX::BVH<Cuda>>/500000/1/manual_time_median                         9435 us         9605 us           10
BM_construction<ArborX::BVH<Cuda>>/500000/1/manual_time_stddev                          143 us         78.9 us           10
BM_knn_search<ArborX::BVH<Cuda>>/500000/200000/10/1/3/manual_time_mean               112840 us       113001 us           10
BM_knn_search<ArborX::BVH<Cuda>>/500000/200000/10/1/3/manual_time_median             112787 us       112946 us           10
BM_knn_search<ArborX::BVH<Cuda>>/500000/200000/10/1/3/manual_time_stddev                188 us          189 us           10
BM_radius_search<ArborX::BVH<Cuda>>/500000/200000/10/0/1/3/manual_time_mean            5774 us         6068 us           10
BM_radius_search<ArborX::BVH<Cuda>>/500000/200000/10/0/1/3/manual_time_median          5762 us         6069 us           10
BM_radius_search<ArborX::BVH<Cuda>>/500000/200000/10/0/1/3/manual_time_stddev          45.8 us         8.47 us           10
BM_construction<ArborX::BVH<CudaUVM>>/500000/1/manual_time_mean                       18740 us        20743 us           10
BM_construction<ArborX::BVH<CudaUVM>>/500000/1/manual_time_median                     18786 us        20789 us           10
BM_construction<ArborX::BVH<CudaUVM>>/500000/1/manual_time_stddev                       204 us          204 us           10
BM_knn_search<ArborX::BVH<CudaUVM>>/500000/200000/10/1/3/manual_time_mean            122237 us       122652 us           10
BM_knn_search<ArborX::BVH<CudaUVM>>/500000/200000/10/1/3/manual_time_median          122177 us       122591 us           10
BM_knn_search<ArborX::BVH<CudaUVM>>/500000/200000/10/1/3/manual_time_stddev             305 us          306 us           10
BM_radius_search<ArborX::BVH<CudaUVM>>/500000/200000/10/0/1/3/manual_time_mean         9066 us         9253 us           10
BM_radius_search<ArborX::BVH<CudaUVM>>/500000/200000/10/0/1/3/manual_time_median       9063 us         9252 us           10
BM_radius_search<ArborX::BVH<CudaUVM>>/500000/200000/10/0/1/3/manual_time_stddev       50.0 us         50.0 us           10

thrust:
BM_construction<ArborX::BVH<Cuda>>/500000/1/manual_time_mean                           6521 us         6685 us           10
BM_construction<ArborX::BVH<Cuda>>/500000/1/manual_time_median                         6489 us         6660 us           10
BM_construction<ArborX::BVH<Cuda>>/500000/1/manual_time_stddev                         68.8 us         47.7 us           10
BM_knn_search<ArborX::BVH<Cuda>>/500000/200000/10/1/3/manual_time_mean               110895 us       111066 us           10
BM_knn_search<ArborX::BVH<Cuda>>/500000/200000/10/1/3/manual_time_median             110900 us       111068 us           10
BM_knn_search<ArborX::BVH<Cuda>>/500000/200000/10/1/3/manual_time_stddev                141 us          142 us           10
BM_radius_search<ArborX::BVH<Cuda>>/500000/200000/10/0/1/3/manual_time_mean            3856 us         4165 us           10
BM_radius_search<ArborX::BVH<Cuda>>/500000/200000/10/0/1/3/manual_time_median          3856 us         4163 us           10
BM_radius_search<ArborX::BVH<Cuda>>/500000/200000/10/0/1/3/manual_time_stddev          12.2 us         11.2 us           10
BM_construction<ArborX::BVH<CudaUVM>>/500000/1/manual_time_mean                       13643 us        15644 us           10
BM_construction<ArborX::BVH<CudaUVM>>/500000/1/manual_time_median                     13632 us        15632 us           10
BM_construction<ArborX::BVH<CudaUVM>>/500000/1/manual_time_stddev                      76.9 us         76.8 us           10
BM_knn_search<ArborX::BVH<CudaUVM>>/500000/200000/10/1/3/manual_time_mean            119367 us       119771 us           10
BM_knn_search<ArborX::BVH<CudaUVM>>/500000/200000/10/1/3/manual_time_median          119349 us       119762 us           10
BM_knn_search<ArborX::BVH<CudaUVM>>/500000/200000/10/1/3/manual_time_stddev             197 us          196 us           10
BM_radius_search<ArborX::BVH<CudaUVM>>/500000/200000/10/0/1/3/manual_time_mean         6374 us         6561 us           10
BM_radius_search<ArborX::BVH<CudaUVM>>/500000/200000/10/0/1/3/manual_time_median       6366 us         6552 us           10
BM_radius_search<ArborX::BVH<CudaUVM>>/500000/200000/10/0/1/3/manual_time_stddev       23.6 us         26.0 us           10

Woah! For hollow variants, both construction and radius search dramatically benefit. For Cuda, hollow box construction is 32% faster, radius search is 34% faster. This is reminiscent of TIOGA results.

I think we may want to design a checklist for accepting performance patches. Something like "Run the following benchmark configurations on these machines". I can write a script that will do this automatically so that it can be done with a push of a button.

Of note, Thrust is part of CUDA Toolkit, an optional installation option of CUDA. A quick check showed that it is available on Summit (OLCF), Condo, and Cori (NERSC). Is that sufficient for us to not require a Thrust search through find_package?

Is there a "standard" way of detecting it?
Also can you confirm we don't need any extra compile or link flag?

Is there a "standard" way of detecting it?

No.

Also can you confirm we don't need any extra compile or link flag?

Confirmed.

Here are the results for #147 from Summit (same configuration as the one used for the paper).
Filled box/filled ball
Construction

KNN

Radius

Hollow box/hollow ball
Construction

KNN

Radius

Wow - huge improvements for big problems. So this is just sorting by Morton index?

@sslattery Yes, all the improvement is coming from the faster Morton index sorting, both for construction and search.

Thrust sort was merged. The issue to remain open until we also fix OpenMP sort.

See https://github.com/kokkos/kokkos/issues/2914.

In #267 we observed that sometimes BinSort is faster than Thrust. For example, in 100K case in bvh_driver it is 15% faster for filled box total construction time, and 25% faster for the shallow case. It means that the difference in the sort itself is even more dramatic. More investigation is required.

I ran Cuda benchmark comparing Thrust vs BinSort for current master (760ae21). The results are mixed.
$ compare_bench.py benchmarks 202004160906_760ae21_master.json 202004160906_760ae21_master_nothrust.json | egrep '(median|CPU|------)'
Benchmark                                                                                Time             CPU      Time Old      Time New       CPU Old       CPU New
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
BM_construction<ArborX::BVH<Cuda>>/10000/0/manual_time_median                                    -0.0736         -0.0763          1646          1525          1658          1532
BM_construction<ArborX::BVH<Cuda>>/100000/0/manual_time_median                                   -0.3237         -0.2791          3323          2248          3661          2639
BM_construction<ArborX::BVH<Cuda>>/1000000/0/manual_time_median                                  +0.1931         +0.1539          8295          9897          8781         10133
BM_construction<ArborX::BVH<Cuda>>/10000/1/manual_time_median                                    -0.0231         -0.0334          1646          1608          1660          1604
BM_construction<ArborX::BVH<Cuda>>/100000/1/manual_time_median                                   -0.2194         -0.1917          3299          2575          3659          2958
BM_construction<ArborX::BVH<Cuda>>/1000000/1/manual_time_median                                  +0.3824         +0.3400          8295         11467          8775         11758
BM_knn_search<ArborX::BVH<Cuda>>/10000/10000/10/1/0/2/manual_time_median                         -0.0692         -0.0653          1452          1352          1542          1441
BM_knn_search<ArborX::BVH<Cuda>>/100000/100000/10/1/0/2/manual_time_median                       +0.0022         -0.0005         10547         10570         10996         10991
BM_knn_search<ArborX::BVH<Cuda>>/1000000/1000000/10/1/0/2/manual_time_median                     +0.0196         +0.0196         96112         97996         96973         98874
BM_knn_search<ArborX::BVH<Cuda>>/10000/10000/10/1/1/3/manual_time_median                         +0.0112         +0.0104          1609          1627          1698          1716
BM_knn_search<ArborX::BVH<Cuda>>/100000/100000/10/1/1/3/manual_time_median                       +0.0407         +0.0397         13755         14314         14171         14734
BM_knn_search<ArborX::BVH<Cuda>>/1000000/1000000/10/1/1/3/manual_time_median                     +0.0506         +0.0490        197212        207190        198075        207787
BM_radius_search<ArborX::BVH<Cuda>>/10000/10000/10/1/0/0/2/manual_time_median                    -0.0393         -0.0356          1113          1069          1203          1160
BM_radius_search<ArborX::BVH<Cuda>>/100000/100000/10/1/0/0/2/manual_time_median                  -0.0158         -0.0174          7212          7098          7652          7520
BM_radius_search<ArborX::BVH<Cuda>>/1000000/1000000/10/1/0/0/2/manual_time_median                +0.0659         +0.0660         60875         64889         61675         65749
BM_radius_search<ArborX::BVH<Cuda>>/10000/10000/10/1/0/1/3/manual_time_median                    +0.0192         +0.0174          1075          1096          1166          1186
BM_radius_search<ArborX::BVH<Cuda>>/100000/100000/10/1/0/1/3/manual_time_median                  -0.1156         -0.0996          3770          3334          4209          3790
BM_radius_search<ArborX::BVH<Cuda>>/1000000/1000000/10/1/0/1/3/manual_time_median                +0.9050         +0.8320         10350         19717         11172         20468

I'd like to put a higher priority on figuring out our sort situation.

@dalg24 has been considering introducing a single interface following standard (presumably, std::sort
In #456, @masterleinad introduced a new overload for SYCL, that behaves different from Thrust overloads internally
Serial sort is slow
I don't think it defaults to std::sort. I've tried running DBSCAN problem in serialwith 500,000 points with default sort, and std::sort, and the later one was dramatic improvement

Timer
BinSort
std::sort

construction
0.464
0.077

query+cluster
1.607
1.218

The last point is relevant for the current ExaWind experiments: even though we don't sort queries, we still sort primitives.

I'd like to put a higher priority on figuring out our sort situation.

@dalg24 has been considering introducing a single interface following standard (presumably, std::sort
In #456, @masterleinad introduced a new overload for SYCL, that behaves different from Thrust overloads internally
Serial sort is slow
I don't think it defaults to std::sort. I've tried running DBSCAN problem in serialwith 500,000 points with default sort, and std::sort, and the later one was dramatic improvement

Timer
BinSort
std::sort

construction
0.464
0.077

query+cluster
1.607
1.218

The last point is relevant for the current ExaWind experiments: even though we don't sort queries, we still sort primitives.

Compadre is working on integrating ArborX, replacing existing nanoflann version. They also hit an issue with the time taken by Kokkos::BinSort in the ArborX tree construction (it takes ~80% of overall time). std::sort for the same problem is about 3x faster.
Of note, Compadre uses Kokkos Threads backend. This is due to using the native install of the Apple Clang compiler (version 12), that does not configure with OpenMP backend. Specifically, it complains that the compiler was built without OpenMP support.

Of note, Compadre uses Kokkos Threads backend. This is due to using the native install of the Apple Clang compiler (version 12), that does not configure with OpenMP backend. Specifically, it complains that the compiler was built without OpenMP support.

There is https://github.com/kokkos/kokkos/issues/3256 for that and https://github.com/kokkos/kokkos/pull/4105 might help.

Closing in favor of Discussion, as there is no concrete action to take at this point.

authors: aprokop dalg24 masterleinad sslattery

repo: arborx/ArborX


text:
🛑 ARCaptcha S3 is down

In 17ca81a, ARCaptcha S3 (https://api.arcaptcha.ir/arcaptcha/api/s3) was down:

HTTP code: 400
Response time: 342 ms

Resolved: ARCaptcha S3 is back up in 8c50955.

repo: arcaptcha/ARCaptcha-monitoring


text:
Plugin system?

A couple times now we've mentioned that we eventually want Arch to have a plugin system, but nobody really knows what it should do. We can discuss and track that here.
What would you want a plugin system to let you do?

Some things I'll list here may not necessarily be something I'd want. I'm just trying to get the brain juices flowing. I'll add to this over time as I think of stuff...

Add custom watch and build tasks (for compiling css and other assets, for example).

authors: charypar chrisvfritz

repo: arch-js/arch


text:
Status validation error

https://developer.servicetitan.io/api-details/#api=tenant-salestech-v2&operation=EstimatesExport_Estimates
This is the validation error and it looks like its for estimates https://github.com/archdotdev/tap-service-titan/blob/43db08183a3c841ec3ecfc9fb921214812fd9502/tap_service_titan/streams.py#L825 since thats the only status field thats not defined as a string type. Based on the docs the type is correct in the tap but the data returned by the API is wrong 🤔 .
jsonschema.exceptions.ValidationError: 'CreditReceived' is not of type 'object', 'null'
Failed validating 'type' in schema['properties']['status']:
    {'properties': {}, 'type': ['object', 'null']}
On instance['status']:

It might actually be returns https://github.com/archdotdev/tap-service-titan/blob/43db08183a3c841ec3ecfc9fb921214812fd9502/tap_service_titan/streams.py#L1685

Yep I see that its labeled as {} in the sample response but elsewhere theres an enum of string values https://developer.servicetitan.io/api-details/#api=tenant-inventory-v2&operation=Returns_GetList&definition=Inventory.V2.InventoryReturnStatus

repo: archdotdev/tap-service-titan


text:
Make images in html-export clickable.

Avoid side effects by creating copy of model before adding additional coordinate-offset information.

Closing this as I did a manual merge into a new branch "html-report-clickable".
There are some cases where some figures do not show links, so needs a bit of fine tuning.

@aschlechter Could you contact me? I have an example file where the images are not clickable. Or you can get it from here:
https://github.com/archimatetool/archi/blob/master/tests/com.archimatetool.testsupport/testdata/models/Archisurance.archimate
The view is "Information Structure View" some boxes are not clickable when exported.

Hi,
I will have a look into this.
Tun
On Wed, Nov 2, 2016 at 4:56 PM, Phil Beauvoir notifications@github.com
wrote:

@aschlechter https://github.com/aschlechter Could you contact me? I
have an example file where the images are not clickable. Or you can get it
from here:
https://github.com/archimatetool/archi/blob/master/tests/com.
archimatetool.testsupport/testdata/models/Archisurance.archimate
The view is "Information Structure View" some boxes are not clickable when
exported.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/archimatetool/archi/pull/157#issuecomment-257908606,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AV5LjE-Vpw-fnm_HNqgwym4jQ38WX3ySks5q6LKZgaJpZM4Km-EB
.

--
Tun Schlechter
Abacus Consulting & Solutions S.A.
24, Val Saint André
L-1128 Luxembourg
Tel: +352 621 178 938
Mail: antoine.schlechter@abac.lu
--
Note: Privileged/Confidential information may be contained in this message
and may be subject to legal privilege. Access to this e-mail by anyone
other than the intended is unauthorised. If you are not the intended
recipient (or responsible for delivery of the message to such person), you
may not use, copy, distribute or deliver to anyone this message (or any
part of its contents ) or take any action in reliance on it. In such case,
you should destroy this message, and notify us immediately. If you have
received this email in error, please notify us immediately by e-mail or
telephone and delete the e-mail from any computer. If you or your employer
does not consent to internet e-mail messages of this kind, please notify us
immediately. All reasonable precautions have been taken to ensure no
viruses are present in this e-mail. As our company cannot accept
responsibility for any loss or damage arising from the use of this e-mail
or attachments we recommend that you subject these to your virus checking
procedures prior to use. The views, opinions, conclusions and other
informations expressed in this electronic mail are not given or endorsed by
the company unless otherwise indicated by an authorized representative
independent of this message.

Hi,
There are archimate:DiagramObject-s in Archisurance.archimate that do not
have width and height attributes. These are initialized in the model with
"-1" each. The coordinate calculation then calculate a lower right corner
that is situated top left of the top left corner.
How is it possible that there are objects in the Archisurance.archimate
that do not have these attributes set? Is this normal?
The model objects are displayed correctly, so someplace in the rendering
process default-values are being used for the missing attributes without
being set into the Bounds of the objects.
Changing the constructor of BoundsWithAbsolutePosition to the following
will resolve the issue... but I believe it would be better to fix it on
load of the model / saving of the model.
public BoundsWithAbsolutePosition(IBounds b) {
this.setLocation(b.getX(), b.getY());
this.setSize(b.getWidth(), b.getHeight());
// FIX FOR MODEL OBJECTS THAT MIGHT NOT HAVE THEIR WIDTH AND HEIGHT
INITIALIZED
if (getWidth()==WIDTH_EDEFAULT) {
setWidth(IGraphicalObjectUIProvider.DefaultRectangularSize.width);
}
if (getHeight()==HEIGHT_EDEFAULT) {
setHeight(IGraphicalObjectUIProvider.DefaultRectangularSize.height);
}
}
Greetings,
Tun Schlechter
On Thu, Nov 3, 2016 at 8:29 AM, Antoine Schlechter <
antoine.schlechter@abac.lu> wrote:

Hi,
I will have a look into this.
Tun
On Wed, Nov 2, 2016 at 4:56 PM, Phil Beauvoir notifications@github.com
wrote:

@aschlechter https://github.com/aschlechter Could you contact me? I
have an example file where the images are not clickable. Or you can get it
from here:
https://github.com/archimatetool/archi/blob/master/tests/
com.archimatetool.testsupport/testdata/models/Archisurance.archimate
The view is "Information Structure View" some boxes are not clickable
when exported.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/archimatetool/archi/pull/157#issuecomment-257908606,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AV5LjE-Vpw-fnm_HNqgwym4jQ38WX3ySks5q6LKZgaJpZM4Km-EB
.

--
Tun Schlechter
Abacus Consulting & Solutions S.A.
24, Val Saint André
L-1128 Luxembourg
Tel: +352 621 178 938
Mail: antoine.schlechter@abac.lu

--
Tun Schlechter
Abacus Consulting & Solutions S.A.
24, Val Saint André
L-1128 Luxembourg
Tel: +352 621 178 938
Mail: antoine.schlechter@abac.lu
--
Note: Privileged/Confidential information may be contained in this message
and may be subject to legal privilege. Access to this e-mail by anyone
other than the intended is unauthorised. If you are not the intended
recipient (or responsible for delivery of the message to such person), you
may not use, copy, distribute or deliver to anyone this message (or any
part of its contents ) or take any action in reliance on it. In such case,
you should destroy this message, and notify us immediately. If you have
received this email in error, please notify us immediately by e-mail or
telephone and delete the e-mail from any computer. If you or your employer
does not consent to internet e-mail messages of this kind, please notify us
immediately. All reasonable precautions have been taken to ensure no
viruses are present in this e-mail. As our company cannot accept
responsibility for any loss or damage arising from the use of this e-mail
or attachments we recommend that you subject these to your virus checking
procedures prior to use. The views, opinions, conclusions and other
informations expressed in this electronic mail are not given or endorsed by
the company unless otherwise indicated by an authorized representative
independent of this message.

Thanks for finding the problem. I will look at a solution as you suggest.
Phil

I've re-instated a compatibility handler that converts default sizes to real sizes. Fixes the problem.
"html-report-clickable" branch has been merged to master
Thanks for your contribution!

authors: Phillipus aschlechter

repo: archimatetool/archi


text:
Manual mode type error.

Bug description
TenancyServiceProvider.php for manual mode https://tenancyforlaravel.com/docs/v3/manual-mode
Events\TenancyInitialized::class => [
    Listeners\CreateTenantConnection::class,
],

run
Tenant::create(['id' => 'test']);

Stancl\Tenancy\Listeners\CreateTenantConnection::handle(): Argument #1 ($event) must be of type Stancl\Tenancy\Events\Contracts\TenantEvent, Stancl\Tenancy\Events\TenancyInitialized given, called in /var/www/html/vendor/laravel/framework/src/Illuminate/Events/Dispatcher.php on line 441

TenancyInitialized and CreateTenantConnection have difference event types.(TenancyEvent, TenantEvent)
Temporary solution.
\App\Listeners\CreateTenantConnection.php
<?php

namespace App\Listeners;

use Stancl\Tenancy\Database\DatabaseManager;
use Stancl\Tenancy\Events\TenancyInitialized;

class CreateTenantConnection {
    public function __construct(
        protected DatabaseManager $database
    ) {
    }

    public function handle(TenancyInitialized $event) {
        $this->database->createTenantConnection($event->tenancy->tenant);
    }
}

TenancyServiceProvider.php

            Events\TenancyInitialized::class => [
//                Listeners\CreateTenantConnection::class,
                \App\Listeners\CreateTenantConnection::class,
            ],

related issue : https://github.com/archtechx/tenancy/issues/759
Laravel version
9.27
stancl/tenancy version
3.5.9

already https://github.com/archtechx/tenancy/issues/899

repo: archtechx/tenancy


text:
左侧菜单栏在发布后适配显示不正常

[ ] I'm sure this does not appear in the issue list of the repository

Basic Info

Package Name And Version: arco-design-pro-vue@2.5.1
Browser: chrome101.0.4951.64

Extra info
使用官网的模板，下载后直接preview和build,然后我用fiddler模拟api/user/login api/user/info接口数据 登陆成功后同样出现上面的问题，已经把setting.json的menuFromServer设置为了false。
What is expected?
但是当使用preview或者build发布后，按上面的步骤缩小窗口后，点击菜单按钮，弹出的菜单栏上面菜单空的，没有正常渲染出来，并且会有报错，然后窗口拉大回来正常
arco.db53d955.js:4

       TypeError: Converting circular structure to JSON
    --> starting at object with constructor 'Object'
    |     property '_' -> object with constructor 'Object'
    |     property 'vnode' -> object with constructor 'Object'
    |     ...
    |     property 'ref' -> object with constructor 'tS'
    --- property '_rawValue' closes the circle
    at JSON.stringify (<anonymous>)
    at Tr.fn (default-layout.0c32ddd6.js:formatted:110:39)
    at Tr.run (arco.db53d955.js:1:6297)
    at rS.get value [as value] (arco.db53d955.js:1:14720)
    at h (default-layout.0c32ddd6.js:formatted:213:24)
    at Proxy.<anonymous> (default-layout.0c32ddd6.js:formatted:228:23)
    at ds (arco.db53d955.js:4:4341)
    at Tr.we [as fn] (arco.db53d955.js:4:35125)
    at Tr.run (arco.db53d955.js:1:6297)
    at N (arco.db53d955.js:4:35412)

通过排查，发现是在 src/components/menu/useMenuTree.ts的第18行，menuTree 计算时，使用了JSON.stringify抛出的错误。
  const menuTree = computed(() => {
    const copyRouter = JSON.parse(JSON.stringify(appRoute.value));

开发环境正常，为何到了发布打包后这里会报错呢。
Steps to reproduce
开发时正常，登陆进去，菜单显示在拉小屏幕后，菜单会隐藏并出现一个菜单按钮在左上方，点击按钮会弹出抽屉菜单，这个是适合小屏幕的菜单显示。

@ktangel 这边由于getrouter会产生一些循环依赖问题。可以根据v2.5.1做一层map。

repo: arco-design/arco-design-pro-vue


text:
Support musl

As a person who works in Docker a lot (Alpine), it would be great to be able to install Bonnie in musl-based environments without having to compile from source! This could be done with a simple extra GitHub Actions hob beyond the existing matrix build, and then if a shell script could be created to automatically install Bonnie (I'm thinking a git.io link), that'd be fantastic.

Okay, this is done in 1.3.0 (nothing in the CHANGELOG because only CI changes). The link shortening will come soon.


text:
Add router state

This adds support for router state to Perseus, including a new example in examples/showcase/ and documentation in the section on templates. It's likely that the router state provided will be extended in future, but, for now, it includes just one property about the router's load state, which can be used to create custom routing progress bars and the like.
Closes #106.

Also, some tests may fail, the latest Actix Web beta seems to be playing havoc in the dependency tree.


text:
Add support for nested quotes, URLs, and email addresses in mail

After moving to Nord from Base 16 Tomorrow Night I noticed that nested quotes and URLs were not properly colored when editing mail. I have copied the definitions from my previous theme and changed the colors to what I think are the Nord-appropriate values. Nord 3 is used for comments, which is similar to a quote in mail. Nord 8 is used for Markdown link text, which is similar to URLs and email addresses in mail.

Hi @pigmonkey :wave:, thanks for your contribution :+1:
I'll review it in the near future and get back to you.

authors: arcticicestudio pigmonkey

repo: arcticicestudio/nord-vim


text:
I miss some data in the saved actor sheet

First I want to say that the idea of this module is fantastic and that it can become an indispensable module :).
And now to the problem, when generating a character it shows data like race, profession, or "proficiencies" that don't appear later in the actor that is saved.
It would be enough if these data appeared in the biography tab of the actor.

it might be some issue with the sheet you are using, are there any errors in the console?
race + profession

proficiencies:

everything that doesn't have a seperate sheet field and is in the bio

I even did a new world with no modules to try it and it's the same, here is the proof

found the issue, if saved as npc it does not fill in those fields, will look into fixing (it works when saved as character)

I am sorry but where is the option to save as character? It always saves as NPC 🤔

I set the default of the setting to save as character now. Do have a fix ready that I'll push in a sec, but I think it being integrated into the sheet looks better than being in the biography.

oh shit, update has an error, one moment

should be fixed now

Yes! I can see the race on the upper NPC sheet right now and the profession and proficiencies in the biography, that will work :)
Thanks!

authors: JJBocanegra ardittristan

repo: ardittristan/VTTNPCGen


text:
Update repositories.txt

hi，could you please add this library to the library manager？
https://github.com/STONElibrary/arduino_lib

Hello, I just added the example, can you update the library again

Hi @STONElibrary. Please read the information here to learn how to make new releases of your library:
https://github.com/arduino/library-registry/blob/main/FAQ.md#how-can-i-publish-a-new-release-once-my-library-is-in-the-list
Please let me know if you have any questions or problems.

repo: arduino/library-registry


text:
Flaky appendonly test

Here are some reminders before you submit the pull request

[ ] Add tests for the change
[ ] Document changes
[ ] Communicate in the mailing list if needed
[ ] Pass make installcheck
[ ] Review a PR in return to support the community

Allure report https://allure.adsw.io/launch/75540

@dkovalev1 We need unique table names in parallel test. So what about using the test name as prefix or suffix in the table name? I'm not sure that the t2_ao_comp_rate name will never be used in other tests.

authors: BenderArenadata andr-sokolov dkovalev1

repo: arenadata/gpdb


text:
解决若干bug，详情看提交日志

解决若干bug，详情看提交日志

@dormscript Too much commit.All issues will be solved in new comming v4.0.0.


text:
ERR_REQUIRE_ESM when upgrading from 0.13.6 to 0.13.8

Getting this error when trying to upgrade @arethetypeswrong/cli to the latest version.
$ attw --pack

.../node_modules/cli-table3/src/utils.js:1
const stringWidth = require('string-width');
                    ^

Error [ERR_REQUIRE_ESM]: require() of ES Module .../node_modules/string-width/index.js from .../node_modules/cli-table3/src/utils.js not supported.
Instead change the require of index.js in .../node_modules/cli-table3/src/utils.js to a dynamic import() which is available in all CommonJS modules.
    at Object.<anonymous> (.../node_modules/cli-table3/src/utils.js:1:21) {
  code: 'ERR_REQUIRE_ESM'
}

Node.js v20.11.0

Also noticed these warning during yarn install
warning Pattern ["string-width-cjs@npm:string-width@^4.2.0"] is trying to unpack in the same destination ".../Library/Caches/Yarn/v6/npm-string-width-cjs-4.2.3-269c7117d27b05ad2e536830a8ec895ef9c6d010-integrity/node_modules/string-width-cjs" as pattern ["string-width@^4.2.0"]. This could result in non-deterministic behavior, skipping.
warning Pattern ["string-width@^4.1.0"] is trying to unpack in the same destination ".../Library/Caches/Yarn/v6/npm-string-width-cjs-4.2.3-269c7117d27b05ad2e536830a8ec895ef9c6d010-integrity/node_modules/string-width-cjs" as pattern ["string-width@^4.2.0"]. This could result in non-deterministic behavior, skipping.

It seems there was a conflict on that package with another tool I'm using — tsup
=> Found "string-width-cjs@4.2.3"
info Reasons this module exists
   - "@arethetypeswrong#cli#cli-table3" depends on it
   - Hoisted from "@arethetypeswrong#cli#cli-table3#string-width-cjs"
   - Hoisted from "tsup#sucrase#glob#jackspeak#@isaacs#cliui#string-width-cjs"
   - Hoisted from "tsup#sucrase#glob#jackspeak#@isaacs#cliui#wrap-ansi-cjs#string-width-cjs"

=> Found "string-width@5.1.2"
info Reasons this module exists
   - "tsup#sucrase#glob#jackspeak#@isaacs#cliui" depends on it
   - Hoisted from "tsup#sucrase#glob#jackspeak#@isaacs#cliui#string-width"
   - Hoisted from "tsup#sucrase#glob#jackspeak#@isaacs#cliui#wrap-ansi#string-width"

I managed to fix it by running yarn upgrade.


text:
created order page @arghadipmanna101 plz merge my pull request if it is correctly done

@arghadipmanna101  issue is resolved  , now check for order page and merge my pull request under ggsoc24 label


text:
add examples

Adding examples for #114

The examples uses a new concept of depndesOn fields to declare a dependence between two generators

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 2 committers have signed the CLA.:white_check_mark: OmerKahani:x: OmerOmer seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

authors: CLAassistant OmerKahani

repo: argoproj-labs/applicationset


text:
Ability to specify filename for helm based git write back target

We would like to use argocd image updater to automatically update the development branch of our application config repo and write back the version to git.  This works well.  We would then like to promote to test by merging this file into our test branch (which does not use image updater) and eventually prod branch which also does not use image updater.  The issue is, each of our applications is named differently, myapp-dev, myapp-test, myapp-prod and the file written to git is ".argocd-source-<appname>.yaml".  I would like to make image updater use the ".argocd-source.yaml" instead so it would be honored in all environments like it is documented in Argo docs, https://argo-cd.readthedocs.io/en/stable/user-guide/parameters/#store-overrides-in-git
The solution I am thinking is to make this similar to the kustomize configuration so you could specify:
argocd-image-updater.argoproj.io/write-back-target: "helm:/.argocd-source.yaml"
I think the above gives the most flexibility in the case that Argo starts accepting different filenames in future releases.  You could also implement it as:
argocd-image-updater.argoproj.io/write-back-target: "helm:exclude-appname"
or something similar to denote that the templated name of .argocd-source-<appname>.yaml should not be used which aligns with ArgoCD's implementation of either having app name or not.

After writing this up and discussing with a colleague, we came up with a work-around until this can be implemented.  You can create a symlink from the environment file that you use argocd image updater on to the generic, non app specific filename.  We just tested this out and it works as expected.
ln -s .argocd-source-myapp-dev.yaml .argocd-source.yaml
Commit symlink file

repo: argoproj-labs/argocd-image-updater


text:
Document RBAC requirements for workflow pods

Testing on GKE with legacy auth disabled. Although the controller installs and runs with correct service account, the pods which it schedules, are still using the default service account (in their respective namespace) and are unable to update the pod metadata of itself and add the outputs to the pod annotation.
time="2017-12-04T02:19:31Z" level=info msg="Capturing script output"
time="2017-12-04T02:19:31Z" level=fatal msg="Error capturing script output, pods \"pod-limits-dds8d-1859251742\" is forbidden: User \"system:serviceaccount:default:default\" cannot get pods in the namespace \"default\": Unknown user \"system:serviceaccount:default:default\"
github.com/argoproj/argo/errors.Wrap
	/root/go/src/github.com/argoproj/argo/errors/errors.go:86
github.com/argoproj/argo/errors.InternalWrapError
	/root/go/src/github.com/argoproj/argo/errors/errors.go:69
github.com/argoproj/argo/workflow/executor.(*WorkflowExecutor).GetMainContainerStatus
	/root/go/src/github.com/argoproj/argo/workflow/executor/executor.go:265
github.com/argoproj/argo/workflow/executor.(*WorkflowExecutor).GetMainContainerID
	/root/go/src/github.com/argoproj/argo/workflow/executor/executor.go:280
github.com/argoproj/argo/workflow/executor.(*WorkflowExecutor).CaptureScriptResult
	/root/go/src/github.com/argoproj/argo/workflow/executor/executor.go:306
github.com/argoproj/argo/cmd/argoexec/commands.waitContainer
	/root/go/src/github.com/argoproj/argo/cmd/argoexec/commands/wait.go:41
github.com/argoproj/argo/vendor/github.com/spf13/cobra.(*Command).execute
	/root/go/src/github.com/argoproj/argo/vendor/github.com/spf13/cobra/command.go:702
github.com/argoproj/argo/vendor/github.com/spf13/cobra.(*Command).ExecuteC
	/root/go/src/github.com/argoproj/argo/vendor/github.com/spf13/cobra/command.go:783
github.com/argoproj/argo/vendor/github.com/spf13/cobra.(*Command).Execute
	/root/go/src/github.com/argoproj/argo/vendor/github.com/spf13/cobra/command.go:736
main.main
	/root/go/src/github.com/argoproj/argo/cmd/argoexec/main.go:11
runtime.main
	/usr/local/go/src/runtime/proc.go:185
runtime.goexit
	/usr/local/go/src/runtime/asm_amd64.s:2337"

Just trying to get started with argo and while these notes are a good start, I don't think that giving the default user admin permissions is a good idea. Correct me if I'm wrong, but that means that all my pods get full access, right?
As I understand it, I can use submit --as to provide a different account, but I struggle creating one that has the right permissions. I've installed argo in a new argo namespace (with install --install-namespace`), then tried:
kubectl create sa argo
kubectl create rolebinding argo --clusterrole admin --serviceaccount default:argo

But when trying to submit a job in the default namespace, I get:
argo submit --as argo https://raw.githubusercontent.com/argoproj/argo/master/examples/coinflip.yaml
2018/02/05 13:23:59 Workflow manifest https://raw.githubusercontent.com/argoproj/argo/master/examples/coinflip.yaml failed submission: workflows.argoproj.io is forbidden: User "argo" cannot create workflows.argoproj.io in the namespace "default"

Do I somehow need to explicitly give it permissions on the workflow CRDs?

Okay I figured this out: I needed to build from source and use the recently added --serviceaccount flag. Not sure what the difference is though. I'd suggest to improve the help strings for the flags too. I don't know what it means by 'impersonating'. Would also help to group the flags somehow to avoid confusion. E.g --user could become --kubeconfig.user or something like that.
In general though, I'd like to be able to run workflows in any namespace, so giving the default user in each namespace some permissions seems to be the way to go. But not the admin permissions. Are the required permissions documented somewhere? IMO there should be a role that can be bound to default, allowing only the necessary actions (annotating the pods AFAIK?)

Correct me if I'm wrong, but that means that all my pods get full access, right?

That is correct, but this is an admin and not cluster-admin, so it will be limited to what is in that namespace. So if you are worried workflows accessing things that it shouldn't, you should run workflows in an isolated namespace.

Not sure what the difference is though. I'd suggest to improve the help strings for the flags too. I don't know what it means by 'impersonating'

Actually these are all kubernetes flags that we inherit from the k8s CLI tooling so we don't have control over this

Okay I figured this out: I needed to build from source and use the recently added --serviceaccount flag

Both v2.0.0-beta1 and v2.0.0-alpha3 have this feature so no need to rebuild from source.

Are the required permissions documented somewhere? IMO there should be a role that can be bound to default, allowing only the necessary actions (annotating the pods AFAIK?)

The bare minimum for normal workflows is that the executor sidecar needs to get/update/patch pods so that it can read metadata about itself, and annotate outputs.
That said, the privileges that the pod needs depends on what the workflow is doing. For example, if the workflow also needs to upload/download artifacts to S3, it should also be able to read secrets in the namespace. If the workflow needs to orchestrate (create/delete) other kubernetes resources, it will need create/delete permissions on those types of resources.

That is correct, but this is an admin and not cluster-admin, so it will be limited to what is in that namespace. So if you are worried workflows accessing things that it shouldn't, you should run workflows in an isolated namespace.

Ah thanks for clarifying.

Both v2.0.0-beta1 and v2.0.0-alpha3 have this feature so no need to rebuild from source.
Uhmm.. you're right, not sure how I missed that.

The bare minimum for normal workflows is that the executor sidecar needs to get/update/patch pods so that it can read metadata about itself, and annotate outputs.

Is there a reason why the controller isn't doing these things instead? Except maybe the S3, it sounds to me (but I might miss something) like it's something the controller should do. That could ensure that it's only modifying the pods that belong to the workflow.

I'm still having issues with RBAC, granting the same access to my developers group I can only execute argo commands if using an admin account. Using a developer account, I have this problem:
argo submit --serviceaccount argo --namespace argo https://raw.githubusercontent.com/argoproj/argo/master/examples/artifact-passing.yaml
2018/02/08 15:47:05 Workflow manifest https://raw.githubusercontent.com/argoproj/argo/master/examples/artifact-passing.yaml failed submission: workflows.argoproj.io is forbidden: User "developers-staging" cannot create workflows.argoproj.io in the namespace "argo"
Couldn't find what kind of permissions I need to grant to my developers group. They can create/patch/update/get pods on the argo namespace. Tried a buch of different rules and still the same issue.

authors: discordianfish jessesuen nelsonfassis

repo: argoproj/argo


text:
Suggest you remove vulgar term starting with "r"

When I ran the updater, a screen flashed momentarily that said "WebM for r$tards", where the $ was an "e". I suggest it would be beneficial to change this term, as it is not an acceptable term in today's society, at least in the US.  Thanks

Updated. Download the latest files.

repo: argorar/WebMConverter


text:
Fix multilooking bug

Handle bug with multilooking by applying looks to the DEM and mask, before using for using or applying for product generation.
Addresses #364

Thanks, @sssangha. I am testing now. Will let you know asap.

authors: rzinke sssangha

repo: aria-tools/ARIA-tools


text:
Improving the [Date|Time|DateTime]Delta API

There are two design questions for DateDelta:

Currently, DateDelta stores years, months, weeks, and days separately. However, in the Gregorian calandar, years are always 12 months, and weeks are always 7 days. It's save on storage to just store months and days. The downside is that users may want to deliberately store unnormalized deltas, such that "24 months" isn't the same as "2 years".
On a related note, the DateDelta components may have different signs (P4Y-3M+1W0D). While this is certainly flexible, it's unclear whether this functionality is actually used. Having one single sign would simplify things—although it may result in exceptions when doing arithmetic (whether years(a) + months(b) - years(c) would raise an exception depending on whether the result would have mixed signs).

While I have not encountered the usecases where a delta needs to be the component distinguishing whether it's months or years (this seems to me like something that is defined by the context, not the data object), I am not sure that optimizing for memory at this level and this point is really necessary.
That said (devil's advocating here a little bit), it looks like Python's timedelta class does normalize. Is this usecase useful enough to deviate from what is "accepted"?:
>>> timedelta(hours=24)
datetime.timedelta(days=1)
>>> timedelta(hours=25)
datetime.timedelta(days=1, seconds=3600)

I would like to chime in: I also think that normalised deltas are expected/assumed coming from the stdlib.
Having different behaviours for e.g. TimeDelta (normalised) and DateDelta (denormalised) is surprising, at least. (And also means DateTimeDelta has a bit of an identity crisis serving both styles of API.)
Maybe maintaining the denormalised form is out-of-scope for this component? (And could be part of a different module, if necessary?)
My uninformed point-of-view is that this library is an improvement over the behaviour of the stdlib when it comes to date and time related structures. Maintaining and exposing a more "advanced" delta API seems like a different thing altogether. That being said, my main gripe here is the departure from the normalised API in the stdlib.
Rough suggestions to move forward:

Everything consistently normalised (like datetime.timedelta), the smaller delta components roll over to the big ones.
Everything consistently denormalised (like in the canonical format), breaking understanding from stdlib.
Everything consistently denormalised through the current API (again, à la datetime.timedelta), but normalised internally and exposed with a new property/method (e.g. DateDelta.canonical_format() will not be normalised unless called after explicit normalisation DateDelta.normalize().canonical_format()).

(If that helps, I'd be happy to try my hand with a few test cases to cover an option I suggested.)

@bibz thanks for taking the time to chime in. Agree with many of your points. I'm AFK at the moment so will go more in depth in a week or so

@bibz Agree that it's good to default to 'expected behavior' (i.e. normalization) for users coming from the standard library. However: this only makes sense so far it's possible. The issue here is that while hours/minutes/seconds/milliseconds/etc can be normalized, calendar days and months cannot.
To summarize: you end up with 3 "buckets" that can be normalized internally, but not between them:

bucket 1: years and months. These can be normalized using the rule: 1 year = 12 months which is always true (in the proleptic gregorian calendar at least)
bucket 2: weeks and days. These can be normalized using the rule: 1 week = 7 days which is always true (in the proleptic gregorian calendar at least). Note that days cannot be normalized into hours, since day length may be influenced by DST (making some days 23 or 25 hours long)
bucket 3: hours, minutes, seconds, milliseconds, microseconds, nanoseconds. These can be normalized according to standardized conversions.

I'm leaning towards minimizing the 'number of buckets'. The 0.5 release DateTimeDelta currently has 5 buckets: years, months, weeks, days, and hours/minutes/seconds/etc.
Note that pendulum attempts to put everything into one bucket (using general rules like month=30 days), but that results in strange inconsistencies (see their issue tracker for numerous examples)

The issue here is that while hours/minutes/seconds/milliseconds/etc can be normalized, calendar days and months cannot.
To summarize: you always end up with at least 3 "buckets" that can be normalized internally, but not between them

Yes, this makes complete sense. Thank you for the detailed explanation.
I agree, minimising the number of buckets while maintaining (strict) equality sounds great.

Note that pendulum attempts to put everything into one bucket (using general rules like month=30 days), but that results in strange inconsistencies (see their issue tracker for numerous examples)

That sounds like a very bad decision for anything in production :scream:

The new API is part of the new release 0.6.0

authors: JaykeMeijer ariebovenberg bibz

repo: ariebovenberg/whenever


text:
python 3.7 support

released 2018-06-27
Should be simple, just a few versions and edits to dub.json

This issue should be closed now.

I found a few more changes to the headers, leave this open until I can get them in

authors: John-Colvin ariovistus atilaneves

repo: ariovistus/pyd


text:
Feat(eos_cli_config_gen): Add support for SSH connection-limit

Change Summary
Add new feature, management_ssh.connection_limit, to limit the # SSH connections to a device, which can be in range 1-100.

Related Issue(s)
Fixes #1150
Component(s) name
arista.avd.eos_cli_config_gen
Proposed changes

Added molecule tests for eos_cli_config_gen
Added new feature in 3.x.x.md
Updated the README.md in eos_cli_config_gen

management_ssh.connection_limit should be an integer in range <1-100>
Added the connection_limit to documentation templates

How to test

# Management SSH
management_ssh:
  access_groups:
    - name: CVP-ACL
      vrf: MGMT
  idle_timeout: 5
  enable: true
  connection_limit: 50
  vrfs:
     MGMT:
      enable: true

Scenario 1) Tested the above snippet and verified:
- intended/configs
- documentation/devices
Scenario 2) Tested the same snippet but this time without specifying connection_limit variable to test if there are no errors and all documentation and configuration are generated properly.
Checklist
User Checklist

N/A

Repository Checklist

[x] My code has been rebased from devel before I start
[x] I have read the CONTRIBUTING document.
[x] My change requires a change to the documentation and documentation have been updated accordingly.
[x] I have updated molecule CI testing accordingly. (check the box if not applicable)

EOS cli supports 2 knobs under connection to limit number of connection globally or per host.
EAPI-LEAF2A(config-s-sess-2-mgmt-ssh)#connection ?
  limit     Set maximum number of SSH sessions
  per-host  Set maximum number of SSH sessions from a single host

So I would go with a data model like this
connection:
  limit: < ... >
  per_host: < ... >

Does it make sense for you ?

Sure, I will make the changes.

repo: aristanetworks/ansible-avd


text:
Kirki Beginner (PHP In General)

Hi, i recently started using kirki, and i am trying to build a plugin actually to customize admin login screen. And i am having difficulties with some options like for example "spacing" option, i couldn't figure out how to apply it. I tried using theese options on theme frontend and they worked, like "typography options" but on admin login page i cant make it happen. I did though make few things work, for example form width using this.
$wp_customize->add_setting('dd_form_width', array (

   'default' => '320px',
   'transport' => 'refresh',

 ));

 Kirki::add_field( 'dd_form_width_control', array(
 	'settings' => 'dd_form_width',
 	'label'    => __( 'Form Width', 'translation_domain' ),
 	'section'  => 'dd_customize_login',
 	'type'     => 'slider',
   'description' => 'Dimensions in px',
 	'priority' => 10,
 	'default'  =>  320,
   'choices'     => array(
   	'min'  => '0',
   	'max'  => '900',
   	'step' => '1',
 ),
 ) );

And then for css
.login form {

  width: <?php echo get_theme_mod('dd_form_width'); ?>px  !important;

}

My question is how can i make "spacing" or "typography" option working on wp-login.php i am really having hard time figuring it out?
Thanks!!!

I got it resolved with help of a friend with this code
$spacing = get_theme_mod( 'my_setting' );
echo "padding: {$spacing['top']} {$spacing['right']} {$spacing['bottom']} {$spacing['left']};";

repo: aristath/kirki


text:
Is there any callback for phantomjs crash or exit in the js

hi, i want to save something into file while phantomjs crash or exit, Is there any callback for phantomjs crash or exit in the js?

A proper onExit handler that is not dependent on phantom.exit() would be really nice. Can this be reopened or should I just add a new issue?

@JamesMGreene seems like onClosing isn't being triggered in some cases.

authors: alexindigo lulufei ricardograca

repo: ariya/phantomjs


text:
Can't Change Window Position

I'm working through the Watir specs with the phantomjs driver, and it appears that the endpoint window/current/position is not functioning:
POST a position returns an empty response, then a GET shows that nothing has changed:
-> POST session/a3b23540-6498-11e5-b3b4-252c274f7203/window/current/position
   >>> http://127.0.0.1:8911/session/a3b23540-6498-11e5-b3b4-252c274f7203/window/current/position | {"x":10,"y":10}
     > {"Accept"=>"application/json", "Content-Type"=>"application/json; charset=utf-8", "Content-Length"=>"15"}
<- {"sessionId":"a3b23540-6498-11e5-b3b4-252c274f7203","status":0,"value":{}}

-> GET session/a3b23540-6498-11e5-b3b4-252c274f7203/window/current/position
<- {"sessionId":"a3b23540-6498-11e5-b3b4-252c274f7203","status":0,"value":{"x":0,"y":0}}

The spec is from "it should move the window"

Probably should be in ghostdriver project... Thanks.


text:
Multiple declarations issue after following the OO example

I'm having issues with multiple declarations in Platform.io on the ESP32. My code seems to be identical to the example, but it fails to link. I would try the example code to sanity check, but PIO doesn't make that the easiest thing.
It's saying all the Task and Scheduler methods are being redefined. These are my header files that are relevant.
restserver.h
#ifndef RESTSERVER_H
#define RESTSERVER_H

#define _TASK_TIMEOUT
#define _TASK_OO_CALLBACKS

#include <ESPAsyncWebServer.h>
#include <TaskScheduler.h>

#include "config.h"
#include "moduleservice.h"
#include "plantservice.h"

class RestServer {
public:
	ModuleService* GetModuleService() { return module_service; }
	PlantService* GetPlantService() { return plant_service; }

	RestServer(AsyncWebServer *server);
	~RestServer();
private:
	Scheduler *scheduler;
	ModuleService *module_service;
	PlantService *plant_service;
};

#endif

plantservice.h:
#ifndef PLANTSERVICE_H
#define PLANTSERVICE_H

#define _TASK_TIMEOUT
#define _TASK_OO_CALLBACKS

#include <Adafruit_Sensor.h>
#include <Adafruit_AM2320.h>
#include <TaskSchedulerDeclarations.h>

#include "config.h"

class PlantService : public Task {
public:
	bool Callback();

	void CheckSensors();
	void GetPlantInfo(char* info);

	PlantService(Scheduler* scheduler);
	~PlantService() {};
private:
	Adafruit_AM2320* am2320;
	float temperature;
	float humidity;
};

#endif

The only place where you include <TaskScheduler.h> is in the main .INO file.
Every other header file should be using <TaskSchedulerDeclarations.h>
Your restserver.h includes the former.
Hope this helps.

I'm not using the scheduler in my main file, just in restserver and its objects. I'd prefer to make the scheduler inside the rest server, mainly because it's only needed there.

Well, you are including TaskScheduler twice somewhere or Platform.io does it for you.
I do not use Platform.io - found it to be difficult to set up for I need to do.
Try to see if that is the case -OR- send me your code (all of it) to arkhipenko@hotmail.com - I won;t be able to help you based on just 2 header files.

Code can be found in this repo. Ignore the outdated Readme.

Can you try including <TaskScheduler.h> once in the main.cpp and <TaskSchedulerDeclarations.h> everywhere else? See if this resolves the compile problem.
On a separate note - your code does not really use task scheduler, definitely not the way it is intended to be used, so most probably won't work even if compiles.

you are not adding tasks to the chain
you are not calling execute() method periodically to actually do the scheduling
you are using blocking methods like delay() - a NO-NO in cooperative multitasking
you are using do {} while loops in the callbacks with a possibility of the infinite loop.

The philosophy of TaskScheduler is that it is the scheduler. All your actions are tasks and therefore classes derived from the Task.  You define the conditions by which the tasks are invoked and let the scheduler do the coordination.  I do not recommend using TS with other scheduling tools (with one exception - FreeRTOS on ESP32, but even that is still experimental).

Have a look at this: https://github.com/arkhipenko/IoT_apis2.git
Not an OO approach - but similar hardware and tasks - running a web server while reading sensors.
All on TS. Please note that as mentioned above, TS is the only scheduler.

I know I'm not calling execute, I was first setting things up and making sure it compiled. I'm pretty sure I'm using delay at points where it doesn't matter for multi-tasking, like before a restart to be sure an HTTP response sends, at the beginning of execution to give me a chance to connect with the serial console before debug output flies by, etc. Besides this, I know the code is a little rough, mostly trying to get a proof of concept running.
I think have a solution to my own problem, but I was trying to avoid creating the scheduler in the main file since it's not really needed anywhere other than the rest server.

I made the change, but I'm getting a new error
.pio/build/huzzah/src/plantservice.cpp.o:(.literal._ZN12PlantServiceC2EP9Scheduler+0x8): undefined reference to `Task::Task(unsigned long, long, Scheduler*, bool)'
.pio/build/huzzah/src/plantservice.cpp.o: In function `PlantService::PlantService(Scheduler*)':
/private path/Grow.local/grow-local-esp/grow.local/src/plantservice.cpp:30: undefined reference to `Task::Task(unsigned long, long, Scheduler*, bool)'
.pio/build/huzzah/src/plantservice.cpp.o:(.rodata._ZTV12PlantService[vtable for PlantService]+0x14): undefined reference to `Task::OnEnable()'
.pio/build/huzzah/src/plantservice.cpp.o:(.rodata._ZTV12PlantService[vtable for PlantService]+0x18): undefined reference to `Task::OnDisable()'

Code for plantservice.cpp hasn't changed

Oops, I forgot to include the defines for the configuration in the main file. It compiles now.

Great. I am closing this issue then. Good luck!

authors: arkhipenko curieos

repo: arkhipenko/TaskScheduler


text:
delete manually disabled self-destruct tasks

adjusts an example to disable a single task before it runs out of iterations. the task disables itself. without the fix in TaskScheduler.h, one can observe a memory leak, as the task which disabled itself is not deleted.
the TaskScheduler is adjusted to check the self-destruct request flag of disabled tasks and to delete such tasks.
output of original example
Free mem=354580 No of tasks=0

        No of tasks=0
        Free mem=354580

output of modified example without fix:
Free mem=354572 No of tasks=0

        No of tasks=0
        Free mem=354488

output of modified example with fix:
Free mem=354572 No of tasks=0

        No of tasks=0
        Free mem=354572

notice that the example which is modified in this PR needs #180 to compile.

Pushed into testing branch as v3.8.4

authors: arkhipenko schlimmchen


text:
Add UIViewController lifetime hooks

The version 1.5.10-beta01 of compose added UIViewController lifetime hooks (see https://github.com/JetBrains/compose-multiplatform-core/pull/779)
It is possible to do similar thing for essenty??

Yes, I think you can drive LifecycleRegistry using those callbacks.

You can use extension functions like LifecycleRegistry#create, LifecycleRegistry#resume, LifecycleRegistry#stop and LifecycleRegistry#destroy.

Closing this for now. Feel free to reopen if there are any issues.

authors: arkivanov francismariano

repo: arkivanov/Essenty


text:
Change evaluation domain API for cosets

Could the struct for an evaluation domain contain a Field element for the affine shift, which then enables it for use as any coset. This not existing required me to re-implement a subset of this logic. (The current API only supports cosets with shift g, for a subset of methods)
My suggested API:

Have two constructors, one for the subgroup case, one for the coset case.
Remove cosetFFT, instead have the FFTs switch "if affine_shift == Field::one()"
Add coset support in the lagrange interpolations. This is simple to do (see libiop: https://github.com/alexchmit/libiop-dev/blob/master/libiop/algebra/lagrange.tcc#L177. I also suggest switching to its method of doing arithmetic as it avoids doing one more pass over the array, with the same number of arithmetic ops)
Update the vanishing polynomial, this just requires setting the constant term to affine_offset^|H|

Had a discussion with @Pratyush regarding an API for this.

Make Domain have two constructors, new_subgroup(subgroup_size) and new_coset(coset_size, offset).
Remove cosetFFT / cosetIFFT methods
Add a convenience method domain.get_coset(offset), to make it easy to go from subgroup -> coset.

Are these changes still wanted? If so I'm happy to submit a pull request for this

Yes!

authors: Pratyush ValarDragon andrewmilson

repo: arkworks-rs/algebra


text:
Deprecated divn and implemented core::ops::Shr

Description
This PR closes https://github.com/arkworks-rs/algebra/issues/714. I choose to add #deprecate annotation to divn() instead of removing them to keep the backward compatibility. Let me know if it's best to remove such old function.

Can someone help me with the "CI / Test against curves (bls12_377)" test? AFAIK, I modified the files that the check is complaining about as you can see in the "Files Changed" tab. Why is it failing?

can you please make two separate pull requests for Shr and Shl?

Done! you can consider this as the PR for core::ops::Shr in place of divn(). Unfortunatelly, the check that was failing before still fails. Do you know why is this?

Done! you can consider this as the PR for core::ops::Shr in place of divn(). Unfortunatelly, the check that was failing before still fails. Do you know why is this?

Hi @hdvanegasm, we saw that this check fails because you've deprecated the functions described by the error message. You must change these to the new replacements and the check will pass

Hi @z-tech. Thanks for your reply. Notice that the check is complaining about lines that where changed in this PR. An example of this is presented here: https://github.com/arkworks-rs/algebra/pull/736/files#diff-7bfbb2ccb1c569a529a64dfba848ae83498a02f8f3012fbd7b2c87f0c11c904eR830. You may take a look at the changed files and you will find that all the lines that the check is showing are changed already for the operator >>. Let me know if I'm wrong in this 😄

Is it possible that this check is failling because the CI file is pointing to an old version of the repo? Take a look at this: https://github.com/arkworks-rs/algebra/blob/d9527c832888ffbd9231999b30a700ce3e572c16/.github/workflows/ci.yml#L420

Is it possible that this check is failling because the CI file is pointing to an old version of the repo? Take a look at this:
https://github.com/arkworks-rs/algebra/blob/d9527c832888ffbd9231999b30a700ce3e572c16/.github/workflows/ci.yml#L420

I see. If you remove this does it work? If yes, it is safe to remove we have archived this repo.

Is it possible that this check is failling because the CI file is pointing to an old version of the repo? Take a look at this:
https://github.com/arkworks-rs/algebra/blob/d9527c832888ffbd9231999b30a700ce3e572c16/.github/workflows/ci.yml#L420

I see. If you remove this does it work? If yes, it is safe to remove we have archived this repo.

I removed the check completely. Let me know if this is what you were looking for.

authors: hdvanegasm mmaker z-tech


text:
bump dependencies

Applied mkpr on package.json
/tmp/mkpr.sh

Pull Request Test Coverage Report for Build 5902293406

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 92.778%

Totals

Change from base Build 5902231474:
0.0%

Covered Lines:
413

Relevant Lines:
436

💛  - Coveralls


text:
🛑 NTFV is down

In 8f28a3b, NTFV (https://ntfv.de) was down:

HTTP code: 0
Response time: 0 ms

Resolved: NTFV is back up in d37aac2 after 7 minutes.

repo: arnef/status


text:
browser extension

Add browser file for browser extension

added code to start off with
https://github.com/aroary/lorem_ipsum/pull/28/commits/8fd3064866c9354b1097faa4eb6da11493551755 https://github.com/aroary/lorem_ipsum/pull/28/commits/b98be0a9b01494568396cb380c23e9b57cd0fa9b https://github.com/aroary/lorem_ipsum/pull/28/commits/b1db23aa1e64c4220c5e15a9adcf5e421295c13a https://github.com/aroary/lorem_ipsum/pull/28/commits/de3534d5e2a69f9028829d91de3f6313ef068727 https://github.com/aroary/lorem_ipsum/pull/28/commits/0d24ed445b84145cdad3cb9dc90ab936637fb72e


text:
Creating a  Real Time Chat App with HTML,CSS , Node js and socket.io

Issue Type:
I want to add a new project , of a Real time chat web application , where I will  Design the interface of this application using HTML ,CSS and Javascript and also use Node Js and Socket.io for a real time chat based support to this application .

@arpit456jain   can you please assign this issue to me , I will make a entire real time chat app with a good design and also real time chat feature .

Hello Sir . I have completed this task and prepared a real time chat application with socket io with attractive UI . so plz assign this issue to me . I will make a pull request immediately .

I was on the verge of completion this app. Why was my issue closed ? Please
I will create another issue ..please assign it to me
On Sun, 6 Mar, 2022, 12:23 am Arpit Jain, @.***> wrote:

Closed #234
https://github.com/arpit456jain/Amazing-Js-Projects/issues/234.
—
Reply to this email directly, view it on GitHub
https://github.com/arpit456jain/Amazing-Js-Projects/issues/234#event-6189758575,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ASRPCWQ54RP2G6ID7RBUFVDU6OURJANCNFSM5PZRSEOQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you were assigned.Message ID:
@.***
com>


text:
How to set the N?N is a num (0,1,,,)?

Thanks,author!
I am suffer from some issues when trained a model and want to generate some samples simply run;
when I execute "python main.py --start-epoch=N add-epochs=0 --train=False"this line,some error appear.
can you share execute comand line?
where N is the checkpoint ,I have a little confused what it is a num or produced model? i have produced the model eg.BEGAN_64_64_0005.tfmod.data-00000-of-00001.
can you give some guide?
thanks again!

This repository is aimed at people with a working knowledge of python and tensorflow, please learn those if you would like to use the code

authors: DLjiaerlin artcg

repo: artcg/BEGAN


text:
🛑 Matrix (client) is down

In 04e0232, Matrix (client) (https://matrix.artemislena.eu) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Matrix (client) is back up in afe0c97.

repo: artemislena/upptime


text:
deploy to EMR from windows, outside docker

Update to make local paths cross platform to deploy code to EMR from windows. Involves:

using pathlib
dealing with files with crlf end of line (windows), forced to lf (linux/mac) since not supported by AWS EMR steps.

Other:

Added first tests for deploy.py
print -> logger.info

Moved to v0.9.21, published

cc @AlejandroUPC : this includes some of things you highlighted, more unit-tests and moving 'print' to 'logger.info'

repo: arthurprevot/yaetos


text:
RpmTest.java:78-80: Extract primary.xml location tag...

The puzzle 376-24e83852 from #376 has to be resolved:
https://github.com/artipie/rpm-adapter/blob/d9cdb6ef33d812e185cbdf8b76de5c9bfc8efe43/src/test/java/com/artipie/rpm/RpmTest.java#L78-L80
The puzzle was created by milkysoft on 07-May-21.
Estimate: 30 minutes,  role: DEV.
If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

The puzzle 376-24e83852 has disappeared from the source code, that's why I closed this issue.

repo: artipie/rpm-adapter


text:
Add bidding topic

Request
Add support for newly added bidding topic.
fixes: #13
Solution
Added new worker for bidding topic.
Added condition for properly process bidding events and post it to subscribed channels.

cc: @dblock

Tests!? @bhoggard feel free to merge

@dblock yes we missed tests for event service, I'll add test for all of them later.

repo: artsy/aprb


text:
Feedback 'From: Kmefmiem Jdnfidnf Banners too narrow shou...'

Message from 57fe450d139b2151650006b5 sent on 2016-10-12 14:15:30 UTC###

From: Kmefmiem Jdnfidnf
Banners too narrow should be 160 tall

Link to HockeyApp

https://rink.hockeyapp.net/manage/apps/37020/feedback/637307

Continuing from here https://github.com/artsy/eigen/issues/1439
@katarinabatina The banners are currently 160 points on both iPhone and iPad, should there be a difference?

I fucked up on the spec sorry, I said the value was 160 when in reality its 300

I should have caught that too, 160 points was very narrow indeed.

authors: alloy artsyit katarinabatina

repo: artsy/eigen


text:
chore: prepare for next release

This PR updates the app version to prepare for next release. #nochangelog

Warnings

:warning:

✅ No changelog changes

  Generated by :no_entry_sign: dangerJS against 63adc21466a3ee930573482fca907b5f44c6d5c7

authors: ArtsyOpenSource artsyit


text:
Move iPad Lot View to Collection Views

The iPad-is-special approach was introducing a lot of inconsistencies and minor UI bugs. This move it to use the same collection view-based approach as on iPhone, with a scaled-back layout. It also fixes a problem with the lot list that had the thumbnails stretched unnaturally.

Yep - that snapshot looks much better in tretrospect

        2 Warnings

  </th>
 </tr>

:warning:
Needs testing on a Phone if change is non-trivial

:warning:
Detected some Swift building time outliers

Time | Class | Function |
| --- | ----- | ----- |260.4ms | AuctionViewController.swift | @objc dynamic func showRefineTappedAnimated(animated: Bool)
201.7ms | SwiftyJSON.swift | get {}
177.7ms | WebSocket.swift | private func processRawMessage(buffer: UnsafePointer, bufferLen: Int)
76.6ms | Observable.swift | private final func nextTokenHash() -> Int
67.1ms | AuctionLotMetadataStackScrollView.swift | required init(viewModel: LiveAuctionLotViewModelType, sideMargin: String)
59.4ms | RefinementOptionsViewController+Private.swift | func stackView() -> ORStackView

  Generated by :no_entry_sign: danger

Cool, given it a second look, looks 👍 on 🍏

authors: ArtsyMobile ashfurrow orta


text:
fix: pass empty filters to saved search button

The type of this PR is: TYPE

This PR resolves []
Description
Small fixes for Saved Search Button M2

PR Checklist (tick all before merging)

[ ] I have included screenshots or videos to illustrate my changes, or I have not changed anything that impacts the UI.
[x] I have tested my changes on iOS and Android.
[x] I have added tests for my changes, or my changes don't require testing, or I have included a link to a separate Jira ticket covering the tests.
[x] I have added a feature flag, or my changes don't require a feature flag. (How do I add one?)
[x] I have documented any follow-up work that this PR will require, or it does not require any.
[x] I have added an app state migration, or my changes do not require one. (What are migrations?)
[x] I have added a changelog entry below or my changes do not require one.

Changelog updates
Changelog updates

Cross-platform user-facing changes

Pass empty filters to saved search when empty criteria

iOS user-facing changes

Android user-facing changes

Dev changes

This PR contains the following changes:

Cross-platform user-facing changes (Pass empty filters to saved search when empty criteria)

  Generated by :no_entry_sign: dangerJS against 6c6432c87fb22f2a7d0b8cce3ddbd57baf7653ce

authors: ArtsyOpenSource dimatretyak


text:
Devote a day to converting the app to use Realm

It could prove worth our time in the longer run.

At this point it'd be better to move to RN + Relay.

repo: artsy/energy


text:
fix: add .tool-versions to the project

Description
.tool-versions with ruby version 2.7.4

PR Checklist

[ ] I tested my changes on iOS and Android.
[ ] I added screenshots or videos to illustrate my changes.
[ ] I added Tests and Stories for my changes.

To the reviewers 👀

[ ] I would like at least one of the reviewers to run this PR on the simulator or device.

Changelog updates
Changelog updates

Cross-platform user-facing changes

iOS user-facing changes

Android user-facing changes

Dev changes

add .tool-versions with ruby 2.7.4 - gkartalis

Need help with something? Have a look on our docs, or get in touch with us.

oh you already updated the code, nvm then LGTM

authors: MounirDhahri gkartalis


text:
chore: Add missing SF env vars to Server/config.ts

The type of this PR is: Chore

Description

During https://github.com/artsy/force/pull/12303, 3 news environment variables were added to Salesforce Wrapper, but these variables were not added to Server/config.ts
See this thread for details
cc @artsy/negotiate-devs

Thank you! On V2, we added it on this PR.

repo: artsy/force


text:
Add viewing-room to pageview exclude

Missed the Viewing Room app from https://github.com/artsy/force/pull/5584

Warnings

:warning:
The staging version of Metaphysics has breaking changes, this might not affect your build, but could mean your queries don't work the way you expect. See below for breaking changes:

:warning: Member 'Sale' was added to Union type 'OrderedSetItem'
:warning: Member 'Show' was added to Union type 'OrderedSetItem'

  Generated by :no_entry_sign: dangerJS against b0f3e337437c2179642ff5ea819fd8894ab4ecfb

authors: ArtsyOpenSource damassi


text:
bugfix: [SEO/Shows] Fix 404 link back to inactive fairs

Addresses fairs portion of https://artsyproduct.atlassian.net/browse/GRO-208
We were running into an issue where after a fair has run and is no longer listed, links back to the fair from shows within the fair 404 leading to an SEO hit. This PR hides the link back.
cc @artsy/grow-devs

@The-Beez-Kneez - Gonna merge since you're out for the rest of the week!


text:
[draft] refactor(GRO-389): inquiry modal form

As I mentioned — there will be two parts to this; the inquiry form (this) followed by the inquiry questionnaire. This is the bulk of the form. I ran into some hurdles where I have to fix some things minor input things in Palette. And in Metaphysics we never implemented the logged out params for the inquiry mutation (so I'll be doing that next before wrapping this up).
Currently looks like:

OK — it actually appears we no longer allow logged out inquiries — we check to see if the email is associated with the account and ask them to login, or prompt for a sign up otherwise.

Some minor things left here but this should be good to merge (won't be called anywhere yet). I'm going to switch to the questionnaire part and then once that's done give everything a final Q/A + layer of polish.


text:
Add OWASP dependency-check

The dependency-check identifies the projects dependencies and reports on
known vulnerabilities.
The build fails when the CVSS score is equal or above the severity level
medium.
Current output:
> Task :dependencyCheckAnalyze
Verifying dependencies for project detekt
Checking for updates and analyzing dependencies for vulnerabilities
Generating report for project detekt
Found 0 vulnerabilities in project detekt
``

I think it's weird that the build hangs on Windows using the JDK 1.8.

I've restarted it

Codecov Report

Merging #1778 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #1778   +/-   ##
=========================================
  Coverage     79.76%   79.76%
  Complexity     1932     1932
=========================================
  Files           323      323
  Lines          5496     5496
  Branches       1019     1019
=========================================
  Hits           4384     4384
  Misses          588      588
  Partials        524      524

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 62366ce...cf42488. Read the comment docs.

Unable to download meta file: https://nvd.nist.gov/feeds/json/cve/1.0/nvdcve-1.0-modified.meta

They seem do have some throttling going on to prevent abuse.
I added a property failOnError = false so that the build doesn't fail, when an error like this happens.

failOnError = false doesn't help.

They seem do have some throttling going on to prevent abuse.

Looks like one needs to setup a local mirror on any kind of server, which we don't have.

Thats sad, many more people reporting this behavior. There is also 5.2 out, but I don't thing this will solve these issues. So closing this?

authors: arturbosch codecov-io schalkms

repo: arturbosch/detekt


text:
🛑 Support Site is down

In 5034d2b, Support Site (https://www.vnhosts.net) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Support Site is back up in 136dcf4.


text:
Add support to query ECOS device API through orchestrator /appliance/rest endpoint

It would be very useful if the EdgeConnect class could be extended so that it authenticates through Orchestrator and pulls data through orchestrator via the /appliance/rest/{nePk}/{url} Orchestrator Endpoint.
This appears to be a reverse proxy into the device-level/ECOS API so that any of the API commands the EdgeConnect class can run directly, the same commands can be run by appending the API endpoint URL to this Orchestrator API endpoint.
This removes the need to try and route from the automation system to each individual appliance since some commands (such as adding static routes) require talking to the device API directly rather than to the Orchestrator API.
It looks like the URL passed to EdgeConnect class is not used directly, so doesn't seem like we could just hack on a url="customer-orch-use1.silverpeak.cloud/gms/rest/appliance/rest/0.NE/" value to the EdgeConnect class during instantiation to trick it into doing this in with the current code.

The endpoints in the Orchestrator class already exist for those passthrough GET/POST/DELETE functions.
The value here would be leverage the existing work of parameter setup/endpoint format from the EdgeConnect class functions rather than having to look them up from source code and/or swagger.
As you noted, while this idea could be achieved, it would take some dedicated time on implementing cross-compatible logic which right now can't be a priority. For right now I'm going to close this as not planned.

authors: cdwchriburg zachcamara-hpe

repo: aruba/pyedgeconnect


text:
possible to set memcache 'expire' on locks?

Hi, First of all thanks for the great library!  Here I have some problems with un-released locks.
I am calling many 3rd party libraries between lock & release.  Very occasionally I could get a fatal crash that the lock is never cleaned up.
My process typically takes 3~5 sec to complete, is it possible to set an expire value for the lock?
E.g. 60 sec, so it is not locked forever.
I could see the alternative maybe using flock so file system handles it...
My code is very simple like this:
$mutex = new Mutex('very-critical-stuff', $lock);
if ($mutex->acquireLock(1000)) {
    // calling many 3rd party libraries.
    // !!! Fatal error crash.
    // the lock is never released
    $mutex->releaseLock();
} else {
    throw new Exception('Unable to gain lock!');
}

https://github.com/arvenil/ninja-mutex/pull/13 Will that work for you?

@arvenil You are awesome!
I carefully read everything you wrote in the fix.  It will work for me but I wouldn't recommend it for anyone else.  I should use an expire time like 100x of the typical processing time.
It is up to you to merge this into master branch.  The potential racing problem is pretty hard to deal with.    I don't want people complain about ninjia-mutex because of this change; changing my code to use flock or mySQL is probably easier.

Awesome :)
No worries, the ->setExpiration() method is optional, by default there is no expiration. Just a warning that it may be dangerous should be enough.
Thanks for your issue report! :)

Resolved by https://github.com/arvenil/ninja-mutex/releases/tag/0.5.0

authors: arvenil reedgz

repo: arvenil/ninja-mutex


text:
Updates data catalog filter options.

Fixes CILogon token expire time.
Adds option to send password reset emails using local/trusted server.

@DanielJMaher This PR is currently on uframe.ooi for testing purposes.  Contact me if you have questions.

@oceanzus Bug found: Go to data catalog, toggle mobile assets only, observe count (37), toggle on metadata streams, observe count (37), toggle off metadata streams, observe count (55).  Should still be 37.

authors: DanielJMaher oceanzus

repo: asascience-open/ooi-ui


text:
单击跟双击事件冲突啊

实现了onClick后，双击事件 默认放大被拦截啊，麻烦问一下怎么解决

我实现的是单击让看大图消失

@jeffy7 兄台，我跟你是一样的需求一样的问题，请问你现在解决了吗？

最新版好像解决这个问题了，我最近合了一个 pr。https://github.com/ascoders/react-native-image-zoom/pull/27

@ascoders 感谢！更新到 2.0.12 ，解决了这个问题。

@ascoders 您好！在真机测试中，我左手拿手机，如果用右手食指去操作，不论单击（关闭）或双击（放大/取消放大），效果都很好；但如果用左手拇指去操作，单击没反应，双击变成了关闭（单击的效果）。是因为拇指接触屏幕的面积大，还是因为双击速度不够快呢？该如何解决， 敬请指点！谢谢！

双击变成单击效果，可能由于双击速度不够快。单击必须在很小的位移范围内抬起才会触发，如果按下去后移动了比较大一段距离，再抬起来，就当作没有触发单击。

@ascoders 我发现了一个bug，在图片没下载下来的时候，滑动，会崩溃在，

(void)URLRequest:(id)requestToken didReceiveData:(NSData *)data
{
if (![self validateRequestToken:requestToken]) {
return;
}
if (!_data) {
_data = [NSMutableData new];
}
[_data appendData:data];

appendData 这里，应该是图片下载的问题，我本来就不想用组件，于是我在
loadImage(index) {}
强制返回了成功，图片下载我交给native的SD去做，

repo: ascoders/react-native-image-viewer


text:
Shade-in jimfs and ecj into java-compiler-testing module

Since jimfs and ecj do not provide valid automatic-module manifest entries for their projects, consider shading in jimfs and ecj into java-compiler-testing for now to prevent risk of module names changing and breaking this library in the future.
We must first ensure that their licenses are compatible with the license in this project, and shading must include their license headers in our distributed JAR.

JIMFS shouldn't be necessary as there is a potential release being made at some point to include Java 9 support: https://github.com/google/jimfs/issues/204#issuecomment-1238147551

Closing as right now this is not overly important. Will reopen if this becomes some issue in the future.

repo: ascopes/jct


text:
Added a note to legacy.rst (#1114) and updated versioning.py

Added a note to legacy.rst (#1114) and updated versioning.py

@KenMighell this PR hasn't seen activity in nearly 6 months, so I'm going to close it.  Please feel free to reopen it if you'd still like to get this change in.

authors: KenMighell eslavich

repo: asdf-format/asdf


text:
Update README.md

Enhance README.md
[EDIT] Let me know if I need to change or add something more, Thank you.

This looks good.
Thanks for contributing.

This looks good.
Thanks for contributing.


text:
いいところ診断の結果に優しさを追加したい

以下の結果を追加したい
'{userName}のいいところは優しさです。あなたの優しい雰囲気や立ち振る舞いに多くの人が癒やされています。'

これから対応します

d879a30 で対応されました。


text:
Why does the v3 version not support YAML decoding

I tried to use the YAML decoder to read the YAML configuration file but found that the v3 version does not support YAML anymore, and the v2 version is supported. What is the reason for removing YAML? And how do I parse the YAML configuration file?

The majority of third party code has moved in to the plugins directory. See https://github.com/asim/go-micro/tree/master/plugins/config/encoder/yaml

The majority of third party code has moved in to the plugins directory. See https://github.com/asim/go-micro/tree/master/plugins/config/encoder/yaml

Thank you very much for your answers

authors: EnigmaOppo asim

repo: asim/go-micro


text:
Wrong WMI class for "AutoPackage - OSArchitecture x64" condition

AutoPackage - OSArchitecture x64 condition creates a rule for the Win32_ComputerSystem class looking for an OSArchitecture property. This property is a member of the Win32_OperatingSystem class.
Line 33 of CreateGlobalConditionsAndRequirements.ps1 should be the following:
New-CMGlobalConditionWqlQuery -DataType String -Class Win32_OperatingSystem -Namespace root\cimv2 -Property OSArchitecture -WhereClause "OSArchitecture = '64-bit'" -Name "AutoPackage - OSArchitecture x64" -Description "Returns True if Win32_OperatingSystem is True. Use as existential rule for 64-bit operating system"

Copy-paste strikes again! This is fixed in the latest commit. Thanks!

Reopening this issue. The Global Condition is now correct, but the requirement added to the template app (and the requirements in the recipes) are incorrect. They should be existential not True/False

authors: asjimene cedricmordrin

repo: asjimene/SCCM-Application-Packager


text:
How to run multiple Gekko Docker instances in command line mode

Can you please confirm how I would be able to run multiple Gekko instances via different Docker images/containers.
The idea is to have each Gekko instance launch with a different configuration (i.e. config-usdbtc.js on Gekko1, config-usd-eth.js on Gekko2 etc)
The reason for this is to initially get Telegram notices and run different configurations.
I am unclear what else I might need to do - so far I think that I need to have a docker-compose like this:
server:
  restart: always
  build: ./
  volumes:
    - ./volumes/gekko-usdbtc/history:/usr/src/app/history
    - ./config-usdbtc.js:/usr/src/app/config.js
  links:
    - redis
  environment:
   - HOST
   - PORT
  ports:
    - "${PORT}:${PORT}"

server2:
  restart: always
  image: gekko_server  # optionally, you can still do "build: ./", but it makes more sense to just reuse
  volumes:
    - ./volumes/gekko-usdeth/history:/usr/src/app/history
    - ./config-usdeth.js:/usr/src/app/config.js
  links:
    - redis
  environment:
   - HOST
   - PORT
  ports:
    - "${PORT}:${PORT}"

redis:
  image: redis:latest
  volumes:
    - ./volumes/redis:/data

and then adjust package.json to remove the --ui-option:
...
    "start": "node ./gekko --config config.js --ui"
...

The Dockerfile would need to include the Telegram bot:
...
npm install --production redis@0.10.0 talib@1.0.2 tulind@0.8.7 node-telegram-bot-api@0.24.0 pg && \
...

Questions:

What is Redis used for and will there be an issue if multiple dockers with different currency pairs reference the same Redis?

Could you think of any case where this could not work or if I miss something else?

I created some virtual machines to run different strategies and different pairs

I solved by modify docker-compose.yml adding a variable for volume:
- ./volumes/gekko_${COMPOSE_PROJECT_NAME}/history:/usr/src/app/history
then build this way:
COMPOSE_PROJECT_NAME=gekko2 docker-compose build
and run this way:
COMPOSE_PROJECT_NAME=gekko2 HOST=1xx.xx.xx.xx PORT=3002 docker-compose up -d

repo: askmike/gekko


text:
Padding in Tensorflow vs Pytorch

Hey I had a quick question regarding padding. I don't have a ton of experience with Pytorch, but as far as I can tell from this, it seems that the layer adds the parameter padding of zeros to each axis of the input.
However, in your implementation, you use padding='same'. In the original implementation in pytorch, the author uses padding=1. I'm under the impression that to get the padding the same, we would need to specify the padding manually in tensorflow.
Am I missing something here where Tensorflow is taking care of something under the hood that I'm not understanding?

Hi @zanussbaum,
Thanks for the info. It's been a while since I wrote this, and I'm not familiar with PyTorch syntax so I'm not sure if there is a discrepancy. I remember when I originally wrote this I followed the original Lua code, https://github.com/szagoruyko/wide-residual-networks/blob/master/models/wide-resnet.lua.
If you think there is a discrepancy and can improve on the model results currently obtained, I happily accept pull requests.
Thanks again! :)

Thanks I'll try and see what's going on. If there's not a discrepancy, at least I'll hopefully understand everything a little more :)


text:
Update branding to preview 8

aspnet/AspNetCore-Internal#2722

Do not merge before we branch

repo: aspnet/AspNetCore-Tooling