text:
Hessian throws error

I am trying to run the example from the Readme.md file but computing hessians instead of gradients, and getting an error for both Zygote and ForwardDiff.
using Quadrature, ForwardDiff, FiniteDiff, Zygote, Cuba
f(x,p) = sum(sin.(x .* p))
lb = ones(2)
ub = 3ones(2)
p = [1.5,2.0]

function testf(p)
    prob = QuadratureProblem(f,lb,ub,p)
    sin(solve(prob,CubaCuhre(),reltol=1e-6,abstol=1e-6)[1])
end

hp1 = Zygote.hessian(testf,p) # throws error
hp2 = FiniteDiff.finite_difference_hessian(testf,p) # ok
hp3 = ForwardDiff.hessian(testf,p) # throws error

Status `~/.julia/environments/v1.6/Project.toml`
[67601950] Quadrature v1.9.0
[f6369f11] ForwardDiff v0.10.18
[e88e6eb3] Zygote v0.6.14
[8a292aeb] Cuba v2.2.0
[6a86dc24] FiniteDiff v2.8.0

stacktrace for ForwardDiff.hessian(testf,p)
MethodError: no method matching Float64(::ForwardDiff.Dual{ForwardDiff.Tag{typeof(testf), Float64}, Float64, 2})
Closest candidates are:
(::Type{T})(::Real, ::RoundingMode) where T<:AbstractFloat at rounding.jl:200
(::Type{T})(::T) where T<:Number at boot.jl:760
(::Type{T})(::AbstractChar) where T<:Union{AbstractChar, Number} at char.jl:50
...
Stacktrace:
[1] convert(#unused#::Type{Float64}, x::ForwardDiff.Dual{ForwardDiff.Tag{typeof(testf), Float64}, Float64, 2})
@ Base ./number.jl:7
[2] setindex!(A::Vector{Float64}, x::ForwardDiff.Dual{ForwardDiff.Tag{typeof(testf), Float64}, Float64, 2}, i1::Int64)
@ Base ./array.jl:839
[3] macro expansion
@ ./broadcast.jl:984 [inlined]
[4] macro expansion
@ ./simdloop.jl:77 [inlined]
[5] copyto!
@ ./broadcast.jl:983 [inlined]
[6] copyto!
@ ./broadcast.jl:947 [inlined]
[7] materialize!
@ ./broadcast.jl:894 [inlined]
[8] materialize!(dest::Vector{Float64}, bc::Base.Broadcast.Broadcasted{Base.Broadcast.DefaultArrayStyle{0}, Nothing, typeof(*), Tuple{ForwardDiff.Dual{ForwardDiff.Tag{typeof(testf), Float64}, Float64, 2}, Float64}})
@ Base.Broadcast ./broadcast.jl:891
[9] (::Quadrature.var"#79#95"{QuadratureProblem{false, Vector{ForwardDiff.Dual{ForwardDiff.Tag{typeof(testf), Float64}, ForwardDiff.Dual{ForwardDiff.Tag{typeof(testf), Float64}, Float64, 2}, 2}}, typeof(f), Vector{Float64}, Vector{Float64}, Base.Iterators.Pairs{Union{}, Union{}, Tuple{}, NamedTuple{(), Tuple{}}}}, Vector{Float64}, Vector{Float64}, Vector{ForwardDiff.Dual{ForwardDiff.Tag{typeof(testf), Float64}, Float64, 2}}})(x::Vector{Float64}, dx::Vector{Float64})
@ Quadrature ~/.julia/packages/Quadrature/rcCut/src/Quadrature.jl:412
[10] generic_integrand!(ndim::Int32, x_::Ptr{Float64}, ncomp::Int32, f_::Ptr{Float64}, func!::Quadrature.var"#79#95"{QuadratureProblem{false, Vector{ForwardDiff.Dual{ForwardDiff.Tag{typeof(testf), Float64}, ForwardDiff.Dual{ForwardDiff.Tag{typeof(testf), Float64}, Float64, 2}, 2}}, typeof(f), Vector{Float64}, Vector{Float64}, Base.Iterators.Pairs{Union{}, Union{}, Tuple{}, NamedTuple{(), Tuple{}}}}, Vector{Float64}, Vector{Float64}, Vector{ForwardDiff.Dual{ForwardDiff.Tag{typeof(testf), Float64}, Float64, 2}}})
@ Cuba ~/.julia/packages/Cuba/KIQTB/src/Cuba.jl:92
[11] dointegrate!
@ ~/.julia/packages/Cuba/KIQTB/src/cuhre.jl:40 [inlined]
[12] dointegrate
@ ~/.julia/packages/Cuba/KIQTB/src/Cuba.jl:195 [inlined]
[13] cuhre(integrand::Quadrature.var"#79#95"{QuadratureProblem{false, Vector{ForwardDiff.Dual{ForwardDiff.Tag{typeof(testf), Float64}, ForwardDiff.Dual{ForwardDiff.Tag{typeof(testf), Float64}, Float64, 2}, 2}}, typeof(f), Vector{Float64}, Vector{Float64}, Base.Iterators.Pairs{Union{}, Union{}, Tuple{}, NamedTuple{(), Tuple{}}}}, Vector{Float64}, Vector{Float64}, Vector{ForwardDiff.Dual{ForwardDiff.Tag{typeof(testf), Float64}, Float64, 2}}}, ndim::Int64, ncomp::Int64; nvec::Int64, rtol::Float64, atol::Float64, flags::Int64, minevals::Int64, maxevals::Int64, key::Int64, statefile::String, spin::Ptr{Nothing}, abstol::Missing, reltol::Missing)
@ Cuba ~/.julia/packages/Cuba/KIQTB/src/cuhre.jl:97
[14] __solvebp_call(::QuadratureProblem{false, Vector{ForwardDiff.Dual{ForwardDiff.Tag{typeof(testf), Float64}, ForwardDiff.Dual{ForwardDiff.Tag{typeof(testf), Float64}, Float64, 2}, 2}}, typeof(f), Vector{Float64}, Vector{Float64}, Base.Iterators.Pairs{Union{}, Union{}, Tuple{}, NamedTuple{(), Tuple{}}}}, ::CubaCuhre, ::Quadrature.ReCallVJP{Quadrature.ZygoteVJP}, ::Vector{Float64}, ::Vector{Float64}, ::Vector{ForwardDiff.Dual{ForwardDiff.Tag{typeof(testf), Float64}, Float64, 2}}; reltol::Float64, abstol::Float64, maxiters::Int64, kwargs::Base.Iterators.Pairs{Union{}, Union{}, Tuple{}, NamedTuple{(), Tuple{}}})
@ Quadrature ~/.julia/packages/Quadrature/rcCut/src/Quadrature.jl:471
[15] __solvebp(::QuadratureProblem{false, Vector{ForwardDiff.Dual{ForwardDiff.Tag{typeof(testf), Float64}, ForwardDiff.Dual{ForwardDiff.Tag{typeof(testf), Float64}, Float64, 2}, 2}}, typeof(f), Vector{Float64}, Vector{Float64}, Base.Iterators.Pairs{Union{}, Union{}, Tuple{}, NamedTuple{(), Tuple{}}}}, ::CubaCuhre, ::Quadrature.ReCallVJP{Quadrature.ZygoteVJP}, ::Vector{Float64}, ::Vector{Float64}, ::Vector{ForwardDiff.Dual{ForwardDiff.Tag{typeof(testf), Float64}, ForwardDiff.Dual{ForwardDiff.Tag{typeof(testf), Float64}, Float64, 2}, 2}}; kwargs::Base.Iterators.Pairs{Symbol, Float64, Tuple{Symbol, Symbol}, NamedTuple{(:reltol, :abstol), Tuple{Float64, Float64}}})
@ Quadrature ~/.julia/packages/Quadrature/rcCut/src/Quadrature.jl:583
[16] solve(::QuadratureProblem{false, Vector{ForwardDiff.Dual{ForwardDiff.Tag{typeof(testf), Float64}, ForwardDiff.Dual{ForwardDiff.Tag{typeof(testf), Float64}, Float64, 2}, 2}}, typeof(f), Vector{Float64}, Vector{Float64}, Base.Iterators.Pairs{Union{}, Union{}, Tuple{}, NamedTuple{(), Tuple{}}}}, ::CubaCuhre; sensealg::Quadrature.ReCallVJP{Quadrature.ZygoteVJP}, kwargs::Base.Iterators.Pairs{Symbol, Float64, Tuple{Symbol, Symbol}, NamedTuple{(:reltol, :abstol), Tuple{Float64, Float64}}})
@ Quadrature ~/.julia/packages/Quadrature/rcCut/src/Quadrature.jl:153
[17] testf(p::Vector{ForwardDiff.Dual{ForwardDiff.Tag{typeof(testf), Float64}, ForwardDiff.Dual{ForwardDiff.Tag{typeof(testf), Float64}, Float64, 2}, 2}})
@ Main ./In[1]:9
[18] vector_mode_dual_eval
@ ~/.julia/packages/ForwardDiff/QOqCN/src/apiutils.jl:37 [inlined]
[19] vector_mode_gradient(f::typeof(testf), x::Vector{ForwardDiff.Dual{ForwardDiff.Tag{typeof(testf), Float64}, Float64, 2}}, cfg::ForwardDiff.GradientConfig{ForwardDiff.Tag{typeof(testf), Float64}, ForwardDiff.Dual{ForwardDiff.Tag{typeof(testf), Float64}, Float64, 2}, 2, Vector{ForwardDiff.Dual{ForwardDiff.Tag{typeof(testf), Float64}, ForwardDiff.Dual{ForwardDiff.Tag{typeof(testf), Float64}, Float64, 2}, 2}}})
@ ForwardDiff ~/.julia/packages/ForwardDiff/QOqCN/src/gradient.jl:106
[20] gradient
@ ~/.julia/packages/ForwardDiff/QOqCN/src/gradient.jl:19 [inlined]
[21] #106
@ ~/.julia/packages/ForwardDiff/QOqCN/src/hessian.jl:16 [inlined]
[22] vector_mode_dual_eval
@ ~/.julia/packages/ForwardDiff/QOqCN/src/apiutils.jl:37 [inlined]
[23] vector_mode_jacobian(f::ForwardDiff.var"#106#107"{typeof(testf), ForwardDiff.HessianConfig{ForwardDiff.Tag{typeof(testf), Float64}, Float64, 2, Vector{ForwardDiff.Dual{ForwardDiff.Tag{typeof(testf), Float64}, ForwardDiff.Dual{ForwardDiff.Tag{typeof(testf), Float64}, Float64, 2}, 2}}, Vector{ForwardDiff.Dual{ForwardDiff.Tag{typeof(testf), Float64}, Float64, 2}}}}, x::Vector{Float64}, cfg::ForwardDiff.JacobianConfig{ForwardDiff.Tag{typeof(testf), Float64}, Float64, 2, Vector{ForwardDiff.Dual{ForwardDiff.Tag{typeof(testf), Float64}, Float64, 2}}})
@ ForwardDiff ~/.julia/packages/ForwardDiff/QOqCN/src/jacobian.jl:147
[24] jacobian(f::Function, x::Vector{Float64}, cfg::ForwardDiff.JacobianConfig{ForwardDiff.Tag{typeof(testf), Float64}, Float64, 2, Vector{ForwardDiff.Dual{ForwardDiff.Tag{typeof(testf), Float64}, Float64, 2}}}, ::Val{false})
@ ForwardDiff ~/.julia/packages/ForwardDiff/QOqCN/src/jacobian.jl:21
[25] hessian(f::Function, x::Vector{Float64}, cfg::ForwardDiff.HessianConfig{ForwardDiff.Tag{typeof(testf), Float64}, Float64, 2, Vector{ForwardDiff.Dual{ForwardDiff.Tag{typeof(testf), Float64}, ForwardDiff.Dual{ForwardDiff.Tag{typeof(testf), Float64}, Float64, 2}, 2}}, Vector{ForwardDiff.Dual{ForwardDiff.Tag{typeof(testf), Float64}, Float64, 2}}}, ::Val{true})
@ ForwardDiff ~/.julia/packages/ForwardDiff/QOqCN/src/hessian.jl:17
[26] hessian(f::Function, x::Vector{Float64}, cfg::ForwardDiff.HessianConfig{ForwardDiff.Tag{typeof(testf), Float64}, Float64, 2, Vector{ForwardDiff.Dual{ForwardDiff.Tag{typeof(testf), Float64}, ForwardDiff.Dual{ForwardDiff.Tag{typeof(testf), Float64}, Float64, 2}, 2}}, Vector{ForwardDiff.Dual{ForwardDiff.Tag{typeof(testf), Float64}, Float64, 2}}}) (repeats 2 times)
@ ForwardDiff ~/.julia/packages/ForwardDiff/QOqCN/src/hessian.jl:15
[27] top-level scope
@ In[5]:1
[28] eval
@ ./boot.jl:360 [inlined]
[29] include_string(mapexpr::typeof(REPL.softscope), mod::Module, code::String, filename::String)
@ Base ./loading.jl:1094
stacktrace for Zygote.hessian(testf,p)
MethodError: no method matching Float64(::ForwardDiff.Dual{Nothing, Float64, 2})
Closest candidates are:
(::Type{T})(::Real, ::RoundingMode) where T<:AbstractFloat at rounding.jl:200
(::Type{T})(::T) where T<:Number at boot.jl:760
(::Type{T})(::AbstractChar) where T<:Union{AbstractChar, Number} at char.jl:50
...
Stacktrace:
[1] convert(#unused#::Type{Float64}, x::ForwardDiff.Dual{Nothing, Float64, 2})
@ Base ./number.jl:7
[2] setindex!(A::Vector{Float64}, x::ForwardDiff.Dual{Nothing, Float64, 2}, i1::Int64)
@ Base ./array.jl:839
[3] macro expansion
@ ./broadcast.jl:984 [inlined]
[4] macro expansion
@ ./simdloop.jl:77 [inlined]
[5] copyto!
@ ./broadcast.jl:983 [inlined]
[6] copyto!
@ ./broadcast.jl:947 [inlined]
[7] materialize!
@ ./broadcast.jl:894 [inlined]
[8] materialize!(dest::Vector{Float64}, bc::Base.Broadcast.Broadcasted{Base.Broadcast.DefaultArrayStyle{0}, Nothing, typeof(*), Tuple{ForwardDiff.Dual{Nothing, Float64, 2}, Float64}})
@ Base.Broadcast ./broadcast.jl:891
[9] (::Quadrature.var"#79#95"{QuadratureProblem{false, Vector{ForwardDiff.Dual{Nothing, Float64, 2}}, typeof(f), Vector{Float64}, Vector{Float64}, Base.Iterators.Pairs{Union{}, Union{}, Tuple{}, NamedTuple{(), Tuple{}}}}, Vector{Float64}, Vector{Float64}, Vector{ForwardDiff.Dual{Nothing, Float64, 2}}})(x::Vector{Float64}, dx::Vector{Float64})
@ Quadrature ~/.julia/packages/Quadrature/rcCut/src/Quadrature.jl:412
[10] generic_integrand!(ndim::Int32, x_::Ptr{Float64}, ncomp::Int32, f_::Ptr{Float64}, func!::Quadrature.var"#79#95"{QuadratureProblem{false, Vector{ForwardDiff.Dual{Nothing, Float64, 2}}, typeof(f), Vector{Float64}, Vector{Float64}, Base.Iterators.Pairs{Union{}, Union{}, Tuple{}, NamedTuple{(), Tuple{}}}}, Vector{Float64}, Vector{Float64}, Vector{ForwardDiff.Dual{Nothing, Float64, 2}}})
@ Cuba ~/.julia/packages/Cuba/KIQTB/src/Cuba.jl:92
[11] dointegrate!
@ ~/.julia/packages/Cuba/KIQTB/src/cuhre.jl:40 [inlined]
[12] dointegrate
@ ~/.julia/packages/Cuba/KIQTB/src/Cuba.jl:195 [inlined]
[13] cuhre(integrand::Quadrature.var"#79#95"{QuadratureProblem{false, Vector{ForwardDiff.Dual{Nothing, Float64, 2}}, typeof(f), Vector{Float64}, Vector{Float64}, Base.Iterators.Pairs{Union{}, Union{}, Tuple{}, NamedTuple{(), Tuple{}}}}, Vector{Float64}, Vector{Float64}, Vector{ForwardDiff.Dual{Nothing, Float64, 2}}}, ndim::Int64, ncomp::Int64; nvec::Int64, rtol::Float64, atol::Float64, flags::Int64, minevals::Int64, maxevals::Int64, key::Int64, statefile::String, spin::Ptr{Nothing}, abstol::Missing, reltol::Missing)
@ Cuba ~/.julia/packages/Cuba/KIQTB/src/cuhre.jl:97
[14] __solvebp_call(::QuadratureProblem{false, Vector{ForwardDiff.Dual{Nothing, Float64, 2}}, typeof(f), Vector{Float64}, Vector{Float64}, Base.Iterators.Pairs{Union{}, Union{}, Tuple{}, NamedTuple{(), Tuple{}}}}, ::CubaCuhre, ::Quadrature.ReCallVJP{Quadrature.ZygoteVJP}, ::Vector{Float64}, ::Vector{Float64}, ::Vector{ForwardDiff.Dual{Nothing, Float64, 2}}; reltol::Float64, abstol::Float64, maxiters::Int64, kwargs::Base.Iterators.Pairs{Union{}, Union{}, Tuple{}, NamedTuple{(), Tuple{}}})
@ Quadrature ~/.julia/packages/Quadrature/rcCut/src/Quadrature.jl:471
[15] #rrule#43
@ ~/.julia/packages/Quadrature/rcCut/src/Quadrature.jl:493 [inlined]
[16] chain_rrule_kw
@ ~/.julia/packages/Zygote/0da6K/src/compiler/chainrules.jl:115 [inlined]
[17] macro expansion
@ ~/.julia/packages/Zygote/0da6K/src/compiler/interface2.jl:0 [inlined]
[18] _pullback(::Zygote.Context, ::Quadrature.var"#__solvebp##kw", ::NamedTuple{(:reltol, :abstol), Tuple{Float64, Float64}}, ::typeof(Quadrature.__solvebp), ::QuadratureProblem{false, Vector{ForwardDiff.Dual{Nothing, Float64, 2}}, typeof(f), Vector{Float64}, Vector{Float64}, Base.Iterators.Pairs{Union{}, Union{}, Tuple{}, NamedTuple{(), Tuple{}}}}, ::CubaCuhre, ::Quadrature.ReCallVJP{Quadrature.ZygoteVJP}, ::Vector{Float64}, ::Vector{Float64}, ::Vector{ForwardDiff.Dual{Nothing, Float64, 2}})
@ Zygote ~/.julia/packages/Zygote/0da6K/src/compiler/interface2.jl:9
[19] _apply(::Function, ::Vararg{Any, N} where N)
@ Core ./boot.jl:804
[20] adjoint
@ ~/.julia/packages/Zygote/0da6K/src/lib/lib.jl:200 [inlined]
[21] _pullback
@ ~/.julia/packages/ZygoteRules/OjfTt/src/adjoint.jl:57 [inlined]
[22] _pullback
@ ~/.julia/packages/Quadrature/rcCut/src/Quadrature.jl:153 [inlined]
[23] _pullback(::Zygote.Context, ::Quadrature.var"##solve#12", ::Quadrature.ReCallVJP{Quadrature.ZygoteVJP}, ::Base.Iterators.Pairs{Symbol, Float64, Tuple{Symbol, Symbol}, NamedTuple{(:reltol, :abstol), Tuple{Float64, Float64}}}, ::typeof(solve), ::QuadratureProblem{false, Vector{ForwardDiff.Dual{Nothing, Float64, 2}}, typeof(f), Vector{Float64}, Vector{Float64}, Base.Iterators.Pairs{Union{}, Union{}, Tuple{}, NamedTuple{(), Tuple{}}}}, ::CubaCuhre)
@ Zygote ~/.julia/packages/Zygote/0da6K/src/compiler/interface2.jl:0
[24] _apply(::Function, ::Vararg{Any, N} where N)
@ Core ./boot.jl:804
[25] adjoint
@ ~/.julia/packages/Zygote/0da6K/src/lib/lib.jl:200 [inlined]
[26] _pullback
@ ~/.julia/packages/ZygoteRules/OjfTt/src/adjoint.jl:57 [inlined]
[27] _pullback
@ ~/.julia/packages/Quadrature/rcCut/src/Quadrature.jl:152 [inlined]
[28] _pullback(::Zygote.Context, ::CommonSolve.var"#solve##kw", ::NamedTuple{(:reltol, :abstol), Tuple{Float64, Float64}}, ::typeof(solve), ::QuadratureProblem{false, Vector{ForwardDiff.Dual{Nothing, Float64, 2}}, typeof(f), Vector{Float64}, Vector{Float64}, Base.Iterators.Pairs{Union{}, Union{}, Tuple{}, NamedTuple{(), Tuple{}}}}, ::CubaCuhre)
@ Zygote ~/.julia/packages/Zygote/0da6K/src/compiler/interface2.jl:0
[29] _pullback
@ ./In[1]:9 [inlined]
[30] _pullback(ctx::Zygote.Context, f::typeof(testf), args::Vector{ForwardDiff.Dual{Nothing, Float64, 2}})
@ Zygote ~/.julia/packages/Zygote/0da6K/src/compiler/interface2.jl:0
[31] _pullback(f::Function, args::Vector{ForwardDiff.Dual{Nothing, Float64, 2}})
@ Zygote ~/.julia/packages/Zygote/0da6K/src/compiler/interface.jl:34
[32] pullback(f::Function, args::Vector{ForwardDiff.Dual{Nothing, Float64, 2}})
@ Zygote ~/.julia/packages/Zygote/0da6K/src/compiler/interface.jl:40
[33] gradient(f::Function, args::Vector{ForwardDiff.Dual{Nothing, Float64, 2}})
@ Zygote ~/.julia/packages/Zygote/0da6K/src/compiler/interface.jl:58
[34] (::Zygote.var"#77#78"{typeof(testf)})(x::Vector{ForwardDiff.Dual{Nothing, Float64, 2}})
@ Zygote ~/.julia/packages/Zygote/0da6K/src/lib/grad.jl:76
[35] forward_jacobian(f::Zygote.var"#77#78"{typeof(testf)}, x::Vector{Float64}, #unused#::Val{2})
@ Zygote ~/.julia/packages/Zygote/0da6K/src/lib/forward.jl:29
[36] forward_jacobian(f::Function, x::Vector{Float64})
@ Zygote ~/.julia/packages/Zygote/0da6K/src/lib/forward.jl:44
[37] hessian_dual
@ ~/.julia/packages/Zygote/0da6K/src/lib/grad.jl:76 [inlined]
[38] hessian(f::Function, x::Vector{Float64})
@ Zygote ~/.julia/packages/Zygote/0da6K/src/lib/grad.jl:74
[39] top-level scope
@ In[4]:1
[40] eval
@ ./boot.jl:360 [inlined]
[41] include_string(mapexpr::typeof(REPL.softscope), mod::Module, code::String, filename::String)
@ Base ./loading.jl:1094

Yes, to fix this someone would need to add a double dual dispatch which moves the Hessian calculation into the integrand. It's almost exactly the same as https://github.com/SciML/Quadrature.jl/blob/v1.9.0/src/Quadrature.jl#L581-L639

Thank you for your quick response, much appreciated! I think the code you link to will take me a while to understand. I will give it a shot, not sure I am the right person to tackle this.

authors: ChrisRackauckas fernando-duarte


text:
Get DiffEqJump docs integrated

Since JumpProblem and such is not in SciMLBase or documented there.

Indeed. I think DiffEqJump needs an entire documentation: that page in DiffEq docs has gotten too crammed 😅 .

Yes, I've noticed that myself! It should be split into a series of tutorials. There is also more API type info that should be collated in a separate section, along with solver information and docs for the spatial stuff we have so far.

source: gharchive/issue

authors: ChrisRackauckas isaacsas

repo: SciML/SciMLDocs

license: MIT

license_type: permissive

license_source: github-api


text:
TensorFlowNet Examples references projects: TensorFlowNet.Hub, TensorFlowNet.Models

Neither of these projects seem to be available, and the namespace hub and models do not appear within TensorFlow.
Can someone help me? I'm probably doing something silly.

Should work now.


text:
Documentation updates following #87

🚀 Pull Request
This PR provides some updates to the documentation and setup instructions based on a review by @pelson on #87.

Codecov Report

Merging #89 (1235f1e) into main (d65f545) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #89   +/-   ##
=======================================
  Coverage   94.30%   94.30%
=======================================
  Files           1        1
  Lines         193      193
  Branches       44       44
=======================================
  Hits          182      182
  Misses          6        6
  Partials        5        5

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d65f545...1235f1e. Read the comment docs.

source: gharchive/pull-request

authors: codecov-commenter spencerkclark

repo: SciTools/nc-time-axis

license_source: bigquery


text:
Surveying dust structure via GALEX MIS

Initial draft for tutorial, contains:

Basic structure for tutorial
Learning goals (tentatively, may be changed as tutorial progresses)
Some additional resources

Closing this pull request in order to split it in two parts.

repo: ScienceBetter/notebooks-stsci


text:
[Bug] 无法更新跃迁记录

Description

已经把抽卡记录打开了，还是无法更新
Reproduction Steps

Expected Behavior
No response
Screenshots
No response
Starward Version
0.10.0
Windows Version
19045.3448
Log
-

Additional Context
No response

把 StarRail_Data\webCaches 这个文件夹删掉，再打开游戏，点击更新。

还是不行

国际服啊，应该是链接变了，等我下个客户端检查一下。

没错我是国际服的

我的账号新手剧情还没过完，看不了抽卡记录。麻烦你把 StarRail_Data\webCaches\2.17.0.0\Cache\Cache_Data\data_2 这个文件私发给我 scighost@outlook.com ，感谢你的帮助。

发了

确定是网页链接改变了，你在我提到的文件中找到以 https://api-os-takumi.mihoyo.com/common/gacha_record/api/getGachaLog 开头的链接，然后通过下图中的输入URL可暂时更新抽卡记录。

可以了，感谢你的帮助

已在 0.10.1 中修复此问题

authors: LycoreReco Scighost

repo: Scighost/Starward


text:
[Request] ProtonVPN Windows Client

Package Request
Information
Name: [name of new package]
proton-vpn
Description: [clear and concise details of what it is]
The Proton VPN app for Windows is the best way to stay secure and private when surfing the internet. It is open source, easy to use, and packed with useful security features.
Homepage: [a URL/link]
https://protonvpn.com/download-windows
Download link(s): [URL(s)/link(s)]
https://protonvpn.com/download/ProtonVPN_win_v2.0.0.exe
Some indication of popularity/repute: [GitHub stars/software reviews etc.]
https://github.com/ProtonVPN/win-app
https://www.pcmag.com/reviews/protonvpn
https://www.techradar.com/reviews/protonvpn

Duplicate of #4678

Thanks for reminding me.

repo: ScoopInstaller/Extras

license: Unlicense


text:
kiwi-for-gmail: Update to version 3.6.2 and fix autoupdate

[X] I have read the Contributing Guide.

/verify


text:
cherry-studio: Add version 0.9.3

[x] I have read the Contributing Guide.
Cherry Studio has 2.7k+ stars: https://github.com/CherryHQ/cherry-studio

/verify


text:
Move and Rename Art Light Scene to add Lutron Lights

Move Art Light scene from Vera to Home assistant, so that we can use the stairwell art light.  Rename to evening/morning lights.

Perhaps do this with a helper group, and use the art light schedule (rename to evening/morning lights or something)

Created helper light group 'light.art_lights', then plugged into automation that uses the schedule.art_lights.  Disabled Vera schedules, and removed the code to create the switch.art_light. It now just operates directly on the group.
Waiting to see if it works...  needed to adjust from 'switch' service to 'light' service, then we're good.


text:
FunctionPlot wrong X bounds

If I pass an IFunctionSource into plot.Add.Function() which has specified RangeX to limit the function to the range, then this is ignored and the function will plot over the whole visible range.
I'm pretty sure its because the Min/Max are backwards here:
https://github.com/ScottPlot/ScottPlot/blob/5c02d82432cebe5018d22ebd8be41738e80f0ebc/src/ScottPlot5/ScottPlot5/Plottables/FunctionPlot.cs#L23-L24
I believe MinX should be the Max(...) of the two mins, and MaxX should be the Min(...) of the two maxs, from what I understand.
ScottPlot.Plot myPlot = new();
myPlot.Axes.SetLimits(-10, 10, -10, 10);
myPlot.Add.Function(new FunctionSource(x => x)
{
    RangeX = new CoordinateRange(-1.0, 1.0)
});
myPlot.SavePng("bug.png", 300, 300);

Hi @Matthew-Chidlow, thanks for reporting this issue! ... and drilling down to the lines of code that underlies it. I'll take a closer look within the next few days (but am happy to review a PR if someone gets to it before I do).
For added context, the present behavior is that the line is shown over the whole visible X range, but really it should only be drawn in the X range [-1, 1]
    [Test]
    public void Test_Function_Bounds()
    {
        FunctionSource fs = new(x => x)
        {
            RangeX = new CoordinateRange(-1.0, 1.0)
        };

        Plot myPlot = new();
        myPlot.Axes.SetLimits(-10, 10, -10, 10);
        myPlot.Add.Function(fs);

        myPlot.SaveTestImage();
    }

resolved in #3603

authors: Matthew-Chidlow swharden

repo: ScottPlot/ScottPlot


text:
Create LinearRegressionLine for ScottPlot5.

Please review.  Adds LinearRegressionLine to ScottPlot5.  So it can be used with code similar to the following:
    // Linear regression line
    double firstDate = dates[0];
    double lastDate = dates[dates.Length - 1];
    var regressionLine = new ScottPlot.Statistics.LinearRegressionLine(dates, chartValues);
    AddLine(_plot.Plot, regressionLine.slope, regressionLine.offset, (firstDate, lastDate), lineWidth: 0.5F, color: XkcdColors.LightGreyBlue, label: "Trend");
}

private void AddLine(Plot plot, double slope, double offset, (double x1, double x2) xLimits, string label = "", Color? color = null, float lineWidth = 1)
{
    double y1 = xLimits.x1 * slope + offset;
    double y2 = xLimits.x2 * slope + offset;
    var scatter = plot.Add.Scatter(new double[] { xLimits.x1, xLimits.x2 }, new double[] { y1, y2 }, color);
    if (!string.IsNullOrWhiteSpace(label))
        scatter.Label = label;
}

Purpose:

Use this space to describe what this pull request accomplishes
If this PR references an issue be sure to link to it
Consider including a picture if it would help clarify what this pull request does
New contributors please review https://github.com/ScottPlot/ScottPlot/blob/main/CONTRIBUTING.md

// You can insert code examples like this
var newThing = new SpecialObject();

Thanks for this PR @anewton! I'm extending it a bit, adding tests, and creating a cookbook demo. It's going to work something like this:

double[] xs = new double[] { 1, 2, 3, 4, 5, 6, 7 };
double[] ys = new double[] { 2, 2, 3, 3, 3.8, 4.2, 4 };

// plot original data as a scatter plot
var sp = myPlot.Add.Scatter(xs, ys);
sp.LineStyle = LineStyle.None;
sp.MarkerStyle.Size = 10;

// calculate the regression line
ScottPlot.Statistics.LinearRegression reg = new(xs, ys);

// plot the regression line
Coordinates pt1 = new(xs.First(), reg.GetValue(xs.First()));
Coordinates pt2 = new(xs.Last(), reg.GetValue(xs.Last()));
var line = myPlot.Add.Line(pt1, pt2);
line.MarkerStyle = MarkerStyle.None;
line.LineStyle.Pattern = LinePattern.Dash;
line.LineStyle.Width = 2;

// note the formula at the top of the plot
myPlot.Title($"y = {reg.Slope:0.###}x + {reg.Offset:0.###} (r²={reg.Rsquared:0.###})");

Thanks for cleaning up the PR!!  I know it was a bit messy and did not probably follow your repo PR requirements.  Was going to come back to it and resubmit.  But it looks like you have it and the changes look awesome.  Very much look forward to using this in my Avalonia desktop apps.  Thanks @swharden!

authors: anewton swharden


text:
beat doesn't log when None was returned.

I noticed that questions -- that uses a beat -- which could return None as a value do not get logged.
Here is what gets logged:
Actor examines thing
... hoping it's equal to <None>
    => <None>

Here is what I would expect to get logged:
Actor examines thing
    => <None>
... hoping it's equal to <None>
    => <None>

And in case it was not obvious (it wasn't to me) the reason the resolution got logged in this case was because of the way hamcrest deals with logged values.  None is wrapped in the IsEqual object.  When we do a is not None check it passes because the object isn't None.  Those clever folks at hamcrest...
                if retval is not None:
                    aside(f"=> {represent_prop(retval)}")

i think we can probably do something like:
if retval is not None or isinstance(func, Answerable):
    ...

or maybe keep a log of which protocols will be expected to return useful information from their -able method.

Unfortunately func isn't an instance of the protocols, it's function.  We might have to get creative on how we identify which functions are allowed to return None.

authors: bandophahita perrygoy

repo: ScreenPyHQ/screenpy


text:
Fix validation issues

What does this PR do?
Fixes validation issues:

Now, we check if manifest is valid before we try to get it (commands no longer panic on invalid manifest)

Since code around EdgeAppManifest and Settings bloated, I moved them to separate files.

Field name is now visible in the error message:

For Option<String> fields can easily modify if they should throw error on field being in the manifest file but empty

How has this been tested?

Manually + unit tests

Checklist before merging

[x] If have added tests.
[ ] Is this a new feature? If yes, please write one phrase about this update.
[x] I've attached relevant screenshots (if relevant).

@sergey-borovkov, @vpetersson  after this changes, if we want to allow empty string for Option<String> field it's as simple as changing the true->false
Of of the following optional fields, which do we allow as empty strings?

user_version
description
icon
author
homepage_url

@sergey-borovkov mentioned that we would like to have stricter validation for fields in the Setting struct (e. g. fail if help_text is empty) - is this the only field that requires it?

@sergey-borovkov When edge-app commands fail, some use eprintln!, some use error! - I think we should make it uniform, which way should we go with?

Yes, regarding help_text.
All optional fields in Manifest itself we decided to allow as empty. But make sure they don't serialize to xxx: null.

authors: StanIwan sergey-borovkov

repo: Screenly/cli


text:
FEATURE: Third version of optimizer. Input/output format

This version of the Optimizer is able to accept inputs in the TOSCA syntax defined during the SeaClouds General Assembly in September 2015.
The functionality of the module has not been increased. It is the same as in the previous versions.
Bugs that have been found in the mean time have been corrected
@adriannieto please, could you review it?
Hopefully the issues with hundreds of commits is solved

@perezp : Ufff... The PR is too big. General comments:

IMO, it's legal to log.debug or not depending in a variable in your code if you need finer grain. But use log.debug, and not log.info.
Do not comment large portions of code to have them just in case. That's what the repository is for.
Java coding standards state that methods name start with lowercase letter.

Is the class Optimizer the "main" class?
Sorry, for not reviewing this before. I had not realized you already resubmitted.

@perezp sorry to not realizing about this until now. I agree with @rosogon suggestions. I will continue the review with line comments.

@rosogon Regarding general comments.

"IMO, it's legal to log.debug or not depending in a variable in your code if you need finer grain. But use log.debug, and not log.info. "
Right. DONE, as you suggested. I liked to use the variable because during debugging I wanted to make a class very verbose, but not the rest of classes. I could not change the log level after the first instantiation.

"Do not comment large portions of code to have them just in case. That's what the repository is for."
You are right. I was my fault that I forgot to remove these methods.

"Java coding standards state that methods name start with lowercase letter."
You're right. DONE.

"Is the class Optimizer the "main" class?"
Yes, in the next PR , which hopefully will be just a couple of days after the acceptance of this one, the Optimizer class will be a web service.
Sorry, for not reviewing this before. I had not realized you already resubmitted.
No problem. Thanks.

Merged. @perezp, please provide REST service asap.

authors: adriannieto perezp rosogon

repo: SeaCloudsEU/SeaCloudsPlatform


text:
运行出错

描述bug
[BLRHH][下午8:24:07][自动抽奖][礼物抽奖]运行时出现异常
window.toast @ userscript.html?id=dd419276-2609-4951-95f1-e6c89f2dfb5b:1823
VM1120 userscript.html:1777
[BLRHH] ReferenceError: $ is not defined
at Object.run (userscript.html?id=dd419276-2609-4951-95f1-e6c89f2dfb5b:1421)
at BLRHH (userscript.html?id=dd419276-2609-4951-95f1-e6c89f2dfb5b:1579)
at Window.eval (userscript.html?id=dd419276-2609-4951-95f1-e6c89f2dfb5b:3664)
at :2:494
at eval (userscript.html?id=dd419276-2609-4951-95f1-e6c89f2dfb5b:2)
at eval (userscript.html?id=dd419276-2609-4951-95f1-e6c89f2dfb5b:3)
at Object.eval (userscript.html?id=dd419276-2609-4951-95f1-e6c89f2dfb5b:3665)
at eval (userscript.html?id=dd419276-2609-4951-95f1-e6c89f2dfb5b:3667)
at eval ()
at :2:494
重现bug
说明您在进行了怎样的操作后出现了bug

xxx
xxx

预期行为
简要描述进行以上操作后预期的脚本行为
截图

使用环境:

浏览器: Chrome
浏览器版本: 72.0.3626.121
脚本的版本: 2.3.12
网络情况(网速): 好
其他浏览器插件/脚本:
bug出现时间: 2019-3-23  20:00:00

其他
若您有其他想要补充的内容，请在此说明

加一行这个
// @require      https://code.jquery.com/jquery-3.3.1.min.js
我之前手滑删了，手头上已经改了，但还没推

加一行这个
// @require https://code.jquery.com/jquery-3.3.1.min.js
我之前手滑删了，手头上已经改了，但还没推

解决了感谢

repo: SeaLoong/Bilibili-LRHH


text:
Problem: Python is not suitable for Hax

The main problem is that Python does not do the static type checking. Another day I was trying to make some minor change and missed to provide an argument to the function - I could detect the issue only after building the new rpm, deploying it into the system and running the code. It's very inconvenient and time-consuming in the long run.
Suggested solution: re-write hax in Go language. Go is an easy-to-learn system programming language with a strong static type-checking. It has very good bindings with C and with Consul (which is written in Go) - something that is essential for hax.

cc @NeeravChoudhari , @knekrasov , @chumakd , @azheregelya .

@andriytk Can you describe more what issue you faced and failed to find with mypy?
The thing is that Python has type checks and the static analysis is already involved into the build procedure. So strictly speaking, we can't say that there is no static type checking.
Another question: can anybody recall why Python was chosen for Hare? What objectives/requirements were there at the moment? I think we need to consider those objectives and thoughts while choosing a new language anyway.

Python was chosen because it was thought to be simple to program in and that many people are acquainted with it. That was the main reason, as far as I remember. We just needed something to quickly prototype in and that most people could read and understand.

Here is the change with the missing argument to the function which builds without any issues:
--- a/hax/hax/hax.py
+++ b/hax/hax/hax.py
@@ -117,7 +117,7 @@ def main():
         stats_updater = _run_stats_updater_thread(motr, consul_util=util)
         # [KN] This is a blocking call. It will work until the program is
         # terminated by signal
-        run_server(q, herald, consul_util=util,
+        run_server(q, herald,
                    threads_to_wait=[consumer, stats_updater])
     except Exception:
         LOG.exception('Exiting due to an exception')

can anybody recall why Python was chosen for Hare? What objectives/requirements were there at the moment?

Team members could program in C, Bash, Haskell, and Python.  Our priority was to deliver fast; learning new programming language was a luxury we didn't have.  Seagate upper management, having their fingers burnt with Haskell, became very conservative about the choice of technologies.  I guess Go lang would be a leap too far in those circumstances, but, to be honest, I don't remember it even to be considered by team members.  We didn't think that far ahead.

#23 seems to be the earliest issue where hax is mentioned.

Let's close it for now.

authors: andriytk knekrasov vvv

repo: Seagate/cortx-hare


text:
Missing semicolon.

Codacy detected an issue:
Message: Missing semicolon.
Currently on:

Commit:  200915377c5039362281acf8b1694febf7a406d5
File:    doc/integrations/myDrive/serverUtils/setupServer.js
LineNum: 205

For the convenience of the Seagate development team, this issue has been mirrored in a private Seagate Jira Server: https://jts.seagate.com/browse/CORTX-32207. Note that community members will not be able to access that Jira server but that is not a problem since all activity in that Jira mirror will be copied into this GitHub issue.

Issue resolved

authors: cortx-admin hessio mukul-seagate11

repo: Seagate/cortx


text:
Update CONTRIBUTORS.md

Added Pranav Pawar to the list of names.
Signed-off-by: Pranav Diliprao Pawar pranav.pawar@seagate.com

dco failed

dco failed

@pranavPawar07, why the PR is closed?

@pranavPawar07, why the PR is closed?

@pranavPawar07, why the PR is closed?

The dco check failed here. Opened a new PR which got approved by John Bent.
https://github.com/Seagate/cortx/pull/620

@pranavPawar07, why the PR is closed?

The dco check failed here. Opened a new PR which got approved by John Bent.
https://github.com/Seagate/cortx/pull/620


text:
Get Basic Info in Constructor

Is there a way to get basic info such as initial piece positions and MyBot's color before the game starts? For example, it would be nice to know that we are white or black before the game starts so that we don't need to check that every time Think() is called.

I'm afraid not, you'll need to get the info from the Think function

authors: SebLague ethaninfinity

repo: SebLague/Chess-Challenge


text:
Path Creator ignores its gameobject's transform changes

Once you create the path, it never gets updated with the changes made on the gamobject's tranform. Normally, I would expect the changes on the game object's or its parents' transform changes to affect the path itself too. So it would be better if the created path's points were relative to the game object.
I think the tool is almost perfect and thank you for sharing it.

@ben4d85, the path is not updated in realtime. You can't attach path to some object.

I can easily make the transform position affect the path, but with the way I'm currently handling rotation and scaling, I can't use the transform's values for those. Not sure if its better to implement only transform position, or to be consistent and not use any values from the transform...

Can make two components? One for static and the other for realtime.

Gonna close this for now as having two scripts isn't different currently feasible. It may be possible to get it to work relative to the transform at some point, but right now it presents some seriously technical problems.

authors: DDru SebLague keenanwoodall semihcihan

repo: SebLague/Path-Creator


text:
🛑 Double Key Encryption Fullpath is down

In cc0c74c, Double Key Encryption Fullpath ($SECRET_DKE_KEY) was down:

HTTP code: 500
Response time: 411 ms

Resolved: Double Key Encryption Fullpath is back up in af687bb.

repo: SecurosysFernandez/clouds-uptime


text:
🛑 Transaction Security Broker - Demo is down

In 5d9d9d9, Transaction Security Broker - Demo (https://tsb-demo.cloudshsm.com/v1/licenseInfo) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Transaction Security Broker - Demo is back up in 3b4ede5.


text:
CAN node as transciever

Is it possible to send and receive messages at the same node using this library?
Using separate nodes for Transmitter and Receiver seems to work. But when I combine them into a single node it crashes.

Should be ok, where crash, can you trace?

license: mit


text:
Move to Binary Data Files + Include 0.6 pT Maps

I will include more info here soon. I need to make a cleanup commit.

/run standalone
/run cmssw

/run standalone
/run cmssw

/run standalone
/run cmssw

Thank you @ariostas. I like your suggestion of moving everything to a single file, although that's probably a lot of work for what it's worth right now. Could be a good project though for a new student or later down the line if this becomes a larger issue.

repo: SegmentLinking/TrackLooper


text:
Add languages to CodeInput

Notably plain text and some popular languages

Missing C, C++


text:
Unable to send stacktrace using RavenHandler

Using Monolog\Handler\RavenHandler::write() there is no option to send a stacktrace ala Raven_Client::captureMessage() (4th arg is not collected or passed).
Solution: Add an extra dimension to the write() method's $record param "trace" or "stack" and then pass $record['some_param'] as the 4th arg to $this->ravenClient->captureMessage($record['formatted'], array(), $options, $record['some_param']);

The right way to capture the stack is to pass an exception instance in the log context's exception key (as defined in PSR-3), then Raven's captureException is used, which captures the stack.

authors: Seldaek phptek

repo: Seldaek/monolog


text:
How to use modal directive?

How to use modal directive?

It's not written yet. Would you be interested in starting the work on it?

See #7. Closing this

authors: caitp m0t0r oukan

repo: Semantic-Org/Semantic-UI-Angular


text:
removeIcon for Label conflicts with children

Steps
I'm trying to use a label with removeIcon:
Test

Expected Result
Add 'x' Icon, which listen to onRemove.
Actual Result
Warning: Failed prop type: Prop `removeIcon` in `Label` conflicts with props: `children`. They cannot be defined together, choose one or the other.

Version
0.73.1

removeIcon is the shorthand prop, it's not possible to combine shorthand props with children. You should use content prop there:
   {}}
  />
   {}}
  />

BTW, it's not required to use removeIcon prop, it will be added by default if onRemove callback is present. However, you can use for some tricks like this:
   {}}
    removeIcon={{ color: 'red', name: 'delete' }}
  />

authors: jaqua layershifter

repo: Semantic-Org/Semantic-UI-React


text:
WIP fix(Transition): hiding automatically when setState of parent called on mount

Fixes #3641

I fixed, review plz and now I'm trying to write appropriate test

This issue was fixed in semantic-ui-react@1.0.0 by #3982. Closing for housekeeping.

authors: DmitryRomaniuk layershifter


text:
[checkbox][tabular] conflict

Hi
outside the tab everything is fine but when checkbox element going inside the tab it's not working .

Closing until there's a test case.

repo: Semantic-Org/Semantic-UI


text:
TypeScript: false positive Unused import

In TypeScript it's valid to export an "ImportEqualsDeclaration".
export import stringify = require('./stringify');

// equivalent to
import stringify = require('./stringify');
export {stringify};

Currently this is reported as unused:
https://lgtm.com/projects/g/DefinitelyTyped/DefinitelyTyped/snapshot/d798d9208fc79327a67b16e60b73965d30f01ad7/files/types/iarna__toml/index.d.ts?sort=name&dir=ASC&mode=heatmap&showExcluded=false#x54f532a8afd9f620:1

Hi ajafff,
Thanks for the bug report.
This was fixed in https://github.com/Semmle/ql/pull/32. It hasn't gone live on lgtm.com yet, but it will soon and then the false positive should go away.

The new distribution has just been deployed, and the alert is gone: https://lgtm.com/projects/g/DefinitelyTyped/DefinitelyTyped/latest/files/types/iarna__toml/index.d.ts?sort=name&dir=ASC&mode=heatmap&showExcluded=true#L10.

authors: ajafff asger-semmle xiemaisi

repo: Semmle/ql


text:
JS: add xlink:href as xss target when using setAttribute

Adds the xlink:href attribute to the list of vulnerable attributes.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

authors: erik-semmle semmle-cla


text:
Python: Remove manual TC from ssaShortCut.

This caused a massive slowdown on certain snapshots.

Will need performance tests run before merging.

Performance mostly unchanged: https://git.semmle.com/gist/taus/30c9ee592974823f9fbd232f4aeb8214
(Except, of course, for the pathological cases where it made a huge difference.)


text:
spelling mistakes

i am better than benny at this job

i went proofreading

i went proofreading

ok
666 commits moment is gone now

ok
666 commits moment is gone now

repo: Seniatical/Mecha-Karen-Source-Code


text:
Add links to dependencies

The example fails to compile unless users understand they need to download the core. This PR removes that hurdle.

The dependencies are documented in the Readme, as well as in the library.properties. They will automatically install if Arduino IDE is used.
Furthermore SensirionCore.h is not directly used by the example but through the SensirionI2CSen5x.h. There is no need to include it in the example.

authors: nseidle psachs


text:
🛑 AI Toolas & News is down

In 5c682b3, AI Toolas & News (https://ai-tools-and-news.com) was down:

HTTP code: 403
Response time: 556 ms

Resolved: AI Toolas & News is back up in 190dfc6 after 6 minutes.

repo: SeoWeb/upptime


text:
Sprint 1 Backend Update

Added new API endpoints -

/article/upload
POST request. This endpoints adds a new article to the database. Validated with a unit test.

/article/all
GET request. Gets all the articles in the database

/article/:id
GET request. Gets an article based on the ID.

/article/author/:id

/article/year/:id

/article/claim/:id

/article/evidence/:id
GET request. Gets all articles by the specified field.

reviewed the pull request

Good to resolve all merge conflicts.
Passed unit tests.

authors: Seongrok-Shin dgw7626 logan-wood


text:
Plugin Crashes

Prerequisites

Be sure that there's no open issue already.

Description
We are trying to use the plugin in a module and getting a hard crash. Our Terraform code layout is like this:
.
|__ README.md
|__ modules/
|     |__ module1/
|            |__ README.md
|            |__ versions.tf
|            |__ providers.tf
|            |__ variables.tf
|            |__ main.tf
|            |__ outputs.tf
|     |__ module2/
|            |__ README.md
|            |__ versions.tf
|            |__ providers.tf
|            |__ variables.tf
|            |__ main.tf
|            |__ outputs.tf
|__ development/
|    |__ appA/
|            |__ README.md
|            |__ main.tf
|            |__ versions.tf
|            |__ variables.tf
|__ stage/
|    |__ appA/
|            |__ README.md
|            |__ main.tf
|            |__ versions.tf
|            |__ variables.tf
|__ production/
|    |__ appA/
|            |__ README.md
|            |__ main.tf
|            |__ versions.tf
|            |__ variables.tf

References go like this: development/appA --calls--> modules/module2 --calls--> modules/module1
module2 uses the haproxy provider plugin and another provider plugin. The module code looks like this:
## Virtual Machine ##
module "module1" {
  source = "../module1"
  vsphere = {
    datacenter_cluster        = var.vsphere.datacenter_cluster
    compute_cluster_name      = var.vsphere.compute_cluster_name
    datastore                 = var.vsphere.datastore
    content_library           = var.vsphere.content_library
    content_library_item_name = var.vsphere.content_library_item_name
    network_name              = var.vsphere.network_name
  }
  virtual_machine = {
    host_name             = var.virtual_machine.host_name
    ipv4_address          = var.virtual_machine.ipv4_address
    ipv4_gateway          = var.virtual_machine.ipv4_gateway
    ipv4_netmask          = var.virtual_machine.ipv4_netmask
    dns_server_list       = var.virtual_machine.dns_server_list
    dns_suffix_list       = var.virtual_machine.dns_suffix_list
    is_windows_image      = true
    domain                = var.virtual_machine.domain
    domain_admin_user     = var.domain_join_username
    domain_admin_password = var.dmz_domain_join_password
  }
}

## Octopus Deploy ##
data "octopusdeploy_environments" "environments" {
  ids = var.octopusdeploy_environments
}
data "octopusdeploy_space" "default" {
  name = var.octopusdeploy_space_name
}
data "octopusdeploy_machine_policies" "default" {
  ids      = var.octopusdeploy_machine_policies
  space_id = data.octopusdeploy_space.default.id
}
resource "octopusdeploy_listening_tentacle_deployment_target" "example" {
  environments = [for e in data.octopusdeploy_environments.environments.environments : e.name]
  is_disabled  = false
  name         = var.name
  roles        = var.octopusdeploy_target_roles
  tentacle_url = "https://${var.name}:10933/"
  thumbprint   = var.octopusdeploy_server_thumbprint
}

## HAProxy ##
data "haproxy_backend" "backend" {
  name = var.haproxy_backend_name
}
resource "haproxy_server" "server" {
  name        = "{{ var.virtual_machine.host_name }}.{{ var.virtual_machine.domain }}"
  port        = 443
  address     = var.virtual_machine.ipv4_address
  parent_name = data.haproxy_backend.backend.id
  parent_type = "backend"
  check       = true
  inter       = 2000
  rise        = 5
  fall        = 2
  depends_on  = [data.haproxy_backend.backend]
}

The calling module looks like this:
provider "vsphere" {
  user           = var.vsphere_username
  password       = sensitive(var.vsphere_password)
  vsphere_server = var.vsphere_server
}
provider "octopusdeploy" {
  address = var.octopusdeploy_address
  api_key = var.octopusdeploy_api_key
}
provider "haproxy" {
  url      = "https://example.internal"
  username = var.haproxy_dataplane_username
  password = var.haproxy_dataplane_password
}

locals {
  instances = tomap({
    server01 : "xxx.xxx.xxx.xxx",
    server02 : "xxx.xxx.xxx.xxx"
  })
  domain                            = "domain"
  ipv4_gateway                      = "xxx.xxx.xxx.xxx"
  ipv4_netmask                      = 24
  dns_server_list                   = ["xxx.xxx.xxx.xxx"]
  dns_suffix_list                   = ["suffix1"]
  vsphere_datacenter_cluster        = "datacenter cluster"
  vsphere_compute_cluster_name      = "datacenter cluster"
  vsphere_resource_pool_name        = "datacenter cluster/resources"
  vsphere_datastore                 = "datastore"
  vsphere_content_library_item_name = "win-2022-std-core"
  vsphere_network_name              = "Network-Dev"
  octopusdeploy_target_roles = [
    "role1"
  ]
}

module "web_servers" {
  source = "../../modules/web_servers"
  providers = {
    octopusdeploy = octopusdeploy
    haproxy       = haproxy
  }
  for_each = local.instances
  vsphere = {
    datacenter_cluster        = var.vsphere_datacenter_cluster
    compute_cluster_name      = local.vsphere_compute_cluster_name
    datastore                 = local.vsphere_datastore
    content_library           = var.vsphere_content_library
    content_library_item_name = local.vsphere_content_library_item_name
    network_name              = local.vsphere_network_name
  }
  virtual_machine = {
    host_name             = each.key
    ipv4_address          = each.value
    ipv4_gateway          = local.ipv4_gateway
    ipv4_netmask          = local.ipv4_netmask
    dns_server_list       = local.dns_server_list
    dns_suffix_list       = local.dns_suffix_list
    is_windows_image      = true
    domain                = local.domain
    domain_admin_user     = var.domain_join_username
    domain_admin_password = var.sredmz_domain_join_password
  }
  octopusdeploy_server_thumbprint = var.octopusdeploy_server_thumbprint
  octopusdeploy_environments      = var.octopusdeploy_environments
  octopusdeploy_machine_policies  = var.octopusdeploy_machine_policy_ids
  octopusdeploy_space_name        = var.octopusdeploy_space_name
  name                            = "${each.key}.${local.domain}"
  octopusdeploy_target_roles      = local.octopusdeploy_target_roles
  haproxy_backend_name            = "some_443-backend"
}

Steps to Reproduce
Create setup similar to above to use the haproxy provider plugin.
Expected behavior: Server "server01.domain" to be added to "some_443-backend" in HAProxy.
Actual behavior: Plugin crashes with following error:
│ Error: Plugin did not respond
│
│   with module.module2["server01"].data.haproxy_backend.backend,
│   on ../../modules/module2/providers.tf line 47, in data "haproxy_backend" "backend":
│   47: data "haproxy_backend" "backend" {
│
│ The plugin encountered an error, and failed to respond to the plugin.(*GRPCProvider).ReadDataSource call. The plugin logs
│ may contain more details.
╵
╷
│ Error: Request cancelled
│
│   with module.module2["server02"].data.haproxy_backend.backend,
│   on ../../modules/module2/providers.tf line 47, in data "haproxy_backend" "backend":
│   47: data "haproxy_backend" "backend" {
│
│ The plugin.(*GRPCProvider).ReadDataSource request was cancelled.
╵

Stack trace from the terraform-provider-haproxy_v0.0.7 plugin:

panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x2 addr=0x10 pc=0x104ce49dc]

goroutine 56 [running]:
terraform-provider-haproxy/internal/backend.dataSourceHaproxyABackendRead(0x1400010f5f0?, {0x1050a1780?, 0x14000138b70})
        terraform-provider-haproxy/internal/backend/data_source.go:37 +0x10c
github.com/hashicorp/terraform-plugin-sdk/helper/schema.(*Resource).ReadDataApply(0x1400048be00, 0x1400010f530?, {0x1050a1780, 0x14000138b70})
        github.com/hashicorp/terraform-plugin-sdk@v1.17.2/helper/schema/resource.go:413 +0x5c
github.com/hashicorp/terraform-plugin-sdk/helper/schema.(*Provider).ReadDataApply(0x14000518680, 0x1400053b9a0, 0x1050a1780?)
        github.com/hashicorp/terraform-plugin-sdk@v1.17.2/helper/schema/provider.go:451 +0x60
github.com/hashicorp/terraform-plugin-sdk/internal/helper/plugin.(*GRPCProviderServer).ReadDataSource(0x1400000ef80, {0x140002c7c40?, 0x1400049cc40?}, 0x140002c7c40)
        github.com/hashicorp/terraform-plugin-sdk@v1.17.2/internal/helper/plugin/grpc_provider.go:1046 +0x29c
github.com/hashicorp/terraform-plugin-sdk/internal/tfplugin5._Provider_ReadDataSource_Handler({0x1051c1140?, 0x1400000ef80}, {0x10520bbb0, 0x14000139470}, 0x1400049cc40, 0x0)
        github.com/hashicorp/terraform-plugin-sdk@v1.17.2/internal/tfplugin5/tfplugin5.pb.go:3341 +0x170
google.golang.org/grpc.(*Server).processUnaryRPC(0x14000338000, {0x105210920, 0x14000103380}, 0x1400021a000, 0x140004a3e00, 0x1058ba3d0, 0x0)
        google.golang.org/grpc@v1.56.0/server.go:1337 +0xc90
google.golang.org/grpc.(*Server).handleStream(0x14000338000, {0x105210920, 0x14000103380}, 0x1400021a000, 0x0)
        google.golang.org/grpc@v1.56.0/server.go:1714 +0x82c
google.golang.org/grpc.(*Server).serveStreams.func1.1()
        google.golang.org/grpc@v1.56.0/server.go:959 +0x84
created by google.golang.org/grpc.(*Server).serveStreams.func1
        google.golang.org/grpc@v1.56.0/server.go:957 +0x16c

Error: The terraform-provider-haproxy_v0.0.7 plugin crashed!

This is always indicative of a bug within the plugin. It would be immensely
helpful if you could report the crash with the plugin's maintainers so that it
can be fixed. The output above should help diagnose the issue.

Reproduces how often: [What percentage of the time does it reproduce?]
Versions
Terraform v1.7.0
on darwin_arm64

provider registry.terraform.io/hashicorp/vsphere v2.6.1
provider registry.terraform.io/octopusdeploylabs/octopusdeploy v0.14.9
provider registry.terraform.io/sepehrimanian/haproxy v0.0.7

Additional Information
Any additional information, configuration or data that might be necessary to reproduce the issue.

Hi, Thank you for taking the time to report this issue, Did you create "haproxy_backend" terraform resource first ?
for example like this:
resource "haproxy_backend" "backend" {
  name  = ...
  mode  = "tcp"
  balance {
    algorithm = "..."
  }
}

data "haproxy_backend" "backend" {
  name = var.haproxy_backend_name
}

the err is:
with module.module2["server02"].data.haproxy_backend.backend,
│   on ../../modules/module2/providers.tf line 47, in data "haproxy_backend" "backend":
│   47: data "haproxy_backend" "backend" {

It's possible that the 'haproxy_backend' doesn't exist.
@KiyoIchikawa

I'm glad I can help out, thank you for creating this provider! We appreciate your time on this.
The "haproxy_backend" is not managed by Terraform and does exist in the HAProxy instance provided. We are hoping to manage the base HAProxy configuration via a different tool and insert servers into pre-existing backends (not managed by Terraform) as they are created by Terraform.

Same issue here, just creating a simple backend:
Terraform will perform the following actions:

  # haproxy_backend.master_controlplane will be created
  + resource "haproxy_backend" "master_controlplane" {
      + check_cache          = true
      + check_timeout        = 10
      + connect_timeout      = 10
      + http_connection_mode = "http-keep-alive"
      + id                   = (known after apply)
      + mode                 = "http"
      + name                 = "master-api"
      + queue_timeout        = 10
      + server_timeout       = 9

      + balance {
          + algorithm = "roundrobin"
        }

      + forwardfor {
          + enabled = false
        }

      + httpchk_params {
          + method  = "GET"
          + uri     = "/health"
          + version = "HTTP/1.1"
        }
    }

Plan: 1 to add, 0 to change, 0 to destroy.

Do you want to perform these actions?
  Terraform will perform the actions described above.
  Only 'yes' will be accepted to approve.

  Enter a value: yes

haproxy_backend.master_controlplane: Creating...
╷
│ Error: Plugin did not respond
│
│   with haproxy_backend.master_controlplane,
│   on main.tf line 140, in resource "haproxy_backend" "master_controlplane":
│  140: resource "haproxy_backend" "master_controlplane" {
│
│ The plugin encountered an error, and failed to respond to the
│ plugin.(*GRPCProvider).ApplyResourceChange call. The plugin logs may contain more details.
╵

Stack trace from the terraform-provider-haproxy_v0.0.7 plugin:

panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x10 pc=0xdd405a]

goroutine 57 [running]:
terraform-provider-haproxy/internal/backend.resourceHaproxyBackendCreate(0xc00080f340, {0xf83980?, 0xc0007993b0})
        terraform-provider-haproxy/internal/backend/resource.go:247 +0xa9a
github.com/hashicorp/terraform-plugin-sdk/helper/schema.(*Resource).Apply(0xc0003900a0, 0xc00098afa0, 0xc000810ee0, {0xf83980, 0xc0007993b0})
        github.com/hashicorp/terraform-plugin-sdk@v1.17.2/helper/schema/resource.go:320 +0x438
github.com/hashicorp/terraform-plugin-sdk/helper/schema.(*Provider).Apply(0xc000713480, 0xc000173908, 0x10e613b?, 0xf?)
        github.com/hashicorp/terraform-plugin-sdk@v1.17.2/helper/schema/provider.go:294 +0x70
github.com/hashicorp/terraform-plugin-sdk/internal/helper/plugin.(*GRPCProviderServer).ApplyResourceChange(0xc0000127c0, {0xc00080ed90?, 0x497a26?}, 0xc00080ed90)
        github.com/hashicorp/terraform-plugin-sdk@v1.17.2/internal/helper/plugin/grpc_provider.go:895 +0x805
github.com/hashicorp/terraform-plugin-sdk/internal/tfplugin5._Provider_ApplyResourceChange_Handler({0x10a0f20?, 0xc0000127c0}, {0x12f4210, 0xc0009911a0}, 0xc00080ed20, 0x0)
        github.com/hashicorp/terraform-plugin-sdk@v1.17.2/internal/tfplugin5/tfplugin5.pb.go:3305 +0x170
google.golang.org/grpc.(*Server).processUnaryRPC(0xc000276000, {0x12f8fc0, 0xc000144b60}, 0xc0009939e0, 0xc0002781b0, 0x19c1460, 0x0)
        google.golang.org/grpc@v1.56.0/server.go:1337 +0xdf3
google.golang.org/grpc.(*Server).handleStream(0xc000276000, {0x12f8fc0, 0xc000144b60}, 0xc0009939e0, 0x0)
        google.golang.org/grpc@v1.56.0/server.go:1714 +0xa36
google.golang.org/grpc.(*Server).serveStreams.func1.1()
        google.golang.org/grpc@v1.56.0/server.go:959 +0x98
created by google.golang.org/grpc.(*Server).serveStreams.func1
        google.golang.org/grpc@v1.56.0/server.go:957 +0x18c

Error: The terraform-provider-haproxy_v0.0.7 plugin crashed!

This is always indicative of a bug within the plugin. It would be immensely
helpful if you could report the crash with the plugin's maintainers so that it
can be fixed. The output above should help diagnose the issue.

haproxy+dataplane running on docker:  tried with versions 3.1 and 2.9
haproxy plugin version: 0.0.7
terraform: 1.9.8
provider config:
provider "haproxy" {
url      = "http://127.0.0.1:5555"
username = "admin"
password = var.haproxy_password
}
Dataplane works creating backends with curl from the host, no problem at all.

Seems it fails because we are using dataplane v3?
Looking at the code, the urls use /v2/ everywhere.

authors: KiyoIchikawa SepehrImanian framegrace


text:
PrCommand: Minor improvements to the formatting of merged pull requests

Previously even a merged pull request would be colored red

This adds a new field containing when the pull request got merged and who merged it

Nice! Thanks for the PR :blue_heart:

authors: bgianfo networkException

repo: SerenityOS/discord-bot


text:
Update RustCrypto dependencies

Updates the following RustCrypto dependencies to the latest versions:

aes-gcm v0.8.0
hmac v0.10.0
hkdf v0.10.0

Updated to use the hkdf v0.10.0 release

Awesome. Thanks for keeping an eye on this. Merged in cff858231387d27bd0a3fc2dec8860846bcdc79b.

authors: SergioBenitez tarcieri

repo: SergioBenitez/cookie-rs


text:
Change of projet

In mode off multi-project, it's very long to change of projet.
It will be great to display all project with then différent branches ?

You mean show a tree with 2 projects and flow branches for each project?
I was thinking about that approach, but that really complicates a lot of things for me. I would like to avoid it, because for that I need to record the whole extension because the main architecture has to be changed.

I that I mean....
I know that is a big change, but when you work on différent project in a same workspace, you have to change of projet, refresh , ...
It's long ;-)

authors: Serhioromano tguenneguez

repo: Serhioromano/vscode-gitflow


text:
bug(auth): wrong hostname on named app_url

On the master, when requesting a connection, the magic link with the token uses the wrong hostname. It seems to still inherit from preview and dev environment as it use the $VERCEL_URL

Fixed with 6dc2c46


text:
Import fails when using a database user with empty password

This is happening because of the validation that checks that
the password is not null and empty on line 145 of MysqlImportService
Example code to reproduce
String sql = new String(Files.readAllBytes(Paths.get("external/test_output_file_name.sql")));
        MysqlImportService res = MysqlImportService.builder();
        res.setJdbcDriver("com.mysql.cj.jdbc.Driver");
        res.setJdbcConnString("jdbc:mysql://localhost:3306/backup4j_test?useUnicode=true&useJDBCCompliantTimezoneShift=true&useLegacyDatetimeCode=false&serverTimezone=UTC&useSSL=false");
        res.setSqlString(sql);
        res.setUsername("smatt");
        res.setPassword("smatt");
        res.setDropExisting(true);
        assertTrue(res.importDatabase());

Fixed in version 1.2.0


text:
insta close

spiel stürtzt mach 10-20minuten ab...
ich bin nicht der einzige mit diesem problem, woran es liegen könnte habe ich allerdings nicht herrausgefunden

Nein, ich habe das auch und wiederholt! Wollte gerade ein Thread aufmachen :D
Jedes mal, wenn eine KI die andere mit vielen Einheiten angreift und ein Video kommt (kurz bevor jemand verliert), dann stürzt das Spiel ab.
Vermutlich hat es mit irgend einer Neuerung zu tun, dass keine Gebäude mehr eingerissen werden können und kein Schlafmodus mehr aktiviert wird. Das würden die KI's normaler weise tun wenn sie so unter Bedrängnis sind.

jip, hab das auch.

I also got the same bugs :(

scheint so, ich hab grad mal den patch ohne abreißen installiert und es ist nicht abgestürzt

Falls das noch mehr bestätigen könnten, wäre das hilfreich. Dieses verdammte Abreißen schon wieder... :D

Hab das Problem gefunden, hatte vergessen eine Datei zu aktualisieren. Hotfix kommt gleich...


text:
LET PEOPLE REMOVE DISCORDCLIENT

What feature do you want to get added on the base engine?

Let people allow or not allow discord on their build if they're having an error like include\backend/discordclient.h(11): fatal error c1083: cannot open include file: 'discord_rpc.h': no such file or directory (referenced from issues #13881)
To test your sight, and reliability, please select the option of what should NOT be requested.
Stage Editor, 6K+ support, and winning icons.

Added in the latest commit of experimental 👍

authors: ShadowMario ZanderRivera

repo: ShadowMario/FNF-PsychEngine


text:
I CANT PLAY FNF MODS HEEELP

Describe your bug here.
Ok I'll tell you the full story:
I did a cover of a song of 4 minutes and the characters wouldn't load, I restarted the game and it was fixed, but when I tried to play it a second time, the game froze, I tried to close it with classic alt+f4, opening the task manager and nothing worked, I had to restart my pc.
Now every time I enter the mod the game goes to 10 fps, and not only the mod or the psych engine ALL THE MODS go like that, I already restarted my pc like 3 times and nothing happens.
I know that the problem is not performance because my pc runs games like Valorant or Fortnite without problems. I guess it's because some fnf file was corrupted or something like that, if you know how to fix it please tell me how because I can't play any fnf mod
(Sorry for the bad english, im using a translator)
Command Prompt/Terminal logs (if existing)
No response
Are you modding a build from source or with Lua?
Lua
What is your build target?
Windows
Did you edit anything in this build? If so, mention or summarize your changes.
I just deleted some options from the menu, and easy and normal difficult

ummm
Try to delete the shadowmario folder in %appdata%

Ok i just needed to update my Windows version


text:
getting bf, gf, dad camera position

What is your question?
bro, how to get the value of bf.cameraPosition and boyfriendCameraOffset[0] / [1] ?
i'm really dont know how to use getPropertyFromGroup. any one know how to get that value ?

local camOffset = getProperty('boyfriendCameraOffset')
-- you can now access it like: boyfriendCameraOffset[1] for the first element of the array

authors: BillyLOLwkwk Stilic


text:
Repgrams most things

hey i added some new stuff. please check it out add what you like do what you want to with this! (also its psych engine but better!)

do not add week 7

I feel like this is gonna get closed

Oh so you made it worse? Good job.

You should not add Week 7, since it's Newgrounds exclusive, and I don't think it's allowed...

But, letting that aside, it's cool. :)
Also, thanks for using that week visibility thing I made. It's appreciated. 👍

Oh so OVERALL you made it worse? Good job!

Removing the original creators from the Credits.hx is extremely disrespectful in my eyes.
The changes to FlashingState.hx, FreeplayState.hx, MainMenuState.hx are unnecessary, keep this to your personal builds.
Why would anyone EVER want rainbow coloured fps? it's just dumb.

I like the Roses stuff you did tho.

I agree too he just did it worse

@ShadowMario You might want to close this.

But, letting that aside, it's cool. :)
Also, thanks for using that week visibility thing I made. It's appreciated. 👍

np! ima finish it off and add more stuff. also the og credits will be readded! also ill add a new setting for psych but better watermarks! sorry for the issues!

Oh so OVERALL you made it worse? Good job!

Removing the original creators from the Credits.hx is extremely disrespectful in my eyes.
The changes to FlashingState.hx, FreeplayState.hx, MainMenuState.hx are unnecessary, keep this to your personal builds.
Why would anyone EVER want rainbow coloured fps? it's just dumb.

I like the Roses stuff you did tho.

hey ima add a pysch but better watermark and thanks for liking the roses thing. also the credits for the pysch engine and fnf credits will be readded! thanks i may remove rainbow colored fps but i just like it and some people use it.

@MeguminBOT i tried my best to add the og psych engine credits ima do more of the credits later. check my commits on it if you want :3

Reference in ne

:C im trying my best out here. cant you be a bit nicer?

i have looked throught the code now and i've gotta say that 99% of your changes are just absolute trash.
Sorry not sorry.
You can use this for your own, but don't try to merge it with the original.

Should I @ someone?

Should I @ someone?

Imma do it

@ShadowMario Security alert! SECURITY ALERT!

God-
What is this mess??? You just fucking ruined an engine! No offense but DID YOU HAD TO INCLUDE WEEK 7'S CODE IN YOUR PR?!

This sucks

What the fuck is wrong with you?, this pr sucks top down. Barely any code changes and shitty name changes

cringe pr

You don't even need api stuff, nobody is gonna be playing fucking Psych on newgrounds, please delete this before I somehow manage to obtain the ability to contract autism from reading this unholy shit

What the fuck is even the point of plans, reverting psych to fuckin 1.1 jesus christ dude... If I have to look at this PR one more time then I'd take a nice swig of salty piss in my mouth
I'm a dumbass in haxe and this looks like complete shit

What the fuck is even the point of plans, reverting psych to fuckin 1.1 jesus christ dude... If I have to look at this PR one more time then I'd take a nice swig of salty piss in my mouth
I'm a dumbass in haxe and this looks like complete shit

LMAO

What the fuck is wrong with you?, this pr sucks top down. Barely any code changes and shitty name changes

listen were working hard dont be mean :c ur just gonna make us work slower for people who actaully want this

You don't even need api stuff, nobody is gonna be playing fucking Psych on newgrounds, please delete this before I somehow manage to obtain the ability to contract autism from reading this unholy shit

stop

What the fuck is even the point of plans, reverting psych to fuckin 1.1 jesus christ dude... If I have to look at this PR one more time then I'd take a nice swig of salty piss in my mouth
I'm a dumbass in haxe and this looks like complete shit

DUDE WERE WORKING HARD.  and plus its a custom stuff

u are actually doing something illegal, like week 7, it is currently prohibited, u can't do this for a open source while original week 7 isn't open source, so u will need to remove it of ur plans
and removing the whole readme was rlly unnecessary

so stop making things that will not be used, srsly dude

and bro, if u want to do this as just a another version of psych, don't make a fuckin pr for the og repo

pull requests are more important than this

You don't even need api stuff, nobody is gonna be playing fucking Psych on newgrounds, please delete this before I somehow manage to obtain the ability to contract autism from reading this unholy shit

BRO IT AINT NEWGROUNDS ITS NEEDED TO COMPILE NOOB

pull requests are more important than this

IDC you cant bring me down

so stop making things that will not be used, srsly dude

i am furrycoltin you cant bring me down!!

so stop making things that will not be used, srsly dude

i am furrycoltin you cant bring me down!!

bro i'm laughing after reading this

but for serious, don't make this as a pr, just make a normal repo, cuz pull requests are made for important commits, and not something like "i MaDe It BeTtEr"

how is this not closed yet

yeah, this PR is really fucked
@ShadowMario please, check this shit

Yea, what the fuck is this shit

i rlly hate kiddos using github

i rlly hate kiddos using github

So what we must use? Maybe Messenger xD

men, you ruined the entire engine. just closes this pr and go to brazil instead.

i rlly hate kiddos using github

So what we must use? Maybe Messenger xD

random

cringe prrrrr

ok so, what the actual fuck is this PR?

God give me strength so I can whoop your ass into the fuckin stratosphere, and send you into orbit, just so that way it's guaranteed that you can't make any more dumb shit on GitHub

Man, you ruined the entire engine. Just close this pr and go to Brazil instead.

Nah, SM lives in Brazil, it'll just encourage this shit. Send this kid into orbit instead, why don't you?

cringe prrrrr

that's what i said at some time ago lol

I'm so sorry for the un-constructive commentary, but I just can't muster anything positive about this. The PR is unnessecary, useless, and not productive. It's just not worth the effort of being positive.

This is an obvious fucking troll, garbage in every single way, and shadow mario's just gonna close it and block you, you basically shot urself in the foot, idiot.

This is an obvious fucking troll, garbage in every single way, and shadow mario's just gonna close it and block you, you basically shot urself in the foot, idiot.

And your adding week 7? Bro...

This is an obvious fucking troll, garbage in every single way, and shadow mario's just gonna close it and block you, you basically shot urself in the foot, idiot.

And your adding week 7? Bro...

So so very cringe indeed... My god.

Anyway stream
https://soundcloud.com/michael-hillard/worlds-smallest-cup on Soundcloud

so true

This overrides the original credits from the Engine. You know that Pull Requests are like suggestions to the main code, right? Do whatever you want with a downloaded version of the code, but please, do not try to suggest these changes to the Main Source Code.

By the way, are you at least 13 years or older? Just a question... :]

"psych engine but better"

By the way, are you at least 13 years or older? Just a question... :]

(Obviously a joke)

(Let's dismiss him...)

@ShadowMario Please dismiss this pr already!

What the fuck is even the point of plans, reverting psych to fuckin 1.1 jesus christ dude... If I have to look at this PR one more time then I'd take a nice swig of salty piss in my mouth
I'm a dumbass in haxe and this looks like complete shit

DUDE WERE WORKING HARD. and plus its custom and different. its just please dont be mean.

Then why are you trying to get it merged.

You don't even need api stuff, nobody is gonna be playing fucking Psych on newgrounds, please delete this before I somehow manage to obtain the ability to contract autism from reading this unholy shit

BRO IT AINT NEWGROUNDS ITS NEEDED TO COMPILE NOOB

You are the noob here because you are making an unwanted pull request instead of compiling it on your own fork. @blaidev

Jesus you just bloated the engine with useless things literally 1 person (probably you) will use.

authors: CrusherMods DMMaster636 DaBanana64 Doritojoey Fronekowy FurryColtin Gui-iago HiroMizuki Keoiki MeguminBOT MeowcaTheoRange ShadowMario Stilic XtraXD1 blaidev fireredfan7 gaminbottomtext magnumsrtisswag skedgyedgy tposejank


text:
Wizard tower doesn't generate

Hello i'm in 1.19.2 version.
I searched through the configs and couldn't find any trace of the wizard towers being generated.
Is this a bug or has it not been implemented?

The tower was removed in 1.18.  It may be readded at a later date, but it is currently not enabled.

repo: Shadows-of-Fire/Apotheosis


text:
Not receiving mob drops

I'm using the mod on 1.12.2, and no matter what i do, i only have the bulbs and not the drops.

Was using the wrong version.


text:
Create MyRocks and TokuDB tables for tests

Alter some of the sysbench tables to use:

With PS 5.7 MyRocks + TokuDB
With Ps 5.6 only TokuDB

With PS 5.6:
2017-11-16 18:02:01 DEBUG    OK: Running -> /home/shahriyar.rzaev/XB_TEST/server_dir/PS131117-percona-server-5.6.38-82.3-linux-x86_64-debug/bin/mysql -A -uroot -S/home/shahriyar.rzaev/XB_TEST/server_dir/PS131117-percona-server-5.6.38-82.3-linux-x86_64-debug/socket.sock --force test -e "alter table sysbench_test_db.sbtest15 engine=tokudb"
2017-11-16 18:02:01 DEBUG    Trying to get mysql client connection...
2017-11-16 18:02:01 DEBUG    Could get mysql client
2017-11-16 18:02:02 DEBUG    OK: Running -> /home/shahriyar.rzaev/XB_TEST/server_dir/PS131117-percona-server-5.6.38-82.3-linux-x86_64-debug/bin/mysql -A -uroot -S/home/shahriyar.rzaev/XB_TEST/server_dir/PS131117-percona-server-5.6.38-82.3-linux-x86_64-debug/socket.sock --force test -e "alter table sysbench_test_db.sbtest16 engine=tokudb"
2017-11-16 18:02:02 DEBUG    Trying to get mysql client connection...
2017-11-16 18:02:02 DEBUG    Could get mysql client
2017-11-16 18:02:03 DEBUG    OK: Running -> /home/shahriyar.rzaev/XB_TEST/server_dir/PS131117-percona-server-5.6.38-82.3-linux-x86_64-debug/bin/mysql -A -uroot -S/home/shahriyar.rzaev/XB_TEST/server_dir/PS131117-percona-server-5.6.38-82.3-linux-x86_64-debug/socket.sock --force test -e "alter table sysbench_test_db.sbtest17 engine=tokudb"
2017-11-16 18:02:03 DEBUG    Trying to get mysql client connection...
2017-11-16 18:02:03 DEBUG    Could get mysql client
2017-11-16 18:02:03 DEBUG    OK: Running -> /home/shahriyar.rzaev/XB_TEST/server_dir/PS131117-percona-server-5.6.38-82.3-linux-x86_64-debug/bin/mysql -A -uroot -S/home/shahriyar.rzaev/XB_TEST/server_dir/PS131117-percona-server-5.6.38-82.3-linux-x86_64-debug/socket.sock --force test -e "alter table sysbench_test_db.sbtest18 engine=tokudb"
2017-11-16 18:02:03 DEBUG    Trying to get mysql client connection...
2017-11-16 18:02:03 DEBUG    Could get mysql client
2017-11-16 18:02:05 DEBUG    OK: Running -> /home/shahriyar.rzaev/XB_TEST/server_dir/PS131117-percona-server-5.6.38-82.3-linux-x86_64-debug/bin/mysql -A -uroot -S/home/shahriyar.rzaev/XB_TEST/server_dir/PS131117-percona-server-5.6.38-82.3-linux-x86_64-debug/socket.sock --force test -e "alter table sysbench_test_db.sbtest19 engine=tokudb"

With PS 5.7:
2017-11-16 18:05:13 DEBUG    OK: Running -> /home/shahriyar.rzaev/XB_TEST/server_dir/PS131117-percona-server-5.7.19-17-linux-x86_64/bin/mysql -A -uroot -S/home/shahriyar.rzaev/XB_TEST/server_dir/PS131117-percona-server-5.7.19-17-linux-x86_64/socket.sock --force test -e "alter table sysbench_test_db.sbtest1 encryption='Y'"
2017-11-16 18:05:13 DEBUG    Trying to get mysql client connection...
2017-11-16 18:05:13 DEBUG    Could get mysql client
2017-11-16 18:05:13 DEBUG    OK: Running -> /home/shahriyar.rzaev/XB_TEST/server_dir/PS131117-percona-server-5.7.19-17-linux-x86_64/bin/mysql -A -uroot -S/home/shahriyar.rzaev/XB_TEST/server_dir/PS131117-percona-server-5.7.19-17-linux-x86_64/socket.sock --force test -e "alter table sysbench_test_db.sbtest2 encryption='Y'"
2017-11-16 18:05:13 DEBUG    Trying to get mysql client connection...
2017-11-16 18:05:13 DEBUG    Could get mysql client
2017-11-16 18:05:13 DEBUG    OK: Running -> /home/shahriyar.rzaev/XB_TEST/server_dir/PS131117-percona-server-5.7.19-17-linux-x86_64/bin/mysql -A -uroot -S/home/shahriyar.rzaev/XB_TEST/server_dir/PS131117-percona-server-5.7.19-17-linux-x86_64/socket.sock --force test -e "alter table sysbench_test_db.sbtest3 encryption='Y'"
2017-11-16 18:05:13 DEBUG    Trying to get mysql client connection...
2017-11-16 18:05:13 DEBUG    Could get mysql client
2017-11-16 18:05:13 DEBUG    OK: Running -> /home/shahriyar.rzaev/XB_TEST/server_dir/PS131117-percona-server-5.7.19-17-linux-x86_64/bin/mysql -A -uroot -S/home/shahriyar.rzaev/XB_TEST/server_dir/PS131117-percona-server-5.7.19-17-linux-x86_64/socket.sock --force test -e "alter table sysbench_test_db.sbtest4 encryption='Y'"
2017-11-16 18:05:13 DEBUG    Trying to get mysql client connection...
2017-11-16 18:05:13 DEBUG    Could get mysql client
2017-11-16 18:05:14 DEBUG    OK: Running -> /home/shahriyar.rzaev/XB_TEST/server_dir/PS131117-percona-server-5.7.19-17-linux-x86_64/bin/mysql -A -uroot -S/home/shahriyar.rzaev/XB_TEST/server_dir/PS131117-percona-server-5.7.19-17-linux-x86_64/socket.sock --force test -e "alter table sysbench_test_db.sbtest5 encryption='Y'"
2017-11-16 18:05:14 DEBUG    Trying to get mysql client connection...
2017-11-16 18:05:14 DEBUG    Could get mysql client
2017-11-16 18:05:14 DEBUG    OK: Running -> /home/shahriyar.rzaev/XB_TEST/server_dir/PS131117-percona-server-5.7.19-17-linux-x86_64/bin/mysql -A -uroot -S/home/shahriyar.rzaev/XB_TEST/server_dir/PS131117-percona-server-5.7.19-17-linux-x86_64/socket.sock --force test -e "alter table sysbench_test_db.sbtest6 encryption='Y'"
2017-11-16 18:05:14 DEBUG    Trying to get mysql client connection...
2017-11-16 18:05:14 DEBUG    Could get mysql client
2017-11-16 18:05:14 DEBUG    OK: Running -> /home/shahriyar.rzaev/XB_TEST/server_dir/PS131117-percona-server-5.7.19-17-linux-x86_64/bin/mysql -A -uroot -S/home/shahriyar.rzaev/XB_TEST/server_dir/PS131117-percona-server-5.7.19-17-linux-x86_64/socket.sock --force test -e "alter table sysbench_test_db.sbtest7 encryption='Y'"
2017-11-16 18:05:14 DEBUG    Trying to get mysql client connection...
2017-11-16 18:05:14 DEBUG    Could get mysql client
2017-11-16 18:05:14 DEBUG    OK: Running -> /home/shahriyar.rzaev/XB_TEST/server_dir/PS131117-percona-server-5.7.19-17-linux-x86_64/bin/mysql -A -uroot -S/home/shahriyar.rzaev/XB_TEST/server_dir/PS131117-percona-server-5.7.19-17-linux-x86_64/socket.sock --force test -e "alter table sysbench_test_db.sbtest8 encryption='Y'"
2017-11-16 18:05:14 DEBUG    Trying to get mysql client connection...
2017-11-16 18:05:14 DEBUG    Could get mysql client
2017-11-16 18:05:15 DEBUG    OK: Running -> /home/shahriyar.rzaev/XB_TEST/server_dir/PS131117-percona-server-5.7.19-17-linux-x86_64/bin/mysql -A -uroot -S/home/shahriyar.rzaev/XB_TEST/server_dir/PS131117-percona-server-5.7.19-17-linux-x86_64/socket.sock --force test -e "alter table sysbench_test_db.sbtest9 encryption='Y'"
2017-11-16 18:05:15 DEBUG    Trying to get mysql client connection...
2017-11-16 18:05:15 DEBUG    Could get mysql client
2017-11-16 18:05:15 DEBUG    OK: Running -> /home/shahriyar.rzaev/XB_TEST/server_dir/PS131117-percona-server-5.7.19-17-linux-x86_64/bin/mysql -A -uroot -S/home/shahriyar.rzaev/XB_TEST/server_dir/PS131117-percona-server-5.7.19-17-linux-x86_64/socket.sock --force test -e "alter table sysbench_test_db.sbtest10 engine=rocksdb"
2017-11-16 18:05:15 DEBUG    Trying to get mysql client connection...
2017-11-16 18:05:15 DEBUG    Could get mysql client
2017-11-16 18:05:15 DEBUG    OK: Running -> /home/shahriyar.rzaev/XB_TEST/server_dir/PS131117-percona-server-5.7.19-17-linux-x86_64/bin/mysql -A -uroot -S/home/shahriyar.rzaev/XB_TEST/server_dir/PS131117-percona-server-5.7.19-17-linux-x86_64/socket.sock --force test -e "alter table sysbench_test_db.sbtest11 engine=rocksdb"
2017-11-16 18:05:15 DEBUG    Trying to get mysql client connection...
2017-11-16 18:05:15 DEBUG    Could get mysql client
2017-11-16 18:05:15 DEBUG    OK: Running -> /home/shahriyar.rzaev/XB_TEST/server_dir/PS131117-percona-server-5.7.19-17-linux-x86_64/bin/mysql -A -uroot -S/home/shahriyar.rzaev/XB_TEST/server_dir/PS131117-percona-server-5.7.19-17-linux-x86_64/socket.sock --force test -e "alter table sysbench_test_db.sbtest12 engine=rocksdb"
2017-11-16 18:05:15 DEBUG    Trying to get mysql client connection...
2017-11-16 18:05:15 DEBUG    Could get mysql client
2017-11-16 18:05:15 DEBUG    OK: Running -> /home/shahriyar.rzaev/XB_TEST/server_dir/PS131117-percona-server-5.7.19-17-linux-x86_64/bin/mysql -A -uroot -S/home/shahriyar.rzaev/XB_TEST/server_dir/PS131117-percona-server-5.7.19-17-linux-x86_64/socket.sock --force test -e "alter table sysbench_test_db.sbtest13 engine=rocksdb"
2017-11-16 18:05:15 DEBUG    Trying to get mysql client connection...
2017-11-16 18:05:15 DEBUG    Could get mysql client
2017-11-16 18:05:16 DEBUG    OK: Running -> /home/shahriyar.rzaev/XB_TEST/server_dir/PS131117-percona-server-5.7.19-17-linux-x86_64/bin/mysql -A -uroot -S/home/shahriyar.rzaev/XB_TEST/server_dir/PS131117-percona-server-5.7.19-17-linux-x86_64/socket.sock --force test -e "alter table sysbench_test_db.sbtest14 engine=rocksdb"
2017-11-16 18:05:16 DEBUG    Trying to get mysql client connection...
2017-11-16 18:05:16 DEBUG    Could get mysql client
2017-11-16 18:05:16 DEBUG    OK: Running -> /home/shahriyar.rzaev/XB_TEST/server_dir/PS131117-percona-server-5.7.19-17-linux-x86_64/bin/mysql -A -uroot -S/home/shahriyar.rzaev/XB_TEST/server_dir/PS131117-percona-server-5.7.19-17-linux-x86_64/socket.sock --force test -e "alter table sysbench_test_db.sbtest15 engine=tokudb"
2017-11-16 18:05:16 DEBUG    Trying to get mysql client connection...
2017-11-16 18:05:16 DEBUG    Could get mysql client
2017-11-16 18:05:16 DEBUG    OK: Running -> /home/shahriyar.rzaev/XB_TEST/server_dir/PS131117-percona-server-5.7.19-17-linux-x86_64/bin/mysql -A -uroot -S/home/shahriyar.rzaev/XB_TEST/server_dir/PS131117-percona-server-5.7.19-17-linux-x86_64/socket.sock --force test -e "alter table sysbench_test_db.sbtest16 engine=tokudb"
2017-11-16 18:05:16 DEBUG    Trying to get mysql client connection...
2017-11-16 18:05:16 DEBUG    Could get mysql client
2017-11-16 18:05:16 DEBUG    OK: Running -> /home/shahriyar.rzaev/XB_TEST/server_dir/PS131117-percona-server-5.7.19-17-linux-x86_64/bin/mysql -A -uroot -S/home/shahriyar.rzaev/XB_TEST/server_dir/PS131117-percona-server-5.7.19-17-linux-x86_64/socket.sock --force test -e "alter table sysbench_test_db.sbtest17 engine=tokudb"

Let's clarify situation a bit. XtraBackup will ignore, MyRocks and TokuDB tables and will continue to backup with Warning message.
The pt-table-checksum will fail because, those missing tables on slave side.
That's why I am going to disable this feature for now.
But it will be merged to release_v1.5.0

repo: ShahriyarR/MySQL-AutoXtraBackup


text:
Cannot set Fill of newly added Rectangle.

namespace TesterApp
{
    class Program
    {
        static void Main(string[] args)
        {
            // opens presentation from the file path
            var presentation = SCPresentation.Create();
            var slide = presentation.Slides[0];

            var shape = slide.Shapes.AddRectangle(0, 0, 100, 100);
            shape.Fill.SetColor("0000FF");

            presentation.SaveAs("test.pptx");
        }
    }
}

When running the code above, I would expect a rectangle with a blue solid fill, however the rectangle has no fill. Similarly, the wiki Solid Fill example does not work for me unless the shape already had a fill colour.
I am running ShapeCrawler 0.46.
Thanks for your great work so far.

It looks like the order of the properties matters. If I manually set the fill and save the PowerPoint, the fill comes before the outline inside the ShapeProperties. Then if I extract the PowerPoint created with ShapeCrawler and manually flip the Outline and Fill tags and re-zip the PowerPoint it works as expected.

@mcxbe, thank you for the bug report and your research. I was able to reproduce this issue.

@mcxbe, the issue was fixed. Please check this beta version v0.47.1-beta.1

authors: adamshakhabov mcxbe

repo: ShapeCrawler/ShapeCrawler


text:
Original web part is disposed and re-rendered after copying

Category

[x] Bug

Describe the bug
When web part is copied it's then disposed and re-rendered.
onDisposed is called, the WebPartContext is undefined and so on, just like when you remove web part completely from the page.
Steps to reproduce

Copy web part (Duplicate web part button)
Focus a copy
Original web part is disposed and re-rendered

Copy whole section (Duplicate section button)
Focus a copy
Focus original
Original web part is disposed and re-rendered

Expected behavior
Original web part is not disposed after copy.
Developer environment

SharePoint Online
Tooling: SPFx v1.9.1, VSCode
Browsers: v80.0.3987.149 (Official Build) (64-bit)

Where are you seeing the copy web part / copy section?

@andrewconnell sorry, here are more details:

I added Hero web part on the page
I copied it with Copy web part button (see screenshot)

After copy, I clicked on the new web parts
Dispose method of the original Hero is called (see screenshot)

On the second screenshot, I put a breakpoint inside dispose method of sp-page-assembly script, it's called every time you remove web part from the page.
The first time it hit when I clicked "Copy web part" button. I logged this.instanceId. This is unexpected.
The second time it hit when I clicked "Remove web part" button. I logged this.instanceId as well. This was expected.
See instanceId is the same both times which means the same web part is being disposed when copying and when deleting.
I just don't understand why onDispose is called when you copy the web part?
Thanks.

authors: SharePickle andrewconnell

repo: SharePoint/sp-dev-docs


text:
WebPart suffix is added twice to the web part class name

Category

[ ] Question
[ ] Typo
[x] Bug
[ ] Additional article idea

Expected or Desired Behavior
WebPart suffix is added once to the web part class name.
Observed Behavior
WebPart suffix is added twice to the web part class name, ie. WrongNameWebPartWebPart.
Steps to Reproduce

use generator v1.2.0 to create new project
add new web part
specify Wrong name as the web part's name
use default description
Use No JavaScript framework
once scaffolding is completed, open the WrongNameWebPart.ts file > the class name is WrongNameWebPartWebPart instead of WrongNameWebPart

This is still visible in generator v1.3.2

Thanks for reporting this Waldek, it should be fixed in the next drop.

I thought the process of closing issues before they were actually fixed and released was stopped @VesaJuvonen ?
IMHO, closed (if fixing a bug) should be what the rest of the world uses = "fixed & released" not "fixed and will be released at some point in the future"

Let's keep things open until they are truly fixed like we have done in the past. The fix is coming soon and will close this when provided.

Unfortunately, just tried repro using v1.3.4 and the issue seems to be still there @nickpape-msft

It's fixed in 1.4, not in 1.3.4. Coming pretty soon as well.

Gotcha, misread it 👍

authors: VesaJuvonen andrewconnell nickpape-msft waldekmastykarz


text:
SPFx 1.18 + MGT 3 fails to run gulp bundle

Target SharePoint environment
SharePoint Online
What SharePoint development model, framework, SDK or API is this about?
💥 SharePoint Framework
Developer environment
None
What browser(s) / client(s) have you tested

[ ] 💥 Internet Explorer
[ ] 💥 Microsoft Edge
[ ] 💥 Google Chrome
[ ] 💥 FireFox
[ ] 💥 Safari
[ ] mobile (iOS/iPadOS)
[ ] mobile (Android)
[ ] not applicable
[ ] other (enter in the "Additional environment details" area below)

Additional environment details
SPFx version: 1.18
Describe the bug / error
The MGT team asked me to create an issue in this repo as SPFx fails to bundle when used with MGT v3.
There is the initial issue in their repo: #2836
It seems that if we keep all the SPFx packages to "1.18.x" except "@microsoft/sp-build-web" that we set to "1.16.1", the bundle works without issues. So probably there is a problem with that library?
Steps to reproduce
Download the MGT samples and open the sp-webpart folder
https://github.com/pnp/mgt-samples/tree/main/samples/app/sp-webpart
Run pnpm install
Run gulp bundle
See error
[17:30:17] ==================[ Finished ]==================
Error - [webpack] Error processing webpack stats: TypeError: Cannot read properties of undefined (reading 'toJson')
Error - [webpack] Webpack error: TypeError: Cannot set properties of undefined (setting 'asyncChunks')
Expected behavior
Gulp bundle should run without errors

Is there any update on this issue? I'm currently experiencing the same behaviour

@Rafaelki - is it still happening with SPFx 1.19?

Hi @AJIXuMuK, I am unsure because we moved to MGT 4 where we didn't have this issue. Also, it is difficult to check anything in SPFx 1.19 due to #9834, which is a blocker for us to upgrade.
I think this issue can be closed.

authors: AJIXuMuK Rafaelki priests123


text:
Update site-design-json-schema.md

Changed from camel-case verb to friendly description as other sections are done this way.
Category

[ ] Content fix
[ ] New article
[x] Example checked item (delete this line)

DELETE THIS LINE BEFORE SUBMITTING | For the above list, an empty checkbox is [ ] as in [SPACE]. A checked checkbox is [x] with no space between the brackets. Use the PREVIEW tab at the top right to preview the rendering before submitting your issue.

Related issues

fixes #issuenumber
partially #issuenumber
mentioned in #issuenumber

DELETE THIS LINE BEFORE SUBMITTING | If this fixes (aka: closes) or references an issue, please reference it here. This helps maintaining the issue list as it will (1) link the PR to the issue & (2) automatically close the issue when this PR is merged in.

What's in this Pull Request?

DELETE THIS LINE BEFORE SUBMITTING | Please describe the changes in this PR. Sample description or details around bugs which are being fixed.

Submission guidelines

!!IMPORTANT!! - All submissions must complete the baseline sections included in this template. Ignoring or deleting this template may result in closing the issue with the label type:incomplete-submission.
Follow our guidance on How To Create Good Pull Requests.
Target the main branch of this repo.
When changing a page, ensure you update the ms.date front matter wih the current date in the format MM/DD/YYYY.
Review all build checks and address the automated errors, warnings, and suggestions.
NOTE: The live site is based on the live branch. Site owners periodically refresh live branch from the main branch so merged PRs won't immediately appear on the live site. Please be patient to see your changes appear on the live site.

DELETE THIS SECTION BEFORE SUBMITTING

@getalex You've changed one, but there are multiple places in the doc where this could be applied. Can you address these as well?
Also, please follow the instructions in the PR template. There are sections to explain what type of change this PR is, a place for comments, and a place for listing issues this addresses/closes. Completing the template is required for PR's. Thanks fo addressing these.

bump @getalex ... please see my previous reply - https://github.com/SharePoint/sp-dev-docs/pull/9250#issuecomment-1746700224

I don’t have the bandwidth at this time to apply the many changes requested and go through the PR template but will put it on the docket – apologies for the delay.
From: Andrew @.>
Sent: Wednesday, October 25, 2023 6:53 AM
To: @.>
Cc: Alex @.>; @.>
Subject: Re: [SharePoint/sp-dev-docs] Update site-design-json-schema.md (PR #9250)
bump @getalexhttps://github.com/getalex ... please see my previous reply - #9250 (comment)https://github.com/SharePoint/sp-dev-docs/pull/9250#issuecomment-1746700224
—
Reply to this email directly, view it on GitHubhttps://github.com/SharePoint/sp-dev-docs/pull/9250#issuecomment-1779004723, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AA23VH6EIG3FIFY33SDWP33YBDVTDAVCNFSM6AAAAAA5OWYA7GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONZZGAYDINZSGM.
You are receiving this because you were mentioned.Message ID: @.***>

authors: andrewconnell getalex


text:
Added the custom API secured with AAD sample

Q
A

Bug fix?
no

New feature?
no

New sample?
yes

Related issues?
n/a

What's in this Pull Request?
Sample solution illustrating how SharePoint Framework client-side web parts can communicate with custom Web API secured with Azure Active Directory.

Hi @waldekmastykarz, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
The agreement was validated by Microsoft and real humans are currently evaluating your PR.
TTYL, MSBOT;

authors: msftclas waldekmastykarz

repo: SharePoint/sp-dev-fx-webparts


text:
ConvertTo-PnPClientSidePage - no output and does nothing

Category
[X] Bug
[ ] Enhancement
Problem Area
[ ] Page Transformation: Error during the setup/use of the Page Transformation UI solution (did you check our troubleshooting guide?)
[X] Page Transformation: Error during the use of page transformation from PnP PowerShell
[ ] Page Transformation: Error during the use of page transformation from .Net
[ ] Page Transformation: Page is not looking correct after transformation
[ ] Modernization Scanner: something went wrong...
Expected or Desired Behavior
Running command:
ConvertTo-PnPClientSidePage -Identity "news-testing-future-date.aspx" -PublishingPage -TargetConnection $target -LogVerbose -LogType File -LogFolder c:\temp
Should generate some output in the log file and create a page on the target SPO site.
Observed Behavior
No new page is created and nothing is logged in the log file at all.
Steps to Reproduce
$target = Connect-PnPOnline https://tenant.sharepoint.com/sites/site/modernization -UseWebLogin -ReturnConnection
Connect-PnPOnline https://sharepoint.domain.com/news -CurrentCredentials
ConvertTo-PnPClientSidePage -Identity "news-testing-future-date.aspx" -PublishingPage -TargetConnection $target -LogVerbose -LogType File -LogFolder c:\temp
Submission Guidelines

@danmyhre , what version are you using? Can you try with -TargetWebUrl (e.g. -TargetWebUrl https://bertonline.sharepoint.com/sites/ModernizationTarget) and see if that works?

I have the following version installed:
3.13.1909.0
Nothing in Get-PnPException
On-prem SharePoint is 2013

Hi @danmyhre ,
The fact that nothing happens is really strange.
Can you try the following:

Check if there's no other SharePoint PnP modules loaded?

Get-Module -Name "SharePointPnPPowerShellOnline" -All

Connect to your on-premises site with PnP PowerShell and then lookup the ID of the page that fails and grab and share the contents of the WikiField

$p = Get-PnPListItem -List sitepages -Id $id
$p.FieldValues["WikiField"] | clip

Hi both,
Can you confirm if you are transforming into a Team Site, noticed the target URL is a Su site of a modern site?
Is the source a publishing page?
Does this occur on all pages?
I have seen rare cases where certain errors occur in the past don’t get reported or logged. E.g closed web parts think did this. We maybe hitting new edge case here.

Only the 1 version of the module exists - 3.13.1909.0
There is nothing in the "WikiField" property on the source, it is publishing page.  The content of the page exists in a field called "NewsBody"
Yes, was trying to go into a sub-site of a site collection.
I'll try a few other pages as well...

I tried against a normal team site homepage (SitePages/Home.aspx) and that seemed to process and I did receive logs, so this issue is only with publishing pages.

Missed the fact it was a publishing page, wikifield obviously does not exist there.
All of the publishing pages? Is this the root site collection or a regular one under a managed path (e.g. /sites or /teams)?

Source is a sub-web within the root site collection

Do you happen to have another publishing portal which is not a root site collection to test with. Would like to verify if it's root site collection related. We've fixed an issue with asset transformation on sub webs of the root site a couple of days ago.

I'll spin one up, will report back soon

That worked - it successfully created the page in SPO.  I went from a subsite in SPS to a subsite in SPO.
Source: https://sharepoint.domain.com/sites/Test-Publishing/News (publishing site)
Destination: https://tenant.sharepoint.com/sites/site/modernization

Alright...then there's something with the sub site of the root web. The current dev build I just tested does handle this correctly (in my lab). By Monday next week latest we'll release the October version which will contain fixes for root site collection handling. Still it bothers me that you're not getting a single error or log output...meaning as long as we're not able to repro the issue we can't ensure things will work with the October version.
Can you try to pass in a non existing page name and see if you get an error when working on the root site collection? Also does the same problem also occur for pages in the root web of the root site collection?

With a non-existent source page

no log file was produced at all

Received an error in PowerShell: ConvertTo-PnPClientSidePage : Object reference not set to an instance of an object.

So this issue is there for all pages on that particular sub site? Do you have pages in other sub sites that you can test? Or pages in the root web of that publishing portal?

I tried using a test page in the root web of the root site collection and it has the same issue of not migrating and producing no output in the log.

Hi @danmyhre ,
I've noticed that the log flushing logic could potentially not run...so I'm wrapping that in a try/finally block so it's always ran...this change will be part of the October release which will come out on Monday. Would recommend testing with that version, hoping that we now at least get a log telling us what went wrong.
Would that work for you?

Also would cross check that in case you've used the -LogSkipFlush parameter that you do flush the log at the end of the run.

Yes, I will try it again and report back once the new version is released.  Thanks!

Same result with 3.14.1910.0

HI @danmyhre ,
I'm puzzled...is it possible to have an online meeting so that I can try to troubleshoot this together with you?

you bet - I am open anytime today other than 10-11 am central.  dan.myhre@outlook.com

Thank you very much for your time today!  The root cause of no logging or migration being performed turned out to be not have site collection admin level permissions on the on-premises SP site.  Once this was added, the process began to work and the log file was generated.

authors: danmyhre jansenbe pkbullock

repo: SharePoint/sp-dev-modernization