text:
clightning: add shutdown hook for plugin

Introduces a shutdown hook to the clightning plugin, ensuring that the plugin is gracefully stopped when c-lightning shuts down.

Subscribe to the 'shutdown' event.
Updated glightning dependency to include the 'shutdown' event. https://github.com/ElementsProject/glightning/pull/20

fixes: https://github.com/ElementsProject/peerswap/issues/307

I'm getting this when shutting down CLN (v24.08.2):
2024-10-30T14:42:07.568Z UNUSUAL lightningd: JSON-RPC shutdown
2024-10-30T14:42:07.569Z DEBUG   lightningd: io_break: start_json_stream
2024-10-30T14:42:07.569Z DEBUG   lightningd: io_loop_with_timers: main
2024-10-30T14:42:07.569Z DEBUG   connectd: REPLY WIRE_CONNECTD_START_SHUTDOWN_REPLY with 0 fds
2024-10-30T14:42:07.569Z DEBUG   lightningd: io_break: connectd_start_shutdown_reply
...
2024-10-30T14:42:37.593Z DEBUG   lightningd: peerswap: failed to self-terminate in time, killing.
2024-10-30T14:42:37.594Z DEBUG   lightningd: io_break: destroy_plugin
2024-10-30T14:42:37.594Z DEBUG   lightningd: Command returned result after jcon close
2024-10-30T14:42:37.595Z DEBUG   connectd: Shutting down
2024-10-30T14:42:37.597Z DEBUG   gossipd: Shutting down
2024-10-30T14:42:37.598Z DEBUG   hsmd: Shutting down

Is this the intended behavior?

The behavior seems to be different from what was expected.
It should terminate with logs like the ones below.
I added an E2E test to verify such behavior.
https://github.com/ElementsProject/peerswap/pull/318/commits/43b1d7d988b40fa11a52deed690b1284b0cb6a52
clightning-1: 2024-11-10T00:53:24.810Z UNUSUAL lightningd: JSON-RPC shutdown
clightning-1: 2024-11-10T00:53:24.810Z DEBUG   lightningd: io_break: start_json_stream
2024-11-10T00:53:24.810Z DEBUG   lightningd: io_loop_with_timers: main
clightning-1: 2024-11-10T00:53:24.810Z DEBUG   connectd: REPLY WIRE_CONNECTD_START_SHUTDOWN_REPLY with 0 fds
2024-11-10T00:53:24.810Z DEBUG   lightningd: io_break: connectd_start_shutdown_reply
clightning-1: 2024-11-10T00:53:24.810Z DEBUG   03bed3ea4df3506aeacad110dd6c15d9a14e2ea9e9456fb84d07f2f291d31bf8d1-channeld-chan#1: Status closed, but not exited. Killing
clightning-1: 2024-11-10T00:53:24.810Z INFO    03bed3ea4df3506aeacad110dd6c15d9a14e2ea9e9456fb84d07f2f291d31bf8d1-chan#1: Peer transient failure in CHANNELD_NORMAL: channeld: Owning subdaemon channeld died (9)
clightning-1: 2024-11-10T00:53:24.811Z DEBUG   plugin-chanbackup: Killing plugin: exited during normal operation
2024-11-10T00:53:24.811Z DEBUG   plugin-bcli: Killing plugin: exited during normal operation
2024-11-10T00:53:24.812Z DEBUG   plugin-pay: Killing plugin: exited during normal operation
2024-11-10T00:53:24.812Z DEBUG   plugin-autoclean: Killing plugin: exited during normal operation
2024-11-10T00:53:24.812Z DEBUG   plugin-recover: Killing plugin: exited during normal operation
2024-11-10T00:53:24.813Z DEBUG   plugin-spenderp: Killing plugin: exited during normal operation
2024-11-10T00:53:24.813Z DEBUG   plugin-commando: Killing plugin: exited during normal operation
2024-11-10T00:53:24.813Z DEBUG   plugin-txprepare: Killing plugin: exited during normal operation
clightning-1: 2024-11-10T00:53:24.813Z DEBUG   plugin-funder: Killing plugin: exited during normal operation
clightning-1: 2024-11-10T00:53:24.813Z DEBUG   plugin-topology: Killing plugin: exited during normal operation
clightning-1: 2024-11-10T00:53:24.813Z DEBUG   plugin-keysend: Killing plugin: exited during normal operation
clightning-1: 2024-11-10T00:53:24.813Z DEBUG   plugin-offers: Killing plugin: exited during normal operation
clightning-1: 2024-11-10T00:53:24.814Z DEBUG   plugin-bookkeeper: Killing plugin: exited during normal operation
clightning-1: 2024-11-10T00:53:24.814Z DEBUG   plugin-sql: Killing plugin: exited during normal operation
clightning-1: 2024-11-10T00:53:24.814Z DEBUG   plugin-cln-askrene: Killing plugin: exited during normal operation
clightning-1: 2024-11-10T00:53:24.814Z DEBUG   plugin-cln-renepay: Killing plugin: exited during normal operation
clightning-1: 2024-11-10T00:53:24.814Z DEBUG   plugin-recklessrpc: Killing plugin: exited during normal operation
clightning-1: 2024-11-10T00:53:32.199Z DEBUG   03bed3ea4df3506aeacad110dd6c15d9a14e2ea9e9456fb84d07f2f291d31bf8d1-gossipd: seeker: startup peer finished
2024-11-10T00:53:32.199Z DEBUG   03bed3ea4df3506aeacad110dd6c15d9a14e2ea9e9456fb84d07f2f291d31bf8d1-gossipd: seeker: state = PROBING_SCIDS Seeking scids 1 - 112
2024-11-10T00:53:32.199Z DEBUG   03bed3ea4df3506aeacad110dd6c15d9a14e2ea9e9456fb84d07f2f291d31bf8d1-gossipd: sending query_channel_range for blocks 1+112
2024-11-10T00:53:32.199Z DEBUG   03bed3ea4df3506aeacad110dd6c15d9a14e2ea9e9456fb84d07f2f291d31bf8d1-connectd: peer_out WIRE_QUERY_CHANNEL_RANGE
clightning-1: 2024-11-10T00:53:32.199Z DEBUG   03bed3ea4df3506aeacad110dd6c15d9a14e2ea9e9456fb84d07f2f291d31bf8d1-gossipd: reply_channel_range 1+112 (of 1+112) 1 scids
2024-11-10T00:53:32.199Z DEBUG   gossipd: seeker: state = NORMAL No unannounced nodes
clightning-1: 2024-11-10T00:53:33.474Z DEBUG   03bed3ea4df3506aeacad110dd6c15d9a14e2ea9e9456fb84d07f2f291d31bf8d1-connectd: peer_out INVALID 42085
2024-11-10T00:53:33.474Z DEBUG   03bed3ea4df3506aeacad110dd6c15d9a14e2ea9e9456fb84d07f2f291d31bf8d1-connectd: peer_in INVALID 42085
clightning-1: 2024-11-10T00:53:33.476Z DEBUG   plugin-peerswap: Killing plugin: exited during normal operation
2024-11-10T00:53:33.476Z DEBUG   lightningd: io_break: destroy_plugin
clightning-1: 2024-11-10T00:53:33.476Z DEBUG   lightningd: Command returned result after jcon close
clightning-1: 2024-11-10T00:53:33.476Z DEBUG   connectd: Shutting down
clightning-1: 2024-11-10T00:53:33.477Z DEBUG   gossipd: Shutting down
clightning-1: 2024-11-10T00:53:33.477Z DEBUG   hsmd: Shutting down

Hmm peerswap is now exiting at startup thinking deprecated APIs are disabled:
2024-11-13T14:17:20.121Z INFO    plugin-peerswap: WARNING: allow-deprecated-apis=false detected in CLN config. Exiting. More info: https://github.com/ElementsProject/peerswap/issues/232
2024-11-13T14:17:21.122Z INFO    plugin-peerswap: Killing plugin: exited during normal operation

https://github.com/ElementsProject/peerswap/pull/330 updated the nix package and was tested with v24.08.02, but it seems the issue does not reproduce.
There might be a specific sequence when the issue occurs.
Regarding the deprecated APIs issue, I rebased on the master branch as the fix in the following PR might have an impact:
https://github.com/ElementsProject/peerswap/pull/321

There was a case where the shutdown hook was not executed when the standard input with cln remained in glightning.
I have modified it to process messages asynchronously, allowing us to stop listening when a shutdown signal is received.
Although I am not certain that this is the cause of the issue, this is the only problem I can currently think of.
Could you please try again?

With the latest commit, peerswap exits instantly while CLN is shutting down. Tested ACK 6dd09b7

authors: YusukeShimizu grubles

repo: ElementsProject/peerswap


text:
运行llama_7b报错，TypeError: Descriptors cannot not be created directly.

运行llama_7b报错，
TypeError: Descriptors cannot not be created directly.
If this call came from a _pb2.py file, your generated code is out of date and must be regenerated with protoc >= 3.19.0.
If you cannot immediately regenerate your protos, some other possible workarounds are:

Downgrade the protobuf package to 3.20.x or lower.
Set PROTOCOL_BUFFERS_PYTHON_IMPLEMENTATION=python (but this will use pure-Python parsing and will be much slower).

请问要怎么解决

Hi! Have you tried running pip install protobuf==3.20.0 and rerunning? This should fix the error message reported here.

source: gharchive/issue

authors: Yun-Peng-Wang haileyschoelkopf

repo: EleutherAI/lm-evaluation-harness

license: MIT

license_type: permissive

license_source: github-api


text:
Logging Samples

Due to this issue, an example logger has been added to the big-refactor branch.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@farzanehnakhaee70
Great work, a few things that needs improvements on.

We should also log the whole doc instead of only the text fields and processed input
We also want to log the resps and filtered_resps

@lintangsutawika
Great. I have updated and added the new required variables to the logger.

@farzanehnakhaee70 this looks good. Can you share example outputs for each output_type? That is

loglikelihood, - lambada_cloze/lambada_standard_cloze.yaml
loglikelihood_rolling - wikitext/wikitext.yaml
greedy_until - superglue/boolq/promptsource-00.yaml
multiple_choice - superglue/boolq/default.yaml

logging-examples.zip
Sure. Here are the outputs:
One thing which should be mentioned is that for lambada_cloze/lambada_standard_cloze.yaml we should change the metric from accuracy to acc in order that the code support it. Otherwise, it is not existed in the metrics.

source: gharchive/pull-request


text:
Adding resources

Pull Request
Proposed Changes

Adding some resources I found useful
No dependencies
-[Adds to #(7)].

Types of changes made

[ ] Fixed Bug
[ ] Added new Features
[X] Edited Documentations
[ ] Enhanced the working of code
[ ] Additional Changes
Mention any Additional Change here

Additional Info
Provide additional information(if any) you want to convey.
Viability of Code
Describe the tests that you ran to verify the changes made. Mention the tests for easy reproducibility.

Test 1
Test 2

Mention(if any) specific Test Configurations used:

Filmware version:
Hardware:
Toolchain:
SDK:

Screenshots or GIFs (if any)
Attach screenshots of the changes made for easy reference.

Original
Updated

Attach_Original_Screenshot
Attach_Updated_Screenshot

Checklist:

[X] My code follows the Mentioned Guidelines for the project
[X] I have self-reviewed the changes made
[X] I have made the changes easy to understand by adding comments
[X] My changes does not generate new warnings/errors
[X] I have attached relevant screenshots to display the changes made
[X] I have made the required changes to the documentations

@Tlazypanda @deepakDOTexe @tejma17 please merge the pull request. Thanks!

repo: Elevate-Lab/elevate-lab-website


text:
How can I make this version run on USB Drive?

First. I've download portable version and install directly to USB Drive
2. now I'm running Ungoogled Chromium direct on USB Drive, All data/Cache/Extention/History it's saving on usb drive normally, and I've running again on same PC same Drive. All saving data load proprably
3. I've eject my usbdrive and put it on another PC (my laptop), All data (Loging on website/Cache/Cookies/Ectentions) it's not loaded, except History
How can I using as Portable Version?

have you tested this flags Disable encryption
,Disable machine ID

repo: Eloston/ungoogled-chromium


text:
Made Notify me button worked

Previously Notify Me button on index.html was not redirecting to contact me page. Changed the code to make it work.

#72

repo: Elzian-Agro/Agro


text:
-32019 Session limit on this device has been reached

We are trying to get the command stream, we have modified the DataStreamExample.
Everything is fine until the _sessionCreator.Create(_cortexToken, headsetId), where we get the error code -32019.
This is our code:
using Newtonsoft.Json.Linq;
using System;
using System.Collections;
using System.Collections.Generic;
namespace CortexAccess
{
public class DataStreamExample
{
private CortexClient _ctxClient;
private List _streams;
private string _cortexToken;
private string _sessionId;
    private HeadsetFinder _headsetFinder;
    private Authorizer _authorizer;
    private SessionCreator _sessionCreator;

    public List<string> Streams
    {
        get
        {
            return _streams;
        }

        set
        {
            _streams = value;
        }
    }

    public string SessionId
    {
        get
        {
            return _sessionId;
        }
    }

    // Event
    public event EventHandler<ArrayList> OnMotionDataReceived; // motion data
    public event EventHandler<ArrayList> OnEEGDataReceived; // eeg data
    //public event EventHandler<ArrayList> OnDevDataReceived; // contact quality data
    public event EventHandler<ArrayList> OnPerfDataReceived; // performance metric
    public event EventHandler<ArrayList> OnBandPowerDataReceived; // band power
    public event EventHandler<ArrayList> OnCommandDataReceived; // mental commands
    public event EventHandler<Dictionary<string, JArray>> OnSubscribed;

    private List<string> _profileLists;

    // Constructor
    public DataStreamExample(string AppClientId, string AppClientSecret) {

        // Event register
        _ctxClient = CortexClient.Instance;
        //
        _ctxClient.AppClientId = AppClientId;
        _ctxClient.AppClientSecret = AppClientSecret;
        _authorizer = new Authorizer();
        _headsetFinder = new HeadsetFinder();
        _sessionCreator = new SessionCreator();
        _cortexToken = "";
        _sessionId = "";
        _streams = new List<string>();
        _profileLists = new List<string>();
        //
        _ctxClient.OnErrorMsgReceived += MessageErrorRecieved;
        _ctxClient.OnStreamDataReceived += StreamDataReceived;
        _ctxClient.OnSubscribeData += SubscribeDataOK;
        _ctxClient.OnUnSubscribeData += UnSubscribeDataOK;
        _ctxClient.OnQueryProfile += QueryProfileOK;

        _authorizer.OnAuthorized += AuthorizedOK;
        _headsetFinder.OnHeadsetConnected += HeadsetConnectedOK;
        _sessionCreator.OnSessionActivated += SessionActivatedOk;
        _sessionCreator.OnSessionClosed += SessionClosedOK;
    }

    private void QueryProfileOK(object sender, JArray profiles)
    {
        //Console.WriteLine("QueryProfileOK" + profiles);
        foreach (JObject ele in profiles)
        {
            string name = (string)ele["name"];
            _profileLists.Add(name);
        }
        // find headset
        _headsetFinder.FindHeadset();
    }

    public void LoadProfile(string profileName)
    {
        if (_profileLists.Contains(profileName))
            _ctxClient.SetupProfile(_cortexToken, profileName, "load");
        //else
            //Console.WriteLine("The profile can not be loaded. The name " + profileName + " has not existed.");
    }

    private void SessionClosedOK(object sender, string sessionId)
    {
        //Console.WriteLine("The Session " + sessionId + " has closed successfully.");
    }

    private void UnSubscribeDataOK(object sender, MultipleResultEventArgs e)
    {
        foreach (JObject ele in e.SuccessList)
        {
            string streamName = (string)ele["streamName"];
            if (_streams.Contains(streamName))
            {
                _streams.Remove(streamName);
            }
        }
        foreach (JObject ele in e.FailList)
        {
            string streamName = (string)ele["streamName"];
            int code = (int)ele["code"];
            string errorMessage = (string)ele["message"];
            //Console.WriteLine("UnSubscribe stream " + streamName + " unsuccessfully." + " code: " + code + " message: " + errorMessage);
        }
    }

    private void SubscribeDataOK(object sender, MultipleResultEventArgs e)
    {
        foreach (JObject ele in e.FailList)
        {
            string streamName = (string)ele["streamName"];
            int code = (int)ele["code"];
            string errorMessage = (string)ele["message"];
            //Console.WriteLine("Subscribe stream " + streamName + " unsuccessfully." + " code: " + code + " message: " + errorMessage);
            if (_streams.Contains(streamName))
            {
                _streams.Remove(streamName);
            }
        }
        Dictionary<string, JArray> header = new Dictionary<string, JArray>();
        foreach (JObject ele in e.SuccessList)
        {
            string streamName = (string)ele["streamName"];
            JArray cols = (JArray)ele["cols"];
            header.Add(streamName, cols);
        }
        if (header.Count > 0)
        {
            OnSubscribed(this, header);
        }
        else
        {
            //Console.WriteLine("No Subscribe Stream Available");
        }
    }

    private void SessionActivatedOk(object sender, string sessionId)
    {
        // subscribe
        _sessionId = sessionId;
        _ctxClient.Subscribe(_cortexToken, _sessionId, Streams);
    }

    private void HeadsetConnectedOK(object sender, string headsetId)
    {
        ////Console.WriteLine("HeadsetConnectedOK " + headsetId);
        // CreateSession
        _sessionCreator.Create(_cortexToken, headsetId);
    }

    private void AuthorizedOK(object sender, string cortexToken)
    {
        if (!String.IsNullOrEmpty(cortexToken))
        {
            _cortexToken = cortexToken;
            // find headset
            _headsetFinder.FindHeadset();
        }
    }

    private void StreamDataReceived(object sender, StreamDataEventArgs e)
    {
        //Console.WriteLine(e.StreamName + " data received.");
        ArrayList data = e.Data.ToObject<ArrayList>();
        // insert timestamp to datastream
        data.Insert(0, e.Time);
        if (e.StreamName == "eeg")
        {
            OnEEGDataReceived(this, data);
        }
        else if (e.StreamName == "mot")
        {

            OnMotionDataReceived(this, data);
        }
        else if (e.StreamName == "met")
        {
            OnPerfDataReceived(this, data);
        }
        else if (e.StreamName == "pow")
        {
            OnBandPowerDataReceived(this, data);
        }
        else if (e.StreamName == "com")
        {
            OnCommandDataReceived(this, data);
        }
    }
    private void MessageErrorRecieved(object sender, ErrorMsgEventArgs e)
    {
        Console.WriteLine("MessageErrorRecieved :code " + e.Code + " message " + e.MessageError);
    }

    // set Streams
    public void AddStreams(string stream)
    {
        if (!_streams.Contains(stream))
        {
            _streams.Add(stream);
        }
    }
    // start
    public void Start()
    {
        _authorizer.Start();
    }

    // Unsubscribe
    public void UnSubscribe(List<string> streams = null)
    {
        if (streams == null)
        {
            // unsubscribe all data
            _ctxClient.UnSubscribe(_cortexToken, _sessionId, _streams);
        }
        else
            _ctxClient.UnSubscribe(_cortexToken, _sessionId, streams);
    }
    public void CloseSession()
    {
        _sessionCreator.CloseSession();
    }
}

}

@depauantonio59 . could you try with this extension
https://chrome.google.com/webstore/detail/simple-websocket-client/pfdhoblngboilpfeibdedpjgfnlcodoo?hl=en
and call api get license info of Cortex
by cortex token you received.

Hi,
we get the following reply:
{"id":1,"jsonrpc":"2.0","result":{"isOnline":true,"license":{"applications":["com.emotiv.sdk.basic"],"billingFrom":"2019-11-11T01:00:00.000+01:00","billingTo":"2029-11-08T01:00:00.000+01:00","deviceInfo":{"deviceLimit":3,"devicesPerSeat":3,"sessionLimit":{"day":null,"month":null,"year":null}},"expired":false,"extenderLimit":0,"hardLimitTime":"2020-01-19T00:59:59.999+01:00","isCommercial":false,"licenseId":"6d96548c-f5eb-4c6b-bbef-742c187737cb","licenseName":"Basic License","localQuota":0,"maxDebit":null,"scopes":[""],"seatCount":1,"sessionCount":0,"softLimitTime":"2020-01-12T00:59:59.999+01:00","totalDebit":0,"totalRegisteredDevices":1,"validFrom":"2019-11-11T01:00:00.000+01:00","validTo":"2029-11-09T00:59:59.999+01:00"}}}

hi @depauantonio59 , from the response you can see
"totalDebit":0 and "localQuota":0 -> mean you did not debit . So, you don't have local session available to create (localQuota = 0).
to fix it, in the request authorize you should set param "debit"

Hi,
In the Autorizhe() call we are currently passing an empty string as LicenseID, and 5 for debit.

Hi,
In the Autorize() call we are currently passing an empty string as LicenseID, and 5 for debit.

oh, really. I wonder why Cortex return totalDebit = 0.
Can you try to make 2 request authorize and get license info, after that send the result for me via email
cuong@emotiv.com ?

Hi,
I have found out that in your example code, when licenseID was empty it was sending debit=0 in the authorize() call. I fixed it and now we local quota:
{"id":1,"jsonrpc":"2.0","result":{"isOnline":true,"license":{"applications":["com.emotiv.sdk.basic"],"billingFrom":"2019-11-11T01:00:00.000+01:00","billingTo":"2029-11-08T01:00:00.000+01:00","deviceInfo":{"deviceLimit":3,"devicesPerSeat":3,"sessionLimit":{"day":null,"month":null,"year":null}},"expired":false,"extenderLimit":0,"hardLimitTime":"2020-01-19T00:59:59.999+01:00","isCommercial":false,"licenseId":"6d96548c-f5eb-4c6b-bbef-742c187737cb","licenseName":"Basic License","localQuota":5,"maxDebit":null,"scopes":[""],"seatCount":1,"sessionCount":0,"softLimitTime":"2020-01-12T00:59:59.999+01:00","totalDebit":5,"totalRegisteredDevices":1,"validFrom":"2019-11-11T01:00:00.000+01:00","validTo":"2029-11-09T00:59:59.999+01:00"}}}
Thanks for your help!

Fixed in PR https://github.com/Emotiv/cortex-v2-example/pull/68


text:
Feature Request: SOCKS for (DBX) Listeners

Greetings Fellows,
I have a little feature request.
Could we have SOCKS support for the Listeners please?
Basically we just need to add the following before any import of urllib2:
import socks
import socket
SOCKSIP="127.0.0.1"
PORT=XXXXX
socks.setdefaultproxy(socks.PROXY_TYPE_SOCKS5, SOCKSIP , PORT)
socket.socket = socks.socksocket
Add config options to the listener.
And then add PySocks to the install.sh
It works very well with dbx.py.
I tested it with TOR and it correctly connected to dropbox via TOR SocksPort.
(tcpdump -i lo shows empire communicating with the remote agent)
(DNS leaking etc has yet to be monitored, but I think that should be fine if you use a local dns server and block certain stuff. Just in case some other module tries to ignore the socks.socket)
(I'd make a quick pullRequest but I tested with the ObfuscatedEmpire fork)
Many thanks in advance.

This sounds like a great idea man and I'm going to strongly encourage you to do the leg work on the PR for this one. Thanks!

Done, Submitted Pull Request #721.
Works like a charm on the dev branch, via TOR, with and w/o using SOCKS.

authors: IljaSchumacher xorrior

repo: EmpireProject/Empire

license_source: bigquery


text:
Update emulationstation2.po

Partial emulationstation2 translation to catalan

Thank you!

authors: joao-pedro-barbosa shantigilbert

repo: EmuELEC/emuelec-emulationstation


text:
MINOR: Fix the awk command in kafka_run.sh

kafka_run.sh is parsing the hostname using awk to get the statefulset index number out of it. The current command splits the hostname by - and takes the second segment as the ID. Tis works fine when the name is kafka-0 or kafka-1. But doesn't work properly when the name would be my-kafka-1. Barnabas currently doesn't provide any support for changing the statefulset name, but it would be good to fix this anyway in case someone renames it in the YAML files.

lgtm

authors: scholzj tombentley

repo: EnMasseProject/barnabas


text:
texture quality issue

when convert from ply to glb, there are holes in mesh and low quality uv texture produced. Even increase the resolution doesn't help. How to make the texture as good as in the video?

Hi Sekkit,
As I mentioned in the previous post #3, the conversion of GS to mesh is an ongoing research effort, and it is not our intention for LucidFusion to produce textured mesh.
LGM provides a way to convert the GS to mesh (through per-scene optimized NeRF), however, we think there might be other ways to do it (as your goal, good quality of texture mesh).
There is no answer to the question yet, and many other researchers are also working on it. If you are interested, you can check things like CRM, craftsman, NKSR, unqiue3D... etc.
Hope that helps!

ok, get it. Will try it in the future

repo: EnVision-Research/LucidFusion


text:
Time-picker input mask

AC

[ ] Ensure correct format when typing in time inputs
[ ] Should support hours and minutes
[ ] Add showcase and documentation in Storybook

Remaining: 3

authors: dzhavat mknic

repo: Energinet-DataHub/greenforce-frontend


text:
add graphql schema

Description

References

#0000

Codecov Report

Merging #1480 (5c55b72) into main (10c54ca) will increase coverage by 19.60%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##             main    #1480       +/-   ##
===========================================
+ Coverage   31.80%   51.40%   +19.60%
===========================================
  Files          54       69       +15
  Lines         827     1208      +381
  Branches       47        0       -47
===========================================
+ Hits          263      621      +358
- Misses        554      572       +18
- Partials       10       15        +5

Impacted Files
Coverage Δ

...ntrollers/MarketParticipantPermissionController.cs
0.00% <0.00%> (ø)

...taHub.WebApi/Controllers/Wholesale/Dto/BatchDto.cs
0.00% <0.00%> (-100.00%)
:arrow_down:

...trollers/MarketParticipant/Dto/FilteredActorDto.cs
16.66% <0.00%> (-83.34%)
:arrow_down:

...gistration/HealthEndpointRegistrationExtensions.cs
45.45% <0.00%> (-36.37%)
:arrow_down:

...WebApi/RequireNonNullablePropertiesSchemaFilter.cs
80.00% <0.00%> (-8.00%)
:arrow_down:

apps/dh/api-dh/source/DataHub.WebApi/Startup.cs
91.66% <0.00%> (-0.93%)
:arrow_down:

.../DataHub.WebApi.Tests/Integration/EndpointTests.cs
100.00% <0.00%> (ø)

...Tests/ServiceMocks/JwtAuthenticationServiceMock.cs
100.00% <0.00%> (ø)

...ntegration/Controllers/WholesaleControllerTests.cs
97.75% <0.00%> (ø)

...rce/DataHub.WebApi.Tests/Fixtures/WebApiFactory.cs
90.00% <0.00%> (ø)

... and 11 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

authors: Renetnielsen codecov-commenter


text:
fix: update solution name

Description
References

Codecov Report

Merging #491 (62e7c7f) into main (21978a1) will decrease coverage by 27.15%.
Report is 177 commits behind head on main.
The diff coverage is 31.61%.

@@             Coverage Diff             @@
##             main     #491       +/-   ##
===========================================
- Coverage   83.07%   55.92%   -27.15%
===========================================
  Files         456      469       +13
  Lines       10418    10213      -205
===========================================
- Hits         8655     5712     -2943
- Misses       1438     4276     +2838
+ Partials      325      225      -100

Files
Coverage Δ

...ivedMessages/ArchivedMessageGetDocumentListener.cs
0.00% <ø> (ø)

source/Api/Common/HttpHeadersExtensions.cs
0.00% <ø> (ø)

...iddleware/Authentication/ActorForAuthentication.cs
0.00% <ø> (ø)

...ntication/Bearer/BearerAuthenticationMiddleware.cs
0.00% <ø> (ø)

...MarketActors/MarketActorAuthenticatorMiddleware.cs
0.00% <ø> (ø)

...ation/Middleware/Correlation/CorrelationContext.cs
66.66% <ø> (ø)

.../Middleware/Correlation/CorrelationIdMiddleware.cs
0.00% <ø> (ø)

...iguration/Middleware/Correlation/UserProperties.cs
0.00% <ø> (ø)

...figuration/Middleware/FunctionContextExtensions.cs
0.00% <ø> (ø)

...rce/Api/Configuration/ServiceBusMessageMetadata.cs
0.00% <ø> (ø)

... and 149 more

... and 362 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

authors: RasmusGraabaek codecov-commenter

repo: Energinet-DataHub/opengeh-edi


text:
Server crash from flask

Short Description
A short description of circumstances under which the crash happened.
Mod version SurvivalInc-1.3.0
For example: "I jumped into the sea and began to draw water into my flask underwater."
To Reproduce
Steps to reproduce the behavior:
Install the mod on the server
Take a flask in your hand
jump into the sea
Start collecting water
Crash Report
https://pastebin.com/UEm34AEt
Additional Notes
Add any other notes about the problem here.
crash-2021-12-10_21.11.47-server.txt

Sorry for the late response. I know where the problem lies (IBlockProvider.getBiome is marked as client-only, idk why). I will fix it in the next commit.

Извините за поздний ответ. Я знаю, в чем проблема ( IBlockProvider.getBiomeпомечено как «только для клиента», не знаю почему). Я исправлю это в следующем коммите.

There is still an important mistake
Synchronization of water on the server does not work.
If the player died of thirst, then he spawns on the spawn and again begins to die of thirst, his water is replenished only on the client's part.
And it outputs data to the server console
[20:55:27] [Netty Epoll Server IO # 1 / INFO]: Stat sync request received from CAHEK (ff08e98c-ea4c-11eb-8515-0cc47a811d3e); Dispatching reponse: StatSync {86d1b461-5396-11ec-bafa-0cc47a811d3e = {"survivalinc: heat": {value: 74.14267f}, "survivalinc: hydration": {value: 58.459312f}, "survivalinc: wetness": {value : 0.0f}, "survivalinc: sanity": {value: 100.0f, ticksAwake: 6760}}, ff08e98c-ea4c-11eb-8515-0cc47a811d3e = {"survivalinc: heat": {value: 69.97842f}, "survivalinc: hydration ": {value: 2.0043693f}," survivalinc: wetness ": {value: 0.0f}," survivalinc: sanity ": {value: 100.0f, ticksAwake: 13984}}}

Now that I think about it I probably forgot to impelment resetting of the stats when player respawns. But I am not really sure whether I would forgot about such an important thing. It's just a few days until I come home so I will check it then. But thanks for reporting it. To be honest, the water quality system was really hastily implemented and there are already plans for decomissioning the current system and replacing it with a new one which would provide better interactions with tech-related mods.

Fixed in 9cca86f8a52d30deb9427ed61c7c02e30bfefd80


text:
After 1 h flight the frequency jumped up to 14.111 :-(

After one hour flight the hf-oszillator jumped after a short ping on 14.097  up to 14.111 for further transmissions.
I am not ammused about this.

Also see the TX is now unstable.  It looks the calculation of the TIMEPULSE has problems?
The TX works well for many days on the ground.

Appendix 1:
Frequenz jumping maybe have some issue with temperatur? during lifoff the temp went down to reported -3 Celsius.
After half an hour an TX was reported with upper 0 C.

i build a new one on the desk and o wonder, it is always transmitting on 14.111.  So i decreased the 4 Frequency lines in the source code about 3 Hz down. Wow - now the frequency is on 14.097.   Resetet the to the originally frequencies, and its back on 14.111.  In my opinion thats not a temperature problem.  Dont know how to get this fixed.

it seems like maybe a lack of PPS. if its getting serial data from the GPS module, it will continue to transmit on the correct timeslot. But without steady PPS pulses the frequency will vary greatly with temperature of the pico's crystal.

Hi
Loss of PPS maybe a reason, but i tried also with a shorter Cabel (3 cm)
and i watched the same problem.
The system worked with success over a week here on an outdoor vertikal. So
i can not explain whats happens. Maybe the level of timepulse changing on
temperature maybe the pico port sensibility gets lower on low temperatures.
I dont know.
I will not start any more until we find some method to get this fixed.
thanks for your attention
73 Wolf
EngineerGuy314 @.***> schrieb am Do., 9. Mai 2024,
18:45:

it seems like maybe a lack of PPS. if its getting serial data from the GPS
module, it will continue to transmit on the correct timeslot. But without
steady PPS pulses the frequency will vary greatly with temperature of the
pico's crystal.
—
Reply to this email directly, view it on GitHub
https://github.com/EngineerGuy314/pico-WSPRer/issues/10#issuecomment-2103029158,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABKZWUGCHNFFUAMZZV553X3ZBOR3LAVCNFSM6AAAAABHOQX22GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMBTGAZDSMJVHA
.
You are receiving this because you authored the thread.Message ID:
@.***>

please try one more thing. Simon had similar problems that were fixed by removing some Print Statements. Set the verbosity to 0 (which will kill all prints) and see if the problem persists. thanks.

Ok Thanks
will test this, but for results we have to wait now until July (longer
Holidays here ;-)
cu 73
EngineerGuy314 @.***> schrieb am Do., 9. Mai 2024,
19:51:

please try one more thing. Simon had similar problems that were fixed by
removing some Print Statements. Set the verbosity to 0 (which will kill all
prints) and see if the problem persists. thanks.
—
Reply to this email directly, view it on GitHub
https://github.com/EngineerGuy314/pico-WSPRer/issues/10#issuecomment-2103144411,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABKZWUAG2ERILXILFGWSARTZBOZRPAVCNFSM6AAAAABHOQX22GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMBTGE2DINBRGE
.
You are receiving this because you authored the thread.Message ID:
@.***>

I had also problems with GPS during my tests two days ago. It saw about 10  to 12 satelites and after some minutes the number decreased rapidly to 6, 4 and 0 and GPS stopped to respond. When the RP2040 started to transmit my slot, GPS stopped to respond nearly immediately. So I suspect interference from the transmission itself or ripple in the supply voltage.  I plan to add 100nF suppression capacitors between power supply and ground and see if there is an improvement.
Jakub, OK1SE
From: Antennen-Wolfgang @.>
Sent: Thursday, May 9, 2024 6:58 PM
To: EngineerGuy314/pico-WSPRer @.>
Cc: Subscribed @.***>
Subject: Re: [EngineerGuy314/pico-WSPRer] After 1 h flight the frequency jumped up to 14.111 :-( (Issue #10)
Hi
Loss of PPS maybe a reason, but i tried also with a shorter Cabel (3 cm)
and i watched the same problem.
The system worked with success over a week here on an outdoor vertikal. So
i can not explain whats happens. Maybe the level of timepulse changing on
temperature maybe the pico port sensibility gets lower on low temperatures.
I dont know.
I will not start any more until we find some method to get this fixed.
thanks for your attention
73 Wolf
EngineerGuy314 @.***mailto:***@***.***> schrieb am Do., 9. Mai 2024,
18:45:

it seems like maybe a lack of PPS. if its getting serial data from the GPS
module, it will continue to transmit on the correct timeslot. But without
steady PPS pulses the frequency will vary greatly with temperature of the
pico's crystal.
—
Reply to this email directly, view it on GitHub
https://github.com/EngineerGuy314/pico-WSPRer/issues/10#issuecomment-2103029158,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABKZWUGCHNFFUAMZZV553X3ZBOR3LAVCNFSM6AAAAABHOQX22GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMBTGAZDSMJVHA
.
You are receiving this because you authored the thread.Message ID:
@.***mailto:***@***.***>

—
Reply to this email directly, view it on GitHubhttps://github.com/EngineerGuy314/pico-WSPRer/issues/10#issuecomment-2103049481, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ADCVHZH22H322YXQRMWUTPLZBOTKRAVCNFSM6AAAAABHOQX22GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMBTGA2DSNBYGE.
You are receiving this because you are subscribed to this thread.Message ID: @.@.>>

Here are some news about jumping in frequency
First: i am using the today version - sure!
Tested to day over 3 hours.  I am connected with usb and the "screen" cmd on debian.
Parallel i watched the kiwisdr at my location.
First thing:  i saw on 14.112 that the hf-osz. is working in stdby at very low level. TX on board is not transmitting on trace
Every TXing the 14.112 was used. Signal is unstable so no decodings on the kiwisdr.
No chance to get the tx qrg on 14.097
What i then see may be interessting.
I pluged the pico on usb again and did not start the screen communicator.
This thime i see on the sdr no  hf-osz. standby signal.
The hf-osz. signal also not visible on 14.097 nor 14.112 until iam starting the screen programm. This time the 14.112 is aquired and later the tx is sending here.
Other way: if iam not starting screen-prg then later the pico is really tx-ing ong 14.097 - wow. first time its on the right QRG.
Condx:   Verbose was allways on 0. No screen programm was started if its qrg is ok, after one time screen prg was called and closed the QRG still stands on 14.112 if tx-ing.
BTW: there are new problems - maybe i open another issue

i losed many times the config values - after some actions with power on with solar insted of usb power the values got lost and are on default.
after the tx was transmitting - it dont stop after the timeslot - its running all the time and did not stop until poweroff.
Thats what my kiwi recorded
i dont know where the /12 is comming from. I didn not set one. let it on "-"

after 8 hours, i found a math bug in some of the original code. it turns out that compensating for a fast xtal was ok, but on another pico with a xtal that happened to be slower i was seeing an incorrect freq output above 14.1mhz. fix has been implemented and pushed.

some more details: the problem was occurring with boards whose crystal was giving less than exactly 12Mhz.  Some picos are like that, but on others I was able to make a a normally good pico exhibit the jump to 14.1Mhz by heating it up enough to reduce crystal frequency below 12Mhz.
on line 90 of GPStime.c Roman was using iSar64 to do bit shifting. The macro for iSar typecasts the argument as int64_t. But a part of the argument used _u64_pps_period_1M, which is an unsigned int. If that number was greater than eDtUpscale * dt_per_window the overall argument to iSar64 was negative and there would be a problem.
I changed the definition of _u64_pps_period_1M from uint64 to int64 and that seems to have solved the problem. I am not exactly sure why that was needed, or if there was a better way to fix it.

WOW! Great!
Just now I am analysing that part of code which seems to be the core of the pico GPSDO. I would like to clearly document it soon.
Jakub
From: EngineerGuy314 @.>
Sent: Saturday, May 11, 2024 1:30 AM
To: EngineerGuy314/pico-WSPRer @.>
Cc: Šerých Jakub @.>; Comment @.>
Subject: Re: [EngineerGuy314/pico-WSPRer] After 1 h flight the frequency jumped up to 14.111 :-( (Issue #10)
some more details: the problem was occurring with boards whose crystal was giving less than exactly 12Mhz. Some picos are like that, but on others I was able to make a a normally good pico exhibit the jump to 14.1Mhz by heating it up enough to reduce crystal frequency below 12Mhz.
on line 90 of GPStime.c Roman was using iSar64 to do bit shifting. The macro for iSar typecasts the argument as int64_t. But a part of the argument used _u64_pps_period_1M, which is an unsigned int. If that number was greater than eDtUpscale * dt_per_window the overall argument to iSar64 was negative and there would be a problem.
I changed the definition of _u64_pps_period_1M from uint64 to int64 and that seems to have solved the problem. I am not exactly sure why that was needed, or if there was a better way to fix it.
—
Reply to this email directly, view it on GitHubhttps://github.com/EngineerGuy314/pico-WSPRer/issues/10#issuecomment-2105379873, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ADCVHZHTZNJEYEQXGHR5JALZBVJ67AVCNFSM6AAAAABHOQX22GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMBVGM3TSOBXGM.
You are receiving this because you commented.Message ID: @.@.>>

Oh my goodness, you are great!
Thanks for you time to dive into the code so deep.
I may check this version today on this test Board and will report soon.
best 73
Wolf
EngineerGuy314 @.***> schrieb am Sa., 11. Mai 2024,
01:29:

some more details: the problem was occurring with boards whose crystal was
giving less than exactly 12Mhz. Some picos are like that, but on others I
was able to make a a normally good pico exhibit the jump to 14.1Mhz by
heating it up enough to reduce crystal frequency below 12Mhz.
on line 90 of GPStime.c Roman was using iSar64 to do bit shifting. The
macro for iSar typecasts the argument as int64_t. But a part of the
argument used _u64_pps_period_1M, which is an unsigned int. If that number
was greater than eDtUpscale * dt_per_window the overall argument to iSar64
was negative and there would be a problem.
I changed the definition of _u64_pps_period_1M from uint64 to int64 and
that seems to have solved the problem. I am not exactly sure why that was
needed, or if there was a better way to fix it.
—
Reply to this email directly, view it on GitHub
https://github.com/EngineerGuy314/pico-WSPRer/issues/10#issuecomment-2105379873,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABKZWUABNFUS5YRXKFZWM7TZBVJ65AVCNFSM6AAAAABHOQX22GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMBVGM3TSOBXGM
.
You are receiving this because you authored the thread.Message ID:
@.***>

authors: EngineerGuy314 serych whallmann


text:
Use Redirect instead of ModifyArgs for compatibility

This PR fixes incompatibilities with lots of other mods by using @Redirect instead of @ModifyArgs.
See https://github.com/EnnuiL/OkZoomer/issues/28, https://github.com/EnnuiL/OkZoomer/issues/31, https://github.com/EnnuiL/OkZoomer/issues/39 aswell as https://github.com/BackportProjectMC/PerspectiveModRedux/issues/9 (which has only been fixed using a not so great workaround and can be undone after this PR).

And you talk about the solution that the other mod has used as a "not so great workaround". This "not so great workaround" happens to be a safer method

it works for the time being, but they fixed their issue by just cancelling the parent function - which only works if it happens to be that the function you were originally redirecting is the last function call in that parent function
Then they could replace their solution with a @ModifyArgs mixin on the two methods where if their conditions are met, change the X and Y to 0.0 and 0.0, and effectively have exactly the same behavior as their @Redirect. And something that I've just thought of is that perhaps instead of that, a @ModifyVariable could be used, although I'm not so sure about that, I remember having to deal with annoying errors with that particular mixin.
Anyway, the point is: although an @Inject and cancel may not look good, it does work, and it doesn't mean that you should bring in the nuke and break mod compat with @Redirect.

authors: EnnuiL jakobkmar

repo: EnnuiL/LibZoomer


text:
Add check-run HTML URL to JSON output.

Closes #310

@EnricoMi tests are running on https://github.com/danxmoran/publish-unit-test-result-action/pull/1 now, thanks for the pointers!

Thanks for the contribution!

authors: EnricoMi danxmoran


text:
the local option in ensemble config is hardcoded to always look for app under assets folder

  # for embedding definitions locally in your Flutter App
  local:
    # the root directory where all your Apps definitions reside
    path: /Users/khurrammahmood/Documents/projects/ensemble/experiments/firebase/edl-samples/
    # appId represents an App, and is a folder under the root directory
    # Note that each App directory also has to be added manually under pubspec.yaml
    appId: Ensemble kitchen sink
    # appHome is the name of the home screen. This will be the first screen when your App loads
    appHome: Home
    #folder that contains the translated strings for all locales
    i18nPath: ensemble/i18n

does not work because
Error while trying to load an asset: Failed to load asset at "assets/Users/khurrammahmood/Documents/projects/ensemble/experiments/firebase/edl-samples/Ensemble%2520kitchen%2520sink/Home.yaml"

You'd want the assets to be packaged with your app, hence relative path. With absolute path, users may mistaken think the App works (locally), but stop working once deployed.

I want to be able to let users download the ensemble-starter, download samples, configure starter to point to where the samples are and run locally. I don't want to force them to copy over the samples repo into this assets folder and then run it. How do I do that? @vusters ?

repo: EnsembleUI/ensemble


text:
Add onChange to DateRange widget

Ticket: #779

@vinothvino42 this widget was developed for demo and has not been fully implemented (hence the lack of schema). Please got hrough the entire class and make sure all features are working, and also add the schema.

@vinothvino42 this widget was developed for demo and has not been fully implemented (hence the lack of schema). Please got hrough the entire class and make sure all features are working, and also add the schema.

I checked it and it is working fine. Today I added schema for the DateRange widget and suffixIcon property


text:
fix: problems with formatting func-call in chain access

This PR includes:

fix: Args of chained calls are no longer conservatively formatted with structure kept.
fix: If the access chain starts with a func-call, the args of that func-call are not correctly indented.
change: Enter code mode in expressions with parentheses (array, dict, args, ...). This allows for more linebreaks outside codeblocks.

We may need a mode with a name difference from Code to express that lines are continued within (allowing breaking binary expressions into multiple lines), which is stronger than Mode::Code.
This can be further used for binary chains.

We may want something like
#{
  let a = (
    1111111111111
      + 2222222222222
      + 3333333333333 / 2
      + 111111111111
        * 333
        / 222
        * 44444
        / 999
        * 1111
        / 44444
        * 1111
        / 44444
        * 1111
        / 44444
      - 222222222222
      + 333333333333
      - 444444444444
      + 555555555555
  )
}

instead of
#{
  let a = (
    1111111111111
      + 2222222222222
      + 3333333333333 / 2
      + (
        111111111111
          * 333
          / 222
          * 44444
          / 999
          * 1111
          / 44444
          * 1111
          / 44444
          * 1111
          / 44444
      )
      - 222222222222
      + 333333333333
      - 444444444444
      + 555555555555
  )
}

repo: Enter-tainer/typstyle


text:
Two dates has today

Hey, I noticed a bug on today. Follow image:

The code:
$("input.datepicker").datetimepicker({
        format: 'DD/MM/YYYY',
        locale: "pt-br"
})

I'm using version 4.17.42 (the newest has another bug with inline option)

Closing in favour of #2182

authors: William-H-M maikealame

repo: Eonasdan/bootstrap-datetimepicker

license: mit


text:
regarding the 6 mfeat datasets

The mfeat_pixel  dataset  has target values ranging from [0.9], while the other mfeat datasets have target values ranging from [1,10]
These datasets are all part of the same collection (https://archive.ics.uci.edu/ml/datasets/Multiple+Features), so they need to have the same feature values because people might compare feature values between the six datasets. I suggest changing the other 5 sets' values from [1,10] to [0,9] because that is consistent with the primary source's site, as well as your current target annotation in other datasets that I've looked at.

come to think of it, the target values should also be [0-9] because the features are statistics that describe images of the characters 0, 1, 2, ..., 9.

Thank you @greggj2016 for raising this issue. @weixuanfu could we discard this recoding of the target column and use the original one?

I think it is OK to record the target.

Closed by #133.

repo: EpistasisLab/penn-ml-benchmarks


text:
Specifying a custom semantic-release configuration does not support installing arbitrary npm modules

The latent issue is, if somebody specifies a semantic-release config with a plugin not included in this action's package.json, the plugin won't be available when semantic-release is invoked which will lead to an error.

This has been resolved, by checking if the host provides a semantic-release configuration and trusting they also provide a package.json specifying the required dependencies. If the host provides a semantic-release configuration, that is used instead of this action's configuration

license: ISC


text:
how to log python file

Describe the bug
Hi, I have been analyzing some C files, and I have noticed how awesome your project is.
But when I try to analyze python files, I didn't find any documentation :(. I have tried this like if it were C file but obviously didn´t work:
CodeChecker log -b "python3 my_file.py" --output ./my_file.json
What I have understood about the "log" command, is that it catches compiler steps and saves it the json output. In C with gcc I can imagine how it captures compilation steps, but I was curious about how does it works with interpreted languages
CodeChecker version
6.17
To Reproduce
CodeChecker log -b "python3 my_file.py" --output ./my_file.json
But it results in an empty json
Expected behaviour
A complete json
Desktop (please complete the following information)
Ubuntu 20.04.3 LTS

CodeChecker log can be used to catch C/C++ compiler calls (g++, gcc, clang) and it will create a compilation database. CodeChecker analyze will work with this compilation database and it will create analyzer result files (basically plist files) to a given directory (report directory).  These result files can be parsed on the CLI (CodeChecker parse) or can be stored to a running CodeChecker server. This approach will work only if you want to run Clang Tidy or Clang SA analyzers.
For other analyzers we created a simple tool which can be used to convert an analyzer output to CodeChecker specific output. For example if you would like to run a python specific analyzer such as pylint you can do it on the following way: https://github.com/Ericsson/codechecker/blob/master/docs/tools/report-converter.md#pylint

authors: csordasmarton gastonstrizzolo

repo: Ericsson/codechecker


text:
Usage of ‘-analyzer-checker=alpha.security.taint.TaintPropagation:Config’ does not work

Hi, sorry for bothering. I met with a problem that while I was trying to use taint analysis with my own source-sink yaml file, the following command line does not work:
CodeChecker analyze --analyzers clangsa -j16 xxx/compilation.json -e alpha.security.taint.TaintPropagation  --checker-config 'clangsa:alpha.security.taint.TaintPropagation:Config=xxx/test/test_memcpy/config.yaml'     --ctu --output ./reports

And here is my target file:
#include <stdio.h>
#include <string.h>
#include <stdlib.h>

void vulnerableFunction(char* input) {
   char buffer[10];
   strcpy(buffer, input); // Vulnerability: No bounds checking on the input

}
int main() {
  unsigned char inputString[200] = {};
  fgets(inputString, sizeof(inputString), stdin);
  vulnerableFunction(inputString);
  return 0;
}

And my config.yaml is:
Filters:
Propagations:
  - Name: fgets
    DstArgs: [0]

Sinks:
  - Name: strcpy
    Args: [0]

There is supposed to be an untrusted variable bug been detected but it turned out that there is no report :(
I followed the user guide :
CodeChecker analyze \
  -e alpha.security.taint.TaintPropagation \
  --checker-config 'clangsa:alpha.security.taint.TaintPropagation:Config=my-cutom-taint-config.yaml'

I'm not sure if it is because I made any mistake in my usage.
Really sorry for bothering.

Hi @ShangzhiXu,
Unfortunately I'm not aware of the behavior of TaintPropagation checker. But if I use sprintf() instead of strcpy() in the attached source code then this checker emits a report for me. I'm not sure, if not reporting on strcpy() is a false-negative of the checker, or I just simply don't understand how the checker works. Someone from the Clang community could help us, perhaps. But maybe you can continue the investigation of the config file's usage with changing sprintf() to strcpy().
I'm looking forward to hear your experiences about this example.
Thank you!

authors: ShangzhiXu bruntib


text:
[clang-tidy][cfg] Remove an alias from the extreme profile

It seems like that bugprone-narrowing-conversions check is the same as
the cppcoreguidelines-narrowing-conversions check.
Check this:
https://github.com/llvm/llvm-project/blob/c63522e6ba7782c335043893ae7cbd37eca24fe5/clang-tools-extra/clang-tidy/bugprone/BugproneTidyModule.cpp#L136-L137
It seems like both of these checks were included in the extreme
profile, thus each of these reports were duplicated basically.
Hereby I'm proposing to keep only one of them in the profile to
workaround this issue.
According to Compiler Explorer, clang-tidy reports these issues only
once, with the [check,alias,alias...] schema, thus it does the right
thing. However, PR #3238 introduced a logic that splits these reports
into individual reports.
I'm not sure if that is the right way of dealing with check aliases, but
we definitely need something more robust than including/excluding checks
from profiles.

@dkrupp


text:
Check usrsctp finish

Pretty straightforward patches, more explanation in the commit messages.

Thanks. 😄

No problem, have a nice day!

authors: MathieuDuponchelle superdump

repo: EricssonResearch/openwebrtc-gst-plugins


text:
Changing nodeSize

Hi Erik!
Sorry to bother you again. I'm trying to use the nodeSize function following the documentation but its not working, probably i'm doing something wrong.
nodeSize: function(nodes, width, textRenderer){                         return [120,70];                     },
Using this, console prints "Error:  attribute x: Expected length, "NaNpx"."
What i'm doing wrong?
Cheers.

Hi @lipedeitos!
It was a while since I've used it but, from what I remember you need to also set the nodes width and height. Here's a snippet from the default function in Builder.js.
      n.cHeight = height;
      if (n.data.hidden) {
        n.cWidth = 0;
      } else {
        n.cWidth = width;
      }

Then you return the maximum of width and height.
/Erik

Hi Erik!
Could you please provide with an example of nodeSize callback function to set width and height for each or all nodes?

authors: ErikGartner Lightislands lipedeitos

repo: ErikGartner/dTree


text:
Develop the 2017 Solution: TypeScript

Check-List of all the solution that should be coded for the different days of the 2017 edition:

[x] Implement solution for day 1:

[x] Part 1
[x] Part 2

[x] Implement solution for day 2:

[x] Part 1
[x] Part 2

[x] Implement solution for day 3:

[x] Part 1
[x] Part 2

[x] Implement solution for day 4:

[x] Part 1
[x] Part 2

[x] Implement solution for day 5:

[x] Part 1
[x] Part 2

[x] Implement solution for day 6:

[x] Part 1
[x] Part 2

[ ] Implement solution for day 7:

[ ] Part 1
[ ] Part 2

[ ] Implement solution for day 8:

[ ] Part 1
[ ] Part 2

[ ] Implement solution for day 9:

[ ] Part 1
[ ] Part 2

[ ] Implement solution for day 10:

[ ] Part 1
[ ] Part 2

[ ] Implement solution for day 11:

[ ] Part 1
[ ] Part 2

[ ] Implement solution for day 12:

[ ] Part 1
[ ] Part 2

[ ] Implement solution for day 13:

[ ] Part 1
[ ] Part 2

[ ] Implement solution for day 14:

[ ] Part 1
[ ] Part 2

[ ] Implement solution for day 15:

[ ] Part 1
[ ] Part 2

[ ] Implement solution for day 16:

[ ] Part 1
[ ] Part 2

[ ] Implement solution for day 17:

[ ] Part 1
[ ] Part 2

[ ] Implement solution for day 18:

[ ] Part 1
[ ] Part 2

[ ] Implement solution for day 19:

[ ] Part 1
[ ] Part 2

[ ] Implement solution for day 20:

[ ] Part 1
[ ] Part 2

[ ] Implement solution for day 21:

[ ] Part 1
[ ] Part 2

[ ] Implement solution for day 22:

[ ] Part 1
[ ] Part 2

[ ] Implement solution for day 23:

[ ] Part 1
[ ] Part 2

[ ] Implement solution for day 24:

[ ] Part 1
[ ] Part 2

[ ] Implement solution for day 25:

[ ] Part 1
[ ] Part 2

For day 7 the first part is developed on my computer. I still need to make part 2 of these problems, comment it and push it.

repo: Erwan-BR/AdventOfCode


text:
Validate Builder Message Signature

Validates builder message signatures
Add the builder fee signatures

@jparr721 Can I get review again?

@jparr721 Can I get review again?

Looks like the error messages still have the newlines and tab characters, and it looks like we're still explicitly panicking. Can we remove both of those and I can re-remove?

@nyospe Looks fine to me, but I am not deep on these changes. Mind taking a look as well?

repo: EspressoSystems/HotShot


text:
Port to Python 3

There is a need to port ArcREST to Python 3 to support ArcGIS Pro users.
I'm looking for porters to help us out!  Anyone interested respond of this thread.
Andrew

First question; are you willing to use six, a compatibility library? It should remove the need for most of compat.py

updated the web functions, but waiting for the new version of the security handlers.

post, get, download, and multipart post done.

authors: Mause achapkowski

repo: Esri/ArcREST


text:
Cmake "ArcGIS Runtime 100.8 Qt Quick app" template runtime problem

On windows: when selecting "ArcGIS Runtime 100.8 Qt Quick app" from the Qt creator wizard and selecting Cmake as buildssystem, where I set the following Cmake values:

ArcGISRuntime_EsriCommonQt_IMPLIB = C:\ArcGIS\Qt100.8\sdk\windows\x64\lib\EsriCommonQtd.lib
ArcGISRuntime_EsriCommonQt_LIB = C:\ArcGIS\Qt100.8\sdk\windows\x64\bin\EsriCommonQtd.dll
ArcGISRuntime_runtimecore_LIB = C:\ArcGIS\Qt100.8\sdk\windows\x64\bin\runtimecore.dll
ArcGISRuntime_INSTALL_DIR = C:/ArcGIS/Qt100.8
QML_IMPORT_PATH = C:/ArcGIS/Qt100.8/sdk/windows/x64/qml

I keep getting the following error during runtime debugging:

QQmlApplicationEngine failed to load component
qrc:/qml/main.qml:16 plugin cannot be loaded for module "Esri.ArcGISRuntime": Cannot load library C:\ArcGIS\Qt100.8\sdk\windows\x64\qml\Esri\ArcGISRuntime\ArcGISRuntimePlugind.dll: The specified procedure could not be found.

How can I fix this? Would it be possible to fix this in the "ArcGIS Runtime 100.8 Qt Quick app" template?

@jensdenbraber can you please post this question on our GeoNet forum instead? We like to keep this repo's issues to be specific to our toolkit, whereas the issue you mention is with the Runtime API itself. Thank you

alright, I posted it here: https://community.esri.com/message/928916

authors: jensdenbraber ldanzinger

repo: Esri/arcgis-runtime-toolkit-qt


text:
Issue with Export to CSV

Hi theres,
I am very new in javascript. So I downloaded the samples to start practicing. I was able to make some of them work, However, the export to CSV sample doesn't work for me. I select a couple points as shown in the attached file and when I click into ExportCSV nothing happen. I already made the label selectable so I was wondering what I am doing wrong.
Thanks,

Hi @luisgalimberti,
In order to solve this issue please open the file:
esri/ dashboard-samples / exportToCsv / exportToCSVFeatureAction.html
Then go to line number 31 you will see the following code statement.
var features = eventProperties.features.features;
Please change the line number 31 to:
var features = eventProperties.featureSet.features;
I have tested it on two different services and the code works perfectly fine.
If you any further question I will be more than happy to help.

authors: bharanigurminder luisgalimberti

repo: Esri/dashboard-samples


text:
Set agent http header to specific value

Some sites are blocking requests from http clients with the generic agent header value 'apache' or such. To make requests from Geoportal Server more recognizable, we should set the header to an identified value. while no guarantee on not being blocked or uniqueness or such, it gives some recognizable source of the requests.
this plays particularly for harvesting and federated search.

Implemented in 1.2.7

authors: mhogeweg pandzel

repo: Esri/geoportal-server


text:
Improvements to app documentation

This PR:

renames docs/index.md to docs/README.md
adds table of contents to (2) README files. The TOC was generated using MDTOC.
links to docs/README.md from root README.md
corrects minor structure and formatting changes in root README.md (85b2d06)
describes patch changes in RELEASE.md
increments app version patch number

@nCastle1 I'm less familiar with versioning in this project, so let me know if I missed any files in f76a7a5 where I should have also incremented the app version.

@esreli I think your suggestion to float the ArcGIS Indoors message to the top was a good one. I also made that other change you noticed - good catch (all these RELEASE.md updates have me mixing formats). Let me know if things now look good from your perspective.

repo: Esri/indoor-routing-xamarin


text:
Accessor interface not updated with new handle methods

Accessor addHandles, etc. didn't get added in 4.25 @arcgis/core interface.d.ts or here.

@COV-GIS we missed the window to add these to 4.25. However, you can verify that addHandles(), removeHandles() and hasHandles() are now available via @arcgis/core@next and arcgis-js-api@next. Thanks again, I'll close this out.

authors: COV-GIS andygup

repo: Esri/jsapi-resources


text:
sec43: update expat to 2 6 3

Issue: https://devtopia.esri.com/runtime/SoftwareSecurity/issues/43

https://github.com/libexpat/libexpat/issues/887

This PR adds null checks to address security concerns in the current version of libexpat (2.6.2) used in Runtimecore 200.6.0 by updating to libexpat 2.6.3.
(Following instructions in https://devtopia.esri.com/runtime/milano/blob/main/References/upgrading_3rd_party/libexpat.md)

[x] rich0003/sec43_update_libexpat_to_2_6_3
[x] library build: https://runtime-rtc.esri.com/view/vTest/job/vtest/job/3rdparty-interface/1136/downstreambuildview/
[x] rtc vtest: https://runtime-rtc.esri.com/view/vTest/job/vtest/job/runtimecore-interface/26539/downstreambuildview/

test failures look unrelated

@rshepherd549 you forgot to update the conanfile_rtc.py and update the package version number

repo: Esri/libexpat


text:
Add Country/CountryCode to Text Attributes Tab

Country/CountryCode isn't a 2525 label attribute (although that would be useful), but it is probably an important attribute we should let the end-user set on that tab.

Can we sort these alphabetically by name (versus code)? I'm having a really hard time finding countries:

I think so?  Another thing I could look into.

Verified in #69 (with sorted names):

authors: csmoore tlauver

repo: Esri/military-symbol-editor-addin-wpf


text:
PN 4.x: Custom notification label changes to default label when editing existing notification and selection method changes

Custom notification label changes to default label when editing existing notification and selection method changes.
To repro:

Click Add to start a notification list
Use search box to search Burbank, select the first suggestion and enter 5000 as buffer distance
Enter a custom label and click Done.
from the My Lists panel, click on the edit button of the recently created list. it will take you the selection status.
Now change the selection mode to Sketch and draw a rectangle, the map updates with new aoi, buffer distance and new selection.
Notice that the custom label is still there, click done and notice the custom label changed to default label for search.

@aparveen this should be resolved as well in one of the recent PRs

Verified

authors: aparveen jmhauck

repo: Esri/solutions-components


text:
Adding Moonbeam network support.

Adds support for the recently launched EVM-compatible Polkadot parachain, Moonbeam. The sister network to Moonriver, which is already supported by UseDapp.

@marekkirejczyk would you mind taking a look at this when you get a chance? Thank you 😁

@m00nbeans Looks good! Would you fix linter and we can merge.

@tt-marek @jodator Made the recommended change and fixed the linter - also verified the multicall contract here: https://blockscout.moonbeam.network/address/0x47152C4dCE75C77Bc9E52F5AAa2a20117971C365/contracts

repo: EthWorks/useDApp


text:
Add binary to communicate with GUI

Binary should implement basic functionalities of the cameradar binary and should be able to communicate with the electron app via JSON RPC over WebSocket or HTTP.

This issue was moved to EtixLabs/cameradar-app#5

repo: EtixLabs/cameradar


text:
Fix temporary Travis dirty patch

Here is the full story about this quick&dirty fix that I used to get Travis to test Cameradar.
First, I use cmake3.5.1 on my system and it works flawlessly. Travis uses the 2.8 by default but I managed to find a PPA giving me the 3.2.3 version. However, even though the 3.5 and the 3.2 do not have relevant differences concerning the install method, it seems that on my system CPack manages to find the external shared libraries after their installation, while Travis does not.
I really tried lots of different manipulations, I've read all the documentation concerning file and install in CMake, and I still have no clue to why they're not found. When looking for them in the system, they are properly generated and in the right place, but they are simply not added to the tarball at the end.
It results in Docker failing to create the image.
To fix this temporarily, I manually unzip the tarball, copy the shared libraries using a global expression, and zip the tarball again with the added libs. It does the trick, but the paths to the libraries is written directly in the .travis.yml file, which is disgusting.
I will keep looking for the reason of this problem later!
If you have an idea of where it could come from, you're free to look at the logs of the 30 first builds of Cameradar on Travis, here : https://travis-ci.org/EtixLabs/cameradar/builds and to answer to this issue.

It has been made cleaner in commit d98d78cd73349c6dfe1d3728e5831a40d9da37aa and should now work even if we add new dependencies or change their paths, but it still implies manually updating the package, which I don't like.

The current state of the Travis build is fine enough, I will not loose more time trying to change it to save 80 miliseconds of build time (on Travis only).


text:
🛑 Diagnostico Zarate is down

In e18ef3d, Diagnostico Zarate (http://www.diagnosticozarate.com.ar) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Diagnostico Zarate is back up in 606e9d4.

repo: Etixen/upptime


text:
🛑 Lisandro Bril is down

In 3993fde, Lisandro Bril (https://www.lisandrobril.com) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Lisandro Bril is back up in eb1ebac.


text:
Problema na responsividade

[ ]

Peguei e irei dar uma solução obrigado @Creuma-Kuzola

De nada, @EufranioDiogo 😊

Desculpa a demora na response mas está feita a correcção e mais uma vez obrigado pelo aviso. @Creuma-Kuzola

authors: Creuma-Kuzola EufranioDiogo


text:
blank screen when opening new tab after a delay

Version: 1.0.0-alpha.55
Platform: win32 10.0.16299
Hi, first, thanks for your work! We really need a decent terminal emulator especially on windoze. Love terminus so far!
The issue I am encountering has started happening in the last month or so. What happens is that I launch terminus and work for a while (1-2min) in the one tab. Then, when I try to open a new tab I get a blank screen. No matter how much I toggle back and forth, nothing will appear...

If I open the dev tools, I see the following errors:

Hmm, removing the "clickable link" plugin got rid of the first error above, but not the second...

I wonder if the winpty issue is related to this: https://github.com/rprichard/winpty/issues/142

@MagicDuck Do you have any third-party antivirus software running, and if so, can you try (temporarily) disabling it or adding the winpty.dll / winpty-agent.exe binaries as exceptions, for testing purposes?

@rprichard yeah, it looks like some mcaffee rule is interfering with it :(. Funny enough, in the log, the action says "would block" but according to it, it doesn't actually block it. May still be doing something weird though....
Unfortunately I am on a corporate network and don't have permission to disable that stuff. I'll follow up with IT on my side.
One thing I am confused about is why it works immediately after starting up terminus. I can open up as many tabs as I like...
Thanks for trying to help!

Just wanted to given an update. IT updated some stuff on my machine and the problem seems to have gone away. I still see the rule saying "would block" in the log, but it now works, so it seems like it was never truly blocking it but maybe something else was screwing things up???...
I didn't get to try @rprichard 's suggestion but I'll keep that in the back pocket in case the problem pops up again.

Version: 1.0.73
Platform: linux 4.15.0-46-generic
Plugins: none

authors: MagicDuck Rodce rprichard

repo: Eugeny/terminus


text:
Config file option for shell.wsl

I am trying to update manually the config file adding an hotkey for shell.wsl but this doesn't work:
hotkeys:
[...]
  shell.wsl:
    - Ctrl-n

any idea why?

This:
  shell:
    wsl:
      - Ctrl-n

did the trick.


text:
match  results

By cloning your project, you finally match two images, but there is this error in the middle

Hello.
From the image above, it seems to be a problem with the Nvidia cuda compiler. :cry:
Please let me know the OS, Cuda Version, GPU Name, pytorch, and tensorflow version, or write a reproducible code block and I think I can help you!

Hello. From the image above, it seems to be a problem with the Nvidia cuda compiler. 😢
Please let me know the OS, Cuda Version, GPU Name, pytorch, and tensorflow version, or write a reproducible code block and I think I can help you!

This is my conda list, which is installed by following the steps in readme：

Hello, I'm sorry for the late response.
It seems to be a mismatch issue between the Nvidia driver and Cuda.
Make sure your NVIDIA driver is up to date and compatible with the CUDA version!


text:
Key bindings

Should use the KeyMap Bubble for key bindings so they can be more easily customized/visible to users.

Closed by #12

repo: Evertras/bubble-table


text:
douyin 个人页链接失效

发生错误的平台？
如：抖音
发生错误的端点？
如：API-V2
提交的输入值？
如：个人页链接
是否有再次尝试？
如：是，2023-2-7开始失效
你有查看本项目的自述文件或接口文档吗？
如：有
现在V1个人页接口（https://www.iesdouyin.com/aweme/v1/web/aweme/post/）失效了，有其他方法获取么？

hope this can be fix soon. i'm having same issue. Thanks for your help

hope this can be fix soon. i'm having same issue. Thanks for your help

I hope too~

Will be fix in few days.

已经修复了

已经修复了

需要重新安装吗？貌似接口文档打不开了

Docs：
api.tikhub.io

已经修复了

这个接口还是不能访问，是我的IP被抖音拉黑了吗？
www.iesdouyin.com/aweme/v1/web/aweme/post/?sec_user_id=

请大家用api.tikhub.io的接口，目前还是免费的。


text:
Typo: lower vs upper case

This didn't affect me with Vim 9.0 patch 1-1413 so I didn't notice it, but it did affect another user now.

@fortenforge does the CLA bot need to trigger?

I already did the process in my previous PR; I assume it's good for the duration of our relationship?

That's right, I just assumed our bot would confirm the CLA status is good.

I think it did trigger

authors: fortenforge pqn vphantom


text:
Code blocks w/o language raise a warning

I keep getting warnings when building the docs, they look like this:
Pygments lexer name '' is not known

I'm pretty sure this is because of
```
some raw text
```

blocks with no language specified. Should we default code blocks w/o a language to a default "raw" language with Pygments, so a warning isn't raised?

Agree, should have a dig in to the Sphinx code to see where/how they do this normally

Could it just be a little check here:
https://github.com/ExecutableBookProject/myst_parser/blob/4f5df007831cb6bff045e844b63c1ed0b1976f9d/myst_parser/block_tokens.py#L266
And
language = 'some default language' if (len(open_info[2]) == 0) else open_info[2]
    self.language = language

?
Also, here's a PR that seems to alter the default behavior in Sphinx's code-block directive:
https://github.com/sphinx-doc/sphinx/pull/6015/files#diff-9e49ca3710206668e9b66660dd700875R474

authors: choldgraf chrisjsewell


text:
Website link to download ExoCTK data yields Internal Server Error

Clicking "ExoCTK Data Downlaod" (note the typo) at the top of the ExoCTK website yields:

Internal Server Error - The server encountered an internal error and was unable to complete your request. Either the server is overloaded or there is an error in the application.

Perhaps related, selecting "NIRISS.GR700XD.txt" in the "Choose Bandpass" menu on the "Limb Darkening Calculator" page yields the same error.

I went to do some digging.
It looks like at some point the function I wrote to returned the zipped data package was replace with just return.
@mfixstsci You can model the function after other data download functions (that should now be removed, now that I think about it) like fortney, etc.

This is closed with #266

authors: JeffValenti julesfowler

repo: ExoCTK/exoctk


text:
Phase constraint hotfix + ready for development updates

Hi folks,
Here comes a (hot) fix to a bug found by Nikolay Nikolov, in which the phase-constraint wouldn't work if eccentricity is not set manually to a number (or when not found by the target resolver). The problem was very simple: when the parameter is not found, it is populated by None by default in the web app forms. In theory we had solved this over a year ago, but apparently in the code I was double setting omega (and not eccentricity) as np.nan (which the web app form likes more than None values). I have now fixed that.
In addition, I took the liberty of updating all the info in the setup.py, CHANGELOG.md and the web-app to match the next version release with this bug fixed (and Matthew's sweep of PEP8 on the code). I also took the liberty of updating the Readme.rst to match the DOI @bourque set up for us with the full list of co-authors to date of the package.
This should be a relatively straightforward merge to develop!
N.

Hello @nespinoza, Thank you for submitting the Pull Request !

In the file exoctk/exoctk_app/app_exoctk.py:

Line 667:21: W605 invalid escape sequence '('
Line 667:25: W605 invalid escape sequence ')'
Line 667:57: W605 invalid escape sequence '\c'
Line 667:74: W605 invalid escape sequence '\e'
Line 673:46: W605 invalid escape sequence '('
Line 673:48: W605 invalid escape sequence '\l'
Line 673:56: W605 invalid escape sequence '\m'
Line 673:66: W605 invalid escape sequence '\h'
Line 673:79: W605 invalid escape sequence '\m'
Line 673:85: W605 invalid escape sequence ')'
Line 674:46: W605 invalid escape sequence '('
Line 674:48: W605 invalid escape sequence '\l'
Line 674:56: W605 invalid escape sequence '\m'
Line 674:66: W605 invalid escape sequence '\h'
Line 674:79: W605 invalid escape sequence '\m'
Line 674:85: W605 invalid escape sequence ')'
Line 675:46: W605 invalid escape sequence '('
Line 675:48: W605 invalid escape sequence '\l'
Line 675:56: W605 invalid escape sequence '\m'
Line 675:66: W605 invalid escape sequence '\h'
Line 675:79: W605 invalid escape sequence '\m'
Line 675:85: W605 invalid escape sequence ')'
Line 681:58: W605 invalid escape sequence '('
Line 681:62: W605 invalid escape sequence '\m'
Line 681:69: W605 invalid escape sequence '\m'
Line 681:75: W605 invalid escape sequence ')'

If you have not done so, please consult PEP8 and PEP257


text:
Log in - Big blank area between login form and the footer part.

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

Launch the app
Put your email address
Tap Continue

Expected Result:
NO big blank area between login form and the footer part.
Actual Result:
Big blank area between login form and the footer part.
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

Version Number: 1.2.82.3
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
View all open jobs on GitHub

Triggered auto assignment to @lschurr (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Bug0 Triage Checklist (Main S/O)

[ ] This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
[ ] This bug is not a duplicate report (check E/App issues and #expensify-bugs)

If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead

[ ] This bug is reproducible using the reproduction steps in the OP. S/O

If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
If the reproduction steps aren't clear and you determine the correct steps, please update the OP.

[ ] This issue is filled out as thoroughly and clearly as possible

Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.

[ ] I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

Hm, I don't see this happening in Chrome or Safari:

I guess there's a decent amount of space on the iOS app. I'm not sure if this is a bug or intended though.
Adding eng for more eyes.

Triggered auto assignment to @dangrous (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

I'm not really seeing this either... but it's not helped by the fact that GH isn't letting me view the original attachment so I can't confirm/deny the initial report... I'm sure it's my comp but @kbecciv is it possible to try uploading it again?
If it's what I'm seeing, I think it's all as expected - the footer is just under the "fold" so it only shows up when you scroll intentionally.

@dangrous Uploaded again, please let me know if you can check the attachment

Ah, yep - that one came through! I think this is expected (maybe cc @shawnborton if you have a second to look?) so we can probably close. What do you think @lschurr

I agree - let's get @shawnborton's opinion just in case.

This is expected, so we can close! We need the terms to stay visible when logging in.

authors: MelvinBot dangrous kbecciv lschurr shawnborton

repo: Expensify/App


text:
[HOLD for payment 2023-07-14] [$1000] Original message is displayed for few seconds after adding emoji reaction on edited message

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

Open the app and login with user A
Open the app in another device and login with user B
From user B, send message to user A
From user A, open user B report, hover on latest sent message and click on Add reaction
From user B, edit the message
Observe in user A, the user B message is displayed edited, from the current open emoji picker for reaction, click on any emoji to add reaction
Observe that after adding the reaction, app displays older (message before edit) for few seconds

Expected Result:
App should not display older message i.e. message before edit on adding reaction to edited message
Actual Result:
App displays older message i.e. message before edit on adding reaction to edited message
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[x] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[x] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: 1.3.33-3
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/93399543/9db1ed99-c6e8-445e-bfc8-93ad2fcde9c8
https://github.com/Expensify/App/assets/93399543/bc2d776e-8a2a-4066-9852-c7e949267100
Expensify/Expensify Issue URL:
Issue reported by: @dhanashree-sawant
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1687870862782029
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~015a60dfce3c07cce2
Upwork Job ID: 1674267414000873472
Last Price Increase: 2023-06-29

Proposal
Please re-state the problem that we are trying to solve in this issue.

Problem is user is seeing old message for few seconds when someone edits the message, before the user add's emoji to the message.

What is the root cause of that problem?

The reportAction given to Report.toggleEmojiReaction function is not updated with the latest message.

What changes do you think we should make in order to solve the problem?

We can access the latest message using reportID and reportActionID and pass it to a function ReportActionsUtils.getReportAction(reportID, reportActionID) (which i had to create) and now use this reportAction for further code.

 Code for `toggleEmojiReaction`
function toggleEmojiReaction(reportID, reportAction, emoji, paramSkinTone = preferredSkinTone) {
    const latestReportAction = ReportActionsUtils.getReportAction(reportID, reportAction);
    const message = latestReportAction.message[0];
    const reactionObject = message.reactions && _.find(message.reactions, (reaction) => reaction.emoji === emoji.name);
    const skinTone = emoji.types === undefined ? null : paramSkinTone; // only use skin tone if emoji supports it
    if (reactionObject) {
        if (hasAccountIDReacted(currentUserAccountID, reactionObject.users, skinTone)) {
            return removeEmojiReaction(reportID, latestReportAction, emoji, skinTone);
        }
    }
    return addEmojiReaction(reportID, latestReportAction, emoji, skinTone);
}

What alternative solutions did you explore? (Optional)

N/A

Proposal
Please re-state the problem that we are trying to solve in this issue.
What is the root cause of that problem?
When user opens the emoji picker from the reaction bar, openEmojiPicker is called
https://github.com/Expensify/App/blob/d1a743c3d6ed9ff3767e6da93daf9a604c45a781/src/components/Reactions/MiniQuickEmojiReactions.js#L59-L71
The value of props.onEmojiSelected is defined when openEmojiPicker is called. So reportAction value of the onEmojiSelected function when emoji is selected would have the value of when user opens the emoji picker.
https://github.com/Expensify/App/blob/53e4154143052649ed7b2b8df302cd1744f31f67/src/pages/home/report/ContextMenu/ContextMenuActions.js#L60-L63
This is the root cause
What changes do you think we should make in order to solve the problem?
We can get latest reportAction in toggleEmojiReaction function
https://github.com/Expensify/App/blob/53e4154143052649ed7b2b8df302cd1744f31f67/src/libs/actions/Report.js#L1641
    const action = _.get(allReportActions, [reportID, reportAction.reportActionID], reportAction);

The final function would look like
function toggleEmojiReaction(reportID, reportAction, emoji, paramSkinTone = preferredSkinTone) {
    const action = _.get(allReportActions, [reportID, reportAction.reportActionID], reportAction);
    const message = action.message[0];
    const reactionObject = message.reactions && _.find(message.reactions, (reaction) => reaction.emoji === emoji.name);
    const skinTone = emoji.types === undefined ? null : paramSkinTone; // only use skin tone if emoji supports it
    if (reactionObject) {
        if (hasAccountIDReacted(currentUserAccountID, reactionObject.users, skinTone)) {
            return removeEmojiReaction(reportID, action, emoji, skinTone);
        }
    }
    return addEmojiReaction(reportID, action, emoji, skinTone);
}

This works as expected.

Result
https://github.com/Expensify/App/assets/126839717/2701b880-71c2-4c7a-a93e-2709e39a5dbf

What alternative solutions did you explore? (Optional)

Comment : https://github.com/Expensify/App/issues/21826#issuecomment-1612093829
Check below video for fix if necessary.

 Fixed Video
https://github.com/Expensify/App/assets/78416198/1b524557-d81a-4d08-923f-35e1db961db8

Did some Android issues for Sophie, so doing an issue swap as I'm a bit swamped today and working 50%.

Able to reproduce!

@jeet-dhandha i agree with the root cause and the solution.

Sounds good to me too thanks!

@neil-marcellini @rushatgabhane - Will create a PR and send here.

@dhanashree - do you mind doing this please?

The BZ member will need to manually hire dhanashree for this role Reporter. Please store your Upwork details and apply to our Upwork job so this process is automatic in the future!

Hi @sophiepintoraetz, sorry I didn't get it, should I apply to the job?

Melvin bot has marked wrong profile, my tag is @dhanashree-sawant

PR: https://github.com/Expensify/App/pull/21933.
Thanks 🙏 .

Regression: https://github.com/Expensify/App/issues/22235

@rushatgabhane Any updates on this one ?

I think @aimane-chnaif is working on the review for regression https://github.com/Expensify/App/pull/22270

Okay so @jeet-dhandha - can you confirm whether your PR introduced a regression? If so, it is correct that is a 50% deduction for you, @rushatgabhane? (So 1500/2 = $750)
Lastly, what is needed to close out this issue?

@sophiepintoraetz There’s a pr which needs to be merged before mine so waiting for that.

Okay but to be clear, your PR did not introduce a regression?

It introduced on DEV env, basically someone was testing on main branch and had a issue in reacting with emoji in a thread chat’s first message. So i fixed it before it can go to Stagging. But my PR was not merged due to this https://github.com/Expensify/App/pull/17996 PR.

So you can somewhat count it as a regression on DEV end.

Any idea on when can we merge that PR ?

Okay so we actually can't release payment until the 7 day window has passed. I think if a regression is introduced in production, that would have the penalty applied...so you're lucky! And Rushat will be best placed to say when we can merge.

Hi @sophiepintoraetz, I have accepted the offer, you have also sent invite for that job so not accepting that as offer already accepted.

Waiting for @stitesExpensify to complete the requested changes on this PR : https://github.com/Expensify/App/pull/17996 and then i will have to make changes accordingly for my PR and then we will be able to complete this. @stitesExpensify if you need any help completing it quicker do tell me.

Hi @sophiepintoraetz, I just got another offer for this issue from @trjExpensify and I understood that it was already paid after accepting it. Not sure what to do about it, kindly suggest.

Most probably offer was for #20423 as @trjExpensify sent me offer with this issue title and had mentioned that offer was sent on that issue.

Yeah, I just fudged the contract title on #20243. My bad! Paid that one out anyhow!

Not overdue

@aimane-chnaif should i take a pull frommain branch on. My current branch or should i create a new branch and make changes there?

Thanks will do that.

@jeet-dhandha @aimane-chnaif @rushatgabhane - can we confirm the PR for this issue has merged with no regressions in the last 7 days? I'm not sure why we're talking about creating/editing branches if the PR has merged?

@sophiepintoraetz i think they're talking about a different issue.
But the bottom line is this -
@jeet-dhandha's PR caused a regression.
So no timeline bonus is applicable
@jeet-dhandha - $1000 (or $500 not sure)
@rushatgabhane - $500

Got it - thanks. @anmurali or @JmillsExpensify will pay you $500 in NewDot once you've completed the checklist here!

Payment issue to Jeet and contract ended - closing.

@sophiepintoraetz wondering does the payment gets 1/3rd when received ?

@jeet-dhandha - see the comment from the c+ here

Reviewed details for @rushatgabhane. This is accurate and approved for payment in NewDot.

authors: JmillsExpensify dhanashree-sawant jeet-dhandha jliexpensify kbecciv neil-marcellini rushatgabhane s-alves10 sophiepintoraetz trjExpensify


text:
Task - The cursor isn’t appeared at the end of the text input on title

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Issue found when executing PR https://github.com/Expensify/App/pull/22586
Action Performed:

FAB > Assign Task
Enter a large amount of text into the task title This is a very very long task title that should occupy multiple lines, at the very least., verify that it can occupies multiple lines
Finish creating the task with any other values for the other fields
In the Task View, click the title

Expected Result:
Verify that the cursor is at the end of the text input
Actual Result:
The cursor isn’t appeared at the end of the text input
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[x] iOS / Safari
[ ] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: 1.3.42.5
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/78819774/8b8c62ca-ef75-4a0e-b287-b629c0daa66d
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

This bug was already previously reported, closing it out


text:
[$500] Android-IOU-Distance IOU amount is auto-filled and displayed in manual request money page

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

Launch app
Tap fab
Tap request money
Tap distance
Tap Start and select an address
Tap Finish and select an address
Tap next
Select a workspace
Note the Request money amount
Navigate back to Request money page
Tap Manual

Expected Result:
The Distance IOU amount should not be displayed in manual request money page.
Actual Result:
The Distance IOU amount is auto-filled and displayed in manual request money page.
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android / native
[x] Android / Chrome
[ ] iOS / native
[x] iOS / Safari
[ ] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: 1.3.65-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/115492554/b59d3cb8-065b-4c2d-aa1b-19d00909db20
Expensify/Expensify Issue URL:
Issue reported by: Applause-Internal Team
Slack conversation: @
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01baf90b8cc8571594
Upwork Job ID: 1702484361858043904
Last Price Increase: 2023-09-15

Proposal
Please re-state the problem that we are trying to solve in this issue.
IOU amount is autofilled and displayed in manual request page when editing Distance request.
What is the root cause of that problem?
The NewRequestAmountPage sets the default value to iou.amount which retrieves the saved amount from Onyx.
What changes do you think we should make in order to solve the problem?
Do not set the iou.amount value if the request page is not in focus.
What alternative solutions did you explore? (Optional)
None.

Proposal
Please re-state the problem that we are trying to solve in this issue.
When we go to the manual money request tab after starting a distance request, the amount from the distance request remains.
What is the root cause of that problem?
We already reset the data when the tab changes:
https://github.com/Expensify/App/blob/f67bf9f88c08fe2cebe16202d1244299a9640ea3/src/pages/iou/MoneyRequestSelectorPage.js#L64-L67
The problem is that when the manual data tab renders, the new amount value has not yet been reset in Onyx. When it is reset, we do not change the amount since there is a condition returning early if !amount:
https://github.com/Expensify/App/blob/f67bf9f88c08fe2cebe16202d1244299a9640ea3/src/pages/iou/steps/MoneyRequestAmountForm.js#L103-L105
What changes do you think we should make in order to solve the problem?

I suggest we update the aforementioned condition so that we still set the amount if it is 0:
    if (!currency || (!amount && amount !== 0)) {
        return;
    }

What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

Demo of my proposed solution:
https://github.com/Expensify/App/assets/138504087/9b1f465e-6792-4291-906b-0431e73e1202

Also as per this comment we want to clear the data when we switch between request types: https://github.com/Expensify/App/issues/26579#issuecomment-1703948897

We still want to reset the money request information because we are sharing the data for a draft money request. If we don't clear the data when a different tab/request type is selected, draft data from the previous type might be included in the new money request.

I've run out of time today and will test soon.

Still on my testing list

@cubuspl42 - when you get a chance, can you please review if the proposals will address this issue? Thanks!

@izarutskaya @alexpensify
I think that the "expected result" should not be just the "actual result", but negated. What amount should actually be displayed? 0?

Yeah, I think 0 makes sense.

I like the approach taken by @joh42 and @tienifr, which focuses on improving the already existing logic for resetMoneyRequestInfo, which seems to have the intention to prevent exactly what we're observing in this issue.
@joh42 was first here, but I think that the hook-based solution by @tienifr is the better one.
So I say we go with @tienifr here.
C+ reviewed 🎀 👀 🎀

@marcochavezf - we need a review here, please. Thanks!

I've bumped @marcochavezf in Chat.

Thanks for the review @cubuspl42, also @tienifr's proposal looks good to me 🚀

This is being taken care of

@cubuspl42 - to prepare for the payment date, can you please complete the checklist? Thanks!

The PR that introduced the bug has been identified. Link to the PR:

https://github.com/Expensify/App/pull/25707/files#r1348624232

The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

[N/A](https://github.com/Expensify/App/pull/25707

A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

No need for additional discussion

Determine if we should create a regression test for this bug.

Up to the QA team

If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Launch the app.
Tap the Floating Action Button (FAB).
Select the 'Request Money' option.
Access the 'Distance' feature.
Click on 'Start' and choose a specific address.
Click on 'Finish' and designate a different address.
Proceed by tapping 'Next'.
Choose your preferred workspace.
Take note of the 'Request Money' amount displayed.
Navigate back to the 'Request Money' page.
Select the 'Manual' option.
Confirm that no amount is set (you should see a slightly greyed-out 0)

The PR that introduced the bug has been identified. Link to the PR:

https://github.com/Expensify/App/pull/25707/files#r1348624232

The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

https://github.com/Expensify/App/pull/25707

A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

No need for additional discussion

Determine if we should create a regression test for this bug.

Up to the QA team

If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Launch the app.
Tap the Floating Action Button (FAB).
Select the 'Request Money' option.
Access the 'Distance' feature.
Click on 'Start' and choose a specific address.
Click on 'Finish' and designate a different address.
Proceed by tapping 'Next'.
Choose your preferred workspace.
Take note of the 'Request Money' amount displayed.
Navigate back to the 'Request Money' page.
Select the 'Manual' option.
Confirm that no amount is set (you should see a slightly greyed-out 0)

My mistake, I missed that there was a regression here but was addressed quickly. I need another day to review and confirm the payment amounts. For now, I've paid the reporter.

Here is the payment summary:

External issue reporter @ashimsharma10 $50
Contributor that fixed the issue @cubuspl42 $500
Contributor+ that helped on the issue and/or PR @tienifr $500

Upwork Job: https://www.upwork.com/jobs/~01baf90b8cc8571594
*If applicable, the bonuses will be applied on the final payment
Extra Notes regarding payment: This GH would fall under an urgency bonus but due to regression there won't be one. We did fix the issue quickly, so I'll be keeping the base pay as is for the contributors.

Everyone has been paid in Upwork. I need to create the regression test and will close it.

Not overdue, I need to create the regression test.

Contributor that fixed the issue @cubuspl42 $500

Contributor+ that helped on the issue and/or PR @tienifr $500

It's the opposite, but doesn't matter much I guess

Alright, I updated the summary based on the @cubuspl42 feedback Also, I created the regression test, so I'm going to close this out.

authors: akinwale alexpensify cubuspl42 izarutskaya joh42 marcochavezf