text:
SystemJS error when import HttpClient

I'm submitting a ...  (check one with "x")
[x] bug report => search github for a similar issue or PR before submitting
[ ] feature request
[ ] support request => Please do not submit support request here, instead see use [gitter](https://gitter.im/mgechev/angular2-seed) or [stackoverflow](https://stackoverflow.com/questions/tagged/angular2)

Current behavior
SystemJS error when import HttpClient
Expected behavior
No error
Minimal reproduction of the problem with instructions
Hi. I'm experiencing problems with adding new HttpClient to SystemJS in Angular seed. I've read comments here https://github.com/mgechev/angular-seed/issues/2033, but offered solutions didn't help. What I've done so far:

npm install tslib --save-dev
add these to packages to additionalPackages in tools/config/project.config.ts (as mentioned in
@maxklenk comment in issue 2033):

        name: '@angular/common/http',
        path: 'node_modules/@angular/common',
        packageMeta: {
          main: 'bundles/common-http.umd.js',
          defaultExtension: 'js'
        }
      },
      {
        name: 'tslib',
        path: 'node_modules/tslib',
        packageMeta: {
          main: 'tslib.js',
          defaultExtension: 'js'
        }
      }

add HttpClientModule import to app.module.ts

And I get this error as result: http://imgur.com/a/ZoYYW
I did these steps afterwards:

delete node modules folder
npm cache clean
npm install

And still have the same error when run "npm start".
Angular version: 4.3.1

I've added '@angular/common/http': 'node_modules/@angular/common/bundles/common-http.umd.js', to both SYSTEM_CONFIG_DEV and SYSTEM_BUILDER_CONFIG in seed.config.ts and tslib via additionalpackages in project.config.ts with
{
                name: 'tslib',
                path: 'node_modules/tslib/tslib.js'
            }

Extending @negberts  comments, It additionally needs tslib because @angular/common/http is dependant on tslib, see Source Here

@negberts  do it get it right that to get http client working you did the following steps:

In seed.config.ts:
Add this line of code:
'@angular/common/http': 'node_modules/@angular/common/bundles/common-http.umd.js'
to SYSTEM_CONFIG_DEV.paths object and to SYSTEM_BUILDER_CONFIG.paths
In project.config.ts add this package definition to additionalPackages array:

{
      name: 'tslib',
      path: 'node_modules/tslib/tslib.js'
}

In app.module.ts:
Add HttpClientModule to IMPORTS array and import the module like this:
import { HttpClientModule } from '@angular/common/http';

And it worked for you with no errors.
Are there any steps I missed?

Nope. That works for us.

@negberts did the same in our project, doesn't work for us for some reason. Neither works solution in offered in #2033, which is different from yours.
Is there a way for me to see your seed.config.ts file? I believe your repository is private, but maybe you can share this config while which shouldn't contain any confidential code.

/**
     * The configuration of SystemJS for the `dev` environment.
     * @type {any}
     */
    SYSTEM_CONFIG_DEV: any = {
        meta: {
            'xlsx': {
                exports: 'XLSX' // <-- this is needed to tell SystemJS to expose XLSX
            }
        },
        paths: {
            [this.BOOTSTRAP_MODULE]: `${this.APP_BASE}${this.BOOTSTRAP_MODULE}`,
            [this.BOOTSTRAP_DEV_MODULE]: `${this.APP_BASE}${this.BOOTSTRAP_DEV_MODULE}`,
            '@angular/animations': 'node_modules/@angular/animations/bundles/animations.umd.js',
            '@angular/animations/browser': 'node_modules/@angular/animations/bundles/animations-browser.umd.js',
            '@angular/platform-browser/animations':
            'node_modules/@angular/platform-browser/bundles/platform-browser-animations.umd.js',
            '@angular/common': 'node_modules/@angular/common/bundles/common.umd.js',
            '@angular/common/http': 'node_modules/@angular/common/bundles/common-http.umd.js',
            '@angular/compiler': 'node_modules/@angular/compiler/bundles/compiler.umd.js',
            '@angular/core': 'node_modules/@angular/core/bundles/core.umd.js',
            '@angular/forms': 'node_modules/@angular/forms/bundles/forms.umd.js',
            '@angular/http': 'node_modules/@angular/http/bundles/http.umd.js',
            '@angular/platform-browser': 'node_modules/@angular/platform-browser/bundles/platform-browser.umd.js',
            '@angular/platform-browser-dynamic':
            'node_modules/@angular/platform-browser-dynamic/bundles/platform-browser-dynamic.umd.js',
            '@angular/router': 'node_modules/@angular/router/bundles/router.umd.js',
            'primeng': 'node_modules/primeng',
            'app/': `${this.APP_BASE}app/`,
            // For test config
            'dist/dev/': '/base/dist/dev/',
            '': 'node_modules/'
        },
        map: {
            'xlsx': this.BUILD_TYPE === BUILD_TYPES.PRODUCTION ? 'node_modules/xlsx/xlsx.min.js' : 'node_modules/xlsx/dist/xlsx.full.min.js',
            'fs': this.BUILD_TYPE === BUILD_TYPES.PRODUCTION ? '@node/fs' : '', // <-- systemjs doesn't seem to automatically suppress node core
            'crypto': this.BUILD_TYPE === BUILD_TYPES.PRODUCTION ? '@node/crypto' : '',
            'stream': this.BUILD_TYPE === BUILD_TYPES.PRODUCTION ? '@node/stream' : '',
            'd3-array': 'node_modules/d3-array',
            'd3-brush': 'node_modules/d3-brush',
            'd3-shape': 'node_modules/d3-shape',
            'd3-selection': 'node_modules/d3-selection',
            'd3-color': 'node_modules/d3-color',
            'd3-drag': 'node_modules/d3-drag',
            'd3-transition': 'node_modules/d3-transition',
            'd3-format': 'node_modules/d3-format',
            'd3-force': 'node_modules/d3-force',
            'd3-dispatch': 'node_modules/d3-dispatch',
            'd3-path': 'node_modules/d3-path',
            'd3-ease': 'node_modules/d3-ease',
            'd3-timer': 'node_modules/d3-timer',
            'd3-quadtree': 'node_modules/d3-quadtree',
            'd3-interpolate': 'node_modules/d3-interpolate',
            'd3-scale': 'node_modules/d3-scale',
            'd3-time': 'node_modules/d3-time',
            'd3-collection': 'node_modules/d3-collection',
            'd3-time-format': 'node_modules/d3-time-format',
            'd3-hierarchy': 'node_modules/d3-hierarchy',
            '@swimlane/ngx-charts': 'node_modules/@swimlane/ngx-charts',
        },
        packages: {
            [this.BOOTSTRAP_DIR]: {
                'defaultExtension': 'js'
            },
            'primeng': {
                'defaultExtension': 'js'
            },
            '@swimlane/ngx-charts': { main: 'release/index.min.js', defaultExtension: 'js' },
            'd3-array': { main: 'build/d3-array.min.js', defaultExtension: 'js' },
            'd3-format': { main: 'build/d3-format.min.js', defaultExtension: 'js' },
            'd3-brush': { main: 'build/d3-brush.min.js', defaultExtension: 'js' },
            'd3-color': { main: 'build/d3-color.min.js', defaultExtension: 'js' },
            'd3-force': { main: 'build/d3-force.min.js', defaultExtension: 'js' },
            'd3-hierarchy': { main: 'build/d3-hierarchy.min.js', defaultExtension: 'js' },
            'd3-interpolate': { main: 'build/d3-interpolate.min.js', defaultExtension: 'js' },
            'd3-scale': { main: 'build/d3-scale.min.js', defaultExtension: 'js' },
            'd3-selection': { main: 'build/d3-selection.min.js', defaultExtension: 'js' },
            'd3-shape': { main: 'build/d3-shape.min.js', defaultExtension: 'js' },
            'd3-time-format': { main: 'build/d3-time-format.min.js', defaultExtension: 'js' },
            'd3-drag': { main: 'build/d3-drag.min.js', defaultExtension: 'js' },
            'd3-transition': { main: 'build/d3-transition.min.js', defaultExtension: 'js' },
            'd3-dispatch': { main: 'build/d3-dispatch.min.js', defaultExtension: 'js' },
            'd3-path': { main: 'build/d3-path.min.js', defaultExtension: 'js' },
            'd3-ease': { main: 'build/d3-ease.min.js', defaultExtension: 'js' },
            'd3-timer': { main: 'build/d3-timer.min.js', defaultExtension: 'js' },
            'd3-quadtree': { main: 'build/d3-quadtree.min.js', defaultExtension: 'js' },
            'd3-time': { main: 'build/d3-time.min.js', defaultExtension: 'js' },
            'd3-collection': { main: 'build/d3-collection.min.js', defaultExtension: 'js' }
        }
    };

    /**
     * The configuration of SystemJS of the application.
     * Per default, the configuration of the `dev` environment will be used.
     * @type {any}
     */
    SYSTEM_CONFIG: any = this.SYSTEM_CONFIG_DEV;

    /**
     * The system builder configuration of the application.
     * @type {any}
     */
    SYSTEM_BUILDER_CONFIG: any = {
        //use typescript for compilation
        transpiler: 'typescript',
        //typescript compiler options
        typescriptOptions: {
            emitDecoratorMetadata: true
        },
        defaultJSExtensions: true,
        base: this.PROJECT_ROOT,
        packageConfigPaths: [
            join('node_modules', '*', 'package.json'),
            join('node_modules', '@angular', '*', 'package.json')
        ],
        meta: {
            'xlsx': {
                exports: 'XLSX' // <-- this is needed to tell SystemJS to expose XLSX
            }
        },
        map: {
            'xlsx': this.BUILD_TYPE === BUILD_TYPES.DEVELOPMENT ? 'node_modules/xlsx/xlsx.min.js' : 'node_modules/xlsx/dist/xlsx.full.min.js',
            'fs': '@node/fs',
            'crypto': '@node/crypto',
            'stream': '@node/stream',
            'd3-array': 'node_modules/d3-array',
            'd3-brush': 'node_modules/d3-brush',
            'd3-shape': 'node_modules/d3-shape',
            'd3-selection': 'node_modules/d3-selection',
            'd3-color': 'node_modules/d3-color',
            'd3-drag': 'node_modules/d3-drag',
            'd3-transition': 'node_modules/d3-transition',
            'd3-format': 'node_modules/d3-format',
            'd3-force': 'node_modules/d3-force',
            'd3-dispatch': 'node_modules/d3-dispatch',
            'd3-path': 'node_modules/d3-path',
            'd3-ease': 'node_modules/d3-ease',
            'd3-timer': 'node_modules/d3-timer',
            'd3-quadtree': 'node_modules/d3-quadtree',
            'd3-interpolate': 'node_modules/d3-interpolate',
            'd3-scale': 'node_modules/d3-scale',
            'd3-time': 'node_modules/d3-time',
            'd3-collection': 'node_modules/d3-collection',
            'd3-time-format': 'node_modules/d3-time-format',
            'd3-hierarchy': 'node_modules/d3-hierarchy',
            '@swimlane/ngx-charts': 'node_modules/@swimlane/ngx-charts',
        },
        paths: {
            // Note that for multiple apps this configuration need to be updated
            // You will have to include entries for each individual application in
            // `src/client`.
            [join(this.TMP_DIR, this.BOOTSTRAP_DIR, '*')]: `${this.TMP_DIR}/${this.BOOTSTRAP_DIR}/*`,
            '@angular/platform-browser/animations': 'node_modules/@angular/platform-browser/bundles/platform-browser-animations.umd.js',
            '@angular/animations/browser': 'node_modules/@angular/animations/bundles/animations-browser.umd.js',
            '@angular/common/http': 'node_modules/@angular/common/bundles/common-http.umd.js',
            'dist/tmp/node_modules/*': 'dist/tmp/node_modules/*',
            'node_modules/*': 'node_modules/*',
            'primeng': 'node_modules/primeng',
            '*': 'node_modules/*'
        },
        packages: {
            '@angular/animations': {
                main: 'bundles/animations.umd.js',
                defaultExtension: 'js'
            },
            '@angular/platform-browser/animations': {
                main: 'bundles/platform-browser-animations.umd.js',
                defaultExtension: 'js'
            },
            '@angular/common': {
                main: 'bundles/common.umd.js',
                defaultExtension: 'js'
            },
            '@angular/compiler': {
                main: 'bundles/compiler.umd.js',
                defaultExtension: 'js'
            },
            '@angular/core': {
                main: 'bundles/core.umd.js',
                defaultExtension: 'js'
            },
            '@angular/forms': {
                main: 'bundles/forms.umd.js',
                defaultExtension: 'js'
            },
            '@angular/http': {
                main: 'bundles/http.umd.js',
                defaultExtension: 'js'
            },
            '@angular/platform-browser': {
                main: 'bundles/platform-browser.umd.js',
                defaultExtension: 'js'
            },
            '@angular/platform-browser-dynamic': {
                main: 'bundles/platform-browser-dynamic.umd.js',
                defaultExtension: 'js'
            },
            '@angular/router': {
                main: 'bundles/router.umd.js',
                defaultExtension: 'js'
            },
            'rxjs': {
                main: 'Rx.js',
                defaultExtension: 'js'
            },
            'primeng': {
                'defaultExtension': 'js'
            },
            '@swimlane/ngx-charts': { main: 'release/index.min.js', defaultExtension: 'js' },
            'd3-array': { main: 'build/d3-array.min.js', defaultExtension: 'js' },
            'd3-format': { main: 'build/d3-format.min.js', defaultExtension: 'js' },
            'd3-brush': { main: 'build/d3-brush.min.js', defaultExtension: 'js' },
            'd3-color': { main: 'build/d3-color.min.js', defaultExtension: 'js' },
            'd3-force': { main: 'build/d3-force.min.js', defaultExtension: 'js' },
            'd3-hierarchy': { main: 'build/d3-hierarchy.min.js', defaultExtension: 'js' },
            'd3-interpolate': { main: 'build/d3-interpolate.min.js', defaultExtension: 'js' },
            'd3-scale': { main: 'build/d3-scale.min.js', defaultExtension: 'js' },
            'd3-selection': { main: 'build/d3-selection.min.js', defaultExtension: 'js' },
            'd3-shape': { main: 'build/d3-shape.min.js', defaultExtension: 'js' },
            'd3-time-format': { main: 'build/d3-time-format.min.js', defaultExtension: 'js' },
            'd3-drag': { main: 'build/d3-drag.min.js', defaultExtension: 'js' },
            'd3-transition': { main: 'build/d3-transition.min.js', defaultExtension: 'js' },
            'd3-dispatch': { main: 'build/d3-dispatch.min.js', defaultExtension: 'js' },
            'd3-path': { main: 'build/d3-path.min.js', defaultExtension: 'js' },
            'd3-ease': { main: 'build/d3-ease.min.js', defaultExtension: 'js' },
            'd3-timer': { main: 'build/d3-timer.min.js', defaultExtension: 'js' },
            'd3-quadtree': { main: 'build/d3-quadtree.min.js', defaultExtension: 'js' },
            'd3-time': { main: 'build/d3-time.min.js', defaultExtension: 'js' },
            'd3-collection': { main: 'build/d3-collection.min.js', defaultExtension: 'js' }
        }
    };

@aGoncharuks did I understand correctly that you added stuff to both seed.config and project.config? For me it was only project.config, didn't work when I had it in both places.

@zladuric you are not supposed to change seed.config.ts. Maybe the issue is related to a property in seed.config.ts which is being used as part of your project.config.ts and not overridden?

Yes, I know, but I was trying various things to make it work. Changing project.config didn't work for me (don't remember the issue), so I ended up modifying seed.config and adding a TODO to do it properly later. Then later I've added stuff to project.config, but forgot to remove seed.config stuff, and it still didn't work, and when I reverted it all the way back, I've finally solved it.

@mgechev one question about "not supposed to change seed.config.ts" - I have a private npm package ("@zladuric/ngx-infinite-scroll" as mentioned somewhere, fork of regular ngx-infinite-scroll").
But if I don't include it here in seed.config, , copying join('node_modules', '@angular', '*', 'package.json') line, than build.prod fails, because it looks for package.json there?
It fails with:
originalErr: Error: ENOENT: no such file or directory, open '/home/zlatko/projects/snakt-web/node_modules/@zladuric/package.json'

(Going through all this again because I again have silly problems with build.prod.)

@zladuric the cleanest way will be to override SYSTEM_BUILDER_CONFIG in project.config.ts.
You can either override the entire property or just SYSTEM_BUILDER_CONFIG. packageConfigPaths.

@mgechev can you please take a look at first post in this thread. As far as I understand, all new packages should be added by changing project.config.ts and that's true for HttpClientModule as well. Did I miss anything or did something wrong in any of steps? I just created new branch and repeated all steps, and still have the in console:
(SystemJS) XHR error (404 Not Found) loading http://localhost:5555/node_modules/@angular/common/http.js.

Closing it because of https://github.com/mgechev/angular-seed/issues/2057.

I know this is a closed item, but I wanted to add that @mgechev's comment helped me:

the cleanest way will be to override SYSTEM_BUILDER_CONFIG in project.config.ts

The syntax to do this is:
this.SYSTEM_BUILDER_CONFIG.packageConfigPaths.push(join('node_modules', '@ngx-translate', '*', 'package.json'));

This solution worked for me
Adding
'@angular/common/http': 'npm:@angular/common/bundles/common-http.umd.js',
'tslib': 'npm:tslib/tslib.js',
in my systemjs.config file resolved the issue for me.

authors: TrueGeek aGoncharuks akshayantony mgechev negberts pankajparkar zladuric


text:
Topic/nginx base

Add nginx_base role to collection.

Blocked by #52

source: gharchive/pull-request

repo: mgit-at/ansible-collection-roles

license_type: permissive

license_source: github-api


text:
Error handling

We need a way to recognize whether a Composer process completed successfully or not.
Users ignoring the Composer output is a real problem.
If we can detect an error, we can probably also extract the error message, and show it.

There is ex, stdout, and stderr, right now all if piped out. This needs to be groomed a lot. Like moving it out of a textarea so we can do HTML highlighting.

source: gharchive/issue

authors: bojanz mglaman

repo: mglaman/conductor

license: mit

license_source: bigquery


text:
🛑 UAT Barracuda v2 is down

In e273021, UAT Barracuda v2 (https://barracuda-uat.mhtr.be/v2/docs) was down:

HTTP code: 403
Response time: 14 ms

Resolved: UAT Barracuda v2 is back up in 3c929af.

repo: mh-data-science/upptime

license: MIT


text:
vim working directory change when open from MRU

When opening files from MRU, it seems it overrides set noautochdir, is it by design?

The default behaviour of changing the directory is separate from 'autochdir'.
Use let g:startify_change_to_dir = 0 instead.

Thanks for help, I should have read the docs first.

repo: mhinz/vim-startify


text:
func FilesFromDisk filenames arg, if path seperator is not system defined, pathInArchieve may be wrong path

What version of the package or command are you using?

What are you trying to do?

What steps did you take?

What did you expect to happen, and what actually happened instead?

How do you think this should be fixed?

Please link to any related issues, pull requests, and/or discussion

Bonus: What do you use archiver for, and do you find it useful?

for example,
map[string]string{
"./disk/file1.txt":         "file1.txt",
"./disk/file2.txt":         "subfolder/file2.txt",
"./disk/folder1/file3.txt": "",              // put in root of archive as file3.txt
"./disk/folder2/file4.txt": "subfolder/",    // put in subfolder as file4.txt
"disk/folder2":             "Custom Folder", // contents added recursively
})
in windows, the path Custom Folder/disk/folder/

	map[string]string{
		"disk/folder2":             "CF", // contents added recursively
	})

I want disk/folder2/a.txt to be CF/a.txt，but it's CF/disk/folder2/a.txt, in windows

Thanks, I'll look into this

Ok so I just looked at the tests and this is expected. What happens if you specify CF/ instead?

in windows the seperator is \，if l use / in filenames arg，it will not work as I want, maybe you can turn \ to / in arg to return the right path
---Original---
From: "Matt @.>
Date: Mon, Aug 21, 2023 21:37 PM
To: @.>;
Cc: @.@.>;
Subject: Re: [mholt/archiver] func FilesFromDisk filenames arg, if pathseperator is not system defined, pathInArchieve may be wrong path (Issue #382)
Ok so I just looked at the tests and this is expected. What happens if you specify CF/ instead?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: @.***>

@mind-owner You mean disk/folder2 -> disk\folder2?
If that works for you on Windows then I suggest using that :man_shrugging: -- nothing needs to be fixed. (We're already using filepath.* function which do account for path separators.)

yes, you are right. I can use \ in windows to return the right path. and usually people would only use / as the path seperator in any system(linux,windows etc), l hope the func FilesFromDisk can support this feature, then l don't need to mention / or , thanks.
---Original---
From: "Matt @.>
Date: Tue, Aug 22, 2023 00:07 AM
To: @.>;
Cc: @.@.>;
Subject: Re: [mholt/archiver] func FilesFromDisk filenames arg, if pathseperator is not system defined, pathInArchieve may be wrong path (Issue #382)
@mind-owner You mean disk/folder2 -> disk\folder2?
If that works for you on Windows then I suggest using that 🤷♂ -- nothing needs to be fixed. (We're already using filepath.* function which do account for path separators.)
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: @.***>

@mind-owner If you call filepath.FromSlash() when making your map keys, does that solve it for you in a more cross-platform way? I feel like that would be the most correct solution. (I could be wrong, but not sure yet.)

Closing due to inactivity

authors: mholt mind-owner

repo: mholt/archiver


text:
Wildcard support for error pages

As far as the documentation goes one can set error pages for all errors above 400 codes. It would be great to have a catch all error file and in addition specific error pages afterwards. Something along the lines of:

generic_error.html
500 500_error.html
502 502_error.html
429 429_error.html

This would serve the specific pages on error 500, 502 and 429, but the generic page on evey other error.

A default error page is probably fine; but I'm not sure I like the idea of stringing them all together on a single line.

And the singe line "idea" was just me not formatting the issue right. Sorry for that.

I`d like to take this one

Thanks @evvvvr! @stp-ip, this is now implemented and will go out with the next release. Note that it works like:
errors {
    * default_error.html
}

authors: evvvvr mholt stp-ip

repo: mholt/caddy


text:
Double systemd LimitNPROC to allow more threads

1. What does this change do, exactly?
LimitNPROC in caddy.service changed from 64 to 128
2. Please link to the relevant issues.
This change solved #1723 for me. I arbitrarily doubled 64 to 128, not sure what is a better value. The error seems to be that caddy requests a 65th thread and then gets denied. Not sure if relevant to #1823 since perhaps that will affect restarting (no more "restart too quickly" errors?). Pinging @wmark
3. Which documentation changes (if any) need to be made because of this PR?
None.
4. Checklist

[ ] I have written tests and verified that they fail without my change
[x] I have squashed any insignificant commits (only one commit)
[ ] This change has comments for package types, values, functions, and non-obvious lines of code
[ ] I am willing to help maintain this change if there are issues with it later

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

I'd set this to 512 to be on the safe side.
ulimit -u or LimitNPROC limits processes and threads (in the whole tree, with caddy as its parent). You can run into this limit on servers with lots of cores (Golang will start C×cores threads if not instructed otherwise) or if you use a plugin which starts its own processes (≠ goroutines).
Anyway, operators configure a limit here to catch misbehaviour early. (See also max smb processes on Samba.)
The natural limit is the »largest« thread count you can expect these days on a 8-way server. 28 cores it is since Broadwell on non-public cpus, and since Skylake for the public. 8× 28×2 +1 = 449.

Thank you!

authors: CLAassistant mholt thejmazz wmark


text:
Add documentation on how to use craftyjs as a server lib and npm publish it

Maybe add a basic example too.

done

repo: mhsjlw/flying-squid


text:
fix(web-components): breadcrumb group collapsed prop issue

Fixed the issue with the breadcrumb group collapsed prop not toggling properly and fixed the back arrow not turning back into a chevron
fix #1998
fix #2028

Summary of the changes
Fixed the issue where the breadcrumb group prop would, when toggled, not remove the collapsed ellipses element so they would just stack up
Also fixed the issue where, when toggled back and forth, the back arrow for the 'back breadcrumb only' prop would not switch back to a chevron icon
Related issue
#1998
#2028

I'm getting some odd behaviour on the collapsed state still, but I think it's a weird edge case. If I toggle in the side panel, it works fine, but when the toggle is set to collapsed="true" and then I click the ellipsis, and set collapsed to "false" in the side panel again, it completely removes breadcrumb 2. It could just be a storybook nuance, but it'd be good if there was a way the playground collapsed value could reflect the actual collapsed value if the ellipsis is clicked e.g. updating the switch to false if the ellipsis is clicked.
https://github.com/user-attachments/assets/eaf8110a-8b6e-447f-9ed4-94da47a84253


text:
Security: remote code execution

Hi,
I am currently auditing many open-source reddit clients and have
found an important vulnerability in rtv involving massive remote code
execution.
The problem
In rtv/terminal.py:471 (rev. 20b59d5), in open_browser(...) the
command variable is built unsafely. An url such as:
http://test.com/?q=');print('hacked');print('

would allow python code injection which would lately be happily
executed by python through the Popen call.
Attack scenario
An attacker could craft a malicious url executing code (most likely
downloading a trojan) and post it under an attractive reddit title.
Anyone trying to open it in the webbrowser through rtv would get
hacked.
Also note that in my example a tab is still opened to the url
http://test.com/?q=

so one could very well provide a real url in order to mask his
attack for those that do not use rtv.
The impact
The impact is critical: hundreds of computers can be impacted at
once. While it needs user interaction it is very easy to hide the
attack from one.
Recommended fix
The best would be not to evaluate python code at all. Every code
injection problem comes from bugs at the interface between two
languages or layers.
The quickest solution though would be to escape quotes and
backslashes within the url. Escaping each and every character would
break lots of urls but at the very least quotes and backslashes
shouldn't be part of it.
I don't recommend the quick solution though: executing external code
through proper means is better.
Course of action
In my humble opinion your best course of action is to patch it as
soon as possible then issue a clear warning to already existing
users, maybe by getting a CVE number (Common Vulnerability and
Exposures, a global reference for all security vulnerabilities in
software of some importance).
I hope this finds you well,
Sincerely,
Cédric Picard

Cedric first sent this via email but have given me permission to post it publicly.
This is the offending line. If the url contains a quote, it can break out of the string and execute arbitrary python commands.
command = "import webbrowser; webbrowser.open_new_tab('%s')" % url

The quickest solution as stated above is to sanitize all urls from reddit before opening them. I wonder if urllib.parse.quote would be sufficient. I'm honestly surprised that the reddit api doesn't already do this for us.

Possible related security hole with mailcap https://bugs.python.org/issue24778 that I noticed a while ago but never looked into.

A quick and dirty solution (albeit effective) would be something along the lines of:
    if self.display:
        command = """
                  import webbrowser, urllib.parse as p
                  webbrowser.open_new_tab(p.unquote('%s'))" % p.quote(url)
                  """
        args = [sys.executable, '-c', command]

It avoids any misquote and injection

Is there any valid reason for the url to have quotes? i.e. why not just
    if self.display:
        command = """
                  import webbrowser
                  webbrowser.open_new_tab('%s')
                  """ % p.quote(url)
        args = [sys.executable, '-c', command]

Not unquoting it would break many things, take a youtube url for example:
https://www.youtube.com/watch?v=dQw4w9WgXcQ
Quoted it becomes https%3A//www.youtube.com/watch%3Fv%3DdQw4w9WgXcQ which isn't valid for youtube. So it needs to be unquoted.

I just published a new release and put a warning in the README letting people know to upgrade.

repo: michael-lazar/rtv


text:
Grunt Compile Error

I got this error after following all of the steps and then running 'grunt compile':
~/tribeca$ sudo grunt compile
module.js:338
throw err;
^
Error: Cannot find module './lexer'
at Function.Module._resolveFilename (module.js:336:15)
at Function.Module._load (module.js:278:25)
at Module.require (module.js:365:17)
at require (module.js:384:17)
at Object. (/tribeca/node_modules/grunt/node_modules/coffee-script/lib/coffee-script/coffee-script.js:10:10)
at Object. (/tribeca/node_modules/grunt/node_modules/coffee-script/lib/coffee-script/coffee-script.js:167:4)
at Module._compile (module.js:460:26)
at Object.Module._extensions..js (module.js:478:10)
at Module.load (module.js:355:32)
at Function.Module._load (module.js:310:12)
I know my node is the correct version (0.12).  The one weird thing is that I installed it under 'sudo' but it should still work... what is this 'lexer' module and why cant it be found?

Yikes, I have no idea what that could be coming from. It's not in the tribeca package.json. It's most likely a dependency of one of my dependencies. One link I found on Google is: http://stackoverflow.com/q/24639586/178073
I also updated the repository with a docker-based compile+deploy strategy. If you're amenable to trying that out, it hopefully should reduce the chances of these weird compile bugs.

Closed due to inactivity.

authors: admazzola michaelgrosner

repo: michaelgrosner/tribeca

license: isc


text:
Cross-compiling shared library using mingw

Please add ability to cross-compile mxml as a shared library.
Currently your library is packaged by MXE project but only for static targets.
Also this will be useful for libomemo project.

Shared library creation is highly system-specific, so I don't see doing this for any platform.
It is conceivable that I could support cross-compiling for a Linux shared library target but even that might not work with all cross-compile tools... :/

[master 2b94fdd] Add (limited) cross-compilation support (Issue #188)

OK, try grabbing the latest code from master and let me know if you have any issues.

...
configure: creating ./config.status
config.status: creating Makefile
config.status: error: cannot find input file: `mxml.list.in'

This made things worse.
Before I was able to cross build mxml shared library with a little patch,
now it will fail.
configure: WARNING: shared libraries not supported on this platform.

config.status: error: cannot find input file: `mxml.list.in'

Shared lib support detection is wrong and completely bogus
This is total nonsense -> https://github.com/michaelrsweet/mxml/blob/master/configure.ac#L171
Even when running configure without crosscompiling the shared check fails.
In my case host_os is  linux-gnu ( its Ubuntu 16.10 x64) which will not pass the check below which check only for "linux" verbatim.

The patch below and running autoconf -v before ./configure fixed cross build again for me:
diff --git a/Makefile.in b/Makefile.in
index 5fbc383..ebb32c5 100644
--- a/Makefile.in
+++ b/Makefile.in
@@ -16,7 +16,7 @@
 # Compiler tools definitions...
 #

-AR             =       @AR@
+AR             :=      $(AR)
 ARFLAGS                =       @ARFLAGS@
 ARCHFLAGS      =       @ARCHFLAGS@
 CC             =       @CC@
@@ -31,7 +31,7 @@ LIBS          =       @LIBS@ @PTHREAD_LIBS@
 LN             =       @LN@ -s
 MKDIR          =       @MKDIR@
 OPTIM          =       @OPTIM@
-RANLIB         =       @RANLIB@
+RANLIB         :=      $(RANLIB)
 RM             =       @RM@ -f
 SHELL          =       /bin/sh

@@ -55,7 +55,7 @@ BUILDROOT     =       $(DSTROOT)
 # Install commands...
 #

-INSTALL_BIN    =       $(LIBTOOL) $(INSTALL) -m 755 -s
+INSTALL_BIN    =       $(LIBTOOL) $(INSTALL) -m 755
 INSTALL_DATA   =       $(INSTALL) -m 644
 INSTALL_DIR    =       $(INSTALL) -d
 INSTALL_LIB    =       $(LIBTOOL) $(INSTALL) -m 755
diff --git a/configure.ac b/configure.ac
index e8c9919..172d0b5 100644
--- a/configure.ac
+++ b/configure.ac
@@ -192,7 +192,7 @@ if test x$enable_shared != xno; then
                        DSOFLAGS="$DSOFLAGS -Wl,-rpath,\$(libdir),-set_version,sgi1.0,-soname,libmxml.so.1 -shared \$(OPTIM)"
                        ;;

-               osf | linux | gnu)
+               osf | linux-gnu*)
                        AC_MSG_RESULT(yes)
                        LIBMXML="libmxml.so.1.5"
                        DSO="\$(CC)"

OK, the patch is wrong.
And the reason I asked you to check is that I don't have you configuration handy and am unable to test it myself (although I should have gotten the missing mxml.list.in file error...  hmmm..)
Try the latest now.  I did push both an updated configure.ac and configure script; I haven't checked install-sh to verify it does the right thing for -s (strip), I suspect that might still be a problem.

(I updated the ar check to use AC_CHECK_TOOL which handles the host tool prefix nonsense, and AC_PROG_RANLIB is supposed to do that already...)

OK, lacking a better solution I've dropped the -s option from the INSTALL_BIN definition to avoid using the wrong strip command on install. Please let me know if you run into any problems!

Thanks.
At least for me latest master built without problems and dirty hacks.

Great!

Why this issue was closed? You have not added libmxml.dll target into Makefile.in and appropriate check for shared library support into configure script.
As far as I see currently there is only one possible way to build *.dll file for MS Windows: using MS Visual Studio. I am just asking for adding MinGW support... As far as I know in autotools based projects it is quite easy to do.

@tehnick You didn't ask to be able to build a DLL via cross-compilation, you asked for cross-compilation via MingW and showed the example of building a Linux shared library. I will investigate possibilities for supporting creation of a Windows DLL via cross-compilation, but right now I only support doing so using the Visual Studio project file (and Visual Studio Essentials is a FREE download).
For the record, libtool and automake are compatibility nightmares, so I will NEVER support them. libtool fails on many platforms and introduces complications for using the shared libraries with non-autotools projects (works for common platforms, not so well for anything else). And automake can create makefiles that are not compatible with regular "make" programs like supplied with Visual Studio, some BSDs, HP-UX, IRIX, Solaris, AIX, etc. In short, using the full autotools suite can make a program less portable and harder to maintain, especially if you are not willing to require the use of GNU make.

For the record, libtool and automake are compatibility nightmares, so I will NEVER support them.

I see.
Personally I do not like autotools at all and use cmake in all projects where it is possible.

You didn't ask to be able to build a DLL via cross-compilation, you asked for cross-compilation via MingW

Sorry if my description was not enough accurate.

and showed the example of building a Linux shared library.

I am not sure what are you talking about. MXE project is developed by Linux, macOS and *BSD users for simplifying cross-compilation of libraries and applications for MS Windows.

I will investigate possibilities for supporting creation of a Windows DLL via cross-compilation,

Thanks a lot.

but right now I only support doing so using the Visual Studio project file (and Visual Studio Essentials is a FREE download).

Unfortunately this is useless for developers without MS Windows.

See #192, cmake takes care of a lot when it comes to building shared libs for windows.

If a user can use MS Visual Studio, he can complie and build mini-XML shared library with Visual Studio command prompt. I wrote an introduction. It can be found in my blog: http://blog.csdn.net/henter/article/details/53907696
I also sent an email to the mini-XML developer to suggest including the introduction in mini-XML documentation,  but I got no response.

I just pushed the following changes to support building DLLs:
[master 3700ebd] Add libmxml1.dll target and support for mingw cross-compilation (Issue #188)
Please let me know whether they work for you...

@tehnick Can you test the changes in master and let me know if things are working satisfactorily?

Please let me know if this does not work for you.

Any news?

authors: Neustradamus asavah greendow michaelrsweet tehnick tonytheodore

repo: michaelrsweet/mxml


text:
Possible null pointer usage in snmp.c

https://github.com/michaelrsweet/pappl/blob/97d7297ee47a21597b19791ccb660da27513db29/pappl/snmp.c#L289-L292
Community variable is used in _PAPPL_DEBUG, but later is checked if is null

Modern C doesn't care about this and will output "(null)" for a NULL string pointer. But I can add a NULL check here to silence any warnings. (Keep in mind this is DEBUG code and never used in a production build...)

[master 785a77c] Add NULL check in debug printf - not necessary but silences warning (Issue #206)

authors: michaelrsweet qarmin

repo: michaelrsweet/pappl


text:
latex expressions in variables

Was wondering if it is possible to implement latex support in variables?

@myutkin, it might be possible to add this feature, but I'm unlikely to implement it. I've pasted the contributing section from the README below.

Contributing
Project Status: Inactive
This code is not being actively developed. It was created to fulfill my pandoc writing needs, and the current feature set is adequate for me.
If you have a feature request, it is unlikely that I will be able to implement it for you. You can create an issue to generate discussion. If you implement a feature, you can file pull request and I will review it eventually, as time permits. If you're interested in making major additions to the code, I'd be happy to welcome a new maintainer to the project.

If you'd like to spark further discussion on this feature request, you might want to describe what the current behaviour is, and what behaviour you'd like to see. A toy example would be helpful.

authors: michaelstepner myutkin

repo: michaelstepner/pandoc-mustache


text:
🛑 git.cta-observatory.org is down

In f56a883, git.cta-observatory.org (https://git.cta-observatory.org) was down:

HTTP code: 0
Response time: 0 ms

Resolved: git.cta-observatory.org is back up in 6bb03d2 after 14 minutes.

repo: michelangelobottura/ctaoit-upptime


text:
Support custom iframes and blockquotes

R = @kesla
T = minor

lgtm - but there's failures in CI

thanks

@iefserge I added bit hound (checks deps & other code quality issues) but it's complaining around linting. Will send up separate PR to handle that

See #8

authors: iefserge kesla

repo: micnews/article-json-to-amp


text:
Add external transport API

TODO:

[ ] Review in detail @jamoralp

This PR should target foxy

repo: micro-ROS/rmw-microxrcedds


text:
pure-export should handle empty selected-collections

Attempting to get 0 documents from nmdcschema/activity_set in pages of 200000.
warning: 400 Client Error: Bad Request for url: https://api.microbiomedata.org/nmdcschema/activity_set?max_page_size=200000
warning: FastAPI request to nmdcschema/activity_set appears to have failed. Trying as a PyMongo query.
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "/home/mark/.cache/pypoetry/virtualenvs/nmdc-schema-_1824IzR-py3.9/lib/python3.9/site-packages/click/core.py", line 1157, in __call__
    return self.main(*args, **kwargs)
  File "/home/mark/.cache/pypoetry/virtualenvs/nmdc-schema-_1824IzR-py3.9/lib/python3.9/site-packages/click/core.py", line 1078, in main
    rv = self.invoke(ctx)
  File "/home/mark/.cache/pypoetry/virtualenvs/nmdc-schema-_1824IzR-py3.9/lib/python3.9/site-packages/click/core.py", line 1434, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/home/mark/.cache/pypoetry/virtualenvs/nmdc-schema-_1824IzR-py3.9/lib/python3.9/site-packages/click/core.py", line 783, in invoke
    return __callback(*args, **kwargs)
  File "/home/mark/gitrepos/nmdc-schema/nmdc_schema/mongo_dump_api_emph.py", line 354, in cli
    direct_data_all = nmdc_pymongo_client.get_docs_from_pymongo(current_collection, max_docs)
UnboundLocalError: local variable 'nmdc_pymongo_client' referenced before assignment

When I visit the URL in the error message...
https://api.microbiomedata.org/nmdcschema/activity_set?max_page_size=200000

...I get the following response:
{
  "detail": "Collection name must be one of {'pooling_set', 'metagenome_annotation_activity_set', 'extraction_set', 'read_based_taxonomy_analysis_activity_set', 'field_research_site_set', 'metabolomics_analysis_activity_set', 'planned_process_set', 'study_set', 'collecting_biosamples_from_site_set', 'mags_activity_set', 'data_object_set', 'metagenome_sequencing_activity_set', 'functional_annotation_agg', 'read_qc_analysis_activity_set', 'library_preparation_set', 'metagenome_assembly_set', 'biosample_set', 'nom_analysis_activity_set', 'metaproteomics_analysis_activity_set', 'omics_processing_set', 'material_sample_set', 'metatranscriptome_activity_set', 'processed_sample_set'}"
}

I don't see activity_set in the list. I wanted to point this out as the Issue name says "empty" (maybe based upon the first line of the error message, which says "0 documents"), while the HTTP request suggests to me something like "unrecognized".

authors: eecavanna turbomam

repo: microbiomedata/nmdc-schema


text:
Allow module developers to specify that modules should be hard to edit/not editable

Third parties:

Parallax

Description
When distributing module files, eg for accessories like the cyber:bot, it's helpful to mark that the module should not be edited without careful thought.
In the V2 editor it wasn't actually possible to edit the files, so we could be introducing a new class of bug where students accidentally change modules that are really providing baked in functionality.
Todo

[ ] Choose the approach for limiting module editablility
[ ] Design it
[ ] Implement it.

Conclusion

This is live with an editor overlay and a setting to disable.
#848 will add a little more context to the setting.

Closed by https://github.com/microbit-foundation/python-editor-next/pull/815

authors: jaustin microbit-matt-hillsdon

repo: microbit-foundation/python-editor-next


text:
Russian translation

Update russian translation

Can you add this translation fix?


text:
IllegalStateException "Trying to close scope for span"

An IllegalStateException is thrown by a simple program. The error message reads: "Trying to close scope for span"
Spans reported to grafana/tempo have mixed up parent-child relationship (looks like the last span does not get closed and starts off as a new parent).
The issue was originally raised with reactor-core, as I observed the issue using reactor's contextCapture() / handle.
It turns out the issue can be reproduced independently from reactor (thanks  @chemicL).
Please see: https://github.com/reactor/reactor-core/issues/3354
To not duplicate, please see this ticket for all information including the reproducing code (in java or kotlin).
Expected Behavior
The following test should run successfully.
Actual Behavior
An IllegalStateException is thrown.
Traces reported to Grafana/Tempo show a wrong parent-child relationship.
Steps to Reproduce
Please see the linked issue for a clear reproducer.
Your Environment
openjdk 17
implementation("io.micrometer:micrometer-observation:1.10.4")
implementation("io.micrometer:context-propagation:1.0.2")
implementation("io.micrometer:micrometer-core:1.10.4")
testImplementation("io.micrometer:micrometer-test:1.10.4")
testImplementation("io.micrometer:micrometer-observation-test:1.10.4")
testImplementation("io.micrometer:micrometer-tracing-test:1.0.1")

Please note: There are recent bugfixes / releases in project reactor / micrometer-context-propagation. It is crucial to use the latest versions or different bugs will appear.

Updated the issue, removed project reactor as the bug can be reproduced independently.

Well this was quick. Thank you very much.

repo: micrometer-metrics/tracing


text:
ABAP SDK For Azure installation with 750 version

Hi, I tried to install ABAP SDK for AZURE for users version. after connecting to Online repo, the objects got pulled into system and see below error after all the objects were activated.
"Object type SUCU not supported, serialize import of object ZSDK S_TABU_DIS failed."
not sure of which functionality effected by not importing the above object. Could you please tell wat are the next steps to address it?

are you using the latest abapGit version?

are you using the latest abapGit version?

I followed the installation guide here.
https://docs.abapgit.org/guide-install.html
Install standalone version step1 - points to code for ZABAPGIT_STANDALONE - I opted this as i am not looking for developer version

I followed the installation guide here.
https://docs.abapgit.org/guide-install.html
Install standalone version step1 - points to code for ZABAPGIT_STANDALONE - I opted this as i am not looking for developer version

Any thoughts on how to resolve this one?

Any thoughts on how to resolve this one?

are you using the latest abapGit version? the version is listed in the bottom of each abapGit screen, please do a screenshot and paste it here,

are you using the latest abapGit version? the version is listed in the bottom of each abapGit screen, please do a screenshot and paste it here,

https://github.com/abapGit/abapGit

https://github.com/abapGit/abapGit

okay...
does the class zcl_abapgitp_object exist in your system?

okay...
does the class zcl_abapgitp_object exist in your system?

No, it doesnt.

No, it doesnt.

Any suggestions here?

Any suggestions here?

hmm, actually I get the same error,

hmm, actually I get the same error,

Ok, Are you planning to fix that, and how long it would take?
what functionality does this affect? Should I be able to prototype in SAP to the event hub with this error in place?

Ok, Are you planning to fix that, and how long it would take?
what functionality does this affect? Should I be able to prototype in SAP to the event hub with this error in place?

so, @microsoft has not updated https://github.com/microsoft/ABAP-SDK-for-Azure/blob/master/src/zadf/zsdk                          s_tabu_dis.sucu.xml to use the native abapGit SUCU handler
as raised as issue 2 years ago, https://github.com/microsoft/ABAP-SDK-for-Azure/issues?q=is%3Aissue+SUCU+is%3Aclosed
so, try installing https://github.com/abapGit/abapGit-Plugins to the local system

so, @microsoft has not updated https://github.com/microsoft/ABAP-SDK-for-Azure/blob/master/src/zadf/zsdk                          s_tabu_dis.sucu.xml to use the native abapGit SUCU handler
as raised as issue 2 years ago, https://github.com/microsoft/ABAP-SDK-for-Azure/issues?q=is%3Aissue+SUCU+is%3Aclosed
so, try installing https://github.com/abapGit/abapGit-Plugins to the local system

and notice that https://github.com/microsoft/ABAP-SDK-for-Azure/blob/master/src/zrest/zres                          s_tabu_dis.sucu.xml was updated to use the native SUCU handler
and https://github.com/microsoft/ABAP-SDK-for-Azure/blob/master/src/zadf/zsdk                          s_tabu_dis.sucu.xml uses the plugin
🤷♂

and notice that https://github.com/microsoft/ABAP-SDK-for-Azure/blob/master/src/zrest/zres                          s_tabu_dis.sucu.xml was updated to use the native SUCU handler
and https://github.com/microsoft/ABAP-SDK-for-Azure/blob/master/src/zadf/zsdk                          s_tabu_dis.sucu.xml uses the plugin
🤷♂

Installing developer version of gitclient and abapgit handlers resolved the above issue

authors: IndiraSomavarapu larshp

repo: microsoft/ABAP-SDK-for-Azure


text:
Publish to AppSource Library App

Im trying to publish to appsource a App that haves a dependency from other repo. It fails saying cannot find the dependency app.

In the /.AL-Go/settings.json i set the property "generateDependencyArtifact": true

But it seems only the main app get publish!?!
Dependency to projects '*' in https://github.com/xxxxxxx/yyyy@main, version latest, release status release
Azure.Storage Module is available in version 2.1.0
Using Azure.Storage version 2.1.0
Attempting authentication to *** using clientCredentials...
Authenticated as app ***
AppSource MainAppFolder .\MainApp
Main App File:
-MainApp_21.2.39.0.app
Library App Files:

None

The whole dependency handling when publishing to AppSource is not super great yet. We are currently publishing all apps to AppSource.

If you set generateDependencyArtifact to true in .AL-Go\settings.json - then the build should generate a dependency artifact and that should also be delivered to AppSource (for the apps, where the publisher name is the same as the main app)
If this doesn't work, please let me know.

I did that, seems that identifies both artifacts but keeps showing
Library App Files:

None

Would it be possible for me to get access to the repo in order to have a look at this?

@freddydk Sorry was in holidays. I will give access to the repo.
I saw that when the app creates the request in the appsource removes the Library app from the live version to the draft version.

Is this the reason?
"Make sure that these dependencies are part of your submission or that they have already been uploaded to AppSource and that they are available for the targeted country/region and release"
Do we need to submit the library app before? Isnt possible to uploaded in the same request?

if you set generateDependencyArtifact to true in .AL-Go/settings.json - it should include dependencies in the submission - else you need to submit the library app another way or beforehand

@freddydk i do that, i can see them getting downloaded but the Library Apps shows "None"
Downloading artifact xxxxxxxxxxx-main-Apps-1.4.49.0
https://api.github.com/repos/SK-Consulting-S-A/xxxxxxxxxxx/actions/artifacts/922653111/zip
D:\a\xxxxxxxxxxx\xxxxxxxxxxx.artifacts\xxxxxxxxxxx-main-Apps-1.4.49.0.zip
Analyzing artifacts
https://api.github.com/repos/SK-Consulting-S-A/xxxxxxxxxxx/actions/artifacts?per_page=100&page=1
project 'xxxxxxxxxxx'
**Downloading artifact xxxxxxxxxxx-main-Dependencies-1.4.49.0
https://api.github.com/repos/SK-Consulting-S-A/xxxxxxxxxxx/actions/artifacts/922653116/zip
D:\a\xxxxxxxxxxx\xxxxxxxxxxx.artifacts\xxxxxxxxxxx-main-Dependencies-1.4.49.0.zip
Artifacts:

xxxxxxxxxxx-main-Apps-1.4.49.0
xxxxxxxxxxx-main-Dependencies-1.4.49.0**
Applying settings from D:\a\xxxxxxxxxxx\xxxxxxxxxxx.github\AL-Go-Settings.json
Applying settings from D:\a\xxxxxxxxxxx\xxxxxxxxxxx.AL-Go\settings.json
Analyzing repository
Checking project dependencies
Azure.Storage Module is available in version 2.1.0
Using Azure.Storage version 2.1.0
Attempting authentication to https://api.partner.microsoft.com/.default using clientCredentials...
Authenticated as app ***
AppSource MainAppFolder Fisqal - xxxxxxxxxxx
Main App File:
SK Consulting S.A._Fisqal - xxxxxxxxxxx_22.3.49.0.app
Library App Files:
None

Hi @freddydk Did you got opportunity to check the repo?
I look on the Delivery.ps1 action looks for some reason the counter of the libraries app, always gives 0 "Empty".

A fix for this is currently in preview.
Same as #1093 and #1110

authors: freddydk jonaswre nixpt82

repo: microsoft/AL-Go


text:
Suggestion: support using const in DataItemLink (Query)

You should consider adding the option to specify a const in the DataItemLink.
As an example, the idea would mean being able to do this:
dataitem(Customer; Customer)
{
    // (...)

    dataitem(SalesPrice; "Sales Price")
    {
        DataItemLink = "Sales Code" = Customer."No.",
                       "Sales Type" = const ("Customer");
         // (...)
    }
}

Business Central frequently uses the pattern of having two fields for an external key (one to specify the table you are linking, another to specify the key). Ex: when configuring a Sales Price, you can choose whether it applies to a Customer, Customer Group or All Customers.
Now, let's say that I want to do a left outer join to that table, because I want two get all customers with a count of all salesprices assigned for the particular customer (among other customer related info).
That is currently impossible, as any dataitem query filters are added to the Where clause (and that automatically excludes all records where the join didn't find a Sales Price, transforming the outer join in an inner join equivalent).
I've tried to simplify the example, but in the last months I've been involved in several integrations between BC and external apps, that use OData to read data, and today marks the third time where a simple query has to be transformed into something much more complex (and less efficient) due to the fact that I had to link data against a table that used this pattern.

Makes sense. I do not remember what was the historical reason not supporting const here and some other places.

Hi @kalberes ,
Beside using a const as @salgiza  mentioned, we should also be able to add a filter as well.
See comment in issue: https://github.com/microsoft/AL/issues/4423#issuecomment-508080164
Kind regards,
Job Louage

Hi @kalberes ,
is there any progress on this issue? Seems quite important to be able to insert a const or a filter in the DataItemLink working with tables that are linked through "Source Type" like "Warehouse Shipment Line" fo example....
Thank you
Best regards
Matthias

No progress. You should add it as an idea,  gather some votes and than it will be considered.

I might not have searched exhaustively, but didn't find an Idea yet, only this, which mentions it indirectly:
Allow Queries to link to setup tables

This could be achieved by allowing the DataItemLink to be of the format DataItemLink = "Primary Key" = Const('');

It would indeed be good to have this (generally; I don't specifically care about setup tables).
So, I've created the Idea, for everyone to go and upvote please:

Support using const or filter in Query DataItemLink property, equivalent to including constant value(s) in SQL JOIN

Daniel reposted this on https://aka.ms/bcideas, where it will be tracked going forward, thus closing this entry. Please continue voting on the ideas site.
https://experience.dynamics.com/ideas/idea/?ideaid=fc893249-7841-ec11-a3ee-0003ff45ebbf

authors: dnpb kalberes louagej matthiasbier pborring salgiza

repo: microsoft/AL


text:
[META] Wrong method to get BC version info

When reporting a bug here, there's in the comment of Versions::
-- In the client search for: System Information --

Business Central:

But searching for that, gives no results...
The BC info is moved to the '?' , Help and Support -> troubleshooting tab.

Thanks @SirBETE ! We will update the templates.

authors: SirBETE atoader


text:
Menu command Menu -> Run -> Start Debugging F5 does not work to update / publish to Business Central Sandbox

Describe the bug
Menu command Menu -> Run -> Start Debugging F5 does not work to update / publish to Business Central Sandbox. Restart debug icon does not work.
To Reproduce
Steps and to reproduce the behavior:
First, start with:
Ctrl + Shift + P
AL: GO!
Basic Hello World message app.
HelloWorld.al
launch.json
environmentName: changed to my sandbox environment name
app.json -> change:
"platform": "17.0.0.0",
"application": "17.0.16993.0"
Symbols are downloaded.
F5
DEBUG CONSOLE shows Success -> app is published
sandbox browser tab launches -> see "Hello world" message
Then, make change to HelloWorld.al "Hello world" -> "Hello Big AL World!"
Menu -> Run -> Start Debugging F5
DEBUG CONSOLE shows Success -> app is published
sandbox browser tab launches -> see "Hello world" message  (no change, not "Hello Big AL World!")
If I use either the actual keyboard press (F5)
OR
Ctrl + Shift + P
AL: Publish with debugging F5 recently used (return to select)
Then will always get any change to the HelloWorld.al -> sandbox browser tab launches
(again, Menu -> Run -> Start Debugging F5 never effects the change)
Similarly, the  Restart icon (Cntrl + Shift + F5) does not work. The DEBUG CONSOLE is cleared, but no Restart.
Pressing the keys Cntrl + Shift + F5 produces warning: There is already a debug configuration "Microsoft cloud sandbox" running.
The Stop (Shift F5) icon works and  pressing the keys Shift F5 does show Warning: Timeout after 2000 ms for 'terminate') but pressing the keys Shift F5 still requires to hit the Stop (Shift F5) icon to remove the Debug icons from it the interface.
AL Code to reproduce the issue
I initially thought it may be a key-binding issue. On laptop needed to use Fn F5. Then changed in BIOS to default to "F-key behavior). No change in outcome.
Disabled all extensions - re-enabled  AL Language extension. No change in outcome.
Expected behavior
Menu -> Run -> Start Debugging F5 should have the same result as pressing F5.
The Restart debugging icon should restart the debugging process.
Pressing  Shift F5 should terminate the sessions and remove the debugging icons from the interface.
Screenshots
If applicable, add screenshots to help explain your problem.

5. Versions:

AL Language:
AL Language, ms-dynamics-smb.al, Microsoft, License v6.1.359074
AL development tools for Dynamics 365 Business Central

VSC Version: 1.50.1 (user setup)
Commit: d2e414d9e4239a252d1ab117bd7067f125afd80a
Date: 2020-10-13T15:06:15.712Z
Electron: 9.2.1
Chrome: 83.0.4103.122
Node.js: 12.14.1
V8: 8.3.110.13-electron.0
OS: Windows_NT x64 10.0.18363

Business Central: Sandbox
"platform": "17.0.0.0",
"application": "17.0.16993.0"

There is a bit of misdirection on the default VsCode menu here.
If you use the menu or debug icon
that will  start a debugging session without publishing equivalent with "Debug without Publishing".
We will try to see if we can rename the built-in VsCode menu text, with the confusing F5 since it should Shift Ctrl F5 for us.   F5 in the AL language server is "publish and debug". The functionality is by design for now.
Also restarting a debugging session is not implemented at all. Thus that is a missing functionality. If there is a demand for it I suggest creating a request here:

I had the same issue.
Go to Keyboard short cuts  and type the letter and number   F5
this will show all the bindings.
I had a "run task" assigned to F5, once I removed it, then F5 starts debugging.

authors: apaGitHub danocharron kalberes


text:
AsDecimal() in TestPage does not work for empty value

1. Describe the bug
If i have a field in a testpage with an empty value and i want to convert the value into a decimal value with AsDecimal() function an error occurs "Input string was not in a correct format".
2. To Reproduce
write code in a test codeunit with a testpage and a field with an empty value:
ExampleTestPage.Field3.AsDecimal()

3. Expected behavior
I would expect that the value "0" as return value. (As in older versions <BC20.3)
4. Actual behavior
An error is occurring with message: "Input string was not in a correct format"
5. Versions:

AL Language: 9.3.646020
Visual Studio Code: 1.69.1
Business Central: 20.3.42673.43026

Hi, could you provide a test page and a test codeunit that makes the error occur? This would help in trying to reproduce the problem. Thanks

This issue has been closed because it needs more information and has not had recent activity. Please open a new issue if you believe this has not been resolved and reference the current issue.

authors: pschwambornMC sergiudina


text:
[EventRequest] Page 5052 "Contact List".UpdateContactBusinessRelationOnContacts

Please add event
local procedure UpdateContactBusinessRelationOnContacts()
var
    ContactToUpdate: Record Contact;
    ContactRec: Record Contact;
    ContactBusinessRelation: Enum "Contact Business Relation";
    //-------------------------------OnBeforeUpdateContactBusinessRelationOnContacts:BEGIN
    IsHandled: Boolean;
    //-------------------------------OnBeforeUpdateContactBusinessRelationOnContacts:END
begin
    //-------------------------------OnBeforeUpdateContactBusinessRelationOnContacts:BEGIN
    OnBeforeUpdateContactBusinessRelationOnContacts(IsHandled);
    if IsHandled then
        exit;
    //-------------------------------OnBeforeUpdateContactBusinessRelationOnContacts:END

    ContactRec.SetRange("Contact Business Relation", ContactBusinessRelation::" ");
    if ContactRec.IsEmpty() then
        exit;

    ContactRec.FindSet();
    repeat
        ContactToUpdate.Get(ContactRec."No.");
        if (ContactToUpdate.UpdateBusinessRelation()) then
            ContactToUpdate.Modify();
    until ContactRec.Next() = 0;
end;

[IntegrationEvent(false,false)]
local procedure OnBeforeUpdateContactBusinessRelationOnContacts(var IsHandled: Boolean)
begin
end;

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.
Build ID: 41251.

repo: microsoft/ALAppExtensions


text:
[Access Request] page 973 "Time Sheet Card" FilterAllLines

Could you please update the scope of the procedure FilterAllLines to at least protected?
//+Change
//-local procedure FilterAllLines(var TimeSheetLine: Record "Time Sheet Line"; ActionType: Option Submit,ReopenSubmitted,Approve,ReopenApproved,Reject)
protected procedure FilterAllLines(var TimeSheetLine: Record "Time Sheet Line"; ActionType: Option Submit,ReopenSubmitted,Approve,ReopenApproved,Reject)
//-Change
begin
    TimeSheetLine.SetRange("Time Sheet No.", "No.");
    TimeSheetMgt.FilterAllTimeSheetLines(TimeSheetLine, ActionType);
end;

Was fixed in version 22.

authors: JesperSchulz pri-kise


text:
Error to print trial balance business central version 21.0.46256.46853 report 6

Hello,
when I try to print a trial balance, with balance at date <>0 as filter, the error appear:
The supplied column ID '34' cannot be found in the query
Thanks,

Duplicate of https://github.com/microsoft/AL/issues/7224 but I don't think it's on-topic at either location. As a runtime/platform/application issue, it should be reported to MS via Support/Partner, not on GitHub.

Please report bugs via Support/Partner, GitHub is for extensibility issues only. This particular issue is already reported, and fix is in progress.

authors: AlexanderYakunin VeronicaGoglia dnpb


text:
[Event Request] codeunit 8612 "Config. Template Management" - multiple publishers

Hello, would it be possible to add OnInsertRecordWithKeyFieldsBeforeValidateFieldValue, OnApplyTemplateLinesWithoutValidationBeforeValidateFieldValue events to codeunit 8612 "Config. Template Management", like this:
    local procedure InsertRecordWithKeyFields(var RecRef: RecordRef; ConfigTemplateHeader: Record "Config. Template Header")
...
          for KeyFieldCount := 1 to KeyRef.FieldCount do begin
             FieldRef := KeyRef.FieldIndex(KeyFieldCount);
             ConfigTemplateLine.SetRange("Field ID", FieldRef.Number);
             if ConfigTemplateLine.FindFirst() then begin
>                 OnInsertRecordWithKeyFieldsBeforeValidateFieldValue(ConfigTemplateHeader, ConfigTemplateLine);//New Event
                 ConfigValidateMgt.ValidateFieldValue(
                   RecRef, FieldRef, ConfigTemplateLine."Default Value", false, ConfigTemplateLine."Language ID")
             end else
                 if KeyRef.FieldCount <> 1 then

    procedure ApplyTemplateLinesWithoutValidation(ConfigTemplateHeader: Record "Config. Template Header"; var RecordRef: RecordRef)
...
              repeat
                 if ConfigTemplateLine.Type = ConfigTemplateLine.Type::Field then
                     if RecordRef.FieldExist(ConfigTemplateLine."Field ID") then begin
                         FieldRef := RecordRef.Field(ConfigTemplateLine."Field ID");
>                         OnApplyTemplateLinesWithoutValidationBeforeValidateFieldValue(ConfigTemplateHeader, ConfigTemplateLine);//New Event
                         ConfigValidateMgt.ValidateFieldValue(
                           RecordRef, FieldRef, ConfigTemplateLine."Default Value", true, ConfigTemplateLine."Language ID");
                         RecordRef.Modify(false);
                         OnApplyTemplLinesWithoutValidationAfterRecRefCheck(ConfigTemplateHeader, ConfigTemplateLine, RecordRef);

     [IntegrationEvent(false, false)]
     local procedure OnInsertRecordWithKeyFieldsBeforeValidateFieldValue(var ConfigTemplateHeader: Record "Config. Template Header"; var ConfigTemplateLine: Record "Config. Template Line")
     begin
     end;

     [IntegrationEvent(false, false)]
     local procedure OnApplyTemplateLinesWithoutValidationBeforeValidateFieldValue(var ConfigTemplateHeader: Record "Config. Template Header"; var ConfigTemplateLine: Record "Config. Template Line")
     begin
     end;

The purpose is to alter the value of ConfigTemplateLine."Default Value" depending on additional conditions before passing it to ConfigValidateMgt.ValidateFieldValue().

Changes done (today merged into master branch) as a part of the previous request (https://github.com/microsoft/ALAppExtensions/issues/22363) even it was marked as Closed.
I will close this one.

authors: AleksandricMarko alapenas


text:
[Bug]: Calculate the Aquisition cost using fixed asset journal preview post showing error

Describe the issue
Calculate the acquisition cost with negative quantity < total quantity.
When I try to post a preview it shows the following error message:
Error Message: Commit is prohibited in the current scope. the operation cannot continue. contact system administrator.
In report 5692 "Calculate Depreciation", there is trigger OnPostDataItem() where local variable NeedCommit is declared.
When we try to preivew then NeedCommit veriable is set True and Commit() will call. When commit() is called then error is thrown.
Expected behavior
When the post preview button is called, and everything is done right then Commit will be not called. So that the post-preview action is called without throwing an error.
Please make bellow changes in report 5692 "Calculate Depreciation" file:

Need to Add global variable:
Global Variable : SuppressCommit: Boolean;

Add procedure and pass the global variable.
procedure SetSuppressCommit(NewSuppressCommit: Boolean)
begin
SuppressCommit := NewSuppressCommit
end;

Need to add a condition in trigger OnPostDataItem()
if NeedCommit and (not SuppressCommit) then
Commit();

So that I will handle the error.
Steps to reproduce

Create 3 Multipart Fixed Assets with a Fa Cost Accounting Integration
Post acquisition cost with quantity for all on 01.01.2021
Post manually depreciation > acquisition cost for all on 31.01.2021 (book value negative)
Create 3 FA Journal lines with negative quantity < total quantity (and negative acquisition cost) with Depr. until FA Posting Date(Posting date and FA Posting date one year grate for date: 31.01.2021).
Try to preview post

Additional context
No response
I will provide a fix for a bug

[X] I will provide a fix for a bug

That might just be a product defect! Unfortunately, this repository is only for extensibility requests for Dynamics 365 Business Central or pull requests towards the 1st party Business Central apps. We suggest that you open a support case or file a bug to ensure that all Business Central users benefit from your catch as soon as possible:
On premises - https://support.microsoft.com/en-us/supportforbusiness/productselection?sapId=93d37907-ad94-d591-22e9-593cfa09dd3f
Cloud – contact your partner, or if you are a partner open a support incident through Partner Center - https://partner.microsoft.com/en-us/pcv/dashboard/overview


text:
[Event Request] Codeunit 7017 "Price List Management" OnBeforeResolveDuplicatePrices(PriceListHeader, DuplicatePriceList)

Describe the request
Function below throws a pop-up:
ResolveDuplicatePrices(PriceListHeader: Record "Price List Header"; var DuplicatePriceLine: Record "Duplicate Price Line") Resolved: Boolean
Requesting an event with handled boolean to handle the functionality with logic instead of popup
Additional context
In function
ResolveDuplicatePrices(PriceListHeader: Record "Price List Header"; var DuplicatePriceLine: Record "Duplicate Price Line") Resolved: Boolean
Have an event OnBeforeResolveDuplicatePrices(PriceListHeader, DuplicatePriceList, handled, resolved)
if handled then exit(resolved)
Internal work item: AB#504228

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.
Build ID: 17376.

authors: AbsolutelyFreeWeb JesperSchulz


text:
[Event Request] Table 5741 Transfer Line OnBeforeCheckItemAvailable

[External] CheckItemAvailable(CalledByFieldNo : Integer)
//>NEW CODE
IsHandled := FALSE;
OnBeforeCheckItemAvailable(Rec,CalledByFieldNo,IsHandled,CurrFieldNo);
IF IsHandled THEN
EXIT;
//<NEW CODE

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability.

authors: aconcato bc-ghost


text:
[Event Request] Page 306 Report Selection - Sales - OnSetUsageFilter

Hi Team,
In Page 306 we need possibility to have our additional checks with the case scenario. Having event in the end of procedure SetUsageFilter in the else state, would be a perfect solution :

[IntegrationEvent(false, false)]
local procedure OnSetUsageFilter(var ReportSelections: Record "Report Selections"; ReportUsage2: Option Quote,"Blanket Order","Order",Invoice,"Work Order","Return Order","Credit Memo",Shipment,"Return Receipt","Sales Document - Test","Prepayment Document - Test","Archived Quote","Archived Order","Archived Return Order","Pick Instruction","Customer Statement","Draft Invoice","Pro Forma Invoice","Archived Blanket Order",,"Proforma Invoice","Proforma Shipment",,,,,,,,,,,,,,,,,,,,,,"C.Statement","V.Remittance")

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability.

authors: MantasGurinas bc-ghost


text:
[Event Request] codeunit 99000815 "Reservation-Check Date Confl.": DateConflict

Object: codeunit 99000815 "Reservation-Check Date Confl."
Function: DateConflict
Integration Event:
OnBeforeDateConflict(var Date: Date);

It's very important that the Date is var!

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability.

authors: TimCsr bc-ghost


text:
Add property for specifying card dimensions

The Problem
Currently, there is no way for a card author to specify that they would like their markup to be rendered at a fixed 1) height, 2) width, or 3) aspect ratio. This is a limitation for Bing API cards, which are designed to have a fixed aspect ratio, and it may be an issue for others as well.
Potential Design
Add a top-level field such as dimensions to the AdaptiveCard schema. It's still an open question as to what the structure of this field should be -- do we want to allow authors control over exact height and width, or perhaps only aspect ratio? We'll also need to figure out what format we want these values specified as.
{
    "$schema": "http://adaptivecards.io/schemas/adaptive-card.json",
    "type": "AdaptiveCard",
    "version": "1.x",
    "dimensions": {
        "height": "150px",  // Should we allow this?
        "width": "285px"
    }
    "body": [
       ...
    ]
}

{
    "$schema": "http://adaptivecards.io/schemas/adaptive-card.json",
    "type": "AdaptiveCard",
    "version": "1.x",
    "dimensions": {
        "aspectRatio": 1.9 // Or we could do something like "16:9"
    }
    "body": [
        ...
    ]
}

Suggestion for aspectRatio: number instead of string to keep the implementation straightforward.

This is a good suggestion, but not something that's on our roadmap at this time. We may reconsider it in the future, or if you would like to make a contribution please see our contribution guidelines here.

authors: RebeccaAnne nuevocampo tongyliu

repo: microsoft/AdaptiveCards


text:
[Designer- Publish Adaptive Card Schema]: On activating 'Set due date' Narrator announces all the information present under the 'Set due date' field at once under 'Publish Adaptive Card Schema'.

https://microsoft.visualstudio.com/OS/_workitems/edit/37777384

Hi @anna-dingler,
Could you please let us know update regarding this issue fixing as of now this issue is still repro.
Test Environment:
URL: https://adaptivecards.io/
OS Version: Dev( Build 26002.1000)
Browser: Edge Dev( 121.0.2277.4)
Screen reader: Narrator
Repro steps:

Press Ctrl+ Windows+ Enter key to turn on the Narrator.

2.Launch the above URL in edge dev browser and login with v- credentials.
3. Navigate to 'Designer' link through tab key under the header controls and activate it.
4. Navigate to the 'Set Due date' control under 'Publish Adaptive Card Schema' card and activate it.

Verify that on activating 'Set due date' control Narrator announces all the information present under the 'Set Due Date' edit field or not.

Actual Result:
On activating 'Set due date' Narrator announces all the information present under the 'Set due date' field at once under 'Publish Adaptive Card Schema'.
Expected Result:
On activating 'Set due date' Narrator should not announce all the information present under the 'Set due date' field at once under 'Publish Adaptive Card Schema'. It should only announce as 'Set due date' menu item expanded 1 of 2'
Observation:
Issue does not repro with NVDA.
User Experience:
Screen reader user will get impacted if Narrator start reading all the information at once due to which user will not be able to clearly understand the purpose of the control and will not be able to track the content properly.
MAS Reference Link:
Info and Relationships - Liquid (microsoft.com)
"Have feedback to share on Bugs ? Please help fill Trusted Tester Bug Feedback (office.com) “,

authors: carlos-zamora vagpt


text:
[Designer] Copying card payload does not include templating expressions

Problem Description
When copying the card payload, the copied payload does not include any templating expressions. Instead, the expressions are replaced with the appropriate data.
Proposed solution
Template expansion should not be applied when copying the payload.
Card JSON
{
    "type": "AdaptiveCard",
    "body": [
        {
            "type": "TextBlock",
            "size": "Medium",
            "weight": "Bolder",
            "text": "${title}"
        }
    ],
    "$schema": "http://adaptivecards.io/schemas/adaptive-card.json",
    "version": "1.5"
}

Card data
{
    "title": "Publish Adaptive Card Schema"
}

Copied payload
{
    "type": "AdaptiveCard",
    "body": [
        {
            "type": "TextBlock",
            "size": "Medium",
            "weight": "Bolder",
            "text": "Publish Adaptive Card Schema"
        }
    ],
    "$schema": "http://adaptivecards.io/schemas/adaptive-card.json",
    "version": "1.5"
}

Screenshot
No response

by design - as discussed in triage, this is an intentional convenience feature (see the button's tooltip). we should consider adding some functionality around making copying the unbound template/data easier for the user, but I don't think it's on our radar at the moment (feel free to file) :)


text:
Azure Service Bus dependency messages have no context

Hi,
We're using AI to track our app, and everything works as expected except service-bus messages.
We have http endpoint which receives a request, then sends a message on the service bus.
All the logs in this function and http/s requests have the same context in the AI as the incoming http request, but the service-bus outgoing message looks like a stand-alone dependency without a parent and context.
Should I add something manually to the ServiceBusClient.send call? Is it a bug?
I can give you a small script to reproduce + screenshots from our AI UI.  (edit: code and screenshots attached)
Thanks!

@hectorhdzg ping

Code example:
const appInsights = require('applicationinsights');
const express = require('express');
const axios = require('axios');
const {ServiceBusClient} = require('@azure/service-bus');
const WebSocket = require('ws');

appInsights.setup()
    .setAutoCollectConsole(true, true)
    .setSendLiveMetrics(true)
    .start();

const connectionString = "******";
const sender = new ServiceBusClient(connectionString, {webSocketOptions: { webSocket: WebSocket }}).createSender('bivas-test');
const app = express();
app.post('/sendMessage', async (_req, res) => {
    console.log('log');
    await axios.default.get('https://google.com');
    console.log('log 2');
    await sender.sendMessages({subject: 'subject', body: {key:'value'}});
    res.sendStatus(200);
});

app.listen(3080, '0.0.0.0', () => {console.log('started')});

This is a snippet from Azure portal if I clicked the 'get to Google' dependency:

And this is what I see if I clicked the 'ServiceBus Message' dependency:

Thanks.

Thank you @hectorhdzg. Do you plan to publish a new release soon?

@orgads we plan to release early next week

Hi @hectorhdzg
I tried to run the example app from above with your fix in it, and the rest request doesn't hold the service-bus message as dependency, In addition, now the service-bus messages not shown at all in the AI UI.
Can you check it?
Thanks
cc: @orgads

@hectorhdzg 7.4.0

@bivas6, @orgads , I can see everything working fine with exact same code you shared and using @azure/service-bus 7.4.0, validated using a tarball generated from develop branch

I just tried again now, and it doesn't work for me.
I tried Node 16.13 and 17.4, both on Windows.
That's what I get:

@orgads do you have any OpenTelemetry package as dependency in your project?

No. I have only the packages that I require directly. What else should I install?

hmmm... I tried on Linux now with Node 17.4.0, and it does show the send message request, but it is still not connected to the http request:

Sorry, these tests on linux were with version 2.2.0. With latest develop it's the same as on Windows (no ServiceBus at all).
This is my package.json (I published my own package from develop):
{
  "name": "servicebus",
  "version": "1.0.0",
  "main": "servicebus.js",
  "scripts": {
    "test": "echo \"Error: no test specified\" && exit 1"
  },
  "keywords": [],
  "author": "",
  "license": "ISC",
  "description": "",
  "dependencies": {
    "@azure/service-bus": "^7.4.0",
    "applicationinsights": "npm:@audc/applicationinsights@^2.3.0",
    "axios": "^0.25.0",
    "express": "^4.17.2",
    "ws": "^8.4.2"
  }
}

@hectorhdzg were you able to reproduce? Can I provide you any more information?

@orgads still no repro on my side, can you try with latest version of Application Insights SDK?, we published yesterday, can you turn logging and share the logs if you still have the problem?

authors: bivas6 hectorhdzg orgads


text:
For Mac: screen will turn black and have to close the app.

Creating new folder or deleting file gives out full screen confirmation dialog and then turns black.

Can you be a little more specific?
Which version of Storage Explorer?  Which version of Mac OS?
Is this for Blob? File Shares?  ADLS Gen2 account?  or something else?
Does this happen to other dialog or just these two?

Hi @jinglouMSFT We also met this issue.
Platforms: MacOs 10.13.6
Repro Steps:

Launch Storage Explorer -> Make it full screen.
Execute an action to open one dialog.
Select and click one button on the prompt dialog.
Check the result.

Actual:
The screen turns black.

Can you be a little more specific?
Which version of Storage Explorer?
Version: 1.10.1
AzCopy Version: 10.2.1

Platform: macOS
Architecture: x64
Build Number: 20190919.2
Commit: 868c6dff1
Support ID: e6a2b7fc-8e8c-88ba-2db7-d8fce1f406cb

Which version of Mac OS?
Mac OS Catalina 10.15.1 ,

Is this for Blob? File Shares? ADLS Gen2 account? or something else?
Blob, gen2

Does this happen to other dialog or just these two?
So far these two, not always but most of the times.

@amtsha09 great bug find. None of us have ever noticed this. For now, you'll need to not run in full screen, but we'll look into getting this fixed.

@MRayermannMSFT happy to help :-)
Thanks.

Fix merged into master. Will ship with 1.13.0. Thank you again @amtsha09

authors: MRayermannMSFT amtsha09 jinglouMSFT v-xianya

repo: microsoft/AzureStorageExplorer


text:
Miss '.' in the waning message on the 'Clone Blob Container with New Name' dialog

Storage Explorer Version: 1.26.0-dev
Build Number: 20220927.1
Branch: main
Platform/OS: Windows 10/Linux Ubuntu 22.04/MacOS Monterey 12.6 (Apple M1 Pro)
Architecture: ia32/x64
How Found: From running test cases
Regression From: Not a regression
Steps to Reproduce

Expand one storage account -> Blob Containers.
Select one blob container and right click it.
Click 'Clone...' -> Empty the 'New name' field.
Observe the warning message.
Check no missed '.'.

Expected Experience
No '.' is missed.
The screenshot of file shares:

Actual Experience
'.' is missed in the warning message.

Verified this issue on the main build 20221008.3. Reproduce. Will verify this issue on a newer build.

Verified this issue on the build main/20221014.6. Fixed. So, we are going to close it.


text:
Add speak tags to EchoBots

Proposed Changes

Add Speak field to outgoing activities in echo-bots.

Testing
Manually tested the bot with Direct Line Speech.

@dargilco and @splumber can you check in on this?

Thanks, looks great!

authors: dargilco stevengum

repo: microsoft/BotBuilder-Samples


text:
"Done" button after "adding property"

will investigtate for 1.4.

repo: microsoft/BotFramework-Composer


text:
fix: generate friendlier project names from new long package names.

Description
this applies a similar heuristic used by the server to generate pretty names for the project name based on the package name.
@microsoft/generator-microsoft-bot-conversational-core becomes "conversational_core"
this should preserve the current naming behavior, but apply it to the new flows.
Task Item
fixes #5948
fixes #5987
Screenshots

Coverage decreased (-0.01%) to 53.79% when pulling ccbb5f6833ecd64b5b80433755b066478195239d on benbrown/createstatus into beb19b89912e848c9d8db7d00d5d541b43bd420b on main.

authors: benbrown coveralls


text:
Adaptive Cards on Slack not available after 24hours

Version
C# with Bot Framework SDK v4.13 (and .NET Adaptive Cards v2.7.0)
Describe the bug
When using the bot framework and connect it to a slack channel, bot sent adaptive cards get automatically transformed to images (which is fine!) and displayed correctly in chats.
Those images sadly are NOT available after 24hours, leaving an empty image (see screenshot below).
To Reproduce
Steps to reproduce the behavior:

Use bot framework sdk and sent an adaptive card json (e.g. on OnMessageActivityAsync)
Publish on Azure/Configure slack channel
Add bot to slack chat
Trigger bot to send adaptive card on a slack chat
Adaptive card is rendered correctly as image (it's an url to https://slack.botframework.com/v3/attachments/<id>/views/original)
After some time (~24h) the image is not available anymore, showing an not found image (see screenshot below)

Expected behavior
Sent adaptive card images should stay or uploaded directly to slack.
Screenshots

This by-design.  The images are uploaded to the temporary attachment cache which has a ttl of ~24hrs.  It may be possible to upload them directly to Slack but that would require a design change and need to be costed.

authors: craigjensen d-bauer

repo: microsoft/BotFramework-Services


text:
[Tracking] DLSpeech: Proactive message is not supported

If you would want to prioritize this feature work, please vote and optionally, provide a user story.

Feature Request
Proactive message is not supported when using Direct Line Speech.
[Enhancement]

We have achieved this by keeping a reference of the ConnectorClient from the turnState and putting it back into the state in the continue conversation callback. Without the original connector client, there is an error from node-fetch as the service URL in the activity is not an HTTP URI.
@corinagum please suggest if there could be any pitfalls in this approach.

Hi @birla, I am no longer a member of the Web Chat team. Please get in contact with @compulim

We have achieved this by keeping a reference of the ConnectorClient from the turnState and putting it back into the state in the continue conversation callback. Without the original connector client, there is an error from node-fetch as the service URL in the activity is not an HTTP URI.
@corinagum please suggest if there could be any pitfalls in this approach.

@compulim Please have a look. I can share some sample code, if required.

authors: birla compulim corinagum

repo: microsoft/BotFramework-WebChat


text:
Clear suggested-actions on button click

Fixes #2160
Changelog Entry
Fix #2160. Clear suggested-actions after button click, by @tdurnford in PR #2189
Specific Changes
Called the setSuggestedActions function in the suggested action's onClick method to clear the suggested actions bar.

[x] Testing Added

Coverage increased (+0.2%) to 63.483% when pulling 4924ab12cf051c06eeaec39072ab987fd8cc6b8e on tdurnford:2160 into 8c8679e90fe9babaf7c356e873af2734e9578a4d on microsoft:master.

rebuilding due to timeout

authors: corinagum coveralls tdurnford


text:
Unable to start dockerd on Mariner VM

I am getting the following error when I try to start dockerd on the VM created using Mariner.
INFO[2022-12-02T23:37:25.631314721Z] Loading containers: start.
WARN[2022-12-02T23:37:25.632681458Z] Running modprobe bridge br_netfilter failed with message: modprobe: WARNING: Module bridge not found in directory /lib/modules/5.15.77.1-1.cm2
modprobe: WARNING: Module br_netfilter not found in directory /lib/modules/5.15.77.1-1.cm2
, error: exit status 1
WARN[2022-12-02T23:37:25.673436458Z] Could not load necessary modules for IPSEC rules: protocol not supported
WARN[2022-12-02T23:37:25.675194205Z] Could not load necessary modules for Conntrack: Running modprobe nf_conntrack failed with message: `modprobe: WARNING: Module nf_conntrack not found in directory /lib/modules/5.15.77.1-1.cm2`, error: exit status 1
INFO[2022-12-02T23:37:25.675373210Z] Default bridge (docker0) is assigned with an IP address 172.17.0.0/16. Daemon option --bip can be used to set a preferred IP address
INFO[2022-12-02T23:37:25.682590505Z] stopping event stream following graceful shutdown  error="context canceled" module=libcontainerd namespace=moby
INFO[2022-12-02T23:37:25.682639206Z] stopping healthcheck following graceful shutdown  module=libcontainerd
INFO[2022-12-02T23:37:25.682691108Z] stopping event stream following graceful shutdown  error="context canceled" module=libcontainerd namespace=plugins.moby
WARN[2022-12-02T23:37:26.683350114Z] grpc: addrConn.createTransport failed to connect to {unix:///var/run/docker/containerd/containerd.sock  <nil> 0 <nil>}. Err :connection error: desc = "transport: Error while dialing dial unix:///var/run/docker/containerd/containerd.sock: timeout". Reconnecting...  module=grpc
failed to start daemon: Error initializing network controller: Error creating default "bridge" network: Failed to Setup IP tables: Unable to enable NAT rule:  (iptables failed: iptables --wait -t nat -I POSTROUTING -s 172.17.0.0/16 ! -o docker0 -j MASQUERADE: iptables v1.8.7 (legacy): Couldn't load target `MASQUERADE':No such file or directory

VM image details:
"imageReference": {
"publisher": "MicrosoftCBLMariner",
"offer": "cbl-mariner",
"sku": "cbl-mariner-2",
"version": "latest",
"exactVersion": "2.20221110.01"
},
Moby details:
tdnf list installed | grep moby
moby-cli.x86_64                             20.10.12-4.cm2           @System
moby-containerd.x86_64                      1.6.6-3.cm2              @System
moby-engine.x86_64                          20.10.14-2.cm2           @System
moby-runc.x86_64                            1.1.2-4.cm2              @System
Am I missing anything?

I was able to get it to work after commenting the following line in /lib/systemd/system/containerd.service
#ExecStartPre=/sbin/modprobe overlay

This was added yesterday to the WSL documentation - Intro | Mariner OS (eng.ms)
However I had to do that for the VM as well. Something to note.

Comment the modprobe cmd is specific to WSL only. In a VM context, it is working out of the box.
@savaradh and I had a quick call and it is now working without modifying the containerd systemd service unit.

authors: eric-desrochers savaradh

repo: microsoft/CBL-Mariner


text:
[dev] Enable cni in Mariner

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

[x] The toolchain has been rebuilt successfully (or no changes were made to it)
[x] The toolchain/worker package manifests are up-to-date
[x] Any updated packages successfully build (or no packages were changed)
[x] Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
[x] All package sources are available
[x] cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/tools/cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
[x] LICENSE-MAP files are up-to-date (./SPECS/LICENSES-AND-NOTICES/data/licenses.json, ./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md, ./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)
[x] All source files have up-to-date hashes in the *.signatures.json files
[x] sudo make go-tidy-all and sudo make go-test-coverage pass
[x] Documentation has been updated to match any changes to the build system
[x] Ready to merge

Summary

What does the PR accomplish, why was it needed?

Enable cni and its dependency fillup to build in Mariner
Rename the pre-existing cni package to cni-plugins
Change dependencies on cni to cni-plugins

Change Log

cni:

Initial CBL-Mariner import from OpenSUSE Tumbleweed
License Verified
Remove shadow from BR
Use systemd and fillup from runtime requirements
Manually define fillup-related macros
Remove buildroot definition

cni-plugins:

Rename to cni-plugins
Upgrade to version 0.8.1

fillup:

Initial CBL-Mariner import from OpenSUSE Tumbleweed
License Verified
Update Source0 URL path
Manually create BIN and OBJ folder to build the project
Remove symbolic link on fillup

kubernetes:

Use cni-plugins as runtime requirement

Does this affect the toolchain?

NO
Associated issues

#xxxx

Links to CVEs

https://nvd.nist.gov/vuln/detail/CVE-YYYY-XXXX

Test Methodology

Local Build

Hi Henry,
this PR will conflict with the golang PR (upgrade to version 1.16.7). I had to bump cni version and rework the spec file because cni does not build with golang 1.16.7.
Could we sync up on this ?

Hi Henry,
this PR will conflict with the golang PR (upgrade to version 1.16.7). I had to bump cni version and rework the spec file because cni does not build with golang 1.16.7.
I upgrade cni to version 0.9.1 and use linux_build.sh script to build (this script is part of the source tarball)
Could we sync up on this ?


text:
HealthChecker (Any/Version 22.10.04.1840) won't excute /hangs

Hi Team,
The script won't execute. Only debug (see) file is generated. The script worked prior to extended protection (Version 22.08.29.1954). Didn't do a roll back or not sure if this has anything to do with  it. No clues in the  event-logs.  Any help is appreciated. Thank you :)

Script is unblocked after downloading
Execution Policy is set to bypass/unrestricted in process scope.
Is run as admin
Is not in Select mode
Tried old versions of the script
?
"
Starting Logger Instance 10/05/2022 15:03:02
Calling: Confirm-ExchangeShell
Passed: LoadExchangeShell: True | Identity: xx
Exchange PowerShell Module already loaded.
Script Executing on Server xx
ToolsOnly: False | RemoteShell False
""

Server: 2016 CU23

What works:
-LoadBalancingReport
-MailboxReport
--
https://microsoft.github.io/CSS-Exchange/Security/Extended-Protection/
https://microsoft.github.io/CSS-Exchange/Diagnostics/HealthChecker/

Running with -Verbose might show what it's waiting for.

Thanks Bill!. The script was trying to perform auto-update.  -SkipVersionCheck  was the solution since internet connectivity is blocked on the servers :)

authors: abassharif bill-long

repo: microsoft/CSS-Exchange