text:
Old golang kafka source did not require type secretKeyRef for SASL but seems to require now?

Describe the bug
Old golang kafka source did not require type secretKeyRef for SASL but seems to require now?
Expected behavior
Existing kafka source should work without changes
To Reproduce
Example Kafka Source that worked before:
apiVersion: sources.knative.dev/v1beta1
kind: KafkaSource
metadata:
  name: kafka-es10
spec:
  consumerGroup: kafkaes10j27c
  bootstrapServers:
  - kafka-1.mh-lbnyvywmvwwvpcmssqgl-4c201a12d7add7c99d2b22e361c6f175-0000.us-south.containers.appdomain.cloud:9093
  topics:
  - e2et10
  net:
    sasl:
      enable: true
      user:
        secretKeyRef:
          name: kafka-secret-es
          key: user
      password:
        secretKeyRef:
          name: kafka-secret-es
          key: password
    tls:
      enable: true
  sink:
    ref:
      apiVersion: v1
      kind: Service
      name: hello-display

With this YAML setup I got no events - I saw in kafka data-plane logs:
{"@timestamp":"2022-04-21T18:44:04.623Z","@version":"1","message":"Failed to reconcile [onNewEgress] egress  id=077c039a-34fb-4a51-a214-94298dd06f5b consumerGroup=kafkaes10j27c destination=http://hello-display.k9.svc.cluster.local/","logger_name":"dev.knative.eventing.kafka.broker.core.reconciler.impl.ResourcesReconcilerImpl","thread_name":"vert.x-eventloop-thread-0","level":"ERROR","level_value":40000,"stack_trace":"io.vertx.core.impl.NoStackTraceThrowable: Security protocol SASL_SSL: invalid SASL mechanism, expected SCRAM-SHA-256, SCRAM-SHA-512 or PLAIN got null\n","id":"077c039a-34fb-4a51-a214-94298dd06f5b","consumerGroup":"kafkaes10j27c","destination":"http://hello-display.k9.svc.cluster.local/"}

Kafak source status was showing OK:
k get kafkasources.sources.knative.dev ; date
NAME             TOPICS           BOOTSTRAPSERVERS                                                                                READY   REASON   AGE
kafka-es10       ["e2et10"]       ["kafka-1.mh-lbnyvywmvwwvpcmssqgl-4c201a12d7add7c99d2b22e361c6f175-0000.us-south.containers.appdomain.cloud:9093"]      True             3h15m

After adding type to Kafka source I have got all events in hello-display sink:
      type:
        secretKeyRef:
          name: kafka-secret-es
          key: type

Knative release version
1.4 with V2
Additional context
Add any other context about the problem here such as proposed priority

@aslom Yeah, I think what I saw is similar. With the new eventing-kafka-broker, we are required to add an additional field:
type:
        secretKeyRef:
          name: kafka-secret-es
          key: type

And we also need to create one more field in the referenced secret. This was not required on our old CR. The error message I saw was a little different though. The error I saw was something like this.
[protocol SASL_SSL] key sasl.mechanism is required.

what's the default SASL type for the old KafkaSource?
/area source
/triage accepted
/area control-plane

When I used PLAIN it worked for the same Kafka topic I tested with old Kafka source. I created type using
kubectl create secret generic kafka-secret-es --from-literal=type=PLAIN ....

It seems PLAIN type was already assumed in control plane?
@aavarghese @lionelvillard do you remember what was default in MT Kafka Source?

@aslom  plain is the assumed default on "old" kafka source:
https://github.com/knative-sandbox/eventing-kafka/blob/main/pkg/common/config/util.go#L94-L99

We could do similar here, I guess:

/assign @aslom

I started working on it. Doing quick fix and testing.

It seems hat the simplest fix will be to change KubernetesCredentials to use PLAIN for SASLMechanism when not specified
    if (SASLMechanism == null) {
      final var SASLMechanism = secret.getData().get(SASL_MECHANISM);
      if (SASLMechanism == null) {
        this.SASLMechanism  = "PLAIN"; //default when not specified
      } else {
        this.SASLMechanism = switch (new String(Base64.getDecoder().decode(SASLMechanism))) {
          case "PLAIN" -> "PLAIN";
          case "SCRAM-SHA-256" -> "SCRAM-SHA-256";
          case "SCRAM-SHA-512" -> "SCRAM-SHA-512";
          default -> null;
        };
      }
    }

in https://github.com/knative-sandbox/eventing-kafka-broker/blob/37a71c271216951196c752bcf906acc45f4431ad/data-plane/core/src/main/java/dev/knative/eventing/kafka/broker/core/security/KubernetesCredentials.java#L157
Going to deploy and test it

After testing the fix I described above I also saw the problem that @steven0711dong noticed I think:
{"level":"error","ts":"2022-04-28T18:55:43.169Z","logger":"kafka-broker-controller","caller":"kafkasource/reconciler.go:302","msg":"Returned an error","knative.dev/pod":"kafka-controller-5b744bd98b-x46hs","knative.dev/controller":"knative.dev.eventing-kafka-broker.control-plane.pkg.reconciler.source.Reconciler","knative.dev/kind":"sources.knative.dev.KafkaSource","knative.dev/traceid":"968038a5-bd34-43d4-a6ff-4b42aeb945ae","knative.dev/key":"k9/kafka-es10a","targetMethod":"ReconcileKind","error":"error getting cluster admin sarama config: [protocol SASL_SSL] SASL mechanism required (key: sasl.mechanism)","stacktrace":"knative.dev/eventing-kafka/pkg/client/injection/reconciler/sources/v1beta1/kafkasource.(*reconcilerImpl).Reconcile\n\tknative.dev/eventing-kafka@v0.30.1-0.20220411014620-2d621fa05a48/pkg/client/injection/reconciler/sources/v1beta1/kafkasource/reconciler.go:302\nknative.dev/pkg/controller.(*Impl).processNextWorkItem\n\tknative.dev/pkg@v0.0.0-20220411013750-e2b4d748e59f/controller/controller.go:542\nknative.dev/pkg/controller.(*Impl).RunContext.func3\n\tknative.dev/pkg@v0.0.0-20220411013750-e2b4d748e59f/controller/controller.go:491"}
{"level":"error","ts":"2022-04-28T18:55:43.169Z","logger":"kafka-broker-controller","caller":"controller/controller.go:566","msg":"Reconcile error","knative.dev/pod":"kafka-controller-5b744bd98b-x46hs","knative.dev/controller":"knative.dev.eventing-kafka-broker.control-plane.pkg.reconciler.source.Reconciler","knative.dev/kind":"sources.knative.dev.KafkaSource","knative.dev/traceid":"968038a5-bd34-43d4-a6ff-4b42aeb945ae","knative.dev/key":"k9/kafka-es10a","duration":0.000954215,"error":"error getting cluster admin sarama config: [protocol SASL_SSL] SASL mechanism required (key: sasl.mechanism)","stacktrace":"knative.dev/pkg/controller.(*Impl).handleErr\n\tknative.dev/pkg@v0.0.0-20220411013750-e2b4d748e59f/controller/controller.go:566\nknative.dev/pkg/controller.(*Impl).processNextWorkItem\n\tknative.dev/pkg@v0.0.0-20220411013750-e2b4d748e59f/controller/controller.go:543\nknative.dev/pkg/controller.(*Impl).RunContext.func3\n\tknative.dev/pkg@v0.0.0-20220411013750-e2b4d748e59f/controller/controller.go:491"}
{"level":"info","ts":"2022-04-28T18:55:43.173Z","logger":"kafka-broker-controller.event-broadcaster","caller":"record/event.go:285","msg":"Event(v1.ObjectReference{Kind:\"KafkaSource\", Namespace:\"k9\", Name:\"kafka-es10a\", UID:\"9b80f019-400f-40f8-9119-0b38d8eadf77\", APIVersion:\"sources.knative.dev/v1beta1\", ResourceVersion:\"770302666\", FieldPath:\"\"}): type: 'Warning' reason: 'InternalError' error getting cluster admin sarama config: [protocol SASL_SSL] SASL mechanism required (key: sasl.mechanism)","knative.dev/pod":"kafka-controller-5b744bd98b-x46hs"}
{"level":"debug","ts":"2022-04-28T18:55:43.177Z","logger":"kafka-broker-controller","caller":"controller/controller.go:574","msg":"Requeuing key k9/kafka-es10a due to non-permanent error (depth: 0)","knative.dev/pod":"kafka-controller-5b744bd98b-x46hs","knative.dev/controller":"knative.dev.eventing-kafka-broker.control-plane.pkg.reconciler.source.Reconciler","knative.dev/kind":"sources.knative.dev.KafkaSource","knative.dev/traceid":"968038a5-bd34-43d4-a6ff-4b42aeb945ae","knative.dev/key":"k9/kafka-es10a"}

I am doing fix for that too in controller.

@aslom Hey I just saw this. I worked on this this afternoon and tested the change and everything seems to work fine. I'll create PR tomorrow.

I think I found possible reason why I did not see "SASL mechanism required" error in controller log. I started with working configuration that had type and when I removed type it seems controller kept cached version. So it kept working but then data plane had configuration without type and that caused other error.

@aslom Do you have the PR for this?

@steven0711dong https://github.com/knative-sandbox/eventing-kafka-broker/pull/2139

authors: aslom matzew pierDipi steven0711dong

repo: knative-sandbox/eventing-kafka-broker


text:
Nop reconciliations should not emit events

Describe the bug

https://github.com/knative/pkg/issues/1520

/assign

source: gharchive/issue

license_type: permissive

license_source: bigquery


text:
Checking if the fancy codecov works with java too

Signed-off-by: Francesco Guardiani francescoguard@gmail.com
Related to #187

Should we use a separate action for Java since this action is synced by Matt's bot?

Should we use a separate action for Java since this action is synced by Matt's bot?

But then we upload 2 reports for each action, does codecov like it?

/shrug

/unshrug

woo woo https://codecov.io/gh/knative-sandbox/eventing-kafka-broker/tree/8ec21d0d628e95dff01cc2dd0e14751384307c9b

source: gharchive/pull-request

authors: pierDipi slinkydeveloper


text:
Remove KinD e2e tests

KinD tests are continuously failing since there aren't enough
resources to run our e2e tests in GH action hosted runners.
Signed-off-by: Pierangelo Di Pilato pierdipi@redhat.com

/retest-required
/assign @matzew @aliok

/lgtm

authors: matzew pierDipi


text:
Remove google builder implementation

The google builder implementation was never widely used, was untested and undocumented, and could only be enabled for all builds on the cluster.
If we decide to add this capability back, we should do it in such a way that it can execute builds alongside the on-cluster implementation. And we should document and test it.
This is just an initial gutting of this functionality, and leaves a few rough edges in the codebase that will need to be sanded off later, probably while we rewrite it all to conform to knative/pkg idioms.
/assign mattmoor
Release Note
Remove capability for Build controller to offload build execution to GCB.

/test pull-knative-build-integration-tests

repo: knative/build


text:
mark msg, when send did NOT fail :fire:

Fixes #304 (Kafka)
Proposed Changes

the postMessage returns error of send
consumerclaim marks message only if POST was good, no error on post bubbled up

/assign @bbrowning

@dubee mind taking a look ?

Thank you sir!

authors: bbrowning matzew

repo: knative/eventing-sources

license_source: github-api


text:
update knative/pkg and add prune options

Proposed Changes

update knative/pkg and add prune options

Release Note
NONE

/assign @grantr

/retest

/lgtm


text:
Evaluate a possibility of calling codegen scripts in vendorless projects

Exploration, is it possible to call code gen scripts in vendorless projects.
If so, this might provide a bridge solution to https://github.com/knative/infra/issues/134

/assign

repo: knative/hack


text:
[main] Update community files

Cron -knative-prow-robot
/cc knative/operations-wg-leads
/assign knative/operations-wg-leads
Produced by: knative-sandbox/knobots/actions/update-community
Details:

/lgtm
/approve

authors: houshengbo knative-automation

repo: knative/operator


text:
Light cleanup on our dependencies.

Proposed Changes
A much more tuned down go at cleaning up our dependencies. This time only removing tools we really don't need and that are guaranteed to have no references.
I recreated Gopkg.lock from scratch in the last commit to guard against the breakage I caused the last time round. This looks much cleaner now!
/assign @houshengbo

Do all of the hack commands still work?

@trshafer I think the bigboy is update-codegen.sh and yes, that still works a charm.

/lgtm

/approve

authors: markusthoemmes trshafer

repo: knative/serving-operator


text:
Filter manifest to install/uninstall extensions such as serving-cert-manager, ns-cert and networking-istio

This patch supports filter function to install/uninstall extensions
such as serving-cert-manager, networking-ns-cert and istio
ingress by the configuration. It solves following two problems.
problem 1
When autoTLS is enabled in config-network, we need
namespace-wildcard-certs and cert-manager
to be deployed. However current operator does not install them.
problem 2
When we want to change ingress.class to antoher Ingress solution
instead of Istio, current operator always deploys networking-istio and
istio gateways.
To solve them, this patch filters manifest to install/uninstall
by the configuration.
e.g - when autoTLS=Enabled ingress.calss=kourier is configured w/ this PR
$ kubectl get pod  -n knative-serving
NAME                                      READY   STATUS    RESTARTS   AGE
activator-869f6d4f9f-ll75v                1/1     Running   2          87m
autoscaler-78994c9fdf-c6kmn               1/1     Running   2          87m
autoscaler-hpa-66bcf9cdc-sxt72            1/1     Running   0          87m
controller-b94c5b667-97wkl                1/1     Running   2          87m
networking-certmanager-5bfcf45d79-kc958   1/1     Running   0          21m
networking-ns-cert-5447795455-wx9pj       1/1     Running   0          21m
webhook-7cdb467d79-4jrfq                  1/1     Running   2          87m

Release Note
serving-cert-manager and networking-ns-cert are deployed when autoTLS is Enabled.
networking-istio is not deployed when ingress.class is not Istio.

/lint

/retest

/test pull-knative-serving-operator-upgrade-tests
TestProbe failed. I think it is flaky.

I'm not sure if serverless-opeator will support cert-manager, ns-cert and other ingress solutions. So I'm closing this rather than keep rebasing it.


text:
Feature ray

This PR address issue #26 .
Things to note.

I've updated the tests.yml to install ray in a local environment for testing. Also created a new pytest.ini file for ignoring deprecation warnings that ray throws. This is an issue that the maintainers of joblib will deal with so I don't see any reason to clutter pytest responses with a 100+ deprecation warnings.

Also made some minor modifications to the Runner docstring to reflect support for ray.
I've performed the unit tests locally any everything checks out.

Code coverage has one caveat being the try - except block in Runner._run which catches the import error for ray. If we really wanted to run this bit of code we would need to alter tests.yml to run a specific test without ray installed, then install ray and run the normal test suite. I figured this was too much work for 5 lines of coverage.

other odds and ends.

Let me know if you need me to do anything else.

Mainly have a question on weather or not ray needs to be running as a service beforehand or if we can start ray just for our own run.

Ray does not need to be running as a service. I.e called explicitly from the CLI before hand. We can use ray.init() in the code itself to start the server locally. I guess it would make things easier from a CI perspective since its one less build step during testing.

repo: koaning/memo

license: MIT


text:
Code highlight doesn't update unless a model is linked

Hello, I was testing this package and I found it quite interesting, however, I found a issue, which happens in the main demo too. If I update the code, aka, type a new one in the window, the new code won't have a new highlight. If I set a default code, it will have the highlight.
However, if I link it to a data model, the highlight works just fine. Below I gave some snippets.
Also, if that's expected, just ignore me :-P
Browser: Firefox 68.0.1
example code:
With this code the highlight doesn't work
Vue.use(BootstrapVue);
Vue.component("prism-editor", VuePrismEditor);

var default_app = new Vue({el: "#app"});

<prism-editor emit-events line-numbers language="js"></prism-editor>

With this code, the highlight work just fine.
Vue.use(BootstrapVue);
Vue.component("prism-editor", VuePrismEditor);

var default_app = new Vue({
    el: "#app",
    data: {
        code: ""
    }
});

<prism-editor v-model="code" emit-events line-numbers language="js"></prism-editor>

Also, if you want a complete working code can be found in my package:
https://github.com/Cerberus1746/PandaCoreData/tree/development/panda_core_data/ui

Hi thanks.
If you don't give a model what is the purpose of using it? Just trying to understand your use case.

Exactly! :V
But I took a while to realize what the issue was because I am a noob with vue. So I would suggest raising an exception if a model could not be found, and it was kinda weird because it was an error that was happening in the demo too.

Alright maybe we'll do sth about it :) Cheers.

Note! There's a point in not using the v-model, because there's a change event:
		<prism-editor
			v-model="___"
			:code="value"
			@change="handleChange"
			language="html"
			:lineNumbers="false"
		/>

S without v-model, it's still useful to use @change.

authors: Cerberus1746 koca trusktr

repo: koca/vue-prism-editor


text:
Visited nfts in gallery item

Seems like it only shows in gallery detail of rmrk nfts?

okay nevermind, it just loads up slowly

repo: kodadot/nft-gallery


text:
Not calculating usd total amount in confirmation modal

👋

here it works

@prury did you manage to reproduce the bug? 👀

@prury did you manage to reproduce the bug? 👀

i did manage do reproduce another one that its similar 😄
Polkadot Assethub:

@exezbcz could you tell me how to reproduce this bug? I tried several times but not catch this wierd dialog.

Did not manage to find any steps to reproduce, One thing that happened to me was the incorrect amount calculation on Polkadot asset hub

authors: exezbcz prury xiiiAtCn


text:
fix: nft detail history styling

Thank you for your contribution to the KodaDot NFT gallery.
👇 _ Let's make a quick check before the contribution.
PR type

[x] Bugfix
[ ] Feature
[ ] Refactoring

What's new?

[x] PR closes #3766
[ ] Requires deployment <rubick/magick_issue>
[ ] <brief_description_of_what_I've_added>

Before submitting Pull Request, please make sure:

[x] My contribution builds clean without any errors or warnings
[x] I've merged recent default branch -- main and I've no conflicts
[x] I've tried to respect high code quality standards
[x] I've didn't break any original functionality
[x] I've posted a screenshot of demonstrated change in this PR

Optional

[ ] I've tested it at </rmrk/collection/26902bc2f7c20c546a-1FVG7>
[x] I've tested PR on mobile and everything seems works
[ ] I found edge cases
[ ] I've written some unit tests 🧪

Had issue bounty label?

[x] Fill up your KSM address: Payout

Community participation

[x] Are you at KodaDot Discord?

Screenshot

[x] My fix has changed something on UI; a screenshot is best to understand changes for others.

could you check conflicts?

could you check conflicts?

Done

I think this already been resolved in #3742 since I can't see problems on beta

I think this already been resolved in #3742 since I can't see problems on beta

Ok, Let's close this PR then.


text:
feat: activity tabs

Thank you for your contribution to the KodaDot NFT gallery.
👇 _ Let's make a quick check before the contribution.
PR Type

[ ] Bugfix
[ ] Feature
[ ] Refactoring
[x] Redesign

Context

[x] Closes #4234
[x] branching from https://github.com/kodadot/nft-gallery/pull/4360, so that PR need to merge first

Before submitting pull request, please make sure:

[x] My contribution builds clean without any errors or warnings
[x] I've merged recent default branch -- main and I've no conflicts
[x] I've tried to respect high code quality standards
[x] I've didn't break any original functionality
[x] I've posted a screenshot of demonstrated change in this PR

Optional

[ ] I've tested it at </bsx/collection>
[ ] I've tested PR on mobile
[ ] I've written unit tests 🧪
[ ] I've found edge cases

Had issue bounty label?

[ ] Fill up your KSM address: Payout

Community participation

[x] Are you at KodaDot Discord?

Screenshot 📸

[x] My fix has changed something on UI; a screenshot is best to understand changes for others.

Merged :)

https://github.com/kodadot/nft-gallery/pull/4360

Seems like the tabs component is getting destroyed and re-rendered sometimes on clicks.
I'm looking at that weird whiteout between clicks; it doesn't always happen and is just pretty random
https://user-images.githubusercontent.com/5887929/206205882-d3186e25-869c-40a4-94f2-b19cb8468187.mov

for this, I will wrap them alongside the table component in this issue #4368, wdyt @roiLeo ?

Yes! I may need your help on #4430
When I move @oruga-ui imports (NeoButton) in histoire.scss the preview is good but I don't have the same rendering in kodadot app.
It would be a shame to have to import in all our new components the oruga-ui variables, lmk if you have any idea why it works this way.

eh, I think we need pagination in this section. so, temporary I will limit the results to 100

feel free to address @exezbcz in case, and I'll go through it with him; we are trying to have weekly calls to resolve some design issues in best efforts

#4403

Plus, I think categories/tags should be as a multi-check box? Like for example, I would like to see Sales and Transfers at once.

Plus, I think categories/tags should be as a multi-check box? Like for example, I would like to see Sales and Transfers at once.

yes, that should work on the multi-check box. maybe the active state to thin? i'm using text-shadow to avoid glitch instead of font-weight bold

Active state to thin is not a great system. Is there really that big of a problem with the bold active state?

Does

#4456 helps fix this?

Current issues are

user doesn't know which tab is currently selected -- bold text issues, we may change to different font?
currently there are missing wrapping text, we can use ... ? For addresses I would like to use some filter function with 3 beginning letters and 3 ending letters for now? Like 2Xk...9oP
hover card should pop up under cursor. Now position is showing over whole table
events name should not be in capslock, only capital letter on event
on the time column we probably can strip "about" if there is "about 1 month ago"
link between tabs and column names should be k-white?

responsive issues but can be solved separately, we will came up with design

let it fly!

authors: exezbcz preschian roiLeo yangwao


text:
feat: Share on Farcaster / Warpcast

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.
👇 __ Let's make a quick check before the contribution.
PR Type

[x] Feature

Needs QA check

@kodadot/qa-guild please review

Context

[x] Closes #9679

Did your issue had any of the "$" label on it?

[x] My DOT address: Payout

Screenshot 📸

[x] My fix has changed UI

Copilot Summary
copilot:summary
copilot:poem

looking at the screenshot you've posted
X icon looks not aligned vertically

X icon looks not aligned vertically

close, Farcaster is down like 2-3px along others

Good catch! I have updated the icon of Farcaster for a better fit.

Minor

Move to svg Farcaster file in public
I thought so too, but moving to a separate svg file will cause the currentColor to be invalid.

Thanks!
pay 30 usd

😍 Perfect, I’ve sent the payout
💵 $30 @ 10.65 USD/DOT ~ 2.817 $DOT
🧗 16SjUbGKSdjCdWTy3NNT3JxbRVGGqD4mwkHpc6BD9U2Rp29Z
🔗 0x393350b8038c9c92325e7c031bdc337a9747ee374e34a3032b10849f8bc5b8e9
🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

Let's add to the success modal share which # you've minted out of total supply, i.e. coinbase inspiration

authors: Jarsen136 daiagi yangwao


text:
[Storage] Cannot set custom option on s3 driver

For now, if we upload image with Storage.disk().put('image.jpg', imageContent), the image stored with missing content-type.
We can add content-type option when upload with aws sdk, but the flydrive wrapper is lack of this feature. The worst thing is, we need this option to make our content accessable publicly.
Currently lunox is using https://github.com/Slynova-Org/flydrive for Storage manager. I think that repo is no longer maintained. We need to refork that repo to add support adding custom option as 3rd params of put method. Or may be better, we can read custom option from filesystem config file like laravel did.

Already fixed in 917bc9e6d3aece87eca6fd65525ff5e0ecf1eab7

repo: kodepandai/lunox


text:
Send window to display breaks changing display foucs

Steps to reproduce:

Send a window to another display window -m display 1
Attempt to change focus back to previous screen display -f prev

Expected result: Previous screen to be focused.
Actual result: No screen focus change is possible until the mouse is used to give focus to the previous display.

Not sure if I understood what this issue is about, but window -fm prev is only to be used between monocle windows inside of a bsp-node.

I had a copy paste error, I updated the OP to include the correct command. The email still had the incorrect command.

Will check when I get home later tonight.

Do you happen to know if this is also broken in Kwm version 2.0.3 as well, or just on master?

Moving the window only is fine, the issue I am having is that display -f does nothing until I use the mouse to focus a display.
The issue is that display -f seems to be broken completely after moving a window.

Fixed in latest commit.
I let the behaviour remain as is.
Moving a window will also move focus to the new display.

👍 this behavior seems more predicable. Confirmed working.

Ok, this isn't quite fixed.
Oddly enough doing window -m 2 works. I can use display -f.
However, going back the other way window -m 1 exhibits the same behavior as before.
GiveFocusToScreen appears to be called, but focus is not updated with kwm. It is updated with osx. When it is in this state using kwm focus commands do not work.

Well this is weird, works fine for me.

I just tried again, here are my steps:

Send focused window to 2nd display window -m display 1
Focus previous display display -f prev
Focus previous display display -f prev
Send focused window back to 1st display window -m display 0
Focus previous display display -f prev

OS X focus the previous display, but the kwm focus does not update. Kwm still receives commands but doesn't change state
Local Daemon is now running..
DisplayID 441231622 has index 0
DisplayID 69733314 has index 1
CreateWindowNodeTree() Create Space 3
CreateBSPTree() Create pair of leafs
CreateBSPTree() Create pair of leafs
CreateBSPTree() Create pair of leafs
CreateBSPTree() Create pair of leafs
CreateBSPTree() Create pair of leafs
SetWindowDimensions() Update window dimensions
SetWindowDimensions() Update window dimensions
SetWindowDimensions() Update window dimensions
SetWindowDimensions() Update window dimensions
SetWindowDimensions() Update window dimensions
SetWindowDimensions() Update window dimensions
SetWindowDimensions() Update window dimensions
KwmExecuteHotkey
GiveFocusToScreen() 1: Space transition ended 3 -> 119
Uninitialized Screen
CreateWindowNodeTree() Create Space 119
SetWindowDimensions() Update window dimensions
SetWindowRefFocus() Focused Window: Slack 3860,1198
KwmExecuteHotkey
GiveFocusToScreen() 0: Space transition ended 119 -> 3
Populated Screen Key/Mouse Focus
SetWindowRefFocus() Focused Window: kwm 22,45
KwmExecuteHotkey
SetWindowRefFocus() Focused Window: react-router/API.md at master · reactjs/react-router 20,1077
KwmExecuteHotkey
RemoveWindowFromBSPTree() Parent && LeftChild && RightChild
SetWindowDimensions() Update window dimensions
AddWindowToTreeOfUnfocusedMonitor() Monocle Space
SetWindowDimensions() Update window dimensions
SetWindowRefFocus() Focused Window: react-router/API.md at master · reactjs/react-router 3860,1198
SetWindowDimensions() Update window dimensions
KwmExecuteHotkey
GiveFocusToScreen() 0: Space transition ended 119 -> 3
Populated Screen Key/Mouse Focus
SetWindowRefFocus() Focused Window: kwm 22,45
KwmExecuteHotkey
GiveFocusToScreen() 1: Space transition ended 3 -> 119
Populated Screen Key/Mouse Focus
SetWindowRefFocus() Focused Window: react-router/API.md at master · reactjs/react-router 3860,1198
KwmExecuteHotkey
AddWindowToTreeOfUnfocusedMonitor() BSP Space
SetWindowDimensions() Update window dimensions
SetWindowDimensions() Update window dimensions
SetWindowRefFocus() Focused Window: react-router/API.md at master · reactjs/react-router 20,558
SetWindowDimensions() Update window dimensions
KwmExecuteHotkey
###
###
### This is where focus gets lost. Notice how the screen transition takes place but no SetWindowRefFocus
###
###
GiveFocusToScreen() 1: Space transition ended 3 -> 119
Populated Screen Key/Mouse Focus
KwmExecuteHotkey
KwmExecuteHotkey
KwmExecuteHotkey
KwmExecuteHotkey
GiveFocusToScreen() 0: Space transition ended 119 -> 3
Populated Screen Key/Mouse Focus
SetWindowRefFocus() Focused Window: react-router/API.md at master · reactjs/react-router 20,558
KwmExecuteHotkey
SetWindowRefFocus() Focused Window: kwm 22,42

I am only able to reproduce the above behaviour if the space of the display that I am moving a window to has not been initialized.
If you start Kwm, give focus to each if the displays either through binds or using the mouse, the above should not be reproducible.

Local Daemon is now running..
Creating display with:
ID: 441231622Resolution: 3840x2160 Origin: (0,0)
DisplayID 441231622 has index 0 and ID 4268EF99-6620-8CD4-A0E6-EFD08D4D5365
Creating display with:
ID: 69733314Resolution: 1920x1200 Origin: (3840,1158)
DisplayID 69733314 has index 1 and ID 1FBF2F7F-57EC-56E5-521F-556A305D1A61
CreateWindowNodeTree() Create Space 3
CreateBSPTree() Create pair of leafs
CreateBSPTree() Create pair of leafs
SetWindowDimensions() zsh pos: 20,45 size: 1889,1011
SetWindowDimensions() zsh pos: 20,1082 size: 1889,1011
SetWindowDimensions() Send window to display breaks changing display foucs · Issue #324 · koekeishiya/kwm pos: 1930,40 size: 1890,2055
SetWindowDimensions() zsh pos: 20,45 size: 1889,1011
KwmExecuteHotkey
DISPLAY ACTIVE
GiveFocusToScreen() 1: Space transition ended 3 -> 145
Uninitialized Screen
CreateWindowNodeTree() Create Space 145
SetWindowDimensions() Slack pos: 3860,1198 size: 1880,1095
SetWindowDimensions()  pos: 3860,1198 size: 1880,1095
SetWindowDimensions() node pos: 3862,1202 size: 1877,1090
SetWindowRefFocus() Focused Window: Slack 3860,1198
KwmExecuteHotkey
DISPLAY ACTIVE
GiveFocusToScreen() 0: Space transition ended 145 -> 3
Populated Screen Key/Mouse Focus
SetWindowRefFocus() Focused Window: kwm 20,45
KwmExecuteHotkey
DISPLAY ACTIVE
GiveFocusToScreen() 1: Space transition ended 3 -> 145
Populated Screen Key/Mouse Focus
SetWindowRefFocus() Focused Window: Slack 3860,1198
KwmExecuteHotkey
SetWindowFocusByNode()
SetWindowRefFocus() Focused Window: node 3862,1202
KwmExecuteHotkey
AddWindowToTreeOfUnfocusedMonitor() BSP Space
SetWindowDimensions() kwm pos: 22,45 size: 932,1011
SetWindowDimensions() node pos: 977,45 size: 932,1011
DISPLAY ACTIVE
GiveFocusToScreen() 0: Space transition ended 145 -> 3
SetWindowRefFocus() Focused Window: node 977,45
SetWindowDimensions() node pos: 977,45 size: 932,1011
KwmExecuteHotkey
DISPLAY ACTIVE
GiveFocusToScreen() 1: Space transition ended 3 -> 145
Populated Screen Key/Mouse Focus
KwmExecuteHotkey
KwmExecuteHotkey
KwmExecuteHotkey
DISPLAY ACTIVE
GiveFocusToScreen() 0: Space transition ended 145 -> 3
Populated Screen Key/Mouse Focus
SetWindowRefFocus() Focused Window: node 977,45
KwmExecuteHotkey
SetWindowRefFocus() Focused Window: kwm 22,45

I can still reproduce this.
Notice in the logs I have initialized both screens before attempting the steps I posted previously.

I noticed you are runing with the GPU patch from @cHoco. I have no idea what this patch currently does and how it may affect the changes I've done to master regarding this issue.

Ah, good catch. Let me revert that and try again.

Ok, git reset --hard and re-ran make. Same result unfortunately
Local Daemon is now running..
DisplayID 441231622 has index 0
DisplayID 69733314 has index 1
CreateWindowNodeTree() Create Space 3
CreateBSPTree() Create pair of leafs
CreateBSPTree() Create pair of leafs
SetWindowDimensions() zsh pos: 20,45 size: 1889,1011
SetWindowDimensions() Better support for dual GPUs setups · Issue #323 · koekeishiya/kwm pos: 20,1077 size: 1890,1017
SetWindowDimensions() display-log.txt pos: 1930,40 size: 1890,2055
SetWindowRefFocus() Focused Window: Better support for dual GPUs setups · Issue #323 · koekeishiya/kwm 20,1077
SetWindowDimensions() Better support for dual GPUs setups · Issue #323 · koekeishiya/kwm pos: 20,1077 size: 1890,1017
SetWindowDimensions() Better support for dual GPUs setups · Issue #323 · koekeishiya/kwm pos: 20,1077 size: 1890,1017
KwmExecuteHotkey
GiveFocusToScreen() 1: Space transition ended 3 -> 149
Uninitialized Screen
CreateWindowNodeTree() Create Space 149
SetWindowDimensions() node pos: 3862,1202 size: 1877,1090
SetWindowDimensions() Slack pos: 3860,1198 size: 1880,1095
SetWindowDimensions() zsh pos: 3862,1202 size: 1877,1090
SetWindowRefFocus() Focused Window: node 3862,1202
KwmExecuteHotkey
GiveFocusToScreen() 0: Space transition ended 149 -> 3
Populated Screen Key/Mouse Focus
SetWindowRefFocus() Focused Window: Better support for dual GPUs setups · Issue #323 · koekeishiya/kwm 20,1077
KwmExecuteHotkey
GiveFocusToScreen() 1: Space transition ended 3 -> 149
Populated Screen Key/Mouse Focus
SetWindowRefFocus() Focused Window: node 3862,1202
KwmExecuteHotkey
AddWindowToTreeOfUnfocusedMonitor() BSP Space
SetWindowDimensions() kwm pos: 22,45 size: 932,1011
SetWindowDimensions() node pos: 977,45 size: 932,1011
GiveFocusToScreen() 0: Space transition ended 149 -> 3
SetWindowRefFocus() Focused Window: node 977,45
SetWindowDimensions() node pos: 977,45 size: 932,1011
KwmExecuteHotkey
GiveFocusToScreen() 1: Space transition ended 3 -> 149
Populated Screen Key/Mouse Focus
KwmExecuteHotkey
KwmExecuteHotkey
KwmExecuteHotkey
KwmExecuteHotkey
KwmExecuteHotkey
KwmExecuteHotkey
KwmExecuteHotkey
KwmExecuteHotkey
KwmExecuteHotkey
KwmExecuteHotkey
GiveFocusToScreen() 0: Space transition ended 149 -> 3
Populated Screen Key/Mouse Focus
SetWindowRefFocus() Focused Window: node 977,45
KwmExecuteHotkey
SetWindowRefFocus() Focused Window: kwm 22,45

I did  the following steps just now:
    Send focused window to 2nd display window -m display 1
    Focus previous display display -f prev
    Focus previous display display -f prev
    Send focused window back to 1st display window -m display 0
    Focus previous display display -f prev

Everything works perfectly for me. Does any of your displays override default mode / padding / gaps in the kwmrc file? All my displays are set to bsp. Maybe this could be some monocle mode only issue?

Ah! Yes I do have Display 1 set to monocle mode. I will test this with both set to BSP, give me a few minutes.

@koekeishiya Very good catch! It only happens when going from a BSP space to a Monocle space. It works perfectly BSP -> BSP!

Right, so I'm able to reproduce now. Will work on a fix in a bit.

Should be fixed for sure this time.

Yup! it is fixed.
Odd behavior though:

Send window to display that is in monocle mode window -m display 1
Start cycling though windows window -f east
After about 2 or 3 cycles the original display becomes focused again for some reason

This behavior only happens when the space the window is sent to is in Monocle mode. If the space is in BSP mode cycling though the windows will always stay on that display.

This behavior only happens when the space the window is sent to is in Monocle mode. If the space is in BSP mode cycling though the windows will always stay on that display.

Hmm, I'm unable to reproduce this..awkward

Local Daemon is now running..
DisplayID 441231622 has index 0
DisplayID 69733314 has index 1
CreateWindowNodeTree() Create Space 3
CreateBSPTree() Create pair of leafs
CreateBSPTree() Create pair of leafs
CreateBSPTree() Create pair of leafs
CreateBSPTree() Create pair of leafs
SetWindowDimensions() zsh pos: 22,45 size: 932,1011
SetWindowDimensions() Send window to display breaks changing display foucs · Issue #324 · koekeishiya/kwm pos: 975,40 size: 935,1017
SetWindowDimensions() kwmrc pos: 20,1077 size: 1890,1017
SetWindowDimensions() zsh pos: 1930,45 size: 1889,1011
SetWindowDimensions() zsh pos: 1930,1082 size: 1889,1011
SetWindowDimensions() zsh pos: 22,45 size: 932,1011
KwmExecuteHotkey
GiveFocusToScreen() 1: Space transition ended 3 -> 176
Uninitialized Screen
CreateWindowNodeTree() Create Space 176
SetWindowDimensions() Slack pos: 3860,1198 size: 1880,1095
SetWindowRefFocus() Focused Window: Slack 3860,1198
KwmExecuteHotkey
GiveFocusToScreen() 0: Space transition ended 176 -> 3
Populated Screen Key/Mouse Focus
SetWindowRefFocus() Focused Window: kwm-overlay 22,45
KwmExecuteHotkey
SetWindowRefFocus() Focused Window: Send window to display breaks changing display foucs · Issue #324 · koekeishiya/kwm 975,40
KwmExecuteHotkey
SetWindowRefFocus() Focused Window: zsh 1930,45
KwmExecuteHotkey
RemoveWindowFromBSPTree() Parent && LeftChild && RightChild
SetWindowDimensions() zsh pos: 1930,44 size: 1889,2050
AddWindowToTreeOfUnfocusedMonitor() Monocle Space
SetWindowDimensions() zsh pos: 3862,1202 size: 1877,1090
GiveFocusToScreen() 1: Space transition ended 3 -> 176
SetWindowRefFocus() Focused Window: zsh 3862,1202
SetWindowDimensions() zsh pos: 3862,1202 size: 1877,1090
KwmExecuteHotkey
SetWindowFocusByNode()
SetWindowRefFocus() Focused Window: Slack 3860,1198
KwmExecuteHotkey
SetWindowFocusByNode()
SetWindowRefFocus() Focused Window: zsh 3862,1202
GiveFocusToScreen() 0: Space transition ended 176 -> 3
KwmExecuteHotkey
SetWindowRefFocus() Focused Window: Send window to display breaks changing display foucs · Issue #324 · koekeishiya/kwm 975,40
SetWindowRefFocus() Focused Window: kwm-overlay 22,45

Probably not helpful but here are my logs.

If you can reliably reproduce this odd behaviour, could you create a new issue for it and list steps to reproduce etc?

Moved to #328

authors: chrishoage koekeishiya

repo: koekeishiya/kwm

license: mit


text:
zsh:1: command not found: yabai - only when running the service

Installed yabai and skhd via brew.
When running skhd --start-service my keybinds not using yabai work as intended.
Whenever I try to run a keybind using yabai the line from the title is added to the error log.
However, if I just run skhd in a terminal (after stopping the service of course) all my keybinds work just fine.

Possibly duplicate of https://github.com/koekeishiya/skhd/issues/350

Ah yes, it seems it was after all.
Calling eval "$(/opt/homebrew/bin/brew shellenv)" inside my .zshenv did the trick.
Tnanks

repo: koekeishiya/skhd


text:
Allow reordering of stacked windows

Are there any plans to allow reodering/swapping stacked windows?
This has already been asked by https://github.com/koekeishiya/yabai/issues/203#issuecomment-683510857 with following snippet
# swap stacked window
rctrl + shift - n : yabai -m window --swap stack.next || yabai -m window --swap stack.first
rctrl + shift - p : yabai -m window --swap stack.prev || yabai -m window --swap stack.last

In the original issue about introducing stacking the https://github.com/koekeishiya/yabai/issues/203#issuecomment-686590184 says

stacked windows cannot be reordered currently. (3 Sep 2020)

With the nice visual indicators for stacks by Stackline, the stacking feature of yabai has become a very compelling feature.

Duplicate of https://github.com/koekeishiya/yabai/issues/960

repo: koekeishiya/yabai


text:
Smartly disable focus follows mouse while select types of dialogs or panes are open

From a user point of view, it does not make sense that moving the mouse towards an open Notification Center can close the Notification Center.
Similarly, when a context menu is open (e.g., from the menu bar or a right click), yabai should smartly disable focus follows mouse. I often find myself having to repeat clicking on things because I forgot to hold down fn.

I like this idea, but it might be tricky to pull off. In my experience not all dialogs and/or panes properly report that they were destroyed. I don't remember a particular way to reproduce that, unfortunately.

I believe this is solved here. https://github.com/koekeishiya/yabai/issues/535#issuecomment-642732172
Correct me if I'm wrong. but after this I don't have any issues with select menus.

That is partially true – it is fixed for the notification center. However, this is still an issue with menu bar dropdowns and context menus, so I'll leave this open for the time being.

This still closes the Notification Center for me (and I would also expect that to happen).
There has not been any changes that to alleviate this issue, yet.

On 15 Jun 2020, at 15:09, Dominik Lohmann notifications@github.com wrote:
That is partially true – it is fixed for the notification center. However, this is still an issue with menu bar dropdowns and context menus, so I'll leave this open for the time being.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub https://github.com/koekeishiya/yabai/issues/407#issuecomment-644124679, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABPDZVYTSLCYHWWKWF7OU6DRWYMRTANCNFSM4KSOWEMA.

It changed for ffm=autofocus for windows of the same application, which was my test case. For that it fixed, if it was ever broken for that case.

I've been thinking about this for quite some time and I think the combination of the following changes should improve the experience of focus-follows-mouse (autoraise) quite a bit:

If a menu is opened, disable focus-follows-mouse until the menu closes. This should in theory be doable by subscribing to the menu-opened and menu-closed notifications.
If the currently focused window is going to be fully occluded by the window that is the target of the ffm autoraise action, we bail and ignore it, as you probably would want to interact with the popup window or whatever it is.

I've been thinking about this for quite some time and I think the combination of the following changes should improve the experience of focus-follows-mouse (autoraise) quite a bit:

If a menu is opened, disable focus-follows-mouse until the menu closes. This should in theory be doable by subscribing to the menu-opened and menu-closed notifications.
If the currently focused window is going to be fully occluded by the window that is the target of the ffm autoraise action, we bail and ignore it, as you probably would want to interact with the popup window or whatever it is.

Sounds good to me. Only additional thing would be the NotificationCenter, which should always disable FFM while open.

Sounds good to me. Only additional thing would be the NotificationCenter, which should always disable FFM while open.

Implemented 1 and 2 from my previous comment on the-future branch.
Note that the new behaviour does not detect menus created by right-clicking on the Dock, as the Dock Is not eligible for menu-opened/closed notifications for some reason. There is also no way to detect menu-opened/closed system-wide:
application_observe: notification kAXMenuOpenedNotification failed with error kAXErrorNotificationUnsupported for Dock
application_observe: notification kAXMenuClosedNotification failed with error kAXErrorNotificationUnsupported for Dock

I am unable to reproduce the issue with the Notification Center closing on macOS Big Sur, so that I cannot work/comment on.

authors: AlaaSaadAbdo dominiklohmann koekeishiya


text:
Fix high specificity for input display property

This will reduce input selector specificity for display property to prevent overriding user written css. fix #78.

Hmm, interesting solution! I'll have to think on this one for a bit.
Note: this will have merge conflicts due to the change to CSS variables in #71. The change will have to be made to src/parts/_forms.css instead.

Sorry for not getting back to you on this pull request!
This is a good contribution, but it's now out of date with master. If you are able to resolve the merge conflicts we would love to have this contributed to water.css.

Hey @frontendmonster, I'll close this merge request for now but feel free to reopen if you can resolve the conflicts. We'd love to have your contribution!

I confirmed that this is still an issue, and did the same fix from the latest branch. So there shouldn't be any merge conflicts.
I'm creating a pull request...

Hi @kylejrp.
Can you check if I missed any steps in my PR?
I ran yarn changeset, but I still got an email re "This PR includes no changesets".
So is my change going to make it through or not?

authors: eazulay frontendmonster kylejrp


text:
GetHighestBlock implementation

Resolves #45.

Pull Request Test Coverage Report for Build 136

13 of 22 (59.09%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-1.4%) to 79.707%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

internal/bstore/reqhandler.go
13
22
59.09%

Totals

Change from base Build 131:
-1.4%

Covered Lines:
381

Relevant Lines:
478

💛  - Coveralls

authors: coveralls sgerbino

repo: koinos/koinos-block-store


text:
Native include directory pulled in via Boost_INCLUDE

I'm unable to compile on Ubuntu due to pulling in standard library headers like unistd.h and wchar.h from the host system.  The host versions of these headers pull in OS- and architecture-specific system headers that are incompatible with the VM.
The reason these headers are included is that I've installed Boost with apt-get.  This system Boost package installs in /usr/include.  So for me, Boost_INCLUDE_DIR is /usr/include, which makes the host system headers available to the Wasm cross-compiler.
We need to either require the user to point to a standalone Boost install in the top-level CMake, or vendor Boost as part of the CDT.

This is fixed

authors: mvandeberg theoreticalbts

repo: koinos/koinos-cdt


text:
[FEATURE]: Add abi_type field to upload_contract_operation

Is there an existing issue for this?

[X] I have searched the existing issues

New feature
The ABI field of upload_contract is currently JSON.
In future we might want to support other formats (binary / zipped / hash of ABI data stored off-chain in Git / IPFS / community site) so we should add a new string field telling clients how they should parse the data in the abi field (suggested field name: abi_type).
Anything else?
One alternative is to change abi to be oneof instead, which may be slightly more wire efficient, but there are several good reasons not to:

(1) oneof would be a hardforking change
(2) Community development of new ABI formats would depend on core developers to assign oneof alternatives in a timely, non-conflicting way
(3) Clients may be less able to handle a oneof alternative they don't understand than a string they don't understand
(4) Contract bytecode uploads are very large, infrequent, and done by relatively well-funded users, so saving a few bytes on upload_contract_operation is not super important

This issue is stale because it has been open for 30 days with no activity.

This issue was closed because it has been inactive for 14 days since being marked as stale.

authors: koinos-ci theoreticalbts

repo: koinos/koinos-proto


text:
🛑 Leo Pizza is down

In a8cfca6, Leo Pizza (https://leo-pizzaservice.de) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Leo Pizza is back up in 0dc2a9d after 19 minutes.

repo: koko-io/up


text:
Allow disabling ad-hoc querying panel

Feature request: support disabling distributed queries through API / query panel page.
Fleet internally uses distributed querying to get info such as network interfaces. I'd like to be able to leave this enabled, but disable the distributed querying features of fleet, such that users are not able to go to the query page and run queries (or use the API).
It's possible to set disable_distributed to true, but then hosts won't send info that fleet uses to enrich the UI.
Also, when disable_distributed is set to true, the UI still lets you go to the query page, select All Hosts and queue up an ad-hoc query that won't ever return results. It would be better for users to remove the link from the sidebar or maybe show a warning that the feature is disabled when that is set to disabled.

I was thinking also disabling ad-hoc queries only admins can write queries, and normal users only use already created/saved queries made by admin to reduce the risk of running something that causes production issues.

I think that would be great, as well as limiting those users to being able to query certain numbers of hosts. However, I think it's a bit off-topic for this ticket, and probably belongs instead in https://github.com/kolide/fleet/issues/2077

This has been implemented by #2167.

Does disabling live queries remove the dependency on redis?

Redis is also used for SSO login. You could remove Redis and you would find that most things work but healthz returns 500 errors and SSO login does not work.

authors: anelshaer mbigras nyanshak zwass

repo: kolide/fleet


text:
Use non-autoflush PrintStream rather than LogStream for mall prices.

I meant to include this in #1382 - the price writing code should use a buffered output stream, instead of a LogStream which auto-flushes each byte array write.
This PR reduces time on the below benchmark from about 10 s to about 500 ms.
  @Test
  void speed() {
    int N = 300;
    MallPriceDatabase.savePricesToFile = true;
    for (var entry : ItemDatabase.entrySet()) {
      MallPriceDatabase.recordPrice(entry.getKey(), entry.getKey(), true);
    }
    for (int i = 0; i < 2 * N / 5; i++) {
      MallPriceDatabase.writePrices();
    }
    long start =
        ManagementFactory.getThreadMXBean().getThreadCpuTime(Thread.currentThread().getId());
    for (int i = 0; i < N; i++) {
      MallPriceDatabase.writePrices();
    }
    long end = ManagementFactory.getThreadMXBean().getThreadCpuTime(Thread.currentThread().getId());
    System.out.println("Elapsed: " + (end - start) / 1_000_000);
    new File(KoLConstants.DATA_LOCATION, "mallprices.txt").delete();
  }

It does flush before writing, see PrintStream.close documentation:

And yeah, it should be done elsewhere. DataUtilities.getOutputStream should probably return a buffered output stream by default...

repo: kolmafia/kolmafia


text:
BBJ 737-700 And Asiana Airlines 777-300ER

it means Boeing Business Jet

Where's the file?

That's not a 737 MAX, it's a 737-700SSW

i changed to 737-700 BBJ

i changed to 737-700 BBJ

Ok, but we still need the file

no file

Where's the file?

no file

https://github.com/kolos26/GEOFS-LiverySelector/issues/44

ok

authors: BlueWacki FreedomAirways githubuser589


text:
Use folder of yaml Var files.

Is it possible to use more than one Yaml file for variables?

:wave: They are not.  #45 asks to support this.

Hi!
This project gets some interest, but sadly, I'm not maintaining it =\
Maintainer wanted!
Discussion: Maintainer Wanted

authors: VictorDewitte-Hogent kolypto mike-carey


text:
Add images to volunteers

This should only be necessary and stored for volunteers, but we need a way to add images to users for added safety.
For users logging in via Google/Facebook, we should ask if they want to pull their social picture directly, for all others offer a way to open up camera to take a picture or to upload from their library.
Add this at the step with the names, address, as part of the onboarding.

For Facebook you can get the image by using http://graph.facebook.com/${ID}/picture?type=square
Example : https://graph.facebook.com/1286977094658117/picture?type=normal.

authors: DragosPetria Mokto

repo: komakio/app


text:
Add komoju refund

Added Komoju refund support. refund method has money argument like other gateways but the argument is just ignored because currently Komoju API doesn't support partial refund.

@k2nr  LGTM :star: I checked it on sandbox. I'll merge it now.

Thanks. I'll cherry-pick the commits and squash

cherry-picked and squashed. closing this PR


text:
Failed to resolve: com.nineoldandroids:library:2.4.0+

I am using
compile 'konifar:fab-transformation:1.0.0'
But suddenly it is showing "Failed to resolve: com.nineoldandroids:library:2.4.0+"
As konifar:fab-transformation:1.0.0 is using "com.nineoldandroids:library:2.4.0+" ; what to do now?

Changing '2.4.0+' to '2.4.0' in build.gradle:84 will help. You can build library with this change by yourself and add to your app, if you can't wait for official release. I just did it myself :-)
source

I didn't use "com.nineoldandroids:library:2.4.0+". So where to change '2.4.0+' to '2.4.0'?

@sudarshaana he is talking about the library's dependencies. you have to download the library code and recompile it yourself

BTW, I got the same problem after i upgraded my Android Studio

I got the solution: Excluding nineoldandroids from the project, and add it to your project like this
compile 'com.nineoldandroids:library:2.4.0'
compile ('konifar:fab-transformation:1.0.0') {
        exclude group: 'com.nineoldandroids', module: 'library'
}

@iballan
Thanks.
Thats also works for me.

Thank's alot buddy....
Works for me as well

you are all welcome :)

repo: konifar/fab-transformation


text:
Create NetworkPolicy to allow Ingress to RHSSO

When Deploying MTA 6 and Exposing RHSSO, a NetworkPolicy needs to be created manually to access the RHSSO UI.
This PR enables the operator to automatically create this NetPol when the user enables RHSSO to be exposed.

@A-Beck can you help us to understand what adding a network policy is intended to do? Is this to provide added security by limiting communication?
Do you know if enabling it adds any limitations to functionality?

I might be crossing my wires with https://github.com/konveyor/tackle2-operator/pull/82 Allow namespace isolation via network policies. @fbladilo are you able to help us understand the two?

@jmontleon Adding the RHSSO network policy is intended to allow traffic to the RHSSO instance so that user access can be managed through the RHSSO UI when feature_isolate_namespace is set to true.
The current network policies allow traffic to the tackle UI only, as intended by #82

need dco

@A-Beck can you signoff on the PR so DCO will pass and fix the conflicts. Once done I'll get this merged. Thank you!

authors: A-Beck jmontleon kaovilai


text:
docs: add backup and recovery documentation

covers:

Ceph Block Storage RBD using mirroring
Ceph Filesystem Storage using CephFS mirroring

Description of your changes:
Which issue is resolved by this Pull Request:
Resolves #
Checklist:

[ ] Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide).
[x] Skip Tests for Docs: If this is only a documentation change, add the label skip-ci on the PR.
[ ] Reviewed the developer guide on Submitting a Pull Request
[ ] Pending release notes updated with breaking and/or notable changes for the next minor release.
[x] Documentation has been updated, if necessary.
[ ] Unit tests have been added, if necessary.
[ ] Integration tests have been added, if necessary.

@ideepika please check if the docs look good locally using make docs-preview

@ideepika please check if the docs look good locally using make docs-preview

looks good locally now, fixed a minor nit

authors: galexrt ideepika

repo: koor-tech/koor


text:
Error: Failed to list databases and collections error="(Unauthorized) not authorized on <database_name> to execute command"

After #25 and #26 were merged and deployed as version v0.1.14, I updated Vi-mongo to v0.1.14 and successfully connected to my sharded cluster.
After connecting I was greeted by a missing database pane and no databases or collections. My enterprise restricts access to some databases so queries to enumerate collections do not work, and no content is rendered in the pane even for sucessfully-queried databases.
Suggestion: when a database cannot be read because of restricted access, do not list that database in the databases list and do not attempt to enumerate collections for that database. Skip it and only render the databases whose collections can be enumerated.
Expected Behavior
I connect to my sharded cluster and see Databases listed with collections at a nested indentation level.
Observed Behavior
Vi-mongo version:
$ vi-mongo --version

 __      ___   __  __
 \ \    / (_) |  \/  |
  \ \  / / _  | \  / | ___  _ __   __ _  ___
   \ \/ / | | | |\/| |/ _ \| '_ \ / _` |/ _ \
    \  /  | | | |  | | (_) | | | | (_| | (_) |
     \/   |_| |_|  |_|\___/|_| |_|\__, |\___/
                                   __/ |
                                  |___/
Version v0.1.14

TUI:

Logs:
Small security nitpick: the vi-mongo.log logfile contained my password in plaintext, can you anonymize before logging to file?
$ tail -f /opt/bin/priv/vi-mongo.log
1:03PM ERR github.com/kopecmaciej/vi-mongo/internal/tui/modal/error.go:16 > Failed to list databases and collections error="(Unauthorized) not authorized on config to execute command { listCollections: 1, filter: {}, nameOnly: true, cursor: {}, lsid: { id: UUID(\"fake-uuid-000\") }, $clusterTime: { clusterTime: Timestamp(1730307830, 1), signature: { hash: BinData(0, 0123456789ABCDEF), keyId: 012345 } }, $db: \"config\" }"
1:04PM ERR github.com/kopecmaciej/vi-mongo/internal/tui/page/main.go:212 > Failed to render server info modal error="(Unauthorized) not authorized on admin to execute command { serverStatus: 1, lsid: { id: UUID(\"fake-uuid-000\") }, $clusterTime: { clusterTime: Timestamp(1730307840, 1), signature: { hash: BinData(0, 0123456789ABCDEF), keyId: 012345 } }, $db: \"admin\" }"
1:04PM INF github.com/kopecmaciej/vi-mongo/cmd/cmd.go:104 > Mongo UI started
1:04PM INF github.com/kopecmaciej/vi-mongo/internal/mongo/setup.go:38 > Connected to mongodb://USER:PASS@shard-00.mongodb.net:27017,shard-01.mongodb.net:27017,shard-02.mongodb.net:27017/admin?ssl=true&retryWrites=false&loadBalanced=false&replicaSet=replica-set-key&readPreference=primary&connectTimeoutMS=10000&authSource=admin&authMechanism=SCRAM-SHA-1
1:04PM ERR github.com/kopecmaciej/vi-mongo/internal/tui/modal/error.go:16 > Failed to list databases and collections error="(Unauthorized) not authorized on config to execute command { listCollections: 1, filter: {}, nameOnly: true, cursor: {}, lsid: { id: UUID(\"fake-uuid-001\") }, $clusterTime: { clusterTime: Timestamp(1730307870, 1), signature: { hash: BinData(0, 0123456789ABCDEF), keyId: 012345 } }, $db: \"config\" }"
1:04PM ERR github.com/kopecmaciej/vi-mongo/internal/tui/modal/error.go:16 > Failed to list databases and collections error="(Unauthorized) not authorized on config to execute command { listCollections: 1, filter: {}, nameOnly: true, cursor: {}, lsid: { id: UUID(\"fake-uuid-001\") }, $clusterTime: { clusterTime: Timestamp(1730307870, 1), signature: { hash: BinData(0, 0123456789ABCDEF), keyId: 012345 } }, $db: \"config\" }"
1:04PM ERR github.com/kopecmaciej/vi-mongo/internal/tui/page/main.go:212 > Failed to render server info modal error="(Unauthorized) not authorized on admin to execute command { serverStatus: 1, lsid: { id: UUID(\"fake-uuid-001\") }, $clusterTime: { clusterTime: Timestamp(1730307870, 1), signature: { hash: BinData(0, 0123456789ABCDEF), keyId: 012345 } }, $db: \"admin\" }"
1:04PM INF github.com/kopecmaciej/vi-mongo/cmd/cmd.go:104 > Mongo UI started
1:04PM INF github.com/kopecmaciej/vi-mongo/internal/mongo/setup.go:38 > Connected to mongodb://USER:PASS@shard-00.mongodb.net:27017,shard-01.mongodb.net:27017,shard-02.mongodb.net:27017/admin?ssl=true&retryWrites=false&loadBalanced=false&replicaSet=replica-set-key&readPreference=primary&connectTimeoutMS=10000&authSource=admin&authMechanism=SCRAM-SHA-1
1:05PM ERR github.com/kopecmaciej/vi-mongo/internal/tui/modal/error.go:16 > Failed to list databases and collections error="(Unauthorized) not authorized on config to execute command { listCollections: 1, filter: {}, nameOnly: true, cursor: {}, lsid: { id: UUID(\"fake-uuid-002\") }, $clusterTime: { clusterTime: Timestamp(1730307890, 1), signature: { hash: BinData(0, 0123456789ABCDEF), keyId: 012345 } }, $db: \"config\" }"

Great, thanks for finding another bug, I will create a PR for this one and fix it as soon as possible (especially the visibility of the password in the logs).

authors: benjamindburke kopecmaciej

repo: kopecmaciej/vi-mongo


text:
Provide SSL/TLS/HTTPS on native targets

Maybe we can embed boringssl https://boringssl.googlesource.com/boringssl/ or use native facilities on each platform.

On windows: https://docs.microsoft.com/en-us/windows/win32/winsock/using-secure-socket-extensions
On linux: https://stackoverflow.com/questions/7698488/turn-a-simple-socket-into-an-ssl-socket
On apple platforms: https://developer.apple.com/documentation/security/secure_transport // https://developer.apple.com/documentation/network

Another alternative is wininet for windows: https://github.com/localazy/kotlin-mpp-wininet

@Josef-Vonasek do you know the minimum required version of Window for using this API?
Relevant links:

https://github.com/localazy/kotlin-mpp-wininet/blob/4853faa86937047546a8acaf8f80a0d42168f9e1/src/windowsMain/kotlin/com/localazy/example/http/wininet/WinInetHelper.kt
https://docs.microsoft.com/es-es/windows/win32/wininet/portal

Looks like Windows 2000 Professional.

But that's for HTTP and FTP only, not for TCP sockets. The idea is to implement a layer to support TLS on all TCP sockets, so everything else works out of the box

authors: Josef-Vonasek soywiz

repo: korlibs/korio


text:
support labelselector and add retry mechanism when update globalnode

What type of PR is this?
/kind feature

What does this PR do?
support labelselector and add retry mechanism when update globalnode

Which issue(s) does this PR fix?

Fixes #
Special notes for your reviewer:

Does this PR introduce a user-facing change?

add issue for this PR

/lgtm
/approve

repo: kosmos-io/kosmos


text:
Add configuration management for routine VPN tasks, like adding peers

The VPN is the only component not managed in Kubernetes. Add a configuration management agent to automate routine tasks, like adding peers.

In the PR that closes this issue, we've decided to automate tasks like retrieving configuration files rather than creating them. The reason is because the VPN node is configured in Terraform, so to add a peer you could update the Terraform plan (specifically the VPN bootstrap script) and do terraform apply. It is less confusing to reapply the Terraform configuration than it is to use Ansible to modify the Terraform resource--plus, updating the Terraform configuration improves our ability to track changes to peers in version control.

repo: kostaleonard/populare-iac


text:
Missing Raise time; units

Hello, great library! How to understand Altitude and Azimuth values? What are units, also for others properties? Is it documented somewhere?

Thank you!

repo: kostebudinoski/SunCalcNet


text:
done task

Я рассмотрел 3 варианта библиотек:

https://github.com/Kotlin/kotlinx.cli
https://github.com/xenomachina/kotlin-argparser
https://ajalt.github.io/clikt/

Выбрал вторую, теперь комментарии почему:

Отсутствие документации и описания, как подключить к проекту без скачивания репозитория сразу  деморализовало, особенно учитывая, что есть второй вариант.
Наличие документации, пусть и не слишком полной, но понятной. Библиотека удобна в использовании, проста в освоении. Хватает функционала для выполнения задания и последующих возможных расширений.
Овер архитектура(шмархетектура), выглядит слишком сложно и заморочено. Хорошее преимущество - полная поддержка unix стиля, но несмотря на то, что библиотека лучше предыдущих, из-за её сложности использовать её в целях данного проекта нецелесообразно.

Есть ещё JCommander, но на Котлине лучше, по возможности, использовать библиотеки Котлина, чтобы не костылять с джавовской совместимостью, а пользоваться сразу адаптированной библиотекой с кучей синтаксических плюшек.

Теперь тесты падают :)
В остальном - ок @yurii-litvinov


text:
VisTree Spacing Issue

This image shows the problem:

The window on the left side shows the result I am getting. While the right side is the result of the Web demo. The spacing between the "expand triangle" and the label is missing.
I simply took the TestTree.java Window and added it to a Stage with a ScreenViewport.
It happens with both the VisLabels and the "normal" Labels.
My libgdx version is 1.9.10
My vis-ui version is 1.4.5-SNAPSHOT
I've just tested this on the Windows 64bit platform.

Web demo is using pretty old version so there are differences.
There is setIconSpacing method for Tree but it doesn't seem to have any effect when added.

authors: Crigges kotcrab

repo: kotcrab/vis-ui


text:
WIP: Multi line string

This is just to outline the idea behind issue #402.

Another idea would be to use more sophisticated libraries like https://github.com/google/diff-match-patch or https://github.com/wumpz/java-diff-utils to generate the difference lines.

I like the idea of using the google diff match patch. Interestingly, many years ago, I released it onto maven as at the time, google hadn't released it.
https://github.com/sksamuel/google-diff-match-patch

Great, would you have the time and will to look into the implementation?

Yes I think its a great idea, I'll add it to 3.2.

Great! But I think the milestone should go to the issue, not this PR.

Yes of course.

I agree that truncating error output is not ideal, but I'm :-1: on this. We used to do message compaction ourselves, but it was removed in #366 because it breaks IDE integration and makes it impossible to see the context when you do need it.
JUnit 5 removed message compaction for the same reasons, although if you use the JUnit 4 test runner, you'll still get the old behavior.
In my opinion, it would be worth seeing if it's possible to get the full strings to print on the command line rather than going back to mangled messages.

When looking at the context of how equalsErrorMessage() is called e.g. at https://github.com/kotlintest/kotlintest/blob/47b7a428d056fcac7d9abb2cb44ab4953fad0f70/kotlintest-assertions/src/main/kotlin/io/kotlintest/dsl.kt#L119 I was under the impression that this is really just the custom user-facing message, and that JUnit would construct its own error from expectedRepr and actualRepr that it gets passed, so I was assuming this would not break anything.
Also, compared to #366 I wasn't thinking of a word-diff feature within a line, but only removing / compacting whole equal lines. I currently don't see how that would break IDE integration.

So the way that the IDE integration works depends on the runner you're using.
When available, we use the JUnit assertions, which IntelliJ treats specially.
In JUnit5, the IDE ignores the message entirely, and uses the expected and actual values for its diff.
In JUnit4, we don't even pass the message to the exception, since the exception doesn't use it.
On other runners like TestNG, we throw a generic kotlin.AssertionError with the message.
It's that last case that would affect IDEs if you change the message. IDEs create a diff based on pattern matching, and right now your proposed change doesn't look like it matches any of them. However, that's easy to fix. We'd still lose the ability for IDEs to diff the entire file, which can definitely be confusing, since there's no way to see what the actual values were any more.
Now that I've given it some more thought, I agree with you that the negative impact is not likely to be significant. So I'll change my vote to +1, but let's make sure the compacted message matches one of the patterns the IDE looks for.

authors: ajalt sksamuel sschuberth

repo: kotlintest/kotlintest


text:
template ac:jiraissues returns error 500

What happened?
If I use the template ac:jiraissues I receive from the confluence an Error 500 "Internal Server Error". I tested this with only the required parameters and with all optional parammeters
What did you expect to happen?
That the Jira issue List would have been created on the confluence page.
How can we reproduce the behavior you experienced?

Add a macro with these values in the markdown

<!--` Macro: :testlist:
     Template: ac:jiraissues
     URL: https://jira.example.com/sr/jira.issueviews:searchrequest-xml/100000/SearchRequest-100000.xml?tempMax=1000
      -->

:testlist:

run mark

Further Information (please complete the following information)

Mark Version (mark --version): [ v9.12]
Mark Parameters: [--drop-h1 --title-from-h1]
Confluence Hosting: [Datacenter]
Confluence Version: [9.5.4]
Environment specific Information: [tested in Gitlab CI and Mac OS terminal]

Logs or other output
Please provide logs, other kind of output here.
Additional context
The problem can be solved when we change Line 170 and
Line 177 in the stdlib.go
The missing bit is that the urls need to be in the ri:url format similiar to Line 254.

Thanks for the PR, I merged it!

repo: kovetskiy/mark


text:
Add a Stream type and make iterate return a stream.

Stream is a handy type because it always has a head and a tail. It can also be dropped to NonEmpty and to the usual list free of charge. Unfolds without a base case are the class of functions that produce streams, iterate being the immediate example, and they could be typed as such.
I think this type would be a nice addition to Relude.

The problem with adding something like a new type (e.g. Stream) is that it won't have all the instances as the original type. This will result in code duplication, and code reuse actually won't be possible since the Stream type in relude will be different from Stream type in another library. Since we don't want to depend on more non-boot libraries according to the goals of this project, reexporing Stream is not an option unless it happens to be on one the boot libraries.

authors: chshersh kindaro

repo: kowainik/relude


text:
細かい修正

enginx経由でセッションが動作しない対処
https://stackoverflow.com/questions/18844863/sinatra-clears-session-on-post
enable: sessionの代わりにuse Rack::Session::Cookieを使用
sessinon破棄の時間が短い
Dockerファイルの修正
sinatra+mysql+nginxでの実行
静的ファイルをnginxで高速配信する点は未実装

enginx経由でセッションが動作しない対処

nginx ですね

ブランチ名minor_fixesなのに肥大してしまった笑
一通りできたのでマージします

authors: Konboi koyo-miyamura

repo: koyo-miyamura/latestgram


text:
Collection: Feature requests from users

[x] Download progress bar
[x] Mac update msg
[x] Auto-Login for OWA / BigBlueButton
[x] #20
[x] Enable screensharing for remote apps

Alle Prozesse in issues abgebildet

repo: koyuawsmbrtn/bbz-cloud


text:
명의 확인시 sqlite3 오류 발생

sqlite3.OperationalError: near "name": syntax error

재현 불가


text:
GeoCode in Census location but not in Census demog acs

I ran the macro and as I was reviewing the results, I found some GeoCodes in my cemsus_location file that were not in the census_demog_acs file.  I went to census.gov and put in one of the addresses for GeoCode 27139081302.  The results were indeed that GeoCode.  Is it expected that there are GeoCodes in census_location that are  not in the census_demog_acs files?
This is the response that I received from Al:
The geocoding app you're using is set to using the Census 2020 mapfiles. I could tell by eyeballing it was a split tract.... Here's how:
Let's start with the tract
27139081302
So… Here's how I read it:

State = 27 (MN)
County = 139 (Scott)
Tract = 081302 This 02 indicates that tract 0813 split into at least two tracts (01 and 02)

If you set the vintage indicator to 2010, you'll get a different result:
27139081300
From the Census https://www.census.gov/programs-surveys/geography/about/glossary.html:
The Census Bureau uses suffixes to help identify census tract changes for comparison purposes. Census tract suffixes may range from .01 to .98. As part of local review of existing census tracts before each census, some census tracts may have grown enough in population size to qualify as more than one census tract. When a census tract is split, the split parts usually retain the basic number but receive different suffixes. For example, if census tract 14 is split, the new tract numbers would be 14.01 and 14.02. In a few counties, local participants request major changes to, and renumbering of, the census tracts; however, this is generally discouraged. Changes to individual census tract boundaries usually do not result in census tract numbering changes.
Currently released ACS files are only through 2019, all of which use the Census map vintage of 2010. So… when we have a 2020 split tract… we need to be using a 2020 ACS (not released yet). If you want to use the 2010-2019 ACS files, you need to be using 2010 vintage geocodes. 2020 vintage geocodes should only be used on 2020-2029 ACS releases.
If you were on the call today… This is the elaboration on the macro I was talking about. The future state of VDW will likely require both 2010 and 2020 vintage geocodes for some years in which a person might have a MRN+LOC_START.

Thank you for adding the issue!
It also raises the concern that Census Location needs to include only the decade of the boundary year.
I think what we'll end up doing is adding an assessment step that rounds to the nearest tens place to assure the match in loc is pointing to the correct year in demog:
%macro round_tens(in_number);
	floor(&in_number/10)*10;
%mend round_tens;

GEOCODE_BOUNDARY_YEAR is being added to the CENSUS_DEMOG_ACS. This kind of obviates the need for further development.


text:
Able to choose between component/xcomponent.frame when importing

Hello,
We're using xcomponent (which is an awesome library, good work!) in a TypeScript/webpack project which means we use npm to install xcomponent and then import it:
import * as xcomponent from 'xcomponent'
The problem is we want to use the xcomponent without the ie-bridge since it causes errors in IE11 (somehow it thinks we want to use the bridge even though we don't use popups). I don't think we need to dig in this bug since without the IE-specific bridge code it works. If we look how react solves this (dev build vs prod build) they use environment variables to be able to choose which build should be included: https://github.com/facebook/react/blob/master/packages/react/npm/index.js
I was thinking if this might be a good idea for xcomponent as well? Maybe introduce a environment variable and let the user choose if one wan't to import the whole thing or without iframe support?

it causes errors in IE11 (somehow it thinks we want to use the bridge even though we don't use popups)

Weird. Can you share some more details about this? I'd like to figure out a solve either way.

Maybe introduce a environment variable and let the user choose if one wan't to import the whole thing or without iframe support?

I'm definitely open to this idea, and if you'd like to PR it in, I'd be more than happy with that. We're already using feature flags in src/ but I'd be more than happy to have them to help decide which bundle to use from dist/

Weird. Can you share some more details about this? I'd like to figure out a solve either way.

I'll try to explain from memory, I don't have a minimal code to recreate the error.
We're having two iframes in the parent page which needs to communicate between each other. We solve this by having both iframes provide a callback to the parent and have our own kind of bridge to tunnel the messages from one iframe to the other via the provided callbacks.
When enabling debug mode we see this error:

Can only use bridge to communicate between two different windows, not between frames.

This error is thrown in the post-robot code:
https://github.com/krakenjs/post-robot/blob/c54c30635b4c715c7dffab7ca2371e4ff7c1436c/src/drivers/send/strategies.js#L75
So the question is why is postrobot assuming we use a bridge here? No external window is created. We just have our two iframes.

I'm definitely open to this idea, and if you'd like to PR it in, I'd be more than happy with that. We're already using feature flags in src/ but I'd be more than happy to have them to help decide which bundle to use from dist/

I'll submit a PR.

Thanks for the PR! And appreciate you sharing details on the issue. I'll take a look.

Oh wait, you only see the issue during debug mode? That's probably expected. The throw there is just used as a way to short-circuit that messaging path.
Anyway, either way, probably best to use the .frame.js build 👍

Oh wait, you only see the issue during debug mode? That's probably expected. The throw there is just used as a way to short-circuit that messaging path. Unless it causes any issues beyond error logs?

Yes, the original issue was that message passing between child page and parent page was slow, around 200-300 ms. When enabling debug logs (defaultLogLevel: 'debug') we got the specified error. defaultEnv was still in prod mode. We also got this log in Sentry:

Error: No handler found for post message ack for message: postrobot_method from http://domain1 in https://otherdomain

Note we're having http/https, might that cause this issue?
I'm having a hard time knowing which logs and errors are related to the problem we had. So I didn't know what info to provide in the original issue. Bear with me :-) .
With the .frame.js-build no error occured in the logs and the message passing was super fast. So I'm not sure the error was expected? :-)

Hey, I'm using Webpack as well, and want to mention that PR #153 has doubled my webpack build size, presumably because Webpack cannot suss out whether both xcomponent.frame.js and xcomponent.js are required and ends up bundling them both in. To be honest I'm still figuring out XComponent and don't have a clear idea of the difference of these two modules, but I do see my bundle size double after xcomponent@6.0.52.
To mitigate this, I'm just importing directly the frame js (as I also only need the frame version): import xcomponent from 'xcomponent/dist/xcomponent.frame', which imho seems a bit cleaner and explicit than using env-vars.

Yikes. Out of interest, which version of webpack are you using, and do you have uglify enabled?

Webpack 3, and experienced both with and without uglify enabled.
The specific webpack settings in using are those generated by the VueJs CLI 3 boilerplate.

I'm using webpack as well and recently changed the xcomponent dependency to zoid. I saw the build size more than double, a similar experience as @doublemarked. I'm still debugging, but found myself on this issue and wanted to note my findings.
xcomponent 6.0.49 was the previous install version.

Just upgraded to zoid@9 and still facing this. However, it seems that changes since zoid@7 now prevent an import of zoid/dist/zoid.frame. I've got it working by changing to require: require('zoid/dist/zoid.frame')...
Still feels kind of hacky and it's unclear whether this is the intended use of the module.

This is still a problem. Even require('zoid/dist/zoid.frame') isn't working in zoid@9.

@KyorCode I can't remember the reason, but we are using currently require('zoid/dist/zoid.frameworks')

I'm having the same issue.
This does not work, zoid is undefined
import zoid from 'zoid/dist/zoid.frameworks';

This somehow works:
const zoid = require('zoid/dist/zoid.frameworks');

I'm using "zoid": "9.0.42"

authors: KyorCode bluepnume doublemarked jimmyn n00b2pr0 r0stig

repo: krakenjs/zoid


text:
Retrieve params within a route

Hello Krasimir,
First of all, much thanks for the awesome work on Navigo, I how simple it handles things !
I'd like to know if there's a way to retrieve params within a route ( ex. product/:id ), I'd like to do it using just Navigo Methods ( If it's possible, and I doubt it cause I searched within the code and nothing appears to handle such a case… correct me if I am wrong ).
I'd sort it out myself with some additional JS, if this isn't an existing feature I'd be glad to share my thoughts about it …
Thanks in advance for your reply.

Hello,
yep, there is such a feature - parameterized urls.

repo: krasimir/navigo


text:
cURL error 28

Kreait\Firebase\Exception\Database\DatabaseError cURL error 28: Failed to connect to oauth2.googleapis.com port 443
This problem appears and disappears

https://curl.se/libcurl/c/libcurl-errors.html
curl Error 28 is a connection timeout. If it happens sometimes and sometimes not, it's either the network connection of your environment or the remote host is not reachable, but unfortunately not this library (I say unfortunately because otherwise I could fix it :))

https://curl.se/libcurl/c/libcurl-errors.html
curl Error 28 is a connection timeout. If it happens sometimes and sometimes not, it's either the network connection of your environment or the remote host is not reachable, but unfortunately not this library (I say unfortunately because otherwise I could fix it :))

authors: Marwan-amer jeromegamez

repo: kreait/laravel-firebase


text:
Add support for undefined

Is your feature request related to a problem? Please describe.
In JS world, undefined is more common than null - it would be nice if we could work with that.
Describe the solution you'd like
A new public API method for handling both null & undefined

Fixed in https://github.com/kreatemore/optional-type/pull/2

repo: kreatemore/optional-type


text:
refactor: remove turbo mode patch

Checklist:

[ ] Have you added an explanation of what your changes do and why you'd like them to be included?
[ ] Have you updated or added documentation for the change, as applicable?
[ ] Have you tested your changes on all related environments with successful results, as applicable?

Type of Changes:

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

What is the current behavior? (link to any open issues here)
What is the new behavior (if this is a feature change)?
Other information:

/test k8s

repo: krestomatio/moodle-operator


text:
Add menus for roster

Idk how reaction predicate works, but I'd say probably use that or DEFAULT_CONTROLS because otherwise roster will just run down eternally.

Thanks. I've looked into it this evening but haven't used the redbot.core.utils.menu module before. Feel free to create a PR if needbe, Jojo or I shall look at this over the next couple of days.

Cool cool. I'm not familiar with any of the redbot utils so its probably something I can't contribute towards. I see that DC was used in awbadge so I guess you could just replicate and modify that chunk of code and move it into the roster section. But again that may be completely different due to that awbadge embeds are already defined separately, so you can append them together; I assume it wouldn't work like that from user data from the dict inside an embed field. Eitherway, see what you can do, idk if it would come under predicate or default controls.

Predicates wouldn't work because they're designed for yes or no type reactions. They would make decisions but would do it a lot less efficiently than just using default controls. I'm sure it would be fairly simple to pagify the list for roster and as I said I will look into this, tomorrow.

I can work on getting a menus system for the Roster. Shouldn't take too long as menus are pretty easy to make 😅

Will do!

okay, looks like i will be looking at this then

Due to the fact that MCOC and Alliance cogs have been pushed over to a different repository, I am not going to be making any changes here. I will keep this open for a while if there are additional questions/statements.
Seeing as Jojo was assigned to this, he could do some work on this issue in his own repo. Andreas, I suggest opening an issue at his repo.

authors: Just-Jojo konamino kreus7


text:
Write some documentation about tested CMS'es

Acceptance criteria:

Written in Dropbox Paper CMS file
Pricing
Content creation (how to)
Pros
Cons

Can we close this?

authors: deannabosschert kriskuiper

repo: kriskuiper/cmd-digital-playground


text:
Galleria's Fatal Error

After including the gem in the Gemfile and bundle install and configuring Galleria, I receive this error for built-in classic theme.
Fatal error: Theme CSS could not load after 20 sec. Please download the latest theme at http://galleria.io/customer/
I'm not sure if that's Galleria's error or the gem's error. So, I'll be creating an issue on both repositories, just to be sure.
I'm on ruby 2.1.0p0, rails 4.1.0 & rails-gallery 0.3.3 it's happening on both localhost and development. The gallery however does work as expected with no problem whatsoever.

Damn, I forgot to reply to your comment after getting this resolved.

repo: kristianmandrup/rails-gallery


text:
Drop the 5.3 PHP support

Drop the 5.3 PHP support fix build failing on 5.3.

That's not dropping support, as you don't tell composer about the new minimum version. that's only dropping CI for 5.3 (meaning shipping untested code to PHP 5.3 users)

#880 includes the dropping of 5.3 support.  Not sure if this is needed.

This has been implemented in the 2.0 branch of assetic-php/assetic. Until we tag 2.0, you can pull it in by using "assetic/framework": "dev-2.0/dev" in your composer.json files.

authors: LukeTowers ghost james-nesbitt stof

repo: kriswallsmith/assetic


text:
Fix MatchesMapperDb

Hello!
Please, change in
includes/Mappers/MatchesMapperDb.php:346
heroid for hero_id
Another thing is:
with setAccountId and\or setHeroId set, and if no matches found, MatchesMapperDb will return all matches.
Can you fix it?
Probably something like in:
includes/Mappers/MatchesMapperDb.php:309
else {
return array();
}

Hi, @et1a1nen. Thanks for report and sorry for long response-time.

heroid for hero_id
Fixed
with setAccountId and\or setHeroId set, and if no matches found, MatchesMapperDb will return all matches.
It's normal behavior. You may create your own class and override method _getMatchesIdsFromMatches


text:
What about Performance?

Hi, I really like your mapping library and its api. Are there any performance benchmarks comparing manually mapping vs mapstruct and shapeshift?

Generally we've not done any comprehensive benchmarks yet, but performance wise ShapeShift will most likely fare worse to mapstruct, seeing as they use code generation and have very little overhead at runtime whereas we made the choice to map at runtime for several reasons;

It centralizes the mapper. (No need for XToYMapper, everything can be mapped via ShapeShift by just supplying the source and target)
It doesn't require the user to add an annotation processor to their project.
In addition to mapping by annotations, we also support a Kotlin DSL for defining mappings. As the DSL is parsed at runtime, there is no way for us to generate code from it without further complicating the development experience for the end user.
We also put a heavy emphasis on Spring use and transformer beans, the ability to have context-aware mappings which may make additional calls (For example, to a database) or checks with other beans is crucial to our design.

Leaving this open so we can address this, thanks!

It would be great to be mentioned in the documentation. Somewhere at overview section. Tried to find before found this issue

authors: Idane nguchakov qoomon

repo: krud-dev/shapeshift


text:
Included a test to validate kruize pod restart behavior

Included a test to validate kruize pod restart behavior

@dinogun - can you please review this, thank you.

repo: kruize/autotune


text:
Crash on Markdown language highlighting

Hi! 👋
First of all, thanks for the great work on STTextView and the Neon plugin, it's amazing!
I have run into an issue recently where if I use the NeonPlugin to parse and highlight Markdown Strings, I get a crash on this line of the Coordinator file of the plugin:

I have done a bit of digging and it looks like there are no highlight queries for the markdown language, which explains the crash. Could this be that there is an issue with the markdown tree sitter or its build process?
Not entirely sure how to regenerate the tree sitter to test it myself, but I am happy to help out to look into it if you know the cause?

ha! It does not provide a highlight query. There is an issue https://github.com/ikatyang/tree-sitter-markdown/issues/23 and it looks like we should get it from https://github.com/nvim-treesitter/nvim-treesitter/tree/master/queries/markdown

tree-sitter-xcframework 0.208.5 should fix that

authors: krzyzanowskim polpielladev

repo: krzyzanowskim/STTextView-Plugin-Neon


text:
Not to spam deselect event on click and DnD when node is already selected

Deselect/select actions pairs shouldn't be triggered on click if their target is already in selection

I suggested solution here https://github.com/kseniaSs/react-flow-editor/pull/14

repo: kseniaSs/react-flow-editor


text:
Add preliminary ServingRuntime support

What this PR does / why we need it:
This PR adds preliminary Serving Runtime support as outlined in this proposal document.
Example InferenceService will look like:
apiVersion: "serving.kserve.io/v1beta1"
kind: "InferenceService"
metadata:
  name: "sklearn-iris"
spec:
  predictor:
    model:
      framework:
        name: sklearn
        version: "0"
      # runtime: kserve-sklearnserver
      storageUri: "gs://kfserving-samples/models/sklearn/iris"
      env:
        - name: SOME_ENV_VAR
          value: foo
    minReplicas: 2
    maxReplicas: 3

Will be adding some tests shortly.
Followup PRs can be done to:

Adjust the InferenceService mutator to convert old schema into the new schema.
Add more default ClusterServingRuntimes

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1816
Release note:

Add ClusterServingRuntime and ServingRuntime CRD support

@pvaneck The inferenceservices are registered with name "model" instead of inferenceservice name.

@Suresh-Nakkeran Thanks for pointing that out. Hmm, one way to fix that from the Isvc spec is under spec.predictor.model add:
      args:
        - --model_name=sklearn-iris

However, I realize that having to add this quite hampers the user experience.
Need to figure out a good way to automatically pass in the Isvc name to whatever arbitrary flag or env variable the runtime expects. the KFServer-based runtimes require that --model-name be passed in with the Isvc name. And I think MLServer requires that the MLSERVER_MODEL_NAME env var be set to the Isvc name.
Perhaps having some known placeholder/template variable be used (e.g. ${{ INFERENCESERVICE_NAME }} or ${{ metadata.name }}) in the ServingRuntime args/env that is processed and substituted with the InferenceService name. So args for the sklearn serving runtime might look something like:
args:
    - --model_name=${{ INFERENCESERVICE_NAME }}
    - --model_dir=/mnt/models
    - --http_port=8080

But that placeholder will eventually be replaced before passing off the container spec.
@yuzisun @njhill WDYT?

@pvaneck @yuzisun I just tried the below approach in my local that we can have default model name "model" in runtime. In Predictor reconcile, we can update model name where we update runtime container. The model name can also be part of environment.
// Update default model name with inferenceservice name in args and envs if it exists
isvcutils.UpdateModelName(container, isvc.ObjectMeta.Name)

func UpdateModelName(container *v1.Container, name string) {
	// update model name in args if exists
	args := container.Args
	for i, vv := range args {
		if strings.Contains(vv, "model_name") {
			args[i] = fmt.Sprintf("%s=%s", constants.ArgumentModelName, name)
			break
		}
	}

	// update model name in envs if exists
	envs := container.Env
	for i, vv := range envs {
		if vv.Name == constants.MLServerModelNameEnv {
			envs[i] = v1.EnvVar{Name: constants.MLServerModelNameEnv, Value: name}
		}
	}

	container.Args = args
	container.Env = envs
	return
}

@Suresh-Nakkeran That approach is a bit specific towards the KFServer and MLServer runtimes. Would like to keep it flexible enough to where a user can inject the inferenceservice name into the runtime even if the argument or env variable is named something else (i.e. not --model_name or MLSERVER_MODEL_NAME). This  is why I am leaning towards introducing a template variable that can be used in the ServingRuntime yaml. Though, I am open to other solutions.

/retest

seems like there is a race condition during installation, the ClusterServingRuntime crd is not ready yet when creating the serving runtimes.
unable to recognize "STDIN": no matches for kind "ClusterServingRuntime" in version "serving.kserve.io/v1alpha1"
unable to recognize "STDIN": no matches for kind "ClusterServingRuntime" in version "serving.kserve.io/v1alpha1"

@Suresh-Nakkeran That approach is a bit specific towards the KFServer and MLServer runtimes. Would like to keep it flexible enough to where a user can inject the inferenceservice name into the runtime even if the argument or env variable is named something else (i.e. not --model_name or MLSERVER_MODEL_NAME). This is why I am leaning towards introducing a template variable that can be used in the ServingRuntime yaml. Though, I am open to other solutions.

ye template approach(e.g go template) sounds good to me. @pvaneck, @Suresh-Nakkeran is working on a follow up PR after this is merged in, so I think he can help implement the template there.

ye template approach(e.g go template) sounds good to me. @pvaneck, @Suresh-Nakkeran is working on a follow up PR after this is merged in, so I think he can help implement the template there.

Sounds good. Can try to get this one in asap so follow-up PRs and enhancements can be performed in parallel. Trying to get the E2E tests to pass.
I believe a list of some of the to-dos are:

Add template variable support for enabling passing in isvc name to runtime container.
Add more default ClusterServingRuntimes
Adjust the InferenceService mutator to convert old schema into the new schema.
Add weight/priority to Framework/ModelType, and add associated logic?
Add E2E tests using new format
Eventually add default ClusterServingRuntimes as a part of the default installation (perhaps generate separate yaml file for default runtimes as including the runtimes in the main default install causes that race condition with the CRD not existing yet).

Also, wasn't quite sure where we landed with the Framework vs ModelType naming inside the ModelSpec. ModelMesh uses ModelType, but I currently still have it as Framework here. Does predictor.model.modelType make sense?

Need to figure out why E2E tests are failing with:
HTTP response body: {"kind":"Status","apiVersion":"v1","metadata":{},"status":"Failure","message":"Internal error occurred: failed calling webhook \"inferenceservice.kserve-webhook-server.defaulter\": Post \"https://kserve-we
bhook-server-service.kserve.svc:443/mutate-serving-kserve-io-v1beta1-inferenceservice?timeout=10s\": no endpoints available for service \"kserve-webhook-server-service\"","reason":"InternalError","details":{"causes":[{"message":"failed c
alling webhook \"inferenceservice.kserve-webhook-server.defaulter\": Post \"https://kserve-webhook-server-service.kserve.svc:443/mutate-serving-kserve-io-v1beta1-inferenceservice?timeout=10s\": no endpoints available for service \"kserve
-webhook-server-service\""}]},"code":500}

Need to figure out why E2E tests are failing with:
HTTP response body: {"kind":"Status","apiVersion":"v1","metadata":{},"status":"Failure","message":"Internal error occurred: failed calling webhook \"inferenceservice.kserve-webhook-server.defaulter\": Post \"https://kserve-we
bhook-server-service.kserve.svc:443/mutate-serving-kserve-io-v1beta1-inferenceservice?timeout=10s\": no endpoints available for service \"kserve-webhook-server-service\"","reason":"InternalError","details":{"causes":[{"message":"failed c
alling webhook \"inferenceservice.kserve-webhook-server.defaulter\": Post \"https://kserve-webhook-server-service.kserve.svc:443/mutate-serving-kserve-io-v1beta1-inferenceservice?timeout=10s\": no endpoints available for service \"kserve
-webhook-server-service\""}]},"code":500}

@pvaneck this is the crash stack from controller
E1122 09:46:23.242494       1 runtime.go:78] Observed a panic: runtime.boundsError{x:0, y:0, signed:true, code:0x0} (runtime error: index out of range [0] with length 0)
goroutine 511 [running]:
k8s.io/apimachinery/pkg/util/runtime.logPanic(0x1aff6e0, 0xc00116a540)
        /go/pkg/mod/k8s.io/apimachinery@v0.19.2/pkg/util/runtime/runtime.go:74 +0xa3
k8s.io/apimachinery/pkg/util/runtime.HandleCrash(0x0, 0x0, 0x0)
        /go/pkg/mod/k8s.io/apimachinery@v0.19.2/pkg/util/runtime/runtime.go:48 +0x82
panic(0x1aff6e0, 0xc00116a540)
        /usr/local/go/src/runtime/panic.go:969 +0x166
github.com/kserve/kserve/pkg/controller/v1beta1/inferenceservice/components.(*Predictor).Reconcile(0xc001152940, 0xc0006b9800, 0x13, 0x2010a60)
        /go/src/github.com/kserve/kserve/pkg/controller/v1beta1/inferenceservice/components/predictor.go:171 +0x1b01
github.com/kserve/kserve/pkg/controller/v1beta1/inferenceservice.(*InferenceServiceReconciler).Reconcile(0xc000745f40, 0x2004c60, 0xc00086ce10, 0xc000a2a040, 0x12, 0xc000a2a020, 0
x14, 0xc00086ce10, 0x40941b, 0xc00084e000, ...)
        /go/src/github.com/kserve/kserve/pkg/controller/v1beta1/inferenceservice/controller.go:166 +0x622
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler(0xc000a8fe00, 0x2004ba0, 0xc000cccb00, 0x1a4b5c0, 0xc0009e73e0)

Thanks @pvaneck ! This is awesome work !
/lgtm
/approve

We can follow up the work in https://github.com/kserve/kserve/issues/1924

authors: Suresh-Nakkeran pvaneck yuzisun

repo: kserve/kserve