text:
Set up CI with Azure Pipelines

PR checklist

[x] Addresses an existing issue: fixes #656
[X] New feature, bugfix, or enhancement

[ ] Includes tests

[ ] Documentation update

Overview of change:
Add support for CI using Azure Pipelines
Is there anything you'd like reviewers to focus on?
I have created a new organization and project on Azure Devops to support the tslint-microsoft-contrib project here: https://dev.azure.com/tslint-microsoft-contrib/
I invited Joshua Goldberg and Hamlet D'Arcy and made them collection level admins.

Is it possible to setup more node version and probably Windows builds too?
Looks a bit strange to test only against Node 8 while Node 10 is latest LTS.

Add #656 to track community discussion.

Per #656: anything we switch to would need to have feature parity with what we have now in OS and Node versions.
Per #489: tslint-microsoft-contrib is going to get rid of its older rule tests and fully switch to TSLint core's. We can save some work by finishing that work first.

@lupine86 One more suggestion: you sent a PR from your master branch, which means pulling in updates to this repository's master branch can be a little annoying. I'd recommend:

Completely resetting your local master to this repository's
Create a new branch, say azure-pipelines, off that reset master
Copying the changes you added in this PR on a commit on that branch
Sending a similar PR from that branch to this repository
Deleting this PR

I'm basing this suggestion off the reported 210 commit difference in your branch on this PR, since it looks like something went wrong in Git land. Apologies if you already knew this!

@JoshuaKGoldberg I've addressed your feedback so far. Please let me know if there's anything else, if not I'll make a new PR and branch. I ran into some issues when I was trying to squash the commits and it had unexpected effects and says I made 210 commits even though they're not mine. The only thing that's different right now is the package-lock.json file but that should fix itself when I reset things.

Yup, looks good! Once the package.json and package-lock.json changes are undone it looks like we can merge this in for testing.

Super, thanks for making progress on this! Closing this PR in favor of #838.

authors: IllusionMH JoshuaKGoldberg apawast lupine86


text:
Is vcpkg dead?

Is this project dead?
I posted a couple of questions over three weeks ago that are showstoppers for me to use vcpkg and I haven't heard anything.

Support? )))

@zhulika vcpkg is indeed very much alive. Sorry we haven't gotten back to you sooner. We're swamped with issues and PRs and are first triaging the issues and commenting on PRs as they come in. The team is focusing on closing/accepting "high impact" issues/PRs first. Thank you for being patient, and I hope the team can get to your questions soon! Mind linking the questions you asked here? It'll help us get to them quicker. I found one but not the other

@tara-raj
Some checks were not successful
1 failing and 1 successful checks
Vcpkg-PR-Eager —  failed
Details ???
Better make the error output by applying log files
To be able to see exactly what errors were admitted during the porting
Because the local build is successful and what you have on the server is not clear at all

@tara-raj Is VS 2019 supported yet in vcpkg? VS 2019 came out more than two weeks ago and it would be a real no-go if it wasn't supported yet. I see some potentially worrying issues like #6078. Also the main page Readme still says "Prerequisites: VS 2015U3 or 2017" and doesn't list 2019.

The CMake version included in VS2019 does not even support VS2019 and people are worried that vcpkg is not supporting it.... Even if libraries build with vcpkg are compiled with VS2017 they will work fine in a project using VS2019 due to binary compatibility.

The CMake version included in VS2019 does not even support VS2019 and people are worried that vcpkg is not supporting it.... Even if libraries build with vcpkg are compiled with VS2017 they will work fine in a project using VS2019 due to binary compatibility.

@Neumann-A The situation is more irritating than that. With a side-by-side install (17/19), vcpkg tries to build with VS19, using the VC17 included cmake (cmake-3.12.4).
I'v raised an issue [on the MS thingy (via the IDE)] and have equally suggested to update both to cmake-3.14.1 and to keep them synced at all time (to avoid issues). I have also mentioned that this causes issues in vcpkg.

@degski I probably never saw an issue with that because I have a separate CMake installation on the path although I have a side-by-side install of VS2017 + VS2019. vcpkg is happily using the separate one. So to me it seems like having a standalone installation of a current CMake version on the PATH works as a workaround?

@Neumann-A How did you do that? I have a standalone 3.14.1 install as well, but it still tries to use the VS-supplied one(s). Your standalone, is it 32- or 64-bit [mine the latter]?

@degski Don't know just works. 64 Bit version. Be sure to add CMake to the PATH variable for all users.
(I inspected the path variable and there is no VS path in the path variable. )
here one line from one of the config logs.
[1/2] cmd /c "cd .. && "C:/Program Files/CMake/bin/cmake.exe" "G:/vcpkg_test/vcpkg/buildtrees/abseil/src/4345461f32-f9655ed6fe" "-DCMAKE_MAKE_PROGRAM=C:/Program Files (x86)/Microsoft Visual Studio/2017/Enterprise/Common7/IDE/CommonExtensions/Microsoft/CMake/Ninja/ninja.exe"

@Neumann-A Sure it's added to the path, one of the first entries. I wished VS doesn't ship with these things [like ninja] and simply prompts the user to install those from the original source.

set VSCMD_DEBUG=1
call "C:\Program Files (x86)\Microsoft Visual Studio\2017\Enterprise\VC\Auxiliary\Build\vcvars64.bat"
[DEBUG:VsDevCmd.bat] calling "ext\cmake.bat"
[DEBUG:ext\cmake.bat] init:COMPLETE

C:\Program Files (x86)\Microsoft Visual Studio\2017\Enterprise\Common7\Tools\vsdevcmd\ext
...
:export_path

if not exist "%VSINSTALLDIR%Common7\IDE\CommonExtensions\Microsoft\CMake\CMake\bin" goto :error_setting_path
if not exist "%VSINSTALLDIR%Common7\IDE\CommonExtensions\Microsoft\CMake\Ninja" goto :error_setting_path
set "PATH=%PATH%;%VSINSTALLDIR%Common7\IDE\CommonExtensions\Microsoft\CMake\CMake\bin;%VSINSTALLDIR%Common7\IDE\CommonExtensions\Microsoft\CMake\Ninja"
goto :end

:error_setting_path
...

rename *.exe
"%VSINSTALLDIR%Common7\IDE\CommonExtensions\Microsoft\CMake\CMake\bin"
"%VSINSTALLDIR%Common7\IDE\CommonExtensions\Microsoft\CMake\Ninja"

@tara-raj. Thank you for your reply. The two questions that I asked were: #5714 and #5715.
I have now received a reply to #5715 but no response to #5714, yet.
The one about "integration" is not as urgent as the issues that I have with your version of libsodium, but it did lead me to wonder whether vcpkg was still a supported product as it refers to compatibility with VS2019 and not some third-party product. I'm pleased to hear that you are still with us, though!

@patrikhuber @degski We've updated to CMake 3.14.0 since one week ago[1], which brings general support for VS 2019[2]. If there are any remaining issues, please let us know specifically so we can fix them!
Additionally, if you'd like to force vcpkg to continue using a side-by-side VS2017 instance, you can use the VCPKG_VISUAL_STUDIO_PATH triplet setting to specify exactly which instance to use.
[1] https://github.com/Microsoft/vcpkg/pull/5702
[2] https://cmake.org/cmake/help/v3.14/release/3.14.html
[3] https://github.com/Microsoft/vcpkg/blob/master/docs/users/triplets.md#vcpkg_visual_studio_path

@ras0219-msft Thanks, Robert... Will give it a go as soon as something needs upgrading (and is not Boost). Don't really see a need for using 17 over 19, but thanks for the option at least.

source: gharchive/issue

authors: Neumann-A Voskrese degski patrikhuber ras0219-msft tara-raj zhulika

repo: Microsoft/vcpkg

license: MIT

license_type: permissive

license_source: github-api


text:
fixed an incorrect relative directory that pointed into wrong location

applocal.ps1 was unable to copy dependent libraries to output directory because installedDir parameter pointed into incorrect location

Hi @jhruby, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, MSBOT;

Thanks for catching this! I'll fix the other relative reference in this file.

source: gharchive/pull-request

authors: jhruby msftclas ras0219-msft


text:
Fix error reporting for GetStaticParametersForMethod

This fixes an error reporting problem for the F# 4.0 feature "static parameters for methods" reported by @dmitry-a-morozov
See https://github.com/fsprojects/FSharp.TypeProviders.StarterPack/issues/63
If possible this should be applied to the next Visual F# Tools update.

The indication that the fix is good can be found in the correct error messages here and here

Cool. Thanks Don.
Would be nice if
https://github.com/Microsoft/visualfsharp/issues/640
https://github.com/Microsoft/visualfsharp/issues/641
https://github.com/Microsoft/visualfsharp/issues/642
will make into Update 1 too.
I made nice progress on integrating statically parameterized methods with FSharp.Data.SqlClient.
https://github.com/fsprojects/FSharp.Data.SqlClient/blob/V2/src/SqlClient.Tests/CreateCommand.fsx
It's planned for V2.
But I probably won't ship production ready V2 until these issues resolved because to me they are serious usability blockers.

This change is good to go in.

merged into vs2015

Thanks for merging!

authors: KevinRansom dmitry-a-morozov dsyme

repo: Microsoft/visualfsharp


text:
Add support for .NET Standard 1.5

This adds .netstandard1.5 and netcoreapp1.0 as targets for VS MEF.
Unit tests run on net45 as before, and now also runs on netcoreapp1.0 to prove that vs-mef works on both platforms.
A couple of caveats regarding .NET Core support:

slow reflection only (by name rather than by metadata token)
NoPIA isn't supported on CoreCLR

Closes #15

@AArnott,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

It all looks good to me as far as I can see.

Codecov Report

Merging #21 into master will decrease coverage by 0.94%.
The diff coverage is 67.82%.

@@            Coverage Diff             @@
##           master      #21      +/-   ##
==========================================
- Coverage      84%   83.06%   -0.95%
==========================================
  Files          71       72       +1
  Lines        5389     5561     +172
  Branches      833      853      +20
==========================================
+ Hits         4527     4619      +92
- Misses        635      711      +76
- Partials      227      231       +4

Impacted Files
Coverage Δ

...dio.Composition/Configuration/CachedComposition.cs
100% <ø> (ø)
:arrow_up:

...VisualStudio.Composition/StandardAssemblyLoader.cs
66.66% <ø> (ø)
:arrow_up:

...lStudio.Composition/Configuration/NetFxAdapters.cs
76% <0%> (-3.73%)
:arrow_down:

....VisualStudio.Composition/Reflection/MemberDesc.cs
0% <0%> (ø)
:arrow_up:

...oft.VisualStudio.Composition/CollectionServices.cs
75% <100%> (+0.45%)
:arrow_up:

...sualStudio.Composition/CompositionConfiguration.cs
91.69% <100%> (+0.15%)
:arrow_up:

...mposition/Configuration/AttributedPartDiscovery.cs
95.37% <100%> (ø)
:arrow_up:

...omposition/ByValueEquality+AssemblyNameComparer.cs
92% <100%> (ø)
:arrow_up:

...figuration/ExportMetadataViewInterfaceEmitProxy.cs
85.71% <100%> (-0.96%)
:arrow_down:

...Microsoft.VisualStudio.Composition/LazyServices.cs
78.26% <100%> (ø)
:arrow_up:

... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 140b3bc...6fcc4b1. Read the comment docs.

authors: AArnott KirillOsenkov codecov-io msftclas

repo: Microsoft/vs-mef


text:
Can't get tracing to work

I added a trace.server setting to my extension (based on the tslint extension), but I'm not seeing any output in the output window when debugging.
Am I missing some code or configuration to make this work?

I think the exact setting is "<id>.trace.server", where <id> is the ID from the LanguageClient constructor call. It seems you're actually using the constructor overload without an ID here, not sure what ID it would use in that case:
https://github.com/glen-84/vscode-sass-lint/blob/d5e04e6fc10523aa0de971cd58954792495cc4f5/sass-lint/src/extension.ts#L144
Try something like:
const client = new LanguageClient("sass", "Sass Lint", serverOptions, clientOptions);

And in settings.json:
"sass.trace.server": "verbose"

I used:
const client = new LanguageClient("sasslint", "Sass Lint", serverOptions, clientOptions);

... and it works! 🎉
Thank you so much. I will credit you when releasing the fix (tomorrow or next weekend).

Haha, no need. :) Happy to hear you got it working!

repo: Microsoft/vscode-languageserver-node


text:
Microsoft Python Server excess memory usage

Environment data

VS Code version: 1.30 Insiders
Extension version (available under the Extensions sidebar): 2018.11.0
OS and version: Windows 10, 64, 1803
Python version (& distribution if applicable, e.g. Anaconda): Anaconda (Python 3.7)
Type of virtual environment used (N/A | venv | virtualenv | conda | ...): N/A
Relevant/affected Python packages and their versions: N/A

Expected behaviour
Reasonable memory usage after prolonged use in a small project (~10 files of <1k lines each) with constant changes in all files.
Actual behaviour
Memory use by the server Microsoft.Python.LanguageServer.exe specifically reached ~10GB after around 16 hours since the most recent restart.
Update:
After force killing the server, it climbs up again pretty fast to around 5GB. That's within ~20
Steps to reproduce:

Have a small-to-moderate project with several local packages (nested modules).
Constantly edit the files.
There might appear several, consistent "Reloading modules" messages in the "Output" panel.
After around 20 mins of use of a VSCode instance, this should happen.

Logs
Output for Python in the Output panel (View→Output, change the drop-down the upper-right of the Output panel to Python)
Starting Microsoft Python language server.
Microsoft Python Language Server version 0.1.65.0
Initializing for C:\ProgramData\Anaconda3\python.exe
Microsoft Python Language Server version 0.1.65.0
Initializing for C:\ProgramData\Anaconda3\python.exe
Microsoft Python Language Server version 0.1.65.0
Initializing for C:\ProgramData\Anaconda3\python.exe
Microsoft Python Language Server version 0.1.65.0
Initializing for C:\ProgramData\Anaconda3\python.exe
Reloading modules...
Reloading modules...
done.
Reloading modules...
done.
done.
Reloading modules...
done.
Reloading modules...
Reloading modules...
done.
done.
Reloading modules...
done.
[and on and on]

Output from Console under the Developer Tools panel (toggle Developer Tools on under Help)
N/A

Duplicate of Microsoft/python-language-server#479.

authors: brettcannon narfanar

repo: Microsoft/vscode-python


text:
Mention Black as option for code formatter

Readme only mentioned yapf and autopep8 but black is also supported in latest release.
Fixes #
black was missing from list of supported formatters.
This pull request:

[x] Has a title summarizes what is changing
[ ] Includes a news entry file (remember to thank yourself!)
[ ] Has unit tests & code coverage is not adversely affected (within reason)
[x] Works on all actively maintained versions of Python (e.g. Python 2.7 & the latest Python 3 release)
[x] Works on Windows 10, macOS, and Linux (e.g. considered file system case-sensitivity)

Thanks!

authors: brettcannon testvinder


text:
Request: Colourise text in Output Channel

I am looking at building an extension that prints a lot of information from errors, debug & warnings so it would be nice to stylise the messages from the realtime logs of a website to help with debugging.
So can I make a feature request please to enable colorised text in Output Channel

Duplicated maybe?
https://github.com/Microsoft/vscode/issues/571

Thanks, yes closing as a duplicate of #571

authors: Thaina egamma warrenbuckley

repo: Microsoft/vscode


text:
TFS: File not found when setup VS Code as diff tool

VSCode Version: 1.4.0
OS Version: Window 10 64 bits

Steps to Reproduce:

Setup VS Code as Diff tool in TFS (code -d -r %1 %2)
Show diff from TFS by click a file and sometime get this error below

If the file does not exist, it means it was not created by TFS in time.

Same setup with kdiff (kdiff %1 %2) and don't see problem

This only happen when i use option -r to open in same window (code -d -r %1 %2)

Likely https://github.com/Microsoft/vscode/issues/14534

authors: bpasero minhhut


text:
edit.delete will move the cursor to the beginning of the line

VSCode Version:
OS Version:

edit.delete will move the cursor to the beginning of the line. As we hijacked Backspace in Vim ext so currently in Insiders build, Backspace is not usable.
A simple extension to demonstrate this issue is as below
export function activate(context: vscode.ExtensionContext) {

    let disposable = vscode.commands.registerCommand('extension.sayHello', async () => {
        vscode.window.activeTextEditor.edit((edit)=> {
            let pos = vscode.window.activeTextEditor.selection.active;
            edit.delete(new vscode.Range(pos, new vscode.Position(pos.line, pos.character - 1)));
        });
    });

    context.subscriptions.push(disposable);
}

You can input abcdef and then run this command and you can see that cursor is put at the beginning of the line after it's executed.

Sorry about that, it is already fixed on master. (fixed with 474aab0a18968059691ddff3d5ad5bc022805418)

authors: alexandrudima rebornix


text:
Feature request - Keyboard binding for run tasks popup menu

I have made a bunch of tasks in my tasks.json file.
Current behavior-
cmd-shift-p find Run Tasks, click, click my task
Desired behavior -
I would like to replace the cmd-shift-b key-binding (or any key-binding of course) with jumping directly to the tasks pop up menu so I can pick one of many tasks.

You can add your own key-binding to the "Run Tasks" command so that the tasks pop up menu shows up.
The command for "Run Tasks" is "workbench.action.tasks.runTask".
For example, you can add the below in your key bindings json file

Perfect, thanks! I hadn't been able to find the runTask command. Is there a documentation page, or other way to discover command names?

I usually search in the Default Keyboard Shortcuts files. If you scroll down, you will find the whole list.

I have logged https://github.com/Microsoft/vscode-docs/issues/683 to see if we can get these in our docs

Thanks! TBH I didn't think to go to the bottom of the file.

Don't worry, I found it by accident actually. One day I was wondering, "woah, this is a big file, do we really have these many keybindings??" and then I scrolled :)

authors: meshula ramya-rao-a


text:
Align on save breaks up the < div> tags

VSCode Version: 1.8.1 (1.8.1)
OS Version: Sierra 10.12.1 OS X

Steps to Reproduce:

I type:

import React from 'react';
import ReactDOM from 'react-dom';

var HelloWorld = React.createClass({
    render: function() {
        return (
            <div>
            HelloWorld!
            </div>
        );
    }
});

When I save it
formats to this

No matter which align plugin i have from the two in the picture, it does that..

Let me know if you need more information.

@dnecklesportfolio that's no fun! Unfortunately I can't seem to reproduce with the steps you provided. In order to help narrow down the issue here, would you mind trying the following?

run VS Code using code --disable-extensions - does the issue still occur? (Also ensure you're running w/ this option for the next couple steps)
does it matter where the cursor position is when you save?
Do you have any custom formatting settings specified? (e.g. editor.tabsize, javascript.format.insertSpaceBeforeAndAfterBinaryOperators, etc.) And if so, could you post them here?

Hi @mousetraps,

No the issue doesnt happen anymore
It didnt matter i tried it before between and have the div tag
Here are those settings

// Place your settings in this file to overwrite the default settings
{
    "sync.gist": "",
    "sync.lastUpload": null,
    "sync.autoDownload": false,
    "sync.autoUpload": false,
    "sync.lastDownload": null,
    "sync.version": 242,
    "sync.showSummary": true,
    "sync.forceDownload": false,
    "sync.workspaceSync": false,
    "sync.anonymousGist": false,
    "vsicons.projectDetection.autoReload": true,
    "files.autoSave": "onFocusChange",
    "editor.tabSize": 2
}```
4. Yeah it didnt do the funky aligning anymore...

Should I remove all extensions and see which one caused it?

Thanks,

Awesome, we're getting somewhere! Yep, if it worked fine with extensions disabled, I'd recommend sifting through to see what the culprit is. Would be awesome if you could also update this thread with your findings in case anyone else runs into it, an also file a bug on the extension author so they know to fix it.

Also, you don't need to uninstall all extensions - you can actually try disabling extensions one at a time instead.

It was the JS-CSS-HTML-Formatter that did it, and they have been having similiar issues before

Last question
Which align plugin do you use?
Does it make sense to have more than one?
Any thank you for your time!

Sweet! Glad everything's working out!
As to your question - personally, I'm not the best person to ask because I don't actually use any of the align plugins because I'm happy enough with VS Code's built-in formatting options.
Definitely doesn't make sense to have more than one - seems like added complexity with no added value.
Anyways, that's my 2c - happy coding! 😃

authors: dnecklesportfolio mousetraps


text:
language specific editor.wordBasedSuggestions setting doesn't override the global setting

VSCode Version: 1.10.2
OS Version: Windows 10 1607 14393.693

Steps to Reproduce:

Create a new empty folder and open it in VSCode
In that folder - create a new xml file
Open workspace settings and set the following settings:
'''{
"editor.wordBasedSuggestions": true,
"[xml]": {
"editor.wordBasedSuggestions": false
}
}
'''
Open the XML file, type a few words and press Ctrl+Space

Actual result:
Word based suggestions show up
Expected result:
No suggestions showing up

@jrieken Looks like wordBasedSuggestions config is being read without lang id.

Please advise how @sandy081. There is nothing obvious on the service: const { wordBasedSuggestions } = this._configurationService.getConfiguration<IEditorOptions>('editor');

@jrieken Agreed, service api is not explicit. You can get language options as follows
this._configurationService.getConfiguration<IEditorOptions>({section: 'editor', overrideIdentifier: <langId>})

@jrieken Not sure why are we not getting editor settings from the editor instead of asking the service again?

Because this is done as service which isn't aware of an editor, just knowing models.

authors: StanislawStempin jrieken sandy081


text:
CTRL+K S keyboard shortcut does not save modified files.

VSCode Version: Code 1.11.2 (6eaebe3b9c70406d67c97779468c324a7a95db0e, 2017-04-13T08:03:11.395Z)
OS Version: Windows_NT ia32 10.0.15063
Extensions:

Extension
Author
Version

html-snippets
abusaidm
0.1.0

vscode-color
anseki
0.4.1

npm-intellisense
christian-kohler
1.3.0

path-intellisense
christian-kohler
1.2.0

vscode-svgviewer
cssho
1.4.0

vscode-eslint
dbaeumer
1.2.8

vscode-stylesheet-formatter
dbalage
0.2.0

jquerysnippets
donjayamanne
0.0.1

python
donjayamanne
0.6.3

vscode-babel-coloring
dzannotti
0.0.4

EditorConfig
EditorConfig
0.9.3

vscode-great-icons
emmanuelbeziat
1.1.52

react-native-react-redux
EQuimper
0.2.2

prettier-vscode
esbenp
0.15.1

code-runner
formulahendry
0.6.16

ftp-simple
humy2833
0.4.16

theme-avon
itsakt
2.0.1

Go
lukehoban
0.6.59

prettify-json
mohsen1
0.0.3

vscode-docker
PeterJausovec
0.0.13

code-settings-sync
Shan
2.6.2

comment-snippets
Tobiah
0.2.0

theme-boxythemekit
trongthanh
0.0.3

quokka-vscode
WallabyJs
1.0.28

bootstrap-3-snippets
wcwhitehead
0.0.9

JavaScriptSnippets
xabikos
1.4.0

ReactSnippets
xabikos
1.2.1

Steps to Reproduce:

Modify one or more editor files
Press CTRL+K S

@itsakt
Is this a problem with the keybinding or the action ?
If you run the action from the menu File > Save All , do the files get saved ?

Problem is with keybinding . File menu action works fine and keybinding is displayed next to menu item.

Perhaps one of the extensions you have installed decides to also register the Ctrl+K S keybinding under a context key that cannot be statically evaluated to hold true or false. To find this out, you can run code --disable-extensions and see if the keybinding works with all extensions disabled.
Which commands are bound to the desired key combination?

Oops... Should have checked before creating an issue. Sorry.  😐 It's Quokka.js.

authors: alexandrudima itsakt


text:
autoIndent doesn't handle indented wrapped TS lines well

if (a) {
	b = `foo` +
		`bar`;
}

Put cursor after } and press enter:

Ran into this while changing some terminal code, specifically:
		if (fgColor) {
			css += `.monaco-workbench .panel.integrated-terminal .xterm { color: ${fgColor}; }` +
				`.monaco-workbench .panel.integrated-terminal .xterm:not(.xterm-cursor-style-underline):not(.xterm-cursor-style-bar).focus .terminal-cursor,` +
				`.monaco-workbench .panel.integrated-terminal .xterm:not(.xterm-cursor-style-underline):not(.xterm-cursor-style-bar):focus .terminal-cursor { background-color: ${fgColor} }` +
				`.monaco-workbench .panel.integrated-terminal .xterm:not(.focus):not(:focus) .terminal-cursor { outline-color: ${fgColor}; }` +
				`.monaco-workbench .panel.integrated-terminal .xterm.xterm-cursor-style-bar .terminal-cursor::before,` +
				`.monaco-workbench .panel.integrated-terminal .xterm.xterm-cursor-style-underline .terminal-cursor::before { background-color: ${fgColor}; }` +
				`.monaco-workbench .panel.integrated-terminal .xterm.xterm-cursor-style-bar.focus.xterm-cursor-blink .terminal-cursor::before,` +
				`.monaco-workbench .panel.integrated-terminal .xterm.xterm-cursor-style-underline.focus.xterm-cursor-blink .terminal-cursor::before { background-color: ${fgColor}; }`;
		}

Root cause: don't have a clue whether the unexpected indentation of previous is intentional or not.
Atom/Sublime/TextMate don't have this issue as they only change indentation when type, if you press enter, it doesn't change the indentation as they think the indentation of current line is intentional so it no longer modify that.
@mjbvz do you think it's a good idea to disable indentation check on Enter?

I've use this pattern pretty frequently, either having 1 or 2 indents on wrapped lines. I'd likely opt to disable if it stayed as is. Here's another common thing I do:
if (someVeryLongConditionLine === true ||
    andAnotherOne) {
  doSomething();
}

It looks much nicer with 2 space indent 😄

The current behavior is a little better but still not ideal. Consider the following:

Move up:

Move down:

Move lines up and down around the intentional indentation can lead to this problem, however if you are just moving lines across your intentional changed area, it'll not affect your final content

I'd like to move this fr/bug to backlog at this moment.

authors: Tyriar rebornix


text:
no intellisense

VSCode Version: Code 1.15.1 (41abd21afdf7424c89319ee7cb0445cc6f376959, 2017-08-16T18:05:38.342Z)
OS Version: Windows_NT ia32 6.1.7601
Extensions:

Extension
Author (truncated)
Version

aessoft-class-autocomplete
AES
0.1.0

stylus
Ala
0.0.4

stylus
buz
0.1.0

npm-intellisense
chr
1.3.0

path-intellisense
chr
1.4.2

vscode-eslint
dba
1.2.11

vscode-npm-source
dku
1.0.0

vscode-npm-script
eg2
0.2.0

vscode-nupkg
eri
0.0.8

vscode-npm
fkn
3.3.0

flow-for-vscode
flo
0.7.1

vscode-firefox-debug
hbe
0.15.3

vue-snippets
hol
0.1.2

csharpextensions
jch
1.3.0

nuget-reverse-package-search
jes
0.1.68

vscode-nuget-package-manager
jmr
1.1.4

sublime-babel-vscode
jos
0.2.6

net-core-project-manager
ksu
0.3.6

csharpfixformat
Leo
0.0.32

tgit-cmds
mbi
1.1.1

vscode-less
mrm
0.6.3

csharp
ms-
1.12.1

debugger-for-chrome
msj
3.2.0

vetur
oct
0.9.5

csharp2ts
raf
0.0.17

vscode-flow
rto
276.3.0

aspnet-helper
sch
0.6.3

stylelint
shi
0.28.0

language-stylus
sys
1.7.3

Steps to Reproduce:

dotnet build
no csharp intelisense

Reproduces without extensions: Yes/No

Do you use an extension that promised C# IntelliSense?

yes c# ver 1.12.1

Ok, please file this issue against https://github.com/OmniSharp/omnisharp-vscode. Thanks


text:
Custom views titles are rendered twice

@joaomoreno FYI

Duplicate of #35035


text:
It's stoped when I use the cmd tools

VSCode Version:1.17.2
OS Version:windows 7 ,use phpstudy

Steps to Reproduce:
1.if use the PHP framework Laravel 5.5,and open the laravel-master project,when I try to use the vscode's cmd tools for create a model with the database table,use commond like this: " php artisan make:model Test -m ", vscode is stoped.
2.If I try to use Ctrl+Shift+~ to close the vscode's cmd window , and open the vscode again,to run this commond ,it will be create another one cmd named php,and it's also happened again.

Reproduces without extensions: Yes/No

So you type that command in the terminal? Then

vscode is stoped.

What do you mean by that exactly? Can you include a screenshot or gif of the problem?

authors: necodon roblourens


text:
Not receiving configurationDoneRequest when no breakpoints are set

VSCode Version: 0.10.12-alpha 3/22 build
OS Version: Windows 10 1511

Steps to Reproduce:

Install Powershell extension and restart
Open folder Examples under the Powershell extension install dir
Select the DebugTest.ps1 file
Press F5 to run, now try to pause the program.  Note that there is no output and pause doesn't work.
Now set a line breakpoint and press F5.  Now there is output and pause works.

Our log file shows that when a breakpoint is not set, we do not get the configurationDoneRequest message.  We are counting on getting that message whether there are breakpoints or not.  BTW this is a regression from the currently shipping version of VSCode.
The debug protocol docs state this:
/** ConfigurationDone request; value of command field is "configurationDone".
    The client of the debug protocol must send this request at the end of the sequence of configuration requests (which was started by the InitializedEvent)
*/

Am I misreading this?  I believe it implies the configurationDoneRequest message gets sent even if there are no "configuration requests" to send.  But I'm not sure.
RE https://github.com/PowerShell/PowerShellEditorServices/issues/196

Yes, configurationDone should always be sent. I will investigate

@rkeithhill I have looked into this and the issue is that the powershell adapter sends the 'initialized' event before vscode sent the 'initialize' call.
Here we specify that the adapter can send the 'initialized' event at any time. However that does not seem to be the right approach since it can happen that VSCode has not yet recieved the 'capabilites' call, and is not aware if debug adapter supports configurationDone request. That is happening in this case, the 'initialized' event comes before the capabilites and VSCode thinks powershell does not support configurationDone. If there are breakpoints due to timing all seems to work out fine, since the 'initialized' comes a bit later.
@weinand is investigating what is the right approach to tackle this issue

Thanks for the update. cc @daviwil

@isidorn I think we have this fixed.  The fix behaves correctly in the Insiders build but not the Alpha build.  Strangely, it appears the Insider build at 0.10.13 is a bit ahead of the Alpha build at 0.10.12.  So I'm hoping that the Insiders build has been "fixed" whereas the Alpha build hasn't.  If this remains the case, I would consider this bug fixed.  My only ask is that the debug protocol docs be updated to clarify this message ordering issue.

@isidorn your analysis makes sense but if I send the 'initializedEvent' after the 'InitializeRequest' has returned the Capabilities I see in Mock Debug that the 'LaunchRequest' arrives before the 'setBreakpointsRequest'. As a consequence no breakpoints are hit because the program has already terminated.
So here is the old sequence for Mock Debug:
initializeRequest
    send InitializedEvent
    return Capabilities
setBreakPointsRequest
launchRequest
configurationDoneRequest

This sequence looks already broken because the 'configurationDoneRequest' comes after the 'launchRequest'. But since 'setBreakPointsRequest' come before 'launchRequest', breakpoints are hit.
If I send the InitializedEvent after returning the Capabilities I see this sequence:
initializeRequest
   return Capabilities
   send InitializedEvent
launchRequest
setBreakPointsRequest
configurationDoneRequest

This sequence is even more broken: here the 'setBreakPointsRequest' comes after the 'launchRequest'.
I will fix the protocol doc and I will create a new issue for the ordering problem.

@weinand Hehe, that is why we have code in the PowerShell extension to capture "launch info" from the launchRequest message and not actually launch until we've received both messages (launchRequest and configurationDoneRequest) regardless of the order they come in.  That said, this is not an ideal situation.

@weinand is there something I could do on the vscode side right now, or should I wait for #4902 first

@isidorn Is there anything that you had planned to do here? My assumption is that fixing the doc is all that we can do here. Or is there a real bug on your side?

@weinand no, I do not think there is a bug on my side.
@rkeithhill alpha is ahead of insiders always, we just do not update the version number on alpha regulerly it seems. It sounds strange that your fix works for insiders, and not for alpha as there have been no big changes on alpha that would affect this.
We will release a new insider update tonight so maybe you can try it out then. If not then please let me know and I can investigate - if I can get you updated version of powershell with the fix.

@isidorn The two channels (latest builds 0.10.14-insider 2016-04-04 and 0.10.12-alpha 2016-04-05) still behave differently for me when I return the initialized event immediately after the initializeRequest response.
Everything appears to work except that if I pause the script and resume it, it finishes but then I get a popup Error cancelled window in VSCode.  I also note that we do not get the disconnect message from VSCode alpha (where I see this error).  Details on this are here https://github.com/Powershell/PowershellEditorServices/issues/196

I've created https://github.com/Microsoft/vscode/issues/4861 for the 'Error cancelled' message.

As far as I understand there is no real bug on the vscode side, @weinand just plans to update the docs.
Let me know if I am mistaken and I will reopen

Correct.  We are getting the configurationDone message when there are no breakpoints set.  I think this started working when I changed the order of the initialized event to be sent after the initialize request response.

@isidorn I've updated the doc already but there is still the ordering issue from above (please read my first comment): https://github.com/Microsoft/vscode/issues/4902

authors: isidorn rkeithhill weinand


text:
VS Code could warn if "Open Folder" is used but a workspace file exists

I receive more and more issues where the reproducible steps assume a multi-root setup with a single folder and a workspace file in this folder.
Since the reproducible steps typically don't explain how to open the project in VS Code I just open the folder. As a consequence I'm missing all workspace settings and launch.configs which makes it difficult to reproduce the issue at hand.
After some interaction with the issue's author we figure out that I was supposed to open the project via the workspace file.
Could we add some smartness to VS Code's "Open Folder" action that warns about this situation and offers me to open the workspace file instead?
/cc @isidorn

@weinand to be clear, you expect a warning to show up whenever a user opens a folder where there is 1-N workspace files top level in that folder?

I'm expecting a warning if a user opens a folder that contains a file "*.code-workspace"

This is a similar request to discussed here:
https://github.com/Microsoft/vscode/issues/45399#issuecomment-372091066
I would love this. If someone has gone to the effort of maintaining a code-workspace in a repository (which is somewhat required for some debugging scenarios) it'd be nice if others opening the folder got a prompt about it.
I suggested it could exist in the .vscode folder but the placement isn't critical.
(FWIW, I don't think it should be a warning - just an offer, like the recommended extensions @bpasero mentioned in the comment linked above).

@bpasero https://github.com/Microsoft/vscode/issues/45657#issuecomment-372934546 is the latest case where I ran into this problem.

I have renamed this, I think there are multiple cases where we could offer to open the workspace:

user accidentally opens a workspace file as file and not as workspace
user opens a folder with 1 workspace file inside
user opens a folder with N workspace files inside (then we should show a picker)

Sounds great to me :-)

I decided to not do anything for now when the workspace file is opened explicitly. But for the other cases:
Single Workspace File

Multiple Workspace Files:

Happy for feedback on the wording.

@DanTup yeah I forgot to mention: it only supports code-workspace files in the root currently. I was not aware that projects would also add workspace files in different places. Is that a pattern you have seen?

I haven't seen many projects use workspaces yet (maybe in part because of the lack of this) but I have seen projects that try to avoid IDE-specific files (esp. if the maintainers use many different IDEs). It'd be much easier to have this extra file accepted if it was in the folder with all the other vscode files (I'd also have a personal preference to put mine in there because the root is already a bit bloated with Travis, AppVeyor, tslint, tscobfig, several npm files, etc! :(

authors: DanTup bpasero weinand


text:
Build process injects unknown code into artifact

VSCode Version: current
OS Version: irrelevant

Steps to Reproduce:

run gulp vscode-[architecture]-min

Does this issue occur when all extensions are disabled?: Irrelevant?

Gulp will connect to marketplace.visualstudio.com during the build and download additional code not found in the git repo, and inject that code into the final artifact.
This makes it very unclear what code is actually powering VSCode, and also makes it impossible to build the software without an Internet connection.

https://github.com/Microsoft/vscode/blob/67cd9258fd0ed429ddc626d488d48bd65c2f2283/build/lib/extensions.ts#L54
https://github.com/Microsoft/vscode/blob/838f4024b30ffc477ea6fbc1eba8e21afc3aff2e/build/lib/builtInExtensions.js#L45
https://github.com/Microsoft/vscode/blob/838f4024b30ffc477ea6fbc1eba8e21afc3aff2e/build/lib/builtInExtensions.js#L59
https://github.com/Microsoft/vscode/blob/838f4024b30ffc477ea6fbc1eba8e21afc3aff2e/build/lib/builtInExtensions.js#L107
https://github.com/Microsoft/vscode/blob/838f4024b30ffc477ea6fbc1eba8e21afc3aff2e/build/lib/builtInExtensions.js#L85
https://github.com/Microsoft/vscode/blob/838f4024b30ffc477ea6fbc1eba8e21afc3aff2e/build/lib/builtInExtensions.js#L21
https://github.com/Microsoft/vscode/blob/838f4024b30ffc477ea6fbc1eba8e21afc3aff2e/build/builtInExtensions.json
The beauties of open source.
You can actually look at it.
You can see its downloading node debug extensions to prepackage.

We don't put every extension into our core code base right now, which requires a download step for extensions like node debug.

The beauty of open source.

This isn't open source, and that's the problem.
You're downloading unknown code from Microsoft's servers during the build step.
I did look at the files you mentioned, and they reference URLs that point to GitHub, but these URLs are ignored completely, and instead the mystery code is fetched from Microsoft's servers at the last minute.
You are welcome to treat your project and your users with this level of disrespect. It's your project and your call to do so, but I will not be using VSCode, and I'm seriously considering instituting a company-wide policy for all of our developers to avoid using it as well.

@taoeffect the person you're quoting does not work at Microsoft or on the VS Code team

@RyanCavanaugh Thanks, I edited my comment to make it clearer that I was replying to both @marekr and @rebornix.

Please don't interpret a closed issue as a sign of disrespect. The question was asked - why is VS Code downloading something - and answered. From a repo maintainer's perspective, there is no additional action and thus the correct state of the issue is closed. This doesn't mean "go away", it is just a metadata bit in a database that repo maintainers use to track the state of an issue.

Please don't interpret a closed issue as a sign of disrespect. The question was asked - why is VS Code downloading something - and answered.

I'm sorry, this wasn't meant to be an issue about me having a question.
Rather, it's an issue about VSCode doing something dangerous that it shouldn't be. Closing this issue would involve not doing said shady/dangerous thing, which, is apparently a pattern in Microsoft projects.
Please respect your developers and users and do not download unknown code during the build step. Just because there's a config file that claims it's "nodejs debugging stuff", doesn't mean that's what gets downloaded, and certainly doesn't mean this project is "open source" when it's obfuscating what source actually gets run.

This is fundamentally no different from running git submodule update.

Just because there's a config file that claims it's "nodejs debugging stuff", doesn't mean that's what gets downloaded

I don't understand the implication here. How would it download something else?

doesn't mean this project is "open source" when it's obfuscating what source actually gets run.

It's a multi-repo build system. VS Code is not intentionally obfuscating anything - it says right there what it's doing, and the builtInExtensions.json file lists the GitHub repos for the packages it downloads: https://github.com/Microsoft/vscode/blob/838f4024b30ffc477ea6fbc1eba8e21afc3aff2e/build/builtInExtensions.json

This is fundamentally no different from running git submodule update.

Let's see...

git submodule update is something the developer does before the build step
git submodule update represents a completely different trust model
git submodule update actually gives developers a chance to inspect the code that goes into the final product

Indeed, doing git submodule update instead of the nonsense it's currently doing would have been a great way to close this issue.

It's a multi-repo build system. VS Code is not intentionally obfuscating anything - it says right there what it's doing, and the builtInExtensions.json file lists the GitHub repos for the packages it downloads:

The GitHub repos that it completely ignores... yes.

@taoeffect Well incidentially....the .vsix it downloads is just a zip file....and inside are just js files ;)

@rebornix One of the issues brought up by @taoeffect is that the build process fails without an internet connection. I feel like this issue should be reopened and renamed to "build fails without internet connection". I understand that you don't wish to fix this issue at this time, but it should be in a later milestone instead of a 'wontfix'.

Today's "Want free VS Code? Build it from source" HN discussion: https://news.ycombinator.com/item?id=17346492

authors: RyanCavanaugh auchenberg eligrey marekr rebornix taoeffect


text:
installed on ubuntu but it doesn't run

VSCode Version:
OS Version:

Steps to Reproduce:

Does this issue occur when all extensions are disabled?: Yes/No

Can you try run code --verbose?
How did you install VS Code?

I have solved it. It's permission problem.
cd ～/config
Sudo rm - rf ./Code/


text:
Indentation should consider escape sequence for SQL language

Issue Type: Bug
If you see this command on vs_code, the code does not gets indented properly because of a ' character in the string which is escaped by .
SELECT 0                                  AS passed,
4195                                      AS pre_id,
f.id,
f.sig_id,
f.build_id,
f.tc_id,
f.batch_id,
spf.cycles,
spf.cpu_time,
spf.cps
FROM sims_fail___4195                     AS f JOIN sim_perf_fail___4195 AS spf
ON spf.id = f.sim_perf_id JOIN sigs___289 AS sigs
ON sigs.id = f.sig_id JOIN batches___289  AS b
ON b.id = f.batch_id
WHERE sigs.signature = 'C_ASSERTION:false\''     AND NOT ((b.name LIKE '%\\_\\_enablement%'))     AND b.state in (1,8,6,3)     AND b.owner = 'ainfra'     AND b.use_model in ('regr simulation')     AND f.start_timestamp BETWEEN '2018-07-12 00:00:00'     AND '2018-07-18 23:59:59' UNION  SELECT 0        AS passed,        4196                                      AS pre_id,        f.id                                      AS id,        f.sig_id                                  AS sigId,        f.build_id                                AS buildId,        f.tc_id                                   AS tcId,        f.batch_id                                AS batchId,        spf.cycles                                AS cycles,        spf.cpu_time                              AS cpuTime,        spf.cps                                   AS cps   FROM sims_fail___4196                     AS f JOIN sim_perf_fail___4196 AS spf      ON spf.id = f.sim_perf_id JOIN sigs___289 AS sigs      ON sigs.id = f.sig_id JOIN batches___289  AS b      ON b.id = f.batch_id   WHERE sigs.signature = 'C_ASSERTION:false''
AND NOT ((b.name LIKE '%\_\_enablement%'))
AND b.state in (1,8,6,3)
AND b.owner = 'ainfra'
AND b.use_model in ('regr simulation')
AND f.start_timestamp BETWEEN '2018-07-12 00:00:00'
AND '2018-07-18 23:59:59'
VS Code version: Code 1.27.2 (f46c4c469d6e6d8c46f268d1553c5dc4b475840f, 2018-09-12T16:17:45.060Z)
OS version: Windows_NT x64 10.0.17134
Extensions (7)

Extension
Author (truncated)
Version

sqlformatter
bre
0.0.7

xml
Dot
2.3.2

sftp
lix
1.5.13

mssql
ms-
1.4.0

cpptools
ms-
0.19.0

ruby
reb
0.20.0

partial-diff
ryu
1.4.0

please file the issue against the SQL extension.


text:
VSCode quits immediately after launching

VSCode Version: 1.27.2
OS Version: macOS 10.13.6 (17G65)

Steps to Reproduce:

Run VSCode
"Wait" for it to immediately quit

Does this issue occur when all extensions are disabled?: Yes
~ ❯❯❯ code --verbose
[main 11:37:02 AM] Sending env to running instance...
[main 11:37:02 AM] Sent env to running instance. Terminating...
[main 11:37:02 AM] Lifecycle#kill()
~ ❯❯❯ code --disable-extensions --verbose
[main 11:38:11 AM] Sending env to running instance...
[main 11:38:11 AM] Sent env to running instance. Terminating...
[main 11:38:11 AM] Lifecycle#kill()
~ ❯❯❯ code -v
1.27.2
f46c4c469d6e6d8c46f268d1553c5dc4b475840f
x64

Solution for #56765 worked.


text:
VS Code able & not able to format CSS

VS Code able & not able to format CSS

VSCode Version:  1.30.1
OS Version:  NA
Does this issue occur when all extensions are disabled?: YES IT DOES

STEPS TO REPRODUCE:
1.Format an HTML document with css inside style tags… WORKS NO PROBLEM.
2.Format a CSS document with the SAME css, and VS Code cannot format.

THE ISSUE(s)
• VS Code CAN format CSS when syntax is set to HTML.
• When syntax is on CSS it cannot.

VS Code can't format CSS out of the box. Consider installing one of the CSS formatter extensions: https://marketplace.visualstudio.com/search?term=css formatter&target=VSCode&category=All categories&sortBy=Relevance.

Thank you for helping get this sorted out!
Im attaching a gif that shows VS Code formatting CSS with its built-in formatter.  It will format CSS but only when that CSS is inside a

Yeah, that's the HTML formatter we bundled (JSBeautify)...It's working OK for some people, but it has some problems so we didn't continue making it the default formatter. You can install https://marketplace.visualstudio.com/items?itemName=HookyQR.beautify.


text:
Integrated terminal doesn't respect .nvmrc file

VSCode Version:
OS Version:

Steps to Reproduce:

Build any javascript project using with mac with NVM installed. Use node version other than one set with default alias.
When VSCode is started integrated terminal always starts the default version not respecting .nvmrc file in the project.

There is quite a bit of Stackoverflow discussion on this topic as well.
https://stackoverflow.com/questions/44700432/visual-studio-code-to-use-node-version-specified-by-nvm
https://stackoverflow.com/questions/54569606/vscode-nvm-complaining-about-a-prefix-option-when-the-integrated-terminal-is-lau
https://stackoverflow.com/questions/38671534/cannot-set-node-module-path-for-visual-studio-code
Expected behavior based on other editors I've used would be to automatically use whatever version is specified in the .nvmrc file.
I can fix the issues by running nvm use XXXX, but with next restart nvm version is incorrect again. To mitigate this is there a project level node part I can setup?

Does this issue occur when all extensions are disabled?: Yes/No

What OS and VS Code version are you on?

What OS and VS Code version are you on?

Hi, @Tyriar I'm using Hight Sierra 10.13.6 and VSCode 1.33.1.
This does happen extensions turned off as well, but I realized there I have one less of a standard piece of configuration in my side. My terminal of choice.
"terminal.external.osxExec": "Hyper.app",
I just also double check that I have nothing funny in my .bash_profile or .bashrc file which would seem unlikely as nvm works fine outside of VSCode.

I thought that this would mean error was due to Hyper.app terminal but changing my terminal settings in settings.json to
    "terminal.integrated.shell.osx":"/bin/bash",
    "terminal.explorerKind": "integrated",

Seem to make no difference.

@HintikkaKimmo if that extension fixes the problem that means you have a configuration issue as all it seems to do is run nvm use? You should looking into tweaking terminal.integrated.shellArgs.osx to either [] or [ "-l" ] and also looking into how nvm is setup in your .bashrc or .bash_profile files.

authors: HintikkaKimmo Tyriar


text:
Add an option to enable/disable JSDoc autocomplete

Hopefully addresses #23642
This PR introduces a new settings option for TypeScript extension:
"jsDocCompletion.enabled": {
  "type": "boolean",
  "default": true,
  "description": "%jsDocCompletion.enabled%"
}

which allows to enable or disable expanding /** using docCommentTemplate tsserver command. When set to false the default SnippetString is used.

@jsynowiec,
Thanks for your contribution.
To ensure that the project team has proper rights to use your work, please complete the Contribution License Agreement at https://cla.microsoft.com.
It will cover your contributions to all Microsoft-managed open source projects.
Thanks,
Microsoft Pull Request Bot

@jsynowiec, thanks for signing the contribution license agreement. We will now validate the agreement and then the pull request.
Thanks, Microsoft Pull Request Bot

Ok, I now see why it was done using an internal command. Reading docs and looking into other ways of restoring the previous behavior rather than immediately resolving the CompletionItem without showing the item preview. All ideas are welcome.

Hopefully all should be OK now.

@jsynowiec Thanks for the PR! We're currently finishing the upcoming release and will look into it some time next week.

Thanks @jsynowiec! This looks like a good change. It came in a little late for the upcoming March release but it should be in the April insiders builds once those resume and in the 1.12 release

authors: chrmarti jsynowiec mjbvz msftclas


text:
[Rust] use separate classes for function/type definition

I propose this change because it makes more sense in the class structure, and is needed for proper support for a theme I that use (https://github.com/tonsky/vscode-theme-alabaster/issues/7#issuecomment-338484649)

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: fwrs sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

@fwrs We actually pull in the rust grammar from this repo. Could you please try submitting this PR against that repo first. Once it is merged in upstream, we can then pull in the update for VS Code

Oh, okay

authors: fwrs mjbvz msftclas


text:
Fixes stuck hover widget when triggered manually, with "editor.hover": false

If the editor's preference editor.hover is set to false and the hover widget is triggered with CMD + K, CMD + I, it gets stuck in the page and does not go away with interactions such as mouse movement, mouse leave, editor scroll or editor model changes. This PR fixes this behaviour by hiding the tooltip when the above interactions happen.
Also, this PR adds support to react to changes on the preference editor.hover without having to reload the editor, effectively allowing the plugin suggested by @rebornix to work for the use case of #25715.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: LeonardoBraga sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

This PR was in conflict after the commit from @alexandrudima on June 22nd, but I've addressed the conflicts and its merging cleanly again.
@alexandrudima / @rebornix could you please review and let me know if there's any value in merging or any other feedback? Thanks!

:+1: Thank you!

authors: LeonardoBraga alexandrudima msftclas


text:
Porting the Support for Reference Parameters in CSM templates

Added the support for csm reference parameters.

Closing the PR as M97 deployment is already complete and hence no porting required for m96

repo: Microsoft/vso-agent-tasks

license: mit

license_source: bigquery


text:
[Test] EventLogDataCollectorShoudCreateLogFileHavingEvents is failing in PR builds

Description
https://ci.dot.net/job/Microsoft_vstest/job/master/job/Windows_NT_Debug_prtest/1451/consoleFull#15018181168943a369-e80c-4557-899a-c780301de2ed
Diagnostic logs

... .. . Total tests: 398. Passed: 381. Failed: 1. Skipped: 16.
06:17:33 ... .. . Failed tests:
06:17:33 ... .. . Failed tests:
06:17:33 ... .. .. . 1. Microsoft.TestPlatform.AcceptanceTests.EventLogCollectorTests.EventLogDataCollectorShoudCreateLogFileHavingEvents (RunnerFramework = net451, TargetFramework = net451, InIsolation)
06:17:33 ... .. .. .. .ErrorMessage:
06:17:33 Assert.IsFalse failed. StdErrorOutput - [Data collector 'Event Log' message: Data collector caught an exception of type 'System.IndexOutOfRangeException': 'Index was outside the bounds of the array.'. More details: The 'Application' event log has encountered an exception, some events might get lost. Error : System.IndexOutOfRangeException: Index was outside the bounds of the array. at System.Diagnostics.EventLogInternal.IntFrom(Byte[] buf, Int32 offset) at System.Diagnostics.EventLogInternal.GetCachedEntryPos(Int32 entryIndex) at System.Diagnostics.EventLogInternal.GetEntryWithOldest(Int32 index) at System.Diagnostics.EventLogInternal.GetEntryAtNoThrow(Int32 index) at System.Diagnostics.EventLogInternal.GetEntryAt(Int32 index) at Microsoft.TestPlatform.Extensions.EventLogCollector.EventLogContainer.OnEventLogEntryWritten(Object source, EntryWrittenEventArgs e)..Test Run Failed.] did not contain expected string 'event log has encountered an exception, some events might get lost'
06:17:33 ... .. .. .. .StackTrace:
06:17:33    at Microsoft.TestPlatform.TestUtilities.IntegrationTestBase.StdErrorDoesNotContains(String substring)
06:17:33    at Microsoft.TestPlatform.AcceptanceTests.EventLogCollectorTests.EventLogDataCollectorShoudCreateLogFileHavingEvents(RunnerInfo runnerInfo)
06:17:33
06:17:33 ... .. .. .. .StdOut:
06:17:33 IntegrationTestBase.Execute: Starting vstest.console.exe
06:17:33 IntegrationTestBase.Execute: Path = D:\j\workspace\Windows_NT_De---9fe03a42\artifacts\Debug\net451\win7-x64\vstest.console.exe
06:17:33 IntegrationTestBase.Execute: Arguments = "D:\j\workspace\Windows_NT_De---9fe03a42\test\TestAssets\EventLogUnitTestProject\bin\Debug\net451\EventLogUnitTestProject.dll" /testadapterpath:"D:\j\workspace\Windows_NT_De---9fe03a42\packages\MSTest.TestAdapter\1.2.0-beta\build_common" /settings:"C:\Users\dotnet-bot\AppData\Local\Temp\test_368248b3-0830-479f-80bc-69d34750c012.runsettings" /logger:"console;verbosity=normal" /ResultsDirectory:C:\Users\dotnet-bot\AppData\Local\Temp\9ca6d6c9-1f3f-464d-a043-06ced1a1bc43
06:17:33 IntegrationTestBase.Execute: Stopped vstest.console.exe. Exit code = 1
06:17:33 ... .. Test: Complete (net451).
06:17:33 ... Invoke-Test: Complete. {00:26:51.4319874}
06:17:33 ... Test complete. {00:26:51.7877891}
06:17:34

Fixed. Closing this issue.

repo: Microsoft/vstest


text:
Unable to publish vstest.console code coverage results to VSTS

This seems almost identical to closed issue https://github.com/Microsoft/vsts-tasks/issues/825.
I have a step to publish (xUnit via VSTest) test results that picks up the *.trx report correctly, but although the *.coverage report is generated and picked up as an attachment, it does not display any code coverage information in the build summary or on the "Code Coverage" tab.
As in the linked issue, I was also updating the build number in VSTS (although without colons), but I have completely removed that build number update in case it was related. No change in behavior.
I have tried using v1 and v2 of the "Publish Test Results" task and I have tried using the "Hosted" and "Hosted 2017" build agents.
From a recent build log:
2017-04-26T16:36:28.9703665Z ##[debug]Find-Files -SearchPattern d:\a\1\s\**\Test*\**\*.trx
2017-04-26T16:36:28.9913666Z ##[debug]FindFiles.FindMatchingFiles(rootFolder = , matchPattern = d:\a\1\s\**\Test*\**\*.trx, includeFiles = True, includeFolders = False
2017-04-26T16:36:29.0033651Z ##[debug]FindFiles.GetMatchingItems(includePatterns.Count = 1, excludePatterns.Count = 0, includeFiles = True, includeFolders = False
2017-04-26T16:36:29.3993659Z ##[debug]FindFiles.GetMatchingItems - Found: d:\a\1\s\.build\TestResults\xUnit\TestResults\buildguest_FACTORYVM-21 2017-04-26 16_36_11.trx
2017-04-26T16:36:30.2683650Z ##[debug]FindFiles.FindMatchingFiles - Found 1 matches
2017-04-26T16:36:30.2863658Z ##[debug]matchingTestResultsFiles = d:\a\1\s\.build\TestResults\xUnit\TestResults\buildguest_FACTORYVM-21 2017-04-26 16_36_11.trx
2017-04-26T16:36:30.2863658Z ##[debug]Calling Publish-TestResults
2017-04-26T16:36:30.3213662Z Publishing Test Results...
2017-04-26T16:36:30.3273664Z ##[debug]Get - SecretService and EndpointService from TaskContext
2017-04-26T16:36:30.3313655Z ##[debug]Fetched Endpoint:SystemVssConnection
2017-04-26T16:36:30.3343663Z ##[debug]AuthorizationType : OAuth
2017-04-26T16:36:31.0210730Z ##[debug]VssConnection created
2017-04-26T16:36:31.1440735Z ##[debug]Attachment location: d:\a\1\s\.build\TestResults\xUnit\TestResults\buildguest_FACTORYVM-21 2017-04-26 16_36_11\In
2017-04-26T16:36:31.1480976Z ##[debug]Setting run start and finish times.
2017-04-26T16:36:31.1510743Z ##[debug]Adding run level attachment: d:\a\1\s\.build\TestResults\xUnit\TestResults\buildguest_FACTORYVM-21 2017-04-26 16_36_11\In\FACTORYVM-21\buildguest_FACTORYVM-21 2017-04-26 16_32_37.coverage
2017-04-26T16:36:31.1610733Z ##[debug]Total test results: 67
2017-04-26T16:36:31.3291888Z Test results remaining: 67
2017-04-26T16:36:33.1449115Z Published Test Run : https://(redacted).visualstudio.com/(redacted)/_TestManagement/Runs#runId=693&_a=runCharts
2017-04-26T16:36:33.1459094Z ##[debug]Leaving script PublishTestResults.ps1
2017-04-26T16:36:33.1703419Z ##[section]Finishing: Publish Test Results **/Test*/**/*.trx```

Hi @fahnzmode,
Is your account url hsem.visualstudio.com? If yes can you provide your build number for the failed build? Please attach the complete logs too. Thanks

I attempted to send more detailed information to that email address, but I am unable:

The groups only accept messages from people in their organization or on their allowed senders list, and your email address isn't on the lists.

Hi, did this got resolved?

Please re-open this issue if it's not resolved. Happy to help you out.

authors: fahnzmode nigurr prawalagarwal

repo: Microsoft/vsts-tasks


text:
Integration Test - Release - 2019/05/20 21:08:27

Auto create for integration test. AnotherAuthorUpdatedArticleFlow

@PRMergerTest2 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

repo: MicrosoftDocs/CSIDev-Public


text:
Getting started with Office 365 CAS

[Enter feedback here]
Please provide a similar page for getting started with the O365 CAS license
Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 8d3a8799-0915-2446-b772-cf5e3c80a238
Version Independent ID: 31f10a22-3c95-5ebe-622d-7431c5cb76f1
Content: Deploy Cloud App Security
Content Source: CloudAppSecurityDocs/getting-started-with-cloud-app-security.md
Service: cloud-app-security
GitHub Login: @shsagir
Microsoft Alias: shsagir

@DeanGross Thanks so much for taking the time to leave us your comment on our documentation. We're researching your issue to update the page based on your suggestions. If relevant, changes will be made in the next possible publish.
We're closing this as an open issue for now, but feel free to continue to comment here as necessary. We appreciate your contribution to our community.

Please don't close this until the changes have been implemented

authors: DeanGross shsagir

repo: MicrosoftDocs/CloudAppSecurityDocs


text:
Update localization.md

Minor typo

This note has been removed/updated in a more recent update.

repo: MicrosoftDocs/Managed-Desktop


text:
[LOC] Invalid link in multiple articles

There is an invalid link in an article.
Repro steps:

Go to https://docs.microsoft.com/en-us/sharepoint/administration/connect-a-publishing-site-to-a-catalog
Search for "Create and manage terms in a term set"
Click on the link

Actual results:
Link redirects to a non existing page
Expected results:
Link should redirect to an existing page
GH article:
https://github.com/MicrosoftDocs/OfficeDocs-SharePoint/blob/live/SharePoint/SharePointServer/administration/connect-a-publishing-site-to-a-catalog.md
https://github.com/MicrosoftDocs/OfficeDocs-SharePoint/blob/live/SharePoint/SharePointServer/administration/configure-cross-site-publishing.md
https://github.com/MicrosoftDocs/OfficeDocs-SharePoint/blob/live/SharePoint/SharePointServer/administration/assign-a-category-page-and-a-catalog-item-page-to-a-term.md

@OfficeGlobal  Thank you for submitting feedback and contributing to the docs. We are currently investigating this.

@officedocsbot assign @scanum

@OfficeGlobal Thank you for your feedback. We have made changes to the article via PR https://github.com/MicrosoftDocs/OfficeDocs-SharePoint/pull/1045

Thank you for submitting feedback. We understand that this issue has been resolved.
Please feel free to re-open this issue if there is a specific area of the docs that we can improve or make better. Thank you.
@officedocsbot close

@officedocsbot close

authors: OfficeGlobal msbemba scanum

repo: MicrosoftDocs/OfficeDocs-SharePoint


text:
File scheme is missing

For us to plan the migration in advance and reducing the risk of losing files, we should be able to know how the tool will work and clarify few assumptions such as if migration will happen to user-by-user and Admin must decide on the destination considering the fact that user could have thousands of files and folders with complex sharing scheme.
Other than that, what if an Admin is attempting to initiate a process for company-wide migration to move completely from Google Workspace to Microsoft Business. We should be able to anticipate how migration will work, what if a user is the owner of a root folder but inside of it hundred of files owned by another user within the same organization or different organization.
All these cases should be mentioned or at least stated as included on excluded for us to know which documentation to read and follow

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 402bdf2a-1b81-fca5-42f3-ba9a140a6fb6
Version Independent ID: ed361570-2aa3-44a8-8b7a-74de71a6528a
Content: Review the destination paths for your Google migration with Migration Manager - Migrate to SharePoint and OneDrive
Content Source: migration/mm-google-step4-review-destinations.md
Service: sharepoint-online
GitHub Login: @JoanneHendrickson
Microsoft Alias: jhendr

Thank you for submitting feedback.
I think the best way forward is if you open a service ticket in your tenant so this can get resolved ASAP. Based on the outcome let me know if it is something that can be called out in the docs.
Please follow this link to contact support for business products:https://docs.microsoft.com/office365/admin/contact-support-for-business-products
Please keep us posted here on the resolution so we can feed whatever information you discover into the content.

authors: scanum yalattas


text:
Next steps for migration from RBS back to a normal Content database.

Firstly thank you  , I've been wanting this sort of documentation specific to SharePoint, and i'm so happy to see it.
I've read through all of the Manage RBS steps in this article.
You mention , its not recommended to uninstall RBS ,So how do i get my content database back to normal?
If you run these commands , the RBS tables are still in the content database and the filestream file is not removed from the database.
So my question is how best to migrate to a new content database ? Move-spsite ? Maybe you can link that as a concept for people to follow on.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 1b6ac330-c6a2-d444-1caa-97acda01118a
Version Independent ID: 9e3db03f-5da8-7766-3b64-f78e5b356e3f
Content: Disable RBS on content databases in SharePoint Server
Content Source: SharePoint/SharePointServer/administration/disable-rbs-on-a-content-database.md
Product: sharepoint-server-itpro
GitHub Login: @bentoncity
Microsoft Alias: stevhord

@scanum you can close this.


text:
Is it possible to limit access to read only CQD somehow?

Hi,
If we should enable user to read only CQD logs and not reading other audit logs as it says on the page:
In addition to reading CQD reports, the Reports Reader can view all the activity reports
So is this possible somehow?

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: cb8d8b48-561b-6817-1ce0-4b2aedc261a8
Version Independent ID: dfd5cf4a-509a-3ed1-0267-6281c251fbef
Content: Call Quality Dashboard (CQD) setup - Microsoft Teams
Content Source: Teams/turning-on-and-using-call-quality-dashboard.md
Service: msteams
GitHub Login: @CarolynRowe
Microsoft Alias: crowe

Hello @Petri-X
How are you?
Let me know if I understand correctly, do you mean a Reports Reader that has access to only CQD?

Yes I was wondering if there can be fine tuned the accesses. But I believe the correct roles are:
Teams Communications Support Engineer and
Teams Communications Support Specialist
Source: Teams roles and capabilities

authors: Petri-X get-itips


text:
Script code doesn't seem to work

The secion titled "Get the members of the specified group." doesn't seem to work, generates error:
Get-AzureADGroupMember : Cannot convert 'system.object ' to the type 'system.string' required by parameter 'ObjectID'. Specified method is not supported

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: fd13cd2b-3dca-1b7c-9970-c0f8c2348712
Version Independent ID: 318c6208-531a-3600-e45b-c43ea845db86
Content: Manage teams policies in Microsoft Teams - Microsoft Teams
Content Source: Teams/teams-policies.md
Service: msteams
GitHub Login: @LanaChin
Microsoft Alias: v-lanac

Have found the issue, the results from the Get-AzureADGroup cmdlet before was returning 3 matches rather than a single match.


text:
Update troubleshoot-wsus-import-sync-issues.md

Added the sws.1update.microsoft.com and changed description of fe2.update.microsoft.com to indicate it is decommissioned. Updated references to include sws1.update.microsoft.com

@lamosley : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@helenclu : Thanks for your contribution! The author(s) have been notified to review your proposed change.

repo: MicrosoftDocs/SupportArticles-docs


text:
Error "The request is not supported." when pulling any windows image

When trying to pull any windows images I get the following error:
PS C:\Users\joao> docker pull microsoft/nanoserver
Using default tag: latest
latest: Pulling from microsoft/nanoserver
bce2fbc256ea: Extracting [==================================================>] 252.7 MB/252.7 MB
58f68fa0ceda: Download complete
failed to register layer: re-exec error: exit status 1: output: ProcessBaseLayer C:\ProgramData\Docker\windowsfilter\916
540d7553abb618b21c525bffa76f982a34bd308282b0c7f79bc3cfd44b78e: The request is not supported.
This happens with other windows images as well.
I have docker for windows installed with the following version info:
PS C:\Users\joao.madureira> docker version
Client:
Version:      17.03.0-ce
API version:  1.26
Go version:   go1.7.5
Git commit:   60ccb22
Built:        Thu Feb 23 10:40:59 2017
OS/Arch:      windows/amd64
Server:
Version:      17.03.0-ce
API version:  1.26 (minimum version 1.24)
Go version:   go1.7.5
Git commit:   60ccb22
Built:        Thu Feb 23 10:40:59 2017
OS/Arch:      windows/amd64
Experimental: true
I'm running Windows 10 Pro.
What could be the problem?

Hi,
Sorry for the delayed response - we're busy ramping up for DockerCon and Build.
Is this still I problem?  If so I can try to reproduce it.
One common cause of issues is trying to run a Windows container when Docker is in Linux container mode.
If you're not sure, here's how to check:

Right click on the Docker whale icon
Look for an option that reads either "Switch to Windows containers" or "Switch to Linux containers".
If it reads "Switch to Windows containers", click that and try to pull the image again.  Otherwise it's something else.

Is this issue still open? It's nearly 2 years ago!

We hugely appreciate your contribution, feedback, and support to our technical documentation.
We’ve phased out GitHub Issues on this repository as the feedback mechanism for content and have replaced it with a new feedback system. For more information see, Content User Feedback. As part of this rollout, we are migrating your issue where our team will use your comments to improve the documentation experience. Unfortunately, this does mean you won't be able to access this issue after the migration is complete.
All issues will be migrated by Thursday 29th August 2024.
Once again, thank you for your valuable feedback, we hope you’ll continue to contribute using our new feedback system.

authors: doctordns joaomadureira mylesbkeating1993 robinharwood


text:
Cannot parse events from Advanced Hunting CSV

Using the query described here:
https://github.com/MicrosoftDocs/WDAC-Toolkit/blob/main/WDAC-Policy-Wizard/docs/using/advanced-hunting.md
when attempting to import the produced CSV from MS Security Center into the WDAC Wizard, we receive "The Wizard could not parse any Advanced Hunting events from the CSV file(s)."
The file matches the requirements as described in said article. There are many relevant events int he exported data: "AppControlCodeIntegrityPolicyAudited", "AppControlCodeIntegrityOriginBlocked", "AppControlCodeIntegrityPolicyBlocked" are some examples of the ActionTypes present.
looking in ...\AppData\Local\Temp\WDACWizard\Temp\2023*\log*.txt shows nothing except for "No Advanced Hunting Records Parsed", no information as to why. If I run the WDAC wizard on a target system (whose events are in this export) and tell it to parse the event logs on the local computer, it will produce file rules--so it's not as though there is no parsable data.

Sure @jgeurten here's an example of a query submitted to the wizard.
WDAC_query.csv

@jgeurten my bad...I have discovered that the CSV I submitted does not have the AuthenticodeHash field. However it was in my Advanced Hunting query--it looks like the field returned a blank value and was thus omitted from the export.
I had to select 'Customize Columns' in the Advanced Hunting interface after running the query again, and select the Authenticode Hash column to be displayed for it to be included in the exported CSV.
After doing so, the CSV is parsed successfully by the WDAC Wizard. Might I suggest that since this seems to be the default behavior of Advanced Hunting that if this field is not present, then have the Wizard ignore that and parse the file anyway. You can feel free to close this issue--but please note that either a revision to the documentation or the application is desired.

hmm that is super odd. I see what you're describing in AH. That's never been an issue before, and I have previous csvs where the Authenticode column is present, but all the data rows are empty. AH must have updated their logic to drop columns where all the data is empty.
I'll need to fix this as I anticipate others will hit this too in the future

Update your KQL query from "project" to "project-keep", otherwise it drops the Authenticode Hash column if the whole column has null values.

@lee-halford that works--thank you.

Thanks all. I will update the documented KQL query!

authors: jgeurten lee-halford ocadudeployment

repo: MicrosoftDocs/WDAC-Toolkit


text:
a

[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 111d7b49-94b6-abd9-c21a-fb0bace59114
Version Independent ID: 5d9aa212-cbb2-803c-2ea9-6da76c7a9394
Content: Microsoft Azure Well-Architected Framework - Microsoft Azure Well-Architected Framework introduction
Content Source: docs/framework/index.md
Service: architecture-center
Sub-service: well-architected
GitHub Login: @doodlemania2
Microsoft Alias: pnp

Thanks for reporting - this issue is under review. This is a Microsoft Internal DevOps Bug ID # 392407

@MutazNase Looks like you've created the issue before sharing all the details here. Could you please update your original post?

repo: MicrosoftDocs/architecture-center


text:
Job limit in stage

We found out (the hard way) that there is a limit of 256 jobs in a stage, or at least in a matrix in a stage. I can't seem to find any documentation about limit of stages, jobs or steps. I think you should document this

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: d322215c-8025-4f21-0700-7dfa7dc5c46e
Version Independent ID: 141fcdbb-8394-525b-bb29-eff9a693a9c4
Content: Stages in Azure Pipelines - Azure Pipelines
Content Source: docs/pipelines/process/stages.md
Product: devops
Technology: devops-cicd-process
GitHub Login: @juliakm
Microsoft Alias: jukullam

@PaulVrugt - Thanks for your question. While we're looking into this, it might be something to bring to the attention of the dev team. To make sure it gets in front of the right people, please submit your bug here.

Thanks @TimShererWithAquent
I've submitted the issue like you asked. See https://developercommunity.visualstudio.com/t/error-when-using-a-matrix-strategy-with-more-thant/1460633

@PaulVrugt Thanks for bringing this to our attention and submitting a bug. I'm adding a note to the article right now.

authors: PaulVrugt TimShererWithAquent juliakm

repo: MicrosoftDocs/azure-devops-docs


text:
Typo "Azure artifacts"→"Azure Artifacts"

https://docs.microsoft.com/en-us/azure/devops/pipelines/packages/nuget-restore?view=azure-devops
#PingMSFTDocs

@hyoshioka0128 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Looks good; merging. Thanks.


text:
Fixing capitalization in TOC

The capitalization of the README doc did not match the name of the file itself.

Looks good to me; thanks @vidia.

authors: ktoliver vidia


text:
Update variable-groups.md

Corrected error
Updated text for clarity

@yaweriqbal : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@ktoliver : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@ktoliver : Thanks for your contribution! The author(s) have been notified to review your proposed change.

The typo fixes look good; thanks!


text:
The Recommendation is not accurate

It's recommended that before installing the Az module, you uninstall AzureRM.
I don't think it is any longer a recommendation but a must.  See below for the resason:
PS C:\WINDOWS\system32> Connect-AzAccount
WARNING: Both Az and AzureRM modules were detected on this machine. Az and AzureRM modules cannot be imported in the
same session or used in the same script or runbook. If you are running PowerShell in an environment you control you
can use the 'Uninstall-AzureRm' cmdlet to remove all AzureRm modules from your machine. If you are running in Azure
Automation, take care that none of your runbooks import both Az and AzureRM modules. More information can be found
here: https://aka.ms/azps-migration-guide
Connect-AzAccount : Method 'get_SerializationSettings' in type
'Microsoft.Azure.Management.Internal.Resources.ResourceManagementClient' from assembly
'Microsoft.Azure.PowerShell.Clients.ResourceManager, Version=1.0.0.0, Culture=neutral,
PublicKeyToken=31bf3856ad364e35' does not have an implementation.
At line:1 char:1

Connect-AzAccount

Perhaps it would help readers if the warning is at the top of the page. To avoid erorr's like the above.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 313f5724-189f-9900-4c54-5a8c5b34a449
Version Independent ID: bd4fb194-d6af-e442-5ced-793e09c3fa83
Content: Install Azure PowerShell with PowerShellGet
Content Source: docs-conceptual/azps-1.1.0/install-az-ps.md
GitHub Login: @sptramer
Microsoft Alias: sttramer

@DMoonesinghe There was some miscommunication from the engineering team about this; the documentation is now clear that AzureRM must be uninstalled before installing Az, and there is documentation for how to have both installed on a system at once.

authors: DMoonesinghe sptramer

repo: MicrosoftDocs/azure-docs-powershell


text:
Docs.MS Release Updates for azure-template

Update docs metadata and targeting for release of azure-template

Docs Build status updates of commit bdd43ac:
:warning: Validation status: warnings

File
Status
Preview URL
Details

docs-ref-services/preview/template-readme.md
:warning:Warning
View (azure-node-preview)
Details

ci-configs/packages-preview.json
:white_check_mark:Succeeded

docs-ref-services/preview/template-readme.md

Line 9, Column 16: [Warning-ms-prod-technology-invalid] Invalid value for 'ms.technology': 'azure' is not valid with 'ms.prod' value 'azure'.
Line 2, Column 1: [Suggestion-description-missing] Missing required attribute: 'description'.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

repo: MicrosoftDocs/azure-docs-sdk-node


text:
Docs.MS Release Updates for azure-keyvault-secrets

Docs.MS Release Updates for azure-keyvault-secrets

Docs Build status updates of commit 19d6380:
:warning: Validation status: warnings

File
Status
Preview URL
Details

docs-ref-services/keyvault-secrets-readme.md
:warning:Warning
View (azure-node-latest) View (azure-node-preview) View (azure-node-legacy)
Details

docs-ref-autogen/overview/ManagedPartner.yml
:warning:Warning
View (azure-node-latest)
Details

docs-ref-services/keyvault-secrets-readme.md

Line 20: [Warning-hard-coded-locale] Link 'https://docs.microsoft.com/en-us/azure/key-vault/key-vault-overview' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
Line 20: [Warning-hard-coded-locale] Link 'https://docs.microsoft.com/en-us/azure/key-vault/key-vault-overview' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
Line 20: [Warning-hard-coded-locale] Link 'https://docs.microsoft.com/en-us/azure/key-vault/key-vault-overview' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
Line 38: [Warning-hard-coded-locale] Link 'https://azure.microsoft.com/en-us/services/key-vault/' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
Line 38: [Warning-hard-coded-locale] Link 'https://azure.microsoft.com/en-us/services/key-vault/' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
Line 38: [Warning-hard-coded-locale] Link 'https://azure.microsoft.com/en-us/services/key-vault/' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
Line 43: [Warning-hard-coded-locale] Link 'https://docs.microsoft.com/en-us/azure/key-vault/quick-create-portal' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
Line 43: [Warning-hard-coded-locale] Link 'https://docs.microsoft.com/en-us/azure/key-vault/quick-create-portal' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
Line 43: [Warning-hard-coded-locale] Link 'https://docs.microsoft.com/en-us/azure/key-vault/quick-create-portal' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
Line 122: [Warning-hard-coded-locale] Link 'https://docs.microsoft.com/en-us/azure/key-vault/key-vault-ovw-soft-delete' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
Line 122: [Warning-hard-coded-locale] Link 'https://docs.microsoft.com/en-us/azure/key-vault/key-vault-ovw-soft-delete' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
Line 122: [Warning-hard-coded-locale] Link 'https://docs.microsoft.com/en-us/azure/key-vault/key-vault-ovw-soft-delete' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
Line 333: [Warning-hard-coded-locale] Link 'https://docs.microsoft.com/en-us/azure/key-vault/key-vault-ovw-soft-delete' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
Line 333: [Warning-hard-coded-locale] Link 'https://docs.microsoft.com/en-us/azure/key-vault/key-vault-ovw-soft-delete' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
Line 333: [Warning-hard-coded-locale] Link 'https://docs.microsoft.com/en-us/azure/key-vault/key-vault-ovw-soft-delete' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
Line 537: [Warning-InvalidFileLink] Invalid file link:(~/docs-ref-services/samples/javascript).
Line 537: [Warning-InvalidFileLink] Invalid file link:(~/docs-ref-services/samples/javascript).
Line 537: [Warning-InvalidFileLink] Invalid file link:(~/docs-ref-services/samples/javascript).
Line 538: [Warning-InvalidFileLink] Invalid file link:(~/docs-ref-services/samples/typescript).
Line 538: [Warning-InvalidFileLink] Invalid file link:(~/docs-ref-services/samples/typescript).
Line 538: [Warning-InvalidFileLink] Invalid file link:(~/docs-ref-services/samples/typescript).
Line 539: [Warning-InvalidFileLink] Invalid file link:(~/docs-ref-services/test/).
Line 539: [Warning-InvalidFileLink] Invalid file link:(~/docs-ref-services/test/).
Line 539: [Warning-InvalidFileLink] Invalid file link:(~/docs-ref-services/test/).

docs-ref-autogen/overview/ManagedPartner.yml

[Warning-DuplicateUids] Uid(azure.nodejs.sdk.landingpage.services.managedapplications) has already been defined in docs-ref-autogen/overview/ManagedGroups.yml.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit 7e8e0d0:
:warning: Validation status: warnings

File
Status
Preview URL
Details

docs-ref-services/keyvault-secrets-readme.md
:warning:Warning
View (azure-node-latest) View (azure-node-preview) View (azure-node-legacy)
Details

docs-ref-autogen/overview/ManagedGroups.yml
:warning:Warning
View (azure-node-latest)
Details

docs-ref-services/keyvault-secrets-readme.md

Line 20: [Warning-hard-coded-locale] Link 'https://docs.microsoft.com/en-us/azure/key-vault/key-vault-overview' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
Line 20: [Warning-hard-coded-locale] Link 'https://docs.microsoft.com/en-us/azure/key-vault/key-vault-overview' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
Line 20: [Warning-hard-coded-locale] Link 'https://docs.microsoft.com/en-us/azure/key-vault/key-vault-overview' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
Line 38: [Warning-hard-coded-locale] Link 'https://azure.microsoft.com/en-us/services/key-vault/' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
Line 38: [Warning-hard-coded-locale] Link 'https://azure.microsoft.com/en-us/services/key-vault/' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
Line 38: [Warning-hard-coded-locale] Link 'https://azure.microsoft.com/en-us/services/key-vault/' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
Line 43: [Warning-hard-coded-locale] Link 'https://docs.microsoft.com/en-us/azure/key-vault/quick-create-portal' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
Line 43: [Warning-hard-coded-locale] Link 'https://docs.microsoft.com/en-us/azure/key-vault/quick-create-portal' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
Line 43: [Warning-hard-coded-locale] Link 'https://docs.microsoft.com/en-us/azure/key-vault/quick-create-portal' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
Line 122: [Warning-hard-coded-locale] Link 'https://docs.microsoft.com/en-us/azure/key-vault/key-vault-ovw-soft-delete' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
Line 122: [Warning-hard-coded-locale] Link 'https://docs.microsoft.com/en-us/azure/key-vault/key-vault-ovw-soft-delete' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
Line 122: [Warning-hard-coded-locale] Link 'https://docs.microsoft.com/en-us/azure/key-vault/key-vault-ovw-soft-delete' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
Line 333: [Warning-hard-coded-locale] Link 'https://docs.microsoft.com/en-us/azure/key-vault/key-vault-ovw-soft-delete' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
Line 333: [Warning-hard-coded-locale] Link 'https://docs.microsoft.com/en-us/azure/key-vault/key-vault-ovw-soft-delete' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
Line 333: [Warning-hard-coded-locale] Link 'https://docs.microsoft.com/en-us/azure/key-vault/key-vault-ovw-soft-delete' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.

docs-ref-autogen/overview/ManagedGroups.yml

[Warning-DuplicateUids] Uid(azure.nodejs.sdk.landingpage.services.managedapplications) has already been defined in docs-ref-autogen/overview/ManagedApplications.yml.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit f10b4a1:
:warning: Validation status: warnings

File
Status
Preview URL
Details

docs-ref-autogen/overview/ManagedApplications.yml
:warning:Warning
View (azure-node-latest)
Details

docs-ref-autogen/microsoft-cognitiveservices-speech-sdk/index.yml
:warning:Warning
View (azure-node-latest)
Details

docs-ref-services/keyvault-secrets-readme.md
:white_check_mark:Succeeded
View (azure-node-latest) View (azure-node-preview) View (azure-node-legacy)

docs-ref-autogen/overview/ManagedApplications.yml

[Warning-DuplicateUids] Uid(azure.nodejs.sdk.landingpage.services.managedapplications) has already been defined in docs-ref-autogen/overview/ManagedGroups.yml.

docs-ref-autogen/microsoft-cognitiveservices-speech-sdk/index.yml

[Warning-DuplicateUids] Uid(microsoft-cognitiveservices-speech-sdk) has already been defined in docs-ref-autogen/microsoft-cognitiveservices-speech-sdk/index.yml.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

@sadasant you can approve and merge this


text:
Where are the automatic backups stored?

It would be useful to know where the automatic backups are stored, as no information is given whatsoever.
Are these backups local? On zone-redundant storage? On geo-redundant storage?
If the datacenter holding my app service plan is destroyed, are the backups gone too?
Customers need to know this information.
Document details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 4754bcfc-204a-d398-6b86-e452cd0d44a1
Version Independent ID: 157885c4-2579-8f98-1e85-c3063a861207
Content: Back up an app - Azure App Service
Content Source: articles/app-service/manage-backup.md
Service: app-service
GitHub Login: @cephalin
Microsoft Alias: cephalin

@daninthemix
Thanks for your feedback! We will investigate and update as appropriate.

daninthemix, As highlighted in this discussion thread - "Automatic backups are simple and stored in the same datacenter as the App Service, and should not be relied upon as your disaster recovery plan."

daninthemix,  I'd been discussing on this internally and we have now created PR with two new FAQs in the doc. After the signoff, the doc will reflect the published changes.
Where are the automatic backups stored?
Automatic backups are simple and stored in the same datacenter as the App Service and should not be relied upon as your disaster recovery plan.
How do I stop the automatic backup?
You cannot stop automatic backup. The automatic backup is stored on the platform and has no effect on the underlying webapp instance or it’s storage.
Much appreciate your feedback!

repo: MicrosoftDocs/azure-docs


text:
Azure DF & SHIR: unable to connect to 3rd party MySQL DB with custom Cert

Azure documentation issue guidance
Thanks for opening an issue in the Azure technical documentation repository.
We use GitHub issues as the primary channel for customer and community feedback about the Azure documentation.
Creating an issue
We prefer that you create documentation feedback issues using the Feedback link on the published article - the feedback control on the doc page creates an issue that contains all the article details so you can focus on the feedback part.
You can also create a feedback issue here in the repo. If you do this, please make sure your issue lists:

[ ] The relevant Azure service or technology.
[ ] A link to the published documentation article that you have feedback about.
[ ] Clear, specific feedback that the author can act on.

Pull requests and article contributions
If you know the change that is needed in an article, we encourage you to submit the changes directly using a pull request. If the change is large, or if you want to contribute an entire article, follow these guidelines:

[ ] Don't surprise us with a big pull request or a pull request with a new article! Submit an issue that describes the details of the proposed large change or new article.
[ ] Include the service or technology area.

We'll route the issue to the appropriate content team for review and discussion.
Tech support and product feedback
If you would like to contact Microsoft about other things, such as product feedback or tech support, please review these guidelines:

If you need technical support using Azure, the paid and free support options are described here: https://azure.microsoft.com/support/options/.

Each article in the Azure technical documentation contains a product feedback button - it's best to submit product feedback directly from a relevant article. Otherwise, you can submit product feedback for most Azure products in the following product feedback forum: https://feedback.azure.com/d365community/forum/79b1327d-d925-ec11-b6e6-000d3a4f06a4.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: a94c02b8-cb8f-37ad-85dc-7d75fd0cf801
Version Independent ID: 1afd9a4d-9030-282a-678e-159e0f98495c
Content: Copy data from and to ODBC data stores - Azure Data Factory & Azure Synapse
Content Source: articles/data-factory/connector-odbc.md
Service: data-factory
Sub-service: data-movement
GitHub Login: @jianleishen
Microsoft Alias: jianleishen

https://learn.microsoft.com/en-us/azure/data-factory/connector-odbc?tabs=data-factory
https://learn.microsoft.com/en-us/azure/data-factory/connector-mysql?tabs=data-factory
I have experimented with many approaches to connecting to a 3rd party MySQL database. The 3rd party has shared  3 SSL certificates & documentation in these links dont show where the certificates need to be included.

@springcherr
Thanks for your feedback! We will investigate and update as appropriate.

Hi @springcherr
As discussed with internal team about the option in ADF linked service for addition of SSL keys and certificates, it is stated that
"Because of ADF security, we want custom certificates to be installed by User and take responsibility for it in shared responsibility model."
It is hence recommended putting right certificates on SHIR then connecting to 3rd party MySQL as stated in above comment.
If it is an urgent matter, and you need to know how to install certificates locally and connect to MySQL, I request you to open a support ticket.
Here is how you can do that: how-to-create-azure-support-request
If there are any further questions regarding the documentation, please tag me in your reply and we will be happy to continue the conversation.

@springcherr
We are going to close this thread as resolved but if there are any further questions regarding the documentation, please tag me in your reply and we will be happy to continue the conversation.

authors: Naveenommi-MSFT springcherr