text:
After upgrading to (preview) NixOS 18.03, nix-repl fails

Issue description
I upgrade to the current preview version of NixOS 18.03 and  nix-repl stopped working with the error:

error: Nix database directory ‘/nix/var/nix/db’ is not writable: Permission denied

I've found a related issue #5713 about Zsh, so i tried:
export NIX_REMOTE=daemon

and indeed this fixed nix-repl.
I verified that the variable NIX_REMOTE is not defined in my user environment if i boot into 18.03pre, but it is defined if i boot into 17.09. (Currently i know nothing about what it does and how.)
I am using Bash.
Steps to reproduce
In Bash:
nix-repl
echo $NIX_REMOTE
export NIX_REMOTE=daemon
nix-repl

Technical details
§ nix-shell -p nix-info --run "nix-info -m"
 - system: `"x86_64-linux"`
 - host os: `Linux 4.14.29, NixOS, 18.03pre131587.b6ddb9913f2 (Impala)`
 - multi-user?: `yes`
 - sandbox: `no`
 - version: `nix-env (Nix) 2.0`
 - channels(alexey): `"nixos-17.03-17.03.1949.78e9665b48f, nixos-17.09-17.09.3205.12512f25e9e"`
 - channels(root): `"nixos-18.03pre131587.b6ddb9913f2"`
 - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos/nixpkgs`

This is expected and is due to upgrading Nix to 2.0 -- the NIX_REMOTE variable is no longer needed.
Nix also now has a repl builtin-- you can access it with nix repl.
Since nix-repl was merged into Nix proper, I'm not sure there's reason to worry about the old nix-repl?

Thanks for the explanation.  Indeed, nix repl works for me.  So, are you saying that nix-repl is not expected to work anymore?  If so, this can be closed.

This confused me too. Currently nix-repl has an explicit dependency on Nix 1:
 nix-repl = callPackage ../tools/package-management/nix-repl { nix = nix1; };
so it is unlikely to work after upgrading to Nix 2.
We should consider dropping the nix-repl package altogether.

@dtzWill Is the documentation out of date here? It still says here that in a multi-user install we're supposed to set that variable.

nix pills no longer include nix-repl examples afaik.

authors: Mic92 alexeymuranov dtzWill masaeedu xeji


text:
mesa: reduce rebuild impact [plan]

Currently the rebuild impact is only due to libGL stubs pulling headers from the mesa build (I think), but upgrading the headers shouldn't be needed on every driver minor bump, as the API should be portable even to other libGL implementations, etc.
Plan: use headers from a fixed version, so that mesa(_drivers) can be changed much easier.

It might actually reduce the rebuild impact of a few other packages, too, as glvnd has much smaller closure than mesa.

I think we could avoid this sort of mass rebuild by removing the self references in mesa_noglu.stubs.  It wouldn't help with version upgrades (unless we pin it, which I'm not sure is a good idea).  Maybe we should source the headers from khronos repositories?

Well, yes, I meant whatever way to get suitable headers.  I have a feeling the khronos headers had been considered by us once, but I don't remember what's happened to that idea.

Done in #118479, currently in staging.

source: gharchive/issue

authors: corngood vcunat

repo: NixOS/nixpkgs

license: MIT

license_type: permissive

license_source: github-api


text:
fetchgit, fetchFromGitHub: postFetch in inconsistent

Issue description

fetchgit: postFetch hook is called after git fetch, with checked out files in $out

fetchFromGitHub: postFetch hook is called after tar.gz file is downloaded to $downloadedFile but before it is unpacked. So at postFetch time no checked out files are available.

This difference makes tricky replacing of fetchgit with fetchFromGitHub and vice-versa.
For example:

fetchFromGitHub { fetchSubmodules = true; } is effectively fetchgit and in this case postFetch is called when checked out files in $out, but
fetchFromGitHub { fetchSubmodules = false; } is effectively fetchzip and postFetch is called after the archive tarball is downloaded but before unpacked.

fetchgit's postFetch might need to be renamed in order not to be confused with fetchzip hook with the same name as they both become available in fetchFromGitHub.

I think I ran into this earlier today. Ended up just using fetchgit because even with fetchSubmodules = true it wouldn't work for me.

Perhaps a relevant change can be found in #57739 :
aed052818925d0a34befcf86355b07eb0b3d9d99  ('fetchFrom*: standardize postFetch')

Perhaps a relevant change can be found in #57739 :
aed0528 ('fetchFrom*: standardize postFetch')

Yes, that's relevant.
Although instead of adding four hooks with subtle differences
https://github.com/NixOS/nixpkgs/blob/aed052818925d0a34befcf86355b07eb0b3d9d99/pkgs/build-support/fetchgithub/default.nix#L6
I was thinking about:

deprecate and forbid (by removal from the argument list)  postFetch in fetch*git*-functions. Because postFetch leaks into internal_fetchzip (if there is internal_fetchzip) and this reliance on postFetch leaked to internal_fetchzip is abused at the call sites (by me as well: #61405), so the removal of postFetch would force to rewrite the call-site code.

add postGitFetch (the only post-hook for fetch*git*-functions) instead which must always work like it is called after git fetch. If there is internal_fetchzip, postGitFetch must be called after unpacking.

@volth

2. add postGitFetch (the only post-hook for fetch*git*-functions) instead which must always work like it is called after git fetch. If there is internal_fetchzip, postGitFetch must be called after unpacking.

What about keeping the postFetch name, but making it act like your postGitFetch? Or would that cause deprecation problems for external Nixpkgs consumers?

@volth

add postGitFetch (the only post-hook for fetch*git*-functions) instead which must always work like it is called after git fetch. If there is internal_fetchzip, postGitFetch must be called after unpacking.

What about keeping the postFetch name, but making it act like your postGitFetch?

It is the current state

Still confusing.

I believe this still requires action.

authors: bb010g conferno toonn veprbl volth


text:
ghcjs-base and ghcjs-prim versions seem inconsistent

I'm seeing this error when comparing two JSString values using GHCJS
Could not deduce (Eq JSString) arising from a use of ‘==’

I'm not sure exactly what is going on, but it seems like maybe this commit https://github.com/ghcjs/ghcjs-prim/commit/1d622ffecace0f56a73b7d32b71865d83fa2d496 is in play and this commit https://github.com/ghcjs/ghcjs-base/commit/bcd6988b07d99e7984de92857e87593e882642d3 isn't.
But from what I can tell ghcjs-prim is using the 7.10 branch, which doesn't have the commit removing the Eq instance. So, I'm a bit stumped.
@ryantrinkle @cstrahan any ideas?

@purefn I've opened a PR upstream here: https://github.com/ghcjs/ghcjs-prim/pull/5

Due to === being not reflexive (e.g. NaN === null), he's not going to keep the Eq instance. He did, however, accept a patch to introduce the missing eqRef definition.

Thanks.

authors: cstrahan purefn


text:
Vulnerability roundup 81: bind-9.14.9: 1 advisory

search, files

[x] CVE-2019-6470 CVSSv3=7.5 (nixos-19.09)

Scanned versions: nixos-19.09: eb65d1dae62. May contain false positives.

Affects: Builds of dhcpd versions prior to version 4.4.1 when using BIND versions 9.11.2 or later

We have dhcp-4.4.1 in 19.09, so we shouldn't be affected.

authors: ckauhaus vcunat


text:
Document experimental bcachefs usage

how to use it?
see for reference:
https://github.com/davidak/nixos-config/tree/master/machines/install-iso-bcachefs

still needed

I feel we do need some documentation about this, at least until it's mainlined.
It's not exactly hard to generate an iso with boot.supportedFilesystems = [ "bcachefs" ];, but that at least needs to be documented.

authors: Madouura davidak


text:
Vulnerability roundup 84: libspiro-0.5.20150702: 1 advisory

search, files

[ ] CVE-2019-19847 CVSSv3=8.1 (nixos-20.03)

Scanned versions: nixos-20.03: 82b5f87fcc7. May contain false positives.

See also: #77262

20.03 is frozen and EOL.
Closing.

authors: ckauhaus redvers


text:
oberon-risc-emu: init at 2020-08-18

Motivation for this change
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[x] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

@GrahamcOfBorg eval

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.
Result of nixpkgs-review pr 100042 run on x86_64-linux 1

1 package built:

oberon-risc-emu

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.
Result of nixpkgs-review pr 100042 run on x86_64-linux 1

1 package built:

oberon-risc-emu

source: gharchive/pull-request


text:
nixos/tests: follow-up to the closure reduction PR

Motivation for this change
This is a follow-up on #49403 where I made a big oversight regarding the QEMU executable that is being described within the NixOS module system. That package actually drives the VMs that are being started. I previously only changed the QEMU package that was used within the test driver script.
I've tried to detail the changes in the commits. Please let me know if there are any open questions and/or remarks.
While working on this I noticed that in 5500dc8 we introduced the --keep-vm-state flag and defaulted to that flag not being set. This lead to the runInMachine tests not longer
working and that going unnoticed for quite some time now.
cc @Ma27 @rnhmjoj #101473

Can you change nixos-build-vms to use the driverInterative? It should work, now.

@rnhmjoj that is actually already the case. Due to the changes that @Ma27 merges the nixos-build-vms output defaults to the fullfeatured QEMU even thought the driver Attribute is used.

so does / should this resolve the eval error currently present on unstable-small ?

@andir yes, but do you think that ``driverInteractiveis more explicit thatvirtualisation.qemu.package = pkgs.qemu;`? From this line alone it's not clear what's going on.

Can you linke me that error or quote it? Not sure what that error is.
On Sun, 25 Oct 2020, 08:07 xaverdh, notifications@github.com wrote:

so does / should this resolve the eval error currently present on
unstable-small ?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/NixOS/nixpkgs/pull/101598#issuecomment-716104104, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAE365D3PZGXLMFJTPJ2GZLSMPFCHANCNFSM4S52PVRQ
.

error: "error: --- ThrownError --- hydra-eval-jobs\nThe option virtualisation.qemu' does not exist. Definition values:\n- In /nix/store/zp8k91zbq2rpj5ky8r629zw2z85s3rw4-source/nixos/modules/testing/test-instrumentation.nix':\n    {\n      consoles = [ ];\n      package = {\n        _type = "override";\n        content = <derivation /nix/store/q72h2cdcb9zjgiay5gdgzwddjkbjr7xq-qemu-host-cpu-only-for-vm-tests-5.1.0.drv>;\n    ..."

(from https://hydra.nixos.org/jobset/nixos/unstable-small#tabs-errors)

Not sure if that is indeed what is preventing eval though. There is also the mysterious

error: [json.exception.type_error.302] type must be string, but is null

at the tail of that log..

I belive the fromer could be fixed (will verify) the latter is (hopefully) unrelated as master has been stuck for a while now.
Funnily enough my hydra instance was able to eval the release jobset of this PR just fine. I'll also let it build the small release set to see if that also succeeds.

@andir yes, but do you think that driverInteractive is more explicit that virtualisation.qemu.package = pkgs.qemu;? From this line alone it's not clear what's going on.

You might have a good point there. So would it be clearer if we switched the nixos-build-vms expression to driverInteractive and just remove the explicit override in the nix-build-vms module?

Oh yeah indeed. The small jobset is failing with the same eval error here:
hydra-eval-jobs returned exit code 1:
error: "error: --- ThrownError --- hydra-eval-jobs\nThe option `virtualisation.qemu' does not exist. Definition values:\n- In `/nix/store/c9mv62dd7r442yiigamw4q1xwx73pfi0-source/nixos/modules/testing/test-instrumentation.nix':\n    {\n      consoles = [ ];\n      package = {\n        _type = \"override\";\n        content = <derivation /nix/store/q72h2cdcb9zjgiay5gdgzwddjkbjr7xq-qemu-host-cpu-only-for-vm-tests-5.1.0.drv>;\n    ..."
error: [json.exception.type_error.302] type must be string, but is null

I managed to reproduce it locally with this command: nix-instantiate nixos/release-small.nix -A nixos.tests.boot.biosCdrom.x86_64-linux.
I'll have a look why this test is complaining while others are just fine.

I think it is due to https://github.com/NixOS/nixpkgs/pull/101246 actually..

I think it is due to #101246 actually..

Yeah, I just started fixing that. The problem is because the virtualisation.qemu options do not always exist and thus we must (continue) to check if they exist before we set them.

@xaverdh I opened a PR for that fix as it can go in on it's own: https://github.com/NixOS/nixpkgs/pull/101645

Once that lands I'll rebase this PR ontop of it and give it another spin.

authors: andir rnhmjoj xaverdh


text:
pythonPackages.tldextract: add missing dependency

Motivation for this change
Noticed this package was broken when upgrading my system, this adds a missing dependency making it build again.
Should be backported as well.
Things done

[X] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[X] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[X] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 106420 run on x86_64-linux 1

1 package failed to build:

lexicon

5 packages built:

python37Packages.tldextract
python38Packages.tldextract
python39Packages.tldextract
qutebrowser
sewer

Please add doCheck = false; and pythonImportsCheck.
sewer.log
176:Ran 0 tests in 0.000s

python37Packages.tldextract.log
146:Ran 0 tests in 0.000s

python39Packages.tldextract.log
146:Ran 0 tests in 0.000s

python38Packages.tldextract.log
146:Ran 0 tests in 0.000

Lexicon fails with:
builder for '/nix/store/j56giwlbqz09vmxgxxa2bjpv977rwh2n-lexicon-3.4.3.drv' failed with exit code 1; last 10 log lines:                                                                       Successfully built dns-lexicon                                                                                Finished creating a wheel...                                                                                Finished executing pipBuildPhase                                                                                installing                                                                                Executing pipInstallPhase                                                                                /build/source/dist /build/source                                                                                Processing ./dns_lexicon-3.4.3-py3-none-any.whl                                                                                Requirement already satisfied: future<1,>=0 in /nix/store/p2ha6p5zlsl571g2f3kn5mhnfganhihh-python3.8-future-0.18.2/lib/python3.8/site-packages (from dns-lexicon==3.4.3) (0.18.2)           ERROR: Could not find a version that satisfies the requirement tldextract<3,>=2 (from dns-lexicon)                                                                                ERROR: No matching distribution found for tldextract<3,>=2                                                                                cannot build derivation '/nix/store/538229lvxi89a32lq1dj947b1d4c6gdy-env.drv': 1 dependencies couldn't be built                                                                             error: --- Error ----------------------------------------------------------------------------------------------------------------------------------------------------------------------- nixbuild of '/nix/store/538229lvxi89a32lq1dj947b1d4c6gdy-env.drv' failed

Please add doCheck = false; and pythonImportsCheck.

Done 👍

Lexicon fails

Looks like this is an issue with the lexicon derivation itself, which i think can be fixed in a seperate PR.


text:
mediawiki: 1.35.0 -> 1.35.1

Motivation for this change
Main goal is to pull the security fixes for:

CVE-2020-35474
CVE-2020-35478
CVE-2020-35479
CVE-2020-35477
CVE-2020-35480

Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[ ] macOS
[x] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.
Result of nixpkgs-review pr 109584 run on x86_64-linux 1

1 package blacklisted:

tests.nixos-functions.nixos-test

1 package built:

mediawiki

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.
Result of nixpkgs-review pr 109584 run on x86_64-linux 1

1 package blacklisted:

tests.nixos-functions.nixos-test

1 package built:

mediawiki

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.
Result of nixpkgs-review pr 109584 run on x86_64-darwin 1

1 package built:

mediawiki

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.
Result of nixpkgs-review pr 109584 run on x86_64-darwin 1

1 package built:

mediawiki

Backporting all these CVEs might be some work.
@redvers wdyt, can we safely upgrade 1.34.4 -> 1.35.1 on stable?

Backporting all these CVEs might be some work.
@redvers wdyt, can we safely upgrade 1.34.4 -> 1.35.1 on stable?

I just went ahead and backported the update: https://github.com/NixOS/nixpkgs/pull/111550
I don't know if it contains any breaking changes.

authors: LeSuisse SuperSandro2000 dotlambda erictapen


text:
nixos/wakeonlan: add types

Motivation for this change
#76184
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

@SuperSandro2000


text:
ocamlPackages.kafka: 0.4 → 0.5

Motivation for this change
Fixes & improvements: https://github.com/didier-wenzek/ocaml-kafka/blob/0.5/CHANGES.md#05
Use Dune 2.
cc maintainer @rixed
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

I am no longer using nixos at the moment, so I am unable to review this change properly.
Would you please take over the "maintener" field ?

authors: rixed vbgl


text:
python3Packages.graphtage: init at 0.2.5

Motivation for this change
A utility to diff tree-like files such as JSON and XML
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[x] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 114546 at 4589100c run on aarch64-linux 1

6 packages built:

python37Packages.graphtage
python37Packages.json5
python38Packages.graphtage
python38Packages.json5
python39Packages.graphtage
python39Packages.json5

authors: r-rmcgibbo veehaitch


text:
pythonPackages.cairosvg: 2.5.1 -> 2.5.2; pythonPackages.celery: add missing requirement

Motivation for this change
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.
Result of nixpkgs-review pr 115307 run on x86_64-linux 1

2 packages marked as broken and skipped:

python38Packages.flower
python39Packages.flower

23 packages built:

mirage-im
python38Packages.cairosvg
python38Packages.celery
python38Packages.django-raster
python38Packages.djmail
python38Packages.pygal
python38Packages.weasyprint
xml2rfc (python38Packages.xml2rfc)
python39Packages.cairosvg
python39Packages.celery
python39Packages.django-raster
python39Packages.djmail
python39Packages.pygal
sourcehut.buildsrht
sourcehut.dispatchsrht
sourcehut.gitsrht
sourcehut.hgsrht
sourcehut.hubsrht
sourcehut.listssrht
sourcehut.mansrht
sourcehut.metasrht
sourcehut.pastesrht
sourcehut.todosrht

The following issues got detected with the above build packages.
Please fix at least the ones listed with your changed packages:

mirage-im:

warning: unclear-gpl
lgpl3 is a deprecated license, check if project uses lgpl3Plus or lgpl3Only and change meta.license accordingly.
Near pkgs/applications/networking/instant-messengers/mirage/default.nix:53:5:
   |
53 |     license = licenses.lgpl3;
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md


text:
python38Packages.lightgbm: 3.1.1 -> 3.2.0

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for python38Packages.lightgbm is: "A fast, distributed, high performance gradient boosting (GBDT, GBRT, GBM or MART) framework"
meta.homepage for python38Packages.lightgbm is: "https://github.com/Microsoft/LightGBM"
meta.changelog for python38Packages.lightgbm is: ""
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS

Warning: a test defined in passthru.tests did not pass

0 of 0 passed binary check by having a zero exit code.

0 of 0 passed binary check by having the new version present in output.

found 3.2.0 with grep in /nix/store/n28jy99pwzicv95qrby82wx4xfx7hkpj-python3.8-lightgbm-3.2.0

found 3.2.0 in filename of file in /nix/store/n28jy99pwzicv95qrby82wx4xfx7hkpj-python3.8-lightgbm-3.2.0

directory tree listing: https://gist.github.com/83fe9409c2640ae7cd48d8842662c25a

du listing: https://gist.github.com/deb204cbc194d8597b02856d0017f58f

Rebuild report (if merged into master) (click to expand)

16 total rebuild path(s)

4 package rebuild(s)

4 x86_64-linux rebuild(s)
4 i686-linux rebuild(s)
4 x86_64-darwin rebuild(s)
4 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
python38Packages.lightgbm
python38Packages.optuna
python39Packages.lightgbm
python39Packages.optuna

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/n28jy99pwzicv95qrby82wx4xfx7hkpj-python3.8-lightgbm-3.2.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A python38Packages.lightgbm https://github.com/r-ryantm/nixpkgs/archive/dea14fafdbe9560a1b468ade743703c07c61a185.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/n28jy99pwzicv95qrby82wx4xfx7hkpj-python3.8-lightgbm-3.2.0
ls -la /nix/store/n28jy99pwzicv95qrby82wx4xfx7hkpj-python3.8-lightgbm-3.2.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

2 packages marked as broken and skipped:

python38Packages.optuna
python39Packages.optuna

2 packages built:

python38Packages.lightgbm
python39Packages.lightgbm

Maintainer pings
cc @teh @costrouc for testing.

Result of nixpkgs-review pr 117689 at dea14faf run on aarch64-linux 1

2 packages marked as broken and skipped:

python38Packages.optuna
python39Packages.optuna

1 package skipped due to time constraints:

python39Packages.lightgbm

1 package built successfully:

python38Packages.lightgbm

1 suggestion:

warning: python-include-tests
Consider adding a checkPhase for tests, or if not feasible, pythonImportsCheck.
Near pkgs/development/python-modules/lightgbm/default.nix:57:0:
   |
57 |     description = "A fast, distributed, high performance gradient boosting (GBDT, GBRT, GBM or MART) framework";
   | ^

authors: r-rmcgibbo r-ryantm


text:
Terraform providers keycloak

Motivation for this change
Update terraform-providers.keycloak to latest release (3.0.0).
Use default model like most of providers to run the update-all-providers script.
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[x] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 119314 at 1c5c091f run on x86_64-linux 1

2 packages built successfully:

terraform-full
terraform-providers.keycloak

2 suggestions:

warning: license-missing
Package is missing a license.
Near pkgs/development/go-modules/generic/default.nix:236:5:
    |
236 |     meta = {
    |     ^

warning: unused-argument
Unused argument: runtimeShell.
Near pkgs/applications/networking/cluster/terraform-providers/default.nix:6:3:
  |
6 | , runtimeShell
  |   ^

authors: r-rmcgibbo yesteph


text:
solana: init at 1.5.19

This adds Solana, a performance-oriented blockchain. The source is the Solana monorepo, which includes the development tools and tools needed to interact with the network.
Version 1.5.19 is not the latest release at the time of writing, but it is the latest one intended for use with the mainnet.
Motivation for this change

Having the Solana devtools available in Nixpkgs makes it easy to manage development environments with Nix.
Solana users who also use Nix don’t need to download a binary / manually build from source any more.

Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[ ] macOS
[x] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Hi, has there been any progress on this recently?

superseded by later PRs.

authors: NickCao rollschild ruuda


text:
i3status-rust: 0.14.7 -> 0.20.0

Motivation for this change
https://github.com/greshake/i3status-rust/releases/tag/v0.20.0.
I will highlight the maildir feature that has now been made optional by default, which I have enabled for compatibility.
Things done

[X] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[X] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[X] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[X] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 122366 at 2bc02574 run on x86_64-linux 1

1 package built successfully:

i3status-rust

1 suggestion:

warning: unclear-gpl
gpl3 is a deprecated license, please check if project uses gpl3Plus or gpl3Only and change meta.license accordingly.
Near pkgs/applications/window-managers/i3/status-rust.nix:45:5:
   |
45 |     license = licenses.gpl3;
   |     ^

authors: ambroisie r-rmcgibbo


text:
verilator: symlink components needed for compilation to default places

To use verilator to compile a verilog file along with a
testing/simulating suite, verilator's output generated makefile
expects to find the #include <verilator-specific> headers in
$out/include, but by default they are placed in
$out/share/verilator/include. The same goes for the verilator_includer
perl script.
Figured this out with the aid of:
https://www.cl.cam.ac.uk/~jrrk2/docs/untether-v0.2/verilator/

Motivation for this change
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 125830 at d3095278 run on x86_64-linux 1

1 package built successfully:

verilator

1 suggestion:

warning: unclear-gpl
lgpl3 is a deprecated license, please check if project uses lgpl3Plus or lgpl3Only and change meta.license accordingly.
Near pkgs/applications/science/electronics/verilator/default.nix:39:5:
   |
39 |     license     = licenses.lgpl3;
   |     ^

This might be a recent change or breakage? If I'm reading you correctly, then Verilator should essentially be broken for all designs, but I've definitely compiled and run plenty of designs with Verilator from Nixpkgs in recent memory... Can you provide an exact example of what's failing?

The following sample works as intended, and is based on the official SystemVerilog example for Verilator. I don't see anything out of place here; logs from a successful build are as follows:
$ git -C /etc/nixos/nixpkgs rev-parse HEAD
8dbcb67680e5bda68d394c89321faa91eefb9227

$ git clone https://gist.github.com/thoughtpolice/1eb103f6b9f9f64fba9afe44c7716766 verilator-test && cd verilator-test
$ nix-shell -p verilator
[nix-shell:~/tmp/verilator-test]$ verilator --version
Verilator 4.110 2021-02-25 rev v4.108-79-g17b75c642

[nix-shell:~/tmp/verilator-test]$ make
...
[nix-shell:~/tmp/verilator-test]$ ./sim.exe
ok done
- top.v:13: Verilog $finish

Can you provide a minimal working test case that illustrates what problem you're having? Thanks!

Can you provide a minimal working test case that illustrates what problem you're having?

I cannot seem to do that now. I have tried compiling everything with the older version (4.101, which is what my current channel definitions have), 4.202, and this "patched" one, and they all see to work.
I don't know what was going on there.

authors: KarlJoad r-rmcgibbo thoughtpolice


text:
gup: 0.7.0 -> 0.8.0

Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[x] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 126059 at e3cf1c63 run on x86_64-linux 1

1 package built successfully:

gup

2 suggestions:

warning: missing-phase-hooks
installPhase should probably contain runHook preInstall and runHook postInstall.
Near pkgs/development/tools/build-managers/gup/default.nix:17:3:
   |
17 |   installPhase = ''
   |   ^

warning: missing-phase-hooks
buildPhase should probably contain runHook preBuild and runHook postBuild.
Near pkgs/development/tools/build-managers/gup/default.nix:16:3:
   |
16 |   buildPhase = "make python";
   |   ^

This version fixes an annoying bug on darwin, can changes to the update script be deferred for later @SuperSandro2000 ? They won't be trivial as I've never used nix-update before.

Also I just kicked the tyres, and it looks like there's at least two bugs, the bad version number detection and an unknown issue with nix-prefetch:
$ nix-update gup
( ... )
fetch https://github.com/timbertson/gup/releases.atom
Update 0.8.0 -> ersion-0.8.0 in /Users/tcuthbertson/Code/nix/nixpkgs/pkgs/development/tools/build-managers/gup/default.nix
$ nix-prefetch (import ./. (if (builtins.hasAttr "config" (builtins.functionArgs (import ./.))) then { config.checkMeta = false; } else { })).gup
error: Unsupported input type ''

..and nix-prefetch --help just says No manual entry for nix-prefetch
😞

I thought this smoke just work but if it doesn't we can fix this another time.

authors: SuperSandro2000 r-rmcgibbo timbertson


text:
ibus-engines.table-others: 1.3.11 -> 1.3.12

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/ibus-table-others/versions.
meta.description for ibus-engines.table-others is: "Various table-based input methods for IBus"
meta.homepage for ibus-engines.table-others is: "https://github.com/moebiuscurve/ibus-table-others"
meta.changelog for ibus-engines.table-others is: ""
Updates performed

Version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS

The tests defined in passthru.tests, if any, passed

0 of 0 passed binary check by having a zero exit code.

0 of 0 passed binary check by having the new version present in output.

found 1.3.12 with grep in /nix/store/m8z5vvkhzd2nd9y5qfsl8cmcc3zanmfz-ibus-table-others-1.3.12

found 1.3.12 in filename of file in /nix/store/m8z5vvkhzd2nd9y5qfsl8cmcc3zanmfz-ibus-table-others-1.3.12

directory tree listing: https://gist.github.com/86c08f456560b85861ead3bb0f649999

du listing: https://gist.github.com/00f7550eb7e63a7da0c502e174a578a3

Rebuild report (if merged into master) (click to expand)

3 total rebuild path(s)

1 package rebuild(s)

1 x86_64-linux rebuild(s)
1 i686-linux rebuild(s)
0 x86_64-darwin rebuild(s)
1 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
ibus-engines.table-others

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/m8z5vvkhzd2nd9y5qfsl8cmcc3zanmfz-ibus-table-others-1.3.12 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A ibus-engines.table-others https://github.com/r-ryantm/nixpkgs/archive/4cdb8dc132ad821c343d89eb9dd90f6ee74dd4f9.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/m8z5vvkhzd2nd9y5qfsl8cmcc3zanmfz-ibus-table-others-1.3.12
ls -la /nix/store/m8z5vvkhzd2nd9y5qfsl8cmcc3zanmfz-ibus-table-others-1.3.12/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

ibus-engines.table-others

Maintainer pings
cc @laMudri for testing.

Result of nixpkgs-review pr 130900 at 4cdb8dc1 run on x86_64-linux 1

1 package built successfully:

ibus-engines.table-others

1 suggestion:

warning: unclear-gpl
gpl3 is a deprecated license, please check if project uses gpl3Plus or gpl3Only and change meta.license accordingly.
Near pkgs/tools/inputmethods/ibus-engines/ibus-table-others/default.nix:27:5:
   |
27 |     license      = licenses.gpl3;
   |     ^


text:
nixos/postgresql: use postgres 13 for 21.11

Motivation for this change
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Relase notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

I have one minor comment, but it's not mandatory.
Looks good to me.

authors: happysalada yu-re-ka


text:
iosevka-bin: 10.0.0 -> 10.1.0

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for iosevka-bin is: "Slender monospace sans-serif and slab-serif typeface inspired by Pragmata\nPro, M+ and PF DIN Mono, designed to be the ideal font for programming.\n"
meta.homepage for iosevka-bin is: "https://be5invis.github.io/Iosevka"
meta.changelog for iosevka-bin is: ""
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS

The tests defined in passthru.tests, if any, passed

0 of 0 passed binary check by having a zero exit code.

0 of 0 passed binary check by having the new version present in output.

found 10.1.0 with grep in /nix/store/pzmlimrcbvidhf0wrxdcj0nzf8xn93fw-iosevka-bin-10.1.0

found 10.1.0 in filename of file in /nix/store/pzmlimrcbvidhf0wrxdcj0nzf8xn93fw-iosevka-bin-10.1.0

directory tree listing: https://gist.github.com/7733f4cce482aa12199c371bdf4b4b08

du listing: https://gist.github.com/504d9eb99afd7da14c32b8db40cf6f34

Rebuild report (if merged into master) (click to expand)

4 total rebuild path(s)

1 package rebuild(s)

1 x86_64-linux rebuild(s)
1 i686-linux rebuild(s)
1 x86_64-darwin rebuild(s)
1 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
iosevka-bin

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/pzmlimrcbvidhf0wrxdcj0nzf8xn93fw-iosevka-bin-10.1.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A iosevka-bin https://github.com/r-ryantm/nixpkgs/archive/48826482213c06937e400eadf89bcda6afea7eda.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/pzmlimrcbvidhf0wrxdcj0nzf8xn93fw-iosevka-bin-10.1.0
ls -la /nix/store/pzmlimrcbvidhf0wrxdcj0nzf8xn93fw-iosevka-bin-10.1.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

iosevka-bin

Maintainer pings
cc @cstrahan for testing.

thanks; please consider adding yourself as a maintainer.

authors: r-ryantm ryantm


text:
rocm: add update scripts

Motivation for this change
Tested OpenCL with an example and it still works.
To update everything with the update scripts:
for f in rocm-smi rocm-cmake rocm-thunk rocm-runtime rocm-opencl-runtime rocm-device-libs rocm-comgr rocclr rocminfo llvmPackages_rocm.llvm hip; nix-shell maintainers/scripts/update.nix --argstr commit true --argstr package $f; end

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Duplicate of #136445

Oh my, even hip is in there. Thanks for the heads up, I’ll rebase.

Why do we even need this? Can't nix-update handle all of this?

I didn’t know nix-update before. Seems like it needs a regex (like nix-update rocm-smi --version-regex 'rocm-(.*)'), it can’t update llvm and for some reason it also cannot update hip (Nix's builtins.parseDrvName could not parse the version from hip).
Using the update.nix script for all packages looks more convenient to me.


text:
libsidplayfp: disable tests on x86_64-darwin

Motivation for this change
As noted in https://github.com/NixOS/nixpkgs/pull/149644#pullrequestreview-827074081, one of the tests fails on x86_64-darwin but not on aarch64-darwin or any other platform. Reported upstream, disabling the tests on x86_64-darwin until this is fixed.
Tested sidplayfp (a reverse dependency of libsidplayfp) on x86_64-darwin and it seemed to work fine.
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 149929 run on x86_64-darwin 1

2 packages built:

libsidplayfp
sidplayfp


text:
yubikey-manager: replace myself as maintainer with other known users

Motivation for this change
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

could have used a squash with the merge :D


text:
python39Packages.google-cloud-datacatalog: 3.6.1 -> 3.6.2

Motivation for this change
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 155287 run on x86_64-linux 1

4 packages built:

python310Packages.google-cloud-bigquery
python310Packages.google-cloud-datacatalog
python39Packages.google-cloud-bigquery
python39Packages.google-cloud-datacatalog


text:
python310Packages.sanic: enable since GHSA-7p79-6x2v-5h88 is resolved

Description of changes
This commit reverts bf149c4, since GHSA-7p79-6x2v-5h88 only applies to sanic <20.12.6

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

But have you seen what 20.12.6 does to "fix" it? https://github.com/sanic-org/sanic/pull/2400

But have you seen what 20.12.6 does to "fix" it? sanic-org/sanic#2400

Oh, I never saw that :/
The reason I was looking into this was that spaCy depends on sanic, but nix fails to find sanic in 3.10. It looks like spaCy supports 3.10, so I'm wondering if this would still be worth it.

I guess it depends what it uses sanic for - probably worth a try though.

@risicle Looking at that patch more closely,

You should either use a supported version of Python (v3.6 - v3.9) or upgrade Sanic to v21+.

nixpkgs is on sanic version 21.12.1

@costrouc @AluisioASG

superseded by c95ab3cc25cbccdc29487ed9059fd38975356011

authors: ajs124 oati risicle


text:
[staging-next] archiveopteryx: fix build on aarch64 by conditioning -Wno-error flag

Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Apologies for the mass ping, messed up opening the merge request and started it pointing to the main branch instead of staging-next.

@ofborg build archiveopteryx

@ofborg eval

authors: fabianhjr mweinelt


text:
pythonPackages.datasette-leaflet: init at 0.2.2

Description of changes
Add the datasette-leaflet plugin, which is a dependency of several other datasette plugins.
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[x] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

@fabaff when I add checkInputs = [ pytestCheckHook pytest-asyncio sqlite-utils ];, it fails with no tests ran. I believe this is because the package on PyPI doesn't include the test files.
Would it be better to pull the package using fetchFromGithub so that the tests can be run?


text:
nixos/pam: Move pam_fprintd.so after pam_unix.so

This enables logging into GUI applications using a password even when
using fprintd. However, this now requires first entering an empty
password before being prompted for a fingerprint.
Fixes #171136
Description of changes

This moves the checking of the pam_fprintd module after the pam_unix module. This is required for GUI applications to still be authenticated with a password
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

Bump. The formatting issue has been addressed. Still needs a rebase though.

However, this now requires first entering an empty
password before being prompted for a fingerprint.

I think the current behavior also requires you to press enter, which is equivalent to entering an empty password anyway.

I think the current behavior also requires you to press enter

At least in GDM and GNOME Shell polkit agent, you just put your finger on the fingerprint reader after being prompted, and it authenticates you without any further action.

Ah, right, I forgot to mention that I'm using i3 & i3lock.

I am on vacations so I cannot touch this yet, I recommend to rebase and look for other reviewers on Discourse.

Needs a rebase

However, this now requires first entering an empty
password before being prompted for a fingerprint.

This is a downgrade IMO.
Maybe something like #171136 (comment) would work better.

I mean, no one made a config PR yet sadly...

I mean, no one made a config PR yet sadly...

That does not mean we should merge a broken PR instead.
And someone actually made a PR with what looked like a proper fix but there was still a bug and we lack people familiar with PAM to review it: https://github.com/NixOS/nixpkgs/pull/282322

I think the current behavior also requires you to press enter

At least in GDM and GNOME Shell polkit agent, you just put your finger on the fingerprint reader after being prompted, and it authenticates you without any further action.

This may be related to https://github.com/sddm/sddm/pull/1220#issuecomment-1829545241

would making an option in the fprint service to have password auth first be a better solution? it would be backwards compatible and still allow people to use the password first method without hacky workarounds

authors: AkechiShiro RaitoBezarius jtojnar kcoderhtml nyabinary rht skeleten


text:
libtiff: 4.3.0 -> 4.4.0

Description of changes
New upstream release: http://www.simplesystems.org/libtiff/v4.4.0.html
Removed all CVE patches, since they reference commits in the history of the v4.4.0 tag.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage

PENDING: libtiff.passthru.tests

[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Breaks freeimage-unstable-2021-11-01 build with:
Source/Metadata/XTIFF.cpp: In function 'BOOL tiff_write_exif_tags(TIFF*, TagLib::MDMODEL, FIBITMAP*)':
Source/Metadata/XTIFF.cpp:752:38: error: '_TIFFDataSize' was not declared in this scope; did you mean 'TIFFDataType'?
  752 |                         if((unsigned)_TIFFDataSize(tif_tag_type) != FreeImage_TagDataWidth(tag_type)) {
      |                                      ^~~~~~~~~~~~~
      |                                      TIFFDataType

freeimage is using a non-public libtiff API that was removed and replaced with a public API. This had already been reported on the freeimage forum and the libtiff mailing list. I'll try applying that patch.

A pillow test also fails (Tests/test_file_libtiff.py:302: AssertionError) . Looks like https://github.com/python-pillow/Pillow/pull/6339 may be needed to fix that.


text:
metasploit: 6.2.0 -> 6.2.1

Description of changes
Update to latest upstream release 6.2.1

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 176119 run on x86_64-linux 1

1 package built:

metasploit


text:
vscodium: 1.67.2 -> 1.68.0

Motivation for this change
Upgrades vscodium from 1.67.2 to 1.68.0
This PR was automatically generated by nixpkgs-upkeep.

CI workflow that created this PR.
Internal tag: d45743ceeff08b64ad1153a81dd8ca65.

Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[ ] macOS
[x] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Ah the test failure is related to https://github.com/NixOS/nixpkgs/pull/171280
@ofborg build nixosTests.allDrivers.vscodium

@ofborg test allDrivers.vscodium
@ofborg test vscodium.xorg
@ofborg test vscodium.wayland
@ofborg build vscodium


text:
sickgear: 0.25.31 -> 0.25.35

Description of changes

Basic version bump. Changelog
Tested working on NixOS 21.11
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Thanks @bobby285271


text:
python310Packages.nextcord: 2.0.0b3 -> 2.0.0rc2

Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

superseded by https://github.com/NixOS/nixpkgs/pull/179532


text:
srsran: 21.10 -> 22.04

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/srsran/srsran/releases.
meta.description for srsran is: "Open-source 4G and 5G software radio suite."
meta.homepage for srsran is: "https://www.srslte.com/"
meta.changelog for srsran is: ""
Updates performed

Version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 22_04 with grep in /nix/store/5qp1kmc1s1cir8gnfxqmqac0dx723v31-srsran-22_04
found 22_04 in filename of file in /nix/store/5qp1kmc1s1cir8gnfxqmqac0dx723v31-srsran-22_04

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
srsran

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/5qp1kmc1s1cir8gnfxqmqac0dx723v31-srsran-22_04 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A srsran https://github.com/r-ryantm/nixpkgs/archive/aa91b2228d746cd1ff2a0a8648e7c2d2ac55191a.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/5qp1kmc1s1cir8gnfxqmqac0dx723v31-srsran-22_04
ls -la /nix/store/5qp1kmc1s1cir8gnfxqmqac0dx723v31-srsran-22_04/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

srsran

Maintainer pings
cc @hexagonal-sun for testing.

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/srsran/srsran/releases.
meta.description for srsran is: "Open-source 4G and 5G software radio suite."
meta.homepage for srsran is: "https://www.srslte.com/"
meta.changelog for srsran is: ""
Updates performed

Version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 22_04_1 with grep in /nix/store/iz660ww12gdavx1nd4c8ffdbqp4rb162-srsran-22_04_1
found 22_04_1 in filename of file in /nix/store/iz660ww12gdavx1nd4c8ffdbqp4rb162-srsran-22_04_1

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
srsran

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/iz660ww12gdavx1nd4c8ffdbqp4rb162-srsran-22_04_1 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A srsran https://github.com/r-ryantm/nixpkgs/archive/a79856c4b9193848a9ef22fb60102ffd5c097146.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/iz660ww12gdavx1nd4c8ffdbqp4rb162-srsran-22_04_1
ls -la /nix/store/iz660ww12gdavx1nd4c8ffdbqp4rb162-srsran-22_04_1/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

srsran

Maintainer pings
cc @hexagonal-sun for testing.

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/srsran/versions.
meta.description for srsran is: "Open-source 4G and 5G software radio suite."
meta.homepage for srsran is: "https://www.srslte.com/"
meta.changelog for srsran is: ""
Updates performed

Version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 22.04 with grep in /nix/store/dym0h4rrbvywn4x5g8qflkv1hlby9986-srsran-22.04
found 22.04 in filename of file in /nix/store/dym0h4rrbvywn4x5g8qflkv1hlby9986-srsran-22.04

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
srsran

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/dym0h4rrbvywn4x5g8qflkv1hlby9986-srsran-22.04 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A srsran https://github.com/r-ryantm/nixpkgs/archive/78809e8840a5b9b1975e3fd1334d4c550ba0c314.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/dym0h4rrbvywn4x5g8qflkv1hlby9986-srsran-22.04
ls -la /nix/store/dym0h4rrbvywn4x5g8qflkv1hlby9986-srsran-22.04/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

srsran

Maintainer pings
cc @hexagonal-sun for testing.

Close in favor of https://github.com/NixOS/nixpkgs/pull/187487

authors: markuskowa r-ryantm


text:
swiProlog: 8.3.29 -> 8.5.17

Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[x] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 192974 run on aarch64-darwin 1

3 packages built:

ape
apeClex
swiProlog


text:
nuget-to-nix: fix warning when package is installed from sdk

Description of changes
Fixes #196676

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

This works perfectly!
Thanks for the absurdly fast fix!

authors: corngood vtrf


text:
python310Packages.pysolcast: 1.0.7 -> 1.0.11

Description of changes
https://github.com/mcaulifn/solcast/releases/tag/v1.0.11

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 199236 run on x86_64-linux 1

2 packages built:

python310Packages.pysolcast
python39Packages.pysolcast


text:
marksman: 2022-12-28 -> 2023-01-29

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for marksman is: Language Server for Markdown
meta.homepage for marksman is: https://github.com/artempyanykh/marksman
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 2023-01-29 with grep in /nix/store/zdk19275vv66b5kfhj0lwb8f6anrljnx-marksman-2023-01-29
found 2023-01-29 in filename of file in /nix/store/zdk19275vv66b5kfhj0lwb8f6anrljnx-marksman-2023-01-29

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
marksman

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/zdk19275vv66b5kfhj0lwb8f6anrljnx-marksman-2023-01-29 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A marksman https://github.com/r-ryantm/nixpkgs/archive/383016f034c05719bcc5c003c78f42b9ed8de8a6.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/zdk19275vv66b5kfhj0lwb8f6anrljnx-marksman-2023-01-29
ls -la /nix/store/zdk19275vv66b5kfhj0lwb8f6anrljnx-marksman-2023-01-29/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

marksman

Maintainer pings
cc @stasjok for testing.

Result of nixpkgs-review pr 213734 run on aarch64-darwin 1

1 package built:

marksman

Result of nixpkgs-review pr 213734 run on aarch64-darwin 1

1 package built:

marksman

authors: r-ryantm wegank


text:
neovim: 0.8.x to 0.9.0

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

is this a continuation of what https://github.com/NixOS/nixpkgs/pull/212235 was originally trying to do?

is this a continuation of what #212235 was originally trying to do?

Yes, in #212235 I previously assumed 0.8.3 would be released from master, I didn't notice those are released from the 0.8 branch. The change in this PR depends on the upstream inclusion of the patch which is on master but not on the 0.8 branch.

Do we know when 0.9.0 will be released?

I'm guessing no, I think for now this is mostly a reminder to remove the patch

dropping in favour of #225152

authors: Kranzes figsoda raboof


text:
python3Packages.notifications-android-tv: init at 1.0.0

Needed by the "nfandroidtv" integration of Home Assistant.
Description of changes

notifications-android-tv is a dependency needed by the "nfandroidtv" integration of Home Assistant.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
Not applicable
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
Not applicable
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

As this is Home Assistant dependency, don't forget to run:
./pkgs/servers/home-assistant/parse-requirements.py

and add that change as a separate commit to this PR.

As this is Home Assistant dependency, don't forget to run [...] and add that change as a separate commit to this PR.

I was planning on sending that as a separate PR, but I'll be happy to include it in this one

I believe I've addresses all the comments and this is ready for review.

Result of nixpkgs-review pr 217684 run on x86_64-linux 1

1 package failed to build:

home-assistant-component-tests.nfandroidtv

2 packages built:

python310Packages.notifications-android-tv
python311Packages.notifications-android-tv

Home Assistant is pinning notifications-android-tv==0.1.5. This means that the dependency needs an override.

What if 1.0.0 and 0.1.5 differ in most aspects of the build process? 0.1.5 needs setuptools instead of poetry, has different runtime dependencies, and no tests. It doesn't have much in common with the derivation for 1.0.0.
Should we only package 0.1.5, since the only user is home-assistant?

Added the override necessary for the home-assistant integration to work.

authors: dominikh fabaff mweinelt


text:
haskell.compiler: fix GHCs' user guide build with sphinx >= 6.0

This requires backporting upstream's fix to all GHCs we are currently shipping, since only GHC 9.4.5 and 9.6.1 will receive a backport.
GHC HEAD will be taken care of in #217168.
https://gitlab.haskell.org/ghc/ghc/-/merge_requests/9625 https://gitlab.haskell.org/ghc/ghc/-/issues/22690
This PR will go to python-updates since the sphinx update will happen there, causing a rebuild of all GHC versions. We can combine these rebuilds with the rebuilds the patches fixing the incompatibility will cause without inflicting an extra burden on haskell-updates.
We will, however, introduce an (easy) to solve merge conflict this way: We have also added a patch to GHC 9.4.4 in haskell-updates. The conflict should be easy to solve on staging, I'll keep an eye out.
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Looks good. So you plan to merge this exactly when the sphinx gets updated in python-packages?

Doesn't matter, it builds before and after the sphinx update.

Thanks!

authors: maralorn mweinelt sternenseemann


text:
forgejo: 1.19.2-0 -> 1.19.3-0

Description of changes
https://codeberg.org/forgejo/forgejo/releases/tag/v1.19.3-0
Excerpt from https://codeberg.org/forgejo/forgejo/src/commit/b96c825c6f7e9c0fcc2137acf06decdb03406b92/RELEASE-NOTES.md#1-19-3-0 (bold text is highlighted by me)

Forgejo was recompiled with Go version v1.20.4 published 2 May 2023. It fixes three vulnerabilities (CVE-2023-29400, CVE-2023-24540, CVE-2023-24539) related to the html/template package. The Forgejo security team analyzed the security fixes it contains and concluded that Forgejo is not affected but recommended a rebuild as a precaution.

Edit: @mweinelt messaged me that we don't even have go 1.20.4 yet :sweat_smile:
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Removing the security label for now.
Deployed it to my instance in the meantime.
I can confirm everything seems to work fine. I can also confirm the single and only bug fix listed in the changelog did in fact, fix the issue:

Allow user that are not signed in to browse the tag list. Requiring users to be signed in to view the tag list was a regression introduced in Forgejo v1.19.2-0.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/2170

authors: IndeedNotJames nixos-discourse


text:
nixos/manual/networkmanager: add info on nm-applet

There is currently no mention of nm-applet in the manual. I feel like the info added by that patch could be useful to XFCE users in particular (it would have been useful to me when I was just starting with NixOS).

Thanks!


text:
verible: 0.0.3253 -> 0.0.3410

Description of changes
Update to latest; a few improvements in the language server and some bugs fixed.

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

(waiting for the aarch64 build to run to see the expected fetchAttrs sha256)

Adding @NickCao who merged the last update


text:
haste-server: use buildNpmPackage

Description of changes
see #229475

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

please add a working updatescript

Doesn't nix-update support updating such packages out of the box?

please add a working updatescript

Why? This version of haste-server won't be updated anymore I think.

authors: doronbehar dotlambda


text:
haxe: introduce haxePackages

Motivation for this change
hxcpp (runtime for Haxe->C++ translator) is broken after upgrade .
This fix hxcpp and also allows to use more than one library directory (that in nix world means more than one library). Added some popular Haxe libs including hxjava and hxcs (runtimes for Haxe->Java and haxe->C# translators).
Cross-compilation in hxcpp is currently broken (including compilation of 32-bit apps on x86_64).
Things done

[ ] Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] Linux

[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

Some 3rd party libraries (for example flow and lime) either use parts of haxelib code or launch haxelib config and interpret its output as a single path.
Supporting multiple repositories on $HAXELIB_PATH requires making changes in those libraries as well.
It might be better not to add this support in order not to break code of unknown number of people, but instead wrap haxe and haxelib (the two binaries in haxe package) in a bash script which would check if $HAXELIB_PATH contains delimiters and if so, would create a temp directory populated with symlinks to the libraries.

@Mic92, @andyli: I managed to add support of multiple repos on HAXELIB_PATH without upstream patch, by creating a temporary repository with symlinks.
You might be worry about the temporary repository never deleted, but the main use case (probably the only use case, I do not have another one at the moment) of multiple repos on HAXELIB_PATH is building Nix derivations, where tmp directory is deleted after the build.

Also you seem to have the use case. I think a number of people would like to use nix-shell as development environment, where the temporary directory would be not cleaned up.

Also you seem not to have the use case. But I think a number of people would like to use nix-shell as development environment or just install haxe as a package, where the temporary directory would be not cleaned up.

Development environment in Haxe is a bit tricky and I am afraid not well compatible with nix-shell: in the repo created a file named .dev which contains path to working directory which should substitute the library in the repo. And some libraries are self-aware that they are being "under development".
But you are right, we need more use cases. We even have no single app written in Haxe in nixpkgs, it might have sense to add a small game just to have another use case.

Should I split it to smaller PRs ?
There are basically:

support for multiple libraries in env variable HAXELIB_PATH akin to PERL5LIB and Java's CLASSPATH. As haxe do not support it out of the box, if HAXELIB_PATH contains a delimiter : a temporary directory created with symlinks to all paths and this directory is used as HAXELIB_PATH hereinafter.
fix a bug in Neko (acceped by upstream)
restore haxe 3.2.1 along with current release 3.4.2. the older version is needed to compile some dependend libraries.
5.. 6... add plenty of popular frameworks and libs

rebased to https://github.com/NixOS/nixpkgs/pull/27101