text:
chore: bdd-spring-1584967424 to 0.0.1

chore: Promote bdd-spring-1584967424 to version 0.0.1

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:
If they are not already assigned, you can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

source: gharchive/pull-request

license_type: permissive

license_source: github-api


text:
chore: bdd-gh-1584895191 to 0.0.1

chore: Promote bdd-gh-1584895191 to version 0.0.1

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:
If they are not already assigned, you can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


text:
chore: bdd-nh-1587012322 to 0.0.1

chore: Promote bdd-nh-1587012322 to version 0.0.1

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:
If they are not already assigned, you can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


text:
chore: bdd-sbhg-1587633789 to 0.0.1

chore: Promote bdd-sbhg-1587633789 to version 0.0.1

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:
If they are not already assigned, you can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


text:
chore: bdd-gh-1587761365 to 0.0.1

chore: Promote bdd-gh-1587761365 to version 0.0.1

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:
If they are not already assigned, you can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


text:
chore: bdd-nh-1586368516 to 0.0.1

chore: Promote bdd-nh-1586368516 to version 0.0.1

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:
If they are not already assigned, you can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


text:
chore: bdd-sbrp-import-1568075245 to 0.0.1

chore: Promote bdd-sbrp-import-1568075245 to version 0.0.1

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:
If they are not already assigned, you can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


text:
Wrong thread names in method runs reports

A test with 2 @Test methods and one @BeforeMethod. When it is executed with parallel = true, reported thread names are incorrect. Code example (only class body):

@BeforeMethod public void init() {
    Reporter.log(Thread.currentThread().toString());
}
@Test public void test1() {}
@Test public void test2() {}

Lines from report (here threads are correct):

Thread[pool-2-thread-1,5,main]
Thread[pool-2-thread-2,5,main]

And this information is extracted from the "Method runs, sorted chronologically" report (methods.html):

11/12/31 01:30:26   0   >>init  pool-2-thread-1@1272266587
11/12/31 01:30:26   -1  >>init  pool-2-thread-1@1272266587
11/12/31 01:30:26   6   test1   pool-2-thread-1@1272266587
11/12/31 01:30:26   6   test2   pool-2-thread-2@489854530

In the report for the both invocations of init() method the same thread is shown.

I'm about to deprecate these reports, can you check if the error is there as well in the new reports?
Thanks.

I can't find any information about threads in the new reports. Also "Reporter output" is empty.

The new reporter viz., org.testng.reporters.jq.Main which now generates the reports, no longer shows the output for configuration methods but confines itself to showing the output of test methods only.

source: gharchive/issue

authors: cbeust krmahadevan sergebg

repo: cbeust/testng

license_source: bigquery


text:
Support large feature tables

This PR solves issue #19 - package ff fails on the allocation of the correlation matrix for large feature tables with dimensions greater than .Machine$integer.max  (details).
The solution was to avoid allocating the whole matrix and thus using the ff package. The idea was to compute only intermediate matrices and store them in the output vector. More details of the algorithm before and after this PR are outlined in the picture below (sorry for the low quality, it's just a sketch).
Also added simple integration test of main functionality and conda environment file for local testing.
Close #19.

Hi, I saw that you included a testthat case, that's great. So I guess that both old and new approach will pass the test and give identical results ? Yours, Steffen

Thanks Steffen - i appreciate you jumping in for this.  I am new to this process!   The 'identical results' question is the one i was to ask as well.

Hi. Yes, the integration test is passing in both versions.
I also refactored and extracted function for computing the similarity. We could write unit tests for this, although it is not easy to compare it with the old version.

I am not clear what the 'integration test' is testing, precisely.  I also am not clear what you mean by 'refactored and extracted function for computing similarity'.   The similarity score should not have to have been changed to make the integer.max problem go away?
Comparing with the old version:
It would be pretty easy to test the ultimate results:
Identical(rc.old$featclus, rc.new$featclus)
Identical(rc.old$fmz, rc.new$fmz)
If those to things are identical, we can be pretty confident the rest is too.
C
From: Matej Troják @.>
Sent: Tuesday, February 22, 2022 2:22 PM
To: cbroeckl/RAMClustR @.>
Cc: Broeckling,Corey @.>; Comment @.>
Subject: Re: [cbroeckl/RAMClustR] Support large feature tables (PR #20)
** Caution: EXTERNAL Sender **
Hi. Yes, the integration test is passing in both versions.
I also refactored and extracted function for computing the similarity. We could write unit tests for this, although it is not easy to compare it with the old version.

Reply to this email directly, view it on GitHubhttps://nam10.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fcbroeckl%2FRAMClustR%2Fpull%2F20%23issuecomment-1048223871&data=04|01|corey.broeckling%40colostate.edu|5bfb348978f341df7b6508d9f6496961|afb58802ff7a4bb1ab21367ff2ecfc8b|0|0|637811617427512524|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=uikLcAURV1tJ1ohCeIM0ktUFeiLRalYR2MolMcITYO4%3D&reserved=0, or unsubscribehttps://nam10.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FABF257IED56CNFZFQ3W6CJ3U4P5AZANCNFSM5PBU4DPA&data=04|01|corey.broeckling%40colostate.edu|5bfb348978f341df7b6508d9f6496961|afb58802ff7a4bb1ab21367ff2ecfc8b|0|0|637811617427512524|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=w9VcrRC5bv%2FCPIyBOG7b589LUEeAHb3zN8bFok2X41A%3D&reserved=0.
Triage notifications on the go with GitHub Mobile for iOShttps://nam10.safelinks.protection.outlook.com/?url=https%3A%2F%2Fapps.apple.com%2Fapp%2Fapple-store%2Fid1477376905%3Fct%3Dnotification-email%26mt%3D8%26pt%3D524675&data=04|01|corey.broeckling%40colostate.edu|5bfb348978f341df7b6508d9f6496961|afb58802ff7a4bb1ab21367ff2ecfc8b|0|0|637811617427512524|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=ky81czvxsjsmrn4eqjskxM3pMrVFjvNlm%2FAg4bFw8mE%3D&reserved=0 or Androidhttps://nam10.safelinks.protection.outlook.com/?url=https%3A%2F%2Fplay.google.com%2Fstore%2Fapps%2Fdetails%3Fid%3Dcom.github.android%26referrer%3Dutm_campaign%253Dnotification-email%2526utm_medium%253Demail%2526utm_source%253Dgithub&data=04|01|corey.broeckling%40colostate.edu|5bfb348978f341df7b6508d9f6496961|afb58802ff7a4bb1ab21367ff2ecfc8b|0|0|637811617427512524|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=Rvkzg1WrUsOhVqBAWZEepVzuNgoiC%2B0Nv8oRdM%2B3iCA%3D&reserved=0.
You are receiving this because you commented.Message ID: @.@.>>

@xtrojak i see the commit for testing:

expect_equal(readLines(expected_msp), readLines(actual_msp))

and it would certainly seem true that if the new .msp file is identical to the old .msp file that the clustering is identical.

@cbroeckl sorry if my answer was confusing. The expected output in "testdata/output.msp" was created using the old version (currently in master) and is being compared to a msp file created using the new version in the test.

@cbroeckl Thank you very much! Yes, we verify that if we re-write an algorithm or so that the outputs of the tool/algorithm don't change so that they are equivalent. Refactoring means changing code structure without changing function 👍

@xtrojak and @hechth - thanks for your contributions.  I am glad that you are finding it valuable enough to continue to invest time into it!

authors: cbroeckl hechth sneumann xtrojak

repo: cbroeckl/RAMClustR

license: MIT


text:
夜莺使用调研，为什么突然嵌入这个链接，该怎么取消啊？

Question and Steps to reproduce
为什么右下角突然嵌入了一个按钮，是不是有后门代码啊？该怎么取消啊？
Relevant logs and configurations
无

Version
版本 7.3.1

增加调研入口是为了让用户更方便的提反馈建议，并不是后门

repo: ccfos/nightingale


text:
Fix build

https://zlib.net/zlib-1.2.12.tar.gz returns error code 404, so this replaces it with https://zlib.net/zlib-1.2.13.tar.gz

Notably all versions of zlib remain available at https://zlib.net/fossils/, so those links could be used instead if you wanted to keep using the older version.

Thank you @stevennyman.  Yes, I guess it'd be better to pin the version and point to the URL under fossils so this recurring issue does not happen again.

I updated the PR to pin the version which should keep builds working. It would still be a good idea to periodically update the version that is used though.

authors: ccoreilly stevennyman

repo: ccoreilly/vosk-browser


text:
Inline video audio continues to play after the video is no longer visible

See (has audio) https://streamable.com/ur696 - the audio stops after leaving the comments view.
Also, after returning from the comments view, the red audio icon is not visible when replaying the video: https://i.imgur.com/Lv7BASa.mp4 The audio plays when you click the video to show it fullscreen but remains muted when you dismiss the fullscreen view: (has audio) https://streamable.com/ow86h
I think it would be helpful to have an option to have inline videos play with audio unmuted. Sometimes I'll play a video inline and not realize it had audio until the end of the video. Or maybe there could be a quick animation that alerts the user that the inline video has audio? Maybe an animation like a larger version or the red audio icon starting in the middle of the video view and shrinking to the corner.

Hmm, I am not able to reproduce this. I think what might be happening in your case is the video is playing in the CommentVC which is actually still stored in memory (the last page is stored so you can return if you closed accidentally), but I do destroy the AVPlayer in the viewWillDisappear block. The LinkCellView there is actually completely recreated when returning to the subredditVC so you should not be seeing different behavior when returning (as it's essentially restarting the cell). It's possible that stored AVPlayer in the comment vc is taking the audio focus?

That's weird, maybe the issue is iOS dependent? I notice this issue on an iPhone 6 Plus running iOS 10.3.3 (14G60).
Clean install: https://streamable.com/60ogy
* Note that you can hear the audio doubled after the unmute button is pressed in the comments view.
Clean install with "Play videos on tap" set: https://streamable.com/6ew2x

If the sound is doubled, that means there are two AVPlayer instances running at one time. It must be the one in comments not getting killed somehow 🤔

Actually, I think pausing/muting the video when opening comments from the LinkCellView would fix this issue

I think I fixed it in my latest commit, if not please re-open this!

Okay, I just install the latest version and the main audio issue is fixed. There are still some cases where the unmute button isn't present. I'll see if I reproduce the issue.

authors: ccrama djjcast

repo: ccrama/Slide-iOS


text:
Log argument

Hello Sir
The --log argument is not supported in the final version (1.2.3) for Windows. How can I print the docking results into files without the copy-paste method?

Redirecting the standard output with > achieves a similar result:
vina --config docking.conf > output.log

thanx

repo: ccsb-scripps/AutoDock-Vina


text:
Connectivity constraints for clifford synthesis

Description
This PR implements connectivity constraints for the clifford synthesis as requested by #328, by passing optional coupling maps. The passed coupling map used to restrict CNOTs to only connected qubits. Additionally, the clifford synthesizer needs to check if the circuit can be synthesized with any permutation of qubits. If no coupling map is passed all to all connectivity is assumed.
Checklist:

[x] The pull request only contains commits that are related to it.
[x] I have added appropriate tests and documentation.
[x] I have made sure that all CI jobs on GitHub pass.
[x] The pull request introduces no new warnings and follows the project's style guidelines.

[!NOTE]
#507 just went in and brought some updates from the MQT Core dependency that cause some conflicts here. Could you please resolve these? They should be fairly easy to resolve. Sorry for the inconvenience.

@burgholzer I tried to resolve the conflicts and everything works locally. However the CI/Change/Check test fails, but all subtasks in there are marked as successful. Do you know what the issue is?

@burgholzer I tried to resolve the conflicts and everything works locally. However the CI/Change/Check test fails, but all subtasks in there are marked as successful. Do you know what the issue is?

Thanks for fixing the conflicts so quickly.
I just retriggered the respective CI job. Let's see if it still fails on the second try.
Should be unrelated to your changes in any case.

@burgholzer @pehamTom I incorporated the feedback by Tom. However now all Python Test fail with a Deprecation warning and one C test which should be unrelated to my PR. Do you know how to solve that?

@burgholzer @pehamTom I incorporated the feedback by Tom. However now all Python Test fail with a Deprecation warning and one C test which should be unrelated to my PR. Do you know how to solve that?

Yeah, that is not your fault. We leave the PR open until the IDP is over anyway. I will take care of it.

@burgholzer @pehamTom I incorporated the feedback by Tom. However now all Python Test fail with a Deprecation warning and one C test which should be unrelated to my PR. Do you know how to solve that?

I think if you hit the "Update Branch" button (effectively merging in the main branch), the deprecation warnings should be gone. IIRC, I fixed them for QMAP in one of the latest updates.
Otherwise, I'll probably address them next week in a separate PR. They should not be related to your changes here 😌

Just merged the main branch in which contains the fixes from #509.
The deprecation warnings here are now really related to your code changes and should be addressed (should be fairly easy).

authors: JakobSchaeffeler burgholzer pehamTom

repo: cda-tum/mqt-qmap


text:
CDF Landscape rollout yaml file

The Landscape processes uses a YAML file that members can update.  We need to build the initial file and test it out.

@danlopez00 is working on it here: https://github.com/cdfoundation/landscape

Correct. We need to chase down the SVGs

It should be in the CNCF landscape repo, you can just reuse the SVGs
https://github.com/cncf/landscape/tree/master/hosted_logos

@TracyRagan has made a lot of progress with logos after @danlopez00 initial code commit. @danlopez00 also provided @TracyRagan various API keys to allow the app to work. We will sync up next week but the next step is to deploy
@danlopez00 to work with @caniszczyk to deploy

deployed v0.5 draft https://landscape.cd.foundation/
https://github.com/cdfoundation/cdf-landscape/blob/master/landscape.yml

Closing this and will move discussion to landscape repo

authors: TracyRagan caniszczyk danlopez00

repo: cdfoundation/foundation


text:
Model Naming

Desire is to make the model more "implementation" friendly while maintaining the precision of the definitions and preferred terms
See slide deck from London scoping F2F meeting
We need to document the naming convention, probably in the IG in an introduction section

Suggested split of PBI:

Align on and document the standard naming conventions and present in IG
Define what attributes in the model need to be changed - change correspondingly in CT and logical model
Update attributes in API (1 sprint later)

Spreadsheet with the list of potential attributes. Two sheets

One with name & description pairs. I think these are the candidates for just being "name" and "description" attributes. Note, they are always in pairs.
Second sheet with classes with only description fields. These are the "scientific" fields that I don't want to change.

@EMuhlbradt @czwickl Have a think on these, this is your call. This is just an extract from the latest CT spreadsheet as per V2.
NameAndDescription.xlsx

@EMuhlbradt Move studyArmDataOriginDescription to Caution tab

Update needed to https://wiki.cdisc.org/display/USDMIGv1/USDM+Data+Dictionary

We have discussed all of the proposed changes to UML model names for Name and Description type attributes. Our comments/thougts/recommendation are in the attached.
NameAndDescription_116_em.xlsx

One comment from the spreadsheet
"General recommendation from Erin/Craig: All entities should be considered to have the following attributes at the very least: Id, Name, Label, Description, Code, and Type. Then it is a logical exercise to determine for each entity, what subset of these are valid/used in practice."
Label and Description. We have not yet used "Label". What is the logic here? Do we want to distinguish between "Label", just a useful human readable label and description which is something more specific?

Attribute Codes links to 'foreign' dictionaries for interventions and Indications. So the indication "Diabetes" can have multiple codes in 1 or more multiple dictionaries. The attribute codes is therefore important for linking to other dictionaries. Also regulatory agencies require those codings. For example CTIS requires a lot of different codings for the Intervention. Adding a Name attribute (and possibly a label) is indeed a good extension for version 3.

Attribute Codes links to 'foreign' dictionaries for interventions and Indications. So the indication "Diabetes" can have multiple codes in 1 or more multiple dictionaries. The attribute 'codes' is therefore important for linking to other dictionaries. Also regulatory agencies require those codings. For example CTIS requires a lot of different codings for the Intervention. Adding a Name attribute (and possibly a label) is indeed a good extension for version 3. However, it does not add value to nest the codes within names as the codes related to the whole intervention and not only to the name of the intervention.

For multiple alternative codings the AliasCode is used. So where this is needed we can change "Code" -> "AliasCode". AliasCode has one standard code and multiple alternative Codes

AliasCode includes the option for 1 standard code and multiple alternative codes. In other cases, the standard code is the CDISC CT. However, for interventions and indications, this does not hold. @dih-cdisc Is it then better to refer to a list of multiple codes like we have now or to the AliasCode class?

In the discussion with Diana, Rebecca and Bess on alignment with SDTM Trial summary domains, Diana indicated that Type alone is not specific enough. Type can be anything and we should better indicate what type we mean. So removing the class name is therefore not a good option since there can be many kinds of types for a single entry in a class. So, on the contrary it might even have to be more specific then only adding the class name.

@dih-cdisc @BSnoeijerCD : CT Deliverable updated in the Github Repository, branch 3-1

In the discussion with Diana, Rebecca and Bess on alignment with SDTM Trial summary domains, Diana indicated that Type alone is not specific enough. Type can be anything and we should better indicate what type we mean. So removing the class name is therefore not a good option since there can be many kinds of types for a single entry in a class. So, on the contrary it might even have to be more specific then only adding the class name.

This is not the case. The "type" field refers to , and only refers to , the type of the class/instance. Any other "types" have their names distinguished by some prefix to distinguish them. In addition, the preferred terms and definitions remain.
As an example, look at the StudyArm  class:

Here we have type (of the study arm) and the dataOriginType ( the origin type of the arm's data) with their associated preferred terms and definitions. Prefixing "studyArm" makes them no more distinguishable. The "type" field always refers to type of the class/instance as the name always refers to the name of the class/instance. Any additional types need to be prefixed with an appropriate preferred term and definition.

Thank you Dave. Makes sense. This will help in further discussions on naming standards..

branch

Thank you Erin. You probably indicated this in the Excel. But can we discuss today why the following items were not changed? - bcName, bcPropertyName, OrganizationName, TimingDescription. I believe they should fall under the same convention as the ones that are changed now.

branch

Thank you Erin. You probably indicated this in the Excel. But can we discuss today why the following items were not changed? - bcName, bcPropertyName, OrganizationName, TimingDescription. I believe they should fall under the same convention as the ones that are changed now.

As discussed on the scrum call 17th Jul, these should not be changed. See ticket

@EMuhlbradt @czwickl @dih-cdisc :
The following changes do not fall under the (only Name, Id, Description rule)

studyArm part removed from studyArmDataOriginDescription.
endpointPurposeDescription changed to PurposeDescription

@MarkPAndrews and @cupkes - please note as well.

@BSnoeijerCD fixes completed in Github Repo for CT deliverables

authors: BSnoeijerCD EMuhlbradt dih-cdisc jowencdisc

repo: cdisc-org/DDF-RA


text:
GeneratorApp Update [dataDictionary.MD]

See Improvement ticket #527
This ticket aims to create the dataDictionary.MD file which is based on dataStructure.yml. The dataDictionary.MD file will be used for the implementation guide.

See ticket #524 for issue with current app to be resolved in this version.


text:
feat(app): hook into synthesis with chart.toJson (#1053)

Backport
This will backport the following commits from 2.x to 1.x:

feat(app): hook into synthesis with chart.toJson (#1053)

Questions ?
Please refer to the Backport tool documentation

⚪ Backport skipped
The pull request was not backported as there were no branches to backport to. If this is a mistake, please apply the desired version labels or run the backport tool manually.
Manual backport
To create the backport manually run:
backport --pr 1056

Questions ?
Please refer to the Backport tool documentation


text:
chore(deps): upgrade dev dependencies

Upgrades project dependencies. See details in workflow run.

Automatically created by projen via the "upgrade-dev-dependencies-1.x" workflow

⚪ Backport skipped
The pull request was not backported as there were no branches to backport to. If this is a mistake, please apply the desired version labels or run the backport tool manually.
Manual backport
To create the backport manually run:
backport --pr 1773

Questions ?
Please refer to the Backport tool documentation


text:
chore(deps): upgrade dependencies

Upgrades project dependencies. See details in workflow run.

Automatically created by projen via the "upgrade-k8s-25-main" workflow

⚪ Backport skipped
The pull request was not backported as there were no branches to backport to. If this is a mistake, please apply the desired version labels or run the backport tool manually.
Manual backport
To create the backport manually run:
backport --pr 2574

Questions ?
Please refer to the Backport tool documentation


text:
chore(deps): upgrade dev dependencies

Upgrades project dependencies. See details in workflow run.

Automatically created by projen via the "upgrade-dev-dependencies-k8s-28-main" workflow

⚪ Backport skipped
The pull request was not backported as there were no branches to backport to. If this is a mistake, please apply the desired version labels or run the backport tool manually.
Manual backport
To create the backport manually run:
backport --pr 4414

Questions ?
Please refer to the Backport tool documentation


text:
Search highlight enhancement

search pattern:

smalot bootstrap-datetimepicker
smalot/bootstrap-datetimepicker

The repository part, only the author string will have highlight, only smalot\/bootstrap-datetimepicker can highlight them together (but not slash)

If we submit smalot\/bootstrap-datetimepicker to algoria,
it considers that \/ is kind of typo not escape character /.
The result will be the same if we change \/ to 1/ or ~/.
So, do we need to add function that if we submit author/repo it will search by github?

IMO it's not about what do we submit to algolia, but how we highlight them in https://github.com/cdnjs/new-website/blob/master/public/js/main.js, agree?

I believe this is still an issue that should be looked at, so going to keep this open.

Feel free to open a new issue for it, as I was removed from the organization without any discussion and respect, just like some other members(I know it's not by you and you're not the one who's in charge for that), I'm now closing ancient issues I'm not working on so that I don't need to receive unnecessary notifications, thanks.

As mentioned here and here, please use the unsubscribe button in this issue if you no longer wish to receive notifications for it. However, please leave this issue open as it is still needed.

repo: cdnjs/new-website

license: ISC


text:
add compression algorithms

[x] brotli11
[x] gzip9

Out of curiosity: What do we need this for? :)

Out of curiosity: What do we need this for? :)

For this reason. I was wondering why gzip -d and brotli -d were giving corruption error messages.

For this reason

I meant, why do we need this PR. What do we need to compress? :)

I meant, why do we need this PR. What do we need to compress? :)

The old cdnjs auto update bot compressed image files — I assume this is going to be for implementing something similar to help reduce file sizes.
You may notice some packages have a dot file for not optimising images, this was from the old bot when it used compression, for cases when we didn’t want to compress images.
@tc80 correct me if I’m wrong on the intent behind this PR!

cdnjs.cloudlare.com currently rely on Cloudflare on-the-fly compression which is good but want to increase the levels they are compressed at. Files will be smaller and that will reduce the bandwidth

repo: cdnjs/tools


text:
New version 3.9.2 not pushed to docker registry codercom

Warning  Failed                  4s (x2 over 17s)  kubelet                  Failed to pull image "codercom/code-server:3.9.2": rpc error: code = Unknown desc = Error response from daemon: manifest for codercom/code-server:3.9.2 not found: manifest unknown: manifest unknown

Thanks for reporting! We're aware and working on it. Issue with the publish workflow.
See: https://github.com/cdr/code-server/issues/2972#issuecomment-807738553

Heads-up: we're still running into issues with our publish workflow and scripts. We will continue looking into this first thing tomorrow.

Ok. Thanks 👍🏻

The issue has been resolved and 3.9.2 is now available on the Docker registry.

We've also written a regression report which you can read here: https://github.com/cdr/code-server/discussions/2983

@jsjoeio I am now seeing my running 3.9.2 broken after I login. After I login, I see websocket connections failing.

@nodesocket hmm...wonder if it's related to this: https://github.com/cdr/code-server/issues/2975
can you please open a new issue (bug report)?

authors: jsjoeio nodesocket

repo: cdr/code-server


text:
Create code-server.sls

Describe in detail the problem you had and how this PR fixes it
Their is no salt state for deployment using salt.
So I made one :P

forgot to add some files, gonna make a new one. Apologies.

I've also put the salt state in https://github.com/korzq/code-server-salt if it should be linked instead of being in the repo.

Thanks for the conntribution, however, since we don't want to compensate for many use cases, we don't want to support such. I'll be closing this off for now. If its fine for you, just update your repo whenever we release something?

Allright 👍


text:
Test static route

Mostly just wanted to add a test for static auth.

I need to refactor the logger module mock because it causes errors in the e2e tests but that conflicts with some constant test changes you're making so I'm going to wait for that to get merged then rebase.

I'm going to wait for that to get merged then rebase.

authors: code-asher jsjoeio


text:
Fixing ACM validation by iterating over SANs and creating route53

Summary | Résumé
The route53 records in the acm validation config were only creating the first entry. If there are SANs, they validation records were not being created, and thus cert validation was failing. This change adds all records.
Test instructions | Instructions pour tester la modification
terragrunt apply in staging.

So I guess this LGTM but what do I know 😬  I see you've just added Pat which I was going to suggest might be a good idea!

So I guess this LGTM but what do I know 😬 I see you've just added Pat which I was going to suggest might be a good idea!

The good news is that if this doesn't work, it's a very smooth roll back, which is the next step if this doesn't go

repo: cds-snc/notification-terraform


text:
Fix/json template validation

Summary | Résumé
closes https://github.com/cds-snc/platform-forms-client/issues/1455

Removed publishingStatus data migration code now that it did run in staging and production once.
Updated Form template JSON schema with new existing properties created by the form builder.
Removed possibility to add additional properties in the Form template JSON schema.
Fixed the way we unpack JSON validation errors so that it handles the additionalProperties not authorized scenario.

Test instructions | Instructions pour tester la modification

Try to upload a JSON Form file with invalid properties at the root level.

(something like)
{
  "id": "clcj7nk9d00513ld920imgrbr",
  "form": {
    "layout": [
      1
    ],
    "endPage": {
      "descriptionEn": "Confirmed",
      "descriptionFr": "Confirmé",
      "referrerUrlEn": "",
      "referrerUrlFr": ""
    },
    "introduction": {
      "descriptionEn": "This is my test form",
      "descriptionFr": "C'est mon formulaire"
    },
    "privacyPolicy": {
      "descriptionEn": "Private",
      "descriptionFr": "Privé"
    },
    "titleEn": "TestForm",
    "titleFr": "Mon formulaire",
    "version": 1,
    "elements": [
      {
        "id": 1,
        "type": "radio",
        "properties": {
          "choices": [
            {
              "en": "First response",
              "fr": "Première réponse"
            }
          ],
          "titleEn": "First question",
          "titleFr": "Première question",
          "validation": {
            "required": false
          },
          "descriptionEn": "",
          "descriptionFr": ""
        }
      }
    ],
    "emailSubjectEn": "TestForm - Response",
    "emailSubjectFr": "Mon formulaire - Réponse"
  },
  "submission": {
    "email": "Clement.Janin@tbs-sct.gc.ca"
  },
  "securityAttribute": "Unclassified",
  "isPublished": true
}

Unresolved questions / Out of scope | Questions non résolues ou hors sujet
With the upcoming work on https://github.com/cds-snc/platform-forms-client/issues/1480 the Form template JSON schema will change quite a bit since we will pretty much only accept stuff related to the form content.
Pull Request Checklist
Please complete the following items in the checklist before you request a review:

[x] Have you completely tested the functionality of change introduced in this PR? Is the PR solving the problem it's meant to solve within the scope of the related issue?
[x] The PR does not introduce any new issues such as failed tests, console warnings or new bugs.
[x] If this PR adds a package have you ensured its licensed correctly and does not add additional security issues?
[x] Is the code clean, readable and maintainable? Is it easy to understand and comprehend.
[x] Does your code have adequate comprehensible comments? Do new functions have docstrings?
[x] Have you modified the change log and updated any relevant documentation?
[x] Is there adequate test coverage? Both unit tests and end-to-end tests where applicable?
[x] If your PR is touching any UI is it accessible? Have you tested it with a screen reader? Have you tested it with automated testing tools such as axe?

Nice work 👍 I noticed though that the reCaptchaID should be removed from the json validation as it is not configurable.
    "reCaptchaID": {
      "type": "string",
      "description": ""
    }

I also think we can keep the seed file migration function in place if we are ensuring that 'publishingStatus' cannot be added to the template JSON. This ensures a clean upgrade path for anyone else who may be on any version of our app.

Removed reCaptchaID and commit that got rid of publishingStatus data migration.

Seeing this when doing an export / import from the form builder

Code:

Seeing this when doing an export / import from the form builder

Code:

@timarney  Was not this supposed to be removed during the export? Or did we just ignore it while importing the JSON file?

@timarney Was not this supposed to be removed during the export? Or did we just ignore it while importing the JSON file?

I think we should remove it when it's downloaded
const schema: Partial<FormRecord> = {
    id,
    form,
    submission,
  };

Yes I agree. I am working on that temporary solution.
By the way, it will change quite a bit when I start working on the new Form Template DB schema.

authors: craigzour timarney

repo: cds-snc/platform-forms-client


text:
🛑 tanecni-divadlo.cz is down

In 01bf0fc, tanecni-divadlo.cz (https://www.tanecni-divadlo.cz) was down:

HTTP code: 0
Response time: 0 ms

Resolved: tanecni-divadlo.cz is back up in 0e56769.

repo: cebreus/upptime


text:
🛑 tanecni-divadlo.cz is down

In 7ee354b, tanecni-divadlo.cz (https://www.tanecni-divadlo.cz) was down:

HTTP code: 0
Response time: 0 ms

Resolved: tanecni-divadlo.cz is back up in 754a8e7.


text:
🛑 tanecni-divadlo.cz is down

In 8ce13a0, tanecni-divadlo.cz (https://www.tanecni-divadlo.cz) was down:

HTTP code: 0
Response time: 0 ms

Resolved: tanecni-divadlo.cz is back up in b4367cd after 477 days, 11 hours, 1 minute.


text:
🛑 tanecni-divadlo.cz is down

In 9b5566c, tanecni-divadlo.cz (https://www.tanecni-divadlo.cz) was down:

HTTP code: 0
Response time: 0 ms

Resolved: tanecni-divadlo.cz is back up in 7b85acd.


text:
🛑 tanecni-divadlo.cz is down

In 2da43ca, tanecni-divadlo.cz (https://www.tanecni-divadlo.cz) was down:

HTTP code: 502
Response time: 21656 ms

Resolved: tanecni-divadlo.cz is back up in 4739b19.


text:
🛑 Bali 2017 is down

In 4c1adcd, Bali 2017 (https://bali-2017.cebre.us/) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Bali 2017 is back up in 0cbe35d after 9 minutes.


text:
🛑 Sébastien Thomas Bagnoud is down

In 73d4486, Sébastien Thomas Bagnoud (https://www.sebastienbagnoud.eu/) was down:

HTTP code: 403
Response time: 158 ms

Resolved: Sébastien Thomas Bagnoud is back up in 6228b90.


text:
🛑 tanecni-divadlo.cz is down

In 6810931, tanecni-divadlo.cz (https://www.tanecni-divadlo.cz) was down:

HTTP code: 0
Response time: 0 ms

Resolved: tanecni-divadlo.cz is back up in 3143a04.


text:
🛑 tanecni-divadlo.cz is down

In 602da07, tanecni-divadlo.cz (https://www.tanecni-divadlo.cz) was down:

HTTP code: 0
Response time: 0 ms

Resolved: tanecni-divadlo.cz is back up in 85dc435.


text:
🛑 tanecni-divadlo.cz is down

In 38c823b, tanecni-divadlo.cz (https://www.tanecni-divadlo.cz) was down:

HTTP code: 0
Response time: 0 ms

Resolved: tanecni-divadlo.cz is back up in 86e99a7.


text:
🛑 tanecni-divadlo.cz is down

In 9f5a259, tanecni-divadlo.cz (https://www.tanecni-divadlo.cz) was down:

HTTP code: 0
Response time: 0 ms

Resolved: tanecni-divadlo.cz is back up in a9c3dc0.


text:
🛑 tanecni-divadlo.cz is down

In db963be, tanecni-divadlo.cz (https://www.tanecni-divadlo.cz) was down:

HTTP code: 0
Response time: 0 ms

Resolved: tanecni-divadlo.cz is back up in 1112ad4.


text:
🛑 CDN is down

In 76cb6f0, CDN (https://cdn.ceccun.com/cdynamic/captive) was down:

HTTP code: 522
Response time: 15292 ms

Resolved: CDN is back up in 81e40bf.

repo: ceccun/status


text:
🛑 CDN is down

In 50f516d, CDN (https://cdn.ceccun.com/cdynamic/captive) was down:

HTTP code: 522
Response time: 15334 ms

Resolved: CDN is back up in af0ac81.


text:
🛑 CDN is down

In 1549ea9, CDN (https://cdn.ceccun.com/cdynamic/captive) was down:

HTTP code: 525
Response time: 359 ms

Resolved: CDN is back up in b9cd948 after 794 days, 22 hours, 39 minutes.


text:
Slidy blocks

Conflicts need to be fixed

Merged manually and pushed.


text:
Card and elevation

Continuation of #15

Let me know when it's ready for review

I think this is good to go.

repo: cecton/yewprint


text:
fix: stop overwriting chain-id in testnode

Overview

Checklist

[X] New and updated code has appropriate documentation
[X] New and updated code has new and/or updated testing
[X] Required CI checks are passing
[X] Visual proof for any user facing features like CLI or documentation updates
[X] Linked issues closed with keywords

also, don't worry about the docker build CI failing, it will for all PRs from forks. we should expect the rest to pass though before merging

@Frenzoid this repo attempts to conform to conventional commits so I renamed the PR title b/c the PR title will be used as the default commit message for the squashed commit that ends up on main.

Thank you all for the feeback, tbh its the first time i've seen this repo, and i've reached to it from LW3 :)

authors: Frenzoid evan-forbes rootulp

repo: celestiaorg/celestia-app


text:
HTML Updates post run-through

I got to as much as possible from this google doc.
Missing still are:

Mention syntax highlighting, importance of saving, transitioning between code and browser
HTML slide notes (in HTML portion, create empty CSS folder but don’t add the file)
Add egg timer (I'm not sure how to go about this... maybe we can just add a timer link to the egg timer?)

Other than fixing up issues noted during the run through, I also styled the slides a little:

Using Google font Khula (similar to the font being used on the PTS site)
Used brand colors in the slide CSS file
Added styles for the following slide class names:

.style-intro (Intro slide)

.style-section

.style-exercise

.style-break

I was wrong about how we use these: we need to use: <!-- .slide: data-state="style-[foo]" -->

Closing in favor of PR on the Philly Tech Sistas repo.

repo: cella/pts-intro-to-html-and-css


text:
WIP: Not ready for review

Add AndroidKeystore related helper methods

This is obsolete

repo: celo-org/react-native-geth


text:
A11y: Treeview feedback from Perkins

The follow is feedback from Perkins after a thorough a11y review.
Keyboard and focus

Walking back up the tree using the left arrow isn't working. Pressing the left arrow on a nested end node should move up to the parent node. Pressing left again should close the parent node if it is open or move up again if it is closed. Pressing left a third time should move up to the grandparent node (if it exists). To see this behavior in action, open the APG treeview example and get keyboard focus into a child item of Project 3. Then press the left arrow key several times to see how it moves back up the tree.
When tabbing into a multi-select treeview with selected items, the focus should land on the first selected item. This seems to happen on the initial load when tabbing forward. Tabbing backward into the treeview doesn't bring focus to the first selected item. After that, the focus seems to not return to the treeview.

Suggestions

Animations do not respect a user's reduced motion preference (MDN). The animations are subtle but do cause significant, visible movement of treeitems. Consider removing animations when users have reduced motion enabled.

The screenreader part of this review has been moved to https://github.com/cengage/react-magma/issues/1420

Looks good here, can't find anything off!

I took a look in Storybook and everything looks good to me.

authors: chris-cedrone-cengage orion-cengage

repo: cengage/react-magma


text:
fix(theme): update danger100 hex color

fix #794

Codecov Report

Merging #801 (3b1ebf0) into dev (e226b85) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev     #801   +/-   ##
=======================================
  Coverage   86.59%   86.59%
=======================================
  Files         175      175
  Lines        4475     4475
  Branches     1520     1520
=======================================
  Hits         3875     3875
  Misses        296      296
  Partials      304      304

Impacted Files
Coverage Δ

packages/react-magma-dom/src/theme/magma.ts
100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e226b85...3b1ebf0. Read the comment docs.

authors: codecov-commenter silvalaura


text:
ImportError: No module named certificates

Hi, we are getting No module named certificates when using this lib.
Our script is currently running on an ubuntu box with python Python 3.8.0.
Distributor ID: Ubuntu
Description:    Ubuntu 20.04.1 LTS
Release:        20.04
Codename:       focal

To Reproduce

python3 -m venv .venv
source .venv/bin/activate
python
import censys.certificates <-- Error ModuleNotFoundError: No module named 'censys.certificates'

pip show censys
Name: censys
Version: 2.0.0
Summary: An easy-to-use and lightweight API wrapper for Censys APIs (censys.io).
Home-page: UNKNOWN
Author: Censys Team
Author-email: support@censys.io
License: Apache License, Version 2.0
Location: /home/tony/expanse/.venv/lib/python3.8/site-packages
Requires: requests, backoff
Required-by:

We also check previous issues related to import errors.
Our python script is called censys_subdomain.py and we also removed pyc files as suggested here
We are following the guide provided in your docs at https://censys.io/api.

Hi @blueteamzone we are working on updating our docs on the new search site search.censys.io. In the mean time the most up to date documentation can be found on ReadTheDocs. I have linked to an example import statement. Many of the pats have changed as we have upgraded to a namespace package for more advanced functionality. If you have any more questions please feel free to reach out or create a discussion post.

Hi @blueteamzone I just updated the examples on our site. For more examples you can also see our examples. For now I am going to close this issue.

authors: blueteamzone thehappydinoa

repo: censys/censys-python


text:
Need to add PySide/PySide2 compatibility

Hi,
First of all, thank you for sharing your solution about how to stretch the column size without loosing the control of it. I adapt it for the QTreeWidget and it works !
Just one thing about your article that you forgot to mention is the compatibility between PySide and PySide2, the function setResizeMode does not exist in Pyside2 anymore, you must use setSectionResizeMode instead. So I add a try/except block and it works pretty well.
Here is my custom QTreeWidget class :
class TreeWidget(QtWidgets.QTreeWidget):
    def __init__(self, parent=None):
        super(TreeWidget, self).__init__(parent)

    def resizeEvent(self, event):
        """ Stretch the headers size by its contents.

            By default the ResizeToContents works but it ends up
            to loosing the interaction with the header size controller.
            Here, the QTreeWidget will not only adapt the size of headers
            but will also allow user to modify it if needed.
        """
        super(TreeWidget, self).resizeEvent(event)
        header = self.header()
        for column in range(self.columnCount()):
            # Compatibility between PySide/PySide2
            # setResizeMode does not exists in PySide2 anymore
            try:
                setResizeMode = header.setResizeMode
            except AttributeError:
                setResizeMode = header.setSectionResizeMode
            setResizeMode(column, QtWidgets.QHeaderView.ResizeToContents)
            width = header.sectionSize(column) * 1.01
            setResizeMode(column, QtWidgets.QHeaderView.Interactive)
            header.resizeSection(column, width)

Tell me what you think !
Camelia

Hi @afcamelia ! Thank you for sharing your solution, I would be happy to receive a pull request of your work to add it to the post and of course give the credit to you.

authors: afcamelia centaurialpha

license: mit


text:
pass options strictSSL to config

somehow it is used here https://github.com/centrifugal/jscent/blob/master/lib/requests.js#L10 but not passed from config

Thanks!

0.2.1 maybe?)

Sure, I am currently away from computer - can do this on Monday.

authors: FZambia skarbovskiy

repo: centrifugal/jscent


text:
Error with set-vaultsystem command

When you run the command Set-VaultSystem and try to do a simple change you get the following error message
PS C:\Users\james.wilson> Set-VaultSystem -VaultSystem (Get-VaultSystem -Name "CFY-STANDALONE") -Description test
Invalid arguments passed to the server.
At C:\Program Files\Centrify\PowerShell\Centrify.Platform.PowerShell\Lib\Set-VaultSystem.ps1:356 char:3

    Throw $_.Exception

    ~~~~~~~~~~~~~~~~~~

CategoryInfo          : NotSpecified: (:) [], ParentContainsErrorRecordException
FullyQualifiedErrorId : RuntimeException

This is due to additional attributes added to Systems over the time, one being related to Policies. The missing argument in this exact case is HealthCheckInterval. Need to re-write this cmdlet to account for this parameter and any other that could be missing.

This is due to additional attributes added to Systems over the time, one being related to Policies. The missing argument in this exact case is HealthCheckInterval. Need to re-write this cmdlet to account for this parameter and any other that could be missing.

@badrogh Has there been any progress in resolving this error?

authors: badrogh bisk-e jmwilson5924

repo: centrify/powershell-sdk


text:
ceph_release_num.ceph_release when clause causing warnings

When I use bluestore in ceph-ansible, I see warnings about when statements.   I'm running ansible RPM ansible-2.3.1.0-1.el7.noarch .   This article is providing a hint on how to fix it.
For example:
TASK [ceph-osd : check if bluestore is supported by the selected ceph version] ***
 [WARNING]: when statements should not include jinja2 templating delimiters
such as {{ }} or {% %}. Found: ceph_release_num.{{ ceph_release }} <
ceph_release_num.luminous
skipping: [ip-172-31-38-188]

related BZ :
https://bugzilla.redhat.com/show_bug.cgi?id=1454688

Thanks Ben, closing this since it's tracked in BZ.

authors: bengland2 guits leseb

repo: ceph/ceph-ansible


text:
shadow MountPropagation doesn't seem to work

deploy/cephfs/kubernetes/cephfsplugin.yaml has /var/lib/kubelet/pods enabled with mountPropagation: "Bidirectional", however it seems plugin-dir is also required to have mountPropogation enabled, for the CSI to work properly and the mounts to be visible outside the plugin container.
As the csi-cephfsplugin conatiner first mounts under plugin-dir and then bind-mount to pods-mount-dir (which enables propogation), I can see both mounted properly inside the csi-cephfsplugin, but not on the host node nor other containers that mounted the pvc successfully. Once plugin-dir enabled mountPropagation: "Bidirectional", the propagation to host node and other containers worked as expected.
This is kubernetes v1.10.5 with ubuntu 16.04 4.15.0-29-generic

@Madhu-1 this is addressed already, Isnt it ?

will verify and close it humble

This has been fixed with this PR https://github.com/ceph/ceph-csi/pull/457

authors: Madhu-1 ShyamsundarR clkao humblec

repo: ceph/ceph-csi


text:
check_ceph_df: TypeError: a bytes-like object is required, not 'str'

When monitoring a specific pool with check_ceph_df the following error is thrown:
$ ./check_ceph_df --pool rbd -C 70 -W 50
Traceback (most recent call last):
  File "/usr/lib64/nagios/plugins/ceph-nagios-plugins/check_ceph_df", line 231, in <module>
    sys.exit(main())
  File "/usr/lib64/nagios/plugins/ceph-nagios-plugins/check_ceph_df", line 136, in main
    if args.pool in line:
TypeError: a bytes-like object is required, not 'str'

$ /usr/bin/env python -V
Python 3.6.8

I worked around this by modifying line 136:
# before
if args.pool in line:

# after
if args.pool in str(line):

Not sure if this an appropriate fix - if so, I can open a PR to fix this issue.

Feel free to open a PR

authors: lorenzbausch valerytschopp

repo: ceph/ceph-nagios-plugins


text:
ceph-salt config does not support modifying config options from outside the configuration group

It would be nice if it would be possible to modify configuration options from within the "root" of the configuration tree, including full tab support up to and including the actual config option (see #284 for a related issue).
For example, it would be nice if the following would not fail:
/> set /cephadm_bootstrap/dashboard/username ceph-admin
Command not found set

You are using incorrect syntax, config path should be the first thing:
/> set /cephadm_bootstrap/dashboard/username ceph-admin
Command not found set

/> /cephadm_bootstrap/dashboard/username set ceph-admin
Value set.

This works indeed - thanks. However, this feels somewhat unintuitive, but I understand it needs to be fixed in the configshell Python module itself.

authors: LenzGr ricardoasmarques

repo: ceph/ceph-salt


text:
salt_utils: don't log dashboard password

Signed-off-by: Tim Serong tserong@suse.com

Codecov Report

Merging #228 into master will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #228   +/-   ##
=======================================
  Coverage   76.87%   76.87%
=======================================
  Files          11       11
  Lines        2400     2400
=======================================
  Hits         1845     1845
  Misses        555      555

Impacted Files
Coverage Δ

ceph_salt/salt_utils.py
90.30% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a853f43...739cedd. Read the comment docs.

A similar change is required for the set method, but it's now included in https://github.com/ceph/ceph-salt/pull/234

authors: codecov-io ricardoasmarques tserong


text:
config: import MuableMapping based on python version

MutableMapping has been moved from collections to collections.abc.

@tchaikov There's slight change in the patch since you last reviewed. I've removed a line leftover from previous patch version.

@tchaikov

just one thing, might want to s/py3.10/config/ in the title of the commit message.

Done.

@tchaikov Thanks!

@susebot run deploy

09:22:45 2022-04-20 01:22:45,541.541 DEBUG:teuthology.suite.util:Defaults for machine_type smithi distro centos: arch=x86_64, release=centos/7, pkg_type=rpm
09:22:45 2022-04-20 01:22:45,541.541 INFO:teuthology.suite.util:container build centos/8, checking for build_complete
09:22:45 2022-04-20 01:22:45,542.542 DEBUG:teuthology.packaging:Querying https://shaman.ceph.com/api/search?status=ready&project=ceph&flavor=default&distros=centos%2F8%2Fx86_64&sha1=b51d866559c7cde15d3b75ee17bbba8fdf2584be
09:22:45 2022-04-20 01:22:46,544.544 INFO:teuthology.suite.util:build not complete
...
09:28:36 2022-04-20 01:28:36,786.786 ERROR:teuthology.suite.run:Packages for os_type 'centos', flavor default and ceph hash '82a94f6d8b62882e7d90b23ea5b31b79cdf3e5c3' not found
09:28:36 2022-04-20 01:28:39,802.802 DEBUG:teuthology.suite.util:Defaults for machine_type smithi distro centos: arch=x86_64, release=centos/7, pkg_type=rpm
09:28:39 2022-04-20 01:28:39,802.802 INFO:teuthology.suite.util:container build centos/8, checking for build_complete
09:28:39 2022-04-20 01:28:39,803.803 DEBUG:teuthology.packaging:Querying https://shaman.ceph.com/api/search?status=ready&project=ceph&flavor=default&distros=centos%2F8%2Fx86_64&sha1=fe63bec3382a149b52666f29358580c48ad8772b
09:28:39 2022-04-20 01:28:40,293.293 INFO:teuthology.suite.util:build not complete
09:28:40 2022-04-20 01:28:40,293.293 ERROR:teuthology.suite.run:Packages for os_type 'centos', flavor default and ceph hash 'fe63bec3382a149b52666f29358580c48ad8772b' not found
09:28:40 Traceback (most recent call last):
09:28:43   File "/home/runner/src/teuthology_master/virtualenv/bin/teuthology-suite", line 33, in <module>
09:28:43     sys.exit(load_entry_point('teuthology', 'console_scripts', 'teuthology-suite')())
09:28:43   File "/home/runner/src/teuthology_master/scripts/suite.py", line 193, in main
09:28:43     return teuthology.suite.main(args)
09:28:43   File "/home/runner/src/teuthology_master/teuthology/suite/__init__.py", line 144, in main
09:28:43     run.prepare_and_schedule()
09:28:43   File "/home/runner/src/teuthology_master/teuthology/suite/run.py", line 398, in prepare_and_schedule
09:28:43     num_jobs = self.schedule_suite()
09:28:43   File "/home/runner/src/teuthology_master/teuthology/suite/run.py", line 640, in schedule_suite
09:28:43     name,
09:28:43   File "/home/runner/src/teuthology_master/teuthology/suite/util.py", line 76, in schedule_fail
09:28:43     raise ScheduleFailError(message, name)
09:28:43 teuthology.exceptions.ScheduleFailError: Scheduling runner-2022-04-20_01:22:33-fs:basic_functional-octopus-distro-default-gra failed: Exceeded 100 backtracks; raise --newest value
09:28:43 + RESULT=1
09:28:43 + echo 1

seems the test script was trying to grab an octopus build, but failed. i cross-checked the build using shaman manually, and verified that octpus builds are not available anymore https://shaman.ceph.com/repos/ceph/octopus/b51d866559c7cde15d3b75ee17bbba8fdf2584be/.
now that we are only maintaining N-2 LTS branches, namely, pacific and quincy (https://github.com/ceph/ceph/commit/43e2e60a7559d3f46c9d53f1ca875fd499a1e35e). probably we need to move over to one of them?
hi @kshtsk do you want to take a look as well? if no objections, i am going to merge this change.

@tchaikov yep, we discuss it a bit with @zmc, I gonna try one of those branches and get to you back soon

thank you @kshtsk for your quick reply. looking forward to your good news!
and i am merging this change.

authors: kshtsk rishabh-d-dave tchaikov

repo: ceph/teuthology


text:
DNM: Support fetching packages from shaman instead of gitbuilder

Note that this PR does not add shaman support to the kernel task, as we're not building kernels with chacra yet.

Let's schedule some test runs.
$ cat shaman.yaml
use_shaman: true

teuthology-suite -v -c jewel -s smoke -m vps -v -p 1 -t wip-shaman-2 -k distro -e zack@redhat.com -d ubuntu -D 16.04 -l 3 --filter-out ceph-deploy  $PWD/shaman.yaml
teuthology-suite -v -c jewel -s smoke -m vps -v -p 1 -t wip-shaman-2 -k distro -e zack@redhat.com -d ubuntu -D 16.04 -l 3 --filter-out ceph-deploy

The build missing the libcephfs-java package is here, but in the last couple hours it has disappeared entirely, even though it is still referred to by this shaman query:
{
status: "ready",
sha1: "9bfc0cf178dc21b0fe33e0ce3b90a18858abaf1b",
extra: {
build_url: "https://jenkins.ceph.com/job/ceph-dev-build/ARCH=x86_64,AVAILABLE_ARCH=x86_64,AVAILABLE_DIST=xenial,DIST=xenial,MACHINE_SIZE=huge/493/",
root_build_cause: "MANUALTRIGGER",
version: "10.2.2-508-g9bfc0cf",
node_name: "158.69.91.83+xenial_trusty_pbuilder_huge__8d10ffc3-3484-40d4-bbad-db68c6eb8dc7",
job_name: "ceph-dev-build/ARCH=x86_64,AVAILABLE_ARCH=x86_64,AVAILABLE_DIST=xenial,DIST=xenial,MACHINE_SIZE=huge",
package_manager_version: "10.2.2-508-g9bfc0cf-1xenial"
},
url: "https://1.chacra.ceph.com/r/ceph/jewel/9bfc0cf178dc21b0fe33e0ce3b90a18858abaf1b/ubuntu/xenial/flavors/default/",
distro_codename: "xenial",
modified: "2016-09-12 18:11:50.242532",
distro_version: "16.04",
project: "ceph",
flavor: "default",
ref: "jewel",
chacra_url: "https://1.chacra.ceph.com/repos/ceph/jewel/9bfc0cf178dc21b0fe33e0ce3b90a18858abaf1b/ubuntu/xenial/flavors/default/",
archs: [
"x86_64"
],
distro: "ubuntu"
},

@zmc Those repos disappeared on you because the hard drives of both chacra1 and chacra2 filled up because of a bug related to chacra not deleting repo paths. @alfredodeza had to do some emergency cleanup and those must have been removed.
Sorry to pull the rug out from under you here. I'll see if can force an update somehow to change the status of these in shaman.

More tests:

teuthology-suite -v -c master -s upgrade/jewel-x -m vps -p 1 -t wip-shaman-2 -k distro -e zack@redhat.com --filter-out 14.04 $PWD/shaman.yaml
teuthology-suite -v -c master -s upgrade/jewel-x -m vps -p 1 -t wip-shaman-2 -k distro -e zack@redhat.com --filter-out 14.04

I was expecting some work in teuthology.suite to find out what sha1 to test based on what distros are being used in the job, perhaps using the sha1=latest feature of shaman. Is that work we plan to do later? Or maybe we don't even want to do that anymore?
I did see a few references to GitbuilderProject in teuthology.suite.util still, for example: https://github.com/ceph/teuthology/blob/master/teuthology/suite/util.py#L102

@andrewschoen This PR is focusing on supporting the new build system as a drop-in replacement to the old. The "latest for all distros" feature idea isn't fully fleshed out so work hasn't started on it.
Your link is to the master branch :)

@zmc ah, gotcha. I just wanted to make sure we were still thinking about the "latest for all distros" feature.

An update: I've been sidetracked a bit lately but picked this back up today. I discovered an issue while running upgrade tests where ShamanProject wasn't using the same rules for ref precedence as GitbuilderProject. It took a bit of refactoring to get them to share the same rules, but I did find and fix a couple long-standing, apparently unnoticed bugs in the process. So, more tests:

teuthology-suite -v -c master -s upgrade/jewel-x -m vps -p 1 -t wip-shaman-2 -k distro -e zack@redhat.com $PWD/shaman.yaml
teuthology-suite -v -c master -s upgrade/jewel-x -m vps -p 1 -t wip-shaman-2 -k distro -e zack@redhat.com

"precendence" on the commit msg in 35e1d7f

So far this all looks credible to me.

authors: andrewschoen dmick zmc


text:
Allow module to create discrete firebase instances

This should allow the firebase module to be instantiated multiple times using different firebase applications.

not quite right, yet.

repo: cerebral/cerebral-module-firebase


text:
Feature Request: Toggle via commandline

I'd like a way to toggle cerebro on via the commandline, instead of via a hotkey.  The reason is that I use my window manager to do all my other keyboard remapping, and it would be nice to have it all in one place.  The idea is that calling a new command cerebro-toggle from the commandline would be the equivalent of hitting the hot-key.  Oh, and providing a way to disable the hotkey would be nice too. If running and in the tray it's still available via right-click, after all.

@pjz what OS do you use? I'm not sure how to do it on Linux, but on Windows and Mac should work custom protocol. I.e. on mac you can use open command in terminal: open cerebro://search. You can even provide search term to it by open "cerebro://search?term=hello"

I'm on Linux.  And cerebro doesn't register itself as a protocol handler for xdg-open to use.

This feature is very important to support some workflows, not just for centralizing keybinding definitions.
As an example, a user may want to trigger a sequence of events such as:

Move to another virtual desktop
Trigger Cerebro
Modify the size of the Cerebro window

Is there any workaround for the current version to support such a workflow?

Since #235 is merged, starting cerebro a second time should just bring it on the screen.
To extend it with toggle functionality, I suggest just extending that bit, for example with something like that:
if (mainWindow.isMinimized()) mainWindow.restore()
else mainWindow.hide() <----------------------

Then it will be possible to externally bind a shortcut to run cerebro process.

Thanks @maximbaz !
For my use cases starting it is enough (no need for the hiding of a toggle functionality).

Current appimage does not support starting a second time - and it would be anyway not exactly snappy for a launcher. So without a toggle possibility it looks like wayland users are out of luck ...
Maybe a  quick(?) workaround could be to add a local websocket listener on a unix domain socket file, which one could feed via any websocket client in order to be able to bind a wayland keyboard shortcut?

ok, I'm not a big javascripter but listening on a udp sock was simple enough for one massive hack getting cerebro working in gnome/wayland:
In the git version go to  /app/main/createWindow.js
+ function listen_udp() {
+     const dgram = require('dgram');
+     const server = dgram.createSocket('udp4');
+
+     server.on('error', (err) => {
+           server.close();
+     });
+
+     server.on('message', (msg, rinfo) => {
+           toggleMainWindow()
+     });
+
+     server.on('listening', () => {
+           const address = server.address();
+           console.log(`server listening ${address.address}:${address.port}`);
+     });
+
+     server.bind(41234);
+ }
+    listen_udp()

so that you can toggle it via an echo "a" > /dev/udp/127.0.0.1/41234 which you put into a script and bind that to the Ctrl-Space gnome hotkey.

I close this as moved to #500

authors: AXGKl KELiON dubisdev infokiller maximbaz pjz

repo: cerebroapp/cerebro


text:
Application depicts black screen within dialog on first install. Workaround posted.

Installed it, typed ctrl + space, and the application presented itself as expected. When I started typing in the query box, the dialog expanded and presented a black screen only, with what looked like a Google icon. Clearly not as expected.
After looking around I saw that cerebro had theme settings and since I use a dark theme, many things commonly have issues supporting it so I tried to change theme setting by hitting ctrl + space and then typing "cerebro settings" to access settings. I then say artifacts in the black screen. I tried clicking all around the black background and eventually clicked on the theme selection box when the dialog normalized as expected and I was able to use the app.
In short, for anyone with this problem or something similar:
Hit Ctrl + space, type cerebro settings, and then keep clicking around in the black dialog as the menu elements are there, just not depicted properly.
Pop OS 20.10 and installed 4.0 of cerebro as instructed in the source readme:
Install
First, clone the repo via git:
$ git clone https://github.com/KELiON/cerebro.git cerebro
And then install dependencies:
$ cd cerebro && yarn && cd ./app && yarn && cd ../
Run
$ yarn run dev

Same here on ubuntu 20.04
but if change the global theme i can use normally

app/main/css/global.css
change line 9 from background-color: var(--main-background-color); to background-color: #fff;

I believe that this issue could be closed when the program start automatically defining a default theme (black or white) in ~ / .config / Cerebro / config.json

we have a problem setting our default theme today.
This problem can be quickly resolved by removing the .config/ Cerebro/ folder and generating another one.
But we need help to remove this bug once and for all


text:
Add in repository quality measures.

Added TravisCI configuration
Added CodeClimate Badge

FYI, saw this in the travis build
npm WARN package.json canadarm@1.0.0 No license field.

Code Climate will only work after it is merged to master. At least from what I can see.

:+1:

@sambao21  If you're good with this I'm going to merge it in the next few days.

:+1:

authors: garrypolley gneatgeek sambao21

repo: cerner/canadarm


text:
[axe-core warning] - Ensure aria-hidden elements do not contain focusable elements

Feature Request
axe-core is logging an error on the following markup:

Description

WDIO Axe Error Report
44) DataGrid - huge with row selection hover is accessible:
expected no accessibility violations but got:
        {
  "description": "Ensures aria-hidden elements do not contain focusable elements",
  "help": "ARIA hidden element must not contain focusable elements",
  "helpUrl": "https://dequeuniversity.com/rules/axe/3.2/aria-hidden-focus?application=axeAPI",
  "id": "aria-hidden-focus",
  "impact": "serious",
  "nodes": [
    {
      "all": [
        {
          "data": null,
          "id": "focusable-not-tabbable",
          "impact": "serious",
          "message": "Focusable content should have tabindex='-1' or be removed from the DOM",
          "relatedNodes": [
            {
              "html": "

",
              "target": [
                ".DataGrid-module__leading-focus-anchor___awyB2"
              ]
            }
          ]
        }
      ],
      "any": [],
      "failureSummary": "Fix all of the following:\n  Focusable content should have tabindex='-1' or be removed from the DOM",
      "html": "

",
      "impact": "serious",
      "none": [],
      "target": [
        ".DataGrid-module__leading-focus-anchor___awyB2"
      ]
    },
    {
      "all": [
        {
          "data": null,
          "id": "focusable-not-tabbable",
          "impact": "serious",
          "message": "Focusable content should have tabindex='-1' or be removed from the DOM",
          "relatedNodes": [
            {
              "html": "

",
              "target": [
                ".DataGrid-module__terminal-focus-anchor___3qmTk"
              ]
            }
          ]
        }
      ],
      "any": [],
      "failureSummary": "Fix all of the following:\n  Focusable content should have tabindex='-1' or be removed from the DOM",
      "html": "

",
      "impact": "serious",
      "none": [],
      "target": [
        ".DataGrid-module__terminal-focus-anchor___3qmTk"
      ]
    }
  ],
  "tags": [
    "cat.name-role-value",
    "wcag2a",
    "wcag412"
  ]
}
running chrome
AssertionError: expected no accessibility violations but got:
        {
  "description": "Ensures aria-hidden elements do not contain focusable elements",
  "help": "ARIA hidden element must not contain focusable elements",
  "helpUrl": "https://dequeuniversity.com/rules/axe/3.2/aria-hidden-focus?application=axeAPI",
  "id": "aria-hidden-focus",
  "impact": "serious",
  "nodes": [
    {
      "all": [
        {
          "data": null,
          "id": "focusable-not-tabbable",
          "impact": "serious",
          "message": "Focusable content should have tabindex='-1' or be removed from the DOM",
          "relatedNodes": [
            {
              "html": "

",
              "target": [
                ".DataGrid-module__leading-focus-anchor___awyB2"
              ]
            }
          ]
        }
      ],
      "any": [],
      "failureSummary": "Fix all of the following:\n  Focusable content should have tabindex='-1' or be removed from the DOM",
      "html": "

",
      "impact": "serious",
      "none": [],
      "target": [
        ".DataGrid-module__leading-focus-anchor___awyB2"
      ]
    },
    {
      "all": [
        {
          "data": null,
          "id": "focusable-not-tabbable",
          "impact": "serious",
          "message": "Focusable content should have tabindex='-1' or be removed from the DOM",
          "relatedNodes": [
            {
              "html": "

",
              "target": [
                ".DataGrid-module__terminal-focus-anchor___3qmTk"
              ]
            }
          ]
        }
      ],
      "any": [],
      "failureSummary": "Fix all of the following:\n  Focusable content should have tabindex='-1' or be removed from the DOM",
      "html": "

",
      "impact": "serious",
      "none": [],
      "target": [
        ".DataGrid-module__terminal-focus-anchor___3qmTk"
      ]
    }
  ],
  "tags": [
    "cat.name-role-value",
    "wcag2a",
    "wcag412"
  ]
}
    at Context.<anonymous> (/Users/bj031910/repos/terra-clinical/node_modules/terra-toolkit/lib/wdio/services/TerraCommands/accessiblity.js:13:54)
    at new Promise (<anonymous>)
    at new F (/Users/bj031910/repos/terra-clinical/node_modules/core-js/library/modules/_export.js:36:28)

45) DataGrid - huge with selected row hover is accessible:
expected no accessibility violations but got:
        {
  "description": "Ensures aria-hidden elements do not contain focusable elements",
  "help": "ARIA hidden element must not contain focusable elements",
  "helpUrl": "https://dequeuniversity.com/rules/axe/3.2/aria-hidden-focus?application=axeAPI",
  "id": "aria-hidden-focus",
  "impact": "serious",
  "nodes": [
    {
      "all": [
        {
          "data": null,
          "id": "focusable-not-tabbable",
          "impact": "serious",
          "message": "Focusable content should have tabindex='-1' or be removed from the DOM",
          "relatedNodes": [
            {
              "html": "

",
              "target": [
                ".DataGrid-module__leading-focus-anchor___awyB2"
              ]
            }
          ]
        }
      ],
      "any": [],
      "failureSummary": "Fix all of the following:\n  Focusable content should have tabindex='-1' or be removed from the DOM",
      "html": "

",
      "impact": "serious",
      "none": [],
      "target": [
        ".DataGrid-module__leading-focus-anchor___awyB2"
      ]
    },
    {
      "all": [
        {
          "data": null,
          "id": "focusable-not-tabbable",
          "impact": "serious",
          "message": "Focusable content should have tabindex='-1' or be removed from the DOM",
          "relatedNodes": [
            {
              "html": "

",
              "target": [
                ".DataGrid-module__terminal-focus-anchor___3qmTk"
              ]
            }
          ]
        }
      ],
      "any": [],
      "failureSummary": "Fix all of the following:\n  Focusable content should have tabindex='-1' or be removed from the DOM",
      "html": "

",
      "impact": "serious",
      "none": [],
      "target": [
        ".DataGrid-module__terminal-focus-anchor___3qmTk"
      ]
    }
  ],
  "tags": [
    "cat.name-role-value",
    "wcag2a",
    "wcag412"
  ]
}
running chrome
AssertionError: expected no accessibility violations but got:
        {
  "description": "Ensures aria-hidden elements do not contain focusable elements",
  "help": "ARIA hidden element must not contain focusable elements",
  "helpUrl": "https://dequeuniversity.com/rules/axe/3.2/aria-hidden-focus?application=axeAPI",
  "id": "aria-hidden-focus",
  "impact": "serious",
  "nodes": [
    {
      "all": [
        {
          "data": null,
          "id": "focusable-not-tabbable",
          "impact": "serious",
          "message": "Focusable content should have tabindex='-1' or be removed from the DOM",
          "relatedNodes": [
            {
              "html": "

",
              "target": [
                ".DataGrid-module__leading-focus-anchor___awyB2"
              ]
            }
          ]
        }
      ],
      "any": [],
      "failureSummary": "Fix all of the following:\n  Focusable content should have tabindex='-1' or be removed from the DOM",
      "html": "

",
      "impact": "serious",
      "none": [],
      "target": [
        ".DataGrid-module__leading-focus-anchor___awyB2"
      ]
    },
    {
      "all": [
        {
          "data": null,
          "id": "focusable-not-tabbable",
          "impact": "serious",
          "message": "Focusable content should have tabindex='-1' or be removed from the DOM",
          "relatedNodes": [
            {
              "html": "

",
              "target": [
                ".DataGrid-module__terminal-focus-anchor___3qmTk"
              ]
            }
          ]
        }
      ],
      "any": [],
      "failureSummary": "Fix all of the following:\n  Focusable content should have tabindex='-1' or be removed from the DOM",
      "html": "

",
      "impact": "serious",
      "none": [],
      "target": [
        ".DataGrid-module__terminal-focus-anchor___3qmTk"
      ]
    }
  ],
  "tags": [
    "cat.name-role-value",
    "wcag2a",
    "wcag412"
  ]
}
    at Context.<anonymous> (/Users/bj031910/repos/terra-clinical/node_modules/terra-toolkit/lib/wdio/services/TerraCommands/accessiblity.js:13:54)
    at new Promise (<anonymous>)
    at new F (/Users/bj031910/repos/terra-clinical/node_modules/core-js/library/modules/_export.js:36:28)

46) DataGrid - huge with column header selections is accessible:
expected no accessibility violations but got:
        {
  "description": "Ensures aria-hidden elements do not contain focusable elements",
  "help": "ARIA hidden element must not contain focusable elements",
  "helpUrl": "https://dequeuniversity.com/rules/axe/3.2/aria-hidden-focus?application=axeAPI",
  "id": "aria-hidden-focus",
  "impact": "serious",
  "nodes": [
    {
      "all": [
        {
          "data": null,
          "id": "focusable-not-tabbable",
          "impact": "serious",
          "message": "Focusable content should have tabindex='-1' or be removed from the DOM",
          "relatedNodes": [
            {
              "html": "

",
              "target": [
                ".DataGrid-module__leading-focus-anchor___awyB2"
              ]
            }
          ]
        }
      ],
      "any": [],
      "failureSummary": "Fix all of the following:\n  Focusable content should have tabindex='-1' or be removed from the DOM",
      "html": "

",
      "impact": "serious",
      "none": [],
      "target": [
        ".DataGrid-module__leading-focus-anchor___awyB2"
      ]
    },
    {
      "all": [
        {
          "data": null,
          "id": "focusable-not-tabbable",
          "impact": "serious",
          "message": "Focusable content should have tabindex='-1' or be removed from the DOM",
          "relatedNodes": [
            {
              "html": "

",
              "target": [
                ".DataGrid-module__terminal-focus-anchor___3qmTk"
              ]
            }
          ]
        }
      ],
      "any": [],
      "failureSummary": "Fix all of the following:\n  Focusable content should have tabindex='-1' or be removed from the DOM",
      "html": "

",
      "impact": "serious",
      "none": [],
      "target": [
        ".DataGrid-module__terminal-focus-anchor___3qmTk"
      ]
    }
  ],
  "tags": [
    "cat.name-role-value",
    "wcag2a",
    "wcag412"
  ]
}
running chrome
AssertionError: expected no accessibility violations but got:
        {
  "description": "Ensures aria-hidden elements do not contain focusable elements",
  "help": "ARIA hidden element must not contain focusable elements",
  "helpUrl": "https://dequeuniversity.com/rules/axe/3.2/aria-hidden-focus?application=axeAPI",
  "id": "aria-hidden-focus",
  "impact": "serious",
  "nodes": [
    {
      "all": [
        {
          "data": null,
          "id": "focusable-not-tabbable",
          "impact": "serious",
          "message": "Focusable content should have tabindex='-1' or be removed from the DOM",
          "relatedNodes": [
            {
              "html": "

",
              "target": [
                ".DataGrid-module__leading-focus-anchor___awyB2"
              ]
            }
          ]
        }
      ],
      "any": [],
      "failureSummary": "Fix all of the following:\n  Focusable content should have tabindex='-1' or be removed from the DOM",
      "html": "

",
      "impact": "serious",
      "none": [],
      "target": [
        ".DataGrid-module__leading-focus-anchor___awyB2"
      ]
    },
    {
      "all": [
        {
          "data": null,
          "id": "focusable-not-tabbable",
          "impact": "serious",
          "message": "Focusable content should have tabindex='-1' or be removed from the DOM",
          "relatedNodes": [
            {
              "html": "

",
              "target": [
                ".DataGrid-module__terminal-focus-anchor___3qmTk"
              ]
            }
          ]
        }
      ],
      "any": [],
      "failureSummary": "Fix all of the following:\n  Focusable content should have tabindex='-1' or be removed from the DOM",
      "html": "

",
      "impact": "serious",
      "none": [],
      "target": [
        ".DataGrid-module__terminal-focus-anchor___3qmTk"
      ]
    }
  ],
  "tags": [
    "cat.name-role-value",
    "wcag2a",
    "wcag412"
  ]
}
    at Context.<anonymous> (/Users/bj031910/repos/terra-clinical/node_modules/terra-toolkit/lib/wdio/services/TerraCommands/accessiblity.js:13:54)
    at new Promise (<anonymous>)
    at new F (/Users/bj031910/repos/terra-clinical/node_modules/core-js/library/modules/_export.js:36:28)

47) DataGrid - huge with subsection selections is accessible:
expected no accessibility violations but got:
        {
  "description": "Ensures aria-hidden elements do not contain focusable elements",
  "help": "ARIA hidden element must not contain focusable elements",
  "helpUrl": "https://dequeuniversity.com/rules/axe/3.2/aria-hidden-focus?application=axeAPI",
  "id": "aria-hidden-focus",
  "impact": "serious",
  "nodes": [
    {
      "all": [
        {
          "data": null,
          "id": "focusable-not-tabbable",
          "impact": "serious",
          "message": "Focusable content should have tabindex='-1' or be removed from the DOM",
          "relatedNodes": [
            {
              "html": "

",
              "target": [
                ".DataGrid-module__leading-focus-anchor___awyB2"
              ]
            }
          ]
        }
      ],
      "any": [],
      "failureSummary": "Fix all of the following:\n  Focusable content should have tabindex='-1' or be removed from the DOM",
      "html": "

",
      "impact": "serious",
      "none": [],
      "target": [
        ".DataGrid-module__leading-focus-anchor___awyB2"
      ]
    },
    {
      "all": [
        {
          "data": null,
          "id": "focusable-not-tabbable",
          "impact": "serious",
          "message": "Focusable content should have tabindex='-1' or be removed from the DOM",
          "relatedNodes": [
            {
              "html": "

",
              "target": [
                ".DataGrid-module__terminal-focus-anchor___3qmTk"
              ]
            }
          ]
        }
      ],
      "any": [],
      "failureSummary": "Fix all of the following:\n  Focusable content should have tabindex='-1' or be removed from the DOM",
      "html": "

",
      "impact": "serious",
      "none": [],
      "target": [
        ".DataGrid-module__terminal-focus-anchor___3qmTk"
      ]
    }
  ],
  "tags": [
    "cat.name-role-value",
    "wcag2a",
    "wcag412"
  ]
}
running chrome
AssertionError: expected no accessibility violations but got:
        {
  "description": "Ensures aria-hidden elements do not contain focusable elements",
  "help": "ARIA hidden element must not contain focusable elements",
  "helpUrl": "https://dequeuniversity.com/rules/axe/3.2/aria-hidden-focus?application=axeAPI",
  "id": "aria-hidden-focus",
  "impact": "serious",
  "nodes": [
    {
      "all": [
        {
          "data": null,
          "id": "focusable-not-tabbable",
          "impact": "serious",
          "message": "Focusable content should have tabindex='-1' or be removed from the DOM",
          "relatedNodes": [
            {
              "html": "

",
              "target": [
                ".DataGrid-module__leading-focus-anchor___awyB2"
              ]
            }
          ]
        }
      ],
      "any": [],
      "failureSummary": "Fix all of the following:\n  Focusable content should have tabindex='-1' or be removed from the DOM",
      "html": "

",
      "impact": "serious",
      "none": [],
      "target": [
        ".DataGrid-module__leading-focus-anchor___awyB2"
      ]
    },
    {
      "all": [
        {
          "data": null,
          "id": "focusable-not-tabbable",
          "impact": "serious",
          "message": "Focusable content should have tabindex='-1' or be removed from the DOM",
          "relatedNodes": [
            {
              "html": "

",
              "target": [
                ".DataGrid-module__terminal-focus-anchor___3qmTk"
              ]
            }
          ]
        }
      ],
      "any": [],
      "failureSummary": "Fix all of the following:\n  Focusable content should have tabindex='-1' or be removed from the DOM",
      "html": "

",
      "impact": "serious",
      "none": [],
      "target": [
        ".DataGrid-module__terminal-focus-anchor___3qmTk"
      ]
    }
  ],
  "tags": [
    "cat.name-role-value",
    "wcag2a",
    "wcag412"
  ]
}
    at Context.<anonymous> (/Users/bj031910/repos/terra-clinical/node_modules/terra-toolkit/lib/wdio/services/TerraCommands/accessiblity.js:13:54)
    at new Promise (<anonymous>)
    at new F (/Users/bj031910/repos/terra-clinical/node_modules/core-js/library/modules/_export.js:36:28)

48) DataGrid - huge with subsection selection hover is accessible:
expected no accessibility violations but got:
        {
  "description": "Ensures aria-hidden elements do not contain focusable elements",
  "help": "ARIA hidden element must not contain focusable elements",
  "helpUrl": "https://dequeuniversity.com/rules/axe/3.2/aria-hidden-focus?application=axeAPI",
  "id": "aria-hidden-focus",
  "impact": "serious",
  "nodes": [
    {
      "all": [
        {
          "data": null,
          "id": "focusable-not-tabbable",
          "impact": "serious",
          "message": "Focusable content should have tabindex='-1' or be removed from the DOM",
          "relatedNodes": [
            {
              "html": "

",
              "target": [
                ".DataGrid-module__leading-focus-anchor___awyB2"
              ]
            }
          ]
        }
      ],
      "any": [],
      "failureSummary": "Fix all of the following:\n  Focusable content should have tabindex='-1' or be removed from the DOM",
      "html": "

",
      "impact": "serious",
      "none": [],
      "target": [
        ".DataGrid-module__leading-focus-anchor___awyB2"
      ]
    },
    {
      "all": [
        {
          "data": null,
          "id": "focusable-not-tabbable",
          "impact": "serious",
          "message": "Focusable content should have tabindex='-1' or be removed from the DOM",
          "relatedNodes": [
            {
              "html": "

",
              "target": [
                ".DataGrid-module__terminal-focus-anchor___3qmTk"
              ]
            }
          ]
        }
      ],
      "any": [],
      "failureSummary": "Fix all of the following:\n  Focusable content should have tabindex='-1' or be removed from the DOM",
      "html": "

",
      "impact": "serious",
      "none": [],
      "target": [
        ".DataGrid-module__terminal-focus-anchor___3qmTk"
      ]
    }
  ],
  "tags": [
    "cat.name-role-value",
    "wcag2a",
    "wcag412"
  ]
}
running chrome
AssertionError: expected no accessibility violations but got:
        {
  "description": "Ensures aria-hidden elements do not contain focusable elements",
  "help": "ARIA hidden element must not contain focusable elements",
  "helpUrl": "https://dequeuniversity.com/rules/axe/3.2/aria-hidden-focus?application=axeAPI",
  "id": "aria-hidden-focus",
  "impact": "serious",
  "nodes": [
    {
      "all": [
        {
          "data": null,
          "id": "focusable-not-tabbable",
          "impact": "serious",
          "message": "Focusable content should have tabindex='-1' or be removed from the DOM",
          "relatedNodes": [
            {
              "html": "

",
              "target": [
                ".DataGrid-module__leading-focus-anchor___awyB2"
              ]
            }
          ]
        }
      ],
      "any": [],
      "failureSummary": "Fix all of the following:\n  Focusable content should have tabindex='-1' or be removed from the DOM",
      "html": "

",
      "impact": "serious",
      "none": [],
      "target": [
        ".DataGrid-module__leading-focus-anchor___awyB2"
      ]
    },
    {
      "all": [
        {
          "data": null,
          "id": "focusable-not-tabbable",
          "impact": "serious",
          "message": "Focusable content should have tabindex='-1' or be removed from the DOM",
          "relatedNodes": [
            {
              "html": "

",
              "target": [
                ".DataGrid-module__terminal-focus-anchor___3qmTk"
              ]
            }
          ]
        }
      ],
      "any": [],
      "failureSummary": "Fix all of the following:\n  Focusable content should have tabindex='-1' or be removed from the DOM",
      "html": "

",
      "impact": "serious",
      "none": [],
      "target": [
        ".DataGrid-module__terminal-focus-anchor___3qmTk"
      ]
    }
  ],
  "tags": [
    "cat.name-role-value",
    "wcag2a",
    "wcag412"
  ]
}
    at Context.<anonymous> (/Users/bj031910/repos/terra-clinical/node_modules/terra-toolkit/lib/wdio/services/TerraCommands/accessiblity.js:13:54)
    at new Promise (<anonymous>)
    at new F (/Users/bj031910/repos/terra-clinical/node_modules/core-js/library/modules/_export.js:36:28)

49) DataGrid - huge with paging is accessible:
expected no accessibility violations but got:
        {
  "description": "Ensures aria-hidden elements do not contain focusable elements",
  "help": "ARIA hidden element must not contain focusable elements",
  "helpUrl": "https://dequeuniversity.com/rules/axe/3.2/aria-hidden-focus?application=axeAPI",
  "id": "aria-hidden-focus",
  "impact": "serious",
  "nodes": [
    {
      "all": [
        {
          "data": null,
          "id": "focusable-not-tabbable",
          "impact": "serious",
          "message": "Focusable content should have tabindex='-1' or be removed from the DOM",
          "relatedNodes": [
            {
              "html": "

",
              "target": [
                ".DataGrid-module__leading-focus-anchor___awyB2"
              ]
            }
          ]
        }
      ],
      "any": [],
      "failureSummary": "Fix all of the following:\n  Focusable content should have tabindex='-1' or be removed from the DOM",
      "html": "

",
      "impact": "serious",
      "none": [],
      "target": [
        ".DataGrid-module__leading-focus-anchor___awyB2"
      ]
    },
    {
      "all": [
        {
          "data": null,
          "id": "focusable-not-tabbable",
          "impact": "serious",
          "message": "Focusable content should have tabindex='-1' or be removed from the DOM",
          "relatedNodes": [
            {
              "html": "

",
              "target": [
                ".DataGrid-module__terminal-focus-anchor___3qmTk"
              ]
            }
          ]
        }
      ],
      "any": [],
      "failureSummary": "Fix all of the following:\n  Focusable content should have tabindex='-1' or be removed from the DOM",
      "html": "

",
      "impact": "serious",
      "none": [],
      "target": [
        ".DataGrid-module__terminal-focus-anchor___3qmTk"
      ]
    }
  ],
  "tags": [
    "cat.name-role-value",
    "wcag2a",
    "wcag412"
  ]
}
running chrome
AssertionError: expected no accessibility violations but got:
        {
  "description": "Ensures aria-hidden elements do not contain focusable elements",
  "help": "ARIA hidden element must not contain focusable elements",
  "helpUrl": "https://dequeuniversity.com/rules/axe/3.2/aria-hidden-focus?application=axeAPI",
  "id": "aria-hidden-focus",
  "impact": "serious",
  "nodes": [
    {
      "all": [
        {
          "data": null,
          "id": "focusable-not-tabbable",
          "impact": "serious",
          "message": "Focusable content should have tabindex='-1' or be removed from the DOM",
          "relatedNodes": [
            {
              "html": "

",
              "target": [
                ".DataGrid-module__leading-focus-anchor___awyB2"
              ]
            }
          ]
        }
      ],
      "any": [],
      "failureSummary": "Fix all of the following:\n  Focusable content should have tabindex='-1' or be removed from the DOM",
      "html": "

",
      "impact": "serious",
      "none": [],
      "target": [
        ".DataGrid-module__leading-focus-anchor___awyB2"
      ]
    },
    {
      "all": [
        {
          "data": null,
          "id": "focusable-not-tabbable",
          "impact": "serious",
          "message": "Focusable content should have tabindex='-1' or be removed from the DOM",
          "relatedNodes": [
            {
              "html": "

",
              "target": [
                ".DataGrid-module__terminal-focus-anchor___3qmTk"
              ]
            }
          ]
        }
      ],
      "any": [],
      "failureSummary": "Fix all of the following:\n  Focusable content should have tabindex='-1' or be removed from the DOM",
      "html": "

",
      "impact": "serious",
      "none": [],
      "target": [
        ".DataGrid-module__terminal-focus-anchor___3qmTk"
      ]
    }
  ],
  "tags": [
    "cat.name-role-value",
    "wcag2a",
    "wcag412"
  ]
}
    at Context.<anonymous> (/Users/bj031910/repos/terra-clinical/node_modules/terra-toolkit/lib/wdio/services/TerraCommands/accessiblity.js:13:54)
    at new Promise (<anonymous>)
    at new F (/Users/bj031910/repos/terra-clinical/node_modules/core-js/library/modules/_export.js:36:28)

50) DataGrid - huge with custom row/header heights is accessible:
expected no accessibility violations but got:
        {
  "description": "Ensures aria-hidden elements do not contain focusable elements",
  "help": "ARIA hidden element must not contain focusable elements",
  "helpUrl": "https://dequeuniversity.com/rules/axe/3.2/aria-hidden-focus?application=axeAPI",
  "id": "aria-hidden-focus",
  "impact": "serious",
  "nodes": [
    {
      "all": [
        {
          "data": null,
          "id": "focusable-not-tabbable",
          "impact": "serious",
          "message": "Focusable content should have tabindex='-1' or be removed from the DOM",
          "relatedNodes": [
            {
              "html": "

",
              "target": [
                ".DataGrid-module__leading-focus-anchor___awyB2"
              ]
            }
          ]
        }
      ],
      "any": [],
      "failureSummary": "Fix all of the following:\n  Focusable content should have tabindex='-1' or be removed from the DOM",
      "html": "

",
      "impact": "serious",
      "none": [],
      "target": [
        ".DataGrid-module__leading-focus-anchor___awyB2"
      ]
    },
    {
      "all": [
        {
          "data": null,
          "id": "focusable-not-tabbable",
          "impact": "serious",
          "message": "Focusable content should have tabindex='-1' or be removed from the DOM",
          "relatedNodes": [
            {
              "html": "

",
              "target": [
                ".DataGrid-module__terminal-focus-anchor___3qmTk"
              ]
            }
          ]
        }
      ],
      "any": [],
      "failureSummary": "Fix all of the following:\n  Focusable content should have tabindex='-1' or be removed from the DOM",
      "html": "

",
      "impact": "serious",
      "none": [],
      "target": [
        ".DataGrid-module__terminal-focus-anchor___3qmTk"
      ]
    }
  ],
  "tags": [
    "cat.name-role-value",
    "wcag2a",
    "wcag412"
  ]
}
running chrome
AssertionError: expected no accessibility violations but got:
        {
  "description": "Ensures aria-hidden elements do not contain focusable elements",
  "help": "ARIA hidden element must not contain focusable elements",
  "helpUrl": "https://dequeuniversity.com/rules/axe/3.2/aria-hidden-focus?application=axeAPI",
  "id": "aria-hidden-focus",
  "impact": "serious",
  "nodes": [
    {
      "all": [
        {
          "data": null,
          "id": "focusable-not-tabbable",
          "impact": "serious",
          "message": "Focusable content should have tabindex='-1' or be removed from the DOM",
          "relatedNodes": [
            {
              "html": "

",
              "target": [
                ".DataGrid-module__leading-focus-anchor___awyB2"
              ]
            }
          ]
        }
      ],
      "any": [],
      "failureSummary": "Fix all of the following:\n  Focusable content should have tabindex='-1' or be removed from the DOM",
      "html": "

",
      "impact": "serious",
      "none": [],
      "target": [
        ".DataGrid-module__leading-focus-anchor___awyB2"
      ]
    },
    {
      "all": [
        {
          "data": null,
          "id": "focusable-not-tabbable",
          "impact": "serious",
          "message": "Focusable content should have tabindex='-1' or be removed from the DOM",
          "relatedNodes": [
            {
              "html": "

",
              "target": [
                ".DataGrid-module__terminal-focus-anchor___3qmTk"
              ]
            }
          ]
        }
      ],
      "any": [],
      "failureSummary": "Fix all of the following:\n  Focusable content should have tabindex='-1' or be removed from the DOM",
      "html": "

",
      "impact": "serious",
      "none": [],
      "target": [
        ".DataGrid-module__terminal-focus-anchor___3qmTk"
      ]
    }
  ],
  "tags": [
    "cat.name-role-value",
    "wcag2a",
    "wcag412"
  ]
}
    at Context.<anonymous> (/Users/bj031910/repos/terra-clinical/node_modules/terra-toolkit/lib/wdio/services/TerraCommands/accessiblity.js:13:54)
    at new Promise (<anonymous>)
    at new F (/Users/bj031910/repos/terra-clinical/node_modules/core-js/library/modules/_export.js:36:28)

@bjankord Should we close the issue? As I think the issue was solved in this PR https://github.com/cerner/terra-clinical/pull/522/files.

Yes, this can be closed.

repo: cerner/terra-clinical