text:
Validate session with flint datasource passed in async job request

Description
Currently, if there's a session running with Datasource1 and the user makes a request to the async API with the same session but a different catalog Datasource2 then SQL plugin doesn't return a new session for Datasource2. This PR creates a new session when there’s a mismatch between datasource and session_id.
Testing done:

manual testing
added IT.

Issues Resolved
https://github.com/opensearch-project/sql/issues/2432
Check List

[X] New functionality includes testing.

[X] All tests pass, including unit test, integration test and doctest

[X] New functionality has been documented.

[X] New functionality has javadoc added
[X] New functionality has user manual doc added

[X] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

please update settings doc. https://github.com/opensearch-project/sql/blob/main/docs/user/admin/settings.rst

please update settings doc. https://github.com/opensearch-project/sql/blob/main/docs/user/admin/settings.rst

updated

authors: kaituo penghuo


text:
basic notes from 2016-11-15 meeting

courtesy of @duglin. not sure if these all require action, but I put them into a checklist

[ ] action: @duglin to remove non-spec stuff from repo
[ ] topic: spec in our repo vs cf repo
[ ] proposal: generate HTML docs from our repo’s src (md).  Platforms can then decide whether to point to our HTML or to pull it into their docs
[ ] proposal: convert existing CF docs into single page format ; move that single page to our repo ; CF then issues PRs against our repo instead of CF’s for v2.11 changes.
[ ] action: shannon/CF-folks to see how to get the single page format in CF and remove CF-isms.

https://github.com/cloudfoundry/docs-services  this is the current source of truth

@duglin you may as well close all the issues related to k8s in this repo. Thanks!

@angarg12 I think I got 'em - let me know if I missed any

@MHBauer @duglin I think this can be closed?

ye closing

source: gharchive/issue

authors: MHBauer angarg12 duglin shalako

repo: openservicebrokerapi/servicebroker

license_type: permissive

license_source: bigquery


text:
OpenShift Nightly Job Failing

Bug description: OpenShift nightly job has been failing the e2e_statesfulsets_test.
Affected area (please mark with X where applicable):

Install                    [ ]
SMI Traffic Access Policy  [ ]
SMI Traffic Specs Policy   [ ]
SMI Traffic Split Policy   [ ]
Permissive Traffic Policy  [ ]
Ingress                    [ ]
Egress                     [ ]
Envoy Control Plane        [ ]
CLI Tool                   [ ]
Metrics                    [ ]
Certificate Management     [ ]
Sidecar Injection          [ ]
Logging                    [ ]
Debugging                  [ ]
Tests                      [X]
Demo                       [ ]
CI System                  [X]

Expected behavior: OpenShift nightly job should pass all e2es.
Steps to reproduce the bug (as precisely as possible):
How was OSM installed?:
Anything else we need to know?:
Bug report archive:

Environment:

OSM version (use osm version):
Kubernetes version (use kubectl version):
Size of cluster (number of worker nodes in the cluster):
Others:

OpenShift nightly job is now failing the e2e_certmanager test, need to debug.

Seems to be an intermittent issue due to: https://cert-manager.io/docs/concepts/webhook/#webhook-connection-problems-shortly-after-cert-manager-installation

repo: openservicemesh/osm

license_source: github-api


text:
Bug 2086921: Controller metrics not exposed/collected properly...

Prometheus ServiceMonitor CR has been enabled by default

/bugzilla refresh

/cc jche

/cc jc-rh

/lgtm

/cc @nishant-parekh @donpenney

/cancel lgtm

Running make bundle with this change modified the bundle docker file:
- LABEL operators.operatorframework.io.metrics.builder=operator-sdk-v1.16.0-ocp
+ LABEL operators.operatorframework.io.metrics.builder=operator-sdk-v1.10.1-ocp

@jc-rh I think most likely you have a stale bin/operator-sdk in your repo. The rule in the Makefile downloads the 1.16.0 version, but it only does an existence check. If you have an operator-sdk previously downloaded (4.10 branch had 1.10 version), it will satisfy the Makefile rule and you'll see what you're seeing. Delete the file and run "make operator-sdk" again, and you should see this resolved, I think

@jc-rh I think most likely you have a stale bin/operator-sdk in your repo. The rule in the Makefile downloads the 1.16.0 version, but it only does an existence check. If you have an operator-sdk previously downloaded (4.10 branch had 1.10 version), it will satisfy the Makefile rule and you'll see what you're seeing. Delete the file and run "make operator-sdk" again, and you should see this resolved, I think

Thanks. I just realized that.

@rauhersu Please run make bundle and check in the generated changes.

@rauhersu Please run make bundle and check in the generated changes.

$ make bundle
/home/rauherna/gorepo/cluster-group-upgrades-operator/bin/controller-gen "crd:trivialVersions=true,preserveUnknownFields=false" rbac:roleName=manager-role webhook paths="./..." output:crd:ar\
tifacts:config=config/crd/bases
/home/rauherna/gorepo/cluster-group-upgrades-operator/bin/operator-sdk generate kustomize manifests -q
cd config/manager && /home/rauherna/gorepo/cluster-group-upgrades-operator/bin/kustomize edit set image controller=quay.io/openshift-kni/cluster-group-upgrades-operator:4.11.0 && PRECACHE_IMG=quay.io/openshift-kni/cluster-group-upgrades-operator-precache:4.11.0 RECOVERY_IMG=quay.io/openshift-kni/cluster-group-upgrades-operator-recovery:4.11.0 envsubst < related-images/in.yaml >related-images/patch.yaml
/home/rauherna/gorepo/cluster-group-upgrades-operator/bin/kustomize build config/manifests | /home/rauherna/gorepo/cluster-group-upgrades-operator/bin/operator-sdk generate bundle -q --overw\
rite --version 4.11.0
INFO[0000] Creating bundle.Dockerfile
INFO[0000] Creating bundle/metadata/annotations.yaml
INFO[0000] Bundle metadata generated suceessfully
/home/rauherna/gorepo/cluster-group-upgrades-operator/bin/operator-sdk bundle validate ./bundle
INFO[0000] All validation tests have completed successfully

The ServiceMonitor CR is now included under:
bundle/manifests/cluster-group-upgrades-controller-manager-metrics-monitor_monitoring.coreos.com_v1_servicemonitor.yaml

/retest

/retest-required

/approve

/assign @donpenney

pinging @jc-rh @donpenney  for lgtm label

/backport 4.10

/backport release-4.10

source: gharchive/pull-request

authors: donpenney jc-rh rauhersu


text:
Update piplines-service or Pipelines-Service or Pipelines Service to 'Pipeline Service'

https://github.com/openshift-pipelines/pipelines-service/issues/133
https://issues.redhat.com/browse/PLNSRVCE-543
https://gitlab.cee.redhat.com/plnsvc/gitops/kcp-stable/-/merge_requests/14
Will update the name of the repo soon after this PR is merged.

Hi @bnallapeta, you forgot to link the issue 😅 (missed the closing keyword before issue number), the PR has been merged but the issue is still open.

Hi @bnallapeta, you forgot to link the issue sweat_smile (missed the closing keyword before issue number), the PR has been merged but the issue is still open.

Thanks @avinal. Have closed the Github issue and Jira associated with it.

authors: avinal bnallapeta

repo: openshift-pipelines/pipeline-service


text:
Add ability to test and wait for NFD-labelled GPU nodes

This PR improves the detection of GPU nodes in the cluster:
instead of relying on AWS Machines and types to detect the presence of GPU nodes, use NFD to ...

test if a GPU node is available (see NVIDIA GPU labels there)
if not available, scale-up the cluster with AWS MachineSet
wait for the GPU node to show up

this PR implements steps 1 and 3.
Incidentally, the PR also removes the strong dependency on AWS infrastructure, which is now only required when no GPU node is available at the beginning of the execution.

/test gpu-operator-e2e

/unhold

/hold cancel

repo: openshift-psap/ci-artifacts


text:
[CNF-5643] add capability name to machine crd

In order to merge https://github.com/openshift/machine-api-operator/pull/1119 I need to add capability annotations to api files because they are directly copied at machine-api-operator

You need to also include the ControlPlaneMachineSet CRD in this right?

The integration tests timeout is at it's limit, it needs to be bumped

/lgtm

authors: JoelSpeed qJkee

repo: openshift/api


text:
pkg/securitycontextconstraints/sccadmission: simplify retrieving SCCs

This is scavanging a small portion of https://github.com/openshift/apiserver-library-go/pull/107 where FindApplicableSCCs is invoked with the requested namespace but without a user. Hence, the current logic returns all SCCs. This indirection makes the current code hard to read.
This PR suggests to simplify it and list all SCCs instead which is the same logic.
/cc @stlaz

/hold

holding for final review

/lgtm

/hold cancel

authors: liouk s-urbaniak stlaz

repo: openshift/apiserver-library-go


text:
[WIP] Update with local library-go vendoring to test

Testing PR with local library-go installer changes to wire in APIServerInternalURL

/payload-job periodic-ci-openshift-release-master-ci-4.13-upgrade-from-stable-4.12-e2e-gcp-ovn-upgrade

/test e2e-gcp-operator

/retest-required

/test gcp-ovn

/payload-job periodic-ci-openshift-release-master-ci-4.13-e2e-gcp-ovn

/retest-required


text:
speed up leader election

this helps with upgrade timing because save one minute on the lease.

infra
/retest


text:
Remove route from deploy template

Route creation should be handled in the app-interface namespace file,
rather than the deploy template.
Signed-off-by: Chris Collins collins.christopher@gmail.com

/lgtm

authors: clcollins iamkirkbater

repo: openshift/compliance-audit-router


text:
Set resource limits to all containers

Add resource requests and limits to all containers.
Infered some sensible values from production metrics.
The TaskRuns only get a limit. This way the resource requests are set to the same value as the limit and we get QoS class Guaranteed. As we do not retry the TaskRuns, we should make them be evicted last.
Closes: https://issues.redhat.com/browse/OSD-22524

/hold
Had weird golang and golangci issues.
Propose we do https://github.com/openshift/configuration-anomaly-detection/pull/271 first

/hold cancel

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 39.59%. Comparing base (ddd45a3) to head (2408e3c).

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #272   +/-   ##
=======================================
  Coverage   39.59%   39.59%
=======================================
  Files          16       16
  Lines        1470     1470
=======================================
  Hits          582      582
  Misses        849      849
  Partials       39       39

authors: RaphaelBut codecov-commenter


text:
Maint: makefile better split into categories

make help

Usage:
  make <target>

Global:
  all                                                 Generate, build, lint, test all subprojects
  build                                               Build all subprojects in this repository
  lint                                                Lint all subprojects

cadctl:
  cadctl                                              Run all targets for cadctl (generate, build, test, lint, generation)
  generate-cadctl                                     Generate mocks for cadctl
  build-cadctl                                        Build the cadctl binary
  lint-cadctl                                         Lint cadctl subproject
  test-cadctl                                         Run automated tests for cadctl

Interceptor:
  interceptor                                         Run all targets for interceptor (build, test, lint)
  build-interceptor                                   Build the interceptor binary
  lint-interceptor                                    Lint interceptor subproject
  test-interceptor                                    Run automated tests for interceptor

Template-updater:
  template-updater                                    Run all targets for template-updater
  build-template-updater                              Build the template-updater binary
  lint-template-updater                               Lint template-updater subproject

Utility:
  pre-commit                                          Run pre-commit hook
  boilerplate-update                                  Update boilerplate version
  generate-template-file                              Generate deploy template file

Previously, the categories were not split and I had accidentally removed the make generate during my refactor

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 37.80%. Comparing base (041dd32) to head (87032a6).

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #295   +/-   ##
=======================================
  Coverage   37.80%   37.80%
=======================================
  Files          19       19
  Lines        1574     1574
=======================================
  Hits          595      595
  Misses        940      940
  Partials       39       39

looks aweesome :heart:

not tied to this PR: What are we thinking about the pre commit hook?
I personally do not like that I have to wait for the linter, but I do like having the diffs ( some kind of isClean ) before pushing some crap

/retest

@RaphaelBut I would love to remove that. I think it just creates extra bloat. If we have that as pre commit, why not also test and validation? It's a slippery slope :D

@RaphaelBut feel free to open a Pr after this to remove it? :)

@typeid  sure thing ;)

/lgtm

/retest

/retest

/retest

authors: RaphaelBut codecov-commenter typeid


text:
Syncset Testing PR #2

This PR reverts the functional changes of #1921 but retains the logging.  This PR is a superset of #1921 and should be merged after it, but before #1924 (which is a superset of this PR).

/retest

/retest

/lgtm

/retest

/retest

/test images

/retest

/retest

/test e2e

/test e2e

/test e2e-pool

/retest

Force merging, https://github.com/openshift/hive/pull/1924 undoes this change

authors: 2uasimojo abutcher dlom jupierce

repo: openshift/hive


text:
MachinePools/OpenStack: Fix nil pointer exception

This is not a cherry-pick of #2253 / (c6b37ee6 & f59f327d). That solution revendored installer to pick up the fix from upstream. In older branches, this would have dragged in too many dependencies, so we instead fix it "locally" with an explicit nil check.
Note also that the original fix added unit tests. We can't do that here either because the new tests rely on the OpenStack UT suite being un-broken [1], which again relied on upstream changes [2][3] we can't pull into older branches.
[1] https://github.com/openshift/hive/pull/2251
[2] https://github.com/openshift/installer/pull/8187
[3] https://github.com/openshift/installer/pull/8209
HIVE-2476

/lgtm

Thanks @suhanime!
/hold for testing

/remove-lifecycle stale
/hold cancel
/override "Red Hat Konflux / hive-mce-25-on-pull-request"
The segfault issue has been addressed; the autoscaling problem will be investigated separately (HIVE-2590).

/override ci/prow/security
#2387
/override "Red Hat Konflux / hive-mce-25-on-pull-request"

/override ci/prow/security

/cherry-pick mce-2.4


text:
OCPBUGS-20033: Make the OLMCatalogPlacement field immutable

Which issue(s) this PR fixes:
Fixes #OCPBUGS-20033

/hold
cc @relyt0925 @hasueki to validate you are ok enforcing this?

/hold cancel

/approve

/hold

Thanks! Dropped a question https://github.com/openshift/hypershift/pull/3113#discussion_r1371585856. Also have we tested this?

Thanks! Dropped a question #3113 (comment). Also have we tested this?

I though that the right place is the current one. It should be the other one? @enxebre

PR Updated @enxebre. Let me know if there is any other change pending.

/lgtm

/hold cancel

/cherry-pick release-4.14

authors: enxebre jparrill muraee

repo: openshift/hypershift


text:
Revert "HOSTEDCP-1778: Enable MultiArch flag by default"

Reverts openshift/hypershift#4272

/approve
/lgtm

/area cli

This is breaking presub on OCP component repos
/override ci/prow/e2e-aws
/override ci/prow/e2e-kubevirt-aws-ovn-reduced

/override "Red Hat Konflux / hypershift-operator-main-on-pull-request"

authors: bryan-cox muraee sjenning


text:
Add codegen-crds targets

/cc @damemi @soltysh @sttts
build on top of @damemi's https://github.com/openshift/library-go/pull/521

This looks good to me, but CI is still failing on (I think) that test where we expect an error: https://prow.svc.ci.openshift.org/view/gcs/origin-ci-test/pr-logs/pull/openshift_library-go/526/pull-ci-openshift-library-go-master-verify-alpha-build-machinery/1368#0:build-log.txt%3A435 points to this line: https://github.com/openshift/library-go/pull/526/files#diff-64b9efa1ab03ac55fe2aa1425d910d08R35

green now - fixed those false positives from older version on centos

Changes added in https://github.com/openshift/cluster-kube-apiserver-operator/pull/568 and tested manually, seems to work! Thanks for the help @tnozicka
/lgtm

/hold
one sec, verify seems touchy

authors: damemi tnozicka

repo: openshift/library-go


text:
[release-4.3] Bug 1876486: static-pod-installer: recreate installers that disappeared

The line
ret.TargetRevision = currNodeState.CurrentRevision

led to a dead-lock because the installer controller only does anything if either

all TargetRevisions are zero
or the TargetRevision value is larger than CurrentRevision.

We went into the second case and the controller dead-locked.
/assign @sttts

/retest

/lgtm
/approve

Overriding the valid-bug, because these are just the library PRs. The bumps will go the normal way.

authors: soltysh sttts


text:
MULTIARCH-5058: Implement the node affinity scoring specs in the ClusterPodPlacementConfig

Task to add the nodeAffinityScoring for ClusterPodPlacemetnConfig API specs can be updated as in the following to host a skeleton of plugins, currently implementing only the nodeAffinityScoring.
Example:
spec:
  plugins:
    nodeAffinityScoring:
        enabled: true
        platforms:
            - architecture: amd64
              # os: linux # TODO: this structure can support the os field in the future (e.g., for win containers)
              weight: 100

/assign @pkenchap

Punith and I did a walkthrough of the structs/interfaces together. Thanks, Paul

/retest

Konflux is failing because make unit  is failing with
...
# github.com/openshift/multiarch-tuning-operator/apis/multiarch/v1beta1
../../../apis/multiarch/v1beta1/zz_generated.deepcopy.go:95:13: in.Plugins.DeepCopyInto undefined (type plugins.Plugins has no field or method DeepCopyInto)
...

authors: AnnaZivkovic pkenchap prb112

repo: openshift/multiarch-tuning-operator


text:
update event watcher with regex ability

old event watcher only looked at the event 'reason'
to further be able to subcategorize events, allow passing a regex (and associated zabbix key to report the event under)

👍 #1265 in stg

repo: openshift/openshift-tools


text:
Remove Infra nodes from workers list

The following test create a deployment with number of pods equals to number of workers.
In a setup with Infra nodes this cause pods to be in pending state because Infra nodes are counted as workers.
This patch removes the Infra nodes from the workers nodes list
"[sig-installer][Suite:openshift/openstack][lb][Serial] The Openstack platform should apply lb-method on TCP Amphora LoadBalancer when a TCP svc with monitors and ETP:Local is created on Openshift"
"[sig-installer][Suite:openshift/openstack][lb][Serial] The Openstack platform should apply lb-method on UDP Amphora LoadBalancer when a UDP svc with monitors and ETP:Local is created on Openshift"

/cherry-pick release-4.17

repo: openshift/openstack-test


text:
When rotating secrets, check for IAM username without account ID suffix label at the end

As part of investigating https://issues.redhat.com/browse/OHSS-21052, we determined that osdctl was failing to rotate secrets because older clusters do not have the account ID suffix labels appended at the end of IAM usernames. This fix will have osdctl check to see if the IAM username is present without the label, and then check again with the label upon failure.

/hold

/unhold

Was this able to have been tested on a cluster in staging?

@iamkirkbater Yes, this was tested on a staging cluster for both the new naming convention (osdManagedAdmin-abcdef) and the older convention (osdManagedAdmin).

/lgtm

authors: AlexVulaj iamkirkbater

repo: openshift/osdctl


text:
Makefile: misleading example about enabling verbose mode

In Makefile there is an example of running tests in verbose mode:
# Build and run tests.
#
# Args:
#   WHAT: Directory names to test.  All *_test.go files under these
#     directories will be run.  If not specified, "everything" will be tested.
#   TESTS: Same as WHAT.
#   GOFLAGS: Extra flags to pass to 'go' when building.
#
# Example:
#   make check
#   make test
#   make check WHAT=pkg/build GOFLAGS=-v
check test: verify
        STI_COVER="-cover -covermode=atomic" STI_RACE="-race" hack/test-go.sh $(WHAT) $(TESTS)
.PHONY: check test

But when I'm trying to run command make check WHAT=pkg/tar GOFLAGS=-v it doesn't enable verbose mode and works as usual.
I suggest to: remove this comment or fix the scripts to make it work.
Known workaround: ./hack/test-go.sh pkg/tar -v

CC @soltysh

I'll take care of than along with fixing/aligning s2i Makefile to origin.

authors: php-coder soltysh

repo: openshift/source-to-image