text:
espup: Fix darwin build

Description of changes
Adds missing SystemConfiguration framework dependency.
Seems like https://github.com/NixOS/nixpkgs/pull/259754 has caused espup to stop building on x86_64-darwin (aarch64-darwin is likely broken too). This PR adds the missing dependency.
nix-build-espup-0.6.1.drv-0/source/target/x86_64-apple-darwin/release/deps/espup_audit_data.o" "-Wl,-u,_AUDITABLE_VERSION_INFO"
       >   = note: ld: framework not found SystemConfiguration
       >           clang-11: error: linker command failed with exit code 1 (use -v to see invocation)
       >
       >
       > error: could not compile `espup` (bin "espup") due to previous error
       For full logs, run 'nix log /nix/store/ic3682762zpsb8igagwp9bb822vl79nr-espup-0.6.1.drv'.

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[x] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Looks good. But I have no mac to test it.

Builds and runs just fine locally if that helps.
nixpkgs/nixos on  fix/espup-darwin-build
❯ ./result/bin/espup update
[2023-10-18T10:18:09Z INFO ] 💽  Updating Espressif Rust ecosystem
[2023-10-18T10:18:09Z INFO ] 💡  Querying GitHub API: 'https://api.github.com/repos/esp-rs/rust-build/releases/latest'
[2023-10-18T10:18:10Z INFO ] 💡  Querying GitHub API: 'https://api.github.com/repos/esp-rs/rust-build/releases'
[2023-10-18T10:18:10Z INFO ] 🔧  Checking Rust installation
[2023-10-18T10:18:13Z INFO ] 🔧  Installing RISC-V targets ('riscv32imc-unknown-none-elf' and 'riscv32imac-unknown-none-elf') for 'nightly' toolchain
[2023-10-18T10:18:13Z WARN ] ⚠   Previous installation of LLVM exists in: '/Users/jpraczyk/.rustup/toolchains/esp/xtensa-esp32-elf-clang/esp-16.0.0-20230516'. Reusing this installation
[2023-10-18T10:18:13Z WARN ] ⚠   Previous installation of GCC exists in: '/Users/jpraczyk/.rustup/toolchains/esp/xtensa-esp32-elf/esp-12.2.0_20230208'. Reusing this installation
[2023-10-18T10:18:13Z WARN ] ⚠   Previous installation of GCC exists in: '/Users/jpraczyk/.rustup/toolchains/esp/xtensa-esp32s3-elf/esp-12.2.0_20230208'. Reusing this installation
[2023-10-18T10:18:13Z WARN ] ⚠   Previous installation of GCC exists in: '/Users/jpraczyk/.rustup/toolchains/esp/xtensa-esp32s2-elf/esp-12.2.0_20230208'. Reusing this installation
[2023-10-18T10:18:13Z WARN ] ⚠   Previous installation of GCC exists in: '/Users/jpraczyk/.rustup/toolchains/esp/riscv32-esp-elf/esp-12.2.0_20230208'. Reusing this installation
[2023-10-18T10:18:15Z INFO ] 🔧  Uninstalling Xtensa Rust toolchain
[2023-10-18T10:18:16Z INFO ] 🔧  Installing Xtensa Rust 1.73.0.0 toolchain
[2023-10-18T10:18:16Z INFO ] 📥  Downloading file '/Users/jpraczyk/.rustup/tmp/.tmpxRgTSH/rust.tar.xz' from 'https://github.com/esp-rs/rust-build/releases/download/v1.73.0.0/rust-1.73.0.0-x86_64-apple-darwin.tar.xz'
[2023-10-18T10:20:34Z INFO ] 🔧  Uncompressing tar.xz file to '/Users/jpraczyk/.rustup/tmp/.tmpxRgTSH'
[2023-10-18T10:20:53Z INFO ] 🔧  Installing 'rust' component for Xtensa Rust toolchain
[2023-10-18T10:21:04Z INFO ] 📥  Downloading file '/Users/jpraczyk/.rustup/tmp/.tmpxRgTSH/rust-src.tar.xz' from 'https://github.com/esp-rs/rust-build/releases/download/v1.73.0.0/rust-src-1.73.0.0.tar.xz'
[2023-10-18T10:21:05Z INFO ] 🔧  Uncompressing tar.xz file to '/Users/jpraczyk/.rustup/tmp/.tmpxRgTSH'
[2023-10-18T10:21:06Z INFO ] 🔧  Installing 'rust-src' component for Xtensa Rust toolchain
[2023-10-18T10:23:35Z INFO ] 🔧  Creating export file
[2023-10-18T10:23:35Z WARN ] 💡  Please, set up the environment variables by running: ' /Users/jpraczyk/export-esp.sh'
[2023-10-18T10:23:35Z WARN ] ⚠   This step must be done every time you open a new terminal
[2023-10-18T10:23:35Z INFO ] ✅  Update successfully completed!


text:
terragrunt: 0.53.6 -> 0.53.8

Description of changes
https://github.com/gruntwork-io/terragrunt/releases/tag/v0.53.8
https://github.com/gruntwork-io/terragrunt/compare/v0.53.6...v0.53.8

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Priorities
Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 270688 run on x86_64-linux 1

1 package built:

terragrunt

source: gharchive/pull-request

repo: NixOS/nixpkgs

license: MIT

license_type: permissive

license_source: github-api


text:
pylyzer: 0.0.49 -> 0.0.50

Description of changes
Diff: https://github.com/mtshiba/pylyzer/compare/v0.0.49...v0.0.50
Changelog: https://github.com/mtshiba/pylyzer/releases/tag/v0.0.50
cc @natsukium

Things done

Built on platform(s)

[x] x86_64-linux
[x] aarch64-linux
[x] x86_64-darwin
[x] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 273226 run on x86_64-linux 1

1 package built:

pylyzer


text:
metasploit: 6.3.45 -> 6.3.46

Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Same issue as reported by @makefu for the last update #271410
...ew/pr-273323]$ ./results/metasploit/bin/msfconsole
Metasploit tip: Tired of setting RHOSTS for modules? Try globally setting it
with setg RHOSTS x.x.x.x
/nix/store/dx6hc6156f31d355akpzn0w88d4379km-metasploit-framework-6.3.46/share/msf/lib/msf/core/framework.rb:88:in `initialize': undefined method `_install_global_resolver' for Rex::Socket:Module (NoMethodError)
	from /nix/store/dx6hc6156f31d355akpzn0w88d4379km-metasploit-framework-6.3.46/share/msf/lib/msf/base/simple/framework.rb:71:in `new'
	from /nix/store/dx6hc6156f31d355akpzn0w88d4379km-metasploit-framework-6.3.46/share/msf/lib/msf/base/simple/framework.rb:71:in `create'
	from /nix/store/dx6hc6156f31d355akpzn0w88d4379km-metasploit-framework-6.3.46/share/msf/lib/msf/ui/console/driver.rb:93:in `initialize'
	from /nix/store/dx6hc6156f31d355akpzn0w88d4379km-metasploit-framework-6.3.46/share/msf/lib/metasploit/framework/command/console.rb:66:in `new'
	from /nix/store/dx6hc6156f31d355akpzn0w88d4379km-metasploit-framework-6.3.46/share/msf/lib/metasploit/framework/command/console.rb:66:in `driver'
	from /nix/store/dx6hc6156f31d355akpzn0w88d4379km-metasploit-framework-6.3.46/share/msf/lib/metasploit/framework/command/console.rb:54:in `start'
	from /nix/store/dx6hc6156f31d355akpzn0w88d4379km-metasploit-framework-6.3.46/share/msf/lib/metasploit/framework/command/base.rb:82:in `start'
	from /nix/store/dx6hc6156f31d355akpzn0w88d4379km-metasploit-framework-6.3.46/share/msf/msfconsole:23:in `<main>'

running update.sh results in a couple of dependencies being updated but gemset.nix fails to include dependencies = ["mini_portile2" "racc"]; to nokogiri. adding this i get a working msfconsole:
https://github.com/NixOS/nixpkgs/pull/273337
it seems that only updating the metasploit package itself was not enough for this patch-release.

authors: fabaff makefu


text:
cmake: 3.27.7 -> 3.28.1

Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[x] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[x] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

I tested both darwin-aarch64 and linux-x86_64 and everything seems to work fine. I'm not sure why ofborg is erroring

You should probably rebase this on top of staging, this has bound to have a lot of rebuilds.

Oh no, sorry for the noise. Changing the base seems to have requested a bunch of people for review. This was accidental.

It looks like you accidentally mass-pinged a bunch of people, which are now subscribed
and getting notifications for everything in this pull request. Unfortunately, they
cannot be automatically unsubscribed from the issue (removing review request does not
unsubscribe), therefore development cannot continue in this pull request anymore.
Please open a new pull request with your changes, link back to this one and ping the
people actually involved in here over there.
In order to avoid this in the future, there are instructions for how to properly
rebase between branches in our contribution guidelines.
Setting your pull request to draft prior to rebasing is strongly recommended.
In draft status, you can preview the list of people that are about to be requested
for review, which allows you to sidestep this issue.
This is not a bulletproof method though, as OfBorg still does review requests even on draft PRs.

authors: 2xsaiko drupol gracicot


text:
mpc-qt: 23.02 -> 23.12

Description of changes

Reformat
Add update script
Update to version 23.12

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Building is failing with the error message:
/nix/store/9vafkkic27k7m4934fpawl6yip3a6k4h-bash-5.2-p21/bin/bash: line 1: /nix/store/k5mav3nynvd2jzyv9rdvaky1ifpp0a5f-qtbase-6.6.1/bin/lrelease: No such file or directory

lrelease is provided by qttools, but the build system is telling it is in qtbase.
Any help in fixing this issue is welcome.

@SuperSandro2000 does this build for you ?

@romildo this builds after applying this patch
[nix-shell:~/.cache/nixpkgs-review/pr-280943/nixpkgs]$ git diff
diff --git a/pkgs/applications/video/mpc-qt/default.nix b/pkgs/applications/video/mpc-qt/default.nix
index 522fcf7754a5..9bb23b548e3f 100644
--- a/pkgs/applications/video/mpc-qt/default.nix
+++ b/pkgs/applications/video/mpc-qt/default.nix
@@ -4,6 +4,7 @@
 , pkg-config
 , qmake
 , qttools
+, qtbase
 , mpv
 , wrapQtAppsHook
 , gitUpdater
@@ -35,6 +36,10 @@ stdenv.mkDerivation rec {
     substituteInPlace lconvert.pri --replace "qtPrepareTool(LCONVERT, lconvert)" "qtPrepareTool(LCONVERT, lconvert, , , ${qttools}/bin)"
   '';

+  postConfigure = ''
+    substituteInPlace Makefile --replace ${qtbase}/bin/lrelease ${qttools.dev}/bin/lrelease
+  '';
+
   qmakeFlags = [
     "MPCQT_VERSION=${version}"
   ];

Result of nixpkgs-review pr 280943 run on x86_64-linux 1

1 package built:

mpc-qt

authors: kirillrdy romildo


text:
cnspec: 10.0.3 -> 10.1.4

Diff: https://github.com/mondoohq/cnspec/compare/refs/tags/v10.0.3...v10.1.4
Changelog: https://github.com/mondoohq/cnspec/releases/tag/v10.1.4
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 285713 run on x86_64-linux 1

1 package built:

cnspec


text:
qtrvsim: 0.9.6 -> 0.9.7

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/cvut/qtrvsim/releases.
meta.description for qtrvsim is: RISC-V CPU simulator for education purposes
meta.homepage for qtrvsim is: https://github.com/cvut/qtrvsim
Updates performed

Version update

To inspect upstream changes
Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 0.9.7 with grep in /nix/store/kfy5jdd2rz1yxhx38z4i5qlk8n6mxdfj-QtRVSim-0.9.7
found 0.9.7 in filename of file in /nix/store/kfy5jdd2rz1yxhx38z4i5qlk8n6mxdfj-QtRVSim-0.9.7

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
qtrvsim

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/kfy5jdd2rz1yxhx38z4i5qlk8n6mxdfj-QtRVSim-0.9.7 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A qtrvsim https://github.com/r-ryantm/nixpkgs/archive/e2351c1c52258a72477b285c106a54b789d57898.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/e2351c1c52258a72477b285c106a54b789d57898#qtrvsim

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/kfy5jdd2rz1yxhx38z4i5qlk8n6mxdfj-QtRVSim-0.9.7
ls -la /nix/store/kfy5jdd2rz1yxhx38z4i5qlk8n6mxdfj-QtRVSim-0.9.7/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

qtrvsim

Maintainer pings
cc @jdupak for testing.

Result of nixpkgs-review pr 289197 run on aarch64-darwin 1

1 package built:

qtrvsim


text:
python312Packages.aiocsv: 1.2.5 -> 1.3.0

Diff: https://github.com/MKuranowski/aiocsv/compare/refs/tags/v1.2.5...v1.3.0
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 290475 run on x86_64-linux 1

4 packages built:

python311Packages.aiocsv
python311Packages.aiocsv.dist
python312Packages.aiocsv
python312Packages.aiocsv.dist


text:
_1password-gui_beta: 8.10.28-11 -> 8.10.28-21 + refactor

Updating the 1Password beta release to 8.10.28
Removing the KeyringHelper application.

The KeyringHelper is deprecated and has been removed from 1password releases.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Force pushed to match contributions.md commit convention.

@savannidgerinel I have a suspicion that the keyring helper still is used somewhere, as I am failing to build this beta release:
error: builder for '/nix/store/lbjn1mf9b2zav6299bd7swlvfw1cwzjw-ensure-all-wrappers-paths-exist.drv' failed with exit code 1;
       last 4 log lines:
       > Checking that Nix store paths of all wrapped programs exist... FAIL
       > The path /nix/store/wmdwmcqs9hszjhaqkx5y5m9aapdkavsa-1password-8.10.28-21.BETA/share/1password/1Password-KeyringHelper does not exist!
       > Please, check the value of `security.wrappers."1Password-KeyringHelper".source`.

Not fully certain but I would assume:
security.wrappers."1Password-KeyringHelper" = lib.mkForce {};

or setting security.wrappers."1Password-KeyringHelper".source to a dummy path.

authors: SebTM Vilsol amaxine savannidgerinel


text:
mate-power-manager: init at 1.18.0

Motivation for this change
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] Linux

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

The commit message must also be reworded: please read CONTRIBUTING.md.

cc @romildo for review.

Hi, can this be merged?

Thanks!

authors: Mic92 chpatrick orivej


text:
mattermost-desktop: support NIXOS_OZONE_WL and fix sso login redirects

Description of changes
Adds NIXOS_OZONE_WL support like other electron packages and fix SSO login redirects via telling Mattermost Desktop that it is not running in dev mode (see https://github.com/NixOS/nixpkgs/pull/279645#discussion_r1540116541)
Supersedes and closes #259351
Supersedes and closes #279645
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 301283 run on x86_64-linux 1

1 package built:

mattermost-desktop

Can confirm that it fixes the sso login redirects issue.

authors: hbenazha lilyinstarlight


text:
proto: init at 0.32.2

Description of changes
Add moonrepo/proto newly.
Proto is a pluggable multi-language version manager.

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[x] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 301492 run on x86_64-linux 1

1 package built:

proto

i am a bit confused with the name "proto", as it doesn't seem to have anything to do with prototyping or protocols.

i am a bit confused with the name "proto", as it doesn't seem to have anything to do with prototyping or protocols.

I was a little confused as well about their naming choice, but they've got some reference on it

authors: lolbinarycat msanft nokazn


text:
kitty: init at 0.4.2

https://github.com/kovidgoyal/kitty.git
Motivation for this change
Adding new application: terminal kitty (opengl, c, python)
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

Thanks!


text:
android-ndks: add 25, 26 ndks, update default ndk and sdk

Description of changes

refactor androidndkPkgs to remove code duplication
adds ndk 25 and 26
sets default ndk to 26
sets default android sdk to 33

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[x] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 319139 run on x86_64-linux 1

2 packages blacklisted:

nixos-install-tools
tests.nixos-functions.nixos-test

authors: JohnRTitor NyCodeGHG


text:
violet: 0.4.6 -> 0.5.0

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for violet is: Lightweight STUN/TURN server
meta.homepage for violet is: https://github.com/paullouisageneau/violet
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 0.5.0 with grep in /nix/store/gxj3qa9v0lj9jrr1iazvf8aff3lnm1vi-violet-0.5.0
found 0.5.0 in filename of file in /nix/store/gxj3qa9v0lj9jrr1iazvf8aff3lnm1vi-violet-0.5.0

Rebuild report (if merged into master) (click to expand)

2 total rebuild path(s)

2 package rebuild(s)

First fifty rebuilds by attrpath

violet

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/gxj3qa9v0lj9jrr1iazvf8aff3lnm1vi-violet-0.5.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A violet https://github.com/r-ryantm/nixpkgs/archive/9971bbfc87e26adf51cc818508e8033d9facd49b.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/9971bbfc87e26adf51cc818508e8033d9facd49b#violet

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/gxj3qa9v0lj9jrr1iazvf8aff3lnm1vi-violet-0.5.0
ls -la /nix/store/gxj3qa9v0lj9jrr1iazvf8aff3lnm1vi-violet-0.5.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review --extra-nixpkgs-config '{ allowInsecurePredicate = x: true; }' run on x86_64-linux 1

1 package built:

violet

Maintainer pings
cc @oluceps for testing.

Result of nixpkgs-review pr 321210 run on x86_64-linux 1

1 package built:

violet

Result of nixpkgs-review pr 321210 run on x86_64-linux 1

1 package built:

violet

authors: JohnRTitor pinpox r-ryantm


text:
mongoc: 1.27.3 -> 1.27.4

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/mongodb/mongo-c-driver/releases.
meta.description for mongoc is: Official C client library for MongoDB
meta.homepage for mongoc is: http://mongoc.org
Updates performed

Version update

To inspect upstream changes
Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 1.27.4 with grep in /nix/store/13r4da245lh3bd691zvmc655kn5pwssk-mongoc-1.27.4
found 1.27.4 in filename of file in /nix/store/13r4da245lh3bd691zvmc655kn5pwssk-mongoc-1.27.4

Rebuild report (if merged into master) (click to expand)

8 total rebuild path(s)

8 package rebuild(s)

First fifty rebuilds by attrpath

collectd
libmongocrypt
mongoc
mongocxx
n8n
rsyslog
syslogng

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/13r4da245lh3bd691zvmc655kn5pwssk-mongoc-1.27.4 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A mongoc https://github.com/r-ryantm/nixpkgs/archive/89b1c8b08749db1feeae81a4c8ba5e1a9b3106ed.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/89b1c8b08749db1feeae81a4c8ba5e1a9b3106ed#mongoc

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/13r4da245lh3bd691zvmc655kn5pwssk-mongoc-1.27.4
ls -la /nix/store/13r4da245lh3bd691zvmc655kn5pwssk-mongoc-1.27.4/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

8 packages built:

collectd
libmongocrypt
mongoc
mongocxx
n8n
rsyslog
syslogng
syslogng.man

Maintainer pings
cc @archer-65 for testing.

Result of nixpkgs-review pr 324234 run on x86_64-darwin 1

1 package marked as broken and skipped:

collectd

3 packages built:

libmongocrypt
mongoc
n8n

authors: r-ryantm wegank


text:
cracklib: 2.9.11 -> 2.10.0

Changes: https://github.com/cracklib/cracklib/releases/tag/v2.10.0
Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 327481 run on aarch64-darwin 1

273 packages marked as broken and skipped:

almanah
anilibria-winmaclinux
arcan
arcan.dev
arcan.lib
arcan.man
benchexec
benchexec.dist
biboumi
booster
brltty
cloud-init
cloud-init.dist
collision
colloid-kde
colloid-kde.sddm
datadog-agent
dbmonster
dbus-test-runner
dnf-plugins-core
dnf-plugins-core.man
dnf4
dnf4.man
dnf4.py
dnf5
dnf5.man
dwl
dwl.man
emacsPackages.ac-mozc
emacsPackages.mozc
emacsPackages.mozc-cand-posframe
emacsPackages.mozc-im
emacsPackages.mozc-popup
emacsPackages.mozc-temp
evolution-data-server
evolution-data-server-gtk4
evolution-data-server-gtk4.dev
evolution-data-server.dev
exaile
eyewitness
fgallery
folks
folks.dev
folks.devdoc
fooyin
gcr_4
gcr_4.bin
gcr_4.dev
gcr_4.devdoc
gnome-calendar
gnome-online-accounts
gnome-online-accounts.dev
gnome-recipes
gnome.gnome-music
gnome.gvfs
graphite-kde-theme
graylog-5_1
graylog-5_2
grilo-plugins
grimblast
gruvbox-gtk-theme
ibus-engines.libthai
journalwatch
journalwatch.dist
kaffeine
kodiPackages.inputstream-adaptive
kodiPackages.inputstream-ffmpegdirect
kodiPackages.inputstream-rtmp
kodiPackages.joystick
kodiPackages.libretro
kodiPackages.libretro-2048
kodiPackages.libretro-fuse
kodiPackages.libretro-genplus
kodiPackages.libretro-mgba
kodiPackages.libretro-nestopia
kodiPackages.libretro-snes9x
kodiPackages.pvr-hdhomerun
kodiPackages.pvr-hts
kodiPackages.pvr-iptvsimple
kodiPackages.pvr-vdr-vnsi
kodiPackages.steam-controller
kodiPackages.vfs-libarchive
kodiPackages.vfs-rar
kodiPackages.vfs-sftp
kodiPackages.visualization-fishbmc
kodiPackages.visualization-goom
kodiPackages.visualization-matrix
kodiPackages.visualization-pictureit
kodiPackages.visualization-projectm
kodiPackages.visualization-shadertoy
kodiPackages.visualization-spectrum
kodiPackages.visualization-starburst
kodiPackages.visualization-waveform
kphotoalbum
labwc
labwc.man
latte-dock
layan-kde
lemurs
liberio
libqtdbusmock
libqtdbustest
libsForQt5.alkimia
libsForQt5.bismuth
libsForQt5.kdelibs4support
libsForQt5.kdelibs4support.dev
libsForQt5.krohnkite
libsForQt5.kwin-dynamic-workspaces
libsForQt5.kwin-tiling
libsForQt5.kzones
libsForQt5.parachute
libsForQt5.tokodon
lightly-boehs
lightly-qt
linux-wifi-hotspot
lomiri.gmenuharness
malcontent
malcontent-ui
malcontent-ui.dev
malcontent-ui.lib
malcontent.bin
malcontent.dev
malcontent.installedTests
malcontent.lib
malcontent.man
malcontent.pam
mate.mate-control-center
mate.mate-power-manager
mate.mate-screensaver
mate.mate-session-manager
mate.mate-settings-daemon-wrapped
mate.mate-system-monitor
mate.mate-utils
mate.mate-wayland-session
matrix-synapse
mautrix-facebook
mautrix-facebook.dist
mojave-gtk-theme
nautilus-python
nautilus-python.dev
nautilus-python.devdoc
nautilus-python.doc
nemu
networkmanager_dmenu
nightfox-gtk-theme
nordic
nordic.sddm
onboard
onboard.dist
ostree-rs-ext
pdns
perl536Packages.LogJournald
perl536Packages.LogJournald.devdoc
perl538Packages.LogJournald
perl538Packages.LogJournald.devdoc
plasma5Packages.alkimia
plasma5Packages.bismuth
plasma5Packages.kdelibs4support
plasma5Packages.kdelibs4support.dev
plasma5Packages.krohnkite
plasma5Packages.kwin-dynamic-workspaces
plasma5Packages.kwin-tiling
plasma5Packages.kzones
plasma5Packages.parachute
plasma5Packages.tokodon
prometheus-postfix-exporter
pulseaudioFull
pulseaudioFull.dev
pykms
python311Packages.dnf-plugins-core
python311Packages.dnf-plugins-core.man
python311Packages.proton-vpn-killswitch-network-manager
python311Packages.proton-vpn-killswitch-network-manager.dist
python311Packages.proton-vpn-network-manager
python311Packages.proton-vpn-network-manager-openvpn
python311Packages.proton-vpn-network-manager-openvpn.dist
python311Packages.proton-vpn-network-manager.dist
python311Packages.py3status
python311Packages.py3status.dist
python311Packages.pystemd
python311Packages.pystemd.dist
python311Packages.python-vlc
python311Packages.python-vlc.dist
python311Packages.qtile-extras
python311Packages.qtile-extras.dist
python311Packages.systemd
python311Packages.systemd.dist
python312Packages.dnf-plugins-core
python312Packages.dnf-plugins-core.man
python312Packages.proton-vpn-killswitch-network-manager
python312Packages.proton-vpn-killswitch-network-manager.dist
python312Packages.proton-vpn-network-manager
python312Packages.proton-vpn-network-manager-openvpn
python312Packages.proton-vpn-network-manager-openvpn.dist
python312Packages.proton-vpn-network-manager.dist
python312Packages.py3status
python312Packages.py3status.dist
python312Packages.pystemd
python312Packages.pystemd.dist
python312Packages.python-vlc
python312Packages.python-vlc.dist
python312Packages.qtile-extras
python312Packages.qtile-extras.dist
python312Packages.systemd
python312Packages.systemd.dist
qemu_full
qemu_xen
qemu_xen-light
qemu_xen_4_15
qemu_xen_4_15-light
qmk_hid
qogir-kde
rivercarro
rpcbind
rubyPackages.rpam2
rubyPackages.ruby-lxc
rubyPackages_3_1.rpam2
rubyPackages_3_1.ruby-lxc
rubyPackages_3_2.rpam2
rubyPackages_3_2.ruby-lxc
rubyPackages_3_3.rpam2
rubyPackages_3_3.ruby-lxc
sanoid
scenefx
shairport-sync
sirikali
snapshot
strongswanNM
stubby
stubby.man
stubby.stubbyExampleJson
sublime-music
sublime-music.dist
sway-contrib.grimshot
sway-contrib.grimshot.man
switch-to-configuration-ng
sysprof
sysprof.dev
sysprof.lib
telepresence
telepresence.dist
tokyonight-gtk-theme
udiskie
udiskie.dist
uhub
unbound-full
unbound-full.lib
unbound-full.man
unbound-with-systemd
unbound-with-systemd.lib
unbound-with-systemd.man
update-resolv-conf
utterly-nord-plasma
vimix-gtk-themes
waybox
wayfire
wayfirePlugins.firedecor
wayfirePlugins.focus-request
wayfirePlugins.wayfire-plugins-extra
wayfirePlugins.wayfire-shadows
wayfirePlugins.wcm
wayfirePlugins.wf-shell
wayfirePlugins.windecor
wayfirePlugins.wwp-switcher
whitesur-gtk-theme
whitesur-kde
wio
xarcan
xen-guest-agent
xfce.xfce4-weather-plugin
zoneminder
zpool-auto-expand-partitions
zram-generator

26 packages failed to build:

atheme
cracklib
darwin.linux-builder
darwin.linux-builder-x86_64
libpwquality
libpwquality.dev
libpwquality.lib
libpwquality.man
mariadb (mariadb_1011)
mariadb-embedded
mariadb-embedded.man
mariadb.man (mariadb_1011.man)
mariadb_105
mariadb_105.man
mariadb_106
mariadb_106.man
mariadb_110
mariadb_110.man
nanomq
python311Packages.libpwquality (python311Packages.libpwquality.dev ,python311Packages.libpwquality.lib ,python311Packages.libpwquality.man ,python311Packages.libpwquality.py)
python312Packages.libpwquality (python312Packages.libpwquality.dev ,python312Packages.libpwquality.lib ,python312Packages.libpwquality.man ,python312Packages.libpwquality.py)
snipe-it
tests.testers.lycheeLinkCheck.network
tests.testers.nixosTest-example
tests.testers.runNixOSTest-example
tests.trivial-builders.references

authors: ofalvai trofi


text:
tea: Install shell completions for bash and zsh

Description of changes
The tea tool comes with shell completions for bash, zsh, fish and ps: https://gitea.com/gitea/tea/src/branch/main/contrib. This change installs the completions for bash and zsh. Currently, there is no simple way to get the fish completion script since it is generated at runtime and directly written on disk. Maybe someone who knows better can add the fish completion later.

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

@vbrandl thanks for this PR <3 I think tea can do shell complete for fish too. Could you check if it does, and if so add it in as well? (Or, I can check it too when I get back to a computer)

Yeah I want to look into fish completion once bash and ZSH completion works. I ran nixpkgs-review pr 334848 but the completion doesn't work in the created shell. I have to look into that first. Or do you have any idea why it doesn't work?
I didn't include fish completion yet, since there is no autocomplete.fish in https://gitea.com/gitea/tea/src/branch/main/contrib. I looked into the code and the fish completion gets generated dynamically: https://gitea.com/gitea/tea/src/branch/main/cmd/autocomplete.go#L112
Currently there is no way to just print the completion script, so I think I have to run tea autocomplete fish and then install the script from $XDG_CONFIG_HOME/fish/conf.d/tea_completion.fish

Instead of using the completions that are in contrib, you could use the generation in the binary for each of the shells. Similar to how golangci-lint does it: https://sourcegraph.com/github.com/NixOS/nixpkgs/-/blob/pkgs/development/tools/golangci-lint/default.nix?L28-32

There is no generation in the binary. Calling tea shellcompletion bash simply downloads the file from contrib:
$ tea shellcompletion bash
Fetching https://gitea.com/gitea/tea/raw/branch/master/contrib/autocomplete.sh

# Run the following commands to install autocompletion (or use --install)
echo 'PROG=tea source "/home/me/.config/tea/autocomplete.sh"' >> ~/.bashrc && source ~/.bashrc

@vbrandl oh dang, that should be changed upstream then. I'm working towards a 0.10.0 release, and will add that in before then.  I'm sorry to ask you to look into fish. No timeline guarantees though, so if you can revert this PR back to bash and zsh, then when I'm done it upstream we can update the shell completion installation in a future PR to include fish.

I removed the fish completion again. But there still is the problem with sourcing the completion scripts without the PROG environment variable. I could just wrap or patch the scripts to set PROG=tea. That might work but I would have to test it first. Or will you change that upstream, too. If so, I will wait for the 0.10.0 release and reopen the nixpkgs PR, once that's done.

authors: techknowlogick vbrandl


text:
chromedriver,{ungoogled-,}chromium: 128.0.6613.119-1 -> 128.0.6613.137-1

Description of changes
https://chromereleases.googleblog.com/2024/09/stable-channel-update-for-desktop_10.html
This update includes 5 security fixes.
CVEs:
CVE-2024-8636 CVE-2024-8637 CVE-2024-8638 CVE-2024-8639
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/) (only ungoogled-chromium)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 341275 run on x86_64-linux 1

2 packages marked as broken and skipped:

archivebox
archivebox.dist

31 packages built:

aws-azure-login
chromedriver
chromium
chromium.sandbox
fast-cli
flaresolverr
gotenberg
grafana-kiosk
mermaid-cli
mermaid-filter
percollate
playwright-test
puppeteer-cli
python311Packages.pytest-playwright
python311Packages.pytest-playwright.dist
python311Packages.shiny
python311Packages.shiny.dist
python312Packages.pytest-playwright
python312Packages.pytest-playwright.dist
python312Packages.shiny
python312Packages.shiny.dist
selendroid
selenium-server-standalone
sharedown
single-file-cli
sitespeed-io
undetected-chromedriver
ungoogled-chromium
ungoogled-chromium.sandbox
vhs
wayback

authors: emilylange networkException


text:
nixos/caddy: add options for ports and openFirewall

Description of changes
Added the option services.caddy.openFirewall. Fixes #338015
Maybe it would be a good idea to trigger a backport for 24.05 as well?
I ran the test nix-build -A nixosTests.caddy in a virtual NixOS machine on my Mac and got the following error. My assumption is that this is caused by some networking issues due to the nested VMs.
error: builder for '/nix/store/1b7bgcx2xf84i3aq8abgbbrrn3mwpmsd-vm-test-run-caddy.drv' failed with exit code 1;
       last 25 log lines:
       > webserver: waiting for TCP port 80 on localhost
       > webserver # Connection to localhost (::1) 80 port [tcp/http] succeeded!
       > (finished: waiting for TCP port 80 on localhost, in 1.91 seconds)
       > subtest: config is reloaded on nixos-rebuild switch
       > webserver: must succeed: /nix/store/83r48jqiag13psakxg142mnyr8jvm9mx-nixos-system-webserver-test/specialisation/config-reload/bin/switch-to-configuration test >&2
       > webserver # [  266.468913] nixos[1038]: switching to system configuration /nix/store/k19q5gmd8f0kxdavbmsvqkw4wahbgw2j-nixos-system-webserver-test
       > webserver # [  266.556710] systemd[1]: Stopped target Local File Systems.
       > webserver # [  266.659840] systemd[1]: Stopped target Remote File Systems.
       > webserver # activating the configuration...
       > webserver # setting up /etc...
       > webserver # [  295.540848] systemd[1]: Reload requested from client PID 1038 ('.switch-to-conf') (unit backdoor.service)...
       > webserver # [  295.588781] systemd[1]: Reloading...
       > webserver # restarting sysinit-reactivation.target
       > webserver # Failed to restart sysinit-reactivation.target: Did not receive a reply. Possible causes include: the remote application did not send a reply, the message bus security policy blocked the reply, the reply timeout expired, or the network connection was broken.
       > webserver # Error: Failed to get unit caddy.service
       > webserver #
       > webserver # Caused by:
       > webserver #     Did not receive a reply. Possible causes include: the remote application did not send a reply, the message bus security policy blocked the reply, the reply timeout expired, or the network connection was broken.
       > webserver: output:
       > Test "config is reloaded on nixos-rebuild switch" failed with error: "command `/nix/store/83r48jqiag13psakxg142mnyr8jvm9mx-nixos-system-webserver-test/specialisation/config-reload/bin/switch-to-configuration test >&2` failed (exit code 1)"
       > cleanup
       > kill machine (pid 10)
       > qemu-kvm: terminating on signal 15 from pid 7 (/nix/store/h3i0acpmr8mrjx07519xxmidv8mpax4y-python3-3.12.5/bin/python3.12)
       > (finished: cleanup, in 0.01 seconds)
       > kill vlan (pid 8)
       For full logs, run 'nix log /nix/store/1b7bgcx2xf84i3aq8abgbbrrn3mwpmsd-vm-test-run-caddy.drv'.

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Thanks for having a look @drupol
I agree that my solution was not ideal for people that used custom http/https ports. I just pushed a new revision of my change and added two new options for setting the ports used by caddy. I split them up in separate commits for better traceability.
W.r.t. the option of disabling http traffic entirely: caddy by default uses the http port to forward to https (https://caddyserver.com/docs/automatic-https#effects). There also does not exist an option to disable the http port globally, one must disable automatic redirects to achieve this. So I think it should be safe to set the port globally.
However, this could be considered a breaking change: What if someone already extended the global settings of caddy with custom ports. By using types.lines, they would be merged, but I am not sure how caddy handles duplicate settings.
Therefore, I marked this PR as draft to prevent accidental merges before we have some clarity on this point.

One way of dealing with the breaking change could be to conditionally add the port settings only if they differ from the default (just like email is only added if specified by the user).

@drupol I changed the default value of the ports to null and conditionally open all ports on the firewall that are set to some value. What do you think?

Sure, I'll have a look later today and will mark the PR as ready for review once I'm done. Thanks!

I just thought about the port options again and am not sure if null should be the default value. I had a look at some other NixOS modules that have a port option and the standard seems to be to use the real port number, so users could be confused by my solution.
Would it be better to have 80/443 as default with the option of setting the to null to remove them from the global config and the firewall? I personally think so, but as said earlier this could be a breaking change for some.
What do you think @drupol?

I totally see your point @emilylange, feel free to close the PR if the others agree.
In case it is still wanted I could add the https port ot the list of open udp ports, thanks for pointing that out.

I let @emilylange decide on this one ;)

Thanks for the ping @emilylange.
This PR is definitely well done, and I can see the use-case for it. That being said, I'm not the target audience for it as I prefer to work directly with fw rules, especially due to specific interfaces.
Some feedback I'd give is similar to @emilylange's in that http/3 requires udp open on 443. So instead of having two options being http and https, then perhaps have the two options be tcpports and udpports. Especially since caddy can have extensions that handle more than just http/s.
I'm not sure that this should be blocked because the pattern doesn't exist in apache-httpd or nginx, but rather I think if a pattern is introduced then we should consider what the implications are for the others as we don't want to create something that works for caddy but not the others.
While I wouldn't use these settings, I do understand that there are multiple valid ways to manage systems and "my" way isn't the only way (or even the "best" way).
I'd prefer if this became more generic, and that perhaps nginx & httpd module maintainers were looped in to see if this could work for them too, but I won't block on it.
Apologies everyone for the novel, but hopefully it's been helpful and not at all yakshaving.

Thank you for the input, @techknowlogick!
Based on the recent feedback, I made some changes to my PR as a suggestion for further discussion on how to handle this best. The following changes were made:

The ports are now set to their respective values (i.e., 80/443) by default, but still allow being set to null.
The global port options are only added to the generated Caddyfile if they are non-null and differ from their respective default values (to handle the potential breaking change of existing configs)
The UDP port is now opened as well if openFirewall is set to true
An additional node has been added to openFirewall saying that non-standard ports need to be opened manually

This may not be the ideal solution for all use cases, but when looking at existing NixOS modules (e.g., samba), it seems that opening the standard/default ports for a service is also done elsewhere.
I also thought about the suggestion of allowing users to specify the desired tcp/udp ports manually, but that would mean that we (i) duplicate the firewall module and (ii) require them to change the ports in two places (in the Caddyfile and in the firewall). If desired I could add another option (e.g., extraTCPPorts and extraUDPPorts), but I would argue that these more advanced use cases are better fitted by setting the options manually at the right places.
Again, I very much understand if this causes more problems than solutions, I just wanted to propose another alternative 😄

Also worth noting Caddy allows using any number of arbitrary ports for both HTTP and HTTPS.

@fin444 which other webservers also allow for and has already been mentioned in an earlier comment? you have just said you would like to remind everyone of that fact? although since it is already out of the norm to not use 80/443 for webservers, i would be willing to bet that anyone doing so would figure out that they would need to open up those ports on the firewall...

authors: drupol dweee fin444 mirkolenz techknowlogick


text:
jawiki-all-titles-in-ns0: 0-unstable-2024-09-11 -> 0-unstable-2024-10-01

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for jawiki-all-titles-in-ns0 is: A jawiki dump list of page titles in main namespace
meta.homepage for jawiki-all-titles-in-ns0 is: https://dumps.wikimedia.org/backup-index.html
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes

Compare changes on GitHub

Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 0-unstable-2024-10-01 in filename of file in /nix/store/kq39bl648a5yrzp278q7zj6p39j2s00a-jawiki-all-titles-in-ns0-0-unstable-2024-10-01

Rebuild report (if merged into master) (click to expand)

2 total rebuild path(s)

2 package rebuild(s)

First fifty rebuilds by attrpath

ibus-engines.mozc-ut

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/kq39bl648a5yrzp278q7zj6p39j2s00a-jawiki-all-titles-in-ns0-0-unstable-2024-10-01 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A jawiki-all-titles-in-ns0 https://github.com/r-ryantm/nixpkgs/archive/966526bda1af9579ae9424c0d20e7e126713d654.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/966526bda1af9579ae9424c0d20e7e126713d654#jawiki-all-titles-in-ns0

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/kq39bl648a5yrzp278q7zj6p39j2s00a-jawiki-all-titles-in-ns0-0-unstable-2024-10-01
ls -la /nix/store/kq39bl648a5yrzp278q7zj6p39j2s00a-jawiki-all-titles-in-ns0-0-unstable-2024-10-01/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

3 packages built:

ibus-engines.mozc-ut
jawiki-all-titles-in-ns0
merge-ut-dictionaries

Maintainer pings
cc @pineapplehunter for testing.

[!TIP]
As a maintainer, if your package is located under pkgs/by-name/*, you can comment @NixOS/nixpkgs-merge-bot merge to automatically merge this update using the nixpkgs-merge-bot.

Add a :+1: reaction to pull requests you find important.

@NixOS/nixpkgs-merge-bot merge

@NixOS/nixpkgs-merge-bot merge

authors: pineapplehunter r-ryantm


text:
python312Packages.dramatiq: 1.17.0 -> 1.17.1

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for python312Packages.dramatiq is: Background Processing for Python 3
meta.homepage for python312Packages.dramatiq is: https://github.com/Bogdanp/dramatiq
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 1.17.1 with grep in /nix/store/jkc33471mr00yw80h3lymhx86ncyjz8v-python3.12-dramatiq-1.17.1
found 1.17.1 in filename of file in /nix/store/jkc33471mr00yw80h3lymhx86ncyjz8v-python3.12-dramatiq-1.17.1

Rebuild report (if merged into master) (click to expand)

8 total rebuild path(s)

8 package rebuild(s)

First fifty rebuilds by attrpath

fittrackee
python311Packages.dramatiq
python311Packages.flask-dramatiq
python311Packages.periodiq
python312Packages.dramatiq
python312Packages.flask-dramatiq
python312Packages.periodiq

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/jkc33471mr00yw80h3lymhx86ncyjz8v-python3.12-dramatiq-1.17.1 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A python312Packages.dramatiq https://github.com/r-ryantm/nixpkgs/archive/09faeb11a60588900f3bb535e04e8a2c4cd69bf2.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/09faeb11a60588900f3bb535e04e8a2c4cd69bf2#python312Packages.dramatiq

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/jkc33471mr00yw80h3lymhx86ncyjz8v-python3.12-dramatiq-1.17.1
ls -la /nix/store/jkc33471mr00yw80h3lymhx86ncyjz8v-python3.12-dramatiq-1.17.1/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review

x86_64-linux

:white_check_mark: 14 packages built:

fittrackee
fittrackee.dist
python311Packages.dramatiq
python311Packages.dramatiq.dist
python311Packages.flask-dramatiq
python311Packages.flask-dramatiq.dist
python311Packages.periodiq
python311Packages.periodiq.dist
python312Packages.dramatiq
python312Packages.dramatiq.dist
python312Packages.flask-dramatiq
python312Packages.flask-dramatiq.dist
python312Packages.periodiq
python312Packages.periodiq.dist

Maintainer pings
cc @traxys for testing.

[!TIP]
As a maintainer, if your package is located under pkgs/by-name/*, you can comment @NixOS/nixpkgs-merge-bot merge to automatically merge this update using the nixpkgs-merge-bot.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 351475 at 50b246d7 run on x86_64-linux 1

:white_check_mark: 7 packages built:

fittrackee
python311Packages.dramatiq
python311Packages.flask-dramatiq
python311Packages.periodiq
python312Packages.dramatiq
python312Packages.flask-dramatiq
python312Packages.periodiq

authors: natsukium r-ryantm


text:
scalp: unstable-2022-03-15 -> 0-unstable-2024-08-28

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 355476

aarch64-darwin

:white_check_mark: 3 packages built:

flopoco
pagsuite
scalp

nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 355476

x86_64-darwin

:white_check_mark: 3 packages built:

flopoco
pagsuite
scalp

nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 355476

aarch64-linux

:white_check_mark: 3 packages built:

flopoco
pagsuite
scalp


text:
bacon: 3.3.0 -> 3.5.0

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for bacon is: Background rust code checker
meta.homepage for bacon is: https://github.com/Canop/bacon
meta.changelog for bacon is: https://github.com/Canop/bacon/blob/v3.5.0/CHANGELOG.md
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 3.5.0 with grep in /nix/store/262jkph01spcx9nai8mymfb0qgana6ly-bacon-3.5.0
found 3.5.0 in filename of file in /nix/store/262jkph01spcx9nai8mymfb0qgana6ly-bacon-3.5.0

Rebuild report (if merged into master) (click to expand)

2 total rebuild path(s)

2 package rebuild(s)

First fifty rebuilds by attrpath

bacon

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/262jkph01spcx9nai8mymfb0qgana6ly-bacon-3.5.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A bacon https://github.com/r-ryantm/nixpkgs/archive/6f1a606c86f048c3c1e02165ec468b1cbaef5da7.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/6f1a606c86f048c3c1e02165ec468b1cbaef5da7#bacon

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/262jkph01spcx9nai8mymfb0qgana6ly-bacon-3.5.0
ls -la /nix/store/262jkph01spcx9nai8mymfb0qgana6ly-bacon-3.5.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review

x86_64-linux

:white_check_mark: 1 package built:

bacon

Maintainer pings
cc @FlorianFranzen for testing.

[!TIP]
As a maintainer, if your package is located under pkgs/by-name/*, you can comment @NixOS/nixpkgs-merge-bot merge to automatically merge this update using the nixpkgs-merge-bot.

Add a :+1: reaction to pull requests you find important.

nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 364595

aarch64-darwin

:white_check_mark: 1 package built:

bacon

authors: r-ryantm uncenter


text:
python312Packages.langchain: fix build - disable some test paths

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

@ofborg build python312Packages.langchain

@ofborg build python312Packages.langchain

@ofborg build python312Packages.langchain python312Packages.langchain-mongodb


text:
gzdoom: 3.3.0 -> 3.3.2

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools.
This update was made based on information from https://repology.org/metapackage/gzdoom/versions.
These checks were done:

built on NixOS
Warning: no binary found that responded to help or version flags. (This warning appears even if the package isn't expected to have binaries.)
found 3.3.2 with grep in /nix/store/zv856axqy6bna0vpgramgaglz02nb8rh-gzdoom-3.3.2
directory tree listing: https://gist.github.com/66372cbd8e865e89ab9749a99b308ea7

cc @Lassulus for review

No attempt on x86_64-darwin (full log)
The following builds were skipped because they don't evaluate on x86_64-darwin: gzdoom
Partial log (click to expand)

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

Success on x86_64-linux (full log)
Attempted: gzdoom
Partial log (click to expand)
/build/source/build/gzdoom.pk3 contains 684 files (updated 684)
[100%] Built target gzdoom_pk3
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/zv856axqy6bna0vpgramgaglz02nb8rh-gzdoom-3.3.2
shrinking /nix/store/zv856axqy6bna0vpgramgaglz02nb8rh-gzdoom-3.3.2/lib/gzdoom/gzdoom
strip is /nix/store/j75dgadrff2d1fyc4fczmcgqkid2imdx-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/zv856axqy6bna0vpgramgaglz02nb8rh-gzdoom-3.3.2/lib  /nix/store/zv856axqy6bna0vpgramgaglz02nb8rh-gzdoom-3.3.2/bin
patching script interpreter paths in /nix/store/zv856axqy6bna0vpgramgaglz02nb8rh-gzdoom-3.3.2
checking for references to /build in /nix/store/zv856axqy6bna0vpgramgaglz02nb8rh-gzdoom-3.3.2...

Success on aarch64-linux (full log)
Attempted: gzdoom
Partial log (click to expand)
/build/source/build/gzdoom.pk3 contains 684 files (updated 684)
[100%] Built target gzdoom_pk3
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/vwaqc5kk5rfjq6qckwfpl02xz63d86cn-gzdoom-3.3.2
shrinking /nix/store/vwaqc5kk5rfjq6qckwfpl02xz63d86cn-gzdoom-3.3.2/lib/gzdoom/gzdoom
strip is /nix/store/j7d4mr0ikv974ig7yzhknpsq288js4bs-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/vwaqc5kk5rfjq6qckwfpl02xz63d86cn-gzdoom-3.3.2/lib  /nix/store/vwaqc5kk5rfjq6qckwfpl02xz63d86cn-gzdoom-3.3.2/bin
patching script interpreter paths in /nix/store/vwaqc5kk5rfjq6qckwfpl02xz63d86cn-gzdoom-3.3.2
checking for references to /build in /nix/store/vwaqc5kk5rfjq6qckwfpl02xz63d86cn-gzdoom-3.3.2...

authors: GrahamcOfBorg r-ryantm


text:
mate-screensaver: 1.20.1 -> 1.21.0

Motivation for this change
Update to version 1.21.0.
Fix https://github.com/NixOS/nixpkgs/issues/44523.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Fits CONTRIBUTING.md.

@GrahamcOfBorg build mate.mate-screensaver

Success on x86_64-linux (full log)
Attempted: mate.mate-screensaver
Partial log (click to expand)
shrinking /nix/store/4pb81cky8qd618x0k2d1mvf1h5kasa69-mate-screensaver-1.21.0/libexec/mate-screensaver/.popsquares-wrapped
shrinking /nix/store/4pb81cky8qd618x0k2d1mvf1h5kasa69-mate-screensaver-1.21.0/libexec/mate-screensaver/.slideshow-wrapped
shrinking /nix/store/4pb81cky8qd618x0k2d1mvf1h5kasa69-mate-screensaver-1.21.0/libexec/.mate-screensaver-gl-helper-wrapped
shrinking /nix/store/4pb81cky8qd618x0k2d1mvf1h5kasa69-mate-screensaver-1.21.0/libexec/.mate-screensaver-dialog-wrapped
gzipping man pages under /nix/store/4pb81cky8qd618x0k2d1mvf1h5kasa69-mate-screensaver-1.21.0/share/man/
strip is /nix/store/1hi76hr87bd1y1q1qjk0lv8nmcjip1c8-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/4pb81cky8qd618x0k2d1mvf1h5kasa69-mate-screensaver-1.21.0/lib  /nix/store/4pb81cky8qd618x0k2d1mvf1h5kasa69-mate-screensaver-1.21.0/libexec  /nix/store/4pb81cky8qd618x0k2d1mvf1h5kasa69-mate-screensaver-1.21.0/bin
patching script interpreter paths in /nix/store/4pb81cky8qd618x0k2d1mvf1h5kasa69-mate-screensaver-1.21.0
checking for references to /build in /nix/store/4pb81cky8qd618x0k2d1mvf1h5kasa69-mate-screensaver-1.21.0...
/nix/store/4pb81cky8qd618x0k2d1mvf1h5kasa69-mate-screensaver-1.21.0

Failure on aarch64-linux (full log)
Attempted: mate.mate-screensaver
Partial log (click to expand)
    Finished release [optimized] target(s) in 363.82 secs
Assembling stage1 compiler (aarch64-unknown-linux-gnu)
Building stage1 std artifacts (aarch64-unknown-linux-gnu -> aarch64-unknown-linux-gnu)
building of '/nix/store/nzxz2hn6ssvanp1v6ayprfbprlvx1sf3-rustc-1.27.0.drv' timed out after 3600 seconds
cannot build derivation '/nix/store/746np0zvbhpa2sr6vkkkpnwsgb9dxdga-cargo-1.27.0.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/q28r339dz25l1mmw8rfbkz1ldcczwzmj-librsvg-2.42.4.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/y3j81m2w0m8ziyz6c0an81icgrxfxh31-hook.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/3v6q3qylgh51cd3nd4i6v8drzms0g241-mate-desktop-1.21.0.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/sg5q9xp0jwfs82vwrnnqqyi46szq8knf-mate-screensaver-1.21.0.drv': 2 dependencies couldn't be built
error: build of '/nix/store/sg5q9xp0jwfs82vwrnnqqyi46szq8knf-mate-screensaver-1.21.0.drv' failed

authors: GrahamcOfBorg Infinisil romildo


text:
Backport breakpointHook [18.09]

Motivation for this change
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Fits CONTRIBUTING.md.

Success on x86_64-linux (full log)
Attempted: breakpointHook, cntr
Partial log (click to expand)
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/5fhjbrrfws7k3lr92xrz3l7lxbij7ppi-cntr-1.2.0
shrinking /nix/store/5fhjbrrfws7k3lr92xrz3l7lxbij7ppi-cntr-1.2.0/bin/cntr
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/5fhjbrrfws7k3lr92xrz3l7lxbij7ppi-cntr-1.2.0/bin
patching script interpreter paths in /nix/store/5fhjbrrfws7k3lr92xrz3l7lxbij7ppi-cntr-1.2.0
checking for references to /build in /nix/store/5fhjbrrfws7k3lr92xrz3l7lxbij7ppi-cntr-1.2.0...
/nix/store/0m0w3s7a0da17qz206rlvs4k3pa58acd-hook
/nix/store/5fhjbrrfws7k3lr92xrz3l7lxbij7ppi-cntr-1.2.0

Success on aarch64-linux (full log)
Attempted: breakpointHook
The following builds were skipped because they don't evaluate on aarch64-linux: cntr
Partial log (click to expand)

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

these derivations will be built:
  /nix/store/imf65gxhn1m3v23b7gbf7rvf8wmnyvxc-hook.drv
building '/nix/store/imf65gxhn1m3v23b7gbf7rvf8wmnyvxc-hook.drv'...
/nix/store/4m5q3ckqpc8h4vjxzsvkym1plp29v81d-hook

Success on x86_64-linux (full log)
Attempted: breakpointHook, cntr
Partial log (click to expand)
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/8qglbfh1yd4ny25q60nazzkxrqd4xkzn-cntr-1.2.0
shrinking /nix/store/8qglbfh1yd4ny25q60nazzkxrqd4xkzn-cntr-1.2.0/bin/cntr
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/8qglbfh1yd4ny25q60nazzkxrqd4xkzn-cntr-1.2.0/bin
patching script interpreter paths in /nix/store/8qglbfh1yd4ny25q60nazzkxrqd4xkzn-cntr-1.2.0
checking for references to /build in /nix/store/8qglbfh1yd4ny25q60nazzkxrqd4xkzn-cntr-1.2.0...
/nix/store/0m0w3s7a0da17qz206rlvs4k3pa58acd-hook
/nix/store/8qglbfh1yd4ny25q60nazzkxrqd4xkzn-cntr-1.2.0

No attempt on x86_64-darwin (full log)
The following builds were skipped because they don't evaluate on x86_64-darwin: breakpointHook, cntr
Partial log (click to expand)

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.


text:
ffmpeg{_3_4,_4,-full}: updates

Motivation for this change
Commits are on top of just-submitted libaom fix PR,
since without that fix newer ffmpeg builds break.
Didn't find changelogs that weren't git commit logs, FWIW.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Assured whether relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

(this should be rebased on top of whatever we end up merging re:libaom over in #52443)

Works for me? (not sure it matters but using git 2.20.1)
Tried using git am on patch generated with git format-patch as well as by github via this URL:
https://github.com/NixOS/nixpkgs/pull/52444/commits/f773cb2e4d82c005fc2476d914dada7f5d01f7eb.patch
However sounds like these cute arrows aren't worth the trouble, was hoping it was a solved problem by now :(.
(and they look terrible in the patch text? eep)

Ah, you are correct, I was actually seeing a bug in tig 2.2's rendering of commits in the commit list.

Okay, well glad to hear it! Dropped them anyway to be safe and potentially easier to read in whatever tooling folks prefer :+1:

@GrahamcOfBorg build ffmpeg

Good to merge, any objections/thoughts?

The darwin build seems to be failing?

Well I built ffmpeg_3_4 on Darwin myself and it built fine.
Something else I just noticed, you have ffmpeg: 4.0.2 -> 4.0.3 in the commits, but ffmpeg = ffmpeg_3 = ffmpeg_3_4 by default. ffmpeg-full however is a 4.* version, which is a bit odd.

Ruhroh, that looks like it was introduced with #52443 sorry! Investigating... :male_detective:

@GrahamcOfBorg build libaom

@GrahamcOfBorg build ffmpeg_4

Hrmm, not sure how to view (or trigger?) darwin builds-- wanted to see if bumping helped the issue...

(still the same error when building)

Thank you for testing this and for the feedback!  What's going on? Hmm..
Did aom build previously? Yes, it appears so: https://hydra.nixos.org/job/nixpkgs/trunk/libaom.x86_64-darwin (for example: https://hydra.nixos.org/build/86083792/log).
If I'm understanding this right, Borg did try building latest on Darwin... and libaom built successfully, with the failure occurring during the ffmpeg build:
[...]
LD      libavdevice/libavdevice.58.dylib
Undefined symbols for architecture x86_64:
  "_OBJC_CLASS_$_NSDictionary", referenced from:
      objc-class-ref in avfoundation.o
  "_OBJC_EHTYPE_$_NSException", referenced from:
      GCC_except_table4 in avfoundation.o
ld: symbol(s) not found for architecture x86_64
clang-5.0: error: linker command failed with exit code 1 (use -v to see invocation)
make: *** [ffbuild/library.mak:103: libavdevice/libavdevice.58.dylib] Error 1
builder for '/nix/store/4633kfnwrbqfb6j0xd5hnj1m40g4kjm0-ffmpeg-full-4.1.drv' failed with exit code 2
error: build of '/nix/store/4633kfnwrbqfb6j0xd5hnj1m40g4kjm0-ffmpeg-full-4.1.drv' failed

And yes indeed ffmpeg_4 currently ("previously") builds on Darwin: https://hydra.nixos.org/job/nixpkgs/trunk/ffmpeg_4.x86_64-darwin (example: https://hydra.nixos.org/build/86416146).  This is expected but just checking :).
@Infinisil are you seeing the same behavior/error as Borg? And if it's not too much trouble: was the last commit (https://github.com/NixOS/nixpkgs/pull/52444/commits/d349cfee88384b4cc353dba8d1154f230520bcc4) necessary to fix libaom for you (if indeed it now builds again)?

Ah yes, seeing the same as ofborg, here's a reference of the build logs:
On 8ac99ab1f4691ed50a65258b2424d4cd0ba8ff72, libaom failing:

[ 80%] Building ASM object /tmp/nix-build-libaom-1.0.0.drv-0/aom/build/asm_objects/aom_dsp_common_ssse3/aom_subpixel_bilinear_ssse3.asm.o
[ 81%] Building ASM object /tmp/nix-build-libaom-1.0.0.drv-0/aom/build/asm_objects/aom_dsp_encoder_ssse3/fwd_txfm_ssse3_x86_64.asm.o
[ 81%] Building ASM object /tmp/nix-build-libaom-1.0.0.drv-0/aom/build/asm_objects/aom_dsp_encoder_ssse3/ssim_opt_x86_64.asm.o
[ 81%] Building ASM object /tmp/nix-build-libaom-1.0.0.drv-0/aom/build/asm_objects/aom_dsp_encoder_ssse3/quantize_ssse3_x86_64.asm.o
[ 81%] Building ASM object /tmp/nix-build-libaom-1.0.0.drv-0/aom/build/asm_objects/aom_dsp_encoder_avx/quantize_avx_x86_64.asm.o
[ 82%] Building ASM object /tmp/nix-build-libaom-1.0.0.drv-0/aom/build/asm_objects/aom_ports/emms.asm.o
[ 82%] Building ASM object /tmp/nix-build-libaom-1.0.0.drv-0/aom/build/asm_objects/aom_av1_encoder_sse2/dct_sse2.asm.o
[ 82%] Building ASM object /tmp/nix-build-libaom-1.0.0.drv-0/aom/build/asm_objects/aom_av1_encoder_sse2/error_sse2.asm.o
[ 82%] Building ASM object /tmp/nix-build-libaom-1.0.0.drv-0/aom/build/asm_objects/aom_av1_encoder_sse2/temporal_filter_apply_sse2.asm.o
Scanning dependencies of target aom
[ 82%] Building C object CMakeFiles/aom.dir/aom/src/aom_codec.c.o
[ 82%] Building C object CMakeFiles/aom.dir/config/aom_config.c.o
[ 82%] Building C object CMakeFiles/aom.dir/aom/src/aom_decoder.c.o
[ 83%] Building C object CMakeFiles/aom.dir/aom/src/aom_encoder.c.o
[ 83%] Building C object CMakeFiles/aom.dir/aom/src/aom_image.c.o
[ 83%] Building C object CMakeFiles/aom.dir/aom/src/aom_integer.c.o
[ 83%] Linking C shared library libaom.dylib
[ 83%] Built target aom
Scanning dependencies of target set_maps
Scanning dependencies of target lightfield_decoder
Scanning dependencies of target scalable_encoder
[ 83%] Building C object CMakeFiles/set_maps.dir/examples/set_maps.c.o
[ 83%] Building C object CMakeFiles/scalable_encoder.dir/examples/scalable_encoder.c.o
[ 83%] Building C object CMakeFiles/lightfield_decoder.dir/examples/lightfield_decoder.c.o
[ 84%] Linking CXX executable examples/scalable_encoder
[ 84%] Linking CXX executable examples/lightfield_decoder
[ 84%] Linking CXX executable examples/set_maps
Undefined symbols for architecture x86_64:
  "_aom_read_obu_header", referenced from:
      _obudec_read_obu_header_and_size in obudec.c.o
ld: symbol(s) not found for architecture x86_64
clang-5.0: error: linker command failed with exit code 1 (use -v to see invocation)
make[2]: *** [CMakeFiles/lightfield_decoder.dir/build.make:147: examples/lightfield_decoder] Error 1
make[1]: *** [CMakeFiles/Makefile2:6180: CMakeFiles/lightfield_decoder.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....
[ 84%] Built target scalable_encoder
[ 84%] Built target set_maps
make: *** [Makefile:130: all] Error 2
builder for '/nix/store/9s8fdm2b051j6kxx1z0ki2a5r98zn07c-libaom-1.0.0.drv' failed with exit code 2
cannot build derivation '/nix/store/9q1cd26q3kz6igknmrlr97z53dyzx1gh-ffmpeg-full-4.1.drv': 1 dependencies couldn't be built
error: build of '/nix/store/9q1cd26q3kz6igknmrlr97z53dyzx1gh-ffmpeg-full-4.1.drv' failed

On d9c1dd28027343ff8ebc145f809d42f969836e59, libaom failing:

[ 72%] Linking C shared library libaom.dylib
[ 72%] Built target aom
Scanning dependencies of target lightfield_bitstream_parsing
Scanning dependencies of target set_maps
Scanning dependencies of target scalable_encoder
Scanning dependencies of target test_aom_common
[ 72%] Building C object CMakeFiles/set_maps.dir/examples/set_maps.c.o
[ 72%] Building C object CMakeFiles/scalable_encoder.dir/examples/scalable_encoder.c.o
[ 72%] Building C object CMakeFiles/lightfield_bitstream_parsing.dir/examples/lightfield_bitstream_parsing.c.o
[ 72%] Building CXX object CMakeFiles/test_aom_common.dir/test/aom_integer_test.cc.o
/tmp/nix-build-libaom-1.0.0.errata.1.drv-0/aom/examples/lightfield_bitstream_parsing.c
:
393:31: warning
: implicit conversion loses integer precision: 'long long' to 'int' [-Wshorten-64-to-32]
  int num_tile_lists = tl_pts - pts;

      ~~~~~~~~~~~~~~   ~~~~~~~^~~~~

1
 warning
 generated.
[ 72%] Linking CXX executable examples/set_maps
[ 73%] Linking CXX executable examples/scalable_encoder
[ 73%] Linking CXX executable examples/lightfield_bitstream_parsing
Undefined symbols for architecture x86_64:
  "_aom_read_obu_header", referenced from:
      _obudec_read_obu_header_and_size in obudec.c.o
  "_aom_wb_write_literal", referenced from:
      _process_tile_list in lightfield_bitstream_parsing.c.o
  "_aom_wb_write_unsigned_literal", referenced from:
      _process_tile_list in lightfield_bitstream_parsing.c.o
ld: symbol(s) not found for architecture x86_64
clang-5.0: error: linker command failed with exit code 1 (use -v to see invocation)
make[2]: *** [CMakeFiles/lightfield_bitstream_parsing.dir/build.make:161: examples/lightfield_bitstream_parsing] Error 1
make[1]: *** [CMakeFiles/Makefile2:432: CMakeFiles/lightfield_bitstream_parsing.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....
[ 73%] Built target scalable_encoder
[ 73%] Built target set_maps
[ 74%] Building CXX object CMakeFiles/test_aom_common.dir/test/decode_test_driver.cc.o
[ 74%] Building CXX object CMakeFiles/test_aom_common.dir/test/test_vectors.cc.o
[ 74%] Built target test_aom_common
make: *** [Makefile:130: all] Error 2
builder for ‘/nix/store/szw9i81ss8a9a5fkmql8hf8cvyfhxlii-libaom-1.0.0.errata.1.drv’ failed with exit code 2
cannot build derivation ‘/nix/store/z2h2m1fv4fdd9vyn2x3j8yq28159kz38-ffmpeg-full-4.1.drv’: 1 dependencies couldn't be built
error: build of ‘/nix/store/z2h2m1fv4fdd9vyn2x3j8yq28159kz38-ffmpeg-full-4.1.drv’ failed

On d349cfee88384b4cc353dba8d1154f230520bcc4, libaom succeeding, ffmpeg-full failing:

skipping strip -x libswresample/x86/rematrix.o
CC      libswresample/x86/rematrix_init.o
X86ASM  libswresample/x86/resample.o
STRIP   libswresample/x86/resample.o
skipping strip -x libswresample/x86/resample.o
CC      libswresample/x86/resample_init.o
GEN     libswresample/libswresample.ver
LD      libswresample/libswresample.3.dylib
LD      libavcodec/libavcodec.58.dylib
LD      libavformat/libavformat.58.dylib
CC      libavresample/audio_convert.o
CC      libavresample/audio_data.o
CC      libavresample/audio_mix.o
CC      libavresample/audio_mix_matrix.o
CC      libavresample/dither.o
CC      libavresample/options.o
CC      libavresample/resample.o
CC      libavresample/utils.o
X86ASM  libavresample/x86/audio_convert.o
STRIP   libavresample/x86/audio_convert.o
skipping strip -x libavresample/x86/audio_convert.o
CC      libavresample/x86/audio_convert_init.o
X86ASM  libavresample/x86/audio_mix.o
STRIP   libavresample/x86/audio_mix.o
skipping strip -x libavresample/x86/audio_mix.o
CC      libavresample/x86/audio_mix_init.o
X86ASM  libavresample/x86/dither.o
STRIP   libavresample/x86/dither.o
skipping strip -x libavresample/x86/dither.o
CC      libavresample/x86/dither_init.o
GEN     libavresample/libavresample.ver
LD      libavresample/libavresample.4.dylib
LD      libavfilter/libavfilter.7.dylib
LD      libavdevice/libavdevice.58.dylib
Undefined symbols for architecture x86_64:
  "_OBJC_CLASS_$_NSDictionary", referenced from:
      objc-class-ref in avfoundation.o
  "_OBJC_EHTYPE_$_NSException", referenced from:
      GCC_except_table4 in avfoundation.o
ld: symbol(s) not found for architecture x86_64
clang-5.0: error: linker command failed with exit code 1 (use -v to see invocation)
make: *** [ffbuild/library.mak:103: libavdevice/libavdevice.58.dylib] Error 1
builder for ‘/nix/store/4633kfnwrbqfb6j0xd5hnj1m40g4kjm0-ffmpeg-full-4.1.drv’ failed with exit code 2
error: build of ‘/nix/store/4633kfnwrbqfb6j0xd5hnj1m40g4kjm0-ffmpeg-full-4.1.drv’ failed

Darwin failure looks awfully similar to this:
https://github.com/NixOS/nixpkgs/pull/51027#issuecomment-441632673
Let's see if the same fix works here? (commit coming soon)

Well ofborg still says it failed, or am I misinterpreting something

authors: Infinisil dtzWill ivan


text:
opencascade-occt: init at 7.3.0p2

Just a package of the official OpenCASCADE OCCT (not OCE).
Motivation for this change
I was playing a bit with the library, and wanted to store/publish the Nix-expression I wrote along the way somewhere… Later it may be possible to let building FreeCAD, KiCAD, and OpenSceneGraph with either of these distributions (OCCT or OCE). But for now this is just it.
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[X] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[X] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Assured whether relevant documentation is up to date
[X] Fits CONTRIBUTING.md.

That's nice that you can use a tag! I got it down to just changing the version line.

@GrahamcOfBorg build opencascade-occt

@GrahamcOfBorg build opencascade-occt

authors: amiloradovsky ryantm


text:
libelf: Fix cross-compile by adding glibc as a native build input.

For cross-compiling, native glibc is needed for the "gencat" program.
Nnote: it is not possible to test this with the current nixpkgs due to general cross-compile regressions.

Merged to staging (see 4b9729f9d9eea4feb751565370a3dd1d4197f88f).


text:
adafruit-ampy: init at 1.0.7

Motivation for this change
Things done

[X] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[X] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[X] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[X] Tested execution of all binary files (usually in ./result/bin/)
[X] Determined the impact on package closure size (by running nix path-info -S before and after)
[X] Assured whether relevant documentation is up to date
[X] Fits CONTRIBUTING.md.

@FRidh Fixed :-)

This pull request has been mentioned on Nix community. There might be relevant details there:
https://discourse.nixos.org/t/prs-already-reviewed/2617/52

authors: etu nixos-discourse


text:
disk_indicator: 2014-05-19 -> 2018-12-18

Motivation for this change
Hi ! I needed the newer disk_indicator, so I've updated the one available.
Things done

[X] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[X] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[X] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[X] Tested execution of all binary files (usually in ./result/bin/)
[X] Determined the impact on package closure size (by running nix path-info -S before and after)
[X] Ensured that relevant documentation is up to date
[X] Fits CONTRIBUTING.md.

@cyplo, I just realized that this is your first PR, so I would also like to welcome you to our community and thank you for your contribution.

Heya @peterhoeg - thanks so much for the review, this helps a lot :) Will fix and ping you again, have a great day :)

welcome @cyplo :) let us know if you need any help moving this PR forward!

Thank you :) I just honestly am swamped right now with other work and been putting this off.
If anyone wants to pick this up - feel free. Also - if anyone wants to pair program on this, via a call or something - please let me know :)

We still carry the old version. No idea if anybody is using this though.

I don't need this one anymore tbh - do we have any stats on most recent downloads from cache or something we could use to assess @peterhoeg ?

authors: cyplo mmahut peterhoeg


text:
nixos/gnupg: Add gpg to systemPackages

Motivation for this change
When the gpgAgent is enabled, the gpg package is installed in the store but not as systemPackage.
This commit also installs it as systemPackage which is reasonable because the agent is also enabled in the system.
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[X] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[X] Fits CONTRIBUTING.md.

Notify maintainers
cc @peti @fpletz @Infinisil

This makes sense, thank you.

authors: duhirsch mmahut


text:
pythonPackages.cvxpy: init at 1.0.25

Motivation for this change
Add dependency for upcoming qiskit package #78772 @jonringer
Depends on #78897
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[ ] macOS
[x] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

please fix eval

@GrahamcOfBorg eval

please rebase

Rebased, but still waiting on #78897

merged, sorry about that

@GrahamcOfBorg eval

@GrahamcOfBorg build python37Packages.cvxpy python38Packages.cvxpy

bot builds fail b/c scs package uses mkl (non-free).

authors: FRidh drewrisinger jonringer


text:
home-assistant: 0.109.6 → 0.110.1

Motivation for this change
New upstream release.
https://www.home-assistant.io/blog/2020/05/20/release-110/
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

@Mic92

The tests are currently failing
hass: must succeed: curl --fail -H 'x-ha-access: some_secret' http://localhost:8123/api/
hass # [    9.852476] hass[750]: 2020-05-20 22:00:42 WARNING (MainThread) [homeassistant.components.http.ban] Login attempt or request with invalid authentication from 127.0.0.1
hass # curl: (22) The requested URL returned error: 401 Unauthorized
hass: output:
Test "Check that Home Assistant's web interface and API can be reached" failed with error: "command `curl --fail -H 'x-ha-access: some_secret' http://localhost:8123/api/` failed (exit code 22)"
error: command `curl --fail -H 'x-ha-access: some_secret' http://localhost:8123/api/` failed (exit code 22)

The tests were already broken with 0.109.6, so the breakage wasn't introduced with this pull.

The frontend module already has the right version.