text:
chore(feature-flags): re-add debug log for all features evaluation"

Issue #, if available: #563
Description of changes:

Checklist

[ ] Meet tenets criteria
[ ] Update tests
[ ] Update docs
[ ] PR title follows conventional commit semantics

Breaking change checklist

RFC issue #:

[ ] Migration process documented
[ ] Implement warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Codecov Report

Merging #590 (7a76582) into develop (f0a852a) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           develop     #590   +/-   ##
========================================
  Coverage    99.95%   99.95%
========================================
  Files          113      113
  Lines         4533     4534    +1
  Branches       245      245
========================================
+ Hits          4531     4532    +1
  Partials         2        2

Impacted Files
Coverage Δ

...owertools/utilities/feature_flags/feature_flags.py
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0a852a...7a76582. Read the comment docs.

authors: codecov-commenter heitorlessa


text:
rewrite extension client and upgrade tokio

replace lambda-extension crate with inline extension client to reduce binary size by another 1MB.
-rwxr-xr-x  1 sunhua  staff   3.7M Jan  7 13:22 target/release/lambda-adapter

Upgrade tokio to 1.24 for improved performance
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

An extension tell Lambda Service what events it's interested in by specifying the event names when it registers. Lambda will only send those events to the extension.
The adapter specified no event names at registration. So Lambda will not return any events to it. The NEXT call will block forever.

lambda-extension crate is a bit bloated. Probably should split into 3 crates: minimum base extension crate for extension api, logs api crate, and telemetry api crate.

source: gharchive/pull-request

repo: awslabs/aws-lambda-web-adapter

license_type: permissive

license_source: github-api


text:
Support additional parameters for Package command

Support additional package params
I wish SAM CLI would support the --kms-key-id and --s3-prefix options on the sam package command.  We use the kms-key-id to encrypt our packages when pushing to s3.
Proposal

Add 2 new parameters to the sam package command for --kms-key-id and --s3-prefix.
Pass those arguments through to the underlying aws cloudformation package command

sam package --template-file /path_to_template/template.json --s3-bucket bucket-name --kms-key-id <some-key> --output-template-file packaged-template.json

We directly shell out to the AWS CLI for this command, so it's not supported there either. If you're able to get these working with aws cloudformation package but not sam package, please let me know the environments and versions as that would be an odd issue indeed.
That said, will look at this as this is definitely a good thing to support.

You're right, it does work.  I guess I was misled because the documentation explicitly references the --s3-bucket param.  I wonder if it would be possible/helpful to extend the docs to state that all parameters of aws cloudformation package are supported.
Tested command:
sam package --s3-bucket artifact-store-123456789012 --template-file main.yml --kms-key-id     arn:aws:kms:us-east-1:123456789012:key/11111111-1111-1111-1111-111111111111 --s3-prefix test

Understood - we're actively working on the long term fix for this, which will include documentation updates. Going to go ahead and close this, feel free to reopen if you have further issues.

source: gharchive/issue

repo: awslabs/aws-sam-cli


text:
Can I init a new function in exist folder not new folder with name(sam-app)

Describe your idea/feature/enhancement
Provide a clear description. Ex. I wish SAM CLI would [...]
I want to init a function in exist folder, not create a new sam-app folder.

Im not sure if we want to support this as this may cause damage to existing folder.

Indeed, there are other features we have in mind that would help to add to existing projects, but if you really need an existing folder to have the contents of a sam init, would recommend you create a temporary folder, copy the contents, and delete it.

authors: awood45 sriram-mv theowenyoung


text:
Add the option to read data from json file for command 'sam local generate-event kinesis'

Add the option to read data from json file for command 'sam local generate-event kinesis', since now see only option -d with which string should be set from command line.

Thanks for the feature request. Using #427 to track this.

authors: alex-semenyuk sanathkr


text:
invalid bind mount spec

When trying to invoke "HelloWorld" from Samples I get the following error. How do I fix it. Below is the output. I am running Docker Toolbox on Windows7.
C:\Users\gaurav_kamdar\go\src\github.com\awslabs\aws-sam-local\test\templates\sam-official-samples\hello_world>sam local invoke "HelloWorld" -e event.json
2017/08/24 14:20:25 Successfully parsed template.yaml
←[34mINFO←[0m[0000] Unable to use system certificate pool: crypto/x509: system root pool is not available on Windows
2017/08/24 14:20:25 Connected to Docker 1.28
←[34mINFO←[0m[0000] Unable to use system certificate pool: crypto/x509: system root pool is not available on Windows
2017/08/24 14:20:25 Fetching lambci/lambda:nodejs4.3 image for nodejs4.3 runtime...
nodejs4.3: Pulling from lambci/lambda
←[1B84c367d8: Already exists
←[1Bf5aea2af: Already exists
←[1BDigest: sha256:fe7fd26840b4f06ba6626148f8bd234a6da21cd4fa2354dbc7c78be2d9bd5e3111kB/2.011kBB
Status: Downloaded newer image for lambci/lambda:nodejs4.3
2017/08/24 14:20:26 Invoking index.handler (nodejs4.3)
2017/08/24 14:20:26 Could not invoke function: Error response from daemon: invalid bind mount spec "C:/Users/gaurav_kamdar/go/src/github.com/awslabs/aws-sam-local
/test/templates/sam-official-samples/hello_world:/var/task:ro": invalid volume specification: 'C:/Users/gaurav_kamdar/go/src/github.com/awslabs/aws-sam-local/test
/templates/sam-official-samples/hello_world:/var/task:ro'

Are you using cygwin or git bash? Does this reproduce in cmd.exe or powershell?

I'm facing the same problem on Windows 10 Home
2017/08/26 21:59:36 Could not invoke function: Error response from daemon: invalid bind mount spec "C:\Users\John\AppData\Local\Temp\aws-sam-local-1503781175721651700:/var/task:ro": invalid volume specification: 'C:\Users\John\AppData\Local\Temp\aws-sam-local-1503781175721651700:/var/task:ro'
aws-sam-local-1503781175721651700 exists on the local file system, but I assume SAM local is writing to that
I'm using docker for the first time, so apologies if some of the responses are nonsense
I'm using git bash which was installed with the docker toolkit - I've tried cmd and powershell, but with both those I get
2017/08/27 10:06:53 Running AWS SAM projects locally requires Docker. Have you got it installed?
Is there a way of getting a list of shared directories from Docker Toolbox, all I could find in the docs was for listing shared directories in a container and the container is not running.  VirtualBox for default has a folder of name c:/Users and path \?\c:\Users with auto-mount and full access.

I am having the same problem on Docker toolbox and windows 7.

I figured out that if you set --docker-volume-basedir \c\Users when invoking, it works.

Yeah, that's the solution. It is also documented in README file

kudos

I facing the same issue when trying to run the sample HelloWorld. I am running Docker Toolbox on Windows8.1 Pro. Sam Version 0.3.0
Output :  (with out --docker-volume-basedir)
C:\Python27\Lib\site-packages\samcli\local\init\templates\cookiecutter-aws-sam-hello-java{{cookiecutter.project_name}}>sam local start-api
2018-06-06 16:11:24 Mounting HelloWorldFunction at http://127.0.0.1:3000/hello [GET]
2018-06-06 16:11:24 You can now browse to the above endpoints to invoke your functions. You do not need to restart/reload SAM CLI while working on your functions changes will be reflected instantly/automatically. You only need to restart SAM CLI if you update your AWS SAM template
2018-06-06 16:11:24  * Running on http://127.0.0.1:3000/ (Press CTRL+C to quit)
2018-06-06 16:11:30 Invoking helloworld.App::handleRequest (java8)
2018-06-06 16:11:30 Found credentials in shared credentials file: ~/.aws/credentials
2018-06-06 16:11:30 Decompressing C:\Python27\Lib\site-packages\samcli\local\init\templates\cookiecutter-aws-sam-hello-java{{cookiecutter.project_name}}\target\HelloWorld-1.0.jar
Fetching lambci/lambda:java8 Docker container image......
2018-06-06 16:11:34 Mounting c:\users\lenovo2\appdata\local\temp\tmp2vg4ry as /var/task:ro inside runtime container
[2018-06-06 16:11:34,845] ERROR in app: Exception on /hello [GET]
Traceback (most recent call last):
File "c:\python27\lib\site-packages\flask\app.py", line 1982, in wsgi_app
response = self.full_dispatch_request()
File "c:\python27\lib\site-packages\flask\app.py", line 1614, in full_dispatch_request
rv = self.handle_user_exception(e)
File "c:\python27\lib\site-packages\flask\app.py", line 1517, in handle_user_exception
reraise(exc_type, exc_value, tb)
File "c:\python27\lib\site-packages\flask\app.py", line 1612, in full_dispatch_request
rv = self.dispatch_request()
File "c:\python27\lib\site-packages\flask\app.py", line 1598, in dispatch_request
return self.view_functionsrule.endpoint
File "c:\python27\lib\site-packages\samcli\local\apigw\service.py", line 161, in _request_handler
self.lambda_runner.invoke(route.function_name, event, stdout=stdout_stream, stderr=self.stderr)
File "c:\python27\lib\site-packages\samcli\commands\local\lib\local_lambda.py", line 80, in invoke
stdout=stdout, stderr=stderr)
File "c:\python27\lib\site-packages\samcli\local\lambdafn\runtime.py", line 83, in invoke
self._container_manager.run(container)
File "c:\python27\lib\site-packages\samcli\local\docker\manager.py", line 61, in run
container.create()
File "c:\python27\lib\site-packages\samcli\local\docker\container.py", line 110, in create
real_container = self.docker_client.containers.create(self._image, **kwargs)
File "c:\python27\lib\site-packages\docker\models\containers.py", line 824, in create
resp = self.client.api.create_container(**create_kwargs)
File "c:\python27\lib\site-packages\docker\api\container.py", line 410, in create_container
return self.create_container_from_config(config, name)
File "c:\python27\lib\site-packages\docker\api\container.py", line 421, in create_container_from_config
return self._result(res, True)
File "c:\python27\lib\site-packages\docker\api\client.py", line 231, in _result
self._raise_for_status(response)
File "c:\python27\lib\site-packages\docker\api\client.py", line 227, in _raise_for_status
raise create_api_error_from_http_exception(e)
File "c:\python27\lib\site-packages\docker\errors.py", line 31, in create_api_error_from_http_exception
raise cls(e, response=response, explanation=explanation)
APIError: 500 Server Error: Internal Server Error ("invalid volume specification: 'c:\users\lenovo2\appdata\local\temp\tmp2vg4ry:/var/task:ro'")
2018-06-06 16:11:34 127.0.0.1 - - [06/Jun/2018 16:11:34] "GET /hello HTTP/1.1" 502 -
2018-06-06 16:11:35 127.0.0.1 - - [06/Jun/2018 16:11:35] "GET /favicon.ico HTTP/1.1" 403 -
Output :  (with --docker-volume-basedir)
C:\Python27\Lib\site-packages\samcli\local\init\templates\cookiecutter-aws-sam-hello-java{{cookiecutter.project_name}}>sam local start-api --docker-volume-basedir \c\Users
2018-06-06 16:15:10 Mounting HelloWorldFunction at http://127.0.0.1:3000/hello [GET]
2018-06-06 16:15:10 You can now browse to the above endpoints to invoke your functions. You do not need to restart/reload SAM CLI while working on your functions changes will be reflected instantly/automatically. You only need to restart SAM CLI if you update your AWS SAM template
2018-06-06 16:15:10  * Running on http://127.0.0.1:3000/ (Press CTRL+C to quit)
2018-06-06 16:15:14 Invoking helloworld.App::handleRequest (java8)
2018-06-06 16:15:14 Found credentials in shared credentials file: ~/.aws/credentials
Fetching lambci/lambda:java8 Docker container image......
2018-06-06 16:15:17 Mounting C:\c\Users\target\HelloWorld-1.0.jar as /var/task:ro inside runtime container
[2018-06-06 16:15:18,585] ERROR in app: Exception on /hello [GET]
Traceback (most recent call last):
File "c:\python27\lib\site-packages\flask\app.py", line 1982, in wsgi_app
response = self.full_dispatch_request()
File "c:\python27\lib\site-packages\flask\app.py", line 1614, in full_dispatch_request
rv = self.handle_user_exception(e)
File "c:\python27\lib\site-packages\flask\app.py", line 1517, in handle_user_exception
reraise(exc_type, exc_value, tb)
File "c:\python27\lib\site-packages\flask\app.py", line 1612, in full_dispatch_request
rv = self.dispatch_request()
File "c:\python27\lib\site-packages\flask\app.py", line 1598, in dispatch_request
return self.view_functionsrule.endpoint
File "c:\python27\lib\site-packages\samcli\local\apigw\service.py", line 161, in _request_handler
self.lambda_runner.invoke(route.function_name, event, stdout=stdout_stream, stderr=self.stderr)
File "c:\python27\lib\site-packages\samcli\commands\local\lib\local_lambda.py", line 80, in invoke
stdout=stdout, stderr=stderr)
File "c:\python27\lib\site-packages\samcli\local\lambdafn\runtime.py", line 83, in invoke
self._container_manager.run(container)
File "c:\python27\lib\site-packages\samcli\local\docker\manager.py", line 61, in run
container.create()
File "c:\python27\lib\site-packages\samcli\local\docker\container.py", line 110, in create
real_container = self.docker_client.containers.create(self._image, **kwargs)
File "c:\python27\lib\site-packages\docker\models\containers.py", line 824, in create
resp = self.client.api.create_container(**create_kwargs)
File "c:\python27\lib\site-packages\docker\api\container.py", line 410, in create_container
return self.create_container_from_config(config, name)
File "c:\python27\lib\site-packages\docker\api\container.py", line 421, in create_container_from_config
return self._result(res, True)
File "c:\python27\lib\site-packages\docker\api\client.py", line 231, in _result
self._raise_for_status(response)
File "c:\python27\lib\site-packages\docker\api\client.py", line 227, in _raise_for_status
raise create_api_error_from_http_exception(e)
File "c:\python27\lib\site-packages\docker\errors.py", line 31, in create_api_error_from_http_exception
raise cls(e, response=response, explanation=explanation)
APIError: 500 Server Error: Internal Server Error ("invalid volume specification: 'C:\c\Users\target\HelloWorld-1.0.jar:/var/task:ro'")
2018-06-06 16:15:18 127.0.0.1 - - [06/Jun/2018 16:15:18] "GET /hello HTTP/1.1" 502 -
2018-06-06 16:15:18 127.0.0.1 - - [06/Jun/2018 16:15:18] "GET /favicon.ico HTTP/1.1" 403 -

authors: JohnHoward9 deividi86 gkamdar kaarthikeyansp sanathkr uvaisTrivecta


text:
DynamoDB Xamarin Example doesn't work out of the box

It would be great if these samples worked straight out of the box, so I am going to document the issues I have faced / am facing with the Xamarin DynamoDB example.
There isn't a readme file, as the repository description suggests.
Firstly, I needed to add using Amazon; to contact.cs.
DoneEntry is not recognised in DoneEntryRenderer.cs
FacebookLoginButton is not recognised in FacebookLoginButtonRenderer.cs
I'll keep updating as I progress...
NB: I am using Visual Studio 2015

Using Xamarin Studio on OSX, I am now getting this error:

the type or namespace name 'facebook' does not exist in the namespace 'xamarin'

?

repo: awslabs/aws-sdk-net-samples

license_source: bigquery


text:
Setting s3 public access block configuration fails when all options are false

Describe the bug
When using the S3 put_public_access_block method, if all four options options are set to false the request will fail. For example:
use aws_sdk_s3 as s3;

#[tokio::main]
#[allow(clippy::result_large_err)]
async fn main() -> Result<(), s3::Error> {
    let region = "us-east-1";
    let bucket = "CHANGE_ME";
    let config = aws_config::from_env().load().await;
    let client = s3::Client::new(&config);
    client
        .create_bucket()
        .bucket(bucket)
        .create_bucket_configuration(
            s3::types::CreateBucketConfiguration::builder()
                .location_constraint(s3::types::BucketLocationConstraint::from(region))
                .build(),
        )
        .send()
        .await?;
    client
        .put_public_access_block()
        .bucket(bucket)
        .public_access_block_configuration(
            s3::types::PublicAccessBlockConfiguration::builder()
                .block_public_acls(false) // <-------- setting all four options to false triggers the bug
                .ignore_public_acls(false) // <-------
                .block_public_policy(false) // <------
                .restrict_public_buckets(false) // <--
                .build(),
        )
        .send()
        .await?;
    Ok(())
}

If at least one of four PublicAccessBlockConfiguration options is set to true then the request will succeed.
Expected Behavior
Running the code above should not produce any errors and result in these options all being disabled for the S3 bucket:

Current Behavior
The code above produces an error:
Error: Unhandled(Unhandled { source: ErrorMetadata { code: Some("InvalidRequest"), message: Some("Must specify at least one configuration."), extras: Some({"s3_extended_request_id": "7VTi3scszh1zFOtXoEMM6NXIjKaSvbsV7yu9l5ECtcJOuaH0PPwaRnEmVwNXgYtZI2URi1FiwVE=", "aws_request_id": "Q2AZ3BYQM6EYQC3Y"}) }, meta: ErrorMetadata { code: Some("InvalidRequest"), message: Some("Must specify at least one configuration."), extras: Some({"s3_extended_request_id": "7VTi3scszh1zFOtXoEMM6NXIjKaSvbsV7yu9l5ECtcJOuaH0PPwaRnEmVwNXgYtZI2URi1FiwVE=", "aws_request_id": "Q2AZ3BYQM6EYQC3Y"}) } })

Reproduction Steps
Run the code above (after changing bucket to an unused S3 bucket name).
Possible Solution
I believe the problem is due to the ser_public_access_block_configuration function having if conditions which skips serializing the options that are false. This function should probably just output the options irrespective of whether they are true or false.
Additional Information/Context
To confirm it is valid to make a request where all 4 options are false you can run the following aws-cli command:
aws s3api put-public-access-block --bucket CHANGE_ME --public-access-block-configuration 'BlockPublicAcls=false,IgnorePublicAcls=false,BlockPublicPolicy=false,RestrictPublicBuckets=false'

Version
├── aws-config v0.55.3
│   ├── aws-credential-types v0.55.3
│   │   ├── aws-smithy-async v0.55.3
│   │   ├── aws-smithy-types v0.55.3
│   ├── aws-http v0.55.3
│   │   ├── aws-credential-types v0.55.3 (*)
│   │   ├── aws-smithy-http v0.55.3
│   │   │   ├── aws-smithy-eventstream v0.55.3
│   │   │   │   ├── aws-smithy-types v0.55.3 (*)
│   │   │   ├── aws-smithy-types v0.55.3 (*)
│   │   ├── aws-smithy-types v0.55.3 (*)
│   │   ├── aws-types v0.55.3
│   │   │   ├── aws-credential-types v0.55.3 (*)
│   │   │   ├── aws-smithy-async v0.55.3 (*)
│   │   │   ├── aws-smithy-client v0.55.3
│   │   │   │   ├── aws-smithy-async v0.55.3 (*)
│   │   │   │   ├── aws-smithy-http v0.55.3 (*)
│   │   │   │   ├── aws-smithy-http-tower v0.55.3
│   │   │   │   │   ├── aws-smithy-http v0.55.3 (*)
│   │   │   │   │   ├── aws-smithy-types v0.55.3 (*)
│   │   │   │   ├── aws-smithy-types v0.55.3 (*)
│   │   │   ├── aws-smithy-http v0.55.3 (*)
│   │   │   ├── aws-smithy-types v0.55.3 (*)
│   ├── aws-sdk-sso v0.28.0
│   │   ├── aws-credential-types v0.55.3 (*)
│   │   ├── aws-endpoint v0.55.3
│   │   │   ├── aws-smithy-http v0.55.3 (*)
│   │   │   ├── aws-smithy-types v0.55.3 (*)
│   │   │   ├── aws-types v0.55.3 (*)
│   │   ├── aws-http v0.55.3 (*)
│   │   ├── aws-sig-auth v0.55.3
│   │   │   ├── aws-credential-types v0.55.3 (*)
│   │   │   ├── aws-sigv4 v0.55.3
│   │   │   │   ├── aws-smithy-eventstream v0.55.3 (*)
│   │   │   │   ├── aws-smithy-http v0.55.3 (*)
│   │   │   ├── aws-smithy-eventstream v0.55.3 (*)
│   │   │   ├── aws-smithy-http v0.55.3 (*)
│   │   │   ├── aws-types v0.55.3 (*)
│   │   ├── aws-smithy-async v0.55.3 (*)
│   │   ├── aws-smithy-client v0.55.3 (*)
│   │   ├── aws-smithy-http v0.55.3 (*)
│   │   ├── aws-smithy-http-tower v0.55.3 (*)
│   │   ├── aws-smithy-json v0.55.3
│   │   │   └── aws-smithy-types v0.55.3 (*)
│   │   ├── aws-smithy-types v0.55.3 (*)
│   │   ├── aws-types v0.55.3 (*)
│   ├── aws-sdk-sts v0.28.0
│   │   ├── aws-credential-types v0.55.3 (*)
│   │   ├── aws-endpoint v0.55.3 (*)
│   │   ├── aws-http v0.55.3 (*)
│   │   ├── aws-sig-auth v0.55.3 (*)
│   │   ├── aws-smithy-async v0.55.3 (*)
│   │   ├── aws-smithy-client v0.55.3 (*)
│   │   ├── aws-smithy-http v0.55.3 (*)
│   │   ├── aws-smithy-http-tower v0.55.3 (*)
│   │   ├── aws-smithy-json v0.55.3 (*)
│   │   ├── aws-smithy-query v0.55.3
│   │   │   ├── aws-smithy-types v0.55.3 (*)
│   │   ├── aws-smithy-types v0.55.3 (*)
│   │   ├── aws-smithy-xml v0.55.3
│   │   ├── aws-types v0.55.3 (*)
│   ├── aws-smithy-async v0.55.3 (*)
│   ├── aws-smithy-client v0.55.3 (*)
│   ├── aws-smithy-http v0.55.3 (*)
│   ├── aws-smithy-http-tower v0.55.3 (*)
│   ├── aws-smithy-json v0.55.3 (*)
│   ├── aws-smithy-types v0.55.3 (*)
│   ├── aws-types v0.55.3 (*)
├── aws-sdk-s3 v0.28.0
│   ├── aws-credential-types v0.55.3 (*)
│   ├── aws-endpoint v0.55.3 (*)
│   ├── aws-http v0.55.3 (*)
│   ├── aws-sig-auth v0.55.3 (*)
│   ├── aws-sigv4 v0.55.3 (*)
│   ├── aws-smithy-async v0.55.3 (*)
│   ├── aws-smithy-checksums v0.55.3
│   │   ├── aws-smithy-http v0.55.3 (*)
│   │   ├── aws-smithy-types v0.55.3 (*)
│   ├── aws-smithy-client v0.55.3 (*)
│   ├── aws-smithy-eventstream v0.55.3 (*)
│   ├── aws-smithy-http v0.55.3 (*)
│   ├── aws-smithy-http-tower v0.55.3 (*)
│   ├── aws-smithy-json v0.55.3 (*)
│   ├── aws-smithy-types v0.55.3 (*)
│   ├── aws-smithy-xml v0.55.3 (*)
│   ├── aws-types v0.55.3 (*)

### Environment details (OS name and version, etc.)

macOS 12.5.1, rustc 1.71.0-nightly

### Logs

_No response_

A workaround is to use the delete_public_access_block method:
client
    .delete_public_access_block()
    .bucket(bucket)
    .send()
    .await?;

@RobbieClarken thanks for submitting such a well-written issue report. I've seen similar failures with S3 APIs that have funky handling of default values. S3 seems to often treat null and false as different values, which leads to stuff like this.
To whomever is tasked with fixing this:

We should look into how other SDKs are handling this.

This issue occurs because the S3 model incorrectly marks these fields as required when they are optional. We need to either wait for the updated S3 model or add a customization on our side to automatically apply the clientOptionalTrait

Sorry for the delay. This issue should be fixed in v0.38

Testing this in the latest version and it now work without any errors. Closing this issue

authors: RobbieClarken Velfi jmklix rcoh

repo: awslabs/aws-sdk-rust


text:
Migrate to java events

Issue #, if available:
Description of changes:
Migrated to Java-events lib.
The build fails because the V4 of Java-events is not released yet.
By submitting this pull request

[x] I confirm that my contribution is made under the terms of the Apache 2.0 license.
[x] I confirm that I've made a best effort attempt to update all relevant documentation.

We identified new issues on unchanged lines of code. Navigate to the Amazon CodeGuru Reviewer console to view the recommendations to fix them.

Thanks for all the work you put into it @mbfreder! Could you please rebase on main to resolve the conflicts? I will go through it in detail afterwards...

Done.

authors: deki mbfreder sapessi

repo: awslabs/aws-serverless-java-container


text:
EC2 Unallocated Elastic IP cost optimitzation query

Issue #, if available:
Unallocated Elastic IP Cost
Description of changes:
added EC2 Unallocated Elastic IP Query to Cost Optimization Section
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Needs to be reviewed in fork - will reopen when ready

repo: awslabs/aws-well-architected-labs


text:
"DBInstanceClass" parameter is interpreted as a secure string

cfn-lint version: (cfn-lint --version)
cfn-lint 0.10.1
Description of issue.
I was prompted to add NoEcho to my DBIstanceClass Parameter in CloudFormation
14:26 MacOS: infrastructure_as_code/ >$ cat -n NestedTemplates/datastore-resources.yml | head -n 30
     1	---
     2	AWSTemplateFormatVersion: '2010-09-09'
     3
     4	Parameters:
...
    24	  DBInstanceClass:
    25	    Description: The desired size of RDS instances.
    26	    Type: String
    27	    Default: db.r4.xlarge
    28
    29	Resources:
...
14:26 MacOS: infrastructure_as_code/ >$ cfn-lint NestedTemplates/datastore-resources.yml
W2501 Parameter DBInstanceClass should have NoEcho True
NestedTemplates/datastore-resources.yml:24:3

14:26 MacOS: infrastructure_as_code/ >$

After perusing through the code I have determined that this is user error:
15:34 MacOS: NestedTemplates/ >$ grep DBInstanceClass datastore-resources.yml
  DBInstanceClass:
        DBInstanceClass: !Ref DBInstanceClass
        DBInstanceClass: !Ref DBInstanceClass
        DBInstanceClass: !Ref DBInstanceClass
      MasterUserPassword: !Ref DBInstanceClass
15:34 MacOS: NestedTemplates/ >$

https://github.com/awslabs/cfn-python-lint/blob/master/src/cfnlint/rules/resources/properties/Password.py#L36
😿

Reopening this for PR #519.

PR has been merged.

repo: awslabs/cfn-python-lint


text:
chore: fix frontend local start

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license
Summary
(describe what this merge request does)
Implementation highlights
(describe how the merge request does for feature changes, share the RFC link if it has)
Test checklist

[ ] add new test cases
[ ] all code changes are covered by unit tests
[ ] end-to-end tests

[ ] deploy web console with CloudFront + S3 + API gateway
[ ] deploy web console within VPC
[ ] deploy ingestion server

[ ] with MSK sink
[ ] with KDS sink
[ ] with S3 sink

[ ] deploy data processing
[ ] deploy data modeling

[ ] new Redshift Serverless
[ ] provisioned Redshift
[ ] Athena

[ ] deploy with reporting
[ ] streaming ingestion

[ ] with Redshift Serverless
[ ] with provisioned Redshift

Is it a breaking change

[ ] add parameters without default value in stack
[ ] introduce new service permission in stack
[ ] introduce new top level stack module

Miscellaneous

[ ] introduce new symbol link source file(s) to be shared among infra code, web console frontend, and web console backend

SonarQube Quality Gate Result

Result: :white_check_mark: OK
Triggered by @tyyzqmf on pull_request

Metric
Status
Value
Error Threshold

Reliability rating
:white_check_mark: OK
1
> 1

Security rating
:white_check_mark: OK
1
> 1

Sqale rating
:white_check_mark: OK
1
> 1

Coverage
:white_check_mark: OK
83.60
< 80

Duplicated lines density
:white_check_mark: OK
5.20
> 30

Blocker violations
:white_check_mark: OK
0
> 0

Bugs
:white_check_mark: OK
0
> 0

Code smells
:white_check_mark: OK
8
> 40

Critical violations
:white_check_mark: OK
0
> 0

Major violations
:white_check_mark: OK
0
> 0

Vulnerabilities
:white_check_mark: OK
0
> 0

View on SonarQube
updated: 5/21/2024, 06:23:00 (UTC+0)

SonarQube Code Analytics
Quality Gate passed

Additional information
The following metrics might not affect the Quality Gate status but improving them will improve your project code quality.
Issues
 0 Bugs
 0 Vulnerabilities
 0 Code Smells
Coverage and Duplications
No data Coverage
No data Duplication

authors: tyyzqmf zxkane

repo: awslabs/clickstream-analytics-on-aws


text:
GraphBolt Training Log

When training with graphbolt, it will not check if the necessary files exist under graph directory. We should check if the fused embedding is under graph directory before going to the training stage.

Can you give some more details?

authors: classicsong jalencato

repo: awslabs/graphstorm


text:
Ensures that Secure renegotiate extension not sent for TLS13

Issue # (if available):  #1243
Description of changes:  adding checks to ensure that secure_renegotiate extension is not send for tls1.3 or higher.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Codecov Report

:exclamation: No coverage uploaded for pull request head (TLS13_extensions@61ce97d). Click here to learn what that means.
The diff coverage is n/a.

authors: codecov-io raviduttsingh


text:
Fix typo in ErrorMetaData

Motivation and Context
Fixes typo that is preventing the compilation.
this becomes,
    extras: Option<HashMap<&'static str, String>>,

this.
    extras: Option<HashMap<&'static str, String>,

Testing
NA
Checklist
NA
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Sorry, it seems like I was the one making mistake.

repo: awslabs/smithy-rs


text:
Axelar testnet: Panic on startup

Hi guys!
Trying to run a fresh Axelar node on Testnet, but my node crashes with this panic message:
panic: unknown field "snapshots" in types.GenesisState
goroutine 1 [running]:
github.com/cosmos/cosmos-sdk/codec.(*ProtoCodec).MustUnmarshalJSON(0xb9cc63?, {0xc0000a53e0?, 0x2eaeb40?, 0xc000124600?}, {0x2ebd2a0?, 0xc000e9f120?})
	/go/pkg/mod/github.com/axelarnetwork/cosmos-sdk@v0.45.17-0.20230904150332-37fb903a6c62/codec/proto_codec.go:178 +0x45
github.com/axelarnetwork/axelar-core/x/snapshot.AppModule.InitGenesis({{}, {{0x2eb61f0, 0xc000d57580}, {0x2ed3100, 0xc000c6ac60}, {0x2eb1f60, 0xc000d56a60}, {0x2ecd590, 0xc0001bf800}, {0x2edf9b0, ...}, ...}}, ...)
	/go/axelar/x/snapshot/module.go:106 +0xa8
github.com/cosmos/cosmos-sdk/types/module.(*Manager).InitGenesis(_, {{0x2ece648, 0xc000056070}, {0x2edf0b8, 0xc000d7c9c0}, {{0x0, 0x0}, {0xc000052d08, 0x17}, 0xa8939, ...}, ...}, ...)
	/go/pkg/mod/github.com/axelarnetwork/cosmos-sdk@v0.45.17-0.20230904150332-37fb903a6c62/types/module/module.go:327 +0x29d
github.com/axelarnetwork/axelar-core/app.(*AxelarApp).InitChainer(_, {{0x2ece648, 0xc000056070}, {0x2edf0b8, 0xc000d7c9c0}, {{0x0, 0x0}, {0xc000052d08, 0x17}, 0xa8939, ...}, ...}, ...)
	/go/axelar/app/app.go:753 +0x20e
github.com/cosmos/cosmos-sdk/baseapp.(*BaseApp).InitChain(0xc000b26700, {{0x218d5b00, 0xed994a1e0, 0x0}, {0xc000052d08, 0x17}, 0xc000231860, {0xc000010840, 0x1, 0x1}, ...})
	/go/pkg/mod/github.com/axelarnetwork/cosmos-sdk@v0.45.17-0.20230904150332-37fb903a6c62/baseapp/abci.go:63 +0x455
github.com/tendermint/tendermint/abci/client.(*localClient).InitChainSync(0xc000bf50e0, {{0x218d5b00, 0xed994a1e0, 0x0}, {0xc000052d08, 0x17}, 0xc000231860, {0xc000010840, 0x1, 0x1}, ...})
	/go/pkg/mod/github.com/cometbft/cometbft@v0.34.27/abci/client/local_client.go:272 +0x118
github.com/tendermint/tendermint/proxy.(*appConnConsensus).InitChainSync(0x10a1480?, {{0x218d5b00, 0xed994a1e0, 0x0}, {0xc000052d08, 0x17}, 0xc000231860, {0xc000010840, 0x1, 0x1}, ...})
	/go/pkg/mod/github.com/cometbft/cometbft@v0.34.27/proxy/app_conn.go:77 +0x55
github.com/tendermint/tendermint/consensus.(*Handshaker).ReplayBlocks(_, {{{0xb, 0x0}, {0x201bfa8, 0x7}}, {0xc000052d08, 0x17}, 0xa8939, 0x0, {{0x0, ...}, ...}, ...}, ...)
	/go/pkg/mod/github.com/cometbft/cometbft@v0.34.27/consensus/replay.go:319 +0xd78
github.com/tendermint/tendermint/consensus.(*Handshaker).Handshake(0xc000e2fbf8, {0x2ee2fc0, 0xc000a93930})
	/go/pkg/mod/github.com/cometbft/cometbft@v0.34.27/consensus/replay.go:268 +0x3d4
github.com/tendermint/tendermint/node.doHandshake({_, _}, {{{0xb, 0x0}, {0x201bfa8, 0x7}}, {0xc000052d08, 0x17}, 0xa8939, 0x0, ...}, ...)
	/go/pkg/mod/github.com/cometbft/cometbft@v0.34.27/node/node.go:329 +0x1b8
github.com/tendermint/tendermint/node.NewNode(0xc000003b80, {0x2ecab60, 0xc000ce0c80}, 0xc000d38670, {0x2eafc40, 0xc000125f08}, 0x0?, 0x0?, 0xc000d38930, {0x2ecf598, ...}, ...)
	/go/pkg/mod/github.com/cometbft/cometbft@v0.34.27/node/node.go:779 +0x597
github.com/cosmos/cosmos-sdk/server.startInProcess(_, {{0x0, 0x0, 0x0}, {0x0, 0x0}, {0x0, 0x0}, {0x2ed4e60, 0xc000199540}, ...}, ...)
	/go/pkg/mod/github.com/axelarnetwork/cosmos-sdk@v0.45.17-0.20230904150332-37fb903a6c62/server/start.go:281 +0x81b
github.com/cosmos/cosmos-sdk/server.StartCmd.func2(0xc000ace900?, {0x3f6c1f8?, 0x0?, 0x0?})
	/go/pkg/mod/github.com/axelarnetwork/cosmos-sdk@v0.45.17-0.20230904150332-37fb903a6c62/server/start.go:129 +0x169
github.com/spf13/cobra.(*Command).execute(0xc000ace900, {0x3f6c1f8, 0x0, 0x0})
	/go/pkg/mod/github.com/spf13/cobra@v1.7.0/command.go:940 +0x862
github.com/spf13/cobra.(*Command).ExecuteC(0xc00019c900)
	/go/pkg/mod/github.com/spf13/cobra@v1.7.0/command.go:1068 +0x3bd
github.com/spf13/cobra.(*Command).Execute(...)
	/go/pkg/mod/github.com/spf13/cobra@v1.7.0/command.go:992
github.com/spf13/cobra.(*Command).ExecuteContext(...)
	/go/pkg/mod/github.com/spf13/cobra@v1.7.0/command.go:985
github.com/cosmos/cosmos-sdk/server/cmd.Execute(0x201a260?, {0xc000b906e0, 0x1d})
	/go/pkg/mod/github.com/axelarnetwork/cosmos-sdk@v0.45.17-0.20230904150332-37fb903a6c62/server/cmd/execute.go:36 +0x1eb
main.main()
	/go/axelar/cmd/axelard/main.go:73 +0x525

Could you help me to figure out a workaround?
Thank you in advance!

Hello @fmira21 if it’s a Cosmos related issue i will suggest you contact a
Cosmos support like i did and got help on their general chain link
Cosmos Live Support Agent
You can use the  ticket ID DR3486 as well for a faster response.
Am a developer, i participate in dApps, coding and web3 work online always so if you want to do a collab or anything you can message me as well.
Thanks.

Hi @Lilly351
Resolved this issue by myself:)
Just applied the latest Testnet snapshot.

repo: axelarnetwork/axelar-core


text:
Conflicting Shortcuts with new JupyterLab 3.0.6

There seem the be a conflicting shortcut with the new JupyterLab. This new version comes with a shortcut for the escape button, that once pressed, goes to the Cell Mode, instead of going from Vim Insert Mode to Vim Edit Mode.

There is a quick fix for this. Just add this to your shortcut setting:
{"shortcuts": [{"command": "notebook:enter-command-mode",
            "keys": [
                "Escape"
            ],
            "selector": ".jp-Notebook.jp-mod-editMode",
            "disabled": true}]
}

There is a quick fix for this. Just add this to your shortcut setting:
{"shortcuts": [{"command": "notebook:enter-command-mode",
            "keys": [
                "Escape"
            ],
            "selector": ".jp-Notebook.jp-mod-editMode",
            "disabled": true}]
}

I just ran into this now. Any chance this shortcut can be added on installation? It would be a good idea to add this to the README, or a message printed on install for jupyter versions affected.
Thanks @axelfahy for keeping the vim extension going!

I am sorry, but I am not able to reproduce. What browser do you use? How did you install the plugin? Did you refresh the page after installing the plugin? Does it only occur with the 3.0.6 version?

I sometimes run into this and have found that after refreshing the page the issue resolves. The thing is that esc has always been a jlab shortcut, so maybe switching to pre-built extensions is having weird inconsistent effects on the order of shortcut definitions. Though I think that that would a be a jlab issue

Hi @axelfahy,
I'm on jupyterlab 3.0.7 with the plugin version 0.13.0 installed via pip using firefox on linux. I've hard refreshed multiple times and it seems to persist unless I add that workaround listed in 2nd post in this thread.

@willprice I'm using firefox on linux with jlab 3.0.9 and found that the issue mostly arises immediately after I build. Can you try running jupyter lab build then refreshing? Also, any change you can post a set of commands (making new env etc) that replicates the issue?

authors: axelfahy davibarreira ianhi willprice

repo: axelfahy/jupyterlab-vim

license: MIT


text:
invalid profile public key

Expected behavior
chat message send normally
Observed/actual behavior
message does not send and a message appears say that I have an invalid profile public key
Steps/models to reproduce
open 1.19.3 with this mod
use this mod to re login to your account
join a server with chat reporting
try to send a message
Version
5.0.0
Agreements

[X] I am running the latest version of the mod.
[X] My version of Minecraft is supported.
[X] I have searched for and ensured there isn't already an open issue regarding this.

Other
in 1.19.3 a change was made to auto refresh the profile public key to prevent this message from appearing
the issue is prbly related to this

Hi 👋
Happy new year, I'm currently away and will be able to take a look in the coming weeks.
Here are the lines of code I suspect are at fault, but I can't do any debugging yet:
https://github.com/axieum/authme/blob/7ef38e0aae5833f5260ae6c2789a03b2bc4fbba8/src/main/java/me/axieum/mcmod/authme/api/util/SessionUtils.java#L87-L90
Thanks for your patience.

authors: axieum jSdCool

repo: axieum/authme


text:
Fix memory leaks

Which branch your pull-request should merge into?

2.1: BugFixes and Improvements for Current LTS branch

Describe your changes
Issue ticket number and link
Checklist before requesting a review
For each PR

[ ] Add Copyright if it missed:
- "Copyright (c) 2019-present Axmol Engine contributors (see AUTHORS.md)."

[ ] I have performed a self-review of my code.
Optional:

[ ] I have checked readme and add important infos to this PR.
[ ] I have added/adapted some tests too.

For core/new feature PR

[ ] I have checked readme and add important infos to this PR.
[ ] I have added thorough tests.

I don't see a logged issue regarding the memory leaks, and there is no information included in the description of this PR, which would be helpful in order to give some context to the changes made in this PR.
Can you please provide that information?

I don't see a logged issue regarding the memory leaks, and there is no information included in the description of this PR, which would be helpful in order to give some context to the changes made in this PR.
Can you please provide that information?

I tested it on Windows 11.
You can check the memory leak by changing the main.cpp file as follows.
#include "main.h"
#include "AppDelegate.h"
#include "axmol.h"
#ifdef _DEBUG
#    include <stdlib.h>
#    include <crtdbg.h>
#endif

USING_NS_AX;

int WINAPI _tWinMain(HINSTANCE hInstance, HINSTANCE hPrevInstance, LPTSTR lpCmdLine, int nCmdShow)
{
#ifdef _DEBUG
    _CrtSetDbgFlag(_CRTDBG_ALLOC_MEM_DF | _CRTDBG_LEAK_CHECK_DF);
#endif

    UNREFERENCED_PARAMETER(hPrevInstance);
    UNREFERENCED_PARAMETER(lpCmdLine);

    // create the application instance
#ifdef USE_WIN32_CONSOLE
    AllocConsole();
    freopen("CONIN$", "r", stdin);
    freopen("CONOUT$", "w", stdout);
    freopen("CONOUT$", "w", stderr);
#endif

    // create the application instance
    AppDelegate app;
    int ret = Application::getInstance()->run();

#ifdef USE_WIN32_CONSOLE
    FreeConsole();
#endif
    return ret;
}

You can check the memory leak by changing the main.cpp file as follows.

I can see the output when the program exits, but it doesn't explain your changes.  Can you please information regarding your changes, and whether they resolve some or all of the apparent memory leaks.

@lich426
Please  add Copyright if it missed:

"Copyright (c) 2019-present Axmol Engine contributors (see AUTHORS.md)."

You can check the memory leak by changing the main.cpp file as follows.

I can see the output when the program exits, but it doesn't explain your changes. Can you please provide some information regarding your changes, and whether they resolve some or all of the apparent memory leaks.

The screenshot below is the log that comes out after the program ends. (not english)

before

after

well, the director leak, because it's was reinit after mainloop when purge requested.
we nee re-consider to solve both director and quad command indices leak

@rh101  @lich426 The PR #1638 will be more clearly.

repo: axmolengine/axmol


text:
Adapt McBride universes?

https://proofassistants.stackexchange.com/q/113/32
I didn't implement this because I thought I don't understand it enough to implement it (I tried it in the experiment "Voile", but I wasn't sure if I did it right). Now I feel like I have to do something, as the current universe polymorphism is blocking @imkiva's work.

https://github.com/RedPRL/cooltt/pull/195

This should close #22 because we have solved the cause of the problem

repo: aya-prover/aya-dev


text:
chore(lspsaga): Update diagnostics icons for consistency.

This commit update lspsaga's lsp diagnostics icons so that it stays consistent with other plugins.

Source:

https://github.com/ayamir/nvimdots/blob/859206f4bd6b14bde47f17e806eb244ea4370aaf/lua/modules/ui/config.lua#L528
https://github.com/ayamir/nvimdots/blob/859206f4bd6b14bde47f17e806eb244ea4370aaf/lua/modules/ui/config.lua#L768-L769
https://github.com/ayamir/nvimdots/blob/859206f4bd6b14bde47f17e806eb244ea4370aaf/lua/modules/tools/config.lua#L116-L117

Sidebar style (lspsaga, which stays consistent with kkharji's [previous maintained version of] lspsaga):

ignored details.

repo: ayamir/nvimdots


text:
Move default configuration into config.go

Hi!
When adding new features, it is often the case that the config struct is extended. Since the struct was previously generated via the config file, which is maintained by the user, it would require them to actively add the missing entries in their configs.
For instance, the new timestamp formats are stored in the config. A user without those entries in their config will see something like:
-- Replying to [username] @ --
instead of the expected
-- Replying to [username] @ 10:45 --
With a default configuration built into the application:

the user can keep their current config file (even though some entries might be the same as the default settings)
new features do not require the user to add those entries to the config
by default, no actual config file is required - making the effort of maintaining a config file optional if the user has no special config

Cheers!

This is actually a very good feature.

I'm going to go ahead and close this, since it's been implemented in #372


text:
Error on "ClientboundLevelParticlesPacket" & "ClientboundSoundPacket" & "ClientboundSetEquipmentPacket"

Hello, when my bot is connected to a server, I get a lot of errors of this type that are triggered
2024-05-23T16:18:47.738638Z ERROR azalea_client::packet_handling::game: failed to read packet: Parse { packet_id: 41, packet_name: "ClientboundLevelParticlesPacket", backtrace: <disabled>, source: Io { source: Error { kind: UnexpectedEof, message: "failed to fill whole buffer" } } }
2024-05-23T16:18:47.738701Z ERROR azalea_client::packet_handling::game: failed to read packet: LeftoverData { data: [120, 0, 0, 0, 3, 63, 128, 0, 0, 0, 0, 0, 0, 254, 158, 126, 245, 86, 53, 252, 72], packet_name: "ClientboundSoundPacket" }
2024-05-23T16:18:47.739279Z ERROR azalea_client::packet_handling::game: failed to read packet: LeftoverData { data: [4, 62, 25, 153, 154, 63, 190, 251, 240, 192, 65, 214, 180, 4, 24, 39, 62], packet_name: "ClientboundSoundPacket" }
2024-05-23T16:18:47.764415Z ERROR azalea_client::packet_handling::game: failed to read packet: LeftoverData { data: [119, 247, 248, 63, 20, 148, 149, 61, 232, 232, 233, 63, 128, 0, 0], packet_name: "ClientboundLevelParticlesPacket" }
2024-05-23T16:18:47.764475Z ERROR azalea_client::packet_handling::game: failed to read packet: LeftoverData { data: [119, 247, 248, 63, 20, 148, 149, 61, 232, 232, 233, 63, 128, 0, 0], packet_name: "ClientboundLevelParticlesPacket" }
2024-05-23T16:18:47.764483Z ERROR azalea_client::packet_handling::game: failed to read packet: LeftoverData { data: [116, 244, 245, 62, 202, 202, 203, 62, 12, 140, 141, 63, 128, 0, 0], packet_name: "ClientboundLevelParticlesPacket" }
2024-05-23T16:18:47.764489Z ERROR azalea_client::packet_handling::game: failed to read packet: LeftoverData { data: [119, 247, 248, 63, 20, 148, 149, 61, 232, 232, 233, 63, 128, 0, 0], packet_name: "ClientboundLevelParticlesPacket" }
2024-05-23T16:18:47.764495Z ERROR azalea_client::packet_handling::game: failed to read packet: LeftoverData { data: [119, 247, 248, 63, 20, 148, 149, 61, 232, 232, 233, 63, 128, 0, 0], packet_name: "ClientboundLevelParticlesPacket" }
2024-05-23T16:18:47.764500Z ERROR azalea_client::packet_handling::game: failed to read packet: LeftoverData { data: [116, 244, 245, 62, 202, 202, 203, 62, 12, 140, 141, 63, 128, 0, 0], packet_name: "ClientboundLevelParticlesPacket" }
2024-05-23T16:18:47.764506Z ERROR azalea_client::packet_handling::game: failed to read packet: LeftoverData { data: [116, 244, 245, 62, 12, 140, 141, 61, 160, 160, 161, 63, 128, 0, 0], packet_name: "ClientboundLevelParticlesPacket" }
2024-05-23T16:18:47.764512Z ERROR azalea_client::packet_handling::game: failed to read packet: LeftoverData { data: [116, 244, 245, 62, 202, 202, 203, 62, 12, 140, 141, 63, 128, 0, 0], packet_name: "ClientboundLevelParticlesPacket" }
2024-05-23T16:18:47.764517Z ERROR azalea_client::packet_handling::game: failed to read packet: LeftoverData { data: [119, 247, 248, 63, 20, 148, 149, 61, 232, 232, 233, 63, 128, 0, 0], packet_name: "ClientboundLevelParticlesPacket" }
2024-05-23T16:18:47.764523Z ERROR azalea_client::packet_handling::game: failed to read packet: LeftoverData { data: [119, 247, 248, 63, 20, 148, 149, 61, 232, 232, 233, 63, 128, 0, 0], packet_name: "ClientboundLevelParticlesPacket" }
2024-05-23T16:18:47.764553Z ERROR azalea_client::packet_handling::game: failed to read packet: LeftoverData { data: [116, 244, 245, 62, 12, 140, 141, 61, 160, 160, 161, 63, 128, 0, 0], packet_name: "ClientboundLevelParticlesPacket" }
2024-05-23T16:18:47.764559Z ERROR azalea_client::packet_handling::game: failed to read packet: LeftoverData { data: [119, 247, 248, 63, 20, 148, 149, 61, 232, 232, 233, 63, 128, 0, 0], packet_name: "ClientboundLevelParticlesPacket" }
2024-05-23T16:18:47.598292Z ERROR azalea_client::packet_handling::game: failed to read packet: Parse { packet_id: 91, packet_name: "ClientboundSetEquipmentPacket", backtrace: <disabled>, source: InvalidUtf8 { bytes: [224, 144, 125, 9, 220, 122, 124, 31, 211, 1, 8, 116, 101, 120, 116, 117, 114, 101, 115, 168, 1, 101, 51, 82, 108, 101, 72, 82, 49, 99, 109, 86, 122, 79, 110, 116, 84, 83, 48, 108, 79, 79, 110, 116, 49, 99, 109, 119, 54, 73, 109, 104, 48, 100, 72, 65, 54, 76, 121, 57, 48, 90, 88, 104, 48, 100, 88, 74, 108], lossy: "��}\t�z|\u{1f}�\u{1}\u{8}textures�\u{1}e3RleHR1cmVzOntTS0lOOnt1cmw6Imh0dHA6Ly90ZXh0dXJl" } }

Also getting this, seems to be specific to logging in on hypixel.net

authors: GustavoWidman Lurgrid

repo: azalea-rs/azalea


text:
baseUrl auto or in config

Please, do not hardcode the baseurl
let baseUrl = 'http://localhost:3001'

use relative url or at least, a config file.
Thx

localhost:3001 is hardcoded in bundle.js. It is very difficult to use with an own domain.

I don't understand why you put this config in your own package.json.
On each upgrade, this file will be overriden and custom config lost.
Please use another file like 'settings.json'

repo: azat-co/mongoui

license: mit


text:
Return null instead of exception when job output prop does not exist …

…and show READY jobs in UI.
In Azkaban partial execution, some jobs can start even if some job output prop is missing.

Pull Request Test Coverage Report for Build 7106

3 of 5 (60.0%)  changed or added relevant lines in 1 file are covered.
6 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.01%) to 45.464%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

azkaban-exec-server/src/main/java/azkaban/execapp/FlowRunner.java
3
5
60.0%

Files with Coverage Reduction
New Missed Lines
%

azkaban-exec-server/src/main/java/azkaban/execapp/FlowRunner.java
6
78.09%

Totals

Change from base Build 7104:
-0.01%

Covered Lines:
18382

Relevant Lines:
40432

💛  - Coveralls

repo: azkaban/azkaban


text:
🛑 Sakai Wolford Bot is down

In b92a0d9, Sakai Wolford Bot (https://sakaibot-discord.uzumekiulee.repl.co/) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Sakai Wolford Bot is back up in d45e37d after 8 minutes.

repo: azrielbsi/monitor


text:
install.sh error on Ubuntu 15.04 (Vivid)

[azk] Checking platform.......................................[ DONE ]
[azk]   Detected platform: linux, x64
[azk]   Detected distribution: ubuntu, 15.04
[azk] Enabling sudo...........................................[ WAIT ]
[azk]   echo sudo enabled
[azk] Enabling sudo...........................................[ DONE ]

[azk] [ERROR]   Unsupported Ubuntu version.
[azk] [ERROR]   Feel free to ask support for it by opening an issue at:
[azk] [ERROR]     https://github.com/azukiapp/azk/issues
[azk] [ERROR] Failed to install azk.

According to Requirements:
Distributions (tested): Ubuntu 12.04/14.04/15.04 and Fedora 20/21/22

Thank you for your feedback @zizuiZ .
This information at our docs is incorrect.The supported versions of Ubuntu are: 12.04, 14.04 and 15.10.

@fearenales,
Its impossible to use it on 15.04?

@zizuiZ You can try install azk from source code. Just follow the instructions at http://docs.azk.io/en/installation/source-code.html.
Any further question, just let me know.

Ok,
Thanks @fearenales.

authors: fearenales zizuiZ

repo: azukiapp/azk


text:
Recent changes to the payload

I see that you have removed the 1 MB limit and modified the structure of the payload.
From what I can tell the payload is
4 bytes = size of the assembly
4 bytes = size of the params
1 byte = amsi bypass 0x00 don't bypass or 0x01 do bypass
n bytes = parameters
m bytes = assembly
I want to verify that is correct. or is the length of parameters inclusive of the 1 byte for amsi bypass?
I ask because I see, in HostingCLR
	unsigned char *allData = (unsigned char*)malloc(raw_assembly_length * sizeof(unsigned char)+ raw_args_length * sizeof(unsigned char) + 8 * sizeof(unsigned char));
I think that shouldbe a + 9 not + 8. It doesn't seem to account for the amsi byte.
same here:
	ReadProcessMemory(GetCurrentProcess(), lpPayload , allData, raw_assembly_length + raw_args_length + 8, &readed);
I see that you break apart here:
	unsigned char *offsetamsi = allData + 8;
	//Store amsi flag
	// Read the amsi setting of the provided payload into the amsiflag variable
	// if 0x01 then it will run the AMSI bypass
	memcpy(amsiflag, offsetamsi, 1);

	//Taking pointer to args
	//  arguments are the 10th byte to the (10+size of arguments) byte
	unsigned char *offsetargs = allData + 9;
	//Store parameters
	memcpy(arg_s, offsetargs, sizeof(arg_s));

	//Taking pointer to assembly
	unsigned char *offset = allData + raw_args_length + 9;
	//Store assembly
	memcpy(pvData, offset, raw_assembly_length);

Here is it appears that the length of the params is independent of the amsi flag.

Hi @osok,
thanks, you are right and for some strange reason this error had never given me problems. I did a quick test and it seems to be working properly now.

I got my go code working with it.  Well, I modified https://github.com/lesnuages/go-execute-assembly and made a pull request to his repo, with the changes.  So not totally my code.  :-)


text:
refactor: use ReadOnlySpan instead of ArraySegment

Small PR which uses ReadOnlySpan instead of ArraySegment in Htmlizer.
Motivation
I do feel it is more readable / less error prone now because we get rid of ref var frame = ref ... because we are working directly with the contiguous slice of memory.  There are neglectable small improvements of performance as well but this was not my main motivation.

btw., just so you know. I prefer to use rebase and merge if the commits are written in the conventional commit messages style, otherwise squash and merge with a commit message in that style. that keeps the commit log cleaner than not.

To the performance thing: Both are struct and are passed around by value. (If not stated via ref then of course by reference).
I just quote the official microsoft site:

Span is defined in such a way that operations can be as efficient as on arrays: indexing into a span doesn’t require computation to determine the beginning from a pointer and its starting offset, as the ref field itself already encapsulates both. (By contrast, ArraySegment has a separate offset field, making it more expensive both to index into and to pass around.)

Regarding:

btw., just so you know. I prefer to use rebase and merge if the commits are written in the conventional commit messages style, otherwise squash and merge with a commit message in that style. that keeps the commit log cleaner than not.

Noted, will follow your guidelines! Much appreciated.

And please feel free to counter my arguments if you see this not necessary or could degrade code quality in any way

And please feel free to counter my arguments if you see this not necessary or could degrade code quality in any way.
At the end all my commits are more less "my personal opinion and experience" so always open for feedback

I don't mind it. I lkke to avoid the more esoteric constructs like ref var if possible. Just surprised there are actually a little perf benefit.
Normally you can pass read-only struct by ref by using the in operator in front of the method argument. We might do that to get additional perf?

@egil As you said in passes the struct as reference and enforces immutability. And it makes it slower*. You can empirically test with BenchmarkDotNet if you like.
The reason is simple (at least in our case).Imagine we have a small struct which has two integer fields. The sequential data length is 8 byte. If we pass that struct around (not via refernece) we copy those 8 sequential bytes and put it onto the stack. That is kind of trivial to do. The caller can just read those new 8 bytes.
Now we do the same but this time as the reference of the struct. First we have to create a copy of the reference on top of the stack. Now depending on your CPU architecture this is either 4 or 8-byte (more likely has the majority uses 64 bit). So the same amount of work as with copying. But: If we want to read the values of the reference we also have to dereference this pointer and get the real values behind. So the more you access the reference, the more expensive* it gets.
But sure, if you have a fat struct >100 bytes, copying becomes way more expensive (especially because it doesn't fit into a single CPU register anymore) and references are faster.

We are taking nano-seconds here!

Ahh that makes sense, its all about the number of bytes you are copying. If the struct is small enough it might be less data to copy than a pointer.

authors: egil linkdotnet

repo: bUnit-dev/bUnit


text:
Resolve #869

Rework the documentation page
Fix the docs as described by the discussion in #869

Hey @pBouillon thanks for handing in that nice PR.
Just a side note from my side. It seems that you branched off from main and not stable. That is why we see some merge commits and additional changes.
Would it be possible to branch of ffrom stable? Or alternatively (depending on how much of a git pro you are), you can do this (pretending you are on your branch):
git pull
git rebase --onto origin/stable origin/main

That commands rebases the from main to stable. Please do this only if you are confident with git.

Hey @linkdotnet!
Thanks for the hint, I misunderstood the issue and thought that I should target stable but didn't get that it implied starting from it too, I'll fix that 😄

I did not felt confident enough with the git commands you suggested so I did a separate PR to change the source and target branches on #877
I'll be closing this PR to avoid duplicates, let me know if I have to change anything else!

authors: linkdotnet pBouillon


text:
New User: Discord

Hey! We use babel too :heart:

Name: Discord
Homepage url: https://discordapp.com/
Brand Guidelines/Licensing: https://discordapp.com/branding
Logo: https://discordapp.com/assets/e4923594e694a21542a489471ecffa50.svg

Awesome, want to open a PR for it? Here's some examples

Cool!

Ahha.  Sure.

authors: hzoo jhgg thejameskyle


text:
Accidentally closing all tabs

I found a pretty nasty issue where I open the dialog, search, tap arrow down to select; at which moment ALL my tabs would be closed. Happened a few times before I understood.
To reproduce;

configure "Close all displayed tabs shortcut" as nothing (no ctrl/shift/alt, and empty text box in the end) (I did this as I was afraid accidentally hitting this and losing all my open tabs)
open dialog
tap arrow down (or likely; any key) -> all tabs close.

Think I even saw a negative comment in the user feedback (chrome web store) on this.
Is there a way to disable the keyboard shortcut to close all tabs?

Exactly this happend to me too. Except that I hit the space key, which then closed all tabs.
To workaround this I did configure "Close all displayed tabs shortcut" to require all special keys and some bogus key, which I'll never hit.
So a way to disable this (or all) keyboard shortcuts would be nice.

Me too. I thought unchecking would deactivate the function all together. BUT, now we know :-D

#148 #183 #208  All issues are related to same lines of code.

authors: 0xC0FFEE MartinLichtblau henrikba

repo: babyman/quick-tabs-chrome-extension


text:
🐛 Bug Report: Disable DynamicPluginsTable thirdClickSort due to bad user experience

📜 Description
Material UI by default has an odd behavior for sorting tables.
On the third click on column sort, the sorting is cleared and it looks like a bug (as our QE observed)
It's possible to disable it, but the backstage table doesn't by default and so the RHDH catalog has this behavior.
WDYT about disabling this feature?
You can see the behavior by clicking three times on sort on of the columns in the catalog table
👍 Expected behavior
The table should always present the data in a user friendly format.
👎 Actual Behavior with Screenshots

👟 Reproduction steps

Trigger some workflows
go to workflows run table
Click sort by started 3 times (until arrow is grey)
Observe data in table, it isn't presented in a user friendly format.

📃 Provide the context for the Bug.
It is just an eye sore, table data should always be easy for the user to read and understand
🖥 Your Environment
rhdh deployed on OCP with Orchestrator and Notifications plugins installed
👀 Have you spent some time to check if this bug has been raised before?

[X] I checked and didn't find similar issue

🏢 Have you read the Code of Conduct?

[X] I have read the Code of Conduct

Are you willing to submit PR?
None

Just wanted to add on some details. Backstage actually uses @material-table/core for it's tables and not the ones in Material-UI. I learned about that when working on a recent update to the Catalog Index customization docs here: https://backstage.io/docs/features/software-catalog/catalog-customization#table-options
You can see an working demo of this issue here: https://demo.backstage.io/catalog?filters[kind]=component&filters[user]=all. Just click on one of the column headers three times. I do find to really notice this you need to cycle through it a few times, the arrow really helps make it more obvious IMO.
@condawrangler, I don't know what "rhdh" is can you share more details? I'm also not familiar with the "Orchestrator" plugin, can you share a link, please? I'm assuming this is what is shown in your screen shot?

The 'third option sort' is indeed useful in certain cases. However, plugin authors have the option to disable this feature if they prefer. I recommend opening an issue at https://github.com/janus-idp/backstage-plugins, as the plugin you're referring to is managed there.

Closing this in favour of the "Table improvemnts RFC": https://github.com/backstage/backstage/issues/22735. I also want to mention that the problem you are running into is related to a specific implementation of Backstage (RHDH) so you might want to reach out to that team instead of raising the issue here.

Hi @tudi2d, you can actually see this on the demo site
Catalog: https://demo.backstage.io/catalog?filters[kind]=component&filters[user]=all
GitHub Actions: https://demo.backstage.io/catalog/default/component/backstage-demo/ci-cd
Docs list: https://demo.backstage.io/docs?filters[user]=all
This does seem to be an Backstage "issue". I don't know the solution but I'll be honest it's confused me often, I've just lived with it.

Hi @tudi2d, you can actually see this on the demo site
Catalog: https://demo.backstage.io/catalog?filters[kind]=component&filters[user]=all GitHub Actions: https://demo.backstage.io/catalog/default/component/backstage-demo/ci-cd Docs list: https://demo.backstage.io/docs?filters[user]=all
This does seem to be a Backstage "issue". I don't know the solution but I'll be honest it's confused me often, I've just lived with it.

so what you are seeing is the "default material ui behaviour", which is inherited by all the tables.
However, plugin authors can customize this behaviour by passing custom props to the Table component. This is the reason why we believe this isn't a bug affecting Backstage. The behaviour might sound confusing but it actually makes sense if you think about data sorted server side according to some criteria. You can decide to sort the data asc or desc on a column or you can reset to the default sorting.

authors: awanlin condawrangler tudi2d vinzscam

repo: backstage/backstage


text:
🐛 Bug Report: Copying from from task log does not preserve newlines

📜 Description
When I try to copy more than one line from the task log, newlines are not preserved. (Tested in Safari and Chrome)
👍 Expected behavior
I should be able to copy the whole log text, including newlines.
👎 Actual Behavior with Screenshots
I get the entire log in one long line, including the line numbers.

What I get out:
12024-05-02T15:08:47.220Z Beginning step Log Repo URL22024-05-02T15:08:47.234Z info: {3  "extra": {4    "host": "gitlab.i40.ifm-datalink.net, Opens in a new window",5    "owner": "software/dev-docs",6    "repo": "k6k8s"7  }8}92024-05-02T15:08:47.234Z Finished step Log Repo URL102024-05-02T15:08:47.235Z Beginning step Log Repo URL112024-05-02T15:08:47.239Z info: {12  "extra": {13    "USER_OAUTH_TOKEN": "[REDACTED]",14    "backstageToken": "[REDACTED]",15    "__initiatorCredentials": "REDACTED"16  }17}182024-05-02T15:08:47.239Z Finished step Log Repo URL192024-05-02T15:08:47.241Z Beginning step fetch:template202024-05-02T15:08:47.249Z info: Fetching template content from remote URL212024-05-02T15:08:47.604Z info: Listing files and directories in template222024-05-02T15:08:47.615Z info: Processing 1 template files/directories with input values {"description":"[REDACTED]","lifecycle":"production","name":"k6k8s","owner":"[REDACTED]","type":"application"}232024-05-02T15:08:47.657Z info: Writing file catalog-info.yaml.njk to template output path with mode 33188.242024-05-02T15:08:47.663Z info: Template result written to /tmp/5788c486-1ad5-443a-b640-5f93a565029d252024-05-02T15:08:47.666Z Finished step fetch:template262024-05-02T15:08:47.667Z Beginning step Create Merge Request

👟 Reproduction steps

Run any template
In the last screen of the wizard, try copying the whole log

📃 Provide the context for the Bug.
No response
🖥 Your Environment
yarn backstage-cli info

OS:   Darwin 23.4.0 - darwin/x64
node: v18.13.0
yarn: 1.22.21
cli:  0.26.4 (installed)
backstage:  1.26.4

Dependencies:
  @backstage/app-defaults                                          1.5.4
  @backstage/backend-app-api                                       0.5.14, 0.7.1
  @backstage/backend-common                                        0.20.2, 0.21.7
  @backstage/backend-defaults                                      0.2.17
  @backstage/backend-dev-utils                                     0.1.4
  @backstage/backend-openapi-utils                                 0.1.10
  @backstage/backend-plugin-api                                    0.6.17
  @backstage/backend-tasks                                         0.5.22
  @backstage/catalog-client                                        1.6.4
  @backstage/catalog-model                                         1.4.5
  @backstage/cli-common                                            0.1.13
  @backstage/cli-node                                              0.2.5
  @backstage/cli                                                   0.26.4
  @backstage/config-loader                                         1.8.0
  @backstage/config                                                1.2.0
  @backstage/core-app-api                                          1.12.4
  @backstage/core-compat-api                                       0.2.4
  @backstage/core-components                                       0.13.10, 0.14.5
  @backstage/core-plugin-api                                       1.9.2
  @backstage/e2e-test-utils                                        0.1.1
  @backstage/errors                                                1.2.4
  @backstage/eslint-plugin                                         0.1.7
  @backstage/frontend-plugin-api                                   0.6.4
  @backstage/integration-aws-node                                  0.1.12
  @backstage/integration-react                                     1.1.26
  @backstage/integration                                           1.10.0
  @backstage/plugin-api-docs                                       0.11.4
  @backstage/plugin-app-backend                                    0.3.65
  @backstage/plugin-app-node                                       0.1.17
  @backstage/plugin-auth-backend-module-atlassian-provider         0.1.9
  @backstage/plugin-auth-backend-module-aws-alb-provider           0.1.9
  @backstage/plugin-auth-backend-module-azure-easyauth-provider    0.1.0
  @backstage/plugin-auth-backend-module-bitbucket-provider         0.1.0
  @backstage/plugin-auth-backend-module-cloudflare-access-provider 0.1.0
  @backstage/plugin-auth-backend-module-gcp-iap-provider           0.2.12
  @backstage/plugin-auth-backend-module-github-provider            0.1.14
  @backstage/plugin-auth-backend-module-gitlab-provider            0.1.14
  @backstage/plugin-auth-backend-module-google-provider            0.1.14
  @backstage/plugin-auth-backend-module-microsoft-provider         0.1.12
  @backstage/plugin-auth-backend-module-oauth2-provider            0.1.14
  @backstage/plugin-auth-backend-module-oauth2-proxy-provider      0.1.10
  @backstage/plugin-auth-backend-module-oidc-provider              0.1.8
  @backstage/plugin-auth-backend-module-okta-provider              0.0.10
  @backstage/plugin-auth-backend                                   0.22.4
  @backstage/plugin-auth-node                                      0.4.12
  @backstage/plugin-auth-react                                     0.1.1
  @backstage/plugin-catalog-backend-module-gitlab                  0.3.15
  @backstage/plugin-catalog-backend-module-scaffolder-entity-model 0.1.15
  @backstage/plugin-catalog-backend                                1.21.1
  @backstage/plugin-catalog-common                                 1.0.22
  @backstage/plugin-catalog-graph                                  0.4.4
  @backstage/plugin-catalog-import                                 0.10.10
  @backstage/plugin-catalog-node                                   1.11.1
  @backstage/plugin-catalog-react                                  1.11.3
  @backstage/plugin-catalog                                        1.19.0
  @backstage/plugin-events-node                                    0.3.3
  @backstage/plugin-home-react                                     0.1.12
  @backstage/plugin-home                                           0.7.3
  @backstage/plugin-org                                            0.6.24
  @backstage/plugin-permission-backend-module-allow-all-policy     0.1.14
  @backstage/plugin-permission-backend                             0.5.41
  @backstage/plugin-permission-common                              0.7.13
  @backstage/plugin-permission-node                                0.7.28
  @backstage/plugin-permission-react                               0.4.22
  @backstage/plugin-proxy-backend                                  0.4.15
  @backstage/plugin-scaffolder-backend-module-azure                0.1.9
  @backstage/plugin-scaffolder-backend-module-bitbucket-cloud      0.1.7
  @backstage/plugin-scaffolder-backend-module-bitbucket-server     0.1.7
  @backstage/plugin-scaffolder-backend-module-bitbucket            0.2.7
  @backstage/plugin-scaffolder-backend-module-gerrit               0.1.9
  @backstage/plugin-scaffolder-backend-module-gitea                0.1.7
  @backstage/plugin-scaffolder-backend-module-github               0.2.7
  @backstage/plugin-scaffolder-backend-module-gitlab               0.3.3
  @backstage/plugin-scaffolder-backend                             1.22.4
  @backstage/plugin-scaffolder-common                              1.5.1
  @backstage/plugin-scaffolder-node                                0.4.3
  @backstage/plugin-scaffolder-react                               1.8.4
  @backstage/plugin-scaffolder                                     1.19.3
  @backstage/plugin-search-backend-module-catalog                  0.1.23
  @backstage/plugin-search-backend-module-pg                       0.5.26
  @backstage/plugin-search-backend-module-techdocs                 0.1.22
  @backstage/plugin-search-backend-node                            1.2.21
  @backstage/plugin-search-backend                                 1.5.7
  @backstage/plugin-search-common                                  1.2.11
  @backstage/plugin-search-react                                   1.7.10
  @backstage/plugin-search                                         1.4.10
  @backstage/plugin-techdocs-backend                               1.10.4
  @backstage/plugin-techdocs-module-addons-contrib                 1.1.9
  @backstage/plugin-techdocs-node                                  1.12.3
  @backstage/plugin-techdocs-react                                 1.2.3
  @backstage/plugin-techdocs                                       1.10.4
  @backstage/plugin-user-settings                                  0.8.5
  @backstage/release-manifests                                     0.0.11
  @backstage/repo-tools                                            0.8.0
  @backstage/test-utils                                            1.5.4
  @backstage/theme                                                 0.4.4, 0.5.3
  @backstage/types                                                 1.1.1
  @backstage/version-bridge                                        1.0.8
✨  Done in 4.00s.

👀 Have you spent some time to check if this bug has been raised before?

[X] I checked and didn't find similar issue

🏢 Have you read the Code of Conduct?

[X] I have read the Code of Conduct

Are you willing to submit PR?
No, I don't have time to work on this right now

on it 🙋

Thanks for looking into this!
I did not know about the hidden copy buttons on the left, so I just selected the text using drag-and-drop. Also, it took me a while to figure out that once you have clicked on a like, you can shift-click on another one, and it copies the text. The UI could be improved to make it more discoverable, but that's more of a feature request than a bug, so I'm closing this ticket.

Thanks for looking into this! I did not know about the hidden copy buttons on the left, so I just selected the text using drag-and-drop. Also, it took me a while to figure out that once you have clicked on a like, you can shift-click on another one, and it copies the text. The UI could be improved to make it more discoverable, but that's more of a feature request than a bug, so I'm closing this ticket.

Agree may be in future I or someone from the community make the icon visible on hover.


text:
Role or scope based authorization

We want to implement scope based authorization. For users with different roles or scopes we would like to show or hide certain features in backstage. Can we have multiple authorization? For users who have logged with github when they click on a specific tab we would like to authorize using okta or auth0 and show the content based on the role or scopes of the user

For entity visibility specifically, there's this issue.
Large parts of the interface are composable in such a way that you could wrap them in an auth barrier, at the JSX level in your app package. We have no builtin functionality for this, but a part of what you mention you can probably implement as a custom thing for your org.

The permissions framework as proposed in the RFC is now being implemented. On top of that, Spotify is developing an RBAC plugin which will be paid. For more details, see https://backstage.spotify.com/blog/authorization-framework-rfc/
and https://backstage.spotify.com/blog/paid-plugins-announcement/

The Permission Framework is now mostly in place I believe. Thinking that we are going to close this ticket now, as the RBAC plugin, which is built upon the open source Permission Framework has been mentioned.

authors: OrkoHunter benjdlambert freben maha-z


text:
Draft: [Vault Plugin] Add requested improvements

Signed-off-by: ivgo ivgo@spreadgroup.com
Hey, I just made a Pull Request!
Context
Changes requested right before merging the initial version of the plugin: #11423
In this PR I'm adding or changing some things that @freben requested right before merging the initial version of this plugin. It's basically adding some missing stuff into the api-report, also handling differently the api calls by throwing errors and not swallowing them.
This has been tested locally and everything is working exactly in the same way as before, but I had to adjust a bit the tests so that they pass.
Regarding the use of the Progress component in here: link, I'm just not adding it because I'm using the prop isLoading from the Table, so you can see the empty Table with a loading animation while the data is being fetched.
The only things missing right now are the use of p-limit and adding the changeset.
:heavy_check_mark: Checklist

[ ] A changeset describing the change and affected packages. (more info)
[ ] Added or updated documentation
[x] Tests for new functionality and regression tests for bug fixes
[ ] Screenshots attached (for UI changes)
[x] All your commits have a Signed-off-by line in the message. (more info)

Hi! Looks like this PR needs an updated API report(yarn build:api-reports) and a changeset :)

Yeah, I still need to add a couple more things. I thought adding the Draft:  at the beginning of the PR name would skip the execution of all the actions


text:
jenkins JobRunTable added

I have added one more table in Jenkins plugin capable of showing all the builds triggers, for a particular job.

@Abhay-soni-developer i think we are good to merge this now.

@benjdlambert @NishkarshRaj @jhaals @awanlin  i think we are ready to merge this branch, all the requested changes have been done too

any updates on this please drop your feedback if you want anything more to be done or please can we get this merge quickly
@benjdlambert @NishkarshRaj @jhaals @awanlin

https://github.com/backstage/backstage/actions/runs/6194714819/job/16818170902?pr=19881
One last bit needed: the API Report must be updated.

@benjdlambert @NishkarshRaj @jhaals @awanlin
The API docs test which was failing, now runs successfully.
The merge is all set to be merged.
Thanks @NishkarshRaj  for your consistent support.

Thank you for your feedback. After careful consideration, I have made some changes to the low-level design of the component, which now meets both our requirements and your suggestions. I am confident that this solution will be easy to maintain and will fit smoothly into the plugin's future roadmap.
@Rugvip  @NishkarshRaj  @jhaals  @awanlin please review

Any updates over this pull request .

where are we with this pull request?
@freben  @Rugvip

OK, will now resume work on the feedbacks
and will contribute to this

@benjdlambert @Rugvip
made changes according to the feedbacks , please check this and get this merge if its all good from your side too.

@benjdlambert @jhaals @awanlin @tudi2d @Rugvip
please pay some attention to this PR, because I think we are very close to closing this PR

After merging the other PR, this has conflicts.

@benjdlambert @jhaals @awanlin @tudi2d @Rugvip
I have worked on the last feedback too. are we good to move forward with this?

@Rugvip are ready to merge this now

you really just need to wait for the review like everyone else.


text:
Add Mend Plugin

Add Mend plugin
Hey, I just made a Pull Request!

:heavy_check_mark: Checklist

[ ] A changeset describing the change and affected packages. (more info)
[ ] Added or updated documentation
[ ] Tests for new functionality and regression tests for bug fixes
[ ] Screenshots attached (for UI changes)
[ ] All your commits have a Signed-off-by line in the message. (more info)

nice! Let's wait until the plugin gets published

@vinzscam @awanlin The plugin was merged into the community plugins repo last Friday. Can you please merge this and publish the plugin package, so that the links in the portal marketplace can be updated (https://backstage.spotify.com/marketplace/mend-io/plugin/mend-io/)?

Hi @awanlin @NormanWenzelWSS, created PR to remove the private flag https://github.com/backstage/community-plugins/pull/1841

authors: NormanWenzelWSS dariuszsobkowicz


text:
More scaffolder config cleanup

🧹
Follow-on to #8309, the old scaffolder config was still included in the create-app template and docs. Now updated.
:heavy_check_mark: Checklist

[x] A changeset describing the change and affected packages. (more info)
[x] Added or updated documentation
[ ] Tests for new functionality and regression tests for bug fixes
[ ] Screenshots attached (for UI changes)
[x] All your commits have a Signed-off-by line in the message. (more info)

Thanks Tim!

authors: jhaals timbonicus


text:
🐛 Bug Report: updated plugin documentation is missing

📜 Description
I want to install some plugins on NBS backstage but it seems there is not any updated documentation for plugins like to-do also, I think some of the plugins are updated with NBS but there documentation are not updated.
👍 Expected behavior
Clear documentation and list of plugins which support NBS  backstage
👎 Actual Behavior with Screenshots
No clear documentation of updated plugins
👟 Reproduction steps
N/A
📃 Provide the context for the Bug.
No response
🖥 Your Environment
No response
👀 Have you spent some time to check if this bug has been raised before?

[X] I checked and didn't find similar issue

🏢 Have you read the Code of Conduct?

[X] I have read the Code of Conduct

Are you willing to submit PR?
None

Hi @prasoon-pxc, can you please log an issue for this here: https://github.com/backstage/community-plugins/issues/new/choose. I'm not sure why but the conversation history is not coming across when I transfer it.

Closing due to issues with the transfer, sorry :(

authors: awanlin prasoon-pxc

repo: backstage/community-plugins


text:
Run with tags using before and beforeEach

I am trying to create a login script that saves the cookies and then re-uses them through the test.
The problem I have is following, I can't use before and beforeEach with tags, I have tried:
beforeEach("@landlordLogin", () => {
beforeEach({ tags: "@landlordLogin" }, () => {

I have more then one users, thats why I would like to run them with tags.

Hi
See https://github.com/TheBrainFamily/cypress-cucumber-preprocessor#before-and-after-hooks
Can you use the Cucumber Hooks rather than the mocha ones?
Would that work for you

I need to run the login Before ALL the other tests and then one that is grabbing/restoring the cookies.
So, I need more then just 'before' and need to be able to use tags.

This is quite a common requirement I would think. The way we handle this in our acceptance tests is as follows
In a Cucumber Before block for the user type associated with a tag we'd do something like
Given The landlord has logged in
or
Given The tenant has logged in
Which, for us, maps to a step definition like
Given(/^The (.+) has logged in$/, (user) => {
    cy.login(user);
});

We created a cypress command to look after, and abstract away, all of the login state gnarliness associated with our systems
It does a bunch of things including cy.getCookie and cy.setCookie calls and if tests to see if appropriate cookies already exist
Essentially

in your Cucumber Before always login. Use tags if appropriate to setup the type of user who is logging in for this set of features/scenarios if thats how you have structured things
write some JS in a helper or a command to make the login actually happen for your DUT and to store the token/key/whatever to a cookie or local storage from this code
surround that login logic with an if block that checks if the answer is already there and if it is don't do it all again

Would that sort of approach work for you?

Due to personal reasons, the previous maintainers of this package are stepping down and handing the reigns over to me, a long-time contributor to the project and a user of it myself. This is a responsibility I'm very excited about. Furthermore, I'd like to thank @lgandecki ++ for all the work that they've done so far.
Read more about the transfer of ownership here.
The repository has however moved and all outstanding issues are being closed. This is not a reflection of the perceived importance of your reported issue. However, if after upgrading to the new version, you still find there to be an issue, feel free to open up another ticket or comment below. Please make sure to read CONTRIBUTING.md before doing so.

authors: badeball dthisner jcundill

repo: badeball/cypress-cucumber-preprocessor


text:
Matrix Badges - "guests not allowed"

Are you experiencing an issue with...
shields.io
🐞 Description
The badges for Matrix rooms all show the same error, "guests not allowed".
It started coming up a few weeks ago I would say.
I've noticed it on my repo: https://github.com/cyb3rko/flashdim
But here are some more examples:

https://github.com/matrix-org/matrix-appservice-irc
https://github.com/gotify/server
https://github.com/hedgedoc/hedgedoc

🔗 Link to the badge
https://img.shields.io/matrix/flashdim%3Amatrix.org?logo=matrix&label=Matrix Chat&color=black
💡 Possible Solution
No response

Looking at the examples you've posted, these are all for rooms hosted on matrix.org
It looks like matrix.org has disabled guest access, which was the method we were using to get stats.
This isn't the case for all matrix servers though. For example, these badges (using different matrix servers) work just fine

 https://img.shields.io/matrix/ndcube:openastronomy.org.svg?server_fqdn=openastronomy.modular.im
 https://img.shields.io/matrix/voicenotify:p51.me?server_fqdn=matrix.p51.me
etc

although I am aware that matrix.org is by far the most common choice of server so this upstream change breaks the majority matrix badges.
In general, the method the matrix badges use to get stats is not very good for performance reasons outlined in https://github.com/badges/shields/issues/10138 even where guest access is available. Moving to the solution outlined in that issue would solve this problem and also provide performance benefits. One of the reasons nobody worked on that is because it is a bit fiddly to deal with different matrix servers out there running different versions of the software. I wonder if enough time has passed that we could simplify the implementation by just dropping the old guest access method and say you now must have the summary endpoint to use the badge. That would simplify things a bit.

Thanks Chris,
that makes sense. I wondered if we could use the same method https://matrix.to/#/#flashdim:matrix.org uses to preview the room user number.
Turns out, they use the mentioned summary endpoint as well:
https://matrix-client.matrix.org/_matrix/client/unstable/im.nheko.summary/rooms/%23flashdim%3Amatrix.org/summary?via=matrix.org&_cacheBuster=4447781817273286
https://matrix-client.matrix.org/_matrix/client/unstable/im.nheko.summary/rooms/%23ndcube:openastronomy.org/summary?via=openastronomy.modular.im/&_cacheBuster=4447781817273286
https://matrix-client.matrix.org/_matrix/client/unstable/im.nheko.summary/rooms/%23voicenotify:p51.me/summary?via=matrix.p51.me/&_cacheBuster=4447781817273286

I would say it makes sense to adopt this new method now and drop the guest access for older rooms / homeservers.
What do you think?

But then again I wonder how https://app.element.io/#/room/#flashdim:matrix.org fetches the user number without the summary call

OK. So just having done a bit more reading on it, it looks like:

https://github.com/matrix-org/matrix-spec-proposals/pull/3266 is still not accepted
This feature is off by default in Synapse (which I think seems to be the most common server implementation?). You have to explicitly opt-in to an experimental feature to enable this endpoint.
This proposal is not implemented in some server implementations
I've not done a full census, but having checked a few other servers I could find based on searching for badges in public READMEs, I have not been able to find another server other than matrix.org with the summary endpoint enabled.

Given that, I think it is too soon to drop the existing method and require the summary endpoint. Doing that would probably fix badges for matrix.org users but break it for a lot of other users. Annoyingly, I think we would ideally need to able to use both methods at this stage.

Someone on Matrix mentioned that apparently shields.io got blocked on matrix.org:
https://matrix.to/#/!QQpfJfZvqxbCfeDgCj:matrix.org/$NzO5dGBTC0TjhDMlZgL36KTt4NWIQU2VT8rbbcaZmcg?via=matrix.org&via=envs.net&via=element.io

Furthermore, guest access doesn't seem to be disabled for matrix.org

That's exciting.
Matrix badges are cached downstream for 30 seconds
https://github.com/badges/shields/blob/bf91e268d62d4a07550ecc0e6a1aa80dffe3ae07/services/matrix/matrix.service.js#L84
but we could, of course, increase that.

It should be increased a lot I feel like.
The only thing fetched in the end is the number of users, right?
If so, we could easily say a cache of 1 day would still be enough. I mean the number of users is not a sensitive stat that has to be up-to-date permanently.

Yeah looking back at it, I think the person who originally contributed this probably copied this from the discord badge, which shows the number of users online right now. The matrix badge just shows the number of channel members. There's less need for this to be fresh. We tend not to cache things for as long as a day, but I've submitted a PR bumping it to 4 hours at https://github.com/badges/shields/pull/10778 . That's 480 times longer than we were caching it previously.
Whether or not that gets us unbanned is another issue but caching for longer is something we can do quickly and easily.
Either way, the ability to optionally use the summary endpoint would be an improvement for other reasons.

Sounds good.
Do you think the logic should be adjusted for now to fetch the summary for matrix.org and for every other server the current logic?

repo: badges/shields


text:
Maybe you can provide Alipay 2D code, so China users can donate you conveniently.

:clipboard: Description

Thanks for reaching out. Could you provide a little information? I'm not familiar with Alipay, but are there issues with donating via Open Collective from certain locations/countries?

[Reply on "provide Alipay 2D code"]
Thanks for reply to my suggestion.
More info:   https://global.alipay.com/docs/
       Maybe you can take a look at “Documentation--online payment--” entry  When you have a free time.
What I want to say is : In china, it is very convenient to use Alipay QR code in China, and Donating via Open Collective is realizable but slightly inconvenient.
"Provide Alipay 2D code" is just an proposal . If you want to make donation channels more unobstructed in you free time,you can give it a try.
 The collection QR code may not be as transparent as other methods，but I think more important thing is to donate your marvelous work more quickly.
------------------ 原始邮件 ------------------
发件人:                                                                                "badges/shields"                                                                                @.>;
发送时间: 2021年12月24日(星期五) 凌晨2:32
@.>;
@.@.>;
主题: Re: [badges/shields] Maybe you can provide Alipay 2D code, so China users can donate you conveniently. (Issue #7415)
Thanks for reaching out. Could you provide a little information? I'm not familiar with Alipay, but are there issues with donating via Open Collective from certain locations/countries?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you authored the thread.Message ID: @.***>

Thanks again for the suggestion and follow up, but I'm going to close this because this isn't a path we want to take at this time.
Open Collective greatly simplifies the process of accepting and spending donations without the legal/tax/etc. overhead that comes with other types of processors. We have an incredibly small maintainer team with limited bandwidth, and a donation platform in Open Collective that works best for us. Trying to incorporate other sources would actually create more problems for us than it would solve.


text:
Update Zeit members list

Addressing this ad hoc for now (https://github.com/badges/svg-to-image-proxy/pull/27/files#r300762988).
At some point we should address this question systematically (see #2577).

Messages

:book:
:sparkles: Thanks for your contribution to Shields, @paulmelnikow!

:book:

Thanks for contributing to our documentation. We :heart: our documentarians!

  Generated by :no_entry_sign: dangerJS against e1eb3986791afd92484e7f689c9b5fd5dfa18c3c

authors: paulmelnikow shields-ci


text:
I cann`t see my orders after updating from 1.3.1 to 1.3.2

Bug report
Issue Description
In new bagisto version I`m manually updated my version. After updating I dont see my orders.
Preconditions

Bagisto version

[ ] master branch
[x] 1.3.2
[ ] 1.3.1
[ ] 1.3.0

Steps to reproduce

Expected result

Actual result

Hi @devansh-webkul
The issue still persist on my side.

Did you added this PR,
https://github.com/bagisto/bagisto/pull/5124

Did you added this PR,
#5124

Yes,

I am just checking, compiled file is missing.

Also I find that I can`t see customers Address, Invoices and Orders.

Yeah, 4 new datagrid-plus have been placed, which is in the testing phase. When it will become stable, we will use it.

@rsabzaali,
Add this PR also,
https://github.com/bagisto/bagisto/pull/5139

authors: devansh-webkul rsabzaali

repo: bagisto/bagisto


text:
ui issue when we add product in compare

Issue Description
ui issue when we add product in wishlist
Bagisto Version

[ ] master branch

Steps To Reproduce

login as a user in blisss theme

select any product from front page and add product into wishlist

Actual Result## Actual Result

working properly


text:
[vee-validate] No validator instance detected

Versions

vee-validate: 2.0.#
vue: 2.#.#

Hi, I'm new, I'll be happy if you tell me.
The page has two components with validation, so I decided to use scope. This functionality works, but in console.log throws warning: "[vee-validate] No validator instance detected". for each field. If I remove scope - warning no.
HTML

                  Имя
                  <input type="text" id="first-name" name="first_name" placeholder="Иван" class="input"
                         v-model="address.firstname"
                         @blur="blurFocusValidate('form-1.firstname', address.firstname)"
                         @input="inputValidate('form-1.firstname', address.firstname)"
                         :class="{'field-with-charact_error' : errors.has('form-1.firstname') }"
                  >

                        {{ errors.first('form-1.firstname') }}

<button class="button button_small button_blue button_radius"
            @click.prevent="submit('form-1')"
        >Добавить</button>

VUE
inject: ['$validator'],

submit(scope){
            this.$validator.validateAll(scope).then(result => {
                this.inputValidateFlag = true;
                if(result){
                    this.$store.dispatch('cart/addNewAddressOrUpdateAddress', this.address);
                }
            })
        },

this.$validator.attach({
            name: 'firstname',
            alias: 'имя',
            rules: 'required',
            scope: 'form-1',
            getter: () => this.address.firstname
        });

Do you mind recreating the example in jsfiddle or codesandbox.io as the issue could be related to multiple things.

A simple example, but warning is already there.
My example is more complicated, but I probably should start with a simple one.
https://codesandbox.io/s/pyjvxn2l8x

Any specific reason preventing you from using the v-validate directive, manually attaching the fields doesn't give you the full features. One of them is causing this warning. I will remove this warning since you decided to handle the fields manually.

Thanks for answers

authors: GrishinAnton logaretm

repo: baianat/vee-validate


text:
windows

这个能在windows跑吗

不大能，依赖的baidu/common库里的部分系统调用在windows下面是没有的，不过，欢迎移植common库：）

authors: wellorange yvxiang

repo: baidu/bfs


text:
按照md文件配置之后 一直返回282000

N0412 14:27:35.120452 19280 /home/cxd/unit-dmkit/src/app_container.cpp:99] logid=dmkit_351720 req={"bot_id": "S16244", "request": {"client_session": "{"client_results":"", "candidate_options":[]}", "bernard_level": 1, "query": "hi", "query_info": {"type": "TEXT", "source": "ASR", "asr_candidates": []}, "user_id": "63915", "updates": ""}, "version": "2.0", "bot_session": "", "log_id": "351720"} service_unit_bot=remote:153.37.235.92:443|tm:237|ret:0 ret={"error_code":282000,"error_msg":"Internal error"} tm=237.830668

S16244是机器人的ID吧？DMKit是在技能层面应用的。

S16244是机器人的ID吧？DMKit是在技能层面应用的。
bot_id难道不是要填机器人的id吗

bot_tokens.json

repo: baidu/unit-dmkit


text:
Hotfix: Add missing + to deploy script check.

There was a plus missing which made pushing to deploy branch break when the patch version is double digits, which just happened.

Merged this fix into #3485


text:
Express error middleware doesn't seem to be used

Node version: 10.21.0
Sails version (sails): 1.2.4
ORM hook version (sails-hook-orm): 2.1.1
Sockets hook version (sails-hook-sockets): not installed, although there are some lingering bits from when it was
Organics hook version (sails-hook-organics): not installed
Grunt hook version (sails-hook-grunt): 4.0.0
Uploads hook version (sails-hook-uploads): not installed
DB adapter & version (e.g. sails-mysql@5.55.5): sails-postgresql@1.0.2 (though I've been reproducing this using sails-disk in development)
Skipper adapter & version (e.g. skipper-s3@5.55.5): not installed (I think?)

Given the following in config/http.js:
  middleware: {
     order: [
       'cookieParser',
       'session',
       'bodyParser',
       'compress',
       'poweredBy',
       'router',
       'www',
       'favicon',
       'testError'
     ],

    testError: function(err, req, res, next) {
      sails.log.error('Test error');
      throw new Error('test error');
    }
  }

Any HTTP 500 error seems like it should cause Test error to be logged to the console, followed by an additional test error stack trace. But I don't see anything.
Am I meant to be using https://sailsjs.com/documentation/reference/response-res/res-server-error? This would probably work but feels wrong - for context, what I'm really trying to do is use Sentry's Express integration in my Sails app. So what I care about is not 500 errors per se, but instead just any error generated during request processing (though I admit that in the end for almost all apps these turn into 500 errors anyway). The middleware ordering also matters; I need this error middleware to be run before any other error middleware.

* Open source is our passion, and our core maintainers volunteer many of their nights and weekends working on Sails.  But you only get so many nights and weekends in life, and stuff gets done a lot faster when you can work on it during normal daylight hours.

Also as a P.S. to my bug report: thank you for maintaining Sails <3
I've just started using it after using bare Express for a long time and I gotta say, I'm starting to really like it.

Hi @strugee, thank you for your interest in Sails

Am I meant to be using https://sailsjs.com/documentation/reference/response-res/res-server-error?

YES! If you want to handle non 5XX errors, stick that in all of your custom response files (how you do this will affect the order)

authors: eashaw strugee

repo: balderdashy/sails