text:
Usermin: Mail: Enhancements

First off, I've started to like using Usermin for the first time in a "long, long" time as the updated Mail interface is really coming along.
Here are some suggestions for further enhancing the Mail experience (borrowed from Gmail).

More Icons Shown When Message(s) Checked (rather then in dropdown menu)
Archive Mail
Label Mail

== MORE ICONS SHOWN ==
When messages are checked in a folder, it would great to have
"Report Spam" (or "Report and Delete" depending on preferences) shown as a default icon in the shown list instead of having to expose this by clicking the dropdown as IMHO this is one of the most common things I'm doing when I'm checking a bunch of messages aside from moving them to another folder.
"Archive Mail" icon to quickly archive messages -- essentially move them to an Archive folder -- more on this in a moment.
"Label Mail" icon to quickly label a message -- similar to "moving" dialog but if I understand "Virtual Folders" correctly adding the message(s) to a "Virtual Folder" similar to labeling in Gmail.
== ARCHIVE MAIL ==
This would be done with a two part process. As a basic option you could simply have an "Archives" folder created and the messages moved there... As a more advanced option you could setup some preferences which like Thunderbird would let you define how archives are stored...
Ex.
Yearly (Achives.2021)
Monthly (Archives.2021.04 or Archives.2021-04)
Essentially this operation would sort of be a shortcut and a more advanced version of the "Move" operation with a predefined overall goal.
== LABEL MAIL ==
As mentioned above, if my understanding of Virtual Folders is correctly, they essentially are more or less like Labels... If so, one could create a Virtual Folder aka Label and then using this icon after selecting a message (or while reading one) could select one or more Labels (Virtual Folders)
As always, happy to contribute ideas which will further enhance the Authentic Theme, and Virtualmin/Webmin/Usermin overall.

Thanks, Peter. Thank you for your kind comments! I will consider your ideas when working again on the mail.
It is very time consuming process, requires a lot of dive-in. Honestly, it has never been prioritized over a dozen of other things we need to work on.
A plan for the near future is to create mail view page and integrate this new UI to Read User Mail (mailboxes module) in Webmin, and setup New Mail  tab in right side slider to display new mail messages for selected  mailboxes. That will be a great progress already when accomplished.

authors: iliarostovtsev tpnsolutions

repo: authentic-theme/authentic-theme


text:
🛑 Bitfee IT-Dokumentation is down

In 17d1353, Bitfee IT-Dokumentation (https://www.doku.ch) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Bitfee IT-Dokumentation is back up in 0c4e841.

source: gharchive/issue

repo: authentiqdigital/upptime

license: MIT

license_type: permissive

license_source: github-api


text:
🛑 Automat hlavní stranka § auto-mat.cz is down

In 07fbfa9, Automat hlavní stranka § auto-mat.cz (https://auto-mat.cz) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Automat hlavní stranka § auto-mat.cz is back up in 9d00526.

repo: auto-mat/automat-statuspage


text:
[build] Add py37 and py39 to build containers

Current containers support only py38 builds.
Add py37 and py39 support so that the tox builds can verify modules on different python versions.
See also:

tox-environments
https://github.com/tox-dev/tox/issues/1591

Closing - matrix tests were added for all python version/OS combinations in platform tests.

repo: autogluon/autogluon


text:
fix #31

about command failed... Not a Directory
resources are packaged in asar and it can't reachable by cp -r
write own copy function using plain node.js will work.
and seems asar will lose permission information so I made every copied files mod to 755

about signature
applet LICENSE file now is in bin/LICENSE.applet.txt, outside the bundle.

tested on mac, and only resolved packaging, #30 is still fallen.

@zh99998 first of all, can you provide steps and commands how do you pack your app in asar file?

I'm using electron-builder.

npm install electron-builder
put these into package.json scripts

    "pack": "tsc && build --dir",
    "dist": "tsc && build",

put there into package.json build
"build": {
"productName": "MyCard",
"appId": "com.mycard.mycard",
"category": "public.app-category.social-networking",
"publish": [
{
"provider": "generic",
"url": "https://wudizhanche.mycard.moe/downloads"
},
{
"provider": "github"
}
],
"extraResources": [
"bin"
],
"win": {
"target": [
"nsis"
]
},
"dmg": {
"contents": [
{
"x": 448,
"y": 344,
"type": "link",
"path": "/Applications"
},
{
"x": 192,
"y": 344,
"type": "file"
}
]
}
}

4. put codesign cert into environment variables.

export CSC_LINK=base64 -i xxx.p12
5. go

npm run pack

@zh99998 thanks for problem investigation, let try sign app with LICENSE moved into applet Content path, it could be resolve sign problem.

@automation-stack
does License file should be outside app bundle?
It will require some person to read it.
if put it in bundle means human will hardly access it.
have a look about electron-builder packet app
dist/mac structure is:
/
/MyCard.app
/LICENSE
/LICENSES.chromium.html

@zh99998 since applet is internal component it's normally pack it with LICENSE in Content directory. Let's try to move it there

@zh99998 nice idea about direct copy with fs, i'll add this patch into version with Sierra fixes and other improvements

closing this since long time inactive

source: gharchive/pull-request

repo: automation-stack/electron-sudo

license: mit

license_source: bigquery


text:
Adding a Get changes for causally ordered updates to the document

@alexjg I could use some Rust specific help - I've got a function stubbed, but with a likely obvious compilation error. I'm not very fluent with Rust internals, nor idiomatic rust - so help on both/either would be very appreciated.
I added a function on the wrapper doc called changes() with the idea of getting all changes by providing an empty vector to get_changes() in Automerge.
I'm getting the changes Vec<&Change>, but I'm not clear on how to convert that into Vec and the relatively obvious path of hoping there was an .into() available that I could call doesn't seem to be correct.
I also wasn't sure about returning the raw vector vs. something like Result<Vec<ChangeHash>, DocError> - and where errors would populate up from within the sequence of code to be entirely sure if an error could be thrown from within what I wrote.
related to #42

Re. error handling. I don't think we need to do any such thing here because get_changes is infallible.

@alexjg I think I've got this into something of a functional configuration. At first I screwed up and was calling heads() instead of changes(), but the tests are showing serial sequences of changes. I haven't yet tried to fully end-to-end use those as a values to get a document at each of those values as "heads", but I suspect I can use that to make a sort of "scroll through history" for the overall document.

authors: alexjg heckj

repo: automerge/automerge-swift


text:
[Slash Commands] Some commands will remain undeleted on exit on self-hosted bot

Issue description
Self-hosting bots delete all of registered commands on exit, but Docker defaults to sending a SIGKILL in 10 seconds after sending SIGTERM.
If command deletion is limited by a rate limit, the bot may be killed before all commands are deleted.
2022/02/23 04:48:33 Registering command map on guild 80258********36117
2022/02/23 04:49:03 Received Sigterm or Kill signal. Bot will terminate in 1 second
2022/02/23 04:49:04 Deleting slash commands
2022/02/23 04:49:04 Deleting command help on guild 80258********36117
2022/02/23 04:49:05 Deleting command info on guild 80258********36117
2022/02/23 04:49:05 Deleting command link on guild 80258********36117
2022/02/23 04:49:05 Deleting command unlink on guild 80258********36117
2022/02/23 04:49:06 Deleting command new on guild 80258********36117
2022/02/23 04:49:06 Deleting command end on guild 80258********36117
2022/02/23 04:49:06 [DG2] restapi.go:155:RequestWithLockedBucket() Rate Limiting https://discord.com/api/v8/applications/805101314429943828/guilds/80258********36117/commands/945666729038716948, retry in 18.692s
2022/02/23 04:49:06 You are being rate limited.
# 👆👆👆 Killed here during waiting for retry, and commands `refresh`, `privacy` and `map` are not deleted

Workaround
stop_grace_period option for automuteus should be specified: https://docs.docker.com/compose/compose-file/compose-file-v3/#stop_grace_period
This option extends the wait time for sending SIGKILL. It is safe to set 1m as default value, since failed deletions will be retried and completed with a wait time of about 20 seconds.
2022/02/23 04:49:03 Received Sigterm or Kill signal. Bot will terminate in 1 second
2022/02/23 04:49:04 Deleting slash commands
2022/02/23 04:49:04 Deleting command help on guild 80258********36117
2022/02/23 04:49:05 Deleting command info on guild 80258********36117
2022/02/23 04:49:05 Deleting command link on guild 80258********36117
2022/02/23 04:49:05 Deleting command unlink on guild 80258********36117
2022/02/23 04:49:06 Deleting command new on guild 80258********36117
2022/02/23 04:49:06 Deleting command end on guild 80258********36117
2022/02/23 04:49:06 [DG2] restapi.go:155:RequestWithLockedBucket() Rate Limiting https://discord.com/api/v8/applications/805101314429943828/guilds/80258********36117/commands/945666729038716948, retry in 18.692s
2022/02/23 04:49:06 You are being rate limited.
2022/02/23 04:49:25 Deleting command refresh on guild 80258********36117
2022/02/23 04:49:25 Deleting command privacy on guild 80258********36117
2022/02/23 04:49:25 Deleting command map on guild 80258********36117
2022/02/23 04:49:26 [DG2] wsapi.go:868:CloseWithCode() called
2022/02/23 04:49:26 [DG2] wsapi.go:874:CloseWithCode() closing listening channel
2022/02/23 04:49:26 [DG2] wsapi.go:884:CloseWithCode() sending close frame
2022/02/23 04:49:27 [DG2] wsapi.go:897:CloseWithCode() closing gateway websocket
2022/02/23 04:49:27 [DG2] wsapi.go:908:CloseWithCode() emit disconnect event
# 👆👆👆 The bot has been gracefully shutted down

Version
Upstream slash-commands branch in automuteus.

I'd also be open to the option of configuring the bot itself instead of Docker. I run the bot outside of docker when I develop it, so I could look into that option. The bot catches the SIGTERM signal already, but it could wait to ensure the commands are deleted properly before exiting

authors: denverquane kurokobo

repo: automuteus/deploy


text:
Refactor test suite

Typically massive PR where I decide it would be "neat" to do something and keep going till I've lost a weekend.

Build failed


text:
The command in the dataset

In the dataset measurement.json, what does command: 4 mean?
Does 1, 2, 3, 4 mean go straight, left turn, right turn, and lane maintenance？

-1: VOID, 1: LEFT, 2: RIGHT, 3: STRAIGHT, 4: LANEFOLLOW, 5: CHANGELANELEFT, 6: CHANGELANERIGHT

repo: autonomousvision/transfuser


text:
Update FileZilla.download.recipe

Change identifier so that Finder does not see file.download as a in-progress download file from Safari. Most other repos follow this standard where its com.github.user.download.APPNAME.
I'd recommend doing the same for all other download recipes you may have.

@bp88 Changing identifiers breaks any overrides users may have for these recipes, such that the overrides will no longer be able to find their parent recipes (those which they have overridden). So, it's usually strongly discouraged once a recipe has been out in the wild.
Some more info here:
https://github.com/autopkg/autopkg/wiki/Recipe-Writing-Guidelines#identifiers

@tsutton that's a good point. But then I'd point back to the same documentation that recommends following a certain naming format which the recipes in this repo aren't following. It's not like folks aren't going to notice if their override isn't working. They'll be able to fix it.

Maybe you know how to fix it, but there are plenty of users (possibly the majority) who don't understand that child recipes are linked to their parents using identifiers.

This is not a tool for an average joe. I won't argue that. But why would you expect people to be able to use this tool, create their own overrides, but not be able to understand what parent/child identifier relationships are? If you're using this tool and making overrides then clearly you have an understanding of how this tool works.
Plus, that's why the documentation is there in case you need to troubleshoot. I JUST started using this tool a few days ago and I understand the parent child relationships with identifiers because I read the documentation. In other words, you guys are quite clear in your documentation and how things work with recipes and how they should be named.
All I'm asking is that this and all the other recipes in this repo be updated to follow the proper naming convention. Short term pain, but long term it follows the proper standard naming convention for identifiers (which are obviously recommended for a reason). Otherwise there's no incentive to follow that naming convention at all and it sets bad precedent that others may follow. In fact, I would argue that repos accepted to autopkg should be following the standard naming convention before they are linked/accepted as searchable autopkg repos. It's a bit surprising to me that @keeleysam is one of the people overseeing the repos on Autopkg, but not following recommendations in the documentation.

Closing as existing identifiers won't be changed as it will break existing users.

authors: bp88 keeleysam timsutton

repo: autopkg/keeleysam-recipes


text:
ci(build-and-test): merge build-and-test and build-and-test-daily workflows

Description
This PR merges build-and-test and build-and-test-daily workflows. The implementation of build-and-test-daily was inefficient as it didn’t utilize caching and other optimizations, so triggers and conditions were added to build-and-test to integrate the two.
This change also improves maintainability.
Related links

How was this PR tested?
Notes for reviewers
None.
Interface changes
None.

Effects on system behavior
None.

I think -daily was intentionally not using cache to make sure that the code could be built with a clean environment just in case. However, since the risk for cache making any difference is low so I'm okay with merging it together. @xmfcx I just want to have your opinion as well.

authors: mitsudome-r youtalk


text:
refactor(behavior_path_planner): move common functions of side_shift and avoidance to utils

Description
move getUnshiftedEgoPose and calcCenterLinePath defined in side_shift and avoidance to utils.

Tests performed
Planning simulator works well with

[ ] old architecture
[x] new architecture

Effects on system behavior

No behavior change.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.

[x] I've confirmed the contribution guidelines.
[x] The PR follows the pull request guidelines.

In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.

[ ] The PR follows the pull request guidelines.

Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.

[ ] There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@satoshi-ota @kyoichi-sugahara Could you review the PR.


text:
fix(map_height_fitter): return failure service response when ground fitting failed

Description
If ground fitting fails, return the service immediately as a failure.
Until now, when there was no point cloud map around the specified initial position, the given height (basically z=0) was returned as is.  If the correct height is not given, the NDT will fail to estimate.

Tests performed
Two tests were performed using logging_simulator and sample rosbag.

How to test for case 1

# 1: Stop rosbag to prevent overwriting with correct gnss.
# 2: Set wrong gnss pose
 ros2 topic pub /sensing/gnss/pose_with_covariance geometry_msgs/msg/PoseWithCovarianceStamped "{pose: {pose: {position: {x: 89435, y: 42047}}}}"
# 3: Call the initialization service
 ros2 service call /api/localization/initialize autoware_adapi_v1_msgs/srv/InitializeLocalization

After the above steps, a error message appears in the console indicating that ground fitting has failed.
Also, the localization status becomes UNINITIALIZED.
How to test for case 2

# 1: Perform "2D Pose Estimate" in the area without a point cloud map as shown in the following figure.

After the above steps, a warning message appears in the console indicating that ground fitting has failed.
The localization status does not change.
Effects on system behavior

If ground fitting fails, the initial position estimation is aborted and a service failure is returned.
(Until now, initialization continued at the given elevation even if ground fitting failed.)
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.

[ ] I've confirmed the contribution guidelines.
[ ] The PR follows the pull request guidelines.

In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.

[ ] The PR follows the pull request guidelines.

Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.

[ ] There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

For case 2, no error when enable_partial_load: false. I think we have to change get_ground_height.

I have made a change so that get_ground_height() will fail if there are no points within a 50-meter (max_search_radius) range when determining the range of point cloud to consider.  Please see the line 154 to 157 the following link.
https://github.com/autowarefoundation/autoware.universe/blob/0171abbd1cdad18e0cc20dc47db0838a56ba783a/map/map_height_fitter/src/map_height_fitter.cpp#L140-L157

@isamu-takagi With the above changes, I believe the reported issue has been resolved.

For case 2, no error when enable_partial_load: false. I think we have to change get_ground_height.

I found the related issue https://github.com/autowarefoundation/autoware.universe/issues/2048
@VRichardJP  If you have any concerns about this PR, please let us know. :+1:

I have noticed that there is a possibility that YabLoc and Eagleye, which are pose_estimator does not rely on point cloud maps, may not be able to complete initial pose estimation. :cry:
I will temporarily mark this PR as a draft. I will also consider an implementation that works with a general pose_estimator.

authors: KYabuuchi isamu-takagi


text:
refactor(behavior_path_start_planner_module)!: prefix package and namespace with autoware

Description
Part of https://github.com/autowarefoundation/autoware/issues/4569
Related links

Tests performed
PSIM
Notes for reviewers

Interface changes

ROS Topic Changes

ROS Parameter Changes

Effects on system behavior

Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.

[x] I've confirmed the contribution guidelines.
[x] The PR follows the pull request guidelines.

In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.

[ ] The PR follows the pull request guidelines.
[ ] The PR has been properly tested.
[ ] The PR has been reviewed by the code owners.

Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.

[ ] There are no open discussions or they are tracked via tickets.
[ ] The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

this PR did not add autoware namespace


text:
PR for protonup-rs on nixpkgs

Hi, I just wanted to let you know I'm trying to get the package on nixpkgs.
I love your utility, I use it all the time and recommend it when people mention any protonup utility.
PR link

Thanks! This is very nice of you!

authors: auyer liperium

repo: auyer/Protonup-rs


text:
Wrap OS_Taskregister in OMIT_DEPRECATED define

Comments suggest this function is obsolete, wrap in #ifdef so code can easily be checked for dependence.

Imported from trac issue 232.  Created by jhageman on 2019-07-25T14:59:00, last modified: 2019-08-19T17:29:05

Trac comment by jhageman on 2019-07-26 15:13:27:
Milestone renamed

Trac comment by jhageman on 2019-08-14 12:45:44:
CCB 8/14/2019 - Not needed for next gen OSAL, could leave as noop.  Mark as deprecate agreed to.

Trac comment by jhageman on 2019-08-19 17:29:05:
Changes required to remove internal dependencies (stubs, unit tests, cfe, osal) exceed the level of "quick fix".  Pushing to next release.


text:
Revamp lap function

Why is it better?

Better styling
It has numberings
Offload all the clear function to one button only, "Reset"
It can adapt to dark mode

Feature preview:

Hi @avinash201199, I revised the PR since someone worked on the same feature as the one I did, consolidated it and make it adaptive to dark mode :)

now close the issue :)


text:
Email and Password Authentication Added but not Registered Email Verification

Is your feature request related to a problem? Please describe.
yes..... Email and Password Verification added already but not registered email verification...... Suppose someone signup as 'g@mail.com'... If there presents no such email, then a fake user can use this application..... So unethical activity can be performed through that..... So I want to add Email and password Verification...
Describe the solution you'd like
When users signup with an email and password, A verification Link Will send to the registered email.... After verifying the registered email through the link(send to registered email via firebase), User only can log in to the application..... (This feature is only for email and password auth not for google or Facebook auth because their authentication is done by default)..... This will make this app more authentic...
Describe alternatives you've considered
I think the above process is very good for the sake of auth...
Additional context
I am also a GSSOC'21 participant.... If I can forward with that.... Please assign me to here.... Thanks, @avinashkranjan @HimeshNayak

Go Ahead @SamarpanCoder2002

Go Ahead @SamarpanCoder2002

Thanks for assigning me.... I will work on that very soon

Go Ahead @SamarpanCoder2002

I already made a pull request regarding to that @HimeshNayak @avinashkranjan .... please review it and merge it.....

repo: avinashkranjan/Friday


text:
Jwt_Secret_Bruteforce_Script added

Description
Jwt_Secret_Bruteforce_Script is added
#398
Have you read the Contributing Guidelines on Pull Requests?

[x] Yes

Type of change
Please delete options that are not relevant.

[x] New feature (non-breaking change which adds functionality)

Checklist:

[x] My code follows the style guidelines(Clean Code) of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I've edited the SCRIPTS.md and link to my code.
[x] I have created a helpful and easy to understand README.md
[x] My documentation follows Template for README.md
[x] My changes generate no new warnings

@avinashkranjan don't merge this PR. This is copied from https://github.com/bing0o/Python-Scripts/blob/master/jwt-secret-bruteforce.py
Proof
@Kalivarapubindusree Code

Original code

This is the case of all the PR , So can you please take some action against him.

authors: Asurhumai Kalivarapubindusree


text:
working with kafka

Hi, I'm working with Kafka on Mulesoft, and I would like to pass the trace id from the publisher to the consumer, I tried to put a traceparent header, but the trace id did not propagate, is there already a way to do this or has it not been implemented yet?

@GabrielMller As per specs, traceparent does include traceId. See details about traceparent here. It is used by the consumer to establish parent-child relationship of the distributed traces. If the consumer side is this module, then that relationship will be established but the module does not pass or extract traceId from that traceparent.
If you need to send traceId as a separate header then you can set it, just like traceparent. vars.OTEL_TRACE_CONTEXT.traceId can give you the current trace id for propagating. Documentation was missing the latest screenshot but #115  should correct that gap.
I hope that answers what you are looking for.

Ok, thanks for your help!

Hi ,is this implemented yet ? Or is there any plans to implement it in the near future?

#223 implements support for propagating context with headers - See src/test/resources/mule-kafka-example.xml for publisher and consumer configuration examples.

authors: GabrielMller JYOTHI-SHRAVZ manikmagar


text:
[feat][wip] (ABC-514): Add responsive stretch class

Add boolean stretch to add .avonni-input-choice-set__stretch to button groups.

Ready for review

Behavior approved by JB. Stretch checkboxes and radio to full width and wrap around.

The tests are broken, because of the class name change I made you do. 😊

🤦♂ There!

repo: avonni/base-components


text:
Properly dockerize

Though, this is untested :(

We'll wait for the Docker Build to finish before merging.

ok fucc this merging

haaaa use a real CI

repo: awau/Clara


text:
How to do batch updates and deletes in amplify graph ql aws amplify

Note: If your question is regarding the AWS Amplify Console service, please log it in the
official AWS Amplify Console forum

** Which Category is your question related to? ** Graph QL
** What AWS Services are you utilizing? ** Aws Amplify
** Provide additional details e.g. code snippets **
I just want to know where is the documentation location on how to do batch updates
and deletes. Can you please provide clear answer how to do this?

Is Dynamo or Aurora Serverless your backing data source?
It's tough, AppSync doesn't seem to be designed or have ad-hoc support for these kind of traditional database operations, even though these situations crop up in natural architectures. And of course the Amplify team is constrained by service limitations in all categories.

My backend data source is Dynamo it would be a shame if this wasn't consider. I could use mysql with app sync but would i need to create custom mutations and would like to see if they could provide docs only docs i see is basic crud

@yuth thanks for your follow up regarding the issue. Amplify is becoming more and more popular these days hopefully you can add this feature soon. Maybe you can create a new directive for @batch and after we create the api and push and go back to modifiey the model we can maybe add @batch to the model so when we push again and now the resolvers know the table names since it's already created.
Thanks for your support

repo: aws-amplify/amplify-cli


text:
Getting CloudFormation error on Auth config updating during amplify push

Describe the bug
After an Amplify push, updating resources in the cloud failed on cognito configuration with the following message :
"Parameters: [userPoolGroupList, resourceNameTruncated, dependsOn] must have values"
Amplify CLI Version
4.2.0
Auth is configured with multi-auth : UserPool and Iam

I tried a new installation to get the tree missing parameters.
If added them in the former installation into the auth parameters.json.
After a push, the new error is pretty confusing :
"Parameters: [resourceNameTruncated, dependsOn, userPoolGroupList] do not exist in the template"

Ok i resolved it.
I tried an Amplify auth update
-> Create or update UserPool
Change nothing to the settings.
But it created a second named "userPoolGroup" witch caused a mess in the next "amplify push" I did.
So i tried a "amplify env pull --restore" that i already did previously but with no success.
And as a miracle the "Auth" line in the next "amplify status" stayed to "update".
And finally a last "amplify push" finished with no error !

Sorry i have forgotten to close.


text:
fix: fix to narrow view config type

Description of changes:

narrow down view configuration type
added enableOnRowClick prop in table config

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Codecov Report

Merging #568 (55a72e3) into tagged-release/forms-and-views (ab67240) will not change coverage.
The diff coverage is n/a.

@@                       Coverage Diff                       @@
##           tagged-release/forms-and-views     #568   +/-   ##
===============================================================
  Coverage                           89.62%   89.62%
===============================================================
  Files                                  78       78
  Lines                                2929     2929
  Branches                              799      799
===============================================================
  Hits                                 2625     2625
  Misses                                290      290
  Partials                               14       14

Impacted Files
Coverage Δ

packages/codegen-ui/lib/types/view/defaults.ts
100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab67240...55a72e3. Read the comment docs.

authors: codecov-commenter kpranoto-aws

repo: aws-amplify/amplify-codegen-ui


text:
fix: update fix onSubmit types for ds and custom

Issue #, if available:
Description of changes:

keep onSubmit naming function consistent between datastore and custom forms
change types for onSubmit for custom forms to also use Record<string, unknown>
remove instance of onSubmitBefore to avoid crashes when rendering form component

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Codecov Report

Merging #638 (746b5d2) into tagged-release/forms-and-views (714c032) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@                        Coverage Diff                         @@
##           tagged-release/forms-and-views     #638      +/-   ##
==================================================================
- Coverage                           90.22%   90.21%   -0.01%
==================================================================
  Files                                  96       96
  Lines                                3579     3577       -2
  Branches                              965      964       -1
==================================================================
- Hits                                 3229     3227       -2
  Misses                                324      324
  Partials                               26       26

Impacted Files
Coverage Δ

.../codegen-ui-react/lib/amplify-ui-renderers/form.ts
97.43% <100.00%> (ø)

...codegen-ui-react/lib/forms/form-renderer-helper.ts
92.10% <100.00%> (-0.14%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 714c032...746b5d2. Read the comment docs.

authors: SwaySway codecov-commenter


text:
chore: update maintainer list in new_issue action (#2337)

Issue #, if available:
N/A
Description of changes:
Cherry picks commit that never made it to main when branches were renamed as part of v2 launch.
Check points: (check or cross out if not relevant)

[ ] ~Added new tests to cover change, if needed~
[ ] ~Build succeeds with all target using Swift Package Manager~
[ ] ~All unit tests pass~
[ ] ~All integration tests pass~
[x] Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
[ ] ~Documentation update for the change if required~
[x] PR title conforms to conventional commit style~
[ ] ~If breaking change, documentation/changelog update with migration instructions~

DataStore checkpoints (check when completed)

[ ] ~Ran AWSDataStorePluginIntegrationTests~
[ ] ~Ran AWSDataStorePluginV2Tests~
[ ] ~Ran AWSDataStorePluginMultiAuthTests~
[ ] ~Ran AWSDataStorePluginCPKTests~
[ ] ~Ran AWSDataStorePluginAuthCognitoTests~
[ ] ~Ran AWSDataStorePluginAuthIAMTests~

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

No longer necessary thanks to:

https://github.com/aws-amplify/amplify-swift/pull/3269

repo: aws-amplify/amplify-swift


text:
Add Neptune samples

AWS::Neptune::DBCluster
AWS::Neptune::DBClusterParameterGroup
AWS::Neptune::DBInstance
AWS::Neptune::DBParameterGroup
AWS::Neptune::DBSubnetGroup

@ericzbeard Thanks for approving my pull request, can we close this issue as well?

repo: aws-cloudformation/iac-model-evaluation


text:
Refactor to remove duplicate creation of ackmodel in pipeline

Summary
The code-generator takes ackmodel as an input (i.e. CRDs), processes the data alongside config, and applies templates against the updated data to output Go code. Each command in the pipeline, api and controller, constructs ackmodel itself, which is inefficient and creates an implicit dependency on $SERVICE-controller (the repo for which we are generating code). These problems can be solved by adding ackmodel to the existing ACK cache and loading the model from cache (or create if not present) in both commands. This solution ensures ackmodel is created once per pipeline (i.e. a given api version) and also removes the need to check API version in the $SERVICE-controller repo.
Context
This is the parent issue to track and implement changes to refactor ackmodel in the code-generator pipeline. The proposal detailing the approach can be found here. Changes to how ackmodel is created are not in the scope of this issue.
Implementation

[ ] Refactor ackmodel to expose fields for json serialization
- Note some attrs such as SDKAPI and cfg will be bulky; some options: don't serialize these fields, b64 encoding/decoding, removing completely
[ ] Remove getLatestAPIVersion(). Add an optional cli input for both commands, apiVersion,  and use stable version as default
[ ] Update loadModel logic to load ackmodel from cache ackmodel or create its own using cli args (ex: apiVersion) if not present

/lifecycle frozen

authors: A-Hilaly brycahta


text:
Allow users to exclude some values from id and sanitized tag outputs

Overview

include terraform-docs
awscc user_agent
content changes described below for tag sanitization
reorganize tests into 1 file per example
write tests for optional attribute passing and reordering id

Previously tags were being populated for account, name, namespace, and env even if those variables weren't populated. This change allows you optionally include some or all parameters. Excluding all merely allows this module to sanitize tags for use with either aws & awscc. Including some creates an id that you can use as a naming prefix for resources.
By default the id is ordered as:
namespace-account-env-name
This order can be changed by updating var.id_order.
If you omit some values without changing var.id_order the same order will be preserved. For example, if account is not provided it will yield namespace-env-name.
tests:
--- PASS: TestFormattedTags (79.92s)
PASS
ok      github.com/aws-ia/terraform-aws-terraform/m/v2  80.091s

Open questions:

Previously the null_resource was used. From what I could tell, there was no specific reason to use this as the output value for tags, etc. I updated the code so we CAN use null_resouce (see below). Would like input as to if its ok to remove prior to merge
output attributes has been removed. Unsure of its usage since they were not appended to the tag output. Attributes can still be passed as a variable to be included in id. Willing to work this back in with some extra context on its purpose.

null_resource update if we actually need it
resource "null_resource" "default" {
  triggers = local.non_empty_vars_map

  lifecycle {
    create_before_destroy = true
  }
}

I converted this to draft, pending unit tests.

new unit tests included and i reorganized pre-existing tests:
PASS
ok      github.com/aws-ia/terraform-aws-terraform/m/v2  95.082s

authors: andrew-glenn drewmullen

repo: aws-ia/terraform-aws-label


text:
JS Sample App

Description: This is an Opentelemetry Javascript Sampleapp featuring metrics, traces, and context propagation.

[x] Parse config file & use default values
[x]  Generate random based metrics
[x] Implement 3 endpoints (/outgoing-http-call /aws-sdk-call /outgoing-sampleapp)
[x] Add request based traces
[x] Add request based metrics
[x] Support invocation of other sample apps

Link to tracking Issue:
Testing Performed:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

FYI - Making this PR to Draft.

FYI - Making this PR to Draft.

Hi. Thanks. It is ready for review now.

authors: NickSulistio PaurushGarg vasireddy99

repo: aws-observability/aws-otel-community


text:
Update README.md to indicate that lambda layer collector can also work with natively compiled lambdas

Description:
Update wording on the different lambda layer collectors, to indicate that the general collector layer will also work with natively compiled lambdas that have preexisting instrumentation.
Link to tracking Issue:
Testing:
Documentation:
Update wording on the different lambda layer collectors, to indicate that the general collector layer will also work with natively compiled lambdas that have preexisting instrumentation.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Thanks for the PR, can you please resolve the conflicts?

Thanks for the PR, can you please resolve the conflicts?

The conflicts are resolved now.

Second this, would prevent alot of confusion

authors: arun-annamalai mcawte vasireddy99

repo: aws-observability/aws-otel-lambda


text:
Doc edits

Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/do-doc-build


text:
ERR_PACKAGE_PATH_NOT_EXPORTED

Good day,
I am trying to follow with example from https://github.com/aws-samples/amazon-cognito-passwordless-auth/blob/main/CUSTOMIZE-AUTH.md#1-create-your-own-lambda-function-using-this-library-and-call-configure
but when I add the sample code to my stack.ts right before I call to construct I have an error
Error [ERR_PACKAGE_PATH_NOT_EXPORTED]: Package subpath './custom-auth' is not defined by "exports" in C:\Users\user\work\AWS-cognito\cdk\node_modules\amazon-cognito-passwordless-auth\package.json
Without the sample injection code works as expected.
import * as cdk from "aws-cdk-lib";
import { Construct } from "constructs";
import { Passwordless } from "amazon-cognito-passwordless-auth/cdk";
import { magicLink } from "amazon-cognito-passwordless-auth/custom-auth";

const sesFromAddress: string =
  "Login Link <test@test.com>";

export { createAuthChallengeHandler as handler } from "amazon-cognito-passwordless-auth/custom-auth";

const defaultConfig = magicLink.configure();

magicLink.configure({
  async contentCreator({ secretLoginLink }) {
    return {
      html: {
        data: `
Your login link: sign in
This link is valid for ${Math.floor(
          defaultConfig.secondsUntilExpiry / 60
        )} minutes
Do not share this email with anyone.
`,
        charSet: "UTF-8",
      },
      text: {
        data: `Your login link: ${secretLoginLink}`,
        charSet: "UTF-8",
      },
      subject: {
        data: "Your login link",
        charSet: "UTF-8",
      },
    };
  },
});

class stackID extends cdk.Stack {
  passwordless: Passwordless;
  constructor(scope?: Construct, id?: string, props?: cdk.StackProps) {
    super(scope, id, props);
    // const spa = cloudfrontServedEmptySpaBucket(this, "ExampleSpa");

    this.passwordless = new Passwordless(this, "Passwordless", {
      allowedOrigins: [
        "http://localhost:5173",

      ],
      clientMetadataTokenKeys: ["consent_id"],
      magicLink: {
        sesFromAddress,
        secretsTableProps: {
          removalPolicy: cdk.RemovalPolicy.DESTROY,
          billingMode: cdk.aws_dynamodb.BillingMode.PAY_PER_REQUEST,
        },
      },
      userPoolProps: {
        removalPolicy: cdk.RemovalPolicy.DESTROY,
      },
      fido2: {
        authenticatorsTableProps: {
          removalPolicy: cdk.RemovalPolicy.DESTROY,
          billingMode: cdk.aws_dynamodb.BillingMode.PAY_PER_REQUEST,
        },
        relyingPartyName: "Passwordless Fido2",
        allowedRelyingPartyIds: [
          "localhost",

        ],
        attestation: "none",
        userVerification: "required",
      },
      smsOtpStepUp: {},
      userPoolClientProps: {
        idTokenValidity: cdk.Duration.minutes(5),
        accessTokenValidity: cdk.Duration.minutes(5),
        refreshTokenValidity: cdk.Duration.hours(1),

        preventUserExistenceErrors: false,
      },
      // while testing/experimenting it's heplful to see e.g. full request details in logs:
      logLevel: "DEBUG",

  }
}

const app = new cdk.App();
const stack = new stackID(app, "test");

Hi @myevit it doesn't work to define the lambda code and CDK code in the same file (that would be cool but right now CDK doesn't really support that).
So instead, you have to create the lambda code in a separate file (in a separate dir too probably) as you normally would for a Lambda function in CDK, and reference that in your CDK code.

Hi! Any chance to see an example of how this was solved? I'm stuck on this issue and can't implement the custom lambda. I have this code on a separate file (custom-auth.js):
// custom-auth.ts
import { magicLink } from "amazon-cognito-passwordless-auth/custom-auth";

// Export the solution's handler to be the handler of YOUR Lambda function too:
export { createAuthChallengeHandler as handler } from "amazon-cognito-passwordless-auth/custom-auth";

// Calling configure() without arguments retrieves the current configuration:
const defaultConfig = magicLink.configure();

// Swap in your own logic:
magicLink.configure({
	sesFromAddress: "no-reply@example.com",
	async contentCreator({ secretLoginLink }) {
		return {
			html: {
				data: `
Your secret sign-in link: sign in
This link is valid for ${Math.floor(
					defaultConfig.secondsUntilExpiry / 60
				)} minutes

`,
				charSet: "UTF-8",
			},
			text: {
				data: `Your secret sign-in link: ${secretLoginLink}`,
				charSet: "UTF-8",
			},
			subject: {
				data: "Your secret sign-in link",
				charSet: "UTF-8",
			},
		};
	},
});

Then I imported this file on cdk-stack.ts:
import { handler as createAuthChallengeHandler } from "./custom-auth.js";
Where do I use createAuthChallengeHandler?
I tried to use it as the value of createAuthChallengeFn on the Passwordless constructor with no luck:
 const passwordless = new Passwordless(
this,
"Passwordless",
{
	userPool,
	allowedOrigins: [
		process.env.WS_PREVIEW_URL!,
		`https://${distribution.distributionDomainName}`, // Allow CDN
	],
	fido2: {
		allowedRelyingPartyIds: [
			process.env.WS_PREVIEW_HOST!,
			distribution.distributionDomainName, // Allow CDN
		],
	},
	createAuthChallengeFn: createAuthChallengeHandler,
	magicLink: {
		sesFromAddress: "no-reply@arrive.services",
	},
}
);

Any help is appreciated!

Also tried this configuration on the Passwordles construct:
functionProps: {
	createAuthChallenge: {
		// Override entry, to point to your custom code:
		entry: join(__dirname, "./custom-auth.ts"),
	},
},

With this, it deploys the stack, but when I'm trying to get the magic link I've got this error:
CreateAuthChallenge invocation failed due to error Socket timeout while invoking Lambda function.

authors: alejandrog79 myevit ottokruse


text:
FSx for Luster client is not installed on Ubuntu 20.04

The FSx for Lustre client is not installed on Ubuntu 20.04 based override AMI.

Hash commit 2b717811090bd0e445fd018a2d6e22e086705e71 resolves this issue.


text:
Issue in Module 2a

When trying to test the service locally, I get this error:
ImportError: cannot import name 'json' from 'itsdangerous' (/usr/local/lib/python3.8/dist-packages/itsdangerous/init.py)

This error can be solved by either upgrading Flask > 2.0 or downgrading ItsDangerous < 2.0 and its MarkUp< 2.0 in the requirements.txt file.
boto3==1.11.16
Flask==1.1.1
itsdangerous==1.1.0
markupsafe==1.1.1
Flask-Cors==3.0.8
werkzeug<1.0

This is the related github flask issue https://github.com/pallets/flask/issues/4455 that hashes out the details


text:
Unable to deploy Swift samples

Seems to be related to the Output block of the template, but after running sam deploy I ran into this error:
➜  swift-custom-runtime git:(master) sam deploy

	Deploying with following values
	===============================
	Stack name                 : swift-lambda-test
	Region                     : us-east-1
	Confirm changeset          : False
	Deployment s3 bucket       : aws-sam-cli-managed-default-samclisourcebucket-10u0ftc8l2tv
	Capabilities               : ["CAPABILITY_IAM"]
	Parameter overrides        : {}

Initiating deployment
=====================
SwiftApi may not have authorization defined.

Waiting for changeset to be created..
Error: Failed to create changeset for the stack: swift-lambda-test, ex: Waiter ChangeSetCreateComplete failed: Waiter encountered a terminal failure state Status: FAILED. Reason: Unresolved resource dependencies [ServerlessHttpApi] in the Outputs block of the template

Using

Docker version 19.03.8, build afacb8b
SAM CLI, version 0.53.0
macOS Catalina 10.15.5

This should be fixed. Thanks!

authors: leopic singledigit

repo: aws-samples/sessions-with-aws-sam


text:
sample workflow pattern using lambda for long running workflow

You can create a state machine that uses a Lambda function to start a new execution before the current execution terminates. Using this approach to continue your ongoing work in a new execution enables you to have a state machine that can break large jobs into smaller workflows, or to have a state machine that runs indefinitely.
Issue #, if available:
Description of changes:
Creating a new patter based on:
https://docs.aws.amazon.com/step-functions/latest/dg/tutorial-use-lambda-cont-exec.html
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

This is missing an workflow.asl.json file and a correct workflow image (exported from workflow studio).

Closing this pull request as there's been no update in 1 month


text:
Error when triggering CIS 1.4 remediation with '@' character in username

Describe the bug
When CIS 1.4 remediation is triggered on a IAM principal with the '@' character in the username, I get the following error:
Traceback (most recent call last):
File "/tmp/e0034708-8dff-4cd9-841c-d31ea816b4c6-2022-03-29-11-18-35/customer_script.py", line 97, in unrotated_key_handler
user_name = get_user_name(event.get("IAMResourceId"))
File "/tmp/e0034708-8dff-4cd9-841c-d31ea816b4c6-2022-03-29-11-18-35/customer_script.py", line 46, in get_user_name
resource_name = list_discovered_resources_response.get("resourceIdentifiers")[0].get("resourceName")
IndexError: list index out of range
IndexError - list index out of range
To Reproduce

Create a user with a username containing the '@' character
Trigger CIS 1.4 remediation

Expected behavior
The remediation should work without errors.
Please complete the following information about the solution:

[ ] Version: v1.4.2
[ ] Region: eu-west-1
[ ] Was the solution modified from the version published on this repository? No

Can you please confirm that you've taken the following troubleshooting steps:

Is AWS Config service enabled in the region?
Is Config configured to record global (IAM) resources? This is an additional checkbox in the Config settings.

Without these prerequisites, the Config service API won't respond how we expect.
If those items are configured properly, can you share what the input to the remediation runbook (SHARR-RevokeUnrotatedKeys) execution is for the parameter IAMResourceId? You can find this in the SSM console under Automation. A redacted version is fine. I expect to see an AWS Config resource ID for the IAM User, which you can confirm is the case by running aws configservice list-discovered-resources --resource-type AWS::IAM::User --resource-name <your_user_name> and checking that the value matches the response resource ID. It might look something like AIDACKCEVSQ6C2EXAMPLE.
Since your Config API call is returning no resources, I'm guessing that value doesn't match. If the control runbook execution step output selector did not match anything in the output payload, it will pass in the string literal {{ ParseInput.IAMResourceId }} to the remediation. The other possibility is that the finding data from Security Hub is not giving us the resource ID we expect.
Even after we figure out what's going on with the resource ID, I am running into problems with us expecting date strings from the IAM API calls, when the response is actually a datetime object. We will add this bug to our backlog.

@dnlprplt Hello! This is in our backlog and will be reviewed/fixed in an upcoming release.

@rakshb I noticed that CIS.1.4 is not passing "UserId" to the SSM document instead it is passing "IAMResourceId" Is it correct? Also noticed that str_time_to_datetime is not required for CreateDate and LastUsedDate since get_access_key_last_used method returns a date object.

@asithagihan thanks for the note, you are correct on both counts. Like @rakshb mentioned these bugs are in our backlog and will be fixed in an upcoming release.

fixed in v1.5.0

authors: asithagihan dnlprplt gsingh04 hearde rakshb


text:
Redaction occurring in non-user-input fields

Describe the bug
Redaction is checked on all keys in request/response objects outside the specific exclusion of FirstSeen and LastSeen, this can lead to invalid data and failed import to OpenSearch. Adding more keys to the exclusion list is possible but there are potentially over 100 keys that would need to be added to the list to cover all scenarios.
To Reproduce
Comprehend needs to identify PII. Seems most impactful when it identifies a single digit/character or a common element (like QID). This appears to only show up in higher volume usage.
Expected behavior
User input should be redacted when enabled, but bot information, session IDs, timestamps, and settings should be skipped.
Please complete the following information about the solution:

[x] Version: v6.1.1
[x] Region: us-west-2
[x] Was the solution modified from the version published on this repository? Yes
[x] If the answer to the previous question was yes, are the changes available on GitHub? No
[x] Have you checked your service quotas for the services this solution uses? I checked to ensure Comprehend average usage was lower than service threshold
[x] Were there any errors in the CloudWatch Logs? No errors found in Fulfillment Lambda logs with debug enabled.

Screenshots
Comprehend identified '2' as a problematic digit:

All 2's were redacted out of other string fields (with the exception of FirstSeen and LastSeen):

The invalid date caused error importing into OpenSearch:

Additional context
Solution appears to use Comprehend to analyze the input transcript/question for the specific locations with detected PII, then stores the strings at those locations as regex capture groups in an environment variable. Regex then uses this env variable to redact data in all fields. So if Comprehend recognizes "QID" as PII that QID is then removed from all string values within request and response.

Thanks. We will review and revert to you

Hi @ferg-dev, thanks for reporting this. I tried to reproduce this on the latest v6.1.5 but was unsuccessful. In my test, I enabled redacting using Comprehend and provided SSN (all 2s), credit card (all 2s), and number 2. The redaction appeared to work successfully based on what I observed in OpenSearch Dashboards > Discover.

To help further investigate, please let us know:

You mentioned you're using v6.1.1 in the description. Are you able to see this issue in the latest version? We released improvements in v6.1.4, and it would be helpful if you could try this version since I am unable to reproduce the issue.

Which logs did you see the parsing error you posted?

You mentioned it failed. Could you please confirm whether you are performing any manual imports outside of the automatic workflows in QnABot?

Are you customizing other settings such as redaction confidence score and setting it lower than the default 0.99? I tried both 0.99 and 0.8 but was unable to reproduce the issue.

authors: abhirpat ferg-dev fhoueto-amz

repo: aws-solutions/qnabot-on-aws