text:
HTTP ERROR 503 - Service Unavailable

More and more issues.... not a very good experience so far of even getting the management server working.
It is set to the correct IP in the properties but and started the service and so on but still getting this error
HTTP ERROR 503
Problem accessing /client/. Reason:
Service Unavailable

@vvaleriev
you need to downgrade mysql-connector-java from 8.0.X to 5.1.X

hi @weizhouapache, curious to know how you figured this out ? didn't find it obvious after looking at the logs..

@skattoju4 the workaround is provided in #3826

@vvaleriev
you need to downgrade mysql-connector-java from 8.0.X to 5.1.X

which is the procedure to downgrade? i am completely new to cloudstack and yesterday installed and faced this issue

@AlexanderKgr you can downgrade to specified version using yum if you use CentOS/RHEL, or apt if you use Ubuntu/Debian.

Hi, I'm trying startup cloudstack-management.service, but failed.
I installed cloudstack-management 4.11 in centos7.
Here are the env:
mysql  Ver 14.14 Distrib 5.7.31, for Linux (x86_64) using  EditLine wrapper
java openjdk version "1.8.0_252"
2020-07-17 04:34:21,829 INFO  [c.c.u.DatabaseUpgradeChecker] (main:null) (logid:) Grabbing lock to check for database upgrade.
2020-07-17 04:34:21,866 ERROR [c.c.u.d.DbUtil] (main:null) (logid:) GET_LOCK() throws exception
java.sql.SQLException: Operation not allowed for a result set of type ResultSet.TYPE_FORWARD_ONLY.
at com.mysql.cj.jdbc.exceptions.SQLError.createSQLException(SQLError.java:129)
at com.mysql.cj.jdbc.exceptions.SQLError.createSQLException(SQLError.java:97)
at com.mysql.cj.jdbc.exceptions.SQLExceptionsMapping.translateException(SQLExceptionsMapping.java:122)
at com.mysql.cj.jdbc.result.ResultSetImpl.first(ResultSetImpl.java:584)
at org.apache.commons.dbcp2.DelegatingResultSet.first(DelegatingResultSet.java:402)
at org.apache.commons.dbcp2.DelegatingResultSet.first(DelegatingResultSet.java:402)
at com.cloud.utils.db.DbUtil.getGlobalLock(DbUtil.java:210)
at com.cloud.utils.db.GlobalLock.lock(GlobalLock.java:154)
at com.cloud.upgrade.DatabaseUpgradeChecker.check(DatabaseUpgradeChecker.java:641)
at org.apache.cloudstack.spring.lifecycle.CloudStackExtendedLifeCycle.checkIntegrity(CloudStackExtendedLifeCycle.java:65)
at org.apache.cloudstack.spring.lifecycle.CloudStackExtendedLifeCycle.start(CloudStackExtendedLifeCycle.java:55)
at org.springframework.context.support.DefaultLifecycleProcessor.doStart(DefaultLifecycleProcessor.java:183)
at org.springframework.context.support.DefaultLifecycleProcessor.access$200(DefaultLifecycleProcessor.java:52)
at org.springframework.context.support.DefaultLifecycleProcessor$LifecycleGroup.start(DefaultLifecycleProcessor.java:358)
at org.springframework.context.support.DefaultLifecycleProcessor.startBeans(DefaultLifecycleProcessor.java:159)
at org.springframework.context.support.DefaultLifecycleProcessor.onRefresh(DefaultLifecycleProcessor.java:123)
at org.springframework.context.support.AbstractApplicationContext.finishRefresh(AbstractApplicationContext.java:884)
at org.springframework.context.support.AbstractApplicationContext.refresh(AbstractApplicationContext.java:552)
at org.apache.cloudstack.spring.module.model.impl.DefaultModuleDefinitionSet.loadContext(DefaultModuleDefinitionSet.java:145)
at org.apache.cloudstack.spring.module.model.impl.DefaultModuleDefinitionSet$2.with(DefaultModuleDefinitionSet.java:122)
at org.apache.cloudstack.spring.module.model.impl.DefaultModuleDefinitionSet.withModule(DefaultModuleDefinitionSet.java:245)
at org.apache.cloudstack.spring.module.model.impl.DefaultModuleDefinitionSet.withModule(DefaultModuleDefinitionSet.java:250)
at org.apache.cloudstack.spring.module.model.impl.DefaultModuleDefinitionSet.withModule(DefaultModuleDefinitionSet.java:233)
at org.apache.cloudstack.spring.module.model.impl.DefaultModuleDefinitionSet.loadContexts(DefaultModuleDefinitionSet.java:117)
at org.apache.cloudstack.spring.module.model.impl.DefaultModuleDefinitionSet.load(DefaultModuleDefinitionSet.java:79)
at org.apache.cloudstack.spring.module.factory.ModuleBasedContextFactory.loadModules(ModuleBasedContextFactory.java:37)
at org.apache.cloudstack.spring.module.factory.CloudStackSpringContext.init(CloudStackSpringContext.java:71)
at org.apache.cloudstack.spring.module.factory.CloudStackSpringContext.(CloudStackSpringContext.java:58)
at org.apache.cloudstack.spring.module.factory.CloudStackSpringContext.(CloudStackSpringContext.java:62)
at org.apache.cloudstack.spring.module.web.CloudStackContextLoaderListener.contextInitialized(CloudStackContextLoaderListener.java:52)
at org.eclipse.jetty.server.handler.ContextHandler.callContextInitialized(ContextHandler.java:890)
at org.eclipse.jetty.servlet.ServletContextHandler.callContextInitialized(ServletContextHandler.java:532)
at org.eclipse.jetty.server.handler.ContextHandler.startContext(ContextHandler.java:853)
at org.eclipse.jetty.servlet.ServletContextHandler.startContext(ServletContextHandler.java:344)
at org.eclipse.jetty.webapp.WebAppContext.startWebapp(WebAppContext.java:1515)
at org.eclipse.jetty.webapp.WebAppContext.startContext(WebAppContext.java:1477)
at org.eclipse.jetty.server.handler.ContextHandler.doStart(ContextHandler.java:785)
at org.eclipse.jetty.servlet.ServletContextHandler.doStart(ServletContextHandler.java:261)
at org.eclipse.jetty.webapp.WebAppContext.doStart(WebAppContext.java:545)
at org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:68)
at org.eclipse.jetty.util.component.ContainerLifeCycle.start(ContainerLifeCycle.java:133)
at org.eclipse.jetty.util.component.ContainerLifeCycle.doStart(ContainerLifeCycle.java:107)
at org.eclipse.jetty.server.handler.AbstractHandler.doStart(AbstractHandler.java:113)
at org.eclipse.jetty.server.handler.gzip.GzipHandler.doStart(GzipHandler.java:273)
at org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:68)
at org.eclipse.jetty.util.component.ContainerLifeCycle.start(ContainerLifeCycle.java:133)
at org.eclipse.jetty.util.component.ContainerLifeCycle.doStart(ContainerLifeCycle.java:115)
at org.eclipse.jetty.server.handler.AbstractHandler.doStart(AbstractHandler.java:113)
at org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:68)
at org.eclipse.jetty.util.component.ContainerLifeCycle.start(ContainerLifeCycle.java:133)
at org.eclipse.jetty.server.Server.start(Server.java:418)
at org.eclipse.jetty.util.component.ContainerLifeCycle.doStart(ContainerLifeCycle.java:107)
at org.eclipse.jetty.server.handler.AbstractHandler.doStart(AbstractHandler.java:113)
at org.eclipse.jetty.server.Server.doStart(Server.java:385)
at org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:68)
at org.apache.cloudstack.ServerDaemon.start(ServerDaemon.java:200)
at org.apache.cloudstack.ServerDaemon.main(ServerDaemon.java:101)
2020-07-17 04:34:21,870 WARN  [o.a.c.s.m.c.ResourceApplicationContext] (main:null) (logid:) Exception encountered during context initialization - cancelling refresh attempt: org.springframework.context.ApplicationContextException: Failed to start bean 'cloudStackLifeCycle'; nested exception is com.cloud.utils.exception.CloudRuntimeException: Unable to acquire lock to check for database integrity.
2020-07-17 04:34:21,871 WARN  [o.e.j.w.WebAppContext] (main:null) (logid:) Failed startup of context o.e.j.w.WebAppContext@77be656f{/client,file:///usr/share/cloudstack-management/webapp/,UNAVAILABLE}{/usr/share/cloudstack-management/webapp}
org.springframework.context.ApplicationContextException: Failed to start bean 'cloudStackLifeCycle'; nested exception is com.cloud.utils.exception.CloudRuntimeException: Unable to acquire lock to check for database integrity.
at org.springframework.context.support.DefaultLifecycleProcessor.doStart(DefaultLifecycleProcessor.java:186)
at org.springframework.context.support.DefaultLifecycleProcessor.access$200(DefaultLifecycleProcessor.java:52)
at org.springframework.context.support.DefaultLifecycleProcessor$LifecycleGroup.start(DefaultLifecycleProcessor.java:358)
at org.springframework.context.support.DefaultLifecycleProcessor.startBeans(DefaultLifecycleProcessor.java:159)
at org.springframework.context.support.DefaultLifecycleProcessor.onRefresh(DefaultLifecycleProcessor.java:123)
at org.springframework.context.support.AbstractApplicationContext.finishRefresh(AbstractApplicationContext.java:884)
at org.springframework.context.support.AbstractApplicationContext.refresh(AbstractApplicationContext.java:552)
at org.apache.cloudstack.spring.module.model.impl.DefaultModuleDefinitionSet.loadContext(DefaultModuleDefinitionSet.java:145)
at org.apache.cloudstack.spring.module.model.impl.DefaultModuleDefinitionSet$2.with(DefaultModuleDefinitionSet.java:122)
at org.apache.cloudstack.spring.module.model.impl.DefaultModuleDefinitionSet.withModule(DefaultModuleDefinitionSet.java:245)
at org.apache.cloudstack.spring.module.model.impl.DefaultModuleDefinitionSet.withModule(DefaultModuleDefinitionSet.java:250)
at org.apache.cloudstack.spring.module.model.impl.DefaultModuleDefinitionSet.withModule(DefaultModuleDefinitionSet.java:233)
at org.apache.cloudstack.spring.module.model.impl.DefaultModuleDefinitionSet.loadContexts(DefaultModuleDefinitionSet.java:117)
at org.apache.cloudstack.spring.module.model.impl.DefaultModuleDefinitionSet.load(DefaultModuleDefinitionSet.java:79)
at org.apache.cloudstack.spring.module.factory.ModuleBasedContextFactory.loadModules(ModuleBasedContextFactory.java:37)
at org.apache.cloudstack.spring.module.factory.CloudStackSpringContext.init(CloudStackSpringContext.java:71)
at org.apache.cloudstack.spring.module.factory.CloudStackSpringContext.(CloudStackSpringContext.java:58)
at org.apache.cloudstack.spring.module.factory.CloudStackSpringContext.(CloudStackSpringContext.java:62)
at org.apache.cloudstack.spring.module.web.CloudStackContextLoaderListener.contextInitialized(CloudStackContextLoaderListener.java:52)
at org.eclipse.jetty.server.handler.ContextHandler.callContextInitialized(ContextHandler.java:890)
at org.eclipse.jetty.servlet.ServletContextHandler.callContextInitialized(ServletContextHandler.java:532)
at org.eclipse.jetty.server.handler.ContextHandler.startContext(ContextHandler.java:853)
at org.eclipse.jetty.servlet.ServletContextHandler.startContext(ServletContextHandler.java:344)
at org.eclipse.jetty.webapp.WebAppContext.startWebapp(WebAppContext.java:1515)
at org.eclipse.jetty.webapp.WebAppContext.startContext(WebAppContext.java:1477)
at org.eclipse.jetty.server.handler.ContextHandler.doStart(ContextHandler.java:785)
at org.eclipse.jetty.servlet.ServletContextHandler.doStart(ServletContextHandler.java:261)
at org.eclipse.jetty.webapp.WebAppContext.doStart(WebAppContext.java:545)
at org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:68)
at org.eclipse.jetty.util.component.ContainerLifeCycle.start(ContainerLifeCycle.java:133)
at org.eclipse.jetty.util.component.ContainerLifeCycle.doStart(ContainerLifeCycle.java:107)
at org.eclipse.jetty.server.handler.AbstractHandler.doStart(AbstractHandler.java:113)
at org.eclipse.jetty.server.handler.gzip.GzipHandler.doStart(GzipHandler.java:273)
at org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:68)
at org.eclipse.jetty.util.component.ContainerLifeCycle.start(ContainerLifeCycle.java:133)
at org.eclipse.jetty.util.component.ContainerLifeCycle.doStart(ContainerLifeCycle.java:115)
at org.eclipse.jetty.server.handler.AbstractHandler.doStart(AbstractHandler.java:113)
at org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:68)
at org.eclipse.jetty.util.component.ContainerLifeCycle.start(ContainerLifeCycle.java:133)
at org.eclipse.jetty.server.Server.start(Server.java:418)
at org.eclipse.jetty.util.component.ContainerLifeCycle.doStart(ContainerLifeCycle.java:107)
at org.eclipse.jetty.server.handler.AbstractHandler.doStart(AbstractHandler.java:113)
at org.eclipse.jetty.server.Server.doStart(Server.java:385)
at org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:68)
at org.apache.cloudstack.ServerDaemon.start(ServerDaemon.java:200)
at org.apache.cloudstack.ServerDaemon.main(ServerDaemon.java:101)
Caused by: com.cloud.utils.exception.CloudRuntimeException: Unable to acquire lock to check for database integrity.
at com.cloud.upgrade.DatabaseUpgradeChecker.check(DatabaseUpgradeChecker.java:642)
at org.apache.cloudstack.spring.lifecycle.CloudStackExtendedLifeCycle.checkIntegrity(CloudStackExtendedLifeCycle.java:65)
at org.apache.cloudstack.spring.lifecycle.CloudStackExtendedLifeCycle.start(CloudStackExtendedLifeCycle.java:55)
... 46 more

I got issue below, please help me
[root@abc management]# ls
access.log  apilog.log  management-server.log  setupManagement.log
[root@abc management]# tail -f management-server.log
at org.apache.cloudstack.ServerDaemon.start(ServerDaemon.java:200)
at org.apache.cloudstack.ServerDaemon.main(ServerDaemon.java:101)
Caused by: com.cloud.utils.exception.CloudRuntimeException: Unable to acquire lock to check for database integrity.
at com.cloud.upgrade.DatabaseUpgradeChecker.check(DatabaseUpgradeChecker.java:642)
at org.apache.cloudstack.spring.lifecycle.CloudStackExtendedLifeCycle.checkIntegrity(CloudStackExtendedLifeCycle.java:65)
at org.apache.cloudstack.spring.lifecycle.CloudStackExtendedLifeCycle.start(CloudStackExtendedLifeCycle.java:55)
... 46 more
2020-12-30 12:23:00,482 INFO  [o.e.j.s.h.ContextHandler] (main:null) (logid:) Started o.e.j.s.h.MovedContextHandler@31206beb{/,null,AVAILABLE}
2020-12-30 12:23:00,605 INFO  [o.e.j.s.AbstractConnector] (main:null) (logid:) Started ServerConnector@670b40af{HTTP/1.1,[http/1.1]}{0.0.0.0:8080}
2020-12-30 12:23:00,605 INFO  [o.e.j.s.Server] (main:null) (logid:) Started @23652ms

Hi, I'm trying startup cloudstack-management.service, but failed.
I installed cloudstack-management 4.11 in centos7.
Here are the env:
mysql Ver 14.14 Distrib 5.7.31, for Linux (x86_64) using EditLine wrapper
java openjdk version "1.8.0_252"
2020-07-17 04:34:21,829 INFO [c.c.u.DatabaseUpgradeChecker] (main:null) (logid:) Grabbing lock to check for database upgrade.
2020-07-17 04:34:21,866 ERROR [c.c.u.d.DbUtil] (main:null) (logid:) GET_LOCK() throws exception
java.sql.SQLException: Operation not allowed for a result set of type ResultSet.TYPE_FORWARD_ONLY.
at com.mysql.cj.jdbc.exceptions.SQLError.createSQLException(SQLError.java:129)
at com.mysql.cj.jdbc.exceptions.SQLError.createSQLException(SQLError.java:97)
at com.mysql.cj.jdbc.exceptions.SQLExceptionsMapping.translateException(SQLExceptionsMapping.java:122)
at com.mysql.cj.jdbc.result.ResultSetImpl.first(ResultSetImpl.java:584)
at org.apache.commons.dbcp2.DelegatingResultSet.first(DelegatingResultSet.java:402)
at org.apache.commons.dbcp2.DelegatingResultSet.first(DelegatingResultSet.java:402)
at com.cloud.utils.db.DbUtil.getGlobalLock(DbUtil.java:210)
at com.cloud.utils.db.GlobalLock.lock(GlobalLock.java:154)
at com.cloud.upgrade.DatabaseUpgradeChecker.check(DatabaseUpgradeChecker.java:641)
at org.apache.cloudstack.spring.lifecycle.CloudStackExtendedLifeCycle.checkIntegrity(CloudStackExtendedLifeCycle.java:65)
at org.apache.cloudstack.spring.lifecycle.CloudStackExtendedLifeCycle.start(CloudStackExtendedLifeCycle.java:55)
at org.springframework.context.support.DefaultLifecycleProcessor.doStart(DefaultLifecycleProcessor.java:183)
at org.springframework.context.support.DefaultLifecycleProcessor.access$200(DefaultLifecycleProcessor.java:52)
at org.springframework.context.support.DefaultLifecycleProcessor$LifecycleGroup.start(DefaultLifecycleProcessor.java:358)
at org.springframework.context.support.DefaultLifecycleProcessor.startBeans(DefaultLifecycleProcessor.java:159)
at org.springframework.context.support.DefaultLifecycleProcessor.onRefresh(DefaultLifecycleProcessor.java:123)
at org.springframework.context.support.AbstractApplicationContext.finishRefresh(AbstractApplicationContext.java:884)
at org.springframework.context.support.AbstractApplicationContext.refresh(AbstractApplicationContext.java:552)
at org.apache.cloudstack.spring.module.model.impl.DefaultModuleDefinitionSet.loadContext(DefaultModuleDefinitionSet.java:145)
at org.apache.cloudstack.spring.module.model.impl.DefaultModuleDefinitionSet$2.with(DefaultModuleDefinitionSet.java:122)
at org.apache.cloudstack.spring.module.model.impl.DefaultModuleDefinitionSet.withModule(DefaultModuleDefinitionSet.java:245)
at org.apache.cloudstack.spring.module.model.impl.DefaultModuleDefinitionSet.withModule(DefaultModuleDefinitionSet.java:250)
at org.apache.cloudstack.spring.module.model.impl.DefaultModuleDefinitionSet.withModule(DefaultModuleDefinitionSet.java:233)
at org.apache.cloudstack.spring.module.model.impl.DefaultModuleDefinitionSet.loadContexts(DefaultModuleDefinitionSet.java:117)
at org.apache.cloudstack.spring.module.model.impl.DefaultModuleDefinitionSet.load(DefaultModuleDefinitionSet.java:79)
at org.apache.cloudstack.spring.module.factory.ModuleBasedContextFactory.loadModules(ModuleBasedContextFactory.java:37)
at org.apache.cloudstack.spring.module.factory.CloudStackSpringContext.init(CloudStackSpringContext.java:71)
at org.apache.cloudstack.spring.module.factory.CloudStackSpringContext.(CloudStackSpringContext.java:58)
at org.apache.cloudstack.spring.module.factory.CloudStackSpringContext.(CloudStackSpringContext.java:62)
at org.apache.cloudstack.spring.module.web.CloudStackContextLoaderListener.contextInitialized(CloudStackContextLoaderListener.java:52)
at org.eclipse.jetty.server.handler.ContextHandler.callContextInitialized(ContextHandler.java:890)
at org.eclipse.jetty.servlet.ServletContextHandler.callContextInitialized(ServletContextHandler.java:532)
at org.eclipse.jetty.server.handler.ContextHandler.startContext(ContextHandler.java:853)
at org.eclipse.jetty.servlet.ServletContextHandler.startContext(ServletContextHandler.java:344)
at org.eclipse.jetty.webapp.WebAppContext.startWebapp(WebAppContext.java:1515)
at org.eclipse.jetty.webapp.WebAppContext.startContext(WebAppContext.java:1477)
at org.eclipse.jetty.server.handler.ContextHandler.doStart(ContextHandler.java:785)
at org.eclipse.jetty.servlet.ServletContextHandler.doStart(ServletContextHandler.java:261)
at org.eclipse.jetty.webapp.WebAppContext.doStart(WebAppContext.java:545)
at org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:68)
at org.eclipse.jetty.util.component.ContainerLifeCycle.start(ContainerLifeCycle.java:133)
at org.eclipse.jetty.util.component.ContainerLifeCycle.doStart(ContainerLifeCycle.java:107)
at org.eclipse.jetty.server.handler.AbstractHandler.doStart(AbstractHandler.java:113)
at org.eclipse.jetty.server.handler.gzip.GzipHandler.doStart(GzipHandler.java:273)
at org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:68)
at org.eclipse.jetty.util.component.ContainerLifeCycle.start(ContainerLifeCycle.java:133)
at org.eclipse.jetty.util.component.ContainerLifeCycle.doStart(ContainerLifeCycle.java:115)
at org.eclipse.jetty.server.handler.AbstractHandler.doStart(AbstractHandler.java:113)
at org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:68)
at org.eclipse.jetty.util.component.ContainerLifeCycle.start(ContainerLifeCycle.java:133)
at org.eclipse.jetty.server.Server.start(Server.java:418)
at org.eclipse.jetty.util.component.ContainerLifeCycle.doStart(ContainerLifeCycle.java:107)
at org.eclipse.jetty.server.handler.AbstractHandler.doStart(AbstractHandler.java:113)
at org.eclipse.jetty.server.Server.doStart(Server.java:385)
at org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:68)
at org.apache.cloudstack.ServerDaemon.start(ServerDaemon.java:200)
at org.apache.cloudstack.ServerDaemon.main(ServerDaemon.java:101)
2020-07-17 04:34:21,870 WARN [o.a.c.s.m.c.ResourceApplicationContext] (main:null) (logid:) Exception encountered during context initialization - cancelling refresh attempt: org.springframework.context.ApplicationContextException: Failed to start bean 'cloudStackLifeCycle'; nested exception is com.cloud.utils.exception.CloudRuntimeException: Unable to acquire lock to check for database integrity.
2020-07-17 04:34:21,871 WARN [o.e.j.w.WebAppContext] (main:null) (logid:) Failed startup of context o.e.j.w.WebAppContext@77be656f{/client,file:///usr/share/cloudstack-management/webapp/,UNAVAILABLE}{/usr/share/cloudstack-management/webapp}
org.springframework.context.ApplicationContextException: Failed to start bean 'cloudStackLifeCycle'; nested exception is com.cloud.utils.exception.CloudRuntimeException: Unable to acquire lock to check for database integrity.
at org.springframework.context.support.DefaultLifecycleProcessor.doStart(DefaultLifecycleProcessor.java:186)
at org.springframework.context.support.DefaultLifecycleProcessor.access$200(DefaultLifecycleProcessor.java:52)
at org.springframework.context.support.DefaultLifecycleProcessor$LifecycleGroup.start(DefaultLifecycleProcessor.java:358)
at org.springframework.context.support.DefaultLifecycleProcessor.startBeans(DefaultLifecycleProcessor.java:159)
at org.springframework.context.support.DefaultLifecycleProcessor.onRefresh(DefaultLifecycleProcessor.java:123)
at org.springframework.context.support.AbstractApplicationContext.finishRefresh(AbstractApplicationContext.java:884)
at org.springframework.context.support.AbstractApplicationContext.refresh(AbstractApplicationContext.java:552)
at org.apache.cloudstack.spring.module.model.impl.DefaultModuleDefinitionSet.loadContext(DefaultModuleDefinitionSet.java:145)
at org.apache.cloudstack.spring.module.model.impl.DefaultModuleDefinitionSet$2.with(DefaultModuleDefinitionSet.java:122)
at org.apache.cloudstack.spring.module.model.impl.DefaultModuleDefinitionSet.withModule(DefaultModuleDefinitionSet.java:245)
at org.apache.cloudstack.spring.module.model.impl.DefaultModuleDefinitionSet.withModule(DefaultModuleDefinitionSet.java:250)
at org.apache.cloudstack.spring.module.model.impl.DefaultModuleDefinitionSet.withModule(DefaultModuleDefinitionSet.java:233)
at org.apache.cloudstack.spring.module.model.impl.DefaultModuleDefinitionSet.loadContexts(DefaultModuleDefinitionSet.java:117)
at org.apache.cloudstack.spring.module.model.impl.DefaultModuleDefinitionSet.load(DefaultModuleDefinitionSet.java:79)
at org.apache.cloudstack.spring.module.factory.ModuleBasedContextFactory.loadModules(ModuleBasedContextFactory.java:37)
at org.apache.cloudstack.spring.module.factory.CloudStackSpringContext.init(CloudStackSpringContext.java:71)
at org.apache.cloudstack.spring.module.factory.CloudStackSpringContext.(CloudStackSpringContext.java:58)
at org.apache.cloudstack.spring.module.factory.CloudStackSpringContext.(CloudStackSpringContext.java:62)
at org.apache.cloudstack.spring.module.web.CloudStackContextLoaderListener.contextInitialized(CloudStackContextLoaderListener.java:52)
at org.eclipse.jetty.server.handler.ContextHandler.callContextInitialized(ContextHandler.java:890)
at org.eclipse.jetty.servlet.ServletContextHandler.callContextInitialized(ServletContextHandler.java:532)
at org.eclipse.jetty.server.handler.ContextHandler.startContext(ContextHandler.java:853)
at org.eclipse.jetty.servlet.ServletContextHandler.startContext(ServletContextHandler.java:344)
at org.eclipse.jetty.webapp.WebAppContext.startWebapp(WebAppContext.java:1515)
at org.eclipse.jetty.webapp.WebAppContext.startContext(WebAppContext.java:1477)
at org.eclipse.jetty.server.handler.ContextHandler.doStart(ContextHandler.java:785)
at org.eclipse.jetty.servlet.ServletContextHandler.doStart(ServletContextHandler.java:261)
at org.eclipse.jetty.webapp.WebAppContext.doStart(WebAppContext.java:545)
at org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:68)
at org.eclipse.jetty.util.component.ContainerLifeCycle.start(ContainerLifeCycle.java:133)
at org.eclipse.jetty.util.component.ContainerLifeCycle.doStart(ContainerLifeCycle.java:107)
at org.eclipse.jetty.server.handler.AbstractHandler.doStart(AbstractHandler.java:113)
at org.eclipse.jetty.server.handler.gzip.GzipHandler.doStart(GzipHandler.java:273)
at org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:68)
at org.eclipse.jetty.util.component.ContainerLifeCycle.start(ContainerLifeCycle.java:133)
at org.eclipse.jetty.util.component.ContainerLifeCycle.doStart(ContainerLifeCycle.java:115)
at org.eclipse.jetty.server.handler.AbstractHandler.doStart(AbstractHandler.java:113)
at org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:68)
at org.eclipse.jetty.util.component.ContainerLifeCycle.start(ContainerLifeCycle.java:133)
at org.eclipse.jetty.server.Server.start(Server.java:418)
at org.eclipse.jetty.util.component.ContainerLifeCycle.doStart(ContainerLifeCycle.java:107)
at org.eclipse.jetty.server.handler.AbstractHandler.doStart(AbstractHandler.java:113)
at org.eclipse.jetty.server.Server.doStart(Server.java:385)
at org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:68)
at org.apache.cloudstack.ServerDaemon.start(ServerDaemon.java:200)
at org.apache.cloudstack.ServerDaemon.main(ServerDaemon.java:101)
Caused by: com.cloud.utils.exception.CloudRuntimeException: Unable to acquire lock to check for database integrity.
at com.cloud.upgrade.DatabaseUpgradeChecker.check(DatabaseUpgradeChecker.java:642)
at org.apache.cloudstack.spring.lifecycle.CloudStackExtendedLifeCycle.checkIntegrity(CloudStackExtendedLifeCycle.java:65)
at org.apache.cloudstack.spring.lifecycle.CloudStackExtendedLifeCycle.start(CloudStackExtendedLifeCycle.java:55)
... 46 more

please use mysql5 and mysql-connector-java 5

Hi all,
I'm installing Cloudstack 11.4.3 and Xenverser 7.
I cannot add host XenServer 7 to Cloudstack with output:
Cannot transit agent status with event AgentDisconnected for host 3, mangement server id is 345049306511,Unable to transition to a new state from Creating via AgentDisconnec
Is Cloudstack not support for XenServer 7 yet?
Please help me.
Many thanks.
Harry

Hi all,
I'm installing Cloudstack 11.4.3 and Xenverser 7.
I cannot add host XenServer 7 to Cloudstack with output:
Cannot transit agent status with event AgentDisconnected for host 3, mangement server id is 345049306511,Unable to transition to a new state from Creating via AgentDisconnec
Is Cloudstack not support for XenServer 7 yet?
Please help me.
Many thanks.
Harry

authors: AlexanderKgr CobbyJ ZhefuTu skattoju4 uttruongson1995 weizhouapache

repo: apache/cloudstack


text:
Add  API/UI option to send guest command via qemu agent

ISSUE TYPE

Enhancement Request
Feature Idea

COMPONENT NAME
API/UI/Backend

CLOUDSTACK VERSION
4.19

CONFIGURATION
OS / ENVIRONMENT
SUMMARY
Hi team,
I notice that actally, for vm that have qemu agent installed, is not possible through cloudstack send command to the host, like vmware guest agent tool.
This is possible with qemu agent and i notiche that freeze for example was implemented with this class:
https://github.com/apache/cloudstack/blob/main/plugins/hypervisors/kvm/src/main/java/org/apache/cloudstack/utils/qemu/QemuCommand.java
But is not implemented for all type of command and I don't see any API that cover it ( and also via UI I can't see any "form").
This is something that you are interested to implemet?
STEPS TO REPRODUCE
EXPECTED RESULTS
ACTUAL RESULTS

@tanganellilore
you can do it on kvm host by virsh command

Hi @weizhouapache ,
yes clear, this is what I'm doing now, call the CS Api, retrieve in wich host is allocated the vm, access to the host and send the virsh command.
But have an "orchestrator" that can also send command, without access to the kvm host it will be a good enhancement to me.
I notice that this is already present for snapshot, so I thing can be implemented without big deal, at lease on api level.

@tanganellilore @DaanHoogland
technically it is simple, (just API, no database/vo changes at all)
However, I wonder if it is necessary. It is easy to do on kvm host.
Integration such features with ACS will make ACS unnecessarily bigger, IMHO.

Hi @weizhouapache ,
i understood that is simple to do it on KVM host, but only if you can access to KVM host, otherwhise no way to do it.
Let me do a simple use case. User that deploy the vm is not the admin of cloudstack/kvm infrastrutcture and can't access on it, so to run a command after provisioning, without usage of cloudstack or virsh command (he can't access to kvm host), he need to use something different like cloud-init.
One more specific use-case is the configuration of vm network, when dhcp is not possibile and we use a L2 shared.
It's will be very usefull have a kvm command that set network remotley without access to kvm hosts.
I' m using vmware,a nd with it is very simple send command thorugh vmware with guest agent installed, and I thing that it will be a very usefull features, cosidering that command is already implemented in backend. We need simply allow the usage of it via API and very basic command validation (or also without it).

Moreover, we need to considering also that normal user not see in which host the vm is allocated and also the ream vm name on kvm side

thanks @tanganellilore
this is a good improvement request
@DaanHoogland has added it to 4.21.0.0 milestone, we will try to make it happen

source: gharchive/issue

authors: tanganellilore weizhouapache

license_type: permissive

license_source: github-api


text:
Updating pom.xml version numbers for release 4.8.2.0-SNAPSHOT

Often, patch and security releases do not require schema migrations or
data migrations.  However, if an empty upgrade class and associated
scripts are not defined, the upgrade process will break.  With this
change, if a release does not have an upgrade, a noop DbUpgrade is added
to the upgrade path.  This approach allows the upgrade to proceed and
for the database to properly reflect the installed version.  This change
should make the release process simpler as RMs no longer need to
rememeber to create this boilerplate code when starting a new release.
Beginning with the 4.8.2.0 and 4.9.1.0 releases, the project will
formally adopt a four (4) position release number to properly accomodate
rekeases that contain only CVE fixes.  The DatabaseUpgradeChecker and
Version classes made assumptions that they would always parse and
compare three (3) position version numbers.  This change adds the
CloudStackVersion value object that supports both three (3) and four (4)
version numbers.   It encapsulates version comparsion logic, as well as,
the rules to allow three (3) and four (4) to interoperate.

Modifies DatabaseUpgradeChecker to handle derive an upgrade path for
a version that was not explicitly specified.  It determines the
releases the first release before it with database migrations and uses
that list as the basis for the list for version being calculated.  A
noop upgrade is then added to the list which causes no schema changes
or data migrations, but will update the database to the version.
Adds unit tests for the upgrade path calculation logic in
DatabaseUpgradeChecker
Removes dummy upgrade logic for the 4.8.2.0 introduced in previous
versions of this patch
Introduces the CloudStackVersion value object which parses and
compares three (3) and four (4) position version numbers.  This class
is intended to replace com.cloud.maint.Version.
Adds the junit-dataprovider dependency -- allowing test data to be
concisely generated separately from the execution of a test case.
Used extensively in the CloudStackVersionTest.

Signed-off-by: John Burwell meaux@cockamamy.net
/cc @rhtyd @karuturi

LGTM
@blueorangutan package

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

There seems to be build failure around db path or marvin, I can check this

Packaging result: ✔centos6 ✔centos7 ✔debian repo: http://packages.shapeblue.com/cloudstack/pr/1654
Job ID-98

I think a db upgrade path is missing causing Travis failures.

@jburwell I've added an empty upgrade path. Tested the db upgrade locally. LGTM.
When you fwd-merge on 4.9 use: git merge -X ours 4.8 to avoid fixing merge conflicts in pom.xm files by hand. Merging 4.9 on master should not then cause any conflicts. We'll then also need to add/update db upgrade paths from 4.8.2 to 4.9.1/4.10.0 db versions (separately)?

@rhtyd I have updated this PR to reflect version being 4.8.2**.0** rather than 4.8.2.  I also added empty migration scripts to maintain consistency with previous releases (e.g. 4.8.1).  Could you please test and verify?
@karuturi @abhinandanprateek @murali-reddy could you please provide a code review?

@rhtyd The Travis build is failing with the following error:
========> Processing SQL file at /home/travis/build/apache/cloudstack/developer/target/db/templates.simulator.sql
Unable to execute /home/travis/build/apache/cloudstack/developer/target/db/templates.simulator.sql: Unknown column 'state' in 'field list'

A similar error is occurring on the builds for PR #1636.

@jburwell changing code version (in pom.xml) to 4.8.2.0-SNAPSHOT is a valid change, but due to the way our db upgrade path works please revert the change on db upgrade path names and string values to 4.8.2 as explained for a similar change in #1665
The Travis failures were caused due to the change in db upgrade path names, they failed at the deploydb step.

@rhtyd I have updated this patch to properly support four position version numbers, as well as, remove the requirement that all versions have a DbUpgrade class defined and/or an upgrade path.  Please see the commit message for more information about the scope and reasoning for these changes.

@jburwell I've fixed the issue failing db upgrade, it was a minor comparison issue in the beginning of the upgrade process. On my local env the upgrade worked as expected. LGTM.

@syed per our conversation on Slack, the following is the test procedure to verify this PR:

Create a fresh install 4.8.1.  Since we are verifying the database upgrade, the install only needs to start the Management Server.
Build this PR and deploy it against the 4.8.1 database
Restart the Management Server will trigger a database upgrade

Following database upgrade operation, the database version in the database should be 4.8.2.0.

Lgtm.

Looks good on code review
here is my LGTM

Given Travis has passed with 2 LGTMs and test LGTM, I'll go ahead and merge this after testing this across 4.8->4.9, 4.9->master.

Tests on 4.8 branch, all pass:
- Clean db setup works, last upgraded version to 4.8.2.0.
   | 17 | 4.8.1   | 2016-09-01 09:56:21 | Complete |
   | 18 | 4.8.2.0 | 2016-09-01 09:56:21 | Complete |

Upgrade tests from 4.8.0.

LGTM, I've stated management and the DB got updated to 4.8.2

Tests on 4.9 branch (after fwd-merge), all pass:
- Upgrade from 4.8.2.0 to 4.9.1.0
- Clean fresh db deployment

Tests on master branch (after fwd-merge), all pass:
- Upgrade from 4.8.2.0, upgrade from 4.9.1.0
- Clean db deployment

Based on the tests and review. I'll proceed with merging this and fwd-merge this across 4.9, master branches.

@jburwell looks like @rhtyd already tested this. Do you need another testing? I am currently setting up my env

@syed we received the LGTMs necessary overnight.  Thank you for helping out.

source: gharchive/pull-request

authors: abhinandanprateek blueorangutan borisstoyanov jburwell rhtyd syed


text:
ui: Show default nic/network in infocard

Description
Shows default next to the default network / nic
Types of changes

[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] New feature (non-breaking change which adds functionality)
[ ] Bug fix (non-breaking change which fixes an issue)
[x] Enhancement (improves an existing feature and functionality)
[ ] Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale

[ ] Major
[x] Minor

Screenshots (if appropriate):
Deploy VM :

VM Instance :

@blueorangutan ui

@davidjumani a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5080 (SL-JID-222)

@GabrielBrascher you are the second lgtm and imply that you tested, any reason you didn't merge?

authors: DaanHoogland blueorangutan davidjumani


text:
server: fix broken unit test in configurationManagerImplTest

Description
This PR fixes a broken test on configurationManagerImplTest.
Types of changes

[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] New feature (non-breaking change which adds functionality)
[x] Bug fix (non-breaking change which fixes an issue)
[ ] Enhancement (improves an existing feature and functionality)
[ ] Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale

[ ] Major
[ ] Minor

Bug Severity

[ ] BLOCKER
[X] Critical
[ ] Major
[ ] Minor
[ ] Trivial

Screenshots (if appropriate):
How Has This Been Tested?

Lgtm

authors: GaOrtiga rohityadavcloud


text:
Option to create StorPool primary storage with a valid URL

Description
This PR provides another option to create StorPool primary storage with a valid URL in cases the old format is not accepted. The user will be able to use the old and new format
Old format SP_API_HTTP=address:port;SP_AUTH_TOKEN=token;SP_TEMPLATE=template_name
New format storpool://{SP_AUTH_TOKEN}@{SP_API_HTTP}:{SP_API_HTTP_PORT}/{SP_TEMPLATE}
Types of changes

[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] New feature (non-breaking change which adds functionality)
[ ] Bug fix (non-breaking change which fixes an issue)
[X] Enhancement (improves an existing feature and functionality)
[ ] Cleanup (Code refactoring and cleanup, that may add test cases)
[ ] build/CI

Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale

[ ] Major
[X] Minor

How Has This Been Tested?
Manual and smoke tests

@blueorangutan package

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Packaging result [SF]: ✔ el7 ✔ el8 ✔ el9 ✔ debian ✔ suse15. SL-JID 8099

@blueorangutan test alma9 kvm-alma9

@DaanHoogland a [SL] Trillian-Jenkins test job (alma9 mgmt + kvm-alma9) has been kicked to run smoke tests

[SF] Trillian test result (tid-8647)
Environment: kvm-alma9 (x2), Advanced Networking with Mgmt server a9
Total time taken: 52392 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8356-t8647-kvm-alma9.zip
Smoke tests completed. 125 look OK, 3 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test
Result
Time (s)
Test File

test_11_destroy_ssvm
Failure
918.66
test_ssvm.py

test_05_list_volumes_isrecursive
Failure
0.04
test_list_volumes.py

test_07_list_volumes_listall
Failure
0.04
test_list_volumes.py

test_01_migrate_VM_and_root_volume
Error
91.61
test_vm_life_cycle.py

test_02_migrate_VM_with_two_data_disks
Error
51.02
test_vm_life_cycle.py

test_08_migrate_vm
Error
46.12
test_vm_life_cycle.py

@blueorangutan package

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Packaging result [SF]: ✔ el7 ✔ el8 ✔ el9 ✔ debian ✔ suse15. SL-JID 8140

@blueorangutan test alma9 kvm-alma9

@sureshanaparti a [SL] Trillian-Jenkins test job (alma9 mgmt + kvm-alma9) has been kicked to run smoke tests

[SF] Trillian test result (tid-8681)
Environment: kvm-alma9 (x2), Advanced Networking with Mgmt server a9
Total time taken: 37980 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8356-t8681-kvm-alma9.zip
Smoke tests completed. 111 look OK, 10 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test
Result
Time (s)
Test File

ContextSuite context=TestDeployVM>:setup
Error
0.00
test_vm_life_cycle.py

test_01_migrate_VM_and_root_volume
Error
1.36
test_vm_life_cycle.py

test_02_migrate_VM_with_two_data_disks
Error
1.42
test_vm_life_cycle.py

test_01_secure_vm_migration
Error
0.02
test_vm_life_cycle.py

test_02_unsecure_vm_migration
Error
0.02
test_vm_life_cycle.py

test_03_secured_to_nonsecured_vm_migration
Error
0.02
test_vm_life_cycle.py

test_04_nonsecured_to_secured_vm_migration
Error
0.02
test_vm_life_cycle.py

ContextSuite context=TestVMLifeCycle>:setup
Error
4.34
test_vm_life_cycle.py

ContextSuite context=TestVMSchedule>:setup
Error
0.00
test_vm_schedule.py

ContextSuite context=TestVmSnapshot>:setup
Error
4.20
test_vm_snapshots.py

test_04_deploy_vnf_appliance
Error
93.92
test_vnf_templates.py

test_04_deploy_vnf_appliance
Error
93.93
test_vnf_templates.py

test_05_delete_vnf_template
Error
0.07
test_vnf_templates.py

ContextSuite context=TestVnfTemplates>:teardown
Error
0.16
test_vnf_templates.py

ContextSuite context=TestCreateVolume>:setup
Error
0.00
test_volumes.py

test_01_root_volume_encryption
Error
0.02
test_volumes.py

test_02_data_volume_encryption
Error
0.02
test_volumes.py

test_03_root_and_data_volume_encryption
Error
0.02
test_volumes.py

ContextSuite context=TestVolumes>:setup
Error
5.53
test_volumes.py

test_01_verify_ipv6_vpc
Error
3.47
test_vpc_ipv6.py

test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL
Error
6.59
test_vpc_redundant.py

test_02_redundant_VPC_default_routes
Error
5.30
test_vpc_redundant.py

test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers
Error
5.68
test_vpc_redundant.py

test_04_rvpc_network_garbage_collector_nics
Error
5.36
test_vpc_redundant.py

test_05_rvpc_multi_tiers
Error
5.20
test_vpc_redundant.py

test_01_VPC_nics_after_destroy
Error
5.53
test_vpc_router_nics.py

test_02_VPC_default_routes
Error
5.45
test_vpc_router_nics.py

test_01_redundant_vpc_site2site_vpn
Failure
3.52
test_vpc_vpn.py

test_01_vpc_site2site_vpn_multiple_options
Failure
3.42
test_vpc_vpn.py

test_01_vpc_remote_access_vpn
Failure
1.18
test_vpc_vpn.py

test_01_vpc_site2site_vpn
Failure
3.49
test_vpc_vpn.py

test_01_cancel_host_maintenace_with_no_migration_jobs
Error
0.07
test_host_maintenance.py

test_02_cancel_host_maintenace_with_migration_jobs
Error
0.06
test_host_maintenance.py

test_03_cancel_host_maintenace_with_migration_jobs_failure
Error
0.06
test_host_maintenance.py

test_01_cancel_host_maintenance_ssh_enabled_agent_connected
Error
0.02
test_host_maintenance.py

test_03_cancel_host_maintenance_ssh_disabled_agent_connected
Error
0.02
test_host_maintenance.py

test_04_cancel_host_maintenance_ssh_disabled_agent_disconnected
Error
0.02
test_host_maintenance.py

LGTM - merging based on github actions and that all changes in storpool specific plugin.

authors: DaanHoogland blueorangutan rohityadavcloud slavkap sureshanaparti


text:
LANG-1214 Handle "void" in ClassUtils.getClass()

getClass() previously deferred to an array type to get the class,
but this fails for void, which lacks an array type.
Instead, map explicitly from primitive name to primitive class.
Added unit test line fails before change, passes after change.

Thanks!

authors: PascalSchumacher henryptung

repo: apache/commons-lang

license_source: bigquery


text:
LANG-1520 spring clean .gitignore

Handles https://issues.apache.org/jira/browse/LANG-1520

I think you tagged won't ticket

Coverage remained the same at 95.101% when pulling 73cf2a5c5a36ce3d95c5eac0989b299815baa05b on nhojpatrick:LANG-1520 into 94b3784fdec5d0e9d63e4aec6772144b68283790 on apache:master.

I think you tagged won't ticket

cheers, working on 4 projects at once

authors: SscSPs coveralls nhojpatrick


text:
TEXT-226: refactored the append method by splitting it

TEXT-226 refactored the append method, because it handles padding, truncation, and formatting. It would be better to split these into separate methods

this PR was done 70 days ago. It awaits review and merge

There is no use case IMO. What do others think?

this PR has been open for half a year

I don't see the need for this. Change for the sake of change?

authors: garydgregory orionlibs

repo: apache/commons-text


text:
CB-12905: (linux) Fix issue with freezing after launching the browser

In Linux, the callback is not called until the process terminates.
If the error is not caused within 2 seconds, then the promise will be resolved.
Platforms affected

Linux

What does this PR do?

If the error after launching the browser is not caused within 2 seconds, then the promise will be resolved.

What testing has been done on this change?

manual testing launching browsers in Linux, Windows and MacOs

Checklist

[x] Reported an issue in the JIRA database
[x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
[ ] Added automated test coverage as appropriate for this change.

Also, I think you need to send this PR in the cordova-serve (https://github.com/apache/cordova-serve)

This needs to be addressed in the cordova-serve repo if it is an issue. Closing.

@purplecabbage
cordova-serve developer addresses it to you and you address to him (-:
https://github.com/Microsoft/cordova-simulate/issues/245#issuecomment-310361201
@matrosov-nikita `s PR seems to work for me.
Can this be in some way fixed?
Thanks.

This pr attempted to patch a dependency in the node_modules folder directly, this is not how we do things.
The dependent module, cordova-serve has been patched, and released, and this module's dependent version was updated. ( https://github.com/apache/cordova-serve/pull/4 )
Not sure what else you are asking for @gruz

authors: gruz matrosov-nikita paymicro purplecabbage

repo: apache/cordova-browser


text:
chore: update .npmignore

Excludes karma.conf.js, and any previously generated *.tgz files from the package generated by npm pack. Also removes the outdated appveyor.yml from the list of ignores.

Codecov Report

Merging #236 (ffac174) into master (e22633f) will decrease coverage by 0.05%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #236      +/-   ##
==========================================
- Coverage   84.23%   84.17%   -0.06%
==========================================
  Files          14       12       -2
  Lines         539      537       -2
==========================================
- Hits          454      452       -2
  Misses         85       85

Impacted Files
Coverage Δ

test/test-platform-modules/platform.js

test/test-platform-modules/exec.js

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e22633f...ffac174. Read the comment docs.

authors: codecov-commenter raphinesse

repo: apache/cordova-js


text:
Camera roll crash on ios 16+

Hello since IOS 16 I am getting reports when camera roll is selected the app crashes. I have found the following in xcode and someone could point me in the right direction.

[BackgroundTask] Background Task 3 ("Called by WebCore, from <redacted>"), was created over 30 seconds ago. In applications running in the background, this creates a risk of termination. Remember to call UIApplication.endBackgroundTask(_:) for your task in a timely manner to avoid this.
After this gets outputted on xcode and I open the camera roll again the app crashes with the following;
This application is modifying the autolayout engine from a background thread after the engine was accessed from the main thread. This can lead to engine corruption and weird crashes.

*cordova ios 5.1.1
*cordova-plugin-camera 6.0.0

update your cordova ios bro!

I recommend updating your cordova-ios to 6.2.0.
ionic cordova platform rm ios
ionic cordova platform add ios@6.2.0

Are you using some BackgroundTask plugin?

 need photo library access to save pictures there

 need photo library access to get pictures from there

adding this two config file in config.xml solve the problem for me

need photo library access to save pictures there need photo library access to get pictures from there
adding this two config file in config.xml solve the problem for me

HOPE App need photo library access to save pictures there

HOPE App need photo library access to get pictures from there

<config-file overwrite="true" parent="NSPhotoLibraryAddUsageDescription" target="*-Info.plist">
   <string> need photo library access to save pictures there</string>
</config-file>
<config-file overwrite="true" parent="NSPhotoLibraryUsageDescription" target="*-Info.plist">
   <string> need photo library access to get pictures from there</string>
</config-file>

adding this two config file in config.xml solve the problem for me

repo: apache/cordova-plugin-camera


text:
Don't allow security updates during cassim migration

Companion PR for cassim manual security doc migrations.

+1 after addressing that one comment.

authors: chewbranca rnewson

repo: apache/couchdb-chttpd


text:
Mango: Add Bitwise Operators

from @janl. No description provided.

I was thinking about this one recently. As far as I know the bitwise operators in MongoDB are mostly useful when operating on raw binaries in a BSON document. If we implemented them in CouchDB, would we want to work on Base64-encoded binary strings? Would we allow them to pull up attachments from disk?

authors: kocolosk wohali

repo: apache/couchdb


text:
Without credentials request the content of reason field should complain about missing credentials

Description
When I want to create a database with endpoint PUT {server_url}/{dbName} without any credentials, I receiving the different reason message on Cloudant and on CouchDB.
CouchDB: "You are not a server admin."
Cloudant: "one of _admin, server_admin is required for this request"
They should respond with the same reason.
Furthermore the message of the reason is not assist to figure out the authentication problem. I have not used any credentials during the API request, therefore I will have no server_admin permission.
Steps to Reproduce
Use PUT {server_url}/{dbName} without any authentication.
curl --request PUT '{server_url}/{dbName}' \
--header 'Content-Type: application/json'

The response on CouchDB:
401 Unauthorized
{
    "error": "unauthorized",
    "reason": "You are not a server admin."
}

The response on Cloudant:
401 Unauthorized
{
    "error": "unauthorized",
    "reason": "one of _admin, server_admin is required for this request"
}

Expected Behaviour
CouchDB and Cloudant should respond with the same reason.
Secondly, the reason message should be more descriptive like:
eg:

No credential is attached to the request
No authentication information

Your Environment

CouchDB version used: 3.0.0-83bdcf6
Cloudant version: 2.1.1. "vendor": {"name": "IBM Cloudant","version": "8135","variant": "paas"}
Operating system and version: MacOS Catalina 10.15.3

Additional Context

The notion of "server_admin" only exists in Cloudant because it is a multi-tenant variant of CouchDB. As such, the error messages are appropriate for both products and the variance is reasonable.

@rnewson is it time to close this, or?

authors: rnewson vmatyusGitHub wohali


text:
CXF-7643 ensure CDI extension defaults are CDI compliant

This PR tries to make defaults of the CDI extension better, here are the changes:

if it detects OWB-web or weld-web it deactivate default context beans for HttpServletRequest and ServletContext
it observes beans to detect the types conflicting with "auto" context beans
it fires the extension and exposes the list of exclusion to let integration layers configure it properly if 1/2 defaults are not enough
when it adds context beans it removes @Default from the ones which are found with 1/2/3 - but it keeps it with the cxf specific qualifier if needed (best practise being to use this classifier for internal/extensions needs)

Can you update one of the existing systests to confirm that the various injection points are available, with the needed dependencies on the classpath?

@johnament done

authors: johnament rmannibucau

repo: apache/cxf


text:
Remove some Expr clones in EliminateCrossJoin(3%-5% faster planning)

~Draft as it builds on https://github.com/apache/datafusion/pull/10427~
Which issue does this PR close?
Part of https://github.com/apache/datafusion/issues/10287
Rationale for this change
I am trying to avoid copying as much in EliminateCrossJoin to speed up planning.
One thing this rule does is quite a few Expr copies while checking exprs for join keys
What changes are included in this PR?

Move management of join key exprs to JoinExprSet struct
Reduce copying of clones internally to JoinExprSet
New tests for JoinExprSet

Are these changes tested?
Existing CI
Are there any user-facing changes?
No functional changes
Performance tests show 3-5% faster for TPCH / TPDS queries
Details

++ critcmp main less_clone_in_eliminate_cross_join
group                                         less_clone_in_eliminate_cross_join     main
-----                                         ----------------------------------     ----
logical_aggregate_with_join                   1.00  1184.8±12.12µs        ? ?/sec    1.02  1207.4±14.82µs        ? ?/sec
logical_plan_tpcds_all                        1.00    156.8±1.94ms        ? ?/sec    1.01    158.1±2.46ms        ? ?/sec
logical_plan_tpch_all                         1.00     16.8±0.24ms        ? ?/sec    1.01     16.9±0.15ms        ? ?/sec
logical_select_all_from_1000                  1.00     17.9±0.11ms        ? ?/sec    1.04     18.7±0.13ms        ? ?/sec
logical_select_one_from_700                   1.00   815.1±20.51µs        ? ?/sec    1.00   813.6±10.21µs        ? ?/sec
logical_trivial_join_high_numbered_columns    1.00   752.3±14.99µs        ? ?/sec    1.02   764.2±14.21µs        ? ?/sec
logical_trivial_join_low_numbered_columns     1.00   736.0±10.70µs        ? ?/sec    1.01    745.7±7.27µs        ? ?/sec
physical_plan_tpcds_all                       1.00   1308.6±9.71ms        ? ?/sec    1.03   1349.1±7.72ms        ? ?/sec
physical_plan_tpch_all                        1.00     88.6±1.59ms        ? ?/sec    1.05     93.0±1.50ms        ? ?/sec
physical_plan_tpch_q1                         1.00      4.7±0.07ms        ? ?/sec    1.08      5.1±0.07ms        ? ?/sec
physical_plan_tpch_q10                        1.00      4.3±0.08ms        ? ?/sec    1.03      4.4±0.09ms        ? ?/sec
physical_plan_tpch_q11                        1.00      3.8±0.08ms        ? ?/sec    1.05      3.9±0.07ms        ? ?/sec
physical_plan_tpch_q12                        1.00      2.9±0.05ms        ? ?/sec    1.11      3.2±0.05ms        ? ?/sec
physical_plan_tpch_q13                        1.00      2.1±0.04ms        ? ?/sec    1.02      2.1±0.03ms        ? ?/sec
physical_plan_tpch_q14                        1.00      2.5±0.06ms        ? ?/sec    1.10      2.8±0.05ms        ? ?/sec
physical_plan_tpch_q16                        1.00      3.6±0.06ms        ? ?/sec    1.07      3.8±0.07ms        ? ?/sec
physical_plan_tpch_q17                        1.00      3.5±0.12ms        ? ?/sec    1.05      3.7±0.08ms        ? ?/sec
physical_plan_tpch_q18                        1.00      3.9±0.07ms        ? ?/sec    1.04      4.1±0.05ms        ? ?/sec
physical_plan_tpch_q19                        1.00      5.8±0.07ms        ? ?/sec    1.08      6.3±0.08ms        ? ?/sec
physical_plan_tpch_q2                         1.00      7.6±0.08ms        ? ?/sec    1.03      7.8±0.11ms        ? ?/sec
physical_plan_tpch_q20                        1.00      4.5±0.10ms        ? ?/sec    1.03      4.6±0.07ms        ? ?/sec
physical_plan_tpch_q21                        1.00      6.1±0.07ms        ? ?/sec    1.02      6.2±0.08ms        ? ?/sec
physical_plan_tpch_q22                        1.00      3.3±0.06ms        ? ?/sec    1.05      3.4±0.07ms        ? ?/sec
physical_plan_tpch_q3                         1.00      3.1±0.06ms        ? ?/sec    1.02      3.1±0.06ms        ? ?/sec
physical_plan_tpch_q4                         1.00      2.2±0.04ms        ? ?/sec    1.04      2.3±0.05ms        ? ?/sec
physical_plan_tpch_q5                         1.00      4.4±0.07ms        ? ?/sec    1.03      4.5±0.09ms        ? ?/sec
physical_plan_tpch_q6                         1.00  1479.7±35.88µs        ? ?/sec    1.09  1616.7±64.90µs        ? ?/sec
physical_plan_tpch_q7                         1.00      5.5±0.11ms        ? ?/sec    1.03      5.7±0.08ms        ? ?/sec
physical_plan_tpch_q8                         1.00      7.2±0.10ms        ? ?/sec    1.02      7.3±0.09ms        ? ?/sec
physical_plan_tpch_q9                         1.00      5.5±0.09ms        ? ?/sec    1.01      5.5±0.07ms        ? ?/sec
physical_select_all_from_1000                 1.00     58.7±0.33ms        ? ?/sec    1.04     61.1±0.87ms        ? ?/sec
physical_select_one_from_700                  1.00      3.6±0.03ms        ? ?/sec    1.02      3.6±0.05ms        ? ?/sec

Thanks for the review @comphead  🚀

repo: apache/datafusion


text:
fix docs of register_table to match implementation

I'm not sure that changing the implementation is possible at this point. We could call deregister_table but I fear that's not atomic. So we'd have to change the implementation of SchemaProvider, a breaking change.

See https://github.com/pydantic/datafusion/blob/1af1b49d6afa4be61e8c32a0510e97c85301e747/datafusion/catalog/src/schema.rs#L59


text:
[Fix][Task] Fix dependent task can not predicate the status of the corres…

…ponding task correctly

Purpose of the pull request
close https://github.com/apache/dolphinscheduler/issues/12252
Brief change log
Fix dependent task can not predicate the status of the corres…
Verify this pull request

This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:

(or)
If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

Codecov Report

Merging #12253 (2111ece) into dev (3c4f938) will decrease coverage by 0.02%.
The diff coverage is 42.85%.

@@             Coverage Diff              @@
##                dev   #12253      +/-   ##
============================================
- Coverage     39.71%   39.69%   -0.03%
+ Complexity     4193     4188       -5
============================================
  Files          1016     1016
  Lines         38049    38020      -29
  Branches       4363     4349      -14
============================================
- Hits          15111    15091      -20
+ Misses        21193    21183      -10
- Partials       1745     1746       +1

Impacted Files
Coverage Δ

...cheduler/plugin/task/api/utils/DependentUtils.java
88.23% <33.33%> (-5.52%)
:arrow_down:

...uler/plugin/task/api/utils/DependentDateUtils.java
98.50% <100.00%> (ø)

...er/master/dispatch/host/assign/RandomSelector.java
77.77% <0.00%> (-5.56%)
:arrow_down:

...erver/master/processor/queue/TaskEventService.java
75.00% <0.00%> (-5.36%)
:arrow_down:

...dolphinscheduler/remote/future/ResponseFuture.java
81.96% <0.00%> (-1.64%)
:arrow_down:

...rver/master/runner/task/BlockingTaskProcessor.java
75.86% <0.00%> (-0.55%)
:arrow_down:

...heduler/api/service/impl/ResourcesServiceImpl.java
51.68% <0.00%> (-0.47%)
:arrow_down:

.../dolphinscheduler/plugin/task/spark/SparkTask.java
72.56% <0.00%> (-0.25%)
:arrow_down:

...eduler/api/dto/workflow/WorkflowCreateRequest.java
100.00% <0.00%> (ø)

...eduler/api/service/impl/DataSourceServiceImpl.java
30.06% <0.00%> (ø)

... and 13 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

repo: apache/dolphinscheduler


text:
[3.1.8-prepare][Fix-14008][registry] cache keep alive lease #14034

Purpose of the pull request

the related pr: #14034
Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:

(or)
If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

Codecov Report

:exclamation: No coverage uploaded for pull request base (3.1.8-prepare@64b9200). Click here to learn what that means.
The diff coverage is n/a.

:exclamation: Current head 033db57 differs from pull request most recent head 68bb197. Consider uploading reports for the commit 68bb197 to get more accurate results

@@               Coverage Diff                @@
##             3.1.8-prepare   #14666   +/-   ##
================================================
  Coverage                 ?   38.22%
  Complexity               ?     3983
================================================
  Files                    ?     1000
  Lines                    ?    36926
  Branches                 ?     4268
================================================
  Hits                     ?    14115
  Misses                   ?    21198
  Partials                 ?     1613

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

authors: codecov-commenter zhuangchong


text:
[Enhancement] ALTER TABLE ADD compatible with mysql

Search before asking

[X] I had searched in the issues and found no similar issues.

Description
Mysql syntax  is not supported in doris. https://www.w3schools.com/sql/sql_alter.asp
mysql> ALTER TABLE db1.customer ADD  c_xianhui_1 varchar(100) NULL;
ERROR 1105 (HY000): errCode = 2, detailMessage = Syntax error in line 1:
ALTER TABLE db1.customer ADD  c_xianhui_1 varchar(100) NULL
^
Encountered: IDENTIFIER
Expected
doris' syntax
mysql> ALTER TABLE db1.customer ADD column c_xianhui_1 varchar(100) NULL;
Query OK, 0 rows affected (0.00 sec)
Solution

[ ] read code of add column.
[ ] support mysql syntax.

Are you willing to submit PR?

[ ] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

@dataroaring I am very willing to participate in this issue。

Hi, how's going?

repo: apache/doris


text:
Enhancement Refine the load channel flush policy on mem limit

Proposed changes
Issue Number: close #xxx
Problem summary
Testing, will complete the description later.
Checklist(Required)

Does it affect the original behavior:

[ ] Yes
[ ] No
[ ] I don't know

Has unit tests been added:

[ ] Yes
[ ] No
[ ] No Need

Has document been added or modified:

[ ] Yes
[ ] No
[ ] No Need

Does it need to update dependencies:

[ ] Yes
[ ] No

Are there any changes that cannot be rolled back:

[ ] Yes (If Yes, please explain WHY)
[ ] No

Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

LGTM

@zhannngchen  Looking forward to updating the Problem summary

commit comment:

Remove single load channel mem limit, only use load channel mgr mem limit
Default load channel mgr mem limit from 50% to 80%
load channel mgr add soft mem limit. When the soft limit is exceeded, other threads will not hang, only current thread triggers flush
When exceed load channel mgr mem limit, find a load channel with the largest mem usage, continue to find a tablet channel with the largest mem usage, and try to flush 1/3 of the mem usage of this tablet channel.

authors: dataalive xinyiZzz zhannngchen


text:
Bug Fix wrong type in TimestampArithmeticExpr

Proposed changes
Issue Number: close #12726
Problem summary
Describe your changes.
Checklist(Required)

Does it affect the original behavior:

[ ] Yes
[ ] No
[ ] I don't know

Has unit tests been added:

[ ] Yes
[ ] No
[ ] No Need

Has document been added or modified:

[ ] Yes
[ ] No
[ ] No Need

Does it need to update dependencies:

[ ] Yes
[ ] No

Are there any changes that cannot be rolled back:

[ ] Yes (If Yes, please explain WHY)
[ ] No

Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

This fix is OK for TimestampArithmeticExpr. Is it possible that other exprs may have similar issue?

This fix is OK for TimestampArithmeticExpr. Is it possible that other exprs may have similar issue?

Actually, this problem will only occur for datetimev2 and decimalv3 type. For datetimev2, I think its related expression should be used only by FunctionCallExpr and TimestampArithmeticExpr.  And this logics has already in FunctionCallExpr.


text:
fix fix clone_type_info function return default scalar type

Proposed changes
Issue Number: close #xxx
Problem summary
Describe your changes.
Checklist(Required)

Does it affect the original behavior:

[ ] Yes
[ ] No
[ ] I don't know

Has unit tests been added:

[ ] Yes
[ ] No
[ ] No Need

Has document been added or modified:

[ ] Yes
[ ] No
[ ] No Need

Does it need to update dependencies:

[ ] Yes
[ ] No

Are there any changes that cannot be rolled back:

[ ] Yes (If Yes, please explain WHY)
[ ] No

Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

LGTM


text:
fix fix signatures of some window functions

Proposed changes
Issue Number: close #xxx
Problem summary
change signatures of lead(), lag(), first_value(), last_value() to be equal with legacy optimizer;
these four functions only support Type.trivialTypes as returnType and input column type.
Checklist(Required)

[ ] Does it affect the original behavior
[ ] Has unit tests been added
[ ] Has document been added or modified
[ ] Does it need to update dependencies
[ ] Is this PR support rollback (If NO, please explain WHY)

Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

run p0

run clickbench

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 34.59 seconds
stream load tsv:          461 seconds loaded 74807831229 Bytes, about 154 MB/s
stream load json:         35 seconds loaded 2358488459 Bytes, about 64 MB/s
stream load orc:          67 seconds loaded 1101869774 Bytes, about 15 MB/s
stream load parquet:          28 seconds loaded 861443392 Bytes, about 29 MB/s
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230220075543_clickbench_pr_100049.html

run arm

run buildall

run p0

run buildall

authors: YangShaw hello-stephen


text:
typoAdd upgrade precautions

Proposed changes
Issue Number: close #xxx
Problem summary
Describe your changes.
Checklist(Required)

[ ] Does it affect the original behavior
[ ] Has unit tests been added
[x] Has document been added or modified
[ ] Does it need to update dependencies
[ ] Is this PR support rollback (If NO, please explain WHY)

Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

run buildall


text:
typo Fix some misspelled words

Proposed changes
Issue Number: close #xxx
Problem summary
I fixed some misspelled words.
Checklist(Required)

[ ] Does it affect the original behavior
[ ] Has unit tests been added
[ ] Has document been added or modified
[ ] Does it need to update dependencies
[ ] Is this PR support rollback (If NO, please explain WHY)

Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

run P0

authors: hechao-ustc luzhijing


text:
FIXfix array literal in fe

Proposed changes
Issue Number: close #xxx
fix array literal in fe const fold logic

Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

run buildall

run buildall

run buildall

authors: amorynan dataroaring


text:
fix compound predicate need cast children to boolean (#27649)

pick from master
PR #27649
commit f0dbce4cf58ec829734175e05bf2188c7158078d
Proposed changes
Issue Number: close #xxx

Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

run buildall


text:
refactor remove download buffer since it never used

Proposed changes
Issue Number: close #xxx

Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall


text:
[test] test pipelineX

Proposed changes
Issue Number: close #xxx

Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall


text:
[Refactor]refactor log workload group when query arrives be

What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Add wg info when query arrives BE.

with group

I20241205 14:43:46.636260 4101563 fragment_mgr.cpp:670] query_id: df11980d08ca493d-8d60f0ff07980a40, coord_addr: TNetworkAddress(hostname=127.0.0.1, port=9220), total fragment num on c
urrent host: 8, fe process uuid: 1733370035373, query type: SELECT, report audit fe:TNetworkAddress(hostname=127.0.0.1, port=9220), use wg:TG[id = 1, name = normal, cpu_share = 20, mem
ory_limit = 169.12 GB, enable_memory_overcommit = true, version = 13, cpu_hard_limit = 1, scan_thread_num = 16, max_remote_scan_thread_num = 960, min_remote_scan_thread_num = 8, memory_
low_watermark=50, memory_high_watermark=80, is_shutdown=false, query_num=0, read_bytes_per_second=-1, remote_read_bytes_per_second=-1]

without group

I20241205 14:44:18.009614 4101564 fragment_mgr.cpp:670] query_id: 2e963fb1b323486f-b55bbbe898ba248c, coord_addr: TNetworkAddress(hostname=127.0.0.1, port=9220), total fragment num on current host: 8, fe process uuid: 1733370035373, query type: SELECT, report audit fe:TNetworkAddress(hostname=127.0.0.1, port=9220), use wg:not carry wg

Release note
None
Check List (For Author)

Test

[ ] Regression test
[ ] Unit Test
[x] Manual test (add detailed scripts or steps below)
[ ] No need to test or manual test. Explain why:

[ ] This is a refactor/code format and no logic has been changed.
[ ] Previous test can cover this change.
[ ] No code files have been changed.
[ ] Other reason

Behavior changed:

[x] No.
[ ] Yes.

Does this need documentation?

[x] No.
[ ] Yes.

Check List (For Reviewer who merge this PR)

[ ] Confirm the release note
[ ] Confirm test cases
[ ] Confirm document
[ ] Add branch pick label

run buildall

run buildall


text:
DRILL-7913: Improve the tips using the Tooltips

DRILL-7913: Improve the tips using the Tooltips
Description
Actually, the tips of web console is hard to use.

Too slowly (Delay 2s +)
No good for the readable (Font size and bg color)

Based on the Bootstrap (existed) and Popper.js (new), Use the new module Tooltips to improve these.
Documentation
N/A
Testing

@luocooong
This looks great!  As a part of this PR, could you update jquery to v 3.6.0?  There are some CVEs associated with the version of jquery that we're currently using.

@cgivre Done. And I have updated the description for the library upgrade. thanks

authors: cgivre luocooong

repo: apache/drill


text:
Quick Start Permission Issue: Can't Ingest

Supposedly, this was was fixed by https://github.com/apache/druid/pull/11299/files
But I am getting the same issues of ingestion failing due to not being able to create a directory in opt shared:
here is my docker-compose.yml
version: "3"

services:
  # Nessie Catalog Server Using In-Memory Store
  nessie:
    image: projectnessie/nessie:latest
    container_name: nessie
    networks:
      dremio-druid-superset:
    ports:
      - 19120:19120

  # Minio Storage Server
  minio:
    image: minio/minio:latest
    container_name: minio
    environment:
      - MINIO_ROOT_USER=admin
      - MINIO_ROOT_PASSWORD=password
      - MINIO_DOMAIN=storage
      - MINIO_REGION_NAME=us-east-1
      - MINIO_REGION=us-east-1
    networks:
      dremio-druid-superset:
    ports:
      - 9001:9001
      - 9000:9000
    command: ["server", "/data", "--console-address", ":9001"]

  # Dremio
  dremio:
    platform: linux/x86_64
    image: dremio/dremio-oss:latest
    ports:
      - 9047:9047
      - 31010:31010
      - 32010:32010
    container_name: dremio
    environment:
      - DREMIO_JAVA_SERVER_EXTRA_OPTS=-Dpaths.dist=file:///opt/dremio/data/dist
    networks:
      dremio-druid-superset:

  # Apache Druid
  postgres:
    container_name: postgres
    image: postgres:latest
    ports:
      - "5433:5432"
    volumes:
      - metadata_data:/var/lib/postgresql/data
    environment:
      - POSTGRES_PASSWORD=FoolishPassword
      - POSTGRES_USER=druid
      - POSTGRES_DB=druid
    networks:
      dremio-druid-superset:

  # Need 3.5 or later for container nodes
  zookeeper:
    container_name: zookeeper
    image: zookeeper:3.5.10
    ports:
      - "2181:2181"
    environment:
      - ZOO_MY_ID=1
    networks:
      dremio-druid-superset:

  coordinator:
    image: apache/druid:29.0.1
    container_name: coordinator
    volumes:
      - druid_shared:/opt/shared
      - coordinator_var:/opt/druid/var
    depends_on:
      - zookeeper
      - postgres
    ports:
      - "8081:8081"
    command:
      - coordinator
    env_file:
      - environment
    networks:
      dremio-druid-superset:

  broker:
    image: apache/druid:29.0.1
    container_name: broker
    volumes:
      - broker_var:/opt/druid/var
    depends_on:
      - zookeeper
      - postgres
      - coordinator
    ports:
      - "8082:8082"
    command:
      - broker
    env_file:
      - environment
    networks:
      dremio-druid-superset:

  historical:
    image: apache/druid:29.0.1
    container_name: historical
    volumes:
      - druid_shared:/opt/shared
      - historical_var:/opt/druid/var
    depends_on:
      - zookeeper
      - postgres
      - coordinator
    ports:
      - "8083:8083"
    command:
      - historical
    env_file:
      - environment
    networks:
      dremio-druid-superset:

  middlemanager:
    image: apache/druid:29.0.1
    container_name: middlemanager
    volumes:
      - druid_shared:/opt/shared
      - middle_var:/opt/druid/var
    depends_on:
      - zookeeper
      - postgres
      - coordinator
    ports:
      - "8091:8091"
      - "8100-8105:8100-8105"
    command:
      - middleManager
    env_file:
      - environment
    networks:
      dremio-druid-superset:

  router:
    image: apache/druid:29.0.1
    container_name: router
    volumes:
      - router_var:/opt/druid/var
    depends_on:
      - zookeeper
      - postgres
      - coordinator
    ports:
      - "8888:8888"
    command:
      - router
    env_file:
      - environment
    networks:
      dremio-druid-superset:

  # Superset
  superset:
    image: apache/superset
    container_name: superset
    networks:
      dremio-druid-superset:
    ports:
      - 8088:8088

networks:
  dremio-druid-superset:

volumes:
  metadata_data:
  middle_var:
  historical_var:
  broker_var:
  coordinator_var:
  router_var:
  druid_shared:

I pretty much copied what was in the repo here https://github.com/apache/druid/blob/29.0.1/distribution/docker/docker-compose.yml. It all starts up fine but I try to do a simple "paste data" ingestion of some comma seperated data:
day, amount
1,1
2,2
3,4
4,8
5,16
6,32
```

I get an error and see this in the middlemanager logs

```
middlemanager  | 2024-05-10T21:20:59,508 INFO [forking-task-runner-1] org.apache.druid.indexing.overlord.ForkingTaskRunner - Logging task query-64c248f2-1516-422c-ba60-79d01f644de8-worker0_0 output to: var/druid/task/slot1/query-64c248f2-1516-422c-ba60-79d01f644de8-worker0_0/log
middlemanager  | 2024-05-10T21:20:59,509 DEBUG [qtp514556983-73] org.apache.druid.jetty.RequestLog - 192.168.48.4 GET //192.168.48.7:8091/druid-internal/v1/worker?counter=8&hash=1715376059501&timeout=180000 HTTP/1.1 204
middlemanager  | 2024-05-10T21:20:59,554 DEBUG [SegmentChangeRequestHistory] org.apache.druid.jetty.RequestLog - 192.168.48.4 GET //192.168.48.7:8091/druid-internal/v1/worker?counter=9&hash=1715376059503&timeout=180000 HTTP/1.1 200
middlemanager  | 2024-05-10T21:21:22,349 INFO [forking-task-runner-1] org.apache.druid.indexing.overlord.ForkingTaskRunner - Exception caught during execution
middlemanager  | org.apache.druid.java.util.common.IOE: Cannot create directory [/opt/shared/indexing-logs]
middlemanager  |        at org.apache.druid.java.util.common.FileUtils.mkdirp(FileUtils.java:488) ~[druid-processing-29.0.1.jar:29.0.1]
middlemanager  |        at org.apache.druid.indexing.common.tasklogs.FileTaskLogs.pushTaskLog(FileTaskLogs.java:53) ~[druid-indexing-service-29.0.1.jar:29.0.1]
middlemanager  |        at org.apache.druid.indexing.overlord.ForkingTaskRunner.waitForTaskProcessToComplete(ForkingTaskRunner.java:517) ~[druid-indexing-service-29.0.1.jar:29.0.1]
middlemanager  |        at org.apache.druid.indexing.overlord.ForkingTaskRunner$1.call(ForkingTaskRunner.java:404) ~[druid-indexing-service-29.0.1.jar:29.0.1]
middlemanager  |        at org.apache.druid.indexing.overlord.ForkingTaskRunner$1.call(ForkingTaskRunner.java:171) ~[druid-indexing-service-29.0.1.jar:29.0.1]
middlemanager  |        at com.google.common.util.concurrent.TrustedListenableFutureTask$TrustedFutureInterruptibleTask.runInterruptibly(TrustedListenableFutureTask.java:131) ~[guava-32.0.1-jre.jar:?]
middlemanager  |        at com.google.common.util.concurrent.InterruptibleTask.run(InterruptibleTask.java:75) ~[guava-32.0.1-jre.jar:?]
middlemanager  |        at com.google.common.util.concurrent.TrustedListenableFutureTask.run(TrustedListenableFutureTask.java:82) ~[guava-32.0.1-jre.jar:?]
middlemanager  |        at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136) ~[?:?]
middlemanager  |        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635) ~[?:?]
middlemanager  |        at java.lang.Thread.run(Thread.java:840) ~[?:?]
middlemanager  | 2024-05-10T21:21:22,355 INFO [forking-task-runner-1] org.apache.druid.indexing.overlord.ForkingTaskRunner - Removing task directory: var/druid/task/slot1/query-64c248f2-1516-422c-ba60-79d01f644de8-worker0_0
middlemanager  | 2024-05-10T21:21:22,449 DEBUG [SegmentChangeRequestHistory] org.apache.druid.jetty.RequestLog - 192.168.48.4 GET //192.168.48.7:8091/druid-internal/v1/worker?counter=10&hash=1715376059553&timeout=180000 HTTP/1.1 200
middlemanager  | 2024-05-10T21:21:22,471 INFO [WorkerTaskManager-NoticeHandler] org.apache.druid.indexing.worker.WorkerTaskManager - Task [query-64c248f2-1516-422c-ba60-79d01f644de8-worker0_0] completed with status [FAILED].
middlemanager  | 2024-05-10T21:21:24,053 INFO [forking-task-runner-0] org.apache.druid.indexing.overlord.ForkingTaskRunner - Exception caught during execution
middlemanager  | org.apache.druid.java.util.common.IOE: Cannot create directory [/opt/shared/indexing-logs]
middlemanager  |        at org.apache.druid.java.util.common.FileUtils.mkdirp(FileUtils.java:488) ~[druid-processing-29.0.1.jar:29.0.1]
middlemanager  |        at org.apache.druid.indexing.common.tasklogs.FileTaskLogs.pushTaskLog(FileTaskLogs.java:53) ~[druid-indexing-service-29.0.1.jar:29.0.1]
middlemanager  |        at org.apache.druid.indexing.overlord.ForkingTaskRunner.waitForTaskProcessToComplete(ForkingTaskRunner.java:517) ~[druid-indexing-service-29.0.1.jar:29.0.1]
middlemanager  |        at org.apache.druid.indexing.overlord.ForkingTaskRunner$1.call(ForkingTaskRunner.java:404) ~[druid-indexing-service-29.0.1.jar:29.0.1]
middlemanager  |        at org.apache.druid.indexing.overlord.ForkingTaskRunner$1.call(ForkingTaskRunner.java:171) ~[druid-indexing-service-29.0.1.jar:29.0.1]
middlemanager  |        at com.google.common.util.concurrent.TrustedListenableFutureTask$TrustedFutureInterruptibleTask.runInterruptibly(TrustedListenableFutureTask.java:131) ~[guava-32.0.1-jre.jar:?]
middlemanager  |        at com.google.common.util.concurrent.InterruptibleTask.run(InterruptibleTask.java:75) ~[guava-32.0.1-jre.jar:?]
middlemanager  |        at com.google.common.util.concurrent.TrustedListenableFutureTask.run(TrustedListenableFutureTask.java:82) ~[guava-32.0.1-jre.jar:?]
middlemanager  |        at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136) ~[?:?]
middlemanager  |        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635) ~[?:?]
middlemanager  |        at java.lang.Thread.run(Thread.java:840) ~[?:?]
middlemanager  | 2024-05-10T21:21:24,055 INFO [forking-task-runner-0] org.apache.druid.indexing.overlord.ForkingTaskRunner - Removing task directory: var/druid/task/slot0/query-64c248f2-1516-422c-ba60-79d01f644de8
middlemanager  | 2024-05-10T21:21:24,132 DEBUG [SegmentChangeRequestHistory] org.apache.druid.jetty.RequestLog - 192.168.48.4 GET //192.168.48.7:8091/druid-internal/v1/worker?counter=11&hash=1715376082442&timeout=180000 HTTP/1.1 200
middlemanager  | 2024-05-10T21:21:24,148 INFO [WorkerTaskManager-NoticeHandler] org.apache.druid.indexing.worker.WorkerTaskManager - Task [query-64c248f2-1516-422c-ba60-79d01f644de8] completed with status [FAILED].
middlemanager  | 2024-05-10T21:24:19,253 DEBUG [SegmentChangeRequestHistory] org.apache.druid.jetty.RequestLog - 192.168.48.4 GET //192.168.48.7:8091/druid-internal/v1/worker?counter=12&hash=1715376084130&timeout=180000 HTTP/1.1 200
middlemanager  | 2024-05-10T21:24:19,257 DEBUG [qtp514556983-82] org.apache.druid.jetty.RequestLog - 192.168.48.4 GET //192.168.48.7:8091/druid-internal/v1/worker?counter=13&hash=1715376259251&timeout=180000 HTTP/1.1 204
```

I'm using the exact same version of the environment file from the repo here: https://github.com/apache/druid/blob/29.0.1/distribution/docker/environment

Is there something I'm missing? Cause I've read everything I could find and supposedly the named volumes were changed to fix this, but I seem to still be seeing the same problem.

I was able to get this working by adding
user:root to the middlemanager, not an ideal solution but for anyone else who runs into this.

repo: apache/druid


text:
fix authorization integration test refactoring missed in previous PR

missed this in #11730

forgot about this, but doesn't seem necessary now


text:
metadata client

实现metadata的读操作，从元数据中心读取元数据。

Sorry, because this issue was raised very early, we have closed it temporarily. You can verify whether this problem still exists in the latest code of the develop branch. If this problem still exists, please reopen it at any time.

repo: apache/dubbo-admin


text:
Reference Level MigrationStep Logic

从官方文档来看, 是支持Reference级别的MigrationStep配置的.

但MigrationRule会缓存首次从ConsumerURL里解析出来的migration.step. 第二个ConsumerURL进来时, 支持取的上次的解析结果. 这块有点疑惑, 是逻辑BUG 还是设计如此.
public MigrationStep getStep(URL consumerURL) {
        MigrationStep value = getValue(consumerURL, SubMigrationRule::getStep);
        if (value != null) {
            return value;
        }

        /**
         * FIXME, it's really hard to follow setting default values here.
         */
        if (step == null) {
            // initial step : APPLICATION_FIRST
            step = MigrationStep.APPLICATION_FIRST;
           // 这里会缓存上次解析结果
            step = Enum.valueOf(MigrationStep.class,
                consumerURL.getParameter(MIGRATION_STEP_KEY, getDefaultStep(consumerURL, step.name())));
        }

        return step;
    }

下面这块是为了设置一个默认值呀

step = Enum.valueOf(MigrationStep.class,
consumerURL.getParameter(MIGRATION_STEP_KEY, getDefaultStep(consumerURL, step.name())));
看逻辑这里才会去ReferenceConfig里获取migration.step这个参数值, 缓存之后下一个ReferenceConfig里获取的就是上个ReferenceConfig里的值了. 目前这边有个场景是部分Reference需要声明FORCE_APPLICATION, 不使用默认的APPLICATION_FIRST.

Fix in https://github.com/apache/dubbo/pull/13237

authors: AlbumenJ iJIAJIA

repo: apache/dubbo


text:
多注册中心，服务覆盖问题

[ ] I have searched the issues of this repository and believe that this is not a duplicate.

Environment

Dubbo version: 3.0.4
Operating System version: ubuntu 18
Java version: 11
nacos version: 2.0.3
protocol: tri
spring boot version: 2.4.9

Steps to reproduce this issue
引用多注册中心，第一次切换访问可以成功，后面的请求全部都打到上次请求的服务上去了。
配置如下
@DubboReference(providedBy = "data-mysql", registry = "ali-sgp", id = "intlAuditLabelService", stub = "intlAuditLabelService", check = false)
 private AuditLabelService intlAuditLabelService;
 @DubboReference(providedBy = "data-mysql", registry = "aws-mb", id = "indAuditLabelService", stub = "indAuditLabelService", check = false)
    private AuditLabelService indAuditLabelService;
dubbo:
registries:
aws-mb:
address: nacos://${nacos.aws-mb.host}:${nacos.aws-mb.port}?namingLoadCacheAtStart=false&username=${nacos.aws-mb.username}&password=${nacos.aws-mb.password}&namespace=${nacos.aws-mb.namespace}
id: aws-mb
timeout: 1100
preferred: true
ali-sgp:
address: nacos://${nacos.ali-sgp.host}:${nacos.ali-sgp.port}?namingLoadCacheAtStart=false&username=${nacos.ali-sgp.username}&password=${nacos.ali-sgp.password}&namespace=${nacos.ali-sgp.namespace}
id: ali-sgp
timeout: 1300

第一次切换访问可以成功，后面的请求全部都打到上次请求的服务上去了。

@feng996 劳烦把这部分问题详细描述一下：服务部署情况，怎么操作的切换，最终问题现象等

https://github.com/apache/dubbo/issues/9427


text:
Update README.md

links are not updated, i feel they are moved in playground repo

Thanks @SiddiqueAhmad. You are correct that the links are outdated due to the examples being moved to the flink-statefun-playground repo.
I'll merge this now. As a follow-up, there is actually going to be a series of rework on the current README to reflect all the recent changes.

authors: SiddiqueAhmad tzulitai

repo: apache/flink-statefun


text:
[FLINK-14021][table-planner][table-planner-blink] Add rules to push down the Python ScalarFunctions contained in the join condition of Correlate node

What is the purpose of the change
This pr solve the problem that the Python ScalarFunctions contained in the join condition of Correlate node should be extracted to make sure the TableFunction works well.
Brief change log

Add SplitPythonConditionFromCorrelateRule to split python condition in correlate

Verifying this change
This change added tests and can be verified as follows:
-SplitPythonConditionFromCorrelateRuleTest
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
The serializers: (no)
The runtime per-record code paths (performance sensitive): (no)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
The S3 file system connector: (no)

Documentation

Does this pull request introduce a new feature? (no)
If yes, how is the feature documented? (not applicable)

Thanks a lot for @hequn8128 review. I have addressed the comments at the latest commit.

@HuangXingBo Thanks a lot for the update. Merging...

repo: apache/flink


text:
[FLINK-2017] Add predefined required parameters to ParameterTool

adds Option class to represent required parameter
adds RequiredParameter class to interact with ParameterTool to check and/or validate parameters
adds corresponding unit tests

One of the builds failed because of a test failure in:
CoStreamCheckpointingITCase>StreamFaultToleranceTestBase.runCheckpointedProgram:105->postSubmit:126 Restore was never called on counting Map function.
I will check it out and update the pull request if necessary.

Thanks for the PR! I am sure that the mentioned test failure is unrelated to your changes. If you like, you can create a new issue with the label test-instability for the failing test.

OK, cool. I have created a separate ticket. https://issues.apache.org/jira/browse/FLINK-2628

Thanks for the PR @mliesenberg!
Can you add the checks (and tests to verify the checks are working) that I mentioned in my comments?
The original JIRA issue also included type checks. I think we could restrict those to Java primitives (Integer, Long, Double, Float, Boolean).
I would be OK with adding this PR without type checks (and opening another JIRA for that) but it would be a cool feature if you'd like to add that.

@fhueske Yes, I will add the checks.
Regarding the type checks: Does that refer to the interaction with the ParameterTool class? I thought about that as well, but there the values are stored as strings and only upon retrieval the expected types are used.

If you add a type field (or enum) to the option, you can check if you can cast the string into the requested type. Since we would only support a fixed set of types (the primitives I listed above) this should be quite easy.

Ok, I will add that.

The test failure seems unrelated to my changes. It's connected to the YARNSessionFIFOITCase test.
FLINK-2700 has been opened a couple of days ago with the same error.

I'll soon review this pull request. Sorry for the delay.

Looks like good progress! As pointed out in one of my comments, I think we should make the use a bit more intuitive. Having two methods which are named so similar but which do different things is not a good idea. IMO it would be better to have one method that applies (and checks) the required options to the parsed parameters.

I think that might just boil down to the question whether or not there is a common enough use case for one without the other.
If so, we could change it to one method for check and one for populate which would untangle the code a bit as well.
If there is no use case for one without the other, I'd agree to get rid of the check.
I am unfortunately a bit pressed for time at the moment, but hope to find time to address the other comments during the weekend and.

Going through FLINK-2017, I interpreted the semantics of check and checkAndPopulate as follows:

check verifies that all required parameters are provided and valid (type, choice, etc.)
checkAndPopulate copied the default values of the options into the ParameterTool

I think a method that is called checkAndPopulate should perform the same checks as check and do the populate in addition. Moreover, I do not see why check alone would be useful. Why would somebody define required parameters with default values without enforcing them, i.e., why you call check without checkAndPopulate.
If we have a single method, we could also give it a simpler name such as applyTo.
What do you think?

I do see your point about the uselessness of only check, so I'll go ahead and implement applyTo.
I'll update the PR tonight.

Thanks!

Thanks for the update!
Except for my comments, the only remaining question is whether to offer the add(Option) method or not, right?

Yes, that's right.
I'll address the comments tonight. If the add(Option) issue is blocking the merge, we can just drop the function it, if you want.

I think it's fine to have an add(Option) method in addition to add(String). There might be cases where you want to create the Options first and add them later on.

Thanks @mxm for the feedback. Then let's keep this PR as it is :-)

Ok, should I rebase on the current master and squash the commits into one before it will be merged?

Yes, that would be nice. Thanks

Hi @rmetzger, do you want to give it another look and check if it does what you intended with FLINK-2017?

Thank you for reviewing the pull request while I was away @fhueske.
I've just tried it out with this code:
RequiredParameters rp = new RequiredParameters();
rp.add("input");
rp.add("output");
rp.add(new Option("parallelism").alt("p").help("Set the parallelism for all operators").type(OptionType.INTEGER));
ParameterTool pt = ParameterTool.fromArgs(args);
try {
	rp.applyTo(pt);
} catch(RequiredParametersException rpe) {
	System.out.println(rp.getHelp());
	System.exit(1);
}

and the output is the following:
 Required Parameter
name, short name, help text, default valueinput	null
output	null
parallelism	p	Set the parallelism for all operators

I think the getHelp method is not producing helpful output here.
How about something like:
Required Parameters:
    --input
    --output
    -p, --parallelism        Set the parallelism for all operators

The RequiredParametersException could list the missing arguments.

I'll address the comments and rework the getHelp method to produce more useful output (and cover that with more tests).

thanks for the feedback.

Thank you for reacting so quickly to my feedback.
I'm sorry for the delays during the PR review.

Sure, no problem.
One comment concerning the comment:
The RequiredParametersException could list the missing arguments.
At the moment the validation in applyTo fails with the first missing parameter. To list all missing arguments would require to change that, but it might be worth it.
What do you think?

I think it should not be too hard to collect all the issues in a list and then throw the exception in the end.
What do you mean by the optional list? Only listing those arguments which are still missing?

optional in the sense of, if the list is passed, then the missing arguments are added to the help text in an extra paragraph at the end.
realized probably via method overloading.

Okay, I think its a good idea.

cool. will update the PR today.

I think the test cases are not good enough.
I tried it out with this code again:
RequiredParameters rq = new RequiredParameters();
rq.add("input");
rq.add(new Option("parallelism").alt("p").defaultValue("1").type(OptionType.INTEGER));
ParameterTool pt = ParameterTool.fromArgs(args);
rq.applyTo(pt);

and got the following error:
Exception in thread "main" org.apache.flink.api.java.utils.RequiredParametersException: Value null is not in the list of valid choices
	at org.apache.flink.api.java.utils.RequiredParameters.applyTo(RequiredParameters.java:126)
	at org.apache.flink.examples.java.wordcount.WordCount.main(WordCount.java:64)

Passing --input abc will result in RequiredParametersException: Value abc is not in the list of valid choices.
The output of the help method looks better now
Required Parameters:
	--input
	-p, --parallelism	Set a parallelism for the job	default: 1
	--ouput	This is my help

Oha. yes. Found the problem causing the exception, will fix it and make the tests more specific as to which exceptions they need to catch.
While I am at it, anything else which needs change or are we good to go?
I'll update the PR tomorrow.

No, I think once that's resolved, the PR is good to merge.

Cool. Pushed my latest changes which fix the bug and add more test cases.
Btw., is there any way to see a test coverage report?

Yes, in IntelliJ the button right to the Debug button will generate a test coverage report.

I'm wondering whether you are trying to run the examples I'm posting here:
RequiredParameters rq = new RequiredParameters();
rq.add("input");
rq.add(new Option("parallelism").alt("p").defaultValue("1").type(OptionType.INTEGER));
ParameterTool pt = ParameterTool.fromArgs(args);
rq.applyTo(pt);

with --input abc
leads to:
Exception in thread "main" org.apache.flink.api.java.utils.RequiredParametersException: Value for parameter parallelism cannot be cast to type INTEGER
	at org.apache.flink.api.java.utils.RequiredParameters.applyTo(RequiredParameters.java:123)
	at org.apache.flink.examples.java.wordcount.WordCount.main(WordCount.java:65)

I didn't provide any value for parallelism and I was expecting it to be set automatically to 1.
I would recommend you to at least add the examples I'm posting here as test cases.

Oha. that is embarrassing, I thought I had it covered. I'll look into it. Sorry for the mess.

the build failure is due to a test in streaming, so most likely not related.
the test failure has been observed before and is captured in issue FLINK-2348

I've tested the PR again.
I found a minor issue with the alternative arguments.
input: --input abc --p 12,
code:
RequiredParameters rq = new RequiredParameters();
		rq.add("input");
		rq.add(new Option("parallelism").alt("p").defaultValue("1").type(OptionType.INTEGER));
		ParameterTool pt = ParameterTool.fromArgs(args);
		rq.applyTo(pt);

		String in = pt.get("input");
		System.out.println("In = "+in + " parallelism = "+pt.getInt("parallelism") + " p="+pt.getInt("p"));

		System.exit(0);

error
Exception in thread "main" java.lang.RuntimeException: No data for required key 'p'
	at org.apache.flink.api.java.utils.ParameterTool.getRequired(ParameterTool.java:236)
	at org.apache.flink.api.java.utils.ParameterTool.getInt(ParameterTool.java:272)
	at org.apache.flink.examples.java.wordcount.WordCount.main(WordCount.java:69)

I think we need to set the (default) value for the long and the short variant.

yep, based on the discussion above with fabian the default value is set only on the long key.
I'll go ahead and set it on the short key as well, if nothing else is defined.
I think the issue above is something else though:
when a value is found for the short key, but not the long key, it is copied to the long key and removed from the short key - also based on my understanding of the discussion above. rereading it and seeing your use case, it is probably better to drop the removal from the short key.

Oh, I see. I have to admit I didn't closely follow the discussion with Fabian.
Would be nice if you could change the behavior.

ok. done.

Thank you for addressing the issues so timely.
I'll merge the change now, thank you!

authors: fhueske mliesenberg mxm rmetzger uce