text:
using vscode loader makes package.json mandatory or the extension will crash

Hello.
I use LunarVim and they recently added the option to load snippets form snipmate and vscode. I only use snipmate in my local configuration, but friendlysnippets is installed, so I guess that executing both loaders is mandatory.
However, if I create some snippets in a runtime path called snippets to provide snipmate snippets, the extension expects a package.json file and if it does not find it ti crashes.
I think some checks should be performed before blindly trying to load a file that may not exist.

Oh this isn't expected to happen, I also have snipmate and vscode-snippets for testing, and haven't encountered crashes because of that before.
Could you show more of your setup?

Is it alright if this is closed? IMO it's okay if luasnip just throws an error if an incorrect path is passed.

the thing is that the path to the folder it's correct, it's the assumption that there is a json file in there what it is incorrect and causing the error. What about checking for the existence first and just ignore it if not present? Throwing an error will stop the process of loading other extensions and will leave neovim in an inconsistent state

Wasn't the problem that the wrong directory is passed to the vscode-loader?
Oh, maybe you're not aware: we cannot just load the .json-files, we need the package.json, it's part of the vscode-package "spec" (see friendly-snippets for an example).
So passing a directory that (potentially) doesn't contain a package.json to the vscode-loader is incorrect.
The snipmate-loader, on the other hand, takes a plain snippets-directory which contains .snippets-files.
Just ignoring the directory would be counterproductive IMO (the reason for some snippets not loading would not be communicated at all)

Just ignoring the directory would be counterproductive IMO (the reason for some snippets not loading would not be communicated at all)

you can always issue a warning. Still think that making it crash is the worst option because it can render the editor unusable until you fix the problem or deactivate the extension, and having other extensions not working because this one crashed can be even more confusing, IMO

Oh, I tried it earlier and loading without package.json did not cause a crash, only an error.
If it actually crashes neovim entirely that's a different matter, we can add a check to prevent that

Is there any error-message upon crashing?
I'm not quite sure where the crash comes from, normally it should be caught by assert(uv.fs_open(...)), which we use exactly like recommended in luv-documentation(https://github.com/luvit/luv/blob/master/docs.md#file-system-operations).

Yes, I get an error message that says it can not open a file that does not exists, then some of my settings are not loaded, which makes me think either packer crashes or something else crashes. I'll try to reproduce it later and put the exact error messages

AFAICT it's fixed in lunarvim now, I'll close this too


text:
npm run serve -- erreur linter

Bonjour.
J'ai voulu jouer un peu avec le code et lancer un npm run serve.
J'obtiens l'erreur suivante
/home/Pierre/code/github/attestation-deplacement-derogatoire-q4-2020/src/js/form.js
  17:26  error  Extra semicolon  semi
  18:82  error  Extra semicolon  semi

https://github.com/LAB-MI/attestation-deplacement-derogatoire-q4-2020/blob/main/src/js/form.js#L16
Alors rien de bien méchant en soit, et cela n'est pas une erreur du code en lui même, mais votre linter semble ne pas être en accord avec votre code.

https://github.com/LAB-MI/attestation-deplacement-derogatoire-q4-2020/pull/60 ?

Parfait 👍

source: gharchive/issue

license: MIT

license_type: permissive

license_source: github-api


text:
Orthographe de GitHub

https://github.com/LAB-MI/deplacement-covid-19/blob/61b778a27ede6d9f1185733a7237a52deec92a56/src/index.html#L259
En réalité c'est GitHub 👼

Bonjour, la correction sera apportée lors d'une prochaine livraison.

Bonjour @AntoineAugusti, La correction a été apportée. Bien cordialement,

authors: AntoineAugusti infosteph


text:
Feature: juju-jockey CLI testing

Problem
Current testing does not includes calls to juju-jockey.  Ideally, these tests commands would be run in the context of a snap, just as a real user would.
Proposed Feature
Add tests which call juju-jockey in a variety of contexts.  A minimum coverage list would be:

juju-jockey info
Querying units with various filters
Querying machines with various filters
Querying across models (in the near future)

100% +1 here. This can catch regressions in the syntax and obvious errors that unit tests may not catch due to them loading functions in through the library interface.

authors: LCVcode johnlettman

repo: LCVcode/jockey


text:
Cannot install the package to user's home

How to reproduce:
$ pip3 install --user .
Processing /home/rbosak/frepos/jenkins-cli-python
Requirement already satisfied (use --upgrade to upgrade): python-jenkins==0.4.14 in /home/rbosak/.local/lib/python3.5/site-packages (from jenkins-cli==0.1.2)

...

copying build/lib/tests/test_cli.py -> /home/rbosak/.local/lib/python3.5/site-packages/tests
    byte-compiling /home/rbosak/.local/lib/python3.5/site-packages/jenkins_cli/cli_arguments.py to cli_arguments.cpython-35.pyc
    byte-compiling /home/rbosak/.local/lib/python3.5/site-packages/jenkins_cli/cli.py to cli.cpython-35.pyc
    byte-compiling /home/rbosak/.local/lib/python3.5/site-packages/jenkins_cli/version.py to version.cpython-35.pyc
    byte-compiling /home/rbosak/.local/lib/python3.5/site-packages/jenkins_cli/__init__.py to __init__.cpython-35.pyc
    byte-compiling /home/rbosak/.local/lib/python3.5/site-packages/tests/__init__.py to __init__.cpython-35.pyc
    byte-compiling /home/rbosak/.local/lib/python3.5/site-packages/tests/test_cli.py to test_cli.cpython-35.pyc
    running install_data
    copying contrib/bash-completion/jenkins -> /usr/share/bash-completion/completions
    error: could not create '/usr/share/bash-completion/completions/jenkins': Permission denied

    ----------------------------------------
Command "/usr/bin/python3 -u -c "import setuptools, tokenize;__file__='/tmp/pip-2rmzm77_-build/setup.py';exec(compile(getattr(tokenize, 'open', open)(__file__).read().replace('\r\n', '\n'), __file__, 'exec'))" install --record /tmp/pip-0y1rkq6j-record/install-record.txt --single-version-externally-managed --compile --user --prefix=" failed with error code 1 in /tmp/pip-2rmzm77_-build/

The problem are the bash completion files, for copying which the user has no permissions.
I can workaround this by changing this in setup.py:
for d in completion_dirs:
    if os.path.isdir(d):
        data_files.append((d, ['contrib/bash-completion/jenkins']))

to this
for d in completion_dirs:
    if os.path.isdir(d):
        pass

This will, of course, install no bash completion files.
Let me note that sudo pip3 install something is NOT recommended, at least not in Fedora linux. It can mess up your distro-provided packages.

I am not sure if it possible to setup bash completion files without sudo privileges.

This might work, but I haven't tried it yet https://serverfault.com/a/506707
The other option is not to install them. Still better than fail with no explanation.

I have several thoughts about it:

When you installing package you still need sudo for most cases. The same is here, but we have pip for our package manager.

Adding to ~/.bash_completion would be hard to maintain.

We can give an option "do not to install bash completion" or make a friendly warning if sudo is not used.

I went with your option 3 in PR #40. Please take a look :)
I agree that option 2 could be tricky
Regarding point 1: I would say it's quite common to install pip packages as non-root (and for most packages it works fine).

license: mit

license_source: bigquery


text:
Add support for ProcessorContext.Forward(...)

A bit related to: #199
Assume we have punctuators that generate messages that need to go through the processing pipeline, in this case we're outside of the Process(..) method in the Transformer and need a way to feed data through the pipeline.
In come the Forward methods:
  void Forward(K, V);
  void Forward(K, V, To);

Directly forwarding on the ProcessorContext might also come in handy when e.g. the transformation function (Process) generates not 1, but multiple messages that need the processed further.  In that case we can simply pass each message individually through the pipeline without the need to explicitly model a List or something as output of the transformer.

Hi, I just started using this project and came across a need to write my own Transformer that would output multiple events, so believe I need this feature. I see the PR is merged and the code is scheduled for the 1.5.0 release. Just wondering if you had a rough timeline on that version? Thanks.

Hi @Choc13 ,
End Q2'23 : https://github.com/LGouellec/kafka-streams-dotnet/milestone/4

authors: Choc13 LGouellec duke-bartholomew

repo: LGouellec/kafka-streams-dotnet


text:
Fix: Replaceable test parameters can also replace test case names

Fixes #723

@juhlee-microsoft @lizzha please check and merge.

@juhlee-microsoft @lizzha please check and merge.

@iamshital, please post the test result how it works.

I've added "DO-NOT-MERGE" until I thoroughly test this PR.

Logs :
PS D:\GitHub\LISAv2> .\Run-LisaV2.ps1 -TestPlatform "Azure" -TestLocation "westus2" -RGIdentifier "mylisatest" -OsVHD "testimage.vhd" -XMLSecretFile "D:\GitHub\LISAv2\XML\AzureSecrets.xml" -TestNames VERIFY-INFINIBAND-INTEL-MPI-2VM-STANDARD-A8 -CustomParameters "INFINIBAND_INTEL_TOTAL_REBOOT_COUNT=100;INFINIBAND_INTEL_MPI_SETTINGS=TEST-TEST-TEST;INFINIBAND_INTEL_PPN=200"
02-15-2019 19:26:28 : [INFO ] Autogenerated test ID: BP77
02-15-2019 19:26:28 : [INFO ] Found branch information and updated with  fix723
02-15-2019 19:26:28 : [INFO ] Logging directory: D:\GitHub\LISAv2\TestResults\2019-16-02-00-56-28-6935
02-15-2019 19:26:28 : [INFO ] Setting parameter: TestPlatform = Azure
02-15-2019 19:26:28 : [INFO ] Setting parameter: TestLocation = westus2
02-15-2019 19:26:28 : [INFO ] Setting parameter: RGIdentifier = mylisatest
02-15-2019 19:26:28 : [INFO ] Setting parameter: OsVHD = testimage.vhd
02-15-2019 19:26:28 : [INFO ] Setting parameter: TestNames = VERIFY-INFINIBAND-INTEL-MPI-2VM-STANDARD-A8
02-15-2019 19:26:28 : [INFO ] Setting parameter: TestIterations = 1
02-15-2019 19:26:28 : [INFO ] Setting parameter: XMLSecretFile = D:\GitHub\LISAv2\XML\AzureSecrets.xml
02-15-2019 19:26:28 : [INFO ] Setting parameter: CustomParameters = INFINIBAND_INTEL_TOTAL_REBOOT_COUNT=100;INFINIBAND_INTEL_MPI_SETTINGS=TEST-TEST-TEST;INFINIBAND_INTEL_PPN=200
02-15-2019 19:26:29 : [INFO ] Test parameters for Azure have been validated successfully. Continue running the test.
02-15-2019 19:26:29 : [INFO ] Updated Test Case xml files.
02-15-2019 19:26:29 : [INFO ] Using provided secrets file: D:\GitHub\LISAv2\XML\AzureSecrets.xml
02-15-2019 19:26:29 : [INFO ] D:\GitHub\LISAv2\XML\AzureSecrets.xml found.
02-15-2019 19:26:29 : [INFO ] ------------------------------------------------------------------
02-15-2019 19:26:29 : [INFO ] Authenticating Azure PS session..
02-15-2019 19:26:36 : [INFO ] Current Subscription : 2cd20493-xxxx-xxxx-xxxx-ab95b63d82c4.
02-15-2019 19:26:36 : [INFO ] ------------------------------------------------------------------
02-15-2019 19:26:36 : [INFO ] Auto selecting storage account : eosgwestus2 as per your test region.
02-15-2019 19:26:36 : [INFO ] Updated D:\GitHub\LISAv2\XML\GlobalConfigurations.xml file.
02-15-2019 19:26:36 : [INFO ] ------------------------------------------------------------------
02-15-2019 19:26:37 : [INFO ] SubscriptionName       : Linux Integration Services Dev & Test
02-15-2019 19:26:37 : [INFO ] SubscriptionId         : 2cd20493-xxxx-xxxx-xxxx-ab95b63d82c4
02-15-2019 19:26:37 : [INFO ] User                   : e4284ff8-xxxx-xxxx-xxxx-46675ee7d752
02-15-2019 19:26:37 : [INFO ] ServiceEndpoint        : https://management.core.windows.net/
02-15-2019 19:26:37 : [INFO ] CurrentStorageAccount  : eosgwestus2
02-15-2019 19:26:37 : [INFO ] ------------------------------------------------------------------
02-15-2019 19:26:37 : [INFO ] Setting global variables
02-15-2019 19:26:37 : [INFO ] Validating XML Files from D:\GitHub\LISAv2 folder recursively...
02-15-2019 19:26:39 : [INFO ] Collected: VERIFY-INFINIBAND-INTEL-MPI-2VM-STANDARD-A8
02-15-2019 19:26:39 : [INFO ] 1 Test Cases have been collected
02-15-2019 19:26:39 : [INFO ] Checking custom parameters ...
02-15-2019 19:26:39 : [INFO ] Custom Parameter: INFINIBAND_INTEL_TOTAL_REBOOT_COUNT=1 --> 100
02-15-2019 19:26:39 : [INFO ] Custom Parameter: INFINIBAND_INTEL_MPI_SETTINGS=-env I_MPI_FABRICS shm:dapl -env I_MPI_DAPL_PROVIDER=ofa-v2-ib0 -env SECS_PER_SAMPLE=600 --> TEST-TEST-TEST
02-15-2019 19:26:39 : [INFO ] Custom Parameter: INFINIBAND_INTEL_PPN=2 --> 200
02-15-2019 19:26:39 : [INFO ] Custom parameter(s) are ready to be injected along with default parameters, if any.
02-15-2019 19:26:39 : [INFO ] INFINIBAND_INTEL_TOTAL_REBOOT_COUNT=100 injected to case VERIFY-INFINIBAND-INTEL-MPI-2VM-STANDARD-A8
02-15-2019 19:26:39 : [INFO ] INFINIBAND_INTEL_MPI_SETTINGS=TEST-TEST-TEST injected to case VERIFY-INFINIBAND-INTEL-MPI-2VM-STANDARD-A8
02-15-2019 19:26:39 : [INFO ] INFINIBAND_INTEL_IB_NIC=eth1 injected to case VERIFY-INFINIBAND-INTEL-MPI-2VM-STANDARD-A8
02-15-2019 19:26:39 : [INFO ] INFINIBAND_INTEL_MPI_TESTNAMES=pingpong allreduce injected to case VERIFY-INFINIBAND-INTEL-MPI-2VM-STANDARD-A8
02-15-2019 19:26:39 : [INFO ] INFINIBAND_INTEL_PPN=200 injected to case VERIFY-INFINIBAND-INTEL-MPI-2VM-STANDARD-A8
02-15-2019 19:26:39 : [INFO ] INFINIBAND_INTEL_MPI_TEST_COUNT=1000 injected to case VERIFY-INFINIBAND-INTEL-MPI-2VM-STANDARD-A8
02-15-2019 19:26:39 : [INFO ] INFINIBAND_INTEL_RMA_TESTNAMES=all injected to case VERIFY-INFINIBAND-INTEL-MPI-2VM-STANDARD-A8
02-15-2019 19:26:39 : [INFO ] INFINIBAND_INTEL_RMA_TEST_COUNT=1 injected to case VERIFY-INFINIBAND-INTEL-MPI-2VM-STANDARD-A8
02-15-2019 19:26:39 : [INFO ] INFINIBAND_INTEL_NBC_TESTNAMES=all injected to case VERIFY-INFINIBAND-INTEL-MPI-2VM-STANDARD-A8
02-15-2019 19:26:39 : [INFO ] INFINIBAND_INTEL_NBC_TEST_COUNT=1 injected to case VERIFY-INFINIBAND-INTEL-MPI-2VM-STANDARD-A8
02-15-2019 19:26:40 : [INFO ] Starting the test

Existing functionality is not impacted. (Executed without any custom parameters)
02-15-2019 19:29:16 : [INFO ] Setting global variables
02-15-2019 19:29:16 : [INFO ] Validating XML Files from D:\GitHub\LISAv2 folder recursively...
02-15-2019 19:29:18 : [INFO ] Collected: VERIFY-INFINIBAND-INTEL-MPI-2VM-STANDARD-A8
02-15-2019 19:29:18 : [INFO ] 1 Test Cases have been collected
02-15-2019 19:29:18 : [INFO ] INFINIBAND_INTEL_TOTAL_REBOOT_COUNT=1 injected to case VERIFY-INFINIBAND-INTEL-MPI-2VM-STANDARD-A8
02-15-2019 19:29:18 : [INFO ] INFINIBAND_INTEL_MPI_SETTINGS=-env I_MPI_FABRICS shm:dapl -env I_MPI_DAPL_PROVIDER=ofa-v2-ib0 -env SECS_PER_SAMPLE=600 injected to case VERIFY-INFINIBAND-INTEL-MPI-2VM-STANDARD-A8
02-15-2019 19:29:18 : [INFO ] INFINIBAND_INTEL_IB_NIC=eth1 injected to case VERIFY-INFINIBAND-INTEL-MPI-2VM-STANDARD-A8
02-15-2019 19:29:18 : [INFO ] INFINIBAND_INTEL_MPI_TESTNAMES=pingpong allreduce injected to case VERIFY-INFINIBAND-INTEL-MPI-2VM-STANDARD-A8
02-15-2019 19:29:18 : [INFO ] INFINIBAND_INTEL_PPN=2 injected to case VERIFY-INFINIBAND-INTEL-MPI-2VM-STANDARD-A8
02-15-2019 19:29:18 : [INFO ] INFINIBAND_INTEL_MPI_TEST_COUNT=1000 injected to case VERIFY-INFINIBAND-INTEL-MPI-2VM-STANDARD-A8
02-15-2019 19:29:18 : [INFO ] INFINIBAND_INTEL_RMA_TESTNAMES=all injected to case VERIFY-INFINIBAND-INTEL-MPI-2VM-STANDARD-A8
02-15-2019 19:29:18 : [INFO ] INFINIBAND_INTEL_RMA_TEST_COUNT=1 injected to case VERIFY-INFINIBAND-INTEL-MPI-2VM-STANDARD-A8
02-15-2019 19:29:18 : [INFO ] INFINIBAND_INTEL_NBC_TESTNAMES=all injected to case VERIFY-INFINIBAND-INTEL-MPI-2VM-STANDARD-A8
02-15-2019 19:29:18 : [INFO ] INFINIBAND_INTEL_NBC_TEST_COUNT=1 injected to case VERIFY-INFINIBAND-INTEL-MPI-2VM-STANDARD-A8
02-15-2019 19:29:18 : [INFO ] Starting the test

@juhlee-microsoft @lizzha please check and merge.

@iamshital, please post the test result how it works.

Hi Ju,
Our replaceable parameters have three formats in test case definition
1. <ParameterName>REPLACEABLE_PARAMETER1</ParameterName>
2. <param>ParameterName=REPLACEABLE_PARAMETER2</param>
2. <param>ParameterName="REPLACEABLE_PARAMETER3"</param>
So, I just added checking with one prefix and one suffix character around REPLACEABLE_PARAMETER.
This ensured that, only parameters (with exact string match) will be replaced.

This looks good, you will need to update document about this parameter with example.

@iamshital any update for document?

@juhlee-microsoft will update the document today.

This looks good, you will need to update document about this parameter with example.

@iamshital any update for document?

Done

source: gharchive/pull-request

authors: chvalean iamshital juhlee-microsoft


text:
Storage logical sector

add one case about checking the logical and physical sector size for disk with 512 sector size

@Jingli1985 please re-submit this one based on the new storage tests params and I'll accept this PR.
Thank you!

repo: LIS/lis-test


text:
Pass in statement from authCallbackParams to signSessionKey

What
This PR:

Fixes SDK bug where the SIWE statement is malformed, thus causing server-side verification of the SIWE message to fail.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

authors: CLAassistant hwrdtm

repo: LIT-Protocol/js-sdk


text:
field_matrix does not use colors of the block containing it

Expected Behavior
field_matrix should follow the colors of the block containing it.
Actual Behavior
It keeps its own greenish color:

I've tried to solve the issue in the PR that references this issue, but my solution feels like a hack. Because the parentBlock property isn't set on field_matix's sourceBlock_ when the affected functions are initially called I've added guards to protect against 'undefined'. This solves the issue, but feels wrong.
In contrast field_angle also references sourceBlock_.parentBlock_ but does not need the guards against parentBlock being undefined. I'm guessing that is because it only references sourceBlock_.parentBlock_ in showEditor_ which is called at a later stage than init and setValue where field_matrix sets its colors.
So perhaps the issue is that setParent should be called earlier? But that change seems like it would be above my paygrade :)
Steps to Reproduce
Add a block containing a field_matrix to an extension and the the extensions colors.
Something along the lines of:
getInfo: function () {
        return {
            blocks: [
                {
                    arguments: {
                        MATRIX: {
                            defaultValue: '0101011111111110111000100',
                            type: 'matrix'
                        }
                    },
                    blockType: 'command',
                    opcode: 'show',
                    text: 'Show [MATRIX]'
                }
            ],
            colour: '#3D7DD9',
            colourSecondary: '#0D4E8E',
            colourTertiary: '#033D6C',
            id: 'myMatixTest',
            name: 'Matrix test',
            targetTypes: ['hub']
        };
    }

Operating System and Browser
Mac OS 10.13.6 (17G65) Chrome Version 70.0.3538.77 (Official Build) (64-bit)

I took a look at #1764 and see what you mean :-/ . We aggressively call updateMatrix_ in places where I didn't think we would need to. I tried removing them and, sure enough, we do not render things quite right... I'm going to ask @ericrosenbaum if he has any thoughts since (I think) he implemented this field.

Ahah. I think I understand - we do want to update the view in many of these cases (i.e. call updateMatrix_) but not every time we update the model (i.e. call setValue).  setValue will get called when the block is being constructed from XML and not everything needed to update the view will exist by then.
This seems to work for me: https://github.com/picklesrus/scratch-blocks/commit/b91fcfc642f514eafb903cebb06dc4c34f220545
Thoughts?

Way more elegant!
Looks like a call to setShadowColour is needed somewhere to give the shadow block (is that the correct term?) the correct color.

Or is that supposed to happen by some other means?

Interesting - I did that part by putting the field inside a different shadow. In other words, I defined a new "matrix" block and set the colors differently... But maybe that doesn't work when constructing this through an extension?

Yeah, looks like you don't need that call if you do something like:
Blockly.Blocks['matrix'] = {
  /**
   * Block for matrix value.
   * @this Blockly.Block
   */
  init: function() {
    this.jsonInit({
      "message0": "%1",
      "args0": [
        {
          "type": "field_matrix",
          "name": "MATRIX"
        }
      ],
      "outputShape": Blockly.OUTPUT_SHAPE_ROUND,
      "output": "Number",
      "extensions": ["colours_pen"]
    });
  }
};

But if you do something like:
const extension = {
    getInfo: function () {
        return {
            blocks: [
                {
                    arguments: {
                        MATRIX: {
                            defaultValue: '0101011111111110111000100', // Heart
                            type: 'matrix'
                        }
                    },
                    blockType: 'command',
                    filter: [],
                    opcode: 'show',
                    text: 'Show [MATRIX]'
                }
            ],
            colour: '#3D7DD9',
            colourSecondary: '#0D4E8E',
            colourTertiary: '#033D6C',
            id: 'myMatixTest',
            name: 'Matrix test',
            targetTypes: []
        };
    },
    show: function (){

    }
};
defaultVM.extensionManager._registerInternalExtension(extension);``` it does seem like you need it (I should not be using `_registerInternalExtension`).

For dropdown menus I think the `vm` takes care of it in `runtime._buildMenuForScratchBlocks` colors are set from the `catagoryInfo` object.

That makes sense.  Yes, I think you're right about the vm during the conversion to scratch blocks.  I think we're going to need something similar to the menu building code you referenced for shadows in extensions.  I'm curious to get @cwillisf 's opinion on this though.
@cwillisf:  When making extension blocks that have shadows, (e.g. the shadow that contains the matrix field for the microbit extension), should we be generating the shadow's definition in the vm (right now I think we just get it from the blocks) so we can set the color appropriately?  Let me know if you need more context - not sure how easy this thread is to follow if you haven't had your head in it already :)

authors: ErikMejerHansen picklesrus

repo: LLK/scratch-blocks


text:
Evol/psr4

Passe de PSR-0 à PSR-4

Plusieurs problèmes dans les tests unitaires :

code déprécié dans PHPUnit 10: cf https://github.com/sebastianbergmann/phpunit/issues/4297
utilisation de chaines de caractères pour les noms de classe au lieu d'utiliser ::class
utilisation de array() au lieu de la syntaxe courte [ ] => préférence personnel
utilisation de ->will($this->returnValue(...)) au lieu de willReturrn(...);

A corriger dans cette PR ?

@MadCat34 Merci.  Je regarde le tout.
Thanks for the PR. I will take a look at it.  I suggest that your write your comments in English.  I am fluent in French but we are both part of a minority of people that can use French.  Actually I assume that @matwright can also speak French...  😄

repo: LM-Commons/LmcUser


text:
Failed to open zap on Ubuntu 18.04 (/opt/zap not found)

Installing zap w/ Zap-linux-amd64-v0.5.1-beta.deb on Ubuntu 18.04.2 LTS. Deb is loaded/installed through Ubuntu Software.
When I try to open the application using search, I get the error Failed to open zap /opt/zap not found which makes sense because the app is actually at /opt/Zap on the system.

Thanks for the report @dannypaz . We will however be dropping support for the .deb build. Moving forwards, please use the AppImage instead.

authors: dannypaz mrfelton

repo: LN-Zap/zap-desktop


text:
Segment fault

Hello, i try to generate the Verilog netlists and testbenches with the command "python3 openfpga_flow/scripts/run_fpga_task.py openfpga_shell/configuration_chain" you have given on the toturial.
But the application is crash because of a memory-access-error (core dumped) --> abgebrochen(Speicherabzug abgeschrieben)

Hello,
In my view, this is mainly due to the out-of-date path to the task file.
Recently, the configuration_chain has been moved to openfpga_shell/full_testbench/configuration_chain.
But the paths in the tutorial has not been updated.
Meanwhile we are patching the tutorial, can you try
python3 openfpga_flow/scripts/run_fpga_task.py openfpga_shell/full_testbench/configuration_chain?

Hello,
i don't think it's due to the path.  Actually i forgot to tell you that i already changed the commend with the correct path and receive this result, otherwise the file can't be found if i give the wrong path.

Hello,
No worries. This test case is in our CI which is tested on each commit.
If it fails on a local machine, it is usually a matter of setup issue.
Would you mind sharing the `and2_run.openfpga` in your first screenshot?
This will helps me reproduce the bug.

hello,
i just ran the script with the new command
cd ${TRAVIS_BUILD_DIR}
python3 /home/ukmsm/Schreibtisch/OpenFPGA/openfpga_flow/scripts/run_fpga_task.py openfpga_shell/full_testbench/configuration_chain --debug --show_thread_logs
But i don't think the problem is solved.

Hello,
Can you provide more details so that we can reproduce your problem?
For example:

How did you compile OpenFPGA?
Which branch and which commit did you checkout?
What is the OS and what compilers you were using?

Hello,

I compiled the OpenFPGA with the following commends :
git clone https://github.com/LNIS-Projects/OpenFPGA.git
cd OpenFPGA
mkdir build
cd build
cmake ..  -DCMAKE_BUILD_TYPE=debug
make
if i run the script manually, it says Assertion "!empty()" failed, core dumped as the first screenshot shows.
if i run the script with the Commend ：
python3 /home/ukmsm/Schreibtisch/OpenFPGA/openfpga_flow/scripts/run_fpga_task.py    openfpga_shell/full_testbench/configuration_chain --debug --show_thread_logs. it says:

*subprocess.CalledProcessError: Command '['/home/ukmsm/Schreibtisch/OpenFPGA/openfpga/openfpga', '-f', 'and2_run.openfpga']' died with <Signals.SIGABRT: 6>
*File "/home/ukmsm/Schreibtisch/OpenFPGA/openfpga_flow/scripts/run_fpga_task.py", line 425, in run_single_script
raise subprocess.CalledProcessError(0, " ".join(command))
*subprocess.CalledProcessError: Command [...] returned non-zero exit status 0
(As the third and fourth Screenshot shows)
*The system is Centos 8

Hello,
That may explain the problem. We are testing continuously on Ubuntu and Centos 7.
We have not tried Centos 8 yet.
Can you share your and2_run.openfpga file? I would like see if there is anything that causes the seg fault.

Hello,
yes for sure
and2_run.openfpga.log

Hello,
The file seems to be ok. Can you run valgrind openfpga -f and2_run.openfpga to trace the segment fault?
I will see where the bug comes from.

Hello,
i have run it with the GDB and Valgrind. The first Screenshot is the result from GDB, and the rest is from Valgrind. im truly sorry, i don't know how to output the errors and save it as a log file.
My tutor has also run it with the GDB and has some ideas. For example: Error in libopenfpga/libopenfpgashell/src/shell.tpp, in line 300:
if ('#' == line.front()) {
#we need to test before, if the string is empty : if (line.empty() || '#' == line.front()) {
This could be a solution:
diff --git a/libopenfpga/libopenfpgashell/src/shell.tpp b/libopenfpga/libopenfpgashell/src/shell.tpp
index b5c506d4..47476ab6 100644
--- a/libopenfpga/libopenfpgashell/src/shell.tpp
+++ b/libopenfpga/libopenfpgashell/src/shell.tpp
@@ -297,7 +297,7 @@ void Shell::run_script_mode(const char* script_file_name, T& context) {
/* Read line by line /
while (getline(fp, line)) {
/ If the line that starts with '#', it is commented, we can skip */

if ('#' == line.front()) {

if (line.empty() || '#' == line.front()) {
continue;
}
/* Try to split the line with '#', the string before '#' is the read command we want */
diff --git a/libopenfpga/libopenfpgautil/src/openfpga_digest.cpp b/libopenfpga/libopenfpgautil/src/openfpga_digest.cpp
index 00cbbe1e..f8eb3625 100644
--- a/libopenfpga/libopenfpgautil/src/openfpga_digest.cpp
+++ b/libopenfpga/libopenfpgautil/src/openfpga_digest.cpp
@@ -62,7 +62,7 @@ std::string format_dir_path(const std::string& dir_path_to_format) {
std::replace(formatted_dir_path.begin(), formatted_dir_path.end(), illegal_back_slash, legal_back_slash);

/* Add a back slash the string is not ended like this! */

if (legal_back_slash != formatted_dir_path.back()) {

if (formatted_dir_path.empty() || legal_back_slash != formatted_dir_path.back()) {
formatted_dir_path.push_back(legal_back_slash);
}

Hello,
Thanks for the inputs. Now we know the sources of the bug.
I have patched on the master branch by following your suggestions.
Please try it and see if it solves the problem.
I also encourage you to create pull requests which can resolve the compatibility on different OS.

Hello,
really thank you for your help. After this change, the application is not crash any more. I think we have dealt with the issue we talked before.
But there's new problem coming out. In the 00_and2/MIN_ROUTE_CHAN_WIDTH_out.log, it says: failed to execute iverilog_verification because of no such directory : iverilog.  And another error --> AttributeError: 'FileNotFoundError' object has no attribute 'output'
And i don't understand, in the openfpgashell.log, it says , the execution is successful finished.
00_and2_MIN_ROUTE_CHAN_WIDTH_out.log
openfpgashell.log
and2_run.openfpga.log

Ah thank you , i just find the Verilog verification is the next step . Maybe i can run modelsim instead. And thank you again for solving the problem for me.

Hello,
really thank you for your help. After this change, the application is not crash any more. I think we have dealt with the issue we talked before.
But there's new problem coming out. In the 00_and2/MIN_ROUTE_CHAN_WIDTH_out.log, it says: failed to execute iverilog_verification because of no such directory : iverilog. And another error --> AttributeError: 'FileNotFoundError' object has no attribute 'output'
And i don't understand, in the openfpgashell.log, it says , the execution is successful finished.
00_and2_MIN_ROUTE_CHAN_WIDTH_out.log
openfpgashell.log
and2_run.openfpga.log

Hello,
Please make sure you have iVerilog correctly installed. You can find all the dependency required here

authors: buddynohair tangxifan

repo: LNIS-Projects/OpenFPGA


text:
resizable window LWJGL

Question
how do I make the window resizable?
(as in I can change the size of the window and the render updates scale of the render, to match the size)

LWJGL 3 offers a GLFW Wrapper for window management. For resizable windows, enable the GLFW hint using:
glfwWindowHint(GLFW_RESIZABLE, GLFW_TRUE);

To set up a resize callback, use:
glfwSetWindowSizeCallback(window, window_size_callback);

You can find more details on window management in GLFW here

The GLFW demos can also be used as a reference when getting started.

authors: Snowiiii TheMrMilchmann TheoW03


text:
We need more precise wording for the qualification

The Qualification wording is imprecise. Some people have completed a PhD, some don't. If I tick PostDoc on the registration, and they look for a PhD, they won't find me, which is bad, because I should be able to do the same work, I'm just not a PhD student any more.
We could state the level as: Tick all the steps you went through, or are currently in?
I'm not sure how to solve this, but we should discuss this again. Maybe I find the time to look at other places, where sth similar is requested.

Well we could leave postdoc out and say tick your highest degree? Then that would mean ticking MSc means you finished a master and if you tick PhD you finished the PhD?

Yes, but Group leader isn't a degree. We could add Professor though.
And also MTLA should be MTA/MTLA (a question today, and makes sense to me).
Doktorrand:in ist auch kein Grad, aber eine wichtige Stufe.
Letztendlch brauchen wir eben die Abfrage nach "wie vielen Jahren Laborerfahrung" wohl doch.
@frwms Wie bekommen wir die Leute dazu, möglichst immer alle Boxen zu ticken, die zutreffend sind?

Auf lange Sicht, oder in "Profil vervollständigen" evtl auch hinter der Stufe noch ein Freitextfeld/Dropdownbox für/mit Studienrichtungen.

issue #184 would close this @Kavakuo

repo: LabHive/LabHive


text:
数据库文件在哪下载？

数据库文件在哪下载？

数据来自于yelp官网，可自行前往https://www.yelp.com/dataset下载。

authors: Labhahaha electronic-pig

repo: Labhahaha/Yelp-Analysis-and-Reco


text:
[bug] When I enter Arabic sources, the novels do not appear to me

Both providers added anti scraping

authors: LagradOst xkingxn

repo: LagradOst/QuickNovel


text:
Version Numbers

Need something to handle new version numbers in MonsterDocs so we can minimally have a dev copy and an official copy.  The production copy should not have very many (if any) TODO pages visible... notionally, we could have version numbers for seasons...
2024.0
2024.1
2024.2
2025.0
etc...
Any other suggestions are appreciated.  Likely use semantic labeling, but due to the nature of documentation... likely do not need to have a "bug fix" third number as in 2024.1.3 which may also be confusing with respect to yyyy-m-d.

@SahanRULES , @venomboss985 , please figure out version numbers as well... not quite sure, but either figuring out version numbers or publishing to dev or other branches will be very beneficial for development so we don't need to preview on main.  We could also end up with various versions of our docs by year.... to keep track of how the docs develop over time.


text:
trapping water problem added with updated ReadMe file

Related Issue

Mention issue for which this pull request is a part of (please mention issue number # )
Trapping Water with optimized solution(#110)

Proposed Changes

Change 1
Added Trapping Water Problem with Optimized solution.
Change 2
Updated ReadMe file accordingly.

Additional Info

Any additional information or context

Checklist

[x] ✅ My code follows the code style of this project.
[ ] 📝 My change requires a change to the documentation.
[ ] 🎀 I have updated the documentation accordingly.
[x] 👀 I have read the CONTRIBUTING document.
[ ] ✨ I have added tests to cover my changes.
[ ] 🚩 All new and existing tests passed.
[ ] 🌟 ed the repo

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Output Screenshots

Screenshot #1
Screenshot #2

Title goes here
Title goes here

Image goes here
Image goes here

Please complete the cheklist

Read contributing steps before creating Pr https://github.com/Lakhankumawat/LearnCPP#read-the-following-steps-before-contributing

Completed the checklist as well added the content to the readMe file.

authors: Lakhankumawat shubhamlakheraa

repo: Lakhankumawat/LearnCPP


text:
Add Searching Algorithms

Add Linear Search
Add Ternary Search

Add my name and fixed typos in contributors.md


text:
fix(antd theme)

Description
Fixed issue where theme overrides were not working
Type

[x] This is a bugfix.
[ ] This is a new feature.
[ ] This is part of a feature.

Organization

[x] Have you linked this pull request to a Trello card?
[x] Have you named the branch in the format of feature/describe_feature_or_change OR bug/describe_bug_this_is_fixing

Review

[ ] Is this a work in progress?
[x] Is this ready to be reviewed?
[x] Have you added two reviewers to this pull request?

 Bug: fix ant design theme overrides not working

 Bug: fix ant design theme overrides not working


text:
coyote.html is just a template file

running a test works but the html generated is just the template, json output is fine though.

I created a pull request #4 to solve this.

Any news?

@JGalego The generated files work :) if you serve them via a web-server look into #4 that explains how you can do that

authors: Antwnis JGalego aahmed-se unfw

repo: Landoop/coyote


text:
发布1.0.1 /1.1.0版本

[ ] 可以考虑发布一个Github Release，因为已经有很多新功能合入了。
[ ] 需要修改plugin.cfg的版本号
[ ] Godot Asset Library那边是不是也得操作一下。发布新版本？

可以，不过我已经睡了😂，要不你帮忙发布一个新的版本，或者我明天发

可以，不过我已经睡了😂，要不你帮忙发布一个新的版本，或者我明天发

我没有对这个仓库的写权限没法发2333。不过也不急啦，有空再弄。晚安🌙

完成


text:
[Bug] With editable-columns got javascript error: registerMinorEditInputEvents is not defined

Bug report
What I did
I upgraded from BP 4.1 to BP 4.1 + PRO and editable-columns
What I expected to happen
When clicking a text column editable field (on focus), no javascript error should be raised, and after editing the field should ba saved.
What happened
When entering the field (on focus) I got the following javascript error:
Uncaught ReferenceError: registerMinorEditInputEvents is not defined at HTMLInputElement.onfocus (room_area:1:1)
What I've already tried to fix it
Checked existing github issues, and monster template code.
Is it a bug in the latest version of Backpack?
Yes.
After I run composer update backpack/crud the bug... is it still there?
Yes.
backpack/editable-columns: * 2.1.1
backpack/pro:  * 1.4.0
backpack/crud: * 5.4.10
Backpack, Laravel, PHP, DB version
When I run php artisan backpack:version the output is:
PHP VERSION:
PHP 8.1.11 (cli) (built: Sep 29 2022 18:29:40) (NTS)
Copyright (c) The PHP Group
Zend Engine v4.1.11, Copyright (c) Zend Technologies
with Zend OPcache v8.1.11, Copyright (c), by Zend Technologies
with Xdebug v3.1.2, Copyright (c) 2002-2021, by Derick Rethans
LARAVEL VERSION:
v8.83.26@7411d9fa71c1b0fd73a33e225f14512b74e6c81e
BACKPACK VERSION:
5.4.10@050b288caf2f60c79313f2b0b7d4fefd25177f3f
Thank you for your support.

My bad (kind of)
I didn't updated my backpack::blank layout. (It was overwritten in resources\views\vendor\backpack\base)
It's in the doc but not in the Upgrade Guide, see in https://backpackforlaravel.com/docs/5.x/base-widgets#requirements-1

@jrbecart Having the same problem here. Can you tell me what exactly did you change/added in order to make it work?

I just solved it also, the thing was that i needed to copy the blank.blade.php file from the repo into mine overwritten file.

authors: JordanchoEftimov jrbecart

repo: Laravel-Backpack/CRUD


text:
Fix for multiple word crud command

Until now doing something like;
php artisan backpack:crud ...
product_category renders Route::crud('product_category', 'Product_categoryCrudController');
product-category renders Route::crud('product-category', 'Product-categoryCrudController');
productCategory renders Route::crud('productcategory', 'ProductCategoryCrudController');
Also, the controller entity names were wrong.
CRUD::setEntityNameStrings('productcategory', 'product_categories');

This PR allows devs to use any format, either kebab-case, snake_case or Title Case.
php artisan backpack:crud ...
product_category, product-category, productCategory
It will always render what is expected.
routes/custom.php
Route::crud('product-category', 'ProductCategoryCrudController');

sidebar_content.blade.php

     Product Categories

ProductCategoryCrudController.php
public function setup()
{
    CRUD::setModel(\App\Models\ProductCategory::class);
    CRUD::setRoute(config('backpack.base.route_prefix') . '/product-category');
    CRUD::setEntityNameStrings('Product Category', 'Product Categories');
}

I LOVE THIS. Thanks @promatik !

@tabacitu it's fixed 🙌

ping @tabacitu

Tested, works great! Thanks @promatik !

Tagged as 3.1.9 - https://github.com/Laravel-Backpack/Generators/releases/tag/v3.1.9

authors: promatik pxpm tabacitu

repo: Laravel-Backpack/Generators


text:
Dogfood allow-scripts workflow here

Pending review of allow-scripts

TypeError [ERR_INVALID_URL]: Invalid URL: undefined
    at onParseError (internal/url.js:259:9)
    at new URL (internal/url.js:335:5)
    at getCanonicalNameInfo (/Users/Etienne/Desktop/lavamoat-stuff/lavamoat/packages/node/test/projects/2/node_modules/@lavamoat/allow-scripts/src/index.js:258:15)
    at getCanonicalNameInfoForTreeNode (/Users/Etienne/Desktop/lavamoat-stuff/lavamoat/packages/node/test/projects/2/node_modules/@lavamoat/allow-scripts/src/index.js:443:12)
    at loadAllPackageConfigurations (/Users/Etienne/Desktop/lavamoat-stuff/lavamoat/packages/node/test/projects/2/node_modules/@lavamoat/allow-scripts/src/index.js:452:42)
    at async setDefaultConfiguration (/Users/Etienne/Desktop/lavamoat-stuff/lavamoat/packages/node/test/projects/2/node_modules/@lavamoat/allow-scripts/src/index.js:159:7)
    at async start (/Users/Etienne/Desktop/lavamoat-stuff/lavamoat/packages/node/test/projects/2/node_modules/@lavamoat/allow-scripts/src/cli.js:26:7) {
  input: 'undefined',
  code: 'ERR_INVALID_URL'
}

this is likely broken due to a lack of workspaces support. that should be resolved by https://github.com/LavaMoat/LavaMoat/pull/184 and then we can revisit this work

blocked by https://github.com/LavaMoat/LavaMoat/pull/184

authors: EtDu kumavis

repo: LavaMoat/LavaMoat


text:
Link MiXplorer icon to “com.mixplorer” package

MiXplorer v6.57.1-API26-RC from Xda has “com.mixplorer” package name

Thanks for contributing, @Sad-Soul-Eater!

authors: Sad-Soul-Eater patrykmichalik

repo: LawnchairLauncher/lawnicons


text:
Add icon for Bluetooth Serial Terminal

Summary
This is some generic "bluetooth communication"-icon. Maybe there are other apps that could use this?
Type of change

:x: Bug fix (non-breaking change which fixes an issue)
:white_check_mark: Icon addition (non-breaking change that adds/modifies Lawnicons's icons)
:x: General change (non-breaking change that doesn't fit the above categories like copyediting)

Icons addition information

Icons added

App Name (de.kai_morich.serial_bluetooth_terminal)

Icons linked

App Name (linked de.kai_morich.serial_bluetooth_terminal to @drawable/serial_bluetooth_terminal)

@Sir-Photch you can rename the icon to generic_bluetooth

all set!

authors: Chefski Sir-Photch


text:
bug: Hit  on float term has wait time 1 sec to react (depends on timeoutlen)

Did you check docs and existing issues?

[X] I have read all the LazyVim docs
[X] I have searched the existing issues of LazyVim
[X] I have searched the existing issues of plugins related to this issue

Neovim version (nvim -v)
NVIM v0.10.0-dev-616+g203181234
Operating system/version
Arch Linux KDE
Describe the bug
[current]
Peek 2023-07-30 01-41.webm
Steps To Reproduce

open float terminal
Hit
wait 1 sec to react

Expected Behavior
[expected]
Peek 2023-07-30 01-40.webm
Repro
-- DO NOT change the paths and don't remove the colorscheme
local root = vim.fn.fnamemodify("./.repro", ":p")

-- set stdpaths to use .repro
for _, name in ipairs({ "config", "data", "state", "cache" }) do
  vim.env[("XDG_%s_HOME"):format(name:upper())] = root .. "/" .. name
end

-- bootstrap lazy
local lazypath = root .. "/plugins/lazy.nvim"
if not vim.loop.fs_stat(lazypath) then
  vim.fn.system({ "git", "clone", "--filter=blob:none", "https://github.com/folke/lazy.nvim.git", lazypath, })
end
vim.opt.runtimepath:prepend(lazypath)

-- install plugins
local plugins = {
  "folke/tokyonight.nvim",
  "folke/LazyVim",
  -- add any other plugins here
}
require("lazy").setup(plugins, {
  root = root .. "/plugins",
})

vim.cmd.colorscheme("tokyonight")
-- add anything else here

wrong tag, that [current] recording should be [expected] and vise versa

This must be caused because of a terminal keymap you have on leader.
Default LazyVim does not have this issue.
You can debug your own config by checking :tmap <leader>

authors: folke radvil

repo: LazyVim/LazyVim


text:
fix(cmp): don't enable snippets source without nvim-snippets

Make it easier, so if users decide to disable nvim-snippets, they don't have to remove the snippets source manually in their config.

Thanks!


text:
overlay and marker panes not displaying

I have been using Leaflet for a number of years and whilst migrating a website have stumbled across a really weird issue:
The overlay and marker panes do not display. I'm using the latest stable version of Leaflet downloaded today.
If I place a polygon on the map and then do a map.fitbounds(.getBounds) then the map focuses on the right area but the polygon does not display. Similarly, if I place a marker on the map then only the shadow appears. I've examined the elements in the Chrome debugging tools and the layers and markers are present in their respective panes.
I'm using other javascript and css that I have used countless times in other projects and I can't see anything in my css that is interfering with the z-index of the overlay and marker panes although logic dictates that there must be.
Does anyone have any ideas as I am baffled?

Hi,
Can you share a plunker / fiddle that reproduces the issue?

Hi,
Thanks for showing interest. I don't think that would help as the problem must be specific to my installation. The only additional piece of information that I can share is that in the chrome inspector the marker has a size of 0 x 0 pixels. There must be another script or style sheet conflicting with it but it is incredibly difficult to identify what it is without rendering the system unusable.
I suppose I'm hoping that someone else has seen this and identified the issue already.
Cheers.

Here's a screenshot of the elements:

authors: flightsurvey ghybs

repo: Leaflet/Leaflet


text:
FeatureGroup do not propagate "move" event from dragging a Marker

[x] I've looked at the documentation to make sure the behavior is documented and expected
[x] I'm sure this is a Leaflet code issue, not an issue with my own code nor with the framework I'm using (Cordova, Ionic, Angular, React…)
[x] I've searched through the issues to make sure it's not yet reported

Steps to reproduce

Setting a map with a FeatureGroup new L.FeatureGroup
Setting listeners to the feature group   .on('layeradd layerremove move click', someFunction, this)
Adding draggable Markers to the Feature group.
Drag the markers.

Expected behavior
all four (layeradd layerremove move click) subscribed events should fire and run someFunction.
Current behavior
'layeradd' 'layerremove' 'click', fire correctly the function, but 'move' failed to do it.
Environment

Leaflet version: 1.6
Browser (with version): Firefox 71.0 (64-bit)
OS/Platform (with version): Linux ****** 5.3.0-24-generic #26-Ubuntu SMP Thu Nov 14 01:33:18 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Additional context

A workarround is :
      .on('layeradd', function(e) {
        e.layer.on('move', someFunction, this)
      }, this)

Minimal example reproducing the issue
https://plnkr.co/edit/zfa9yCzkm0VVRxDopILj?p=preview

[x] this example is as simple as possible
[x] this example does not rely on any third party code

The fix is easy (see https://github.com/Leaflet/Leaflet/compare/propagate-marker-drag ), but there's a major drawback.
In Leaflet, events which are propagated to the event parent are propagated through the entire event parent chain. So, in your case, the move event would propagate from the Marker to the FeatureGroup and from there to the Map.
And that would conflict with the Map's move event (which triggers when the map's center changes) - a dev would need to either take care to stopPropagation() such events, or check the event's target every time. Idem for dragstart et al.
I've seen the confusion that the propagation of click events from markers to the parent Map has caused since @perliedman implemented that in 1.0.0... and I fear the confusion that propagating move events from markers could cause. Because of that fear, I'll not make a PR from the propagate-marker-drag branch (unless another maintainer thinks it's a good idea). I'd like to close this as "wontfix" for that reason.

@IvanSanchez wait, I did what? Not sure if this is the same thing, but I was myself surprised that it worked this way: https://github.com/Leaflet/Leaflet/pull/5880

Hi @IvanSanchez,
As a dev, I wouldn't ask for an event triggered "in" a FeatureGroup to be propagated outside of it, along the chain to the Map object...
It would make sens that a FeatureGroup handle  the feature (in this case UI behavior)  by it self (with stopPropagation() enabled by default.

the move event would propagate from the Marker to the FeatureGroup and from there to the Map.

In fact it will not propagate out of FeatureGroup, so I suppose that your fix is proper.
(just rebased propagate-marker-drag on current master)

authors: IvanSanchez elmatou johnd0e perliedman


text:
Stop propagation of 'drag' event in Leaflet

Is there a possibility to prevent Leaflet dragstart event from triggering just moment after start dragging a marker.
According to Leaflet documentation all you have to do is:
L.DomEvent.on(div, 'click', function (ev) {
    L.DomEvent.stopPropagation(ev);
});

But this obviously will ONLY work for few particular event (e.g. click, dblclick, mouseup, mousedown) because L.DomEvent.stopPropagation(e) and L.DomEvent.preventDefault(e) are just calling e.stopPropagation() and e.preventDefault() respectively otherwise it will try to access the originalEvent object inside the event.

This is the stopPropagation code in Leaflet 1.7.1:
export function stopPropagation(e) {

	if (e.stopPropagation) {
		e.stopPropagation();
	} else if (e.originalEvent) {  // In case of Leaflet event.
		e.originalEvent._stopped = true;
	} else {
		e.cancelBubble = true;
	}
	skipped(e);

	return this;
}

This is everything i tried until now to prevent the Leaflet dragstart event from being firing but no success:
marker.on("dragstart", function (e) {
	if (logic) {
L.DomEvent.stopPropagation(e);
L.DomEvent.preventDefault(e);
L.DomEvent.stop(e);
stopPropagation(e.originalEvent);
preventDefault(e.originalEvent);
stop(e.originalEvent);
e.originalEvent.stopPropagation();
marker.on("dragstart", L.DomEvent.stopPropagation);
marker.off("dragstart");
marker.bubblingMouseEvents = false;
	}
});

Jsfiddle
https://jsfiddle.net/sgf1uxoL/3/
What we need is really the ability to cancel the dragstart event sometimes depending on a logic that we evaluate in the last moment (when the user is about to start dragging) and NOT MAKING THE MARKER NON DRAGGABLE because this would break our design (completely block user from dragging the markers) therefore we don't and we can't use marker.dragging.disable();

Seen already at https://stackoverflow.com/questions/68956196/stop-propagation-of-drag-event-in-leaflet . Not a Leaflet bug.

authors: IvanSanchez hamzarhaiem


text:
Items should be dropped when structures are deleted

Currently, they're just lost to the void.
Instead, they should scatter into nearby tiles.
Particularly important with seeds!

Additionally, building materials should be refunded too.

repo: Leafwing-Studios/Emergence


text:
Import old code

And clean up the layout as we go.
-- remove personal data
-- RSpec tests

Done.


text:
[Draft - don't merge!] Brainstorm clustering pred invention

Just checking the diff

Closing since new, clean and working PR is on its way!


text:
Make gem5 directory load as a package.

Add an empty init.py file so that python recognizes gem5 as a package. Otherwise it uses a namespace loader which does not provide the __file__ attribute needed by inspect.getfile().
Error produced on python 3.10 without this patch:
In [2]: import simulator
---------------------------------------------------------------------------
TypeError                                 Traceback (most recent call last)
Cell In[2], line 1
----> 1 import simulator

File ~/src/pie/gem5/simulator.py:27
     24 import subprocess
     25 import shlex
---> 27 GEM5_DIR_PATH=os.path.dirname(inspect.getfile(gem5))
     30 DOCKERFILE_TEMPLATE = """
     31 FROM alexshypula/gem5-skylake:api
     32
   (...)
     41
     42 """
     44 import logging

File ~/opt/anaconda3/envs/pie/lib/python3.10/inspect.py:778, in getfile(object)
    776     if getattr(object, '__file__', None):
    777         return object.__file__
--> 778     raise TypeError('{!r} is a built-in module'.format(object))
    779 if isclass(object):
    780     if hasattr(object, '__module__'):

TypeError: <module 'gem5' (<_frozen_importlib_external._NamespaceLoader object at 0x7fce11f49930>)> is a built-in module

Thanks!

authors: AlexShypula ChrisCummins

repo: LearningOpt/pie


text:
Track uncaught errors thrown in the bridge transaction flow

errors that are thrown out of the bridge.prepareTransaction or bridge.getTransactionStatus (not those in status.errors, but actually the THROWN errors) are kinda critical, and at the moment only displayed to the user but not sent yet to sentry errors = it means we don't see them at all. This add this feature.
❓ Context

Impacted projects: ledger-live-common and ledger-live-mobile
Linked resource(s): in order to see errors like TECSUPPORT-1245 on sentry

✅ Checklist

[x] Test coverage: for the first time, we have test coverage on useBridgeTransaction
[x] Atomic delivery
[x] No breaking changes: no impact on LLD because not used yet. on LLM we hook errors to logger.critical

🚀 Expectations to reach
Please make sure you follow these Important Steps.
Pull Requests must pass the CI and be internally validated in order to be merged.

Yeah the context was also my idea but like you said, it feels overkill.

authors: Justkant gre

repo: LedgerHQ/ledger-live


text:
🛑 Retamin1 is down

In b6dc9e6, Retamin1 (https://app1.wisereport.co.kr/Home/ServerCheck) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Retamin1 is back up in e290cad.


text:
Problems signing in to Leetcode US

🐛 Bug Report
I'm not able to sign in to leetcode.com using account and password, it said invalid password, but I'm sure I was using correct username and password.
To Reproduce

Sign in to Leetcode
Select Leetcode Account
Enter username and password

Expected behavior
Sign in to Leetcode without any issue
Extension Output
login: (node:46311) Warning: Accessing non-existent property 'padLevels' of module exports inside circular dependency
(Use `node --trace-warnings ...` to show where the warning was created)
pass: - Signing in leetcode.com
[ERROR] invalid password?

Your Environment

os: macOS 12.6
extension settings: Default settings
nodejs version: v16.17.0
vscode version: v1.71.2
extension version: v0.18.1

Getting same error, any solutions yet?

Same

Same

Same

Same

Same

Same issue

same

repo: LeetCode-OpenSource/vscode-leetcode


text:
Instagram doesn't get called during build?

This may be outside of the scope of this project (and may be an issue with gatsby-source-plugin or just user error :) ).
I have my FB App in development mode, I can build it locally with yarn start and no issue.
If I keep it in development and deploy to netlify, it doesn't get any data from Instagram.
If I flip the switch on the FB app to production I fail to build for both local and netlify.
Any suggestions?

Also to add to this gatsby build && gatsby serve will display instagram correctly locally.

Glad that you could figure it out :)

authors: GarrettJMU LekoArts

repo: LekoArts/gatsby-starter-portfolio-jodie


text:
[DOCS] Minor adjustments

Minor adjustments
Just a routine job, typos and broken links fixes

can you make your branch up to date with main ? thanks

@LelouchFR rebased

authors: LelouchFR eng-gabrielscardoso

repo: LelouchFR/skill-icons


text:
[FEATURE] Dynamic Lookahead Distance

Requested Feature
Dynamic lookahead distance

Lookahead distance scales automatically to better follow the path
Lookahead distance changes while the path is being followed

Current Implementation
Lookahead is static and manually input by the user
Motivation
Pure Pursuit is known to deviate from the path, especially around corners, before converging with it again. A dynamic lookahead distance can reduce this deviation around corners while maintaining speed around straight sections.
Possible Implementation
let:

$l$ represent the lookahead distance
$l_{min}$ represent the minimum lookahead distance
$l_{max}$ represent the maximum lookahead distance
${v_t}$ represent the target velocity

$l = {clamp}(v_t \cdot k_l ,  l_{min} ,  l_{max})$
With this implementation, the lookahead increases at high speeds and decreases at lower speeds, but will not exceed the specified limits. This could be implemented either as a calculation to be performed at runtime

Is the suggestion to modify how interpolation of waypoints on a path happens by also considering the speed of the robot at that line segment? For example, driving slower on a specific segment would decrease LD and therefore add more waypoints?

This issue does not suggest changing the interpolation of the waypoints. The algorithm will just find the lookahead point on the furthest line segment, according to the current implementation

At higher speeds, the look-ahead distance $\ell$ should be greater than it would be at a lower speed so that sharp turns and such may anticipated earlier. This motivates us to make $\ell$ proportional to the target velocity $v$. The target velocity is used due to its stable nature (as opposed to measured velocity). Let target velocity be bounded by $v_{min} \leq v \leq v_{max}$ for all possible paths. Let $\ell_{max}$ be the maximum look-ahead distance. We may set $$\ell = \frac{v}{v_{max}}\ell_{max}$$, which will ensure that $\ell = \ell_{max}$ when $v =v_{max}$ and $\ell = \frac{v_{min}}{v_{max}}\ell_{max} > 0$, when $v = v_{min}$.
I am unsure of whether the look-ahead point should regress if $\ell$ shrinks enough so that distance from the robot's current position $R$ and the old look-ahead point $L_{prev}$ is greater than $\ell$. The dynamic look-ahead distance should be tested with and without this regression.
Possible implementation of look-ahead point regression:
Let:

$W_i$ denote the $i^{\text{th}}$ waypoint from the beginning of the path.
$i_{0}$ be such that $W_{i_0}$ is the closest waypoint to the previous look-ahead point.
$\operatorname{distance}(R, W_{i})$ denote the distance from the robot to $W_i$
$\ell$ be the new look-ahead distance
$E(i_k) = \text{abs}\left(\operatorname{distance}\left(R, W_{i_k}\right) - \ell\right)$ be distance error.
If $E(i_{0}-1) > E(i_0)$, then let $i_{1} = i_{0} - 1$, and more generally, let $i_{k+1} = i_{k}-1$ until $E(i_n) < E(i_{n+1})$. Otherwise, let $i_{k+1} = i_k + 1$ until the same condition occurs. If $\operatorname{distance}(R, W_{i_n}) \leq \ell$ and $\operatorname{distance}(R, W_{i_{n+1}}) \geq \ell$ or vise versa, interpolate between $W_{i_{n}}$ and $W_{i_{n+1}}$ to find the look-ahead point. Otherwise, it will lie between $W_{i_{n-1}}$ and $W_{i_{n}}$.

authors: SGD2718 SizzinSeal Vlarkus

repo: LemLib/LemLib


text:
部分网站乱码

搜狐体系新浪体系阿里体系的很多网站，都是乱码。

请提供一下地址

http://mt.sohu.com

这个CardLink没法解决，因为
默认发送的请求是utf-8编码，而这个网站实际响应的是gbk编码，编码不一致所以导致的乱码


text:
"Radical" thought: "+"

Here's a more radical idea. FDK now also allows + in glyph names. So I recently thought — wouldn’t it be simplest to ditch the AGL names like Aacute and consistently use A+acute? The + could be the replacement of the Unicode character name term WITH. And the non-spacing marks could be renamed +acute, +grave etc. (instead of cmb-*).
Ok, it is a bit radical but... who knows.

WITH is also used in ligatures and double accents.

Hm. :/

authors: LettError twardoch

repo: LettError/glyphNameFormatter


text:
[BUG] Ship Jitter

Describe the bug
Player ship appears to jitter randomly (ie, sway left and right really quickly) ever since the game speed was increased. May be caused by the aiming system being designed for a slower game.
To Reproduce
Play the game, fly around a bit. Sometimes staying still will trigger it. Ship orientation is not smooth.
Expected behavior
Ship orientation should be smooth and consistently pointing at or moving towards the player cursor, without jitter
Additional context
Liam H mentioned this may be caused by the aiming system being physics based.

This was resolved some time ago but the issue wasn't closed correctly.

authors: Liam-Harrison MistaMishMash

repo: Liam-Harrison/Celeritas


text:
[BUG]: Badge is imported from both

问题提交
使用BrnBottomTabBar时遇到以下问题
../../../.pub-cache/hosted/pub.dev/bruno-2.2.0/lib/src/components/tabbar/normal/brn_tab_bar.dart:463:17: Error: 'Badge' is imported from both 'package:badges/src/badge.dart' and 'package:flutter/src/material/badge.dart'.
Badge(
^^^^^

2、复现步骤
  1：实现底部导航
        bottomNavigationBar: BrnBottomTabBar(
          fixedColor: Colors.blue,
          currentIndex: _selectedBarIndex,
          badgeColor: Colors.red,
          items: const <BrnBottomTabBarItem>[
            BrnBottomTabBarItem(
                icon: Icon(Icons.home),
                title: Text("首页1"),
                badgeNo: null,
                activeIcon: Icon(Icons.home_filled)),
            BrnBottomTabBarItem(
                icon: Icon(Icons.home),
                title: Text("首页2"),
                badgeNo: null,
                activeIcon: Icon(Icons.home_filled)),
          ],
        ),
   2：热重载后运行报错 Badge is imported from both

3、期望行为
不报错正常运行
4、运行环境

运行设备
iPhone 14 Pro Max
系统
MacOs 13.0.1 (22A400)
Bruno 版本
Bruno 2.2.0
Flutter Doctor 信息
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel master, 3.7.0-15.0.pre.11, on macOS 13.0.1 22A400 darwin-arm64, locale zh-Hans-CN)
[✓] Android toolchain - develop for Android devices (Android SDK version 33.0.1)
[✓] Xcode - develop for iOS and macOS (Xcode 14.1)
[✓] Chrome - develop for the web
[✓] Android Studio (version 2021.3)
[✓] VS Code (version 1.74.2)
[✓] Connected device (3 available)
[✓] HTTP Host Availability

5、附加信息

包括视频、图片等补充信息

improt 'package:flutter/material.dart' hide  Badge;

improt 'package:flutter/material.dart' hide Badge;

是修改本地的brn_tab_bar.dart吗，在应该不是最好的选择吧？

看问题，跟 material 库里面的 Badge 重复，你如果引入 bruno 的 Badge，可以隐藏 material 库里面的 Badge

BrnBottomTabBar

引入的是bruno 的 BrnBottomTabBar，BrnBottomTabBar 的 brn_tab_bar.dart 里的 Badge 重复报错了 [5、附加信息] 的第一张图是brn_tab_bar.dart的，项目中暂时没使用  bruno 的 Badge

@shi-lai-mu  flutter 在后续版本中 增加了 Badge 组件，目前 Bruno 优先适配 Flutter stable 版本，暂时未适配未发布的版本。
后续适配 flutter 新版本时考虑去除 badge 库依赖，替换为官方组件。
ps. 日常开发推荐使用官方稳定版本～

请问你这个问题解决了吗？ 我现在hide 哪个都没法运行

请问你这个问题解决了吗？ 我现在hide 哪个都没法运行

我切换flutter至稳定版，暂时解决了这个问题

3.3.0 版本已发布解决，带来的不便深感抱歉

authors: leftcoding shi-lai-mu violinday wwg90 zhoujuanjuan

repo: LianjiaTech/bruno


text:
Word wrap for table cells

The table cells in https://libertem.github.io/LiberTEM/sample_datasets.html are currently not wrapping.
This could be an issue with the theme?

This could be an issue with the theme?

This is generally an issue with tables - it's hard to have a working default styling that covers all cases in a sane way. I think we should instead just not use a table. Could a list work better maybe? Similar but simpler than our funding section?
That way, we don't have to fit long dataset names into the horizontal space, while still displaying the other columns...

Could a list work better maybe? Similar but simpler than our funding section?

Sounds good, would also be much easier to edit in the source code. I've made it a "good first issue" now. :-)

repo: LiberTEM/LiberTEM


text:
IPyparallel integration

As a follow-up to #760, we could have a classmethod on the DaskJobExecutor that allows easy creation of a cluster from an ipython parallel cluster. I think this means mostly creating the right resources on the dask workers and running the matching setup code.
cc @jhgee

Update: as long as we don't need GPU support, we don't need to specify resources anymore, since #816 is now merged. What remains is getting https://github.com/ipython/ipyparallel/issues/414 fixed and documenting how to use ipyparallel with LiberTEM.


text:
add how to run benchmarks section to readme

Useful for future dev to understand the steps in the  benchmark process.
Part of #280
❗ Blocked by  this devOps Pivotal Story

@demisx  can you also bring back how to run unit tests section

❓ So, is there any value to the team in capturing these benchmark commands in readme, or should we wait until #280 is finished by devOps and close this PR?

I think it would be good to update it with the information about how to run them from #280 as well as how to run them locally if you want to test things. (For example A/B testing performance of two implementations still works locally because those numbers are relative to each other).

Moved to the wiki.

authors: demisx saraswatpuneet wilwade

repo: LibertyDSNP/frequency


text:
Delete Missing Photos Stuck

🐛 Bug Report

[x] 📁 I've Included a ZIP file containing my librephotos log files
[x] ❌ I have looked for similar issues (including closed ones)
[x] 🎬 (If applicable) I've provided pictures or links to videos that clearly demonstrate the issue

📝 Description of issue:
After correcting the error #768, now it just hangs the process itself.

127.0.0.1 - - [2023-03-06 15:32:25] "POST /build/ HTTP/1.1" 200 142 1.095149
127.0.0.1 - - [2023-03-06 15:32:30] "POST /build/ HTTP/1.1" 200 142 1.066571
127.0.0.1 - - [2023-03-06 15:32:35] "POST /build/ HTTP/1.1" 200 142 1.126486
127.0.0.1 - - [2023-03-06 15:32:40] "POST /build/ HTTP/1.1" 200 142 1.083360
127.0.0.1 - - [2023-03-06 15:32:45] "POST /build/ HTTP/1.1" 200 142 1.064139
127.0.0.1 - - [2023-03-06 15:32:50] "POST /build/ HTTP/1.1" 200 142 1.112556
127.0.0.1 - - [2023-03-06 15:32:54] "POST /build/ HTTP/1.1" 200 142 1.039401
15:32:54 default: Job OK (01cff0b8-7492-4e7d-9221-98b21027e7ee)
15:32:54 Result is kept for 60 seconds
Unauthorized: /api/rqavailable/
Unauthorized: /api/dirtree/
15:39:39 Cleaning registries for queue: default
Unauthorized: /api/rqavailable/
Unauthorized: /api/dirtree/
Unauthorized: /api/jobs/
Unauthorized: /api/dirtree/
Unauthorized: /api/albums/thing/list/
Unauthorized: /api/albums/place/list/
Unauthorized: /api/searchtermexamples/
Unauthorized: /api/albums/user/list/
Unauthorized: /api/persons/
Unauthorized: /api/dirtree/
Unauthorized: /api/rqavailable/
Unauthorized: /api/rqavailable/
Unauthorized: /api/jobs/
Unauthorized: /api/dirtree/
Unauthorized: /api/dirtree/
Unauthorized: /api/rqavailable/
Unauthorized: /api/jobs/
Unauthorized: /api/dirtree/
Unauthorized: /api/dirtree/

🔁 How can we reproduce it:
Click the button to delete missing photos
Please provide additional information:

💻 Operating system: Ubuntu 20.04
⚙ Architecture (x86 or ARM): x86
🔢 Librephotos version: dev
📸 Librephotos installation method (Docker, Kubernetes, .deb, etc.): docker-compose

🐋 If Docker or Kubernets, provide docker-compose image tag: dev

📁 How is you picture library mounted (Local file system (Type), NFS, SMB, etc.): NFS
☁ If you are virtualizing librephotos, Virtualization platform (Proxmox, Xen, HyperV, etc.): Hyper-V

When i do a:
librephotos=# select missing,path from api_file;
 missing |                                                                      path
---------+------------------------------------------------------------------------------------------------------------------------------------------------
 f       | /data/neroData/WhatsApp/Media/Files/2022/05/VID-20220521-WA0051.mp4
 f       | /data/neroData/Camera/2022/05/PXL_20220502_144407450.jpg
 t       | /data/neroData/Google Fotos/Cosas/IMG_20190527_145726.jpg
 f       | /data/neroData/Google/dateless/5c93a0d9327df97fa7efa025dec36d33.jpg
 f       | /data/neroData/Google/2017/IMG_20171122_213209.jpg
 f       | /data/neroData/Google/2017/IMG_20171209_195949-ANIMATION.gif
 f       | /data/neroData/Google/2019/IMG_20190101_000732.jpg
 t       | /data/neroData/Google/2019/IMG-20191103-WA0143.jpeg
 f       | /data/neroData/Cosas/2022/IMG_20190211_103716.jpg
 f       | /data/neroData/Cosas/2022/IMG-20161209-WA0063.jpg
 f       | /data/neroData/Google/2016/20160621_112843.jpg
 f       | /data/neroData/Google/2016/IMG-20161213-WA0041.jpg
 t       | /data/neroData/Google/2015/IMG-20151220-WA0005.jpg
 t       | /data/neroData/Google/2018/IMG_20180122_142133.jpg
 f       | /data/neroData/Google/2018/IMG_20180204_135339.jpg
 t       | /data/neroData/Google/2020/IMG-20200503-WA0032.jpg
 f       | /data/neroData/Google/2020/IMG_20200525_145800.jpg
 t       | /data/neroData/Google/2016/IMG-20161016-WA0012.jpg
 f       | /data/neroData/Google/2016/IMG-20160508-WA0010.jpg
 t       | /data/neroData/Google/2016/IMG-20160710-WA0009.jpeg

It just stalls.

should be fixed now :)

authors: Nerodacles derneuere

repo: LibrePhotos/librephotos


text:
Native FSDP and MixedPrecision inconsistent behaviour

Bug description
When using MixedPrecisionPlugin alongside fsdp (Fairscale), the memory is reduced as expected compared to full precision. However, when using fsdp_native, no memory gain is observed, as if the training is performed in full precision.
Running the code below on 2 RTX 3090, I observe in Full Prec, for both fsdp and fsdp_native a constant memory usage of 5515MiB * 2.
With fsdp and MixedPrecisionPlugin activated, the memory usage is 3457MiB * 2.
With fsdp_native and MixedPrecisionPlugin, the memory usage is 5515MiB * 2 (exactly the same as Full Prec)
This is an issue since fsdp being deprecated in favour of fsdp_native, it will lead to a regression for the maximum batch size for those using Fairscale FSDP up until now.
How to reproduce the bug
from torch import optim, nn, utils, Tensor
from torchvision.datasets import FakeData
from torchvision.transforms import ToTensor
import pytorch_lightning as pl
from pytorch_lightning.plugins.precision import MixedPrecisionPlugin
import timm

model = timm.create_model('resnet18', num_classes=10)

# define the LightningModule
class DummyModel(pl.LightningModule):
    def __init__(self, model, lr):
        super().__init__()
        self.model = model
        self.lr = lr
        self.loss_func = nn.CrossEntropyLoss()

    def training_step(self, batch, batch_idx):
        x, y = batch
        z = self.model(x)
        loss = self.loss_func(z, y)
        self.log("train_loss", loss)
        return loss

    def configure_optimizers(self):
        optimizer = optim.Adam(self.trainer.model.parameters(), lr=self.lr)
        return optimizer

pl_model = DummyModel(model, 1e-6)

dataset = FakeData(size=100000, transform=ToTensor())
train_loader = utils.data.DataLoader(dataset, batch_size=100)

trainer = pl.Trainer(limit_train_batches=1000, max_epochs=100, accelerator='gpu', strategy='fsdp_native', plugins=[MixedPrecisionPlugin(16, device='cuda')])
trainer.fit(model=pl_model, train_dataloaders=train_loader)

Error messages and logs
# Error messages and logs here please

Environment

Current environment
#- Lightning Component (e.g. Trainer, LightningModule, LightningApp, LightningWork, LightningFlow): Trainer, LightningModule
#- PyTorch Lightning Version (e.g., 1.5.0): 1.9.0
#- Lightning App Version (e.g., 0.5.2):
#- PyTorch Version (e.g., 1.10): 1.13.1+cu117
#- Python version (e.g., 3.9): 3.9
#- OS (e.g., Linux): Linux
#- CUDA/cuDNN version: 11.7
#- GPU models and configuration: NVidia GeForce RTX 3080
#- How you installed Lightning(`conda`, `pip`, source): pip
#- Running environment of LightningApp (e.g. local, cloud): local

More info
No response
cc @awaelchli @carmocca

@w2ex This looks like a configuration/validation issue to me. With FSDP, you would need to set the FSDPPrecision plugin, not the regular MixedPrecisionPlugin. We can probably add an error/validation for this.
You should be able to validate this by just setting precision=16 or precision="bf16" in the trainer rather than passing in the plugin object. And then you should see the memory reduction.
trainer = pl.Trainer(limit_train_batches=1000, max_epochs=100, accelerator='gpu', strategy='fsdp_native', precision=16)

If you are interested in the code, here is why you saw this "silent" behavior:
https://github.com/Lightning-AI/lightning/blob/1288e4ccc4baf73d7b25f52a448685ac6c4f592a/src/lightning/pytorch/strategies/fsdp.py#L174-L180

Indeed, this seems to solve the issue ! Sorry for creating the issue, I was not aware of the existence of FSDPMixedPrecisionPlugin.
Thanks for your quick answer.

repo: Lightning-AI/lightning


text:
Incorrect batch dtype at on_train_batch_start/end using 16-mixed / FSDP

Bug description
I have attached a minimal repro below. When using 16-mixed precision and FSDPStrategy, on_train_batch_start and on_train_batch_end receives the batch in low prec torch.float16. A different hook training_step receives the correct torch.float32 as expected.
    assert(batch[0].dtype == torch.float32)
AssertionError

What version are you seeing the problem on?
master
How to reproduce the bug
import torch
import torch.nn as nn
import torch.nn.functional as F
from torch.utils.data import DataLoader

import lightning as L
from lightning.pytorch.strategies import FSDPStrategy
from lightning.pytorch.demos import Transformer, WikiText2

class LanguageModel(L.LightningModule):
    def __init__(self, vocab_size):
        super().__init__()
        self.model = Transformer(  # 1B parameters
            vocab_size=vocab_size,
            nlayers=32,
            nhid=4096,
            ninp=1024,
            nhead=64,
        )

    def on_train_batch_start(self, batch, batch_idx):
        ### ISSUE: this assertion fails, is torch.float16
        assert(batch[0].dtype == torch.float32)
        return

    def training_step(self, batch):
        input, target = batch
        print(input.dtype, target.dtype) # returns torch.float32
        input, target = input.to(torch.int64), target.to(torch.int64)
        output = self.model(input, target)
        loss = F.nll_loss(output, target.view(-1))
        self.log("train_loss", loss, prog_bar=True)
        return loss

    def configure_optimizers(self):
        return torch.optim.Adam(self.parameters(), lr=0.1)

L.seed_everything(42)

# Data
class CustomWikiText2(WikiText2):
    def __getitem__(self, idx):
        l, r = super().__getitem__(idx)
        return l.to(torch.float32), r.to(torch.float32)
dataset = CustomWikiText2()
train_dataloader = DataLoader(dataset)

# Model
model = LanguageModel(vocab_size=dataset.vocab_size)

# Strategy
strategy = FSDPStrategy()

# Trainer
trainer = L.Trainer(accelerator="cuda", devices=1, strategy=strategy, precision='16-mixed')
trainer.fit(model, train_dataloader)
trainer.print(torch.cuda.memory_summary())

Error messages and logs
# Error messages and logs here please

Environment

Current environment
#- Lightning Component (e.g. Trainer, LightningModule, LightningApp, LightningWork, LightningFlow):
#- PyTorch Lightning Version (e.g., 1.5.0): 2.0.9
#- Lightning App Version (e.g., 0.5.2): 2.1.0rc0
#- PyTorch Version (e.g., 2.0): 2.2.0.dev20230921+cu118
#- Python version (e.g., 3.9): 3.10
#- OS (e.g., Linux): Linux
#- CUDA/cuDNN version: 11.8
#- GPU models and configuration: A100
#- How you installed Lightning(`conda`, `pip`, source): pip/venv
#- Running environment of LightningApp (e.g. local, cloud):

More info
No response
cc @awaelchli @carmocca

We have two choices we could make here.

We keep the input conversion in float16 for mixed precision training, but set cast_root_forward_inputs=False (default is True) in https://github.com/Lightning-AI/lightning/blob/f1df76ce840119f7baee702ef2df1373e516f12f/src/lightning/pytorch/plugins/precision/fsdp.py#L113-L117 This will make it so that FSDP won't cast the tensor back to float32 (the weights dtype) when passing it into the training step.

We don't convert the input to float16 for mixed precision training. This way, the dtype will be unchanged and appear as float32 both in the on_train_batch_start hook as well as in training_step / forward.

is consistent with how the non-fsdp amp works in PL, while 2) is consistent with how it is in Fabric. This is rather more like a choice we have to make in terms of what is the convenient default. I could be convinced either way. But we should avoid redundant dtype conversions whenever possible.

@carmocca @justusschock do you have opinions?

Thanks @awaelchli, I'm not too familiar with lightning internals / design philosophy to comment here, but a minor note is that for mixed-precision training, I would still expect to be in full precision at on_train_batch_start and training_step for all logging/training purposes.

while 2) is consistent with how it is in Fabric

If I understood the proposal, 2) advocates that we don't convert. But it seems like Fabric does convert https://github.com/Lightning-AI/lightning/blob/master/src/lightning/fabric/plugins/precision/amp.py#L64-L65. Did you mean the opposite?
I think option 2) is the closest to the standard PyTorch experience, so I would suggest that as I agree with @Sumith1896
But why was this conversion added in the first place? Was there a specific reason? Would the users have to convert themselves then?

There is no right or wrong choice here. I presented two ways to resolve the unexpected difference in dtype between the two hooks and then I asked for opinions before I go and send a PR. That's all.

Did you mean the opposite?

In the text I initially wrote
"Option 1) is consistent with how the non-fsdp amp works in PL, while 2) is consistent with how it is in Fabric." but I had the options switched. I edited the post.

But why was this conversion added in the first place? Was there a specific reason? Would the users have to convert themselves then?

It was in LightningLite first and then it became Fabric. This is really up to the user. A cast would occur sooner or later anyway if the weights have a different dtype.
Please note that this conversion is unique to FSDP as I described above. Tensors passe to the forward get converted. Other wrappers don't do this.

Thank you so much for the fix @awaelchli!

authors: Sumith1896 awaelchli carmocca


text:
Merge lora weights

I have:
LoRA weights stored at "lit_model_lora_finetuned.pth"
Base model stored at "checkpoints/meta-llama/Llama-2-7b-chat-hf"
Could you please help explain how to merge the lora weights with the base model to produce the desired combined model? Thank you very much for your help!

@zl-liu There is currently no such utility. One could be made though, it's relatively easy. You would basically run everything up to this line here: https://github.com/Lightning-AI/lit-gpt/blob/fc4c14d89e62799eeae162548b6aec24f1ab901a/generate/lora.py#L114C1-L114C1
and then torch.save(filepath, model.state_dict()) to save the merged weights.
Here is a sketch:
model = GPT(config)
with lazy_load(checkpoint_path) as checkpoint, lazy_load(lora_path) as lora_checkpoint:
    checkpoint.update(lora_checkpoint.get("model", lora_checkpoint))
    model.load_state_dict(checkpoint)
merge_lora_weights(model)

# drop lora params from checkpoint
state_dict = {k: v for k, v in model.state_dict() if "lora" not in key}
# save the merged checkpoint
torch.save("lora_merged_weights", state_dict)

@awaelchli Thank you! I will try to do it based on your suggestions. If it works I will share the code here.

@zl-liu I actually made this PR to lit-llama awhile ago, I just spotted this repo and will focus on contributing here instead now. You can check it out: https://github.com/Lightning-AI/lit-llama/pull/310

The code was a sketch. You can just add the missing .items() when iterating over the state dict :)

Added in #495

authors: awaelchli carmocca timothylimyl zl-liu

repo: Lightning-AI/lit-gpt


text:
/lit_parrot/model.py:201 in forward

Running:
python generate.py --prompt "Hello, my name is" --checkpoint_dir checkpoints/stabilityai/stablelm-tuned-alpha-3b
/lit_parrot/model.py:201 in forward:
k = cache_k.index_copy(2, input_pos, k)
RuntimeError: index_copy_(): self and source expected to have the same dtype, but got (self) Float and (source) BFloat16

Found a fix for the problem:
After line 196 in lit_parrot/model.py, 196: cache_k, cache_v = kv_cache
add the following two lines:
cache_k = cache_k.type(torch.bfloat16)
cache_v = cache_v.type(torch.bfloat16)
Everything now works!

repo: Lightning-AI/lit-parrot


text:
Revision datamodules...CityscapesDataModule

What does this PR do?

Related to #839

update docstring
add data type color, polygon along with torchvision cityscape
add train extra dataloader for coarse dataset
add color data type test

Before submitting

[x] Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
[x] Did you read the contributor guideline, Pull Request section?
[x] Did you make sure your PR does only one thing, instead of bundling different changes together?
[x] Did you make sure to update the documentation with your changes?
[x] Did you write any new necessary tests? [not needed for typos/docs]
[x] Did you verify new and existing tests pass locally with your changes?
[ ] If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

[x] Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃

Let's bump min Python versiom, pending on #1021

@lijm1358 could you pls check typing? :rabbit:

Any update here?

authors: Borda dgcnz lijm1358

repo: Lightning-Universe/lightning-bolts


text:
Avoid Numpy for transforms

Hi,
Currently my code goes as:
        self.transform = Compose(
            [
                Resize(
                    width=518,
                    height=518,
                    resize_target=False,
                    keep_aspect_ratio=True,
                    ensure_multiple_of=14,
                    resize_method="lower_bound",
                    image_interpolation_method=cv2.INTER_CUBIC,
                ),
                NormalizeImage(mean=[0.485, 0.456, 0.406], std=[0.229, 0.224, 0.225]),
                PrepareForNet(),
            ]
        )

    @torch.inference_mode()
    def processFrame(self, frame):
        try:
            # frame is a torch.uint8 tensor
            frame = (frame / 255.0).numpy()
            frame = self.transform({"image": frame})["image"]

            frame = torch.from_numpy(frame).unsqueeze(0).to(self.device)

            if self.half and self.isCudaAvailable:
                frame = frame.half()
            else:
                frame = frame.float()

            depth = self.model(frame)

            depth = F.interpolate(
                depth[None],
                (self.height, self.width),
                mode="bilinear",
                align_corners=False,
            )[0, 0]
            depth = (depth - depth.min()) / (depth.max() - depth.min()) * 255.0

            self.writeBuffer.write(depth)

        except Exception as e:
            logging.exception(f"Something went wrong while processing the frame, {e}")

        finally:
            self.semaphore.release()

Since Compose uses PIL / Numpy under the hood all of the operations are being offhanded to the CPU Instead of being done on the GPU. Would it be possible to keep the input/output as a torch tensor for as long as possible in order to avoid conversions to and from numpy and benefit as much as possible from the GPU's horse power?
Thank you.

Since the self.transform part is just calling those 3 steps: Resize, NormalizeImage and PrepareForNet it's just a matter of re-implementing those steps using torch tensors. The code for each is defined the depth_anything/util/transform.py script, so you can check that for reference of what processing needs to happen.
As the name suggests, the Resize transform is just resizing the input image using cv2.resize. The equivalent operation using torch tensors would be torch.nn.functional.interpolate (or just F.interpolate which is already being used in the code you posted). You'd also have to copy the logic used to set the proper aspect ratio & multiples of 14 that the original resize operation was doing.
The NormalizeImage transform is just a simple shifting/scaling operation, which can be done exactly the same way using torch tensors.
And then finally, the PrepareForNet transform looks like it's just re-arranging the dimensions of the image from HxWxC to CxHxW and then making sure it's a float32 data type. The equivalent re-arranging operation with tensors is permute.

Hi, you're totally right. I am sorry for being naive.
After converting all the nodes to Pytorch equivalents I've noticed a 50% bump in performance for CUDA and a 300% performance bump for TensorRT.
Thanks for the tips.
FWIW and future reference for others, most of the modifications can be seen here

authors: NevermindNilas heyoeyo

repo: LiheYoung/Depth-Anything


text:
🛑 Limbo Yggdrasil Authserver is down

In 5392007, Limbo Yggdrasil Authserver (https://auth.lsmp.site/api/yggdrasil) was down:

HTTP code: 500
Response time: 219 ms

Resolved: Limbo Yggdrasil Authserver is back up in b4c79a8 after 17 hours, 10 minutes.

repo: Limbo-Studios/limbo-status-page


text:
Feat/token tests unit

Summary of the change:
Unit tests for Token Creation

New Autorenew Period Check
Token Creation Rejects Numeric Symbol
Token Creation rejects non-uppercase alphabetical Symbol

The same tests have been added on prechecks as well.

authors: failfmi georgiyazovaliiski

repo: LimeChain/hedera-services


text:
🛑 Towny 1 is down

In 4c95bb9, Towny 1 ($SERVER_1) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Towny 1 is back up in 85cbe73.

repo: LimeNetwork/limestatus


text:
ServiceNotFoundException The service "liform.resolver" has a dependency on a non-existent service "validator.mapping.class_metadata_factory"

Hi,
I want to integrate your bundle into Symfony4 project.
But when I load my application I have this issue :

I already added this line in my bundles.php file for loading your bundle in my kernel app symfony
 Limenius\LiformBundle\LimeniusLiformBundle::class => ['dev' => true, 'test' => true],
perhaps Symfony version dependancy issue ?

Mmmm Sorry this is my first project with Symfony4 and I just see that validator component is now not be included into symfony framework by default (but symfony 2 and 3 yes).
I install this component by : composer require validator
And this error not happen.
Sorry for open issue and thank you for your bundle

repo: Limenius/LiformBundle


text:
噫！微斯人，吾誰與歸？

赞赞赞！

俺也一样

俺也一样

俺也一样

俺也一样

吾无异呼。

俺也一样
@Co2333
俺也一样
（花谱头像，惊了
（（希望我没认错

吾有一数。曰玖柒贰柒肆肆玖陆肆。名曰「扣扣群」。

有官方群吗

骚操作!!哈哈哈哈....

简直牛逼

authors: Afanyiyu Co2333 GFwer JetaimeNotLove masterKPr orange030 rockswang xKHUNx yangtzehina yobdm zuishuailjc

repo: LingDong-/wenyan-lang


text:
LinkDown is not compatible with MacOS

Issue: LinkDown is not compatible with MacOS
I discovered that LinkDown is only compatible with Windows, since in the demo it requires cmd (which is not available on MacOS). I wonder if there will ever be a MacOS version or please be sure to claim in your README file that your product is only available to Windows user. Thank you very much!

HI Zigao!
LinkDown could be compatible with MacOS, however, it's because the commands needed to be sent to the system terminal / cmd is totally different. There is a way to solve it, but I suggest you can just use Downie (Which is what I currently use).
If you really want to use LinkDown on mac, you will have to modify the browser extension to send only URLs instead of commands to the NativeHost, and make two different NativeHosts on Windows and MacOS. Finally, you will need to make a set-up script that installs yt-dlp, you-get and ffmpeg automatically, set up the $PATH, and add nativehost to the place that the browser identifies.
(P.S. I saw the green tie on your GitHub avatar and saw you are also in Shanghai. Are you in YK Pao School? I used to be in YK Pao during Grade 1 to 6)

@ZigaoWang

Hi Thomas!
First of all, thanks for the suggestion! I am currently using Downie 4 for downloading videos. It certainly is a great app!
Yes, I am in YK Pao School and I had heard you from one of my friends, and she said you were skilled at making backend programming stuff (correct me if wrong). Therefore, I went to search you on GitHub and found you! By the way, I'm a frontend developer (which make static HTML websites), so I'm not good that these stuff.
Anyways, keep up the good work! I believe your team LinkScape can achieve something big in the future!
Best Regards,
Zigao Wang

authors: ZigaoWang thomaswcy

repo: LinkScapeOfficial/LinkDown


text:
hybris: use x86-64 for amd64 instead of x86

HYBRIS_LD_LIBRARY_PATH and other vars fail to set properly because it is looking for /system/lib instead of /system/lib64.
This was the root cause of that issue.

Thanks!

repo: Linux-on-droid/libhybris


text:
Измерение SBU

https://www.linuxfromscratch.org/~bdubbs/about.html

я засекал только make
ну и у нас сбу может быть чут другим

Добавить информацию о том, как измерить

https://github.com/Linux4Yourself/Linux4Yourself.Book/pull/490
Сейчас надо? Просто в Milestone поставлено Future...

future значит что к 1.0 необязательно

authors: Linuxoid85 avmaisak makpif


text:
lock with FD 99 instead of 200 for systems with low ulimit -n (#314)

Make brew work on systems with a ulimit -n of 100.

Codecov Report

Merging #316 into master will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #316      +/-   ##
==========================================
+ Coverage   70.58%   70.59%   +0.01%
==========================================
  Files         341      341
  Lines       17698    17698
==========================================
+ Hits        12492    12494       +2
+ Misses       5206     5204       -2

Impacted Files
Coverage Δ

extend/io.rb
100% <0%> (+28.57%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64fb648...266befc. Read the comment docs.

Lock with FD 99 instead of 200 for systems with low ulimit -n.
Fixes Linuxbrew/brew#314

🌟 Thanks for your contribution to Linuxbrew, Purag!

authors: codecov-io purag sjackman

repo: Linuxbrew/brew


text:
neovim fails loading shared library libstdc++.so.6 on centos7

Please follow the general troubleshooting steps first:

[ x] Ran brew update and retried your prior step?
[ x] Ran brew doctor, fixed as many issues as possible and retried your prior step?

Bug report:
Tried to install novim on centos 7, fails. But recently installed successfully on debian 8. Also the lib it complains about is installed in /usr/lib64/libstdc++.so.6:
==> Building third-party dependencies.
==> cmake ../third-party -DUSE_BUNDLED_BUSTED=OFF -DUSE_EXISTING_SRC_DIR=ON -DCM
Last 15 lines from /home/gatis/.cache/Homebrew/Logs/neovim/01.cmake:
cmake
../third-party
-DUSE_BUNDLED_BUSTED=OFF
-DUSE_EXISTING_SRC_DIR=ON
-DCMAKE_C_FLAGS_RELEASE=-DNDEBUG
-DCMAKE_CXX_FLAGS_RELEASE=-DNDEBUG
-DCMAKE_INSTALL_PREFIX=/home/gatis/.linuxbrew/Cellar/neovim/0.1.2
-DCMAKE_BUILD_TYPE=Release
-DCMAKE_FIND_FRAMEWORK=LAST
-DCMAKE_VERBOSE_MAKEFILE=ON
-Wno-dev
-DCMAKE_BUILD_WITH_INSTALL_RPATH=1
-DCMAKE_INSTALL_RPATH_USE_LINK_PATH=1

cmake: error while loading shared libraries: libstdc++.so.6: cannot open shared object file: No such file or directory

https://gist.github.com/anonymous/aa91707471e467dd797e.

brew install gcc may work around this issue.

That worked, but now there is next problem with ncurses
xgettext failed to run correctly: /home/gatis/.linuxbrew/bin/xgettext:
  error while loading shared libraries: libncurses.so.5: cannot open shared
  object file: No such file or directory

I installed brew install ncurses but nothing changed.

gettext was compiled against ncurses 5.9 but ncurses was upgraded to 6.0.
brew reinstall gettext
You may need to reinstall other packages.
brew uses --installed ncurses

Thank you very much, it worked, maybe you can put top 10 fixes in the readme.

Glad to hear it worked. Figuring out how to better handle library upgrades is definitely on my radar.

authors: gacha sjackman

repo: Linuxbrew/linuxbrew


text:
Swift: add linux bottle

[ ] Have you followed the guidelines in our Contributing document?
[ ] Have you checked to ensure there aren't other open Pull Requests for the same update/change?
[ ] Does your submission pass
brew audit --strict <formula> (where <formula> is the name of the formula you're submitting)?
[ ] Have you built your formula locally prior to submission with brew install <formula>?

Did you build this bottle yourself?

Travis CI fails with this error:
CMake Error at cmake/modules/HandleLLVMOptions.cmake:43 (message):
  Host Clang must be able to find libstdc++4.7 or newer!

https://travis-ci.org/Linuxbrew/linuxbrew/builds/121124036#L2420-L2421

LinuxbrewTestBot fails with this error:
/tmp/swift20160406-121547-1qmz309/swift-swift-2.2-RELEASE/utils/build-script: Can't find clang.  Please install clang-3.5 or a later version.

authors: alekseysidorov sjackman


text:
🛑 LYRA is down

In f43db5c, LYRA (https://lyra.flitswallet.app/api) was down:

HTTP code: 502
Response time: 552 ms

Resolved: LYRA is back up in 5b7ba5c.


text:
Network and top accounts table size

Expected behavior
Tables on top accounts and network pages should have same width as other pages
Actual behavior
Tables are non standard with on top accounts and network page
Which version(s) does this affect? (Environment, OS, etc...)
all

fixed

repo: Liskscan/lisk-explorer


text:
请确保您已阅读以上注意事项，并勾选下方的确认框。

[X] 我确定这是一个从未被提出和实现过的功能。
[X] 我已经在 Issue Tracker 中找过我要提出的功能，没有找到相同功能的ISSUE。
[X] 我已知晓并同意，此处仅用于建议新功能。若这个 Issue 是关于其他非主题的问题，则我的 Issue 可能会被无条件自动关闭或/并锁定。
[X] 我已知晓并同意，如果我不按照模板提供的指示进行填写，则我的 Issue 可能会被无条件删除。

需要添加的功能内容
目前QQ9.9.12版本去除了透明效果，能不能出一个插件修改一下侧边栏的显示效果，比如实现侧边栏半透明或者磨砂，透明效果

https://github.com/mo-jinran/More-Materials

https://github.com/mo-jinran/More-Materials

你好我这边亚克力效果确实是有的

但是侧边栏一直有个白底怎么破，设置里面的列表也是一样

repo: LiteLoaderQQNT/LiteLoaderQQNT