text:
I encounter an error when running eas build --platform android --local, but there is no error if it's not a local build.

Build/Submit details page URL
No response
Summary
I encounter an error when running eas build --platform android --local, but there is no error if it's not a local build.
Managed or bare?
bare
Environment
[RUN_EXPO_DOCTOR] Running "expo doctor"
[RUN_EXPO_DOCTOR] Running 10 checks on your project...
[RUN_EXPO_DOCTOR] ✔ Check Expo config for common issues
[RUN_EXPO_DOCTOR] ✔ Check package.json for common issues
[RUN_EXPO_DOCTOR] ✔ Check dependencies for packages that should not be installed directly
[RUN_EXPO_DOCTOR] ✔ Check for common project setup issues
[RUN_EXPO_DOCTOR] ✔ Check npm/ yarn versions
[RUN_EXPO_DOCTOR] ✔ Check for legacy global CLI installed locally
[RUN_EXPO_DOCTOR] ✔ Check that native modules do not use incompatible support packages
[RUN_EXPO_DOCTOR] ✔ Check Expo config (app.json/ app.config.js) schema
[RUN_EXPO_DOCTOR] ✔ Check that packages match versions required by installed Expo SDK
[RUN_EXPO_DOCTOR] ✔ Check that native modules use compatible support package versions for installed Expo SDK
[RUN_EXPO_DOCTOR] Didn't find any issues with the project!
Error output
[PREBUILD] Running "npm install" in /var/folders/yx/ss8k_ymj7z9cxkgk1vdrdmxr0000gn/T/eas-build-local-nodejs/d1396930-e426-4c3b-9feb-e2e54f322e5e/build directory
[PREBUILD] up to date in 3m
[PREPARE_CREDENTIALS] Writing secrets to the project's directory
[PREPARE_CREDENTIALS] Injecting signing config into build.gradle
[RUN_GRADLEW] Running 'gradlew :app:bundleRelease' in /var/folders/yx/ss8k_ymj7z9cxkgk1vdrdmxr0000gn/T/eas-build-local-nodejs/d1396930-e426-4c3b-9feb-e2e54f322e5e/build/android
[RUN_GRADLEW] > Task :gradle-plugin:pluginDescriptors
[RUN_GRADLEW] > Task :gradle-plugin:processResources
[RUN_GRADLEW] > Task :gradle-plugin:compileKotlin
[RUN_GRADLEW] > Task :gradle-plugin:compileJava NO-SOURCE
[RUN_GRADLEW] > Task :gradle-plugin:classes
[RUN_GRADLEW] > Task :gradle-plugin:jar
[RUN_GRADLEW] > Task :gradle-plugin:inspectClassesForKotlinIC
[RUN_GRADLEW] FAILURE: Build completed with 2 failures.
[RUN_GRADLEW] 1: Task failed with an exception.
[RUN_GRADLEW] -----------
[RUN_GRADLEW] * Where:
[RUN_GRADLEW] Script '/private/var/folders/yx/ss8k_ymj7z9cxkgk1vdrdmxr0000gn/T/eas-build-local-nodejs/d1396930-e426-4c3b-9feb-e2e54f322e5e/build/node_modules/expo-modules-autolinking/scripts/android/autolinking_implementation.gradle' line: 356
[RUN_GRADLEW] * What went wrong:
[RUN_GRADLEW] A problem occurred evaluating project ':expo'.
[RUN_GRADLEW] > A problem occurred configuring project ':expo-modules-core'.
[RUN_GRADLEW]    > Failed to notify project evaluation listener.
[RUN_GRADLEW] >
[RUN_GRADLEW] com.android.builder.errors.EvalIssueException: SDK location not found. Define a valid SDK location with an ANDROID_HOME environment variable or by setting the sdk.dir path in your project's local properties file at '/private/var/folders/yx/ss8k_ymj7z9cxkgk1vdrdmxr0000gn/T/eas-build-local-nodejs/d1396930-e426-4c3b-9feb-e2e54f322e5e/build/android/local.properties'.
[RUN_GRADLEW] >
[RUN_GRADLEW] Could not get unknown property 'release' for SoftwareComponentInternal set of type org.gradle.api.internal.component.DefaultSoftwareComponentContainer.
[RUN_GRADLEW] * Try:
[RUN_GRADLEW] > Run with --stacktrace option to get the stack trace.
[RUN_GRADLEW] > Run with --info or --debug option to get more log output.
[RUN_GRADLEW] > Run with --scan to get full insights.
[RUN_GRADLEW] ==============================================================================
[RUN_GRADLEW] 2: Task failed with an exception.
[RUN_GRADLEW] -----------
[RUN_GRADLEW] * What went wrong:
[RUN_GRADLEW] A problem occurred configuring project ':expo'.
[RUN_GRADLEW] > com.android.builder.errors.EvalIssueException: compileSdkVersion is not specified. Please add it to build.gradle
[RUN_GRADLEW] * Try:
[RUN_GRADLEW] > Run with --stacktrace option to get the stack trace.
[RUN_GRADLEW] > Run with --info or --debug option to get more log output.
[RUN_GRADLEW] > Run with --scan to get full insights.
[RUN_GRADLEW] ==============================================================================
[RUN_GRADLEW] * Get more help at https://help.gradle.org
[RUN_GRADLEW] BUILD FAILED in 8s
[RUN_GRADLEW] 5 actionable tasks: 5 executed
[RUN_GRADLEW] Error: Gradle build failed with unknown error. See logs for the "Run gradlew" phase for more information.
Build failed
Gradle build failed with unknown error. See logs for the "Run gradlew" phase for more information.
npx exited with non-zero code: 1
Error: build command failed.
Reproducible demo or steps to reproduce from a blank project
run:
eas build --platform android --local

Hi, it seems like your local setup is broken. Do you have the ANDROID_HOME env var set?

After setting the CMake version to 3.22.1 and configuring the environment variable ANDROID_HOME, everything should be good.

Im getting this error even tho npx expo run:android works fine and is having the corrects env and sdk path...

authors: TomasSestak szdziedzic x007xyz

repo: expo/eas-cli


text:
[eas-cli] Switch to using M1 by default when running build:configure

Checklist

[x] I've added an entry to CHANGELOG.md if necessary. You can comment this pull request with /changelog-entry [breaking-change|new-feature|bug-fix|chore] [message] and CHANGELOG.md will be updated automatically.

Why
For new apps adopting EAS Build, they should be using M1, and this should be explicit until we change the default across the board.
How
Add M1 resource class configuration to eas.json. We should remove this as M1 adoption increases, likely around the SDK 48 release where we hope to make it default.
Test Plan
I ran easd build:configure on a new project

/changelog-entry new-feature Add M1 resource class configuration to default eas.json when running eas build:configure on a new project

Looks good, thanks @brentvatne!

source: gharchive/pull-request

authors: brentvatne dsokal

license: MIT

license_type: permissive

license_source: github-api


text:
Fixed README.md for Hooks

What:
Fixed README.md for Hooks.
Why:
There was no useState in import.
Checklist:

[x] Documentation added/updated
- [x] Typescript definitions updated (N/A)
- [x] Tests added and passing (N/A)
[x] Ready to be merged

review please.

@mrbinky3000 thank you for review. :)

:tada: This PR is included in version 1.27.2 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

repo: express-labs/pure-react-carousel

license: mit

license_source: bigquery


text:
get content-length

I want set content-length to give client, but i can't get size after compression, what should i do?thanks

Because compression modifies the body and changes the size, the content length is removed since it will have the incorrect value after compression.

source: gharchive/issue

authors: dougwilson drdevelop

repo: expressjs/compression


text:
Same File Have different ETag on from different server response with Play 1.2.10,

Hi Team,
I am working on old play 1.2.10 application , where we use activator start/run to launch the web application. I have load balance server as apache and two server instance of application. I want to generate same ETag from both server. Cloud you please help me , where I can find and fix this. I am new to play and we are using java controller.
I tried to disable using  below conf parameter in application.conf, but does not works
Disable the Etag Creation By Play Server
http.useETag=false
I need help to over-ride the Assets functionality using java.
Assets built in Note :Etag support
The Assets controller automatically manages ETag HTTP Headers. The ETag value is generated from the digest (if sbt-digest is being used in the asset pipeline) or otherwise the resource name and the file’s last modification date. If the resource file is embedded into a file, the JAR file’s last modification date is used.
When a web browser makes a request specifying this Etag then the server can respond with 304 NotModified.
Thank you in Advance.

What is Play 1.2.10? I'm not 100% sure what you're asking in relation to Express.js. Are you trying to get your Express.js app to match the same ETag format from Apache or something? Please provide some additional information in what your issue with Express.js is.

Thank you Dougwilson!
Its not related to express. Its Scala Play framework. Where we launch server using activator run command. I commented  here because it same problem, which I have.   here is the play link.
https://github.com/playframework/playframework/issues/3657

Hi @krishtyagi I have never used the Play framework and until now never even heard of it before. Not sure if anyone here would be able to help, though. This is an issue ("bug") tracker for the Express.js project. If you are having an issue with Express.js let us know! If you're asking a general question, you may want to try out a forum like Stackoverflow.

Thank you Dougwilson!

authors: dougwilson krishtyagi

repo: expressjs/express


text:
5.0

Mistake?

authors: Gurshant wesleytodd


text:
Add description to each page (#1639)

Added concise descriptions to each page in the en folder.

We would have to add a description page in other languages, even if it is in English.

before

after

We would have to add a description page in other languages, even if it is in English.

Hi @carlosstenzel , can you please elaborate what you mean by that? Does this mean adding description tag (like I did in the en folder) in all other language folders? @bjohansebas , please let me know your thoughts

before
after

Hi @carlosstenzel , do you want me to remove description tag from /en/blog/posts.md file?

@carlosstenzel For the blog posts, the description was in the original page design but was removed before it was released.
It was originally removed since it did not look good in the posts themselves, so I don't think we'd want to add it to the markup.
Is this only for use in outside sites? That would seem okay, like for SEO, etc?

I looked at the metadata, and I didn't find the description

but when searching on google. I was confused.

** the description tag would be for better SEO

before
after

Hi @carlosstenzel , do you want me to remove description tag from /en/blog/posts.md file?

I added the images just for viewing and analysis by others. tks

We would have to add a description page in other languages, even if it is in English.

Hi @carlosstenzel , can you please elaborate what you mean by that? Does this mean adding description tag (like I did in the en folder) in all other language folders? @bjohansebas , please let me know your thoughts

@rehmansheikh222 please do it, exactly as you said—doing the same in the other folders

We would have to add a description page in other languages, even if it is in English.

Hi @carlosstenzel , can you please elaborate what you mean by that? Does this mean adding description tag (like I did in the en folder) in all other language folders? @bjohansebas , please let me know your thoughts

@rehmansheikh222 please do it, exactly as you said—doing the same in the other folders

Hi @bjohansebas , just one last thing, does the description need to be in english (for other languages folder)?

@rehmansheikh222 Yes, in English

@rehmansheikh222 Yes, in English

@carlosstenzel please check and let me know if there is anything else you would like me to change/add

@rehmansheikh222 Yes, in English

@carlosstenzel please check and let me know if there is anything else you would like me to change/add

I don't think it's ok ;)

@rehmansheikh222 Yes, in English

@carlosstenzel please check and let me know if there is anything else you would like me to change/add

I don't think it's ok ;)

Can you please elaborate?

@rehmansheikh222 Yes, in English

@carlosstenzel please check and let me know if there is anything else you would like me to change/add

I don't think it's ok ;)

Can you please elaborate?

sorry
*** I think it's ok

@rehmansheikh222 Yes, in English

@carlosstenzel please check and let me know if there is anything else you would like me to change/add

I don't think it's ok ;)

Can you please elaborate?

sorry
*** I think it's ok

Oh, okay. So, do you think you can approve the PR now?

@rehmansheikh222 Yes, in English

@carlosstenzel please check and let me know if there is anything else you would like me to change/add

I don't think it's ok ;)

Can you please elaborate?

sorry
*** I think it's ok

Oh, okay. So, do you think you can approve the PR now?

@carlosstenzel it still says one review is required for the merging :)

@bjohansebas  @chrisdel101  @UlisesGascon  could you help?

@rehmansheikh222 thanks

@rehmansheikh222 thanks

I'm glad I could contribute in some way, this was my first issue for open source and I plan to contribute more. Thanks all of you guys, you were really helpful.

@rehmansheikh222 we have a documentation group, maybe you want to join and help us. see #1506

@rehmansheikh222 we have a documentation group, maybe you want to join and help us. see #1506

Yes sure, I will keep an eye on it. Thanks bro


text:
Security Vulnerability in v1.8.0

About the issue
https://nodesecurity.io/advisories/534

The debug version 2.6.9 is not vulnerable.

Looking back at this issue, I realize you said version 1.8.0. Yes, upgrade to version 1.9.0 for the fix. Sorry I read your message as 1.9.0 incorrectly.

repo: expressjs/morgan


text:
Add support in REST handler for HTTP PATCH

Adding PATCH support would allow for a cleaner separation of duties between POST and PUT, allowing the user to update an existing resource using HTTP PATCH, create a new resource using POST, and add or replace a new resource at a specific location using PUT.

The spec talks about partial updates, as opposed to full updates from PUT. I'll let this open for a while to get people's idea on the best ways to implement this.

Yes, exactly.  Most people right now are using POST to do partial updates, but this would just make things cleaner IMO.

I'm with aberman, I think patch would be a welcome addition for doing partial updates to existing resources.

Well this is actually quite a nice idea.
Today we have:

POST when post_is_create returns false which is used to update an existing resource.
POST when post_is_create returns true which is used to create a resource whose identity is unknown by the client.
PUT to overwrite a possibly previously existing resource whose name we know. This is either create or update with the complete resource given in the request body.

But post_is_create is just a special case needed because PATCH doesn't exist (and I guess because browsers don't know anything other than GET and POST for normal requests).
So we could add PATCH to do the same as POST would when post_is_create returns false. Now this would mean that PATCH does the same as process_post, which would end up being quite an awkward name.
Ultimately I think we want to replace process_post with a patch_resource callback (possibly even having different handlers there like for PUT that vary depending on the request content), and have POST either send to the put_resource route or the patch_resource route depending on whether post_is_create returns true. We don't really need a post_is_create since semantically it should always create, but it is a convenience I suppose some people need.
What do you think?

I think post_is_create and process_post should stay the same for people that wish to support clients that do not support PATCH and to keep the REST API backwards compatible. They should not in any way be tied to PATCH.
That said, I think patch should work very much like PUT in that content types are handled differently by different callbacks and of course where the resource exists!
I would like to have function callbacks that look like...
update_from_json
update_from_qs
etc
That would be perfect!

Yeah I suppose for now process_post should stay but I'll mark it as deprecated so we can later move on to a better API (before Cowboy gets to 1.0 preferably). I get that backwards compatible is important but cleanliness is even more so and should be pushed onto people in a few simple steps at a time, while we can.

I agree with you, @essen.  The Webmachine API is not perfect and I'd much rather have a clean, very understandable API than something that just follows an older API for compatibility sake (especially since Cowboy hasn't hit the 1.0 version yet).  I've used Webmachine extensively and I always actually hated the post_is_create function.  The reason is because that function requires that you pass back an id for the new resource since its sole purpose is to just set the Location header.  In every case I've ever dealt with, I never have the id until I actually do the save itself so I just return some random term instead and modify the Location header manually in my process_post.  I've seen many other people do exactly the same thing and so there's clearly an issue with that function.
I like where you're going @essen, but POST on a new resource cannot simply call the PUT functions as it really does need to set the Location header.  Of course it can be set manually, but then you're looking at putting a case statement in the PUT function to test if it's a POST or something to that effect.  If we want to call the PUT functions, we would need to be able to return the new id at the end of the function.  Maybe if you see that an id is returned in the function then you mod the Location header, otherwise you don't?

Well yeah we do set the Location header when post_is_create returns true, after create_path is called. Then and only then it goes on to be like PUT. This is pretty much what Webmachine is doing really.
I feel that we need to write down how Cowboy does things currently (probably in a diagram) and then we can work out how to improve things.

That would be great!  Sorry, in my previous post, I meant that post_is_create forces you to return an id in create_path which is what I don't like.

Yeah I figured. You're right though, there are cases where you can know the ID before, and others where you need to process/save the request body before you do. We should take that into account.

authors: aberman bfrog essen

repo: extend/cowboy

license: ISC


text:
client.query().then is not a function in 0.6.2 version

This code doesn't work in v0.6.2 but works in v0.4.0:
const client = graphql('/api')
client.query(`query { me }`, { var1: '42' }).then(/* ... */ )

It seems like once number of arguments to returning function of GraphQLClient.prototype.createSenderFunction had changed from one to three, it became not working.
I had managed to fix it in three ways:

Add two extra arguments to query

- client.query(`query { me }`, { var1: '42' }).then(/* ... */ )
+ client.query(`query { me }`, '', '', { var1: '42' }).then(/* ... */ )

Remove query type from GraphQL query string

- client.query(`query { me }`, { var1: '42' }).then(/* ... */ )
+ client.query(`{ me }`, { var1: '42' }).then(/* ... */ )

Add caller call to graphql.js itself to behave like 0.4.20 version before changes in GraphQLClient.prototype.createSenderFunction

if (arguments.length > 3) {
    return caller.apply(null, Array.prototype.slice.call(arguments, 3))
}
+if (arguments.length > 1) {
+    return caller.apply(null, Array.prototype.slice.call(arguments, 1))
+}
return caller

@f what is the correct way to fix this problem?

Hi ilyazub,
client.query returns a function, not a promise. Try using this
const client = graphql('/api')

 //see the extra funtion call `()` before `.then`
client.query(`query { me }`)( { var1: '42' }).then(/* ... */ )

or better to read the code
const client = graphql('/api')
const myQuery = client.query(`query { me }`);
myQuery({ var1: '42' }).then(/* ... */ )

Also have a look at the execution demo
See: https://github.com/f/graphql.js#direct-execution-with-run-and-es6-template-tag
I hope that helps

authors: aalibaabaa ilyazub


text:
Correct configuration variable definition (bufsize -> buffsize).

Fixes https://github.com/fHDHR/fHDHR_plugin_origin_ceton/issues/47
Signed-off-by: Nathan Hintz nlhintz@hotmail.com

Sorry if this looks like a bit of a mess; but in the end, it ends up just modifiying the one file.  What looked like an obvious change, wasn't.  If the default value of buffsize is specified as '0' (int), it comes in as 'None" and the conversion to "int" when it is used fails; but if it's specified as "0" (a string), the conversion to "int" is successful.  Maybe someone with more experience w/ Python can figure this out, but this pull request gets things working again.

license: WTFPL


text:
Candle Request Limitation

Apparently the returned candle data from Bitfinex V2 API is limited to a length of 120 candles. This may be a new limitation by Bitfinex. You can test this yourself by simply getting the historical candle data without any Limit Parameter. Limit parameter values bellow 120 seem to work but anything above is ignored.

Issues was generated by a typo on my side. Please apologize.

repo: faberquisque/pyfinex


text:
Class tinyCapsuleNet calls super of CapsuleNet

Hi Fabio, great stuff.
When I init a tinyCapsuleNet I get a type error:
TypeError: super(type, obj): obj must be an instance or subtype of type
because the other class' super is called. Changing it resolves the issue.

Fixed, thank you for spotting it!

authors: Vejni fabio-deep

repo: fabio-deep/Variational-Capsule-Routing


text:
Fabioduque feature/add categories to selected days

I add two props for YearCalendar component.
colorful (Just for YearCalendar)

Boolean
default false

When colorful=true activeDates will sync by array with Object. [{ date: '2019-03-13', className: 'red' }, { date: '2019-03-14', className: 'blue' }]
colorful=true with String. ['2019-01-01', '2019-02-01']
activeClass (send to MonthCalendar)

String
default 'calendar--active'
Use on

    <year-calendar
      v-model="year"
      :activeDates.sync="activeDates"
      ...
      activeClass="custom-day-active-class"
    ></year-calendar>

Then user can use there custom classList.
.custom-day-active-class
  background-color: #0aa
  color: white !important
  &.blue
    background-color: #0000aa
    color: white !important
  &.red
    background-color: #a00
    color: white !important

Do you have any other ideas?

Hi, Fabioduque.
I have remove colorful props and measure activeDates type state.
Maybe I will provide only Object type for activeDates props in version 2.0.0.
Thank you!

repo: fabioduque/vue-material-year-calendar


text:
Uncaught TypeError: $.data is not a function

I'm trying to get the jQuery.i18n code to work with Cash.
To stop it complaining about the references to jQuery I have had to add window.jQuery = cash; but when I try to load the pages it throws the following error:
Uncaught TypeError: $.data is not a function

The error message refers to the following line in the jQuery.i18n code:
i18n = $.data( document, 'i18n' ),

Is there an easy resolution to this or something that I am missing?
-Andy.

This function is not a part of Cash.
You could achieve similar functionality with something like this:
document['i18n'] = something;
i18n = document['i18n'];

This function is not a part of Cash.

Exactly. And this won't be part of Cash because the way it works in jQuery is not compatible with stuff like React.
@sdcsystems you should implement this yourself if you need it. You can find our previous implementation of it by going back enough in git's history, I don't remember exactly when it got removed, that should be mentioned in the changelog.

I have no desire to start going back through git commits and start reimplementing functionality.  If there isn't a simple to use i18n library for Cash then I will just dump it and go back to using jQuery.
-Andy.

Not that I know of.

authors: fabiospampinato ornicar sdcsystems

repo: fabiospampinato/cash


text:
Document the usage of Codecov.io for this repository

We use Codecov.io to track code coverage changes. It would be good to document the usage of Codecov.io in the README.md as well.

Implemented in https://github.com/fabric8-analytics/fabric8-analytics-auth/pull/53


text:
Spinney Loading on Home Page Takes Way Too Long

Thoughts on this?  Should we kill the landing page alltogether and simply start people off on the screen asking them whether they want to launch an "Example" or "Create New Application?"

This is shown when angular is starting, removing the landing page will not improve this. We can have a look at optimizing this though.

Closed because a new react based frontend is now available.

authors: ALRubinger edewit ia3andy


text:
Document the Feature Toggle Solution for external Devs

Document the implemented feature toggle solution and the example so it can be used by other developers. Keep in mind that this might be a platform feature that might be used outside of the Planner component. So keep the documentation encapsulated and put some generic samples on it.

We are tracking this here https://github.com/openshiftio/openshift.io/issues/278
Closing.

authors: joshuawilson michaelkleinhenz


text:
Remove "almighty" appearances from code.

As a followup we have to rename this repo
from https://github.com/almighty-test/almighty-test-unit
to https://github.com/fabric8-test/fabric8-test-unit
or something alike and adapt the places in tests accordingly.

[test]

Why not remove the word from comments as well?

https://github.com/fabric8-services/fabric8-wit/pull/1796/files#diff-acc8d3974d80a8260ecd28803a0b064aR159
https://github.com/fabric8-services/fabric8-wit/pull/1796/files#diff-acc8d3974d80a8260ecd28803a0b064aR171
https://github.com/fabric8-services/fabric8-wit/pull/1796/files#diff-acc8d3974d80a8260ecd28803a0b064aR194

authors: DhritiShikhar kwk


text:
developer builds versus CD builds

so we can easily use branch names to detect feature branches, issues, PRs and whatnot to kick in the CI / PR pipelines. We can treat 'master' as CD or developer builds pretty easily as an OOTB.
However given a repo in github org 'foo' where master is a CD build that generates a new versioned release on each merge.
Now if a user 'james' forks it; what should happen OOTB if there's a merge to the james repo? Feels like a good OOTB would be for it to be a developer build. i.e. the same branch name in a different namespace/organisation may want to disable the CD pipeline behaviour and use the developer pipeline instead.
Similarly if you just import any github repo which has our canonical CI / CD jenkinsfile into a different openshift cluster or namespace we maybe wanna default to 'developer build' (which does a mvn fabric8:deploy along with any CI tests).
i..e whether a branch in a git repo is a CD or developer build may not depend on whats in git; it may be an environmental configuration (something you configure in the namespace).
So I wonder if we should default to developer builds in our pipelines for master or feature branches; then CI builds for PRs / issues (using some well known naming convention).
Then when creating/importing a project a user can opt in to make master the 'CD release'. If they do that then we'd write a ConfigMap value somewhere that the master branch of that git repo was a CD release - if anyone else imports it it'd default to a developer branch?

one alternative to the ConfigMap would be to use the organisation + repo name + branch name to decide if its a CD build versus developer build; so that git lists the canonical organisation + repo + branch name that CD releases come from

Yeah I've been wondering about this too.  As a developer that forks a repo we should probably automate the checking out of a feature or bug branch then that would avoid running a CD pipeline during development.  Although that doesn't protect an accidental release in the users for if they push to master.
So having a check where the pipelines know the release org/repo/branch would be good.

Then folks can use whatever workflow (gitflow etc) they choose

authors: jstrachan rawlingsj


text:
Backup not retained when installing over the top of previous install

Describe the bug
Config.yaml is backed up to installation directory, then the directory is removed.
To Reproduce
Install over the top of previous install
Expected behavior
Backup is retained

Tried this approach, ty to point me out to that newbie error :)

repo: fabriziosalmi/proxmox-vm-autoscale


text:
Fratture request: css loader

Make a custom CSS loader so we can make custom themes that we can easly share with other comunity members (also you could make a category for the chats about your projects on your Ds server)

Added in d552a95

repo: face-hh/fextify


text:
fix: make scrollbar visible in inner page navigation

Motivation
Fixes #1220
I've created a custom scrollbar that appears in the table of contents if there are too many items.
Have you read the Contributing Guidelines on pull requests?
Yes.
Test Plan
Tested across multiple browsers.
There's a little problem. My solution is not working in Firefox or IE/Edge because these browsers do not support custom scrollbars. I could try to implement custom scrollbars using JS but I'm not sure if this is a good idea or not.

@akinariobi
Congrats on merging your first pull request here ! 🎉 How awesome!

Wow! Thank you very much for your feedback.  I'm happy now 😊

authors: akinariobi endiliey

repo: facebook/Docusaurus


text:
fby35: Enable mctp/pldm function via i3c

Summary:

Revise i3c write to use i3c smq device
Enable i3c device in dts
Enable mctp/pldm service

Test plan:

Building pass for fby35, GT and Halfdome
Transfer data from BIC to BMC

Test Log:
root@bmc-oob:~# bic-util slot3 0x18 0x1
00 80 21 09 02 BF 15 A0 00 00 00 00 00 00 00
root@bmc-oob:~# bic-util slot3 0x18 0x4
55 00
root@bmc-oob:~# bic-util slot3 0xe0 0x3 0x15 0xa0 0x0 15 A0 00 7B 12 5E B7 76 9E E2 65 14 00

Hi @garnermic
Thanks for your comments.
Based on your suggestions modify the code, rebase the main, and force update this branch.
Please help review it again, thank you.

authors: DelphineChiu SaraLin-wiwynn

repo: facebook/OpenBIC


text:
Updating generated test vectors

This PR regenerates the test vectors (which were out of date after the latest change to lookup + history proof generation).
Also adds a test which will fail next time if the logic is updated and out-of-sync with the test vectors (prompting the developer to manually re-generate the test vectors) using the command in https://github.com/facebook/akd/blob/main/examples/README.md

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 88.03%. Comparing base (3ce5335) to head (6e45544).
Report is 13 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #448      +/-   ##
==========================================
- Coverage   88.61%   88.03%   -0.59%
==========================================
  Files          39       38       -1
  Lines        9109     8282     -827
==========================================
- Hits         8072     7291     -781
+ Misses       1037      991      -46

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

authors: codecov-commenter kevinlewi

repo: facebook/akd


text:
Add App.module.css instead of App.css on project initialization

The idea behind this change is to show how CSS Modules works in CRA.
In the end a new project shows how to import a regular stylesheet in the index.js and how to import CSS Module.
This change came in my mind after this thread:
https://twitter.com/dan_abramov/status/1195440508681646080?s=20

Hi @esvyridov, I understand the intention here - but we want to keep CRA's base templates very light, and not too confusing for new-starters.

@mrmckeb I see your point. Ok, let me close this PR. Sorry that I didn't create an issue before the PR.

Sorry for being late to the game. I love css modules to make styling scale in big projects. let's demonstrate the power of that in a separate template.

@andriijas Sorry, I think I don't understand what do you mean by "separate template". Do you mean separate template for injecting css, like I did in this PR or separate app template like it was implemented for typescript support?

3.3.0 is shipping soon with template support :)

@andriijas Sorry, I didn't know about that :) I've checked that change and if we want to add a template with css modules we have to add two more templates... for js and ts. Am I right?

authors: andriijas esvyridov mrmckeb

repo: facebook/create-react-app


text:
test: ensure consistent CSS ordering

Motivation
It's easy to modify CSS insertion order by mistake (just changing ES import orders).
Docusaurus should guarantee a stable CSS insertion ordering over time for all the different ways to provide styling.
This test is just a way to ensure we keep the exact same order. We'll fix ordering issues in a separate PR.
See also

https://github.com/facebook/docusaurus/issues/3678
https://github.com/facebook/docusaurus/pull/5987

Have you read the Contributing Guidelines on pull requests?
(Write your answer here.)
Test Plan
test integrated in Netlify deployment (not ideal but seems better than a new GH workflow)

Yes, agree with that, just want a quick way to ensure we don't regress on CSS ordering again as it can be disruptive for users
We'll figure out how to make this better over time

In the future, if we have a docusaurus-tests repo (as I mentioned on Discord), we can move this to a separate E2E test repo

Removed the comments as we don't 100% agree on what is wrong with current CSS ordering
Going to merge now and we'll figure out a better CSS ordering in other PRs

Yes, let's fix the obvious problems first :D

authors: Josh-Cena slorber

repo: facebook/docusaurus


text:
Issue with React Native project

Hello everyone. I'm working on a React Native project and I receive this error every time I (or someone else, like a package in node_modules) import react.
This modules resolves to "<<PROJECT_ROOT>>/../../../node_modules/react/package.json",
which is outside both your root directory and all of the entries in
the [include] section of your .flowconfig.
You should either add this directory to the [include] section of your .flowconfig,
move your .flowconfig file higher in the project directory tree, or move this package
under  your Flow root directory.: /path/to/react/node_modules/react-native/Libraries/ReactIOS/YellowBox.js:263

I honestly don't understand what's going on. Has anyone else this problem?
I searched in the past issues and I only find something related to third party libraries, but never to react itself

@bolismauro I just ran into this myself.
Removing:
# Flow has a built-in definition for the 'react' module which we prefer to use
# over the currently-untyped source
.*/node_modules/react/react.js
.*/node_modules/react/lib/React.js
.*/node_modules/react/lib/ReactDOM.js

from .flowconfig seems to resolve the issue. I'm new to React, React Native, Flow and even Node. So I don't pretend to understand exactly what is going on here 😉

It seems that now those errors are gone. I receive a massive amount of errors from react-native files though.
It is just me?

Hmm, I don't get those. We may be on different versions of something:
Flow, a static type checker for JavaScript, version 0.25.0```

There's actually a 0.26.0 out, needs to be pushed to Homebrew. I'll submit a formula pull request shortly.

Then my `packages.json` has:

"dependencies": {
"react": "^15.0.2",
"react-native": "^0.26.3",
"react-redux": "^4.4.5",
"redux": "^3.5.2"
},
"devDependencies": {
"flow": "^0.2.3",
"flow-bin": "^0.26.0"
}

I just upgraded to the latest flow, 0.26.0. No, I'm still not seeing react-native errors.

I'm using RN 0.25.1 since I can't update it to the 0.26 because of a bug.
It may be that..
I'll wait for RN 0.27

Hey!
Can you please provide your '.flowconfig' ?
React-Native needs quite some configuration to make flow work properly ;-)

Sure,
[ignore]

# We fork some components by platform.
.*/*.web.js
.*/*.android.js

# Some modules have their own node_modules with overlap
.*/node_modules/node-haste/.*

# Ugh
.*/node_modules/babel.*
.*/node_modules/babylon.*
.*/node_modules/invariant.*

# Ignore react and fbjs where there are overlaps, but don't ignore
# anything that react-native relies on
.*/node_modules/fbjs/lib/Map.js
.*/node_modules/fbjs/lib/ErrorUtils.js

# Flow has a built-in definition for the 'react' module which we prefer to use
# over the currently-untyped source
#.*/node_modules/react/react.js
#.*/node_modules/react/lib/React.js
#.*/node_modules/react/lib/ReactDOM.js

.*/__mocks__/.*
.*/__tests__/.*

.*/commoner/test/source/widget/share.js

# Ignore commoner tests
.*/node_modules/commoner/test/.*

# See https://github.com/facebook/flow/issues/442
.*/react-tools/node_modules/commoner/lib/reader.js

# Ignore jest
.*/node_modules/jest-cli/.*

# Ignore Website
.*/website/.*

# Ignore generators
.*/local-cli/generator.*

# Ignore BUCK generated folders
.*\.buckd/

.*/node_modules/is-my-json-valid/test/.*\.json
.*/node_modules/iconv-lite/encodings/tables/.*\.json
.*/node_modules/y18n/test/.*\.json
.*/node_modules/spdx-license-ids/spdx-license-ids.json
.*/node_modules/spdx-exceptions/index.json
.*/node_modules/resolve/test/subdirs/node_modules/a/b/c/x.json
.*/node_modules/resolve/lib/core.json
.*/node_modules/jsonparse/samplejson/.*\.json
.*/node_modules/json5/test/.*\.json
.*/node_modules/ua-parser-js/test/.*\.json
.*/node_modules/builtin-modules/builtin-modules.json
.*/node_modules/binary-extensions/binary-extensions.json
.*/node_modules/url-regex/tlds.json
.*/node_modules/joi/.*\.json
.*/node_modules/isemail/.*\.json
.*/node_modules/tr46/.*\.json

[include]

[libs]
node_modules/react-native/Libraries/react-native/react-native-interface.js
node_modules/react-native/flow
flow/

[options]
module.system=haste

esproposal.class_static_fields=enable
esproposal.class_instance_fields=enable
unsafe.enable_getters_and_setters=true

munge_underscores=true

module.name_mapper='^image![a-zA-Z0-9$_-]+$' -> 'GlobalImageStub'
module.name_mapper='^[./a-zA-Z0-9$_-]+\.\(bmp\|gif\|jpg\|jpeg\|png\|psd\|svg\|webp\|m4v\|mov\|mp4\|mpeg\|mpg\|webm\|aac\|aiff\|caf\|m4a\|mp3\|wav\|html\|pdf\)$' -> 'RelativeImageStub'

suppress_type=$FlowIssue
suppress_type=$FlowFixMe
suppress_type=$FixMe

suppress_comment=\\(.\\|\n\\)*\\$FlowFixMe\\($\\|[^(]\\|(\\(>=0\\.\\(2[0-4]\\|1[0-9]\\|[0-9]\\).[0-9]\\)? *\\(site=[a-z,_]*react_native[a-z,_]*\\)?)\\)
suppress_comment=\\(.\\|\n\\)*\\$FlowIssue\\((\\(>=0\\.\\(2[0-4]\\|1[0-9]\\|[0-9]\\).[0-9]\\)? *\\(site=[a-z,_]*react_native[a-z,_]*\\)?)\\)?:? #[0-9]+
suppress_comment=\\(.\\|\n\\)*\\$FlowFixedInNextDeploy
suppress_comment=\\(.\\|\n\\)*\\$Ignore

[version]
>=0.24.2

I changed these
# Flow has a built-in definition for the 'react' module which we prefer to use
# over the currently-untyped source
#.*/node_modules/react/react.js
#.*/node_modules/react/lib/React.js
#.*/node_modules/react/lib/ReactDOM.js

based on @Benjamin-Dobell  comment

I am facing the same issue.

Make sure you're using a .flowconfig from the version of react-native you're using and install the same version of flow that's mentioned in the [version] section of that .flowconfig

So this is the structure
/
 /react
   - .flowconfig
   /node_modules
 /other stuff

I moved flowconfig file in the root folder but nothing has changed. I still have a lot (> 72) errors on react native. I've also tried to change the paths on flowconfig to take into account the react folder but nothing has changed

I am getting these errors as well.
 48: const React = require('React');
                   ^^^^^^^^^^^^^^^^ This modules resolves to "<<PROJECT_ROOT>>/../../../node_modules/react/package.json", which is outside both your root directory and all of the entries in the [include] section of your .flowconfig. You should either add this directory to the [include] section of your .flowconfig, move your .flowconfig file higher in the project directory tree, or move this package under your Flow root directory.```

Below are my versions for various modules:
```react-native --> 0.25.1
flow version is --> 0.24.2
npm --> 3.8.3
node --> 5.8.0```

I tried all the suggestions provided in this issue. Also it's creating problem only in my machine and working fine in others. I assume there is no problem with `.flowconfig` file and some configuration issue on my machine.

@deeptiagrawa You're definitely not the only one getting this. You are running some out-dated software, but I'm still receiving these same errors every update. I still have to comment out:
# Flow has a built-in definition for the 'react' module which we prefer to use
# over the currently-untyped source
#.*/node_modules/react/react.js
#.*/node_modules/react/lib/React.js
#.*/node_modules/react/lib/ReactDOM.js

in .flowconfig.
$ react-native --version react-native-cli: 1.0.0 react-native: 0.28.0 $ flow version Flow, a static type checker for JavaScript, version 0.26.0

Is anyone else still experiencing these errors? I just upgraded to 0.33 and have many of them:
node_modules/react-native/Libraries/Components/Touchable/TouchableBounce.js:14
 14: var Animated = require('Animated');
                    ^^^^^^^^^^^^^^^^^^^ This modules resolves to "<<PROJECT_ROOT>>/../../../node_modules/animated/package.json", which is outside both your root directory and all of the entries in the [include] section of your .flowconfig. You should either add this directory to the [include] section of your .flowconfig, move your .flowconfig file higher in the project directory tree, or move this package under your Flow root directory.

node_modules/react-native/Libraries/CustomComponents/NavigationExperimental/NavigationCard.js:35
 35: const Animated = require('Animated');
                      ^^^^^^^^^^^^^^^^^^^ This modules resolves to "<<PROJECT_ROOT>>/../../../node_modules/animated/package.json", which is outside both your root directory and all of the entries in the [include] section of your .flowconfig. You should either add this directory to the [include] section of your .flowconfig, move your .flowconfig file higher in the project directory tree, or move this package under your Flow root directory.

node_modules/react-native/Libraries/CustomComponents/NavigationExperimental/NavigationCardStackPanResponder.js:15
 15: const Animated = require('Animated');
                      ^^^^^^^^^^^^^^^^^^^ This modules resolves to "<<PROJECT_ROOT>>/../../../node_modules/animated/package.json", which is outside both your root directory and all of the entries in the [include] section of your .flowconfig. You should either add this directory to the [include] section of your .flowconfig, move your .flowconfig file higher in the project directory tree, or move this package under your Flow root directory.

I had the same errors. I changed [libs] pathes to react-native modules and now everything is ok.
Here is my .flowconfig file
`[ignore]
We fork some components by platform.
./[.]android.js
Ignore templates with @flow in header
./local-cli/generator.
Ignore malformed json
./node_modules/y18n/test/..json
Ignore the website subdir
<PROJECT_ROOT>/website/.*
Ignore BUCK generated dirs
<PROJECT_ROOT>/.buckd/
Ignore unexpected extra @providesModule
.*/node_modules/commoner/test/source/widget/share.js
Ignore duplicate module providers
For RN Apps installed via npm, "Libraries" folder is inside node_modules/react-native but in the source repo it is in the root
./Libraries/react-native/React.js
./Libraries/react-native/ReactNative.js
./node_modules/jest-runtime/build/tests/.
Ignore node_modules
./node_modules/react/node_modules/fbjs/.
[include]
[libs]
node_modules/react-native/Libraries/react-native/react-native-interface.js
node_modules/react-native/flow
flow/
[options]
module.system=haste
esproposal.class_static_fields=enable
esproposal.class_instance_fields=enable
esproposal.decorators=ignore
experimental.strict_type_args=true
munge_underscores=true
module.name_mapper='^image![a-zA-Z0-9$-]+$' -> 'GlobalImageStub'
module.name_mapper='^[./a-zA-Z0-9$-]+.(bmp|gif|jpg|jpeg|png|psd|svg|webp|m4v|mov|mp4|mpeg|mpg|webm|aac|aiff|caf|m4a|mp3|wav|html|pdf)$' -> 'RelativeImageStub'
suppress_type=$FlowIssue
suppress_type=$FlowFixMe
suppress_type=$FixMe
suppress_comment=\(.\|\n\)\$FlowFixMe\($\|[^(]\|(\(>=0\.\(3[0-2]\|[1-2][0-9]\|[0-9]\).[0-9]\)? \(site=[a-z,]*react_native[a-z,]\)?)\)
suppress_comment=\(.\|\n\)\$FlowIssue\((\(>=0\.\(3[0-2]\|1[0-9]\|[1-2][0-9]\).[0-9]\)? \(site=[a-z,]*react_native[a-z,]\)?)\)?:? #[0-9]+
suppress_comment=\(.\|\n\)*\$FlowFixedInNextDeploy
unsafe.enable_getters_and_setters=true
[version]
^0.32.0`

I'm using a default installation of react-native 0.34.0 and I still see this error. Starting to wonder if it's tied to my machine somehow

Bump into this error with react-native: "0.42.0" and flow-bin: "0.38.0"
Ignore these files inside .flowconfig
[ignore]
/* ... */
.*/node_modules/react-native-experimental-navigation/.*
.*/Libraries/Components/StaticContainer.js

I get the same problem with react-native 0.42.0 and flow-bin 0.38.0. Is there any solution for this?

Ran into this with react-native: 0.43.1 and flow-bin:0.43.1:

For anyone who still needs help with this, I have fixed the issue on my machine:
Instead of running flow with flow; test $? -eq 1 -o $? -eq 2 like the getting started docs say, use:
./path/to/node_modules/.bin/flow src/** where src is the main directory for your app code.

Looks like there is a known way to do this now, so I'm going to close the issue. Feel free to object if there's something else here that should be fixed in the flow codebase and I can reopen.

@asolove What is the known way? I didn't find a solution in this thread. I still get about 50 errors from React Native libraries, like:
Error: node_modules/react-native/Libraries/Animated/src/Easing.js:65
 65:   static step0(n) {
                    ^ n. Missing annotation

authors: Benjamin-Dobell MikeJSX RTsGIT alpcanaydin asolove baldursson bolismauro chetstone deeptiagrawa kiddo13 matthamil rebelliard ryyppy simonsmith

repo: facebook/flow


text:
Static variable in class is not compiled

Using Babel and Flow, this code:
class Agent {
  static agents;
}

is compiled to
class Agent {}

Yet not error is thrown.

What kind of error did you expect?

Sorry, I was a bit confused by the fact that I can't initialise the static variable in the class, but rather have to do
Agent.agents = []

outside the class. Will close this.

authors: olleharstedt samwgoldman


text:
Array indexing into a function should be an error

I mistyped the () to call a function as []. I was surprised that Flow had no complaints!
function add(x, y) {
  return x + y;
}
add[1, 2]

I suppose I could do add[2] = 123 somewhere else, but this wasn't an exported function, so flow could have known that this was off the table. Is fn[key] a construct that's often used?

Hmm, this is valid JavaScript so it's not clear that Flow should ban it. Computed property gets with functions are probably more rare than they are with regular objects, but they should work. You can do
function foo() {}
var bind = foo['bind'];

The add[1, 2] example you provided is probably pretty rare. People don't seem to use sequence expressions very often (the sequence expression expr1, expr2, ..., exprN evaluates to exprN), and probably not in this context. For example, I could have written above:
var bind = foo[1, 2, 3, 4, 'bind'];

and bind would have the same behavior.
We could prohibit sequence expressions inside of computed property accesses to avoid this exact issue, but I'm not sure if adding special cases for these sorts of edge cases is worth it. Perhaps we could instead try to recognize dead code...expressions without side effects that are just thrown away. In that case
add[1, 2]

would be an error, since evaluating the expression 1 has no side effect and its result is never stored.

Warning about dead code seems like a reasonable solution. There's a fine tradition of that in linting tools.

I totally agree with this, it's better than a workaround and throwing warning about dead code could be used to other cases.

FWIW, I see the same non-error as of Flow 0.17:
$ echo 'function add(x, y) { return x + y; }; add[1, 2];' | flow check-contents
No errors!
$ flow --version
Flow, a static type checker for JavaScript, version 0.17.0

Yeah, we still haven't gotten around to purity analysis (seeing if code has any effects when it's run). For a sequence expression (expr1, expr2, ..., exprN), you could complain if any of expr1 through exprN-1 were pure. So while you would want to allow
add[console.log("hi"), 2];

we would complain about
add[1, 2];

@gabelevi that sounds reasonable (and more general). You'd complain about this then, too, right?
1, 2;

Yep! And things like
someFunc((1,2));

To be quite honest, we probably could just complain about all sequences and no one would really mind :stuck_out_tongue:. Definitely would be easier than purity analysis!

authors: Eyyub danvk gabelevi


text:
Fix build by copying header files

Summary:
The open source build was broken for two reasons:

There were two new .c files that needed to be listed in the Makefile
Hack now is using .h files and ocamlbuild doesn't copy these into _build

I did a little bit of googling to see if it is easy to get ocamlbuild to understand .h files, but it didn't seem that easy. So I took the easy way out and just updated the Makefile to simply copy the .h files into _build.
Test plan:
make clean
make test
make

@facebook-github-bot shipit


text:
Update to Jupyter

Having updated ipython notebook to the new Jupyter incarnation I am no longer able to run Itorch notebooks. I get the following error in the terminal;
[E 12:31:50.348 NotebookApp] Bad kernel_info reply
Traceback (most recent call last):
File "/Users/jdg1g14/anaconda/lib/python2.7/site-packages/IPython/html/services/kernels/handlers.py", line 136, in _handle_kernel_info_reply
msg = self.session.deserialize(msg)
File "/Users/jdg1g14/anaconda/lib/python2.7/site-packages/IPython/kernel/zmq/session.py", line 826, in deserialize
raise ValueError("Unsigned Message")
ValueError: Unsigned Message
[C 12:31:50.355 NotebookApp] Malformed message: ['<IDS|MSG>', '', '{"session":"cbb297c0-14a9-46bc-c691-1d0ef9b42df9","date":"2015-03-05T12:31:50","username":"itorch","msg_id":"efce62cb-11ae-47cc-c783-b28c18a61233","msg_type":"kernel_info_reply"}', '{"version":"5.0","session":"2C78A94C43AD4D938328AA5F64DF5483","username":"username","msg_id":"8B1711ABA13643C68B62C682142D0937","msg_type":"kernel_info_request"}', '{}', '{"protocol_version":[4,0],"language":"lua","language_version":[20100]}']
Traceback (most recent call last):
File "/Users/jdg1g14/anaconda/lib/python2.7/site-packages/IPython/html/base/zmqhandlers.py", line 181, in _on_zmq_reply
msg = self._reserialize_reply(msg_list, channel=channel)
File "/Users/jdg1g14/anaconda/lib/python2.7/site-packages/IPython/html/base/zmqhandlers.py", line 162, in _reserialize_reply
msg = self.session.deserialize(msg_list)
File "/Users/jdg1g14/anaconda/lib/python2.7/site-packages/IPython/kernel/zmq/session.py", line 826, in deserialize
raise ValueError("Unsigned Message")
ValueError: Unsigned Message
/Users/jdg1g14/torch/install/bin/luajit: /Users/jdg1g14/torch/install/share/lua/5.1/itorch/main.lua:256: attempt to index local 'line' (a nil value)
stack traceback:
/Users/jdg1g14/torch/install/share/lua/5.1/itorch/main.lua:256: in function 'extract_completions'
/Users/jdg1g14/torch/install/share/lua/5.1/itorch/main.lua:297: in function </Users/jdg1g14/torch/install/share/lua/5.1/itorch/main.lua:295>
/Users/jdg1g14/torch/install/share/lua/5.1/lzmq/poller.lua:75: in function 'poll'
...s/jdg1g14/torch/install/share/lua/5.1/lzmq/impl/loop.lua:307: in function 'poll'
...s/jdg1g14/torch/install/share/lua/5.1/lzmq/impl/loop.lua:325: in function 'sleep_ex'
...s/jdg1g14/torch/install/share/lua/5.1/lzmq/impl/loop.lua:370: in function 'start'
/Users/jdg1g14/torch/install/share/lua/5.1/itorch/main.lua:341: in main chunk
[C]: in function 'require'
(command line):1: in main chunk
[C]: at 0x010ec41640
Any help would be appreciated...

hey Josh, I have not yet tested this with Jupyter. I will test it and get back to you today. thanks for the report

Hi @soumith / @josh-gree
Any luck with this? I can't run the old notebooks (cant see their contents even), after update to Jupyter.

i've reproduced the issue. will prepare appropriate fixes this week/weekend.

Hi  @soumith
Not sure if the issue has been fixed, but I am using the latest anaconda (incl. IPython) distribution, and have installed iTorch again. Torch works, IPython works, but iTorch doesn't work (neither in notebook nor in terminal). Any thoughts on what could be causing this?

Sorry for the delay. I've fixed it via this commit: https://github.com/facebook/iTorch/commit/59be6bcaf64f737a2361158b3021923e1afde39f
All you have to do to get it working with IPython 3.0 is do:
luarocks install itorch

And then to start itorch in notebook mode:
itorch notebook

And then create a new iTorch notebook from dropdown menu.
starting ipython notebook wont work, starting itorch notebook will work.
I am looking to see how ipython notebook will also work in 3.0.
If after this reinstall, you are still having trouble in ipython v3.0, please reopen this issue.

Thanks @soumith - really appreciate this.
I doesn't seem to be working for me.
When I start a torch notebook, this is the error I see (in the terminal):
[E 15:12:16.297 NotebookApp] Bad kernel_info reply
Traceback (most recent call last):
File "/Users/rezakhorshidi/anaconda/lib/python2.7/site-packages/IPython/html/services/kernels/handlers.py", line 136, in _handle_kernel_info_reply
msg = self.session.deserialize(msg)
File "/Users/rezakhorshidi/anaconda/lib/python2.7/site-packages/IPython/kernel/zmq/session.py", line 826, in deserialize
raise ValueError("Unsigned Message")
ValueError: Unsigned Message
[C 15:12:16.301 NotebookApp] Malformed message: ['<IDS|MSG>', '', '{"session":"cbb297c0-14a9-46bc-c691-1d0ef9b42df9","date":"2015-03-26T15:12:16","username":"itorch","msg_id":"efce62cb-11ae-47cc-c783-b28c18a61233","msg_type":"kernel_info_reply"}', '{"version":"5.0","session":"F863A9700B4B4E5F9A52E30DCE650117","username":"username","msg_id":"615D8039001B427D8E8A682E62E1C465","msg_type":"kernel_info_request"}', '{}', '{"protocol_version":[4,0],"language":"lua","language_version":[20100]}']
Traceback (most recent call last):
File "/Users/rezakhorshidi/anaconda/lib/python2.7/site-packages/IPython/html/base/zmqhandlers.py", line 181, in _on_zmq_reply
msg = self._reserialize_reply(msg_list, channel=channel)
File "/Users/rezakhorshidi/anaconda/lib/python2.7/site-packages/IPython/html/base/zmqhandlers.py", line 162, in _reserialize_reply
msg = self.session.deserialize(msg_list)
File "/Users/rezakhorshidi/anaconda/lib/python2.7/site-packages/IPython/kernel/zmq/session.py", line 826, in deserialize
raise ValueError("Unsigned Message")
ValueError: Unsigned Message
Any thoughts?

Thanks for this but again not working for me, don't get any error in the
terminal output but new notebook starts with an unaccessible cell. Could
this possibly be an anaconda issue?
Josh
On 26 Mar 2015 15:14, "rezakhorshidi" notifications@github.com wrote:

Thanks @soumith https://github.com/soumith - really appreciate this.
I doesn't seem to be working for me.
When I start a torch notebook, this is the error I see (in the terminal):
[E 15:12:16.297 NotebookApp] Bad kernel_info reply
Traceback (most recent call last):
File
"/Users/rezakhorshidi/anaconda/lib/python2.7/site-packages/IPython/html/services/kernels/handlers.py",
line 136, in _handle_kernel_info_reply
msg = self.session.deserialize(msg)
File
"/Users/rezakhorshidi/anaconda/lib/python2.7/site-packages/IPython/kernel/zmq/session.py",
line 826, in deserialize
raise ValueError("Unsigned Message")
ValueError: Unsigned Message
[C 15:12:16.301 NotebookApp] Malformed message: ['', '',
'{"session":"cbb297c0-14a9-46bc-c691-1d0ef9b42df9","date":"2015-03-26T15:12:16","username":"itorch","msg_id":"efce62cb-11ae-47cc-c783-b28c18a61233","msg_type":"kernel_info_reply"}',
'{"version":"5.0","session":"F863A9700B4B4E5F9A52E30DCE650117","username":"username","msg_id":"615D8039001B427D8E8A682E62E1C465","msg_type":"kernel_info_request"}',
'{}',
'{"protocol_version":[4,0],"language":"lua","language_version":[20100]}']
Traceback (most recent call last):
File
"/Users/rezakhorshidi/anaconda/lib/python2.7/site-packages/IPython/html/base/zmqhandlers.py",
line 181, in _on_zmq_reply
msg = self._reserialize_reply(msg_list, channel=channel)
File
"/Users/rezakhorshidi/anaconda/lib/python2.7/site-packages/IPython/html/base/zmqhandlers.py",
line 162, in _reserialize_reply
msg = self.session.deserialize(msg_list)
File
"/Users/rezakhorshidi/anaconda/lib/python2.7/site-packages/IPython/kernel/zmq/session.py",
line 826, in deserialize
raise ValueError("Unsigned Message")
ValueError: Unsigned Message
Any thoughts?
—
Reply to this email directly or view it on GitHub
https://github.com/facebook/iTorch/issues/33#issuecomment-86563065.

@rezakhorshidi i see the error that you see if I start "ipython notebook" and choose "new -> iTorch". if I start "itorch notebook", I dont see the error. Regardless, spending some time today to fix this even more properly.

I see ...
Well, I use
itorch notebook
in the terminal to open the server and start a notebook and this happens.
Moreover, if I simply use
itorch
and open it in the terminal, it functions as an ipython shell (i.e., import numpy works, but require 'nn' doesn't).

@soumith works like a charm for me with "itorch notebook" and creating a new one. Thank you!

@iassael what can be the possible cause on my side? Are you using anaconda (i)python?

@rezakhorshidi yes I am using the latest Anaconda Python. I don't know if it was necessary or they were overwritten in any case but removed any torch ~/.ipython configurations, and then reinstalled iTorch using luarocks make. Finally, everything works perfect when I use "itorch notebook" from terminal.

I installed torch for the first time yesterday and I had all sorts of issues when trying to run itorch notebook. All my issues were fixed by changing the last line in~/torch/install/bin/itorch from:
ipython $mode --profile torch $@
to:
ipython $mode --MappingKernelManager.default_kernel_name="itorch" --Session.key='' $@
This gets rid of the need for the torch python profile (I couldn't get it to work just by modifying the profile, also the profile uses c.KernelManager.kernel_cmd which is deprecated)
Only the kernel_spec is needed - ~/./ipython/kernels/itorch/kernel.json.

@thealch3m1st are you some kind of a wizard? Where does one find documentation for all of these command-line flags...
Let me try this and patch it in master.

@rezakhorshidi fixed it more properly in trunk, thanks to @thealch3m1st. See if "itorch notebook" now works for you.
https://github.com/facebook/iTorch/commit/8a6d29faf2bd9e4c5edea0cab14ae1a08462d3f3

@rezakhorshidi you will have to reinstall itorch ("luarocks install itorch")

@soumith I'm new to iPython & torch. I went thru hours of researching and trial and error before I got to what I posted.
This explains how to use the command line flags:
https://ipython.org/ipython-doc/dev/config/intro.html#command-line-arguments
I found the --MappingKernelManager.default_kernel_name option while looking thru all the commented options in the profile trying to find a replacement for deprecated c.KernelManager.kernel_cmd. The kernel wasn't starting at all for me whenever I opened a notebook and the notebook (even if it had content) looked empty. I was just looking for a way to force it to start the iTorch kernel, but changing stuff in the profile didn't really work for me so I looked for a way to set options one by one using the command line and found the info in the link above.
--Session.key='' disables auth/encryption and fixes the ValueError("Unsigned Message") exception when running without the profile (it's being set in the profile, so without the profile the option is not set).

@thealch3m1st thanks for doing all that research. It looks like the ipython guys are in a transition, because your solution works for itorch notebook, but not for itorch console (pushed another fix for that).
I was lost on how to set the session key to empty string in the new 3.0 configuration (I already do it with the 2.0 config).

Thanks @soumith and @thealch3m1st
It works perfectly fine now.

I have installed all the dependencies like ipython, iTorch and Jupyter. But when I run jupyter notebook, I am not able to see itorch notebook.
Please suggest any solution @soumith !!

authors: Ashutosh1995 iassael josh-gree rezakhorshidi soumith thealch3m1st

repo: facebook/iTorch


text:
Metadata API

Likely easier to accomplish as a plugin or similar with any changes that may come from #301, but this would be a super nice to have.
Currently I'm using a custom metadata API on my fork to signal specific properties on a map used in triggering a change at a path (sort of an observable cursor type deal). Other cases I'm using are to store temporary info related to the data but which shouldn't change the actual shape of underlying value - the "type" of a filtered result, whether a map has been "validated", etc.
Setting metadata on an Immutable object would return a new value which would be considered value equal but not referential equal.

Interesting. So you use meta as a marker interface to see if some data has been validated or not already. What other common uses take advantage of meta?

@swannodette I'm sure you can provide some good advice here. What are the benefits and pitfalls of meta in practice in most clojure apps?

@leebyron the only real pitfall for metadata is accidentally losing it, internally most Clojure(Script) data structures preserve metadata across all operations that make sense. The other problem is how to transit metadata over the wire. Got no ideas about that.
The benefits are many in Clojure(Script), people use it for all kinds of things - everything from annotating Clojure(Script) source code itself to providing provenance information on runtime data.

I would also appreciate some kind of metadata API. I don't know where to store state (such as loading, error, ok) and error messages in react app using immutable.js now.
I have implemented my own "library" which wraps immutable.js structures and provides method like updateDataAndMetada, getErrors, getState (+ shortcuts isLoading, isOk, ...). It also has methods like get, getIn, set, setIn which behaves the same way like immutable.js methods. So if you call set on "my" object, it returns a new instance with value set on the inner immutable.js object. But I don't think it is a best approach.

Metadata would be super easy to add to mutable data structures. Adding a field to an object would done the thing. However with immutable objects we need to be sure it is copied with every object change.

Yeah, I'm using it in a custom collection of models (records with ids and client ids), where you can have metadata as @janmarek mentioned of setting if that collection is currently being fetched. Anyway, I implemented it by making my custom collection have a record of metadata attributes. Would be really great to see how an API for metadata attributes could look like

:+1: on metadata for all immutable objects. We need a flag to indicate if our record object is only partially fetched (= only the identifier field is set). Right now we work around this by checking if all values are undefined (= default values) expect the identifier field(s).

Thank you for reporting this issue and appreciate your patience. We've  notified the core team for an update on this issue. We're looking for a response within the next 30 days or the issue may be closed.

Closing this aging issue - perhaps something we could consider in the future.

authors: facebook-github-bot-6 janmarek leebyron leoasis madebyherzblut swannodette tgriesser

repo: facebook/immutable-js


text:
Just want to say thanks

A Github issue is probably not the right place for this, but I've had such a great experience using Immutable over the last few weeks that I'm compelled to say thank you somehow.
I've been moving an existing React app to Immutable, and I've seen significant performance gains and much simpler, cleaner, easier to understand code as a result. Immutable has just been a pleasure to use in so many ways, and I think I'm a better (certainly happier) developer for having used it.
So to @leebyron and all the other contributors, thank you for your hard work on a wonderful project! I really appreciate what you've done with Immutable and hope to contribute myself someday, even if just documentation patches (step 1: move past feeling like I have nothing to contribute).

Not sure if this is the right place, either, but... I fully agree. :smile:

authors: jareware leebyron nathanjsharpe


text:
Can we use FBSnapshotTestCase with XCTestCase?

Can we use FBSnapshotTestCase with the XCTestCase? and can use FBSnapshotTestCase with the real time data? I tried this with the table view if the content of the table view change the test case fails. and should I push the snapshots on git repo or not?

FBSnapshotTestCase is a subclass of XCTestCase. You can use anything in XCTestCase.

authors: alanzeino amrutahoke

repo: facebook/ios-snapshot-test-case


text:
setTimeout and setInterval aren't detected as open handles

🐛 Bug Report
I would expect setTimeout and setInterval to be treated as open handles, preventing Jest from exiting normally and causing an error but timeouts are ignored, the process exists without waiting for them. This results in inability to detect that tested code is potentially buggy.
To Reproduce
Steps to reproduce the behavior:
function foo() {
  setTimeout(() => {}, 4000);

  new Promise((resolve, reject) => setTimeout(() => reject(new Error('unhandled rejection')), 3000));

  return 1;
}

it('should warn about open handles', done => {
  expect(foo()).toBe(1);
  setTimeout(done, 100);
})

PASS  tests/index.js
√ should warn about open handles (128ms)
Test Suites: 1 passed, 1 total
Tests:       1 passed, 1 total
Snapshots:   0 total
Time:        3.497s
Ran all test suites.

The problem persists with latest Jest release (24.1).
Expected behavior
A clear and concise description of what you expected to happen.
Link to repl or repo (highly encouraged)
A repo that replicates the problem.
Run npx envinfo --preset jest
  System:
    OS: Windows 7
    CPU: (8) x64 Intel(R) Core(TM)
  Binaries:
    Node: 10.13.0 - C:\Program Files (x86)\nodejs\node.EXE
    Yarn: 1.9.4 - C:\Program Files (x86)\nodejs\yarn.CMD
    npm: 6.4.1 - C:\Program Files (x86)\nodejs\npm.CMD

Do we have an update on this issue ? Seems like am facing the same issue when using setTimeout and jest doesn't wait for the timeout and exists with no errors .

I can confirm this bug. This is caused by jest-environment-jsdom. If you set testEnvironment to node, it works as expected. I've tried removing all of the error handler stuff from jest-environment-jsdom and bringing its usage of fake timers in line with that of jest-environment-node, but to no avail - it might even be caused by something in jsdom itself :/

@github-actions It's not stale, bot

As https://github.com/facebook/jest/issues/7933#issuecomment-474419143 states, this only happens when using JSDOM. JSDOM uses browser timers, which do not keep the process open - Jest exits cleanly in your example.
If you use node test env the process is kept open (and the handles are reported).

If you want jest (and not node, which is what where checking with open handles) to wait for your timers, you need to either return promises or use the done callback

@SimenB Why was the issue closed? It's still relevant and not fixed. It would be the problem of JSDOM if it were just a third-party lib that is used by developers at their own risk. But Jest has first-class JSDOM support and provides it as first-party environment, so it's expected to  its responsibility to take care of consistent and predictable behaviour. The explanation that you gave makes sense but this behaviour not documented and certainly not expected.
I personally strictly follow good practices regarding writing asynchronous tests. However, I explained the problem in the issue, "This results in inability to detect that tested code is potentially buggy", it occurred to me previously.

There are no open handles produced by setTimeout in a browser setting, so there's nothing to detect.

But JSDOM isn't browser setting, it only replicates it to some extent, it was never thoroughly described to which one. This happened to me in universal code and Node code that was tested in the same environment as the rest of the project, which was jsdom, one could only guess what could affected by the choice of environments besides the availability of browser API.
As I said, the reasons why it works like that make sense, but it's not documented and totally looks like a bug and not a feature. I'd suggest to reopen the issue and find an appropriate resolution for it if possible. If this is something that goes without saying, why is this not mentioned in the documentation?

There is nothing we can do to detect you are not waiting for the async work your test is doing, that's just how JavaScript works. Your OP talked about how --detectOpenHandles does not detect this case, and I've explained why it's detected in node env, but not jsdom env.
If you think the documentation can be improved in regards to how to test async code, we should have an issue for that (or even better, send a PR) - not a bug report about --detectOpenHandles.

As I said, the reasons why it works like that make sense, but it's not documented and totally looks like a bug and not a feature

The second sentence in the first paragraph of https://jestjs.io/docs/asynchronous is

When you have code that runs asynchronously, Jest needs to know when the code it is testing has completed, before it can move on to another test.

Not sure how it can be more explicit?

I filed #12522 earlier. That was mostly to lift promises above callbacks, but if you have any suggestions for how to reword this, that issue might be a good place to put it 🙂

authors: SimenB abhishek-1985 bisubus jeysal

repo: facebook/jest


text:
Update Configuration.md on Async TestEnvironment API

Clarify the TestEnvironment usage.

Thanks for the clarification.

authors: cpojer xfumihiro


text:
Add missing export statement

Add missing export statement in puppeteer_environment.js
Just found that the puppeteer_environment.js under docs/Puppeteer.md doesn't export the environment

Thanks @QiuHaohao would you mind adding a changelog entry? Also you need to add a semicolon to the end of the export line to fix the lint error
module.exports = PuppeteerEnvironment;

Codecov Report

Merging #7127 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #7127   +/-   ##
======================================
  Coverage    66.6%   66.6%
======================================
  Files         253     253
  Lines       10629   10629
  Branches        4       3    -1
======================================
  Hits         7079    7079
  Misses       3549    3549
  Partials        1       1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b69eb01...aed03ec. Read the comment docs.

authors: QiuHaohao codecov-io mattphillips


text:
Playground, ImageResizer />: image overflows - width/maxWidth issue?

This issue comes from the playground example.
The <img /> component styling has not been altered
I am happy to create a PR if y'all think the below is an actual issue and not something I'm missing/not understanding fully.

If I'm missing something could someone please elaborate on usage of this?

Lexical version: v0.5.0
Steps To Reproduce / The current behavior

Add image with "Insert image"
resize the added image to some size
resize the screen to something small and see the original image overflow-x

Enough space for set width:

Small screen (not enough space) for set width:

The expected behavior
Image to be resized to the desired size IF the screen space allows for it, otherwise shrink to maxWidth: 100%, which would result in something like this:

Yea, this sounds like it could be improved. PR is welcome here.

I'm not sure if this is a bug or the expected UX. I think this would be the expected behaviour if the editor was in readonly mode, in which case we could make the image responsive for smaller viewports, but if we want the user to explicitly set the pixel value of the underlying image, we shouldn't probably then override that if the editor viewport becomes smaller (with I'm presuming an intersection observer?).

I'm not sure if this is a bug or the expected UX. I think this would be the expected behaviour if the editor was in readonly mode, in which case we could make the image responsive for smaller viewports, but if we want the user to explicitly set the pixel value of the underlying image, we shouldn't probably then override that if the editor viewport becomes smaller (with I'm presuming an intersection observer?).

Hmm, interesting... I wonder how commonly would this kind of behaviour would be desirable? Wouldn't in most cases it would be expected for the UI to be easy to use in favour of Figma-like - for the sake of argument - infinite overflow?

I'm not sure if this is a bug or the expected UX. I think this would be the expected behaviour if the editor was in readonly mode, in which case we could make the image responsive for smaller viewports, but if we want the user to explicitly set the pixel value of the underlying image, we shouldn't probably then override that if the editor viewport becomes smaller (with I'm presuming an intersection observer?).

I don't think you need an intersection observer for this. It's just about preserving the aspect ratio of the img AFAICT, which should be something we can do with CSS.

Hey Acy,
Wooho, sounds great, will do!
I’m taking off for conference travels for next 2 weeks, can’t wait to be back and set up a Zoom coffee “)
Cheers,
@SᴄᴏᴛᴛAɢɪʀs
On Oct 26, 2022, 4:59 PM +0300, Acy Watson @.***>, wrote:

I'm not sure if this is a bug or the expected UX. I think this would be the expected behaviour if the editor was in readonly mode, in which case we could make the image responsive for smaller viewports, but if we want the user to explicitly set the pixel value of the underlying image, we shouldn't probably then override that if the editor viewport becomes smaller (with I'm presuming an intersection observer?).
I don't think you need an intersection observer for this. It's just about preserving the aspect ratio of the img AFAICT, which should be something we can do with CSS.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: @.***>

authors: ScottAgirs acywatson thegreatercurve

repo: facebook/lexical


text:
Fix TableCell child nodes on paste

This PR fixes pasting tables that have the copied html in such format:
...

 ...

...

Pasting this results in the following node structure:

which causes the editor to freeze and eventually crash on enter key press, as the text node is not wrapped in a paragraph node.
This issue is similar to the one described here and was fixed for the case when pasting empty cells.
This PR addresses the case when on paste the children of the TableCell node are not within a block element node.
Another case to reproduce this issue is when we copy something with such html:
...

 ...

...

This results in a link node inside a tablecell node which again crashes on enter key press.
Also, this PR fixes the issue with alignment of text inside the cell as well, as this formatting can now be applied on the wrapping block element node.
So, copying from google sheets will now have the correct alignment.
Before

After

Thank you, we can merge this, but I'd be inclined to roll it back as soon as https://github.com/facebook/lexical/pull/5857 is ready as it fixes the same issue in a more generic manner cc @potatowagon

Thanks Gerard! Happy to revert once the larger one lands. Do we have an ETA on the generic solution? If it's a week, we can wait it out.

#5857 is ready, tests and comments addressed @ivailop7 @zurfyx

authors: Shubhankerism ivailop7 potatowagon zurfyx


text:
ListView with RecyclerViewBackedScrollView crash on Android

Description
When using renderScrollComponent={props => <RecyclerViewBackedScrollView {...props} /> on a ListView, the app crash on android giving this error :
java.lang.AbstractMethodError: abstract method "boolean android.support.v7.widget.RecyclerView$ItemAnimator.animateAppearance(android.support.v7.widget.RecyclerView$ViewHolder, android.support.v7.widget.RecyclerView$ItemAnimator$ItemHolderInfo, android.support.v7.widget.RecyclerView$ItemAnimator$ItemHolderInfo)"
at android.support.v7.widget.RecyclerView.animateAppearance(RecyclerView.java:3528)
at android.support.v7.widget.RecyclerView$4.processAppeared(RecyclerView.java:461)
at android.support.v7.widget.ViewInfoStore.process(ViewInfoStore.java:249)
at android.support.v7.widget.RecyclerView.dispatchLayoutStep3(RecyclerView.java:3385)
at android.support.v7.widget.RecyclerView.dispatchLayout(RecyclerView.java:3135)
at android.support.v7.widget.RecyclerView.onLayout(RecyclerView.java:3568)
at android.view.View.layout(View.java:16630)
at android.view.ViewGroup.layout(ViewGroup.java:5437)
at com.facebook.react.uimanager.NativeViewHierarchyManager.updateLayout(NativeViewHierarchyManager.java:192)
at com.facebook.react.uimanager.NativeViewHierarchyManager.updateLayout(NativeViewHierarchyManager.java:177)
at com.facebook.react.uimanager.UIViewOperationQueue$UpdateLayoutOperation.execute(UIViewOperationQueue.java:123)
at com.facebook.react.uimanager.UIViewOperationQueue$2.run(UIViewOperationQueue.java:782)
at com.facebook.react.uimanager.UIViewOperationQueue.flushPendingBatches(UIViewOperationQueue.java:829)
at com.facebook.react.uimanager.UIViewOperationQueue.access$1500(UIViewOperationQueue.java:44)
at com.facebook.react.uimanager.UIViewOperationQueue$DispatchUIFrameCallback.doFrameGuarded(UIViewOperationQueue.java:868)
at com.facebook.react.uimanager.GuardedChoreographerFrameCallback.doFrame(GuardedChoreographerFrameCallback.java:32)
at com.facebook.react.uimanager.ReactChoreographer$ReactChoreographerDispatcher.doFrame(ReactChoreographer.java:131)
at android.view.Choreographer$CallbackRecord.run(Choreographer.java:856)
at android.view.Choreographer.doCallbacks(Choreographer.java:670)
at android.view.Choreographer.doFrame(Choreographer.java:603)
at android.view.Choreographer$FrameDisplayEventReceiver.run(Choreographer.java:844)
at android.os.Handler.handleCallback(Handler.java:739)
at android.os.Handler.dispatchMessage(Handler.java:95)
at android.os.Looper.loop(Looper.java:148)
at android.app.ActivityThread.main(ActivityThread.java:5417)
at java.lang.reflect.Method.invoke(Native Method)
at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:726)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:616)

Reproduction
      <ListView
          dataSource={this.state.eventsDataSource}
          pageSize={this.state.eventsCount}
          ref="eventsListView"
          refreshControl={
            <RefreshControl
              enabled={false}
              refreshing={this.props.fetchingEvents}
            />
          }
          renderRow={(event) =>
            <EventListItem
              color={this.getEventColor(event)}
              event={event}
              height={EVENT_LIST_ITEM_HEIGHT}
              onPress={() => {}}
            />
          }
          renderScrollComponent={props => <RecyclerViewBackedScrollView {...props} />}
          renderSectionHeader={(sectionData, date) =>
            <View style={styles.sectionHeader}>
              <Text style={styles.sectionHeaderText}>{I18n.l('date.formats.long_day_month_date_year', date)}</Text>
            </View>
          }
        />

Additional Information

React Native version: 0.35
Platform: Android
Operating System: MacOS

I confirm it also happened with me

same here for React 0.37

Can you reproduce this on rnplay.org?

Mmm, was using Nuclide,and somehow I think the packager went bonkers.
I will come back to you if I manage to crash it with normal start from cli.

same for RN 0.37

I have the same problem.
com.android.support:appcompat-v7:23.0.1
com.android.support:design:23.0.1
compile 'com.android.support:recyclerview-v7:23.0.1
can work well.
if recyclerview or appcompat version > 23.0.1 ,will crash.
same for RN 0.37-0.39
Additional Information:
React Native version: 0.39
Platform: Android
Operating System: MacOS

Not sure the recycler is used (and therefore maintained anymore 😢 ) ->  https://github.com/facebook/react-native/pull/11095

I've reopened a PR to depreciate this.

@tychota Why do you want to deprecate it? Many people use RecyclerViewBackedScrollView and there is no alternative. Just search issue section for "RecyclerViewBackedScrollView" to see just how many.

@teodors : https://github.com/facebook/react-native/pull/11445
tl;dr
RecyclerViewBackedScrollView seems to be an experiment, not maintained by Facebook anymore (thus breaking in last RN version).
It was useful in the Past cause it was a great workaround around ListView bugs and perf issues but now:

bug where insertion of items make the list bounce back is fixed in list view
the performance benefit is really minimal not that removeClippedSubviews exist in ListView (according to core contributor discussion, I have no benchmark)
no one is left to maintain it and push it so it replace list view

@teodors: Well I may be wrong, so please comment on the pull request that you don't want it to be merged.
The initial PR was about to get merged to depreciate this, but a member of RN core team decided to extract it to a repo before. That as never the case, as far as I know and now the RecyclerViewBackedScrollView make android crash.

@teodors u can use this https://github.com/facebook/react-native/blob/master/Libraries/Experimental/WindowedListView.js

Closing as ListView is deprecated in 0.43. Use FlatList.

authors: IbrahimAmin chang-chaunce charlesluo2014 hramos joles86 rborn sibelius teodors tychota

repo: facebook/react-native


text:
Can't wrap RefreshControl in a custom component on Android?

Description
If I want common swipe-to-refresh functionality to be re-used across several screens in my app (across both ListViews and ScrollViews), surely the cleanest solution to this would be to have a custom MyRefreshControl, which encapsulates its own state / syncing logic / styling, that can be composed in with a single line - refreshControl={<MyRefreshControl />}.  But from what I can tell this doesn't seem to work.
Reproduction
https://rnplay.org/apps/41CAVQ
Example above works on iOS, but not Android.  Uncommenting line 27 and commenting 28 (i.e. removing the custom component wrapper) fixes it for Android.
Additional Information

React Native version: 0.37.0 (Exponent latest)
Platform: Android
Operating System: Windows

Never mind - turns out the issue was that I wasn't passing {...this.props} down from my component to the real RefreshControl.
From the way it's called, it's not really clear that there are other props being implicitly passed on to the RefreshControl.  Might be useful if that was mentioned in the docs, or there was some kind of error if those props aren't being provided.

This caught me too. Thanks for following up with a resolution, @jamesisaac.

YES!  Thank you @jamesisaac.  Just saved me a ton of time.

Hi @toytonic .  I wasn't putting a view around it, just wrapping it in another React component so that I could pass in some props by default.  By wrapping it in a view you're affecting the view hierarchy, which would have unknown consequences... not really related to this issue.

authors: BradRyan aroth jamesisaac


text:
Unable to pull up Developer Menu after upgrade to 0.42.0

Description
I upgraded my application to latest react native, react and supporting packages. I did this by creating a brand new react native project and importing the necessary files as react-native-git-upgrade was not working for me.
Now when running my application on ios simulator, it doesn't seem to recognize Command⌘ + D. However in my old project, using 0.38.0, I have no issues.
I have tried building and running the application from xCode directly and from terminal using react-native run-ios
I have also completely cleaned out the node-modules folder and done a clean npm install
I have checked and do not have Slow Animations enabled
Are there any logs or run commands that I can add to see why the Command⌘ + D isn't being recognized?
Reproduction
You should be able to clone the following repo and reproduce the issue by following the installation instructions here:
https://github.com/macnube/Atdaa
Additional Information

React Native version: 0.42.0
Platform: ios
Operating System: MacOS
Dev tools: XCode

Did you check the Hardware Keyboard setting?

Yep and it's on. Should have mentioned that earlier as well.

Have the exact same issue. Wondering if it could be some conflict in pbxproj?

So I went through the painful process of recreating the project from scratch and slowly adding in everything little by little. Now the cmd R and debug menu with cmd D does work.
I did this after I cleaned out the project, cleared the TMPDIR for react-native and reinstalled watchman to no avail.
Not the best solution but I'm glad that it's working now.

Had the same problem. After recreating app it was gone until I installed some other lib via cocoapods, the developer menu stopped working. Upgrade to 0.42.3 solved  this issue so I guess if somebody has same problem, just do upgrade.

authors: hramos macnube mewwts pfulop


text:
Natively started activity is closed when launching rn app from desktop icon on Android.

🐛 Bug Report
On some screen of react-native application I call native method (@ReactMethod), which launches new activity. Then when I navigate to the Android home screen and reopen my app from the background using app icon (not application dispatcher), the app opens on the last screen, from which I'd called my native method. In other words, it opens MainActivity when I expect seeing natively started MyActivity.
MainActivity-s launchMode is set to singleTask. Debugging shows, that after clicking launch icon, MyActivity is destroyed before MainActivity.onNewIntent is called.
To Reproduce

From the screen A in react-native call native method myNativeMethod marked as @ReactMethod (for example, when clicking some button).
In that myNativeMethod launch a new activity MyActivity using reactApplicationContext.
Hide the application using Android home button.
Reopen background app using launch icon from desktop or application list (not from application dispatcher).

Expected Behavior
Expect seeing MyActivity but seeing MainActivity on the last react-native screen (screen A), from which I called myNativeMethod.
Code Example
@ReactMethod
fun myNativeMethod() {
    val intent = Intent(reactApplicationContext, MyActivity::class.java)
    reactApplicationContext.startActivity(intent)
}

Environment
info
  React Native Environment Info:
    System:
      OS: macOS 10.14.4
      CPU: (8) x64 Intel(R) Core(TM) i5-8259U CPU @ 2.30GHz
      Memory: 60.40 MB / 16.00 GB
      Shell: 3.2.57 - /bin/bash
    Binaries:
      Node: 11.13.0 - /usr/local/bin/node
      Yarn: 1.15.2 - /usr/local/bin/yarn
      npm: 6.7.0 - /usr/local/bin/npm
      Watchman: 4.9.0 - /usr/local/bin/watchman
    SDKs:
      iOS SDK:
        Platforms: iOS 12.2, macOS 10.14, tvOS 12.2, watchOS 5.2
      Android SDK:
        API Levels: 16, 17, 18, 19, 20, 21, 22, 23, 24, 25, 26, 27, 28
        Build Tools: 25.0.2, 26.0.1, 26.0.2, 27.0.2, 27.0.3, 28.0.0, 28.0.2, 28.0.3
        System Images: android-16 | ARM EABI v7a, android-16 | Google APIs Intel x86 Atom, android-17 | Google APIs Intel x86 Atom, android-19 | Google APIs Intel x86 Atom, android-22 | Google APIs Intel x86 Atom, android-23 | Google APIs Intel x86 Atom, android-24 | Google Play Intel x86 Atom, android-25 | Google Play Intel x86 Atom, android-26 | Google APIs Intel x86 Atom, android-26 | Google Play Intel x86 Atom, android-28 | Google Play Intel x86 Atom, android-P | Google APIs Intel x86 Atom
    IDEs:
      Android Studio: 3.3 AI-182.5107.16.33.5264788
      Xcode: 10.2.1/10E1001 - /usr/bin/xcodebuild
    npmPackages:
      react: 16.8.3 => 16.8.3
      react-native: 0.59.2 => 0.59.2
    npmGlobalPackages:
      react-native-cli: 2.0.1
      react-native-create-library: 3.1.2

maybe you should remove launchMode=singleTask, and try.

@dulmandakh - remove and run into multiple instances for each launch from icon or push notification?
It's not a solution.
I've thought that probably I'd described as a bug the normal way Android handles singleTask activities. Now I see the only solution in creating another launcher activity without singleTask launch mode which will proxy intents to MainActivity ignoring launch intents from application icon, when the app is already launched.

authors: SpertsyanKM dulmandakh


text:
React native Android Scrollview slow down after some redirections in app:

I have react native app like instagram,
My problem is first time app is load scrollview working very smoothly in home page with large data, but after some redirection in app, back to home page, scrollview stuck at some points.
here is my code
               <ScrollView
					ref={ref => this.scrollView = ref}
				 	scrollEventThrottle={400}
				 	onScroll={({nativeEvent}) => {
				      this.handleScroll(nativeEvent)
				    }}
				    keyboardShouldPersistTaps='handled'
				    showsVerticalScrollIndicator={false}
				    refreshControl={
						<RefreshControl
							refreshing={this.state.refreshing}
							onRefresh={this._onRefresh}
						/>
			        }
				    >
					<View style={[this.state.isSubscribingTab ? this.tabHeight() : style.mianContainer]}>
						<AuctionPosts ref={instance => { this.AuctionPostsChild = instance; }} _onRefreshEnd={this._onRefreshEnd} />
						<View style={style.mainContent}>
							<Tabs ref={component => this._tabs = component} locked={true} tabBarUnderlineStyle={style.tabUnderLine} onChangeTab={({ i }) => this.tabChange(i)}>
								<Tab activeTabStyle={{ backgroundColor: colors.white }} tabStyle={{ backgroundColor: colors.white }} heading={this.state.labels.following ? this.state.labels.following : "Following"} textStyle={style.tabTextStyle} activeTextStyle={style.activeTextTab}>
									<FollowingPosts  ref={instance => { this.FollowingPostsChild = instance; }} _onRefreshEnd={this._onRefreshEnd} />
								</Tab>
								<Tab activeTabStyle={{ backgroundColor: colors.white }} tabStyle={{ backgroundColor: colors.white }} heading={this.state.labels.subscribing ? this.state.labels.subscribing : "Subscribing"} textStyle={style.tabTextStyle} activeTextStyle={style.activeTextTab}>
									<SubscribingPosts ref={instance => { this.SubscribingPostsChild = instance; }} subscribingPostCount={this.subscribingPostCount} />
								</Tab>
							</Tabs>
						</View>
					</View>
				</ScrollView>

it is working fine in IOS but issue in Android
Thanks!

i got the exact same problem.
First lauch the scrollview scroll the large amont of data with no problemes. Very Quick and fluid.
then i navigate in my app or reload it and the scrollView have big big lags and stop to scroll.

i experience the problem only on old Android phones.
when i strongly press the screen and make a slow big swipe the app scroll normaly, it seems that the scrollView doesn't responds to quick/little swipes.
Like it was not a problem with the large amont of data in the scrollView but a problem with  the Gesture,Swipe listener.

I got the same issue as @nicolasdet described above.
It happens only with the above Android 8.0. It can scroll smoothly without issue in Android 7.0 below.
The first stack navigator doesn't have any issue when swipe, But the third or more stack navigator causes scroll view scroll slow down and laggy. I used ScrollView of react-native

authors: bharatidudhrejiya kyunkakata nicolasdet


text:
[iOS] Inconsistent behaviour when converting homogeneous arrays as native call arguments

On iOS, when calling native method that accepts array as argument, automatic conversion of values inside array is different in Release and Debug configuration. What works in Debug crashes in Release
React Native version:
React Native Environment Info:
System:
OS: macOS 10.14.5
CPU: (12) x64 Intel(R) Core(TM) i7-8750H CPU @ 2.20GHz
Memory: 663.40 MB / 16.00 GB
Shell: 5.3 - /bin/zsh
Binaries:
Node: 10.11.0 - ~/.nvm/versions/node/v10.11.0/bin/node
Yarn: 1.13.0 - ~/.dev/yarn/1.13.0/bin/yarn
npm: 6.4.1 - ~/.nvm/versions/node/v10.11.0/bin/npm
Watchman: 4.9.0 - /usr/local/bin/watchman
SDKs:
iOS SDK:
Platforms: iOS 12.2, macOS 10.14, tvOS 12.2, watchOS 5.2
IDEs:
Xcode: 10.2.1/10E1001 - /usr/bin/xcodebuild
npmPackages:
react: 16.8.3 => 16.8.3
react-native: 0.59.8 => 0.59.8
Steps To Reproduce
Call AsyncStorage.set('key', 123)
Above works in Debug and crashes in Release
Describe what you expected to happen:
Above works in debug as number (although types suggest it explicitly expects string) gets automatically converted to string via sequence of calls ending with RCTConvertArrayValue which converts converts anything to expected type (which is NSString) https://github.com/facebook/react-native/blob/ffa3b0d4d601fe6788319a7cfd4185b8e4bf462f/React/Base/RCTConvert.m#L558
in Release sequence of macro calls is different though, never reaching RCTConvertArrayValue as can be seen here https://github.com/facebook/react-native/blob/ffa3b0d4d601fe6788319a7cfd4185b8e4bf462f/React/Base/RCTConvert.m#L591-L596
What I think is expected behaviour is that in Debug it should log error descriptions of types mismatches but never convert anything to NSString automatically.
Were there any considerations as to why automatic conversion to string was added that I am missing?

Please report issues in AsyncStorage in this repo: https://github.com/react-native-community/async-storage – it was extracted from RN and will soon be removed from React Native. Please use the community package from now on.

@cpojer, please, read carefully. The issue is in React Native RUNTIME. I only used AsyncStorage to illustrate it. It could have been any other native module with method that accepts array of strings as parameter.

@gavrix this should resolved in https://github.com/facebook/react-native/commit/df17ebfcfaaf2cf5984e836bdb70ccf8d9f66307

Awesome, Thanks!

authors: cpojer gavrix sammy-SC