text:
webhook in cncf

this pr is to don't rely on openshift to deploy webhook service and webhook tlscertificate

webhook is working now:

However I saw some error message in the log, investigating if it is related to webhook server:
I0414 15:25:45.868711       1 request.go:665] Waited for 1.031378146s due to client-side throttling, not priority and fairness, request: GET:https://172.30.0.1:443/apis/apps.openshift.io/v1?timeout=32s
2023-04-14T15:25:47.277Z	INFO	controller-runtime.metrics	metrics server is starting to listen	{"addr": ":8080"}
I0414 15:25:47.278152       1 main.go:132] Identifying Common Service Operator Role in the namespace ibm-common-services
I0414 15:25:49.785018       1 init.go:160] Single Deployment Status: false, MultiInstance Deployment status: true, SaaS Depolyment Status: false
I0414 15:25:49.789640       1 main.go:185] Updating common-service-maps ConfigMap in kube-public
I0414 15:25:52.251405       1 main.go:215] Creating CommonService CR in the namespace ibm-common-services
I0414 15:25:52.255874       1 certificaterefresh_controller.go:231] Set up
I0414 15:25:52.255922       1 podrefresh_controller.go:338] Set up
I0414 15:25:52.255944       1 v1_add_label_controller.go:114] Set up
I0414 15:25:52.255960       1 webhookreconciler.go:281] Creating common service webhook configuration
I0414 15:25:52.255978       1 webhookreconciler.go:336] setting up webhook server
I0414 15:25:54.709798       1 operator_webhooks.go:182] Reconciling common service webhook service
I0414 15:25:54.713817       1 operator_webhooks.go:207] Creating common service webhook service
E0414 15:25:54.725809       1 operator_status.go:76] Failed to check operator ibm-licensing-operator: the cache is not started, can not read objects
E0414 15:25:54.725832       1 operator_status.go:76] Failed to check operator ibm-mongodb-operator: the cache is not started, can not read objects
E0414 15:25:54.725839       1 operator_status.go:76] Failed to check operator ibm-cert-manager-operator: the cache is not started, can not read objects
E0414 15:25:54.725845       1 operator_status.go:76] Failed to check operator ibm-iam-operator: the cache is not started, can not read objects
E0414 15:25:54.725851       1 operator_status.go:76] Failed to check operator ibm-im-operator: the cache is not started, can not read objects
E0414 15:25:54.725857       1 operator_status.go:76] Failed to check operator ibm-im-operator-v4.0: the cache is not started, can not read objects
E0414 15:25:54.725864       1 operator_status.go:76] Failed to check operator ibm-healthcheck-operator: the cache is not started, can not read objects
E0414 15:25:54.725871       1 operator_status.go:76] Failed to check operator ibm-commonui-operator: the cache is not started, can not read objects
E0414 15:25:54.725879       1 operator_status.go:76] Failed to check operator ibm-idp-config-ui-operator-v4.0: the cache is not started, can not read objects
E0414 15:25:54.725884       1 operator_status.go:76] Failed to check operator ibm-idp-config-ui-operator: the cache is not started, can not read objects
E0414 15:25:54.725890       1 operator_status.go:76] Failed to check operator ibm-management-ingress-operator: the cache is not started, can not read objects
E0414 15:25:54.725896       1 operator_status.go:76] Failed to check operator ibm-ingress-nginx-operator: the cache is not started, can not read objects
E0414 15:25:54.725903       1 operator_status.go:76] Failed to check operator ibm-auditlogging-operator: the cache is not started, can not read objects
E0414 15:25:54.725908       1 operator_status.go:76] Failed to check operator ibm-platform-api-operator: the cache is not started, can not read objects
E0414 15:25:54.725914       1 operator_status.go:76] Failed to check operator ibm-monitoring-grafana-operator: the cache is not started, can not read objects
E0414 15:25:54.725919       1 operator_status.go:76] Failed to check operator ibm-events-operator: the cache is not started, can not read objects
E0414 15:25:54.725925       1 operator_status.go:76] Failed to check operator ibm-zen-operator: the cache is not started, can not read objects
E0414 15:25:54.725931       1 operator_status.go:76] Failed to check operator ibm-platformui-operator: the cache is not started, can not read objects
E0414 15:25:54.725936       1 operator_status.go:76] Failed to check operator ibm-platformui-operator-v4.0: the cache is not started, can not read objects
E0414 15:25:54.725942       1 operator_status.go:76] Failed to check operator cloud-native-postgresql: the cache is not started, can not read objects
E0414 15:25:54.725948       1 operator_status.go:76] Failed to check operator ibm-user-data-services-operator: the cache is not started, can not read objects
E0414 15:25:54.725954       1 operator_status.go:76] Failed to check operator ibm-zen-cpp-operator: the cache is not started, can not read objects
E0414 15:25:54.725959       1 operator_status.go:76] Failed to check operator ibm-bts-operator: the cache is not started, can not read objects
E0414 15:25:54.725965       1 operator_status.go:76] Failed to check operator ibm-automation-flink: the cache is not started, can not read objects
E0414 15:25:54.725971       1 operator_status.go:76] Failed to check operator ibm-automation-elastic: the cache is not started, can not read objects
2023-04-14T15:25:54.733Z	INFO	controller-runtime.webhook	registering webhook	{"path": "/mutate-ibm-cp-operandrequest"}
2023-04-14T15:25:54.733Z	INFO	controller-runtime.webhook	registering webhook	{"path": "/validating-ibm-commonservice"}
E0414 15:25:54.733628       1 main.go:259] expected pointer, but got invalid kindError setting up webhook server
I0414 15:25:54.733644       1 main.go:275] Starting manager
I0414 15:25:54.733885       1 cache.go:334] Start filtered cache
I0414 15:25:54.733923       1 filtered-cache.go:417] Start filtered cache
2023-04-14T15:25:56.734Z	INFO	starting metrics server	{"path": "/metrics"}
2023-04-14T15:25:56.734Z	INFO	controller.commonservice	Starting EventSource	{"reconciler group": "operator.ibm.com", "reconciler kind": "CommonService", "source": "kind source: /, Kind="}
2023-04-14T15:25:56.734Z	INFO	controller.commonservice	Starting EventSource	{"reconciler group": "operator.ibm.com", "reconciler kind": "CommonService", "source": "kind source: /, Kind="}
2023-04-14T15:25:56.734Z	INFO	controller.commonservice	Starting Controller	{"reconciler group": "operator.ibm.com", "reconciler kind": "CommonService"}
2023-04-14T15:25:56.734Z	INFO	controller.certificaterefresh-controller	Starting EventSource	{"source": "kind source: /, Kind="}
2023-04-14T15:25:56.734Z	INFO	controller.certificaterefresh-controller	Starting Controller
2023-04-14T15:25:56.734Z	INFO	controller-runtime.webhook.webhooks	starting webhook server
2023-04-14T15:25:56.735Z	INFO	controller.addlabel-controller	Starting EventSource	{"source": "kind source: /, Kind="}
2023-04-14T15:25:56.734Z	INFO	controller.podrefresh-controller	Starting EventSource	{"source": "kind source: /, Kind="}
2023-04-14T15:25:56.735Z	INFO	controller.podrefresh-controller	Starting Controller
2023-04-14T15:25:56.735Z	INFO	controller.addlabel-controller	Starting Controller
2023-04-14T15:25:56.735Z	INFO	controller-runtime.certwatcher	Updated current TLS certificate
2023-04-14T15:25:56.736Z	INFO	controller-runtime.webhook	serving webhook server	{"host": "", "port": 8443}
2023-04-14T15:25:56.736Z	INFO	controller-runtime.certwatcher	Starting certificate watcher
2023-04-14T15:25:58.737Z	INFO	controller.certificaterefresh-controller	Starting workers	{"worker count": 1}
2023-04-14T15:25:58.737Z	INFO	controller.certificaterefresh-controller	Reconciling CertificateRefresh	{"name": "cs-ca-certificate-secret", "namespace": "ibm-common-services", "req.Namespace": "ibm-common-services", "req.Name": "cs-ca-certificate-secret"}
2023-04-14T15:25:58.737Z	INFO	controller.certificaterefresh-controller	Certificate Secret is a CA, its leaf should be refreshed	{"name": "cs-ca-certificate-secret", "namespace": "ibm-common-services", "Secret.Name": "cs-ca-certificate-secret", "Secret.Namespace": "ibm-common-services"}
2023-04-14T15:25:58.837Z	INFO	controller.addlabel-controller	Starting workers	{"worker count": 1}
2023-04-14T15:25:58.837Z	INFO	controller.addlabel-controller	Reconciling CertificateRefresh	{"name": "cs-ca-certificate", "namespace": "ibm-common-services", "req.Namespace": "ibm-common-services", "req.Name": "cs-ca-certificate"}
2023-04-14T15:25:58.837Z	INFO	controller.certificaterefresh-controller	All leaf certificates refreshed for	{"name": "cs-ca-certificate-secret", "namespace": "ibm-common-services", "Secret.Name": "cs-ca-certificate-secret", "Secret.Namespace": "ibm-common-services"}
2023-04-14T15:25:58.837Z	INFO	controller.certificaterefresh-controller	Reconciling CertificateRefresh	{"name": "cs-webhook-cert-secret", "namespace": "ibm-common-services", "req.Namespace": "ibm-common-services", "req.Name": "cs-webhook-cert-secret"}
2023-04-14T15:25:58.837Z	INFO	controller.certificaterefresh-controller	Certificate Secret is a CA, its leaf should be refreshed	{"name": "cs-webhook-cert-secret", "namespace": "ibm-common-services", "Secret.Name": "cs-webhook-cert-secret", "Secret.Namespace": "ibm-common-services"}
2023-04-14T15:25:58.837Z	INFO	controller.certificaterefresh-controller	All leaf certificates refreshed for	{"name": "cs-webhook-cert-secret", "namespace": "ibm-common-services", "Secret.Name": "cs-webhook-cert-secret", "Secret.Namespace": "ibm-common-services"}
2023-04-14T15:25:58.837Z	INFO	controller.commonservice	Starting workers	{"reconciler group": "operator.ibm.com", "reconciler kind": "CommonService", "worker count": 1}
I0414 15:25:58.837934       1 commonservice_controller.go:67] Reconciling CommonService: ibm-common-services/common-service
2023-04-14T15:25:58.838Z	INFO	controller.podrefresh-controller	Starting workers	{"worker count": 1}
2023-04-14T15:25:58.843Z	INFO	controller.addlabel-controller	Reconciling CertificateRefresh	{"name": "cs-webhook-certificate", "namespace": "ibm-common-services", "req.Namespace": "ibm-common-services", "req.Name": "cs-webhook-certificate"}
I0414 15:25:58.864455       1 util.go:348] StorageClass Number: 0
W0414 15:25:58.864479       1 util.go:351] StorageClass is not found, which might be required by CloudPak services, please refer to CloudPak's documentation for prerequisites.
I0414 15:25:58.868003       1 init.go:202] Checking if OperandRegistry and OperandConfig CRD already exist
I0414 15:25:59.918822       1 request.go:665] Waited for 1.046666933s due to client-side throttling, not priority and fairness, request: GET:https://172.30.0.1:443/apis/autoscaling.openshift.io/v1beta1?timeout=32s
I0414 15:26:05.270812       1 init.go:209] Installing/Updating OperandRegistry
I0414 15:26:05.279107       1 init.go:643] Updating resource with name: common-service, namespace: ibm-common-services, kind: OperandRegistry, apiversion: operator.ibm.com/v1alpha1
I0414 15:26:05.279140       1 init.go:214] Installing/Updating OperandConfig
I0414 15:26:05.290474       1 init.go:220] Installing ODLM Operator
I0414 15:26:05.294852       1 init.go:458] Fetch Subscription: ibm-common-services/operand-deployment-lifecycle-manager-app
I0414 15:26:09.954609       1 request.go:665] Waited for 2.196681459s due to client-side throttling, not priority and fairness, request: GET:https://172.30.0.1:443/apis/route.openshift.io/v1?timeout=32s
I0414 15:26:10.206460       1 init.go:233] Checking OperandRegistry and OperandConfig deployment status
I0414 15:26:10.408016       1 init.go:238] Installing/Updating OperandRegistry
I0414 15:26:10.415883       1 init.go:643] Updating resource with name: common-service, namespace: ibm-common-services, kind: OperandRegistry, apiversion: operator.ibm.com/v1alpha1
I0414 15:26:10.415928       1 init.go:243] Installing/Updating OperandConfig
I0414 15:26:10.432695       1 init.go:1023] Deploying Cert Manager CRs
I0414 15:26:19.990328       1 request.go:665] Waited for 2.197192585s due to client-side throttling, not priority and fairness, request: GET:https://172.30.0.1:443/apis/certificates.k8s.io/v1?timeout=32s
I0414 15:26:22.716554       1 operator_webhooks.go:182] Reconciling common service webhook service
I0414 15:26:22.817085       1 operator_webhooks.go:207] Creating common service webhook service
I0414 15:26:22.823948       1 operator_webhooks.go:170] Reconciling webhook ibm-operandrequest-webhook-configuration-ibm-common-services
I0414 15:26:22.833359       1 webhookreconciler.go:132] Creating/Updating MutatingWebhook ibm-operandrequest-webhook-configuration-ibm-common-services
I0414 15:26:22.844949       1 operator_webhooks.go:170] Reconciling webhook ibm-common-service-validating-webhook-ibm-common-services
I0414 15:26:22.849264       1 webhookreconciler.go:205] Creating/Updating ValidatingWebhook ibm-common-service-validating-webhook-ibm-common-services
I0414 15:26:22.864995       1 render_template.go:69] Applying multipleInstancesEnabled configuration
I0414 15:26:22.865157       1 render_template.go:104] Applying size configuration
I0414 15:26:22.878024       1 render_template.go:69] Applying multipleInstancesEnabled configuration
I0414 15:26:22.878140       1 render_template.go:104] Applying size configuration
2023-04-14T15:26:22.893Z	DEBUG	events	Normal	{"object": {"kind":"CommonService","namespace":"ibm-common-services","name":"common-service","uid":"73797494-9552-4161-ab9f-6530928ad965","apiVersion":"operator.ibm.com/v3","resourceVersion":"411598"}, "reason": "Noeffect", "message": "No update, resource sizings in the OperandConfig ibm-common-services/common-service are larger than the profile from CommonService CR ibm-common-services/common-service"}
I0414 15:26:22.898086       1 commonservice_controller.go:206] Finished reconciling CommonService: ibm-common-services/common-service
I0414 15:27:55.794383       1 request.go:665] Waited for 1.047220961s due to client-side throttling, not priority and fairness, request: GET:https://172.30.0.1:443/apis/performance.openshift.io/v2?timeout=32s
2023-04-14T15:28:34.319Z	DEBUG	controller-runtime.webhook.webhooks	received request	{"webhook": "/validating-ibm-commonservice", "UID": "d4338ac0-c806-4639-a6aa-b38d52975526", "kind": "operator.ibm.com/v3, Kind=CommonService", "resource": {"group":"operator.ibm.com","version":"v3","resource":"commonservices"}}
I0414 15:28:34.319818       1 validatingwebhook.go:47] Webhook is invoked by Commonservice ibm-common-services/common-service
2023-04-14T15:28:34.320Z	DEBUG	controller-runtime.webhook.webhooks	wrote response	{"webhook": "/validating-ibm-commonservice", "code": 403, "reason": "Operator Namespace: kube-public should be one of WATCH_NAMESPACE", "UID": "d4338ac0-c806-4639-a6aa-b38d52975526", "allowed": false}
I0414 15:29:58.271086       1 request.go:665] Waited for 1.046543871s due to client-side throttling, not priority and fairness, request: GET:https://172.30.0.1:443/apis/apiserver.openshift.io/v1?timeout=32s

@qpdpQ
I think that we are talking about following error
E0414 15:25:54.725971       1 operator_status.go:76] Failed to check operator ibm-automation-elastic: the cache is not started, can not read objects

I think this is expected. operator_status.go is an additional go routine that consistently checks operator deployment status.
However, it relies on operator controller's cache to be ready. It will only be ready when Manager is set up.
So we could see that when manager is not ready, it failed to read object from cache. And the error msg disappear after controller is up and running.

We could do additional enhancement to fill the time gap between status check and manager setup.
But this would be a different task. Please feel free to open an ticket to track that

track this issue in this ticket: https://github.ibm.com/IBMPrivateCloud/roadmap/issues/58246

authors: Daniel-Fan qpdpQ

repo: IBM/ibm-common-service-operator


text:
Monitoring version bumup for 3.19.14/3.23.6

https://github.ibm.com/IBMPrivateCloud/roadmap/issues/59614

/lgtm

source: gharchive/pull-request

repo: IBM/ibm-grafana-ocpthanos-proxy

license_type: permissive

license_source: github-api


text:
NCA fails to read pod list from a live cluster

When NCA runs kubectl get pod -o=json --all-namespaces k8s returns a resource of type List.
However, the code in PeerContainer.add_eps_from_list() checks for type PodList and will not add any peers from the resource it got from K8s.

We should probably support both List and PodList. The first is returned by kubectl. The latter is returned in the REST API replies.

source: gharchive/issue

repo: IBM/network-config-analyzer


text:
fix: refine validation rules as part of pre-1.0 work (group 10) (#551)

PR summary
This commit covers the following rules:

ibm-property-consistent-name-and-type
ibm-ref-pattern
ibm-requestbody-name-exists
ibm-requestbody-is-object
ibm-error-response-schemas
ibm-response-example-exists
ibm-response-status-codes
ibm-schema-description-exists
ibm-schema-type-exists
ibm-securityscheme-attributes
ibm-securityschemes
ibm-server-variable-default-vault
ibm-unused-tags
ibm-valid-path-segments
ibm-schema-type-format

PR Checklist
General checklist
Please make sure that your PR fulfills the following requirements:

[x] The commit message follows the Angular Commit Message Guidelines.
[x] Tests for the changes have been added (for bug fixes / features)
[x] Docs have been added / updated (for bug fixes / features)
[ ] Dependencies have been updated as needed
[ ] .secrets.baseline updated as needed?

Checklist for adding a new validation rule:

[ ] Added new validation rule definition (packages/ruleset/src/rules/*.js, index.js)
[ ] If necessary, added new validation rule implementation (packages/ruleset/src/functions/*.js, updated index.js)
[ ] Added new rule to default configuration (packages/ruleset/src/ibm-oas.js)
[ ] Added tests for new rule (packages/ruleset/test/*.test.js)
[ ] Added docs for new rule (docs/ibm-cloud-rules.md)

:tada: This PR is included in version 0.0.2-rc.1 :tada:
The release is available on npm package (@v1-rc dist-tag)
Your semantic-release bot :package::rocket:

authors: ibm-devx-sdk padamstx

repo: IBM/openapi-validator


text:
Minor fix on string #190 (proposal)

It is ok on string #200: (...) we use the a simple Python transform (...) I wonder: "the a simple Python" is right?

@kant i removed the in your second comment

authors: kant stevemart

repo: IBM/pixiedust-traffic-analysis


text:
test: add tests re: date-time marshalling/unmarshalling

Fixes arf/planning-sdk-squad#2313
This commit adds new tests for the datetime_to_string and
string_to_datetime functions to ensure that each of the required
date-time formats are supported.  These new tests are aligned
with similar tests in the Java and Go cores.
Edit: I originally included a change to datetime_to_string() to use only milliseconds precision when marshalling a datetime value, but it turns out that the python versions we build with on Travis do not support the use of the "timespec" parameter on the datetime.isoformat() function.   So, I'll leave datetime_to_string() alone for now and it will continue to produce strings with microsecond precision, which leaves us no worse off than we were before.   But the addition of the new tests should provide us with some confidence that we support the same formats of datetime values as in the Java and Go cores.

:tada: This PR is included in version 3.3.2 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

authors: ibm-devx-automation padamstx

repo: IBM/python-sdk-core


text:
There is a Flaky test in CI

Problem Description
I am seeing ##[error]    TestAsyncProducerRecoveryWithRetriesDisabled/non-retriable_error: async_producer_test.go:50: kafka: client has run out of available brokers to talk to (Is your cluster reachable?) error in bunch of CI failures. It is a flaky test and need to be looked into. Any idea? if not, I will look into it.
@bai  @dnwe @d1egoaz

This has been fixed and is no longer a flakey test

repo: IBM/sarama

license: MIT


text:
fix(Security Vulnerabilities): fixing dependabot reported security vulnerabilities

PR summary

PR Checklist
Please make sure that your PR fulfills the following requirements:

[x] The commit message follows the Angular Commit Message Guidelines.
[x] Tests for the changes have been added (for bug fixes / features)
[x] Docs have been added / updated (for bug fixes / features)

Current vs new behavior

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

:tada: This PR is included in version 2.0.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

repo: IBM/scc-node-sdk


text:
global update tools images - for tools need tests

Signed-off-by: Xinchun Liu xcliu@ca.ibm.com
What this PR does / why we need it:
trying to update for the tools image build itself, we need wait after the other operators to work before validate this one
/cc @ashank07  @pgodowski

do not label lgtm when approve, I will need to do active test on Friday when everything else works good

/lgtm

repo: IBM/test-infra


text:
rename dev-resources to data

the name "dev resources" is mis-leading, this is data that is required to make the app run.

merged folder name change with master.

authors: sauravraiguru stevemart

repo: IBM/watson-banking-chatbot


text:
Heterogeneous Environment Support

The code changes were made to support Heterogeneous Environment for DataSets.
i.e if there are no GPU(s) present or if GPU has not been enabled then the code execution will fallback to CPU.

Fixed the below stack
java.lang.AssertionError: assertion failed
at scala.Predef$.assert(Predef.scala:156)
at com.ibm.gpuenabler.MAPGPUExec$$anonfun$doExecute$1.apply(CUDADSUtils.scala:131)
at com.ibm.gpuenabler.MAPGPUExec$$anonfun$doExecute$1.apply(CUDADSUtils.scala:73)
at org.apache.spark.rdd.RDD$$anonfun$mapPartitionsWithIndex$1$$anonfun$apply$26.apply(RDD.scala:843)
at org.apache.spark.rdd.RDD$$anonfun$mapPartitionsWithIndex$1$$anonfun$apply$26.apply(RDD.scala:843)
at org.apache.spark.rdd.MapPartitionsRDD.compute(MapPartitionsRDD.scala:38)
at org.apache.spark.rdd.RDD.computeOrReadCheckpoint(RDD.scala:323)
at org.apache.spark.rdd.RDD.iterator(RDD.scala:287)
at org.apache.spark.rdd.MapPartitionsRDD.compute(MapPartitionsRDD.scala:38)
at org.apache.spark.rdd.RDD.computeOrReadCheckpoint(RDD.scala:323)
at org.apache.spark.rdd.RDD.iterator(RDD.scala:287)
at org.apache.spark.rdd.MapPartitionsRDD.compute(MapPartitionsRDD.scala:38)
at org.apache.spark.rdd.RDD.computeOrReadCheckpoint(RDD.scala:323)
at org.apache.spark.rdd.RDD.iterator(RDD.scala:287)
at org.apache.spark.scheduler.ResultTask.runTask(ResultTask.scala:87)
at org.apache.spark.scheduler.Task.run(Task.scala:99)
at org.apache.spark.executor.Executor$TaskRunner.run(Executor.scala:282)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748)

repo: IBMSparkGPU/GPUEnabler

license_source: bigquery


text:
testPacketContentAssemblerFlowsAndFiles.sh failed due to missing file

21 Jun 2018 06:31:20.351+0000 [17538] INFO #splapptrc,J[0],P[0],PacketStream,PacketFileSource M[PacketStream.cpp:processPCAPfile:171]  - opening PCAP file '/mnt/scratch/data.garanti-bank/Ayca_Test_wireshark.pcap'
21 Jun 2018 06:31:20.354+0000 [17538] ERROR #splapptrc,J[0],P[0],PacketStream,#splapptrc,J[0],P[0],PacketStream,spl_operator M[PEImpl.cpp:handleOperatorFailure:661]  - CDISR5030E: An exception occurred during the execution of the PacketStream operator. The exception is: error opening PCAP file '/mnt/scratch/data.garanti-bank/Ayca_Test_wireshark.pcap', /mnt/scratch/data.garanti-bank/Ayca_Test_wireshark.pcap: No such file or directory

test script must not reference files that are not part of test environment


text:
Once something is public nothing in SBOL namespace can be changed

Anything outside SBOL namespace can be changed freely after publication on SynBioHub, but anything in SBOL namespace cannot be changed without creating a new version.

All the edits of public parts must occur on SynBioHub with security as to who can edit the part and what fields can be edited.

Not exactly an issue but rather a policy.  We likely will be even stricter than this.  There are now three mutable fields (mutable{description,notes,provenance}).  Others like citations likely will be added, but for now these are added on case-by-case basis.  This issue is not really needed, but simply the policy consider if new requests are made for edit capability.


text:
Get info about Train Stations

As a user I want to know which train stations the train stops:
Acceptence criteria:
When a user asks for example: "Welche Stationen gibt es?" he want's to recieve an answer like:
Folgende Stationen gibt es auf der Strecke:
Basel SBB, Basel Bad Bf, Freiburg(Breisgau) Hbf, Offenburg, Karlsruhe Hbf, Mannheim Hbf, Frankfurt(M) Flughafen Fernbf, Siegburg/Bonn, Köln Hbf,
Düsseldorf Hbf, Duisburg Hbf, Oberhausen Hbf, Arnhem Centraal, Utrecht Centraal, Amsterdam Centraal

haben wir doch schon lange fertig oder? @cma5

Stimmt, das ham wir fertig! Ich schließ es gleich mal.

haben wir doch schon lange fertig oder? @cma5


text:
Yourwallet

Yourwallet - helps you manage all your passes with ease.
Download it now: http://play.google.com/store/apps/details?id=eu.yourpass.wallet

#396

#395

repo: IDEA-Research/Grounded-Segment-Anything


text:
请问训练的参数在哪个文件

您好，在执行python tools/train_net.py 指令时，会指定--config-file  但是我并没有在train_net.py中找到这些参数，请问在哪个文件里面呢？
因为我在中断训练之后想继续训练，但是我找不到参数的文件在哪里

你好，请问您解决这个问题了吗

repo: IDEA-Research/detrex


text:
🛑 Org 10W Laser is down

In 4677d68, Org 10W Laser (https://snapmaker.com/snapmaker-10w-laser-module) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Org 10W Laser is back up in 2174bcb.

repo: IDKHTS/upptime-demo


text:
Same reference entry in OPF  ignored.

From jens.tro...@gmail.com on August 21, 2013 12:10:29
PROBLEM: I am not sure if this is a problem at all, or if this can be ignored.  Couldn't find anything mentioned in the standard.  The "problem" occurred for me when I generated a EPUB using a script of mine with a bug, and that resulted in generating a OPF guide element with the same reference entry multiple times:
  <guide>
    <reference type="cover" title="Cover Page" href="cover.html" />
    <reference type="start" title="Start Page" href="cover.html" />
    <reference type="start" title="Start Page" href="cover.html" />
    <reference type="start" title="Start Page" href="cover.html" />
    <reference type="start" title="Start Page" href="cover.html" />
  </guide>

There was no warning that this had occurred.
METHOD: What steps will reproduce the problem?

Attached EPUB contains a document which validates using epubcheck 3.0.1
Unpack it, take a look at OEBPS/content.opf
Behold multiple entries.

RESULT: Nothing.
EXPECTED: A warning would have made sense, but I am not sure if one would be justified.
PLATFORM: Latest epubcheck 3.0.1 on Mac.
java version "1.6.0_51"
Java(TM) SE Runtime Environment (build 1.6.0_51-b11-456-10M4508)
Java HotSpot(TM) Client VM (build 20.51-b01-456, mixed mode)

ADDITIONAL INFO: Attached is a test EPUB.
Attachment: test.epub
Original issue: http://code.google.com/p/epubcheck/issues/detail?id=299

Not sure if it helps, but duplicate references to the same document/fragment was made an error in 3.1 for the landmarks nav. An info message for 2.0 seems appropriate.

Thanks for the review, Matt! Adding the "missing" and "epub-3.1" labels.
/cc @jenstroeger (original author)

Thanks @tofi86 for adding me! 👍

So guide and landmark duplicated are already checked since #738 (by @tofi86).
For EPUB 3.2, we just need to report landmark duplicates as ERROR instead of WARNING.

authors: jenstroeger mattgarrish rdeltour tofi86

repo: IDPF/epubcheck

license: mit


text:
🛑 IDR 2858266 is down

In a68d600, IDR 2858266 (https://idr.openmicroscopy.org/webclient/?show=image-2858266) was down:

HTTP code: 0
Response time: 0 ms

Resolved: IDR 2858266 is back up in 83090c1 after 26 minutes.

repo: IDR/upptime


text:
🛑 IDR (image 3063667) is down

In 0de09b0, IDR (image 3063667) (https://idr.openmicroscopy.org/webclient/?show=image-3063667) was down:

HTTP code: 502
Response time: 108 ms

Resolved: IDR (image 3063667) is back up in bbcf8c4 after 15 minutes.


text:
🛑 IDR (image 820684) is down

In e8cb128, IDR (image 820684) (https://idr.openmicroscopy.org/webclient/?show=image-820684) was down:

HTTP code: 502
Response time: 106 ms

Resolved: IDR (image 820684) is back up in 47c7c44 after 9 minutes.


text:
print_config not working

It seems like the internal interface of pprint changed with some python version. With python 3.8, calling an experiment with print_config results in the error:
Exception originated from within Sacred.
Traceback (most recent calls):
  File ".../python3.8/site-packages/sacred/commands.py", line 61, in _non_unicode_repr
    repr_string, isreadable, isrecursive = pprint._safe_repr(
TypeError: _safe_repr() missing 1 required positional argument: 'sort_dicts'

This bug was already fixed in #719, so it is working with the current master. Can we have a new version pushed to pypi so that the official version works with python 3.8?

same here.

The new version is on PyPIa, so it should be working now!

authors: mdolgich thequilo

repo: IDSIA/sacred


text:
BUG: Updates scaffold with config_hook return value

Fixes #326

I have to say: I am quite impressed. You are fixing bugs in some of the most difficult parts of the codebase. Thanks a lot for your effort!

authors: Qwlouse thomasjpfan


text:
chore(main): release 1.0.1

:robot: I have created a release beep boop
1.0.1 (2024-08-14)
Documentation

update index.rst (f7967ad)

This PR was generated with Release Please. See documentation.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 92.51%. Comparing base (f7967ad) to head (1192a7c).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #58   +/-   ##
=======================================
  Coverage   92.51%   92.51%
=======================================
  Files          11       11
  Lines         775      775
=======================================
  Hits          717      717
  Misses         58       58

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

authors: codecov-commenter judithspd

repo: IFCA-Advanced-Computing/anjana


text:
pod install does not work for example.

I get the following error:
pod install
[!] Invalid Podfile file: [!] Unsupported options {:exclusive=>true} for target JotDemo..
from /Users/todd/Desktop/Project_Source/Open_Source_Projects/jot/Example/Podfile:11
-------------------------------------------

target 'JotDemo', :exclusive => true do

install_pods
-------------------------------------------
[!] xcodeproj was renamed to project. Please use that from now on.

This should be fixed by https://github.com/IFTTT/jot/pull/15. Please pull and try again.

authors: maxmeyers toddfreese

repo: IFTTT/jot


text:
The training crashes

Dear authors, thank you for sharing your codes for the community, I have a question about the model training, is it nomarl that the model crashes during the training, as I tried to reproduct the model on derain and desnow datasets, but during certain iters, as 800000, the visual results shows like pure noise or pure black. Should I wait more iters or is there any error in my reproduction? Thank you very much

I've verified that the black patch shows when the loss is NAN

hey there can you help me to setup this code locally as i am not able to find datasets and .txt files?

hey there can you help me to setup this code locally as i am not able to find datasets and .txt files?

you can find the .txt files from #10

authors: Holly-Max Kushpatel49 OwEnXiaoMing OwXiaoM

repo: IGITUGraz/WeatherDiffusion


text:
Specify tracing identifiers in AuditEvents

Is your feature request related to a problem? Please describe.
The Swiss national EPR will require the use of the traceparent HTTP header in future REST transactions (and backport it somehow into a SOAP header for the SOAP transactions).
I am looking for a way to integrate that value in the AuditEvents and saw that BALP was already supporting the somewhat similar X-Request-Id header.
Describe the solution you'd like
I am unsure: add a code for traceparent and tracestate in the CodeSystem and ValueSet BasicAuditEntityType, or add a more generic tracing identifier code?
Describe alternatives you've considered
None.
Additional context
Official specifications: https://www.w3.org/TR/trace-context/
The traceparent has a few advantages over X-Request-Id: it is a proper (W3C) specification, it supports flags to negotiate tracing behaviours, and allows for better transaction tracing by providing multiple identifiers: the trace-id (second part in traceparent) is constant for a given transaction, while the parent-id (third part) changes at each HTTP message (request, response). For example:
GET /Patient/$ihe-pix?sourceIdentifier=1 HTTP/1.1
traceparent: 00-0af7651916cd43dd8448eb211c80319c-b7ad6b7169203331-00

200 ok
traceparent: 00-0af7651916cd43dd8448eb211c80319c-00f067aa0ba902b7-00

In the case where the server is acting like an initiating gateway, it can also use the same trace-id to link the transactions together.
The Trace Context specification also defines the tracestate header, which is a vendor-specific header: its value is not standardized, but if support is added for traceparent, tracestate should be supported as well.
Related discussions on Zulip:
https://chat.fhir.org/#narrow/stream/179223-ihe/topic/.E2.9C.94.20Specify.20tracing.20identifiers.20in.20AuditEvents.20.28BALP.29
https://chat.fhir.org/#narrow/stream/179247-Security-and.20Privacy/topic/TraceID's

@qligier  Need to develop CP-ITI-1303 for a CP ballot.

authors: JohnMoehrke qligier


text:
🛑 Pilsudski Katalog Biblioteki is down

In 1517e64, Pilsudski Katalog Biblioteki (http://www.pilsudskilibrary.org) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Pilsudski Katalog Biblioteki is back up in c47637e.

repo: IJPNY/upptime


text:
🛑 Pilsudski Katalog Biblioteki is down

In 4192ed9, Pilsudski Katalog Biblioteki (http://www.pilsudskilibrary.org) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Pilsudski Katalog Biblioteki is back up in 7f129ce.


text:
[BUG] Blank canvas or report templates missing in the version 0.9.3

Is there an existing issue for this?

[X] I have searched the existing issues

Description
I am using the version 0.9.3. When I tried to create a Project, it request to select report but there are no report templates or blank canvas option. I am not able to create the project.
Current Behavior
Blank canvas report template should be available
Expected Behavior
Blank canvas report template is missing. Get the below exception.
Error Loading Templates
An error occured while loading report templates
(Err: Load failed)
Steps To Reproduce

Click Create New Project
Enter all details and click next

Environment
- Operating System and Version: Linux
- AI Verify Version:0.9.3
- Any other relevant information (e.g. version of related package dependencies installed):

Did you build using source code or from docker file? If from source code, please provide the below information:
- Python Version:3.11.5
- Node Version:18
- Redis Version:
- Mongo Version:
- Screen Resolution:

Screenshots/ Code snippets
Not able to upload the error screen. Below is the error -
Error Loading Templates
An error occured while loading report templates
(Err: Load failed)
Additional Context
No response
Possible Solution (Optional)
No response

I found the issue. It looks like due to grapql URL. When I am trying to access the portal from outside the server the web socket URL is still localhost. Looks like I need to change that.

Hi @Ranbazh, thank you for raising this issue to us. May I know which server are you using?

Server is Debian 11. I used the source version for the set up. I think I found the issue and it works now. please let me know how I can document it and help with community.

Hi @Ranbazh, please help us by creating a PR for it. In the description, please include the description of the issue and tag the PR to the relevant GitHub Issue. Do let me know if you require any assistance.

Closing this to be tracked in #169

authors: Ranbazh imda-benedictlee kimeetok

repo: IMDA-BTG/aiverify


text:
Fixed Incorrect Placement of Content-Type Header in API Request. Closes #22

Closes #22
Type of Change

[ ] New Feature
[x] Bug Fix
[ ] Code Refactor
[ ] Documentation Update
[ ] Other (please specify):

Description of Change
Fixed Incorrect Placement of Content-Type Header in API Request
Demo

before

after

very good @Akshat1276 , thank you for submitting, i can see that the commit addresses the issue nicely.

@AyushDharDubey Sir, this is my third accepted PR, but the scores for these PRs is not being reflected in the leaderboard. What is the reason for this?
Thank you sir

Okay sir.
Thank You

repo: IMGIITRoorkee/Ticketify


text:
Update zio, zio-streams, zio-test, ... to 2.0.9

Updates

dev.zio:zio
dev.zio:zio-streams
dev.zio:zio-test
dev.zio:zio-test-sbt

from 2.0.3 to 2.0.9.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "dev.zio" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "dev.zio" }
}]

labels: library-update, early-semver-patch, semver-spec-patch, commit-count:1

Superseded by #194.

repo: INCATools/relation-graph


text:
Code style

Issue #7
If need be, I can squash all of these into one commit.

Nice, did you use a script to do this or did you do it all manually?
Also the only problem I see with this is that it may make current pull requests unable to automatically merge.

I was tempted to write a script for this, but it was all manual.

I've just gone through files changed. Yes, it took a while. Obviously there were a few instances where the codestyle was missed, or blocks of repeated code weren't consistent ( Changing 1 liners to blocks, but not changing them all to blocks ).
As far as I can tell there should be 0 impact on performance. I haven't tested all of SF functionality with these changes, but from inspection none of them modify behaviour, just cosmetics.
Hopefully this won't break any current PR's. :)

It did break current PRs :(

authors: EpicG Jazzelhawk awilliamson

repo: INPStarfall/Starfall


text:
🛑 IOGT CLOUD is down

In 18cc16b, IOGT CLOUD ($CLOUD_SERVER) was down:

HTTP code: 530
Response time: 111 ms

Resolved: IOGT CLOUD is back up in b05ad0b.

repo: IOGT/upptime


text:
feat(arbiter): Add dedicated arbiter module.

Allows cores to use the arbiter module without axi_interconnect (like the iob-eth core).
Due to merge conflicts, this PR should be merged in a new branch or wait for update.

branch created , pls retarget PR

merged in branch arbitr

repo: IObundle/verilog-axi


text:
[wip] package updates

[x] numpy and scipy bump to address @s-good's comments re: https://github.com/scikit-learn-contrib/hdbscan/issues/272 done in 574c6da
[ ] ~rev cotede to 0.21.1, along with any necessary dependencies.~ recommend doing this in a separate PR

[x] oceansdb 0.8.6 -> 0.8.11; done in d613352. Note this causes one of the CoTeDe WOA unit tests to fail, presumably because this rev appears to move from woa13 to woa18 5deg temperature record files. Expected value changed to match by fiat in the unit test in the same commit; @castelao please let us know if a change from 0.8.6 to 0.8.11 should not cause a results change.

There appears to be some non-trivial differences between CoTeDe 0.19.2 and 0.21.1 that come out in the glue script https://github.com/IQuOD/AutoQC/blob/master/cotede_qc/cotede_test.py that allows AutoQC to ingest CoTeDe. Specifically, the config object cfg has a completely different structure, having gone from a dictionary in 0.19.2 to an orderedDict in 0.21.1 which appears to have different keys than the original.
@castelao, can you advise on the mapping between old and new config objects? It's likely just a difference of some key names, but it'll take me a while to tease out the changes myself.
@s-good I would go ahead and merge this PR now, while we assess how to get CoTeDe upgraded; there's no need to block the other package updates on this.

HI @BillMills , yes, OceansDB update will change some results. You're correct, that reflects Tim's update on WOA.
About the CoTeDe config, the new standard should recognize your config as an old standard and fix it in the background. Could you point me to the error message that you get?

The fix_config() should conform your config files into the new standard. It is more than just renaming. The new standard is more explicit, and includes a 'rev' to help to track and fix future changes.
new_standard_config = cotede.utils.config.fix_config(your_dict)
But you shouldn't require to do that yourself. I probably missed something.

@castelao I think the trouble is that AutoQC has some logic hard-coded into it that assumes the config returned by CoTeDe's load_cfg function is the old style, which is not true if we upgrade past 0.19.2. Specifically see https://github.com/IQuOD/AutoQC/blob/master/cotede_qc/cotede_test.py#L49-L68 - this starts with a call to load_cfg which in CoTeDe 0.22.0 returns the new-style config, but the AutoQC code then goes on to treat that config like old-style config, resulting in unit test failures like the one below, which is really just a bunch of keyErrors:
======================================================================
ERROR: Make sure CoTeDe Argo density inversion is working as expected.
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/AutoQC/cotede_qc/cotede_test.py", line 60, in get_qc
    cfg = {var: {test: cfg[var][test]}}
KeyError: 'TEMP'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/AutoQC/cotede_qc/cotede_test.py", line 65, in get_qc
    cfg = {'main': {test: cfg['main'][test]}, var: {'dummy': None}}
KeyError: 'main'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/nose/case.py", line 198, in runTest
    self.test(*self.arg)
  File "/AutoQC/tests/CoTeDe_checks_validation.py", line 33, in test_CoTeDe_Argo_density_inversion
    qc = qctests.CoTeDe_Argo_density_inversion.test(padi, None)
  File "/AutoQC/qctests/CoTeDe_Argo_density_inversion.py", line 10, in test
    qc = get_qc(p, config, testname)
  File "/AutoQC/cotede_qc/cotede_test.py", line 67, in get_qc
    with open('cotede_qc/qc_cfg/' + config + '.json') as f:
FileNotFoundError: [Errno 2] No such file or directory: 'cotede_qc/qc_cfg/argo.json'

So there's work to be done not on CoTeDe but on how AutoQC interprets CoTeDe's config object.

Replaced by #264 and recent CoTeDe work.

Replaced by #264 and recent CoTeDe work.

authors: BillMills castelao

repo: IQuOD/AutoQC


text:
Feature/115 log out button header

Now when logging in, you don't have to hover around and click the button, you can just press enter and it'll all work out!

In this Pr's branch I'll do both the button and everything related to issue #130. Regarding that issue, the avatar isn't shown correctly since it's impossible to access any user's avatar since they're not online nor accessible through the API for now, so it won't load for the moment


text:
As a developer, I want only a specific amount of cheeps to be shown to the client

Acceptance Criteria:

Must not return all the cheeps.
A GET request to the specific number of page shall return only that page to the client.
A GET request with no query parameter for a page shall per default return the first page.

til 1. b


text:
For users, we need to allow them to check out and edit their personal info.

Goal:
Make it so that the users can customize their personal information more.
Key Requirements:

[ ] Add the feature to allow users to change their username and their email (remember to confirm uniqueness with the DB)
[ ] Add the feature to allow users to upload images to display.

Put on hold to focus on more vital parts of the program


text:
#2 fixed an issue with the fragment parsing

I believe the fragment parsing has a bug that breaks the first parameter of the fragment.

Thanks, the bug is fixed in commit  https://github.com/ITfoxtec/ITfoxtec.Identity.BlazorWebAssembly.OpenidConnect/commit/71abff2556c3662e81786c5181ecbff107d67007

Fixed in commit 71abff2

authors: Revsgaard chrsin


text:
🛑 API is down

In 75fdcba, API ($API_ENDPOINT) was down:

HTTP code: 0
Response time: 0 ms

Resolved: API is back up in e7fdef4.

repo: IVAO-Portugal/status-page


text:
🛑 API is down

In a5714d8, API ($API_ENDPOINT) was down:

HTTP code: 0
Response time: 0 ms

Resolved: API is back up in 604a4b4 after 19 minutes.


text:
[2.0.0 nomap] Troubles with scrolling in the timeline

OnePlus CPH2399
Android 13
Gallery 2.0.0 (20070) nomap edition
• When I scroll the images in the timeline they seems to crush and impact each other in a disorderly manner.
For privacy reasons I cannot provide the screenshot.
• Might you adding the nomaps edition in Izzy or fdroid repo too?

Thanks for reporting, it's a slight visual bug that happens only in the album timeline, I'm already aware of it but it's not really a priority right now. The permissions should be reduced from 20079


text:
Smaller cards frames in "Albums" tab

I come from Aves Libre.
Currently design in Gallery has too much big frames, so it needs to scroll up and down to see six albums (cards view).
I ask a little smaller frames (as option).

I will include UI customization such as album sizes later in the Settings!


text:
Codecov.io support

API looks pretty similar to Coveralls, so should be easy enough.

Can you show me an example json coverage output that I can parse server side. Thanks!

We currently just export in the Coveralls.io JSON format. The raw coverage data is in the form of lines where the first 9 columns are a count and the rest is the actual line. This package reads that in, and currently mangles it into Codecov.io's JSON format if its different. It looks mostly the same

https://twitter.com/iaindunning/status/595235822804275201

OK, I have this ALMOST working but I'm still getting HTTP 200 when I try to POST the results to codecov with the repo token included.

Http200 means success - is there a message?

Yeah! I got it to work! I was stupid and didn't refresh the repo... anyway we now have BASE COVERAGE ON CODECOV :tada: :fireworks: I'll submit PRs to you and to CoverageBase with my changes!

Wow neat.
@stevepeak we should be getting a released version soon, and a lot of Julia packages will instantly be able to start using CodeCov.io. BTW, your badge format isn't really the same as the other ones, might need to generate new ones using shield.io?

NB: Right now, submit_token expects that you are NOT running on CI, and scrapes the branch and commit info directly from git. I did that because that's how the Coveralls version works right now too. If people want it some other way I am happy to add more other CI services in!

If you've got any more Coverage.jl time, could you update the README with how to use Codecov instead of Coveralls?

Yes!

There may still be a problem with codecov support. The current HTTP return code is 400, with the message data: ASCIIString "template not found at html/errors/400.html" (see the build reports of travis: https://travis-ci.org/IainNZ/Coverage.jl/jobs/69379891). Also the codecov summary page does not show new commits, the last one shown is two months old: https://codecov.io/github/IainNZ/Coverage.jl.

authors: IainNZ julian-gehring kshyatt stevepeak


text:
unable to find packages

getting error
Error occurred while restoring NuGet packages: Unable to load the service index for source https://dotnet.myget.org/F/uwpcommunitytoolkit/api/v3/index.json.
[uwpcommunitytoolkit] Unable to load the service index for source https://dotnet.myget.org/F/uwpcommunitytoolkit/api/v3/index.json.
  Response status code does not indicate success: 404 (Feed does not exist.).

Closing this issue as the project is being archived.

Closing this issue as the project is being archived.

authors: IanSavchenko nitinjs

repo: IanSavchenko/BleLab


text:
fix: add hover effects to button as updated by designers

Some buttons on the website do not have a hover effect but hover effects have been added to them on the design. Here the samples below from figma.
1

2

3

.take

repo: Ibadan-Techies/badtechies


text:
[New App] Threadfin

App Information
Name: Threadfin
Short Description: M3U Proxy for Plex DVR and Emby/Jellyfin Live TV. Based on xTeVe
Official Website: https://github.com/Threadfin/Threadfin
Docker Image: https://hub.docker.com/r/fyb3roptik/threadfin
Closes #210

Sorry for the late validation of your pull request, thanks for your submitting it. I'll add two default env parameters for easier installation.
environment: THREADFIN_BRANCH=main
- THREADFIN_BRANCH=main
- THREADFIN_DEBUG=0

repo: IceWhaleTech/CasaOS-AppStore


text:
Authentication for subdomains

Hello,
I'm writing a multi-tenant SPA, where tenants are identified by subdomains.
I don't want to whitelist each subdomain at the Identity Provider.
I use both silent login, and redirects, and I hoped to be able to make the return_uri a single location (the higher domain), and then pass the token to the original pages (so the browser would eventually remain in the original subdomain).

In silent login, the callback window.parent.postMessage() is hardcoded forcing the frame and container to have the same origin.
In both silent login and redirects, the state is in fact kept in local storage instead of being routed through the request - also preventing access to state data between the two domains.

The way I see it, allowing state to go to the Identity Provider instead of keeping state locally would really help in such a case.
Is this limitation a security consideration or a bug?
If this is by design, could you recommend the proper way to work in this case?
Thanks.

The way I see it, allowing state to go to the Identity Provider instead of keeping state locally would really help in such a case.

But that's not terribly secure, as there's no way to validate it upon return. So this was by design.
As for the cross-origin callbacks, I don't know... I'd have to think about it. It adds complexity, which possibly hurts the security of the library.

But that's not terribly secure, as there's no way to validate it upon return. So this was by design
I guess one can always sign the state, instead of just using the state key as a nonce. I understand that this may also add too much complexity. I'm thinking about implementing this approach as a private implementation of StateStorage.

As for the cross-origin callbacks, I don't know... I'd have to think about it. It adds complexity, which possibly hurts the security of the library.
Yeah, and it only solves the silent login, not the redirect...

Someone recently submitted a PR for the cross-origin feature, but it was too complex for me to digest in one sitting.

I stand corrected about the state - I reread the OIDC spec (3.2.2.5) and saw that

Clients MUST verify that the state value is equal to the value of state parameter in the Authorization Request

I'm considering working around the issue by setting a cross-domain cookie to let the callback page know where to redirect the token. Does this seem legitimate to you or does it defeat the purpose of the whitelist?

Not sure, I'd have to spend time to threat model that.
In any event, I'll close this issue for now. If you still have issues, feel free to reopen.

Thanks. As it happens, a consultant ended advising that I whitelist each subdomain individually and not bother with creative code solutions for this problem.

authors: brockallen gilknyaz

repo: IdentityModel/oidc-client-js


text:
Sample code using response_mode shows error in typescript

From the sample: http://docs.identityserver.io/en/latest/quickstarts/6_javascript_client.html
new Oidc.UserManager({response_mode:"query"}).signinRedirectCallback().then(function() {
window.location = "index.html";
}).catch(function(e) {
console.error(e);
});
Typescript gives a error that 'response_mode' is not part of Oidc.UserManagerSettings.
It does seem to work by ignoring this error, but it'd be nice to be including in the definitions.

Feel free to add it and submit a PR.

It appears to be part of the base class already in index.d.ts and after updating to the latest client it appears to be resolved. Perhaps an issue in my local environment.

authors: brockallen fuzzzerd


text:
OIDC silent renew giving error : "TypeError: Cannot read property 'message' of undefined"

userManager.signinSilent() method is throwing the below error when we are trying to renew the token.
Error : TypeError: Cannot read property 'message' of undefined
Can you please help us fixing it?
export const SilentRedirectToLogin = async () => {
        const state = store.getState();
        let user = state && state.oidc && state.oidc.user;

     if (!user || user.expired) {

           return await userManager.signinSilent().catch(response => {
           throw response.error;

        });
    } else {
                 return user;
              }
    };

Sorry, did you ever sort this out?

Yes, it got sorted. The issue was nothing to do with the package.
Browser cookie creation through third party applications was disabled by my organization browser policy. Hence the package was not sending the cookies to OIDC provider. Therefore the error.
Thanks
Rahul


text:
Cake cannot find build.cake

Issue / Steps to reproduce the problem
Downloaded the latest release version, then used Powershell (as administrator) to execute the 'build.ps1' file.
Running the build.ps1 fails.
Relevant parts of the log file
Cake.exe : Error: Could not find script 'C:/IdentityServer4/tools/build.cake'.
At line:1 char:1
+ & "C:\IdentityServer4\tools\Cake\Cake.exe" "build.cake" -target="Defa ...
+ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : NotSpecified: (Error: Could no...ls/build.cake'.:String) [], RemoteException
    + FullyQualifiedErrorId : NativeCommandError

Conclusion
Apparently cake doesn't seem to be able to find the build.cake file. Seeing how Cake probably looks for it in its own folder (tools), that is correct, as build.cake is located in the root.
Moving the build.cake to the tools-folder does not work, as it then fails at a different point.
Giving a path to the parameter does the trick though:
Invoke-Expression "& `"$CAKE_EXE`" `"C:\IdentityServer4\$Script`" -target=`"$Target`" -configuration=`"$Configuration`" -verbosity=`"$Verbosity`" $UseMono $UseDryRun $UseExperimental $ScriptArgs"

working for me. @leastprivilege do we expect anything else installed on the machine (i forget).


text:
grant type invalid !

im using EntityFramework.Storage in  my db grant type is credential and password
when request grant type is credential all its ok when change to password show error invalid grant type
how resolve this

not enough information.


text:
Support for public clients

Public clients don't need a client secret to request tokens from the token endpoint

Hi @leastprivilege, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla2.dotnetfoundation.org.

TTYL, DNFBOT;

@brockallen please review

@leastprivilege, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.
Thanks, DNFBOT;

:shipit:

authors: brockallen dnfclas leastprivilege


text:
Request #b210ee0

Original: "Ground Commercial"
Your request: Ground Commercial
Terrain commercial
ou Raison commerciale

Retenu: Raison commerciale

authors: Imaginaerum abbroderies


text:
Improve reproducibility of the workflows

[ ] instead of pulling the latest docker images, we should use SHA, and ideally tags, to ensure the same version of the image is used
[ ] workflows currently refer to the notebooks from "main" branch; instead we should use git tags and refer to tagged notebooks
[ ] parameterize papermill with the variable to pass the tag, and refer to the tagged versions of the artifacts from the notebook
[ ] remove all branches from the repository so that the users of Dockstore are not confused
[ ] before running the analysis, create a new release/tag, and use the specific Dockstore workflow releases for the run

We can also consider encoding the specific version of the workflow in the SEG/SR objects created, but I want to discuss this with David C first.

workflows currently refer to the notebooks from "main" branch; instead we should use git tags and refer to tagged notebooks
parameterize papermill with the variable to pass the tag, and refer to the tagged versions of the artifacts from the notebook

@vkt1414 I thought about this, and here's how I think we could do it:

for non-tagged releases, just use "main"
whenever we want to have a tagged release, rewrite all URLs to substitute "main" with the planned tag name, make a commit, and then tag that commit with the name that was used during rewriting URLs.
on the following commit after the tagged one, rewrite the URLs again to use "main"
instead of checking out individual artifacts from URLs in the notebooks, add a variable that would be initialized to "main" or tag name at the top of the notebook, check out the entire repository using main or tag, and refer to the files from the checked out repository tree in the following cells. This way we can get a bit close to versioning notebooks when they are executed outside of papermill.

If you have better ideas, let's discuss here before implementing!

I do not have a complete plan yet but two things worry about the workflow you suggested.
We use URLs at a lot of places. Links to image sources and config files in notebooks, and links to the notebooks in the wdl and cwl files. Chaning them manually I think poses a lot of room for errors, especially when I revisit the repo after a few months of no activity.
Secondly, I'm wary about cloning the entire git repo as we will be running thousands of workflows in parallel and that would mean we rely even more on github. We never faced an issue so far with individual artifacts but I do not think it may be a good idea.
What I have in mind currently is to use a github action that can take care of updating the branch/tag references. We already have bits and pieces of this in several repos now (idc-index, browser, and tutorials) and it should not take a while to come up with one.
The gha should recognize tag and run a python script that will use a regex express to identify main branch and replace them with the tag. Otherwise, we always refer to main branch as you also suggested.
What are your thoughts?

Chaning them manually I think poses a lot of room for errors

I agree - I didn't mean to do it manually, it can be done with a script.

What I have in mind currently is to use a github action that can take care of updating the branch/tag references. We already have bits and pieces of this in several repos now (idc-index, browser, and tutorials) and it should not take a while to come up with one.

For this kind of tasks, I think it is easier to have a script that can be run locally, and then whoever ran it an easily review all the changes and confirm that modifications make sense.


text:
Add analysis notebook using MCMICRO

This notebook covers an example of image analysis using fluorescence WSI data from IDC as input to MCMICRO. Some caveats include:

Nextflow and Docker need to be installed, as they are requirements for running MCMICRO. To my knowledge, Docker cannot be used within Google Colab, so these notebooks must be downloaded and run locally.
As noted in https://github.com/ImagingDataCommons/IDC-Tutorials/pull/67 commands like wget will not work on Windows, so some sections may need alternatives provided.
MCMICRO does not appear to support DICOM as input, given the expectations for multi-file filesets https://mcmicro.org/troubleshooting/faq.html#q-mcmicro-doesnt-seem-to-recognize-my-file-format-how-do-i-tell-it-what-files-to-look-for For this reason, the IDC DICOM data was converted to OME-TIFF before running the analysis. This has the advantage of optionally cropping the analysis input for quick testing.

Note that the markers.csv and params.yml files needed for MCMICRO analysis are included in this PR as well.
cc @melissalinkert @dclunie @fedorov

@DanielaSchacherer thank you for the review!
@erindiel I am working on my review, and adding some small features to idc-index to help simplify some steps. I will follow up shortly.

As an update to what I had to adapt in the code: I had to manually create the folder /raw in MCMICRO-example-IDC/OME-TIFF and move markers.csv into MCMICRO-example-IDC/OME-TIFF. I guess that's not something I was supposed to do, is it?

authors: DanielaSchacherer erindiel fedorov

repo: ImagingDataCommons/IDC-Tutorials


text:
Error when submitting raw arxiv ID

Software throws an error when an arxiv ID is submitted without 'arxiv:' in front of it. Example input is 1802.02689.

Fixed with 98ca891. API now recognizes the ID format and adds 'arxiv:' to the string.

repo: Impactstory/citeas-api


text:
The map K_v to prod_{w|v} L_w is continuous

#235 says that K_v -> L_w is continuous and this should be easy from that.

This is continuous_pi (fun w ↦ (adicCompletionComapAlgHom A K L B v _ w.2).cont)

Thanks!

authors: erdOne kbuzzard

repo: ImperialCollegeLondon/FLT


text:
Text-Element Update Problem

Describe the bug
I'm using the Text Element to display GPS-Koords and Date/Time.. Using this code:
String gps_time = "";     gps_time = String(gps.date.day())+("/")+String(gps.date.month())+"/"+String(gps.date.year())+" "+String(gps.time.hour())+":"+String(gps.time.minute())+":"+String(gps.time.second());     Serial.println(gps_time);     char carray[26] = "                        ";     gps_time.toCharArray(carray, sizeof(carray));     gslc_ElemSetTxtStr(&m_gui, m_pElemDateInfo, carray);
it's working the text is updated, but i'm not able to clear the displaying text in the element.
So the new text (seconds as example) appear on top of the old text
The page is not updated properly even when i try to call it or use gslc_Update(&m_gui);
Maybe i just need to get the trigger to force the update into my code but i wasn't able to determine what this would be.
Changing page and returning to main page does the charm but only shows me the problem not the solution, can you give me a quick tip?
Device hardware

MCU: ATmega2560
Display: Ellegoo ILI9341 2.8" resistive
GUIslice config selected:  ard-shld-elegoo_28_res

Please confirm whether:

Display works correctly with standalone display driver library examples (eg. TFT_eSPI graphicstest, Adafruit graphicstest, etc.) without GUIslice: all works fine
Touch works correctly with standalone touch library examples without GUIslice: yep

Hi @feendrache -- thanks for reporting this.
There are a few different ways in which fonts can be rendered, depending on the display mode and color options. In your case, it sounds like the text is being updated without a background redraw.
Can you confirm a couple additional details for me:

What library version are you using?
What font have you selected?
Please indicate any calls you have made to create & modify the appearance of the text element (m_pElemDateInfo). In particular, I'm interested in the foreground color, background color and and fill attribute, ie. ElemCreateTxt(), ElemSetFillEn(), ElemSetTxtCol(), etc.
Alternately, please attach the sketch you have created.

thanks!

Thanks for attaching the sketch!
The problem you are seeing is that the text output is wider than the created text element dimensions. GUIslice performs rendering updates within the boundaries of each element. In both the KOORD and T_TIME elements, the width was specified as 18 pixels.
Please try modifying your sketch (or Builder project) to use a field that is large enough to encompass your output. For example:
// E_ELEM_KOORD width changed from 18 to 150
pElemRef = gslc_ElemCreateTxt(&m_gui,E_ELEM_T_KOORD,E_PG_MAIN,(gslc_tsRect){90,40,150,10},
    (char*)m_sDisplayTextKoord,26,E_FONT_TXT5);

// E_ELEM_T_TIME width changed from 18 to 100
pElemRef = gslc_ElemCreateTxt(&m_gui,E_ELEM_T_TIME,E_PG_MAIN,(gslc_tsRect){90,60,100,10},
    (char*)m_sDisplayTextTime,26,E_FONT_TXT5);

To visualize the update region differences, you can enable a frame on the text field with:
gslc_ElemSetFrameEn(&m_gui,pElemRef,true);
Note that I would have expected that the Builder code generation would have defaulted to a wider dimension after you had entered an External Storage Size of 26, but if not, that could explain the config difference.

Ah thank you,
yeah that explains a lot and the enabling of the frame is magic for debugging.
You were right that this was the problem with the updating.
I'm not quite sure if it was a fault of the builder code generation or if i changed the storage size afterward...
THANK YOU for your help :)

authors: ImpulseAdventure feendrache

repo: ImpulseAdventure/GUIslice


text:
feat: Exchange Issuance for Leveraged Tokens

Exchange Issuance for Leveraged Tokens:

Supports issuing Leveraged Tokens with one debt and one collateral token (such as FLI tokens)
Designed to be run on Polygon
Utilizes Aave flashloan to avoid the user having to supply / receive the debt token on redemption / issuance
Uses UniswapV2 based exchanges for token swaps (Sushiswap, Quickswap)

:tada: This PR is included in version 0.3.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

authors: FlattestWhite ckoopmann

repo: IndexCoop/index-coop-smart-contracts


text:
Unhandled exception: System.Runtime.Serialization.SerializationException

I created a simple plan to execute a Jenkins build and import the build artifacts.

The queue build step throws the following error when I attempt to execute this plan:
Unhandled exception: System.Runtime.Serialization.SerializationException: Type 'Inedo.Extensions.Jenkins.Operations.QueueJenkinsBuildOperation' in Assembly 'Jenkins, Version=1.0.2.0, Culture=neutral, PublicKeyToken=null' is not marked as serializable.
Full stack trace: exec-log-15.txt
I've verified that this plan is setup correctly in BuildMaster because if I remove the Queue Jenkins Build step and just leave the Import Artifact step, BuildMaster successfully downloads the build artifacts from the latest build.

After further investigation, it appears this is indeed a programatic error.
https://stackoverflow.com/questions/15707872/error-is-not-marked-as-serializable
https://stackoverflow.com/questions/11507819/serializationexception-type-is-not-marked-as-serializable-but-it-is?rq=1
Can someone please assist?

This looks like a bug with the ProxyRequest argument, which unfortunately defaults to true. If you set it to false (it's under the Advanced tab), this should work, though the request to queue the build will always be made from the server BuildMaster is installed on in that case.

@gdivis thanks that worked :D I'll leave this issue open then so the bug can be fixed.

authors: gdivis heyitsfranklin

repo: Inedo/inedox-jenkins


text:
Fully decoupling of filter

Decoupling filter pipe from items.
Merge list and items into list.
Improve demo to use pipe in template.

Coverage remained the same at 95.21% when pulling 304fd59c45cff92dbe139cc340ca8a321a939722 on petko5kov:master into d739e5d9b9cf514d0ea9d68743d27d776867f4b5 on Infragistics:master.

repo: Infragistics/zero-blocks


text:
🛑 Database Management System is down

In 5faa66b, Database Management System ($SJURL) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Database Management System is back up in 3587bef.


text:
Slow base permissify command

The base command permissify is really slow for some reason.
Reproducing:
/permissify in game.

This has been fixed, however if the user isn't a super admin, and it's the firs time they run a command, it will still be slow. However, users that are super admin will only get a slow command the first time. This is something that should still be looked into, but, it's work able for now. The problem is related to running the mysql statement to find out if the user is a super admin, and that result wasn't being cached, creating the slowness all the time. This issue will only occur if you're far from the database.

repo: Innectic/Permissify


text:
imwrite does ignore nifti intent_code and intent_name

Description
When saving images using itk.imwrite() in nifti format the writer does ignore nifti intent_code and nifti intent_name.

Steps to Reproduce

Load image with intent_code / intent_name or set them on loaded image
Save the image with itk.imwrite(image, some_place.nii)
Load the saved image and check new_img['intent_code'] and new_img['intent_code']

Expected behavior
itk.imwrite() respects intent_code and intent_name

Actual behavior
intent_code is set to 0 and intent_name to ""

Reproducibility
Every time

Versions
itk-io 5.2.1.post1
and higher

Environment
Python 3.8, 3.9, 3.10

@ch-n   The intent_code and intent_name are specific to the nifti file format.  They are not part of the ITK data model and therefore are not managed by ITK.
As an application developer, you could potentially use the metadata dictionary functionality to privately manage those values in your application.
The code currently works as expected and is documented according to the designed ITK behavior.

authors: ch-n hjmjohnson

repo: InsightSoftwareConsortium/ITK


text:
BUG: Object::InvokeEvent should not use a dangling Observer pointer

SubjectImplementation::InvokeEventRecursion (an internal helper function of
Object::InvokeEvent) tried to "find" a possibly dangling pointer o in its
list of Observer pointers.
It appears more secure to check if an observer is still in the list by
comparing its tag to the tags of the other observers.

FYI A dangling Observer pointer o actually occurs when running the test function testDeleteObserverDuringEvent() from CommandObserverObjectTest, while executing the following line of code:
https://github.com/InsightSoftwareConsortium/ITK/blob/2f2b29cbbe3fe91474933e0194db8d581d5b3247/Modules/Core/Common/test/itkCommandObserverObjectTest.cxx#L101
Which triggers calling the callback function onUserRemove:
https://github.com/InsightSoftwareConsortium/ITK/blob/2f2b29cbbe3fe91474933e0194db8d581d5b3247/Modules/Core/Common/test/itkCommandObserverObjectTest.cxx#L67-L72

Also for reference, this case of deleting events during event's actually regularly occurs in SimpleITK because the "Delete" event of an object is used for free up some dependent resources/referenced, like other event objects.

However, I object to labeling the old as having a "BUG".  The dangling pointer is not dereferenced, it is check if it is still valid as is correct.

Thanks for your comment, @blowekamp However, I still believe it is a bug. Even if the dangling pointer is not dereferenced! Please have another look at the original code from SubjectImplementation::InvokeEventRecursion:
https://github.com/InsightSoftwareConsortium/ITK/blob/a639acc22c41072d5f4cf201756db5b0add7457d/Modules/Core/Common/src/itkObject.cxx#L221-L231
The observer initially pointed to by o (line 222) may be removed during the recursion, so then std::find cannot find it anymore. Which is fine. But during the recursion, when that particular observer is removed, another observer may be added as well, right? This newly added observer might coincidentally get exactly the same memory address as the one that was just removed.
When that happens, std::find will find the pointer o, but it's not pointing to the same observer anymore. I think o->m_Command->Execute(self, event) should then not be called. Right?

When that happens, std::find will find the pointer o, but it's not pointing to the same observer anymore. I think o->m_Command->Execute(self, event) should then not be called. Right?

I will concede that this sequence of events is not impossible. Good call. However I am skeptical that this is was you were originally call a bug. 🧐 😆
This recursive function was a very elegant solution to a rather tricky problem encountered. 😀

I will concede that this sequence of events is not impossible. Good call.

Thanks @blowekamp

This recursive function was a very elegant solution...

I believe so, but it will be even more elegant when using tags instead of dangling pointers  😸

authors: N-Dekker blowekamp


text:
Add SetPointsByCoordinates to PointSet, add warning to SetPoints(PointsVectorContainer *)

Added a warning to PointSet::SetPoints(PointsVectorContainer *), mitigating issue #4848
Added PointSet::SetPointsByCoordinates as a safe alternative.

Perhaps write a Python test to demonstrate that?

I'm sorry I'm not very good in Python tests. 🤷  But it looks like SWIG supports passing a Python tuple or list as argument, when the parameter type is std::vector.

If I remember correctly, the main point of the old method was convenient usage from Python. @PranjalSahu is that correct?
@N-Dekker how would use of the proposed method look like from Python? Perhaps write a Python test to demonstrate that?

Yes, another library supported such functionality of directly passing a 1-D vector of points in any dimension, so we wanted to have a similar feature here. It would be better to find an alternative to reinterpret_cast instead of adding a new method.
If there are no alternatives then yes we can add a new method.
Also did @N-Dekker did you come across any platform where this method is breaking?

did you come across any platform where this method is breaking?

Honestly, I did not. But it's really quite a coincidence that the reinterpret_cast<PointsContainer *>(points) just seems to work so far. As you know, it internally "reinterprets" the bits of an std::vector<CoordRepType> as an std::vector<PointType>.  Suppose the std::vector would internally have a m_NumberOfElements member variable.  This member would then have the same value after the "reinterpretation", as before. But that would be wrong, of course.  The number of elements of std::vector<PointType> is less than the number of elements of std::vector<CoordRepType>.
In general, undefined behavior should be avoided because the compiler (especially the optimizer) may mess up things as it is allowed to assume that there is no undefined behavior.

ok it will be great if we could create a scenario where it fails!
My understanding is that it is converting the pointer type of the continuous memory block where the 1D vector of 1D points of length 3N is stored, to a vector of length N of 3D Points. Essentially the same as Numpy reshape operator (1 x 3N  -> 3xN).
This is needed because only 1D vectors are supported while converting the Numpy vector to VectorContainer and vice-versa.

@PranjalSahu Please try the following:
#include "itkPointSet.h"
#include "../../QuadEdgeMesh/include/itkQuadEdgeMeshTraits.h"
#include <gtest/gtest.h>

TEST(PointSet, SetPoints)
{
  static constexpr auto PointDimension = 2;

  using MeshTraits = itk::QuadEdgeMeshTraits<double, PointDimension, bool, bool>;
  using PointSetType = itk::PointSet<double, PointDimension, MeshTraits>;
  using CoordRepType = PointSetType::CoordRepType;

  auto pointSet = PointSetType::New();
  auto pointsVectorContainer = PointSetType::PointsVectorContainer::New();
  auto numberOfPoints = 42;
  pointsVectorContainer->CastToSTLContainer() = std::vector<CoordRepType>(numberOfPoints * PointDimension);
  pointSet->SetPoints(pointsVectorContainer);
  auto points = pointSet->GetPoints();

  EXPECT_EQ(points->size(), numberOfPoints);
}

It appears that after calling your SetPoints(PointsVectorContainer *) overload, the point-set has got an arbitrary number of points. While it should have been 42! 🤷 (Don't blame me for the MeshTraits 😇 )

Ok yes, it was not designed to be used with such complex point types.
So yes, either we can create a new method as you suggest or add a comment to not use it with complex Point types.

/azp run ITK.Linux.Python

By the way, I proposed a different name for the added member function, "SetPointsByCoordinates", because it is fundamentally different from the two existing SetPoints overloads. Those overloads both "share" the ownership of the object passed as argument (using ITK's reference counting mechanism).  Whereas "SetPointsByCoordinates" copies the coordinates from the specified argument.
Personally I think the name "SetPointsByCoordinates" is fine, but it could also be named, for example, "SetPointsFromCoordinates" or "CopyCoordinatesToPoints". A matter of taste, I guess  🤷

Yes, that was also one of the requirements. Because the number of points could be large, we wanted to avoid copying the data.

Yes, that was also one of the requirements. Because the number of points could be large, we wanted to avoid copying the data.

How large could the number of points possibly be, in your application? Can you please give the SetPointsByCoordinates member function that I'm proposing a chance?
Undefined behavior is just not an option, for any professional application or any serious open source project.

We will have to add tests for Python wrapping also.

We will have to add tests for Python wrapping also.

OK, thanks for reminding me, @PranjalSahu, but Python tests can also be added in a follow-up pull request. The given PR does not break any existing use case. While it does add a valid C++ use case, already.
(I like to keep pull requests small, so that they can be reviewed easily, and merged smoothly.)

We will have to add tests for Python wrapping also.

OK, thanks for reminding me, @PranjalSahu, but Python tests can also be added in a follow-up pull request. The given PR does not break any existing use case. While it does add a valid C++ use case, already.
(I like to keep pull requests small, so that they can be reviewed easily, and merged smoothly.)
PS My first impression is that passing an np.array([1.0, 2.0, 3.0]) argument to a Python wrapped C++ function whose parameter type is const std::vector<double>& just works well. 👍 (I just tried it for ITKElastix.)

Before removing this it would be great if the Python wrapping could be tested and merged.
Because the only purpose to add the vectorcontainer support was for Python wrapping.

Is there a Python wheel for Windows available, based on the latest commit, including this pull request? I would like to try out the new SetPointsByCoordinates member function in Python.

A Python wheel is not built automatically. You need a local build with wrapping enabled. Then, copy C:\Dev\ITK-py22\Wrapping\Generators\Python\WrapITK.pth to your_venv/Lib/site-packages. After restarting Python interpreter ITK should be available.

authors: N-Dekker PranjalSahu dzenanz


text:
STYLE: Renamed array of radii EllipseSpatialObject to RadiiInObjectSpace

Renamed the array of radii of EllipseSpatialObject from
RadiusInObjectSpace to RadiiInObjectSpace.
Thereby it can be distinguished more clearly from use cases where
there is only one radius.

@aylward Please review... what do you think?

Great idea!   Much more clear / unambiguous.

Thanks @aylward Tomorrow I hope to fix the ITK.macOS compilation error.

I think this pull request is ready now: it has succeeded on all ITK machines. It's unclear to me why CDash still says In progress — Build analysis summary

Hi,
I was looking into the failing Python test:
https://open.cdash.org/testDetails.php?test=747024664&build=5830892
which is related to this change.
Since we consistently use Radius to mean multi-dimensional radii throughout the toolkit, and this is a breaking change, should we revert?
There are over 700 hits for Radius, most of which refer a multi-dimensional radii.
https://github.com/InsightSoftwareConsortium/ITK/search?p=3&q=Radius&unscoped_q=Radius
in contrast, the only hits for Radii outside of comments are the changes introduced here.
https://github.com/InsightSoftwareConsortium/ITK/search?q=Radii&unscoped_q=Radii
What do you think?

I am fine with calling it Radius for consistency with the rest of the
toolkit.
On Sun, Mar 31, 2019 at 7:42 PM Matt McCormick notifications@github.com
wrote:

Hi,
I was looking into the failing Python test:
https://open.cdash.org/testDetails.php?test=747024664&build=5830892
which is related to this change.
Since we consistently use Radius to mean multi-dimensional radii
throughout the toolkit, and this is a breaking change, should we revert?
There are over 700 hits for Radius, most of which refer a
multi-dimensional radii.
https://github.com/InsightSoftwareConsortium/ITK/search?p=3&q=Radius&unscoped_q=Radius
in contrast, the only hits for Radii outside of comments are the
changes introduced here.
https://github.com/InsightSoftwareConsortium/ITK/search?q=Radii&unscoped_q=Radii
What do you think?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/InsightSoftwareConsortium/ITK/pull/640#issuecomment-478396707,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AARErwI5cu9adhmCGRe8jJKTKN6sZ8quks5vcUfdgaJpZM4cOXu0
.

--
Stephen R. Aylward, Ph.D.
Senior Director of Strategic Initiatives, Kitware, Inc., North Carolina
Kitware: Advancing the frontiers of understanding
by developing innovative open-source software platforms
and integrating them into research, processes, and products.

It is fine to revert. @N-Dekker?

Same here, I am running into a failure here because of the renaming. Based on the result returned by grep -ri radii and grep -ri radius in ITK source tree, I think for consistency with the rest of the library, it is better to revert this PR and name the function Radius. For example, in this class (which is following a standard pattern in ITK), there are two SetRadius() functions: one that takes a single value, and one that takes a "list" of values, but both functions are named SetRadius().

Personally I still think it's much clearer to use the term "radii" for an array of radii. I wanted to propose "radii" for a long time already, but then I hesitated because of backward compatibility. Now that the function is renamed anyway with ITKv5 (by appending "InObjectSpace"), I thought it would be the right moment to rename to "radii" as well.
On the longer term, it might be a good idea to introduce a CircleSpatialObject. @thewtex actually already suggested me to do so long ago... CircleSpatialObject::GetRadius() clearly would return just a floating point value (double), instead of an array. While it might be derived from EllipseSpatialObject. It might then cause compilation conflicts and confusion, when there would also be a EllipseSpatialObject::GetRadius().
Hope I made my point clear. If you still want to revert, I can't stop you anyway!

@N-Dekker I agree with you 100%: All the functions in ITK that take or return multiple values should be called radii and not radius. That would be more accurate from a linguistics point of view, and that would also allow corner cases like the one you are mentioning with a CircleSpatialObject that would have a function GetRadius() and be derived from EllispseSpatialObject without having a compilation conflict.
That will require a lot of work, since we will want to keep the API consistent across the whole toolkit. That means that all the GetRadius and SetRadius functions that take or return multiple values in the toolkit will need to be renamed, tests will need to be updated, and deprecation macros like the ones @hjmjohnson is adding in #676 will have to be added everywhere. Plus, other software using these functions will need to be updated.

authors: N-Dekker aylward dzenanz fbudin69500 thewtex


text:
Unable to build project using Xcode 15: Undefined symbols

New issue checklist

[X] I have reviewed the README and documentation
[X] I have searched existing issues and this is not a duplicate
[] I have attempted to reproduce the issue and include an example project.

General information

IGListKit version: This commit from main branch ebbc90961b8162079039eaf869ed447033375a29
iOS version(s): 17.0
CocoaPods/Carthage version: None
Xcode version: 15.0
Devices/Simulators affected: iOS 17 simulator and devices
Reproducible in the demo project? (Yes/No): Haven't tried
Related issues:

Hey guys, just wanted to let you know that I'm no longer able to build my project when using IGListKit from main branch (SPM, commit: ebbc90961b8162079039eaf869ed447033375a29), Xcode 15. Got a weird linking error with no additional information:
Undefined symbols:
Linker command failed with exit code 1 (use -v to see invocation)

After setting -ld_classic in Other Linking flags parameter in the Linking section I got this:
Undefined symbol: _objectsWithDuplicateIdentifiersRemoved
Linker command failed with exit code 1 (use -v to see invocation)

Took me several hours to track it down to this library, and after using some older commit everything start to work again. I suspect it's probably related to this commit 51a3cb140e3cbf3b9577683ffdfbf3bfc9644c8b
Cheers.

Thanks @jurex! This should have been fixed in #1591. Please let me know if you find anything else!

authors: TimOliver jurex

repo: Instagram/IGListKit


text:
adobereaderdc-update fails to detect installed version

Adobe Acrobat Reader DC.app is now Adobe Acrobat Reader.app
Entries for updating Adobe Reader should be updated to include this change.
Log:
Script result: 2023-04-18 17:37:13 : REQ   :  : shifting arguments for Jamf
2023-04-18 17:37:13 : INFO  : adobereaderdc-update : setting variable from argument NOTIFY=all
2023-04-18 17:37:13 : INFO  : adobereaderdc-update : setting variable from argument DEBUG=0
2023-04-18 17:37:13 : INFO  : adobereaderdc-update : setting variable from argument REOPEN="no"
2023-04-18 17:37:13 : REQ   : adobereaderdc-update : ################## Start Installomator v. 10.4beta, date 2023-04-12
2023-04-18 17:37:13 : INFO  : adobereaderdc-update : ################## Version: 10.4beta
2023-04-18 17:37:13 : INFO  : adobereaderdc-update : ################## Date: 2023-04-12
2023-04-18 17:37:13 : INFO  : adobereaderdc-update : ################## adobereaderdc-update
2023-04-18 17:37:13 : INFO  : adobereaderdc-update : SwiftDialog is not installed, clear cmd file var
2023-04-18 17:37:14 : INFO  : adobereaderdc-update : BLOCKING_PROCESS_ACTION=tell_user
2023-04-18 17:37:14 : INFO  : adobereaderdc-update : NOTIFY=all
2023-04-18 17:37:14 : INFO  : adobereaderdc-update : LOGGING=INFO
2023-04-18 17:37:15 : INFO  : adobereaderdc-update : LOGO=/System/Applications/App Store.app/Contents/Resources/AppIcon.icns
2023-04-18 17:37:15 : INFO  : adobereaderdc-update : Label type: pkgInDmg
2023-04-18 17:37:15 : INFO  : adobereaderdc-update : archiveName: Adobe Acrobat Reader DC.dmg
2023-04-18 17:37:15 : INFO  : adobereaderdc-update : name: Adobe Acrobat Reader DC, appName: Adobe Acrobat Reader DC.app
2023-04-18 17:37:15 : WARN  : adobereaderdc-update : No previous app found
2023-04-18 17:37:15 : WARN  : adobereaderdc-update : could not find Adobe Acrobat Reader DC.app
2023-04-18 17:37:15 : INFO  : adobereaderdc-update : appversion:
2023-04-18 17:37:15 : INFO  : adobereaderdc-update : Latest version of Adobe Acrobat Reader DC is 23.001.20143
2023-04-18 17:37:15 : REQ   : adobereaderdc-update : Downloading https://ardownload2.adobe.com/pub/adobe/reader/mac/AcrobatDC/2300120143/AcroRdrDCUpd2300120143_MUI.dmg to Adobe Acrobat Reader DC.dmg
2023-04-18 17:37:15 : INFO  : adobereaderdc-update : notifying
2023-04-18 17:38:10 : REQ   : adobereaderdc-update : no more blocking processes, continue with update
2023-04-18 17:38:10 : REQ   : adobereaderdc-update : Installing Adobe Acrobat Reader DC
2023-04-18 17:38:10 : INFO  : adobereaderdc-update : notifying
2023-04-18 17:38:10 : INFO  : adobereaderdc-update : Mounting /var/folders/zz/zyxvpxvq6csfxvn_n0000000000000/T/tmp.zMHHbqrq/Adobe Acrobat Reader DC.dmg
2023-04-18 17:38:11 : INFO  : adobereaderdc-update : Mounted: /Volumes/AcroRdrDCUpd2300120143_MUI
2023-04-18 17:38:11 : INFO  : adobereaderdc-update : found pkg: /Volumes/AcroRdrDCUpd2300120143_MUI/AcroRdrDCUpd2300120143_MUI.pkg
2023-04-18 17:38:11 : INFO  : adobereaderdc-update : Verifying: /Volumes/AcroRdrDCUpd2300120143_MUI/AcroRdrDCUpd2300120143_MUI.pkg
2023-04-18 17:38:11 : INFO  : adobereaderdc-update : Team ID: JQ525L2MZD (expected: JQ525L2MZD )
2023-04-18 17:38:11 : INFO  : adobereaderdc-update : Installing /Volumes/AcroRdrDCUpd2300120143_MUI/AcroRdrDCUpd2300120143_MUI.pkg to /
2023-04-18 17:38:20 : DEBUG : adobereaderdc-update : Last Log repeated 2 times
2023-04-18 17:38:20 : INFO  : adobereaderdc-update : Finishing...
2023-04-18 17:38:23 : INFO  : adobereaderdc-update : name: Adobe Acrobat Reader DC, appName: Adobe Acrobat Reader DC.app
2023-04-18 17:38:23 : WARN  : adobereaderdc-update : No previous app found
2023-04-18 17:38:23 : WARN  : adobereaderdc-update : could not find Adobe Acrobat Reader DC.app
2023-04-18 17:38:23 : REQ   : adobereaderdc-update : Installed Adobe Acrobat Reader DC
2023-04-18 17:38:23 : INFO  : adobereaderdc-update : notifying
2023-04-18 17:38:24 : INFO  : adobereaderdc-update : REOPEN=no, not reopening anything
2023-04-18 17:38:24 : REQ   : adobereaderdc-update : All done!
2023-04-18 17:38:24 : REQ   : adobereaderdc-update : ################## End Installomator, exit code 0

see #933

authors: reuven-cohen scriptingosx

repo: Installomator/Installomator