text:
Textual date representation

Source issue: https://github.com/metanorma/metanorma-jis/issues/9
From cover page:

Currently:

adoc:

:published-date: 2019-07-22

Presentation xml:

<date type="published">
<on>2019-07-22</on>
</date>

令和元年 - Google translated is as 2019
This sentence contains from two parts:

令和 means 'Reiwa era' https://en.wikipedia.org/wiki/Reiwa_era, from May 1, 2019
元年 means 'first year'
translate.ru (https://www.translate.ru/перевод/японский-английский?text=令和元年) shows The first year of Reiw

Note: for 2019 - there are two  years in Japanese notation

(from https://groups.oist.jp/resource-center/japanese-year-converter)
7 月22 日 - July 22

Right now we don't have a good gem that works with Japanese dates. It would be easier if we just ask the user to input the dates for now.

Right now we don't have a good gem that works with Japanese dates.

https://github.com/twitter/twitter-cldr-rb does Japanese Gregorian dates fine: https://github.com/twitter/twitter-cldr-rb/blob/b5256d83cdb8e90310ab4a28994407b7139f8394/resources/locales/ja/calendars.yml . For Japanese Imperial eras, there likely are several gems out there (remember where Ruby originated), but we haven't searched for them yet.

https://github.com/RyoYamamotoJP/japanese_calendar

Yes, but only to the extent of customising Gregorian calendars. The Thai Buddhist calendar used to be supported, and was retracted; there is no indication of any Japanese imperial calendar.

I've used twitter_cldr to make the era year spelled out, the gem I've used is numeric.

@opoudjis thanks!

As you can see, @Intelligent2013, I am slowly catching up on very old backlog...

authors: Intelligent2013 opoudjis ronaldtse

repo: metanorma/metanorma-jis


text:
feat: override accound keys and program id

Summary
This PR adds the ability for users to do the following:

provide a programId, if not provided it defaults to the programId provided to solita
during code generation
provide overrides for known account ids like tokenProgram, if not provided it defaults to
the keys provided by the respective libraries

Example
Auction Houes buy instruction serves as a shortened example of what is generated now:
Accounts Type
/**
 * Accounts required by the _buy_ instruction
 *
 * @property [**signer**] wallet
 * @property [_writable_] paymentAccount
 * @property [] transferAuthority
 * @property [] treasuryMint
 * @property [] tokenAccount
 * @property [] metadata
 * @property [_writable_] escrowPaymentAccount
 * @property [] authority
 * @property [] auctionHouse
 * @property [_writable_] auctionHouseFeeAccount
 * @property [_writable_] buyerTradeState
 * @category Instructions
 * @category Buy
 * @category generated
 */
export type BuyInstructionAccounts = {
  wallet: web3.PublicKey
  paymentAccount: web3.PublicKey
  transferAuthority: web3.PublicKey
  treasuryMint: web3.PublicKey
  tokenAccount: web3.PublicKey
  metadata: web3.PublicKey
  escrowPaymentAccount: web3.PublicKey
  authority: web3.PublicKey
  auctionHouse: web3.PublicKey
  auctionHouseFeeAccount: web3.PublicKey
  buyerTradeState: web3.PublicKey
  tokenProgram?: web3.PublicKey
  systemProgram?: web3.PublicKey
  rent?: web3.PublicKey
}

NOTE: that the optional accounts are not included in the comments as overriding them is a
hidden feature.
Known Account Resolution
  const keys: web3.AccountMeta[] = [
    {
      pubkey: accounts.wallet,
      isWritable: false,
      isSigner: true,
    },
    [ .. many more .. ]
    {
      pubkey: accounts.tokenProgram ?? splToken.TOKEN_PROGRAM_ID,
      isWritable: false,
      isSigner: false,
    },
    {
      pubkey: accounts.systemProgram ?? web3.SystemProgram.programId,
      isWritable: false,
      isSigner: false,
    },
    {
      pubkey: accounts.rent ?? web3.SYSVAR_RENT_PUBKEY,
      isWritable: false,
      isSigner: false,
    },
  ]

Program ID
/**
 * Creates a _Buy_ instruction.
 *
 * @param accounts that will be accessed while the instruction is processed
 * @param args to provide as instruction data to the program
 *
 * @category Instructions
 * @category Buy
 * @category generated
 */
export function createBuyInstruction(
  accounts: BuyInstructionAccounts,
  args: BuyInstructionArgs,
  programId = new web3.PublicKey('hausS13jsjafwWwGqZTUQRmWyvyxn9EQpqMwV1PBBmk')
) {

  // [ .. ]

  const ix = new web3.TransactionInstruction({
    programId,
    keys,
    data,
  })

  return ix
}

NOTE: programId is not listed in the docs as overriding it is a hidden feature as well.
FIXES: #44

That's great thank you!
I've got a small question, but I'm happy for you to merge this as-is if you think it's best.
export function createBuyInstruction(
  accounts: BuyInstructionAccounts,
  args: BuyInstructionArgs,
  programId = new web3.PublicKey('hausS13jsjafwWwGqZTUQRmWyvyxn9EQpqMwV1PBBmk')
)

On the 4th line of the above example, wouldn't it make more sense to use the PROGRAM_ID constant defined in generated/index.ts?

source: gharchive/pull-request

authors: lorisleiva thlorenz

repo: metaplex-foundation/solita

license_type: permissive

license_source: github-api


text:
IPv4 converters

[x] tests and linter show no problems (npm t)
[x] tests are added/updated for bug fixes and new features
[x] code is properly formatted (npm run fmt)
[ ] description of changes is added in CHANGELOG.md
[x] update .d.ts typings

Landed in https://github.com/metarhia/metautil/commit/55343320ceaa47dfd0f3c405059b47bff9ee1e4d, https://github.com/metarhia/metautil/commit/4eaeeb968159d80d8de6eaeb15ec5ca4fb8210aa, https://github.com/metarhia/metautil/commit/d9d7386ad85e43adcf26cf0fed58605c543bd01e, https://github.com/metarhia/metautil/commit/2bbacf3e766ebbe7aeec4e2a320f85f4236839c0, and https://github.com/metarhia/metautil/commit/f390bfa2b4d50250d0918b92274be397457066fb

repo: metarhia/metautil

license: MIT


text:
#3765 fix grid alignment error

Description

Related Issue : #3765

How Has This Been Tested?

Create a grid chart.
Check if the sort function works normally.

Need additional checks?
Types of changes

[X] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] I have read the CONTRIBUTING document.
[ ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have added tests to cover my changes.

Additional Context

deploy to 1

authors: eltriny ufoscw

repo: metatron-app/metatron-discovery

license_source: bigquery


text:
v1.2.0 Start Script Failure

Hello 👋
Working on a MacOS 10.14.5 and after a clean download of Metricio (downloaded the latest zip)  I am having issues when running:
npm i && npm run start

Specifically, I am getting this:
> metricio@1.2.0 start /Users/erubioteruel/Documents/GitHub/DevOps-Dashboard
> babel-node app.js

/Users/erubioteruel/Documents/GitHub/DevOps-Dashboard/app.js:1
import { createServer } from 'http';
       ^

SyntaxError: Unexpected token {
    at Module._compile (internal/modules/cjs/loader.js:721:23)
    at loader (/Users/erubioteruel/Documents/GitHub/DevOps-Dashboard/node_modules/babel-register/lib/node.js:144:5)
    at Object.require.extensions.(anonymous function) [as .js] (/Users/erubioteruel/Documents/GitHub/DevOps-Dashboard/node_modules/babel-register/lib/node.js:154:7)
    at Module.load (internal/modules/cjs/loader.js:653:32)
    at tryModuleLoad (internal/modules/cjs/loader.js:593:12)
    at Function.Module._load (internal/modules/cjs/loader.js:585:3)
    at Function.Module.runMain (internal/modules/cjs/loader.js:829:12)
    at Object.<anonymous> (/Users/erubioteruel/Documents/GitHub/DevOps-Dashboard/node_modules/babel-cli/lib/_babel-node.js:154:22)
    at Module._compile (internal/modules/cjs/loader.js:776:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:787:10)
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! metricio@1.2.0 start: `babel-node app.js`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the metricio@1.2.0 start script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /Users/erubioteruel/.npm/_logs/2019-07-23T16_56_42_601Z-debug.log

I thought it might be because I had not installed Redis, but I went ahead and did that but I am still getting the same message.
Any help would be appreciated!!

Also, in case this helps:
0 info it worked if it ends with ok
1 verbose cli [ '/usr/local/bin/node', '/usr/local/bin/npm', 'run', 'start' ]
2 info using npm@6.9.0
3 info using node@v10.16.0
4 verbose run-script [ 'prestart', 'start', 'poststart' ]
5 info lifecycle metricio@1.2.0~prestart: metricio@1.2.0
6 info lifecycle metricio@1.2.0~start: metricio@1.2.0
7 verbose lifecycle metricio@1.2.0~start: unsafe-perm in lifecycle true
8 verbose lifecycle metricio@1.2.0~start: PATH: /usr/local/lib/node_modules/npm/node_modules/npm-lifecycle/node-gyp-bin:/Users/erubioteruel/Documents/GitHub/DevOps-Dashboard/node_modules/.bin:/usr/share/www/intranet.directstartv.com/scripts/srcsync-dir:/usr/local/bin:/usr/share/www/devops/scripts:/usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin:/usr/share/www/intranet.directstartv.com/scripts/srcsync-dir:/usr/share/www/devops/scripts
9 verbose lifecycle metricio@1.2.0~start: CWD: /Users/erubioteruel/Documents/GitHub/DevOps-Dashboard
10 silly lifecycle metricio@1.2.0~start: Args: [ '-c', 'babel-node app.js' ]
11 silly lifecycle metricio@1.2.0~start: Returned: code: 1  signal: null
12 info lifecycle metricio@1.2.0~start: Failed to exec start script
13 verbose stack Error: metricio@1.2.0 start: `babel-node app.js`
13 verbose stack Exit status 1
13 verbose stack     at EventEmitter.<anonymous> (/usr/local/lib/node_modules/npm/node_modules/npm-lifecycle/index.js:301:16)
13 verbose stack     at EventEmitter.emit (events.js:198:13)
13 verbose stack     at ChildProcess.<anonymous> (/usr/local/lib/node_modules/npm/node_modules/npm-lifecycle/lib/spawn.js:55:14)
13 verbose stack     at ChildProcess.emit (events.js:198:13)
13 verbose stack     at maybeClose (internal/child_process.js:982:16)
13 verbose stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:259:5)
14 verbose pkgid metricio@1.2.0
15 verbose cwd /Users/erubioteruel/Documents/GitHub/DevOps-Dashboard
16 verbose Darwin 18.6.0
17 verbose argv "/usr/local/bin/node" "/usr/local/bin/npm" "run" "start"
18 verbose node v10.16.0
19 verbose npm  v6.9.0
20 error code ELIFECYCLE
21 error errno 1
22 error metricio@1.2.0 start: `babel-node app.js`
22 error Exit status 1
23 error Failed at the metricio@1.2.0 start script.
23 error This is probably not a problem with npm. There is likely additional logging output above.
24 verbose exit [ 1, true ]

@eduardoRubioG this one works for me : https://stackoverflow.com/a/33608835/3506156

source: gharchive/issue

authors: eduardoRubioG jordanfitnext

repo: metricio/metricio


text:
Open Recruitment Landing page first section (title & button & learn-more)

Description
Landing page implementation in the Figma

Closed in #39

repo: metricsui/web


text:
Retrieve code for AIC as figure 7

need to implement previous code for aic. make axes start at 0.

if we have a list of 40 cells, the cells that are root cells and at 30 or above (ie root cells at end list  - which live the longest of all root cells) have an EL that is near 0 and an NF that is near 0 and MSD that is at 1). This is for a 1 state fit on 2 state lineages.

issue was that bern is instantiated as 1/numstates. in 1 state model this become 1. and for cells that die, their bern is 0, so the probability of being in this state of bern 1 is 0, which causes nans.

i ran 100 of our 2 state lineages (same parameters as the paper) and the error bars are the stdev. @aarmey can you look at the formula we use calculate AIC in the getAIC function in thmm.utils? because our results here are not promising and wondering if it a misimplementation of the formula rather than an underlying model issue. @shak360

line 104, also copied below:
def getAIC(tHMMobj, LL):
    '''
    Gets the AIC values. Akaike Information Criterion, used for model selection and deals with the trade off
    between over-fitting and under-fitting.
    AIC = 2*k - 2 * log(LL) in which k is the number of free parameters and LL is the maximum of likelihood function.
    Minimum of AIC detremines the relatively better model.

    Args:
        ----------
        tHMMobj (obj): the tHMM class which has been built.
        LL (list): a list containing log-likelihood values of Normalizing Factors for each lineage.

    Returns:
        ----------
        AIC_value_holder_rel_0 (list): containing AIC values relative to 0 for each lineage.
        [numStates]*len(AIC_value_holder) (list): a list containing the # of states, repeated # of lineage times.
        AIC_degrees_of_freedom_holder (list): Contains all of the parameters for each of the lineages.

    Example Usage:

        from matplotlib.ticker import MaxNLocator

        x1val = []
        x2val = []
        yval = []
        for numState in range(3):
            tHMMobj = tHMM(X, numStates=numState, FOM='G') # build the tHMM class with X
            tHMMobj, NF, betas, gammas, LL = fit(tHMMobj, max_iter=100, verbose=False)
            AIC_value, numStates, deg = getAIC(tHMMobj, LL)
            x1val.append(numStates)
            x2val.append(deg)
            yval.append(AIC_value)

        fig = plt.figure(figsize=(10,10))
        ax1 = fig.add_subplot(111)
        ax1.scatter(xval, yval, marker='*', c='b', s=500, label='One state data/model')
        ax1.xaxis.set_major_locator(MaxNLocator(integer=True))
        ax1.grid(True, linestyle='--')
        ax1.set_xlabel('Number of States')
        ax1.set_ylabel('AIC Cost')
        title = ax1.set_title('Akaike Information Criterion')
        title.set_y(1.1)
        fig.subplots_adjust(top=1.3)

        ax2 = ax1.twiny()
        ax2.set_xticks([1]+ax1.get_xticks())
        ax2.set_xbound(ax1.get_xbound())
        ax2.set_xticklabels(x2val)
        ax2.set_xlabel('Number of parameters')

        ax1.legend()
        plt.rcParams.update({'font.size': 28})
        plt.show()
    '''
    numStates = tHMMobj.numStates
    AIC_value_holder = []
    AIC_degrees_of_freedom_holder = []
    for num in range(tHMMobj.numLineages):
        number_of_parameters = 0
        number_of_parameters += 1

        AIC_degrees_of_freedom = numStates**2 + numStates * number_of_parameters - 1
        AIC_degrees_of_freedom_holder.append(AIC_degrees_of_freedom)
        AIC_value = -2 * LL[num] + 2 * AIC_degrees_of_freedom
        AIC_value_holder.append(AIC_value)

    AIC_value_holder_rel_0 = AIC_value_holder - min(AIC_value_holder)  # this line is to make it so the minimum value is 0
    return(AIC_value_holder, [numStates] * len(AIC_value_holder), AIC_degrees_of_freedom_holder) # no longer returning relative to zero

All the files in venv need to be removed.

Looks like my second axis for the number of parameters vs. the number of states isn't working either... Also that code doesn't make sense. Doesn't that for loop indicate that number_of_parameters is always 1?
 for num in range(tHMMobj.numLineages):
        number_of_parameters = 0
        number_of_parameters += 1

All the files in venv need to be removed.

done

Looks like my second axis for the number of parameters vs. the number of states isn't working either... Also that code doesn't make sense. Doesn't that for loop indicate that number_of_parameters is always 1?
 for num in range(tHMMobj.numLineages):
        number_of_parameters = 0
        number_of_parameters += 1

i fixed the thmm issue. took all but the second line out of the for loop

i added venv to the gitignore so the folder wouldnt get pushed. can i resolve that conflict from the gitignore?

final figure

repo: meyer-lab/lineage-growth


text:
env_unlock() will be removed from rlang

Hello, just a heads up that we'll remove env_unlock() from rlang in a future version (undetermined timeline as of yet) because it's implemented using non-API calls that CRAN has started to lint. Could you try and find another approach please?

Thanks for the heads-up @lionel-, work is already ongoing on this front to better interface with bigrquery package. The feature will be entirely dropped.

Done in #52 so this issue can be closed.

authors: hadley lionel- meztez

repo: meztez/bigrquerystorage


text:
Interface and naming conventions

The names of objects, methods, and so forth are not always consistent throughout the code. This issue is intended to collect some of the known inconsistencies and discuss how the code could be changed or documented to remove or mitigate some of these inconsistencies.

Element: spelled "Element", "Elem", or "E" at various places. Note also that this word has two semantic meanings as well, as a finite element or as an element of a Vector/Matrix.
Number: spelled "Number", "Num", or "N" at various places.
Parallel: spelled "Parallel" or "Par" variously in the code.
Dimension: spelled "Dimension" (as in Mesh) or "Dim" (as in FiniteElement)
Communicator: spelled "Comm" almost everywhere but in GroupCommunicator
Boundary: spelled "Boundary", "Bdr", or "B", this one is an inconsistent mess throughout the code.
Column: spelled "Column" (as in SparseMatrix) or "Col" (as in HypreParMatrix)
ElementVector/SubVector: in the Vector class, we have AddElementVector but GetSubVector and SetSubVector.

Regarding "Parallel":
In my view "Par" is much more common in the code than "Parallel", so I would recommend:

Within ParGridFunction, rename ParallelAverage(), ParallelAssemble(), and ParallelProject()
Within ParLinearForm, rename ParallelAssemble()
Within ParBilinearForm, rename ParallelAssemble(), ParallelAssembleElim(), ParallelEliminateEssentialBC(), ParallelEliminateTDofs()
Within StaticCondensation, rename GetParallelMatrix()

Regarding "Number":
"N" is used very often but is probably not always clear to users, and I would recommend replacing it with "Num":

In Mesh: GetNV, GetNE, GetNBE, GetNEdges, GetGlobalNE, GetNFaces (note that GetNumFaces() already exists and appears to do something different from GetNFaces!)
in 'FiniteElementSpace`: GetNDofs, GetNConformingDofs, GetNVDofs, GetNEDofs, GetNFDofs, GetNF, GetNRanks
in StaticCondensation: GetNPrDofs, GetNExDofs
in Table: NumberOfRows, NumberOfEntries could be spelled "Num" for consistency

One thing that will definitely help is to document what the methods do, so there is no room for misinterpretation, if you read the documentation.
One additional item I can add:

Face: it can mean two different things: a 2D mesh entity, or (dim-1)-dimensional mesh entity in a dim-dimensional mesh.

Having clear conventions for naming things is great and can help a lot but one still needs to learn and remember what they are. Documentation is where one can learn these.
Even in the current state, there is some logic and conventions used for naming things, even if they are not fully consistent. For example, based on the context, I don't think using one or the other of the following is really confusing:  Num vs Number, Dim vs Dimension, Col vs Column, etc.

When you are looking at Num vs Number, I agree that there is no chance ambiguity.  It's more a matter of when you want to invoke one of those methods, and you don't remember which way it is named, so you have to go look it up each time.  It is a minor thing, but nice to have.

If we start renaming things, I think we should definitely keep the old names too, at least for some time.

Hi @rw-anderson ,
in internal projects I tackled such issues gradually. First, marking the problematic functions and methods as deprecated, either through function attributes (__attribute__, __declspec, ...) or the deprecated specifier). This way users have time to modernize their code. Then, with the next major version bump, the deprecated functions were removed, complemented with a changelog to give users a better chance to modernize old snippets, which may reside in gists, solved issues, blog posts, ....
I really second documenting these kinds of problems, but in general I do not think is worth breaking interfaces too quickly (as @v-dobrev also said in the meantime).
So, here is my round of semantic problems which I would like to address in this thread.

const correctness, especially with respect to getter methods.
Marking immutable data "const" possibly unlocks code optimization and really helps in writing programs with shared memory parallelism (e.g. through OpenMP), because data races are impossible. For example, the following example
https://github.com/mfem/mfem/blob/657c64ac2432905d9ea779734daf8e090fd46f04/mesh/mesh.cpp#L415-L419
can lead to really hard to track down issues, because multiple threads reference to the same mutable object and may change the integration point simultaneously. On the other hand the following method (called by the previous one)
https://github.com/mfem/mfem/blob/657c64ac2432905d9ea779734daf8e090fd46f04/mesh/mesh.cpp#L421
seems to be somewhat const correct.
I also see from time to time getter functions which either do a substatial amount of computationas internally (e.g. the error estimators) or which transfer ownership (i.e. create objects which the caller must cleanup).
https://github.com/mfem/mfem/blob/657c64ac2432905d9ea779734daf8e090fd46f04/fem/pfespace.hpp#L284-L287
While this is documented, this still can become an issue, as it is not the behavior I would expect from a method starting with "get".
Note that marking a method (or data) const is potentially a breaking change for user code.
ownership and parameter passing
It is often not directly clear when to pass a pointer or a reference and its consequence to the objects ownership. While in most places the data members are documented, methods do not reflect this. E.g. in
https://github.com/mfem/mfem/blob/c9d97af71700c33098140301f06a6d1023ac3592/fem/fespace.hpp#L296-L302
the mesh ownership is not transfered, while e.g.
https://github.com/mfem/mfem/blob/657c64ac2432905d9ea779734daf8e090fd46f04/fem/nonlinearform.hpp#L84-L86
does. Especially the latter one gave me a really hard time to track down in my AMR simulations.
Here a good example is the design of the ZZ error estimator construction
https://github.com/mfem/mfem/blob/ca5a4dff6f5b9e2b72ab72fac7c75772128916e2/fem/estimators.hpp#L111-L119
https://github.com/mfem/mfem/blob/ca5a4dff6f5b9e2b72ab72fac7c75772128916e2/fem/estimators.hpp#L131-L139
because references for non-owned inputs and pointers for taking ownership is a widespread convention.
access and indexing of non-local quantities
This one is from my view as a developer, when trying to extend MFEM. For me it is still a point of confusion whenever I have to use/pass negative indices (starting at -2!) and when to use "max-local-quantity + non-local-index". E.g. FaceInfo sometimes stores negative indices in Face1Inf and Face2Inf. I am not sure what exactly Inf stands for and what "Inf = 64 * LocalFaceIndex + FaceOrientation " tells me. On the other hand ParGridFunction::GetValue allows me to access grid data of adjacent processes (after calling ParGridFunction::ExchangeFaceNbrData), via an index larger than the number of local dofs. Also, vdim starts at 1 and not 0 (?) if I understand correctly.
Again Doxygen misses to capture some documentation for FaceInfo (the note below the class), which I think is quite essential to grasp what is going on. I also noticed that there is no way of accessing the NCInfo, which is (may be?) necessary to distinguish whether a face is a slave or master face.

Since I think this thread is also an oppurtunity to improve documentation in general, here two more points which catched my attention

working with non-conforming meshes
I figured out by try-and-error, that sub-face integration (i.e. the integral over individual "slave-parts") works out of the box with the FaceElementTransformations class. I could not find a place where this is documented. Also, it is unclear to me why FaceElementTransformations::face is deprecated, as it is quite useful, especially when working with a distributed memory application (because it gives direct access to the correct shared face). Also, Doxygen misses the documentation for this class.
Involved operators and the different vectorial quantities
When I started using mfem it was really not clear how exactly the operator decomposition (i.e. https://mfem.org/performance/ and https://ceed.exascaleproject.org/libceed/) relates to which classes in the code and how to access these quantities/operators. I am not sure about this one, but probably small code snippets could help (new) users here.

Btw, for documentation which must be shared between functions and methods, Doxygen has a feature called grouping, which may become handy. Especially since the classes have quite some methods and finding the "right" ones can take some time and often methods share some common documentation (and context).

"Inf = 64 * LocalFaceIndex + FaceOrientation"
You don't find raw bit shifting and packing intuitively obvious?
Yeah, it wasn't to me either. :smile:

@termi-official Thanks for your very detailed comments! Honestly I did not intend this issue to be quite so broad when I opened it - I am wondering if things like const-correctness and ownership of pointers should be documented and discussed in separate issues?

If we start renaming things, I think we should definitely keep the old names too, at least for some time.

Keeping the old names is a very good idea. However, I have a question that is more or less related to this. I noticed that there are 2 functions AddTriangle and AddTia that are seemingly the same. Is there any preference to use one over the other? Was it that someone wanted to change the name, and now we have both for backward compatibility?
Tamas

I noticed that there are 2 functions AddTriangle and AddTia that are seemingly the same. Is there any preference to use one over the other? Was it that someone wanted to change the name, and now we have both for backward compatibility?

These two are exactly the same -- just alternative names.
I had to check the 1-line implementations to see that, since we the only "documentation" for these is that they are part of the "documentation group" that starts here: https://github.com/mfem/mfem/blob/3c5dc275a4f14eb87b88d76323b6e0fa270074ea/mesh/mesh.hpp#L503-L507

@barker29 In case the question was directed at me, I would keep it in this thread. Simply because the mentioned contracts (i.e. pre-, postconditions, invariants and possibly local or global side effects) are part of an interface and its conventions.

I had to check the 1-line implementations to see that, since we the only "documentation" for these is that they are part of the "documentation group" that starts here:
https://github.com/mfem/mfem/blob/3c5dc275a4f14eb87b88d76323b6e0fa270074ea/mesh/mesh.hpp#L503-L507

Yes, I saw that the implementations are the same. That's why I thought that one of those will be deleted at some point and that could cause a problem. (The same problem will happen if you rename anything that is suggested in this issue and delete the old names anytime in the future.)

If this issue is for general interface issues, I thought I'd raise the issue of the "Coefficient" classes which I presume were originally used to describe coefficients in PDEs, but seem to now function as more of a general non-FE function interface that is used for other things like defining initial conditions, exact solutions, due to the convenience of being able to project into a FE space.
I wonder if something as simple as a typedef to allow the alias "Function" in place of "Coefficient" would make programmer intent a bit less confusing in places.

I found another small one in the Mesh regarding the connectivity information, which is at least not obvious to me.
There is
const Table & ElementToElementTable ()
without const
const Table & ElementToFaceTable () const + const Table & | ElementToEdgeTable () const
with const and further
Table *GetFaceEdgeTable () const + Table * GetEdgeVertexTable () const
withouth the "to" and a mutable Table instance.
Going through the implementation I guess the latter two are specific to 3D meshes while the former are for "ND" meshes? It also looks like the Mesh has the ownership of the latter?

Bumping because I think this is a useful discussion, even if most of this is not likely to be fixed soon.

Another source of inconsistencies is whether accessors should include the prefix Get. For example, Vector and Array provide GetData() functions. DenseMatrix provides both Data() and GetData() (they do the same thing, should one be deprecated?). DenseTensor provides GetData(int) and Data() (these are two versions of related accessors — why should the semantics depend on the prefix Get?).
Similarly, to get the mesh from a finite element space, you use GetMesh, however to get the finite element space from a grid function you use FESpace().
ParFiniteElementSpace has both GetGroupComm and GroupComm member functions, which do very different things (one is private, but the point still stands...).

Are Mesh.Print() and GridFunction.Save() named differently for a reason?  They seem to be very similar.

I think Save is to distinguish it from the Print inherited from Vector. The former calls the latter.

I have just started working with MFEM and as I was looking at GetBdrElementTransformation and was surprised it was not marked as const. Searching for const correctness in the issue brought me here. As @termi-official noted, more methods should be made const.  I have a few more comments on his remarks:

const correctness, especially with respect to getter methods.
Marking immutable data "const" possibly unlocks code optimization and really helps in writing programs with shared memory parallelism (e.g. through OpenMP), because data races are impossible.

I think const is mostly not there for the compiler but for the programmers. It helps a reader better understand the code, for example immediately seeing when an argument being passed is possibly an output rather than just an input data. Having non const-correct code means in some places, a pointer or reference argument cannot be marked as const as well and the reader either is likely to make an incorrect assumption or has to open the code to find what is going on.

For example, the following example
https://github.com/mfem/mfem/blob/657c64ac2432905d9ea779734daf8e090fd46f04/mesh/mesh.cpp#L415-L419
can lead to really hard to track down issues, because multiple threads reference to the same mutable object and may change the integration point simultaneously. On the other hand the following method (called by the previous one)
https://github.com/mfem/mfem/blob/657c64ac2432905d9ea779734daf8e090fd46f04/mesh/mesh.cpp#L421
seems to be somewhat const correct.

Actually this function, though it should be const cannot be marked as const because it uses some internal temporary data space (FaceElemTr for 2D periodic meshes).
It seems that the use of temporary internal data space variable in the class Mesh is imho too widespread. Several methods return pointers to internal data space, including the one argument GetBdrElementTransformation mentioned by @termi-official. Modern allocators/deallocators are fast. It seems that in modern C++11, values should be returned from such one-argument function.

Has it ever been considered to use a naming convention to distinguish member variables? Like google's convention to use a trailing underscore? I find this helpful when trying to understand complex classes. I recognize this would be a sweeping change.

Has it ever been considered to use a naming convention to distinguish member variables? Like google's convention to use a trailing underscore? I find this helpful when trying to understand complex classes. I recognize this would be a sweeping change.

It could be something to consider for mfem-5.0

Has it ever been considered to use a naming convention to distinguish member variables? Like google's convention to use a trailing underscore? I find this helpful when trying to understand complex classes. I recognize this would be a sweeping change.

It could be something to consider for mfem-5.0

Ok. Only if there is broad support for it. I know opinions vary on this.

In Qt Creator (and maybe other editors), you can configure it to show member variables with a different style -- e.g. I configured it to show then in italic.
That said, I don't see a problem in using some convention for that. A common choice is to use the prefix m_.

In Qt Creator (and maybe other editors), you can configure it to show member variables with a different style -- e.g. I configured it to show then in italic.

Interesting.  Does Qt Creator parse the code with a C++ compiler to determine that?

That said, I don't see a problem in using some convention for that. A common choice is to use the prefix m_.

m_ is what I am most accustomed to. I have been told recently by younger developers that this is considered archaic. But I personally would be comfortable with it.

Interesting. Does Qt Creator parse the code with a C++ compiler to determine that?

Yes, it uses a version of clang that comes with it.

Found some issues related to the matrix infrastructure. Since this is giving me constant issues in my code I am wondering why PetscParMatrix and HypreParMatrix just specialized on Operator and not on AbstractSparseMatrix  - is there some rationale to not do this?
Further matrix patching/elimination methods are inconsistent and DiagonalPolicy seems to be not really used.
In the HypreParMatrix some time the eliminated entries are returned, but no option how the diagonal should be handled or docs on what happens to the entry.
HypreParMatrix * HypreParMatrix::EliminateRowsCols (const Array< int > &rows_cols)
HypreParMatrix * HypreParMatrix::EliminateCols (const Array< int > &cols)
void HypreParMatrix::EliminateRows (const Array< int > &rows)

Here the elimination methods have even different semantics. The first method eliminates the rows/cols of the input matrix and assigns itself the eliminated entries, which is not true for the latter two methods. Again no way to handle the diagonal entries.
void OperatorHandle::EliminateRowsCols (OperatorHandle &A, const Array< int > &ess_dof_list)
void OperatorHandle::EliminateRows (const Array< int > &ess_dof_list)
void OperatorHandle::EliminateCols (const Array< int > &ess_dof_list)

Here we the EliminateCols method is missing completely. Also, row elimination does not give an option to handle the diagonal entry or docs on what happens to the entry.
void PetscParMatrix::EliminateRowsCols (const Array< int > &rows_cols, const PetscParVector &X, PetscParVector &B, double diag=1.)
void PetscParMatrix::EliminateRowsCols (const Array< int > &rows_cols, const HypreParVector &X, HypreParVector &B, double diag=1.)
PetscParMatrix * PetscParMatrix::EliminateRowsCols (const Array< int > &rows_cols)
void PetscParMatrix::EliminateRows (const Array< int > &rows)

Not quite sure about the "vanilla" one.
void SparseMatrix::EliminateRow (int row, const double sol, Vector &rhs)
void SparseMatrix::EliminateRow (int row, DiagonalPolicy dpolicy=DIAG_ZERO)
void SparseMatrix::EliminateCol (int col, DiagonalPolicy dpolicy=DIAG_ZERO)
void SparseMatrix::EliminateCols (const Array< int > &cols, const Vector *x=NULL, Vector *b=NULL)
void SparseMatrix::EliminateCols (const Array< int > &col_marker, SparseMatrix &Ae)
void SparseMatrix::EliminateRowCol (int rc, const double sol, Vector &rhs, DiagonalPolicy dpolicy=DIAG_ONE)
void SparseMatrix::EliminateRowCol (int rc, DiagonalPolicy dpolicy=DIAG_ONE)
void SparseMatrix::EliminateRowCol (int rc, SparseMatrix &Ae, DiagonalPolicy dpolicy=DIAG_ONE)
void SparseMatrix::EliminateRowColDiag (int rc, double value)

authors: FunMiles barker29 pazner rw-anderson termi-official thorvath12 tzanio v-dobrev

repo: mfem/mfem


text:
HYPRE Triangular Solver API Break

It looks like the latest HYPRE commit to the master branch here has an API break that breaks compiling the examples. This could also be related to HYPRE+CUDA.
MFEM configuration:
make config \
  MFEM_USE_OPENMP=YES MFEM_USE_MPI=YES CC=mpixlc CXX=mpixlC \
  MPICC=mpixlc MPICXX=mpixlC \
  HYPRE_DIR=${HYPRE_DIR} \
  METIS_DIR=${METIS_DIR} MFEM_USE_METIS_5=YES \
  MFEM_USE_CUDA=YES CUDA_CXX=nvcc \
  CUDA_FLAGS='-x=cu -arch=sm_70 --expt-extended-lambda --compiler-options -O3' \
  CUDA_LIB='-lcusparse -lcurand -lcublas'

HYPRE configuration:
CUDA_HOME=${OLCF_CUDA_ROOT} \
  HYPRE_CUDA_SM=70 \
  CC=mpixlc \
  CXX=mpixlC \
  ./configure \
  --disable-fortran \
  --with-cuda \
  --enable-unified-memory \
  --enable-device-memory-pool \
  --enable-cusparse \
  --enable-cublas \
  --enable-curand

Trying make ex1p in the examples directory produces:
/ccs/proj/csc404/wcdawn/container/hypre/src/hypre/lib/libHYPRE.a(par_relax_device.obj): In function `hypre_BoomerAMGRelaxHybridGaussSeidelDevice':
tmpxft_003cf231_00000000-6_par_relax_device.cudafe1.cpp:(.text+0x414): undefined reference to `hypre_CSRMatrixTriLowerUpperSolveDevice'
tmpxft_003cf231_00000000-6_par_relax_device.cudafe1.cpp:(.text+0x4d0): undefined reference to `hypre_CSRMatrixTriLowerUpperSolveDevice'
tmpxft_003cf231_00000000-6_par_relax_device.cudafe1.cpp:(.text+0x51c): undefined reference to `hypre_CSRMatrixTriLowerUpperSolveDevice'
collect2: error: ld returned 1 exit status
make: *** [makefile:78: ex1p] Error 1

I'm not sure if this is may be as simple as changing function names.

@liruipeng, is there a recommended way to handle this change?

@tzanio Should I use the master branch of mfem to reproduce? BTW, building mfem (with the config above) is super slow. Is this normal? Thanks!

I build ex1p with the master of mfem and the master of hypre, which seemed fine
li50@ray59:~/workspace/mfem/master/examples$ make ex1p
nvcc  -O0 -std=c++11 -x=cu -arch=sm_70 --expt-extended-lambda -ccbin mpixlC -I.. -I/g/g92/li50/workspace/hypre/test/src/hypre/include  -Xcompiler=-fopenmp ex1p.c
pp -o ex1p -L.. -lmfem -L/g/g92/li50/workspace/hypre/test/src/hypre/lib -lHYPRE -lcusparse -lcurand -L/g/g92/li50/workspace/metis-4.0.3/ -lmetis  -lcusparse -lcu
rand -lcublas -lrt

@liruipeng

Should I use the master branch of mfem to reproduce? BTW, building mfem (with the config above) is super slow. Is this normal?

Yes, I built with mfem:master. Yes, it takes a while to build MFEM like this. I'm building on Summit and I built with 32 cores and it took 252 seconds.
I still get the same error. I think you may have a different configuration because your compiler ran with -O0 but mine ran with -O3.  Summit recently underwent an OS upgrade so there could be something new that is causing this. Specifically, there is a new version of nvcc.
nvcc --version
nvcc: NVIDIA (R) Cuda compiler driver
Copyright (c) 2005-2020 NVIDIA Corporation
Built on Wed_Jul_22_19:08:50_PDT_2020
Cuda compilation tools, release 11.0, V11.0.221
Build cuda_11.0_bu.TC445_37.28845127_0

@liruipeng

Should I use the master branch of mfem to reproduce? BTW, building mfem (with the config above) is super slow. Is this normal?

Yes, I built with mfem:master. Yes, it takes a while to build MFEM like this. I'm building on Summit and I built with 32 cores and it took 252 seconds.
I still get the same error. I think you may have a different configuration because your compiler ran with -O0 but mine ran with -O3. Summit recently underwent an OS upgrade so there could be something new that is causing this. Specifically, there is a new version of nvcc.
nvcc --version
nvcc: NVIDIA (R) Cuda compiler driver
Copyright (c) 2005-2020 NVIDIA Corporation
Built on Wed_Jul_22_19:08:50_PDT_2020
Cuda compilation tools, release 11.0, V11.0.221
Build cuda_11.0_bu.TC445_37.28845127_0

Found the error. Stay tuned. Thanks!

Thanks @liruipeng !

@wcdawn can you confirm that mfem:master works for you now with hypre:master?
Thanks again for the quick report.

Works for me now. Thanks!

Resolved by change in hypre, https://github.com/hypre-space/hypre/pull/469

authors: liruipeng tzanio wcdawn


text:
Resolve compiler warnings in gslib.cpp

This PR fixes warnings when compiling with GCC using -Wall -pedantic, which revealed some warnings related to variable length arrays and signed/unsigned type comparison.

PR
Author
Editor
Reviewers
Assignment
Approval
Merge

#3278
@sebastiangrimberg
@tzanio
@atallah727 + @kmittal2
10/30/22
⌛due 11/13/22
⌛due 11/20/22

PR Checklist

[ ] Code builds.
[ ] Code passes make style.
[ ] Update CHANGELOG:

[ ] Is this a new feature users need to be aware of? New or updated example or miniapp?
[ ] Does it make sense to create a new section in the CHANGELOG to group with other related features?

[ ] Update INSTALL:

[ ] Had a new optional library been added? If so, what range of versions of this library are required? (Make sure the external library is compatible with our BSD license, e.g. it is not licensed under GPL!)
[ ] Have the version ranges for any required or optional libraries changed?
[ ] Does make or cmake have a new target?
[ ] Did the requirements or the installation process change? (rare)

[ ] Update continuous integration server configurations if necessary (e.g. with new version requirements for each of MFEM's dependencies)

[ ] .github
[ ] .appveyor.yml

[ ] Update .gitignore:

[ ] Check if make distclean; git status shows any files that were generated from the source by the project (not an IDE) but we don't want to track in the repository.
[ ] Add new patterns (just for the new files above) and re-run the above test.

[ ] New examples:

[ ] All sample runs at the top of the example source file work.
[ ] Update examples/makefile:

[ ] Add the example code to the appropriate SEQ_EXAMPLES and PAR_EXAMPLES variables.
[ ] Add any files generated by it to the clean target.
[ ] Add the example binary and any files generated by it to the top-level .gitignore file.

[ ] Update examples/CMakeLists.txt:

[ ] Add the example code to the ALL_EXE_SRCS variable.
[ ] Make sure THIS_TEST_OPTIONS is set correctly for the new example.

[ ] List the new example in doc/CodeDocumentation.dox.
[ ] If new examples directory (e.g.examples/pumi), list it in doc/CodeDocumentation.conf.in
[ ] Companion pull request for documentation in mfem/web repo:

[ ] Update or add example-specific documentation, see e.g. the src/examples.md.
[ ] Add the description, labels and screenshots in src/examples.md and src/img.
[ ] In examples.md, list the example under the appropriate categories, add new categories if necessary.
[ ] Add a short description of the example in the "Extensive Examples" section of features.md.

[ ] New miniapps:

[ ] All sample runs at the top of the miniapp source file work.
[ ] Update top-level makefile and makefile in corresponding miniapp directory.
[ ] Add the miniapp binary and any files generated by it to the top-level .gitignore file.
[ ] Update CMake build system:

[ ] Update the CMakeLists.txt file in the miniapps directory, if the new miniapp is in a new directory.
[ ] Add/update the CMakeLists.txt file in the new miniapp directory.
[ ] Consider adding a new test for the new miniapp.

[ ] List the new miniapp in doc/CodeDocumentation.dox
[ ] If new miniapps directory (e.g.miniapps/nurbs), add it to MINIAPP_SUBDIRS in the makefile.
[ ] If new miniapps directory (e.g.miniapps/nurbs), list it in doc/CodeDocumentation.conf.in
[ ] Companion pull request for documentation in mfem/web repo:

[ ] Update or add miniapp-specific documentation, see e.g. the src/meshing.md and src/electromagnetics.md files.
[ ] Add the description, labels and screenshots in src/examples.md and src/img.
[ ] The miniapps go at the end of the page, and are usually listed only under a specific "Application (PDE)" category.
[ ] Add a short description of the miniapp in the "Extensive Examples" section of features.md.

[ ] New capability:

[ ] All new public, protected, and private classes, methods, data members, and functions have full Doxygen-style documentation in source comments. Documentation should include descriptions of member data, function arguments and return values, template parameters, and prerequisites for calling new functions.
[ ] Pointer arguments and return values must specify whether ownership is being transferred or lent with the call.
[ ] Any new functions should include descriptions of their intended use e.g. for internal use only, user-facing, etc., along with references to example code whenever possible/appropriate.
[ ] Consider adding new sample runs in existing examples to highlight the new capability.
[ ] Consider saving cool simulation pictures with the new capability in the Confluence gallery (LLNL only) or submitting them, via pull request, to the gallery section of the mfem/web repo.
[ ] If this is a major new feature, consider mentioning it in the short summary inside README (rare).
[ ] List major new classes in doc/CodeDocumentation.dox (rare).

[ ] Update this checklist, if the new pull request affects it.
[ ] Run make unittest to make sure all unit tests pass.
[ ] Run the tests in tests/scripts.
[ ] (LLNL only) After merging:

[ ] Update internal tests to include the new features.

This PR is now under review (see the table in the PR description). To help with the review process, please do not force push to the branch.

Merged in next for testing...

authors: sebastiangrimberg tzanio


text:
Trial/rebase try1 rebase 前

rebase 前にどんな差分ができるのかテスト

期待通り、自分の変更よりも前の差分が含まれた。
これを自分のやったものだけの差分にしたい

repo: mganeko/momo


text:
e2e testing failing

I'm submitting a ...  (check one with "x")
[x] bug report => search github for a similar issue or PR before submitting (Nothing solves this)

Current behavior
Running end to end testing failed.  All three methods I tried fail for different reasons.  See reproduction and OUTPUTS header.

(new edit)  I went back to b60150ec5f5b17f615d677b71bce02f99aa58daf (May10) and the testing is failing there also.  I didn't look any further through the history.
Expected behavior
e2e.spec tests would be run and succeed / fail accordingly.
Minimal reproduction of the problem with instructions

Clone repository
Run npm run e2e or npm run e2e.ci or protractor

What is the motivation / use case for changing the behavior?
I want testing to work
Please tell us about your environment:

Angular Seed Version: 2.0.X

2.01
current master (4b0183780f0dc24afbad2d19b2b1ee21db475507   Tue Oct 25 13:39:03 2016 -0700)

Node: node --version =

v5.12.0
v6.8.0 both tried

** OUTPUTS **
Using node v6.8.0.
npm run e2e
[nix-shell:~/dev/work/ga/_Angular/angular2-seed]$ npm run e2e

> angular2-seed@0.0.0 e2e /Users/brookes/dev/work/ga/_Angular/angular2-seed
> protractor

[13:41:39] I/direct - Using ChromeDriver directly...
[13:41:39] I/launcher - Running 1 instances of WebDriver

/Users/brookes/dev/work/ga/_Angular/angular2-seed/node_modules/selenium-webdriver/error.js:27
    super(opt_error);
    ^
SessionNotCreatedError: session not created exception
from unknown error: Runtime.executionContextCreated has invalid 'context': {"auxData":{"frameId":"27961.1","isDefault":true},"id":1,"name":"","origin":"://"}
  (Session info: chrome=54.0.2840.71)
  (Driver info: chromedriver=2.21.371459 (36d3d07f660ff2bc1bf28a75d1cdabed0983e7c4),platform=Mac OS X 10.12.1 x86_64)
    at WebDriverError (/Users/brookes/dev/work/ga/_Angular/angular2-seed/node_modules/selenium-webdriver/error.js:27:5)
    at SessionNotCreatedError (/Users/brookes/dev/work/ga/_Angular/angular2-seed/node_modules/selenium-webdriver/error.js:296:5)
    at Object.checkLegacyResponse (/Users/brookes/dev/work/ga/_Angular/angular2-seed/node_modules/selenium-webdriver/error.js:580:13)
    at /Users/brookes/dev/work/ga/_Angular/angular2-seed/node_modules/selenium-webdriver/lib/webdriver.js:64:13
    at Promise.invokeCallback_ (/Users/brookes/dev/work/ga/_Angular/angular2-seed/node_modules/selenium-webdriver/lib/promise.js:1329:14)
    at TaskQueue.execute_ (/Users/brookes/dev/work/ga/_Angular/angular2-seed/node_modules/selenium-webdriver/lib/promise.js:2790:14)
    at TaskQueue.executeNext_ (/Users/brookes/dev/work/ga/_Angular/angular2-seed/node_modules/selenium-webdriver/lib/promise.js:2773:21)
    at asyncRun (/Users/brookes/dev/work/ga/_Angular/angular2-seed/node_modules/selenium-webdriver/lib/promise.js:2652:27)
    at /Users/brookes/dev/work/ga/_Angular/angular2-seed/node_modules/selenium-webdriver/lib/promise.js:639:7
    at process._tickCallback (internal/process/next_tick.js:103:7)
From: Task: WebDriver.createSession()
    at acquireSession (/Users/brookes/dev/work/ga/_Angular/angular2-seed/node_modules/selenium-webdriver/lib/webdriver.js:62:22)
    at Function.createSession (/Users/brookes/dev/work/ga/_Angular/angular2-seed/node_modules/selenium-webdriver/lib/webdriver.js:295:12)
    at Driver (/Users/brookes/dev/work/ga/_Angular/angular2-seed/node_modules/selenium-webdriver/chrome.js:778:38)
    at Direct.getNewDriver (/Users/brookes/dev/work/ga/_Angular/angular2-seed/node_modules/protractor/built/driverProviders/direct.js:65:26)
    at Runner.createBrowser (/Users/brookes/dev/work/ga/_Angular/angular2-seed/node_modules/protractor/built/runner.js:182:43)
    at /Users/brookes/dev/work/ga/_Angular/angular2-seed/node_modules/protractor/built/runner.js:255:30
    at _fulfilled (/Users/brookes/dev/work/ga/_Angular/angular2-seed/node_modules/q/q.js:834:54)
    at self.promiseDispatch.done (/Users/brookes/dev/work/ga/_Angular/angular2-seed/node_modules/q/q.js:863:30)
    at Promise.promise.promiseDispatch (/Users/brookes/dev/work/ga/_Angular/angular2-seed/node_modules/q/q.js:796:13)
    at /Users/brookes/dev/work/ga/_Angular/angular2-seed/node_modules/q/q.js:556:49
[13:41:40] E/launcher - Process exited with error code 1

npm ERR! Darwin 16.1.0
npm ERR! argv "/nix/store/xj6dkgd4p92k39vpflgq96ka5s6n0zxm-nodejs-6.8.0/bin/node" "/nix/store/hmz1inq8bky8kwxsc15jybgwrk0klmb2-nodejs/bin/npm" "run" "e2e"
npm ERR! node v6.8.0
npm ERR! npm  v3.10.8
npm ERR! code ELIFECYCLE
npm ERR! angular2-seed@0.0.0 e2e: `protractor`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the angular2-seed@0.0.0 e2e script 'protractor'.
npm ERR! Make sure you have the latest version of node.js and npm installed.
npm ERR! If you do, this is most likely a problem with the angular2-seed package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     protractor
npm ERR! You can get information on how to open an issue for this project with:
npm ERR!     npm bugs angular2-seed
npm ERR! Or if that isn't available, you can get their info via:
npm ERR!     npm owner ls angular2-seed
npm ERR! There is likely additional logging output above.

npm ERR! Please include the following file with any support request:
npm ERR!     /Users/brookes/dev/work/ga/_Angular/angular2-seed/npm-debug.log

npm run e2e.ci
[nix-shell:~/dev/work/ga/_Angular/angular2-seed]$ npm run e2e.ci

> angular2-seed@0.0.0 e2e.ci /Users/brookes/dev/work/ga/_Angular/angular2-seed
> gulp build.prod --color && gulp build.js.e2e --color && gulp e2e --color

[13:42:34] Requiring external module ts-node/register
[13:42:37] Loading tasks folder /Users/brookes/dev/work/ga/_Angular/angular2-seed/tools/tasks/seed
[13:42:37] Registering task ~/dev/work/ga/_Angular/angular2-seed/tools/tasks/seed/build.assets.dev
...
[13:42:37] Registering task ~/dev/work/ga/_Angular/angular2-seed/tools/tasks/seed/watch.test
[13:42:37] Registering task ~/dev/work/ga/_Angular/angular2-seed/tools/tasks/seed/webdriver
[13:42:37] Loading tasks folder /Users/brookes/dev/work/ga/_Angular/angular2-seed/tools/tasks/project
[13:42:37] Registering task ~/dev/work/ga/_Angular/angular2-seed/tools/tasks/project/sample.task
[13:42:37] Using gulpfile ~/dev/work/ga/_Angular/angular2-seed/gulpfile.ts
[13:42:37] Starting 'build.prod'...
[13:42:37] Starting 'check.tools'...
[13:42:37] Tools not compiled, skipping rebuild
[13:42:37] Finished 'check.tools' after 373 ms
[13:42:37] Starting 'clean.prod'...
[13:42:37] Deleted dist/prod
[13:42:37] Deleted dist/tmp
[13:42:37] Finished 'clean.prod' after 65 ms
[13:42:37] Starting 'tslint'...

/Users/brookes/dev/work/ga/_Angular/angular2-seed/node_modules/codelyzer/angular/templateParser.js:6
    var TemplateParser = _.TemplateParser;
                          ^
TypeError: Cannot read property 'TemplateParser' of undefined
    at Object.exports.parseTemplate (/Users/brookes/dev/work/ga/_Angular/angular2-seed/node_modules/codelyzer/angular/templateParser.js:6:27)
    at InputMetadataWalker.Ng2Walker.visitClassDecorator (/Users/brookes/dev/work/ga/_Angular/angular2-seed/node_modules/codelyzer/angular/ng2Walker.js:115:62)
    at Array.forEach (native)
    at InputMetadataWalker.Ng2Walker.visitClassDeclaration (/Users/brookes/dev/work/ga/_Angular/angular2-seed/node_modules/codelyzer/angular/ng2Walker.js:72:40)
    at InputMetadataWalker.SyntaxWalker.visitNode (/Users/brookes/dev/work/ga/_Angular/angular2-seed/node_modules/tslint/lib/language/walker/syntaxWalker.js:264:22)
    at /Users/brookes/dev/work/ga/_Angular/angular2-seed/node_modules/tslint/lib/language/walker/syntaxWalker.js:459:63
    at visitEachNode (/Users/brookes/dev/work/ga/_Angular/angular2-seed/node_modules/typescript/lib/typescript.js:8338:30)
    at Object.forEachChild (/Users/brookes/dev/work/ga/_Angular/angular2-seed/node_modules/typescript/lib/typescript.js:8498:24)
    at InputMetadataWalker.SyntaxWalker.walkChildren (/Users/brookes/dev/work/ga/_Angular/angular2-seed/node_modules/tslint/lib/language/walker/syntaxWalker.js:459:12)
    at InputMetadataWalker.SyntaxWalker.visitSourceFile (/Users/brookes/dev/work/ga/_Angular/angular2-seed/node_modules/tslint/lib/language/walker/syntaxWalker.js:190:14)

npm ERR! Darwin 16.1.0
npm ERR! argv "/nix/store/xj6dkgd4p92k39vpflgq96ka5s6n0zxm-nodejs-6.8.0/bin/node" "/nix/store/hmz1inq8bky8kwxsc15jybgwrk0klmb2-nodejs/bin/npm" "run" "e2e.ci"
npm ERR! node v6.8.0
npm ERR! npm  v3.10.8
npm ERR! code ELIFECYCLE
npm ERR! angular2-seed@0.0.0 e2e.ci: `gulp build.prod --color && gulp build.js.e2e --color && gulp e2e --color`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the angular2-seed@0.0.0 e2e.ci script 'gulp build.prod --color && gulp build.js.e2e --color && gulp e2e --color'.
npm ERR! Make sure you have the latest version of node.js and npm installed.
npm ERR! If you do, this is most likely a problem with the angular2-seed package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     gulp build.prod --color && gulp build.js.e2e --color && gulp e2e --color
npm ERR! You can get information on how to open an issue for this project with:
npm ERR!     npm bugs angular2-seed
npm ERR! Or if that isn't available, you can get their info via:
npm ERR!     npm owner ls angular2-seed
npm ERR! There is likely additional logging output above.

npm ERR! Please include the following file with any support request:
npm ERR!     /Users/brookes/dev/work/ga/_Angular/angular2-seed/npm-debug.log

protractor
[nix-shell:~/dev/work/ga/_Angular/angular2-seed]$ protractor
[13:43:50] I/direct - Using ChromeDriver directly...
[13:43:50] I/launcher - Running 1 instances of WebDriver

/Users/brookes/dev/work/ga/_Angular/angular2-seed/node_modules/selenium-webdriver/error.js:27
    super(opt_error);
    ^
SessionNotCreatedError: session not created exception
from unknown error: Runtime.executionContextCreated has invalid 'context': {"auxData":{"frameId":"27996.1","isDefault":true},"id":1,"name":"","origin":"://"}
  (Session info: chrome=54.0.2840.71)
  (Driver info: chromedriver=2.21.371459 (36d3d07f660ff2bc1bf28a75d1cdabed0983e7c4),platform=Mac OS X 10.12.1 x86_64)
    at WebDriverError (/Users/brookes/dev/work/ga/_Angular/angular2-seed/node_modules/selenium-webdriver/error.js:27:5)
    at SessionNotCreatedError (/Users/brookes/dev/work/ga/_Angular/angular2-seed/node_modules/selenium-webdriver/error.js:296:5)
    at Object.checkLegacyResponse (/Users/brookes/dev/work/ga/_Angular/angular2-seed/node_modules/selenium-webdriver/error.js:580:13)
    at /Users/brookes/dev/work/ga/_Angular/angular2-seed/node_modules/selenium-webdriver/lib/webdriver.js:64:13
    at Promise.invokeCallback_ (/Users/brookes/dev/work/ga/_Angular/angular2-seed/node_modules/selenium-webdriver/lib/promise.js:1329:14)
    at TaskQueue.execute_ (/Users/brookes/dev/work/ga/_Angular/angular2-seed/node_modules/selenium-webdriver/lib/promise.js:2790:14)
    at TaskQueue.executeNext_ (/Users/brookes/dev/work/ga/_Angular/angular2-seed/node_modules/selenium-webdriver/lib/promise.js:2773:21)
    at asyncRun (/Users/brookes/dev/work/ga/_Angular/angular2-seed/node_modules/selenium-webdriver/lib/promise.js:2652:27)
    at /Users/brookes/dev/work/ga/_Angular/angular2-seed/node_modules/selenium-webdriver/lib/promise.js:639:7
    at process._tickCallback (internal/process/next_tick.js:103:7)
From: Task: WebDriver.createSession()
    at acquireSession (/Users/brookes/dev/work/ga/_Angular/angular2-seed/node_modules/selenium-webdriver/lib/webdriver.js:62:22)
    at Function.createSession (/Users/brookes/dev/work/ga/_Angular/angular2-seed/node_modules/selenium-webdriver/lib/webdriver.js:295:12)
    at Driver (/Users/brookes/dev/work/ga/_Angular/angular2-seed/node_modules/selenium-webdriver/chrome.js:778:38)
    at Direct.getNewDriver (/Users/brookes/dev/work/ga/_Angular/angular2-seed/node_modules/protractor/built/driverProviders/direct.js:65:26)
    at Runner.createBrowser (/Users/brookes/dev/work/ga/_Angular/angular2-seed/node_modules/protractor/built/runner.js:182:43)
    at /Users/brookes/dev/work/ga/_Angular/angular2-seed/node_modules/protractor/built/runner.js:255:30
    at _fulfilled (/Users/brookes/dev/work/ga/_Angular/angular2-seed/node_modules/q/q.js:834:54)
    at self.promiseDispatch.done (/Users/brookes/dev/work/ga/_Angular/angular2-seed/node_modules/q/q.js:863:30)
    at Promise.promise.promiseDispatch (/Users/brookes/dev/work/ga/_Angular/angular2-seed/node_modules/q/q.js:796:13)
    at /Users/brookes/dev/work/ga/_Angular/angular2-seed/node_modules/q/q.js:556:49
[13:43:51] E/launcher - Process exited with error code 1

We're running e2e tests in CI and the build passes. What's your OS?

Cool.  We are currently on release 2.0.1 and I think I must have rooted my checkout to that.
I checked out the head of master and run npm run build.e2e and npm run e2e and it looked good.  Though the tests seem to be failing as they are failing.  Obviously some things need to be fixed still.
Do you have an eta for when the next release is expected?  As it seems we should wait until then before sorting our tests out.

In case the issue is not related to the seed we can move the conversation to gitter.

Yeah sorry, I thought it was an issue.  Thanks.

authors: mgechev oehm-smith

repo: mgechev/angular-seed

license: mit


text:
Fixes lexical scope issues on error, referenced in issue #1300

We stumbled upon this error too today, thanks to @rbr82 for this finding.
Fixes #1300

Thanks for the PR.

authors: maxmarkus mgechev


text:
initialized module support

I understand that in order to provide autocomplete for private module attributes that you need to "see" and have access to the module.
I was wondering, considering that a terraform init downloads the modules into the .terraform directory, whether you would be able to parse the variables.tf from there to provide a list of possible attributes for autocomplete?
"There is support for public and private modules by utilizing the APIs provided by Hashicorp..."
The private modules in my case are held in github, so the module source refers to a github repo using a version tag.
terraform init downloads the module into the .terraform directory, so there's nothing special required to access the module.
Can you parse an initialized module's variables.tf for a list of possible module attributes, and pass them to the completer for user visualisation?

Actually, this is already possible through the terraform language server in the terraform vscode extension, so long as the source url format is set correctly.
There is a bug affecting it at the moment for github.com sources of initialized modules.
https://github.com/hashicorp/vscode-terraform/issues/1440

repo: mgtrrz/terraform-completer


text:
Mock datetime for save_transformation_to_json test

def test_save_transformation_to_json(self, transformation_encoder, file_transformation, tmp_path, mocker):
    date_mocker = mocker.patch('renamerename.executor.encoder_decoder.datetime')
    date_mocker.now.strftime.return_value = "X"
    transformation_encoder.save_transformation_to_json(tmp_path, file_transformation)
    assert 1 == 1
    mocker.resetall()

The call generated by the patched object is not returning the required value "X"

Done in dd1ac4813f3f9b670be2d9851521cb498afe7e39

repo: mhmdkanj/RenameRename


text:
Incorporate CSS column guide

https://gist.github.com/javasteve99/3013151
Make it mesh well with Pure css?
https://purecss.io/grids/#grids-units-sizes
[grid] {
	width: 128rem;
	margin: 0 auto;
	background-size: 33rem;
	background-image: linear-gradient(
		to right,
		rgba(255, 0, 0, 0.25) 0,
		rgba(255, 0, 0, 0.25) 29rem,
		transparent 29rem
	);
	background-attachment: local;
	background-origin: content-box;
	position: absolute;
	top: 0;
	right: 0;
	bottom: 0;
	left: 0;
	z-index: 999;
	pointer-events: none;
}
@media (min-width: 35.5em) {

}
@media (min-width: 48em) {

}
@media (min-width: 64em) {

}
@media (min-width: 80em) {

}
@media (min-width: 120em) {

}

Just found this:
https://github.com/larsenwork/CSS-Responsive-Grid-Overlay
Tryy to ignore the CSS Tricks paid advert article promoting his chrome plugin! :)
CSS Tricks please!

Hey, just ran across this project the other day. My project (H5C3.gs) is an example of how you could implement your grid column guides using modern css.

authors: djburkhart mhulse

repo: mhulse/ps-web-starters


text:
Finetuning & Doku

Runden Sie die Anwendung ab, dass nutzbar ist. Dokumentieren Sie, wie fremde Dritte sie installieren und nutzen können und erzeugen
Sie einen Screenmovie (max 5min Länge) von der fertigen Anwendung. Laden Sie das Video hier hoch: th-koeln.sciebo.de/s/RydIagW8Uij1ZG5
Investieren Sie max 16 Stunden in das Issue.

Des Weiteren wird das Feedback aus dem Pullrequest #10  implementiert!


text:
docs(root): added icon button variants with web component and React c…

…ode snippets
Added icon button variants with web component and React code snippets

Summary of the changes
Added icon button variants (primary, secondary, tertiary, destructive) with Web Component and React code snippets
Related issue
#1010
Checklist

[] I have manually accessibility tested any changes, if relevant.
[X] I have raised this pull request against the develop branch

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Putting this on hold at the moment until the StackBlitz work goes in. Hoping this will be unblocked by tomorrow

This is unblocked now. Please rebase off origin/develop and follow the new format for code snippets. Thank you!

Noticed the web components and react code snippets still have one button with variant="icon" but we're not showing an example of that in the component preview. Not sure which is best, but we'll either want to remove the code snippets for that or add another button into the component preview.


text:
Subreddit Search implemented

I implemented searching of a subreddit using praw's search function. Simply type f to open the search prompt. If no results were found, there is a popup message.
Also moved prompt_input to it's own method in the BasePage so it can be used for future prompts.
#39

From issue #39

Will need a special case for the front page

Yep, just noticed this

Might want to make the prompt a different color to differentiate from the subreddit prompt. green or yellow maybe?

Does it need to be different? I thought since you'd only have one at a time and they'd each have descriptions that the same color would be fine.

Should be catching specific exceptions in your try-except block

Will do

Are multireddits searchable? E.g. /r/python+programming

Yes they are.

repo: michael-lazar/rtv


text:
Added Tanveer bio

Added the bio and relevant at the end of the notebook. If it is too long, feel free to edit.

Perfect, thanks!  I'll make a few tweaks of format probably.  Let me know if you're unhappy with any changes.

authors: michaelJwilson tanveerkarim

repo: michaelJwilson/DESI-HighSchool


text:
Adding total number of members in the fnotch output results

To be able to select out clustering that might be noise, I need to know how many total members are jointly in the fnotch. I can't find an east way to go back to the individual fan and blotch catalogs you generate. @michaelaye  can you please output the sum of the members of the fan+ blotch in your fnotch output? thanks

Just for my understanding, is this different from #18? And, considering that we agreed not to artificially combine markings of fans and blotches of fnotches, shouldn't I rather keep track of both the number of cluster members of the mean fan AND the mean blotch that make up the fnotch instead of just the sum of both?

I forgot in the title for that other ticket I mentioned outputting this.
I want for each individual source which I'm taking as a fnotch - so you can save and report the total number of fan markings and total number of blotch markings that went into it or the total, since the fnotch scores gives the relative frequency of one to the other.

Fixed by a7d95fd0bd8600b40f796fce7e9c840de494ea72

authors: michaelaye mschwamb

license: isc


text:
dirPaginate: track by $index breaks the directive

If we want to allow duplicates we need to use track by $index but it doesn't work with dir-paginate. Here is the error it throws - Pagination directive: the 'itemsPerPage' filter must be set.
This is the code i am using
tr dir-paginate="location in locations track by $index | itemsPerPage: 5">

Try putting the "track by" part of the expression at the end:
<tr dir-paginate="location in locations | itemsPerPage: 5 track by $index">

Let me know if that works for you.

Yes, It seems to work with this. Thanks a lot. Great Utility

Cool, glad it got sorted.

It seems like track by $index restarts when pagingating to another page. Is this correct behavior?
I would like the $index to continue correctly even if I am on page 2 for instance

@cash1981 Yes, this is correct behaviour. $index is exposed by the ngRepeat directive and is only aware of what is displayed on the current page. To figure out the index, use this formula:
absolute_index = $index + ($scope.currentPage - 1) * $scope.pageSize;

Thanks
Will try.
Thanks for the great and easy tool

authors: RahulKatariya cash1981 michaelbromley

repo: michaelbromley/angularUtils


text:
Bug: The library is not working on mobile (or tablet) devices

Bug Summary
The WebGL fluid enhanced library works amazingly well on desktop devices. It really is a beautiful library, thanks for making this. However, on touch devices, it doesnt seem to work. Could this have something to do with the configuration of the canvas?
Expected behavior
On moving your finger through the div, the fluid colors should appear.
Actual Behavior
On moving your finger through the div, nothing happens.
Steps to reproduce
This is the code I have written, it is pretty similar to what has been mentioned in the documents for Next.js. What I am using is Next.js, Typescript, and TailwindCSS. There's some GSAP too, but none in this component. It's parent is a client component.
import React, ( useEffect, useRef } from "react";
import WebGLFluidEnhanced from "webgl-fluid-enhanced";

const Contact = () => {
  const containerRef = useRef(null);

  useEffect(() => {
    if (containerRef.current) {
      const simulation = new WebGLFluidEnhanced(containerRef.current);
      simulation.setConfig({
        densityDissipation: 0.5,
        velocityDissipation: 0.4,
        pressure: 0.5,
        curl: 4,
        colorPalette: ["#5D0E85", "#45056E", "#2D004E"],
        bloom: false,
        colorful: false,
      });
      simulation.start();

      return () => {
        simulation.stop();
      };
    }
  }, []);

  return (

          Some text here

  );
};

export default Contact;

The issue is probably with that the div blocks pointer events. Try adding the tailwind class pointer-events-none

That seems to break it entirely, for both the mobile and the desktop devices.

You have to put it on the absolute div, not the div with the simulation

Hey @michaelbrusegard , sorry, super busy at work, completely spaced out on this haha. I did try both, and they don't work. I also removed everything inside the div to just keep the container where the simulation is applied, but that doesn't solve it either.

does it work without the absolute div?

No, it doesn't.

I am very confused, I can take a deeper look at it after exams this semester, but for the moment I advice looking at how it is setup in the playground on the documentation website. It uses Nextjs and react, and it works on mobile completely fine. Maybe the issue is something else? Is the problem related to having the canvas in just a small portion of the website and then dragging through it?

Honestly, this is tripping me up too. I tinkered around a bit, and I found that it does work for mobile, so we can close the issue. The bug still persists though, (this is just me sharing this because I find it very curious, maybe it's easy, but I am a junior dev haha), but, the component renders perfectly, as long as it is rendered on the top of the page. If I have more components before, and then render this, then it fails to work in the intended way.

authors: KartikChinda michaelbrusegard

repo: michaelbrusegard/WebGL-Fluid-Enhanced


text:
fixes: win32 cpu and ram; resurrect extension

This PR fixes the ram and cpu modules on Windows.
Also fixes the filename of resurrect.lua so the extension loads as expected.

this is great! Thank you

authors: joncrangle michaelbrusegard


text:
Don't test the installer, since it requires an internet connection

Internet connections can be flaky, so tests should not rely on them

Thanks! I've added the new file to the circleci configuration too (see d9c2dc184b9771ed14a56a52587c954203127a15)

authors: devurandom michaelcontento

repo: michaelcontento/circleci-matrix


text:
Split location manager into two managers to support observers and dir…

Overview

Split location manager into two managers to support observers and direct queries at the same time.
This PR does the following:

Add a new location manager instance to be used with the observer/watch calls. This means the observer can use different settings than the getCurrentPosition call, and the observer can use the significant changes API while still being able to do accurate requests

Add a bug fix where listening to updates would immediately return a recently cached value. This means the updates will be disabled right after, and we never get the final update. Observed behaviour mostly on the simulator when testing multiple locations.

getCurrentPosition no longer allows to use significant changes API (as documented, not a breaking a change)

Please review. The issue this PR fixes was not observed on Android, nor Android's react-native-geolocation-service (which should honestly be merged into this)
Test Plan

Tested on various iOS simulators using the location simulation feature. Tests were done using the watch/observe API with different settings (significant changes, high/low precision, etc) while also periodically requesting location with the getCurrentPosition call.
Lastly, tested on a real device (13.2.3)

Any reviews? Thoughts? Possible caveats?

Hey @cristianoccazinsp !
Thank you for this PR. I took over this library and I would like to land this PR. Are you interested in following it up?
It would be super helpful if you could point it to the next branch, rebase it and remove indentation changes.

Hi @michalchudziak , I actually switched to https://github.com/Agontuk/react-native-geolocation-service which proved to be much more reliable and customizable.

I completely understand! Good luck :)

authors: cristianoccazinsp michalchudziak

repo: michalchudziak/react-native-geolocation


text:
Using AOS in Astro

Hi @michalsnik,
First, I got this working on a react-based site.
Now I'm building a new one with Astro.
I have used npm to install AOS.
I added the import command, and the init to the 'index.astro' page but it doesn't seem to want to do anything.
Here's the site, if poking around helps: https://cheapfm.com/
Thank you!

Try to add like this:

Create file in src/js/main.js

import AOS from 'aos';
import 'aos/dist/aos.css'
AOS.init()

In src/layouts/Layout.astro

<!DOCTYPE html>
<html lang="pl">
  <head>
...
  </head>
  <body>
    <slot />

    <script src="../js/main"></script> <- add this
  </body>
</html>

and your good to go

I have animation only after the first opening, then the elements appear without animation. After clearing the cache, the animations reappear until the page changes

Fix:

I'm using TailwindCSS and adding duration-[400].
or
Add data-aos-duration='400'

in your principal layout in your head add
<link rel="stylesheet" href="https://unpkg.com/aos@next/dist/aos.css" />
and before your closing body tag
<script is:inline src="https://unpkg.com/aos@next/dist/aos.js"></script>
<script is:inline>
  AOS.init();
</script>

@Willywes works like a charm. Thank you.

@Willywes thanks a lot! ❤

authors: HighError Willywes aam-himel ariley burasuk guttenbergovitz

repo: michalsnik/aos


text:
Crash

When I add a shortcut from opera to home screen and longclick on that shortcut the launcher crashes.
This is log of crash
java.lang.NullPointerException: Attempt to invoke virtual method 'java.lang.String android.content.ComponentName.getPackageName()' on a null object reference
03-30 20:55:58.864 E/AndroidRuntime( 7157): 	at com.android.launcher3.util.ShortcutsManager.getShortcutsBasedOnTag(ShortcutsManager.java:47)
03-30 20:55:58.864 E/AndroidRuntime( 7157): 	at com.android.launcher3.Launcher.onLongClick(Launcher.java:3290)
03-30 20:55:58.864 E/AndroidRuntime( 7157): 	at android.view.View.performLongClick(View.java:5243)
03-30 20:55:58.864 E/AndroidRuntime( 7157): 	at android.widget.TextView.performLongClick(TextView.java:9225)
03-30 20:55:58.864 E/AndroidRuntime( 7157): 	at com.android.launcher3.CheckLongPressHelper$CheckForLongPress.run(CheckLongPressHelper.java:41)
03-30 20:55:58.864 E/AndroidRuntime( 7157): 	at android.os.Handler.handleCallback(Handler.java:739)
03-30 20:55:58.864 E/AndroidRuntime( 7157): 	at android.os.Handler.dispatchMessage(Handler.java:95)
03-30 20:55:58.864 E/AndroidRuntime( 7157): 	at android.os.Looper.loop(Looper.java:148)
03-30 20:55:58.864 E/AndroidRuntime( 7157): 	at android.app.ActivityThread.main(ActivityThread.java:5471)
03-30 20:55:58.864 E/AndroidRuntime( 7157): 	at java.lang.reflect.Method.invoke(Native Method)
03-30 20:55:58.864 E/AndroidRuntime( 7157): 	at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:726)
03-30 20:55:58.864 E/AndroidRuntime( 7157): 	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:616)

You have to set package name in edit text, show me screenshot of your dialog.
N.B
Shortcuts added by dialog isn't persistent, so if you restart launcher they disappear!

I add link from opera like this

It appeared on launcher

When I long clicked it crashed (unfortunately ...)
They don't disappear on restart or crash. That log is of that crash only

Maybe the shortcuts has brick..you must uninstall the launcher to reset preference...

Tried that uninstalling reinstalling clearing data
Still crashing on long clicking.
I think It is problem with shortcut manager.
Because when I am long clicking any other thing it is not crashing . and when I moved that shortcut to a folder then it not crashed on long click so it does not crash in folder because shortcuts are not opened in folder.

Fixed! next update 0.1.0 Alpha 50

authors: YAJATapps michelelacorte

repo: michelelacorte/FlickLauncher


text:
License?

@michitaro  - Hi, I was looking for a TS / JS HEALPix package, thinking to write one, and now see that you've already done it. Awesome, thanks!
One question concerning license: is it really MIT?
The original C++ lib is GPL, so I assume you didn't copy from there?

I wrote this from scratch, borrowing only API interfaces from healpy.
So yes, this is MIT licensed.

Great, thanks for confirming!

authors: cdeil michitaro

repo: michitaro/healpix


text:
Error building micro_ros_agent due to missing target /opt/ros/humble/lib/libfastrtps.so.2.6.8

Hello,
I am encountering an issue while building the micro_ros_agent package in my workspace. The error indicates a missing target for /opt/ros/humble/lib/libfastrtps.so.2.6.8. Here are the details:
Build Command:
colcon build
Error Output:
[0.411s] WARNING:colcon.colcon_core.package_selection:Some selected packages are already built in one or more underlay workspaces:
... (output omitted for brevity) ...
--- stderr: micro_ros_agent
gmake[2]: *** 'micro_ros_agent' に必要なターゲット '/opt/ros/humble/lib/libfastrtps.so.2.6.8' を make するルールがありません.  中止.
gmake[1]: *** [CMakeFiles/Makefile2:137: CMakeFiles/micro_ros_agent.dir/all] エラー 2
gmake: *** [Makefile:146: all] エラー 2
Environment:
ROS 2 Distribution: Humble
OS: [Your OS, e.g., Ubuntu 22.04]
micro-ROS workspace: /home/takasei/microros_ws
colcon version: [Run colcon version to get this information]

Steps to Reproduce:
Source the ROS 2 Humble workspace:

source /opt/ros/humble/setup.bash
Set up the micro-ROS workspace:
cd ~/microros_ws
colcon build

Encounter the error above.

Questions:
How can I resolve the missing target for /opt/ros/humble/lib/libfastrtps.so.2.6.8?
Is this a compatibility issue between micro-ROS and ROS 2 Humble?
Are there any specific dependencies or setup steps I might have missed?

[0.411s] WARNING:colcon.colcon_core.package_selection:Some selected packages are already built in one or more underlay workspaces:
'nav_msgs' is in: /home/takasei/microros_ws/install/nav_msgs, /opt/ros/humble
'test_msgs' is in: /home/takasei/microros_ws/install/test_msgs, /opt/ros/humble
'composition_interfaces' is in: /home/takasei/microros_ws/install/composition_interfaces, /opt/ros/humble
'geometry_msgs' is in: /home/takasei/microros_ws/install/geometry_msgs, /opt/ros/humble
'rosgraph_msgs' is in: /home/takasei/microros_ws/install/rosgraph_msgs, /opt/ros/humble
'common_interfaces' is in: /home/takasei/microros_ws/install/common_interfaces, /opt/ros/humble
'example_interfaces' is in: /home/takasei/microros_ws/install/example_interfaces, /opt/ros/humble
'unique_identifier_msgs' is in: /home/takasei/microros_ws/install/unique_identifier_msgs, /opt/ros/humble
'sensor_msgs' is in: /home/takasei/microros_ws/install/sensor_msgs, /opt/ros/humble
'std_srvs' is in: /home/takasei/microros_ws/install/std_srvs, /opt/ros/humble
'sensor_msgs_py' is in: /home/takasei/microros_ws/install/sensor_msgs_py, /opt/ros/humble
'trajectory_msgs' is in: /home/takasei/microros_ws/install/trajectory_msgs, /opt/ros/humble
'statistics_msgs' is in: /home/takasei/microros_ws/install/statistics_msgs, /opt/ros/humble
'diagnostic_msgs' is in: /home/takasei/microros_ws/install/diagnostic_msgs, /opt/ros/humble
'lifecycle_msgs' is in: /home/takasei/microros_ws/install/lifecycle_msgs, /opt/ros/humble
'std_msgs' is in: /home/takasei/microros_ws/install/std_msgs, /opt/ros/humble
'builtin_interfaces' is in: /home/takasei/microros_ws/install/builtin_interfaces, /opt/ros/humble
'visualization_msgs' is in: /home/takasei/microros_ws/install/visualization_msgs, /opt/ros/humble
'rcl_interfaces' is in: /home/takasei/microros_ws/install/rcl_interfaces, /opt/ros/humble
'action_msgs' is in: /home/takasei/microros_ws/install/action_msgs, /opt/ros/humble
If a package in a merged underlay workspace is overridden and it installs headers, then all packages in the overlay must sort their include directories by workspace order. Failure to do so may result in build failures or undefined behavior at run time.
If the overridden package is used by another package in any underlay, then the overriding package in the overlay must be API and ABI compatible or undefined behavior at run time may occur.
If you understand the risks and want to override a package anyways, add the following to the command line:
--allow-overriding action_msgs builtin_interfaces common_interfaces composition_interfaces diagnostic_msgs example_interfaces geometry_msgs lifecycle_msgs nav_msgs rcl_interfaces rosgraph_msgs sensor_msgs sensor_msgs_py statistics_msgs std_msgs std_srvs test_msgs trajectory_msgs unique_identifier_msgs visualization_msgs
This may be promoted to an error in a future release of colcon-override-check.
Starting >>> builtin_interfaces
Starting >>> microcdr
Starting >>> micro_ros_msgs
Starting >>> unique_identifier_msgs
Starting >>> micro_ros_utilities
Starting >>> std_srvs
Starting >>> lifecycle_msgs
Starting >>> micro_ros_setup
Finished <<< microcdr [0.32s]
Starting >>> microxrcedds_client
Starting >>> rosidl_typesupport_microxrcedds_c
Finished <<< micro_ros_setup [0.33s]
Finished <<< micro_ros_utilities [0.37s]
Finished <<< microxrcedds_client [0.31s]
Finished <<< std_srvs [0.86s]
Finished <<< micro_ros_msgs [0.89s]
Finished <<< unique_identifier_msgs [0.90s]
Finished <<< lifecycle_msgs [0.90s]
Finished <<< builtin_interfaces [0.94s]
Starting >>> std_msgs
Starting >>> action_msgs
Starting >>> rcl_interfaces
Starting >>> complex_msgs
Starting >>> micro_ros_agent
Starting >>> rosgraph_msgs
Starting >>> statistics_msgs
Finished <<< rosidl_typesupport_microxrcedds_c [0.76s]
Starting >>> rosidl_typesupport_microxrcedds_cpp
--- stderr: micro_ros_agent
gmake[2]: *** 'micro_ros_agent' に必要なターゲット '/opt/ros/humble/lib/libfastrtps.so.2.6.8' を make するルールがありません.  中止.
gmake[1]: *** [CMakeFiles/Makefile2:137: CMakeFiles/micro_ros_agent.dir/all] エラー 2
gmake: *** [Makefile:146: all] エラー 2
Failed   <<< micro_ros_agent [0.26s, exited with code 2]
Aborted  <<< complex_msgs [0.85s]
Aborted  <<< action_msgs [0.87s]
Aborted  <<< rcl_interfaces [0.86s]
Aborted  <<< rosgraph_msgs [0.87s]
Aborted  <<< std_msgs [0.90s]
Aborted  <<< statistics_msgs [0.88s]
Aborted  <<< rosidl_typesupport_microxrcedds_cpp [0.79s]
Summary: 10 packages finished [2.25s]
1 package failed: micro_ros_agent
7 packages aborted: action_msgs complex_msgs rcl_interfaces rosgraph_msgs rosidl_typesupport_microxrcedds_cpp statistics_msgs std_msgs
1 package had stderr output: micro_ros_agent
22 packages not processed


text:
timesync epoch helpers

@Acuadros95 I tried using the API you added at #117 but its not working for me as well as the eProsima, mainly because i can use 0 timeout and get the epoch time even if timeout reached,
I propose to wrap the eProsima API as follows

@Acuadros95 can you take care of this?
Tests are failing.

Thanks for fixing the tests @Acuadros95

@Acuadros95 LGTM, squash merge if you are ok

Marie Kondo

@amfern I have included a check for session synchronized on the rmw_uros_epoch functions.
I think it looks great, thanks for your suggestions.

yes, this works perfectly with my code, thanks!

repo: micro-ROS/rmw-microxrcedds


text:
Keep Soil-NMDC-Template_Compiled, esp. SheetIdentification tab tidy and authoritative

SheetIdentification
Tests have been started for this task
see also #59

all tabs that appear in Soil-NMDC-Template_Compiled must be listed in the SheetIdentification tab
the tabs should (?) be listed in the order they appear in Soil-NMDC-Template_Compiled
tabs that are expected to be parsed in creation of DH templates must be tagged as input for soil DH template generation in SheetIdentification
tabs that aren't tagged as to be parsed in creation of DH templates, or don't serve some other well-characterized purpose should be deleted

maybe we should designate some tabs as scratch space?

@mslarae13 thanks for the information about tabs that can be deleted. I think I have acted on all of them.

Google Sheets no longer used in pipeline. Closing.

authors: pkalita-lbl turbomam

repo: microbiomedata/DataHarmonizer


text:
what should the slot for EMSL project alternative identifiers be

@turbomam  is adding emsl_project_identifiers to study_identifiers: https://microbiomedata.github.io/nmdc-schema/study_identifiers/
However, EMSL uses study, proposal, and project rather interchangeably.
Addition of this new slot, will include a todo, to add alias.

[ ] What are the aliases?

Montana to check with NEXUS

[ ] Add aliases

duplicates https://github.com/microbiomedata/nmdc-schema/issues/927

repo: microbiomedata/nmdc-schema


text:
Update CODE_OF_CONDUCT.md

Updated C-O-C that combines this with NMDC code of conduct

Waiting for feedback from @emileyfadrosh and @cmungall


text:
Update button styles

Warning button is styled similarly to a secondary button. The white background from secondary-like buttons has been removed.
See https://microbit-global.monday.com/boards/1356069004/views/10076885

Lucy has approved these changes from a design point of view.

repo: microbit-foundation/ml-trainer


text:
Remove namespace object and all zipkin objects

fix kubernetes/kubernetes.github.io#3214

@errordeveloper you've got conflicts

@vlal fixed now :)

some of the other services such as carts, orders, shipping also make reference to ZIPKIN. I'm thinking these should be removed as well.

Closing consolidating under #727

authors: errordeveloper jasonrichardsmith vlal

repo: microservices-demo/microservices-demo


text:
Attachment page api return error

Hello All, I try to query the attachment page api, because I want to know the data structure in D365 business center, and upload attachment, but after I visit the api, I get follow error:
{
"error": {
"code": "Application_CallbackNotAllowed",
"message": "Microsoft Dynamics 365 Business Central Data Services attempted to issue a client callback to create a DotNet object: Microsoft.Dynamics.Nav.Client.Capabilities.CameraProvider (Page 2322 BC O365 Inc. Doc. Attch. List). Client callbacks are not supported on Microsoft Dynamics 365 Business Central Data Services."
}
}
May I know how to solve it ? and How to upload file by attachment api

Hi! This repository no longer handles general questions and is only dedicated to bug reports and feature suggestions for the AL compiler and developer tools.
To get help for your question please use one of the following resources:
Business Central Community
mibuso forum
Dynamics User Group

authors: atoader robertzengcn

repo: microsoft/AL


text:
GetUrl returns not working link in version 24.0

1. Describe the bug
The system function GetUrl start returning different not working links in Version: W1 24.0 (Platform 24.0.18959.0 + Application 24.0.16410.17628)
Same code below is tested on version 23.5 and it works fine, while on version 24.0 it is not working correctly.
2. To Reproduce

Create a new project.
Use this small test page
`

page 50200 "Test GetUrl"
{
    PageType = Card;
    ApplicationArea = All;
    UsageCategory = Administration;

    layout
    {
        area(Content)
        {
            group(General)
            {
                fielD(UrlText; UrlText)
                {
                    ApplicationArea = All;
                    Caption = 'Url Text';
                    ToolTip = 'Url Text';
                    MultiLine = true;
                }
            }
        }
    }

    actions
    {
        area(Processing)
        {
            action(GenerateUrl)
            {
                ApplicationArea = All;
                Caption = 'Generate Url';
                ToolTip = 'Generate Url';

                trigger OnAction()
                begin
                    Customer.FindFirst();

                    UrlText := GetUrl(ClientType::Web, CompanyName, ObjectType::Page, Page::"Customer Card", Customer)
                end;
            }
        }
    }

    var
        Customer: Record Customer;
        UrlText: Text;
}

`
3. Expected behavior
A link should be generated that is able to open the right destination.
Correct link generated deploying the code on version 23.5
https://businesscentral.dynamics.com/[TenantIdMasked]/[EvnNameMasked]/?company=[CompanyNameMasked]&page=21&bookmark=27%3BEgAAAAJ7%2F0QAMAAwADMAMAAwADAAMA%3D%3D
4. Actual behavior
The link first try open Business Central, but immediately after that redirect to https://signup.microsoft.com/get-started/signup page asking to start a Business Central trial.
Tested with both partner account and account in the destination tenant.
Same code deploying the code on version 24.0 returns:
https://businesscentral.dynamics.com:443/?company=[CompanyNameMasked]&page=21&bookmark=27%3BEgAAAAJ7CDAAMQA0ADQANQA1ADQANA%3D%3D&tenant=[TenantNameMasked]
5. Versions:

AL Language: v13.0.971907
Visual Studio Code: 1.88.1
Business Central: Version: W1 24.0 (Platform 24.0.18959.0 + Application 24.0.16410.17628)
List of Visual Studio Code extensions that you have installed:

This is an issue with the runtime, so it is not in the scope of this repository. One reason I'm saying this is that the link does not look malformed, so it is the service that is not responding to it properly.
To get this to the correct team, I'd suggest one of the options below:
Open a support request to CSS through the PartnerSource portal
Open a bug in Collaborate
Contact your Service Account Manager (SAM) in your local subsidiary to understand what is included in your contract as of support incident and PAH (Partner Advisory Hours). Your SAM might also direct you "step by step" how to open a support request or how to get credentials, if this is the first time for you or your company.

Thanks for the answer.
I do understand there should be some rules and guide to use the right support channel so I did think twice before whether I should post it here or Yammer or Partner Portal. However you have to think to be able redirect somehow internally if for some reason the channel is mistaken.
If I have to open a ticket in a few places, contact someone to help me understand where I should register a support ticket...

Any of the options suggested above are valid for the issue you are reporting. They also ensure you will have a go to person to ask for the progress on the resolution of the issue and that multiple people who might have the same issue will benefit from its resolution. The issue you are reporting may also affect live customers, thus it must be prioritized accordingly.
This is a repository for issues on the AL language compiler and developer tools, so we do not track these issues here.

It has already been posted on Yammer: https://www.yammer.com/dynamicsnavdev/threads/2776607520030720

authors: BazookaMusic NKarolak nvtopalov


text:
[Event Request] codeunit 7304 "Whse. Jnl.-Register Batch" - OnCheckWhseItemTrackingLine

We would like to add a new event OnCheckWhseItemTrackingLine in the following procedure:
local procedure CreateTrackingSpecification(WhseJnlLine: Record "Warehouse Journal Line"; var TempHandlingSpecification: Record "Tracking Specification" temporary)
var
    WhseItemTrkgLine: Record "Whse. Item Tracking Line";
    WhseItemTrackingSetup: Record "Item Tracking Setup";
    BinContent: Record "Bin Content";
    Location: Record Location;
begin
    if (WhseJnlLine."Entry Type" = WhseJnlLine."Entry Type"::Movement) or
       (WhseJnlLine.Quantity < 0)
    then
        BinContent.Get(WhseJnlLine."Location Code", WhseJnlLine."From Bin Code", WhseJnlLine."Item No.",
          WhseJnlLine."Variant Code", WhseJnlLine."Unit of Measure Code");

    WhseItemTrkgLine.SetCurrentKey(
      "Source ID", "Source Type", "Source Subtype", "Source Batch Name",
      "Source Prod. Order Line", "Source Ref. No.", "Location Code");
    WhseItemTrkgLine.SetRange("Source Type", DATABASE::"Warehouse Journal Line");
    WhseItemTrkgLine.SetRange("Source ID", WhseJnlLine."Journal Batch Name");
    WhseItemTrkgLine.SetRange("Source Batch Name", WhseJnlLine."Journal Template Name");
    WhseItemTrkgLine.SetRange("Source Ref. No.", WhseJnlLine."Line No.");
    WhseItemTrkgLine.SetRange("Location Code", WhseJnlLine."Location Code");
    WhseItemTrkgLine.CalcSums("Qty. to Handle (Base)");

    if WhseItemTrkgLine."Qty. to Handle (Base)" <> Abs(WhseJnlLine."Qty. (Absolute, Base)") then
        Error(Text005);

    if WhseItemTrkgLine.Find('-') then
        repeat
            OnCheckWhseItemTrackingLine(WhseJnlLine, WhseItemTrkgLine); //A200F0000.Event
            ItemTrackingMgt.GetWhseItemTrkgSetup(WhseJnlLine."Item No.", WhseItemTrackingSetup);
            WhseItemTrkgLine.CheckTrackingIfRequired(WhseItemTrackingSetup);
        until WhseItemTrkgLine.Next() = 0;

    if (WhseJnlLine."Entry Type" = WhseJnlLine."Entry Type"::Movement) or
       (WhseJnlLine.Quantity < 0)
    then
        if WhseItemTrkgLine.Find('-') then
            repeat
                BinContent.SetTrackingFilterFromWhseItemTrackingLine(WhseItemTrkgLine);
                BinContent.CalcFields("Quantity (Base)");
                if WhseItemTrkgLine."Quantity (Base)" > BinContent."Quantity (Base)" then
                    Error(Text006);
            until WhseItemTrkgLine.Next() = 0;

    if WhseItemTrkgLine.Find('-') then
        repeat
            OnBeforeInsertTempHandlingSpecs(WhseJnlLine, WhseItemTrkgLine);

            TempHandlingSpecification.Init();
            TempHandlingSpecification.TransferFields(WhseItemTrkgLine);
            TempHandlingSpecification."Quantity actual Handled (Base)" := WhseItemTrkgLine."Qty. to Handle (Base)";
            OnBeforeTempHandlingSpecificationInsert(TempHandlingSpecification, WhseItemTrkgLine);
            TempHandlingSpecification.Insert();

            with WhseJnlLine do begin
                Location.Get("Location Code");
                if ("From Bin Code" <> '') and
                   ("From Bin Code" <> Location."Adjustment Bin Code") and
                   Location."Directed Put-away and Pick"
                then begin
                    BinContent.Get("Location Code", "From Bin Code", "Item No.", "Variant Code", "Unit of Measure Code");
                    BinContent.SetTrackingFilterFromTrackingSpecification(TempHandlingSpecification);
                    BinContent.CheckDecreaseBinContent("Qty. (Absolute)", "Qty. (Absolute, Base)", "Qty. (Absolute, Base)");
                end;
            end;
        until WhseItemTrkgLine.Next() = 0;
end;

Event Signature:
[IntegrationEvent(false, false)]
local procedure OnCheckWhseItemTrackingLine(WarehouseJournalLine: Record "Warehouse Journal Line"; WhseItemTrackingLine: Record "Whse. Item Tracking Line")
begin
    //A200F0000.Event
end;

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.

repo: microsoft/ALAppExtensions


text:
[Event Parameter change] codeunit 80 "Sales-Post" - OnBeforeSalesShptHeaderInsert

    //OnBeforeSalesShptHeaderInsert(SalesShptHeader, SalesHeader, SuppressCommit, IsHandled); A109F0000.Event.o
    OnBeforeSalesShptHeaderInsert(SalesShptHeader, SalesHeader, SuppressCommit, TempWhseRcptHeader, WhseReceive, TempWhseShptHeader, WhseShip, IsHandled); //A109F0000.Event.n

Event Signature:
[IntegrationEvent(false, false)]
local procedure OnBeforeSalesShptHeaderInsert(var SalesShptHeader: Record "Sales Shipment Header"; SalesHeader: Record "Sales Header"; CommitIsSuppressed: Boolean; WarehouseReceiptHeader: Record "Warehouse Receipt Header"; WhseReceive: Boolean; WarehouseShipmentHeader: Record "Warehouse Shipment Header"; WhseShip: Boolean; var IsHandled: Boolean)
begin
    //A109F0000.Event Parameters
end;

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.