text:
Enhance style/filename to support RubyGems convention

I'm just putting this up for discussion (and since I might be implementing this anyway).
Style would be based on this: http://guides.rubygems.org/name-your-gem
Sadly, RuboCop itself doesn't follow the convention (should be 'rubo_cop', not 'rubocop').
Personally, it took me a while to learn to write RuboCop instead of Rubocop (because I assume the name based on the file).
Historically, Rails made the transition in the past (e.g. now it's require 'active_record').
The value is mostly when mapping a module/class name to a file and vice verse.
Not following the convention can create ambiguity (although rare), e.g. without the underscore in filenames, both NoWhere and NowHere would resolve to 'nowhere'. (Instead of 'no_where' and 'now_here' respectively).
And it creates a mess when doing the reverse (e.g. what's the module name in the file 'nowhere.rb' ? - now we have to search for all matching constants).
Either way, there's probably little reason to not follow the RubyGems convention in new projects.

To make this less boring, here are some examples of ambiguity: childrenslaughter, everyoneshavingbabies, needsatan, nowthatcherisdead, kidsexchange.
Sure, not having to put the underscore is "convenient", but there's a price tag on it.

A reasonable exception would be if the word has a single letter, e.g. 'RSpec', (because 'r_spec' would really be pushing it).

I'm pretty sure the cop follows the RubyGems conventions as it was derived from it. You can specify certain exceptions like RSpec and RuboCop in the cop's config. I understand RuboCop violates the convention, but I don't care that much about this - it's hard for me to write rubo_cop and changing the filenames will break too much related code, anyways.
I'm not sure what exactly would you like to be changed in the cop.

It's about matching the module name to the file name, so it's not about checking just the file name, but taking the class name into account.
Maybe it would be best to just start with extreme cases, e.g. with the RubyGems example:
require 'net/http/digest_auth' # -> Net::HTTP::DigestAuth

.. having a file 'digest-auth' would be an offense. So would 'http_digest_auth' (because the class is not 'HttpDigestAuth'.
If a file name has many parts to it (using '-' or '_') - the filename shouldn't contain a definition of a class that doesn't match - because requiring that file should define the expected, namespaced class/module name.
I'm pretty sure being strict here (like with RuboCop) would break too much code - so I'm wondering if "obviously misleading" examples can't be covered at least (where '-' and '_' are provided, but incorrectly used).
So I think this should be a new cop at least, probably more related to this one: https://github.com/bbatsov/rubocop/blob/master/lib/rubocop/cop/style/class_and_module_camel_case.rb
The problem is it would have to ideally take the whole path, and not just the filename. So 'net/http/foo' should be expected to define a class or module Net::Http::Foo (which is usually the case).
Sticking with the convention is most useful with auto loading "plugins" where a module can be loaded/initialized based on the file name or module name. Without a convention, the filename and module would have to provided - just like e.g. for Kernel.autoload calls.
And in general, if I need to use 'Foo::BarBaz', I expect `require "foo/bar_baz" to work - or I suddenly have to know both the class name and namespace ... and the filename.
Do you think this is worth tackling with PR? Or is it unlikely to be accepted?

Maintainers: do you want this? It seems to be a fairly common request (there are other similar issues in the issue tracker). Perhaps disabled by default?

Yeah, I'm fine with this.

authors: alexdowad bbatsov e2

repo: bbatsov/rubocop


text:
Style/GuardClause triggered for complex elsif conditions

The most recent version of RuboCop as well as current git master trigger this GuardClause errors for my if/elsif/else branches. Example file:
def process_file file
  if file.video?
    puts file.video_info
  elsif file.image?
    puts file.image_info
  else
    raise "unsupported file type"
  end

  puts file.general_info
end

Output:
asd.rb:4:3: C: Use a guard clause instead of wrapping the code inside a conditional expression.
  elsif file.image?
  ^^^^^

I think it doesn't make sense. The guard condition would have to be very complex, the more complex the more elsif clauses there are. Below is – in my opinion – worse code that Rubocop likes:
def process_file file
  raise "unsupported file type" unless file.video? || file.image?

  if file.video?
    puts file.video_info
  elsif file.image?
    puts file.image_info
  end

  puts file.general_info
end

If this looks OK to you then consider the same example, but with 5 elsif checks.

Using case will pass the cop:
def process_file file
  case
  when file.video?
    puts file.video_info
  when file.image?
    puts file.image_info
  else
    raise "unsupported file type"
  end

  puts file.general_info
end

Using case will pass the cop:

That's true, but is the behavior of this cop desirable as re: elsif?

No, I think @amw 's original example is preferable when using elsif

This cop already has a clause which catches elsifs, but it does it wrongly.

source: gharchive/issue

authors: alexdowad amw madwort

license: MIT

license_type: permissive

license_source: github-api


text:
Lint/AmbiguousBlockAssociation with Rspec syntax

I'm quite lost with this example:
expect do
  make_request
end.to enqueue_job(DeliverEventWebhookJob)
  .with { |event_name, _claim_id| expect(event_name).to eq("claim_renewed") }

The offence is:
W: Lint/AmbiguousBlockAssociation: Parenthesize the param with to make sure that the block will be associated with the to method call.
    expect do ...
    ^^^^^^^^^

I tried few other ways, but either Rubocop is not happy or it's not a valid Ruby syntax.
$ rubocop -V
0.48.0 (using Parser 2.4.0.0, running on ruby 2.4.1 x86_64-linux)

I would probably recommend disabling this cop for specs, since it's a deliberate idiom in RSpec. 🙂
Lint/AmbiguousBlockAssociation:
  Exclude:
    - "spec/**/*"

authors: Drenmi morgoth


text:
[Fix #4745] Make Style/SafeNavigation ignore negated continuations

This cop would suggest using the safe navigation operator when the continuation was negated. However, this results in different semantics.
Example:
foo && !foo.bar?

will be falsey if foo is nil. However, the suggested change:
!foo&.bar?

will be truthy (!nil).
This change fixes that by having the cop ignore negated continuations.

Before submitting the PR make sure the following are checked:

[X] Wrote good commit messages.
[X] Commit message starts with [Fix #issue-number] (if the related issue exists).
[X] Used the same coding conventions as the rest of the project.
[X] Feature branch is up-to-date with master (if not - rebase it).
[X] Squashed related commits together.
[X] Added tests.
[X] Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
[X] All tests(rake spec) are passing.
[X] The new code doesn't generate RuboCop offenses that are checked by rake internal_investigation.
[X] The PR relates to only one subject with a clear title
and description in grammatically correct, complete sentences.
[ ] Updated cop documentation with rake generate_cops_documentation (required only when you've added a new cop or changed the configuration/documentation of an existing cop).

Thanks for the fix, I've run into this issue with a similar negated continuation 👍

source: gharchive/pull-request

authors: Drenmi tagliala


text:
CGPROD 3000 NinePatch

Adds NinePatch plugin
Adds ninepatch config support to scrollable list
Update core-js polyfills to latest

There are quite a lot of TODOs still in here, but otherwise looks good! 🐡

Yeah they are just things I've noticed we need to address before release. Saldy haven't been on top of the shop work as much as I should have been :)

repo: bbc/genie


text:
New translator support

Is it possible to add this translator by default (the AI translation model that is being trained) ?
https://www.reddit.com/r/visualnovels/comments/qnsgd2/from_sugoi_translator_developer_today_i_will_send/
Works offline, it's free and unlimited plus the translation quality is great if not the best japanese>english out there.
Kinda slow at first but there's a way to make it use the GPU which makes it way faster.

This is certainly very interesting. Now, without knowing too much about this at all, is what you're asking for, the thing that this plugin provides?
https://github.com/Vin-meido/XUnity-AutoTranslator-SugoiOfflineTranslatorEndpoint

Hum I didn't know about that plugin...
But yeh, what I want is support for Sugoi Translator and their offline AI trained model just like XUnity supports google translate.

I has seen about the sugoi translator and trying it out, i got everything working and on the autotranslator status say running but it not translator.

It only supports JP->EN

As you may already know (since I saw you on the discord) this offline translator can outperform DeepL primarily because it has been trained in JA-to-EN Visual Novel data. So unless the author decides to also train it in other language pairs it will not support those.
Anyway it is certainly a massively impressive translator. Would like to have native support for it in the future.

As you may already know (since I saw you on the discord) this offline translator can outperform DeepL primarily because it has been trained in JA-to-EN Visual Novel data. So unless the author decides to also train it in other language pairs it will not support those.
Anyway it is certainly a massively impressive translator. Would like to have native support for it in the future.

Can also be used to translate EN to JP but not other languages and afaik there is no plans for addition languages since it would require an entire new set of data to train which can be an hassle to get.

Can also be used to translate EN to JP but not other languages and afaik there is no plans for addition languages since it would require an entire new set of data to train which can be an hassle to get.

authors: Mochongli Terell2018 gravydevsupreme mspykerez


text:
🐛 [BUG]: Can't show/hide handle during connection process.

Is there an existing issue for this?

[X] I have searched the existing issues and this is a new bug.

Current Behavior
When I start a connection, even if I hide (display:none) handle div visually, the functionality of the handle remains active on the screen and I observe a visual "magnetic connection" effect. Vue-flow can only disable when the connection is completed or canceled.
Expected Behavior
When the handle is hidden its functionality must disappear immediately even during the connection process. Except maybe for the source handle involved in the current connection.
Steps To Reproduce

create two nodes: one node with a source handle and another node with a target handle
Create a code that hides (display:none) the target handle div after the connection is started on the source handle. For example:

 watch(
      connectionStartHandle,
      (pre, post) => {
            targetHandleReactiveStyle.display='none'
       }
)

Observe that the "magnetic" functionality is still working on the location where the handle is not displayed anymore.
Cancel the connection and start it one more time. Now the "magnetic" function finally disappears.

Relevant log output
No response
Anything else?
No response

You really shouldn't use css to "hide" the handle if you want to avoid connecting to it. CSS is not considered when looking for the closest handle available, it will just look for an element within the radius.
Instead use a v-if to actually remove the handle from the DOM, which will prevent "magic connection" as you call it ^^

got it. Thanks! Closing this bug then.

hm. looks like 'v-if' doesn't fix the issue.  so I'm reopening.

Can you provide a sandbox reproduction for this issue? :)

Here's a basic template.
It would make it easier to debug if I had a sandbox reproducing this issue 😅

https://user-images.githubusercontent.com/78412429/222098810-4d7d4f91-4ccb-4c5d-b1ca-5dbf3adf603d.mov
v-if seems to solve the issue for me.

const handleVisible = ref(true)

watch(connectionStartHandle, () => {
  handleVisible.value = !connectionStartHandle.value
})

<Handle v-if="handleVisible" type="target" :position="Position.Left" :style="targetHandleStyle" />

you are right. I have the same behavior in my sandbox as you have in yours. Maybe something is different in my local env. Need to investigate it.  For now, I'm closing the bug.

I've finally reproduced the issue. It is not exactly what I initially described, but very close it in.
Here is the sandbox:  https://codesandbox.io/p/sandbox/vue-flow-bug-reporduce-jpekby
When you start the connection from the bottom handle, you will not be able to connect to the top handle right after they appear. Buy on the second try you can.

Mh... you shouldn't pop-in handles when trying to create a connection as the handles are looked up on pointerDown and not pointerMove, meaning, Vue Flow has no knowledge of this handle potentially existing when the connection is started (pointerDown = connectStart).
I might change this behavior at a later point or offer another event like beforeConnectStart, which could be used to pop the handle in before a connection is even started.
Though for now you can achieve the same effect using opacity: 0 and opacity: 100 instead.

That was my first idea actually, but because there I have two overlapping source and target handles and there is also a bug with the overlapping handles, opacity doesn't work for me.
Here is the bug reproduction: https://codesandbox.io/p/sandbox/vue-flow-bug-reporduce-forked-8ccfn5
You can't connect to the target even if it is located on top of the source handle by z-index.

Yeah, because z-index is irrelevant for checking the closest handles. If they're on top of each other, Vue Flow can't determine which is the correct handle and will use one, and in this case possibly the wrong one.
That's not really a good solution either to place two handles on top of one another.
What even is the use-case for this? ^^
Why not just use ConnectionMode.Loose and use a single handle typed as source and that's it?

That's because the target handle is custom elements that contain custom content, and the source is just a regular handler. I centered both of them in my node and wanted to show the target handler on top of the whole node content in order to reflect that this node is ready to accept the connection, and when it is connected, I wanted to hide it behind the node again.
It is just my attempt to implement floating edges with both handles located in the center of the node.
I will go with the ConnectionMode.Loose then.  It just looked to me that separating the handles by type is a bit easier in the implementation.

Mh... I'm not sure I properly understand, though wouldn't a single handle where you hide the custom content depending on connection status work?
Something like this?
<Handle>

...

</Handle>

yeah, this will work. I've only been working with vue/TypeScript/vueflow for about 3 weeks, so some of my design solutions may seem weird :)

I see, no worries 😄
I'll consider using z-index as well when looking up handles for connections as well, maybe this case has some usages for others as well.

@bcakmakoglu I've found some workaround using one handle. btw, it would be nice to be able to change the handle during connection with connectionStartHandle.value.handleId = newId. Now it works only visually and I can't get the new handle in listeners when the connection is finished.

@heaven-born
Is there anything you would need from the library to get your solution working? Otherwise this issue will be closed 😄

authors: bcakmakoglu heaven-born

repo: bcakmakoglu/vue-flow


text:
Update README.md

@bcanseco Hi,
Brief overview: I don't think github allows to secret names start with GITHUB_ anymore, so I replaced the secret name with GH_TOKEN

Alright, I got a little confused.
Thanks for letting me know ;)


text:
Somatic tumor only variant calling pipeline with UMIs step by step

Hi @naumenko-sa
In the "Somatic tumor only variant calling pipeline with UMIs step by step" found in this link (https://bcbio-nextgen.readthedocs.io/en/latest/contents/internals.html) the first command does some kind of trimming to reads.
trimming 2p from reads: trim_ends: [2,0,2,0], indexing:

Is this mandatory? Why do we have to trim 2bp from the reads? (I have already trimmed adapter sequences)

This depends on the UMI design. Most manufacturers introduce a variable number of bases between UMI and insert or they have UMI of different length. To deal with that you extract a fixed number of bases for the UMI and trim the rest.

So, it is better to not do any adapter trimming, and then follow what bcbio does with 2p trimming?

Without knowing your particular UMI setup, I would generally say that you should (in this order)

De-multiplex and trim sequencing adapters from the end of reads,
Extract UMIs,
Trim remaining bases from the start of reads, if this is necessary.

If you are using off-the-shelf UMI, the manufacturer should provide suitable instructions (IDT, Agilent, Twist do).

If you have the time, you could process one sample and perform alignment (no consensus or variant calling). Review the BAM file in IGV. If you see 2 soft-clipped bases at the start of many reads, you should trim them. Otherwise it is not necessary.

authors: gabeng kokyriakidis

repo: bcbio/bcbio-nextgen


text:
Ease testing of non-published chartlets.js versions

Currently we have to publish chartlets.js versions to npm before testing any enhancement and fixes in the host application. This is by far too time consuming.
The desired approach would be declare "chartlets.js": "file:../chartlets/chartlets.js" in the package.json (sym-linking it) of the host application. However, that doesn't work currently doesn't work because of the way chartlets.js's package.json specifies its dependencies since it includes the demo application. We may need to move the demo code into a separate repo.

Current runtime errors in dev console when running the app using "chartlets.js": "file:../chartlets/chartlets.js" in the package.json:

Will split repos, this will also simplify individual repo setup and will make things much clearer for users.

Closed by #66

repo: bcdev/chartlets


text:
org.bouncycastle.util.IPAddress#isValidIPv4WithNetmask

org.bouncycastle.util.IPAddress#isValidIPv4WithNetmask
This method changes the verification result of ::/0

I'm sorry, but I don't understand this one. The method returns false, as it should.

No further detail available.

authors: LetheBarry dghgit

repo: bcgit/bc-java


text:
#2979 - Email notification - PD/PPD Student reminder email 8 weeks before end date  Part 2

AC

[X] Select all student applications where

Offerings end date within 8 weeks.
Applications with current disbursement pending.
Application not archived.
Remove assessments where a notification was already sent.
With the PD/PPD mismatch using the same logic from validate-disbursement-base.ts.

[X] Save the assessment ID as metadata and ensure the email will be sent once.

*note:  E2E test will follow in upcoming Pull request.
Migrations Revert Demo:

Sample Email

Underlying SQL for TypeOrm
SELECT "application"."application_number" AS "application_application_number",
       "application"."id"                 AS "application_id",
       "student_assessments"."id"         AS "student_assessments_id",
       "students"."disability_status"     AS "students_disability_status",
       "students"."id"                    AS "students_id",
       "users"."id"                       AS "users_id",
       "users"."email"                    AS "users_email",
       "users"."first_name"               AS "users_first_name",
       "users"."last_name"                AS "users_last_name"
FROM "sims"."applications" "application"
         INNER JOIN "sims"."student_assessments" "student_assessments"
                    ON "student_assessments"."id" = "application"."current_assessment_id"
         INNER JOIN "sims"."students" "students" ON "students"."id" = "application"."student_id"
         INNER JOIN "sims"."users" "users" ON "users"."id" = "students"."user_id"
         INNER JOIN "sims"."education_programs_offerings" "epo" ON "epo"."id" = "student_assessments"."offering_id"
         INNER JOIN "sims"."disbursement_schedules" "ds" ON "ds"."student_assessment_id" = "student_assessments"."id"
WHERE "epo"."study_end_date" >= '2024-11-28T21:37:26.764Z'
  AND "students"."disability_status" NOT IN ('PD', 'PPD')
  AND json_extract_path_text(student_assessments.workflow_data::json, 'calculatedData', 'pdppdStatus') = 'true'
  AND "application"."is_archived" = false
  AND "ds"."disbursement_schedule_status" = 'Pending'
  AND NOT EXISTS ((SELECT 1
                   FROM "sims"."notifications" "n"
                   WHERE "n"."notification_message_id" = 30
                     AND json_extract_path_text(n.metadata::json, 'assessmentId') =
                         CAST("student_assessments"."id" AS TEXT)))
  AND NOT EXISTS ((SELECT 1
                   FROM "sims"."disbursement_schedules" "ds2"
                   WHERE "ds2"."student_assessment_id" = "student_assessments"."id"
                     AND "ds2"."disbursement_date" < "ds"."disbursement_date"))

Please see below an E2E test that I ended up creating to test the query changes. It can be used as a starting point for the E2E scenarios.
import { createMock } from "@golevelup/ts-jest";
import { INestApplication } from "@nestjs/common";
import { QueueNames } from "@sims/utilities";
import {
  createTestingAppModule,
  describeProcessorRootTest,
} from "../../../../../test/helpers";
import {
  E2EDataSources,
  createE2EDataSources,
  saveFakeApplicationDisbursements,
  saveFakeStudent,
} from "@sims/test-utils";
import { Job } from "bull";
import {
  ApplicationStatus,
  DisabilityStatus,
  DisbursementScheduleStatus,
  NotificationMessageType,
  WorkflowData,
} from "@sims/sims-db";
import { IsNull, Not } from "typeorm";
import { StudentApplicationNotificationsScheduler } from "../../student-application-notifications/student-application-notifications.scheduler";

describe(
  describeProcessorRootTest(QueueNames.StudentApplicationNotifications),
  () => {
    let app: INestApplication;
    let processor: StudentApplicationNotificationsScheduler;
    let db: E2EDataSources;

    beforeAll(async () => {
      // Set the SFAS folder to the files mocks folders.
      const { nestApplication, dataSource } = await createTestingAppModule();
      app = nestApplication;
      db = createE2EDataSources(dataSource);
      // Processor under test.
      processor = app.get(StudentApplicationNotificationsScheduler);
    });

    beforeEach(async () => {
      // Cancel all applications to ensure tha existing data will not affect these tests.
      await db.application.update(
        { applicationStatus: Not(ApplicationStatus.Cancelled) },
        { applicationStatus: ApplicationStatus.Cancelled },
      );
    });

    it(
      "Should generate a notification for PD/PPD student mismatch close to the offering end date " +
        "when the application is completed and at least one disbursement is pending and there is a PD/PPD mismatch.",
      async () => {
        // Arrange
        // Create a student with a non-approved disability.
        const student = await saveFakeStudent(db.dataSource, undefined, {
          initialValue: { disabilityStatus: DisabilityStatus.Requested },
        });
        // Create an application with the disability as true.
        const application = await saveFakeApplicationDisbursements(
          db.dataSource,
          { student },
          {
            applicationStatus: ApplicationStatus.Completed,
            currentAssessmentInitialValues: {
              workflowData: {
                calculatedData: {
                  pdppdStatus: true,
                },
              } as WorkflowData,
            },
            createSecondDisbursement: true,
            firstDisbursementInitialValues: {
              disbursementScheduleStatus: DisbursementScheduleStatus.Sent,
            },
            secondDisbursementInitialValues: {
              disbursementScheduleStatus: DisbursementScheduleStatus.Pending,
            },
          },
        );
        // Queued job.
        const job = createMock<Job<void>>();

        // Act
        await processor.studentApplicationNotifications(job);

        // Assert
        const notification = await db.notification.findOne({
          select: {
            id: true,
            messagePayload: true,
          },
          relations: { notificationMessage: true },
          where: {
            notificationMessage: {
              id: NotificationMessageType.StudentPDPPDApplicationNotification,
            },
            dateSent: IsNull(),
            user: { id: student.user.id },
          },
        });
        expect(notification).toBeDefined();
        expect(notification.messagePayload).toStrictEqual({
          email_address: application.student.user.email,
          template_id: "7faea39f-cf8e-41ee-af02-c4790cac5b26",
          personalisation: {
            lastName: application.student.user.lastName,
            givenNames: application.student.user.firstName,
            applicationNumber: application.applicationNumber,
          },
        });
      },
    );
  },
);

authors: andrewsignori-aot bidyashish

repo: bcgov/SIMS


text:
21310 Implement Authorization Date min date validation

Issue #: bcgov/entity#21310
Description of changes:

app version = 5.10.20
added Authorization Date min date validation

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the bcrs-entities-create-ui license (Apache 2.0).

/gcbrun

Temporary Url for review: https://business-create-dev--pr-701-1jrgf7gx.web.app

/gcbrun

Temporary Url for review: https://business-create-dev--pr-701-1jrgf7gx.web.app

authors: bcregistry-sre severinbeauvais

repo: bcgov/business-create-ui


text:
Determine government-wide demand for AirTable vs alternate online forms solutions

Describe the issue
We're using AirTable for our online onboarding forms - it's working well, but our ED has noted that there are 7 or more other forms solutions in use in government, and reluctant to have our team contributing to SaaS sprawl
Which Sprint Goal is this issue related to?

Note: 'Milestone' is a ZenHub term that we use synonymously with 'Sprint'.

The 'Milestone' description (created in ZenHub) should clearly list Sprint Goals. This section should indicate which 'goal' this issue is related to.
Additional context
Add any other context, attachments or screenshots
Definition of done

develop short report listing the most common forms solutions in use around government
assess pros and cons of each with particular attention to our requirements
make a recommendation on next steps with AirTable or alternative
review with PO, and with Gen

Full disclosure: I've not surveyed very broadly (CITZ, Justice, NRS) but haven't identified additional demand for AirTable. Did find that Google Forms has already had SoAR and PIA for GRS (CIRMO), took a quick look at it and found that it has several advantages over AirTable for our purposes. Now following up on SoAR, PIA, legal review (thinking to do this after we get agreement with Google on terms to add to the GCFA for Cloud Brokering Service - we'll have their attention and this might help in getting terms agreed for Google Forms).

repo: bcgov/cloud-pathfinder


text:
SPIKE: Draft CI/CD patterns to reuse code

Describe the issue
Instead of seeing an ecosystem or CI/CD sprawl, we want to group patterns so that teams can work off a common set of CI/CD code to avoid sharp edges for each team.  Also to consider PR based workflows -> Master branch.
Which Sprint Priority is this issue related to?
The 'Milestone' should clearly list Sprint Priorities - which one is this issue related to?
Additional context

For PR based workflows we would need to either bake off entire ECS clusters or better inject differently named pods inside existing.
URL firewall step is a manual process at the moment (which is perimeter network, which we don't want to allow team automation to change)

Definition of done

Roll up CI/CD into an NPM module or Action Step including patterns
Create plan to move CI/CD forward
Determine the need for / balance around tightly wrapped CI/CD functionality (make the molecule, provide all the atoms)
Balance early optimization vs pathfinding
Timebox to a solid day's effort

Follow-up with CP Tech team needed.

authors: ActionAnalytics sid-gov


text:
Reduce repeated boilerplate in terragrunt "layer" files in *-live repos.

Describe the issue
Currently we have several snippets of repeted "boilerplate" code in our terragrunt files in our *-live repos.  The main example of this is the code that we use to configure Terraform Cloud backends, although there could be other occurrences.  We should refactor to reduce this error-prone and tedious aspect of the "stack" to simplify development and maintainability.
Which Sprint Priority is this issue related to?

Note: 'Milestone' is a ZenHub term that we use synonymously with 'Sprint'.

The 'Milestone' overview/description (created in ZenHub) should clearly list Sprint Priorities/Goals. This section should indicate which of the priorities/goals this issue is related to.
Additional context

terragrunt "inheritiance" provides for definition of common content in one file and inclusion/merge into another via "include"
moving the repeated after_hook into an included file would eliminate one instance of boilerplate
other main instance of boilerplate is in "generate" for backend.  currently, this relies on locals which are not accessible when inherited.

Definition of done

Contents of *-live repos refactored with repeated boilerplate eliminated/reduced.

closing following attempt at this has surfaced that only a single "include" is allowed in terragrunt meaning we will have to live with repeated boilerplate for now.


text:
CLUS Explorer Tool - Staff Requests 2020

Add indicators for 'old' and 'mature' forest

Change 'dashboard' configuration to include maps and indicators together

DONE. Added 'old' and 'mature' forest as indicators to survival table output form survivalCLUS. Uses same approach as prop_age, and adds prop_mature (80 to 120 years old) and prop_old (>120 years old). Added two ggplots to the CLUS Explorer Tool that call these fields from the 'survival' table created in survivalCLUS.  I think it is fine to keep this as indicator part of the caribou survival module, but it may be more intuitive to create an 'age' or 'caribou_habitat' module for trackign these kind of indicators.

repo: bcgov/clus


text:
name change in Maternity/parental leave on Careers & MyHR

Looks like this one has been done - https://www2.gov.bc.ca/gov/content/careers-myhr/all-employees/leave-time-off/maternity-parental-pre-placement-adoption/maternity

repo: bcgov/digital-journeys


text:
FOI Ministry Request Queue - Corrections

As a BC Corrections User
I want requests for the corrections branch to only be visible to me or my group
so that I can ensure the highest level of privacy for my applicants

Assumptions & Scope
This is a requirement received from the justice sector for onboarding them as a Ministry. Corrections request fall under the Ministry of Public Safety and Solicitor General. A change is being pushed in AXIS to create a corrections action office code (COR)
Assumption: a new keycloak group specifically for PSS-Corrections requests will need to be created
There will be no practical difference in functionality for this queue, it will operate the same as with other Ministry level queues
What is IN scope?
Requests that will appear in the queue for BC Corrections staff
What is NOT in scope?
Acceptance Criteria
Scenario 1: Correction Requests - Call for Records

GIVEN a request has the Corrections Action Office code "COR"
WHEN the state is changed to Call for Records
THEN the request will be assigned to the PSS - Corrections Team Queue
AND the request will NOT be visible or searchable to the main PSS Team

Scenario 2: Correction Requests – Action Office Changed

GIVEN a COR request and is in the call for records state or later
WHEN the action office is changed to PSS
AND the IAO user syncs the request
THEN the request will disappear from the corrections queue
AND the request will appear as an unassigned request in the main PSS Team queue

Scenario 3: PSS Requests - Change to Corrections

GIVEN a request has the action office PSS assigned to it
WHEN the action office is changed to COR
AND the IAO user syncs the request
THEN the request will disappear from the main PSS Team queue
AND the request will appear as an unassigned request in the corrections queue

Validation Rules? (If yes, list here)
Design
@xxx - please link the Design here
Definition of Ready

[ ] Is there a well articulated User Story?
[ ] Is there Acceptance Criteria that covers all scenarios (happy/sad paths)?
[ ] If there is a user interface, is there a design?
[ ] Does the user story need user research/validation?
[ ] Does this User Story needs stakeholder approval?
[ ] Design / Solution accepted by Product Owner
[ ] Is this user story small enough to be completed in a Sprint? Should it be split?
[ ] Are the dependencies known/ understood? (technical, business, regulatory/policy)
[ ] Has the story been estimated?

Definition of Done

[ ] Passes developer unit tests
[ ] Passes peer code review
[ ] If there's a user interface, passes UX assurance
[ ] Passes QA of Acceptance Criteria with verification in Dev and Test
[ ] Confirm Test cases built and succeeding
[ ] No regression test failures
[ ] Test coverage acceptable by Product Owner
[ ] Ticket ready to be merged to master or story branch
[ ] Developer to list Config changes/ Update documents and designs
[ ] Can be demoed in Sprint Review
[ ] Tagged as part of a Release
[ ] Feature flagged if required
[ ] Change Management activities done?

First stab at how we will handle the PSS Corrections Queue requirement - this story will have a dependency on 2969

notes for dev

no need to filter subject code by ministry, there are edge cases where corrections subject code is used by other ministries

Note: will need to re-estimate this one, change in course for how corrections files will be identified going forward (still TBC)

@abin-aot @richard-aot  - Please see revised AC for this story - I have changed the acceptance criteria to be more in line with what we expect for standard queue behaviour. Notable element for this story is that there will now be a COR action office code. Andrew has confirmed the COR action office code has been added to iTest - so this can now be developed. I am removing the dependency with the AXIS Subject code story

cc: @lmullane @liseandtea @KyEggleston

Note from sprint planning - This may be covered in existing ticket for changes to codes for Justice Sector onboarding. If test is successful, this will go to 0 and can be closed.

authors: m-prodan nkan-aot

repo: bcgov/foi-flow


text:
Add initial devcontainer

Description
This PR includes the following proposed change(s):

Contains an initial devcontainer configuration for nodejs and typescript.  Angular CLI is installed as well.

Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Refactoring / Documentation
[ ] Version change

if your change is a breaking change, please add breaking change label to this PR
How Has This Been Tested?
Tested by opening the citizen-portal folder using the Remote Container extension in vscode.
Does the change impact or break the Docker build?

[ ] Yes
[x] No

If Yes: Has Docker been updated accordingly?

[ ] Yes
[ ] No

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[ ] I have made corresponding changes to the documentation
[x] New and existing unit tests pass locally with my changes

We could move this up one folder if we thing the development tooling for all the portals would be the same.

We could move this up one folder if we thing the development tooling for all the portals would be the same.

After consideration, I have moved the devcontainer configuration up one line so that the same container can be used for both citizen and staff portals.

After consideration, I have moved the devcontainer configuration up one line so that the same container can be used for both citizen and staff portals.

After consideration, I have moved the devcontainer configuration up one line so that the same container can be used for both citizen and staff portals.

After consideration, I have moved the devcontainer configuration up one line so that the same container can be used for both citizen and staff portals.

I am playing around with this.  For now going to close this PR. I want to get the sense of how this dev container can be used vs when using docker compose etc.

I am playing around with this.  For now going to close this PR. I want to get the sense of how this dev container can be used vs when using docker compose etc.

repo: bcgov/jag-traffic-courts-virtualization


text:
fix(deps): update dependency org.testcontainers:testcontainers-bom to v1.18.3

This PR contains the following updates:

Package
Type
Update
Change

org.testcontainers:testcontainers-bom (source)
import
patch
1.18.1 -> 1.18.3

Release Notes

testcontainers/testcontainers-java
v1.18.3
Compare Source
Testcontainers for Java 1.18.2 introduced new strategies to detect the docker.sock. There was an issue reported, see #7082. It's is highly recommended to use version 1.18.3.
What's Changed

Fixes for new strategies (#7085) @eddumelendez

🧹 Housekeeping

Demote "testcontainers.properties not found" message to debug log level (#7035) @perlun

v1.18.2
Compare Source
Highlights ✨

Support Docker Desktop paths for Linux and Mac (#7058) @eddumelendez
Update testcontainers/ryuk version to 0.5.1 (#7054) @eddumelendez

🐛 Bug Fixes

[redpanda] Fix command by setting memory to 1G (#7045) @eddumelendez
[cratedb] Enable single node by default (#7041) @matriv

🚀 Features & Enhancements

Add TestcontainersHostPropertyClientStrategy (#7053) @eddumelendez
DockerComposeContainer: add 'removeVolumes' parameter (#7009) @DanWiseProgramming

📖 Documentation

Fix typo in gitlab_ci instruction docs (#7059) @dakshin-k
Add Apache Kyuubi to who is using testcontainers (#7042) @bowenliang123

🧹 Housekeeping

Add LocalStackContainer#getEndpoint() (#7037) @eddumelendez

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

closing this as it was resolved by #162

authors: bcgov-renovate paulushcgcj

repo: bcgov/nr-forest-client-api


text:
feat: scheduled job to report OpenShift users

Create a scheduled job to write users.yaml to the root of repository.  Should contain at least users with OpenShift.

This isn't a great idea.  Closing.

repo: bcgov/quickstart-openshift


text:
User Management | Edit User Role as Gov Admin or Managing Users roles

https://trello.com/c/9KWSUB2k/1053-user-management-edit-user-role-as-gov-admin-or-managing-users-roles
while logged in as a gov admin, on the edit user page, there is no drop down or option to change the role of a  user

 User Management | Edit User Role as Gov Admin or Managing Users roles

repo: bcgov/tfrs


text:
ZEVA - Remove automatic reduction

Describe the task
Automatic administrative reduction is not a necessary feature. It should be removed.
Purpose
This feature automatically deducts B credits when suppliers have insufficient credits but it should not. Deductions should only happen after the model year report is done.
Acceptance Criteria

[ ] Automatic administrative reduction is removed
[ ] The organization that had that happen needs to have the entry removed.

Additional context

This is likely a feature that was being tested at the inception of ZEVA that did not later get deleted.

One more note: automatic reductions should also not happen when a transfer gets issued (please see line 378 in services/credit_transaction.py)

repo: bcgov/zeva


text:
Lxc / Lxd Support?

Nice Tool. When can we expect the support of lxc/lxd?

Serious this could be pretty good but i'll stick to systemd-cgtop

I too would like to see support for lxc.  It looks like a very useful tool, but without an lxc connector, I can't use it.

+one for me too for LXD support if possible

Any news?

Let me be this year's commenter that would like to see LXC support :wink:

I will continue this tradition )

Pretty please with sugar on (c)top. :wink:

Bump for this year !

authors: 2b DavidWC bmullan damm despens emansije gregorg knutov tosigus

repo: bcicen/ctop

license: mit

license_source: bigquery


text:
set_cookie: foreach not consistent with preceding comment

Commit eb770fdc6d809bc7c28d499f897c0ab2c449f669 added the $samesite parameter to set_cookie(). But now there's a contradiction between the foreach and the comment on the immediately preceding line (system/core/Input.php lines 311-312):
  // always leave 'name' in last place, as the loop will break otherwise, due to $$item
  foreach (array('value', 'expire', 'domain', 'path', 'prefix', 'secure', 'httponly', 'name', 'samesite') as $item)

Either the comment or the code is wrong ....

The code is wrong.
If you pass an array as the first parameter to set_cookie, the samesite setting will be ignored, and defaults to $config['cookie_samesite'] from application/config/config.php.
set_cookie([
    'name' => 'foo',
    'value' => 'bar',
    'samesite' => 'None', // this is ignored
]);

authors: Kenqr rwalkerands

repo: bcit-ci/CodeIgniter


text:
On learning rate range test

Hi @bckenstler ,
Thanks a lot for sharing your implementation. I just read the paper on cyclical learning rate. I'd like to know how you dealt with the following

How do you choose the number of epochs to run the model?
When I run the LR range test, and estimate accuracy on validation set, I get an accuracy of 0.5 for almost all the learning rates. Since, the model is hardly trained, it is behaving as a random classifier. Then, the validation accuracy around 0.5 looks justified. But, this is not what the accuracy vs learning curve look like in the paper. How did you deal with this?
Thanks

@deepaksuresh I've tried to reproduce the CLR paper's experiment on CIFAR-10, especially of Figure 3's first two rows and Table1. However, what I got is different from the paper. If interested, you can try my code https://github.com/zchrissirhcz/Cyclical-Learing-Rates

authors: deepaksuresh zchrissirhcz

repo: bckenstler/CLR


text:
Defining an option key with "no-" in front of it

I'm working on a wrapper for some common command line things we do in a .NET project. One of things I'm trying to mirror is the .NET command dnu restore --no-cache. (The Node script will run the command automatically in a bunch of places.) I'd like the Node script's arguments to mirror dnu's, but I can't specify an option for --no-cache, as it's always seen as a negated version of --cache.
Where this gets rather annoying is that if my yargs is configured to be strict(), then it always fails because I haven't defined a "cache" option. I can define a "cache" option and default it to true to get the same behavior, but the --help for it ends up being confusing if you're expecting --no-cache. Maybe if an option is defined to start with "no-" then negation should be ignored? Or maybe add a flag when defining an option to disable negation?

Hey @MikeyBurkman our next major release of yargs allows you to turn on and off various parsing features:
You can add the following stanza to your package.json:
{
"yargs": {
"boolean-negation": false
}
}
See https://github.com/yargs/yargs-parser#configuration for details.
I would love for you to try this feature out, and give some feedback:
npm i yargs@alpha --save

authors: MikeyBurkman bcoe

repo: bcoe/yargs


text:
is it changed download file size!

when i download file from https://gaia.nullschool.net/data/gfs/current/current-wind-surface-level-gfs-0.5.epak ,saved file is bigger than webbrower saved file.

Crawler is not designed for downloading this kind of files, if you have problems about dealing with this file, please dive into the source code and solve go ahead.

https://github.com/bda-research/node-crawler/issues/215

it is related to #215, which has been resolved.

repo: bda-research/node-crawler


text:
feat: wheels for macOS and Windows

With any luck, just running the cibuildwheel step on other platforms than just Ubuntu should be enough...
⚠ I didn't test this yet, since I didn't want to yet try and wrangle the workflow to running the wheeling step for non-main refs...

Unfortunately, it blew up.  https://github.com/bdraco/ulid-transform/pull/12 might fix it but will be a few minutes before we know

That fixed it
@akx Do you need this bumped in hass?

@akx Do you need this bumped in hass?

Nah, no need :) I could build a wheel locally on my laptop, but other folks might not be so lucky. Thanks for the merge & fix!
(As an aside: other ulid-related prior art by yours truly: https://github.com/valohai/ulid2 ... :-) )

authors: akx bdraco

repo: bdraco/ulid-transform


text:
BDSX: Implement PlayerInteractEvent

Implements event.playerInteract
Description
Implements PlayerInteractEvent, which triggers on player interaction with entity using RMB, or holding on a touchscreen
Motivation and Context
Pretty useful event, I needed it multiple times, and I think other's too
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)

Checklist:

[x] My code follows the code style of this project.
[x] I have tested my changes and confirmed that they are working

How is it different from events.blockInterectedWith?
and please don't remove the template and fill out the form.

It triggers when player interacted with entity (I Mean RMB)

Filled template

Thanks for your contribution

authors: KostyaJRZ karikera

repo: bdsx/bdsx


text:
Zenhub Board Usage Check List

We should create a check list for ANY dev to check if issues on the board are in the correct state. We also have to find an easily accessible place where the list is stored.

Are the issues in the right column?
Are all issues in in progress or to review attached to the current sprint?
Are all issues which are in the current sprint estimated?
Do all issues in progress have an assignee?
Are all PRs attached to the respective issue?

@taleldayekh @istankovic @palango @weilbith @manuelwedler @nekhaly Please edit if something is missing

What happens to issues which are not done, but sprint is over? Moved to the next sprint?

Yes, that part is done automatically by Zenhub.

Thanks for compiling this list, @fredo ! :heart:

What are the next steps with this, @fredo?
I'm not sure how to proceed with this one.

authors: fredo istankovic

repo: beamer-bridge/beamer


text:
Shorten/Improve Tab Completion Output

Bean Shell's tab completion seems to be recursive. This really decreases the utility of tab completion, especially since it seems also that, rather than paging the tab completion possibilities with subsequent invocations of the tab completion functionality, Bean Shell just seems to... shorten the output list size, and print completion suggestions which it has already printed.. in fact the behavior is rather inexplicable..
Reported by: smirk-
Original Ticket: "beanshell/feature-requests/15":https://sourceforge.net/p/beanshell/feature-requests/15

Not entirely clear what the desired outcome should be.

I wonder if we should consider dropping features that are outside of the core interpreter,  Such as

servlet and remote
console
class browser
httpd
Basically most things in bsh.util.

These classes have zero value for me.  They are neat demonstration features but they are only samples.  Maybe put them in an unsupported example code folder.  Does anyone use these classes?

We could create separate repos for them, there is also #493 which will probably be easiest if separate releases are hosted in separate projects.

repo: beanshell/beanshell


text:
Feature Request: Allow specifying signcolumn behavior

Unless I've missed something it doesn't seem like there is a way to enable any signcolumn behavior other than auto, which (for me) causes annoying movements of code I'm editing with lsp diagnostics.  It would be nice if we could provide the value to set signcolumn to on WinEnter as part of the setup.  Eg. something like
require('focus').setup({
  enable = true,
  signcolumn = true,
  signcolumn_value = "yes"
})

For now I've modified my fork to use the value I want directly, so this isn't a high priority issue for me
Thanks for this great plugin!

Glad you are enjoying focus 😄
If I am understanding correctly, you can set signcolumn to false in the focus setup, and then put something along the lines of set signcolumn=yes in your configs. I just tried it then. I can add something into the readme FAQ or otherwise do you think it should definitely be an option included in focus?
The intention was that is you set auto signcolumn to false then you can configure it yourself using any option you like in your configs.

Ah I think I haven't done a good job describing the behavior I was hoping for.  I would like to leverage the auto commands that are set up by focus so that I can have signcolumn=yes on the active split only.  When I'm actively editing a specific split then having the signcolumn=auto is unfortunate, but once I move away from that split to another one, I would like focus to do what it currently does when 'setup({signcolumn=true})and setsigncolumn=no` to avoid wasting space
Does that make sense?

Ah I think I haven't done a good job describing the behavior I was hoping for. I would like to leverage the auto commands that are set up by focus so that I can have signcolumn=yes on the active split only. When I'm actively editing a specific split then having the signcolumn=auto is unfortunate, but once I move away from that split to another one, I would like focus to do what it currently does when setup({signcolumn=true}) and set signcolumn=no to avoid wasting space
Does that make sense?

Yes this makes sense. Let me get onto it

Setting it to auto is not fully resolving the issue. There is way more possible options for signcolumn. Please see :h signcolumn'`:
When and how to draw the signcolumn. Valid values are:
   "auto"       only when there is a sign to display
   "auto:[1-9]" resize to accommodate multiple signs up to the
                given number (maximum 9), e.g. "auto:4"
   "auto:[1-8]-[2-9]"
                resize to accommodate multiple signs up to the
                given maximum number (maximum 9) while keeping
                at least the given minimum (maximum 8) fixed
                space. The minimum number should always be less
                than the maximum number, e.g. "auto:2-5"
   "no"         never
   "yes"        always
   "yes:[1-9]"  always, with fixed space for signs up to the given
                number (maximum 9), e.g. "yes:3"
   "number"     display signs in the 'number' column. If the number
                column is not present, then behaves like 'auto'.

Probably the best way is to save its initial value in some state var, so read signcolumn if setup { signcolumn = true }.

Okay, I

Are you saying that if user has focus.signcolumn enabled (I don't) then the required way will be to set it through focus.nvim's configuration? That doesn't feel right. I think focus.nvim could manage it's internal state where initial (user set) values would be stored.
Not sure how to solve the issue of having option changed in running nvim rather than at startup (as focus.nvim would have startup value, not update one).

Yes so because what we are doing is creating an autocommand, the only way is to specify the user setting when creating the autocommand.
We could perhaps instead recreate the autocommands say on BufEnter events and grab the variable from vim itself and not configure it in focus.
Is this what you are referring to? We can do it, but it would require the autocommands to be set up at BufEnter I am pretty sure.

It could be
{ 'BufEnter,WinEnter', '*', 'setlocal signcolumn=' .. vim.opt.signcolumn:get() },

maybe? With some note in readme that signcolumn needs to be set before running setup().
It would still disregard user's change of that option after changing windows once.

vim.opt.signcolumn:get()

Thanks! This is much better

@kmclarnon @gegoune should not grab the var. you can run :set signcolumn=yes
let me know if any issues with it.

awesome, thanks!

Do we think this is safe to close now?

Yep, sorry for the delay 👍

All good no worries 👍  Thank you

authors: beauwilliams gegoune kmclarnon


text:
postinstall script fails on node 0.10.x

The postinstall script fails when installing on node 0.10.x. I've tested this on versions 0.10.32, 0.10.33, and 0.10.45. I've also tested this with npm versions 2.15.1 and 3.9.5 on each of those node versions.
It looks like it's because devDependencies aren't installed until after the postinstall script, so the sync-exec dependency isn't available when lib/post_install.js is run. Details on that here: https://github.com/npm/npm/issues/10366 and https://github.com/npm/npm/issues/4134
I'm not sure what can be done about this. Perhaps support for 0.10.x should be dropped for now, until a solution is found? Or maybe the /lib/post_install.js script can be modified to not require execSync. I'm not sure how else this could be solved.

I'm not sure what can be done about this. Perhaps support for 0.10.x should be dropped for now, until a solution is found? Or maybe the /lib/post_install.js script can be modified to not require execSync. I'm not sure how else this could be solved.

I don't have a great interest in supporting Node 0.10 given it's so old. I don't mind dropping it given it appears to be problematic.
If you can figure out a way to drop execSync I guess that would be the best solution. /lib/post_install.js is a hack at best. 😞

Yeah, I can't see any particularly nice solution. You could inline execSync or some equivalent function, but that'd be even more of a hack.
One option would be to transpile before publishing, rather than after. My impression from the npm folks is that they'd like to deprecate postinstall altogether because they want to prevent/discourage library authors from installing things aside from the library itself.
One option would be to transpile before publishing, rather than after. My impression from the npm folks is that they'd like to deprecate postinstall altogether because they want to prevent/discourage library authors from installing things aside from the library itself.
I haven't looked into it a whole lot, so perhaps there's a good reason not to do it that way. But that would solve this problem, and would make the package easier to install in general. Thoughts?

@Gudahtt I actually transpile before publishing to npm. The script is meant only for those users that use the git version for a reason or another.

Ah OK, thanks. I knew I had to be missing something - I've seen other libraries do this as well. Hmm.

@Gudahtt I guess dropping Node 0.10 would be the easiest way out. Just need to set up engines field and that's it. Btw, see my API prototype (esp. demo). If you have thoughts on that, comment at #109. This is a good time to get features in.

@bebraw Sure thing! Will do.
I think I might have a solution for the postinstall problem, without dropping support for 0.10.x. Using spawn instead of execSync should do the trick. I can create a PR.

@Gudahtt Ok, cool. That would be great.

Great, thanks! Problem solved.

authors: Gudahtt bebraw

repo: bebraw/reactabular


text:
tvl endpoint is missing in docs (README)

Hi,
Seems like the tvl endpoint is working, but there is no mention of it in the docs.
Furthermore, what is the output format ?
I see the following for example :
{
  "25": {
     ...
  },
  "56": {
     ...
   },
  "137": {
     ...
  }
}

What do these numbers mean ?
Thanks

Hi. The "numbers" you reference are the "Chain ID"s of the blockchains on which the Beefy vault contracts have been deployed.
Btw, the most active place to discuss aspects of Beefy's protocol is in the Beefy discord, the #development channel in this case.

Thanks, thought about discord but didn't know if this was too specific...
Shall I close this then, or leave it until info is in the README ?

authors: AllTradesz pmorange

repo: beefyfinance/beefy-api


text:
Bulk data insertion not working

Hi,
I'm trying to use postgres for bulk insertion in my database.
I have a CSV file
id,name
1,2010

I have setup postgres (0.2.12.0) instance on my local machine (fedora 22).
Trying to insert from CSV
curl -X POST -d @/tmp/toto.csv http://localhost:3000/seasons -H 'Content-Type: text/csv'

I have
{"hint":null,"details":null,"code":"42601","message":"erreur de syntaxe sur ou près de « returning »"}

but I can insert from JSON
curl -X POST -H 'Content-type: application/json' -d '{"name":"2010","id":"1"}'  http://localhost:3000/seasons

Is there a mistake (in HTTP headers for example) ?
Regards,

My csv is
name,id
2010,1
2011,2
2012,3
2013,4
2014,5
2015,6
2016,7

and query executed in postgresql was
insert into public.seasons (name, id2010, "12011", "22012", "32013", "42014", "52015", "62016", "7") values  returning row_to_json(public.seasons.*)

with v3, the query is
WITH pg_source AS (INSERT INTO  public.seasons  (name, id2010, "12011", "22012", "32013", "42014", "52015", "62016", "7")  VALUES  RETURNING public.seasons.*) SELECT null, pg_catalog.count(t), null, null FROM ( SELECT  pg_source.* FROM  pg_source   LIMIT ALL OFFSET 0) t

The error comes form this line https://github.com/begriffs/postgrest/blob/v3/src/PostgREST/App.hs#L269
We should have the check changed to make sure we have at least the header and one line (rows > 1)

@waghanza can you verify if the problem still exists in v0.3.1.1?

Pretty sure this has long been fixed. Re-open the issue if you have the same trouble on v0.4.

authors: begriffs ruslantalpa waghanza

repo: begriffs/postgrest


text:
Reg From Doc Name issue

It's optional field and should be required

repo: behruz-b/medical


text:
solarized-light modeline colours difficult to see

Hello,
I think the solarized light modeline colours are a difficult to see https://belak.github.io/base16-emacs/#sec-1-75, especially when the frame is in focus. Though I realise this may be just my matter of taste.

Sorry, turns out I should have searched for 'mode line', not 'modeline', #51


text:
chore(yarn): second attempt to make pnp works

Test out pnp related to this https://github.com/belgattitude/nextjs-monorepo-example/issues/800
Prisma still fails, maybe check https://github.com/prisma/prisma/issues/1439

pnp still have drawbacks when using standalone mode (@vercel/nft). Link: https://gist.github.com/belgattitude/0ecd26155b47e7be1be6163ecfbb0f0b
Closed

repo: belgattitude/nextjs-monorepo-example


text:
Penambahan algoritma -> Pascal Triangle on Math Folder

Menambahkan fungsi untuk mendapatkan segitiga pascal pada Math Folder

saya menggunakan
OS : Windows
Python: 3.9
tambahan lainnya

Boleh sensei @slowy07 ?

boleh go on, pake docstring nnti @KelvinMulyawan

sip sensei @slowy07

issue sudah solve

repo: bellshade/Python


text:
Плагин для сборки БЭМ проектов на gulp

Будьте добры, подскажите какой плагин стоит использовать для gulp, чтоб собирать БЭМ проекты? Желательно с документацией, тк новичок во всем этом :)

Использую
gulp-bem-bundle-builder
gulp-bem-bundler-fs
Вот пример https://github.com/hvab/palecore/blob/master/gulpfile.js

repo: bem-site/bem-forum-content-ru


text:
fix(kibbeh): improve download page

Signed-off-by: Oxygemo alej0hio2007@gmail.com

Always has been

I will try to fix the downloads page in this PR from now on. Kinda hate changing the scope of a PR but meh

You could take inspiration from the discord download page

That's what I'm planning to do. I'll most likely make a dropdown for Linux downloads instead of having a bazillion buttons for each way of packaging.

nvm will do that in a later pr. pls merge

fix the eslint error please

You could take inspiration from the discord download page

@ajmnz has to approve new design thingies.

@ajmnz has to approve new design thingies.

I didn't even get to design it, so no worries for now

You could take inspiration from the discord download page

no, don't do that. we will redesign when @ajmnz comes up with a design for this

fix the eslint error please
how the hell did that happen

Maybe just add a dropdown for all the Linux ones for now, and improve the design later ?

don't feel like doing that atm, but i'll do it in another pr

authors: BronzW DoeHetGewoon Odyssey346 ajmnz amitojsingh366 overlisted samarmohan

repo: benawad/dogehouse


text:
TEST

Choose a PR Template
Switch to "Preview" on this description then select one of the choices below.
Click here to open a PR for a Data Plane API.
Click here to open a PR for a Control Plane (ARM) API.

test

/requestmerge

/requestmerge

/requestmerge

/pr requestmerge

/pr requestmerge

repo: benbp/azure-rest-api-specs


text:
🛑 Canary Page is down

In edff073, Canary Page (https://canary.benfoster.dev) was down:

HTTP code: 503
Response time: 124 ms

Resolved: Canary Page is back up in 3ac264a.


text:
this is possible make a mask with this format?

this is possible make a mask with this format?

i can`t define delimiter with false? right?

Hi!
The better solution for what you want is to use a default textinput, convert the value into Number and apply decimal places.
You can see more info about decimal places in this link: https://www.w3schools.com/jsref/jsref_tofixed.asp

authors: benhurott henriqueweiand

repo: benhurott/react-native-masked-text


text:
[Feature Request] min/max column and row height/width and min/max item height/width

So I just found this component today and I really love it. It is simple to use and works pretty well.
But I really miss the option to set a minimum width and height vor Grid fields and also for items.
I am creating a currently nesting grids so that within an Item, there is another grid with just one column but each of the nested items do have same height as width and this is a bit annoying :)
Is this already planned for future and can I look forward to see this feature soon?
Greetings
Jan :)

Hi Jan,
Thanks for your positive feedback.
Indeed some of these features are inside the core already however i have not exposed them to vue props. To confirm i am on the same page you wish for the following options:

settable rowHeight instead of always keeping the grid square.
settable columnWidth instead of it growing or shrinking to fit the area
limits on column width (min/max) to avoid items getting to small /large (assuming colWidth is not statically set as per dot point 2?

Correct. These were my ideas.

Hi Jan,
Give the latest version a try. I think its what you are after: https://vue-responsive-dash.netlify.app/api/#dash-layout

It does work partly so far.
I've set a rowHeight to 20. That does work for items with height 1: They got a height of 20 px.
But if I resize them to a greater height, heights are 10 px to large. So when an Item uses more than one row, it is 10px to high.
Furthermore I would love to see a min/max colSpan and rowSpan to limit the user in resizing items.

It does work partly so far.
I've set a rowHeight to 20. That does work for items with height 1: They got a height of 20 px.
But if I resize them to a greater height, heights are 10 px to large. So when an Item uses more than one row, it is 10px to high.

Just found out that this is caused by the margin set in Layout, so it is not a bug 😇

No worries,
Another good thought about limiting size of items, ill have a think about how best to do this.

Released these features in latest version

Works great. Thank you so much! :+1:

repo: bensladden/vue-responsive-dash


text:
Refactored subparsers

The goal here is to make the parsers a whole lot easier to comprehend

@sahansk2 I know you haven't touched this in a while, but I was feeling like the commands were getting unwieldy. Do you think you can take a look at this?

I was thinking about doing a loop in __init__ to make the arguments automatically include the self variable, so you'd only have to call args.func(args) in GitGud.parse, but that seems like overkill and I'm not sure how to do it well

repo: benthayer/git-gud


text:
Dropbox File Open Doesn't Work For Some Paths

Tried to open a file with '@' and '+' in the file name (/Documents/@drafts/Lecture Notes +civil2.md). Got the following error:

Dropbox error (404: {"error": "Path '/documents/%40Drafts/Lecture Notes %2Bcivil2.md' not found"}).

File didn't open.

Commenting to report on the same issue. Stackedit will not open any file in a folder that begins with + or @. The symbols are being converted into Unicode as the previous commenter noted.

https://stackedit.io/app can't handle Unicode (for example, Chinese) in file path. But i remember https://stackedit.io/editor works well.

authors: RobertTalbert lance6716 willthong

repo: benweet/stackedit


text:
Is it support for IOS?

I have tried to build it with IOS target, but always not found the MusicKit ?

I have tried to run it on IOS, and both Mac and IPhone, didn't hear MIDI sound output ?

I haven't created an iOS example yet, but the examples do work on a Mac. The example apps transform MIDI, but do not produce sound. If you have a MIDI keyboard, the ChordRecognition example will identify the chords you play.
Creating more intuitive examples with audio output is definitely on the roadmap, but I've been pretty busy lately.

authors: benzguo etamity

repo: benzguo/MusicKit


text:
players can't enter a train before they press the use key anywhere

Nobody can enter a train before he presses the "USE" key anywhere in the world. After the player press the "USE" key on something, a block like stone, he can enter and leave the carts.
Spigot: 1.8.8 R0.1
Traincarts: 1.75
Tested with :

BKC: 1.65
BKC: 1.66 SNAPSHOT

And tested without any other plugins (only traincarts and bkcommonlib)

What is you BKCommonLib version?

tested with :
BKCommonLib V.: 1.65
BKCommonLib V.: 1.66 SNAPSHOT

Does this also happen when TrainCarts is not installed?

No, without traincarts the lores working normally.

Yep, I've reproduced this as well

I think this was in the the 1.7.10 version of traincarts too

Very old bug but its actually fixed for some time now. Had to do with a click-timeout measure in TC to prevent entering minecarts while clicking on blocks to put down tracks / spawn minecarts. Incorrect initialization of the timeout timestamp was to blame. Its fixed.

authors: RyanHecht bergerkiller donbubu mg-1999 timmaker

repo: bergerhealer/TrainCarts


text:
🛑 SIDAP is down

In 68abd41, SIDAP (http://uladap.adm.ula.ve/sidap/) was down:

HTTP code: 0
Response time: 0 ms

Resolved: SIDAP is back up in 5c26c88 after 21 hours, 17 minutes.

repo: berlinserver/estatus


text:
[Fabric 1.18] adding multiple looping animations at once doesn't work

I have a blockEntity which has multiple "idle" animations depending on its state, one needing to constantly loop on all instances of it, and others being state-dependent.
However, when I add the animation in code testing on state, only the first animation added plays
So with the following code, only pulseAnim will play, and the controller seems to completely ignore wingFlapAnim
var wingFlapAnim = "animation.strawberry.flap_wings_loop";
var pulseAnim = "animation.strawberry.pulse_loop";

controller.setAnimation(new AnimationBuilder().addAnimation(pulseAnim).addAnimation(wingFlapAnim));

same with the opposite, with the code below, only wingFlapAnim plays, and pulseAnim is nowhere to be seen
var wingFlapAnim = "animation.strawberry.flap_wings_loop";
var pulseAnim = "animation.strawberry.pulse_loop";

controller.setAnimation(new AnimationBuilder().addAnimation(pulseAnim).addAnimation(wingFlapAnim));

my whole code in this repo if it helps
in case it is of any importance, I would also like to note that I have code-driven animations here for this block

After a bit of inspection, it seems that addAnimation adds to a Queue??
Is there a way to combine animations ?

Each controller can only run a single animation at a time. This is modeled after the Bedrock animation system. By calling:
controller.setAnimation(new AnimationBuilder().addAnimation(first).addAnimation(second));

You are queueing up 2 animations in a row - the second will run when the first is finished. If you want 2 animations to run at the same time, you'll need to add 2 separate controllers to your animation handling class:
@Override
public void registerControllers(AnimationData data) {
    data.addAnimationController(new AnimationController<>(this, "wings", 10, this::handleWings));
    data.addAnimationController(new AnimationController<>(this, "pulse", 10, this::handlePulse));
}

This will allow you to layer/stack animations. For more information, I would recommend reading through the wiki article on this topic, which answers your question in detail.

Thanks for this precision! It worked like a charm :D
I don't know if this was mentioned in the wiki, perhaps I missed it?

well this has been answered, so ima close it

authors: Azagwen Draylar

repo: bernie-g/geckolib


text:
added onDoubleTap and onLongPress gestures

added onDoubleTap and onLongPress gestures to handle more gestures

Pull Request Test Coverage Report for Build 62

5 of 6 (83.33%)  changed or added relevant lines in 1 file are covered.
5 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.4%) to 59.293%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

lib/src/swiper.dart
5
6
83.33%

Files with Coverage Reduction
New Missed Lines
%

lib/src/swiper.dart
5
60.82%

Totals

Change from base Build 60:
-0.4%

Covered Lines:
386

Relevant Lines:
651

💛  - Coveralls

I don't know what this coverage/coveralls crap is, but please merge these changes into the next relase.

authors: coveralls phiwu


text:
remarque / conseil

on nous demande combien de temps on passe devant l'ordi hors boulot mais pas au boulot, or, on passe bcp de temps au travail sur l'ordi, ne faudrait-il pas l'inclure ?

Le temps passé devant l'ordi au travail relève de l'aspect professionnel. Nos Gestes Climat s'intéresse seulement aux aspects de la vie personnelle

Le temps passé devant l'ordi au travail relève de l'aspect professionnel. Nos Gestes Climat s'intéresse seulement aux aspects de la vie personnelle

authors: Benjamin-Boisserie-ABC publicodes

repo: betagouv/ecolab-data


text:
Connection timeout fetching images

$ python3 scripts/get_mapswipe_data.py 1
tart fetching tiles
fetched 0 tiles
fetched 10 tiles
fetched 20 tiles
fetched 30 tiles
fetched 40 tiles
fetched 50 tiles
fetched 60 tiles
fetched 70 tiles
fetched 80 tiles
fetched 90 tiles
Traceback (most recent call last):
  File "/home/pwaller/.local/lib/python3.5/site-packages/requests/packages/urllib3/connectionpool.py", line 544, in urlopen
    body=body, headers=headers)
  File "/home/pwaller/.local/lib/python3.5/site-packages/requests/packages/urllib3/connectionpool.py", line 349, in _make_request
    conn.request(method, url, **httplib_request_kw)
  File "/usr/lib/python3.5/http/client.py", line 1106, in request
    self._send_request(method, url, body, headers)
  File "/usr/lib/python3.5/http/client.py", line 1151, in _send_request
    self.endheaders(body)
  File "/usr/lib/python3.5/http/client.py", line 1102, in endheaders
    self._send_output(message_body)
  File "/usr/lib/python3.5/http/client.py", line 934, in _send_output
    self.send(msg)
  File "/usr/lib/python3.5/http/client.py", line 877, in send
    self.connect()
  File "/home/pwaller/.local/lib/python3.5/site-packages/requests/packages/urllib3/connection.py", line 155, in connect
    conn = self._new_conn()
  File "/home/pwaller/.local/lib/python3.5/site-packages/requests/packages/urllib3/connection.py", line 134, in _new_conn
    (self.host, self.port), self.timeout, **extra_kw)
  File "/home/pwaller/.local/lib/python3.5/site-packages/requests/packages/urllib3/util/connection.py", line 88, in create_connection
    raise err
  File "/home/pwaller/.local/lib/python3.5/site-packages/requests/packages/urllib3/util/connection.py", line 78, in create_connection
    sock.connect(sa)
TimeoutError: [Errno 110] Connection timed out

To get tiles from Bing without violating their TOS you need an API key, then fetch a JSON resource which tells you the URL and crucially a parameter to add to that URL. Currently that code is hardcoded. So beyond "temporary" failure I think this means we need to actually implement that extra round trip.
Docs: https://msdn.microsoft.com/en-us/library/ff701716.aspx

authors: betatim pwaller

repo: betatim/dreamview


text:
🛑 Emir Tarlan is down

In 14d3979, Emir Tarlan (https://emirtarlan.com) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Emir Tarlan is back up in da7dc53 after 30 minutes.

repo: betterwithagency/status-page


text:
on "shadow" doesn't get triggered if I move the element upwards

I'm probably missing something, but I'm trying to move an element inside a div container and I need to get its position while is moving. I'm using .on("shadow") and it's working great moving the element down, left or right but it seems that the event doesn't get triggered if I move my element upwards. Do you may know what am I missing?

I'm trying to debug it in a plunker and I noticed that if I remove this line of css:
.gu-hide {
display: none !important;
}
my icon it doesn't move anymore in any direction.
Here is the plunker.
http://embed.plnkr.co/Efa74I1on325k7Dhq0me/

Well sure, you shouldn't be removing that line. That's completely unrelated, though.

Check if the latest release fixes your issues, but I wasn't able to reproduce your bug report.

Hi Nicolas, thank you very much for looking into it, I've tried with the
new version but nothing change.
Did you have the chance to look into the plunker maybe?
What I'm trying to do is moving a div around a single area, the div (the
blue circle in the example) has position absolute because I needed to let
the user move it around and I set its top and left property on dragend. I
take the coordinate on shadow because is the only event I found triggering
on element moving.
I don't know if this is the right way of using dragula, but it seems
working apart from upwards direction.
If you check the console it prints coordinates on element dragging, and you
can see that if you are trying to go up nothing will be printed.
2015-07-30 2:30 GMT+02:00 Nicolas Bevacqua notifications@github.com:

Check if the latest release fixes your issues, but I wasn't able to
reproduce your bug report.
—
Reply to this email directly or view it on GitHub
https://github.com/bevacqua/dragula/issues/138#issuecomment-126138523.

--
Daniele Bertella
*web designer & developer *
+39.340.490.57.80
info@danielebertella.com
LinkedIn: danielebertella http://it.linkedin.com/in/danielebertella/
Twitter: _denb https://twitter.com/_denb
www.danielebertella.com

Dragula doesn't support absolute positioning. You may be able to get away with adding absolute positioning on dragend and removing it on drag.

OK got IT i will try then!
Il 09/ago/2015 18:51, "Nicolas Bevacqua" notifications@github.com ha
scritto:

Dragula doesn't support absolute positioning. You may be able to get away
with adding absolute positioning on dragend and removing it on drag.
—
Reply to this email directly or view it on GitHub
https://github.com/bevacqua/dragula/issues/138#issuecomment-129216302.

authors: bevacqua dbertella

repo: bevacqua/dragula


text:
Loading a .glb or .gltf with a jpeg throws an error

Bevy version
0.4.0
Operating system & version
Ubuntu 20.10
What you did
Create a new project and load a .glb or .gltf file through the asset server:
let terrain_handle: Handle<Mesh> =         asset_server.load("some_terrain.glb");
What you expected to happen
The asset will be loaded and no errors will be thrown.
What actually happened
An error was thrown:
thread 'IO Task Pool (0)' panicked at 'called `Result::unwrap()` on an `Err` value: AssetLoaderError(The image format Jpeg is not supported)', /home/user/.cargo/registry/src/github.com-1ecc6299db9ec823/bevy_asset-0.4.0/src/asset_server.rs:298:60 note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
Additional information
I'm just starting game development and Rust. Let me know if I can improve my bug report or code.

JPEG support is an optional cargo feature (only PNG and HDR are enabled by default). There are also features for DDS, TGA, BMP.
It is a similar thing with audio formats. MP3 is enabled by default, but others such as FLAC, WAV, and OGG Vorbis can be enabled with cargo features.
Try adding the jpeg cargo feature. If it works, then we can close this issue.

Thanks for your answer. Enabling the jpeg feature for the bevy dependency worked.
Example:
[dependencies]
bevy = { version = "0.4", features=["jpeg"] }

Is this mentioned in the documentation somewhere? Would it be nice to add this? I can help if needed.

thanks for this post. This solution worked for me too !

Thanks for your answer. Enabling the jpeg feature for the bevy dependency worked.
Example:
[dependencies]
bevy = { version = "0.4", features=["jpeg"] }

Is this mentioned in the documentation somewhere? Would it be nice to add this? I can help if needed.

Thanks for this comment. This fixed my issue too.

repo: bevyengine/bevy


text:
Filter queries within systems

What problem does this solve or what need does it fill?
You may need to access a query in both unfiltered and filtered forms within the same query.
What solution would you like?
Add a filter::<F>() method to Query, allowing you to take new subsets of a query.
If you want to get really clever, ideally you'd be able to have safe access to multiple mutually exclusive parts of the query at once.
What alternative(s) have you considered?
Filter over the entities one at a time using Option components and .is_changed methods. This is much slower, and less clear.
Additional context
This is somewhat more complex than it might first appear. Summarizing the discussion with @cart on this:

Archetypes are currently locked during parallel system execution, so we can freely add new With, Without or Changed filters.
We can't access new Changed filters using a naive implementation of this, as other systems running in parallel could flip those flags.

We could add another trait to differentiate this and then disallow Changed filtering. Alternatively, we could force any user to explicitly request read-access to the relevant information by adding an Info<T> query parameter, which would communicate intent to the schedule correctly.

Is this doable now with QueryLens?

Yep, calling this completed.

This looks more like the join functionality which isn't merged yet

authors: alice-i-cecile hymm james7132


text:
UI examples are deeply nested and not fun to read

What problem does this solve or what need does it fill?
UI examples could be more readable.
What solution would you like?
Reduce the nesting by extracting instances creation to functions.
This will not only make the whole layout cleaner,
but naming the functions appropriately will help defining what certain components do.
Additional context
I can do the PR just let me know whether this is desired.

The other pattern that I like is storing the entity id, and then using .push_children.
I'm in favor of this change though!

Yeah, there are many ways to go about it,
I'll experiment with few layouts in the PR,
I'm looking forward to feedback 😃

authors: MiniaczQ alice-i-cecile


text:
add DepthPrepass when DeferredPrepass is used

Objective
fix crash / misbehaviour when DeferredPrepass is used without DepthPrepass.

Deferred lighting requires the depth prepass texture to be present, so that the depth texture is available for binding. without it the prepass node doesn't run and nothing will be rendered.
When DeferredPrepass is used without other prepass markers, and with any materials that use OpaqueRenderMode::Forward, those entities will try to queue to the Opaque3dPrepass render phase, which doesn't exist, causing a crash.

Solution
add DepthPrepass marker to views with DeferredPrepass.
also changed some With<T>.is_some()s to Has<T>s

I think this definitely could make sense. Worth nothing though that this will create a discontinuity between the which prepass components the camera has in the main world vs the render world if the user only adds the deferred prepass.

i've been on a bit of a journey with this...
forcing the depth prepass whenever deferred is present is not ideal: if a scene has forward materials and deferred materials it forces the depth prepass to run for the forward materials even if not requested/required.
i thought maybe it would be better to make a new marker DepthPrepassTextureRequired and add it when DepthPrepass or DeferredPrepass are present. but, maybe somebody will implement a deferred lighting plugin that doesn't require the depth texture, so adding/copying the depth texture unconditionally still doesn't make sense.
also, dealing with shader defs gets a bit tricky: the prepass depth texture won't be populated for forward materials, so the def should not be present in the main pass for forward materials. but the view BindGroupLayout still needs to contain the corresponding entry to match the BindGroup, which will have the texture. currently both the layout and the def are based on MeshPipelineKey::DEPTH_PREPASS, and adding an extra key bit for "DEPTH_TEXTURE_IS_IN_THE_GROUP_BUT_SHOULDNT_BE_AVAILABLE_TO_THE_SHADER_BECAUSE_IT_WONT_BE_POPULATED" seemed like overkill.
so instead i just fixed the crash (we now check if the xxx3dPrepass phase exists before trying to queue to it), and added a note to the DeferredPrepass comment that it requires DepthPrepass as well. I also changed the condition on prepare_prepass_textures so the deferred textures are still created if only DeferredPrepass is present. this means the original issue of running depth prepass for forward materials is still present, but at least it doesn't crash, and if somebody wants to make a custom deferred pass that doesn't use depth then the DepthPrepass doesn't need to be added.

@robtfm I think this needs rebasing or something, the diff seems weird.


text:
Move float_ord from bevy_core to bevy_utils

Objective
Reduce the catch-all grab-bag of functionality in bevy_core by moving FloatOrd to bevy_utils.
A step in addressing #2931 and splitting bevy_core into more specific locations.
Solution
Move FloatOrd into bevy_utils. Fix the compile errors.
As a result, bevy_core_pipeline, bevy_pbr, bevy_sprite, bevy_text, and bevy_ui no longer depend on bevy_core (they were only using it for FloatOrd previously).

One quick question. I like this change though; it's clearly the right organization and the rest lgtm.

bors try

@CAD97 can you rebase?

This should be labeled as a breaking change: those who import single items from Bevy instead of the prelude will have their builds broken.

@CAD97 can you add a quick migration guide to this?


text:
Improve ergonomics and reduce boilerplate around creating text elements.

Objective
Creating UI elements is very boilerplate-y with lots of indentation.
This PR aims to reduce boilerplate around creating text elements.
Changelog

Renamed Text::with_section to from_section.
It no longer takes a TextAlignment as argument, as the vast majority of cases left it Default::default().
Added Text::from_sections which creates a Text from a list of TextSections.
Reduces line-count and reduces indentation by one level.
Added Text::with_alignment.
A builder style method for setting the TextAlignment of a Text.
Added TextSection::new.
Does not reduce line count, but reduces character count and made it easier to read. No more .to_string() calls!
Added TextSection::from_style which creates an empty TextSection with a style.
No more empty strings! Reduces indentation.
Added TextAlignment::CENTER and friends.

Note for reviewers.
Because of the nature of these changes I recommend viewing them in 'split diff view'.
Look for the book icon in the top-left of the Files changed tab.
Have fun reviewing :heart:
 >:D
Migration Guide
Text::with_section was renamed to from_section and no longer takes a TextAlignment as argument.
Use with_alignment to set the alignment instead.

The other related change I really want is a helper method for quickly getting the first section of text.

Ping @plof27 for review :)

@Weibye @TimJentzch, can I get your opinions on this?

bors r+

That new diff looks great!

authors: IceSentry alice-i-cecile devil-ira


text:
try_clone method for UI text and image bundles

Objective
ImageBundle, AtlasImageBundle and TextBundle don't implement Clone because ContentSize has a measure_func: Option<MeasureFunc> field which isn't cloneable.
But ContentSize should always be set to its default (where measure_func is None) with these bundles, anything else is a bug.
Solution
Manually implement Clone for each bundle and add an assertion that panics if a MeasureFunc is present.

Hopefully with Taffy 0.4, measure functions will be trait based. So it should be possible to make them properly Clone.

Hopefully with Taffy 0.4, measure functions will be trait based. So it should be possible to make them properly Clone.

I was thinking about this, and don't think it's worth it. Since the systems only query for changes in content, if you clone a node with a ContentSize the MeasureFunc will be overwritten anyway, making the cloning pointless.
Maybe cloning a ContentSize should just ignore the inner value, and always return ContentSize { measure_func: `None` }.

It would make sense to return Result<Self, Self>, where both the Ok and Err variant lack the MeasureFunc, but in the Ok case because the original had None already and the Err variant because that field was set to None. That way the method is more useful.

authors: ickshonpe nicoburns urben1680


text:
Fix env variable when calling check_output

The evaluate function currently sets the ROUGE_EVAL_HOME environment variable, but discards all others. This can cause failures when other environment variables are needed to run pyrouge. For example, we may need the PERL5LIB env variable to be able to locate certain Perl libraries needed to run ROUGE.
This PR fixes this by copying the current OS environment variables, and updating the ROUGE_EVAL_HOME one if needed, instead of only setting ROUGE_EVAL_HOME and discarding all others.

Thank you!

authors: bheinzerling mgrenander

repo: bheinzerling/pyrouge


text:
Develop rules gmv

This PR implements several important things:

Generic functional message in the form of ContinuousUnivariateLogPdf distribution. This distribution supports various domains and provides an interface for further message approximation (has not been implemented yet)
Testing utilities for testing rules and their results
As an example of introduced changes almost all rules have been reimplemented and tested for NormalMeanVariance node

Related to #15


text:
Printing imported names

is this what you want for #78?
using EzXML
    docstr = """
    <?xml version="1.0" encoding="UTF-8"?>
    <root>
        <foo>ok</foo>
    </root>
    """
doc = parsexml(docstr)
show(doc)
> EzXML.Document(EzXML.Node(<DOCUMENT_NODE@0x000000001014d320>))

import EzXML.Node
show(doc)
> EzXML.Document(Node(<DOCUMENT_NODE@0x000000001014d320>))

Cool! This is the thing what I wanted.
Can you add a similar method to the Document type?

Yeah but you've only overridden Base.show function for 'Node' and 'StreamReader' type.
So it Document is already working like this on '0.7.0' 😃
using EzXML
import EzXML.Document

show(doc)
> Document(EzXML.Node(<DOCUMENT_NODE@0x0000000027c375f0>))

Oops, you're right.

Thank you for your pull request :)

Happy to be helpful:) Thank you for great package!