text:
feat(Pointer): offset playAreaCursor to hint at relative player position

Add offset to playAreaCursor relative to hmd position, per discussion in issue #173

Thanks for the PR, looks good! I've just left a couple of points to look into :)

Great suggestions, thanks! I'll revise.

There were the following issues with your Pull Request

Commit: 0681644d8748d4858604860fd54524a4152cf618
Commits must be in the following format: %{type}(%{scope}): %{description}
Invalid type. Valid types are feat, fix, docs, style, refactor, perf, test, chore, revert

Guidelines are available at https://github.com/thestonefox/SteamVR_Unity_Toolkit

This message was auto-generated by https://gitcop.com

Close to being mergeable now :)
Just need to fix the commit message so it adheres to the gitcop rules.
Your original commit message would be fine, would be good to also include a longer description too.

Ok, I revised my second commit message that violated your gitcop rule and used git push --force to overwrite it. But I realize now that it might have been cleaner to repeatedly revise the original commit, since you don't necessarily want to merge a bunch of incremental commits from my branch as I figure out what to do. Or do you mind having those commits as long as they conform to the formatting rules?

I'd squash your changes so there is only 1 commit.
May be easier to just re-implement your changes in a new commit if you're not used to squashing git commits (it's only 3 lines really).
There's no need to have the history of the commit as the latest commit is pretty much the work you want to commit.

authors: GitCop sdouglas thestonefox


text:
Resolve security advisory

I love this project .. I am trying to get a long chain of security advisory warnings resolved from a project I am working on
When I run cargo audit on this project I get this warning
Crate:     time
Version:   0.1.45
Title:     Potential segfault in the time crate
Date:      2020-11-18
ID:        RUSTSEC-2020-0071
URL:       https://rustsec.org/advisories/RUSTSEC-2020-0071
Severity:  6.2 (medium)
Solution:  Upgrade to >=0.2.23
Dependency tree:
time 0.1.45
└── chrono 0.4.26
    └── theta-chart 0.0.5
        └── leptos_chart 0.1.0

I have created these issues  in theta-chart and chrono
When those are complete the fix here will be simple.

Thanks you,

Temporarily update to version 0.1.2 while waiting for chrono to fix.

source: gharchive/issue

license: MIT

license_type: permissive

license_source: github-api


text:
demo can't run

when run index.html on the demo.Video can not play and this error showed.

Thanks for reporting the issue. ThetaWebWidgets.js is a small file (about 11 kB). It could be just a hiccup. We have just verified that the demo worked. Could you try again? Thanks!

dgets

Yes,it works,now.

OK thanks for the confirmation

repo: thetatoken/theta-protocol-delivery-lib


text:
Added basic dependency injection

This will allow plugins to request Plugins and Libraries inside methods.

Example Code
using System;
using uMod;
using uMod.Libraries;

namespace uMod.Plugins
{
	[Info("The Test Plugin", "austinv900", "1.0.0")]
	[Description("A Test Plugin")]
	internal class TheTestPlugin : UniversalPlugin
	{
		private void Init()
		{
			PrintWarning("Hello world!");
		}

		private void Init(Plugin betterChat)
		{
			if (betterChat)
			{
				betterChat.Call("SomeAPI_Method");
			}
			PrintWarning("Hello world with BetterChat!");
		}

		private void OnServerInitialized(bool init, Libraries.Timer t)
		{
			PrintWarning("OnServerInitialized was called with timer");
			t.Once(5.0f, () =>
			{
				PrintWarning("Timer test was successful");
			}, this);
		}
	}
}

Per our discussion on Discord, libraries are already globally available so defining these per hook would be redundant and unnecessary. The library system is also on its way out, so I wouldn’t put too much effort in it.
As far as the plugin references go, the addition of those per hook/usage also seems like an unnecessary complication to an already simple system where you define once and done.
Feel free to discuss it with me further though in case I am missing some benefit to this.

A major feature inclusion such as this would need some type of justification outside of the proof of concept, especially in an FOSS project.  FOSS developers are known for being fairly meticulous so in the future for something like this I would suggest writing at least a brief 2-3 paragraph summary to accompany the proof of concept justifying why the proof is necessary.
That said, I'm not sure we should discard this one yet - though it might require some tweaking and more detail.
I will take the liberty of making a case for it since it's a fairly common (though sometimes counterintuitive) pattern in programming called dependency injection.  Dependency injection is generally seen as a way to decouple code, making it more flexible and less brittle.
Libraries are tightly coupled to plugins.  Though we currently have a limited number of libraries, coupling like this is generally considered to be a bad thing when avoidable.  Meaning that the Plugin, under the hood, must have the library instances attached to it directly.  Namely timers, permissions, webrequests, lang, etc.  For the sake of this PR I'll refer to them as libraries, even if we intend on removing the library abstraction, the concept is sound (as dependency injection could be implemented simply through global bindings or just an interface IDependency).
Though the PR could be more fleshed out to serve many ends, the approach itself (without too much work) could serve to eliminate coupling between plugins and libraries entirely.
I genuinely think that adding dependency injection to uMod would be a worthy addition.  I would only suggest a couple of things..

Provide justifications for your additions
Decouple the dependency injector from Library and use a generic container
Add a generic container, like this..

Interface.uMod.Bind(typeof(Libraries.Lang), delegate() {
   return Interface.uMod.GetLibrary<Libraries.Lang>();
});

source: gharchive/pull-request

authors: Calytic austinv900 lukespragg

repo: theumod/uMod


text:
Change format of glossary

Glossary button opens a table containing glossary terms and their descriptions. This might be better done using a description list: https://www.w3.org/WAI/WCAG21/Techniques/html/H40

Hi @FayCross not sure if you've seen this article which suggests that VoiceOver and NVDA both don't do well with definition lists and that their findings suggest that a table or unordered list is still the best, with use of scopes and roles...
https://snook.ca/archives/html_and_css/definition-lists-v-tables
It was written 10 years ago so not sure if it still hold up but probably worth looking into before we spend a lot of time reworking this.

@JohnSmith-LT interesting - I will have to do some testing. We could just leave it as a table - perhaps with a header row with 'term' & 'definition'

Maybe try finding some more recent guidance on this. Personally I don't think there's anything wrong with using a table like this but perhaps the markup could be improved upon to make it more accessible...
I will have a hunt when I get time and post anything here that I find that is more recent... Perhaps NVDA, VoiceOver and other screen readers are better at dealing with the mentioned issues than they were 10 years ago...

@JohnSmith-LT I tried it with NVDA yesterday a definition list of two terms and definitions was announced as 'list containing four items' and didn't make it clear that the term and definition were related in any way. I will close

authors: FayCross JohnSmith-LT

repo: thexerteproject/xerteonlinetoolkits


text:
Possible bug on path name and method name?

I have two services in different files:
src/controllers/v1/test.controller.ts
src/controllers/v2/test.controller.ts
The main path in the services are:
The first one
@Path('test/hello/v1')
export class TestController {
@Path('')
@POST
public async testName(name: string): Promise {
console.log("hello" + name);
return;
}
}
The second one
@Path('test/hello/v2')
export class TestController {
@Path('')
@POST
public async testName(name: string): Promise {
console.log("hello" + name);
return;
}
}
It throws me this error:
node_modules\typescript-rest\dist\decorators.js:1138
throw Error('Can not use more than one body parameter on the same method.');
I've tried many options but the only way to fix it is to do this:
The first one
@Path('test/hello')
export class TestController {
@Path('v1')
@POST
public async testNameV1(name: string): Promise {
console.log("hello" + name);
return;
}
}
The second one
@Path('test/hello')
export class TestController {
@Path('v2')
@POST
public async testNameV2(name: string): Promise {
console.log("hello" + name);
return;
}
}
Must put the end path in the method path name and change the method name. Is it good? Another way to do something like the first option?
Thank you.

Yes, I could reproduce it here. It is a serious bug. Thanks for reporting it.
I am working on it

repo: thiagobustamante/typescript-rest

license: mit

license_source: bigquery


text:
Plugin pattern: Router with opt-in upgrades (DO NOT MERGE)

Introduces PluginRegistry and RouterOptInUpgrades.
PluginRegistry.sol

Similar to PluginMap; maintains a map from fn selector -> plugin contract.
This map can be updated by a PLUGIN_ADMIN_ROLE role holder.
Contains the function isApprovedPlugin which returns true if the concerned plugin exists in the plugin registry's map.

function isApprovedPlugin(bytes4 functionSelector, address plugin) external view returns (bool);

RouterOptInUpgrades

Inherits Router with the following condition in _canSetPlugin:

    /// @dev Returns whether plug-in can be set in the given execution context.
    function _canSetPlugin(bytes4 _functionSelector, address _plugin) internal view virtual override returns (bool) {
        return
            hasRole(PLUGIN_ADMIN_ROLE, msg.sender) &&
            PluginRegistry(pluginRegistry).isApprovedPlugin(_functionSelector, _plugin);
    }

The plugin pattern has since been revised, and is now the Dynamic Contracts standard, which can be found in this repository.

repo: thirdweb-dev/contracts


text:
Hold note visual issue?

The hold notes look really weird

Known issue, will be fixed

Fixed in 2.0.0

authors: GrapieGrapie this-is-bennyk

repo: this-is-bennyk/FNF-Benjine


text:
✨ Hinzufügen einer "Request-confirmation" Mail

Done✅


text:
BuchstabierenTask-Bilder sollen vorab geladen werden

Bilder werden zur Zeit verzögert geladen, dies soll vermieden werden, indem die Bilder vorab (vllt im initState()) geladen werden

bilder werden vorab geladen
ausgenommen die App wird nach der Installation zum ersten Mal benutzt,
dann existiert weiterhin eine Verzögerung aber auch nur bei dem erst Aufruf des Buchstabieren_tasks

repo: thm-mni-ii/lama


text:
A way to remove cluster timeout

I think that there should be a way to turn off the cluster timeout option. May be if u set the value to negative number or 0.

Good idea.

repo: thomasdondorf/puppeteer-cluster


text:
is there a way to use different proxies for every instances?

some websites have ip blocking measures, i have to change ip for each instance after a while, is there a way i can use puppeteer-cluster to do that without start a new cluster?

I will suggest you handle proxy problem out of headless chrome.
build a proxy-switch-server and set you proxy server to proxy-switch-server.
It looks like

Yes, perfect answer given by @imfht (thanks!). This is currently not build into this library.
Ether do it with a custom proxy server or develop a solution without puppeteer-cluster.

@imfht Thank you for your suggestion, this load balancing strategy is really good for scrapping, yet i want each browser instance stick to one specific socks5 proxy(like tor) so sessions wont get blocked for swapping IP. But I guess puppeteer-cluster is not designed to do this kind of task?

That is currently not supported, but I could modify the library to support your use case (as it is trivial to implement).
What you need to do is copy one of the browser concurrency files and implement a custom launch function:
https://github.com/thomasdondorf/puppeteer-cluster/blob/master/src/browser/ConcurrencyBrowser.ts#L15
If that works for you, I can change the current implementation to support custom concurrency implementations.

I added a way in version 0.12 to provide any object as concurrency option. That way, this could be implemented very easy.
The concurrency implementation can be changed to call the launch function with custom arguments (like proxy) for each worker.
Documentation is coming soon.

Added tests, fixed a bug and added documentation. This feature is now ready to use. Just copy one of the concurreny implementations (like Browser) and provide the class to the concurrency option.

That is currently not supported, but I could modify the library to support your use case (as it is trivial to implement).
What you need to do is copy one of the browser concurrency files and implement a custom launch function:
https://github.com/thomasdondorf/puppeteer-cluster/blob/master/src/browser/ConcurrencyBrowser.ts#L15
If that works for you, I can change the current implementation to support custom concurrency implementations.

In my case, I don't know all the proxies IP addresses at cluster instantiation. Proxy IPs and corresponding credentials are obtained from a database and once fetched, a cluster worker needs to be created with these proxy credentials and currently, there is no way to pass any arguments to custom ClusterImplementation on queuing a worker task. Any thoughts on this use case?

authors: cyxou imfht lxwang42 thomasdondorf


text:
using multiple cores for calculationg startrails / keogram

hi,
i played around with the allsky software and had to run the startrail app often, to find a good brightness level.
there I found, that it was very slow. in htop I saw, only 1 core of my raspberry was used, 3 cores had nothing to do.
after investigating the code, I got the idea to run the mathematical part of startrails in more than 1 thread.
so I extended the code to 4 threads, controled by a new command line flag (-m).
see the screenshot of htop, using all the raspberry calculating power. the calculation of the startrails is almost 4 times faster than the single core code.

please see here the modified file. it is not optimal, but fast an good for raspberry 3 / 4.
I also added a dimension check of the images, because i use image cropping and sometimes, the images are in original size, not cropped.
startrails.zip

No worries - you contributed some actual code and that's extremely helpful. This is also relevant to my interests, since I reprocess on my workstation with lots of cores and memory.

authors: ckuethe sebmueller

repo: thomasjacquin/allsky


text:
🛑 Dashboards-NBG is down

In 6572647, Dashboards-NBG ($URL_DASHBOARDS_DE) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Dashboards-NBG is back up in 8256d6c after 5 minutes.

repo: thomasmerz/upptime


text:
Add koa-router with koa-mount example

Closes #3.

@thomseddon added a quick example but hoping this matches your idea.

:+1: looks good to me

Thanks for the review @thomseddon.

authors: ruimarinho thomseddon

repo: thomseddon/koa-oauth-server


text:
Error logging in (ERROR: Navigated to password page for the  2nd time. Exiting...)

I set up the add-on yesterday and was able to successfully retrieve my data usage and migrate it into HA that morning. However, after that first time, it now consistently gives the "ERROR:  Navigated to password page for the  2nd time. Exiting..." error. This continues 2-3 times before eventually hanging with high CPU/RAM usage. I have already attempted reinstalling the add-on (choosing to wipe data) as well as resetting my configs and reentering all info. I have also confirmed I am able to login with the credentials used in the config via my browser, and I do not have 2FA enabled. Attached are the debug logs. Thanks for this app, it is MUCH appreciated, wish Xfinity made it easier to track usage.
logs.pdf

To add, not sure if my password should be in plain text in the logs (assume it should for XFINITY_PASSWORD) and if so, it appears that the add-on is ignoring my actual password in my config and replacing it with a string of random characters.

I had luck with the new version for a few hours and it started failing again. Same problem.

Let know if v0.1.2.2 helps.  Xfinity's bot detection is causing a lot of headaches.

Let know if v0.1.2.2 helps. Xfinity's bot detection is causing a lot of headaches.

Yup, hat worked! Thank you for your work on this, much appreciated!

authors: J-CMartin izzletodasmizzle thor0215


text:
inner-loop timeout

Note: Asked here: https://stackoverflow.com/questions/65173084/timeout-and-skip-a-block-of-code-inside-a-python-iteration
How can I skip and continue when a step of a loop takes too long?
Below are a few desirable interfaces I'd like:
for x in some_collection:
    with Timeout(2.5):  # time out after 2.5 seconds
        do_something(x)

Would be nice (and even better -- but might be harder):
with TimeoutLoopStep(2.5):  # time out after 2.5 seconds
    for x in some_collection:
        do_something(x)

Possibly an equivalent timeout_loop_step decorator to consume iterators in that manner:
timeout_loop_step(2.5)(map(do_something, some_collection))

The following (based on SO answers) doesn't do the job since this Timer thing just "Call a function after a specified number of seconds". What we want is a means to "interrupt the call of a function after a specified number of seconds".
from threading import Timer

class Watchdog(Exception):
    def __init__(self, timeout, callback=None):  # timeout in seconds
        self.timeout = timeout
        self.callback = callback if callback is not None else self.raise_self
        self.timer = Timer(self.timeout, self.callback)

    def __enter__(self):
        self.timer.cancel()
        self.timer = Timer(self.timeout, self.callback)
        self.timer.start()
        return self

    def __exit__(self, *args):
        self.timer.cancel()

    def raise_self(self):
        raise self

def wait_and_return(x):
    time.sleep(x)
    return "computed"

def callback():
    print('callback is being called')
    return "timedout"

r = None
with Watchdog(1, callback):
    r = wait_and_return(0.5)
assert r == 'computed'

Another solution route: https://stackoverflow.com/questions/492519/timeout-on-a-function-call

Timeout on code execution:

https://stackoverflow.com/questions/492519/timeout-on-a-function-call
(https://pypi.org/project/func-timeout/, untried)

Python and functional programming
The advice from the core team on how to do functional programming in Python:

https://docs.python.org/3/howto/functional.html

repo: thorwhalen/umpyre


text:
Update README.md

Adding Hakiri badge to highlight some potential dependency security warnings (the way you have it in Paperclip).

Thanks for the contribution. I'm not inclined to merge this as I think the warnings it finds are misleading. For instance, the current build has 1 warning for code injection, which sounds really bad. Upon investigation, I see that it's for a nokogiri issue. I do not depend on nokogiri directly in this application. To solve this issue, I can either get everyone else (including Rails) to bump their acceptable version of nokogiri or I can create a false direct dependency on nokogiri.
I think these services are great for end user applications as the user is in the best place to decide how to mitigate any warnings.

@derekprior, yes, some dependencies are transitive and are not used in a gem directly. Those can be marked as false positives. Do you think there is still value in continuous security monitoring for non-transitive dependencies in this gem?

authors: derekprior vasinov

repo: thoughtbot/clearance


text:
Easy to accidentally load spec/support/factory_bot.rb twice

I came across the error of my factories being loaded twice because I was requiring FactoryBot::Syntax::Methods twice.
It's pretty easy to do by adding the whole snippet below in the Getting Started guide. (A few others have noted on SO)
# spec/support/factory_bot.rb
RSpec.configure do |config|
  config.include FactoryBot::Syntax::Methods
end

# RSpec without Rails
RSpec.configure do |config|
  config.include FactoryBot::Syntax::Methods

  config.before(:suite) do
    FactoryBot.find_definitions
  end
end

I've created a quick PR to clarify a bit, would love if you guys could take a look!

Closed by 8ad9cb1d716016c18c7fb349b32e474bb0aa4d94. Thanks!

authors: composerinteralia jarvisjohnson


text:
thcrap_configure: remember shortcuts settings

It would be nice if thcrap_configure could remember which shortcuts settings the user used the last time, and re-apply them automatically. The user is likely to reuse the same settings.

Done in bf2c146e095726b6c7a34da3857d823da6b71137, will be included in the next version

repo: thpatch/thcrap

license: unlicense


text:
Payment screen refers to previous payment screeen which is not in the chatflow

eVDC deployment flow after you have put in all the required data (name, secret, type of eVDC then comes the payment screen:

First line it sais: Please scan the QR Code below for the payment details if you missed it from the previous screen
There is no previous screen so change to: Please scan the QR Code below for the payment

9751f7318bf6f40419272af192a9f8c253a11df4

9751f7318bf6f40419272af192a9f8c253a11df4

verified on vdc.testnet.grid.tf

verified on vdc.testnet.grid.tf

authors: waleedhammam weynandkuijpers xmonader

repo: threefoldtech/js-sdk


text:
Error starting a halted 3bot container using 3sdk

branch development commit c99a93e849f64e65ac91f393a5e3473d60386977
3sdk> container start

@param server=True will start 3bot server

3bot
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/Users/rob/sandbox/code/github/threefoldtech/jumpscaleX_core/install/threesdk/container.py", line 120, in start
    c = _containers.get(name=name)
  File "/Users/rob/sandbox/code/github/threefoldtech/jumpscaleX_core/install/threesdk/lib/SDKContainers.py", line 74, in get
    if not docker.executor.exists("/sandbox/cfg/.configured"):
  File "/Users/rob/sandbox/code/github/threefoldtech/jumpscaleX_core/install/threesdk/InstallTools.py", line 5402, in executor
    if not self._executor:
AttributeError: 'DockerContainer' object has no attribute '_executor'

'DockerContainer' object has no attribute '_executor'
3sdk> container list

list the containers

 - 3bot       : localhost       : threefoldtech/3bot2       (sshport:9000)
3sdk> container kosmos

start kosmos shell

Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/Users/rob/sandbox/code/github/threefoldtech/jumpscaleX_core/install/threesdk/container.py", line 104, in kosmos
    c = _containers.get(name=name)
  File "/Users/rob/sandbox/code/github/threefoldtech/jumpscaleX_core/install/threesdk/lib/SDKContainers.py", line 74, in get
    if not docker.executor.exists("/sandbox/cfg/.configured"):
  File "/Users/rob/sandbox/code/github/threefoldtech/jumpscaleX_core/install/threesdk/InstallTools.py", line 5402, in executor
    if not self._executor:
AttributeError: 'DockerContainer' object has no attribute '_executor'

'DockerContainer' object has no attribute '_executor'

It worked today


text:
investigate whether provider could wait for deployments concurrently.

Currently, resources like network and kubernetes wait sequentially for a deployment to be deployed on a node.
And although chain transactions could only happen sequentially for now, the provider doesn't have to wait for every deployment to be deployed on a node.
So, could deployment creations and updates be done sequentially, and then let the provider wait for all deployments to be deployed concurrently?

duplicate of https://github.com/threefoldtech/terraform-provider-grid/issues/12

authors: MarioBassem ashraffouda

repo: threefoldtech/terraform-provider-grid


text:
change deployment list titles

Description
Describe the changes introduced by this PR and what does it affect
the new titles
Clusters,
CapRover machines,
Discourse machines,
Funkwhale machines,
Mastodon machines,
Mattermost machines,
Owncloud machines,
Peertube machines,
Subsquid machines,
Taiga machines,
Wordpress machines,
Gateway names,
TFhubValidator machines,
Casperlabs machines,
Presearch machines,
QSFS virtual machines,
Micro Virtual machines,
Node Pilot machines,
Full virtual machines,
Algorand machines,
Umbrel machines,

Some of them are not used, but we should have them to avoid any error while accessing the deplomentTitle with the project name

Changes
List of changes this PR includes
Related Issues
List of related issues
Checklist

[ ] Tests included
[x] Build pass
[ ] Documentation
[x] Code format and docstrings
[x] Screenshots/Video attached (needed for UI changes)

Virtual Machines
Kubernetes, and caprover use Cluster suffix
Everything else can be X instances

repo: threefoldtech/tfgrid-sdk-ts


text:
Create 404 page

Currently, we do not have any 404 page.
Need to create a 404 page and also add the route in router.

Hi, I want to work on this issue. Assign it to me.

@milinddethe15 go ahead.

Join our Discord server to discuss ideas, ask questions, and collaborate with others.

repo: thtauhid/open-profile


text:
camera fov and default dist? How to render the output mesh so that it look like the input image most?

Hi authors, thank you for this great work!
I wonder how can I render the output mesh, so that the rendered image would look like the input image most? Specifically, what is the camera fov in degrees, and default distance between the camera and the mesh? or maybe we should scale the mesh first?
Thank you!!!

Hi, Thank you for the interest @YuQiao0303
We use the nvdiffrast for differential render in training, so if you want the rendered image most like the input image, you need render the output mesh using nvdiffrast.
For the fov, We render the ground truth image through blender python api like shap-e, so the fov is the default fov in blender (rad 0.6911112070083618, sorry i can't find the doc specifically saying the default fov, it is the value i export by the script) .
For the distance, our reconstruction model is trained by scale the mesh [-0.5, 0.5] to [-0.95, 0.95] as 3dgen. If you want the rendered image most like the input image, you need to set the distance between the camera and the mesh to 2 * 0.95 / 0.5=3.8, or scale the exported mesh by 0.5 / 0.95  and keep the distance at 2.
Looking forward for your reply

Hi, Thank you for the interest @YuQiao0303
We use the nvdiffrast for differential render in training, so if you want the rendered image most like the input image, you need render the output mesh using nvdiffrast.
For the fov, We render the ground truth image through blender python api like shap-e, so the fov is the default fov in blender (rad 0.6911112070083618, sorry i can't find the doc specifically saying the default fov, it is the value i export by the script) .
For the distance, our reconstruction model is trained by scale the mesh [-0.5, 0.5] to [-0.95, 0.95] as 3dgen. If you want the rendered image most like the input image, you need to set the distance between the camera and the mesh to 2 * 0.95 / 0.5=3.8, or scale the exported mesh by 0.5 / 0.95 and keep the distance at 2.
Looking forward for your reply

Hi author! Thank you for your fast and detailed reply!!!  I really appreciate it!
I test rendering using nvdiffrast, though following your mentioned settings looks a little strange. The image is overall too small and the camera settings seem wrong.   (see right part of the image)
I accidentally found that using an orthogonal camera seems good. (see middle part of the image).
Thank you so much !!!

repo: thu-ml/CRM


text:
DAMD evaluation

Hi, thanks for releasing the source code.
However, this log got the much higher result than this paper reported. I don't know the difference between these two settings.
https://github.com/thu-spmi/damd-multiwoz/blob/9b0456d7e590fb5de77ec81e967e8010487eeb56/experiments/all_multi_acts_sample3_sd666_lr0.005_bs80_sp5_dc3/eval_log.json#L89

Hi,
The higher result is due to the use of the ground truth belief state for searching the database. The result is comparable to line 7 in Table 2 of our paper (slightly higher since we report the average score of 5 runs in the paper).  If you want to reproduce the result of line 12, you need to set "bspn_mode='bspn'" and "use_true_bspn_for_ctr_eval=False".

Thanks for the information.

repo: thu-spmi/damd-multiwoz


text:
🛑 Anylearn is down

In e1c41e0, Anylearn (https://anylearn.nelbds.cn) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Anylearn is back up in 969d9c3.

repo: thulab/anylearn-status


text:
Use tabs for documenting the token platforms

We currently use a dropdown which folks have said is hard to find. Using tabs would make it more consistent with our component pages:

Thanks @webbower for pointing this out!

Is Tabs an actual component yet?  If so, we'd definitely use it on the Help site.

@benknight — It is not. But I imagine it'd be helpful.
cc: @jonpkerwin

@webbower — This is now live 🎉

authors: benknight danoc

repo: thumbtack/thumbprint


text:
The mAP of ImageNet is different from that on paper

Can you share the parameters setting on ImageNet?
I follow the settings described on paper, but obtain a bad result:

The pytorch version of the code perform badly on ImageNet. We do not find the reason yet. Please use the caffe version if you want to run on ImageNet.

Could you share the link of caffe version? I can't find it on github.

check caffe directory

I directly use your pretrained caffe's model to evaluate the mAP on ImageNet, and some results are as follows;

16bit: 0.4643
32bit: 0.5934

However, the results on your paper are as follows:

What makes this difference?

Maybe it is because the caffe framework changes or other reason such as initialization. I'm sure it can reproduce the results at publishing.

I retrained the model and obtain an ideal result. Thank you~

I retrained the model and obtain an ideal result. Thank you~

请问是如何训练的？我用PyTorch在DSH、DHN和HashNet三个算法上复现，均是在Imagenet数据集上表现奇差。

I retrained the model and obtain an ideal result. Thank you~

请问是如何训练的？我用PyTorch在DSH、DHN和HashNet三个算法上复现，均是在Imagenet数据集上表现奇差。

我之前跑过HashNet的作者提供的PyTorch版本，也自己复现过，但是在ImageNet上表现都不好，但我感觉你的表现好像比我的还更差。不过如果直接跑caffe的版本的话，结果和论文差不多。

authors: TreezzZ caozhangjie caozhangjiex chenshen03

repo: thuml/HashNet


text:
🛑 Nyasama is down

In 8d953da, Nyasama (https://bbs.nyasama.com/) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Nyasama is back up in 0e88097 after 12 minutes.

repo: thwiki/status


text:
Error while calling client.getAccountInformation()

code :
const { SpotClient } = require("binance");
require("dotenv").config();

const client = new SpotClient({
    api_key: process.env.APIKEY,
    api_secret: process.env.SECRET,
});

client
    .getAccountInformation()
    .then(data => {
        console.log("data :", data);
    })
    .catch(err => {
        console.log("error :", err);
    });

Console :
error : {
  code: undefined,
  message: undefined,
  body: '
404 Not found
',
  headers: {
    'content-length': '48',
    connection: 'close',
    date: 'Mon, 16 Aug 2021 15:04:45 GMT',
    server: 'nginx',
    'strict-transport-security': 'max-age=31536000; includeSubdomains',
    'x-frame-options': 'SAMEORIGIN',
    'x-xss-protection': '1; mode=block',
    'x-content-type-options': 'nosniff',
    'content-security-policy': "default-src 'self'",
    'x-content-security-policy': "default-src 'self'",
    'x-webkit-csp': "default-src 'self'",
    'cache-control': 'no-cache, no-store, must-revalidate',
    pragma: 'no-cache',
    expires: '0',
    'x-cache': 'Error from cloudfront',
    via: '1.1 50cac58b596cabc9a79db20889c98bc1.cloudfront.net (CloudFront)',
    'x-amz-cf-pop': 'BOM52-C1',
    'x-amz-cf-id': '13uwVvA4N8sDvQm04Zk1BAEiPLDZD975Y_wFDiukA4hosxj1Te5_NA=='
  },
  requestUrl: 'https://api.binance.com/api/v3/account',
  requestBody: undefined,
  requestOptions: {
    recvWindow: 5000,
    syncIntervalMs: 3600000,
    strictParamValidation: false,
    api_key: '###apikey###',
    api_secret: '###apisecret###'
  }
}

I tried calling other functions like getAllOrders, getOpenOrders etc. they work fine.
Am i missing something here?

Fixed in 2.0.1 (#129). Thanks @harsh132

repo: tiagosiebler/binance


text:
Working with Pydantic v1 while having v2 installed

Discussed in https://github.com/tiangolo/fastapi/discussions/9966

Originally posted by slafs July 29, 2023
This is a continuation of a topic introduced in https://github.com/tiangolo/fastapi/discussions/9709#discussioncomment-6449868 as requested by @Kludex. I've chosen the "Show and tell" category as the (lack of) template seems better for this discussion.
In the original thread I've asked if there's a way to work with pydantic v1 while having v2 installed:
Pydantic v2 ships the latest version of v1 for easier migration, so the pattern is to work with v1 via things like from pydantic.v1 import BaseModel etc. while having v2 installed.
Currently, this approach doesn't seem to work with FastAPI 0.100.0 and the following snippet:
from fastapi import FastAPI

from pydantic.v1 import BaseModel

class Model(BaseModel):
    foo: str = "foo"
    bar: int = 2

app = FastAPI()

@app.get("/")
def root(model: Model) -> Model:
    return model

produces the following error:
Traceback (most recent call last):
  File ".../fiddles/fastapi_pydantic_v1_on_v2.py", line 15, in <module>
    def root(model: Model) -> Model:
  File ".../lib/python3.10/site-packages/fastapi/routing.py", line 706, in decorator
    self.add_api_route(
  File ".../lib/python3.10/site-packages/fastapi/routing.py", line 645, in add_api_route
    route = route_class(
  File ".../lib/python3.10/site-packages/fastapi/routing.py", line 448, in __init__
    self.response_field = create_response_field(
  File ".../lib/python3.10/site-packages/fastapi/utils.py", line 101, in create_response_field
    raise fastapi.exceptions.FastAPIError(
fastapi.exceptions.FastAPIError: Invalid args for response field! Hint: check that <class '__main__.Model'> is a valid Pydantic field type. If you are using a return type annotation that is not a valid Pydantic field (e.g. Union[Response, dict, None]) you can disable generating the response model from the type annotation with the path operation decorator parameter response_model=None. Read more: https://fastapi.tiangolo.com/tutorial/response-model/

Switching from pydantic.v1 to just pydantic (v2) obviously works.
I'm seeing there's fastapi._compat module and PYDANTIC_V2 var, but I'm not sure if that's the right direction.
For reference, installed versions:
fastapi==0.100.0
pydantic==2.0.3
pydantic_core==2.3.0

Now... that being said, I'm not even sure if this would be helpful to anyone even if FastAPI did support it. My initial thought was that this would ease the migration, but the reality seems more complicated. E.g. models are used by other models and even Pydantic itself doesn't support mixing v1 and v2 together. So given that the cost of figuring out the plan for the gradual migration seems comparable with doing the whole migration at once (at least for us).
Maybe it would be useful if people commented on their intended use case and see if that's actually a feature that's needed/wanted.

In case it helps, I started PR about that:
https://github.com/tiangolo/fastapi/pull/10223

+1 to
TypeError: BaseModel.validate() takes 2 positional arguments but 3 were given

error

.

Maybe it would be useful if people commented on their intended use case and see if that's actually a feature that's needed/wanted.

It seems people have been primarily doing that on #10223 and in issues opened against a heap of other projects (see above).
In short, not supporting the pydantic.v1 models completely blocks codebases that can't be upgraded all in one go to pydantic v2 (not practical in larger codebases, and the bump-pydantic tool misses many issues), which prevents people either from upgrading to pydantic v2 (which, at least based on its docs, seems like a solid improvement on v1) or keeps people on old versions of fastapi.
It also means that FastAPI doesn't really support pydantic v1 as indicated here. Specifically, it doesn't really support pydantic v2, since the backwards compatibility with pydantic v1 models is an important feature of that version allowing progressive upgrades.
Unfortunately that PR, though well-intentioned, appears to be abandoned. It's a bit lacking in detail as to what's left to be done or why it's not ready to merge, so it seems unlikely anyone'll be able to pick it up either - which given the amount of people asking about its status might otherwise have happened, though I'm under no illusion that it's much easier to ask about progress than to act on it yourself 😄

Unfortunately that PR, though well-intentioned, appears to be abandoned.

If you talk about PR #10223, it was complete IMO at the time of creation but sadly never got any response from @tiangolo.
I am willing to rebase it but not without feedback.

@tiangolo Any update on this issue??

Any way of getting some visibility here? It’s currently very hard to migrate for large code bases.

Joining the thread as well, I'm WIP updating from Pydantic V1 to V2 on a massive code base with dozens of FastAPI routes and hundreds of models. I use the "from pydantic.v1 import BaseModel" approach, however I have failures to generate OpenApi schema using FastAPI "get_openapi" utility since the schema generation fails when encountering a field with Pydantic V1 @validator decorator which is treated as a field instead of being ignored from the schema scanner.

A good comprise might be if the pydantic v1 vs v2 logic was applied per APIRouter.
Each router can use either Pydantic V1 models or V2 models, but not use both simultaneously.
Devs witch a large code base can then migrate per router (and if need be, break up their app to use multiple routers).

Any news about this? I thought that i could easily apply fastapi and pydantic v2 upgrade but this totally blocks me.

Any update? It's making it very difficult to migrate large codebases to Pydantic v2.

Any update on this?

authors: 7adidaz AlonMorgen EldarSehayekZenity Kilo59 Kludex chbndrhnns code-yeongyu dariota derekahuang hduce mike0sv tomtom103

repo: tiangolo/fastapi


text:
[BUG] OAuth2PasswordRequestForm returns 422 instead of 400

Describe the bug
When a validation error occurs on an OAuth2PasswordReqeustForm, the HTTP response code is 422 Unprocessable Entity). However, the OAuth2 spec specifies that either a 400 Bad Request or 401 Unauthorized MUST be returned. Also, a generic pydantic error JSON is returned, but the RFC specifies differently. Therefore FastAPI's imlementation is non-conformant. I understand these issues can be worked around in a custom implementation, but I feel that the default, batteries-included implementation should follow the spec correctly. Arguably a 422 is actually more suitable in this case, but its use is also likely to break OAuth2 client libraries.
To Reproduce

Create a file with:

from fastapi import FastAPI
from fastapi.security.oauth2 import OAuth2PasswordBearer, OAuth2PasswordRequestForm

app = FastAPI()
oauth2_scheme = OAuth2PasswordBearer(tokenUrl="/token")

@app.post("/token")
def login(form: OAuth2PasswordRequestForm):
    return {"access_token": "faketoken", "token_type": "bearer"}

Send an invalid request form
Observe the non-conformant 422 error with pydantic JSON error response

Expected behavior
A 400 error is returned with a valid error response as described in https://tools.ietf.org/html/rfc6749#section-5.2

Not sure there's an ideal way to implement this without a significant architectural change.

422 is a webdav thing.  a lot of APIs may choose to leverage this explicitly but it seems odd that this is a default unless this was settled upon by digging through stackoverflow comments.  I could be wrong, but I haven't seen an RFC that indicates that 422 is the valid for any response except a webdav interface so it seems odd that fastapi defaults to it.

422 is Unprocessable Entity
https://developer.mozilla.org/en-US/docs/Web/HTTP/Status/422

authors: amacfie retnikt sarathak stephenoneal


text:
Technical reviewer needed

Hello,
I dont know if this is the right place to ask this but is there anyone here up to reviewing a technical resource on FastAPI?
Thanks

There's a jobs channel in the discord server, GitHub issues aren't the best place for job offers

Thanks for the help here @Mause ! 👏  🙇
Thanks for coming back and closing the issue @aitoehigie  👍

Sorry for the long delay! 🙈  I wanted to personally address each issue/PR and they piled up through time, but now I'm checking each one in order.

authors: Mause aitoehigie tiangolo


text:
🌐 Add Japanese translation for docs/ja/docs/deployment/server-workers.md

based on https://github.com/tiangolo/fastapi/pull/3974
Japanese translation of Server Workers - Gunicorn with Uvicorn

📝 Docs preview for commit bec7f4bc88f5fa68b0b56c38f8ac1b33433dee1b at: https://d69a16b1.fastapitiangolo.pages.dev

Here is the page I added to this PR

authors: tamtam-fitness tiangolo


text:
Fix typos

Just fix a couple of typos in the docs.

Awesome, thanks!

authors: kkinder tiangolo


text:
反射vivo系统方法异常

vivo x23，funtouchOS10，android 9
Class<?> shortcutList = Class.forName("com.bbk.launcher2.installshortcut.PurviewActivity");
异常报类找不到，
我用adb查看activity，是有这个类的
adb shell "dumpsys window | grep mCurrentFocus"
mCurrentFocus=Window{b3629ee u0 com.bbk.launcher2/com.bbk.launcher2.installshortcut.PurviewActivity}

这个类是launcher的，当然拿不到

哦，这块我不了解
我之前遇到华为的反射找不到类，加上FreeReflection框架就能拿到类了
Class<?> PermissionManager = Class.forName("com.huawei.hsm.permission.PermissionManager");
所以，习惯性的以为，所有的类，都可以反射
我的目的是为了获取到vivo手机 创建桌面快捷方式的权限（是允许或是禁止）
github上好些这种方式获取vivo的桌面权限是否开启
public static int checkOnVIVO(@NonNull Context context) {
ContentResolver contentResolver = context.getContentResolver();
if (contentResolver == null) {
return PERMISSION_UNKNOWN;
}
Cursor query = null;
try {
Uri parse = Uri.parse("content://com.bbk.launcher2.settings/favorites");
query = contentResolver.query(parse, null, null, null, null);
if (query == null) {
return PERMISSION_UNKNOWN;
}
while (query.moveToNext()) {
String titleByQueryLauncher = query.getString(query.getColumnIndexOrThrow("title"));
if (!TextUtils.isEmpty(titleByQueryLauncher)) {
int value = query.getInt(query.getColumnIndexOrThrow("shortcutPermission"));
if (value == 1 || value == 17) {
return PERMISSION_DENIED;
} else if (value == 16) {
return PERMISSION_GRANTED;
} else if (value == 18) {
return PERMISSION_ASK;
}
}
}
} catch (Exception e) {
e.printStackTrace();
} finally {
if (query != null) {
query.close();
}
}
return PERMISSION_UNKNOWN;
}
但是报错
java.lang.SecurityException: Permission Denial:
opening provider com.bbk.launcher2.data.LauncherProvider from ProcessRecord{)
requires com.bbk.launcher2.permission.READ_SETTINGS or com.bbk.launcher2.permission.WRITE_SETTINGS
添加权限或则用反射都走不通，
（参考这个博客，https://hjw45611.github.io/blog/2021/06/22/Vivo%E5%88%9B%E5%BB%BA%E6%A1%8C%E9%9D%A2%E5%BF%AB%E6%8D%B7%E6%96%B9%E5%BC%8F/
不知道他怎么拿到权限的，就想着反射系统类试试）
关于获取vivo桌面快捷方式权限，大佬有什么建议吗？

repo: tiann/FreeReflection


text:
Support multi-classes or multi-objects segmentation?

I read this code,but I found it only support one object.

Greetings! As the two tasks, camouflaged object detection and shadow detection, are single-class segmentation tasks, our code presently only supports single-class segmentation. However, we remain open to exploring additional possibilities in the future.

authors: tianrun-chen wuyuanmm

repo: tianrun-chen/SAM-Adapter-PyTorch


text:
Token登录失败（ubuntu+docker+正确的token+机器能上网）

在ubuntu上以docker-compose模式运行，我确认token的正确性，以及ubuntu能正常上网（我内网的另一台电脑，能够正常链接网络和访问网页云盘）
aliyunpan-sync | 登录失败
aliyunpan-sync |   名称                   值               建议值               描述
aliyunpan-sync |   cache_size             0B               1KB ~ 256KB          下载缓存, 如果硬盘占用高或下载速度慢, 请尝试调大此值
aliyunpan-sync |   max_download_parallel  0                1 ~ 20               最大下载并发量，即同时下载文件最大数量
aliyunpan-sync |   max_upload_parallel    0                1 ~ 20               最大上传并发量，即同时上传文件最大数量
aliyunpan-sync |   max_download_rate      不限制                                限制单个文件最大下载速度, 0代表不限制
aliyunpan-sync |   max_upload_rate        不限制                                限制单个文件最大上传速度, 0代表不限制
aliyunpan-sync |   transfer_url_type      1                1-默认，2-阿里云ECS  上传下载URL类别。除非在阿里云ECS（暂只支持经典网络）服务器中使用，不然请设置1
aliyunpan-sync |   savedir                /root/Downloads                       下载文件的储存目录
aliyunpan-sync |   proxy                                                        设置代理, 支持 http/socks5 代理，例如：http://127.0.0.1:8888
aliyunpan-sync |   local_addrs                                                  设置本地网卡地址, 多个地址用逗号隔开，例如：127.0.0.1,192.168.100.126
aliyunpan-sync |
aliyunpan-sync | 保存配置成功!
aliyunpan-sync |
aliyunpan-sync | 未登录账号
aliyunpan-sync | using existed sync_drive_config.json file
aliyunpan-sync | 未登录账号
aliyunpan-sync | login use refresh token: b2f2*******5612
aliyunpan-sync | Token登录失败： Post "https://auth.aliyundrive.com/v2/account/token": context deadline exceeded (Client.Timeout exceeded while awaiting headers)
aliyunpan-sync | 登录失败
aliyunpan-sync |   名称                   值               建议值               描述
aliyunpan-sync |   cache_size             0B               1KB ~ 256KB          下载缓存, 如果硬盘占用高或下载速度慢, 请尝试调大此值
aliyunpan-sync |   max_download_parallel  0                1 ~ 20               最大下载并发量，即同时下载文件最大数量
aliyunpan-sync |   max_upload_parallel    0                1 ~ 20               最大上传并发量，即同时上传文件最大数量
aliyunpan-sync |   max_download_rate      不限制                                限制单个文件最大下载速度, 0代表不限制
aliyunpan-sync |   max_upload_rate        不限制                                限制单个文件最大上传速度, 0代表不限制
aliyunpan-sync |   transfer_url_type      1                1-默认，2-阿里云ECS  上传下载URL类别。除非在阿里云ECS（暂只支持经典网络）服务器中使用，不然请设置1
aliyunpan-sync |   savedir                /root/Downloads                       下载文件的储存目录
aliyunpan-sync |   proxy                                                        设置代理, 支持 http/socks5 代理，例如：http://127.0.0.1:8888
aliyunpan-sync |   local_addrs                                                  设置本地网卡地址, 多个地址用逗号隔开，例如：127.0.0.1,192.168.100.126
aliyunpan-sync |
aliyunpan-sync | 保存配置成功!
aliyunpan-sync |
aliyunpan-sync | 未登录账号

使用docker-compose 运行的备份模式，下面是配置文件
version: '3'
services:
  sync:
    image: tickstep/aliyunpan-sync:v0.1.8
    container_name: aliyunpan-sync
    restart: always
    volumes:
      # 指定本地备份目录绝对路径：/tickstep/Documents/设计文档
      - /usbdata/test:/home/app/data:rw
      # （可选）可以指定JS插件sync_handler.js用于过滤文件，详见下面的插件说明
      #- ./plugin/js/sync_handler.js:/home/app/config/plugin/js/sync_handler.js
      # （推荐）挂载sync_drive同步数据库到本地，这样即使容器销毁，同步数据库还可以用于以后使用
      - /opt/docker/aliyunpan_sync_drive:/home/app/config/sync_drive
    environment:
      - TZ=Asia/Shanghai
      # refresh token
      - ALIYUNPAN_REFRESH_TOKEN=b2f2**********61a5612
      # 上传下载链接类型：1-默认 2-阿里ECS环境
      - ALIYUNPAN_TRANSFER_URL_TYPE=1
      # 下载文件并发数
      - ALIYUNPAN_DOWNLOAD_PARALLEL=2
      # 上传文件并发数
      - ALIYUNPAN_UPLOAD_PARALLEL=2
      # 下载数据块大小，单位为KB，默认为10240KB，建议范围1024KB~10240KB
      - ALIYUNPAN_DOWNLOAD_BLOCK_SIZE=1024
      # 上传数据块大小，单位为KB，默认为10240KB，建议范围1024KB~10240KB
      - ALIYUNPAN_UPLOAD_BLOCK_SIZE=10240
      # 指定网盘文件夹作为备份目录，不要指定根目录
      - ALIYUNPAN_PAN_DIR=/备份盘/
      # 备份模式：upload(备份本地文件到云盘), download(备份云盘文件到本地), sync(双向同步备份)
      - ALIYUNPAN_SYNC_MODE=upload

奇怪的是，使用该命令可以登陆成功。
docker run -d --name=ali -v "/usbdata/test:/home/app/data" -e TZ="Asia/Shanghai" -e ALIYUNPAN_REFRESH_TOKEN="b2f2*******5612" -e ALIYUNPAN_PAN_DIR="/备份盘/" -e ALIYUNPAN_SYNC_MODE="upload" tickstep/aliyunpan-sync:v0.1.8

关闭

大佬为啥我网页上只有xml文件啊  怎么把文件下下来啊

repo: tickstep/aliyunpan


text:
Generate entire catalogue client

This PR tweaks openapi-generator to generate a Catalogue class that serves the generated API classes and uses retrofit and our own authentication.
The generated client is fully functional.
You can try the generation yourself by running ./catalogue/bin/generate.sh
This is only a small step away from dynamically generating TIDAL-compatible Android clients for any submitted OpenApi-compatible spec file.

You can try the generation yourself by running ./catalogue/bin/generate.sh

I think we should run this as part of the build process prior to compiling, rather than relying on people/CI manually calling a script when appropriate.

You can try the generation yourself by running ./catalogue/bin/generate.sh

I think we should run this as part of the build process prior to compiling, rather than relying on people/CI manually calling a script when appropriate.

Of course, but we're at the beginning of this process. There will be a number of intermediate steps that work but not like desired in a final product.

authors: michpohl stoyicker

repo: tidal-music/tidal-sdk-android


text:
A new app that displays the bus arrival times at specified DC-area …

…(WMATA) bus stop(s).

Thanks for your inputs.  Let me make sure I understand your requests/suggestions before getting started.

Also wanted to ask if you could make the app provide a default graphic for the case when no configuration is provided?

So for this, would simply making the API call with a “hard-coded” default StopID and rendering the results back to the user do what you are requesting?

...the cache key probably also needs to include the StopID to make sure later calls to GetTime1 aren't just returning the cached data from previous calls with (potentially) different StopID.

Yeah good point.  I incorrectly attempted this using the two caches (GetTimes1 and GetTimes2), but was careless not just adding the StopID.  Good catch.

...so if the WMATA Key is optional it could be good to mention that in the field name.

Certainly.  I was using Pixlet which did show the description field so I was unaware iPhone users would not see it.  Thanks for heads up.

...since there's an encrypted key already available, perhaps this config field isn't needed at all?

I thought about this since I did have some trouble getting the key into/out of config.  Ultimately, however, I liked the option of being able to debug the app from pixlet which required it to be in config (or hard-coded in the app).  You’re correct though, it makes sense to leave it out and hardcode it in when/if I need to test app locally.
While I have you, let me ask you a question since I struggled mightily getting the original PR to work correctly (thank god someone mentioned using Git Desktop).  Once I make these changes, do I simply make a new PR from Git Desktop?
Thanks again for the good inputs,
Steven

Steven Pressnall
Senior Signal Processing Engineer
Resonant Sciences
@.***
703.971.6504

Also wanted to ask if you could make the app provide a default graphic for the case when no configuration is provided?

So for this, would simply making the API call with a “hard-coded” default StopID and rendering the results back to the user do what you are requesting?

Either that, or hard coding some sample data to remove the need for calling the API.

...since there's an encrypted key already available, perhaps this config field isn't needed at all?

I thought about this since I did have some trouble getting the key into/out of config.  Ultimately, however, I liked the option of being able to debug the app from pixlet which required it to be in config (or hard-coded in the app).  You’re correct though, it makes sense to leave it out and hardcode it in when/if I need to test app locally.

Got it. Another option is to remove it from get_schema() but still check for it in config and then pass it in via a query parameter. E.g., when using pixlet serve, you'll see something like ?foo=bar in the URL of your browser. If you manually change that to say ?foo=bar&baz=bat, you should see bat in config.get("baz"), even though the baz field is not defined in get_schema().

While I have you, let me ask you a question since I struggled mightily getting the original PR to work correctly (thank god someone mentioned using Git Desktop).  Once I make these changes, do I simply make a new PR from Git Desktop?

Afraid I've no experience of Git Desktop. In general, you can just add and push commits to an existing PR, and it looks like you got that working! =)

authors: JetgirlDC matslina

repo: tidbyt/community


text:
feat: improve autonomous_emergency_braking

Description
improve autonomous_emergency_braking

apply prediction_time_interval to predicted_path
disable debug pointcloud publishing in aeb

Related links

Tests performed
Psim

Notes for reviewers

Interface changes
none

Effects on system behavior
As the avove description

Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.

[ ] I've confirmed the contribution guidelines.
[ ] The PR follows the pull request guidelines.

In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.

[ ] The PR follows the pull request guidelines.
[ ] The PR has been properly tested.
[ ] The PR has been reviewed by the code owners.

Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.

[ ] There are no open discussions or they are tracked via tickets.
[ ] The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

After checking with the actual vehicle, I will also creae a pull request on awf/main


text:
recreate ES/kibana certs when DNS names change

Description

For PR author

[ ] Tests for change.
[ ] If changing pkg/apis/, run make gen-files
[ ] If changing versions, run make gen-versions

For PR reviewers
A note for code reviewers - all pull requests must have the following:

[ ] Milestone set according to targeted release.
[ ] Appropriate labels:

kind/bug if this is a bugfix.
kind/enhancement if this is a a new feature.
enterprise if this PR applies to Calico Enterprise only.

After discussing with @doublek , I'll add a follow-up PR tomorrow

After discussing with @doublek , I'll add a follow-up PR tomorrow

repo: tigera/operator