text:
Add CPython 3.4.5 and 3.5.2

http://blog.python.org/2016/06/python-352-and-python-345-are-now.html.

How we can backport this patch ?
bug: https://bugs.python.org/issue26664
patch: https://hg.python.org/cpython/rev/8d7bde14d7a4

pyenv install (and python-build) supports -p which let python-build to read patch from standard input. cat foo.patch | pyenv install -v 3.4.5 allows users to apply custom patch when building.
https://github.com/yyuu/pyenv/blob/0e298b691d8490064cc069a56be91597afdb590b/plugins/python-build/bin/pyenv-install#L18
https://github.com/yyuu/pyenv/blob/0e298b691d8490064cc069a56be91597afdb590b/plugins/python-build/bin/python-build#L8
I can bundle the patch as a default patch if there's working configuration.

Thank @yyuu. It's works really well.
curl https://hg.python.org/cpython/raw-rev/8d7bde14d7a4 | pyenv install -p 3.5.2

I can bundle the patch as a default patch if there's working configuration.

I'll love it =D

@robsonpeixoto could you send me a PR if possible? Just putting the patch file under $(pyenv root)/plugins/python-build/share/python-build/patches/Python-5.2 should let python-build to apply the patch before building.

I'll

https://github.com/yyuu/pyenv/pull/725

authors: robsonpeixoto yyuu zmwangx


text:
Remove skip_interested check

Controller class should not do any "interested" checking. That should be already handled in the peer connection in the lookup.

https://github.com/yzernik/squeaknode/pull/893

source: gharchive/issue

repo: yzernik/squeaknode

license: MIT

license_type: permissive

license_source: github-api


text:
Javascript Injection Security flaw

Go anywhere in administration forms and add  to any input.
Confirmed on demo and local. Long live eval. :)
Really, this is a serious security flaw in case of viewing info added from frontend.
https://github.com/z-song/laravel-admin/search?utf8=✓&q=globalEval

Thank you for point out the serious  problem，I fix it by convert all applicable characters in grid to html entities .

The fix will not solve the core problem. This means the eval function. I strongly recommend removing it or use alternatives. It can cause very serious problems. This could lead to session hijacking, keyloggers and so on.
In the case i'll use my custom view inside your controller and show db data, I know laravel will escape values, but your module won't and will execute them.  Your package already has 822 downloads (at the time of this writing), this means 822 extremely vulnerable projects.

The eval function in pjax.js is use to execute javascript code in script tag respond by pjax request, and it's same as refresh the page manually.
I think the way to avoid js injection is validate or filter data added from frontend.

authors: akizor z-song

repo: z-song/laravel-admin

license: mit

license_source: bigquery


text:
$grid->actions(function (Actions $actions) 配置继承问题

Laravel Version: 6
PHP Version:
Laravel-admin: 1.7.9

Description:
我在bootstrap.php中已经初始化Grid
Grid::init(function (Grid $grid) {
    $grid->actions(function (Actions $actions) {
        $actions->disableDelete();
        $actions->disableEdit();
        $actions->disableView();
         //如果是软删除就禁用删除和查看动作，添加恢复和彻底删除动作
        if (\request('_scope_') === 'trashed') {
            $actions->add(new RestoreAction);
            $actions->add(new ForceDeleteAction);
       }
   }
}

如果我在BaseAdminController中继续对Grid进行操作
class BaseAdminController extends AdminController
{
    public function index(Content $content)
    {
        $content->header($this->title);
        $content->description($this->description['index']);
        $content->breadcrumb(
            ['text' => $this->ParentTitle],
            ['text' => $this->title]
        );
        $grid = $this->grid();
        /**
        *  如果在这里对grid actions 进行进一步修改，则在Grid::init中初始化的配置项将全部失效
        *  我想对一般grid action 做模版配置，如果有特殊需求可以在原有配置上进行修改
        *  我该怎么办呢
        */
        $grid->actions(function (Actions $actions){
            if ($canEdit){
               $actions->disableEdit(false);
            }
        }
        $content->body($grid);
        return $content;
    }
}

Steps To Reproduce:

做不到，actions方法接收的闭包参数是作为独立的参数传入的，不能继承init方法中传入的actions闭包参数

authors: loveyuxiao z-song


text:
Add ability to use custom LinkModel when user interactively adds links.

Also fixes minor issue when calculating target port position.

LGTM! Thank you for the PR!

source: gharchive/pull-request

authors: joezearing zHaytam


text:
Changes: Minor tweaks

adjusted jobs parameters which are shouldn't have been enforced (schedule)
driver_node_type_id is now optional

Codecov Report

Merging #5 (af60277) into main (680671e) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main       #5   +/-   ##
=======================================
  Coverage   15.24%   15.24%
=======================================
  Files          17       17
  Lines        1824     1824
=======================================
  Hits          278      278
  Misses       1546     1546

Impacted Files
Coverage Δ

R/data-structures.R
100.00% <ø> (ø)

R/jobs.R
0.00% <ø> (ø)

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

authors: codecov-commenter zacdav-db

repo: zacdav-db/brickster


text:
CRC failed always

I've tried 2 different models, many CSC. Always same problem. It seems it downloads very few bytes and fails.
Tried both android and windows version.
Any suggestions?
Thanks in advance

Also have  the same problem

Same problem.

The application is reporting wrong error. It's a HTTP 403 Forbidden. Seems that the FUS client cannot authenticate to Samsung servers. You can seet response in tk.zwander.common.tools.FusClientKt#doDownloadFile.

Same as #107

Fixed.

authors: Groonir Tostis evdcush nemenos zacharee

repo: zacharee/SamloaderKotlin


text:
Update example.py

Transaction is successful if finish with aft_clean_transaction_poll

Transaction is successful if finish with

At this point, why not call aft_clean_transaction_poll directly inside aft_in ?

Do not use aft_clean_transaction_poll in directly inside aft_in because the machine response time is different. A proper use of aft_clean_transaction_poll is to loop it. If it raises an error or returns 'Transfer pending (not complete)' you continue to execute until 'Full transfer successful'. Otherwise, you break the cycle and make the request invalid.

Thank you so much for the clarification !

It works in 40-50 casinos sas.py is my mod.
my_out = None
for i in range(3):
if my_out == None:
if self.slee_on_down is True:
time.sleep(self.sas_sleep)
try:
self.clear_meter()
my_out = self.meter['out']
my_out = all_meter = self.sas.send_meters_10_15(True)
except Exception as e:
my_out = None
self.log.error(e, exc_info=True)
else:
break
self.log.error('get in client_bonus')
if my_out != None:
if bonus_waith_for_in is True and my_out - out >= self.cust_hold_mony:
time.sleep(4)
self.log.warning('NO CREDIT FOR BONUS')
return 'BREAK'
if self.slee_on_down is True:
time.sleep(self.sas_sleep)
if waith_to_play > time.time():
try:
if kwargs['restricted'] is False:
if self.check_for_game is True:
data = self.sas.AFT_won(mony=mony, amount=1)
else:
data = self.sas.AFT_won(mony=mony, amount=1, games=1)
else:
data = self.sas.AFT_in(mony=mony, amount=2)
except Exception as e:
data = None
self.log.warning(e, exc_info=True)
else:
return False
if data == 'NoGame':
time.sleep(4)
self.log.warning('NO GAME SELECTED: %s', data)
return False
data = None
while request_time > time.time():
if data == None or data is False:
if self.slee_on_down is True:
time.sleep(self.sas_sleep)
try:
data = self.clean_transaction_poll()
except sas.BadCRC as e:
data = None
self.log.info(e, exc_info=True)
except sas.BadTransactionID as e:
data = None
self.log.error(e, exc_info=True)
except Exception as e:
data = None
self.log.error(e, exc_info=True)
else:
if data['Transfer status'] == 'Full transfer successful':
self.old_in = self.meter['in']
self.log.info('client_bonus: sas response %s', data)
if kwargs['block_out']:
self.no_out_befor(**kwargs['block_out'])
self.bonus_old_in = self.meter['in']
if kwargs['hold_bonus']:
self.player_hold(**kwargs['hold_bonus'])
return True
elif data['Transfer status'] == 'Transfer pending (not complete)':
if self.emg_type == 7 or self.emg_type == 8:
self.bonus_clear_transaction_pool = True
self.old_in = self.meter['in']
self.log.info('client_bonus: sas response %s', data)
if kwargs['block_out']:
self.no_out_befor(**kwargs['block_out'])
if kwargs['hold_bonus']:
self.player_hold(**kwargs['hold_bonus'])
return True
data = None
elif data['Transfer status'] == 'Gaming machine unable to perform
transfers at this time (door open, tilt, disabled, cashout in progress,
etc.)':
if self.mem_server.get('MAKE_IN_OUT'):
self.mem_server.set('MAKE_IN_OUT', False)
self.sas.remote_handpay_reset()
return False
else:
self.log.error('client_bonus: sas response %s', data)
return False
self.log.warning('client_bonus time out: sas response %s', data)
if self.clean_aft_tranzaction is True:
return False
На нд, 28.01.2024 г. в 12:08 Antonio @.***> написа:

Thank you so much for the clarification !
—
Reply to this email directly, view it on GitHub
https://github.com/zacharytomlinson/saspy/pull/6#issuecomment-1913542038,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABZYRJN5MTZNBPSMZID4CGTYQYPS5AVCNFSM6AAAAABCMTUOIOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMJTGU2DEMBTHA
.
You are receiving this because you authored the thread.Message ID:
@.***>

My system is very large and complex. I have SMIB with rfid client module
cashless and 4" touch screen. Jackpot server, central information server,
cashier program, croupier and overall management of all cash flow in
casino. I also have my own SAS protocol, but the modified one works better
than mine.
На нд, 28.01.2024 г. в 15:54 Григор @.***> написа:

It works in 40-50 casinos sas.py is my mod.
my_out = None
for i in range(3):
if my_out == None:
if self.slee_on_down is True:
time.sleep(self.sas_sleep)
try:
self.clear_meter()
my_out = self.meter['out']
my_out = all_meter = self.sas.send_meters_10_15(True)
except Exception as e:
my_out = None
self.log.error(e, exc_info=True)
else:
break
self.log.error('get in client_bonus')
if my_out != None:
if bonus_waith_for_in is True and my_out - out >= self.cust_hold_mony:
time.sleep(4)
self.log.warning('NO CREDIT FOR BONUS')
return 'BREAK'
if self.slee_on_down is True:
time.sleep(self.sas_sleep)
if waith_to_play > time.time():
try:
if kwargs['restricted'] is False:
if self.check_for_game is True:
data = self.sas.AFT_won(mony=mony, amount=1)
else:
data = self.sas.AFT_won(mony=mony, amount=1, games=1)
else:
data = self.sas.AFT_in(mony=mony, amount=2)
except Exception as e:
data = None
self.log.warning(e, exc_info=True)
else:
return False
if data == 'NoGame':
time.sleep(4)
self.log.warning('NO GAME SELECTED: %s', data)
return False
data = None
while request_time > time.time():
if data == None or data is False:
if self.slee_on_down is True:
time.sleep(self.sas_sleep)
try:
data = self.clean_transaction_poll()
except sas.BadCRC as e:
data = None
self.log.info(e, exc_info=True)
except sas.BadTransactionID as e:
data = None
self.log.error(e, exc_info=True)
except Exception as e:
data = None
self.log.error(e, exc_info=True)
else:
if data['Transfer status'] == 'Full transfer successful':
self.old_in = self.meter['in']
self.log.info('client_bonus: sas response %s', data)
if kwargs['block_out']:
self.no_out_befor(**kwargs['block_out'])
self.bonus_old_in = self.meter['in']
if kwargs['hold_bonus']:
self.player_hold(**kwargs['hold_bonus'])
return True
elif data['Transfer status'] == 'Transfer pending (not complete)':
if self.emg_type == 7 or self.emg_type == 8:
self.bonus_clear_transaction_pool = True
self.old_in = self.meter['in']
self.log.info('client_bonus: sas response %s', data)
if kwargs['block_out']:
self.no_out_befor(**kwargs['block_out'])
if kwargs['hold_bonus']:
self.player_hold(**kwargs['hold_bonus'])
return True
data = None
elif data['Transfer status'] == 'Gaming machine unable to perform
transfers at this time (door open, tilt, disabled, cashout in progress,
etc.)':
if self.mem_server.get('MAKE_IN_OUT'):
self.mem_server.set('MAKE_IN_OUT', False)
self.sas.remote_handpay_reset()
return False
else:
self.log.error('client_bonus: sas response %s', data)
return False
self.log.warning('client_bonus time out: sas response %s', data)
if self.clean_aft_tranzaction is True:
return False
На нд, 28.01.2024 г. в 12:08 Antonio @.***> написа:

Thank you so much for the clarification !
—
Reply to this email directly, view it on GitHub
https://github.com/zacharytomlinson/saspy/pull/6#issuecomment-1913542038,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABZYRJN5MTZNBPSMZID4CGTYQYPS5AVCNFSM6AAAAABCMTUOIOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMJTGU2DEMBTHA
.
You are receiving this because you authored the thread.Message ID:
@.***>

authors: dedalgr well-it-wasnt-me

repo: zacharytomlinson/saspy


text:
Check status of links

Use https://github.com/spatie/http-status-check to check status of links. Have a status indicator on the project manager page with colored dots: green for 200, orange for 300, red for 400/500. Output error message for all but 200 range. Run in background and update via ajax. Have either grey indicator or spinner in place of status indicator if process hasn't completed yet.

Done, just need to add tests.

Extract curl stuff out to separate class and unit test it
Run acceptance tests for 200, 404, and maybe 500 links and check that the classes are being set

v0.9.08

repo: zachleigh/larafolio


text:
Default loading state for when extension is doing something async (returning list)

Description of the new feature / enhancement
UI needed to show users that something is loading. This should be abstracted away from the extension developers... all they should need to do is do some async thing and then return a list (or not an async thing and return a list)... once that list is returned, the loading status goes away
Scenario when this would be used?
This will be used by default for all loading.
Supporting information
No response

You know, I have a prototype for this in #187

authors: joadoumie zadjii-msft

repo: zadjii-msft/PowerToys


text:
Collapse other then current expanded?

How to collapse all and collapse other then expanded current parent item?

Please wait a moment, I'll add the next version

Actually, you don't have to cut bignerdranch/expandable-recycler-view lib.

@s13524801  it support three and more?

@chiragdigi  hi,there, you can check my implemented lib, welcome  pull request ,issues ,thanks!
https://github.com/HuaJianJiang/ExpandableRecyclerView

authors: HuaJianJiang chiragdigi s13524801 zaihuishou

repo: zaihuishou/ExpandableRecyclerview


text:
Typos

One-line summary
Fixing typo

:+1:

:+1:

👍

authors: Dmitry-Erokhin dstockhammer

repo: zalando-incubator/clin


text:
Fallback to simple String for invalid JSON body

Fixes #38

As this is a kind-of breaking bug in this library, should we merge this? We could open an issue to implement the SPI later.

As this is a kind-of breaking bug in this library, should we merge this? We could open an issue to implement the SPI later.

Agreed. I created #41

authors: lukasniemeier-zalando whiskeysierra

repo: zalando/logbook


text:
mr_note_test: change MR ID used for testing discussion

This patch choose another MR to be used as text dump for testing, since
the last one filled up.
Signed-off-by: Bruno Meneguele bmeneg@redhat.com

It seems today is the day for changing things about live MRs in our gitlab test repos :).
I'm going to merge this PR as soon as the test passes so it unblocks other PRs testing.

repo: zaquestion/lab


text:
Local browser creds ?

Can this be used to dump local browser credentials and cookies? In post exploitation phase

https://github.com/zblurx/dploot#browser

What I meant with local was, local windows domain not domain joined windows machine.

Yes it can, have you encountered errors with the tool for not domain joigned windows machine loot ?

Yes it can, have you encountered errors with the tool for not domain joigned windows machine browser triage?

TBH I was wondering how I could execute the tool in not domain-joined windows since there will be no Kerberos to authenticate. And python would not be installed by default.
Suppose python was installed in windows then the syntax probably could be like this?
dploot masterkeys -d Prisoner\DESKTOP-8JAAAPK-u Prisoner -p 'Password!123' 127.0.0.1

repo: zblurx/dploot


text:
FR: Allow GetBlockRange to stream blocks in descending order

What is your feature request?
Right now, the GetBlockRange method streams blocks from lowest height to tallest height. For BlazeSync, it might be useful to have the blocks streamed backwards - i.e., tallest height to lowest height. Maybe have an optional parameter that specifies the direction in which to stream blocks
How would this feature help you?
Streaming blocks backwards allows wallets to detect incoming spends quicker, allowing users access to their most recent transactions first.
cc: @LarryRuane , @braddmiller

This should be easy, just generalize GetBlockRange() to run the loop index either up or down. Rather than adding an optional parameter, it may make sense to just allow start=20, end=10 to mean return 20, 19, ... 10. Currently, those arguments would return an empty list. This approach is almost backward-compatible -- close enough, I think.

This is a great idea. We should just do this.

This looks like a really great solution, adding to our sprint

@mdr0id, can we get PR #355 up in our LWD instance for testing?

authors: LarryRuane adityapk00 braddmiller

repo: zcash/lightwalletd


text:
No need for deoplete settings

We shouldn't be explaining deoplete settings. Shougo has fantastic
documentation. I also don't think anyone needs to modify any of those settings anymore.

@nhooyr yea.
It is for users who do not understand the deoplete.nvim
but deoplete.nvim became famous, so it would be no longer required.
LGTM.

todo: vim syntax doc.txt

authors: nhooyr zchee

repo: zchee/deoplete-go


text:
questions about vqa

Hi, what the image_size used for VQAv2 in Table 2 and Table 3 in your paper?

Hi, as in the paper, the image size is 224×224 or 384×384 depending on the adopted vision transformers. For example, CLIP-224/32 and CLIP-224/16 used an image size of 224x224, Swin32_base384 used 384x384


text:
Security scan and fix vulnerabilities if any

CVE-2022-4065

Basic acceptance and automation smoke performed, fixed

authors: akamarouski okamara

repo: zebrunner/carina-commons


text:
jenkins/variables.env contain changes and should be regenerated during upgrade

ZEBRUNNER_VERSION env variable is used to determine actual pipeline version. It is forcibly specified during restart.
During migration from 1.0 and 1.1 to 1.2 we didn't regenerate this script and as result 1.1 default pipeline version always specified.
Let's fix it in 1.3 release.
P.S. the re is no sense to fix asap because 1.1 and 1.2 pipeline releases are absolutely identical

done: https://github.com/zebrunner/zebrunner/commit/ead37cef0e5ed6b3c42a8f3562fedfe7fb40fd37
test scenario (upgrade use-case):

setup zebrunner from master (1.2v)
do basic acceptance
-> take a look to ./jenkins/variables.env - no ZEBRUNNER_PIPELINE variable declared inside
switch to develop and pull latest changes recursively
run ./zebrunner.sh upgrade steps and restart everything
-> review ./jenkins/variables.env - ZEBRUNNER_PIPELINE=1.3 should be declared
Inspect after jenkins restart that global env var ZEBRUNNER_PIPELINE=1.3
run again api/web tests to make sure all good with execution

Ticket is blocked by https://github.com/zebrunner/zebrunner/issues/361

done, test one time

authors: okamara vdelendik

repo: zebrunner/zebrunner


text:
JS/TS always use absolute import paths

Check for existing issues

[X] Completed

Describe the feature
For JavaScript/TypeScript files, Zed currently automatically adds an import when typing a variable name and pressing tab - which is awesome.
It also seems to respect tsconfig and use absolute import paths - but not always. If the module to be imported is at the same level, or a level above, relative paths are used.
Is there a way to force absolute paths to always be used? If not, is this on your roadmap?
Thanks!
If applicable, add mockups / screenshots to help present your vision of the feature
No response

I'm not sure this is something Zed can address. Zed delegates most language-specific features to the specific language server. For JavaScript/TypeScript, it's typescript-language-server. Perhaps you could tweak it to your liking by adjusting importModuleSpecifierPreference. 🙂

@posthardcode did you find a solution to your problem?

@hovsater I did face the same problem, which in other IDEs e.g. VSCode setting the property you mentioned to relative does the job. However, on Zed, having
 "lsp": {
    "typescript-language-server": {
      "initialization_options": {
        "preferences": {
          "importModuleSpecifier": "relative"
        }
      }
    }
  }

on my settings.json apparently has no effect. Am I missing something here?

@reloadedhead I'm pretty sure the key must be importModuleSpecifierPreference to work. At least judging by the docs.

@hovsater Indeed, my bad. Caffeine levels were low 😅 can confirm it works like a charm! Extremely happy with Zed :)

authors: hovsater posthardcode reloadedhead

repo: zed-industries/community


text:
Custom key bindings in menubar

Check for existing issues

[X] Completed

Describe the bug / provide steps to reproduce it
I would like to set the same key bindings as in VSCode for the following actions:

Expand selection
Shrink selection
Move line up
Move line down

In VSCode there are the following settings:

First problem is that the following key bindings are missing in ZED, so it is not possible to create a custom key binding for them.

Expand selection
Shrink selection

Second problem is that if I set the custom key binding for "Move line up" and "Move line down" actions, the custom setting is not correctly presented in GUI.
[
  {
    "context": "Editor",
    "bindings": {
      "alt-up": "editor::MoveLineUp",
      "alt-down": "editor::MoveLineDown"
    }
  }
]

Last problem is that these settings should be set by default the same as in VSCode due to "base_keymap": "VSCode".
Environment
Zed: v0.97.1 (preview)
OS: macOS 13.5.0
Memory: 16 GiB
Architecture: x86_64
If applicable, add mockups / screenshots to help explain present your vision of the feature
No response
If applicable, attach your ~/Library/Logs/Zed/Zed.log file to this issue.
If you only need the most recent lines, you can run the zed: open log command palette action to see the last 1000.
No response

@jezikk, does select {larger,smaller} syntax node do what you're looking for with {Expand,Shrink} Selection?

No expand / shrink selection doesn't work, because I rebind their key bindings:
[
  {
    "context": "Editor",
    "bindings": {
      "alt-up": "editor::MoveLineUp",
      "alt-down": "editor::MoveLineDown"
    }
  }
]

There is no bindings for expand / shrink selection. I think there should be bindings for all actions which can be triggered by hotkeys.

authors: JosephTLyons jezikk


text:
Hover on terminal tab should show full running command

Check for existing issues

[X] Completed

Describe the feature
Hover on terminal tab should show full running command, instead of just minoring what's shown on tab.

If applicable, add mockups / screenshots to help present your vision of the feature
No response

This is fixed in v0.119.4 preview.

authors: JosephTLyons liebkne


text:
Add .go/ cache directory to gitignore

Signed-off-by: Avi Deitcher avi@deitcher.net
It is just a cache directory, so should be in gitignore.

LGTM

authors: deitch rvs

repo: zededa/eve


text:
Looped Slides don't call Angular functions

I am using the Swiper to create a stereotypical Hero Carousel. Headline, subtitle and a CTA. I added an angular function to the CTA to record analytics for this action. It passes the Headline as a string argument whenever it is clicked. It works fine except for on the duplicated slides. How can I make a duplicated slide have the same functionality as its Angular one?

I have noticed the same issue today.

I have the same problem.
I try this when loop start ( it is a parallel deal while there is no definitive solution):
component.ts:
@ViewChild("swiperRef") public swiper?: SwiperComponent;

...
onChangeIndex(event: number) {
    const realIndex = this.swiper.directiveRef.getIndex(true);
    if (realIndex == 0)
      this.swiper.directiveRef.setIndex(0);
}

component.html
<swiper *ngIf="showSwipper()" [config]="swiperOptions" (indexChange)="onChangeIndex($event)" #swiperRef>

    <div class="swiper-slide" *ngFor="let relatorio of grupoApresentacao.powerBIRelatorioApresentacao; let i = index;"
      swiperSlide>
      <app-relatorios-powerbi [showButtons]="false" [groupId]="relatorio.powerBIRelatorio.workspacePBIID"
        [reportId]="relatorio.powerBIRelatorio.relatorioPBIID" [grupoApresentacaoId]="relatorio.grupoApresentacaoId">
      </app-relatorios-powerbi>
    </div>

</swiper>

authors: bflopez cm-cm-cm-cm samuksilv

repo: zefoy/ngx-swiper-wrapper


text:
Update sizes-hpc.md

Updating the memory bandwidth, CPU model and L3 cache size

@zehranaz  I have made my updates to this doc

repo: zehranaz/azure-docs


text:
Minor fix on string #51

This pull request just goes for this readme.md file, so, there is no break on code.

Thank you. Merged.

authors: kant ppot

repo: zeit/hyper


text:
Pass state between pages

I'm having trouble determining how I would share state between page components. Since they are top-level components, I don't believe there's a way to do a Flux or Redux style architecture where data comes in through a top-level component and gets passed to children via props. Am I missing something?
For example, I have a Profile "page" component where a user can log-in. I am setting userId state in that component, but I want that state available to other page components. Is this possible?

It's very easy to use Redux or Apollo with Next, here are some examples:
https://github.com/zeit/next.js/tree/master/examples/with-redux
https://github.com/zeit/next.js/tree/master/examples/with-apollo-and-redux
using getInitialProps you can create the store in both server and client, but in the client you can do something like:
let reduxStore = null

export const initStore = () => {
  if (process.browser && !reduxStore) {
    reduxStore = createStore()
  }
  return reduxStore
}

the example with-apollo-and-redux can help you a lot.

Thanks for pointing me in the right direction, @Goluis.

Thanks @Goluis.
Closing this since, we've an answer.

authors: Goluis arunoda mikeriley131


text:
with-ant-design Example is failing under React 16

[x] I have searched the issues of this repository and believe that this is not a duplicate.

Expected Behavior

Following the README.md instructions on cloning and running the app should result in a running app, compiled correctly.
Current Behavior

Running npm i && npm run dev:

Fails to build the app.  Reason is, package.json specifies older react version but latest next.js
After upgrading react to 16, runtime error occurs due to missing "Transform Decorators Legacy" babel plugin.
After runningnpm install babel-plugin-transform-decorators-legacy the app loads without errors.

Steps to Reproduce (for bugs)

Clone the repo in a clean environment.
Run npm i && npm run dev
Update React dependencies, and repeat (2)
Open the browser to http://localhost:3000/

Context

Attempting to learn how to integrate ant design into next.js app.
Your Environment

Tech
Version

next
4.1.3

node
7.3.0

OS
MacOS Sierra 10.12.6

browser
Google Chrome

react
^16.0.0

react-dom
^16.0.0

Suggested fix:
In package.json, use the following dependencies:
"dependencies": {
    "antd": "^2.10.2",
    "babel-plugin-import": "^1.1.1",
    "babel-plugin-transform-decorators-legacy": "^1.3.4",
    "next": "latest",
    "react": "^16.0.0",
    "react-dom": "^16.0.0"
  }

or, alternatively, fix next version.  Note that with the above package.json, I see the following errors running npm list command:
npm ERR! peer dep missing: react@^0.14.0 || ^15.0.0-0, required by react-lazy-load@3.0.12 npm ERR! peer dep missing: react@^0.14.0 || ^15.0.1, required by react-slick@0.15.4 npm ERR! peer dep missing: react-dom@^0.14.0 || ^15.0.0-0, required by react-lazy-load@3.0.12 npm ERR! peer dep missing: react-dom@^0.14.0 || ^15.0.1, required by react-slick@0.15.4 npm ERR! peer dep missing: jquery@>=1.8.0, required by slick-carousel@1.8.1

Try upgrading antd?

Just giving my two cents, antd v2.9.x is using react v15 however there's a version 3 in development (current version is: 3.0.0-alpha.19) which is using react v16. So beside upgrading to this version or downgrading to Next.js v3, I don't another way to solve those errors.

I'm using next@4 and antd@2.12.8 with no issues.

@pruhstal I'm not saying it's not working with next@4 and antd@2.12.8, I was just point at the error messages while installing the packages

@vzelenko:
Maybe try changing your babelrc to this to remove  "transform-decorators-legacy"
{
  "presets": ["next/babel"],
  "plugins": [
    [
      "import",
      {
        "libraryName": "antd",
        "style": false
      }
    ]
  ]
}

@pruhstal - your suggestion works (I like not having legacy deps), but not to fix the issue.  The libraries that fail on deps are part of 'antd' package.  Which means we would have to wait until they upgrade, as advised by @blabassi, or downgrade next.js & react to compatible version of react 15x.

authors: alikhani blabassi pruhstal vzelenko


text:
Add identifier to NEXT_DATA for gs(s)p

This adds a gsp or gssp field to __NEXT_DATA__ to allow detecting whether a page is using getStaticProps or getServerSideProps. I added tests to the respective test suites to ensure this is set correctly
NEXT-98

Stats from current PR

Default Server Mode

General Overall increase ⚠

zeit/next.js canary
ijjk/next.js add/gssp-identifier
Change

buildDuration
8.7s
8.9s
⚠ +127ms

nodeModulesSize
56.3 MB
56.3 MB
⚠ +483 B

Client Bundles (main, webpack, commons)

zeit/next.js canary
ijjk/next.js add/gssp-identifier
Change

main-HASH.js gzip
5.76 kB
5.76 kB
✓

webpack-HASH.js gzip
746 B
746 B
✓

de003c3a9d30..67cb.js gzip
9.69 kB
9.69 kB
✓

framework.HASH.js gzip
39.1 kB
39.1 kB
✓

Overall change
55.3 kB
55.3 kB
✓

Client Bundles (main, webpack, commons) Modern

zeit/next.js canary
ijjk/next.js add/gssp-identifier
Change

main-HASH.module.js gzip
4.79 kB
4.79 kB
✓

webpack-HASH..dule.js gzip
746 B
746 B
✓

de003c3a9d30..dule.js gzip
6.64 kB
6.64 kB
✓

framework.HA..dule.js gzip
39.1 kB
39.1 kB
✓

Overall change
51.3 kB
51.3 kB
✓

Legacy Client Bundles (polyfills)

zeit/next.js canary
ijjk/next.js add/gssp-identifier
Change

polyfills-HASH.js gzip
18.9 kB
18.9 kB
✓

Overall change
18.9 kB
18.9 kB
✓

Client Pages

zeit/next.js canary
ijjk/next.js add/gssp-identifier
Change

_app.js gzip
1.07 kB
1.07 kB
✓

_error.js gzip
2.98 kB
2.98 kB
✓

hooks.js gzip
664 B
664 B
✓

index.js gzip
222 B
222 B
✓

link.js gzip
1.89 kB
1.89 kB
✓

routerDirect.js gzip
279 B
279 B
✓

withRouter.js gzip
278 B
278 B
✓

Overall change
7.38 kB
7.38 kB
✓

Client Pages Modern

zeit/next.js canary
ijjk/next.js add/gssp-identifier
Change

_app.module.js gzip
589 B
589 B
✓

_error.module.js gzip
2.08 kB
2.08 kB
✓

hooks.module.js gzip
370 B
370 B
✓

index.module.js gzip
212 B
212 B
✓

link.module.js gzip
1.48 kB
1.48 kB
✓

routerDirect..dule.js gzip
271 B
271 B
✓

withRouter.m..dule.js gzip
270 B
270 B
✓

Overall change
5.27 kB
5.27 kB
✓

Client Build Manifests

zeit/next.js canary
ijjk/next.js add/gssp-identifier
Change

_buildManifest.js gzip
61 B
61 B
✓

_buildManife..dule.js gzip
61 B
61 B
✓

Overall change
122 B
122 B
✓

Rendered Page Sizes

zeit/next.js canary
ijjk/next.js add/gssp-identifier
Change

index.html gzip
936 B
936 B
✓

link.html gzip
946 B
946 B
✓

withRouter.html gzip
934 B
934 B
✓

Overall change
2.82 kB
2.82 kB
✓

Serverless Mode (Decrease detected ✓)

General Overall increase ⚠

zeit/next.js canary
ijjk/next.js add/gssp-identifier
Change

buildDuration
9.5s
9.4s
-44ms

nodeModulesSize
56.3 MB
56.3 MB
⚠ +483 B

Client Bundles (main, webpack, commons)

zeit/next.js canary
ijjk/next.js add/gssp-identifier
Change

main-HASH.js gzip
5.76 kB
5.76 kB
✓

webpack-HASH.js gzip
746 B
746 B
✓

de003c3a9d30..67cb.js gzip
9.69 kB
9.69 kB
✓

framework.HASH.js gzip
39.1 kB
39.1 kB
✓

Overall change
55.3 kB
55.3 kB
✓

Client Bundles (main, webpack, commons) Modern

zeit/next.js canary
ijjk/next.js add/gssp-identifier
Change

main-HASH.module.js gzip
4.79 kB
4.79 kB
✓

webpack-HASH..dule.js gzip
746 B
746 B
✓

de003c3a9d30..dule.js gzip
6.64 kB
6.64 kB
✓

framework.HA..dule.js gzip
39.1 kB
39.1 kB
✓

Overall change
51.3 kB
51.3 kB
✓

Legacy Client Bundles (polyfills)

zeit/next.js canary
ijjk/next.js add/gssp-identifier
Change

polyfills-HASH.js gzip
18.9 kB
18.9 kB
✓

Overall change
18.9 kB
18.9 kB
✓

Client Pages

zeit/next.js canary
ijjk/next.js add/gssp-identifier
Change

_app.js gzip
1.07 kB
1.07 kB
✓

_error.js gzip
2.98 kB
2.98 kB
✓

hooks.js gzip
664 B
664 B
✓

index.js gzip
222 B
222 B
✓

link.js gzip
1.89 kB
1.89 kB
✓

routerDirect.js gzip
279 B
279 B
✓

withRouter.js gzip
278 B
278 B
✓

Overall change
7.38 kB
7.38 kB
✓

Client Pages Modern

zeit/next.js canary
ijjk/next.js add/gssp-identifier
Change

_app.module.js gzip
589 B
589 B
✓

_error.module.js gzip
2.08 kB
2.08 kB
✓

hooks.module.js gzip
370 B
370 B
✓

index.module.js gzip
212 B
212 B
✓

link.module.js gzip
1.48 kB
1.48 kB
✓

routerDirect..dule.js gzip
271 B
271 B
✓

withRouter.m..dule.js gzip
270 B
270 B
✓

Overall change
5.27 kB
5.27 kB
✓

Client Build Manifests

zeit/next.js canary
ijjk/next.js add/gssp-identifier
Change

_buildManifest.js gzip
61 B
61 B
✓

_buildManife..dule.js gzip
61 B
61 B
✓

Overall change
122 B
122 B
✓

Serverless bundles Overall decrease ✓

zeit/next.js canary
ijjk/next.js add/gssp-identifier
Change

_error.js gzip
292 kB
292 kB
⚠ +468 B

404.html gzip
1.34 kB
1.34 kB
✓

hooks.html gzip
975 B
975 B
✓

index.js gzip
292 kB
292 kB
-31 B

link.js gzip
300 kB
300 kB
⚠ +9 B

routerDirect.js gzip
298 kB
298 kB
⚠ +54 B

withRouter.js gzip
299 kB
298 kB
-1.02 kB

Overall change
1.48 MB
1.48 MB
-517 B

Stats from current PR

Default Server Mode

General Overall increase ⚠

zeit/next.js canary
ijjk/next.js add/gssp-identifier
Change

buildDuration
8.7s
8.7s
-71ms

nodeModulesSize
56.3 MB
56.3 MB
⚠ +483 B

Client Bundles (main, webpack, commons)

zeit/next.js canary
ijjk/next.js add/gssp-identifier
Change

main-HASH.js gzip
5.76 kB
5.76 kB
✓

webpack-HASH.js gzip
746 B
746 B
✓

de003c3a9d30..67cb.js gzip
9.69 kB
9.69 kB
✓

framework.HASH.js gzip
39.1 kB
39.1 kB
✓

Overall change
55.3 kB
55.3 kB
✓

Client Bundles (main, webpack, commons) Modern

zeit/next.js canary
ijjk/next.js add/gssp-identifier
Change

main-HASH.module.js gzip
4.79 kB
4.79 kB
✓

webpack-HASH..dule.js gzip
746 B
746 B
✓

de003c3a9d30..dule.js gzip
6.64 kB
6.64 kB
✓

framework.HA..dule.js gzip
39.1 kB
39.1 kB
✓

Overall change
51.3 kB
51.3 kB
✓

Legacy Client Bundles (polyfills)

zeit/next.js canary
ijjk/next.js add/gssp-identifier
Change

polyfills-HASH.js gzip
18.9 kB
18.9 kB
✓

Overall change
18.9 kB
18.9 kB
✓

Client Pages

zeit/next.js canary
ijjk/next.js add/gssp-identifier
Change

_app.js gzip
1.07 kB
1.07 kB
✓

_error.js gzip
2.98 kB
2.98 kB
✓

hooks.js gzip
664 B
664 B
✓

index.js gzip
222 B
222 B
✓

link.js gzip
1.89 kB
1.89 kB
✓

routerDirect.js gzip
279 B
279 B
✓

withRouter.js gzip
278 B
278 B
✓

Overall change
7.38 kB
7.38 kB
✓

Client Pages Modern

zeit/next.js canary
ijjk/next.js add/gssp-identifier
Change

_app.module.js gzip
589 B
589 B
✓

_error.module.js gzip
2.08 kB
2.08 kB
✓

hooks.module.js gzip
370 B
370 B
✓

index.module.js gzip
212 B
212 B
✓

link.module.js gzip
1.48 kB
1.48 kB
✓

routerDirect..dule.js gzip
271 B
271 B
✓

withRouter.m..dule.js gzip
270 B
270 B
✓

Overall change
5.27 kB
5.27 kB
✓

Client Build Manifests

zeit/next.js canary
ijjk/next.js add/gssp-identifier
Change

_buildManifest.js gzip
61 B
61 B
✓

_buildManife..dule.js gzip
61 B
61 B
✓

Overall change
122 B
122 B
✓

Rendered Page Sizes

zeit/next.js canary
ijjk/next.js add/gssp-identifier
Change

index.html gzip
936 B
936 B
✓

link.html gzip
946 B
946 B
✓

withRouter.html gzip
934 B
934 B
✓

Overall change
2.82 kB
2.82 kB
✓

Serverless Mode (Increase detected ⚠)

General Overall increase ⚠

zeit/next.js canary
ijjk/next.js add/gssp-identifier
Change

buildDuration
9.5s
9.5s
⚠ +64ms

nodeModulesSize
56.3 MB
56.3 MB
⚠ +483 B

Client Bundles (main, webpack, commons)

zeit/next.js canary
ijjk/next.js add/gssp-identifier
Change

main-HASH.js gzip
5.76 kB
5.76 kB
✓

webpack-HASH.js gzip
746 B
746 B
✓

de003c3a9d30..67cb.js gzip
9.69 kB
9.69 kB
✓

framework.HASH.js gzip
39.1 kB
39.1 kB
✓

Overall change
55.3 kB
55.3 kB
✓

Client Bundles (main, webpack, commons) Modern

zeit/next.js canary
ijjk/next.js add/gssp-identifier
Change

main-HASH.module.js gzip
4.79 kB
4.79 kB
✓

webpack-HASH..dule.js gzip
746 B
746 B
✓

de003c3a9d30..dule.js gzip
6.64 kB
6.64 kB
✓

framework.HA..dule.js gzip
39.1 kB
39.1 kB
✓

Overall change
51.3 kB
51.3 kB
✓

Legacy Client Bundles (polyfills)

zeit/next.js canary
ijjk/next.js add/gssp-identifier
Change

polyfills-HASH.js gzip
18.9 kB
18.9 kB
✓

Overall change
18.9 kB
18.9 kB
✓

Client Pages

zeit/next.js canary
ijjk/next.js add/gssp-identifier
Change

_app.js gzip
1.07 kB
1.07 kB
✓

_error.js gzip
2.98 kB
2.98 kB
✓

hooks.js gzip
664 B
664 B
✓

index.js gzip
222 B
222 B
✓

link.js gzip
1.89 kB
1.89 kB
✓

routerDirect.js gzip
279 B
279 B
✓

withRouter.js gzip
278 B
278 B
✓

Overall change
7.38 kB
7.38 kB
✓

Client Pages Modern

zeit/next.js canary
ijjk/next.js add/gssp-identifier
Change

_app.module.js gzip
589 B
589 B
✓

_error.module.js gzip
2.08 kB
2.08 kB
✓

hooks.module.js gzip
370 B
370 B
✓

index.module.js gzip
212 B
212 B
✓

link.module.js gzip
1.48 kB
1.48 kB
✓

routerDirect..dule.js gzip
271 B
271 B
✓

withRouter.m..dule.js gzip
270 B
270 B
✓

Overall change
5.27 kB
5.27 kB
✓

Client Build Manifests

zeit/next.js canary
ijjk/next.js add/gssp-identifier
Change

_buildManifest.js gzip
61 B
61 B
✓

_buildManife..dule.js gzip
61 B
61 B
✓

Overall change
122 B
122 B
✓

Serverless bundles Overall increase ⚠

zeit/next.js canary
ijjk/next.js add/gssp-identifier
Change

_error.js gzip
292 kB
292 kB
⚠ +193 B

404.html gzip
1.34 kB
1.34 kB
✓

hooks.html gzip
975 B
975 B
✓

index.js gzip
292 kB
293 kB
⚠ +1.18 kB

link.js gzip
299 kB
299 kB
⚠ +15 B

routerDirect.js gzip
298 kB
298 kB
-262 B

withRouter.js gzip
298 kB
298 kB
-22 B

Overall change
1.48 MB
1.48 MB
⚠ +1.1 kB

Stats from current PR

Default Server Mode

General Overall increase ⚠

zeit/next.js canary
ijjk/next.js add/gssp-identifier
Change

buildDuration
10.2s
10.5s
⚠ +375ms

nodeModulesSize
56.3 MB
56.3 MB
⚠ +483 B

Client Bundles (main, webpack, commons)

zeit/next.js canary
ijjk/next.js add/gssp-identifier
Change

main-HASH.js gzip
5.76 kB
5.76 kB
✓

webpack-HASH.js gzip
746 B
746 B
✓

de003c3a9d30..67cb.js gzip
9.69 kB
9.69 kB
✓

framework.HASH.js gzip
39.1 kB
39.1 kB
✓

Overall change
55.3 kB
55.3 kB
✓

Client Bundles (main, webpack, commons) Modern

zeit/next.js canary
ijjk/next.js add/gssp-identifier
Change

main-HASH.module.js gzip
4.79 kB
4.79 kB
✓

webpack-HASH..dule.js gzip
746 B
746 B
✓

de003c3a9d30..dule.js gzip
6.64 kB
6.64 kB
✓

framework.HA..dule.js gzip
39.1 kB
39.1 kB
✓

Overall change
51.3 kB
51.3 kB
✓

Legacy Client Bundles (polyfills)

zeit/next.js canary
ijjk/next.js add/gssp-identifier
Change

polyfills-HASH.js gzip
18.9 kB
18.9 kB
✓

Overall change
18.9 kB
18.9 kB
✓

Client Pages

zeit/next.js canary
ijjk/next.js add/gssp-identifier
Change

_app.js gzip
1.07 kB
1.07 kB
✓

_error.js gzip
2.98 kB
2.98 kB
✓

hooks.js gzip
664 B
664 B
✓

index.js gzip
222 B
222 B
✓

link.js gzip
1.89 kB
1.89 kB
✓

routerDirect.js gzip
279 B
279 B
✓

withRouter.js gzip
278 B
278 B
✓

Overall change
7.38 kB
7.38 kB
✓

Client Pages Modern

zeit/next.js canary
ijjk/next.js add/gssp-identifier
Change

_app.module.js gzip
589 B
589 B
✓

_error.module.js gzip
2.08 kB
2.08 kB
✓

hooks.module.js gzip
370 B
370 B
✓

index.module.js gzip
212 B
212 B
✓

link.module.js gzip
1.48 kB
1.48 kB
✓

routerDirect..dule.js gzip
271 B
271 B
✓

withRouter.m..dule.js gzip
270 B
270 B
✓

Overall change
5.27 kB
5.27 kB
✓

Client Build Manifests

zeit/next.js canary
ijjk/next.js add/gssp-identifier
Change

_buildManifest.js gzip
61 B
61 B
✓

_buildManife..dule.js gzip
61 B
61 B
✓

Overall change
122 B
122 B
✓

Rendered Page Sizes

zeit/next.js canary
ijjk/next.js add/gssp-identifier
Change

index.html gzip
936 B
936 B
✓

link.html gzip
946 B
946 B
✓

withRouter.html gzip
934 B
934 B
✓

Overall change
2.82 kB
2.82 kB
✓

Serverless Mode (Decrease detected ✓)

General Overall increase ⚠

zeit/next.js canary
ijjk/next.js add/gssp-identifier
Change

buildDuration
10.8s
10.8s
-92ms

nodeModulesSize
56.3 MB
56.3 MB
⚠ +483 B

Client Bundles (main, webpack, commons)

zeit/next.js canary
ijjk/next.js add/gssp-identifier
Change

main-HASH.js gzip
5.76 kB
5.76 kB
✓

webpack-HASH.js gzip
746 B
746 B
✓

de003c3a9d30..67cb.js gzip
9.69 kB
9.69 kB
✓

framework.HASH.js gzip
39.1 kB
39.1 kB
✓

Overall change
55.3 kB
55.3 kB
✓

Client Bundles (main, webpack, commons) Modern

zeit/next.js canary
ijjk/next.js add/gssp-identifier
Change

main-HASH.module.js gzip
4.79 kB
4.79 kB
✓

webpack-HASH..dule.js gzip
746 B
746 B
✓

de003c3a9d30..dule.js gzip
6.64 kB
6.64 kB
✓

framework.HA..dule.js gzip
39.1 kB
39.1 kB
✓

Overall change
51.3 kB
51.3 kB
✓

Legacy Client Bundles (polyfills)

zeit/next.js canary
ijjk/next.js add/gssp-identifier
Change

polyfills-HASH.js gzip
18.9 kB
18.9 kB
✓

Overall change
18.9 kB
18.9 kB
✓

Client Pages

zeit/next.js canary
ijjk/next.js add/gssp-identifier
Change

_app.js gzip
1.07 kB
1.07 kB
✓

_error.js gzip
2.98 kB
2.98 kB
✓

hooks.js gzip
664 B
664 B
✓

index.js gzip
222 B
222 B
✓

link.js gzip
1.89 kB
1.89 kB
✓

routerDirect.js gzip
279 B
279 B
✓

withRouter.js gzip
278 B
278 B
✓

Overall change
7.38 kB
7.38 kB
✓

Client Pages Modern

zeit/next.js canary
ijjk/next.js add/gssp-identifier
Change

_app.module.js gzip
589 B
589 B
✓

_error.module.js gzip
2.08 kB
2.08 kB
✓

hooks.module.js gzip
370 B
370 B
✓

index.module.js gzip
212 B
212 B
✓

link.module.js gzip
1.48 kB
1.48 kB
✓

routerDirect..dule.js gzip
271 B
271 B
✓

withRouter.m..dule.js gzip
270 B
270 B
✓

Overall change
5.27 kB
5.27 kB
✓

Client Build Manifests

zeit/next.js canary
ijjk/next.js add/gssp-identifier
Change

_buildManifest.js gzip
61 B
61 B
✓

_buildManife..dule.js gzip
61 B
61 B
✓

Overall change
122 B
122 B
✓

Serverless bundles Overall decrease ✓

zeit/next.js canary
ijjk/next.js add/gssp-identifier
Change

_error.js gzip
292 kB
292 kB
-539 B

404.html gzip
1.34 kB
1.34 kB
✓

hooks.html gzip
975 B
975 B
✓

index.js gzip
292 kB
292 kB
-82 B

link.js gzip
299 kB
299 kB
⚠ +79 B

routerDirect.js gzip
298 kB
299 kB
⚠ +960 B

withRouter.js gzip
299 kB
298 kB
-1.02 kB

Overall change
1.48 MB
1.48 MB
-600 B


text:
Bugfix: Enable render to string in middleware

Problem
It is useful to be able to render the AppTree to string within the context of middleware. One usecase might be to do query analysis for specialised data fetching components or hooks. Unfortunately currently this is not possible because middleware is run before AppContainer is initialized.
import Document from "next/document";
import React from "react";
import { renderToString } from "react-dom/server";

export default Document;

export async function middleware(ctx) {
  const { AppTree } = ctx;
  renderToString(<AppTree />);
}

This throw a ReferenceError:
ReferenceError: Cannot access 'AppContainer' before initialization

Solution
This PR moves the call to middleware until after AppContainer has been defined

Let me know if I should write a test for this somewhere.

Stats from current PR

Default Server Mode

General

zeit/next.js canary
ryardley/next.js bug/allow-render-to-string-middleware
Change

buildDuration
10.1s
10.2s
⚠ +101ms

nodeModulesSize
53.2 MB
53.2 MB
✓

Client Bundles (main, webpack, commons)

zeit/next.js canary
ryardley/next.js bug/allow-render-to-string-middleware
Change

main-HASH.js gzip
5.77 kB
5.77 kB
✓

webpack-HASH.js gzip
746 B
746 B
✓

de003c3a9d30..8eb0.js gzip
9.78 kB
9.78 kB
✓

framework.HASH.js gzip
39.1 kB
39.1 kB
✓

Overall change
55.4 kB
55.4 kB
✓

Client Bundles (main, webpack, commons) Modern

zeit/next.js canary
ryardley/next.js bug/allow-render-to-string-middleware
Change

main-HASH.module.js gzip
4.78 kB
4.78 kB
✓

webpack-HASH..dule.js gzip
746 B
746 B
✓

de003c3a9d30..dule.js gzip
6.71 kB
6.71 kB
✓

framework.HA..dule.js gzip
39.1 kB
39.1 kB
✓

Overall change
51.4 kB
51.4 kB
✓

Legacy Client Bundles (polyfills)

zeit/next.js canary
ryardley/next.js bug/allow-render-to-string-middleware
Change

polyfills-HASH.js gzip
26.3 kB
26.3 kB
✓

Overall change
26.3 kB
26.3 kB
✓

Client Pages

zeit/next.js canary
ryardley/next.js bug/allow-render-to-string-middleware
Change

_app.js gzip
1.09 kB
1.09 kB
✓

_error.js gzip
2.97 kB
2.97 kB
✓

hooks.js gzip
664 B
664 B
✓

index.js gzip
222 B
222 B
✓

link.js gzip
1.89 kB
1.89 kB
✓

routerDirect.js gzip
279 B
279 B
✓

withRouter.js gzip
278 B
278 B
✓

Overall change
7.39 kB
7.39 kB
✓

Client Pages Modern

zeit/next.js canary
ryardley/next.js bug/allow-render-to-string-middleware
Change

_app.module.js gzip
594 B
594 B
✓

_error.module.js gzip
2.08 kB
2.08 kB
✓

hooks.module.js gzip
370 B
370 B
✓

index.module.js gzip
212 B
212 B
✓

link.module.js gzip
1.48 kB
1.48 kB
✓

routerDirect..dule.js gzip
271 B
271 B
✓

withRouter.m..dule.js gzip
270 B
270 B
✓

Overall change
5.28 kB
5.28 kB
✓

Client Build Manifests

zeit/next.js canary
ryardley/next.js bug/allow-render-to-string-middleware
Change

_buildManifest.js gzip
61 B
61 B
✓

_buildManife..dule.js gzip
61 B
61 B
✓

Overall change
122 B
122 B
✓

Rendered Page Sizes

zeit/next.js canary
ryardley/next.js bug/allow-render-to-string-middleware
Change

index.html gzip
916 B
916 B
✓

link.html gzip
924 B
924 B
✓

withRouter.html gzip
913 B
913 B
✓

Overall change
2.75 kB
2.75 kB
✓

Serverless Mode (Increase detected ⚠)

General

zeit/next.js canary
ryardley/next.js bug/allow-render-to-string-middleware
Change

buildDuration
11.4s
11.3s
-135ms

nodeModulesSize
53.2 MB
53.2 MB
✓

Client Bundles (main, webpack, commons)

zeit/next.js canary
ryardley/next.js bug/allow-render-to-string-middleware
Change

main-HASH.js gzip
5.77 kB
5.77 kB
✓

webpack-HASH.js gzip
746 B
746 B
✓

de003c3a9d30..8eb0.js gzip
9.78 kB
9.78 kB
✓

framework.HASH.js gzip
39.1 kB
39.1 kB
✓

Overall change
55.4 kB
55.4 kB
✓

Client Bundles (main, webpack, commons) Modern

zeit/next.js canary
ryardley/next.js bug/allow-render-to-string-middleware
Change

main-HASH.module.js gzip
4.78 kB
4.78 kB
✓

webpack-HASH..dule.js gzip
746 B
746 B
✓

de003c3a9d30..dule.js gzip
6.71 kB
6.71 kB
✓

framework.HA..dule.js gzip
39.1 kB
39.1 kB
✓

Overall change
51.4 kB
51.4 kB
✓

Legacy Client Bundles (polyfills)

zeit/next.js canary
ryardley/next.js bug/allow-render-to-string-middleware
Change

polyfills-HASH.js gzip
26.3 kB
26.3 kB
✓

Overall change
26.3 kB
26.3 kB
✓

Client Pages

zeit/next.js canary
ryardley/next.js bug/allow-render-to-string-middleware
Change

_app.js gzip
1.09 kB
1.09 kB
✓

_error.js gzip
2.97 kB
2.97 kB
✓

hooks.js gzip
664 B
664 B
✓

index.js gzip
222 B
222 B
✓

link.js gzip
1.89 kB
1.89 kB
✓

routerDirect.js gzip
279 B
279 B
✓

withRouter.js gzip
278 B
278 B
✓

Overall change
7.39 kB
7.39 kB
✓

Client Pages Modern

zeit/next.js canary
ryardley/next.js bug/allow-render-to-string-middleware
Change

_app.module.js gzip
594 B
594 B
✓

_error.module.js gzip
2.08 kB
2.08 kB
✓

hooks.module.js gzip
370 B
370 B
✓

index.module.js gzip
212 B
212 B
✓

link.module.js gzip
1.48 kB
1.48 kB
✓

routerDirect..dule.js gzip
271 B
271 B
✓

withRouter.m..dule.js gzip
270 B
270 B
✓

Overall change
5.28 kB
5.28 kB
✓

Client Build Manifests

zeit/next.js canary
ryardley/next.js bug/allow-render-to-string-middleware
Change

_buildManifest.js gzip
61 B
61 B
✓

_buildManife..dule.js gzip
61 B
61 B
✓

Overall change
122 B
122 B
✓

Serverless bundles Overall increase ⚠

zeit/next.js canary
ryardley/next.js bug/allow-render-to-string-middleware
Change

_error.js gzip
293 kB
293 kB
⚠ +3 B

404.html gzip
1.32 kB
1.32 kB
✓

hooks.html gzip
957 B
957 B
✓

index.js gzip
294 kB
293 kB
-382 B

link.js gzip
301 kB
301 kB
⚠ +733 B

routerDirect.js gzip
300 kB
300 kB
-63 B

withRouter.js gzip
300 kB
300 kB
-170 B

Overall change
1.49 MB
1.49 MB
⚠ +121 B

The experimental middleware is going to be removed in the near future as it deoptimized the whole application.
Allowing tree rendering here would amplify deoptimizing the application even further.

authors: ijjk ryardley timneutkens


text:
add warning about manually installing PostCSS plugins

Add a warning to the "Customizing PostCSS config" page instructing users to manually install any plugins they include in the file.

Stats from current PR

Default Server Mode (Decrease detected ✓)

General

zeit/next.js canary
pjaws/next.js canary
Change

buildDuration
11.1s
11.1s
⚠ +84ms

nodeModulesSize
55.5 MB
55.5 MB
✓

Page Load Tests Overall decrease ⚠

zeit/next.js canary
pjaws/next.js canary
Change

/ failed reqs
0
0
✓

/ total time (seconds)
1.851
1.895
⚠ +0.04

/ avg req/sec
1350.36
1319.34
-31.02

/error-in-render failed reqs
0
0
✓

/error-in-render total time (seconds)
0.945
1.003
⚠ +0.06

/error-in-render avg req/sec
2646.02
2492.99
-153.03

Client Bundles (main, webpack, commons)

zeit/next.js canary
pjaws/next.js canary
Change

main-HASH.js gzip
6.25 kB
6.25 kB
✓

webpack-HASH.js gzip
746 B
746 B
✓

de003c3a9d30..5e5e.js gzip
10.3 kB
10.3 kB
✓

framework.a1..NSE.txt gzip
220 B
220 B
✓

framework.a1..NSE.txt gzip
220 B
220 B
✓

framework.HASH.js gzip
39 kB
39 kB
✓

Overall change
56.7 kB
56.7 kB
✓

Client Bundles (main, webpack, commons) Modern

zeit/next.js canary
pjaws/next.js canary
Change

main-HASH.module.js gzip
4.79 kB
4.79 kB
✓

webpack-HASH..dule.js gzip
746 B
746 B
✓

de003c3a9d30..dule.js gzip
6.85 kB
6.85 kB
✓

framework.HA..dule.js gzip
39 kB
39 kB
✓

Overall change
51.4 kB
51.4 kB
✓

Legacy Client Bundles (polyfills)

zeit/next.js canary
pjaws/next.js canary
Change

polyfills-HASH.js gzip
26.2 kB
26.2 kB
✓

Overall change
26.2 kB
26.2 kB
✓

Client Pages

zeit/next.js canary
pjaws/next.js canary
Change

_app.js gzip
1.24 kB
1.24 kB
✓

_error.js gzip
3.12 kB
3.12 kB
✓

hooks.js gzip
664 B
664 B
✓

index.js gzip
222 B
222 B
✓

link.js gzip
2.06 kB
2.06 kB
✓

routerDirect.js gzip
279 B
279 B
✓

withRouter.js gzip
278 B
278 B
✓

Overall change
7.86 kB
7.86 kB
✓

Client Pages Modern

zeit/next.js canary
pjaws/next.js canary
Change

_app.module.js gzip
602 B
602 B
✓

_error.module.js gzip
2.09 kB
2.09 kB
✓

hooks.module.js gzip
383 B
383 B
✓

index.module.js gzip
223 B
223 B
✓

link.module.js gzip
1.52 kB
1.52 kB
✓

routerDirect..dule.js gzip
281 B
281 B
✓

withRouter.m..dule.js gzip
278 B
278 B
✓

Overall change
5.38 kB
5.38 kB
✓

Client Build Manifests

zeit/next.js canary
pjaws/next.js canary
Change

_buildManifest.js gzip
61 B
61 B
✓

_buildManife..dule.js gzip
61 B
61 B
✓

Overall change
122 B
122 B
✓

Rendered Page Sizes

zeit/next.js canary
pjaws/next.js canary
Change

index.html gzip
927 B
927 B
✓

link.html gzip
937 B
937 B
✓

withRouter.html gzip
924 B
924 B
✓

Overall change
2.79 kB
2.79 kB
✓

Serverless Mode

General

zeit/next.js canary
pjaws/next.js canary
Change

buildDuration
11.8s
11.9s
⚠ +105ms

nodeModulesSize
55.5 MB
55.5 MB
✓

Client Bundles (main, webpack, commons)

zeit/next.js canary
pjaws/next.js canary
Change

main-HASH.js gzip
6.25 kB
6.25 kB
✓

webpack-HASH.js gzip
746 B
746 B
✓

de003c3a9d30..5e5e.js gzip
10.3 kB
10.3 kB
✓

framework.a1..NSE.txt gzip
220 B
220 B
✓

framework.a1..NSE.txt gzip
220 B
220 B
✓

framework.HASH.js gzip
39 kB
39 kB
✓

Overall change
56.7 kB
56.7 kB
✓

Client Bundles (main, webpack, commons) Modern

zeit/next.js canary
pjaws/next.js canary
Change

main-HASH.module.js gzip
4.79 kB
4.79 kB
✓

webpack-HASH..dule.js gzip
746 B
746 B
✓

de003c3a9d30..dule.js gzip
6.85 kB
6.85 kB
✓

framework.HA..dule.js gzip
39 kB
39 kB
✓

Overall change
51.4 kB
51.4 kB
✓

Legacy Client Bundles (polyfills)

zeit/next.js canary
pjaws/next.js canary
Change

polyfills-HASH.js gzip
26.2 kB
26.2 kB
✓

Overall change
26.2 kB
26.2 kB
✓

Client Pages

zeit/next.js canary
pjaws/next.js canary
Change

_app.js gzip
1.24 kB
1.24 kB
✓

_error.js gzip
3.12 kB
3.12 kB
✓

hooks.js gzip
664 B
664 B
✓

index.js gzip
222 B
222 B
✓

link.js gzip
2.06 kB
2.06 kB
✓

routerDirect.js gzip
279 B
279 B
✓

withRouter.js gzip
278 B
278 B
✓

Overall change
7.86 kB
7.86 kB
✓

Client Pages Modern

zeit/next.js canary
pjaws/next.js canary
Change

_app.module.js gzip
602 B
602 B
✓

_error.module.js gzip
2.09 kB
2.09 kB
✓

hooks.module.js gzip
383 B
383 B
✓

index.module.js gzip
223 B
223 B
✓

link.module.js gzip
1.52 kB
1.52 kB
✓

routerDirect..dule.js gzip
281 B
281 B
✓

withRouter.m..dule.js gzip
278 B
278 B
✓

Overall change
5.38 kB
5.38 kB
✓

Client Build Manifests

zeit/next.js canary
pjaws/next.js canary
Change

_buildManifest.js gzip
61 B
61 B
✓

_buildManife..dule.js gzip
61 B
61 B
✓

Overall change
122 B
122 B
✓

Serverless bundles

zeit/next.js canary
pjaws/next.js canary
Change

_error.js
557 kB
557 kB
✓

404.html
4.18 kB
4.18 kB
✓

hooks.html
3.81 kB
3.81 kB
✓

index.js
557 kB
557 kB
✓

link.js
594 kB
594 kB
✓

routerDirect.js
586 kB
586 kB
✓

withRouter.js
586 kB
586 kB
✓

Overall change
2.89 MB
2.89 MB
✓

Thanks!

authors: ijjk pjaws timneutkens


text:
ref: avoid running apollo SSR logic on the client-side

From the with-apollo example:
Previously, initApollo and getDataFromTree would be called on the client-side when getInitialProps is called. This seems to be unnecessary work to do on the client side. You can place some debugger; marks to see this initialisation taking place and then navigate between Home and About pages.
I extracted the server side initialisation of Apollo into the getApolloDataOnServer function and invoked it when getInitialProps is called on the server only.

I submitted the pr for this change (#3457), just to get some feedback. My intention was to make Apollo work better with the "next.js" way of fetching data using getInitialProps. With getDataFromTree just running on the server, you can't use libs like nprogress and wait for data load before doing page transitions, leaving you with a bunch of loading spinners (ofc thats up to your implementation). However, later I figured out how you can pass ApolloClient to getInitialProps, so the need for running getDataFromTree isn't that needed anymore for our projects part. And thats what I feel is the problem with the Apollo examples; they are so fragmented and tailored against each projects requirements, and each example does things a little bit differently. There is also projects like next-apollo, which I feel is great for learning and quickly getting Apollo integrated into a Next.js project.

withData is no more, but the logic is still the same, I'm not entirely sure what the expected behaviour should be, since I've had an instance where getting all data in getInitialProps was required as opposed to loading... everywhere.
Maybe we should just documented this change as an option 🤔

authors: disintegrator jonespen timneutkens


text:
Merge examples canary to master

Fix for typescript examples 1.0.1 -> 1.1.0

We only merge to master when releasing new versions. A pull request to create-next-app was merged but not released yet: https://github.com/segmentio/create-next-app/pull/36

authors: gtgalone timneutkens


text:
now alias error: 'deployment readyState is INITIALIZING and not READY

Using now@10.2.1 on bash-for-windows
Deployment works fine and is accessible at the hash .now.sh URL, but when attempting to assign an alias, I get this error:
> Error! Unknown error: Error: The deployment `readyState` is `INITIALIZING` and not `READY`
Error: The deployment `readyState` is `INITIALIZING` and not `READY`
    at module.exports.Now.createAlias.alias.retry (/snapshot/repo/dist/now.js:3968:21)
    at <anonymous>
    at process._tickCallback (internal/process/next_tick.js:188:7)

I've tried re-deploying a few times, but no change in symptoms.
Anyway to work around this, or any other way to assign an alias besides CLI?

gd it. Just as I tried to run it with DEBUG=* to add to this issue, it worked. I'll close this & just re-open if it happens again / to someone else.
$ DEBUG=* now alias project-some-hash.now.sh some-alias.now.sh
  now:main start +0ms
  now:main falling back to default now provider 'sh' +20ms
  now:main user supplied known subcommand alias +0ms
> Success! some-alias.now.sh now points to project-some-hash.now.sh! [998ms]

I am also seeing this after upgrading to the lastest now-cli
> Assigning alias graph.movecounselors.com to deployment...
> graph.movecounselors.com is a custom domain.
> Verifying the DNS settings for graph.movecounselors.com (see https://zeit.world for help)
> Verification OK!
> Error! Unknown error: Error: The deployment `readyState` is `INITIALIZING` and not `READY`
Error: The deployment `readyState` is `INITIALIZING` and not `READY`
    at module.exports.Now.createAlias.alias.retry (/snapshot/repo/dist/now.js:3968:21)
    at <anonymous>
    at process._tickCallback (internal/process/next_tick.js:188:7)

@southpolesteve Are you still experiencing that error?

Same here
now:main start +0ms
now:main falling back to default now provider 'sh' +47ms
now:main user supplied known subcommand alias +0ms

Error! An unexpected error occurred in alias: Error: Fetching a deployment failed
at module.exports.EventEmitter.findDeployment.hostOrId.retry (/snapshot/repo/dist/now.js:634:15)
at
at process._tickCallback (internal/process/next_tick.js:188:7)

This is not happening as of Now 2.0 anymore: https://zeit.co/blog/now-2

authors: MAPESO brandonmp leo pantharshit00 southpolesteve

repo: zeit/now-cli


text:
Use prop-types package

When utilizing later builds of react using the react PropTypes triggers a deprecation warning:
Warning: Accessing PropTypes via the main React package is deprecated. Use the prop-types package from npm instead.

Wonderful. Thanks!

authors: hharnisc leo

repo: zeit/react-keyframes


text:
[Court] List of court cases randomly changes order

https://github.com/zeitgeistpm/ui/assets/49552287/f468f4d6-06dc-4a71-90bf-cdc98227eac5

Not exactly sure what happens here. Could case 4 have gotten closed as you where on the page?

No, it's still happening.

Chrome Version 119.0.6045.199 (Official Build) (x86_64)
macOS 14.1.2 (23B92)

authors: maltekliemann yornaath

repo: zeitgeistpm/ui


text:
update to eslint 3.5.0

master currently has a bundled version of eslint 2.7.0, which is not really current.
In order to support newer and updated rules, an upgrade is needed, which I'd quickly done here.

Will this get merged soon? It would be great to have support for a more recent version of ESLint

authors: pmvrmc siebertm

repo: zendesk/eslintrb


text:
Check Documentation For Other Things

Check docs for other problems

TLDR; Cast your eye over the documetation for any problems not covered in the other issues

Things slip through the net, so check the documentation for other problems that have been missed. Common other problems include

Bullet lists (should be single * then space at the start of line)
Inline code - should be marked by three backticks at start and finish
bookdown.json file is correctly formated and has the right escaping
Links between documentation using RST have been stripped
Any other RST has been removed correctly
Anything and everything not covered

If you end up fixing the same problem over and over, please ping Gary Hockin - we may be able to add bespoke issue for that problem, or fix in automated capacity

Yes.

authors: GeeH froschdesign

repo: zendframework/zend-ldap


text:
Gnome 47 support

Seems that at least the Clutter.Color change needs to be addressed.

which elements / lines do you mean?

I only see now that you already addressed this in 547113d9985ca2e3. No idea why that escaped me. Sorry for the noise!

@jspitz please be aware that current master IS NOT available on extensions.gnome.org, because i wait for gnome-shell 47 is available for me. There are little difference between master and branch teatimer (which reflect extensions.gnome.org).

@zeners I have installed the extension now manually fro this repo and it works perfectly well with GNOME 47 AFAICT.

authors: jspitz zeners

repo: zeners/gnome-shell-teatime


text:
:lipstick: Underline link only on mouse over

Close #48

@ripoul thanks for your contribution 👍 This change only works for resources section. It should also work for top contributors, top projects and highlighted projects sections. Do you need some pointers about it ?

something like that ?

That's exactly what I expect 👍 but I wonder if you remove text-decoration: none; from People.css and TopProjects.css isn't your global rule sufficient ?

c'est vrai que c'est mieux.

Thank you for your work @ripoul 👍

authors: frinyvonnick ripoul

repo: zenika-open-source/insights-website


text:
Transition to Mkdocs for versioned api-docs

Pre-requisites
Please ensure you have done the following:

[x] I have read the CONTRIBUTING.md document.
[x] If my change requires a change to the documentation, I have updated the documentation accordingly.
[x] I have added tests to cover my changes.

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Describe changes
Dynamically create docstrings when docs are served. Try it out locally by running docs/mkdocstrings_helper.py and then mkdocs serve from within the docs folder.

CUrrently only a draft because I want to remove --push from the default .sh script and because i need to still verify that all dependencies are included in the pyproject.toml file.
Unfortunately the changes inside the yml are not tested for functionality, we will have to see what happens during release or just try doing a testrun.
Feel free to check out docs produced here: http://apidocs.zenml.io/0.5.7/

Will take a look Alexej! Could you change the name of the PR to something more verbose? I think that would make it clearer in the release notes! :)

I jut noticed one mistake. Other than that, i think we should test the deployment in a test run somewhere soon and remove the push also as you suggest.
Btw I notice that https://apidocs.zenml.io/ redirects to https://apidocs.zenml.io/latest which is currently down. I have changed the 0.5.7 docs to go directly to https://apidocs.zenml.io/0.5.7/ for now but we should fix this asap

Currently testing this

I ran tests on two separate branches to verify different versions are pushed subsequently to the equivalent of gh-pages for the github actions.
First this action was executed: https://github.com/zenml-io/zenml/runs/4925657388?check_suite_focus=true
Then this one: https://github.com/zenml-io/zenml/runs/4925797327?check_suite_focus=true
Here you can see the expected two versions (branch names): https://github.com/zenml-io/zenml/tree/misc/test_docs
latest points at the second action that was run, so testing_gh_action_for_api_docs_publish

repo: zenml-io/zenml


text:
Update to use Quill v.1.2.5.

There are some useful bug fixes in the most recent version.
Quill version:

[X ] 1.0.0-rc-2

I believe the package.json is compatible with 1.2.5: https://github.com/zenoamaro/react-quill/blob/master/package.json#L43-L46
You just need to npm upgrade the package.

authors: alexkrolick aliciawood

repo: zenoamaro/react-quill


text:
Is dataence/encoding the same repository?

There are import paths that points to github.com/dataence/encoding/* all over the library. It seems as you moved this repository from dataence to zentures and you forgot to change to paths. Am I right? I could open a quick PR and fix the paths.

Unfortunately I have not been maintaining this. Please feel free to fork. Thanks

authors: vteromero zhenjl

repo: zentures/encoding


text:
Formatting of hours and minutes in field

Hours and minutes should always be formatted with two digits in the input fields:
12:1 should be 12:01
6:27 should be 06:27

@rolandschaub When clicking today? When updating? On blur?

On blur would be nice, otherwise on update.

authors: nadar rolandschaub

repo: zephir/luya


text:
ADC generic driver missing features: calibration, reference voltage value

The Nordic SAADC peripheral has a calibration feature that's supposed to be initiated before the first use.  The existing generic ADC driver does not have a way to initiate this.  Since configuring ADC through the "generic" API requires including the SOC headers anyway, I'm just calibrating manually.
Also there's an option to use the internal reference voltage, but no way to fetch the value of that voltage for whatever board you're running on so the measurement in ADC counts can be converted to a voltage.   The value isn't even in the nrfx HAL as far as I can tell.

@anangl was the person leading the ADC API rework that took place recently.

Thumbs up, I would be happy to see SAADC calibration feature added.

When somebody comes to support retrieving the internal reference voltage here's what I've found:

For CONFIG_ADC_NRFX_ADC it's 1200 mV
For CONFIG_ADC_NRFX_SAADC it's 600 mV
For ARC Designware ADC the information is not publicly available
For Intel Quark D2000 it's either 3.3V or the battery voltage
For Kinetis (MCUX_ADC16) there is no internal reference voltage, although ADC_REF_INTERNAL is the only permitted configuration.  The actual reference voltage is selected from one of two external choices, possibly constrained by the PCB, and fixed via Kconfig.
For Atmel SAM AFEC it's either 3.3V or 5.0V.  For sam_e70_xplained it appears to be 3300 mV.
No other platforms implement this API.

Looking at the huge variation in ADC support across just these few platforms I suspect it would be wiser to reduce the complexity of the ADC API to a bare-bones set of operations that do not attempt to provide a generic API for things like channel configuration, acquisition time, resolution, or sequencing.
Or just remove it and accept that doing ADC requires a platform-specific driver with no generic abstraction, which would probably be a more maintainable and simpler approach.

Looks like calibration and reference voltage APIs are now both present, so if there's a problem with them that can be a new issue.

authors: Qbicz carlescufi pabigot

repo: zephyrproject-rtos/zephyr


text:
insufficient code coverage for include/sys/math_extras_impl.h

The inline functions declared here are not sufficiently tested by test cases in tests/kernel/ or tests/lib/.
I can find no test case at all which proves that these work. Need to add a test under tests/lib/ which exercises every function, with and without builtins, and prove that they work.

These are actually covered in /tests/unit_tests.
Here is the lcov report:

I tested with both builtin and portable versions, although there is a small bug in tests/unit/math_extras/portable.c:
#define VNAME(N) test_portable_##N
#include "tests.inc"

ZTEST(math_extras_portable, test_portable_u32_add) {
	run_portable_u32_add();
}

...

Where i had to change #define VNAME(N) test_portable_##N to #define VNAME(N) run_portable_##N

well, I would say we have many things that do not have good code coverage, we do not need to have an issue about each.,

authors: andrewboie nashif rubidijum


text:
sanitycheck: hardware map generation unexpected exit during the first attempt

Describe the bug
When I create a hardware map for any board, for example reel_board, it finishes work on the step:
[maksim@maksim-nuc scripts]$ sanitycheck --device-serial /dev/ttyACM0 --generate-hardware-map mec.file
INFO    - Scanning connected hardware...
[maksim@maksim-nuc scripts]$

At the same time hardware map file mec.file was succesfully created, at can be opened.
When I run the same command at the second time, it gives me the full output.
[maksim@maksim-nuc scripts]$ sanitycheck --device-serial /dev/ttyACM0 --generate-hardware-map mec.file
INFO    - Scanning connected hardware...
INFO    - Registered devices:

| Platform   | ID                       | Serial device   |
|------------|--------------------------|-----------------|
| unknown    | 024002010E8B3E61F375C3D9 | /dev/ttyACM0    |
[maksim@maksim-nuc scripts]$

To Reproduce
Steps to reproduce the behavior:

Use the latest master 17d066b9dc0e0ac632edce4a2e723332ee950ec6
Connect  reel_board or any other board. Tested on Sam_e70_xplained and FRDM have the same behaviour.
Run $ sanitycheck --device-serial /dev/ttyACM0 --generate-hardware-map mec.file
If after the first run, was no suspicious behavior, try to to delete hardware map.file and run command again. You should be able to see that bug.

Expected behavior
I expect that hardware map output should be full after the first attempt.
Impact
Annoyance, not clear understanding if hardware map was created or not, so need to run command again.
Environment (please complete the following information):

OS: Fedora 28
Toolchain Zephyr SDK 0.10.3
Commit 17d066b9dc0e0ac632edce4a2e723332ee950ec6

@maksimmasalski  you do not need to call --generate-hardware-map mec.file with --device-serial /dev/ttyACM0, the serial is supposed to be detected.

I expect that hardware map output should be full after the first attempt.

it is full, however we do not show the detected devices.

authors: maksimmasalski nashif


text:
drivers: i2c: i2c_nrfx_twim  Power Consumption rises after I2C data transfer

Describe the bug
We are using a nrf52832 based board. There are some I2C devices like tsm12 and eeprom.
The power consumption is 200ua when the I2C buses of the nrf52832 is enabled, but without data transfering.
But when data transfer throw the I2C bus, the power consumption of the board increased by about 400ua.
The power consumption will never fall back again, even when the data transfering is over.
What have you tried to diagnose or workaround this issue?

When the issue is taking place, i have tried to disconnect the physical connection of all the i2c devices
included the tsm12 and the eeprom.  But it is useless. So the increase of the power consumption issue is caused
by the chip of nrf52832.
But the i2c driver of nrf52832 has disabled the i2c bus after data transfering by calling this function:
"nrfx_twim_disable(&get_dev_config(dev)->twim);" . So it seems that the power consumption issue is not caused by
the i2c bus of the nrf52832.
Then i tried to disable  all the interupts of the i2c bus of the nrf52832. The issue does not take place.
I tried to delete the calling of the function : k_sem_take(&(get_dev_data(dev)->completion_sync),
I2C_TRANSFER_TIMEOUT_MSEC).  The issue does not take place.
So it seems that the interupts conflict with this function：k_sem_take. Maybe the interupts affect the power saving
strategy of the kernel.

To Reproduce
Steps to reproduce the behavior:

Find a nrf52 based board with some i2c devices
run the sample
Test the power cosumpertion
A nrf52832 based board without a i2c device is also can be used to reproduce the issue. Becase the errors can also
trigger an interupt.

A nrf52832 based board without a i2c device is also can be used to reproduce the issue. Becase the errors can also trigger
an interupt.

A nrf52832 based board without a i2c device is also can be used to reproduce the issue. Becase the errors can also trigger
an interupt.

@carlescufi  please assign

@carlescufi  please assign

@YoYo0304 A quick info from me, who has been developing on the nrf52832 - there's an errata 89 (https://infocenter.nordicsemi.com/index.jsp?topic=%2Ferrata_nRF52832_EngB%2FERR%2FnRF52832%2FEngineeringB%2Flatest%2Fanomaly_832_89.html) - power cycling the TWIM/SPIM register should help.
However, in doing so, the peripheral loses its configuration, and currently, there seems to be no way to re-initialize a device driver. From what I've gathered in Slack, there's an issue where this is being worked on.

There are at least two ways to workaround increased power consumption:

follow nrf52832 errata, as @dueringa mentioned; this means that i2c peripheral needs to be reinitialized before each i2c transfer, but such behavior needs changes in nrf i2c driver,
stop using GPIOTE; there is an open PR (#31823) to "emulate" edge interrupts using other GPIO capabilities in nRF.

@YoYo0304 can you try to switch from TWIM to TWI, i.e. set compatible = "nordic,nrf-twi"; instead of compatible = "nordic,nrf-twim"; in the devicetree node for the instance you are using?

authors: YoYo0304 anangl dueringa mniestroj nashif


text:
mimxrt1050_evk: failed to run samples/subsys/task_wdt

Describe the bug
failed to run samples/subsys/task_wdt
Logs and console output
*** Booting Zephyr OS build v2.7.99-1104-g27e44acda185  ***
Task watchdog sample application.
task wdt init failure: -22
[00:00:00.008,000] [1;31m<err> wdt_mcux_wdog: Invalid timeoutValue, valid (0.5s - 128.0s)[0m
[00:00:00.008,000] [1;31m<err> task_wdt: hw_wdt install timeout failed: -22[0m
Control thread started.
[00:00:01.007,000] [1;31m<err> wdt_mcux_wdog: No valid timeouts installed[0m
[00:00:01.007,000] [1;31m<err> wdt_mcux_wdog: Invalid channel id[0m
[00:00:01.007,000] [1;31m<err> wdt_mcux_wdog: Invalid channel id[0m
[00:00:01.057,000] [1;31m<err> wdt_mcux_wdog: Invalid channel id[0m
[00:00:01.107,000] [1;31m<err> wdt_mcux_wdog: Invalid channel id[0m
[00:00:01.157,000] [1;31m<err> wdt_mcux_wdog: Invalid channel id[0m
[00:00:01.207,000] [1;31m<err> wdt_mcux_wdog: Invalid channel id[0m
[00:00:01.257,000] [1;31m<err> wdt_mcux_wdog: Invalid channel id[0m
[00:00:01.307,000] [1;31m<err> wdt_mcux_wdog: Invalid channel id[0m
[00:00:01.358,000] [1;31m<err> wdt_mcux_wdog: Invalid channel id[0m
[00:00:01.408,000] [1;31m<err> wdt_mcux_wdog: Invalid channel id[0m
[00:00:01.458,000] [1;31m<err> wdt_mcux_wdog: Invalid channel id[0m
[00:00:01.508,000] [1;31m<err> wdt_mcux_wdog: Invalid channel id[0m
[00:00:01.558,000] [1;31m<err> wdt_mcux_wdog: Invalid channel id[0m
[00:00:01.608,000] [1;31m<err> wdt_mcux_wdog: Invalid channel id[0m
[00:00:01.658,000] [1;31m<err> wdt_mcux_wdog: Invalid channel id[0m
[00:00:01.708,000] [1;31m<err> wdt_mcux_wdog: Invalid channel id[0m
[00:00:01.758,000] [1;31m<err> wdt_mcux_wdog: Invalid channel id[0m
[00:00:01.808,000] [1;31m<err> wdt_mcux_wdog: Invalid channel id[0m
[00:00:01.859,000] [1;31m<err> wdt_mcux_wdog: Invalid channel id[0m
[00:00:01.909,000] [1;31m<err> wdt_mcux_wdog: Invalid channel id[0m
[00:00:01.959,000] [1;31m<err> wdt_mcux_wdog: Invalid channel id[0m
[00:00:02.009,000] [1;31m<err> wdt_mcux_wdog: Invalid channel id[0m
[00:00:02.059,000] [1;31m<err> wdt_mcux_wdog: Invalid channel id[0m
[00:00:02.109,000] [1;31m<err> wdt_mcux_wdog: Invalid channel id[0m
[00:00:02.159,000] [1;31m<err> wdt_mcux_wdog: Invalid channel id[0m
[00:00:02.209,000] [1;31m<err> wdt_mcux_wdog: Invalid channel id[0m
[00:00:02.259,000] [1;31m<err> wdt_mcux_wdog: Invalid channel id[0m
[00:00:02.309,000] [1;31m<err> wdt_mcux_wdog: Invalid channel id[0m
[00:00:02.360,000] [1;31m<err> wdt_mcux_wdog: Invalid channel id[0m
[00:00:02.410,000] [1;31m<err> wdt_mcux_wdog: Invalid channel id[0m
[00:00:02.460,000] [1;31m<err> wdt_mcux_wdog: Invalid channel id[0m
[00:00:02.510,000] [1;31m<err> wdt_mcux_wdog: Invalid channel id[0m
[00:00:02.560,000] [1;31m<err> wdt_mcux_wdog: Invalid channel id[0m
[00:00:02.610,000] [1;31m<err> wdt_mcux_wdog: Invalid channel id[0m
[00:00:02.660,000] [1;31m<err> wdt_mcux_wdog: Invalid channel id[0m
[00:00:02.710,000] [1;31m<err> wdt_mcux_wdog: Invalid channel id[0m
[00:00:02.760,000] [1;31m<err> wdt_mcux_wdog: Invalid channel id[0m
[00:00:02.810,000] [1;31m<err> wdt_mcux_wdog: Invalid channel id[0m
[00:00:02.861,000] [1;31m<err> wdt_mcux_wdog: Invalid channel id[0m
[00:00:02.911,000] [1;31m<err> wdt_mcux_wdog: Invalid channel id[0m
[00:00:02.961,000] [1;31m<err> wdt_mcux_wdog: Invalid channel id[0m
[00:00:03.011,000] [1;31m<err> wdt_mcux_wdog: Invalid channel id[0m
[00:00:03.061,000] [1;31m<err> wdt_mcux_wdog: Invalid channel id[0m
Control thread getting stuck...
[00:00:03.111,000] [1;31m<err> wdt_mcux_wdog: Invalid channel id[0m
[00:00:03.161,000] [1;31m<err> wdt_mcux_wdog: Invalid channel id[0m
[00:00:03.211,000] [1;31m<err> wdt_mcux_wdog: Invalid channel id[0m
[00:00:03.261,000] [1;31m<err> wdt_mcux_wdog: Invalid channel id[0m
[00:00:03.311,000] [1;31m<err> wdt_mcux_wdog: Invalid channel id[0m
[00:00:03.362,000] [1;31m<err> wdt_mcux_wdog: Invalid channel id[0m
[00:00:03.412,000] [1;31m<err> wdt_mcux_wdog: Invalid channel id[0m
[00:00:03.462,000] [1;31m<err> wdt_mcux_wdog: Invalid channel id[0m

Environment (please complete the following information):

OS: Linux
Toolchain zephyr-sdk-0.13.1

This failure is because the watchdog on the iMX RT SOC only supports timeouts in 500ms increments, and the task wdt sample defaults to a 100ms watchdog timeout window. I've update the sample to use a 500ms timeout window in #42601, and updated the iMX RT watchdog driver to provide a more useful error message when too short of a timeout value is used

authors: LixinGuoX danieldegrasse


text:
Intel CAVS: cavstool.py fails to extract complete log from winstream buffer when logging is frequent

Is your enhancement proposal related to a problem? Please describe.
(Below code is slightly changed from the cavstool.py to better describe the issue.)
There's no synchronization between cavstool.py running on host and the fw running on the board.
If the fw output logs frequently enough,  the line HERE 2 will seldom be satisfied. The log read will be re-attempted in the next while loop from the same last_seq.
As the log accumulates in the buffer, last_seq can be left too behind and  line HERE 1 will be triggered.
Then cavstool.py will be fast-forwarded and no log will be read.
The HERE 2 line is kind of a lock-free protocol. But it comes at a price. It places a limit on the frequency of log output.
Or in other words, the frequency the winstream header region can be updated.
No matter how big the winstream buffer size is, as long as the logging is frequent enough, logs will be lost.
def winstream_read(last_seq):
    while True:
        (wlen, start, end, seq) = win_hdr()
        if last_seq == 0:
            last_seq = seq if args.no_history else (seq - ((end - start) % wlen))
        if seq == last_seq or start == end:
            return (seq, "")
        behind = seq - last_seq
        if behind > ((end - start) % wlen): # <==================== HERE 1
            log.error(f"===fast forward")
            return (seq, "")
        copy = (end - behind) % wlen
        suffix = min(behind, wlen - copy)
        result = win_read(16 + copy, suffix)
        if suffix < behind: #sm: need to read wrap around.
            result += win_read(16, behind - suffix)
        (wlen, start1, end, seq1) = win_hdr()
        if start1 == start and seq1 == seq: # <=================== HERE 2
            # Best effort attempt at decoding, replacing unusable characters
            # Found to be useful when it really goes wrong
            log.error(f"===OK read to seq: {seq}") # sm debug
            return (seq, result.decode("utf-8", "replace"))
        else:
            lost_result = result
            log.error(f"===DSP side changed! = start =")
            log.error(f"===DSP side changed! {len(lost_result)}, seq = {seq}, seq1 = {seq1}")
            log.error(f"===DSP side changed! lost result: {lost_result}, ")
            log.error(f"===DSP side changed! = end =")

Such log missing can cause problems.
For example, the test/lib/mem_blocks  outputs a lot of logs in short time.
When running it with twister, the fw will update the winstream header region frequently, and 2 log reading attempts failed due to DSP side changed. If the total amount of logs is smaller than the size of the buffer. A wrap around doesn't happen. The complete log can still be salvaged after all the log is in the buffer. And buffer is in a steady state. But if a wrap around happens, cavstool.py will be left too behind and logs will be lost. And it'll be difficult for twister to determine the test result based on the logs.
ERROR:cavs-fw:===DSP side changed! = start =
ERROR:cavs-fw:===DSP side changed! 1581, seq = 1641, seq1 = 3024
ERROR:cavs-fw:===DSP side changed! lost result: b'*****\n*** Booting Zephyr OS build zephyr-v3.1.0-2139-g98a99183f5d2  (delayed boot 10000ms) ***\nRunning TESTSUITE  ... (omitted)
ERROR:cavs-fw:===DSP side changed! = end =

ERROR:cavs-fw:===DSP side changed! = start =
ERROR:cavs-fw:===DSP side changed! 2964, seq = 3024, seq1 = 5477
ERROR:cavs-fw:===DSP side changed! lost result: b'*** Booting Zephyr OS build zephyr-v3.1.0-2139-g98a99183f5d2  (delayed boot 10000ms) ***\nRunning TESTSUITE lib_mem_block\n============== ... (omitted)
ERROR:cavs-fw:===DSP side changed! = end =

ERROR:cavs-fw:===OK read to seq: 5477

For tests that failed for this reason, it's possible to capture the complete log by adding some extra delay between tests: https://github.com/zephyrproject-rtos/zephyr/pull/47779. But this is not fixing the root problem described in this issue. Just work around.
And there's another PR to add summary to ztest log output so that we can determine test result with less logs.
https://github.com/zephyrproject-rtos/zephyr/pull/48499

Closing this issue as it is being tracked by the affected parties.

Closing this issue as it is being tracked by the affected parties.


text:
wifi: esp32: build error due to WIFI_SCAN_TYPE_{ACTIVE,PASSIVE} redeclaration

Describe the bug
Both Zephyr:
enum wifi_scan_type {
	WIFI_SCAN_TYPE_ACTIVE = 0,
	WIFI_SCAN_TYPE_PASSIVE,
};

and hal_espressif:
typedef enum {
    WIFI_SCAN_TYPE_ACTIVE = 0,  /**< active scan */
    WIFI_SCAN_TYPE_PASSIVE,     /**< passive scan */
} wifi_scan_type_t;

repositories declare the same enumerators. This results in build failure:
In file included from /modules/hal/espressif/zephyr/esp32/../esp_shared/include/wifi/esp_networking_priv.h:9,
                 from /zephyr/drivers/wifi/esp32/src/esp_wifi_drv.c:20:
/modules/hal/espressif/zephyr/esp32/../../components/esp_wifi/include/esp_wifi_types.h:108:5: error: redeclaration of enumerator 'WIFI_SCAN_TYPE_ACTIVE'
  108 |     WIFI_SCAN_TYPE_ACTIVE = 0,  /**< active scan */
      |     ^~~~~~~~~~~~~~~~~~~~~
In file included from /zephyr/include/zephyr/net/wifi_mgmt.h:16,
                 from /zephyr/drivers/wifi/esp32/src/esp_wifi_drv.c:17:
/zephyr/include/zephyr/net/wifi.h:268:9: note: previous definition of 'WIFI_SCAN_TYPE_ACTIVE' with type 'enum wifi_scan_type'
  268 |         WIFI_SCAN_TYPE_ACTIVE = 0,
      |         ^~~~~~~~~~~~~~~~~~~~~
/modules/hal/espressif/zephyr/esp32/../../components/esp_wifi/include/esp_wifi_types.h:109:5: error: redeclaration of enumerator 'WIFI_SCAN_TYPE_PASSIVE'
  109 |     WIFI_SCAN_TYPE_PASSIVE,     /**< passive scan */
      |     ^~~~~~~~~~~~~~~~~~~~~~
/zephyr/include/zephyr/net/wifi.h:269:9: note: previous definition of 'WIFI_SCAN_TYPE_PASSIVE' with type 'enum wifi_scan_type'
  269 |         WIFI_SCAN_TYPE_PASSIVE,
      |         ^~~~~~~~~~~~~~~~~~~~~~
/zephyr/drivers/wifi/esp32/src/esp_wifi_drv.c: In function 'esp32_wifi_scan':
/zephyr/drivers/wifi/esp32/src/esp_wifi_drv.c:409:28: error: invalid type argument of '->' (have 'wifi_scan_config_t')
  409 |                 scan_config->scan_type = params->scan_type;
      |                            ^~

This is a regression introduced by 69fead199828a418c31a2f4f8362e6d94dc703ef which was part of #59204.
To Reproduce
Steps to reproduce the behavior:

west build -b esp32 samples/net/wifi
See error

Expected behavior
WiFi driver for ESP32 platform should build without issue.
Impact
Showstopper for using WiFi on ESP32 platform with Zephyr.
Environment (please complete the following information):

OS: Linux
Toolchain: Zephyr SDK 0.16.0
Commit SHA: 33b116407b03883efd889f75d69f5bc753b7ade3

Fixed by https://github.com/zephyrproject-rtos/zephyr/pull/59995

Fixed by #59995

No, it is not fixed. Referenced issue is fixing something else (though related).

Apologies, you're right.
It seems that @marekmatej has already handled the name collision on the ESP side (https://github.com/zephyrproject-rtos/hal_espressif/commit/d5a8fc861136abe74f05f56fad5738477a9985d2) so we'll need to wait for the hal_espressiff revision update in Zephyr.

The issue was fixed on hal_espressif and already merged. Unfortunately, the fix commit sits on the top of changes that need https://github.com/zephyrproject-rtos/zephyr/pull/58454 in order to work.

authors: marekmatej mniestroj rlubos


text:
boards: up_squared: fixes build errors and include it in sanitycheck

Due to earlier DTS changes, the names of GPIO macros have also changed. So update the necessary bits to refer to the new naming. Also updated the sample.yaml so that GPIO sample will be built by sanitycheck.

Codecov Report

Merging #11006 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #11006   +/-   ##
=======================================
  Coverage   53.21%   53.21%
=======================================
  Files         217      217
  Lines       26667    26667
  Branches     5913     5913
=======================================
  Hits        14192    14192
  Misses      10059    10059
  Partials     2416     2416

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa2bdbe...439def5. Read the comment docs.

authors: codecov-io dcpleung


text:
LD: arm: bootloader: Support injecting bootloader metadata

Out-of-tree ARM bootloaders need a mechanism to place image metadata
at a specific offset into the flash. This is now implemented in a
bootloader-agnostic way through Kconfig and the cortex_m linker
script.
Signed-off-by: Sebastian Bøe sebastian.boe@nordicsemi.no

Codecov Report

Merging #12161 into master will decrease coverage by 0.05%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #12161      +/-   ##
==========================================
- Coverage   48.11%   48.06%   -0.06%
==========================================
  Files         284      284
  Lines       43383    43383
  Branches    10397    10397
==========================================
- Hits        20875    20853      -22
- Misses      18368    18389      +21
- Partials     4140     4141       +1

Impacted Files
Coverage Δ

subsys/logging/log_core.c
74.67% <0%> (-7.87%)
:arrow_down:

subsys/logging/log_msg.c
86.36% <0%> (-2.28%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fcc7240...7b0dce5. Read the comment docs.

Closing as the user no longer needs this.

authors: SebastianBoe codecov-io


text:
boards: hifive1: Added flash runner

Signed-off-by: Timon Baetz timon.baetz@gmail.com

Sure, but this is duplicating a file identically that is part of openocd. So not sure what the value of doing that is.

which file is this duplicating? This file additional has the gdb stubs, those are not in openocd. This file can also be used to add commands that are not in the default provided by openocd.

I updated the pull request yesterday evening and replaced the content of the cgf file with source [find board/sifive-hifive1.cfg]

I did some more testing on different platforms. It seems to work fine with both the Zephyr SDK and custom toolchains (with the 9.5 version of the SDK you still need the -DOPENOCDparameter)

authors: nashif timbz


text:
boards: mimxrt*: Temporarily disable Ethernet [REVERT ME]

Many of the networking PRs are failing in these boards because
of this build error:
ERROR: section nocache is 128 bytes in the virtual/runtime address
space, but only 0 in the loaded/XIP section!
See #16778 for details.
So temporarily disable Ethernet support so that unrelated PRs can
be merged. This should be reverted after the root cause is found
and #16778 is fixed.
Signed-off-by: Jukka Rissanen jukka.rissanen@linux.intel.com

We have been agreeing already that the whitelisting in various networking tests should be removed. So if some board is no longer working properly, then we should avoid trying to compile that board. Easiest way is to disable sanitychecker to use that board for networking tests that want ethernet interface.

So if some board is no longer working properly, then we should avoid trying to compile that board.

You know, I'm a big proponent of such solutions. If you're too, then I wonder why my proposal to disable misbehaving sam_e70_xplained boards wasn't supported for ~half a year?

Easiest way is to disable sanitychecker to use that board for networking tests that want ethernet interface.

That's the problem with this change - the config for this board says that it has Ethernet, and that's true, it has, on hardware level. You change says that it doesn't have Ethernet, which is well, not true. If you want to disable that board by blacklisting it from particular tests, I'm +1 right away.

You change says that it doesn't have Ethernet, which is well, not true.

And besides, the build failure doesn't even happen because of the Ethernet, it happens with some link-time helper script.

I just want to the PRs to progress and get merged. If there is proper fix, that is just fine. I do not want to start to add the whitelists again to multiple PRs if there is a simple and temporary workaround.

No need for this as #16923 solves the issue.

authors: jukkar pfalcon


text:
Bluetooth: Mesh: Add Config Client API

The api is used to reset a node (other than a Provisioner) and
remove it from the network
Signed-off-by: YanBiao Hao haoyanbiao@xiaomi.com

In addition to the other comments: Please recheck your sign-off line format again. There should generally only be one, and it should match the commit author email. It should also be preceded by a blank line.

@haoyanbiao if you don't mind, I'll amend the commit to clear the status, so we can get this merged

@haoyanbiao if you don't mind, I'll amend the commit to clear the status, so we can get this merged

There is a lot of work to do recently. sorry about that I didn't check your information in time. Of course, you can modify it directly

Other LGTM 👍

authors: LingaoM haoyanbiao trond-snekvik


text:
kernel: drop unused priority related definitions

Hi, this drops a couple of seemingly obsolete and unused defines, and two Kconfig comments that do not seem to apply anymore since https://github.com/zephyrproject-rtos/zephyr/commit/1acd8c2996c3a1ae0691247deff8c32519307f17.

@andyross @dcpleung could you please review?

authors: carlescufi fabiobaltieri


text:
doc: dts: clear up DTC_OVERLAY_FILE

Make it clearer that you can set it explicitly or the build system
will try to set it for you, and try to make it clearer what the build
system is doing when it tries to set it on your behalf.
Signed-off-by: Martí Bolívar marti.bolivar@nordicsemi.no

cc @marinjurjevic

If you don't set :makevar:DTC_OVERLAY_FILE, the build system will try to set
it by looking in your application source directory for these files:

This sentence should clear all ambiguity. LGTM!

Updated to address feedback, and also mentioned shields.

Just added 2 small suggestions, but in general LGTM

Just added 2 small suggestions, but in general LGTM

https://github.com/zephyrproject-rtos/zephyr/pull/40489 addresses these, thanks.


text:
Rpmsg demo - imx8mm

In this pull request, we merge the pull-request 42320, and customize it for imx8mm.
In addition, we created a customized version of the sample openamp_rsc_table that manage to establish an inter-processor communication between A53 and M4.
On the A53 we run Yocto as OS.
The kernel module imx_rpmsg_tty need to be active on the A53.

modprobe imx_rpmsg_tty

Once the application starts on the M4, the A53 installs the tty driver to enable communication over the channel /dev/ttyRPMSG1024.

Please fix the commit-messages and make the driver changes an own commit.

Hello @arnopo. I saw that you were one of the contributors for the resource table example, do you have some advice?
Thanks for your help.

Hello @arnopo. I saw that you were one of the contributors for the resource table example, do you have some advice? Thanks for your help.

Hello @andrecmilano
Sure I can give some advice, but i can't guaranty that you will like them ;-)
First of all very nice to see another platform implementing the resource table!
Before reviewing in detail the sample i have few questions/comments
Regarding your sample:
-It looks very similar to the https://github.com/zephyrproject-rtos/zephyr/tree/main/samples/subsys/ipc/openamp_rsc_table
Do you think it could be possible to merge both in one? Only the name channel, the CB and the app thread should be different.
And using a config to enable channel.
I did something in this way for OpenAMP demos here.
I can't upstream this for time being because need some cleans and a part of the code need to wait that some Linux Kernel upstream are accepted ( rpmsg_char reworking).
If you decide to go in this way, I can crosscheck that update will be compatible with stm32mp1 platform.

Since the Linux Kernel 5.16 there is a generic rpmsg_tty driver. Could be nice to at least support it in addition of the IMX one. The delta from zephyr's point of view is mainly a channel name, I guess.

Regarding the rpmsg_service layer introduced by @carlocaione:

would be nice to relying on it, especially if you introduce a new sample. But this imply to port the resource table support as a new backend of the rpmsg_service.
I am delinquent on this part. This is something that I have in mind for the openamp_rsc_table but not bandwidth to work on it.

Regards,
Arnaud

Regarding the rpmsg_service layer introduced by @carlocaione:

Just for the sake of clarity I introduced the IPC service but the point stands :)

No issue to create several endpoints with different channel name, the Linux create an associated device and then probe the driver only if a match is found. We can also duplicate the callbacks and tasks if needed
As a first step I can create a PR to restructure the application part to add a manager task in charge of the message reception, This would simplify the introduction of multi channels: arnopo@23a6253

That sounds good to me. I can then add a new endpoint for the specific channel name.

Yes would be nice. If you are Ok to move forward in this way, I can adapt the ST part to match with the evolution you would propose.

That is perfect.
I am working on cleaning up this pull request, I will keep only the minimal changes needed.

we used the vring information directly from the device tree
...
For your information a DT design similar to Linux already exits

Yeah, a lot of work went into IPC service and TBH seeing people still trying to reinvent the wheel is a bit discouraging.

we used the vring information directly from the device tree
...
For your information a DT design similar to Linux already exits

Yeah, a lot of work went into IPC service and TBH seeing people still trying to reinvent the wheel is a bit discouraging.

Fully agree with you @carlocaione that the proper implementation would be to migrate on top of  IPC service with a backend managing the resource table (As mentioned in https://github.com/zephyrproject-rtos/zephyr/pull/42967#issuecomment-1047141970). Unfortunately not bandwidth on my side yet to do this :-(.
that's why I'm trying to find a intermediate step that, at minimum, ease the future migration...
Or do you consider that it is a must in short term for new rpmsg samples or evolutions?

Fully agree with you @carlocaione that the proper implementation would be to migrate on top of IPC service with a backend managing the resource table (As mentioned in #42967 (comment)). Unfortunately not bandwidth on my side yet to do this :-(.

Definitely not trying to give you more work and I didn't mean that you were supposed to be in charge of this work :) I already greatly appreciate the time you spend in reviewing the Zephyr patches.

that's why I'm trying to find a intermediate step that, at minimum, ease the future migration... Or do you consider that it is a must in short term for new rpmsg samples or evolutions?

No, I'm definitely not in the position to say what it is a must and what it is not. It is undeniable that leveraging the current samples is easier than writing a new backend from scratch for the IPC service, so I cannot blame people really.
What we can do (and you did rightfully so) is to point out that another alternative does exist that already tried to solve many of the same issues and pray that someone would be willing to do the job (at least as long as I don't find the time myself) :)

No issue to create several endpoints with different channel name, the Linux create an associated device and then probe the driver only if a match is found. We can also duplicate the callbacks and tasks if needed
As a first step I can create a PR to restructure the application part to add a manager task in charge of the message reception, This would simplify the introduction of multi channels: arnopo@23a6253

That sounds good to me. I can then add a new endpoint for the specific channel name.

Done in https://github.com/zephyrproject-rtos/zephyr/pull/43114

authors: alexanderwachter andrecmilano arnopo carlocaione


text:
Bluetooth: Audio - internal changes to media proxy instance structure

Updates an include guard, and moves a callback struct inside the media proxy instance struct.
closes https://github.com/zephyrproject-rtos/zephyr/issues/41201

Rebased on main with no changes.


text:
Bluetooth: Mesh: add check for rx buffer overflow in pb adv

There is a potential buffer overflow in pb adv.
If Transaction Continuation PDU comes before
Transaction Start PDU the last segment number is set to 0xff.
The current implementation has a buffer only for 2 segments.
It is possible to receive a malformed frame with the wrong segment
number. All segments with number 2 and above will be stored
in the memory behind Rx buffer.
Signed-off-by: Aleksandr Khromykh Aleksandr.Khromykh@nordicsemi.no

Why was this closed?

Why was this closed?

There were some issues with it. I created another PR with the same changes. https://github.com/zephyrproject-rtos/zephyr/pull/45066

authors: alxelax jhedberg