text:
New qmk

Motivation for this change
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 127863 run on x86_64-linux 1

3 packages failed to build:

python38Packages.hid
python39Packages.hid
qmk

2 packages built:

python38Packages.milc
python39Packages.milc

It is good to see you are back into working on this. Frankly I did not understand what they were trying to do in the other PR.

It looks like hid needs some extra dependencies during the check phase?
error: builder for '/nix/store/76zibvn0w8cj6py3qa0r64xf7cd0df9x-python3.8-hid-1.0.4.drv' failed with exit code 1;
       last 10 log lines:
       >   File "/build/hid-1.0.4/hid/__init__.py", line 30, in <module>
       >     raise ImportError(error)
       > ImportError: Unable to load any of the following libraries:libhidapi-hidraw.so libhidapi-hidraw.so.0 libhidapi-libusb.so libhidapi-libusb.so.0 libhidapi-iohidmanager.so libhidapi-iohidmanager.so.0 libhidapi.dylib hidapi.dll libhidapi-0.dll
       >
       > ----------------------------------------------------------------------
       > Ran 1 test in 0.005s
       >
       > FAILED (errors=1)
       > Test failed: <unittest.runner.TextTestResult run=1 errors=1 failures=0>
       > error: Test failed: <unittest.runner.TextTestResult run=1 errors=1 failures=0>

ImportError: Unable to load any of the following libraries:libhidapi-hidraw.so libhidapi-hidraw.so.0 libhidapi-libusb.so libhidapi-libusb.so.0 libhidapi-iohidmanager.so libhidapi-iohidmanager.so.0 libhidapi.dylib hidapi.dll libhidapi-0.dll

This is the part I am not understanding. It tries to load the libraries above from hidapi. They were installed (just ls /nix/store | grep hidapi looks OK) but hid Python package does not find it.
https://github.com/apmorton/pyhidapi/blob/5a872c81cf8034c011f215b5bca672762df030b4/hid/__init__.py#L9

Is setting doCheck = false an option for hid package? :smiley:

Nope. This is not a mere stress test.
It is something like #include <stdio.h> in a filesystem without a libc.

It looks like pyusb patches itself, as does hidapi

hidapi is not the same as hid.
At least not for Python Package Index.

hidapi is not the same as hid.
At least not for Python Package Index.

No, but they both seem to rely on libhid, as does pyusb.
I'm not familiar with python though, so I do not know how the library search happens. Is there an environment variable to set to include libhid in a search path?

@AndersonTorres I looked into this a little more and for hid's check phase to pass, ${hidapi}/lib needs to be in the LD_LIBRARY_PATH. else python can't find the libraries to load.
I'm not 100% sure how the right way to get it there is, and probably persist it to runtime (maybe @jonringer knows the way?)

@afontaine many thanks! I have worked out the script.

If I am not wrong yet, qmk CLI can do everything except compilation.
Now comes the most confusing part: how to deal with the cross compilers.

I can think of two ways to solve this problem.
Packaging qmk_firmware and including qmk as a dependency for it. qmk_firmware should compile all of the firmwares by default, but it also should have an overridable attribute set. Keyboard files will be copied into the nix store and built alongside firmware files. Custom keyboard users will preferably use an overlay to build a crafted firmware and then get the hex file from  nix store to flash it. qmk flash is still unusable with this approach.
packageOverrides = super: let self = super.pkgs; in {
  myQMK = pkgs.qmk_firmware.override {
    customLayout = true;
    customSrc = fetchFromGitHub { ... };
    customDst = "keyboads/ergodox_ez/keymaps/bb2020";
    customPreBuild = "qmk json2c layout.json >keymap.c";

    makeFlags = "qmk compile -kb ergodox_ez -km bb2020";
  }
}

Another solution would be pushing QMK's shell.nix into nixpkgs and making it work without triggering any compilation (especially gcc). This approach would be similar to androidenv. This is also problematic because there will be inconsistency between qmk_firmware fork and build tools. It is because every time the fork is pulled from upstream, one should call qmk setup to update the build environment.

Packaging qmk_firmware and including qmk as a dependency for it. qmk_firmware should compile all of the firmwares by default, but it also should have an overridable attribute set.

It is unusual that the original source code would be compiled in its entirety. Even because there are entire sections of that huge tree that do not compile at all (the original nixpkgs expression removed them completely).
Further, the firmwares are efemeral: they are generated, flashed and discarded. Therefore it does not make sense so much sense to cache the results of this compilation (and I tell you, it is a big and sluggish compilation) inside /nix/store/. Packaging qmk_firmware this way is counterproductive.
Also, the README of QMK says that QMK can work with other trees besides the original QMK Firmware. Indeed, many custom keyboard and mouse distributors release their modified QMK trees without merging them directly into the original one.
For the reasons above I do not think a qmk_firmware package is a good approach.

This is also problematic because there will be inconsistency between qmk_firmware fork and build tools. It is because every time the fork is pulled from upstream, one should call qmk setup to update the build environment.

How do this affect qmk_cli?

I agree, I don't think it makes sense to have a qmk_firmware package.
I think a build.nix script within the qmk_firmware project could be interesting though 🤔 and that we should add this bumped qmk_cli as a buildInput for the existing shell.nix file.

A Nix file inside qmk_firmware upstream source tree? it would be great!

I think it should be in nixpkgs because the way I see it, shell.nix in qmk_firmware is almost always outdated. Furthermore it starts to build gcc from scratch when it is initiated.

Also, the README of QMK says that QMK can work with other trees besides the original QMK Firmware. Indeed, many custom keyboard and mouse distributors release their modified QMK trees without merging them directly into the original one.

This can be worked out by overriding package src. As long as dependencies are the same, nix package can build their tree too.

How do this affect qmk_cli?

It doesn't but, we still can't build the firmware with current qmk_cli. :smiley:

A Nix file inside qmk_firmware upstream source tree? it would be great!

There's already a shell.nix! what's one more? :wink:
@bb2020 maybe this would make more sense as a convenient builder as opposed to a package?
Even then, though, how do you envision the workflow? I think that might help find the best path forward.

@bb2020 maybe this would make more sense as a convenient builder as opposed to a package?
Even then, though, how do you envision the workflow? I think that might help find the best path forward.

Yes, it is much better. For example, a new package called qmk-builder that exposes a wrapper named qmk-shell that spawns mkShell. The shell includes cross compilers (avr, arm, teensy), python packages and qmk-cli in its environment so I can descent into a qmk_firmware fork and call qmk build. But is this doable? If it starts to compile build tools from ground up then it will be worthless for newcomers.

But is this doable? If it starts to compile build tools from ground up then it will be worthless for newcomers.

I am not following you here. Are you saying that in every invocation of it, the cross toolchains would be rebuilt from scratch?
As far as I remember, Nix caches the built artifacts at /nix/store. It would happen once and never more (except maybe in subsequent GCC updates).

I am not following you here. Are you saying that in every invocation of it, the cross toolchains would be rebuilt from scratch?
As far as I remember, Nix caches the built artifacts at /nix/store. It would happen once and never more (except maybe in subsequent GCC updates).

Of course, it caches the output. But the last time I tried to use shell.nix on my cheap laptop, it tooks days to build gcc :rofl:

Well, in this case the best we can do is ask Hydra maintainers to cache it for those of us with Pentium III machines...

This can be worked out by overriding package src. As long as dependencies are the same, nix package can build their tree too.

But it should be almost the same as rewriting the qmk clone functionality.

It doesn't. We still can't build the firmware with current qmk_cli though.

Then it is not the reason why qmk cli can't compile the firmwares.

Then it is not the reason why qmk cli can't compile the firmwares.

Dosen't qmk_cli just calls bin/qmk?
Shell approach is much better if some packages like pkgsCross.avr.libcCross can be cached.
For example, gcc-arm-embedded is cached by Hydra and available instantly in the environment.

Doesn't qmk_cli just calls bin/qmk?

https://github.com/qmk/qmk_firmware/blob/master/bin/qmk#L37

Shell approach is much better if some packages like pkgsCross.avr.libcCross can be cached.
For example, gcc-arm-embedded is cached by Hydra and available instantly in the environment.

Yes, and I think we can/should provide it inside Nixpkgs tree.

That would be great. It was always my dream to be able to update my keyboard under NixOS.

Well, that being said, I think it suffices to an official upgrade. We can treat the qmk-shell.nix project later.

Next phase: shell.nix for a full QMK hacking environment!

authors: AndersonTorres afontaine bb2020


text:
python38Packages.pygame-gui: 0.5.7 -> 057

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for python38Packages.pygame-gui is: "A GUI system for pygame"
meta.homepage for python38Packages.pygame-gui is: "https://github.com/MyreMylar/pygame_gui"
meta.changelog for python38Packages.pygame-gui is: ""
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS

The tests defined in passthru.tests, if any, passed

0 of 0 passed binary check by having a zero exit code.

0 of 0 passed binary check by having the new version present in output.

found 057 with grep in /nix/store/mmis2cx080zpgfkcz8gq5f3wc2wd6n6w-python3.8-pygame-gui-057

found 057 in filename of file in /nix/store/mmis2cx080zpgfkcz8gq5f3wc2wd6n6w-python3.8-pygame-gui-057

directory tree listing: https://gist.github.com/adfda9a3c84dbe5b3b2a143e1367a337

du listing: https://gist.github.com/0904f30b73ba129dbc327e63b8fce441

Rebuild report (if merged into master) (click to expand)

8 total rebuild path(s)

2 package rebuild(s)

2 x86_64-linux rebuild(s)
2 i686-linux rebuild(s)
2 x86_64-darwin rebuild(s)
2 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
python38Packages.pygame-gui
python39Packages.pygame-gui

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/mmis2cx080zpgfkcz8gq5f3wc2wd6n6w-python3.8-pygame-gui-057 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A python38Packages.pygame-gui https://github.com/r-ryantm/nixpkgs/archive/06a1e872062a84e31aa464436e8ad7f47215969f.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/mmis2cx080zpgfkcz8gq5f3wc2wd6n6w-python3.8-pygame-gui-057
ls -la /nix/store/mmis2cx080zpgfkcz8gq5f3wc2wd6n6w-python3.8-pygame-gui-057/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

2 packages built:

python38Packages.pygame-gui
python39Packages.pygame-gui

Maintainer pings
cc @angustrau for testing.

This looks like it might be a false version bump?

Result of nixpkgs-review pr 137667 at 06a1e872 run on aarch64-linux 1

2 packages built successfully:

python38Packages.pygame-gui
python39Packages.pygame-gui

@rya

source: gharchive/pull-request

authors: SuperSandro2000 angustrau r-rmcgibbo r-ryantm

repo: NixOS/nixpkgs

license: MIT

license_type: permissive

license_source: github-api


text:
vsce/zxh404.vscode-proto3: init at 0.5.4

Motivation for this change
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

@ofborg build vscode-extensions.zxh404.vscode-proto3

Result of nixpkgs-review pr 139593 run on x86_64-linux 1

1 package built:

vscode-extensions.zxh404.vscode-proto3

authors: deviant figsoda


text:
[21.05] nvidia_x11_beta: 456.27 -> 495.29.05

Motivation for this change
Backport beta bumps to nvidia drivers. Should allow for new gbm backend.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

21.05 is now EOL


text:
python3Packages.hidapi: 0.10.1 -> 0.11.0.post2

Motivation for this change

version update

Things done

Built on platform(s)

[ ] x86_64-linux
[x] aarch64-linux
[ ] x86_64-darwin
[x] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
Result of nixpkgs-review pr 142073 run on x86_64-linux 1

1 package marked as broken and skipped:

plover.stable

2 packages failed to build and already failed to build on hydra master:

python38Packages.ledgerwallet: log was empty
python39Packages.ledgerwallet: log was empty

32 packages built:

cm-rgb
electron-cash
electrum
electrum-ltc
hwi (python39Packages.hwi)
keepkey_agent (python39Packages.keepkey_agent)
ledger_agent (python39Packages.ledger_agent)
liquidctl (python39Packages.liquidctl)
onlykey-agent
onlykey-cli
python38Packages.bitbox02
python38Packages.btchip
python38Packages.ckcc-protocol
python38Packages.hidapi
python38Packages.hwi
python38Packages.keepkey
python38Packages.keepkey_agent
python38Packages.ledger_agent
python38Packages.ledgerblue
python38Packages.liquidctl
python38Packages.python-u2flib-host
python38Packages.trezor
python38Packages.trezor_agent
python39Packages.bitbox02
python39Packages.btchip
python39Packages.ckcc-protocol
python39Packages.hidapi
python39Packages.keepkey
python39Packages.ledgerblue
python39Packages.python-u2flib-host
trezorctl (python39Packages.trezor)
trezor_agent (python39Packages.trezor_agent)


text:
zsh-vi-mode: init at v0.8.5

Adding zsh-vi-mode at version 0.8.5.
Motivation for this change
Upstreaming the zsh-vi-mode package derivation I've been using locally for a while.
Things done

Built on platform(s)

[x] x86_64-linux
[x] aarch64-linux
[x] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[X] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[X] Fits CONTRIBUTING.md.

You need to add this package on pkgs/top-level/all-packages.nix

Fixed. Thanks for being patient while I figure out the packaging.

Result of nixpkgs-review pr 146272 run on x86_64-linux 1

1 package built:

zsh-vi-mode

authors: KyleOndy thiagokokada


text:
nixos/ssh: add programs.ssh.knownHostsFiles option

The programs.ssh.knownHosts.*.publicKeyFile is broken, because it's
scoped to a set of host names, but to insert those host names on each
line of the file we'd have to parse out blank lines and comments, so
only the first line works.  It would be much easier all round if users
just provided known hosts files in the normal format, and we pointed
ssh directly to them.  This way, it would be possible to have multiple
keys for a single host (which is extremely common due to multiple
algorithms being commonplace).
We add an option for this instead of relying on extraConfig, because
we need to make sure /etc/ssh/ssh_known_hosts is always included to
ensure programs.ssh.knownHosts keeps working.
/etc/ssh/ssh_known_hosts2 is another OpenSSH default that seems a bit
weird, but there's no real reason to change that so we'll leave it.

Motivation for this change
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

/etc/ssh/ssh_known_hosts2 is another OpenSSH default that seems a bit
weird, but there's no real reason to change that so we'll leave it.

that file is a legacy artifact from when openssh protocol V2 https://salsa.debian.org/ssh-team/openssh/-/blob/master/pathnames.h#L30


text:
cpplint: 1.5.1 -> 1.5.5

Motivation for this change
Upstream pinned pytest-runner to version 5.2 to remain compatible for Python 2. Since the nixpkgs cpplint package builds only for Python 3, I have removed this version requirement so that it would build with the more recent version of pytest-runner present in nixpkgs.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review --run "nixpkgs-review pr 147004"
1 package built: cpplint


text:
python3Packages.python-opendata-transport: 0.2.2 -> 0.3.0

Motivation for this change
Update to latest upstream release 0.3.0
Change log: https://github.com/home-assistant-ecosystem/python-opendata-transport/releases/tag/0.3.0
Fix build (https://hydra.nixos.org/build/159221470)
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 147240 run on x86_64-linux 1

2 packages built:

python38Packages.python-opendata-transport
python39Packages.python-opendata-transport


text:
python38Packages.aioymaps: 1.2.1 -> 1.2.2

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for python38Packages.aioymaps is: "Python package fetch data from Yandex maps"
meta.homepage for python38Packages.aioymaps is: "https://github.com/devbis/aioymaps"
meta.changelog for python38Packages.aioymaps is: ""
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS

The tests defined in passthru.tests, if any, passed

0 of 0 passed binary check by having a zero exit code.

0 of 0 passed binary check by having the new version present in output.

found 1.2.2 with grep in /nix/store/qizcrxkgg6wy903rgk0y14yskdzq7589-python3.8-aioymaps-1.2.2

found 1.2.2 in filename of file in /nix/store/qizcrxkgg6wy903rgk0y14yskdzq7589-python3.8-aioymaps-1.2.2

Rebuild report (if merged into master) (click to expand)

7 total rebuild path(s)

4 package rebuild(s)

4 x86_64-linux rebuild(s)
3 x86_64-darwin rebuild(s)

First fifty rebuilds by attrpath
docbookrx
home-assistant
python38Packages.aioymaps
python39Packages.aioymaps

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/qizcrxkgg6wy903rgk0y14yskdzq7589-python3.8-aioymaps-1.2.2 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A python38Packages.aioymaps https://github.com/r-ryantm/nixpkgs/archive/e56dc97efe7af6112244a298f3994959faa11377.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/qizcrxkgg6wy903rgk0y14yskdzq7589-python3.8-aioymaps-1.2.2
ls -la /nix/store/qizcrxkgg6wy903rgk0y14yskdzq7589-python3.8-aioymaps-1.2.2/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package failed to build:

home-assistant

2 packages built:

python38Packages.aioymaps
python39Packages.aioymaps

Maintainer pings
cc @fabaff for testing.

Part of #150420.

#150420 has been merged

authors: bobby285271 mweinelt r-ryantm


text:
sope: 5.3.0 -> 5.4.0

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/sope/versions.
meta.description for sope is: "An extensive set of frameworks which form a complete Web application server environment"
meta.homepage for sope is: "https://github.com/inverse-inc/sope"
meta.changelog for sope is: ""
Updates performed

Version update

To inspect upstream changes

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
/nix/store/gcb6874844pnqlml8d2mjfm6s2aziywd-sope-5.4.0/bin/load-EOAdaptor passed the binary check.
/nix/store/gcb6874844pnqlml8d2mjfm6s2aziywd-sope-5.4.0/bin/connect-EOAdaptor passed the binary check.
/nix/store/gcb6874844pnqlml8d2mjfm6s2aziywd-sope-5.4.0/bin/wod passed the binary check.
1 of 3 passed binary check by having a zero exit code.
2 of 3 passed binary check by having the new version present in output.
found 5.4.0 with grep in /nix/store/gcb6874844pnqlml8d2mjfm6s2aziywd-sope-5.4.0
found 5.4.0 in filename of file in /nix/store/gcb6874844pnqlml8d2mjfm6s2aziywd-sope-5.4.0

Rebuild report (if merged into master) (click to expand)

4 total rebuild path(s)

3 package rebuild(s)

3 x86_64-linux rebuild(s)
1 x86_64-darwin rebuild(s)

First fifty rebuilds by attrpath
docbookrx
sogo
sope

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/gcb6874844pnqlml8d2mjfm6s2aziywd-sope-5.4.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A sope https://github.com/r-ryantm/nixpkgs/archive/d03e0c14058a608d4df0019e464ceadb282d75d8.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/gcb6874844pnqlml8d2mjfm6s2aziywd-sope-5.4.0
ls -la /nix/store/gcb6874844pnqlml8d2mjfm6s2aziywd-sope-5.4.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

2 packages built:

sogo
sope

Maintainer pings
cc @ajs124 @dasJ for testing.

this should be bumped together with sogo


text:
python3Packages.pywilight: 0.0.70 -> 0.0.73

Motivation for this change
Update to latest upstream release 0.0.73
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

@ofborg build home-assistant


text:
vimPlugins.onedark-nvim: etc

Motivation for this change

pkgs.vimPlugins.onedark-nvim now refers to navarasu/onedark.nvim (formerly refers to olimorris/onedarkpro.nvim).

Fixes https://github.com/NixOS/nixpkgs/pull/153045#discussion_r781641557.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
-> Somehow the test fails:
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[x] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[x] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

$ nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"

$ git -c fetch.prune=false fetch --no-tags --force https://github.com/NixOS/nixpkgs master:refs/nixpkgs-review/0
From https://github.com/NixOS/nixpkgs
   e90cc18e09c..0eee9d1067c  master     -> refs/nixpkgs-review/0
$ git worktree add /home/sei40kr/.cache/nixpkgs-review/rev-cb3eb553e409183e857b5ba5e40d6f7ec63d69d3/nixpkgs 0eee9d1067cf5d7f0c49b5b16fe89b09e5f3f105
Preparing worktree (detached HEAD 0eee9d1067c)
Updating files: 100% (29265/29265), done.
HEAD is now at 0eee9d1067c Merge pull request #154403 from willcohen/zsh-darwin
$ nix-env --option system x86_64-linux -f /home/sei40kr/.cache/nixpkgs-review/rev-cb3eb553e409183e857b5ba5e40d6f7ec63d69d3/nixpkgs -qaP --xml --out-path --show-trace
$ git merge --no-commit --no-ff cb3eb553e409183e857b5ba5e40d6f7ec63d69d3
Automatic merge went well; stopped before committing as requested
$ nix-env --option system x86_64-linux -f /home/sei40kr/.cache/nixpkgs-review/rev-cb3eb553e409183e857b5ba5e40d6f7ec63d69d3/nixpkgs -qaP --xml --out-path --show-trace --meta
2 packages updated:
nixos-install-tools spacevim

$ nix --experimental-features nix-command build --no-link --keep-going --option build-use-sandbox relaxed -f /home/sei40kr/.cache/nixpkgs-review/rev-cb3eb553e409183e857b5ba5e40d6f7ec63d69d3/build.nix
1 package blacklisted:
nixos-install-tools

1 package built:
spacevim

error: build log of '/nix/store/iqbh28cx0yf0ji2dkaxkgc74dd59cg1j-nixos-install-tools-22.05pre-git.drv' is not available
error: build log of '/nix/store/njvq8rr7i0vzfhnzyf2rgl96g6hb1c6z-nixos-install-tools-22.05pre-git' is not available
$ nix-shell /home/sei40kr/.cache/nixpkgs-review/rev-cb3eb553e409183e857b5ba5e40d6f7ec63d69d3/shell.nix

@jonringer
I resolved the conflicts.


text:
[Backport release-21.11] vengi-tools: 0.0.14 -> 0.0.18 and related changes

Motivation for this change
https://github.com/NixOS/nixpkgs/pull/158094#issuecomment-1029930182 cc @turion
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[x] (Package updates) Added a release notes entry if the change is major or breaking
[x] (Module updates) Added a release notes entry if the change is significant
[x] (Module addition) Added a release notes entry if adding a new NixOS module
[x] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

ofborg bot added the ofborg-internal-error label 1 minute ago

...did I do something wrong?

@GrahamcOfBorg eval

This looks fine to me, but I've never merged a nontrivial backport PR, so I'd like to have some other committer's opinion.

ofborg bot added the ofborg-internal-error label 1 minute ago

...did I do something wrong?

Nah, this is usually something GitHub did (i.e. sending API responses without required fields). It's just labeled so I can (eventually) check it out and make sure that's what it is, and not some silent API changes we'll have to accommodate.

/marvin opt-in
/status needs_rewiewer

/status needs_rewiewer

/status needs_reviewer
Too many "w"s :sweat_smile:

/status needs_reviewer

@timokau for some reason marvin just undid its last action here https://github.com/NixOS/nixpkgs/pull/158116#event-6153635644

@GrahamcOfBorg eval

ofborg built it

@fgaz that happens when marvin re-requests the same reviewer as before. Github does not show that in its UI. See https://github.com/timokau/marvin-mk2/issues/86.

authors: cole-h fgaz jonringer timokau turion


text:
vultr-cli: 2.12.0 -> 2.12.1

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/vultr-cli/versions.
meta.description for vultr-cli is: "Official command line tool for Vultr services"
meta.homepage for vultr-cli is: "https://github.com/vultr/vultr-cli"
meta.changelog for vultr-cli is: ""
Updates performed

Golang update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
Warning: no invocation of /nix/store/315485131nhnm1yza3rf7i4h6i5nyf5v-vultr-cli-2.12.1/bin/vultr-cli had a zero exit code or showed the expected version
0 of 1 passed binary check by having a zero exit code.
0 of 1 passed binary check by having the new version present in output.
found 2.12.1 with grep in /nix/store/315485131nhnm1yza3rf7i4h6i5nyf5v-vultr-cli-2.12.1
found 2.12.1 in filename of file in /nix/store/315485131nhnm1yza3rf7i4h6i5nyf5v-vultr-cli-2.12.1

Rebuild report (if merged into master) (click to expand)

2 total rebuild path(s)

1 package rebuild(s)

1 x86_64-linux rebuild(s)
1 x86_64-darwin rebuild(s)

First fifty rebuilds by attrpath
vultr-cli

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/315485131nhnm1yza3rf7i4h6i5nyf5v-vultr-cli-2.12.1 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A vultr-cli https://github.com/r-ryantm/nixpkgs/archive/8454a7ed0ec9b703ff7a0bd839f8f22b8c391b23.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/315485131nhnm1yza3rf7i4h6i5nyf5v-vultr-cli-2.12.1
ls -la /nix/store/315485131nhnm1yza3rf7i4h6i5nyf5v-vultr-cli-2.12.1/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

vultr-cli

Maintainer pings
cc @Br1ght0ne @kalbasit for testing.

### Dependencies
* Bump github.com/vultr/govultr/v2 from 2.14.0 to 2.14.1 [PR 232](https://github.com/vultr/vultr-cli/pull/232)

### Enhancements
* Firewall Rule : Add ip type, source and subnet size to firewall rule printer [PR 234](https://github.com/vultr/vultr-cli/pull/234)

Change looks good to me.


text:
python3Packages.pybind11: build in parallel

Motivation for this change
Build pybind11 in parallel using $NIX_BUILD_CORES.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 162216 run on x86_64-linux 1

1 package built:

home-assistant

Please git rebase $(git merge-base master staging) and change the target branch to staging.

I would put this in staging, doesn't seem to affect correctness

Thanks for the merge!

authors: cpcloud dotlambda jonringer


text:
python39Packages.flit: 3.6.0 -> 3.7.1

Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

In flit-core, version and format need to be inherited from flit as well.

Done

$ nix-build -A python3.pkgs.pep517
error: attribute 'format' missing

       at /home/freddy/code/other/nixpkgs_2/pkgs/development/python-modules/flit-core/default.nix:7:25:

            6|
            7| buildPythonPackage rec {
             |                         ^
            8|   pname = "flit-core";
(use '--show-trace' to show detailed location information)

Reverted that. I thought format is propagated but whatever. Nothing that important.


text:
nixos/ipfs: fix the services.ipfs.autoMigrate option

Description of changes
Apparently this was never properly tested in #136261 and never worked. When the IPFS repo needs upgrading, the first call to ipfs, which is run before running the migration, fails with the error message "Error: ipfs repo needs migration".
To fix this, simply run the migration before any ipfs config calls but don't run it when dataDir is empty and we need to call ipfs init.
Writing a NixOS test for this would require keeping at least two versions of IPFS in Nixpkgs, which we don't currently do.
Also remove some unused code and add myself as a maintainer.
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

/marvin opt-in
/status needs_reviewer

Cc @happysalada
Strange that nobody noticed this problem before.

this looks good to me.
I remember testing this, but most probably I was in state that didn't require a migration.

authors: Luflosi happysalada


text:
gh: 2.11.2 -> 2.11.3

https://github.com/cli/cli/releases/tag/v2.11.3
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[x] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 174620 run on aarch64-darwin 1

1 package built:

gh

authors: siraben zowoq


text:
libidn2: hack to avoid referencing bootstrap tools

Due to bootstrap tools getting purged from closure of libidn2.dev,
a very large rebuild is caused.

Fixes https://github.com/NixOS/nixpkgs/issues/175693
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

Eh, well, the conflict is trivial to resolve, now I rather want this to be testable without a stdenv rebuild.
This approach is the best I could come with, though perhaps someone will have a better idea or some nits to improve in this PR.


text:
reviewdog: 0.14.0 -> 0.14.1

Description of changes

https://github.com/reviewdog/reviewdog/releases/tag/v0.14.1
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[x] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

@GrahamcOfBorg build reviewdog


text:
python310Packages.crownstone-uart: 2.4.1 -> 2.5.0

Description of changes
https://github.com/crownstone/crownstone-lib-python-uart/blob/master/CHANGELOG.md#release-250

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 178713 run on x86_64-linux 1

3 packages built:

home-assistant-component-tests.crownstone
python310Packages.crownstone-uart
python39Packages.crownstone-uart

Result of nixpkgs-review pr 178713 run on x86_64-linux 1

3 packages built:

home-assistant-component-tests.crownstone
python310Packages.crownstone-uart
python39Packages.crownstone-uart


text:
[22.05] php: 7.4.29 -> 7.4.30, 8.0.19 -> 8.0.20, 8.1.6 -> 8.1.7

Description of changes
Fixes https://nvd.nist.gov/vuln/detail/CVE-2022-31625 and https://nvd.nist.gov/vuln/detail/CVE-2022-31626.
Changelogs: https://www.php.net/ChangeLog-7.php#7.4.30 https://www.php.net/ChangeLog-8.php#8.0.20 https://www.php.net/ChangeLog-8.php#8.1.7
These were already done on master in https://github.com/NixOS/nixpkgs/pull/177136, but not backported.
@etu decided that all three should go into stable, though: https://github.com/NixOS/nixpkgs/pull/177136#issuecomment-1152151418
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

nixpkgs-review happy, macos 10.15

authors: risicle whentze


text:
qolibri: 2019-07-22 -> 2.1.4

Description of changes

https://github.com/ludios/qolibri/releases/tag/2.1.4
Install the desktop file in the source folder

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Is there anything I need to do to get this merged?

Is everything okay now or do I still need to do something?

Is everything okay now or do I still need to do something?

Yes, please squash commits into single one (qolibri: 2019-07-22 -> 2.1.4), so it can be merged.

Is it okay now?

authors: Jacavena sikmir


text:
wails: 2.0.0 -> 2.1.0

Description of changes
Update Wails app builder to v2.1.0.
Changelog: https://github.com/wailsapp/wails/releases/tag/v2.1.0
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 196640 run on x86_64-linux 1

1 package built:

wails

Result of nixpkgs-review pr 196640 run on x86_64-linux 1

1 package built:

wails

Thank you!

authors: ianmjones onny


text:
imv: 4.3.1 -> 4.4.0

Description of changes
Update to latest release

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Can you update the homepage to https://sr.ht/~exec64/imv/?

Can you update the homepage to https://sr.ht/~exec64/imv/?

Sure, thanks adjusted ✌🏻

The build is failing on darwin, may you fix it or mark it broken?

@ofborg build imv

The build is failing on darwin, may you fix it or mark it broken?

> meson.build:94:2: ERROR: Dependency "wayland-client" not found, tried pkgconfig and framework
I've had a look but I'm not sure why it would depend on this on darwin, so I marked it broken on darwin and aarch64

The aarch64-linux build is fine, is just darwin that's failing, likely because wayland doesn't support it.
Try with this patch:
diff --git a/pkgs/applications/graphics/imv/default.nix b/pkgs/applications/graphics/imv/default.nix
index b824b435670..22efd5e3d36 100644
--- a/pkgs/applications/graphics/imv/default.nix
+++ b/pkgs/applications/graphics/imv/default.nix
@@ -11,7 +11,7 @@
 , icu
 , pango
 , inih
-, withWindowSystem ? "all"
+, withWindowSystem ? null
 , xorg
 , libxkbcommon
 , libGLU
@@ -27,6 +27,12 @@
 }:

 let
+  # default value of withWindowSystem
+  withWindowSystem' =
+         if withWindowSystem != null then withWindowSystem
+    else if stdenv.isLinux then "all"
+    else "x11";
+
   windowSystems = {
     all = windowSystems.x11 ++ windowSystems.wayland;
     x11 = [ libGLU xorg.libxcb xorg.libX11 ];
@@ -47,7 +53,7 @@ let
 in

 # check that given window system is valid
-assert lib.assertOneOf "withWindowSystem" withWindowSystem
+assert lib.assertOneOf "withWindowSystem" withWindowSystem'
   (builtins.attrNames windowSystems);
 # check that every given backend is valid
 assert builtins.all
@@ -67,7 +73,7 @@ stdenv.mkDerivation rec {
   };

   mesonFlags = [
-    "-Dwindows=${withWindowSystem}"
+    "-Dwindows=${withWindowSystem'}"
     "-Dtest=enabled"
     "-Dman=enabled"
   ] ++ backendFlags;
@@ -87,7 +93,7 @@ stdenv.mkDerivation rec {
     libxkbcommon
     pango
     inih
-  ] ++ windowSystems."${withWindowSystem}"
+  ] ++ windowSystems."${withWindowSystem'}"
     ++ builtins.map (b: backends."${b}") withBackends;

   postInstall = ''
@@ -96,7 +102,7 @@ stdenv.mkDerivation rec {
     install -Dm644 ../files/imv.desktop $out/share/applications/
   '';

-  postFixup = lib.optionalString (withWindowSystem == "all") ''
+  postFixup = lib.optionalString (withWindowSystem' == "all") ''
     # The `bin/imv` script assumes imv-wayland or imv-x11 in PATH,
     # so we have to fix those to the binaries we installed into the /nix/store

@@ -113,6 +119,5 @@ stdenv.mkDerivation rec {
     license = licenses.mit;
     maintainers = with maintainers; [ rnhmjoj markus1189 ];
     platforms = platforms.all;
-    broken = (stdenv.isDarwin || stdenv.isAarch64);
   };
 }

Thanks for helping out with a patch, I've updated the PR - let's see what ofborg says :)✌🏻

It's still broken for another reason: can you add a meta.badPlatforms = platforms.darwin?

It's still broken for another reason: can you add a meta.badPlatforms = platforms.darwin?

np, or should I also revert the changes from the patch as well? not sure

np, or should I also revert the changes from the patch as well? not sure

No, that's fine: it more correct this way. Thank you.

authors: NickCao SebTM rnhmjoj


text:
Make cross-compiling with the crossSystem argument work (v2)

This is version 2 of my previous pull request (https://github.com/NixOS/nixpkgs/pull/18386).  Compared to my previous pull request, this has a bit of a smaller scope: it does not add a test directory and it does not try to fix the deprecated --with-headers option used to compile GCC cross-compilers.  Also, it does not do as much fixing of the top-level logic, thanks to the merged pull request https://github.com/NixOS/nixpkgs/pull/19940 by @Ericson2314 which cleaned up a lot of the problems in that area.
This pull request fixes several things about cross-compiling with the crossSystem argument:

It fixes the expressions for several derivations (gcc5, boehmgc, libffi, libxml2, readline, libtool, libiconv) so that their native derivations do not change when the top-level crossSystem argument is provided.
It avoids using bootstrap tools to compile the cross-compilers; it uses the normal stdenv.

To accomplish these goals, some new things were added:

stdenv.mkDerivationWithCrossArg
lib.overrideNativeDrv
lib.overrideNativeDrvs

Motivation for this change
For motivation information, see my comment on the old pull request: https://github.com/NixOS/nixpkgs/pull/18386#issuecomment-245522662
Things done to test
This pull request was tested using the expression here:
https://gist.github.com/DavidEGrayson/8f962b3ec6edf06365ecb0c70a88029f
The tests passed, all the derivations were successfully built, and the rpiHello derivation was successfully run on a Raspberry Pi.  This pull request should not cause a mass rebuild of native derivations.

[ ] Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)

[ ] NixOS
[ ] macOS
[x] Linux

[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

Future work
Here are some similar things that could be done in the future:

Search for more improper uses of stdenv.cross, possibly remove stdenv.cross to prevent future errors.
Stop using the deprecated --with-headers option to configure GCC cross-compilers.
Apply these GCC fixes to the GCC 6 expression.
Get cross-compiling working on Darwin too; this pull request is mainly about getting it to work on Linux.
Add automated tests to make sure the problems fixed by this PR do not reoccur.

CC @shlevy and @bjornfor because they both asked for status updates on the previous pull request, and @dezgeg because he helped make the previous pull request work.  Also, @viric and @rasendubi.

@DavidEGrayson you pinged me mentioning conflicts with my https://github.com/NixOS/nixpkgs/pull/21268 . Well besides the files changed there is a difference in approach. Currently in nixpkgs, as we both know, there is a only a very sloppy attempt to make nativeDrvs and crossDrvs. You clean that up with overrideNativeDrv, whereas I throw it out altogether. So were I to rebase mine on yours, I'd need to revert using those two lib functions (there's not bad, just no longer have any use), and changes like pythonSupportReally, whereas if you revert on mine, your diff should just shrink dramatically with no need to revert any of my changes.

On a diffferent note, it would be amazing to get your tests into https://github.com/NixOS/nixpkgs/blob/master/pkgs/top-level/release-cross.nix so they (I think) will be tested by hydra.

I posted this pull request one day before Christmas Eve.  Now that the holidays are over, maybe a nixpkgs member would be interested in looking at it and merging it?  There was a lot of interest on my previous pull request (https://github.com/NixOS/nixpkgs/pull/18386) and I thought people were gung-ho to get it merged in.
A lot of this pull request is just fixing logic errors in the recipes for individual packages that are due to people misunderstanding how stdenv.cross works.

I currently have a good understanding on how stdenv works.
However I want nixos on my ARM boards too, so I do my best and give it a shoot.
When rebasing your pull request against current master,
I get the following evaluation error after, when trying to rebuild my system:
building Nix...
building the system configuration...
error: value is null while a Boolean was expected, at /etc/nixos/nixpkgs/pkgs/development/libraries/libxslt/default.nix:7:8
(use ‘--show-trace’ to show detailed location information)

This is the failing file: nixpkgs/pkgs/development/libraries/libxslt/default.nix
assert pythonSupport -> python2 != null;
assert pythonSupport -> libxml2.pythonSupport; # <--- this is failing line

you changed in libxml2/default.nix
-, pythonSupport ? (! stdenv ? cross) }:
+, pythonSupport ? null }:

As I said don't know enough about stdenv and cross compilation in this context to know what the right fix in this case would be...

@Mic92 Thanks, that would have to be fixed before we merge this in.  If you're looking for a quick solution, maybe just remove the assertion that is failing.  For the longer term, I'd have to look into populating libxml2.pythonSupport with a proper boolean variable that says whether it supports Python or not.

Unfortunately this is a mass-rebuild on NixOS. I currently do not have the resources locally to test this here. Probably someone with access to hydra could take a look at it.

Hmmm, I have tests and code to try to make sure that this PR would not be a mass rebuild.  What is the first derivation that is getting rebuilt for you when you try it out?

@DavidEGrayson this would be the rebuild log, when doing nixos-rebuild dry-build:
https://gist.github.com/a92f9e47bf87f801034221aa48fa3647

I am closing this.  @Ericson2314 is working hard to clean up cross-compiling in nixpkgs, so this pull request would probably just get in his way or make things harder.
Instead of working on this stuff, I am pursuing a project called nixcrpkgs where I will make my own Nix expressions for cross-compiling and just use nixpkgs as the base platform for my build system.  Since I don't need to worry about supporting a million different use cases, my expressions can be much cleaner and simpler than what has accumulated in nixpkgs over the years, especially when it comes to building a GCC cross-compiler.

@DavidEGrayson Thanks, definitely watching that repo. I had opened https://github.com/NixOS/nixpkgs/issues/21471 which I hope your repo + my nixpkgs PRs will greatly accelerate.


text:
python310Packages.aioswitcher: 3.2.1 -> 3.2.2

Diff: https://github.com/TomerFi/aioswitcher/compare/refs/tags/3.2.1...3.2.2
Changelog: https://github.com/TomerFi/aioswitcher/releases/tag/3.2.2
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 214595 run on x86_64-linux 1

3 packages built:

home-assistant-component-tests.switcher_kis
python310Packages.aioswitcher
python311Packages.aioswitcher


text:
magma: fix for cuda_profiler_api.h for CUDA 11.8+

Description of changes

The location of cuda_profiler_api.h changed in CUDA 11.8 to a new package, cuda_profiler_api. This PR adds a conditional to ensure the correct package is chosen.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

cc @NixOS/cuda-maintainers

Result of nixpkgs-review pr 219200 run on x86_64-linux 1

1 package failed to build:

magma_2_6_2

2 packages built:

magma (magma-cuda ,magma_2_7_1)
python310Packages.torchWithCuda

Failed derivations

[ ] magma-2.6.2.drv (derivation hash: qf2fwpagm5g88y6fh9svhjdx1zw1hzy1)

https://gist.github.com/d16722a82e977928eb13783280be8fee

Result of nixpkgs-review pr 219200 run on x86_64-linux 1

1 package failed to build:

magma_2_6_2

2 packages built:

magma (magma-cuda ,magma_2_7_1)
python310Packages.torchWithCuda

@SomeoneSerge @samuela would either of you have the bandwidth to review? Still no issues on my end with CUDA 11.7 (the default) or CUDA 11.8.

Result of nixpkgs-review pr 219200 run on x86_64-linux 1

LGTM, thanks @ConnorBaker !

Failed derivations

[x]  magma-2.6.2.drv (derivation hash: qf2fwpagm5g88y6fh9svhjdx1zw1hzy1)

https://gist.github.com/d16722a82e977928eb13783280be8fee
Segmentation fault, happens sometimes on my desktop
Was able to build it without issue when run again

Does nixpkgs-review create these build log posts automatically? Or did you upload the logs and write the comment yourself?  I've always found it annoying to upload the build logs for failing jobs

Oh I have a treat for you then :)
https://gist.github.com/ConnorBaker/b32a7f69d318e3f338b6b4fedeef37ef
Should probably be pretty easy to integrate into nixpkgs-review, but I haven't gotten around to it :(

Oooh, beautiful! I can def make use of this, thank you!!

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/tweag-nix-dev-update-45/26397/1

authors: ConnorBaker nixos-discourse samuela


text:
bazel: add basic documentation to manual

Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

umm, I'm not sure what happened here. sorry for ping all y'all

I'm going to assume a bad rebase. In the future, before you do a rebase, you should switch the PR to draft, force push, change the target branch, and then undraft it, which will stop people from getting pinged.

authors: piperswe winterqt


text:
azure-cli: fix build

Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Love seeing @jonringer back!

authors: superherointj wegank


text:
onagre: init at 1.0.0-alpha.0

Description of changes
Add onagre application launcher for X and Wayland

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Thanks for the review.
With importCargoLock.lockFile, do I just manually copy the lockfile from the original repo or is there an automated/nix-way to generate it from github?

With importCargoLock.lockFile, do I just manually copy the lockfile from the original repo or is there an automated/nix-way to generate it from github?

It may be possible to patch the lock file directly without using the methods in the prompt. Otherwise, importing custom Cargo locks is purely manual.

Please squash the commits for onagre. Otherwise, LGTM.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/2053

authors: jfvillablanca nixos-discourse wegank


text:
nixos/loki: add package option

Description of changes
Adds the commonly used package option to services.loki.
To me, it doesn't feel like a significant enough change to add it to the release notes, so I didn't :eyes:
But I am obviously open to adding it anyway :)
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

@ofborg eval

@ofborg test loki


text:
jetbrains.dataspell: init at 2023.1

Description of changes
New IDE: https://www.jetbrains.com/dataspell
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[x] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Any telling when this'll be merged? We ran into this awhile back, and our company still needs it :)

When you need a Jetbrains product, you can also use the Jetbrains Toolbox, maybe it is already available in there.

When you need a Jetbrains product, you can also use the Jetbrains Toolbox, maybe it is already available in there.

Actually, the toolbox distributions fail to load on my machine, unless started from the toolbox UI itself -- which is pretty bad integration. :/

Open a pr !
On Sat, Jun 3, 2023, 01:19 Alexandria @.***> wrote:

When you need a Jetbrains product, you can also use the Jetbrains Toolbox,
maybe it is already available in there.
Actually, the toolbox distributions fail to load on my machine, unless
started from the toolbox UI itself -- which is pretty bad integration. :/
—
Reply to this email directly, view it on GitHub
https://github.com/NixOS/nixpkgs/pull/226340#issuecomment-1574428615,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAB5RCVBPJYBK3RJ3PSEE3DXJJYH7ANCNFSM6AAAAAAW7ULRUQ
.
You are receiving this because you modified the open/close state.Message
ID: @.***>

authors: alxpettit drupol leona-ya


text:
libfilezilla: 0.41.0 -> 0.45.0; filezilla: 3.63.1 -> 3.66.4

Description of changes
Sources are now distributed in a .tar.xz
https://filezilla-project.org/changelog.php
https://lib.filezilla-project.org/
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

3.66.4 contains the mitigation for CVE-2023-48795.
Looking at the version history it should be fine to backport the upgrade.
https://filezilla-project.org/versions.php?version=3.66.4&oldversion=3.63.1

authors: Intuinewin LeSuisse


text:
tensorflow: depend on cudatoolkit 8 and cudnn 5.1

Motivation for this change
Latest hardware can be efficiently used only with newer versions of CUDA libraries
Things done

[ ] Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)

[ ] NixOS
[ ] macOS
[x] Linux

[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

@edwtjo Any opinion on this pr?

If you would like to get PR's like this in faster I suggest you become maintainer of the expression. When there's no maintainers I typically keep PR's open for a while so others can give feedback.

Alright, thanks for the tip @FRidh . How would one go about becoming maintainer? @teh or @edwtjo may also want to take maintainership.

Open a PR adding yourself to meta.maintainers.
On Tue, Mar 7, 2017 at 2:15 PM, Jean-Philippe Bernardy <
notifications@github.com> wrote:

Alright, thanks for the tip @FRidh https://github.com/FRidh . How would
one go about becoming maintainer? @teh https://github.com/teh or @edwtjo
https://github.com/edwtjo may also want to take maintainership.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/NixOS/nixpkgs/pull/23240#issuecomment-284718008, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ACB877wmj1kKTP5AlLQ-MFj5uBy-mw8vks5rjVh3gaJpZM4MNKjP
.

authors: FRidh jyp