text:
Revisit conventions for naming of handler methods

We want to make sure it's possible to make the On and Async in a handler method options.
We also want to consider if you can drop Post from a handler method name and just have the handler method portion. So Delete() would match the delete form action. In this model all public methods are considered handler methods (same exceptions for dispose).
I also want to consider, could get get away from using verbs entirely... this would mean choosing a different term to represent GET and non-GET.

I'm also wondering whether we should rename the "formaction" concept to be more in line with pages, e.g. "handler". I'm using it for things that expressly aren't form-actions, they're HTTP GET callbacks from other sites for example, and it seems to gel better with the whole "page handler" thing we have going.
Thoughts?

I chose the term form action based on the HTML attribute. We could certainly revisit this

Yeah I know, and it made sense, but I'm finding I'm using it for more than that, and as we discussed, we could end up "hiding" that attribute via a Tag Helper in some cases anyway.

297196baa0d4a28a4f71d0b4bba2d5b942af6190

authors: DamianEdwards rynowak

repo: aspnet/Mvc


text:
Migration

FYI only

@JunTaoLuo what is this?

@davidfowl - some packages were missed by some of the scripts that were used for the conversion.

source: gharchive/pull-request

authors: Eilon JunTaoLuo davidfowl

license_type: permissive

license_source: github-api


text:
Use built-in clipboard API.

Today we make use of the clipboardy package in order to copy Razor issue content to the cilpboard. VSCode recently finalized a clipboard API so we don't have to use such a package: https://code.visualstudio.com/updates/v1_30#_clipboard

45fd89ae005f92f851944581b63c5594aabd19c5
b54c8e8f661c816b387bd8b588e604208e392086

source: gharchive/issue


text:
Fix #1322 #1328 #1310 #1325

This are mechanical API Cleanup issues.

FYI only

repo: aspnet/Razor


text:
Enable dnxcore50 in Microsoft.AspNet.Authentication.Test

In #420 I identified a number of items that are incompatible with dnxcore50.  We should address these so that the project supports coreclr.

remaining Moq reference in OpenIdConnectMiddlewareTest
XmlTextWriter reference in CookieMiddlewareTest
Uri.GetLeftPart(...) in FacebookMiddlewareTest, GoogleMiddlewareTest, and MicrosoftAccountMiddlewareTest
UriPartial in FacebookMiddlewareTest, GoogleMiddlewareTest, and MicrosoftAccountMiddlewareTest

@jmloeffler I'm asking @Tratcher to follow up on anything remaining in this PR. Sorry for the delay in getting back to you!

No problem.  I think people were waiting on me anyway.  There was some concern over one of the test changes I made and I got a bit discouraged about the whole thing when I saw this commit af14c99b465ef79bea85edd38421f7d08f7d371e.  But I'm happy to put more time into this one if having dnxcore support in the test projects is still desired.

Yes, we definitely want the tests to run on dnxcore50!

https://github.com/aspnet/Security/commit/42cba79e01872a69165ffc957ddcb7d79adf63da

authors: Eilon Tratcher jmloeffler

repo: aspnet/Security


text:
Nuke Notification and Infrastructure namespaces

Keep Notification folder, but squash namespace
cc @Tratcher @muratg

:shipit:

73d4440a25adb1f3ad72d8c0dd43f2dd6e0262c5

authors: HaoK Tratcher


text:
Don't install nginx twice on OSX Travis build.

cc @Tratcher @BrennanConroy

Green. Squirrel?

Ship :ship:

authors: BrennanConroy cesarbs

repo: aspnet/ServerTests


text:
Method names on js client are case sensitive

They shouldn't be.

@davidfowl  alpha1?

Yep

authors: davidfowl moozzyk

repo: aspnet/SignalR


text:
Updating external dependencies

New versions:
SystemReflectionMetadataPackageVersion
SystemThreadingChannelsPackageVersion
SystemRuntimeCompilerServicesUnsafePackageVersion
SystemDataSqlClientPackageVersion
SystemSecurityCryptographyCngPackageVersion
SystemServiceProcessServiceControllerPackageVersion
SystemDiagnosticsEventLogPackageVersion
SystemSecurityPrincipalWindowsPackageVersion
SystemNumericsVectorsPackageVersion
SystemCollectionsImmutablePackageVersion
SystemBuffersPackageVersion
SystemDiagnosticsDiagnosticSourcePackageVersion
SystemNetHttpWinHttpHandlerPackageVersion
SystemIOPipelinesPackageVersion
SystemThreadingTasksExtensionsPackageVersion
SystemValueTuplePackageVersion
SystemSecurityPermissionsPackageVersion
MicrosoftNETCoreAppPackageVersion
SystemComponentModelAnnotationsPackageVersion
MicrosoftExtensionsDependencyModelPackageVersion
MicrosoftCSharpPackageVersion
SystemMemoryPackageVersion
SystemThreadingTasksDataflowPackageVersion
SystemTextEncodingsWebPackageVersion
SystemNetWebSocketsWebSocketProtocolPackageVersion
SystemSecurityCryptographyXmlPackageVersion
MicrosoftWin32RegistryPackageVersion

It this coherent? Let's take it.

authors: pakrym ryanbrandenburg

repo: aspnet/Universe


text:
Enforce mandatory properties in Azure Alert payload

Tag mandatory properties with Required.Always so JSON.NET enforces the requirement during (de)serialization
Fix a couple of comment typos on KuduNotification
Add required 'resourceRegion' property to AlertMessage1.json test content
Add AlertMessage3.json to validate change against sample payload in Azure docs
Add unit tests

Hi @maitre-matt, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla2.dotnetfoundation.org.

TTYL, DNFBOT;

@maitre-matt, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.
Thanks, DNFBOT;

Committed to dev: 6958689c68e6ed1772892ffb19a2558af1721c45
Thanks!
Henrik

repo: aspnet/WebHooks

license_source: bigquery


text:
Created Abp.EntityFramework.SettingStore

Tests passed 👍
Created the nuget locally Abp.EntityFramework.SettingStore-beta2
See aspnetboilerplate/aspnetboilerplate/issues/2152

Thanks a lot for your contribution. I'll review it in a short time.

Thank you, first time contributing might've Missed something don't know...  I'm glad to do it. Amazing framework 😌

Hi,
One question is that: How this new module is supposed to use? I think we should add a DbSet<Setting> property to our DbContext. Right? If so, it would be better to define an interface, like ISettingDbContext that should be implemented by the DbContext.
Second improvement would be renaming SettingModule to AbpEntityFrameworkSettingStoreModule.

authors: hikalkan wocar

repo: aspnetboilerplate/module-zero

license: mit


text:
Introspection.findGetter() should check "has" prefix for finding boolean properties

Summary
Introspection.findGetter method only attempt to use "is" prefix to find boolean properties in a class. It should also try "has" as it is a frequently used prefix for boolean properties.

findGetter is in line with the Oracle's JavaBeans specification, chapter 8.3.2:

In addition, for boolean properties, we allow a getter method to match the pattern:
public boolean is<PropertyName>();

This “is” method may be provided instead of a “get” method, or it may be provided in addition to a “get” method.
In either case, if the “is” method is present for a boolean property then we will use the “is” method to read the property value.
An example boolean property might be:
public boolean isMarsupial();
public void setMarsupial(boolean m);

Honestly, I couldn't come up with any boolean property name that would have a meaningful "has" method. "has" feels more natural with collections, for example.
Could you provide a concrete example?

“has” prefix is often prefered to express the notion of an object HAVING a value or a characteristic instead of the notion of an object BEING of a certain kind or in a certain state.
Example:
interface Car {
    boolean isCabriolet();   // "is" prefix ok
    boolean isParked();

    boolean hasABS();        // "has" prefix is a better choice here than any isXXX
    boolean hasESBAudio()
}

But thinking a bit further, I find cases where the behavior could be ambiguous, such as when a class has a getXXX AND a hasXXX (like the classes generated by Google protobuf Generator). It would be difficult to tell AssertJ to call the getXXX method instead of the hasXXX method (or vice versa).
Thus I'm going to close this thread, because it could do more harm than good.

authors: scordio zartc

repo: assertj/assertj-core


text:
Rework StandardComparisonStrategy#areEqual to avoid shortcuts

The previous behavior relied on java.util.Objects#deepEquals, which
performs a reference check before invoking equals on the first
parameter. While this it not an issue for proper implementations of
the equals contract, it was behaving incorrectly in case of
implementations not satisfying the reflexive property. Also, performing
the reference check outside of the equals implementation reduced the
overall coverage.
The tests now provide thorough regression to ensure that no shortcut is
taken, especially in case of implementations violating the contract.
Check List:

Fixes #1949
Unit tests : YES
Javadoc with a code example (on API only) : YES

Test executions with:

java.util.Objects#deepEquals

Proposed changes:

Test executions with:

java.util.Objects#deepEquals

Proposed changes:


text:
"npm install" on windows error

I'm trying to 'npm install' this projects on windows, but i am getting this error:
Thank you in advance.
> angular-input-masks@2.1.0 prepublish C:\projects\angular-input-masks
> gulp build

[11:26:50] Using gulpfile C:\projects\angular-input-masks\gulpfile.js
[11:26:50] Starting 'build-dependencies'...
[11:26:51] Finished 'build-dependencies' after 1.09 s
[11:26:51] Starting 'build'...

events.js:72
        throw er; // Unhandled 'error' event
              ^
Error: Cannot find module 'validators' from './src/'
    at C:\projects\angular-input-masks\node_modules\browserify\node_modules\resolve\lib\async.js:46:17
    at process (C:\projects\angular-input-masks\node_modules\browserify\node_modules\resolve\lib\async.js:173:43)
    at ondir (C:\projects\angular-input-masks\node_modules\browserify\node_modules\resolve\lib\async.js:188:17)
    at load (C:\projects\angular-input-masks\node_modules\browserify\node_modules\resolve\lib\async.js:69:43)
    at onex (C:\projects\angular-input-masks\node_modules\browserify\node_modules\resolve\lib\async.js:92:31)
    at C:\projects\angular-input-masks\node_modules\browserify\node_modules\resolve\lib\async.js:22:47
    at Object.oncomplete (fs.js:107:15)

npm ERR! angular-input-masks@2.1.0 prepublish: `gulp build`
npm ERR! Exit status 8
npm ERR!
npm ERR! Failed at the angular-input-masks@2.1.0 prepublish script.
npm ERR! This is most likely a problem with the angular-input-masks package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     gulp build
npm ERR! You can get their info via:
npm ERR!     npm owner ls angular-input-masks
npm ERR! There is likely additional logging output above.
npm ERR! System Windows_NT 6.1.7601
npm ERR! command "C:\\Program Files\\nodejs\\\\node.exe" "C:\\Program Files\\nodejs\\node_modules\\npm\\bin\\npm-cli.js" "install"
npm ERR! cwd C:\projects\angular-input-masks
npm ERR! node -v v0.10.28
npm ERR! npm -v 1.4.9
npm ERR! code ELIFECYCLE
npm ERR!
npm ERR! Additional logging details can be found in:
npm ERR!     C:\projects\angular-input-masks\npm-debug.log
npm ERR! not ok code 0

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/26758781-npm-install-on-windows-error?utm_campaign=plugin&utm_content=tracker%2F1022469&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F1022469&utm_medium=issues&utm_source=github).

Same freaking issue. Hate these absurdly fragmented projects with no prebuilt release versions. Wasting my f'ing time trying to learn all your toolchain so I can just use a freaking us phone number mask.

I don't get what you need, you just intend to use the project? If yes, the project have a prebuilt release, you can get it by these methods 'https://github.com/assisrafael/angular-input-masks#installation'
or on this link: https://github.com/assisrafael/bower-angular-input-masks.
I'm with this issue because i'm trying to do a PR

@rafaelzomer which versions of node, npm and windows you are using?

I'm not using Bower in my toolchain and furthermore that lacks all the US masks in the resulting build output. The "angular-input-masks.us.js" is full of this module.exports and require('... crap that I wasted my time trying to custom build.

@assisrafael

node =  v0.10.28
npm = 1.4.9
windows = Windows 7 Ultimate / Service Pack 1

You just cloned the repository and executed npm install?

@assisrafael Yes

Which version of browserify is installed?

v10.2.1
but i ran "npm install -g browserify@10.2.1", before do "browserify --version"

Try npm install browserify@latest inside angular-input-masks folder for a fresh local installation.

I ran it, but when i ran "npm install" again the NPM fetched the version of browserify that was in package.json, so, i tried to ran only "gulp build", but the system give me the following error:
'gulp' não é reconhecido como um comando interno
ou externo, um programa operável ou um arquivo em lotes.

Aparently windows can't run local modules that are inside of "node_modules" (Maybe?)(It should work? I don't remeber if this works on this way on Linux)

Maybe is your node version. Try a newer version, like v4.0.
The build process works fine in windows using iojs@2.3.
On linux it works well with >=0.10.40

authors: assisrafael circuitrider rafaelzomer

repo: assisrafael/angular-input-masks


text:
Update 02.7.md

避免主协程退出，子协程内容未输出

您好，您发的邮件已收到。我会尽快阅读。

这是来自QQ邮箱的自动回复邮件。您的邮件，我已经收到，O(∩_∩)O谢谢

authors: Allen-Jaeger RuikaiLiu ccsay


text:
Weird conflict between formatter and linter fix all

Here are two files:
#!/usr/bin/env -S poetry run python

from typing import Any
from toml import load

# @BUG: https://github.com/darrenburns/ward/issues/378
from ward import Scope, fixture  # pyright: ignore [reportUnknownVariableType]

and
#!/usr/bin/env -S poetry run python

from collections.abc import Callable
from typing import Any
from unittest.mock import MagicMock

# @BUG: https://github.com/darrenburns/ward/issues/378
from ward import Scope, fixture  # pyright: ignore [reportUnknownVariableType]

First one doesn't have any issues yet the second one is triggering I001,
.ruff.toml:
builtins = [
  "_"
]
cache-dir = "tmp/ruff"
preview = true
target-version = "py312"
unsafe-fixes = true

[format]
docstring-code-format = true
docstring-code-line-length = 120
line-ending = "lf"

[lint]
dummy-variable-rgx = "^_$"
extend-select = [
  "D213"
]
ignore = [
  "CPY001",
  "D212"
]
select = [
  "ALL"
]
task-tags = [
  "@BUG",
  "@HACK",
  "@TODO"
]

[lint.isort]
combine-as-imports = true
force-sort-within-sections = true
lines-after-imports = 2
no-lines-before = [
  "first-party",
  "future",
  "local-folder",
  "standard-library",
  "third-party"
]

[lint.pycodestyle]
max-doc-length = 120
max-line-length = 120

[lint.pydocstyle]
convention = "google"

[lint.pylint]
allow-magic-value-types = [
]

[lint.flake8-annotations]
allow-star-arg-any = true

Thanks for reporting this bug.
The issue here is that the formatter enforces a blank line between two imports if there's an own-line comment between them (similar to black).
from unittest.mock import MagicMock
# @BUG: https://github.com/darrenburns/ward/issues/378
from ward import Scope, fixture  # pyright: ignore [reportUnknownVariableType]

Gets reformatted to
from unittest.mock import MagicMock

# @BUG: https://github.com/darrenburns/ward/issues/378
from ward import Scope, fixture  # pyright: ignore [reportUnknownVariableType]

Now, isort doesn't agree with the blank line because of the no-lines-before  configuration.

Will formatter be updated to take into account .ruff.toml config of isort?

I need to think in more detail about what the best solution here is. We want to avoid that the formatter needs to read the isort configuration and reimplement the same logic (the formatter doesn't know about first-party-imports etc).

I think I've found a bunch of other issues too with formatter conflicting lint fix. Long term formatter should be compatible with linter config file...

For what it's worth, by far the best way to ensure compatibility is to avoid highly customized formatting rules or configuration in the linter (e.g., modifying the isort settings). It's possible that we don't end up "fixing" those and instead just mark them as incompatible with user-facing warnings, as with other formatter-conflicting lint rules and settings (see: https://docs.astral.sh/ruff/formatter/#conflicting-lint-rules).

authors: MichaReiser charliermarsh mgzenitech

repo: astral-sh/ruff

license: MIT


text:
Is an venv created by uv updatable by pip?

I'm one of the maintainers of Megalinter, a tool and action that combines many linters to run on code. Most of our work is essentially integrating all these projects of different environments together. It is known to be very configurable to be able to use it any project.
I've been following the project since it was announced, and am exploring the suitability of using uv for installing the Python-based linters when building the docker images. Since all these tools have vastly different dependencies, they are installed in virtual environments. Currently, installing these Python tools take a larger part of the 20-25 minutes taken for the docker build step. That's why if uv, as Python package install tool, could be faster to do the job, it will shine nicely.
However, as mentioned, since it is a project that is known to be configurable  to adapt to the user's project's particularities, it is possible for users to add commands to install additional tools before running, or changing to a particular version if the image doesn't fit their needs. Some of them would have pip install commands in these venvs (all inside the alpine-based container).
So, would a venv created by uv, still be compatible (enough) for pip to modify that environment? We wouldn't want to shove uv as a change for all our users, but would love to use it for ourselves initially.
Thanks again for your project, it's amazing how much progress was made in the last two weeks!

Oh that's a fast answer!
Okay great, if it only takes us to make sure we add pip inside these venvs, that's easy!

Oh, and last question, does uv still need to exist once installed, or it could be removed at install time and the venv would work as expected at runtime?

Oh, and last question, does uv still need to exist once the packages in the venv are installed, or it could be removed at install time and the venv would work as expected at runtime?

uv doesn't need to exist afterwards, it could be removed!
I typically don't install uv into the virtualenv at all. uv can exist anywhere on the system and install into any virtualenv or Python interpreter, so there's generally no need to install it in the environment.

I meant in the system at all: when building docker images, you want to limit files that needs to be saved at each layer. You'd want to clean unnecessary files in the same layer as they are created. So, I was exploring the need to have this persisted or not. Your answer confirms my impression then.

👍 Totally fine to remove the uv binary and the uv cache too.

authors: charliermarsh echoix

repo: astral-sh/uv


text:
Add uv init --from-project <path> to import from other tools

As previously discussed for uv add -r pyproject.toml but without any of the controversy about what to do with extras. We can copy all of the dependencies as reported by the build backend.

I'll look into this tonight unless someone beats me to it.

I have no idea why I closed this.

Related: https://github.com/astral-sh/uv/issues/6164

Is this up for grabs?

Yes!

You can use SourceTreeResolver to get the metadata. But one challenge is... we probably need to preserve extras rather than resolving them. For example, if the user's pyproject.toml has:
[project.optional-dependencies]
foo = "bar"

Then in the project we create, we'd also want to create a foo extra with bar in it.

I'll take a look soon.

we'd also want to create a foo extra with bar in it.

This makes sense, a similar PR would then resolve #6164 right?

Yeah, it's possible that we want to skip #6164 for now since it brings up some confusing questions, like what does --extra mean in uv add --extra baz -r pyproject.toml. So let's start with support here in uv init.

What is needed to get this merged/released? It will help converting a lot of users  from Poetry to UV, at least for companies which have large number of repo's.

Shameless plug (in case someone stumbles over this issue here and --from-project is still WIP): I wrote a script to migrate our Poetry monorepo project to uv. I doubt it will work immediately on other projects, but could be a good start.
https://gist.github.com/mrcljx/8e99a7f9fb924a573416f4365ee15873

authors: blueraft charliermarsh mrcljx mrijken zanieb


text:
feat: export --prune

Summary
This adds a --prune flag to the export command to correspond with the --prune flag of the tree command.
The purpose is for generating a requirements.txt that omits a package and all of that package's unique dependencies. This is useful for cases where the project has a dependency on a common core package, but where that package does not need to be installed in the target environment.
For example, a pyspark job needs spark for development, but when installing into a cluster that already has pyspark installed, it is desirable to omit pyspark's whole dependency tree so that only the unique dependencies that your job needs get installed, and do not risk breaking the pyspark dependencies with something incompatible.
Dev groups cannot always cover this case because there are other projects where this common dependency occurs as a transitive. One example is Airflow providers, which include Airflow itself as a dependency, but it is unnecessary and undesirable to include Airflow's dependency tree in the requirements.txt for your DAGs.
Partly related to #7214, though I'm not sure it covers the ask in that one of having this functionality extend to the project's actual published metadata.
Test Plan
An integration test was added, and some manual testing. Let me know if more would be better.

Great PR!


text:
fix: routing + starkex bugs

Changes

Fixes a bug in the routing where we want to route if the data is too old
Updates StarkEx freshness interval (until fetcher delay is fixed)

📚 $\text{Stack Overview}$
Pulls submitted in this stack:

#143
#142 👈
main

This comment was automatically generated by st.

repo: astraly-labs/pragma-node


text:
id_log diagnostics not recorded correctly

The problem
The id_log key in HA diagnostics should display raw and localized values for stateProgramPhase, stateProgramID and stateProgramType. In practice, stateProgramPhase appears to be the only logged key, with raw value consistent with with that key. However, localized is clearly from stateProgramID.
Version of miele integration having the issue?
miele-0.0.11
Version of Home Assistant Core having the issue?
core-2022.2.6
Anything in the logs that might be useful for us?
"id_log": [
      {
        "appliance": "Dishwasher",
        "key": "stateProgramPhase",
        "raw": 1792,
        "localized": "Automatic"
      },
      {
        "appliance": "Washer dryer",
        "key": "stateProgramPhase",
        "raw": 256,
        "localized": ""
      },
      {
        "appliance": "Dishwasher",
        "key": "stateProgramPhase",
        "raw": 1792,
        "localized": "Automatic"
      },
      {
        "appliance": "Washer dryer",
        "key": "stateProgramPhase",
        "raw": 256,
        "localized": ""
      },
      {
        "appliance": "Dishwasher",
        "key": "stateProgramPhase",
        "raw": 1792,
        "localized": "Automatic"
      },

Additional information
No response

Something funky's still going on - I got no log_id entries for stateProgramID at all.

The logging code might be in sub-optimal place, where it is depending on what the frontend is doing. I will have a look tonight or tomorrow.

Yes it seems to record the same things over and over again. Also, should the log not be unique to each device? Currently the list is mixed.

This logging function is not good enough to be left in the backgound. To be really effective it should subscribe to events from the status sensor when the status is changed and log appropriate data. This is not a trivial fix for me, but should be doable if time allows.

authors: astrandb mundschenk-at

repo: astrandb/miele


text:
Solve VSCode notebooks usage

Ongoing thread on Discord: VSCode notebooks seem to import modules from a different path. Can be solved by using axonasif/workspace-python:debug2 https://github.com/astrojuanlu/workshop-jupyter-kedro/commit/da77fe0638065a0d0e4f439c824b74782b63ee58
https://github.com/astrojuanlu/workshop-jupyter-kedro/blob/da77fe0638065a0d0e4f439c824b74782b63ee58/.gitpod.Dockerfile#L1

I should raise the priority of this one.

repo: astrojuanlu/workshop-jupyter-kedro


text:
[Feature]  Allow remote store caching for the profiles file

Description
Similar to PR https://github.com/astronomer/astronomer-cosmos/pull/1147 that allows remote store caching for dbt ls output, enable/support caching remotely the profiles file
Are you willing to submit a PR?

[x] Yes, I am willing to submit a PR!

@dosubot

repo: astronomer/astronomer-cosmos


text:
Cycle 3 Funding: Hire a community manager

This issue captures execution of the Cycle 3 project “Hire a community manager” (#284). The full text of the proposal is available here.
This project was funded to the level of $48,000, funded from the Moore grant (please submit invoices here)

The Moore funding currently has $58.5k unallocated in the “Consultant - Project Administrator/Manager” line item. I propose we can use that for this position. Finance ctte members (@kelle , @aaryapatil , @eteq ), can I get a 👍 if you're happy with that?

Might be a good resource for this hire: https://contributor-experience.org/

I want to point out that there is significant overlap in the Code or Conduct portion of this plan with other activities that we already discussed at the Coordination meeting and with NumFOCUS (through a ChanZuckerberg grant) sponsoered activities in https://contributor-experience.org/. We need to keep an eye on wasting our efforts if different groups in Astropy develop different CoC proposals independently.

Yes, absolutely. These existing efforts were discussed at our kick-off meeting. Thanks for making sure though!

This work was completed.

authors: hamogu jdswinbank kelle pllim

repo: astropy/astropy-project


text:
Added zoom function

Added zoom function.
Please read the README for details.
Thanks.

Adding the zoom feature is a subject for a fork or a separate library. I would prefer to keep dragscroll simple and serving for a single purpose, so that people who only need dragging will not load additional code.

authors: asvd cymakr

repo: asvd/dragscroll


text:
Unable to create frigate cleanly

Please verify that you have read and understood the guidelines.
yes
A clear and concise description of the issue.
Script is failing:
 ✓ Cleaned
 \400 Parameter verification failed.rces
memory: unable to hotplug memory: trying to change memory cgroup values: container not running

pct set <vmid> [OPTIONS]
 |
[ERROR] in line 67: exit code 0: while executing command pct set $CTID -memory 1024

What settings are you currently utilizing?
Default Settings
Which Linux distribution are you employing?
Debian 11
If relevant, including screenshots or a code block can be helpful in clarifying the issue.
Running this command on proxmox shell:
bash -c "$(wget -qLO - https://github.com/asylumexp/Proxmox/raw/main/ct/frigate.sh)"
On Raspberry Pi 4B 8GB, using proxmox 8.2.4.
Default settings:
    ______     _             __
   / ____/____(_)___ _____ _/ /____
  / /_  / ___/ / __ `/ __ `/ __/ _ \
 / __/ / /  / / /_/ / /_/ / /_/  __/
/_/   /_/  /_/\__, /\__,_/\__/\___/
             /____/

Using Default Settings
Using Distribution: debian
Using debian Version: 11
Using Container Type: 0
Using Root Password: Automatic Login
Using Container ID: 100
Using Hostname: frigate
Using Disk Size: 20GB
Allocated Cores 4
Allocated Ram 4096
Using Bridge: vmbr0
Using Static IP Address: dhcp
Using Gateway IP Address: Default
Using Apt-Cacher IP Address: Default
Disable IPv6: No
Using Interface MTU Size: Default
Using DNS Search Domain: Host
Using DNS Server Address: Host
Using MAC Address: Default
Using VLAN Tag: Default
Enable Root SSH Access: No
Enable Verbose Mode: No
Creating a Frigate LXC using the above default settings

 ✓ Using local for Template Storage.
 ✓ Using local for Container Storage.
 ✓ LXC Container 100 was successfully created.
 ✓ Started LXC Container
 ✓ Set up Container OS
 ✓ Network Connected: 192.168.0.50 xxxxxxxxxxxxxxxxxxxxxxx
 ✓ IPv4 Internet Connected
 ✓ IPv6 Internet Connected
 ✓ DNS Resolved github.com to 20.26.156.215
 ✓ Updated Container OS
 ✓ Installed Dependencies
 ✓ Installed Python3 Dependencies
 ✓ Installed Node.js
 ✓ Installed go2rtc
 ✓ Set Up Hardware Acceleration
 ✓ Stop spinner to prevent segmentation fault
 ✓ Installed Frigate v0.13.2
 ✓ Installed Coral Object Detection Model
 ✓ Built Nginx
 ✓ Configured Services
 ✓ Customized Container
 ✓ Cleaned
 \400 Parameter verification failed.rces
memory: unable to hotplug memory: trying to change memory cgroup values: container not running

pct set <vmid> [OPTIONS]
 |
[ERROR] in line 67: exit code 0: while executing command pct set $CTID -memory 1024

With advanced settings  (verbose):
    ______     _             __
   / ____/____(_)___ _____ _/ /____
  / /_  / ___/ / __ `/ __ `/ __/ _ \
 / __/ / /  / / /_/ / /_/ / /_/  __/
/_/   /_/  /_/\__, /\__,_/\__/\___/
             /____/

Using Advanced Settings
Using Distribution: debian
Using debian Version: 11
Using Container Type: 0
Using Root Password: ********
Container ID: 103
Using Hostname: frigate2222
Using Disk Size: 20
Allocated Cores: 4
Allocated RAM: 3075
Using Bridge: vmbr0
Using IP Address: 192.168.0.103/24
Using Gateway IP Address: 192.168.0.1
Using APT-Cacher IP Address: Default
Disable IPv6: yes
Using Interface MTU Size: Default
Using DNS Search Domain: Host
Using DNS Server IP Address: Host
Using Vlan: Default
Enable Root SSH Access: yes
Enable Verbose Mode: yes
Creating a Frigate LXC using the above advanced settings
 ✓ Using local for Template Storage.
 ✓ Using local for Container Storage.
 ✓ LXC Container 103 was successfully created.
 ✓ Started LXC Container
net.ipv6.conf.all.disable_ipv6 = 1
 ✓ Set up Container OS
 ✓ Network Connected: 192.168.0.103
 ✓ IPv4 Internet Connected
 ✗ IPv6 Internet Not Connected
 ✓ DNS Resolved github.com to 20.26.156.215
Get:1 http://deb.debian.org/debian bullseye InRelease [116 kB]
Get:2 http://deb.debian.org/debian bullseye-updates InRelease [44.1 kB]
Get:3 http://deb.debian.org/debian-security bullseye-security InRelease [48.4 kB]
Get:4 http://deb.debian.org/debian bullseye/main arm64 Packages [7,956 kB]
Get:5 http://deb.debian.org/debian bullseye/main Translation-en [6,236 kB]
Get:6 http://deb.debian.org/debian-security bullseye-security/main arm64 Packages [276 kB]
Get:7 http://deb.debian.org/debian-security bullseye-security/main Translation-en [180 kB]
Fetched 14.9 MB in 6s (2,309 kB/s)
Reading package lists... Done
 \N: Repository 'http://deb.debian.org/debian bullseye InRelease' changed its 'Version' value from '11.9' to '11.10'
Reading package lists... Done
Building dependency tree... Done
Reading state information... Done
Calculating upgrade... Done
 |The following packages will be upgraded:
  base-files libgnutls30 libgssapi-krb5-2 libk5crypto3 libkrb5-3 libkrb5support0 libnss-systemd libpam-systemd libsystemd0 libudev1 systemd systemd-sysv systemd-timesyncd udev
14 upgraded, 0 newly installed, 0 to remove and 0 not upgraded.
Need to get 8,827 kB of archives.
After this operation, 24.6 kB disk space will be freed.
Get:1 http://deb.debian.org/debian bullseye/main arm64 base-files arm64 11.1+deb11u10 [70.2 kB]
Get:2 http://deb.debian.org/debian bullseye/main arm64 libsystemd0 arm64 247.3-7+deb11u5 [355 kB]
Get:3 http://deb.debian.org/debian bullseye/main arm64 systemd-timesyncd arm64 247.3-7+deb11u5 [130 kB]
Get:4 http://deb.debian.org/debian bullseye/main arm64 libpam-systemd arm64 247.3-7+deb11u5 [275 kB]
Get:5 http://deb.debian.org/debian bullseye/main arm64 libnss-systemd arm64 247.3-7+deb11u5 [196 kB]

....

 ✓ Built Nginx
 ✓ Configured Services
Reading package lists... Done
Building dependency tree... Done
Reading state information... Done
 -0 upgraded, 0 newly installed, 0 to remove and 0 not upgraded.
Reading package lists... Done
Building dependency tree... Done
Reading state information... Done
 ✓ Cleaned
 -400 Parameter verification failed.rces
memory: unable to hotplug memory: trying to change memory cgroup values: container not running

pct set <vmid> [OPTIONS]
 \
[ERROR] in line 67: exit code 0: while executing command pct set $CTID -memory 1024

root@pi:/home/tom#

Please provide detailed steps to reproduce the issue.
Run frigate using bash -c "$(wget -qLO - https://github.com/asylumexp/Proxmox/raw/main/ct/frigate.sh)"

I'll add a fix for this later when I have got some time

repo: asylumexp/Proxmox


text:
Can we add it to the doc?

Can we add that the #[Object] impl per object can only be used once?
First, I am a Rust beginner.
I tried to use #[Object] impl multiple times in one struct, but later realized that I couldn't.
I know now why it doesn't, but I think it's often the case for others.

write with google translation

define_complex_object

I updated the document. 😀

WOW, COOOOOOOOOL!!!
THANK YOU VERY MUCH!!!

repo: async-graphql/async-graphql


text:
Undocumented feature: all fields expands to FieldResult

Hello,
I'm not sure if this is realted to the recent changes on FieldResult but I've just noticed that we can use ? in field resolvers even if they don't return a FieldResult:
#[async_graphql::Object]
impl QueryRoot {
    #[field]
    async fn user(&self, ctx: &Context<'_>, id: ID) -> models::User {
        let id = ObjectId::with_string(&id.to_string())?;
        ctx.data::<Loaders>().user.load(id).await?
    }
}

It feel a bit odd, but is also very convenient and makes error management easier. The documentation doesn't seems to mention this at the moment, is this a feature we can rely on or is it subject to change in the future ?
Cheers

The code generator modifies the function signature to add FieldResult to all return values, which is why this code works.
But I think this is a bug that should cause the compiler to report an error.

I fixed this problem in version 1.10.6, and now the compiler is reporting errors correctly.😁

Nice!


text:
Allow for crate renaming in Cargo.toml

Macros will now correctly expands when users rename the crate in cargo.toml

Macros will now correctly expands when users rename the crate in cargo.toml
declaring dependency like so now works
gql = { package = "async-graphql", version = "1.11.3" }

There's still an issue, but I don't know what's happening there.
This works:
use gql::FieldResult;

#[gql::Object]
impl User {
    async fn email(&self) -> Fieldresult<&str> {
        Ok("foo")
    }
}

This does not:
#[gql::Object]
impl User {
    async fn email(&self) -> gql::Fieldresult<&str> {
        Ok("foo")
    }
}

error: Invalid type
  --> src/api/models/user.rs:32:30
   |
32 |     async fn email(&self) -> gql::FieldResult<&str> {
   |                              ^^^^^^^^^^^^^^^^^^^^^^

Great. 😁

async fn email(&self) -> gql::FieldResult<&str>

Let me solve this problem, but first tell me how to rename it in Cargo.toml. 😁

Just declare your dependency like so:
gql = { package = "async-graphql", version = "1.11.3" }

You can use the same name in patch section to use your local version:
[patch.crates-io]
gql = { package = "async-graphql", path = "../../async-graphql" }

Thanks, I learned new knowledge again. 🍺

But I can start to solve this problem tomorrow. Because COVID-19 I haven't gone out for a long time to drink with my friends, and today is my first time in 4 months.

Have fun! There's no pressure on this :D


text:
ci: update release workflow

Description
Update release workflow.
Related issue(s)

Fixes #282
cc @derberg

@derberg made the changes 🙂

/rtm

repo: asyncapi/server-api


text:
chore: create definitions for 2.5.0 version of the Spec

Description
This PR creates the new 2.5.0 definition files (no new features, just a ""copy"" of 2.4.0)
Related issue(s)
https://github.com/asyncapi/spec/issues/654#issuecomment-1158971826

@derberg @fmvilas @dalelane this is ready to be reviewed

Thanks @smoya for handling all of it 🙏🏼

/rtm

authors: derberg smoya

repo: asyncapi/spec-json-schemas


text:
Use Raw github link

Use Raw github link in ag command for code gen

@derberg, FYI blog update per issue found via Twitter

repo: asyncapi/website


text:
🛑 Wedding HTTPS is down

In 288b017, Wedding HTTPS ($WEDDINGHTTPS) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Wedding HTTPS is back up in ad44ad8.

repo: atatkin/milos-uptime


text:
🛑 Wedding HTTPS is down

In d26a730, Wedding HTTPS ($WEDDINGHTTPS) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Wedding HTTPS is back up in a9f12ef.


text:
🛑 Wedding HTTPS is down

In 80a8a3c, Wedding HTTPS ($WEDDINGHTTPS) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Wedding HTTPS is back up in 3f0864d.


text:
🛑 Wedding HTTPS is down

In fbaca9b, Wedding HTTPS ($WEDDINGHTTPS) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Wedding HTTPS is back up in 319d6a6.


text:
🛑 Wedding HTTPS is down

In ad3fcfb, Wedding HTTPS ($WEDDINGHTTPS) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Wedding HTTPS is back up in 3c24cc7.


text:
🛑 Wedding HTTPS is down

In 0df9d23, Wedding HTTPS ($WEDDINGHTTPS) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Wedding HTTPS is back up in 6ed3a51.


text:
🛑 Wedding HTTPS is down

In 6490fc4, Wedding HTTPS ($WEDDINGHTTPS) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Wedding HTTPS is back up in 4c4cf61.


text:
Drop support for Java EE 6

Update Maven artifacts to Java EE 7
Use CDI 1.1 beans.xml
remove BeanManagerProvider and BeanProvider (CDI.current().select(C.class).get() )
Use JSF 2.2 versioned config files.

Use MethodHandles instead of reflection (since Java 7 is now the minimal targetted version)

repo: atbashEE/jsf-renderer-extensions


text:
Dialpad icon

There are volume icons, phone icons, and mic icons. Can you maybe add a dialpad icon?

Will be done in the next update :+1:

added the dialpad icon in the 1.7.0 update

authors: atisawd jsdgdo

repo: atisawd/boxicons


text:
Adding a new request file w/ multiple connections for unittest

There are test files with networkx notations. We need one in the format of spec v2 and write a unittest for controller to refer to in dealing with link failure.

add to pce instead

repo: atlanticwave-sdx/datamodel


text:
Fix scariest and some scary FindBugs bugs

SearchController: withCurrentBroadcastsOnly expects a primitive
boolean. Passing null with throw a RuntimeException. Change to
passing false instead if not specified
User: manages method was checking applicationIds contains itself
rather than the provided applicationId. This code is currently unused
Actor: Fix inconsistent equals/hashCode and change equals to follow
usual patterns rather than doing an instanceof to a specific type
that breaks symmetry of equals with superclass' equals
KeyPhrase: String.format was expecting 3 parameters, but only two
are passed
ChannelSchedule: Remove misleading final on a static field; Fix
inconsistent equals/hashCode and non-standard equals as before
ScheduleRef: Fix inconsistent equals/hashCode and non-standard equals
as before
EsContentTranslator: Fix possible NPE if existing series does not
have locations and returns null instead of the empty list

lgtm

repo: atlasapi/atlas-deer


text:
webview:  How do I specify a proxy?

I'm trying to collect html requests using fiddler.  My windows is set up to proxy to fiddler but webview seems to be ignoring it.

Never mind.  I see chromium doesn't support it.
https://code.google.com/p/chromium/issues/detail?id=172285

Actually it does work.  On windows I used apm config set https-proxy http://localhost:8888 and then fiddler picked up the traffic.  See the thread about proxies here https://discuss.atom.io/t/is-there-any-proxy-settings/710/28

repo: atom/atom-shell


text:
Docs for Point don't state whether rows and columns are indexed from 0 or 1

The docs for Point don't state whether rows and columns are indexed from 0 or 1.
https://atom.io/docs/api/v1.4.0/Point
Point [essential]

Represents a point in a buffer in row/column coordinates.

Every public method that takes a point also accepts a point-compatible Array.
This means a 2-element array containing Numbers representing the row and
column.  So the following are equivalent:

  new Point(1, 2)
  [1, 2] # Point compatible Array

It actually does mention that rows and columns are zero-indexed:
https://atom.io/docs/api/v1.4.0/Point#instance-row
https://atom.io/docs/api/v1.4.0/Point#instance-column

A zero-indexed Number representing the row of the Point.

Hope that helps!

Ah, I should have expanded.  Thanks.

authors: WalterGR mnquintana

repo: atom/atom


text:
Uncaught Error: Cannot read property 'object' of undefined TypeError:

This error happened a little bit after I saved a file
Atom Version: 1.10.2
Electron Version: 0.37.8
System: Mac OS X 10.11.5
Thrown From: Atom Core
Error
Uncaught Error: Cannot read property 'object' of undefined TypeError: Cannot read property 'object' of undefined at ObjectsRegistry.get (/Applications/Atom.app/Contents/Resources/electron.asar/browser/objects-registry.js:44:28) at EventEmitter. (/Applications/Atom.app/Contents/Resources/electron.asar/browser/rpc-server.js:309:31) at emitMany (events.js:121:13) at EventEmitter.emit (events.js:195:7) at EventEmitter. (/Applications/Atom.app/Contents/Resources/electron.asar/browser/api/web-contents.js:141:25) at emitTwo (events.js:100:13) at EventEmitter.emit (events.js:185:7)
Stack Trace
Error: Cannot read property 'object' of undefined
TypeError: Cannot read property 'object' of undefined
at ObjectsRegistry.get (/Applications/Atom.app/Contents/Resources/electron.asar/browser/objects-registry.js:44:28)
at EventEmitter. (/Applications/Atom.app/Contents/Resources/electron.asar/browser/rpc-server.js:309:31)
at emitMany (events.js:121:13)
at EventEmitter.emit (events.js:195:7)
at EventEmitter. (/Applications/Atom.app/Contents/Resources/electron.asar/browser/api/web-contents.js:141:25)
at emitTwo (events.js:100:13)
at EventEmitter.emit (events.js:185:7)
at metaToValue (/Applications/Atom.app/Contents/Resources/electron.asar/renderer/api/remote.js:178:13)
at undefined.remoteMemberFunction (/Applications/Atom.app/Contents/Resources/electron.asar/renderer/api/remote.js:112:18)
at AtomEnvironment.module.exports.AtomEnvironment.getWindowDimensions (/Applications/Atom.app/Contents/Resources/app.asar/src/atom-environment.js:636:29)
at AtomEnvironment.module.exports.AtomEnvironment.storeWindowDimensions (/Applications/Atom.app/Contents/Resources/app.asar/src/atom-environment.js:670:36)
at WindowEventHandler.module.exports.WindowEventHandler.handleWindowBlur (/Applications/Atom.app/Contents/Resources/app.asar/src/window-event-handler.js:182:35)
at /Applications/Atom.app/Contents/Resources/app.asar/src/window-event-handler.js:3:61
Commands
     -6:58.1.0 core:save (atom-text-editor.editor.is-focused.autocomplete-active)
  5x -6:28.6.0 core:backspace (atom-text-editor.editor.is-focused.autocomplete-active)
  3x -5:39.4.0 core:save (atom-text-editor.editor.is-focused)
  9x -5:17.8.0 core:select-right (atom-text-editor.editor.is-focused)
     -5:16.2.0 core:select-left (atom-text-editor.editor.is-focused)
  3x -5:05.8.0 core:backspace (atom-text-editor.editor.is-focused)
     -4:44.8.0 core:save (atom-text-editor.editor.is-focused)
  2x -4:35.3.0 core:backspace (atom-text-editor.editor.is-focused.autocomplete-active)
     -3:55.8.0 core:save (atom-text-editor.editor.is-focused.autocomplete-active)
  8x -3:53 core:backspace (atom-text-editor.editor.is-focused)
     -2:55.1.0 core:move-left (atom-text-editor.editor.is-focused)
 12x -1:26.5.0 core:backspace (atom-text-editor.editor.is-focused)
     -0:57.6.0 core:paste (atom-text-editor.editor.is-focused)
     -0:47.7.0 core:save (atom-text-editor.editor.is-focused)
  2x -0:18.9.0 core:backspace (atom-text-editor.editor.is-focused)
     -0:10.1.0 core:save (atom-text-editor.editor.is-focused)

Config
{
  "core": {
    "themes": [
      "atom-material-ui",
      "one-dark-syntax"
    ]
  },
  "editor": {
    "invisibles": {}
  }
}

Installed Packages
# User
atom-material-ui, v1.3.3 (active)
emmet, v2.4.3 (active)
lipsum, v0.1.0 (inactive)
minimap, v4.24.7 (active)
pigments, v0.31.2 (active)
seti-icons, v1.3.3 (active)
atom-dark-syntax, v0.27.0 (inactive)
atom-dark-ui, v0.52.0 (inactive)
atom-light-syntax, v0.28.0 (inactive)
atom-light-ui, v0.44.0 (inactive)
base16-tomorrow-dark-theme, v1.1.0 (inactive)
base16-tomorrow-light-theme, v1.1.1 (inactive)
one-dark-ui, v1.5.0 (inactive)
one-light-ui, v1.5.0 (inactive)
one-dark-syntax, v1.3.0 (active)
one-light-syntax, v1.3.0 (inactive)
solarized-dark-syntax, v1.0.2 (inactive)
solarized-light-syntax, v1.0.2 (inactive)
about, v1.5.3 (active)
archive-view, v0.61.1 (active)
autocomplete-atom-api, v0.10.0 (active)
autocomplete-css, v0.11.2 (active)
autocomplete-html, v0.7.2 (active)
autocomplete-plus, v2.31.1 (active)
autocomplete-snippets, v1.11.0 (active)
autoflow, v0.27.0 (inactive)
autosave, v0.23.1 (active)
background-tips, v0.26.1 (active)
bookmarks, v0.41.0 (active)
bracket-matcher, v0.82.1 (active)
command-palette, v0.38.0 (inactive)
deprecation-cop, v0.54.1 (active)
dev-live-reload, v0.47.0 (active)
encoding-selector, v0.22.0 (active)
exception-reporting, v0.39.0 (active)
find-and-replace, v0.201.0 (active)
fuzzy-finder, v1.3.0 (active)
git-diff, v1.1.0 (active)
go-to-line, v0.31.0 (inactive)
grammar-selector, v0.48.1 (active)
image-view, v0.58.2 (active)
incompatible-packages, v0.26.1 (active)
keybinding-resolver, v0.35.0 (active)
line-ending-selector, v0.5.0 (active)
link, v0.31.1 (inactive)
markdown-preview, v0.158.0 (active)
metrics, v0.53.1 (active)
notifications, v0.65.0 (active)
open-on-github, v1.2.0 (inactive)
package-generator, v1.0.0 (inactive)
settings-view, v0.242.2 (active)
snippets, v1.0.2 (active)
spell-check, v0.67.1 (active)
status-bar, v1.4.1 (active)
styleguide, v0.47.0 (active)
symbols-view, v0.113.0 (inactive)
tabs, v0.100.2 (active)
timecop, v0.33.2 (active)
tree-view, v0.208.2 (active)
update-package-dependencies, v0.10.0 (active)
welcome, v0.34.0 (active)
whitespace, v0.33.0 (active)
wrap-guide, v0.38.1 (active)
language-c, v0.52.1 (active)
language-clojure, v0.21.0 (active)
language-coffee-script, v0.47.2 (active)
language-csharp, v0.12.1 (active)
language-css, v0.37.1 (active)
language-gfm, v0.88.0 (active)
language-git, v0.15.0 (active)
language-go, v0.42.1 (active)
language-html, v0.45.1 (active)
language-hyperlink, v0.16.0 (active)
language-java, v0.23.0 (active)
language-javascript, v0.119.0 (active)
language-json, v0.18.2 (active)
language-less, v0.29.5 (active)
language-make, v0.22.2 (active)
language-mustache, v0.13.0 (active)
language-objective-c, v0.15.1 (active)
language-perl, v0.35.0 (active)
language-php, v0.37.2 (active)
language-property-list, v0.8.0 (active)
language-python, v0.45.0 (active)
language-ruby, v0.69.0 (active)
language-ruby-on-rails, v0.25.0 (active)
language-sass, v0.56.0 (active)
language-shellscript, v0.22.4 (active)
language-source, v0.9.0 (active)
language-sql, v0.23.0 (active)
language-text, v0.7.1 (active)
language-todo, v0.28.0 (active)
language-toml, v0.18.0 (active)
language-xml, v0.34.9 (active)
language-yaml, v0.26.0 (active)

# Dev
No dev packages

This is a duplicate of #11692 - feel free to subscribe there for updates.


text:
Atom package dependency add Unix utils

I am interested in writing an Atom package that may depend on and call a Unix util, specifically a2ps: https://www.gnu.org/software/a2ps/. Is this possible? Thanks.

We're trying to control the amount of Issues that we have to triage and track. For general questions, the Atom message board is where you'll probably be able to find answers faster.


text:
The editor has crashed

Description
As soon as I start atom live server it says editor is crashed

Actual behavior: Editor crashes
Please help me in starting live server

First thing to do would be opening the issue in the right repository. This is an issue with atom live server, so open it there. If the maintainers decide the bug is with Atom, they can then raise the issue on core.

@2sagarraut2  Here is the place it should be raised.


text:
Disable native TextEditor input in non-readonly editors

To complement readonly mode, provide a way to tell a TextEditor that it should not accept keyboard input, but should still be modifiable. This would be useful for any package that wants to take control of the way the editor input is processed (i.e. vim-mode-plus).
@lee-dohm and I were brainstorming names for this mode the other day; setKeyboardInput(false)? setNativeInput(false)?
/cc @t9md

This fix must included before releasing next-beta.
Unless that, vim-mode-plus become useless in atom-beta as it is useless in current atom-master.
history and background
I what share brief history to share same background/context.

Originally vim-mode-plus have been setting editor.component.setInputEnabled(false) to prevent typed char inserted to editor in it's normal-mode.
This is the behavior vim-mode-plus want now.
#16294 introduced readonly editor. It also make calling editor.component.setInputEnabled(false) automatically be readonly editor(which I'm not happy as vim-mode-plus's author)
#16999 make readonly editor protect being mutated through editor's method such as editor.insertText("aaa"). All vim-mode-plus's operator no longer work properly.

Two approaches to fix this.
Either case, what vim-mode-plus want is just get back original behavior which I described at 0. of history and background.
A. Add soft read-only state: (COMPLEX)

How it is enabled: editor.setReadOnly(true, {soft: true})
TODO:

Remove component.setInputEnabled and component.isInputEnabled which is just proxying to editor's method and having different name other than setReadOnly is just confusing.
Reflect soft state to editor.element's className like editor read-only-soft to make it distinguishable from strict read-only only from className.

B. Allow the way to disable input without making editor readOnly

Introduce editor.component.ignoreTextInput(true).

btw this is completely exact behavior of original component.setInputEnabled
Then independently have state at component which is checked in component.didTextInput.

Or revert component.setInputEnabled to the behavior before #16294 intrduced.
Who call component.setInputEnabled other than vim-mode-plus?
If plugin or atom-core really want to make editor read-only they should call editor.setReadOnly or build <atom-text-editor read-only> element.
If plugin or atom-core or vim-mode-plus just want to ignore keytype, use compnent.ignoreTextInput(or component.setInputEnabled whichever).

I like B. approach which is far more simple in implementation-wise.
And also vim-mode-plus's behavior less likely broken by the future change in read-only behavior.

This fix must included before releasing next-beta.

Don't worry, we've got it on our radar and don't plan to release without a fix in.

Allow the way to disable input without making editor readOnly

Yes, this is the way we're leaning as well, as described in the body of this issue.

Introduce editor.component.ignoreTextInput(true)

I kind of like ignoreTextInput as a name. What do you think @smashwilson?

authors: lee-dohm smashwilson t9md


text:
Uncaught Error: The specified module could not be found./?~\AppData\Local\atom\app-1.27.0\res...

[Enter steps to reproduce:]

...
...

Atom: 1.27.0 x64
Electron: 1.7.11
OS: Microsoft Windows 10 Pro
Thrown From: Atom Core
Stack Trace
Uncaught Error: The specified module could not be found.
\?\C:\Users\mamun\AppData\Local\atom\app-1.27.0\resources\app.asar.unpacked\node_modules\keyboard-layout\build\Release\keyboard-layout-manager.node
At ELECTRON_ASAR.js:173

Error: The specified module could not be found.
\\?\C:\Users\mamun\AppData\Local\atom\app-1.27.0\resources\app.asar.unpacked\node_modules\keyboard-layout\build\Release\keyboard-layout-manager.node
    at process.module.(anonymous function) [as dlopen] (ELECTRON_ASAR.js:173:20)
    at Object.Module._extensions..node (module.js:598:18)
    at Object.module.(anonymous function) [as .node] (ELECTRON_ASAR.js:187:18)
    at Module.load (module.js:488:32)
    at tryModuleLoad (module.js:447:12)
    at Function.Module._load (module.js:439:3)
    at Module.require (/app.asar/static/index.js:47:45)
    at require (internal/module.js:20:19)
    at customRequire (~/AppData/Local/atom/app-1.27.0/resources/app/static/<embedded>:96:26)
    at get_KeyboardLayoutManager (~/AppData/Local/atom/app-1.27.0/resources/app/node_modules/keyboard-layout/lib/keyboard-layout.js:7:65)
    at get_manager (~/AppData/Local/atom/app-1.27.0/resources/app/node_modules/keyboard-layout/lib/keyboard-layout.js:16:42)
    at Object.getCurrentKeyboardLayout (~/AppData/Local/atom/app-1.27.0/resources/app/node_modules/keyboard-layout/lib/keyboard-layout.js:32:17)
    at exports.keystrokeForKeyboardEvent (~/AppData/Local/atom/app-1.27.0/resources/app/node_modules/atom-keymap/lib/helpers.js:201:42)
    at KeymapManager.module.exports.KeymapManager.keystrokeForKeyboardEvent (~/AppData/Local/atom/app-1.27.0/resources/app/node_modules/atom-keymap/lib/keymap-manager.js:467:20)
    at KeymapManager.module.exports.KeymapManager.handleKeyboardEvent (~/AppData/Local/atom/app-1.27.0/resources/app/node_modules/atom-keymap/lib/keymap-manager.js:347:30)
    at WindowEventHandler.handleDocumentKeyEvent (~/AppData/Local/atom/app-1.27.0/resources/app/src/window-event-handler.js:110:40)

Commands
     -0:55.1.0 core:copy (div.line)

Non-Core Packages
atom-beautify undefined
atom-html-preview 0.2.5
atom-knockout 1.0.1
atom-ternjs 0.18.3
autoclose-html 0.23.0
autocomplete-bash-builtins 0.3.5
busy-signal 1.4.3
gaia-dark-syntax 2.1.0
github-atom-light-syntax 0.5.0
intentions 1.1.5
linter 2.2.0
linter-php 1.3.2
linter-ui-default 1.6.4
php-cs-fixer 4.1.0
php-debug 0.2.5
php-integrator-autocomplete-plus 1.6.1
php-integrator-autocomplete-plus-legacy-php56 1.0.1
pretty-json 1.6.4
windows-context-menu 0.3.1

+1
Atom: 1.27.0 x64
Electron: 1.7.11
OS: Microsoft Windows 10 Pro
no packages installed
the error message pops when clicking none text keyboard keys (ctrl,backspace,delete etc.)
makes it impossible to use atom

I think this is a duplicate of issues like #15722. If you have any anti-virus software running, please check if there are any messages about quarantining this file and then see if you can restore it, or try to re-install with your anti-virus temporarily disabled. If you don't have any anti-virus software running or re-installing doesn't help, let me know (it could be a duplicate of https://github.com/atom/atom/issues/14461 as well).

authors: rsese smartoarif supraniti


text:
Uncaught TypeError: Path must be a string. Received undefined

[Enter steps to reproduce:]

...
...

Atom: 1.27.2 x64
Electron: 1.7.15
OS: Mac OS X 10.13.5
Thrown From: Atom Core
Stack Trace
Uncaught TypeError: Path must be a string. Received undefined
At path.js:7

TypeError: Path must be a string. Received undefined
    at assertPath (path.js:7:11)
    at Object.join (path.js:1211:7)
    at onEvents.events.map.event (/Applications/Atom.app/Contents/Resources/app/src/path-watcher.js:283:46)
    at Array.map (native)
    at handler (/Applications/Atom.app/Contents/Resources/app/src/path-watcher.js:276:34)

Commands
     -3:25.6.0 core:move-up (input.hidden-input)
     -3:24.4.0 core:move-down (input.hidden-input)
     -3:23.9.0 core:move-right (input.hidden-input)
     -3:23.3.0 editor:move-to-end-of-screen-line (input.hidden-input)
     -3:14 editor:newline (input.hidden-input)
  6x -3:11.7.0 core:backspace (input.hidden-input)
     -3:01.2.0 core:save (input.hidden-input)
  2x -2:47 editor:newline (input.hidden-input)
     -2:42.1.0 autocomplete-plus:activate (atom-text-editor.editor)
     -2:32.8.0 core:move-right (input.hidden-input)
     -2:30.9.0 autocomplete-plus:confirm (input.hidden-input)
     -2:24.8.0 autocomplete-plus:activate (atom-text-editor.editor)
     -2:22.1.0 autocomplete-plus:confirm (input.hidden-input)
     -2:20.7.0 core:save (input.hidden-input)
     -2:14.9.0 core:backspace (input.hidden-input)
     -2:06.1.0 core:save (input.hidden-input)

Non-Core Packages
autocomplete-python 1.10.5
busy-signal 1.4.3
file-icons 2.1.21
intentions 1.1.5
linter 2.2.0
linter-pylint 2.1.1
linter-ui-default 1.7.1
pretty-json 2.0.1

Thanks for contributing!
We noticed that this looks like a duplicate of https://github.com/atom/atom/issues/14227 so you can subscribe there if you'd like.

Because we treat our issues list as the Atom team's backlog, we close duplicates to focus our work and not have to touch the same chunk of code for the same reason multiple times. This is also why we may mark something as duplicate that isn't an exact duplicate but is closely related.
For information on how to use GitHub's search feature to find out if something is a duplicate before filing, see the How Can I Contribute? section of the Atom CONTRIBUTING guide.

authors: chrifost rsese


text:
error when diffing file changes

Prerequisites

[X ] Put an X between the brackets on this line if you have done all of the following:

Reproduced the problem in Safe Mode: https://flight-manual.atom.io/hacking-atom/sections/debugging/#using-safe-mode
Followed all applicable steps in the debugging guide: https://flight-manual.atom.io/hacking-atom/sections/debugging/
Checked the FAQs on the message board for common solutions: https://discuss.atom.io/c/faq
Checked that your issue isn't already filed: https://github.com/issues?utf8=✓&q=is%3Aissue+user%3Aatom
Checked that there is not already an Atom package that provides the described functionality: https://atom.io/packages

Description
unable to save file: Permissions denied '/atom:'

Steps to Reproduce

Open project
Change something in a file
Click on the 'Open file in Diff View' icon next to the changed file under the UNCOMMITTED CHANGES section
Give credentials to Atom Helper dialog asking for permissions.

Expected behavior: [What you expect to happen]
Show visual diff of the changes made to the file.
Actual behavior: [What actually happens]
Error notification pops up with text from above
Reproduces how often: [What percentage of the time does it reproduce?]
Every time.
Versions
You can get this information from copy and pasting the output of atom --version and apm --version from the command line. Also, please include the OS and what version of the OS you're running.
$ atom --version
Atom    : 1.29.0
Electron: 2.0.5
Chrome  : 61.0.3163.100
Node    : 8.9.3

$ apm --version
apm  1.19.0
npm  3.10.10
node 6.9.5 x64
atom 1.29.0
python 3.7.0
git 2.18.0

Mac OS 10.12.6.
Additional Information
Any additional information, configuration or data that might be necessary to reproduce the issue.

Thanks for the report!

Click on the 'Open file in Diff View' icon next to the changed file under the UNCOMMITTED CHANGES section

Hmmm, can you clarify this part?  The GitHub package doesn't have an "UNCOMMITTED CHANGES" section but maybe I'm looking in the wrong place.  Can you share a screenshot?

Yes I have the Nuclide plugin installed.

Ahhh ok - it may be that there is still a bug in Atom but if so, we'll need the https://github.com/facebook/nuclide maintainers to help track that down.  You should file this issue on their repository so they can either fix the problem or tell us where the problem is coming from. The Atom FAQ has information on how to contact the maintainers of any Atom community package or theme.

Looks like someone beat me to it https://github.com/facebook/nuclide/issues/1556

authors: kevwil rsese


text:
Atom is not opening an empty editor on start

Atom is not opening an empty editor on start.
It's basically issue #10623, except it apparently hasn't been solved for some reason.

"Open Empty Editor At Start" is checked
"Restore Previous Windows On Start" is "no"
welcome: showOnStartup: false
Tried in safe mode, problem was still there
the process.nextTick -> trick for init.coffee had no effect
closing manually every single tab, still opened the same "project" at startup

I have an open folder and open files, some of the files modified, and I'm closing it with the top-right X.
Atom:
$ atom --version

Atom    : 1.44.0
Electron: 4.2.7
Chrome  : 69.0.3497.128
Node    : 10.11.0

Windows:
OS Name	Microsoft Windows 10 Enterprise
Version	10.0.18362 Build 18362

Thanks for reporting this!
This has already been fixed in https://github.com/atom/atom/pull/20547. The fix is currently available in the latest version of atom v1.51.0.


text:
wrong architecture? running xubuntu 14 on intel i7

Hi,
I would love to install Atom on my machine but the .deb and the .rpm (using alien) both say "wrong architecture".
I have a Lenovo T431s with an Intel i7 vPro with Xubuntu
This is my uname -a result:
3.16.0-48-generic #64~14.04.1-Ubuntu SMP Thu Aug 20 23:03:49 UTC 2015 i686 i686 i686 GNU/Linux

Any idea how to install atom?
Cheers!
Jerry

Hi Jerry, both the .deb and .rpm are currently built for x64 systems only.  If you want to run Atom on x32, you'll need to build it by yourself, sorry.


text:
Issues when opening new files : tabs do not show up

Hey I've got a very annoying issue right know : Every time I want to open a new file into my project (by double click on tree view or with cmd + p). The file is open, but no tab are visible for this file
I noticed that an error pops everytime I do it :
Uncaught (in promise) TypeError: deprecationSite.getFileName is not a function(…)

Here is my config :
"*":
  "exception-reporting":
    userId: "50a72f92-1de6-c058-6e00-a9cee2334fd9"
  "release-notes":
    viewedVersion: "0.84.0"
  welcome:
    showOnStartup: false
  metrics:
    userId: "2878163b4b361702a451e57922df9c59ef809b5b"
  editor:
    invisibles:
      space: "."
      tab: "_"
      eol: " "
    tabLength: 4
    fontSize: 20
    lineHeight: 2
    scrollPastEnd: true
    scrollSensitivity: 50
    tabType: "soft"
    showInvisibles: true
    showIndentGuide: true
  core:
    themes: [
      "atom-material-ui"
      "material-syntax"
    ]
    ignoredNames: [
      ".git"
      ".svn"
      ".DS_Store"
    ]
    disabledPackages: [
      "linter-bootlint"
      "merge-conflicts"
      "minimap"
    ]
  "atom-material-ui":
    slimScrollbar: true
    useRoboto: true
    depth: false
    panelContrast: false
    disableAnimations: false
    rippleAccentColor: false
    fonts:
      useRoboto: true
    treeView: {}
    tabs:
      tabMinWidth: true
    ui:
      accentColor: "Blue"
    panels:
      altCmdPalette: false
  "emmet-simplified": {}
  "color-picker":
    abbreviateValues: true
    automaticReplace: true
  "tree-view": {}
  "linter-scss-lint":
    executablePath: "/usr/local/bin/scss-lint"
  linter:
    showErrorTabLine: true
    showErrorPanel: false
  "git-blame":
    ignoreWhiteSpaceDiffs: false
    useCustomUrlTemplateIfStandardRemotesFail: true
  "git-blame-plus": {}
  "linter-htmlhint": {}
  "linter-jshint":
    lintInlineJavaScript: true
  blame: {}
  minimap: {}
  "atom-beautify":
    _loggerLevel: "error"
    css_align_assignments: true
    css_force_indentation: true
    css_newline_between_rules: true
    css_no_lead_zero: true
    css_preserve_newlines: true
    css_selector_separator_newline: true
    _analyticsUserId: "79722fab-1165-499f-8c44-56fd6f16ca8a"
    js_indent_char: "  "

and that's all my packages :
angularjs@0.3.3
atom-beautify@0.28.18
atom-jade@0.3.0
atom-material-syntax@0.2.4
atom-material-ui@0.8.0
autocomplete-paths@1.0.2
blame@0.7.0
color-picker@2.0.13
emmet@2.3.14
goto@1.7.1
gulp-helper@5.0.0
hyperclick
jquery-snippets@11.0.0
linter@1.11.1
linter-htmlhint@0.2.1
linter-jshint@1.2.1
linter-less@2.2.0
linter-php@1.1.1
linter-scss-lint@2.4.0
material-syntax@0.5.0
merge-conflicts@1.3.7
minimap@4.16.0
nuclide-arcanist@0.0.32
nuclide-blame
nuclide-blame-provider-hg
nuclide-blame-ui@0.0.32
nuclide-buck-files@0.0.32
nuclide-installer@0.0.32
php-twig@4.0.0
project-manager@2.6.5
seti-icons@0.4.5
seti-syntax@0.4.1
seti-ui@0.8.1
sort-lines@0.12.0
symfony-snippets@0.3.0
tabs-to-spaces@0.11.1
tabularize@0.2.5
text-pastry@0.6.1
toggle-quotes@0.11.3
tool-bar-main@0.0.8

thank you for your help !

This is an issue with Nuclide packages - please see #9350 for more details.


text:
Swap underlying editor correctly when calling setModel on editor element

Fixes #15005.
Previously, when setModel was called, we forgot to update the pointer to the component in the newly supplied editor. This was causing the element to not update in response to model updates but only as a result of focus or visibility changes. We suspect this regressed during the rewrite of the editor rendering layer.
With this pull request we will now correctly swap the element's underlying editor by updating the component pointer on the newly supplied editor. Also, if the element was already attached to another editor, we will null out the component reference on it, because one instance of TextEditorElement can only represent one instance of TextEditor.
/cc: @nathansobo @tjfryan

This looks reasonable. I'll take a look at the test failure now.

❤ @ungb

Thank you so much!

authors: as-cii nathansobo tjfryan


text:
Judge resize of overlay by contentRect changing

fix https://github.com/atom/atom/issues/16077
In the OverlayComponent resize observer, we're judging whether the element resized by comparing the contentRect with the result of a call to getBoundingClientRect() here. The dimensions reported by these two methods aren't always the same[1][2]. This results in a resize observer loop while the overlay decorations are present:

In this fix, we store the previous contentRect as reported in the ResizeObserver callback as state on the OverlayComponent. That way in subsequent calls of the ResizeObserver callback, we're comparing contentRect's to contentRect's.
@DavidLGoldberg thanks for reporting this bug and the work to help reproduce it on various builds!
/cc @nathansobo

⚡ Thanks @leroix @DavidLGoldberg.

Unfortunately guys, My app is still in a state of disarray.
Oddly it still works with the baby blue dev build OR any other build with atom -d.
If it were only working with just the -d I'd say maybe I don't know how to use git or the dev mode but...I've been doing it for a while now ;)
Here's a bit more description:
https://github.com/DavidLGoldberg/jumpy/issues/108

@DavidLGoldberg the commit indicates that this fix is only in Atom 1.23.0-beta0 and later...have you tried that version?

Oh very sorry I'll check as soon as I get home!  When will that go live?
On Tue, Nov 7, 2017, 6:43 PM Wliu notifications@github.com wrote:

@DavidLGoldberg https://github.com/davidlgoldberg the commit indicates
that this fix is only in Atom 1.23.0-beta0 and later...have you tried that
version?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/atom/atom/pull/16083#issuecomment-342661507, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAjTr-9sb5xgGteek0rCTrKiGfkHRj5aks5s0Os7gaJpZM4QQXsA
.

@50Wliu @leroix @nathansobo ,
I tested on the Atom 1.23.0-beta0 and it works smoothly.  Thanks for catching that @50Wliu .
I launched a 4.1.0 with a small little feature / fix and a yellow warning notification explaining the situation.
BTW, I put the notification object on the package's constructor / activation.  I guess this will trigger for any new windows / reloads, but it's pretty easy to dismiss.
Is there a built in way to have this show once and only once to users?  I didn't want to start fumbling with localStorage or any of that, but could it be done?
Would this be a useful feature to add into Atom's core notifications if I can get around to it?
Actually I kind of like the idea of being able to push these things to some managed bulletin but I know there are security concerns / limitations.  It'd be really cool if it just read from any GH issue tagged with a certain tag :-p

Would this be a useful feature to add into Atom's core notifications if I can get around to it?

Yeah, that's a great idea. Some kind of way of identifying a notification and requesting that it only runs once would be a good feature. I'll be interested to hear your thoughts on the design.

I thought that #16086 was a fix for 1.22 but it seems like we must have missed something. I think we should follow up rather than leaving this broken for a whole release cycle.

Ok, so this might sound unbelievable with my limited Atom expertise (I have a hard time believing it myself) but I believe there is a much bigger issue at play.
This may have started since I did a local build of atom (with baby blue icon, I love that by the way).
But I did an install using the downloadable executable from atom.io and now have the good ole stable green icon for both
atom
and
atom -d
The weird thing is though that everytime I do atom -d  Jumpy performance has no issue.  My jumpy repo has a clean git status and it's equivalent to my master branch now (4.1.0).
Atom beta NON dev mode also of course works because it has the fix.
Is this all just a problem with my machine?
I only really have one dev env at the moment unfortunately.
If one of you could do
apm develop jumpy and verify that atom -d doesn't perform well I'd feel better.  If it does well, then there's something scary wrong with dev mode as of late.
Right?  What do I have confused?
(FYI: You have to perform a full jump now to see the 2nd iteration of the performance issue.)
-David

authors: 50Wliu DavidLGoldberg leroix nathansobo


text:
bump Contributor Covenant version to 1.3

This updates the version from 1.2 to 1.3 in the README and CONTRIBUTING docs.
http://contributor-covenant.org/version/1/3/0/

@zeke Thanks for taking the time to open a pull request for this. :heart:
In the future, could I trouble you to also provide a diff which clearly shows the differences in the text between the two versions? Let me try and explain why that's important. In a way, we're bumping a dependency here (a very important one) and we don't really have any tests which would verify that the new version still works for the project. For that reason, we need humans to verify that manually, and it is much easier to do that when you can see the whole and exact diff in one place (instead of just the diff for changing the URL, and without asking people to figure out the diff themselves). Does that make sense?
I've gone ahead and did that below:
@@ -12,10 +12,12 @@ Trolling or insulting/derogatory comments
 Public or private harassment
 Publishing other's private information, such as physical or electronic addresses, without explicit permission
 Other unethical or unprofessional conduct
-Project maintainers have the right and responsibility to remove, edit, or reject comments, commits, code, wiki edits, issues, and other contributions that are not aligned to this Code of Conduct. By adopting this Code of Conduct, project maintainers commit themselves to fairly and consistently applying these principles to every aspect of managing this project. Project maintainers who do not follow or enforce the Code of Conduct may be permanently removed from the project team.
+Project maintainers have the right and responsibility to remove, edit, or reject comments, commits, code, wiki edits, issues, and other contributions that are not aligned to this Code of Conduct, or to ban temporarily or permanently any contributor for other behaviors that they deem inappropriate, threatening, offensive, or harmful.
+
+By adopting this Code of Conduct, project maintainers commit themselves to fairly and consistently applying these principles to every aspect of managing this project. Project maintainers who do not follow or enforce the Code of Conduct may be permanently removed from the project team.

 This code of conduct applies both within project spaces and in public spaces when an individual is representing the project or its community.

-Instances of abusive, harassing, or otherwise unacceptable behavior may be reported by opening an issue or contacting one or more of the project maintainers.
+Instances of abusive, harassing, or otherwise unacceptable behavior may be reported by contacting a project maintainer at [INSERT EMAIL ADDRESS]. All complaints will be reviewed and investigated and will result in a response that is deemed necessary and appropriate to the circumstances. Maintainers are obligated to maintain confidentiality with regard to the reporter of an incident.

-This Code of Conduct is adapted from the Contributor Covenant, version 1.2.0, available from http://contributor-covenant.org/version/1/2/0/
+This Code of Conduct is adapted from the Contributor Covenant, version 1.3.0, available from http://contributor-covenant.org/version/1/3/0/

@atom/core @atom/feedback How do you all feel about these changes? I'll add my thoughts when I find a moment to read this thoroughly.
I did notice one change, though:
... by contacting a project maintainer at [INSERT EMAIL ADDRESS] ...

That makes me think that just linking to the Contributor Covenant isn't going to work anymore and we need to have a local copy of it with that part substituted with an actual email address.

That makes me think that just linking to the Contributor Covenant isn't going to work anymore and we need to have a local copy of it with that part substituted with an actual email address.

Agreed. Didn't Contributor Covenant once have a query parameter version that would put the right things in the right places?

The Elixir language project uses a CODE_OF_CONDUCT.md in their project. Perhaps we could do the same.

The Elixir language project uses a CODE_OF_CONDUCT.md in their project. Perhaps we could do the same.

@lee-dohm Yeah, I prefer that approach over linking to an external site. :+1:
I just had another look at the changes in the code of conduct and they look find to me. @atom/feedback if you don't see any :red_circle: :flags: in these changes, we can create a local copy of the code of conduct and add our email address to it (or just a link to https://atom.io/contact ?).

Changes look fine to me!  I like the extra language about banning.

I'm :+1: on the changes. Thank you for the diff @izuzak. I think the email address would be better than the contact form. Email addresses are a little more clear on to whom they are going, which is better in a situation that is potentially embarrassing.

Sorry for the slow response. I subscribed to the whole atom/atom repo and it got lost in sea of issues! I'm happy to update this PR with a local CODE_OF_CONDUCT.md.
What email address should be used?

I believe it's atom@github.com.

Added a file and mailto link to atom@github.com
This is ready for review.

Fetched upstream master and rebased to see if that fixes the (seemingly-unrelated) CI failure.

:+1:.
In the future, just add [ci skip] to these kinds of commits (ie ones that don't touch code or change functionality) since there's no point in testing them.

[ci skip]

Nice. Will do!

Thanks @zeke!

:+1: Looks good to me! Totally fine with the changes here.

Thanks for this @zeke
Would you be up for doing a similar pull request to Electron?

authors: 50Wliu izuzak kevinsawicki lee-dohm mnquintana zeke


text:
Less intrusive autocomplete

Would it be possible to get a less intrusive autocomplete, something more like TextMate's where you press escape to cycle through alternatives.
When I code I almost always know what I want to autocomplete to, I just don't want to type it. Having to select from a list makes me slower, not faster.
At the same time, I know that many like autocomplete with a list and are used to that from other editors, so I'm just asking for a way to run the autocomplete in a less UI-driven manner. If there were actions for autocomplete with next suggestion I could hook up the keymappings myself, but as far as I can tell it's not currently possible, at least I didn't manage to autocomplete without showing the alternatives panel.

+1 for wanting to be able to disable autocomplete. I love everything about atom but I have to uninstall it. It's too obtrusive to my workflow. Hopefully optional disable is a feature in the next release!

@grahammutter could you elaborate a bit please?  I have to press Ctrl+Space in order to toggle autocomplete.  In addition, if it is always on by default for you somehow, you can always disable this package by going to Settings-->Packages-->autocomplete.
Also, this probably is even more obtrusive, but you may want to take a look at autocomplete-plus which will be replacing the default autocomplete in the near future.

Settings-->Packages-->autocomplete only disables my ability to manually call the autocomplete, but it still automatically brings itself up after 95% of keypresses. Perhaps my build is bugged. I'll try clean wiping it and reinstalling.

I've figured out what was causing it. autocomplete-plus is a dependency for the TypeScript plugin. Though I was uninstalling it, it was being automatically reinstalled on every launch. Disabling keystroke suggestions in the autocomplete-plus plugin but leaving it installed has worked as a fix.

+1 on disabling keystroke suggestions.  My reaction was: too visually distracting.  The keystroke suggester is far too aggressive.  I like Visual Studio's more restrained suggestions.  If I'm "dotting into" an object, it's nice to automatically see a list of the properties and functions within it.  The rest of the time, I just want to type.  As a compromise, I'm OK with having to manually press Ctrl+Space when I want help in Atom, to avoid the stress of constantly losing my focus because of visual churn.

This repo is no longer maintained - Atom's autocomplete functionality is now provided by https://github.com/atom/autocomplete-plus

This package is deprecated and no longer shipped with Atom. If this is still an issue using the autocomplete-plus package, please open up a new issue on that repository, thanks.

authors: 50Wliu cosinekitty grahammutter iconara kevinsawicki mnquintana

repo: atom/autocomplete


text:
Update quick-start.md for zh-CN

Fixed some typo.

Thanks!

authors: neutrous zcbenz

repo: atom/electron


text:
isMisspelled() always returns false on Win 7

Hi,
I've been using the spellchecker on Macos and Win10 and it works perfectly on both.
Unfortunately when I try to use it on Win7 it is not working.
getAvailableDictionaries() return an empty array.
I tried to add this to my configuration and it copy correctly the files but it doesn't change anything.
...
"extraResources": [
     {
        "from": "node_modules/spellchecker/vendor",
        "to": "app.asar.unpacked/node_modules/spellchecker/vendor",
        "filter": "**/*"
      }
    ],
...

The doc says :

Windows 7 and below as well as Linux will rely on Hunspell

But no matter what I try, the array of available dictionaries stays empty and isMisspeled return always false. By default I set the dictionary to en-US.
Does any of you have successfully setup the spellchecker for Windows 7 with Hunspell and if yes, how ?

You can use https://github.com/Wulf/nodehun in the meanwhile.  brew install hunspell or sudo apt-get install hunspell.  Not sure about Windows support, but it looks like Chocolatey has hunspell package as well.

authors: AshDevFr niftylettuce

repo: atom/node-spellchecker