text:
Remove user safelist for WebKit exports

This snippet of code caught attention in https://github.com/web-platform-tests/wpt-pr-bot/pull/63#discussion_r254678028:
https://github.com/web-platform-tests/wpt-pr-bot/blob/4a9ab1236de3808a134cf9e8625577f104db63cd/lib/metadata/index.js#L32-L36
This probably doesn't match the current WebKit export script, which anyone can use.
@youennf what is the export flow, and what signals could wpt-pr-bot use to confidently mark a PR as reviewed in WebKit?

@rniwa @litherum

AFAIK nobody is specifically in charge of running this script so we could receive PR from any contributor. Also, the limitation assigning the label for people with no +w in the WPT project is also  causing that those PR are being created without the label because lack of permissions.
I'd suggest to use the WebKit export of and  or the https://bugs.webkit.org/show_bug.cgi?id=   string occurrences from the PR title to set the label directly from the  wpt-pr-bot to work-around this current limitation. It seems the most handy way to handle this.
Based on this, we could setup then a Github Action which for each the PR still open and tagged with wetkit-export checks if the bugzilla reported issue in the description is fixed to label this as reviewed (or any other)

In addition to correctly labeling and approving the PRs, there’s also the question of merging them. Having the bot automatically approve is actually not enough, as you still need a user with write access to the repo to merge. The bot could do it, but when?
When opening up to merging as well, the security matters more, so we’d need a solid way to verify that the PR matches what’s been reviewed and approved in WebKit.
@stephenmcgruer

Based on this, we could setup then a Github Action which for each the PR still open and tagged with wetkit-export checks if the bugzilla reported issue in the description is fixed to label this as reviewed (or any other)

For example:
>>> import requests
>>> response = requests.get("https://bugs.webkit.org/rest/bug/200081")
>>> response.json()['bugs'][0]['resolution']
u'FIXED'

We don't want to wait until the bug is closed because the WebKit workflow is that upstream WPT PR must be merged before the patch is landed in WebKit side.

We don't want to wait until the bug is closed because the WebKit workflow is that upstream WPT PR must be merged before the patch is landed in WebKit side.

Should we establish then the r+ as  the right point for this?
I still have doubts because if WK workflow requires WPT PR merged before then I miss these PR merged, approved or some similar label here :-/

https://github.com/web-platform-tests/wpt/pull/8956
https://github.com/web-platform-tests/wpt/pull/16940
https://github.com/web-platform-tests/wpt/pull/17801
https://github.com/web-platform-tests/wpt/pull/17825
https://github.com/web-platform-tests/wpt/pull/19538

We don't want to wait until the bug is closed because the WebKit workflow is that upstream WPT PR must be merged before the patch is landed in WebKit side.

Should we establish then the r+ as the right point for this?

We could get this information from the bugzilla rest API too:
>>> import requests
>>> r = requests.get("https://bugs.webkit.org/rest/bug/200081/history")
>>> j = r.json()
>>> j['bugs'][0]['history'][6]['changes'][1]['added']
u'review+'

We don't want to wait until the bug is closed because the WebKit workflow is that upstream WPT PR must be merged before the patch is landed in WebKit side.

Should we establish then the r+ as the right point for this?

Yes.

Alright, that sounds like a plan! Seems like wpt-pr-bot could approve the PR and possibly point directly to the approval in bugs.webkit.org.
Because reviews in bugs.webkit.org wouldn't trigger anything directly in WPT, there might need to be a polling action to check this on open webkit exports regularly.
Or... is it possible to add a webhook in bugs.webkit.org that would send a request to a URL of our choosing?

Because reviews in bugs.webkit.org wouldn't trigger anything directly in WPT, there might need to be a polling action to check this on open webkit exports regularly.
Or... is it possible to add a webhook in bugs.webkit.org that would send a request to a URL of our choosing?
I didn't play too much with bugzilla but apparently we could trigger that from the
bug_end_of_update hook. bug_end_of_update basically provides the same info  that we can get from https://github.com/web-platform-tests/wpt-pr-bot/issues/100#issuecomment-550060246.

Not sure how this hooks in bugzilla works and , for example, if they has retry mechanism in case of network issues or service is down situations. In negative case,  a pulling cronjob action iterating the current actions looks much more reliable.
BTW, I don't see either any example of hook in use by bugs.webkit.org in the source code. ... but I see examples about how this is integrated with the Early Warning System (using extensions):
commit 1b60da135712f264d3a73d7caf73eb13f537a999
Author: dbates@webkit.org <dbates@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date:   Tue Jun 19 20:35:03 2018 +0000

    EWS for security bugs
    https://bugs.webkit.org/show_bug.cgi?id=186291
    <rdar://problem/40829658>

    Reviewed by Lucas Forschler

    Part 2 of 2.

    Adds a new Bugzilla extension that will automatically CC the EWS feeder queue
    on each bug that has a patch up for review, including security bugs. This allows
    the WebKit OpenSource Project to use an unprivileged Bugzilla account for the
    EWS feeder queue.

Ah, maybe hooking into EWS could be a way here. It looks like extensions are written using Perl, but probably it'd make the most sense to have the actual logic written in Python in webkitpy or wpt, or as part of wpt-pr-bot in this repo.
@psaavedra as a start, can you look into what it would look like to check the reviewed status in WebKit as part of this repo? If it's only a small amount of code it's OK even though the future of this repo is uncertain.

Ah, maybe hooking into EWS could be a way here. It looks like extensions are written using Perl, but probably it'd make the most sense to have the actual logic written in Python in webkitpy or wpt, or as part of wpt-pr-bot in this repo.

not sure because the EWS runs before of any review. In other works you need the EWS results in green before receive  a r+ (normally).

@psaavedra as a start, can you look into what it would look like to check the reviewed status in WebKit as part of this repo? If it's only a small amount of code it's OK even though the future of this repo is uncertain.

You mean, how difficult is to check if the bug is r+ before to export the changes in the export-w3c-test-changes tool?. Sure I think It is not so difficult because we could get it from the bugzilla API.

EWS runs before of any review

I see, EWS wouldn't work then. Is there anything that happens after a patch is reviewed that would be possible to hook into?

check if the bug is r+ before to export the changes in the export-w3c-test-changes tool?

Not quite, I mean to check for r+ before wpt-pr-bot marks the export PR as reviewed. Merely creating it before it's reviewed is fine, perhaps people would do that in order to see the results on other browsers before asking for review.

perhaps people would do that in order to see the results on other browsers before asking for
review.
Yes that would be really useful.

Ideally, we would create the WPT PR either at patch upload or at "r?".
At patch upload is probably the best approach as long as we handle patch reupload as a way to update the WPT PR.
We would either merge the PR manually at any time after the "r+" or merge automatically at "cq+" time.

Not quite, I mean to check for r+ before wpt-pr-bot marks the export PR as reviewed

Then I see wpt-pr-bot or a Github Action like the best places where checking this.
For each opened PR :
    If  PR with a bug in bug.webkit.org related in the description:
        Check the `changes` in `https://bugs.webkit.org/rest/bug/999999/history`:
            If `r+` => set label `Approved`

Ideally, we would create the WPT PR either at patch upload or at "r?".

but, how we can identify a patch  as candidate to be  submitted as PR in WPT? I dont see a reliable way to do it.

...
We would either merge the PR manually at any time after the "r+" or merge automatically at "cq+" time.

I understand, the point here is automate this ... at least labeling the PR as Approved or Reviewed

how we can identify a patch as candidate to be submitted as PR in WPT? I dont see a reliable way to do it.

Basically, any change to LayoutTests/imported/w3c/web-platform-tests (except for some files like -expected.txt, log, any.html...)
Tools/Script/export-w3c-tests is doing most of this work.
This script is integrated with "webkit-patch upload" to ask webkit developers whether they want to generate a PR whenever a change is detected. These scripts need some more refinements though, especially if they run on a bot.

Is webkit-patch upload the main supported way to upload code reviews for WebKit? If so integrating with that somehow sounds good.
However, because exports for people who aren't WebKit or WPT reviewers should work, some piece of approving and possibly merging export PRs needs to be performed by something other than that script. If the signal for "this is reviewed in WebKit" is clear, then does that work to resolve this issue?

However, because exports for people who aren't WebKit or WPT reviewers should work, some piece of approving and possibly merging export PRs needs to be performed by something other than that script. If the signal for "this is reviewed in WebKit" is clear, then does that work to resolve this issue?

I suppose we need manual action for those cases. I don't see other option.
At this point, I have to recap... Do we have clear the criteria to set a PR as "reviewed"?

For this specific issue yes, getting a r+ signal from bugs.webkit.org is sufficient to mark the WPT PR as "reviewed".

@youennf how would you like to deal with merging the export PRs ideally? Even if this bots auto-approves it will still require someone with write access to actually merge it.
Is there also a signal that merging is expected, so that this could also be automated?

Ideally, PR would be merged automatically as part of putting patch in webkit commit queue. That would allow resolving any potential conflict before actually landing webkit patch.
webkit-patch land is another way to land and could be updated to trigger merging.
Or pre/post commit hooks as a last resort.

Where is the code for the WebKit commit queue maintained? Would it be simple enough to add GitHub credentials and code to merge the PR there, or would there be concerns about depending on a third party?
Do the CQ and webkit-patch land have any common code path that could be used?

@psaavedra, @clopez and I discussed this a bit today. This issue is very specific about a few lines of non-ideal code, but the larger issue is making it very low-friction to work with web-platform-tests in WebKit, and while I heard at https://webkit.org/meeting/ that smooth export isn't the biggest blocker, I believe it will become more of an issue as contributions from WebKit increase.
I think the best case for export from WebKit to WPT is bot actions for each of these events:

Uploading or requesting review on a WebKit patch creates a draft export PR
Getting review (r+) on the WebKit patch approves the export PR
The export PR is merged when the WebKit patch is about to land

Additionally, because of the possibility of reverts that bypass commit queue:

Changes to WebKit trunk which don't have an export PR gets one created, approved and merged ASAP

@youennf @rniwa does that sound about right, and which if any of these parts do you think is most valuable?
There are many options for where to integrate tooling, but I think rough agreement on what actions are taken by bots is more important than those details for now.

Looks like https://bugs.webkit.org/show_bug.cgi?id=167911 is the relevant WebKit bug for the overall issue of low-friction import/export. I only found it now, and I don't mind where the discussion happens if moving there would be more appropriate.

Additionally, because of the possibility of reverts that bypass commit queue:

You mean a patch in WebKit can get reverted? Why is that an issue? Even if a patch gets reverted, there is no issue in merging the associated test to WPT.

Changes to WebKit trunk which don't have an export PR gets one created, approved and merged ASAP

Could you elaborate what you mean by this?

You mean a patch in WebKit can get reverted? Why is that an issue? Even if a patch gets reverted, there is no issue in merging the associated test to WPT.

We could go either way I guess.
We probably do not want to block WebKit revert patch landing on WPT though.
It seems slightly easier to not revert WPT changes and have specific handling for the relanding patches.

You mean a patch in WebKit can get reverted? Why is that an issue? Even if a patch gets reverted, there is no issue in merging the associated test to WPT.

@rniwa yes, revert on WebKit trunk that bypass CQ is what I mean. Sometimes the test will still be fine, but the reason for the revert can be that the test is flaky. This happens in Chromium at least, with https://github.com/web-platform-tests/wpt/pull/17548 being an example.
Leaving this problem until later would be fine with me though.

Looks like there are many considerations involved here and a need for wider input from the WebKit community all together. With the idea of facilitating this, I've written a document summarizing the current situation based on all your comments here and also other feedback receive from other WebKit developers habituated to the WPT thing. This document also summarize a draft  defining a plausible future automate import/export process for the WPT test:
https://hackmd.io/b4ViVtDsSk6Qg8fAycexVA
WDYT?, let's use this doc to polish the ideas.

This WIP PR above tries to cover the points:

https://hackmd.io/b4ViVtDsSk6Qg8fAycexVA#1-Uploading-or-requesting-review-on-a-WebKit-patch-creates-a-draft-export-PR
https://hackmd.io/b4ViVtDsSk6Qg8fAycexVA#2-Getting-review-r-on-the-WebKit-patch-approves-the-export-PR

of https://hackmd.io/b4ViVtDsSk6Qg8fAycexVA.

The user safelist was removed in e49022f#diff-6858ab67caf6ac5fd0757dba33dfdcc84b285a36b92b03d00b9029ca8b0929b5 .

authors: foolip psaavedra rniwa stephenmcgruer youennf

repo: web-platform-tests/wpt-pr-bot


text:
Range active indicator color not showing properly

Current behaviour

The color of active indicator for Range date picker remains light purple, while primary color is set to dark red...
How to reproduce?
const theme = {
  ...DefaultTheme,
  colors: {
    ...DefaultTheme.colors,
    primary: '#1F1717',
  },
};

Preview

Looks like you have to declare the color for primaryContainer...
Apparently it's not calculated automatically based on primary??
Can close now, if this is intended behaviour.

The underlying theming is derived from the parent library https://callstack.github.io/react-native-paper/docs/guides/theming.

source: gharchive/issue

authors: Strengthless iM-GeeKy

repo: web-ridge/react-native-paper-dates

license: MIT

license_type: permissive

license_source: github-api


text:
Poor quality animations code

https://github.com/webaverse/app/pull/3286/files added a lot of poor quality animation code hacks in swimming, such as:

referencing animations by case sensitive file name instead of logical name
inline constant hacks
adding dead variables

This shouldn't have been merged in this state @gonnavis
Additionally, other developers have been copying this code, making surrounding code worse.

I see, sorry, I wanted to ship water related codes quickly that time.
I'll improve it with the help of patriboz.

authors: avaer gonnavis

repo: webaverse/app


text:
Sonic Boom disappears when near to shield in street.scn

Describe the bug
While we are near this shield effect, the sonic boom disappears for a while
To Reproduce
Steps to reproduce the behavior:

Do naruto run wit shift+double w
Go through this shield effect, the sonic boom appears disappearing

Expected behavior
Sonic boom should not be affect by this
Screenshots
https://user-images.githubusercontent.com/35926530/182622916-7144f140-58d5-4095-b14f-5c666d877c28.mp4

Couldn't check the bug on my local.

https://github.com/webaverse/app/issues/2769#issuecomment-1097249349


text:
CJS files are missing from the 5.0.0 release

I'm not able to update to 5.0.0 because the wdio-vscode-service/dist/cjs folder is missing from the 5.0.0 release:
Spec file(s): file:///Users/fabian.jakobs/Workspaces/databricks-vscode/packages/databricks-vscode/src/test/e2e/configure.e2e.ts
Error: Error: Cannot find module '/Users/fabian.jakobs/Workspaces/databricks-vscode/packages/databricks-vscode/node_modules/wdio-vscode-service/dist/cjs/index.js'

Please see #58. v5.0.0 does not support CJS anymore.

authors: christian-bromann fjakobs


text:
Disabling INFO / NOTE logs and JavaScript

I was wondering if there is a way to disable the terminal logging statements that begin with
[07-29:01:09:32] Torbutton INFO: ...
[07-29:01:09:32] Torbutton NOTE: ...

I was also wondering how you can disable JavaScript. Here is what I have tried:
pref_dict = {"noscript.global": False, "extensions.torbutton.security_custom": True}
driver = TorBrowserDriver("/path/to/my/tor-browser_en-US/", tor_cfg=pref_dict)

I was wondering if there is a way to disable the terminal logging statements that begin with

The pref that controls the Torbutton log level is: extensions.torbutton.loglevel
You may want to try different levels to find the one that suits your needs.

I was also wondering how you can disable JavaScript. Here is what I have tried:

You can set the security level to "High" ( "Safest") to disable JavaScript. See the test here:
https://github.com/webfp/tor-browser-selenium/blob/main/tbselenium/test/test_set_security_level.py#L84
Sorry for the delayed response.

The pref that controls the Torbutton log level is: extensions.torbutton.loglevel

Can you get code of this? I don't understand how to change extersions value

Would be something like this:
with TorBrowserDriver(TBB_PATH, pref_dict={'extensions.torbutton.loglevel': LOG_LEVEL}) as driver:
    driver.load_url(...)

authors: Mostalk beencanteen gunesacar

repo: webfp/tor-browser-selenium


text:
Put search UI at top of editor

Also, make max editor size to be 100vh
Hopefully that provides a better UX as it
keeps the search area on the screen.
It's not perfect because until the search UI hits the top of the screen it keeps moving so you have to chase it with your mouse. Putting at the bottom doesn't work because it's off the screen by default.
I spent a few minutes trying to make it hover at the bottom but failed.
Ultimately I'm mixed on the point. The code is on github. We could just have a link to the correct folder on github.

before: Clicking in text area and pressing Ctrl-F/Cmd-F does nothing (because the search is at the bottom of the page). Even going to the bottom of the page, typing in "device" and picking "next" doesn't appear to do anyting.
https://github.com/webgpu/webgpu-samples/assets/234804/dcaaf8a1-c381-45de-9217-fdb72bbf3ba4
after: clicking in text area and pressing Ctrl-F/Cmd-F the search UI appears at the top. The text area is limited to 100vh so once it fill the screen you're scrolling through the editor, not the page. Typing "device" and pressing "next" takes you do each result.
https://github.com/webgpu/webgpu-samples/assets/234804/183152f8-5d88-43a0-93cb-f1a205d7bb4c

source: gharchive/pull-request

repo: webgpu/webgpu-samples


text:
Special indications column

with the switch to 2, it wouldn't be too difficult to add in a special indications tab that adds icons for different special situations.
The following could include an icon in the column and an accompanying note when expanding the weapon.

Yeah, Font Awesome 5 or rpg-awesome could be useful for this!


text:
Add ResNet example

Supports ResNet 101 V2 from TFLite and ResNet 50 V2 from ONNX.
Fixed #7.

@huningxin, PTAL, thanks! I will add the preview once the corresponding test-data PR landed.

test data PR merged @Honry

@huningxin, thanks! Please check the preview https://honry.github.io/webnn-samples/image_classification/.

@huningxin, I've combined the buildLinearBottleneck1_ and buildLinearBottleneck2_ into buildBottleneckV2_, PTAL, thanks!

authors: Honry huningxin

repo: webmachinelearning/webnn-samples


text:
Cannot read property 'createChildCompiler' of undefined

Original Issue at: https://github.com/vuejs/vue-cli/issues/3192 and https://github.com/webpack-contrib/thread-loader/issues/55
Here is a minimum reproducible test repo https://github.com/sohailalam2/mrt-vue-comlinkjs-worker-loader
Vue Cli Version
3.2.1
Environment info
Environment Info:

  System:
    OS: Windows 10
    CPU: (8) x64 Intel(R) Core(TM) i7-8650U CPU @ 1.90GHz
  Binaries:
    Node: Not Found
    Yarn: Not Found
    npm: 6.5.0 - C:\Program Files\nodejs\npm.CMD
  Browsers:
    Edge: 42.17134.1.0
  npmPackages:
    @vue/babel-preset-app:  3.2.0
    @vue/cli-overlay:  3.2.0
    @vue/cli-plugin-babel: ^3.2.0 => 3.2.0
    @vue/cli-plugin-e2e-cypress: ^3.2.0 => 3.2.0
    @vue/cli-plugin-eslint: ^3.2.0 => 3.2.1
    @vue/cli-plugin-pwa: ^3.2.0 => 3.2.0
    @vue/cli-plugin-unit-jest: ^3.2.0 => 3.2.0
    @vue/cli-service: ^3.2.0 => 3.2.0
    @vue/cli-shared-utils:  3.2.0
    @vue/component-compiler-utils:  2.3.1
    @vue/eslint-config-airbnb: ^4.0.0 => 4.0.0
    @vue/preload-webpack-plugin:  1.1.0
    @vue/test-utils: ^1.0.0-beta.20 => 1.0.0-beta.27
    @vue/web-component-wrapper:  1.2.0
    babel-helper-vue-jsx-merge-props:  2.0.3
    babel-plugin-transform-vue-jsx:  4.0.1
    eslint-plugin-vue: ^5.0.0-0 => 5.0.0
    jest-serializer-vue:  2.0.2
    vue: ^2.5.17 => 2.5.21
    vue-eslint-parser:  2.0.3
    vue-hot-reload-api:  2.3.1
    vue-jest:  3.0.2
    vue-loader:  15.4.2
    vue-router: ^3.0.1 => 3.0.2
    vue-style-loader:  4.1.2
    vue-template-compiler: ^2.5.17 => 2.5.21
    vue-template-es2015-compiler:  1.6.0
    vuex: ^3.0.1 => 3.0.1
  npmGlobalPackages:
    @vue/cli: Not Found

Steps to reproduce
Step 1: Create vue.config.js with the following
module.exports = {
  parallel: true,
  chainWebpack: (config) => {
    config.module.rule('worker')
      .test(/\.worker\.js$/i)
      .use('worker-loader')
      .loader('worker-loader');
  },
};

Step 2: npm run serve
What is expected?
Should successfully build the project
What is actually happening?
ERROR  Failed to compile with 1 errors                                                                                4:46:14 PM
error  in ./src/workers/sample.worker.js
Module build failed (from ./node_modules/thread-loader/dist/cjs.js):
Thread Loader (Worker 0)
Cannot read property 'createChildCompiler' of undefined
at Object.pitch (xxxxx\node_modules\worker-loader\dist\index.js:83:39)

@ ./node_modules/cache-loader/dist/cjs.js??ref--12-0!./node_modules/thread-loader/dist/cjs.js!./node_modules/babel-loader/lib!./node_modules/cache-loader/dist/cjs.js??ref--0-0!./node_modules/vue-loader/
lib??vue-loader-options!./src/components/HelloWorld.vue?vue&type=script&lang=js& 45:0-51 71:33-45
@ ./src/components/HelloWorld.vue?vue&type=script&lang=js&
@ ./src/components/HelloWorld.vue
@ ./node_modules/cache-loader/dist/cjs.js??ref--12-0!./node_modules/thread-loader/dist/cjs.js!./node_modules/babel-loader/lib!./node_modules/cache-loader/dist/cjs.js??ref--0-0!./node_modules/vue-loader/
lib??vue-loader-options!./src/views/Home.vue?vue&type=script&lang=js&
@ ./src/views/Home.vue?vue&type=script&lang=js&
@ ./src/views/Home.vue
@ ./src/router.js
@ ./src/main.js
@ multi ./src/main.js
ERROR  Build failed with errors.
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! app@0.1.0 build: vue-cli-service build --modern
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the app@0.1.0 build script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

Turning off parallel flag in vue.config.js successfully builds the project
module.exports = {
  parallel: false,
  chainWebpack: (config) => {
    config.module.rule('worker')
      .test(/\.worker\.js$/i)
      .use('worker-loader')
      .loader('worker-loader');
  },
};

Please don't spam issue in may repo, also you reproducible test repo is not look minimum.
Simple example = fast fix.

Apologies... don't mean to spam... I just don't know what's the root cause of this - Vue Cli or Worker Loader or Thread Loader?
About the reproducible test, it's quite straightforward because I have used Vue Cli to generate the code and made only some small changes. If you want more explanation, I can document the details but I don't know how else to reproduce this issue.

Any status change in regards to this issue? Also experiencing this problem.

PR welcome

Same issue, not sure what is the cause, if I nuke the node_modules directory and reinstall it does work, but eventually breaks again and I have to reinstall.

perhaps is related with webpack-contrib/thread-loader#27

I'm also running into the issue described above. I created a slightly smaller reproduction, maybe this can help in isolating the issue @evilebottnawi? :)
To summarize, the build-task fails with the error-message above. Removing the node_modules folder does not fix the issue for me.

The same error that appeared after using worker-loader appears only with npm run build. That is, for npm run serve everything works as usual, using vue-cli.

Also run into this problem, parallel: false helps, but I want to know if there is an elegent solution

@CrashyBang's fix worked for me (having to delete node_modules and re-running npm install).
This allowed the npm run build to finish (like others in this thread have stated, npm run serve works fine)

it seems  that you should add "options"
e.g.
config.module
      .rule('worker')
      .test(/\.worker\.js$/)
      .use('worker-loader')
      .loader('worker-loader')
      .options({ name: '[name].[hash].js' })
      .end()

I'm facing the same issue described above, only deleting node_modules and installing everything again solves the problem temporarily (until changes in the worker). Has anyone found out a solution?

Problem in thread-loader side, we will fix it in the near future, sorry for delay, as workaround you can disable thread-loader for worker files using exclude: /\.worker\.js$/

@evilebottnawi Until this is actually fixed, is there an open issue tracking this bug? The thread-loader issue was closed in favor of this one?
Thanks for the update and workaround.

authors: CrashyBang GenericDeveloper14 Myqilixiang PowerfulPony Yanfei-Qiao a-froghyar brianhelba evilebottnawi raczosala sohailalam2 sysebert wanecek

repo: webpack-contrib/worker-loader


text:
file-loader seems to corrupt font files (.woff .woff2 .eot .ttf)

I'm extracting font files from CSS into my dist/ folder with the file-loader. That works nicely. However the file-loader seems to corrupt the font files. No browser can display them anymore.
When I copy the original font files manually into my dist/ folder, everything works.
These are the warnings I'm getting from the latest version of Chrome:
kitchen-sink.html:1 Failed to decode downloaded font: http://localhost:8888/dist/fonts/MaterialIcons-Regular-5be9da5f5fe772cae17b56df1cf150a7.woff2
kitchen-sink.html:1 OTS parsing error: Failed to convert WOFF 2.0 font to SFNT

kitchen-sink.html:1 Failed to decode downloaded font: http://localhost:8888/dist/fonts/MaterialIcons-Regular-cd63a3a9169fbd408105e71820482aa1.woff
kitchen-sink.html:1 OTS parsing error: incorrect file size in WOFF header

kitchen-sink.html:1 Failed to decode downloaded font: http://localhost:8888/dist/fonts/MaterialIcons-Regular-9679b709fae34447e6ba1362138a63f1.ttf
kitchen-sink.html:1 OTS parsing error: incorrect entrySelector for table directory

kitchen-sink.html:1 Failed to decode downloaded font: http://localhost:8888/dist/fonts/socicon-fb368d36440f2c7fe9a87558cb3e0c58.woff2
kitchen-sink.html:1 OTS parsing error: Size of decompressed WOFF 2.0 is set to 0

kitchen-sink.html:1 Failed to decode downloaded font: http://localhost:8888/dist/fonts/socicon-c1a3e19822251c78c74275e8820687a7.woff
kitchen-sink.html:1 OTS parsing error: incorrect file size in WOFF header

kitchen-sink.html:1 Failed to decode downloaded font: http://localhost:8888/fonts/socicon-a59005d8108d177950adabbfd9ff2ff7.ttf
kitchen-sink.html:1 OTS parsing error: FFTM: invalid table offset

I also tried setting ?mimetype=application/font-woff (etc) and using the url-loader to inline the fonts in the CSS all with the same result as above.
I hope you can help me, this is my first project with Webpack, I really like it so far! Great work!

Could you post your webpack configuration, please?

Sure, here you go:
    {
        entry: './build.js',
        output: {
            path: "./dist",
            filename: "bundle.js"
        },
        module: {
            loaders: [
                {
                    test: /\.css$/i,
                    loader: ExtractCSS.extract("css-loader!autoprefixer-loader")
                },
                {
                    test: /\.less$/i,
                    loader: ExtractCSS.extract("css-loader!autoprefixer-loader!less-loader")
                },
                {
                    test: /\.scss$/i,
                    loader: ExtractCSS.extract("css-loader!autoprefixer-loader!sass-loader")
                },
                {
                    test: /\.(woff|woff2|eot|ttf)$/i,
                    loader: "file-loader?name=fonts/[name]-[hash].[ext]"
                },
                {
                    test: /\.(jpe?g|png|gif|svg)$/i,
                    loader: "file-loader?name=images/[name]-[hash].[ext]"
                }
            ],
        },
        plugins: [
           ExtractCSS,
        ]
    }

Okay, never mind - I'm sorry.
After restarting my computer a couple of times since last time I worked on it, this exact same setup works today.. computers sigh

FWIW I had to debug the same problem and I posted my findings on StackOverflow: http://stackoverflow.com/questions/34133808/webpack-ots-parsing-error-loading-fonts/34133809#34133809

authors: greenish kaikuchn wmadden

repo: webpack/file-loader


text:
Ignore Plugin on Files

I'm having an angular app which is quiet big, so I'm lazily loading chunks and just want to ignore few chunks. So, using IgnorePlugin but unable to match the specific folder/directory. Currently my folder structure is src/app/modules/platform, so I want to ignore platform folder in ng-build but unable to achieve it. I', lazily loading that module so the lazy loading code is in src/app/modules/app-routing.module.ts Any help will be appreciated. Thanks in advance.

I encourage you to ask your question on StackOverflow instead. We try to use the issue tracker for bug reports and feature requests, as well as some discussions, but this appears to be a very localized question.
I’m closing for these reasons.


text:
Documentation: Get Started with Webpack

The new docs are really awesome!
In the getting started-mentioned index.html file with the bundle.js couldn't get it to work as it is. When I move the script tag inside the body tag everything works fine.

Would you be interested in doing a PR?

If you could be kind enough to tell me how :)
On Thu, Nov 24, 2016 at 8:02 PM, Kees Kluskens notifications@github.com
wrote:

Would you be interested in doing a PR?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/webpack/webpack.js.org/issues/427#issuecomment-262826465,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AD1eZsCZ6R_s__wFu_MQ6VUALhFj0YcLks5rBdFJgaJpZM4K732_
.

Of course, you can find it here: https://github.com/webpack/webpack.js.org/blob/develop/content/get-started/index.md. If you click on the 'edit' button on the top-right, you can make edits. After saving the file, the GitHub UI will help you to make a PR.

Thank you very much for your time!

Thank you too!
Fixed by #428


text:
Progress is logged to STDErr which is causing lots of inconvenience

This is a new issue referring to an older closed one - that one was closed for missing the template and since then has never been opened so probably lost from the issue radar: https://github.com/webpack/webpack/issues/3520

Bug report

What is the current behavior?
Progress is considered unconventional output so it's logged to stdErr - which is inconvenient to say the least when the progress has to be parsed by other programs, for example dotNet core
If the current behavior is a bug, please provide the steps to reproduce.
Steps are simple -> get any project which contains Webpack and use it to build with --progress enabled
and directing the output of StdOut and StdErr to a separate file each. You will notice the progress ending up in the StdErr file while you would expect it in the StdOut file...

What is the expected behavior?
The progress being logged into the StdOut file or at least through the StdOut pipe...

Other relevant information:
webpack version:  N/A
Node.js version: N/A
Operating System: N/a
Additional tools:
See: https://github.com/webpack/webpack/issues/3520

You can configure that: https://webpack.js.org/configuration/other-options/#stream

Answered

authors: ThaDaVos alexander-akait sokra

repo: webpack/webpack


text:
Is there a bug using $router Provider from AngularJS Component Router?

I am trying to get my Angular/Webpack/ocLazyLoad app to work. My app code looks like this:
     var app = angular.module('app', ['oc.lazyLoad', 'ngComponentRouter']);
     app.config(function ($locationProvider) {
      $locationProvider.html5Mode(true);
       });

           app.value('$routerRootComponent', 'app');

             app.component('app', {
              template: [
             'Home |',
                'Heroes |',
             'Crisis Center',
               '
',
              '<ng-outlet></ng-outlet>',

             ].join('\n'),

              controller: ['$router', '$ocLazyLoad', function($router, $ocLazyLoad) {

              $router.config([
               {path: '/', name: 'Home', component: 'home', usaAsDefault: true},

                //Heroes Route
    {
        path: '/heroes/...',
        name: 'Heroes',
        loader: function () {
            // lazy load Heroes
            /*return $ocLazyLoad.load([require('heroes.module')])
                .then(function () {
                    return 'heroes';
                });*/
        }
    },

    //Crisis Center Route
    {
        path: '/crisis-center/...',
        name: 'CrisisCenter',
        loader: function () {
            // lazy load CrisisCenter
            /*return $ocLazyLoad.load([require('')])
                .then(function () {
                    return 'crisisCenter';
                });*/
        }

    }

       ]);
     }]

    });

I injected all dependencies etc, it debugs also to the $router, but I get an unkown provider error.
When I delete all Webpack related code, it works.
If I change the version of webpack, I get a changed Errormessage: Component "Root" has no route config.
Since it works without webpack, I have a suspicion it could have to do with webpack?

Please ask on StackOverflow.

authors: liasrose sokra


text:
Please make long term caching better supported out of the box

Do you want to request a feature or report a bug? Feature

What is the current behavior? Currently, predictable long term caching of output chunks is difficult to achieve. After reading this article, I was surprised to learn two things:

I have been doing predictable long-term caching wrong for a long time.
Every project is different, and the CommonsChunkPlugin integration for every project will be different. However, there are a number of concepts required for consistent long term caching which are not used by default, including the plugins NamedChunksPlugin & NamedModulesPlugin, and ensuring that all chunks have a module identifier.

The documentation for caching includes minimal explanation for using module identifiers instead of facilities for supporting long term caching:

To minimize the size of generated files, webpack uses identifiers instead of module names.

However, for production projects, this means that more work needs to be done to ensure that long term caching is possible since the defaults do not support it, and the rapid state of change in the webpack codebase (and supporting documentation) can easily be missed by devs on webpack projects.
What is the expected behavior? It would be nice to have sensible defaults that make long term caching easier, such as including NamedChunksPlugin and NamedModulesPlugin by default, and ensuring that all modules have an identifier. Additionally, in the future it would be nice to include config options that more simply expose some (pardon the pun) common use cases of CommonsChunkPluginbehaviors, like breaking out chunks into their own files, creating a runtime chunk, and including async children chunks in a parent chunk.
If this is a feature request, what is motivation or use case for changing the behavior? As a webpack user for over a year now, I still feel that the framework is very powerful—but that there are a number of default configurations that should be simpler to achieve. It is not clear that there is a worthy performance reason to not support long term caching by default, when it is not immediately clear that webpack requires additional configuration for long term caching in the first place.

I second this. Getting long-term caching working involves a lot of trial-and-error, as evidenced by this issue. It also requires you to know too much about the internals of webpack in order to get it to work. Why should I have to know how webpack identifies modules internally? I think HashedModuleIdsPlugin should be used by default. Then the only thing you'd need to do to get caching working is to add extract the runtime and use chunkhash in your output filename. E.g.
This:
output: {
  filename: '[name].[chunkhash].js'
},
plugins: [
  new webpack.optimize.CommonsChunkPlugin({
    names: ['vendor', 'manifest'],
    minChunks: Infinity
  }),
]

instead of this:
output: {
  filename: '[name].[chunkhash].js'
},
plugins: [
  new webpack.optimize.CommonsChunkPlugin({
    names: ['vendor', 'manifest'],
    minChunks: Infinity
  }),
  new webpack.NamedModulesPlugin(),
  new webpack.NamedChunksPlugin(),
]

All the various and extremely confusing combinations of multiple caching plugins should really be deprecated in favour of default behaviour at https://medium.com/webpack/predictable-long-term-caching-with-webpack-d3eee1d3fa31
Moreover, this page should feature prominently in each and every page that discusses caching until caching is solved.

I got most of my example config from the official docs on caching. Not sure what's "extremely confusing" about it. Although, I do agree the one from the medium article is more robust.

@danny-andrews-snap
Thta page is just a "running start". If you need an actual caching solution, you have to follow the several-screens-long explanation in the medium post. However, caching as described in the post,  should work out of the box, and not require umpteen plugins with arcane configurations to get what you need in the first place.
On top of that, that entire documentation page is already outdated because CommonChunksPlugin is removed in webpack v4.
Thankfully, persistent caching is in the roadmap for v5.

Cool, I think it makes sense to point people to that article in the meantime.

webpack 5 has added a lot improvements for long term caching.
It now produces output files in a deterministic way, so that changes to on part of the application are very unlikely to affect another part of the application. Module and Chunk Ids use determinstic numeric ids (which is a good tradeoff between size, caching and not exposing internals). Exports are mangled in a determinstic way using 1-3 letter hashes depending on the number of exports. node_modules (once they reach a size threshold) are automatically split from application modules to respect the different change behavior.
All this should yield good caching behavior for caching via re-validation by default.
I can recommend to add the following options for even better long term caching:
output: {
  filename: "[contenthash].js",
},
optimization: {
  splitChunks: {
    chunks: "all"
  }
}

Currently we did not enable these options by default because they make it harder to use the output files generated by webpack. output.filename make the filename unguessable and splitChunks.chunks will generate multiple files that need to be included via script tag. To use output files with these settings you need to have some kind of process that will generate the HTML and script tags for you. To improve developer experience, especially for newcomers, this is not needed by default.
In future we might offer the ability to use an HTML file as entrypoint, which would allow to enable such optimizations by default.

authors: danny-andrews danny-andrews-snap dmitriid fruchtose sokra


text:
process.binding problem in the browser using ng test

Here is a screenshot of the problem:

My library (suman) creates its own polyfill for process, so that process.binding becomes a noop.
But the standard process polyfill throws an error when process.binding is called.
Does anyone know how to handle this problem? I really don't understand why the authors of the process polyfill for the browser decided to throw errors instead of making these methods on process no-ops.

It looks like you just deleted/ignored our lovely crafted issue template. It was there for good reasons. Please help us solving your issue by answering the questions asked in this template. I'm closing this. Please open a new issue with filled issue template. Also make sure your issue is not a question. Questions should be posted on Stack Overflow.

authors: ORESoftware sokra


text:
[WIP] Make CommonsChunkPlugin care about indirect children, too

What kind of change does this PR introduce?
Feature
Did you add tests for your changes?
Not yet, wasn't able to find where tests for the CommonsChunkPlugin would have to go or where are some already.
If relevant, link to documentation update:
Will update Docs as soon as I'm confident this change will make it in and works as intended.
Summary
If you use the CommonsChunkPlugin with the children flag enabled it currently only cares about direct children. This change makes it so it cares about all children that are not required from somewhere else than the common chunk.
https://github.com/webpack/webpack/issues/3981
Does this PR introduce a breaking change?
If the config deepChildren isn't set the behavior stays the same as before, it only changes if the flag gets set.
Other information
Please be gentle, as this is my first try to get a PR merged.

Changed the little things as requested. Also fixed two bugs I found in the way I searched for the children.
The idea behind how I walk through the children of the common chunk is to check for each chunk if all parents are either the common chunk itself or another chunk I already know i use. As this checking begins with the children of the common chunk and I push the chunks I use before checking its children I can always be sure that I don't add any chunks I shouldn't.
At least that's what I think. I hope I didn't miss something really obvious.
I also added a testcase where you suggested it. I have to admit I'm not entirely sure my test really tests the right thing, tough. Had a bit of trouble wrapping my head around how to test my case from the source itself.

@timse Could you help resolving this conflict?

will do! (tonight :))

@timse, @sokra, what is the status of this PR? Getting this merged would make me happy.

Sorry lost track of it. Will check tonight!

hum im kind of overwhelmed given the changes to the current module and the changeset :p

I had the same problem. Maybe it is simpler if I make the changes again based on the new module after you PR. Then we wouldn't need to try to resolve the conflicts.
I can look into the new version in a few hours if you want.

i pushed a branch can you check please @ArcEglos
and close this one if its ok and reopen the pr with the new branch?
see here: https://github.com/webpack/webpack/pull/4416

@timse great, thanks. I'll look into it later in the day

Sorry for the confusion I'm creating but I didn't know how to properly use the branch you created, so I copied over the new Version from it and added the missing pieces. @timse

no worries

it looks however as you still have conflicts against master here

Ah yeah, thanks for reminding. Resolved them.

the tests fail and there is a console.log left,
you could just take the diff of https://github.com/webpack/webpack/pull/4416/files and it should work.

Ah sorry, I have to admit I only checked the example. My bad. I'll look into it.
Yep, the changes in #4416 didn't take into account chunks that have several parents but still only depend on the commonsChunk if you expand the whole dependency tree.
The approach I chose goes down from the common chunk and for each children recursively looks, if all parents of the children are either the common chunk or are in the list of chunks known to only have the common chunk as (grand, etc) parents. These children are added to said list before walking further down. When finished walking the dependency tree we take this list and know that all these chunks only have the commonChunk as parent.

got it,
can we document that somehow? and could we split up the code a bit?
something like this:
// filter to only those chunks whose parents all are affected
filterChildenWithAllAffectedParents(affectedChunks, childChunks) {
  return childChunks.filter(() => {
    return chunk.parents.length === 1 ||
      chunk.parents.every((parentChunk) => affectedChunks.indexOf(parentChunk) > -1);
  });
}

// remove duplicates of "existing"
filterAlreadyExistingChunks(existing, potential) {
  return potential.filter(p => existing.indexOf(p) === -1);
}

// get all child chunks that are affected - meaning they could be moved to the commons chunk
getAffectedUnnamedChunksFlat(affectedChunks, childChunks) {
  if (!childChunks) {
    return [];
  }

  if(this.async) {
    return childChunks;
  }

  return filterChildenWithAllAffectedParents(affectedChunks, childChunks)
}

// get all chunks that can be put into the commons chunk
getAffectedUnnamedChunks(affectedChunks, childChunks) {
  const affectedChildChunks = this.filterAlreadyExistingChunks(
    affectedChunks,
    this.getAffectedUnnamedChunksFlat(affectedChunks, childChunks)
  );
  if(!this.deepChildren) {
    return affectedChildChunks;
  }
  return childChunks.reduce((allAffectedChunks, childChunk) => {
    return this.filterAlreadyExistingChunks(
      allAffectedChunks,
      this.getAffectedUnnamedChunksFlat(allAffectedChunks, childChunk.chunks)
    );
  }, affectedChunks);
}

that way we have clear functions and its a bit easier to understand what is happening

The last part could probably be made nicer.
Also could this lead to endless loops? What if some chunks are each others parents/childrens

I haven't had the time yet to refactor the code and comment it better. Hope to find time tonight, but won't make any promises. Just answering some of your questions in advance:
About the endless loops: These shouldn't be a problem, as we a) stop walking the dependencies at chunks that have parents we don't like and b) stop walking if we find a chunk has already been added to the chunks we are sure to only have parents we like.
So no chunk should be visited via the same connection more than once.
Maintaining these two conditions are also the main hurdle to seperate the whole thing into two steps because both the hierarchy while walking the dependencies and the timing of it are relevant to avoid endless loops and wrong assertions if a chunk is ok to add. But there is probably still a way to break it up.

I hope this removes the problems with the tests (at least they run at my machine).
I also added more documentation what happens why.
When it comes to first flattening the tree before filtering it, I'm not really convinced this is a good idea. (At least to me) It makes the subtle ordering and hierarchical problems even less clear when reading the code. But maybe I'm the only one with this opinion @timse - maybe the annotated version also clarifies what's going on. It's up to you to judge ;)

Hey, 1 test failed. This is a cool feature that I would like to see
 1 failing

  1) ConfigTestCases commons-chunk-plugin move-to-grandparent should compile:
     Uncaught SyntaxError: Unexpected token [
      at Object.exports.runInThisContext (vm.js:53:16)
      at _require (/home/travis/build/webpack/webpack/test/ConfigTestCases.test.js:95:18)
      at /home/travis/build/webpack/webpack/test/ConfigTestCases.test.js:124:9
      at /home/travis/build/webpack/webpack/lib/Compiler.js:9:17985
      at Compiler.emitRecords (/home/travis/build/webpack/webpack/lib/Compiler.js:9:24097)
      at /home/travis/build/webpack/webpack/lib/Compiler.js:9:17387
      at /home/travis/build/webpack/webpack/lib/Compiler.js:9:23782
      at next (/home/travis/build/webpack/webpack/node_modules/tapable/lib/Tapable.js:154:11)
      at Compiler.<anonymous> (/home/travis/build/webpack/webpack/lib/performance/SizeLimitsPlugin.js:9:4844)
      at Compiler.applyPluginsAsyncSeries1 (/home/travis/build/webpack/webpack/node_modules/tapable/lib/Tapable.js:158:13)
      at Compiler.afterEmit (/home/travis/build/webpack/webpack/lib/Compiler.js:9:23432)
      at Compiler.<anonymous> (/home/travis/build/webpack/webpack/lib/Compiler.js:9:23301)
      at /home/travis/build/webpack/webpack/node_modules/async/dist/async.js:359:16
      at iteratorCallback (/home/travis/build/webpack/webpack/node_modules/async/dist/async.js:935:13)
      at /home/travis/build/webpack/webpack/node_modules/async/dist/async.js:843:16
      at /home/travis/build/webpack/webpack/node_modules/graceful-fs/graceful-fs.js:43:10
      at FSReqWrap.oncomplete (fs.js:82:15)

@markrileybot did you end up working on this? If not, I'd like to help finishing it as well.

wait to be merged

Need this

Any progress with this PR? @markrileybot @maroshluskasc

I am amazed that commonChunksPlugin hasn't always worked this way, always assumed I was doing something wrong causing code duplication across  lazy loaded modules. Just to be clear, should I wait for this feature instead of attempting to optimize my bundles through other means? I was considering following the webpack docs and using dynamic imports for libraries that are being duplicated, but if this feature will figure the same splitting functionality with normal imports then I'd rather wait. Can anyone verify if this PR does that?

Would love to see this merged 👍

Pretty please

just chiming in here but happy to help in any way to get this cleaned up / merged (or to pick it up into a new pr if need be).

Would be great to have this one put in! 👍 All the way.

I have fixed all issues with this pull request and submitted another pull request:
https://github.com/webpack/webpack/pull/5764

This can be closed now that #5764 is merged & 3.7.0 is out! 🎉

@sokra BTW you can close this PR

authors: ArcEglos PTC-JoshuaMatthews STRML Tom910 abdavid brad-sobie daggerjames drphelps grydstedt ljcrapo maroshluskasc modosc sokra stevewillard timse wbern


text:
ARMv6 Support

Hi, Unable to find this anywhere but is ARMv6 supported? I am mainly looking for rendering my UI on a browser running in kiosk mode with HTML5 & WebRTC support, running on Raspberry Pi Zero (non-w). Any luck?

Since GTK works on ARM, I don't see why not. Though resource usage may be an issue for your use case.

@justjosias It works great on linux x86 but when I tried compiling my go program, looking at the size of the executable I realised it's not a self-contained binary and probably dynamically linking to the required dependencies. I am unsure of what dependencies are there & how I can provide that to the program (paths?) in the running environment ARMv6.
Can you give me some pointers?

@ashfame GTK should be the main/only dependency. If you can install that, it should work.
This is where webview needs better documentation.

@justjosias I just did that and upon starting the program it neither shows the UI nor throw any errors :-/

authors: ashfame justjosias

repo: webview/webview


text:
🛑 Jeff with Susan is down

In a16a054, Jeff with Susan (https://www.jeffwithsusan.com) was down:

HTTP code: 521
Response time: 145 ms

Resolved: Jeff with Susan is back up in 11c7958 after 420 days, 7 hours, 37 minutes.

repo: webworldview/uptime


text:
🛑 DragonBoat Times is down

In 57b0fa0, DragonBoat Times (https://www.dragonboattimes.com) was down:

HTTP code: 521
Response time: 148 ms

Resolved: DragonBoat Times is back up in c1c1d3e after 32 minutes.


text:
🛑 Member Genesis is down

In cc56b10, Member Genesis (https://www.membergenesis.com) was down:

HTTP code: 403
Response time: 829 ms

Resolved: Member Genesis is back up in 26adac8.


text:
🛑 The Good Cyclist is down

In a62e468, The Good Cyclist (https://thegoodcyclist.iwview.com) was down:

HTTP code: 0
Response time: 0 ms

Resolved: The Good Cyclist is back up in 95f338a.


text:
🛑 Web World View is down

In e90597b, Web World View (https://www.webworldview.com) was down:

HTTP code: 500
Response time: 4046 ms

Resolved: Web World View is back up in 96cc8fd after 8 minutes.


text:
ERR PuppetWeChatBridge start() exception: TimeoutError: Navigation timeout of 30000 ms

🚨 The issue tracker is not for questions 🚨

[question]

我有同样的问题。
node.js: v14.17.0
os:CentOS 7.9.2009

same issue

same issue

我今天也遇到了同样的问题

repo: wechaty/getting-started


text:
Need new message type for Group Note message.

Example
接龙
1. xxx

We could make it as Group Note in WeChat App, and it is a new type for wechaty.

Glad to add the Group Note type, you are welcome to send a PR to do that.
BTW Do we have any good name for the 接龙？

In English version of WeChat App, 接龙 named GroupNote.

Great, the English version of the name in WeChat can be our first choice.
Thanks for the enhancement!

You are welcome, happy with the new type.

authors: huan su-chang

repo: wechaty/wechaty-puppet


text:
When training from scratch on ian3 scene does not converge

GOOD JOB! I tried training the model from scratch, but the results I got were strange. Is there something wrong?
This is training script:
GPU=0 CUDA_VISIBLE_DEVICES=$GPU python training/exp_runner.py --conf ./confs/pretrain_flow.conf --gpu 0 --nepoch 2000 --is_pretrain_flow
This train result:

The result is expected since the pretraining is not training on ian3 but on a dummy ball that grows from 0.5m to 1.0m, see here. Then the next step after pretraining would use those pretrained network weights (defined here) to train on a real scene.
For me, revising the run.sh as below worked well in getting reasonable results on the hanggling_ b2 scene, I've also added a few comments based on my understanding:
# 1. Pre-training of the SDF Flow: Train on a dummy sphere that grows from radius 0.5 to 1.0 over the time horizon.
python -m training.exp_runner --conf confs/pretrain_flow.conf --gpu 0 --nepoch 2000 --is_pretrain_flow

# 2. Train the SDF Flow on a scane in the Total Capture dataset (the scene id is defined in the config)
python -m training.exp_runner --conf confs/total_capture.conf --gpus 2 --nepoch 2000 --is_dist --cancel_vis

# 3. Evaluate the trained SDF Flow

# 3.1. Create .ply files for the predicted geometry.
#         My results were saved to exps/total_capture_hanggling_b2/2024_04_24_10_31_25/runconf.conf
#         And I had stopped the training in step 2 after 300 epochs (as it was quite slow)
#         So I evaluate the checkpoint for epoch 300
#         But the results already look reasonable (qualitatively and quantitatively)
python -m training.exp_runner --conf exps/total_capture_hanggling_b2/2024_04_24_10_31_25/runconf.conf  --gpu 0 --cancel_vis --is_only_plot --is_continue --checkpoint 300

# 3.2. Evaluate the predicted geometry
python -m evaluation.eval_flow_geo --conf exps/total_capture_hanggling_b2/2024_04_24_10_31_25/runconf.conf --checkpoint 300 --timestamp 2024_04_24_10_31_25

# After 300 epochs:
# Mean Accuracy: 9.314097464084625
# Mean Completeness: 22.686426527798176

The result is expected since the pretraining is not training on ian3 but on a dummy ball that grows from 0.5m to 1.0m, see here. Then the next step after pretraining would use those pretrained network weights (defined here) to train on a real scene.
For me, revising the run.sh as below worked well in getting reasonable results on the hanggling_ b2 scene, I've also added a few comments based on my understanding:
# 1. Pre-training of the SDF Flow: Train on a dummy sphere that grows from radius 0.5 to 1.0 over the time horizon.
python -m training.exp_runner --conf confs/pretrain_flow.conf --gpu 0 --nepoch 2000 --is_pretrain_flow

# 2. Train the SDF Flow on a scane in the Total Capture dataset (the scene id is defined in the config)
python -m training.exp_runner --conf confs/total_capture.conf --gpus 2 --nepoch 2000 --is_dist --cancel_vis

# 3. Evaluate the trained SDF Flow

# 3.1. Create .ply files for the predicted geometry.
#         My results were saved to exps/total_capture_hanggling_b2/2024_04_24_10_31_25/runconf.conf
#         And I had stopped the training in step 2 after 300 epochs (as it was quite slow)
#         So I evaluate the checkpoint for epoch 300
#         But the results already look reasonable (qualitatively and quantitatively)
python -m training.exp_runner --conf exps/total_capture_hanggling_b2/2024_04_24_10_31_25/runconf.conf  --gpu 0 --cancel_vis --is_only_plot --is_continue --checkpoint 300

# 3.2. Evaluate the predicted geometry
python -m evaluation.eval_flow_geo --conf exps/total_capture_hanggling_b2/2024_04_24_10_31_25/runconf.conf --checkpoint 300 --timestamp 2024_04_24_10_31_25

# After 300 epochs:
# Mean Accuracy: 9.314097464084625
# Mean Completeness: 22.686426527798176

Thank you for your answer, I get it!


text:
Target .NET 8

.NET 8 has been released and System.Json.Text has changed its targeting frameworks. Though the current targeting framework net6.0 and netstandard2.x would still work, it would be good to exam over any breaking changes and change the targeting framework accordingly.
We need to:

[x] Go over breaking changes in the System.Text.Json package of .NET 7
[x] Change targeting framework accordingly
[x] Target test projects to .NET 8
[x] Target benchmark project to .NET 8
[x] Update Github Actions to build and test in .NET 8
[x] Remove .NET 5 from all projects

Completed in #43

repo: weichch/system-text-json-jsondiffpatch


text:
Error when building with "make" on Ubuntu 18.04

Hello all,
I need a bit of help with building the repository. My specifications are as follows:
Ubuntu 18.04
libtorch v.1.0.0
OpenCV 3.2
I cloned the repo, created a build folder and used cmake .. , which went well.
When I use make, it gives me the following error:
cmake ..
-- Configuring done
-- Generating done
-- Build files have been written to: /home/andik/Schreibtisch/ML/libtorch-yolov3-deepsort/build
andik@andik-VirtualBox:~/Schreibtisch/ML/libtorch-yolov3-deepsort/build$ make ..andik@andik-VirtualBox:~/Schreibtisch/ML/libtorch-yolov3-deepsort/build$ make
Scanning dependencies of target detection
[  5%] Building CXX object detection/CMakeFiles/detection.dir/src/Darknet.cpp.o
/home/andik/Schreibtisch/ML/libtorch-yolov3-deepsort/detection/src/Darknet.cpp:63:53: error: ‘torch::IntArrayRef’ has not been declared
torch::Tensor forward(torch::Tensor prediction, torch::IntArrayRef inp_dim) {
^~~~~
/home/andik/Schreibtisch/ML/libtorch-yolov3-deepsort/detection/src/Darknet.cpp: In member function ‘at::Tensor DetectionLayerImpl::forward(at::Tensor, int)’:
/home/andik/Schreibtisch/ML/libtorch-yolov3-deepsort/detection/src/Darknet.cpp:72:38: error: invalid types ‘int[int]’ for array subscript
int64_t stride[] = {inp_dim[0] / grid_size[0], inp_dim[1] / grid_size[1]};
^
/home/andik/Schreibtisch/ML/libtorch-yolov3-deepsort/detection/src/Darknet.cpp:72:65: error: invalid types ‘int[int]’ for array subscript
int64_t stride[] = {inp_dim[0] / grid_size[0], inp_dim[1] / grid_size[1]};
^
detection/CMakeFiles/detection.dir/build.make:62: recipe for target 'detection/CMakeFiles/detection.dir/src/Darknet.cpp.o' failed
make[2]: *** [detection/CMakeFiles/detection.dir/src/Darknet.cpp.o] Error 1
CMakeFiles/Makefile2:85: recipe for target 'detection/CMakeFiles/detection.dir/all' failed
make[1]: *** [detection/CMakeFiles/detection.dir/all] Error 2
Makefile:83: recipe for target 'all' failed
make: *** [all] Error 2
Has anyone experienced the same error?
Best regards
Andi

When I use "make -j12", the complete error log is different, I attached it in the txt file.
make_error_report.txt


text:
workflow-stage-upload/film/bnumber folder disappears

workflow-stage-upload/film/bnumber folder disappears when a file is copied to it, forcing us to create the bnumber folder two or three times for an ingest.
It'd be helpful if the bnumber folder could be created and then remain so all three separate files could be copied to it without having to create it over and over
Closing #332 for this issue

Related, the Goobi workflow moves forward before we can get all the files in. Usually the PDF doesn't make it and we have to roll it back. Is there an order to get the files in before Goobi moves forward?

To help the issue above, maybe we could change the film ingest to be like the audio, in which we can load the files from S3 and then pick up the task, check what's in there and release? We're having a hard time keep track of what we put in for films.
How much work is that? We'd like to try it on staging at least.

We will change the film ingest to be like the audio and delete the prefix/folder only after the manual step is closed. This will take approx 2 days.

Yeah, let's go for it! Harkiran and I have discovered while testing this week that it's way to easy to get distracted and remember what you put in haha

authors: aray-wellcome opaetzel

repo: wellcomecollection/goobi-infrastructure


text:
Add namespaces option

Description
Allow users to define namespaces for faasd using the services.faasd.namespaces option.
Namespaces are automatically created and labeled with openfaas=true

Nicely done 👍

authors: alexellis welteki

repo: welteki/faasd-nix


text:
update to caddy 2.0.0

With caddy being in version 2.0.0 and caddy-gen still sporting version 0.10.12 wouldn't it be a good idea to upgrade to the nwest version?
I tried setting the caddy version in the dockerfile myself, but it wont run. I suppose there is some new stuff about the api in the Caddyfile.
But maybe there is no real reasson for an update?

I am not yet familiar with caddy@2
I will dig into it soon! Thanks!

I've created similar project, but based on Caddy2: https://github.com/Siemko/caddy2-gen. Feel free to check the differences.

@Siemko I can add you as a maintainer for this package and merge your changes. Do you want this to happen? 🙂

Yes, sounds interesting :)

I've created similar project, but based on Caddy2: https://github.com/Siemko/caddy2-gen. Feel free to check the differences.

Ah, so sweet, thank you alot :) Gonna test it out asap!

@Siemko awesome! Thanks! PR is more than welcome!

authors: AlphaMoonbaseBerlin Siemko sobolevn

repo: wemake-services/caddy-gen


text:
Conflict with onClick event from view inside card content

The view inside card content somehow consumes the touch event, and the cadStack doesn't listen to the drag gestures, is there a workaround or something we can do, so views inside the card content respond to onClick and drag gestures from CardStack also gets triggered.
I have a video of the undesired behavior below:
https://www.youtube.com/watch?v=jOyM0T69KCA

This is not library specific issue, it is general question of how do you
handle the events. Google it
http://stackoverflow.com/questions/6374592/passing-touch-events-to-the-parent-view
On 25 Jun 2016 1:26 a.m., "Juan Pablo Prado" notifications@github.com
wrote:

The view inside card content somehow consumes the touch event, and the
cadStack doesn't listen to the drag gestures, is there a workaround or
something we can do, so views inside the card content respond to onClick
and drag gestures from CardStack also gets triggered.
I have a video of the undesired behavior below:
https://www.youtube.com/watch?v=jOyM0T69KCA
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/wenchaojiang/AndroidSwipeableCardStack/issues/56, or mute
the thread
https://github.com/notifications/unsubscribe/AAv25BlVUu0ncNKKF3K9hIc1WIanfclOks5qPHXRgaJpZM4I-OKr
.

authors: juanpabloprado wenchaojiang

repo: wenchaojiang/AndroidSwipeableCardStack

license: mit

license_source: bigquery


text:
export ONNX format issue for CPU

ENV: onnx = 1.10.0, torch=1.11.0
when i export onnx format of encoder by setting chunk_size -1, the output node is as follows:
output [Addoutput_dim_0, T, 256]
r_att_cache [12,4,T_CACHE,128]
r_cnn_cache [12,1,256,Concatr_cnn_cache_dim_3]
the dimension name "Addoutput_dim_0" and "Concatr_cnn_cache_dim_3" should be fixed to 1 and 7?
another is decoder onnx, the output is as follows:
score [LogSoftmaxscore_dim_0,L,4233]
r_score
there is any mistake for these two output node's dimension.

@xingchensong @lzhin please follow the issue.

I cannot reproduce this issue, please provide more info. Are u using u2pp_conformer or just standard conformer?  whats your num_left_chunks? please show us all of your hyperparameters.

@xingchensong  Yes, i use u2++_conformer model, and my export script is as below:
python wenet/bin/export_onnx_cpu.py  --config exp/u2++_conformer/train.yaml --checkpoint exp/u2++_conformer/final.pt --chunk_size -1 --beam 15 --num_decoding_left_chunks -1 --output_dir ./onnx/
my OS is centos7

I think this doesn't affect the decoding result, since Addoutput_dim_0 and Concat_cnn_cache_dim_3 can be inferred during runtime.

I will try it for inference, and this may be a issue for onnx export, i think nbest need be set to a fixed value when exporting.

Have you solved the problem? I cannot feed the r_cnn_cache with an uncertain dimension to the encoder.

Discussed it offline, close this issue


text:
pre-trained models trained on only voxceleb1

I'm benchmarking speaker embedding models, for speaker verifications, that are trained and tested on the voxceleb1 dataset. I am referring to the pre-trained models list here but it looks like these models are trained on voxceleb2? if this is the case, are there any pre-trained models that have been trained on voxceleb1?

Sorry that we do not train any models on the voxceleb1 dev set, for it only has 1211 speakers, which is not enough for training a well-performed speaker verification system. You can try to train on voxceleb1 dataset using our codes and have a comparison.
We follow the protocol used in the VoxSRC challenge series. Training on the voxceleb2 dev dataset while testing on the whole voxceleb1 dataset, including vox1-O, vox1-E, and vox1-H, is widely-used for benchmarking. You can consider this setup.

authors: JiJiJiang sidhantls


text:
Account over LFS quota

I'm unable to clone the data due to an LFS error:
$ git clone https://github.com/wengong-jin/DSMBind.git
Cloning into 'DSMBind'...
remote: Enumerating objects: 61, done.
remote: Counting objects: 100% (3/3), done.
remote: Compressing objects: 100% (3/3), done.
remote: Total 61 (delta 0), reused 0 (delta 0), pack-reused 58
Unpacking objects: 100% (61/61), 51.86 MiB | 15.09 MiB/s, done.
Downloading data/antibody/test_HER2.jsonl (94 MB)
Error downloading object: data/antibody/test_HER2.jsonl (3cc268d): Smudge error: Error downloading data/antibody/test_HER2.jsonl (3cc268d539af711b87962c5807f4558ac00f6d4e7319b98b50652189c152e88e): batch response: This repository is over its data quota. Account responsible for LFS bandwidth should purchase more data packs to restore access.

Is the test data hosted anywhere else?  Perhaps https://zenodo.org/ could be a good option (and would include a DOI).

Yes the data is now moved to zenedo. Thank you for point it out!

authors: andybarry wengong-jin

repo: wengong-jin/DSMBind


text:
Where is the DB query result from?

Nice work!
Where is the DB query result in train, dev, test.tsv and the source in train, val, test.json from? It seems that they are the same.
Your paper said that the ground truth belief state and DB records are assumed available. So how to get the DB query result based on this assumption?

Hi there, this paper does not touch the state tracking part. However, during generation, we need the DB results to do the slot filling for post-processing. Therefore, we assume the state tracking (DB constraint) is already known to us at each round and use that as the SQL query to retrieve the DB result during pre-processing. This step is handled in preprocessing/create_delex_data.py, the code is revised based on "https://github.com/budzianowski/multiwoz/blob/master/create_delex_data.py".

Hi there, this paper does not touch the state tracking part. However, during generation, we need the DB results to do the slot filling for post-processing. Therefore, we assume the state tracking (DB constraint) is already known to us at each round and use that as the SQL query to retrieve the DB result during pre-processing. This step is handled in preprocessing/create_delex_data.py, the code is revised based on "https://github.com/budzianowski/multiwoz/blob/master/create_delex_data.py".

Thank you for your reply. I still have some questions about this issue. I have studied your revised create_delex_data.py, but i cannot find how the train, dev, test.tsv files are generated. And the train, val, test.json are generated based on train, val, test.bak.json where the "source" e.g. DB query result already exits, could please share the code of generating .bak.json files since i cannot find where the dbpointer.py is used.

Hi there, this paper does not touch the state tracking part. However, during generation, we need the DB results to do the slot filling for post-processing. Therefore, we assume the state tracking (DB constraint) is already known to us at each round and use that as the SQL query to retrieve the DB result during pre-processing. This step is handled in preprocessing/create_delex_data.py, the code is revised based on "https://github.com/budzianowski/multiwoz/blob/master/create_delex_data.py".

Get it! Thank you for your reply!

Sorry for another question. In create_delex_data.py, the train, val, test.json files are generated using train, val, test.bak.json files. I wonder where these bak.json files are from and what they are used for?

Hi, the bak file is only for reusing the dialog act we defined in the previous version. It has nothing to do with the DB records, the relevant lines about the DB records are from line 202-221 from create_delex_data.py. You can specifically look into these lines to understand how it is generated.

Thank you very much for your reply.

authors: taolusi wenhuchen

repo: wenhuchen/HDSA-Dialog


text:
Inference on video

Hi, Thanks for the amazing work. I was wondering if there is a way to test it on user-passed video as input. Please highlight the steps to run inference.
Thanks.

I'd also be interested in this, I tried to use the existing code to run one of my own videos, but the results were basically noise - hopefully I just did something wrong!

@danielcrane just use transnet v2, it's very easy to use the pytorch version

@danielcrane just use transnet v2, it's very easy to use the pytorch version

@eisneim Indeed yes I'm currently making use of that, it's very good, just wanted to test performance differences!

@danielcrane just use transnet v2, it's very easy to use the pytorch version

@eisneim Indeed yes I'm currently making use of that, it's very good, just wanted to test performance differences!

well I use transnet v2 and autoshot both for my own dataset , but I find noise and misjudge for gradual transition ,do you know how to fix it?

@lrbk for long transitions i found no solutions, so what i did is cut them manually;  but for the most part TransnetV2 is saving me a lot time

@lrbk for long transitions i found no solutions, so what i did is cut them manually; but for the most part TransnetV2 is saving me a lot time

@eisneim I follow the training instruction of TransNetV2, but i found some problem with gin and its config parameters.Could you tell me which version of gin and other library you used?

@lrbk i didn't do any training, just use the pretrained weights

@lrbk for long transitions i found no solutions, so what i did is cut them manually; but for the most part TransnetV2 is saving me a lot time

@eisneim I follow the training instruction of TransNetV2, but i found some problem with gin and its config parameters.Could you tell me which version of gin and other library you used?

Hello, I am also trying to copy the training of transnetv2. Have you succeeded? Are there any special configurations that need to be paid attention to?

i didn't do any training, just use the pretrained weights

i didn't do any training, just use the pretrained weights to find cut point and divide the video into small parts

repo: wentaozhu/AutoShot


text:
chore: release 2.14.0

:robot: I have created a release *beep* *boop*
2.14.0 (2024-11-26)
Features

build, docker, buildah, dockerfile: add secrets support (#6429) (dac370b)
giterminism: add build secrets (#6436) (266dc99)
release: publish werf images for linux/arm64 platform (#6427) (833b26d)

Bug Fixes

cleanup: fix cleanup for Buildah images by switching to tag-based logic (73fcc1b)
cleanup: keep relatives for keepImagesBuiltWithinLastNHours policy (a0eb160)
unsorted Set.ToSlice usage in parallel task execution (2f5d536)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/werf/werf/releases/tag/v2.14.0 :sunflower:

repo: werf/werf


text:
Не стартует закачка с Kinozal

Какие-то работают, какие-то нет
Например эта http://kinozal.tv/details.php?id=1591233. После запуска время обновления не меняется "Last update: not specified". Хотел продебажить, но видно невдаха.

@DmitryRibalka заработало?

@werwolfby заработало само, что-то было с версткой. Если что-то вылезет, то буду уже дебажить.

@werwolfby  Вроде понял почему, не у всех новых торрентов есть дата обновления
вот например http://kinozal.tv/details.php?id=1605266

authors: DmitryRibalka werwolfby

repo: werwolfby/monitorrent

license: WTFPL


text:
Add tests for windows paths

This should do the trick 😄

One for @wesbos when you get a chance to take a look 👌

Thanks a ton - should this test not makes sure it can require something with double paths? As I'm reading it, it makes sure it fails?

Ah I think I see - sorry need to revert this

authors: Daniel-Griffiths wesbos

repo: wesbos/gatsby


text:
Bug: Unintended values come in due to automatic input by google chrome

Environment
Host

item
version

OS
mac OS 10.15.4

GROWI
3.8.1-RC

node.js
12.14.0

npm
6.13.4

Using Docker
no

Using [growi-docker-compose][growi-docker-compose]
no

Client

item
version

OS
mac OS 10.15.4

browser
chrome 80.0.3987.163

How to reproduce? (再現手順)

Make google remember password at login.
Access to user settings page

What happens? (症状)

There is a name in the field to enter the email address

What is the expected result? (期待される動作)

Email address comes in automatically

Attempted to fix this issue here(https://github.com/weseek/growi/releases) but it's still happening in dev/4.5.x.
Currently looking for an implementer

Fixed the issue in all the versions

authors: Shunm634-source Yohei-Shiina itizawa

repo: weseek/growi


text:
Improvement: Edgeからドラッグ&ドロップで画像をアップロードできるように修正する

Environment
Host

item
version

OS
CentOS 7

GROWI
3.1.11

node.js
8.11.3

npm
5.6.0

Using Docker
yes

Using [growi-docker-compose][growi-docker-compose]
yes

Client

item
version

OS
Windows 10

browser
Microsoft Edge 41.16299.522.0

How to reproduce? (再現手順)
EdgeでWikiにアクセスし、編集画面で画像ファイルをドラッグアンドドロップする
What happens? (症状)
画像がアップロードされない
Note
Firefoxでは通常通りアップロードできました

@tremblerscreed ご報告ありがとうございます。
一応 Firefox, Chrome で正常動作することを目安にしていますので多少優先度は落ちますが、余裕のあるときに対応しようと思います。

#1087 の調査・修正の過程でこちらの症状は修正されました。v3.5.2 以降をご利用ください。

authors: tremblerscreed yuki-takei


text:
Lots of 204 responses

Hi there, thanks a lot for your awesome work.
Starting today, I keep getting 204 responses when loading images from my app pages (app.alobees.com):

If I open the image URL directly in the browser, the image displays well and refreshing the initial page, I get a 200 and it now shows better:

But all other images still get 204. Any idea?

Our automated system to block abuse flagged some traffic, and made rules that blocked a bit too much. I'll spare you the details, but somewhere a regular expression got a bit too inclusive, and your request payload was matching this.
The 204 is send by this system as a last resort to prevent users from hogging resources, it's the fastest way of telling the client to keep going and ignore the response, but normal use should not trigger this.
Should be fixed now, could you verify this?

Yes it looks ok now, thank you so much for your reactivity.

No problem, thanks for the report!

authors: andrieslouw ebaynaud

repo: weserv/images


text:
🛑 Bug Monitor (Third-Party) is down

In 484fd1b, Bug Monitor (Third-Party) (https://bugreport.indexyz.me) was down:

HTTP code: 530
Response time: 214 ms

Resolved: Bug Monitor (Third-Party) is back up in 1cba4e8 after 5 minutes.

repo: wfjsw/status-winterco-org


text:
timeit-profile

We use timeit to compare performance of similar code:
$ python -m timeit -s 'import foo' 'foo.egg()'
10000 loops, best of 3: 25.2 usec per loop
$ python -m timeit -s 'import foo' 'foo.spam()'
10000 loops, best of 3: 40.3 usec per loop

Now we know foo.spam() is slower.  But why?
profiling should provide timeit as a command.  It will be helpful to inquire into the cause of the performance loss.
$ python -m profiling timeit -s 'import foo' 'foo.spam()'
            ^^^^^^^^^
           Just add it.

Implemented at 9c5c5b355d4ef6b6b50f9575ff83c7bd95726eb9.

repo: what-studio/profiling


text:
add starter queries for SQLcaster users

gm @whatrocks I've added a directory sql_queries with a file called starter_queries.sql for SQLcaster users.
seven queries with descriptions are contained in the file.
all queries have been tested and are currently working on SQLcaster.
note: an update in data indexing could change results.

This is great stuff, and I think it's fine to keep this directory going as a good reference. But I'd also suggest adding these here: https://github.com/whatrocks/sqlcaster/blob/main/pages/index.tsx#L10. The "I'm Feeling Lazy" button can just cycle through these samples. I think that "in-app" documentation is probably going to be more useful to more people!

This is great stuff, and I think it's fine to keep this directory going as a good reference. But I'd also suggest adding these here: https://github.com/whatrocks/sqlcaster/blob/main/pages/index.tsx#L10. The "I'm Feeling Lazy" button can just cycle through these samples. I think that "in-app" documentation is probably going to be more useful to more people!

hi @whatrocks i've added those starter queries into the CANNED_QUERIES array in index.tsx.👍🏻

Thank you! This is great!

authors: PaulApivat whatrocks

repo: whatrocks/sqlcaster


text:
Remove my.catgirl.party, how-about-th.at, catch-me-outside.how-about-th.at and woah.this-is-a.site

🙏 that I did things correctly, never used gulp before.

same

authors: DoNotSpamPls lordjbs

repo: whats-this/landing


text:
Doc improvements

Hello,
(disclaimer, I am just starting with elixir)
I lost a fair bit of time trying to set values containing white spaces.
I think it might be worth it to add to the doc that we can also use something like
cmd = ["HSET", "username:1", "Name", "My Name"]

to prepare commands since
cmd = ~w(HSET username:1 name "My Name")

will not work with values containing white spaces...
Thanks!

This has come up before, so I pushed a commit removing ~w from the documentation in favor of normal lists. I hope it's gonna be enough so that it's clear how to pass strings with spaces, since without ~w it shouldn't be a problem anymore. :)
Let me know how it looks and thanks for the report! 💟

yes I think it's better. thanks!

authors: nonotest whatyouhide

repo: whatyouhide/redix


text:
Add flavour field

Describe the solution you'd like
A description field for the merchant will be shown to those that enter the shop.

Are you just looking for an idea of where on the sheet to put the description or something else?
If so then I think right below the merchant's image and above the "GM Settings" is a perfect place for it. Your eye is drawn to the picture and then the description would be right below it.
Have to move GM Settings down of course. Or, better yet, have the new Description field be flexible.

@Shuggaloaf I'm no expert in CSS and HTML. Do you have any expertise in this? I will see what I can do soon.

@whelan Sorry I must have misunderstood. I thought you were asking for ideas for design/layout/etc. I didn't realize you were asking how to do it. Unfortunately I can't help you with that. Maybe try the Foundry Discord server. There's a lot of really smart peeps on there. I'd love to see it though so good luck!

You helped very much. And sorry, it was more if you could help. I will look into it when I have the time. Please provide more ideas if you see some that could be made.

Added in 1.1.4

authors: Shuggaloaf whelan

repo: whelan/fvtt-merchant-sheet-npc


text:
Fix Binance Market validation

Description
Binance has coins like 1INCH that can be used because of current RegExp
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of change
Please make your selection.

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update
[ ] This change requires a new dependency
[ ] Code Maintainability / comments
[ ] Code Refactoring / future-proofing

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.
Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added pytest unit tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules
[x] I have checked my code and corrected any misspellings

Thanks @byymster. Is this change for Binance specifically? Does the same update not have to happen for Coinbase Pro and Kucoin as well? Can you please check?
There seems to be conflicts in models/TradingAccount.py. Can you please review and adjust accordingly?
PR's need to be raised against the "beta" branch. I've changed the PR to "beta".

Thanks @byymster. Is this change for Binance specifically? Does the same update not have to happen for Coinbase Pro and Kucoin as well? Can you please check?
There seems to be conflicts in models/TradingAccount.py. Can you please review and adjust accordingly?
PR's need to be raised against the "beta" branch. I've changed the PR to "beta".

HI @whittlem
Other exchanges already has this RegEx
See code:
if self.app.getExchange() == "coinbasepro" and market != "":
            p = re.compile(r"^[1-9A-Z]{2,5}\-[1-9A-Z]{2,5}$")
            if not p.match(market):
                raise TypeError("Coinbase Pro market is invalid.")
        elif self.app.getExchange() == "binance":
            p = re.compile(r"^[A-Z]{5,12}$")
            p = re.compile(r"^[1-9A-Z]{5,12}$")
            if not p.match(market):
                raise TypeError("Binance market is invalid.")
        elif self.app.getExchange() == "kucoin":
            p = re.compile(r"^[1-9A-Z]{2,5}\-[1-9A-Z]{2,5}$")
            if not p.match(market):
                raise TypeError("Kucoin market is invalid.")

@whittlem conflict is resolved

authors: byymster whittlem

repo: whittlem/pycryptobot


text:
repo2docker integration discussion

As we've looked into integrating with repo2docker, three points have come up:

We'd like the ability to change the base image or, perhaps more useful, to parameterize the template
We need a way to store the repo2docker version so we know which version to use (and possibly template) to generate an image from a Tale/repo ala https://github.com/jupyter/repo2docker/issues/170#issuecomment-356482270
Using an /environment directory  ala https://github.com/jupyter/repo2docker/issues/386

On the topic of changing the base image, we have two different motivations.

WT doesn't require Jupyter in all images (we don't use JupyterHub today).  For example, we run Rstudio directly and envision doing the same for other environments, although admittedly they'll be edge cases as our primary cases are covered by Jupyter/Rstudio today.
We have at this point primarily anecdotal evidence of communities that need non-Ubuntu base operating systems. The Dark Energy Survey (DES) and LSST projects have most of their tools packaged for CentOS. From the last WT OSI WG call, it's my understanding that the Neurodebian packages eventually find their way to Ubuntu, but there's often a delay.

In the first case, we would want to change the template but not necessarily  the base OS.  In the second, we might want to change the base OS and eventually add things like buildpacks for yum.txt. This may open a Pandora's box.
Pinning the repo2docker version and supporting the /environment subdirectory seem less controversial.

We've started the process of integrating repo2docker into Whole Tale platform for image customization.  The primary rationale is that we can leverage and contribute to an existing project instead of developing something that would end up being quite similar in the end.
One of the broader issues we've encountered is RStudio support. For example:

It's not possible to have RStudio be the default application on an empty repo/workspace
While it is possible to run RStudio from repo2docker, the built image still uses the Jupyter PORT and CMD
Today, Whole Tale leverages the rocker/geospatial images, while repo2docker assumes an Ubuntu base then installs  rstudio-server and shiny-server via buildpack. The only Binder example that uses rocker images requires a Dockerfile
If we allowed specifying an alternative base image, we'd likely run into problems with versioning strategies.  For example, repo2docker allows the user to change the runtime, while the runtime is baked into the rocker images.

For us, primary benefit of using repo2docker is the templated customization. Users can extend the environment without needing to know how to write a Dockerfile.  Another benefit is that Tales in Whole Tale will be compatible with Binders. I can push my Tale to Github or import my Binder to Whole Tale.
Are there any existing initiatives to bridge these two worlds? Is it worth WT pursuing?
@cboettig I wonder if you have any thoughts one this.

Hi @craig-willis , these are good questions and not sure there are any easy answers, though @choldgraf, @yuvipanda and co will very likely have better answers than me.
Like you say, it would be possible for WT to parse  the templated customization (I think by this you mean files like requirements.txt and apt.txt to customize the install?) without actually building on the same images.  That would likely work most of the time and create really hard-to-debug problems for those rarer instances where getting the same package from different upstream sources causes problems.
I recently tried reconstructing a project from the deep past of 2015 (aka prior to rocker versioned stack; though of course this being science most of the code base was a year or two older).  Picking the MRAN date to match reliably got me viable versions of the R packages needed, but I had to track down and compile the right versions of JAGS, pandoc, and pandoc-citeproc (the latter two obviously only relevant for the output and not the computation) onto a versioned image before things would build (see Dockerfile.  I raise this example because it highlights a few lessons for me: apt.txt wouldn't cut it, as debian:jessie, debian:stretch, ubuntu:16.04, etc ship different versions of these things.  but also that regardless of the base platform of the containerized system, as the user I still have to do this similar translation from whatever my native environment was, and that is often the hardest part (particularly in the past). so this is always something of a problem unless you're developing on the containerized system or something very close to it...

Regarding the default application, since that can be toggled in the link structure used to launch the image, (the ?rstudio) -- not sure if that's sufficient for WT use?

As far as interoperability is concerned, I do get that most scientists don't want to write Dockerfiles, but I'm still hesitant about alternative strategies for fancy customization. I suspect the majority of use cases are simple scripts that can be run out of the box without anything special, or extended using existing language-specific standards & packaging mechanisms (DESCRIPTIONs, requirements.txt / setup.py, gemspec, etc).  but that's also my bias

Thanks for the great feedback, @cboettig.  I should've acknowledged that Binder team has certainly been very supportive in helping us work through some of these issues.   As I'm working to replace our base rocker/geospatial base image with repo2docker I guess I'm coming to terms with what we might lose in the transition.

@craig-willis I think you've already nailed it in that the main risk is that some things that work in a rocker/geospatial stack aren't going to work on repo2docker's ubuntu based images.
Copying over things from the rocker stack will help that (e.g. libs installed in both geospatial and verse); but of course some versions of libs might be different that way and that could break things that worked on rocker/geospatial. (binder is ubuntu:18.04 based by default now?  What's binder's model for when to update LTS? at the time of the new LTS release or not until the old one reaches end of life?  How do I indicate which binder image/ LTS release I want?)   My more general concern is that it feels less obvious to me what is in the binder stack and how test and debug it locally.

Thanks again, @cboettig.
I'm thinking that we could continue supporting the rocker base images -- either via repo2docker's explicit Dockerfile method or even via our original build mechanism.  If the rocker images are intended to be extended via Docker, then maybe the community will be comfortable with this approach.  We can use the basic repo2docker model for our other users that need simple Rstudio with a handful of packages.
I don't have answers to all of your questions and would be interested to hear how the decisions are made for rocker.  They have moved to 18.04 and I expect they would move to the new LTS close to when it's released.  I'm actively working on adding the ability for a repo to pin to a particular repo2docker version, which determines the LTS version.

My more general concern is that it feels less obvious to me what is in the binder stack and how test and debug it locally.

It does require the leap to accept repo2docker instead of Docker and some of the assumptions that come with it.  I've advocated for WT to adopt it as a component with the hope of benefitting from many reproducibility-minded folks working in the same space.

might also be worth looping in @karthik, who has also been working on finding more friendly ways to support repo2docker (well, Binder really) in the R community. If I recall, he wrote a little tool that constructs binder-ready Dockerfiles from R repositories. In a sense that circumvents what repo2docker is doing, but it might be a nice way to keep technical development overlapping.
re: LTS etc, @cboettig that is a great question. the repo2docker/binder communities are still figuring out how far to push on reproducibility features in the longer-longer term. It would be great if you could provide your thoughts on what sounds reasonable!

Thanks @choldgraf.
One of our initial plans was to to make the repo2docker template configurable.  We abandoned this idea since it seemed like most use cases could be supported with the current template. (On one of the community calls, I think we discussed supporting this type of extension not through templates but through the buildpack mechanism). In light of the rocker case, I wonder if this is worth revisiting. Looking at https://github.com/bocinsky/guedesbocinsky2018 as a recent example, it seems like it would be useful to be able to simply add an apt.txt and install.R to this repo and declare that they're basing this on a rocker-geospatial template/buildpack (and therefore debian:stretch instead of buildpack-deps:bionic).

yeah, this still feels compelling to me...not sure what the broader repo2docker consensus is around this topic. Perhaps it's worth making a specific proposal around that we can discuss as a group? Something with enough meat on it that we can discuss pros, cons, etc?
I'd love to hear @cboettig's thoughts on this as well! :-)

I've been working on a proof-of-concept and will gladly write something up and circulate for comment.   As I recall, those on the call were open to the idea, but we didn't have a compelling example -- I just didn't realize that it was under my nose!

Connecting this to @choldgraf's original thread about making the base image configurable:
https://github.com/jupyter/repo2docker/issues/487
I think the discussion of potentially adding Rocker support to repo2docker should go there.

This integration was completed in 2019 (see  https://github.com/whole-tale/gwvolman/pull/43). We currently maintain our own fork of r2d (https://github.com/whole-tale/repo2docker) and plugin (https://github.com/whole-tale/repo2docker_wholetale/) that includes support for Rocker, MATLAB and STATA environments.

This integration was completed in 2019 (see  https://github.com/whole-tale/gwvolman/pull/43). We currently maintain our own fork of r2d (https://github.com/whole-tale/repo2docker) and plugin (https://github.com/whole-tale/repo2docker_wholetale/) that includes support for Rocker, MATLAB and STATA environments.

authors: cboettig choldgraf craig-willis

repo: whole-tale/whole-tale


text:
增加上海海事大学链接

增加上海海事大学链接

感谢支持！

repo: wht-im/wht-university-link


text:
🎉 Show folders in views! 🎉

This cool PR adds the option to show folders in the thumbnails, files and clips view! 🎉
It basically replicates a standard file browser, which a lot of people will probably like - and the ability to browse to a folder, then flip the folder view off and continue like normal is very cool! 😄
It has some pretty snazzy features, which I'll leave you to try it to see what you think! 😉
I also removed the folder only view, as I don't think it added anything with this option now - I can revert that commit if you think otherwise! 👍
Caveats:

Only works with the default sort due to the way folders are computed. Auto toggles on and off if you swap sorts!
Folder Intersection is treated as an exact prefix match if the first entry starts with /
Probably doesn't work on Windows yet, will test now!

Update: Works on Windows here for me, but only because I created the library on Linux - see #131

I haven't tested this on Windows yet, but this should now work with either an existing library after doing a meta regen in the settings, or on just a new library with this version! 👍
I've also added support for sorting with folders enabled! 😄 🎉 Along with folder contents details!

Ready for review! 👍

These are going to have a few merge conflicts, so whenever you get a chance to check them out just let me know which you're good with and I'll address the conflicts and merge them! 👍

❤ OMG you're amazing 🌟
This is so cool! 🙇

repo: whyboris/Video-Hub-App


text:
https://www.python.org/dev/peps/pep-0440/

i get PEP 440 problem with current dspam-milter
in case some like to help me solve gentoo ebuild my work is here
layman -a fidonet
emerge --autounmask-write dspam-milter
emerge --buildpkgonly dspam-milter

What is the actual problem? I don't use ebuilds, but if you need a tarball to base your package on, you should use a released one, as that has an actual semver compantible version. Latest release at https://github.com/whyscream/dspam-milter/releases should work i think.
Otherwise, please state your actual problem ;)

its not ebuilds, imho you miss to build test more for that i started with in this thread here, PEP 440 is not gentoo specific in ebuilds
great to see dspam still lives in good fame

As long as you cannot explain your problem, I cannot help you. When you talk about ebuilds, it seems to me that I need to run your ebuild in order to find out your actual issue: I'm sorry but I can't do that.
All releases have proper x.y.z versions, as described in the PEP you talk about. So I don't understand your problem.

pep 440 are not very gentoo or even ebuild specific, i will make a web error log when i have time to debug my own fails later
i could use precompiled problems to hide precompiled problems reports
would it be possible to make dspam in 100% python aswell ?
i ask for this since it would solve more problems i have not yet reported :(

Closing until you have time to debug and create a log.

authors: tomhendrikx whyscream xpunkt

repo: whyscream/dspam-milter


text:
🛑 Mastodon assets is down

In a6f1b65, Mastodon assets (https://assets.mstdn.uec.tokyo/mastodon/accounts/avatars/000/000/002/original/7c1c520de04c6952.png) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Mastodon assets is back up in e72922e.

repo: whywriteit/upptime