text:
Update workspace naming from Overview to Profile

Details
Implement Update name convention from Overview to Profile for all workspace level items like components, functions, routes, etc. from the Simplified Collect: Profile, Members, Categories design doc
Fixed Issues
$ https://github.com/Expensify/App/issues/35718
PROPOSAL: https://github.com/Expensify/App/issues/35718
Tests

Open any workspace settings
Verify that in the left menu first item is Profile
Verify that top section has naming Profile as well

On mobile:

Open workspace settings
Verify that first menu item is Profile
Click on Profile
Verify that back button is shown with text Profile

[x] Verify that no errors appear in the JS console

Offline tests

Open any workspace settings
Verify that in the left menu first item is Profile
Verify that top section has naming Profile as well

On mobile:

Open workspace settings
Verify that first menu item is Profile
Click on Profile
Verify that back button is shown with text Profile

QA Steps

Open any workspace settings
Verify that in the left menu first item is Profile
Verify that top section has naming Profile as well

On mobile:

Open workspace settings
Verify that first menu item is Profile
Click on Profile
Verify that back button is shown with text Profile

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x]  I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

Reviewer Checklist

[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[ ] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[ ] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If any new file was added I verified that:

[ ] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)

[ ] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[ ] If the PR modifies the form input styles:

[ ] I verified that all the inputs inside a form are aligned with each other.
[ ] I added Design label so the design team can review the changes.

[ ] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[ ] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

Thanks for getting started on this review @DylanDylann. This is a high value project, so if you could prioritize this review that'd be great!

@luacmartins All yours

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/luacmartins in version: 1.4.40-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
failure ❌

🚀 Deployed to production by https://github.com/mountiny in version: 1.4.40-5 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
failure ❌

authors: DylanDylann OSBotify luacmartins narefyev91


text:
improvement: Use Const for 'violation' everywhere we check for violation type.

Details

Fixed Issues
$ https://github.com/Expensify/App/issues/39227
PROPOSAL: https://github.com/Expensify/App/issues/39227#issuecomment-2026693784
Tests
No tests required

[x] Verify that no errors appear in the JS console

Offline tests
No tests required
QA Steps
No tests required

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

@akinwale, what should we do for test steps and recordings? 🙇🏻

I don't think we need test steps here, but for recordings, you could probably just take screenshots from any screen to demonstrate that the app is running.

Reviewer Checklist

[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[x] I verified testing steps are clear and they cover the changes made in this PR

[x] I verified the steps for local testing are in the Tests section
[x] I verified the steps for Staging and/or Production testing are in the QA steps section
[x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I checked that screenshots or videos are included for tests on all platforms
[x] I included screenshots or videos for tests on all platforms
[x] I verified tests pass on all platforms & I tested again on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[x] I verified proper code patterns were followed (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I verified that this PR follows the guidelines as stated in the Review Guidelines
[x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/yuwenmemon in version: 1.4.59-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/Julesssss in version: 1.4.60-13 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

source: gharchive/pull-request

authors: Krishna2323 OSBotify akinwale

repo: Expensify/App

license: MIT

license_type: permissive

license_source: github-api


text:
Fix group chat name and avatar of quick action does not update dynamically

Details

The name and avatar of quick action don't update dynamically and this PR fix it.
Fixed Issues

$ https://github.com/Expensify/App/issues/40536
PROPOSAL: https://github.com/Expensify/App/issues/40536#issuecomment-2067973004
Tests

Same as QA Steps

[x] Verify that no errors appear in the JS console

Offline tests

Same as QA Steps
QA Steps

Split bill in a group chat
Verify it's shown in the FAB quick action
Go to the group chat settings and edit the name and avatar
Open the FAB
Verify the group name and avatar is updated
(web/desktop only) Hover over the avatar
Verify the group name and avatar in the tooltip is updated

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

https://github.com/Expensify/App/assets/50919443/8c10b2ed-e2a6-45d1-a95a-24b0ebc9dab2

Android: mWeb Chrome

https://github.com/Expensify/App/assets/50919443/022c1e76-d21e-4373-b243-f8e7a9caac0c

iOS: Native

https://github.com/Expensify/App/assets/50919443/5511eca3-8b5e-4724-baec-77b8308621d3

iOS: mWeb Safari

https://github.com/Expensify/App/assets/50919443/a2573704-d199-4fff-ad27-63a8d281c8b2

MacOS: Chrome / Safari

https://github.com/Expensify/App/assets/50919443/7957f278-79d5-406e-b963-7ef2a54405f8

MacOS: Desktop

https://github.com/Expensify/App/assets/50919443/a1606a04-51f9-44e5-b2e9-b612ff64020a

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/marcaaron in version: 1.4.67-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/francoisl in version: 1.4.67-7 🚀

platform
result

🤖 android 🤖
failure ❌

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/francoisl in version: 1.4.67-7 🚀

platform
result

🤖 android 🤖
failure ❌

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

authors: OSBotify bernhardoj


text:
Fix - Category rules - default tax rate field is blank for a moment after editing category name

Details

By the way, the problem regarding the approver (policy?.rules?.approvalRules) has already been handled in https://github.com/Expensify/App/pull/48325 following my third approach (updating the optimistic data) so in this PR I handled the other bug I mentioned, which is the related with the default tax rate (linked to policy?.rules?.expenseRules), by updating the expenseRule optimistically on category renaming.
Fixed Issues

$ https://github.com/Expensify/App/issues/49293
PROPOSAL: https://github.com/Expensify/App/issues/49293#issuecomment-2353751940
Tests

Precondition: Taxes, Rules and Workflows are enabled.

Go to workspace settings > Categories.
Click on any category.
Click Default tax rate and select any tax rate different from the default value.
Press on the name menu.
Change the name of the category and press on Save button.
Verify that the default tax rate is the one you set in (3).

[x] Verify that no errors appear in the JS console

Offline tests

QA Steps

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

https://github.com/user-attachments/assets/f454cf6a-4967-45c1-a55e-87042551b187

Android: mWeb Chrome

https://github.com/user-attachments/assets/e9ec8ca5-9c0f-45ba-8c86-e668b3dd4782

iOS: Native

https://github.com/user-attachments/assets/d80d6755-f4a2-4c8f-8ca3-7942c9e2ba5c

iOS: mWeb Safari

MacOS: Chrome / Safari

https://github.com/user-attachments/assets/5435cd0d-e70d-4e6f-be33-f32831805149

MacOS: Desktop

https://github.com/user-attachments/assets/9e3949d2-8ebc-463e-a792-0d79515f8f63

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

authors: FitseTLT OSBotify


text:
[Snyk] Security upgrade grunt-eslint from 22.0.0 to 25.0.0

This PR was automatically created by Snyk using the credentials of a real user.Snyk has created this PR to fix one or more vulnerable packages in the `npm` dependencies of this project.
As this is a private repository, Snyk-bot does not have access. Therefore, this PR has been created automatically, but appears to have been created by a real user.
Changes included in this PR

Changes to the following files to upgrade the vulnerable dependencies to a fixed version:

package.json

⚠ Warning
Failed to update the package-lock.json, please update manually before merging.

Vulnerabilities that will be fixed
With an upgrade:

Severity
Priority Score (*)
Issue
Breaking Change
Exploit Maturity

631/1000  Why? Proof of Concept exploit, Has a fix available, CVSS 6.2
Missing Release of Resource after Effective Lifetime SNYK-JS-INFLIGHT-6095116
Yes
Proof of Concept

(*) Note that the real score may have changed since the PR was raised.

Commit messages

Package name: grunt-eslint
    The new version differs by 20 commits.

82c984f 25.0.0
5d282f8 Meta tweaks
81834b4 Update to ESLint 9, support flat config, and require Node.js 18 (#175)
0704be0 v24.3.0
495118b Update dependencies
fac0aff 24.2.0
826ca5f Update dependencies
88cbcac 24.1.0
89eb056 Support async formatters (#174)
63a9fe7 24.0.1
1322e30 Fix the plugin not finishing in some cases
259ce5c Meta tweaks
5e086f7 24.0.0
7bb705b Cleanup
dbaf9d5 Upgrade to ESLint 8 and require Node.js 12 (#171)
3de5e21 Move to GitHub Actions (#170)
61e98a9 23.0.0
2ba9e26 Meta tweaks
a8f45f6 Upgrade to ESLint 7 and require Node.js 10 (#167)
274625a Update link to built-in formatter (#164)

See the full diff

Check the changes in this PR to ensure they won't cause issues with your project.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
🛠 Adjust project settings
📚 Read more about Snyk's upgrade and patch logic

Learn how to fix vulnerabilities with free interactive lessons:
🦉 Learn about vulnerability in an interactive lesson of Snyk Learn.

This didn't update the package-lock.json file

Getting a new reviewer because I have commits on this now.

authors: MelvinBot yuwenmemon

repo: Expensify/expensify-common


text:
DocHub (wrong?) link

The link in the wiki/References-And-Links to DocHub points to a .io domain that appears to be empty / for sale – not sure what the actual link should be (.com?)

Looks like it's been down for a while. Here's the last record of it via WayBack:
https://web.archive.org/web/20141016022040/http://dochub.io/
From that page I found the GitHub repo:
https://github.com/rgarcia/dochub/issues
Looks like there's an issue:
https://github.com/rgarcia/dochub/issues/49
Looks like their twitter feed has been inactive for a while:
https://twitter.com/documenthub
With that said, I am not sure of what a good replacement link would be as I don't know what dochub.io offered … Maybe this:
https://searchyapp.io/scopes/web-developer
This one also is interesting, though, probably not the same as dochub;
https://searchcode.com/
So, should we just remove the link? Can anyone think of a replacement site?

I actually can't remember what doc hub was. Some kind of reference

source: gharchive/issue

authors: fabianmoronzirfas mhulse undavide

repo: ExtendScript/wiki

license: Unlicense


text:
Enable Semantic PRs doesn't apply for existing PRs

After enable Semantic PRs on bytebase/bytebase and close & reopen PR https://github.com/bytebase/bytebase/pull/1445, it seems Semantic PRs app doesn't report the status. Only new (created) PRs will trigger the App.
Is it possible to (re)check and report the status when a PR is reopened?

After a new commit pushed, it seems this App is triggered. Keep open for @Ezard's opinion.

@tisonkun unfortunately I don't think there's a way for it to be triggered on PRs that are already open 😔 (although I'm happy to be proved wrong if you know how to do this haha)
I can definitely add a trigger for when PRs are reopened though, sure!
I'm pretty busy today and tomorrow, so I'll probably implement this on Thursday

I don't think there's a way for it to be triggered on PRs that are already open.

Haha, I think so.

I can definitely add a trigger for when PRs are reopened though, sure!
I'm pretty busy today and tomorrow, so I'll probably implement this on Thursday

Thank you! Take your spare time :)

authors: Ezard tisonkun

repo: Ezard/semantic-prs


text:
🛑 PR Medialogia is down

In 6d77f8f, PR Medialogia (https://pr.mlg.ru) was down:

HTTP code: 0
Response time: 0 ms

Resolved: PR Medialogia is back up in fb1bff3 after 23 days, 9 hours, 10 minutes.


text:
queryString中传入是中文的时候，被编码

暂时去除了编码转换，后面重构时看看能不能自动编码解码，目前解码这块没法很好地处理，尤其是分享出去地页面

authors: EslRain F-loat

repo: F-loat/mpvue-router-patch


text:
PS2 Not locating the file.

My problem is exactly what the title says. I'm using FreeUSBBoot to launch the exploit, but when I go to the mass section of it, nothing at all shows up. I've tested with two different drives (A USB 3.0 and USB 2.0 both formatted to fat32,) and always get the same result.  Is there a certain slot it's supposed to be plugged into? And if not, are there any other reasons this could be happening? Thank you!

Also wanted to add that my console's model number is SCPH-70012, and that this is a fresh install of freedvdboot

I'm not exactly sure what would be the cause of ulaunchelf not detecting your USB / it's files. I would ask here https://discord.gg/Bd3A7v8 as they are probably more knowledgeable than I, best of luck!

I'm not exactly sure what would be the cause of ulaunchelf not detecting your USB / it's files. I would ask here https://discord.gg/Bd3A7v8 as they are probably more knowledgeable than I, best of luck!

Thank you so much! For some reason, my drive was formatted as gpt... so yeah, bad mistake


text:
Feature Request: Run a "sanity-check" program

Hello!
This is a very great project! I have been looking for a much smaller but still capable process supervisor compared to PM2 and this looks like it is exactly what i need :)
I would like to request/suggest a feature: Allow the user to specify a "sanity check". For instance, imagine this shell script:
#!/bin/bash

check() {
  command -v $1 >/dev/null
  if [ $? != 0 ]; then
    echo "$1 was not found!"
    exit 1
  fi
}

check go
check node

If either of these fail, the script exits with exit code 1.
What I would like to do is to run this before any of the processes are invoked as a way to introduce a script that verifies the environment if everything is exactly where it should be. :)
Again thanks a lot for this project, been playing around with it today a lot and it's great!
Kind regards,
Ingwie

Good morning!
You are most welcome!

Globally. It should just make sure all things are where and how they should be.
No, it should run before all processes. If it returns true, assume that everything is fine and proceed to start the processes.
This could be considered - but I think it'd be better if a per-process check failed, it should only mean that this process can not be started and should only affect dependees.
Depends on if the user supplied arguments or not. Like if they only want to run one process out of many, I think the global check should still run. You could consider passing a PROCESS_COMPOSE_PROCS environment variable to tell the check if it should limit its checks or not.

Feel free to ask! I am not very good with Go, so there is not that much I can contribute. More of a C and Nodejs guy. ^^;

Good afternoon.
I think I have a clearer picture of what you want to achieve.
I think that even today this is almost possible if you define the first process to be this check and all other processes are dependent on it. Or at least the first process in the chain is dependent on it.
The only thing that is missing is the ability to exit on process failure.
What do you think about the following:

I will add support to configure an exit strategy if the process exit code != 0. This will be optional. If not configured the behavior will be as today.
If configured and exit code != 0 the process-compose will gracefully terminate all the other running processes (in case of the preflight check there shouldn't be any) and exit with the same exit code as the check process.
As today, you will be able to disable/enable the check process in configuration.
As a separate feature, I will add the support to run specific processes by providing a CLI argument to process compose. This way you will be able to run all the checks individually and validate their correctness before running all the other processes.
There is a downside to this approach - the check process(es) will be visible in the TUI, I am not sure if this can be a deal breaker for someone.

What do you think?
You are contributing a lot by using the project and thinking about new use cases 😊

Hey!

I think that even today this is almost possible if you define the first process to be this check and all other processes are dependent on it

Good point, didn't think of that. So basically:
sanitycheck:
  command: ./scripts/run-checks.sh

other_proc:
  command: ...
  depends_on:
    sanitycheck:
      condition: process_completed_successfuly

Like so?

What do you think about the following:

I like 2 a lot. 5 is not a big problem really - at least I don't think so.

You are contributing a lot by using the project and thinking about new use cases 😊

Haha, thanks! Most welcome as well. :)

Hey @IngwiePhoenix
Yes, exactly! Your code snippet sums up the idea.
BTW, even today the processes won't run if all of them are process_completed_successfuly dependent on sanitycheck.
I will implement 1-4.

Thanks for the great issue @IngwiePhoenix!
My 2 cents on this as user is that instead of trying to treat the symptoms of an incorrect environment in process-compose, the problem should be solved externally, by providing the correct environment reproducibly and proactively.
Great tools for this purpose are Docker/Nix/Guix plus a bajillion other tools I am sure.
This way process-compose does not have to get bloated with a feature-set that does not really solve the problem.
Example:

what if the go binary is present on the PATH, but is actually not the proper version?
What if node was compiled with an older libv8 than needed?
What if the MacOS/Linux execution environment distinction is important for OS-specific feature reasons and require separate binaries?

Handling this with bespoke shell scripts gets tiring/error-prone really quick, and process-compose can only short-circuit a faulty start.
Even so a simple bash function can accomplish this today:
# put this into direnv/virtualenv/whatever
export PRJ_ROOT=$(pwd)
pcompose() { $PRJ_ROOT/bin/check.sh && process-compose "$@" }; }

$ pcompose completion --help
CHECK: All good!
Generate the autocompletion script for process-compose for the specified shell.
See each sub-command's help for details on how to use the generated script.

Leaving you with the option to easily opt-out of the check by just invoking process-compose directly.

Hi @thenonameguy,
I agree with your approach for a local, single developer environment. It is clear and keeps the process-compose lighter and its configuration simpler.
However, for the multi developers environment, you would want to share your compose.yaml file and expect it to function in a similar manner, even if they run it without the wrapper script.
This can be achieved by adding the relevant checks and dependencies to the processes execution chain and, if needed, termination of process-compose (new functionality).
Something similar to what I proposed to @IngwiePhoenix :
sanitycheck:
  command: "which go"
  availability:
    restart: "exit_on_failure" #new functionality

other_proc:
  command: ...
  depends_on:
    sanitycheck:
      condition: process_completed_successfuly

Hey @thenonameguy !

instead of trying to treat the symptoms of an incorrect environment in process-compose, the problem should be solved externally

Not wrong, I agree! It's an idea I had to bring down the external programms needed mainly. I go between platforms a lot; my laptop does not have WSL or Msys - only Docker. My Desktop has WSL with Nix and Docker and my server is a pure Debian box with only Docker, no Nix. So, for "between platform goers", it might be easier to have that feature, hence why I suggested it.
Hey @F1bonacc1 ! Just noticed you linked a PR and subsequent commits; I'll goa nd check out the new additions!
Sorry for my late response, got a little side-tracked IRL... :)

Hi @IngwiePhoenix,
I added the ability to exit if the process fails exit_on_failure. When this is configured, process-compose will exit with the same exit code as the failed process.
This functionality is part of v0.21.0 release.
Please let me know if it works as expected for you.

authors: F1bonacc1 IngwiePhoenix thenonameguy


text:
Creating wide-ip's with bigip monitor using AS3 declaration is throwing an error as 422 Unprocessable Entity

Environment
Application Services Version: v3.41.0
BIG-IP Version: 15.1.8
Summary
When sending AS3 declaration to create wideip using bigip monitor, declaration is failing with 422 Unprocessable Entity.
Error says declaration was well formed but unable to be followed due to semantics error.
Steps To Reproduce
Steps to reproduce the behavior:
{
"class": "AS3",
"declaration": {
"class": "ADC",
"schemaVersion": "3.34.0",
"constants": {
"class": "Constants",
"timestamp": "2023-07-19T06:14:27Z",
"version": "20230719.0.2"
},
"id": "partition-A",
"remark": "template:basic-wideip-20230118.2-main",
"partition-A": {
"class": "Tenant",
"app": {
"class": "Application",
"template": "generic",
"wideip.abc.com": {
"class": "GSLB_Domain",
"domainName": "wideip.abc.com",
"resourceRecordType": "A",
"pools": [
{
"use": "wideip.abc.com-wip-pool"
}
],
"remark": "20230719.0.2"
},
"wideip.abc.com-wip-pool": {
"class": "GSLB_Pool",
"members": [
{
"server": {
"bigip": "/Common/device_ltm1"
},
"virtualServer": "/Common/VS1",
"enabled": true
},
{
"server": {
"bigip": "/Common/device_ltm2"
},
"virtualServer": "/Common/VS2",
"enabled": true
}
],
"monitors": [
{
"bigip": "/Common/bigip"
}
],
"lbModePreferred": "round-robin",
"lbModeFallback": "none",
"resourceRecordType": "A",
"remark": "20230719.0.2"
}
}
}
}
}
Observe the following error response:

Expected Behavior
GTM should be deployed with 200 ok response.
Actual Behavior
getting error 422 Unprocessable Entity it says declaration was well formed but unable to be followed due to semantics error.

Can someone please take a look on this.

we no more have this issue, hence closing it.


text:
HTTP Application Template - set Ingress Topology to LAN fails

Environment

FAST RPM Version: 1.24
BIG-IP Version: 16.1.2.1

Summary
When using "HTTP Application Template" and selecting LAN as the Ingress Topology option and Deploy. Checking the application it has changed back to the default value WAN.
Checking the BIG-IP Local Traffic configuration at Virtual Servers it does have "f5-tcp-wan" configured.
Steps To Reproduce
List the steps to reproduce the behavior:

In the FAST GUI select "HTTP Application Template".
Enter the required values to be able to deploy the template.
Change the 'Ingress Toplogy' value from 'WAN' to 'LAN'.
Hit Deploy.
Once deployed, select the application and check the 'Ingress Topology' value.
Check the related VS client tcp profile.

You will notice that the selected LAN value is reverted back to WAN upon Deploying the template.
Expected Behavior
When selecting LAN as the Ingress Topology option one will expect 'f5-tcp-lan' configured as the client tcp profile in the virtual server and not 'f5-tcp-wan'.
Actual Behavior
When selecting LAN as the Ingress Topology value, the template will not configure this but configure the default value of WAN once the template gets deployed.

Thanks for submitting this issue. It's now being tracked internally with ID, EC-177.

Hello @gwolfis, this appears to be an AS3 bug, but you can work around it in one of two ways:

check the "Common TCP Profile" box, and then select LAN from the "Common Network Topology" list -- which will create a lan profile that is used on both Ingress and Egress
select something other than the default, LAN, for the "Egress Topology" when "Common TCP Profile" is unchecked

The AS3 bug occurs when you try to use the same value in the ingress as you do in the egress for the Service_HTTP_profileTCP object.

authors: gwolfis joelkeener shyawnkarim


text:
cloud docs URL to the schema for validation is wrong

Environment

Declarative Onboarding Version: 1.10.0-2
BIG-IP Version: 14.1.2-0.0.37.0

Summary
https://clouddocs.f5.com/products/extensions/f5-declarative-onboarding/latest/validate.html
says to add this to you declaration to validate it:
"$schema": "https://raw.githubusercontent.com/F5Networks/f5-declarative-onboarding/master/schema/latest/base.schema.json",

The source tree was refactored and the doc was not updated. Should read:
"$schema": "https://raw.githubusercontent.com/F5Networks/f5-declarative-onboarding/master/src/schema/latest/base.schema.json",

duplicate of https://github.com/F5Networks/f5-declarative-onboarding/issues/97

Closing as a duplicate.


text:
Install mods?!

Should it not have installed that mods for me?

the code for that exists but does not seem to work

Api call is wrong

repo: FAForever/downlords-faf-client


text:
Keypad is not work

Hi @FASTSHIFT ,
This is a amusing project.   i try build and run but the screen keypad seem not work.  how do fixed it?
my test environment is
No LSB modules are available.
Distributor ID:	Ubuntu
Description:	Ubuntu 20.04.5 LTS
Release:	20.04
Codename:	focal

gcc version:
gcc (Ubuntu 9.4.0-1ubuntu1~20.04.1) 9.4.0
Copyright (C) 2019 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

@kay54068
This is caused by the higher priority of SDL keyboard input. You can simply remove the gba_port_init() call in main.c first, and you can use the screen to simulate the keyboard. I'll refine the command line parser later so the user can choose the type of input.
If you want to use the keyboard to operate, refer to the following key table.
    static const SDL_Keycode key_map[] = {
      SDL_SCANCODE_X, /* GBA_JOYPAD_B */
      0, /* GBA_JOYPAD_Y */
      SDL_SCANCODE_BACKSPACE, /* GBA_JOYPAD_SELECT */
      SDL_SCANCODE_TAB, /* GBA_JOYPAD_START */
      SDL_SCANCODE_UP, /* GBA_JOYPAD_UP */
      SDL_SCANCODE_DOWN, /* GBA_JOYPAD_DOWN */
      SDL_SCANCODE_LEFT, /* GBA_JOYPAD_LEFT */
      SDL_SCANCODE_RIGHT, /* GBA_JOYPAD_RIGHT */
      SDL_SCANCODE_Z, /* GBA_JOYPAD_A */
      0, /* GBA_JOYPAD_X */
      SDL_SCANCODE_L, /* GBA_JOYPAD_L */
      SDL_SCANCODE_R, /* GBA_JOYPAD_R */
      0, /* GBA_JOYPAD_L2 */
      0, /* GBA_JOYPAD_R2 */
      0, /* GBA_JOYPAD_L3 */
      0 /* GBA_JOYPAD_R3 */
    };

If you want to modify the key, you can find it in gba_port_sdl2.c and modify it.

@FASTSHIFT
Got it.  i remark the gba_port_init callback in main.c the keypad can work.
Do you have plans to coexist with SDL keyboard and Keypad?

@FASTSHIFT
Got it. i remark the gba_port_init callback in main.c the keypad can work. Do you have plans to coexist with SDL keyboard and Keypad?

Supported in this commit.

@FASTSHIFT
it's work for me.
sdl2 and evdev can work together.
thanks.


text:
Special handling for CodeableReference type constraints

Fixes #220 and completes task CIMPL-1100.
CodeableReference elements have to be handled a bit carefully because they are sort of like Reference elements, but the FSH Reference keyword usually tries to make things a Reference type. This can lead to issues when a choice element has a CodeableReference type. Make separate rules for constraining the type to CodeableReference and for constraining the target profiles for CodeableReference.
When round-tripping the file in the issue, the only differences are in the ordering of properties. The starting and ending JSON are logically equal.
One thing I noticed that may or may not be in scope to do here is that OnlyRuleExtractor.process can't really handle a case where an element with type Reference or CodeableReference has both profile and targetProfile defined. As far as I know, nothing in the spec prohibits this, so that will need to be addressed.

This PR is on hold until there are some changes in SUSHI to support a CodeableReference keyword.

closed, there will be a new PR that uses the CodeableReference keyword.

repo: FHIR/GoFSH


text:
Limits report should be persisted

The limits report generated should be persisted on some storage like s3. Currently if the service is killed or shutdown, the data is lost.

The underlying data is fetched from AWS so upon restart of the service, fresh data can be fetched.  You will however lose the historical snapshot data so this can be persisted if stored in place such as S3.

repo: FINRAOS/aphelion


text:
3.0.1版本bcos尝试进行压力测试出现check failed

Describe the bug
我在尝试对本地搭建的区块链网络进行压力测试，但结果出现大量的check failed

To Reproduce
Steps to reproduce the behavior:

搭建第一个区块链网络按照这个教程至第四步结束，如果都做完也会有一样的效果。
压力测试指南按照这一教程至第三步，在第三步配置文件之前，先进入dist目录，不然压力测试启动会失败。
直接到最下方的压力测试，使用java -cp 'conf/:lib/:apps/' org.fisco.bcos.sdk.demo.perf.PerformanceDMC group 32 500000 20000命令启动一次测试。
测试结束后便会出现上方图片中的结果。

Expected behavior
这样的问题是正常的吗？
Environment (please complete the following information):

OS: [Ubuntu 20.04.1]
FISCO BCOS Version [3.0.1]
java sdk [openjdk 11.0.17]

可能交易池装不下了，有交易被丢弃，可以在配置文件里面把交易池改大再试试

repo: FISCO-BCOS/FISCO-BCOS


text:
拆解build_chain.sh解读FISCO-BCOS建链过程

这里是本教程的：配套视频
起链
我们在这里就不完整的去讲起链的方式，挑重点讲如果大家对起链感兴趣或者不熟悉，可以去看我的另一篇文章
【教程】完美的FISCO-BCOS区块链网络如何启动，单机四节点，联盟链
首先我会下载build_chain.sh脚本
使用建链命令进行建链（在这里使用一个节点目录方便教学）
bash build_chain.sh -l  127.0.0.1 -p 30300,20200,8545
我们可以先看一下窗口中返回的信息

第一段
[INFO] Downloading fisco-bcos binary from https://github.com/FISCO-BCOS/FISCO-BCOS/releases/download/v2.9.0/fisco-bcos.tar.gz ...
curl: (7) Failed to connect to github.com port 443: Connection refused
[INFO] Download speed is too low, try https://osp-1257653870.cos.ap-guangzhou.myqcloud.com/FISCO-BCOS/FISCO-BCOS/releases/v2.9.0/fisco-bcos.tar.gz
这里讲了我们去访问GitHub中下载FISCO-BCOS的压缩包，结果发现链接失败所以跳转到国内的码云中去下载
这里对应这我们build_chain.sh中的1633行

这里的cdn_download_link在上面环境变量中有指定
在下面有许多的判断就是为了预防在国内无法访问GitHub的情况发生
第二段
============================================================== Generating CA key... ==============================================================
生成CA秘钥对应脚本1677行，在脚本内的运行流程就是找到${output_dir}下的cert目录将CA证书存放进去，${output_dir}在上面定义的是nodes目录，所以我们进入后就可以看见我们的CA证书，具体CA证书的生成会有专栏来讲解。

第三段
==============================================================
 Generating keys and certificates ...
 Processing IP=127.0.0.1 Total=1 Agency=agency Groups=1
==============================================================`
生成秘钥和证书对应在脚本的1793行，脚本内的运行流程就是在输入起链命令后将他们赋给变量$OPTARG接收，确定起链模式，节点数量，确定IP，群组等参数，开始创建节点目录节点目录由node_count来确定这个node_count就是我们在起链时输入的节点数量我们是默认单节点，所以建起来的目录就是一个目录

第四段
==============================================================
Generating configuration files ...
Processing IP=127.0.0.1 Total=1 Agency=agency Groups=1
==============================================================
生成配置文件对应在脚本的1925行，脚本内的运行流程就是先确定证书的输出目录的位置，用node_count和node_dir进行接收之后就将生成的证书发送到目录下，生成的证书有群组证书，group.X.genesis、group.x.ini、config.ini、和agency目录
第五段
==============================================================
 [INFO] Start Port      : 30300 20200 8545
[INFO] Server IP       : 127.0.0.1
[INFO] Output Dir      : /home/fisco223/fisco/nodes
[INFO] CA Path         : /home/fisco223/fisco/nodes/cert/
[INFO] RSA channel     : true
==============================================================
这里是将所有的端口和服务以及最终的工作目录反馈给使用者，用于自身确定是否达到预期以及预防工作量过大后配置文件等找不到的情况，对应脚本226行

第六段
 ==============================================================
[INFO] Execute the download_console.sh script in directory named by IP to get FISCO-BCOS console. e.g.  bash /home/fisco223/fisco/nodes/127.0.0.1/download_console.sh -f
 ==============================================================
 [INFO] All completed. Files in /home/fisco223/fisco/nodes
这里就是提醒使用者在IP命名的目录中使用sh脚本获取FISCO-BCOS控制台。并且举了个例子e.g.讲解了用法，最终提示用户所有的流程已经结束，搭建完成工作目录在${output_dir}下。

LGTM 👍


text:
v4 and migration to Cypress 13

Hello again everyone! 👋
Sorry for being away for a while - I had simply not time to keep the library in a shape that I'd like it to be. My apologies!
As a part of repo cleaning up process, I'd started migration to Cypress 13. But because it's a release that drops support for Node@12 (so introducing a breaking change) - we need to raise the major number of this library as well.
To do a proper "major" release I've figure it'll be a good time to take care of some long-staging issues & PRs before releasing v4. I'll try to handle them in upcoming days, so bear with me for little more time! All changes will land firstly to the branch feat/release-4.0.0 - you can keep track of code changes there.
List of PRs/issues/discussions that need to be handled before v4 release:

[x] Upgrade to Cypress 13
[x] Upgrade to Vitest 2
[x] Upgrade CI Scripts to newest version
[x] Upgrade Sharp to 0.33.5 (https://github.com/FRSOURCE/cypress-plugin-visual-regression-diff/pull/256)
[x] Upgrade Node version used in the repo to 20
[ ] https://github.com/FRSOURCE/cypress-plugin-visual-regression-diff/pull/179
[ ] https://github.com/FRSOURCE/cypress-plugin-visual-regression-diff/pull/181 (https://github.com/FRSOURCE/cypress-plugin-visual-regression-diff/issues/178)
[ ] https://github.com/FRSOURCE/cypress-plugin-visual-regression-diff/pull/199 (https://github.com/FRSOURCE/cypress-plugin-visual-regression-diff/issues/196)
[ ] https://github.com/FRSOURCE/cypress-plugin-visual-regression-diff/issues/106
[ ] https://github.com/FRSOURCE/cypress-plugin-visual-regression-diff/issues/204
[ ] https://github.com/FRSOURCE/cypress-plugin-visual-regression-diff/issues/258
[ ] https://github.com/FRSOURCE/cypress-plugin-visual-regression-diff/issues/259
[ ] https://github.com/FRSOURCE/cypress-plugin-visual-regression-diff/issues/282
[ ] https://github.com/FRSOURCE/cypress-plugin-visual-regression-diff/issues/294
[ ] https://github.com/FRSOURCE/cypress-plugin-visual-regression-diff/issues/302
[ ] https://github.com/FRSOURCE/cypress-plugin-visual-regression-diff/issues/314
[ ] https://github.com/FRSOURCE/cypress-plugin-visual-regression-diff/discussions/96
[ ] https://github.com/FRSOURCE/cypress-plugin-visual-regression-diff/discussions/189
[ ] https://github.com/FRSOURCE/cypress-plugin-visual-regression-diff/discussions/226
[ ] https://github.com/FRSOURCE/cypress-plugin-visual-regression-diff/discussions/214
[ ] https://github.com/FRSOURCE/cypress-plugin-visual-regression-diff/discussions/309

List of postponed issues

[ ] https://github.com/FRSOURCE/cypress-plugin-visual-regression-diff/issues/212 - this should be resolved by OOT solution for whole process - e.g. github action or working script. Community support welcome! Relates to https://github.com/FRSOURCE/cypress-plugin-visual-regression-diff/discussions/159

could you please do a patch release for v3 in the meantime?
3.3.10 has sharp version pinned which has a known CVE.
in your repo the bots already took care of the update.
npm audits solution would be to downgrade your plugin...
git:(main) ✗ npm audit
# npm audit report

sharp  <0.32.6
Severity: high
sharp vulnerability in libwebp dependency CVE-2023-4863 - https://github.com/advisories/GHSA-54xq-cgqr-rpm3
fix available via `npm audit fix --force`
Will install @frsource/cypress-plugin-visual-regression-diff@1.4.0, which is a breaking change
node_modules/sharp
  @frsource/cypress-plugin-visual-regression-diff  >=1.5.0
  Depends on vulnerable versions of sharp
  node_modules/@frsource/cypress-plugin-visual-regression-diff

2 high severity vulnerabilities

To address all issues (including breaking changes), run:
  npm audit fix --force

authors: FRSgit geroyche


text:
#24: Modal popup - focus on first input field

done by creating a custom attribute directive that runs a conditional focus

Thanks for the contribution, @pliguori. Is it still possible to tab through the fields? Is there a way to solve this more elegant with HTML5?

@FRosner what do you actually mean with "more elegant with HTML5"? If you create the popup via angularjs, you need to manage its behavior via angularjs, else it could become unpredictable.
And of course you can tab through the fields, that's normal behavior based on the DOM (TAB goes to the next enabled input field in the hierarchy)

authors: FRosner pliguori

repo: FRosner/cluster-broccoli

license_source: bigquery


text:
Syntax error due to parenthesis.

Hello,
I think I found a small bug into the parser. The following code raises a syntax error.
module Helios

val length : list 'a -> Tot nat
let rec length l = match l with
  | [] -> 0
  | hd::tl -> 1 + length tl

val lem_len_nil: unit -> Lemma (length [] = 0)
let lem_len_nil () = ()

val lem_len_cons: hd:'a -> (tl:list 'a) -> Lemma (length (hd::tl) = (length tl) + 1)
let lem_len_cons hd tl = ()

When I replace the line
val lem_len_cons: (hd:'a) -> (tl:list 'a) -> Lemma (length (hd::tl) = (length tl) + 1)

by
val lem_len_cons: hd:'a -> tl:list 'a -> Lemma (length (hd::tl) = (length tl) + 1)

it works well.
Best regards,
Vincent Cheval

I agree with Nik, it's commonplace that parentheses delimit binding scopes. For instance \x. x x is different than (\x. x) x.

I might be backtracking on this one ...
This discrepancy between the syntax of binders in type and let definitions and the binders in arrow types is annoying.

Not sure about how best to resolve this. We have some conflicting requirements.

We like the x:t -> t' syntax, particularly when it is used as x:t{phi} -> t'.

As such, this type is currently accepted: a:Type -> (x:a -> int) -> int, where the second argument is an unnamed function, with a named argument.

But, this syntax is rejected: let f (a:Type) (x:a -> int) = 0 ... the second argument is an unnamed function ... and in a let binding, all the parameters have to be named. For the record, the same comment applies to type f (a:Type) (x:a -> int) = int

How can we resolve this? Suggestions most welcome.

argh. this is screwed up ... please hold off on comments until I fix my last comment

Let me try again (working through this with Jonathan) (It's a bad sign that I am so confused about the syntax myself : )
This parses:
let f (x:int) (y:int -> int) = y

But, this doesn't:
type g = (x:int) -> (y:int -> int) -> int

The failure is in the parsing of (x:int): The grammar attempts to parse this as an atomic type (delimited by the parens), then expects to parse a refinement type because of the binder x:int and then fails because there is no following refinement. The variant below parses:
type h = (x:int{x > 0}) -> (y:int -> int) -> int

As does this variant:
type g' = x:int -> (y:int -> int) -> int

However, it parses with different scoping rules. So, this version parses but fails to type-check (actually, fails during name-binding while desugaring). Specifically, the y names only the argument int not the entire function.
assume type vector : int -> Type
type g'' = x:int -> (y:int -> int) -> vector (y 0)

This is consistent with g' and h ... but different than f. Perhaps that's ok ... perhaps not.

Again, with Jonathan:
FYI: A further inconsistency was that the parsing of the parameters of let-bindings and the parameters in type definitions was different. This did not parse until my most recent commit 068990c5d8581effb7a51cd200c4f146319eeaba
type ff (x:int) (y:int -> Tot int) = vector (y 0)

However, it does parse and type-check now.
So does this:
type ff (x:int) (y:(int -> Tot int)) = vector (y 0)

So, what are our options:

We live with the difference between the syntax of arrows and of let/type definitions. This could be mitigated with some tricks (see below).

We insist on parenthesis in the binders even in arrow types. So, you would have to write (x:int{x > 0}) -> vector x. This would also require a change in binding rules for arrow types, where even though it is delimited by parens, the scope of x would span over both the refinement and the RHS of the arrow. The upside is that let/type becomes consistent with arrow. The downside is that we need to write more parens in arrow types ... which is burdensome.

I don't have any opinion one way or the other, but let me try to cheer you up: https://xkcd.com/297/

Resolving this mess in a465a241a90e064faa347f9deacde8eec12a1c70

Here's what the parser accepts now:
module Test
assume type tint : int -> Type

type t1 = x:int{x >= 0} -> tint x
type t2 = x:int -> res:tint x
type t3 = (a:Type) -> (x:int) -> result:list a{result=[] /\ x=18}
type t4 = x:nat & y:nat{y > x}
type t4' = (x:nat) & y:nat{y > x}
type t4'' = (x:nat) & (y:nat{y > x}) //parentheses are not significant
type t5 = x:int{x=0} * y:int
//type t5' = x:int{x=0} * tint x
//parses but fails name-binding; x is not in scope in the 2nd component
type t6 = (int * int) -> int
type t7 = int * int -> int

type t8 = x:int * int -> int
//type t8' = x:int * int -> tint x //x is not in scope to the right of the arrow
type t8' = x:(int * int) -> tint (fst x)

type t9 = x:int & tint x -> int
type t9' = y:(x:int & tint x) -> tint (dfst y)

type ta = (x:int) -> (y:int -> tint y) -> tint x
type tb = x:int -> (y:int -> tint y) -> tint x
type tc = x:int -> f:(y:int -> Tot int) -> tint (f 0)

let f1 (x: y:int &  z:tint y{z=z /\ y=0}) = x
let f2 (x: y:int *  z:tint 0{z=z}) = x
let f3 (x: y:int -> z:tint y{z=z /\ y=0}) = x
let f4 (#a:Type) (l:list a) (#x:int) (v:tint x) = l
let f5 (l:list int) (v:tint 0) = f4 l v

type s0 (x:int) (y:int -> Tot int) = tint (y 0)
type s1 (x: y:int &  z:tint y{z=z /\ y=0}) = tint (dfst x)
type s2 (x: y:int *  z:tint 0{z=z}) = tint (fst x)
type s3 (x: y:int -> z:tint y{z=z /\ y=0}) = tint ((fun x -> 0) x)

The main takeaway point is that the discrepancy between the syntax of arrows and type/let-bindings has been resolved.
There is, however, a difference in the scoping rules for those constructs, particular at higher order.
Specifically:
In the arrow type below, x names the formal parameter of the unnamed function-typed argument. It is in scope in t1 but not in t2.
 (x:t0 -> t1) -> t2

As an aside, the same rule applies to the &` constructor, for dependent tuples.
In a let-binding, type-definition, or quantifier, each argument carries a mandatory name. So, the only way to parse
type (x:t0 -> t1) = t2

is for x to name the function t0 -> t1 and for x to be in scope in t2.
For first-order types, this distinction is irrelevant. For example, in both cases below, x names the argument t0 and is in scope in t1
(x:t0) -> t1
type t (x:t0) = t1

authors: VincentCheval catalin-hritcu nikswamy

repo: FStarLang/FStar


text:
Migrating to RoadRunner 1.0

Before issuing a pull request, please see the contributing page.

Trying again with a new PR


text:
investigate record inner classes

see e87bc5c63ab41194defacfbe0451dd2cc522a55a. dunno if it's the InnerClasses attributes or if something is accidentally leaked elsewhere.

15aeb4c52b3de1ab5610a98ee7d5992d248605ae

repo: FabricMC/MappingPoet


text:
Split into fabric-loader and fabric-base

fabric-loader should rely solely on launchwrapper and the mixin library as to be includeable in Weave and versioned outside of Minecraft itself; fabric-base should depend on it and provide "essential" Minecraft-related functionality (kicking players on fatal mod list mismatches, for example).

Why would loader need to be included in Weave, or anything outside of -base itself? Maybe if it was a general loading system, but it's not, it's very closely tied to Fabric's model of how mods work.

Actually, that was changed. It was needed for the mixin applier, as it also
has to load mods, but I just integrated the mixin applier into -base.
The idea was to be able to fix bugs/add improvements to the Loader separate
from the Minecraft-specific support code.
2016-10-04 18:19 GMT+02:00 Shadowfacts notifications@github.com:

Why would loader need to be included in Weave, or anything outside of
-base itself? Maybe if it was a general loading system, but it's not, it's
very closely tied to Fabric's model of how mods work.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/FabricMC/fabric-base/issues/21#issuecomment-251437481,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAG7ag5ULLemMDMKTqv_RvWIvbEClBWeks5qwnyggaJpZM4KNprI
.

So does base depend on loader?

Base would just be another module, with a few special privileges if needed.

This is effectively happening, with dynamic class resolution (thanks to FyberOptic's idea) being used for the few things which do require a "-base" module. Therefore, -loader and -base will still be one thing, just relatively Minecraft-independent.

authors: asiekierka liach shadowfacts

repo: FabricMC/fabric-base


text:
Sodium and Create[fabric] is incompatible

Describe the Bug
The Fabric loader showed that Create was incompatible to Sodium (0.5.3)
Reproduction Steps

Have Sodium (0.5.3) installed on a Fabric loader of Minecraft (1.20.1).
Have Create (0.5.1-d) installed.
Load the game.

Expected Result
Sodium and Create are the newest versions are and the other mods I are as well. I thought it would have worked, but at last it did not.
Screenshots and Videos
No response
Crash Report or Log
No response
Operating System
Windows 11
Mod Version
0.5.1d
Minecraft Version
1.20.1
Other Mods
additional redstone
alloy-forgery
alternate-current
amthyst-update
appleskin
architectuy api
attracion
badpackets
bedshreads
better combat
better F3
bushier flowers
chisel reborn
cloth-config
collective
comforts
continuity
copper horns
customizable elytra
dummmmmmy
eating animations
elytra slot
emi
emi effect
Enchanting Infuser
enchant tweaker
fabric api
fabric language kotlin
footprint particle
forbidden Potions
forge config api port
gecko lib
grappelhook
hangglider
immersive melodies
immersive portals
incantationem
Idium
iris
just mob heads
lamb dynamic lights
lazydfu
lithium
magic sorting system
mod menu
moonlight lib
more banner features
more bows
mystic potions
mythic metals
origins
owo lib
Pehkui
player animation
polymorph
portal gun
puzzel lib
realistic sleep
redstone bits
redstone pen
reeses sodium options
reimagined trims
reinfored chests , barrel, shulker boxes
simple copper horns
simply swords
sodium extra
Sodium (the problem)
sound physics
supplementaries
tool tip fix
trinkets
uncrafables
vanilla refresh
voice chat
color me outlines
wthit (what the hell is that)
yet another config lib
Zoomify
[All the mods above are the newest version]
Additional Context
No response

#1039

authors: SCP-lover TropheusJ

repo: Fabricators-of-Create/Create


text:
[Passive] CORN COB

Chance to spawn friendly dip when special tear hits.
Code: WIP
Art: Complete

Animation: Tear Animation Needed

 CORN SHOT: Chance to spawn a friendly dip on special tear hit

Item renamed to Corn Cob

authors: FacemanFoothand jtmcginnis

license: mit


text:
color attribute for FloatingActionButton conflicts with an attribute defined in android.support.v7.appcompat

I suggest renaming color to colorBackground.

Just rename the color attribute to whatever else, alse make sure to rename the FloatingActionButton_color in FloatingActionButton class. That was my solution.

That fixes the problem. You might want to consider changing it in the
future.
On Jan 14, 2015 12:11 PM, "Aimen7" notifications@github.com wrote:

Just rename the color attribute to whatever else, alse make sure to rename
the FloatingActionButton_color in FloatingActionButton class. That was my
solution.
—
Reply to this email directly or view it on GitHub
https://github.com/FaizMalkani/FloatingActionButton/issues/26#issuecomment-69951999
.

Agreed with bvr, every other person using the library shouldn't have to always change it in their own copy. FAB as a library right now doesn't play nice with the compatibility lib.

repo: FaizMalkani/FloatingActionButton


text:
No description of image

No description of image, should add it.

Have added  description of image


text:
Dev.jb.readme

updated readme

Resolved conflict, always remember to pull down a fresh copy.

repo: Fanshawe-JB/myFirstRepo


text:
New vector API + Functional environments + (vector) wrappers

Opening this PR to track the progress of the entire project.
This will be merged when the following features are ready, since they interact with each other strongly:

New vector API (supporting custom vectorization and soon maybe envpool) (mostly done - #93)
Functional API as a backend for hardware-accelerated envs (mostly done - #25)
Implementations of (some) hardware-accelerated envs
Wrappers done in such a way to properly work with individual and vector envs (most likely separately)

For people involved in this PR (or working on adjacent things) - I just resolved the merge conflicts that github was detecting, but this will need to be manually updated to follow the new plan of firstly merging the changes into the experimental directory. I'll try to do this and bring this branch back into a working state soon so that it's not necessary to copy-paste all the new code into a new PR

The branch is now stable for new contributions. The plan is to keep features related to vector API and functional environments containted to this branch, and then we will merge it to main when the time comes.

@RedTachyon we briefly discuss this in the past, can we call reset() in Vec envs at the beginning of step if the episode ended in the previous step, instead of calling it immediately?

@younik Within my rewrite of the sync vector env, this is how I have implemented the step function if I understand you correctly

@younik Within my rewrite of the sync vector env (#196), this is how I have implemented the step function if I understand you correctly

Yes, exactly, thank you!

@younik I have a longer discussion on the idea in https://github.com/Farama-Foundation/Gymnasium/issues/32#issuecomment-1365493442

@RedTachyon With v0.27.1 released and I don't have plans for another release, would you like to merge this PR such that experimental work can happen on main or would you like it to continue on this branch?

@pseudo-rnd-thoughts I addressed the comments, reverted the autoreset order change as discussed, and resolved merge conflicts, so it should be ready for final review and hopefully merge

authors: RedTachyon pseudo-rnd-thoughts younik

repo: Farama-Foundation/Gymnasium


text:
Change package name

Change to a package name that I own: com.satsuware (as opposed to com.farbod.)
This is similar to an issue my other library.

I forgot to mention in the commit description...
Well, this has been closed by commit 2bd74ef.

repo: FarbodSalamat-Zadeh/MaterialDesignUtils


text:
Link out to docs for filterReverseGeocodingByTypes

closes https://github.com/FaridSafi/react-native-google-places-autocomplete/issues/428

Thanks!


text:
Add: calculate and print code

#1
@brekJ @misolove
세 번째 파트: 성공률 계산 및 출력 구현하였습니다.

잘 하셨어요. 확인했습니다.

authors: alwaysblu brekJ


text:
Error

Domain
https://oko.sh
Link
https://oko.sh/NaufragoHD1080p
Version
Versión 0.2279-Mv3
What browsers are you seeing the problem on?
Microsoft Edge
What OS are you seeing the problem on?
Windows
Anything else?

There is no error. You need to manually bypass this website, so others can bypass it too (as read on the pop-up). This happens because the website uses crowdbypass.
Also is this really FastForward?

authors: FerGarrix princessmortix

repo: FastForwardTeam/FastForward


text:
Random webpage opening

Body
Around 20% of the time when I close edge the page to edit settings for the extension pops up. Very annoying
Version
0.2279-Mv3
What browsers are you seeing the problem on?
Microsoft Edge
What OS are you seeing the problem on?
Windows
Anything else?

It's probably related to this https://github.com/FastForwardTeam/FastForward/pull/921/files#diff-25daee2bd4a749c171c5bd0b87567f3fe306a1fdacb2a6d6785a3e1e6fd065f9R15
I'll investigate

Yeah, it's really annoying that it happens every time. Not only that page but for me, it's also opening the "Welcome" and "Thanks for installing" page whenever I open Edge.

Just thought I'd add, the same thing happens on Chrome as well.

fixed by https://github.com/FastForwardTeam/FastForward/commit/03ffd999705f477e3296749878d17731746c792e

authors: DSGriff NotAProton rlnt streetlegithub


text:
Add manual upload feature

@lopezac aca intento atacar el problema de #82, ya que no parece que ofertahoraria va a actualizarse.
Mi idea es que uno pueda ir al SIU y traerse todos sus datos, y usar eso en vez de los jsons del fiuba plan (no usarlos a la par. usar o uno o el otro).
Todavia falta la mayoria de la logica, pero si me queres ir contando que te parece o incluso agregando codigo o ideas en alguna branch aparte que se ponga arriba de este PR, genial. (El frontend no es definitivo, si no te gusta algo chifla!)

Espectacular la idea Fede!

@lopezac termine el parser. queres probarlo? tenes que correr el repo local, y seguir las instrucciones. con mi SIU anda sin problemas, pero tengo miedo de que con el SIU de otra persona rompa. Gracias!

Mergeo y confio

authors: FdelMazo lopezac

repo: FdelMazo/FIUBA-Plan


text:
⚠ Thumbnails API Endpoint has degraded performance

In 1d2ef10, Thumbnails API Endpoint (https://thumbnails.roblox.com/v1/assets?assetIds=82738847&format=Png&isCircular=false&size=30x30) experienced degraded performance:

HTTP code: 200
Response time: 5180 ms

Resolved: Thumbnails API Endpoint performance has improved in 5842353 after 3 minutes.

repo: FearedFusionX/Ro-Status


text:
🛑 Voice Chat API is down

In ed955e0, Voice Chat API (https://voice.roblox.com/) was down:

HTTP code: 404
Response time: 94 ms

Resolved: Voice Chat API is back up in 4b49a88 after 50 minutes.


text:
Add package to pypi

Even its just an alpha/beta please add this package to https://pypi.org/ in order to easy up the installation process.

Yeah, I had the same idea some time ago which is why I created a pypi package already. As I had the feeling that the experiment might be successful I published it under the mjml name (not "-stub").  😀

Yeah, I had the same idea some time ago which is why I created a pypi package already. As I had the feeling that the experiment might be successful I published it under the mjml name (not "-stub").  😀

authors: FelixSchwarz barsch

repo: FelixSchwarz/mjml-stub


text:
Coveralls

Need to have coveralls operate outside of Travis-CI

Closing due to bandwidth and minimal expected value

repo: FenrirUnbound/flipit


text:
Update getting started section

Maybe not the final version but good starting point to iterate through reviews.

We need to improve the way we present the information.
Instead of reciting the exact code that the user can read through we need to give them more information about the code, what it's there for and how it relates to what they're trying to do.

Thanks for the review, appreciated. I will take this into account for now on.

I've included the getting started updates in my latest docs improvements.

authors: FilledStacks ferrarafer

repo: FilledStacks/stacked-docs


text:
only consider full import path

prior to this change gvt update -all would fail with "subpackages of this dependency are already present" for "github.com/dgryski/go-bits" against "github.com/dgryski/go-bitstream"

Thanks!

authors: FiloSottile casualjim

repo: FiloSottile/gvt


text:
Add more CJK characters

All characters have been textured from 0x4e00 to 0x4f55. Then I realized that I should do more common characters before ones that aren't even used anymore and hence from 0x4f56 to 0x5100 only common characters in CHINESE are textured. I might have missed some common characters while looking through the Unicode charts.
Also, the characters I textured are common in Mandarin Chinese, and may not be common in Japanese, which use Chinese characters.

Thank you very much, merging now!

repo: FinalForEach/Cosmic-Reach-Localization


text:
[Mod Compatibility] Control It! vs. Hide It, Bobby!

Note: I haven't had time to test, just flagging this up as it will need testing, if someone has time...

First mod
Control It! by Keallu
Other mod
Hide It, Bobby! by User
Compatibility
Both mods have options to hide panels on main menu screen, and thus will potentially conflict or cause weird issues.

Same Functionality - the mods provide the same functionality / change the same thing, making them incompatible.

Same Functionality, but compatible - the mods provide the same functionality, but are still compatible.

Specific Settings - using both mods together requires specific settings for one or both mods (please describe below).

Based on how the mods work, so long as the user only hides/alters panels via one of the mods, they should potentially be compatible. No idea what happens if both mods try to update the same panels.

I've asked Keallu about compatibility and will await their answer.

This will be updated in catalog 4.60.

repo: Finwickle/CompatibilityReport


text:
quest 2 avatar stats settings dont show up

main UserData folder does not contain a AvatarStats folder either

its most likely a lemon loader issue

what the buggy code outputs

what the melonloader code does
(BaseDirectory is GameDirectory which is string.Copy(internal method called GetGameDirectory))

did you save any avatar stats?

yes but all of the settings get stored in the root folder

pushed a new update, version 1.2.2. try it out when it goes live. Might not do anything, all I did was swap from using string concatenation to Path.Combine which should at least fix using the wrong path separator.

you forgot to update the file saving
and yes the folder now is located in userdata

Fixed it, version 1.2.3 is now uploaded to thunderstore but will take an unknown amount of time to be visible

repo: FirEmerald/AvatarStatsLoader