text:
Part 3 of generator: add back MCP functionality and GRPC

This introduces 2 Generators:

'api' will return the Istio APIs, using the MCP resource and code. This is currently using XDS
protocol for transport - as agreed we removed duplicated code and functionality, but we want
to preserve the ability to return Istio APIs. This is not a new functionality - but replaces the service
proto from MCP to XDS ( and in future it'll work with minimal changes with UDPA)

'grpc' generator supports current GRPC clients that use XDS for load balancing. The current
release of GRPC has subtle differences - requiring us to have a generator for RDS and CDS -
but those can be fixed in GRPC ( and there is work in progress). The LDS generation is different.
This is targeted to people testing and developing the new 'native istio support' in grpc libraries.

The Generator interface is changed to also support passing the list of updates. This will
allow EDS to be implemented using same Generator interface.
The selection of a generator can now be overriden per resource.
General context: PR#22897

@costinm: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
77d0ab3d50c245a7753f22d02cb09baf0248186d
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
77d0ab3d50c245a7753f22d02cb09baf0248186d
link
/test unit-tests_istio

integ-local-tests_istio
77d0ab3d50c245a7753f22d02cb09baf0248186d
link
/test integ-local-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
77d0ab3d50c245a7753f22d02cb09baf0248186d
link
/test unit-tests_istio

integ-local-tests_istio
77d0ab3d50c245a7753f22d02cb09baf0248186d
link
/test integ-local-tests_istio

release-test_istio
77d0ab3d50c245a7753f22d02cb09baf0248186d
link
/test release-test_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
77d0ab3d50c245a7753f22d02cb09baf0248186d
link
/test unit-tests_istio

integ-local-tests_istio
77d0ab3d50c245a7753f22d02cb09baf0248186d
link
/test integ-local-tests_istio

release-test_istio
77d0ab3d50c245a7753f22d02cb09baf0248186d
link
/test release-test_istio

update-ref-docs-dry-run_istio
77d0ab3d50c245a7753f22d02cb09baf0248186d
link
/test update-ref-docs-dry-run_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
77d0ab3d50c245a7753f22d02cb09baf0248186d
link
/test unit-tests_istio

integ-local-tests_istio
77d0ab3d50c245a7753f22d02cb09baf0248186d
link
/test integ-local-tests_istio

release-test_istio
77d0ab3d50c245a7753f22d02cb09baf0248186d
link
/test release-test_istio

update-ref-docs-dry-run_istio
77d0ab3d50c245a7753f22d02cb09baf0248186d
link
/test update-ref-docs-dry-run_istio

lint_istio
77d0ab3d50c245a7753f22d02cb09baf0248186d
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
77d0ab3d50c245a7753f22d02cb09baf0248186d
link
/test unit-tests_istio

integ-local-tests_istio
77d0ab3d50c245a7753f22d02cb09baf0248186d
link
/test integ-local-tests_istio

release-test_istio
77d0ab3d50c245a7753f22d02cb09baf0248186d
link
/test release-test_istio

update-ref-docs-dry-run_istio
77d0ab3d50c245a7753f22d02cb09baf0248186d
link
/test update-ref-docs-dry-run_istio

lint_istio
77d0ab3d50c245a7753f22d02cb09baf0248186d
link
/test lint_istio

integ-mixer-k8s-tests_istio
77d0ab3d50c245a7753f22d02cb09baf0248186d
link
/test integ-mixer-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
77d0ab3d50c245a7753f22d02cb09baf0248186d
link
/test unit-tests_istio

integ-local-tests_istio
77d0ab3d50c245a7753f22d02cb09baf0248186d
link
/test integ-local-tests_istio

release-test_istio
77d0ab3d50c245a7753f22d02cb09baf0248186d
link
/test release-test_istio

update-ref-docs-dry-run_istio
77d0ab3d50c245a7753f22d02cb09baf0248186d
link
/test update-ref-docs-dry-run_istio

lint_istio
77d0ab3d50c245a7753f22d02cb09baf0248186d
link
/test lint_istio

integ-mixer-k8s-tests_istio
77d0ab3d50c245a7753f22d02cb09baf0248186d
link
/test integ-mixer-k8s-tests_istio

integ-pilot-k8s-tests_istio
77d0ab3d50c245a7753f22d02cb09baf0248186d
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
77d0ab3d50c245a7753f22d02cb09baf0248186d
link
/test unit-tests_istio

integ-local-tests_istio
77d0ab3d50c245a7753f22d02cb09baf0248186d
link
/test integ-local-tests_istio

release-test_istio
77d0ab3d50c245a7753f22d02cb09baf0248186d
link
/test release-test_istio

update-ref-docs-dry-run_istio
77d0ab3d50c245a7753f22d02cb09baf0248186d
link
/test update-ref-docs-dry-run_istio

lint_istio
77d0ab3d50c245a7753f22d02cb09baf0248186d
link
/test lint_istio

integ-mixer-k8s-tests_istio
77d0ab3d50c245a7753f22d02cb09baf0248186d
link
/test integ-mixer-k8s-tests_istio

integ-pilot-k8s-tests_istio
77d0ab3d50c245a7753f22d02cb09baf0248186d
link
/test integ-pilot-k8s-tests_istio

integ-distroless-k8s-tests_istio
77d0ab3d50c245a7753f22d02cb09baf0248186d
link
/test integ-distroless-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
77d0ab3d50c245a7753f22d02cb09baf0248186d
link
/test unit-tests_istio

integ-local-tests_istio
77d0ab3d50c245a7753f22d02cb09baf0248186d
link
/test integ-local-tests_istio

release-test_istio
77d0ab3d50c245a7753f22d02cb09baf0248186d
link
/test release-test_istio

update-ref-docs-dry-run_istio
77d0ab3d50c245a7753f22d02cb09baf0248186d
link
/test update-ref-docs-dry-run_istio

lint_istio
77d0ab3d50c245a7753f22d02cb09baf0248186d
link
/test lint_istio

integ-mixer-k8s-tests_istio
77d0ab3d50c245a7753f22d02cb09baf0248186d
link
/test integ-mixer-k8s-tests_istio

integ-pilot-k8s-tests_istio
77d0ab3d50c245a7753f22d02cb09baf0248186d
link
/test integ-pilot-k8s-tests_istio

integ-distroless-k8s-tests_istio
77d0ab3d50c245a7753f22d02cb09baf0248186d
link
/test integ-distroless-k8s-tests_istio

integ-galley-k8s-tests_istio
77d0ab3d50c245a7753f22d02cb09baf0248186d
link
/test integ-galley-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
77d0ab3d50c245a7753f22d02cb09baf0248186d
link
/test unit-tests_istio

integ-local-tests_istio
77d0ab3d50c245a7753f22d02cb09baf0248186d
link
/test integ-local-tests_istio

release-test_istio
77d0ab3d50c245a7753f22d02cb09baf0248186d
link
/test release-test_istio

update-ref-docs-dry-run_istio
77d0ab3d50c245a7753f22d02cb09baf0248186d
link
/test update-ref-docs-dry-run_istio

lint_istio
77d0ab3d50c245a7753f22d02cb09baf0248186d
link
/test lint_istio

integ-mixer-k8s-tests_istio
77d0ab3d50c245a7753f22d02cb09baf0248186d
link
/test integ-mixer-k8s-tests_istio

integ-pilot-k8s-tests_istio
77d0ab3d50c245a7753f22d02cb09baf0248186d
link
/test integ-pilot-k8s-tests_istio

integ-distroless-k8s-tests_istio
77d0ab3d50c245a7753f22d02cb09baf0248186d
link
/test integ-distroless-k8s-tests_istio

integ-galley-k8s-tests_istio
77d0ab3d50c245a7753f22d02cb09baf0248186d
link
/test integ-galley-k8s-tests_istio

integ-security-k8s-tests_istio
77d0ab3d50c245a7753f22d02cb09baf0248186d
link
/test integ-security-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
77d0ab3d50c245a7753f22d02cb09baf0248186d
link
/test unit-tests_istio

integ-local-tests_istio
77d0ab3d50c245a7753f22d02cb09baf0248186d
link
/test integ-local-tests_istio

release-test_istio
77d0ab3d50c245a7753f22d02cb09baf0248186d
link
/test release-test_istio

update-ref-docs-dry-run_istio
77d0ab3d50c245a7753f22d02cb09baf0248186d
link
/test update-ref-docs-dry-run_istio

lint_istio
77d0ab3d50c245a7753f22d02cb09baf0248186d
link
/test lint_istio

integ-mixer-k8s-tests_istio
77d0ab3d50c245a7753f22d02cb09baf0248186d
link
/test integ-mixer-k8s-tests_istio

integ-pilot-k8s-tests_istio
77d0ab3d50c245a7753f22d02cb09baf0248186d
link
/test integ-pilot-k8s-tests_istio

integ-distroless-k8s-tests_istio
77d0ab3d50c245a7753f22d02cb09baf0248186d
link
/test integ-distroless-k8s-tests_istio

integ-galley-k8s-tests_istio
77d0ab3d50c245a7753f22d02cb09baf0248186d
link
/test integ-galley-k8s-tests_istio

integ-security-k8s-tests_istio
77d0ab3d50c245a7753f22d02cb09baf0248186d
link
/test integ-security-k8s-tests_istio

integ-telemetry-k8s-tests_istio
77d0ab3d50c245a7753f22d02cb09baf0248186d
link
/test integ-telemetry-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
77d0ab3d50c245a7753f22d02cb09baf0248186d
link
/test unit-tests_istio

integ-local-tests_istio
77d0ab3d50c245a7753f22d02cb09baf0248186d
link
/test integ-local-tests_istio

release-test_istio
77d0ab3d50c245a7753f22d02cb09baf0248186d
link
/test release-test_istio

update-ref-docs-dry-run_istio
77d0ab3d50c245a7753f22d02cb09baf0248186d
link
/test update-ref-docs-dry-run_istio

lint_istio
77d0ab3d50c245a7753f22d02cb09baf0248186d
link
/test lint_istio

integ-mixer-k8s-tests_istio
77d0ab3d50c245a7753f22d02cb09baf0248186d
link
/test integ-mixer-k8s-tests_istio

integ-pilot-k8s-tests_istio
77d0ab3d50c245a7753f22d02cb09baf0248186d
link
/test integ-pilot-k8s-tests_istio

integ-distroless-k8s-tests_istio
77d0ab3d50c245a7753f22d02cb09baf0248186d
link
/test integ-distroless-k8s-tests_istio

integ-galley-k8s-tests_istio
77d0ab3d50c245a7753f22d02cb09baf0248186d
link
/test integ-galley-k8s-tests_istio

integ-security-k8s-tests_istio
77d0ab3d50c245a7753f22d02cb09baf0248186d
link
/test integ-security-k8s-tests_istio

integ-telemetry-k8s-tests_istio
77d0ab3d50c245a7753f22d02cb09baf0248186d
link
/test integ-telemetry-k8s-tests_istio

integ-conformance-k8s-tests_istio
77d0ab3d50c245a7753f22d02cb09baf0248186d
link
/test integ-conformance-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
77d0ab3d50c245a7753f22d02cb09baf0248186d
link
/test unit-tests_istio

integ-local-tests_istio
77d0ab3d50c245a7753f22d02cb09baf0248186d
link
/test integ-local-tests_istio

release-test_istio
77d0ab3d50c245a7753f22d02cb09baf0248186d
link
/test release-test_istio

update-ref-docs-dry-run_istio
77d0ab3d50c245a7753f22d02cb09baf0248186d
link
/test update-ref-docs-dry-run_istio

lint_istio
77d0ab3d50c245a7753f22d02cb09baf0248186d
link
/test lint_istio

integ-mixer-k8s-tests_istio
77d0ab3d50c245a7753f22d02cb09baf0248186d
link
/test integ-mixer-k8s-tests_istio

integ-pilot-k8s-tests_istio
77d0ab3d50c245a7753f22d02cb09baf0248186d
link
/test integ-pilot-k8s-tests_istio

integ-distroless-k8s-tests_istio
77d0ab3d50c245a7753f22d02cb09baf0248186d
link
/test integ-distroless-k8s-tests_istio

integ-galley-k8s-tests_istio
77d0ab3d50c245a7753f22d02cb09baf0248186d
link
/test integ-galley-k8s-tests_istio

integ-security-k8s-tests_istio
77d0ab3d50c245a7753f22d02cb09baf0248186d
link
/test integ-security-k8s-tests_istio

integ-telemetry-k8s-tests_istio
77d0ab3d50c245a7753f22d02cb09baf0248186d
link
/test integ-telemetry-k8s-tests_istio

integ-conformance-k8s-tests_istio
77d0ab3d50c245a7753f22d02cb09baf0248186d
link
/test integ-conformance-k8s-tests_istio

integ-multicluster-k8s-tests_istio
77d0ab3d50c245a7753f22d02cb09baf0248186d
link
/test integ-multicluster-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
77d0ab3d50c245a7753f22d02cb09baf0248186d
link
/test unit-tests_istio

integ-local-tests_istio
77d0ab3d50c245a7753f22d02cb09baf0248186d
link
/test integ-local-tests_istio

release-test_istio
77d0ab3d50c245a7753f22d02cb09baf0248186d
link
/test release-test_istio

update-ref-docs-dry-run_istio
77d0ab3d50c245a7753f22d02cb09baf0248186d
link
/test update-ref-docs-dry-run_istio

lint_istio
77d0ab3d50c245a7753f22d02cb09baf0248186d
link
/test lint_istio

integ-mixer-k8s-tests_istio
77d0ab3d50c245a7753f22d02cb09baf0248186d
link
/test integ-mixer-k8s-tests_istio

integ-pilot-k8s-tests_istio
77d0ab3d50c245a7753f22d02cb09baf0248186d
link
/test integ-pilot-k8s-tests_istio

integ-distroless-k8s-tests_istio
77d0ab3d50c245a7753f22d02cb09baf0248186d
link
/test integ-distroless-k8s-tests_istio

integ-galley-k8s-tests_istio
77d0ab3d50c245a7753f22d02cb09baf0248186d
link
/test integ-galley-k8s-tests_istio

integ-security-k8s-tests_istio
77d0ab3d50c245a7753f22d02cb09baf0248186d
link
/test integ-security-k8s-tests_istio

integ-telemetry-k8s-tests_istio
77d0ab3d50c245a7753f22d02cb09baf0248186d
link
/test integ-telemetry-k8s-tests_istio

integ-conformance-k8s-tests_istio
77d0ab3d50c245a7753f22d02cb09baf0248186d
link
/test integ-conformance-k8s-tests_istio

integ-multicluster-k8s-tests_istio
77d0ab3d50c245a7753f22d02cb09baf0248186d
link
/test integ-multicluster-k8s-tests_istio

gencheck_istio
77d0ab3d50c245a7753f22d02cb09baf0248186d
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
77d0ab3d50c245a7753f22d02cb09baf0248186d
link
/test unit-tests_istio

integ-local-tests_istio
77d0ab3d50c245a7753f22d02cb09baf0248186d
link
/test integ-local-tests_istio

release-test_istio
77d0ab3d50c245a7753f22d02cb09baf0248186d
link
/test release-test_istio

lint_istio
77d0ab3d50c245a7753f22d02cb09baf0248186d
link
/test lint_istio

integ-mixer-k8s-tests_istio
77d0ab3d50c245a7753f22d02cb09baf0248186d
link
/test integ-mixer-k8s-tests_istio

integ-pilot-k8s-tests_istio
77d0ab3d50c245a7753f22d02cb09baf0248186d
link
/test integ-pilot-k8s-tests_istio

integ-distroless-k8s-tests_istio
77d0ab3d50c245a7753f22d02cb09baf0248186d
link
/test integ-distroless-k8s-tests_istio

integ-galley-k8s-tests_istio
77d0ab3d50c245a7753f22d02cb09baf0248186d
link
/test integ-galley-k8s-tests_istio

integ-security-k8s-tests_istio
77d0ab3d50c245a7753f22d02cb09baf0248186d
link
/test integ-security-k8s-tests_istio

integ-telemetry-k8s-tests_istio
77d0ab3d50c245a7753f22d02cb09baf0248186d
link
/test integ-telemetry-k8s-tests_istio

integ-conformance-k8s-tests_istio
77d0ab3d50c245a7753f22d02cb09baf0248186d
link
/test integ-conformance-k8s-tests_istio

integ-multicluster-k8s-tests_istio
77d0ab3d50c245a7753f22d02cb09baf0248186d
link
/test integ-multicluster-k8s-tests_istio

gencheck_istio
77d0ab3d50c245a7753f22d02cb09baf0248186d
link
/test gencheck_istio

update-ref-docs-dry-run_istio
81f0a3433f0a56e99a6d36148a9778180804113e
link
/test update-ref-docs-dry-run_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
77d0ab3d50c245a7753f22d02cb09baf0248186d
link
/test unit-tests_istio

integ-local-tests_istio
77d0ab3d50c245a7753f22d02cb09baf0248186d
link
/test integ-local-tests_istio

release-test_istio
77d0ab3d50c245a7753f22d02cb09baf0248186d
link
/test release-test_istio

integ-mixer-k8s-tests_istio
77d0ab3d50c245a7753f22d02cb09baf0248186d
link
/test integ-mixer-k8s-tests_istio

integ-pilot-k8s-tests_istio
77d0ab3d50c245a7753f22d02cb09baf0248186d
link
/test integ-pilot-k8s-tests_istio

integ-distroless-k8s-tests_istio
77d0ab3d50c245a7753f22d02cb09baf0248186d
link
/test integ-distroless-k8s-tests_istio

integ-galley-k8s-tests_istio
77d0ab3d50c245a7753f22d02cb09baf0248186d
link
/test integ-galley-k8s-tests_istio

integ-security-k8s-tests_istio
77d0ab3d50c245a7753f22d02cb09baf0248186d
link
/test integ-security-k8s-tests_istio

integ-telemetry-k8s-tests_istio
77d0ab3d50c245a7753f22d02cb09baf0248186d
link
/test integ-telemetry-k8s-tests_istio

integ-conformance-k8s-tests_istio
77d0ab3d50c245a7753f22d02cb09baf0248186d
link
/test integ-conformance-k8s-tests_istio

integ-multicluster-k8s-tests_istio
77d0ab3d50c245a7753f22d02cb09baf0248186d
link
/test integ-multicluster-k8s-tests_istio

gencheck_istio
77d0ab3d50c245a7753f22d02cb09baf0248186d
link
/test gencheck_istio

update-ref-docs-dry-run_istio
81f0a3433f0a56e99a6d36148a9778180804113e
link
/test update-ref-docs-dry-run_istio

lint_istio
81f0a3433f0a56e99a6d36148a9778180804113e
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
77d0ab3d50c245a7753f22d02cb09baf0248186d
link
/test unit-tests_istio

integ-local-tests_istio
77d0ab3d50c245a7753f22d02cb09baf0248186d
link
/test integ-local-tests_istio

release-test_istio
77d0ab3d50c245a7753f22d02cb09baf0248186d
link
/test release-test_istio

integ-mixer-k8s-tests_istio
77d0ab3d50c245a7753f22d02cb09baf0248186d
link
/test integ-mixer-k8s-tests_istio

integ-pilot-k8s-tests_istio
77d0ab3d50c245a7753f22d02cb09baf0248186d
link
/test integ-pilot-k8s-tests_istio

integ-distroless-k8s-tests_istio
77d0ab3d50c245a7753f22d02cb09baf0248186d
link
/test integ-distroless-k8s-tests_istio

integ-galley-k8s-tests_istio
77d0ab3d50c245a7753f22d02cb09baf0248186d
link
/test integ-galley-k8s-tests_istio

integ-security-k8s-tests_istio
77d0ab3d50c245a7753f22d02cb09baf0248186d
link
/test integ-security-k8s-tests_istio

integ-telemetry-k8s-tests_istio
77d0ab3d50c245a7753f22d02cb09baf0248186d
link
/test integ-telemetry-k8s-tests_istio

integ-conformance-k8s-tests_istio
77d0ab3d50c245a7753f22d02cb09baf0248186d
link
/test integ-conformance-k8s-tests_istio

integ-multicluster-k8s-tests_istio
77d0ab3d50c245a7753f22d02cb09baf0248186d
link
/test integ-multicluster-k8s-tests_istio

update-ref-docs-dry-run_istio
81f0a3433f0a56e99a6d36148a9778180804113e
link
/test update-ref-docs-dry-run_istio

lint_istio
81f0a3433f0a56e99a6d36148a9778180804113e
link
/test lint_istio

gencheck_istio
81f0a3433f0a56e99a6d36148a9778180804113e
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-local-tests_istio
77d0ab3d50c245a7753f22d02cb09baf0248186d
link
/test integ-local-tests_istio

release-test_istio
77d0ab3d50c245a7753f22d02cb09baf0248186d
link
/test release-test_istio

integ-mixer-k8s-tests_istio
77d0ab3d50c245a7753f22d02cb09baf0248186d
link
/test integ-mixer-k8s-tests_istio

integ-pilot-k8s-tests_istio
77d0ab3d50c245a7753f22d02cb09baf0248186d
link
/test integ-pilot-k8s-tests_istio

integ-security-k8s-tests_istio
77d0ab3d50c245a7753f22d02cb09baf0248186d
link
/test integ-security-k8s-tests_istio

integ-telemetry-k8s-tests_istio
77d0ab3d50c245a7753f22d02cb09baf0248186d
link
/test integ-telemetry-k8s-tests_istio

integ-multicluster-k8s-tests_istio
77d0ab3d50c245a7753f22d02cb09baf0248186d
link
/test integ-multicluster-k8s-tests_istio

update-ref-docs-dry-run_istio
81f0a3433f0a56e99a6d36148a9778180804113e
link
/test update-ref-docs-dry-run_istio

lint_istio
81f0a3433f0a56e99a6d36148a9778180804113e
link
/test lint_istio

gencheck_istio
81f0a3433f0a56e99a6d36148a9778180804113e
link
/test gencheck_istio

unit-tests_istio
81f0a3433f0a56e99a6d36148a9778180804113e
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-multicluster-k8s-tests_istio
77d0ab3d50c245a7753f22d02cb09baf0248186d
link
/test integ-multicluster-k8s-tests_istio

lint_istio
81f0a3433f0a56e99a6d36148a9778180804113e
link
/test lint_istio

gencheck_istio
81f0a3433f0a56e99a6d36148a9778180804113e
link
/test gencheck_istio

unit-tests_istio
81f0a3433f0a56e99a6d36148a9778180804113e
link
/test unit-tests_istio

update-ref-docs-dry-run_istio
970998fe8af3bf98ec9f43e08922bc1f33ab54e1
link
/test update-ref-docs-dry-run_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-multicluster-k8s-tests_istio
77d0ab3d50c245a7753f22d02cb09baf0248186d
link
/test integ-multicluster-k8s-tests_istio

gencheck_istio
81f0a3433f0a56e99a6d36148a9778180804113e
link
/test gencheck_istio

unit-tests_istio
81f0a3433f0a56e99a6d36148a9778180804113e
link
/test unit-tests_istio

update-ref-docs-dry-run_istio
970998fe8af3bf98ec9f43e08922bc1f33ab54e1
link
/test update-ref-docs-dry-run_istio

lint_istio
970998fe8af3bf98ec9f43e08922bc1f33ab54e1
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-multicluster-k8s-tests_istio
77d0ab3d50c245a7753f22d02cb09baf0248186d
link
/test integ-multicluster-k8s-tests_istio

update-ref-docs-dry-run_istio
970998fe8af3bf98ec9f43e08922bc1f33ab54e1
link
/test update-ref-docs-dry-run_istio

lint_istio
970998fe8af3bf98ec9f43e08922bc1f33ab54e1
link
/test lint_istio

unit-tests_istio
970998fe8af3bf98ec9f43e08922bc1f33ab54e1
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

update-ref-docs-dry-run_istio
970998fe8af3bf98ec9f43e08922bc1f33ab54e1
link
/test update-ref-docs-dry-run_istio

unit-tests_istio
970998fe8af3bf98ec9f43e08922bc1f33ab54e1
link
/test unit-tests_istio

lint_istio
ac45a0e4d388c002d2180b18ba75f51dc2e28e28
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
970998fe8af3bf98ec9f43e08922bc1f33ab54e1
link
/test unit-tests_istio

lint_istio
ac45a0e4d388c002d2180b18ba75f51dc2e28e28
link
/test lint_istio

update-ref-docs-dry-run_istio
ac45a0e4d388c002d2180b18ba75f51dc2e28e28
link
/test update-ref-docs-dry-run_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
ac45a0e4d388c002d2180b18ba75f51dc2e28e28
link
/test lint_istio

update-ref-docs-dry-run_istio
ac45a0e4d388c002d2180b18ba75f51dc2e28e28
link
/test update-ref-docs-dry-run_istio

unit-tests_istio
ac45a0e4d388c002d2180b18ba75f51dc2e28e28
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
ac45a0e4d388c002d2180b18ba75f51dc2e28e28
link
/test unit-tests_istio

lint_istio
dc209342d11b47671190f2b046bcfe90649b0223
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
dc209342d11b47671190f2b046bcfe90649b0223
link
/test lint_istio

unit-tests_istio
dc209342d11b47671190f2b046bcfe90649b0223
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
dc209342d11b47671190f2b046bcfe90649b0223
link
/test unit-tests_istio

lint_istio
1b8764fd0cbc1862bee2233048f67898731493d9
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
1b8764fd0cbc1862bee2233048f67898731493d9
link
/test lint_istio

unit-tests_istio
1b8764fd0cbc1862bee2233048f67898731493d9
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
1b8764fd0cbc1862bee2233048f67898731493d9
link
/test unit-tests_istio

lint_istio
287e774ec78acf7191c897bedb8eddca0e46fe43
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
287e774ec78acf7191c897bedb8eddca0e46fe43
link
/test lint_istio

unit-tests_istio
287e774ec78acf7191c897bedb8eddca0e46fe43
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
287e774ec78acf7191c897bedb8eddca0e46fe43
link
/test unit-tests_istio

lint_istio
087ff138895448cfed4889921bd698caf23da0c3
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
287e774ec78acf7191c897bedb8eddca0e46fe43
link
/test unit-tests_istio

lint_istio
6a2364c9266e377c2a6fd851f65b4a87065109c6
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
6a2364c9266e377c2a6fd851f65b4a87065109c6
link
/test lint_istio

unit-tests_istio
6a2364c9266e377c2a6fd851f65b4a87065109c6
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
6a2364c9266e377c2a6fd851f65b4a87065109c6
link
/test unit-tests_istio

lint_istio
9bc43191150a45cc203a215d87ef9a57bf35bd63
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Can I update it in next PR ( or if any other change is requested ) ? It
feels like it's 2017 - I think
it's about the time we started MCP, and this file is implementing most of
that.
On Fri, Apr 24, 2020 at 9:48 AM mandarjog notifications@github.com wrote:

@mandarjog commented on this pull request.
In pilot/pkg/networking/apigen/apigen.go
https://github.com/istio/istio/pull/23159#discussion_r414717646:

@@ -0,0 +1,160 @@
+// Copyright 2017 Istio Authors

Nit: its 2020 :/)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/istio/istio/pull/23159#pullrequestreview-400110087,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAUR2SKTXP44BXJJGHBKYLROG7EDANCNFSM4MOSE4FA
.

Apigen is restoring the ability to pull Istio config objects - that has been reviewed and approved and has been available in 1.5 (Galley). We no longer ship galley - the new code is providing the same
feature, but in one file (much simpler) and over XDS. All use cases from MCP apply.
I'm personally interested in this because it allows istio-agent to get the ServiceEntry objects - and
resolve DNS without a round trip ( the DNS-TLS increases latency - with this mechanism the latency should be lower than with DNS-UDP). I'm also interested in it for the experiments with having generation of config in agent - the prototype is in the WIP PR. I'm going to propose it for 1.7 - but
it helps to have numbers.
However apigen is not specific to either of those feature - it just restore a functionality already approved that we would lose otherwise.

Re. GRPC - the design doc is linked in the comments ( or was ), it has been discussed and approved in the envoy community and is implemented by other XDS servers. I'm not very happy with it - or
with the implementation they have - that's what motivated me to work on the istio support.

@costinm this PR is way too big to be reviewed before 1.6 code freeze. I have few high level questions:

Why do we need this? Where is the use case/issue related to it?
Why does it have to merged in release-1.6 if we never discussed it during Networking WG meetings?

@costinm apigen is just istio config distribution, right? That is a super nice feature, the question is can we invite experimentation with it without adding to mainline code in 1.6? I think the experimentation can be done on master once design docs are widely reviewed?

Ok, leaving it out of 1.6.
If the standard is to have all non-user visible changes in 1.6 be
officially approved - maybe we should enforce what Mitch was proposing, and
have links to approved docs in each merged PR.
Will start writing the formal doc for next meeting - and let's enforce this
on all PRs
On Fri, Apr 24, 2020, 21:15 mandarjog notifications@github.com wrote:

@costinm https://github.com/costinm apigen is just istio config
distribution, right? That is a super nice feature, the question is can we
invite experimentation with it without adding to mainline code in 1.6? I
think the experimentation can be done on master once design docs are widely
reviewed?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/istio/istio/pull/23159#issuecomment-619317301, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAUR2X3MMACYD3KUMGBTLDROJPXPANCNFSM4MOSE4FA
.

However apigen is not specific to either of those feature - it just restore a functionality already approved that we would lose otherwise.

I think this merits a much bigger discussion. I dont want to bring back all the complexity we threw away, in the form of a different protocol wrapper.
With regard to your comment about DNS: shouldn't we have some design consensus ? I am not really sure streaming service entries to agents is the way to go when there are easier ways IMO. Also, fwiw, the dns service is running in istiod (in 1.6). So, once we move the DNS to istio-agent, I am happy to investigate ways of providing dns resolution details to the agents.
The gRPC side of it - I am really okay to ship as experimental in 1.6 (assuming others are okay with it) as long as it is guarded by feature flag and turned off until we really see performance numbers to prove that it wont affect the envoy side of things.
The problem everyone has with this PR is that it is bundling way too many concerns - bringing back mcp, starting to stream service entries to sidecar agents, and grpc - none of these have gotten any consensus from other maintainers.

However apigen is not specific to either of those feature - it just restore a functionality already approved that we would lose otherwise.

I think this merits a much bigger discussion. I dont want to bring back all the complexity we threw away, in the form of a different protocol wrapper.
With regard to your comment about DNS: shouldn't we have some design consensus ? I am not really sure streaming service entries to agents is the way to go when there are easier ways IMO. Also, fwiw, the dns service is running in istiod (in 1.6). So, once we move the DNS to istio-agent, I am happy to investigate ways of providing dns resolution details to the agents.
The gRPC side of it - I am really okay to ship as experimental in 1.6 (assuming others are okay with it) as long as it is guarded by feature flag and turned off until we really see performance numbers to prove that it wont affect the envoy side of things.
The problem everyone has with this PR is that it is bundling way too many concerns - bringing back mcp, starting to stream service entries to sidecar agents, and grpc - none of these have gotten any consensus from other maintainers.

I've started the design docs for each individual feature.
Regarding MCP - AFAIK the concept of mesh config distribution has been approved long ago.
The 'complexity' of the previous implementation is still there - most of the files in galley are still around. This is just a new implementation of what was long-ago approved - as a single file.
Using XDS for 'extensible' transport has also been discussed and approved - see the UDPA
discussions in envoy. So I am just re-implementing approved designs with cleaner/simpler
code.
This PR is NOT streaming anything to agents - and of course we'll have design docs before
I'm doing that. Same for DNS changes - I just mentioned that I'm planning to rely on the already
approved MCP design for those new designs, to explain why I'm interested in having this merged.
It doesn't have to be in 1.6 for my purpose - but because we're no longer shipping Galley and
the work to run the big MCP server in istiod didn't complete I think it would have been better to
not have a regression in functionality. Streaming Istio configs is a very useful feature we had
for 3 releases, and I don't remember any TOC or WG decision to revert the approval on the
MCP design. We agreed to de-duplicate the code and clean up - which is what I'm doing.
None of the other cleanup PRs had design docs, nor many of the far more user-impacting changes.

https://docs.google.com/document/d/1lHjUzDY-4hxElWN7g6pz-_Ws7yIPt62tmX3iGs_uLyI for MCP - will add it to next WG meeting.

Moved MCP to different package - this is just GRPC.
Design doc in this week networking agenda - hopefully or similar PRs will also start to be required to have a design doc and approval...

@costinm: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
787522f767d4ec826c410c82fc208bc9b4746901
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
787522f767d4ec826c410c82fc208bc9b4746901
link
/test lint_istio

unit-tests_istio
787522f767d4ec826c410c82fc208bc9b4746901
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Split to 2 PRs, this is just doing gRPC.
If the concern on blocking this PR is that it was not discussed on Networking WG - added it to the agenda, with a design doc - and please let's stop and rollback other changes that are in progress or
have been merged that don't meet this bar. I'm not disagreeing with that !

@costinm: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
787522f767d4ec826c410c82fc208bc9b4746901
link
/test lint_istio

unit-tests_istio
787522f767d4ec826c410c82fc208bc9b4746901
link
/test unit-tests_istio

integ-conformance-k8s-tests_istio
418008cf68052a97a84afd9575410108cbb99ad2
link
/test integ-conformance-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test integ-conformance-k8s-tests_istio

/cherrypick release-1.6

@costinm: #23159 failed to apply on top of branch "release-1.6":
.git/rebase-apply/patch:248: new blank line at EOF.
+
.git/rebase-apply/patch:448: new blank line at EOF.
+
.git/rebase-apply/patch:882: new blank line at EOF.
+
warning: 3 lines add whitespace errors.
error: Failed to merge in the changes.
Using index info to reconstruct a base tree...
M	pilot/pkg/bootstrap/server.go
M	pilot/pkg/model/context.go
M	pilot/pkg/proxy/envoy/v2/ads.go
M	pilot/pkg/serviceregistry/external/conversion.go
Falling back to patching base and 3-way merge...
Auto-merging pilot/pkg/serviceregistry/external/conversion.go
Auto-merging pilot/pkg/proxy/envoy/v2/ads.go
Auto-merging pilot/pkg/model/context.go
Auto-merging pilot/pkg/bootstrap/server.go
CONFLICT (content): Merge conflict in pilot/pkg/bootstrap/server.go
Patch failed at 0001 Part 3 of generator refactoring: add back MCP-resource generator and basic GRPC support

In response to this:

/cherrypick release-1.6

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

authors: costinm istio-testing mandarjog nrjpoddar rshriram


text:
[release-1.6] sds: add file watcher support

This is an automated cherry-pick of #23417

@ramaraochavali Please consent.

I consent

@googlebot  I consent

source: gharchive/pull-request

repo: istio/istio

license_type: permissive

license_source: github-api


text:
[DO NOT MERGE] Auto PR to update dependencies of istio

This PR will be merged automatically once checks are successful.
none

@istio-testing: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-smoke.sh
9fc228c57e00f82ce3043e6a8aac18ebae185194
link
/test e2e-smoke

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


text:
Fuzzing: Add helm reconciler fuzzer

Adds a fuzzer that creates a fuzzed k8sobject, passes its unstructured object to a fake client, creates a helm reconciler, and then calls ApplyObject with the same unstructured object.
[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ ] Networking
[x] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[x] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
Pull Request Attributes
Please check any characteristics that apply to this pull request.
[x] Does not have any user-facing changes. This may include CLI changes, API changes, behavior changes, performance improvements, etc.

Hi @AdamKorcz. Thanks for your PR.
I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

/ok-to-test

@AdamKorcz: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
5d16c413398ad16aec6eaa02dc54e6ac1c503efb
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

authors: AdamKorcz ericvn istio-testing


text:
Add DeploymentConfig to GetDeployMetaFromPod

Please provide a description of this PR:
Related to https://github.com/istio/istio/issues/36155.
@bianpengyuan @lucasponce

@lucasponce please take a look at this change. thanks!

@lucasponce please take a look at this change. thanks!

Patch looks ok, thanks !
DeploymentConfig are old controllers, but there are a large population of OpenShift users that still use them, and they want to add them to the mesh without migrating, so this patch will help them to get the proper name of the workload.

@monsteredc: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

lint_istio
ea01184fd87ddf5e5f9eace22eda3dd044a906f2
link
true
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

authors: bianpengyuan istio-testing lucasponce monsteredc


text:
Update dependencies

Please provide a description of this PR:
Update 3rd party dependencies

@jacob-delgado: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
9782a08cb05dd623c834dbb7cb5cbc5d4a73f403
link
true
/test unit-tests-arm64

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jacob-delgado: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
9782a08cb05dd623c834dbb7cb5cbc5d4a73f403
link
true
/test unit-tests-arm64

unit-tests_istio
9782a08cb05dd623c834dbb7cb5cbc5d4a73f403
link
true
/test unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jacob-delgado: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
9782a08cb05dd623c834dbb7cb5cbc5d4a73f403
link
true
/test unit-tests-arm64

unit-tests_istio
9782a08cb05dd623c834dbb7cb5cbc5d4a73f403
link
true
/test unit-tests

release-test_istio
9782a08cb05dd623c834dbb7cb5cbc5d4a73f403
link
true
/test release-test

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jacob-delgado: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
9782a08cb05dd623c834dbb7cb5cbc5d4a73f403
link
true
/test unit-tests-arm64

unit-tests_istio
9782a08cb05dd623c834dbb7cb5cbc5d4a73f403
link
true
/test unit-tests

release-test_istio
9782a08cb05dd623c834dbb7cb5cbc5d4a73f403
link
true
/test release-test

integ-basic-arm64_istio
9782a08cb05dd623c834dbb7cb5cbc5d4a73f403
link
true
/test integ-basic-arm64

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

authors: istio-testing jacob-delgado


text:
Disable istio-ingressgateway in ambient profile

Please provide a description of this PR:
Fixes: #44030
Adding DNM until the getting started with ambient doc is updated.

/test integ-security-multicluster

@frankbu: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-ambient_istio
f51539fdb888abd55815310af8f5861f24a80f54
link
unknown
/test integ-ambient

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test integ-ambient

authors: ericvn frankbu istio-testing


text:
envoy: revert to authenticated principal in rbac for sidecars

Change-Id: If8a647e70ee4a1d4a5115b45ed95301c602fe833
Follow-up to https://github.com/istio/proxy/pull/5047 to use the upstream filters.
Because Istio sidecars support "mixed" SPIFFE certificates with dual-use URI SANs, this PR reverts to the old sidecar policy generation until we can enforce stricter SPIFFE validation.
For ambient, we assume the strict SPIFFE encoding, so we can replace it with the upstream filter.

@kyessenov: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

lint_istio
947b01e59d752dc72beaa8e8b2564e3f159a015f
link
true
/test lint

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kyessenov: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

lint_istio
947b01e59d752dc72beaa8e8b2564e3f159a015f
link
true
/test lint

gencheck_istio
947b01e59d752dc72beaa8e8b2564e3f159a015f
link
true
/test gencheck

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kyessenov: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

lint_istio
947b01e59d752dc72beaa8e8b2564e3f159a015f
link
true
/test lint

gencheck_istio
947b01e59d752dc72beaa8e8b2564e3f159a015f
link
true
/test gencheck

integ-ambient_istio
947b01e59d752dc72beaa8e8b2564e3f159a015f
link
true
/test integ-ambient

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kyessenov: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-ambient_istio
8384811db9986373d709738ae7bd8af7b1917586
link
true
/test integ-ambient

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@GregHanson @aryan16 Responding here since it's easier to find later.
Istio 1.17 - Istio 1.20 sidecar RBAC works fine with the authenticated principal instead of filter_state, so there's no compatibility issues of the Istio 1.20 control plane for the Istio 1.19 data plane.
Istio ambient mode is going to be affected by the replacement of the extensions, but that's expected for "alpha" APIs. We should still prefer the upstream extensions for future stability.

authors: istio-testing kyessenov


text:
OpenTelemetryTracingProvider: Allow to configure resource detectors

Please provide a description of this PR:
This PR uses the new resource detectors API config (https://github.com/istio/api/pull/3002) and allows configuring OpenTelemetry resource detectors.
Resource detectors are an important part of observability, allowing to correlate telemetry with things such as hosts, processes, cloud resources and much more. This PR adds the possibility to configure two resource detectors:

Environment
Dynatrace

Closes #48885
I tested this locally with both resource detectors enabled and I confirmed the attributes are all added to the exported telemetry.

@joaopgrassi: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
e3ce9e829a4e660013712992b782b6103a15b700
link
true
/test release-notes

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@joaopgrassi: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-telemetry-istiodremote_istio
3d286e8e89da31d53e1bb28d07f5985981ce6eb2
link
true
/test integ-telemetry-istiodremote

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@joaopgrassi: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-telemetry-istiodremote_istio
3d286e8e89da31d53e1bb28d07f5985981ce6eb2
link
true
/test integ-telemetry-istiodremote

integ-telemetry_istio
3d286e8e89da31d53e1bb28d07f5985981ce6eb2
link
true
/test integ-telemetry

integ-telemetry-discovery_istio
3d286e8e89da31d53e1bb28d07f5985981ce6eb2
link
true
/test integ-telemetry-discovery

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@joaopgrassi: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-telemetry-istiodremote_istio
3d286e8e89da31d53e1bb28d07f5985981ce6eb2
link
true
/test integ-telemetry-istiodremote

integ-telemetry_istio
3d286e8e89da31d53e1bb28d07f5985981ce6eb2
link
true
/test integ-telemetry

integ-telemetry-discovery_istio
3d286e8e89da31d53e1bb28d07f5985981ce6eb2
link
true
/test integ-telemetry-discovery

integ-telemetry-mc_istio
3d286e8e89da31d53e1bb28d07f5985981ce6eb2
link
true
/test integ-telemetry-mc

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@joaopgrassi: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-telemetry-istiodremote_istio
3d286e8e89da31d53e1bb28d07f5985981ce6eb2
link
true
/test integ-telemetry-istiodremote

integ-telemetry_istio
3d286e8e89da31d53e1bb28d07f5985981ce6eb2
link
true
/test integ-telemetry

integ-telemetry-discovery_istio
3d286e8e89da31d53e1bb28d07f5985981ce6eb2
link
true
/test integ-telemetry-discovery

integ-telemetry-mc_istio
3d286e8e89da31d53e1bb28d07f5985981ce6eb2
link
true
/test integ-telemetry-mc

unit-tests-arm64_istio
97c45c6bd1a1dd810a39c956441a9378fbf3f45b
link
true
/test unit-tests-arm64

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@joaopgrassi: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-telemetry-istiodremote_istio
3d286e8e89da31d53e1bb28d07f5985981ce6eb2
link
true
/test integ-telemetry-istiodremote

integ-telemetry-discovery_istio
3d286e8e89da31d53e1bb28d07f5985981ce6eb2
link
true
/test integ-telemetry-discovery

integ-telemetry-mc_istio
3d286e8e89da31d53e1bb28d07f5985981ce6eb2
link
true
/test integ-telemetry-mc

unit-tests-arm64_istio
97c45c6bd1a1dd810a39c956441a9378fbf3f45b
link
true
/test unit-tests-arm64

integ-telemetry_istio
97c45c6bd1a1dd810a39c956441a9378fbf3f45b
link
true
/test integ-telemetry

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@joaopgrassi: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-telemetry-istiodremote_istio
3d286e8e89da31d53e1bb28d07f5985981ce6eb2
link
true
/test integ-telemetry-istiodremote

integ-telemetry-mc_istio
3d286e8e89da31d53e1bb28d07f5985981ce6eb2
link
true
/test integ-telemetry-mc

unit-tests-arm64_istio
97c45c6bd1a1dd810a39c956441a9378fbf3f45b
link
true
/test unit-tests-arm64

integ-telemetry_istio
97c45c6bd1a1dd810a39c956441a9378fbf3f45b
link
true
/test integ-telemetry

integ-telemetry-discovery_istio
97c45c6bd1a1dd810a39c956441a9378fbf3f45b
link
true
/test integ-telemetry-discovery

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@joaopgrassi: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-telemetry-mc_istio
3d286e8e89da31d53e1bb28d07f5985981ce6eb2
link
true
/test integ-telemetry-mc

unit-tests-arm64_istio
97c45c6bd1a1dd810a39c956441a9378fbf3f45b
link
true
/test unit-tests-arm64

integ-telemetry_istio
97c45c6bd1a1dd810a39c956441a9378fbf3f45b
link
true
/test integ-telemetry

integ-telemetry-discovery_istio
97c45c6bd1a1dd810a39c956441a9378fbf3f45b
link
true
/test integ-telemetry-discovery

integ-telemetry-istiodremote_istio
97c45c6bd1a1dd810a39c956441a9378fbf3f45b
link
true
/test integ-telemetry-istiodremote

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

The tests are failing because when configuring the environment resource detector, Envoy fails to start when the env variable OTEL_RESOURCE_ATTRIBUTES is not defined. I'm looking if I can find a way to add some but would appreciate some help.

The tests are failing because when configuring the environment resource detector, Envoy fails to start when the env variable OTEL_RESOURCE_ATTRIBUTES is not defined. I'm looking if I can find a way to add some but would appreciate some help.
ner rejected: Error adding/updating listener(s) 0.0.0.0_9080: Environment variable doesn't exist: OTEL_RESOURCE_ATTRIBUTES
0.0.0.0_4317: Environment variable doesn't exist: OTEL_RESOURCE_ATTRIBUTES
0.0.0.0_15010: Environment variable doesn't exist: OTEL_RESOURCE_ATTRIBUTES
10.98.50.165_15021: Environment variable doesn't exist: OTEL_RESOURCE_ATTRIBUTES
0.0.0.0_15014: Environment variable doesn't exist: OTEL_RESOURCE_ATTRIBUTES
0.0.0.0_80: Environment variable doesn't exist: OTEL_RESOURCE_ATTRIBUTES
10.96.0.10_9153: Environment variable doesn't exist: OTEL_RESOURCE_ATTRIBUTES
0.0.0.0_55678: Environment variable doesn't exist: OTEL_RESOURCE_ATTRIBUTES
0.0.0.0_4318: Environment variable doesn't exist: OTEL_RESOURCE_ATTRIBUTES
virtualInbound: Environment variable doesn't exist: OTEL_RESOURCE_ATTRIBUTES
        thread=14
2024-02-05T12:46:00.634678Z     warn    Envoy proxy is NOT ready: config received from XDS server, but was rejected: cds updates: 1 successful, 0 rejected; lds updates: 0 successful, 1 rejected

maybe envoy should just warning instead of rejecting the config.

maybe envoy should just warning instead of rejecting the config.

Yes, that was my proposal as well but the Envoy folks preferred that if there are  problems during "configuration phase", Envoy shouldn't not start up. The argument was that if that failed and Envoy would just continue silently, it would be hard for users to know that the resource detector is not working properly.
The Dynatrace detector is different (if it fails to detect, Envoy is not blocked), because if it fails for some reason, Dynatrace customers will know inside the product, on their deployment status page.

maybe envoy should just warning instead of rejecting the config.

Yes, that was my proposal as well but the Envoy folks preferred that if there are problems during "configuration phase", Envoy shouldn't not start up. The argument was that if that failed and Envoy would just continue silently, it would be hard for users to know that the resource detector is not working properly.
The Dynatrace detector is different (if it fails to detect, Envoy is not blocked), because if it fails for some reason, Dynatrace customers will know inside the product, on their deployment status page.

make sense

maybe envoy should just warning instead of rejecting the config.

Yes, that was my proposal as well but the Envoy folks preferred that if there are problems during "configuration phase", Envoy shouldn't not start up. The argument was that if that failed and Envoy would just continue silently, it would be hard for users to know that the resource detector is not working properly.
The Dynatrace detector is different (if it fails to detect, Envoy is not blocked), because if it fails for some reason, Dynatrace customers will know inside the product, on their deployment status page.

make sense

I do not agree it makes sense :slightly_smiling_face: . This turns this feature into a cluster-wide outage generator. I really think this needs more consideration

Otel proper SDKs do not fail if OTEL_RESOURCE_ATTRIBUTES is unset, I think this basically violates OTEL spec.

Otel proper SDKs do not fail if OTEL_RESOURCE_ATTRIBUTES is unset, I think this basically violates OTEL spec.

@howardjohn  In general I agree with you and that is what I tried to push and gave examples (OTel collector also does not fail), but unfortunately my intention didn't make it through.
About violating the OTel spec, unfortunately it is not that simple:
The OTel spec for resource detectors says:

Resource detection logic is expected to complete quickly since this code will be run during application initialization. Errors should be handled as specified in the Error Handling principles. Note the failure to detect any resource information MUST NOT be considered an error, whereas an error that occurs during an attempt to detect resource information SHOULD be considered an error.

The emphasis is mine, of what is pertinent to the discussion here. If the user configures Istio to use the env resource detector, but doesn't have the variable set, it shouldn't throw errors - as that is error during detecting resource information.
BUT: the Error Handling principles it links says:

The API or SDK MAY fail fast and cause the application to fail on initialization, e.g. because of a bad user config or environment, but MUST NOT cause the application to fail later at run time, e.g. due to dynamic config settings received from the Collector.

Which then favors what Envoy is doing - a user configuring Envoy to have the environment resource detector but NOT setting the environment variable can be considered as "bad user config" so it's not actually violating the spec.
Not sure how I can proceed here. I can try to open a new PR in Envoy, trying to change the behavior of the detector and I would much appreciate help from you folks to maybe have more weight on the decision.

I opened https://github.com/envoyproxy/envoy/issues/32225

I opened envoyproxy/envoy#32225

Thanks! I opened the PR, let's see if we can get it patched somehow.

I opened envoyproxy/envoy#32225

The PR that fixes it is merged in Envoy.
I reverted the change that added the env variable to the test. So it should fail now until Istio has the new Envoy version with the fix.

@joaopgrassi: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-telemetry-istiodremote_istio
1cda858d0633f8464570f4f685d4f75e1620126e
link
true
/test integ-telemetry-istiodremote

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@joaopgrassi: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-telemetry-istiodremote_istio
1cda858d0633f8464570f4f685d4f75e1620126e
link
true
/test integ-telemetry-istiodremote

integ-telemetry_istio
1cda858d0633f8464570f4f685d4f75e1620126e
link
true
/test integ-telemetry

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@joaopgrassi: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-telemetry-istiodremote_istio
1cda858d0633f8464570f4f685d4f75e1620126e
link
true
/test integ-telemetry-istiodremote

integ-telemetry_istio
1cda858d0633f8464570f4f685d4f75e1620126e
link
true
/test integ-telemetry

integ-telemetry-discovery_istio
1cda858d0633f8464570f4f685d4f75e1620126e
link
true
/test integ-telemetry-discovery

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@joaopgrassi: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-telemetry-istiodremote_istio
1cda858d0633f8464570f4f685d4f75e1620126e
link
true
/test integ-telemetry-istiodremote

integ-telemetry_istio
1cda858d0633f8464570f4f685d4f75e1620126e
link
true
/test integ-telemetry

integ-telemetry-discovery_istio
1cda858d0633f8464570f4f685d4f75e1620126e
link
true
/test integ-telemetry-discovery

integ-telemetry-mc_istio
1cda858d0633f8464570f4f685d4f75e1620126e
link
true
/test integ-telemetry-mc

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Istio Proxy is still not up-to date with my commit in Envoy, but soon 🔜 . https://github.com/istio/proxy/commit/4d0b802082dd36cd1a5597ca24ed1fefbcb55f33

@joaopgrassi: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-telemetry_istio
1cda858d0633f8464570f4f685d4f75e1620126e
link
true
/test integ-telemetry

integ-telemetry-discovery_istio
1cda858d0633f8464570f4f685d4f75e1620126e
link
true
/test integ-telemetry-discovery

integ-telemetry-mc_istio
1cda858d0633f8464570f4f685d4f75e1620126e
link
true
/test integ-telemetry-mc

integ-telemetry-istiodremote_istio
531622c0ba39251e43a701a377b581420a996a82
link
true
/test integ-telemetry-istiodremote

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@joaopgrassi: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-telemetry-discovery_istio
1cda858d0633f8464570f4f685d4f75e1620126e
link
true
/test integ-telemetry-discovery

integ-telemetry-mc_istio
1cda858d0633f8464570f4f685d4f75e1620126e
link
true
/test integ-telemetry-mc

integ-telemetry-istiodremote_istio
531622c0ba39251e43a701a377b581420a996a82
link
true
/test integ-telemetry-istiodremote

integ-telemetry_istio
531622c0ba39251e43a701a377b581420a996a82
link
true
/test integ-telemetry

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@joaopgrassi: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-telemetry-discovery_istio
1cda858d0633f8464570f4f685d4f75e1620126e
link
true
/test integ-telemetry-discovery

integ-telemetry-istiodremote_istio
531622c0ba39251e43a701a377b581420a996a82
link
true
/test integ-telemetry-istiodremote

integ-telemetry_istio
531622c0ba39251e43a701a377b581420a996a82
link
true
/test integ-telemetry

integ-telemetry-mc_istio
531622c0ba39251e43a701a377b581420a996a82
link
true
/test integ-telemetry-mc

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@joaopgrassi: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-telemetry-istiodremote_istio
531622c0ba39251e43a701a377b581420a996a82
link
true
/test integ-telemetry-istiodremote

integ-telemetry_istio
531622c0ba39251e43a701a377b581420a996a82
link
true
/test integ-telemetry

integ-telemetry-mc_istio
531622c0ba39251e43a701a377b581420a996a82
link
true
/test integ-telemetry-mc

integ-telemetry-discovery_istio
531622c0ba39251e43a701a377b581420a996a82
link
true
/test integ-telemetry-discovery

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

authors: howardjohn istio-testing joaopgrassi zirain


text:
Add istio debug endpoints page to dashboard

Please provide a description of this PR:
Provide a convenient way to see the Istio debug endpoints.

what is the cmd output look like

what is the cmd output look like

@hzxuzhonghu Will be something like
istioctl d istio-debug istiod-ff7c47cfc-7xlqz
http://localhost:15014/debug

and automatically open the web browser, like other dashboard commands.

authors: hanxiaop hzxuzhonghu


text:
ztunnel: drop default requests

CPU is more debatable, but the memory requests is egregiously large
based on current performance tests.

In response to a cherrypick label: new pull request created: #51145

authors: howardjohn istio-testing


text:
Remove broker related code, test, and build files

The broker is not under active development at this time. Most of the
code is configuration related which will need to be rewritten from
scratch when we switch over to Galley/MCP. Furthermore, the CRD tests
are adding unnecessary load on the k8s api-server and causing test
flakes in some scenarios.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: ayj
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: rshriram
Assign the PR to them by writing /assign @rshriram in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/lgtm

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: ayj, geeknoid
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [geeknoid]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/lgtm

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: ayj, geeknoid, rshriram
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [geeknoid,rshriram]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ayj: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
7c60ba88a5012cf17b418329bfcb4ac6e046174d
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

New changes are detected. LGTM label has been removed.

@ayj: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
7c60ba88a5012cf17b418329bfcb4ac6e046174d
link
/test istio-presubmit

prow/istio-unit-tests.sh
83399671ea8aec7c0b26a078c1ae821369167cb7
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ayj: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
83399671ea8aec7c0b26a078c1ae821369167cb7
link
/test istio-unit-tests

prow/istio-presubmit.sh
83399671ea8aec7c0b26a078c1ae821369167cb7
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/lgtm

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: ayj, geeknoid, ldemailly, rshriram
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [geeknoid,ldemailly,rshriram]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ayj: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
83399671ea8aec7c0b26a078c1ae821369167cb7
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@geeknoid broker seems like an interesting idea.  I get it is being removed for 1.0 as we don't have capacity to finish it up (or really even start it).  Will the broker make a return to Istio, and if so, what will be its general purpose?
tx
-steve

@ayj: PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ayj - missed removing the line item in the README about a broker being part of the source as well. Don't know if you want to take that out.

New changes are detected. LGTM label has been removed.

/lgtm

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: ayj, geeknoid, ldemailly, rshriram, zachgersh
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [geeknoid,ldemailly,rshriram]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/lgtm

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: ayj, geeknoid, ldemailly, rshriram, zachgersh
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [geeknoid,ldemailly,rshriram]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ayj would be nice to pull this into release-1.0 as well?

authors: ayj geeknoid istio-testing ldemailly rshriram sdake zachgersh


text:
Manifest manipulation package

Utility package for moving between objects and manifest YAMLs.

The types need to be documented.  I'm not sure what the purpose is behind these types, which makes it difficult to review.

Finally coming back to clean this up with docs.

authors: ostromart rcernich

repo: istio/operator

license_source: bigquery


text:
BUG[UI] Inconsistency in text labels: sign in(sign-in) and sign up(sign-up)

Steps to reproduce:

Go to:
https://ita-social-projects.github.io/GreenCityClient/#/welcome
Click on 'sign-up' hyperlink
Verify that all text labels are written in the same way:
sign-in/sign-up or sign in/sign up
Actual result:
Text labels for sign in/sign up option are inconsistent and written in different ways: sign in, sign-in, sign up, sign-up
Expected result:
Text labels should be written in the same way everywhere: with or without hyphen '-', with the same capitalization of first letters
Environment:
OS: Windows 10
Browser: Firefox Mozilla 73.0.1 / 64-bit
Google Chrome 80.0.3987.132 / 64-bit

Not relevant

source: gharchive/issue

repo: ita-social-projects/GreenCity

license: MIT


text:
Admin/Main StreetCode block

Acceptance Criteria
The listed below fields are displayed and working according to described details.

"Номер Стріткоду" field should accept only number values
"Тип стріткоду" dropdown has two options

Постать (Selected by default)
Подія

If "Постать" was selected in the previous field - the next fields are "Ім'я" and "Прізвище" are displayed in one row
If "Подія" was selected in the previous field - the next field is"Назва події"
Date picker for "Роки життя/Дата або період події" is not prefilled, dates can be entered manually OR selected via calendar
If admin clicks on an arrow on dropdown "Теги" list of tags with a scroll should be opened with tags sorted in alphabetical order, no more than 10 tags are visible at the moment.
Admin is able to type in name of a tag in dropbox, so list of tags will be adjusted according to entered text.
Click on a tag adds it as a separate element below and clears text field. Added tags can be deleted by pressing a 'trash bin icon'
In a text field for "Teaser"  in the right bottom side quantity of symbols that can be entered, should be displayed.
By default, limitation is 450 symbols including spaces.
In case if the paragraph was entered in the text filed limitation should be changed to 400 symbols.
In field "Анімація" user can attach only one animated image in GIF format. User can either drag and drop file or press on 'paper clip' to select a file from File Exploler
In field "Зображення" user can attach UNLIMITED quantity of images. User can either drag and drop file or press on 'paper clip' to select a file from File Exploler
In field "Аудіо" user can attach only one file in MP3 fromat. User can either drag and drop file or press on 'paper clip' to select a file from File Exploler

Unlimited quantity of images?
How we will make a preview for tags?

UPD:
6. In a text field for "Teaser"  in the right bottom side quantity of symbols that can be entered, should be displayed.
By default, limitation is 450 520 symbols including spaces. In case if the paragraph was entered in the text filed limitation should be changed to 400 455 symbols.
NEW:
11. In field "URL" user is able to enter a text using latin alphabet, this text will be used as a text for URL, after https://streetcode.com.ua/
12. In field "Короткий опис (для звʼязків історії)" user is able to enter text, which will be displayed on a card of this StreetCode when it is displayed on other StreetCode's section "Зв'язки історії"
13. Symbols limitation for fields
Назва стріткоду - 100
Ім'я - 50
Прізвище - 50
Короткий опис (для зв'язків історії) - 33
URL - 100

UPD
5. Date picker for "Роки життя/Дата або період події" is not prefilled, dates can be entered manually OR selected via calendar
The first date is mandatory. Field "РОКИ" displays how user will see selected dates. This field can be edited after first date was selected, for example, to add a double date.

Update to "Teaser":
10. In a text field for "Teaser" in the right bottom side quantity of symbols that can be entered, should be displayed.
By default, limitation is 450 symbols including spaces.
In case if the paragraph was entered in the text field limitation should be changed to 400 symbols.
What was wrong?
Incorrect amount of valid symbols.
** NEW to "Teaser":**
10. In a text field for "Teaser" on the right bottom side quantity of symbols that can be entered, should be displayed.
By default, the limitation is 520 symbols including spaces (if there is 1 paragraph).
In case the paragraph was entered in the text field, the limitation should be changed to 455 symbols (if there are 2 paragraphs).

authors: AlbinaVorobiova vladnvp

repo: ita-social-projects/StreetCode


text:
[1002] Re-Iscrizione di soggetto già subentrato: Codice Fiscale variato

ambiente di PRODUZIONE - comune di FAENZA (039010)
idSoggettoANPR 19184678
il soggetto è stato iscritto per immigrazione (ws 1002) nel 2017, con codice fiscale numerico.
nel marzo 2019 è emigrato verso comune NON subentrato (ws 2003), sempre con CF numerico.
oggi ritorna, e nel frattempo gli è stato assegnato un codice fiscale alfanumerico, e la situazione è la seguente:

in AE ha un codice fiscale alfanumerico
in ANPR ha ancora il codice fiscale numerico

indipendentemente dal codice che si tenta di passare con l'iscrizione (abbiamo tentato sia col numerico che con l'alfanumerico) l'operazione viene bloccata a causa di errori di tipo EAxxx.
l'iscrizione è andata a buon fine attivando il GestioneCF '3' (nessuna validazione), ma adesso in ANPR il soggetto non ha più il codice fiscale e sembra non si riesca a variare con mutazioni successive... (secondo le vostre indicazione, procederemo con l'annullamento dell'iscrizione e ripartiremo).
questo che si porta come esempio è un caso specifico che se volete potete verificare partendo dall'idSoggettoANPR, ma ce ne sono altri similiari in attesa di essere passati.
non si vuole entrare nel merito del singolo caso, ma vorremmo avere le indicazioni precise da eseguire per allineare situazioni come queste, ovvero, quali informazioni indicare a livello "CF per ricerca", "CF" e "GestioneCF" per ottenere il risultato atteso.
grazie.
Alessandro Monopoli ADS

Buonasera,
l'identificativo operazione ANPR  del ws 5008 utilizzato per inserire il codice fiscale corretto è 115551524?
Se non fosse più disponibile è possibile riprovare l'allineamento e comunicare il relativo identificativo operazione ANPR?
Grazie

la comunicazione con idANPR 115551524 è stato l'ultimo tentativo di aggiornamento del codice fiscale, con le seguenti caratteristiche:

generalitaPerRicerca.codiceFiscale: il CF numerico
generalitaDaModificare.codiceFiscale: il CF alfanumerico
e ritorna l'errore:

<errore>
  <codiceErroreAnomalia>ES102</codiceErroreAnomalia>
  <tipoErroreAnomalia>E</tipoErroreAnomalia>
  <testoErroreAnomalia>Codice fiscale 99999999999 non presente o scheda archiviata</testoErroreAnomalia>
</errore>

questa mattina ho fatto un altro tentativo - che è andato a buon fine - con l'idANPR 115983157
la comunicazione aveva le seguenti caratteristiche:

generalitaPerRicerca.codiceFiscale: non valorizzato
generalitaDaModificare.codiceFiscale: il CF alfanumerico
gestioneCF: 0
ANPR è stato aggiornato con il CF alfanumerico, che risulta validato

la situazione è stata quindi gestita, tra vari tentativi, con questi passaggi:

iscrizione con ws1002, senza indicazione di codiceFiscale e gestioneCF '3'
mutazione con ws 5008, con la sola indicazione di generalitaDaModificare.codiceFiscale e gestioneCF '0'

mi chiedo se sia l'unico percorso da seguire, oppure se ci siano altre strade che permettano all'operatore di utilizzare i dati gia presenti nell'anagrafe locale e nell'ANPR (nel caso specifico, il codice fiscale).
grazie

Buongiorno,
sì, per questa casistica l'unica soluzione possibile è quella individuata.
Nei casi in cui un CF è diventato "collegato" il suo utilizzo è inibito da Agenzia Entrate in quanto non più attuale.
La richiesta di mutazione comprensiva del precedente CF non andava a buon fine in quanto la posizione corrente del cittadino in ANPR era priva di codice fiscale (da qui l'errore ES102).

ok. diremo al cliente di seguire queste indicazioni.
grazie

authors: AMonopoliADS azabatta

repo: italia/anpr


text:
Certificato di stato di famiglia con relazioni di parentela per un minore

Buongiorno,
abbiamo verificato che se si richiede un certificato intestato a un minore ma con un richiedente maggiorenne viene segnalato un errore, che sembrerebbe dipendere da questo vincolo:
"Il certificato non puo' essere emesso perche' il richiedente deve essere maggiorenne ed appartenente alla stessa famiglia anagrafica dell'intestatario"
In realtà l'art. 33 comma 1 del DPR 223/1989 prevede che:

Fatti salvi i divieti di comunicazione di dati, stabiliti da speciali disposizioni di legge, e quanto previsto dall'articolo 35, l'ufficiale di anagrafe rilascia a chiunque ne faccia richiesta, previa identificazione, i certificati concernenti la residenza, lo stato di famiglia degli iscritti nell'anagrafe nazionale della popolazione residente, nonché ogni altra informazione ivi contenuta.

Quindi è corretto che il richiedente sia sempre maggiorenne, e l'intestatario possa essere minorenne, ma il richiedente NON debba necessariamente appartenere al nucleo familiare dell'intestatario.
Potete procedere ad una modifica?
Grazie e a presto
Patrizia Saggini - Comune di Anzola dell'Emilia (BO)

Il certificato di stato di famiglia con relazioni di parentela può essere richiesto SOLO da un soggetto appartenente alla stessa famiglia, a prescindere dal fatto che l'intestatario della famiglia sia o meno maggiorenne, su  indicazione del Ministero dell'Interni. Suggerisco, pertanto, di chiarire questo aspetto con lo stesso Ministero e, a valle di questa verifica, non ci saranno problemi ad eseguire tutte le verifiche del caso.

Abbiamo verificato e mediato questa richiesta con il Ministero.
Si conferma la segnalazione bloccante quando una persona estranea al nucleo famigliare richiede un certificato di stato di famiglia con relazione di parentela.
Il comune avrà, in ogni caso, la possibilità di “eseguire” l’operazione se ravvisa la necessità di produrre comunque questo certificato.
A tal fine sarà necessario indicare il valore 1 nel campo forzaCertificazione, se si utilizzano i WS o specificare “Si” nel campo “Stampa certificato anche in presenza di segnalazioni:” se si utilizza la WA.
Verrà notificato attraverso questo canale quando sarà attivo negli ambienti di test-comuni e pre-subentro.

authors: gcarbonin mccalv psaggini


text:
[5008] Mutazione dati da WebApp - Operazione non effettuabile (Codice: 999)

Per il Comune di NASINO (SV) non riusciamo ad attribuire un codice fiscale a soggetto AIRE, direttamente da WebApp
Sia come variazione dati che come rettifica
Il soggetto non esiste in Agenzia delle Entrate e già in altri casi abbiamo utilizzato con successo questa procedura per l'attribuzione del codice fiscale
Questo il messaggio di errore:
Informazioni sull'operazione da fornire in caso di assistenza : data 2021-12-16 10:33:56 , idOperazioneANPR 725035571 (Codice: EN527)
Cosa possiamo verificare?
Grazie
Daniel Carenzo
C&C Sistemi Srl

Buongiorno
potete riprovare per favore ad eseguire l'operazione?

Buongiorno,
non avendo ricevuto ulteriori riscontri si chiude la issue.
Per ulteriori richieste di assistenza per questo problema o per altri relativi ad operazioni anagrafiche specifiche che potrebbero richiedere anche un contatto telefonico, si prega di contattare il numero verde 800863116.

authors: DanielCarenzo ncapozzi


text:
Discordanza tra tabelle Use Case

Buongiorno,
nell'ultima versione pubblicata trovo tra gli Use Case di test nel documento ANSC_Piano_Test.xlsx i seguenti:
2112 - Richiesta trascrizione atto di morte all'estero richiesto da privati
2113 - Richiesta trascrizione atto di morte all'estero richiesto da pubblica autorità
131110 - Trascrizione di atto di nascita avvenuta all’estero su richiesta dell’autorità diplomatica o consolare (DICHIARANTE MAGGIORENNE)
mentre nella tabella di decodifica (ANSC_03) trovo:
2212 - Richiesta trascrizione atto di morte all'estero richiesto da privati con istanza scritta
2213 - Richiesta trascrizione atto di morte all'estero richiesto da pubblica autorita'
1311 - Trascrizione di atto di nascita avvenuta all'estero su richiesta dell'autorita' diplomatica o consolare
sono in realtà gli stessi use case?
Inoltre nella cartella Mapping_casi_uso il file 3_dec_use_case.xlsx non contiene numerosi use case che sono invece presenti negli altri file (esempio 1331 - Trascrizione del decreto prefettizio di cambiamento del nome e cognome), presumo che quest'ultimo file sia ancora in fase di implementazione, è corretto?
Grazie.
Luca Bonini APKAPPA

Buongiorno,
verifichiamo e le facciamo sapere.

Buongiorno, i casi d'uso presenti sulla tabella delle decodifiche vengono rilasciati a gruppi, ad ogni nuova versione del sistema.
In particolare
2112 -> non presente nella tabella di decodifica
2113 ->non presente nella tabella di decodifica
131110 -> non presente nella tabella di decodifica
2212 -> Morte_006 non ancora rilasciato
2213 -> Morte_007 rilasciato con la versione 1.5.2
1311 -> Trascr_005 rilasciato con la versione v1.6.0
i casi d'uso non presenti al momento sulla tabella di decodifica, verranno codificati, aggiunti e rilasciati in una delle prossime versioni del sistema.

authors: LucaBonini64 anbatistini asqueglia

repo: italia/ansc


text:
Update fonts-loader.js

Tag

Grazie @giusnadd, ottimo!

authors: francescozaia giusnadd

repo: italia/bootstrap-italia


text:
Capture Standard I/O and output it to the parent process

Is it possible to catch Standard I/O (stdin, stdout, stderr) and write to the parent process, in my case, the terminal? It would make this a lot better CLI tool and sudo replacement for Windows than just a tool to elevate GUI programs when needed.

Not in this (deprecated) project, but butler elevate will relay stdout and stderr: https://github.com/itchio/butler - it does so by using named pipes on Windows.

repo: itchio/elevate

license: mit


text:
How can I change the separator between status lines in different panes?

As you can see in the below screenshot, I have two vim panes open.
The problem is the small gray rectangle that doesn't match the pane divider.

I can make it look like this:

by setting
highlight StatusLine cterm=NONE
highlight StatusLineNC cterm=NONE

But I'd really like it to match the pane divider. Any ideas on how I can do this?
Thanks!
P.S. This split UI is accomplished with;
set fillchars+=vert:│
highlight VertSplit ctermbg=NONE guibg=NONE

I'm afraid this is impossible. Which color do you expect it to be equal to? How about this configuration? Be sure to update lightline because I changed the highlight group names recently (but will never, I guess...).
hi! link StatusLineNC LightlineRight_normal_0
hi! link StatusLine LightlineRight_normal_0

Ok! The color in the first screenshot is correct, but it's not using the same divider character as the pane divider. So it's much wider. I want them to be the same width (skinny).
Closing. If anyone figures out a way, please let me know!

authors: flybayer itchyny


text:
Failed attempt to serve PyTorch model

Train & saving model code:
import torch
import math
from mlem.api import save

x = torch.linspace(-math.pi, math.pi, 2000)
y = torch.sin(x)

p = torch.tensor([1, 2, 3])
xx = x.unsqueeze(-1).pow(p)

model = torch.nn.Sequential(
    torch.nn.Linear(3, 1),
    torch.nn.Flatten(0, 1)
)
loss_fn = torch.nn.MSELoss(reduction='sum')
learning_rate = 1e-6

for t in range(2000):

    y_pred = model(xx)
    loss = loss_fn(y_pred, y)

    if t % 100 == 99:
        print(t, loss.item())

    model.zero_grad()
    loss.backward()

    with torch.no_grad():
        for param in model.parameters():
            param -= learning_rate * param.grad

linear_layer = model[0]

print(f'Result: y = {linear_layer.bias.item()} + {linear_layer.weight[:, 0].item()} x + {linear_layer.weight[:, 1].item()} x^2 + {linear_layer.weight[:, 2].item()} x^3')

save(
    model,
    'torch_model',
    sample_data=xx,
    description='Example of pytorch model'
)

Environment:

OS: Ubuntu 20.04
Python: 3.8.10
Python package manager: pip 22.1.2
mlem: 0.2.3
pytorch: 1.11.0
fastapi: 0.78.0
uvicorn: 0.17.6

Metafile of mlem model:
artifacts:
  data:
    hash: fa0c8b5bbc44d9a19b12d47850609ac5
    size: 1767
    uri: torch_model
description: Example of pytorch model
model_type:
  methods:
    predict:
      args:
      - name: data
        type_:
          dtype: float32
          shape:
          - null
          - 3
          type: torch
      name: predict
      returns:
        dtype: float32
        shape:
        - null
        type: torch
    torch_predict:
      args: []
      name: _call_impl
      returns:
        dtype: float32
        shape:
        - null
        type: torch
      varargs: input
      varkw: kwargs
  type: torch
object_type: model
requirements:
- module: torch
  version: 1.11.0+cu102

Command:
mlem serve torch_model fastapi

Ouptut/Error:
⏳ Loading model from .mlem/model/torch_model.mlem
Starting fastapi server...
❌ Unexpected error:
Please report it here: <https://github.com/iterative/mlem/issues>

Could you please give some simple example how to save and serve PyTorch models by mlem?

Please, add mlem --tb serve torch_model fastapi output. We'll take a look

Ok, that was a missing implementation on our end. Please try installing from #296

repo: iterative/mlem