text:
doc: why nullable of list item is set to true

Which issue does this PR close?

Closes #11625.
Rationale for this change

When working on issues related to #8708 there have been multiple PRs which dealt with the nullability of list item in accumulator state. This doc patch makes the reasoning of existing code explicit.
What changes are included in this PR?

Only doc comments are added. There are no code changes.
Aggregate functions which use data type of first argument:

ArrayAgg
NthValueAgg
Count

Aggregate functions which use data type of returned value:

BitwiseOperation
Sum

Are these changes tested?

Are there any user-facing changes?

Notes:

I felt inline comments made more sense here rather than adding this as part of docs for state_fields. This is primarily intended for the reader of code rather than the user of the library.
There is repetition of comment text in aggregate functions.

Please recommend changes to copy or critique this approach.

tbh I would be putting this to trait object instead of copying through methods.

Do you mean add the documentation to https://docs.rs/datafusion/latest/datafusion/logical_expr/trait.AggregateUDFImpl.html#method.state_fields ?

tbh I would be putting this to trait object instead of copying through methods.

Do you mean add the documentation to https://docs.rs/datafusion/latest/datafusion/logical_expr/trait.AggregateUDFImpl.html#method.state_fields ?

yep, it might be a better place imho. Especially if it related to all function implementations

tbh I would be putting this to trait object instead of copying through methods.

This does not belong in trait object because this affects only a few aggregate functions, not all of them.
For some aggregate functions the intermediate accumulator state often has:

a list of items and,
the type of the item is same as the first argument or the returned value

Field::new_list(
    format_state_name(args.name, "distinct_array_agg"),
    Field::new("item", args.input_type.clone(), true), // [1] should always be true
    true,  // [2] or false
)

At first glance it looked like nullable of the list item should be configurable. There were also multiple PRs in this direction before  we realized it was all unnecessary.
To get rid of the comment duplication, I'll instead move them to a markdown doc within functions-aggregate and link to it from the comments.

I pushed a minor copy edit and CI failed. Looking at the error logs it looks to me like it is not related to this change.

I pushed a minor copy edit and CI failed. Looking at the error logs it looks to me like it is not related to this change.

The clippy errors in CI are being tracked here - #11651.

I merged up from main to get the fix for the clippy errors

I merged up from main to get the fix for the clippy errors

@alamb Thank you.

Thanks @jcsherin

Thanks again - we can iterate on the docs in follow on PRs if there is more to do

Thanks for the review feedback - @alamb, @comphead and for prior discussions @jayzhan211.

authors: alamb comphead jcsherin


text:
to #10692: fix Parameter transfer problem when recover failed task an…

https://github.com/apache/dolphinscheduler/issues/10692

Codecov Report

Merging #10695 (4cdbb15) into dev (5855274) will decrease coverage by 0.09%.
The diff coverage is 6.77%.

:exclamation: Current head 4cdbb15 differs from pull request most recent head 16c59a4. Consider uploading reports for the commit 16c59a4 to get more accurate results

@@             Coverage Diff              @@
##                dev   #10695      +/-   ##
============================================
- Coverage     40.89%   40.80%   -0.10%
+ Complexity     4830     4826       -4
============================================
  Files           897      897
  Lines         36157    36208      +51
  Branches       4006     4009       +3
============================================
- Hits          14788    14774      -14
- Misses        19898    19965      +67
+ Partials       1471     1469       -2

Impacted Files
Coverage Δ

...r/server/master/runner/MasterSchedulerService.java
0.00% <ø> (ø)

.../server/master/runner/WorkflowExecuteRunnable.java
7.72% <0.00%> (-0.05%)
:arrow_down:

...nscheduler/service/process/ProcessServiceImpl.java
30.28% <ø> (ø)

...er/server/master/runner/task/SubTaskProcessor.java
24.18% <7.69%> (-23.86%)
:arrow_down:

...er/master/dispatch/host/assign/RandomSelector.java
77.77% <0.00%> (-5.56%)
:arrow_down:

...rver/master/runner/task/BlockingTaskProcessor.java
75.60% <0.00%> (-0.30%)
:arrow_down:

...eduler/api/service/impl/DataSourceServiceImpl.java
29.41% <0.00%> (ø)

.../dolphinscheduler/plugin/task/datax/DataxTask.java
0.00% <0.00%> (ø)

...cheduler/plugin/task/api/ShellCommandExecutor.java
0.00% <0.00%> (ø)

... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5855274...16c59a4. Read the comment docs.

PTAL @ruanwenjun @lenboo

@zwZjut May I ask whether you are still interested in following up with this PR?

source: gharchive/pull-request

authors: EricGao888 caishunfeng codecov-commenter zwZjut

repo: apache/dolphinscheduler

license_type: permissive

license_source: github-api


text:
[Typo] standardized license header.

Purpose of the pull request

Brief change log

Standardized license header.
Verify this pull request

This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:

(or)
If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

@FlechazoW Just curious, how did you find those misformatted files?

Codecov Report

Merging #14548 (7a96d31) into dev (8020c15) will decrease coverage by 0.02%.
The diff coverage is n/a.

:exclamation: Current head 7a96d31 differs from pull request most recent head 5fdfad0. Consider uploading reports for the commit 5fdfad0 to get more accurate results

@@             Coverage Diff              @@
##                dev   #14548      +/-   ##
============================================
- Coverage     38.73%   38.71%   -0.02%
+ Complexity     4578     4576       -2
============================================
  Files          1237     1237
  Lines         43537    43458      -79
  Branches       4823     4803      -20
============================================
- Hits          16862    16826      -36
+ Misses        24804    24760      -44
- Partials       1871     1872       +1

Impacted Files
Coverage Δ

...dolphinscheduler/rpc/common/ResponseEventType.java
0.00% <ø> (ø)

...scheduler/rpc/serializer/ProtoStuffSerializer.java
0.00% <ø> (ø)

...dolphinscheduler/rpc/serializer/RpcSerializer.java
0.00% <ø> (ø)

...r/plugin/task/python/PythonTaskChannelFactory.java
0.00% <ø> (ø)

... and 62 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

@FlechazoW Just curious, how did you find those misformatted files?

Accidentally found. But I went though a global search ";/*", and found these.

authors: EricGao888 FlechazoW codecov-commenter


text:
[Fix-14819][Master] Fix the full log path of logical task is not be set when task is dispatched.

ref #14819

Purpose of the pull request
Fix the full log path of logical task is not be set when task is dispatched.

Brief change log
set the full log path when logical task is dispatched.

Verify this pull request

Manually verified the change by testing locally.

Codecov Report

Merging #14821 (23b745d) into dev (294a622) will decrease coverage by 0.04%.
The diff coverage is 0.00%.

:exclamation: Current head 23b745d differs from pull request most recent head b9c5f6d. Consider uploading reports for the commit b9c5f6d to get more accurate results

@@             Coverage Diff              @@
##                dev   #14821      +/-   ##
============================================
- Coverage     38.68%   38.64%   -0.04%
+ Complexity     4493     4487       -6
============================================
  Files          1197     1197
  Lines         42591    42560      -31
  Branches       4744     4726      -18
============================================
- Hits          16477    16448      -29
- Misses        24291    24292       +1
+ Partials       1823     1820       -3

Files Changed
Coverage Δ

...c/LogicITaskInstanceDispatchOperationFunction.java
0.00% <0.00%> (ø)

... and 27 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

authors: codecov-commenter guowei-su


text:
[Fix][Bug][Dev]Switch version in pom.xml to dev-SNAPSHOT (#9223)

Purpose of the pull request

Versions in pom.xml files of dev branch is currently set to 2.0.4-SNAPSHOT, which is confusing. This PR switches the version from 2.0.4-SNAPSHOT to dev-SNAPSHOT.
This PR closes: #9223

Brief change log

As stated above in Purpose section.

Verify this pull request

Compile the code with cmd mvn -U install package -Prelease -Dmaven.test.skip=true and related output jars/packages should be of version dev-SNAPSHOT

Please do not merge this PR at this time. There's still something wrong with it.

Please do not merge this PR at this time. There's still something wrong with it.

Is there still WIP for this PR?

Please do not merge this PR at this time. There's still something wrong with it.

Is there still WIP for this PR?

Still WIP, some wired issue with log4j.properties. https://github.com/apache/dolphinscheduler/issues/9223#issuecomment-1080399656

I will test locally in my laptop to try this PR,

@EricGao888 I find out your PR does not change anything. Did you delete your branch? Fix-9223

@EricGao888 I find out your PR does not change anything. Did you delete your branch? Fix-9223

@zhongjiajie Sorry I mistakenly delete the branch last night. I will recover it later.

@EricGao888 I find out your PR does not change anything. Did you delete your branch? Fix-9223

@zhongjiajie Sorry I mistakenly delete the branch last night. I will recover it later.

I reopened the PR here: https://github.com/apache/dolphinscheduler/pull/9299


text:
docsupdate en docs

Proposed changes
Issue Number: close #xxx
Problem summary
Describe your changes.
Checklist(Required)

Does it affect the original behavior:

[ ] Yes
[x] No
[ ] I don't know

Has unit tests been added:

[ ] Yes
[ ] No
[x] No Need

Has document been added or modified:

[ ] Yes
[ ] No
[x] No Need

Does it need to update dependencies:

[ ] Yes
[x] No

Are there any changes that cannot be rolled back:

[ ] Yes (If Yes, please explain WHY)
[x] No

Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

LGTM

authors: httpshirley luzhijing

repo: apache/doris


text:
[refactor](remove unused code) remove thread pool manager

Proposed changes
Issue Number: close #xxx
Problem summary
Describe your changes.
Checklist(Required)

Does it affect the original behavior:

[ ] Yes
[ ] No
[ ] I don't know

Has unit tests been added:

[ ] Yes
[ ] No
[ ] No Need

Has document been added or modified:

[ ] Yes
[ ] No
[ ] No Need

Does it need to update dependencies:

[ ] Yes
[ ] No

Are there any changes that cannot be rolled back:

[ ] Yes (If Yes, please explain WHY)
[ ] No

Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 34.83 seconds
load time: 493 seconds
storage size: 17122303863 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230129024303_clickbench_pr_85894.html

authors: hello-stephen yiguolei


text:
fix lru cache handle field order

Proposed changes
For LRUHandle, all fields should be put ahead of key_data.

run buildall

the pipeline failed but seams irrelevant with pr

“For LRUHandle, all fields should be put ahead of key_data.”   why? Is there anything wrong if we keep the previous order? @hqx871

“For LRUHandle, all fields should be put ahead of key_data.” why? Is there anything wrong if we keep the previous order? @hqx871

The LRUHandle is allocated using malloc and starting from field key_data is for key data.
    size_t handle_size = sizeof(LRUHandle) - 1 + key.size();
    LRUHandle* e = reinterpret_cast<LRUHandle*>(malloc(handle_size));
    e->value = value;
    e->deleter = deleter;
    e->charge = charge;
    e->key_length = key.size();
    e->total_size = (_type == LRUCacheType::SIZE ? handle_size + charge : 1);
    DCHECK(_type == LRUCacheType::SIZE || bytes != -1) << " _type " << _type;
    e->bytes = (_type == LRUCacheType::SIZE ? handle_size + charge : handle_size + bytes);
    e->hash = hash;
    e->refs = 2; // one for the returned handle, one for LRUCache.
    e->next = e->prev = nullptr;
    e->in_cache = true;
    e->priority = priority;
    e->mem_tracker = tracker;
    e->type = _type;
    memcpy(e->key_data, key.data(), key.size());

This is a very deep hidden bug. Thanks for your contribution.


text:
Improvement add http_stream case

Proposed changes
add http_stream case

Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

authors: dataroaring zzzzzzzs


text:
feature Decouple DataDir from global StorageEngine instance

Proposed changes
Decouple DataDir from global StorageEngine instance
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall


text:
bugfx Add refresh hdfs vault logic && check whether latest fs is nullptr

Proposed changes
Issue Number: close #xxx
The latest fs logic would be replaced in #32910. This pr mainly prevents the nullptr coredump by accessing latest fs.

Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

run buildall


text:
opt add some profile for parquet reader and change meta cache config

Proposed changes
This PR mainly changes:

add new BE config enable_parquet_page_index
Default is true, if set to false, the parquet reader will not use page index to filter data.
This is only for debug purpose, in case sometimes the page index
filter wrong data.

Add new FE config max_hive_partition_table_cache_num
Separator from max_hive_table_cache_num. This config is used to set the max cache number
of partitionValuesCache, which is for partition values list of partitioned hive table.

Reduce the default expire time of meta cache from 86400 to 24400.
The hive table partitioned by day, if the expire time of cache is 86400,
it may always fetching the stale cache value after a day pass by.

run buildall

LGTM

authors: AshinGau morningman


text:
Fix fix json with duplicate key entry may result out of bound exception

#38146

run buildall


text:
Feature support agg state storage array/map/struct

Proposed changes
support agg state storage array/map/struct

run buildall

run buildall

run buildall


text:
fix try to drop function before create it

Proposed changes
Issue Number: close #xxx

run buildall


text:
Improve pick random backend as coordinator

What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)

Test

[ ] Regression test
[ ] Unit Test
[ ] Manual test (add detailed scripts or steps below)
[ ] No need to test or manual test. Explain why:

[ ] This is a refactor/code format and no logic has been changed.
[ ] Previous test can cover this change.
[ ] No code files have been changed.
[ ] Other reason

Behavior changed:

[ ] No.
[ ] Yes.

Does this need documentation?

[ ] No.
[ ] Yes.

Check List (For Reviewer who merge this PR)

[ ] Confirm the release note
[ ] Confirm test cases
[ ] Confirm document
[ ] Add branch pick label

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.
Please clearly describe your PR:

What problem was fixed (it's best to include specific error reporting information). How it was fixed.
Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
What features were added. Why was this function added?
Which code was refactored and why was this part of the code refactored?
Which functions were optimized and what is the difference before and after the optimization?

run buildall

authors: Thearas eldenmoon


text:
DRILL-6795: Upgrade Janino compiler from 2.7.6 to 3.0.9

For details please reffer DRILL-6795.

@vdiravka could you please review?

authors: arina-ielchiieva vvysotskyi

repo: apache/drill


text:
Fix Dockerfile instructions for Java 11

Description
Java 11 is the default now.
This PR has:

[x] been self-reviewed.

Hello @liam-verta we have made many improvements on the Dockerfile including the README which also fixes the problem you mentioned. I will close this PR. Thank you again for your work.

repo: apache/druid


text:
Web console: grab warnings from correct key + test

Make sure to grab the warnings from the correct key warnings not warningReport. Add test.

To be clear: this is the only change that matters: https://github.com/apache/druid/pull/12977/files#diff-2cf6e2ec08ef02fd25529220eb3e3b92c63f25ab7b8fd19bf2313563365ba400R221 the rest is tests and window dressing


text:
Fix hardcoded version in pom file

Fix hardcoded version in pom file. This could break builds if the version changes.

This PR has:

[x] been self-reviewed.

[ ] using the concurrency checklist (Remove this item if the PR doesn't have any relation to concurrency.)

[ ] added documentation for new or modified features or behaviors.
[ ] a release note entry in the PR description.
[ ] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
[ ] added or updated version, license, or notice information in licenses.yaml
[ ] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
[ ] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
[ ] added integration tests.
[ ] been tested in a test Druid cluster.

Thanks for the fix @adarshsanjeev !!

authors: adarshsanjeev cryptoe


text:
Revert "[CVE Fixes] Update version of Nimbus.jose.jwt"

Reverts apache/druid#16320
Updating nimbus to version 9+ is causing HTTP ERROR 500 java.lang.NoSuchMethodError: 'net.minidev.json.JSONObject com.nimbusds.jwt.JWTClaimsSet.toJSONObject()'
Refer to https://github.com/SAP/cloud-security-services-integration-library/issues/429#issuecomment-1501601312 for more details.
We would need to upgrade other libraries as well for updating nimbus.jose.jwt

@pagrawal10 Whats other libraries need to get bumped up ?

We need to bump up druid-pac4j as well. I have created a PR for the same: https://github.com/apache/druid/pull/16567
We would need to add it as a different extension as that would not be compatible with JDK8.
pac4j versions > 5 are compatible with only JDK 11 and above
import needed is also different for pac4j v4.5.7 and pac4j v5.7.3 :
import org.pac4j.jee.context.JEEContext;
vs
import org.pac4j.core.context.JEEContext;


text:
Fixed the non deterministic test testSerdeWithInputFormat

Fixed a non deterministic test in org.apache.druid.indexing.kafka.supervisor.KafkaSupervisorSpecTest.testSerdeWithInputFormat

Steps to reproduce
To reproduce the problem, first build the module kafka-indexing-service:

mvn install -pl extensions-core/kafka-indexing-service -am -DskipTests

Then, run the regular test:

mvn -pl extensions-core/kafka-indexing-service test -Dtest=org.apache.druid.indexing.kafka.supervisor.KafkaSupervisorSpecTest#testSerdeWithInputFormat

To identify the flaky test, execute the following nondex command:

mvn -pl extensions-core/kafka-indexing-service edu.illinois:nondex-maven-plugin:2.1.7:nondex -Dtest=org.apache.druid.indexing.kafka.supervisor.KafkaSupervisorSpecTest#testSerdeWithInputFormat

Description
The testSerdeWithInputFormat was producing non-deterministic output because the JSON object used in the test did not include a parser that enforced a specific order, unlike other tests. Due to the inherent non-deterministic nature of JSON serialization, this resulted in inconsistent outputs. The dimension spec array gave non deterministic order on different runs as follow-
expected: "dimensionExclusions":["__time","value_max","count","value_min","value_sum","value]","timestamp"]
actual: "dimensionExclusions":["value_sum","value","count","__time","value_min","value_max]","timestamp"] .
The fix involves adding a parser to the JSON like the other tests to ensure a consistent order.

This PR has:

[x] been self-reviewed.
[ ] added documentation for new or modified features or behaviors.
[ ] a release note entry in the PR description.
[ ] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
[ ] added or updated version, license, or notice information in licenses.yaml
[ ] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
[ ] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
[ ] added integration tests.
[ ] been tested in a test Druid cluster.

Initially, I had resolved the issue by sorting the contents of the JSON. However, since the ordering of elements is important, I later updated the solution to align with how other tests handled ordering. The parser we were using provided a deterministic order, which ensured the test passed.
Now that the parser is deprecated, one possible solution could be to avoid relying on string equality for comparisons and instead perform a direct JSON comparison. What is your opinion on this one?


text:
No such extension org.apache.dubbo.metadata.store.MetadataReportFactory by name zookeeper

Environment

Dubbo version: 2.7.3
Java version: 1.8

在clone了最新代码后修改了org.apache.dubbo.demo.provider.Application中的main方法，具体如下：
@Bean
public RegistryConfig registryConfig() {
RegistryConfig registryConfig = new RegistryConfig();
//            registryConfig.setAddress("multicast://224.5.6.7:1234");
registryConfig.setAddress("zookeeper://127.0.0.1:2181");
return registryConfig;
}
然后执行main方法后一直报错，目前dubbo-demo下实例都无法正常运行，请大家指教一下这个是什么原因造成的，报错信息如下：
Exception in thread "main" java.lang.IllegalStateException: No such extension org.apache.dubbo.metadata.store.MetadataReportFactory by name zookeeper
at org.apache.dubbo.common.extension.ExtensionLoader.findException(ExtensionLoader.java:520)
at org.apache.dubbo.common.extension.ExtensionLoader.createExtension(ExtensionLoader.java:527)
at org.apache.dubbo.common.extension.ExtensionLoader.getExtension(ExtensionLoader.java:351)
at org.apache.dubbo.metadata.store.MetadataReportFactory$Adaptive.getMetadataReport(MetadataReportFactory$Adaptive.java)
at org.apache.dubbo.metadata.integration.MetadataReportService.(MetadataReportService.java:69)
at org.apache.dubbo.metadata.integration.MetadataReportService.instance(MetadataReportService.java:82)
at org.apache.dubbo.config.AbstractInterfaceConfig.getMetadataReportService(AbstractInterfaceConfig.java:433)
at org.apache.dubbo.config.ServiceConfig.doExportUrlsFor1Protocol(ServiceConfig.java:622)
at org.apache.dubbo.config.ServiceConfig.doExportUrls(ServiceConfig.java:457)
at org.apache.dubbo.config.ServiceConfig.doExport(ServiceConfig.java:415)
at org.apache.dubbo.config.ServiceConfig.export(ServiceConfig.java:378)
at org.apache.dubbo.config.spring.ServiceBean.export(ServiceBean.java:336)
at org.apache.dubbo.config.spring.ServiceBean.onApplicationEvent(ServiceBean.java:114)
at org.apache.dubbo.config.spring.ServiceBean.onApplicationEvent(ServiceBean.java:60)
at org.springframework.context.event.SimpleApplicationEventMulticaster.doInvokeListener(SimpleApplicationEventMulticaster.java:172)
at org.springframework.context.event.SimpleApplicationEventMulticaster.invokeListener(SimpleApplicationEventMulticaster.java:165)
at org.springframework.context.event.SimpleApplicationEventMulticaster.multicastEvent(SimpleApplicationEventMulticaster.java:139)
at org.springframework.context.support.AbstractApplicationContext.publishEvent(AbstractApplicationContext.java:393)
at org.springframework.context.support.AbstractApplicationContext.publishEvent(AbstractApplicationContext.java:347)
at org.springframework.context.support.AbstractApplicationContext.finishRefresh(AbstractApplicationContext.java:883)
at org.springframework.context.support.AbstractApplicationContext.refresh(AbstractApplicationContext.java:546)
at org.springframework.context.support.ClassPathXmlApplicationContext.(ClassPathXmlApplicationContext.java:139)
at org.springframework.context.support.ClassPathXmlApplicationContext.(ClassPathXmlApplicationContext.java:83)
at org.apache.dubbo.demo.provider.Application.main(Application.java:28)

应该是依赖没有正确的添加，检查下 maven 依赖，看下的这个依赖是否存在。
<groupId>org.apache.dubbo</groupId>
<artifactId>dubbo-metadata-report-zookeeper</artifactId>

@web1992 pom中有加这个依赖。

尝试重新build demo，可能还是依赖问题。你添加了metadata report配置了吗？

@chickenlj 重新build了demo，在dubbo-provider.xml中也有加如下配置：
<dubbo:config-center address="zookeeper://127.0.0.1:2181"/>
<dubbo:metadata-report  address="zookeeper://127.0.0.1:2181"/>
还是会报那个错。

@web1992@chickenlj 感谢二位，重新把最新的代码clone到本地，然后在dubbo-demo-xml和dubbo-demo-annotation的pom文件中加入了

org.apache.dubbo
dubbo-metadata-report-zookeeper
${project.parent.version}

在dubbo-provider.xml和dubbo-provider.properties中分别加入了如下配置：dubbo.configcenter=zookeeper://127.0.0.1:2181
dubbo.metadata-report.address=zookeeper://127.0.0.1:2181
然后成功运行，并在dubbo-admin的管理界面及服务的详细页面元数据部分能正常显示。
总结来说应该还是配置和pom的原因。

source: gharchive/issue

authors: chickenlj web1992 zpLiuHH

repo: apache/dubbo


text:
[Bug]  xAxis.axisPointer.label sometimes does not disappear

Version
5.3.2
Link to Minimal Reproduction
No response
Steps to Reproduce
https://echarts.apache.org/examples/zh/editor.html?c=line-tooltip-touch
Current Behavior
Swiping 'handel' repeatedly causes the label to stay on the page.
Expected Behavior
https://user-images.githubusercontent.com/8214804/169851721-47d2a6e1-7a24-43b5-9b8a-744831b7cd0b.mp4
Environment
- OS: win10
- Browser: firefox
- Framework:

Any additional comments?
No response

This seems to be an old question,try myChart.dispatchAction({type:'updateAxisPointer'})

repo: apache/echarts


text:
[Bug] Unable to distinguish the disabled legend in the dark mode

Version
5.3.0
Link to Minimal Reproduction
https://codepen.io/Harshitha19/pen/wvmgbeZ
Steps to Reproduce

Open the sample and click on any one of the legends to toggle the series line.
Observe that it is hard to distinguish between the enabled legend text and the disabled legend text.

Current Behavior
There is hardly any difference between enabled and disabled legend text in the dark theme.
Expected Behavior
Disabled text color should be applied according to the theme selected.
Environment
- OS:
- Browser:
- Framework:

Any additional comments?
No response

Hi, This is something we are also looking for the solution. Any suggestions/ workaround in this regard would be much appreciated.

They seems to have changed the way they store the themes, and so the theme builder is not working anymore...
In the meantime, you can "update" the color by hand:
import dark from 'echarts/lib/theme/dark';
dark.legend.textStyle.color = "#ffffff";

Or you can register a new theme, and specify the correct color:
echarts.registerTheme("xdark", {
    legend: {
        textStyle: {
            color: "#ffffff"
        }
    },
});

authors: Caceresenzo MNHarshitha RahulVishK


text:
[ISSUE #3402] Improve Trace class

Fixes #3402
Motivation
Explain the content here.
Explain why you want to make the changes and what problem you're trying to solve.
Modifications
Describe the modifications you've done.
Documentation

Does this pull request introduce a new feature? (no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
If a feature is not applicable for documentation, explain why?
If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

Please check CI failure~

Based on our discussion in https://github.com/apache/eventmesh/pull/3632, the review comment at https://github.com/apache/eventmesh/pull/3632#pullrequestreview-1434053124 pointed out that the original issue is redundant and invalid. Thank you very much for your contribution. Please feel free to select other valuable issues to work on.

repo: apache/eventmesh


text:
add Merge Strategy section to README

@ptuomola @xurror @awasum @avikganguly01 @thesmallstar @percyashu @fynmanoj @vidakovic @conradsp @Grandolf49 how about (something like) this to document the recommended Merge Strategy for this project? Your review feedback, if any, most welcome, of course.

@vorburger  should we not update the github PR template then? which says

LGTM. Just check the typo as the last line: Multiple commits in singl PR make sense in certain cases (e.g. branch backports).

Fixed, using Edit on GitHub UI. Which makes this PR itself now have 2 commits, and I'm too lazy to pull it locally and squash, which makes this an example of a PR that whichever committers merges this should squash... as this documents. :smile_cat:
PS: @awasum et al just just use GitHub Suggestions to propose changes directly! (Instead of only "commenting".)

Fixed, using Edit on GitHub UI. Which makes this PR itself now have 2 commits, and I'm too lazy to pull it locally and squash, which makes this an example of a PR that whichever committers merges this should squash... as this documents. 😸
looks like we are about to have 3 commits as an example now :P

@vorburger should we not update the github PR template then? which says

great point / feedback, I didn't think of that! Thanks - done now.

looks like we are about to have 3 commits as an example now :P

@thesmallstar yeah, you made me pull it after all (or perhaps I'm too stupid to know how to edit multiple files on GitHub's Web UI).

@vorburger  this failed due to connection error (but I think you can merge this anyways)...

authors: thesmallstar vorburger

repo: apache/fineract


text:
[FLINK-15618] Remove useless JobTimeoutException

What is the purpose of the change
This pull request removes useless JobTimeoutException
Brief change log

Remove useless JobTimeoutException

Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (yes / no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
The serializers: (yes / no / don't know)
The runtime per-record code paths (performance sensitive): (yes / no / don't know)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / no / don't know)
The S3 file system connector: (yes / no / don't know)

Documentation

Does this pull request introduce a new feature? (yes / no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

cc @zentol

repo: apache/flink


text:
[FLINK-15904][connectors/kafka] Make Kafka Consumer work with activated "disableGenericTypes()"

What is the purpose of the change
Currently, class KafkaTopic KafkaTopicPartition uses GenericTypeInformation during the serialization in the unionOffsetStates inside the KafkaConsumer. Which prevents any flink application to disableGenericTypes.
We can still continue to use compatible KryoSerialization, but by specifying serialization explicitly we can avoid check on generic types.
Brief change log

Replace TypeHint in the state initialization by explicit TupleSerializer which takes KryoSerializer as the parameter.

Verifying this change
I suppose that test FlinkKafkaConsumerBaseMigrationTest#testRestoreFailsWithNonEmptyPreFlink13StatesIfDiscoveryEnabled will test it against several states savepoints from the previous version.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): no
The public API, i.e., is any changed class annotated with @Public(Evolving): no
The serializers: don't know
The runtime per-record code paths (performance sensitive): no
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: no
The S3 file system connector: no

Documentation

Does this pull request introduce a new feature? No

@flinkbot run travis

@JTaky I like how you put the code in a separate method! I pushed a commit that simplifies the test quite a bit. Could you check if that's ok for you?

@JTaky I like how you put the code in a separate method! I pushed a commit that simplifies the test quite a bit. Could you check if that's ok for you?

Thanks for the change!
Have only a single optional comment about UT error message.

Thanks for working on this! 😃 I merged.

authors: JTaky aljoscha


text:
[release-1.12][FLINK-20114][connector/kafka,common] Fix a few KafkaSource-related bugs

Backport of https://github.com/apache/flink/pull/15161

CC: @lindong28

Unrelated e2e test failure:
2021-05-05T19:51:17.8939009Z May 05 19:51:17 [FAIL] 'Running Kerberized YARN application on Docker test (default input)' failed after 6 minutes and 49 seconds! Test exited with exit code 1

@flinkbot run azure

Thank you @tweise for creating the PR! LGTM.
I have verified that this PR only contains changes from https://github.com/apache/flink/pull/15161. And this PR contains all bug fixes that are in https://github.com/apache/flink/pull/15161 but not currently in the release-1.12 branch.

@flinkbot run azure

@tillrohrmann @AHeise there seems to be some level of flakiness in the AZP runs and the results are not consistent and contain unrelated failures. What's the recommended way to verify that this PR does not add additional issues? Where can I see the build status of the release-1.12 branch HEAD?

I just deactivated two e2e tests (Kerberos+Yarn) on release-1.12 (couple of hours ago), so it would make sense to rebase. If the Kafka-related (e2e) test pass, it's okay to merge.

@AHeise thanks for the suggestion. e2e tests pass after rebase.
test_ci python failed in 2 out of 4 AZP runs, that's unrelated to this PR.
Merging..

authors: AHeise lindong28 tweise


text:
[FLINK-22710][formats] Explicitly set the bucket assigner to avoid writing into two buckets in the tests

What is the purpose of the change
This PR fixes that some tests use the default DateTimeBucketAssigner which partitions the data into buckets according to the hour, if the test are executed at the boundary of an hour, the data might be write into two buckets, but the tests will validate that there is only one bucket.
Brief change log

4ecced5f26139215ae8555cc358291c46e9c7bfb adds a default UniqueBucketAssigner and configure the bucket assigner explicitly.

Verifying this change
This change is already covered by existing tests.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): no
The public API, i.e., is any changed class annotated with @Public(Evolving): no
The serializers: no
The runtime per-record code paths (performance sensitive): no
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
The S3 file system connector: no

Documentation

Does this pull request introduce a new feature? no
If yes, how is the feature documented? not applicable

Very thanks @guoweiM for the review! I updated the PR according to the comments~

@flinkbot run azure

Very thanks @guoweiM  for the review! I'll merge the code~


text:
[hotfix] fix PageRank example to run with no args; some doc fixes

This PR includes a fix for the java PageRank example to retrieve the required parameter numPages  when run with no arguments and some documentation fixes.

+1 good to merge

Thanks, merging.

authors: rmetzger vasia


text:
[Hotfix][streaming] Fix a typo.

What is the purpose of the change
fix a typo
Brief change log
(for example:)

The TaskInfo is stored in the blob store on job creation time as a persistent artifact
Deployments RPC transmits only the blob storage reference
TaskManagers retrieve the TaskInfo from the blob cache

Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)

Added integration tests for end-to-end deployment with large payloads (100MB)
Extended integration test for recovery after master (JobManager) failure
Added test that validates that TaskInfo is transferred only once across recoveries
Manually verified the change by running a 4 node cluser with 2 JobManagers and 4 TaskManagers, a stateful streaming program, and killing one JobManager and two TaskManagers during the execution, verifying that recovery happens correctly.

Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (yes / no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
The serializers: (yes / no / don't know)
The runtime per-record code paths (performance sensitive): (yes / no / don't know)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know)
The S3 file system connector: (yes / no / don't know)

Documentation

Does this pull request introduce a new feature? (yes / no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

Hi, @alpinegizmo . Could you help me to check it ? Thank you.


text:
[BP-1.18][FLINK-33531][python] Remove cython upper bounds

This is a cherry pick backport of https://github.com/apache/flink/pull/23755 to 1.18

//cc @JingGe
since it was reproduced for 1.18 at
https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=55583&view=logs&j=3e4dd1a2-fe2f-5e5d-a581-48087e718d53&t=b4612f28-e3b5-5853-8a8b-610ae894217a&l=27725

@snuyanzin thanks for the heads-up. Let's add it into 1.18.1 release

thanks for taking a look

authors: JingGe snuyanzin


text:
[FLINK-1925] Fixes blocking method submitTask on the TM

The submitTask method which processes the SubmitTask message blocks while downloading the task jars from the JobManager. Depending on the number of TMs and jars, this can take a long time.
In order to get rid of the blocking call the submitTask method is split up into two phases: TDD reception with eager acknowledgement and TDD instantiation with a subsequent state update message. The TDD instantiation is executed concurrently in a future. Upon finishing the instantiation, an UpdateTaskExecutionState message with ExecutionState.RUNNING is sent to the JM. This implies that the state of the Execution is not directly set to RUNNING by the SubmitTask future handler which is created in Execution.deployToSlot.

Looks god modulo some comments. The most critical being the concurrent Map one.

Thanks for reviewing the code @StephanEwen. I addressed your comments and updated the PR.

Looks good. Will merge this in my next batch, since I am building code on top anyways...

authors: StephanEwen tillrohrmann


text:
FLUME-3152 Add Flume Metric for Backup Checkpoint Errors

Added a new metric to the file channel
new test case added
build with tests was successful

@szaboferee , thanks for the added test case.
The change looks good to me, 👍

authors: adenes szaboferee

repo: apache/flume


text:
GEODE-7051: Upgrade to log4j 2.12.0

Upgrade to log4j 2.12.0 and mark log4j-core dependency as optional in geode-core.

UnitTestOpenJDK11 failed due to PowerMock which has nothing to do with Log4j. There are no tests involving Log4j that use PowerMock.

@rhoughton-pivot I can pair with you to change the version strings. Let me know when you're available.

Note: @rhoughton-pivot has given me the go-ahead to commit this PR as is.

The UpgradeTestOpenJDK11 failure is a hang in WANRollingUpgradeMultipleReceiversDefinedInClusterConfiguration which Bruce reported on this morning.

repo: apache/geode


text:
GEODE-7403: Test LogConsumer with log levels in all VM types

Adds new tests for all log levels within all DUnit VM types to verify
that the DUnit grep for suspect strings mechanism works as expected.
I'm seeing the locator VM log a stack trace for "Context initialization
failed" with a root cause of ClassNotFoundException LogService.
For some reason, the dunit grep for suspect strings is ignoring it.
This PR adds unit and dunit tests to ensure that the string itself can be
matched by LogConsumer.
GEODE-7403 is closed, but this test is still good to have.

Adding more tests


text:
[#4171] feat(docs): Add Paimon Catalog doc

What changes were proposed in this pull request?
Add Paimon Catalog doc
Why are the changes needed?
Fix: https://github.com/apache/gravitino/issues/4171
Does this PR introduce any user-facing change?
No.
How was this patch tested?
No testing required.

comments have been addressed. cc @FANNG1

merged to main, thanks for your contribution!

repo: apache/gravitino


text:
Migrate from CircleCI

We plan to move off the CircleCI system.
We can use GitHub actions for a lot of things.
If we need more than that, we can move onto the Apache Software Foundation's Jenkins instance. Our rationale for using that is that a couple of the current maintainers (@Poundex and @jonnybot0) have some background with Jenkins, which also has a nice Groovy DSL for jobs.
The Apache Guide on Jenkins says we'll need access from the PMC. It looks like I can currently login to Jenkins and even create objects in the Groovy section.
Will look at replicating many of the build steps in Circle CI to GitHub actions first, as that's the least friction

Did a basic PoC git GitHub actions to run the check job, which seemed to work okay. https://github.com/apache/groovy-geb/actions/runs/12188231782
I had a go at using Reusable actions for much of the rest, but I don't think I've quite got it right. See:

Failed run: https://github.com/apache/groovy-geb/actions/runs/12188668188
Source: https://github.com/apache/groovy-geb/tree/refs/heads/task/213-github-actions-for-ci
Docs: https://docs.github.com/en/actions/sharing-automations/avoiding-duplication

I'll need to dig into things a bit more later. Leaving this note here for future me to pick up where I left off.

The publishing of snapshots is now handled by this Jenkins build (may require asf login):
https://ci-builds.apache.org/job/Groovy/job/Geb%20snapshot%20build/

Snapshot artifacts are published here:
https://repository.apache.org/content/repositories/snapshots/org/apache/groovy/geb/

Note: I moved a couple of PRs fairly quickly, so some of this may change once the dust settles and folks have a chance to review.

Hey, Paul. I actually appreciate you moving some of this quickly. Wrapping up for the end of year left me with relatively little time for review, but I'm going to be doing some catch-up today. If there's any feedback that I can quickly action, I'll probably just raise a PR. If it needs more discussion, I may raise a post or comment here as appropriate.

So, running check pretty well covers everything that was in the manual and check steps. That step is definitely taking a lot longer, so it may be needful to break it up into distinct steps as it was in CircleCI... gonna need to do a little more analysis before I shoot from the hip next time. :/

repo: apache/groovy-geb


text:
GROOVY-10112: IndexedProperty AST transform should only provide the g…

…etter for immutable fields

Merged. Thanks!

repo: apache/groovy


text:
HADOOP-16380: test to show that it is the root directory where the "tombstone problem" can be replicated

You don't get it on deeper paths because the full prefix is returned "/test/dir/deleted", which doesn't match the short name of a tombstone.
this helps explain why we only see it on the root dir tests.
Change-Id: I6e00b39684b7f3ff76eb84ee877128fa01c0f2bc
This is not the fix
This test replicates the problem as seen in the IDE when debugging root dir test failures

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
165
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+1
mvninstall
1399
trunk passed

+1
compile
36
trunk passed

+1
checkstyle
22
trunk passed

+1
mvnsite
41
trunk passed

+1
shadedclient
807
branch has no errors when building and testing our client artifacts.

+1
javadoc
28
trunk passed

0
spotbugs
69
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
66
trunk passed

_ Patch Compile Tests _

+1
mvninstall
33
the patch passed

+1
compile
30
the patch passed

+1
javac
30
the patch passed

+1
checkstyle
18
the patch passed

+1
mvnsite
35
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
843
patch has no errors when building and testing our client artifacts.

+1
javadoc
23
the patch passed

+1
findbugs
65
the patch passed

_ Other Tests _

+1
unit
282
hadoop-aws in the patch passed.

+1
asflicense
28
The patch does not generate ASF License warnings.

4032

Subsystem
Report/Notes

Docker
Client=18.09.7 Server=18.09.5 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1079/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1079

JIRA Issue
HADOOP-16380

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux ebf201665f4f 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 9cec023

Default Java
1.8.0_212

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1079/1/testReport/

Max. process+thread count
318 (vs. ulimit of 5500)

modules
C: hadoop-tools/hadoop-aws U: hadoop-tools/hadoop-aws

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1079/1/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

thanks Steve for creating a test that reproduces the issue. I'm looking into how to solve this.

the tests will pass if I change the return new S3AFileStatus(Tristate.TRUE, path, username); to return new S3AFileStatus(Tristate.FALSE, path, username); at org.apache.hadoop.fs.s3a.S3AFileSystem#s3GetFileStatus (org/apache/hadoop/fs/s3a/S3AFileSystem.java:2760). I'll update my PR with a test against this.

OK. Is there any other issue which this problem creates.
I'm worried about whether if there's a file /test/dir1/file.avro under, say, /test, and there's a tombstone for /test, will the file get found in a listing, and is that behaviour different in the root path from elsewhere?. I know a listFiles() is likely to find it, I'd expect a treewalk with listStatus() will miss it just because the topmost directory listing won't find the /test dir to scan

I have to create a test to be sure. We created a tad bit complex to just say no or yes to your question :(

OK. Is there any other issue which this problem creates.
I'm worried about whether if there's a file /test/dir1/file.avro under, say, /test, and there's a tombstone for /test, will the file get found in a listing, and is that behaviour different in the root path from elsewhere?. I know a listFiles() is likely to find it, I'd expect a treewalk with listStatus() will miss it just because the topmost directory listing won't find the /test dir to scan

If there's a tombstone for /test it won't be visible, but we should expect that behaviour.
This is why we have tombstone expiry. So eventually we don't have this problem - if /test/ has bee created by an OOB operation (I guess that's why we have a tombstone and still have the directory structure behind it) then the metadata and tombstone expiry will be eventually solved.
The problem starts to surface if we have a /test1/ tombstoned, and we also have /test9, or even /test2/dir1/file.avro. I will write a test for that.

Also note that
    // PUT child to store
    Path child = new Path(firstPath, "child");
    StoreContext ctx = fs.createStoreContext();
    String childKey = ctx.pathToKey(child);
    String rootKey = ctx.pathToKey(root);
    AmazonS3 s3 = fs.getAmazonS3ClientForTesting("LIST");

    createEmptyObject(fs, childKey);

is an out of band operation by definition in your test.
The test will fail even without it - commenting out
      //createEmptyObject(fs, childKey);

and the check for it:
      // the listing has the firstDir path as a prefix, because of the child
      //Assertions.assertThat(listing.getCommonPrefixes())
      //    .describedAs("The prefixes of a LIST of %s", root)
       //   .contains(firstDir + "/");

Why do you add a child object to the store?

I'm explicitly adding a child as that was the situation I was seeing; if you can replicate the problem in a different way, then that'd be another piece of information.
The key point: a file under a tombstone was enough to convince the client that the directory was empty

superceded by #1123

authors: bgaborg hadoop-yetus steveloughran

repo: apache/hadoop


text:
HDFS-15925. The lack of packet-level mirrorError state synchronization in BlockReceiver can cause the HDFS client to hang

I propose a fix for HDFS-15925.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m  2s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
35m 50s

trunk passed

+1 :green_heart:
compile
1m 24s

trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
compile
1m 15s

trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

+1 :green_heart:
checkstyle
1m  0s

trunk passed

+1 :green_heart:
mvnsite
1m 28s

trunk passed

+1 :green_heart:
javadoc
0m 59s

trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
1m 26s

trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

+1 :green_heart:
spotbugs
3m 22s

trunk passed

+1 :green_heart:
shadedclient
18m 49s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 15s

the patch passed

+1 :green_heart:
compile
1m 17s

the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javac
1m 17s

the patch passed

+1 :green_heart:
compile
1m  7s

the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

+1 :green_heart:
javac
1m  7s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 53s
/results-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs-project/hadoop-hdfs: The patch generated 4 new + 42 unchanged - 2 fixed = 46 total (was 44)

+1 :green_heart:
mvnsite
1m 13s

the patch passed

+1 :green_heart:
javadoc
0m 46s

the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
1m 16s

the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

+1 :green_heart:
spotbugs
3m 17s

the patch passed

+1 :green_heart:
shadedclient
18m 48s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
377m 31s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 41s

The patch does not generate ASF License warnings.

471m 56s

Reason
Tests

Failed junit tests
hadoop.hdfs.server.namenode.ha.TestBootstrapStandby

hadoop.hdfs.TestClientProtocolForPipelineRecovery

hadoop.hdfs.TestDFSShell

hadoop.fs.viewfs.TestViewFileSystemOverloadSchemeHdfsFileSystemContract

hadoop.hdfs.server.namenode.ha.TestEditLogTailer

hadoop.hdfs.server.datanode.fsdataset.impl.TestFsVolumeList

hadoop.hdfs.server.namenode.snapshot.TestNestedSnapshots

hadoop.hdfs.server.datanode.TestBlockScanner

hadoop.fs.viewfs.TestViewFileSystemOverloadSchemeWithHdfsScheme

hadoop.hdfs.server.datanode.TestBlockRecovery

hadoop.hdfs.server.namenode.TestDecommissioningStatusWithBackoffMonitor

hadoop.hdfs.TestSnapshotCommands

hadoop.hdfs.server.datanode.TestDirectoryScanner

hadoop.hdfs.TestPersistBlocks

hadoop.hdfs.tools.offlineEditsViewer.TestOfflineEditsViewer

hadoop.hdfs.server.namenode.TestDecommissioningStatus

hadoop.hdfs.server.datanode.fsdataset.impl.TestFsDatasetImpl

hadoop.hdfs.server.diskbalancer.command.TestDiskBalancerCommand

hadoop.hdfs.server.namenode.ha.TestSeveralNameNodes

hadoop.fs.viewfs.TestViewFSOverloadSchemeWithMountTableConfigInHDFS

hadoop.hdfs.server.namenode.TestNamenodeStorageDirectives

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2821/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2821

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux 9116a565a8ed 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / d34f6b68f57c575e6c8bf0ec90518ceca24a793e

Default Java
Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2821/1/testReport/

Max. process+thread count
2154 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2821/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

@functioner Thanks for report and fix.
Could you please add a test case?

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 52s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
49m 43s

trunk passed

+1 :green_heart:
compile
1m 31s

trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
compile
1m 18s

trunk passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
checkstyle
1m 12s

trunk passed

+1 :green_heart:
mvnsite
1m 30s

trunk passed

+1 :green_heart:
javadoc
1m 15s

trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
1m 36s

trunk passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
spotbugs
3m 26s

trunk passed

+1 :green_heart:
shadedclient
36m  3s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 15s

the patch passed

+1 :green_heart:
compile
1m 18s

the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javac
1m 18s

the patch passed

+1 :green_heart:
compile
1m 12s

the patch passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
javac
1m 12s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
1m  4s
/results-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs-project/hadoop-hdfs: The patch generated 4 new + 36 unchanged - 2 fixed = 40 total (was 38)

+1 :green_heart:
mvnsite
1m 20s

the patch passed

+1 :green_heart:
javadoc
0m 55s

the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
1m 31s

the patch passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
spotbugs
3m 23s

the patch passed

+1 :green_heart:
shadedclient
35m 39s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
248m  8s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 58s

The patch does not generate ASF License warnings.

395m 10s

Reason
Tests

Failed junit tests
hadoop.hdfs.TestClientProtocolForPipelineRecovery

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2821/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2821

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux ee21fc74c935 4.15.0-212-generic #223-Ubuntu SMP Tue May 23 13:09:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / d34f6b68f57c575e6c8bf0ec90518ceca24a793e

Default Java
Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2821/1/testReport/

Max. process+thread count
3272 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2821/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

authors: ferhui functioner hadoop-yetus


text:
HDFS-16048. RBF: Print network topology on the router web

JIRA: HDFS-16048
In order to query the network topology information conveniently, we can print it on the router web. It's related to HDFS-15970.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 56s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
33m 18s

trunk passed

+1 :green_heart:
compile
0m 39s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
compile
0m 34s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
checkstyle
0m 23s

trunk passed

+1 :green_heart:
mvnsite
0m 38s

trunk passed

+1 :green_heart:
javadoc
0m 38s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
0m 50s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
1m 16s

trunk passed

+1 :green_heart:
shadedclient
16m 50s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 33s

the patch passed

+1 :green_heart:
compile
0m 33s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javac
0m 33s

the patch passed

+1 :green_heart:
compile
0m 28s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
javac
0m 28s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 16s
/results-checkstyle-hadoop-hdfs-project_hadoop-hdfs-rbf.txt
hadoop-hdfs-project/hadoop-hdfs-rbf: The patch generated 37 new + 0 unchanged - 0 fixed = 37 total (was 0)

+1 :green_heart:
mvnsite
0m 31s

the patch passed

+1 :green_heart:
javadoc
0m 32s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
0m 49s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
1m 18s

the patch passed

+1 :green_heart:
shadedclient
16m 42s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
30m 53s

hadoop-hdfs-rbf in the patch passed.

+1 :green_heart:
asflicense
0m 30s

The patch does not generate ASF License warnings.

110m 42s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3062/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/3062

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux 7aad36b2871e 4.15.0-142-generic #146-Ubuntu SMP Tue Apr 13 01:11:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 180e6cf9739af78962f33ce001727d4d9a2a308b

Default Java
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3062/1/testReport/

Max. process+thread count
2518 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project/hadoop-hdfs-rbf

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3062/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 57s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
33m 21s

trunk passed

+1 :green_heart:
compile
0m 39s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
compile
0m 34s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
checkstyle
0m 23s

trunk passed

+1 :green_heart:
mvnsite
0m 38s

trunk passed

+1 :green_heart:
javadoc
0m 39s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
0m 54s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
1m 16s

trunk passed

+1 :green_heart:
shadedclient
17m  8s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 32s

the patch passed

+1 :green_heart:
compile
0m 34s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javac
0m 34s

the patch passed

+1 :green_heart:
compile
0m 28s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
javac
0m 28s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 16s
/results-checkstyle-hadoop-hdfs-project_hadoop-hdfs-rbf.txt
hadoop-hdfs-project/hadoop-hdfs-rbf: The patch generated 16 new + 0 unchanged - 0 fixed = 16 total (was 0)

+1 :green_heart:
mvnsite
0m 31s

the patch passed

+1 :green_heart:
javadoc
0m 30s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
0m 48s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
1m 20s

the patch passed

+1 :green_heart:
shadedclient
16m 53s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
24m 24s

hadoop-hdfs-rbf in the patch passed.

+1 :green_heart:
asflicense
0m 29s

The patch does not generate ASF License warnings.

104m 34s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3062/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/3062

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux c8a9b795954e 4.15.0-142-generic #146-Ubuntu SMP Tue Apr 13 01:11:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 85599bd59d58c1b18ca62b5675a43dfc5118294a

Default Java
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3062/3/testReport/

Max. process+thread count
2463 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project/hadoop-hdfs-rbf

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3062/3/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 50s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
33m  6s

trunk passed

+1 :green_heart:
compile
0m 39s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
compile
0m 34s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
checkstyle
0m 24s

trunk passed

+1 :green_heart:
mvnsite
0m 39s

trunk passed

+1 :green_heart:
javadoc
0m 37s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
0m 52s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
1m 16s

trunk passed

+1 :green_heart:
shadedclient
16m 40s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 32s

the patch passed

+1 :green_heart:
compile
0m 33s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javac
0m 33s

the patch passed

+1 :green_heart:
compile
0m 28s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
javac
0m 28s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 16s

the patch passed

+1 :green_heart:
mvnsite
0m 31s

the patch passed

+1 :green_heart:
javadoc
0m 31s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
0m 46s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
1m 18s

the patch passed

+1 :green_heart:
shadedclient
16m 35s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
23m  7s

hadoop-hdfs-rbf in the patch passed.

+1 :green_heart:
asflicense
0m 29s

The patch does not generate ASF License warnings.

102m  5s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3062/4/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/3062

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux 4d1706bfe114 4.15.0-142-generic #146-Ubuntu SMP Tue Apr 13 01:11:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 73d8baa909714bfd9f338725a31e671d2a0bd53b

Default Java
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3062/4/testReport/

Max. process+thread count
2016 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project/hadoop-hdfs-rbf

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3062/4/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

Hi @ayushtkn @goiri @tasanuma , Could you please review the code? Thank you. As mentioned earlier PR-2896, we also want to print topology information on the Router Web.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 52s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
12m 37s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
22m 33s

trunk passed

+1 :green_heart:
compile
5m 16s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
compile
4m 50s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
checkstyle
1m 15s

trunk passed

+1 :green_heart:
mvnsite
1m 58s

trunk passed

+1 :green_heart:
javadoc
1m 33s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
2m 19s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
4m 29s

trunk passed

+1 :green_heart:
shadedclient
16m 57s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 22s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
1m 46s

the patch passed

+1 :green_heart:
compile
5m 10s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javac
5m 10s

the patch passed

+1 :green_heart:
compile
4m 40s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
javac
4m 40s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
1m  9s

the patch passed

+1 :green_heart:
mvnsite
1m 50s

the patch passed

+1 :green_heart:
javadoc
1m 21s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
2m 11s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
4m 40s

the patch passed

+1 :green_heart:
shadedclient
16m 49s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
347m 27s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
unit
24m 16s

hadoop-hdfs-rbf in the patch passed.

+1 :green_heart:
asflicense
0m 40s

The patch does not generate ASF License warnings.

488m 52s

Reason
Tests

Failed junit tests
hadoop.hdfs.server.namenode.ha.TestEditLogTailer

hadoop.hdfs.server.namenode.TestDecommissioningStatusWithBackoffMonitor

hadoop.hdfs.server.namenode.TestDecommissioningStatus

hadoop.hdfs.TestDFSShell

hadoop.hdfs.server.datanode.fsdataset.impl.TestFsVolumeList

hadoop.hdfs.server.namenode.ha.TestBootstrapStandby

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3062/5/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/3062

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux a618afa0831e 4.15.0-142-generic #146-Ubuntu SMP Tue Apr 13 01:11:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 05ca8ba36da36bae2e974bad43902681500ff2dc

Default Java
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3062/5/testReport/

Max. process+thread count
2228 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3062/5/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

Those failed unit tests work fine locally.
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3062/5/testReport/

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 56s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
13m 37s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
23m 19s

trunk passed

+1 :green_heart:
compile
5m 29s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
compile
5m 21s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
checkstyle
1m 21s

trunk passed

+1 :green_heart:
mvnsite
2m 13s

trunk passed

+1 :green_heart:
javadoc
1m 35s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
2m 20s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
4m 34s

trunk passed

+1 :green_heart:
shadedclient
17m 24s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 24s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
1m 57s

the patch passed

+1 :green_heart:
compile
5m 32s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javac
5m 32s

the patch passed

+1 :green_heart:
compile
5m 11s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
javac
5m 11s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
1m 14s

the patch passed

+1 :green_heart:
mvnsite
2m  1s

the patch passed

+1 :green_heart:
javadoc
1m 34s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
2m 17s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
4m 58s

the patch passed

+1 :green_heart:
shadedclient
18m  8s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
356m 19s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
unit
23m 49s

hadoop-hdfs-rbf in the patch passed.

+1 :green_heart:
asflicense
0m 40s

The patch does not generate ASF License warnings.

503m 48s

Reason
Tests

Failed junit tests
hadoop.hdfs.server.namenode.ha.TestBootstrapAliasmap

hadoop.hdfs.TestSnapshotCommands

hadoop.hdfs.server.namenode.TestDecommissioningStatusWithBackoffMonitor

hadoop.hdfs.server.namenode.TestDecommissioningStatus

hadoop.hdfs.TestDFSShell

hadoop.hdfs.server.datanode.fsdataset.impl.TestFsVolumeList

hadoop.hdfs.server.namenode.ha.TestBootstrapStandby

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3062/6/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/3062

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux 49ae01131d22 4.15.0-142-generic #146-Ubuntu SMP Tue Apr 13 01:11:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 7a6da91b979c858d338e5f0d480824f959df026f

Default Java
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3062/6/testReport/

Max. process+thread count
2076 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3062/6/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

LGTM

LGTM

Thanks @hemanthboyina for your review.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 58s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
13m  2s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
24m 59s

trunk passed

+1 :green_heart:
compile
6m 22s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
compile
5m 26s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
checkstyle
1m 24s

trunk passed

+1 :green_heart:
mvnsite
2m 13s

trunk passed

+1 :green_heart:
javadoc
1m 41s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
2m 28s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
5m  3s

trunk passed

+1 :green_heart:
shadedclient
17m  1s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 26s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
1m 48s

the patch passed

+1 :green_heart:
compile
5m 37s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javac
5m 37s

the patch passed

+1 :green_heart:
compile
5m 36s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
javac
5m 36s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
1m 19s

the patch passed

+1 :green_heart:
mvnsite
2m  6s

the patch passed

+1 :green_heart:
javadoc
1m 30s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
2m 20s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
4m 49s

the patch passed

+1 :green_heart:
shadedclient
17m 17s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
394m 50s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

-1 :x:
unit
27m  9s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs-rbf.txt
hadoop-hdfs-rbf in the patch passed.

+1 :green_heart:
asflicense
0m 56s

The patch does not generate ASF License warnings.

548m 21s

Reason
Tests

Failed junit tests
hadoop.hdfs.server.namenode.ha.TestEditLogTailer

hadoop.hdfs.TestRollingUpgrade

hadoop.hdfs.server.namenode.TestDecommissioningStatusWithBackoffMonitor

hadoop.hdfs.server.namenode.TestDecommissioningStatus

hadoop.hdfs.TestDFSShell

hadoop.hdfs.server.datanode.fsdataset.impl.TestFsVolumeList

hadoop.hdfs.server.namenode.ha.TestBootstrapStandby

hadoop.fs.contract.router.web.TestRouterWebHDFSContractCreate

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3062/7/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/3062

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux afe81dbe1d9d 4.15.0-142-generic #146-Ubuntu SMP Tue Apr 13 01:11:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 56479fdf16924d11a1579188b58c38784d058f57

Default Java
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3062/7/testReport/

Max. process+thread count
2611 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3062/7/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 54s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
12m 53s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
23m 19s

trunk passed

+1 :green_heart:
compile
5m 37s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
compile
5m  0s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
checkstyle
1m 21s

trunk passed

+1 :green_heart:
mvnsite
2m  9s

trunk passed

+1 :green_heart:
javadoc
1m 35s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
2m 32s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
4m 44s

trunk passed

+1 :green_heart:
shadedclient
17m 41s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 27s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
1m 55s

the patch passed

+1 :green_heart:
compile
5m 32s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javac
5m 32s

the patch passed

+1 :green_heart:
compile
5m  3s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
javac
5m  3s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
1m 13s

the patch passed

+1 :green_heart:
mvnsite
1m 53s

the patch passed

+1 :green_heart:
javadoc
1m 24s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
2m 15s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
4m 54s

the patch passed

+1 :green_heart:
shadedclient
17m 30s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
366m 14s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
unit
24m 39s

hadoop-hdfs-rbf in the patch passed.

+1 :green_heart:
asflicense
0m 46s

The patch does not generate ASF License warnings.

513m 28s

Reason
Tests

Failed junit tests
hadoop.hdfs.server.namenode.ha.TestEditLogTailer

hadoop.hdfs.server.namenode.TestDecommissioningStatusWithBackoffMonitor

hadoop.hdfs.server.namenode.TestDecommissioningStatus

hadoop.hdfs.TestDFSShell

hadoop.hdfs.server.datanode.fsdataset.impl.TestFsVolumeList

hadoop.hdfs.server.namenode.ha.TestBootstrapStandby

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3062/8/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/3062

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux 06986d2d174a 4.15.0-142-generic #146-Ubuntu SMP Tue Apr 13 01:11:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / b238934eccd5eda85ad61935d8ed5264b027e948

Default Java
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3062/8/testReport/

Max. process+thread count
2749 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3062/8/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

Hi @goiri @tasanuma @aajisaka , could you please help merge the code? Thank you.

Merged. Thanks for your contribution, @tomscut.
Thanks for your reviews, @goiri, @hemanthboyina and @aajisaka.

Merged. Thanks for your contribution, @tomscut.
Thanks for your reviews, @goiri, @hemanthboyina and @aajisaka.

Thanks @tasanuma for the merge.

authors: hadoop-yetus hemanthboyina tasanuma tomscut