text:
[FLOC-3883] FilePath matchers and temporary helpers

Adds new helper methods to our base test cases:

make_temporary_path – like mktemp, but returns a FilePath
make_temporary_directory – returns a temporary directory as a FilePath
make_temporary_file – returns a temporary file, with optional content

Adds a new flocker.testtools.matchers module that provides FilePath-related matchers:

path_exists – matches if a FilePath exists on disk
dir_exists – matches if a FilePath exists and is a directory
file_exists – matches if a FilePath exists and is a file
file_contents – matches on the contents of a file if it exists

Note that file_contents is analogous to testtools.matchers.FileContains but different in that it always takes a matcher and has a name that reflects this.
In order to make writing the above matchers easier, I added:

after – a thing like AfterPreprocessing that operates on Matcher factories
on_mismatch – like after, but applies to mismatches
OnMismatch – life AfterPreprocessing, but applies to mismatches
A new _Mismatch type that also stores the mismatched object, to allow for better composition

None of these have direct tests, as they came out of refactoring efforts.
In order to make testing these changes easier, I added a flocker.testtools.strategies module that collates existing strategies and adds a couple for file paths. I also added a helper for creating simple test cases.
There are also unrelated lint fixes to flocker/testtools/__init__.py.
Apologies for the size of this PR. I was originally going to focus on the matchers, but found that doing the temp helpers was a natural pair.

Thanks for this change, @jml and thanks @james-w for helping with the review!
Apart from the few small comments, I think the change looks good. The Jenkins job wasn't triggered for this PR so I started a build. I'm happy for this to be merged once the comments are addressed and the tests are passing but feel free to get another review since you are my mentor for reviews. :smile:

I'm going to move this issue to "Accepted" but I can change it back if you would like another review.

Thanks for the reviews! I'll merge this after I get a new test run.

authors: jml zubron


text:
https://github.com/Coalfire-CF/terraform-aws-active-directory-mvp/issues/6

there's issues with the way SGs are made, https://github.com/Coalfire-CF/terraform-aws-active-directory-mvp/issues/6
this needs to be discussed in an Orange crush meeting

Original Issue closed.

source: gharchive/issue

authors: herman-wong-cf kourosh-forti-hands

repo: Coalfire-CF/terraform-aws-securitygroup

license: MIT

license_type: permissive

license_source: github-api


text:
Swift Compatibility Status

Following #299, #338, #358 and more broadly 2.x.x discussion in #225.

[x] CocoaLumberjack.swift and CocoaLumberjackSwift framework wrappers (#362, #382).

Ideally users would install the Objective-C CocoaLumberjack library though CocoaPods, then either manually add CocoaLumberjack.swift, link CocoaLumberjackSwift?? Until there is official CocoaPods support for Swift.
To do:

[x] Fix iOSSwift demo project.
[ ] Add Travis build steps for Swift code. iOS 8 SDK is already supported by Travis, OS X 10.10 SDK not yet.
[ ] Merge mobile and desktop frameworks/static libraries. iOS now supports frameworks as well so we could probably move to a single framework or at least single project.
[ ] Move framework/static libraries demo projects out to the Demos directory.

What version/branch/tag should I use at the moment to get Swift support?

For Xcode 6.3 and Swift 1.2, the swift_support branch will compile.

I think that merging #466 will help using Cocoalumberjack in several Swift project / libraries.

I would like to but I was waiting for an answer from the contributor. If you want you can contribute to that pull request too so we can merge it.

authors: MaddTheSane guidomb mackuba rivera-ernesto

repo: CocoaLumberjack/CocoaLumberjack


text:
Assign Problems to Codeforces Contest

Assign Problems to Codeforces Contest for Extension.
Based on User Rating
Select 5 Problems -
Steps -
Filter Problems of Codeforces and Regular Contest
Filter and Exclude Problems that were solved by User
Select Problems in range +-200.

/cib assign problems

User Status - Seen Problem
Problem.objects.filter(platform = 'F' )
Gym Filter ->
Contest Filter ->
contest.objects.filter(Type = 'R' )
Make a list of all ids.
contest.id
Problem.objects.filter(contest = contestsID)
After all Problem Filter
Regular Contest
Excluding seen problems
SolveProblemsAPIView - Read and Understand
-> Rating CodeforcesUser.rating
Problem Filter Select 5 Problems
( Rating % 100 == 0 )
=> Random Rating
Difficulty None

repo: Code-dig-ger/Backend


text:
Improve 404 and non-API 500-level error handling.

When the API gives us a 404, send the same to the user and show a nice page.
Decently handle non-API 500 responses.

This may not actually prevent New Relic from jumping up and down about 404s, let me take another look. Midnight ain't the best time to write code.

Ok, this should work.

source: gharchive/pull-request

license_source: bigquery


text:
list 添加完成之后马上设置SelectItem，EnsureVisible不可用

list 添加若干项（要可以出现滚动条），然后SelectItem（最后一项），
结果滚动条还是在最上端，
我debug发现
EnsureVisible方法，在正常情况下RECT rcItem = m_pList->GetItemAt(iIndex)->GetPos();
这句是有值的，但是如果添加完成之后马上调用SelcetItem方法，这句话得到的rcItem就是0。

控件还没有绘制完毕的确有这个问题

repo: CodeBees/duilib-Ex-Debug

license: mit


text:
Wyświetlenie obrazka organizacji

Description:
Wyświetlenie obrazka organizacji przy podglądzie organizacji

moje!

repo: CodeForPoznan/volontulo


text:
Add read-only joined field to offer serializer

Description:
Add read-only joined field to OfferSerializer - it need to return boolean value that holds information if user attached to request already joined this particular offer.
Current behaviour:
There's no way to determine if user joined offer in API endpoints.
Expected behaviour:
User can access information - if he/she already joined offer.

@Kropkakam


text:
Added leetcode-43 String Matching

Related Issue #1292
[Cite any related issue(s) this pull request addresses. If none, simply state "None”]
Description
[Please include a brief description of the changes or features added]
Type of PR

[x] Documentation update

Screenshots / Videos (if applicable)

[Attach any relevant screenshots or videos demonstrating the changes]
Checklist

[x] I have performed a self-review of my code.
[x] I have read and followed the Contribution Guidelines.
[x] I have tested the changes thoroughly before submitting this pull request.
[x] I have provided relevant issue numbers, screenshots, and videos after making the changes.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] I have followed the code style guidelines of this project.
[x] I have checked for any existing open issues that my pull request may address.
[x] I have ensured that my changes do not break any existing functionality.
[x] Each contributor is allowed to create a maximum of 4 issues per day. This helps us manage and address issues efficiently.
[x] I have read the resources for guidance listed below.
[x] I have followed security best practices in my code changes.

Additional Context
[Include any additional information or context that might be helpful for reviewers.]
Resources for Guidance
Please read the following resources before submitting your contribution:

[ ] Code Harbor Hub Community Features
[ ] Docusaurus Documentation
[ ] React.js Documentation
[ ] Markdown Guide
[ ] MDX Documentation
[ ] Mermaid Documentation

Resources for DSA Features on Our Site:

[ ] Tabs: Switch Languages
[ ] Line Numbering
[ ] Math Equations

Contribution Guidelines
Thank you for considering contributing to our project! To ensure smooth collaboration and effective contribution management, please adhere to the following guidelines:
Issue Creation

Limit on Issues:

Each contributor is allowed to create a maximum of 4 issues per day. This helps us manage and address issues efficiently.

Contribution Levels

Basic Contributions:

This project is primarily focused on documentation. Most of the setup has been completed, so contributors will generally need to work on basic code tasks, such as writing tests.
For these tasks, issues will be assigned the level1 label.

Acknowledging Hard Work:

If a contributor puts in significant effort on a task, the issue will be upgraded to level2. This is our way of recognizing and appreciating extra effort.

Feature Additions and Component Work:

Contributors working on new features or components using JSX/TSX will be assigned a level based on the complexity and quality of their work.
The more complex and valuable the contribution, the higher the level assigned.

Level Definitions

Level1:

Tasks are straightforward, such as fixing minor bugs, writing tests, or making simple documentation updates.

Level2:

Tasks require more effort, such as addressing complex bugs, improving existing features, or making substantial documentation improvements.

Level3:

Tasks are highly complex and involve significant new feature development, major refactoring, or extensive contributions to the project’s core components.

We look forward to your contributions and appreciate your effort in helping us improve the project!

hello @Ajay-Dhangar
can you please review this PR and merge it?


text:
Feature-wire/frame | Sabita Shrestha |Module-user-Focused-Data

Learners, PR Template
Self checklist

[ ] I have committed my files one by one, on purpose, and for a reason
[ ] I have titled my PR with COHORT_NAME | FIRST_NAME LAST_NAME | REPO_NAME | WEEK
[ ] I have tested my changes
[ ] My changes follow the style guide
[ ] My changes meet the requirements of this task

Changelist
Briefly explain your PR.
Questions
Ask any questions you have for your reviewer.

@SabitaShrestha325 your work was missed because it had no label. Please label your work with Needs Review, so mentors can find it.
Mentors look at this view to see what work they have to do: https://github.com/CodeYourFuture/Module-User-Focused-Data/pulls?q=is%3Apr+is%3Aopen+label%3A"Needs+Review"

repo: CodeYourFuture/Module-User-Focused-Data


text:
fix(PageSection): Adding margin-top to footer of PageSection

Overview
This just adds a marginTop={16} to the footer of the PageSection component so it's not right up against the content of the section.
This is to support the following design for the Profiles page, but should be applicable to every usecase:

PR Checklist

[ ] Related to designs:
[ ] Related to JIRA ticket: ABC-123
[x] I have run this code to verify it works
[ ] This PR includes unit tests for the code change

📬Published Alpha Packages:@codecademy/gamut-kit@0.3.53-alpha.85b38b.0@codecademy/gamut-labs@14.4.5-alpha.85b38b.0@codecademy/styleguide@36.5.1-alpha.85b38b.0

🚀 Styleguide deploy preview ready!https://608861a43253cd00b17ba8fb--gamut-preview.netlify.appDeploy Logs

authors: ZackMFleischman codecademydev

repo: Codecademy/client-modules


text:
feat(CurriculumCard): Allowing dynamic difficulty spans

Overview

Updating the difficulty section of curriculumCards to be more dynamic. Allowing us to render the amount of circles based on the difficulty level.
Portal integration PR
Monolith  integration PR

PR Checklist

[x] Related to designs: Notion
[x] Related to JIRA ticket: DISC-53
[x] I have run this code to verify it works
[x] This PR includes unit tests for the code change

📬Published Alpha Packages:@codecademy/gamut-kit@0.6.81-alpha.b03969.0@codecademy/gamut-labs@30.2.7-alpha.b03969.0@codecademy/styleguide@55.1.7-alpha.b03969.0

📬Published Alpha Packages:@codecademy/gamut-kit@0.6.81-alpha.261ed3.0@codecademy/gamut-labs@30.2.7-alpha.261ed3.0@codecademy/styleguide@55.1.7-alpha.261ed3.0

🚀 Styleguide deploy preview ready!https://62323d806dad313700d3b0dd--gamut-preview.netlify.appDeploy Logs

📬Published Alpha Packages:@codecademy/gamut-kit@0.6.81-alpha.c3e3ae.0@codecademy/gamut-labs@30.2.7-alpha.c3e3ae.0@codecademy/styleguide@55.1.7-alpha.c3e3ae.0

🚀 Styleguide deploy preview ready!https://62324274235da441d4960653--gamut-preview.netlify.appDeploy Logs

📬Published Alpha Packages:@codecademy/gamut-kit@0.6.81-alpha.fdbc85.0@codecademy/gamut-labs@30.2.7-alpha.fdbc85.0@codecademy/styleguide@55.1.7-alpha.fdbc85.0

🚀 Styleguide deploy preview ready!https://62332d67237cda2fa1b29e6f--gamut-preview.netlify.appDeploy Logs

📬Published Alpha Packages:@codecademy/gamut-kit@0.6.81-alpha.1524cf.0@codecademy/gamut-labs@30.2.7-alpha.1524cf.0@codecademy/styleguide@55.1.7-alpha.1524cf.0

🚀 Styleguide deploy preview ready!https://6233aaf3dc30e12672c33eb5--gamut-preview.netlify.appDeploy Logs

📬Published Alpha Packages:@codecademy/gamut-kit@0.6.82-alpha.f8635c.0@codecademy/gamut-labs@30.3.1-alpha.f8635c.0@codecademy/styleguide@55.2.1-alpha.f8635c.0

🚀 Styleguide deploy preview ready!https://6233acb2a177b129ef607589--gamut-preview.netlify.appDeploy Logs

📬Published Alpha Packages:@codecademy/gamut-kit@0.6.82-alpha.d1fefb.0@codecademy/gamut-labs@30.3.1-alpha.d1fefb.0@codecademy/styleguide@55.2.1-alpha.d1fefb.0

🚀 Styleguide deploy preview ready!https://62349598f300a852113e7bf7--gamut-preview.netlify.appDeploy Logs

📬Published Alpha Packages:@codecademy/gamut-kit@0.6.82-alpha.e04abb.0@codecademy/gamut-labs@30.3.1-alpha.e04abb.0@codecademy/styleguide@55.2.1-alpha.e04abb.0

🚀 Styleguide deploy preview ready!https://6234cf251626c40070f5c00d--gamut-preview.netlify.appDeploy Logs

📬Published Alpha Packages:@codecademy/gamut-kit@0.6.82-alpha.ff29eb.0@codecademy/gamut-labs@30.3.1-alpha.ff29eb.0@codecademy/styleguide@55.2.1-alpha.ff29eb.0

🚀 Styleguide deploy preview ready!https://6234ff3a48f3532466bd6f75--gamut-preview.netlify.appDeploy Logs

📬Published Alpha Packages:@codecademy/gamut-kit@0.6.82-alpha.511c5a.0@codecademy/gamut-labs@30.3.1-alpha.511c5a.0@codecademy/styleguide@55.2.1-alpha.511c5a.0

🚀 Styleguide deploy preview ready!https://62350315c2e8e83031e6652f--gamut-preview.netlify.appDeploy Logs

🚀 Styleguide deploy preview ready!https://6238a5b0caf1e10992aad44a--gamut-preview.netlify.appDeploy Logs

🚀 Styleguide deploy preview ready!https://6238ab5f41ef2b0c22661b2d--gamut-preview.netlify.appDeploy Logs

📬Published Alpha Packages:@codecademy/gamut-kit@0.6.82-alpha.4570ca.0@codecademy/gamut-labs@30.3.1-alpha.4570ca.0@codecademy/styleguide@55.2.1-alpha.4570ca.0

📬Published Alpha Packages:@codecademy/gamut-kit@0.6.82-alpha.90d8df.0@codecademy/gamut-labs@30.3.1-alpha.90d8df.0@codecademy/styleguide@55.2.1-alpha.90d8df.0

🚀 Styleguide deploy preview ready!https://623a01c212b34c45453a914f--gamut-preview.netlify.appDeploy Logs

📬Published Alpha Packages:@codecademy/gamut-kit@0.6.84-alpha.b91352.0@codecademy/gamut-labs@30.4.1-alpha.b91352.0@codecademy/styleguide@55.2.3-alpha.b91352.0

🚀 Styleguide deploy preview ready!https://623a483f824a96410f3de539--gamut-preview.netlify.appDeploy Logs

📬Published Alpha Packages:@codecademy/gamut-kit@0.6.85-alpha.cabd74.0@codecademy/gamut-labs@30.4.2-alpha.cabd74.0@codecademy/styleguide@55.3.1-alpha.cabd74.0

🚀 Styleguide deploy preview ready!https://623b16656d50652c29d474a3--gamut-preview.netlify.appDeploy Logs

authors: codecademydev vonbarown

repo: Codecademy/gamut


text:
layout engine

Hi,
that's not an issue: I am watching you since a while and I just wanted to let you know there is a 'Docker' library: https://github.com/WebCabin/wcDocker. I integrated this in my IDE without bigger hassle and the results are really great; it gives you basically the richness as seen in Eclipse or similar.
I also tried 'dockspawn.com' but it isn't really easy to port over to JS.
And if you like 'Ribbons', here is another library I can recommend: https://github.com/mc007/ribbon-js.
If you need a require-js port of these libs, let me know.
g

well, never mind :-(

repo: Codiad/Codiad


text:
Feature request: blacklist items

Can you add a option to blacklist items from being traded?

Sorry for the last answer. I had a little break.
Thanks for your commitment, you will get a blacklist ;)

authors: CodingAir VMBindraban

repo: CodingAir/TradeSystem


text:
first Issues are done and should now in the DEV Branche for the Start

I have connected the DB, created the KidsRepoInterface and stored the secret in the applicaton.properties. The Kids Record is only there so that I don't get any errors and is not yet finished. The connection to the DB has been tested and exit code 0 is displayed, i.e. no error.
The merge is deliberately not going into the main because we don't have a basic framework yet. but to be able to work cleanly, it should definitely be in the dev branch

Pls only check the Backend updates in this PR all Frontend stuff is our test stuff that could be changed or deleted

repo: CodingRobIT/glowing-spork


text:
Refactoring PR label handling, enhancing language detection, and updating CLI commands

Type
Refactoring, Enhancement, Tests

Description
This Pull Request introduces several changes:

Refactors the way custom labels are handled in the PR agent, replacing the previous string concatenation with a class-based approach.
Updates CLI commands to include new functionalities such as 'add_docs' and 'generate_labels'.
Changes the way PR types are referenced in the code, moving from 'PR Type' and 'PR Labels' to 'type' and 'labels'.
Updates the TOML configuration files to reflect the new Pydantic model definitions for labels and PR descriptions.
Moves the 'clip_tokens' function from 'pr_processing' to 'utils' module and adds corresponding tests.
Enhances readability in TOML files and adds verbosity level logging in 'pr_generate_labels.py'.
Updates the method of determining the main PR language by using a language-extension map.

PR Files Labels

Semantic label
Relevant files

Refactoring
Filespr_agent/tools/pr_description.pypr_agent/git_providers/git_provider.pypr_agent/algo/utils.pypr_agent/tools/pr_generate_labels.pypr_agent/algo/pr_processing.pypr_agent/algo/language_handler.pypr_agent/cli.pypr_agent/git_providers/codecommit_provider.pypr_agent/git_providers/azuredevops_provider.pypr_agent/git_providers/github_provider.pypr_agent/git_providers/gitlab_provider.py

Enhancement
Filespr_agent/tools/pr_description.pypr_agent/git_providers/git_provider.pypr_agent/algo/utils.pypr_agent/tools/pr_generate_labels.pypr_agent/algo/language_handler.pypr_agent/cli.pypr_agent/git_providers/codecommit_provider.pypr_agent/git_providers/azuredevops_provider.pypr_agent/git_providers/github_provider.pypr_agent/git_providers/gitlab_provider.py

Tests
Filestests/unittest/test_clip_tokens.py

Preparing PR description...

Preparing PR labels...

Preparing PR labels...

Preparing PR labels...

Preparing PR labels...

Preparing PR labels...

Preparing PR labels...

Preparing review...

Preparing review...

Preparing review...

Preparing review...

/review -i

/review

Preparing review...

Preparing review...

Preparing review...

PR Analysis

🎯 Main theme: Refactoring and enhancement of PR label handling and CLI command updates
📝 PR summary: The PR introduces a class-based approach for handling custom labels in the PR agent, adds new CLI commands, and updates the TOML configuration files to use Pydantic model definitions. It also replaces string keys with more concise ones in the code.
📌 Type of PR: Refactoring
🧪 Relevant tests added: No
⏱ Estimated effort to review [1-5]: 3, because the PR involves multiple files with structural changes and new features that require careful review to ensure compatibility and correctness.
🔒 Security concerns: No security concerns found

PR Feedback

💡 General suggestions: The PR seems to be a significant improvement in terms of code structure and functionality. However, it's important to ensure that all changes are backward compatible and that the new CLI commands are tested thoroughly. Additionally, it would be beneficial to have tests accompanying these changes to validate the new behavior and prevent regressions.

 🤖 Code feedback:

relevant file: pr_agent/algo/utils.py
suggestion: Consider using a list comprehension or a generator expression to build the 'custom_labels_class' string more concisely and Pythonically. [important]
relevant line: variables["custom_labels_class"] = "class Label(str, Enum):"

relevant file: pr_agent/cli.py
suggestion: Ensure that the new CLI commands 'add_docs' and 'generate_labels' have proper help text and documentation for users to understand their usage. [important]
relevant line: add_docs

relevant file: pr_agent/tools/pr_description.py
suggestion: Replace the string concatenation with f-strings for better readability and performance when constructing 'variables["custom_labels_class"]'. [medium]
relevant line: variables["custom_labels_class"] += f"\n    {k.lower().replace(' ', '_')} = '{k}' # {description}"

relevant file: pr_agent/settings/pr_custom_labels.toml
suggestion: Ensure that the TOML configuration files are updated to reflect the new class-based label definition and that they are compatible with the existing configuration. [important]
relevant line: system="""You are CodiumAI-PR-Reviewer, a language model designed to review git Pull Requests (PR).

Preparing review...

Preparing review...

updated review to latest commit https://github.com/Codium-ai/pr-agent/commit/0df054295828c8b1395a1b084a89b99688200d0b

updated review to latest commit https://github.com/Codium-ai/pr-agent/commit/0df054295828c8b1395a1b084a89b99688200d0b

Persistent review updated  to latest commit https://github.com/Codium-ai/pr-agent/commit/0df054295828c8b1395a1b084a89b99688200d0b

Preparing review...

PR Analysis

🎯 Main theme: プルリクエストのラベル処理をリファクタリングし、CLIコマンドを更新すること
📝 PR summary: このプルリクエストでは、PRエージェントのカスタムラベルの処理方法を文字列連結からクラスベースのアプローチに変更し、'add_docs'や'generate_labels'などの新しいCLIコマンドを追加しました。また、PRのタイプを参照するコードを'PR Type'と'PR Labels'から'type'と'labels'に変更し、TOML設定ファイルを新しいPydanticモデル定義に合わせて更新しました。
📌 Type of PR: Refactoring
🧪 Relevant tests added: No
⏱ Estimated effort to review [1-5]: 3, このPRは複数のファイルにわたる変更が含まれており、リファクタリングと機能追加の両方が行われているため、適切なレビューには注意深い検討が必要です。
🔒 Security concerns: No security concerns found

PR Feedback

💡 General suggestions: このPRの変更は全体的に良い方向に進んでいるようですが、いくつかの提案があります。特に、新しいクラスベースのアプローチを採用している部分では、Pythonの標準ライブラリのEnumを活用してコードの可読性と保守性を向上させることができます。また、CLIコマンドの追加に関しては、ヘルプテキストの更新を忘れずに行ってください。

 🤖 Code feedback:

relevant file: pr_agent/algo/utils.py
suggestion: Enumクラスを使用してラベルを定義する際に、Enumメンバーの名前を自動的に小文字とアンダースコアに変換するのではなく、明示的に指定することを検討してください。これにより、将来的な変更や追加が容易になります。 [important]
relevant line: variables["custom_labels_class"] += f"\n    {k.lower().replace(' ', '_')} = '{k}' # {description}"

relevant file: pr_agent/cli.py
suggestion: 新しいCLIコマンド'add_docs'と'generate_labels'のヘルプテキストを追加して、使用方法を明確にすることを提案します。これにより、ユーザーが新しいコマンドの目的と使用方法を理解しやすくなります。 [important]
relevant line: add_docs

relevant file: pr_agent/settings/custom_labels.toml
suggestion: TOML設定ファイルでコメントアウトされた古いYAMLスキーマの指示を削除して、設定ファイルをクリーンに保つことを提案します。 [medium]
relevant line: #description = """Fixes a bug in the code"""

relevant file: pr_agent/settings/pr_custom_labels.toml
suggestion: 'pr_custom_labels_prompt'のテンプレート内で、不要なコメントや古いYAMLスキーマの指示を削除し、新しいクラスベースの定義に合わせて更新することを提案します。 [medium]
relevant line: system="""You are CodiumAI-PR-Reviewer, a language model designed to review git Pull Requests (PR).

Persistent review updated  to latest commit https://github.com/Codium-ai/pr-agent/commit/0df054295828c8b1395a1b084a89b99688200d0b

Preparing review...

PR Analysis

🎯 Main theme: PRラベル処理のリファクタリングとCLIコマンドの更新
📝 PR summary: このPRでは、PRエージェントにおけるカスタムラベルの処理方法を文字列連結からクラスベースのアプローチに変更し、'add_docs'や'generate_labels'などの新しいCLIコマンドを追加しました。また、コード内のPRタイプの参照方法を変更し、TOML設定ファイルを新しいPydanticモデル定義に合わせて更新しています。
📌 Type of PR: Refactoring
Enhancement
🧪 Relevant tests added: No
⏱ Estimated effort to review [1-5]: 3, このPRは複数のファイルにわたる変更が含まれており、新しいクラスベースのアプローチやCLIコマンドの追加など、検討すべき点がいくつかあります。
🔒 Security concerns: No security concerns found

PR Feedback

💡 General suggestions: PRの変更は全体的に適切に見えますが、新しいクラスベースのアプローチを使用することでコードの可読性が向上しています。ただし、新しいCLIコマンドの追加に関連するドキュメントやヘルプテキストの更新が必要かもしれません。また、新しいラベル生成方法が既存の機能に影響を与えないか、十分にテストすることが重要です。

 🤖 Code feedback:

relevant file: pr_agent/algo/utils.py
suggestion: ラベルの生成にEnumを使用する際は、Enumの値にも実際のラベルの説明を含めることを検討してください。これにより、コード内でラベルを参照する際に、その意味をより簡単に理解できるようになります。 [important]
relevant line: variables["custom_labels_class"] += f"\n    {k.lower().replace(' ', '_')} = '{k}' # {description}"

relevant file: pr_agent/cli.py
suggestion: 新しいCLIコマンド 'add_docs' と 'generate_labels' のヘルプテキストを追加して、使用方法を明確にしてください。 [important]
relevant line: # add_docs

relevant file: pr_agent/tools/pr_description.py
suggestion: 'type' と 'labels' のキーを使用する際は、これらが常に存在し、適切な型であることを確認するためのバリデーションを追加してください。 [medium]
relevant line: elif 'type' in self.data:

relevant file: pr_agent/settings/pr_custom_labels.toml
suggestion: TOML設定ファイルのコメントアウトされた部分を削除し、設定ファイルをよりクリーンに保つことを検討してください。 [medium]
relevant line: #description = """Other changes that do not fit in any of the above categories"""

Persistent review updated  to latest commit https://github.com/Codium-ai/pr-agent/commit/0df054295828c8b1395a1b084a89b99688200d0b

Preparing review...

PR Analysis: Main theme: プルリクエストのラベル処理とCLIコマンドのリファクタリング
PR summary: |-
このプルリクエストでは、PRエージェントにおけるカスタムラベルの処理方法をクラスベースのアプローチに変更し、'add_docs'や'generate_labels'などの新しいCLIコマンドを追加しました。また、PRのタイプを参照するコードを変更し、TOML設定ファイルを新しいPydanticモデル定義に合わせて更新しました。
Type of PR: Refactoring
Relevant tests added: No
Estimated effort to review [1-5]: |-
3, リファクタリングと機能追加が含まれており、新しいクラスベースのアプローチやCLIコマンドの変更を理解する必要があるため、中程度のレビュー労力が必要です。

PR Feedback

💡 General suggestions: このプルリクエストは全体的に良く整理されており、コードの可読性と保守性が向上しています。ただし、新しいクラスベースのラベル処理に関するテストが追加されていないため、機能の正確性を保証するためにテストを追加することをお勧めします。

 🤖 Code feedback:

relevant file: pr_agent/algo/utils.py
suggestion: ラベルの説明をクラス属性のコメントとして追加するのではなく、Enumのdocstringとして追加することを検討してください。これにより、コードの可読性が向上し、ドキュメント生成ツールがラベルの説明をより適切に処理できるようになります。 [important]
relevant line: variables['custom_labels_class'] += f'

relevant file: pr_agent/cli.py
suggestion: 新しいCLIコマンド 'add_docs' と 'generate_labels' のヘルプテキストを追加してください。これにより、ユーザーがこれらのコマンドの使用方法を理解しやすくなります。 [important]
relevant line: - add_docs

relevant file: pr_agent/tools/pr_description.py
suggestion: 'type' および 'labels' キーの存在チェックを行う際に、'in' キーワードを使用する代わりに、より安全な '.get()' メソッドを使用してデフォルト値を提供することを検討してください。これにより、キーが存在しない場合のエラーを防ぐことができます。 [medium]
relevant line: if 'labels' in self.data:

relevant file: pr_agent/settings/custom_labels.toml
suggestion: TOMLファイルの最後に改行を追加してください。これは一般的なファイルフォーマットの慣習であり、将来的な変更で差分をより明確にするのに役立ちます。 [medium]
relevant line:

Persistent review updated  to latest commit https://github.com/Codium-ai/pr-agent/commit/0df054295828c8b1395a1b084a89b99688200d0b

Preparing review...

PR Analysis

🎯 Main theme: プルリクエストのラベル処理のリファクタリングとCLIコマンドの更新
📝 PR summary: このプルリクエストでは、PRエージェントにおけるカスタムラベルの処理方法をクラスベースのアプローチにリファクタリングし、'add_docs'や'generate_labels'などの新しいCLIコマンドを追加しています。
📌 Type of PR: Refactoring
🧪 Relevant tests added: No
⏱ Estimated effort to review [1-5]: 3, このPRは複数のファイルにわたる変更が含まれており、新しいクラスベースのアプローチへの理解と、CLIコマンドの追加に関するレビューが必要です。
🔒 Security concerns: No security concerns found

PR Feedback

💡 General suggestions: このPRは全体的に良く構成されており、コードのリファクタリングとCLIコマンドの追加が適切に行われています。ただし、新しいクラスベースのラベル処理に関連するテストが追加されていないため、機能の正確さを保証するためにテストを追加することをお勧めします。

 🤖 Code feedback:

relevant file: pr_agent/algo/utils.py
suggestion: ラベルの説明を複数行にまたがる文字列からエスケープされた文字列に変換する際に、より安全な方法を検討してください。例えば、json.dumpsを使用することで、特殊文字が適切にエスケープされます。 [important]
relevant line: description = v['description'].strip('\n').replace('\n', '\n')

relevant file: pr_agent/cli.py
suggestion: 新しいCLIコマンド 'add_docs' と 'generate_labels' のヘルプテキストを追加して、ユーザーがこれらのコマンドの使用方法を理解できるようにしてください。 [important]
relevant line: add_docs

relevant file: pr_agent/tools/pr_description.py
suggestion: 'type' と 'labels' のキーを使用する新しいコードに対して、それらのキーがデータ辞書に存在しない場合の処理を追加することを検討してください。これにより、キーが見つからない場合のエラーを防ぐことができます。 [medium]
relevant line: elif 'type' in self.data:

relevant file: pr_agent/settings/pr_custom_labels.toml
suggestion: TOMLファイルのコメントアウトされた例の部分を削除するか、もしくは新しいクラスベースの定義に合わせて更新してください。これにより、設定ファイルの整合性と理解を向上させることができます。 [medium]
relevant line: #description = """Fixes a bug in the code"""

Preparing review...

Preparing review...

PR Analysis

🎯 Main theme: プルリクエストのラベル処理をリファクタリングし、CLIコマンドを更新すること。
📝 PR summary: このプルリクエストでは、PRエージェント内のカスタムラベルの扱いを文字列の連結からクラスベースのアプローチに変更し、'add_docs'や'generate_labels'などの新しいCLIコマンドを追加しました。また、PRのタイプを参照するコードを'PR Type'と'PR Labels'から'type'と'labels'に変更し、TOML設定ファイルを新しいPydanticモデル定義に合わせて更新しました。
📌 Type of PR: Refactoring
🧪 Relevant tests added: No
⏱ Estimated effort to review [1-5]: 3, このPRは複数のファイルにわたる変更が含まれており、新しいクラスベースのアプローチへの変更を理解し、適切に実装されているかを確認する必要があるため、中程度のレビュー労力が必要です。
🔒 Security concerns: No security concerns found

PR Feedback

💡 General suggestions: PRの変更内容を全体的に確認し、新しいクラスベースのアプローチが適切に実装されているか、そして新しいCLIコマンドが期待通りに動作するかを慎重に検証してください。また、TOML設定ファイルの更新が新しいモデル定義に適合しているかも確認が必要です。

 🤖 Code feedback:

relevant file: pr_agent/algo/utils.py
suggestion: ラベルの説明を複数行に渡って記述する際には、適切なエスケープ処理を行うことを確認してください。また、ラベルのキーを小文字とアンダースコアに変換する際には、特殊文字が含まれていないかも確認してください。 [important]
relevant line: description = v['description'].strip('\n').replace('\n', '\n')

relevant file: pr_agent/cli.py
suggestion: 新しいCLIコマンド'add_docs'と'generate_labels'のヘルプテキストを追加し、使用方法を明確に説明してください。 [important]
relevant line: add_docs

relevant file: pr_agent/settings/custom_labels.toml
suggestion: TOMLファイルのコメントアウトされた部分を削除し、設定ファイルをクリーンに保つことを検討してください。不要なコメントは将来の混乱を招く可能性があります。 [medium]
relevant line: #description = """Fixes a bug in the code"""

relevant file: pr_agent/settings/pr_description_prompts.toml
suggestion: Pydanticモデル定義を使用する新しいYAMLスキーマの説明を更新し、古いスキーマの指示を削除してください。これにより、設定ファイルの整合性と可読性が向上します。 [medium]
relevant line: {{ custom_labels_class }}

Persistent review updated  to latest commit https://github.com/Codium-ai/pr-agent/commit/0df054295828c8b1395a1b084a89b99688200d0b

Preparing review...

Persistent review updated  to latest commit https://github.com/Codium-ai/pr-agent/commit/0df054295828c8b1395a1b084a89b99688200d0b

/improve --extended

Preparing review...

Preparing review...

Preparing review...

Preparing review...

Persistent review updated to latest commit https://github.com/Codium-ai/pr-agent/commit/0df054295828c8b1395a1b084a89b99688200d0b

Preparing review...

Persistent review updated to latest commit https://github.com/Codium-ai/pr-agent/commit/0df054295828c8b1395a1b084a89b99688200d0b

Preparing review...

Persistent review updated to latest commit https://github.com/Codium-ai/pr-agent/commit/0df054295828c8b1395a1b084a89b99688200d0b

Preparing review...

Persistent review updated to latest commit https://github.com/Codium-ai/pr-agent/commit/0df054295828c8b1395a1b084a89b99688200d0b

Preparing PR description...

Preparing PR description...

Preparing PR description...

Preparing PR description...

Preparing PR description...

Preparing PR description...

Preparing PR description...

Preparing PR description...

Preparing PR description...

Preparing PR description...

Preparing review...

Persistent review updated to latest commit https://github.com/Codium-ai/pr-agent/commit/1a28c7778325bf2c996a6da6d6c02ef1025f8651

PR Description updated to latest commit (https://github.com/Codium-ai/pr-agent/commit/668041c09fc28ebcfe3782b219900e82b2eef1b2)

Preparing PR description...

Preparing PR description...

Preparing PR description...

PR Description updated to latest commit (https://github.com/Codium-ai/pr-agent/commit/668041c09fc28ebcfe3782b219900e82b2eef1b2)

PR Description updated to latest commit (https://github.com/Codium-ai/pr-agent/commit/668041c09fc28ebcfe3782b219900e82b2eef1b2)

Preparing PR description...

PR Description updated to latest commit (https://github.com/Codium-ai/pr-agent/commit/668041c09fc28ebcfe3782b219900e82b2eef1b2)

Preparing PR description...

repo: Codium-ai/pr-agent


text:
(minor) use format's pluralize directive ("dependenc[y/ies]")

and voilà :)
http://gigamonkeys.com/book/a-few-format-recipes.html

To help you generate messages with words properly pluralized, FORMAT provides the ~P directive, which simply emits an s unless the corresponding argument is 1.

(format nil "file~p" 1)  ==> "file"
(format nil "file~p" 10) ==> "files"
(format nil "file~p" 0)  ==> "files"

Typically, however, you'll use ~P with the colon modifier, which causes it to reprocess the previous format argument.

(format nil "~r file~:p" 1)  ==> "one file"
(format nil "~r file~:p" 10) ==> "ten files"
(format nil "~r file~:p" 0)  ==> "zero files"

With the at-sign modifier, which can be combined with the colon modifier, ~P emits either y or ies.

(format nil "~r famil~:@p" 1)  ==> "one family"
(format nil "~r famil~:@p" 10) ==> "ten families"
(format nil "~r famil~:@p" 0)  ==> "zero families"

Thanks!

authors: dunn vindarel

repo: CodyReichert/qi


text:
Remote repository implementation

Remote repository is now not supported. This should be simple implementation similar to services invocation.

Implemented

repo: Cognifide/knotx


text:
How do I add mathjax support correctly?

I added mathjax script source to head.html in _includes.

My layout for first-post is post-no-feature and has includes head.html

I entered equation in first-post under header "Mathjax Test" but this resulted in no equation being displayed.

How do I resolve this?

Hey @joshfpedro – If you link me to your live site I can take a look

authors: ColeTownsend joshfpedro

repo: ColeTownsend/Balzac-for-Jekyll


text:
Not running on Windows 11

I just downloaded the Windows Binary and opened as administrator but it is instantly closing again.
Any clues would be greatly appreciated.

Sounds like a panic. Could you run the binary from CMD or Powershell and see if you get an error message?

Ah, wait, I wasn't thinking straight when I replied originally. Satpaper only works from the command line - it's closing immediately because you aren't providing the required arguments.
I don't use Windows often, but I think you can either create a shortcut to the binary that specifies the required arguments (see the README for those) or use a batch script. Not sure how to make it run in the background, but I'm fairly certain there's a way.
Let me know if that helps!

Thank you for your time!
Everything works fine now, I will find out the rest.
Very nice Program!

authors: Colonial-Dev Darknessaep

repo: Colonial-Dev/satpaper


text:
Native english language, GPU support through SiaNet

Could you change the repository & subsequently the applications to be both in English & Russia ?
(I could once look at porting the application together with English buttons/labels textzz)
But what i think i couldn't do myself yet (or could pretty hardly) is porting it to supporing GPUs, which could be done by porting it to this framework..
https://github.com/SciSharp/SiaNet

Good day, sorry for the long wait! English will soon be added as a separate branch. Regarding the GPU, I plan to call the OpenCL driver directly from the application via PInvoke. This will allow you to use almost all video cards that are younger than 15 years and different from NVIDIA. It's not that hard to do. Especially as to calculate on GPU makes sense only convolutions as they demand really a lot of calculations. As for other layers, such as pooling and relu, the use of the GPU there can not lead to higher performance.

I had poorly settled notifications, so i didn't even noticed the response, so i yet didn't mind the wait..
I also had a quite silly idea, could you implement the DeepFakes (face swap) for videos software in .NET ? Thought that the Tensorflow.NET or other pre-made libraries would make it easier to code for you, as you wouldn't have to pretty much rewrite the conv code from scratch each time you create a project..

That's an interesting idea. Theoretically, it is possible, but first I need to implement GPU support, otherwise the program will be very slow. To use an unmanaged library, such as tensorflow, I don't want. There are several objective reasons, if necessary, I can tell you about them. I can't promise anything yet.

Maybe we shall collaborate a bit yet..
I think yet i'm maybe pretty terrible at makin' ML code work (in any programming language..), while ya quite fall short on the Windows Form design.. Do you have any account accepting PMs outside of Github ?

You can write me a mail glebbrykin@yandex.ru.

I would like to help try to port this project to some kind of GPU accelerated code. I quickly attempted to use https://github.com/kaby76/Campy but it crashed, and wasn't able to move forward with it really. Really impressive project though.
Your project has been the ONLY project that has really helped me to understand ML in general. Every other one has been too much of a black box. Thank you so much for an amazing collection of work!

Thank you very much for your support! I plan to use OpenCL to work with the GPU. This will allow to use not only the card from NVIDIA, but also any other.

authors: GlebBrykin ad48hp jdluzen


text:
Implement basic kinematics functionality of the helicity formalism

Closes #3
Note: Some functionality of the ComPWA kinematics is still missing #15, #38.

Failed job will be fixed by #42

Good work, also nicely documented! If this module is required to move on with the development, I'm happy to approve and discuss the bigger issues (final state ID and namespaces) separately.

authors: redeboer spflueger

repo: ComPWA/tensorwaves


text:
Created jsdoc comments and updated gruntfile so html will automatically be updated when a file is changed.

Doc folder contains generated html documentation

This has been cleaned up with Pull Requests #36 & #37. Closing.

repo: Comcast/Surf-N-Perf


text:
Fix TR to continue if a DS regex is invalid.

Fixes #1587

Verified an exception is thrown (for each server) and the DS is not available, but other DSs are available.

Can you clean up some of the formatting while you're in this part of the code?
https://github.com/robert-butts/traffic_control/blob/6a093a1537659c3fc5b44d228fbe6ec173c56f45/traffic_router/core/src/main/java/com/comcast/cdn/traffic_control/traffic_router/core/dns/ZoneManager.java#L638
Also can you find a way to express your change without embedding the try catch within another try catch?
I'd recommend adding a unit test however I understand that this is in a private static method which is very large so it's probably not feasible.

authors: dneuman64 robert-butts trevorackerman


text:
Added Byteman to thirdparty libraries.

This adds Byteman. Necessary for the runtime to load the javaagent with Byteman.
This is necessary for setting j.s.Statement.setQueryTimeout method as a workround.

CC @ruhan1  Looks like an error resolving a SNAPSHOT version of galley-transport-httpclient using the Gateway. Looks like the host cannot be resolved. Can this be looked at ?

@whitingjr This is caused by a missing snapshots of galley. I've just rebuilt that snapshots and restart the test. Let's wait for the result.

@whitingjr can this be re-started again. looks like the job was cancelled

authors: ligangty whitingjr

repo: Commonjava/indy


text:
Use softreference as key for ExpiringMemoryNotFoundCache to avoid OOM

According to my debug, the NFC is a big memory eater. I rewrite the ExpiringMemoryNotFoundCache with a soft reference as the key. This can not 100% avoid the OOM since the entries in the Map may not get cleared if the user doesn't call the NfcResource clearing REST APIs. However, this makes sure the heavy ConcreteResources are GC-ed before an OOM occurs. With this fix, I believe Indy can survive much longer and the user should have more chance to call the clear API, in a cheap way. We can 100% avoid the bloating of the Map by running clearAllExpiredMissing more aggressively in the addMissing(). But that will harm the performance so I did not do it. Maybe we can use something like a scheduled job to do the periodical clearing. I will leave further work to master branch. BTW, I added some synchronized blocks to protect the Map from being corrupted. I did not use ConcurrentHashMap because we may iterate over and add/remove concurrently, and a simple ConcurrentHashMap won't suffice.

@jdcasey The comments are missing after I push a new commit with -f.
One of your question is "If we allow GC to expire these entries, that will short-circuit the NFC behavior, leading to Indy retrying the content retrieval earlier than it should. IMO this isn't what we want, since we could end up losing most or all of our NFC when memory pressure builds a little bit, and putting more pressure on the network and Indy itself by retrying all these downloads. This would make Indy less efficient as load increases."
Actually, we do not allow GC to expire them. Soft reference is quite "strong" in terms of when it gets reclaimed. JVM only reclaim soft referenced objects when the memory is used up - just before an OOM. JVM makes sure it releases all soft referenced obj before throwing an OOM. On the other hand, it won't clean soft reference until the program is going to die. It is pretty natural to use it to implement a cache. While weak referenced is not - those are reclaimed as soon as GC runs.
Anyway, I abandon this fix and replace it with a much better one. I will explain the details in JIRA.


text:
Add full CH32V30x support

[x] CH32V303
[x] CH32V305
[x] CH32V307

All board definitions for CH32V30x were autogenerated and do compile.
Complex example tested on CH32V307 board and work fine. Other boards not available for me at the moment.
Assuming basic support was added correctly, reopening if issues appear.


text:
feat: accordion copilot-11963

This PR introduces offset annotations for accordion and accordion items which will be used in the body field of a content type.
Accordion is used to group contextual data together in the form of header and content

Accordion holds the attributes of layout and anchorName
AccordionItem has attributes as header and panel.

Header stores the title of the content in the panel.
Panel holds the content

@copilot-robot prerelease

@copilot-robot prerelease

@copilot-robot prerelease

@copilot-robot prerelease

@copilot-robot prerelease

@copilot-robot prerelease

@copilot-robot prerelease

@copilot-robot prerelease

repo: CondeNast/atjson


text:
Write basic implementation of the HOCON parser

Write unit test for the parser implementation and to check for syntax errors

Closed by #57

repo: ConfigMate/configmate


text:
I need ConnectyCube Dashboard to call my API when call is finished

My app needs reliable information after every call, which is only called once per call between participants. Must be handled on Server and not in Front End JS.
I would like to provide a URL to ConnectyCube dashboard: POST https://myhostname:4000/call/finished
And when any  ConnectyCube 1-to-1 call is finished (Audio call, or Video call). The Call information gets posted to the endpoint. E.g:
  {
    "duration": 100000,
    "callType": "Video",
    "occupant_ids": [123, 223],
    "callStatus": "finished",
    "isSuccessfulCall": "true"
    ...
  }

This is so that in my server I can do:
app.post('/call/finished', function (req, res) {
   console.log(req.body.duration)
})

@stephanoparaskeva
No way to do it trough server.
The WebRTC Peer-to-peer works w/o server. Both users send signaling message via SDP (Session Description Protocol) to each other to setup peer-to-peer connection. Server helps to exchange data to establish communication and doesn't store the info about calls. You can manage this only on front-end side.

@stephanoparaskeva
No way to do it trough server.
The WebRTC Peer-to-peer works w/o server. Both users send signaling message via SDP (Session Description Protocol) to each other to setup peer-to-peer connection. Server helps to exchange data to establish communication and doesn't store the info about calls. You can manage this only on front-end side.

Okay, thank you Vlad!

authors: ccvlad stephanoparaskeva


text:
Project dependencies may have API risk issues

Hi, In mythril, inappropriate dependency versioning constraints can cause risks.
Below are the dependencies and version constraints that the project is using
blake2b-py
coloredlogs>=10.0
coincurve>=13.0.0
cython
cytoolz<0.12.0
asn1crypto>=0.22.0
configparser>=3.5.0
coverage>6.0
py_ecc<5.0.0>=1.4.7
eth_abi<3.0.0>=2.0.0b4
eth-account<0.6.0>=0.5.6
ethereum-input-decoder>=0.2.2
eth-hash<0.4.0>=0.3.1
eth-keyfile<0.6.0>=0.5.1
eth-keys<0.4.0>=0.2.1
eth-rlp<0.3.0>=0.1.0
eth-typing<3.0.0>=2.1.0
eth-utils<2
hexbytes<0.3.0
jinja2>=2.9
MarkupSafe<2.1.0
mock
persistent>=4.2.0
py-flags
py-evm==0.5.0a1
py-solc-x
py-solc
pytest>=3.6.0
pyparsing<3>=2.0.2
pytest-cov
pytest_mock
requests
rlp<3
semantic_version
transaction>=2.2.1
typing-extensions<4>=3.7.4
z3-solver>=4.8.8.0
matplotlib
pre-commit
certifi>=2020.06.20

The version constraint == will introduce the risk of dependency conflicts because the scope of dependencies is too strict.
The version constraint No Upper Bound and * will introduce the risk of the missing API Error because the latest version of the dependencies may remove some APIs.
After further analysis, in this project,
The version constraint of dependency coloredlogs can be changed to >=0.5,<=15.0.1.
The version constraint of dependency configparser can be changed to ==3.5.0b1.
The version constraint of dependency configparser can be changed to >=3.5.1,<=3.5.2.
The version constraint of dependency configparser can be changed to >=3.7.2,<=5.2.0.
The version constraint of dependency eth-utils can be changed to >=1.0.0b1,<=2.0.0.
The version constraint of dependency jinja2 can be changed to >=2.11.0,<=3.1.2.
The version constraint of dependency py-solc can be changed to >=0.6.0,<=3.2.0.
The version constraint of dependency requests can be changed to >=0.14.2,<=2.24.0.
The version constraint of dependency requests can be changed to ==2.26.0.
The version constraint of dependency z3-solver can be changed to >=4.8.11.0,<=4.11.2.0.
The above modification suggestions can reduce the dependency conflicts as much as possible,
and introduce the latest version as much as possible without calling Error in the projects.
The invocation of the current project includes all the following methods.
The calling methods from the coloredlogs
coloredlogs.install

The calling methods from the configparser
configparser.ConfigParser
configparser.ConfigParser.add_section
configparser.ConfigParser.set

The calling methods from the eth-utils
eth_utils.int_to_big_endian
eth_utils.big_endian_to_int

The calling methods from the jinja2
jinja2.Environment.get_template
jinja2.select_autoescape

The calling methods from the py-solc
solc.get_solc_version_string

The calling methods from the requests
requests.Session
requests.adapters.HTTPAdapter

The calling methods from the z3-solver
z3.BoolVal
z3.Extract
z3.simplify
z3.Not
z3.BVMulNoOverflow
z3.Or
z3.BVAddNoOverflow
z3.Solver
z3.BitVecSort
z3.K
z3.And
z3.Concat
z3.is_false
z3.Array
z3.Select
z3.set_param
z3.BitVec
z3.BVSubNoUnderflow
z3.Bool
z3.set_option
z3.Function
z3.Sum
z3.Xor
z3.is_true
z3.substitute
z3.Store
z3.Optimize
z3.If
z3.BitVecVal

The calling methods from the all methods
self.Constraints.super.__iadd__
op.self.instr_pre_hook.append
InstructionCoveragePlugin
detect_mode
d.name
mocker.patch.object
color_map.get
self.super_strategy.get_strategic_global_state.get_annotations
self._memory.get
initial_accounts.keys
mythril.support.signatures.SignatureDB.get
mythril.laser.smt.Optimize.check
mythril.laser.ethereum.transaction.ContractCreationTransaction
mythril.laser.ethereum.state.constraints.Constraints
self.calculate_memory_gas
mythril.ethereum.util.extract_version
state.stack.pop
analyzer.fire_lasers.as_text
mythril.support.model.get_model.decls
annotation.state_change_states.append
os.unlink
set_config.set_api_infura_id
is_assertion_failure
functools.lru_cache
self.work_list.remove
self._register_mythril_modules
create_concolic_parser
mythril.laser.ethereum.function_managers.keccak_function_manager.find_concrete_keccak
mythril.ethereum.interface.rpc.client.EthJsonRpc
ast.literal_eval
self.coverage.items
EtherThief
mythril.laser.ethereum.util.concrete_int_to_bytes
mythril.support.support_utils.sha3
mythril.analysis.module.modules.suicide.AccidentallyKillable
codecs.open
z3.set_param
new_memory.append
self._create_condition
sys.stdout.flush
configparser.ConfigParser.sections
join
SourceCodeInfo
z3.Bool
range
self.conn.cursor
a1.merge_annotation
self.println_ani
hashlib.md5.digest
get_dependency_annotation.extend_storage_write_cache
execute_contract_creation
self.eth.eth_getBalance
matplotlib.pyplot.savefig
mythril.laser.ethereum.call.get_call_parameters
z3.set_option
global_state.mstate.calculate_extension_size
self._init_config
version_line.split.split
contract.disassembly.address_to_function_name.values
contract.get_source_info
parser.add_subparsers.add_parser
str_eval.strip
transaction.call_value.raw.model.eval.as_long
DependenceBucket
self.keys_set.add
mythril.laser.smt.BitVec
length.self.hash_result_store.append
hook_type.self.hook_type_map.append
mythril.laser.ethereum.function_managers.keccak_function_manager.create_conditions
NodeFlags
binascii.a2b_hex
self._modules.extend
self.storage_loaded.union
global_state.mstate.subroutine_stack.append
sys.stderr.write
self.MachineStack.super.pop
mythril.laser.ethereum.transaction.concolic.execute_transaction
cur.execute
global_state.mstate.check_gas
TimeHandler
_arithmetic_helper
self._handle_create_type_post
state.mstate.stack.annotate
mythril.laser.smt.Solver.check
mythril.laser.ethereum.transaction.symbolic.execute_transaction
mythril.laser.smt.URem
os.path.expanduser
rpc.split
self.tuple.__hash__
plugin_builder
dynamic_loader.dynld
x.upper
mythril.laser.smt.K
configparser.ConfigParser.get
global_state.mstate.mem_extend
mythril.mythril.MythrilConfig
issue.contract.contract_data.remove
_check_basic_block
self.keys_get.add
annotation.path.append
data.concrete
solcx.import_installed_solc
mythril.laser.ethereum.util.get_instruction_index
laser_evm.edges.append
ops.get_variable
eth_hash.auto.keccak.hex
self.get_easm
input_file.data.items
_get_concrete_state
self._code_copy_helper
ord
global_states.remove
extension
base.annotations.union
self.register_laser_hooks
mythril.plugin.discovery.PluginDiscovery.build_plugin
atexit.register
retrieve_callback_issues
self.config_path.open.close
result.append
re.sub
plugin
self.manage_cfg
op_code.self.instr_post_hook.op_code.self.instr_pre_hook.self.dynamic_loader.op_code.Instruction.evaluate
state.mem_extend
self.work_list.sort
self.storage_keys_loaded.add
self.put_account
dynamic_loader.read_balance
self.mem_extend
mythril.mythril.MythrilDisassembler
states.append
self._call
d.model.as_list
expression.decl
mythril.analysis.module.loader.ModuleLoader
self.post_handler
opcode.self.instr_pre_hook.append
mythril.laser.ethereum.evm_exceptions.OutOfGasException
global_state.world_state.accounts.values
self.changed_files.append
mythril.laser.plugin.plugins.plugin_annotations.MutationAnnotation
offset.idx.self.solc_indices.data.encode.count
mythril.plugin.discovery.PluginDiscovery.installed_plugins
f.write
LastJumpAnnotation
mythril.plugin.discovery.PluginDiscovery.is_installed
m.group
mythril.support.start_time.StartTime
_transaction_end
annotation.blocks_seen.add
mythril.laser.ethereum.time_handler.time_handler.time_remaining
convert_bv
platform.system
os.path.expanduser.split
z3.Optimize
self._make_stats
mythril.laser.smt.LShR
functools.reduce
_comparison_helper
self.symbolic_inputs.values
self.wrap
ops.Call
signature_database.get
mythril.laser.ethereum.state.world_state.WorldState.put_account
self._init_solc_binary
z3.BoolVal
mythril.laser.smt.UDiv
initial_accounts.items
mythril.laser.smt.Solver.add
self._merge_buckets
os.mkdir
mythril.support.loader.DynLoader
global_state.environment.active_account.code.assign_bytecode
mythril.disassembler.asm.disassemble
self.raw.sexpr
c.encode
state.get_annotations
mythril.laser.ethereum.call.native_call
plugin_builder.initialize
global_state.world_state.constraints.append
self._create_transaction_helper
self.raw.__hash__
create_func_to_hash_parser
sqlite3.connect
new_state.world_state.constraints.append
self.Constraints.super.copy
utils.hex_to_dec
state.memory.write_word_at
mythril.laser.smt.Optimize.maximize
line.strip.strip
z3.Array
global_state.current_transaction.end
mythril.laser.plugin.plugins.MutationPrunerBuilder
mythril.laser.smt.Optimize.sexpr
self.installed_plugins.items
coincurve.PublicKey.from_signature_and_message.format
state.get_current_instruction.startswith
account.balance
self.update_calls
JumpdestCountAnnotation
argparse.ArgumentParser.add_subparsers
global_state.transaction_stack.append
find_op_code_sequence
self.acquire
dynamic_loader.read_storage
eth._utils.blake2.coders.extract_blake2b_parameters
mythril.laser.ethereum.transaction.MessageCallTransaction
module.execute
self.raw.check
execute_command
list
mythril.laser.ethereum.strategy.BasicSearchStrategy.__init__
self.register_instr_hooks
mythril.laser.ethereum.instruction_data.get_required_stack_elements
mythril.laser.smt.SolverStatistics
transfer_ether
stdout.decode
global_state.world_state.accounts_exist_or_load
mythril.laser.smt.Concat
mythril.analysis.issue_annotation.IssueAnnotation
details.items
mythril.laser.ethereum.instructions.Instruction
self.models.append
global_state.mstate.stack.pop
Instruction._sha3_gas_helper
exec
Args
semantic_version.NpmSpec.match
mythril.ethereum.util.solc_exists
constraints.append
actual_hook.hook_dict.append
z3.BitVecVal
length.offset.offset.solidity_file.data.encode.decode.decode
self.sigs.import_solidity_file
module.reset_module
symbolic_vm.post_hook
get_opcode_from_name
py_ecc.optimized_bn128.FQ12.one
ACTORS.addresses.values
py_ecc.optimized_bn128.normalize
z3.Or
func
isinstance
SQLiteDB
self.coverage.keys
OPCODES.items
configparser.ConfigParser.write
self._source_hash.index
re.findall
self.output.isatty
subparsers.add_parser.add_argument_group
time.sleep
mythril.laser.smt.Optimize.minimize
self._annotations.append
self.check_gas
LolCat
mythril.disassembler.asm.find_op_code_sequence
map
state.new_bitvec
mythril.ethereum.util.get_solc_json
hook_dict.items
state.world_state.constraints.is_possible
self._new_node_state
set.union
args.branches.split
os.path.exists
other.storage_written.keys
mythril.support.support_utils.get_code_hash
self.set_api_rpc_localhost
self.serialised_code
parts.append
super.reset_module
json.dumps
format.write_text
open
eth_utils.int_to_big_endian
stack.pop
Report.environment.get_template
is_sequence_match
mythril.analysis.potential_issues.get_potential_issues_annotation
size.value.mem_start.value.mem_start.value.state.mstate.memory.bytes.eth_abi.decode_single.decode
parse_args_and_execute
py_ecc.optimized_bn128.FQ2
annotations.union.union
z3.If.domain
mythril.support.support_args.args.solver_log.Path.mkdir
Bool
logging.info
self.calculate_extension_size
mythril.laser.smt.BVMulNoOverflow
self.size.raw.model.eval.as_long
_issues.append
binascii.b2a_hex
encode
mythril.laser.smt.Concat.size
BenchmarkPlugin
mythril.laser.ethereum.time_handler.time_handler.start_execution
mythril.mythril.MythrilDisassembler.load_from_address
mythril.laser.ethereum.strategy.concolic.ConcolicStrategy
_replace_with_actual_sha
OverUnderflowAnnotation
symbolic_vm.coverage.items
analyzer.fire_lasers.as_markdown
mythril.analysis.security.retrieve_callback_issues
self.blocks_seen.union
z3.BVMulNoOverflow
global_state.transaction_stack.pop
BoundedLoopsStrategy.calculate_hash
mythril.laser.ethereum.svm.LaserEVM
self.assertEqual
NotImplementedError
BoundedLoopsStrategy.count_key
mythril.laser.ethereum.state.machine_state.MachineState
random.randint
s_index.tx.replace
code_split.append
mythril.analysis.potential_issues.Issue
set_config.set_api_from_config_path
ExternalCalls
sig.self.solidity_sigs.append
os.path.dirname
sorted
hasattr
mythril.laser.ethereum.state.account.Account.set_balance
self._accounts.keys
index.instruction_list.rjust
copy.deepcopy
execution_info.as_dict
SourceMapping
mythril.laser.ethereum.state.calldata.ConcreteCalldata
account.serialised_code
self.MachineStack.super.append
mythril.laser.ethereum.evm_exceptions.InvalidJumpDestination
disassembler.contracts.get_creation_easm
mythril.analysis.ops.get_variable
self.Array.super.__init__
env.get_template.render
self.eth_coinbase
mythril.analysis.module.modules.exceptions.Exceptions
time.time
mythril.laser.smt.array.Array
matplotlib.pyplot.ylabel
self.world_state.annotate
self.creation_disassembly.get_easm
DependencyPruner
state.memory.get_word_at
self.session.close
hashlib.md5
mythril.laser.smt.Optimize
global_state.mstate.subroutine_stack.pop
mythril.ethereum.util.safe_decode
d.hex.rstrip
mythril.laser.smt.simplify.size
mythril.analysis.report.Report
self.installed_plugins.keys
mythril.laser.smt.Solver
array.domain.size
ULT
self.plugin_args.get
self.get_solc_indices
py_ecc.optimized_bn128.FQ2.zero
mstate.mem_extend
multiprocessing.Lock
self.eth.eth_getStorageAt
mythril.laser.smt.bool.Bool
semantic_version.NpmSpec
super.initial_global_state_from_environment
hashlib.new
world_state.create_account
self.find_concrete_keccak
mythril.laser.ethereum.state.world_state.WorldState
self.buckets.remove
hashlib.sha256
function_name.find
z3.Store
self._accounts.values
math.ceil
mythril.analysis.solver.get_model
laser_evm.work_list.append
setuptools.setup
state.node.states.append
issue.resolve_function_names
exc.output.decode
iteration.self.storage_written.add
mythril.laser.ethereum.function_managers.keccak_function_manager.create_keccak
mythril.plugin.discovery.PluginDiscovery
self.conn.commit
self.laser.extend_strategy
_add_calldata_placeholder
self.load
_get_padded_hex_address
dict
math.sin
self._ostates_satisfiable.add
mythril.laser.smt.UGT.append
WSDependencyAnnotation
mythril.laser.ethereum.instruction_data.get_opcode_gas
args.__dict__.get
args.modules.strip
self.set_criterion_satisfied
mythril.laser.ethereum.call.get_call_data
py_ecc.optimized_bn128.add
self.accumulate_gas
contract_data.items
_get_concrete_transaction
mythril.ethereum.util.get_solc_json.values
line.strip.startswith
data.size
mythril.laser.smt.bitvec.BitVec
math.log2
strategy.split
mythril.concolic.concolic_execution
NAME.lower.replace
stderr.command.check_output.decode
mythril.laser.smt.ULT
UserAssertions
b.annotations.a.annotations.union.union
state.world_state.annotate
mythril.laser.smt.symbol_factory.BitVecSym
mythril.laser.ethereum.util.extract_copy
get_runtime_input_parser
self.create_account
self.constraints.pop
get_dependency_annotation.get_storage_write_cache
self.op_code.startswith
z3.BVSubNoUnderflow
solcx.install_solc
exceptions.BadResponseError
node.get_cfg_dict
MachineStack
instruction.startswith
self.laser.sym_exec
mythril.ethereum.util.extract_binary
contract_data.values
GlobalState
input.iterdir
mythril.laser.smt.symbol_factory.Bool
max
length.self.symbolic_inputs.append
json.load
configparser.ConfigParser.set
op_code.upper
exit
self.raw.model
mythril.analysis.module.modules.multiple_sends.MultipleSends
attacker_constraints.append
mythril.analysis.traceexplore.get_serializable_statespace
mythril.mythril.MythrilConfig.init_mythril_dir
mythril.laser.ethereum.transaction.execute_message_call
mythril.interfaces.cli.main
mythril.laser.smt.Optimize.model
self.handle_vm_exception
self._handle_shift
z3.If
create_safe_functions_parser
load_code
self.MachineStack.super.__init__
potential_issue.detector.update_cache
NAME.lower
filter
state.constraints.is_possible
self._reads.append
z3.Extract
self.raw.minimize
length.offset.offset.solidity_file.data.encode.decode
analyzer.fire_lasers.as_json
solc.get_solc_version_string
mythril.plugin.loader.MythrilPluginLoader
self._modules.append
flip_branches
_SmtSymbolFactory
mythril.analysis.symbolic.SymExecWrapper
file.split
self.raw.append
stack.append
solcx.get_installable_solc_versions
create_disassemble_parser
mythril.laser.ethereum.state.environment.Environment
io.open
mythril.analysis.module.get_detection_module_hooks
ethereum_input_decoder.decoder.FourByteDirectory.lookup_signatures
report.issues.values
validate_args
bytecode.startswith.startswith
py_ecc.optimized_bn128.is_on_curve
a.annotations.union
exceptions.append
str.split
self.annotations.union
min.extend
UGT
self.conn.close
instruction_mutator
tuple
self._execute_post_hook
self._write_to_graph
value.encode
int.hex
self.issues.values
shutil.copyfile
address.self.sloads_on_path.append
int
solidity_file.data.encode
bytearray
func.sha3.hex
mythril.laser.ethereum.evm_exceptions.StackUnderflowException
Storage
mythril.laser.smt.Bool
subprocess.Popen
get_utilities_parser
mythril.laser.ethereum.util.pop_bitvec
self._set_internal_compiler_error
self.release
self.session.post
self._ostates_unsatisfiable.add
print_function_report
ValueError
state.get_current_instruction
issue.title.issue.address.str.issue.function.issue.contract.encode
args.modules.strip.split
error_msg.split.split
contract.solc_indices.values
self._store_report
self._is_covered
rest.split.split
issubclass
self.println
op_code.endswith
self.sort_and_eliminate_states
contract.split
random.uniform
mythril.laser.smt.Extract
eth._utils.address.generate_contract_address
self.online_lookup_miss.add
TESTDATA_OUTPUTS_CURRENT.mkdir
self.super_strategy.get_strategic_global_state.get_current_instruction
add_graph_commands
requests.Session
STRIP_ANSI.sub.decode
transaction.call_data.concrete
self.sorted_issues
mythril.laser.ethereum.cfg.Edge
mythril.laser.smt.Optimize.add
self._execute_transactions
self.storage_written.get
get_callee_address
self.get_function
argparse.ArgumentParser.add_argument
mythril.laser.smt.BVSubNoUnderflow
IndexError
self._add_dynamic_loading_option
self.dynamic_loader.address.value.global_state.world_state.accounts_exist_or_load.balance
mythril.laser.ethereum.transaction.transaction_models.ContractCreationTransaction.initial_global_state
mythril.laser.ethereum.instruction_data.calculate_sha3_gas
mythril.analysis.module.modules.arbitrary_jump.ArbitraryJump
z3.Select
argparse.FileType
jinja2.Environment.get_template
inv
Constraints.append
self.wanna_execute
solcx.install.get_executable
self.update_sloads
self.raw.index
MultipleSendsAnnotation
int.to_bytes
nodes.append
self.Constraints.super.__add__
SolidityContract
self.raw.pop
configparser.ConfigParser.add_section
float
state.stack.append
mythril.laser.ethereum.transaction.tx_id_manager.get_next_tx_id
code_raw.append
m.group.sha3.hex
find_input.inverse.raw.model.eval.as_long
traceback.format_stack
Storage.items
self._end_message_call
sqlite3.OperationalError
world_state.accounts.values
mythril.mythril.MythrilDisassembler.load_from_bytecode
self._get_covered_instructions
SolidityContract.get_full_contract_src_maps
mythril.laser.ethereum.function_managers.exponent_function_manager.create_condition
mythril.laser.ethereum.evm_exceptions.WriteProtection
self.get_strategic_global_state
self.concrete_hashes.items
size.concrete_hashes.append
mythril.analysis.module.modules.delegatecall.ArbitraryDelegateCall
self._load_detection_module
dynloader.read_balance
z3.Not
get_call_data
self._write_symbolic_returndata
self.cache.add
AccidentallyKillable
os.getenv
_get_expr_variables
ecrecover_to_pub
mythril.analysis.module.ModuleLoader
EvmInstruction
type.get_all_constraints
re.match
BitVec
mythril.analysis.module.modules.integer.IntegerArithmetics
SolverStatistics
re.search
global_state.environment.active_account.set_balance
mythril.analysis.report.Issue
parser.add_argument_group.add_argument
self.source_list.append
hash
self.update_sstores
self.raw.size
mythril.laser.plugin.plugins.plugin_annotations.DependencyAnnotation
mythril.laser.ethereum.instruction_data.calculate_native_gas
strategy
model.eval.as_long
get_ws_dependency_annotation
extract_version
state_annotation.overflowing_state_annotations.add
target.get_current_instruction
bytes.fromhex
self._is_autogenerated_code
STRIP_ANSI.sub.rstrip
solc_exists
repr
mythril.laser.smt.Optimize.set_timeout
mythril.laser.ethereum.transaction.transaction_models.MessageCallTransaction
create_analyzer_parser
DependencyAnnotation
re.search.group
requests.adapters.HTTPAdapter
mythril.mythril.MythrilDisassembler.hash_for_function_signature
self._reset
self.loaded_plugins.append
self.edges.append
mythril.exceptions.IllegalArgumentError
global_state.get_annotations
argparse.ArgumentParser.add_argument_group
self.eth.eth_getCode
truncated_code.replace.replace
transaction.caller.raw.model.eval.as_long.zfill
item.split
self.init_installed_plugins
FileLockException
contracts.append
BoundedLoopsStrategy.get_loop_count
mythril.laser.ethereum.transaction.transaction_models.MessageCallTransaction.initial_global_state
self.laser.register_hooks
mythril.analysis.module.modules.external_calls.ExternalCalls
op_code.hook_dict.append
synchronized
pytest.raises
return_global_state.add_annotations
random.choices
issue.add_code_info
pow
_get_overflowunderflow_state_annotation
symbolic_vm.pre_hook
self.pre_hooks.keys
global_state.mstate.stack.append
mythril.analysis.module.loader.ModuleLoader.register_module
os.open
operation
get_potential_issues_annotation
WorldState
mappings.append
outtxt.append
mythril.solidity.soliditycontract.SolidityContract
InstructionProfiler
round
global_state.mstate.pop
mythril.mythril.MythrilAnalyzer.dump_statespace
m.strip
argparse.ArgumentParser
mythril.analysis.ops.Call
mythril.plugin.discovery.PluginDiscovery.get_plugins
mythril.laser.ethereum.util.get_concrete_int
jinja2.Environment
logging.getLogger.warning
mythril.laser.smt.If.size
index.instruction_list.bytes.hex
coincurve.PublicKey.from_signature_and_message
mythril.laser.smt.bool.And
self.post_hooks.keys
annotation.potential_issues.extend
value.raw.model.eval.as_long
z3.is_false
PredictableValueAnnotation
self.MachineStack.super.__len__
mythril.laser.ethereum.transaction.transaction_models.tx_id_manager.get_next_tx_id
abs
opcode.self.instr_post_hook.append
self.__next__
mythril.analysis.report.Report.append_issue
self._source_hash.append
mythril.disassembler.disassembly.Disassembly
annotation.storage_loaded.add
s.check.append
_InstrExecStatistic
run
logging.getLogger.setLevel
hook
re.match.group
op.self.instr_post_hook.append
mythril.laser.smt.And
mythril.ethereum.util.get_indexed_address
hash_parser.add_argument
mythril.laser.plugin.plugins.CallDepthLimitBuilder
_set_minimisation_constraints
z3.Function
input_file.data.keys
mstate.stack.pop
re.split
z3.Concat.size
mythril.laser.smt.ULE
mythril.laser.ethereum.util.extract32
mythril.analysis.module.modules.state_change_external_calls.StateChangeAfterCall
z3.Sum
self.open_states.append
py_ecc.optimized_bn128.FQ2.one
os.system
LolCat.cat
StateChangeCallsAnnotation
mythril.laser.ethereum.function_managers.keccak_function_manager.get_empty_keccak_hash
PotentialIssuesAnnotation
version.startswith
DependenceMap
TypeError
py_ecc.optimized_bn128.pairing
self.call_on_state_copy
get_dependency_annotation
self._distance
UncheckedRetval
mythril.exceptions.CompilerError
self.__copy__
Memory
typing.cast.size
internal_model.decls
account.pop
self.work_list.pop
json.dump
self.accounts.values
x.startswith
mythril.analysis.module.modules.unchecked_retval.UncheckedRetval
self._execute_pre_hook
print
mythril.analysis.module.loader.ModuleLoader.get_detection_modules
self.Constraints.super.append
array.range.size
element.to_dict
self.laser_plugin_builders.items
safe_ord
min_price_dict.get
mythril.solidity.soliditycontract.get_contracts_from_file
matplotlib.pyplot.xlabel
semantic_version.Version
hex_encoded_string.startswith
mythril.laser.ethereum.state.calldata.SymbolicCalldata
mythril.analysis.potential_issues.check_potential_issues
OverUnderflowStateAnnotation
sys.argv.remove
SolidityContract.get_sources
merged_annotation.annotations_stack.append
self._check_execution_termination
color_map.keys
issues.append
mythril.laser.smt.bitvec.BitVec.size
isinstance.simplify
super.__init__
StateTransition
subparsers.add_parser.add_argument
typing.cast
argparse.ArgumentParser.print_help
d.model.as_long
eth_abi.decode_abi
self.raw.set
WorldState.put_account
line.rstrip
Issue.resolve_input
state.get_current_instruction.lower
f.read
TransactionEndSignal
symbolic_vm.laser_hook
self.ansi
subprocess.Popen.communicate
self._normalize_byte_sig
edges.append
mythril.support.opcodes.OPCODES.keys
configparser.ConfigParser
mythril.mythril.MythrilAnalyzer.fire_lasers
args.code.startswith
get_creation_input_parser
self.contracts.append
laser_evm.exec
file_path.solc_json.values
self._distance.sort
subprocess.check_output
mythril.analysis.module.base.Issue
self._execute_post_hooks
mythril.exceptions.CriticalError
unsat_potential_issues.append
annotation.trace.append
min
transaction.get
state_accounts.append
self.MachineStack.super.__getitem__
pathlib.Path
bytes
py_ecc.optimized_bn128.multiply
op_code.self.pre_hooks.append
world_state.accounts_exist_or_load
self.source.get_source_from_contracts_list
disassemble
set.add
TxOrigin
os.urandom.binascii.b2a_hex.decode
extract_nodes
packages.append
traceback.format_exc
self.session.post.json
constraints.copy
IssueAnnotation
ArbitraryDelegateCall
self._calldata_copy_helper
z3.If.range
self.instruction_coverage_plugin.is_instruction_covered
random.randrange
mythril.laser.smt.Or
l.strip
logging.getLogger.info
z3.BVAddNoOverflow
mythril.laser.plugin.plugins.InstructionProfilerBuilder
mythril.mythril.MythrilDisassembler.load_from_solidity
m.group.replace
val.to_bytes
get_function_info
self.disassembly.get_easm
self.Constraints.super.__init__
get_requirements
self._add_default_options
argparse.ArgumentParser.parse_args
mythril.laser.plugin.plugins.plugin_annotations.WSDependencyAnnotation
args.storage_slots.strip.split
address.self.sstores_on_path.append
Report.environment.get_template.render
UnsupportedPluginType
global_state.world_state.transaction_sequence.append
get_output_parser
operator.itemgetter
mythril.support.support_utils.zpad
StateChangeAfterCall._balance_change
self.rainbow
Constraints
mythril.laser.ethereum.cfg.Node
self.storage_accessed_global.add
exceptions.BadJsonError
len
mstate.stack.append
self._load_default_enabled
self.domain.append
OldBlockNumberUsedAnnotation
expression.simplify
_InstrExecRecord
configparser.ConfigParser.has_option
self._annotations.add
self._check_create_termination
self.issues.items
generate_function_constraints.append
CallDepthLimit
RuntimeError
execute_message_call
mythril.support.model.get_model.eval
meta_data.update
StateChangeAfterCall
TESTDATA_OUTPUTS_CURRENT_LASER_RESULT.mkdir
mythril.laser.ethereum.state.constraints.Constraints.append
mythril.support.model.get_model
mythril.analysis.module.module_helpers.is_prehook
add_analysis_args
PredictableVariables
mythril.laser.plugin.plugins.DependencyPrunerBuilder
offset.bytes.hex
super
self.set_api_rpc_infura
mythril.analysis.callgraph.generate_graph
z3.simplify
other.storage_written.get
self.storage_written.keys
py_ecc.optimized_bn128.final_exponentiate
eval
final_states.append
Account
self._generate_new_address
UncheckedRetvalAnnotation
MutationPruner
flip_branches.append
setup_concrete_initial_state
world_state_annotation.annotations_stack.append
self.dynld.read_storage
list.items
re.compile
self.output.write
exit_with_error
args.storage_slots.strip
solcx.set_solc_version
bytes_data.hashlib.sha256.digest
StateChangeAfterCall._add_external_call
modules.append
start_signal.transaction.initial_global_state
jinja2.select_autoescape
concrete_input.size
self.buckets.append
mythril.support.support_utils.rzpad
DependenceMap.add_condition
mythril.laser.ethereum.util.get_concrete_int.append
set
cur.fetchall
func_input.size
mythril.laser.smt.symbol_factory.BitVecVal
self.raw
StateTransition.check_gas_usage_limit
a.strip
mythril.laser.ethereum.natives.native_contracts
r.end_time.timestamp
mythril.laser.ethereum.state.memory.Memory
mythril.analysis.module.modules.dependence_on_origin.TxOrigin
call_offsets.append
code.bytearray.hex
mythril.laser.plugin.loader.LaserPluginLoader.add_args
jinja2.PackageLoader
child.get
f
analyzer_parser.add_argument_group.add_argument
self.session.mount
logging.getLogger.error
mythril.laser.smt.SRem
generate_function_constraints
self._get_args
matplotlib.pyplot.axis
utils.output_of
ret_lis.append
eth._utils.numeric.ceil32
self.check_gas_usage_limit
mythril.exceptions.DetectorNotFoundError
hashlib.md5.update
_setup_global_state_for_execution
mythril.support.source_support.Source.get_source_from_contracts_list
mythril.support.signatures.SignatureDB
self.raw.add
eth._utils.bn128.validate_point
get_rpc_parser
set.key.self.storage_written.get.union
self._load
eth_abi.decode_single
get_callee_account
mythril.laser.plugin.plugins.CoveragePluginBuilder
vulnerabilities.append
mythril.laser.plugin.loader.LaserPluginLoader.load
exceptions.BadStatusCodeError
mythril.laser.smt.Not
datetime.datetime.now
self.beam_priority
address.symbol_factory.BitVecVal.initial_world_state.starting_balances.raw.model.eval.as_long
mythril.laser.smt.BVAddNoOverflow
ostate.get_current_instruction
pkg_resources.iter_entry_points
self.get_current_instruction
format
KeccakFunctionManager
MultipleSends
self.size
result.extend
instruction_list.append
mythril.mythril.MythrilAnalyzer
get_state_accounts
index.instruction_list.bytes.hex.rjust
mythril.laser.ethereum.state.global_state.GlobalState
mythril.laser.plugin.loader.LaserPluginLoader
logging.debug
eth_hash.auto.keccak
mythril.laser.ethereum.state.account.Account
global_state.annotate
val.simplify.value.to_bytes
_padded_operation
self._make_bitvec_if_not
self.println_plain
json.loads.get
op0.annotate
bytearray_to_int
os.getcwd
op_code.self.post_hooks.append
TxOriginAnnotation
self.installed_plugins.get
os.path.realpath
os.urandom
mythril.disassembler.asm.instruction_list_to_easm
self.solidity_sigs.get
z3.BitVecSort
a1.check_merge_annotation
global_state.new_bitvec
mythril.laser.smt.bool.Or
r.start_time.timestamp
pytest.mark.parametrize
mythril.analysis.module.modules.user_assertions.UserAssertions
op_code.entrypoint.extend
self._get_smt_bool_list
self.op_code.lower
self.memory.extend
mythril.analysis.module.modules.ether_thief.EtherThief
self.calls.append
contract_hash_to_address
retvals.append
IntegerArithmetics
bytes_data.hashlib.new.digest
self.set_api_rpc
edge.condition.simplify.str.replace
version_line.re.search.group
self.simplify
mythril.analysis.module.modules.arbitrary_write.ArbitraryStorage
self._set_rpc
SolidityFile
mythril.mythril.MythrilDisassembler.get_state_variable_from_storage
os.path.abspath
str
mythril.laser.smt.Array
data.binascii.b2a_hex.decode
analyzer.fire_lasers.as_swc_standard_format
setuptools.find_packages
insert_ret_val
mythril.laser.smt.UGE
Variable
self.increment_states_pc
a.size
inverse
_z3_array_converter
line.strip.split
type
functools.wraps
self.super_strategy.get_strategic_global_state
getattr
self.func_hashes.append
mythril.laser.ethereum.transaction.TransactionStartSignal
self.update_cache
logging.getLogger.critical
copy.copy.get_current_instruction
mythril.laser.ethereum.transaction.transaction_models.tx_id_manager.restart_counter
mythril.ethereum.evmcontract.EVMContract
self._execute
mythril.analysis.potential_issues.get_potential_issues_annotation.get_issue
configparser.ConfigParser.read
SignatureDB
datetime.timedelta
coloredlogs.install
self._add_world_state
os.path.join
collections.namedtuple
TraceAnnotation
TxIdManager
os.environ.get.endswith
os.environ.get
self.raw.reset
self._get_exception_data
power
Exceptions
z3.Solver
self.compare_files_error_message
self.add_block_data
z3.K
self._get_solc_mappings
z3.And
nonce.creator.generate_contract_address.hex
json.load.update
int_to_32bytearray
self.is_installed
state.annotate
self.balance
mythril.mythril.MythrilAnalyzer.graph_html
re.compile.sub
collections.defaultdict
potential_issue.detector.issues.append
self._execute_pre_hooks
minimize.append
mythril.laser.smt.model.Model
logging.getLogger.debug
self._normalize_byte_sig.startswith
contract.items
global_state.get_current_instruction
sys.path.insert
data.value.to_bytes
state.get_current_instruction.upper
NAME.lower.replace.replace
typing.TypeVar
operator
set_config
expression.children
disassembler.contracts.get_easm
trace_data.keys
z3.Xor
utils.validate_block
int.from_bytes
mythril.support.source_support.Source
mythril.laser.ethereum.util.concrete_int_from_bytes
main
mythril.laser.ethereum.util.extract32.to_bytes
hex
state.world_state.get_annotations
ArbitraryJump
z3.substitute
self.init_mythril_dir
self.raw.as_long
self.raw.maximize
super.__or__
mythril.laser.ethereum.evm_exceptions.VmException
TxIdManager.get_next_tx_id
self.assign_bytecode
py_ecc.secp256k1.ecdsa_raw_recover
ArbitraryStorage
concrete_data.items
enumerate
self.super_strategy.get_strategic_global_state.annotate
environment.calldata.get_word_at
self._file_name
mythril.laser.ethereum.transaction.execute_contract_creation
mythril.laser.smt.Solver.set_timeout
mythril.laser.ethereum.function_managers.keccak_function_manager.reset
self.lookup_online
bytes.hex
mythril.laser.ethereum.evm_exceptions.StackOverflowException
trace_data.values
edge.condition.str.replace
is_unique_jumpdest
mythril.laser.ethereum.function_managers.keccak_function_manager.get_concrete_hash_data
self.constraints.extend
self.execute_state
os.close
mythril.analysis.potential_issues.PotentialIssue
cls.Singleton.super.__call__
self.add
ExponentFunctionManager
self.source.get_source_index
entry_point.load
mythril.analysis.module.reset_callback_modules
concrete_transactions.append
eth_utils.big_endian_to_int
mythril.concolic.find_trace.concrete_execution
encode_int32
z3.Concat
sum
self.output.flush
self._load_laser_plugin
json.loads
create_read_storage_parser
re.sub.split
Actors
transaction.caller.raw.model.eval.as_long
re.sub.replace
self.get
z3.BitVec
global_state.environment.active_account.balance
mythril.laser.smt.simplify
mythril.laser.smt.is_false
self.check_completion_criterion
extract_edges
sys.exit
logging.getLogger
mythril.laser.plugin.loader.LaserPluginLoader.instrument_virtual_machine
mythril.analysis.security.fire_lasers
set_config.set_api_rpc
key.size
self._analyze_state
symbolic_vm.instr_hook
idx.self.solc_indices.data.encode
mythril.laser.smt.If
mythril.analysis.solver.get_transaction_sequence
op_code.self.records.append
z3.is_true
mythril.laser.smt.Function
sys.stdout.write
create_hash_to_addr_parser
internal_model.eval
self.records.items
model.eval
address.PRECOMPILE_FUNCTIONS
copy.copy
zip
mythril.laser.smt.UGT
matplotlib.pyplot.plot
mythril.laser.ethereum.strategy.basic.BasicSearchStrategy.__init__
mythril.laser.ethereum.transaction.transaction_models.ContractCreationTransaction
mythril.analysis.module.ModuleLoader.get_detection_modules
mythril.analysis.module.modules.dependence_on_predictable_vars.PredictableVariables
mythril.support.lock.LockFile
blake2b.compress
new_node.states.append
MachineState
mythril.laser.ethereum.state.return_data.ReturnData
world_state_annotation.annotations_stack.pop

@developer
Could please help me check this issue?
May I pull a request to fix it?
Thank you very much.

Hi @PyDeps
Yes, that should be helpful. Feel free to open a Pull Request.

authors: PyDeps norhh

repo: ConsenSys/mythril


text:
Replace run.sh with something maintainable

Description
scripts/run.sh is a handy but hacky script which is quite hard to maintain and fiddly to use. We should replace it with something like a docker compose configuration.
Acceptance Criteria

Provide a way to quickly and easily run a multi-node local teku testnet
Don't use interop mode (use a local besu instance to provide a real ETH1 chain)

Done.

Done.

repo: ConsenSys/teku


text:
Remove network flag from Web3Signer

Instead rely on the information provided by the validator client request.
This can help avoid certain misconfigurations, e.g. a fork epoch mismatch between VC and w3s.

Closing issue. Web3Signer need --network flag.

authors: siladu usmansaleem


text:
Updating Linux images for executors in CircleCI

PR Description
The images we were using have been deprecated. I have updated them to a newer version.

is this an lts image?

is this an lts image?

Yep. 22.04 is an LTS version

authors: lucassaldanha rolfyone

repo: Consensys/teku


text:
Improve logging on validator loading errors

PR Description
Currently we print only InvalidConfigurationException to default console log in MultithreadedValidatorLoader.loadValidators() and shutdown on any exception during validator startup. It could confuse user seeing exit without any visible cause (until user uses --log-destination=console, which is not default or check logs).

Validator loading errors in loadValidators()  could be not only InvalidConfigurationException
Validator loading errors could happen in addValidatorsFromSource, for example when local keys directory is provided which doesn't exist
Other Validator Service Loading errors should be displayed to the user in any case as we shutdown

Fixed Issue(s)

Documentation

[x] I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

[x] I thought about adding a changelog entry, and added one if I deemed necessary.

3 acceptance tests fail because locally it's:
ERROR - Failed to load keystore, error: Keystore file /opt/teku/keys/9894149_validator.json.lock already in use.
ERROR - Unable to initialize validator client service, please manually correct errors and try again.

and on CI it's
ERROR - Failed to load keystore, error: Access Denied trying to access lock file /keys/8eff122_validator.json.lock
ERROR - Unable to initialize validator client service, please manually correct errors and try again.

Working to resolve this


text:
[TOOLS-735] Update Faraday version to resolve dependencies

Update Faraday version to update dependencies as new sentry SDK depends on a newer version of Faraday

Do not merge this yet! Faraday >= 1.0 seems to be breaking many other dependencies in website gems

repo: Constructor-io/constructorio-ruby-gem


text:
slate-keymap: drive-by what-if analysis

I just found your repo and I like the concept of slate-keymap. I looked at the code and have two comments:

Would it not be better to map hotkeys to a canonical string, and use a map to match handlers? Now each keystroke performs a linear search.
How about string handlers that just call an editor command? See https://docs.slatejs.org/guides/plugins#register-commands-and-queries - E.g. "ctrl+i": 'insertImage'

Thanks for checking it out @wmertens!

Would it not be better to map hotkeys to a canonical string, and use a map to match handlers? Now each keystroke performs a linear search.

Thinking about this to make sure I follow: So a user pressing "ctrl" and "i" would map to the string "ctrl+i", and then we would check if that key is in a map? If so, for things like pressing "ctrl", "shift", and "i",  "ctrl+shift+i" and "shift+ctrl+i" would both be valid.  So we would have to do some normalization there. I'd have to see what that ends up looking like in code to understand more. Let me know if you meant something different.

How about string handlers that just call an editor command? See https://docs.slatejs.org/guides/plugins#register-commands-and-queries - E.g. "ctrl+i": 'insertImage'

I like this. I started with the function because it was more flexible, but I think we can and should support both. So these would both be valid:
{
  "ctrl+i": "insertImage",
  "mod+a": (event, editor) => editor.selectAll()
}

Is that what you had in mind?

Correct on both :)
I think is-hotkey has some normalization built in too

Great! Well I'm 100% sold on adding the string command support, as that will cleanup some code in the upcoming slate-lists. Let me know if you want to add it, and if not, I'll go ahead and do it.
And good point about is-hotkey, I'll check out how it's done there.

No, you can do it, thank you :)
It looks like is-hotkey can parse keys and then it compares the resulting object. I think it will need to have a stringifyKey method added.

Created a PR https://github.com/ConvertKit/slate-plugins/pull/8 for the string command idea. Let me know what you think. I'm going to have my team take a look as well. Thanks for the suggestion!

Thanks again for taking a look @wmertens. I'm going to close out this issue. I'll probably wait on the optimization until I or someone else runs into issues with it.

authors: brendancarney wmertens

repo: ConvertKit/slate-plugins


text:
Can't mute MediaStream playback

When trying to playback a media stream while recording, it plays a horrible echoing sound. I want the player to muted while it's having live playback, but setting  muted={true} and volume={0} has no effect.

I think this actually may be a problem with the recording library we are using, I'll verify and close this issue if that is the case.

Looks like it was an issue with the camera library I was using.

repo: CookPete/react-player


text:
⚠ Samsung has degraded performance

In e5fee23, Samsung (https://samsung.com) experienced degraded performance:

HTTP code: 200
Response time: 2735 ms

Resolved: Samsung performance has improved in 36f2533.

repo: CoopPlayzz/Webstatus-electronicbrands


text:
⚠ Samsung has degraded performance

In 22dbba9, Samsung (https://samsung.com) experienced degraded performance:

HTTP code: 200
Response time: 1956 ms

Resolved: Samsung performance has improved in ce8c0e7.


text:
⚠ Minecraft has degraded performance

In 24e02b3, Minecraft (https://www.minecraft.net) experienced degraded performance:

HTTP code: 200
Response time: 1166 ms

Resolved: Minecraft performance has improved in 1d4797b.

repo: CoopPlayzz/Webstatus-games


text:
⚠ Fortnite has degraded performance

In 1413d17, Fortnite (https://fortnite.com) experienced degraded performance:

HTTP code: 200
Response time: 1622 ms

Resolved: Fortnite performance has improved in 06302c3.


text:
⚠ Fortnite has degraded performance

In 816fdd3, Fortnite (https://fortnite.com) experienced degraded performance:

HTTP code: 200
Response time: 1678 ms

Resolved: Fortnite performance has improved in c25b2ad.


text:
⚠ Fortnite has degraded performance

In f5a36e8, Fortnite (https://fortnite.com) experienced degraded performance:

HTTP code: 200
Response time: 1634 ms

Resolved: Fortnite performance has improved in b20fb96.


text:
⚠ Fortnite has degraded performance

In 3659823, Fortnite (https://fortnite.com) experienced degraded performance:

HTTP code: 200
Response time: 1506 ms

Resolved: Fortnite performance has improved in 3af0e1f.


text:
Rename Extern

We use the same type Extern in both cosmwasm_std and cosmwasm_vm for similar but different things. Using different names would be better. Furthermore, the usage in cosmwasm_std (foreign functions available to use) is the opposite of extern "C" where the name was based on.
I propose:

Renaming cosmwasm_std::Extern -> cosmwasm_std::Imports
Renaming cosmwasm_vm::Extern -> cosmwasm_vm::Exports (I am less sure on this rename)

Opinions on renaming at all? Or opinions on better name?

At some point in the not too far future, there will be API calls implemented in the VM directly and API calls that are implemented by calling into Cosmos SDK.
contract            VM                         go-cosmwasm               Cosmos SDK
    🗎    ----->  humanize_address   -------> humanize_address --------> humanize_address
    🗎    ----->     db_read         ------->      db_read     --------> db_read
    🗎    -----> secp265k1_ecrecover
    🗎    -----> bls12381_verifify

So an API as seen by the contract would contain many more functions than what we need to inject into the VM's Instance as deps: Extern<S, A, Q>. I propose calling everything right of the VM in that diagram the VM's "backend". That would include FfiError as well, since we already have FfiErrors don't come from the FFI (Rust/Go) but are simply Rust errors in go-cosmwasm backend.

Nice diagram and explanation.
Your naming proposal would be cosmwasm_vm::Extern -> cosmwasm_vm::Backend ?
And Backend would return Result<_, FfiError> while cosmwasm_std::Imports would return Result<_, StdError>?
Is that a correct interpretation?

Yupp, cosmwasm_vm::Backend and Result<_, BackendError>.
I don't have any strong views on the contract naming. I'd just try to use the same name for variable name and type (deps: Extern<…> is a bit strange). Maybe extern: Extern<…> is just fine. In case of unit testing, no imports are used at all.

extern is a reserved keyword in Rust, otherwise I would agree completely.
I called them dependencies a few places (as we are performing dependency injection), but I don't really like a struct with such a long name in all the function signatures.
deps: Deps<S, A, Q> ?

extern is a reserved keyword in Rust, otherwise I would agree completely.

Arg.

deps: Deps<S, A, Q> ?

Yeah, this works and is a small change.

To summarize:
cosmwasm_std::Extern => cosmwasm_std::Deps and all methods that return Result, return StdError
cosmwasm_vm::Extern => cosmwasm_std::Backend and all methods that return Result, return BackendError
(This also implies clarifying the return value of Querier.raw_query if not one of those, but that is another issue)

repo: CosmWasm/cosmwasm


text:
Benchmark with default features on CircleCI

Fixes the CI run which broke as a consequence of #2049

By the way, if you need your PR to run benchmarks (e.g. to compare on more or less the same system as main), you can just add the branch name here: https://github.com/CosmWasm/cosmwasm/blob/4f1cbdac03f92a796dec5e7d5683911e9566a834/.circleci/config.yml#L86-L87


text:
Minor cleanups found during wasm integration

Change some Env types from int64 -> uint64

Pulled this commit into #81

repo: CosmWasm/go-cosmwasm


text:
added a method that will try to create the static data folder in the …

…mc directory.
Changes proposed in this pull request:

Creates the static data folder in the Minecraft directory. Added because without it, its way to easy to forget that this feature exists.

Looks like a good change, no problems with the impl.

authors: Frontrider falkreon

repo: CottonMC/StaticData


text:
webpage crashing out

Subject: webpage crashing out
Description:
it gave me an unknown error.
Results:
I am trying to navigate in the page and its giving me a lots of errors. crashing out many times
Backend version: develop-3ccf2161
Frontend version: develop-3ccf2161
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/96.0.4664.110 Safari/537.36
Page: https://app.couchers.org/connections
User: felco (7975)

@aapeliv redeploy?

I redeployed ~19 h ago

authors: CouchersBot aapeliv lucaslcode

repo: Couchers-org/couchers


text:
can't see my references

Subject: can't see my references
Description:
whenever i click on the tab "references" i can't actually see anything there, though i already have 2.
Results:
Backend version: develop-f07e2814
Frontend version:
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/109.0.0.0 Safari/537.36
Page: https://couchers.org/messages/surfing
User: alexander_g (25824)

i can see them now

authors: CouchersBot aapeliv


text:
Fix gitlab failing if protos doesn't need to run

Right now GitLab will fail if we didn't update anything that makes the protos job run, for example adding meeting notes or adjusting settings.json.
This is because the preview:protos job needs the protos job. To make the preview:protos job conditional on whether the protos job ran, we should use a when condition in the GitLab CI/CD configuration. This setting can prevent the preview:protos job from failing if the protos job did not produce new artifacts, such as when the only changes are in files like .eslint or settings.json.

Hey, sorry: I fixed this yesterday in https://github.com/Couchers-org/couchers/pull/5039 but didn't mention on slack! Sorry for the wasted effort!

Fixed in #5039

authors: aapeliv nabramow


text:
"Login" and "Sign Up" Buttons Design Improvement and Addition of Hover Effect

Is your feature request related to a problem? Please describe.
No. It's an enhancement in the existing design of buttons.
Describe the solution you'd like
Styling changes in the buttons design and addition of hover effect.
Describe alternatives you've considered
Addition of hover effecct.
Additional context
Current Design

This screenshot shows the design of buttons with no hover effect.
Expected Updated Design

In this screenshot, "Login" buttons shows the design and "Sign Up" buttons shows the button when it is hovered.

I can work on this issue @iamRabia-N @thestarsahil  Please assign me this issue

authors: Himral iamRabia-N

repo: Counselllor/Counsellor-Web


text:
GetBalancesByAddresses

We need a way to get balances across a set of accounts in a single request.
One possible API but open to all of your suggestions here :)
{ result: balances: [ {  asset: "XCP", total: 10, { [address_1]: 5, [address_2]: 4 } }]
I'm not sure if we need pagination here, practically.  Although technically, it's probably the right thing to do.

done here https://github.com/CounterpartyXCP/counterparty-core/pull/2041

authors: mattmarcello ouziel-slama

repo: CounterpartyXCP/counterparty-core


text:
Remove incorrect executable bits

A few .rs files and a .wasm file have the executable bit set; unset it.

Thanks for fixing this!

authors: joshtriplett sunfishcode

repo: CraneStation/wasmtime


text:
CASMINST-5485/CASMINST-5487: Clarify NCN personalization & image customization

Description
Clarify that during upgrades, NCN image customizations is worker only, but personalization is for all management NCNs.
Checklist Before Merging

[X] If I added any command snippets, the steps they belong to follow the prompt conventions (see example).
[X] If I added a new directory, I also updated .github/CODEOWNERS with the corresponding team in Cray-HPE.
[X] My commits or Pull-Request Title contain my JIRA information, or I do not have a JIRA.

/backport main

repo: Cray-HPE/docs-csm


text:
CASMHMS-6156: Add POST option to get power states to avoid size limitations with GET parameters

Summary and Scope
See source PR for full explanation of the PCS changes associated with this, and the testing that was done:
https://github.com/Cray-HPE/hms-power-control/pull/41
Adopted app version 2.3.0 for CSM 1.5 (helm chart 2.0.8)
Adopted app version 2.3.0 for CSM 1.6 (helm chart 2.1.5)
Issues and Related PRs

Resolves CASMHMS-6156
Required for CASMCMS-8952

Testing
See source PR for full explanation of the PCS changes associated with this, and the testing that was done:
https://github.com/Cray-HPE/hms-power-control/pull/41
For this PR specifically, I also made sure I could upgrade and deploy the new charts on mug.
Pull Request Checklist

[x] Version number(s) incremented, if applicable
[x] Copyrights updated
[x] License file intact
[x] Target branch correct
[x] CHANGELOG.md updated
[x] Testing is appropriate and complete, if applicable

The Snyk failures all appear to be pre-existing in this branch and unrelated to this PR

repo: Cray-HPE/hms-power-control-charts


text:
Move -Werror and -Wall to test build

This PR moves the -Werror and -Wall compile flags only to the test build.  The optional flags can be added via the WERROR CMake variable.  This variable is set initially in the library Makefile and passed through build_lib.sh.   It was verified that the flags work correctly by injecting an unused variable into the SmartRedis code and observing that the library builds but the test suite does not.

Codecov Report

Merging #183 (d94f190) into develop (b3d0bd0) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop     #183   +/-   ##
========================================
  Coverage    80.91%   80.91%
========================================
  Files           50       50
  Lines         2672     2672
========================================
  Hits          2162     2162
  Misses         510      510

This looks good so far. Do we need to add WERROR to CI to complete this PR?

Good question -- I think since run_tests.yml executes make test-verbose, the test suite built and run with the CI should have WERROR defined.

Great PR, thanks for taking care of this!

repo: CrayLabs/SmartRedis