text:
"Use Beta App"

There should be a drop down menu allowing a user to use the Electron app in a beta mode. This will allow us to release beta versions of the app to a fraction of the user base (those with beta app mode enabled) in order to have them act as a test population for app changes and updates. Partial rollout is the most ideal way to test new features and changes.

@SimplyAhmazing electron-builder has added the exact feature we were talking about :)

authors: SimplyAhmazing akashnimare

repo: zulip/zulip-electron


text:
Setup for spectron on Travis CI Linux runs

Invoke test runs via Travis CI using a separate shell script that ensures the a suitable frame buffer is available on Linux to run chromedriver against
Example Run: https://travis-ci.org/steele/zulip-electron/builds/159046422
Tested Zulip-Desktop 0.3.1 (based upon 2d43ce0) on Windows 7 Enteprise SP1

@steele you are awesome 🎅 .

source: gharchive/pull-request

authors: akashnimare steele

license_type: permissive

license_source: bigquery


text:
Message contents is overlapping on scroll.

yeah I am also getting this error on current master
with this warning
Error: Bad value for 'anchor': undefined

Get the latest master for the bug @Sam1301 is referring to.

The other bug, I guess i am calculating incorrectly the MessageHeader index. Will try to fix.

this is fixed for me on latest master

fixed for me too. 👍

source: gharchive/issue

repo: zulip/zulip-mobile

license_source: github-api


text:
user profile: Choice fields show index of field instead of actual value.

Tagging this as a priority, since it's a correctness issue.

@zulipbot claim
fixing soon

authors: YJDave synicalsyntax timabbott

repo: zulip/zulip


text:
Separate command and text field for slack-compatible outgoing webhook

Discussed here: https://chat.zulip.org/#narrow/stream/127-integrations/topic/gitlab.20slash.20commands/near/1247658
Current behavior puts entire message, including bot mention, in the text field of the outgoing POST.
POST coming from Slack itself puts the "slash command" in a separate command field while their text field only contains the message body after the command.
For better compatibility, if message starts with a bot mention then we should separate that out into a command field and put the rest of the message in the text field.
Perhaps we can also transform the mention (**@mybot**) to a slash command (/mybot) so it looks like it would coming from Slack.

@esamson can you provide an example Slack payload or a pointer to the right part of their documentation?
https://api.slack.com/legacy/custom-integrations/outgoing-webhooks#legacy-info__post-data does not suggest the presence of a command field, but that is a legacy API.

Yeah, I haven't been able to find docs but just observed this by testing against Slack itself.

@timabbott @eeshangarg can i work on this issue ??

@madrix01 There's a command on this page you can use to pick up the issue.

@eeshangarg Yes, that's what I did. I took the instruction from https://docs.gitlab.com/ee/user/project/integrations/slack_slash_commands.html and pointed to requestbin instead of gitlab.

@zulipbot claim
Would love to work on this as my first open source contribution!

@zulipbot claim

@zulipbot claim

@zulipbot claim

I have worked on this issue and I have made a PR. Review is pending

@zulipbot claim

@zulipbot claim

@zulipbot claim

@zulipbot claim

@zulipbot claim

@zulipbot claim

@zulipbot claim

@zulipbot claim

claim

@zulipbot claim

@esamson Hi, would you like to look at my open PR is review it?
Thanks.

authors: BrianMcDowell Kaustubhkongile LoganNiswander SamchenUF cynthialiuu esamson ikrambil jsmwoolf leighadennis madrix01 rohithvarma3000 salandei sudhanshu154 taeukkang09 timabbott


text:
Remove extraneous heading in Create stream UI

The stream creation UI has two redundant heading for the message retention policy. We should fix this.

Specifically, we should:

[ ] Drop the "Message retention for stream" heading
[ ] Replace the "i" after the "Message retention period" heading with a question mark pointing to /help/message-retention-policy, just as we currently have after the "Message retention for stream" heading.

@alya can i work on this one?

Sure, please follow the instructions in the contributor guide, and claim the issue once you know how you will approach solving it.

@zulipbot claim


text:
Zulip on Linux freezes when scrolling left<->right on code blocks ("```-formatted")

Describe the bug
Basically, when scrolling through a code block in horizontal axis, Zulip freezes and I cannot do anything else than quit & restart.
To Reproduce
Send a code snippet as wide as (just an approximate, I have not measured it) your screen width 3-4 times. Try scrolling left-right. It should almost immediately freeze.
Expected behavior
I can share formatted code with colleagues.
Screenshots
Irrevelant here
Desktop (please complete the following information):

OS: Pop!_OS 22.04 LTS
App: Zulip v5.10.0 (flatpak)

Additional context
None

Thanks for checking, @skelly37 ! I transferred the issue to the Zulip server/webapp repository.

I believe this is an issue with Chromium on Linux (and as such CEF/Electron) as I have experienced it on other sites outside of Zulip. Probably not a Zulip bug but might be able to be worked around.

@sevmonster - Have you tried with other browsers on Linux to see if it reproduces only in Chromium (and the desktop app) or if it also freezes on Firefox on Linux for example?

No, that was merely an idle observation on my part—but I can try that.

I started a conversation in the Zulip development community here to see about getting more folks to reproduce: https://chat.zulip.org/#narrow/stream/9-issues/topic/Zulip.20freezes.20scrolling.20left.2Fright.20on.20code.20blocks.2C.20.2325765/near/1595242.

@sevmonster

1. Is the browser you reproduced this on Chromium-based? Is it still happening? What about other browsers such as Firefox or Webkit-based browsers such as qutebrowser?

I was reproducing it on Chromium when I told you that it is broken there too. I have just run Zulip in Firefox and it seems to work just fine.

2. Can you try installing the Zulip app natively instead of using flatpak? Please [see the documentation here](https://zulip.com/help/desktop-app-install-guide).

I refrained from doing so, because flatpak flags worked for me. Let me know if testing the native installation could help you and I will be glad to help :)

3. Do you have hardware acceleration correctly configured and with a supported GPU? I have never used Pop!_OS but it may do this automatically for the user.

Actually, I do not know, though I do not seem to have problems with other apps (both flatpak and native installations). My GPU setup: NVIDIA GeForce RTX 3060 Ti 8GB + GPU integrated with AMD Ryzen 9 7900X

4. Are you using X11 or Wayland?

X11

5. Can you try disabling hardware acceleration to see if this is a GPU hardware/driver issue? I think this should work but please anyone correct me if it won't:
   `flatpak run org.zulip.Zulip --disable-gpu --disable-software-rasterizer`

It seems to work, I could not reproduce the issue with Zulip launched with this command
Seems like your guess was correct — the issue is withing GPU-accelerated Chromium

I do not know enough about Pop!_OS to tell you exactly how, but you might try using other drivers than whatever are on your system now, for example the open source nouveau drivers. Or, perhaps the currently installed drivers are outdated. In any case, if you want a workaround for now, disabling hardware acceleration seems to do the trick. Performance should be acceptable for you with that hardware.
You could still try installing natively, as flatpak often uses older libraries compared to the native system. Though since you also experience the problem in Chromium, I am not sure if it will make a lot of difference. If your Chromium install is also delivered via flatpak, I would very much recommend trying the native install of both. You can also try launching Chromium with those flags as well (--disable-gpu --disable-software-rasterizer) to see if it fixes it there. I imagine it will.
I would recommend raising this issue with Google/Nvidia. Unfortunately this doesn't seem like a Zulip bug. Though perhaps there could be a workaround if the core issue is discovered.
You could also specify to use your integrated GPU via Chromium flags if you still want hardware acceleration, though I do not recall how to do that off the top of my head—and your system may not have the drivers for it.

@skelly37 and @sevmonster thanks for digging into the root of this issue!
Since it doesn't seem to be a Zulip bug, I'm going to close out this issue for now. If there's more follow-up on the issue in Google/Chromium, feel free to post an update here or in the discussion for this issue in the Zulip development community.

authors: alya laurynmm sevmonster skelly37


text:
Renaming a stream does not preserve links

One of the amazing things about renaming a github repo, or moving a github repo to a different organization, is that old links (web links + git remotes) keep working after the transition.
It would be delightful if Zulip did something similar when streams were renamed. My expectation is that if you renamed a stream A to B, visiting /#narrow/stream/A would redirect to /#narrow/stream/B. If someone then re-created a new A, the redirect would no longer apply.
I don't have a good sense of how challenging this would be to implement :-)

What would happen when some other streams takes the old name of the other stream?

Wow, thanks for the quick feedback! I described this case in the issue:

If someone then re-created a new A, the redirect would no longer apply.

Does this make sense?

Ah, missed that part. Makes sense 👍

The default strategy I'd probably take with this is the same that we currently use for PM threads, basically putting the ID of the object into the URL:
https://chat.zulip.org/#narrow/pm-with/857-joshuapan8
So we'd be doing here e.g.
https://chat.zulip.org/#narrow/stream/123125-A
I don't think that change would be super difficult to implement.  Downsides include:
(1) If you're writing documentation or something, you can't just enter a permanent link by typing the URl structure from memory, you need to actually go grab it from the Zulip UI so you get the stream ID.
(2) the change would probably break all existing links, unless we're going to ban names starting with "[0-9]+-" from the space of valid stream names, so that one can parse both formats.  In which case, I suppose we could support the sloppy form of links as well; they just wouldn't have the benefits of surviving a stream rename.
Thoughts?  I think that this model is probably simpler than making a StreamAlias table that contains redirects from old stream names to new ones, at the cost of making the URLs somewhat less attractive.

Thanks @timabbott ! I should have read this earlier :-)

the change would probably break all existing links

Yeah, that's the part that breaks my use case (preserving historical links from the FHIR issue tracker, mailing list, etc). I wound up taking a naive stab at something more like the StreamAlias, mostly as an exercise in (re)familiarizing myself with the codebase.
There're are challenging bits that I haven't tried, like updating the client-side rename list when stream names change while the client is running  (thought it's vaguely possible this works correctly, given that the server-side tests pass). My sense is it's probably less work to throw this out and start something new (since 95% of my effort was understanding the codebase), but not sure whether I'll have the time for it.
I'll send along a PR for what's there.

OK, now that I have some tests in place and have figured out where to hook the logic into the frontend, I'm much happier with this. If it's getting close enough to be at all plausible for inclusion in 1.6 @timabbott that'd be awesome (but otherwise we can always deploy in FHIR's fork).

I think this is a bit ambitious to get into 1.6, which we're hoping to release pretty soon.
I definitely like some of the ideas here:

We should persist old names with something like StreamAlias, as shown in your PR.  We'll want to make absolutely sure there's a DB index on the name field.
On the client side we can have a simple mapping of old_stream_name -> stream_id, and we can try to find the most surgical places to swap in the "current" name for things like filtering.
We can fix the hashes to include stream id like we did with PMs--I think this will largely solve the problem of somebody posting a link on a blog or similar that gets out of date due to a rename.

We should probably discuss this on chat.

I like the last solution.

@jmandel well, this took longer than might have been ideal to happen, but I'm pretty happy with the solution in #8400.  Thanks again for bringing this issue to our attention! :)

authors: jmandel lonerz showell timabbott


text:
zerver/lib/cache.py: Move remote_cache_prefix to var directory.

This PR reference Issue #1132

Automated message from Dropbox CLA bot
@staranjeet, it looks like you've already signed the Dropbox CLA. Thanks!

You can probably do several these as different commits in one PR to help batch up the effort.

ok, will update on this PR when i complete all the subtasks.

@timabbott : any idea how can i debug this locally, (running the travis build locally using production environment).
I am trying to debug it by running python manage.py checkconfig but facing an error of Error: You must set ZULIP_ADMINISTRATOR in /etc/zulip/settings.py.

Yeah, so the problem is that we want to move the path for REMOTE_CACHE_PREFIX in development, but this is also moving it in production since your change is unconditional.  Probably the simplest fix is to add code to do mkdir -p var/ before trying to access that directory in cache.py.

@timabbott : i should use os.mkdir or run ? os.mkdir will throw an exception if the folder already exists, where as in run passing it wont(mkdir -p).

I'd prefer to do mkdir -p via subprocess, since it's more robust.

@timabbott : please review.

@timabbott : I guess you can review this now as most of the sub tasks are complete.

Great, merged the pieces so far!

authors: smarx staranjeet timabbott


text:
Remove the "pointer" from Zulip, part 1

This does substantial work towards removing the pointer as a concept in Zulip (#8994).  The goal is to get to a place where the server does not send a pointer parameter to clients and they don't send such a parameter to the server, either.
This isn't mergable yet, because:

The commit "pointer: Remove have_initial_messages code." breaks our node tests by making the message_fetch initialization code run the main code path.  @showell I'd love some help in figuring out how we want the ui_init.js tests to proceed here; one option would be to just skip message_fetch in that test; I'm not sure if that makes sense.
I'm not sure what to replace the last two remaining message_fetch references to page_params.pointer with; they appear only in this funny corner case where the home view has no messages in it after the initial fetch.
It needs some manual testing, and maybe some burn-in on chat.zulip.org.

But I'm otherwise pretty happy with this initial series of commits.  Next steps include:

Switching our analytics/ references to look at the "mark message as read" endpoints instead of the pointer endpoints.
Updating docs/subsystems/pointer.md to describe how unread messages work now, and maybe also rename it to unread.md.
Removing the webapp code to send pointer updates to the client (I have a draft commit that I left off this PR).  This will remove 2/3 of pointer.js; the rest (for marking messages as read on message selection) we'll end up moving somewhere more sensible, ideally deduplicating it with the similar code in narrows.
Deleting the fix_unreads management command and Inlining zerver/lib/fix_unreads.py into zerver/migrations/0104_fix_unreads.py so that the code properly lives within the single migration that needs it.
Removing the API endpoints for the pointer
Removing the pointer from events.
Removing the pointer field from the database.

@timabbott Can you update this commit message?
 pointer: Remove have_initial_messages code.

This was implemented in 2012 to avoid showing a loading indicator for
fetching messages for users with no message history.  However, the
Zulip onboarding UI always creates some message history, and fetching
history is fast, so this is likely clutter more than a useful
optimization.

This change results in the frontend tests for ui_init trying to do a
fetch, which is a unit testing mess.  Perhaps the direction I've been
attempting should be discarded and replaced with another approach?

The last paragraph doesn't really make much sense any more.  The commit now simply skips over the message_fetch step, which is fine.

I merged the first 3 commits after a bit more manual testing; so this is just that last commit (which needs work on the testing).  @amanagr can you prioritize this?  There's a bunch of follow-up work that I'd like to get into this release that blocks on it.

I am waiting on #15065 to proceed with tests, which I expect will be merged soon.

@15065 is getting to be a bit complicated; can you at least rebase this on master?

Rebased.

I guess I was a bit wrong, in that we merged #15065.

Fails node tests with this:
https://app.circleci.com/pipelines/github/timabbott/zulip/217/workflows/d19d04cf-cbe5-489b-aff8-4d192a45e732/jobs/1935

@amanagr I turned off CI on my CircleCI branch; hopefully that will make the PR run the build.
I think you should also just swap the order of the commits; the blueslip error commit should be able to be correct without the change to the pointer (and have a real commit message explaining how the case is impossible, etc.).

@timabbott updated this.

Great.  I'm test-deploying this on chat.zulip.org to get more intensive testing on it.

OK, I haven't seen instances of that blueslip.fatal error so far.  The main reason I hadn't merged a few hours ago was the vague concern we might be missing something in our assumptions and those code paths actually happen.  If they happen, they're rare enough that we can debug and fix forward.
Thanks @amanagr!  I'll open an issue for the next steps with removing the pointer more fully.

authors: amanagr showell timabbott


text:
Accessibility:Add-title to edit-topic,stream-sidebar action

This PR closes https://github.com/zulip/zulip/issues/17364
Testing plan:
Tested manually in local environment.
GIFs or screenshots:

This PR closes #17364

LGTM.

Can you rewrite the commit message to match our style?
Check out the Zulip commit message guidelines for more details: https://zulip.readthedocs.io/en/latest/contributing/version-control.html#commit-messages

Can you rewrite the commit message to match our style?
Check out the Zulip commit message guidelines for more details: https://zulip.readthedocs.io/en/latest/contributing/version-control.html#commit-messages

Thanks for the review. Done that.

Closing PR for the same changes are made via another commit. Thanks.

authors: Signior-X guptaprakhariitr timabbott


text:
message_scroll: Use fadeOut effect to hide the scroll to bottom button.

We use fadeOut effect to hide the scroll to bottom button more
widely. We already use fadeIn effect to display the button
every time.
We deliberately don't use the fadeOut effect when doing
make_compose_box_full_size to avoid any button overlap with
compose for a short time.
discussion - https://chat.zulip.org/#narrow/stream/101-design/topic/scroll.20to.20bottom.20.2319937

Playing around with this, I like the visual change of having a fadeout effect.
However, it seems to also change how much the button sticks around. I had thought that we changed it so that it stays unless some action (e.g. keyboard navigation) explicitly dismisses it? Anyway, that seems to be the behavior on CZO, and I've been happy with it. I think having the button disappear fairly quickly, as in this PR, is less usable.

I had thought that we changed it so that it stays unless some action (e.g. keyboard navigation) explicitly dismisses it?

Yes, that behavior is still the same. We are just changing the time it takes to hide.

It turns out that what Alya was seeing is an unrelated bug: When one scroll in an interleaved view and crosses onto another topic, we (I assume) rerender the close compose box widget, and that is somehow hiding this component as a side effect.

I guess that's not a bug: We have explicit code here to disappear it after 3 seconds if (1) you are not hovering the element and (2) it is an interleaved view. I don't know what the motivation for this logic is, but one possibility is that the scroll to bottom notice feels wrong in search views where one might arrive at the bottom.
    // Wait before hiding to allow user time to click on the button.
    hide_scroll_to_bottom_timer = setTimeout(() => {
        // Don't hide if user is hovered on it.
        if (
            !narrow_state.narrowed_by_topic_reply() &&
            !$show_scroll_to_bottom_button.get(0).matches(":hover")
        ) {
            $show_scroll_to_bottom_button.fadeOut(500);
        }
    }, 3000);

authors: alya amanagr timabbott


text:
settings: Improve delete user group confirmation modal.

Confirmation modal message is changed for user group delete to improve user experience.
Fixes: #22593

Screenshots and screen captures:
Screenshot of Result:

Self-review checklist

[x] Self-reviewed the changes for clarity and maintainability
(variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

[x] Explains differences from previous plans (e.g., issue description).
[x] Highlights technical choices and bugs encountered.
[x] Calls out remaining decisions and concerns.
[x] Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

[x] Each commit is a coherent idea.
[x] Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

[x] Visual appearance of the changes.
[x] Responsiveness and internationalization.
[x] Strings and tooltips.
[x] End-to-end functionality of buttons, interactions and flows.
[x] Corner cases, error conditions, and easily imagined bugs.

@Rixant Thanks for your work on this!
The code changes looks good to me, can you please squash both the commits in a single one, we make sure that each commit passes the CI individually and avoid the commits doing only linter error fixes.

@alya , you might want to take a look at this PR now.

Looks good to me!

@timabbott small change reviewed by @jai2201 and myself; ready for you to take a look.

authors: Rixant alya jai2201


text:
email_mirror: Create attachments as the message sender.

When the email mirror gateway is sending messages "as" a user (as triggered by having access to the missed-message email address), attachments were still created as the Email Gateway bot.  Since the sender (the end-user) was not the owner of those attachments (the gateway bot), nor were they referenced yet anywhere, this resulted in the attachments being "orphaned" and not allowed to be accessed by anyone -- despite the attachment links being embedded in the message. This was accompanied by the error:
WARN [] User 12345 tried to share upload 123/3LkSA4OcoG6OpAknS2I0SFAQ/example.jpf in message 123456, but lacks permission
INFO [zerver.lib.email_mirror] Successfully processed email from user 12345 to example-stream

We solve this by creating attachment objects as the users the message will be sent from.

There's a bit of a question of if we try to backfill this for the orphaned attachments in the history.  Doing this would require finding all of the orphaned attachments owned by the gateway bot (which is straightforward) and then, for each, trying to match them up with message contents which were sent to that realm, with a client_id of Internal, and not has_attachment, and has content containing that path-id.  That is doable, it's just not likely to be a well-indexed query at all so the migration will be slow -- for those that use the mail gateway, which is probably not that many deploys.

Screenshots and screen captures:

Self-review checklist

[ ] Self-reviewed the changes for clarity and maintainability
(variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

[ ] Explains differences from previous plans (e.g., issue description).
[ ] Highlights technical choices and bugs encountered.
[ ] Calls out remaining decisions and concerns.
[ ] Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

[ ] Each commit is a coherent idea.
[ ] Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

[ ] Visual appearance of the changes.
[ ] Responsiveness and internationalization.
[ ] Strings and tooltips.
[ ] End-to-end functionality of buttons, interactions and flows.
[ ] Corner cases, error conditions, and easily imagined bugs.

Tangentially related to #20932 and #21580.

lgtm, but I'd like @mateuszmandera to review carefully as well.

Does this mean including attachments in these missed message emails was completely broken all along or am I missing something?

AFAICT, yes.

Tangential question - do we set an explicit limit for the size of attachments we will accept via email? Just thinking whether we should be making sure to enforce it to be consistent with the standard upload size limit, e.g. to be able to safely make assumptions about the size of any file we have in uploads.

We don't set a file size limit for individual files, only a realm upload limit.  The individual file upload limit is very much a technical "it starts breaking somewhere around here" limit, and my sense is not meant to be an enforcement mechanism.

Don't we hard-limit the upload size at least via nginx? client_max_body_size 80m;

AFAICT, yes.

Hmm, that seems surprising -- it seems like someone would have reported it long ago. I guess uploads sent to public streams would normally get the is_realm_public flag sent, and end up working... but that code only run when the attachment gets associated with the message, and that's the thing that's not working here.
(We added support for uploaded files in these back in 2013)

Merged, thanks @alexmv!
I'd like us to confirm it in production before we backport it to 6.x.

#24128 is the follow-up migration to fix old attachments and messages.

Backported to 6.x as 8bc6ad7a469b8dde1f41cfd9010f639c7909d6ae.

authors: alexmv mateuszmandera timabbott


text:
UserTopic: Update UserTopic records regardless of the visibility_policy.

As discussed in #24236 (comment)
The frst commit updates the do_update_message codepath to update the UserTopic records regardless
of visibility policy during the "move topic" operation.
This is required before offering new visibility policies in the UI.
Currently, UserTopic records are moved or deleted only for objects with a MUTED visibility policy.
The second commit addresses the TODO comment to use bulk database operation instead of looping.
CZO discussion

Fixes: #24574

To Do:

[x] Include tests for -- users having UNMUTE visibility_policy during move-topic operation.
[x] Address the TODO comment for bulk update.
[x] Might have to rework on the current changes after addressing the TODO comment.

Self-review checklist

[x] Self-reviewed the changes for clarity and maintainability
(variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

[x] Explains differences from previous plans (e.g., issue description).
[x] Highlights technical choices and bugs encountered.
[x] Calls out remaining decisions and concerns.
[x] Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

[x] Each commit is a coherent idea.
[x] Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

[ ] Visual appearance of the changes.
[ ] Responsiveness and internationalization.
[ ] Strings and tooltips.
[x] End-to-end functionality of buttons, interactions and flows.
[x] Corner cases, error conditions, and easily imagined bugs.

@timabbott @abhijeetbodas2001
Please have a look at the PR and the review comments I have left for discussion.

I've only skimmed this, I thought I'd mention that ideally, we'll want to do this in a way where we can avoid duplicating complex code -- so we should be thinking about whether this can be done by refactoring the existing do_set_user_visibility_policy function to be a bulk operation (which happens to work great if you pass a single user), rather than making a separate parallel implementation that's the bulk operation; it's really hard to maintain two copies of a function over time, often the end result if one just has the API endpoint call the bulk operation with a single user works nice.
For some inspiration, see the bulk_add_subscriptions code path -- it's a single implementation that handles all of our use cases, including API endpoints capable of adding a single user with N streams or a single stream with M users efficiently.

Not specific to this PR, but is there a specific reason to use the delete-and-update pattern in the message edit code (where in, old topic UserTopic rows are first deleted, and new topic UserTopic rows are then created)? Can we not just update the stream/topic field in a single query for these topics?

So, previously we had delete-and-update pattern because add_topic_mute and remove_topic_mute used to perform create and delete operations respectively. We didn't have any update query (makes sense at that time).
Now we can do that. So, I will do the changes in a prep commit. Also, we would no longer need skip_muted_topics_event  after this.

Not specific to this PR, but is there a specific reason to use the delete-and-update pattern in the message edit code (where in, old topic UserTopic rows are first deleted, and new topic UserTopic rows are then created)? Can we not just update the stream/topic field in a single query for these topics?

Earlier we had only add_topic_mute and remove_topic_mute, we didn't have function with update query. Hence delete-and-update pattern.
Now, it is possible to do this, but using set_user_topic_visibility_policy_in_database for this task, doesn't sound good. This function is meant to set visibility_polcy. Updating stream & topic_name shouldn't happen in it.
We can have a separate function (I discussed one approach in CZO), but as Tim Abbott mentioned, we should avoid maintaining two functions.

So I have refactored our existing function for bulk_ operation

I think,
In test_edit_muted_topic, this is a stale code:

Code
        # Returns the users that need to be notified when a message topic is changed
        def notify(user_id: int) -> Dict[str, Any]:
            um = UserMessage.objects.get(message=message_id)
            if um.user_profile_id == user_id:
                return {
                    "id": user_id,
                    "flags": um.flags_list(),
                }

            else:
                return {
                    "id": user_id,
                    "flags": ["read"],
                }

        users_to_be_notified = list(map(notify, [hamlet.id, cordelia.id, aaron.id]))

        check_update_message(....)

        for muting_user in get_users_muting_topic(stream.id, change_all_topic_name):
            for user in users_to_be_notified:
                if muting_user.id == user["id"]:
                    user["muted_topics"] = get_topic_mutes(muting_user)
                    break

  It doesn't verifies anything.
I have added the code to verify if send_event() works as expected or not in test_edit_umuted_topic.
Please let me know, if that sounds good. I will fix test_edit_muted_topic in a separate commit on similar pattern.
Code for quick reference:

Code
        # users that need to be notified in the case of change-topic-name operation.
      users_to_be_notified: List[int] = []
      for user_topic in get_users_with_user_topic_visibility_policy(stream.id, "Topic1"):
          # We are appending the same data twice because of delete-and-update pattern.
          # TODO: I think, this is a bug which I will discuss in a PR comment in detail.
          users_to_be_notified.append(user_topic.user_profile_id)
          users_to_be_notified.append(user_topic.user_profile_id)

      check_update_message(....)

      # Extract the send_event call where event type is 'user_topic'.
      # Here we assert that the expected users are notified properly.
      called = False
      users_notified: List[int] = []
      for call_args in mock_send_event.call_args_list:
          (arg_realm, arg_event, arg_notified_users) = call_args[0]
          if arg_event["type"] == "user_topic":
              self.assertEqual(arg_event["type"], "user_topic")
              users_notified.append(*arg_notified_users)
              called = True
      self.assertTrue(called)
      self.assertEqual(sorted(users_notified), sorted(users_to_be_notified))

Another issue I would like to discuss:
Currently, in do_set_user_topic_visibility_policy we have:

code
    if not skip_muted_topics_event:
        muted_topics_event = dict(type="muted_topics", muted_topics=get_topic_mutes(user_profile))
        send_event(user_profile.realm, muted_topics_event, [user_profile.id])

    user_topic_event: Dict[str, Any] = {
        "type": "user_topic",
        "stream_id": stream.id,
        "topic_name": topic,
        "last_updated": datetime_to_timestamp(last_updated),
        "visibility_policy": visibility_policy,
    }

    send_event(user_profile.realm, user_topic_event, [user_profile.id])

This needs the following update:
`skip_muted_topics_event` renamed to `skip_events`
and the code:

code
    if not skip_events:
        muted_topics_event = dict(type="muted_topics", muted_topics=get_topic_mutes(user_profile))
        send_event(user_profile.realm, muted_topics_event, [user_profile.id])

        user_topic_event: Dict[str, Any] = {
            "type": "user_topic",
            "stream_id": stream.id,
            "topic_name": topic,
            "last_updated": datetime_to_timestamp(last_updated),
            "visibility_policy": visibility_policy,
        }

        send_event(user_profile.realm, user_topic_event, [user_profile.id])

Reason:
In our move-topic codepath,
during delete operation we shouldn't send either of muted_topics or user_topics event.
during create operation both should be sent.
Currently, user_topics event gets send twice. (during delete & create)
Thoughts ?

@abhijeetbodas2001 this is ready to review.
I have replied to the respective review comments.
These are two questions which need attention:

Question 1
Question 2

The bulk approach is looking pretty good! I posted a few comments on details, but I think we're getting close to having something we can integrate here. (I think that events testing approach seems fine).

@timabbott This is ready to review.
I have replied to the respective review comments.
One more question which needs discussion (not a blocker to this PR):

There should be a check that allows to set visibility_policy of user_topic as UNMUTED only if the stream is MUTED?

There should be a check that allows to set visibility_policy of user_topic as UNMUTED only if the stream is MUTED?

I think we can enforce this when UNMUTING a topic just to avoid user confusion which can come from seeing a UNMUTE button on a topic in a not-muted stream.
But as long as we handle UNMUTED topics in not-muted streams correctly (which we do), I think it's fine to not always maintain this truth -- for example, I think it would be OK to avoid doing things like cleaning up UNMUTED topics whenever a stream is unmuted. Doing so would also break workflows for people who frequently mute/unmute streams (I'm not sure if there is a genuine use case for doing so though).

But as long as we handle UNMUTED topics in not-muted streams correctly (which we do), I think it's fine to not always maintain this truth -- for example, I think it would be OK to avoid doing things like cleaning up UNMUTED topics whenever a stream is unmuted. Doing so would also break workflows for people who frequently mute/unmute streams (I'm not sure if there is a genuine use case for doing so though).

Yeah, agreed, if we just define "UNMUTED" as "not muted even if the stream if muted", we don't need to do something special, and we are usefully storing state for the case where the user toggles the stream's muted state from time to time. (Which I do see use cases for).


text:
api docs: Use enum for reaction_type.

It's not currently rendered in the docs, but good to have this in place anyway:
https://github.com/zulip/zulip/pull/21005#discussion_r797823366

(This is a cherry-pick of a commit from #21005, which I plan to close as superseded by #21704 and #21771 and this.)

The CI failure is something in ./tools/check-schemas -- which I think tries to compare schemas in web/tests/lib/events.js used for frontend tests with those in the OpenAPI docs. My guess is the bug is in check-schemas itself not supporting enums properly but haven't really looked; @laurynmm do you understand that tool?
tools/check-schemas has a decent docsting at the top at least.

Yeah, this came up recently in another API documentation update I was doing (though it was the reverse where we had incorrectly documented something as an enum that wasn't). I made the updates to the event schema and pushed those updates here, so CI should pass that check now.

Merged, thanks @chrisbobbe and @laurynmm!

authors: chrisbobbe laurynmm timabbott


text:
mention_pills: Allow pills to scale with other message text.

This removes duplicate font-size and line-height declarations that matched the legacy values.
Fixes part of #30476
Screenshots and screen captures:

Before
After (no change at legacy sizes)

Self-review checklist

[x] Self-reviewed the changes for clarity and maintainability
(variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

[x] Explains differences from previous plans (e.g., issue description).
[x] Highlights technical choices and bugs encountered.
[x] Calls out remaining decisions and concerns.
[x] Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

[x] Each commit is a coherent idea.
[x] Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

[x] Visual appearance of the changes.
[x] Responsiveness and internationalization.
[x] Strings and tooltips.
[x] End-to-end functionality of buttons, interactions and flows.
[x] Corner cases, error conditions, and easily imagined bugs.

Merged, thanks @karlstolley! We should probably do a pass of git grep font-size and audit any other 14px values too.

authors: karlstolley timabbott


text:
settings: Clean schemas and types used for group settings.

Removed "type"/"Type" from schema and type names used for group settings because we want to use "type"/"Type" only for "type of a type" cases.
So, this commit renames-

anonymous_group_type => anonymous_group_schema
group_setting_type_schema => group_setting_value_schema
GroupSettingType => GroupSettingValue

We also had duplicate definitions for GroupSettingType, in state_data.ts and in settings_components.ts. So, removed it from settings_components.ts.

https://github.com/zulip/zulip/pull/31623#discussion_r1795968511

Self-review checklist

[ ] Self-reviewed the changes for clarity and maintainability
(variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

[ ] Explains differences from previous plans (e.g., issue description).
[ ] Highlights technical choices and bugs encountered.
[ ] Calls out remaining decisions and concerns.
[ ] Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

[ ] Each commit is a coherent idea.
[ ] Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

[ ] Visual appearance of the changes.
[ ] Responsiveness and internationalization.
[ ] Strings and tooltips.
[ ] End-to-end functionality of buttons, interactions and flows.
[ ] Corner cases, error conditions, and easily imagined bugs.

Merged, thanks @sahil839!


text:
Change the "top of messages" logo to SVG from PNG.

This changes the logo that sits at the top of the messages to an SVG
rather than a PNG used as the current navbar logo that is filtered to
be grayscale.
Thanks to @rishig for generating the SVG!

Automated message from Dropbox CLA bot
@brockwhittaker, it looks like you've already signed the Dropbox CLA. Thanks!

I confirmed that this fixed the performance regression we'd seen and merged this, thanks @brockwhittaker!
I think we should probably still do some polish work on this new feature, though for the Zulip 1.5 release -- at least making a mouseover tooltip explaining that this token means the top of the feed.

authors: brockwhittaker smarx timabbott


text:
sign-in: Show proper error for deactivated user.

Show a clear error message when a user tries to sign in with
a deactivated account.
Fixes #4757

Codecov Report

Merging #5463 into master will decrease coverage by 0.03%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #5463      +/-   ##
==========================================
- Coverage   86.55%   86.51%   -0.04%
==========================================
  Files         430      430
  Lines       53043    53046       +3
  Branches     2066     2066
==========================================
- Hits        45912    45894      -18
- Misses       7131     7152      +21

Impacted Files
Coverage Δ

zerver/tests/test_decorators.py
99.53% <100%> (ø)
:arrow_up:

zerver/forms.py
96.15% <100%> (+0.07%)
:arrow_up:

zerver/tornado/ioloop_logging.py
46.66% <0%> (-46.67%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23dc32a...06cf859. Read the comment docs.

Merged!  Thanks @umairwaheed!

I think this will break login for MIT Zephyr users who have a mirror dummy.  This check should probably add and not user_profile.is_mirror_dummy.  Search for is_mirror_dummy is zerver/views/registration.py to see the code path.
@umairwaheed can you take care of fixing that issue and adding a test?

authors: codecov-io showell timabbott umairwaheed


text:
looking forward to your model

I have starred your repo..

I have already published the head models.
2019-01-31 update
https://github.com/zuoqing1988/ZQCNN

license: MIT


text:
Simple menu with align right still has left margin

When using align-right I expected the margin to also switch from left to right, so that last child aligns with the outer edge.
// Align right and simple
&.simple.align-#{$global-right} {
      > li {
        margin-#{$global-right}: 0;
        margin-#{$global-left}: get-side($menu-item-padding, $global-left);
      }
}

Perhaps?

I agree this is an issue.
To resolve it, @mixin menu-simple should take a $direction parameter and use a @mixin menu-simple-margin sub-modifier, to be able to generate a margin at the left or right.
Then, there is two solutions to provide a modifier like this in CSS:

The simpler but not proper solution: .simple.align-{left|right} selector (with a specificity of 0.3.1):

...

The proper but not simpler solution: .simple-{left|right} selector (with a specificity of 0.2.1)

...

At this point, everyone will think I'm for the second solution. But... the whole menu should be refactored anyway (the specificity goal is 0.1.0, we are far away from that). So let's go for the simpler solution.

authors: forkiven ncoden

repo: zurb/foundation-sites

license: mit


text:
Fix stylesheet portion of bower.json to comply w/ new main spec

Per https://github.com/bower/bower.json-spec/pull/43 / https://github.com/bower/bower.json-spec/commit/0b34d2bb0bdd4fa31fa9728f787f49e170e41f99, which has finally brought clarity regarding main. In particular:

Use source files with module exports and imports over pre-built distribution files.

Also, in the spec's example, the CSS files aren't included in main, but the main SCSS file is.
X-Ref: https://github.com/zurb/foundation-apps/pull/607

@gakimball Ping.

repo: zurb/foundation


text:
RefreshAllNodes function

Currently, you can refresh just the values of one node but there is no way to refresh all nodes. Because of recent changes to the startup procedure nodes don't seem to check the values on startup anymore (at least I think we used to do this). The result is that if the system crashes or goes down without saving the cached state, devices go out of sync with their actual state in the UI. I've observed this with mqtt discovery but it should apply with HA discovery too I believe. There is no great way to fix this other than to force it to reinterview everything by savings the settings page. I'm unsure if you can even fix this in HA if you aren't running zwavejs2mqtt.
We should have a function to just refresh all values on all devices when necessary without reinterviewing, even though this function would generate a good deal of traffic. It's less traffic than reinterviewing everything. This would then need to be implemented in the UIs or services.
/cc
@robertsLando
@raman325

Maybe I am misunderstanding, but shouldn't we fix the root issue that requires a refresh of all nodes and all values instead of creating this workaround?

Perhaps but I'm not sure that we can detect that the power cord was yanked out and that the states don't match. I'm also not sure it's a work around to be able to resync the whole network. I believe ozw had a similar function.

We have this for single nodes: https://zwave-js.github.io/node-zwave-js/#/api/node?id=refreshvalues
I wonder if it's worth adding another method that just loops through all nodes and calls this or if that is something applications can implement themselves.

Humm we could do that just for config CC maybe?

That's https://zwave-js.github.io/node-zwave-js/#/api/node?id=refreshccvalues

I swear I looked

Not in the UI yet but there is already the mqtt support for it

I don't think there's a necessity to do this in the driver

This may actually go hand-in-hand with the discussion on discord yesterday. The HA addons users don't have a way to invalidate the cache and a reinterview of all so if we added that I think it would supplant the need for this.

Cache issues should be owned by the driver. If the cache needs to be invalidated, the driver should have the capability to do it, whether it's automatically or through a method. I'm not arguing that the capability is needed, but I don't think it makes sense for the HA addon or the HA integration to provide this capability directly

repo: zwave-js/node-zwave-js


text:
feat: add param 92 to aerq v2.01

Adding param 92 per Aeotec support:
In V2.01 of the new aerQ Sensor, there is a new battery calibration check parameter setting. There are only 3 different setting inputs:

Parameter 92 [4 byte] = 0x05010000 (83951616)

Example checked value returned (0x0B5B0B54 = 190516052 )

Parameter 92 [4 byte] = 0x05020000 (84017152)

Example checked value returned (0x0AF70AEC = 183962348 )

Parameter 92 [4 byte] = 0x05030000 (84082688)

Example checked value returned (0x0A2F0A28 = 170854952 )

Ah shit, that min/max thing doesn't work with allowManualEntry: false.


text:
第三章测试时报错

纸质的第一版第三章测试时报错，省略的attr_local_variable_table.go文件和cp_invoke_dynamic.go文件，应在相关小节提醒一下读者。cp_utf8.go文件中如果用简化版的decodeMUTF8函数，会报导入的包未用到，这个是小问题。

非常好的反馈，如果本书有机会出版第二版，我会考虑改进 ：）


text:
chore(deps): upgrade dependencies

Upgrades project dependencies. See details in workflow run.

Automatically created by projen via the "upgrade-main" workflow

Codecov Report

Merging #432 (74a1498) into main (1c9c132) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #432   +/-   ##
=======================================
  Coverage   95.69%   95.69%
=======================================
  Files           1        1
  Lines         395      395
  Branches       53       53
=======================================
  Hits          378      378
  Misses         17       17

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

authors: codecov-commenter zxkane

repo: zxkane/snat


text:
インデックスサイズ再計算ヘルパー案

インデックスサイズの1と2の境界はsigned_byte最大値を基に計算されてるようです
ヘッダーのインデックスサイズ再計算用ヘルパー案です
pmx.Header.VertexIndexSize = calcIndexSize(pmx.VertexArray.Length);
            byte calcIndexSize(int count){
                if(count <= sbyte.MaxValue)
                    return (byte)1;
                else if(count <= short.MaxValue)
                    return (byte)2;
                else
                    return (byte)4;
            };

ありがとうございます。使わせていただきます。

authors: flammpfeil zyando

repo: zyando/MMDataIO


text:
RFC: a new API that plans algorithm with prior information before binarize

In #30 we changed the usage of AdaptiveThreshold from
w = recommend_window_size(img)
f = AdaptiveThreshold(window_size = w, percentage = 15)
binarize(img, f)

to
f = AdaptiveThreshold(percentage = 15)
binarize(img, f)

By doing this, users no longer need to call recommend_window_size anymore, which is an improvement.
However, this isn't what we really want in the beginning, since we'd like to hold all parameters of AdaptiveThreshold inside of it.

a window_size is something that is intrinsic to an adaptive method since the existence of a window is what often differentiates global thresholding from adaptive local thresholding. A sensible choice of window_size does indeed depend on the size of the image.
-- @zygmuntszpak

As a solution, I’m keeping thinking of introducing another set of API that generate the algorithms with the “best” inferred parameters from prior information, for example, the usage could be:
# option 1
f = AdaptiveThreshold(img)
# option 2
f = algorithm_plan(:AdaptiveThreshold, img)

binarize(img, f)

The idea here is, use img to infer as much information as needed, and leave the others using the default value.
A toy implementation of option 1 could be:
AdaptiveThreshold(img::AbstractArray; kwargs...) =
    AdaptiveThreshold(;window_size=default_AdaptiveThreshold_window_size(img), kwargs...)

P.S., a practical example of this design is used in my NonlocalMean, where we infer the best r_p (aka. window_size) using img.

closed by #45


text:
🛑 Maple - Request Service is down

In a9430e0, Maple - Request Service (https://request.zyradyl.moe) was down:

HTTP code: 530
Response time: 575 ms

Resolved: Maple - Request Service is back up in 3f3d1a0 after 23 hours, 2 minutes.


text:
最低で最高のPARADISO

最低で最高のPARADISO

歌曲信息

专辑：ラブライブ！The School Idol Movie ユニットシングル付き第3弾
作词：畑 亜貴
作曲：木村有希
编曲：木村有希
歌手：BiBi

谱
2221 11(7)1(7) 1(7)122
2221 11(7)1(7) 1(7)122
2221 11(7)1(7) 1(7)122
22652 22652122
2221 11(7)1(7) 1(7)122
2221 11(7)1(7) 1(7)122
2221 11(7)1(7) 1(7)122
22652 22652122
2345 6655 5544
4435432#123456
6655 5544
4434 443453
---------------
666#6[1]#665 54565
5556#665343454
2456 2456 56[1]#664566
666#6[1]#665545[1][1]
[1][1][1][2][1]#665 54544
256262 6262 6262 2243
22 22 12
[1]75 55256 [1]75 55256
---------------
2221 11(7)1(7) 1(7)122
1252 1262 126545 4212
2221 11(7)1(7) 1(7)142
12 56 56 52122
2345 6655 5544
4435432#123456
6655 5544
4434 443456
----------------
666#6[1]#665 54565
5556#665343454
2456 2456 56[1]#664566
666#6[1]#665545[1][1]
[1][1][1][2][1]#665 54544
256262 6262 6262 2243
22 22 12
----------------
666#6[1]#665 54565
5556#665343454
2456 2456 56[1]#664566
666#6[1]#665 54565
5556#6[1]65 54544
2456 2456 56[1]#664566
666#6[1]#665545[1][1]
[1][1][1][2][1]#665 54544
256262 6262 6262 2243
22 22 12

记谱： 气球气球往往

BiBi, LoveLive!(ラブライブ!)


text:
api-reference url change

@govindmaheshwari2 Remove the existing folder of api-reference for flutter


text:
Update README.md

Pull Request Test Coverage Report for Build 8102676562
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build 8102669649:
0.0%

Covered Lines:
220

Relevant Lines:
220

💛  - Coveralls

authors: coveralls reidja


text:
classification spelling was wrong

this was due to copy right concerns


text:
Fix insurance price cant be deciaml number

Codecov Report

Merging #200 (9829707) into master (13e9460) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #200   +/-   ##
=========================================
  Coverage     55.45%   55.45%
  Complexity      785      785
=========================================
  Files           166      166
  Lines          3280     3280
  Branches        381      381
=========================================
  Hits           1819     1819
  Misses         1359     1359
  Partials        102      102

Impacted Files
Coverage Δ

...main/java/seedu/address/model/insurance/Price.java
80.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13e9460...9829707. Read the comment docs.

authors: codecov-commenter zzkzzzz


text:
Bug fixes for PreviousCommand

Codecov Report

Merging #205 (267a0bd) into master (047abcc) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master     #205      +/-   ##
============================================
+ Coverage     75.22%   75.24%   +0.02%
- Complexity      862      863       +1
============================================
  Files           110      110
  Lines          2446     2448       +2
  Branches        311      311
============================================
+ Hits           1840     1842       +2
  Misses          514      514
  Partials         92       92

Impacted Files
Coverage Δ

...java/seedu/address/logic/parser/LibTaskParser.java
80.00% <ø> (ø)

.../seedu/address/logic/commands/PreviousCommand.java
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 047abcc...267a0bd. Read the comment docs.

authors: Halpfrog codecov-commenter


text:
Write tests

Codecov Report

Merging #237 (52358e5) into master (9b9948f) will increase coverage by 1.91%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##             master     #237      +/-   ##
============================================
+ Coverage     48.60%   50.52%   +1.91%
- Complexity      643      655      +12
============================================
  Files           137      137
  Lines          2874     2874
  Branches        370      370
============================================
+ Hits           1397     1452      +55
+ Misses         1374     1318      -56
- Partials        103      104       +1

Impacted Files
Coverage Δ

...main/java/seedu/address/commons/core/Messages.java
0.00% <ø> (ø)

.../address/logic/parser/tag/AddTagCommandParser.java
0.00% <0.00%> (ø)

src/main/java/seedu/address/model/tag/Tag.java
88.88% <ø> (ø)

src/main/java/seedu/address/model/task/Id.java
42.85% <0.00%> (+4.76%)
:arrow_up:

...c/main/java/seedu/address/model/task/Deadline.java
87.50% <0.00%> (+31.25%)
:arrow_up:

...in/java/seedu/address/storage/JsonAdaptedTask.java
98.00% <0.00%> (+98.00%)
:arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

authors: codecov-commenter ryanguai


text:
Test: Add tests for autocomplete enhancements

Added


text:
Update Developer Guide to include filter

Codecov Report

Merging #39 (bdce988) into master (5dd8e5f) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #39   +/-   ##
=========================================
  Coverage     72.15%   72.15%
  Complexity      399      399
=========================================
  Files            70       70
  Lines          1232     1232
  Branches        125      125
=========================================
  Hits            889      889
  Misses          311      311
  Partials         32       32

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

authors: ShummyOwnzYou codecov-commenter


text:
Update index.md and gradle.yml

closes #37


text:
Renewing the link to the official discord of The Rust Programming Language

In the first commit I didn't remove the Track-Rust Practise Questions link and it was with the wrong commit message, sorry about that, and thank you very much for this path btw

no problem, thanks for your contribution

authors: AbdesamedBendjeddou odmrs

repo: AbdesamedBendjeddou/Rusty-CS


text:
fix and enable eth provider tests

@xlc it's odd that chopsticks@0.6.0 broke the CI, and I had to revert to 0.5.0 for it to work.
It might not be a bug but some weird compatibility issue among { bun, chopsticks, github-ci }, so just take a note here in case something similar happen

maybe it is related to https://github.com/AcalaNetwork/chopsticks/pull/826

authors: shunjizhan xlc


text:
Update XMU_Auto_Check_In.yml

请在自己的fork中修改这些内容

authors: AiRanthem Lumberlift

repo: AiRanthem/xmu-daily-report


text:
Feature/remove/change/search

Resolved conflict by Alex


text:
feat: allow horizontal scroll

LGTM, Can you update the man and github wiki? :)

authors: Alexays rroohhh

repo: Alexays/Waybar


text:
Release 0.1.0

We should make sure everything is fine and tag this when merged. @5-pebbles

You mean when we merge into dev?
Also, I will start working on the tests, but I have family over, so it will be another few days.

You mean when we merge into dev? Also, I will start working on the tests, but I have family over, so it will be another few days.

No when me merge into main.
Please don't worry, enjoy family time!  I will slowly work on the things.


text:
update dependencies

closed with 2.10.1

repo: Annoraaq/grid-engine


text:
Create performance test scenarii with locust

Will do in a separate environment

repo: AntaresSimulatorTeam/AntaREST


text:
Create documentation

Any good ideas on how to structure the documentation would be nice. What do you like about other library docs? What would you say is required?
Also, I am tempted to use the github wiki, but perhaps placing docs in a /docs folder and hosting them on an external site would reduce lock-in?

repo: ArcadyIT/munisio


text:
Asgi support

@darwing1210 I am pulling your PR into my fork, for testing and use in my MVP. Will let you know how it goes. Thanks a ton for the commit.


text:
..

boa


text:
Azure private DNS zone (Private endpoints)

Feature/Enhancement moved to ADO for tracking

repo: Azure/avdaccelerator


text:
Prepare Key Vault Secrets release for October 2023.

API change check
API changes are not detected in this pull request.

repo: Azure/azure-sdk-for-java


text:
AutoPr-Kusto-radennis-REST Spec PrNumber 5366

No changes to the Sdk itself. Closing PR.

authors: adxsdknet dsgouda

repo: Azure/azure-sdk-for-net


text:
[textanalytics] update messaging to align across languages

API change check
API changes are not detected in this pull request.

authors: azure-sdk kristapratico

repo: Azure/azure-sdk-for-python


text:
bump version across the SDK

Is there any particular reason? Just to prepare for next release? We do normally bump versions - to prerelease versions, though - after a release across all our other languages. For a GA, we strip the prerelease semver part off right before we release.

Just prepping to do the next release.  We've been doing releases approximately once a month.

repo: Azure/azure-sdk-for-rust


text:
fix - player controls width on mobile

Thanks!

repo: Bellisario/musicale


text:
Staging

:tada: This PR is included in version 1.3.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

repo: BenjaminPasco/home


text:
Wait for Cargo publish

Publish failed for bitski-common just now, so seems like it's needed for Cloudsmith

Oh nvm, it failed b/c of missing auth token

repo: BitskiCo/bitski-internal-sdk


text:
Add registered_*s tables

wow, there are a lot of them :astonished:

authors: BuckarooBanzay appgurueu

repo: BuckarooBanzay/luacheck


text:
When you leave another person's profile, it should go back to the search bar

is this in the user stories or specs? because in the storyboards, I just have it go back to the user's main screen if they leave someone's profile page after they've searched that user

i'd prefer back to search, makes way more sense. WE're not trying to replicate the beartracks way of doing UX

authors: Mattwmaster58 QueenBeta kezzayuno


text:
Fix compilation error

哎呀这是我注释的，感谢修正！
虽然是修复编译错误...不过大家不会真的去编译这个仓库的Redis吧...我去掉了一些文件，不知道会不会影响编译...


text:
Issue #8 and #26 Fixed

LGTM too. Merge.

repo: CORD-ai/cord-website


text:
Release/1.1

Looks good to me, besides the mypy error in pyquil

authors: cqc-alec cqc-melf

repo: CQCL/pytket-extensions


text:
Develop re-work importer

old status

repo: CactuseSecurity/firewall-orchestrator


text:
Invite members

@GregBailey

All inaugural members invited.

repo: Cartheur-Research/evb-dev


text:
fix: fix package files

:tada: This PR is included in version 1.1.2 :tada:
The release is available on:

GitHub release
npm package (@latest dist-tag)

Your semantic-release bot :package::rocket:

repo: Chrtyaka/vue-use-bem


text: Fix

repo: Chuyu-Team/Dism-Multi-language


text:
Tr/fix prompt

Preparing PR description...

repo: Codium-ai/pr-agent


text:
Add wait-for-it.sh script

All I want for christmas is a better way to depend on wait-for-it.sh scripts across packages so we don't have to just copy the sh script code into places. I want versioning, I want changelogs, I want it all

Git sub repos?
On Wed, 24 Aug 2022, 3.23 PM Niels Abildgaard, @.***>
wrote:

All I want for christmas is a better way to depend on wait-for-it.sh
scripts across packages so we don't have to just copy the sh script code
into places. I want versioning, I want changelogs, I want it all
—
Reply to this email directly, view it on GitHub
https://github.com/CopenhagenCityArchives/kbh-billeder/pull/366#issuecomment-1225721226,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AABI7BCMA7U6F46ELUF6EX3V2YO5HANCNFSM57AVFHYQ
.
You are receiving this because you authored the thread.Message ID:
@.***>

I was thinking more along the lines of a package that could be installed somehow... if we could make wait-for-it a npm package, we can execute it with npx where needed (potentially installing as dev dependency, too)?

The problem is that it must be runnable from inside the containers, which
might not be running nodejs at all. Also - I think it would be dirty to
include it into the docker image, considering that it could just be a part
of the docker-compose setup.
The necessity of such docker-compose-related files was my reasoning behind
having a docker-compose-directory in the first place.
The ideal solution - in my view - would be if docker-compose itself had a
more mature readiness-concept.
On Thu, 25 Aug 2022 at 11:10, Niels Abildgaard @.***>
wrote:

I was thinking more along the lines of a package that could be installed
somehow... if we could make wait-for-it a npm package, we can execute it
with npx where needed (potentially installing as dev dependency, too)?
—
Reply to this email directly, view it on GitHub
https://github.com/CopenhagenCityArchives/kbh-billeder/pull/366#issuecomment-1226994888,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AABI7BGHSZWL653MGD3A4SLV24Z7JANCNFSM57AVFHYQ
.
You are receiving this because you authored the thread.Message ID:
@.***>

I'm not saying it should be part of a docker image. I'm also not saying that the npm solution will work for everything, but for a lot of cases it will.
My suggestion is to support something like this:

npm i wait-for-it
Add volume ${PWD}/node_modules/.bin/wait-for-it.sh:/wait-for-it.sh (notice wait-for-it is a binary in node_modules)
Add the same command you have added, e.g. /wait-for-it.sh elasticsearch:9200 -- npm run install-and-start

On machines that run npm we could make sure to install dev dependencies, which meas we would not need to mount in the volume and could run npx wait-for-it instead :smile:

repo: CopenhagenCityArchives/kbh-billeder


text:
Test and Document Atomic Swap with UTXO Support

done here https://github.com/CounterpartyXCP/counterparty-core/pull/2203

repo: CounterpartyXCP/counterparty-core


text:
How to remove the cursor from touch devices

if (window.matchMedia('(pointer:fine)').matches) {
    const cursor = new MouseFollower();
}

See also #14

awesome thanks

authors: Drafteed cocabangaa

repo: Cuberto/mouse-follower


text:
Ask user for feedback

The scope of this would be the digital design pattern for enabling users to provide feedback.
Aim: bring about consistency across DfE services in the way we ask users for feedback. We anticipate that we will not cover how the data is collected and analysed, although we may consider this as part of the contributions and see whether we can offer some guidance or recommendations.
Currently not in scope: centralise a component to collect all the feedback data and display / analyse across all services in the department.
Limitations: typically feedback is skewed towards particular issues users are having, so, if you ask for a user satisfaction rating or similar, the results will likely be biased. Could mitigate this by encouraging teams to report the % of users who leave feedback.

I've put a Lucid board together and asked the community to share examples. Will give it a week or 2 to gather contributions.

repo: DFE-Digital/dfe-frontend


text:
Added initial Db Script

I realise this isn't in the schema that was discussed, but would it be worth to set things like:

dateCreated -> set on create to GETUTCDATE()
dateLastUpdated -> same, but also on modified

etc.?

I realise this isn't in the schema that was discussed, but would it be worth to set things like:

dateCreated -> set on create to GETUTCDATE()
dateLastUpdated -> same, but also on modified

etc.?

Removed the database create script and added default UTC to the dateCreated


text:
[0050] Start rollover (To deploy in rollover env only!)

Failing tests are sorted in https://github.com/DFE-Digital/teacher-training-api/pull/2719

repo: DFE-Digital/teacher-training-api


text:
How do I use this?

It replaces your minecraft bedrock with the last version with the old rendering engine, just run it and reinstall your bedrock from it :D

Can this be used in Android?

Can this be used in Android?

No. Only on windows :(

repo: DMDCR/Minecraft-RenderDragonRemoval


text:
Feature: Enhance custom string- and char-type support

Pull Request Test Coverage Report for Build 11458200999
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.003%) to 99.453%

Totals

Change from base Build 11445343092:
0.003%

Covered Lines:
1090

Relevant Lines:
1096

💛  - Coveralls

authors: DNKpp coveralls

repo: DNKpp/mimicpp


text:
Feat 5.x

+1

repo: DTStack/dt-react-component


text:
WM-1606 - Add nonterminal state

LGTM.
Not asking for a change -- I'm interested in the opinions of others here -- but I kind of like the clock icon for "initializing" instead of the gear icon. Other reviewers and @kpierre13 , let me know what you think...

I'm good with either. That is what I had originally, but purely chose the cog for sake of variety. I'm happy to go with what majority thinks.

repo: DataBiosphere/cbas-ui


text:
Create speedtest.py

new for noob

repo: DataMastersDevelopers/datamasters


text:
Create a contact info block

Add an intro about yourself: who are you, what is your strength, why are you here.


text:
As a user, I want the elements in the experience to have pleasing micro-interactions.

Hey team! Please add your planning poker estimate with ZenHub @ChristopherSterza @Donovanphenry @JMBeresford @sedwardsmarsh

authors: ChristopherSterza gdochoa

repo: Deforestation-Detector/web


text:
Define the artistic aspect of the objects

The artistic aspect of the collectables was defined in our game presentation.


text:
Refactored Filter and Added a Builder

solves #4

authors: FabianAndrees stylefish

repo: EcholoN-software/echolon-api-client


text:
testing branch protection

Approved

repo: Eigen-DB/hnswgo


text:
LLM config via json file

Works great!

authors: deepak-akkil teaxio

repo: EmergenceAI/Agent-E


text:
Script added to dynamically create HTML and inject code

very good

repo: Fezzer/recipe-finder


text:
[channels,disp] fix typo in monitor->height

@freerdp-bot can you test that my friend ?

authors: dobord hardening

repo: FreeRDP/FreeRDP


text:
Automatically inject router.base in your Nuxt configuration file

Hello @marcin-krystianc ! This configuration seems to be working...
What is left please ?

Hello @marcin-krystianc ! This configuration seems to be working...

I don't think it works (although it should). I don't know yet what is going on.

authors: baimamboukar marcin-krystianc

repo: G-Research/DotNetPerfMonitor


text:
Create azure-webapps-node.yml

1.github/workflows/azure-webapps-node.yml


text:
ТОБД - практика №8 - Строки

https://github.com/GeorgiyDemo/FA/commit/c3fb5e0844ddc21737a47ba35c9c5a05bd9208bb

repo: GeorgiyDemo/FA

license: WTFPL


text:
feat(#22): install.sh with additional information

@SteinRobert Maybe you can check this PR as I do not have much shell scripting skills :D . I am not sure if this works on MAC, too. For me it printed the additional information with icons on Linux.

Pull Request Test Coverage Report for Build 2783865136

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 63.071%

Totals

Change from base Build 2773927302:
0.0%

Covered Lines:
994

Relevant Lines:
1576

💛  - Coveralls

authors: buschNT coveralls

repo: Getdeck/getdeck


text:
Add github workflow for pyink check

Tested the workflow : https://github.com/isha97/dataproc-spark-connect-python/actions/runs/10912508870


text:
Allow disk_size and source_family_project_id packer overriding

/gcbrun

/gcbrun


text:
docs: Update tags for go/render-helm-chart/v0.2.3

It looks like the CD job for pushing images is broken: https://github.com/GoogleContainerTools/kpt-functions-catalog/actions/workflows/after-tag-with-version.yaml
Will merge this PR after getting guidance on how to push to the image

I think that is expected to fail https://github.com/GoogleContainerTools/kpt-functions-catalog/pull/952/files#r1024392970
cc @justinsb

@sdowell Do you have any context on why the CD job exists if it is expected to fail?

@sdowell Thanks for the context! So is it expected to fail but still push the image to the container registry? Seems like the new render-helm-chart function tag didn't get pushed either

IIRC @justinsb was working on a new CD approach that was designed for a subset of functions he was working on. I don't have much more context than that, but it looks like that workflow doesn't work for any of the older functions which use the previous pattern of the Makefile in the parent directory.
I don't recall how exactly the old release flow works, I think there is an internal release pipeline that builds/publishes the images


text:
clang fixes, including a security bug in tls.

LGTM

authors: elbing rminnich

repo: Harvey-OS/harvey


text:
Feature/graphical

I suggest reviewing from the bottom up...a lot of code I wrote on the beginning of this branch has since been deleted

or start from this commit:
https://github.com/HydrologicEngineeringCenter/fda-statistics/pull/50/commits/f36750a1dfaa4def13039d3076253d57f51661dc

Thanks! I'll make the changes you suggest and then merge.


text:
Create DarkLearner.json

Hi


text:
Update deployment agent python version

more deployment agent! :fire:

repo: ITISFoundation/osparc-ops-environments


text:
udpate news article summary in README everytime

implemented in today's commit


text:
WIP Warning fixes

The last two commits are experimental, I want to see what CI thinks...

So there are 2 things to decide

can we make this last NULL -> nullptr change?  It's the only one left in the codebase! @hjmjohnson
the removal of those EIGEN_USUSED decorations is green on CI.  Shall we make this change until upstream eigen decides on their own fix? @phcerdan

@seanm looks good to me. I don't see any EIGEN_UNSUSED changes. Are you handling those in other PR? If you need me to cherry-pick commits from upstream or from your fork into our eigen, let me know, I'll be glad to help.

@seanm looks good to me. I don't see any EIGEN_UNSUSED changes. Are you handling those in other PR? If you need me to cherry-pick commits from upstream or from your fork into our eigen, let me know, I'll be glad to help.

I removed that commit so that this MR can be merged.  But at least it showed CI is ok with such a change.

All these changes look reasonable and hopefully work with modern supported platforms.

authors: hjmjohnson phcerdan seanm

repo: InsightSoftwareConsortium/ITK


text:
[Setting] 블로그 이전 게시글 이전

~22.08.11 완료


text:
Create system panic screen in exception handler.

This is now functionally complete, but I'd like to tidy up the display a little to make it easier to read.

repo: JackScottAU/Amethyst

license: ISC


text:
add unittests

Codecov Report

:exclamation: No coverage uploaded for pull request base (dev@efb6b92). Click here to learn what that means.
The diff coverage is n/a.

@@          Coverage Diff          @@
##             dev     #61   +/-   ##
=====================================
  Coverage       ?   0.00%
=====================================
  Files          ?      20
  Lines          ?    1332
  Branches       ?       0
=====================================
  Hits           ?       0
  Misses         ?    1332
  Partials       ?       0

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

authors: JarbasAl codecov-commenter

repo: JarbasHiveMind/HiveMind-core


text:
Create hngeelyedu.txt

@kawa11 First stage of verification passed, official domain is hngeelyedu.cn as far as I verified. This is just an informational note. Pull request is still in the review. I appreciate your patience while waiting for the final decision.

@kawa11 The website is permanently unavailable. I cannot add the domain without verification. I recommend students of this university to apply for free educational license with an official document which proves that they are students. One can do it using "OFFICIAL DOCUMENT" tab at https://www.jetbrains.com/shop/eform/students.
I have to close the request without merging.
Thank you for your understanding!

repo: JetBrains/swot


text:
Add: Universidad del Norte

@Carvajalo I am sorry, the domain uninorte.edu.co is removed from our trusted domains list because it was abused in the past. If you are the student of this school, please enroll to GitHub Student Developer Pack at https://education.github.com/discount_requests/application. Then apply for JetBrains educational subscription with your GitHub account (GitHub tab at https://www.jetbrains.com/shop/eform/students).

authors: Carvajalo philipto


text:
University of the West Indies

@mitrakalloo I am sorry, the domain my.uwi.edu is removed from our trusted domains list because it was abused in the past. If you are the student of this school, please enroll to GitHub Student Developer Program. Then apply for JetBrains educational subscription with your GitHub account (GitHub tab at https://www.jetbrains.com/shop/eform/students).

authors: mitrakalloo philipto


text:
add Martin Segitz Schule

@AdrisGithub The first verification stage is complete: the official domain for  Martin-Segitz-Schule – Staatliche Berufsschule III Fürth is www.b3-fuerth.de, to the best of my knowledge. This is just an informational note. The pull request is still under review. The review may take some more time. I greatly appreciate your patience. Here is the proof of domain ownership: https://www.b3-fuerth.de/wp-content/uploads/2023/10/MS-Azure-Informationen_V10.pdf

authors: AdrisGithub philipto


text:
Improve docstrings and close #27

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (b1e25f8) 90.24% compared to head (d03954c) 90.24%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff           @@
##           master      #30   +/-   ##
=======================================
  Coverage   90.24%   90.24%
=======================================
  Files           3        3
  Lines          82       82
=======================================
  Hits           74       74
  Misses          8        8

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

authors: carstenbauer codecov-commenter


text:
[CI] Some fixes to GitHub Actions setup

Ok, the state of testing of this package is particularly sad.  I can't find a commit of this package where tests pass for me on julia v1.10.5.  However I'm not familiar with this code and don't have time to dig into it to fix it, so I'm just going to merge this PR to make at least job not taking forever to finish.


text:
Cleaned up repo

LGTM


text:
Lab1/unittest multiple users

Multiple Users

repo: JulianFrattini/edutask


text:
Add feature to send user agent string

completed

repo: Juniper/apstra-go-sdk


text:
Feature/topology tests & lint

Codecov Report
Attention: Patch coverage is 72.00000% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 22.04%. Comparing base (cb92282) to head (fb3386f).
Report is 1 commits behind head on master.

Files
Patch %
Lines

providers.go
0.00%
4 Missing :warning:

topology.go
80.00%
3 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #24      +/-   ##
==========================================
+ Coverage   16.20%   22.04%   +5.83%
==========================================
  Files           9        9
  Lines         617      635      +18
==========================================
+ Hits          100      140      +40
+ Misses        511      488      -23
- Partials        6        7       +1

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

authors: KaymeKaydex codecov-commenter

repo: KaymeKaydex/go-vshard-router


text:
HTML 24: Link CSS, JS, JQuery and JQueryUI CDNs to HTML.

All linked to HTML

authors: Kelllzzz RamisaChowdhury

repo: Kelllzzz/Avo-Great-Day


text:
Zk rollup/main contract pallet

[ ] batch proof verification
[ ] operator fee
[ ] use same rpc interface with pallet-balance transfer
[ ] withdraw proof verification

authors: KiriosK ashWhiteHat

repo: KogarashiNetwork/Kogarashi


text:
Docs: 要致富，先撸树

看来又要多出好几个 PR 了（

快拉点人来做苦力，孩纸要开学了 （bushi

repo: KomoriDev/NoneBotX


text:
add hero section

Duplicated PR

authors: juancwu norachams

repo: LaurierHawkHacks/Landing


text:
Fixed getMood problem

This feels a bit random - how does this answer relate to the question?

Beginners don't set the mood 9 times out of 10 and then while trying to get the mood they get this error. Also i believe this could have been answered better i'll do another PR with a better explanation. I also feel like i didn't answer it the way it should be answered.


text:
С прошедшим Днём рождения!

хахахаха, спасибо)
<3


text:
New location please: Somerville, VIC

I added it myself :)

repo: LukePrior/nbn-upgrade-map


text:
Slight Changes

ss


text:
MANGO-424. Feature: updated message DTO.

Codecov Report

Merging #178 (64a3faf) into develop (008920b) will not change coverage.
The diff coverage is 70.00%.

@@           Coverage Diff            @@
##           develop     #178   +/-   ##
========================================
  Coverage    59.69%   59.69%
========================================
  Files          202      202
  Lines         2970     2970
  Branches       110      110
========================================
  Hits          1773     1773
  Misses        1176     1176
  Partials        21       21

Flag
Coverage Δ

web
59.69% <70.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...piCommands/Messages/DeleteMessageCommandHandler.cs
71.42% <0.00%> (ø)

....BusinessLogic/Models/MessageDeleteNotification.cs
20.00% <0.00%> (ø)

...iQueries/Messages/SearchChatMessageQueryHandler.cs
58.44% <50.00%> (ø)

.../ApiCommands/Messages/EditMessageCommandHandler.cs
88.67% <66.66%> (ø)

.../ApiCommands/Messages/SendMessageCommandHandler.cs
100.00% <100.00%> (ø)

...gic/ApiQueries/Messages/GetMessagesQueryHandler.cs
100.00% <100.00%> (ø)

MangoAPI.BusinessLogic/Models/Chat.cs
83.87% <100.00%> (ø)

MangoAPI.BusinessLogic/Models/Message.cs
97.22% <100.00%> (ø)

...PI.BusinessLogic/Models/MessageEditNotification.cs
100.00% <100.00%> (ø)

MangoAPI.Domain/Entities/ChatEntity.cs
92.85% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 008920b...64a3faf. Read the comment docs.

authors: Khachatur-Khachatryan codecov-commenter

repo: MangoInstantMessenger/MangoMessengerAPI


text:
LFD-48 Fix Sonar Smells and Bugs

Haben Teamentwicklung durchgeführt. Review passt.

authors: MaximilianLincks aigenseer

repo: MaximilianLincks/LectureFeed


text:
Added scale option to image generation

Images:

repo: McCzarny/crypto-mongrels


text:
Build add rollup

:tada: This PR is included in version 1.2.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

repo: Menuable/MenuAlly


text:
Create bulk operation wrapper

https://github.com/Michael-Gibbons/osb-addon-bulk-operations

repo: Michael-Gibbons/OSB


text:
porting the changes for m89

rest looks fine

authors: acesiddhu allendm-msft

repo: Microsoft/vso-agent-tasks


text:
updated the title

#sign-off

authors: brendansco stevemunk

repo: MicrosoftDocs/azure-docs


text:
[operator-nexus] Update description for CSN_ARM_ID and L3_NETWORK_ID.

#assign-review:harish6724

#sign-off


text:
add azureml-fe tsg for kubernetes online endpoint

@snowei : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@petrodeg
Can you review the proposed changes? IMPORTANT: When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
#assign:@MicrosoftDocs/public-repo-pr-review-team

The following users don't have valid GitHub IDs, or are not collaborators on this repo: microsoftdocs/public-repo-pr-review-team


text:
Update private-offers-api.md

@djbreen7 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@rigonzales,
Can you review the proposed changes?
IMPORTANT: When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge. Thanks.
#label:"aq-pr-triaged"
#assign:@MicrosoftDocs/public-repo-pr-review-team

The following users don't have valid GitHub IDs, or are not collaborators on this repo: microsoftdocs/public-repo-pr-review-team

#sign-off this is simply a JSON syntax error (missing comma) that has been fixed. Thanks to @djbreen7

This PR will close automatically when the public-private repo sync happens. Do not merge.


text:
Stronger guidance on resilient authentication using UAMI

#sign-off

authors: anlandu barclayn

repo: MicrosoftDocs/entra-docs


text:
Live

Docs Build status updates of commit 779aa32:
:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

repo: MicrosoftDocs/msteams-docs


text:
Configure code ql

:tada: This PR is included in version 1.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

repo: Mikycid/dev-console


text:
refactor: logging module

Low-hanging fruit done

repo: Mitchellpkt/python-isthmuslib


text:
As a user, I want the platform's interface to be intuitive and user-friendly, providing clear error messages and guiding me through any issues I encounter.

The UI is interactive and error messages are provided for every task. This has been completed in M3.

repo: MithishR/Communicado


text:
Go SDK Sync - fix(api): add response body to get /api/virtual_accounts and update resources - v0.0.1

Closing - we are using Stainless' automated release system now

repo: Modern-Treasury/modern-treasury-go


text:
HTTPS

HTTPS is now available with Link v2 and above!


text:
Similar() to find similar pages by tags is broken.

Created missing script and added "top count" parameter.

repo: NTDLS/TightWiki


text:
add some kafka model constraint args

Test fails but patch lg2m

authors: jolynch nickmahilani


text:
Implement CI/CD for Devnet upgrades (Dev & Prod)

Done

repo: NethermindEth/starknet-remix-plugin


text:
View ticket page are missing logout button

This was resolved in 58b270a9e7475aa7eab645fff7a1df5121e79c78

@xavanx I think this has been resolved

authors: continuumNought xavanx

repo: NimbusInformatics/bdcat-data-tracker


text:
Figure out how to hide Services from Post group

I don't see any reason for this right now, it looks good as it is


text:
Don't Merge! PR real time test for source branch full build

Docs Build status updates of commit 38465d2:
:clock10: Full build: the average full build time is 7 min(s) 24 sec(s), this is based on the last 30 build(s) for this repository.

Docs Build status updates of commit 38465d2:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docfx.json
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


text:
Don't Merge! PR real time test for webhook case

Docs Build status updates of commit 22fdcfb:
:clock10: Pending: waiting for processors (24 builds ahead of you)
:warning: Docs Build is busy, currently there are 24 builds ahead of this one, for more information you can view the Build queue graph on the Docs Portal.

Docs Build status updates of commit 22fdcfb:
:clock10: Full build: the average full build time is 7 min(s) 51 sec(s), this is based on the last 30 build(s) for this repository.

Docs Build status updates of commit 22fdcfb:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs-ref-conceptual/testing.md
:white_check_mark:Succeeded
View (azure-cli-latest) View (azure-cli-2017-03-09-profile) View (azure-cli-2018-03-01-hybrid)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


text:
03/27/2018 02:52 : Create Pull Request for branch prTesting_2018032702 -> master

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

split/updateTestRef.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


text:
Adult Dungeons

@Joshua8600 is this ready to be reviewed?

repo: OoTMM/OoTMM


text:
Update Maven plugins

Included in the latest 0.0.2-SNAPSHOT tag

repo: OpenPj/manifoldcf-sdk


text:
Add manifest tests

Before merge, the Manifest Tests in the shared repo should be merged and the reference updated in these actions

Apologies for not reviewing in time.

repo: OpenVoiceOS/skill-ovos-date-time


text:
Feature/support for private

https://github.com/OriginTrail/dkg.js/pull/186 <- added here

authors: Mihajlo-Pavlovic brkagithub


text:
Hello, will there be such a project on IOS？

it's very hard to do since the symbols are stripped from binary file

try https://github.com/vfsfitvnm/frida-il2cpp-bridge

authors: KarmaMod Perfare Suiran1031


text:
Fix /playertags not opening UI

Hey, thank you very much for this PT. But for whatever reason I didn't get any  otification for this, so I didn't see it. I already fixed it and pushed an update yesterday, so I close this.


text:
CI for Node

Contains the compiled JavaScript

repo: PrestonHarrod/github-actions-for-ci


text:
Add accessors for email / name on Contact

Thanks!

authors: jelmer konstin


text:
Update qiskit.org textbook beta link

qiskit.org learn page is being updated: https://github.com/Qiskit/qiskit.org/issues/2553
and part of the update includes changing the beta url: https://github.com/Qiskit/qiskit.org/issues/2605
this issue is to update the textbook beta link reference to the new url: https://github.com/Qiskit/platypus/blob/main/server/utilities.ts#L26
this should be corrdinated with the learn page going live

repo: Qiskit/platypus


text:
рефакторинг js

Большинство кейсов корректно отрабатывает.
Одно условие пропущенно - судя по тест кейсам было необходимо следить за длиной строк в аргументах и выполнять функцию только для одного символа возвращать -1.
P.S. На мой взгляд можно улучшить читаемость кода задав осмысленные имена аргументам и самой функции. Увеличение кода небольшое, а польза на мой взгляд значительная.

Отличное решение в одну строчку.
Из критичного отмечу падение тестов, что является недопустимым, так как в случае рефакторинга не подразумевается изменение логики функции, но это произошло в нашем случае.

repo: QoreCode/second-task-js


text:
Create Historical Interest Rate Graph (1982-2023)

Hi @jstac,
This PR is up-to-date with the figures I demonstrated today.
Please let me know if there is anything I can further improve.
Many thanks in advance.

repo: QuantEcon/macro-case-studies


text:
Full Tree

When thinking about this, I found that lorenz tree API felt very natural and a similar API surface could be created.
See Entry.java and MappingSet.java.
Some attention should be also be given to MappingTreeView.java from mapping-io

repo: QuiltMC/quilt-mapping-tools


text:
12 add a login page

Looks Ok, merging this into Main


text:
readme assets

https://user-images.githubusercontent.com/21000943/150613732-442589e2-6b08-4b14-b0a3-47effef0eb28.mov

repo: RRethy/nvim-treesitter-endwise


text:
EBS to org_id migration changes

@r14chandra Yupana does not include any other field so I have not added it in yuptoo too. Does puptoo includes org_id and account under platform_metadata?

/retest

@r14chandra Yupana does not include any other fields, To make Yuptoo equivalent to Yupana I think for now we can skip org_id, account ad other fields in platform_metadata.

Sure! we can merge this PR then.

repo: RedHatInsights/yuptoo


text:
Add PARENT_JOB_NAME as default name for ci job in iib flow

/verified

New container for quay.io/redhat_msi/ocp-addons-operators-cli:latest published

repo: RedHatQE/ocp-addons-operators-cli


text:
Support Span

已经实现了自己的Span规则，该规则适用于RPC调用


text:
Incluindo classe PisType

Codecov Report

Merging #4 (5ec2b0d) into main (ffd46b2) will decrease coverage by 24.92%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##             main       #4       +/-   ##
===========================================
- Coverage   98.30%   73.37%   -24.93%
===========================================
  Files           4        5        +1
  Lines         471      631      +160
===========================================
  Hits          463      463
- Misses          8      168      +160

Flag
Coverage Δ

unittests
73.37% <0.00%> (-24.93%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

src/PisType.cs
0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ffd46b2...5ec2b0d. Read the comment docs.

Testando comentário para aparecer na issues

Comentando fazendo referência a issues #3

authors: RenatoPacheco codecov-commenter


text:
do action when module not exitst

#1 fixed


text:
SP-500: Add Data Product document template

Thank you!  Merging...

repo: SPHEREx/spherex-templates


text:
Not getting a gaussian curve in the graph

solved this bug in the commit bb5a6908fd87fb980360efd8794e77bee6fd24b1


text:
Add Contact-us page

Hello, I would like to work upon this issue, please assign it to me

@SauravMukherjee44 I would like to work on this issue.

authors: Amritanshu02 HetviSoni I-ArchanaDash


text:
[skip ci] LanguageTool

This is pretty cool, what tool are you using for this @ArnoStrouwen?

LanguageTool, specifically through VS Code.


text:
Add limit on comment text when showing on main page

I've search for the ruby solution but I was not able to find it.
On Sun, 4 Dec 2022, 1:21 pm Shehroz Irfan, @.***> wrote:

@.**** commented on this pull request.
In app/views/comments/index.html.erb
https://github.com/ShehrozIrfan/comment_tree_app/pull/48#discussion_r1038928043
:

@@ -9,7 +9,7 @@
<% @comments.each do |comment| %>

                 <%= link_to comment_path(comment.id), class: 'text-dark' do %> <%= comment.text %><% end %>

                 <%= link_to comment_path(comment.id), class: 'text-dark link' do %> <%= comment.text %><% end %>

Please use a definitive class name, like link is very generalized.
You can use comment-text-with-limit
—
Reply to this email directly, view it on GitHub
https://github.com/ShehrozIrfan/comment_tree_app/pull/48#pullrequestreview-1203615651,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AYAFYYDGMUBCTAJG4XRQI63WLRIAPANCNFSM6AAAAAASTAD2M4
.
You are receiving this because you were mentioned.Message ID:
@.***>

Hey @FaheemAhmedNoor ,
We can use  comment.text.truncate(255) and that's it. No need to do a lot of stuff.

@FaheemAhmedNoor
Is it possible for you to add the above updates on this weekend?

#62

authors: FaheemAhmedNoor ShehrozIrfan


text:
Save image libraries in binary format

Massively reduced disk space required, and much faster.
-rw-r--r--. 1 simon simon  49511 Mar 15 09:23 font.lib
-rw-r--r--. 1 simon simon   4428 Apr  1 17:07 font_blb
-rw-rw-rw-. 1 simon simon  42534 Mar 31 11:59 invaders.lib
-rw-r--r--. 1 simon simon   3911 Apr  1 17:07 invaders_blb

repo: SimonGreenaway/QL-Space-Invaders


text:
Feature/aos 4955 migrering av applicationdeployments

merget inn

repo: Skatteetaten/herkimer


text:
Feature/vdx 172/version discovery

Please rebase, as there are simply too many changes from @sksadjad in here for me to do a proper review

authors: hrehman-sphereon nklomp


text:
WAL-380

Codecov Report

Merging #79 (29bc199) into develop (9de66e4) will decrease coverage by 3.39%.
The diff coverage is 12.38%.

:exclamation: Current head 29bc199 differs from pull request most recent head cbc5d7a. Consider uploading reports for the commit cbc5d7a to get more accurate results

@@             Coverage Diff             @@
##           develop      #79      +/-   ##
===========================================
- Coverage    48.85%   45.45%   -3.40%
===========================================
  Files           62       64       +2
  Lines         2178     2389     +211
  Branches       456      516      +60
===========================================
+ Hits          1064     1086      +22
- Misses        1114     1303     +189

Impacted Files
Coverage Δ

.../connection-manager/src/agent/ConnectionManager.ts
0.00% <0.00%> (ø)

...ction-manager/src/store/AbstractConnectionStore.ts
0.00% <ø> (ø)

...kages/data-store/src/connection/ConnectionStore.ts
0.00% <0.00%> (ø)

...es/vc-handler-ld-local/src/ld-credential-module.ts
84.28% <ø> (ø)

.../src/suites/impl/JsonWebSignatureWithRSASupport.ts
6.73% <6.73%> (ø)

...-local/src/suites/impl/JsonWebKeyWithRSASupport.ts
14.00% <14.00%> (ø)

...andler-ld-local/src/suites/JsonWebSignature2020.ts
10.71% <16.66%> (+0.71%)
:arrow_up:

...ler-ld-local/src/agent/CredentialHandlerLDLocal.ts
85.98% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

LGTM

repo: Sphereon-Opensource/ssi-sdk


text:
feature/login

Nesse momento já tem um HTML Básico para implementar as funcionalidades do back-end.
@ViniciusGregorine


text:
Course-Certification

CertificateOfCompletion_Python Quick Start.pdf

CertificateOfCompletion_Introducing Jupyter.pdf

repo: TANDuming/github-slideshow


text:
Vytvorit plan implementacie

Pages:

.css
Kostra (hlavicka, nav, peta)
Index (nastenka) (P1, P2, S7)
Login (P1, P2, S3)
Rozvrch (P1, P2, S4)
Vlak (P1, P2, S4, S6)
Historia (P1, P2, S4)
Admin (P1, P2, S3)
Change (P1, P2, S3, S8)

Web components:

Vlak ikona (S4, M2, P1) ?
Vagon ikona (S6, M5, P1) ?

Models:

Datetime
User
Train (M1)
Template
Wagon
Note (M1)

Services:

DbConnectionService
SQLService (S1)
UserManagerService (S2, M2)
TrainManagerService (S2, M3)
TemplateManagerService (S2, M4)
WagonManagerService (S2, M5)
NotesManagerService (S2, M6)
UserChangesManagerService (S2, M2, M1)

Config.txt

Pridat service - FileExportService
Page Historia zavysi na FileExportService

license: Unlicense


text:
Last item in library doesn't disappear when removed

Fixed in f390c251

repo: Tajmoti/Tulip