text:
[Test][Plugin]Plugin Test

Hi, everyone, at present we have added many new plugins to the dev branch. We plan to release a version in March. Community contributors are welcome to test it. If you are interested in this, please leave a message in the issue (if you are interested plugin), I will assign it to you, please leave a message in this issue when you are finished, (if you have additional information, you can submit an issue and indicate it in the comment)
You can find the documentation of the plugin on the official website: https://seatunnel.apache.org/docs/introduction

Spark
Plugin
Assignees
Status
Comment

Source
TiDB
@zixi0825

Sink
TiDB
@zixi0825

Source
Socket
@wuchunfu
done

Sink
Redis
@wuchunfu
done

Source
Redis
@wuchunfu
done

Sink
Phoneix
@PotatoDream

Source
Phoneix
@PotatoDream

Source
Neo4J
selectbook

Sink
MongoDB
@wuchunfu
done

Source
MongoDB
@wuchunfu
done

Sink
Kudu
@simon824
done

Source
Kudu
@simon824
done

Sink
Kafka
@ZhangchengHu0923
done

Source
Kafka
@ZhangchengHu0923
done

Sink
Jdbc
@zhaomin1423 @wuchunfu
done

Source
Jdbc
@zhaomin1423 @wuchunfu
done

Sink
Hudi
@leo65535

Source
Hudi
@leo65535

Sink
Hive
@zhaomin1423

Source
Hive
@zhaomin1423

Sink
Hbase
@PotatoDream @simon824
done

Source
Hbase
@PotatoDream @simon824
done

Sink
File
@simon824
done

Source
File
@simon824
done

Source
Fake

Sink
Email
@lvshaokang

Source
Elasticsearch
@ITzhangqiang

Sink
Elasticsearch
@ITzhangqiang

Sink
Doris
@taikongren365
done

Sink
Console
@dailidong

Sink
ClickHouse
@xsaffable
done

Transform
Split
@denglingang @simon824 @wuchunfu
done

Transform
Sql
@denglingang @simon824
done

Transform
Json
@denglingang

Flink
Plugin
Assignees
Status
Comment

Source
Socket
@JesseAtSZ
done

Sink
Kafka
@gaodayu1209

Source
Kafka
@gaodayu1209

Sink
JDBC
@kalencaya

Source
JDBC
@kalencaya

Sink
InfluxDB
@asdf2014

Source
InfluxDB
@asdf2014

Source
File
@simon824  @kalencaya
done

Sink
File
@simon824  @kalencaya
done

Source
Fake
@JesseAtSZ
done

Sink
Elasticsearch
@ITzhangqiang

Source
Druid
@asdf2014

Sink
Druid
@asdf2014

Sink
Doris
@taikongren365
done

Source
Console
@dailidong

Transform
Split
@simon824
done

Transform
Sql
@simon824
done

Transform
table2datastream

Transform
datastream2table

Hi @CalvinKirs, I would like to pick up the plugins of Druid and InfluxDB since I contributed them. BTW, you have missed the source plugin of InfluxDB I believe, please add it as well, thanks.

Hello, I would like to pick up the plugins of spark-jdbc and spark-hive.

Hi, I'm willing to pick up flink jdbc and file plugins, for I'm working on them

Hello, I would like to pick up the plugins of flink-kafka

@CalvinKirs Hi, I will test with redis and mongodb

Hello, I would like to pick up the plugins of Transform-json , Transform-split, and Transform-sql

Dear @CalvinKirs, Im willing to pick up Spark-Sink-Doris and Flink-Sink-Doris. For now, im doing jobs with Doris.

@CalvinKirs  I would like to pick up the plugins of spark-tidb source and sink

@CalvinKirs I would like to pick up Elasticsearch-source and Elasticsearch-sink, for I'm good at them.

@CalvinKirs I would like to pick up the plugins of ClickHouse-sink.

@CalvinKirs  I would like to pick up the plugins of spark-hbase/spark-phoenix source and sink.

@CalvinKirs  No similar tests have been done before. Is this test rigorous? Is there any guidance? If I can, I'd like to try fake source.

@CalvinKirs No similar tests have been done before. Is this test rigorous? Is there any guidance? If I can, I'd like to try fake source.

We need to test whether the corresponding plug-in is working properly, following the plug-in documentation will do. For now, just make sure it works functionally

@CalvinKirs  I would like to pick up the plugins of spark-kaka source and sink，and I would test it in local mode, if u don't mind

@CalvinKirs I would like to pick up the plugins of spark-kafka source and sink，and I would test it in local mode, if u don't mind

I plan to do the test work like this: Sink the data to Kafka from a mysql table, and then sink it back to another mysql table after subscribe it from Kafka by the source plugin，just like the picture below.
@CalvinKirs
the question is: I don't know whether I can test it this way for not knowing weather seatunnel will  serialize and deSerialize the data automaticly

hi，guys,Please update the status of this issue as soon as you finish the test

@CalvinKirs I would like to pick up the plugins of spark-kafka source and sink，and I would test it in local mode, if u don't mind

I functionally tested this and everything works，but I didn't do any performance testing
@CalvinKirs

@CalvinKirs I would like to pick up the plugins of spark-kafka source and sink，and I would test it in local mode, if u don't mind

I functionally tested this and everything works，but I didn't do any performance testing @CalvinKirs

the doc has nothing write about spark-kafka source plugin,I'd like to add what I learn while doing the test to the document
@CalvinKirs

@CalvinKirs I would like to pick up the plugins of spark-kafka source and sink，and I would test it in local mode, if u don't mind

I functionally tested this and everything works，but I didn't do any performance testing @CalvinKirs

the doc has nothing write about spark-kafka source plugin,I'd like to add what I learn while doing the test to the document,could u tell me the step to do it @CalvinKirs
is here https://github.com/apache/incubator-seatunnel/blob/dev/docs/en/spark/configuration/sink-plugins/Kafka.md,
You can see if there is anything to add to this, and again, deeply thanks for your contribution. 👍

@CalvinKirs I would like to pick up the plugins of spark-kafka source and sink，and I would test it in local mode, if u don't mind

I functionally tested this and everything works，but I didn't do any performance testing @CalvinKirs

the doc has nothing write about spark-kafka source plugin,I'd like to add what I learn while doing the test to the document,could u tell me the step to do it @CalvinKirs

is here https://github.com/apache/incubator-seatunnel/blob/dev/docs/en/spark/configuration/sink-plugins/Kafka.md, You can see if there is anything to add to this, and again, deeply thanks for your contribution. 👍

I found that we are just missing a link in the readme file, need I add and submit a PR ?

@CalvinKirs I would like to pick up the plugins of spark-kafka source and sink，and I would test it in local mode, if u don't mind

I functionally tested this and everything works，but I didn't do any performance testing @CalvinKirs

the doc has nothing write about spark-kafka source plugin,I'd like to add what I learn while doing the test to the document,could u tell me the step to do it @CalvinKirs

is here https://github.com/apache/incubator-seatunnel/blob/dev/docs/en/spark/configuration/sink-plugins/Kafka.md, You can see if there is anything to add to this, and again, deeply thanks for your contribution. 👍

I found that we are just missing a link in the readme file, need I add and submit a PR ?

This is the best 👍

@CalvinKirs I would like to pick up the plugins of ClickHouse-sink.

I tested it in local mode and yarn mode, everything works fine.

well done, deeply thanks. 👍

@CalvinKirs

Dear @CalvinKirs

Dear @CalvinKirs, Im willing to pick up Spark-Sink-Doris and Flink-Sink-Doris. For now, im doing jobs with Doris.

I functionally tested both Spark-Sink-Doris and Flink-Sink-Doris plugin.

Dear @CalvinKirs, Im willing to pick up Spark-Sink-Doris and Flink-Sink-Doris. For now, im doing jobs with Doris.
I tested both Spark-Sink-Doris and Flink-Sink-Doris plugin. Both of them works functionally well with sample cases.

Dear @CalvinKirs, Im willing to pick up Spark-Sink-Doris and Flink-Sink-Doris. For now, im doing jobs with Doris.

I tested both Spark-Sink-Doris and Flink-Sink-Doris plugin. Both of them works functionally well with simple cases in local mode. Laterly, I will update result which is tested on my Company's Cluster Environment.

Dear @CalvinKirs, Im willing to pick up Spark-Sink-Doris and Flink-Sink-Doris. For now, im doing jobs with Doris.

I tested both Spark-Sink-Doris and Flink-Sink-Doris plugin. Both of them works functionally well with simple cases in local mode. Laterly, I will update result which is tested on my Company's Cluster Environment.

well done, deeply thanks. 👍

@zixi0825, @wuchunfu, @PotatoDream, @zhaomin1423, @leo65535, @PotatoDream, @ITzhangqiang, @denglingang, @gaodayu1209, @asdf2014, @kalencaya, @taikongren365
hi, everyone, if you finish the test, remember to leave a message in this issue, thank you.

These Plugins are done.
spark：file-sink、file-source、transform-split、transform-sql
flink：file-sink、file-source、transform-split、transform-sql

Dear @CalvinKirs, Im willing to pick up Spark-Sink-Doris and Flink-Sink-Doris. For now, im doing jobs with Doris.

I tested both Spark-Sink-Doris and Flink-Sink-Doris plugin. Both of them works functionally well with simple cases in local mode. Laterly, I will update result which is tested on my Company's Cluster Environment.

Flink-Sink-Doris.conf.txt
Spark-Sink-Doris.conf.txt

well done, deeply thanks. 👍

I've finished tests on Company's Cluster Environment. They all ran quite well.
Below is my config file for anyone who  is interested in Spark-Sink-Doris and Flink-Sink-Doris plugin.
Dear @CalvinKirs I thought tests for Spark-Sink-Doris and Flink-Sink-Doris plugin are done.

These Plugins have been done. spark：file-sink、file-source、transform-split、transform-sql flink：file-sink、file-source、transform-split、transform-sql

well done, thanks

Dear @CalvinKirs, Im willing to pick up Spark-Sink-Doris and Flink-Sink-Doris. For now, im doing jobs with Doris.

I tested both Spark-Sink-Doris and Flink-Sink-Doris plugin. Both of them works functionally well with simple cases in local mode. Laterly, I will update result which is tested on my Company's Cluster Environment.

Flink-Sink-Doris.conf.txt Spark-Sink-Doris.conf.txt

well done, deeply thanks. 👍

I've finished tests on Company's Cluster Environment. They all ran quite well. Below is my config file for anyone who is interested in Spark-Sink-Doris and Flink-Sink-Doris plugin. Dear @CalvinKirs I thought tests for Spark-Sink-Doris and Flink-Sink-Doris plugin are done.

well done, thanks

@zixi0825,  @PotatoDream, @zhaomin1423, @leo65535, @PotatoDream, @ITzhangqiang, @denglingang, @gaodayu1209, @asdf2014, @kalencaya
hi, everyone, if you finish the test, remember to leave a message in this issue, thank you.

Of course I will do.
Actually, I'm resolving flink JdbcSink plugin exception which caused by not implementing FlinkStreamSink<Row, Row> interface and try to pull request recently.

@zixi0825, @PotatoDream, @zhaomin1423, @leo65535, @PotatoDream, @ITzhangqiang, @denglingang, @gaodayu1209, @asdf2014, @kalencaya
hi, everyone, if you finish the test, remember to leave a message in this issue, thank you.

of course I will do.
Actually, I'm resolving flink JdbcSink plugin exception which caused by not implementing FlinkStreamSink<Row, Row> interface and pull my request recently.

Do Flink socket and fake source need to be tested? I've been using these two sources for debugging recently. There's no problem.

hi, I have tested spark-kudu source & sink, spark-hbase source & sink.

@CalvinKirs The following modules have been tested and the tests passed
spark-connector-source-socket
spark-connector-source-redis
spark-connector-sink-redis
spark-connector-source-mongodb
spark-connector-sink-mongodb
spark-connector-source-jdbc
spark-connector-sink-jdbc
spark-transform-split

@CalvinKirs spark-connector-source-hive and spark-connector-sink-hive work well.  spark-connector-source-jdbc work well.

@CalvinKirs The following modules have been tested and the tests passed
spark-connector-source-socket
spark-connector-source-redis
spark-connector-sink-redis
spark-connector-source-mongodb
spark-connector-sink-mongodb
spark-connector-source-jdbc
spark-connector-sink-jdbc
spark-transform-split

spark-connector-sink-jdbc has a bug when save mode is update.

@CalvinKirs The following modules have been tested and the tests passed
spark-connector-source-socket
spark-connector-source-redis
spark-connector-sink-redis
spark-connector-source-mongodb
spark-connector-sink-mongodb
spark-connector-source-jdbc
spark-connector-sink-jdbc
spark-transform-split

spark-connector-sink-jdbc has a bug when save mode is update.

I'll merge in later

@CalvinKirs The following modules have been tested and the tests passed
spark-connector-source-socket
spark-connector-source-redis
spark-connector-sink-redis
spark-connector-source-mongodb
spark-connector-sink-mongodb
spark-connector-source-jdbc
spark-connector-sink-jdbc
spark-transform-split

spark-connector-sink-jdbc has a bug when save mode is update.

I'll merge in later

Thanks.

@CalvinKirs flink-connector-source-jdbc and flink-connector-sink-jdbc workes well and ready for release

@CalvinKirs when I tested spark-kafka plugin, I had used spark-console-sink ,it works well

@CalvinKirs
Hi，I tested the components related Elasticsearch
SPARK：Elasticsearch-source and Elasticsearch-sink doesn't support ES 7.x version
FLINK： Elasticsearch-sink doesn't support ES 7.x version
Does the community plan to support multiple versions? Maybe I can give it a try

@CalvinKirs  Hello, I would like to pick up the plugins of Spark-Neo4J

@CalvinKirs Hello, I will like to test the email plugin sink

@CalvinKirs Hi，I tested the components related Elasticsearch SPARK：Elasticsearch-source and Elasticsearch-sink doesn't support ES 7.x version FLINK： Elasticsearch-sink doesn't support ES 7.x version Does the community plan to support multiple versions? Maybe I can give it a try

Hi,#1631 is doing this.

@CalvinKirs
I tested the email sink，i found some enhancement points，like enable ssl/tsl option、support ArrayType data etc. I will submit a pr later.

@CalvinKirs I tested the email sink，i found some enhancement points，like enable ssl/tsl option、support ArrayType data etc. I will submit a pr later.

well.that's good 🤣

@CalvinKirs
PTAL. https://github.com/apache/incubator-seatunnel/pull/1686

Hello, I would like to test  the transform of table2datastream and datastream2table

nice

repo: apache/incubator-seatunnel


text:
sharding-jdbc and sharding-proxy use same metaData refresh strategy.

i find sharding-jdbc and sharding-proxy have same code for metaDataRefresh after execute ddl.
so i remove MetaDataRefreshStrategy  from Sharding-jdbc-core to ShardingSphere-common.
then sharding-jdbc ,sharding-proxy can use same code.

Pull Request Test Coverage Report for Build 10793

12 of 24 (50.0%)  changed or added relevant lines in 7 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.2%) to 57.521%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

sharding-proxy/sharding-proxy-backend/src/main/java/org/apache/shardingsphere/shardingproxy/backend/schema/impl/ShardingSchema.java
0
3
0.0%

sharding-jdbc/sharding-jdbc-core/src/main/java/org/apache/shardingsphere/shardingjdbc/executor/AbstractStatementExecutor.java
0
9
0.0%

Totals

Change from base Build 10791:
0.2%

Covered Lines:
11720

Relevant Lines:
20375

💛  - Coveralls

source: gharchive/pull-request

repo: apache/incubator-shardingsphere

license_type: permissive

license_source: bigquery


text:
[ISSUE#1850] delete this test case, different jdk version has differe…

…nt exception message.(#1850)
// Describe your PR here; eg. Fixes #issueNo

Make sure that:

[X] You have read the contribution guidelines.
[X] You submit test cases (unit or integration tests) that back your changes.
[X] Your local test passed mvn clean install -Dmaven.javadoc.skip=true.

Codecov Report

Merging #1851 (2dac528) into master (1eb8d09) will decrease coverage by 0.39%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #1851      +/-   ##
============================================
- Coverage     66.06%   65.67%   -0.40%
+ Complexity     2559     2548      -11
============================================
  Files           489      489
  Lines         10752    10752
  Branches       1071     1071
============================================
- Hits           7103     7061      -42
- Misses         3116     3154      +38
- Partials        533      537       +4

Impacted Files
Coverage Δ

...enyu/client/tars/TarsServiceBeanPostProcessor.java
25.67% <0.00%> (-32.44%)
:arrow_down:

...ache/shenyu/plugin/grpc/cache/GrpcClientCache.java
66.66% <0.00%> (-27.78%)
:arrow_down:

...henyu/plugin/grpc/resolver/ShenyuNameResolver.java
56.84% <0.00%> (-6.32%)
:arrow_down:

...in/java/org/apache/shenyu/spi/ExtensionLoader.java
86.84% <0.00%> (-2.64%)
:arrow_down:

...henyu/plugin/httpclient/NettyHttpClientPlugin.java
57.14% <0.00%> (-2.05%)
:arrow_down:

...che/shenyu/sync/data/http/HttpSyncDataService.java
69.90% <0.00%> (-1.95%)
:arrow_down:

...elimiter/handler/RateLimiterPluginDataHandler.java
69.69% <0.00%> (-1.52%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1eb8d09...2dac528. Read the comment docs.

authors: HessTina-YuI codecov-commenter

repo: apache/incubator-shenyu

license_source: github-api


text:
Fix protocol mistakes.

Please answer these questions before submitting pull request

Why submit this pull request?

[x] Bug fix

[ ] New feature provided

[ ] Improve performance

Related issues

Bug fix

Rename a duplicate getTopNServerThroughput to getTopNApplicationThroughtput for overview page.
Rename applicationName toapplicationCode in AppServerInfo

Coverage remained the same at 20.904% when pulling a736c01a81064adfc6c4c97592ccc6a5d0b83d56 on fix/query into 1afe6c7977df6e61c5d975b72c7de7e59659a1d8 on master.

authors: coveralls wu-sheng

repo: apache/incubator-skywalking


text:
Dialog box does not close when you click OK

Make sure these boxes are checked before submitting your issue - thank you!
The error messge dialog box does not close when you click on OK.
https://github.com/apache/incubator-superset/pull/5523
@mistercrunch @betodealmeida
Expected results
After clicking OK, the dialog box should close
Actual results
It doesn't.
Steps to reproduce
Write a query with count(*), try to visualize, then click OK on the error message dialog box.

Confirmed, saw that too recently, thinking bumping libs may help

source: gharchive/issue

authors: mistercrunch timifasubaa

repo: apache/incubator-superset


text:
Improve Filter Box Control to accept Conditional Filters

Is your feature request related to a problem? Please describe.
Currently, Dashboard filters accept a list of dimensions and you can filter on values. But , for a few reports, I also want to filter based on some conditions. Let's take the example of the Sample Dashboard World Bank's Data. I wanted to see Life Expectency for Asia without the Country India.
Describe the solution you'd like
Currently, i can only select filters where value is in [some value] . I would like the filters to be more dynamic and one can build upon those instead of selecting a value.

Instead of this, i would like a representation that has the following

You can build filter controls with a specified set of dimensions but while rendering the dashboard, you can pick and select them just like filter controls.
Describe alternatives you've considered
I have considered adding a filter to the chart itself. But there are times when i just want to filter out on some values from the dashboard / just do a quick compare with different filter conditions.
Additional context
Add any other context or screenshots about the feature request here.
I saw a similar request here but it's been closed now.
https://github.com/apache/incubator-superset/issues/8194

You can create a filter based on a query in SQL-Lab, and then use it in the Dashboard.

authors: klazaj shanmukhsista


text:
[bugfix] throw "TypeError: 'NoneType'..." when save chart to dash

All changes in save_or_overwrite_slice:

fix bug
change text from "slice" to "chart"
make info localizable

Bug replication steps:

remove Admin's "can add on DashboardModelView" permission
open a chart in explore page, then click "save" -> "Add to new dashboard"
a exception is thrown

../incubator-superset/superset/views/core.py", line 1409, in save_or_overwrite_slice
    _('You don\'t have the rights to ') + _('create a ') + _('dashboard'),
TypeError: 'NoneType' object is not callable

it seems that in function save_or_overwrite_slice,  lazy_gettext's alies _ is overridden by a local variable _
def save_or_overwrite_slice
        .....
        form_data, _ = self.get_form_data()
        .....

        .....
        _('You don\'t have the rights to ') + _('create a ') + _('dashboard'),
        .....

Codecov Report

Merging #5835 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master    #5835   +/-   ##
=======================================
  Coverage   64.46%   64.46%
=======================================
  Files         422      422
  Lines       20566    20566
  Branches     2250     2250
=======================================
  Hits        13257    13257
  Misses       7182     7182
  Partials      127      127

Impacted Files
Coverage Δ

superset/views/core.py
74.91% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b210742...b5152b2. Read the comment docs.

LGTM

authors: codecov-io hitdemo mistercrunch


text:
[MINOR] fix: Allow mountPoint do not contains '/'

What changes were proposed in this pull request?

Allow mountPoint do not contains '/'
Why are the changes needed?

mountPoint is not always contains '/', such as rootfs
Does this PR introduce any user-facing change?

No
How was this patch tested?

No need.

Codecov Report

Merging #607 (c3d9235) into master (7a8cdb0) will increase coverage by 2.26%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##             master     #607      +/-   ##
============================================
+ Coverage     60.85%   63.11%   +2.26%
+ Complexity     1800     1799       -1
============================================
  Files           214      200      -14
  Lines         12387    10417    -1970
  Branches       1044     1045       +1
============================================
- Hits           7538     6575     -963
+ Misses         4444     3497     -947
+ Partials        405      345      -60

Impacted Files
Coverage Δ

...le/storage/common/DefaultStorageMediaProvider.java
51.51% <0.00%> (-1.61%)
:arrow_down:

...storage/handler/impl/DataSkippableReadHandler.java
83.78% <0.00%> (-2.71%)
:arrow_down:

...oy/kubernetes/operator/pkg/controller/util/util.go

...y/kubernetes/operator/pkg/webhook/inspector/rss.go

deploy/kubernetes/operator/pkg/webhook/manager.go

...y/kubernetes/operator/pkg/webhook/inspector/pod.go

...pkg/controller/sync/shuffleserver/shuffleserver.go

...eploy/kubernetes/operator/pkg/utils/coordinator.go

deploy/kubernetes/operator/pkg/utils/util.go

...rnetes/operator/pkg/webhook/inspector/inspector.go

... and 6 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

authors: codecov-commenter xianjingfeng

repo: apache/incubator-uniffle


text:
多页面应用，andriod报错android.os.FileUriExposedException

2018-12-20 11:29:59.102 13648-13648/com.weex.app E/Navigator: android.os.FileUriExposedException: file://assets/dist/web.js?title=%E6%A5%BC%E5%AE%87%E5%88%97%E8%A1%A8&Url=http%3A%2F%2F192.168.0.225%3A8088%2F%23%2Fbuildlist exposed beyond app through Intent.getData()
at android.os.StrictMode.onFileUriExposed(StrictMode.java:1799)
at android.net.Uri.checkFileUriExposed(Uri.java:2346)
at android.content.Intent.prepareToLeaveProcess(Intent.java:8965)
at android.content.Intent.prepareToLeaveProcess(Intent.java:8926)
at android.app.Instrumentation.execStartActivity(Instrumentation.java:1517)
at android.app.Activity.startActivityForResult(Activity.java:4225)
at android.support.v4.app.BaseFragmentActivityApi16.startActivityForResult(BaseFragmentActivityApi16.java:54)
at android.support.v4.app.FragmentActivity.startActivityForResult(FragmentActivity.java:67)
at android.app.Activity.startActivityForResult(Activity.java:4183)
at android.support.v4.app.FragmentActivity.startActivityForResult(FragmentActivity.java:720)
at android.app.Activity.startActivity(Activity.java:4522)
at android.app.Activity.startActivity(Activity.java:4490)
at com.taobao.weex.appfram.navigator.WXNavigatorModule.push(WXNavigatorModule.java:132)
at java.lang.reflect.Method.invoke(Native Method)
at com.taobao.weex.bridge.MethodInvoker.invoke(MethodInvoker.java:46)
at com.taobao.weex.bridge.NativeInvokeHelper$1.run(NativeInvokeHelper.java:48)
at com.taobao.weex.common.WXThread$SafeRunnable.run(WXThread.java:49)
at android.os.Handler.handleCallback(Handler.java:751)
at android.os.Handler.dispatchMessage(Handler.java:95)
at android.os.Looper.loop(Looper.java:154)
at android.app.ActivityThread.main(ActivityThread.java:6119)
at java.lang.reflect.Method.invoke(Native Method)
at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:886)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:776)

这个问题为什么官方没有处理啊

authors: hponiang wuzhoubo

repo: apache/incubator-weex


text:
ZEPPELIN-31 fix REST API base path in web-app

Fixes https://issues.apache.org/jira/browse/ZEPPELIN-31

Ready to merge

When i go to interpreter menu.
REST api call address was
http://localhost:8080/api/interpreter
but changed to
http://localhost:8080//api/interpreter
and getting 404

@Leemoonsoo should be good now

Triggering CI

Ready to merge

\cc @corneadoug @anthonycorbacho for review

+1

+1 as well
On Jun 11, 2015 11:18 PM, "CORNEAU Damien" notifications@github.com wrote:

+1
—
Reply to this email directly or view it on GitHub
https://github.com/apache/incubator-zeppelin/pull/30#issuecomment-111375036
.

Tested. +1

Thanks, merging then!

authors: Leemoonsoo anthonycorbacho bzz corneadoug

repo: apache/incubator-zeppelin


text:
Improve aggregation with value filter

Improve aggregation with value filter. Avoid duplicate series reader.

This PR has been moved to ClusterQueryOpt branch.

repo: apache/iotdb


text:
Improve group by month performance

Currently, when judging whether a page/chunk/point statisfies group by month filter, we get the interval that need to juege directly instead of one by one.

Coverage decreased (-0.01%) to 67.884% when pulling abec4457ef4966c8ac7c40045a30d8e428e96ef3 on groupbybug into cd69b8e51cf7c6797374d73de9d76922b49df9ac on master.


text:
JAMES-3657 Modular entity validation for webadmin-data

Why?: Adding a new entity requires to modify all the other
entity, which is error prone, and also fastidious...
These entity includes: groups, aliases, users.
How?: Write a modular validation system that all types would use.
Adding a new type would just require to add its validator.

Actually after rereading the test cases defined in the ticket, some are missing no?

No net really, there was already existing tests on this topic.

No net really, there was already existing tests on this topic.
I'm alright then :)

We will have the using UserEntityValidator for James-cli in another pr?

We will have the using UserEntityValidator for James-cli in another pr?

This is a good question!
Actually entity validation would need to make it to the backend components (user reposiotry, RRT). I do of course back up such a change. I propose to write a follow up pull request to push all this logic one level back! (I'm a bit worry about Spring injects...)

authors: Arsnael chibenwa vttranlina

repo: apache/james-project


text:
MINOR: Gradle build optimizations

Applies various build optimizations to take full advantage of Gradle's incremental build feature, and Gradle's local build caching feature. The optimizations will help to reduce build times for developers when running builds locally.
Specific optimizations:

Enable the local build cache
The local build cache avoids re-running tasks whose inputs have not changed,
even if the build output has been cleaned or if the build is executed in a
different directory.

Instruct Gradle to ignore version files when doing up-to-date checks
This can save a lot of developer time when working locally and creating a lot of commits. In particular, tests won't be re-executed simply because the commit ID changes (unless one of the other test inputs changes).

Update createVersionFile tasks support incremental builds and build caching
The version files are no longer recreated unless one of their inputs changes (the commit ID or the version property). The tasks are also marked as cacheable (the cached version can be used even on a clean build if the inputs are the same).
These tasks don't take a lot of time to run, but optimizing them shows how other tasks could be optimized if needed.

Set the root project name in settings.gradle
The root project name is used to name the build as a whole. It is used in reports and other types of artifacts. If a root project name is not set, then the containing directory's name is used as the root project name.
It is a best-practice to explicitly set the root project name. Otherwise, the root project name could change if the directory the project belongs to is different from the desired name (for example, of someone checks out the repository into a directory named differently from the default).

Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

@ijuma it looks like you review a lot of these changes.

Full disclosure: I'm an engineer that works for Gradle (on Gradle Enterprise, and I found these optimizations while using the project to test out Gradle Enterprise features.
Also, FWIW, I was able to reduce overall test execution time by more than half by using Gradle Enterprise's support for Test Distribution. This might be something worth considering at some point in the future.

One last comment: these changes should be compatible with Gradle 7.

Thanks for the PR! Looks like the build failed:

[2021-04-06T20:21:12.201Z] * What went wrong:
[2021-04-06T20:21:12.201Z] A problem occurred evaluating settings 'Kafka_kafka-pr_PR-10490'.
[2021-04-06T20:21:12.201Z] > No signature of method: org.gradle.initialization.DefaultProjectDescriptor.name() is applicable for argument types: (String) values: [kafka]
[2021-04-06T20:21:12.201Z]   Possible solutions: any(), wait(), path(), dump(), setName(java.lang.String), any(groovy.lang.Closure)

Also, have you measured a performance improvement without Gradle Enterprise?

Thanks for the PR! Looks like the build failed:

Whoops! That was silly of me. Somehow I accidentally deleted an important equals sign when getting these commits ready for submission. Should be fixed now (tested locally this time).

Also, have you measured a performance improvement without Gradle Enterprise?

For locally executed builds, the build caching can really help avoid re-running tasks with inputs that haven't changed since the last time they were executed. This can save a lot of time when working locally.  You'll observe a noticeable performance gain when running clean builds. Additionally, tests aren't executed anymore if all you do is make a commit that changes something not directly related to the tests themselves, like build logic (although if you change the test tasks, then they'll of course re-run).
On the CI-server side, these changes have little to no impact at all, unfortunately.
This is already a pretty mature build and the optimizations in this PR are relatively minor. By far, the vast majority of the build time is taken up executing tests. In particular, the tests in the core module tend to take a long time to execute, even with parallel test execution enabled.

On the CI-server side, these changes have little to no impact at all, unfortunately.

The CI build improvements will come from using the Gradle Enteprise remote build cache on CI builds to re-use outputs from previous builds. There is no remote build cache configured we cannot see these improvement.

For locally executed builds, the build caching can really help avoid re-running tasks with inputs that haven't changed since the last time they were executed. This can save a lot of time when working locally. You'll observe a noticeable performance gain when running clean builds. Additionally, tests aren't executed anymore if all you do is make a commit that changes something not directly related to the tests themselves, like build logic (although if you change the test tasks, then they'll of course re-run).

Does the clean task delete the local caches or not? If so, how would one force that in case of a bug? It would be good to update the Readme.md with this info.

Does the clean task delete the local caches or not?

It does not delete the local build cache.

If not, how would one force cache deletion in case of a bug?

It's best to address bugs like those by finding the offending task and fixing it to properly declare it's inputs and outputs (or if the issue is with a third-party plugin, to file a bug report against the plugin).
But in a pinch, you can pass --rerun-tasks to instruct Gradle to skip the cache and up-to-date checks. If a cache entry has been corrupted, this will also tell Gradle to overwrite the cache entry with the new task output.
However, these types of issues are quite rare. It is also best to avoid training users to use --rerun-tasks (as it eliminates all of the incremental build and build cache benefits).  For these reasons, I'm somewhat hesitant to update the README.

authors: ijuma jthurne runningcode

repo: apache/kafka


text:
KAFKA-15583: Enforce HWM advance only if partition is not under-min-ISR

Enforce a new rule of the HWM advance. Only advance HWM if the ISR size >= min ISR
https://issues.apache.org/jira/browse/KAFKA-15583

The failing tests are irrelevant.


text:
Small change to API doc for seekToEnd() to clarify lazy evaluation.

Small clarification to docs. Current behaviour could confuse when doing something like:
consumer.seekToEnd()
consumer.send(msg)
consumer.poll() //would return msg as seek evaluates lazily

LGTM. Thanks for the clarification :)

Small clarification to docs. Current behaviour could confuse when doing something like:
consumer.seekToEnd()
consumer.send(msg)
consumer.poll() //would return msg as seek evaluates lazily

Small clarification to docs. Current behaviour could confuse when doing something like:
consumer.seekToEnd()
consumer.send(msg)
consumer.poll() //would return msg as seek evaluates lazily

Small clarification to docs. Current behaviour could confuse when doing something like:
consumer.seekToEnd()
consumer.send(msg)
consumer.poll() //would return msg as seek evaluates lazily

Small clarification to docs. Current behaviour could confuse when doing something like:
consumer.seekToEnd()
consumer.send(msg)
consumer.poll() //would return msg as seek evaluates lazily

Small clarification to docs. Current behaviour could confuse when doing something like:
consumer.seekToEnd()
consumer.send(msg)
consumer.poll() //would return msg as seek evaluates lazily

Small clarification to docs. Current behaviour could confuse when doing something like:
consumer.seekToEnd()
consumer.send(msg)
consumer.poll() //would return msg as seek evaluates lazily

authors: b-goyal benstopford gwenshap


text:
MINOR: Fix bug in AdminClient node reassignment following connection failure

We added logic to reassign nodes in callToSend after a connection failure, but we do not handle the case when there is no node currently available to reassign the request to. This can happen when using MetadataUpdateNodeIdProvider if all of the known nodes are blacked out awaiting the retry backoff. To fix this, we need to ensure that the call is added to pendingCalls if a new node cannot be found.
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

@hachikuji Ah I forgot to read the description. I guess it will help me understand it better if we can reproduce the error. Otherwise, if the issue is hard to reproduce, I am OK with this patch as well. Please let me know whether you can fix the test and whether you would like further review by @rajinisivaram. Thanks.

@lindong28 Thanks, I think I worked out the issue. There was inconsistent behavior between NetworkClient and MockClient in the handling of leastLoadedNode. For NetworkClient, we will not return blacked out nodes that are awaiting the reconnect backoff, but we would in MockClient. Unfortunately, we had a few unrelated test cases which were erroneously depending on this difference in behavior. We probably need to spend some time cleaning up MockClient to ensure that it's behavior actually matches NetworkClient in all cases, especially since our client testing depends on it so heavily. At the moment, it's just a tangle of one-off hacks.

@lindong28 You need the changes in MockClient to reproduce the failure. You should see testUnreachableBootstrapServer hang until the test ultimately times out. The other test case was added for completeness and passes on trunk.

Merging to trunk.

authors: hachikuji lindong28 rajinisivaram


text:
HOTFIX: keep restore consumer assignment in sync & don't prematurely mark task closed

This fixes two issues which together caused the soak to crash/some test to fail occasionally.
What happened was:
In the main StreamThread loop we initialized a new task in TaskManager#checkForCompletedRestoration which includes registering, but not initializing, its changelogs. We then complete the loop and call poll, which resulted in a rebalance that revoked the newly-initialized task. In TaskManager#handleAssignment we then closed the task cleanly and go to remove the changelogs from the StoreChangelogReader only to get an IllegalStateException because the changelog partitions were not in the restore consumer's assignment (due to being uninitialized).
This by itself should^ be a recoverable error, as we catch exceptions here and retry closing the task as unclean. Of course the task actually was successfully closed (clean) so we now get an unexpected exception Illegal state CLOSED while closing active task
The fix(es) I'd propose are:

Keep the restore consumer's assignment in sync with the registered changelogs, ie the set ChangelogReader#changelogs but pause them until they are initialized
Move the StoreChangelogReader#remove call to before the task.closeClean so that the task is only marked as closed if everything was successful. We should do so regardless, as we should (attempt to) remove the changelogs even if the clean close failed and we must do unclean.

@guozhangwang @vvcephei

Ok to test.

Ran the tests locally twice: one unrelated failure in shouldWorkWithRebalance (that fix coming next) but otherwise all green. Prior to this I saw 1-2 failures per run due to the issue(s) fixed here

Why are there no new test cases for this bug in this PR?

I'll make a note to add test cases for this in the next PR

authors: ableegoldman apurvam vvcephei


text:
[KARAF-884] Generate feature dependencies

Currently, POMs containing feature dependencies (classifier "features"
and type "xml") produce features listing all the required bundles.
This patch causes feature generation to represent feature dependencies
using  elements instead.
As a side-effect, aggregate features produce a new aggregate feature
containing all the generated features.
Signed-off-by: Stephen Kitt skitt@redhat.com

R: @jbonofre

authors: jbonofre skitt

repo: apache/karaf


text:
KYLIN-4377: allow project administrator to operate hybrid model

see: https://issues.apache.org/jira/browse/KYLIN-4377

Codecov Report

Merging #1105 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #1105      +/-   ##
============================================
- Coverage     25.07%   25.05%   -0.03%
+ Complexity     6226     6224       -2
============================================
  Files          1440     1440
  Lines         87883    87883
  Branches      12291    12291
============================================
- Hits          22039    22015      -24
- Misses        63688    63703      +15
- Partials       2156     2165       +9

Impacted Files
Coverage Δ
Complexity Δ

...he/kylin/dict/lookup/cache/RocksDBLookupTable.java
72.97% <0%> (-5.41%)
6% <0%> (-1%)

...rg/apache/kylin/cube/inmemcubing/MemDiskStore.java
65.95% <0%> (-5.17%)
7% <0%> (ø)

...org/apache/kylin/rest/util/QueryRequestLimits.java
35.71% <0%> (-4.77%)
5% <0%> (-1%)

...ream/core/storage/columnar/ColumnarStoreCache.java
52.27% <0%> (-3.41%)
8% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e5b9a3...94aa4ef. Read the comment docs.

Pull Request Test Coverage Report for Build 5612

0 of 0   changed or added relevant lines in 0 files are covered.
10 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.005%) to 27.517%

Files with Coverage Reduction
New Missed Lines
%

core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java
10
75.99%

Totals

Change from base Build 5602:
-0.005%

Covered Lines:
24183

Relevant Lines:
87883

💛  - Coveralls

authors: codecov-io coveralls zhoukangcn

repo: apache/kylin


text:
KYLIN-3994: StorageCleanupJob may delete cube id data of new built segment because of cube cache in CubeManager

See: https://issues.apache.org/jira/browse/KYLIN-3994

Can one of the admins verify this patch?

Pull Request Test Coverage Report for Build 4466

3 of 5 (60.0%)  changed or added relevant lines in 4 files are covered.
2 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.003%) to 27.866%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

core-cube/src/main/java/org/apache/kylin/cube/CubeManager.java
0
2
0.0%

Files with Coverage Reduction
New Missed Lines
%

core-job/src/main/java/org/apache/kylin/job/impl/threadpool/DefaultScheduler.java
2
80.23%

Totals

Change from base Build 4453:
-0.003%

Covered Lines:
22800

Relevant Lines:
81819

💛  - Coveralls

it's fine to me

Codecov Report

Merging #633 into master will decrease coverage by <.01%.
The diff coverage is 50%.

@@             Coverage Diff              @@
##             master     #633      +/-   ##
============================================
- Coverage     25.78%   25.78%   -0.01%
- Complexity     6008     6009       +1
============================================
  Files          1382     1382
  Lines         82202    82205       +3
  Branches      11519    11519
============================================
- Hits          21198    21197       -1
- Misses        58958    58962       +4
  Partials       2046     2046

Impacted Files
Coverage Δ
Complexity Δ

...c/main/java/org/apache/kylin/cube/CubeManager.java
37.83% <0%> (-0.2%)
44 <0> (ø)

...pache/kylin/rest/job/StorageCleanJobHbaseUtil.java
49.38% <100%> (ø)
7 <0> (ø)
:arrow_down:

.../org/apache/kylin/rest/job/MetadataCleanupJob.java
66.42% <100%> (ø)
26 <0> (ø)
:arrow_down:

...a/org/apache/kylin/rest/job/StorageCleanupJob.java
65.48% <100%> (ø)
31 <0> (ø)
:arrow_down:

...rg/apache/kylin/cube/inmemcubing/MemDiskStore.java
69.3% <0%> (-0.92%)
7% <0%> (ø)

...ream/core/storage/columnar/ColumnarStoreCache.java
51.16% <0%> (+2.32%)
8% <0%> (+1%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 670c2a9...7ac7c45. Read the comment docs.

authors: ZhengshuaiPENG asfgit codecov-io coveralls lshmouse


text:
Bump Iceberg 1.6.0

:mag: Description
Test RC
Types of changes :bookmark:

[ ] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Test Plan 🧪
Behavior Without This Pull Request :coffin:
Behavior With This Pull Request :tada:
Related Unit Tests

Checklist 📝

[x] This patch was not authored or co-authored using Generative Tooling

Be nice. Be informative.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 0.00%. Comparing base (3aaa1d6) to head (0180521).
Report is 1 commits behind head on master.

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #6558   +/-   ##
======================================
  Coverage    0.00%   0.00%
======================================
  Files         677     677
  Lines       41799   41799
  Branches     5709    5709
======================================
  Misses      41799   41799

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Thanks, merged to master

repo: apache/kyuubi


text:
Flink upgrade 1.16.2 and compatible with multiple versions

Flink upgrade 1.16.2
"flink.version" defaults to "1.16.2 ". If you want to use flink1.12.2, you need to set "flink.version" to "1.12.2 "and recompile the source code

Good job

Multi-version compatibility needs to be considered

Multi-version compatibility needs to be considered

Ok, thanks for reviewing the code

cc @Alexkun

支持的多版本包括1.13.x版本吗

Sorry, 1.13 is not currently supported

authors: ChengJie1053 ly-yhq peacewong

repo: apache/linkis


text:
Ununified document addresses

I found two document addresses, what I can see directly is https://logging.apache.org/log4j/2.x/index.html, What's not easy to find is
https://logging.apache.org/log4j/2.12.x/, But I have found that the two complement each other. Would you consider merging them?
And the latter is in some ways more detailed, I prefer the latter.

@youngledo,
The /log4j/2.12.x website contains the documentation of the 2.12.x release. That release was a (very short-lived) branch with security-only fixes, that appeared in December 2021 and was discontinued on December 29th, 2021.
I am planning to remove the /log4j/2.3.x and /log4j/2.12.x websites in a couple of weeks (see this dev@logging thread), but if you wish to move some content from that page to /log4j/2.x, feel free to open a PR. There is an [Edit] button on each page of the new website, which points you to the correct AsciiDoc source document.

authors: ppkarwasz youngledo


text:
Move site back where it belongs

This is work-in-progress: trying to get the log4net site generation working properly again.

@rgoers I've moved the artifacts back where maven recognises them, but the result I get from running a command like mvn site:stage -DstagingDirectory=$HOME/log4net gives me a site where the index is ok, but a lot of the linked pages (eg releases) don't exist. I'm not sure if the problem is environmental or otherwise; since I know nothing about maven (another thing to learn!) I'm not 100% sure about where to start tracking this down, but a quick text-search within the site folder & generated area hasn't been very illuminating. I thought I'd start a PR now so that anyone with more knowledge on the tooling could help.

FWIW, the Apache Logging project generally uses "CTR " (commit - then review). So if you are comfortable with the changes being made you don't need to create a PR. Committers generally only create PRs when they really want a code review because they either a) aren't 100% sure they are doing the right thing or b) want others to be aware of some impact the commit is going to cause.

@rgoers I had 2 subsequent commits on the PR (didn't realise that you'd acted on it so quickly!) which restore the release folder in the site area, fixing all the missing artifacts that I found upon trying to build the site. Does CTR imply I should simply commit to master on apache/logging-log4net?

On Aug 26, 2020, at 8:27 PM, Davyd McColl notifications@github.com wrote:
@rgoers https://github.com/rgoers I had 2 subsequent commits on the PR (didn't realise that you'd acted on it so quickly!) which restore the release folder in the site area, fixing all the missing artifacts that I found upon trying to build the site. Does CTR imply I should simply commit to master on apache/logging-log4net?

Yes, unless you specifically want others to review it because you aren’t quite sure if it is the right way to do it, the code will cause breaking changes and you want others opinions, etc. For most things you should just commit to master. We all get commit emails and will see it.  Some of us might look at it and if we have questions we will ask.
Ralph

@rgoers cool -- but I can't push to apache/logging-log4net:
ERROR: Permission to apache/logging-log4net.git denied to fluffynuts.

Your apache userid is davydm. It needs to be linked with your GitHub user. See https://gitbox.apache.org/setup/. Apache Logging doesn't have a guide but many projects do. For example, https://cwiki.apache.org/confluence/display/OPENWHISK/Accessing+Apache+GitHub+as+a+Committer
Ralph

@rgoers I've gone through the above:

linked my apache id davydm to this github account (fluffynuts)
accepted the asf invitiation
received mail around team addition
gitbox seems to think I should be able to push:

however, I still can't push to github.com/apache/logging-log4net:
ERROR: Permission to apache/logging-log4net.git denied to fluffynuts.

I'm not sure what I'm missing, but I'm assuming I've either missed a step or done something wrong.

Thanks @rgoers I've managed to push & I've pushed new site content via svn too; getting a little stuck at point 7 of https://cwiki.apache.org/confluence/display/LOGGING/Managing+the+Logging+Services+Web+Site with respect to getting the site live (and haven't done the 2.x symlink to the new content yet as I'm at a windows machine; need to do it quick on my linux box)

I'm not sure if this belongs to the changes made in this PR, but https://logging.apache.org/log4net/ (with is the top Google result if you search for "log4net") currently leads to a directory listing.

@cremor thanks for reporting; logging sites are in a bit of a state of upheaval right now (as far as I understand). Good people are On It.

Please try it again.

FWIW, the documentation for publishing the web site is at https://cwiki.apache.org/confluence/display/LOGGING/Managing+the+Git+Hosted+Web+Site. So you would run your build to create the web site and then copy it into the Log4net site repo.

Thanks for sorting it out @rgoers. I'll try to be better prepared next time.

@rgoers Now the link https://logging.apache.org/log4net/ works, but the link which is on https://logging.apache.org, which is https://logging.apache.org/log4net/2.x/index.html (both the button on the main site and in the menu at the top), doesn't work any more 😕

Thanks. Those should be fixed now.

None of this was your fault. All these issues were related to me moving the site from the ASF CMS system to GitHub.
Ralph

On Sep 10, 2020, at 9:50 AM, Davyd McColl notifications@github.com wrote:
Thanks for sorting it out @rgoers https://github.com/rgoers. I'll try to be better prepared next time.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/apache/logging-log4net/pull/62#issuecomment-685954452, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAA5MX5JSB54TEOH4GJKN4DSFD7WFANCNFSM4QMCEMTA.

authors: cremor fluffynuts rgoers


text:
Javadocs, Sorter impls:

clarify which sorts are stable/not
link from utility methods to the primary Sorter implementations for further information
describe when InPlaceMergeSorter is useful.  Fix incorrect statement that is uses insertion sort.

As an aside, I'm dubious on the value of InPlaceMergeSorter.  If my statement in the docs I added is correct, that it's for small arrays to avoid allocating memory, then such use-cases could call TimSorter and we could enhance TimSorter to up-front recognize it's a "small" array and go directly into binarySort without allocating anything.  WDYT?  We could just do that any way.

Thanks David for bringing clarity there!
I think the quality of the in-place merge sort is to be stable, and more efficient (O(n.log(n)) on larger arrays than the binary sort or insertion sort (O(n2)).

Actually I wonder if we should always use the insertion sort on small arrays. It seems to me it is more efficient than the binary sort. Something to benchmark.

I think the quality of the in-place merge sort is to be stable, and more efficient (O(n.log(n)) on larger arrays than the binary sort or insertion sort (O(n2)).

That's not useful advise to a user because we don't offer the latter two.  We offer MSBRadixSorter, IntroSorter, InPlaceMergeSorter and TimSorter.
I'm approaching this from a user's perspective who doesn't work on sorting algorithms.  We have a number of options and they should have documentation that helps me/us decide which to used based on the situation.  The current docs and even with my minor changes are confusing.  Based on what I've found here so far, my thought-process is to choose a sorting algorithm based on this ranked list:

Use MSBRadixSorter if I have strings (includes byte strings / arrays) and don't mind a non-stable sort.
Use IntroSorter if I don't mind non-stable sort.  (however I've seen a trick by Adrien in our code somewhere to work-around the lack of stability by adding a number to the sort criteria based on the original position.)
InPlaceMergeSorter if need a stable sort and the list to sort is typically small.  (this is my assessment; could be wrong).
Use TimSorter otherwise

If my characterization is sub-optimal, lets work out what advise to give in a similar fashion to the above and put this on Sorter's class javadocs so we have one place to point users.

Your characterization makes sense to me. Note that we also have a StableMSBRadixSorter.

authors: bruno-roustant dsmiley jpountz

repo: apache/lucene


text:
Fixes for 1.2-rc2

Few fixes for upcoming 1.2-rc2

That looks good. I would consider adding this as well: https://github.com/apache/mynewt-nimble/pull/528

authors: rymanluk sjanc

repo: apache/mynewt-nimble


text:
[NIFI-2929] remove canvas element names when zoomed out and view perm…

Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:

[ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?

[ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

[ ] Has your PR been rebased against the latest commit within the target branch (typically master)?

[ ] Is your initial contribution a single, squashed commit?

For code changes:

[ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
[ ] Have you written or updated unit tests to verify your changes?
[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
[ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
[ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

[ ] Have you ensured that format looks appropriate for the output in which it is rendered?

Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
…issions are removed

Hey @scottyaslan. I think the name fields are the only ones that need to be clear out. The other fields are part of the 'details' group which is removed when zoomed out.

@mcgilman I have updated the PR based on your feedback.

Thanks @scottyaslan! This has been merged to master.

authors: mcgilman scottyaslan

repo: apache/nifi


text:
su password of nifi 1.9.2 docker images

Could anyone help!
What is the su password in the NiFi container for the NiFi docker image?
I followed the steps (https://www.nifi.rocks/apache-nifi-docker-compose-cluster/#running-a-cluster) to build up a three-containers NiFi cluster.  When I use GetFile and ListFile processors, it can not read and write the files at the local container since the permission is denied.
It is Debian Linux, NiFi version is 1.9 .  I use su  to change my role, but asked to provide the password.

Kind regards,
Raymond

Our project does not use GitHub Pull Requests to post/answer questions like this. Please contact the Apache NiFi mailing lists at dev@nifi.apache.org or users@nifi.apache.org and ask this question there. You should receive a prompt response. Thank you.


text:
NIFI-6849: On startup, NiFi should be more liberal about what it's willing to inherit from cluster

Thank you for submitting a contribution to Apache NiFi.
Please provide a short description of the PR here:
Description of PR
Enables X functionality; fixes bug NIFI-YYYY.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:

[ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?

[ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

[ ] Has your PR been rebased against the latest commit within the target branch (typically master)?

[ ] Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not squash or use --force when pushing to allow for clean monitoring of changes.

For code changes:

[ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
[ ] Have you written or updated unit tests to verify your changes?
[ ] Have you verified that the full build is successful on both JDK 8 and JDK 11?
[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
[ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
[ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

[ ] Have you ensured that format looks appropriate for the output in which it is rendered?

Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

i went through the changed files and it looked good.

I' have built this PR and spun it up with a 3 node cluster:

[x] the goal of this PR: a more liberal flow and authorization inheritence was working as expected.
[x] even though this PR affects very many files, i could not witness it to break anything. Also, it passes the unit tests.

+1 for this great feature!

Will share feedback on review/testing tomorrow (hopefully!)

and no sooner than I said that do I realize this is simply too hard to review right now and not worth holding up 1.11 over.  Moving off the 1.11 list so we can get the rest of the fixes/improvements/features out

Testing back up of users.xml and authorizations.xml with a two node cluster, stopped second node and manually edited authorizations.xml to remove a policy, then started again and got this exception:
Caused by: org.apache.nifi.controller.UninheritableFlowException: Proposed Authorizer is not inheritable by the flow controller because of Authorizer differences: Proposed Authorizations do not match current Authorizations: Proposed fingerprint is not inheritable because the current access policies is not empty.
	at org.apache.nifi.controller.StandardFlowSynchronizer.sync(StandardFlowSynchronizer.java:239)
	at org.apache.nifi.controller.FlowController.synchronize(FlowController.java:1426)
	at org.apache.nifi.persistence.StandardXMLFlowConfigurationDAO.load(StandardXMLFlowConfigurationDAO.java:89)
	at org.apache.nifi.controller.StandardFlowService.loadFromBytes(StandardFlowService.java:792)
	at org.apache.nifi.controller.StandardFlowService.loadFromConnectionResponse(StandardFlowService.java:985)
	... 5 common frames omitted

Shouldn't this have backed up the current authorizations.xml and then forcibly inherited from the cluster?
Same exception if start with everything equal and then modifying users.xml on one node.

The latest updates look. I ran through a number of tests for nheriting the flow, users/groups, and policies, as well as missing components and bundles. Everything seems to be working nicely so I am a +1. Will leave the PR open for Matt to finish reviewing.

One minor point I forgot, I get a checkstyle violation locally, not sure why it doesn't show up on GitHub Actions...
[WARNING] src/main/java/org/apache/nifi/controller/inheritance/BundleCompatibilityCheck.java:[21,8] (imports) UnusedImports: Unused import - org.apache.nifi.controller.MissingBundleException.

Thanks @markap14 for the PR! Thanks @bbende for the help reviewing. Things look good here too. +1
This has been merged to master. I resolved the unused import manually when rebasing.

authors: bbende ekovacs joewitt markap14 mcgilman


text:
[BUG] pow() nuttx libmath return wrong value

Description / Steps to reproduce the issue
Here's a small example 1:
    for (int32_t i = 0; i < 3; i++)
    {
        printf("%f", std::pow(500.f, i));
    }

And the results on xmc4800-relax with the lib math package with nuttx
       1.000000
       485165486.398179
       235385549191982000.000000

I've tried to compile with the gcc libmath, and no problem.
If a make i goes from 0 to 2 (instead of 3), my problem disapears...
Another strange issue is that this example 2 works :
        printf("%f", std::pow(500.f, 0));
        printf("%f", std::pow(500.f, 1));
        printf("%f", std::pow(500.f, 2));

In the case of example 1, I see that the pow() of libm is called. In the example 2, this function is not called. I have no idea why.
Thank you for any help understanding this issue...
On which OS does this issue occur?
[Linux]
What is the version of your OS?
Ubuntu 22
NuttX Version
12.6.0
Issue Architecture
[arm]
Issue Area
[Other]
Verification

[X] I have verified before submitting the report.

@nicolas71640 did you try: pow(500.0f, (float) i); ?
@pkarashchenko any idea?

Just did... and same result

Will need some debugging. The idea would be to check if there is FPU and if it is enabled. Like to check soft float vs hard float case.

I stepped into similar strange behavior a long time ago, but not with Nuttx and here are the steps to check that can explain the observation:

std::pow(500.f, 0) is slightly different from std::pow(500.f, i) in terms of compiler optimization. I suppose that optimization is enabled for the code in both example 1 and 2. But in example 2 the compiler calculates std::pow(500.f, 0), std::pow(500.f, 1) and std::pow(500.f, 2) and emits code that that just prints the constants. I think you can check the generated assembly to confirm.
First std::pow(500.f, i) in the loop also is calculated at compile time as i is equal to zero (known) while other two calls actually run buggy pow. Again, please check the assembly code to prove it.
pow really contains a bug that should be investigated. But the test case should either be compiled with -O0 or volatile should be added to i declaration to have consistent behavior.

@nicolas71640 could you please update description and add some steps that use configure.sh and some test config? Also add a test config that you use.
I found that such behavior is possible if Nuttx is misconfigured and just want to reproduce your case locally

Updates : (correction).
I'm still investigating. And actually, that's not link to c and c++.
The difference between c and c++ that I have seen was actually due to the used libmath. For c it was the toolchain libmath, and c++ the libmath of nuttx.
So I have the same result in c...

Updates :
I have narrowed down the issue. The culprit is the log function.
the libm of nuttx gives : log(500) = 20.000
To reproduct :
  float i = 495;
  printf("log(%f) = %f\n", i, log(i));
  i = 496;
  printf("log(%f) = %f\n", i, log(i));

Gives :
log(495.000000) = 6.272894     // GOOD
log(496.000000) = 16.000032  // WRONG !!

@nicolas71640 please try the linked PR. I hope it should help

Here's the two assembly code in c++ and c. The c works, the c++ doesn't.
C++
0c01a038 <helloxx_main>:
 c01a038:       b500            push    {lr}
 c01a03a:       b085            sub     sp, #20
 c01a03c:       9001            str     r0, [sp, #4]
 c01a03e:       9100            str     r1, [sp, #0]
 c01a040:       2301            movs    r3, #1
 c01a042:       9303            str     r3, [sp, #12]
 c01a044:       9803            ldr     r0, [sp, #12]
 c01a046:       f7fb fd79       bl      c015b3c <__aeabi_i2d>
 c01a04a:       4602            mov     r2, r0
 c01a04c:       460b            mov     r3, r1
 c01a04e:       ec43 2b11       vmov    d1, r2, r3
 c01a052:       ed9f 0b07       vldr    d0, [pc, #28]   ; c01a070 <helloxx_main+0x38>
 c01a056:       f001 fc03       bl      c01b860 <pow>
 c01a05a:       ec53 2b10       vmov    r2, r3, d0
 c01a05e:       4806            ldr     r0, [pc, #24]   ; (c01a078 <helloxx_main+0x40>)
 c01a060:       f001 f910       bl      c01b284 <printf>
 c01a064:       2300            movs    r3, #0
 c01a066:       4618            mov     r0, r3
 c01a068:       b005            add     sp, #20
 c01a06a:       f85d fb04       ldr.w   pc, [sp], #4
 c01a06e:       bf00            nop
 c01a070:       00000000        .word   0x00000000
 c01a074:       407f4000        .word   0x407f4000
 c01a078:       0c01d8c4        .word   0x0c01d8c4

C
0c01a9a0 <hello_main>:
 c01a9a0:       b500            push    {lr}
 c01a9a2:       b085            sub     sp, #20
 c01a9a4:       9001            str     r0, [sp, #4]
 c01a9a6:       9100            str     r1, [sp, #0]
 c01a9a8:       2301            movs    r3, #1
 c01a9aa:       9303            str     r3, [sp, #12]
 c01a9ac:       9803            ldr     r0, [sp, #12]
 c01a9ae:       f7fb f897       bl      c015ae0 <__aeabi_i2d>
 c01a9b2:       4602            mov     r2, r0
 c01a9b4:       460b            mov     r3, r1
 c01a9b6:       ec43 2b11       vmov    d1, r2, r3
 c01a9ba:       ed9f 0b07       vldr    d0, [pc, #28]   ; c01a9d8 <hello_main+0x38>
 c01a9be:       f000 f84f       bl      c01aa60 <pow>
 c01a9c2:       ec53 2b10       vmov    r2, r3, d0
 c01a9c6:       4806            ldr     r0, [pc, #24]   ; (c01a9e0 <hello_main+0x40>)
 c01a9c8:       f001 fccc       bl      c01c364 <printf>
 c01a9cc:       2300            movs    r3, #0
 c01a9ce:       4618            mov     r0, r3
 c01a9d0:       b005            add     sp, #20
 c01a9d2:       f85d fb04       ldr.w   pc, [sp], #4
 c01a9d6:       bf00            nop
 c01a9d8:       00000000        .word   0x00000000
 c01a9dc:       407f4000        .word   0x407f4000
 c01a9e0:       0c01e8b8        .word   0x0c01e8b8

I do not see a difference in assembly here. However in assembly from example
  int32_t i = 1;
  printf("%f\n", pow(500.f, 1));
  printf("%f\n", pow(500.f, i));

You can see that two calls of printf are emitted, but there is only one call of pow. Compiler injects precalculated value instead of pow(500.f, 1).

@pkarashchenko  Thank you for your help, but it doesn't help. Still have the log(496.0) = 16.0000....

@pkarashchenko  Thank you for your help, but it doesn't help. Still have the log(496.0) = 16.0000....

Strange, as I had the repro rate as you described and it was fixed by this change. Maybe there is something else. I will take a closer look.
Also your message that C works and C++ does not work is something I can't fully understand. Could you please triple check this?

@nicolas71640 can you increase LOG_MAX_ITER value to 50 (or 100) and check if that gives any positive effect?

I'm having other change under test. Seems my previous fix is wrong

@nicolas71640 please check it new change works for you. At least my experiments show positive dynamic in particular cases including your example

@pkarashchenko  Just checked your PR, it works indeed ! Thanks !

authors: acassis nicolas71640 pkarashchenko

repo: apache/nuttx


text:
VirtIO/Vhost Drivers: bug fix and new feature support

Summary

virtio devices: update virtqueue operate buffer add lock API

1. Use the virtqueue_xxx_lock() api;
2. Add spinlock for some virtio and vhost drivers that do not
   use spinlock to protect the virtqueues;

virtio/virtio-net: add spinlock for the virtqueue

virtqueues are used in irq and thread, so add spinlock to protect
them.

virtio/virtio-net: calculate the correct buffer number

Avoid exceed the virtqueue length limit when adding buffer to the
virtqueue.

virtio-rpmb.c: add spin lock for virtqueue add/get buffer

Virtqueeus are used in both user thread and interrupt, so add spinlock
to proetect them.

virtio-serial.c: add spin lock for virtqueue add/get buffer

Virtqueeus are used in both user thread and interrupt, so add spinlock
to proetect them.

virtio-blk.c: add spin lock to fix get/add virtqueue buffer at the same time err

Virtqueues are used in both user thread and interrupt, so add spinlock to protect
them.

virtio-blk.c: change virtio blk req and resp to local variables

So we can remove the mutex lock to improve the virtio-block driver
performance

virtio-rng.c: add spin lock to fix get/add virtqueue buffer at the same time err

the virtqueue should be protected by the spinlock, because the virtqueues are used
both in worker and interrupt.

virtio-blk: add VIRTIO_BLK_F_BLK_SIZE feature

Support configure the virtio block device block size to other value
(default value is 512)

virtio-blk: add VIRTIO_BLK_F_RO feature

When feature VIRTIO_BLK_F_RO is set, virtio-blk only support read
operation.

virtio-blk: add VIRTIO_BLK_F_FLUSH features

Should support the flush command only when virtio device support
feature VIRTIO_BLK_F_FLUSH

virtio/virtio-rng: make virtio-rng work for remoteproc transport layer

For remoteproc transport layer, the virtio drivers can not use the malloced
memory from the default system heap to communicate with the virtio devices,
the buffers placed in virtqueue should be in the share memory region
(mallcoed virtio_alloc_buf()).

virtio-serial: support custom the virtio serial device name

By setting config CONFIG_DRIVERS_VIRTIO_SERIAL_NAME to "ttyXX0;ttyXX1;..."
to customize the virtio serial name.

For example:
If CONFIG_DRIVERS_VIRTIO_SERIAL_NAME="ttyBT;ttyTest0;ttyTest1",
virtio-serial will register three uart devices with names:
"/dev/ttyBT", "/dev/ttyTest0", "/dev/ttyTest1" to the VFS.

nsh> ls dev
/dev:
 console
 null
 telnet
 ttyBT
 ttyS0
 ttyTest0
 ttyTest1
 zero

virtio-mmio: add secure virtio mmio device register api

In secure state, call virtio_register_mmio_device_secure() to
register the secure virtio mmio device;
In non-secure state, call virtio_register_mmio_device() to
register the non-secure virtio mmio device;
Board should ensure not mixed use the secure and non-seucre mmio
device.

audio:add getlatency for virtio snd driver

add getlatency in virtio snd driver

Impact
All the virtio and vhost drivers
Testing
qemu armv7a and armv8a

[Experimental Bot, please feedback here]
This PR seems to introduce significant changes to various virtio drivers in NuttX, primarily focusing on:

Concurrency Control:  Many changes address thread safety by introducing spinlocks to protect virtqueue operations that were previously susceptible to race conditions between interrupts and user threads.
Feature Additions: The PR adds support for block size configuration, read-only mode, and flush commands in the virtio-blk driver. It also introduces custom device naming for virtio-serial.
Security Enhancements: Secure registration for virtio-mmio devices is added.
Performance Improvements: The virtio-blk driver receives optimizations through the removal of unnecessary mutex locks.
Remoteproc Support: The virtio-rng driver is adapted to function with the remoteproc transport layer, utilizing shared memory for communication.

However, the provided information lacks crucial details to determine if it fully meets NuttX's requirements:

Insufficient Summary: The summary provides a bullet list of changes but lacks a concise explanation of the overall motivation and impact.  What specific problems or limitations does this PR solve?
Vague Impact Description: Stating "All the virtio and vhost drivers" is too general. Be specific about which drivers are affected and how users might be impacted. Will any existing applications or configurations break?
Missing Documentation Impact: The PR makes many changes, including new features. Does this PR include updates to the documentation to reflect these changes?
Incomplete Testing Information:

The testing information lacks details about the specific configurations used (both host and target).
The provided "testing logs" are placeholders. Include actual relevant log snippets demonstrating the issue before the change and the correct behavior after the change.

Recommendations:

Expand the Summary:  Provide a concise overview of the PR's purpose, the problems it solves, and the overall benefits.
Detailed Impact Assessment: Specify the affected drivers, potential user impact (breaking changes, configuration updates), and any compatibility concerns (backward/forward).
Documentation:  Confirm if documentation updates are necessary and whether they are included in the PR.
Comprehensive Testing: Provide detailed information about the testing environment (host OS, compiler, target architecture, boards, configurations) and include relevant log excerpts showing the issue before and the fix after the changes.

By addressing these points, the PR will better adhere to NuttX's requirements and facilitate a smoother review process.

authors: CV-Bowen nuttxpr


text:
arm64/qemu: Add 9pfs configuration

Note: Please adhere to Contributing Guidelines.
Summary
arm64/qemu: Add 9pfs configuration
9pfs is not enabled in any current configuration
Impact
None
Testing
Convenient for qemu debugging and adding ci check
We can learn to use the following command to mount 9pfs on qemu64

    qemu-system-aarch64 -cpu max -nographic \
            -machine virt,virtualization=on,gic-version=3,mte=on \
            -fsdev local,security_model=none,id=fsdev0,path=/xxxx -device virtio-9p-device,id=fs0,fsdev=fsdev0,mount_tag=host \
            -chardev stdio,id=con,mux=on, -serial chardev:con \
            -mon chardev=con,mode=readline  -kernel ./nuttx

    mkdir mnt
    mount -t v9fs -o trans=virtio,tag=host mnt

[Experimental Bot, please feedback here]
No, this PR does not fully meet the NuttX requirements.  While it provides a basic summary and mentions testing, it lacks crucial details.
Here's a breakdown of what's missing:

Summary:

Lacks a clear explanation of why adding 9pfs is necessary.  What problem does it solve? What benefit does it provide?  Is it for debugging, development, or a specific feature?
"9pfs is not enabled in any current configuration" isn't a justification, it's an observation.
How does the change work?  Does it modify the configuration system? Add Kconfig options? Patch existing drivers?  Be specific.
Missing related issue references (if any).

Impact:

Claiming "None" is unlikely.  At a minimum, this adds a new configuration option which impacts the build system (more configurations available).  Consider other potential impacts, such as memory usage, dependencies, and potential conflicts with other filesystems.

Testing:

The provided "testing" is an example of how to use the feature, not a demonstration that the feature works.
Missing build host details (OS, compiler version, etc.)
Missing target details (specific board configuration used within qemu).
Critically missing:  Logs from before and after the change.  Show that something changed as a result of this PR. For instance, show that 9pfs was not available before and is available after.  Demonstrate mounting and using the filesystem.

In short: The PR needs to provide significantly more detail to demonstrate the value and correctness of the change.  It should show what changed, why it changed, how it was tested, and the overall impact on the system.

authors: W-M-R nuttxpr


text:
arch/risc-v/src/mpfs/mpfs_ddr.c: Correct erroneous register addresses…

… in DDR training
Writes to MPFS_CFG_DDR_SGMII_PHY_EXPERT_DFI_STATUS_OVERRIDE register were not done properly. Use correct address for writes.
Summary
This is a bug found in QEMU testing. It will most probably have some consequences on real HW, as it is really writing to wrong addresses (outside of register area even). And of course, the settings that it is trying to set are not affected.
Impact
No functional impact other than may solve random stability issues
Testing
Tested on several custom MPFS based boards

This is a good catch! Putreg32 is dangerous at times.

authors: eenurkka jlaitine


text:
Move out standalone server tests to a new Travis profile

Currently the system test profile time is hovering around 50 mins. This PR moves out the standalo ne test to a new profile
Related issue and scope

[ ] I opened an issue to propose and discuss this change (#????)

My changes affect the following components

[ ] API
[ ] Controller
[ ] Message Bus (e.g., Kafka)
[ ] Loadbalancer
[ ] Invoker
[ ] Intrinsic actions (e.g., sequences, conductors)
[ ] Data stores (e.g., CouchDB)
[ ] Tests
[ ] Deployment
[ ] CLI
[ ] General tooling
[ ] Documentation

Types of changes

[ ] Bug fix (generally a non-breaking change which closes an issue).
[ ] Enhancement or new feature (adds new functionality).
[ ] Breaking change (a bug fix or enhancement which changes existing behavior).

Checklist:

[ ] I signed an Apache CLA.
[ ] I reviewed the style guides and followed the recommendations (Travis CI will check :).
[ ] I added tests to cover my changes.
[ ] My changes require further changes to the documentation.
[ ] I updated the documentation where necessary.

Codecov Report

Merging #4657 into master will decrease coverage by 4.69%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master    #4657     +/-   ##
=========================================
- Coverage   83.12%   78.43%   -4.7%
=========================================
  Files         184      184
  Lines        8438     8438
  Branches      591      591
=========================================
- Hits         7014     6618    -396
- Misses       1424     1820    +396

Impacted Files
Coverage Δ

...core/database/cosmosdb/RxObservableImplicits.scala
0% <0%> (-100%)
:arrow_down:

...ore/database/cosmosdb/cache/CacheInvalidator.scala
0% <0%> (-100%)
:arrow_down:

...core/database/cosmosdb/CosmosDBArtifactStore.scala
0% <0%> (-96.17%)
:arrow_down:

...tabase/cosmosdb/cache/CacheInvalidatorConfig.scala
0% <0%> (-94.74%)
:arrow_down:

...sk/core/database/cosmosdb/CosmosDBViewMapper.scala
0% <0%> (-92.6%)
:arrow_down:

...e/database/cosmosdb/cache/ChangeFeedListener.scala
0% <0%> (-86.67%)
:arrow_down:

...e/database/cosmosdb/cache/KafkaEventProducer.scala
0% <0%> (-76.48%)
:arrow_down:

...whisk/core/database/cosmosdb/CosmosDBSupport.scala
0% <0%> (-74.08%)
:arrow_down:

...a/org/apache/openwhisk/common/ExecutorCloser.scala
0% <0%> (-66.67%)
:arrow_down:

...abase/cosmosdb/CosmosDBArtifactStoreProvider.scala
7.69% <0%> (-50%)
:arrow_down:

... and 29 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f9a780...2b31f90. Read the comment docs.

authors: chetanmeh codecov-io

repo: apache/openwhisk


text:
HDDS-11325. Intermittent failure in TestBlockOutputStreamWithFailures#testContainerClose

What changes were proposed in this pull request?
HDDS-11325. Intermittent failure in TestBlockOutputStreamWithFailures#testContainerClose
Please describe your PR in detail:
The assertion assumes the buffer pool is allocated 4 buffers.
After HDDS-9844, the block output stream buffer allocation becomes asynchronous and it's possible to allocate fewer buffers than before, because some response already come back and the associated buffer can be reused.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-11325
How was this patch tested?
Unit test change only.

Cool bean! Running it now.

Here's the test run 10x10 without failure
https://github.com/jojochuang/ozone/actions/runs/10467209337

Thanks @duongkame merged.

I'm trying to assess the current health of the master branch before bring it in to our feature branch and I'm confused by this change:

The Jira title says this is a fix for TestBlockOutputStreamWithFailures#testContainerClose
The code change is a fix for TestBlockOutputStream#testWriteMoreThanMaxFlushSize
The flaky annotation was not removed from TestBlockOutputStream#testWriteMoreThanMaxFlushSize. I'm not sure if that means it was run in the test split or not.

So is this PR supposed to fix failues in TestBlockOutputStream#testWriteMoreThanMaxFlushSize, TestBlockOutputStreamWithFailures#testContainerClose, or both?

it's supposed to fix both. TestBlockOutputStreamWithFailures#testContainerClose calls TestBlockOutputStream#testWriteMoreThanMaxFlushSize

TestBlockOutputStreamWithFailures#testContainerClose calls TestBlockOutputStream#testWriteMoreThanMaxFlushSize

Intellij shows no callers of TestBlockOutputStream#testWriteMoreThanMaxFlushSize other than the test annotation. TestBlockOutputStreamWithFailures#testContainerClose calls TestBlockOutputStreamWithFailures#testWriteMoreThanMaxFlushSize which is a different private method in TestBlockOutputStreamWithFailures. I'm looking at recent master fb43023f79fb096dbd1714feeae4ddd411605373
Flaky annotations on both tests mentioned in my original comment are also still present and now pointing to a resolved Jira so it is still unclear what was fixed here.

Aaah. ok I should reopen and redo it again.

repo: apache/ozone


text:
Parquet Travis CI jobs to be turned off February 15th

Greetings Parquet PMC,
Infrastructure has reached out to you regarding the Travis CI Open Source policy changes, and the resulting need for Apache projects to migrate away from using Travis.
So far, we have received no response from your PMC.
On February 15th, we will begin the final phase of this migration, turning off Travis builds in order to bring our Travis usage down to 0.
We have found the following repositories mention or make use of .travis.yml files:

parquet-mr.git

parquet-cpp.git
You must immediately move to migrate your builds from Travis. If you do not, you will soon be unable to do builds that now rely on Travis.
Many projects have moved to using GitHub Actions, and migrating to GHA is quite straightforward. Other projects use Jenkins providing ARM support, with nodes using the arm label
If you are unsure how to proceed, I would be happy to explain your next steps.
Please at least respond to acknowledge the need to migrate away from Travis, and to tell us your current plans.
Thank you!

Reporter: Xinli Shang / @shangxinli
Note: This issue was originally created as PARQUET-2233. Please see the migration documentation for further details.

Xinli Shang / @shangxinli:
In this Issue, we are going to migrate parquet-mr.git and parquet-format.git.
The hard deadline is 2/15/2023.
More information can be found https://cwiki.apache.org/confluence/display/INFRA/Travis+Migrations. We will see if we can migrate to Action.

Gang Wu / @wgtmac:
I see there is a comment in the travis yaml file saying that the blocker is missing AMD64 support: https://github.com/apache/parquet-mr/blob/master/.travis.yml#L18
I think apache/arrow has provided an example to use AMD64 on Github Action: https://github.com/apache/arrow/blob/master/.github/workflows/java.yml
[~shangx@uber.com] Not sure if we can do similar thing.

Jiashen Zhang / @zhangjiashen:
[~shangx@uber.com] for parquet-mr, I found we already have a workflow that is working  and doing same thing as Travis except running on different arch. Github Action probably doesn't provide arm64 and I am seeing this task is making progress. Do we need build and pass tests on different arch? for parquet-format, travis.yml doesn't exist and it is runing with Action already.

Xinli Shang / @shangxinli:
Were you able to log in?

Jiashen Zhang / @zhangjiashen:
 [~shangx@uber.com] I don't have permissions to https://cwiki.apache.org/confluence/display/INFRA/Travis+Migrations. are you able to grant access for me, my email is jiashenzzzzz@gmail.com ?

Xinli Shang / @shangxinli:
[~Jiashen Zhang]Please have a look and we can discuss if there are still blocking issues.

repo: apache/parquet-java


text:
PARQUET-34: implement not() for Contains predicate

This should be the final subtask for the Contains() predicate work. It adds support for logical inversion -- not(contains(...)).
Also, it fixes a small bug with the composition of mixed Contains predicates.
Make sure you have checked all steps below.
Issue

[x] My PR addresses the following GitHub issues and references
them in the PR title. For example, "GH-1234: My Parquet PR"

https://issues.apache.org/jira/browse/PARQUET-34 (should I make a new Github issue for this?)
In case you are adding a dependency, check if the license complies with
the ASF 3rd Party License Policy.

Tests

[x] My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

[x] My commits all reference GitHub issues in their subject lines. In addition, my commits follow the guidelines
from "How to write a good git commit message":

Subject is separated from body by a blank line
Subject is limited to 50 characters (not including GitHub issue reference)
Subject does not end with a period
Subject uses the imperative mood ("add", not "adding")
Body wraps at 72 characters
Body explains "what" and "why", not "how"

Style

[ ] My contribution adheres to the code style guidelines and Spotless passes.

To apply the necessary changes, run mvn spotless:apply -Pvector-plugins

Documentation

[ ] In case of new functionality, my PR adds documentation that describes how to use it.

All the public functions and the classes in the PR contain Javadoc that explain what it does

@gszadovszky Do you want to take a look?

Merged. Thanks @clairemcginty and @gszadovszky!

authors: clairemcginty wgtmac


text:
update some JavaDoc in Font-table classes

the JavaDoc fixes are preparation for some bug-hunt wrt OpenType-font.

Thanks, I applied your changes in the trunk and in 3.0 with some small modifications: only one IOException in the javadoc; some grammar changes. If I'm right about these, then it proves you were not using an AI, which is a good thing.

authors: DvonHolten THausherr

repo: apache/pdfbox


text:
in CI, don't specify full scala version

makes CI maintenance easier
the sbt files have the full scala versions specified

looks like the build needs full scala versions

repo: apache/pekko-grpc


text:
Add logs indicating the star-tree config diff to understand the rebuild purpose

This PR prints the StarTreeV2BuilderConfig for existing star-trees on the segment and the incoming star-trees from the updated table config.
This will help to understand why certain star-trees were rebuild during segment reload or server restart.

Codecov Report
Attention: Patch coverage is 0% with 11 lines in your changes missing coverage. Please review.

Project coverage is 0.00%. Comparing base (59551e4) to head (276a6df).
Report is 764 commits behind head on master.

Files
Patch %
Lines

...ocal/startree/v2/builder/MultipleTreesBuilder.java
0.00%
11 Missing :warning:

:exclamation:  There is a different number of reports uploaded between BASE (59551e4) and HEAD (276a6df). Click for more details.
HEAD has 53 uploads less than BASE

Flag
BASE (59551e4)
HEAD (276a6df)

integration
7
1

integration2
3
1

temurin
12
1

java-21
7
1

skip-bytebuffers-true
3
1

skip-bytebuffers-false
7
0

unittests
5
0

unittests1
2
0

java-11
5
0

unittests2
3
0

integration1
2
0

custom-integration1
2
0

Additional details and impacted files
@@              Coverage Diff              @@
##             master   #13627       +/-   ##
=============================================
- Coverage     61.75%    0.00%   -61.76%
=============================================
  Files          2436     2480       +44
  Lines        133233   137045     +3812
  Branches      20636    21308      +672
=============================================
- Hits          82274        0    -82274
- Misses        44911   137045    +92134
+ Partials       6048        0     -6048

Flag
Coverage Δ

custom-integration1
?

integration
0.00% <0.00%> (-0.01%)
:arrow_down:

integration1
?

integration2
0.00% <0.00%> (ø)

java-11
?

java-21
0.00% <0.00%> (-61.63%)
:arrow_down:

skip-bytebuffers-false
?

skip-bytebuffers-true
0.00% <0.00%> (-27.73%)
:arrow_down:

temurin
0.00% <0.00%> (-61.76%)
:arrow_down:

unittests
?

unittests1
?

unittests2
?

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

repo: apache/pinot


text:
Expose msg length info to metadata

feature
Stream message length is an important metadata information as its timestamp. Expose this info to metadata to make it easier extracted through transform functions.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 0.00%. Comparing base (59551e4) to head (adb7e51).
Report is 1490 commits behind head on master.

:exclamation:  There is a different number of reports uploaded between BASE (59551e4) and HEAD (adb7e51). Click for more details.
HEAD has 48 uploads less than BASE

Flag
BASE (59551e4)
HEAD (adb7e51)

integration
7
2

integration2
3
2

temurin
12
2

java-21
7
2

skip-bytebuffers-true
3
1

skip-bytebuffers-false
7
1

unittests
5
0

unittests1
2
0

java-11
5
0

unittests2
3
0

integration1
2
0

custom-integration1
2
0

Additional details and impacted files
@@              Coverage Diff              @@
##             master   #14688       +/-   ##
=============================================
- Coverage     61.75%    0.00%   -61.76%
=============================================
  Files          2436        3     -2433
  Lines        133233        6   -133227
  Branches      20636        0    -20636
=============================================
- Hits          82274        0    -82274
+ Misses        44911        6    -44905
+ Partials       6048        0     -6048

Flag
Coverage Δ

custom-integration1
?

integration
0.00% <ø> (-0.01%)
:arrow_down:

integration1
?

integration2
0.00% <ø> (ø)

java-11
?

java-21
0.00% <ø> (-61.63%)
:arrow_down:

skip-bytebuffers-false
0.00% <ø> (-61.75%)
:arrow_down:

skip-bytebuffers-true
0.00% <ø> (-27.73%)
:arrow_down:

temurin
0.00% <ø> (-61.76%)
:arrow_down:

unittests
?

unittests1
?

unittests2
?

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


text:
delete all related minion task metadata when deleting a table

Delete the ZNode MINION_TASK_METADATA/${tableName} and its descendants when deleting a table, so that we don't need to explicitly delete each MINION_TASK_METADATA/${tableName}/${taskType} separately.

Codecov Report

Merging #9339 (71bb19f) into master (0f4bcfc) will decrease coverage by 2.65%.
The diff coverage is 71.42%.

@@             Coverage Diff              @@
##             master    #9339      +/-   ##
============================================
- Coverage     69.80%   67.15%   -2.66%
- Complexity     4777     4865      +88
============================================
  Files          1875     1394     -481
  Lines         99860    72341   -27519
  Branches      15194    11585    -3609
============================================
- Hits          69706    48577   -21129
+ Misses        25231    20246    -4985
+ Partials       4923     3518    -1405

Flag
Coverage Δ

integration1
?

integration2
?

unittests1
67.15% <71.42%> (+0.05%)
:arrow_up:

unittests2
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...e/pinot/common/minion/MinionTaskMetadataUtils.java
90.90% <50.00%> (-5.65%)
:arrow_down:

...ache/pinot/common/metadata/ZKMetadataProvider.java
15.64% <100.00%> (-51.78%)
:arrow_down:

...he/pinot/common/utils/helix/FakePropertyStore.java
58.33% <100.00%> (+1.81%)
:arrow_up:

...va/org/apache/pinot/core/routing/RoutingTable.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...va/org/apache/pinot/common/config/NettyConfig.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...a/org/apache/pinot/common/metrics/MinionMeter.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...g/apache/pinot/common/metrics/ControllerMeter.java
0.00% <0.00%> (-100.00%)
:arrow_down:

.../apache/pinot/common/metrics/BrokerQueryPhase.java
0.00% <0.00%> (-100.00%)
:arrow_down:

.../apache/pinot/common/metrics/MinionQueryPhase.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...ache/pinot/server/access/AccessControlFactory.java
0.00% <0.00%> (-100.00%)
:arrow_down:

... and 726 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jackjlli thanks for reviewing the code. I made some more changes to clean up some redundant. Please help to review the code again when you get some time. Thanks!

authors: codecov-commenter zhtaoxiang


text:
Can we provide support for mdc

Is your enhancement request related to a problem? Please describe.
If we pass a tracing id in message header, is it possible to retrieve this info and put it into mdc, then all of log will see this id to solve some problems
Describe the solution you'd like
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

It‘s not the duty of pulsar, you can do it by APM systems.

https://medium.com/asyncparadigm/logging-in-a-multithreaded-environment-and-with-completablefuture-construct-using-mdc-1c34c691cef0
maybe we can use this method to track one message flow

Making messages traceable is critical when all processing stages are asynchronous, and it would be even better to add metrics and statistics about cost time in each stage.

Did you try with a Interceptor that sets the MDC while receiving a message?

authors: RayneHwang eolivelli leizhiyuan tjiuming

repo: apache/pulsar