text:
Set Breakpoint/Clear Breakpoint disabled on context menu

only activated when debugger is active.  also pls file debugger issues under gide :)

authors: rcoreilly rohrlich

repo: goki/gi


text:
Native A2HS updates

:tada: This has been pushed live to https://developers.google.com/web/

source: gharchive/pull-request

authors: WebFundBot petele

repo: google/WebFundamentals

license_type: permissive

license_source: bigquery


text:
Adds Alpha dropout

Hi @vballoli, thanks for the contribution! I've never heard of Alpha dropout personally, can you share more about where it's used? We'd like to be careful to merge new functionality into Flax core unless we're sure that the Flax core team can adequately maintain the code. I know in case your PR is small but we should still think carefully because it's easy to accidentally accumulate maintenance burden without noticing.
Generally, it's best to clearly describe the purpose of a PR, in this case it's hard to judge.

Hi, sorry for the really late reply! There aren't many use cases per se, but i thought it'd be good to have a non-random dropout as a feature. But I do agree with you, regarding the maintenance and new functionality. If this isn't a good enough contribution, I'll gladly close this PR.
On a side note, is there a dedicated list of core features required to better help contributions ? I'd really love if there is one to streamline new additions from keen contributors like me!

Hi @vballoli -- yeah, probably at this point best to close this PR, but if you put your code on your own GitHub repository we are happy to link to it.
Thanks for asking about contributing!
We don't yet have a good list of needed core features, partly because we are in the process of a major API change (initial discussion in #208, though the concrete proposal at the moment has diverged a bit from the exact details there).
After that point, we will try to find time to better organize our thoughts for where the ecosystem is headed and will be more open about possible contributions.

authors: avital vballoli

repo: google/flax


text:
Add draft for mock http client for unittesting

Thanks, @migueleliasweb .
Before doing a full code review, let's please get all the tests passing.
It is currently stuck on:
Run go vet ./...
# github.com/google/go-github/v37/mock
vet: mock/client.go:62:20: NopCloser not declared by package io
Error: Process completed with exit code 2.

Thanks, @migueleliasweb .
Before doing a full code review, let's please get all the tests passing.
It is currently stuck on:
Run go vet ./...
# github.com/google/go-github/v37/mock
vet: mock/client.go:62:20: NopCloser not declared by package io
Error: Process completed with exit code 2.

This is due to the differences in golang 1.16. I changed to use the ioutil package instead.

Now the error is:
--- FAIL: TestMockClient (0.00s)
panic: runtime error: index out of range [0] with length 0 [recovered]
	panic: runtime error: index out of range [0] with length 0

goroutine 6 [running]:
testing.tRunner.func1.2(0x8ce040, 0xc00001e570)
	/opt/hostedtoolcache/go/1.16.5/x64/src/testing/testing.go:1143 +0x49f
testing.tRunner.func1(0xc000001800)
	/opt/hostedtoolcache/go/1.16.5/x64/src/testing/testing.go:1146 +0x695
panic(0x8ce040, 0xc00001e570)
	/opt/hostedtoolcache/go/1.16.5/x64/src/runtime/panic.go:971 +0x499
github.com/google/go-github/v37/mock.(*MockRoundTripper).RoundTrip(0xc000010290, 0xc000146600, 0x0, 0x0, 0x0)
	/home/runner/work/go-github/go-github/mock/client.go:52 +0x5c5
net/http.send(0xc000146600, 0x971340, 0xc000010290, 0x0, 0x0, 0x0, 0x0, 0x0, 0xc0000102b0, 0xc00016b508)
	/opt/hostedtoolcache/go/1.16.5/x64/src/net/http/client.go:251 +0x6db
net/http.(*Client).send(0xc00006d5f0, 0xc000146600, 0x0, 0x0, 0x0, 0xc0000102b0, 0x0, 0x1, 0x730000004a82e2)
	/opt/hostedtoolcache/go/1.16.5/x64/src/net/http/client.go:175 +0x1d6
net/http.(*Client).do(0xc00006d5f0, 0xc000146600, 0x0, 0x0, 0x0)
	/opt/hostedtoolcache/go/1.16.5/x64/src/net/http/client.go:717 +0x2cc

Now the error is:
--- FAIL: TestMockClient (0.00s)
panic: runtime error: index out of range [0] with length 0 [recovered]
	panic: runtime error: index out of range [0] with length 0

goroutine 6 [running]:
testing.tRunner.func1.2(0x8ce040, 0xc00001e570)
	/opt/hostedtoolcache/go/1.16.5/x64/src/testing/testing.go:1143 +0x49f
testing.tRunner.func1(0xc000001800)
	/opt/hostedtoolcache/go/1.16.5/x64/src/testing/testing.go:1146 +0x695
panic(0x8ce040, 0xc00001e570)
	/opt/hostedtoolcache/go/1.16.5/x64/src/runtime/panic.go:971 +0x499
github.com/google/go-github/v37/mock.(*MockRoundTripper).RoundTrip(0xc000010290, 0xc000146600, 0x0, 0x0, 0x0)
	/home/runner/work/go-github/go-github/mock/client.go:52 +0x5c5
net/http.send(0xc000146600, 0x971340, 0xc000010290, 0x0, 0x0, 0x0, 0x0, 0x0, 0xc0000102b0, 0xc00016b508)
	/opt/hostedtoolcache/go/1.16.5/x64/src/net/http/client.go:251 +0x6db
net/http.(*Client).send(0xc00006d5f0, 0xc000146600, 0x0, 0x0, 0x0, 0xc0000102b0, 0x0, 0x1, 0x730000004a82e2)
	/opt/hostedtoolcache/go/1.16.5/x64/src/net/http/client.go:175 +0x1d6
net/http.(*Client).do(0xc00006d5f0, 0xc000146600, 0x0, 0x0, 0x0)
	/opt/hostedtoolcache/go/1.16.5/x64/src/net/http/client.go:717 +0x2cc

For some reason this seems to be a flakey test :thinking: It passes most times but eventually fails. I'm troubleshooting....

The tests should pass now :crossed_fingers: . Ping @gmlewis :bell: .

OK, thanks, @migueleliasweb .
I have some big concerns about this approach...  especially from a maintenance perspective.

to support the full library, each endpoint will need to be (manually most likely) added and the resulting size is going to be huge
this is driven with regexps which are challenging to always get right (and not interfere with each other)

Before doing a full code review (where I would suggest that headers be added and Marshal should have a single l, for example), I would like to hear what @gauntface and @willnorris think about this approach.

OK, thanks, @migueleliasweb .
I have some big concerns about this approach... especially from a maintenance perspective.

to support the full library, each endpoint will need to be (manually most likely) added and the resulting size is going to be huge
this is driven with regexps which are challenging to always get right (and not interfere with each other)

Before doing a full code review (where I would suggest that headers be added and Marshal should have a single l, for example), I would like to hear what @gauntface and @willnorris think about this approach.

Damn it, got Marshal wrong. I always spell it the wrong way. Second language problems, sry.
Yeah,I'm afraid you're not wrong about the regexps.
I was trying to come up with another way to maybe generate the code to match the requests but I ended up trying this one first. I thought of two other ways:

Try to use runtime.CallersFrames inside the custom RoundTripper to determine the last call made in the go-github code thus finding the caller function in the SDK. With this approach, the matcher code could be something much more clear like a string UsersService.Get instead of the somewhat ugly regexps.
Add a header to the request and match the request to that inside the RoundTripper to make it easier to distinguish between calls

I just wrote a poc with the runtime frames. The API looks much cleaner without the regexps and I reckon it would be doable to auto generate all endpoints in this case. Have a look: https://github.com/migueleliasweb/go-github/compare/mock-transport...migueleliasweb:mock-transport-pc-frames?expand=1

I just wrote a poc with the runtime frames. The API looks much cleaner without the regexps and I reckon it would be doable to auto generate all endpoints in this case.
Have a look: https://github.com/migueleliasweb/go-github/blob/mock-transport-pc-frames/mock/client.go

Ah, wow... that is quite intriguing, @migueleliasweb !
I'm guessing that the GitHub API call would be closer to the "recent" end of the call stack as opposed to the "oldest" end of the call stack...  so it might make the most sense (from a performance perspective) to search for the call from the end to the beginning... actually maybe you are already doing that... if so, great.
I'm not too concerned about the performance implications of the endpoint search... I think this would be much easier to support than the other solution... especially if the critical list of methods that users would use are auto-generated.
Overall, I like this approach a lot...  I think you are on to something big here!

(just some random thoughts...)
The use of caller frames to match the intercepted request is certainly an interesting approach, and one I probably wouldn't have considered.  But I think it's a bit more rigid in tying the test to the method that made the http request, rather than what the request itself is.
This is very close to being a really interesting, generic, standalone approach to intercepting and mocking outbound http requests.  If that were the goal (to make this reusable beyond just go-github), then I wonder if the original URL matching approach might be more flexible.  I also wonder if some of the regex logic could be made safer (or at least more maintainable) by using some of the path parsing and matching logic in something like gorillatoolkit (or similar framework)?  That could allow writing paths to match using a friendlier syntax like /users/{user}

(just some random thoughts...)
The use of caller frames to match the intercepted request is certainly an interesting approach, and one I probably wouldn't have considered. But I think it's a bit more rigid in tying the test to the method that made the http request, rather than what the request itself is.

The problem as @gmlewis already pointed out, there's not (as far as I know) way to determine which call was made in the current state of the codebase. Using the regexps could end up being a bit tedious to handcraft all the required expressions and ensure they don't collide to each other. The workaround was the runtime.Frames poc I wrote.

I also wonder if some of the regex logic could be made safer (or at least more maintainable) by using some of the path parsing and matching logic in something like gorillatoolkit (or similar framework)? That could allow writing paths to match using a friendlier syntax like /users/{user}

Using something like the gorillamux would definitely make the request matching much more friendly but I thought this repo in general was trying to not bring more remote dependencies. And also, once again, maintaining all the paths, although it would be much easier with the gorilla mux or something similar, would still mean all those paths would have to be handcrafted and maintained for the future.
Thanks for the feedbackm @willnorris ! :+1:

I will try to add the code generation to the runtime.Frame poc PR for some of the service methods to see how it would look.

Closing in favor of https://github.com/google/go-github/pull/2008

Even if this were not fully generic, and is instead specific to go-github, this is only intended for use by users of go-github. It's not used by the library itself. So I think this should really be its own repo, which we can optionally link to from go-github's README as one approach to testing applications that use the library. (/cc @gmlewis)

It is true that this code is more like a helper other than something integral to this repo so I see no big problem of moving this logic to a new repo. Something like go-github-testing or similar.
Where this new repo would reside? If inside google, I have no access, so the repo would have to be created by someone with proper access to so I could create a PR and we follow up the process in there. If not, I could create it under my user (or any of your users as well).
Also, if we're decided to move this PR to a new repo, @willnorris idea of using like gorilla to have a much more friendly URL matching would become doable. So I reckon I could close https://github.com/google/go-github/pull/2008 and improve this one.

Where would this new repo reside?

I see no reason why it couldn't be under your own user name, but we'll see what @willnorris says.

yeah, I was imagining just under your own account, at least to start out.  I don't think it will ever make sense to put it under @google, since no one from Google is actively involved with this at this point.

Hi @willnorris and @gmlewis I think I have something that is somewhat presentable. Let me know if, other than the missing CI, there's something else I'm missing.
https://github.com/migueleliasweb/go-github-mock
ps: don't know where to have this conversation, if you guys prefer to create issues in the repo itself, feel free

Sounds great, @migueleliasweb !  Thanks for doing that!
Feel free to create a PR to add a reference to your new repo in this repo's README.md so we can point people to it.

Will do, @gmlewis . I just wanted a couple more hours to ensure the tests are being run in the CI workflow before opening the floodgates :joy: .

authors: gmlewis migueleliasweb willnorris

repo: google/go-github

license_source: github-api


text:
Updated interested-technical-writers.md to add my candidature

Added my participation details for GSod. Signed the CLA as well.

@googlebot I signed it!

repo: google/season-of-docs


text:
Increases timeout for alert dialog presence testing

LGTM, but I think 1 min feels a bit long. Would 30 seconds be fine? Just thinking about what counts as "reasonable" loading time.
FInal decision is up to you, this is just a data point. Feel free to merge once you've decided.

authors: davyrisso-at-google seanlip

repo: google/tie


text:
Release 0.5.2

Codecov Report

Merging #113 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master    #113   +/-   ##
======================================
  Coverage    83.3%   83.3%
======================================
  Files          28      28
  Lines        1108    1108
  Branches      112     112
======================================
  Hits          923     923
  Misses         93      93
  Partials       92      92

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da80b13...c8a1677. Read the comment docs.

authors: codecov-io crwilcox


text:
Fixed validation additionalClassifications from 2017 year

Changes Unknown when pulling f6ac103171a487cd15386195f6eea087e08e2a64 on dev_fix_tests into ** on fix_tests**.

authors: IrynaPomazan coveralls


text:
Copy code is not working on getting started page

fixed in https://github.com/govau/designsystem/pull/233/commits/b0dc4bd410dacd23519fac0e840b9a55154e3c36

source: gharchive/issue

authors: alex-page sukhrajghuman

repo: govau/designsystem

license: MIT


text:
[doc] create documentation for the 1.4.* versions

Closed by Gravitee.io 2.x version (documentation is now splitted by version)


text:
Manually upmerge v1.3.x into master

I want to let the tests run, because I had to manually merge some Ruby files.

The Mac failures are #9729. The Windows failure is #9088. The TSAN failure is #10736. The interop failures are #10763 and #10766. And the performance failure is #10512.

repo: grpc/grpc


text:
Fix spaces in mergeable config file

Please squash the commits if possible.

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

[trickle] No significant performance differences

Objective-C binary sizes
*****************STATIC******************
  New size                      Old size
 1,976,356      Total (=)      1,976,356

 No significant differences in binary sizes

***************FRAMEWORKS****************
  New size                      Old size
10,770,405      Total (<)     10,770,414

 No significant differences in binary sizes

[microbenchmarks] No significant performance differences

Mergeable config fix, nothing to do with tests.

authors: grpc-testing mehrdada srini100


text:
Added third_party/protobuf/src to protoc's include path

It seems all failures are known (python failures on windows)


text:
Add support for settings custom headers to backend bucket

@robmorgan is there any hope for merging this PR?

Any update on this PR. There is no response from any maintainer?

Apologies for the delay in responding to this PR. Please see below:
Sunset notice
We believe there is an opportunity to create a truly outstanding developer experience for deploying to the cloud, however developing this vision requires that we temporarily limit our focus to just one cloud. Gruntwork has hundreds of customers currently using AWS, so we have temporarily suspended our maintenance efforts on this repo. Once we have implemented and validated our vision for the developer experience on the cloud, we look forward to picking this up. In the meantime, you are welcome to use this code in accordance with the open source license, however we will not be responding to GitHub Issues or Pull Requests.
If you wish to be the maintainer for this project, we are open to considering that. Please contact us at support@gruntwork.io.

A web application uses HTTPS and a URL-based session identifier. The web application might wish to link to HTTPS resources on other web sites without leaking the user’s session identifier in the URL.  - From w3.org

This looks like it would be very important for hosting some applications that contain sensitive data in the url.  The PR looks clean to me (a passer by who also likes this repo), but maybe the default configurations should set a lesser intrusive same-origin value because it may cause confusion if engineers are expecting referrer information in their own code and overlook this setting?

authors: Etiene MeNsaaH TheNotary othree


text:
CI for Node

Initializes with two players
Starts the game with a random player
Sets the current player to be whoever it is not

Initializes with two players
Starts the game with a random player
Sets the current player to be whoever it is not


text:
add get/set_document_unit() to svg surface

Thanks!

authors: GuillaumeGomez jsparber

repo: gtk-rs/cairo


text:
Migracja do LaTeX'a

[ ] Opis tematu
[ ] Opis problemu
[ ] Wizja rozwiązania
[ ] Koncepcja
[ ] Podsystem uwierzytelniania
[ ] Podsystem zarządzania zajęciami
[ ] Podsystem organizacji placówki
[ ] Podsystem zarządzania karnetami
[ ] Podsystem zarządzania sprzętem
[ ] Podsystem zarządzania kontem
[ ] Podsystem komunikacji
[ ] Podsystem administratora


text:
Added Svelte Native app examples

Brilliant, thanks

authors: halfnelson jonathoncoding

repo: halfnelson/svelte-native


text:
Do i have option to use it without the option to selected image?

Hi @roysG!
Could you elaborate the problem you're having? Do you mean not defining selected property of media objects?

Closing for inactivity. Let me know if you have any update on the issue.

Sorry to re-open such an old issue but I think @roysG may have been trying to work out the same thing I am.
Basically the grid in react-native-photo-browser alone is one of the only react native plugins that do this really well. What I'd like to do is just have it so you select an image on the grid, without being shown the full-screen page.
Basically using the app as an image picker from a grid if that makes any sense?
I've tried overriding the onSelectionChanged but it doesnt appear to work like that.
Any tips or info would be greatly appreciated @halilb :)

authors: halilb rickmills roysG

repo: halilb/react-native-photo-browser

license: mit


text:
CI for Node

game.test

repo: hasibhassan/github-actions-for-ci


text:
refactor: upgrade packages

:tada: This PR is included in version 1.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

authors: blockstack-devops kyranjamie

repo: hirosystems/eslint-config


text:
Feat/hirsch

:tada: This PR is included in version 1.12.0 :tada:
The release is available on:

GitHub release
npm package (@latest dist-tag)

Your semantic-release bot :package::rocket:


text:
Fix #1406: modify documented network_key

Hi @rubenfiszel,
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!

You are changing the example key in our documentation for a long time already:
https://www.home-assistant.io/docs/z-wave/installation/
This should not be changed and for real, not be used.

authors: frenck homeassistant rubenfiszel

repo: home-assistant/hassio-addons


text:
release 0.6.2 [ci skip]

fix #119


text:
map-file results In temp files as definition sources

Relevant information:
https://github.com/DanielG/ghc-mod/issues/482
https://github.com/DanielG/ghc-mod/pull/737

Both the linked issues in DanielG/ghc-mod are now closed, not sure what that means for this project though.

The first was already closed when we began discussing it, the second was closed and supposedly fixed in 5.6.
I'm still waiting on the next version of ghc to drop to fix my incompatibility with Windows insider, so when that happens I'll try again with the latest ghc and ghc-mod and see if the issue persists.

authors: danstiner hoovercj

repo: hoovercj/vscode-ghc-mod


text:
Do/oauth

Could you please integrate the new config from master before? Thanks!

Great! Thanks for your contribution! I hope we can now finish the Oauth task in the HowCanI project.

authors: janbaer ovu

repo: howcani-project/howcani-api


text:
Translation-Docs » Tutorials » Writing Your First Application : Querying the ledger

finished

repo: hyperledger-labs/fabric-docs-cn


text:
Fix typo

Already done, but thanks anyway. New artifact has been pushed and awaits sync to Central.

I just push 3 minutes before you ;) Anyway, looks good to me. I'll add it to the 3rd party starters, thanks!

I didn't see it, sorry. But you didn't change the version anyway ;-) Thanks again!

:smile:

authors: hzpz snicoll

repo: hzpz/mongeez-spring-boot-starter


text:
How can we save the new list after drag?

In onItemMove, you have to swap your list item.
After swapping, you have access to the new list.
@Override     public boolean onItemMove(int fromPosition, int toPosition) {         Collections.swap(yourList, fromPosition, toPosition);         notifyItemMoved(fromPosition, toPosition);         return true;     }

thanks.

authors: AtulaGuleria UNCVR

repo: iPaulPro/Android-ItemTouchHelper-Demo


text:
Make parameter USER_AUTHENTICATION_MQCSP configurable

i have created a pull request. Please review

Please can you give me some idea why this is a good idea? It doesn't seem like a desirable feature to me.

Hi,
We would also like to have this config option.
We need USER_AUTHENTICATION_MQCSP to be false to be able to connect to our company MQ server. If it's true the MQ server tries to authenticate as the executing user instead of using the username and password supplied in the properties.

Right but isn't setting this to true essentially telling the MQ client to use a modern way of passing credentials, not the original way? Are you trying to talk to an old version of MQ?

Me met this problem with out ibm mq server. Also confluent ibm mq kafka connector supports this param

Not sure how old version of MQ it is. Could look it up. But so far setting USER_AUTHENTICATION_MQCSP to false is the only way I've been able to connect.

The same we have.

OK, but the default must be TRUE. I'll take another look at the PR soon.

I've added the capability. Try setting the config mq.user.authentication.mqcsp=false to turn off use of MQCSP.

authors: AndrewJSchofield flojon mtghunt

repo: ibm-messaging/kafka-connect-mq-source


text:
Add redux-saga workflow and removed minor bugs.

@Ahsanch11 Could you re-do the PR, it has some conflicts now, all you have to do is rebase from dev.

repo: icbootcamp-project/estore


text:
Removal of unused fields in CardanoConfiguration

bors r+

repo: input-output-hk/cardano-node


text:
how to set this up?

the instructions say:
OAuth2 is used for authenticating with your Google account. The resulting token is placed in the ~/.gcalcli_oauth file. When you first start gcalcli the authentication process will proceed. Simply follow the instructions.
but when I run it, I get
[jason@badman ~]$ gcalcli
usage: gcalcli [-h] [--auth_host_name AUTH_HOST_NAME]
[--noauth_local_webserver]
[--auth_host_port [AUTH_HOST_PORT [AUTH_HOST_PORT ...]]]
[--logging_level {DEBUG,INFO,WARNING,ERROR,CRITICAL}]
[--version] [--client-id CLIENT_ID]
[--client-secret CLIENT_SECRET] [--config-folder CONFIG_FOLDER]
[--noincluderc] [--calendar CALENDAR]
[--default-calendar DEFAULTCALENDAR] [--locale LOCALE]
[--refresh] [--nocache] [--conky] [--nocolor]
[--lineart {fancy,unicode,ascii}]
{list,search,edit,delete,agenda,calw,calm,quick,add,import,remind}
...
gcalcli: error: the following arguments are required: command
[jason@badman ~]$
???
-db

You should use one of the commands, see the man page for examples.
Available commands are listed in that output:
{list,search,edit,delete,agenda,calw,calm,quick,add,import,remind}

authors: dirtbag jcrowgey

repo: insanum/gcalcli


text:
task/AV2-474/directLink-imersonate-error

lint ERROR: /codebuild/output/src251623977/src/github.com/intersective/practera-app-v2/src/app/auth/auth.service.ts:82:70 - missing whitespace
190 | ERROR: /codebuild/output/src251623977/src/github.com/intersective/practera-app-v2/src/app/auth/auth.service.ts:112:25 - missing whitespace
191 | ERROR: /codebuild/output/src251623977/src/github.com/intersective/practera-app-v2/src/app/auth/auth.service.ts:112:36 - Missing semicolon
192 | ERROR: /codebuild/output/src251623977/src/github.com/intersective/practera-app-v2/src/app/switcher/switcher.service.ts:149:36 - missing whitespace

unit test fails due to:
ERROR in src/app/auth/auth.service.spec.ts(111,25): error TS2345: Argument of type '{ authToken: string; }' is not assignable to parameter of type '{ authToken: any; timelineId: any; }'.
223 | Property 'timelineId' is missing in type '{ authToken: string; }'.
224 | src/app/switcher/switcher.service.spec.ts(235,29): error TS2570: Property 'subscribe' does not exist on type 'Promise<Observable>'. Did you forget to use 'await'?

authors: Barry-Chen-Intersective ronakamani


text:
Update README.MD: anchor to "Reloading API..."

@killthekitten thx

repo: intridea/grape


text:
Tests should not require root to run

Do the tests require root? I'm having luck doing this:
./bpftrace_test --gtest_filter='-codegen*'
...
20 FAILED TESTS

The failed tests are another issue.

I think it's just codegen.builtin_name and codegen.builtin_name_wild which require root - they'll fail if you run them without it.
I've not looked into what they're doing, but I do see code which tries to read "/sys/kernel/debug/tracing/available_filter_functions". This should be mocked out like in the tracepoint_format_parser tests.

Sounds good, I'll give this a shot if that's ok.

Go for it!

authors: ajor danobi

repo: iovisor/bpftrace


text:
Ipfs update

closing in favor of #1569

repo: ipfs-shipyard/ipfs-webui


text:
publish manager docker images on Jenkin's post submit hook

Jenkins job manager/presubmit passed

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@534d7d9). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #199   +/-   ##
=========================================
  Coverage          ?   31.31%
=========================================
  Files             ?       19
  Lines             ?     1782
  Branches          ?        0
=========================================
  Hits              ?      558
  Misses            ?     1172
  Partials          ?       52

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 534d7d9...eb5dac6. Read the comment docs.

authors: codecov-io istio-testing sebastienvas

repo: istio/manager


text:
reindenting of  yaml code blocks

thanks @ryokugyu 🎉

authors: ryokugyu shcheklein


text:
Generate map if mode set to random

Thanks :)

authors: geekgame itsexe


text:
Fix typo

:+1:

authors: didoarellano jamesob

repo: jamesob/desk


text:
give env variables higher precedence

You're too fast. 😜

Thanks and I really need it :smile:

Merged! I'll cut a new release real fast as well.

repo: jasoncharnes/pay


text:
Added new image and quote entry to the mock database.

You forgot to update the changelog.md to reflect your changes

repo: jedi-academy/starter-quotes


text:
feat: collect deployments

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign vbehar
You can assign the PR to them by writing /assign @vbehar in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/approve

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: vbehar
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [vbehar]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

authors: jenkins-x-bot-test vbehar

repo: jenkins-x/cd-indicators


text:
fix: switch to http repo

/test kube

/test kube

repo: jenkins-x/jxr-versions


text:
Add support for the claim-column

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

authors: jenkinsadmin wolfs

repo: jenkinsci/job-dsl-plugin


text:
Limit offset support

Reopening here as I'd like to see this be apart of the opts struct w/ all other JSONAPI compliant query features.

@jeregrine updates such that it only atomizes keys that are apart of the struct.

Good call, will update.

On Nov 3, 2017, at 7:44 AM, Jason S. notifications@github.com wrote:
@jeregrine requested changes on this pull request.
In lib/jsonapi/query_parser.ex:

@@ -194,4 +198,16 @@ defmodule JSONAPI.QueryParser do
view = Keyword.fetch!(opts, :view)
struct(JSONAPI.Config, opts: opts, view: view)
end

defp struct_from_map(params, struct) do
struct_keys = Map.keys(struct) |> Enum.filter(fn x -> x != :struct end)
https://hexdocs.pm/elixir/Map.html#from_struct/1 Map.from_struct will accomplish this.

In lib/jsonapi/query_parser.ex:

@@ -194,4 +198,16 @@ defmodule JSONAPI.QueryParser do
view = Keyword.fetch!(opts, :view)
struct(JSONAPI.Config, opts: opts, view: view)
end

defp struct_from_map(params, struct) do
struct_keys = Map.keys(struct) |> Enum.filter(fn x -> x != :struct end)
processed_map =
for struct_key <- struct_keys, into: %{} do
To save a step

for {key, _ } <- Map.from_struct(keys), into: %{} do
..
end
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

@jeregrine @doomspork LMK if you think this is reasonable to merge now.

@StareIntoTheBeard could you add test coverage?

@jeregrine @doomspork test coverage added.

Thanks!! <3

Thank you! :)

authors: StareIntoTheBeard doomspork jeregrine

repo: jeregrine/jsonapi


text:
Use the current standard for version constraints

Is this good to merge then?

Maybe leave a chance for contributors to fix their PRs first? It's only been 10 hours…

I want this merged so that the remaining PRs can be rebased on top of it.

authors: GrahamCampbell mnapoli

repo: jeremeamia/acclimate-container


text:
Remove the restriction that the external magic strings must be ascii strings

LGTM

authors: robertsipka zherczeg

repo: jerryscript-project/jerryscript


text:
Rename effortDistanceKm in Rarities sheet, drop effortDistanceEnteredUnit

commit 4b33f5ad7ecc8e67ae28dfbbf3a4f8d430cac49d
or sooner; had to complete column rename work to fix this

commit 4b33f5ad7ecc8e67ae28dfbbf3a4f8d430cac49d
or sooner; had to complete column rename work to fix this


text:
Add support for rank_feature query

After a rebase on master the build should pass, not force-pushing in case someone's already having a look at the changes

Thanks for this & sorry for the slow response. I added a bit more configurable version of this in #64. You'll be able to enable plugins on the source block as well as customize settings for the search module.
So, closing this PR in favor of my own.

Thanks, left a question on the merged PR on how to make use of it.

authors: jillesvangurp yassenb

repo: jillesvangurp/es-kotlin-client


text:
show (x,y) at mouse point in show.py

Please see https://stackoverflow.com/a/22925718/1801749

achieved with NavigationToolbar2Tk

repo: jintonic/toward


text:
Need GET route for Menu

PR #83


text:
Create CODE_OF_CONDUCT.md

Merged to master


text:
fix vulnerabilities with dev dependencies

Coverage remained the same at 100.0% when pulling 270fae4ff7482433cc0cad60d292bf0a00baa8b3 on v2.2.2 into ce5de65c8b75a59d091073a01ce594039a3001fe on master.

authors: coveralls joaquimserafim

license: isc


text:
Brain powered arms

Requires #10

repo: jobtalle/SketchSquids


text:
fix typos

Thanks

authors: azu syoichi


text:
Default HECP to an empty list (fixes #48)

Lgtm

authors: johnsca kwmonroe

repo: juju-solutions/jujubigdata


text:
Dockerfile deis deployment of deis-ui with grunt-connect-proxy and etcd autodiscovery

There's a lot going on in this PR. I'm not a maintainer of this project, but this seems to infer a lot about Deis' internals, especially WRT inferring that etcd is at 172.17.42.1:4001 by default (a lot of different cloud providers use different internal addresses). Even I'm :confused: on all of the changes going on in here.
Would it be too much to separate out the different changes in this PR (adding a new DEIS_CONTROLLER_FQDN envvar, LIVERELOAD, Dockerfile, proxy settings) into separate PRs along with a well-described justification such that each change can be given the focus it needs?

@bacongobbler, I appreciate your feedback, and I would totally love to spend more time helping with this project, which I fully understand isn't a OpDemand project nor one that you helped build.
However, and I'm going to put it nicely, I spent a solid 12 hours slamming my head up against really horrible grunt/connect/node.js documentation in order to solve the key problem with this project as it stands, and that is that until this PR it was impossible for me to deploy this into my deis clusters.
This uses someting called "livereload" which normally runs on TCP port 35729 and runs its own WebSocket service that is entirely separate from the "connect" web service that runs on port 9000.  In order to use with deis, grunt-connect-proxy needed to be grafted in, and let me tell you, that was no small feat.
Note: I don't run much node.js. I've written a few smaller node.js apps, but I'm not an expert in it by any means. This means it's still a pretty monumental undertaking for me to jump into some foreign node.js codebase and do something like graft a proxy into it to make it use a single port.
Heck, the second biggest problem I ran into is that grunt-connect 0.1.11 broke HTTPS proxying. No joke. HTTPS proxying is  I had to freeze this thing to 0.1.10 to use HTTPS to my deis controller. Issue #70 in grunt-connect-proxy has my comments for posterity on the matter.
The first problem I ran into is the, again, horrible node.js/grunt/connect documentation, and a community of folks who seem to be mostly cutting and pasting code snippets from a very small number of folks who actually know how this works internally. I had to dig into the source to figure it out.
So, I spent a full day on this. It is deployed. It is obviously a work in progress, but I think jumbojett has a really nice idea here, and I think very idiomatic (such as they are) node.js is being employed. I want to encourage jumbojett to continue this effort, and the best way I could think of was to spend an additional couple of hours iterating and whittling down my PR to the bare minimum required to allow deis-ui to use one port, as is the current deis limitation.
To be honest, I'm using port 8443 here mostly because I have my own ELB setup with TCP and proxyProtocol fowarded to hacked deis-router instances that merrily proxy through to that same TCP port 9000 listener being used by deis (as it is, and can be, the only EXPORT in the Dockerfile). Only by the magic of detecting UPGRADE for proxying WebSockets is this thing merrily working with livereload. It probably should be 443, to be honest.
Then again, this all may be lack of sleep on my part, and I might just be all gripey because of the hair and sleep I've lost last night trying to figure out the right magic to allow both HTTP and WebSockets proxying in node.js, using nothing but sheer force of will and determination.
So, yes, I agree, there is room for improvement. This PR could be so much more. But without this, it simply isn't deployable yet. Granted, it may not be ready to be deployed by most folks yet, but more eyes on a project can only help it.
Keep up the great work @jumbojett! And know that someone else is using your project now :)

This is a great discussion.
@ianblenke - I agree the Node.js is daunting at first. I will point out that the end result is a build of static html and javascript files. Grunt and livereload are meant for development purposes. I'd like to include a dist in the future so developers can avoid dealing with the build process. I think there's a lot of good ideas in you pull request though.
@bacongobbler - I'm adding you as a contributor. Understandably @ianblenke seems short of time and I'd like help cherry-picking this pull request.

Thanks @jumbojett!
Running deis-ui as pure static content would be great. The big challenge seems to be related to CORS, as without the proxy I was getting a consistent error with Authorization against the deis controller URL. After proxying things, this problem abated.
Is this meant to be deployed as the static content served up by nginx by default on a deis-controller?

The CORS issues is due to the fact that deis headers need to be whitelisted, I have a PR for that open in deis/deis#3253 which will probably be part of the next release.

authors: Joshua-Anderson bacongobbler ianblenke jumbojett

repo: jumbojett/deis-ui


text:
Improve Docs

Thanks for the pull request, but this would not be an appropriate change.

authors: minrk tejasmak


text:
Add symbols to raw_collection types that won't be mapped

Can you add a description here please? What problem are you solving?

Sorry about that, you caught me while trying to figure out how to link the pull request to the issue *)

authors: Morred justinfrench

repo: justinfrench/formtastic


text:
Update bluebird and lodash to their latest versions

Cool stuff! I guess this needs to be rebased now that https://github.com/jviotti/rindle/pull/4 got merged.

Yep, done

Check 1.3.1 on npm.

authors: Page- jviotti

repo: jviotti/rindle


text:
cannot import name '_C'

/home/jiang/anaconda3/lib/python3.6/importlib/_bootstrap.py:219: RuntimeWarning: numpy.dtype size changed, may indicate binary incompatibility. Expected 96, got 88
return f(*args, **kwds)
/home/jiang/anaconda3/lib/python3.6/importlib/_bootstrap.py:219: RuntimeWarning: numpy.dtype size changed, may indicate binary incompatibility. Expected 96, got 88
return f(*args, **kwds)
Traceback (most recent call last):
File "trainval_net.py", line 33, in
from model.faster_rcnn.vgg16 import vgg16
File "/home/jiang/faster-rcnn.pytorch/lib/model/faster_rcnn/vgg16.py", line 16, in
from model.faster_rcnn.faster_rcnn import _fasterRCNN
File "/home/jiang/faster-rcnn.pytorch/lib/model/faster_rcnn/faster_rcnn.py", line 10, in
from model.rpn.rpn import _RPN
File "/home/jiang/faster-rcnn.pytorch/lib/model/rpn/rpn.py", line 8, in
from .proposal_layer import _ProposalLayer
File "/home/jiang/faster-rcnn.pytorch/lib/model/rpn/proposal_layer.py", line 21, in
from model.roi_layers import nms
File "/home/jiang/faster-rcnn.pytorch/lib/model/roi_layers/init.py", line 3, in
from .nms import nms
File "/home/jiang/faster-rcnn.pytorch/lib/model/roi_layers/nms.py", line 3, in
from model import _C
ImportError: cannot import name '_C'

I have the same error when I run the demo in pytorch 1.0 branch, and solution?

I solved it.
1） install pytorch 1.0.0 .
I used 1.0.1 before，then got error ：
from model import _C
ImportError:  /mypath/to...... /model/_C.cpython-36m-x86_64-linux-gnu.so: undefined symbol: _ZN3c105ErrorC1ENS_14SourceLocationERKSs
2）update GCC by ：conda install -c psi4 gcc-5
I received warning when using GCC4.8: Your compiler (g++ 4.8.5) may be ABI-incompatible with PyTorch! Please use a compiler that is ABI-compatible with GCC 4.9 and above. 。。。。
see:  https://gist.github.com/goldsborough/d466f43e8ffc948ff92de7486c5216d6

Thanks @DiaoYuxian
downgrading pytorch to 1.0.0
rm -rf lib/build/
python setup.py build develop

solved the problem too.
wonder if its a bug in nightly pytorch..

When I run pytorch1.0 branch,I have the same problem with you. But I can find /model/_C.cpython-36m-x86_64-linux-gnu.so
Then how did you solve it?

Why can't I find this /_C.cpython-36m-x86_64-linux-gnu.so under /model?

This is because of pytorch version incompatibility ,
pip install torch==1.3.0
These Worked for me .

Thanks @DiaoYuxian
downgrading pytorch to 1.0.0
rm -rf lib/build/
python setup.py build develop

solved the problem too.
wonder if its a bug in nightly pytorch..

It seems version incompability is the main reason. Just remove the build and build it again.

I have tried many times, from torch 1.0.0 to torch 1.3.0. I am still suffering the problem.... @DiaoYuxian I also follow your instruction. But it does not work. Any idea? Thanks

Do you solve the problem? @wtliao I met the same problem and tried many times too....

Thanks @DiaoYuxian
downgrading pytorch to 1.0.0
rm -rf lib/build/
python setup.py build develop

solved the problem too.
wonder if its a bug in nightly pytorch..

solved the problem.
thanks!

Thanks @DiaoYuxian
downgrading pytorch to 1.0.0
rm -rf lib/build/
python setup.py build develop

solved the problem too.
wonder if its a bug in nightly pytorch..

solved the problem.
thakns!

Thanks @DiaoYuxian
downgrading pytorch to 1.0.0
rm -rf lib/build/
python setup.py build develop

solved the problem too.
wonder if its a bug in nightly pytorch..

My compile env:
torch=1.3.1
torchvision=0.4.2
python=3.6
OS = linux
When I try to run trainval_net.py, I have the similar problem:
undefined symbol: _ZN2at19UndefinedTensorImpl10_singletonE
after remove the  lib/build/
and run :
python setup.py build develop
These worked.
Thanks!

thans to before all. I have already solved this problem.
Cant find _C ???

delete build file if build file exist
cd to faster-rcnn.../lib/ and run python setup.py build develop
cd faster-rcnn/lib/build/lib.linux-x86_64-3.5/model than copy _C.cpython-35m-x86_64-linux-gnu.so to faster-rcnn.../lib/model

I have spent 5 days to solve  the same problem, which comes from stereo-rcnn,not this.
when I want to build  and run nms.py. it shows:
undefined symbol: _ZN2at19UndefinedTensorImpl10_singletonE
My compile env:
torch=1.0.0
torchvision=0.2.2
cuda =9
python=3.6
gcc 5.4
OS = linux
it should  work,but i fail
finally,  I find the soultion in pytorch.org. I must import torch.
I success
In a word. we should keep torch,torchvision,cuda ,python,and gcc compatible.what's more, import torch.hope it can help you.

Install pytorch1.0.0, and compile the cuda dependencies using following simple commands:
cd lib
python setup.py build develop
it works.

You can run train trainval_net.py at torch==1.0.0 torchvision==0.2.0, but run test_net.py will get ImportError: /root/code/faster-rcnn.pytorch/lib/model/_C.cpython-35m-x86_64-linux-gnu.so: undefined symbol: _ZN2at19UndefinedTensorImpl10_singletonE.
It's because the version of pythrch. I install 1.3.0 by pip install torch==1.3.0+cu100 torchvision==0.4.1+cu100 -f https://download.pytorch.org/whl/torch_stable.html
Remember pythrch need match cuda,my cuda version is 10.

pip install torch==1.3.0+cu100 torchvision==0.4.1+cu100 -f https://download.pytorch.org/whl/torch_stable.html
cd lib
rm -rf build
python setup.py build develop

Thanks @DiaoYuxian
downgrading pytorch to 1.0.0
rm -rf lib/build/
python setup.py build develop

solved the problem too.
wonder if its a bug in nightly pytorch..

It worked on macOS.
But it's more accurate like this:
cd lib/
rm -rf build
python setup.py build develop
cd ../
python demo.py

then got:
Installed /Users/user_name/dir/faster-rcnn.pytorch/lib
Processing dependencies for faster-rcnn==0.1
Finished processing dependencies for faster-rcnn==0.1

I have tried many times, from torch 1.0.0 to torch 1.3.0. I am still suffering the problem.... @DiaoYuxian I also follow your instruction. But it does not work. Any idea? Thanks

I have tried many times, from torch 1.0.0 to torch 1.3.0. I am still suffering the problem.... @DiaoYuxian I also follow your instruction. But it does not work. Any idea? Thanks

Herr liao, i am kai, i met the same problem ....

authors: AQ123AQ AyazSaiyed Damilytutu DiaoYuxian Janezzliu Luweiww LwGitUp fanyuzeng jiangkeng123 kentaroy47 kuailefeifei rpfly3 shirui-japina smallflyingpig wtliao www516717402


text:
is there a pytorch  implementation?

Hi,
Thanks for your interest in our work!
Unfortunately, our Pytorch reimplementation is not ready to release.
From our experience, it should be relatively easy to do it by changing the functions of "tf" to "torch" in the SegSort module and planting it on top of an existing PyTorch segmentation codebase.
Hope this helps.  Let me know if you have further questions; otherwise I'll close this issue for now.
Best,
Jyh-Jing

repo: jyhjinghwang/SegSort


text:
Correct spelling

I always mistake this word. Thanks!


text:
最新版本跳转到函数定义很卡，希望优化下

我的基本是没法跳转了，进度条卡半天然后跳不过去。

authors: WitLau loglugang


text:
Remove v1alpha1 CRDs and related bits

This looks good Dan.  I didn't see anything that would delete the collection controller deployment and friends on an upgrade from 0.9.0 to 0.10.0.  I think we need something in the kabanero controller that makes sure the collections stuff is deleted (deployment/pod, SA, roles, etc).  I'm not sure that stuff would get deleted on an upgrade unless the Kab CR instance was deleted.  Do you agree?
@dacleyra

Maybe. The upgrade scenario doesn't satisfy InstallPlan
    Message:               error missing existing CRD version(s) in new CRD: kabaneros.kabanero.io: New CRD (kabaneros.kabanero.io) must contain existing served versions
(v1alpha1)

https://github.com/operator-framework/operator-lifecycle-manager/blob/fb2879e6ec1f54973f69a2d6136fc99094e2b261/doc/design/dependency-resolution.md#deprecateremove-a-version-of-crd
I don't think we set v1alpha1 served: false in a version previous

Do we just need to introduce an artificial step (like have 0.9.1 set served = false for v1alpha1 and then 0.10.0 can remove it)?

yes

Setting served = false in 0.9.1, and then installing 0.10.0 from the PR worked
InstallPlan was successful
collection controller deployment is gone
the collections CRD sticks around though, but that seems to be normal? I don't think OLM necessarily cleans out CRDs

close in favor of
https://github.com/kabanero-io/kabanero-operator/pull/760

authors: dacleyra kaczyns

repo: kabanero-io/kabanero-operator


text:
Add login result to data.extra

The modification looks good. If you add some tests to check for the presence/absence of the data.extra field in some responses, and add it to the documentation, I'll pull this in.

Also, thanks so much for submitting this PR!! I'm in such a rush I almost forgot that very important bit :)

Any update on this? Another user was requesting the functionality in #194. I imagine you've just been busy.

Sorry about that, I've added tests now

Oh, awesome! Did not expect that quick of a response. I'll take a look at the tests, and if they look good and everything passes I'll merge this in tonight and publish a new version. I'll keep you posted. Thanks again for putting this together!

:+1: no worries, thanks for building this great library.

Okay, the tests look good and they're all passing. Awesome! I'll consider creating an explicit test for the data.extra field (instead of testing for it throughout other tests), but this is enough to verify the functionality for now. I'll merge this in soon, then I just need to update the docs (to remove the "coming soon" label from this feature) and the change log before deploying. Thanks again for the quick response!

Sorry, I spoke to soon. You'll need to rebase this onto devel and do a force push to this branch (otherwise you'll have to create a new PR and we'll lose this comment history). Sorry about that. I was looking at GitHub claiming that there were no conflicts with the base branch up above.

If it's not too late, while you're rebasing, feel free to squash these into a single commit. No worries if you don't. It's fine as two commits. Just not totally necessary, since we never really want features to exist without accompanying tests, so the intermediate commit is kind of a "dead" commit. Like I said though, no big deal if you've already rebased.

The squash and rebase is done, but I've never used it in my workflow before. I favour keeping the history intact as it helps with identifying in which commit a bug was introduced, as well as keeping the dates intact for record keeping.

Not sure what you mean about keeping the dates intact. You'll see that the date of the original commit is intact. Git keeps record of the original date a commit was authored and the date of the most recent modification. Just run git cat-file -p <commit_sha> to see the detailed commit info (notice the difference between the author and commit dates):
$ git cat-file -p dace68ce8d42efa0a
tree a6e22145a03440454890ae2897983ad1f9e64ec0
parent 7876327dbbb0ddcab60066a0b45c9c43c34ca167
author Aram Kocharyan <akarmenia@gmail.com> 1453036205 +1100
committer Aram Kocharyan <akarmenia@gmail.com> 1457752390 +1100

Add login result to data.extra

Add tests for extra field

I always love to learn about different git workflows (even though I believe I have found the perfect one :P ), but like I said, that intermediate commit was "bad" history, as it contains untested code. Ideally, tests should be written before any code is changed. If the commit with the tests came first I would have said to just leave it. Squashing it seemed easier than asking you to swap their order. Just trying to keep up with the conventions I've done my best to follow in this repo. I don't care about having ALL the history, so much as having a clean history. Just a difference in philosophy is all. Definitely not claiming my way is better.
Anywho, I'll get this merged in ASAP. Just finishing up something for another project and then I'll take care of it. You'll get a notification as soon as it's merged and closed. I'll make those updates to the docs and publish the new version shortly after that (should be v0.8.9). Once again, thanks for the PR and the feedback. Greatly appreciated!

This was released in v0.8.9. Thanks for all your help @aramk!

Cheers for the merge and explanation :+1:

authors: aramk kahmali

repo: kahmali/meteor-restivus


text:
Update externals

Requires #266

config.location only exists in nixpkgs-unstable for now :/

config.location only exists in nixos-unstable for now :/

You can import that as a patch against stable.

@kalbasit is this patch https://github.com/kalbasit/shabka/blob/shabka_update-externals/external/unstable/fix-nvim-terraform-plugin.patch still relevant? It seems the requested changes have been merged in nixpkgs-unstable, but the patch doesn't match those changes.

applying patch /nix/store/gfsp59g796fzvrf6zwkpsn7b5rhvqkxf-add-config-locale.patch is failing.

applying patch /nix/store/gfsp59g796fzvrf6zwkpsn7b5rhvqkxf-add-config-locale.patch is failing.

Yeah, but this only happens on the CI. It patches without problem on my machine.

The flashplayer problem has been corrected upstream, so I'll update the hosts once more

applying patch /nix/store/gfsp59g796fzvrf6zwkpsn7b5rhvqkxf-add-config-locale.patch is failing.

Okay so git-apply works but patch doesn't

@kalbasit is this patch https://github.com/kalbasit/shabka/blob/shabka_update-externals/external/unstable/fix-nvim-terraform-plugin.patch still relevant? It seems the requested changes have been merged in nixpkgs-unstable, but the patch doesn't match those changes.

Yes, this patch was a workaround the issue, but I fixed it properly in NixOS/nixpkgs#66536.

Should I delete the patch while I'm at it?

@kalbasit this is ready to merge (except for https://github.com/kalbasit/shabka/pull/265#issuecomment-524992913). hera builds just fine on my machine.

authors: kalbasit rissson

repo: kalbasit/shabka


text:
UART LCD Controller Driver

Assigned to Ziyi Feng.

Closing for now. May reopen at a later time.

authors: ZiyiFeng-SJSU kammce


text:
Throwing error without loosing stack trace

Thanks, that makes a lot of sense, but can you please leave it at using a for loop as forEach is not available in older browsers.

Build fails due to https://github.com/karma-runner/karma-requirejs/issues/41

I will close and reopen PR to trigger travis build

Thanks :octocat:

authors: delfrrr dignifiedquire

repo: karma-runner/karma


text:
Add appdev {% if}s for deploy params & bump version.

LGTM

authors: MrCreosote scanon


text:
Unit test coverage

:clap:

repo: kevinzhow/PNChart


text:
implement PolicyURI

@oconnor663 can you review this?

Looks good to me. Did we run into someone's PGP key that requires support for this?

Yeah see the referred issue.  Confirmed that this fixes is.
On Saturday, January 2, 2016, oconnor663 notifications@github.com wrote:

Looks good to me. Did we run into someone's PGP key that requires support
for this?
—
Reply to this email directly or view it on GitHub
https://github.com/keybase/go-crypto/pull/3#issuecomment-168435151.

repo: keybase/go-crypto


text:
Add common test logging module

/test pull-knative-pkg-unit-tests

/hold

/hold cancel

/lgtm

repo: knative/pkg


text:
Add update-codegen

/retest

/lgtm

authors: evankanderson greghaynes k4leung4

repo: knative/serving-operator


text:
update CamRole to MtcRole

@jmontleon we probably need operator updates for this as well.

authors: djwhatle jmontleon

repo: konveyor/mig-controller


text:
Add map.shouldHaveSize assertion

I don't believe we have this currently.

Should not we close it yet? :)

Sure thing!
I suggest closing issues when commiting https://help.github.com/en/articles/closing-issues-using-keywords

Sure thing!
I suggest closing issues when commiting https://help.github.com/en/articles/closing-issues-using-keywords

Ok. Did not know. Thank you!

authors: Kerooker sksamuel verkhovin

repo: kotlintest/kotlintest


text:
Update OWNERS.

/retest

/retest

Force-merging to get approval status from the OWNERS file.

repo: kube-reporting/hive


text:
Fix json syntax errors in the node-discovery template

/assign

Those values are placeholders that are supposed to be replaced with numbers so I think this PR is invalid.

this change actually breaks label-nodes.sh as replaced string in quotes becomes different data type:
./label-nodes.sh
error: error validating "node-feature-discovery-job.json": error validating data: [ValidationError(Job.spec.completions): invalid type for io.k8s.api.batch.v1.JobSpec.completions: got "string", expected "integer"

makes sense, closing the PR.

authors: chaitanyaenr marquiz okartau


text:
small refactoring in lb to start to unravel managed sg

Coverage decreased (-0.1%) to 23.293% when pulling 7bb2c8c33320e3a5715f9d253d939469a80cbfc2 on refactor-lb into a6565ea427473c41e004983e9b9ba12f5b0617d1 on master.

authors: bigkraig coveralls


text:
Remove unused timeout var from the sync controller

It looks like the SchedulingPreferenceController contains this same unused variable. Should we remove it there too?

Good catch! Done.

repo: kubernetes-sigs/kubefed


text:
Convert images to use Fedora

/cc @admiyo @stu-gott @davidvossel @vladikr

authors: berrange fabiand

repo: kubevirt/kubevirt


text:
Fix type for newParam

Coverage decreased (-1.6%) to 31.212% when pulling 83a46928be1dc5530a2aa31d6959c032d2efa391 on fcastilloes:fix-type into bd3d9bc2c18dc16624b5f56bc02cbcd975e31736 on kusanagi:master.

authors: coveralls fcastilloes


text:
Updates to README

Coverage remained the same at 88.654% when pulling 80a6eca8cfd1b30bcbc4c412a37c2e73ecbb4657 on nullproxy:master into f0b29a1a85c5254b8497ae7483304e6c18e034fb on kusanagi:master.

Coverage remained the same at 88.654% when pulling 1d337a8b658092e3761109a92bb2d23d42c11181 on nullproxy:master into f0b29a1a85c5254b8497ae7483304e6c18e034fb on kusanagi:master.

authors: coveralls nullproxy


text:
修改群满时的处理及提示

LGTM

repo: leancloud/ChatKit-OC


text:
Refactor

Coverage increased (+9.6%) to 53.004% when pulling 25bb185ae09d527cec575c36ebadc4b591d7b5e8 on refactor into 6e991e6fe92858538e36f55ae49e719615216364 on master.

authors: coveralls liampauling

repo: liampauling/flumine


text:
Update 00064_02.sced.txt

Comments # on English lines means English is ignored.  Put # at the beginning of Japanese line to have English in patch.


text:
Stop relying on flaky jsonplaceholder.typicode.com in ProjectTests

Going to merge this to unblock https://github.com/lihaoyi/Ammonite/pull/1061.

repo: lihaoyi/Ammonite


text:
integrate with codecv

fix #35

repo: liuzhengyang/simple-rpc


text:
added e2e latency stats

Thanks for this PR!

@0x46616c6b fixed according to your comments, thank you!
at a point we'll get some tests in there as well :)

Can you squash your commits? After this i will merge this PR.

so i fixed all the comments, but i think i need to do another pr, since somehow its not being updated according to master.

Cool, but now you changed the commit message to "squashed commits". It should reflect what you had changed. :-/

@0x46616c6b fixed.
sorry about that.
also added a make instruction on the ready file.

now are two commits are present. one with the "squashed commits" message and a commit with a meaningful message but their is only the change of the readme. i recommend to reset your branch to origin/master and make a new commit and after this you can do a force push.

Any updates on this pull request?

will fix that, and push today/tomorrow

hey @0x46616c6b , or @tecbot , can you please review?
I've added a func to check for e2eLatency Percentiles existence .

Thanks for this PR and your patience!

authors: 0x46616c6b Dnile saidimu


text:
[doc] Fix typo in TLUL docs

Oops, can't commit yet. Error message:
The commit message must contain a Signed-off-by line that matches the commit author name and email, indicating agreement to the Contributor License Agreement. See CONTRIBUTING.md for more details. "git commit -s" can be used to have git add this line for you.
Please address @nmoroze and we can submit

Fixed, my bad!

authors: nmoroze sjgitty

repo: lowRISC/opentitan


text:
Add log-out feature

 Admin logout

 Admin session management

 User app - session management

repo: lucy-marko/centrepoint


text:
Progress of status of conversion

The generalMatcher Not working properly

Exception in thread "pool-3-thread-4" java.lang.NumberFormatException: For input string: ""
at java.base/java.lang.NumberFormatException.forInputString(NumberFormatException.java:65)
at java.base/java.lang.Integer.parseInt(Integer.java:662)
at java.base/java.lang.Integer.parseInt(Integer.java:770)
at es.urjc.videotranscoding.core.impl.StreamGobbler.getDifference(StreamGobbler.java:121)
at es.urjc.videotranscoding.core.impl.StreamGobbler.run(StreamGobbler.java:76)
at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1167)
at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:641)
at java.base/java.lang.Thread.run(Thread.java:844)

repo: luiscajl/VideoTranscoding


text:
Bring back Qubole

there are a few qubole collection thingys

repo: lyft/flyteplugins


text:
fix PluginError arguments

LGTM :+1:

authors: mainyaa nazo

repo: mainyaa/gulp-electron


text:
fix url parse error when port specified

Thank you! Unfortunately this was already fixed in #252. Will be released soon.

authors: Hrysa drwpow

repo: manifoldco/swagger-to-ts


text:
Refactored test code in order to speed up builds.

speedup

repo: manub/scalatest-embedded-kafka


text:
你好，请问歌曲的时长和播放条那的时间歌名歌手是写在哪个文件的

你好，是在 music.vue 里面

滚动条目前是通过CSS改变的，具体样式请查看index.less


text:
Fix comma position in hashfolder.toString

Thanks @bernard-ng, I squashed and merged the fix.


text:
fontSize for labelStyle does not change for android

Yeah that's correct, I should update the documentation. Unfortunately you're unable to style the android picker like that (see: https://reactnative.dev/docs/picker-style-props)

authors: adriantabirta markuswind


text:
Fall back to msMatchesSelector in findAssignedElement util

LGTM if you also add a direct dependency on @material/dom

Done, in all 3 packages where we use it.


text:
Attachment viewer

LGTM

authors: giomfo ylecollen

repo: matrix-org/matrix-ios-kit


text:
Added in array example

Codecov Report

Merging #257 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #257   +/-   ##
=======================================
  Coverage   81.62%   81.62%
=======================================
  Files           8        8
  Lines        1894     1894
=======================================
  Hits         1546     1546
  Misses        259      259
  Partials       89       89

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e82392c...0890e3e. Read the comment docs.

repo: mattn/anko


text:
On clicking inside the sidebar, sidebar should not get closed

Can we have this very soon

@Mobeidat I will have time to look into this weekend and hopefully release the fix
I am also happy to accept a PRif you would like to fix

I was just looking into this issue!
Being able to pass a callback function that would determine if the menu closes would be ideal. Or a passed boolean that turns off the auto-close.
It's essentially this function that is causing it to close on click:
    documentClick: function documentClick(e) {
      var element = document.querySelector('.bm-burger-button');
      var target = e.target;

      if (element !== target && !element.contains(target)) {
        this.closeMenu();
      }
    }

Any updates on this?!

@Mobeidat Fixed this in v1.0.3 :)

I'm having this issue on v1.0.8. Clicking on a div inside the bar, closes it.

@edum18 I need more info...what you mean clicking on a div inside the bar ?

Indeed it's not fixed. Clicking on div or anything else inside off-canvas menu closes it. We talking about slot content here...

I'm on v2.0.2 and i am having the same issue, menu closing upon click on a menu item.
As follow my analysis about the documentClick method:

element evaluates to the burgerButton
The if statement checks if the target element is not contained in the burgerButton
By checking the DOM the burgerButton is a sibling of the menu and not its parent, so the if always evaluates to true which automatically closes the menu:

      ....

...

Issue fixed by looking up targetElement from parentElement and not from burgetButtonElement:
  if (... && !element.parentElement.contains(target) && ...)

Please PR this and release it.
      if ( ... && !element.parentElement.contains(target) && ... )

this way as long as we're clicking inside the parent div of both burgetButton and bmMenu we're not closing the menu.

authors: EggIt Mobeidat RomkaLTU edum18 macksfield mbj36


text:
Update german translation (5 new in UI)

Thanks :+1:

authors: kripton mcallegari

repo: mcallegari/qlcplus


text:
do you plan to make an 'rnpm' integration ?

@delmotte Not until this is feature complete. Though I'd merge something in the meantime.

rnpm seems to work fine for me.

Re-open if it doesn't for anyone

authors: LeBlaaanc delmotte mehcode

repo: mehcode/rn-splash-screen


text:
Add warning against XCode 12

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

authors: CLAassistant smarki

repo: mendix/docs


text:
[DCOS-41803, DCOS-41812] Updated login_session to use new CLI features.

This would break if we later change to using older CLIs with older clusters, correct?
/cc @takirala

@porridge This will work for DC/OS clusters >= 1.10, that's the main feature of the new CLI.

Also apparently it will not work with 1.9 clusters, even with 1.12's CLI.

I know that @jeschkies has recently spent quite a bit of time addressing this flow in shakedown. Would it make sense to consolidate this knowledge there so that this would work out the box for anyone that wants to use it -- otherwise the Marathon team will end up with the same issues as soon as they start using the new CLI.

Closing this as the first solution investigated to solve the issue is in review and will be easier to use on your side: https://github.com/dcos/dcos-cli/pull/1335

authors: ArmandGrillet elezar porridge

repo: mesosphere/dcos-commons


text:
Handle special case, if users have no access to the root group.

Coverage decreased (-0.02%) to 74.055% when pulling e1148fcf3cc5bda8216f3dca2d312f20103e1a3b on mv/empty_group_access into cf504d13e0dac9f6886ed9bcac0513cb5c6b7390 on master.

@gkleiman added a test case

Coverage increased (+0.1%) to 74.209% when pulling 74ada444da41db2d5c2a9805c6522762bc30114c on mv/empty_group_access into cf504d13e0dac9f6886ed9bcac0513cb5c6b7390 on master.

@aquamatthias: just one more little thing and then I'll hit merge! =)

@gkleiman copy/paste. Thanks.

Coverage increased (+0.1%) to 74.195% when pulling 3ce142e6696ccdf8b2dbfcb7c11607d3b678d962 on mv/empty_group_access into 7bccb74ed8d50292b4cabc943d3d07d1ed1fd719 on master.

:ship:

authors: aquamatthias coveralls gkleiman

repo: mesosphere/marathon


text:
Version 0.3.10

Landed in 70bac79

repo: metarhia/metasync


text:
Added Travis to Slack notification

Coverage remained the same at 73.504% when pulling a26b3281ea11a108e699e6fbb72244c03300b68d on enhancement/travis-slack-notification into 13ed3694f804b2cb5bce4d52c7402c30ccebf71a on master.

Coverage remained the same at 73.504% when pulling 0b713a7c0e6d88863d764a7b16ec857641c10031 on enhancement/travis-slack-notification into a7f700acd7caaadd6aa094c046a7c70e91dde522 on master.

authors: coveralls frankscholten

repo: microservices-demo/shipping


text:
Clean up test and migrate to 3.1

This PR is a bit big and also some of the changes I don't necessarily agree with. This would be a good candidate to split into multiple PRs also, to discuss first to achieve an agreeable outcome.

I do think migrating examples to .NET Core 3.1 is a good goal and would be worth an independent PR.

I'm going to close this PR as it is too big for a single merge. There are many separate concerns being addressed here. Smaller PRs with a single concern would be preferred.

repo: microsoft/FeatureManagement-Dotnet


text:
Fix the documentation

I was just about to open a new PR to add the hist-GBDT to the documentation.
Thanks for that!

authors: ahmedkrmn interesaaat

repo: microsoft/hummingbird


text:
Saving untitled files in VSC Notebooks

Validating as work item.

authors: DonJayamanne IanMatthewHuff

repo: microsoft/vscode-python


text:
Add whether we're running in codespaces in startup telemetry

Closing as every telemetry event already has Properties["common.uikind"] and that value is "web" when the extension is running in Codespaces.

Closing as every telemetry event already has Properties["common.uikind"] and that value is "web" when the extension is running in Codespaces.


text:
Create BrandedVisions

Test


text:
fix up statesync demo

Requested updates made.

repo: microtick/bounties


text:
Priority 4 - Search in Audit logs not working

Have you tried using the advance search option, I am going to close this issue.

yes i did, still its not perfect.

i need some additional search options to easily search for log

authors: MathiDuruva Meena88 maektwain

repo: mifos-x-customization/temp-os


text:
Update README.md with a note for macos Mojave users

Thanks for the heads up. This information already lives on the wiki but should definitely be added to the README as well.
I'm closing this PR in favor of adding README links to the appropriate wiki sections instead: #62
Let me know if this does/doesn't make sense!

I think you need to have some sort of clear instruction on the github page,
particularly if you want it accessible for anyone. I was just playing and
trying wax out and I wanted to spin up a site and was having such trouble
until I found this. I didn't even see the wiki. Either link to the wiki
(which may or may not be linked to, but def needs to be more predominant,
or link to the site mentioned above.)
On Thu, Jun 27, 2019 at 1:41 PM marii¨ notifications@github.com wrote:

Thanks for the heads up. This information already lives on the wiki
https://minicomp.github.io/wiki/wax/system-requirements/ but should
definitely be added to the README as well.
I'm closing this PR in favor of adding README links to the appropriate
wiki sections instead: #62 https://github.com/minicomp/wax/issues/62
Let me know if this does/doesn't make sense!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/minicomp/wax/pull/58?email_source=notifications&email_token=ACLJOTZ7EQCEAFKE5C2ABULP4T3U5A5CNFSM4HXZSOLKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYX3LHQ#issuecomment-506443166,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACLJOTYAHPHXKLC4TMTA25TP4T3U5ANCNFSM4HXZSOLA
.

--
Laura Newman Eckstein
First Year PhD Student in History at the University of Pennsylvania
Early Atlantic Jewish History. Digital Humanities. Economic Trade Networks.
Lauraneckstein.com

authors: lauraneckstein mnyrop

repo: minicomp/wax


text:
Small update for README (compile -> implementation)

thanks a lot @andproger !

authors: andproger patedit

repo: mixpanel/mixpanel-android


text:
unable to use pyodbc with access database

Can you provide some more information?
There are unit tests for access in the tests2 and test3 directories.  They were failing unless you ran with -v.
There are some Python 2.7 failures for very long memos, but everything else seems to work.

authors: derarnader mkleehammer

repo: mkleehammer/pyodbc


text:
fix mleibman/SlickGrid#855 (Memory leaks when cell contains jQuery controls

A question, Simon, if you're still interested.
In
     $canvas[0].removeChild(cacheEntry.rowNode);
     $(cacheEntry.rowNode).empty(); // remove children from jQuery cache

I would imagine that the node will no longer exist by the time the second line executes, having been removed from the DOM. Is there something I'm missing ?
I think we'd just use:
     $(cacheEntry.rowNode).remove();

Or - I'm thinking about removal of the element in an asynchronous fashion, similar to its original post-render instantiation - we'd use (this is a simplified version):
     $(cacheEntry.rowNode).detach();
     setTimeout(function(){ $(cacheEntry.rowNode).remove(); }, 100);

(no need to mod your pull request, I'm formulating an API for my fork to queue the asynchronous cleanup of nodes. I'm just new to this kind of memory leak in jQuery)

It's worth noting that empty() or remove() both create the performance drag that was the subject of conversation in #855, so there's a trade-off here.

I've not moved our codebase over to your fork yet btw, but I am considering doing so, and I appreciate that you're keeping the project alive.

Yes, the approach I've decided would be best, after much thought , is:

global flag EnableCelljQueryCleanup and cellCleanupDelay
nodesForCleanup array variable
whenever DOM nodes are removed, check to see if they have been post processed, and if so, detach them, add them to the nodesForCleanup array and fire the cleanup function (if not post processed, they can just be deleted as usual)
the cleanup function removes a single row's cells and re-calls itself after the given delay, just like the asyncpostrender master function

Re your codebase, I realise that once your own codebase has diverged, it can be difficult to apply the changes made to the original root. To that effect, I have offered discrete patches for most of the non trivial bug fixes. How have you found that? Are there any issue I should consider to make it easier for you?
Thanks for the feedback so far.

That cleanup approach sounds pretty good to me.  Discrete patches will probably help make this a little more manageable, but ultimately our copy of the code hasn't diverged that much from master, and now that you're maintaining your fork I should probably submit any changes we've made to you as patches as well - I just haven't been working on our project that uses slickgrid over the past few months, so it's just a prioritization issue for me to spend a day on this.

A patch for this issue has been added to the 'alternative master' repo. An example page demonstrating cleanup has been added to the repo. Any testing, particularly regarding memory leaks, is greatly appreciated.
Repo: https://github.com/6pac/SlickGrid
Blog post: http://low-bandwidth.blogspot.com.au/2015/06/slickgrid-async-post-render-cleanup.html
I haven't tagged this commit as the next release yet, just waiting for this commit to settle.

authors: 6pac SimonBrangwin froodian

repo: mleibman/SlickGrid


text:
Add a switch to zip files instead of always zipping...

I want to keep my NoNpDrm dumps as one file. It's easier to manage storage this way. It's also faster to copy it around, instead of sometimes hundreds if not thousands of small files. And it gives you automatic checksums, so you can later detect if file is corrupted. Zip file it creates is not compressed, it uses "store" method, because almost all files are encrypted anyway  so there is no performance penalty of creating zip file - only advantages (performance, checksums, accidentally deleting some files).

yeah, but this way it's the same as the vpk which will take double space when transferring and installing it in PSVita, also each PKG has it's own sha1 checksum so you can check if it's corrupted.
Thx for the tool :)

Why not creat a simply folder of game without zip file ?

@alpakeno You don't need to transfer zip file. Open it up in your favorite archiver program, or even Windows Explorer, and then drag&drop files to connected Vita device. Or if you use command-line - cd to vita drive/mounted folder and execute "unzip path/to/file.zip".
Yes, pkg has checksum, but after it is unpacked, there are not checksum.
@chronoss09 because of reasons I mentioned above.

Ok thanks !

So one question: Does the tool create a zip file out of the pkg or does it extract the files in a folder atm? That‘s not clear to me.
And would it be ok for you (the creator) if i use the shell script to create a Gui Version for macOS? I can share it with you if you want to :)
Thanks in advice for an answer to my questions :)

It creates zip file out of files that are extracted from contents of pkg file. pkg itself doesn't contain zip file, although its structure is very similar to zip files.
How can you use shell script to create GUI? Do you mean TUI?
You can create whatever you want based on my tool, but I'm not sure if I want non-crossplatform code back in my repo...

license: unlicense


text:
Add kryptocheck to merchants file

Please open an issue as requested: https://github.com/monero-project/monero-site/issues/new?assignees=&labels=🏪+merchant%2C+🔍+Needs+investigation&template=new-merchant.md&title=Add+<NAME+OF+YOUR+BUSINESS>+to+the+list+of+merchants

@erciccione Okay, sry, did not know that.

repo: monero-project/monero-site


text:
reader: add ReadFiles method for consuming a slice of filepaths

Codecov Report

Merging #932 (c304f39) into master (47b96ff) will decrease coverage by 0.02%.
The diff coverage is 71.42%.

:exclamation: Current head c304f39 differs from pull request most recent head 7f1d116. Consider uploading reports for the commit 7f1d116 to get more accurate results

@@            Coverage Diff             @@
##           master     #932      +/-   ##
==========================================
- Coverage   91.78%   91.75%   -0.03%
==========================================
  Files          66       66
  Lines        5219     5226       +7
==========================================
+ Hits         4790     4795       +5
- Misses        260      261       +1
- Partials      169      170       +1

authors: adamdecaf codecov-commenter

repo: moov-io/ach


text:
Support for Android Ice Cream Sandwitch (4.0 - API 14)

Thanks. Still a bunch of documentation and stuff missing but I will update and do the rest..

authors: lvillani mosabua

repo: mosabua/maven-android-sdk-deployer


text:
Review and remove deprecations for 5.0

Keeping deprecated methods in SortedSet APIs to not introduce further breaking changes.


text:
Diagrama nuevos

Codecov Report

Merging #4 (5564e0e) into master (22dc3f6) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master       #4   +/-   ##
=========================================
  Coverage     20.00%   20.00%
  Complexity        2        2
=========================================
  Files             4        4
  Lines            20       20
=========================================
  Hits              4        4
  Misses           16       16

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 22dc3f6...5564e0e. Read the comment docs.

ok

authors: Andreskub codecov-commenter mpata2000


text:
Create scenic viewpoint symbol

@mtaylorlong already completed this! Organizing issues to keep artwork linked to specific releases moving forward.


text:
Add ability to edit showcase title/description

Coverage increased (+0.25%) to 94.76% when pulling 9bbc9189ab68642f8515ae2f056767f9d14b4662 on showcase-title into a8734a0f4453a71c5b7021c54cddcdda6be2792c on master.

authors: coveralls jaronkk

repo: ndlib/honeycomb


text:
Deployment na Heroku

Link to app https://place-x.herokuapp.com

authors: niemonie wzieba

repo: netguru-code-college/place-x


text:
Fix getTranslation method in trait to prevent loading translations for default locale

Closed #13

Closed #13

repo: nevadskiy/laravel-translatable


text:
Feat cc stop integration

Duplicate https://github.com/newrelic/infrastructure-agent/pull/186

repo: newrelic/infrastructure-agent


text:
Update year range to 2016

LGTM

repo: ng-bootstrap/core


text:
Remove redundant test

Originally OneStep2 made in2 dirty while OneStep made cat1 dirty. They became somewhat identical in 94f2fd0acff696458a0e08727e11060a5e02ea5a. Not sure what we should do here.

Until we figure this out, we should not remove the test. Feel free to open an issue though.

authors: jhasse jonesmz

repo: ninja-build/ninja


text:
animator not displayed in viewdidload

startAnimating(size, message: "", type: NVActivityIndicatorType(rawValue: NORMAL_SPINNER)!, color: THEME_COLOR,  backgroundColor: UIColor.white.withAlphaComponent(0.5))
I have Placed above code in viewdidload method of viewcontroller but indicator not displayd.

@bhaveshbc: What is the color of THEME_COLOR? Another thing is when stopAnimating is called?

@ninjaprox i'm experiencing that too

@kohdesmond: I tried with a simple setup in the example project as the following:
override func viewDidLoad() {
        super.viewDidLoad()

        startAnimating(CGSize(width: 80, height: 80), message: "", type: NVActivityIndicatorType(rawValue: 1)!, color: .red,  backgroundColor: UIColor.white.withAlphaComponent(0.5))

However, I know it seems too simple to reproduce the issue. An example with reproducible issue would be helpful to debug.

@ninjaprox thanks, i'm running 2 project and one of it with tabbar works fine.
the one i'm encountering issues was running with
pod 'SideMenu' as the slide menu, putting a delay seems to fix the issues

authors: bhaveshbc kohdesmond ninjaprox

repo: ninjaprox/NVActivityIndicatorView


text:
CSI::Plugins::OwaspZap - Fix enabled parameter bug in intercept method

sweet.


text:
Test

Also comments from github show up too

how do formatted comments
{
  perform: "?"
}

authors: Fluidbyte eanplatter

repo: node-modli/modli-dynamodb


text:
fix mqtt node on calling function done

Coverage decreased (-0.1%) to 88.233% when pulling 49b489f529e7dd83b023521e3ab9dc700eda7988 on marceloaqno:master into a457c06500f98f5a8d07495d02178ff2b42fa03c on node-red:master.

authors: coveralls marceloaqno

repo: node-red/node-red


text:
View a list of starred/favorited tracks

Pretty sure this is working how we want it now. Will open new tix for bugs.

repo: nprapps/austin


text:
Factlist: add support for emoji 😀

FYI the latest beta version of html2canvas supports emoji.  I've just tested using https://github.com/niklasvh/html2canvas/releases/tag/v0.5.0-beta4 and it seems to work.

authors: allank livlab

repo: nprapps/lunchbox


text:
Create ISSUE_TEMPLATE.md

👍  💯

👍

This is a great pull request!
One of the finest I have seen :shipit:

authors: Gward2489 kimberly-bird krysmathis


text:
Adding readme for the vsd-api-documentation repo

thank you!

authors: little-dude pdellaert

repo: nuagenetworks/vspkgenerator


text:
[T4A3][T10-B1]Liu Yuheng

@E0003705 Some comments added. Please close the PR after reading comments.


text:
Setup tests

See cypress.io

Les tests fonctionnels sont OK avec la CI et Cypress.
Pour un exemple, voir sylvainmetayer/agent-ready#22 et sylvainmetayer/agent-ready#21

@oRiamn Des tests débiles sont mis en place. J'ai laissé le fichier d'exemple dans cypress/example pour voir les possibilités offertes par l'outil

Eventuellement, parce que ça va être rapidement galère de relancer 50 fois le serveur node, je pose ça la, à voir https://github.com/remy/nodemon

repo: oRiamn/epsi-expert-system


text:
Translate "The Client" into Japanese

Thx!

authors: ShunsukeTadokoro ochrons

repo: ochrons/scalajs-spa-tutorial


text:
Mitaka nfp 07 april 2016

Changes are tested on 07 April 2016 branch. Merging this to main branch.

repo: oneconvergence/group-based-policy


text:
add validator apiClient

:+1:

authors: itkg-alavieille itkg-ngilain


text:
Code | Numeric Pattern 90

Please assign me this issue @aryashah2k

repo: openAOD/Python-PatternHouse


text:
Add bad skip messages for tests that need a proxy cert

I think you should check if the cert is valid instead of whether it has been created.

Sure but we don't have to hold back adding useful skip info to the test for that

authors: brianhlin matyasselmeci

repo: opensciencegrid/osg-test


text:
Test ignore

Codecov Report

Merging #29 (5e12850) into main (963f343) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main      #29   +/-   ##
=======================================
  Coverage   63.18%   63.18%
=======================================
  Files           7        7
  Lines         459      459
=======================================
  Hits          290      290
  Misses        136      136
  Partials       33       33

Impacted Files
Coverage Δ

pkg/cmd/pipelineascode/pipelineascode.go
21.15% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 963f343...5e12850. Read the comment docs.

authors: chmouel codecov-commenter

repo: openshift-pipelines/pipelines-as-code


text:
TestGrid: Simplify wording around release gating overrides

cc @bparees

repo: openshift/ci-docs


text:
Fix Links

/cherrypick op-0.7-master

repo: openshift/pipelines-docs


text:
Rm err get string table

See #1379

I'm happy to see this in preference to 1379, modulo style nits.

yeah, fixed those with an updated commit.  thanks.

+1 for merge after beta

merged, thanks.

authors: kaduk mattcaswell richsalz

repo: openssl/openssl


text:
Scraper/utrgv

@jodizzle I think I've fixed everything. How does it look now?

@jodizzle Oh, I see what you mean. I didn't notice that some of the PDFs weren't syllabi. I don't see a way to identify them from the results page, and the error page still returns a 200 status, so I'm not sure what we could do to avoid it at the scraper level.  Any ideas?

@HarrisonGregg I can imagine a couple elaborate things you could do – like elongating the callback process across a few more functions, visiting pages multiple times to check them, carrying around multiple response objects, that sort of thing – but those are probably more trouble than it's worth and would almost certainly end up being inefficient.  I think the best thing to do is probably leave an inline # NOTE: about it somewhere in the scraper and then maybe we can address it as a structural edge case later on.

authors: HarrisonGregg jodizzle

repo: opensyllabus/osp-scraper


text:
Update README.md

heya, any idea why this line was added? I'm about to remove it because it's causing issues for users.
the problem with it is that the Makefile isn't available at this stage since configure hasn't been run yet so it fails.
it's also not clear to me why a distclean is required after a fresh clone of the repo?

yea that's my mistake I didn't know that distclean isn't available at fresh install.
The line was added because many people faced the issue with lots of comments of incorrect installation or wrong datadir.
I think it's reasonable to add a comment to skip it on fresh install

authors: evrial missinglink

repo: openvenues/libpostal


text:
[PAXLOGGING-275] Log exception in FrameworkHandler

Thanks @joshiste for the PR. I tried backporting it to pax-logging-1.11.x branch, but there's different API used. Do you want it to be ported to 1.11.4 too (as https://ops4j1.jira.com/browse/PAXLOGGING-275 says?)

authors: grgrzybek joshiste


text:
Integrate JGroups cluster peer enhancements.

Not sure what's up with the hit in batched..
Before
Benchmark                                         Mode  Cnt      Score     Error  Units
SingleNodeBenchmark.requestThroughput            thrpt  100  63033.949 ± 646.801  ops/s
SingleNodeBenchmark.avgRequestTime_batched        avgt  100     13.905 ±   0.170  us/op
SingleNodeBenchmark.avgRequestTime_singleThread   avgt  100     30.291 ±   0.281  us/op

After
Benchmark                                         Mode  Cnt       Score      Error  Units
SingleNodeBenchmark.requestThroughput            thrpt  100  192216.205 ± 2304.724  ops/s
SingleNodeBenchmark.avgRequestTime_batched        avgt  100       5.375 ±    0.141  us/op
SingleNodeBenchmark.avgRequestTime_singleThread   avgt  100      37.554 ±    0.971  us/op

After a bit of digging batched suffers a performance hit when using the same executor service as execution, by using a different executor batched score is on par with the previous score.

Infinispan release with Jgroups fix should be cut this week, also requires further benchmarking.

@JoeHegarty ptal

repo: orbit/orbit


text:
Add filter|sort|page support to findRelatedRecords queries

This will be a really nice addition ❤

I had to change jsonapi source to emit several addToRelatedRecords operations instead of replaceRelatedRecordsOperation. Otherwise filtered out records will be removed from the relationship in memory and other syncing sources. I also had to change addToRelatedRecords operation on record-cache to be idempotent.

authors: dgeb tchak

repo: orbitjs/orbit


text:
missing schema when updating depth

Thanks for this PR. Would you have time to write a test for this?

added schema test.
Because https://github.com/sequelize/sequelize/pull/4939 , so will get a failed testing for now.

Thanks @devmark. Would you mind squashing it all to a single commit and then I'll have a look?
Also, I think the two lines:
sql = utils.replaceTableNames(sql, {through: hierarchy.through}, sequelize);
sql = utils.replaceTableNames(sql, {item: model}, sequelize);

could be combined into:
sql = utils.replaceTableNames(sql, {
    through: hierarchy.through,
    item: model
}, sequelize);

Hey @overlookmotel, I've also encountered the issues presented in this PR. It looks like there hasn't been any progress made on this for a while now, and since the issue mentioned in sequelize/sequelize#4939 has since been fixed, the tests may pass now. I can open up a new PR if necessary to get this merged in.

I just re-ran the tests on Travis with Sequelize v3.22.0. Tests still failing on Postgres. I haven't had time to look and see why.
I'm afraid I'm really tied up at the moment and am unlikely to be able to look at this in more detail for a week or two at the earliest.

But if anyone can get to the bottom of the failing test, that would certainly help...

will take a look soon

Finally got around to fixing this. It's in v0.6.0.
The problem was actually really simple - bug in Sequelize v2 with .destroy( { truncate: true } ) not working with schemas.

authors: devmark overlookmotel teagup

repo: overlookmotel/sequelize-hierarchy


text: Add legend box

repo: oviohub/prism-frontend


text:
Adding an Auth Perm for getting Pipeline Logs

@actgardner I decided to go with the less invasive approach of checking auth within the GetLogs RPC instead of splitting it up into two RPCs. I don't love it but I think the less invasive option makes sense in this case. Let me know if you think differently

repo: pachyderm/pachyderm


text:
Add ContentExperiment support

LGTM

authors: jeffkaufman oschaaf


text:
Implement Data delete API

Closed with merge of write-api branch.

repo: pandaproject/panda


text:
SERVO_OUTPUT_RAW only display the first 8 channels

This should be fixed in rust-mavlink: https://github.com/mavlink/rust-mavlink/issues/57

Moving to emit-extension feature fix the problem: dc88d4ae259bd3c9366a592bae7b351d5ec88d4e

It appears to be a problem with rust-mavlink: https://github.com/mavlink/rust-mavlink/issues/61

Fixed with  71fb896


text:
fix: update xmldom

:tada: This PR is included in version 7.0.4 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

repo: patrickmichalina/camera-probe


text:
deps: Bump peaceiris/hugo-mod-mathjax from 0.1.2 to 0.1.3

https://608386e83bb13c5f1f6eb262--hugo-theme-iris.netlify.app/posts/math/

repo: peaceiris/hugo-theme-iris


text:
Clean up documentation

Thank you Karl :)

No problem, thanks for the project!

authors: karlhorky meaku

repo: peerigon/erroz


text:
[PDI-14925] Add Log4JDBC

Base build failed with return code 1

Last chance to follow the new component process, or I'll kill the PR ... ;)

authors: matthewtckr mbatchelor wingman-pentaho

repo: pentaho/pentaho-kettle