text:
Bug when using rr with babel-plugin-transform-remove-prop-types

Due to this line: https://github.com/ReactTraining/react-router/blob/389df9c0ba603b758de4a979a34ee10276f9a8d0/modules/Router.js#L135
I got around this in another library I maintain by requiring that defaultProps be set for each propType and then doing what you're doing with defaultProps instead.

What error are you getting? That the propTypes don't exist or aren't an object?
Honestly, I'm not sure if this is our responsibility though. That plugin isn't super-common to be used and is something outside of this library that's interfering. Also, it isn't supposed to run on node_modules, just your own code.

That's a good point @timdorr, I raised an issue against the plugin: https://github.com/oliviertassinari/babel-plugin-transform-react-remove-prop-types/issues/82

Looks like this is more on bptrrpt (™!) to provide some sort of fix for. I'm happy to add in some small guard comments or some other indicator that it should ignore that line of code, but this isn't a "React Router problem" per se. So, closing this one out. Thanks for bringing it up, @yaycmyk!

authors: timdorr yaycmyk

repo: ReactTraining/react-router


text:
Refactor - Link.js -  {...props} to {...rest}

rename ...props on Link.js to ...rest - same naming convention used on NavLink.js. renaming for consistency.
also refactored   proptypes.

Thanks!

source: gharchive/pull-request

authors: alireza-mh timdorr

license: mit

license_type: permissive

license_source: bigquery


text:
Upgrading to rxjs 6.2.1 creates a typing issue

Bug Report
Current Behavior
A clear and concise description of the behavior.
ERROR in node_modules/atlas-client-web/node_modules/rxjs/internal/symbol/observable.d.ts(4,9): error TS2687: All declarations of 'observable' must have identical modifiers.
src/app/activity-query.ts(58,35): error TS2345: Argument of type 'MonoTypeOperatorFunction<any>' is not assignable to parameter of type 'OperatorFunction<any, any>'.
  Types of parameters 'source' and 'source' are incompatible.
    Type 'Observable<any>' is not assignable to type 'Observable<any>'. Two different types with this name exist, but they are unrelated.
      Types of property 'source' are incompatible.
        Type 'Observable<any>' is not assignable to type 'Observable<any>'. Two different types with this name exist, but they are unrelated.

Here is the code that is causing the problem:
      this.activitiesRefresh.pipe(takeUntil(done))
        .subscribe(() => { /* ... */    });

activitiesRefresh is a Subject<any>, imported from 'rxjs'. takeUntil is imported from 'rxjs/operators'.
This issue does not happen with rxjs 6.2.0.
Environment

Runtime: [e.g. Node v${x}, Chrome v${x}]
RxJS version:
(If bug is related) Loader, build configuration: [e.g webpack, angular-cli version, config]

Node: 8.11.1
rxjs: 6.2.1 (no rxjs-compat)
@types/node: 8.10.18

Possible Solution

Additional context/Screenshots
Add any other context about the problem here. If applicable, add screenshots to help explain.

Two different types with this name exist, but they are unrelated.

That sounds like there are multiple versions of rxjs in node_modules.
Run this command to see what's in there:
npm list rxjs

Here's the output of yarn list rxjs:
├─ @angular-devkit/architect@0.6.8
│  └─ rxjs@6.2.0
├─ @angular-devkit/build-angular@0.6.8
│  └─ rxjs@6.2.0
├─ @angular-devkit/core@0.6.8
│  └─ rxjs@6.2.0
├─ @angular-devkit/schematics@0.6.8
│  └─ rxjs@6.2.0
├─ @angular/cli@6.0.8
│  └─ rxjs@6.2.0
├─ @schematics/update@0.6.8
│  └─ rxjs@6.2.0
├─ atlas-client-web@1.0.0-alpha.38
│  └─ rxjs@6.2.0
└─ rxjs@6.2.1

It does seem odd that 6.2.0 and 6.2.1 are both present. Not sure why that is.

Any update on this. I have only one version of RxJs I still get the same errror.

I'm getting this error with a project structure where I'm sharing model files between two sub-projects within one project:
Type
    'import(".../bar/node_modules/rxjs/internal/Observable").Observable<any>'
is not assignable to type
    'import(".../foo/node_modules/rxjs/internal/Observable").Observable<any>'.
          Types of property 'operator' are incompatible.

Where my folder structure is like
project
└ foo
    └ node_modules
    └ models
└ bar
    └ node_modules

Where in the bar project, I import models from foo using relative paths, i.e. ../foo/models/example-model.ts

source: gharchive/issue

authors: CoreyCole cartant fr0 rewathkafley

repo: ReactiveX/rxjs

license_source: github-api


text:
feat(bindNodeCallback): remove resultSelector

Removes the optional result selector to simplify the API

BREAKING CHANGE: resultSelector removed, use map instead: bindNodeCallback(fn1, fn2)() becomes bindNodeCallback(fn1)().pipe(map(fn2))

Coverage decreased (-0.005%) to 97.549% when pulling 26e6e5c59d1010fd2dacd4b6bf5fcfc65bae29eb on benlesh:remove-resultSelector-from-bindNodeCallback into 0a3a04a1532fff84407b4bceb86d19f2e9ef05af on ReactiveX:master.

authors: benlesh coveralls


text:
Use codecov with '-X xcodeplist' option

codecov-bash has changed its behavior from https://github.com/codecov/codecov-bash/commit/c90a47936d8de4db33047c1193a0bf649d00e363 so the coverage files are not being processed for a while.
https://github.com/codecov/codecov-bash/pull/73
Coverage report of this commits can be found at: https://codecov.io/gh/ReactorKit/ReactorKit/commit/7726f4dbbc74f8f26dc6cd3aa3487d6b588f13e3

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@96eb330). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #39   +/-   ##
=========================================
  Coverage          ?   89.18%
=========================================
  Files             ?        5
  Lines             ?      148
  Branches          ?       21
=========================================
  Hits              ?      132
  Misses            ?       15
  Partials          ?        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96eb330...7726f4d. Read the comment docs.

authors: codecov-io devxoul

repo: ReactorKit/ReactorKit


text:
Upgrade RN version from 0.71.1 to 0.71.5

Description:
Basically the title. It behoves us to keep the upgrading the RN version of the app constantly. Otherwise, it will be rendered incompatible and upgrading might become exponentially difficult.

https://github.com/Real-Dev-Squad/CalendarMobile/pull/15

repo: Real-Dev-Squad/CalendarMobile

license: MIT


text:
Necessary Firestore Indexes.

1
CollectionId
chaincodes
Fields indexed
userId Ascending
timestamp Descending
2
CollectionId
profileDiffs
Fields indexed
approval Ascending
userId Ascending
timestamp Descending

Thank you! Done ✅

collection
tasks
fields

assignee | Ascending

id | Ascending

status | Ascending

taskLevel.category |  Ascending

taskLevel.level |  Ascending

authors: ankushdharkar vinayak-trivedi

repo: Real-Dev-Squad/identity-service


text:
Create dateTime util function to convert epoch seconds to milliseconds

Create dateTime util function to convert epoch seconds to milliseconds
for fromNowStartedOn and fromNowEndsOn in src/components/tasks/card/index.tsx and src/components/pullRequests/index.tsx.

@palakgupta2712 I would like to take this issue, please assign me

repo: Real-Dev-Squad/website-status


text:
openstack Horizon Web UI cannot be opened

Internal Server Error
The server encountered an internal error or misconfiguration and was unable to complete your request.
Please contact the server administrator at [no address given] to inform them of the time this error occurred, and the actions you performed just before this error.
More information about this error may be available in the server error log.

Solution is to log on to the controller host and change permissions on the horizon.log file. It is currently owned by root, hence not writable by apache
ssh into: controller-< YOUR ID >.rhpds.opentlc.com
as root: chown apache:apache  /var/log/containers/horizon/horizon.log
(no need to restart any service)

authors: xiyao-redhat-com zokahn


text:
CPOL-107 If user requests openapi.json, then send json.

Signed-off-by: Heiko W. Rupp hrupp@redhat.com
$ curl -i  http://localhost:8080/api/custom-policies/v1.0/openapi.json
Access-Control-Allow-Origin: *
Access-Control-Allow-Credentials: true
Access-Control-Allow-Methods: GET, HEAD, OPTIONS
Access-Control-Allow-Headers: Content-Type, Authorization
Access-Control-Max-Age: 86400
Content-Type: application/json;charset=UTF-8
content-length: 15066

{
  "openapi" : "3.0.1",
  "info" : {
    "title" : "Custom-Policies",
    "description" : "The API for Custom-Policies",
    "version" : "1.0"
  },
  "servers" : [ {

$ curl http://localhost:8080/api/custom-policies/v1.0/openapi.json | more
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 14666  100 14666    0     0   895k      0 --:--:-- --:--:-- --:--:--  895k
{
  "openapi" : "3.0.1",
  "info" : {
    "title" : "Custom-Policies",
    "description" : "The API for Custom-Policies",
    "version" : "1.0"
  },
  "servers" : [ {
    "url" : "https://cloud.redhat.com",
    "description" : "Production Server",
    "variables" : {
      "basePath" : {
        "default" : "/api/custom-policies/v1.0"
 // ...

authors: josejulio pilhuhn


text:
image-sets-view: fixes sort dates and images latest status.

Fixes THEEDGE-1553
Type of change
What is it?

[X] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Documentation update
[ ] Tests update
[ ] Refactor

Checklist:

[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] I have added tests that prove my fix is effective or that my feature works
[X] New and existing unit tests pass locally with my changes
[X] I run make pre-commit to check fmt/vet/lint/test-no-fdo

/lgtm

repo: RedHatInsights/edge-api


text:
added auth modal for unauth users

Description
Added auth modal for unath users
Fixes # (issue)
Type of change
What is it?

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Documentation update
[ ] Tests update

Checklist:

[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] I run npm run lint:js:fix to check that my code is properly formatted

Codecov Report

Merging #420 (c8b1634) into master (2db3c6f) will decrease coverage by 1.56%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #420      +/-   ##
==========================================
- Coverage   33.38%   31.81%   -1.57%
==========================================
  Files         122      123       +1
  Lines        2702     2722      +20
  Branches      789      790       +1
==========================================
- Hits          902      866      -36
- Misses       1641     1696      +55
- Partials      159      160       +1

Impacted Files
Coverage Δ

src/App.js
0.00% <0.00%> (ø)

src/components/AuthModal.js
0.00% <0.00%> (ø)

src/components/BuildModalReview.js
0.00% <0.00%> (-100.00%)
:arrow_down:

src/Routes/Devices/UpdateDeviceModal.js
0.00% <0.00%> (-68.58%)
:arrow_down:

src/components/Modal.js
14.28% <0.00%> (-42.86%)
:arrow_down:

src/hooks/useApi.js
68.18% <0.00%> (-4.55%)
:arrow_down:

src/Routes/Repositories/RepositoryTable.js
73.33% <0.00%> (-3.59%)
:arrow_down:

src/Routes/GroupsDetail/GroupsDetail.js
42.10% <0.00%> (-1.49%)
:arrow_down:

src/Routes/Groups/GroupTable.js
27.08% <0.00%> (-0.58%)
:arrow_down:

src/components/general-table/GeneralTable.js
67.11% <0.00%> (-0.22%)
:arrow_down:

... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2db3c6f...c8b1634. Read the comment docs.

authors: codecov-commenter resoluteCoder

repo: RedHatInsights/edge-frontend


text:
Adds shellcheck to pre-commit

Secure Coding Practices Checklist Link

https://github.com/RedHatInsights/secure-coding-checklist

Secure Coding Checklist

[ ] Input Validation
[ ] Output Encoding
[ ] Authentication and Password Management
[ ] Session Management
[ ] Access Control
[ ] Cryptographic Practices
[ ] Error Handling and Logging
[ ] Data Protection
[ ] Communication Security
[ ] System Configuration
[ ] Database Security
[ ] File Management
[ ] Memory Management
[x] General Coding Practices

Codecov Report
Patch coverage: 67.86% and project coverage change: +22.80 :tada:

Comparison is base (209c0c9) 50.14% compared to head (a414a1b) 72.94%.

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #313       +/-   ##
===========================================
+ Coverage   50.14%   72.94%   +22.80%
===========================================
  Files          13       25       +12
  Lines         357      743      +386
===========================================
+ Hits          179      542      +363
- Misses        178      201       +23

Impacted Files
Coverage Δ

clean_expired_records.py
0.00% <0.00%> (ø)

historical_system_profiles/mgmt_views/v0.py
100.00% <ø> (ø)

kafka_listener.py
0.00% <0.00%> (ø)

standalone_flask_server.py
0.00% <ø> (ø)

wsgi.py
0.00% <ø> (ø)

..._system_profiles/notification_service_interface.py
35.00% <35.00%> (ø)

...ical_system_profiles/baseline_service_interface.py
39.13% <39.13%> (ø)

historical_system_profiles/archiver.py
55.05% <54.41%> (+55.05%)
:arrow_up:

historical_system_profiles/config.py
66.66% <60.00%> (-27.28%)
:arrow_down:

...torical_system_profiles/drift_service_interface.py
66.66% <66.66%> (ø)

... and 14 more

... and 3 files with indirect coverage changes
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

merging as this does not influence the app in any way

authors: codecov-commenter petrblaho


text:
[CCXDEV-10346] Revert "log a test error so that we can check glitchtip works (#197)"

Description
This reverts commit 3e56e574de80f3bf50a19809f30ce009fb43035a.
I already checked in stage and prod so this is not needed anymore.
Type of change
Logging.
Testing steps
Stage and prod.
Checklist

[ ] make before_commit passes
[ ] updated documentation wherever necessary
[ ] added or modified tests if necessary
[ ] updated schemas and validators in insights-data-schemas in case of input/output change

Codecov Report
Patch coverage has no change and project coverage change: +0.06 :tada:

Comparison is base (3e56e57) 57.47% compared to head (a496b00) 57.54%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #198      +/-   ##
==========================================
+ Coverage   57.47%   57.54%   +0.06%
==========================================
  Files           7        7
  Lines         856      855       -1
==========================================
  Hits          492      492
+ Misses        326      325       -1
  Partials       38       38

Impacted Files
Coverage Δ

exporter.go
38.46% <ø> (+0.12%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

authors: codecov-commenter juandspy


text:
prettify (wow!)

@david-christiansen look at this trick I learned! Before merging, I'll want to make this a non-default option in the mode, though.

What a kludge! Are you sure you want this in the mode, as opposed to the mode's documentation?

Also, (foo . (bar bz)) means the same thing as (foo bar baz).

What a kludge! Are you sure you want this in the mode, as opposed to the mode's documentation?

Ha, fair! I think this qualifies as the sort of weird hack that the total two people who would want this can just add to their own configurations...

:-)

authors: david-christiansen jonsterling

repo: RedPRL/sml-redprl


text:
UI is too woke and I can't handle it

Tested versions
First be a asshole and take peoples contributions and fucking ruin them.
System information
windows 11, god (im a pro christian)
Issue description
UI is too woke
Steps to reproduce
be a dick like the whole redot team
Minimal reproduction project (MRP)
hglp

Huh.

repo: Redot-Engine/redot-engine


text:
sub-category buttons' not working

When clicking on the sub-category "film" it does not go to "film"

Technical note:
=> issue with hashlink (verify HashLinkis correctly used)

authors: Lauraillouz Margaaux


text:
Gridlines are not available as an option.

Added in the horizontal and vertical line options to make gridlines
available as they are in the Chart.js library.

Just tested this PR and it works as expected - finally horizontal lines

Big thanks to @Vulpenox!

authors: Regaddi Vulpenox jantimon


text:
Request: add giscuss

add giscuss please.. https://giscus.app/

Hi! vuepress-plugin-giscus for Vuepress 2 is avaliable on npm, it can be installed by:
yarn add vuepress-plugin-giscus@next

Also see here for its source code and documentation.
However, as for now, there is no plan to support Vuepress 1 due to my limit time (I'm now working on moving theme Gungnir to Vuepress 2, see here for progress), but prs are welcome!

authors: Renovamen banghasan

repo: Renovamen/vuepress-theme-gungnir


text:
Feature Request: Add sorting & advanced logic to table render

From: https://redcap.vanderbilt.edu/community/post.php?id=210654

Added support for table column sortBy and sortDesc in b4912c318c5f5fbf4e4ca485bdd6cc30b5daca57

Hello Ekin. Thanks so much for moving my request to github, and for doing this so quickly!
In terms of installing these updates, I'm just looking at the EM repository in REDCap and I am not seeing an update to download and install the upgraded module.
ON the repository it says the date of last upgrade was 2023-04-25:

I'm excited to start using your changes this but I can't seem to find them!
Thanks again,
-James

@James-Ducas
I have submitted a new release (v2.2.0) to the REDCap External Module Repository Submission. As soon as Vanderbilt checks and approves it will be available for public.
Please note that I cannot implement a filtering feature at the moment.

Hello @tertek
I have downloaded the newest version of your module and have ensured the most recent version is active:

I have found that now in element editor I can specify sorting:

However in testing this I have found that is isn't working:

As such, either I'm making a mistake or I don't think this is resolved. May you help me troubleshoot this? I'm really thankful that you've responded to my request but I'm not sure the update to the EM you have provided is answering my problem.
Thanks!
-James Ducas

@James-Ducas I have applied your setup but cannot confirm the issue

Could you please tell the REDCap Version you are using and check the JavaScript Console for error messages?

Thanks @tertek
I am running REDCap 13.1.37
I do see a posisble issue in my browser console. I am running Google Chrome:

Here is what I get under Firefox:

I hope this helps solve the issue!

@James-Ducas These warnings are not related to the issue (I am having them too). Unfortunately, I cannot tell why you are having the issue. Can you replicate the issue on another REDCap instance? Have you tried in another simple project?

@James-Ducas These warnings are not related to the issue (I am having them too). Unfortunately, I cannot tell why you are having the issue. Can you replicate the issue on another REDCap instance? Have you tried in another simple project?

@James-Ducas These warnings are not related to the issue (I am having them too). Unfortunately, I cannot tell why you are having the issue. Can you replicate the issue on another REDCap instance? Have you tried in another simple project?

@James-Ducas These warnings are not related to the issue (I am having them too). Unfortunately, I cannot tell why you are having the issue. Can you replicate the issue on another REDCap instance? Have you tried in another simple project?

Hi @tertek
I have created a simple test project, which is just a single repeating form with a few fields:

I created six instances of that repeating form and configured the module as follows:

Now when I go to that record home page, I find that the table is appropriately sorted:

However I noticed that the field I'm trying to sort on in my real project is a date/time field. I thought maybe it has to be a date field without time? I created a text field that would just use @CALCTEXT to extract the date from the date/time field. I then sorted on the basis of this:

But I found it wasn't sorting as expected:

So it seems to be working on my simple test project, but my real project appears to be breaking it... Any thoughts?
Would you like an .XML export of my real project to test it on your end?

@James-Ducas thank you for the report. I will look into it coming week

I created a text field that would just use @CALCTEXT to extract the date from the date/time field. I then sorted on the basis of this

@James-Ducas I have made another test:

[x] sorting for date validated fields works
[x] sorting for date time validated fields works

It seems like the problem is sourced in your @CALCTEXT. It may be that the sorting algorithm does not know how to handle the output of your calculation (maybe the calctext is a javascript on front-end rendering time) or it is a problem with the output (spaces in between that confuse the sorting).
This is why I would NOT recommend to use fields with calctext applied on them as a source for sorting. Instead sort over the original date or date/time field.

Hi again @tertek
I suspected that something might have gone wrong with the upgrade of the External Module as its configuration applied to existing projects. So I created a copy of the existing project and in the copy screen, I unchecked the box to copy external module configuration. And then I reconfigured the Dashboard as described above, and it worked:

I can't really explain why this worked, however this isn't the first time that the only way I could fix a misbehaving external module was to copy the project and reconfigure the module from scratch.
Maybe this can provide you some clues about what happened? I'm happy to rebuild my project however if this breaks again in the future reconfiguring the project after move to production could create some difficulties for me.
Thanks again,
-James

UPDATE
@tertek I continued re-building my project after making the above post and I found that after I added another one of my other repeating forms to the dashboard, the sorting functionality again broke for the other forms:

I then deleted the Child form from the dashboard and reloading the page. However the Appointment repeating form sorting also stopped working:

I'm confused! Any thoughts?
With kindness,
-James

@James-Ducas
Please check me post above, where I wrote

It seems like the problem is sourced in your @CALCTEXT. It may be that the sorting algorithm does not know how to handle the output of your calculation (maybe the calctext is a javascript on front-end rendering time) or it is a problem with the output (spaces in between that confuse the sorting).

I suppose the sorting works only if you use it on original time/date fields, not on calculated ones.
I have tested the above scenario and can not confirm a problem when adding multiple repeating forms.

@tertek Thanks again for following up. And thanks for re-iterating that point about the calctext tag. I didn't get the message the first time around! I guess I was engaging in some wishful thinking and target fixation, as I was intending on using the calctext tag to build a HTML link so the user would be able to directly navigate to the page in question. It was set up so they can click the date/time of appointment and be brought to the correct page.
However, I found that if I do this 'calctext link building' on another field that isn't being sorted upon, it does work, so I moved the link from the Date/Time of appointment to the child ID and it works:

Maybe a nice feature to have for subsequent iterations of the External Module would be to designate a column for a button to link to the page of the instance? 😃

@James-Ducas Thank you for confirming the issue is related to the usage of a calctext that modifies date/time so that the sorting algo gets messed up.
I will close this then, since I am unable to implement a filtering feature at the moment.

Maybe a nice feature to have for subsequent iterations of the External Module would be to designate a column for a button to link to the page of the instance?
Hmm, true it would be nice to have access to the row's parameters to create custom links. Unfortunately, I am currently not available for this kind of work. But thank you for the idea, and if you like add it as a feature request.

authors: James-Ducas tertek


text:
Improper mobile positioning for Hub Select + various modal fixes

Various resolution-specific fixes for post modal
Bug: Hub Select has incorrect position in mobile
Updated HubSelect to be more mobile friendly

Before:
https://www.loom.com/share/cea35ba8291645df81940ab872f26ab2
After:
https://www.loom.com/share/eb3465116c074c058152fbdab6383c05

@manveerxyz yeah, the BaseModal needs to be refactored for sure

repo: ResearchHub/researchhub-web


text:
lectern still shows as before

The highlight shows the vanilla highlight

I just tested and it worked fine I would suggest checking your mods to make sure its not another mod screwing with it.

Found the mod. It was https://www.curseforge.com/minecraft/mc-mods/resourceful-lib

Though I don't know why I have it since none of my other mods require it as a dependency. I think it's caused by

Highlight API (Custom Selection boxes that are not bound to cubes)

that is this mods dependency its just inside of it

authors: Aces-and-Jacks ThatGravyBoat

repo: Resourceful-Bees/Highlight


text:
Stepper driver (2021-02-14)

Fixed power connections
Updated with split/cleaner powerstep01 symbol
Added limit switch filter and connector
Minor cleanups (changed LEDs from diode symbols to LED symbols, renamed ports from arduino-pin to functional names)
Actually, looks like I still need to add an output connector for the stepper motor...

Satisfies #733 / #773

Design checks out.  Approved.  Ok to defer connector selection to post-merge.  (We might want to consider dissimilar or combined connectors to prevent swapped mating of the two stepper motors, and this would need to be done at the upper level schematic hierarchy.)

Recommend either leave connector as is, or convert to hierarchical port.  Either way, I feel ok about the merge, as we can also do this at the schematic integration stage.

authors: dcstraney inceptionev

repo: RespiraWorks/Ventilator


text:
When only one player is allowed, the provided entity selector allows more than one.

For example, if I have a command like /bounty <target> <amount> with the code similar to this:
    @Command("bounty")
    public void onBountyCommand(Player sender, Player target, double amount) {
    }

It still suggests @a, @e, @n, @p, @r and upon for example trying to even type in /bounty @e it sends this error in console:
[17:55:18 ERROR]: Thread Async Tab Complete Thread - #0 failed main thread check: Chunk getEntities call
java.lang.Throwable: null
        at org.spigotmc.AsyncCatcher.catchOp(AsyncCatcher.java:14) ~[paper-1.21.1.jar:1.21.1-89-1ed64f8]
        at net.minecraft.server.level.ServerLevel.getEntities(ServerLevel.java:2384) ~[paper-1.21.1.jar:1.21.1-89-1ed64f8]
        at net.minecraft.server.level.ServerLevel.getEntities(ServerLevel.java:1413) ~[paper-1.21.1.jar:1.21.1-89-1ed64f8]
        at net.minecraft.commands.arguments.selector.EntitySelector.addEntities(EntitySelector.java:174) ~[paper-1.21.1.jar:1.21.1-89-1ed64f8]
        at net.minecraft.commands.arguments.selector.EntitySelector.findEntities(EntitySelector.java:158) ~[paper-1.21.1.jar:1.21.1-89-1ed64f8]
        at org.bukkit.craftbukkit.CraftServer.selectEntities(CraftServer.java:2927) ~[paper-1.21.1.jar:1.21.1-89-1ed64f8]
        at org.bukkit.Bukkit.selectEntities(Bukkit.java:2558) ~[paper-mojangapi-1.21.1-R0.1-SNAPSHOT.jar:?]
        at DufjiSMP-1.0.0-REL.jar/revxrsal.commands.bukkit.parameters.PlayerParameterType.fromSelector(PlayerParameterType.java:60) ~[DufjiSMP-1.0.0-REL.jar:?]
        at DufjiSMP-1.0.0-REL.jar/revxrsal.commands.bukkit.parameters.PlayerParameterType.parse(PlayerParameterType.java:81) ~[DufjiSMP-1.0.0-REL.jar:?]
        at DufjiSMP-1.0.0-REL.jar/revxrsal.commands.bukkit.parameters.PlayerParameterType.parse(PlayerParameterType.java:50) ~[DufjiSMP-1.0.0-REL.jar:?]
        at DufjiSMP-1.0.0-REL.jar/revxrsal.commands.node.parser.ParameterNodeImpl.parse(ParameterNodeImpl.java:122) ~[DufjiSMP-1.0.0-REL.jar:?]
        at DufjiSMP-1.0.0-REL.jar/revxrsal.commands.autocomplete.StandardAutoCompleter.complete(StandardAutoCompleter.java:147) ~[DufjiSMP-1.0.0-REL.jar:?]
        at DufjiSMP-1.0.0-REL.jar/revxrsal.commands.autocomplete.StandardAutoCompleter.complete(StandardAutoCompleter.java:100) ~[DufjiSMP-1.0.0-REL.jar:?]
        at DufjiSMP-1.0.0-REL.jar/revxrsal.commands.bukkit.listener.AsyncPaperTabListener.onAsyncTabComplete(AsyncPaperTabListener.java:62) ~[DufjiSMP-1.0.0-REL.jar:?]
        at com.destroystokyo.paper.event.executor.asm.generated.GeneratedEventExecutor8.execute(Unknown Source) ~[?:?]
        at org.bukkit.plugin.EventExecutor$2.execute(EventExecutor.java:77) ~[paper-mojangapi-1.21.1-R0.1-SNAPSHOT.jar:?]
        at co.aikar.timings.TimedEventExecutor.execute(TimedEventExecutor.java:80) ~[paper-mojangapi-1.21.1-R0.1-SNAPSHOT.jar:1.21.1-89-1ed64f8]
        at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.java:70) ~[paper-mojangapi-1.21.1-R0.1-SNAPSHOT.jar:?]
        at io.papermc.paper.plugin.manager.PaperEventManager.callEvent(PaperEventManager.java:54) ~[paper-1.21.1.jar:1.21.1-89-1ed64f8]
        at io.papermc.paper.plugin.manager.PaperPluginManagerImpl.callEvent(PaperPluginManagerImpl.java:131) ~[paper-1.21.1.jar:1.21.1-89-1ed64f8]
        at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.java:628) ~[paper-mojangapi-1.21.1-R0.1-SNAPSHOT.jar:?]
        at org.bukkit.event.Event.callEvent(Event.java:45) ~[paper-mojangapi-1.21.1-R0.1-SNAPSHOT.jar:?]
        at net.minecraft.server.network.ServerGamePacketListenerImpl.handleCustomCommandSuggestions0(ServerGamePacketListenerImpl.java:822) ~[paper-1.21.1.jar:1.21.1-89-1ed64f8]
        at net.minecraft.server.network.ServerGamePacketListenerImpl.lambda$handleCustomCommandSuggestions$1(ServerGamePacketListenerImpl.java:811) ~[paper-1.21.1.jar:1.21.1-89-1ed64f8]
        at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1144) ~[?:?]
        at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:642) ~[?:?]
        at java.base/java.lang.Thread.run(Thread.java:1583) ~[?:?]
[17:55:19 ERROR]: Thread Async Tab Complete Thread - #1 failed main thread check: Chunk getEntities call
java.lang.Throwable: null
        at org.spigotmc.AsyncCatcher.catchOp(AsyncCatcher.java:14) ~[paper-1.21.1.jar:1.21.1-89-1ed64f8]
        at net.minecraft.server.level.ServerLevel.getEntities(ServerLevel.java:2384) ~[paper-1.21.1.jar:1.21.1-89-1ed64f8]
        at net.minecraft.server.level.ServerLevel.getEntities(ServerLevel.java:1413) ~[paper-1.21.1.jar:1.21.1-89-1ed64f8]
        at net.minecraft.commands.arguments.selector.EntitySelector.addEntities(EntitySelector.java:174) ~[paper-1.21.1.jar:1.21.1-89-1ed64f8]
        at net.minecraft.commands.arguments.selector.EntitySelector.findEntities(EntitySelector.java:158) ~[paper-1.21.1.jar:1.21.1-89-1ed64f8]
        at org.bukkit.craftbukkit.CraftServer.selectEntities(CraftServer.java:2927) ~[paper-1.21.1.jar:1.21.1-89-1ed64f8]
        at org.bukkit.Bukkit.selectEntities(Bukkit.java:2558) ~[paper-mojangapi-1.21.1-R0.1-SNAPSHOT.jar:?]
        at DufjiSMP-1.0.0-REL.jar/revxrsal.commands.bukkit.parameters.PlayerParameterType.fromSelector(PlayerParameterType.java:60) ~[DufjiSMP-1.0.0-REL.jar:?]
        at DufjiSMP-1.0.0-REL.jar/revxrsal.commands.bukkit.parameters.PlayerParameterType.parse(PlayerParameterType.java:81) ~[DufjiSMP-1.0.0-REL.jar:?]
        at DufjiSMP-1.0.0-REL.jar/revxrsal.commands.bukkit.parameters.PlayerParameterType.parse(PlayerParameterType.java:50) ~[DufjiSMP-1.0.0-REL.jar:?]
        at DufjiSMP-1.0.0-REL.jar/revxrsal.commands.node.parser.ParameterNodeImpl.parse(ParameterNodeImpl.java:122) ~[DufjiSMP-1.0.0-REL.jar:?]
        at DufjiSMP-1.0.0-REL.jar/revxrsal.commands.autocomplete.StandardAutoCompleter.complete(StandardAutoCompleter.java:147) ~[DufjiSMP-1.0.0-REL.jar:?]
        at DufjiSMP-1.0.0-REL.jar/revxrsal.commands.autocomplete.StandardAutoCompleter.complete(StandardAutoCompleter.java:100) ~[DufjiSMP-1.0.0-REL.jar:?]
        at DufjiSMP-1.0.0-REL.jar/revxrsal.commands.bukkit.listener.AsyncPaperTabListener.onAsyncTabComplete(AsyncPaperTabListener.java:62) ~[DufjiSMP-1.0.0-REL.jar:?]
        at com.destroystokyo.paper.event.executor.asm.generated.GeneratedEventExecutor8.execute(Unknown Source) ~[?:?]
        at org.bukkit.plugin.EventExecutor$2.execute(EventExecutor.java:77) ~[paper-mojangapi-1.21.1-R0.1-SNAPSHOT.jar:?]
        at co.aikar.timings.TimedEventExecutor.execute(TimedEventExecutor.java:80) ~[paper-mojangapi-1.21.1-R0.1-SNAPSHOT.jar:1.21.1-89-1ed64f8]
        at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.java:70) ~[paper-mojangapi-1.21.1-R0.1-SNAPSHOT.jar:?]
        at io.papermc.paper.plugin.manager.PaperEventManager.callEvent(PaperEventManager.java:54) ~[paper-1.21.1.jar:1.21.1-89-1ed64f8]
        at io.papermc.paper.plugin.manager.PaperPluginManagerImpl.callEvent(PaperPluginManagerImpl.java:131) ~[paper-1.21.1.jar:1.21.1-89-1ed64f8]
        at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.java:628) ~[paper-mojangapi-1.21.1-R0.1-SNAPSHOT.jar:?]
        at org.bukkit.event.Event.callEvent(Event.java:45) ~[paper-mojangapi-1.21.1-R0.1-SNAPSHOT.jar:?]
        at net.minecraft.server.network.ServerGamePacketListenerImpl.handleCustomCommandSuggestions0(ServerGamePacketListenerImpl.java:822) ~[paper-1.21.1.jar:1.21.1-89-1ed64f8]
        at net.minecraft.server.network.ServerGamePacketListenerImpl.lambda$handleCustomCommandSuggestions$1(ServerGamePacketListenerImpl.java:811) ~[paper-1.21.1.jar:1.21.1-89-1ed64f8]
        at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1144) ~[?:?]
        at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:642) ~[?:?]
        at java.base/java.lang.Thread.run(Thread.java:1583) ~[?:?]

Then when sending the command, it sends out this error:
Only one player is allowed, but the provided selector allows more than one

Any idea on how to resolve this, or is this just a bug with Lamp?

I see. Sounds like a problem with asynchronous tab completion. You could disable it as following:
BukkitLampConfig config = BukkitLampConfig.builder(plugin).disableAsyncCompletion().build();
Lamp<BukkitCommandActor> lamp = BukkitLamp.builder(config).build();

Can you try it and let me know if it persists?

That does resolve the console error, but does not resolve the issue where it's suggesting using @a, @e, @n, @p, @r for a single player selector.

This is Brigadier's default behavior. @a and @e can be minimized using further selectors (i.e. limit=1 or d=2) to reduce to one player, and the client will display the input in red if it does not.
Do you want to remove them altogether? Either disable Brigadier through the BukkitLampConfig, or register a SuggestionProvider for the Player class. That will automatically remove the @a, @e, etc.

This is Brigadier's default behavior. @a and @e can be minimized using further selectors (i.e. limit=1 or d=2) to reduce to one player, and the client will display the input in red if it does not.
Do you want to remove them altogether? Either disable Brigadier through the BukkitLampConfig, or register a SuggestionProvider for the Player class. That will automatically remove the @a, @e, etc.

I'll do that and I'll share the code I make here, I think it's silly to suggest args that the user cannot use, but thanks for the help.

This is Brigadier's default behavior. @a and @e can be minimized using further selectors (i.e. limit=1 or d=2) to reduce to one player, and the client will display the input in red if it does not.
Do you want to remove them altogether? Either disable Brigadier through the BukkitLampConfig, or register a SuggestionProvider for the Player class. That will automatically remove the @a, @e, etc.

I'll do that and I'll share the code I make here, I think it's silly to suggest args that the user cannot use, but thanks for the help.

When you do this for your code, I would recommend adding a parameter that allows enabling/disabling them individually to make it more configurable.

Will close this as it is Brigadier's default behavior to allow this. It will show red and give an error if the selector does not reduce to a single entity/player.

authors: HyperSkys Revxrsal creatorfromhell

repo: Revxrsal/Lamp


text:
Feature: add access to shared iCloud libraries

A few notes:
ZGENERICASSET.ZCLOUDLOCALSTATE
ZCLOUDISMYASSET = 0 (not NULL) appears to be shared Photos not owned by me
photos appear to be /resources/cloudsharing/ when downloaded
directory is /resources/cloudsharing/data/
within folder for each shared album, there's an Info.plist with cloudOwnerEmail, CloudOwnerName, etc
e.g. /Users/rhet/Pictures/Photos Library.photoslibrary/resources/cloudsharing/data/146768460/8021C2B2-4D83-4A5D-924E-861071AB604A/Info.plist
ZCLOUDOWNERHASHEDPERSONID is not NULL if shared  <-- seems to be the most reliable indicator of shared photo
ZCLOUDPLACEHOLDERKIND = 2 if shared album, 5 if not? or could be 4?
ZLOCALRESOURCESSTATE = -1 if shared album?
ZSAVEDASSETTYPE = 4 if shared?
ZCLOUDFEEDASSETSENTRY = not NULL if shared?
Z_FOK_CLOUDFEEDASSETSENTRY = not NULL if shared?
ZCLOUDBATCHPUBLISHDATE not NULL if shared
ZMASTER = NULL if cloud
Have not been able to determine how to tell if file is downloaded without actually looking for the photo

Create test db for shared: create a test iCloud account with a test library then share it (need two accounts to share to each other).

v0.18.0 adds support for shared albums but only for Photos 5. I've not been able to figure out how to access shared albums in Photos <= 4

Need to add shared to PhotoInfo.json()

Hi RhetTbull, great enhancement, thanks. I was wondering if it would it be possible to not only support export of shared iCloud items but also those that are not shared but only residing on iCloud? Currently, a "Skipping missing photo" warning is given and when I download the photo (i.e. open it), the export succeeds.

@mwort — yes, I think this is possible. Issue #13 to add PhotoKit support would enable this. I’m stuck on one of the implementation details but will work as time permits. Currently, osxphotos reads the Photos library and can copy files already present on disk but doesn’t directly interact with Photos or PhotoKit (Apple’s approved programmatic interface to Photos).  Using PyObjC, I should be able to directly interact with Photos and request a copy of the original image which will force download. Another way to do this is call an AppleScript to force the export. That’s more clunky so I’d prefer to get a PhotoKit interface implemented.

Sounds good, I'm happy run tests.

@mwort I've added a "--download-missing" option to the command line export tool. Give it a try and see if this does what you need. I've not down a lot of testing yet but in initial testing, seems to work.  Note: current implementation uses applescript to interact with Photos so it will ask for permission to interact with Photos first time you run it  then Photos will stay in foreground while the script is running as it's constantly being hit by applescript to do the export.  Kind of klunky but until I can get a native PhotosKit version working this might do the trick.

Thanks @RhetTbull, that works for me. I encountered two smaller issues after upgrading to get this to work (apologies for not opening separate issues for that, just for you to consider):

got a TypeError: __init__() got an unexpected keyword argument 'hidden' error with click 6.7 installed, i.e. you might want to stipulate click>=7.0 in setup.py
for some reason none of the CLI commands worked before I had started Photos once, gave me a can't find library error, worked once it was started and even after I had closed it again (file access/permissions problem?)

@mwort Thanks for the feedback.  I updated setup.py to specify min required version of Click.
On the second point, I opened issue #54 as a new bug.  osxphotos reads the file ~/Library/Containers/com.apple.Photos/Data/Library/Preferences/com.apple.Photos.plist to find the last opened Photos library but this must have failed in your case.
Which OS are you running?  Also, had you previously opened Photos from that account or was this on a new machine? If you've got any other details to add, please add a comment on issue #54.  Thanks!

authors: RhetTbull mwort

repo: RhetTbull/osxphotos


text:
Add support for bing context.

WIthout this , copilot context seems to not work.
I think this was removed by mistake in the recent update.

@vaibhavard
I've sorted the arguments and merged them to be a bit clearer and less repetitive.
Using the context should work now, the logic for processing it is still there.

authors: Richard-Weiss vaibhavard

repo: Richard-Weiss/node-chatgpt-api


text:
CS0117 'JsonSchema' does not contain a definition for 'FromTypeAsync'

Trying to use the JSON schema generator using the example in the Readme.
Getting an error saying CS0117 'JsonSchema' does not contain a definition for 'FromTypeAsync', what am I missing?
I see no FromTypeAsync in the repo other than in the Readme and a test that is commented out.

It has been changed to FromType (non async), updated the docs.

authors: RicoSuter vladik-hbinov

repo: RicoSuter/NJsonSchema


text:
Client generated from API does not contain FileResponse

I tried generating a C# Winx64 Client from API located at https://developer.allegro.pl/swagger.yaml using NSwag GUI. No matter which generation mode I choose, I always get code which references FileResponse in one of the methods but there's no FileResponse class generated in the output. The offending API method /sale/dispute-attachments/{attachmentId} is described as returning type */*.

Is this related to form data?

I'm not sure how I should respond to this. The API is provided by third party, it does not designate usage case limits, my use case is backend application and the problem is with generating client from Swagger YAML that I am using to access this API.
Here's the excerpt generating FileResponse reference:
paths:
  '/sale/dispute-attachments/{attachmentId}':
    put:
      tags:
        - Disputes
      summary: "Upload a dispute message attachment"
      description: >-
        Upload a dispute message attachment.

        This operation should be used after creating an attachment declaration with *POST /sale/dispute-attachments*

        **Important!** You can find the URL address to upload the file to our server in the *Location* response header of *POST /sale/dispute-attachments*.
        The URL is unique and one-time. As its format may change in time, you should always use the address from the header.
        Do not compose the address on your own.

      operationId: uploadDisputeAttachmentUsingPUT
      parameters:
        - name: attachmentId
          in: path
          required: true
          description: Attachment identifier.
          schema:
            type: string
            format: uuid
      servers:
        - url: https://upload.{environment}
          variables:
            environment:
              default: allegro.pl
              enum:
                - allegro.pl
                - allegro.pl.allegrosandbox.pl
      responses:
        '201':
          description: File uploaded correctly
        '400':
          description: Syntactically incorrect request
        '401':
          description: Invalid or missing bearer token
        '413':
          description: File is too big
        '415':
          description: Unsupported media type
      requestBody:
        required: true
        content:
          image/png:
            schema:
              type: string
              format: binary
              description: File in a binary format
          image/gif:
            schema:
              type: string
              format: binary
              description: File in a binary format
          image/bmp:
            schema:
              type: string
              format: binary
              description: File in a binary format
          image/tiff:
            schema:
              type: string
              format: binary
              description: File in a binary format
          image/jpeg:
            schema:
              type: string
              format: binary
              description: File in a binary format
          application/pdf:
            schema:
              type: string
              format: binary
              description: File in a binary format
    get:
      tags:
        - Disputes
      summary: "Get an attachment"
      description: >-
        Use this resource to get an attachment. Read more.
      operationId: getAttachmentUsingGET
      parameters:
        - name: attachmentId
          in: path
          description: Attachment identifier.
          required: true
          schema:
            type: string
            format: uuid
      responses:
        '200':
          description: OK
          content:
            '*/*':
              schema:
                type: string
                format: binary
        '401':
          description: Unauthorized
        '403':
          description: Forbidden
        '404':
          description: Not Found

NSwag config
{
  "runtime": "WinX64",
  "defaultVariables": null,
  "documentGenerator": {
    "fromDocument": {
      "json": "...",
      "url": "https://developer.allegro.pl/swagger.yaml",
      "output": null
    }
  },
  "codeGenerators": {
    "openApiToCSharpClient": {
      "clientBaseClass": "BaseAllegroClient",
      "configurationClass": null,
      "generateClientClasses": true,
      "generateClientInterfaces": false,
      "clientBaseInterface": null,
      "injectHttpClient": true,
      "disposeHttpClient": true,
      "protectedMethods": [],
      "generateExceptionClasses": true,
      "exceptionClass": "{controller}ApiException",
      "wrapDtoExceptions": true,
      "useHttpClientCreationMethod": false,
      "httpClientType": "System.Net.Http.HttpClient",
      "useHttpRequestMessageCreationMethod": true,
      "useBaseUrl": false,
      "generateBaseUrlProperty": true,
      "generateSyncMethods": false,
      "exposeJsonSerializerSettings": true,
      "clientClassAccessModifier": "public",
      "typeAccessModifier": "public",
      "generateContractsOutput": false,
      "contractsNamespace": null,
      "contractsOutputFilePath": null,
      "parameterDateTimeFormat": "s",
      "parameterDateFormat": "yyyy-MM-dd",
      "generateUpdateJsonSerializerSettingsMethod": true,
      "useRequestAndResponseSerializationSettings": false,
      "serializeTypeInformation": false,
      "queryNullValue": "",
      "className": "Allegro{controller}Client",
      "operationGenerationMode": "SingleClientFromOperationId",
      "additionalNamespaceUsages": [],
      "additionalContractNamespaceUsages": [],
      "generateOptionalParameters": true,
      "generateJsonMethods": false,
      "enforceFlagEnums": false,
      "parameterArrayType": "System.Collections.Generic.IEnumerable",
      "parameterDictionaryType": "System.Collections.Generic.IDictionary",
      "responseArrayType": "System.Collections.Generic.ICollection",
      "responseDictionaryType": "System.Collections.Generic.IDictionary",
      "wrapResponses": true,
      "wrapResponseMethods": [],
      "generateResponseClasses": true,
      "responseClass": "{controller}Response",
      "namespace": "Allegro_Payout.Clients",
      "requiredPropertiesMustBeDefined": true,
      "dateType": "System.DateTimeOffset",
      "jsonConverters": null,
      "anyType": "object",
      "dateTimeType": "System.DateTimeOffset",
      "timeType": "System.TimeSpan",
      "timeSpanType": "System.TimeSpan",
      "arrayType": "System.Collections.Generic.ICollection",
      "arrayInstanceType": "System.Collections.ObjectModel.Collection",
      "dictionaryType": "System.Collections.Generic.IDictionary",
      "dictionaryInstanceType": "System.Collections.Generic.Dictionary",
      "arrayBaseType": "System.Collections.ObjectModel.Collection",
      "dictionaryBaseType": "System.Collections.Generic.Dictionary",
      "classStyle": "Poco",
      "generateDefaultValues": true,
      "generateDataAnnotations": true,
      "excludedTypeNames": [],
      "excludedParameterNames": [],
      "handleReferences": false,
      "generateImmutableArrayProperties": true,
      "generateImmutableDictionaryProperties": true,
      "jsonSerializerSettingsTransformationMethod": null,
      "inlineNamedArrays": false,
      "inlineNamedDictionaries": false,
      "inlineNamedTuples": true,
      "inlineNamedAny": false,
      "generateDtoTypes": true,
      "generateOptionalPropertiesAsNullable": true,
      "templateDirectory": null,
      "typeNameGeneratorType": null,
      "propertyNameGeneratorType": null,
      "enumNameGeneratorType": null,
      "serviceHost": null,
      "serviceSchemes": null,
      "output": "AllegroClient.cs"
    }
  }
}

Method generated from above request:
public async System.Threading.Tasks.Task<FileResponse> GetAttachmentUsingGETAsync(System.Guid attachmentId, System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken))

I encountered the same error, but for Typescript client

I had the same issue when used UseOneOfForPolymorphism method.

Any news on this?

repo: RicoSuter/NSwag


text:
Can NSwag handle binary content?

I'm trying to consume an API that has a particular endpoint defined as per the excerpt below (apologies if the terms are not the correct ones, I'm kind of new to this API consumption realm :))
    "/v1/secrets/{id}/fields/{slug}": {
      "get": {
        "tags": [
          "Secrets"
        ],
        "summary": "Get Secret Field",
        "description": "Get a secret data field",
        "operationId": "SecretsService_GetField",
        "produces": [
          "application/json",
          "application/octet-stream"
        ],
        "parameters": [
...
        ],
        "responses": {
          "200": {
            "description": "Secret field value. If the field is a file attachment, the content type will be `application/octet-stream` and the response body will be the file contents.",
            "schema": {
              "description": "String",
              "type": "string"
            }
          },
...
      },

I've trimmed most content to keep it simple but happy to add the whole thing back in if required.
For my use case I'm only calling this particular endpoint for binary content, so I tried removing the "application/json", line from the produces block and generate the code again but it still complains on runtime that it 'Could not deserialize the response body stream as System.String.
I've seen other issues with similar queries/bugs but they're also different, one's about handling text/plain responses, another one was a question about how to write the NSwag definition for binary content, so I was a bit reluctant to barge in those issues, and am wondering if I'm doing something wrong or if it is just the case that NSwag can't handle binary content responses and seems to always expect "application/json"?
If someone can clarify this for me so I know if I should keep at it or just try some other alternative, that would be awesome. If NSwag does NOT handle binary content replies, what would be a good alternative to consume this API?
Thanks in advance,
Fernando
P.S.: Forgot to mention, this happens even in the latest (13.15.7) version of NSwagStudio and I'm using C#, with the following settings (which work just fine for everything else in this webservice):
// Common settings:
//   Runtime: Default
//   Operation Generation Mode: MultipleClientsFromOperationId
//   Generate Optional Parameters: Checked
//   Inject HttpClient via constructor: Checked
//   Generate default values for properties: Checked

Hmm. I had a break of a few months whilst working on other things and now that I've picked this up again, I can see that there is no feedback at all. Also, from more googling, I found this other issue open over 3 years ago (https://github.com/RicoSuter/NSwag/issues/1824), so I guess my options are now clear, I need to find some other alternative to NSwag and start again... :(


text:
C# code generation with /GenerateBaseUrlProperty:false option is broken in v14.0.1

NSwag generates invalid C# code when /GenerateBaseUrlProperty:false option is used. It looks like it is a regression in v14.0.1 possibly caused by #4691
Here's a simple project which demonstrates the regression: GenerateBaseUrlPropertyFalse.zip. It will download and use example petstore OpenAPI document. Just run dotnet build.
It works with NSwag.ApiDescription.Client 13.20.0 and 14.0.0 but fails with 14.0.1
@paulomorgado

@olegd-superoffice, please, explain in what way it doesn't work.

@RicoSuter,
I think I'm getting something wrong here.
Is the _baseUrl field supposed to be used anywhere other than inside the BaseUrl property?
HasBaseUrl indicates that the base URL from the API definition is to be used, right?
UseBaseUrl indicates that a base URL should be used, right?
GenerateBaseUrlProperty indicates that a BaseUrl property is to be generated, right?
InjectHttpClient indicates that an HttpClient property is to be injected, right?
The difference between 14.0.1 and 14.0.0 and 13.20.0 is that 14.0.1 assigns the _baseUrl field without declaring it, but all versions use the baseUrl property without declaring it when /GenerateBaseUrlProperty:false is specified.
My reasoning how this should be is:

if UseBaseUrl is true, _baseUrl or BaseUrl should be used, depending on BaseUrl being generated or not.

Or always use BaseUrl and make it public only if /GenerateBaseUrlProperty:true.

if UseBaseUrl is true

if HasBaseUrl  is true , set either _baseUrl or BaseUrl to the sanitzed BaseUrl.

Or always use BaseUrl and make it public only if /GenerateBaseUrlProperty:true.

if HasBaseUrl  is false , add a baseUrl parameter to the constructor and set either _baseUrl or BaseUrl to the sanitzed BaseUrl.

Or always use BaseUrl and make it public only if /GenerateBaseUrlProperty:true.

Is that how it should be?

@RicoSuter,
Seems like the change is to never initialize the _baseUrlfield and initialize BaseUrl property instead.
And there's a breaking change for implementers of the BaseUrl property that need to provide a / terminated URL.

But why force implementers to provide a /terminated URL. This seems like a potential spot for bugs.
If the BaseUrl has a value, version 13.20 would check to see if it had a trailing / before concatenating with the rest of the URL and query strings.

I changed it as a performance optimization, but I'm rethinking it.

Should be fixed with this commit:
https://github.com/RicoSuter/NSwag/commit/be42e58d1e2f9c4e86b9c302b0c6e82cc5c36d45
Sorry for all the inconveniences...

@RicoSuter The 14.0.3 generated code is getting compiled without errors now but the logic of how
/GenerateBaseUrlProperty:false flag works is different now.

Up to (and including) 14.0.0 it meant that BaseUrl property was not generated but still was used and it was responsibility of base class to declare and assign a BaseUrl value (usually from configuration).
In 14.0.1 and 14.0.2 it was broken and code generated with /GenerateBaseUrlProperty:false flag didn't compile.
In 14.0.3 code is getting compiled again but works differently - BaseUrl property is not generated and is not used at all. Instead private string _baseUrl field is assigned from a host value defined in OpenAPI document. The only workaround I could find to change _baseUrl value is to put some weird logic into override of PrepareRequest method.

It looks like it is still a breaking change between 14.0.0 and 14.0.3.

I think I was addressing all issues with https://github.com/paulomorgado/NSwag/commit/744940b6c5b90a06c3c64f98e8ed247de34a5b26, but it's now failing this recently added test:
[Fact]
public async Task WhenUsingBaseUrl_ButNoProperty_ThenPropertyIsNotUsedAndFieldIsGenerated()
{
    // Arrange
    var swaggerGenerator = new WebApiOpenApiDocumentGenerator(new WebApiOpenApiDocumentGeneratorSettings
    {
        SchemaSettings = new NewtonsoftJsonSchemaGeneratorSettings()
    });
    var document = await swaggerGenerator.GenerateForControllerAsync<FooController>();
    var generator = new CSharpClientGenerator(document, new CSharpClientGeneratorSettings
    {
        UseBaseUrl = true,
        GenerateBaseUrlProperty = false
    });
    // Act
    var code = generator.GenerateFile();
    // Assert
    Assert.DoesNotContain("BaseUrl", code);
    Assert.Contains("string _baseUrl", code);
}

I still don't have a full grasp of the usage of -baseUrl and BaseUrl.

I can confirm the impact on my project as well.
My use case is:
useBaseUrl=true
generateBaseUrlProperty=false
I have a base class that implements BaseURL and return the urlto be used in urlBuilder but now it's ignored.
The proxy is using directly _baseUrl instead of BaseURL

I also have this problem. I cannot assign baseUrl in base class because generated classes use locally defined _baseUrl ignoring external settings.

For me, 14.0.1 works as expected using BaseUrl from the base class
14.0.2 works as long as the swagger.json does not have a BasePath.  If it has a BasePath I get a compile error because _baseUrl is not defined.
14.0.3 compiles, but the BasePath in the base class gets ignored, so things don't work.
I am running with UseBaseUrl = true and GenerateBaseUrlProperty = false.
For my application, I need to be able to set the base Url at run time, even if a Base Path is specified in swagger.json.  Is this going to be changed back so the base class can control the base Url, or do I need to find another way to do this?
For now I have to stay on 14.0.1
Thanks

14.0.7 still doesn't work.

When will this issue be fixed? The code should use the BaseUrl from the ClientBase instead of hardcoding the original URL in the _baseUrl. Please also revert the logic to trim a trailing '/'. As mentioned above, this potentially introduces bugs.

Any updates on the issue?

authors: RicoSuter Trapulo W0GER alexcheveau dreamofmaks franklixuefei olegd-superoffice patophasselt paulomorgado soligen2010


text:
App crash after hit any key

I tried to delete the settings (folder Documents\LeagueDirector), tried to connect another keyboard. The logs are empty.
Past topic: https://github.com/RiotGames/leaguedirector/issues/2
https://youtu.be/6pw-egk6Zr4
dmp-file: LeagueDirector.exe.9156.zip
leaguedirector.log

There may be a problem in Windows (use 8.1), and maybe in the fact that I have a laptop.
It is strange that the program crashes only after pressing the buttons. All other functions of the program work.
For example, if you launch a replay of a game with a program, it will work, and if you switch (Alt+TAB) in program, it immediately crashes.

Thanks for the report and yes it sounds like 8.1 is the problem here. I am going to close this issue however, because it is a duplicate of this: #7

authors: Serpic cammm

repo: RiotGames/leaguedirector


text:
How to change the background color?

Please provide you version information :

Dependency
Version

ionic2

angular

ionic-img-viewer

Have you checked...

[ ] That npm install returns no warning ?
[ ] Doing a purge of your node_modules folder ?

add
image-viewer{     ion-backdrop {         opacity: 0.95 !important;     } }
to your app.scss

authors: julesmorel peachapol

repo: Riron/ionic-img-viewer


text:
Feature: Mongo DB Schemas

Added User, Satellite, and Log DB schemas
Added endpoints to create and update user
Added endpoints to create satellite record
Created flow to view and edit user roles from the frontend
Created navbar

https://github.com/RishiVaya/Lower_Earth_Orbiters/assets/59628796/2c5a043c-8fd9-4499-bf2d-970e463fd11d

can we make the navbar and the table exist in dark mode/look slightly better lol

can we make the navbar and the table exist in dark mode/look slightly better lol

Done

authors: Umang-Rajkarnikar quinnha


text:
Query on CTSimSiam loss

Hi,
In your paper, you used $CT_{SimSiam}$ loss, but I could not find the implementation of it in your code, only $CT_{Barlow}$ loss is implemented. I could not reproduce the result for $CT_{SimSiam}$.

Hi,
Thank you bringing this to our notice. I will update the SimSiam code soon

Added the SimSiam Code. Sorry about the delay. Good luck.
I am closing the issue feel free to reopen if needed

repo: RishikeshMagar/Crystal-Twins


text:
Changed to use version 0.11.0 of purescript.

The steps outloined failed when I used the 0.9.1 image

Thanks for PR

authors: Risto-Stevcev srufle

repo: Risto-Stevcev/purescript-docker


text:
🛑 ai is down

In 761e5c6, ai (https://ai.sensoro.com/) was down:

HTTP code: 0
Response time: 0 ms

Resolved: ai is back up in eee3149.

repo: Roarain/upptime


text:
🛑 lins is down

In d313cc8, lins (https://lins.sensoro.com) was down:

HTTP code: 0
Response time: 0 ms

Resolved: lins is back up in a043676.


text:
Roaring64Bitmap.forInRange correctness issues

SUMMARY

Added test cases for the issues described in #577
Fixed a signed byte comparison that should have been unsigned in the two shuttle implementations of the trie.

This fixes #577
Automated Checks

[x] I have run ./gradlew test and made sure that my PR does not break any unit test.
[x] I have run ./gradlew checkstyleMain or the equivalent and corrected the formatting warnings reported.

@lemire Can you take a look at the fix? It's pretty straight forward...whoever decided that JVM languages don't get unsigned numerical primitives just caused a lot of developer pain :D
Also CI is repeatedly failing to fetch dependencies, apparently because the server is overloaded. I wonder if we could cache these in Github actions, so we don't have to flood the jfrog server as much?

On my desk

@lemire jmh dependencies still don't seem to be available. Not sure how long we want to wait? There is also a newer version of the plugin available (https://github.com/melix/jmh-gradle-plugin), but it requires a gradle update apparently. I know nothing about gradle, so this is kinda beyond my expertise.

I can take a look later today

I will let @richardstartin take a look and if we can't make progress or can't look, I will investigate.
Do not be concerned, we will resolve this issue.

@larsk-db thanks for spending your time fixing this. I fixed the dependency problem in #579 so if you rebase this will build and can be merged.

@larsk-db : I think we just need you to sync with our main branch to verify that everything is ready.

authors: larsk-db lemire richardstartin

repo: RoaringBitmap/RoaringBitmap


text:
Typing 0 in Currency does not work

If I have a text input with a number in it, set to currency mask, I cannot select all, then type 0 to set the value in the textbox to "0.00".  I have to hit backspace or delete to get "0.00".
Is this a known issue?

@SeanKendle ,
Which version do you use as I cannot reproduce

Sorry, I don't get any sort of email or notification when someone replies.  Did you fix this?

Version: 3.3.4-18

I see that there is a new version 4.x out, I'll try using that and report back in the next few days, very busy right now.

authors: RobinHerbots SeanKendle

repo: RobinHerbots/Inputmask


text:
May be issue with bower package - missing files

dist/inputmask/bindings and dist/inputmask/dependencyLibs directories are both empty when installing bower package.

@amosfolz ,
Aw, I will include the files for the next release.

How do I specify a wildcard for the dist folder and subfolders?
"ignore": [
"/*",
"!dist//*",
],

authors: RobinHerbots amosfolz


text:
Date Extension Year Range

Unable to implement this snippet from the readme regarding date extension:
$("#date").inputmask("date", {yearrange: { minyear: 1900, maxyear: 2000 }}); //specify year range
});
I would like to only use dates in the past ( Date of Birth )
When I input only 2 Digits for example 77 ( for 1977 ) it defaults to 2077.
is it possible for this to default to 19 Century before 20th century
Apologies if this is not the correct place for this comment its my first post on github.
Thanks

Hi Robin, I have the same issue and as I can see it has been resolved but I am using the latest version of Inputmask (ver 3.3.11) and i still have this issue. When I input only 2 Digits for example 78 ( for 1978 ) it defaults to 2078 . would you please help me to can i fix this one in new version? Thanks

authors: snshafiee telemetry


text:
🛑 Nextcloud is down

In 290070c, Nextcloud (https://cloud.craftingcomrades.net/) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Nextcloud is back up in f79ad00 after 10 hours, 52 minutes.

repo: RoblKyogre/uptime


text:
Sound StarterCharacterScript is needlessly insecure

For those who don't know, there is a property in the Sound object called "Playing", which can be used to toggle whether a sound is playing or not, as the name suggests. The reason I bring this up is because this Property is different from almost every other Roblox property in that it replicates to the server, that is it bypasses non-Experimental Mode. checks
This is a problem and has caused any game unaware of it to have an exploit where a hacker can repeatedly play every sound in the game over and over again, regardless of whether Experimental Mode is on or off. This has caused many developers, including me, to write our own sound systems that create sounds on the client rather than having them on the server at all.
The Sound StarterCharacterScript responsible for creating the sounds of a character (walking, jumping, dying, etc) problematically creates the sounds of the character on the server. This means any unaware developer will have this exploit used on their games with every sound a character could have be repeatedly played on loop. There is no reason for the sounds to be created on the server. LocalSound should be completely responsible for the playing and creating of sounds without any involvement of the server. This will solve the issue of the exploit (for character sounds at least) because all the sounds are created on the client, not on the server.
I can create this functionality as I already have done for my own game, but the main problem is backwards compatibility. I can assume some games rely on the sounds being created on the server, so the more secure character sound system will have to be enabled rather than be the default. Because of the limitations of CoreScripts (in this case, CoreScripts cannot create custom properties), it will have to be a dirty way to implement rather than a property as it should be. When I create my PR, if it gets approved I ask that it not be merged until Roblox creates a property on either SoundService or more accurately StarterPlayer to enable it. I think the way I am going to have it enabled is it will check if you have an object named "UseNewSoundSystem" in SoundService.

I believe this is resolved by setting Soundscape to "RespectFilteringEnabled"

That's a feature? I didn't know that. My bad.

repo: Roblox/Core-Scripts


text:
Fix imprecise return types for methods of TextService.

Fixed incorrect / unprecise return types.
Changes

Changed the return types of the two methods from Instance to TextFilterTranslatedResult and TextFilterResult respectively.

Checks
By submitting your pull request for review, you agree to the following:

[x] This contribution was created in whole or in part by me, and I have the right to submit it under the terms of this repository's open source licenses.
[x] I understand and agree that this contribution and a record of it are public, maintained indefinitely, and may be redistributed under the terms of this repository's open source licenses.
[x] To the best of my knowledge, all proposed changes are accurate.

Hello, thanks for the suggestion here. Just FYI, only summaries, descriptions, and deprecation messages can be changed for classes and enums through this workflow; all other changes will be automatically overwritten from the source. I have requested that these return types be updated at the source though, so once that is complete, they should update to something more specific than "Instance".

authors: Anto-fire IgnisRBX

repo: Roblox/creator-docs


text:
LUAFDN-491 connect should pass only innerProps

Closes #48

Coverage remained the same at 100.0% when pulling c198f1214d971249edaac9419e9cd68a5c71573f on fix-connect-map-state-to-props-call into 40877d3969fa46be021e88ba8405e32a340b59fc on master.

authors: coveralls oltrep

repo: Roblox/roact-rodux


text:
Add issue template

Can I make issue templates to enhance the workflow of the repository?

Yeah, sure you can. I think it would improve the experience. Keep us updated with your work here and feel free to ask any doubts.

Link to my pull request for fixing this issue: https://github.com/RoboticsClubIITJ/ML-DL-implementation/pull/87

repo: RoboticsClubIITJ/ML-DL-implementation


text:
Add /version endpoint

Let's add a /version endpoint to quickly identify the version which is deployed.

can we integrate the "version number" in the OpenAPI spec as well?

Yes, makes sense!

authors: defreng timofurrer

repo: Roche/foxops


text:
Add French and Some Hindi Translations

@RocketChat/android

Partial Fix #2128
Changes:
Add French and Hindi Translations

Merging this one @divyanshub024. Your suggestion was addressed. Thank you.

authors: filipedelimabrito theLimitBreaker


text:
[IMPROVEMENT] Optimize user experience

overview: hide keyboard when click blank
implement: check CurrentFocus, if the focus is not on EditText, hide keyboard.

@RocketChat/android

Closes #ISSUE_NUMBER

fix: overview: hide keyboard when click blank area.

@OrangeyYu Thanks for this but this PR is upon the legacy app (develop branch). Please use the develop-2x branch for any further PRs.

authors: OrangeyYu leonardoaramaki


text:
Download manager server filter duplicates server names

Describe the bug
The download manager server filter isn't useful. It contains the same server name multiple times in the filter.
What operating system and which version? macOS 11.4 (20F71)
Which version of Rocket.Chat (Server)? 3.18.0
Which version of Rocket.Chat.Electron (Electron/Desktop)? 3.5.6
Is there any setting relevant changed?
To Reproduce
Steps to reproduce the behavior:

Open download manager
Click on server dropdown

Expected behavior
Only one option per server should exist.
Screenshots

Hey @wreiske I think that this problem is fixed. Just tested and this doesn't happens. I will close the issue but if it persists please tell me to reopen it.

authors: jeanfbrito wreiske


text:
Bkup db upgrade

Signed-off-by: lucia.guevgeozian lucia.guevgeozian@rocket.chat
Added pre upgrade hooks to create a volume and back up mongodb data before switching from deployment to replicaset and therefore dropping the PVC with all the data.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.2 out of 42 committers have signed the CLA.:white_check_mark: nitisht:white_check_mark: LuluGO:x: steven-sheehy:x: alexvicegrab:x: ChiefAlexander:x: bitnami-bot:x: adharmawan:x: helgi:x: michaelbeaumont:x: mdonkers:x: cw-ozaki:x: jeff-knurek:x: s12chung:x: KIVagant:x: sebastien-prudhomme:x: YoussB:x: smcavallo:x: prateekpandey14:x: TristanPeers:x: tompscanlan:x: ElfoLiNk:x: LittleWhiteYA:x: tompizmor:x: ctrox:x: containscafeine:x: gouglhupf:x: rmb938:x: marc-sensenich:x: Ngob:x: okgolove:x: rverma-nikiai:x: asherf:x: startnow65:x: skalinets:x: kytart:x: denis111:x: davidkarlsen:x: someonegg:x: batazor:x: legal90:x: gocd-ci-user:x: mscbpiYou have signed the CLA already but the status is still pending? Let us recheck it.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.2 out of 39 committers have signed the CLA.:white_check_mark: nitisht:white_check_mark: LuluGO:x: bitnami-bot:x: adharmawan:x: helgi:x: michaelbeaumont:x: mdonkers:x: cw-ozaki:x: jeff-knurek:x: s12chung:x: KIVagant:x: sebastien-prudhomme:x: YoussB:x: smcavallo:x: prateekpandey14:x: TristanPeers:x: tompscanlan:x: ElfoLiNk:x: LittleWhiteYA:x: tompizmor:x: ctrox:x: containscafeine:x: gouglhupf:x: rmb938:x: marc-sensenich:x: Ngob:x: okgolove:x: rverma-nikiai:x: asherf:x: startnow65:x: skalinets:x: kytart:x: denis111:x: davidkarlsen:x: someonegg:x: batazor:x: legal90:x: gocd-ci-user:x: mscbpiYou have signed the CLA already but the status is still pending? Let us recheck it.

authors: CLAassistant LuluGO

repo: RocketChat/charts


text:
Vanish doesn't work

The build 547 fixed the console error but now vanish doesn't even work.  Rocket reports vanish mode is enabled but everyone can still see the player who used vanish.

True. Was walking around checking my server while in vanish mode, when a player started talking to me. He can see me! lol

I've uploaded a pull request for a fix for vanish.
https://github.com/RocketMod/Rocket.Unturned/pull/23/files

repo: RocketMod/Rocket


text:
Dependent Dynamic Fields

Description of issue
I didn't find anything in the documentation reporting about it, so I decided to create the issue. The use case would be as follows:
I have a question form and I would like new questions to appear if the user marks a specific answer.

Usage example
I have the following question:
Do you have a car?
a) Yes
b) No
If the user checks the option a (Yes), a new question would appear:
What color is it?
Answer: Blue
If the user selects option b (No), a new question would appear:
Do you want to buy one this year?
a) Yes
b) No
And so on ...
It would be fields that depend on answers to appear.

Hey @mateusc42,
Are you requesting a new feature or want to know how to get what you describe?

@carlosallexandre In fact I would like to know if there is a possibility to do this action today and if it exists, I would like an example.

@mateusc42,
You can do this with state. Maybe in the future we can have a custom hook useWatch (see the roadmap) that makes this easier. Later I will put a snippet of how you can do it.

@carlosallexandre,
UseWatch would be of great help in these features.
Thanks for the answer.

repo: Rocketseat/unform


text:
High memory usage

Hello,
During running some of my benchmarks for ratarmount, I noticed one of them failing with a 100GB .tar.xz test file. The memory usage increases while linearly while reading over the file and exceeded 33GB and which point it was killed by the OOM killer. It works with other compression backends, so I'm pretty sure the memory usage stems from python-xz. Do you have any idea from where it might originate from? I would have thought that you only need to story block and stream offsets, i.e., list of integers, which should be small.

Some code to reproduce the problem:
import resource
import sys
import time

import xz

if __name__ == '__main__':
    print("xz version:", xz.__version__)

    size = 0
    t0 = time.time()
    with xz.open(sys.argv[1], 'rb') as file:
        t1 = time.time()

        while True:
            readSize = len(file.read(32*1024*1024))
            if readSize == 0:
                break
            size += readSize

            if time.time() - t1 > 10:
                t1 = time.time()
                print(f"{t1 - t0:.0f}s {resource.getrusage(resource.RUSAGE_SELF).ru_maxrss // 1024} MiB RSS")

    t1 = time.time()
    print(f"Reading {size} B took: {t1-t0}s")

"""
base64 /dev/urandom | head -c $(( 4*1024*1024*1024  )) > large
xz -T 0 --keep large
xz -l large.xz
    Strms  Blocks   Compressed Uncompressed  Ratio  Check   Filename
        1     171  3.148,1 MiB  4.096,0 MiB  0,769  CRC64   large.xz
python3 decompress-xz.py large.xz

Output:
xz version: 0.2.0
10s 171 MiB RSS
21s 243 MiB RSS
31s 323 MiB RSS
41s 396 MiB RSS
51s 468 MiB RSS
61s 548 MiB RSS
71s 621 MiB RSS
82s 693 MiB RSS
92s 773 MiB RSS
102s 846 MiB RSS
112s 918 MiB RSS
123s 998 MiB RSS
133s 1071 MiB RSS
143s 1143 MiB RSS
153s 1223 MiB RSS
163s 1296 MiB RSS
174s 1368 MiB RSS
184s 1448 MiB RSS
Reading 4294967296 B took: 186.66424465179443s

I also tested 0.3.1 and it behaves the same.

Thank you for your report and the test case, I'm able to reproduce.
After some profiling, I can see that the LZMA decompressors (1 per block) are responsible for all that memory usage.
I see a quick but partial fix (case 1), and a more difficult fix (case2).

Case 1
When a LZMA block is fully read (i.e. last byte of that block is read), free the LZMA decompressor. To be honest, I'm surprised Python was not already doing it automatically.
This should have no side effect, and fix your test example.
Case 2
However, if partial reads are performed from many blocks, the issue would remain.
Imagine the following scenario:

read 1kb from block A
jump to block B, read 1kb
jump to where we were in block A, read next kb
jump to where we were in block B, read next kb
jump to where we were in block A, read next kb
etc.

In this scenario (continuous reads but alternating from two blocks), we would want the LZMA decompressors to stay in memory, otherwise reads will be done from the beginning of a block each time we switch block (which would be slower).
Imagine the same scenario with more than 2 alternating blocks.
We have a tradeoff between memory usage and speed to resume reading from the middle of a block.
Maybe I could draw a line at a an arbitrary number of LZMA decompressors (e.g. 8, but this would be parametrizable) and make sure that we delete LZMA decompressors (we would need to decide which ones to delete) so that no more than 8 are alive at any point in time.

My plan is to work on the first case by this weekend, and think about the second case after.
@mxmlnkn I'm afraid real-world use of ratarmount would hit the case 2, but maybe I'm wrong?
Also, I would appreciate any feedback for the case 2!

I think you are right. The second case isn't that abnormal and might happen with ratarmount depending on the usage of the mount point.
Maybe you can implement a kind of block cache to handle case 2 and still be memory-bound and fast in most cases. I.e., hold the last 10 (or any number) most recently used blocks and deallocate the LzmaDecompressor of any older one even if the end of the block was not reached.

I still don't understand while neither closing nor deleting the opened XZ file, doesn't free the memory in my test. I would have expected the memory to be freed after the with statement or at least after del file, which both don't seem to improve anything in my tests.

Maybe you can implement a kind of block cache to handle case 2 and still be memory-bound and fast in most cases. I.e., hold the last 10 (or any number) most recently used blocks and deallocate the LzmaDecompressor of any older one even if the end of the block was not reached.

This was a proposition I tried to make in my last message, but it may have not be written in the best way. In any case, if we both think that's a possible solution, it must be a good idea :wink:

I still don't understand while neither closing nor deleting the opened XZ file, doesn't free the memory in my test. I would have expected the memory to be freed after the with statement or at least after del file, which both don't seem to improve anything in my tests.

From my understanding, ru_maxrss gives the peak memory usage of the process, and in many cases will never decrease: https://unix.stackexchange.com/a/30941
Btw because of this writing tests targeting memory consumption is kind of hard :unamused:

Case 2 is not even about performance, it also still makes it possible to explode memory until the out-of-memory limit has been hit if all xz blocks are only partially read

yes exactly

Maybe you can implement a kind of block cache to handle case 2 and still be memory-bound and fast in most cases. I.e., hold the last 10 (or any number) most recently used blocks and deallocate the LzmaDecompressor of any older one even if the end of the block was not reached.

This was a proposition I tried to make in my last message, but it may have not be written in the best way. In any case, if we both think that's a possible solution, it must be a good idea :wink:

I still don't understand while neither closing nor deleting the opened XZ file, doesn't free the memory in my test. I would have expected the memory to be freed after the with statement or at least after del file, which both don't seem to improve anything in my tests.

From my understanding, ru_maxrss gives the peak memory usage of the process, and in many cases will never decrease: https://unix.stackexchange.com/a/30941
Btw because of this writing tests targeting memory consumption is kind of hard :unamused:

Case 2 is not even about performance, it also still makes it possible to explode memory until the out-of-memory limit has been hit if all xz blocks are only partially read

yes exactly

This was a proposition I tried to make in my last message, but it may have not be written in the best way. In any case, if we both think that's a possible solution, it must be a good idea wink

Ah, I see now. Yes, that seems like the way to go for me albeit it is complex.

From my understanding, ru_maxrss gives the peak memory usage of the process, and in many cases will never decrease: https://unix.stackexchange.com/a/30941

That is also how I understand it. But I am interested in the peak memory usage because that is what determines whether I am able to run the program or not with limited main memory. Even if it requires 500GB of RAM for only a second that still would lead to an out of memory kill (or hanging Linux if the OOM killer does not work).

This was a proposition I tried to make in my last message, but it may have not be written in the best way. In any case, if we both think that's a possible solution, it must be a good idea wink

Ah, I see now. Yes, that seems like the way to go for me albeit it is complex.

From my understanding, ru_maxrss gives the peak memory usage of the process, and in many cases will never decrease: https://unix.stackexchange.com/a/30941

That is also how I understand it. But I am interested in the peak memory usage because that is what determines whether I am able to run the program or not with limited main memory. Even if it requires 500GB of RAM for only a second that still would lead to an out of memory kill (or hanging Linux if the OOM killer does not work).

I've pushed some commits that provide a first implementation. Please note that I'm not sure about the exposed API of providing a custom strategy for freeing LZMA decompressors, and I have tests against memory requirements failing in some Python versions.
But the fix should be working as it is without any change needed in your code, could you try and see if it solves the issue on your 100Gb file?
pip install git+https://github.com/Rogdham/python-xz.git@68bb6a6b81de9a14ad67d3d59122c7307f0aab8b

I tried it with a smaller file for now but it seems to work. Thank you!
An API for a custom strategy for freeing looks good but also "difficult". Imho, the default version should behave sufficiently well, i.e. not run out of memory in any case, without any tuning necessary by the library user. But by itself, the strategy classes look good. If an abstract base class is provided, a developer could even write his own strategies as he requires, but that would definitely be something for power users. E.g., one strategy right off my mind would be "clear decompressors if free memory is below a threshold".

Thank you for all your feedback!
Fixed in version 0.4.0 :tada:

authors: Rogdham mxmlnkn

repo: Rogdham/python-xz


text:
the only annotation

mark a single subscript term

I now feel this is not necessary, because if you write X[1] * X[2] there is no need for an extra node marking this is an adaptive #sites like Only(X[1] * X[2]) just define X[1] * X[2] as adaptive #sites seems not ambiguous?


text:
Bot User can't connect to discord.

Hello, here's the problem, i followed the intro guide to discord.net but when i start the program (only the bot connection), exceptions are thrown and the bot is disconnected.
This is my code :
using System;
using System.Collections.Generic;
using System.Linq;
using System.Text;
using System.Threading.Tasks;
using Discord;
using Discord.WebSocket;

namespace VioletBot
{
    class Program
    {
        public static void Main(string[] args)
            => new Program().MainAsync().GetAwaiter().GetResult();

        public async Task MainAsync()
        {
            var client = new DiscordSocketClient();
            client.Log += Log;

            string token = "{MY_TOKEN}";
            await client.LoginAsync(TokenType.Bot, token);
            await client.StartAsync();

            await Task.Delay(-1);
        }

        private Task Log(LogMessage msg)
        {
            Console.WriteLine(msg.ToString());
            return Task.CompletedTask;
        }
    }
}

exceptions are thrown
But what exceptions? Those are important to know.

i fixed it ! Used .NET Core instead of .NET Standard.

@jairo127 Then close the issue


text:
Monster of the Week - Bugfix - Resolving Typo in CSS

Submission Checklist
Required

[x] The pull request title clearly contains the name of the sheet I am editing.
[x] The pull request title clearly states the type of change I am submitting (New Sheet/New Feature/Bugfix/etc.).
[x] The pull request makes changes to files in only one sub-folder.
[x] The pull request does not contain changes to any json files in the translations folder (translation.json is permitted)

Character Sheet Info Roll20 Internal Use only.


text:
[Warlock-polish-edition] Bugfix

Submission Checklist
Required

[x] The pull request title clearly contains the name of the sheet I am editing.
[x] The pull request title clearly states the type of change I am submitting (New Sheet/New Feature/Bugfix/etc.).
[x] The pull request makes changes to files in only one sub-folder.
[ ] The pull request does not contain changes to any json files in the translations folder (translation.json is permitted)

New Sheet Details

The name of this game is: <   >  (i.e. Dungeons & Dragons 5th Edition, The Dresden Files RPG)

The publisher of this game is: <   > (i.e. Wizards of the Coast, Evil Hat)

The name of this game system/family is: <   > (i.e. Dungeons & Dragons, FATE)

[ ] I have followed the Character Sheets Standards when building this sheet.

[ ] I have authorization from the game's publisher to make this an official sheet on Roll20 with their name attached.
[ ] This game is not a traditionally published game, but a copy of the game rules can be purchased/downloaded/found at: <   >
[ ] This sheet is for an unofficial fan game, modification to an existing game, or a homebrew system.

Changes / Description

Character Sheet Info Roll20 Internal Use only.


text:
Metal Adventure : Move img in Github

Fix
get img form github only.

With pleasure.
Thank for your reactivity too.

Hello @yuyuki
FYI, we received an email from Github about a possible security vulnerability in the repo related to package-lock.json in the Metal Adventures folder. We went ahead and remove a few of the files in that folder which I assume are part of your build process. This came up as part of our weekly code push so we may have removed more files than we need just to in order to facility the process. You could add back the .gitignore file but the gulpfile, package-lock, and package should probably be kept locally.
Let me know if you have any questions.
Thanks,
Cassie

Hi @clevett ,
Thank to advice me. I will remove from « Metal Adventures » all unnecessary files.

authors: clevett yuyuki


text:
[Warhammer 4e Character Sheet] Fixes & roll temp updates

Changes / Comments

Cleaned up roll template for critical roll text on casting and channelling to make it clearer that theses at happening.
PC & NPC Characteristic rolls now show success/failure message.
Added some further missing translation tags

Roll20 Requests
Comments are very helpful for reviewing the code changes. Please answer the relevant questions below in your comment.

[x] Does the pull request title have the sheet name(s)? Include each sheet name.
[ ] Is this a bug fix?
[ ] Does this add functional enhancements (new features or extending existing features) ?
[ ] Does this add or change functional aesthetics (such as layout or color scheme) ?
[ ] If changing or removing attributes, what steps have you taken, if any, to preserve player data ?
[ ] If this is a new sheet, did you follow Building Character Sheets standards ?

If you do not know English. Please leave a comment in your native language.

Character Sheet Info Roll20 Internal Use only.


text:
[Shadowbane Inquisition] minor update

Changes / Comments
some css and default values
Roll20 Requests
Comments are very helpful for reviewing the code changes. Please answer the relevant questions below in your comment.

[ ] Does the pull request title have the sheet name(s)? Include each sheet name.
[ ] Is this a bug fix?
[ ] Does this add functional enhancements (new features or extending existing features) ?
[ ] Does this add or change functional aesthetics (such as layout or color scheme) ?
[ ] If changing or removing attributes, what steps have you taken, if any, to preserve player data ?
[ ] If this is a new sheet, did you follow Building Character Sheets standards ?

If you do not know English. Please leave a comment in your native language.

Character Sheet Info Roll20 Internal Use only.


text:
Add linkedin as a social icon link

Describe the problem
As community, we primarily use discord, meetup and linkedin.
The last one is not currently present in our social links/
Describe the proposed solution
Add linkedin icon with link to https://linkedin.com/company/romajs
Alternatives considered
none
Importance
absolutely necessary

Hi @FaberVitale, I would like to have a go at this, can you assign me this issue?

authors: CommonHouseCat FaberVitale

repo: Roma-JS/roma-js-on-astro


text:
Added Automatic Birthday Wisher Python Project

Added Automatic Birthday Wisher Python Project

ATTENTION 🚨🚨🚨
Don’t Forget To Follow Me On Github , and Add Your Name In contributing.md if not found your name in contributing.md it should be Labelled as SPAM.
STAR 🌟 this REPO for future HacktoberFest.


text:
Add Keith Watson to Contributors list

Update Contributors.md to add entry with contributor's name at end of list as per instructions in README.md

@WhowantsToknow, I'm quite elated about your PR. I wanna evolve this project to addresses various problems faced by first-time contributors. I'd love to learn about your journey in open source community, the problems, pain points you had etc.
Could you explain how you felt when you went through the tutorial, made a PR and learned that I merged it?

@Roshanjossey, sorry I took so long to respond. Went away for a few days and then came back to an inbox full of messages (yes, I know - "been there!, done that!, got the t-shirt!" :-) ).
First of all a big thank you for setting this up and running it. It's a real service to the FOSS user community. Well done and thanks.
Bit of background - retired software engineer - retired 4 1/2 years ago. Used centralized source code management packages like CVS, Subversion and various proprietary ones during my career and only really started looking at git once I'd retired.
Been into GNU/Linux and FOSS since the mid 1990's but never had time to really usefully contribute apart from supporting my local ALUG.
So I have 2 main objectives with regard to git and github;

how to effectively contribute to FOSS projects (most of the ones I'm interested in are git based)
how to use git to manage my own bits and pieces of software and allow others to access or contribute them if they are of any use.

Your  project was exactly what I needed to take me through the basics of contributing to a git based project. I think the fact that I'd spent the last couple of years or so learning the basics of git, experimenting with it to manage some of my own stuff and unlearning the techniques and ideas I'd formed using centralised source management was a great help. I think if I'd tried to contribute to the project with little or no knowledge or experience of git I  probably would not have got so much out of it.
I found the format very clear and easy to follow. I think the main advice I'd give to anyone else is to take your time and make sure you read the instructions thoroughly. What was particularly good for me was I could also relate the process to how I'd managed contributions in the past to software projects using centralised source management systems.
I also liked the housekeeping overview for after the PR is accepted and merged. I think many contributors may simply leave stuff lying around because they are not sure what they can delete and what should be kept.
Additional information which could be useful would be bail-out or roll back instructions at each stage so contributors could understand how to recover when things go wrong (as they always will).
How about what to do if a PR is rejected or isn't merged for some reason? I think you do touch on this but it wouldn't hurt to emphasize it (for thick types like me!! :-) ).
Lastly it would be nice to see the process from the other side (so to speak) and have some idea of how to deal with contributions to a repository owned by oneself.
OK I'll stop there (sighs of relief!) a quick 5 minute reply seems to have taken me most of the afternoon. Hope some of my ramblings are of use.

Wow! That's one awesome feedback. Firstly I'm honored to have somebody of your experience using this project.
We also have a slack team to help/mentor people trying to contribute to open source projects.
We could totally use your help there mentoring us newbies.
You can join the team by going to https://firstcontributions.herokuapp.com

Additional information which could be useful would be bail-out or roll back instructions at each stage so contributors could understand how to recover when things go wrong (as they always will).

How often have I felt the need for a git undo command.  Nevertheless, I'm not sure what should go it first contributions or where to add that.

authors: Roshanjossey WhowantsToknow

repo: Roshanjossey/first-contributions


text:
while clicking upload button getting the below error

[2020-07-01 14:43:17,926] ERROR in app: Exception on / [POST]
Traceback (most recent call last):
File "/Users/jeethusingh/PycharmProjects/aiMath/lib/python3.6/site-packages/flask/app.py", line 2447, in wsgi_app
response = self.full_dispatch_request()
File "/Users/jeethusingh/PycharmProjects/aiMath/lib/python3.6/site-packages/flask/app.py", line 1952, in full_dispatch_request
rv = self.handle_user_exception(e)
File "/Users/jeethusingh/PycharmProjects/aiMath/lib/python3.6/site-packages/flask/app.py", line 1821, in handle_user_exception
reraise(exc_type, exc_value, tb)
File "/Users/jeethusingh/PycharmProjects/aiMath/lib/python3.6/site-packages/flask/_compat.py", line 39, in reraise
raise value
File "/Users/jeethusingh/PycharmProjects/aiMath/lib/python3.6/site-packages/flask/app.py", line 1950, in full_dispatch_request
rv = self.dispatch_request()
File "/Users/jeethusingh/PycharmProjects/aiMath/lib/python3.6/site-packages/flask/app.py", line 1936, in dispatch_request
return self.view_functionsrule.endpoint
File "/Users/jeethusingh/PycharmProjects/aiMath/welcome.py", line 41, in upload_file
result_file = solver.solve(save_file_path)
File "/Users/jeethusingh/PycharmProjects/aiMath/solver/init.py", line 73, in solve
if parser_tree['status'] == STATUS['solved']:
KeyError: 'status'
127.0.0.1 - - [01/Jul/2020 14:43:17] "POST / HTTP/1.1" 500 -

sorry for the error and late reply. I guest the main reason is the input is too complicate to recognize. The published system only support add/sub/mul/div operator.  Other kind of expression can not be calculated. Could you upload the image you input?

Thank you for your response.....i have tried giving the above image.....apart from add/sub/mul/div ..can weperform other operations as well using your code?

Sorry, the sqrt operator is not support. (not implement in my code) For strong math expression recognization system, please refer to TAP(Track, Attend and predict) model.

authors: Jeeth-rathore Roujack

repo: Roujack/mathAI


text:
Crash on 1.20.2

Randomly while killed tons of mobs.
java.util.ConcurrentModificationException
at java.base/java.util.ArrayDeque.nonNullElementAt(ArrayDeque.java:270)
at java.base/java.util.ArrayDeque$DeqIterator.next(ArrayDeque.java:700)
at me.roundaround.pickupnotifications.client.gui.hud.PickupNotificationsHud.render(PickupNotificationsHud.java:65)
at net.fabricmc.fabric.api.client.rendering.v1.HudRenderCallback.lambda$static$0(HudRenderCallback.java:27)
at net.minecraft.class_329.handler$ema000$fabric-rendering-v1$render(class_329.java:7485)
at net.minecraft.class_329.method_1753(class_329.java:399)
at net.minecraft.class_757.method_3192(class_757.java:927)
at net.minecraft.class_310.method_1523(class_310.java:1275)
at net.minecraft.class_310.method_1514(class_310.java:856)
at net.minecraft.client.main.Main.main(Main.java:253)
at net.fabricmc.loader.impl.game.minecraft.MinecraftGameProvider.launch(MinecraftGameProvider.java:470)
at net.fabricmc.loader.impl.launch.knot.Knot.launch(Knot.java:74)
at net.fabricmc.loader.impl.launch.knot.KnotClient.main(KnotClient.java:23)

Fixed for 1.20/1.20.1 in version 1.5.2 and for 1.20.2 in 1.6.1! Thanks for reporting!
https://modrinth.com/mod/pickup-notifications/versions

authors: Roundaround sternschnaube