text:
Install pip<24.1 for minimum requirements test

The ansys-dpf-core version 0.8.0 cannot be installed with pip version 24.1 and above, since
its dependency on ansys-dpf-gate>=0.3.* is identified as invalid metadata (the * only being allowed
with == and != relations).
For the purposes of checking our backwards compatibility, we can simply use an older version of pip.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 92.21%. Comparing base (ec5461f) to head (2907edd).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #481   +/-   ##
=======================================
  Coverage   92.21%   92.21%
=======================================
  Files          50       50
  Lines        3352     3352
=======================================
  Hits         3091     3091
  Misses        261      261

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

authors: codecov-commenter greschd

repo: ansys/pydpf-composites


text:
Wrong legend when importing launch_mapdl

Before submitting the issue

[X] I have checked for Compatibility issues
[X] I have searched among the existing issues
[X] I am using a Python virtual environment

Description of the bug
The plot legend is messed up if there is a launch_mapdl import after the dpf imports. Download the attached serialized field ("field.log") and run the snippet below. This results in the following output:

If the imports in are switched (first the launch_mapdl import), the plot looks as expected:

from ansys.dpf.core import operators, types
from ansys.mapdl.core import  launch_mapdl

op = operators.serialization.deserializer()
op.inputs.file_path("field.log") # log file extension so it can be uploaded to github
field = op.get_output(1,types.field)
field.plot()

field.log
Note: Uses current dev version of server.
Steps To Reproduce
See Description
Which Operating System causes the issue?
Windows
Which DPF/Ansys version are you using?
Ansys 2024 R1
Which Python version causes the issue?
3.10
Installed packages
Package                               Version         Editable project location

accessible-pygments                   0.0.4
aiohttp                               3.9.1
aiosignal                             1.3.1
alabaster                             0.7.16
ansys-acp-core                        0.0.dev0        D:\ANSYSDev\pyacp-private
ansys-api-acp                         0.1.0.dev2
ansys-api-mapdl                       0.5.1
ansys-api-mechanical                  0.1.1
ansys-api-platform-instancemanagement 1.0.0
ansys-api-tools-filetransfer          0.1.dev3
ansys-api-utilities-filetransfer      0.1.dev0
ansys-dpf-composites                  0.3.2
ansys-dpf-core                        0.10.1
ansys-mapdl-core                      0.67.0
ansys-mapdl-reader                    0.53.0
ansys-math-core                       0.1.3
ansys-mechanical-core                 0.10.5
ansys-mechanical-env                  0.1.0
ansys-platform-instancemanagement     1.1.2
ansys-pythonnet                       3.1.0rc3
ansys-sphinx-theme                    0.13.0
ansys-tools-filetransfer              0.1.dev0
ansys-tools-local-product-launcher    0.1.dev0
ansys-tools-path                      0.3.2
ansys-utilities-filetransfer          0.1.dev0
anyio                                 4.2.0
appdirs                               1.4.4
argon2-cffi                           23.1.0
argon2-cffi-bindings                  21.2.0
arrow                                 1.3.0
asttokens                             2.4.1
async-lru                             2.0.4
async-timeout                         4.0.3
attrs                                 23.2.0
Babel                                 2.14.0
backports.entry-points-selectable     1.3.0
beautifulsoup4                        4.12.2
black                                 23.3.0
bleach                                6.1.0
bokeh                                 3.3.1
cachetools                            5.3.2
certifi                               2023.11.17
cffi                                  1.16.0
cfgv                                  3.4.0
charset-normalizer                    3.3.2
click                                 8.1.7
clr-loader                            0.2.6
colorama                              0.4.6
comm                                  0.2.1
contourpy                             1.2.0
coverage                              7.4.0
cycler                                0.12.1
debugpy                               1.8.0
decopatch                             1.4.10
decorator                             5.1.1
defusedxml                            0.7.1
distlib                               0.3.8
docker                                7.0.0
docutils                              0.19
exceptiongroup                        1.2.0
executing                             2.0.1
fastjsonschema                        2.19.1
filelock                              3.13.1
fonttools                             4.47.0
fqdn                                  1.5.1
frozenlist                            1.4.1
geomdl                                5.3.1
google-api-core                       2.15.0
google-api-python-client              2.113.0
google-auth                           2.26.1
google-auth-httplib2                  0.2.0
googleapis-common-protos              1.62.0
grpcio                                1.60.0
grpcio-health-checking                1.48.2
httplib2                              0.22.0
hypothesis                            6.92.6
identify                              2.5.33
idna                                  3.6
imageio                               2.28.1
imagesize                             1.4.1
importlib-metadata                    7.0.1
iniconfig                             2.0.0
ipycanvas                             0.13.1
ipydatawidgets                        4.3.5
ipyevents                             2.0.2
ipykernel                             6.28.0
ipython                               8.18.1
ipython-genutils                      0.2.0
ipytree                               0.2.2
ipyvtklink                            0.2.3
ipywidgets                            8.1.1
isoduration                           20.11.0
jedi                                  0.19.1
Jinja2                                3.1.2
json5                                 0.9.14
jsonpointer                           2.4
jupyter_client                        8.6.0
jupyter_core                          5.7.1
jupyter-events                        0.9.0
jupyter-lsp                           2.2.0
jupyter_server                        2.12.3
jupyter_server_proxy                  4.1.0
jupyter_server_terminals              0.5.1
jupyterlab                            4.0.8
jupyterlab_pygments                   0.3.0
jupyterlab_server                     2.25.1
jupyterlab-widgets                    3.0.9
kiwisolver                            1.4.5
linkify-it-py                         2.0.2
makefun                               1.15.2
Markdown                              3.5.1
markdown-it-py                        3.0.0
MarkupSafe                            2.1.3
matplotlib                            3.8.2
matplotlib-inline                     0.1.6
mdit-py-plugins                       0.4.0
mdurl                                 0.1.2
mistune                               3.0.2
mock                                  5.1.0
more-itertools                        10.2.0
multidict                             6.0.4
mypy                                  1.8.0
mypy-extensions                       1.0.0
nbclient                              0.9.0
nbconvert                             7.14.0
nbformat                              5.9.2
nest-asyncio                          1.5.8
nodeenv                               1.8.0
notebook                              7.0.6
notebook_shim                         0.2.3
numpy                                 1.26.3
numpydoc                              1.6.0
overrides                             7.4.0
packaging                             23.2
pandas                                2.1.3
pandocfilters                         1.5.0
panel                                 1.3.1
param                                 2.0.1
parso                                 0.8.3
Paste                                 3.5.3
pathspec                              0.12.1
pillow                                10.2.0
pip                                   22.3.1
platformdirs                          4.1.0
pluggy                                1.3.0
pooch                                 1.8.0
pre-commit                            3.6.0
prometheus-client                     0.19.0
prompt-toolkit                        3.0.43
protobuf                              3.20.3
protoc-gen-swagger                    0.1.0
psutil                                5.9.7
pure-eval                             0.2.2
py-cpuinfo                            9.0.0
pyansys-tools-versioning              0.5.0
pyasn1                                0.5.1
pyasn1-modules                        0.3.0
pycparser                             2.21
pydata-sphinx-theme                   0.15.1
Pygments                              2.17.2
pyiges                                0.3.1
pypandoc                              1.12
pyparsing                             3.1.1
pytest                                7.4.4
pytest-benchmark                      4.0.0
pytest-cases                          3.8.1
pytest-cov                            4.1.0
python-dateutil                       2.8.2
python-json-logger                    2.0.7
pythreejs                             2.4.2
pytz                                  2023.3.post1
pyvista                               0.43.1
pyviz_comms                           3.0.0
pywin32                               306
pywinpty                              2.0.12
PyYAML                                6.0.1
pyzmq                                 25.1.2
readable                              0.0.post30
referencing                           0.32.1
requests                              2.31.0
rfc3339-validator                     0.1.4
rfc3986-validator                     0.1.1
rpds-py                               0.16.2
rsa                                   4.9
scipy                                 1.11.4
scooby                                0.9.2
Send2Trash                            1.8.2
setuptools                            69.0.3
setuptools-scm                        6.4.2
shortuuid                             1.0.11
simpervisor                           1.0.0
six                                   1.16.0
sniffio                               1.3.0
snowballstemmer                       2.2.0
sortedcontainers                      2.4.0
soupsieve                             2.5
Sphinx                                6.2.1
sphinx-autodoc-typehints              1.23.0
sphinx-copybutton                     0.5.2
sphinx_design                         0.5.0
sphinx-gallery                        0.13.0
sphinxcontrib-applehelp               1.0.7
sphinxcontrib-devhelp                 1.0.5
sphinxcontrib-htmlhelp                2.0.4
sphinxcontrib-jsmath                  1.0.1
sphinxcontrib-qthelp                  1.0.6
sphinxcontrib-serializinghtml         1.1.9
stack-data                            0.6.3
tabulate                              0.9.0
Tempita                               0.5.2
terminado                             0.18.0
tinycss2                              1.2.1
toml                                  0.10.2
tomli                                 2.0.1
tornado                               6.4
tqdm                                  4.66.1
traitlets                             5.14.1
traittypes                            0.2.1
trame                                 3.5.0
trame-client                          2.14.2
trame-server                          2.15.0
trame-vtk                             2.6.3
uri-template                          1.3.0
uritemplate                           4.1.1
urllib3                               2.1.0
virtualenv                            20.25.0
vtk                                   9.3.0
waitress                              2.1.2
wcwidth                               0.2.13
webcolors                             1.13
webencodings                          0.5.1
WebError                              0.13.1
WebOb                                 1.8.7
websocket-client                      1.7.0
WebTest                               3.0.0
wheel                                 0.37.1
widgetsnbextension                    4.0.9
wslink                                1.12.4
xyzservices                           2023.10.1
yarl                                  1.9.4
zipp                                  3.17.0
zope.component                        6.0
zope.event                            5.0
zope.hookable                         5.4
zope.interface                        6.0

Hi @germa89, any idea of what could be causing a conflict in the pymapdl import? I know there is a PyVista custom theme set-up but I do not see why it would result in this...

I think that issue is related to this PR: https://github.com/ansys/pymapdl/pull/2295
But I need to keep investigating and I cannot this week, so I'm transferring this issue to PyMAPDL just to not lose track of it. If it is a PyDPF issue, I will transfer it back with my findings as a comment.

source: gharchive/issue

authors: PProfizi germa89 janvonrickenbach

repo: ansys/pydpf-core

license: MIT

license_type: permissive

license_source: github-api


text:
[BUG]希望增加一个 prefix 的属性

发现 pro 的 less 样式表里面有取 ant design 的 prefix，但是在 pro 的代码中样式却是写死的，如 ant-design-pro-layout。这对于有修改 ant design 样式前缀的需求项目，是个麻烦事。

已经尽量使用了 antd 的 less 变量，我来排查一下，或者你方便给一个问题列表吗

less 文件中确实尽量使用了，但是组件中有的还是写死的。问题列表的话我建议直接搜索 ant-pro、ant 之类的字眼就可以看到了。

v6 支持了

repo: ant-design/ant-design-pro-layout


text:
.ant-layout 元素存在 overflow-x: hidden 导致内部元素 position: sticky 无效

相当于限制了 children 的能力，这个  overflow-x: hidden  的作用是？

隐藏横向滚动条

你可以通过传入 style 来解决这个问题

authors: chenshuai2144 noyobo shaohuatsou


text:
Ant Motion中列表交换会使右侧进度条消失，形成抖动，不知会不会对项目造成影响

Ant Motion中列表交换会使右侧进度条消失，形成抖动，不知会不会对项目造成影响

拖动时目前是把页面的滚动干掉的吧，避免页面滚动导至错位。如果你有好的方案可以 PR.

repo: ant-design/ant-motion


text:
تلخيص

مقدمة في نظرية القرارات.pdf
قم بتلخيص محتوى الملف

لخص

repo: anthropics/anthropic-sdk-python


text:
Expose Hypothesis strategies for builtin types

Todo

[ ] Unit test _get_scalar_int_bounds (especially for _NonScalarBounds).
[ ] Unit test _get_scalar_float_bounds (especially for _NonScalarBounds).
[ ] Test all combinations of (float, int) * (exclusive, inclusive).

Codecov Report

Merging #262 (5fd13f3) into main (e80bcbd) will decrease coverage by 2.67%.
The diff coverage is 82.35%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@            Coverage Diff             @@
##             main     #262      +/-   ##
==========================================
- Coverage   99.77%   97.10%   -2.67%
==========================================
  Files          27       28       +1
  Lines         871     1037     +166
  Branches      135      170      +35
==========================================
+ Hits          869     1007     +138
- Misses          1       25      +24
- Partials        1        5       +4

Impacted Files
Coverage Δ

src/phantom/sized.py
90.62% <62.50%> (-9.38%)
:arrow_down:

src/phantom/interval.py
86.71% <75.32%> (-13.29%)
:arrow_down:

src/phantom/negated.py
90.00% <81.81%> (-10.00%)
:arrow_down:

src/phantom/_base.py
100.00% <100.00%> (ø)

src/phantom/_hypothesis.py
100.00% <100.00%> (ø)

src/phantom/boolean.py
100.00% <100.00%> (ø)

src/phantom/datetime.py
100.00% <100.00%> (ø)

src/phantom/iso3166.py
100.00% <100.00%> (ø)

src/phantom/re.py
100.00% <100.00%> (ø)

src/phantom/_utils/compat.py
100.00% <0.00%> (+25.00%)
:arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

source: gharchive/pull-request

authors: antonagestam codecov-commenter

repo: antonagestam/phantom-types


text:
terraform_docs: Check abillity to use native terraform-docs config as replacement for custom --hook-config=

In #380 I discovered that terraform-docs now have a big config, that, theoretically, can be used as a replacement for all or part of custom --hook-config='s
Need to investigate that option, hope we can remove part of the custom logic.

In #380 I discovered that terraform-docs now have a big config

Me too 😂

that, theoretically, can be used as a replacement for all or part of custom --hook-config='s

...which would mean we need to ship pre-commit-terraform along with a terraform-docs config file, which consumers of pre-commit-terraform would need to amend per their preferences and requirements and put into a standard location where terraform-docs expect it to be (the precedence of config vs cmdline options is not obvious from the terraform-docs README file).
So this may suffice for dockerized pre-commit-terraform only, I seem to think (I might be wrong).
ON the other hand, terraform-docs README says to use cmdline options when used with pre-commit: https://github.com/terraform-docs/terraform-docs#pre-commit-hook

I'm using the following hook configuration and everything related to terraform-doc is managed by the config files. It works like a charm
- repo: https://github.com/antonbabenko/pre-commit-terraform
   rev: v1.72.1
   hooks:
     - id: terraform_docs
       args:
         - --args=--config=infra/.terraform-docs.yml
         - --hook-config=--create-file-if-not-exist=true

Adding my experience here using the .terraform-docs.yml config file with this hook. Generally passing in the config file works, however there is a slight bug that can produce some undesirable effects.
Example setup for various files:
Config file .pre-commit-config.yaml
repos:
  - repo: https://github.com/antonbabenko/pre-commit-terraform
    rev: v1.81.0
    hooks:
      - id: terraform_docs
        args:
          - --args=--config=.terraform-docs.yml

Config file .terraform-docs.yml
formatter: "markdown"
version: "0.16.0"

content: |-
  {{ .Requirements }}
  ...
  various other customizations for our documentation
  ...

output:
  file: README.md
  mode: inject
  template: |-
    <!-- BEGINNING OF PRE-COMMIT-TERRAFORM DOCS HOOK -->
    {{ .Content }}
    <!-- END OF PRE-COMMIT-TERRAFORM DOCS HOOK -->

# Truncated: "settings" block left as defaults for each option

Setup of README.md
# Title for repo

General description paragraph

<!-- BEGINNING OF PRE-COMMIT-TERRAFORM DOCS HOOK -->
<!-- END OF PRE-COMMIT-TERRAFORM DOCS HOOK -->

The Outcome

As you can see, the hook actually ends up writing the console message to the README.md file instead of the expected content.
Two things to note:

If I remove the "output" block from my .terraform-docs.yml file, the content is correctly inserted into README.md. So far in my use case, all of the other configuration settings seem to work correctly. For my use case, I definitely want to retain the "output" block so more troubleshooting was necessary.
If I keep the .terraform-docs-yml file target as README.md and redirect the pre-commit hook towards a different file (i.e. add --hook-config=--path-to-file=RANDOM.md to the args), then I can get the desired output in README.md and the console output as shown in the image above in RANDOM.md. This leads me to believe there is something happening in the handoff or a double-write operation causing the conflict here.

Final Solution
I realized that I can refactor my README.md and .terraform-docs.yml files to no longer use the custom comment template that pre-commit-terraform expects. Setting different comment strings in these two files means that pre-commit-terraform will no longer write the changes and instead terraform-docs will handle writing the output per it's config file.
In summary, if you are converting from a standard use of this hook and want to now use terraform-docs config file feature, change your comment strings in your target markdown file to anything else (for example, back to the default <!-- BEGIN_TF_DOCS --> and <!-- END_TF_DOCS -->)
# DO NOT USE if you want to specify a config file with an "output" block
<!-- BEGINNING OF PRE-COMMIT-TERRAFORM DOCS HOOK -->
<!-- END OF PRE-COMMIT-TERRAFORM DOCS HOOK -->

Hope this helps!

As an aside, I think the greatest driver towards my use of a config file instead of cmd line arguments was the ability to fully customize the generated content. I can re-order the standard sections, add static text wherever I want, insert other files' contents, and (best of all) I am adding an auto-generated code block that users will be able to copy/paste into their projects to consume the terraform module for ease-of-use.
That code block will be automagically updated for any terraform file changes instead of having to manually maintain the doc! (I'm going to be building sooo many modules and don't want to maintain that 😄 )

@drAlberT @UkklyDukkling  can you please point how you were able to replicate
- --hook-config=--create-file-if-not-exist=true

in your terraform-docs.yaml config?
And if you have idea how make - --hook-config=--add-to-existing-file=true working for inject mode using only native terraform-docs.yaml configs, let me know too.
(Btw, I don't think that hook currently able to work with replace mode)
just in case,

starting from https://github.com/antonbabenko/pre-commit-terraform/releases/tag/v1.92.2, output.file setting from .terraform-docs.yml config prioritized over --hook-config=--path-to-file=
starting from https://github.com/antonbabenko/pre-commit-terraform/releases/tag/v1.93.0 <!-- BEGIN_TF_DOCS --> and <!-- END_TF_DOCS --> markers used by default (with under-the-hood replacement of old-one markers)

Which means that next settings, not more needed
- --hook-config=--path-to-file=
- --hook-config=--use-standard-markers=

And now we need to figure-out how to deal with
- --hook-config=--add-to-existing-file=true     # Boolean. true or false
- --hook-config=--create-file-if-not-exist=true # Boolean. true or false

@drAlberT @UkklyDukkling can you please point how you were able to replicate
- --hook-config=--create-file-if-not-exist=true

in your terraform-docs.yaml config?

TL;DR: terraform-docs always generate section to file, no matter what, https://github.com/antonbabenko/pre-commit-terraform/issues/715.
So we still need --hook-config=--add-to-existing-file= at least to disable addition of such sections. Defaults could be changed in v2.0, but I don't think that it worth it.
--hook-config=--create-file-if-not-exist= not supported by terraform-docs

authors: MaxymVlasov UkklyDukkling drAlberT yermulnik

repo: antonbabenko/pre-commit-terraform


text:
tokio concurrency with Client

Hello,
I'm having an issue running concurrent instances of Client.
Here is the general control flow of my application:
let list_of_chats: Vec<&str> = vec!["chat_1", "chat_2", ...];

    // let (sender, mut receiver) = tokio::sync::mpsc::channel::<Box<Update>>(10000);

    // Process all of this concurrently
    let mut list_of_futures = FuturesUnordered::new();

    for chat in list_of_chats {
        let client = Client::builder()
            .with_tdlib_parameters(
                TdlibParameters::builder()
                    .database_directory(chat)
                    .use_test_dc(false)
                    .api_id(std::env::var("API_ID").unwrap().parse::<i32>().unwrap())
                    .api_hash(std::env::var("API_HASH").unwrap())
                    .system_language_code("en")
                    .device_model("Desktop")
                    .system_version("Unknown")
                    .application_version(env!("CARGO_PKG_VERSION"))
                    .enable_storage_optimizer(true)
                    .build(),
            )
            // .with_updates_sender(sender)
            .build()
            .unwrap();

        let mut worker = Worker::builder().build().unwrap();

        worker.start();

        let client = worker.bind_client(client).await.unwrap();

        loop {
            if worker.wait_client_state(&client).await.unwrap() == ClientState::Opened {
                log::info!("client authorized");
                break;
            }
        }

        let i_s = pull_sources_from_channel_name(client.to_owned(), club);
        list_of_futures.push(i_s);

        client.stop().await.unwrap();

        loop {
            if worker.wait_client_state(&client).await.unwrap() == ClientState::Closed {
                log::info!("client1 closed");
                break;
            }
        }

        worker.stop();

    }

    while let Some(status_result) = list_of_futures.next().await {
        log::info!("{:#?}", status_result)
    }

When I run this with my API_ID and API_HASH, I get the following error:
[ 0][t 0][1677184963.310343980][Client.cpp:282] Receive must not be called simultaneously from two different threads, but this has just happened. Call it from a fixed thread, dedicated for updates and response processing.

What I'm getting from this message is that the receive method on the original Client binding can only be run on one thread, but is it possible to send requests concurrently and merely receive them blocked?
Otherwise, I really love this library and I prefer it so much to the Python implementation!
Keep up the good work, y'all!! <3

omg, lost the issue, sorry.
so you are right, the original library is totally sequential and does not support concurrent access to its api, at least when you try to create multiple worker instances.
But you may try to create single instance of worker (which is right in any case) and access it asynchronously.
So, like this:

create single worker instance
create one client and bind it
create a future using Client::get_whatever_you_want and put it into a list_of_futures in a loop
the other logic.

No worries at all! Really appreciate the response.
I'll give it a shot this weekend, and I'll come back with any other issues I have. I thought I tried something like this but I'll give it another shot.
Again, thanks so much for the work you've put into this.

@moonstripe any updates regarding the issue?

I just implemented it as you said today. Works excellently.
Again, thanks for all of your work!

authors: antonio-antuan moonstripe

repo: antonio-antuan/rust-tdlib


text:
Fix issue that Aurora cannot be launched when the Ducky keyboard is not connected.

List any issues that this PR fixes: fixes # , etc...
Fix issue that Aurora cannot be launched when the Ducky keyboard is not connected.
This pull request proposes the following changes:

Check the result of opening Duck keyboard

Duplicate of #1996

repo: antonpup/Aurora


text:
Deprecate Antrea Octant Plugin

We start updating the documentation to remove some references to Octant and the plugin, add some pointers to the Antrea web UI, and add some deprecation notices. The plugin code itself and all the build infrastructure are preserved, until after the Antrea v1.12 release.
See #4640

I have removed the PNG file to avoid growing the repo size in the future. The SVG uses path objects for text, so will render correctly on all browsers.

I have addressed Jianjun's comment, but I will wait until we have released v0.1.0 of antrea-ui before merging this. Otherwise there may be some confusion (see https://github.com/antrea-io/antrea/pull/4825#discussion_r1161400028).

/skip-all

repo: antrea-io/antrea


text:
Add missing metav1.ObjectMeta to NetworkPolicyEvaluation API type

It seems that omitting the field was a mistake when defining the API. New versions of the K8s code generators (client-gen specifically) will not work with types missing this field.
See https://github.com/kubernetes/code-generator/commit/688a73a18a8c19ffd7979f5c9a6c03d118cc4d7f.
This is preventing us from updating to a more recent version of the K8s libraries and of the code generators.
Note that I believe that this API was modeled after the upstream TokenReview API (which like this one only supports the "create" verb, and returns a response immediately). The TokenReview type does include a metav1.ObjectMeta field.
Unfortunately, for backwards-compatibility, we need to use Protobuf field number 3 for the metadata field, while K8s always uses 1. This is a bit surprising, but it should only affect the wire format, and nothing else.

Thanks for catching this issue. LGTM except that codegen seemingly needs update

Thanks! Codegen test +1

@Dyanngg @qiyueyao thanks, I have generated the code

/test-all

/test-all

authors: Dyanngg antoninbas qiyueyao


text:
双轴图 分组柱状图和分组条形图一起使用时，分组条形图的线首尾连接

问题描述
双轴图 分组柱状图和分组条形图一起使用时，分组条形图的线首尾连接，且只有一种颜色
重现链接
https://codesandbox.io/p/sandbox/frosty-fog-xsnnrf?file=%2Findex.ts
重现步骤
No response
预期行为
分组条形图正常显示
平台

操作系统: [macOS, Windows, Linux, React Native ...]
网页浏览器: [Google Chrome, Safari, Firefox]

屏幕截图或视频（可选）

补充说明（可选）
No response

{
  type: "line",
  ...
+ scale: { series: { independent: true } },
  ...
}


text:
fix(interval): fix interval render funnel (#4868)

修复interval绘制funnel、pyramid

非常感谢贡献，PR 描述中写一下当前的问题和你的解法方案吧，有助于 CR 以及大家了解这个 PR。@shield2018

非常感谢贡献，PR 描述中写一下当前的问题和你的解法方案吧，有助于 CR 以及大家了解这个 PR。@shield2018

这里有个相关的 https://github.com/antvis/G2/issues/4868

麻烦关注一下
https://github.com/antvis/G2/issues/4877
这个bug会导致漏斗图点击图例后，4个点的计算出现问题

authors: hustcc pearmini shield2018


text:
有没有V2升级到^V3的文档

有没有V2升级到^V3的文档？大版本升级很痛苦！！

没有的，V2 到 V3 基本上需要看 V3 API 重新写一下

authors: JadeDruid Yanyan-Wang


text:
合并单元格后，拖动表格内部滚动条，合并的单元格边框重新出现

1. 在官网示例，正常进行合并单元格操作，但尝试滚动表格后，原来合并的单元格边框再次出现

2. 合并单元格后，文本内容能否默认垂直水平居中？
3. 同时发现配置在 s2Options 中的 mergedCellsInfo 属性中时，也会出现同样的情况。

:tada: This issue has been resolved in version @antv/s2-v1.24.0-alpha.2 :tada:
The release is available on:

npm package (@alpha dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This issue has been resolved in version @antv/s2-v1.24.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


text:
当画布区域过长时，小地图展示不全

Describe the bug

当画布区域过长时，小地图展示不全
点击小地图可点击区域，小地图视口也不能准确跟随

Your Example Website or App
https://codesandbox.io/s/x6-minimap-zhan-shi-bu-quan-hfqqyw
Steps to Reproduce the Bug or Issue

打开demo，点击小地图可点击区域，小地图视口不能准确跟随
一直向下滚动，会发现小地图展示不完整

Expected behavior

当画布区域过长时，小地图展示完整
点击小地图可点击区域，小地图视口正常移动
或者支持小地图宽度/高度自适应

Screenshots or Videos
No response
Platform

OS: [macOS]
Browser: [Chrome]
Version: [109.0]

Additional context
No response

I have the same problem. The minimap doesn't really follow the map. The displayed data does not show completely. The minimap does not update when going into full screen mode. How to make it interactive? I think that the minimap needs to be improved)

authors: haohaio lexoring


text:
TypeError: extensionRegistry.addExtension is not a function

TypeError: extensionRegistry.addExtension is not a function
https://codesandbox.io/s/wsnu8
Not work local.
when you remove CanvasMiniMap and CanvasSnapline.
and set position={{ width: 800, height: 800 }} the component is rendered
but CanvasScaleToolbar not appear
      <XFlowCanvas config={graphConfig} position={{ width: 800, height: 800 }} >
        <CanvasScaleToolbar position={{ top: 12, left: 12 }} />
      </XFlowCanvas>

Steps To Reproduce

npx create-react-app xflow-ts-demo --template typescript
cd xflow-ts-demo
yarn add @antv/xflow
yarn add antd @antv/layout @ant-design/icons @antv/x6 @antv/x6-react-components @antv/x6-react-shape
copy packages\xflow-docs\docs\tutorial\getting-started\demo to xflow-ts-demo/src
import App from './demo'; in index.tsx
yarn start

Error Message & Stack Trace
D:/app/src/xflow-main/components/app-extension-module.tsx:25
  22 | const disposable = extensionRegistry.addExtension({
  23 |     config: config,
  24 |     createModule,
> 25 | });
     | ^  26 | return () => {
  27 |     disposable.dispose();
  28 | };

Your Environment
package.json:
{
  "name": "xflow-ts-demo",
  "version": "0.1.0",
  "private": true,
  "dependencies": {
    "@ant-design/icons": "^4.7.0",
    "@antv/layout": "^0.1.19",
    "@antv/x6": "^1.28.1",
    "@antv/x6-react-components": "^1.1.15",
    "@antv/x6-react-shape": "^1.5.2",
    "@antv/xflow": "^1.0.7",
    "@testing-library/jest-dom": "^5.11.4",
    "@testing-library/react": "^11.1.0",
    "@testing-library/user-event": "^12.1.10",
    "@types/jest": "^26.0.15",
    "@types/node": "^12.0.0",
    "@types/react": "^17.0.0",
    "@types/react-dom": "^17.0.0",
    "antd": "^4.17.2",
    "react": "^17.0.2",
    "react-dom": "^17.0.2",
    "react-scripts": "4.0.3",
    "typescript": "^4.1.2",
    "web-vitals": "^1.0.1"
  },
  "scripts": {
    "start": "react-scripts start",
    "build": "react-scripts build",
    "test": "react-scripts test",
    "eject": "react-scripts eject"
  },
  "eslintConfig": {
    "extends": [
      "react-app",
      "react-app/jest"
    ]
  },
  "browserslist": {
    "production": [
      ">0.2%",
      "not dead",
      "not op_mini all"
    ],
    "development": [
      "last 1 chrome version",
      "last 1 firefox version",
      "last 1 safari version"
    ]
  }
}

OS: Windows 8
Browser: Chrome 96.0.4664.45 (64 bits), Firefox 94.0.2 (64-bit)

我也报这个错，请问你解决了吗，我没找到

let me check it out

please use this template for XFlow quick start
https://github.com/antvis/XFlow/tree/master/examples/quick-start-cra

authors: 1195002442 lyn-boyu rnapoles

repo: antvis/XFlow


text:
fix: Guide 的 position 百分比解析需要考虑原始数据中本身包含 '%'

的情况.Closed #590.

Checklist

[ ] npm test passes
[ ] tests and/or benchmarks are included
[ ] commit message follows commit guidelines

Description of change

G2 中也会有这个问题 @paleface001 @hustcc


text:
gh-pages build with remote action

[x] build and deploy website on remote action
[x] trigger only on release published

这个 pr 可以不用追 11.22。

👍 给力，感觉应该给所有仓库来一份。

👍 给力，感觉应该给所有仓库来一份。

包括 changelog 和 commitlint，后面一起都弄了~

包括 changelog 和 commitlint，后面一起都弄了~

提一个 @antv/tools 类似 https://github.com/ant-design/antd-tools，把 webpack 配置这些也搞了，现在几个仓库配置也挺乱的。

trigger only on release published
🎉release的时候可以直接npm publish了

authors: afc163 hustcc zqlu


text:
Groups not working

In live example group does not work. I followed the tutorial and its not working. Can someone fix this?

Looks like this was fixed in this PR and can be closed now.  Looking at the live example, the groups are working as expected.

authors: ImExoOdeex Kysluss


text:
refactor aws cli script

[x] Refactor AWS CLI into bash script
[x] Provide env var examples for AWS CLI requirements
[x] set our env vars for AWS using gp env

[x] Refactor AWS CLI into bash script
[x]  Provide env var examples for AWS CLI requirements
[x] set our env vars for AWS using gp env


text:
BUG: Color Mismatch of Subscribe Button with Theme Color

Is there an existing issue for this?

[X] I have searched the existing issues

What happened?
The color of the Subscribe button on the website does not match the theme color, causing inconsistency and affecting the overall aesthetics. The button color needs to be adjusted to align with the theme color scheme of the website.

Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSOC'24 contributor
[X] I want to work on this issue

Assigned!
Make sure to attach before & after screenshots in your PR. Also, star the repo
before working on it. While creating your PR, ensure you pull all existing changes
beforehand to avoid conflicts.
Happy open-source contributing!


text:
SOLID LOGIN: Allow a skip login option

Description
Add an option to allow the login to be skipped with something like SolidLogin(requireLogin: false).
If requireLogin is false then there is a CONTINUE button on the app's login screen to go directly to the child.
If the user clicks LOGIN and then CANCEL in the browser popup or enters the wrong credentials, then return to the Login screen.
Why
So that an app that may not require data to be retrieved from or saved to a Pod, but supports it if logged in, can operate without the need of a Pod or logging in.  The btsim and innerpod apps are examples of this use case.

Made pull request https://github.com/anusii/solid/pull/45
https://github.com/anusii/keypod/pull/43

Made pull request Made pull request https://github.com/anusii/solid/pull/45
https://github.com/anusii/keypod/pull/43

Where do I find the Continue button?

Great addition of the Cancel button on the Logging in... popup. On Android at the moment this login is failing. At least I now have an option to return to the Login page. Thanks.

Tested and working well. I have updated a few bits here and there. The CONTINUE button swapped with the GET A POD button since the latter will disappear once another issue is completed.

Great addition of the Cancel button on the Logging in... popup. On Android at the moment this login is failing. At least I now have an option to return to the Login page. Thanks.

Hi @gjwgit, the issue should be fixed at the existing issue https://github.com/anusii/solid/issues/43. According to previous experience, some configuration files in android folder should be edited.

There was no issue. Sorry for the confusion. I changed the code to put the CONTINUE button where I think it belongs longer term.

Can be merged and closed once @anushkavidanage or @NinadBhat have reviewed. Thanks.

Merged. Can be closed.

authors: gjwgit zheyxu

repo: anusii/solid


text:
Additional style updates

A third round of style updates to standardise the naming system, remove old style declarations, and simplify the overall implementation.

[x] Unify the sheet classes to remove code duplication
[x] Simplify the settings classes
[x] Create a dedicated radio button component
[x] Add binding classes where they haven't already been implemented (excluding actor groups)
[x] Make the entire toggle button clickable on the setup sheet pane
[x] Simplify desk styles
[x] Update all of the template styles

Update 1: The latest round of changes should complete the update to the new naming scheme, following standard BEM conventions with a handful of utility classes.
The only classes which have not been updated are those for the forthcoming actor groups feature. It's likely that only a handful of new styles will be needed over the current generic components, meaning that most of the existing front-end code for this feature will be discarded.
Update 2: The PR now includes updates for the majority of the actor group styles, as well as template changes for the actor group feature.
Update 3: The PR now also includes the preliminary work for setting custom themes. The var function is used to associate custom property names with specific system elements; however, no values for these custom properties is set. Instead, a fallback value is provided for each var, acting as the system default. Users can modify the styles by setting values for the custom property names used in the system CSS.
These additions will be built upon when we get around to implementing custom styling for the system interface.

Known issues as of the latest commit:

Checkboxes are not working on the new actor groups.
Actor groups currently have no help text.
The input element for the actor group name currently does not update the name of the actor group.
Some of the actor group classes have not been updated to the new format.

repo: anvil-vtt/FateX


text:
requester pays bucket issue

See galaxy on anvil channel in anvil slack for details

requester pays is working, and no further error detail provided so


text:
IPFS integration (feature)

Would love to see the integration of IPFS. What do you think?
http://ipfs.io/

It's OK to me if:

It's a file system with directory support.
it has an existing Node client.

Have not looked into IPFS yet.
Now we still have many adapters to integrate. Some common adapters will be considered with higher priority.
I'm very glad if someone would like to contribute to this adapter.

This is the node api:
https://github.com/ipfs/node-ipfs-api
It assumes a running installation of ipfs on the local box, agnostic of whether python, go or node is driving it.

authors: ddliu denjello

repo: anyfs/anyfs

license: mit

license_source: bigquery


text:
Connection rate limiting.without governor

Problem
For testing purpose only -- do not review
Summary of Changes
Fixes #

Codecov Report
Attention: Patch coverage is 86.04651% with 24 lines in your changes are missing coverage. Please review.

Project coverage is 81.9%. Comparing base (4672efa) to head (dc36f8e).
Report is 115 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##           master    #1195     +/-   ##
=========================================
- Coverage    81.9%    81.9%   -0.1%
=========================================
  Files         857      860      +3
  Lines      232441   232608    +167
=========================================
+ Hits       190583   190656     +73
- Misses      41858    41952     +94

Merged into the original PR

authors: codecov-commenter lijunwangs

repo: anza-xyz/agave


text:
Bump crossbeam-channel from v0.5.12 to v0.5.13

Problem
My work (= unified scheduler) wants to use new features of the latest version of crossbeam-channel.
https://docs.rs/crossbeam-channel/0.5.13/crossbeam_channel/macro.select_biased.html
Summary of Changes
Bump it.
cc: @apfitzge
special thanks: @taiki-e for https://github.com/crossbeam-rs/crossbeam/pull/1040

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 82.7%. Comparing base (da02962) to head (a38181e).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1434   +/-   ##
=======================================
  Coverage    82.7%    82.7%
=======================================
  Files         872      872
  Lines      370361   370361
=======================================
+ Hits       306528   306542   +14
+ Misses      63833    63819   -14

authors: codecov-commenter ryoqun


text:
完善网关所需的环境变量

网关所需的环境变量采用直接在 start.sh 中赋值的方式来便于顺利启动网关。

关联 pr:  https://github.com/ao-space/space-agent/pull/32

repo: ao-space/space-single


text:
yaml support

Provide some way to deserialize from yaml

Might work if we change the next_key/next_value type from &str -> Cow<str>

I've not dug into this issue or the design of this crate yet but https://github.com/clap-rs/clap/issues/1041 might help

authors: aobatact epage

repo: aobatact/clap-serde


text:
Viewer build issue with png and node-gyp

I'm trying to build the current moloch updates on a system currently running v0.16.1 but I'm running into issues during the Viewer build.  Everything has gone smoothly with previews builds.  Been running Moloch on this box for probably over a year now.
> png@3.0.3 install /root/manual_installs/moloch/viewer/node_modules/png
> node-gyp rebuild

make: Entering directory '/root/manual_installs/moloch/viewer/node_modules/png/build'
  CXX(target) Release/obj.target/png/src/common.o
  CXX(target) Release/obj.target/png/src/png_encoder.o
  CXX(target) Release/obj.target/png/src/png.o
../src/png.cpp: In member function ‘v8::Handle<v8::Value> Png::PngEncodeSync()’:
../src/png.cpp:33:71: error: ‘class v8::Object’ has no member named ‘GetHiddenValue’
     Local<Value> buf_val = Local<Object>::New(isolate, persistent())->GetHiddenValue(String::NewFromUtf8(isolate, "buffer"));
                                                                       ^
../src/png.cpp: In static member function ‘static void Png::New(const v8::FunctionCallbackInfo<v8::Value>&)’:
../src/png.cpp:155:53: error: ‘class v8::Object’ has no member named ‘SetHiddenValue’
     Local<Object>::New(isolate, png->persistent())->SetHiddenValue(String::NewFromUtf8(isolate, "buffer"), args[0]);
                                                     ^
../src/png.cpp: In static member function ‘static void Png::UV_PngEncodeAfter(uv_work_t*)’:
../src/png.cpp:214:14: warning: ‘v8::TryCatch::TryCatch()’ is deprecated: Use isolate version [-Wdeprecated-declarations]
     TryCatch try_catch; // don't quite see the necessity of this
              ^
In file included from /root/.node-gyp/7.1.0/include/node/v8.h:26:0,
                 from /root/.node-gyp/7.1.0/include/node/node.h:42,
                 from ../src/common.h:4,
                 from ../src/png.cpp:3:
/root/.node-gyp/7.1.0/include/node/v8.h:7015:40: note: declared here
   V8_DEPRECATED("Use isolate version", TryCatch());
                                        ^
/root/.node-gyp/7.1.0/include/node/v8config.h:329:3: note: in definition of macro ‘V8_DEPRECATED’
   declarator __attribute__((deprecated(message)))
   ^
../src/png.cpp:219:33: warning: ‘void node::FatalException(const v8::TryCatch&)’ is deprecated: Use FatalException(isolate, ...) [-Wdeprecated-declarations]
         FatalException(try_catch);
                                 ^
In file included from ../src/common.h:4:0,
                 from ../src/png.cpp:3:
/root/.node-gyp/7.1.0/include/node/node.h:299:29: note: declared here
                 inline void FatalException(const v8::TryCatch& try_catch) {
                             ^
/root/.node-gyp/7.1.0/include/node/node.h:66:42: note: in definition of macro ‘NODE_DEPRECATED’
     __attribute__((deprecated(message))) declarator
                                          ^
../src/png.cpp: In static member function ‘static void Png::PngEncodeAsync(const v8::FunctionCallbackInfo<v8::Value>&)’:
../src/png.cpp:264:76: error: ‘class v8::Object’ has no member named ‘GetHiddenValue’
     Local<Value> buf_val = Local<Object>::New(isolate, png->persistent())->GetHiddenValue(String::NewFromUtf8(isolate, "buffer"));
                                                                            ^
png.target.mk:93: recipe for target 'Release/obj.target/png/src/png.o' failed
make: *** [Release/obj.target/png/src/png.o] Error 1
make: Leaving directory '/root/manual_installs/moloch/viewer/node_modules/png/build'
gyp ERR! build error
gyp ERR! stack Error: `make` failed with exit code: 2
gyp ERR! stack     at ChildProcess.onExit (/usr/lib/node_modules/npm/node_modules/node-gyp/lib/build.js:276:23)
gyp ERR! stack     at emitTwo (events.js:106:13)
gyp ERR! stack     at ChildProcess.emit (events.js:191:7)
gyp ERR! stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:215:12)
gyp ERR! System Linux 4.4.0-59-generic
gyp ERR! command "/usr/local/bin/node" "/usr/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "rebuild"
gyp ERR! cwd /root/manual_installs/moloch/viewer/node_modules/png
gyp ERR! node -v v7.1.0
gyp ERR! node-gyp -v v3.4.0
gyp ERR! not ok
npm WARN optional SKIPPING OPTIONAL DEPENDENCY: fsevents@^1.0.0 (node_modules/chokidar/node_modules/fsevents):
npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for fsevents@1.0.17: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})
npm WARN optional SKIPPING OPTIONAL DEPENDENCY: png@3.0.3 (node_modules/png):
npm WARN optional SKIPPING OPTIONAL DEPENDENCY: png@3.0.3 install: `node-gyp rebuild`
npm WARN optional SKIPPING OPTIONAL DEPENDENCY: Exit status 1

I've removed the node_modules folder and tried again with no joy.  Any pointers would be much appreciated.

We haven't done any testing with node 7, node 4.6 is required for now.
That said png is an optional dep, so it should work anyway.

authors: LaramieSmile awick

repo: aol/moloch


text:
Lymphangiosarcoma by Blasted Pancrea skipped after 20 seconds of playing

Describe the bug
Playing Lymphangiosarcoma by Blasted Pancreas and reaching the 20 second mark, spotify-player immediately skips to the nxt song on context.
To Reproduce
Play Lymphangiosarcoma by Blasted Pancreas
Expected behaviour
I am able to listen to the song fully.
Log and backtrace
2024-07-24T19:50:58.900114Z  INFO spotify_player::streaming: Got a new player event: Changed { old_track_id: TrackId("0qdvXuzk8SrWQVw0C7zdRi"), new_track_id: TrackId("00yRFTGFFmrFiwkv4ySYCp") }
2024-07-24T19:50:59.150676Z  INFO spotify_player::client: Retrieving image from file: /home/sewn/.cache/spotify-player/image/Carcinoma-Blasted Pancreas-cover.jpg
2024-07-24T19:50:59.561925Z  INFO spotify_player::streaming: Got a new player event: Playing { track_id: TrackId("00yRFTGFFmrFiwkv4ySYCp"), position_ms: 0, duration_ms: 125280 }
2024-07-24T19:50:59.962874Z  INFO client_request{request=GetCurrentUserQueue}: spotify_player::client: Successfully handled the client request, took: 325ms
2024-07-24T19:51:18.740170Z  INFO spotify_player::streaming: Got a new player event: EndOfTrack { track_id: TrackId("00yRFTGFFmrFiwkv4ySYCp") }
2024-07-24T19:51:18.740530Z  INFO spotify_player::streaming: Got a new player event: Changed { old_track_id: TrackId("00yRFTGFFmrFiwkv4ySYCp"), new_track_id: TrackId("0qdvXuzk8SrWQVw0C7zdRi") }
2024-07-24T19:51:19.391289Z  INFO spotify_player::streaming: Got a new player event: Playing { track_id: TrackId("0qdvXuzk8SrWQVw0C7zdRi"), position_ms: 0, duration_ms: 75371 }
2024-07-24T19:51:19.979636Z  INFO spotify_player::client: Retrieving image from file: /home/sewn/.cache/spotify-player/image/Katana Orgy-Jig-Ai-cover.jpg

Environment

OS: Alpine Linux
Application version: 0.18.1 (installed from repository)

Additional context
Add any other context about the problem here.

what kinda bug is this 💀

Solved on it's own for unknown reason after updating

authors: CoolSoulz apprehensions


text:
Bug: Missing testbeds schema dependency

In the Claude 3.5 Sonnet PR it seems the dependency on the testbeds package was removed.
With this package missing, the Streamlit app now crashes on launch with the following error:
    from moatless.file_context import FileContext
  File "/Users/jensr/Documents/Deep Quantum/Coding Agents/moatless-tree-search/moatless/file_context.py", line 27, in <module>
    from testbeds.schema import TestStatus
ModuleNotFoundError: No module named 'testbeds'

It seems the testbeds.schema is required even if you aren't using the Moatless Testbeds.

FYI I re-added the dependency in this PR.

Thanks! I merged your PR.

authors: JensRoland aorwall

repo: aorwall/moatless-tree-search


text:
QingStor detect use path style instead of vhost

code here
For some reason, dns is not available for vhost, so we need to use path style.

We can check location via HEAD https://qingstor.com/bucket_name

If bucket exists, it will return 301 with location https://zone.qingstor.com/bucket_name
If a bucket not exists, it will return a 404

authors: Prnyself Xuanwo

repo: aos-dev/go-service-qingstor


text:
文档问题

缺少使用文档，不知道如何安装，如何使用

只需要把这个库添加为项目依赖即可：
go get github.com/aos-dev/go-storage/v3

quick start 可以参见 https://github.com/aos-dev/go-storage#quick-start
我们现在正在写一些 example，可以关注一下我们的文档官网： https://aos.dev/docs/go-storage/index

authors: OldSmokeGun Xuanwo

repo: aos-dev/go-storage


text:
Fix broken ITs caused by #1892

On my last PR, #1892, which converted to pre-split tables, it was pointed out in a comment that the changes broke some ITs. This change fixes those broken ITs.

Thanks, @DomGarguilo !

authors: DomGarguilo ctubbsii

repo: apache/accumulo


text:
ARTEMIS-2813 Update MiniKDC and fix Kerberos tests on JDK 11+

Updates the MiniKDC dependency and adds another now needed dep in order
to get the Kerberos tests working on JDK 11+ builds.

Looks good, ran the tests on 8 and 11 without issue. Merged.

repo: apache/activemq-artemis


text:
MERGE does not see 'x' as a valid reuse

Describe the bug
The MERGE command doesn't see a valid case of variable reuse for a vertex.
How are you accessing AGE (Command line, driver, etc.)?
psql command line
What data setup do we need to do?
Setup shouldn't matter. However, this was done on an empty graph database.
What is the necessary configuration info needed?
AGE
What is the command that caused the error?
The following command fails, but the second 'x' should be seen as a valid reuse of 'x'. This command works successfully on Neo4j.
psql-11.5-5432-pgsql=# SELECT * FROM cypher('test', $$ MERGE (x:C)-[:A]->(x) RETURN x $$) as (r agtype);
ERROR:  multiple labels for variable 'x' are not supported
LINE 1: ...ELECT * FROM cypher('test', $$ MERGE (x:C)-[:A]->(x) RETURN ...
                                                             ^
psql-11.5-5432-pgsql=#

Expected behavior
It should create a vertex with a self loop.
Environment (please complete the following information):
current master branch
Additional context
None.

I have created PR #997 to address this and the issue with using a duplicated vertex (self loop) mentioned in a previous MERGE PR.

Resolved

repo: apache/age


text:
Fix issue 1124: Segmentation fault when using specific tables

This is a fix for issue 1124 -
Segmentation fault when using specific names for tables.
This issue is due to an oversight of some very specific types of tables that are parameterless functions. The logic to walk through these nodes didn't expect them and would crash due to them.
This fix adds in code to skip over these types of tables.
Added regression tests.

Looks good to me.

authors: dehowef jrgemignani


text:
feat: Add support for non auth plugins with ApisixConsumer

Description
Hey Team,
I'm looking to set up a consumer group via CRD, but I'm having trouble finding the specific CRD for that. Additionally, I've created the consumer using the YAML below. How can I incorporate a plugin into this consumer?
apiVersion: apisix.apache.org/v2
kind: ApisixConsumer
metadata:
  name: abc
spec:
  authParameter:
    keyAuth:
      value:
        key: "abc12345"

Any guidance on adding a plugin to this consumer would be appreciated!

@223311 You can configure the auth plugins in Consumer like the one example you have shown.
You can see the full schema here - https://github.com/apache/apisix-helm-chart/blob/master/charts/apisix-ingress-controller/crds/ApisixConsumer.yaml#L24

@223311 Currently ingress-controller doesn't allow configuring consumer group via ingress controller.

I created a feature request issue for track for supporting consumer group but it doesn't look like it will be next release.https://github.com/apache/apisix-ingress-controller/issues/2070

@223311 You can configure the auth plugins in Consumer like the one example you have shown. You can see the full schema here - https://github.com/apache/apisix-helm-chart/blob/master/charts/apisix-ingress-controller/crds/ApisixConsumer.yaml#L24
@Revolyssup  -Sure, I appreciate the response. However, I'm seeking guidance on adding a plugin to the consumer. From the CRD, it seems we can only pass an authentication parameter. If I aim to implement a rate limit for a specific consumer, how can we incorporate that?

@223311 Currently ApisixConsumer CR only supports auth plugins.

@223311 We can keep this issue for track though.

@Revolyssup We are also interested in exposing rate limit plugin for the Consumer; if you can provide guidance to my engineers; we'll be happy to contribute a PR

@leowmjw You can go ahead and create a PR for this. I can help you on it.

Hi, I want to do this, but I do not know how to make manifests for my changed CRD. It seems you use kubebuilder to generate manifests.
Could you give me some advice.

Hi, any news on this? Thanks

Hello! Is there a solution at this point in time?
We were surprised to find that ApisixConsumer (as an APISIX CRD configuration for Kubernetes) still does not support setting specific consumer parameters from our custom plugins or other built-in plugins (except for the 6 built-in authorization plugins).
@Revolyssup could you tell us please, is this improvement already planned in the roadmap or not?
Or maybe give instructions on how we can extend this standard helm chart so that the ApisixConsumer configuration supports passing additional parameters from other built-in or our custom plugins? Or any other workaround solution.

authors: 223311 Revolyssup bigfish02 fsteccanella ivlukyanov leowmjw

repo: apache/apisix-ingress-controller


text:
docs: update Contributor Guide

Fixes: #515

@juzhiyuan @liuxiran

repo: apache/apisix-website


text:
discussion: ConnectionGetObjects vs ConnectionGetTableSchema

What would you like help with?
ConnectionGetObjects is more general and more flexible but it doesn't return Arrow-specific type information. Having to call both of these APIs in the client might result in two round-trips to a server, which would be unfortunate. What if we were to do something like add a new column TABLE_SCHEMA.column_schema which contains a serialized Arrow schema? It would be null if the depth didn't include column information, of course.
Or am I missing something?

Possibly. It's long bugged me that Arrow schemas don't have a good Arrow-native representation.
The driver could cache too, of course, but that complicates things. It might have been better to return some secondary object (fetching data up front) that could then be queried separately (so you don't have to unwrap such a complicated schema)...
@zeroshade and I have also chatted a bit offline about possibly trying to break up GetObjects since the current version is a little inextensible. That, and it's unclear to me whether changing one of these 'fixed' schemas is a backwards compatibility break or not.

authors: CurtHagenlocher lidavidm

repo: apache/arrow-adbc


text:
Cannot query parquet files generated by Apache Spark from datafusion-cli

Describe the bug
I have a data set created by Apache Spark and I tried to query it from the DataFusion CLI. It failed, saying that a parquet file was corrupt.
 CREATE EXTERNAL TABLE store_sales STORED AS PARQUET LOCATION 'store_sales.dat';
0 rows in set. Query took 0.002 seconds.
❯ select count(*) from store_sales;
Parquet reader thread terminated due to error: ParquetError(General("Invalid Parquet file. Corrupt footer"))

I added some debug logging and found that it was actually trying to read the following file, which is not a Parquet file.
store_sales.dat/.part-00005-5142b177-bacb-499d-b14f-12de4b94d9d9-c000.snappy.parquet.crc

To Reproduce
Create a non-Parquet file with a non-Parquet extension and put it in a directory along with some valid parquet files.
Expected behavior
Should only try and read files with file extension .parquet.
Additional context
None

This is because we are not providing file extension as search suffix in https://github.com/apache/arrow-datafusion/blob/9c5ccae240ce38b084128e8d7ff0752d0e2318a6/datafusion/src/execution/context.rs#L232
I think the right behavior should be providing a default extension suffix and let user override if they are using something different.

@houqp plz assign this to me 😊.

It would also be nice if the error message could include the name of the file that is corrupt to make these issues easier to debug

authors: Ted-Jiang andygrove houqp

repo: apache/arrow-datafusion


text:
Support to use Schedular in tpch benchmark

Which issue does this PR close?

No
Rationale for this change

Support to test Schedular(the newest executor designed by @tustvold ) performance in tpch benchmark
What changes are included in this PR?

Support to use Schedular in tpch benchmark
Are these changes tested?

No need, I have checked in my local.
➜  benchmarks git:(master) ✗ cargo run --release --bin tpch -- benchmark datafusion --iterations 1 --path ~/parquet_data --format parquet --enable-scheduler --query 1
    Finished release [optimized] target(s) in 0.13s
     Running `/arrow-datafusion/target/release/tpch benchmark datafusion --iterations 1 --path /Users/xudong/parquet_data --format parquet --enable-scheduler --query 1`
Running benchmarks with the following options: DataFusionBenchmarkOpt { query: Some(1), debug: false, iterations: 1, partitions: 2, batch_size: 8192, path: "/Users/xudong/parquet_data", file_format: "parquet", mem_table: false, output_path: None, disable_statistics: false, enable_scheduler: true }
Query 1 iteration 0 took 3847.1 ms and returned 4 rows
Query 1 avg time: 3847.15 ms

Are there any user-facing changes?

No

This is a cool option! Just out of my own curiosity I've compared --enable-scheduler  vs not to see if there are any clear wins and there are a few queries where the scheduler outperforms by %10. Obviously, there are still some others with major degradations but with this option, it should be much easier to identify those cases and see the underlying cause.
┏━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━┓
┃ Query        ┃     Baseline ┃   Comparison ┃        Change ┃
┡━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━┩
│ Q1           │     643.67ms │     592.49ms │ +1.09x faster │
│ Q2           │     291.85ms │     262.98ms │ +1.11x faster │
│ Q3           │     373.14ms │    1028.82ms │  2.76x slower │
│ Q4           │     103.54ms │     105.93ms │     no change │
│ Q5           │     363.02ms │     714.48ms │  1.97x slower │
│ Q6           │     370.04ms │     374.17ms │     no change │
│ Q7           │     745.62ms │    1316.95ms │  1.77x slower │
│ Q8           │     471.89ms │     867.03ms │  1.84x slower │
│ Q9           │     651.69ms │     998.41ms │  1.53x slower │
│ Q10          │     432.42ms │    1165.39ms │  2.70x slower │
│ Q11          │     204.11ms │     173.80ms │ +1.17x faster │
│ Q12          │     186.74ms │     194.05ms │     no change │
│ Q13          │     404.37ms │     379.72ms │ +1.06x faster │
│ Q14          │     337.40ms │     413.87ms │  1.23x slower │
│ Q15          │     325.42ms │     624.71ms │  1.92x slower │
│ Q16          │     153.15ms │     155.41ms │     no change │
│ Q17          │    1931.96ms │    2051.97ms │  1.06x slower │
│ Q18          │    1349.79ms │    1280.70ms │ +1.05x faster │
│ Q19          │     621.30ms │     683.34ms │  1.10x slower │
│ Q20          │     609.66ms │     642.90ms │  1.05x slower │
│ Q21          │     628.37ms │     710.87ms │  1.13x slower │
│ Q22          │      65.89ms │      65.55ms │     no change │
└──────────────┴──────────────┴──────────────┴───────────────┘

@isidentical It's expected.
There is a tracking issue: https://github.com/apache/arrow-datafusion/issues/2504
I add the Option because I plan to iterate our new executor with @tustvold, the option will help check some iterations quickly.

Perhaps when I finish up integrating the row format everywhere I'll have some more time to work on this 😄

I'll start to do it after work and look forward to seeing you back!


text:
can't build a docker image

Trying to build with postgres 17 in a ubuntu 22 image, I get this :
7.049 Found ninja-1.11.1 at /usr/bin/ninja
7.634 ninja: Entering directory `/apache-arrow-flight-sql-postgresql-0.1.0.build'
14.53 [1/2] Compiling C++ object arrow_flight_sql.so.p/src_afs.cc.o
14.53 FAILED: arrow_flight_sql.so.p/src_afs.cc.o
14.53 c++ -Iarrow_flight_sql.so.p -I. -I../apache-arrow-flight-sql-postgresql-0.1.0 -I/usr/include -fdiagnostics-color=always -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -std=c++17 -O0 -g -fPIC -fPIC -isystem/usr/include/postgresql/17/server -MD -MQ arrow_flight_sql.so.p/src_afs.cc.o -MF arrow_flight_sql.so.p/src_afs.cc.o.d -o arrow_flight_sql.so.p/src_afs.cc.o -c ../apache-arrow-flight-sql-postgresql-0.1.0/src/afs.cc
14.53 ../apache-arrow-flight-sql-postgresql-0.1.0/src/afs.cc: In member function ‘virtual arrow::Result<std::unique_ptr<arrow::flight::FlightInfo> > {anonymous}::FlightSQLServer::GetFlightInfoStatement(const arrow::flight::ServerCallContext&, const arrow::flight::sql::StatementQuery&, const arrow::flight::FlightDescriptor&)’:
14.53 ../apache-arrow-flight-sql-postgresql-0.1.0/src/afs.cc:2673:99: error: no matching function for call to ‘arrow::flight::FlightEndpoint::FlightEndpoint(<brace-enclosed initializer list>)’
14.53  2673 |                         arrow::flight::FlightEndpoint{arrow::flight::Ticket{std::move(ticket)}, {}}};
14.53       |                                                                                ^

Do you know why could this happen ?
dependencies :
RUN set -ex; \
    apt-get update && apt-get install -y -V \
    ca-certificates \
    lsb-release \
    wget \
    gnupg \
    postgresql-common \
    apt-transport-https \
    meson \
    ninja-build \
    cmake \
    build-essential \
    libkrb5-dev \
    libpq-dev \
    && wget https://apache.jfrog.io/artifactory/arrow/$(lsb_release --id --short | tr 'A-Z' 'a-z')/apache-arrow-apt-source-latest-$(lsb_release --codename --short).deb \
    && apt-get install -y -V ./apache-arrow-apt-source-latest-$(lsb_release --codename --short).deb \
    && apt-get clean

RUN set -ex; \
    apt-get update && apt-get install -y -V \
    libarrow-dev \
    libarrow-glib-dev \
    libarrow-dataset-dev \
    libarrow-dataset-glib-dev \
    libarrow-acero-dev \
    libarrow-flight-dev \
    libarrow-flight-glib-dev \
    libarrow-flight-sql-dev \
    libarrow-flight-sql-glib-dev \
    libgandiva-dev \
    libgandiva-glib-dev \
    libparquet-dev \
    libparquet-glib-dev \
    && apt-get clean

maybe a compiler version ?

Ah, Apache Arrow C++ API is changed.
We need to follow the change.

what is the last version that worked with 0.1.0 ?

Apache Arrow C++ 17.0.0 or 16.1.0 will work.

thanks

Ah, sorry. Apache Arrow C++ 13.0.0 or later may not work...

How can I do this step :+1:
    && wget https://apache.jfrog.io/artifactory/arrow/$(lsb_release --id --short | tr 'A-Z' 'a-z')/apache-arrow-apt-source-latest-$(lsb_release --codename --short).deb \
    && apt-get install -y -V ./apache-arrow-apt-source-latest-$(lsb_release --codename --short).deb \
    && apt-get clean

To select the version that works ? I am not familiar with this repository format ! Thanks

Could you try this?
    apt-get update && apt-get install -y -V \
    libarrow-dev=12.0.1-1 \
    libarrow-flight-dev=12.0.1-1 \
    libarrow-flight-sql-dev=12.0.1-1 \

1.630 Reading package lists...
3.321 + apt-get install -y -V libarrow-dev=12.0.1-1 libarrow-glib-dev=12.0.1-1 libarrow-dataset-dev=12.0.1-1 libarrow-dataset-glib-dev=12.0.1-1 libarrow-acero-dev=12.0.1-1 libarrow-flight-dev=12.0.1-1 libarrow-flight-glib-dev=12.0.1-1 libarrow-flight-sql-dev=12.0.1-1 libarrow-flight-sql-glib-dev=12.0.1-1 libgandiva-dev=12.0.1-1 libgandiva-glib-dev=12.0.1-1 libparquet-dev=12.0.1-1 libparquet-glib-dev=12.0.1-1
3.337 Reading package lists...
5.066 Building dependency tree...
5.453 Reading state information...
5.494 Package libarrow-acero-dev is not available, but is referred to by another package.
5.494 This may mean that the package is missing, has been obsoleted, or
5.494 is only available from another source
5.494
5.494 Package libparquet-dev is not available, but is referred to by another package.
5.494 This may mean that the package is missing, has been obsoleted, or
5.494 is only available from another source
5.494
5.494 Package libarrow-dev is not available, but is referred to by another package.
5.494 This may mean that the package is missing, has been obsoleted, or
5.494 is only available from another source
5.494
5.494 Package libarrow-glib-dev is not available, but is referred to by another package.
5.494 This may mean that the package is missing, has been obsoleted, or
5.494 is only available from another source

No chance this way, will see if I can find a proper way to do it

Could you share full Dockerfile?

authors: journeytosilius kou

repo: apache/arrow-flight-sql-postgresql


text:
Add delete_prefixed method to ObjectStore trait

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

Currently the way to delete a "directory" through the ObjectStore interface is to call list with the directory path as prefix and then pipe that to delete_stream.
This is the correct way to do this for object storage since "directories" don't really exist and the path is just a prefix to individual objects.
But for actual filesystems directories are actual inodes themselves in the filesystem which should be cleaned up.
Describe the solution you'd like

Add a new method to ObjectStore: async fn delete_prefix(&self, prefix: Option<&Path>) -> Result<()>
This default implementation for this method can just be calling list(prefix) and then piping that to delete_stream but in the case of LocalFilesystem (and potentially other implementations in the future) will be specialized to also delete directories
Describe alternatives you've considered

This could be handled inside LocalFilesystem during delete_stream but could become complicated. The implementation would have to:

Track prefixes during the delete operation
After delete determine if any of the prefixes are now empty
Delete them

Additional context

My personal preference would be an option for empty directories to be automatically cleaned up, as this is closer to the semantics of object stores, and should be a relatively straightforward case of calling std::fs::remove_dir on each parent until it errors.
Alternatively we could allow LocalFilesystem::delete to delete directories if that is what the path points to, I'm a little more lukewarm on this as it sort of leaks out of the abstraction.
I am not a fan of a delete_prefix method that has subtely divergent behaviour from standard deletion, I suspect users will find this surprising

I think we can do it automatically by changing delete code for local fs a bit:
async fn delete(&self, location: &Path) -> Result<()> {
        let config = Arc::clone(&self.config);
        let path = self.path_to_filesystem(location)?;
        maybe_spawn_blocking(move || {
            if let Err(e) = std::fs::remove_file(&path) {
                Err(match e.kind() {
                    ErrorKind::NotFound => Error::NotFound { path, source: e }.into(),
                    _ => Error::UnableToDeleteFile { path, source: e }.into(),
                })
            } else {
                let root = config.root.to_file_path().unwrap();
                let mut parent = path.parent();

                while let Some(loc) = parent {
                    if loc != root && std::fs::remove_dir(loc).is_ok() {
                        parent = loc.parent();
                    } else {
                        break;
                    }
                }

                Ok(())
            }
        })
        .await
    }

We should definitely make this opt-in to avoid surprises, but ^ sounds good to me

I'm perfectly fine with doing this internal to LocalFilesystem to minimize changes but to make the argument for the new method:

It is a useful shorthand for an operation that should be reasonably common even with non-filesystem implementations.
It can be formulated in terms of the default implementation of existing methods so won't break anything
Handling it internal to LocalFilesystem requires doing a bunch of unnecessary filesystem operations (and their associated syscalls) since we have to try and delete the parent directory after deleting each file.

Perhaps we could quantify the performance impact of the additional syscalls? I don't disagree that the operation is relatively common, but I also think consistency is very important, if only some methods cleanup directories it makes for a confused UX IMO.

I think it's good to have such a short-cut  for list + deleted as additionally to handling empty dirs it can be more efficient in some implementation

Also, we can keep both approaches together without too much harm to the UX

if only some methods cleanup directories it makes for a confused UX IMO

IMO the internalized implementation is more confusing UX-wise. I would not necessarily expect deleting a file to also delete its parent directory which is what would happen. And while deleting the empty directories is the concrete issue we are facing, I think the ability to to recursively delete objects under a path makes sense as discrete operation on its own terms.

Given you clearly feel strongly on the matter, let's just add a delete_all method with a default implementation using list and delete_stream.

Added suggested changes in a #5975

IMHO, we're talking about two different things here:

prefix deletion: Should we offere an API for ALL implementations (with fallback) that allows quick prefix-based deletion. I think the question is mostly if any cloud stored actually support this. For the local store, this is mostly irrelevant (see next point as well) because under the hood a prefix-deletion is the same as "list prefix"+"delete" (at least under Unix you cannot just delete a directory, you have to empty it first).
directory management for file-based object store: As others pointed out, directories are only an auxiliary data structure for file-based object stores. They have zero meaning for the key-value semantic of the object store. In theory, we could encode the file-based keys in a way that we don't need directories at all, but most people would find this confusing and some operations like "list prefix" would be considerably slower. That said, I think the object store should by default (maybe via opt-out) clean up the auxiliary structures it creates. Sure that's expensive, but to implement an FS-based store correctly, you need a bunch of syscalls anyways (e.g. to prevent the creation of partially written files) and tokio isn't the most efficient way to do file-based IO. So if you use this store and you have that many files that the per-file overhead is too large, I think you lost this game even prior to the implementation of the clean-up logic.

@fsdvh  has a nice PR here to add optional "clean empty directories for local filesystem":  https://github.com/apache/arrow-rs/pull/5978
I think this reflects the consensus of discussion on this ticket. Please take a look when you have time.

authors: alamb crepererum fsdvh thinkharderdev tustvold

repo: apache/arrow-rs


text:
[CI][Python] Pandas upstream_devel and nightlies are failing

Describe the bug, including details regarding any error messages, version, and platform.
The following pandas testing jobs have started failing:

test-conda-python-3.8-pandas-nightly
test-conda-python-3.9-pandas-upstream_devel

There are a couple of test failures:
 =================================== FAILURES ===================================
_____ TestConvertDateTimeLikeTypes.test_timestamp_to_pandas_out_of_bounds ______

self = <pyarrow.tests.test_pandas.TestConvertDateTimeLikeTypes object at 0x7fdc7d41bb40>

    def test_timestamp_to_pandas_out_of_bounds(self):
        # ARROW-7758 check for out of bounds timestamps for non-ns timestamps

        for unit in ['s', 'ms', 'us']:
            for tz in [None, 'America/New_York']:
                arr = pa.array([datetime(1, 1, 1)], pa.timestamp(unit, tz=tz))
                table = pa.table({'a': arr})

                msg = "would result in out of bounds timestamp"
                with pytest.raises(ValueError, match=msg):
                    arr.to_pandas()

                with pytest.raises(ValueError, match=msg):
                    table.to_pandas()

                with pytest.raises(ValueError, match=msg):
                    # chunked array
                    table.column('a').to_pandas()

                # just ensure those don't give an error, but do not
                # check actual garbage output
                arr.to_pandas(safe=False)
                table.to_pandas(safe=False)
>               table.column('a').to_pandas(safe=False)

opt/conda/envs/arrow/lib/python3.8/site-packages/pyarrow/tests/test_pandas.py:1461:
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
pyarrow/array.pxi:837: in pyarrow.lib._PandasConvertible.to_pandas
    ???
pyarrow/table.pxi:469: in pyarrow.lib.ChunkedArray._to_pandas
    ???
opt/conda/envs/arrow/lib/python3.8/site-packages/pandas/core/dtypes/dtypes.py:848: in __from_arrow__
    array = array.cast(pyarrow.timestamp(unit=self._unit), safe=True)
pyarrow/table.pxi:551: in pyarrow.lib.ChunkedArray.cast
    ???
opt/conda/envs/arrow/lib/python3.8/site-packages/pyarrow/compute.py:400: in cast
    return call_function("cast", [arr], options, memory_pool)
pyarrow/_compute.pyx:572: in pyarrow._compute.call_function
    ???
pyarrow/_compute.pyx:367: in pyarrow._compute.Function.call
    ???
pyarrow/error.pxi:144: in pyarrow.lib.pyarrow_internal_check_status
    ???
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _

>   ???
E   pyarrow.lib.ArrowInvalid: Casting from timestamp[s, tz=America/New_York] to timestamp[ns] would result in out of bounds timestamp: -62135596800

pyarrow/error.pxi:100: ArrowInvalid
__________________ test_chunked_array_to_pandas_preserve_name __________________

    @pytest.mark.pandas
    def test_chunked_array_to_pandas_preserve_name():
        # https://issues.apache.org/jira/browse/ARROW-7709
        import pandas as pd
        import pandas.testing as tm

        for data in [
                pa.array([1, 2, 3]),
                pa.array(pd.Categorical(["a", "b", "a"])),
                pa.array(pd.date_range("2012", periods=3)),
                pa.array(pd.date_range("2012", periods=3, tz="Europe/Brussels")),
                pa.array([1, 2, 3], pa.timestamp("ms")),
                pa.array([1, 2, 3], pa.timestamp("ms", "Europe/Brussels"))]:
            table = pa.table({"name": data})
            result = table.column("name").to_pandas()
>           assert result.name == "name"
E           AssertionError: assert None == 'name'
E            +  where None = 0   2012-01-01 00:00:00+01:00\n1   2012-01-02 00:00:00+01:00\n2   2012-01-03 00:00:00+01:00\ndtype: datetime64[ns, Europe/Brussels].name

opt/conda/envs/arrow/lib/python3.8/site-packages/pyarrow/tests/test_table.py:348: AssertionError

This is happening on the 12.0.0 maintenance branch, meaning there has been something introduced on Pandas.
Component(s)
Continuous Integration, Python

@jorisvandenbossche @AlenkaF I don't think this would require a fix on our side for the 12.0.0 but I would appreciate your thoughts on this one.

The failure on pyarrow/tests/test_pandas.py::TestConvertDateTimeLikeTypes::test_timestamp_to_pandas_out_of_bounds seems related with Timezone, because it passes locally with pandas dev if I just do this:
$ git diff
diff --git a/python/pyarrow/tests/test_pandas.py b/python/pyarrow/tests/test_pandas.py
index 60c4831..129502b 100644
--- a/python/pyarrow/tests/test_pandas.py
+++ b/python/pyarrow/tests/test_pandas.py
@@ -1458,7 +1458,11 @@ class TestConvertDateTimeLikeTypes:
                 # check actual garbage output
                 arr.to_pandas(safe=False)
                 table.to_pandas(safe=False)
-                table.column('a').to_pandas(safe=False)
+                if not tz:
+                    table.column('a').to_pandas(safe=False)
+                else:
+                    with pytest.raises(pa.ArrowInvalid, match=msg):
+                        table.column('a').to_pandas(safe=False)

     def test_timestamp_to_pandas_empty_chunked(self):
         # ARROW-7907 table with chunked array with 0 chunks

Taking a look on the latest pandas commits: https://github.com/pandas-dev/pandas/commits/main
it might be related to: https://github.com/pandas-dev/pandas/pull/52677
but I am unsure

I have came to the same conclusion. Both tests are failing if tz is not None.
There have been three PRs merged in the last day on the Pandas side:

https://github.com/pandas-dev/pandas/pull/52769
https://github.com/pandas-dev/pandas/pull/52767
https://github.com/pandas-dev/pandas/pull/52762

and the PR that you linked, Rauls, seems the closest to being the reason for this. But I haven't managed to figure out the connection.

Here is an update after going through the issue with Joris:

the first failing test where we get the casting error is happening due to the change on the Pandas side with https://github.com/pandas-dev/pandas/pull/52201. Due to __from_pyarrow__ being added for pandas DatetimeTZDtype the conversion of the column in a table on the arrow side is now happening through this method and not through _array_like_to_pandas as it did before. Because in pyarrow we still cast datetime types to ns resolution (https://github.com/apache/arrow/issues/34462), the __from_pyarrow__ on the pandas side receives the casted data type (that is in ns resolution) and does the casting there but fails as the value is out of bounds.
For now I will skip this test for dev version of pandas as this is a bigger issue that needs to be solved in pyarrow for 13.0.0 (https://github.com/apache/arrow/issues/33321).

the second failing test has the same root cause but can be fixed easily by passing name to pandas_api.series(arr) in _to_pandas() (table.pxi)

I will create a PR asap to skip/fix the tests.

Thanks @AlenkaF ! I am marking this issue for 12.0.0 and as a blocker. Will hold to create the RC until this is merged.

authors: AlenkaF raulcd

repo: apache/arrow


text:
ARROW-8825: [C++] Fix compilation for Wunused-paraemter flag

add a compiler hint to tell the compiler that the unused-parameter is by default.

This needs to rebased so I'll open a new PR


text:
[Bug]: Using WriteToBigQuery FILE_LOADS in a streaming pipeline does not remove temporary tables

What happened?
More details are here: https://stackoverflow.com/questions/64526500/using-writetobigquery-file-loads-in-a-streaming-pipeline-just-creates-a-lot-of-t
Issue Priority
Priority: 3 (minor)
Issue Components

[X] Component: Python SDK
[ ] Component: Java SDK
[ ] Component: Go SDK
[ ] Component: Typescript SDK
[X] Component: IO connector
[ ] Component: Beam YAML
[ ] Component: Beam examples
[ ] Component: Beam playground
[ ] Component: Beam katas
[ ] Component: Website
[ ] Component: Spark Runner
[ ] Component: Flink Runner
[ ] Component: Samza Runner
[ ] Component: Twister2 Runner
[ ] Component: Hazelcast Jet Runner
[ ] Component: Google Cloud Dataflow Runner

Any update on this? It is still happening with the 2.53.0 version.

authors: liferoad shresthapradip

repo: apache/beam


text:
[BEAM-14001] Add missing test cases to existing suites in exec package

Adds extra cases to existing test suites to catch code that was previously untested.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

authors: asf-ci jrmccluskey


text:
[BEAM-1718] Handle Infinite Skew in SimpleDoFnRunner

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

[x] Make sure the PR title is formatted like:
[BEAM-<Jira issue #>] Description of pull request
[x] Make sure tests pass via mvn clean verify. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
[x] Replace <Jira issue #> in the title with the actual Jira issue
number, if there is one.
[x] If this contribution is large, please file an Apache
Individual Contributor License Agreement.

Deprecate getAllowedTimestampSkew

Coverage increased (+0.01%) to 70.127% when pulling feefa8e128f9f7c874f8f68432ec08d38b1b12e0 on tgroh:infinite_skew into b672cde111b2f11d185479e1d208e63ef6ff322e on apache:master.

retest this please

Coverage increased (+0.008%) to 70.124% when pulling feefa8e128f9f7c874f8f68432ec08d38b1b12e0 on tgroh:infinite_skew into b672cde111b2f11d185479e1d208e63ef6ff322e on apache:master.

Coverage increased (+0.001%) to 70.117% when pulling d84a81f177ea21c6fe8cbc1ddba9dba0423577a8 on tgroh:infinite_skew into b672cde111b2f11d185479e1d208e63ef6ff322e on apache:master.

R: @jkff OR @kennknowles OR @bjchambers

Coverage decreased (-0.1%) to 69.981% when pulling e79759e314155f0881c64ebe7aad60f06ac40125 on tgroh:infinite_skew into b672cde111b2f11d185479e1d208e63ef6ff322e on apache:master.

authors: coveralls tgroh


text:
[BEAM-1672] Extract interface MetricData

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

[x] Make sure the PR title is formatted like:
[BEAM-<Jira issue #>] Description of pull request
[x] Make sure tests pass via mvn clean verify. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
[x] Replace <Jira issue #> in the title with the actual Jira issue
number, if there is one.
[ ] If this contribution is large, please file an Apache
Individual Contributor License Agreement.

Pull up similar methods in DistributionData/GaugeData into an interface
and create a similar CounterData. This makes for cleaner code and will
ease implementing metrics support for runner writers.

Run Spark ValidatesRunner

Run Dataflow ValidatesRunner

Coverage decreased (-0.02%) to 70.072% when pulling aa41c2cbe28797686a34eb47c26502953c86b462 on aviemzur:metricdata-interface into dc672f42083c375872d87030523545866cea4f55 on apache:master.

Dataflow postcommit is broken for about 2 days now, so probably unrelated.

R: @bjchambers

Run Spark ValidatesRunner

retest this please

Run Spark ValidatesRunner

Coverage decreased (-0.01%) to 70.076% when pulling 50e4bb9011bf19dcfcd4e93c76d13c5799e8af1e on aviemzur:metricdata-interface into cd77033b5237c99c160afcf10e69b13837b8dbfa on apache:master.

Coverage decreased (-0.02%) to 70.072% when pulling 50e4bb9011bf19dcfcd4e93c76d13c5799e8af1e on aviemzur:metricdata-interface into cd77033b5237c99c160afcf10e69b13837b8dbfa on apache:master.

Can you elaborate in the commit description on why we want to extract this?

@bjchambers added to commit description (and PR description).

Coverage decreased (-0.01%) to 70.431% when pulling 46c9d7f714658ff03bc57696204e424e2b5f763f on aviemzur:metricdata-interface into 4daac664426da06268fa84a0a07793f818ce3913 on apache:master.

Closing this PR for now as https://github.com/apache/beam/pull/2649 does a better job at reducing LOC and duplication between runners.

authors: aviemzur bjchambers coveralls


text:
Workaround for Jenkins DSL Sandboxing

Signed-off-by: Jason Kuster jasonkuster@google.com
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

[ ] Make sure the PR title is formatted like:
[BEAM-<Jira issue #>] Description of pull request
[ ] Make sure tests pass via mvn clean verify. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
[ ] Replace <Jira issue #> in the title with the actual Jira issue
number, if there is one.
[ ] If this contribution is large, please file an Apache
Individual Contributor License Agreement.

Run Seed Job

Changes Unknown when pulling b271ac9b7466150468879100c35f4e87f1ddb1e8 on jasonkuster:groovy-eval into ** on apache:master**.

Run Seed Job

Run Seed Job

This PR has been changed to copy the contents of common_job_properties.groovy into each job as a build step.

Coverage decreased (-0.5%) to 70.136% when pulling bbc6bf8c45729bceb0d552a2871b5c126eeb6f15 on jasonkuster:groovy-eval into 8f4bb0158cecb8c4144766706fa9d70b094fc88d on apache:master.

Coverage decreased (-0.5%) to 70.146% when pulling bbc6bf8c45729bceb0d552a2871b5c126eeb6f15 on jasonkuster:groovy-eval into 8f4bb0158cecb8c4144766706fa9d70b094fc88d on apache:master.

Run Seed Job

R: @davorbonaci

Obsolete? Close?

authors: coveralls davorbonaci jasonkuster


text:
[BEAM-165] Initial implementation of the MapReduce runner.

Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Make sure there is a JIRA issue filed for the change (usually before you start working on it).  Trivial changes like typos do not require a JIRA issue.  Your pull request should address just this issue, without pulling in other changes.
[ ] Each commit in the pull request should have a meaningful subject line and body.
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue.
[ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[ ] Run mvn clean verify to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

R: @kennknowles @jbonofre

retest this please

Changes Unknown when pulling caedb2bfd11618eb2b40e59dc48a87dc87ccc994 on peihe:mr-runner into ** on apache:mr-runner**.

Changes Unknown when pulling caedb2bfd11618eb2b40e59dc48a87dc87ccc994 on peihe:mr-runner into ** on apache:mr-runner**.

retest this please

retest this please

retest this please

retest this please

Changes Unknown when pulling 32aeb7ac3d49ade0dc3ad79e711e7b624091d485 on peihe:mr-runner into ** on apache:mr-runner**.

@kennknowles
PTAL
build and validates runners test passed

authors: coveralls peihe


text:
[BEAM-2545] Updates bigtable.version to 1.0.0-pre3.

Performs a slight update to BigtableServiceImpl to comply with the new version.
Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Make sure there is a JIRA issue filed for the change (usually before you start working on it).  Trivial changes like typos do not require a JIRA issue.  Your pull request should address just this issue, without pulling in other changes.
[ ] Each commit in the pull request should have a meaningful subject line and body.
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue.
[ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[ ] Run mvn clean verify to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

Coverage decreased (-0.01%) to 69.68% when pulling 27d95db2a22738d16177157b69f87deff58477db on chamikaramj:update_bigtable_dependency into 80c86f81b40e2342bff5bec4a5a1162b5cf67b14 on apache:master.

R: @sduskis

Coverage decreased (-0.003%) to 69.686% when pulling 0879500cfba3d8c798af796bf87c65b94f08eeb5 on chamikaramj:update_bigtable_dependency into 80c86f81b40e2342bff5bec4a5a1162b5cf67b14 on apache:master.

LGTM.  Thanks for the change.
Ugh... I forgot about the API change that included the InterruptedException.

Thanks.
cc: @kennknowles

BT tests passed with the updated jar: https://builds.apache.org/view/A-D/view/Beam/job/beam_PostCommit_Java_MavenInstall/4751/org.apache.beam$beam-runners-google-cloud-dataflow-java/testReport/org.apache.beam.sdk.io.gcp.bigtable/

authors: chamikaramj coveralls sduskis


text:
[BEAM-6212] MongoDbIO add ordered option (inserts documents even if errors)

to support failure of pipeline, we need the option to be idempotent, so we need the option to ignore duplicates
@jbonofre
Post-Commit Tests Status (on master branch)

Lang
SDK
Apex
Dataflow
Flink
Gearpump
Samza
Spark

Go

---
---
---
---
---
---

Java

Python

---

---
---
---

Merged manually because I did some minor fixes.

Thanks @chaimt

authors: chaimt iemejia


text:
[BEAM-5709] Changing sleeps to CountdownLatch in test

Pretty straightforward. Changing the somewhat clunky sleep call to a
latch, and adds a timeout to the test.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[x] Choose reviewer(s) and mention them in a comment (R: @username).
[x] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

Post-Commit Tests Status (on master branch)

Lang
SDK
Apex
Dataflow
Flink
Gearpump
Samza
Spark

Go

---
---
---
---
---
---

Java

Python

---

---
---
---

Pre-Commit Tests Status (on master branch)

---
Java
Python
Go
Website

Non-portable

Portable
---

---
---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

R: @boyuanzz
Quick update based on @kennknowles comments in this older PR https://github.com/apache/beam/pull/6639


text:
[BEAM-7305] Improve and extend Hazelcast Jet based Java Runner

added support for Beam UnboundedSources
optimised how Jet DAG is wired together
sorted out various metrics related issues
improved on how JetPipelineResult works
removed side input related hack
made cluster member count configurable
done a bit of cleanup

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

Post-Commit Tests Status (on master branch)

Lang
SDK
Apex
Dataflow
Flink
Gearpump
Samza
Spark

Go

---
---
---
---
---
---

Java

Python

---

---
---
---

Pre-Commit Tests Status (on master branch)

---
Java
Python
Go
Website

Non-portable

Portable
---

---
---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

R: @mxm
R: @kennknowles

Hi @mxm. Yes, I was pondering it yesterday if I should make this pull request out of multiple change-sets or squash them down to a single one... I might not have made the best choice...
The thing is that I'm dumping months of my work into these two change-sets, that's why it looks so non-incremental. The actual development has been done in https://github.com/hazelcast/hazelcast-jet-beam-runner, there are 100+ commits there (debugging has proven simpler if working like this, worth the effort of migrating later). Anyways, from now on pace of development should be slower and I will make it more incremental by issuing more frequent PRs.
As far as reviews are concerned, they have been done to some degree on our module by my Hazelcast colleagues. Here we would need somebody both impartial to Hazelcast and with knowledge of Jet, might be not that simple to find.

In the long run it would be nice to have other contributors to the Jet Runner. Of course this can take a bit. I think the first step would be to have the review process with your colleagues here instead of in the fork.

Ok, we'll try to do further development here instead of our own runner repo.

authors: jbartok mxm


text:
BIGTOP-4081: Add knox support

Description of PR
Thank you very much, cheelio for woring on this https://github.com/apache/bigtop/pull/1029
99% of the work on this PR was contributed by cheelio. Due to cheelio's long absence of response and inactivity on this PR, it has been resubmitted in the hope of continuing to drive this matter forward. Based on the original PR, support for pkg suffix has been added, and the version has been updated to 2.0, along with some fixes for 2.0.
The significance of this effort lies in its ability to enhance Knox functionality, particularly in clusters employing Kerberos. Knox's proxy access capabilities provide an intuitive means for users to access the UI interface of Kerberos-enabled clusters.
How was this patch tested?
smoke test and manual test
tested on rocky8
./docker-hadoop.sh -d --create 1 --image bigtop/puppet:trunk-rockylinux-8 --docker-compose-plugin --memory 8g --repo file:///bigtop-home/output --disable-gpg-check --stack knox --smoke-tests knox

tested on debian11
./docker-hadoop.sh -d -dcp -C config_debian-11.yaml -F docker-compose.yml -G -L -k knox  -s knox -c 1

tested on ambari deploy
. /etc/profile.d/bigtop.sh;./gradlew knox-clean knox-pkg -PparentDir=/usr/bigtop -PpkgSuffix -PbuildThreads=2C repo

For code changes:

[ ] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'BIGTOP-3638. Your PR title ...')?
[ ] Make sure that newly added files do not have any licensing issues. When in doubt refer to https://www.apache.org/licenses/

@iwasakims @guyuqi @kevinw66

@iwasakims @guyuqi @kevinw66 Could you help review this pr?

repo: apache/bigtop


text:
Remove YAML tags from CM output

What "adaptForSaltYamlTypes" does is pass a string to the "java.lang.String" constructor. No point in that, use the argument string directly.

👍  looks good and doesn't break org.apache.brooklyn.entity.cm.salt.HighstateTest, which includes use of the "!!python/unicode" form; merging.

authors: geomacy neykov

repo: apache/brooklyn-library


text:
BROOKLYN-396: test and fix

When rebinding a location, if a config flag corresponds to a field
with @SetFromFlag then just set the field, and don’t leave the
key-value inside config().getBag().
Some classes use fields to store internal state, which should not be
passed to child locations (e.g. LocalhostMachineProvisioningLocation.origConfigs).

It's concerning that the implementation of BasicLocationRebindSupport.addConfig() is very different from BasicEntityRebindSupport and BasicPolicyRebindSupport.
But I don't want to try changing that stuff now. It's one to mull over, and change in the future (possibly next time we're doing major work on rebind).

@aledsage the fix looks good. The blueprint I gave in 396 resizes correctly after rebind.
In the comments on the issue you wrote that "I presume the solution will be to improve what we store in the origConfigs (e.g. so that the sub-machines don't inherit it)." Is origConfigs doing the right thing? Or have we side-stepped it?

@sjcorbett this change ensures the origConfigs has the right thing.
The intent of origConfigs is to remember the state of the location from before we returned it, so if a BYON gets it back and then gives it out again, it can reset the config to what it was originally. This means that origConfigs is a map from MachineLocation instance to its config map.

Merging now.

authors: aledsage sjcorbett

repo: apache/brooklyn-server