text:
Issue servers do only get deleted from database, but not filesystem.

just checked my local files and there seems to be an issue deleting servers. they did get removed from the database, but they did not get removed from the local filesystem.
The logs look okay, however there is only one small difference between a successful and an unsuccessful deletion.
This is a successfull deletion:
[GIN] 2021/02/09 - 18:43:47 | 200 |    2.181215ms |  109.250.97.254 | GET      "/proxy/daemon/socket/2af45241"
[GIN] 2021/02/09 - 18:43:53 | 401 |       4.067Âµs |       127.0.0.1 | GET      "/daemon"
[INFO] Destroying server 2af45241
[GIN] 2021/02/09 - 18:43:53 | 204 |    8.651443ms |       127.0.0.1 | DELETE   "/daemon/server/2af45241"
[GIN] 2021/02/09 - 18:43:54 | 204 |    37.50789ms |  109.250.97.254 | DELETE   "/api/servers/2af45241"
[ERROR] Error proxying socket: websocket: close 1005 (no status)
[ERROR] error on reading from websocket: websocket: close 1006 (abnormal closure): unexpected EOF
[GIN] 2021/02/09 - 18:43:54 | 200 |      2.1344ms |  109.250.97.254 | GET      "/api/servers?page=1&limit=10"

while this is an unsuccessful one:
[GIN] 2020/09/14 - 17:22:17 | 200 |     650.039Âµs |       127.0.0.1 | GET      /daemon/server/3ee93ba2/data
[GIN] 2020/09/14 - 17:22:17 | 200 |    2.476271ms | 109.250.102.204 | GET      /proxy/daemon/server/3ee93ba2/data
[GIN] 2020/09/14 - 17:22:22 | 401 |       6.986Âµs |       127.0.0.1 | GET      /daemon
[GIN] 2020/09/14 - 17:22:22 | 204 |     455.036Âµs |       127.0.0.1 | DELETE   /daemon/server/3ee93ba2
[GIN] 2020/09/14 - 17:22:22 | 204 |   20.382152ms | 109.250.102.204 | DELETE   /api/servers/3ee93ba2
[ERROR] Error proxying socket: websocket: close 1005 (no status)
[ERROR] error on reading from websocket: websocket: close 1006 (abnormal closure): unexpected EOF
[GIN] 2020/09/14 - 17:22:23 | 200 |    4.481847ms | 109.250.102.204 | GET      /api/servers?page=1&limit=10

Which mainly misses this line:
[INFO] Destroying server ffffffff
The last time a server wasn't removed correctly was back in September, so this line is either new in the latest version of pufferpanel, or it might be a hint on whats wrong.
Maybe this is already known and fixed, but I thought I better report it, just in case.

This happens to me too, every time I login to pufferpanel I get a flash of like all the servers including the deleted ones and then it goes back to just being the servers that are active. I also can't create new servers with the same name as servers that have been deleted

This is resolved in 2.3.2

It's only resolved for new deletions, previous deletions still show up like
before, is there any way to properly get rid of these?
On Wed, 22 Sep 2021, 15:49 Joshua Taylor, @.***> wrote:

This is resolved in 2.3.2
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/PufferPanel/PufferPanel/issues/991#issuecomment-925004121,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ATRDGDXX557RMNWBPFSKWPDUDHUHTANCNFSM4XLSR7UQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

It's only resolved for new deletions, previous deletions still show up like before, is there any way to properly get rid of these?

This issue is about files not getting deleted properly (not the DB entries) You can delete the server folders on your node normally via ssh.
All the Infos for the panel itself are located in the "database.db" file located in your pufferpanel install location.
If you need to clean it up, I would recommend shutting down pufferpanel, downloading and then opening the database.db in something like https://sqlitebrowser.org/).
You can then modify the database to your liking and remove faulty stuff.
If you feel uncomfortable by modifying a database by hand (which is bad practice anyway) you can execute the attached query.
In the first line of the query you need to list the identifiers of the servers which did not get deleted properly.
I recommend comparing the server folders with the "servers" table in the database to get the differences.
Once you adjusted the script just run it. It will then:

delete the specified servers
clean up the permissions table
reset user defined server lists
clean up user settings

Next you save the adjusted database.db and put it back on the server and start pufferpanel back up.
Here the script:
DELETE FROM servers WHERE servers.identifier IN ('bf2932d8', '4e4dd0d2', 'bbb22342');
DELETE FROM permissions WHERE permissions.server_identifier NOT NULL AND permissions.server_identifier NOT IN (Select identifier FROM servers);
DELETE FROM permissions WHERE permissions.user_id NOT IN (Select id FROM users);
DELETE FROM user_settings WHERE user_settings.key = 'serverList';
DELETE FROM user_settings WHERE user_settings.user_id NOT IN (Select id FROM users);

Okie dokie, thank you :)
On Thu, 23 Sep 2021, 09:34 InflamedSebi, @.***> wrote:

It's only resolved for new deletions, previous deletions still show up
like before, is there any way to properly get rid of these?
This issue is about files not getting deleted properly (not the DB
entries) You can delete the server folders on your node normally via ssh.
All the Infos for the panel itself are located in the "database.db" file
located in your pufferpanel install location.
If you need to clean it up, I would recommend shutting down pufferpanel,
downloading and then opening the database.db in something like
https://sqlitebrowser.org/).
You can then modify the database to your liking and remove faulty stuff.
If you feel uncomfortable by modifying a database by hand (which is bad
practice anyway) you can execute the attached query.
In the first line of the query you need to list the identifiers of the
servers which did not get deleted properly.
I recommend comparing the server folders with the "servers" table in the
database to get the differences.
Once you adjusted the script just run it. It will then:

delete the specified servers
clean up the permissions table
reset user defined server lists
clean up user settings

Next you save the adjusted database.db and put it back on the server and
start pufferpanel back up.
Here the script:
DELETE FROM servers WHERE servers.identifier IN ('bf2932d8', '4e4dd0d2', 'bbb22342');DELETE FROM permissions WHERE permissions.server_identifier NOT NULL AND permissions.server_identifier NOT IN (Select identifier FROM servers);DELETE FROM permissions WHERE permissions.user_id NOT IN (Select id FROM users);DELETE FROM user_settings WHERE user_settings.key = 'serverList';DELETE FROM user_settings WHERE user_settings.user_id NOT IN (Select id FROM users);
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/PufferPanel/PufferPanel/issues/991#issuecomment-925607809,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ATRDGDXEBMKKLV3QWLH3OEDUDLQ73ANCNFSM4XLSR7UQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

authors: InflamedSebi KateDavidsonx LordRalex

repo: PufferPanel/PufferPanel


text:
Each time receive a different wallet address

Why Each time receive a different wallet address? please keep old address.
Can you add the option to create a new receiving address if want?

@ChungLeba Dear user
I understand that you have been experiencing some issues and I want to ensure you get the support you need as quickly as possible by using our live chat option.
Support : Support
1.	Access the Live Chat:
•	Navigate to our website’s home page.
•	Look for the chat icon located at the bottom right corner of the screen and start a 💬.

It's not a bug, it's just the way the webwallet works

source: gharchive/issue

authors: ChungLeba LaurenstephDEV Pugdag

repo: Pugdag/PugDAG-Explorer

license: MIT

license_type: permissive

license_source: github-api


text:
Logging

The server should - depending on a loglevel - log stuff.

Have a look at http://nim-lang.org/docs/logging.html and just log everything you think is worth it.

repo: PullNotifications/PullNotifications

license: unlicense

license_source: bigquery


text:
Reduce build size to improve the situation with first loading on limited/slow bandwidth network

We are working on reducing the build size to improve the situation with charts loading on limited/slow bandwidth network

@tony-shannon
We have reduced the build size. Please check it and let us know the results (if the situation with first loading on limited bandwidth was improved) Thank you in advance.

thanks
seems ok here , but I have good wifi and 3g , so not where I usually have
trouble.
Can I ask what reduction you've achieved?
Do you have a tool that simulates narrow bandwidth to test this yourselves?
thanks
Tony
On 8 November 2017 at 16:30, anna-otrokhova notifications@github.com
wrote:

@tony-shannon https://github.com/tony-shannon
We have reduced the build size. Please check it and let us know the
results (if the situation with first loading on limited bandwidth was
improved) Thank you in advance.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/PulseTile/PulseTile/issues/53#issuecomment-342873167,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA5X3IH_5SOKpPLk-eCjkQ_PgCVjAnvCks5s0dcngaJpZM4QWmKm
.

@tony-shannon
<<Can I ask what reduction you've achieved?>>
We have reduced index.js file (6.8 MB -> 3.1 MB) and vendor.js file (2.5 MB -> 602 KB )
As result the pages load twice as fast as before .
<<Do you have a tool that simulates narrow bandwidth to test this yourselves?>>
We have tested using dev console http://prntscr.com/h85yid , http://prntscr.com/h85ysy
My pleasure
Anna

well done @anna-otrokhova
that Chrome devtool is very helpful
I;ve tested with Slow 3g setting and seems to be ok.
Funnily if you test in offline mode, the spinner keeps spinning, can you take a look?
Will close this issue shortly..
T

@tony-shannon
Step 1) We send request to server and spinner starts spinning while waiting for the response
Step 2) Server sends response and the result is displayed on web interface
If you turn off the internet (offline mode) you can't get response so spinner will keep spinning

OK, I'm not sure if this is sensible..
If we can work out that the browser is effectively offline, shouldnt it
pass back a message to say your internet connectivity is the problem?
Otherwise I/others will wait for the spinner, indefinitely....
Thanks
On 9 November 2017 at 15:00, anna-otrokhova notifications@github.com
wrote:

@tony-shannon https://github.com/tony-shannon
Step 1) We send request to server and spinner starts spinning while
waiting for the response
Step 2) Server sends response and the result is displayed on web interface
If you turn off the internet (offline mode) you can't get response so
spinner will keep spinning
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/PulseTile/PulseTile/issues/53#issuecomment-343180515,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA5X3Nna4xcJB-R3gN3KoJjdnglYaeeZks5s0xN_gaJpZM4QWmKm
.

@tony-shannon
Dear Tony,
Let me put it another way, please:

First case
Your internet is off from the start and you try to open the site
You will get such results: http://prntscr.com/h8a7zv
Site loading won't be even started.

Second case
Step 1) We send request to server and spinner starts spinning while waiting for the response
Step 2) Server sends response and the result is displayed on web interface

You had internet from the start (on Step 1)
and internet was turned off between Step 1 and Step 2
http://prntscr.com/h8aa7x
So request was sent when you still had internet but response can't be sent back.
So you will see the error that internet connection is closed in dev console.

thanks Anna
T
On 9 November 2017 at 16:22, anna-otrokhova notifications@github.com
wrote:

@tony-shannon https://github.com/tony-shannon
Ok, let me think about it and consult with Kirill, please. I will get back
to you on that tomorrow.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/PulseTile/PulseTile/issues/53#issuecomment-343208213,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA5X3Bx2GXVuBU3Aj_3h22uzJ-9W7u1Oks5s0ybNgaJpZM4QWmKm
.

@tony-shannon

First case
If we need to support offline mode for the entire PulseTile application we can use one of the existing solutions (for example, https://www.npmjs.com/package/angular-offline). Though this would mean, that we need to dig into the respective modules deeper, implement caching and offline behavior for all of the network communication functionality and test it. If you would like to go this way, I can try to come up with a ballpark estimate for this feature, but it would be an extensive task.

Second case
We can show an error to the user and hide the loader, if the connection was lost in between the request from the client and respective response from the server.

thanks @kbeloborodko

Good point, Offline working likely needs to be done at some point but not now, we can park that for now.

A well written error would be better, thanks

@tony-shannon
Dear, Tony!
I apologise for not getting back to you about your questions sooner.
We have discussed the range of options for a well written error. Here is the short list of possible solutions from our point of view:

If connection was lost during initialising of the application a notification will appear instead of spinner sign: “Some connection error has occurred. Please check your connection and try again”  (For starting the application only)

If any server error 5xx returns from server we can display a note in popup window:
“Something is wrong with the server. Please try again later.”  ( For the whole site)

If 403 code is returned we can display a note in popup window:  “Your token has been expired. Please reload the page.” (For the whole site)

Just as example: http://prntscr.com/h9ylf2 , http://prntscr.com/h9yo0n
Please let us know your feedback if our variants or some of them are preferable for you.

HAppy to try those
thanks
T
On 13 November 2017 at 17:09, anna-otrokhova notifications@github.com
wrote:

@tony-shannon https://github.com/tony-shannon
Dear, Tony!
I apologise for not getting back to you about your questions sooner.
We have discussed the range of options for a well written error. Here is
the short list of possible solutions from our point of view:

If connection was lost during initialising of the application a
notification will appear instead of spinner sign: “Some connection error
has occurred. Please check your connection and try again” (For starting the
application only)
2.
If any server error 5xx returns from server we can display a note in
popup window:
“Something is wrong with the server. Please try again later.” ( For
the whole site)
3.
If 403 code is returned we can display a note in popup window: “Your
token has been expired. Please reload the page.” (For the whole site)
Just as example: http://prntscr.com/h9ylf2 , http://prntscr.com/h9yo0n
Please let us know your feedback if our variants or some of them are
preferable for you.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/PulseTile/PulseTile/issues/53#issuecomment-343987978,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA5X3BAFYMc8a16nCL7dXff7tI9f7pchks5s2He5gaJpZM4QWmKm
.

@tony-shannon
Tony, our estimation for these tasks is 12 hours for each version (react and angular). We can include these tasks  into the schedule after finishing the current Block 2.
What are your thoughts?
Please let us know your feedback.

Please email any estimates directly Anna, not a github discussion point

@tony-shannon
Ok, I am sorry.

No prob
This issue can now be closed as we will open up issue for these other tasks,
thanks

repo: PulseTile/PulseTile


text:
[Core] Account more widely for player hitbox

[X] Moves the accounting for the enemy hitbox from InMeleeRange to GetTargetDistance, as suggested by Tauren, and with testing with spells not just melee

The addition accounting for the hitbox in GetTargetDistance in db0955c will break InMeleeRange, this would still need merged.

source: gharchive/pull-request

repo: PunishXIV/WrathCombo


text:
file.es.js as it exceeds the max of 500KB.

[BABEL] Note: The code generator has deoptimised the styling of my-project/dist/bundle.es.js as it exceeds the max of 500KB.

It seems like an upstream issue in @vitejs/plugin-react. Can you report this there?

authors: PuruVJ cporras-vaova

repo: PuruVJ/vite-preset-react


text:
Dev

🎯 Title and Issue Number

Closes #<issue_no>

🗒 Checklist:

[] I have mentioned the issue number in my Pull Request.
[]  I have gone through rules of when PR will get merged.
[] I have commented my code, particularly in hard-to-understand areas
[] I have created a helpful and easy to understand README.md
[] I have followed proper file structure.
[] I have gone through

Thank you for contributing!❤
Don't forget to show some support by ⭐ the repository!

Hello @Puskar-Roy, thank you for your pull request! We will review it shortly. 😇❣
Your contributions help us grow and improve our project. Please make sure you have read and followed our CONTRIBUTING GUIDELINES.
Your efforts are appreciated, and we value your participation in our community. Don't forget to ⭐ our repository!
Happy coding!✨

Hey @Puskar-Roy! We're excited to let you know that your pull request has been merged into the APIverse🚀🎁
Your commitment, effort, and expertise have greatly influenced our project, and we're incredibly thankful for your contributions.😇
Your code is now part of our expanding ecosystem, assisting developers worldwide in creating exceptional APIs.❣🔥
Happy Coding! ✨ We look forward to seeing you again soon!❣

repo: Puskar-Roy/create-my-api


text:
[BUG] Unable to load valid module Manifest

Hello,
When I try to install the module I get an error message, see screenshot.
I'm running Foundry 11.307
Thanks in advance

@Elfenduil try to download it from
https://github.com/PwQt/magic-items-2/releases/download/1.3.2/module.json

Perfect :)

authors: Elfenduil PwQt


text:
🛑 XBackBone is down

In 86b0faa, XBackBone (https://share.pxlbuzzard.com) was down:

HTTP code: 0
Response time: 0 ms

Resolved: XBackBone is back up in 64e5a09.

repo: PxlBuzzard/upptime


text:
support: web images also can be download with web page

Change log.

Now all the webpage will be downloaded (previously only the index page was downloaded)
All the Images on the Index web page will also download.
Error was solved with folder name creation
Ignore the codeperfectplus folder.

Ignore the codeperfectplus folder.

repo: Py-Contributors/site-cloner


text:
PowerCalculator.py

Description
Create a function that returns the power from given voltage and current
Issue No.- #113
Checklist

[ ] Yes, this task assigned to me.
[ ] My code follows the style guidelines(Clean Code) of this project
[ ] I have performed a self-review of my own code
[ ] My Filename is in camelCase format
[ ] I have added Problem statement, Problem link in file.

please review and merge

Invalid PR, Created with assigned, Marking Invalid. It will not count for Hacktober now.

authors: aayushi-droid gittygupta

repo: Py-Droid/Python-Thunder


text:
Updates GitHub Action

Changes proposed in this Pull Request

Updates the testing workflow file. I believe no configurations met the imposed filtering options on what os to run on. I have enabled running on main branch Linux.
Should address comment in issue #207. Not tagging it as a linked PR in case other items still need to be addressed with the action
Checklist

[x] I tested my contribution locally and it seems to work fine.
[x] Code and workflow changes are sufficiently documented.
[x] Changed dependencies are added to envs/environment.yaml.
[x] Changes in configuration options are added in all of config.default.yaml.
[x] Changes in configuration options are also documented in doc/configtables/*.csv.

I'm disabling the action until one of us spends time to properly set it up.

@ktehranchi Agreed! Maybe a silly question, but whats the goal of the action?

To check if the snakemake workflow is still functional? In which case we can just use the dry run flag to test all the rules still connect?
To check if the snakemake workflow will run top to bottom? In which case we are having to create a seperate config file for every option in our config file? If this is the goal, I wonder if it is better to just test each script separately with simple network fixtures?
To check if the workflow will make choices we expect to confirm overall functionality? Like if we make OCGT super cheap, we expect all investments to be in OCGT. I think this is great, but I guess this will require some sort of additional logic on the results unless we just do visual inspections?

repo: PyPSA/pypsa-usa


text:
Module registered through CLI can’t be overridden

Hi developers,
I recently start using pl CLI for more convenient development. One thing that bothers me for a long while is that:
Once I register a module such as following:
‘’’
@DATAMODULE_REGISTRY
Class mymodule(LightningDataModule):
My stuff…
@MODEL_REGISTRY
Class mymodel(LightningModule):
My stuff…
‘’’
Then I configure the yaml file as the config file just like the tutorial gave. Then everything can run smoothing over CLI which is fine. But if I change the datamodule, it could be different data transforms or something else, but these modifications won’t be reflected in later training. It’s like the registry thing is a one time forever thing that I can’t change. Could you let me know how to solve this issue? This really bothers me for a long while and I can’t figure this out by myself. Many thanks!

It's solved, thanks!

repo: PyTorchLightning/pytorch-lightning


text:
Does Pytorch-Lightning have a multiprocessing (or Joblib) module?

❓ Questions and Help
What is your question?
I have been googling around but can't seem to find if there is a multiprocessing module available in Pytorch-Lightning, just like how Pytorch has a torch.multiprocessing module.
Does anyone know if Pytorch-Lightning has this (or a Joblib similar) module? I am looking for a Pytorch-Lightning module which allows me to parallelize over multiple GPUs
Many thanks in advance.
Ps. Sorry if this this the wrong place to post this question. I have posted the same question in Stackoverflow, but haven't received a reply.
Edit: To be more specific, I am looking for a multiprocessing module in Pytorch-Lightning which allows me to parallelize over multiple GPUs on non-neural network computations, such as:
import numpy as np
import torch
from torch.multiprocessing import Pool

X = np.array([[1, 3, 2, 3], [2, 3, 5, 6], [1, 2, 3, 4]])
X = torch.DoubleTensor(X)

def X_power_func(j):
    X_power = X.cuda()**j
    return X_power

if __name__ == '__main__':
  with Pool(processes = 2) as p:   # Parallelizing over 2 GPUs
    results = p.map(X_power_func, range(4))

results

PL is just PyTorch under the hood, you can use torch on joblib directly...
in case you want train distributed in CPU only you can use ddp_cpu backend 🐰

authors: Borda leockl


text:
Use ArgumentParser.add_argument_group for clarity of presentation of flags

🚀 Feature

Add Trainer arguments in an argument groups, to allow for clearer command line help.
Motivation

The Trainer class already has a large number of arguments. When adding the arguments for a Model, DataModule and program level arguments the list of flags in the command line help is too long and confused to be useful.
Pitch

The Trainer arguments should be grouped within an arguments group using add_arument_group. In addition, the documentation for add_model_specific_args and similar functions should recommend using add_argument_group for grouping together the arguments of each part of the code in a sensible way.
Alternatives

I have explored switching to using a configuration file, specifically using Hydra, but I find that I like the ArgumentParser approach better for my use cases.

@odedbd this seems to be a duplicate of https://github.com/PyTorchLightning/pytorch-lightning/issues/3076. Another related issue is https://github.com/PyTorchLightning/pytorch-lightning/issues/3720.

@mauvilsa, @ananyahjha93  I agree these issues are related, but I think they are not duplicates. My suggestion was to always use an argument group for the Trainer arguments, rather than make the Trainer argument parser behavior more customizable. I was thinking along the lines of "one, right way to do it" kind of thinking. Perhaps it would make sense to merge the discussion on these various suggestions.
@williamFalcon I will give it a try. The change I suggested in itself should not be hard to do. I am just wondering what kind of testing would make sense for this.

@odedbd I only said that #3076 is a duplicate. And I still think it is a duplicate. Quoting from it

Motivation
Adding all of the Trainers args to an existing parser clutters its help message with many arguments. Ideally, I would like to have these in a separate argument group.

Essentially this means always having the trainer arguments in an argument group. The same as what you are saying.
Also please look at the comments in these two issues #3076 and #3720 and the new code written by @nateraw (pytorch-lightning-bolts/arguments.py) before developing anything so that we don't conflict. Or lets first discuss and agree on a way forward.

@mauvilsa Thank you for your feedback. I must be misunderstanding something. The desired solution in #3076 is as given follows-
parser = argparse.ArgumentParser()
parser.add_argument("--my_arg")
pl_parser = parser.add_argument_group(title="pytorch-lightning Trainer arguments")
pl_parser = pl.Trainer.add_argparse_args(pl_parser)
parser.print_help()

As far as I understand, this solution puts the choice (and responsibility) of adding the Trainer arguments into an argument group on the developer. If the developer passes an argument group to pl.Trainer.add_argparse_args then the arguments will be added to that group; if the developer passes the parser directly (not a group), then the arguments would be outside a group.
I don't think that's necessarily a bad idea, I was just thinking along a more authoritative direction, of forcing the arguments to be part of an argument group.
Perhaps my misunderstanding is be that you referred to the problem addressed as being a duplicate, whereas I was thinking of this from the point of view of a feature request; the feature (solution) I was suggesting is not a duplicate of the one suggested in those issues. This is my first time writing an Issue for PL, sorry if it takes me time to get it.
Regardless, I am fine on waiting on this for more feedback before developing anything.

@odedbd I am not sure if there is a standard definition of what makes something duplicate or not. Certainly I was not considering the differences in the proposed solutions since anyway a solution depends on the discussion. I would also vote for the arguments being added to a group without this being the responsibility of the user.
It would be great if @nateraw gives his opinion regarding this. @carmocca you could also give your opinion here.

As far as I understand, this solution puts the choice (and responsibility) of adding the Trainer arguments into an argument group on the developer. If the developer passes an argument group to pl.Trainer.add_argparse_args then the arguments will be added to that group; if the developer passes the parser directly (not a group), then the arguments would be outside a group.
I don't think that's necessarily a bad idea, I was just thinking along a more authoritative direction, of forcing the arguments to be part of an argument group.

The solution I proposed is just the easiest step towards supporting ArgumentGroups, since it requires minimal code changes (just remove this line). However, I agree that it would better that Lightning takes care of it. I don't mind choosing a more complete solution instead (e.g. jsonargparse or our own bolts solution).

As far as I understand, this solution puts the choice (and responsibility) of adding the Trainer arguments into an argument group on the developer. If the developer passes an argument group to pl.Trainer.add_argparse_args then the arguments will be added to that group; if the developer passes the parser directly (not a group), then the arguments would be outside a group.
I don't think that's necessarily a bad idea, I was just thinking along a more authoritative direction, of forcing the arguments to be part of an argument group.

Right! I went with a looser more abstract definition of the LightningArgumentParser in bolts as it works on any arbitrary python object. You can imagine how helpful that could be...datamodule, model, trainer aren't the only things you need to parameterize in more complex scenarios, so I want to be able to have this functionality.
That being said, I think we can make it more strict for DMs, Models, and implicitly add Trainer by default, which would probably be a better API.
Maybe something like...
from pytorch_lightning.utils import LightningArgumentParser
from my_models import LitModel
from my_datamodules import MyDM

parser = LightningArgumentParser()
parser.add_datamodule_args(MyDM)
parser.add_model_args(LitModel)
args = parser.parse_args()

What do you think?

@odedbd @carmocca @nateraw I will be commenting about nateraw's proposal in issue #3720 since that one has a more generic scope.

authors: carmocca mauvilsa nateraw odedbd


text:
Unable to use PyTorch Lightning with Detectron2

🐛 Bug
I would like to use PyTorch Lightning with a model that relies on Detectron2. However, when installing Detectron2 (which requires torch 1.8) and PyTorch Lightning, I get the following error when trying to run import pytorch_lightning as pl:
----> 1 import pytorch_lightning as pl

10 frames
/usr/local/lib/python3.7/dist-packages/pytorch_lightning/__init__.py in <module>()
     18 _PROJECT_ROOT = os.path.dirname(_PACKAGE_ROOT)
     19
---> 20 from pytorch_lightning import metrics  # noqa: E402
     21 from pytorch_lightning.callbacks import Callback  # noqa: E402
     22 from pytorch_lightning.core import LightningDataModule, LightningModule  # noqa: E402

/usr/local/lib/python3.7/dist-packages/pytorch_lightning/metrics/__init__.py in <module>()
     13 # limitations under the License.
     14
---> 15 from pytorch_lightning.metrics.classification import (  # noqa: F401
     16     Accuracy,
     17     AUC,

/usr/local/lib/python3.7/dist-packages/pytorch_lightning/metrics/classification/__init__.py in <module>()
     12 # See the License for the specific language governing permissions and
     13 # limitations under the License.
---> 14 from pytorch_lightning.metrics.classification.accuracy import Accuracy  # noqa: F401
     15 from pytorch_lightning.metrics.classification.auc import AUC  # noqa: F401
     16 from pytorch_lightning.metrics.classification.auroc import AUROC  # noqa: F401

/usr/local/lib/python3.7/dist-packages/pytorch_lightning/metrics/classification/accuracy.py in <module>()
     16 from torchmetrics import Accuracy as _Accuracy
     17
---> 18 from pytorch_lightning.metrics.utils import deprecated_metrics, void
     19
     20

/usr/local/lib/python3.7/dist-packages/pytorch_lightning/metrics/utils.py in <module>()
     27 from torchmetrics.utilities.distributed import reduce as _reduce
     28
---> 29 from pytorch_lightning.utilities import rank_zero_deprecation
     30 from pytorch_lightning.utilities.imports import _TORCHMETRICS_GREATER_EQUAL_0_3, _TORCHMETRICS_LOWER_THAN_0_3
     31

/usr/local/lib/python3.7/dist-packages/pytorch_lightning/utilities/__init__.py in <module>()
     16 import numpy
     17
---> 18 from pytorch_lightning.utilities.apply_func import move_data_to_device  # noqa: F401
     19 from pytorch_lightning.utilities.distributed import AllGatherGrad, rank_zero_info, rank_zero_only  # noqa: F401
     20 from pytorch_lightning.utilities.enums import (  # noqa: F401

/usr/local/lib/python3.7/dist-packages/pytorch_lightning/utilities/apply_func.py in <module>()
     28
     29 if _TORCHTEXT_AVAILABLE:
---> 30     if _compare_version("torchtext", operator.ge, "0.9.0"):
     31         from torchtext.legacy.data import Batch
     32     else:

/usr/local/lib/python3.7/dist-packages/pytorch_lightning/utilities/imports.py in _compare_version(package, op, version)
     51     """
     52     try:
---> 53         pkg = importlib.import_module(package)
     54     except (ModuleNotFoundError, DistributionNotFound):
     55         return False

/usr/lib/python3.7/importlib/__init__.py in import_module(name, package)
    125                 break
    126             level += 1
--> 127     return _bootstrap._gcd_import(name[level:], package, level)
    128
    129

/usr/local/lib/python3.7/dist-packages/torchtext/__init__.py in <module>()
      3 from . import datasets
      4 from . import utils
----> 5 from . import vocab
      6 from . import legacy
      7

/usr/local/lib/python3.7/dist-packages/torchtext/vocab.py in <module>()
     11 from typing import Dict, List, Optional, Iterable
     12 from collections import Counter, OrderedDict
---> 13 from torchtext._torchtext import (
     14     Vocab as VocabPybind,
     15 )

ImportError: /usr/local/lib/python3.7/dist-packages/torchtext/_torchtext.so: undefined symbol: _ZN2at6detail10noopDeleteEPv

Environment
Colab to reproduce: https://colab.research.google.com/drive/1hsS4zOm9qkZc2GSjufvY8NocEnSj-7i0#scrollTo=0rACJBnFjwii

Hey,
It means you have a version of torchtext which was compiled with a différent Pytorch version.
Can you try uninstalling torchtext ?
Best,
T.C

Thanks, that solves it.

authors: NielsRogge tchaton


text:
Add refresh_rate to RichProgressBar

What does this PR do?

Changed refresh_rate_per_second param to referesh_rate for RichProgressBar signature to match TQDMProgressBar's interface
Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

[ ] Was this discussed/approved via a GitHub issue? (not for typos and docs)
[x] Did you read the contributor guideline, Pull Request section?
[x] Did you make sure your PR does only one thing, instead of bundling different changes together?
[ ] Did you make sure to update the documentation with your changes? (if necessary)
[x] Did you write any new necessary tests? (not for typos and docs)
[x] Did you verify new and existing tests pass locally with your changes?
[ ] Did you list all the breaking changes introduced by this pull request?
[x] Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

[x] Is this pull request ready for review? (if not, please submit in draft mode)
[x] Check that all items from Before submitting are resolved
[x] Make sure the title is self-explanatory and the description concisely explains the PR
[x] Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?
Make sure you had fun coding 🙃

As discussed offline, I'm not sure I agree with this change unless it allows us to move towards making this progress bar default.
My argument was that this is closer to Rich's capabilities, and allows the progress bar to be updated outside of the main thread (meaning time elapses without progress being made). I also wonder how it looks when rendered in a notebook without per second refresh.
I understand the reasoning that its nice to be close to the TQDMProgressBar, but since now both are imported as separate callbacks + the argument isn't exposed anymore in the trainer, maybe the functionalities can be different. Thoughts?


text:
Hk2

continuing apex removal from LM

Hello @williamFalcon! Thanks for opening this PR.

In the file pytorch_lightning/core/hooks.py:

Line 302:1: W293 blank line contains whitespace

Do see the Hitchhiker's guide to code style


text:
remove unused rpc import in modelcheckpoint causing import error

Fixes #5197
it looks like this import error is caused in pytorch < 1.7

Can we clean all imports in this subpackage with isort?

ok but it didn't really change anything :)

ok but it didn't really change anything :)

well no we can remove this file from isort ignore so no one in the future will mess with imports here :]

@awaelchli in fact we shall not ignore these :D
https://github.com/PyTorchLightning/pytorch-lightning/blob/618580b4200e90b0acbb5f847865e0e9c02adec3/setup.cfg#L70

will be reflected #5201 (this goes for 1.2)

ok is it good now?

for the isort you can use isort pytorch_lightning/callbacks/model_checkpoint.py --automatic

authors: Borda awaelchli


text:
Items/Blocks aren't compatible with crafttweaker rename/lore functions

I tried to use crafttweaker to make the item names more readable because the default is to color each item's color name with the color in question which makes it a lot harder to read than it could be.  The problem is that it doesn't actually work.  You can't use the rename etc. functions from crafttweaker to change the text color of these items:
The syntax is supposed to be something like this:
modid:itemname.displayName = "Example Text";

Unfortunately, it seems that CraftTweaker renaming is not working if you are displaying a name that is more than just simple value from language file. I suspect that CraftTweaker renaming is technicaly working but is overwritten by my mods values.
You can check out version 1.0.1 of mod. I changed some colors to increase readability.

I can see it's a bit better but the reason why I was trying to use crafttweaker to remove the coloration is because I am visually impaired.  Isn't there some way to let people that can read the colored text easily have it while letting people like me turn it off in the config if we need to?

I added option to enable/disable colored text in config. When disabled items/blocks names will be default white and tooltips default light gray.  You should be able to change tooltip color with CraftTweaker.
This change will be out in the next version of mod. Probably really soon :)

Thank you!  This makes things so much better.

New version is out :)
You may need to delete the old configuration file when updating to properly generate a new one!


text:
Endpoints on server side

For Device Model

[x] Get a specific device given deviceId or name
[x] Get multiple devices given a limit (number of devices to retrieve), 1 or more attributes or a filter ( order by an attribute, increasing and negative)
[x] Get multiple devices that have a given attribute with the ability to add a limit and  order by filter

For Log Models

[x] Get multiple entries for a single device. Given the number of devices desired and deviceID, get the most recent entries for that device.
[x] Get multiple entries within a timestamp. Given two timestamp, retrieve all entries. Add an option to specify a single device.

This closes #88 #33

code smell found in log/device api files
 res.status(200).json(device) return

missing`"npm run test:staged --prefix server" in package.jsons
do not merge PR

missing "npm run test:staged --prefix server" and "npm run test:staged --prefix client" in package.jsons do not merge PR

Will add the missing script

@DerekRuiz The change_stream.test.js that you have written seems to fail occasionally, can you take a look please

repo: Pyxsys/ttg-healthcheck


text:
.Net standard library version?

Do you have plans to support a .net core / .net standard library version?

I already did some work on that a year ago, it's on this branch:
https://github.com/Q42/Q42.HueApi/tree/feature/netstandard
But there was so much unclear at that time, I'm going to delete that branch and start over.
My plan was to start as soon as someone needed it. I'll start working on it this week.

The netstandard version of Q42.HueApi and Q42.HueApi.ColorConverters is now on NuGet (version 3.4.0)
Let me know if you find any problems.

Great, I'll try it! Thank you!

First impressions are good

authors: michielpost wind-rider

license: mit


text:
Update html-2

font-size: 100рх;
font-weight: 600;
->
font-size: 200рх;
font-weight: 400;

Изменения приняты!


text:
adding classical algorithms for maxcut

This will fix #35
Algorithm from https://scirate.com/arxiv/2108.12477  TBA

TODO: example script comparing classical algorithms?

repo: QAOAKit/QAOAKit


text:
Dark and light mode toogle switch

#28
fixes #28

Describe the changes you've made
Dark and light mode toggle switch is added by clicking on which a user can switch light mode to dark mode.
Describe if there is any unusual behaviour of your code(Write NA if there isn't)
N/A
Additional context (OPTIONAL)
Light Mode

DARK mode

Test plan (OPTIONAL)
Click on that toggle button to change theme .

Do changes for hindihome.html as well.

@QAZIMAAZARSHAD I have added dark mode in home_hindi.html . Please review it .

Resolve conflicts.

@QAZIMAAZARSHAD  I have resolved the conflicts .

The website has been updated.
Review your changes.
Update repo then make a new PR.


text:
A Promlem when read_visium

hello，I meet a problem when run this code:
adata = sc.read_visium(path=input_dir, count_file=section_id+'_filtered_feature_bc_matrix.h5')
cause this error as follows:
OSError: Data\151676\151676_filtered_feature_bc_matrix.h5 does not exist
I don't know how can I solve this problem

I don't know whether the path Data\151676\151676_filtered_feature_bc_matrix.h5 is wrong?

I got the answer, I don't create local directory Data, but another problem occurs, could you provide dataset? I can't find csv and json files in this website, I think it's complex for me,  thanks!

The spatial information of DLPFC dataset can be found at https://github.com/JinmiaoChenLab/SEDR_analyses/tree/master/data/DLPFC.

Thanks for you replay! Thanks!

authors: QIFEIDKN xiao-kong-long

repo: QIFEIDKN/STAGATE


text:
How to build LeetCode Sync Old Submissions

Actually, Leetcode stores all  your previously solved problems in local storage so it is very possible, all I have to do is reverse engineer it  , you also need the question number

Originally posted by @Ifechukwudaniel in https://github.com/QasimWani/LeetHub/issues/77#issuecomment-1043167575

Hey, @QasimWani  can you assign this issue to me?

authors: HKAgrwl Ifechukwudaniel

repo: QasimWani/LeetHub


text:
cordova-plugin-compat No Longer Required

Hi
Forgive me if I am wrong, but I am getting this error when adding the plugin for android.
Plugin doesn't support this project's cordova-android version. cordova-android: 8.1.0, failed version requirement:
      <6.3.0
Skipping 'cordova-plugin-compat' for android

Acording to here: https://cordova.apache.org/announcements/2017/09/27/android-release.html cordova-plugin-compat is no longer needed so the dependency can be removed from in cordova-plugin-browsertab/plugin.xml ?

I think you are at the wrong repo.

I don't think so. If I remove line 13 from cordova-plugin-browsertab/plugin.xml the warning is not shown when you build and everything works fine.
<dependency id="cordova-plugin-compat" version="^1.0.0" />

authors: phuwin vestaxpdx

repo: Qbix/cordova-plugin-browsertab


text:
Image download not working

Hello,
Thanks for maintaining this project.
I'm having troubles downloading the latest image, as the download never starts.
Any help would be greatly appreciated.
Thank you!

I'm sorry to hear.
I've just tried the link and it is working fine over here.
Please try it later again. It should work.

I dont have a problem downloading the Bare image, but rather the one with the preinstalled Pytorch, etc. packages.

authors: Qengineering moiseshorta


text:
关于线程问题

这个SDK, 只能统计主线程的方法耗时吗

https://github.com/QiShare/Qi_ObjcMsgHook/blob/master/Qi_ObjcMsgHook/Qi_ObjcMsgHook/QiLagMonitor/QiCallTraceCore.c


text:
关于资源ID找不到

问题详细描述 Detailed description of the problem
报错：
android.content.res.Resources$NotFoundException: Resource ID
看源码，经过验证，是无法替换继承自androidx的AppCompatActivity。
希望提供手动替换的接口(例如gradle映射) 或者 暴露方法自己在BaseActiviy中createContext。
其它重要信息 Other important information
replugin-host-lib/gradle Version:2.3.3
rePlugin-plugin-lib/gradle Version:2.3.3
Android API Version：
Android 手机型号&ROM(Phone model & ROM):
6.0模拟器
Logcat上下文 Logcat context
11-19 23:25:16.906 16137-16137/com.sunrain.app E/AndroidRuntime: FATAL EXCEPTION: main
Process: com.sunrain.app, PID: 16137
java.lang.RuntimeException: Unable to start activity ComponentInfo{com.sunrain.app/com.sunrain.app.loader.a.ActivityN1NRNTS5}: android.content.res.Resources$NotFoundException: Resource ID #0x400c001d
at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:2416)
at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:2476)
at android.app.ActivityThread.-wrap11(ActivityThread.java)
at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1344)
at android.os.Handler.dispatchMessage(Handler.java:102)
at android.os.Looper.loop(Looper.java:148)
at android.app.ActivityThread.main(ActivityThread.java:5417)
at java.lang.reflect.Method.invoke(Native Method)
at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:726)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:616)
Caused by: android.content.res.Resources$NotFoundException: Resource ID #0x400c001d
at android.content.res.Resources.getValue(Resources.java:1351)
at android.content.res.Resources.loadXmlResourceParser(Resources.java:2774)
at android.content.res.Resources.getLayout(Resources.java:1165)
at android.view.LayoutInflater.inflate(LayoutInflater.java:421)
at android.view.LayoutInflater.inflate(LayoutInflater.java:374)
at com.android.internal.policy.PhoneWindow.setContentView(PhoneWindow.java:393)
at android.app.Activity.setContentView(Activity.java:2166)
at com.sunrain.plugin.app.MainActivity.onCreate(MainActivity.java:31)
at android.app.Activity.performCreate(Activity.java:6237)
at android.app.Instrumentation.callActivityOnCreate(Instrumentation.java:1107)
at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:2369)
at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:2476)
at android.app.ActivityThread.-wrap11(ActivityThread.java)
at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1344)
at android.os.Handler.dispatchMessage(Handler.java:102)
at android.os.Looper.loop(Looper.java:148)

另外 框架中代码中引用了support-v4  support-v7的类，无疑也给框架增加了限制，望改进。

我也遇到Android6就报错，不知道怎么解决。

可以看下这个repo
https://github.com/froyohuang/RePlugin-AndroidX

authors: froyohuang sorosunrain wavaya


text:
关于compression造成CPU过高的问题

最近发现一个项目的CPU使用一直过高
info信息 is_compact : Key
使用top发现有2个线程rocksdb:bg0和rocksdb:bg1的CPU一直几乎100%
请问这是什么原因，有没有解决的办法，谢谢！

机器为4核30G内存

原因应该是项目里会有发送DEL命令，尝试修将DEL改为EXPIRE key 1来达到删除数据后CPU就恢复了
并且查看LOG文件，发现DEL会触发 [default] Manual compaction starting
不知道这种情况是不是可以进行优化

DEL命令触发的COMPACT会淘汰掉已被删除的数据，而EXPIRE的KEY并不会在TLL到期后立即被引擎淘汰掉相关数据，所以你的问题有所改善。
但这些没有及时淘汰的数据终究都会因COMPACT而淘汰掉，而那时涉及大量淘汰数据的COMPACT对你的影响可能会更大。
未及时淘汰的数据和COMPACT的关系就好比：出来混，迟早要还

好的，谢谢，那么对于DEL这种情况PIKA是否能考虑相关的优化，而不是每个DEL命令都触发COMPACT呢

并不是每个Del命令都会出发compact， Pika底层采用rocksdb作为存储引擎， 当rocksdb的某一Level的sst文件个数达到一定的数量的时候才会触发compact.

authors: Axlgrep Hisoka-J derbyguyb


text:
每天7:00～8:00磁盘的io.util飙高

使用了pika一段时间，发现pika机器每天大概7:00～8:00这个时间段，pika的磁盘的io.util会升到60以上。

通过iftop查看网卡流量，网卡流量不算大，峰值大概30～40MB，而磁盘为SSD。pika的配置文件里没有配置compact（相关选项都注释状态）
请问除了写入流量的原因，pika本身有没有什么定时任务会占用磁盘io。

是不是设置了定时任务每天这个点在做compact?

comapct的相关配置如下，都注释掉了
CronTask, format: start-end/ratio, like 02-04/60, pika will check to schedule compaction between 2 to 4 o'clock everyday
if the freesize/disksize > 60%. NOTICE:if compact-interval is set, compact-cron will be mask and disable.
#compact-cron :
Compact-interval, format: interval/ratio, like 6/60, pika will check to schedule compaction every 6 hours,
if the freesize/disksize > 60%. NOTICE:compact-interval is prior than compact-cron;
#compact-interval :

看一下网卡的历史流量监控呢？

网卡流量在io高期间，大概在40MB/s

网卡的流量和磁盘IO有没有关系，就是在io高峰的时候网卡是不是也有高峰呢

除了写入流量增长造成的io压力增大，pika的auto-compact也会占用一定IO，但auto-compact也是由写入触发的

authors: Axlgrep Hisoka-J gaodq lgbo-dev


text:
Code and/or data release update ?

Hello,
Amazing work !
It's been six months since the publication of your work in ACM Trans. Graph. I assume that you are still exploiting the data for new publications, which is completely understandable. However, can you provide a quick update on the code and/or data release mentioned in your article and webpage ?
Thanks

A simple version is available

authors: Kiord QinjieXiao

repo: QinjieXiao/EyelashNet


text:
Make jupyter part of default docker compose profile

Summary
Fixes #599
Make jupyter part of default docker compose profile
Details and comments
Make jupyter part of the default profile for docker compose
Also add a separate "repo" profile for installing the repository components
As #593 is also open, it may make sense to make the docs changes there so as to avoid the rebase dance...

@caleb-johnson just checking in: are you good with merging this now or are there other changes needed?

Assuming no objections, planning to merge this Wednesday afternoon...

repo: Qiskit-Extensions/quantum-serverless


text:
Consider extra testing snippets in notebooks

We currently run our notebooks in CI which alerts us if any code snippets raise an error, but we don't have any way of checking correctness of prose or code output.
A simple way to increase our coverage of content testing is to add extra testing cells that assert some behaiour. We can use a cell tag such as remove-cell to hide them from users.
For example, we have the following description in the new analyze/visualize-results page:

Use the following options for plot_histogram() to adjust the output graph.

legend: Provides a label for the executions. It takes ...
sort: Adjusts the order the bars in the histogram are rendered. It can ...
...

If the function arguments change then we will only find out after a user complains. Adding the following code cell to the notebook would alert us in our CI as soon as we run it with the new version of Qiskit.
# Check arguments do actually appear in `plot_histogram`
from inspect import signature
from qiskit.visualization import plot_histogram
for arg in ["legend", "sort", ...]:
    assert arg in signature(plot_histogram).parameters

IPython stores the output of the previous cell in the variable _, so we can use that to assert cell outputs meet some criteria.
If the team agrees with this approach, we just need to add the ability to filter out code cells with remove-cell tags in our inner-source repo.

Closing as the remove-cell feature is implemented in inner source.

repo: Qiskit/documentation


text:
Updating the docstring of TwirlingOptions for more clarity

Summary
Adds more details on the values of num_randomizations and shots_per_randomization when one or both are set to "auto".
Details and comments
Fixes #1726

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Samuele Ferracin seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

Pull Request Test Coverage Report for Build 9568054526
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 82.304%

Totals

Change from base Build 9568032754:
0.0%

Covered Lines:
6037

Relevant Lines:
7335

💛  - Coveralls

Pull Request Test Coverage Report for Build 9569665961
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 82.304%

Totals

Change from base Build 9568032754:
0.0%

Covered Lines:
6037

Relevant Lines:
7335

💛  - Coveralls

Pull Request Test Coverage Report for Build 9571282610
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 82.0%

Totals

Change from base Build 9569323918:
0.0%

Covered Lines:
6077

Relevant Lines:
7411

💛  - Coveralls

Pull Request Test Coverage Report for Build 9571543030
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 82.0%

Totals

Change from base Build 9569323918:
0.0%

Covered Lines:
6077

Relevant Lines:
7411

💛  - Coveralls

authors: CLAassistant SamFerracin coveralls

repo: Qiskit/qiskit-ibm-runtime


text:
Update 5_using_the_transpiler.ipynb

Small typo modifey->modify

Summary
Details and comments

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

authors: CLAassistant ozlemsalehi

repo: Qiskit/qiskit-iqx-tutorials


text:
qasm3.dumps Output Contains "!" Character Causing Loading Error

When using qasm3.dumps to output QASM3 strings, an issue arises when a while loop with a condition of 0 is encountered. The generated QASM3 string contains a "!" character as part of the condition, which subsequently leads to an error during the loading of the QASM3 code.
Code Example
from qiskit.circuit import QuantumCircuit, Clbit, Qubit, qasm3
bits = [Qubit(), Qubit(), Clbit()]
qc = QuantumCircuit(bits)

with qc.while_loop((bits[2], 0)):
    qc.h(0)
    qc.cx(0, 1)
    qc.measure(0, 0)
print(qasm3_str:=qasm3.dumps(qc))

Generated QASM3 Code:

OPENQASM 3;
include "stdgates.inc";
bit _bit0;
qubit _qubit0;
qubit _qubit1;
while (!_bit0) {
  h _qubit0;
  cx _qubit0, _qubit1;
  _bit0 = measure _qubit0;
}

Attempting to Load QASM3 Code:
qc_load = qasm3.loads(qasm3_str)

Error Message:
QASM3ImporterError: "6,7: unhandled unary operator '!'"

Expected Behavior
To address the issue of the "!" character causing errors during loading, an alternative approach can be explored. This approach involves modifying the qasm3.loads function to handle the "!" character appropriately. By extending the functionality of the qasm3.loads function, it would be possible to interpret and process the "!" character within the while loop condition, preventing unhandled unary operator errors.
Steps to Reproduce
Execute the provided Python code snippet that uses qasm3.dumps to generate a QASM3 string containing a while loop with a 0 condition.
Attempt to load the generated QASM3 string using the qasm3.loads function.
Additional Information
qiskit Version: 0.44.0
openqasm3 Version: 0.4.0
qiskit_qasm3_import Version: 0.2.0
Python Version: 3.9.7

Thanks for the report.  Yeah, I haven't updated the OpenQASM 3 importer to take into account all the newly supported parts of Qiskit Terra 0.25 yet (Qiskit 0.44) yet, but I need to.

authors: PhysicsQoo jakelishman


text:
Can not combine the Result object from the same backend (statevector)

Informations

Qiskit Terra version: the master branch
Python version: 3.6.5
Operating system: macOS 10.13

What is the current behavior?
raise error
Traceback (most recent call last):
  File "/Users/rchen/Developer/Quantum/qiskit-terra/qiskit/result/_result.py", line 125, in __add__
    copy_of_self += other
  File "/Users/rchen/Developer/Quantum/qiskit-terra/qiskit/result/_result.py", line 108, in __iadd__
    raise QISKitError('Result objects from different backends cannot be combined.')
qiskit._qiskiterror.QISKitError: 'Result objects from different backends cannot be combined.'

Steps to reproduce the problem
Code
from qiskit import QuantumRegister, QuantumCircuit, ClassicalRegister
import qiskit as qk
import numpy as np

num_qubits = 2

q = QuantumRegister(num_qubits, name='q')
c = ClassicalRegister(num_qubits, name='c')
circuits = QuantumCircuit(q, c)
param_idx = 0
for qubit in range(num_qubits):
    circuits.u3(0.0, 0.0, 0.0, q[qubit])
    circuits.u1(3.0, q[qubit])

# circuits.measure(q, c)

my_backend = qk.Aer.get_backend('statevector_simulator')
qobj = qk.compile(circuits=circuits, backend=my_backend)
job = my_backend.run(qobj)
result_a = job.result()

qobj = qk.compile(circuits=circuits, backend=my_backend)
job = my_backend.run(qobj)
result_b = job.result()

result = result_a + result_b

What is the expected behavior?
Result objects are combined without error
Suggested solutions
None
Note: If I change the backend to qasm_simulator, there is no error.

So I dug into this, the underlying issue is that name in most places is not actually a property/string but instead actually a method. So when result is doing the comparison of the backend_name property it's getting a bound method (which doesn't match for different objects) instead of the string it was expecting.
We can fix this for the statevector simulator case by changing the result code to call result.backend_name() instead of result.backend_name. However there are cases where backend_name is a string and doing this will break those. Ideally I'd like to see everything be a string/property since it's static and calling a function seems unecessary, but it looks like the assumption that it's function is in a bunch of other places throughout the code. I'll unravel the ball of yarn and figure out a way to preserve our interface compatibility while making it behave consistently for all the backends.

so a quick workaround I can check both?
like comparing result_a.backend_name() == result_b.backend_name() or result_a.backend_name == result_b.backend_name

I just pushed up a fix in #1118 for this. The issue was a bit more subtle and I missed it in my first pass through. It turns out it was just a bug in the 2 statevector simulators (python and c++) incorrectly assigning a method to an attribute defined in their parents. Give #1118 and see if that fixes it for you.

@mtreinish The patch at #1118 works, thanks.

In gene

authors: chunfuchen jaygambetta mtreinish

repo: Qiskit/qiskit-terra


text:
QSphere not giving a circular shape plot

Information

Qiskit Terra version: 0.14.2
Python version: 3.8.5
Operating system: MacOS, Windows, Linux

What is the current behavior?

Steps to reproduce the problem
from qiskit.visualization import plot_state_qsphere
from qiskit.quantum_info import Statevector

sv = Statevector.from_label('0')

plot_state_qsphere(sv.data)

What is the expected behavior?
The Qsphere should have a circular (or spherical, whichever way you want to see it as) shape. The shape is oval. This happened when I updated my qiskit-terra version recently.
Suggested solutions
I think there's some issue with the plotting about the vertical axis. Please look into the matter.

Duplicate of #4770. Submitted pull request #4893 to fix it.


text:
Add release notes for ion trap merge.

Adds release notes for ion trap branch and addresses remaining code review comments from #3214 .

The docs job also uploads a zip file of the built html docs you can use to see the output from reno: https://dev.azure.com/qiskit-ci/qiskit-terra/_build/results?buildId=3737&view=artifacts

authors: kdk mtreinish


text:
Fix pulse limit_amplitude unittest

Summary
The class variable limit_amplitude in Pulse base class controls validation of max pulse amplitude. When this is disabled, user can set amplitude exceeding 1.0.
Seems like this test is for testing above behavior, however, nothing is tested.
Details and comments

Pull Request Test Coverage Report for Build 2161288835

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 83.944%

Totals

Change from base Build 2157761883:
0.0%

Covered Lines:
54201

Relevant Lines:
64568

💛  - Coveralls


text:
Gate with parameterized gate and phase is bound incorrectly

Information

Qiskit Terra version: main @ a2cc56f82ebbfd83fb9dc87e9f5dd59eacba9709
Python version: 3.7.9
Operating system: macOS

What is the current behavior?
A circuit that contains a gate with the same parameter both in a gate and the global phase does bind the parameters, but it still shows up as free in the bound circuit.
Steps to reproduce the problem
from qiskit.circuit import *

x = Parameter('x')
inner = QuantumCircuit(1)
inner.global_phase = x
inner.rx(x, 0)

bound = inner.assign_parameters([0])
print("Inner", bound.parameters, "and decomposed", bound.decompose().parameters)

outer = QuantumCircuit(inner.num_qubits)
outer.append(inner.to_gate(), outer.qubits)

bound = outer.assign_parameters([0])
print("Outer", bound.parameters, "and decomposed", bound.decompose().parameters)

Results in
Inner ParameterView([]) and decomposed ParameterView([])
Outer ParameterView([]) and decomposed ParameterView([Parameter(x)])

What is the expected behavior?
The decomposed outer circuit should not have free parameters.
Suggested solutions

This is no longer reproducible as of Qiskit 1.0.1 and appears to do the right thing now, so I'll close this issue as complete.

authors: Cryoris jakelishman

repo: Qiskit/qiskit


text:
Localise py_op caching data in RefCell

Summary
This localises the caching concerns of the PackedInstruction::py_op field into a method unpack_py_op, which can now update the cache through an immutable reference (if no other immutable references are taken out).  Having the new method to encapsulate the cache_pyops feature simplifies the large #[cfg(feature = "cache_pyop")] gates.

Details and comments
Locally, this had no impact for me on runtime performance for the benchmarks of #12459 if (on macOS) I set the MallocMediumZone=0 environment variable, but I did see a reduction in performance without that set.  That said, setting it also caused a sizeable improvement in the benchmarks without this PR as well.
This will make memory usage a bit worse while the pygate caching is in place (the RefCell makes the cost 2 pointers rather than one), but since we're roughly hoping to remove that before 1.2, it's probably worth doing.  This commit makes it much harder to forget to set the cache (which a few places in the existing code were doing), and means that the APIs (&self vs &mut self) don't need to change within the feature flag, which will make ripping the cache out easier in the future. edit: if necessary, we can trade off the memory usage against a shade more runtime cost by boxing the RefCell, which should be ok since performance-critical Qiskit code largely shouldn't be using the caching mechanisms by the time of the 1.2 release, but if the caching is still enabled in release builds, then the memory costs would be paid by everyone.
Will clash with #12593 (most of its changes are already made locally here too) but I can sort that out easily.

Pull Request Test Coverage Report for Build 9552158178
Details

63 of 63 (100.0%)  changed or added relevant lines in 2 files are covered.
19 unchanged lines in 3 files lost coverage.
Overall coverage decreased (-0.006%) to 89.735%

Files with Coverage Reduction
New Missed Lines
%

crates/qasm2/src/lex.rs
4
92.62%

crates/qasm2/src/parse.rs
6
97.15%

crates/circuit/src/circuit_data.rs
9
90.94%

Totals

Change from base Build 9551377748:
-0.006%

Covered Lines:
63341

Relevant Lines:
70587

💛  - Coveralls

This looks like it does: 1) refactor a lot of code into unpack_py_op. and 2) Use RefCell to hide the mutability of a reference.
When caching the python op is removed there will be no need for a mutable ref.
I'm curious if it is possible to get the same refactoring benefit without using RefCell, rather continuing to use a plain vanilla mutable ref. Does the part about making it harder to forget to update the cache depend only on the refactoring?
Since caching the Python op is supposed to be a bridge anyway, and there are not dramatic performance differences, maybe it's not a big deal whether RefCell is used or not.  I do like the idea of boxing the RefCell.

John: in theory this can be done without the RefCell, just that then everywhere that handles PackedInstruction needs to have a mutable reference to it, not just a base reference.  Since PackedInstruction is the data-at-rest format from within the CircuitData struct, that means that methods on CircuitData would need to take that by mutable reference as well, etc, so it proliferates.
About the refactoring: reducing the duplicated code in the #[cfg(feature = "cache_pygates")] down to single expressions was actually the original purpose of this PR, but in doing that I realised that there were places that were forgetting to update the cache (I think CircuitData::foreach_op was one?) and that there were some functions where the split was that the cache_pygates version needed to take a mutable reference where the base method took an immutable one.

With the same principles of moving fast and undoing if necessary, I'll merge this now to avoid further merge conflicts, since it may well get touched up as part of #12622 anyway.

authors: coveralls jakelishman jlapeyre


text:
How to hide sensibles data like passwords, tokens, ...

Hello,
First, thanks for your really useful package !
I would like to hide secrets data like password, tokens, private_key, ... Do you have any solution ?
I think the best approch is to check the argument name in case of simple structure (str, int, ...) and argument content in case of dict for example, then override the sensitive data by a raw string. Do you know what function I can override ?
I know it would not be perfect, but if we could avoid the majority of the leaking it's already a huge step.
Thanks in advance,
Max

Yeah, don't use this package if you're working with sensitive information. It's not meant to be used in production. There is no other alternative here - anything would be a hack at best, insecure at worst.

repo: Qix-/better-exceptions


text:
[BUG] Provider icons icons not appear in login page browsing with Firefox

Steps
Loading login page with Firefox
Expected Result
To see icons fro googe + , github, facebook, etc
Actual Result
icons not appear
Version
x.y.z
Testcase

@sevastosm I appreciate your support. It is not valid for data URIs to contain # characters. It's resolved 👍

authors: Qolzam sevastosm

repo: Qolzam/react-social-network


text:
Added model classes for apply connectivity, added tests

This change is

Changes Unknown when pulling e2d6af9190be35fc865bec9b3972466fa9ef09a7 on refactoring_14092016 into ** on dev**.

Changes Unknown when pulling 5691dc0b449f3497c2984f2fcbf19a150bfdf3fc on refactoring_14092016 into ** on dev**.

Changes Unknown when pulling b687a98b9ecc6bbb48fc0757a8e03dc3d2049726 on refactoring_14092016 into ** on dev**.

Changes Unknown when pulling 2de023c381c7354f04af988e6cb628c87bac8292 on refactoring_14092016 into ** on dev**.

Reviewed 7 of 11 files at r1, 2 of 12 files at r2, 3 of 22 files at r3, 9 of 14 files at r5.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

authors: coveralls doppleware

repo: QualiSystems/cloudshell-networking-core


text:
Same key transaction

https://github.com/QuantConnect/Lean/blob/c88a88ebc525e5dc5d3bc5750cc926c23b48c41c/Common/Securities/SecurityPortfolioManager.cs#L638
This code threw for me in live mode. I understand it's a very rare occurrence, but it happened. (I am doing multiple different checks to exit).
I'll write around it for now, but perhaps we need to think of a different key here.

I'm not sure we even need this to be a dictionary. I could see us storing a list with the same data and for pnl analysis later, simply summing profit/loss at each uniquely represented point in time. This would remove the potential duplicate key error and arguably provide more accurate statistics since we wouldn't be pushing duplicates by a millisecond (consider making 1,000 trades on the same minute, the first would show up having executed at 9:31:00AM and the last one would be at 9:31:01AM, a full second later. Not huge, but a place where we can improve fidelity.

@Worthy7 -- for bug reports, please use the template provided as it ensures certain pieces of information are given. For example, it would be nice to include a representative case (maybe a trimmed down version of your algorithm that demonstrates the issue, the exception/stack trace thrown, the expected behavior and the actual behavior was already provided.)

@mchandschuh  Yea I know sorry, but I couldn't reproduce it, it just randomly happened the one time. If it happens again I'll take down more info. I'll post the stack trace tomorrow

I filtered out some noise and wrote my explanation on it:
Order Entry Long
2018-06-14T07:33:35.0451314Z TRACE:: BrokerageTransactionHandler.Process(): 2018/06/14 7:33:35 UTC: Submit Order: (1) - OrderId: 1 New Market order for 2407000 units of EURUSD Entry Status: Unprocessed
2018-06-14T07:33:35.9972153Z TRACE:: BrokerageTransactionHandler.OrderStatusChanged(): Time: 2018/06/14 7:33:35 OrderID: 1 Symbol: EURUSD Status: Submitted BrokerId: 113
2018-06-14T07:33:36.0031871Z TRACE:: LiveTradingResultHandler.OrderEvent(): Time: 2018/06/14 7:33:35 OrderID: 1 Symbol: EURUSD Status: Submitted
Entry Long filled
2018-06-14T07:33:36.0061862Z TRACE:: BrokerageTransactionHandler.OrderStatusChanged(): Time: 2018/06/14 7:33:36 OrderID: 1 Symbol: EURUSD Status: Filled Quantity: 2407000 FillPrice: 1.18149 USD Message: Oanda Fill
2018-06-14T07:33:36.0221737Z TRACE:: LiveTradingResultHandler.OrderEvent(): Time: 2018/06/14 7:33:36 OrderID: 1 Symbol: EURUSD Status: Filled Quantity: 2407000 FillPrice: 1.18149 USD Message: Oanda Fill Event
Order Stop Loss
2018-06-14T07:33:36.0261722Z TRACE:: BrokerageTransactionHandler.Process(): 2018/06/14 7:33:36 UTC: Submit Order: (2) - OrderId: 2 New StopMarket order for -2407000 units of EURUSD at stop 1.18083 Exit Status:
2018-06-14T07:33:36.3943976Z TRACE:: BrokerageTransactionHandler.OrderStatusChanged(): Time: 2018/06/14 7:33:36 OrderID: 2 Symbol: EURUSD Status: Submitted BrokerId: 115
2018-06-14T07:33:36.3953979Z TRACE:: LiveTradingResultHandler.OrderEvent(): Time: 2018/06/14 7:33:36 OrderID: 2 Symbol: EURUSD Status: Submitted

some time later

Hit take profit target (which is not an order, just detected)
Order Cancel the stop loss order
2018-06-14T07:56:24.0040385Z TRACE:: BrokerageTransactionHandler.Process(): 2018/06/14 7:56:24 UTC: Cancel Order: (2) -  Status: Unprocessed
2018-06-14T07:56:24.0070090Z TRACE:: LiveTradingResultHandler.OrderEvent(): Time: 2018/06/14 7:56:24 OrderID: 2 Symbol: EURUSD Status: CancelPending

Order Take Profit
2018-06-14T07:56:24.0170294Z TRACE:: BrokerageTransactionHandler.Process(): 2018/06/14 7:56:24 UTC: Submit Order: (3) - OrderId: 3 New Market order for -2407000 units of EURUSD Exit Status: Unprocessed

Cancel stop loss order succeeded
2018-06-14T07:56:25.1539502Z TRACE:: BrokerageTransactionHandler.OrderStatusChanged(): Time: 2018/06/14 7:56:25 OrderID: 2 Symbol: EURUSD Status: Canceled Message: Oanda Cancel Order Event BrokerId: 115
2018-06-14T07:56:25.1539502Z TRACE:: LiveTradingResultHandler.OrderEvent(): Time: 2018/06/14 7:56:25 OrderID: 2 Symbol: EURUSD Status: Canceled Message: Oanda Cancel Order Event

Take profit order fills
2018-06-14T07:56:25.6037494Z TRACE:: BrokerageTransactionHandler.OrderStatusChanged(): Time: 2018/06/14 7:56:25 OrderID: 3 Symbol: EURUSD Status: Submitted BrokerId: 117
2018-06-14T07:56:25.6037494Z TRACE:: LiveTradingResultHandler.OrderEvent(): Time: 2018/06/14 7:56:25 OrderID: 3 Symbol: EURUSD Status: Submitted
2018-06-14T07:56:25.6057461Z TRACE:: BrokerageTransactionHandler.OrderStatusChanged(): Time: 2018/06/14 7:56:25 OrderID: 3 Symbol: EURUSD Status: Filled Quantity: -2407000 FillPrice: 1.18172 USD Message: Oanda Fill
2018-06-14T07:56:25.6747066Z TRACE:: LiveTradingResultHandler.OrderEvent(): Time: 2018/06/14 7:56:25 OrderID: 3 Symbol: EURUSD Status: Filled Quantity: -2407000 FillPrice: 1.18172 USD Message: Oanda Fill Event

Error
2018-06-14T07:56:25.6996919Z ERROR:: SecurityPortfolioModel.ProcessFill():  System.ArgumentException: 同一のキーを含む項目が既に追加されています。
   場所 System.ThrowHelper.ThrowArgumentException(ExceptionResource resource)
   場所 System.Collections.Generic.Dictionary`2.Insert(TKey key, TValue value, Boolean add)
   場所 System.Collections.Generic.Dictionary`2.Add(TKey key, TValue value)
   場所 QuantConnect.Securities.SecurityPortfolioManager.AddTransactionRecord(DateTime time, Decimal transactionProfitLoss) 場所 C:\Users\Ian\Source\Repos\QuantLeanian\Common\Securities\SecurityPortfolioManager.cs:行 638
   場所 QuantConnect.Securities.SecurityPortfolioModel.ProcessFill(SecurityPortfolioManager portfolio, Security security, OrderEvent fill) 場所 C:\Users\Ian\Source\Repos\QuantLeanian\Common\Securities\SecurityPortfolioModel.cs:行 109

Prints the same line again as before
2018-06-14T07:56:25.6996919Z TRACE:: LiveTradingResultHandler.OrderEvent(): Time: 2018/06/14 7:56:25 OrderID: 3 Symbol: EURUSD Status: Filled Quantity: -2407000 FillPrice: 1.18172 USD Message: Oanda Fill Event

After this the algo crashes/stops

This should be resolved via https://github.com/QuantConnect/Lean/pull/2297
@Martin-Molinero -- please check this out and confirm my suspicions here.

Yes, this shouldn't happen anymore. Also, I believe this happened due to this other guy https://github.com/QuantConnect/Lean/issues/2204, also solved.

authors: Martin-Molinero Worthy7 mchandschuh

repo: QuantConnect/Lean


text:
Unexpected Order Event Handling

Expected Behavior
Settings.UnexpectedOrderEventsHandling
    = UnexpectedOrder.Ignore       # Drop without matching order id.
    = UnexpectedOrder.Merge       # Add asset; accept the fill.
    = UnexpectedOrder.Shutdown # Default

void OnUnexpectedOrderEvent(UnexpectedOrderEvent event);

It could allow users to manually enter with intelligent risk control exits. Or reusing the same UUID in FIX networks.
Actual Behavior
Always shuts down strategy.
Potential Solution
In the fill handling add the additional options above and act based on the setting of the strategy.
Reproducing the Problem
Placing a trade in the OANDA cloud terminal while running a live Oanda algorithm
Checklist

[x] I have filled out this template
[x] I have confirmed that this issue exists on the current master branch
[x] I have confirmed that this is not a duplicate issue by searching issues

The IBrokerageMessageHandler already allows this functionality, overriding the HandleOrder and setting a custom behavior, see  for example https://github.com/QuantConnect/Lean/blob/master/Algorithm.Python/CustomBrokerageSideOrderHandlingRegressionPartialAlgorithm.py.  By default orders are rejected
TODO here: Brokerages should now trigger the new OnNewBrokerageOrderNotification base method to trigger the functionality

authors: Martin-Molinero jaredbroad


text:
Use IBaseData in type constraints

Refactors existing consolidators, indicators, and helper methods to depend on
IBaseData instead of BaseData. These updates also defines an IBaseDataBar to
act as an abstraction point between TradeBar and QuoteBar.
Tried to think of a way of making this in smaller commits but it really is a
systemic change. Most of the changes involve changing TradeBar references
to the new IBaseDataBar (open to suggestions on naming). Some other
changes were to the indicator selectors, now Func<IBaseData, decimal> and
Func<IBaseData, IBaseDataBar>

With the code changes done, we'll want to re-assess the potential impact on user code. I was able to make these changes with only one update required in an algorithm, so if that counts as a litmus than we should be pretty safe with these changes.

Should QuoteBar implement IBaseDataBar rather than IBar? That way, QuoteBar can be used in all the indicators.
So this: public class QuoteBar : BaseData, IBaseDataBar
Rather than: public class QuoteBar : BaseData, IBar

@andrewhart098: yes, absolutely.


text:
Update the contributing to QuantEcon.jl page?

Maybe some people here could improve the pages here: https://quantecon.org/julia-developers

Initial thoughts:

[ ] Point people to the lecture-source-jl repo (which we should probably clean up for new contributors).

[ ] Remove stuff about style guides not existing. There's a good one on the Julia website and on the lectures repo. The linked PR for docstrings has also been merged in.

[ ] Remove the stuff about test guides not existing, and instead replace it with a short intro to unit and regression tests.

[ ] Link people to the first few lectures in the Julia side (i.e., getting started, version control, tools_editors) so that people are working with a consistent setup.

authors: arnavs natashawatkins


text:
Added default impl for ModifiersState

It is convenient to store current state of modifiers to process them in mouse click or something else.
But there is no way to create "empty" state, unless using Option. It is not very convenient to carry around an Option, so the default() method is more appropriate approach.

Thanks, looks good to me and should definitely be useful. Congrats on making the first ever pull request for this project :) I'll update the changelog.

Changelog updated here: https://github.com/QuantumBadger/Speedy2D/commit/a7f2b31a48d1c576e808f25bdb21f30b6ff18e42. Thanks again!

authors: QuantumBadger Revertron


text:
messageMemoryStorage returns 0 messages for dialogID when I open app after terminating.

Did this work before?
No. Seems like it clears cache on terminating app.
Expected behavior
The messages must be saved like dialogs.
Actual behavior
When I initiate chat and send a message, the messageMemoryStorage returns that message till I am in app. Once I terminate the app and try to retrieve messages from storage with same method, it returns 0.
Any others comments?
How can I save the messages like dialogs ? Dialogs stay in memory until I delete the app. But, messages do not. How does the cache for Messages work ?

@unoiatech, This bug is not reproducible in our samples and Q-municate. Please attach full logs.
[QBSettings setLogLevel:QBLogLevelDebug];
[QBSettings enableXMPPLogging];

authors: VitaliyGuru unoiatech

repo: QuickBlox/q-municate-services-ios


text:
all_tenants attribute in Beat Schedule

Hello,
This might be a very stupid question, but what does the all_tenants attribute do when creating a beat schedule?
For example, I want to create a task that runs at 5am everyday for each tenant, but I would like the tenant to be able to change the time as they please. Would I set all_tenants to true or false?
app.conf.beat_schedule = generate_beat_schedule(
    {
        "celery.backend_cleanup": {
            "task": "celery.backend_cleanup",
            "schedule": crontab("0", "4", "*"),
            "options": {"expire_seconds": 12 * 3600},
            "tenancy_options": {
                "public": False,
                "all_tenants": True,
                "use_tenant_timezone": True,
            }
        },
    }
)

Setting all_tenants to true will result in a periodic task being created for all tenants in their respective schemas. The configuration options will all be the same, so you can't change the time individually (apart from via the time zone setting). The generate_beat_schedule function is just a helper to save you having to duplicate a lot of the beat schedule dict. You can still manually add entries if you need more control. Check out the source for that function here.
You can also create and manage periodic tasks in the Django admin, which sounds like what you're after in this case. That allows admin users in each tenant to configure the scheduling as normal. See here. The app.conf.beat_schedule is a static definition of tasks that you know you want in advance, so it doesn't sound appropriate for your situation.

authors: dave-v premudeshi

repo: QuickRelease/django-tenants-celery-beat


text:
Bug Description
Mac下，网页的右键菜单只有复制

已尝试重启obsidian
已尝试重装该插件
其余web-browser插件已关闭

网页选中后右键如下图：

Relevant Screenshot
No response
To Reproduce
No response
Obsidian Version
0.3.0
web-browser-only

[X] Did you install only one web browser plugin?

Checklist

[X] I updated to the latest version of the plugin.

目前不清楚该如何修复，已经用 mac 尝试了一下

尝试了下似乎还是无效，并不能拖动内容到新的面板：

按住 CTRL 拖动这个选中内容来生成链接

obsidian 版本：v1.0.3
surfing 版本：0.6.2
已尝试重启软件和插件，并测试了多个网页，也许是 obsidian 版本的原因？

这里指的是拖动到编辑器中，你这边需要拖到编辑器再尝试一下。

是的，我就是这么尝试的，左边网页，右边测试的md文件（编辑状态），按照你的提示，按住 Ctrl 无法拖动选中的内容到右边编辑器中。
另，按住 Ctrl 尝试拖动选中内容时，会出现一个和右键一样的 copy 菜单，但仍旧无法拖动选中的文字。

可以说勉强能够使用 😂

authors: AaronNick Quorafind

repo: Quorafind/Obsidian-Surfing


text:
[✨] vite ssr mode: pre-load entry.ssr.tsx

Is your feature request related to a problem?
I would like to run server code inside the qwik-city server.
:point_right: Obviously I can put it in the server entry, but I also want to run in dev ssr mode.
:point_right: Obviously I can call the server entry point from entry.ssr.tsx which is called from both places, but then Vite will only execute that on first render.
Describe the solution you'd like
Is it possible to load the entry code before vite calls it? That way, it also speeds up the first SSR render.
Describe alternatives you've considered
Maybe an option to define a server-code entry point?
Additional context
No response

We moved this issue to qwik-evolution repo to create a RFC discussion for this.
Here is our Qwik RFC process thanks.

authors: gioboa wmertens

repo: QwikDev/qwik


text:
Crash removing runtime/compiled folder

Crash log from user in Discord:
nslog2023-09-12_21-48-53.txt
Seems to be caused by this code?
https://github.com/R2Northstar/NorthstarLauncher/blob/07e76e3a8e2738dbb7a1d5a6aeaa908a838f5a02/NorthstarDLL/mods/modmanager.cpp#L589
Solution to the problem was to delete the folder manually, although this is a temporary fix I would assume.

"remove_all: Zugriff verweigert: "R2Northstar\runtime\compiled"

The launcher doesn't have the necessary permissions to delete the folder for some reason

The launcher doesn't have the necessary permissions to delete the folder for some reason

That seems to be the case, yeah. We definitely shouldn't crash like this though, should probably display an error dialog or something explaining the issue? (Or we could try and handle the exception nicely but I doubt that that is possible given the error)

Yeah a windows message box would probably be enough.
How does this even happen though

I honestly have no idea. Perhaps just a read-only folder thing for some reason? perhaps they installed the game into a read-only folder and then marked most of it as not read-only, but missed this folder somehow? idk

authors: ASpoonPlaysGames uniboi


text:
Fix Northstar.dll not loading from non-ascii profile name

Fixed an issue where a northstar dll wouldn't be loaded if the profile containing it had non-ascii characters in it's name.
I also removed an unnecessary scope and instead of dereferencing a null pointer when failing to load the LauncherMain function, the program returns 1.

Some changes to the pr: it rewrote it to only use utf8 strings instead of wide strings.
This makes the code a more consistent since the old code was using both utf8 and wide strings in an inconsistent way.

Eh, just changing to -A APIs isn't really gonna fix things (it would on later OSs if Northstar opted into the UTF-8 support thing). I think it should be best kept to -W APIs, and common conversion helper util functions for charset conversions should be defined somewhere.
Also the stuff you put outside of code block was inside of it in order to minimize the unneeded inflation of stack size for the whole program lifetime. It'd be better to put some stuff that was above inside of it too, rather than removing it.
Not to mention the whole conversion could have been avoided in the first place if command line was also parsed with GetCommandLineW() instead :v

Eh, just changing to -A APIs isn't really gonna fix things (it would on later OSs if Northstar opted into the UTF-8 support thing). I think it should be best kept to -W APIs, and common conversion helper util functions for charset conversions should be defined somewhere.
Also the stuff you put outside of code block was inside of it in order to minimize the unneeded inflation of stack size for the whole program lifetime. It'd be better to put some stuff that was above inside of it too, rather than removing it.
Not to mention the whole conversion could have been avoided in the first place if command line was also parsed with GetCommandLineW() instead :v

The scope only contained a single bool, it didn't think that scope was necessary. Maybe we put the entire startup stuff into another function which returns the LauncherMain function pointer, then make the main function only call those two functions?

From my initial testing unicode characters with the -A functions seemed to work fine. however i just discovered that it doesn't work with japanese characters for example, so you're right.

after some more testing: even if the launcher can deal with "more advanced" unicode characters in the game path (i tested japanese characters), at some point it crashes in northstar.dll

Maybe we put the entire startup stuff into another function which returns the LauncherMain function pointer, then make the main function only call those two functions? I think this would be more readable.

Yeah, this is exactly what I ended up doing in TFORevive, as the launcher code is based on its very old version originally (just that originally there were a bit more variables, including some buffers for paths, that are not here anymore). So I approve of that idea.

after some more testing: even if the launcher can deal with "more advanced" unicode characters in the game path (i tested japanese characters), at some point it crashes in northstar.dll

Hm, probably not everyone contributing code over time that dealt with paths considered this problem. I think having the game process opt into using UTF-8 could be worthwhile (this requires creating a .manifest file and passing it to the linker iirc), it'd only work in newer Windows 10's and up (on old ones it'd just work like before), but at least it'd ensure the game and all dependent libraries would work with those paths.
In such case it might be fine to use the -A APIs, provided we know it'd break the game itself either way otherwise...
It's worth to keep in mind though that std::filesystem::path uses wide strings internally on Windows though, so some conversions might sometimes be still unavoidable.
The manifest file would look like this (bonus point is that the process won't be faked into thinking it runs on Windows 8.1 by WinAPI with this):
<?xml version="1.0" encoding="UTF-8" standalone="yes"?>
<assembly xmlns="urn:schemas-microsoft-com:asm.v1" manifestVersion="1.0">
  <application xmlns="urn:schemas-microsoft-com:asm.v3">
    <windowsSettings>
      <activeCodePage xmlns="http://schemas.microsoft.com/SMI/2019/WindowsSettings">UTF-8</activeCodePage>
    </windowsSettings>
  </application>
  <compatibility xmlns="urn:schemas-microsoft-com:compatibility.v1">
    <application>
      <!-- Windows 10 and Windows 11 -->
      <supportedOS Id="{8e0f7a12-bfb3-4fe8-b9a5-48fd50a15a9a}"/>
      <!-- Windows 8.1 -->
      <supportedOS Id="{1f676c76-80e1-4239-95bb-83d0f6d0da78}"/>
      <!-- Windows 8 -->
      <supportedOS Id="{4a2f28e3-53b9-4441-ba9c-d69d4a4a6e38}"/>
      <!-- Windows 7 -->
      <supportedOS Id="{35138b9a-5d96-4fbd-8e2d-a2440225f93a}"/>
    </application>
  </compatibility>
</assembly>

I ended up going with wstrings anyways, because:

I already made a functioning version with wstrings for testing
Even if it crashes in later either way, if we ever try to fix the issues with unicode characters in the game's path or profile name, having the launcher already support it is better than having it not.

I also put the initialization stuff in InitNorthstar, so the stack size is lower when the game is running without having that scope in the main function.


text:
Add UI for adding Protocol for app

This will allow scheduling from the server or just exposing the protocol via the REST endpoints so the app can use it.
The UI should have feature for easy readability and configuration like randomizing schedule times, more readable ways of specifying the protocol (like 3 times a day every 6 weeks), etc.

This would be migrated to https://github.com/RADAR-base/radar-app-config

repo: RADAR-base/RADAR-Appserver


text:
Feature/quota restrict

Ticket
GRDM#9826
Purpose
ディスク容量のクォータ機能をPRいたします。
対応するフィーチャーは以下になります。
　【フィーチャー】クォータ制限を超えたファイル登録を抑止する（#9826）
Changes
Side effects
QA Notes
Deployment Notes
RCOSDP/RDM-osf.io/commits/feature/inst-sto_quota-restrict_staging
　もあわせてデプロイしてください。
　その際、機能を動作させるためには 、RDM-osf.io 側の .docker-compose.wb.env
　ファイル の OSF_URL 変数を利用できるようにする必要があります。

Pull Request Test Coverage Report for Build 42

16 of 16 (100.0%)  changed or added relevant lines in 5 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.02%) to 87.193%

Totals

Change from base Build 39:
0.02%

Covered Lines:
7680

Relevant Lines:
8808

💛  - Coveralls

repo: RCOSDP/RDM-waterbutler


text:
add default case

fixes #2

Thank you for fixing this. Merged

No problemo, thank you for the writing this in the first place! Saves me a ton of work.

authors: RCmags icannotfly


text:
imap crawler: [error] error retrieving message b'20' failded to fetch

Hello,
i tried different imap-servers for the crawler. But only a few local installations worked as expected.
I still have problems with gmail - and outlook.com gave me the same error:
2017-08-06 11:31:28.752: [info] filecrawler initialized
2017-08-06 11:31:30.049: [info] crawling xxx@gmail.com at imap.gmail.com
2017-08-06 11:31:30.349: [error] error retrieving message b'20' failded to fetch
2017-08-06 11:31:30.650: [info] done
My config:
{
"id": "Gmail",
"uid": "Gmail_d033e22ae348aeb5660fc2140aec35850c4da997",
"description": "Test",
"type": "imap",
"locations": [
{
"host_name": "imap.gmail.com",
"ip_address": "",
"location": "xxx@gmail.com"
}
],
"file_regex": "(\.doc[a-z]$)|(\.xls[a-z]$)|(\.txt$)|(\.csv$)|(\.htm[a-z]$)|(\.ppt[a-z]$)|(\.pdf$)|(\.msg$)|(\.zip$)|(\.eml$)|(\.rtf$)|(\.md$)|(\.png$)|(\.bmp$)|(\.tif[f]$)|(\.jp[e]g$)|(\.hwp$)",
"credentials": {
"auth_type": "basic",
"login": "xxx@gmail.com",
"password": "***",
"token": ""
},
"schedule": {
"is_active": false,
"cron_schedule": "/15 * * * *"
},
"max_file_size_bytes": 30000000,
"verbose": true
}
Thank you!

I found the following change to imapcrawler.py:
<<<<<
callResult, data = self.connection.fetch(messageId, '(RFC822)')
callResult, data = self.connection.uid('fetch', messageId, '(BODY.PEEK[])')

Makes gmail work -- not sure why calling the fetch method directly instead of using the uid call makes it choke on the message ids.  Also, changing RFC822 to BODY.PEEK[] keeps your mail unread.

Implemented, see 2fc84df85cd06895e0ec1b282348c64672d035ab
Thanks for your input!


text:
Refactor of the Cartridge struct

CartridgeHeader is now in the "Cartridge" file along with the "Cartridge" struct, which is respondible to take raw data and turn it in header fields and ROM (most of the fields are missing at the moment)
Cartridge takes the ROM data under the "rom" field in a reference counted ptr, so the type inside the ARM7TDMI implementation of the CPU was modified

This pull request is referring issue #9

I should have got rid of most of the problems

@simo498 it looks strange because I see my changes about CI here 🤔

@simo498 it looks strange because I see my changes about CI here 🤔

Yeah i know, i don't actually know why they are in my commit, maybe after pulling updates from main?

@simo498 it looks strange because I see my changes about CI here 🤔

Yeah i know, i don't actually know why they are in my commit, maybe after pulling updates from main?

Don't know what you did, but you can re-write your single commit with only you changes with a nice commit message because "Start refactoring" doesn't means nothing to other people that read that

@simo498 it looks strange because I see my changes about CI here 🤔

Yeah i know, i don't actually know why they are in my commit, maybe after pulling updates from main?

Don't know what you did, but you can re-write your single commit with only you changes with a nice commit message because "Start refactoring" doesn't means nothing to other people that read that

Did it👍

authors: gallottino guerinoni simo498

repo: RIP-Comm/clementine


text:
Support for custom sql_query injection to index via config with param-bindings

In practice there can be non-standard situations where even multiple QueryParams - where clauses,  sorting, limiting etc couldn't be sufficient, ex.: some sort of nested queries, or aggregate functions usage or may be combination of those.

https://laravel.com/docs/5.4/database#listening-for-query-events

    'custom_sql'    => [
        'article' => [
            'enabled' => true,
            'query'   => 'SELECT title FROM article WHERE tag_id IN (SELECT id FROM tags WHERE CHAR_LENGTH(tag) > 5) ORDER BY id DESC',
        ],
    ],

repo: RJAPI/raml-json-api


text:
🛑 Sensor Tracker login is down

In 1e75c4a, Sensor Tracker login (https://stg.ceotr.ca/sensor_tracker) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Sensor tracker login is back up in ff48c1d after 1 minute.

repo: RKTowse/upptime


text:
🛑 CEOTR Home Page loads is down

In 84acc86, CEOTR Home Page loads (https://stg.ceotr.ca CEOTR Home) was down:

HTTP code: 0
Response time: 0 ms

Resolved: CEOTR Home Page loads is back up in 39aa377 after 2 minutes.


text:
🛑 CEOTR Home Page loads is down

In d426666, CEOTR Home Page loads (https://stg.ceotr.ca CEOTR Home) was down:

HTTP code: 0
Response time: 0 ms

Resolved: CEOTR Home Page loads is back up in 09a84ed.


text:
🛑 Sensor Tracker login is down

In fee7a01, Sensor Tracker login (https://stg.ceotr.ca/sensor_tracker) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Sensor tracker login is back up in 594edf1 after 8 minutes.


text:
🛑 Sensor Tracker login is down

In fb3ddff, Sensor Tracker login (https://stg.ceotr.ca/sensor_tracker) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Sensor tracker login is back up in fd6a83a after 1 minute.


text:
🛑 CEOTR Home Page loads is down

In 4e08409, CEOTR Home Page loads (https://stg.ceotr.ca CEOTR Home) was down:

HTTP code: 0
Response time: 0 ms

Resolved: CEOTR Home Page loads is back up in d9d0b8d after 2 minutes.


text:
🛑 CEOTR Home Page loads is down

In 6fa7030, CEOTR Home Page loads (https://stg.ceotr.ca CEOTR Home) was down:

HTTP code: 0
Response time: 0 ms

Resolved: CEOTR Home Page loads is back up in 56d58bd after 2 minutes.


text:
🛑 Sensor Tracker login is down

In 6f397d6, Sensor Tracker login (https://stg.ceotr.ca/sensor_tracker) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Sensor tracker login is back up in 2876c66 after 1 minute.


text:
🛑 Sensor Tracker login is down

In ea65eb2, Sensor Tracker login (https://stg.ceotr.ca/sensor_tracker) was down:

HTTP code: 502
Response time: 83 ms

Resolved: Sensor tracker login is back up in d56f4c1.


text:
🛑 Sensor Tracker login is down

In ab14a05, Sensor Tracker login (https://stg.ceotr.ca/sensor_tracker) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Sensor tracker login is back up in d79d932 after 1 minute.


text:
🛑 CEOTR Home Page loads is down

In 0690c19, CEOTR Home Page loads (https://stg.ceotr.ca CEOTR Home) was down:

HTTP code: 0
Response time: 0 ms

Resolved: CEOTR Home Page loads is back up in f51f638 after 2 minutes.


text:
🛑 CEOTR Home Page loads is down

In 32238d2, CEOTR Home Page loads (https://stg.ceotr.ca CEOTR Home) was down:

HTTP code: 0
Response time: 0 ms

Resolved: CEOTR Home Page loads is back up in ae44680 after 2 minutes.


text:
🛑 Sensor Tracker login is down

In 9b3f2d4, Sensor Tracker login (https://stg.ceotr.ca/sensor_tracker) was down:

HTTP code: 502
Response time: 107 ms

Resolved: Sensor tracker login is back up in 443fe7b.


text:
🛑 Sensor Tracker login is down

In 1f99cd8, Sensor Tracker login (https://stg.ceotr.ca/sensor_tracker) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Sensor tracker login is back up in 313ba30 after .


text:
🛑 Sensor Tracker login is down

In 30b37e3, Sensor Tracker login (https://stg.ceotr.ca/sensor_tracker) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Sensor tracker login is back up in 50cc9b6 after .


text:
🛑 CEOTR Home Page loads is down

In 2a9b0cb, CEOTR Home Page loads (https://stg.ceotr.ca CEOTR Home) was down:

HTTP code: 0
Response time: 0 ms

Resolved: CEOTR Home Page loads is back up in 7e2f822.


text:
🛑 Sensor Tracker login is down

In c96983c, Sensor Tracker login (https://stg.ceotr.ca/sensor_tracker) was down:

HTTP code: 502
Response time: 126 ms

Resolved: Sensor tracker login is back up in fc25ce6.


text:
🛑 CEOTR Home Page loads is down

In 4219de4, CEOTR Home Page loads (https://stg.ceotr.ca CEOTR Home) was down:

HTTP code: 0
Response time: 0 ms

Resolved: CEOTR Home Page loads is back up in c643179 after 2 minutes.


text:
🛑 RMUG Installations is down

In 8f31965, RMUG Installations (https://installations.rmusergroup.net) was down:

HTTP code: 502
Response time: 298 ms

Resolved: RMUG Installations is back up in 1a08b74 after 14 minutes.

repo: RM-User-Group/RMUG-Upptime


text:
Remove some verbs from xenos

About the PR

Removed some verbs from xenos
Xenos can no longer:

light flares
remove webbings
toggle weapon attachables
toggle internals
attempt to pray
see or change gun fire modes
--- list incomplete, will update once I manage to find more ---

Why / Balance

Feel like most of these are unintentional
Resolves #3848, resolves #3202
Technical details

Added checks for XenoComponent in various GetVerbsEvent handlers
Media

Requirements

[x] I have read and I am following the Pull Request Guidelines. I understand that not doing so may get my pr closed at maintainer’s discretion
[x] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog

:cl:

fix: Xenos can no longer light flares on ground.
fix: Xenos can no longer remove webbings from jumpsuits.
fix: Xenos can no longer toggle attachables or internals.
fix: Xenos can no longer (attempt to) pray.
fix: Xenos can no longer see or change gun fire modes.

why can't xenos pray man! let us contant our xeno gods!!

authors: KingOnBudget crystalHex


text:
Blinking coins

Coins are blinking sometimes, need to investigate and remove the blinking.

Fixed, was an issue with instancing processing

repo: RMDarth/Chewman-Vulkan