text:
Support latest react and additional props #9

Updated the PR.

@alexkuz Could you please review this PR? Or maybe give @kof push rights to the repo if he wants to maintain the project and if you don’t mind?

@sapegin I'm sorry I'm not following this issue with proper attention lately.
I don't mind giving rights to @kof if he's up to it, but as for this issue - I'm still not convinced it's necessary, unless there are some performance issues (that should be solved by other means anyway).

I think there should be a better way to achieve what I wanted. Clear perf issue is to create markdown-it instances all the time. Ultimately it will require an incompatible public api change.

I am seeing this error with 0.3.0 when there is an image component in md.  Example -
readme = '# Some test \n This is a test \n ' +
''
Can someone accept this PR if code change is correct?

I have got commit rights, will do soon.
On Sep 17, 2017 10:40, "ajayapte" notifications@github.com wrote:

I am seeing this error with 0.3.0 when there is an image component in md.
Example -
readme = '# Some test \n This is a test \n ' +
'[image: Image alt text of mine]
https://camo.githubusercontent.com/133bb7f07f1debe42ff7fd91948de49d7867ec73/68747470733a2f2f7777772e796f75747562652e636f6d2f7974732f696d672f72696e676f2f696d672f696d6167652d68682d3430342d76666c503368714e542e706e67
'
Can someone accept this PR if code change is correct?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/alexkuz/markdown-react-js/pull/10#issuecomment-330029786,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AADOWITG0XfiPZPZaZQDGm8xBcUrGjU4ks5sjNr4gaJpZM4JPpKz
.

Any progress on this?

merged

Are there plans to publish these changes to NPM?

done

authors: ajayapte alexkuz kof sapegin smm-telus

repo: alexkuz/markdown-react-js


text:
Bubble Sort VB .net Implementation

Hey @dovisutu Sorry about the wait, we need someone to review this PR and unfortunately do not have a local expert in VB. We are waiting on a review before merging this one.

Well... Actually I'm doubted about the Realizing of Bubble Sort, because the input array is so different.
in C++,C and a lot of languages: [An integer array]
int input[] = {1, 45, 756, 4569, 56, 3, 8, 5, -10, -4};
in D: [A random float array]
auto input = generate!(() => uniform01!float).take(10).array;
in Julia and some other languages: [A float/double array]
a = [1., 3, 2, 4, 5, 10, 50, 7, 1.5, 0.3]
in Matlab: [A random integer array]
array = floor(rand(1, 7) * 100);
Anyhow, in my next commit, I'll change my reference from C++ [Because I can read it easier] to Julia [Leios's Standard?]

BTW, there's a VB .net document here, because I'm implementing bubble sort, this may be helpful.

BTW, there's a vb .net document here, since I'm implementing bubble sort, this may be work.

[lang: vb]

Sorry this took so long, but we don't accept sorting algorithm PRs any more.
I'm closing this.

source: gharchive/pull-request

authors: Amaras dovisutu leios ntindle

repo: algorithm-archivists/algorithm-archive

license: MIT

license_type: permissive

license_source: github-api


text:
fix typos in doc

thx

authors: luics lzyzsd

repo: alibaba/weex


text:
update version to 5.3.1

Codecov Report

Merging #12 into master will increase coverage by 0.18%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master     #12      +/-   ##
=========================================
+ Coverage   49.22%   49.4%   +0.18%
=========================================
  Files          45      45
  Lines        1093    1093
  Branches      183     183
=========================================
+ Hits          538     540       +2
+ Misses        433     430       -3
- Partials      122     123       +1

Impacted Files
Coverage Δ

...fa/rpc/boot/container/ProviderConfigContainer.java
74% <0%> (+4%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2b3502...e36f390. Read the comment docs.

authors: NeGnail codecov-io

repo: alipay/sofa-rpc-boot-projects


text:
custom domain support https

Coverage decreased (-0.009%) to 92.835% when pulling 662e857c412f939577dff8321c038139b7a9b4b4 on support-customdomain-https into 909eb478a8d07375ba341b858ff0666d182f5a43 on master.

authors: coveralls rsonghuster

repo: aliyun/fc-python-sdk


text:
Formatting Pages

Awesome. Thanks!

license: mit

license_source: bigquery


text:
Compute partial dependence for categorical variables

I filed this after having a conversation with @rpeck

@tyler3991 Can you provide more info? I believe our partial dependence method supports categoricals
https://github.com/alteryx/evalml/issues/1509

I believe #1509 fixed this! This issue tracks verifying that, make sure we have docs example in model understanding too

source: gharchive/issue

authors: dsherry freddyaboulton tyler3991

repo: alteryx/evalml


text:
关注过的up主会显示成关注按钮而不是粉丝团详情

这其实是为了隐身入场导致。下个版本会添加一个选项，让用户自行决定是否开启这个功能。


text:
Code Refactor and Testing

Open a beta branch instead.

repo: anew-org/store


text:
feat(overlay): add maxWidth and maxHeight

@jelbourn looks like there's a linting error.

Fixed lint
(I don't know why WebStorm doesn't trim trailing whitespace sometimes...)

authors: crisbeto jelbourn


text:
Update README.md

Codecov Report

Merging #149 into master will decrease coverage by 0.1%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master    #149      +/-   ##
=========================================
- Coverage   98.61%   98.5%   -0.11%
=========================================
  Files          31      31
  Lines         937     937
=========================================
- Hits          924     923       -1
- Misses         13      14       +1

Impacted Files
Coverage Δ

src/Discontinuity.jl
93.18% <0%> (-2.28%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d7f924...edfbfc5. Read the comment docs.

All fixed and merged, thanks!

authors: codecov-io davidanthoff


text:
Import and Export of actor templates

This would be great although all one has to do is create an actor from a template and then export that.

authors: PatrickBauer hendelmasad

repo: anvil-vtt/FateX


text:
feat(logger): replace bucker with bunyan

Great work! Thanks!

repo: anvilresearch/connect


text:
fix(signout): avoid double call to res.sendStatus

Coverage increased (+0.007%) to 79.75% when pulling 63e1580fb0ba530379bacd1d912ba21c11e1cd9a on camfou:fix_signout_return into 747b625395e7232ec1c43a6fcdac241e2af6dc24 on anvilresearch:master.

authors: camfou coveralls


text:
Make JDBC OpenFile Thread Safe

@mtaylor / @andytaylor  no JIRA?

I will push -f without this commit.. it should have had a JIRA

will leave it as it is.

authors: clebertsuconic mtaylor

repo: apache/activemq-artemis


text:
BIGTOP-3389. Extend timeout for installing protobuf and R packages.

Merged into master. Will kick the Docker-Toolchain-Trunk job on Jenkins again and check if this works as expected.

Installing protobuf sometimes failed when building aarch64 images, but with this PR, it succeeded for all distros on the first try.
https://ci.bigtop.apache.org/view/Docker/job/Docker-Toolchain-Trunk/130/OS=debian-9-aarch64/console
https://ci.bigtop.apache.org/view/Docker/job/Docker-Toolchain-Trunk/130/OS=debian-10-aarch64/console
https://ci.bigtop.apache.org/view/Docker/job/Docker-Toolchain-Trunk/130/OS=fedora-31-aarch64/console
https://ci.bigtop.apache.org/view/Docker/job/Docker-Toolchain-Trunk/130/OS=ubuntu-16.04-aarch64/console
https://ci.bigtop.apache.org/view/Docker/job/Docker-Toolchain-Trunk/130/OS=ubuntu-18.04-aarch64/console
But installing R packages is still failing on CentOS 7 even with this extended timeout. I'm going to retry a few times.
https://ci.bigtop.apache.org/view/Docker/job/Docker-Toolchain-Trunk/130/OS=centos-7-aarch64/console

Hmm, I tried several times but installing R packages is continuing to fail in building a CentOS 7 image.
(I'm not sure which one is the cause, distro or assigned EC2 instance performance. Maybe both?)
https://ci.bigtop.apache.org/view/Docker/job/Docker-Toolchain-Trunk/130/OS=centos-7-aarch64/console
https://ci.bigtop.apache.org/view/Docker/job/Docker-Toolchain-Trunk/131/OS=centos-7-aarch64/console
https://ci.bigtop.apache.org/view/Docker/job/Docker-Toolchain-Trunk/132/OS=centos-7-aarch64/console
https://ci.bigtop.apache.org/view/Docker/job/Docker-Toolchain-Trunk/133/OS=centos-7-aarch64/console
https://ci.bigtop.apache.org/view/Docker/job/Docker-Toolchain-Trunk/134/OS=centos-7-aarch64/console
https://ci.bigtop.apache.org/view/Docker/job/Docker-Toolchain-Trunk/135/OS=centos-7-aarch64/console
I'm going to submit another PR to extend its timeout more.

repo: apache/bigtop


text:
[FLINK-4506] CsvOutputFormat defaults allowNullValues to false, even …

I think should rather adjust the documentation to fit the current behavior. This discrepancy wasn't just introduced recently, as far as i can tell it has been there forever, or rather since the allowNullValues flag was introduced.

I agree with @zentol. this.allowNullValues = false; is the behavior since the initial code import. I would not change this and rather fix the JavaDocs.

Thanks for the update @kirill-morozov-epam!
Merging

authors: fhueske kirill-morozov-epam zentol

repo: apache/flink


text:
HDDS-1733. Fix Ozone documentation

@anuengineer Thanks for review :) The review commas have been addressed!

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
75
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

_ trunk Compile Tests _

+1
mvninstall
489
trunk passed

+1
mvnsite
0
trunk passed

+1
shadedclient
1386
branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1
mvninstall
508
the patch passed

+1
mvnsite
0
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
814
patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1
asflicense
62
The patch does not generate ASF License warnings.

3030

Subsystem
Report/Notes

Docker
Client=18.09.5 Server=18.09.5 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1031/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1031

Optional Tests
dupname asflicense mvnsite

uname
Linux f28664f6658a 4.15.0-48-generic #51-Ubuntu SMP Wed Apr 3 08:28:49 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / f02b0e1

Max. process+thread count
346 (vs. ulimit of 5500)

modules
C: hadoop-hdds/docs U: hadoop-hdds/docs

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1031/1/console

versions
git=2.7.4 maven=3.3.9

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
31
Docker mode activated.

_ Prechecks _

+1
dupname
1
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

_ trunk Compile Tests _

+1
mvninstall
487
trunk passed

+1
mvnsite
0
trunk passed

+1
shadedclient
1277
branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1
mvninstall
435
the patch passed

+1
mvnsite
0
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
684
patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1
asflicense
52
The patch does not generate ASF License warnings.

2650

Subsystem
Report/Notes

Docker
Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1031/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1031

Optional Tests
dupname asflicense mvnsite

uname
Linux dcd3b984503a 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / f02b0e1

Max. process+thread count
411 (vs. ulimit of 5500)

modules
C: hadoop-hdds/docs U: hadoop-hdds/docs

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1031/2/console

versions
git=2.7.4 maven=3.3.9

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@dineshchitlangia  Thanks for the contribution. I have committed this patch to the trunk.

Ohh I see it got committed by the time I have posted it.

authors: anuengineer bharatviswa504 dineshchitlangia hadoop-yetus

repo: apache/hadoop


text:
HBASE-26005 Update ref guide about the EOL for 2.2.x

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  4s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

_ Patch Compile Tests _

_ Other Tests _

2m 17s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3388/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/3388

Optional Tests

uname
Linux 4dffc0c72b12 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 8f618a0846

Max. process+thread count
56 (vs. ulimit of 30000)

modules
C: . U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3388/1/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 34s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

_ Patch Compile Tests _

_ Other Tests _

2m 48s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3388/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/3388

Optional Tests

uname
Linux 1be8f4e80fa4 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 8f618a0846

Max. process+thread count
47 (vs. ulimit of 30000)

modules
C: . U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3388/1/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  5s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+1 :green_heart:
mvninstall
4m 18s
master passed

+1 :green_heart:
mvnsite
10m  0s
master passed

+0 :ok:
refguide
3m 41s
branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
4m  1s
the patch passed

+1 :green_heart:
mvnsite
9m 47s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m  1s
The patch has no ill-formed XML file.

+0 :ok:
refguide
3m 47s
patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

_ Other Tests _

+1 :green_heart:
asflicense
0m 12s
The patch does not generate ASF License warnings.

38m 30s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3388/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/3388

Optional Tests
dupname asflicense refguide mvnsite xml

uname
Linux e2ae983fff48 4.15.0-142-generic #146-Ubuntu SMP Tue Apr 13 01:11:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 8f618a0846

refguide
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3388/1/artifact/yetus-general-check/output/branch-site/book.html

refguide
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3388/1/artifact/yetus-general-check/output/patch-site/book.html

Max. process+thread count
79 (vs. ulimit of 30000)

modules
C: . U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3388/1/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 28s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

_ Patch Compile Tests _

_ Other Tests _

1m 40s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3388/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/3388

Optional Tests

uname
Linux 51352278d460 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 8f618a0846

Max. process+thread count
47 (vs. ulimit of 30000)

modules
C: . U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3388/2/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  5s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

_ Patch Compile Tests _

_ Other Tests _

2m 17s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3388/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/3388

Optional Tests

uname
Linux 49f156c86880 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 8f618a0846

Max. process+thread count
56 (vs. ulimit of 30000)

modules
C: . U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3388/2/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  7s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s
No case conflicting files found.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+1 :green_heart:
mvninstall
4m 19s
master passed

+1 :green_heart:
mvnsite
9m 53s
master passed

+0 :ok:
refguide
3m 45s
branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
4m  2s
the patch passed

+1 :green_heart:
mvnsite
9m 49s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m  1s
The patch has no ill-formed XML file.

+0 :ok:
refguide
3m 46s
patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

_ Other Tests _

+1 :green_heart:
asflicense
0m 13s
The patch does not generate ASF License warnings.

38m 32s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3388/2/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/3388

Optional Tests
dupname asflicense refguide mvnsite xml

uname
Linux 6a087ce7a907 4.15.0-142-generic #146-Ubuntu SMP Tue Apr 13 01:11:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 8f618a0846

refguide
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3388/2/artifact/yetus-general-check/output/branch-site/book.html

refguide
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3388/2/artifact/yetus-general-check/output/patch-site/book.html

Max. process+thread count
79 (vs. ulimit of 30000)

modules
C: . U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3388/2/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 27s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

_ Patch Compile Tests _

_ Other Tests _

1m 35s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3388/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/3388

Optional Tests

uname
Linux 78363b8e2588 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 8f618a0846

Max. process+thread count
46 (vs. ulimit of 30000)

modules
C: . U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3388/3/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 28s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

_ Patch Compile Tests _

_ Other Tests _

1m 44s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3388/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/3388

Optional Tests

uname
Linux 7af5df5c30e7 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 8f618a0846

Max. process+thread count
54 (vs. ulimit of 30000)

modules
C: . U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3388/3/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  6s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+1 :green_heart:
mvninstall
4m  3s
master passed

+1 :green_heart:
mvnsite
9m 47s
master passed

+0 :ok:
refguide
3m 42s
branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
4m  3s
the patch passed

+1 :green_heart:
mvnsite
9m 52s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m  2s
The patch has no ill-formed XML file.

+0 :ok:
refguide
3m 43s
patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

_ Other Tests _

+1 :green_heart:
asflicense
0m 10s
The patch does not generate ASF License warnings.

38m  3s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3388/3/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/3388

Optional Tests
dupname asflicense refguide mvnsite xml

uname
Linux 3b3928de7bcc 4.15.0-142-generic #146-Ubuntu SMP Tue Apr 13 01:11:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 8f618a0846

refguide
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3388/3/artifact/yetus-general-check/output/branch-site/book.html

refguide
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3388/3/artifact/yetus-general-check/output/patch-site/book.html

Max. process+thread count
78 (vs. ulimit of 30000)

modules
C: . U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3388/3/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Seems the tables in the newly generated ref guide are broken? @GeorryHuang
PTAL.
Thanks.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 28s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

_ Patch Compile Tests _

_ Other Tests _

1m 18s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3388/4/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/3388

Optional Tests

uname
Linux 6223332336da 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 555f8b461f

Max. process+thread count
46 (vs. ulimit of 30000)

modules
C: . U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3388/4/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  4s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

_ Patch Compile Tests _

_ Other Tests _

1m 56s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3388/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/3388

Optional Tests

uname
Linux e60e69e8319f 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 555f8b461f

Max. process+thread count
45 (vs. ulimit of 30000)

modules
C: . U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3388/4/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 26s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+1 :green_heart:
mvninstall
4m  0s
master passed

+1 :green_heart:
mvnsite
8m 59s
master passed

+0 :ok:
refguide
3m 32s
branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m 38s
the patch passed

+1 :green_heart:
mvnsite
8m 41s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m  1s
The patch has no ill-formed XML file.

+0 :ok:
refguide
3m 26s
patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

_ Other Tests _

+1 :green_heart:
asflicense
0m 13s
The patch does not generate ASF License warnings.

34m 20s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3388/4/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/3388

Optional Tests
dupname asflicense refguide mvnsite xml

uname
Linux 308cd2c511b8 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 555f8b461f

refguide
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3388/4/artifact/yetus-general-check/output/branch-site/book.html

refguide
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3388/4/artifact/yetus-general-check/output/patch-site/book.html

Max. process+thread count
89 (vs. ulimit of 30000)

modules
C: . U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3388/4/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Have fixed it!

The hadoop support matrix is still broken? I can just see an empty table...

Oh, seems something wrong with the jenkins website, the table in the original ref guide is also empty. Let me merge.

The hadoop support matrix is still broken? I can just see an empty table...

Forgot to check my emails and missed this comment. Thanks for reviewing

authors: Apache-HBase Apache9 GeorryHuang

repo: apache/hbase


text:
ignite-2382 JDBC drivers improvements

Merged into ignite-1.6 and master branches.

repo: apache/ignite


text:
HAWQ-385. Fix too many ssh connections on master and standby

+1

I'm testing this patch on 40 nodes cluster.

Successfully initialize a 40 nodes cluster in 2 minutes. Well done @radarwave ! +1.

authors: radarwave wangzw yaoj2

repo: apache/incubator-hawq


text:
Add picture for sharding-scaling document

Codecov Report

Merging #4912 into master will not change coverage by %.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #4912   +/-   ##
=========================================
  Coverage     54.53%   54.53%
  Complexity      441      441
=========================================
  Files          1137     1137
  Lines         20455    20455
  Branches       3759     3759
=========================================
  Hits          11155    11155
  Misses         8593     8593
  Partials        707      707

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fac29f5...dca61cc. Read the comment docs.

Pull Request Test Coverage Report for Build 10518

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 58.049%

Totals

Change from base Build 10515:
0.0%

Covered Lines:
11874

Relevant Lines:
20455

💛  - Coveralls

authors: KomachiSion codecov-io coveralls

repo: apache/incubator-shardingsphere


text:
Update ui

Coverage increased (+0.1%) to 12.29% when pulling a2621d0738e069e9fc7b4ca656bd00b04572d170 on submodule/ui into 2dd4f54957cdb8c78a4584e01b851b267d7cb625 on master.

authors: coveralls hanahmily

repo: apache/incubator-skywalking


text:
[SQL][MINOR] Fix one little mismatched comment according to the codes in interface.scala

Can one of the admins verify this patch?

Jenkins, test this please.

Test build #2405 has started for PR 10824 at commit 276ff4f.

LGTM.

Test build #2405 has finished for PR 10824 at commit 276ff4f.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Thanks - I've merged this.

@rxin Thanks for the prompt reviewing & merging. :-)

authors: AmplabJenkins SparkQA proflin rxin

repo: apache/spark


text:
[5.1] build-script-impl: do not copy the darwin compiler-rt builtin archives when using --build-llvm 0

@swift-ci please smoke test

@swift-ci please test

Build failed
Swift Test Linux Platform
Git Sha - 7e7f964f7511b9a88d0c5f35d71396fa8ec7513b

@swift-ci please test Linux

authors: hyp swift-ci

repo: apple/swift


text:
Identify and fix the flaky test cases

Following tests are identified as flaky tests.
Smoke_TestSuite/ClientSideTests/Binding/Bind_InputWidget_Table_Sorting_spec.js
Smoke_TestSuite/ClientSideTests/ApiPaneTests/API_Unique_name_spec.js
Smoke_TestSuite/ClientSideTests/Binding/Bind_API_with_List_Widget_spec.js
Smoke_TestSuite/ClientSideTests/Binding/Bind_TableTextPagination_spec.js
Smoke_TestSuite/ServerSideTests/OrganisationTests/CreateOrgTests_spec.js
Smoke_TestSuite/ClientSideTests/GlobalSearch/GlobalSearch_spec.js
Smoke_TestSuite/ClientSideTests/Binding/aTobAndbToaBasictest_spec.js
Smoke_TestSuite/ClientSideTests/Binding/loadashBasictest_spec.js
Smoke_TestSuite/ClientSideTests/Binding/momentBasictest_spec.js
Smoke_TestSuite/ServerSideTests/QueryPane/AddWidget_spec.js
Smoke_TestSuite/ClientSideTests/ActionExecution/ExecutionParams_spec.js

authors: arslanhaiderbuttar yatinappsmith

repo: appsmithorg/appsmith


text:
Streaming cursor API stops lying about hasMore

The failure in jenkins is unreleated

authors: goedderz mchacki

repo: arangodb/arangodb


text:
Added link to community meetings

Merged

repo: argoproj/argo


text:
[WIP] Add RGB <=> YCbCr conversion.

I fixed all you said.
However, I'm sure that mypy still returns errors, because the build logs indicate that the errors is in the codes I don't modified.

I noticed why it doesn't pass.
I wrote static tests in value range [0, 1], but there is adding 128 for cb and cr channel, my bad.
Is there any manner to specify value range?

@S-aiueo32 if the range values are well stated in the docs (which I think they are) it shouldn't be a problem. For consistency can we keep it in 0/1 ?

@S-aiueo32 from where did you get the expected results ? did you compute by hand or from opencv ?

From opencv.
data = np.array([[[255, 0, 0],
                  [255, 0, 0],
                  [255, 0, 0]],

                 [[0, 255, 0],
                  [0, 255, 0],
                  [0, 255, 0]],

                 [[0, 0, 255],
                  [0, 0, 255],
                  [0, 0, 255]]], dtype='uint8')
data = np.transpose(data, [1, 2, 0])

cv2_ycbcr = cv2.cvtColor(data, cv2.COLOR_RGB2YCrCb)
cr = cv2_ycbcr[:,:,1].copy()
cb = cv2_ycbcr[:,:,2].copy()
cv2_ycbcr[:,:,1], cv2_ycbcr[:,:,2] = cb, cr
cv2_ycbcr = np.transpose(cv2_ycbcr, [2, 0, 1])

@edgarriba @ducha-aiki
Thank you for reviewing.
I'm sorry about not doing anything about this PR.
The rejection from CI is caused by rounding errors.
I have to edit the test script to pass all checks but I don't know the acceptable error range you want.
Any suggestion?

@S-aiueo32 I will take a look today and will merge it. What other features do you have in mind to implement. Maybe we can help.

@S-aiueo32 I did a small refactor and a quick test. From where did you get the test data/expected ? I see that there are several implementations of this algorithm in different libraries (opencv, pil, etc)
@ducha-aiki any suggestions ?

@ananyamukh6 could you take a look at this ?

closing this in favor of https://github.com/kornia/kornia/pull/345

repo: arraiyopensource/kornia


text:
Remove Folio EULA on the next deploy

This is done.

repo: artsy/energy


text:
Fix Wiki link

Yeah, I forgot to fix it. Anyway we don't have a decent wiki yet

repo: asc-community/AngouriMath


text:
add-permanent-notation to function-scope

Deploy preview for js-primer ready!
Built with commit 94fcdbbaf31db56a154d4276fb6d625a4e4dada7
https://deploy-preview-403--js-primer.netlify.com

repo: asciidwango/js-primer


text:
Add configuration package reference because Logging dropped it

:up::date:

Merging to unblock the build

repo: aspnet/EntityFramework


text:
Add serviceable attribute to projects.

:shipit:

:shipit:

authors: Eilon NTaylorMullen pranavkm

repo: aspnet/Mvc


text:
Add filters on admin grid

@VincentMarmiesse Just noticed this one -- what's the intended behavior in the UI?  I'd like ot make sure this does what its supposed to before merging (description? Screenshots? Both?)

It adds the filters button on the admin grid:

authors: VincentMarmiesse astorm

repo: astorm/pestle


text:
Add responsive grid-padding-* classes to _grid.scss

Completed.

repo: asyncdesign/webui


text:
Automatically extracting scores from package_analysis on PR

Amazing!

authors: axel-op creativecreatorormaybenot


text:
Email

 work on email re-direct after change, and showing change or not change confirmation


text:
create and fix favicon

Transparent favicon is preferable.

repo: baby-degu/portal


text:
Add read/write speed limit

小功能，求过

build

repo: baidu/bfs


text:
Fixed PR #4277

"PR" stands for "Pull Request"; #4277 is not a pull request.
You're missing a changelog entry.
You're missing a basic description here, similarly to half of your pull requests in the past.
You've opened a separate PR in #4377 for what is essentially the same thing as here (and also lacks a changelog entry and doesn't follow our styleguide).

This may be a dick move, but I'm closing both of these - make an effort please.

authors: bjjay narfbg

repo: bcit-ci/CodeIgniter


text:
Move repos to the seabird-irc org

Not worth it right now. If more people actually end up working on this, I'll reopen this, but it's a super low priority.

repo: belak/seabird


text:
updated jasimine-headless-webkit for qt4.8

Hi, i wanna join to this project :)
Regards

repo: beliarbts/call-center


text:
Custom emotes are at the bottom of the emoji picker,  I want them at the top

i tried setting the include prop on emoji-mart, but the thing is, I think they have a bug in the package where it doesn't pickup the custom element in the include array. it accepts all other categories.

we might need to fork/pr then

yeah, I'll see what I can do

We got custom emote picker @ kibbeh now

authors: ajmnz benawad nadirabbas

repo: benawad/dogehouse


text:
Linear modeling and other tests

LGTM

authors: AlonDaks jodreen


text:
add extension for Junit5

fixed in #2

repo: bertramn/mongodb-junit-test


text:
Develop

15 ноября2015


text:
fixed focus for select inputs

Thanks!

authors: bevacqua nickdecorte

repo: bevacqua/dragula


text:
Improve README and keywords

👍🏻👍🏻

authors: bgentry villander

repo: bgentry/ember-apollo-client


text:
Added Heap Sort

Hi, can you add "hacktoberfest-accepted" label to my PR?


text:
Dev chri

Too much work code is the same in both repos dev_chri will be killed after dev


text:
Fix top-level function's argument passthrough interface to model methods

Current coverage is 90.27% (diff: 100%)

Merging #20 into master will decrease coverage by 0.15%

@@             master        #20   diff @@
==========================================
  Files             8          8
  Lines           188        185     -3
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
- Hits            170        167     -3
  Misses           18         18
  Partials          0          0

Powered by Codecov. Last update 2ae7650...0921062

authors: codecov-io sohkai

repo: bigchaindb/pycoalaip


text:
docker doc fixes

Coverage remained the same at 80.108% when pulling 91b8c6166b62b340ef1cfc12bbf45e5fd0d6c9d3 on akmorrow13:master into 6665c0cec7694d8d7351ae9bae67a451e2998f36 on bigdatagenomics:master.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/mango-prb/869/
Test PASSed.

authors: AmplabJenkins akmorrow13 coveralls

repo: bigdatagenomics/mango


text:
Replace the logo with a BIMsurfer logo

Added a temporary logo for now

repo: bimserver/BIMsurfer


text:
Pass proper type

Coverage remained the same at 31.721% when pulling 360f79c4cf91ee297ef0e0d8eae6191322a0e3b5 on qingweibinary:qingwei/fix_prop into 659dd4907ac56d7f7b7a3c08110feb61739a1f7e on binary-com:master.

authors: coveralls qingweibinary

repo: binary-com/binary-next-gen


text:
Make UI + pcp use the server-side random id generation + also return ppaste/curl command

done

done

repo: binwiederhier/pcopy


text:
Final project: Morgan Kindel and Julia Burke

Looks good. I strongly encourage you to use pre-existing tools to achieve all of these details. Your project will be creating a pipeline to run all of those tools. Snakemake or Prefect would be two tools that will help you create such a workflow.
See my comment here about working together.
See my comment here about balancing the project goals of ticking off details on the rubric etc.

@jnburke4

Can you guys just leave a comment here about how the merging/merge conflicts went. I'd like to get a sense of how much of time you lost to that.
Also your code is nicely modularized in that it is split into notebooks. If you can make functions out off the some of the code there some easy points there. And some docstrings and assertions (or even tests).

Can you guys just leave a comment here about how the merging/merge conflicts went. I'd like to get a sense of how much of time you lost to that.
Also your code is nicely modularized in that it is split into notebooks. If you can make functions out off the some of the code there some easy points there. And some docstrings and assertions (or even tests).

The merging was surprisingly extremely difficult, I couldn't say how much time we have spent sorting out where to put things but it was many hours. Ultimately, we decided since most of our work was here in this repository, we would post here. We merged some but this was working out better.
We split functions into tests as well, thanks for the suggestions!

Ok good to know thanks. Yea we didn't work through that. There are various strategies to make it easier. It is especially difficult with Jupyter notebooks though.

#superceded by #32

Excellent job. I appreciate the toils with trying to resolve git merge conflicts. I didn't know, otherwise I could have provided some strategies for improving the situation. With that said you still created a nicely organized, modular project, with lots of comments.
Areas for improvement for your future in coding:
References to pre-existing solutions could be better. You use opencv to solve your problem: mentioning this and the reasons for this decision would be useful for others considering reusing your code. Even if "my lab uses it" that's fine but demonstration of awareness of the context to your decision is important
Look at some of the other students' projects regarding testing: adding tests in the tests directory will make any projects far more scalable and maintainable. Especially in a collaborative setting, tests provide sanity to the development process, ensuring that changes introduced do not break previously working functionality.
Python modules should typically define functions and not run them or much other code (besides imports and some general variable declaration).
If you do wish to run the file as an executable too you can wrap that bit of code like this:
__name__ == '__main__':
    filecount()
    create_dict()
    create_template()
    match_images()

You have stored a few too many images in the repository. Ideally you would store this somewhere else. It quickly become unmanageable to work with git if you have such a large size on disk. Solutions include:

Make the data much smaller (often impractical)
storing the images separately on a webserver
storing the data in a git submodule
using git-annex or datalad

Regarding the "package":
In your setup.py file you are missing a comma after the url argument and you should include your dependencies in the install_requires argument (opencv-python, PIL etc)
Overall your attention to python style is good. A notable exception is lines of code that are too long. Moving forward keep an eye on the pep8 style guide to continue to grow in this respect
Well done.


text:
fix: reduced chance of throttling

:tada: This PR is included in version 1.17.15 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

authors: MrsFlux simlu

repo: blackflux/lambda-monitor


text:
WIP

First off, I admit I’m not an expert, so I may be wrong.
But my reasoning was that Bluebird has nice helper functions for filter and map that allow for promises.
http://bluebirdjs.com/docs/api/promise.filter.html
This is also why functions is wrapped in Promise.all() to get the bluebird version of that filter and map functions.

Ah, I see. I think that the benefits of the promise filter helper method come from it predating ecma 6 type promise chaining. As the language stands at the moment, I don't know that I see a benefit to using
const Promise = require('bluebird');

Promise.filter(
  functions.map(f => cloudWatchLogs.(...).promise(),
  filterFn
)
  .then(...)

over
Promise.all(functions.map(f => cloudWatchLogs.(...).promise())
  .then(res => res.filter(filterFn))
  .then(...)

In fact, after writing it out, I think I prefer the chained filtering as it's much clearer that the filtering happens on the resolved promises, something that wasn't immediately clear to me until reading the documentation.

authors: MacMcIrish iDVB


text:
banish submodules, update gitignore

Approved- submodules don't really do much for us

repo: blue-dot-consortium/blue-dot


text:
Fix typos in README

Thanks a lot!

authors: LucianBuzzo boltgolt

repo: boltgolt/howdy


text:
Update to Kotlin 1.4

I tried an upgrade to 1.4.0. Got these build errors in bootique-kotlin-config:
[ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.093 s <<< FAILURE! - in io.bootique.kotlin.config.KotlinScriptCompilerTest
[ERROR] execute simple script config file  Time elapsed: 0.093 s  <<< ERROR!
java.lang.NoClassDefFoundError: org/jetbrains/kotlin/scripting/compiler/plugin/repl/GenericReplCompiler
	at io.bootique.kotlin.config.KotlinScriptCompilerTest.execute simple script config file(KotlinScriptCompilerTest.kt:36)
Caused by: java.lang.ClassNotFoundException: org.jetbrains.kotlin.scripting.compiler.plugin.repl.GenericReplCompiler
	at io.bootique.kotlin.config.KotlinScriptCompilerTest.execute simple script config file(KotlinScriptCompilerTest.kt:36)

This is expected, Scripting reworked in 1.4.0 and now it's benefits closer integration with Intellij Idea, Default Imports, Narrow Classpath, etc. I'm working on update

authors: IRus andrus

repo: bootique/bootique-kotlin


text:
Change figure colors - GCB

Did this, but feel free to rework if you don't like new Figure 2. Thanks.

Thanks, I'll just change the range to cut off the yellow colors

I've made you an editor on the manuscript doc, so feel free to drop in new figure(s) when you're happy. Thanks!

repo: bpbond/cosore


text:
Added editing support for dataset page

I think we can replace this line

tags = tags.replace(/^[ \t]+/g, '').replace(/,[ \t]+/g, ',');
with something like..
tags.split(",").map(s=>s.trim());

For the (put)/dataset API, since we should only update those 3 parameters, I would simplify it to only set those 3 on the model record.

authors: soichih stevengeeky

repo: brain-life/core-warehouse


text:
add badges

Badges added in commits fc3bdc0 and 5d9fab6

Badges added in commits fc3bdc0 and 5d9fab6

repo: brazil-data-cube/sits-docker


text:
Closes #428; Adding a 'one_space_or_newline' style for SpaceAfterPropertyColon

Merged in f080325 with a fix to get the build passing in 9c27792.

authors: sds srawlins

repo: brigade/scss-lint


text:
chore(package): keep the fixed version of sync-request

Coverage remained the same at 82.839% when pulling 56bdc11c8af702861b058801a4c3ab5d04b15dc0 on helio-frota:pr into 5e34b174dcd887a254066652d923a07707a16d02 on bucharest-gold:master.

authors: coveralls helio-frota

repo: bucharest-gold/license-reporter


text:
Create sequence diagram

https://drive.google.com/a/bw-sw.com/file/d/1xlCLYnW-vipPH_ptw4VjMKOcjturVB9V/view?usp=sharing

authors: Krisilda MedvedevBW

repo: bwsw/cs-orm


text:
comment block

Done.


text:
fix issue #535, missing other consultations in PDF

Fixed with PR #589

repo: canada-ca/aia-eia-js


text:
Complete image prefetch

Hi! I would love to try to implement this. Any advice on a good place to get started?

Hi @hmerzin , thank you for your support.
Please checkout   GiphyPickerCollectionViewPrefetcher.swift  there is a function name prefetchURLs you can start from there.

Great, thanks!

I implemented the prefetched using SDWebimagePrefetcher and gave it an SDWebImageManager with GiphyPicker->sharedImageCache as well as an SDWebImageDownloader that does not currently have any options associated with it. Is there any chance you might be able to recommend a strategy for testing this?

Based on your needs you can use:
For sync operations:
GiphyPicker.sharedImageCache.diskImageDataExists(withKey: <#T##String?#>)
For async operations:
 GiphyPicker.sharedImageCache.diskImageExists(withKey: <#T##String?#>, completion: <#T##SDImageCacheCheckCompletionBlock?##SDImageCacheCheckCompletionBlock?##(Bool) -> Void#>)

authors: candotti hmerzin

repo: candotti/GiphyPicker


text:
fix: lock again

:tada: This PR is included in version 0.109.18 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

authors: adlerhurst fforootd

repo: caos/zitadel


text:
Update Hear to 1.2.4

Thank you for the contribution. It was merged directly as 19f3ae6692e6f8911ea579f58a36323e19461aee to keep commit history cleaner. Your contribution is still credited to you.

authors: buo victorpopkov

repo: caskroom/homebrew-cask


text:
Updated qlcolorcode (2.0.4)

Hi @tsparber and @jawshooah, could you update the cask to the latest version of qlcolorcode please?

authors: anthonygelibert tsparber


text:
Add homework 1

Hello @artek0chumak! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file homework_1/micrograd/engine.py:

Line 14:80: E501 line too long (88 > 79 characters)
Line 30:14: E261 at least two spaces before inline comment
Line 35:9: E112 expected an indented block
Line 43:14: E261 at least two spaces before inline comment
Line 48:9: E112 expected an indented block
Line 53:14: E261 at least two spaces before inline comment
Line 56:25: E261 at least two spaces before inline comment
Line 62:14: E261 at least two spaces before inline comment
Line 65:25: E261 at least two spaces before inline comment
Line 86:80: E501 line too long (80 > 79 characters)
Line 148:15: E261 at least two spaces before inline comment
Line 149:1: W293 blank line contains whitespace
Line 151:15: E261 at least two spaces before inline comment
Line 152:1: W293 blank line contains whitespace
Line 154:15: E261 at least two spaces before inline comment
Line 155:1: W293 blank line contains whitespace
Line 157:15: E261 at least two spaces before inline comment
Line 158:1: W293 blank line contains whitespace
Line 160:15: E261 at least two spaces before inline comment
Line 177:15: E261 at least two spaces before inline comment
Line 180:20: E261 at least two spaces before inline comment

In the file homework_1/micrograd/mnist.py:

Line 7:8: E225 missing whitespace around operator
Line 7:80: E501 line too long (89 > 79 characters)
Line 9:1: E302 expected 2 blank lines, found 1
Line 63:5: E303 too many blank lines (2)

In the file homework_1/micrograd/nn.py:

Line 26:80: E501 line too long (92 > 79 characters)
Line 30:80: E501 line too long (96 > 79 characters)

repo: catalyst-team/dl-course


text:
Mac build fixes

ping

@cbranch can you merge this?

repo: cbranch/smoltcp


text:
Improve error messages

Add more information to stacktrace, something like:
https://github.com/riganti/dotvvm/pull/494

repo: cezarypiatek/Tellurium


text:
Not working in http://techbus.safaribooksonline.com/

I don't have access to http://techbus.safaribooksonline.com/, what is this site for?

This the old site for safari books online. I'm just thinking if this can be added to your code..
On Oct 22, 2016 5:36 AM, Di notifications@github.com wrote:
I don't have access to http://techbus.safaribooksonline.com/, what is this site for?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/chenditc/safari-download/issues/3#issuecomment-255471236, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AV3bJcq8vDTJqOkPsK0MNm367p8UhJIKks5q2TBggaJpZM4Kan8O.

Oh... ok. For now, this tool fits all my needs, so I don't realy want to dig into old site that might get retired sometime in the future.
Sent from my iPhone

On Oct 25, 2016, at 14:54, jhomzki notifications@github.com wrote:
This the old site for safari books online. I'm just thinking if this can be added to your code..
On Oct 22, 2016 5:36 AM, Di notifications@github.com wrote:
I don't have access to http://techbus.safaribooksonline.com/, what is this site for?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/chenditc/safari-download/issues/3#issuecomment-255471236, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AV3bJcq8vDTJqOkPsK0MNm367p8UhJIKks5q2TBggaJpZM4Kan8O.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

http://techbus.safaribooksonline.com/  is not an old but a subsidiary part of safaribooksonline, its mostly used by corporate employees who gets access to safaribooks via their organisation. I tried adding this to your code, but it didn't work, maybe I'm doing something wrong. Can you please guide me where can I make changes to get this extension working on techbus domain. Million thanks from all those who are waiting for your response.

I agree with Lawilap, it would be really helpful if you could add in support for techbus.safaribooksonline.com because it's a huge part of safari

proquest.safaribooksonline.com would be also nice as it is used by universities.

does it work for ezproxy url?

I can't seem to get the extension to work via "proquest.safaribooksonline.com"

Only standard "www.safaribooksonline.com" is supported. You are welcome to fork this repo and support your own need.

authors: GitHubSouceCodeAdmin chenditc gylns jhomzki lawilap multiflexi watsoncl

repo: chenditc/safari-download


text:
fix busybox image from env

signed

repo: cilium/cilium-etcd-operator


text:
Release/v4.0.6 alpha.1

Before merging this in, could you do a quick rebase with master (Just gets a security fix in too)

authors: davidsauntson luke-hill

repo: citizensadvice/design-system


text:
Log marathon api requests

Coverage decreased (-0.5%) to 80.783% when pulling bd86407bbb068d09fd8038f29b91a9aeb6e246f8 on feature/log-marathon-requests into 64be0d024dd3667f442c3584a6fce68afb04b16c on master.

authors: ckaznocha coveralls

repo: ckaznocha/marathon-resource


text:
Disable public endpoints on cluster

Fixed in cloud-native-toolkit/terraform-ibm-ocp-vpc#v1.0.0


text:
Deprecating nginx-google-oauth in favor of Cloudflare Access

@dhaynespls for review

repo: cloudflare/nginx-google-oauth


text:
The bosh login step is automatically kicked off during bosh target  lite

Updated.

authors: cppforlife sharms

repo: cloudfoundry/bosh-lite


text:
Add listing usage events to permissions table

Thanks, @Gerg !

authors: Gerg animatedmax

repo: cloudfoundry/docs-cloudfoundry-concepts


text:
refactors VanillaSoftwareProcessLifecycleModifier

Looks good on the whole. Tests? Would also like the class to be renamed to indicate that it specifically handles TOSCA's standard interface.

@robertgmoss Thanks.

authors: robertgmoss sjcorbett

repo: cloudsoft/brooklyn-tosca


text:
Add auto-toolbox

Please provide a description.

See https://github.com/codeddraig/ffau/blob/create_auto_toolbox/README.md line 89

(CTRL+F for 'Here's an example using all Ffau components and three blocks:')

@palkerecsenyi see now

authors: gezakerecsenyi palkerecsenyi

repo: codeddraig/ffau


text:
Wip/mwk/msgpack ext

Could you add tests for int_to_bytes and int_from_bytes? Especially for corner cases like int_from_bytes('').

done

authors: koriakin mkow

repo: codilime/veles


text:
Adds Python implementation for Depth Charge

Thank you!

authors: anson-vandoren coding-horror

repo: coding-horror/basic-computer-games

license: Unlicense


text:
Exceptions caused by processing bad inputs should report line number and simple error message

:+1:

Solved with: 8ec5b71fb3f5d20a43fb23b0b5529e3d4018ae50

authors: comamitc oakmac


text:
remove old UI

おつかれさまでしたー

authors: dadaa nakamurataichi

repo: comozilla/Parapara-Canvas-Editor


text:
возрождение

разместить маркеры в казармах

ломается

ломается

иногда приходится долго ждать

в режиме возрождения сразу на поле боя
при первом подключении, после переключения управления на птицу, игрока убивает скрипт, нужно исправить


text:
0.24.0

Please can we be better about releasing conan and CPT in sync when they become incompatible.
 >> Conan/CPT version mismatch. Conan version installed: 1.13.0 . This version of CPT supports only Conan < 1.12
Traceback (most recent call last):
  File "build.py", line 23, in <module>
    builder.run()
  File "/usr/local/lib/python2.7/site-packages/cpt/packager.py", line 428, in run
    self._check_conan_version()
  File "/usr/local/lib/python2.7/site-packages/cpt/packager.py", line 295, in _check_conan_version
    raise Exception(msg)
Exception: Conan/CPT version mismatch. Conan version installed: 1.13.0 . This version of CPT supports only Conan < 1.12

@lasote Here is the changelog for 0.24.0
Feature: Compatibility with Conan 1.13 (#341)
Feature: Support Shippable CI (#337)
Feature: Support Azure DevOps (#335)
Fix: Use the correct build path to load Conan class (#325)
Fix: Remove extra python requirements (#328)

Hi @brianembry!
Sorry, we have a proper order to release the things. In fact CPT should be released first. However, you could use fixed versions to avoid any possible new bug in the future.

@brianembry that is the way we decided to operate. sorry. We are releasing first Conan and when everything is ready we release the compatible CPT. You should install CPT only in your build scripts to install the correct compatible conan.

Released.

authors: brianembry lasote uilianries

repo: conan-io/conan-package-tools


text:
MNT: Re-rendered with conda-smithy 2.1.1

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

Thanks @lexual. Feel free to add yourself as a maintainer in a subsequent PR.

authors: conda-forge-linter jakirkham lexual


text:
update pins

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

authors: conda-forge-linter ocefpaf

repo: conda-forge/qgis-feedstock


text:
R3.5

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.
I do have some suggestions for making it better though...
For recipe:

Using toolchain directly in this manner is deprecated.  Consider using the compilers outlined here.

authors: cbrueffer conda-forge-linter

repo: conda-forge/r-diptest-feedstock


text:
Fixed README example

Oh, I meant to just have this be the README fix, but I guess when I push to master, those commits get included too.  I think having Mapper classes have access to all entries opens some possibilities like the back-reference mapper that I've included.

Hey, could you clean up the PR and maybe add the code as an example. This could also be stored in a /examples folder or so. What do you think @madtrick

I'll open separate pull requests for each of these commits.

authors: nijotz pxlpnk


text:
rkt/containers: introduce a general api to the container dirs

This PR is missing tests for containerHandle, please add those.

I'll add tests shortly, just want feedback on the overall approach.
Regarding the bitmask for selecting which containers to include (garbage vs. non-garbage vs. everything); I don't find it particularly clever/unreadable, but I'm a C programmer.  I've thrown in the rkt list implementation to show the other use case (where all containers are included).  If nobody likes the bitmasks we can change it, but the alternatives strike me as more annoying/cumbersome and repetitious.
This incarnation of containers.go dispenses with getContainerHandles() altogether, switching to an iterator interface so we don't unnecessarily open so many locks simultaneously (RLIMIT_NOFILE concerns) and the callers don't need to concern themselves with iterating and handle-freeing.

I like the iterator interface much better.

I am also not a huge fan of the mask approach. Right now I think withContainerHandles is a bit broken because getContainerHandle will happily/erroneously return a (non)garbage collected container irrespective of what is actually being requested, and then withContainerHandles doesn't check for this. Makes me feel it could be refactored to deal with this a bit more cleanly.

... sorry, that sounds a bit whiny. I do think this is on the right track :-)

@jonboulle have a look at the latest.

I think there's another issue with uuids possibly appearing in both lists for the includeContainers|includeGarbage aggregate case from when a uuid migrates during the operation.

Most recent fixes the mistake @eyakubovich pointed out as well as changing getContainers() to unique-ify the returned list of uuids.  We need to either tolerate the possibility of containers moving to the garbage simultaneously or introduce another lock, lockless approach seems reasonable so far.

@vcaputo where are we on this? looks like it needs a rebase at least

@jonboulle yep, rebased

LGTM

authors: crawford jonboulle kelseyhightower vcaputo

repo: coreos/rocket


text:
[core] make mpp::event_emitter type-safe

see #15

authors: imkiva mikecovlee

repo: covariant-institute/mozart


text:
Remove as many grid lines as possible, especially vertical ones

the pr for #14 slightly addresses this

the highcharts chart has a lot less lines closing for now

repo: covid-projections/covid-projections


text:
[GPoS] Enable random validator selection in the later stage of main network

close it for now.

repo: crustio/crust


text:
refactor GlobalDefaultExceptionHandler a little bit

Codecov Report

Merging #1232 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

@@             Coverage Diff              @@
##             master    #1232      +/-   ##
============================================
- Coverage     49.04%   49.02%   -0.02%
- Complexity     1701     1702       +1
============================================
  Files           366      366
  Lines         10277    10277
  Branches       1043     1043
============================================
- Hits           5040     5038       -2
- Misses         4864     4868       +4
+ Partials        373      371       -2

Impacted Files
Coverage Δ
Complexity Δ

...mmon/controller/GlobalDefaultExceptionHandler.java
0% <0%> (ø)
0 <0> (ø)
:arrow_down:

...lo/configservice/util/InstanceConfigAuditUtil.java
70.17% <0%> (-5.27%)
13% <0%> (-2%)

.../apollo/internals/RemoteConfigLongPollService.java
77.91% <0%> (+1.22%)
28% <0%> (+1%)
:arrow_up:

...ervice/service/ReleaseMessageServiceWithCache.java
86.9% <0%> (+2.38%)
25% <0%> (+2%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3963822...4cfbf1e. Read the comment docs.

Coverage decreased (-0.04%) to 52.632% when pulling 4cfbf1ed1dfc5f5ce4bf0e9fb012525d2a85bfd4 on nobodyiam:master into 39638224a92c292a821bf7f91df6986d26cbcf44 on ctripcorp:master.

authors: codecov-io coveralls nobodyiam

repo: ctripcorp/apollo


text:
Criar uma pasta de exemplos de pagedown

Coloquei exemplos que já vem no pacote:

tese
carta
currículo
artigo

authors: azeloc beatrizmilz

repo: curso-r/main-visualizacao


text:
Athos, tudo bem? Estou aqui refazendo todas as aulas. Seria possível vocês criarem uma lista de top 10 dicas apresentadas no curso e também escrever um texto pessoal sobre a utilidade de cada um dos pacotes especiais que vocês mostraram no curso. Por exemplo: o dplyr, serve pra quê, ajuda no quê e porque usar ele. Cumprimentos

lista de exercicios sem duvida seria bem-vinda!
O advanced programming do Hadley é muito advanced, mas o r4ds  acaba sendo muito básico!
Onde encontro exercicios "intermediários" de dplyr?

authors: danielreispereira nosbielcs


text:
Convexity Done

@xiaotinghe  我只是粗略地看了一下，数学表述（特别是术语）可能还得仔细review一下

Can we remove the following if they are unnecessary:

Job d2l-zh/PR-688/2 is complete.
Check the results at http://preview.d2l.ai/d2l-zh/PR-688/

Job d2l-zh/PR-688/1 is complete.
Check the results at http://preview.d2l.ai/d2l-zh/PR-688/

Job d2l-zh/PR-688/3 is complete.
Check the results at http://preview.d2l.ai/d2l-zh/PR-688/

Job d2l-zh/PR-688/4 is complete.
Check the results at http://preview.d2l.ai/d2l-zh/PR-688/

Job d2l-zh/PR-688/5 is complete.
Check the results at http://preview.d2l.ai/d2l-zh/PR-688/

Job d2l-zh/PR-688/6 is complete.
Check the results at http://preview.d2l.ai/d2l-zh/PR-688/

Job d2l-zh/PR-688/7 is complete.
Check the results at http://preview.d2l.ai/d2l-zh/PR-688/

Job d2l-zh/PR-688/8 is complete.
Check the results at http://preview.d2l.ai/d2l-zh/PR-688/

Job d2l-zh/PR-688/9 is complete.
Check the results at http://preview.d2l.ai/d2l-zh/PR-688/

Job d2l-zh/PR-688/10 is complete.
Check the results at http://preview.d2l.ai/d2l-zh/PR-688/

Job d2l-zh/PR-688/13 is complete.
Check the results at http://preview.d2l.ai/d2l-zh/PR-688/

@xiaotinghe could you take a look? Thanks!

authors: astonzhang goldmermaid mli


text:
[Don't merge]Just Build PDF[PyTorch]

Job d2l-zh/PR-715/1 is complete.
Check the results at http://preview.d2l.ai/d2l-zh/PR-715/

d2lbook build pdf --tab PyTorch is not working now.

Job d2l-zh/PR-715/2 is complete.
Check the results at http://preview.d2l.ai/d2l-zh/PR-715/

Still MXnet version...
http://preview.d2l.ai/d2l-zh/PR-715/d2l-zh.pdf

any master have the pytorch version?

authors: GreenTeaHua StevenJokess mli


text:
Add graph serialization to n-quads

Coverage increased (+0.02%) to 90.973% when pulling b6c707020a82ddfca85f216badc0bb99be0f1128 on improve-graph-api into d041329f7d8216eb78618d79b6b791a040c95f69 on master.

authors: coveralls dan-f

repo: dan-f/twinql


text:
Upgraded to support React Native 0.26.0 and above.

Covered by #111

authors: maranbomater tomauty

repo: dancormier/react-native-swipeout


text:
Refactor codes for event trace

Changes Unknown when pulling 8fcac75a4fd5e973580e489c8a1535da1fee5b55 on Zhangxinguo:2.0.6 into ** on dangdangdotcom:2.0.6**.

Changes Unknown when pulling 8fcac75a4fd5e973580e489c8a1535da1fee5b55 on Zhangxinguo:2.0.6 into ** on dangdangdotcom:2.0.6**.

authors: Zhangxinguo coveralls

repo: dangdangdotcom/elastic-job


text:
New modifications in scripts and others.

outdated

authors: PrikhodkoStanislav danilaml

repo: danilaml/qreal


text:
Fix crash in UpdatePreferredDownload

Closed in favor of 1389.

repo: dashpay/dash


text:
Chart refactor

supersedes and closes #4


text:
Add microsoft AppCenter

this is a big win for the swift community. Glad MS finally got around to adding SPM support.

🚀🎉 Thanks!

authors: BrentMifsud daveverwer

repo: daveverwer/SwiftPMLibrary


text:
Added documentation for systemd-resolved

Thanks @alinalexandru

authors: alinalexandru davidalger

repo: davidalger/warden


text:
Issue #792 Fix for react native

What are the main changes between control-component-factory and control-component?

The goal was to not have react-dom required/imported when using the native versions. Therefore I extracted the factory into another module so that could be used via native.js but then kept the original component-control module for backwards compatibility.

findDOMNode is now passed in the strategy to the component control factory

authors: davidkpiano peterdivvito

repo: davidkpiano/react-redux-form


text:
how much time does it take you to train a model with 0.919 accuracy on LFW?

It depends on a few factors, e.g. how fast your disk is, how fast the triplet selection can run on the CPU and how fast the training on the GPU is. For me it takes roughly 72 hours to train for 500 000 steps with triplet loss and the nn4 model.

@davidsandberg thank you very much.

authors: ZHAIXINGZHAIYUE davidsandberg

repo: davidsandberg/facenet


text:
Update fetch_cluster_logs.bash

@mesosphere-mergebot label ready for review

@cprovencher  - This was not getting a ship-it because it was out of date. Updated this.

@mesosphere-mergebot label ship it

@mesosphere-mergebot label ship it

authors: cprovencher orsenthil

repo: dcos/dcos


text:
Fix read preference using pymongo 3+

@dcrosta Did you like this PR?

Hi, did you saw my changes?

Any questions about this PR?

This doesn't fix the read preference provided in URL.

Please see the announcement about Flask-PyMongo 2.0 in #110 -- I believe that that work will obviate the fix here, and will simplify future maintenance of Flask-PyMongo, as you'll just use a URI or keyword arguments to configure PyMongo, without having to have the strange layer in between from Flask-PyMongo.
I'm going to close this to keep things tidy, but thanks for the contribution nonetheless!

authors: computist dcrosta luiscoms

repo: dcrosta/flask-pymongo


text:
DBZ-2413 Added support for MySql8 backup_admin, create role, and drop role privileges

@rgibaiev thanks a lot! In fact I believe the test failure is related, as it's parser failure related to a statement containing the ROLE keyword, and this PR also is touching on this. I suppose your change introduced some kind of ambiguity in the grammar.
Re your question on adding other privilege keywords: the parser need to be able to parse any statement a user might run, so if there's grammar changes needed in order to achieve that, let's do this, there's no way around :)

Closing this PR in favor of a bigger one https://github.com/debezium/debezium/pull/1745

authors: gunnarmorling rgibaiev

repo: debezium/debezium


text:
chore: major bump of node-abort-controller

Thanks! Released in 0.2.6.

authors: aikoven atassis

repo: deeplay-io/abort-controller-x


text:
fix: rollback to tf-1.14.0

Breaks

repo: deepmipt/DeepPavlov


text:
fix(Makefile): build docker image with --no-cache by default

@mboersma it looks like telegraf/versioning.mk and influxdb/versioning.mk also need amendments (only grafana's changed so far)

Good catch--updated now.

authors: mboersma vdice

repo: deis/monitor


text:
can not add multiple ip address?

I was also wondering how to use this with multiple ip addresses, e.g. using the overload IEnumerable<string>.
From this it only seems to be allowed to use simple types as parameter in attributes.
https://stackoverflow.com/a/3192882/1693918
https://github.com/dotnet/csharplang/blob/master/spec/attributes.md#attribute-parameter-types

authors: bjarnef razamemon

repo: dejanstojanovic/IP-Address-Filtering


text:
Add publisher script (Maven Central)

@bartfaitamas I tried to fix all your comments.

repo: digital-asset/lib-daml-jvm-test


text:
Geo distance function

Awesome! Left some small actionable comments and a question. Will merge after the comments are addressed

authors: forest-tong phillipm

repo: dimagi/javarosa


text:
example pr for rabit cache

Hey @chenqin, trying to check out this PR I get the following errors Server does not allow request for unadvertised object:
git fetch origin pull/4636/head:chenqin
remote: Enumerating objects: 25, done.
remote: Counting objects: 100% (25/25), done.
remote: Compressing objects: 100% (2/2), done.
remote: Total 36 (delta 23), reused 24 (delta 23), pack-reused 11
Unpacking objects: 100% (36/36), done.
From https://github.com/dmlc/xgboost
 * [new ref]           refs/pull/4636/head -> chenqin
Fetching submodule dmlc-core
From https://github.com/dmlc/dmlc-core
   d06aceb..f1ff6cc  master     -> origin/master
Fetching submodule rabit
error: Server does not allow request for unadvertised object db343f9394470d63bc2c95551d3beb80f39086c3
error: Server does not allow request for unadvertised object ee234c4bb05422963491cae35f391d1e15d88f29
error: Server does not allow request for unadvertised object ef235c4308f64170d586743c6d0897239a7a55be
error: Server does not allow request for unadvertised object 7186da620fa4897545c34d8b7bb0a40cd8001e65
error: Server does not allow request for unadvertised object f32edca5812b1b5160c15ea2c40034048f5af843

Hey @chenqin, trying to check out this PR I get the following errors Server does not allow request for unadvertised object when checking out rabit:
git fetch origin pull/4636/head:chenqin
remote: Enumerating objects: 25, done.
remote: Counting objects: 100% (25/25), done.
remote: Compressing objects: 100% (2/2), done.
remote: Total 36 (delta 23), reused 24 (delta 23), pack-reused 11
Unpacking objects: 100% (36/36), done.
From https://github.com/dmlc/xgboost
 * [new ref]           refs/pull/4636/head -> chenqin
Fetching submodule dmlc-core
From https://github.com/dmlc/dmlc-core
   d06aceb..f1ff6cc  master     -> origin/master
Fetching submodule rabit
error: Server does not allow request for unadvertised object db343f9394470d63bc2c95551d3beb80f39086c3
error: Server does not allow request for unadvertised object ee234c4bb05422963491cae35f391d1e15d88f29
error: Server does not allow request for unadvertised object ef235c4308f64170d586743c6d0897239a7a55be
error: Server does not allow request for unadvertised object 7186da620fa4897545c34d8b7bb0a40cd8001e65
error: Server does not allow request for unadvertised object f32edca5812b1b5160c15ea2c40034048f5af843

sorry about late reply can you give another try against? https://github.com/chenqin/xgboost/commit/7f5f278b3c87f2fc143db7006cd262e5c9333c8d

I just found this PR may also involve conflict with the issue at https://github.com/dmlc/xgboost/pull/4594 (where more rabit operations are to be added )

I just found this PR may also involve conflict with the issue at #4594 (where more rabit operations are to be added )

Let's review design document first once it's out.

authors: CodingCat chenqin thvasilo

repo: dmlc/xgboost


text:
docs: fix registry link to point to localhost in deploy doc

cc @moxiegirl

nice catch @nubs LGTM

@nubs Thank you for the contribution! Could you please sign the commit?

Signed, thanks!  The contributing docs for docker/distribution don't mention signing commits so I also created #377 to track that.

@nubs Thank you for the addition!

authors: moxiegirl nubs stevvooe

repo: docker/distribution


text:
$cordovaAppRate sets callbacks correctly

Please strip out the /dist files from this commit; as it causes conflicts when we go to build or include other changes.

/dist files removed

authors: gortok pmccloghrylaing

repo: driftyco/ng-cordova


text:
Flow types improvements

Thanks again!

;)

@TrySound I'm just going to give you push rights. I'd appreciate it if you keep making PRs so I can follow what you're doing, but you can merge them yourself. Really appreciate all the work you're doing :)

Cool. Thanks to you for this project.

Btw, @ds300, can you publish beta 1?

Sure.

Do you use npm or yarn? I want to make a lockfile.

I like yarn. It has upgrade-interactive and lockfile merge features.

Ok I'm going to add np for doing publishing and create a yarn.lock. Also I'm going to restrict the linting to the src folder because it errors for >es5 features and you're using some >es5 features in the tests.

There is eslint config in test, which extends root config.

oh. Well it was failing for me. We can sort it out later

Thanks!


text:
Publish should put in top level public

Fixed in https://dblank@bitbucket.org/ipre/calico.git commit 1a2344c


text:
Fix Slide Print Station Name

V 3.04 TEST - fixes workstation name issue not show.

repo: dspencer-mawd/MAWDSlideTracker


text:
I want to see a list of all transactions

Unsure about how to create a method that will fire when the button is clicked

I don't understand what the Label is binding to/ what that binding is used for

How do I make another one of these with resharper? this is a property right?

@dtotino - adding a click event handler for a button is one of those very basic Visual Studio/WPF things you should be able to figure out with a google search or Pluralsight course.
For the label, the Text = ....syntax is doing the same thing as value.bind in Aurelia.  Whether you reference UserName in the code, it will update the label value.  When you update the UI, it will update UserName.
For the property, I normally type in prop (then Tab) to create an auto property.  An auto property just has getter and setter.  This makes it usable by others (for example the databinding in the UI) and allows you to intercept if needed.  In the example above, the get isn't doing anything special and there is no need to.  For the set, we make sure that the new value isn't the same as the old one before moving forward.  Then, we set the new value to the backing field (_userName).  Then, we call OnPropertyChanged.  Anyone who has subscribed to our PropertyChangedEvent (the UI has...this is the way WPF works), will be notified that we made a change.  At this point, the UI will get UserName (which just returns the value of _userName) and update the UI.
A property gives you the ability to do anything.  With WPF, what you see is a very common pattern and becomes monotonous to enter it in all the time.  So, Resharper came up with a quick fix: you can read about it here:

@dukesta3 -- I am trying to figure out how you did the binding for the How Cool Am I part, but I don't remember how or where you started and the steps you took to make the binding happen. After understanding that, I want to try 2-way binding


text:
Format public/data/projects.json

@AliNisarAhmed Thanks again for noticing and fixing these formatting errors.

authors: AliNisarAhmed dwayne

repo: dwayne/builtwithelm


text:
2.0.0

wtf


text:
Test error handler wait

Build status:

Linux
Windows

repo: eProsima/Micro-XRCE-DDS


text:
New proteome xsd code changes

BuscoReport, we may soon add lineageDBcreatedDate
CPDReport, we may change CPD report as well in the near future

i updated proteome_example.xml test data. I think that it will be better to have some roundtrip tests for proteome xml parser

I think that for now proteome domain is good. It is likely that we will need to change proteome and proteome domain in the near future, but not before new website release

It is fine

authors: LeonardoGonzales jieluo321 uniprot

repo: ebi-uniprot/uniprot-core


text:
Add try/catch to pemParser, fixed #106

You have also created a Draft PR which cannot be merged.

Hi @hpragt ,
Thanks for your contribution. However, you are missing the signed-off-by in the commit message (see also https://www.eclipse.org/legal/ECA.php)

I added sign-off to commit message. What can I do now to let you receive the change ?

Hi @hpragt
It seems that the ECA form is not yet signed (linked to the email address you used in the commit). Can you do this?
Thx
Rudy

ECA
Hello, @hpragt, we would like to process your contribution but your ECA  seems to be unsigned.

Make sure you signed it for your email address, see example of my profile:

Open https://accounts.eclipse.org/user and create an account and sign ECA, if that is what you want to do.
Commits
Next, could you squash those commits into 1? e.g.
Either from scratch if you already deleted the repo locally:
$ git clone https://github.com/hpragt/microprofile-starter.git
$ cd microprofile-starter/
$ git remote  add upstream https://github.com/eclipse/microprofile-starter.git
$ git fetch --all
$ git rebase -i upstream/master

pick 7fafaae Add try/catch to pemParser
s a5b60ad Add try/catch to pemParser
# Rebase d5bc85d..873021b onto d5bc85d (2 command(s))

or with something like
git rebase -i HEAD~2
Then edit the commit message so as it is one:
    Add try/catch to pemParser

    Signed-off-by: hpragt <github@pragt.org>

And force push to your remote origin branch:
git push origin 106 --force

The change will appear here on this PR and we can merge it :smiley:
Thank you

@hpragt  ?

Cannot be merged any longer since code is rewritten in #188.

Closing as obsoleted.

authors: Karm hpragt rdebusscher

repo: eclipse/microprofile-starter


text:
Test

Closing this since it was a test

authors: dtip sylvielamythepaut

repo: ecmwf/magics


text:
Feature/testability

:green_heart: Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

Build Cause: Pull request #18 opened

Start Time: 2021-04-02T18:09:33.190+0000

Duration: 5 min 0 sec

Commit: 6c0c880262b9434a2ae611b488ae6d74ef0bd8a8

Trends :test_tube:

authors: apmmachine bryce-b

repo: elastic/apm-agent-ios


text:
Updated Token Names to Follow Token Standard

Coverage decreased (-0.04%) to 91.821% when pulling 746071ad52b094ce444b81bd3e85ade5438d0c0b on paul/tweak/names into 788b9205c541e421cfc43a380485109e6ed6d11f on main.

authors: coveralls pvienhage

repo: element-fi/elf-contracts


text:
Renamed aH to allowedHost

Coverage remained the same at 100.0% when pulling 7dbfedb7c9fb87f0c03b3983bf3c93bdf0dcba6b on ankitjaggi:feature/refactoring into 8ad651555d7f88bb66e526a949c40f1c8200cad7 on elssar:master.

authors: ankitjaggi coveralls

repo: elssar/sails-hook-allowed-hosts


text:
Only one window reparents to root on exit

Doesn't always occur - behaves as expected when run under valgrind

repo: emmamai/makron

license: isc


text:
WIP: Reorder modal

We kan find this pr in the history if ever needed

repo: ems-project/EMSCoreBundle


text:
Remove unnecessary mut in SBDebugger::enable_log.

I'm sorry, I forgot about this. Wouldn't it make sense for things that modify the SBDebugger to require mutability?

In my view, every concept is designed with a purpose. For mutable objects, it signal the programmer the potential pitfalls concerning mutability. For mutable references, it help the compiler to check for data races (concurrent writes to the same object).
In this case, the Rust object is a reference to the internal C++ object. After the invocation, the proxy object written in Rust is not modified, but the internal object that referenced by the proxy must change.
It's more debatable in the scenario of FFI — should we distinguish the mutability between the internal object and the proxy object which is a reference? I prefer to distinguish them and not use "mut". From the point of semantics of "mut", the reference is not altered, thus a "mut" is unnecessary. From the point of utility, the internal object is guarded by LLDB's own lock, thus an additional layer of protection from Rust is unnecessary.

Sounds well thought out. I'll merge!

authors: hghwng waywardmonkeys


text:
Update private.txt

bors r+

repo: eol-uchile/eol-edx


text:
introduce alternative file loader 'run' method

Merging, please add final keyword to all parameters in FileLoader.

authors: epickrram grumpyjames

repo: epickrram/angler


text:
Create Jar based utility of web scraper to extract content easily

@nilsml I have created this task so that it will easy for anyone form the team can run the web scraper from the command line

@nilsml @vnys I have updated the repository with totally new code base which is developed with spring boot and spring batch to easily run utility jar. Please refer to README.md file for more information

repo: equinor/energyvision


text:
Rename envoycp config parameters for consistency

Codecov Report

Merging #21 into master will increase coverage by 0%.
The diff coverage is 0%.

@@          Coverage Diff          @@
##           master    #21   +/-   ##
=====================================
  Coverage       8%     8%
=====================================
  Files          91     91
  Lines        5147   5146    -1
=====================================
  Hits          422    422
+ Misses       4716   4715    -1
  Partials        9      9

Impacted Files
Coverage Δ

cmd/envoycp/config.go
0% <0%> (ø)

cmd/envoycp/route.go
0% <0%> (ø)

cmd/envoycp/xds.go
0% <0%> (ø)

pkg/types/route.go
0% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e425fd...97228ab. Read the comment docs.

authors: codecov-io erikbos

repo: erikbos/gatekeeper


text:
Update to LLVM 3.8 on OS X.

Merge whenever needed.

Will be obsolete by #64.
After #64 you can still use pre-built LLVM available on your platform by explicitly passing its location to cmake:
cmake -DLLVM_DIR=/usr/local/opt/llvm38/lib/llvm-3.8/share/llvm/cmake

Right - so whenever you flip that live by updating the sub-module in libethereum, we're also going to want to look at the Homebrew formula (and maybe at the PPA formula, @chriseth?).   CC @5chdn.

EVMJIT not officially support only LLVM 3.8.
In Homebrew you can use llvm38 (by using -DLLVM_DIR)
In Ubuntu/PPA there is no LLVM 3.8 freely available, so I suggest building from source. You can try backporting from 16.04 or some other tricks, but I don't have time to do it myself.
In any case, please create separated issues if some change is needed.

So you're going to need to commit https://github.com/ethereum/homebrew-ethereum/pull/67, @chfast, at the same time as we update the version of evmjit used in the libethereum sub-module.
It looks like I updated ethdocs.org on May 11th (https://github.com/ethereum/homestead-guide/commit/39f4562adb372065a43682f318d88111d9235402), so we're currently out of sync between docs and build/release flow.   We should just get those re-aligned ASAP.

I think, @chriseth, that will we also need to re-add that unconditional setting of LLVM_DIR in libethereum's cmake files:
if (DEFINED APPLE)
     set(LLVM_DIR "/usr/local/opt/llvm38/lib/llvm-3.8/share/llvm/cmake")
endif()

Without that, it will drop-back to build-from-source for LLVM (which is what I would like to get to), which would then see us remove that LLVM line from Homebrew (because the package doesn't come via brew), but then I think we'll likely be screwed at runtime, because the dylibs won't be there.
Thoughts, @chfast?   Do spawn new issues if you think we need.      Maybe there are 2 things here.    LLVM to 3.8 on OS X, and LLVM-from-source-enabled-on-OS X.

It all depends on your needs. I plan to integrate that soon, we will see what will happen then.

What do you want to do here, @chfast?

It's obsoleted. However we should get builds with LLVM from homebrew.

authors: bobsummerwill chfast

repo: ethereum/evmjit


text:
node.js client

This is great, but the pull request is not mergable. Can you extract the node client and submit another request?

authors: fjakobs kastner

repo: etsy/statsd


text:
Flowify reporters in jest-cli #2

The latest Jest version isn't running correctly for me (no test output) and it bisects to this diff. Not really sure exactly which part of this diff broke it, though. See #1190.

Yep, fixed in https://github.com/facebook/jest/commit/cc58a501756a49378258b0fb1db100252d06d6a1, not published yet (the current version is just an alpha).

repo: facebook/jest


text:
Update run instructions on IOS

@brentvatne I thought the QR code has been removed from iOS?

@charpeni - the Expo client app doesn't have a QR code scanner built in but the iOS Camera app will scan the QR code and open the deep link into the Expo client

authors: RafaelDoering brentvatne charpeni

repo: facebook/react-native-website


text:
Added getLength and getLine methods

It's like Christmas! Only with presents!

repo: faceleg/ACEView


text:
Realtime report builder needs optimization

I used dichotomy method to read data from log files, it works much faster now. In addition, I've create a log of analytic requests to have precise data how much time every request taken (log file is under App_Data folder of analytics site)

repo: fandrei/AppMetrics


text:
bug fix when local file exist

add port support

repo: fanux/sealos


text:
apakah ada API light novel indonesia?

Barusan saya searching belum dapet mas. Mungkin temen-temen yang lain ada yang punya referensinya?

saya dapet API novel cuman pake bahasa inggris
https://github.com/Kevin-Umali/novel-api

Minta bantuannya temen temen ada yang punya rest api tentang nnovel?

nitip

authors: farizdotid mazushishounen nahansans putrilest

repo: farizdotid/DAFTAR-API-LOKAL-INDONESIA


text:
Fix link to blog post and don't say "my"

👍

authors: KrauseFx asfalcone

repo: fastlane/boarding


text:
disposeInternal should be implemented at Framework level, starting from core.Object.

Fixed with https://github.com/fatihacet/spark/compare/b0e9ef6b4fa7c37362d4e643c80cf584d4886c99...b89e2cc70c1bea81e305341a7cab0575b4ff4b01
Introduced destroy method to framework and implemented the core destroy in Object and override it in necessary subclasses like View, DraggableView etc.
Object's destroy will call dispose and disposeInternal of the EventTarget so we are sure that all event listeners will be purged.
View will destroy all child views and it's responsible to unlisten DOM related events. So we are sure that every events bound to View will also be purged.
Some classes like DraggableView, Textarea, Router will also dispose the internal used classes like goog.fx.Dragger, goog.ui.CharCounter etc.
I heavily tested the listener counts before and after destroying a view to make sure we are really unlisten all those events and results were fantastic. Here is the results for Modal and DraggableView.

repo: fatihacet/spark


text:
Add Eslint extractor

Extractor added here: https://github.com/fcsonline/codemonitor/commit/3511e3b7152a054fb38ca792b8dae316524d1fe1

repo: fcsonline/codemonitor


text:
TS26-MedicinePagination

O pull request será aceito, pois cumpre com todos os requisitos necessários.


text:
Use the .log extension for log files instead of .txt

@Jaiganeshkumaran Is there any reason to make this change?

@yaichenbaum The only reason I changed the extension was to make the log file more identifiable for non-technical users.

@Jaiganeshkumaran Unless users are asking for this I don't think there is much of a reason to do it...

authors: Jaiganeshkumaran yaichenbaum

repo: files-community/files-uwp


text:
Added beamer implementation of sign-in-routing scenario

Fixed the merge conflicts here: https://github.com/flutter/uxr/pull/55

authors: johnpryan slovnicki

repo: flutter/uxr


text:
Update forseti_conf.yaml.sample

Adding cla: yes label, as the PR author is a googler at the time of this PR was created.

authors: blueandgold carise

repo: forseti-security/forseti-security


text:
Create workflow

The function the add comment on constante class messed up the value when there is whitespace in it.
ex:
"My constante value"
become
"Myconstantevalue"

The function the add comment on constante class messed up the value when there is whitespace in it.
ex:
"My constante value"
become
"Myconstantevalue"

Fixed

repo: freddycoder/AutoCode


text:
Added network test for CaseQuery functionality

I'm a bit lost what this PR is since it has dozens of commits and the diff is huge. It's really too big for me to review. Can the unique bits be pulled into a fresh PR?

That's weird, it should only have like 2 commits. It's just supposed to be a test for the casequery function. Let me check why githut is showing a bunch of unrelated commits here.

Did you revert a bunch of commits on github? Going to https://github.com/freelawproject/juriscraper/commits/master shows only commits up till Mar 2. I think somehow two months of commits were reverted, so my pull request on top of the latest cloned version now has all those commits.

@audiodude audiodude force-pushed the freelawproject:master branch from 9c93e4a to f833d7f 20 hours ago

this seems to be what happened?

OK, yeah, it looks like @audiodude made a git mistake yesterday. I just force pushed my local master to fix it (whew!), but that didn't fix your PR.
My theory is that when @audiodude force pushed, he nuked the branch point your PR used from master, and your PR rebranched itself from head (which was several months behind), because it needed to branch from...something? Now that I've force pushed, I think your branch point is still in the wrong place, and needs to be rebased on the correct head of master (the one I just pushed).
Sorry to ask, but can you check on that? Seems you have pretty good git-fu in any case?

Should be fixed now

Sorry about that! Total mess up by me.

Happens to the best of us, @audiodude. Thanks for the fix, @ikeboy. Merging now.

authors: audiodude ikeboy mlissner

repo: freelawproject/juriscraper


text:
Remove duplicate

Thanks.

authors: fzaninotto mijgame

repo: fzaninotto/Faker


text:
Update dictionary.js

Codecov Report

Merging #12 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master       #12   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            3         3
  Lines           15        15
=========================================
  Hits            15        15

Impacted Files
Coverage Δ

src/dictionary.js
100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 06b2d8f...957ddd3. Read the comment docs.

authors: PawelekDev codecov-commenter

repo: gabrielfurini/morsee


text:
Sync with python implementation

PR opened against the wrong branch, closing

repo: gballet/go-verkle


text:
Is there a way to automatically refresh the display every n seconds independent of key presses?

Is https://github.com/gdamore/tcell/blob/f4d402906fa3d330545365abbf970c048e677b35/_demos/beep.go more or less the idiomatic way to handle this?

Is https://github.com/gdamore/tcell/blob/f4d402906fa3d330545365abbf970c048e677b35/_demos/beep.go more or less the idiomatic way to handle this?

Yeah, separating the render loop and the event handling loop sounds like the
right way to do this.
The render loop, as in that example, will call render (screen.Beep in that
example) at some frequency until the quit channel is closed.
// renderLoop renders to the screen at 25 FPS until quit is called.
func renderLoop(screen tcell.Screen, quit <-chan struct{}) {
    ticker := time.NewTicker(time.Second / 25)  // 25 FPS
    defer ticker.Stop()

    for {
        select {
        case <-ticker.C:
            render()

        case <-quit:
            return
        }
    }
}

A separate event loop will be responsible for handling events and manipulating
state necessary for the render() function.
// eventLoop handles inbound events. Closes the quit channel when it's time to
// quit.
func eventLoop(screen tcell.Screen, quit chan struct{}) {
    defer close(quit)

    for {
        switch ev := screen.PollEvent().(type) {
        case *tcell.EventResize:
            screen.Sync()

        case *tcell.EventKey:
            if shouldQuit(ev) { // for some definition of shouldQuit
                return
            }
        }
    }
}

Then these fit together in the main goroutine.
func main() {
    // ...

    quit := make(chan struct{})
    go renderLoop(screen, quit)

    // Handle events in the main goroutine to block application exit until
    // it's time to quit.
    eventLoop(screen, quit)
}

I'm using top-level functions (and therefore global state for render()) in
the example above but you can encapsulate it all in some kind of App object
to avoid that.

Amazing. Thank you @abhinav! I looked at a bunch of TUI libraries, including ones built on top of tcell, and tcell was the best by far.

authors: abhinav droctothorpe

repo: gdamore/tcell


text:
fixed term name and definitions Fixes #13354

--------------------------------------------------------------------------------
Parser: org.semanticweb.owlapi.oboformat.OBOFormatOWLAPIParser@2e54db99
    Stack trace:
LINENO: 199679 - Unexpected tag subsetdef in term frame.
LINE: subsetdef: gocheck_do_not_manually_annotate        o

should be inSubset OWL tag

authors: cmungall pgaudet

repo: geneontology/go-ontology


text:
refactor the code a little bit

Thank you very much!


text:
fix: Sanitize user data, which contains sensitive $_SESSION data

The user context is supplied by the developer and I don't think we should sanitize this since the developer can scrub the data it puts in the user context.

authors: maleetz stayallive

repo: getsentry/sentry-php


text:
remove go chassis config,auth pkg

Coverage increased (+0.08%) to 65.914% when pulling 5635051cf5a67d76723de3b84fe1dbf258c6e63f on tianxiaoliang:master into 7d1677393733ff9a7879df0dd6c5dd6504f8035f on go-chassis:master.

authors: coveralls tianxiaoliang

repo: go-chassis/go-chassis