text:
Inaccurate and misleading description regarding sharing a model-driven app

The description, regarding sharing a model-driven app, is inaccurate and misleading. The article does not distinguish precisely enough between model-driven app and canvas app.
For sharing model-driven apps, only the predefined security roles Basic User, System Customizer, and System Administrator are available. Custom roles cannot be selected. If they are, the article is not clear about this either. In this case, how must a custom security role be configured so that it can be used to share a model-driven app?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 4549b49b-30e8-c879-39a4-dab18142c213
Version Independent ID: 8a4a64ea-979f-c4e2-94f0-dd7311b660a4
Content: Share a model-driven app using Power Apps - Power Apps
Content Source: powerapps-docs/maker/model-driven-apps/share-model-driven-app.md
Service: powerapps
Sub-service: mda-maker
GitHub Login: @Mattp123
Microsoft Alias: matp

Thanks for your comment, @SkippingAdi. This issue has been assigned to the doc author for review.

@SkippingAdi - Most security roles can be assigned to a model-driven app including custom roles. Both the pet schedulers and copy of basic user are custom security roles that can be assigned to the model-driven app in this screenshot. Closing issue.

authors: Mattp123 SkippingAdi bishalgoswami

repo: MicrosoftDocs/powerapps-docs


text:
Does not work on private repos

Hi,
This only seems to work for public repos and therefore cant be used within our (or most) enterprise solutions. Can you advise on any roadmap to have this working with private repos?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 076ce105-645c-cf91-44b7-4e2192eed874
Version Independent ID: fb6358ab-0940-7ced-1036-2ddc49b78ce5
Content: Tutorial: Connect to a GitHub repo with Power BI - Power BI
Content Source: powerbi-docs/service-tutorial-connect-to-github.md
Service: powerbi
Sub-service: powerbi-service
GitHub Login: @maggiesMSFT
Microsoft Alias: maggies

Hi, @chris-schulz -- thanks for your question! Hmmm. I specifically chose a public repo for this article so folks could follow along, but I can create a report for our private content repo, too. In our case, I have to add "-pr" to the end of the repo name. Not sure if that's a GitHub convention, or just our internal convention. Can you try it with your private repo name?

Hi, @chris-schulz -- thanks for your question! Hmmm. I specifically chose a public repo for this article so folks could follow along, but I can create a report for our private content repo, too. In our case, I have to add "-pr" to the end of the repo name. Not sure if that's a GitHub convention, or just our internal convention. Can you try it with your private repo name?

No success I'm afraid...
MessageWeb.Contents failed to get contents from 'https://api.github.com/repos/<myreponame>/reporting-pr' (404): Not Found Table: RepoDetails.
Cluster URIWABI-AUSTRALIA-SOUTHEAST-redirect.analysis.windows.net
Activity IDa97b9064-d1be-4d29-8bd4-8c03cae3fbe6
Request ID460cd385-9c98-f4a8-b2a5-ad5bace2a79c

Hi, @chris-schulz -- I'm checking with someone else. In the meantime you can try the Power BI community and support sites,
https://community.powerbi.com/
https://powerbi.microsoft.com/en-us/support/

Yep, that's where I started... crickets... :(

OK. Well, I've sent your question to someone else. We'll see what I get back.

Was there ever a fix for this?
I'm having problem connecting to a private repository that I'm admin for.
I'm getting the following error:
Last refresh failed: Mon May 17 2021 18:43:32 GMT+0200 (Central European Summer Time)There was an error when processing the data in the dataset.

Processing error:
The column 'Column1' of the table wasn't found.

Cluster URI:
WABI-NORTH-EUROPE-K-PRIMARY-redirect.analysis.windows.net

Activity ID:
26135b3c-faf4-2cd6-ab23-5846b39ed6dd

Request ID:
e6470c97-7fea-8eba-94f0-12cc394b4351

Time:
2021-05-17 16:43:32Z

Inside github the Power-BI is approved as it should be:

source: gharchive/issue

authors: ZynThaX chris-schulz maggiesMSFT

repo: MicrosoftDocs/powerbi-docs

license_type: permissive

license_source: github-api


text:
Correction needed (I think)

[Enter feedback here]
Article says
"In your tenant, go to the data hub in Power BI Desktop"
Think it should be changed "Power BI Service"

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 74430e48-5764-9eff-7410-26ab2c400917
Version Independent ID: 74430e48-5764-9eff-7410-26ab2c400917
Content: Access shared datasets in Power BI as a guest user from an external organization (preview) - Power BI
Content Source: powerbi-docs/collaborate-share/service-dataset-external-org-share-view.md
Service: powerbi
Sub-service: powerbi-admin
GitHub Login: @ajburnle
Microsoft Alias: ajburnle

Thanks for your comment, @rjoboyle. This issue has been assigned to the doc author for review.

Hi @rjoboyle,
You're right, this is a typo - thanks for pointing this out.
I fixed this typo and it'll show on the website soon.
Thanks,
Kesem

authors: KesemSharabi bishalgoswami rjoboyle


text:
Add documentation for %trace

This PR adds in a short section under this docs page that explains how to visualize Q# programs with the %trace magic command.

Docs Build status updates of commit eababa1:
:clock10: Pending: waiting for processors (5 builds ahead of you)
:warning: Docs Build is busy, currently there are 5 builds ahead of this one, for more information you can view the Build queue graph on the Docs Portal.

Acrolinx Scorecards
A minimum Acrolinx score of 80 is required.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology.

Article
Acrolinxscore
Lowestcategoryscore
Spellingissues
Scorecard
Processed

articles/user-guide/host-programs.md
80
47
4
link
:white_check_mark:

More information about Acrolinx

Install Acrolinx locally for VSCode
False positives or issues
Troubleshooting issues with Acrolinx

Docs Build status updates of commit eababa1:
:warning: Validation status: warnings

File
Status
Preview URL
Details

articles/user-guide/host-programs.md
:warning:Warning
View
Details

articles/media/trace_example.png
:white_check_mark:Succeeded
View

articles/user-guide/host-programs.md

Line 571, Column 0: [Warning-hard-coded-locale] Link 'https://docs.microsoft.com/en-us/qsharp/api/iqsharp-magic/trace' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit ea04de3:
:clock10: Pending: waiting for processors (5 builds ahead of you)
:warning: Docs Build is busy, currently there are 5 builds ahead of this one, for more information you can view the Build queue graph on the Docs Portal.

Acrolinx Scorecards
A minimum Acrolinx score of 80 is required.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology.

Article
Acrolinxscore
Lowestcategoryscore
Spellingissues
Scorecard
Processed

articles/user-guide/host-programs.md
80
47
4
link
:white_check_mark:

More information about Acrolinx

Install Acrolinx locally for VSCode
False positives or issues
Troubleshooting issues with Acrolinx

Docs Build status updates of commit ea04de3:
:warning: Validation status: warnings

File
Status
Preview URL
Details

articles/user-guide/host-programs.md
:warning:Warning
View
Details

articles/media/trace_example.png
:white_check_mark:Succeeded
View

articles/user-guide/host-programs.md

Line 571, Column 0: [Warning-hard-coded-locale] Link 'https://docs.microsoft.com/en-us/qsharp/api/iqsharp-magic/trace' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit c091650:
:clock10: Pending: waiting for processors (5 builds ahead of you)
:warning: Docs Build is busy, currently there are 5 builds ahead of this one, for more information you can view the Build queue graph on the Docs Portal.

Acrolinx Scorecards
A minimum Acrolinx score of 80 is required.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology.

Article
Acrolinxscore
Lowestcategoryscore
Spellingissues
Scorecard
Processed

articles/user-guide/host-programs.md
80
47
4
link
:white_check_mark:

More information about Acrolinx

Install Acrolinx locally for VSCode
False positives or issues
Troubleshooting issues with Acrolinx

Docs Build status updates of commit c091650:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

articles/media/trace_example.png
:white_check_mark:Succeeded
View

articles/user-guide/host-programs.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit ebc0f43:
:clock10: Pending: waiting for processors (6 builds ahead of you)
:warning: Docs Build is busy, currently there are 6 builds ahead of this one, for more information you can view the Build queue graph on the Docs Portal.

Acrolinx Scorecards
A minimum Acrolinx score of 80 is required.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology.

Article
Acrolinxscore
Lowestcategoryscore
Spellingissues
Scorecard
Processed

articles/user-guide/host-programs.md
80
47
4
link
:white_check_mark:

More information about Acrolinx

Install Acrolinx locally for VSCode
False positives or issues
Troubleshooting issues with Acrolinx

Docs Build status updates of commit ebc0f43:
:warning: Validation status: warnings

File
Status
Preview URL
Details

articles/user-guide/host-programs.md
:warning:Warning
View
Details

articles/media/trace_example.png
:white_check_mark:Succeeded
View

articles/user-guide/host-programs.md

Line 571, Column 127: [Warning-xref-not-found] Cross reference not found: 'microsoft.quantum.iqsharp.magic-ref.trace'.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

source: gharchive/pull-request

repo: MicrosoftDocs/quantum-docs-pr


text:
Fixed link in what-is-sql-server-machine-learning.md

The link to "Machine Leanring Services (with R)" was broken because it had two sets of parathenses around it, removed one set of parentheses.

@crahrig : Thanks for your contribution! The author, @HeidiSteen, has been notified to review your proposed change.

repo: MicrosoftDocs/sql-docs


text:
Add missing space

Add missing space to:

@kendaleiv : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Looks good/verified in preview; thanks.

authors: PRMerger9 kendaleiv ktoliver


text:
Fix typo in accessing-the-current-transaction.md

The sentence:

The error message thresembles similar to the following:

...should read:

The error message is similar to the following:

@ericmutta : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Looks good. Thanks @ericmutta

Thanks for following up @ktoliver!

authors: PRMerger13 ericmutta ktoliver


text:
Typo "Azure blob storage"→"Azure Blob Storage"

https://docs.microsoft.com/en-us/sql/relational-databases/databases/sql-server-data-files-in-microsoft-azure?view=sql-server-ver15

@hyoshioka0128 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@hyoshioka0128 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

The change aligns with current guidance in the internal cloud style guide; we'll merge

The change aligns with current guidance in the internal cloud style guide; we'll merge


text:
Update copy-into-transact-sql.md

Added Guidelines to the AUTO_CREATE_TABLE = ON

@VasiyaKrishnan : Thanks for your contribution! The author(s) have been notified to review your proposed change.

This is high priority and would like to make the changes visible as soon as possible. @WilliamDAssafMSFT @jonburchel

#sign-off

@VasiyaKrishnan: I'm sorry - only the author of this article, @MikeRayMSFT, can sign off on your changes. But we do have an exception process - if you are on the Microsoft content or product team for this product area, you can ask the PR review team to review and merge it by sending mail to the techdocprs alias.

I am on the Microsoft Product Team and would like to ensure these changes gets reflected ASAP as it has a significant customer impact.
#sign-off

@VasiyaKrishnan: I'm sorry - only the author of this article, @MikeRayMSFT, can sign off on your changes. But we do have an exception process - if you are on the Microsoft content or product team for this product area, you can ask the PR review team to review and merge it by sending mail to the techdocprs alias.


text:
Explain how to make msbuild respect errors for IDExxxx diagnostics

I tried putting in my .editorconfig:
[*.{cs,vb}]
dotnet_diagnostic.IDE0067.severity = error

In the IDE in the Error List window, it appears as an error. However, when I run msbuild /r/ m, the build succeeds (even if I remove bin and obj first). How do I instruct msbuild to properly fail in this situation?
I think this docs page should explain why the behavior I see is expected behavior and also describe how to get msbuild to fail when setting the severity to error.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: c27ec225-8fc2-3578-05a0-a3e56e1c6510
Version Independent ID: 186d9286-10db-6135-b542-81b1bf71575a
Content: Analyzer rule severity and suppression - Visual Studio
Content Source: docs/code-quality/use-roslyn-analyzers.md
Product: visual-studio-windows
Technology: vs-ide-code-analysis
GitHub Login: @jillre
Microsoft Alias: jillfra

@binki You are using VS 2019 16.3 or later? In the doc, looks like this is required.
@mavasani Manish, do you know why the build might fail with an error in the IDE, but succeed in MSBuild?

Couple of things:

IDE diagnostics in default VS install are only for live analysis. These cannot cause build breaks by default - that would be a breaking change for everyone.

IDE analyzers currently have VS dependencies, and are not executable on CI. See https://github.com/dotnet/roslyn/issues/33558, which tracks enabling them to execute on CI.

@Mikejo5000 I am using 16.4.2 currently. When I filed this issue, I am not sure what version I was using, but I normally stay on latest. I know that I was able to get the diagnostics to appear as errors in the IDE but not via MSBuild.
The docs I filed this issue against claim that setting the diagnostic severity to error will cause a command line build time failure. I was hoping the docs could be expanded to explain how to get that to work if it were really possible. From @mavasani’s remarks, it sounds like there are plans to make this possible but that it isn’t currently possible.

The docs I filed this issue against claim that setting the diagnostic severity to error will cause a command line build time failure. I was hoping the docs could be expanded to explain how to get that to work if it were really possible. From @mavasani’s remarks, it sounds like there are plans to make this possible but that it isn’t currently possible.

@binki Note that all the stuff mentioned in the docs work for all 3rd party analyzers in both CI and live analysis. It also works for IDE analyzers in live analysis. The only missing support is for IDE analyzers to be available as a NuGet package that can run in CI break build.

@mavasani Do you think this warrants a note in the docs? Since the issue may be addressed in the not-too-distant future, I'm inclined to leave the docs as they are.

Yes, we are actively working towards porting IDE rules to a NuGet package, so probably it is fine.

Closing this for now

authors: Mikejo5000 binki mavasani

repo: MicrosoftDocs/visualstudio-docs


text:
Docker Tutorial - docker build failing

I am currently running through the Docker tutorial and receiving an error upon building the image in my command line.
See the attached images for the error messages provided at the time of running the command.
Feel free to check my Dockerfile in the case that that is on the off chance causing an issue.
Let me know if you need anything further on my end of things for debugging. ☺

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 38a38919-b557-4723-7ea9-b0fbafbfdc52
Version Independent ID: 2117c374-eda9-906e-392e-c55e1ebf8060
Content: Docker tutorial - Part 2: Build and run the todo list sample app
Content Source: docker/tutorials/your-application.md
Product: vs-code
GitHub Login: @BigMorty
Microsoft Alias: mikemort

@kentond18 -- Kenton, thank you for your detailed feedback.  This repo is solely for documentation issues, and this appears to be product-related.  Please consider these resources:

Visual Studio on Microsoft Q&A
Visual Studio MSDN Forum
Stack Overflow
Reddit

I am closing this issue now.  You are welcome to @ mention me for any followup.  We hope to hear from you again.


text:
bad maximumFractionDigit field

The maximumFractionDigit field in the code snippet should actually be maximumFractionDigits (plural).

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: d71e6f22-ce3f-9fc7-06aa-aca4cc38742e
Version Independent ID: ba98a0d5-966c-2914-8768-67c434d35c41
Content: format Property (Intl.NumberFormat)
Content Source: scripting-docs/javascript/reference/format-property-intl-numberformat.md
Service: unspecified
GitHub Login: @Mikejo5000
Microsoft Alias: mikejo

@monarchdodra Thanks for the feedback! I will plan to fix this


text:
Delete unnecessary spaces

When copying from the web page, there is an unnecessary space after the code.

@changeworld : Thanks for your contribution! The author, @gregvanl, has been notified to review your proposed change.

@changeworld Thank you for this cleanup work! I'm going to merge this now.

authors: PRMerger7 changeworld tfosmark


text:
createCustomEnvironment not documented

What does createCustomEnvironment do?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: fa498d54-1576-498a-b8b5-189f2859a884
Version Independent ID: 0642e827-92b5-5f30-e162-c7220de4089f
Content: Conda Environment
Content Source: docs/pipelines/tasks/package/conda-environment.md
Product: devops
GitHub Login: @erickson-doug
Microsoft Alias: brcrista

conda is both a package manager and environment manager. createCustomEnvironment set to True tells this task that you want to create an environment instead of using the default one.

Docs have been updated to clarify this and other arguments.  Thank you!

create an environment link does not exists. Please update the doc with correct link.

@DavidStaheli
In the Azure pipeline conda step, can we specify conda.yaml file path, such that it creates env from the yaml file?

@brcrista can you please advise?

@praneetmsft we've learned that the task can't cover every scenario.  We're in the process of deprecating the task and recommend you just use script for working with Anaconda environments.
We have a new guide just for using Anaconda in Pipelines, you can see it here: https://docs.microsoft.com/azure/devops/pipelines/languages/anaconda#from-yaml
Thanks for pointing out the broken link, I'll fix that.

@brcrista In principle I'm very much in favour of exposing functionality with CLI tools. I see two problems with the new approach though:

Activating an environment has to be done for each subsequent task that needs to use it. That is quite cumbersome. Any way to work around that and make it persist?
Having to change PATH just to use conda is a bit awkward, for one thing because of the syntax ##vso[.. syntax) and also because it's different per operating system. What about a UseConda task that does this automatically?

Agreed on both counts.  The way each step runs in a fresh system environment / process has been feedback we've heard before, especially with conda.  That was a fundamental decision made a long time ago in what it means to be a "step."  The original Conda Environment task was an attempt to address this, but Anaconda environments end up having a lot of customization options that the task just can't cover.  @vtbassmatt and I have kicked around some new ideas on how to address this in a script-first way for the YAML world.
Yeah, putting every tool in PATH does get hard to scale for reasons like this.
@vtbassmatt , being able to say use: conda and go look for an install location might be a good solution here too.

authors: DavidStaheli brcrista carterbox letmaik praneetmsft

repo: MicrosoftDocs/vsts-docs


text:
Generated server id doesn't match what is advised in the azure artifacts packaging page

Love this tool.  It will help us tremendously, as the auto-authenticate of the maven task requires the root POM to have all upstream registries.  Plus, this will be great for our Docker authentication.
However, the generated ID in the settings.xml is just the name of the artifact stream you are attaching to.  The snippet in the packaging UI has a schema of dev-azure-com-${ORG}-${PACKAGESTREAM}.  Since our engineers will be leveraging the UI a lot, this causes drift with what we have in our poms.xml to support both CI and local building.  Currently we rely on text replacement commands ran immediately after the authenticate task.
Is there a way to specify the name of the ID we will generate?  Or, is there a different standard you are expecting poms to follow so that we can have the repository contain two IDs?  Thank you!

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 652905ce-af26-dbea-9207-c11cd3bd0064
Version Independent ID: 6558ec51-b1b5-15d8-0d46-1214f4038de1
Content: Maven Authenticate task (for task runners) - Azure Pipelines
Content Source: docs/pipelines/tasks/package/maven-authenticate.md
Product: devops
Technology: devops-cicd
GitHub Login: @chasewilson
Microsoft Alias: phwilson

Thanks for your question. It looks like your question isn't an issue with the documentation, but an issue or question specific to your implementation or a bug in the product itself.
For help with a specific task, here are a couple of options where you might consider asking your question:

Azure DevOps on Stack Overflow
Azure DevOps Support Bot

If you've encountered an issue with the product itself, to make sure it gets in front of the right people, please submit your bug here.
If you have an idea for improving the product, please submit your idea here.

authors: SirAlvarex mijacobs


text:
ICompositionSupportsSystemBackdrop.SystemBackdrop() link error of CompositionBrush

When I tryied using code like
myICompositionSupportsSystemBackdrop.SystemBackdrop(myCompositionBackdropBrush)

, VS2022 just says
E0304 No instance of overloaded function "winrt::Microsoft::UI::Composition::ICompositionSupportsSystemBackdrop::SystemBackdrop"

I have created a new winUI3 C++ project using Windows App SDK 1.4.2, cpp/winrt version 2.0.220929.3, and included no header files other than those provided in pch.h.
Code behind works fine in C#:
public static void SetTransparent(Window window)
{
    var brushHolder = window.As<ICompositionSupportsSystemBackdrop>();
    var colorBrush = WindowsCompositionHelper.Compositor.CreateColorBrush(Windows.UI.Color.FromArgb(0, 255, 255, 255));
    brushHolder.SystemBackdrop = colorBrush;
}

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 41d04c2d-5b65-44d2-3eb4-3471853e2e5c
Version Independent ID: 41d04c2d-5b65-44d2-3eb4-3471853e2e5c
Content: ICompositionSupportsSystemBackdrop.SystemBackdrop Property (Microsoft.UI.Composition) - Windows App SDK
Content Source: winapps-winrt-build/xml/Microsoft.UI.Composition/ICompositionSupportsSystemBackdrop.xml
Product: reunion
Technology: reunion-reference
GitHub Login: @jwmsft
Microsoft Alias: jimwalk

Thanks to DarranRowe's answer (see Issue in microsoft-ui-xaml repo ! He found that it was a link mistake of the documention. The parameter of SystemBackdrop should be Windows.UI.Composition.CompositionBrush, not Microsoft.UI.Composition.CompositionBrush. Hope it helps!

@Bobby-Ling, thanks for opening this issue. The incorrect links to CompositionBrush have been fixed.

authors: Bobby-Ling jwmsft

repo: MicrosoftDocs/winapps-winrt-api


text:
General brush up of PowerToys docs

occasional spelling fixes
use "select" for interaction, and for checkbox state
use "screen", "display" according to Style Guide
"tab" for a page in the Settings window
format of "arrow keys"
and such...

Looks good to me now. Do you want Clint or anyone from the team to take a look at it before I merge?

Thank you. It would be a courtesy to give Clint a chance, yes. Or else i'll leave it up to you.

Sounds good. I'll hold off until tomorrow so folks have a chance. Thanks for the contribution!

"a few"? 🤣 LOL nah you've got some good points. I'll process them when I'm back on my computer 👍🏻

@crutkas thoughts?

PS those build updates are just annoying as 💩
😆 Sorry, just had to say it. At least it would be nice if all the older comments would be removed upon a new comment...

authors: Jay-o-Way alvinashcraft

repo: MicrosoftDocs/windows-dev-docs


text:
Visual C++ > Windows Driver > Tests cannot be found

I would like to create the test project for the driver using c++, but according to the paragraph "To customize a driver test using the Driver Test template for C++" I cannot find the Visual C++ > Windows Driver > Tests in my VS 2015 even 2019, may I know where I can create the driver testing project?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 6b9c14aa-06ab-bacb-7b10-ff184858d1d1
Version Independent ID: 0cb2cc28-6e79-1732-722d-b903a82e2046
Content: How to write a driver test using a Driver Test template - Windows drivers
Content Source: windows-driver-docs-pr/develop/how-to-write-a-driver-test-.md
Product: windows-hardware
Technology: windows-devices
GitHub Login: @tedhudek
Microsoft Alias: tedhudek

Hi @o60816, I believe the WDK prior to 2015 contained this template but it never made it in to 2015 and beyond. I have no info on a replacement.
You could try the forums --

Windows Hardware WDK and Driver Development
OSR's ntdev List

Thanks for the feedback!

I added a note at the top of https://docs.microsoft.com/en-us/windows-hardware/drivers/develop/how-to-write-a-driver-test-

Thank you for your reply, I appreciate it very much.
May I know without this template test project how can I create my own test cases? Is it still possible to create custom test cases?

Thanks for the question, @o60816.  I'm sorry to report that there is no current workaround to create custom test cases.

repo: MicrosoftDocs/windows-driver-docs


text:
OpenAdater of Umd driver is never be called,unless disable OpenAdater10-12. (D3D9->EnumAdapter()  Only find MSBDD Adapter ） DXGI->EnumAdapter Can find New Wddm Adapter

[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 7938c677-9152-8055-45e5-57ef0e9a6a9f
Version Independent ID: db35793a-8f83-5d2d-9aff-f7102320f44a
Content: D3D Runtime Functions called by User-Mode Display Drivers - Windows drivers
Content Source: windows-driver-docs-pr/display/direct3d-runtime-functions-called-by-user-mode.md
Product: windows-hardware
Technology: display
GitHub Login: @lorihollasch
Microsoft Alias: loriwhip

@404517981 , thanks for submitting an issue. We are uncertain what you want updated on the page. Can you provide me with the specifics of what documentation you think needs to be updated, or submit a PR? I'm going to close this issue for now - feel free to reopen it with your specific documentation request.


text:
What about vs 2022 17.3? Does it support driver debugging?

[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 5930505f-6810-b2a2-86b5-3c678aae7f89
Version Independent ID: 28315cf8-f06f-23ad-2088-9d51d08efe0d
Content: Download the Windows Driver Kit (WDK) - Windows drivers
Content Source: windows-driver-docs-pr/download-the-wdk.md
Product: windows-hardware
Technology: whats-new-and-downloads
GitHub Login: @tedhudek
Microsoft Alias: tedhudek

Hi @terraslate, thanks for the question and apologies for the delay.
This issue also affects VS 17.3.  I have updated https://learn.microsoft.com/en-us/windows-hardware/drivers/download-the-wdk to reflect this.

authors: tedhudek terraslate


text:
Update inf-manufacturer-section.md

Use consistent casing for NT architecture decorations

Thanks Zac, should be live soon

authors: tedhudek zlockard


text:
Update user-account-control-behavior-of-the-elevation-prompt-for-stan…

…dard-users.md
sync with best practices, see https://github.com/MicrosoftDocs/windows-itpro-docs/commit/c66f5f99b1ee002661c50a9faa0adebe380d5c7f

Why

Closes #[Issue Number]

Changes

Thanks for the contribution @rafalfitt! I've merged this PR.

authors: rafalfitt vinaypamnani-msft

repo: MicrosoftDocs/windows-itpro-docs


text:
Key Trust now support RDP

Please take a look at the docs below. Now WHfb Key Trust model supports RDP.
https://docs.microsoft.com/en-us/windows/security/identity-protection/hello-for-business/hello-deployment-rdp-certs

( ref. PR #9394 & #9396 )

This issue isn't accurate. The instructions in the linked doc are basically for how to issue a cert for a key trust credential so it can be used as a supplied credential for RDP. Supplying only the key is still not supported.

Closing based on the comments above.

authors: e0i illfated mapalko tayasuta


text:
Update Set-SmbServerConfiguration.md

Changed example heading from 'singing' to 'signing' Hopefully in the right repo this time.

Docs Build status updates of commit 07bb7af:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docset/windows/smbshare/Set-SmbServerConfiguration.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@tseward Care to comment on this minor typo fix? Thank you.

repo: MicrosoftDocs/windows-powershell-docs


text:
Change Sageo UI Images to white Font when Black Theme is enabled

Change Sageo UI Images to white Font when Black Theme is enabled.
Can't see the icons on black theme,

Hi @TiMeJuMp - Thanks for filing this issue. Are these the icons you are referring to in the black theme...?

I agree that these are harder to see in blue. I'll connect with the platform devs and see if there is a reason for not changing them these to the white font.

Hi @mattwojo
no i mean the icons a few sites down.

Ahh -- I see what your talking about now. Agh, not good. Let me see what I can do. Thanks @TiMeJuMp!

Thanks @mattwojo
This is clever :)

Thanks @TiMeJuMp  -- Please let us know if you see any other issues. Closing this one out. 👍

authors: TiMeJuMp mattwojo

repo: MicrosoftDocs/windows-uwp


text:
Examples provide invalid syntax

Many (if not all) of the provided examples for using manage-bde are simply wrong and executing them will generate an "Invalid Syntax" error. This is because the arguments before the Volume have dropped their leading "dash." For example, the command manage-bde -protectors -adbackup C: is incorrectly shown as managed-bde protectors adbackup C:.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 5dd9f8b1-7b5e-844d-fcab-94ec6741dd4a
Version Independent ID: 52ed5d26-1606-0afb-4812-c3eefb534896
Content: manage-bde protectors
Content Source: WindowsServerDocs/administration/windows-commands/manage-bde-protectors.md
Product: windows-server-threshold
GitHub Login: @coreyp-at-msft
Microsoft Alias: coreyp

@steved0x, it looks like the defect I logged was fixed with 08645b607215017b85440074f1e196b2899c513a.

@rbeesley : Thank you for pointing out that detail and that it seems to be corrected.

This issue ticket was in effect resolved by PR #3437 and commit https://github.com/MicrosoftDocs/windowsserverdocs/commit/08645b607215017b85440074f1e196b2899c513a .

#please-close

authors: illfated rbeesley

repo: MicrosoftDocs/windowsserverdocs


text:
Tools for Forest Recovery automation

This guide says that "Because of the complex and critical nature of the forest recovery process, there is currently no end-to-end automation of it", however there are commercial products which do automate Forest Recovery, for example Quest Recovery Manager for Active Directory Forest Edition or Disaster Recovery Edition.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 95e9deae-29e2-3ca6-3a38-430b383508c0
Version Independent ID: 1a6b129b-8faf-6064-5283-52a1de86c9e8
Content: AD Forest Recovery - FAQ
Content Source: WindowsServerDocs/identity/ad-ds/manage/AD-Forest-Recovery-FAQ.md
Product: windows-server-threshold
Technology: identity-adds
GitHub Login: @MicrosoftGuyJFlo
Microsoft Alias: joflore

Microsoft does not test third party tools for forest recovery.

#please-close

#please-close

#please-close

authors: MicrosoftGuyJFlo illfated izblah skalitin


text:
Please add Windows 11 home edition.

Hi, My customer use Remote desktop at Windows 10 Home Edition.
They want to upgrade to Windows 11, but Windows Home Edition is not supported remote desktop.
I think it's probably a miss the words, so please add it.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: f10e667a-7b08-b25f-5c0a-b776b7f11cb4
Version Independent ID: ae4936a7-f5a3-b3ad-170c-7aba109435db
Content: Supported configurations for the Windows Desktop client
Content Source: WindowsServerDocs/remote/remote-desktop-services/clients/windowsdesktop-supported-config.md
Product: windows-server
Technology: remote-desktop-services
GitHub Login: @Heidilohr
Microsoft Alias: helohr

We hugely appreciate your contribution, feedback, and support to our technical documentation.
We’ve phased out GitHub Issues on this repository as the feedback mechanism for content and have replaced it with a new feedback system. For more information see, Content User Feedback. As part of this rollout, we are migrating your issue where our team will use your comments to improve the documentation experience. Unfortunately, this does mean you won't be able to access this issue after the migration is complete.
All issues will be migrated by Thursday 29th August 2024.
Once again, thank you for your valuable feedback, we hope you’ll continue to contribute using our new feedback system.

authors: ookada robinharwood


text:
secedit-export: The "/db" parameter is optional

On live systems we can clearly see that the "/db" parameter is optional.

Hey @exchange12rocks, thank you for your contribution! We have modified the description for the /db parameter to make it more clear to users.
Merging shortly.


text:
Updates on this page

[Enter feedback here]
Hi, it's been a while. Are you expecting to update this page?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 64b487e4-704e-7407-dc4e-dbd4787b6b17
Version Independent ID: b7c66d71-1e06-7758-ca85-1f7b62937025
Content: UWP features not yet supported on Xbox - Windows UWP applications
Content Source: winrt-related-src/extension-sdks/uwp-limitations-on-xbox.md
Product: uwp
Technology: winrt-reference
GitHub Login: @stevewhims
Microsoft Alias: stwhi

Hi, @MarcoEnxuto, I'll go ahead and start investigating this question. I'll report progress here.
Thanks!
Steve

I just sent a ping to the email thread I have going. No response yet, but I'll keep investigating.

UPDATE: I've made contact with a feature team representative, who is looking into this. If the feature team have changes they'd like to make to this topic, then I'll make them. I'll also keep the internal discussion going periodically.
Thanks!
Steve

I've sent another reminder internally. We're still investigating. Thanks for your patience.
-Steve

So, any news? 🙂

@stevewhims ?

Hi, so I just sent a further reminder internally. It's possible that I might have to close this issue if I can't manage to get the info. In the meantime, just in case it's useful to you, here are all of the developer support resources, for completeness.

Microsoft Q&A is the right place to lobby for a change or a new feature, to make a suggestion, or to ask a product question.
For community assistance with development questions, there are our forums, and StackOverflow.
The Windows developer support site explains other support options.
The Visual Studio developer community is available, and responsive. The former User Voice feature is now there on the Suggest a feature tab, if you want to lobby for a change, a feature, or to make a suggestion.
For developer issues, or suspected product bugs, there's Microsoft Support; a support engineer will look at the repro and see whether the issue is a Microsoft product bug, or something else. If it's a bug with a Microsoft product then the ticket will be free of charge.

Thanks!
Steve

Hi, @MarcoEnxuto, I've received confirmation that this topic is in fact still accurate. I'll go ahead and close the issue. Thanks for being patient!
-Steve

authors: MarcoEnxuto stevewhims

repo: MicrosoftDocs/winrt-related


text:
Xamarin.EssentialsGeolocation: CalculateDistance example error

The Calculate distance example on the Xamarin.Essentials Geolocation page seems to be in error. You get a Error Mesaage:
No Overload for method CalculateDistance takes 3 arguments
Location boston = new Location(42.358056, -71.063611);
Location sanFrancisco = new Location(37.783333, -122.416667);
double miles = Location.CalculateDistance(boston, sanFrancisco, DistanceUnits.Miles);
Change the last line to:
double miles = boston .CalculateDistance(sanFrancisco, DistanceUnits.Miles);
:)
Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: f0acf3fa-b705-f0cc-b676-eeca60176dfa
Version Independent ID: 1788a5d5-a3cb-15c8-927c-b6a24810245a
Content: Xamarin.Essentials: Geolocation - Xamarin
Content Source: docs/essentials/geolocation.md
Product: xamarin
GitHub Login: @jamesmontemagno
Microsoft Alias: jamont

Hi @djaus2, thanks for the comment. I tried the code as it stands in the docs, using the latest version of Xamarin.Essentials (0.8.0-preview), and it does work correctly.
It looks like there was a bug fixed for 0.8.0-preview that might be related to the issue you're seeing?
However, the approach you mentioned works as well.

Both are actually valid as we do have https://github.com/xamarin/Essentials/blob/master/Xamarin.Essentials/Types/LocationExtensions.shared.cs
We can add documentation to this too.

How do we track LocationChangedEvent? need to get periodic location updates,or can we use a timer that fetches location

We have a feature request open to add this capability into a future release.

authors: bradumbaugh djaus2 jamesmontemagno wltdaniel

repo: MicrosoftDocs/xamarin-docs


text:
Client side javascript part as library?

I like the demo and would use the client side part of the demo as library. Is there a library available based on the demo?
Just the client side javascript part as a single file library to include by a script tag.

To send web push on the client side, we need all browsers to enable CORS w3c/push-api#303 Firefox is the only one that have enable it.

authors: jimmywarting pwFoo

repo: MicrosoftEdge/pushnotifications-demo


text:
Update container via Azure CLI failed.

As docs shown we can just use 'create' to update the container if our docker image was updated. It's tell me that if I don't change the 'os type', 'restart policy', 'network profile', 'CPU', 'memory' and 'GPU', the container can be rebuild. But when I use this command line 'az container create --resource-group  --name  --image haohoo/image:version --location westus' is failed. It prompt 'The updates on container group '' are invalid...'

Hi HaoHoo,
Could you share the full error message? There are a few immutable properties, I wonder if you changed any of those?
thanks!

I'm seeing the same issue and the only value that I'm changing is --image. Is create really the prescribed way to update a container image?

I had the same issue. You have to verify that the values for os type, restart policy, network profile, CPU, memory and GPU correspond to those of the current container. If you don't set them, it will take the default ones:
os type: Linux
restart policy: Always
CPU: 1
memory: 1.5
GPU: null
In my case I had to re-set my network profile and restart policy with --network-profile myprofile --restart-policy OnFailure

Pretty much the same as @luispinedaneo except my network profile was null (as per the output of az container list) so I only had to set the restart policy to match the existing one in the JSON result of the above command (OnFailure) and it worked.

Pretty much the same as @luispinedaneo except my network profile was null (as per the output of az container list) so I only had to set the restart policy to match the existing one in the JSON result of the above command (OnFailure) and it worked.

authors: BeigeBadger HaoHoo luispinedaneo tshak yangl900

repo: MicrosoftFeedback/aci-issues


text:
File name with 2 extensions

Module: 04
Lab/Demo: 01
Task: 04
Step: 3
Description of issue
The ARM template file in the repo has 2 extensions: https://github.com/MicrosoftLearning/AZ-700-Designing-and-Implementing-Microsoft-Azure-Networking-Solutions/blob/master/Allfiles/Exercises/M04/azuredeploy**.json.json**
The Powershell script referencing this file has it if one extension: https://github.com/MicrosoftLearning/AZ-700-Designing-and-Implementing-Microsoft-Azure-Networking-Solutions/blob/master/Allfiles/Exercises/M04/deployvms.ps1
Suggested fix: rename azuredeploy.json.json to azuredeploy.json
Repro steps:

Please rename azuredeploy.json.json to azuredeploy.json

I have a PR open to fix this. It's #3

@irishtechie Thanks for submitting the PR. I was too lazy for that. Funny thing is the file got uploaded a few days the the other files. Someone updated the folder and didn't test the result.

Issue with double extension still exists. In task 4, there is reference to azuredeploy.json, but in repo azuredeploy.json.json exists
https://docs.microsoft.com/en-us/learn/modules/load-balancing-non-https-traffic-azure/4-exercise-create-configure-azure-load-balancer

The PR is still waiting for review and merge.

Bump to Course Owner - this needs to be addressed!

authors: ArmandoLacerda TesterTesterson1004 irishtechie sunnykey

license: MIT


text:
Changed texts for step 8, fixing issue

Related Issue
Fixes #447
Checklist
Mark completed with "x" between brackets, "[x]", or checking the box once the PR is created:

[X] Has related GitHub Issue 💥 Create Issue 📝
[X] Tested it
[X] Read the PR collaboration guide 👓 Collaboration Guide 📝

Changes proposed in this pull request:
Correcting trigger label and other UI misalignments.

Thanks @mkennten!

authors: LuizMacedo mkennten


text:
04-create-dax-calculations-in-power-bi-desktop.md

English:
Month field
Current Translation:
[月份] 欄位
Suggested Translation:
Month 欄位
Description:
The name of field should be English. Global check

Hello contributor,
Thank you for your contribution! We are processing your suggestions and we will update you shortly.
Kind regards,
Microsoft Worldwide Learning Team

Run bugfix tool and waiting for result.

authors: HienThuThiDai olprod stonezy123


text:
Defender for Cloud Apps access policy cannot be created

Module: 03
Lab: 18
Exercise: 03
Task: 01
Step: 06
Description of issue - Cannot create policy due conditional client app control not exist
Conditional access created according previous step but not populated into Defender for Cloud App
Alex

I was not able to duplicate your issue.  However, I found several changes that can make the lab easier to follow, and made those updates.  I am hoping that will clear up the problem.  NOTE - you should complete Exercise1 or this lab before you work on this second Exercise.


text:
eslint require error

when use
"interactive-linter.javascript": ["eslint"],     "language": {         "javascript": {             "linting.prefer": [                 "ESLint"             ],             "linting.usePreferredOnly": true         }     }
and .eslintrc
  "parser": "babel-eslint",
the InteractiveLinter will echo Interactive Linter: 1 Linter Problem
like that:
Module name "babel-eslint" has not been loaded yet for context: _. Use require([]) http://requirejs.org/docs/errors.html#notloaded	[undefined] - undefined

@raiscui yeah configuring anything but linting rules is supported.  Currently, supporting the parser field isn't a priority as that's not quite as common of a use case.  However, I will happily accept a PR :)

authors: MiguelCastillo raiscui

license: mit

license_source: bigquery


text:
Add google code formatter along with goal

Add google code formatter dependency so that the code is formatted throughout independent of the environment.
Maven Link: Google Formatter

mvn com.spotify.fmt:fmt-maven-plugin:format```

repo: Miishri/KiwiEats


text:
Hello test

@Mikatech

Je suis un nouveau commentaire poste automatiquement

repo: Mikatech/sandboxAI


text:
Change the ReadMe file so that it has valuable information

The ReadMe file should always have great desctription !

Why is this reopened ?

From: Mile Petkovski @.>
Sent: Thursday, August 29, 2024 6:36 PM
To: MilePrivate/GitPractice @.>
Cc: Subscribed @.***>
Subject: Re: [MilePrivate/GitPractice] Change the ReadMe file so that it has valuable information (Issue #1)
Reopened #1https://github.com/MilePrivate/GitPractice/issues/1.
—
Reply to this email directly, view it on GitHubhttps://github.com/MilePrivate/GitPractice/issues/1#event-14066421906, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BK3AHX6FTJ5SZIJXSKQO7K3ZT5EYJAVCNFSM6AAAAABNKZP3SCVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJUGA3DMNBSGE4TANQ.
You are receiving this because you are subscribed to this thread.Message ID: @.***>

Should i take a look at this ?

Should i take a look at this ??

Should i take a look at this ??

no ill take it

ok

authors: MilePrivate PetkovskiM

repo: MilePrivate/GitPractice


text:
I get this error below, please help

Code:
var initializer = RavePayInitializer(
amount: 1000,
publicKey: publicKey,
encryptionKey: encryptionKey,
subAccounts: subAccounts.isEmpty ? null : null)
..country = "Nigeria"
..currency = "NGN"
..email = "office.foodstuffstore@gmail.com"
..fName = "Samuel"
..lName = "Dokubo"
..narration = ""
..txRef = ""
..orderRef = ""
..acceptMpesaPayments = false
..acceptAccountPayments = false
..acceptCardPayments = true
..acceptAchPayments = false
..acceptGHMobileMoneyPayments = false
..acceptUgMobileMoneyPayments = false
..acceptMobileMoneyFrancophoneAfricaPayments = false
..displayEmail = true
..displayAmount = true
..staging = false
..isPreAuth = false
..displayFee = true;
var response = await RavePayManager()
.prompt(context: context, initializer: initializer);
print(response);

Output: RaveResult{status: RaveStatus.error, rawResponse: null, message: An error occured while attempting to decrypt some parameters}

Im having the same error and had to switch to flutterwave standard

@tjsvisual Using Flutterwave standard, is they a way one can by pass that first screen with the Pay button so users can be taken straight to the payment UI? Please let me know if you were able to achieve that

authors: FoodStuffStore calistus tjsvisual


text:
fix: correct the stack trace of async helper errors

When an exception is raised in a Promise chain constructed with a synchronous method, the stack trace does not include the caller. So don't use function wrappers.

Codecov Report
Patch coverage: 100.00% and project coverage change: +0.36% :tada:

Comparison is base (65c05b5) 99.63% compared to head (2d1f5ef) 100.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##           master       #20      +/-   ##
===========================================
+ Coverage   99.63%   100.00%   +0.36%
===========================================
  Files           7         7
  Lines         542       536       -6
  Branches       87        85       -2
===========================================
- Hits          540       536       -4
+ Misses          2         0       -2

Files Changed
Coverage Δ

test_stream.ts
100.00% <100.00%> (+0.38%)
:arrow_up:

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

authors: Milly codecov-commenter

repo: Milly/deno-streamtest


text:
Cannot find detours.h

Cannot find detours.h just gives me an error.......

download it here and put it into the Cobalt/Cobalt folder
then change #include <detours.h>to #include "detours.h"
it worked for me

repo: Milxnor/Cobalt


text:
Migrate spec documentation for Events

Checklist:

[ ] Modified the current draft of release notes with details on what is completed or incomplete within this project
[ ] Document code purpose, how to use it

Mention expected invariants, implicit constraints

[ ] Tests were added for the new behavior

Document test purpose, significance of failures
Test names should reflect their purpose

[ ] All tests pass (CI will check this if you didn't)
[ ] Serialized types are in stable-versioned modules
[ ] Does this close issues? List them

Stale, and the zkApps MIP has been accepted. Closing.

repo: MinaProtocol/mina


text:
Make replayer checkpointing work (mainnet)

There was some scaffolding in the replayer for checkpointing, but starting from a checkpoint file didn't really work.
Added flag --checkpoint-interval to dump a checkpoint file periodically, useful if there's a failure and we want to restart the replayer.
This change enables #12993, which will give assurance that the hard fork migration uses valid data.
We'll want to make comparable changes for the replayer in berkeley, and the modified replayer that fills in the accounts_accessed table (not yet written).

!ci-build-me

!ci-build-me

!ci-build-me


text:
Update Rosetta with various improvements

This pull request includes several improvements to Rosetta:

Remove unnecessary code and return inferred nonce in /construction/metadata

Update account balance retrieval using GraphQL query when requesting balance at tip and make it able to respond when not connected to a DB

Don't rely on runtime config for genesis balance anymore

Use token_id from request in account SQL query

Reformat Rosetta code

Changes tested locally on demo netwok.

!ci-build-me

!ci-toolchain-me

!ci-build-me

!ci-nightly-me

!approved-for-mainnet


text:
Possible bug in rivers algorithm

Lines 385-390 of worldengine/simulations/erosion.py
                    newElevation = world.layers['elevation'].data[y, x] + (
                        diff * curve)
                    if newElevation <= world.layers['elevation'].data[ry, rx]:
                        print('newElevation is <= than river, fix me...')
                        newElevation = world.layers['elevation'].data[r, x]
                    world.layers['elevation'].data[y, x] = newElevation

I think that world.layers['elevation'].data[r, x] is wrong. It should be instead orld.layers['elevation'].data[ry, rx]. Am I missing something?

You can always link to the line of code instead:
https://github.com/Mindwerks/worldengine/blob/master/worldengine/simulations/erosion.py#L390
                  if newElevation <= world.layers['elevation'].data[ry, rx]:
                       print('newElevation is <= than river, fix me...')
                       newElevation = world.layers['elevation'].data[r, x]

^-- I put that in there to catch issues newElevation being lower than current elevation (it mustn't be lower than the river itself) so we reset it back to the original value. However, this could be 'dead' code and is never run. Might have just been lucky.
There are a few things in that code that don't make sense... right now (page miss!). Like line: https://github.com/Mindwerks/worldengine/blob/master/worldengine/simulations/erosion.py#L371
I'll give it an eye-over.

repo: Mindwerks/worldengine


text:
Question about control_primitives and control_primitives_context

There seem to be functions of the same name under the two folders, one folder is used for skill manager agent while the other is used for action agent, I'm wondering what is the reason two function implementations of the same name is needed? Could anyone help me understand?

Hi, thanks for your interest in this project! This is a trick we use to shorten the context:
The control_primitives refer to the actual functions that are executed on the JavaScript side. To provide the bot with environmental feedback, we incorporate multiple safeguards and chat messages.
On the other hand, the control_primitives_context contains functions that are displayed within GPT's context. They serve as examples for GPT on how to utilize the Mineflayer API and our control primitives. We don't want GPT to see those if...else safeguards.

You're awesome! @xieleo5 Thanks!

repo: MineDojo/Voyager