text:
Refactor to support other library checks

Would like to refactor the code to make it easier to drop in support for any new libraries for the availability check.
Making some kind of common interface, and storing various implementations in different modules would be one way others could contribute.
Having these modules might also include the ability to turn this into a dropdown, so we could support the selection of any arbitrary library within the application.

This PR starts a pattern for multiple libraries: https://github.com/MCBoarder289/shelf-help/pull/9

Merged https://github.com/MCBoarder289/shelf-help/pull/9
Any future libraries we want to add, we can address other refactors.

Merged https://github.com/MCBoarder289/shelf-help/pull/9
Any future libraries we want to add, we can address other refactors.


text:
set Dockerfile ENV DEBIAN_FRONTEND=noninteractive

This is needed for Ubuntu image to avoid asking to configure tzdata.
More info: https://askubuntu.com/questions/909277/avoiding-user-interaction-with-tzdata-when-installing-certbot-in-a-docker-contai
Closes #3

@MGenteluci Please have a look at this

source: gharchive/pull-request

authors: Shidil lucasfsousa

repo: MGenteluci/cloudformation-deploy-action

license: MIT

license_type: permissive

license_source: github-api


text:
glibc: Add ptest

Purpose of pull request
This PR adds ptest of glibc package based on the following recipe:

base recipe: meta/recipes-core/glibc/glibc_2.35.bb
base branch: kirkstone
base commit: f966e16c3bf59a4e174675e9e45518d5f14ada2d

Note
Tests of glibc depends on libgcc, and libgcc depends on glibc.
Therefore, it causes circular build-dependency between glibc and libgcc.
To avoid this circular build-dependency, test code of glibc is split out as "glibc-tests" recipe in current implementation.
As a result,

libgcc depends on glibc
glibc-tests depends on glibc,

and then glibc-tests is build-able.
This relationship is the same as that of dbus and dbus-test in meta-debian.
Test
How to test
1.Enable ptest and install glibc package
$ . ./repos/poky/oe-init-build-env build
$ bitbake-layers add-layer ../repos/meta-debian/
$ cat << EOS >> conf/local.conf
DISTRO = "deby"
MACHINE = "qemuarm64"
PACKAGE_CLASSES = "package_deb"
DISTRO_FEATURES_append = " ptest"
EXTRA_IMAGE_FEATURES += "ptest-pkgs"
IMAGE_INSTALL_append = " glibc"
EOS

2.Build core-image-minimal
$ bitbake core-image-minimal

3.Run qemu and execute ptest of glibc
$ runqemu nographic qemuparams="-m 1024"
...(snip)...
# ptest-runner -l
...(snip)...
# ptest-runner -t -1 glibc

Test result
ptest-run.sh
ptest-result-count.sh
# ptest-runner -l
Available ptests:
busybox /usr/lib/busybox/ptest/run-ptest
glibc   /usr/lib/glibc/ptest/run-ptest
util-linux      /usr/lib/util-linux/ptest/run-ptest
zlib    /usr/lib/zlib/ptest/run-ptest
# ptest-runner -t -1 glibc | tee glibc-ptest-1.log
START: ptest-runner
2023-12-27T05:03
BEGIN: /usr/lib/glibc/ptest
PASS: /usr/lib/glibc/ptest/tests/glibc-ptest/localedata/tst-langinfo-setlocale-static
PASS: /usr/lib/glibc/ptest/tests/glibc-ptest/localedata/tst-ctype
PASS: /usr/lib/glibc/ptest/tests/glibc-ptest/localedata/tst-langinfo-newlocale-static
...(snip)...
PASS: /usr/lib/glibc/ptest/tests/glibc-ptest/dirent/tst-scandir64
PASS: /usr/lib/glibc/ptest/tests/glibc-ptest/dirent/tst-seekdir
PASS: /usr/lib/glibc/ptest/tests/glibc-ptest/dirent/tst-fdopendir
DURATION: 1574
END: /usr/lib/glibc/ptest
2023-12-27T05:30
STOP: ptest-runner

ptest-glibc.log
Test summary

TOTAL: 1014

PASS:  820
SKIP:  5
XFAIL: 0
FAIL:  189
XPASS: 0
ERROR: 0

TOTAL: 1014

PASS:  819
SKIP:  5
XFAIL: 0
FAIL:  190
XPASS: 0
ERROR: 0

TOTAL: 1014

PASS:  820
SKIP:  5
XFAIL: 0
FAIL:  189
XPASS: 0
ERROR: 0

I executed this ptest 3 times and obtained the same results except the test timezone/tst-tzset.
Rationale of test flakieness
(TODO: Describe why)

PACKAGES += "${@bb.utils.contains('PTEST_ENABLED', '1', 'glibc-ptest', '', d)}"

についてですが、

inherit ptest

をしているので、ptest.bbclass側で

PACKAGES =+ "${@bb.utils.contains('PTEST_ENABLED', '1', '${PN}-ptest', '', d)}"

の機能が働くと思います。
glibc_debian.bbにinherit ptestしてdo_install_ptest等を直接書かずに、ファイルを分けて独自に処理した背景を教えてください。
何か不都合があって今の形になったと思うのですが、判断材料が足りません。

PACKAGES += "${@bb.utils.contains('PTEST_ENABLED', '1', 'glibc-ptest', '', d)}"

についてですが、

inherit ptest

をしているので、ptest.bbclass側で

PACKAGES =+ "${@bb.utils.contains('PTEST_ENABLED', '1', '${PN}-ptest', '', d)}"

の機能が働くと思います。 glibc_debian.bbにinherit ptestしてdo_install_ptest等を直接書かずに、ファイルを分けて独自に処理した背景を教えてください。　 何か不都合があって今の形になったと思うのですが、判断材料が足りません。

https://pdctj.slack.com/archives/C02G6TMHL0K/p1701413094206449
にあるように、glibc <-> libgcc で循環するからです。glibcのテストコードをビルドするには、libgccが必要です。

https://pdctj.slack.com/archives/C02G6TMHL0K/p1701413094206449
にあるように、glibc <-> libgcc で循環するからです。glibcのテストコードをビルドするには、libgccが必要です。

JIRAにも上記Slackの内容の転記と、それゆえに今の形になった旨を記載ください。

https://pdctj.slack.com/archives/C02G6TMHL0K/p1701413094206449
にあるように、glibc <-> libgcc で循環するからです。glibcのテストコードをビルドするには、libgccが必要です。

JIRAにも上記Slackの内容の転記と、それゆえに今の形になった旨を記載ください。

JIRAにも記載しました。

run-ptestの移植で少し改変してる部分については問題ないと思います。
その他は分離したptest用のレシピをビルドするための差分なので、動作していれば問題無いと思います。
PRの説明に以下の情報を加えてください。ひとまず3回実施して結果を見て欲しいです。

PASS/FAIL/その他の件数
実行する度にPASS/FAIL/その他の件数が変わるかどうか。
→変わる場合は原因解消が必要
FAILによってテスト全体が止まってしまうかどうか。
→止まる場合は原因解消が必要

meta-debianの動作確認はDISTRO="deby"で実施する必要があるとのことでしたので、再度ログを取り直しました。
2回目の実行でだけ  timezone/tst-tzset でFAILが出ていました。しかし、その後、数回実施してもFAILになりませんでした。おそらく実行中にテスト以外の要因でIO負荷が上がってIOエラーになったものと思われます。
再度3回実行して問題なければログとサマリーを差し替えるつもりです。
また、

glibc_debian.bbにinherit ptestしてdo_install_ptest等を直接書かずに、ファイルを分けて独自に処理した背景を教えてください。
何か不都合があって今の形になったと思うのですが、判断材料が足りません。

こちらについて、Note に記載しました。(JIRAはupstreamのレビューに使えないため)

再度3回実行して問題なければログとサマリーを差し替えるつもりです。

実行してログとサマリーを更新しました。
(リダイレクトを忘れてターミナルのバッファからログを作成したため、ログファイルが1つにまとまっていますがご容赦ください。)

meta-debianの最新版にrebaseした上で、SDKビルドが通ることを確認しました。
SDKビルドは以下の2パターンで確認しました。

meta-debianとpokyを使い、DISTRO=deby で bitbake core-image-minimal -c populate_sdk を実行
meta-debian, meta-debian-extended, meta-emlinux, pokyを使い、DISTRO=emlinux で bitbake core-image-minimal-sdk -c populate_sdk を実行

rebaseして https://github.com/ml-ichiro/meta-debian/pull/8 に移動済み

authors: ML-HirotakaFurukawa ksasaky soenos

repo: ML-HirotakaFurukawa/meta-debian


text:
Added navbar

Please, go through these steps before you submit a PR.

[x] My Pod Leader knows I'm working on this Pull Request
[x] I've explained what the Pull Request is adding.
[x] I've explained why this is important.

PR for #8

Looks nice!


text:
Wish: Provide Func<object, IHtmlString> overloads/extensions for methods taking an IHtmlString

For example, for Append, OverrideFieldHtml, InlineLabel and others it can be very useful to use the following:
s.FieldFor(p => p.Prop).OverrideFieldHtml(@Inline html here!)

The implementation is simple:
public IFieldConfiguration OverrideFieldHtml(this IFieldConfiguration src, Func<object,IHtmlString> genHtml) {
    return src.OverrideFieldHtml(genHtml(null));
}

Cool idea! More than happy to accept pull requests for this.

source: gharchive/issue

authors: fsateler robdmoore

repo: MRCollective/ChameleonForms


text:
Build script platform bug

Problem
The platform variable in scripts/build.js has a bad assignment.
referenced issue(s): n/a
Solution

Fix variable assignment
Script refactor to clean it up

Testing
npm run build

Bleh, looks like electron-packager supports and array of strings for the platform option: https://github.com/electron-userland/electron-packager/blob/master/docs/api.md#platform. This isn't a bug!

Hah: 615a5ef79a88efad916fb1d46456df1fac5735e7. It me.

I think 2cee50b5764b3c06caebfaa6b13cd0628a373f8f addressed this. According to electron-packager's 8.7.2 docs this should be valid.

repo: MRN-Code/coinstac

license: mit

license_source: bigquery


text:
AzurePrep: write list of things created to a file

Currently AzurePrep displays things it created (e.g. Stream Analytics policies) to the console and disappears after hitting Enter. Should also write to a text file on user desktop (and advise user of that). After list displayed and file created, should pause on screen with "Hit Enter to close".

Done at AzurePrepUpdates branch.

authors: dinarisio spyrossak

repo: MSOpenTech/connectthedots


text:
Missing image in the getting started guide

The getting started guide has a missing image.

Fixed

authors: BeatriceOltean avranju


text:
Network encryption plugin version 0.75

Needs #108 first.
As far as I found out, this version just uses SimpleModulus and no Xor32 encryption at all.

A plugin was added already.

I have to reopen the issue as I encountered a problem. I can’t decrypt the login packet with SimpleModulus. It’s 1 byte too small, so the content is not divisible by 11 :(
Even if I add a byte at the end, I get an invalid checksum and invalid block size in the first block.
I’ll have to review the keys and probably the algorithm isn’t exactly the same as in newer versions, too.

I have looked at the client side key files (Enc1.dat, Dec2.dat) and it’s very strange. Usually, they would be 54 bytes small. However, in the 0.75 client, they are 196 bytes long.
I‘ll test if the client would work with the normal-sized key files when I have more time.
If anyone else has an idea, please tell me ;)

I‘ll test if the client would work with the normal-sized key files when I have more time.

It doesn't work. The client closes automatically when logging in 👎

I think I have a small trace... There are 16 instead of 4 keys in the dat files. It seems like there are no blocks yet in this early version of SimpleModulus. That means, the encrypted content doesn’t need to be a multiple of 11 and don‘t include block checksums and lengths yet.

After some aha-moments, I finally understood what's different in SimpleModulus of version 0.75 from newer ones.
It does use blocks in 0.75 as well, but much bigger ones. One block is 32 decrypted and 38 encrypted bytes long.
One 16 bit-value needs 18 bits in encrypted state (because the multiplication result is bigger), so you can basically calculate the encrypted block size as follows:
blockSizeencrypted = (blockSizedecrypted * 18 / 16) + 2
The last two bytes are still block length and the checksum.
Another difference is, that the first byte of the packet content is not a counter. Webzen probably has added the counter in a later version to prevent replay attacks.

Fixed with merge of #114.

repo: MUnique/OpenMU


text:
Closes #1: Display fleet and airport info on dashboard home.

Also set up structures to display information for later iterations.

don't merge this yet

repo: MVCK/WackyFlights


text:
load and export not working after reader modifying

      Excel::load($path, function($reader) use ($data) {
            $reader->noHeading();
            $reader->skip(5);

        })->store('csv', storage_path('storage/files'));

i have above code , but it is not skipping data , just saving data as it is in csv . Please help me to resolve this.

skip is only for reading, not for manipulating the contents.
You can better read the file, manipulate the contents and create a new file that overwrites the current one.

authors: adnandogar patrickbrouwers

repo: Maatwebsite/Laravel-Excel


text:
import column header text is converted to lowercase

Hi,
How can I prevent that the column header text is converted to lowercase?
thx

just type uppercase to your table head
EXAMPLE
EXAMPLE
EXAMPLE
EXAMPLE

In your config->excel.php line 374 option 'heading'
change 'slugged' to 'original'

We are closing all old tickets, because version 2.* is reaching the End-of-Life stage. Our full attention is now allocated to version 3.0. It's still possible to use 2.*, but there will be no active support anymore.

authors: bpikaar disto muhghazaliakbar patrickbrouwers


text:
1020: Fixed Illegal Offset in HtmlReader.php

Added a check to see if borders[1] is empty -> if so, we skip all of the styling.
This fixes a fatal error with some versions of Bootstrap CSS.

Thanks :)

authors: patrickbrouwers steveeakin


text:
Cleanup

Format files according to cargo fmt
Fix errors reported by clippy

Perfect! Just in time for v6 :smile:
Thank you Teddy :heart:

Glad I can help 😄
Should we maybe adjust the workflows to fail if either one of these checks fails?

Should we maybe adjust the workflows to fail if either one of these checks fails?

Agreed, but I believe we should only fail if clippy throws a warning.

Agreed, but I believe we should only fail if clippy throws a warning.

Okay, can you elaborate why you don't want to fail for cargo fmt?

I don't think it's necessary, what are your thoughts?

I like a well formatted codebase and the Rust formatter does an excellent job of keeping it consistent.
Therefore I would turn it on as well and prevent cleanup commits like this one 😉

Seems reasonable, I'll get that going ASAP :)

authors: FantasyTeddy grtcdr

repo: Macchina-CLI/libmacchina


text:
Sending JAMF API credentials in "Files and Processes" exposes API credentials to client devices

Although the JAMF API credentials are saved to the keychain anyway, the API credentials are exposed to the client devices when Files and Processes are run with --jamf-account and --jamf-password. when running sudo jamf policy -v
Is it possible to send through a script and using the $4 and $5 variables instead and setting the script to run "after", or will this cause issues?

First, the fact that we have to save the API credentials to the System Keychain is the fundamental security problem here. Any local admin can simply view the saved API credentials at any time without knowing anything about the command line or Jamf. Please consider upvoting this Jamf feature request as a permanent solution to this problem.
That being said, you could certainly use an "after" script to start super instead of Files and Processes. I was just trying to keep the initial documentation short and simple. I'll consider this workflow for the eventual super wiki.

After much consideration and coding... super v2 will directly accept Jamf Parameters, so you won't have to use any intermediate script or Execute Command anymore.

Check out super v2.0-b1.
Now supports Jamf Pro Policy script Parameters.

authors: Luke-From-IT Macjutsu

repo: Macjutsu/super


text:
Automatic built releases

Hey @MadBomber. First off wanted to say thanks for working on a great project!
Appreciate you thinking about how to include other justfiles in a clean way that is usable right now!
I've been using it for a while now for my personal projects -- but some folks I have been talking with about justprep have a hard time to install it.
Would you be interested if I setup some automatic github actions to build binaries for folks (starting with the crystal one) whenever you cut a new release?
I would like to help out if possible, but first just :wink: wanted to check if that was something you would appreciate!
If not that is fine too. Appreciate your work!

@lutostag  great idea.  I have not taken the time to learn any of the actions/release features that GH offers.  Your idea is good.  How shall we proceed?

I am gonna try to follow along with the docs laid out at https://crystal-lang.org/reference/1.3/guides/ci/gh-actions.html in a fork, and can submit a PR if that is helpful.
Gonna see how far I get this weekend! Happy to chat/pair with you on it if you want -- I will be hanging around in the just discord at https://discord.gg/ezYScXR

I think I got it working with #6 -- but happy to chat with you on any questions you might have (either in this thread or PR or channel above). Or if its not something you are interested in that is fine as well.
Thanks again for a great project! Appreciate your work on making justfiles easier to compose!

Greg I am away on a short family road trip. I will be back home later tonight will catch up with you then. Thank you for taking on this enhancement.
Dewayne
o-*

On Mar 19, 2022, at 12:19 PM, Greg Lutostanski @.***> wrote:

I think I got it working with #6 -- but happy to chat with you on any questions you might have (either in this thread or PR or channel above). Or if its not something you are interested in that is fine as well.
Thanks again for a great project! Appreciate your work on making justfiles easier to compose!
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.

Greg I merged the release then  updated the README file and bumped the version number.

I see that the workflow ran after I manually told github to build a release but I do not see the links anywhere to download the binary.

The links are in the "assets" section of the release at the bottom.

They should run automatically whenever you add a new git tag. I'm also looking into seeing if I can add it via a homebrew tap -- but not sure how feasible it is. Haven't written a formula for brew before.
I appreciate the merge! Does it work like you would want? I could also try writing up some more in the README too if that would be helpful.

https://github.com/lutostag/justprep/releases/latest
Should be the link to the latest "release" where the binaries can be found in the assets section.

authors: MadBomber lutostag

repo: MadBomber/justprep


text:
jacoco-report can't find defined token

I'm integrating jacoco-report for the first time and have run into a problem that I can't figure out. It's probably something obvious that I've missed.
I've included the jacoco-report block of my workflow below. When this block runs, the workflow fails and give the following error:

Error: Error: Parameter token or opts.auth is required

Here's the full error for context:
Run madrapps/jacoco-report@v1.4
  with:
    paths: /home/runner/work/consumer-mobile-app-android/consumer-mobile-app-android/FooApp/app/build/coverage-report/report-release.xml
    min-coverage-overall: 40
    min-coverage-changed-files: 60
    update-comment: false
    debug-mode: false
  env:
    BUNDLE_GEMFILE: /home/runner/work/consumer-mobile-app-android/consumer-mobile-app-android/FooApp/Gemfile
    JAVA_HOME: /opt/hostedtoolcache/Java_Corretto_jdk/11.0.19.7.1/x64
    JAVA_HOME_11_X64: /opt/hostedtoolcache/Java_Corretto_jdk/11.0.19.7.1/x64
    GRADLE_BUILD_ACTION_SETUP_COMPLETED: true
    GRADLE_BUILD_ACTION_CACHE_RESTORED: true
Event is pull_request_target
base sha: b3576e4665e4f25c03344d7388599dbbf90f6294
head sha: f4984029b7787a3b53f89da6e1cd9f8b1ff703e6
Error: Error: Parameter token or opts.auth is required
##[debug]Node Action run completed with exit code 1
##[debug]Finishing: Add coverage to PR

Does anyone have an idea what I'm missing?
      - name: 📝 Add coverage to PR
        id: jacoco
        uses: madrapps/jacoco-report@v1.4
        with:
          paths: ${{ github.workspace }}/FooApp/app/build/coverage-report/report-release.xml
          token: ${{ secrets.GITHUB_TOKEN }}
          min-coverage-overall: 40
          min-coverage-changed-files: 60
          debug-mode: true

@dnedrow Is this your own repository or a forked one?
The logs should have token: ***. My guess is the ${{ secrets.GITHUB_TOKEN }} doesn't resolve correctly. If this is indeed not a fork repository, then could you try creating a custom token with write permission and try with that?

authors: dnedrow thsaravana

repo: Madrapps/jacoco-report


text:
🛑 Nitter (nitter.net) is down

In 80bfa14, Nitter (nitter.net) (https://nitter.net) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Nitter (nitter.net) is back up in be96b30.

repo: Magic-Services/upptime


text:
🛑 Nitter (nitter.net) is down

In fdb3b3a, Nitter (nitter.net) (https://nitter.net) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Nitter (nitter.net) is back up in a377f32.


text:
🛑 Nitter (nitter.net) is down

In 59ba30c, Nitter (nitter.net) (https://nitter.net) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Nitter (nitter.net) is back up in 63e5eee.


text:
🛑 Libreddit (libreddit.spike.codes) is down

In 634a418, Libreddit (libreddit.spike.codes) (https://libreddit.spike.codes) was down:

HTTP code: 502
Response time: 22337 ms

Resolved: Libreddit (libreddit.spike.codes) is back up in 3de4d3c.


text:
🛑 Libreddit (libreddit.spike.codes) is down

In d248b49, Libreddit (libreddit.spike.codes) (https://libreddit.spike.codes) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Libreddit (libreddit.spike.codes) is back up in f4e16f2.


text:
🛑 Libreddit (libreddit.spike.codes) is down

In 4914a47, Libreddit (libreddit.spike.codes) (https://libreddit.spike.codes) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Libreddit (libreddit.spike.codes) is back up in bbc8056 after 595 days, 12 hours, 46 minutes.


text:
🛑 Libreddit (libreddit.spike.codes) is down

In 0156385, Libreddit (libreddit.spike.codes) (https://libreddit.spike.codes) was down:

HTTP code: 502
Response time: 19707 ms

Resolved: Libreddit (libreddit.spike.codes) is back up in dfa3f29 after 58 minutes.


text:
🛑 Nextcloud (semi-public instance) is down

In c634a2e, Nextcloud (semi-public instance) ($NC_SEMI_PUBLIC) was down:

HTTP code: 503
Response time: 868 ms

Resolved: Nextcloud (semi-public instance) is back up in c7d999d after 12 minutes.


text:
🛑 MagicLike is down

In e776828, MagicLike (https://magiclike.net) was down:

HTTP code: 0
Response time: 0 ms

Resolved: MagicLike is back up in 013661f after 11 minutes.


text:
MessageDialog not inheriting dynamically assigned accent

Hi,
When I use MetroWindow.ShowMessageAsync with a statically loaded ressource dict (red for example) it works great and inherits the accent from parent window. When loading it programatically, e.g parsing it from settings or giving user choice to change accents, it gives this all the time (note the different accents: blue in the dialog, and green in the form)

Is it a bug, or me missing something ?
Thank you !

I've figured it out on my own, found a workaround. I had to call ChangeAppStyle like this:
ThemeManager.ChangeAppStyle(Application.Current.Resources, ThemeManager.GetAccent(_col), ThemeManager.GetAppTheme(color));
It didn't work, so I had to add the accent and the theme to the app.xaml.
<ResourceDictionary Source="pack://application:,,,/MahApps.Metro;component/Styles/Accents/Cobalt.xaml" /> <ResourceDictionary Source="pack://application:,,,/MahApps.Metro;component/Styles/Accents/BaseLight.xaml" />
There is an another issue, when none of those dicts is statically loaded, DetectAppStyle can return null, and cause bugs later. I'll try to make a patch later.
Thanks for the superb library anyway !

@TayebJa3ba

when none of those dicts is statically loaded

in the readme and the doku is described how to use the resource dictionaries, and this is a must!


text:
[WIP] Ribbon menu support

@punker76 Fixed pop up issue and code cleanup.
@kiangtengl Styled the ribbon button, split button, menu button and radio button.
@Tide Made changes to the ribbon demo and merged in latest master.

:+1: Would love to see this released.

@petersondrew i dont think that we finish this, but as alternative you can use this cool lib that also understands MahApps https://fluent.codeplex.com/

putting the new GitHub link to Fluent.Ribbon here for travellers from the future.

@CADbloke :+1:

authors: CADbloke Tide petersondrew punker76


text:
Requirements Packages are Outdated

pip install -r requirements.txt causes several failures when setting up with venv. Have not tested conda env. Recommend modifying requirements to the following to solve dependency related issues:
wget
cython
wheel
onnx
cmake
nemo_toolkit
faster-whisper
git+https://github.com/m-bain/whisperX.git@4cb167a225c0ebaea127fd6049abfaa3af9f8bb4
git+https://github.com/facebookresearch/demucs#egg=demucs
deepmultilingualpunctuation
I'm still unable to get audio to work as I keep getting modulenotfound errors for wget which I have not solved despite quite a bit of troubleshooting against it.

cython should be installed before the requirements as mentioned in the instructions
wheel, cmake are either installed along with pip or are bundled with almost all OS installations nowadays so no need to include them
as for onnx I never stumbled upon a use case where it's required

yeah i just started manually adding libraries that were causing hangs when establishing the venv and this combination seemed to get past it hence the recommendation

Helped me get things going on debian 12 venv. Thank you.

I am also running into this issue. Tried following another thread, #73 Fix Cython 3.0.0 brokes PyYAML==5.4.1 (from NeMo requirements) but I haven't had any luck over there either.

Just want to add that install fails on WSL unless you use python 3.10.12 per the nemo installer.

authors: Barron-Brock MahmoudAshraf97 dahifi mrgreyigogg ricklearns


text:
Suggestion : Afficher les trains sans arrêt

L'app a beau être fiable, j'ai toujours une petite sueur froide en voyant un train passer quand je suis encore à 600m de la gare haha, ça serait bien que Navika affiche les trains sans arrêt, je trouve.

Pour les trains de la SNCF, j'ai rajouté une vérification pour masquer les trains sans arrêts. Mais pour les autre opérateur, les trains sans arrêts ne sont pas présent dans les données.  :/
Et si j'ajoute les trains sans arrêts, il faut également voir pour les différencier d'un clin d’œil dans l'appli.

authors: Kalytis MaisClement


text:
🛑 Open Weather API is down

In d1141c8, Open Weather API (https://api.openweathermap.org/data/2.5/uvi?appid=$API_OPEN_WEATHER&lat=52.370216&lon=4.895168) was down:

HTTP code: 504
Response time: 827 ms

Resolved: Open Weather API is back up in 0d663ca.

repo: MamonakuCommittee/status


text:
🛑 Open Weather API is down

In 4f28402, Open Weather API (https://api.openweathermap.org/data/2.5/uvi?appid=$API_OPEN_WEATHER&lat=52.370216&lon=4.895168) was down:

HTTP code: 504
Response time: 1143 ms

Resolved: Open Weather API is back up in 165a846 after 16 minutes.


text:
Traceback during openshift refresh

Traceback
[----] E, [2017-02-23T05:19:50.309663 #6901:beb130] ERROR -- : MIQ(ManageIQ::Providers::OpenshiftEnterprise::ContainerManager::Refresher#refresh) EMS: [XXX XXXX], id: [10000000000001] Refresh failed
[----] E, [2017-02-23T05:19:50.327868 #6901:beb130] ERROR -- : [NoMethodError]: undefined method `state' for nil:NilClass  Method:[rescue in block in refresh]
[----] E, [2017-02-23T05:19:50.331315 #6901:beb130] ERROR -- : /opt/rh/cfme-gemset/gems/activerecord-5.0.0.1/lib/active_record/connection_adapters/abstract/transaction.rb:204:in `rescue in ensure in within_new_transaction'
/opt/rh/cfme-gemset/gems/activerecord-5.0.0.1/lib/active_record/connection_adapters/abstract/transaction.rb:201:in `ensure in within_new_transaction'
/opt/rh/cfme-gemset/gems/activerecord-5.0.0.1/lib/active_record/connection_adapters/abstract/transaction.rb:201:in `within_new_transaction'
/opt/rh/cfme-gemset/gems/activerecord-5.0.0.1/lib/active_record/connection_adapters/abstract/database_statements.rb:232:in `transaction'
/opt/rh/cfme-gemset/gems/activerecord-5.0.0.1/lib/active_record/transactions.rb:211:in `transaction'
/opt/rh/cfme-gemset/gems/activerecord-5.0.0.1/lib/active_record/transactions.rb:392:in `with_transaction_returning_status'
/opt/rh/cfme-gemset/gems/activerecord-5.0.0.1/lib/active_record/persistence.rb:277:in `update!'
/var/www/miq/vmdb/app/models/ems_refresh/save_inventory_helper.rb:92:in `save_inventory_with_findkey'
/var/www/miq/vmdb/app/models/ems_refresh/save_inventory_helper.rb:53:in `block in save_inventory_multi'
/var/www/miq/vmdb/app/models/ems_refresh/save_inventory_helper.rb:52:in `each'
/var/www/miq/vmdb/app/models/ems_refresh/save_inventory_helper.rb:52:in `save_inventory_multi'
/var/www/miq/vmdb/app/models/ems_refresh/save_inventory_container.rb:408:in `save_custom_attribute_attribute_inventory'
/var/www/miq/vmdb/app/models/ems_refresh/save_inventory_container.rb:419:in `save_docker_labels_inventory'
/var/www/miq/vmdb/app/models/ems_refresh/save_inventory_helper.rb:107:in `block in save_child_inventory'
/var/www/miq/vmdb/app/models/ems_refresh/save_inventory_helper.rb:107:in `each'
/var/www/miq/vmdb/app/models/ems_refresh/save_inventory_helper.rb:107:in `save_child_inventory'
/var/www/miq/vmdb/app/models/ems_refresh/save_inventory_helper.rb:54:in `block in save_inventory_multi'
/var/www/miq/vmdb/app/models/ems_refresh/save_inventory_helper.rb:52:in `each'
/var/www/miq/vmdb/app/models/ems_refresh/save_inventory_helper.rb:52:in `save_inventory_multi'
/var/www/miq/vmdb/app/models/ems_refresh/save_inventory_container.rb:318:in `save_container_images_inventory'
/var/www/miq/vmdb/app/models/ems_refresh/save_inventory_container.rb:13:in `block in save_ems_container_inventory'
/var/www/miq/vmdb/app/models/ems_refresh/save_inventory_container.rb:12:in `each'
/var/www/miq/vmdb/app/models/ems_refresh/save_inventory_container.rb:12:in `save_ems_container_inventory'
/var/www/miq/vmdb/app/models/ems_refresh/save_inventory.rb:7:in `save_ems_inventory'
/var/www/miq/vmdb/app/models/ems_refresh/refreshers/ems_refresher_mixin.rb:127:in `save_inventory'
/var/www/miq/vmdb/app/models/ems_refresh/refreshers/ems_refresher_mixin.rb:91:in `block in refresh_targets_for_ems'
/var/www/miq/vmdb/gems/pending/util/extensions/miq-benchmark.rb:11:in `realtime_store'
/var/www/miq/vmdb/gems/pending/util/extensions/miq-benchmark.rb:30:in `realtime_block'
/var/www/miq/vmdb/app/models/ems_refresh/refreshers/ems_refresher_mixin.rb:91:in `refresh_targets_for_ems'
/var/www/miq/vmdb/app/models/ems_refresh/refreshers/ems_refresher_mixin.rb:24:in `block (2 levels) in refresh'
/var/www/miq/vmdb/gems/pending/util/extensions/miq-benchmark.rb:11:in `realtime_store'
/var/www/miq/vmdb/gems/pending/util/extensions/miq-benchmark.rb:30:in `realtime_block'
/var/www/miq/vmdb/app/models/ems_refresh/refreshers/ems_refresher_mixin.rb:24:in `block in refresh'
/var/www/miq/vmdb/app/models/ems_refresh/refreshers/ems_refresher_mixin.rb:14:in `each'
/var/www/miq/vmdb/app/models/ems_refresh/refreshers/ems_refresher_mixin.rb:14:in `refresh'
/var/www/miq/vmdb/app/models/manageiq/providers/base_manager/refresher.rb:10:in `refresh'
/var/www/miq/vmdb/app/models/ems_refresh.rb:91:in `block in refresh'
/var/www/miq/vmdb/app/models/ems_refresh.rb:90:in `each'
/var/www/miq/vmdb/app/models/ems_refresh.rb:90:in `refresh'
/var/www/miq/vmdb/app/models/miq_queue.rb:347:in `block in deliver'
/opt/rh/rh-ruby23/root/usr/share/ruby/timeout.rb:91:in `block in timeout'
/opt/rh/rh-ruby23/root/usr/share/ruby/timeout.rb:33:in `block in catch'
/opt/rh/rh-ruby23/root/usr/share/ruby/timeout.rb:33:in `catch'
/opt/rh/rh-ruby23/root/usr/share/ruby/timeout.rb:33:in `catch'
/opt/rh/rh-ruby23/root/usr/share/ruby/timeout.rb:106:in `timeout'
/var/www/miq/vmdb/app/models/miq_queue.rb:343:in `deliver'
/var/www/miq/vmdb/app/models/miq_queue_worker_base/runner.rb:106:in `deliver_queue_message'
/var/www/miq/vmdb/app/models/miq_queue_worker_base/runner.rb:134:in `deliver_message'
/var/www/miq/vmdb/app/models/miq_queue_worker_base/runner.rb:152:in `block in do_work'
/var/www/miq/vmdb/app/models/miq_queue_worker_base/runner.rb:146:in `loop'
/var/www/miq/vmdb/app/models/miq_queue_worker_base/runner.rb:146:in `do_work'
/var/www/miq/vmdb/app/models/miq_worker/runner.rb:334:in `block in do_work_loop'
/var/www/miq/vmdb/app/models/miq_worker/runner.rb:331:in `loop'
/var/www/miq/vmdb/app/models/miq_worker/runner.rb:331:in `do_work_loop'
/var/www/miq/vmdb/app/models/miq_worker/runner.rb:153:in `run'
/var/www/miq/vmdb/app/models/miq_worker/runner.rb:128:in `start'
/var/www/miq/vmdb/app/models/miq_worker/runner.rb:21:in `start_worker'
/var/www/miq/vmdb/app/models/miq_worker.rb:343:in `block in start'
/opt/rh/cfme-gemset/gems/nakayoshi_fork-0.0.3/lib/nakayoshi_fork.rb:24:in `fork'
/opt/rh/cfme-gemset/gems/nakayoshi_fork-0.0.3/lib/nakayoshi_fork.rb:24:in `fork'
/var/www/miq/vmdb/app/models/miq_worker.rb:341:in `start'
/var/www/miq/vmdb/app/models/miq_worker.rb:270:in `start_worker'
/var/www/miq/vmdb/app/models/mixins/per_ems_worker_mixin.rb:68:in `start_worker_for_ems'
/var/www/miq/vmdb/app/models/mixins/per_ems_worker_mixin.rb:46:in `block in sync_workers'
/var/www/miq/vmdb/app/models/mixins/per_ems_worker_mixin.rb:45:in `each'
/var/www/miq/vmdb/app/models/mixins/per_ems_worker_mixin.rb:45:in `sync_workers'
/var/www/miq/vmdb/app/models/miq_server/worker_management/monitor.rb:52:in `block in sync_workers'
/var/www/miq/vmdb/app/models/miq_server/worker_management/monitor.rb:50:in `each'
/var/www/miq/vmdb/app/models/miq_server/worker_management/monitor.rb:50:in `sync_workers'
/var/www/miq/vmdb/app/models/miq_server/worker_management/monitor.rb:22:in `monitor_workers'
/var/www/miq/vmdb/app/models/miq_server.rb:346:in `block in monitor'
/var/www/miq/vmdb/gems/pending/util/extensions/miq-benchmark.rb:11:in `realtime_store'
/var/www/miq/vmdb/gems/pending/util/extensions/miq-benchmark.rb:30:in `realtime_block'
/var/www/miq/vmdb/app/models/miq_server.rb:346:in `monitor'
/var/www/miq/vmdb/app/models/miq_server.rb:368:in `block (2 levels) in monitor_loop'
/var/www/miq/vmdb/gems/pending/util/extensions/miq-benchmark.rb:11:in `realtime_store'
/var/www/miq/vmdb/gems/pending/util/extensions/miq-benchmark.rb:30:in `realtime_block'
/var/www/miq/vmdb/app/models/miq_server.rb:368:in `block in monitor_loop'
/var/www/miq/vmdb/app/models/miq_server.rb:367:in `loop'
/var/www/miq/vmdb/app/models/miq_server.rb:367:in `monitor_loop'
/var/www/miq/vmdb/app/models/miq_server.rb:250:in `start'
/var/www/miq/vmdb/lib/workers/evm_server.rb:65:in `start'
/var/www/miq/vmdb/lib/workers/evm_server.rb:92:in `start'
/var/www/miq/vmdb/lib/workers/bin/evm_server.rb:4:in `<main>'
[----] E, [2017-02-23T05:19:50.331404 #6901:beb130] ERROR -- : MIQ(ManageIQ::Providers::OpenshiftEnterprise::ContainerManager::Refresher#refresh) EMS: [XXX XXXX], id: [10000000000001] Unable to perform refresh for the following targets:
[----] E, [2017-02-23T05:19:50.332422 #6901:beb130] ERROR -- : MIQ(ManageIQ::Providers::OpenshiftEnterprise::ContainerManager::Refresher#refresh)  --- ManageIQ::Providers::OpenshiftEnterprise::ContainerManager [XXX XXXX] id [1000000000000
WARNING:  there is already a transaction in progress

More info TBD.

https://github.com/rails/rails/pull/28360

@jrafanie I'm wondering if a timeout / kill would be causing this issue.

wow, I have no idea @kbrock

hmm, WARNING:  there is already a transaction in progress is that from the same process?  Could this be an exception raised in a nested transaction?

Also, https://bugzilla.redhat.com/show_bug.cgi?id=1427688 is the same exception

@jrafanie I think the warning comes from the fact that the timeout prevents the connection from being properly closed. so the next transaction gets confused.
Timeout.timeout is very dangerous :(

This traceback/issue is the same reported in bug https://bugzilla.redhat.com/show_bug.cgi?id=1427688
So far not specific to OpenShift.
@miq-bot assign gtanzillo
cc @chessbyte

I just pinged rails team again on this one

ref: https://github.com/rails/rails/pull/28360

authors: isimluk jrafanie kbrock simon3z

repo: ManageIQ/manageiq


text:
Unstyled selects in Button editing form

Tested on an upstream build from Aug 10th.
When adding or editing a button, the fields Display for and Submit have unstyled select tags.

@mfalesni please open an [UPSTREAM] BZ for this if not done already.

authors: dclarizio mfalesni


text:
Rails4 regression in MiqReport

in app/models/miq_report_result.rb we have:
  def report
    val = read_attribute(:report)
    val.nil? ? nil : val.first
  end

  def report=(val)
    write_attribute(:report, val.nil? ? nil : [val])
  end

this seems to be causing:
[----] I, [2015-06-18T14:40:56.348236 #15377:4cfe78]  INFO -- : Completed 200 OK in 559ms (Views: 0.3ms | ActiveRecord: 5.7ms)
[----] I, [2015-06-18T14:40:59.985088 #15377:4cfe78]  INFO -- : Started POST "/report/tree_select/?id=rr-10r744" for 127.0.0.1 at 2015-06-18 14:40:59 +0200
[----] I, [2015-06-18T14:41:00.129988 #15377:4cfe78]  INFO -- : Processing by ReportController#tree_select as JS
[----] I, [2015-06-18T14:41:00.130208 #15377:4cfe78]  INFO -- :   Parameters: {"id"=>"rr-10r744"}
[----] F, [2015-06-18T14:41:00.192330 #15377:4cfe78] FATAL -- : Error caught: [NoMethodError] undefined method `fetch_value' for #<Hash:0x0000000cf7b550>
/home/martin/.rvm/gems/ruby-2.0.0-p645@cfme/bundler/gems/rails-db89410f3d77/activerecord/lib/active_record/attribute_methods/read.rb:93:in `_read_attribute'
/home/martin/.rvm/gems/ruby-2.0.0-p645@cfme/bundler/gems/rails-db89410f3d77/activerecord/lib/active_record/attribute_methods.rb:50:in `__temp__e616d656'
/home/martin/Projects/manageiq/vmdb/app/controllers/application_controller.rb:797:in `report_first_page'
/home/martin/Projects/manageiq/vmdb/app/controllers/report_controller/saved_reports.rb:54:in `fetch_saved_report'
/home/martin/Projects/manageiq/vmdb/app/controllers/report_controller/saved_reports.rb:17:in `show_saved_report'
/home/martin/Projects/manageiq/vmdb/app/controllers/report_controller.rb:457:in `determine_rr_node_info'
/home/martin/Projects/manageiq/vmdb/app/controllers/report_controller.rb:554:in `get_node_info'
/home/martin/Projects/manageiq/vmdb/app/controllers/report_controller.rb:668:in `replace_right_cell'
/home/martin/Projects/manageiq/vmdb/app/controllers/report_controller.rb:254:in `tree_select'

When accessing generated reports. Cloud Inteligence ---> Reports --> Saved Reports ---> select a report ---> select a saved generated report ---> bang!

@tenderlove Can you look at this one?

@martinpovolny what's the best way to get reports seeded in the database?  I think this might be an AR bug (the method doesn't look like it's doing anything wrong).

@tenderlove rake db:seed gets the reports in.  If you want report results you have to run a report.  Might be easier to just get a populated database.

@tenderlove : you should have some "built-in" reports, you only need to have them generated (report results). You can do that by finding that particular report in the Reports tree and clicking on Schedule report. You need to have some workers running for that (if you are in dev setup). Or you can simulate the workers by running simulate_queue_worker from the rails c.
I keep a populated database that I got from Dan or Xav and I keep updating it as I move forward. Ping on IRC, I'll give you a link if you want.

I rake db:seeded once, but it doesn't seem to make reports that have results.  I'll try simulate_queue_worker.  If that doesn't work, I'll ping you on IRC!

We should fix this long term by not serializing AR objects as YAML.  Here is a patch that will "fix" the records when they are read:
diff --git a/vmdb/app/models/miq_report_result.rb b/vmdb/app/models/miq_report_result.rb
index 9d3e1c1..d07b8b4 100644
--- a/vmdb/app/models/miq_report_result.rb
+++ b/vmdb/app/models/miq_report_result.rb
@@ -109,7 +109,25 @@ class MiqReportResult < ActiveRecord::Base
   # => "records are quoted as their primary key"
   def report
     val = read_attribute(:report)
-    val.nil? ? nil : val.first
+
+    return unless val
+
+    val = val.first
+
+    if val.instance_variable_get(:@attributes).is_a? Hash
+      new_report = val.class.new
+      val.instance_variable_get(:@attributes).each_pair do |k,v|
+        new_report.send :write_attribute, k, v
+      end
+      self.send(:original_raw_attributes)[:report] = [new_report]
+      self.send :raw_write_attribute, :report, [new_report]
+      self.report = new_report
+      report_will_change!
+      save
+      new_report
+    else
+      val
+    end
   end

   def report=(val)

I'm not sure if that's the way we should go.  Maybe we should do this in a migration instead.  It doesn't fix the fundamental problem of us storing AR objects as YAML, but it does eliminate the exception that @martinpovolny is seeing.

We should check for more places like this. Ping @Fryguy ?
I would agree that we should fix the content of the column in a migration.
As for general problem of storing AR object in YAML: we should probably create a technical debt issue and track all the places where we have this issue.

Just to summarize what the problem is (so that I don't forget), we have AR objects being serialized as YAML in the database.  These objects were serialized on Rails 3.2.  The internals of AR objects have changed (one change is that @attributes is no longer a hash).  When we deserialize the attributes from the database, the internal state doesn't work with the internals of ActiveRecord on 4.2.
To test this, I had to import some old data, then I ran a script like this:
$ bundle exec rails r 'MiqReportResult.transaction { MiqReportResult.where("report is not null").each { |x| p x.report.name }; raise }'

I've been looking at this. I have a migration that will convert the serialized objects to plain hashes with the corresponding code in the model to store and retrieve them in that form. However, there's another place where this is being done that also needs to be addressed. The other place is where we save the instance of an executed report and the Ruport results in  a binary blob. It also deserializes the entire thing there resulting in the same error. I'm looking into how to deal with that as well.

I moved this onto @gtanzillo's plate since he has a bunch of code in this direction already to fix it "for good"

@martinpovolny now that we are on Rails 5, is this still a valid issue?

I'd say we can close this.

authors: Fryguy chessbyte gtanzillo martinpovolny tenderlove


text:
Add missing policy buttons to Network Manager Relationship pages

fixing https://bugzilla.redhat.com/show_bug.cgi?id=1347223
Add missing policy buttons to some of the Relationship pages to enable
tagging more items at once when managing a cloud provider in Compute ->
-> Clouds -> Provider.
Before:

After:

@miq-bot add_label ui,bug

@miq-bot add_label wip

@miq-bot remove_label wip

@hstastna When I navigate to Network -> Network ports -> [some network port] -> Cloud subnets
and from the list view I select a cloud subnet and hit the tagging button, I get an error flash:

Similar behavior can be seen in other submenus (security groups -> network port for example).

@mzazrivec btw. this is darga/yes https://bugzilla.redhat.com/show_bug.cgi?id=1352016 , Hilda should be probably assigned to that BZ as well?

So I tested this and I can now set tags on children of cloud providers, so I'm merging it.  I will be opening another issue I've found during testing where some object classes don't allow an advanced search to specify direct tags to the main object, only tags for related objects.

Darga Backport conflict:
$ git cherry-pick -x -m 1 35bfb21
error: could not apply 35bfb21... Merge pull request #10584 from hstastna/Policy_button_on_manager_relationships
hint: after resolving the conflicts, mark the corrected paths
hint: with 'git add <paths>' or 'git rm <paths>'
hint: and commit the result with 'git commit'

$ git status
On branch darga
Your branch is up-to-date with 'upstream/darga'.
You are currently cherry-picking commit 35bfb21.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:

        modified:   app/controllers/ems_common.rb
        modified:   app/controllers/mixins/generic_button_mixin.rb

Unmerged paths:
  (use "git add <file>..." to mark resolution)

        both modified:   app/helpers/application_helper/toolbar_chooser.rb

$ git diff

diff --cc app/helpers/application_helper/toolbar_chooser.rb
index 2beb38e,cfbd2b7..0000000
--- a/app/helpers/application_helper/toolbar_chooser.rb
+++ b/app/helpers/application_helper/toolbar_chooser.rb
@@@ -431,17 -431,17 +431,21 @@@ class ApplicationHelper::ToolbarChoose

    # Return non-explorer based toolbar file name
    def center_toolbar_filename_classic
 -    return "#{@center_toolbar}_center_tb" if @center_toolbar
 -
      # Original non vmx view code follows
      # toolbar buttons on sub-screens
++<<<<<<< HEAD
 +    if ((@lastaction == "show" && @view) ||
 +        (@lastaction == "show" && @display != "main")) &&
 +       !@layout.starts_with?("miq_request")
++=======
+     to_display = %w(availability_zones cloud_networks cloud_object_store_containers cloud_subnets
+                     cloud_tenants cloud_volumes ems_clusters flavors floating_ips hosts load_balancers
+                     network_ports network_routers orchestration_stacks resource_pools security_groups storages)
+     to_display_center = %w(stack_orchestration_template topology)
+     if @lastaction == 'show' && (@view || @display != 'main') && !@layout.starts_with?("miq_request")
++>>>>>>> 35bfb21... Merge pull request #10584 from hstastna/Policy_button_on_manager_relationships
        if @display == "vms" || @display == "all_vms"
          return "vm_infras_center_tb"
-       elsif @display == "ems_clusters"
-         return "ems_clusters_center_tb"
-       elsif @display == "hosts"
-         return "hosts_center_tb"
        elsif @display == "images"
          return "template_clouds_center_tb"
        elsif @display == "instances"
@@@ -458,7 -452,13 +456,14 @@@
          return "#{@explorer ? "x_" : ""}vm_performance_tb"
        elsif @display == "dashboard"
          return "#{@layout}_center_tb"
++<<<<<<< HEAD
++=======
+       elsif to_display.include?(@display)
+         return "#{@display}_center_tb"
+       elsif to_display_center.include?(@display)
+         return "#{@display}_center"
++>>>>>>> 35bfb21... Merge pull request #10584 from hstastna/Policy_button_on_manager_relationships
        end
 -    elsif @lastaction == "arbitration_profiles"
 -      return @showtype == "item" ? "arbitration_profile_center_tb" : "arbitration_profiles_center_tb"
      elsif @lastaction == "compare_miq" || @lastaction == "compare_compress"
        return "compare_center_tb"
      elsif @lastaction == "drift_history"

@hstastna Please run the same cherry-pick command locally, resolve conflicts, validate, and make a Darga PR from it.

I will be opening another issue I've found during testing where some object classes don't allow an advanced search to specify direct tags to the main object, only tags for related objects.

BZ opened here https://bugzilla.redhat.com/show_bug.cgi?id=1372442 as this exists in Darga as well

Backported to Darga via #11013
$ git log

commit 353d122e1656d4b5dfaf25b7292add5ef354a544
Merge: 5552222 bd8019e
Author: Oleg Barenboim <chessbyte@gmail.com>
Date:   Mon Sep 5 15:37:17 2016 -0500

    Merge pull request #11013 from hstastna/DARGA_Policy_button_on_manager_relationships

    [DARGA] Add missing policy buttons to Network Manager Relationship pages

commit bd8019ebec6859639ef0475fa06fb6815d930d6f
Author: Hilda Stastna <hstastna@redhat.com>
Date:   Thu Aug 25 17:15:34 2016 +0200

    Fix policy buttons on Network Managers pages

    fixing https://bugzilla.redhat.com/show_bug.cgi?id=1347223

    Fix policy buttons on some of the Network Managers pages
    to enable tagging more items at one when reaching
    Networks -> Providers/Networks/Subnets/etc.

    (cherry picked from commit 207f6a4fe1b79d13c31a12c3e68b92f6b59f87bb)

commit d7731f223d7f4aa76cb87f955917662f1cd4949d
Author: Hilda Stastna <hstastna@redhat.com>
Date:   Mon Aug 22 15:52:12 2016 +0200

    Add missing policy buttons to Network Manager Relationship pages

    fixing https://bugzilla.redhat.com/show_bug.cgi?id=1347223

    Add missing policy buttons to some of the Relationship pages to enable
    tagging more items at once when managing a cloud provider in Compute ->
    -> Clouds -> Provider.

    (cherry picked from commit 0f0c28e925be8a1e56849731f18b24e055177cbc)

commit 9c56dde2edb26df4b05425d3a05db466bd84d4f7
Author: Hilda Stastna <hstastna@redhat.com>
Date:   Thu Aug 18 15:05:07 2016 +0200

    Refactor ems_common controller and toolbar_chooser

    Refactor ems_common.rb controller in app/controllers
    and toolbar_chooser.rb in app/helpers/application_helper
    to prepare the code for adding missing policy buttons
    to some of the Network Manager Relationship pages
    when managing a cloud provider.

    (cherry picked from commit 211a47e0f643b14d32691ab240a94db163a69c00)

authors: Ladas chessbyte dclarizio hstastna mzazrivec


text:
Fix a spec that was failing when the database was using region 0

The issue was that deleting a subscription removes all data which belongs in that region. This included the region record that we were using to test if the authentication was removed.
Instead we can just grab the authentication id and make sure that record is removed.
@gtanzillo please review
/cc @d-m-u @kbrock This was the failure we were talking about here

Whoa thanks, this is cool!

@chessbyte I added an additional commit that changes some of the details around what region the subscriptions under test actually refer to. It also changes the id of the region record we use for the test to not be in the currently configured region.
I hope this clears up some of the confusion around how this all works by making these specs align more explicitly with how it would work in a real installation.
I feel like the spec itself is fairly clear, it relates an authentication record to the region and when the subscription associated with that region is removed, so is the authentication record.

:+1: LGTM

👍 LGTM

authors: carbonin d-m-u gtanzillo kbrock


text:
[FINE] bundle update for Travis runs

Manual backport https://github.com/ManageIQ/manageiq/pull/16463

@simaishi this PR gets Fine closer to green but still fails in the kubernetes provider...
  1) ManageIQ::Providers::Kubernetes::ContainerManager::MetricsCapture::CaptureContext will read hawkular status
     Failure/Error:
           VCR.use_cassette("#{described_class.name.underscore}_refresh",
                            :match_requests_on => [:path,]) do # , :record => :new_episodes) do
             EmsRefresh.refresh(@ems)
             @node = @ems.container_nodes.first
             pod = @ems.container_groups.first
             container = @ems.containers.first

             @targets = [['node', @node], ['pod', pod], ['container', container]]
           end if @node.nil?

     VCR::Errors::UnusedHTTPInteractionError:
       There are unused HTTP interactions left in the cassette:
         - [get https://capture.context.com/hawkular/metrics/status] => [200 "\x1F\x8B\b\x00\x00\x00\x00\x00\x00\x00\r\xCC\xBD\x0E\xC2 \x18\x85\xE1{a\x16\xC2_+qk\xD5\xAA\x83\x8B4\xEE\x94~MH\x806@]\x8C\xF7.\xD3Y\x9E\xF3~\xD1\x13Jr6kH\x1Fg\x01\x9D\x90\x1E\xBB\xD7x\xBD\xA0\x03z\x84\xCDC\x80XLqk\xC4oH"]
         - [get https://capture.context.com/hawkular/metrics/metrics/?tags=miq_metric:true&timestamps=true&type=string] => [204 ""]
     # /Users/joerafaniello/.gem/ruby/2.3.1/gems/vcr-3.0.3/lib/vcr/cassette/http_interaction_list.rb:68:in `assert_no_unused_interactions!'
     # /Users/joerafaniello/.gem/ruby/2.3.1/gems/vcr-3.0.3/lib/vcr/cassette.rb:68:in `eject'
     # /Users/joerafaniello/.gem/ruby/2.3.1/gems/vcr-3.0.3/lib/vcr.rb:156:in `eject_cassette'
     # /Users/joerafaniello/.gem/ruby/2.3.1/gems/vcr-3.0.3/lib/vcr.rb:191:in `use_cassette'
     # ./spec/models/manageiq/providers/kubernetes/container_manager/metrics_capture/capture_context_spec.rb:28:in `block (2 levels) in <top (required)>'

  2) ManageIQ::Providers::Kubernetes::ContainerManager::MetricsCapture::CaptureContext will read only specific timespan hawkular metrics
     Failure/Error:
           VCR.use_cassette("#{described_class.name.underscore}_refresh",
                            :match_requests_on => [:path,]) do # , :record => :new_episodes) do
             EmsRefresh.refresh(@ems)
             @node = @ems.container_nodes.first
             pod = @ems.container_groups.first
             container = @ems.containers.first

             @targets = [['node', @node], ['pod', pod], ['container', container]]
           end if @node.nil?

     VCR::Errors::UnusedHTTPInteractionError:
       There are unused HTTP interactions left in the cassette:
         - [get https://capture.context.com/hawkular/metrics/status] => [200 "\x1F\x8B\b\x00\x00\x00\x00\x00\x00\x00\r\xCC\xBD\x0E\xC2 \x18\x85\xE1{a\x16\xC2_+qk\xD5\xAA\x83\x8B4\xEE\x94~MH\x806@]\x8C\xF7.\xD3Y\x9E\xF3~\xD1\x13Jr6kH\x1Fg\x01\x9D\x90\x1E\xBB\xD7x\xBD\xA0\x03z\x84\xCDC\x80XLqk\xC4oH"]
         - [get https://capture.context.com/hawkular/metrics/metrics/?tags=miq_metric:true&timestamps=true&type=string] => [204 ""]
     # /Users/joerafaniello/.gem/ruby/2.3.1/gems/vcr-3.0.3/lib/vcr/cassette/http_interaction_list.rb:68:in `assert_no_unused_interactions!'
     # /Users/joerafaniello/.gem/ruby/2.3.1/gems/vcr-3.0.3/lib/vcr/cassette.rb:68:in `eject'
     # /Users/joerafaniello/.gem/ruby/2.3.1/gems/vcr-3.0.3/lib/vcr.rb:156:in `eject_cassette'
     # /Users/joerafaniello/.gem/ruby/2.3.1/gems/vcr-3.0.3/lib/vcr.rb:191:in `use_cassette'
     # ./spec/models/manageiq/providers/kubernetes/container_manager/metrics_capture/capture_context_spec.rb:28:in `block (2 levels) in <top (required)>'

  3) ManageIQ::Providers::Kubernetes::ContainerManager::MetricsCapture::CaptureContext will read hawkular metrics
     Failure/Error:
           VCR.use_cassette("#{described_class.name.underscore}_refresh",
                            :match_requests_on => [:path,]) do # , :record => :new_episodes) do
             EmsRefresh.refresh(@ems)
             @node = @ems.container_nodes.first
             pod = @ems.container_groups.first
             container = @ems.containers.first

             @targets = [['node', @node], ['pod', pod], ['container', container]]
           end if @node.nil?

     VCR::Errors::UnusedHTTPInteractionError:
       There are unused HTTP interactions left in the cassette:
         - [get https://capture.context.com/hawkular/metrics/status] => [200 "\x1F\x8B\b\x00\x00\x00\x00\x00\x00\x00\r\xCC\xBD\x0E\xC2 \x18\x85\xE1{a\x16\xC2_+qk\xD5\xAA\x83\x8B4\xEE\x94~MH\x806@]\x8C\xF7.\xD3Y\x9E\xF3~\xD1\x13Jr6kH\x1Fg\x01\x9D\x90\x1E\xBB\xD7x\xBD\xA0\x03z\x84\xCDC\x80XLqk\xC4oH"]
         - [get https://capture.context.com/hawkular/metrics/metrics/?tags=miq_metric:true&timestamps=true&type=string] => [204 ""]
     # /Users/joerafaniello/.gem/ruby/2.3.1/gems/vcr-3.0.3/lib/vcr/cassette/http_interaction_list.rb:68:in `assert_no_unused_interactions!'
     # /Users/joerafaniello/.gem/ruby/2.3.1/gems/vcr-3.0.3/lib/vcr/cassette.rb:68:in `eject'
     # /Users/joerafaniello/.gem/ruby/2.3.1/gems/vcr-3.0.3/lib/vcr.rb:156:in `eject_cassette'
     # /Users/joerafaniello/.gem/ruby/2.3.1/gems/vcr-3.0.3/lib/vcr.rb:191:in `use_cassette'
     # ./spec/models/manageiq/providers/kubernetes/container_manager/metrics_capture/capture_context_spec.rb:28:in `block (2 levels) in <top (required)>'

Finished in 15.84 seconds (files took 7.4 seconds to load)
3 examples, 3 failures

Failed examples:

rspec ./spec/models/manageiq/providers/kubernetes/container_manager/metrics_capture/capture_context_spec.rb:39 # ManageIQ::Providers::Kubernetes::ContainerManager::MetricsCapture::CaptureContext will read hawkular status
rspec ./spec/models/manageiq/providers/kubernetes/container_manager/metrics_capture/capture_context_spec.rb:78 # ManageIQ::Providers::Kubernetes::ContainerManager::MetricsCapture::CaptureContext will read only specific timespan hawkular metrics
rspec ./spec/models/manageiq/providers/kubernetes/container_manager/metrics_capture/capture_context_spec.rb:60 # ManageIQ::Providers::Kubernetes::ContainerManager::MetricsCapture::CaptureContext will read hawkular metrics

Randomized with seed 27479

@yaacov could you try this branch and see if you can figure this out?  This test fails locally:
bundle exec rspec spec/models/manageiq/providers/kubernetes/container_manager/metrics_capture/capture_context_spec.rb

@simaishi The test failures are unrelated to this change.

@yaacov could you try this branch and see if you can figure this out?

a. @jrafanie , I think that when we updated the inventory, we changed the order of objects to get metrics, and the recordings are mismatched, @cben does that sounds right to you ?
b. @cben I think you fixed this, but I do not remmber in what PR, can you check ?

I suppose that's https://github.com/ManageIQ/manageiq-providers-kubernetes/pull/76, testing...

authors: bdunne cben jrafanie yaacov


text:
Introduce $vcloud_log that logs into log/vcloud.log

With this commit we introduce yet another global logger that is to be used by VMware provider. We're having quite some logs there and it's better to log them into its own file.
@miq-bot add_label enhancement
@miq-bot assign @Fryguy
Related issue: https://github.com/ManageIQ/manageiq/issues/16642
BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1525201
/cc @blomquisg @gberginc

LGTM
Reassigning to @blomquisg because he's been involved in the discussions.
@miq-bot assign @blomquisg
@miha-plesko Please, open an issue and mention that that's a request from Red Hat support team.
Adding labels for backports.
@miq-bot add_label gaprindashvili/yes, fine/yes
@chargio Please check that this is correct.

@blomquisg @agrare We need some guidelines here:

What should be the name of the log. Should it be independent on other VMware providers?
What information is in this log and what should be in production.log?

I think this should be called vcloud.log, we already have vim.log for vSphere (VIM is the name of the sdk) so vmware.log would be misleading.  This also follows the pattern of other providers e.g. aws.log and azure.log

I like vcloud better too, because we're not going to be using it for infra manager anyway. Thanks for noticing, I've repushed.

I'm going to remove the backport labels since this is an RFE and doesn't seem to be critical

@agrare thanks for merging. Could you also take a look at https://github.com/ManageIQ/manageiq/pull/16455? Exactly same thing, only for Nuage provider.

@miha-plesko no problem :)
There is an open question to Jason on that one that hasn't been resolved

@agrare The request for this comes from Support. They need the logs to be able to support properly the provider.
So I would add the labels back if you don't mind 😄

Adding back the backport labels.  This is specific for a Fine release.

Gaprindashvili backport details:
$ git log -1
commit e37bb361a6b2a174ec46d42ab58686e655395203
Author: Adam Grare <agrare@redhat.com>
Date:   Wed Dec 13 12:18:09 2017 -0500

    Merge pull request #16641 from miha-plesko/vcd-logger

    Introduce $vcloud_log that logs into log/vcloud.log
    (cherry picked from commit d14404370304efc0e5b1243a750e2c8da03ed4e4)

    https://bugzilla.redhat.com/show_bug.cgi?id=1527555

authors: agrare blomquisg chargio gberginc miha-plesko simaishi


text:
[FINE] Set default value of dropdown list to be nothing

Fix for https://bugzilla.redhat.com/show_bug.cgi?id=1555487.
We're setting dropdown defaults if they're multiselect and dynamic to be the first value in the array. Prior to multiselect, this made sense, because the single select gets the options of  or  but the use case for wanting a multiselect that loaded without an option hadn't been considered. The problem with the workaround of creating an option that is nothing and have it say "Nothing selected" or something is that that option still gets picked. If the multiselect flag is set it might make more sense to set the default to have nothing selected which this does. Incidentally this works fine on master as of the time of this PR thanks to the work done in ui-components.

@eclarizio can you 👀 please?

@miq-bot add_label bug
@miq-bot assign @gmcculloug

@bdunne any chance you could 👀 for me please?

@miq-bot add_label blocker

authors: JPrause d-m-u


text:
Mark Cloud Tenant as required for Openstack provisioning

Follow up to https://github.com/ManageIQ/manageiq-providers-openstack/pull/223
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1610736 in combination with https://github.com/ManageIQ/manageiq-providers-openstack/pull/331

Looks good to me :+1:
(VM would end up under a tenant anyway, better require specify it similar as in OpenStack own tools)

authors: aufi mansam


text:
Redo presence check after possible reset of user to nil

Yeah, it's my bug. If the retirement requester was a string and then the lookup for the userid based on that string returned nil,  q_options[:user_id] = requester.id will fail cause no id for nil.
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1677569.

@miq-bot assign @gmcculloug
@miq-bot add_reviewer @bdunne
@miq-bot add_label hammer/yes, gaprindashvili/yes, bug

any chance someone could please look at this?

This PR seems to have broken master post-merge

Hammer backport details:
$ git log -1
commit 074a1c028055aafaf344f48aafa6b5c828052701
Author: Brandon Dunne <brandondunne@hotmail.com>
Date:   Wed Feb 20 10:13:54 2019 -0500

    Merge pull request #18462 from d-m-u/bz1677569

    Redo presence check after possible reset of user to nil

    (cherry picked from commit 1680ffb493068b447a1ffa762b57f7740aee7884)

    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1763856

authors: Fryguy d-m-u simaishi


text:
[EmbeddedAnsible] Ensure newline for :ssh_key_data

SSH formats like OPENSSH require that a newline exist on the last line, otherwise it is considered an invalid format.
This adds a before_save callback to the model to ensure that it adds a newline to the key in case it was stripped off by the UI or via other means.
Links

BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1893014
Related discussions:

https://gitter.im/ManageIQ/manageiq/ui?at=5fa02fff7cac87158f807568
https://gitter.im/ManageIQ/manageiq/automate?at=5f9afef1c10273610ad33f61
https://gitter.im/ManageIQ/manageiq-providers-embedded_ansible?at=5f9c20e3d5a5a635f28e7d13

cc @tinaafitz @djberg96

@Fryguy just pushed all of the requested fixes (after your approval).  Hopefully those are good.

In the general case, rails trimming the last "\n" makes sense to me.
It also makes sense that we don't want that behavior.
this solution looks like a great and would be a good candidate for backporting

Kasparov backport details:
$ git log -1
commit a24481e6a1b2d444d6e0fcdf42f3b7b4d74ae599
Author: Keenan Brock <keenan@thebrocks.net>
Date:   Mon Nov 2 15:33:43 2020 -0500

    Merge pull request #20771 from NickLaMuro/embedded_ansible_scm_cred_ensure_newline

    [EmbeddedAnsible] Ensure newline for :ssh_key_data

    (cherry picked from commit 1895a653cbb81f0c472fd816f899dbc6f95265e5)

Jansa backport details:
$ git log -1
commit 4a50d87f7f609a7c69b8b0bd63998985df3308cc
Author: Keenan Brock <keenan@thebrocks.net>
Date:   Mon Nov 2 15:33:43 2020 -0500

    Merge pull request #20771 from NickLaMuro/embedded_ansible_scm_cred_ensure_newline

    [EmbeddedAnsible] Ensure newline for :ssh_key_data

    (cherry picked from commit 1895a653cbb81f0c472fd816f899dbc6f95265e5)

@NickLaMuro can this be ivanchuk/yes?

@simaishi Probably should be okay to do so.  Might have conflicts though.
@miq-bot add_label ivanchuk/yes

No conflicts 😄
Ivanchuk backport details:
$ git log -1
commit 1f6a3bacf60fa9b7d756678aad3355d532305f23
Author: Keenan Brock <keenan@thebrocks.net>
Date:   Mon Nov 2 15:33:43 2020 -0500

    Merge pull request #20771 from NickLaMuro/embedded_ansible_scm_cred_ensure_newline

    [EmbeddedAnsible] Ensure newline for :ssh_key_data

    (cherry picked from commit 1895a653cbb81f0c472fd816f899dbc6f95265e5)

    https://bugzilla.redhat.com/show_bug.cgi?id=1893014

authors: NickLaMuro kbrock simaishi


text:
Set the pod HOME env variable to a writable location

Our code or libraries could try to use ~ or $HOME and expect to be able to
create directories or files here and fail.  Previously, $HOME would default to /, which is
not writable for our user.
This now looks very similar to the heartbeat file location:
irb(main):001:0> pp ContainerOrchestrator.new.send(:default_environment)[1]
{:name=>"HOME", :value=>"/Users/joerafaniello/Code/manageiq/tmp"}
=> {:name=>"HOME", :value=>"/Users/joerafaniello/Code/manageiq/tmp"}

irb(main):002:0> pp ContainerOrchestrator.new.send(:default_environment)[4]
{:name=>"WORKER_HEARTBEAT_FILE",
 :value=>"/Users/joerafaniello/Code/manageiq/tmp/worker.hb"}
=> {:name=>"WORKER_HEARTBEAT_FILE", :value=>"/Users/joerafaniello/Code/manageiq/tmp/worker.hb"}

Note, on pods/appliances, this location is /var/www/miq/vmdb/tmp

Setting WIP until I can verify a build with this in case tmp isn't created by the time we try to use it as a HOME env variable location.

Ok, I had a few issues rebuilding my environment to test a build with this but using this branch, I was able to get $HOME to be /var/www/miq/vmdb/tmp.  All pods orchestrated by the orchestrator will now have a $HOME with a writable location.  If we want it to be a subdirectory here or in /tmp, we'll need to ensure that directory gets created beforehand.
joerafaniello@Joes-MBP-2 manageiq-operator % oc describe pod 1-ui-5968cd8f9f-n47r6 | grep -A 10 Environment
    Environment:
      GUID:                     a660faf5-2364-407e-bb70-dc6f4d0bd263
      HOME:                     /var/www/miq/vmdb/tmp
      MEMCACHED_SERVER:         memcached:11211
      MEMCACHED_SERVICE_NAME:
      WORKER_HEARTBEAT_FILE:    /var/www/miq/vmdb/tmp/worker.hb
      WORKER_HEARTBEAT_METHOD:  file
      ENCRYPTION_KEY:           <set to the key 'encryption-key' in secret 'app-secrets'>  Optional: false
      DATABASE_PORT:            5432
      DATABASE_SSL_MODE:
      DATABASE_HOSTNAME:        <set to the key 'hostname' in secret 'postgresql-secrets'>  Optional: false
      ...

joerafaniello@Joes-MBP-2 manageiq-operator % oc exec 1-ui-5968cd8f9f-n47r6 -- env | grep HOME
HOME=/var/www/miq/vmdb/tmp

@jrafanie Were you looking to backport this to morphy as well?

@jrafanie Were you looking to backport this to morphy as well?

Yes, thanks!

Unfortunately that's not how ansible works in this case.  While we use ansible runner to isolate the runs and each run has its own temp dir, there are cases where the ansible authors hardcoded the $HOME/.ansible dir.

We can set the $HOME env var to be anything we want though so we were thinking when executing ansible-runner we could set $HOME to a Tmpdir that way they're isolated and also will work when running as a non-root user (manageiq user is no-logon and has no homedir)

Oh I see now... yeah, we might be able to do that just for the ansible-runner execution.  I wonder if we can put the HOME directly inside the existing ansible-runner-tmp location.

We can set the $HOME env var to be anything we want though so we were thinking when executing ansible-runner we could set $HOME to a Tmpdir that way they're isolated and also will work when running as a non-root user (manageiq user is no-logon and has no homedir)

So, if I'm understanding this, maybe we can add HOME here:
https://github.com/ManageIQ/manageiq/blob/9b06ebecf45cbf5a25a3a5b0d60e396b392b6ef5/lib/ansible/runner.rb#L308-L312
I think this is the entrypoint that everything goes through.  I could be wrong.
Note, this hash is merged on top of any ENV variables provided by the caller, so if something was trying to set HOME, our change would override it.  Maybe we'd need to treat HOME differently and only set HOME when not specified.

Backported to morphy in commit 4b867adea7588de3e88d6f3b9363661fe1855e7c.
commit 4b867adea7588de3e88d6f3b9363661fe1855e7c
Author: Brandon Dunne <brandondunne@hotmail.com>
Date:   Thu Dec 9 16:45:34 2021 -0500

    Merge pull request #21606 from jrafanie/set_home_env_var_in_pods_started_by_the_orchestrator

    Set the pod HOME env variable to a writable location

    (cherry picked from commit 8c95d605ea084780b54f2be80ea6230d5eb5676e)

authors: Fryguy agrare bdunne jrafanie


text:
kubernetes: api_version was removed in 0.1.8

This patch rectifies a kubeclient update that was recently introduced. The api_version parameter was removed in 0.1.8 (not 0.1.7).

@miq-bot add_label providers/containers

/cc @oschreib @abonas
@Fryguy this should be quick to review, the changes introduced in PR #2506 actually required version 0.1.8.
Because in 0.1.7 "version" (in initialize) is still there:
https://github.com/abonas/kubeclient/blob/v0.1.7/lib/kubeclient.rb

@abonas We really need those EMS refresh specs to catch issues like this.

Will merge when green. :+1:

@simon3z thanks for catching this.
@Fryguy an effort started to do rspecs, but it's not gonna happen overnight naturally.

@Fryguy this should be ok to merge now.

The build team is OK with this change. Please let us know if has to be backported.

@jvlcek I don't think this needs any backporting... unless https://github.com/ManageIQ/manageiq/pull/2506 was backported somewhere. In that case you also need this fix.

authors: Fryguy abonas jvlcek simon3z


text:
Deleted redundant code in MIQ Policy Controller / MIQ Actions

Check for generated flash messages no longer needed with the code fix in https://github.com/ManageIQ/manageiq/pull/6525
New begin/rescue block in ci_processing/process_elements generates flash messages

@dclarizio @h-kataria Redundant code removal, please review.

LGTM

authors: GregP h-kataria


text:
Add .gitignore

Just for convenience and prevent contributors from committing unnecessary files, let's add a .gitignore :slightly_smiling_face: This one is a fairly default template for Python projects.

Looks good but I made an issue to generate this through generalpackager

No problem :) Can you tell me how do I get the .gitignore in my local development environment? The linked issue doesn't really help...

Ah sorry, I didn't consider that I could merge this as a temporary solution. Also didn't know that it cannot be reopened when you deleted the branch, I'm learning so much!
If you reopen this I'll accept it! The commit is still here though, that's interesting

I could restore the branch but not re-open the PR :sweat_smile: I'll try to open a new one from the same branch.

authors: Mandera ZanSara

repo: ManderaGeneral/generalimport


text:
Improve README, append link to create account on MangoPay website

Small documentation improve.

Thanks @harobed!

authors: harobed hobailey


text:
Unserializable OAuthToken class

I am using  strategy IStorageStrategy and I whant to save OAuthTOken in redis
public interface IStorageStrategy {
  OAuthToken get(String envKey);
  void store(OAuthToken token, String envKey);
}

but cannot do it!! becouse OAuthToken has token-type private field! I don't want use reflection for this.
public class OAuthToken extends Dto implements Serializable {
   private Long create_time;
   public String access_token;
   public String token_type;
   public int expires_in;
    public OAuthToken() {
       create_time = System.currentTimeMillis() - 5000;
   }
   public Boolean IsExpired() {
       return (System.currentTimeMillis() >= (create_time + (expires_in * 1000)));
   }

  @Override
   public String toString() {

       return "access_token = " + this.access_token + ", token_type: " + this.token_type + ", expires_in: " + this.expires_in;

   }
}

and what does mean 5000 magic number?

Hi @YaroslavTir, we take off 5000ms to try and avoid a situation when the token is valid but has infact expired by the time it reaches the Mangopay servers (because the connection took longer than 5s).
As for the token_type, it seems to me that it is indeed public unless I'm missing something - could you perhaps do a pull request with the changes you'd need so we can understand more clearly?

oh, sorry it is create_time field. I cannot serialize/deserialize this value from this field because it private. When I deserialize it time will be

create_time = System.currentTimeMillis() - 5000;
so IsExpired return valid value

That should sort it @YaroslavTir :-)

authors: YaroslavTir hobailey


text:
manim_directive: fix image links in docs - Windows

Changelog / Overview

Use POSIX path on Windows to link images so documentation can build locally.

Use POSIX path on Windows to link images or else it doesn't work. Also, use pathlib wherever possible.
This fixes https://github.com/ManimCommunity/manim/issues/1150
Motivation
It will be possible to render docs on Windows, which will work, after this change.
Explanation for Changes
Use pathlib wherever possible.
Testing Status
Tested locally, Windows 10. Maybe should I set up CI for this?
Checklist

[x] I have read the Contributing Guidelines
[x] I have written a descriptive PR title (see top of PR template for examples)
[x] I have written a changelog entry for the PR or deem it unnecessary
[ ] My new functions/classes either have a docstring or are private
[ ] My new functions/classes have tests added and (optional) examples in the docs
[ ] My new documentation builds, looks correctly formatted, and adds no additional build warnings

Reviewer Checklist

[x] The PR title is descriptive enough
[x] The PR is labeled correctly
[x] The changelog entry is completed if necessary
[ ] Newly added functions/classes either have a docstring or are private
[ ] Newly added functions/classes have tests added and (optional) examples in the docs
[ ] Newly added documentation builds, looks correctly formatted, and adds no additional build warnings

In rst files only / is a valid seperator for image links and \ is an escape sequence.

repo: ManimCommunity/manim


text:
Update stable branch

Update the stable branch to the current master.

If we care about he commit history of the stable branch, it is now or never.
(I think it's more important to have a clean commit history on the dev branch, but whatevs)

Doing a squash and merge should prevent the history getting messy

authors: eulertour leotrs


text:
DIA-NN proteotypic peptide filtering

Hello,
I have noticed that directLFQ does not filter out shared peptides from the DIA-NN output so the quant can be highly misleading for certain protein families. I can use the generic input format with the precursors table as a work-around, but it would be great to filter for proteotypic peptides only by default or as an optional parameter if possible.
Thanks!

Hi Rob,
thanks a lot for your input! Indeed we do not filter out any peptides based on this criterium. The reasoning behind this is, that when we use the Protein.Groups column every peptide maps to only one protein group. So the mapping is unique, but indeed it can be that the assignment of the protein group is wrong. So it would be good to have an option to filter for proteotypic peptides and I will include it in the next releases. Another option to filter now is to subset the DIA-NN report.tsv to only prototypic peptides, save it and feed that directly into directLFQ.
Best&thanks
Constantin

Hi Rob,
in the new directLFQ version there the now the switch 'filter_dict', where you can specify individual filters as a dictionary. In the Python API you can for example do something like this:
filter_dict={'proteotypic_filter' :{'param' : 'Proteotypic','comparator': '==', 'value': 1}}
directlfq.lfq_manager.run_lfq(.....,filter_dict = filter_dict)
In the CLI and GUI, you need to specify this as a .yaml file (see also GitHub docu). Hope this works for you? I did not include the proteotypicity filter as a default because I think this is too stringent. There I would rely on the parsimony principle usually applied for the grouping (see response above)
Best & thanks
Constantin

Hi Constantin,
Thanks very much for adding this filter. I will give the new version a try.
Rob

authors: ammarcsj rob-lawrence

repo: MannLabs/directlfq


text:
Completed logic and added progress view

Progress

Completed logic in main.py
Added support for random seed for reproducability, can be changed in configurations.py
Added requirements.txt
Tested the code with a sample video, everything's functional. Results can be seen in generate_synthetic_images_byCodes/dataset

Pending tasks

Write proper readme
Add code documentation file

Progress

Added code documentation and usage example

Pending

Write proper readme

Updated readme to match the progress and added links to view documentation directly from readme as html.


text:
Add examples for Input API

Didn't add examples for GetCurrentTouchIndex() because it had many occurrences for each UI type. Added examples for pointerMovedEvent, mouseButtonPressedEvent, mouseButtonReleasedEvent.
First time modifying the API docs so let me know if I made a mistake in syntax or whatever.

Converted examples over to other rep.

authors: DoubleA-MG PopThosePringles


text:
feat: add a optional separatorBuilder

This awesome library is sadly missing a way of simply adding spacing or other widgets inbetween the lists widgets, like Listviews separatorBuilder argument.

probably the easiest to implement when this issues gets resolved: https://github.com/flutter/flutter/issues/48226


text:
Visualizer not working with Spotify

When I first installed the visualizer it was working fine with Spotify but then it randomly stopped working and no matter what I do it won't work again. I've tried downloading other visualizers and they are not working with Spotify too! Really have no idea what the problem is and I love the Monstercat Visualizer :(

Just to clarify is the Spotify info such as what song is playing there and just the audio visualizer isn't working?
If so iirc that normally happens when the audio plugin has not detected the default audio device has changed, try restarting rainmeter.

Yes that's all there but I just tried restarting rainmeter and the visualizer still won't work. I've tried re-installing the program and still nothing, I've also tried other visualizers and still nothing?

Could you please send a screenshot from the debug log of Rainmeter (https://docs.rainmeter.net/manual/user-interface/about/) and post it in here.
Also please write down your OS version, Rainmeter version and skin version.

 OS is Windows 10 (64 bit), Rainmeter version is 4.0.0 r2746 64-bit and skin version is 1.5.3

 Here's the log when I open Spotify.

 Here's just the debugs when running Spotify.

Did you already reinstall Spotify? Cause most of the time when the plugin can't detect Spotify there is a issue with the SpotifyWebHelper.exe which got corrupted via update or is not running at all. Open explorer, enter %AppData%\Roaming\Spotify in the top and try to launch SpotifyWebHelper.exe.

I'll try reinstalling it now and just tried to open the SpotifyWebHelper.exe. and it wouldn't run/open?

It will be running in the background, it will not open anything.

Oh ok, just reinstalled Spotify and still not working and I was running the webhelper in the background.

Try installing NET Framework 4: https://www.microsoft.com/de-at/download/details.aspx?id=17718

Just tried to install it and it said I already have it installed on my OS

 And just opened that link and it said this at the top and I was running the webhelper, I don't know what it meant.

Ok, so at least you should get the token so this is not an issue. Are you in private or offline mode? Because it only works in normal mode.
Also try to restart your computer after reinstalling Spotify, sometimes that helps too.

Also which Antivirus are you using?
If you are using AVG, please disable Link scanner as shown in the gif below:
https://i.gyazo.com/3960cbaf9abb257bbc6c3f7edb786833.gif

Restarted my pc and I just use Windows Defender and my Spotify on my pc isn't in offline or private mode

I restarted and still not working

Marco maybe I am misunderstanding his issue but I think this is an issue with the audio plugin not the Spotify plugin. Klossel, do you have a discord account so that we can go through debugging what is going on in a faster fashion? If you do add me at tjhrulz#5476

Just sent you a friend request :)

After some debugging the AudioLevel plugin did not correctly install, reinstalled rainmeter and it fixed it.

Thanks for all your help guys :)

I'm also having this issue, Windows Sounds make the visualizer work, this was actually working but randomly stopped, tried reinstalling everything, no fix :S

Is this an issue with Spotify or the Audi bars. Also do to some recent issues try doing a manual install: #manual-installation

tjrulez i added you on discord, as i have the exact same issue :(

authors: IonstormEU Klossel MarcoPixel MissCupcakeDK tjhrulz

repo: MarcoPixel/Monstercat-Visualizer


text:
Completion of error handling

Would you like to add more error handling for return values from functions like the following?

malloc ⇒ blGenList
pthread_mutex_init ⇒ blGenMutex

ok，i will add error handling later，now bulllord engine is in development，I need to complete most of the functionality

authors: MarilynDafa elfring

repo: MarilynDafa/Bulllord-Engine


text:
proxy-error after create new instance

when I create a new instance on the sensorthings.geosas.fr server, I get a new error “Proxy Error”.

Yes the fact that when a new service is add by the /Service route the default new user is the service name cause some trouble.
it's fixed now
https://github.com/Mario-35/Stean/commit/c3a0b7e07713a5a5fbe30f6900dc92a14548b7ea


text:
Support RobotFramework 5 features

Looks like a whole raft of new syntax features are added in robotframework 5.0. We should try to support them!

I'm going to do a little looking at this...

#11 is ready for review.


text:
Rule detecting hyphens inside variable names

Closes #271

Codecov Report

Merging #452 (e002411) into master (a0e7464) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #452   +/-   ##
=======================================
  Coverage   97.79%   97.80%
=======================================
  Files          22       22
  Lines        2180     2183    +3
=======================================
+ Hits         2132     2135    +3
  Misses         48       48

Impacted Files
Coverage Δ

robocop/checkers/naming.py
98.96% <100.00%> (+0.01%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a0e7464...e002411. Read the comment docs.

authors: codecov-commenter mnojek

repo: MarketSquare/robotframework-robocop


text:
Add code style checker

In order to maintain consitent code a style checker should be added. See the style guideline created by @keeferrourke's initial RHPMAN implementation to see if that would work for this project.

Seems like you can probably close this issue :)

authors: MarshallAsch keeferrourke

repo: MarshallAsch/saf

license: ISC


text:
Default App for handling media control buttons?

[macOS] Any way to have GPMDP to be the default for handling the play/pause, skip and previous buttons? I know the app will work with the buttons if you have the app open, but if it's closed it seems to just open iTunes.

I don't believe mac OS gives you the option to pick. However I don't have a mac to test with.

@jostrander No, it does not. I should've worded myself differently; I wanted a way for it to do so, which I know is not there at the moment.

Unfortunately it's not something we can implement, it has to be something Apple creates and implements, which is highly unlikely.

authors: SpectralKH jostrander


text:
日志定期删除N天前的日志记录

例行检查

[√] 我已确认目前没有类似 issue
[√] 我已确认我已升级到最新版本
[√] 我已完整查看过项目 README，已确定现有版本无法满足需求
[√] 我理解并愿意跟进此 issue，协助测试和提供反馈
[√] 我理解并认可上述内容，并理解项目维护者精力有限，不遵循规则的 issue 可能会被无视或直接关闭

功能描述
希望新增一个定期删除N天前的日志记录, 每次都要到数据库里手动清空日志, 有点麻烦了...

设置-运营设置-日志设置中有清理历史日志，时间选择框指的应该是清除选定时间以前的日志，没有试过你可以试一下。

你可以在后台手动清除。
定时清除 暂时没计划。

主要是这个清理日志是按秒来清理. 如果设置区间范围, 就比较合理些.

authors: MartialBE fengjisheng soulgod001

repo: MartialBE/one-api


text:
Need CAM license?

Hello,
I was interested in using this library to control a Leica SP5 running LAS-AF.
Do I need the CAM license to use leicacam?

As far as I know, you need a CAM license to activate the CAM feature in LAS AF. There's no specific check in leicacam though. This library just needs a server that accepts a connection over a socket from the library client on the port configured.

repo: MartinHjelmare/leicacam


text:
BBox calculation for collections with multiple CRSs

Problem
The current implementation handles the bbox of collections with multiple crs incorrectly, e.g. an project spanning more than one UTM zone.
Solution/Idea
For collections with > 1 crs:

convert bbox of each dataset to wgs84
merge the converted bboxes using datacube.utils.geometry.bbox_union().

Else:
Merge bboxes using native crs.

Fixed by b759705

repo: MartinPontius/pygeoapi-odc-provider


text:
MG - 9 - Capitalize "directed acyclic graph (DAG)"

Very minor thing: the first character of each word should be capitalized to relate to the related letter in the acronym.

Fixed! Thank you!

authors: Maryamvalian balacij


text:
Can't connect to Kong server. ERROR

I am runnining docker-compose KONG from this repo https://github.com/Mashape/docker-kong/tree/master/compose  and trying to run this great repo in docker too. I provided 0.0.0.0:8001 in node URL but got error : 'Can't connect to Kong server.' ...  curl 0.0.0.0:8001 responds fine ...
I am using Linux Mint 18.1 Serena

sorry, this is issue for another repository )  it for https://github.com/PGBI/kong-dashboard/issues/90

repo: Mashape/docker-kong


text:
RequireUserVerification Is Not Documented

Describe the issue
requireUserVerification is not documented and leads to issues when using Chrome's built-in passkey because it doesn't promp for pin verification. requireUserVerification is true by default and it's behaviour should be documented as such
link to implementation

Hello @megaconfidence, the docstring on that parameter currently notes that requireUserVerification defaults to true:

This was part of the v10 release because, I agree, in prior releases this property (and many others) were inadequately documented.
Does this resolve your issue?

Closing because the conversation has gone quiet, please feel free to reopen if you want to continue talking about this.

authors: MasterKale megaconfidence

repo: MasterKale/SimpleWebAuthn


text:
🛑 Mirror is down

In e3ec7ea, Mirror (https://mirror.bettercrewl.ink/) was down:

HTTP code: 403
Response time: 62 ms

Resolved: Mirror is back up in 174e537.

repo: MatadorProBr/BetterCrewLink-status


text:
copy_both: handle Future cancellation case

When a user starts a CopyBoth query a state machine is created that is responsible for driving the CopyBoth protocol forward regardless of what the user does with the returned handles. The state machine starts in the Setup phase and only gives control back to the user (in the form of the returned handles) after having finished with the Setup. Therefore the code assumed (incorrectly) that the handles will never be dropped while in Setup mode.
It turns out there is one more way of dropping the handle even while in the Setup phase, and that is to cancel the entire Future object returned by the copy_both method at just the right time. This resulted in the state machine observing that the handles were dropped while still in the Setup phase, which was asserted to never happen.
This PR fixes the problem by handling the case where a handles are dropped while still in the Setup phase.
Fixes: https://github.com/MaterializeInc/database-issues/issues/8604

Could we test this deterministically by adding a failpoint with a sleep?

We could but then this makes this PR non-upstreamable. I just had an idea that might work in a unit test though, will report back in a moment

@def- added a unit test and confirmed that it fails without this PR

repo: MaterializeInc/rust-postgres


text:
App 3

A mensagem vai ate COMPU e não a COM como deveria estar

Arrumado separando os controles de volume para as interrupções!

repo: MateusFauri/Cesar


text:
🛑 Ticketing App is down

In 710e718, Ticketing App (https://rt.greenpeace.org.ar/) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Ticketing App is back up in b2a3b6d.


text:
🛑 Inventario App is down

In 1c79883, Inventario App (https://inventario.voluntariosgreenpeace.cl/) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Inventario App is back up in e03ad31 after 11 hours, 50 minutes.


text:
ci: merge staging to master

This is an automatic PR generated by the pipeline CI/CD. This will be automatically fast-forward merged if successful.

Pipeline Attempt on 1034214721 for f4f6c12fb94d89aae2c9e0d3d1fd88b728bf0622
https://gitlab.com/MatrixAI/open-source/js-mdns/-/pipelines/1034214721

Pipeline Succeeded on 1034214721 for f4f6c12fb94d89aae2c9e0d3d1fd88b728bf0622
https://gitlab.com/MatrixAI/open-source/js-mdns/-/pipelines/1034214721

repo: MatrixAI/js-mdns


text:
🛑 Mailcow is down

In 1c179b6, Mailcow (https://mail.atslega.network) was down:

HTTP code: 503
Response time: 480 ms

Resolved: Mailcow is back up in 5c1db5a.

repo: MaxAtslega/status


text:
Too much 'here'

It's annoying having to put 'here' everywhere!!!

Like in this screenshot... I don't want to say
set ra 'OF HERE' to ra 'OF HERE' + 1

Instead, I just want to say
set ra to ra+1

TOO MUCH HERE

The new is_block doesn't have 'here' in so much! I like it - it's nicer and simpler. Maybe we could change some other blocks to work like it? eg: the is_touching block?

A potential downside is that there's less customisability(?) of the block's behaviour, but maybe that's ok? ie: It has 'here' hard-coded into it now.
Another potential downside is: will this be confusing with current blocks? Like, what would you expect this to do?

Personally, I'd expect it to move down into air, and then do the same again. I would expect the hard-coded 'here' to dynamically update to where the cell moves to. I did try that a while back, and it ended up confusing too 🤔
Would it make more sense if it worked like this?:

I think the balance is ok for now. It's a lot better than before

repo: MaxBittker/sand-blocks


text:
CDN is down

http://netdna.bootstrapcdn.com/
CDN Link is down

It's down right now too.

@sean-hill looking into it

@jdorfman thanks :) It's now completely "down" it's just taking about 45 seconds to load.

@sean-hill yeah working with our engineering team.

@sean-hill it is isolated in Los Angeles.  Still unexceptable but that is the latest I know.

@jdorfman I don't know if this helps, but I'm in Phoenix, AZ and still having issues connecting to https://www.bootstrapcdn.com/.

@sean-hill yeah AZ routes to LA.  Try now.

@jdorfman Works like a charm!

@sean-hill awesome.  Sorry for the inconvenience.  We will be updating status.maxcdn.com with a post mortem.

status.maxcdn.com could have a form to add issues - similar to this one:
http://allestoerungen.de/stoerung/netflix
This is a real time analyses of user problems - users just click a button, categorize thir problem and the issue is counted in a heat map.

authors: geri777 jdorfman sean-hill veera

repo: MaxCDN/bootstrap-cdn


text:
Submit PRs on repos with legacy references.

A quick search yielded 11 repos with references to maxcdn.bootstrapcdn.com. I'm going to submit PRs to each updating to the latest stackpath url and add identity where missing.
https://github.com/search?q=maxcdn.bootstrapcdn.com

So, I wouldn't bother with the repos at all, they all look like test repos and nothing serious IMO.

Can we close this? Please see my comment above.

Ping @jmervine ^^

While this issue is outdated I think it could be relevant in migration of *.bootstrapcdn.com links to cdn.jsdelivr.net links.
As first step I think a manual review and sending PRs to most popular repos would make sense.

authors: XhmikosR jimaek jmervine

repo: MaxCDN/bootstrapcdn


text:
Directory download bug

i dont know if its a bug or just "not featured":
when i want to download an directory nothing happens

it's just not implemented yet, take a look here: #262.

authors: MaxXor alpha-supporter

repo: MaxXor/xRAT


text:
issues installing plugins

I don't know why but Roblox Studio Mod Manager makes it so when the Roblox site tries to open studio it will open mod manager instead so I can't install plugins.

Launching through the mod manager from the website should install the plugin correctly. If it isn’t then let me know.

Closing since I haven’t heard back.

repo: MaximumADHD/Roblox-Studio-Mod-Manager


text:
OW1 Ana

Healing from 75 -> 70
Ammo from 15 -> 12
Biotic Grenade duration effect from 3.5 seconds -> 4 seconds

Closed because first two issues are resolved, third issue will be made as seperate issue.

authors: MaxwellJung dubspool


text:
0 byte files

Libation is getting 0 byte zip logs after upgrading to .net8. Would you mind releasing this nuget as .net8 to see if that helps?

Ugh, thank god we only have to do this once every 20 years.
May I suggest adding a new text note to Libation repo? "Steps to upgrade .NET"

@rmcrackan I've updated Serilog.Sinks.ZipFile to 3.1.1 (now matching Serilog's version number).

Thanks for the fix. Good idea -- https://github.com/rmcrackan/Libation/blob/master/Source/Upgrading dotnet version.txt

authors: Mbucari rmcrackan

repo: Mbucari/serilog-sinks-zipfile


text:
Different type labels from official document (str→string, int → integer, etc.)

It seems that the labels of str and int type is different between tidy and Typst's official documentation, where
the string type is str

https://typst.app/docs/reference/foundations/str/
the integer type is int

https://typst.app/docs/reference/foundations/int/
It seems that in old version of Typst, type(1) yields "integer", so is this a legacy or is it intended?

This is indeed legacy and also applies to relative (which was originally relative length).

The old versions will also be supported in favour of backwards-compatibility

authors: Mc-Zen mkpoli

repo: Mc-Zen/tidy


text:
Builder Ignoring BlockBreaking Event. (Please High Priority)

The Builder when placing/Replacing blocks totally ignores if it is breakable or not.
Yes it check the unbreakable state of the Block but there is no Event check if the Blocks can be destroyed.
Thats why the BlockBreakEvent exists.
A big serverhoster i try to help fixing bugs gave me the task to fix that issue.
The pack they are using is SkyFactory 3 (1.10.2).
It would be nice if you could fix it. Or if you allow me  to make a push to you so you can release it.
At the moment the second option is not possible since i cant create dev invioments because gradlew gets connection crashes...
The fix could be really simple:
add a function that returns boolean as result and that throws a canBreakEvent(),
and add that function to all calls that would replace blocks.
Thanks for reading

Unfortunatelly I cannot fix this quickly as I have hardly any time this weekend and this is something that needs to be done carefully. I'll try to check it out as soon as possible though

You think you would be able to fix until the end of next week?
(I will quote you on that one)

I did find some time.
I did not release this yet as I would prefer if you could test this a bit (I only did some local testing) but you can get a version that checks for break events here:
http://jenkins.k-4u.nl/job/RFTools/
If all is ok on your side with this then I can release this to the public.
Thanks

Please tell me that rftools uses compact layer as basemod because then you will get no testresults. Since i requested it for 1.10.2...

All my mods use compatlayer so you will be fine

^^"

Turns out that we cant test it. For one reason: Its for a server and you gave out a version with a new version number. (for some things updating forge version ids is fine but small fixes like that should have the same version as the latest in code so servers can update without clients to do that. (for a server with over 100 people playing actively thats important)).
Luckly we exported your fix with a different version number (the one we need).
Testing is luckly happening soon with that fixed fixed version. We tell you the results later.

Well RFTools 5.90 is the latest so the version did correspond to the latest release of RFTools. Also when I'll do the fix fo realy this will be for RFTools 5.91 anyway

i.e. I didn't update the version number. I just reused the latest

well he uses SkyFactory 3 so i assume that uses a outdated  version.

Fixed next release

authors: McJty Speiger

repo: McJty/RFTools