text:
Remove register 2nd call

Also refactor Send() calls to use a DTO aimed to be enqueued in next PR.

Pull Request Test Coverage Report for Build 261418908

49 of 58 (84.48%)  changed or added relevant lines in 2 files are covered.
4 unchanged lines in 1 file lost coverage.
Overall coverage increased (+0.05%) to 58.313%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

pkg/integrations/v4/dm/emitter.go
46
55
83.64%

Files with Coverage Reduction
New Missed Lines
%

pkg/integrations/v4/logs/cfg_watcher.go
4
67.5%

Totals

Change from base Build 261233762:
0.05%

Covered Lines:
11062

Relevant Lines:
18970

💛  - Coveralls

authors: coveralls varas


text:
Temp Solution to setEntityGuid

Temp solution for client side to setEntityGuid
Tested with apps, didn't write unit test as this will be removed later

Tested build with apps, didn't write unit test as this will be removed later.

source: gharchive/pull-request

repo: newrelic/newrelic-android-agent

license_type: permissive

license_source: github-api


text:
Scanned Events Query Governance

Summary
Scanned Events The dashboard's dynamic and detailed nature facilitates a deep understanding of query volumes, empowering users to optimize queries and manage resources effectively. There are no alerts attached yet
A concise description of the changes being introduced. Please review the pre-merge checklist section to validate this pull request is ready for review and merge. If it is not ready, please mark the pull request as a draft.
The owners of this repo are not experts in the subject matter of the quickstarts. We review for the quickstart to be functional and for security risks. If you are seeking feedback on the content of the quickstart, please seek out a subject matter expert. If you are not an internal NR contributor, we can do our best to connect you with a content reviewer.
Pre merge checklist
[ x] Did you check you NRQL syntax? - Does it work?
[x ] Did you include a Data source and Documentation reference?
[x ] Are all documentation links publicly accessible?
[ x] Did you check your descriptive content for voice and tone?
[ x] Did you check your descriptive content for spelling and grammar errors?
[ x] Did you review your content with a subject matter expert? (e.g. a Browser agent quickstart is reviewed with a member of the Browser Agent team)
Dashboards
[x ] Does the PR contain a screenshot for each of your dashboards?
[x ] Do your screenshots show data?
[ x] Has the sanitization script been run on each dashboard?
Alerts
[x ] Did you check that your alerts actually work?

Ready for review, thank you!

Changed logo size and removed accidentally committed file

Updated logo

repo: newrelic/newrelic-quickstarts


text:
Fails to load all applications

Description of issue
We currently have over 24K APM services across multiple subaccounts, under one main account. Whether using v1 or v2, I don't get all of those loaded. Loading takes sometimes 30 mins and even then, I get at most 15K-16K loaded. Usually, loading doesn't complete at all.
Steps to replicate

https://one.newrelic.com/
apps
agent groundskeeper
onscreen it says "Agent Groundskeeper v2, Switch to v1, Scanning 24814 applications"
stuck here for hours, status bar never finishes

-OR-

https://one.newrelic.com/
apps
agent groundskeeper
onscreen it says "Agent Groundskeeper v2, Switch to v2, filter bar defaulted to agents < 2 weeks old and Out of date, Loaded x applications
stuck here for hours, status bar never finishes

Expected Behaviour

step 5 shows 24814 applications loaded
all reports, filters are running against 24814 applications

Relevant Logs / Console output
Your Environment

NR1 CLI version used:
Browser name and version: Google Chrome Version 113.0.5672.127 (Official Build) (64-bit)
Operating System and version: Windows 10 Enterprise 22H2

Additional context
Opened a ticket with New Relic knowing they have had challenges scaling to our volume before and they sent me here

Hi @NickleShy! Thanks for reaching out. Are seeing any error messages in your browser's console? If so, could you please post it here? Please make sure you remove any account specific information before posting it.

source: gharchive/issue

authors: NickleShy amit-y


text:
fix to minor spelling mistake

minor spelling mistake in the UI.

:tada: This PR is included in version 1.5.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

authors: devfreddy ricegi


text:
Create direct download capability for podcast media files in article view

This would make it possible to bypass Podboat.

Not convinced. What's wrong with Podboat, exactly?

Pressing one key to download a file is easier than pressing one key to add it to the queue, opening Podboat, pressing another key to downoad and pressing a key to delete the file from the queue.
Gesendet: Dienstag, 02. Juli 2019 um 20:37 Uhr
Von: "Alexander Batischev" notifications@github.com
An: newsboat/newsboat newsboat@noreply.github.com
Cc: Eucyon martin_wolf@gmx.de, Author author@noreply.github.com
Betreff: Re: [newsboat/newsboat] Create direct download capability for podcast media files in article view (#562)
Not convinced. What's wrong with Podboat, exactly?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

This sound like you're using Podboat just to download stuff. If that's the case, you might be better of writing a script that will watch the queue file, and on every change: parse it, download the files, and clear the queue. Perhaps this should be implemented in Podboat itself, even. Would you keep Podboat open just for it to automatically download podcasts?
I still don't think this is a good feature to have in Newsboat proper. With any podcast, user's end goal is to listen to it. This means not just downloading it, but also playing it; or perhaps notifying some other program that the file is ready. Then there are people (like me) who download podcasts in batches, and listen to the backlog as time permits; those people will need some way to manage their downloaded files.

Thanks for considering this again.
In my use case, I download quite a lot of audio files to my Download folder. So I am able to listen to them when I would like to.
I also thought about what you suggested ("writing a script..."). But in my eyes it would be easier to simply press a key after I have read the article in Newsboat and decided to download. This would be an additional capability of NB, which would make invoking Podboat unnecessary in my use case. Maybe this would be useful for others.

With a script, you'll press exactly one key—'e'. Or even none at all, if auto-enqueue is enabled. But that script still needs to be written.
You didn't answer if you would run Podboat in background if it could automatically download stuff, obviating the need for the script. Would you?
I'm not trying to persuade you that you don't need this feature. Instead, I'm trying to show that this is a case of feature creep: adding just one key that downloads podcasts won't be enough, and eventually we'll have to move the whole of Podboat into Newsboat. The result will be harder to maintain, especially since Podboat doesn't seem to enjoy any popularity at all—can't remember getting any patches for it, unlike hundreds of PRs to Newsboat.
In short, I'd rather see Podboat improved to a point where it covers your use-case, rather than turn Newsboat into even bigger of a monster.

OK, I will think about a way, maybe via letting PB run in background.
Thanks!

Wait, there is no point today in running Podboat in background. My question was about a hypothetical future where Podboat learns to do watch the queue and automatically download everything it sees. I'm trying to figure out how I can improve Podboat to suit your needs better, so let's think through this together please?

Thanks for accomodating.
But still, I would prefer not to be forced to invoke a second program to download a media file.
I saw that the queue is a plain file containing the URLs in plaintext. So I probably will write a little script that I start at the same time as NB that watches the queue, downloads the files in it and exits when NB is closed.

This script watches NB's queue in background, starts NB, downloads all files added to the queue to the "Download" folder and quits, when NB is quit:
#!/bin/bash

{
  sleep 5
  while pidof newsboat > /dev/null
  do
    while read url filename; do
      wget -qP ~/Downloads "$url" && sed -i "\!^$url!d" ~/.newsboat/queue
    done < ~/.newsboat/queue
    sleep 5
  done
} &

newsboat

It depends on wget.
Put it in the binary folder (~/bin) and start it with the name you gave it, e.g "n".

OP is right that the Podboat download-queue workflow seems fastidious when wget exists. More resilient, yes, but also more cumbersome than just "download it".
But there's another problem! What if the user wants to rewrite the downloaded file's metadata using the feed values? In other words, to correctly populate the ID3 tags on a downloaded MP3 so that it is decipherable in an audio player. Many podcast RSS feeds contain poorly tagged enclosures, presumably because it's assumed they'll only ever be played by a podcast client within the context of their RSS feed. The Podboat workflow means that any such missing data is lost irretrievably.
The obvious solution would be a function to pipe out the enclosure URL, together with the metadata which might not be in the enclosure - "Feed name", "Article title", etc. Either just to wget or to a script which can make use of the RSS metadata to rewrite tags and so on.
Is there any hope that such a pipe function might be implemented?

It's open source, so there's always hope :) In #1691, I outline how enqueueing might be unified with some other features, but no work has been done on that yet. Patches are always welcome (though that one requires a design discussion first, I guess).

It's open source, so there's always hope

Indeed. I was being disingenuous. I actually have much expertise in the art of nagging and pestering software maintainers. :)
Your little manifesto in #1691 is persuasive, nice work for thinking it through.
I am new to this project but it does feel like a relative of Mutt. And Mutt allows direct download of email attachments.

authors: Eucyon Friptick Minoru

repo: newsboat/newsboat

license: MIT


text:
Mystery Text Discussion: ww.txt

Post your screenshots and discuss your findings about ww.txt here!

So i found interesting that this mystay text brought up martians a lot at 163 times which was said more than the word came showing how frequently it shows up. In one of my photos I screenshotted how frequently and how many times it was used in certain parts of the text. another than i noticed was there was a frequency with a five letter phrase "the edge of the pit" which was used 8 times which i think is pretty big for a 5 Ngram scan, and it seems that there is a big plot point of this pit and a major setting in the story.  At an NGRAM of 3 a phrase shows up "of the martians" 28 times so that would also mean that i would imagine this story being about martians and something to do with maybe the pit of space being the edge or maybe talking about a planet.

repo: newtfire/introDH-Hub


text:
Recommended way to add 3rd party plugins, styles, etc?

I'm trying to add bootstrap and other 3rd party javascript and css assets into the project.  What is the best way to include them?  I tried bower but I'm not sure how to include them in the webpack build process.

@cheeselover: You can require css, less or other js files just as shown in the generated components.
For example, you could include Bootstrap like this:
// First install bootstrap via npm:
npm install --save bootstrap
npm install --save jquery

// Then, in one of your components (or whereever):
require('bootstrap/dist/css/bootstrap.css');
var jq = require('jquery');

As far as I know the files are automatically searched for in the current directory, then in the node_modules folder where they can be found after installing them via npm.
Hope this helps

authors: cheeselover weblogixx

repo: newtriks/generator-react-webpack

license: mit

license_source: bigquery


text:
播放器黑屏

demo中仿抖音的实现
上下切换视频播放器有大概0.5-1秒的黑屏闪动，请问有什么解决方案

case AVPlayerItemStatusReadyToPlay:{
JPDebugLog(@"AVPlayerItemStatusReadyToPlay");
dispatch_after(dispatch_time(DISPATCH_TIME_NOW, (int64_t)(0.1 * NSEC_PER_SEC)), dispatch_get_main_queue(), ^{
self.playerStatus = JPVideoPlayerStatusReadyToPlay;
// When get ready to play note, we can go to play, and can add the video picture on show view.
if (!self.playerModel) return;
[self callPlayerStatusDidChangeDelegateMethod];
[self.playerModel.player play];
[self displayVideoPicturesOnShowLayer]; //将这里的0.01秒延迟的GCD去掉
});
}

repo: newyjp/JPVideoPlayer


text:
Add shortcuts for custom menu top-level items #84

Signed-off-by: John M. Horan johnmhoran@gmail.com

LGTM! 👍

authors: jdaguil johnmhoran

repo: nexB/aboutcode-manager


text:
Determine preferred way to refer to CVEs, GHSAs and other vulnerability IDs

In the new UI, one task I'm working on is providing succinct user instructions on the new landing page for both a vulnerable package search and a vulnerability search.  This raises various questions, including how best to refer to what we currently refer to as aliases, e.g., a CVE or GHSA.  Here's the text I'm currently using:
Search for comprehensive information for a VULCOID (VulnerableCode Database ID). (Only the first of these methods requires that the input be all uppercase.)
- Search for a specific VULCOID (e.g., "VULCOID-1").
- Search for all VULCOIDs that are associated with a specific CVE (e.g., "CVE-2009-3898") or GHSA (e.g., "GHSA-2qrg-x229-3v8q").
- Search for "CVE" or "GHSA" -- this will return all VULCOIDs that are associated with one or more CVEs or GHSAs, respectively.

And a screenshot:

I understand from colleagues' comments that the term alias is based on the term's use in the OSSF OSV schema, and that alternatively we could say, e.g., "Search for other vulnerability ids such as NVD's CVE or GitHub's GHSA."  We also have a model named Alias and use that term in some of our tabular displays of vulnerability (VULCOID) data.
What is our preferred vocabulary for this group of vulnerability IDs?

I believe this was handled several weeks ago, closing belatedly.

repo: nexB/vulnerablecode


text:
1주차 2단계 - 인수 테스트 리팩터링

안녕하세요~ 영철님😃
지난번에 피드백 주신 dto 생성 책임 관련해서 서비스 내의 비공개 메서드에서 dto의 정적 팩토리메서드로 리팩토링 해봤습니다.
중복 안되도록 처리하면서 중복 익셉션을 도입해서 해당 예외 발생시 ControllerAdvice에서 409를 리턴하도록 구현하였습니다.
인수테스트의 중복코드를 리팩터링하면서 나름대로 분리해봤는데 좋은 방향인지 궁금합니다~
리뷰 잘 부탁드립니다🙇♂

@zeroooooowest

중복 안되도록 처리하면서 중복 익셉션을 도입해서 해당 예외 발생시 ControllerAdvice에서 409를 리턴하도록 구현하였습니다.
인수테스트의 중복코드를 리팩터링하면서 나름대로 분리해봤는데 좋은 방향인지 궁금합니다~

네 오류를 서비스나 컨트롤러에서 catch해서 처리하게 되면
동일한 오류에 대해서 코드가 중복될 수도 있고,
또한 에러 처리로 인해 코드가 복잡해질 우려도 있습니다.
그런 점에서 저는 ControllerAdvice, RestControllerAdvice 사용하는게 오류 처리라는 기능의 응집도 측면에서 좋다고 생각합니다 :)

authors: ivvve zeroooooowest

repo: next-step/atdd-subway-map


text:
Step3 - 지하철 구간 관리

안녕하세요 리뷰어님!
벌써 마지막 step이네요. 너무 재미있게 미션 수행했습니다 😄
마지막 리뷰도 잘 부탁드립니다 🙇
노선 조회시 역 정보를 같이 반환하는 부분에서 목록 조회 관련 언급이 없어서 일단 노선 목록 조회시에도 역 정보를 같이 반환하도록 했습니다.
기획과의 협의! ㅋㅋㅋ 잘 기억하고 있습니다.
참고 부탁드립니다 🙏
즐거운 연휴 되세요!

추가적으로, 저 같은 경우 테스트를 할 당시 BDD 방식의 테스트를 선호하는데요, 미션을 진행하시다가 여유가 생기시거나 관심이 생기시면 한 번 시도해보시는것도 좋을 것 같습니다.
https://johngrib.github.io/wiki/junit5-nested/


text:
Step1 단계 리뷰 부탁드리겠습니다.

안녕하세요 리뷰어님
이번 미션 또한 상당히 어려웠네요 ㅠ
절차대로 따라가지만 조그마난 실수 때문에 시간이 오래걸리기도 하는거 같구요 ㅠ
네트워크와 로깅 관련해서 공부를 좀 더 진행해야 할거 같고 aws 인프라도 조금 더 공부 해봐야겠습니다.
단계를 따라가며 로깅을 해보았고 대시보드 구성도 해보았는데요.
부족한 부분이 있다면 코멘트 꼭 부탁드리겠습니다! 시간이 걸리더라도 차근차근 확인해보겠습니다!
감사합니다!

안녕하세요 리뷰어님! 코멘트 감사합니다!
회원 쪽이 중요한 로그라고 판단하여 모든 로그를 남기도록 하였는데요! 코멘트를 보고 조금 잘못생각했다고 판단하였습니다!
어떤식으로 로그를 남길지 고민을 많이 하였는데요!
일단 회원가입과 로그인의 경우에 로그를 남기도록 하였고, 로그인의 경우 패스워드는 남기지 않도록 하였습니다!
추가로 경로의 경우에는 JSON 포맷으로 파일로깅을 하였는데요.
멤버의 회원가입과 로그인과 다른 로그로 남기고 싶었고, JSON 포맷을 이용한 로깅을 한번 해보고 싶어서의 의미도 있었습니다!
다시한번 리뷰 부탁드리겠습니다!

repo: next-step/infra-subway-monitoring


text:
[prod] 26.0.0beta5

Signed-off-by: John Molakvoæ skjnldsv@protonmail.com

26 to 26.0.0 beta 5 upgrade failures are expected


text:
🛑 /getCommentsByUrl - Get comments list by video URL is down

In ec530d3, /getCommentsByUrl - Get comments list by video URL (https://nextpost.tech/tiktok-api/getCommentsByUrl?video_url=https%3A%2F%2Fwww.tiktok.com%2F%40onerepublic%2Fvideo%2F7141505394869898538%3Fis_copy_url%3D1%26is_from_webapp%3Dv1&cache_timeout=0&license_key=$API_KEY) was down:

HTTP code: 400
Response time: 11725 ms

Resolved: /getCommentsByUrl - Get comments list by video URL is back up in 6446448 after 300 days, 20 hours, 10 minutes.

repo: nextpost-tech/tiktok-status


text:
implement pipeline nf-test

Description of feature
implement pipeline nf-test

see here:
https://github.com/nf-core/rnaseq/tree/dev/tests

closed by #111

repo: nf-core/multiplesequencealign


text:
gunzip_ensembl_files fails with missing files

Issue
Error executing process > 'gunzip_ensembl_files'

Caused by:
  Missing output file(s) `*.dna*.fa` expected by process `gunzip_ensembl_files`

This respective work directory only contains the following files:
Homo_sapiens.GRCh38.103.gtf
Homo_sapiens.GRCh38.cdna.all.fa
Homo_sapiens.GRCh38.ncrna.fa
Homo_sapiens.GRCh38.pep.all.fa

@jgriss can you try again, I have fixed multiple errors in gunzip.

@ypriverol Unfortunately, now there's a new error:
Unknown method invocation `getFileSystem` on Boolean type

The error apparently doesn't occur in a process but in the main code.

the gunzip process is replaced with unzipping files in the pgatk package therefore I consider this issue resolved.

authors: husensofteng jgriss ypriverol

repo: nf-core/pgdb


text:
[Feature Request] Database xref as synonym for relationship directed search

Is your feature request related to a problem? Please describe.
Use xref mentions as synonym for parent-child directed search.
This is necessary to easily interop the nfdi4plants ontology with other ontologies.

Done!


text:
get the name of the playlist

#273 get the name of the playlist

Coverage increased (+0.8%) to 76.892% when pulling 52c2ada98b1d7b1c8bd772dff1404c926478f0eb on tenyearscoder:get-the-name-of-the-playlist into aac8ac91918ea9273cf3667b1f397ae4ddb348b5 on nficano:master.

god yes, please merge this. I need that feature for my automatic playlist downloader `,\

authors: AntiMatterAMA coveralls tenyearscoder

repo: nficano/pytube

license: Unlicense


text:
fix(contextualmenu): disabled not watched.

References #268.

Coverage decreased (-0.03%) to 98.425% when pulling 913c946010b69cde86a435340fea0c43ca849a85 on s-KaiNet:contextmenu-issue-268 into 7f1fd86a2c68418526339c1ae9dd05207809247d on ngOfficeUIFabric:dev.

Coverage remained the same at 98.455% when pulling 458d483efd5c543fcb8f37334cb17145f82c2447 on s-KaiNet:contextmenu-issue-268 into 7f1fd86a2c68418526339c1ae9dd05207809247d on ngOfficeUIFabric:dev.

authors: coveralls s-KaiNet

repo: ngOfficeUIFabric/ng-officeuifabric


text:
feat(gcc): update compiler and use webpack in tests

Updates build projects to the latest. This is not a breaking change relative to this project, though it's possible hoisting issues could cause odd behavior if the project is in an opensphere workspace that has not been updated. Workspaces using this project via NPM will not be impacted, but we may want to merge this alongside ngageoint/opensphere/pull/1244.
Update: This project picks up the Closure library via opensphere, so tests will fail until the above PR is merged. Carry on.

:tada: This PR is included in version 1.2.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

repo: ngageoint/opensphere-plugin-geopackage


text:
Email users password reset option

Make the "forgot password" process work.

password reset and email added

authors: Lbookman aazaff


text:
Remove usage info from log output

Remove usage info from log output.
Problem: When a critical error occurs at startup, usage information for the binary is dumped into the log output.
Solution: Set SilenceUsage to true in the cobra.Command. This problem was discussed here in an older discussion on cobra's github page.
Testing: Manually tested these cases (usage is there before the change and is no longer there after the change):

Running docker restart kind-control-plane which displayed the error recorded in a non-functional test here.
Not creating the NginxGateway CRD on startup.

Please focus on (optional): Should I set SilenceUsage in createProvisionerModeCommand? Currently its just in the StaticModeCommand. Also, as described in the discussion linked above, it mentions possibly setting SilenceUsage in the root command, should I instead put that in createRootCommand?
Closes #1105
Checklist
Before creating a PR, run through this checklist and mark each as complete.

[x] I have read the CONTRIBUTING doc
[x] I have added tests that prove my fix is effective or that my feature works
[x] I have checked that all unit tests pass after adding my changes
[x] I have updated necessary documentation
[x] I have rebased my branch onto main
[x] I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

I think we should also set SilenceError to true so we don't print the error message twice:
without SilenceError:
{"level":"info","ts":"2023-11-10T14:24:48-06:00","msg":"Starting NGINX Gateway Fabric in static mode","version":"edge","commit":"fbc33116eba7fc8e52c55dedb073d97bf8d00995","date":"2023-11-10T20:19:02Z"}
Error: error validating POD_IP environment variable: IP address must be set
error validating POD_IP environment variable: IP address must be set

with SilenceError:
{"level":"info","ts":"2023-11-10T14:31:26-06:00","msg":"Starting NGINX Gateway Fabric in static mode","version":"edge","commit":"fbc33116eba7fc8e52c55dedb073d97bf8d00995","date":"2023-11-10T20:30:42Z"}
error validating POD_IP environment variable: IP address must be set

Should I set SilenceUsage in createProvisionerModeCommand? Currently its just in the StaticModeCommand. Also, as described in the discussion linked above, it mentions possibly setting SilenceUsage in the root command, should I instead put that in createRootCommand?

I think it makes sense in the root command so that every subcommand inherits those values.

repo: nginxinc/nginx-gateway-fabric


text:
Upgrade to Angular 18

I'm submitting a
Feature request
Current behavior
Currently on Angular 17
Expected behavior
Should be available for Angular 18 as well
Minimal reproduction of the problem with instructions
No response
What is the motivation / use case for changing the behavior?
No response
Environment
No response

Hello PR are welcomed.

Should be available for Angular 18 as well

It's already available for Angular 18 as the current version peerDependencies are:
"peerDependencies": {
    "@angular/common": ">=16.0.0",
    "@angular/core": ">=16.0.0"
  },

I will try. Would be cool to use signals as well

authors: CharlieGreenman geromegrignon

repo: ngneat/edit-in-place


text:
Observable dies with skipWhile operator

Which @ngneat/elf-* package(s) are the source of the bug?
requests-cache
Is this a regression?
No
Description
In the documentation the skipWhile operator has been described as below:
In addition to value, you can pass in the same object a returnSource which will be returned by the operator if the request is cached. The default return value is EMPTY observable.

todos.service.ts
import { skipWhileTodosCached, setTodos } from './todos.repository';

export function fetchTodos() {
  return http.get(todosUrl).pipe(
    tap((todos) => setTodos(todos)),
    skipWhileTodosCached('todos', { returnSource: of([]) })
  );
}

but when i don't provide any return source then the observable dies. I don't want to pass an empty array either. I want the cached value in the next pipe.
export function fetchTodos() {
  return http.get(todosUrl).pipe(
    tap((todos) => setTodos(todos)),
    skipWhileTodosCached('todos'),
    tap(todos => console.log(todos)
  );
}

i want to print the cached todos with tap like the above mentioned code.
Please provide a link to a minimal reproduction of the bug
No response
Please provide the exception or error you saw
No response
Please provide the environment you discovered this bug in
angular

Anything else?
No response
Do you want to create a pull request?
No

That's not the purpose of this. You need to query the store if you want the value.

authors: NetanelBasal syedfahimabrar

repo: ngneat/elf


text:
[Documentation] For using untilDestroyed in non Angular apps

I found this in implementation that it can work with non angular apps by providing destroy method name
Using this in Stencil.js app untilDestroyed(this, 'disconnectedCallback')
This can be added in Readme file

Oh, Its already there

repo: ngneat/until-destroy


text:
Nested Property Keys

INFO: http://angular-formly.com/#/example/advanced/nested-property-keys

@divyakumarjain @aitboudad Should we support this? since Angular 2 itself is not supporting it.

For scenarios where form layout is not nested but model does have nested properties it will be tricky to place nested fields across the form layout. But keeping these fields grouped at single location in layout is possible using formly groups.
i think is good to have but may not be must have.

I did some initial work and seems to be working fine, I'll provide a PR soon!

Thanks @Pouja 🎆 🌟 🎉

Ok. Hi, again guys - so this actually should be supported... But i am running into problems with this.
I got a nested model and want to refer to one of the keys from my FormlyfieldConfig, like: key: "district.id" with a model like{ district: { id: 'UniqueId" }} but when i set my model on the form the nested field value just isn't reflected (/gets deleted) on the model anymore.

authors: FloNeu aitboudad divyakumarjain mohammedzamakhan

repo: ngx-formly/ngx-formly


text:
Type definitions for beforeCreateSchedule

Describe the bug
As interface IEvents, event handler beforeCreateSchedule has schedule parameter which is typeof ISchedule.
But actual object is
{
  start: TzDate,
  end: TZDate,
  guide: MonthGuide,
  isAllDay: Boolean,
  triggerEventName: string
}

Also In document (https://nhn.github.io/tui.calendar/latest/Calendar#event-beforeCreateSchedule), parameter type of beforeCreateSchedule is not ISchedule.
But in Type definitions for TOAST UI Calendar v1.13.1 (index.d.ts file in project)
export interface IEvents {
    'afterRenderSchedule'?: (eventObj: {schedule: ISchedule}) => void;
    'beforeCreateSchedule'?: (schedule: ISchedule) => void;
    'beforeDeleteSchedule'?: (eventObj: IEventScheduleObject) => void;
    'beforeUpdateSchedule'?: (eventObj: IEventObject) => void;
    'clickDayname'?: (eventObj: IEventDateObject) => void;
    'clickMore'?: (eventObj: IEventMoreObject) => void;
    'clickSchedule'?: (eventObj: IEventScheduleObject) => void;
    'clickTimezonesCollapseBtn'?: (timezonesCollapsed: boolean) => void;
}

as a result, I think it should be fixed for use typescript with tui-calendar

@mnoko33 Thanks for the report. It clearly needs to be fixed.


text:
Ensure discussion titles take up full width of card to minimise white space #342

Before PR:

After PR:

i like the before and after in the PR, makes it easier to see the change without having to pull the code down

Before the change made in Discover new Groups Homepage

After the change

Forum discussion title card

authors: jpmaHub tim-hunt

repo: nhsengland/futurenhs


text:
change image markup

Description
Checklist

[ ] Tested against our testing policy (Resolution, Browser & Accessibility)
[ ] Follows our coding standards and style guide
[ ] CHANGELOG entry

Probably needs a CHANGELOG entry. @AdamChrimes ?

Looks like the backstop tests are failing. https://travis-ci.org/nhsuk/nhsuk-frontend/jobs/592032901

Thanks @mayank this looks good, I'll have a quick test.
Please could you resolve the conflict with the CHANGELOG.md? Give me a shout if you need help with conflicts.

Just need to check the indenting on the HTML and Nunjuck macro snippets in the README
We use soft tabs with two spaces and nested elements should be indented once (two spaces).
Coding standards - Syntax

Backstop tests are still failing on this branch.
https://travis-ci.org/nhsuk/nhsuk-frontend/jobs/595674785 4 failures.

There are 12 commits here for one change. Would be good to rebase on master before merging.

I've undone the change to the pagination component so that BackstopJS tests are passing.
I've also tidied up some of the README adding the new arguments to the nunjucks macro table and cleaned up some of the examples.
Will squash all these commits into 1 on merge.

@mikemonteith you OK to give this another review please?

authors: AdamChrimes mayank1211 mikemonteith

repo: nhsuk/nhsuk-frontend


text:
Note change of phone no in next release (to coincide with v6 update)

On this page: https://service-manual.nhs.uk/content/a-to-z-of-nhs-health-writing#phone-and-phone-numbers
We have the phone number: 07771 900 900
Turns out it’s an actual real phone number.  07700 900 866 is usable from Ofcom’s TV and Drama range for things like this and have tested it.
If we can release this change ASAP, I'll note it in the What's new next time we do a major release.

@sarawilcox I'll get this out ASAP!

Update to What's new added into branch feature/back-link-button. Awaiting release.

Published.

authors: sarawilcox wa-rren-dev

repo: nhsuk/nhsuk-service-manual


text:
Create a partial view for the 'Get in touch' section

The 'Get in touch' section on component pages is duplicated across each of the components pages, rather than having the code duplicated multiple times, we could have a single partial view included on each of the pages.
This would save us time having to update each of the component pages if the get in touch details ever changed.

It's on many other pages of the site too.

This is going to be picked up as part of the service manual redesign.

authors: AdamChrimes sarawilcox


text:
Get the Prototype Kit domain name added to the HSCN protected DNS system

The prototype-kit.service-manual.nhs.uk domain has been added to the public DNS system but has not been set up on the HSCN Domain Name System (DNS).
This is preventing it from being accessed from some internal NHS networks.
To fix this we’ll need to request that it is also added to the HSCN DNS system.
See https://digital.nhs.uk/services/health-and-social-care-network/hscn-technical-guidance/dns

@anandamaryon1 would you be able to investigate this? Possibly an email to dnsteam@nhs.net might be enough to get it sorted?

Emailed them, let's see 🤞


text:
Handle error

If an error occurs while making an API call, the error message is displayed to the user. Modify this behavior so that a nice error message such as Can't retrieve data, try again later is printed instead of Type Error. If an error occurs, the error message is not removed immediately the user starts typing  in the input element. Change this behavior so that the error message is removed as soon as the user starts typing again. This issue can be reproduced if you try searching without internet connection.

This issue has been fixed

If an error occurs while making an API call, an appropriate message is displayed to the user
Modified behavior of removing  error message once a user starts entering another city name


text:
3 niveaux de menu ?

Bonjour,
Est-il possible de faire fonctionner facilement ce menu pour un menu à 3 niveaux ?

Hello,
nope, pas possible. Ceci dit, regarde dans les PR, y a un gros refactoring qui p-e le permet (j'ai jamais eu le temps de m'y pencher, honte à moi).

Merci pour ta réponse. De toutes façons, après quelques réflexions et recherches, il s'avère que ce n'est pas une bonne idée pour l'expérience utilisateur.

@juliemoynat oh oui, ça pose tellement de problèmes qu'en général ça en crée plus que ça n'en résout. :)


text:
[DEMO] TV-Mode

Hey,
I really love this plugin, one of the most used for me.
I configured it perfectly for my need.
I want to give the TV mode a try, but I have no test scenario available and do not want to loose my actual config, because I used several action on hardware wall switches as example.
Can I see somewhere pircutes of the mode?
Is it also possible to use both in combination, like for example "devicesToPublishAsAccessoriesSwitch"
Thanks!

Hi, if you want to give it a try , are on 0.0.x version of this plugin(I guess so) and don’t have any other Roku or lg web tv plugin that exposes such device in homebridge, you can just add a second platform to your homebridge config with this mode enabled, a different name, and same hub ip.
You have a video on my twitter account https://twitter.com/dujnic/status/1091094270814109696?s=21
Sent with GitHawk

Hey, if 2 platforms in parallel are working, great... I think I will give it a try.

What do you mean by such devices ?

Yes, only that hub which is exposed via your plugin to home.
What does that then mean no support for the older versions? Only TV mode? ....

No, only 1.x version of my plugin which will involve configuration changes
Sent with GitHawk

authors: Phoenix-DH nicoduj

repo: nicoduj/homebridge-harmony


text:
Cannot update plugin:

I have updated my plugins without any problem, except Xiaomi... :(
I thought it maybe was git, but it's installed and working.
pi@raspberrypi:~ $ sudo npm install -g -unsafe-perm homebridge-xiaomi-roborock-vacuum@latest -g
npm ERR! code 128
npm ERR! Command failed: /usr/bin/git clone --depth=1 -q -b master git://github.com/nicoh88/miio.git /root/.npm/_cacache/tmp/git-clone-50f943cd
npm ERR! fatal: could not create leading directories of '/root/.npm/_cacache/tmp/git-clone-50f943cd': Permission denied
npm ERR!

npm ERR! A complete log of this run can be found in:
npm ERR!     /root/.npm/_logs/2019-06-23T08_27_35_646Z-debug.log
pi@raspberrypi:~ $ sudo npm outdated -g
Package                            Current  Wanted  Latest  Location
homebridge-xiaomi-roborock-vacuum    0.4.0   0.4.2   0.6.0
npm                                  6.4.1   6.9.0   6.9.0
pi@raspberrypi:~ $ sudo npm install -g -unsafe-perm homebridge-xiaomi-roborock-vacuum@latest -g
npm ERR! code 128
npm ERR! Command failed: /usr/bin/git clone --depth=1 -q -b master git://github.com/nicoh88/miio.git /root/.npm/_cacache/tmp/git-clone-5b419228
npm ERR! fatal: could not create leading directories of '/root/.npm/_cacache/tmp/git-clone-5b419228': Permission denied
npm ERR!

npm ERR! A complete log of this run can be found in:
npm ERR!     /root/.npm/_logs/2019-06-23T08_29_13_953Z-debug.log
pi@raspberrypi:~ $ npm install -g homebridge-xiaomi-roborock-vacuum@latest --unsafe-perm
npm WARN checkPermissions Missing write access to /usr/lib/node_modules/homebridge-xiaomi-roborock-vacuum/node_modules/ieee754
npm WARN checkPermissions Missing write access to /usr/lib/node_modules/homebridge-xiaomi-roborock-vacuum/node_modules/inherits
npm WARN checkPermissions Missing write access to /usr/lib/node_modules/homebridge-xiaomi-roborock-vacuum/node_modules/ms
npm WARN checkPermissions Missing write access to /usr/lib/node_modules/homebridge-xiaomi-roborock-vacuum/node_modules/process-nextick-args
npm WARN checkPermissions Missing write access to /usr/lib/node_modules/homebridge-xiaomi-roborock-vacuum/node_modules/miio
npm WARN checkPermissions Missing write access to /usr/lib/node_modules/homebridge-xiaomi-roborock-vacuum
npm WARN checkPermissions Missing write access to /usr/lib/node_modules/homebridge-xiaomi-roborock-vacuum/node_modules
npm WARN checkPermissions Missing write access to /usr/lib/node_modules
npm ERR! path /usr/lib/node_modules/homebridge-xiaomi-roborock-vacuum/node_modules/ieee754
npm ERR! code EACCES
npm ERR! errno -13
npm ERR! syscall access
npm ERR! Error: EACCES: permission denied, access '/usr/lib/node_modules/homebridge-xiaomi-roborock-vacuum/node_modules/ieee754'
npm ERR!  { Error: EACCES: permission denied, access '/usr/lib/node_modules/homebridge-xiaomi-roborock-vacuum/node_modules/ieee754'
npm ERR!   stack: 'Error: EACCES: permission denied, access \'/usr/lib/node_modules/homebridge-xiaomi-roborock-vacuum/node_modules/ieee754\'',
npm ERR!   errno: -13,
npm ERR!   code: 'EACCES',
npm ERR!   syscall: 'access',
npm ERR!   path: '/usr/lib/node_modules/homebridge-xiaomi-roborock-vacuum/node_modules/ieee754' }
npm ERR!
npm ERR! The operation was rejected by your operating system.
npm ERR! It is likely you do not have the permissions to access this file as the current user
npm ERR!
npm ERR! If you believe this might be a permissions issue, please double-check the
npm ERR! permissions of the file and its containing directories, or try running
npm ERR! the command again as root/Administrator (though this is not recommended).

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/pi/.npm/_logs/2019-06-23T08_30_40_816Z-debug.log

Try:
sudo su -
npm install -g homebridge-xiaomi-roborock-vacuum@latest --unsafe-perm

sudo su - is importent

Thanks! I'm not that into Linux and all... so I have no idea why this plugin needs this and others don't.

pi@raspberrypi:~ $ sudo su -
root@raspberrypi:~# npm install -g homebridge-xiaomi-roborock-vacuum@latest --unsafe-perm

homebridge-xiaomi-roborock-vacuum@0.6.0
updated 6 packages in 21.771s
root@raspberrypi:~#

But thanks. I hope that the issue of not activating on first try is fixed now. I always needed to tick the vacuum, switch it off and then again on in the home app to let him do his job.

If you have further problems, please open a new issue. 😄


text:
enable the conversation of single files to typescript

Checklist

[x] Use a separate branch in your local repo (not master).
[x] Test coverage is 100% (or you have a story for why it's ok).

@googlebot I signed it!

Please rebase this over the phases-overhaul branch.  Otherwise, it will be hard to merge this with all the changes in there.

Did so for now and added some initial typing based on @Oliboy50 progress linked in #190.
Will have to check with the actual phase changes though.
And some tests fail atm, will get to that after sleep.

Removed the initial typings for now, but left files and tests as tsx, so we would see if that causes any errors in publishing/bundling.

The tsx files are causing some test failures.  Can you take a look?
Let's just use this PR to strip the prefixes of the .js imports?

@ksjogo Are you still interested in getting this in?  The phases-overhaul branch has been merged into master so you can just work off the master branch.

Hey @nicolodavis ,yeah I am still interested in this. Just moved countries, will fix/rebase in the next days.

authors: ksjogo nicolodavis


text:
[Feature Request] Support for libretranslate.com

Description
Support for https://libretranslate.com/
Also, I think in this case, the construct should have the url as parameter, since as described at https://github.com/LibreTranslate/LibreTranslate#mirrors , the project can be used locally or by other servers.

Hey @nidhaloff I am really new to contributing to open-source projects, but would love to help out here.
Could I take this issue? If all goes according to plan, I should be able to work on this in the next week. Hopefully it won't take me too much time to implement.

@ridicolos Sure, just make a PR ;)

@ridicolos Any progress on this feature?

@nidhaloff unfortunately not yet. If you want to take over the issue right away, you can. I'm not sure how soon I'll get to it.
I'll probably manage to work on it a bit on sunday, but probably won't be able to finish it then.

Hi! Is this issue up for grabs?

Hey @rahulbanerjee26, because I unfortunately still haven't got around to starting the issue i don't think anything stands in the way and you can start with the implementation

Thanks, @ridicolos
@nidhaloff could you please assign the issue to me? I should have a PR out in a week or so, thanks!

Hi @rahulbanerjee26 thanks for joining. Normally I'm against assigning issues to specific people and I would prefer that anyone can work on it and just make a PR if something is ready. However, I would assign the issue to you in this case if you keep us updated about findings, changes, etc... ;)

Hi! @nidhaloff thank you!
Just to give you a bit of context, one of my courses in my university requires me to make an open-source contribution. I am a part of a team of 5 and the entire team will work together on making the PR.
We found an API Wrapper for libretranslate and are investigating it to see if it can be used. If the wrapper has any limitations, we plan on consuming the API directly instead.

@rahulbanerjee26 Sounds great. I'd rather not add a dependency/lib. The wrapper does not look mature and therefore, it would be great if you guys can make use of the existing dependencies. As you said, calling the API directly should be straightforward

Hi! @nidhaloff, we just made a PR for this feature.

authors: fcolecumberri nidhaloff rahulbanerjee26 ridicolos

repo: nidhaloff/deep-translator


text:
Fix parser

Hi Nils, this is a fix for not having values of:

speed
energy
power

that's my setup at home.
thank you for your project

Looks good, thank you for the proposed fix! Did you try this script at home/can you elaborate what needed to be fixed?

Yes you are understanding that correctly, in my setup there is nothing like speed/energy/power messurments. So in the data it is missing.
My old blnet is "ill" and do not function as it should anymore. So I decided to integrate the direct connection with your project and it doesn't work out of the box. This is the fix for it.

I also added a test for the parser, but it fails in py3.8 in Travis CI. Don't know why.

I also don't see why 3.8 is failing, but it's unrelated to your change. Looks good to me :)

what I do not understand, that i have speed values (in php version) but did not get it here with BLNETDirect

authors: nielstron zwotzie

repo: nielstron/pyblnet


text:
35 building documentation

Fixes #35
Fixes #38

Current CI crash can be reproduced locally in MacOS with python -m pytest examples/tractography.ipynb

repo: niivue/ipyniivue


text:
Add --count flags to list-* commands (#444)

This PR adds the --count option to the list-* commands which outputs the number of filtered items (e.g. windows). This flag is mutually exclusive with the --format option.
Example usage:
$ aerospace list-windows --workspace focused --count
3

This is draft PR since the --count is currently added only for the list-windows command. Before I'll update the other commands, @nikitabobko, does this look a correct approach? I'm still figuring out the code base.
Resolve #444

You also probably need ot update these lines:
diff --git a/Sources/Common/cmdArgs/impl/ListWindowsCmdArgs.swift b/Sources/Common/cmdArgs/impl/ListWindowsCmdArgs.swift
index 044d6c26..d0e13ce4 100644
--- a/Sources/Common/cmdArgs/impl/ListWindowsCmdArgs.swift
+++ b/Sources/Common/cmdArgs/impl/ListWindowsCmdArgs.swift
@@ -57,14 +57,14 @@ public func parseRawListWindowsCmdArgs(_ args: [String]) -> ParsedCmd<ListWindow
             }
         }
         .filter("--all conflicts with \"filtering\" flags. Please use '--monitor all'") { raw in
-            !raw.all || raw == ListWindowsCmdArgs(rawArgs: .init([]), all: true, format: raw.format)
+            !raw.all || raw == ListWindowsCmdArgs(rawArgs: .init([]), all: true, format: raw.format, outputOnlyCount: raw.outputOnlyCount)
         }
         .filter("--focused conflicts with \"filtering\" flags") { raw in
-            !raw.focused || raw == ListWindowsCmdArgs(rawArgs: .init(args), focused: true, format: raw.format)
+            !raw.focused || raw == ListWindowsCmdArgs(rawArgs: .init(args), focused: true, format: raw.format, outputOnlyCount: raw.outputOnlyCount)
         }
         .map { raw in
             // Normalize alias
-            raw.all ? ListWindowsCmdArgs(rawArgs: .init(args), monitors: [.all], format: raw.format) : raw
+            raw.all ? ListWindowsCmdArgs(rawArgs: .init(args), monitors: [.all], format: raw.format, outputOnlyCount: raw.outputOnlyCount) : raw
         }
 }

Thanks!
Merged with the following patch squashed to your appropriate commits:
diff --git a/Sources/AppBundleTests/command/ListWindowsTest.swift b/Sources/AppBundleTests/command/ListWindowsTest.swift
index cfa090e2..e739c1af 100644
--- a/Sources/AppBundleTests/command/ListWindowsTest.swift
+++ b/Sources/AppBundleTests/command/ListWindowsTest.swift
@@ -14,10 +14,10 @@ final class ListWindowsTest: XCTestCase {
         assertEquals(parseCommand("list-windows --all --count --format %{window-title}").errorOrNil, "ERROR: Conflicting options: --count, --format")
         assertEquals(
             parseCommand("list-windows --all --focused --monitor mouse").errorOrNil,
-            "ERROR: Conflicting options: --all, --focused, --monitor")
+            "ERROR: Conflicting options: --all, --focused")
         assertEquals(
             parseCommand("list-windows --all --focused --monitor mouse --workspace focused").errorOrNil,
-            "ERROR: Conflicting options: --all, --focused, --monitor, --workspace")
+            "ERROR: Conflicting options: --all, --focused, --workspace")
         assertEquals(
             parseCommand("list-windows --all --workspace focused").errorOrNil,
             "ERROR: Conflicting options: --all, --workspace")
diff --git a/Sources/Common/cmdArgs/impl/ListWindowsCmdArgs.swift b/Sources/Common/cmdArgs/impl/ListWindowsCmdArgs.swift
index abf81607..ac5befda 100644
--- a/Sources/Common/cmdArgs/impl/ListWindowsCmdArgs.swift
+++ b/Sources/Common/cmdArgs/impl/ListWindowsCmdArgs.swift
@@ -22,7 +22,8 @@ public struct ListWindowsCmdArgs: CmdArgs {
         ],
         arguments: [],
         conflictingOptions: [
-            ["--all", "--focused", "--workspace", "--monitor"],
+            ["--all", "--focused", "--workspace"],
+            ["--all", "--focused", "--monitor"],
             ["--format", "--count"],
         ]
     )
@@ -58,7 +59,7 @@ public func parseRawListWindowsCmdArgs(_ args: [String]) -> ParsedCmd<ListWindow
         }
         .map { raw in
             // Normalize alias
-            raw.all ? ListWindowsCmdArgs(rawArgs: .init(args), monitors: [.all], format: raw.format) : raw
+            raw.all ? ListWindowsCmdArgs(rawArgs: .init(args), monitors: [.all], format: raw.format, outputOnlyCount: raw.outputOnlyCount) : raw
         }
 }

diff --git a/Sources/Common/cmdArgs/parseSpecificCmdArgs.swift b/Sources/Common/cmdArgs/parseSpecificCmdArgs.swift
index dde0925c..d2f58065 100644
--- a/Sources/Common/cmdArgs/parseSpecificCmdArgs.swift
+++ b/Sources/Common/cmdArgs/parseSpecificCmdArgs.swift
@@ -39,6 +39,7 @@ public func parseSpecificCmdArgs<T: CmdArgs>(_ raw: T, _ args: [String]) -> Pars
         let mutualOptions = conflictSet.intersection(options)
         if mutualOptions.count > 1 {
             errors.append("Conflicting options: \(mutualOptions.sorted().joined(separator: ", "))")
+            break
         }
     }

diff --git a/grammar/commands-bnf-grammar.txt b/grammar/commands-bnf-grammar.txt
index a688e519..e4f6de71 100644
--- a/grammar/commands-bnf-grammar.txt
+++ b/grammar/commands-bnf-grammar.txt
@@ -82,13 +82,13 @@ aerospace -h;

     | list-monitors [--focused [no] | --mouse [no] | --format <output_format> | --count]...

-    | list-windows [<list_windows_filter_flag> | (--format <output_format>|--count)]...
-    | list-windows [--format <output_format>|--count]... --all [--format <output_format>|--count]...
-    | list-windows [--format <output_format>|--count]... --focused [--format <output_format>|--count]...
+    | list-windows [<list_windows_filter_flag> | --format <output_format> | --count]...
+    | list-windows [--format <output_format>|--count] --all [--format <output_format>|--count]
+    | list-windows [--format <output_format>|--count] --focused [--format <output_format>|--count]

-    | list-workspaces [<list_workspaces1_flag> | (--format <output_format>|--count)]... --monitor <monitor_id>... [<list_workspaces1_flag> | (--format <output_format>|--count)]...
-    | list-workspaces [--format <output_format>|--count]... --all [--format <output_format>|--count]...
-    | list-workspaces [--format <output_format>|--count]... --focused [--format <output_format>|--count]...
+    | list-workspaces [<list_workspaces1_flag>]... --monitor <monitor_id>... [<list_workspaces1_flag>]...
+    | list-workspaces [--format <output_format>|--count] --all [--format <output_format>|--count]
+    | list-workspaces [--format <output_format>|--count] --focused [--format <output_format>|--count]
     ;

 <window_id> ::= {{{ aerospace list-windows --all --format '%{window-id}%{right-padding}%{tab}%{app-name}%{right-padding} | %{window-title}' }}};
@@ -98,7 +98,7 @@ aerospace -h;
 <number> ::= {{{ true }}};
 <monitor_pattern> ::= {{{ true }}};

-<list_workspaces1_flag> ::= --visible [no] | --empty [no] | --format <output_format>;
+<list_workspaces1_flag> ::= --visible [no] | --empty [no] | --format <output_format> | --format <output_format> | --count;

 <focus_flag> ::= --boundaries <boundary>|--boundaries-action <boundaries_action>|--ignore-floating;
 <boundaries_action> ::= stop|wrap-around-the-workspace|wrap-around-all-monitors;

authors: Henkru nikitabobko

repo: nikitabobko/AeroSpace


text:
VVS-API is now private

Module throws exception, bit research on https://www.opendata-oepnv.de/ht/de/api, turns out you need an API-Key.
If I haven't missed a thing you can take this module down for now.
Pls close, wasn't right, API is still there, but configuration changed.

you can close the issue

repo: niklaskappler/MMM-vvsDeparture


text:
Javacript Math unavailable

I am unable to get the functions in https://github.com/nikolaeu/Numi-extensions/blob/master/CommunityExtensions/MinMax/MinMax.js to work.
I copy-pasted it into my Default.js, and they still do not function:

In comparison, I was able to add triangle number summation:
numi.addFunction({ id: "triangleSumm", phrases: "triangleSumm" }, function(
  values
) {
  return { double: (values[0].double * (values[0].double + 1)) / 2 };
});

Whoops, I see I am using commas and not semi-colons

repo: nikolaeu/Numi-extensions


text:
2.8.9打开卡死

2.8.9打开慢，右键直接无响应，2.7.4没有这这种反应

我这边没有遇到这个问题 你重新下载试试？

下载了，还是一样，不很奇怪然后还提示有病毒

我下载源码重新编译了，已经不出现无响应的问题了，感谢

使用Costura.Fody插件将程序打包成一个可以独立运行的EXE文件，运行后不提示病毒也不显示无响应了，文件的大小变成了645k

使用Costura.Fody插件将程序打包成一个可以独立运行的EXE文件，运行后不提示病毒也不显示无响应了，文件的大小变成了645k

谢谢，的确是一个很好插件！今后会使用此种方式打包。

authors: nilaoda xzeu


text:
[RESOLVED] Interface eth0(): High error rate (>2 for 5m)

Problem started at 15:36:29 on 2023.04.20
Problem name: Interface eth0(): High error rate (>2 for 5m)
Host: S100-Primario
Severity: Warning
Operational data: errors in: 2, errors out: 0
Original problem ID: 19797
Event details in Zabbix: http://192.168.232.99/tr_events.php?triggerid=23483&eventid=19797

Problem has been resolved in 15m 0s at 15:51:29 on 2023.04.20
Problem name: Interface eth0(): High error rate (>2 for 5m)
Host: S100-Primario
Severity: Warning
Original problem ID: 19797


text:
关于只能使用powershell执行的问题

今天心血来潮pull了一下更新，然后原本的方式不能用了
我原本是在桌面为akhelper.py创建了一个快捷方式，现在双击快捷方式无用，在原本文件夹中双击akhelper.py也无用，只能通过用powershell运行
python akhelper.py
来打开。后来发现用cmd执行上述命令结果就是如下：

程序初始化似乎不成功，但使用powershell就没问题

我在网络上并没有找到关于这种只能用powershell运行不能用cmd运行的原因，也许和脚本内部代码有关？能请帮忙解答一下吗？谢谢

看看 cmd 里 where python 和 powershell 里 Get-Command python 是否指向同一个文件？

看了一眼指向的文件没问题，目前是通过git暂且回滚到上个版本就解决了这个问题，后续我再找找这个问题根源吧，谢谢了

authors: ArsKoe dantmnf

repo: ninthDevilHAUNSTER/ArknightsAutoHelper


text:
Remove app_name label from manifest

> Manifest merger failed : Attribute application@label value=(@string/label_application) from AndroidManifest.xml:16:7-48
  	is also present at [com.github.niorgai:StatusBarCompat:2.1.3] AndroidManifest.xml:13:9-41 value=(@string/app_name).
  	Suggestion: add 'tools:replace="android:label"' to <application> element at AndroidManifest.xml:6:3-8:37 to override.```

Did you import the lib like this ?
 compile ('com.github.niorgai:StatusBarCompat:2.1.3', {
            exclude group: 'com.android.support'
        })

authors: mseroczynski niorgai

repo: niorgai/StatusBarCompat


text:
fsaverage being deleted when running multiple subjects in parallel

What happened?
I'm re-running fmriprep 23.2.0 on my data in order to take advantage of the added msmsulc registration so I'm submitting multiple subjects in parallel. However I'm seeing crashes during the freesurfer step because fsaverage is being deleted and re-written. The error is below. In the log I see there is an option for "overwrite_fsaverage" that is set to False. Perhaps if it is set to True the files would be overwritten fast enough to prevent this from occurring.
Node inputs:

derivatives = /scratch/group/congalab/vts_reward_mri/derivatives/fmriprep
freesurfer_home = /opt/freesurfer
minimum_fs_version = 7.0.0
overwrite_fsaverage = False
spaces = []
subjects_dir = /scratch/group/congalab/vts_reward_mri/derivatives/fmriprep/sourcedata/freesurfer

What command did you use?
singularity run -B ${TEMPLATEFLOW_HOME:-/scratch/group/congalab/software/templateflow}:/templateflow --cleanenv --home $SCRATCH -B /scratch/user/joseph.orr/:/work /scratch/group/congalab/software/fmriprep_23.2.0.sif /scratch/group/congalab/vts_reward_mri/bids/ /scratch/group/congalab/vts_reward_mri/derivatives/fmriprep participant --participant-label ${subject} --fs-license-file $FS_LICENSE --me-output-echos --me-t2s-fit-method curvefit --nthreads 16 --omp-nthreads 16 --mem 116000

What version of fMRIPrep are you running?
23.2.0
How are you running fMRIPrep?
Singularity
Is your data BIDS valid?
Yes
Are you reusing any previously computed results?
No
Please copy and paste any relevant log output.
shutil.Error: [('/opt/freesurfer/subjects/fsaverage/label/lh.BA1_exvivo.label', '/scratch/group/congalab/vts_reward_mri/derivatives/fmriprep/sourcedata/freesurfer/fsaverage/label/lh.BA1_exvivo.label', "[Errno 2] No such file or directory: '/scratch/group/congalab/vts_reward_mri/derivatives/fmriprep/sourcedata/freesurfer/fsaverage/label/lh.BA1_exvivo.label'"), ('/opt/freesurfer/subjects/fsaverage/label/lh.BA1_exvivo.thresh.label', '/scratch/group/congalab/vts_reward_mri/derivatives/fmriprep/sourcedata/freesurfer/fsaverage/label/lh.BA1_exvivo.thresh.label', "[Errno 2] No such file or directory: '/scratch/group/congalab/vts_reward_mri/derivatives/fmriprep/sourcedata/freesurfer/fsaverage/label/lh.BA1_exvivo.thresh.label'"), ('/opt/freesurfer/subjects/fsaverage/label/lh.BA2_exvivo.label', '/scratch/group/congalab/vts_reward_mri/derivatives/fmriprep/sourcedata/freesurfer/fsaverage/label/lh.BA2_exvivo.label', "[Errno 2] No such file or directory: '/scratch/group/congalab/vts_reward_mri/derivatives/fmriprep/sourcedata/freesurfer/fsaverage/label/lh.BA2_exvivo.label'"), ('/opt/freesurfer/subjects/fsaverage/label/lh.BA2_exvivo.thresh.label', '/scratch/group/congalab/vts_reward_mri/derivatives/fmriprep/sourcedata/freesurfer/fsaverage/label/lh.BA2_exvivo.thresh.label', "[Errno 2] No such file or directory: '/scratch/group/congalab/vts_reward_mri/derivatives/fmriprep/sourcedata/freesurfer/fsaverage/label/lh.BA2_exvivo.thresh.label'"), ('/opt/freesurfer/subjects/fsaverage/mri', '/scratch/group/congalab/vts_reward_mri/derivatives/fmriprep/sourcedata/freesurfer/fsaverage/mri', "[Errno 17] File exists: '/scratch/group/congalab/vts_reward_mri/derivatives/fmriprep/sourcedata/freesurfer/fsaverage/mri'"), ('/opt/freesurfer/subjects/fsaverage/xhemi', '/scratch/group/congalab/vts_reward_mri/derivatives/fmriprep/sourcedata/freesurfer/fsaverage/xhemi', "[Errno 17] File exists: '/scratch/group/congalab/vts_reward_mri/derivatives/fmriprep/sourcedata/freesurfer/fsaverage/xhemi'")]

Additional information / screenshots
No response

This is an interaction of a "feature" (https://github.com/nipreps/niworkflows/pull/739) and running in parallel (https://github.com/nipreps/fmriprep/issues/2505). If you start one subject and let it completely replace the fsaverage directory, then the rest should not attempt to delete.

Got it, thanks!

Ah, sorry, not #2505 but https://github.com/nipreps/niworkflows/issues/804. Anyway, closing as a duplicate of that. Dealing with that race is a long-standing ideal, but handling it robustly for different filesystems (e.g., network and Windows filesystems, proxied through Docker's VFS) has been a challenge.

PRs and testing welcome, though!

authors: effigies oricon

repo: nipreps/fmriprep


text:
gva per sector for scenarios 0, 1, 2 different order of magnitude to baseline

For example:

timestep
lad_uk_2016
sectors
gva_per_sector
baseline
unplanned
new-cities

2015
E06000001
2
13.812944
10824.195921
13.812944
13.812944

2015
E08000017
28
471.836332
8772.237410
471.836332
471.836332

2015
E07000084
8
7.565480
1437.441149
7.565480
7.565480

2015
E08000017
27
264.779320
9523.968665
264.779320
264.779320

2015
E07000084
9
0.385775
478.360871
0.385775
0.385775

2015
E08000017
23
295.547540
10630.684871
295.547540
295.547540

2015
E07000084
10
23.466302
6006.889354
23.466302
23.466302

2015
E08000017
19
441.898150
7300.736982
441.898150
441.898150

Closed by #3

repo: nismod/arc-economics


text:
Evaluate adding https://bandit.readthedocs.io/en/latest/ to precommit

Automatic security checks.

Bandit has been in use in this repo since beginning of June. I also use it on some of Niteo's internal project and like it so far. Good find!

repo: niteoweb/pyramid-realworld-example-app


text:
installation USBs are not listed

Thank you for the work.
I have a problem with the installation(Monterey/Ventura).
The installation USBs are not listed.
Only the already installed ones are found on another hackintosh.
I created them on another hackintosh and tried them there, they work.
fastboot is disabled
Richie
sorry for my bad english

@IamTheRichie try disabling HIDE AXULUARY and enabling Show picker from misc on your EFI.

@IamTheRichie try disabling HIDE AXULUARY and enabling Show picker from misc on your EFI.

authors: IamTheRichie devboloji


text:
May need several tries to make Ctrl-click work for "Goto Definition"

Description
Please refer $subject.

Fixed with #9. Hence closing the issue.


text:
Provide configuration files for Nginx and Apache

Windows
Linux

No longer relevant

authors: ghost proto-h

repo: njcom/framework


text:
Navbar for collection page

Navbar.js for collection page

Conflicting files

authors: Lawzstopwar nk-mart


text:
Pairing an ESP32 with a health device from the client (master)

Hi,
I have a glucometer (Beurer GL50 EVO) which can work in BLE mode.
I want to get all glucose measurements from it.
I want to do this using an ESP32-C3.
I have walked through the characteristics using nrfConnect, and evrything works fine.
I have tried to do the same using my ESP32, and it works fine until I send a code "0x0101" to a certain characteristic meaning "send all mesurements".
With nrfConnect these measurements are send via notifications.
When I ask this with nrfConnect, the first time the request is refused, and nrfConnect tries then to pair with the device. Pairing request is sent by the client.
The problem is that when I ask this from the ESP32 using a writeValue(), I don't have any error. In fact nothing happens, and the loop goes on.
This is my first question, what to do to see the error?
The second question is: is there an example somewhere of pairing initiated by the client, not the server. In my case the PIN is known, no need to display anything. I can send it directly.
I've searched a lot, and only fond pairing requests initiated by the server.
BTW: I have seen all this using wireshark on the btsnoop_hci.log file produced on my Android phone.
Thanks in advance

After reading BLE lib code all day long I have finally found how to detect an error (ESP_GATT_INSUF_AUTHENTICATION in my case).
All I need now is an example of code that does pairing initiated by the client (master).
Hope someone will help me.

I have found an example here
My problem is solved. The app works fine on an ESP32-C3.
I close this issue.


text:
WebServer serving issue

creating the following handler definition:
HttpServer* pHttpServer = new HttpServer();
std::regex ppath("\\/hello.*");
pHttpServer->addPathHandler("GET",   &ppath,      		           handleROOT);

will result correct handling & serving by the handler, monitor however shows:
I (33489) HtttpResponse: Opening file: /hello
E (33490) HttpResponse: Unable to open file /hello for reading
means although the handler was found and processed, the server tries to get the file from file system (should happen only if handler was not found).

Does your handleROOT add a proper prefix to the filename, f.i. '/spiffs/hello' or 'sdcard/hello' so that an actual filesystem is searched?

authors: HanVertegaal zafrirron


text:
Add support of nullable fields to NLOHMANN_DEFINE_TYPE_NON_INTRUSIVE and NLOHMANN_DEFINE_TYPE_INTRUSIVE

What is the issue you have?

When I try to deserialize JSON which contains nullable string fields into an object with (de)serializers generated by NLOHMANN_DEFINE_TYPE_NON_INTRUSIVE macro, the program throws an exception at this point:
from_json.hpp line 80
error:
Exception thrown at 0x764A4DBD in TrelloBackup.exe: Microsoft C++ exception: nlohmann::detail::type_error at memory location 0x00FAE7B8.
Unhandled exception at 0x764A4DBD in TrelloBackup.exe: Microsoft C++ exception: nlohmann::detail::type_error at memory location 0x00FAE7B8.
Exception thrown: read access violation.
_Right was nullptr.
Please describe the steps to reproduce the issue.

Create a json like this:
{
      "cover":{
         "idAttachment":null,
         "color":null,
         "idUploadedBackground":null,
         "size":"normal",
         "brightness":"light"
      }
}

Define classes like this:
#pragma once

#include <string>
#include <vector>
#include <nlohmann/json.hpp>

using namespace std;
using json = nlohmann::json;

namespace TrelloDtos {

	class CoverDto {
	public:
		string idAttachment;
		string size;
	};

	class CardDto {
	public:
		CoverDto cover;
	};
		NLOHMANN_DEFINE_TYPE_NON_INTRUSIVE(CoverDto, idAttachment, size)
		NLOHMANN_DEFINE_TYPE_NON_INTRUSIVE(CardDto, cover)
}

Then try to deserialize:

voidTrelloApi::findCards(string response) {
    json jsonObj = json::parse(response);
    CardDto cardDto = jsonObj .get<CardDto>(); <--- at this point the exception is thrown
}

I had to write custom (de)serailizers to handle nullable fields like this:
void TrelloDtos::to_json(json& j, const CoverDto& p) {
	j = json{ {"idAttachment", p.idAttachment},{"size", p.size} };
}

void TrelloDtos::from_json(const json& j, CoverDto& p) {
	auto idAttachment = j.at("idAttachment");
	if (!idAttachment.is_null()) {
		idAttachment.get_to(p.idAttachment);
	}
	auto size = j.at("size");
	if (!size.is_null()) {
		size.get_to(p.size);
	}
}

What is the expected behavior?
I would expect the logic generated by macros not to crash if it stumbles upon a nullable field, but set nullpointr or some default value to the field.
And what is the actual behavior instead?
Exception is thrown.
Which compiler and operating system are you using?

Compiler: Win32
Operating system: Windows 8.1

Which version of the library did you use?

[x] latest release version 3.9.1

If you experience a compilation error: can you compile and run the unit tests?

[ ] yes
[x] no - please copy/paste the error message below

This is not a bug, but the expected behavior of the macros. If you need anything beyond a mapping of members to object keys, you need to define your own conversion functions, just as you did.

Thank you for the clarification!
I am curious, would it make sense to improve those macros to handle nullability of the field?

I think changing the existing macros' behavior would not be helpful as this would break existing code. I'm not sure whether adding another pair of macros like NLOHMANN_DEFINE_TYPE_NON_INTRUSIVE_NULLABLE would be a good idea. Any thoughts?

can we use std::optional for C++ data types used in nlohmann::json This way we can add support of std::nullopt for values atleast.
Datatypes are mentioned here

can we use std::optional for C++ data types used in nlohmann::json This way we can add support of std::nullopt for values atleast.
Datatypes are mentioned here

Optionals are a C++17 feature. We are working on support for built-in support for them, see #2229.

I don't think NLOHMANN_DEFINE_TYPE_NON_INTRUSIVE_NULLABLE would be very useful after #2229 is merged in?

authors: PrintScr SahibYar nlohmann serg06

repo: nlohmann/json


text:
Issues with the arithmetic in iterator and reverse iterator

Hi, I just found that the iterator class hasn't override the n + iterator operator, which is a requirement in the random access iterator type.
More specifically, this operator is missing:
operator+(difference_type, const iter_impl&);

The failing code is:
json j_object
auto it = j_object.cbegin();
1 + it; // error

Actually I found some more issues during the fix up.
The iter_impl was defined as a random access iterator (https://github.com/nlohmann/json/blob/develop/src/json.hpp#L7994), but a couple of lines later, the iterator category is then changed to bidirectional (https://github.com/nlohmann/json/blob/develop/src/json.hpp#L8018). I tried to fix this, but it introduced some fail the test cases of distance(rbegin(), rend()) == size().
So I dig it up and found that the json reverse iterator is overriding all the operators, while the implementation of the iter - iter operator is not correct (https://github.com/nlohmann/json/blob/develop/src/json.hpp#L8677). Instead of this->base() - other.base(), it should be other.base() - this->base().
Here is the implementation in llvm:
template <class _Iter1, class _Iter2>
inline _LIBCPP_INLINE_VISIBILITY
typename reverse_iterator<_Iter1>::difference_type
operator-(const reverse_iterator<_Iter1>& __x, const reverse_iterator<_Iter2>& __y)
{
    return __y.base() - __x.base();
}

In addition, the iter + n and iter - n operators are implemented in a reversed way.
Personally, I would recommend remove all the operator override in the reverse iterator, since the template class reverse_iterator<iterator> should give us all the correct implementations.

I noticed that the iter - iter issue also occurred in iter_impl and primitive_iterator. They were all implemented as lhs - rhs, however rhs - lhs should be correct.

Sorry, I made a mistake in the previous message.
As for the reverse iterator, I can see why the operators are override. But still three operators were implemented in an incorrect way, which are iter + n, iter - n and iter - iter.

It took me quite a while to get the iterators "working". I expect that there are better ways to implement them, and I am not surprised that there are issues. I am grateful for any hints how to improve the situation.

I could make them compiled. But some of the cases are failing. I think it's the problem of the test code.
For example, I can see that iterators of object types are not able to compare, but some test cases were still using distance(j.begin(), j.end()) (unit-capacity.cpp +345). Shall we remove these cases?

Oh, just misunderstood your last message. I have an idea of implementing the reverse iterator, instead of inheriting the reverse_iterator<iter_impl>, we could inherit template <class T> reverse_iterator. In such a way, the return type of all the operators will still be consistent with the derived classes, so no need to implement the operators again. But it's just an idea, I haven't tested it yet.

As I said: I was happy once the iterators worked, and the did not receive much love until they were refactored with #395. If you have any proposals how to improve them, I would be happy about a PR. Maybe as a bonus, you may have and idea how to fix #550. :-)

Sure. I'll have these bugs fixed today, then I'll see what I can do to improve the design, and also #550.
Pleasure to help.

I did a code walk today, and wondering if I could improve the iterator code structure.
Currently the iterator has three internal iterators, which looked very redundant at the first glance. So I trying to merge the three internal iterators into one type.
Another issue is that the iterator category, actually should be consistent with the iterator class in the internal container. For example, if the container is std::map, the iterator category tag should be bidirectional. I was wondering if I could define the category tag dynamically, according to the real container type.
It turned out that, none of these improvement is possible, because the basic_json class is using the value_type as a variable instead of a type name, unless we introduce polymorphism. I understand there is no easy way to change value_type to a type name, so I guess we can only keep it that way.
My last recommendation is to change the iterator category to random access tag, because running functions like std::advance and std::distance will be constant time complexity if the container is a vector-like container. As for the non random accessible containers, we can still re-implement the linear running time iter + n operators for these types, such that std::distance wouldn't throw an exception.

I'm sorry that I won't find the time to properly answer here or have a deeper look at the PRs. Sorry about this - I shall get back to this next week.

No worries. Take your time.

Regarding https://github.com/nlohmann/json/issues/593#issuecomment-304826302:
I agree to paragraph 1-4. The idea is that all JSON values have the same type (basic_json) with the specific type encoded in variable m_type. We won't change this.
In the 5th paragraph, you propose to change the behavior of the iterator so iter + n would work for objects. I don't really like this idea, because it would change the behavior of JSON objects compared to std::map and would also suggest an ordering of the keys in an object. This would contradict the definition in RFC 7159 which states

An object is an unordered collection of zero or more name/value pairs, where a name is a string and a value is a string, number, boolean, null, object, or array.

I understand.
How about the iterator category tag? Do you think we should change it to random access tag? Even if we don't change the implementation, we can still use the random accessible tag. All we need to do is removing the test cases that are using random access operations on object types. (i.e. https://github.com/nlohmann/json/blob/develop/test/src/unit-capacity.cpp#L327)

Your mentioned line is
CHECK(std::distance(j.rbegin(), j.rend()) == j.size());

for an object j. Would this mean std::distance would not work any more?

Correct. Because std::distance would call iter - iter if it finds the iterator as a random accessible iterator. But iter - iter throws exceptions in the current implementation.

I am puzzled - why did it work before?

Or to clarify: I would like JSON objects to behave just like std::map.

It's still working now. We haven't change the tag to random access tag yet.

We have to choose one tag, either bidirectional or random access. Currently we are using bidirectional, and it works as std::map does. However the functions for std::vector types would not be optimized.

I'll try to make this clearer. The iterator has been using the bidirectional tag all the time, even though it inherits the random accessible iterator, the tag is changed a few lines later.
When I tried to change the tag to random access, many bugs occurred, but most of them got resolved in the PR#595. I am still keeping this tag as bidirectional, because std::distance would throw exceptions on object types. (I would expect std::advance does the same.)
If we don't change the current implementation, the pros and cons in bidirectional and random access tag ares:

bidirectional tag:

pros: compatible to all types

cons: functions such as std::distance runs linear time on array types

random access tag:

pros: functions optimized for array types

cons: functions such as std::distance doesn't work for object types

Actually there is a ambiguity on the definition of the object type. If you believe the objects should have no ordering at all, then std::distance is meaningless, same as ++ and --. But std::map does have an ordering. If you have operator++ implemented, then operator+(n) somehow makes sense. Although std::map doesn't have operator+(n) either, due to the nature of the data structure, we can still overloading it to support std::distance and std::advance.

Why would std::distance be linear on array types if we use std::vector internally?

If the iterators are bidirectional instead of random access, then distance needs to iterate the first iterator until it gets to the second and count the steps, instead of doing second - first.

Gregmarr is right, if the tag is bidirectional, the distance function assumes iter - iter operation is invalid, therefore it would only use ++ operator for linear times to count the distance.

Sorry @HenryRLee for my ongoing confusion. I am unsure about this. Any further opinion is greatly appreciated.

Personally, I still think adding iter + n operators for the object type is the best solution. These are just higher level of the ++ operators, while the unordered property is contradicted when an iterator is provided for the object type.
Having overloading the iter + n operators, the std::distance and std::advance functions would work on both array types and object types. In addition, theses functions would be optimized for array types with only O(1) time complexity.

I think the iterator should remain bidirectional, we don't want to lose correctness on JSON objects.
IIRC, there is a way to access the underlying value (get_ref/ptr), for people that want optimizations on std::distance and other algorithms.

Hi @nlohmann It's basically right.
Personally I would prefer adding += to objects to removing the failing cases (i.e. distance()), since there might be many people relying on this function.
If you need my help, I can work on this and create a PR this weekend.

@HenryRLee Thanks for the offer, but I already gave it a try, see c77a0be5f3b93365b87b7cdca2e9c3475813652c. It would be great if you could have a look at the changes.

It's incorrect  to make this iterator class look like a random-access iterator -- in some cases it is (vector), but in others it's not (map). You'll create a correctness issue, and could cause major performance regressions if the STL starts choosing algorithms tuned for O(1) access that turns out to be O(n).  For example, std::sort requires random-access in order to achieve O(n log n), but if you give it iterators that actually have O(n) traversal when it is expecting O(1), you could end up with really bad performance.
This iterator needs to be the greatest-common-denominator of the choices, and that is bidirectional.

Hi @jaredgrubb Correct me if I am wrong. As far as I can see, there are no performance regressions in any functions in <algorithm> or <iterator>. sort() takes only random-access iterator tag, same as the heap related functions. The binary search or merge related functions have only one version for both forward and random-access iterator tags. So, for example, if user chooses to sort on an object type when it's in a random-access iterator tag, the complexity is indeed O(n^2 logn) . But using a bidirectional iterator tag instead, sort() doesn't work at all, there wouldn't be O(n logn) or O(n^2) solutions. So, choosing a random-access tag is no worse than bidirectional tag.
The only problem is that user may be expecting more when they sees the tag as a random-access tag. It's the same issue when running advance or distance functions, where although the tag is random-access but it turns out to be running in O(n) time. It could be a correctness issue depending on how we define it.

I agree with @jaredgrubb, as I wrote a few months ago , we should not modify this.
Bidirectional is correct in every cases, not optimal that's true, so what?
If a user wants to perform some algorithms on a JSON array, they just convert it into a vector or array.
And if the cost of conversion is too high, they use get_ptr to access the underlying vector
I'm sorry but I don't see how this proposed solution could be beneficial to the library

@HenryRLee, I have to disagree. You're right that there's no direct performance regression with your patch (the things that worked before continue to work just fine, and maybe even faster), but you're opting the iterator into new things that it may not be suited for.
Look, if you review the requirements for a random-access iterator (eg, at http://en.cppreference.com/w/cpp/concept/RandomAccessIterator), then you will see that the '+=' has a note requiring 'complexity is constant'. The json::iterator clearly does not fulfill that, and therefore must not be labelled a random-access iterator.

I agree that it is ugly/incorrect to call an interator "random-access" when it does not satisfy all of its requirements. I also agree that using a bidirectional iterator as least common denominator could be a solution for this.
But the nature of the JSON container makes life more difficult, because we need to find a way to find a common interface for differing underlying containers such as std::map and std::vector. In the end, I always aimed for an interface that makes life easy and that tries to hide the fact that we are working with a union of different types under the hood, but rather with a JSON value.
That is why I like the idea of having

Several things here:
It's good for an interface to be easy to use, but also hard to misuse.
About std::sort, it's the same problem with std::list, if people want a sorted list, they call list::sort, so we could add a basic_json::sort method.
Often times you have to call a container member function, since std:: algorithms just deal with iterators, and knowing their category is sometimes not sufficient:
Even with C++17 searchers, using string::find can be more efficient than std::search.
But one of the issue mentioned by @HenryRLee was that std::advance et al. didn't work in some specific cases.
I think the solution to have both correctness and good performance is to define distance/next/advance etc... for nlohmann::detail::iter_impl, like you would do for std::swap.
This would make std::* algorithms call our custom distance automatically.
For non std code, the following snippet will be necessary to have the best performance:
// This works, but not optimal on JSON arrays
auto dist = std::distance(j.begin(), j.end());

// Our distance implementation performs a runtime check
// to check the JSON underlying type (array, object, ...)
using std::distance;
auto dist = distance(j.begin(), j.end());

I don't know the library iterators that well, it seems that calling begin/end on a number or string work, so we'll have to keep that in mind if we implement distance et al.

I reverted the changes for now.

I agree that misrepresenting the iterator tag can be very bad.  If this checking could be done at runtime, so that if it's on an array, the iterator is random access, but on an object it's bidirectional, that would be okay, but I'm pretty sure that the machinery doesn't work that way, and it's all static typing.

You are right, it's compile-time only.

OK, the longer I think about this, the more I am convinced that we should not change the code to random_access_iterator_tag.
Question is: is there anything to be changed in the code to close this issue once and for all?

I think we have to find a solution to bind the iterator type dynamically. It would be difficult but not impossible. Note that if we are strict to the least common denominator, bidirectional is not the one, because user may choose a forward list as an array type, or even an unordered map as an object (although we don't support it yet).
Having said that, this issue can be closed. Perhaps we need to change the template argument of the iterator to bidirectional and update all the documents, since I remember they were all random access tag all the time.

Actually yes, IIRC we inherit from random_iterator_tag, and then alias iterator_category, to bidirectional_tag. We should inherit from bidirectional_tag directly.
There is code that relies on std::is_base_of<std::random_iterator_tag, ...> (not in the library AFAIK, but client code could), that is one correctness issue to fix.
I don't see anything concerning the iterator category.

Would this be sufficient to switch to bidirectional iterators and close this issue?
@ -3618,7 +3618,7 @@ This class implements a both iterators (iterator and const_iterator) for the
@since version 1.0.0, simplified in version 2.0.9
*/
template<typename BasicJsonType>
- class iter_impl : public std::iterator<std::random_access_iterator_tag, BasicJsonType>
+ class iter_impl : public std::iterator<std::bidirectional_iterator_tag, BasicJsonType>
{
    /// allow basic_json to access private members
    friend iter_impl

You can also remove the using iterator_category = ..., since std::iterator already exposes this typedef.

Thanks everyone. I shall close this issue once the CI succeeds.

authors: HenryRLee gregmarr jaredgrubb nlohmann theodelrieu


text:
currObj should be updated as the closest from all candidated.

fix #115 currObj shuld be updated as the nearest node in topCandidates

Why is this not merged, I believe it is a bug.

Good question. It seems I just forgot about it. Thanks for reminding!
I'll check it and the other PR within this week.

Thank you so much! It is a bug indeed.
Sorry it took so long. It seems I rely to much on my memory.

authors: uestc-lfs yurymalkov

repo: nmslib/hnswlib


text:
Demo: using natural language to generate nmstate YAML for linux bridge

Still trying to know how this nlp things work.

See
fn test_nlpm: https://github.com/elomscansio/nmstate/blob/d27dd2ddc553e241f17f1350fdfb6f5c7171032e/rust/src/lib/unit_tests/nlpm.rs#L4
fn nlpm: https://github.com/elomscansio/nmstate/blob/d27dd2ddc553e241f17f1350fdfb6f5c7171032e/rust/src/lib/nlpm.rs#L10
print:  https://pastebin.com/ENXNYiEs

Concerning the bad code structure, this is just a demo so i'm still test running stuff

Hello, ffmancera Gris Ge ihuguet I'm currently waiting for your responses to proceed with the PR. For example, after extracting the required details with NLP, should I create a NetworkState instance, or is it preferable to return static YAML with placeholders for the extracted information such as port, bridge, and so on?

Since this is demo, you have to evaluate whether using struct is better than yaml. Both of them is API, hence I have no preference.

As the contribution period finished, we are closing this. There is no intention to merge this because it was just a demo.

authors: cathay4t elomscansio ffmancera

repo: nmstate/nmstate


text:
[Service] handle dbus error case

Check returned val and handle error case when failed to invoke dbus methods.
Signed-off-by: Jaeyun jy1210.jung@samsung.com

:memo: TAOS-CI Version: 1.5.20200925. Thank you for submitting PR #237. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://ci.nnstreamer.ai/.

authors: jaeyun-jung taos-ci

repo: nnstreamer/api


text:
Update example/customshortcut readme.md

[ ] update how to run
[ ] add demo footage

:octocat: cibot: Thank you for posting issue #436. The person in charge will reply soon.

resolved with #474

authors: taos-ci zhoonit

repo: nnstreamer/nntrainer


text:
[layers] Add trainable feature

Add trainable feature for each layer which allows certain layers to just not train without affecting others
Signed-off-by: Parichay Kapoor pk.kapoor@samsung.com

:memo: TAOS-CI Version: 1.4.20191203. Thank you for submitting PR #255. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://nnsuite.mooo.com/.

authors: kparichay taos-ci


text:
[layer] added start/end dimension in flatten layer

For now flatten layer flatten all dimension except batch. This commit will be able to flatten only the sub dimensions

Signed-off-by: hyeonseok hs89.lee@samsung.com

:memo: TAOS-CI Version: 1.5.20200925. Thank you for submitting PR #2611. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://ci.nnstreamer.ai/.

:octocat: cibot: @lhs8928, A builder checker could not be completed because one of the checkers is not completed. In order to find out a reason, please go to http://ci.nnstreamer.ai/nntrainer/ci/repo-workers/pr-checker/2611-202405302038390.9945240020752-28103339fdbc90d17dc98fe8809e0f1cc293ef48/.


text:
Added notice about keyboard shortcuts

Closes #61

Closing without merging per conversation in #61

authors: Zasco noah-severyn


text:
Don't showing more than 4 child elements

Notice that when I put more than 4 elements, the directive simply ignore the "excess".
See here: http://plnkr.co/edit/BcGEhsLSoFxhgDLzon26
So what is going wrong? Please, can you help me?

You have to rebuild the CSS file accordingly as to support as many buttons as needed. See the docs for the way to do it properly. Let me know if you need further help.

Really thanks a lot, but in a cenario that intends to be more dinamic as possible, how I could do these adjusts dinamically?

Being it tied to a css stylesheet there is no way to recompile it on the fly, as far as I know. You could sort of replicate the logic behind the scss to work in the JavaScript and calculate the positions dynamically but in the end i am quite sure that the cost in term of work and performance would just not be justified.
My suggestion: simply to define a sensible maximum amount of buttons your layout can support (I hardly see anyone needing more than 7-8 buttons, let alone have sufficient real estate for them in the page), choose an effect and make a custom build as explained in the docs linked above.
You'll end up with some lines of potentially unused CSS but it will probably affect next to zero your overall performance and your layout will support a variable amount of buttons from 0 to n without any problem.

I've decided to solve the problem as you have said, that is define sensibly the maximum amount of buttons. But by the Docs that you've sent me, I changed just the property "$number-of-child-buttons" to "5" instead "4 !default" and I rebuilt the SASS file to generate CSS. Sadly, I think isn't just that.
Please, can you help me? Best regards.

Check this Plunkr.
I generated the css form a scss file like the my-custom.scss you see in the Plunkr, which is simply:
$number-of-child-buttons: 6;
$effects-slidein: false;
$effects-slidein-spring: false;
$effects-fountain: false;
@import "../bower_components/ng-mfb/mfb/src/mfb.scss";

You just need to tell your task runner to compile this my-custom.scss file and it will generate the appropriate code in your own css.

Yeah yeah, I've managed it yesterday but thanks a lot.

$number-of-child-buttons: 6; works fine. thanks

authors: nobitagit rohitsgoudagaon scandeiro

repo: nobitagit/ng-material-floating-button


text:
Sending notifications became slower with apn 2.1.3 update

Since I updated to apn 2.1.3 (from 2.1.2), sending 1000 notifications takes a minute (it took around 2 seconds on the previous version). I'm using json web authentication and node v6.9.4.
Did anyone else experienced this?
Thanks
EDIT: I just tried with node v7.5, and it's the same. This is my code:
"use strict";
const apn = require("apn");
var rawTokens;
var options = {
    token: {
        key: "/key.p8",
        keyId: "XXXXXXXX",
        teamId: "XXXXXXXX",
    },
    production: true,
};
var service = new apn.Provider(options);
let note = new apn.Notification();
note.rawPayload = {
    "aps": {
        "alert":{
            "body":"text"
        },
        "sound":"default",
        "badge":10
    }
};
note.expiry = Math.floor(Date.now() / 1000) + 7200;
note.topic = "my.app";
service.send(note, "MYTOKEN").then( result => {
    console.log(result);
});

service.shutdown();

Same here :-(

same here

This is probably related to how we handle JWTs now. We verify that they are still valid before sending a request.
@cmdkoh Could you take a look at that?

Sure

Thank you guys 👍

Hi @sbeff, question for you, of these 1K notifications, are they sending to approximately how many devices? Is it like 1 notification to 1K devices?
Also, can you please record the execution time of the block of code in
node_modules\apn\lib\client.js

the code block between line 62 and 68 below?
if (this.config.token) {
    if (this.config.token.isExpired(3300)) {
        this.config.token.regenerate(this.config.token.generation);
    }
    headers.authorization = "bearer " + this.config.token.current;
    tokenGeneration = this.config.token.generation;
}

Thanks

Sure, could you please tell me how to do that? :P
Yes, it's the same notification for 1K tokens.

@sbeff try adding the following
let start = new Date();
if (this.config.token) {
    if (this.config.token.isExpired(3300)) {
        this.config.token.regenerate(this.config.token.generation);
    }
    headers.authorization = "bearer " + this.config.token.current;
    tokenGeneration = this.config.token.generation;
}
console.log('Token Validation Took => ' + new Date()-start);

It prints 0 every time.

so, it probably not related to the token verification code we added in 2.1.3.
Btw, How do you measure it looks couple minutes to sent?

Sorry, I didn't see the notification. I use a php script to measure how much time does a command take, and it is around 60/70 seconds, even with the latest 2.1.4 update @florianreinhart

@florianreinhart any news? Thanks!

@sbeff Sorry, no. It would be great if you could investigate the issue and submit a fix if possible.

I encounter the same problem when send 1000 notifications one time;
I has modified endpoint.js file, change this._maximumStreamSlots to 10(the negotiated value is 1000), the task will finish shortly, may be http2 flow control problem.
this._connection.on("RECEIVING_SETTINGS_MAX_CONCURRENT_STREAMS", maxStreams => {
      if (maxStreams > this.options.maxStreamCount) {
        this._maximumStreamSlots = this.options.maxStreamCount;
      } else {
        this._maximumStreamSlots = maxStreams;
      }
      this.emit("wakeup");
    });

I found it very slow with node.js 8

authors: cmdkoh florianreinhart sbeff tapwork tian-yuan trx222 wong2

repo: node-apn/node-apn


text:
Update index.html

Remove js reference thats is no longer required.

Thank you!

authors: kukielp nkbt


text:
httpin respects apiMaxLength?

According to this link and this link, I assume that http in nodes will respect configuration parameter apiMaxLength.
By looking at 21-httpin.js:23 there are no limit parameters passing in, should it be there?

Hi - sorry for the slow response.
Despite what I had said in those threads, apiMaxLength is specifically for admin API. We will need to introduce a new setting for the http nodes.

Not sure if you guys had an idea about the name yet; but following httpRequestTimeout, httpRequestLimit may be a good start.

is there any way to hack the node red code to increase the limit??

@jonathanrcarter you can edit 21-httpin.js here https://github.com/node-red/node-red/blob/3b12076d4bc8f42c3f824ef0be466649f1b4de39/nodes/core/io/21-httpin.js#L24 to be:
var jsonParser = bodyParser.json({limit: '5mb'});

Is there other considerations preventing this change? If not I can make a PR.

I don't think there's much in the way here... just need to agree the name of the property this will introduce. To be consistent with other properties, I would suggest httpNodeMaxLength. A PR would be most welcome.

Took a few looks of the inner workings and found that incoming body is already parsed in red/api/index.js:103 before 21-http.js:24 can touch it.
Which means the jsonParser in 21-httpin.js has never done anything from the very beginning.
We have a few approaches here:

apiMaxLength takes precedence as settings.apiMaxLength || settings.httpNodeMaxLength || '5mb';
Use the bytes library and Math.min() to pick the smallest one.
Delete req.body and req._body in every requests received by 21-http.js to force a re-parse.

Although 3. Make the most sense to me, it does have a performance hit and the error falls into the flow context and if people doesn't use a catch node the client will see 500 Internal server error instead.
This really affects the inner workings, I could use your advise here.

There are two separate express apps here.
adminApp is the express app that handles the admin api and is controlled by apiMaxLength.
The HTTP Nodes attach to a different express app here: https://github.com/node-red/node-red/blob/c9317659c5049f1929c4fe60bafe3c7dffa97b02/red/runtime/index.js#L62
So the jsonParser in 21-httpin.js should be being used and separately configured to the adminApp one.

I placed a logging middleware at these two lines.
https://github.com/node-red/node-red/blob/c9317659c5049f1929c4fe60bafe3c7dffa97b02/red/api/index.js#L104
https://github.com/node-red/node-red/blob/c9317659c5049f1929c4fe60bafe3c7dffa97b02/nodes/core/io/21-httpin.js#L248
According to the logs the request passes through red/api/index.js, then carries the parsed JSON in req.body and then arrives 21-httpin.js where it ignores the parsing because of lib/types/json:98.

Diving in and out I arrived at these two lines,
https://github.com/node-red/node-red/blob/c9317659c5049f1929c4fe60bafe3c7dffa97b02/red.js#L244
https://github.com/node-red/node-red/blob/c9317659c5049f1929c4fe60bafe3c7dffa97b02/red.js#L250
I suspect with the same express app connecting two separate apps, namely httpAdmin/adminApp and httpNode/nodeApp, they in fact shares the same request object.

Coming back to this, given your last comment, and further testing, apiMaxLength does apply to the http nodes.
So I'm not sure there's anything to address here.

When httpNodeRoot and httpAdminRoot is the same, in the default mode (not embedded) httpNodeMaxLength will be inherently dependent on apiMaxLength because express has no way to distinguish between them as of yet.
RED.httpAdmin will always parse the body before RED.httpNode has a chance to do so.
Possible Scenarios
apiMaxLength >= httpNodeMaxLength

We are wasting a few milliseconds to "reparse" the body with httpNodeMaxLength.
If body exceed the limit, http nodes will respond with 500 instead of 412 unless users put a catch node and manually craft a 412 response.

apiMaxLength < httpNodeMaxLength

It just won't arrive the http nodes at all because apiMaxLength in RED.httpAdmin already respond with 412.

Fair enough, happy to see this resolved. Thanks!

authors: jonathanrcarter knolleary vicary

repo: node-red/node-red


text:
Integrating Passport.js

I've figured out a way to integrate Passport.js as an inline node; I'll post it to my node-red-nodes fork when it's done, just wondering if this is something that anyone else has tried or has an interest in seeing work a particular way.

This was a long time ago :) I couldn't find it in your node-red-nodes fork. Really looking for a way to use passport as part of a flow rather than using it as part of express middleware.

authors: TJKoury bigdoods


text:
Add numpy blocks

What type of PR is this?
Enhancement
What this PR does / why we need it:
This PR implements many numpy  methods that work with scalar values.
Which issue(s) this PR fixes:

None.
Special notes for your reviewer:
None.
Does this PR introduce a user-facing change?
No.

Additional documentation, usage docs, etc.:
None.

On Hold because of missing icons.

authors: EnricaSo nodedge

repo: nodedge/nodedge


text:
Re-implemented murmur2 partitioner, to be consistent with Kafka Java client

Using https://github.com/vuza/murmur2-partitioner for murmur2 partitioning, which is tested to be consistent with Kafka's Java client. Also fixing this two issues: https://github.com/nodefluent/node-sinek/issues/40, https://github.com/nodefluent/node-sinek/issues/39

Close https://github.com/nodefluent/node-sinek/issues/40 and https://github.com/nodefluent/node-sinek/issues/39 after merge!

You are right! I fixed that!

I still dont like pulling two modules in just for the partitioner..however lets get this released already..

authors: krystianity vuza

repo: nodefluent/node-sinek


text:
feat: introduce release metadata to generators

This PR introduces the ability for the API docs tooling to retrieve the current running/target Node.js version and all major versions from the CHANGELOG.md file; this is important since relative version metadata is necessary during the doc build process.
In the future, when the proper React/MDX generators are created, this information will be used for the Navigation of different Node.js versions and + for knowing what version the API docs are targeting.
This will also be used for the legacy API doc tooling.

cc @nodejs/web-infra

repo: nodejs/api-docs-tooling