text:
First pull request

Hi Jesse
These are the changes I made on PeCorA. I changed the README.md quite a bit; we can decide later what we want to say/show there.

Readmes:

[ ]  change section 2 header to "install":
Changed
[ ]  add windows install instructions
within R, development version
      install.packages("devtools")
      devtools::install_github("jessegmeyerlab/PeCorA")
Changed
within R, CRAN?
      install.packages("PeCorA")
Added that but still not submited to CRAN
[ ]  update install location to jessegmeyerlab repo
Changed
[ ]  maybe under header 3, add subsection on how to use their own data, eg what columns/information are required
Changed
[ ]  Functions needed?
convert maxquant peptides.txt to pecora format
            would need user to input peptides.txt and unique group name from the LFQ col names
wrapper function to run via command line
Need to add those function to package
loading into R saw this, is this a problem?:

library(PeCorA)
Registered S3 methods overwritten by 'lme4':
method                          from
cooks.distance.influence.merMod car
influence.merMod                car
dfbeta.influence.merMod         car
dfbetas.influence.merMod        car

PeCorA package is loaded quietly in the Vignette now, so that message does not appear

Testing vignette got error, does function need to be standardize::scale_by?:

scaled_peptides<-PeCorA_preprocessing(t, 8, 100, "cntrl")
Error in scale_by(ms1log2 ~ Condition * BioReplicate, t) :
could not find function "scale_by"

library(standardize) is also added in the vignette now, which removes the error. standardize::scale_by is imported in PeCoRa package, but it doesn't seem to be imported correctly for now.

In addition: Warning message:
In which(is.na(as.numeric(t[, area_column_name])) == TRUE) :
NAs introduced by coercion

I need to suppress that warning in PeCorA_preprocessing function.

Great, thanks for doing this.
Can you please update the install instructions in the vignette as well? Sorry that is what I meant when I suggested changing the second section to "install", I like "installation". I can change the main readme myself but less sure how to change the vingette afterwards.

Vignette updated. See PeCorA_vignette.pdf

Can we please fix the dependency as well? I looked and maybe it needs to be under "depends" instead of "imports", or it might need to be called in the function as standardize::scale_by

Changed now

see line comments related to above
Note it also does not correctly import ggplot

It does import ggplot correctly now

For the command line wrapper, please make it dump all the plots of significantly different peptides as before.

Thanks for updating this. I just tried to test it and now it wont install at all. It might be some problem with the package dependencies "digest", "reshape", and/or "MSstats".
`> devtools::install_github("demar01/pecora-1")
Downloading GitHub repo demar01/pecora-1@HEAD
These packages have more recent versions available.
It is recommended to update all of them.
Which would you like to update?
1: All
2: CRAN packages only
3: None
4: digest   (0.6.25 -> 0.6.26) [CRAN]
5: quantreg (5.73   -> 5.74  ) [CRAN]
Enter one or more numbers, or an empty line to skip updates:3
√  checking for file 'C:\Users\jmeyer\AppData\Local\Temp\Rtmp0i44df\remotes6f5411803d1e\demar01-PeCorA-1-136091f/DESCRIPTION' ...

preparing 'PeCorA': (731ms)
√  checking DESCRIPTION meta-information ...
checking for LF line-endings in source and make files and shell scripts
checking for empty or unneeded directories
NB: this package now depends on R (>= 3.5.0)
WARNING: Added dependency on R >= 3.5.0 because serialized objects in  serialize/load version 3 cannot be read in older versions of R.  File(s) containing such objects: 'PeCorA/data/Covid_peptides.rda'  'PeCorA/data/PeCorA_noZ.rda'  WARNING: Added dependency on R >= 3.5.0 because serialized objects in  serialize/load version 3 cannot be read in older versions of R.  File(s) containing such objects: 'PeCorA/data/input.dda.iprg.pg.rda'  WARNING: Added dependency on R >= 3.5.0 because serialized objects in  serialize/load version 3 cannot be read in older versions of R.  File(s) containing such objects: 'PeCorA/data/input.microglia.sk.rda'
building 'PeCorA_0.0.0.9000.tar.gz'

Installing package into ‘C:/Users/jmeyer/Documents/R/win-library/4.0’
(as ‘lib’ is unspecified)

installing source package 'PeCorA' ...
** using staged installation
** R
** data
*** moving datasets to lazyload DB
** inst
** byte-compile and prepare package for lazy loading
Error: (converted from warning) package 'reshape' was built under R version 4.0.3
Execution halted
ERROR: lazy loading failed for package 'PeCorA'
removing 'C:/Users/jmeyer/Documents/R/win-library/4.0/PeCorA'
restoring previous 'C:/Users/jmeyer/Documents/R/win-library/4.0/PeCorA'
Error: Failed to install 'PeCorA' from GitHub:
(converted from warning) installation of package ‘C:/Users/jmeyer/AppData/Local/Temp/Rtmp0i44df/file6f5473eb67f7/PeCorA_0.0.0.9000.tar.gz’ had non-zero exit status`

Tried on my tablet to check if it was install specific and got a different error with MSstats?
`> devtools::install_github("demar01/pecora-1")
Downloading GitHub repo demar01/pecora-1@HEAD
These packages have more recent versions available.
It is recommended to update all of them.
Which would you like to update?
1: All
2: CRAN packages only
3: None
4: digest   (0.6.25 -> 0.6.26) [CRAN]
5: rlang    (0.4.6  -> 0.4.8 ) [CRAN]
6: quantreg (5.73   -> 5.74  ) [CRAN]
Enter one or more numbers, or an empty line to skip updates:3
√  checking for file 'C:\Users\jesse\AppData\Local\Temp\Rtmpa80Mc0\remotese081b222ca\demar01-PeCorA-1-136091f/DESCRIPTION' (523ms)

preparing 'PeCorA': (2.6s)
√  checking DESCRIPTION meta-information ...
checking for LF line-endings in source and make files and shell scripts
checking for empty or unneeded directories
NB: this package now depends on R (>= 3.5.0)
WARNING: Added dependency on R >= 3.5.0 because serialized objects in  serialize/load version 3 cannot be read in older versions of R.  File(s) containing such objects: 'PeCorA/data/Covid_peptides.rda'  'PeCorA/data/PeCorA_noZ.rda'  WARNING: Added dependency on R >= 3.5.0 because serialized objects in  serialize/load version 3 cannot be read in older versions of R.  File(s) containing such objects: 'PeCorA/data/input.dda.iprg.pg.rda'  WARNING: Added dependency on R >= 3.5.0 because serialized objects in  serialize/load version 3 cannot be read in older versions of R.  File(s) containing such objects: 'PeCorA/data/input.microglia.sk.rda'
building 'PeCorA_0.0.0.9000.tar.gz'

Installing package into ‘C:/Users/jesse/Documents/R/win-library/4.0’
(as ‘lib’ is unspecified)
ERROR: dependency 'MSstats' is not available for package 'PeCorA'

removing 'C:/Users/jesse/Documents/R/win-library/4.0/PeCorA'
Error: Failed to install 'PeCorA' from GitHub:
(converted from warning) installation of package ‘C:/Users/jesse/AppData/Local/Temp/Rtmpa80Mc0/filee087d506c6e/PeCorA_0.0.0.9000.tar.gz’ had non-zero exit status`

Tried on my tablet to check if it was install specific and got a different error with MSstats?
`> devtools::install_github("demar01/pecora-1")
Downloading GitHub repo demar01/pecora-1@HEAD
These packages have more recent versions available.
It is recommended to update all of them.
Which would you like to update?
1: All
2: CRAN packages only
3: None
4: digest (0.6.25 -> 0.6.26) [CRAN]
5: rlang (0.4.6 -> 0.4.8 ) [CRAN]
6: quantreg (5.73 -> 5.74 ) [CRAN]
Enter one or more numbers, or an empty line to skip updates:3
√ checking for file 'C:\Users\jesse\AppData\Local\Temp\Rtmpa80Mc0\remotese081b222ca\demar01-PeCorA-1-136091f/DESCRIPTION' (523ms)

preparing 'PeCorA': (2.6s)
√  checking DESCRIPTION meta-information ...
checking for LF line-endings in source and make files and shell scripts
checking for empty or unneeded directories
NB: this package now depends on R (>= 3.5.0)
WARNING: Added dependency on R >= 3.5.0 because serialized objects in  serialize/load version 3 cannot be read in older versions of R.  File(s) containing such objects: 'PeCorA/data/Covid_peptides.rda'  'PeCorA/data/PeCorA_noZ.rda'  WARNING: Added dependency on R >= 3.5.0 because serialized objects in  serialize/load version 3 cannot be read in older versions of R.  File(s) containing such objects: 'PeCorA/data/input.dda.iprg.pg.rda'  WARNING: Added dependency on R >= 3.5.0 because serialized objects in  serialize/load version 3 cannot be read in older versions of R.  File(s) containing such objects: 'PeCorA/data/input.microglia.sk.rda'
building 'PeCorA_0.0.0.9000.tar.gz'

Installing package into ‘C:/Users/jesse/Documents/R/win-library/4.0’
(as ‘lib’ is unspecified)
ERROR: dependency 'MSstats' is not available for package 'PeCorA'

removing 'C:/Users/jesse/Documents/R/win-library/4.0/PeCorA'
Error: Failed to install 'PeCorA' from GitHub:
(converted from warning) installation of package ‘C:/Users/jesse/AppData/Local/Temp/Rtmpa80Mc0/filee087d506c6e/PeCorA_0.0.0.9000.tar.gz’ had non-zero exit status`

I moved MSstats to dependency now. If I download it and run R CMD INSTALL PeCorA_0.0.0.9000.tar.gz it works for me. Does it for you? What if you update all the packages ( option 1)?
I made a wrapper to run PeCorA on the command line and updated the instructions in the vignette. It works on my computer, can you check on yours (windows?)

Updating the packages didn't help, it seems related to the change to add those packages as "depends". I cloned your repo and will try to figure it out for windows and let you know.
I moved those back out of depends to dissect the problem and now its complaining that its missing the function "import_processed_data_for_PeCorA_LFQ"
from the R folder.
Can you please check that you pushed that to the master? maybe the name is wrong

Also not seeing the wrapper function - can you check that you pushed that to your fork?

Updating the packages didn't help, it seems related to the change to add those packages as "depends". I cloned your repo and will try to figure it out for windows and let you know.
I moved those back out of depends to dissect the problem and now its complaining that its missing the function "import_processed_data_for_PeCorA_LFQ"
from the R folder.
Can you please check that you pushed that to the master? maybe the name is wrong
I am  always posting to your master branch from mine:

`** building package indices
** testing if installed package can be loaded from temporary location
*** arch - i386
Error: package or namespace load failed for 'PeCorA' in namespaceExport(ns, exports):
undefined exports: import_processed_data_for_PeCorA_LFQ
Error: loading failed
Execution halted
*** arch - x64
Error: package or namespace load failed for 'PeCorA' in namespaceExport(ns, exports):
undefined exports: import_processed_data_for_PeCorA_LFQ
Error: loading failed
Execution halted
ERROR: loading failed for 'i386', 'x64'

removing 'C:/Users/jmeyer/Documents/R/win-library/4.0/PeCorA'
Warning message:
In i.p(...) :
installation of package ‘C:/Users/jmeyer/AppData/Local/Temp/RtmpABcgkR/file4bfc1b3d72e5/PeCorA_0.0.0.9000.tar.gz’ had non-zero exit status`

@jessegmeyerlab this is the wrapper function

I see now thanks. I was confused because I didn't see it in the "R" folder. Is that OK to be in the directory?

there is no "import_processed_data_for_PeCorA_LFQ" in the folder "R", but it is in the NAMESPACE. I think that is why it is complaining?

Lemme check
Maria Dermit
Postdoctoral Research Assistant | Centre for Molecular Oncology
Barts Cancer Institute - a Cancer Research UK Centre of Excellence
Queen Mary, University of London
John Vane Science Centre, Charterhouse Square, London EC1M 6BQ
Email: maria.dermit@qmul.ac.uk

From: jessegmeyerlab notifications@github.com
Sent: Monday, October 19, 2020 2:13 PM
To: jessegmeyerlab/PeCorA PeCorA@noreply.github.com
Cc: Maria Dermit maria.dermit@qmul.ac.uk; Author author@noreply.github.com
Subject: Re: [jessegmeyerlab/PeCorA] First pull request (#2)
there is no "import_processed_data_for_PeCorA_LFQ" in the folder "R", but it is in the NAMESPACE. I think that is why it is complaining?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fjessegmeyerlab%2FPeCorA%2Fpull%2F2%23issuecomment-712146946&data=04|01||23a55dba72ed4ff7419408d87430bbaa|569df091b01340e386eebd9cb9e25814|0|0|637387099937202378|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=hS5WmWqzfBmszEmX2IdDfMc08pYv1BWmjOHfaKn7Oig%3D&reserved=0, or unsubscribehttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FABGGWHK7LIJGYGH3PSU2X4TSLQ3OJANCNFSM4SQ7FJGQ&data=04|01||23a55dba72ed4ff7419408d87430bbaa|569df091b01340e386eebd9cb9e25814|0|0|637387099937202378|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=AfRPvQilxqThaNHlhtjB1Th0eS73M10jT21EduQmELA%3D&reserved=0.

there is no "import_processed_data_for_PeCorA_LFQ" in the folder "R", but it is in the NAMESPACE. I think that is why it is complaining?

Correct, it should be there now. Is is working?

Thanks! will check again now

OK it worked on my computer that already had MSstats installed by devtools::install_github(), but failed on dependency MSstats not available when I didn't have it installed on my tablet.
MSstats isn't on cran so does it make sense to have as a dependency? Which function is it required for?

actually getting a lot of different errors now that MSstats error went away - there is some problem with package versions. I will see if I can figure it out this morning

You are right, we dont need MSstats. I remove it from the description. Lemme know if updating packages solve the problem.  Version  of packages uses is on the vignette - which I need to update to remove MSstats.
Maria Dermit
Postdoctoral Research Assistant | Centre for Molecular Oncology
Barts Cancer Institute - a Cancer Research UK Centre of Excellence
Queen Mary, University of London
John Vane Science Centre, Charterhouse Square, London EC1M 6BQ
Email: maria.dermit@qmul.ac.uk

From: jessegmeyerlab notifications@github.com
Sent: Monday, October 19, 2020 2:38 PM
To: jessegmeyerlab/PeCorA PeCorA@noreply.github.com
Cc: Maria Dermit maria.dermit@qmul.ac.uk; Author author@noreply.github.com
Subject: Re: [jessegmeyerlab/PeCorA] First pull request (#2)
OK it worked on my computer that already had MSstats installed by devtools::install_github(), but failed on dependency MSstats not available when I didn't have it installed on my tablet.
MSstats isn't on cran so does it make sense to have as a dependency? Which function is it required for?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fjessegmeyerlab%2FPeCorA%2Fpull%2F2%23issuecomment-712162744&data=04|01||ef2800ab29a84e5eca6308d8743450d7|569df091b01340e386eebd9cb9e25814|0|0|637387115327394651|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=ye%2BHzHtlwcpNqPRQWA9%2FqFKcgz%2BTqVVrOdeolHxDdbA%3D&reserved=0, or unsubscribehttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FABGGWHIP2E5DA6VP2WIRAWDSLQ6OTANCNFSM4SQ7FJGQ&data=04|01||ef2800ab29a84e5eca6308d8743450d7|569df091b01340e386eebd9cb9e25814|0|0|637387115327404647|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=6l903q7BvLuG39zikOtHUvNhEFA5lgQO6rtscy2U1OA%3D&reserved=0.

OK got it to install now. Might have partially been issue with R version so I updated to 4.0.3 and ran it in the base R gui and it installed
going through the vingette and found this error in the control name

Great, we could write in the documentation:
PeCorA has been tested with R version 3.6.3. The following packages/version are required:
reshape_0.8.8 standardize_0.2.1  ggplot2_3.3.2
what do you mean error in the control name?
Maria Dermit
Postdoctoral Research Assistant | Centre for Molecular Oncology
Barts Cancer Institute - a Cancer Research UK Centre of Excellence
Queen Mary, University of London
John Vane Science Centre, Charterhouse Square, London EC1M 6BQ
Email: maria.dermit@qmul.ac.uk

From: jessegmeyerlab notifications@github.com
Sent: Monday, October 19, 2020 3:29 PM
To: jessegmeyerlab/PeCorA PeCorA@noreply.github.com
Cc: Maria Dermit maria.dermit@qmul.ac.uk; Author author@noreply.github.com
Subject: Re: [jessegmeyerlab/PeCorA] First pull request (#2)
OK got it to install now. Might have partially been issue with R version so I updated to 4.0.3 and ran it in the base R gui and it installed
going through the vingette and found this error in the control name
[image]https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fuser-images.githubusercontent.com%2F65188012%2F96464523-c75a6700-11dc-11eb-8068-3789af3f2281.png&data=04|01||b630449010714d0998ae08d8743b6a92|569df091b01340e386eebd9cb9e25814|0|0|637387145834445860|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=yiZUqW1qHuXIA2SAfk37ysTi3WP6WiLyiA1qtJtVRwA%3D&reserved=0
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fjessegmeyerlab%2FPeCorA%2Fpull%2F2%23issuecomment-712200875&data=04|01||b630449010714d0998ae08d8743b6a92|569df091b01340e386eebd9cb9e25814|0|0|637387145834455862|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=R8lVmTEzy1o4UUlhF4Cuc0qV2e4yaDKJDF38sMWib0o%3D&reserved=0, or unsubscribehttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FABGGWHPORNMDIAEZT346ABLSLRENHANCNFSM4SQ7FJGQ&data=04|01||b630449010714d0998ae08d8743b6a92|569df091b01340e386eebd9cb9e25814|0|0|637387145834465853|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=sTSWFPylr3n2PvjF3fufbsu0KWTny2gfUNCpFPsMNw8%3D&reserved=0.

Can you see in the image of the vingette? control_name="t<-..." when it should be control_name="cntrl"

Great, we could write in the documentation: PeCorA has been tested with R version 3.6.3. The following packages/version are required: reshape_0.8.8 standardize_0.2.1 ggplot2_3.3.2 what do you mean error in the control name? Maria Dermit Postdoctoral Research Assistant | Centre for Molecular Oncology Barts Cancer Institute - a Cancer Research UK Centre of Excellence Queen Mary, University of London John Vane Science Centre, Charterhouse Square, London EC1M 6BQ Email: maria.dermit@qmul.ac.uk
…
________________________________ From: jessegmeyerlab notifications@github.com Sent: Monday, October 19, 2020 3:29 PM To: jessegmeyerlab/PeCorA PeCorA@noreply.github.com Cc: Maria Dermit maria.dermit@qmul.ac.uk; Author author@noreply.github.com Subject: Re: [jessegmeyerlab/PeCorA] First pull request (#2) OK got it to install now. Might have partially been issue with R version so I updated to 4.0.3 and ran it in the base R gui and it installed going through the vingette and found this error in the control name [image]https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fuser-images.githubusercontent.com%2F65188012%2F96464523-c75a6700-11dc-11eb-8068-3789af3f2281.png&data=04|01||b630449010714d0998ae08d8743b6a92|569df091b01340e386eebd9cb9e25814|0|0|637387145834445860|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=yiZUqW1qHuXIA2SAfk37ysTi3WP6WiLyiA1qtJtVRwA%3D&reserved=0 — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fjessegmeyerlab%2FPeCorA%2Fpull%2F2%23issuecomment-712200875&data=04|01||b630449010714d0998ae08d8743b6a92|569df091b01340e386eebd9cb9e25814|0|0|637387145834455862|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=R8lVmTEzy1o4UUlhF4Cuc0qV2e4yaDKJDF38sMWib0o%3D&reserved=0, or unsubscribehttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FABGGWHPORNMDIAEZT346ABLSLRENHANCNFSM4SQ7FJGQ&data=04|01||b630449010714d0998ae08d8743b6a92|569df091b01340e386eebd9cb9e25814|0|0|637387145834465853|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=sTSWFPylr3n2PvjF3fufbsu0KWTny2gfUNCpFPsMNw8%3D&reserved=0.

c

Also, I like that you added the math

I'm not an expert in linear models so maybe you understand this better, but are the groups X1 and X2 the condition groups or the peptide groups? If the latter then please change "x1= peptidei" and  x2 = "all other peptides".
If X1 and X2 are the groups then there would X3 when we have three groups?

I tested the steps in the vignette and it all works! If you can fix those two minor vingette parts I will merge this!

I tested the steps in the vignette and it all works! If you can fix those two minor vingette parts I will merge this!

Awesome! I just

Can you see in the image of the vingette? control_name="t<-..." when it should be control_name="cntrl"

Great, we could write in the documentation: PeCorA has been tested with R version 3.6.3. The following packages/version are required: reshape_0.8.8 standardize_0.2.1 ggplot2_3.3.2 what do you mean error in the control name? Maria Dermit Postdoctoral Research Assistant | Centre for Molecular Oncology Barts Cancer Institute - a Cancer Research UK Centre of Excellence Queen Mary, University of London John Vane Science Centre, Charterhouse Square, London EC1M 6BQ Email: maria.dermit@qmul.ac.uk
…
________________________________ From: jessegmeyerlab notifications@github.com Sent: Monday, October 19, 2020 3:29 PM To: jessegmeyerlab/PeCorA PeCorA@noreply.github.com Cc: Maria Dermit maria.dermit@qmul.ac.uk; Author author@noreply.github.com Subject: Re: [jessegmeyerlab/PeCorA] First pull request (#2) OK got it to install now. Might have partially been issue with R version so I updated to 4.0.3 and ran it in the base R gui and it installed going through the vingette and found this error in the control name [image]https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fuser-images.githubusercontent.com%2F65188012%2F96464523-c75a6700-11dc-11eb-8068-3789af3f2281.png&data=04|01||b630449010714d0998ae08d8743b6a92|569df091b01340e386eebd9cb9e25814|0|0|637387145834445860|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=yiZUqW1qHuXIA2SAfk37ysTi3WP6WiLyiA1qtJtVRwA%3D&reserved=0 — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fjessegmeyerlab%2FPeCorA%2Fpull%2F2%23issuecomment-712200875&data=04%7C01%7C%7Cb630449010714d0998ae08d8743b6a92%7C569df091b01340e386eebd9cb9e25814%7C0%7C0%7C637387145834455862%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=R8lVmTEzy1o4UUlhF4Cuc0qV2e4yaDKJDF38sMWib0o%3D&reserved=0, or unsubscribehttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FABGGWHPORNMDIAEZT346ABLSLRENHANCNFSM4SQ7FJGQ&data=04%7C01%7C%7Cb630449010714d0998ae08d8743b6a92%7C569df091b01340e386eebd9cb9e25814%7C0%7C0%7C637387145834465853%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=sTSWFPylr3n2PvjF3fufbsu0KWTny2gfUNCpFPsMNw8%3D&reserved=0.

c

Ups! I missed that. It is fixed on the vignette now.

Also, I like that you added the math

I'm not an expert in linear models so maybe you understand this better, but are the groups X1 and X2 the condition groups or the peptide groups? If the latter then please change "x1= peptidei" and x2 = "all other peptides".
If X1 and X2 are the groups then there would X3 when we have three groups?

I think it is correct how it is  like that. It is the simplify version how we wrote it on Fig2C (image below)

and the exact complete formula ( for an example peptide)  from
lm(subtmpdf$ms1adj ~ subtmpdf$Condition*subtmpdf$allothers) is:
α+ β1(subtmpdf$ConditionEtOH)+ β2(subtmpdf$ConditionLPS)+ β3(subtmpdf$allothersC[+57]QGTFSPEDNSIK_all)+ β4(subtmpdf$ConditionEtOH× subtmpdf$allothersC[+57]QGTFSPEDNSIK_all)+ β5(subtmpdf$ConditionLPS× subtmpdf$allothersC[+57]QGTFSPEDNSIK_all)+ϵ
So there will be as many B as combinations are

Also, I like that you added the math

I'm not an expert in linear models so maybe you understand this better, but are the groups X1 and X2 the condition groups or the peptide groups? If the latter then please change "x1= peptidei" and x2 = "all other peptides".
If X1 and X2 are the groups then there would X3 when we have three groups?

Also, I like that you added the math

I'm not an expert in linear models so maybe you understand this better, but are the groups X1 and X2 the condition groups or the peptide groups? If the latter then please change "x1= peptidei" and x2 = "all other peptides".
If X1 and X2 are the groups then there would X3 when we have three groups?

I think it is correct how it is  like that. It is the simplify version how we wrote it on Fig2C (image below)

and the exact complete formula ( for an example peptide)  from
lm(subtmpdf$ms1adj ~ subtmpdf$Condition*subtmpdf$allothers) is:
α+ β1(subtmpdf$ConditionEtOH)+ β2(subtmpdf$ConditionLPS)+ β3(subtmpdf$allothersC[+57]QGTFSPEDNSIK_all)+ β4(subtmpdf$ConditionEtOH× subtmpdf$allothersC[+57]QGTFSPEDNSIK_all)+ β5(subtmpdf$ConditionLPS× subtmpdf$allothersC[+57]QGTFSPEDNSIK_all)+ϵ
So there will be as many B as combinations are

I tested the steps in the vignette and it all works! If you can fix those two minor vingette parts I will merge this!

Awesome! Lemme know what you think about the formula, if you think we  need to change it in the vignette.

Awesome! Are we thinking of submitting the package to CRAN?
I just built a cute hexticker for the package 🙂
I will send later a new pull request to include it.
Maria Dermit
Postdoctoral Research Assistant | Centre for Molecular Oncology
Barts Cancer Institute - a Cancer Research UK Centre of Excellence
Queen Mary, University of London
John Vane Science Centre, Charterhouse Square, London EC1M 6BQ
Email: maria.dermit@qmul.ac.uk

From: jessegmeyerlab notifications@github.com
Sent: Monday, October 19, 2020 7:09 PM
To: jessegmeyerlab/PeCorA PeCorA@noreply.github.com
Cc: Maria Dermit maria.dermit@qmul.ac.uk; Author author@noreply.github.com
Subject: Re: [jessegmeyerlab/PeCorA] First pull request (#2)
Merged #2https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fjessegmeyerlab%2FPeCorA%2Fpull%2F2&data=04|01||3f285348e4d848f550c008d8745a14be|569df091b01340e386eebd9cb9e25814|0|0|637387277545066907|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=0EoaExOplupcGmC4u07LOZm82A8Hn%2F88KPiDzJLlyWc%3D&reserved=0 into master.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fjessegmeyerlab%2FPeCorA%2Fpull%2F2%23event-3894851045&data=04|01||3f285348e4d848f550c008d8745a14be|569df091b01340e386eebd9cb9e25814|0|0|637387277545076902|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=o6usaiprwYuSrwU8kTEw%2BH5BEHW6LxkAcLw3Uj53JjM%3D&reserved=0, or unsubscribehttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FABGGWHO3G7ZU2BUCUBXRKRLSLR6EJANCNFSM4SQ7FJGQ&data=04|01||3f285348e4d848f550c008d8745a14be|569df091b01340e386eebd9cb9e25814|0|0|637387277545076902|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=tPlM%2FedaDligNYAasbQN8QlhJsWdN%2FMTEmiHCvNYrPo%3D&reserved=0.

Hi Maria,
That is adorable I love it!
Yes we should submit to CRAN. Do you know how that works in case we need to update it in the future.
Best,
Jesse
From: Maria Dermit maria.dermit@qmul.ac.uk
Sent: Monday, October 19, 2020 1:47 PM
To: jessegmeyerlab/PeCorA reply@reply.github.com; Meyer, Jesse jesmeyer@mcw.edu
Subject: Re: [jessegmeyerlab/PeCorA] First pull request (#2)
ATTENTION: This email originated from a sender outside of MCW. Use caution when clicking on links or opening attachments.

Awesome! Are we thinking of submitting the package to CRAN?
I just built a cute hexticker for the package 🙂
I will send later a new pull request to include it.
Maria Dermit
Postdoctoral Research Assistant | Centre for Molecular Oncology
Barts Cancer Institute - a Cancer Research UK Centre of Excellence
Queen Mary, University of London
John Vane Science Centre, Charterhouse Square, London EC1M 6BQ
Email: maria.dermit@qmul.ac.ukmailto:maria.dermit@qmul.ac.uk

From: jessegmeyerlab <notifications@github.commailto:notifications@github.com>
Sent: Monday, October 19, 2020 7:09 PM
To: jessegmeyerlab/PeCorA <PeCorA@noreply.github.commailto:PeCorA@noreply.github.com>
Cc: Maria Dermit <maria.dermit@qmul.ac.ukmailto:maria.dermit@qmul.ac.uk>; Author <author@noreply.github.commailto:author@noreply.github.com>
Subject: Re: [jessegmeyerlab/PeCorA] First pull request (#2)
Merged #2https://urldefense.com/v3/__https:/eur01.safelinks.protection.outlook.com/?url=https*3A*2F*2Fgithub.com*2Fjessegmeyerlab*2FPeCorA*2Fpull*2F2&data=04*7C01*7C*7C3f285348e4d848f550c008d8745a14be*7C569df091b01340e386eebd9cb9e25814*7C0*7C0*7C637387277545066907*7CUnknown*7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0*3D*7C1000&sdata=0EoaExOplupcGmC4u07LOZm82A8Hn*2F88KPiDzJLlyWc*3D&reserved=0__;JSUlJSUlJSUlJSUlJSUlJSUlJSU!!H8mHWRdzp34!sejezBWOCcGBY5X_yyGKKF7mES-FxwQRkC3BdxJZMbKiv-CKH7INg5EPkJ6SNjpQ$ into master.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https:/eur01.safelinks.protection.outlook.com/?url=https*3A*2F*2Fgithub.com*2Fjessegmeyerlab*2FPeCorA*2Fpull*2F2*23event-3894851045&data=04*7C01*7C*7C3f285348e4d848f550c008d8745a14be*7C569df091b01340e386eebd9cb9e25814*7C0*7C0*7C637387277545076902*7CUnknown*7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0*3D*7C1000&sdata=o6usaiprwYuSrwU8kTEw*2BH5BEHW6LxkAcLw3Uj53JjM*3D&reserved=0__;JSUlJSUlJSUlJSUlJSUlJSUlJSUl!!H8mHWRdzp34!sejezBWOCcGBY5X_yyGKKF7mES-FxwQRkC3BdxJZMbKiv-CKH7INg5EPkJ4Dn9Wh$, or unsubscribehttps://urldefense.com/v3/__https:/eur01.safelinks.protection.outlook.com/?url=https*3A*2F*2Fgithub.com*2Fnotifications*2Funsubscribe-auth*2FABGGWHO3G7ZU2BUCUBXRKRLSLR6EJANCNFSM4SQ7FJGQ&data=04*7C01*7C*7C3f285348e4d848f550c008d8745a14be*7C569df091b01340e386eebd9cb9e25814*7C0*7C0*7C637387277545076902*7CUnknown*7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0*3D*7C1000&sdata=tPlM*2FedaDligNYAasbQN8QlhJsWdN*2FMTEmiHCvNYrPo*3D&reserved=0__;JSUlJSUlJSUlJSUlJSUlJSUlJSU!!H8mHWRdzp34!sejezBWOCcGBY5X_yyGKKF7mES-FxwQRkC3BdxJZMbKiv-CKH7INg5EPkFO8wR7j$.

repo: jessegmeyerlab/PeCorA


text:
JSQMessagesBubbleImageFactory initialized with custom image for chat bubble not working

New issue checklist

[ ] I have read all of the README, documentation, and FAQ.
[ ] I have reviewed the contributing guidelines. Confirmation: ____
[ ] I have searched existing issues and this is not a duplicate.

General information

Library version(s):
iOS version(s):
Devices/Simulators affected:
Reproducible in the demo project? (Yes/No):
Related issues:

Bug report
Expected behavior

...

Actual behavior

...

Steps to reproduce

...

Crash log? Screenshots? Videos? Sample project?

...

Question or Feature Request

...

Help Needed
Need to hide the default image of bubble and show my own bubble image, try to change image using following code but not working
outgoingBubbleImageView = JSQMessagesBubbleImageFactory.init(bubbleImage: UIImage(named: "bubbleMine"), capInsets: UIEdgeInsetsZero).outgoingMessagesBubbleImageWithColor(UIColor.grayColor())

...

Thanks @bikram109 ! 😄
You need to return your images from the data source method, messageBubbleImageDataForItemAtIndexPath:

source: gharchive/issue

repo: jessesquires/JSQMessagesViewController

license: mit

license_type: permissive

license_source: bigquery


text:
Static input toolbar - toolbar not moving with keyboard

Hi,
My setup is the following. My root controller is a tab bar controller. On the active tab I have a navigation controller with a similar setup as the demo project. On pushing the message view I hide the tab bar and everything looks good. When I tap on the input toolbar the keyboard appears but the input toolbar remains at the bottom of the view. See images below. Also if I start typing multiple lines the text view doesn't expand.
Not sure if this is a bug or something wrong in my implementation. I have pretty much copy pasted the demo project code.
Thanks,
Michael

Thx, guys, had the same problem.

You save my hours as well.
Thanks a lot man.

@jessesquires Thanks a lot

hi ,
When I had almost the same problem. When clicking on the accessory button in , i choose a picture using imagepicker and then when i come back to the JSQViewController the inputtoolbar is disappearing. I tried to use
[self.inputToolbar.contentView.textView becomeFirstResponder]; when

(void)imagePickerController:(UIImagePickerController *)picker didFinishPickingMediaWithInfo:(NSDictionary *)info
{
[self.inputToolbar becomeFirstResponder];
and
[self.inputToolbar.contentView.textView resignFirstResponder];
}

But it didnt change

any news about this issue? @jessesquires

thanks guys for this!

authors: Serge-Staravoitau carloskekwa imuhammadjabbar kingkeishan realsurfer yadavanand


text:
Errors when running downsample_logging.py

Hi,
I followed the ReadMe and recording start but shortly after the follow errors start to occur repeatedly.
I am running a JS110
Any thoughts ?
Thanks
2023-09-15T13:48:26 ERROR    status returned 11
2023-09-15T13:48:28 WARNING  ctrl_in timed out
2023-09-15T13:48:28 ERROR    status returned 11
2023-09-15T13:48:31 WARNING  ctrl_in timed out
2023-09-15T13:48:31 ERROR    status returned 11
2023-09-15T13:48:34 ERROR    handle_rsp unsupported !ctrl_in
2023-09-15T13:48:35 WARNING  ctrl_in timed out
2023-09-15T13:48:35 ERROR    status returned 11
2023-09-15T13:48:35 ERROR    handle_rsp unsupported !ctrl_in
2023-09-15T13:48:36 WARNING  ctrl_in timed out
2023-09-15T13:48:36 ERROR    status returned 11
2023-09-15T13:48:36 ERROR    handle_rsp unsupported !ctrl_in
2023-09-15T13:48:38 WARNING  ctrl_in timed out
2023-09-15T13:48:38 ERROR    status returned 11
2023-09-15T13:48:39 WARNING  ctrl_in timed out

Those messages indicate that your JS110 is not correctly communicating with the host.  A few questions:

What host OS and computer are you using?
Is the JS110 connected directly to a USB port on the host computer, no hubs, docks or adapters?
Does this same setup work with the Joulescope UI?

Hi,

Its Mac M1 running OSX Venutra.
The JS110 goes via an Apple USB to USB-C converter but thats it.
Joulscope UI seems to work fine.
Python 3.11.3 (main, Jun  5 2023, 13:12:00) [Clang 14.0.3 (clang-1403.0.22.14.1)]

Thanks,
Serge

Ok, macOS does some annoying power management that may prevent this script (and all others) from working.
Do you care about standard deviation?  If not, you can also try using on-instrument 2 Hz statistics.  Add the --source sensor command line argument to downsample_logging.py.
In the Joulescope UI, we use appnope to prevent macOS from performing app nap.  You could modify downsample_logging to have this.  First, pip install appnope.  Then just insert this near the top of downsample_logging.py:
import appnope
appnope.nope()

Does this help?

Hi,
Neither option resolves the issue.
Thanks,
Serge

Ok, so I am not sure what is happening yet.  Let's try a few other things:

Is your mac plugged into power?
Do both the sensor-side LED under "IN" and the host-side "Status" LED remain illuminated when this occurs?
Does this command work: python -m pyjoulescope_driver statistics

Ok.  I do not understand what is happening with downsample_logging.py on your machine.  I just tried this on a MacBook POro 13-inch 2020 M1 running macOS 13.4.1 (c) with python 3.11.5.  It has been running over 5 minutes.  I will keep it running and let you know if I see anything.
Are you running brew?  You can update everything: brew update && brew upgrade
You can also ensure that the python packages are up to date: pip install -U --upgrade strategy eager joulescope
Does running python -m pyjoulescope_driver statistics get you what you need?

OK thanks, I changed the USB adapter but that did not help nor did the upgrades. I am still going to try a different USB cable.

I dont know, I have to read-up and see what it does.

Thanks

I saw that I had a macOS update.  I updated to macOS 13.5.2, but downsample_logging.py still works for me.
However, I noticed a few log messages that I think indicates that the JS110 is still streaming samples even with the --source sensor argument.  It should not be, which significantly reduces the data rate and chance for errors.  If you only need statistics data from a single JS110 source, then python -m pyjoulescope_driver statistics is a great choice.

Hi.
Did this ever get fixed ?
However, I noticed a few log messages that I think indicates that the JS110 is still streaming samples even with the --source sensor argument
I am still unable to use downsample_logging.py
Thanks,
Serge

Hi @ssozonoff  - We did no further investigation since we could not duplicate the issue and you seemed to be OK.
We will try to duplicate this again.
To confirm. is this the command you are having trouble with?
python3 downsample_logging.py --source sensor

Hi.That’s correct. I have run a large bunch of updates Python, etc…. but no change. I have tried another USB cable, USB port and even an adapter but still getting the error.Thanks,Serge Sent from my iPhone 6On 5 Mar 2024, at 21:34, Matt Liberty @.***> wrote:
Hi @ssozonoff  - We did no further investigation since we could not duplicate the issue and you seemed to be OK.
We will try to duplicate this again.
To confirm. is this the command you are having trouble with?
python3 downsample_logging.py --source sensor
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: @.***>

Hi @ssozonoff
There are really two problems here:

Your MacBook does not support JS110 sample streaming.
The downsample_logging.py script causes JS110 sample streaming, even with --source sensor.  I confirmed the sample streaming using a TotalPhase Beagle USB 5000.

I suspect that MacBook power management is causing (1).  However, we have not proven this.  Looking at the conversation above, I see that appnope did not solve the problem.
If we could fix (2), then (1) becomes less of an issue for the moment.  I took a closer look at downsample_logging.py.  While it still works, it was also the first script we wrote after launching the JS110.  Since the focus of this script is reliability, it really should now directly use pyjoulescope_driver and avoid the additional complexity of the joulescope package.  I have made these changes.
Can you please try out the latest downsample_logging.py script?
Does this updated script now work for you?

Hi Matt,
I tested the modified downsample_logging.py script you provided and it works fine. Thanks for porting it to use pyjoulescope_driver.
Kind regards,
Serge

license_source: github-api


text:
User Interface Enhancements

From usability-testing the following improvements were found and should be implemented in the next iteration:

Launching and using the application for the first time is time-consuming, since no tutorial is present. A future version could benefit from a short tutorial that appears on launch, which explains all actions and possibilities.
The .json file could contain color codes for the Toolbox-items, so the colors are no longer randomly generated and will appear equal on all processes of Roblocks. This will make referring to items by color more easy, for example during a video call.
The Add (+) and Remove (-) button are not very intuitive, this could be improved a lot by a drag and drop system or by giving component or blocks their own Add and Remove button. This is also the case with the "Settings icon".
The output-view currently appears default on the left of the screen. This should be changed to invisible by default, the average user will not benefit of this view. The position of the Window might also be something to improve.
The log contains both expert and user messages, this should be unambiguous.
Create demonstration and explanation video for the UI.

Node management v0.1 (Wireframes)

Adding nodes
Hidden node actions
Reordering nodes
Wireframe sprint overview

Adding nodes
The function of the Add (+) and Remove (-) button is unclear in it's current location. I propose to put the desired action on the area it's being applied on: the node sequencer.
One solution is to put an empty field at the end in the block sequencer (i'd rather call it a node sequencer) with a CTA option to insert a new node in the sequencer.
The last node in the sequencer (or the first if it's empty) would look something like this:

The resulting node chain would look something like this after adding one node:

Hidden node actions
Other node actions, such as renaming, duplicating and deleting are hidden behind the individual node's settings icon.

Reordering nodes
For reordering nodes I added a drag handle at the top left of each node so that you can easily drag nodes around the sequencer.
Wireframe sprint overview

Splash
#4 (Splashscreen)
Hi @jetspiking
Little off topic, but what do you think about this fancy new splash screen (& logo) design? 😏

I think it looks amazing! There is no way I could have made that myself. If you are okay with it I am going to put this in the next version. I will add a credit section on the GitHub, because your Wireframes and Splashscreen are a large contribution to the project, in my opinion.
Combined with your updated GUI Wireframes it would look much more modern.

Alternative user flow idea
Today I came up with an idea where users can fill action sequencers with blocks, from which variables can be stored in a common side panel.
I also came up with the idea of providing built-in blocks, in the example below: conditional blocks, but you can also think of variable or math blocks.
In the example below, a situation is wireframed in which the robot walks 1 meter ahead, takes a measurement and stores it in variable $sensorValue, and then checks if that variable is greater than 8. If so, it jumps to the next sequencer: Sequencer 2.

authors: jaschahuisman jetspiking

repo: jetspiking/Roblocks

license: MIT


text:
Installation without webhook not working

I attempted to install cert-manager without webhooks as outlined here on GKE with Kubernetes 1.13: https://docs.cert-manager.io/en/latest/getting-started/webhook.html. Unfortunately by installing kubectl apply -f https://github.com/jetstack/cert-manager/releases/download/v0.9.1/cert-manager-no-webhook.yaml.
we get:
Internal error occurred: failed calling webhook "webhook.certmanager.k8s.io": the server could not find the requested  resource

In the past we had version 0.5.2 installed. First we tried to setup with webhooks. But this resulted in similar errors already during installation. webhook itself did subsequently not start because of missing TLS certificates. The namespace was properly labeled to disable validation.
I would have expected this error to disappear when not using webhooks.

interestingly I attempted to downgrade to 0.5.2 again and still see the same issue. Fairly certain everything v0.9.1 related is gone.

Any update on this issue? Facing a similar problem.

To my part I test the 0.9.1 without webhook it failed but 0.8.1 works

We've had the same issue when upgrading from 0.6.x to 0.9.1 and got around it by manually removing the MutatingWebhookConfiguration from the admission controller:
kubectl delete MutatingWebhookConfiguration cert-manager-webhook
After that I ran into the problem that the ingress-shim flags in the Helm chart are seemingly not supported anymore (--default-issuer-name etc), but that's a different issue altogether.

Yep, it looks like you've not properly cleaned up the webhook resources you created when you first tried to install with the webhook enabled.
I'm going to close this as it isn't really a bug, rather a misconfiguration caused by a borked upgrade/downgrade 😄

authors: munnerz obeyler remmeier spyroslalos svmaris

repo: jetstack/cert-manager


text:
For Helm, what's the difference between cluster-resource-name in extraArgs and global section?

Hi,
What's the difference between the two settings on cluster-resouce-namespace?
First is here
https://github.com/jetstack/cert-manager/blob/725705cde5f0c155664fd5a6ee4e23627e95a854/deploy/charts/cert-manager/values.yaml#L70
# Override the namespace used to store DNS provider credentials etc. for ClusterIssuer
# resources. By default, the same namespace as cert-manager is deployed within is
# used. This namespace will not be automatically created by the Helm chart.
clusterResourceNamespace: ""

Second is here
https://github.com/jetstack/cert-manager/blob/725705cde5f0c155664fd5a6ee4e23627e95a854/deploy/charts/cert-manager/values.yaml#L87
extraArgs: []
  # Use this flag to set a namespace that cert-manager will use to store
  # supporting resources required for each ClusterIssuer (default is kube-system)
  # - --cluster-resource-namespace=kube-system

Hi, thanks for opening the issue.
I think you should only use the top level clusterResourceNamespace key. They both set the --cluster-resource-namespace flag on cert-manager controller deployment, but we should not use extra args to configure flag if there is already a top level key for it. Also the flag is anyway always set by looking at clusterResourceNamespace key (see here) so providing it via extra args would result in deployment config with the same flag set twice (with the value from extra args having priority).
I'm going to remove the  - --cluster-resource-namespace example from the extra args to avoid confusion.

Thanks for the detailed reply!

authors: introom irbekrm


text:
Change TabPane ripple color from CSS

Hello,
How do I change the TabPane ripple color from CSS ? I looked at the Java code and the rippler has no id nor class associated with it, so I don't think I can link it from the CSS... I saw the -fx-ripple-color property but it doesn't seem to work wherever I put it.

well the property is -fx-rippler-fill not -fx-rippler-color, here is an example of how to change the JFXTabPane rippler color:

.jfx-tab-pane .tab-header-area .jfx-rippler{
	-fx-rippler-fill:RED;
}

It works, thanks!

need css for  JFXTabpane
change slider color on selected tab and also change the background color of tab pane by background like this

idk why this isnt working for me. I put a usual tab from the builder to jfx tab pane

For the background color of tab pane , try this:
.jfx-tab-pane .headers-region
{
-fx-background-color: black;
}
.jfx-tab-pane .tab-header-background
{
-fx-background-color: black;
For changing the slider color on selected tab that's my BIG problem. I'm using jfoenix 1.7.0 and i tried everything that i could remember so far... and nothing! :(((( If someone could give me some tips i really apreciate.

Hello,
you can change the slider color and rippler color using the following css:
.jfx-tab-pane .tab-selected-line {
	 -fx-stroke: #color;
 }

 .jfx-tab-pane .tab-header-area .jfx-rippler {
	 -jfx-rippler-fill: #color;
 }

Regards,

Yes, but "-fx-stroke" doesn't work in the v1.7.0 !
i tried a few minutes ago:
.jfx-tab-pane .tab-selected-line
{
-fx-border-color: red;
}
and it worked.
I still didn't found out how to change the Tabs labels color.

authors: bobnathanzeonbe jfoenixadmin natinusala peteralien yogi0823

repo: jfoenixadmin/JFoenix


text:
JFXDecorator doesn't respect setOnCloseRequest

If you use a JFXDecorator, your window will go away when you hit the X, but any listeners set with primaryStage.setOnCloseRequest will not fire.
I've taken a gander at the source code and seen that when you close a JFXDecorator the default is that Stage.close() is called. As far as I understand, this is because we don't want to close all the windows, right?
If that's the case, is there a reason we shouldn't let the default be to fire a WINDOW_CLOSE_REQUEST event instead? It seems to close just the one window, as well as firing any listeners.
stage.fireEvent(new WindowEvent(stage, WindowEvent.WINDOW_CLOSE_REQUEST));

Jewelsea, gave me the idea.

Hi,
yeah sure, it's better to fire the event. I was expecting that close events will be fired upon calling the method close(). @TurekBot  can you create a PR with this fix?

Looking at what jewesea says, it seems that the reasonclose() doesn't trigger the listeners is because it does an internal close and firing a close event does an external close.

@TurekBot thanks for clarification :)

I'll fix it and update the repo, thanks @TurekBot  for pointing out the issue 👍

authors: TurekBot jfoenixadmin


text:
JFROG CLI 2.54.0 regression upon npm p execution

Describe the bug
Hey,
Since the new version of the JFROG CLI, the command jfrog npm p does not build anymore but leads to a runtime error.
Everything's ok in the 2.53.2.
Current behavior
jfrog npm p --build-name=vod-nutflix-front --build-number=0.6.0-0 vod-nutflix-front-0.6.0-0.tgz --registry <artifactory>
16:05:32  panic: runtime error: invalid memory address or nil pointer dereference
16:05:32  [signal SIGSEGV: segmentation violation code=0x1 addr=0x24 pc=0x872aeda]
16:05:32
16:05:32  goroutine 1 [running]:
16:05:32  github.com/jfrog/jfrog-client-go/utils/io/content.(*ContentReader).NextRecord(0x0, {0x8bac6a0, 0xb87e4e0})
16:05:32  	/root/go/pkg/mod/github.com/jfrog/jfrog-client-go@v1.38.0/utils/io/content/contentreader.go:66 +0x6a
16:05:32  github.com/jfrog/jfrog-client-go/artifactory/services/utils.ConvertArtifactsDetailsToBuildInfoArtifacts(0x0)
16:05:32  	/root/go/pkg/mod/github.com/jfrog/jfrog-client-go@v1.38.0/artifactory/services/utils/resultutils.go:86 +0x85
16:05:32  github.com/jfrog/jfrog-cli-core/v2/artifactory/commands/npm.(*NpmPublishCommand).Run(0xba87620)
16:05:32  	/root/go/pkg/mod/github.com/jfrog/jfrog-cli-core/v2@v2.49.0/artifactory/commands/npm/publish.go:197 +0x40a
16:05:32  github.com/jfrog/jfrog-cli-core/v2/common/commands.Exec({0x8ebdaa8, 0xba87620})
16:05:32  	/root/go/pkg/mod/github.com/jfrog/jfrog-cli-core/v2@v2.49.0/common/commands/command.go:26 +0xa6
16:05:32  github.com/jfrog/jfrog-cli/buildtools.NpmPublishCmd(0xb92e420)
16:05:32  	/var/****_home/workspace/eco-system/release/jfrog-cli-release/temp/jfrog-cli/buildtools/cli.go:868 +0x26b
16:05:32  github.com/jfrog/jfrog-cli/buildtools.npmGenericCmd(0xb92e420, {0xfff397b7, 0x1}, 0x0)
16:05:32  	/var/****_home/workspace/eco-system/release/jfrog-cli-release/temp/jfrog-cli/buildtools/cli.go:830 +0x138
16:05:32  github.com/jfrog/jfrog-cli/buildtools.GetCommands.func11(0xb92e420)
16:05:32  	/var/****_home/workspace/eco-system/release/jfrog-cli-release/temp/jfrog-cli/buildtools/cli.go:331 +0x190
16:05:32  github.com/urfave/cli.HandleAction({0x8b475a0, 0x8d46618}, 0xb92e420)
16:05:32  	/root/go/pkg/mod/github.com/urfave/cli@v1.22.14/app.go:524 +0x50
16:05:32  github.com/urfave/cli.Command.Run({{0x8c7bb82, 0x3}, {0x0, 0x0}, {0x0, 0x0, 0x0}, {0x8ca4ce6, 0x10}, {0x8d324f7, ...}, ...}, ...)
16:05:32  	/root/go/pkg/mod/github.com/urfave/cli@v1.22.14/command.go:175 +0x63e
16:05:32  github.com/urfave/cli.(*App).Run(0xb925340, {0xb828140, 0x8, 0x8})
16:05:32  	/root/go/pkg/mod/github.com/urfave/cli@v1.22.14/app.go:277 +0xb11
16:05:32  main.execMain()
16:05:32  	/var/****_home/workspace/eco-system/release/jfrog-cli-release/temp/jfrog-cli/main.go:139 +0x4d5
16:05:32  main.main()
16:05:32  	/var/****_home/workspace/eco-system/release/jfrog-cli-release/temp/jfrog-cli/main.go:78 +0x23

Reproduction steps

Use the latest cli version
Run npm p using the jfrog cli

Expected behavior
It should build
JFrog CLI version
2.54.0
Operating system type and version
RHEL 8 in docker
JFrog Artifactory version
No response
JFrog Xray version
No response

Hey @Thomas-Boutin,
Thank you for using JFrog CLI!
I was unsuccessful in replicating the problem. Could you kindly offer more detailed instructions on how to reproduce it?

Set CLI debug log level by : export JFROG_CLI_LOG_LEVEL=DEBUG
Share the package.json file.

Providing thorough steps to recreate this issue would greatly assist us in resolving it.
I made an attempt to replicate the issue by installing version v2.54.0 of the CLI within a RHEL 8 Docker image, but the problem did not arise.

Additional information : the above job is running with npm 10.2.4 and node 20.11.1

Hey @Thomas-Boutin,
Thank you for this information.
I was able to reproduce the issue and fix it, you can track the progress in the following PR
As a temp workaround you could downgrade the cli version or use jf npm p without providing an already packed npm package ( the jf command will pack it for you )
Thank you for the bug report!

@EyalDelarea cheers good job!
Thanks for the fast fix. We've already downgraded the cli version. Looking forward to having this fixed :-)
Have a nice day

Hey @Thomas-Boutin ,
A new version of the CLI has been released and the fix is included.
Feel free to reach out if you require further assistance!

Hey @EyalDelarea I'll test this one I'll let you know

Thanks for the update @Thomas-Boutin!

authors: EyalDelarea Thomas-Boutin eyalbe4

repo: jfrog/jfrog-cli


text:
Update docs for artifactory_federated_gems_repository

Describe the bug
The documentation for artifactory_federated_gems_repository incorrectly says gem.
Requirements for and issue

[x] A description of the bug
[ ] A fully functioning terraform snippet that can be copy&pasted (no outside files or ENV vars unless that's part of the issue). If this is not supplied, this issue will likely be closed without any effort expended.
[ ] Your version of artifactory (you can curl it at $host/artifactory/api/system/version
[ ] Your version of terraform
[ ] Your version of terraform provider

Expected behavior
Documentation should list the correct resource type.
Additional context

https://github.com/jfrog/terraform-provider-artifactory/blob/f6234647759f9a2e14a981f204297dc87954d5e0/pkg/artifactory/resource/repository/federated/federated.go#L15
https://github.com/jfrog/terraform-provider-artifactory/blob/master/docs/resources/federated_gems_repository.md is one of the places that will need to be updated.

Terraform v1.2.6
on linux_amd64
+ provider registry.terraform.io/jfrog/artifactory v6.15.1

repo: jfrog/terraform-provider-artifactory


text:
One step application of changes

Sorry for ignoring the template, I would just have a question:
Is there a way to apply a pattern in one step, e.g. using it with the Commander plugin or Obsidian Advanced URI?
Use case:
When applying changes to selection, one might need to use plugin 4-5 times on the same file (e.g. deleting some quotation marks but not all). In the current workflow (I am using iPad), one would need to invoke Command Pallette, select Apply Patterns/Selection and scroll down to Pattern on demand.
The three steps could be shortened to one if the user could pin a command somewhere.
Is what I want currently achieveable in some way or, if not, would you consider implementing a method to achieve it?
Thank you for your time
Cheers

Thank you for reaching out. To confirm, it is possible to create Command Palette commands for single Patterns or groups of Patterns, using the "Commands" section of the Apply Patterns settings menu. Those can then be invoked with, e.g., the QuickAdd plugin, to pair them with other Command Palette commands in sequence.
Does that address your question?

You're welcome! Thank you for asking!

authors: jglev zanodor

repo: jglev/obsidian-apply-patterns-plugin


text:
Facebook Insights Pagination Won't Stop

#The following does not stop at the until date. It keeps paginating on for dates that do not exist yet.

from facepy import GraphAPI

graph = GraphAPI("XXXXXXX")

#Get page fans
pages = graph.get('/OBJECT/insights/page_fan_adds?since=1397079426&until=1397338626', page=True, retry=2)
print pages

import json, urlparse

fb_dump = open('dumpfb4.txt', 'w')

all_pages = []

for page in pages:
    all_pages = all_pages + page["data"]
    print all_pages

fb_dump.write(json.dumps(all_pages, indent=4))

I'm gonna close this and focus on #126.

authors: jgorset spacecrusader

repo: jgorset/facepy


text:
Allow only a specific group of people to access draw.io

How to open access to use Draw.io only for a specific group?
https://desk.draw.io/a/tickets/12471

Unfortunately, Atlassian connect does not provide any means to achieve this. Given the platform will be deprecated, it's unlikely Atlassian will add support.

authors: davidjgraph mararad

repo: jgraph/drawio


text:
"Words overlap in container while using PlantUML" (Draw.io uses a PlantUML server/docker with only one installed font?)

Preflight Checklist

[x] I agree to follow the Code of Conduct that this project adheres to.
[x] I have searched the issue tracker for a feature request that matches the one I want to file, without success.

Describe the bug
If I add following PlantUML diagram in Draw.io then the characters overlaps (output is SVG).
If the diagram is displayed on the online PlantUML server then it is correct displayed (output is SVG too).
@startuml
header plantuml %version()

[=SPA\n=Admin SPA\nSPA\nAdmin SPA]
@enduml

draw.io output:

PlantUML online server output:

My assumption is that only one font is installed on the used PlantUML server/docker and therefore wrong distances,... are calculated.
Therefore I listed all available (PlantUML) fonts and create a png file (that it is independent of the e.g. fonts which are installed in the  browsers,...) and this looks for me that only one font is installed on the used PlantUML server/docker.
@startuml
listfonts <size:20>Admin SPA
@enduml

draw.io output:

(details see below)
My original issues is documented in C4-PlantUML with a detailed analysis.
And I think it is also related to the  "off-topics" comments of https://github.com/jgraph/drawio/issues/4020.
To Reproduce

Go to 'https://app.diagrams.net'
Add a new PlantUML diagram via "Arrange->Insert->Advanced->PlantUML"
Enter following text

@startuml
header plantuml %version()

[=SPA\n=Admin SPA\nSPA\nAdmin SPA]
@enduml

Check that "PlantUML (SVG)" is selected and press "Insert"
And you see the image with the overlapping characters

Expected behavior
The PlantUML server/dockercalculates the correct distances (based on the installed fonts) that the SVG diagram can be drawn without any overlaps,
Screenshots
see above and below
draw.io version (In the Help->About menu of the draw.io editor):

https://app.diagrams.net/?src=about;  version 24.7.17

Desktop (please complete the following information):

OS: Windows
Browser: Edge (but also Chrome has the same problem)
Browser Version: 129.0.2792.79

I tested the problem in incognito/private mode with all browser extensions switched off, write "yes" below:

yes

Additional context
The original issues is documented in C4-PlantUML with a detailed analysis.
But I think the most important difference is that the PlantUML online server has more installed fonts and you see that ex. "SansSerif" and "Serif" use different fonts in the png output of the PlantUML online server (and in draw.io even the "Serif" font has no serifs):
@startuml
listfonts <size:20>Admin SPA
@enduml

PlantUML online server output:
(the image has a link to the PlantUML online server, that you can compare it online too)

If you are using a docker image it could be the simplest to add more fonts based on following PlantUML instruction: Additional fonts inside the PlantUML docker container

We use PlantUML on AWS lambda, it provides for a massive reduction in attack-surface. A side effect of this is that only one font is available, yes.
But, this is meant as an as-is PlantUML implementation. If you want a fully featured, fully up to date implementation draw.io is the wrong tool.

authors: davidjgraph kirchsth


text:
guarded relevance test

Do not merge, but here's a first cut at guarded relevance for testing

It might not be complete, but this looks quite good. Going to merge it in.

source: gharchive/pull-request

repo: jgstew/jgstew-recipes


text:
Using TAB to go down instead of autocomplete

Hello !
I would like to make TAB going down instead of autocomplete.
I tried to hack tty_interface.c but didnt succed to find where and how the TAB keybinding was handled.
It looks like its handled by CTRL+I witch is a bit weird.
peace

I don't think there's enough interest in this. Thanks for the suggestion.
I find tab occasionally useful for the ability to add additional text in the returned result (ex. to make a new similarly named file).

repo: jhawthorn/fzy


text:
Error Argument of type 'number' is not assignable to parameter of type 'string' in user-management.component.ts

When running npm start it gives following error
ERROR in /src/main/webapp/app/admin/user-management/user-management.component.ts(98,15) TS2345: Argument of type 'number' is not assignable to parameter of type 'string'.
Issue is code passes integer value to the  userManagementService().remove function while it requires a string and can be fixed by simply converting it to a String like this
this.userManagementService()       .remove(String(this.removeId))

Another issue (very close) has been created after yours: https://github.com/jhipster/jhipster-vuejs/issues/484.
I tried to reproduce the problem but this seems to have been fixed since you submitted this issue. I'm closing it, don't hesitate to re-open the ticket if you're still facing this bug.

authors: harshajayaweeraXHJ hdurix

repo: jhipster/jhipster-vuejs


text:
Please restore support for Windows to WidevineCDM

Description
Please restore Windows support to WidevineCDM as a part of nativefier.
Steps to reproduce issue
Basically, run any nativefier command on Windows to attempt to create a native app that uses DRM protection. It no longer works on Windows computers. Google Chrome's implementations keeps failing and the electron widvinecdm plugin is discontinued by the developer. He/She stated on the page though that anyone who wishes to take over the project can do so, they just need to contact him/her.  As it is, it's outdated and has no Windows support at all.
Details

Are you nativefying a public website? Yes

Feature request? Have you looked at nativefier --help to see if an existing option could fit your needs? Yes

Full nativefier command used to build your app: nativefier --name "NETFLIX" "https://www.netflix.com/" --flash --widevine-cdm-path "C:\Program Files (x86)\Google\Chrome\Application\73.0.3683.103\WidevineCdm\_platform_specific\win_x64\widevinecdm.dll\" --widevine-cdm-version "4.10.1303.2"

Version of Nativefier (run nativefier --version): v7.6.12

Version of node.js (run node --version): v10.15.3

OS: Windows 7 Ultimate x64

Error message / stack trace (if any):

https://libraries.io/npm/electron-widevinecdm

this is impossible!
Widevine is a commercial platform, needs a license for any browser project

authors: PhantomNimbi mxdpeep

repo: jiahaog/nativefier


text:
The NUS-WIDE dataset

Hello! I have an question that I can get the NUS-WIDE.mat from your matlab implement but there is no nus-wide images dataset for pytorch implement. Can the author share the Nus-wide image dataset ?
Thank you very much !

I have update the links and password. You can download nus-wide dataset now.

You're so nice. Thank you very much.

Hi @jiangqy,
Where can I download NUS-WIDE dataset for pytorch?

@josianerodrigues Hi, please contact the author of NUS-WIDE. Mr. Xindi Shang, (shangxin AT comp.nus.edu.sg) from nus-wide homepage

Thank you!

nus-wide homepage is not opening. how can I download NUS-WIDE dataset.

I don't know is there any other resources. Maybe you can contact the authors of NUS-WIDE? @scpmail

authors: forrestlly jiangqy josianerodrigues scpmail


text:
Changes to run e2e for private cluster

Fixes #N/A
Description
How was this change tested?
Does this change impact docs?

[ ] Yes, PR includes docs updates
[ ] Yes, issue opened: #
[x] No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Request Test Coverage Report for Build 7981678542
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.02%) to 82.514%

Totals

Change from base Build 7981674866:
0.02%

Covered Lines:
5016

Relevant Lines:
6079

💛  - Coveralls


text:
[Search] Add Order By

https://myanimelist.net/anime.php?q=&letter=&type=0&score=0&status=0&p=0&r=0&sm=0&sd=0&sy=0&em=0&ed=0&ey=0&c[0]=a&c[1]=b&c[2]=c&c[3]=d&c[4]=e&c[5]=f&c[6]=g&gx=0&o=7&w=2&o=7&w=1
It's possible to order by columns available on the search results by passing some extra GET params.

An attempt to understand get parameters in MAL searches:

Param Name
Description
Example
Range

q
search query
q=Hello
Any Alphabetical character

score
any score that starts with this int
Gintama has a score 9.14, so it should show up on score=9
1 -10, but should be 1 - 9 since nothing will ever be scored 10/10 on MAL

type
type, e.g. Movie/TV
type=0
0=all, 1=TV, 2=OVA, 3=Movie, 4=Special, 5=ONA, 6=Music

status
airing status
status=2
3=unaired, 2=finished airing, 1=airing, 0=all

p
producer
p=11
p=<producer_id>, where producer is the corresponding id in https://myanimelist.net/anime/producer/11

r
rating
r=2
0=all, 1=G, 2=PG, 3=PG-13, 4=R, 5=R+ (no 6=Rx???)

sm, sd, sy
start month/day/year
sd=1&sm=5&sy=2015
typical date ranges. If a start date is specified by no end date, this gives you anything after that start date

em, ed, ey
end month/day/year

analogous to above

I realize that this stuff is already in Jikan, I just wanted to wrap my head around it and thought this might be an alright place to leave this.
Regarding the URL above, I dont know whats going on with the
o=7&w=2&o=7&w=1 at the end.
I'm not super familiar with GET parameters, does one overwrite the other...? o=7 twice?
Also, not sure if its something you'd want to add, but we're missing the letter paramter. E.g.:
https://myanimelist.net/anime.php?letter=. (punctuation)
https://myanimelist.net/anime.php?letter=A
https://myanimelist.net/anime.php?letter=B
For anime that start with that letter

I'm not super familiar with GET parameters, does one overwrite the other...? o=7 twice?
Yep, that's my bad. I just dumped the URL in a hurry. o=7&w=1 is currently applying to the request, it overwrites the previous o and w params.

I realized we were missing the letter param. Seems like I forgot to add it then. I made a commit that adds it. Would be there in the next update

Great.
Also, regarding the w parameter (which only reverses order for o=6,7,8,9), they dont use the w parameter for o=1-5 and instead split those into two (e.g. o=0 ascending name, o=1 descending name)
Using o=7 (popularity) as an example
These two order in descending order
https://myanimelist.net/anime.php?o=7: Descending
https://myanimelist.net/anime.php?o=7&w=1: Descending
Anything else orders in ascending order:
https://myanimelist.net/anime.php?o=7&w=-1
https://myanimelist.net/anime.php?o=7&w=2
https://myanimelist.net/anime.php?o=7&w=0
https://myanimelist.net/anime.php?o=7&w=6023424

Seems the w parameter can be used on o=0-6, but it doesn't offer any additional information.
These sort titles alphabetically
https://myanimelist.net/anime.php?o=0
https://myanimelist.net/anime.php?o=0&w=52345
https://myanimelist.net/anime.php?o=0&w=2
But specifying exactly w=1 to o=0 will sort it in reverse, even though o=1 already sorts it in reverse. i.e. these are equivalent:
https://myanimelist.net/anime.php?o=0&w=1
https://myanimelist.net/anime.php?o=1
I dont think this  that important, following this gives you every possibility for ordering.

Oh, jikan is missing the p (producer) param as well, unless you already added that.
In addition, here, it says the q= is required for v3+, but I dont think it has to be.
It would be pretty useful to not require the q as that means the search endpoint can become a way to create a list of every approved entry on MAL, which is a common problem in the discord.
I understand that the MAL anime.php endpoint requires a minimum amount of parameters to work, and just doing https://myanimelist.net/anime.php?q=&type=0&score=0&status=0&p=0&r=0, where the q is empty, and every other basic param is 0, which means 'all', it results in an error.
However, using the order parameter allows you to search for something without a query:
https://myanimelist.net/anime.php?q=&type=0&score=0&status=0&p=0&r=0&o=0
The corresponding request on jikan might be api.jikan.moe/v3/search/anime?page=1
If no orderby is specified in the jikan parameters, it can default to one (e.g. o=0; alphabetical), to allow searches without queries.
e.g. this:
api.jikan.moe/v3/search/anime?page=1
would convert to:
https://myanimelist.net/anime.php?q=&o=0
One could iterate from
api.jikan.moe/v3/search/anime?page=1
(https://myanimelist.net/anime.php?q=&o=0)
to
api.jikan.moe/v3/search/anime?page=314
https://myanimelist.net/anime.php?q=&o=0&show=15650
to get a list of all entries

You're right seems like producer is missing from just the REST API as well :fearful: I will add that asap.
It seems like I misphrased the "requirement" of q - what I meant was depreciating the backward compatibility of searching like this in v2 /search/Fate which was causing issues. Hence the usage of q was "required". Sorry about the confusion, I will need to fix that in the docs.
Regarding how the search would work without the q parameter, it's currently possible to run that query: api.jikan.moe/v3/search/anime?page=1 returns empty - as would https://myanimelist.net/anime.php?q=
Here are some examples:
/v3/search/anime?genre[]=1&genre[]2 (multiple genre response)
/v3/search/anime?start_date=2019-04-29 "upcoming"
v3/search/anime?status=upcoming alternative "upcoming"
/v3/search/anime?rated=g
api.jikan.moe/v3/search/anime?page=1

would convert to:

https://myanimelist.net/anime.php?q=&o=9&w=2

I feel defaulting these two would be incorrect. The goal is to respond the same stuff MAL would with the same query passed to MAL.
i.e the response for https://myanimelist.net/anime.php?q= would be "No titles that matched your query were found." So /v3/search/anime?q= returns with an empty array of results as it does.
One could iterate from

api.jikan.moe/v3/search/anime?page=1
(https://myanimelist.net/anime.php?q=&o=9&w=2)

to

api.jikan.moe/v3/search/anime?page=314
(https://myanimelist.net/anime.php?q=&o=9&w=2&show=15650)

to get a list of all entries

I'm hoping to have a different orderby value in order to query that sort of request.
We could possibly do something like this instead:
/v3/search/anime?orderby=added&sort=ascending -> https://myanimelist.net/anime.php?q=&o=9&w=2 (from the first added item onwards)
/v3/search/anime?orderby=added&sort=descending -> https://myanimelist.net/anime.php?q=&o=9&w=1 (from the last added item)
What do you think?

All sounds reasonable,.
I suppose its fine if it doesnt default to an ordering, I dont think youd want to return an error for it but its a bit confusing that https://api.jikan.moe/v3/search/anime?page=1 returns empty
Perhaps adding an example that doesnt have a search query in the docs would help push people towards knowing you can do one without a q param

I think an empty array is the correct response. An error would generally be not an option as all keys with array/object values in the API return empty if they're not present on the website.
Devs can easily check whether array/object values are empty and respond accordingly in their apps.
Indeed, I will further document search examples. :100:

So here's my compiled understanding and testing of the ordering and sorting so far:
Note: all these requests are appended with the following GET arguments:
c[]=a&c[]=b&c[]=c&c[]=f&c[]=d&c[]=e&c[]=g
This ensured the availability of all the available columns as listed below. The o value will change if these arguments are not passed on.
There are two sorting values for w that work for o from 0-9

Sort Direction
Value

Ascending
0

Descending
1

Note: However, the behavior for these two value are reversed if a certain o is the reverse of of it's other. See examples below with reverse marked.
Anime

Column
Order By Value o=value
Default Sort Value on MAL (without passing w)

title
0
0

title (reverse)
1
It's same as passing w=1 to o=0; thus we can ignore this value safely

start date
2
1 (Defaulted by the anime with the most future start date to the oldest)

score
3
1 (high -> low)

score (reverse)
4
1 (low -> high)

end date
5
1 (Defaulted by the anime with the most future end date to the oldest)

type
6
1 (Music -> ONA -> Special -> Movie -> OVA -> TV -> Unknown)

members
7
1

rated
8
1 (Rx -> R+ -> R -> PG13 -> PG -> G)

MAL ID
9
1 (high -> low)

Added to the parser, transferring the issue to the jikan-rest repo.

authors: irfan-dahir purplepinapples

repo: jikan-me/jikan


text:
I get no sound from the sound actuator

I have tried a number of firmwares on my A6 4G 2.0TDI, some with CAN bus errors in the control unit and some error-free.
nevertheless, the actuator does not make a sound while driving, regardless of the driving mode. Only the actuator diagnosis works, there the usual whistling sound is emitted. But absolutely nothing happens while driving.
Anyone know what could be the problem?
Warm greetings

Can you share exactly what errors you get?

I have same problem: a6 2.0tfso 4g 252hp, I tested 4g and 8k firmwares. No docs, but no sound Aktor sound. I think is can us data problem, but don’t know… can somebody check?

Same issue with A3 8V PFL. Flashed TTRS unlocked_1, only output test works, no actuator sound regardless of chosen profile.

I've tried pretty much every file.
Except for the original file, I always have two errors in the A9.
"Can error engine control unit message is missing"
"Can error ESP control unit message is missing"
still no sound :/

This is the current file that does not generate errors.
FL_4G0907159B__0010_UNLOCKED.odx
I think the original file was 0002. But I'm no longer sure because it was blocked at the time and I had the error "Wrong vehicle type".

I think maybe there other problem modifying the firmware. User Oleksii (Alex) Strelets, who has mqb-blog.com , helped me with external soundaktor (exhaust firmwares) and managed to make work, because I had the same problem, exhaust sound no errors but no sound until he modified one line more with 010 editor (sorry, but I'm very dumb with this and I don't know hot to open the template and see what I need to modify). He told me when he modified the firmware: "There is one more byte I still don't know the exact meaning (RFU3 field in the 010 template), and it should be set to zero if the VIN mask was cleared." Can somebody check please if this firmwares can be modified like this?

if anyone wants, they can also take a look at my problem via TeamViewer or AnyDesk.
I'm starting to think there's a wiring error somewhere. Because really none of the files work. The readings in VCDS change properly when changing profiles. but still no sound is output.
I'll leave you my contact details and if anyone is interested, feel free to get in touch.
WhatsApp: 0160/8136671
Email: daniel.fischer95@yahoo.com
Warm greetings.

That's probably not the issue. I'll make a file based on the original to see if it works. Just be patient. 😅

okay thank you very much!
I will wait until they finish the file.

Any news? Going to try to use 010 editor + template...

can you show me how it works in the 010 editor?

I've tried pretty much every file. Except for the original file, I always have two errors in the A9.
"Can error engine control unit message is missing"
"Can error ESP control unit message is missing"
still no sound :/

MQB firmwares are different then those Audi files and they give Engine and Esp error.
Had the same problem on my A4 8K, 2.0TDI.
I have 8K file which works perfectly on TDI.
Let me know if you want to try with it.

Yes of course, I would love to try!

Ich habe so ziemlich jede Datei ausprobiert. Mit Ausnahme der Originaldatei habe ich immer zwei Fehler in der A9.
"Kann Fehlermeldung des Motorsteuergeräts fehlen"
"Kann Fehler ESP-Steuergerätmeldung fehlt"
immer noch kein Ton :/

MQB-Firmware unterscheidet sich von diesen Audi-Dateien und geben Motor- und Esp-Fehler.Hatte das gleiche Problem auf meinem A4 8K, 2.0TDI.Ich habe eine 8K-Datei, die auf TDI perfekt funktioniert.Lassen Sie es mich wissen, wenn Sie es versuchen möchten.

Ich habe so ziemlich jede Datei ausprobiert. Mit Ausnahme der Originaldatei habe ich immer zwei Fehler in der A9. > > "Kann Fehlermeldung des Motorsteuergeräts fehlen" > > "Kann Fehler ESP-Steuergerätmeldung fehlt" > > immer noch kein Ton :/ > > MQB-Firmware unterscheidet sich von diesen Audi-Dateien und geben Motor- und Esp-Fehler.Hatte das gleiche Problem auf meinem A4 8K, 2.0TDI.Ich habe eine 8K-Datei, die auf TDI perfekt funktioniert.Lassen Sie es mich wissen, wenn Sie es versuchen wollen.

Yes of course, I would love to try!

Here you go!
Test it!
If all ok, Jille can upload it on FWs list if he wants. :-)
Diesel - 8K0.zip
BR,
Vex

unfortunately cannot flash the data set.

What you want to flash? Engine sound actuator or exhaust sound? Because that file is for engine actuator xxx159x are for engine sound and xxx160x are for exhaust sound… beware to flash, I fucked up one exhaust sound because I flashed xxx159x file…

@erchoui in previous post he said it is 159.
ODIS message says everything, go to administration and change Expected-Idents.
Then you can flash any file version.
But as @erchoui said beware of unit version 159 or 160.

I want to flash the engine sound drive. So 159. I know that you shouldn't confuse 159 and 160.
I'll try again tomorrow by deactivating the identity.

@erchouiIn einem früheren Beitrag sagte er, es sei 159.
Die ODIS-Nachricht sagt alles, gehen Sie zur Verwaltung und ändern Sie die erwarteten Identitäten.
Dann können Sie jede Dateiversion flashen.
But as @erchoui said beware of unit version 159 or 160.

so it seems to work with your dataset.
However, the noise is very quiet and almost inaudible.

Good that it works, now you can play some more :-)
This is the only one I got working on my A4.
It is from S4, but with diesel RPM, for me it is good 👍

I don't know, it's just a subtle hum. really very quiet. if you really focus on it, you can hear it.
is there a way to make it louder? Volume is already at 100%.
I was hoping for a little more from it.
Unfortunately, I can't try much anymore, since there is almost no radio data set

I don't know, it's just a subtle hum. really very quiet. if you really focus on it, you can hear it. is there a way to make it louder? Volume is already at 100%. I was hoping for a little more from it. Unfortunately, I can't try much anymore, since there is almost no radio data set

That's the problem I have with the 4g firmware!!! I have very poor sound (inaudible) and volume is at 100%, it's like can messages doesn't care to soundaktor and doesn't volume up...
Also, with exhaust sound (C0), I used 4g0 firmware (a6 diesel engine) and sound... my car is petrol... can someone change the dataset for a petrol engine? Thanks!!!! I can upload the firmware that with my car works, this firmware is the only I succesfully make it work...

I found out yesterday that it is suddenly louder and also audible in the kickdown. in normal driving operation, however, it is hardly audible, it only switches on audibly from around 3500rpm. So I would always have to drive above 3500rpm or with kickdown to really get something out of it. :/

This is moded to diesel RPM, but still you have to take in consideration that S4 is petrol engine and it revs on higher RPM, so probably sound map itself is different…
I will try to make one “Frankenstein” file for you to try.
@erchoui upload file, I’ll try to do it.

FL_4G0907160B__0007.MODIFIED3 WORK PERFECT.zip
This is the only one I succeeded make work in my car. No others work. This is the difference why it works  "There is one more byte I still don't know the exact meaning (RFU3 field in the 010 template), and it should be set to zero if the VIN mask was cleared."

I swaped only RPM values in your file with values from file FL_8W0907160___0001, range is now from 500 to 8150.
FL_4G0907160B__0007.MODIFIED3 WORK PERFECT-Benzin.odx.zip

@erchoui
I swaped only RPM values in your file with values from file FL_8W0907160___0001, range is now from 500 to 8150.
FL_4G0907160B__0007.MODIFIED3 WORK PERFECT-Benzin.odx.zip

@OzeanOfDreams
Frankenstein :-)
FL_8K0907159___D006-Borg-Frank.zip

@OzeanOfDreams Frankenstein :-)
FL_8K0907159___D006-Borg-Frank.zip

Super thank you! :)
I'll test the data set today and then give feedback! :)

Unfortunately, the Frankenstein dataset does not work :/

@erchoui I swaped only RPM values in your file with values from file FL_8W0907160___0001, range is now from 500 to 8150.
FL_4G0907160B__0007.MODIFIED3 WORK PERFECT-Benzin.odx.zip

It works!!! It sound louder!!! Can you try to modify the 4g0907159b a9 file with the directions I told you is modified the c0 one file to test? “ There is one more byte I still don't know the exact meaning (RFU3 field in the 010 template), and it should be set to zero if the VIN mask was cleared." I think is the problem that´s why I don’t hear the a9 structure borne sound. I had same problem with exhaust until  Oleksii (Alex) Strelets Modified the 160b file. Many thanks for your efforts!!!

Here you go!
FL_4G0907159B__0002 - D001.zip

Thanks! Tomorrow will test!!!

Bitteschön!
FL_4G0907159B__0002 - D001.zip

could you maybe check for a slightly louder file? It can be a bit exaggerated. I would just like to test what the A9 actuator is capable of.

I think now this issue can be closed because few files I made got it working.
Here is the file with rpm changed.
FL_4G0907159B__0002 - D002 - Borg.zip

@jilleb I think now this issue can be closed because few files I made got it working.
Here is the file with rpm changed...
FL_4G0907159B__0002 - D002 - Borg.zip

what might I have missed using your firmware for the CRTE 3.0 TDI?
The test passes, but does not work at all when the engine is running. Maybe there are some restrictions for CRTE 3.0 Tdi? No errors in the block, test passes :(

Which file did you use before and did it work?

Which file did you use before and did it work?
all for 4g and A9 ecu from download area:

FL_4G0907159B__0010_UNLOCKED.odx
FL_4G0907159B__0010_UNLOCKED_NOFPA.odx
And from that thread:
FL_4G0907159B__0002 - D001.zip
FL_4G0907159B__0002 - D002 - Borg.zip

If my VIN begins with WAUZZ*, than it should be profile ID 1?  maybe the problem is in the 3F engine code?

Maybe your engine is 2D by default; from script code I see “case 0x2D: return "A6 diesel ?";”, so file needs to be adapted.
WAUZZZ doesn’t affect it, part “FC” is what needs to be replaced by 3F.
Just swap FC Vin2 with 3F and same thing in Vin1 (3F with FC) recalculate chksum and it should be ok.

@erchouiIn einem früheren Beitrag sagte er, es sei 159.
Die ODIS-Nachricht sagt alles, gehen Sie zur Verwaltung und ändern Sie die erwarteten Identitäten.
Dann können Sie jede Dateiversion flashen.
But as @erchoui said beware of unit version 159 or 160.

so it seems to work with your dataset. However, the noise is very quiet and almost inaudible.

@OzeanOfDreams do we need some more coding for A6 4G as only to add A9 in installation list in 19?  Did you something more ? In 5F maybe?

From whole range of engines, yours should be the one which has support, since it is 3.0L.
I forgot that it is 4G, so I told you to change to FC, sorry!
It has nothing with power class.
As you mentioned, on my A4 8K I had to do changes in coding as described in link; maybe it can help you.
Than try with unlocked file (you said no errors, etc.) and if it work - great!
If not, I have one more idea what you can try to do, then we will try with that.
Link:
https://www.a5oc.com/threads/drive-select-engine-sound-option.65705/

From whole range of engines, yours should be the one which has support, since it is 3.0L. I forgot that it is 4G, so I told you to change to FC, sorry! It has nothing with power class. As you mentioned, on my A4 8K I had to do changes in coding as described in link; maybe it can help you. Than try with unlocked file (you said no errors, etc.) and if it work - great! If not, I have one more idea what you can try to do, then we will try with that.
Link: https://www.a5oc.com/threads/drive-select-engine-sound-option.65705/

Installed and wired as needed, i hope :). I have Elsa and a loot of experience in retrofitting.  C0 ( Active Sound exhaust system) works, Audi drive select i working too.
Flashed A9 now with FL_4G0907159B__0010_UNLOCKED.odx but without success, I'm looking forward to your idea :)

In unlocked file change following:
2D ??????FC????????? -> 0C ??????FC?????????
As it seems to me, your engine could really be 2D code, so maybe it interferes with locked part - 2D …FC…
I hope you understand what I am trying to say.
If you don’t like 0C you may use any other engine code except 2D and 3F.
Hope this will help you!

Why 0C?  You are writing "any other engine codes". Is there info about available engine codes?? Can I read about it somewhere?

You didn’t do your homework 😉
Inside template code, all known engine codes are written.
For example 0C, it represents some 2.0Tdi engine…
This week I don’t have time to help you make file, but next week I can do it if you don’t know how to.

Here you go!
FL_4G0907159B__0002 - D001.zip

Sorry for late reply, I was on vacation this days... Sadly, it doesn't work, no sound when accelerating, and at ilde is very very low volume... you have to touch the sound actuator to check if it's vibrating or not... it's a shame... I can't get it working well... Sound exhaust works like a charm...
If anyone has any idea or can contact me by private to teach me a little how to use template on 010 editor, will try to test some things without annoying others...
thanks!!!!
PS.
Is there any way to make louder sound using original exhaust sound generator withou using for example, kufatec's sound booster pro?
Thanks!!!!

You didn’t do your homework 😉 Inside template code, all known engine codes are written. For example 0C, it represents some 2.0Tdi engine… This week I don’t have time to help you make file, but next week I can do it if you don’t know how to.

OMG, Thank you bro, will do my homework )

Here you go!
FL_4G0907159B__0002 - D001.zip

Sorry for late reply, I was on vacation this days... Sadly, it doesn't work, no sound when accelerating, and at ilde is very very low volume... you have to touch the sound actuator to check if it's vibrating or not... it's a shame... I can't get it working well... Sound exhaust works like a charm...
If anyone has any idea or can contact me by private to teach me a little how to use template on 010 editor, will try to test some things without annoying others...
thanks!!!!
PS. Is there any way to make louder sound using original exhaust sound generator withou using for example, kufatec's sound booster pro?
Thanks!!!!

Same here, and if you ask for help, please answer how to reach you )

You didn’t do your homework 😉 Inside template code, all known engine codes are written. For example 0C, it represents some 2.0Tdi engine… This week I don’t have time to help you make file, but next week I can do it if you don’t know how to.

Okay... It is not a problem of engine/VIN filter, it is a problem of 4G0907159B firmware which was made for gasoline engines, not for diesels! Firmware for diesel are 4G0907159A and 4G0907159D.
4G0907159B does, but vеry, very quietly.  To "hear" the work you need to remove the Sound-Actuator, take it in your hands, only then you can feel its vibration.

Here you go!
FL_4G0907159B__0002 - D001.zip

Sorry for late reply, I was on vacation this days... Sadly, it doesn't work, no sound when accelerating, and at ilde is very very low volume... you have to touch the sound actuator to check if it's vibrating or not... it's a shame... I can't get it working well... Sound exhaust works like a charm...
If anyone has any idea or can contact me by private to teach me a little how to use template on 010 editor, will try to test some things without annoying others...
thanks!!!!
PS. Is there any way to make louder sound using original exhaust sound generator withou using for example, kufatec's sound booster pro?
Thanks!!!!

Same here, and if you ask for help, please answer how to reach you )

You didn’t do your homework 😉 Inside template code, all known engine codes are written. For example 0C, it represents some 2.0Tdi engine… This week I don’t have time to help you make file, but next week I can do it if you don’t know how to.

Okay... It is not a problem of engine/VIN filter, it is a problem of 4G0907159B firmware which was made for gasoline engines, not for diesels! Firmware for diesel are 4G0907159A and 4G0907159D.
4G0907159B does, but vеry, very quietly. To "hear" the work you need to remove the Sound-Actuator, take it in your hands, only then you can feel its vibration.

Hi!!!! Chuck2k, I don't have telegram, but I can tell you my car is PETROL (CYPA, 2.0tfsi) and 4g0907159b firmware if it's for petrol engines, in my car has same problem than in other cars... if anyone find solution...

Here you go!
FL_4G0907159B__0002 - D001.zip

Sorry for late reply, I was on vacation this days... Sadly, it doesn't work, no sound when accelerating, and at ilde is very very low volume... you have to touch the sound actuator to check if it's vibrating or not... it's a shame... I can't get it working well... Sound exhaust works like a charm...
If anyone has any idea or can contact me by private to teach me a little how to use template on 010 editor, will try to test some things without annoying others...
thanks!!!!
PS. Is there any way to make louder sound using original exhaust sound generator withou using for example, kufatec's sound booster pro?
Thanks!!!!

Same here, and if you ask for help, please answer how to reach you )

You didn’t do your homework 😉 Inside template code, all known engine codes are written. For example 0C, it represents some 2.0Tdi engine… This week I don’t have time to help you make file, but next week I can do it if you don’t know how to.

Okay... It is not a problem of engine/VIN filter, it is a problem of 4G0907159B firmware which was made for gasoline engines, not for diesels! Firmware for diesel are 4G0907159A and 4G0907159D.
4G0907159B does, but vеry, very quietly. To "hear" the work you need to remove the Sound-Actuator, take it in your hands, only then you can feel its vibration.

Hi!!!! @chuck2k , I don't have telegram, but I can tell you my car is PETROL (CYPA, 2.0tfsi) and 4g0907159b firmware if it's for petrol engines, in my car has same problem than in other cars... if anyone find solution...

Okay, than it is not only diesel problem...

Anybody successfully done something? I’m going to read an sound actor processor only for research…

Guys, new to Github here and have the same issue with Soundaktor not working on my 2017 Audi A5 since I got it a few months ago.
In VCDS, volume is set to 100% and the output test produces sound, but I get nothing at all when in any mode including dynamic, even when kicking down on the pedal on sports mode.
Can somebody do an idiots guide to getting this working? Something like: Buy OBD to usb cable, Go to ’x’ page, download ’x’ firmware, download ‘x’ app to send the firmware to the Soundaktor, what state the car should be in, ie ignition on. That would be much appreciated. Thanks!

hi, does anyone have a modified sound for golf7 gtd, louder

authors: FPSUsername OzeanOfDreams Pesroozza chuck2k erchoui jilleb rynoc1 vexovex

repo: jilleb/mqb-soundaktor


text:
Another grab bag

fixes #14 (stops using imagestreams for infra components)
makes a configurable for every image and sets imagePullPolicy: Always across the board
starts a stub for setting config based on the requested openshift version
starts work on waiting for deployments after helm upgrade (but may be buggy)

@pweil- @mjudeikis @kargakis ptal

/lgtm
Follow-up issue to invalidate patch versions in Manifest or it's still
undecided?
On Fri, Jul 6, 2018, 05:00 Jim Minter notifications@github.com wrote:

@pweil- https://github.com/pweil- @mjudeikis
https://github.com/mjudeikis @kargakis https://github.com/kargakis
ptal
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/jim-minter/azure-helm/pull/59#issuecomment-402911407,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADuFfzLXCFelzfyV_8_I7NOZd7Ob-xhIks5uDtLKgaJpZM4VEz6x
.

Follow-up issue to invalidate patch versions in Manifest or it's still undecided?

Will be in #60.

authors: jim-minter kargakis

repo: jim-minter/azure-helm


text:
🛑 GitHub Issues App is down

In cf9eece, GitHub Issues App (https://github-issues.jimbrig.com) was down:

HTTP code: 404
Response time: 127 ms

Resolved: GitHub Issues App is back up in 083e233 after 9 minutes.

repo: jimbrig/upptime


text:
Syntax colors with Monokai, please

Describe the bug
Syntax colors with Monokai theme isn't as expressive and clear as with Darcula scheme.
Expected behavior
It would be amazing to have different colors to increase readability also with Monokai.
Screenshots

Version and Environment Details
Operation system: Windows 10
IDE name and version: Goland 2020.1.3
Plugin version: 2.5.0

Hi,
Thanks for using the plugin.
The syntax highlighting relies on the default language colors shown on the right here to work best across the different IDEs:

The API itself for picking the colors is quite simple, and it's my understanding that it can't target specific themes. As such I don't see this as actionable from my side.
You'll need to set those language defaults within the Monkai theme, or override them specifically in the GraphQL settings.
Best regards
Jim

So, I don't understand, whose fault is it?

It's not really a fault, more a set of limitations in the API, combined with the complexity of supporting different IDEs that support different programming languages. This means that for this plugin, the colors that make sense from a syntax highlighting perspective are the ones coming from the "Default Language" set:
https://github.com/jimkyndemeyer/js-graphql-intellij-plugin/blob/d83dad8bc30b528b6cc9928408ea7e77df6b16bb/src/main/com/intellij/lang/jsgraphql/ide/GraphQLSyntaxHighlighter.java#L27-L55
Different themes will use these colors default differently, some may even ignore them completely to provide their own. My point is that even though I would like the colors to make sense for all themes, I don't see how to achieve this with the IntelliJ Platform API for syntax highlighting.
If you're not happy with the GraphQL colors as they appear with the Monokai theme, you'll need to either tweak the "Default Language" colors within the Monkai theme, or override them specifically in the GraphQL color settings.

I opened this: https://youtrack.jetbrains.com/issue/GO-9528.

Thanks for your commitment.

There is an answer here, @jimkyndemeyer: https://youtrack.jetbrains.com/issue/GO-9528#focus=streamItem-27-4210084.0-0,

Is there a way I can change editor schema only for GraphQL, @jimkyndemeyer?
Can you please see that thread with the answer for you, @jimkyndemeyer? (https://youtrack.jetbrains.com/issue/GO-9528#focus=streamItem-27-4210084.0-0)

@vepanimas shoud I change them manually? One by one?
Can we copy Monokai colors for Graphql from somewhere and create a PR?

I looked at the implementation of highlighting and I have a few thoughts on this, I will look at it later, perhaps in the next release.

@frederikhors what monokai theme do you use exactly? There are many of them in the marketplace.

The default one.

So, I've finally done it. Will be available in the next release.
Before:

After:

authors: frederikhors jimkyndemeyer vepanimas


text:
Link missing in README.md

Details:
In Document section. Links Github  and ReadTheDocs are missing.
Please add correct and related links for community users, thanks!

Hi, Github and ReadTheDocs are just placeholder parts so there will be no links there, we will remove them, thanks for reporting, and sorry for the confusion.

Hi, Github and ReadTheDocs are just placeholder parts so there will be no links there, we will remove them, thanks for reporting, and sorry for the confusion.

Thanks for the reply, hope more docs (except those in the docs store) can be publicly shown for dev contributors!

authors: jemmyshin matchyc

repo: jina-ai/annlite


text:
fix: YAML flow parser

create new flow from imported YAML
support both legacy and v1 Jina YAML syntax
test yaml parsing and formatting

Ooh, I like that all green in code coverage comment. :heart:
Could you merge master onto your branch. Let's see if that fixes failing integration tests.

authors: Roshanjossey imsergiy

repo: jina-ai/dashboard