text:
Dependencies is missing

after the version update the dependencies disappeared and broke the whole project

To sync dependency management in camel runtimes, now they are in application.properties
How to generate default application.properties

But what do I do with the resources I'm using in the route without the dependencies tab

you can add your dependencies in application.properties file in camel.jbang.dependencies line

in this case I will add mvn:classpath:RemoveSoapEnv.xslt for example?

I think that dependencies should be java libs in maven repository
For classpath resources you should use camel.jbang.classpathFiles property

So I tried to do as you said, but I still have the dependency error, do you have example?

@davsclaus what is correct properties for the files in classpath fro camel-jbang?

If the xslt files are local, then they should likely be using file:xxx instead of classpath:xxx or even without any scheme, eg just xxx.

However I think Karavan should have a nice UI for configuring dependencies (a bit like we had before) but then it stores it automatic in that properties file for you.

I've already tried to put only the path or just the name of the file and even then it doesn't recognize it, before with the dependency tab it worked just fine

@MorganaPrado what is your runtime: camel-jbang, quarkus, camel-k? version?

authors: MorganaPrado davsclaus mgubaidullin

repo: apache/camel-karavan


text:
Upgrade Localstack container image to version 3.3.0

Description

Target

[x] I checked that the commit is targeting the correct branch (note that Camel 3 uses camel-3.x, whereas Camel 4 uses the main branch)

Tracking

[ ] If this is a large change, bug fix, or code improvement, I checked there is a JIRA issue filed for the change (usually before you start working on it).

Apache Camel coding standards and style

[x] I checked that each commit in the pull request has a meaningful subject line and body.

[x] I have run mvn clean install -DskipTests locally and I have committed all auto-generated changes

/component-test aws

source: gharchive/pull-request

repo: apache/camel

license_type: permissive

license_source: github-api


text:
fix CAMEL-12787 Accept header is not respected anymore in CXFRS consu…

…mer when POST

I'm merging this.

Merged on master, 2.22.x and 2.21.x

authors: oscerd xldai


text:
[LOG] Optimize the logs of CarbonProperties that only one """ and close  "is"

[Problem]
2019-02-09 16:51:08 WARN  CarbonProperties:465 - The enable unsafe sort value "null" is invalid. Using the default value "true
2019-02-09 16:51:08 WARN  CarbonProperties:477 - The enable off heap sort value "null" is invalid. Using the default value "true
2019-02-09 16:51:08 WARN  CarbonProperties:438 - The custom block distribution value "null" is invalid. Using the default value "false
2019-02-09 16:51:08 WARN  CarbonProperties:425 - The enable vector reader value "null" is invalid. Using the default value "true
2019-02-09 16:51:09 WARN  CarbonProperties:453 - The carbon task distribution value "null" is invalid. Using the default value "block
2019-02-09 16:51:09 WARN  CarbonProperties:556 - The enable auto handoff value "null" is invalid. Using the default value "true
2019-02-09 16:51:09 WARN  CarbonProperties:1298 - The specified value for property 512is invalid.
2019-02-09 16:51:09 WARN  CarbonProperties:1309 - The specified value for property carbon.sort.storage.inmemory.size.inmbis invalid. Taking the default value.512
[Solution]
2019-02-09 17:12:44 WARN  CarbonProperties:465 - The enable unsafe sort value "null" is invalid. Using the default value "true"
2019-02-09 17:12:44 WARN  CarbonProperties:477 - The enable off heap sort value "null" is invalid. Using the default value "true"
2019-02-09 17:12:44 WARN  CarbonProperties:438 - The custom block distribution value "null" is invalid. Using the default value "false"
2019-02-09 17:12:44 WARN  CarbonProperties:425 - The enable vector reader value "null" is invalid. Using the default value "true"
2019-02-09 17:12:44 WARN  CarbonProperties:453 - The carbon task distribution value "null" is invalid. Using the default value "block"
2019-02-09 17:12:44 WARN  CarbonProperties:556 - The enable auto handoff value "null" is invalid. Using the default value "true"
2019-02-09 17:12:44 WARN  CarbonProperties:1298 - The specified value for property 512 is invalid.
2019-02-09 17:12:44 WARN  CarbonProperties:1309 - The specified value for property carbon.sort.storage.inmemory.size.inmb is invalid. Taking the default value.512
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:

[ ] Any interfaces changed?

[ ] Any backward compatibility impacted?

[ ] Document update required?

[ ] Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance test report.
- Any additional information to help reviewers in testing this change.

[ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/2558/

Build Success with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/10817/

Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/2788/

why not use stringformat for better reading?

@xuchuanyin  because the origin code didn't use String.format.
Now i optimize this, please review and merge, thank you

why not use stringformat for better reading?

@xuchuanyin because the origin code didn't use String.format.
Now i optimize this, please review and merge, thank you

Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/2570/

Build Success with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/10829/

Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/2800/

LGTM
If the performance is not very important(for example: in exception catch branch), I agree to use String.format also.

@QiangCai  i have replaced with String.format as xuchuanyin said

authors: CarbonDataQA QiangCai qiuchenjian xuchuanyin

repo: apache/carbondata


text:
[CARBONDATA-3357] Support TableProperties from single parent table and restrict alter/delete/partition on mv

This PR is depend on PR-3179

Inherit Table Properties from main table to mv datamap table, if datamap has single parent table, else use
default table properties.
Restrict Alter/Delete/Partition operations on MV

[ ] Any interfaces changed?

[ ] Any backward compatibility impacted?

[ ] Document update required?

[ ] Testing done

[ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/2952/

Build Failed  with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/11214/

Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/3184/

Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/2956/

Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/3188/

Build Failed  with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/11218/

Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/2962/

Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/3193/

Build Success with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/11223/

Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/2985/

Build Failed  with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/11249/

Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/3219/

Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/2986/

Build Success with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/11250/

Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/3220/

Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/3009/

Build Success with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/11273/

Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/3025/

Build Success with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/11289/

@ravipesala handled comments. PLease review

Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/3042/

Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/3044/

Build Success with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/11309/

Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/3243/

Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/3052/

Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/3251/

Build Success with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/11316/

Build Failed  with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/11343/

Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/3079/

Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/3278/

Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/3080/

Build Failed  with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/11344/

Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/3081/

Build Success with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/11345/

Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/3280/

Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/3091/

Build Failed  with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/11355/

Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/3093/

Build Success with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/11357/

Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/3293/

Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/3097/

Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/3296/

Build Failed  with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/11361/

Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/3098/

Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/3297/

Build Success with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/11362/

Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/3104/

Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/3303/

Build Success with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/11368/

Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/3110/

Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/3309/

Build Success with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/11374/

Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/3115/

Build Success with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/11379/

Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/3314/

retest this please

Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/3121/

Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/3320/

Build Failed  with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/11385/

Retest this please

Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/3123/

Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/3323/

Build Success with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/11388/

Build Failed  with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/11394/

Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/3129/

Retest this please

Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/3131/

Build Success with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/11396/

Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/3330/

Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/3140/

Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/3339/

Build Success with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/11405/

Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/3147/

Build Failed  with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/11412/

Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/3346/

Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/3148/

Build Failed  with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/11413/

Retest this please

Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/3347/

Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/3150/

Build Success with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/11415/

Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/3151/

Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/3349/

Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/3350/

Build Failed  with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/11416/

Retest this please

Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/3152/

LGTM

Build Success with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/11417/

Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/3351/

Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/3156/

Build Success with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/11421/

Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/3158/

Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/3357/

Build Failed  with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/11423/

Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/3163/

Build Success with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/11428/

Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/3361/

Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/3166/

Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/3364/

Build Success with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/11431/

Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/3250/

Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/3450/

Build Failed  with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/11518/

Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/3256/

Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/3457/

Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/3261/

Build Failed  with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/11525/

Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/3265/

Build Failed  with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/11529/

retest this please

Build Success with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/11537/

Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/3277/

Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/3482/

Build Failed  with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/11548/

retest this please

Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/3284/

Build Failed  with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/11556/

Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/3291/

Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/3494/

retest this please

Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/3299/

Build Success with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/11566/

Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/3502/

@Indhumathi27 PLease rebase

Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/3323/

Build Success with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/11589/

Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/3524/

LGTM

authors: CarbonDataQA Indhumathi27 ravipesala


text:
CASSANDRA-19612 Make sure IntersectFilteringQueryTest#shouldNotWarnOrFailOnIndexQuery waits for indexes to be available before making queries

patch by Caleb Rackliffe; reviewed by Stefan Miklosovic for CASSANDRA-19612

Committed as https://github.com/apache/cassandra/commit/1d04457a2414c5b631e84f2dc198842eefbd90c9

repo: apache/cassandra


text:
Maintenance

Hello!
Is this project still maintened?

@iamcryptoki , i think there is still interest but i have no idea who the leading developers are.this was migrated from kuvbernetes to the cloudstack project to prevent it from being deleted completely. Are you volunteering?

Thank you for your reply!
Not at the moment but I would be more than happy to volunteer in the very near future if the project is no longer maintained.

@iamcryptoki any help and volunteering is welcome!

@iamcryptoki Thanks for the offer!
The project is very much alive, but still needs some love from a few sides.
If you have any issues, input or pull requests, please post them on the Github tracker.
And if you want to try the provider for yourself, you can always build it locally.
I recommend merging #8 , #10 , #11 and #9 as they contain various fixes and the IP whitelisting feature that I just finished. Any feedback on #9 is highly appreciated.

@iamcryptoki You can also take a look at https://hub.docker.com/repository/docker/swisstxt/cloudstack-kubernetes-provider - I'm occasionally pushing development versions there.

Release management and CI is being addressed in #7  and #16 .
We have access to Dockerhub now, and containers will be pushed there.
Please stay tuned for the v1.0 release.

Closing this, @iamcryptoki pl follow #7 and #16  and wait for v1.0 something soon (in coming weeks/months).

source: gharchive/issue

authors: DaanHoogland iamcryptoki onitake rhtyd

repo: apache/cloudstack-kubernetes-provider


text:
”cpu.overprovisioning.factor“ Configuration not in effect

ISSUE TYPE

Bug Report

COMPONENT NAME
 cloudstack-managemnt server

CLOUDSTACK VERSION

4.15.1-SNAPSHOT

STEPS TO REPRODUCE

change `cpu.overprovisioning.factor ` value to 2，But it doesn't work

EXPECTED RESULTS

cpu.overprovisioning.factor  can be configured correctly

ACTUAL RESULTS

it doesn't work correctly.

@staySober, I've tested this, and cpu.overprovisioning.factor is set correctly. This is just a warning that the configuration wasn't found in Config.java because it's deprecated and most of the configurations are moved to ConfigDepot. If it wasn't in ConfigDepot you will get something like this Did not find configuration cpu.overprovisioning.factor in ConfigDepot too.
I've changed the value to 2 and created a new cluster that takes the new value

or you mean about something else

@slavkap  but when I deploy a VM, I saw the log as follow

I think it's mean My cpu.overprovisioning.factor is value '1', but I set it value to 2

Hmm not sure what steps you've taken. To take effect on old hosts, you have to update the cpu.overprovisioning.factor in the cluster's settings. If you changed it from the Global Settings tab, it will take effect only on newly created clusters (maybe I'm wrong, but I came to this conclusion after a quick check of the code )

@slavkap Oh, My problem. I forget check the cluster setting. now It work correctly. Thanks for your help me.

authors: slavkap staySober

repo: apache/cloudstack


text:
Adding cloudstack repository fails under Rocky Linux 8.5

ISSUE TYPE

Bug Report

COMPONENT NAME

Centos 8 Repo
CLOUDSTACK VERSION

4.16
CONFIGURATION

OS / ENVIRONMENT

Rocky Linux 8.5
SUMMARY

Following the documentation to add the cloudstack-epo fails:
Failed to download metadata for repo 'cloudstack': Checksum mismatch /var/cache/dnf/cloudstack-972dd32202bee359/repodata/e9d29c06626056b2e09e7712d6477873a470cf1abb59646e90805b2a3bc64a67-filelists.xml.gz
STEPS TO REPRODUCE

dnf update

EXPECTED RESULTS

adding repo
[cloudstack]
name=cloudstack
baseurl=http://download.cloudstack.org/centos/$releasever/4.16/
enabled=1
gpgcheck=0
should work
ACTUAL RESULTS

Failed to download metadata for repo 'cloudstack': Checksum mismatch /var/cache/dnf/cloudstack-972dd32202bee359/repodata/e9d29c06626056b2e09e7712d6477873a470cf1abb59646e90805b2a3bc64a67-filelists.xml.gz

@ukedk Thanks for reporting the issue. The repodata was out of sync and it's been fixed
Can you try clearing the cache and trying again ?

Closing the issue as per @davidjumani's comment - if the issue persists please reopen it @ukedk

authors: davidjumani nvazquez ukedk


text:
vpc/server: Fix network statistics for vpc

Description

This contains 3 main changes
(1) add NETWORK_STATS_ethX for all nics with public ips in VPC VRs (current: NETWORK_STATS_eth1)
(2) DO NOT create records in user_statistics for each VPC tier (only one record per public nic per VPC VR)
(3) send NetworkUsageCommand before unplugging a NIC with public IPs from VPC VR

Types of changes

[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] New feature (non-breaking change which adds functionality)
[X] Bug fix (non-breaking change which fixes an issue)
[ ] Enhancement (improves an existing feature and functionality)
[ ] Cleanup (Code refactoring and cleanup, that may add test cases)

Screenshots (if appropriate):
How Has This Been Tested?

Is this in progress or ready for review @ustcweizhou ?

Is this in progress or ready for review @ustcweizhou ?

@rhtyd it is ready for review
travis failed, I will check it.

Is this in progress or ready for review @ustcweizhou ?

@rhtyd it is ready for review
travis failed, I will check it.

don't bother @weizhouapache those seem to be the usual log too long errors. Travis stops at 4GB or so.

Is this in progress or ready for review @ustcweizhou ?

@rhtyd it is ready for review
travis failed, I will check it.

don't bother @weizhouapache those seem to be the usual log too long errors. Travis stops at 4GB or so.

thanks @DaanHoogland for your info.

@blueorangutan package

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Packaging result: ✔centos7 ✔debian. JID-1356

@blueorangutan package

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Packaging result: ✖centos7 ✖debian. JID-1368

@blueorangutan package

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Packaging result: ✔centos7 ✔debian. JID-1508

@blueorangutan test

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan test

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

Trillian test result (tid-1976)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 49953 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3944-t1976-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_supported_versions.py
Intermittent failure detected: /marvin/tests/smoke/test_router_dhcphosts.py
Smoke tests completed. 82 look OK, 1 have error(s)
Only failed tests results shown below:

Test
Result
Time (s)
Test File

test_01_add_delete_kubernetes_supported_version
Error
1807.31
test_kubernetes_supported_versions.py

@weizhouapache @ustcweizhou can you start a discussion thread on dev ML? This needs some discussion before we can consider merging this.

@weizhouapache converted to draft so it is clear 4.15 is not waiting for it. please change back if you disagree

@ustcweizhou @weizhouapache can you comment/explore the cases where this could add regression for usage/billing?

@DaanHoogland @rhtyd
this fixes bugs in network statistics for vpc.
cloudstack should collect network statistics from the public interfaces, not from eth1 which is default public nic for vpc but there might be more public nics, not from vpc tiers.
in a word, there is not per tier billing. there are only statistics for all public interfaces in VR for isolated network and vpc, and for all nics on shared network.

@weizhouapache the changes seem logical to me and given your description above seem to do what you intended, but we have no testdescription and no integration tests to guarantee against regressions. I'm a bit reluctant to include this just before release. can we with just the current set of smoke tests? cc @rhtyd @sureshanaparti are there any others we could ask for testing this functionality?

@weizhouapache the changes seem logical to me and given your description above seem to do what you intended, but we have no testdescription and no integration tests to guarantee against regressions. I'm a bit reluctant to include this just before release. can we with just the current set of smoke tests? cc @rhtyd @sureshanaparti are there any others we could ask for testing this functionality?

@DaanHoogland let's move this to 4.15.1.0 (and 4.14.1.0)

@weizhouapache conflicts here

@blueorangutan package

@shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Packaging result: ✖centos7 ✖centos8 ✖debian. JID-2792

Packaging result: ✖centos7 ✖centos8 ✖debian. JID-2796

Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2798

@blueorangutan test

@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

Trillian test result (tid-3601)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 31877 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3944-t3601-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py
Smoke tests completed. 86 look OK, 0 have error(s)
Only failed tests results shown below:

Test
Result
Time (s)
Test File

@rhtyd @weizhouapache no discussion has happened, do we dare merge this?

@rhtyd @weizhouapache no discussion has happened, do we dare merge this?

@DaanHoogland @rhtyd
it is ok for me to merge it :-D
we have this patch on our productions. looks good until now.

authors: DaanHoogland blueorangutan rhtyd shwstppr ustcweizhou weizhouapache


text:
load (domains) continuously in dropdown boxes

Description
This PR attempts to load items (PoC for domains on the network creation tab) in case there is more to load than the default 500 maximum.
This should be generalised to a mechanism that applies to any dropdown UI item, but is now only for a particular instance.

Fixes: #7780

Types of changes

[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] New feature (non-breaking change which adds functionality)
[ ] Bug fix (non-breaking change which fixes an issue)
[ ] Enhancement (improves an existing feature and functionality)
[ ] Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale

[ ] Major
[ ] Minor

Bug Severity

[ ] BLOCKER
[ ] Critical
[ ] Major
[ ] Minor
[ ] Trivial

Screenshots (if appropriate):
How Has This Been Tested?

create loads of domains 26*((26*3)+26)+1 and in the network create dialog add one by typing a partial name that is beyond the 500 mark. I create domains a-z with subdomain a through z  and sub-sub-domain 1st, 2nd and 3rd
What is still missing is searching for the last 3rd for instance. There are 26*26 (676) domains named 3rd, and if I want to select the last one. A thing that may also be missing in the domain overview search and in the results of #7766 , this does address the comment in https://github.com/apache/cloudstack/pull/7766#pullrequestreview-1549019223 but as said, not in a generic way (yet)

@kiranchavala can you review?

@blueorangutan package

@DaanHoogland a [SF] Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 7068

Packaging result [LL]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 6178

@kiranchavala can you test this?

Code LGTM but maybe we can create a new element which allows continuous loading for a given API and can be reused across different forms

that was my thought as well, but this is a larger job as there can be different parameters required and also different indices/display fields. This is a quick fix on request. A more generic solution is desirable, i agree. I sugest we merge (if ok'd) and create a ticket for an improvement, @shwstppr .

Code LGTM but maybe we can create a new element which allows continuous loading for a given API and can be reused across different forms

that was my thought as well, but this is a larger job as there can be different parameters required and also different indices/display fields. This is a quick fix on request. A more generic solution is desirable, i agree. I sugest we merge (if ok'd) and create a ticket for an improvement, @shwstppr .

We should merge if no further testing/review needed

authors: DaanHoogland blueorangutan shwstppr


text:
fix javadocs and typos.

as title.

Merged in commit 6bba60a617c720753021b25a53db6925bfe05189

repo: apache/commons-geometry

license_source: bigquery


text:
Fix MC_OVERRIDABLE_METHOD_CALL_IN_READ_OBJECT in EventListenerSupport class

This pull request addresses the issue identified by SpotBugs: MC_OVERRIDABLE_METHOD_CALL_IN_READ_OBJECT in the readObject method of the EventListenerSupport class. The bug relates to the use of the potentially overridable method Thread.currentThread().getContextClassLoader() during deserialization, which could lead to unexpected behavior or security risks in certain contexts.
Changes Made

Introduced a static constant DEFAULT_CLASS_LOADER:

The ClassLoader is captured at class initialization and stored in a static constant.
This ensures a consistent and safe ClassLoader is used throughout the deserialization process.

Replaced the call to Thread.currentThread().getContextClassLoader:

The call inside the readObject method was replaced with the DEFAULT_CLASS_LOADER constant.
This eliminates the risk of calling a potentially overridden method during deserialization.

Added explanatory comments:

Detailed comments were added to clarify the purpose of the changes and the reasoning behind the new approach.

Advantages

Improved Safety: The readObject method no longer relies on a method that could be overridden, reducing the likelihood of unexpected behavior during deserialization.
Consistency: By capturing the ClassLoader at initialization, the deserialization process becomes more predictable and less dependent on runtime thread states.
Compliance with Best Practices: The changes align the code with best practices for deserialization, particularly avoiding non-final or overridable methods during critical operations.

Conclusion
This fix ensures the EventListenerSupport class is more robust, secure, and reliable during deserialization while maintaining its original functionality. These changes also resolve the SpotBugs warning without introducing breaking changes to the codebase.

Please ignore the commit - Fix string comparisons and handle null values safely

Hello @GracieleRodrigues-dev
One cannot "ignore" a commit in a PR, it's all or nothing. You need to update the PR.

authors: GracieleRodrigues-dev garydgregory

repo: apache/commons-lang


text:
Remove deprecated platforms from plugin page

Platforms affected
None
What does this PR do?
Update plugin list page to remove deprecated platforms.
This PR replaces PR #824. I some how lost PR #824's branch.
What testing has been done on this change?
Manual Testing
Checklist

[ ] Reported an issue in the JIRA database
[ ] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
[ ] Added automated test coverage as appropriate for this change.

I've tried to make this a bit more straightforward. Did not test since I've never built the docs before. Might be a matter of taste. Would approve the original PR too :+1:

@raphinesse I updated the proposal. I added the platform keyword to the sortedPlatforms collection.
Example:  {keyword: 'cordova-android', icon: 'android', alt: 'Android'},
The proposed filter .filter(platform => keywords.has(platform)) did not work because the keywords are not identical to platform.
The keywords contains a collection of keywords taken from the npm package.json.
For example cordova-plugin-whitelist you can see the list of keywords at the bottom as cordova, whitelist, ecosystem:cordova, cordova-android
filter was updated as so: .filter(platform => keywords.has(platform.keyword))
With this, the keyword cordova-android will now match platform.keyword cordova-android.

@erisu Of course, stupid bug. Thanks for fixing! And thanks for explaining what's actually happening, too :+1:
I probably would have reduced the sorted record format to {id: 'android', name: 'Android'} and generated keywords on the fly for filtering, but that's nitpicking :sweat_smile:

I was also thinking about generating the keyword on the fly for filtering but just couldn't decide what others would really like ha.

@janpio Let me know if you also have any thoughts, questions, or concerns with this change. At this stage, I think it's good to go unless theres more feedback.

authors: erisu raphinesse

repo: apache/cordova-docs


text:
CB-8115 incorrect birthday saved to phonebook using Contacts Plugin

Converting birthday stored as string internally to Date to align with the plugin API.
Added a corresponding test for find method.
Jira issue

@alsorokin, we can add an Appium test to also verify birthday field type for pickContact method.

repo: apache/cordova-plugin-contacts


text:
Create file error code 9

Hello there,
What is expected to happen?
Create a file if not exists... dir.getFIle("test",{"create":true,"exclusive":false}  )
What does actually happen?
dir.getFIle("test",{"create":true,"exclusive":false}  ) result on {"code":9} so not created ?
dir.getFIle("test",{}  ) result on {"code":1} ==> normal

I don't understand the goal of { create exclsuive...}, why it's not working like nodejs ?
Version information
Cordova android@10.0.1
cordova-plugin-file 7.0.0 "File"
Android 12 on my device.

See https://github.com/apache/cordova-plugin-file/issues/527#issuecomment-1402873214

authors: breautek ptorrent

repo: apache/cordova-plugin-file


text:
setting a different direction indexes is impossible

CouchDB with Hyperledger fabric seems not support setting a index with multiple fields with different directions.
Expected Behavior

I think CouchDB supports multiple directions find and indexing
Current Behavior

I cannot make complex index with two fields, one direction is asc and another is desc.
This is my stackoverflow question
Possible Solution

Steps to Reproduce (for bugs)

Context

I need to complex sorting logic to my hyperledger application to implements different direction sorting supported by other NoSQL like Mongodb.
Your Environment

Version used: 2.1.1
Browser Name and version: Chrome
Operating System and version (desktop or mobile): Hyperledger fabric(1.2) couchDB
Link to your project: n/a

Hi, That's correct, CouchDB indexes only support a single sort order, hence the accurate error message you received.

repo: apache/couchdb


text:
Missing metrics to monitor internal replication status

This is more a general design question than a bug report.
Description
We are running our CouchDB clusters on GKE.
Entire setup is very simple: each cluster has 3 nodes, default sharding settings (q=8,n=3).
To make sure that our clusters are healthy, we monitor:

/_membership data on every node, to verify that every node has connectivity to other nodes.
couchdb_httpd_request_time metric, which contains "length of a request inside CouchDB without MochiWeb", to verify that every node responds in a reasonable time.

We are looking to improve our monitoring solution to cover more failure modes, and have couple of questions:

Is there a way to determine that node is lagging to process writes?
After split brain situations (node lost connectivity to other nodes, but now connectivity is restored and node is syncing data) – is there a way to determine  "replication lag" or, in other words, amount of documents that are left to update?
Does it make sense to monitor if databases contain documents with conflicts after split brain situations?

Thanks!
Your Environment
GKE, CouchDB is installed with Helm using semi-official chart:
https://github.com/gpii-ops/gpii-infra/tree/master/shared/charts/couchdb

CouchDB Version used: 2.3.1
Browser name and version: None
Operating System and version: None, GKE

Hi @natarajaya,
As you said, this is not a CouchDB bug. GitHub is for actual CouchDB bugs only. Unfortunately this means your question got ignored.
If you are looking for general support with using CouchDB, please try one of these other options:

The user mailing list. Signup instructions are here
The Slack/IRC chat room. Joining instructions are here

authors: natarajaya wohali


text:
Support JDK 17 + JAXB reflection at runtime.

Fixes #745.

JDK 17 is detected at build time to enable the jvm flags during tests.
Use the locate-java-home npm module to detect the latest JVM version from within the extension, honoring $JAVA_HOME if set.

Conflicts resolved.  Now they need to be squashed.

@scholarsmate @stricklandrbls There seems to be an issue with clearInterval in this PR, do either of you know why?

@shanedell, there is a type disagreement on the timer.  Wonder why it's affecting this PR and not happening elsewhere?  I'll look more into this Timer.

I think it is from a bad merge with yarn.lock. I'll try to fix.

Not that, but I can fix the typescript types real quick Timer => Timeout.

authors: arosien scholarsmate shanedell

repo: apache/daffodil-vscode


text:
feat: Add support for Int8 and Int16 data types in data page statistics

Which issue does this PR close?

Closes #10928
Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

I also filed https://github.com/apache/datafusion/issues/10951 and https://github.com/apache/datafusion/issues/10952 to add more type support

authors: Weijun-H alamb

repo: apache/datafusion


text:
[Bug] [Master]  Logical task logs are not available because the full log path is not set when the logical task is dispatched.

Search before asking

[X] I had searched in the issues and found no similar issues.

What happened
Logical task logs are not available:

What you expected to happen
I think it is caused by not setting the full log path when deispatch logical tasks.
How to reproduce
Create a logical task, then start it and check the logs.
Anything else
No response
Version
dev
Are you willing to submit PR?

[X] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Closed by #14821

authors: guowei-su ruanwenjun

repo: apache/dolphinscheduler


text:
docker dolphinscheduler-standalone-server remoteshell org.apache.sshd.common.SshException: No more authentication methods available

Search before asking

[X] I had searched in the issues and found no similar issues.

What happened

What you expected to happen

How to reproduce

Anything else
No response
Version
dev
Are you willing to submit PR?

[ ] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

The task was successful, but the log shows a failure

Could you please assign this issue to me?
I want to fix this bug, and the deadline is January 31, 2025.
Thank you.
@SbloodyS

Could you please assign this issue to me?
I want to fix this bug, and the deadline is January 31, 2025.
Thank you.
@SbloodyS

Please take your time. There is no such thing as deadline in the open source community.

The remote shell task was successful, but the log shows a failure

Hi, @FN20200222 .
Could you show me the detailed logs for this particular failure, even when the task finishes successfully?
I was able to reproduce your error logs, but only when I entered an incorrect username and/or password and clicked 'Test Connection'. However, In this case, the task eventually failed.

Could you provide me with a step-by-step guide on how to reproduce this bug?
Or, could you could double-check your username and password input, and test the connection again?

For the Remote SSH task, we need to include a connectivity test in the parameter check.

Currently, the Remote SSH task plugin does not prevent the submission of incorrect parameters when the connection test fails:

authors: FN20200222 Mighten SbloodyS


text:
[DSIP-80][Parameter Parser] Improvement the parameter parser

Search before asking

[X] I had searched in the DSIP and found no similar DSIP.

Motivation
Now we support 2 kinds of parameter definition.

System variable
use ${}
Time related variable
use $[], and in this variable we also support data calculate, like $[add_months(yyyyMMdd,N)]

But now we can't support the case that we need concat a fixed value with a dynamic value.
like  /tmp/${system.workflow.instance.id}
Do we need improve the parser to support more flexible definition.
like /tmp/$[yyyy-MM-dd]/${system.workflow.instance.id}
Design Detail

refactor the current class, make each class's function clear
create 3 parser implemention

InnerSystemParser  find the ${} variable, and replace with parameterMap's value
TimeParser    find the $[] variable, calculate and replace time related placeholder
StringParser   find the $<> variable, and for loop to find other placeholder,  ${}, $[]. replace the response with placeholder.

Compatibility, Deprecation, and Migration Plan
No response
Test Plan
Create new test and update/check exist test
Code of Conduct

[X] I agree to follow this project's Code of Conduct

cc @ruanwenjun @Radeity @Gallardot @caishunfeng @EricGao888

But now we can't support the case that we need concat a fixed value with a dynamic value.
like /tmp/${system.workflow.instance.id}

I think this is currently supported. Can you give an example?

Sorry, My bad, I try to use ${/tmp/${system.workflow.instance.id}  before, It not work.
When i use /tmp/${system.workflow.instance.id}, it's work

authors: SbloodyS liunaijie


text:
[Fix][python] add import SageMaker task

relate: #10826
Purpose of the pull request

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:

Codecov Report

Merging #11121 (48304f4) into dev (3701a24) will decrease coverage by 0.07%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                dev   #11121      +/-   ##
============================================
- Coverage     40.35%   40.28%   -0.08%
  Complexity     4872     4872
============================================
  Files           950      950
  Lines         37184    37248      +64
  Branches       4078     4082       +4
============================================
- Hits          15005    15004       -1
- Misses        20669    20733      +64
- Partials       1510     1511       +1

Impacted Files
Coverage Δ

...r/plugin/task/sqoop/parameter/SqoopParameters.java
53.33% <0.00%> (-1.34%)
:arrow_down:

...e/dolphinscheduler/remote/NettyRemotingClient.java
52.08% <0.00%> (-0.70%)
:arrow_down:

.../datasource/api/client/CommonDataSourceClient.java
0.00% <0.00%> (ø)

...atasource/api/plugin/DataSourceClientProvider.java
0.00% <0.00%> (ø)

...r/plugin/datasource/hive/HiveDataSourceClient.java
1.92% <0.00%> (+0.58%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us.

@zhongjiajie PTAL

authors: codecov-commenter jieguangzhou


text:
[Feature-11488][Datax]Datax can submit to YARN

https://github.com/apache/dolphinscheduler/issues/11488
Instructions:
Configure the environment variables DATAX_ON_YARN_DEPEND_JAR and DATAX_HDFS_PATH to run DATAX ON YARN
Parameter explanation:
DATAX_ON_YARN_DEPEND_JAR:
https://github.com/duhanmin/datax-on-yarn Compile and package
DATAX_HDFS_PATH:
You need to upload the datax installation package to yarn
example:
#export DATAX_ON_YARN_DEPEND_JAR=${DATAX_ON_YARN_DEPEND_JAR:-/opt/soft/datax/datax-on-yarn-1.0.0.jar}
#DATAX_HDFS_HOME is HDFS path
#export DATAX_HDFS_PATH=${DATAX_HDFS_HOME:-/hdfs/opt/hadoop/datax.tar.gz}

使用方法:
配置环境变量DATAX_ON_YARN_DEPEND_JAR和DATAX_HDFS_PATH就可以运行DATAX ON YARN
参数解释:
DATAX_ON_YARN_DEPEND_JAR:
https://github.com/duhanmin/datax-on-yarn 编译打包
DATAX_HDFS_PATH:
需要将datax安装包上传到yarn
例子:
#export DATAX_ON_YARN_DEPEND_JAR=${DATAX_ON_YARN_DEPEND_JAR:-/opt/soft/datax/datax-on-yarn-1.0.0.jar}
#DATAX_HDFS_HOME is HDFS path
#export DATAX_HDFS_PATH=${DATAX_HDFS_HOME:-/hdfs/opt/hadoop/datax.tar.gz}

Hi @duhanmin , please associate the issue and correct the title.

@duhanmin Hello, thanks for submitting this PR and it's a good feature. I've added some comments and please take a look.

authors: EricGao888 SbloodyS duhanmin


text:
[Improvement] remove log-server and server module

Purpose of the pull request
remove log-server and server module.
Brief change log
move the log-server and server module  class into service module.
Verify this pull request

Manually verified the change by testing locally.

Glad to see this PR.

I would like to change the milestone to 3.1.1

Does it mean I no more need to remove powermock from log-server module? 🤣 :doge:

Thanks all~

authors: EricGao888 caishunfeng ruanwenjun


text:
fix: Remove duplicate "registryClient.close" method calls

Purpose of the pull request
The master server or worker server is started, When the server is shut down,
log error :
org.apache.dolphinscheduler.spi.register.RegistryException: zookeeper remove error
	at org.apache.dolphinscheduler.plugin.registry.zookeeper.ZookeeperRegistry.remove(ZookeeperRegistry.java:202) ~[na:na]
	at org.apache.dolphinscheduler.service.registry.RegistryCenter.remove(RegistryCenter.java:156) ~[classes/:na]
	at org.apache.dolphinscheduler.server.master.registry.MasterRegistryClient.unRegistry(MasterRegistryClient.java:374) ~[classes/:na]
	at org.apache.dolphinscheduler.server.master.registry.MasterRegistryClient.closeRegistry(MasterRegistryClient.java:135) ~[classes/:na]
	at org.apache.dolphinscheduler.server.master.MasterServer.close(MasterServer.java:178) [classes/:na]
	at org.apache.dolphinscheduler.server.master.MasterServer.lambda$run$0(MasterServer.java:145) [classes/:na]
	at java.lang.Thread.run(Thread.java:745) ~[na:1.8.0_112]
Caused by: java.lang.IllegalStateException: Expected state [STARTED] was [STOPPED]
	at org.apache.curator.shaded.com.google.common.base.Preconditions.checkState(Preconditions.java:823) ~[na:na]
	at org.apache.curator.framework.imps.CuratorFrameworkImpl.checkState(CuratorFrameworkImpl.java:432) ~[curator-framework-4.3.0.jar:4.3.0]
	at org.apache.curator.framework.imps.CuratorFrameworkImpl.delete(CuratorFrameworkImpl.java:452) ~[curator-framework-4.3.0.jar:4.3.0]
	at org.apache.dolphinscheduler.plugin.registry.zookeeper.ZookeeperRegistry.remove(ZookeeperRegistry.java:200) ~[na:na]
	... 6 common frames omitted

Reason:
The "registry center close" logic already exists in the master server.
            // close
            this.masterSchedulerService.close();
            this.nettyRemotingServer.close();
            this.masterRegistryClient.closeRegistry();

The "registry center close" logic also exists in the ServerNodeManager class.
    /**
     * destroy
     */
    @PreDestroy
    public void destroy() {
        executorService.shutdownNow();
        registryClient.close();
    }

So, Need to remove "registryClient.close();" in the ServerNodeManager class.
Brief change log
Remove "registryClient.close();" in the ServerNodeManager class.
Verify this pull request

This pull request is already covered by existing tests, such as (please describe tests).

Codecov Report

Merging #5805 (eef198e) into dev (70fef3d) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                dev    #5805      +/-   ##
============================================
- Coverage     45.43%   45.40%   -0.04%
+ Complexity     3695     3692       -3
============================================
  Files           607      607
  Lines         24879    24878       -1
  Branches       2834     2834
============================================
- Hits          11305    11295      -10
- Misses        12486    12496      +10
+ Partials       1088     1087       -1

Impacted Files
Coverage Δ

...uler/server/master/registry/ServerNodeManager.java
7.07% <ø> (+0.06%)
:arrow_up:

...lphinscheduler/rpc/common/AbstractRpcCallBack.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...r/plugin/registry/zookeeper/ZookeeperRegistry.java
38.46% <0.00%> (-5.60%)
:arrow_down:

...er/master/dispatch/host/assign/RandomSelector.java
77.77% <0.00%> (-5.56%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70fef3d...eef198e. Read the comment docs.

authors: codecov-commenter wen-hemin


text:
[Fix-5808][Server]  When we try to transfer data using datax between  different types of data sources, the worker will exit with ClassCastException

Purpose of the pull request
Fix #5808
Close #5808
Brief change log
This problem comes after #5116 , the improvement is great, but the source dataType and target dataType  was't  used correctly.
Verify this pull request
Manually verified the change by testing locally.

cc @ruanwenjun

Codecov Report

Merging #5809 (7a752d3) into dev (16986c3) will decrease coverage by 0.02%.
The diff coverage is 80.00%.

@@             Coverage Diff              @@
##                dev    #5809      +/-   ##
============================================
- Coverage     45.42%   45.39%   -0.03%
+ Complexity     3694     3690       -4
============================================
  Files           607      607
  Lines         24872    24879       +7
  Branches       2834     2833       -1
============================================
- Hits          11299    11295       -4
- Misses        12484    12496      +12
+ Partials       1089     1088       -1

Impacted Files
Coverage Δ

...nscheduler/server/worker/task/datax/DataxTask.java
55.08% <80.00%> (ø)

...he/dolphinscheduler/common/enums/SqoopJobType.java
0.00% <0.00%> (-88.89%)
:arrow_down:

...er/master/dispatch/host/assign/RandomSelector.java
77.77% <0.00%> (-5.56%)
:arrow_down:

...hinscheduler/server/worker/task/http/HttpTask.java
2.58% <0.00%> (-0.05%)
:arrow_down:

...inscheduler/common/task/sqoop/SqoopParameters.java
74.00% <0.00%> (ø)

...pache/dolphinscheduler/common/utils/DateUtils.java
81.75% <0.00%> (+0.69%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16986c3...7a752d3. Read the comment docs.

ping
@CalvinKirs

authors: codecov-commenter kyoty


text:
[Enhancement] Add new builtin function of the first day of month

Search before asking

[X] I had searched in the issues and found no similar issues.

Description
Add a new builtin function named first_month_day, the mechanism of this function is the same as toStartOfMonth in ClickHouse.
Syntax
first_month_day(datetime)
Arguments
datetime — This argument's type could be date, datetime, datev2 or datetimev2
Returned values
This function returns date when argument is date or datetime; returns datev2 when argument is datev2 or datetimev2.
And this function always returns the month first day, so the output day is '01'.
Input ('2021-12-01'), it returns ('2021-12-01'); or  Input ('2021-12-31'), it still returns ('2021-12-01')
Solution
No response
Are you willing to submit PR?

[X] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

MySQL [(none)]> select month_floor('2021-12-22 01:02:03');
+------------------------------------+
| month_floor('2021-12-22 01:02:03') |
+------------------------------------+
| 2021-12-01 00:00:00                |
+------------------------------------+
1 row in set (0.01 sec)
MySQL [(none)]> select date_format(month_floor('2021-12-22 01:02:03'),'yyyy-MM-dd');
+-------------------------------------------------------------+
| date_format(month_floor('2021-12-22 01:02:03'), '%Y-%m-%d') |
+-------------------------------------------------------------+
| 2021-12-01                                                  |
+-------------------------------------------------------------+

repo: apache/doris


text:
[Bug] Binglog同步Canal任务未处理关键字

Search before asking

[X] I had searched in the issues and found no similar issues.

Version
doris-1.2.1-rc01
What's Wrong?
表现: 当源表字段包含关键字(如: group,whitelist), SYNC JOB会报错并暂停任务
分析: 查看fe.log, 可以查看到
2023-03-01 06:57:22,062 WARN (mysql-nio-pool-80|2154) [ConnectProcessor.handleQueryException():353] Process one query failed because.
org.apache.doris.common.AnalysisException: errCode = 2, detailMessage = Syntax error in line 2:
...ame,code,method,url,scope,whitelist,valid,author,creat...
^
Encountered: WHITELIST
Expected: WHITELIST is keyword, maybe WHITELIST
    at org.apache.doris.qe.ConnectProcessor.parse(ConnectProcessor.java:387) ~[doris-fe.jar:1.0-SNAPSHOT]
    at org.apache.doris.qe.ConnectProcessor.handleQuery(ConnectProcessor.java:277) ~[doris-fe.jar:1.0-SNAPSHOT]
    at org.apache.doris.qe.ConnectProcessor.dispatch(ConnectProcessor.java:463) ~[doris-fe.jar:1.0-SNAPSHOT]
    at org.apache.doris.qe.ConnectProcessor.processOnce(ConnectProcessor.java:690) ~[doris-fe.jar:1.0-SNAPSHOT]
    at org.apache.doris.mysql.nio.ReadListener.lambda$handleEvent$0(ReadListener.java:52) ~[doris-fe.jar:1.0-SNAPSHOT]
    at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) ~[?:1.8.0_342]
    at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) ~[?:1.8.0_342]
    at java.lang.Thread.run(Thread.java:750) ~[?:1.8.0_342]

Caused by: org.apache.doris.common.AnalysisException: errCode = 2, detailMessage = Syntax error
at org.apache.doris.analysis.SqlParser.unrecovered_syntax_error(SqlParser.java:2365) ~[doris-fe.jar:1.0-SNAPSHOT]
at java_cup.runtime.lr_parser.parse(lr_parser.java:616) ~[jflex-1.4.3.jar:?]
at org.apache.doris.common.util.SqlParserUtils.getMultiStmts(SqlParserUtils.java:60) ~[doris-fe.jar:1.0-SNAPSHOT]
at org.apache.doris.qe.ConnectProcessor.parse(ConnectProcessor.java:378) ~[doris-fe.jar:1.0-SNAPSHOT]
查看同步任务源码(org.apache.doris.load.sync.canal.CanalSyncChannel.beginTxn()),其中并没有对字段添加"`",在后面的检查中未能通过
What You Expected?
建议canal sync job时对任务目标字段进行处理,防止后面检查不通过导致同步失败
How to Reproduce?
mysql:
CREATE TABLE api (
id int NOT NULL AUTO_INCREMENT,
name varchar(20) NOT NULL,
whitelist tinyint(1) NOT NULL,
PRIMARY KEY (id)
) ENGINE=InnoDB AUTO_INCREMENT=1;
doris:
CREATE TABLE api (
id bigint(20) NOT NULL,
name varchar(20) NOT NULL,
whitelist tinyint(1) NOT NULL,
) ENGINE=OLAP
UNIQUE KEY(id)
DISTRIBUTED BY HASH(id) BUCKETS 2
PROPERTIES ( "replication_num" = "1" )
sync job:
CREATE SYNC test_sync(
FROM test_mysql.api INTO api(id,name,whitelist)
) FROM BINLOG (
"type" = "canal",
"canal.server.ip" = "127.0.0.1",
"canal.server.port" = "11111",
"canal.destination" = "example",
"canal.username" = "canal",
"canal.password" = "xxx"
);
源表添加数据,目标表数据不变化.
SHOW SYNC JOB 发现任务已经暂停, 日志显示异常信息
Anything Else?
DDL和DML时, 当使用{关键字}是可以正确执行, 但同步任务时未处理字段名.
也可能是我使用方式不对,望解答
Are you willing to submit PR?

[ ] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

目前临时解决方案:
拉取drois 1.2.2-rc01代码, 将 org.apache.doris.load.sync.canal.CanalSyncChannel类beginTxn方法代码修改如下
String targetColumn = Joiner.on(",").join(columns) + "," + DELETE_COLUMN;
// 修改成
String targetColumn = "`" + Joiner.on("`,`").join(columns) + "`," + DELETE_COLUMN;

我当前2.1.1版本 已经验证可以解决的办法：
关键字用 三个反引号:
如下：
from

authors: Suchahaercana mrfengtiger


text:
bug fix regression test of jdbc postgresql table core

Proposed changes
Issue Number: close #xxx
Problem summary
Describe your changes.
Checklist(Required)

Does it affect the original behavior:

[ ] Yes
[ ] No
[ ] I don't know

Has unit tests been added:

[ ] Yes
[ ] No
[ ] No Need

Has document been added or modified:

[ ] Yes
[ ] No
[ ] No Need

Does it need to update dependencies:

[ ] Yes
[ ] No

Are there any changes that cannot be rolled back:

[ ] Yes (If Yes, please explain WHY)
[ ] No

Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 34.96 seconds
load time: 466 seconds
storage size: 17172259636 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221119073704_clickbench_pr_49068.html

why the fix just fix the case ?

why the fix just fix the case ?

I discuss it with @zhangstar333 , this is because currently, we have to make sure that the column type in Doris
is identical to the type in source table, or it will cause BE crash.
In this case, the delete column is with boolean type in source table, so the external table in Doris has to be boolean too.
@zhangstar333 will find some other way to prevent BE from crash when type is different, maybe in next PR.
So I will merge it now to make regression test happy.

authors: HappenLee hello-stephen morningman zhangstar333


text:
[Pick](bitmap index) fix is_like_predicate for bitmap index evaluate

Proposed changes
Pick from #25961

Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall


text:
bug fix bitmap value not clear get wrong data

Proposed changes
The SQL : select * from table, the row of dt = 20220202 return [10000,10001,72173389]
But if SQL: select * from table where dt = 20220202       return [10001,72173389]
root reason is the bitmap value not clear, so it's shared from others.

Issue Number: close #xxx

Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

https://github.com/apache/doris/pull/26451 this PR have contains the fix and have been merged to 2.0.3 and pick to branch-2.0


text:
fix Fix pipeline load regression test error

fix pipeline load regression test error

run buildall

has fixed

authors: HowardQin dataroaring zclllyybb


text:
fix fix time zone error in parquet reader

Proposed changes
backport: #33217
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

run buildall

authors: AshinGau xiaokang


text:
Fix fix ScalarType.getAssignmentCompatibleType() when deal boolean and decimal

cherry-pick to branch-2.0 from #34435

run buildall

run buildall


text:
fix use isManagedTable instead of check table type (#34287)

pick: https://github.com/apache/doris/pull/34287

run buildall


text:
FixEnhanced Security Checks for Audit Log File Names (#44612)

#44612

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.
Please clearly describe your PR:

What problem was fixed (it's best to include specific error reporting information). How it was fixed.
Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
What features were added. Why was this function added?
Which code was refactored and why was this part of the code refactored?
Which functions were optimized and what is the difference before and after the optimization?

run buildall

authors: CalvinKirs hello-stephen


text:
Web console: allow stringly schemas in the data loader

This is a change to retain the ability to specify no dimensions without setting useSchemaDiscovery: true in the data loader.
This is needed if someone wants to ingest data in schemaless mode into a datasource made with Druid < 26 and retain the same dimension types.
Internally in the code there is an internal representation of how dimensions are read it used to have values: specific and auto-detect it now has values:

fixed (renamed from specific)
string-only-discovery - represents non useSchemaDiscovery: true schema-less where everything is string typed
type-aware-discovery - represents useSchemaDiscovery: true

Here is how the user selects it:

There is also a warning:

This is tagged as "26.0". There aren't currently docs for useSchemaDiscovery, so for overall consistency we should either add docs or have this feature be more hidden in the UI.

This is tagged as "26.0". There aren't currently docs for useSchemaDiscovery, so for overall consistency we should either add docs or have this feature be more hidden in the UI. Any thoughts on which way we'll go?

Docs are in #14065, which was missing the tag

I updated the PR and also added a warning. The links link to an anchor that will exist once https://github.com/apache/druid/pull/14065 is merged

Configure schema tab:
Prefer to be specific where possible if "this section" might be ambiguous or "any work". Suggestion:

Enabling schema auto detection resets all data transformations and schema configurations for this indexing task.

Prefer "Druid's string-only schema discovery feature" over "string-only schema discovery of Druid"
Configure schema warning:
Suggest:
You have enabled type-aware schema discovery {useSchemaDiscovery:true} to ingest data into the existing datasource {wikipedia}. If you used string-based schema discovery when first ingesting data to {wikipedia}, using type-aware schema discovery now can cause problems with the values multi-value string dimensions. For more information see the documentation.

Thank you for the feedback, I updated the copy (see screenshots)

authors: clintropolis gianm techdocsmith vogievetsky

repo: apache/druid


text:
无法兼容dubbo 2.7.4

Please upgrade to 2.7.4.1

authors: leshalv mercyblitz

repo: apache/dubbo-spring-boot-project


text:
empty sitemap.xml

mkdocs need attr named 'site_url' to generate sitemap.xml

https://dubbo.apache.org/zh-cn/sitemap.xml

repo: apache/dubbo-website


text:
dubbo consumer 在注入spring bean时,无法注入相关的service

Environment

Dubbo version: 3.0.2/3.0.2.1
Operating System version: macos big sur 11.5
Java version: 1.8

Steps to reproduce this issue

定义一个XXXFilter implements org.apache.dubbo.rpc.Filter
在XXXFilter 里定义一个 属性 xxService(需要有一个实现xxService 并增加spring 的@Service注解)
增加一个属性的set方法xxService
启动消费者后,会发现XXXFilter中的xxService并未被实例化,还是null（同理提供者是正常的）

问题原因
最开始设置上下文的地方在DubboInfraBeanRegisterPostProcessor#setApplicationContex中，这里将上下文设置进SpringExtensionFactory。后面调用SpringExtensionFactory#initialize()就会清掉，而consumer端后面没有地方再设置（configCenter没配的情况下）

Suspected of the same issues：#8793

authors: CrazyHZM FelixLiuSheng

repo: apache/dubbo


text:
Tri support no pb wrapper mode

What is the purpose of the change
Brief changelog
Verifying this change

Checklist

[x] Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[ ] Each commit in the pull request should have a meaningful subject line and body.
[ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[ ] Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
[ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
[ ] Add some description to dubbo-website project if you are requesting to add a feature.
[ ] GitHub Actions works fine on your own branch.
[ ] If this contribution is large, please follow the Software Donation Guide.

Solution to #10776

@EarthChen 合并请求#10776的解决方案

The wrapper mode provides the ability to interoperate with native grpc client/server. Compared with the improved performance, the maintenance cost and complexity brought by this content-type mode will be greater. It is recommended that users who care more about performance can choose native protobuf mode instead of maintaining a dialect protocol.

@EarthChen  Please go through workflow；

authors: guohao neighbor-uncleWang


text:
[Dubbo-AbstractConfig] Fix password be print in plain text

What is the purpose of the change
Hidden the important password information to avoid be printed in plain text into the logger file
Brief changelog
Update AbstractConfig.java
hidden password
Verifying this change
The registry[<dubbo:registry password="******" username="someone" timeout="10000" group="test" client="curator" address="127.0.0.1" protocol="zookeeper" port="2181" />] will be used as the config center, dubbo version: 2.7.8, current host: 127.0.0.1
Follow this checklist to help us incorporate your contribution quickly and easily:

[x] Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[x] Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
[x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
[x] Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
[x] If this contribution is large, please follow the Software Donation Guide.

Issue is here
https://github.com/apache/dubbo/issues/6930

Codecov Report

Merging #6931 (eab74e9) into master (3fc2d10) will decrease coverage by 0.08%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##             master    #6931      +/-   ##
============================================
- Coverage     59.43%   59.34%   -0.09%
+ Complexity      510      507       -3
============================================
  Files          1028     1028
  Lines         41519    41519
  Branches       6037     6038       +1
============================================
- Hits          24677    24641      -36
- Misses        14105    14130      +25
- Partials       2737     2748      +11

Impacted Files
Coverage Δ
Complexity Δ

...n/java/org/apache/dubbo/config/AbstractConfig.java
73.05% <0.00%> (-0.33%)
0.00 <0.00> (ø)

...ng/transport/dispatcher/all/AllChannelHandler.java
82.75% <0.00%> (-6.90%)
0.00% <0.00%> (ø%)

...e/dubbo/remoting/transport/netty/NettyChannel.java
55.68% <0.00%> (-4.55%)
20.00% <0.00%> (-1.00%)

...pache/dubbo/remoting/transport/AbstractServer.java
53.75% <0.00%> (-3.75%)
0.00% <0.00%> (ø%)

...mmon/serialize/kryo/utils/AbstractKryoFactory.java
75.43% <0.00%> (-3.51%)
0.00% <0.00%> (ø%)

...he/dubbo/remoting/transport/netty/NettyServer.java
70.17% <0.00%> (-3.51%)
8.00% <0.00%> (-1.00%)

...g/apache/dubbo/rpc/protocol/rest/RestProtocol.java
68.21% <0.00%> (-3.11%)
0.00% <0.00%> (ø%)

...g/apache/dubbo/config/AbstractInterfaceConfig.java
85.18% <0.00%> (-2.47%)
0.00% <0.00%> (ø%)

...he/dubbo/rpc/protocol/hessian/HessianProtocol.java
67.46% <0.00%> (-2.41%)
9.00% <0.00%> (ø%)

...n/java/org/apache/dubbo/config/RegistryConfig.java
84.12% <0.00%> (-2.39%)
0.00% <0.00%> (ø%)

... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3fc2d10...eab74e9. Read the comment docs.

authors: FavorMylikes codecov-io


text:
Adjust the way to obtain codec extension

What is the purpose of the change
Fix https://github.com/apache/dubbo/issues/9440
Fix https://github.com/apache/dubbo/issues/9435
Brief changelog
Verifying this change

Checklist

[x] Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[ ] Each commit in the pull request should have a meaningful subject line and body.
[ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[ ] Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
[ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
[ ] Add some description to dubbo-website project if you are requesting to add a feature.
[ ] GitHub Actions works fine on your own branch.
[ ] If this contribution is large, please follow the Software Donation Guide.

Codecov Report

Merging #9442 (68f2077) into 3.0.5-release (3dac257) will decrease coverage by 0.22%.
The diff coverage is 60.00%.

@@                 Coverage Diff                 @@
##             3.0.5-release    #9442      +/-   ##
===================================================
- Coverage            65.17%   64.95%   -0.23%
+ Complexity             342      341       -1
===================================================
  Files                 1203     1203
  Lines                52009    51952      -57
  Branches              7768     7714      -54
===================================================
- Hits                 33898    33743     -155
- Misses               14487    14581      +94
- Partials              3624     3628       +4

Impacted Files
Coverage Δ

...che/dubbo/remoting/transport/AbstractEndpoint.java
36.36% <60.00%> (+4.10%)
:arrow_up:

...a/org/apache/dubbo/rpc/filter/AccessLogFilter.java
24.35% <0.00%> (-44.88%)
:arrow_down:

...va/org/apache/dubbo/rpc/support/AccessLogData.java
53.16% <0.00%> (-37.98%)
:arrow_down:

.../remoting/api/SingleProtocolConnectionManager.java
61.53% <0.00%> (-23.08%)
:arrow_down:

...ache/dubbo/remoting/transport/AbstractChannel.java
75.00% <0.00%> (-12.50%)
:arrow_down:

...dubbo/common/status/support/LoadStatusChecker.java
50.00% <0.00%> (-11.54%)
:arrow_down:

...mmon/threadpool/support/fixed/FixedThreadPool.java
80.00% <0.00%> (-7.50%)
:arrow_down:

.../common/threadpool/serial/SerializingExecutor.java
70.37% <0.00%> (-7.41%)
:arrow_down:

.../threadpool/support/limited/LimitedThreadPool.java
83.33% <0.00%> (-5.56%)
:arrow_down:

...o/rpc/protocol/injvm/DefaultParamDeepCopyUtil.java
57.89% <0.00%> (-5.27%)
:arrow_down:

... and 48 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3dac257...68f2077. Read the comment docs.

Well done, I think the specific issue stated in issue #9440.
I also think that further steps need to be done to refactor the remoting level, the initialization and runtime of all remoting comments rely on one single URL of a specific interface/service which is very weird.
I personally think replacing the URL parameter in remoting with a mapping attribute will be more clear.

Well done, I think the specific issue stated in issue #9440.
I also think that further steps need to be done to refactor the remoting level, the initialization and runtime of all remoting comments rely on one single URL of a specific interface/service which is very weird.
I personally think replacing the URL parameter in remoting with a mapping attribute will be more clear.

Agree, this will make the URL definition easier, and we can optimize it in subsequent versions.

authors: CrazyHZM chickenlj codecov-commenter


text:
Bar timeseries chart binning is not working as expected

Version
5.2.2
Reproduction link
https://codesandbox.io/s/echarts-zoomin-timeseries-sktvb?file=/src/App.js
Steps to reproduce
You can run the codesadnbox link provided and try to zoom in on each bar chart too reproduce the problem.
What is expected?
Suppose we have three date-value pairs on (1988, 8, 3), (1988, 9, 18) and (1988, 10, 18).
It's expected that when you zoom in on each bar (for example 18/10/1988) and the user can see the actual date on the ticks, the bar should wrap around the actual date tick and it shouldn't extend to other ticks.
Zoomed-out state:

Expected zoomed-in state (Zoomed in on 18/09/1988):

What is actually happening?
The bar wraps around other dates and the actual zoomed-in state on 18/10/1988 looks like this:

(Which is wrong, the bar is also covering 8th and 10th month but it is counting only the data on 9th month)

I also provided a gif on what's happening:

This is not a bug but currently the time series lack the ability to control bar width in the unit of value (time).

Bar width could be controlled by barMaxWidth - Demo v.5.2.2.
Unfortunately v.5.2.2 is the last version showing bars at the right time (X-axis location). And only with (redundant!) stack present.
Newer versions treat time axis similarly to category axis and try to "make space" for adjacent series which makes horizontal position inaccurate.

authors: Ovilia helgasoft th1under

repo: apache/echarts


text:
数值型坐标轴 axisLabel 能否在回调中提供更有用的 data? 目前是 undefined.

在把 axisLabel 设置为 clickable: true 之后, 在 echarts 实例上通过监听事件获取到的值, 除了 axis 的 name, 其它都是无用的, 返回如下:
{
    data: undefined,
    dataIndex: -1,
    event: MouseEvent,
    name: 2004,
    seriesIndex: -1,
    seriesName: undefined,
    special: undefined,
    type: "click",
    value: undefined
}

能否能把当前 x/y轴 值的数组传到 data 中?
是否有方法可以通过 axisLabel 的点击获取到当前所在 x/y轴 所有的数据? 或者像处理坐标点数据一样, 把数组传到 data 中.

同样的问题，能否带一个回调函数

我也需要对X轴进行事件监听
但是 axisLabel  配置中并没有 clickable 这个配置项啊，请问是在哪配置的

https://echarts.apache.org/zh/option.html#xAxis.triggerEvent

authors: BlackCodes fallingfree mansion-sun xiaoyunchen


text:
Added and Enforced AnnotationLocation(1) Checkstyle

I have tried to update XML at random positions to avoid the merge conflicts, I hope the random won't clash :)

Flaky test! looking into it :)

For all flaky tests, always immediately create JIRA and reply with comment
to it on all affected PRs, please.

authors: thesmallstar vorburger

repo: apache/fineract


text:
PART 2 - Use prepared statements instead of string concatenated SQL everywhere (FINERACT-1343)

Description
See FINERACT-1343
Work in progress ..
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!

[x] Write the commit message as per https://github.com/apache/fineract/#pull-requests

[x] Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.

[ ] Create/update unit or integration tests for verifying the changes made.

[x] Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.

[ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/api-docs/apiLive.htm with details of any API changes

[x] Submission is not a "code dump".  (Large changes can be made "in repository" via a branch.  Ask on the developer mailing list for guidance, if required.)

FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.

Hi Fineract community members,
I would like feedback on this particular commit. It is introducing a new project library dependencies
https://github.com/apache/fineract/pull/1687/commits/2d8f3f0a326992e1804757e27a6f884d582754e5
Use ESAPI, The OWASP Enterprise Security API, Escaping where Prepared Statements with Parameterized Queries is not feasible to mitigate SQL Injection (FINERACT-1343)

Woow... This looks like a valuable work. @ptuomola , @vorburger . Have time to take a look?

@josemakara2 This looks really good and would definitely be in favour of merging this... just wondered if you had more work planned for this? The description says "Work in progress" and there's also a TODO in the code...

@ptuomola  Maybe we should just merge this one if it Look Good. Than to let the bot auto close it again.

@awasum Yes, at a quick glance this looks good. I just didn't do anything on this as the comment says "Work in progress". Also the build seems to be failing (could be unrelated) and the comments would need to be squashed. @josemakara2  would you have a chance to finish this off, and we can then merge?

@josemakara2 Can you resolve the build failure?

Let's see if we can get the build to pass...

Looks like this is failing because of classpath duplicates. Need to see if we can fix those...

This still looks important... @fynmanoj , @galovics , @ptuomola , @vidakovic ...Anyone interested to make this happen?

Closing because it looks abandoned.

Looking this one... if someone rebased and made it pass the build.. it will fix some of the issues seen here: https://github.com/apache/fineract/security/code-scanning

authors: BLasan awasum josemakara2 ptuomola vidakovic


text:
[FLINK-26706] Introduce Ingress URL templating

users can customise the endpoint address of the Flink UI
eliminates the need for a wildcard DNS entry *.example.com
enables path and domain based routing with ingress

cc @wangyang0918 @gyfora I'm sharing with you guys while working on the validation. Let me know what you think.

Great work. I will have a look on this PR today.

This PR looks really good to me.
When I am testing this PR in my minikube, I find we must add a trailing slash in the URL. For example, http://192.168.64.5/default/advanced-ingress/. Otherwise, the Flink webUI could not show up. Could we find some solution for this?

I couldn't find a solution for this yet. Maybe we need another rule to handle the root context.

This PR looks really good to me.
When I am testing this PR in my minikube, I find we must add a trailing slash in the URL. For example, http://192.168.64.5/default/advanced-ingress/. Otherwise, the Flink webUI could not show up. Could we find some solution for this?

I couldn't find a solution for this yet. Maybe we need another rule to handle the root context.

See https://github.com/kubernetes/ingress-nginx/issues/4266 for the background. So something like this would solve the missing trailing slash. (I don't personally like the solution tho)
ingress:
    template: "/{{namespace}}/{{name}}(/|$)(.*)"
    className: "nginx"
    annotations:
      nginx.ingress.kubernetes.io/rewrite-target: "/$2"
      nginx.ingress.kubernetes.io/enable-rewrite-log: "true"
      nginx.ingress.kubernetes.io/configuration-snippet: |
        if ($uri = "/default/advanced-ingress") {rewrite .* $1/default/advanced-ingress/ permanent;}

This solution is amazing! Thanks a lot =D
But add this feature in annotation os very useful, for example:
ingress:
    template: "/{{namespace}}/{{name}}(/|$)(.*)"
    className: "nginx"
    annotations:
      nginx.ingress.kubernetes.io/rewrite-target: "/$2"
      nginx.ingress.kubernetes.io/enable-rewrite-log: "true"
      nginx.ingress.kubernetes.io/configuration-snippet: |
        if ($uri = "/{{namespace}}/{{name}}") {rewrite .* $1/{{namespace}}/{{name}}/ permanent;}

WDYT?

authors: morhidi robsonpeixoto wangyang0918

repo: apache/flink-kubernetes-operator


text:
[FLINK-26703] Introduce flink-table-store-dist module for packaging

We need a flink-table-store-dist module to produce a fat connector jar for table store.

We can check the classes in the bundle jar. Let's see if we can shade more, For example, orc has hive-related dependencies inside.
We should introduce NOTICE file?

Hive related dependencies are already shaded. I'll take a look at the NOTICE file.

org/apache/hadoop/hive needs to be shaded too

authors: JingsongLi tsreaper

repo: apache/flink-table-store


text:
[FLINK-17523] Add call expression with a class of UDF as a parameter

What is the purpose of the change
Add a call method that accept a class of UDF. Similar to org.apache.flink.table.api.TableEnvironment#createTemporarySystemFunction(java.lang.String, java.lang.Class<? extends org.apache.flink.table.functions.UserDefinedFunction>)
Verifying this change
Added a test case in ExpressionResolverTest
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (yes / no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
The serializers: (yes / no / don't know)
The runtime per-record code paths (performance sensitive): (yes / no / don't know)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / no / don't know)
The S3 file system connector: (yes / no / don't know)

Documentation

Does this pull request introduce a new feature? (yes / no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@flinkbot run azure

repo: apache/flink


text:
[FLINK-21162] [Blink Planner]use "IF(col = '' OR col IS NULL, 'a', 'b')",when co…

…l = NULL return b.

What is the purpose of the change
we can use if correctly in IF(col = '' OR col IS NULL, 'a', 'b'), its return b before.i add some test,it can be merge when rebase master.
Brief change log
Verifying this change
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): no
The public API, i.e., is any changed class annotated with @Public(Evolving): no
The serializers: no
The runtime per-record code paths (performance sensitive): no
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
The S3 file system connector: no

Documentation

Does this pull request introduce a new feature? no
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

FYI: this issue is already covered by another PR: https://github.com/apache/flink/pull/15547

authors: KurtYoung chaozwn


text:
[FLINK-17707][k8s] Support configuring replicas of JobManager deployment when HA enabled

What is the purpose of the change
At the moment, in the native K8s setups, we hard code the replica of Deployment to 1. However, when users enable the ZooKeeper HighAvailabilityServices or Kubernetes HA service, they would like to configure the replica of JobManager deployment also for faster recovery.
In #15248, we have added the documentation for how to start standby JobManagers for standalone Flink cluster on K8s. This PR tries to make replica of JobManager deployment configurable for native mode.
Brief change log

Support configuring replicas of JobManager deployment when HA enabled

Verifying this change

Add dedicated tests for the changes

Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (yes / no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
The serializers: (yes / no / don't know)
The runtime per-record code paths (performance sensitive): (yes / no / don't know)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / no / don't know)
The S3 file system connector: (yes / no / don't know)

Documentation

Does this pull request introduce a new feature? (yes / no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

cc @tillrohrmann  could you please have a look at your convenience?

Rebase latest master.

cc @xintongsong Could you please have a look?

Thanks for preparing the PR, @wangyang0918.
I'm afraid we are not ready for this feature ATM. As FLINK-21667 reveals, currently a standby RM can perform modifying actions on native Kubernetes deployment. I have not started working on FLINK-21667, because I'd rather not to make significant changes to the RM lifecycle management right before the 1.13 feature freeze.
I'd suggest to postpone this feature as well, marking it as blocked by FLINK-21667.

@xintongsong Thanks for your comments. Even though the standby only stop the terminated pod currently, but it is not a by-design behavior. The standby ResourceManagers should not perform the modifying actions. I agree with you that we could defer this PR after FLINK-21667.

Since the FLINK-21667 has been merged, I think this PR is ready for review. cc @xintongsong

Since the FLINK-21667 has been merged, I think this PR is ready for review. cc @xintongsong

@xintongsong Yes, this feature has been verified in a real K8s cluster. Actually, I think the Flink config option description is enough. But I will add a brief introduction in the native_kubernetes.md.

@xintongsong Thanks for your review. PR updated.


text:
[FLINK-31305] Propagate producer exceptions outside of mailbox execut…

…or so that checkpoints can correctly fail
What is the purpose of the change
Fixes a regression when the checkpoint completes although there is an error. The exception is never thrown before checkpoint completing because the exception throwing logic is enqueued to separate task, during checkpointing.
Brief change log

Propagate exception and throw them in write/flush/close methods.

Verifying this change
This change added tests and can be verified as follows:

Added unit tests and ran existing unit tests, integration tests, and e2e tests.

Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): no
The public API, i.e., is any changed class annotated with @Public(Evolving): no
The serializers: no
The runtime per-record code paths (performance sensitive): yes
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: yes
The S3 file system connector: no

Documentation

Does this pull request introduce a new feature? no
If yes, how is the feature documented? not applicable

If that is documented and known to everyone then OK. I think it would be better to follow the established process until the old code was actually removed from master. Otherwise we allow for the possibility of merge conflicts due to absence of a primary branch.

@tweise on the matter of merge process for this change:
I believe there wasn't any prior announcement for this, but technically now that release-1.17 branch is cut, and the fact that we've agreed that 1.17 will be the last release where the Flink Kafka Connector will exist in an apache/flink core release, we should actually be good now to remove the Flink Kafka connector code from apache/flink:master, and going forward the official process would be:

Open changes against apache/flink-connector-kafka:main
If necessary, backport to previous release branches of apache/flink-connector-kafka
While Flink 1.16 and 1.17 is still supported, if appropriate, backport changes to apache/flink:release-1.16 and apache/flink:release-1.17 as well.

Merging this PR to apache/flink:master now could complicate things a bit with the externalization effort - because technically we can remove the Kafka connector code in apache/flink:master any time now.
Perhaps we actually should do that first?

@tzulitai removing the code from master would resolve this. I would also be in favor of that, since 1.17 was released. I just think that while the code is still there it also should be maintained. Is anyone working on removing it?

authors: mas-chen tweise tzulitai


text:
[FLINK-5906] [table] Add support to register UDAGG in Table and SQL API

Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration.
If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the How To Contribute guide.
In addition to going through the list, please provide a meaningful description of your changes.

[x] General

The pull request references the related JIRA issue ("[FLINK-XXX] Jira title text")
The pull request addresses only one issue
Each commit in the PR has a meaningful commit message (including the JIRA id)

[ ] Documentation

Documentation has been added for new functionality
Old documentation affected by the pull request has been updated
JavaDoc for public methods has been added

[x] Tests & Build

Functionality added by the pull request is covered by tests
mvn clean verify has been executed successfully locally or a Travis build has passed

Thanks for the review, @fhueske , and very good point regarding to the approach to "replace UDAGGFunctionCall". I have addressed your comments. Please take a look.

Merging

authors: fhueske shaoxuan-wang


text:
[FLINK-7506] Fence JobMaster

What is the purpose of the change
This commit lets the JobMaster extend from FencedRpcEndpoint. This enables
automatic fencing of all messages. Moreover, this PR introduces the
JobMasterId which is the new leader id/fencing token replacing the UUID. This
improves type safety when passing multiple fencing tokens around.
This PR is based on #4582 and #4579.
Verifying this change
This change is already covered by existing tests, such as FencedRpcEndpointTest.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
The serializers: (no)
The runtime per-record code paths (performance sensitive): (no)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)

Documentation

Does this pull request introduce a new feature? (no)
If yes, how is the feature documented? (not applicable)

Failing test case JobManagerCleanupITCase.testBlobServerCleanupCancelledJo is unrelated. Merging this PR.


text:
[FLINK-10045] [Startup Shell Scripts] .bat script to start/stop Flink daemon

Created scripts to start/stop Flink as daemon
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): no
The public API, i.e., is any changed class annotated with @Public(Evolving): no
The serializers: no
The runtime per-record code paths (performance sensitive): no
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: no
The S3 file system connector: no

Documentation

Does this pull request introduce a new feature? no
If yes, how is the feature documented? not applicable

@pavel-shvetsov-git thanks for your contribution, all the files of this PR missed Apache License title, please add it.

The Flink developers have decided that we don't want to extend windows script support for now: https://lists.apache.org/thread.html/r7693d0c06ac5ced9a34597c662bcf37b34ef8e799c32cc0edee373b2%40<dev.flink.apache.org>. I'm very sorry because you already invested time in this.

authors: aljoscha pavel-shvetsov-git yanghua


text:
[FLINK-12963][state-processor-api] Add savepoint writer for bootstrapping new savepoints

What is the purpose of the change
Introduce a savepoint writer for bootstrapping state.
Brief change log
This is based on #8618 and only the last 4 commits are relevant.
b341e91  Introduces the new runtime components for running a bounded stream task and snapshotting its contents after processing all elements. Note this is the most important commit.
830ac6a Add user-facing interfaces and corresponding stream operators.
f12439f Adds the user api
b0f176e  Update the travis profile so that the state processor api is run during the libraries stage
Verifying this change
This change added tests and can be verified as follows:
UT and IT test
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): no
The public API, i.e., is any changed class annotated with @Public(Evolving): no
The serializers: no
The runtime per-record code paths (performance sensitive): no
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: no
The S3 file system connector: no

Documentation

Does this pull request introduce a new feature? yes
If yes, how is the feature documented? documented

cc @tzulitai

Thanks for taking a look @Myasuka
Parallelism does not matter since it does not affect the user's ability to restore, only max parallelism which is used to define key groups. This implementation assumes the parallelism of the provided data set was set appropriately by the user for the data. The only times we change it are when

Writing broadcast state
The parallelism is greater than the specified max parallelism

As outlined in the docs, max parallelism is set either when creating a new savepoint Savepoint.create or when using an existing savepoint as a base Savepoint.load its max parallelism is used.
I do agree, the ability to set max functionality at a per operator level, in addition to the global max parallelism would be useful.

@tzulitai I've rebased on master and made some misc updates to align with the changes you made on the reader api when merging.

@flinkbot approve description
@flinkbot approve consensus

@flinkbot approve all

authors: sjwiesman tzulitai