text:
fix: Guard against NoneType value when using group in Amazon hub parsing

Proposed change

Fix NoneType error when Amazon Hub is in use
Type of change

[ ] Dependency upgrade
[x] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (which adds functionality)
[ ] Breaking change (fix/feature causing existing functionality to break)
[ ] Code quality improvements to existing code or addition of tests
[ ] Documentation update
[ ] Adds a new shipper
[ ] Update existing shipper

Additional information

This PR fixes or closes issue: fixes #568

Codecov Report

Merging #569 (7f283a3) into dev (8ce7846) will increase coverage by 0.00%.
The diff coverage is 100.00%.

:exclamation: Current head 7f283a3 differs from pull request most recent head bba46e1. Consider uploading reports for the commit bba46e1 to get more accurate results

@@           Coverage Diff           @@
##              dev     #569   +/-   ##
=======================================
  Coverage   98.92%   98.92%
=======================================
  Files           6        6
  Lines        1298     1300    +2
=======================================
+ Hits         1284     1286    +2
  Misses         14       14

Impacted Files
Coverage Δ

custom_components/mail_and_packages/helpers.py
99.57% <100.00%> (+<0.01%)
:arrow_up:

source: gharchive/pull-request

license: MIT

license_type: permissive

license_source: github-api


text:
Migrate dotnet tool

merge feature branch - migrate dotnet tool

re-open for review and merge.

repo: morganstanley/Crossroads


text:
Add a reason parameter to shouldRenderSuggestions

This pull request:

Fixes #772, as described in that issue.
Fixes npm run build, by fixing prettier to run against src.
This wasn't working because npm run prettier is missing an argument for which files to prettify. Rather than following #763 and running prettier:all (and reformatting a huge amount of code) this just prettifies the src files, which appear to be the previous prettier'd content, and are already very close to correct anyway. If this is merged, #763 could be closed too.

Hi @hugoholgersson I didn't realise anybody else was maintaining this repo, and I had previously been planning to just directly merge my own PR here. I'm not sure how involved you want to get, but if you are interested in helping with reviews I'd love to know what you think on this one, so I'm not just unilaterally merging my own code :smiley:. Let me know!

repo: moroshko/react-autosuggest

license: mit

license_source: bigquery


text:
make list bounded when using arrows

Right now using up and down arrows on list rendered by autowhatever causes "null" value at the end of list. It would be nice if there would be possibility of using only available values when using arrows.
Example: https://jsfiddle.net/b6m0frgs/9/
Type 'a' -> press arrow key down (you see 'Apple') -> press arrow key down (you see 'Banana') -> press arrow key down (you see 'Cherry') -> press arrow key down (you see 'a')
So maybe instead of last 'a' there should be 'Apple' again.
This could be configurable by a flag. What do you think? It will be nice thing to have in react-autosuggest
Cheers,
Michał

@moroshko WDYT? I could prepare this change

I came up with different solution for my problem, so this issue is no longer important for me. Sorry for that
Cheers

source: gharchive/issue

repo: moroshko/react-autowhatever


text:
🛑 Bama is down

In 75e231e, Bama (https://bama.design) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Bama is back up in ff61c0c after 20 minutes.

repo: mortonpepper/upptime-upptime


text:
Change vision image

What does this PR do?
Changes vision image to build on 3.10 / torch 1.13.

Test failures will be fixed here https://github.com/mosaicml/composer/pull/1874

repo: mosaicml/composer


text:
Remove requirement for validation and metrics

Users who just want to run training, and not validate on an external dataset should not need to supply validation and metrics as part of their ComposerModel. Especially now that the eval_dataloader is an optional argument to our trainer. This PR removes the abstract marker for the two methods in question.
h/t: @A-Jacobson

Can you have these functions raise a NotImplementedError instead of just a pass? Will help avoid nasty errors if a user doesn't implement something but we still call the method. Otherwise LGTM

authors: hanlint ravi-mosaicml


text:
Unify algorithm settings in our test suite

Several parts of our test suite need to test the algorithm within a trainer context:

test_algorithm_resumption
test_trainer: TestTrainerAssets
individual algorithm tests

Currently, each one defines a large test combination of models, datasets, algorithms, and then filters/xfails, and each one takes a different approach. Algorithm developers would then need to modify these individually. This inflexiblity also slows the test suite as ReNet50 is used for blurpool because its required for stochastic_depth, when a more minimal model is appropriate.
This PR introduces a central place for storing canonical "setting" (dataset, model, algorithm, algorithm kwargs) for each algorithm. This should be as minimal as possible to activate the algorithms.
Draft mode, open for comments.
Open question: Should this be in code, or do we want to involve hparams and use the yamls?
TODO:

[x] adapt test_trainer to use settings
[x] adapt test_algo_resumption to use settings

I try to make sure that unit tests only test one component, and be as independant as possible, so mixing hparams testing and algorithm resumption testing seems anathema to that? The motivation here being that the tests are more readable, easier to maintain, and also easier to debug (e.g. an hparams failure shows up in an hparams test, and not elsewhere).
Perhaps we need separate hparams test that create the object using both hparams and __init__, and then test that the created objects are equivalent?

tests are more readable, easier to maintain, and also easier to debug

Certainly seems that way to me.

Perhaps we need separate hparams test that create the object using both hparams and init, and then test that the created objects are equivalent?

This seems like the right call.

authors: growlix hanlint


text:
Infer step size and gather_in_batch_negatives for Embeddings

Theres two cases:

For in batch negatives, total number of negatives is batch size - 1. And pos_step_size is 2.
For hard negatives, each sample has a list of negatives that can be as long as you like. In this case you have to change the pos_step_size.

We can remove setting step_size and autoinfer without needing the pos_step_size. We will need to look at the first batch to determine how many hard negatives. If there are hard negatives, we will use that - 1 as the step size. Otherwise, we will defer to batch negatives, setting step_size = 2
Testing:
embedding-ft-no-pos-zXOtvz (off of this branch, removed pos_step_size keyword):

embedding-ft-pos-kl2fPy (off foundry main pos_step_size = 2):

embedding-ft-pos-neg-gMJSGx (off foundry main pos_step_size = 21)

embedding-ft-no-pos-neg-3GoEms (off of this branch, removed pos_step_size keyword):

I really like this idea. I do have a couple soft suggestions:

Rather than self._first_batch_seen can you simply set self.step_size = None during init? Then check if self.step_size is None instead of using first_batch_seen.

It could be more tidy to just make step_size part of the batch. I think you could do something like batch["step_size"] = step_size, so that it is accessible in compute_score? That being said, I'm not familiar enough to foundry to know if this causes complications, and you might need to do something like batch["step_size"] = torch.tensor([step_size] * batch_size, dtype=torch.long). If you go this route, then you can ignore (1).

Anyway, the current approach is fine too, but wanted to share just in case.

Tested with the following runs:
0 negatives: embedding-ft-no-pos-neg-0-7jyk87

1 negative: embedding-ft-no-pos-neg-1-zAeAzg

20 negatives: embedding-ft-no-pos-neg-20-EicOP8

All looks good

authors: KuuCi mrdrozdov

repo: mosaicml/llm-foundry


text:
Fix fmapi_chat for instruct models and custom tokenizers

🙃 https://stackoverflow.com/questions/67412925/what-is-the-difference-between-lentokenizer-and-tokenizer-vocab-size
Tested via:
device_eval_batch_size: 4
icl_tasks:
-
  label: jeopardy
  dataset_uri: eval/local_data/world_knowledge/jeopardy_all.jsonl
  num_fewshot: [3]
  icl_task_type: language_modeling
  continuation_delimiter: "\nAnswer: " # this separates questions from answers
  has_categories: true
icl_subset_num_batches: 1
max_seq_len: 1024
models:
- model:
    local: true
    name: fmapi_chat
  model_name: mpt-example
  tokenizer:
    name: mosaicml/mpt-7b-8k-instruct
seed: 1

@dakinggg  Good call, caught an issue in interface.py that would have caused the same bug when I got to casual models..
Updated 8a7c929

Great catch! I can only imagine how hard this bug was to track down. 🙃

authors: aspfohl bmosaicml


text:
Add finetuning streaming dataset conversion

Changes:

add a JSONL IFT dataset
modified scripts/data_prep/convert_finetuning_dataset.py, adding tokenizer args. If it's set, it will run the tokenizer, and save token ids, instead of raw text.

In a separate PR, we will add an example yaml to use streaming dataset for finetuning.
test:
python convert_finetuning_dataset.py --dataset "json" --splits "train"    --out_root "example_data" --data_files "./dolly_hhrlhf_train_small.jsonl" --tokenizer=gpt2 --skip-preprocessing --max_seq_len=512

You might want to run linting locally and also pytest using pytest -vv -s . command to ensure those passes locally.

LGTM, but can you please include evidence of manual testing in the PR description?

Thanks very much for the review! Added the screenshot of the run. Please let me know if more information is needed.

@bigning i'd suggest also just loading the dataset manually and checking that the first sample looks as you expect it to

authors: bigning dakinggg karan6181


text:
ci: check that all code in .proto must have comments; 让 CI工具检查“proto 代码必须包含注释”

What would you like to be added:
We can let CI to check that all code in .proto files must have comments.
For example, we have comments on state API, see https://github.com/mosn/layotto/blob/main/spec/proto/runtime/v1/runtime.proto#L440

And these comments are used to generate document, see https://github.com/mosn/layotto/blob/main/docs/en/api_reference/runtime_v1.md#getstaterequest
But unfortunately, we don't have comments on File API. So the corresponding doc is empty. see https://github.com/mosn/layotto/blob/main/docs/en/api_reference/runtime_v1.md#getfilerequestmetadataentry

Why is this needed:
Make sure we have necessary comments on api spec

A bit of complex for me maybe. I can give it a try.

@MichaelDeSteven ok. Thanks!
We need to search for any existing linter to achieve this goal.
I know there are some linters for proto files, but haven't look into details:
https://github.com/ckaznocha/protoc-gen-lint
https://github.com/uber/prototool
https://github.com/bufbuild/buf

@MichaelDeSteven ok. Thanks! We need to search for any existing linter to achieve this goal. I know there are some linters for proto files, but haven't looked into details: https://github.com/ckaznocha/protoc-gen-lint https://github.com/uber/prototool https://github.com/bufbuild/buf

we can use buf linters to achieve this goal.
here is my step:

config buf.yaml in project root directory.

version: v1
lint:
  use:
    - MINIMAL
    - COMMENT_ENUM
    - COMMENT_ENUM_VALUE
    - COMMENT_FIELD
    - COMMENT_MESSAGE
    - COMMENT_ONEOF
    - COMMENT_RPC
    - COMMENT_SERVICE

write makefile and dockfile
we can execute buf lint to check comment before compile proto files and generator the corresponding doc.

@MichaelDeSteven Sounds great! We can run this linter in our CI
Could u submit a PR for it?

@MichaelDeSteven Hi, how about you continue with this issue?
As for https://github.com/mosn/layotto/pull/669 , I will help do it

@MichaelDeSteven Hi, how about you continue with this issue? As for #669 , I will help do it

Apologies for the delayed response.
ci task has some progress.

buf lint will be executed when we use make proto.doc

here is result of the above pic.
empty comment item is more than 100, which will be fixed.

buf lint is not support check trailing comments but I found the project doc says that trailing comments is support. Maybe we should only support leading comments to simplify issues?

Looking forward to your reply.

@MichaelDeSteven
Regarding trailing comments: yes, we can only check leading comments to simplify it.
Regarding make proto.doc and buf lint: actually we want to check the comments automatically in the CI, so that when contributors want to modify the proto files, the CI can tell him "hey, please write some comments on them".
Therefore, could you add this  buf lint check in the CI ?
Thanks a lot for your contribution!

Hi @seeflood, I hava two question.

The scope of comments. We just need to check the COMMENT_ENUM, right? If we check all of place including COMMENT_ENUM\COMMENT_MESSAGE\COMMENT_SERVICE and so on, I need take some time to add necessary comments.

I have not write CI file experience. The CI of the buf. I just need to follow them, right? Is that we need to provide makefile that developer can check .proto file in local env before pr?

@MichaelDeSteven

I think you can make it check all, including COMMENT_ENUM\COMMENT_MESSAGE\COMMENT_SERVICE.
You don't have to add comments for all of them yourself, which is tiring.
We can add comments together in some other PR. Maybe just adding a simple comment "Required" or "Optional" is enough.

Yes you can follow the guide and modify the github workflow file

we need to provide makefile that developer can check .proto file in local env before pr?

Yes, besides github workflow, I think a makefile script is helpful.

@MichaelDeSteven

I think you can make it check all, including COMMENT_ENUM\COMMENT_MESSAGE\COMMENT_SERVICE.
You don't have to add comments for all of them yourself, which is tiring.
We can add comments together in some other PR. Maybe just adding a simple comment "Required" or "Optional" is enough, which indicates whether this field is necessary or not .
Yes you can follow the guide and modify the github workflow file

we need to provide makefile that developer can check .proto file in local env before pr?

Yes, besides github workflow, I think a makefile script is helpful. But if you find the makefile hard to write, you can split this issue into different PR, one PR for github workflow, another PR for makefile script.

I open a pr. Review it plz.

authors: MichaelDeSteven seeflood

repo: mosn/layotto


text:
Add setting for disposable time between transfers

This adds an option to increase the time between transfers by a fixed duration. This setting can be used, if passengers want some time for orientation or to compensate small delays.

please rename disposable -> additional
the word disposable seems not like a good fit
https://www.thesaurus.com/browse/disposable

Any suggestions for a better name? Thank you for the fast reply
I'm also not sure, if the duration for the footpath should include this duration. Or if it should be split, e.g. FOOTPATH (duration=X,  additional_time=Y)

I guess the user expects that (footpath time + additional time) < (departure time - arrival time)
At least I would expect that.

That was my intention, to make the footpath duration and additional time more obvious. But as I wrote, I'm not sure what format might be good to avoid possible confusion. I think, it might also depends on how the feature will be used.

authors: MichaelKutzner felixguendling

repo: motis-project/nigiri


text:
Boolean fields submitting nil instead of false

I'm new to motor-admin, but am having a great experience so far, after trying activeadmin.
When I create a new record on a table that has boolean columns, if I do not check the boxes, they are saved as nil instead of false. If I go ahead and check them and then uncheck them, they get recorded properly as false values.
Am I doing something wrong?

Do your boolean fields accept null?

authors: dmanaster thedumbtechguy

repo: motor-admin/motor-admin-rails


text:
Reto #1 - Go

Describe tus cambios
(Opcional) Sobre todo aconsejable si la "Pull Request" se corresponde con una corrección adicional y no con la presentación de un ejercicio.
Comprobaciones
Asegúrate de cumplir los siguientes puntos antes de realizar la "Pull Request":

[ ] El título de mi Pull Request sigue este formato: "Reto #[número] - [lenguaje_utilizado]". (Ej: Reto #0 - Kotlin")
[ ] El nombre el fichero que se corresponde con el de mi usuario en GitHub más la extensión del lenguaje. (Ej: mouredev.kt)
[ ] El fichero de corrección se encuentra dentro del directorio del ejercicio y en una carpeta con el nombre del lenguaje de programación utilizado en minúsculas. (Ej: Reto #0/kotlin/mouredev.kt)
[ ] He revisado que el nombre del directorio del lenguaje no es conflictivo:

c#, no csharp
c++, no cplusplus
go, no golang
javascript, no js

[ ] Únicamente he incluído los ficheros de ejercicios. No se aceptarán Pull Requests que contengan archivos adicionales asociados a editores de código o semejantes.

Información

Tienes toda la información sobre los retos semanales en retosdeprogramacion.com/semanales2023.
Cada semana se realizará la corrección en directo y publicación de un nuevo reto en twitch.tv/mouredev.
Recuerda que tienes un grupo de apoyo llamado "reto-semanal" en Discord.

Excelente propuesta Luis!

authors: LuisZentenxx leoarayav


text:
Allow attached objects in move_group's /compute_ik pose frames

Description
In the existing move_group implementation, the pose frame in PositionIKRequest's pose_stamped and pose_stamped_vector were converted to robot's root frame using TF2, which meant that the calls to /compute_ik service would fail with FRAME_TRANSFORM_FAILURE when one tried to use an attached object frame (or subframe) there. This changes the code to use RobotState::getFrameTransform to convert those poses to the robot's root frame instead, enabling the use of attached object frames/subframes.
Checklist

[X] Required by CI: Code is auto formatted using clang-format
[ ] Extend the tutorials / documentation reference
[ ] Document API changes relevant to the user in the MIGRATION.md notes
[ ] Create tests, which fail without this PR reference
[ ] Include a screenshot if changing a GUI
[ ] While waiting for someone to review your request, please help review another open pull request to support the maintainers

Also, does RobotState::getFrameTransform() actually support getting frames not in the robot model, like available as external frames in the TF tree?
This may also be another major difference between the existing and proposed implementations, which would also break for any non-robot model reference frames.

authors: ANogin sea-bass


text:
Consider enabling linting of markdown files

So that code blocks are validated.
See: https://www.npmjs.com/package/eslint-plugin-markdown

More or less related to this, what about linting markdown documents as a whole? 🤔

authors: acostalima satazor

repo: moxystudio/eslint-config


text:
Ensure all folders are accessible by appuser in the Docker container

What's changing
I run into an error trying to run the container, /home/appuser/.cache is not accessible for appuser
How to test it
Build the container and try to run it locally
I already...

[X] Tested the changes in a working environment to ensure they work as expected
[N/A ] Added some tests for any new functionality
[N/A ] Updated the documentation (both comments in code and under /docs)

Ok I made some changes so that models are correctly downloaded after configuring the user

authors: agpituk daavoo

repo: mozilla-ai/document-to-podcast


text:
Getting Uncaught TypeError: a is not a function error on the CDN version of the library.

Uncaught TypeError: a is not a function
at Object. (:1:9802)
at t (:1:385)
at Object. (:1:9677)
at t (:1:385)
at Object. (:1:9626)
at t (:1:385)
at Object. (:1:9332)
at t (:1:385)
at Object. (:1:9142)
at t (:1:385)
Note: This used to work 3 days ago, looks like something is broken in the latest version.
I am using https://unpkg.com/react-jsonschema-form/dist/react-jsonschema-form.js CDN link.

Can you confirm that this is still the case? Can you provide a SSCCE, for example on codesandbox.io?

I don't know how long this will still be available, but I don't get the errors with:
   <script scr='https://unpkg.com/react-jsonschema-form@1.0.3/dist/react-jsonschema-form.js'></script>
It would be really helpful if Mozilla provided a simple example on how to use the "CDN version" of this library. Just plain HTML with  embedded

I too am seeing this issue with 1.0.4. It does not happen with 1.0.3.

I think this is a duplicate of #991.

authors: GuyPaddock M-Reimer glasserc loganvolkers rohitbishnoi

repo: mozilla-services/react-jsonschema-form


text:
Implement local support for Trusted Crates

This bug is to track implementing support for the local component of Trusted Crates (#458). This includes both adding the relevant section to the audits.toml file format, handling in the resolver and imports.lock resolution, as well as adding the cargo vet trust command to trust a new crate's author.
A significant fraction of this work could be based on the existing wildcard audits logic, though unlike wildcard audits, these should not be imported into imports.lock or considered when imported from a peer.
Support for performing trust suggestions based on live-imported trust entries can be implemented independently once this is implemented.

This was finished in #461

repo: mozilla/cargo-vet


text:
Do not send extra channels for aggregate devices.

We drop the first several channels if there are extras (e.g. for aggregate devices) After f8df86f753d81c3ef2e8a6661b11ed65af579919, this is often incorrect
(because the first device is the input device), and also is inefficient.
So, only request the channels we're planning to use.

cc @Pehrsons , who I've been working with on this. You may want to do more extensive testing here; I've only tested one combination of input/output devices.

I believe the test failures are the same as on ToT, but I'm not sure if there are any new problems here.

repo: mozilla/cubeb-coreaudio-rs

license: ISC


text:
allow running of TestCsrfMiddleware tests in isolation

http://paste.codebasehq.com/pastes/cqiietmujjohn7l0e5
if I run all the tests for the module it passes, if I single out TestCsrfMiddleware it fails
the number of tests run each way adds up though, so it's not skipping anything when I run all
I can see why it fails but I wasn't getting why it passes when you run them all. Now I see it's because the Django request middleware gets set up by ClientHandlerif you run the other test classes, and this is necessary to have a request.user for the csrf middleware to check for.
So strictly speaking it seems like TestCsrfMiddleware should also set up request middleware, at least for the failing method that needs request.user.
I have made a hack for this here, not sure if it's the best way. (or could I just set a dummy user attribute on the request and leave it at that?)

Thanks Paul!

cool, p.s. how do you know my name?  :)

heh ok phew, thought I'd messed up my github config :)

authors: anentropic jbalogh

repo: mozilla/django-session-csrf


text:
[bug 1161144] Implement suggest framework

This implements a suggest framework that allows us to have a series of
Providers which offer suggested links to list on the Thank You page
after a user has given us feedback. Initially, we'll use this to generate
links for sad feedback based on SUMO data. We can additionally use this
for other purposes such as soliciting additional information based on
trigger words.
The world will be our oyster.
r?

I'm interested in thoughts and comments. There isn't much test-wise, but there isn't much code, yet, either.
Thoughts?

This looks good to me. I don't know if it will last 400 years like :notes: :musical_note:
It will do for now though.

^^^ rebases against master and fixes the typo.

@mythmon points out it's probably better to do instances. I'll switch it now.

^^^ Redoes it so it uses instances instead of classes.

LGTM. :sunny:

Thank you!

authors: rlr willkg

repo: mozilla/fjord


text:
Add the missing  index to prod (#1048)

Fixes #1048

@jasonthomas r?

r+

authors: jasonthomas magopian

repo: mozilla/olympia


text:
[Regression] Text-selection boxes visually overlap after PR 17533

Attach (recommended) or Link to PDF file here: https://github.com/mozilla/pdf.js/blob/master/test/pdfs/pdf.pdf.link
(This can be reproduce even with tracemonkey.pdf, but it's less pronounced since the lines don't overlap as much.)
Configuration:

Web browser and its version: Firefox 123.0a1
Operating system and its version: Windows 11
PDF.js version: 5d2e7cf3fcac1d0536003369ab3163b006539bfa, i.e. PR #17533
Is a browser extension: N/A

Steps to reproduce the problem:

Select text, and look at the intersection between different text-selection boxes.

What is the expected behavior? (add screenshot)
The intersection should not be visible, as previously:

What went wrong? (add screenshot)
The intersection is visible:

Link to a viewer (if hosted on a site other than mozilla.github.io/pdf.js or as Firefox/Chrome extension): N/A
/cc @calixteman

This has not made its way to Firefox yet, right?

This has not made its way to Firefox yet, right?

Correct.

I think this regression is acceptable with regard to the improvement we've in HCM and it helps to see the caret to make highlighting possible with the keyboard.
It's a visual annoyance, but I'd say that it doesn't avoid to use text selection and I checked few pdfs and in general there are no issues, so maybe this case is just a corner case.
That said, as far as I know there is no way to fix it without reverting the regressor patch BUT the height of the selection depends of the font, its size, the line height, ... which aren't correct because the font we use (serif/sans serif) is very likely not the one we've in the pdf. So the correct fix should be to use the font from the pdf in the text layer (I still have a WIP locally to do that).

Given the above, should we still mark this as a release blocker? I'm planning to make a new release tomorrow, and if this does block a new release I'll postpone that action.

I think this regression is acceptable with regard to the improvement we've in HCM and it helps to see the caret to make highlighting possible with the keyboard.

I don't really agree with that assessment, since we have potential regressions for the majority of users this way.

It's a visual annoyance, but I'd say that it doesn't avoid to use text selection and I checked few pdfs and in general there are no issues, so maybe this case is just a corner case.

Unfortunately it can be a lot worse than just a minor annoyance in some cases, please see an example further below.

That said, as far as I know there is no way to fix it without reverting the regressor patch

Would it be feasible to only apply the new styles in HCM, to avoid affecting "normal" browsing?

So the correct fix should be to use the font from the pdf in the text layer (I still have a WIP locally to do that).

The problem is that it still won't fix these types of issues generally, since glyphs are often positioned absolutely and that means that we'll never get rid of all overlapping text-selection boxes. The example that I used in this issue contained vertical overlap, but it could just as well be horizontal overlap which can look a lot worse.
The following is an especially problematical example, since it uses Type3 fonts, but it does illustrate (much better) why we "need" to do something about it: https://github.com/mozilla/pdf.js/files/1274923/SMPembedded.2006.10.09b.pdf

In general we can't ship something which isn't accessible (it used to be the opposite but nowadays it's the policy), so we need to make highlighting keyboard accessible if we want to ship it.
The "annoyance" you mentioned here is less important for us than fixing a11y issues.
About the pdf you mentioned in your comment: it was already awful (in term of text selection) and I fully agree that now it's worse but between "awful" and "slightly more awful" and I don't see that much difference, so I still consider that it's a minor annoyance in general.
That said, I usually try to improve things instead of making them worse, so I've a WIP locally to draw the selection in using the svg layer we recently added , for example:

and it'll fix this bug and it'll let us really improve text selection in HCM (in using a filter) which is, right now, awful. In term of performance, I didn't see any noticeable regressions.

And for your information, I have a potential fix for the selection issue in Chrome.
I need to think about that globally but I've the feeling it should be possible to fix most of the selection issues we've.

I think this regression is acceptable with regard to the improvement we've in HCM and it helps to see the caret to make highlighting possible with the keyboard.

I don't really agree with that assessment, since we have potential regressions for the majority of users this way.

I agree we should avoid shipping this regression to users. I have filed https://bugzilla.mozilla.org/show_bug.cgi?id=1878258 to track this regression so that we make sure it is fixed before we release Firefox 124 (which currently includes the regression).
That said, we are considering the regression less severe than the improvement because while it's true that the regression affects a larger number of users, the improvement has a huge impact for users that currently are completely unable to select text and/or highlight text in the reader.

I agree we should avoid shipping this regression to users. I have filed https://bugzilla.mozilla.org/show_bug.cgi?id=1878258 to track this regression so that we make sure it is fixed before we release Firefox 124 (which currently includes the regression).

Thank you for the feedback. Given this information I'll hold off on releasing a new PDF.js version until this is fixed so there is enough time and we avoid any bug reports about this.

Given that this has been a release blocker for a long time now and the last PDF.js release was in December 2023, the question was raised in https://github.com/mozilla/pdf.js/pull/17880#issuecomment-2034930669 if we should go ahead and create a release now and just put a note in the release notes about this bug? I agree with this because we have had many features and bugfixes land since that users would like to have, and if we wait longer the release will only get bigger while we would like to keep releases small (as was the purpose of the monthly release cycle).
@calixteman @marco-c What do you think about this?

@calixteman if it's a quick and easy fix, I'd say let's wait on that. If it's a more cumbersome fix, I'd agree with shipping a version with the regression included.

@calixteman What do you think of the above? If it's desired I can make a new release today or tomorrow, for the reasons mentioned above and so we can land some other PRs that would be safer to merge once a new release is made.

Yes please make a release.
I'll try to land a patch in the next weeks.

I have just completed the release of PDF.js version 4.1.392, with this bug references as a known issue in the release notes at https://github.com/mozilla/pdf.js/releases/tag/v4.1.392.
@calixteman The bot sadly doesn't seem to have pushed the release to NPM. Could you check the logs and push it manually so NPM is also in sync again? This issue prompted me to look into porting the NPM part to GitHub Actions as part of #11851 again, and I think I now finally have an idea on how we can prepare and test this without actually having to push something to NPM until we're fully convinced it will work (because we don't want to pollute NPM with test releases), so I hope to make a patch for that soon so we can remove this functionality from the bots and hopefully fix this issue once and for all.
In any case, the landing of new patches should be unblocked now.

It was a matter of cached ssh key.
It should fine now:
https://www.npmjs.com/package/pdfjs-dist

I have removed the release-blocker label because we're already tracking this with the regression label and as high priority on the project board, plus we've had several releases by now and haven't received new complaints about this as far as I have seen (so hopefully for most documents the change isn't really visible). We should still fix this, but it doesn't seem severe enough anymore to warrant the release-blocker label or separate inclusion in the release notes.

authors: Snuffleupagus calixteman marco-c timvandermeij


text:
Equality sign not displayed

Instead of the "equality sign" the "minus sign" is displayed.
PDF url: http://www.karlin.mff.cuni.cz/~navratil/index_soubory/cv1.pdf , page 2, section "VLASTNOSTI"
PDF.js version: not sure how to get this information
Windows version: win 7 64bit
Firefox version: 25.0.1
Javascript console: Firebug does not show any warnings/errors

If you need any more info, just ask and I will provide it.

This happens for me and has nothing to do with PDFs. I get this in normal fixed width fonts in the browser (FF 37.0.2). When I zoom in (using the browser zoom) the equal sign appears, but at 100% it appears as a minus sign.

I'm still getting this problem in 94.0.2. When I zoom in, I can see the equal signs but at normal zoom they all appear as minus signs. This issue persists when HWA is on and off.

The bug is closed and the pdf in first comment is not available, so there is nothing actionable here.
Please file a new bug.

authors: calixteman graywolf hanmangokiwi tim-sebring


text:
This PDF renders slowly when the window is large

Create a new Firefox profile
Maximize the Firefox window (important!)
Load http://makezineblog.files.wordpress.com/2013/07/integratedspaceplan2color.pdf

Result: PDF renders very slowly. When it is adding text, it adds one letter at a time IFF the word being drawn is on-screen.
(Firefox Nightly on Mac; Retina MBP with 1440x900 CSS-pixel resolution)
Sample: https://gist.github.com/jruderman/10072492

Closing as fixed. A lot of performance fixes have been merged in the meantime and I cannot reproduce the issue anymore using Firefox 36 on Windows. Even with text layer it renders quite fast (given that this is a huge PDF file to render). We have more open issues with similar files and issues, so this can be closed.

authors: jruderman timvandermeij


text:
[api-minor] Add basic support for PageLayout in the API and the viewer

Please see the specification, https://www.adobe.com/content/dam/acom/en/devnet/acrobat/pdfs/PDF32000_2008.pdf#G6.2393749, and refer to the inline comments for additional details.

/botio-linux preview

/botio unittest

Nice addition!

authors: Snuffleupagus timvandermeij


text:
Add ESLint rule for indentation

I find formatting a tedious and unproductive task. I often see in code reviews that you want the code indented properly.
I'm trying to understand all the rules you have in your mind and so far, I was able to form the following rules:

2 spaces are used for indentation
If array elements won't fit in one line, align the elements in the next line with the first element:const arr = ['baa', 'bab', bac',
             'bad', 'bae'];

If arguments in call expressions won't fit one line, align the arguments in the next line with the first argument: function foo(baa, bab, bac
              bad, bae) { ...

There are many cases in which this rule is being broken, for example  this.thumbnailButton.classList.toggle('toggled',
    view === SidebarView.THUMBS);

If parameters in function expressions won't fit one line, align the parameters in the next line with the first parameter: const result = foo(baa, bab, bac
                    bad, bae)

If object properties won't fit in one line, align the properties in the next line with the first property:const obj = { baa: 1, bab: 2, bac: 3,
              bad: 4, bae: 4 };

Switch case should be formatted like this:switch (case) {
  case 1: ...
  case 2: ...
}

Multiple variable declarations should align with the first one:const a = 0,
      b = 1;

This ESLint configuration enforces these rules.

I think it's really good to check what we can achieve with linting for formatting code, especially since automating this task will make code consistency and reviews easier. It looks like you're correct about most points. I'm not sure if we have a convention about the third point, since you also mentioned lots of variations here. I think it depends on the length of the line which one we choose, so we should either make a fixed choice or exclude that one from linting. Finally, we usually don't prefer multiple declarations on one line, and if we must then they should stay on one line. If it doesn't fit anymore, just make a new statement.

If we don't add the third rule for now, how many linting errors do we have left? If that is fixable, I would say that we can go for that.

If we're going to touch basically the entire code-base, then I think that we should do it the "right" way (to minimize unnecessary churn) and try to align a bit better with mozilla-central at the same time.
I've not had time yet, but will during Christmas, to look into using Prettier instead to end all formatting discussions once and for all. Hence I'd prefer that we WONTFIX this, since a better solution is available.

Ah! Prettier would be perfect. Looks like we're not gonna avoid a massive codebase modification anyway - after a lot of experimentation with these rules I ended up with ~5500 lines to be modified anyway. Which isn't too bad, but ain't minor as well.

@wojtekmaj Just a heads-up: we switched to Prettier in #11446, so code formatting should be less tedious now :+1:

authors: Snuffleupagus timvandermeij wojtekmaj


text:
Add a config file for tools like no_assignee and leave_open

Just add a file tools.json in auto_nag/scripts/configs which contains:
{
"no_assignee":
{
"receivers":
[
"calixte@mozilla.com",
"sylvestre@mozilla.com"
],
"days_lookup": 7
},
"leave_open":
{
"receivers":
[
"calixte@mozilla.com",
"sylvestre@mozilla.com"
],
"days_lookup": 7
}
}

Coverage increased (+0.5%) to 50.696% when pulling ca32776a7cd676d801593b276f3cf48f012709d8 on calixteman:perfect_world into 46f9596785d8d57386297c53153c6f5556ed6bb7 on mozilla:master.

authors: calixteman coveralls

repo: mozilla/relman-auto-nag


text:
Emit warnings only once, if not overridden by setting Shumway.loggingOptions.omitRepeatedWarnings to false

r? @yurydelendik

/botio test

@yurydelendik, this implements what we talked about yesterday. Additionally, there's now a function Shumway.Debug.warnCount() that you can use to dump a list of encountered warnings and their frequency. Quite useful in my short experimentations.
Excellent example of where this is useful: SWF 1575.

r+

authors: tschneidereit yurydelendik

repo: mozilla/shumway


text:
Display GUID in developper pages (bug 1119851)

https://bugzilla.mozilla.org/show_bug.cgi?id=1119851

Waiting on answers to https://bugzilla.mozilla.org/show_bug.cgi?id=1119851#c1

@clouserw r?

r+ thanks

authors: clouserw diox

repo: mozilla/zamboni


text:
fix: Fixes #18 missing bracket issue

Fixes #18 missing bracket issue

Thanks for fixing this. Merged.

authors: DoDzilla-ai mpatacchiola


text:
how to handle exception using Freshdesk API.

try{
$tickets = Freshdesk::tickets()->all(['tag'=>'Lead']);
dd($tickets);
}catch(\Exception $e) {
echo $response = $e->getResponse();
    }

its not showing error response ?
I am using Lumen and installed freshdesk sdk via composer

I had a similar issues and had to fork and modify the PHP SDK myself.
Api.php peformRequestMethod add this in the catch :
$actualError = $e->getResponse()->getBody()->getContents();
Then pass that to the ApiException
throw ApiException::create($e, $actualError);
Then modify the ApiException class to pass that error along in the __construct method.

authors: TheFrankman rameshwebmaster

repo: mpclarkson/freshdesk-php-sdk


text:
🛑 Tentus is down

In 1bea1ea, Tentus (http://tentus.dbperulab.com/) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Tentus is back up in 7013560 after 20 minutes.

repo: mperezdbperu/dbperu


text:
Non ascii keys

We have a number of existing non-ascii keys, so this allows us to enable non-ascii support via the :nonascii option.

It looks like this is legacy from the old text protocol where keys were not allowed to contain "whitespace or control characters".  We can just remove the restriction altogether - I think the only restriction should probably be length.
If you want to update your pull request to do this, go ahead.  Otherwise open another issue and I'll fix it sometime this week.

Any plans to pull this into an upcoming release? Thanks!

authors: amdtech mperham remen

repo: mperham/dalli


text:
dynamic addScene in a loop

Hi I want to add scenes to my pano viewer with some data from my backend server. Though I get a value of this.xmlItems[i].rotation inside the loop, I'm unable to assign it to yaw or any other property. Is there a way to achieve this?
I'm getting the following error :
TypeError: Cannot set property '2' of undefined     at Viewer.addScene (node_modules\pannellum\src\js\pannellum.js:2873)
My code looks like this:
       this.v =  pannellum.viewer('panorama', {            "default": {             "firstScene": "1",             "author": "default",             "sceneFadeDuration": 1000,             "autoLoad": false,             "scenes": {}         }       });       for (i=0; i<this.xmlItems.length; i++) {           //var camYaw = this.xmlItems[0].rotation;           console.log("pano yaw"+this.xmlItems[i].rotation);           this.v.addScene(i,{             "hfov": 120,             "pitch": -10,             "autoload": true,             "yaw": this.xmlItems[i].rotation,             "type": "equirectangular",             "panorama": "assets/images2/"+this.xmlItems[i].path,             "hotspots": [ ]           });           //console.log("addscene:"+v.getScene());         };         this.v.loadScene(1,-10,180,120);

Figured out to make it work, but on addScene & addHotSpot the viewer stops working for the scene rotation: both for  startAutoRotate=true or on drag, is there a way to fix this?

You can't initialize the viewer without a scene. Since you seem to know all your scenes ahead of time, you should construct a configuration object with all of the scenes and then initialize the viewer with it instead of using the addScene method.
As for your second question about scene rotation, you're going to have to be more specific. I don't have any issues with addScene or addHotSpot stopping the viewer.

You can't initialize the viewer without a scene. Since you seem to know all your scenes ahead of time, you should construct a configuration object with all of the scenes and then initialize the viewer with it instead of using the addScene method.
As for your second question about scene rotation, you're going to have to be more specific. I don't have any issues with addScene or addHotSpot stopping the viewer.

After adding a scene by addScene() or after adding a hotspot by addHotspot(), the scenes aren't loaded by itself, the image loads when I go into the scene, but blacks out if I click/drag.
I added loadScene() after each of them,
```
for (i=2; i<this.xmlItems.length; i++) {
    var path1 = "assets/images2"+this.xmlItems[i].path.slice(1);
    var sceneId = i+1;
    this.v.addScene(sceneId,{
      "sceneFadeDuration": 1000,
      "title": "360 Virtual Tour",
      "hfov": 120,
      "pitch": -10,
      "autoload": true,
      "yaw": this.xmlItems[i].rotation,
      "type": "equirectangular",
      "panorama": path1,
    });
    console.log(this.v.isLoaded());
    this.v.loadScene(sceneId);
    console.log(this.v.isLoaded());
  }

But both the `v.isLoaded()` gives me a false result.

So I also tried it with `sceneChangeListener()`

this.v.on('scenechange', this.sceneChangeListener.bind(this));
sceneChangeListener(event: any) {
console.log("Scene " + this.v.getScene());
this.v.loadScene(this.v.getScene(),-10,180,120);
console.log(this.v.isLoaded());
};
Still I'm receiving false for v.isLoaded(), the loadScene doesn't seem to be working either in both the cases and the scene fades out to a blank screen on click/drag. It would be extremely helpful if you could guide me to a solution/workaround for this issue.

I also tried this, but the same issue is persisting, any solution to this?

repo: mpetroff/pannellum


text:
Phenotype dataset issue

This issue concerns the anophthalmia phenotype reported for 1700034E13Rik<em1(IMPC)Mbp> on the abnormal eye morphology page
https://nginx.mousephenotype-dev.org/data/phenotypes/MP:0002092
The supporting data link is throwing an error because the request for the dataset returns a 404.

The statistical results mapper is failing to generate a dataset description for this PAT dataset.
This is one of those cases where the pathologist has assigned both the specific term and the general term to a single specimen. It probably has something to do with that, maybe the dataset id generation should include the mp_term to manage this cases, I think at some point the de duplication is being done by using the id, and these 2 datasets have the same values for the idetifying columns used on the id generation.

Noticed a different issue, the PAT service JSON data has not parameter name which generates an empty anatomy value in the table for the pathology data.

authors: ficolo rwilson-ebi


text:
Allow specifying the GHC to be used for the cabal cradle

A standard idiom is cabal new-configure --with-compiler=ghc-8.8.2.
Given a hie.yaml file is intended to set up the local developer's intentions, we should be able to specify the GHC compiler version with a cabal cradle.
As a side-effect, this can help tooling like hie and its successors to choose an appropriate version to run.

I would like to take this on. It seems like a relatively easy task. What do you think?

That sounds nice! However, designing a nice API doesnt sound as easy. Also, we got to think about https://github.com/mpickering/hie-bios/issues/44 of which this could be an extension. In a different approach, we could use cabal-install-parsers in hie/ghcide/hls to find the ghc version automatically.
I am happy for PR's but would like to discuss design ideas such as modifications in hie.yaml as well as changes in the types before.

Has there been any progress on #44 ?

I have been implementing a prototype but there is not much to show at the moment.
First step would be discussing an hie.yaml format for it and should it be a global option, per cradle, etc... A lot to discuss. If you have any ideas, you can write them in #44!

@alanz Would it be better if hie-bios honours the configuration in cabal.project, etc... or if it was possible to specify the ghc version in hie.yaml?

both? 😝

Not sure if both is really nice. E.g. cabal configure -w ghc-8.6.4 but you specify a different ghc in hie.yaml?

Hmm, I have been mentally using a workflow where the cabal.project is under version control, and is "general", without specifying the GHC version.  This simplifies things like CI.
Then when working with a particular GHC version you configure it to use that. And I guess the same effect comes from using cabal.project.local.
But I have had experiences where I am working on a project which I manually configured with one version of GHC (say ghc-8.8.2), and then hie-bios periodically reconfigures it with the "default" ghc, being 8.6.5. So you end up fighting with it.

Yes, and I think the most intuitive approach would be that hie-bios uses the correctly configured version from cabal.project.local. However, if it does that, a custom field in hie.yaml would be superfluous.

closing as duplicate in favor of #194 (As there is a technical discussion on how to accomplish and a linked pr)

authors: alanz fendor jneira sureyeaah

repo: mpickering/hie-bios


text:
Ramdom number generator doesn't work with 10 characters

Error:
[InvalidArgumentException]
randomNumber() can only generate numbers up to mt_getrandmax()
Random Generator doesn't work with 10 characters when using validation digits:10

In case you haven't sorted this out, I've got an open PR that addresses this issue. It should sort you out

Merged your PR

authors: kavanpancholi mpociot travoltron

repo: mpociot/laravel-apidoc-generator


text:
Error with lumen 5.6 running php artisan api:generate --routePrefix="api/v1/*"

Running this command php artisan api:generate --routePrefix="api/v1/*" generates following error
In GenerateDocumentation.php line 259:
Call to a member function getName() on array

@nerijunior
@mpociot
@lucasmichot
@grinry

Check out this fork which has support for Lumen using Dingo Router:
https://github.com/davmixcool/lumen-apidoc-generator
Installation:
composer require davmixcool/lumen-apidoc-generator
Go to your bootstrap/app.php and register the service provider:
$app->register(Davmixcool\ApiDoc\ApiDocGeneratorServiceProvider::class);
See repo for more info

@davmixcool would you consider integrating your fork back into this project? This package currently doesn't support Lumen (and DIngo support is quite limited), so that would be a big help.

@shalvah, this issue is still present in the latest release with lumen. It causes an error on GenerateDocumentation.php on line 275. This issue is caused by the lumen Router class. The getRoutes() function does not return a RouteCollection but a JSON array. Causing this tool to break there.

@Svenh98 this project currently doesn't officially support Lumen. It's on the roadmap for version 3, which we'll start work on soon.
(Also, I don't think your error is on line 275. The contents of that line:
https://github.com/mpociot/laravel-apidoc-generator/blob/af9da31ea5cac7c0caed3274c239b4cf3b19a741/src/Mpociot/ApiDoc/Commands/GenerateDocumentation.php#L275
)

authors: Svenh98 amjad-eremnews davmixcool napestershine shalvah


text:
Add validation of name and email

This PR adds a request validation to the controller stubs for the name and email entered by the user when creating a team or an invite.

Codecov Report

Merging #89 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #89   +/-   ##
=======================================
  Coverage   76.12%   76.12%
=======================================
  Files          15       15
  Lines         356      356
=======================================
  Hits          271      271
  Misses         85       85

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ffea927...57b80db. Read the comment docs.

Would you like to resolve the conflicts? I caused them by changing some things. Sorry about that :/

@okaufmann I can't because I have deleted my fork :/

Ok, then I'll take your changes right in a commit. Thanks :)

It's now included https://github.com/mpociot/teamwork/commit/fee391ad7392d647b84fee54f14a0743671d5e13
Thanks again!

authors: Jeroen-G codecov-io okaufmann

repo: mpociot/teamwork


text:
created a css file for the styling and re-arrange the html layout

created a new css file for the styling and re-arrange the layout.
by doing this it makes the code to be easily read and understand

Could you post some screenshots so that others can easily spot what this is all about without trying it themself first? Thanks!

authors: Faruqoloyede dumblob

repo: mprimi/portable-secret


text:
Feature/add maven publish to build

Motivation
Enable publishing of the artefacts by using the gradle maven-publish plugin
Changes
Added maven-publish plugin and publishing config for JAR, sources and docs
Corrected JavaDoc errors which were preventing the javadoc task from succeeding

@SgtSilvio your changes look good to me 😊👍

repo: mqtt-bee/mqtt-bee


text:
Create a file that maps top FIBers to the iffy list used to find them

For the FB download, this could be built into the script.
For the Twitter pipeline, this will need to be thought through a bit..

This will be captured in the database so I am closing this.

repo: mr-devs/top-FIBers


text:
Added CodeComplete2 book into practice section

Great book on programming practice and approach. Added to Practice section.

Thanks for contributing, but I am gonna pull out "opinionated" card here. I have just reread the CC book and I do not find it as valuable as most people say. The content is quite diluted.

authors: asdevgit mr-mig

repo: mr-mig/every-programmer-should-know


text:
styling changes in quick action buttons

Namely makes the margins a little more consistent and uses the discord icon instead of the person one for discord server links

Not needed anymore.


text:
Showing 2 Stations

Hello mrVragec,
I want to show two different stations.
One for me and one for my wife.
I was trying to load the module twice but then it shows the data for one station in both modules.
All the different settings how ever apply to both modules differently.
Also tried adding an array into the station field like [StationA, Station], but I guess this is not supported. So I also tried renaming everying in your module to mvgmunich2 but then this model will not start.
My Linux and JavaScript skills are limited but I am not new to programming. I would be thankful for a little bit of direction. I am even willing to help developing if needed.

Hello @ipien,
this was already a problem in the past, which was successfully solved (issue #7).
I will check again and try to fix it :).

Hi @ipien,
there is a new branch (name 'showing_2_stations') in which your problem should be solved.
Would be possible to test it?

Thank you for looking into it so quickly.
Unfortunately it is not working for me.
I downloaded the "showing_2_station" branch with:
git clone --single-branch showing_2_stations ...
into my new MagicMirror folder then I copied my config.js from my backup there.
It shows me the same as before. Is there a way I can see if I downloaded the correct files?
I will try posting my config soon maybe I did something wrong there.

If you prefer the text itself then I can copy this as well for you.
But for a quick check this should be fine.

I just noticed that I did not use your new code.
In the beginning if shows until the first update time for me 30 seconds - undefined
The it shows me the two different stations.
Thank you so much!

But somehow not 100% correct.
I have set the second station to show only tram and ubahn and I can see them but only 2 entries even though I selected 4 (maxentries)I guess this is new issue.
Total count with all different vehicle classes is probably 4.

Yes, there is a bug with counting shown stations :) Just saw it when testing your configuration,
I will take care of it.

Thank you so much. You are doing a great job.

Hey @ipien, can you please pull from the branch 'showing_2_stations', the problem with number of visible stations should be solved.

Perfect thank you. Yes this is solved now!
And no error messages ;)

authors: ipien mrVragec

repo: mrVragec/MMM-mvgmunich


text:
🛑 ABB Restore is down

In 4a04798, ABB Restore (https://backup.$DOMAIN) was down:

HTTP code: 0
Response time: 0 ms

Resolved: ABB Restore is back up in efd8e89.

repo: mrdavidkovacs/status


text:
[Question] Delay/Grace Period

Hi , I am using firefox 54 x64
Any plans on taking full advantage on firefox and allow delay values in secounds ?
instant cleanup may break some sites and 6s is quite long compared to 2s ( ͡° ͜ʖ ͡°)
Thanks

2/60=0.03 minutes
I know it probably not the most user friendly option but as long as Chrome has a minimum timer of 1 minute, I have to make it constant across browsers. At least, FF doesn't have this limitation.

Tbh didn't thought of using 2 decimal digits... now i feel stupid xD
Works and well made , great successor for sdc
thanks again , should've tried before asking but it seems you guys already thought about everything : )

you guys already thought about everything

Mostly it's just me doing all the code and a couple of volunteer translators, but thanks, and enjoy 1.4.0 which gets pretty close to SDC now. The only thing left is localstorage support. Everything else is basically bonus.

@mrdokenny
For some reason i tried to make CAD 1.4.0 to work with 2s (0.03)  on chrome 59.0.3071.115 (Official Build) (64-bit) and it seems that its working just fine ... google may had removed the limit
Awesome news ( ͡° ͜ʖ ͡°)

authors: RandomGOTI mrdokenny

repo: mrdokenny/Cookie-AutoDelete


text:
added Designite

I have added a software design quality assessment tool Designite.

Thanks for the pull request. :smiley:
The list is sorted alphabetically. Could you change the order of your entry before I merge it?

I just changed the order as per your suggestion.
Thanks in advance :)

Thank you. Merging :-)

authors: mre tushartushar

repo: mre/awesome-static-analysis


text:
Unable to start with this project.

Trying to install and run this, and following these steps mentioned in this page: http://coreui.io/docs/getting-started/vue-js-version/
But wen I'm running npm run dev It is returning following error:
module.js:538
    throw err;
    ^

Error: Cannot find module 'shelljs'
    at Function.Module._resolveFilename (module.js:536:15)
    at Function.Module._load (module.js:466:25)
    at Module.require (module.js:579:17)
    at require (internal/module.js:11:18)
    at Object.<anonymous> (/var/www/cc-server/TaxiWala/public/admin/CoreUI-Vue/Vue_Starter/build/check-versions.js:4:13)
    at Module._compile (module.js:635:30)
    at Object.Module._extensions..js (module.js:646:10)
    at Module.load (module.js:554:32)
    at tryModuleLoad (module.js:497:12)
    at Function.Module._load (module.js:489:3)
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! @coreui/vue@1.0.8 dev: `node build/dev-server.js`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the @coreui/vue@1.0.8 dev script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
npm WARN Local package.json exists, but node_modules missing, did you mean to install?

npm ERR! A complete log of this run can be found in:
npm ERR!     /root/.npm/_logs/2018-01-17T17_02_13_943Z-debug.log

(I'm New in Node and Vuejs)

Cannot reproduce.
You've got no such file or directory error in node_modules/node-sass/vendor see also #53
Sometimes things go wrong with npm install
please try:

remove node_modules directory
remove package-lock.json file
then npm install

@jaideepghosh If you're Windows user and using git bash, switching to powershell apparently resolves this issue.

authors: jaideepghosh stranger26 xidedix

repo: mrholek/CoreUI-Vue


text:
feat: allow arbitrary Lua functions without mapping to a command

Resolves: #149
How to Test
Create/bind a function such as
require("legendary.bindings").bind_functions({
  {
    function(args)
      if args then vim.pretty_print(args) end

      vim.lsp.buf.code_action({
        filter = function(a)
          return a.isPreferred
        end,
        apply = true,
      })
    end,
    description = "Auto Fix...",
    opts = { buffer = bufnr },
  },
}, "LSP")

Check that it's displayed in the menu and correctly called. Further, if opts.buffer is set, then it should be available only for the specified buffer. If you're in visual mode, the function above should also print the selection range.
Testing for Regressions

[x] Creating keymaps via legendary.nvim, then triggering via the keymap in all modes (normal, insert, visual)
[x] Triggering keymaps from legendary.nvim in all modes (normal, insert, visual)
[x] Triggering commands from legendary.nvim in all modes (normal, insert, visual)

I'll write proper commit messages later.

Description is generated as string | nil but should be just string, since it's required.
https://github.com/mrjones2014/legendary.nvim/pull/158/files#diff-200ca7c4c61c7a392bab8641d7c2234d3111c5810849c6ead1138ea0420e39d2R245
https://github.com/mrjones2014/legendary.nvim/pull/158/files#diff-186ee35de9b71f106af6ad4912bbd15860373e2298994cb381f36bb43c959e6aR51

This looks pretty good, thanks! I can give a more thorough review tomorrow, busy with family  day today. And thanks for fixing my typos 😝

And thanks for fixing my typos stuck_out_tongue_closed_eyes

Don't think it was me, I just ran gen-api-docs =P

Thanks for the PR!


text:
Dark screen

It got this screen when i'm downloaded lasted version of Terrafirma

I can use menu bar, but notthing happen!
Terraria version: 1.3.7
Terrafirma: 3.0.5

What happens if you turn off Fog of War in the menubar?

The bug still exists for me :/ (I know, that this is old, but I only want to let you know) Even when I switch Fog of War...

It was a problem with some variable names in the shaders.  It was just fixed.

authors: ThexXTURBOXx mrkite percynguyen92

repo: mrkite/TerraFirma


text:
cda.pl nie daje rady

W środę (6 kwietnia) nasze serwery po raz kolejny pod naporem kilkuset tysięcy internautów odmówiły posłuszeństwa. Czekamy na nową infrastrukturę, dzięki której mamy nadzieję osiągniemy prędkość światła. Szacujemy, iż nowe serwery będą w stanie udźwignąć 300.000 osób jednocześnie korzystających ze strony. Nowe maszyny będą miały łącznie aż 6144 GB RAM i ultra szybką światłowodową sieć wewnętrzną. Przepraszamy za ostatnie przerwy w działaniu serwisu i dziękujemy za korzystanie z cda.pl

Przepraszam mam Pytanie..: Jest możliwość Pooglądać Polski Film Pitbull nowe porządki gdzieś na Necie. Nie mieszkam w Polsce......:(

@Adam-po jeszcze niema!

authors: Adam-po xxcriticxx

repo: mrknow/filmkodi


text:
CPU Utilization metrics missing

Is there a way to retrieve CPU utilization metrics from iDRAC? This metric appears to be missing from the exporter. I have also tried using the Redfish API, but it does not seem to be available there either. If there's another method to access these metrics, please let me know. Thank you!

Hi @Rohith-Scalers
I have not checked thoroughly, but I do not believe this is part of the Redfish specification. I think there are some non-standard vendor specific implementations. However, I would argue that this kind of information should be scraped from the operating system, e.g. using the node exporter, which in any case will contain more reliable information.

Thank you @mrlhansen

authors: Rohith-Scalers mrlhansen


text:
❓ Is there a way to access actual bytes of a frame from js?

Question
Say, I want to do some basic image recognition in pure js.
The only option Im seeing right now is doing takePhoto so it saves it to a file, and then using react-native-fs to access actual data from this file
What I tried
No response
VisionCamera Version
2.13.2
Additional information

[ ] I am using Expo
[X] I have read the Troubleshooting Guide
[X] I agree to follow this project's Code of Conduct
[X] I searched for similar questions in the issues page as well as in the discussions page and found none.

Hey!
I experimented with exposing actualy bytes to the JS Runtime, but it turned out to be really slow and JS simply isn't fast enough to process information quick enough.
Frame Processor Plugins are native and fast, while still being relatively simple.

authors: Overtorment mrousavy

repo: mrousavy/react-native-vision-camera


text:
Player Names

Hello, This isn't really an Issue but I'm posting it here. I also emailed you just in case. How would I go about adding the player's name above their heads on the live map? Is that in the API or Livemap.js?
Thanks.

@zippy4
This has been added in the most recent commit.

repo: mrtwidget/Livemaps


text:
"Unlocked" the SERVO pinMode

The SERVO mode was ready to use on the StandardFirmata. By stopping to ignore the Servo PinMode I successfully attached servos and sent commands to them without any issues

Hi @marcodiniz, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, MSBOT;

Thanks marcodiniz! It looks like this may have been an oversight during refactoring of the analogWrite function. Good catch, and the fix looks good so far. I will test this as soon as possible and approve the PR once I am able to verify the functionality!

@turkycat Post back when tests are complete, and we'll get this pulled in.

Tested well on multiple configurations! @ooeygui go ahead and pull! @marcodiniz Thanks for the contribution!! :D

great! thanks!

authors: marcodiniz msftclas ooeygui turkycat

repo: ms-iot/remote-wiring


text:
Regression

Implements Proposition 5.6 from issue #10 .
The sampling appears to be a slightly shifted.

with different seed:

Wo wir aufpassen müssen: In einer früheren Version fehlt die Matrix inv(a) in der Gleichung für mu:

Richtig ist

with smaller noise value:
par = [-0.2, 0.1, 0.09]

tend = 20 Plot

Looks good.

authors: frankschae mschauer


text:
🛑 Do53 Roost IPv4 UDP is down

In 33e3fbc, Do53 Roost IPv4 UDP (http://107.189.10.142:9202) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Do53 Roost IPv4 UDP is back up in 0edbd01 after 18 minutes.

repo: mschirrmeister/upptime-loopx


text:
🛑 Do53 Roost IPv4 TCP is down

In 2046112, Do53 Roost IPv4 TCP (http://107.189.10.142:9203) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Do53 Roost IPv4 TCP is back up in 3426a48 after 1 hour, 27 minutes.


text:
🛑 Do53 Roost IPv6 TCP is down

In 8f79f60, Do53 Roost IPv6 TCP (http://107.189.10.142:9205) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Do53 Roost IPv6 TCP is back up in 2977f4d after 25 minutes.


text:
🛑 Do53 Roost IPv6 TCP is down

In adcf751, Do53 Roost IPv6 TCP (http://107.189.10.142:9205) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Do53 Roost IPv6 TCP is back up in 547a919 after 9 minutes.


text:
Add missing dependencies to NuGet packages

Add missing .NETStandard2.0 dependencies to NuGet package. The System.CodeDom reference, in particular, is causing this issue and probably #283, too.
(edit: grammar)

Thank you!
Would you make more PR again for master branch?

I am new on c# could you please write out which package i need to install, and how

why I didn't see .NETStandard2.0 from NuGet, could you please explain clearly?

@yichunzhao
Could you give actual error message text which you saw?
I believe that all dependent package should be listed in nuspec file, but something went wrong in your environment unfortunatelly, so I may help you if you give more information.

authors: lucaspimentel yfakariya yichunzhao

repo: msgpack/msgpack-cli


text:
После запуска контейнера открываю сайт http://localhost:8000/ получаю ошибку Array['errMessage'], что делать?

Добавьте в скрипт https://github.com/mshegolev/congenial-potato/blob/main/cinema/BD/id11870327_mysite.sql предварительное удаление таблиц и ограничений, перед созданием новых.
Предварительные действия:

Открыть http://localhost:8081/ логин admin пароль test
Выбрать база данных database.
Перейти на вкладку SQL.
Открыть скрипт https://github.com/mshegolev/congenial-potato/blob/main/cinema/BD/id11870327_mysite.sql
Скопировать данные из скрипта и вставить в окно SQL.
Выполнить скрипт (нажать кнопку Вперед/Запустить в русской версии или run) Если с первого раза скрипт не выполнится,
то запустить повторно убедившись что подключились к базе данных database.
Открыть сайт http://localhost:8000/client/index.php убедиться что доступен выбор фильмов.

Суть проблемы:

При добавлении данного скрипта https://github.com/mshegolev/congenial-potato/blob/main/cinema/BD/id11870327_mysite.sql  , выскакивает ошибка о уже созданных ранее (но пустых, без данных) таблицах.
При ручном предварительном удалении всех таблиц и ограничений БД, - скрипт сработал как надо.

Windows 10.
Coogle Chrome Версия 115.0.5790.171 (Официальная сборка), (64 бит).
Docker Compose version v2.13.0

Добавлено удаление таблиц перед их созданием.
-- удаляем таблицы если созданы
drop table films;
drop table halls;
drop table sales;
drop table seances;
drop table users;

authors: Nephedov mshegolev

repo: mshegolev/congenial-potato


text:
Cannot load module 'IntuneMAMWalledGardenSwift' as 'IntuneMAMSwift'

Hi All,
When I download zip file and open in Xcode 10.2.1, I got this error.
I didn't change anything.
Cannot load module 'IntuneMAMWalledGardenSwift' as 'IntuneMAMSwift'
Could you please suggest?
Meanwhile, could i please know if it support Xcode 11 now?

Xcode 11 is not supported on current version of sdk: https://github.com/msintuneappsdk/Chatr-Sample-Intune-iOS-App/issues/48
Regarding this error: I solved by updating the IntuneMAMSwift.framework and IntuneMAMSwiftStub.framework to the latest version (11.2.0 has the fix). You can use a dependency manager (cocapods) but I manually copied it over by downloading this zip for sdk and replacing the framework files with the update versions here: https://github.com/msintuneappsdk/ms-intune-app-sdk-ios

Hey @leonzhuyihong, this is a known issue in version 11.1.2 of the SDK which we addressed in version 11.2.0. The issue is specific to simulator, so you should be able to build for a physical device. Alternatively, you can upgrade to 11.2.0 to build for both simulator and device.
Note: As @slnali mentioned, you'll need to build with Xcode 10 for now as we have not yet released a version of our SDK which supports Xcode 11. We're working on addressing that and will update the sample repo as soon as that happens.

Hi All,
Appreciate of prompt reply!
Just replace SDK to 11.2.0 and error gone.
Thanks All!

Hey @leonzhuyihong, I just updated the sample to use the latest release of the Intune MAM SDK (12.0.12), which supports Xcode 11. Both issues should be resolved now.

authors: Kyle-Reis leonzhuyihong slnali


text:
QXcbConnection: Could not connect to display

While I was running python ./rfcn/demo.py
errors occurred:

testing COCO_test2015_000000000891.jpg 0.2425s
QXcbConnection: Could not connect to display
Aborted (core dumped)

just download Xmanager fixed the problem

repo: msracver/Deformable-ConvNets


text:
A bunch of letterforms are missing from defaultLetterMap

As near as I can tell, there are quite a few letterforms missing from the defaultLetterMap.
λ> sort $ M.elems $ OCR.getLetterMap OCR.defaultLetterMap
"AABBCCEEFFGGHHIJJKKLLNOPPRX"

It looks like it's missing one of the Rs, the U, the Y, and both Zs.

I think the problem is that spurious spaces are getting into the string literal somehow:
λ> raw1 = bimap id (filter (/=' ')) $ OCR.rawLetterforms1
λ> sort $ M.elems $ OCR.getLetterMap $ uncurry OCR.parseLetterMap raw1
"ABCEFGHIJKLOPRUYZ"

Maybe a problem with heredoc?

Ah, thank you...this is definitely interesting, and concerning!  I wonder what is going on here...it does sound like it could be a problem with the heredoc.  I should probably also build some fuzz testing for this instead of relying on some built in forms.

I've added a filter to the heredocs, this seems to resolve the issue for now. But I do wonder what's happening.

Ah! It might be a locale thing, since checking defaultLettermap on my machine gives the full alphabet.  What OS are you using?

I'm on MacOS 10.13.

hm..definitely interesting.
i'm closing this issue because I've implemented the filtering change mentioned, but it would be interesting to investigate this further on the heredoc side. thanks opening!

authors: gilgamec mstksg

repo: mstksg/advent-of-code-ocr


text:
🛑 mtbn.fr is down

In a86695d, mtbn.fr (https://mtbn.fr) was down:

HTTP code: 503
Response time: 1115 ms

Resolved: mtbn.fr is back up in cbcf12e.

repo: mtauban/parcelle-uptime


text:
the Package has problems with latest gradle-7.3.3 version , and here what i get

FAILURE: Build failed with an exception.

What went wrong:
Execution failed for task ':camera_deep_ar:bundleDebugAar'.

Error while evaluating property 'hasLocalAarDeps' of task ':camera_deep_ar:bundleDebugAar'
Direct local .aar file dependencies are not supported when building an AAR. The resulting AAR would be broken because the classes and Android resources from any local .aar file dependencies would not be packaged in the resulting AAR. Previous versions of the Android Gradle Plugin produce broken AARs in this case too (despite not throwing this error). The following direct local .aar file dependencies of the :camera_deep_ar project caused this error: C:\src\flutter.pub-cache\hosted\pub.dartlang.org\camera_deep_ar-0.0.2+3\android\lib\deepar0.aar

related to https://github.com/mtellect/CameraDeepAR/issues/24#issue-1091689008
kindly check the branch dev/example to see implementation

Yes , i used old version of gradle then it is work , but it is not work
with latest version
في الثلاثاء، 25 يناير 2022 في 4:38 م تمت كتابة ما يلي بواسطة Maugost <
@.***>:

related to #24 (comment)
https://github.com/mtellect/CameraDeepAR/issues/24#issue-1091689008
kindly check the branch dev/example to see implementation
—
Reply to this email directly, view it on GitHub
https://github.com/mtellect/CameraDeepAR/issues/35#issuecomment-1021191620,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AUVKOXH5YOQ2ALOEMJCGTB3UX2RWJANCNFSM5MYIUPYA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you authored the thread.Message ID:
@.***>

nothing related with dev/example 😊
في الأربعاء، 26 يناير 2022 في 1:50 ص تمت كتابة ما يلي بواسطة Mohammed
Hamdan @.***>:

Yes , i used old version of gradle then it is work , but it is not work
with latest version
في الثلاثاء، 25 يناير 2022 في 4:38 م تمت كتابة ما يلي بواسطة Maugost <
@.***>:

related to #24 (comment)
https://github.com/mtellect/CameraDeepAR/issues/24#issue-1091689008
kindly check the branch dev/example to see implementation
—
Reply to this email directly, view it on GitHub
https://github.com/mtellect/CameraDeepAR/issues/35#issuecomment-1021191620,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AUVKOXH5YOQ2ALOEMJCGTB3UX2RWJANCNFSM5MYIUPYA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you authored the thread.Message ID:
@.***>

authors: bermohmtnm mtellect

repo: mtellect/CameraDeepAR


text:
Add Support for Polygon

Added function to translate a Polygon which allows Polygons to be used as shapes in calls to tikz().
Updated examples to include a call to Polygon()

Woops just noticed this, I guess I'm not getting notifications for this repository. Looks good, thanks!


text:
🛑 https://hcie.ps is down

In 7c26b4a, https://hcie.ps (https://hcie.ps) was down:

HTTP code: 0
Response time: 0 ms

Resolved: https://hcie.ps is back up in 40e8e53.

repo: mtitservice/site


text:
🛑 https://mtit.pna.ps is down

In 1e2d473, https://mtit.pna.ps (https://mtit.pna.ps) was down:

HTTP code: 0
Response time: 0 ms

Resolved: https://mtit.pna.ps is back up in 7ebf332.


text:
🛑 https://moj.pna.ps is down

In 5799112, https://moj.pna.ps (https://moj.pna.ps) was down:

HTTP code: 0
Response time: 0 ms

Resolved: https://moj.pna.ps is back up in ba38aaf.


text:
🛑 https://detulkarm.edu.ps is down

In 7594969, https://detulkarm.edu.ps (https://detulkarm.edu.ps) was down:

HTTP code: 0
Response time: 0 ms

Resolved: https://detulkarm.edu.ps is back up in 72129c5.


text:
🛑 https://reports.mtit.pna.ps is down

In 43c44be, https://reports.mtit.pna.ps (https://reports.mtit.pna.ps) was down:

HTTP code: 0
Response time: 0 ms

Resolved: https://reports.mtit.pna.ps is back up in ebc6cb5.


text:
🛑 https://treport.mtit.pna.ps is down

In 0f1b4de, https://treport.mtit.pna.ps (https://treport.mtit.pna.ps) was down:

HTTP code: 0
Response time: 0 ms

Resolved: https://treport.mtit.pna.ps is back up in 6b7344c.


text:
🛑 https://verify.moj.pna.ps is down

In 7f4265d, https://verify.moj.pna.ps (https://verify.moj.pna.ps) was down:

HTTP code: 0
Response time: 0 ms

Resolved: https://verify.moj.pna.ps is back up in c523ef2.


text:
🛑 https://treport.mtit.pna.ps is down

In e1bd416, https://treport.mtit.pna.ps (https://treport.mtit.pna.ps) was down:

HTTP code: 0
Response time: 0 ms

Resolved: https://treport.mtit.pna.ps is back up in 6d1e7c4.


text:
Change backed up saves order in context menu to descending

Currently they are ordered in ascending order, from oldest to newest.

May I suggested if the order could be changed to descending, meaning, from newest to oldest from top to bottom? I think it would make more sense that way to have listed the most recent one first.

Makes sense to me :+1:

authors: darklinkpower mtkennerly

repo: mtkennerly/ludusavi-playnite


text:
If recording is stopped early while recordingDuration property is set, a second stop occurs

line 231 of RecordRTC.js
    function handleRecordingDuration() {
        setTimeout(function() {
            stopRecording(self.onRecordingStopped);
        }, self.recordingDuration);
    }

This timeout is set, but it is not cleared if the recording is stopped via another method.  For example, if you wish to limit the size of the output by limiting the length of the recording while still allowing users to stop or pause the recording early.

Here's something you could use:
https://gist.github.com/jpehman/09922ceec9798bcde3748da84fa64868

Thanks for fixing this :)

repo: muaz-khan/RecordRTC


text:
How to modify Video tag's ID

Hi,
I'm trying to put certain restrictions in which videos can a user see in the SIgnalR video conference, and I though of doing it by using my own especific IDs for the streaming video tags, but I can't fully understand how you created the tags in RTCMultiConnection.js
Can you please help me see where to modify?

onstream event: https://www.rtcmulticonnection.org/docs/onstream/
connection.onstream = function(event) {
    var videoTag = event.mediaElement;

    if (event.type === 'local') {
        videoTag.id = 'set-id-yourself';
    }

    if (event.type === 'remote') {
        videoTag.id = 'set-id-yourself';
    }

    // append to <body>
    document.body.appendChild(video);
};

OR create HTML element yourself:
connection.onstream = function(event) {
    var videoTag = document.createElement('video');
    videoTag.controls = true;
    videoTag.autoplay = true;
    videoTag.muted = event.type === 'local'; // fix echo

    if (event.type === 'local') {
        videoTag.id = 'set-id-yourself';
    }

    if (event.type === 'remote') {
        videoTag.id = 'set-id-yourself';
    }

    // append to <body>
    document.body.appendChild(video);
};

Every MediaStream object has a unique-ID. Defined as SSRC object in the SDP. Here is how to use that unique-id:
connection.onstream = function(event) {
    var videoTag = event.mediaElement;

    videoTag.id = event.stream.id;

    // append to <body>
    document.body.appendChild(video);
};

Or detect who is sending the video:
connection.onstream = function(event) {
    var videoTag = event.mediaElement;

    if (event.type === 'remote') {
        if (event.userid === 'someone-username' || event.extra.fullName === 'Mr. Bean') {
            videoTag.style.border = '5px solid red';
            videoTag.id = 'vip';
        }
    }

    // append to <body>
    document.body.appendChild(video);
};

Check the doc here: https://www.rtcmulticonnection.org/docs/onstream/

I think that what I need is that Extra property, but when I tried putting data in it locally, it does not arrive to the remote peers

Once you add extra property you need to update connection.
connection.extra.videoTagId = "yourId";
connection.updateExtraData();

authors: Jhordan92 mohamadhussain muaz-khan

repo: muaz-khan/WebRTC-Experiment


text:
Section titles not wrapping

Issue
When creating sections in descriptions, if the section title is too long, it will not wrap.
[[This is a very long section title that will not wrap]] {
See, no wrapping.
}

Resolved in PR #100

repo: mucklet/mucklet-client