text:
✨  Add editor.config to vscode to get consistent YAML across team members

User Story
As a CoP
I expect we tab and space the same
So that our YAML is consistent 🕙
Value / Purpose
Tabs vs Spaces ¯_(ツ)_/¯ as long as we are consistent!
Useful Contacts
No response
Additional Information
We can look at YAML linting
Definition of Done

[ ] editor config is created
[ ] applied to all devs machines
[ ] applied to repo's

We've elected to close this issue with no action, we haven't hit this as an issue in a while and think it should be caught by the YAML linters in the event it's needed.

repo: ministryofjustice/nvvs-devops


text:
Make failed auth url configurable

Add config to Helm
Add config to config file
All url to be injected to allow testing

Do we want to tightly couple our auth flow with the CMS? I can see it has some benefits by allowing other members of the team to add content, but it feels like a frontend system flow, and feels distinct from CMS content.
As an example, I would expect the auth failure to be reported correctly if we switched to a new CMS, or had a test environment with no content.

@spikeheap it's configurable? It's not tied to anything 😕

@spikeheap it's configurable? It's not tied to anything 😕

What I'm getting at is that it won't work without those CMS pages, so our frontend auth flow demands a specific piece of content exist in the CMS for the auth flow to work (or rather, fail) correctly.
What makes me uncomfortable is that we're taking something that (I believe) is an integral part of the frontend auth flow, and shifting that concern into the CMS.
As an example, we've talked about being able to fire up a vanilla version of the Drupal instance for development/test environments. To have a functional (albeit empty) site, this change introduces the need for us to create at least one page.

source: gharchive/pull-request

authors: psoleckimoj spikeheap

license: MIT

license_type: permissive

license_source: github-api